Invalid Pass Pipeline

Hi,
Thanks for reply of last issue.
I tried to use e2e_test.sh  to generate model in EmitC dialect.
Here is my command.
./e2e_test_tosa.sh saved_model/my_model/ ../reference-implementation/include/ ../build/bin/ clang 32 0 /workspace/mlir-emitc/scripts/test_e2e/
Here is the error message I got.
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/pywrap_mlir.py", line 84, in experimental_run_pass_pipeline
    mlir_txt.encode('utf-8'), pass_pipeline.encode('utf-8'), show_debug_info)
tensorflow.python.framework.errors_impl.InvalidArgumentError: Invalid pass_pipeline: MLIR Textual PassPipeline Parser:1:105: error: 'tf-device-decompose-resource-ops' does not refer to a registered pass or pass pipeline
symbol-dce,tf-standard-pipeline,builtin.func(tf-device-index-selector),inline,canonicalize,builtin.func(tf-device-decompose-resource-ops),builtin.func(tf-functional-control-flow-to-cfg),inline,symbol-dce,canonicalize,tf-saved-model-optimize-global-tensors,tf-saved-model-freeze-global-tensors

Did I misunderstand anything?
I also tried to use savedmodel_to_tf_dialect.py and tf_to_tosa_dialect.py to achieve the goal.
When I ran tf_to_tosa_dialect.py, I got the similar error message.
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/pywrap_mlir.py", line 84, in experimental_run_pass_pipeline
    mlir_txt.encode('utf-8'), pass_pipeline.encode('utf-8'), show_debug_info)
tensorflow.python.framework.errors_impl.InvalidArgumentError: Invalid pass_pipeline: MLIR Textual PassPipeline Parser:1:100: error: 'tosa-fuse-bias-tf' does not refer to a registered pass or pass pipeline
inline,canonicalize,cse,builtin.func(affine-loop-fusion),builtin.func(affine-scalrep),builtin.func(tosa-fuse-bias-tf),builtin.func(tosa-legalize-tf),builtin.func(tosa-infer-shapes),builtin.func(tosa-make-broadcastable),inline,symbol-dce

Thanks for helping a lot!

Please make sure that you are using the TensorFlow version specified in our requirements.txt file. Those passes were registered in a later version of TensorFlow, older version only support those passes via the tf-opt command line tool but not via the Python API. Please re-open if the issue still persists.


send custom data using ble

I have device which receives any data (digits) using ble and showing it on lcd
I'm using sketch in arduino ide for now.
Is it possible to send any data using ble with your module? I see only switch implementation
Thanks in advance

Hi,
Are you thinking about using my module for receiving digits and displaying them on LCD? Well, then you could use a custom command like „receive-digits“, which can receive strings.
esp32_ble_controller:
commands:

command: receive-digits
description: just a test
on_execute:

logger.log:
format: "I have received some digits: %s"
args: 'arguments[0].c_str()'

So if you send „receive-digits 1234“ over BLE Command channel characteristic, then you should see „ I have received some digits: 1234“ in the logging output. So the digits are in the arguments[0] variable and you could show them on the LCD as well.

I have xiaomi thermometer LYWSD03MMC. I use custom firmware ( https://github.com/pvvx/ATC_MiThermometer ) to send any data to thermometer for showing it on its lcd.
this is the sketch i'm currently using: https://gist.github.com/bonuzzz/8b69f821d850d7cb2f8ac3b1b5b0fa06

Oh, I see. Your sketch is implementing a BLE client (see line 159), my component provides a BLE server. So I am afraid you cannot use it to replace your sketch with ESP Home. Maybe you can use the BLE client and the BLE client sensor from the standard ESPHome. But I think they can only receive and not send data, but I am not sure. So please contact the author of this components.


DOC++ is outdated and unsupported

I tried to build and install DOC++ to build the documentation, but I'm running into multiple issues where I have to manually patch the code to get it to build. DOC++ hasn't been updated since 2002. I know it would take a lot of work and time, but it seems moving to a new documentation system would be recommended. Another possibility could be forking DOC++ and patching it.

Hi Jacob,
I think you got that wrong. The library uses Doxygen, not DOC++. They are similar because Doxygen has got a lot of inspiration from DOC++.
You should not get too much trouble installing Doxygen, your distro most certainly has it.
Regards,
Marcelo.

Ah, I think I've found the issue. First of all, I'm using an older version (1.8.6, matching the version in buildroot) I should've thought about that and guessed it had been updated since. That's my fault. However, the README still says DOC++:
From the current README:

Additionally, the documentation for the SDK can be auto-generated from the upnp.h header file using DOC++, a documentation system for C, C++, IDL, and Java*.  DOC++ generates the documentation in HTML or TeX format. Using some additional tools, the TeX output can be converted into a PDF file. To generate the documentation these tools are required:

DOC++   | The homepage for DOC++ is http://docpp.sourceforge.net. The current version as of this release of the SDK is version 3.4.9. DOC++ is the only requirement for generating the HTML documentation.

So the changes that switch to doxygen are not in the older version, but the current README still says DOC++, which was what I was referencing. Thus, my confusion.

Hi Jacob,
Indeed, the documentation is outdated, sorry for that. I have just committed a fix for the README file.
Regards,
Marcelo.

Looks good, I'll close this issue


Adding circuit breaker

What does this PR do?
This PR adds a circuit breaker so when there are too many errors calling the DataDog
endpoint, the library stops trying for a while.
This should reduce the resources needed both on the the caller side and on the DataDog side.
Ideally, this is a complementary PR to https://github.com/DataDog/datadog-lambda-go/pull/63
If / when timeouts happens, the library user stops trying to call that endpoint for a moment.
Motivation
We observed high latency at certain times and we would like to reduce the time and resources
it takes to resolve requests on those cases. This is related to support case 441237.
And to PR https://github.com/DataDog/datadog-lambda-go/pull/63
Testing Guidelines
I reduced the http client timeout, producing a lot of errors, which triggered the circuit breaker
to open and observed the errors at the output
Additional Notes
I've added gobreaker to vendor and the 3rd party licenses.
Types of changes

[ ] Bug fix
[x] New feature
[ ] Breaking change
[ ] Misc (docs, refactoring, dependency upgrade, etc.)

Checklist

[ ] This PR's description is comprehensive
[ ] This PR contains breaking changes that are documented in the description
[ ] This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
[ ] This PR impacts documentation, and it has been updated (or a ticket has been logged)
[ ] This PR's changes are covered by the automated tests
[ ] This PR collects user input/sensitive content into Datadog

also, I merged the upstream changes in main to resolve the conflicts in go.mod

any chance to get this one merged at some point?

@lhelman Yes, thanks again for the contribution. I've just released v0.10.0 with this change


Support for the new Discourse chat?

https://github.com/discourse/discourse-chat
Would be great to create chat bridges and such.
Thanks.

This would likely go beyond the scope of what this library ought to reasonably support, unless someone really wants to tackle this.


Performance issue with pidigits

Describe the bug
Background: Pidigits is a problem that mainly measures the performance of big integer implementation, here or here are benchmarks for popular languages.
I was trying to benchmark kotlin native with source code here and found it SUPER slow, like 10x+ slower than other implementations. Not sure if I'm just simply using it incorrectly. Thanks!
To Reproduce
Use source code here or attached binary (compiled on ubuntu 20.04) pidigits.zip
# 1000 digits of PI
./pidigits.kexe 1000

Expected behavior
Be comparable to java implementation?
Platform

kotlin native 1.4.31 + ubuntu 20.04

Hi @hanabi1224,
A s far as I can tell, without going into details of your benchmark code, you are doing everything right. I tried running your benchmark as well, and running the native test resulted in 16.5s seconds, js - legacy was 12.4s, js - ir was 16.5s, and jvm was 810ms :smiley:
The multiplatform bignum library has probably a lot of space to improve performance-wise, I already spent some time on optimizing memory and processing usage, but theres defintiely more (i.e. #61 which I will probably never get to at this pace).
To answer your question:
Library source code for all platforms (jvm, native, js) is completely the same. (that not entirely true, there is only one difference when comparing number in JS, but that's it)
The differences in performance you are seeing are caused by kotlin compiler (or transpiler in case of legacy js)
As far as I could gather from different threads and posts regarding Kotlin/Native and it's sluggish, it's primary goal is application development and it's not really expected that it will be breaking any speed records at the moment. I would expect as the compiler matures that there will be less and less difference between jvm and native, but we'll have to wait and see.
Keep in mind that Kotlin/Native is in Beta state since 1.3, and Kotlin Multiplatform is Alpha since September of 2020.
With that said, if I was building a speed critical application and wanted to use Kotlin/Native or Kotlin Multiplatform, I would just use expect/actual mechanism and probably use GMP. I would expect that to bring results more in line with JVM.
There is still a plan (https://github.com/ionspin/kotlin-multiplatform-bignum/projects/4) to provide a version of the multiplatform-bignum library with platform specific implementations (i.e. Java BigInteger on JVM, GMP on native, whatever is fast on JS) that would be more performance oriented, but I simply don't have time to do that at the moment.
So I'll close this issue as there is nothing to do in the current completely shared bignum code that could help improve the native performance except waiting for compiler to improve.

native test resulted in 16.5s seconds, js - legacy was 12.4s, js - ir was 16.5s, and jvm was 810ms

After looking at these results I started to wait 0.3 version with GNU MP library support:)
I hope you find some time on adapting it and maybe it will be even faster than Java version.
Did you test performance of linked GMP in kotlin/native? I just curios will kotlin/native ruin C performance or not.

I hope you find some time on adapting it and maybe it will be even faster than Java version.
This would be a lot of work, and at the moment I have very limited time to work on the library. Also in the development roadmap this is planned for 0.4.0

To implement native versions you would need to map the current api into actual/expect form, add GMP build process to produce libraries for all targets (there is 12 native targets at the moment supported by bignum at the moment), see if there is a emscripten version of GMP for JS or some other JS library, and then write the wrappers expect for all platforms (JVM, JS, Native).
So pull requests to help out on this are welcome :)

Did you test performance of linked GMP in kotlin/native? I just curios will kotlin/native ruin C performance or not.

That is a very interesting question, and I haven't directly compared the two, but I wrote a libsodium wrapper library where I could actually run the comparison, once I have some time. I'll ping you when I do this at some point.
Cheers!

I would say that results @hanabi1224 got is not because of Kotlin/Native but because of the lib itself. Maybe, of course, Kotlin/Native gives negative impact but it's minimal. Take a look at the following tests on JVM:
@Test
    fun compareRandom1() {
        val modes = RoundingMode.values().filterNot { it == RoundingMode.UNNECESSARY }
        val res = measureTimeMillis {
            for (i in 0..100_000) {
                val rand1 = Random.nextDouble(-12313.0, 1233123.0)
                val rand2 = Random.nextDouble(-12313.0, 1233123.0)
                if (rand2 == 0.0) continue
                val randScale = Random.nextInt(0, 80)
                val randMode = modes.random()
                assertEquals(
                    rand1.toString().toBigDecimal().divide(rand2.toString().toBigDecimal(), randScale, randMode).stripTrailingZeros().toPlainString(),
                    rand1.toString().toBigDecimal().divide(rand2.toString().toBigDecimal(), randScale, randMode).stripTrailingZeros().toPlainString()
                )
            }
        }
        println("BigDecimal/BigDecimal " + res)
    }

    @Test
    fun compareRandom2() {
        val modes = RoundingMode.values().filterNot { it == RoundingMode.UNNECESSARY }
        val res = measureTimeMillis {
            for (i in 0..100_000) {
                val rand1 = Random.nextDouble(-12313.0, 1233123.0)
                val rand2 = Random.nextDouble(-12313.0, 1233123.0)
                if (rand2 == 0.0) continue
                val randScale = Random.nextInt(0, 80)
                val randMode = modes.random()
                val randModeBN = randMode.toBNMode()
                assertEquals(
                    rand1.toString().toBigDecimal().divide(rand2.toString().toBigDecimal(), randScale, randMode).stripTrailingZeros().toPlainString(),
                    BN.parseString(rand1.toString())
                        .divide(BN.parseString(rand2.toString()), DecimalMode(100 + randScale.toLong(), randModeBN, randScale.toLong()))
                        .toPlainString()
                )
            }
        }
        println("BigDecimal/BN " + res)
    }

    @Test
    fun compareRandom3() {
        val modes = RoundingMode.values().filterNot { it == RoundingMode.UNNECESSARY }
        val res = measureTimeMillis {
            for (i in 0..100_000) {
                val rand1 = Random.nextDouble(-12313.0, 1233123.0)
                val rand2 = Random.nextDouble(-12313.0, 1233123.0)
                if (rand2 == 0.0) continue
                val randScale = Random.nextInt(0, 80)
                val randMode = modes.random()
                val randModeBN = randMode.toBNMode()
                assertEquals(
                    BN.parseString(rand1.toString())
                        .divide(BN.parseString(rand2.toString()), DecimalMode(100 + randScale.toLong(), randModeBN, randScale.toLong()))
                        .toPlainString(),
                    BN.parseString(rand1.toString())
                        .divide(BN.parseString(rand2.toString()), DecimalMode(100 + randScale.toLong(), randModeBN, randScale.toLong()))
                        .toPlainString()
                )
            }
        }
        println("BN/BN " + res)
    }

And the results on old Intel i3 CPU:
BigDecimal/BigDecimal 3770
BigDecimal/BN 68615
BN/BN 118259

Java's BigDecimal is x31 times faster than BigNum library in multiple tasks (divide, parse, toPlainString). So there is definitely a room for optimizations. Not now since you don't have a time but just added this tests as a new information.

Hi @avently,

I would say that results @hanabi1224 got is not because of Kotlin/Native but because of the lib itself.
I disagree. Running the same test on jvm took 810 miliseconds, while running it on native took 16.5 seconds. It's significant.

Java's BigDecimal is x31 times faster than BigNum library in multiple tasks (divide, parse, toPlainString)
The toString in my library is absolutely terribly implemented, it's probably whats taking the most time in your examples. But I would expect this library to be around 10 or 20 times slower than Java BigInteger.

@ionspin yep, kotlin native is slow. Actually I'll rewrite a server part of my app using Nim (I've being working on the server part three years, imaging how large the codebase. But benefits are so sweet). What can be better than real native performance? Nothing :)


Addendum to previous PR

(misunderstood pokpoong on discord, and merged prematurely; this addresses the comments)

LGTM


app render() is called twice at startup.

Before opening a new issue, please take a moment to review our community guidelines to make the contribution process easy and effective for everyone involved.
Description
the default render function in app/containers/App/index.js   is called twice at npm start.
Steps to reproduce
add a console.log("render") in app/containers/App/index.js   render function, then npm start, you'll see that "render" is print twice.
NOTE: not render function in app/app.js, but app/containers/App/index.js.
render in app/app.js is called once.
but render in  app/containers/App/index.js is called twice at startup.
(Add link to a demo on https://jsfiddle.net or similar if possible)
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Versions

React-Boilerplate: newest version
Node/NPM: newest version
Browser:newest version of both Chrome/Safari

it's quite annoying that the whole app is render() twice by default, can you help fix it up?

is this free to work?

Wanna try this one :)

Wanna try this one :)

Try it please, it hurt me badly.

export default function App() {
console.log("render"); // add here please.
return (

okay!

cannot fix this or find out a solution...
moved my project to npx create-react-app...

working on it...is this index.js your entry point?

working on it...is this index.js your entry point?

to reproduce the bug, all you have to do is git clone the project, and add  a console.log("render") in app/containers/App/index.js render function, and type npm start. no other changes is made.
well, I have already totally moved my code to npx create-react-app toolchain, which cost me 3 hours. Now every thing is fine.
To those who want to start your work based on this toolchain:
if your root page is calling ajax in didMount, you will soon meet this trouble.

I reproduced the bug but I think the problem is something else..

I reproduced the bug but I think the problem is something else..

Yes bro! it's something else that I couldn't understand, so I give it up  :-P
Thank you and Good luck bro!


bop it

Update: refactored the ToggleButton as an example, see latest commit.

This PR is based around a hook that can be used in various situations.
I also want to highlight the intellisense available on Box and Text, but also within useStyle and other utils.

useStyle
The goal here was a mid-level (as opposed to low (like theme.style or high-level (like Box)) util that can be used for defining more complex components like a button, or for styling 3rd party libraries.
It accepts any style props configured by us via properties on the theme.
const styles = useStyle({
  c: 'text',
})

console.log(styles) // => { color: '#333' }

So like for a button, we could make a component like this (this is rough):
import { ComponentProps, useStyle } from 'lib/design-system'

export type ButtonProps = ComponentProps & {
  variant: 'primary' | 'secondary'
}

export function Button({ children, variant, style, ...rest }: ButtonProps) {
  const { styles, props } = usePick<ViewProps>(rest)
  const styles = useStyle({
    px: 's',
    py: 'xs',
    gtPhone: {
      px: 'm',
      py: 's',
    },
    ...({
      primary: { bg: 'theme', c: 'light' },
      secondary: { bg: 'secondary', c: 'dark' },
    }[variant]),
  })

  return <View accessibilityRole='button' {...props} style={[styles, style]} />
}

Similarly for a 3rd party component like a dropdown or something:
export function DateInput() {
  const styles = useStyle({ ... })
  return <DateLibrary style={styles} />
}

I also added (as an example) what a more familiar (like StyleSheet.create) pattern could look like with useStyles (plural, formerly useMultiStyle):
const { container } = useStyles({
  container: {
    px: 's',
    gtPhone: {
      px: 'm',
    }
  }
})

Which gives nice intellisense.

So otherwise, typical usage as primitive components looks like this:
<Box
  inline
  pa='m'
  bg='dark'
  gtPhone={{
    padding: 50
  }}
/>

Main things to note from this example
Properties can be longhand or shorthand, whatever we configure. These could even match like, Tailwind or something if we wanted.
Properties apply in-order, and override just like a normal object i.e. both of the following will result in backgroundColor: 'dark'
<Box bg='theme' backgroundColor='dark' />
// and
<Box backgroundColor='theme' bg='dark' />

gtPhone is a breakpoint, which is only applied above the value configured in the theme. We can name these anything we want, I just took a page from Tamagui's book for this convention. We can have multiple breakpoints. They only update and re-render when the browser window crosses the threshold of a new breakpoint. I also designed this in a way that we should be able to just disable breakpoints on mobile/tablet and basically apply whatever screen size the device has, then never update again (may not want this if we aim to support landscape orientation too, but just thinking ahead).
Most properties can also accept non-theme values, like padding above falls back to DimensionValue from RN.
Properties defined as macros can be boolean, meaning no need to pass a value i.e. inline above that applies { flexDirection: row }
Theming stuff
Themes are created using a factory function. The idea here was just to create types based on what's passed in instead of extending a namespace like some other libraries. Little easier to reason about.
tokens are "design tokens" and correspond to their CSS property names, with the exception of space, which is manually mapped to properties using specialTokenMapping here. There are a few properties mapped to color tokens as well, like backgroundColor and borderColor, etc. Otherwise stuff like fontSize corresponds directly to fontSize property definitions on components.
properties on the theme includes all valid CSS properties by default, and as you can see we can extend them to include "aliases" or "shorthands".
macros are basically custom props. Pass in a value and return a style object. They're useful for boolean attributes, like inline above. But also good for stuff like font that needs to apply a different font family depending on fontFamily and fontWeight attributes i.e. we could pass in like font='sans bold' and map that to { fontFamily: 'InterBold' }.
Ideas
Values like '100vh' work on web but not mobile, so we should export a util like web('100vh') that tells TypeScript that it's valid and prevents that value from being applied if outside a web env.
useStyle could accept a function which gets passed the whole theme object or something too if we want to access it or the tokens within it.

I think we're as close to Tamagui as we can get without getting our eyes wet. We're at a point where we should have a closer look at it as an option, and only come back here if new concerns arise.
Atm the only cons I can think of around using Tamagui is that it's a little more of an all-or-nothing approach (can still do incrementally), and may not be as smooth of a transition going from StyleSheet to XStack (Box) syntax without a useStyle hook like we have here. If we can get it configured and working smoothly then the fact that it brings a whole component ecosystem with it could be a boon.
Closing for now!


Post a reminder message on stale PRs, instead of just closing

In this example (https://github.com/JuliaRegistries/General/pull/26570), the stale bot posted a message and then closed the PR immediately.
Instead of doing that, I think it would be better to first post a reminder message, then wait a little while, and then close the PR if nobody responds after the reminder message.
Is that possible?
cc: @giordano @fredrikekre

That's what I did initially in #26710.

That's what I did initially in #26710.


 I'm very new to bluetooth as a whole.
I've connected my application to a glucose monitor. I'm trying to read that data - I've got the short UUIDs for the Glucose and then the characteristic Glucose Measurement. But these are in the form 0x1808 and 0X2A18.
Do I require the longer UUID? If so, how do I obtain this value?
Apreciate nany help!

@JamesOwen7 were you able to do so? Please let me know how.
Thanks


AWS Machine Driver: Resources not cleaned up

Rancher Version: v1.2.0
Docker Version: 1.12.3
OS and where are the hosts located? (cloud, bare metal, etc):  Ubuntu 16.04.1 LTS, AWS Cloud
Setup Details: (single node rancher vs. HA rancher, internal DB vs. external DB) single node, internal DB
Environment Type: (Cattle/Kubernetes/Swarm/Mesos) Cattle
Steps to Reproduce:

Create an environment
Navigate to Add Host >> Amazon EC2, provide AWS credentials
Select a VPC/Subnet
Select a security group with all ports open (or at least tcp port 22 open)
Specify a name, select Use only private IP address, click create
Wait for a while, hosts will never be accessible via SSH (no public IP attached)
Delete hosts from UI

Results: Instances & keypairs still exist in AWS account
Expected: Instances & keypairs are deleted

This may be related tohttps://github.com/rancher/rancher/issues/6750

This is a different issue which is seen even in fresh install of v1.2.
The scenario is to delete the host when host is still in "provisioning" state specifically when it is in the state of "Waiting for ssh to be available.." . The host gets removed from the UI but continues to remain provisioned in AWS. The same behavior is seen when host that is stuck in provisioning  "Waiting for ssh to be available.."  is deleted when provisioning ROS by providing user other than rancher.
In cases where docker machine is not really able to ssh to host (misconfiguring) , "Add Host" eventually errors out in which case the instances from AWS are removed as expected.
@LLParse , for the scenario you have mentioned , use  had to wait (~ 1 hour after 60 failed retry attempts) , for host to get to "Error" state , at which point hosts gets removed from AWS.
We should be able to error our much earlier in this case . Tracked this issue in - https://github.com/rancher/rancher/issues/6872


Mark all regressions tests as pending for MarkLogic

@jedesah is this build going to hang because it doesn't include fix #1412 ?

@alissapajer No, because we don't yet have a Travis build that actually runs the integrations tests for MarkLogic.

@jedesah ah good point! :)

Current coverage is 68.41% (diff: 100%)

Merging #1413 into master will increase coverage by <.01%

@@             master      #1413   diff @@
==========================================
  Files           266        266
  Lines         13298      13298
  Methods       13017      13017
  Messages          0          0
  Branches        130        130
==========================================
+ Hits           9097       9098     +1
+ Misses         4201       4200     -1
  Partials          0          0

Powered by Codecov. Last update 0c3dcc8...8247ecf


[BACKEND][AMD] Disable linear layout due to perf regression

We have identified a 20% perf regression in our downstream flash attention perf kernel after switching to linear layout. Initial analysis shows register pressure is increased to cause spills. Further analysis is still ongoing.

Yeah we are looking into this at the moment. Because in the down stream kernel (specifically, this one) it's already using lots of registers so the change in codegen causes spills. the flash attention tutorial is not as a big issue due to less registers used there.


[TODO] Resize handles on elements

So we can easily resize rectangles, circles... We shouldn't do it for text.
We need to make sure that if the element is small, we can still move it instead of resizing it. It's going to be an interesting UX challenge with the hit targets.

On top of this, each shape should define where the handles should be placed (which could be implemented as part of https://github.com/excalidraw/excalibur/issues/9) --- specifically, the arrow shape should only define 2 nodes, which will allow to easily change the start/end positions.


Support for C#10 and C# 11, and for Razor page partials

Update to the latest Roslyn SDK to support running R4MVC over codebases written in C# 10 and C# 11.
In particular this adds support for file-scoped namespaces, which the parser was seeing as an error.
The PR also addresses the lack of support for Razor page partials i.e. plain .cshtml files with no code-behind class that live within the /Pages hierarchy
.NET Core 2 and 3 are out of support, so remove the AspNetSimple.NetCore2 sample app, and update AspNetSimple to .NET 7.
Also update other NuGet package dependencies.

Closed this - reverted to forking T4MVC/R4MVC directly.


pseudo-lenses

As promised here in #1, I've made a prototype implementation that uses lenses to allow checking different fields in one component. I recommend you look at examples/lens-derive.rs to get a full example, but the gist is this:
#[derive(Component, FieldCheckable)]
struct Enemy {
    state: EnemyState,
    condition: EnemyCondition,
}

#[derive(FieldCheckable)]
struct EnemyCondition {
    alive: EnemyAlive,
    health: u32,
}

#[derive(FieldCheckable)]
struct EnemyAlive {
    alive: bool,
}

fn running_enemies(_entities: Query<&Enemy, Check<lens!(Enemy::state), IsRunning>>) {
    // ...
}

fn alive_enemies(
    _entities: Query<
        &Enemy,
        Check<lens!(Enemy::condition, EnemyCondition::alive, EnemyAlive::alive), Is<true>>,
    >,
) {
    // ...
}

The lenses allow you to access different fields, and they're composable, so you can access nested structs. I think it's pretty neat :)
It's still very rough, but I'm opening the PR so you can take a look and say if this is something you'd be interested in, and if you are, I'll polish it a bit more. Let me know if you want any names changed. It builds on #1, but in case that PR is rejected and this isn't, it could be reworked to remove the other stuff.
To make it work I added the Checkable trait, which substitutes Component as the trait bound on T inside Check. This trait has two associated types: Component and Checked. These are not good names, I'm still working on replacements '^^. Component is the actual component, and Checked is the type that is fed into the test method of Predicate. I shifted the stuff in src/impls.rs to refer to T::Component instead of T.
Last thing: I haven't actually tested that it filters stuff correctly, I'll set up some tests for that later.

For now, I don't think I'm interested in a lens-style concept for this crate, but I am glad for your work on the IsVariant macro!
The reasoning being, bevy programs usually (and should) lend themselves towards wide and shallow data collections, rather than thin and deep data nesting. IMO, EnemyCondition as in the example should really be 2 different components (same with Enemy). I'd have to see some more real world examples where lenses would be the best choice to want to consider supporting it. For now, I believe IsTrue/IsFalse and IsVariant should cover a vast majority of use cases, and people can always implement Predicate themselves as a safe hatch.
And I've already found myself reaching for IsVariant in my own project. Again, thanks! 😃

That's a fair point! I didn't have a lot of hope of this getting merged, it was just a fun proof of concept to work on ^^


Add citation support.

Hi ! I was using this library for a forum website when I noticed that notations are not supported, could you add it ? I think it would be simple also, as it's just a <blockquote> tag.

Exemple of citation I'm needing.

Never mind, I was saving > as >.


Excessive false positive R-18 tags when downloading in whitecube

I got R-18 tags for almost every all-age image I download.

You need to disable the R-18 from your pixiv website configuration and delete the old cookie value in config.ini?

I still want to download R-18 at the same time as all-age, but have R-18 tags for R-18 images only.

hmm, r18mode=True in config.ini will only download R-18 tagged images, not the other way around.
If you want to enable/disable R-18, you need to change it from the website.

If you are using download by Tags, you can use NOT R-18 in the query.

fixed in https://github.com/Nandaka/PixivUtil2/releases/tag/v20161124


[SPARK-48004][SQL] Add WriteFilesExecBase trait for v1 write

What changes were proposed in this pull request?

This pr adds a new trait WriteFilesExecBase for v1 write, so that the downstream project can inherit WriteFilesExecBase rather than WriteFilesExec. The reason is that, inherit a case class is a bad practice in scala world.
Why are the changes needed?

Make downstream project easy to develop.
Does this PR introduce any user-facing change?

no
How was this patch tested?

Pass CI
Was this patch authored or co-authored using generative AI tooling?

no

cc @cloud-fan @yaooqinn thank you

late LGTM


Use error estimates of Mag as features

This can be done with a robust optimisation approach.
See chapter 12 of:
http://www2.isye.gatech.edu/~nemirovs/FullBookDec11.pdf

When it comes to choosing our training data, we might want to use the bright objects (since they have smaller errors) and then test our classifier on faint ones. But from a machine learning perspective, perhaps we might want to do the reverse, since it's better to let our classifiers know as much about the random noises at the training phase as possible.


[Android] App crashes when close

RN: 0.40
React native fcm: 5.0.0
Device: Android 7.1 cyanogen(Real)
When back button is pressed, system gives error saying App keeps stopping
In console, I am getting Object is not a function (evaluating 'this.notificationUnsubscribe()')
In componentDidMount, I am doing this.notificationUnsubscribe = FCM.on(...)
When I remove this.notificationInsubscribe(), then no errors. But I doubt that it will drain my battery.

the syntax has changed, check latest readme and release tab


Provide documentation how to configure various storage backends

Description
While the "build-in" backends adopt the configuration of object_store and we could always refer to the config over there, we should add some docs in the delta-rs documentation at least pointing folks in the right direction.
Specifically the S3 integration can be adopted to work with several other implementations, sometimes leveraging features (atomic rename) not available in "vanilla" S3.
Use Case
Users should easily discover how they can leverage their storage backend.
Related Issue(s)
#2361

Is this just providing some very basic "This is how to write to S3 then read from S3 with some options" documentation? If so, I think I may be of some help with this as I am currently interacting with AWS S3 and Minio S3. If it is that, where should I document? In the code, or just put something in a markdown file?


Policy Mapping parameters org, orgID, and bucketIDare incorrect for/dbrps`

Description:
The swagger documentation references the /dbrps parameters as orgID,org, and `'bucketID':
https://github.com/influxdata/influxdb/blob/master/http/swagger.yml#L376
whereas the documentation for the dbrp compatibility endpoints uses organization_id, organization, and bucket_id: https://docs.influxdata.com/influxdb/v2.0/reference/api/influxdb-1x/dbrp/#manually-create-and-manage-dbrp-mappings
Results:

When I follow the swagger instructions, and submit a POST like this:

curl --request POST 'http://localhost:8086/api/v2/dbrps' \
--header 'Content-Type: application/json' \
--header 'Authorization: Token {myToken}
--data-raw '{
    "orgID": "17efaf2695e0598c",
    "bucketID": "4cd36b5dcfaac160",
    "database": "1601916910db",
    "retention_policy": "autogen",
    "default": true
}'

I get this error:
{
    "code": "invalid",
    "message": "invalid ID"
}

However, when I submit this request based on the instructions for the dbrp compatibility endpoints:

curl --request POST 'http://localhost:8086/api/v2/dbrps' \
--header 'Content-Type: application/json' \
--header 'Authorization: Token {myToken}' \
--data-raw '{
    "organization_id": "17efaf2695e0598c",
    "organization": "sengel-org",
    "bucket_id": "4cd36b5dcfaac160",
    "database": "1601917004db",
    "retention_policy": "autogen",
    "default": true
}'

then I get a successful 201 response:
{
    "id": "066a6c3549c54000",
    "database": "1601917121db",
    "retention_policy": "autogen",
    "default": true,
    "organization_id": "17efaf2695e0598c",
    "bucket_id": "4cd36b5dcfaac160"
}

Expected Results:

Both API documents should reference the same params for the/dbrps path
Based on the param naming convention that is already established in the /api/v2/ swagger documentation, the correct params should be org, orgID, and bucket_id.

@ivankudibal @kelseiv
I created this issue based on a discrepancy I found. I'm not sure if / when this will be fixed, but I wanted your teams to be aware.

Closing because this issue was fixed in the above-referenced docs PR


Only URLs of first level categories are generated

Describe the bug
The script only generates the URLs of the first level of categories.
Expected behavior
It should generate the URLs of all categories and child categories.
To Reproduce
We have multiple categories and child categories, and we recently translated them to multiples languages. We wanted to use your module to generate the URL keys of the categories in the new store views using the translated name we set in those store views.
Unfortunately when we run this :
bin/magento ok:urlrewrites:regenerate --entity-type=category

It only regenerate the URL keys of the first level of categories.
Additional context
I see in the code (https://github.com/olegkoval/magento2-regenerate_url_rewrites/blob/master/Model/RegenerateCategoryRewrites.php#L257) that you specifically select only top categories, as the products and child categories will be regenerated as well.
But I don't see where the child categories' URLs should then be generated?
My suggestion would be to remove the line https://github.com/olegkoval/magento2-regenerate_url_rewrites/blob/master/Model/RegenerateCategoryRewrites.php#L259 as I don't see it's utility, but maybe I am missing something?

same issue

Also got this

Same issue

same issue


UNAUTHORIZED: "authentication required

When I followed your steps, the following error occurred:
error pushing image: failed to push to destination index.docker.io/reme3180/executor:ubuntu: UNAUTHORIZED: "authentication required"
The pod.yml file is as follows:
`
apiVersion: v1
kind: Pod
metadata:
name: kaniko
namespace: jenkins
spec:
containers:

name: kaniko
image: registry.icp.com:5000/library/executor:test
imagePullPolicy: Always
tty: true
args:

--dockerfile=Dockerfile
--context=dir:///test
--destination=reme3180/executor:ubuntu
volumeMounts:

name: kaniko-secret
mountPath: /root
restartPolicy: Never
imagePullSecrets:

name: registry.icp.com
volumes:

name: kaniko-secret
secret:
secretName: regcred
items:
- key: .dockerconfigjson
path: .docker/config.json
`

Hi @Reme3180, this error occurs because kaniko failed to push the built image to your dockerhub repo. The reason was most likely that the kaniko pod did not mount your account secret successfully.
For a quick investigation, you could docker exec into the running kaniko container and see if there are .docker/config.json file in /root path. Maybe it because you added a imagePullSecrets field and recognized as null by k8s.
Please refer to k8s official doc and kaniko push example to learn more about how to create a dockerhub secret and used when push kaniko image, thanks!


Remove Modals

Current Modals are not perfect, especially on Android.
Remove it from sources

wont do.


Support for Android 4.x

I'm trying to use this library on an app with a minimum SDK of 14, and it appears to work fine, appart from one method in AuthenticationIntercepter, which only support API 19 and above:
To fix this I've added a special method to get UTF8 standard charset:
    @Override
    public Response intercept(Chain chain) throws IOException {
        Request request = chain.request()
            .newBuilder()
            .addHeader("Authorization", Credentials.basic(userName, password, standardUTF8()))
            .build();
        return chain.proceed(request);
    }

The method to get a standard charset is as follows:
    public static Charset standardUTF8()
    {
        if (android.os.Build.VERSION.SDK_INT >= android.os.Build.VERSION_CODES.KITKAT)
        {
            return StandardCharsets.UTF_8;
        }
        else
        {
            //noinspection CharsetObjectCanBeUsed
            return Charset.forName("UTF-8");
        }
    }

Great. Feel free to open a PR with this change so that we can review it.

Opened my first PR, hope I've done it right? Don't have git on my windows PC, so I made the modifications from github.

Fixed by #41


feat(expect-puppeteer): use helper that keep original error message

Related to #33.

@neoziro I need to write some tests and add a notice in the README.
Is that errorHandler I introduced ok though? Feedback welcome.

All errors are wrapped, it is a good first step. Second step, we need to display the original error to the user, in order to simplify debug. I think displaying the originalError.stack should be sufficient.

@neoziro What I did is incorrect I think, I can't just add an attribute like this to an Error object, I guess I have to extend it - tried to console.log the added attribute but it's undefined. When you say "displaying the originalError.stack", do you mean console.log/console.error-ing it?

I did it in #45, thanks for your time and sorry for not having merged your PR.


Arrows Left and Right should only display when appropriate

Is your feature request related to a problem? Please describe.
When working with a non-infinite carousel the left arrow shows up when the carousel is at position 0. This leads to bad ux since you can scroll to the left any farther behind index 0.
Similarly when you are at, or close to the end of the list (ie there is no more pages beyond the last card) the right arrow still appears.
Describe the solution you'd like
This to automatically be handled
Describe alternatives you've considered
I've made a function that passes in the arrow props dynamically for now which is working great, but this seems like it could be a built in feature.

Thanks for reporting this.
Unfortunately we don't have enough time to resolve this issue.
Anyway a PR is more than welcome.
Btw. it would be great if you recorded a video showing your issue.

Hi @piotr-s-brainhub ,
This issue is fixed in this PR.
PR: https://github.com/brainhubeu/react-carousel/pull/125
Thanks

thanks @udaypydi

@patricksimonian
Can I ask you to fill in this form https://docs.google.com/forms/d/1tfRs1Io49tJBwz-06aDnz8hrJ3WySJTi45y4k6hHGaQ ?


Linting podspec fails on branch used to prepare a point release

When preparing a point release that does not include all changes on master, the process is to create a branch from the most recent release, cherry pick the relevant changes, bump the version, then push a PR for CI to chew on. The verify-cocoapods job now fails on such branches. The pod spec lint commands fail as the version number they refer to does not have a corresponding tag in our GitHub repository:
mrowe@apollo:~/Source/realm-cocoa$ pod spec lint Realm.podspec --verbose

    Realm (0.98.6) - Analyzing on iOS 7.0 platform.
  Preparing

Analyzing dependencies

Fetching external sources
-> Fetching podspec for `Realm` from `/Users/mrowe/Source/realm-cocoa/Realm.podspec`

Resolving dependencies of

Comparing resolved specification to the sandbox manifest
  A Realm

Downloading dependencies

-> Installing Realm (0.98.6)
 > Git download
 > Git download
     $ /usr/bin/git clone https://github.com/realm/realm-cocoa.git /var/folders/cy/9dj49tyx5sbb5nthgbndrwlc0000gn/T/d20160325-38762-2u3apl --single-branch --depth 1 --branch v0.98.6
     Cloning into '/var/folders/cy/9dj49tyx5sbb5nthgbndrwlc0000gn/T/d20160325-38762-2u3apl'...
     warning: Could not find remote branch v0.98.6 to clone.
     fatal: Remote branch v0.98.6 not found in upstream origin

[!] Error installing Realm
 -> Realm (0.98.6)
    - WARN  | url: The URL (https://realm.io/docs/objc/0.98.6) is not reachable.
    - ERROR | [iOS] unknown: Encountered an unknown error ([!] /usr/bin/git clone https://github.com/realm/realm-cocoa.git /var/folders/cy/9dj49tyx5sbb5nthgbndrwlc0000gn/T/d20160325-38762-2u3apl --single-branch --depth 1 --branch v0.98.6

Cloning into '/var/folders/cy/9dj49tyx5sbb5nthgbndrwlc0000gn/T/d20160325-38762-2u3apl'...
warning: Could not find remote branch v0.98.6 to clone.
fatal: Remote branch v0.98.6 not found in upstream origin
) during validation.

Analyzed 1 podspec.

[!] The spec did not pass validation, due to 1 error and 1 warning.

We no longer run pod spec lint in pull requests, so this is no longer an issue.


Simplify router args

I tried to simplify some of these complex args and self types.
But I ended up with:
error[E0038]: the trait `CosmosExecutor` cannot be made into an object
   --> packages/multi-test/src/wasm.rs:684:17
    |
684 |         router: &dyn CosmosExecutor<ExecC = ExecC>,
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ `CosmosExecutor` cannot be made into an object
    |
note: for a trait to be "object safe" it needs to allow building a vtable to allow the call to be resolvable dynamically; for more information visit <https://doc.rust-lang.org/reference/items/traits.html#object-safety>
   --> packages/multi-test/src/app.rs:498:38
    |
497 | pub trait CosmosExecutor {
    |           -------------- this trait cannot be made into an object...
498 |     type ExecC: Clone + fmt::Debug + PartialEq + JsonSchema;
    |                                      ^^^^^^^^^ ...because it uses `Self` as a type parameter

I don't quite follow why it is not proper. Maybe you tried this path already and failed. Maybe you know how to fix it.
I think it will make Wasm cleaner as we add more types into Router (like Staking, etc). But maybe this approach is not possible.

If you have a solution or idea, please just push it on this branch

Update: this is compiling and passing tests.
Usage of the Router in wasm.rs is much simpler.
The biggest issue encountered was that struct CosmosMsg<T> requires T: Clone + Debug + PartialEq + JsonSchema + ... and it seems the PartialEq could not be used as a bound on the trait attribute/type. Ugh.
I demo a solution, I made a fake CosmosMsg, where the struct doesn't have any bounds on T (just the implementations). This solved the issue. We really should upstream this so as not to have multiple CosmosMsg types floating around.
Other than that, I think this does make usage of Router nicer and wasm.rs simpler. I would like some feedback

See https://github.com/CosmWasm/cosmwasm/pull/1098 to simplify the types upstream.


Add a combo-system for Skills

In the original game, the blade knight can use 3 skills in a certain order to get a combo damage bonus (and a special effect). The combo bonus is calculated by (Strength + Agility + Energy) / 2.
It would be great if we could implement that in a more generic way, so that we can allow other characters to have some kind of combos, and also to define the combo-damage-bonus.
So what we need to define:

How many stages need to be executed
Which skills are allowed in which stages
How much time is allowed between the skills
How the damage bonus is calculated (e.g. by AttributeRelationships)
General requirements to be able to grant the combo bonus (e.g. a completed Quest, or generally an AttributeRequirement)

There is now the attribute Stats.IsSkillComboAvailable which gets set to 1 when the Dark Stone Quest is completed.
The calculation of Stats.ComboBonus was added as well, for Knights.


feat(getUtxos()): Can now get UTXOs for a different address

:tada: This PR is included in version 4.5.0 :tada:
The release is available on npm package (@latest dist-tag)
Your semantic-release bot :package::rocket:


Running using node cluster?

Have it been tried? Maybe should be used this way by default to scale?

This has been tried and works. We will be investigating this going forward to see what the best approach is using uws, since we maybe be able to share the server connections in a more efficient manner.

Closing due to 3.0 cluster changes


could not log in to Land Portal

cannot reproduce , no information aside the screenshot (which isn't much help here)
= > close


OCPBUGS-19674: Report correct port when API exposed via route

What this PR does / why we need it:
When using a route to expose the API server, the external port should be
443. This commit makes the change in the HyperShift operator, as well as the real fix in the control plane operator so that we can account for existing hosted control planes that report the wrong port.
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #OCPBUGS-19674
Checklist

[x] Subject and description added to both, commit and PR.
[x] Relevant issues have been referenced.

/jira refresh

/test e2e-aws

/lgtm

/cherry-pick release-4.14


Ignore files not in local repo

When commiting files from the Transport-to-branch option Abapgit tries to commit all objects in the transport request, and if these transports are for some reason ignored (.gitignore, generated SADL-objects for example) the commit fails since not all files to be commited are in the repo.
This change ignores these files, and trusts that the files not in the local repo should not be staged. Not sure if this is something we should trust, but it solves my itch.

lets try it, merging

Seems to work, deleted my fork now

Thanks folks. It solved one of the issues I am having. Now I don't need to worry about objects from different packages in same transport. I can go to respective package and create branch.

@Srinu3366
This change is only for the transport to branch-option, if you try to stage objects from packages outside of the repo it will still complain. So yes, this works if you only use transport-to-branch, but not if you subsequently try to make another commit, then you still need to cherry-pick your objects.
Also, wouldn't it be very easy to create dependencies between specific branches of different repos, not sure that's a good idea, I like to see my commits as "atomic" as far as possible


Law and proof: rotational inertia of thin rod

You have all recent commits in your PR. Merge or rebase to fix.


Allow LINQ Where - where property of object is not used

I am attempting to use Marten with a specification pattern that my applications currently use. The specification interface uses the following interface:
public interface ISpecification<T>
{
    bool IsSatisfiedBy(T entity);

    ISpecification<T> And(ISpecification<T> other);
    ISpecification<T> And(Expression<Func<T, bool>> expression);

    ISpecification<T> AndNot(ISpecification<T> other);
    ISpecification<T> AndNot(Expression<Func<T, bool>> expression);

    ISpecification<T> Or(ISpecification<T> other);
    ISpecification<T> Or(Expression<Func<T, bool>> expression);

    ISpecification<T> Not();

    ISpecification<T> OrderBy<TProperty>(Expression<Func<T, TProperty>> property);
    ISpecification<T> OrderByDescending<TProperty>(Expression<Func<T, TProperty>> property);
    ISpecification<T> Take(int amount);
    ISpecification<T> Skip(int amount);
}

To build a specification the following is used:
var spec = Specification<Entity>.All()
                           .And(x => x.Id == "something")
                           .And(x => x.Prop == "somthing-else");

The implementation of All() is like this:
public static ISpecification<T> All()
{
    return Where(x => true);
}

For use with Marten the specification is converted into Expression<Func<TEntity,bool>> and used in a query like this:
var expression = Specification<T>.ToExpression(specification);
var queryableResults = Session.Query<T>().Where(expression);

The usage of All() causes the following exception to be thrown:
System.NotSupportedException: Marten does not (yet) support this Linq query type
   at Marten.Linq.MartenExpressionParser.ParseWhereFragment(IDocumentMapping mapping, Expression expression)
      at Marten.Linq.DocumentQuery.buildWhereClause()
      at Marten.Linq.DocumentQuery.ConfigureCommand[T](IDocumentSchema schema, IDocumentStorage documentStorage, NpgsqlCommand command)
      at Marten.Linq.DocumentQuery.ConfigureCommand[T](IDocumentSchema schema, NpgsqlCommand command)
      at Marten.Linq.MartenQueryExecutor.BuildCommand[T](QueryModel queryModel, ISelector`1& selector)
      at Marten.Linq.MartenQueryExecutor.Remotion.Linq.IQueryExecutor.ExecuteCollection[T](QueryModel queryModel)
      at Remotion.Linq.Clauses.StreamedData.StreamedSequenceInfo.ExecuteCollectionQueryModel[T](QueryModel queryModel, IQueryExecutor executor)
      at Remotion.Linq.Clauses.StreamedData.StreamedSequenceInfo.ExecuteQueryModel(QueryModel queryModel, IQueryExecutor executor)
      at Remotion.Linq.QueryModel.Execute(IQueryExecutor executor)
      at Remotion.Linq.QueryProviderBase.Execute(Expression expression)
      at Remotion.Linq.QueryProviderBase.System.Linq.IQueryProvider.Execute[TResult](Expression expression)
      at Remotion.Linq.QueryableBase`1.GetEnumerator()
      at System.Collections.Generic.List`1..ctor(IEnumerable`1 collection)
      at System.Linq.Enumerable.ToList[TSource](IEnumerable`1 source)

It would be great if Marten could support expressions which just return a Boolean. Is this use case acceptable, or should I look at changing how my specifications work?
I'm happy to look at making this change myself if it is something that would be acceptable when working.

"It would be great if Marten could support expressions which just return a Boolean" -- yeah, it's really not that simple. Marten's Linq support never actually executes those methods, and you can't get away with doing anything that general. You have to be able to parse and convert any method encountered in the Expression into a Sql statement.
Here's a blog post on extending the Linq support to custom methods: http://jeremydmiller.com/2016/03/08/an-example-of-the-openclosed-principle-in-action/

@ncwilliams Have you tried using the PredicateBuilder listed here.
http://www.c-sharpcorner.com/UploadFile/c42694/dynamic-query-in-linq-using-predicate-builder/
It will allow you to start of with a true and then chain where statements to give you a statement that can be passed into Where(). It supports IQueryable.

@ncwilliams Hey, with @schotime 's workaround up there, I'm going to close this one as a "won't fix" thing just to clean off the issue list.


Dynamic Nesting Attributes Support

Hi there. I am currently migrating a project from Restkit to Realm + ObjectMapper.
Say if I have a rest api response like this
{
"adam": {
    "email"<EMAIL_ADDRESS>    "phone_number": "0987654321"
    },
"smith": {
    "email"<EMAIL_ADDRESS>    "phone_number": "1234567890"
    }
}

and I would like to map it to a collection of objects with this model
class Contact: Mappable {
	var name: String?
	var email: String?
	var phoneNumber: String?
}

Restkit can handle Dynamic Nesting Attributes like this
https://github.com/RestKit/RestKit/wiki/Object-mapping#handling-dynamic-nesting-attributes
I have not found a way to work around this in Object Mapper yet, but here is my work around.
I modified the Map class's contructor
public final class Map {
	//...
	private init(mappingType: MappingType, JSONDictionary: [String : AnyObject]) {
		self.mappingType = mappingType
		self.JSONDictionary = JSONDictionary
        self.currentValue = JSONDictionary // I added this line
	}
	//...
}

Then I defined my model like this
class ContactDict: Mappable {
	var dict: [String: Contact]?
	init() {}
	required init?(_ map: Map) {
		mapping(map)
		// assign key of contact to name here
		if let dict = dict {
			for (name, contact) in dict {
				contact.name = name
			}
		}
	}
	func mapping(map: Map) {
		// currently objectMapper does not support mapping this map without a subscript
		// the line I added in constructor enabled this
		dict <- map
	}
}
class Contact: Mappable {
	var name: String?
	var email: String?
	var phoneNumber: String?
	init() {}
	required init?(_ map: Map) {
		mapping(map)
	}
	func mapping(map: Map) {
		email <- map["email"]
		phoneNumber <- map["phone_number"]
	}
}

Do you have better ways to work around this? I've been thinking about adding this feature to ObjectMapper but I haven't yet come up with a elegant way to do it yet. This would be a awesome feature.

Hey there,
This is an interesting idea/problem. Dynamic nested attributes would indeed be a nice addition to ObjectMapper but I can't think of a great solution at the moment (I will put some more thought into it though).
I do have a suggestion to make your above code simpler. Instead of modifying the map class you can do something like this following (using your Contact class):
var contactDict = Mapper<Contact>().mapDictionary(apiResponse)
if let contactDict = contactDict {
     for (name, contact) in dict {
           contact.name = name
      }
}

Hope this helps out
Tristan

Thank you, I overlooked the mapDictionary method


V5 Offcanvas: Opening link can't have children

Using the example given in the docs works fine:

  Link with href

However adding classes to the content of the link, breaks the offcanvas and it won't open:

  Link with href clicking here will not work

However clicking on the first part of the text will still work.
This also happens for <button>

i have the same issue,

when i try to use svg in html not as office use as background.it's break the offcanvas,it's opened and auto closed.
so try to use background imgage to solved this,but it's a bug.

Duplicate #33457

Thank you guys for reporting this. It is very helpful for to know and fix any issues.
I close it as duplicate


WW no longer returns a world flag

Using the code "WW" used to return a generic world flag. It no longer does.

Using the code "WW" used to return a generic world flag. It no longer does.

It was removed in V2 https://github.com/madebybowtie/FlagKit/blob/master/Assets/Flags.md


Add sample to publish to Kafka

done. Kafka Http100WebAggregateToKafkaApp.java: Hitting 100 common websites to get these status code to kafka. Usage of response context to pass kafka client. You may use the included Kafka Receiver to validated. Check pom.xml to see which version of kafka we use. Simple fork this and change HOSTNAME to point to your kafka server to work. Have tested with our kafka server and receiver.


Fixes #481 (Jobs status page access control check)

PR for revel/revel#481
I verified that direct, localhost request and proxied nginx request allows access to status page and denies access for non-IPv4 local loopback. Did not test IPv6, but the logic is sound ("::1" is IPv6 local loopback address).

@brendensoares I don't think we can do this:
remoteAddress := c.Request.RemoteAddr
if proxiedAddress, isProxied := c.Request.Header["X-Forwarded-For"]; isProxied {
	remoteAddress = proxiedAddress[0]
}

Just imagine, you are using revel without proxy. And I'm visiting your website with spoofed X-Forwarded-For header...
Either isProxied should be taken from conf file (isProxied = revel.Config.BoolDefault(...)``) or we should make sure that remoteAddress` is a local address (but what if your app is in instranet).

@anonx excellent point. I think making it configurable and disabled by default is a great solution. Agreed?

Yes.


Prepare docs on GitHub pages

Suggested technologies
https://www.11ty.dev/
https://docs.github.com/en/pages/setting-up-a-github-pages-site-with-jekyll/about-github-pages-and-jekyll

the home page exists.
https://cloud-native-saasi.github.io/saasi.github.io/
need to start to add the following

getting started
architecture page
contribution guidelines
components

Added intro and arch drafts at:
https://cloud-native-saasi.github.io/saasi.github.io/posts/get-started/intro/


Update column priority on move

WHY
BEFORE - What was wrong? What was happening before this PR?
Making a column first in the list wouldn't update the priority, thus it wouldn't display as reported in: https://github.com/Laravel-Backpack/CRUD/issues/5215
A concrete example is:
CRUD::addColumns(['column1', 'column2', 'column3']);

// column1 - priority 1
// column2 - priority 2
// column3 - priority 3

// now we will add a new column that should be the first column:
CRUD::column('column4')->makeFirst();
// column4 - priority 4

// the column array is now:
['column4', 'column1', 'column2', 'column3'];

But since column4 has lower priority than the other 3 columns, it will be hidden when there is no space on the table to display the four columns.
AFTER - What is happening after this PR?
Whenever you move a column, we will check if the priority was "auto-set" by counting the number of columns vs the auto-assigned priority and change the priority of the moved column accordingly.
HOW
How did you achieve that, in technical terms?
I am not 100% happy with his solution, but it will work for 99% of the cases. The "real issue" is the underlying priority assigned by Backpack when the column is added to the crud panel.
The real fix for this would be to only assign column priorities when ALL columns have been defined, so "at the end" of setupListOperation.
Another case where "lifecycle hooks" would be the definitive solution, but we don't have them yet, so this is the "best" we can do.
Is it a breaking change?
No
How can we test the before & after?

Looks good to me!

Heads-up, looks like this breaks the tests. Received an email that main is now failing all tests: https://github.com/Laravel-Backpack/CRUD/actions/runs/10427840554/job/28883168977
Looks to me like this PR is the source:


Straight does not find updated recipes when updating&freezing their repos

I've just narrowed down a weird problem I've had with straight.el for a little while: I keep my emacs config in sync between two machines using git & frozen versions via straight. Every so often, I'll add a new package (recently, eglot and deadgrep) on one machine, and then when I check out the configuration on the other machine, emacs will refuse to start up because it can't find the recipe in any of the recipe packages. This seems to happen more often to things that sort alphabetically before straight's recipe repos (melpa, emacsmirror, etc).
Steps to reproduce:

Make a note of the version of melpa that's checked out (we'll use that to simulate transporting the emacs config across the network) - let's say the version is 7726fcef0525bb50b313c6e7ef10fa5b16e12101
Find a package that's newly released on melpa (that is, it is not in the version of melpa that's frozen) - let's pick deadgrep.
Add that package to the init file
Freeze both melpa and that package
Remove both the new package from the build & repo dirs: rm -rf ~/.emacs.d/straight/{repos,build}/deadgrep/
Checkout the old version of melpa in its repo dir & delete its build dir: (cd ~/.emacs.d/straight/repos/melpa && git reset --hard 7726fcef0525bb50b313c6e7ef10fa5b16e12101) && rm -rf ~/.emacs.d/straight/build/melpa
Restart emacs

Result:
Emacs fails to load the init file, saying: error: Could not find package deadgrep in recipe repositories: (org-elpa melpa gnu-elpa emacsmirror)
Workaround: M-x straight-pull-package RET melpa RET
Expected result:
Straight should pull melpa and the other recipe repos first to match the frozen versions, then attempt to install new packages / new versions of other packages.

There are definitely problems with the UX of moving lockfiles between machines (what is really needed is a way to start Emacs with a command-line flag saying "please normalize and update packages as you go, instead of loading the old versions"), but I think that your particular steps for reproduction result in expected behavior. In step 2, how are you adding the package to the init-file if the recipe isn't yet available in that machine's copy of MELPA? If you are writing a lockfile, it should mean that all the packages are currently using correct revisions.
You seem to want recipe repositories to be pulled automatically. I don't think this is the correct solution. Instead, there should be a way to automate the following steps for updating an Emacs configuration using straight.el, which currently have to be performed manually:

Fix remotes using M-x straight-normalize-all
Fetch new revisions using M-x straight-fetch-all (or M-x straight-x-fetch-all; that function really needs to be merged into the core library)
Reset all packages to correct revisions using M-x straight-thaw-versions

Because as you have noticed, if you don't perform all of these steps, then you may find errors during startup. This is really annoying, frankly, and a big problem for UX. But I don't really think automatic updates is the correct solution—after all, other breakage can also result if all the packages aren't reset to the versions in the lockfile.

I think what you are missing is running M-x straight-thaw-versions on the new machine. That needs to be done before you start Emacs, otherwise your configuration can't be expected to work. To do the work manually, you can just navigate to ~/.emacs.d/straight/repos/melpa and check out the revision listed in your lockfile.
I think that there should be a way for straight.el to be told to do this automatically when appropriate, but for now this is the workaround.
But maybe your real problem is that straight.el doesn't complete startup successfully, which means that Emacs is not fully functional and isn't aware of all of your packages. This is indeed a major problem—and one which really needs to be fixed—but at least it will be aware of MELPA when it errors, so you should be able to have it thaw the version for MELPA, and then restart.

Maybe you're expecting straight.el to interact with the Git repositories in some way at startup. That simply isn't done, both for performance and because it allows you to make arbitrary local changes without additional steps. You need to run the interactive functions to request changes to be made to the Git repositories (M-x straight-normalize-all, M-x straight-fetch-all, M-x straight-thaw-versions).

Aha, ok, I think that's exactly where I was wrong - this isn't super clear from the docs, and I think my main confusion stems from straight downloading packages on startup that I added to the init file (and failing for the packages that aren't available in the recipe repos that are currently checked out).
I think I can make my workflow work this way, but I've found a separate weird interaction trying out this normalize/fetch/thaw flow:

Run M-x straight-normalize-all, M-x straight-fetch-all, M-x straight-thaw-versions in sequence
Run M-x straight-freeze-versions
Inspect the versions/default.el file

From your description, I would expect a freeze after a thaw to be a no-op. But if I check the diff on the frozen versions file, it shows that freezing reverted back to the versions that were checked out previously (my canary is ace-window which gets re-frozen to a version from January, when the frozen versions previously contained one from June).
I tried restarting emacs a few times between thaw and freeze, but it's the same behavior every time - freeze reverts frozen versions to the versions that were checked out previously.

What you describe sounds like a bug. I don't see any problem with your steps. Do you think you can provide a minimal init-file and lockfile that reproduce the problem?

Actually, it would be best if you could open a new issue about that bug, so we can leave this one for discussion of documentation improvements :)


adding turf functions

Going to clean up some issues here:

[x] TURF: Add midpoint operation #90
[ ] TURF: Add extent operation #89
[x] TURF: Add destination operation #87
[x] TURF: Add along operation #85
[x] TURF: Add explode operation #84
[x] TURF: Add simplify operation #82

Adding midpoint:

Destination:

along

explode

Hmmm, stuck at the end with simplify. I've written tests and they pass, but when I execute the function in the app the feature is only replicated, and not simplified.

@mapsam Took a look at simplify, seems like there were two problems:

We were using parseInt rather than parseFloat for any number input, meaning that any tolerance < 1 would be 0. Effectively, disabling it.
Using a select for a boolean seems a bit weird. The value that comes from a select is always a string. We could do something like if (value == 'false' || 'true') value = parse(value);, but I still feel like a checkbox is a better representation of a boolean.

Before:

After:

Nice debugging! Thanks for adding some extra love to this. Agreed on checkbox considering there are other functions that will have options like this.
Considering this ready to merge if it looks good to you.

Done, good work on this!


Update Face README

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
API changes are not detected in this pull request.

@Han-msft : When you're ready to merge, mention me and I'll push the button.

@jsquire we are ready to merge. I asked Crystal to help me. Thanks!


how can i use( Apple/mac's ) command  key for shortcut creation ?

@jpca999 See the "Supported Keys" section of the Moustrap docs. But in short, just use "command" a you would "ctrl" in combos.

Or since Mousetrap 1.4 use mod+s

On Mac this ends up mapping to command+s whereas on Windows and Linux it maps to ctrl+s.


setCallbacks inconsistent deprecation warning

Which version and edition of Flyway are you using?
5.2.0
If this is not the latest version, can you reproduce the issue with the latest one as well?
(Many bugs are fixed in newer releases and upgrading will often resolve the issue)
Yes
Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin)
Java API
Which database are you using (type & version)?
N/A
Which operating system are you using?
N/A
What did you do?
(Please include the content causing the issue, any relevant configuration settings, the SQL statement that failed (if relevant) and the command you ran.)
Nothing specific
What did you expect to see?
Calling setCallbacks is deprecated according to the Javadoc in favour of Flyway.configure so the warning message should reference this method rather than a reference to an already deprecated method.
What did you see instead?

Flyway.setCallbacks(FlywayCallback) has been deprecated and will be removed in Flyway 6.0. Use Flyway.setCallbacks(Callback) instead.

Good catch! We actually had a number of cases like this, which have now all been fixed.


Add agents versioning and publishing doc

Signed-off-by: Pavol Loffay<EMAIL_ADDRESS>Ported from https://github.com/hypertrace/hypertrace/pull/113 and https://github.com/hypertrace/javaagent/pull/81

@hypertrace/agent-maintainers could you please review?


Uninstalling the plugin

Please suggest the correct way to uninstall the plugin.
I tried to remove it from plugins directory and run 'rake redmine:plugins:migrate RAILS_ENV=production'
It seemed to be ok at first, but then different problems emerged. I even can't backup my DB.
It shows: mysqldump: Got error: 1286: Unknown storage engine 'Mroonga' when using LOCK TABLES
Had to return the plugin back and managed to backup the redmine DB.

Sorry, I uninstalled it correctly and now everything is ok.


Better results when I having reimplement the "2D_FFTs" convolution with PyTorch

Hi, Sascha,
Appreciate very much your great work on the blog of "Fourier Convolutions with Kernel Sizes of 1024x1024 and Larger"!
I have got better results after reimplementing the "2D_FFTs" convolution with PyTorch, as,
Mean Absolute Error: 6.840202217972546e-07
Standard deviation: 6.106938030825404e-07

Thank you again for a lot of knowledge learned from your blog!

Hi songyuc,
happy to hear that the article motivated you to implement it yourself!
Great results! The errors in both cases are very small and caused by the quntazition of values stored on the computer. Probably in pytorch you required less commands to implement the fourier convolution or used a datatype with higher accuracy.
All the best,
Sascha


Color labels to help highlight or categorize folders or files

Is your feature request related to a problem? Please describe.
In the past, MacOS had a really handy way to add color labels to files and folders to help categorize them (e.g. business vs personal) or just highlight them so they got your attention more quickly while scanning down a list. Personally I find this sufficient, and without the complexity of tags, though I know some people love tags. It also means I can more quickly find things, but without having to add them to the sidebar.
Describe the solution you'd like
Screenshot attached of what this could look like in list view. Designs would be needed for tile and icon views as well - if there's interest (and technical feasibility) in this idea, I can work up some.
There would be a way to assign, change and remove colors to individual or multiple items. Could be done in the ellipsis menu or with contextual menu. MacOS also allowed you to assign word labels to the colors - not sure how often this was used so maybe less important.
Describe alternatives you've considered
Tags - but (personally speaking), these take more time to manage, and are not as good for quickly finding a type or important item in a list as it requires more reading.
Additional context
A downside to this is that it may be meta data than traditional File Explorer can't make use of, unless there's a way to convert it into some searchable entity. There is a plugin of sorts for Windows called Folder Colorizer IIRC, which I have used, but it's not particularly user friendly, and it only works on folders, not files.

Duplicate of #1161

Thanks! I'd done a search but hadn't turned that one up.


Support for Exercises directive & Added Chinese translation (zh_CN)

support for exercise directive
add translation to Chinese
change encoding to "utf8" in the _convert.py to be compatible more languages
translation json for exercise directive
pre-commit runs

Co-authored-by: Ming Yang<EMAIL_ADDRESS>

thanks for this PR @11Haoyu -- I will review soon and see if we can get this merged.

Codecov Report
Base: 96.13% // Head: 96.17% // Increases project coverage by +0.04% :tada:

Coverage data is based on head (f43d4b9) compared to base (d37495f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
+ Coverage   96.13%   96.17%   +0.04%
==========================================
  Files           6        6
  Lines         362      366       +4
==========================================
+ Hits          348      352       +4
  Misses         14       14

Flag
Coverage Δ

pytests
96.17% <100.00%> (+0.04%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

sphinx_proof/nodes.py
93.63% <100.00%> (+0.11%)
:arrow_up:

sphinx_proof/proof_type.py
100.00% <100.00%> (ø)

sphinx_proof/translations/_convert.py
93.33% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@11Haoyu there are just a few pre-commit issues re: styling etc.
Running pre-commit will solve these for you locally
https://pre-commit.com


Add name

Related issue

What changes does this PR do?
Screenshots (If any)
Questions

Hi @RakeshSangem, sure, done. Do I need to request a new pull request?

Hi @RakeshSangem, sure, done. Do I need to request a new pull request?

No, you can make changes in the same PR. 🙂


added script to download formatted tweets from a specific user

please add your name to contributor list😅

done :D

Thank you for your help, and congrats on your first pr to this repo!!🎉
If you like this repo don't  forget to 🌟.


added Auto-Anvil

Please tell me if the page doesnt meet your requirements, I edited this in the github web IDE so yeah :D

Okay,time to edit this in a real editor. Should I also put a section about crafting or is that self explanatory?

Okay,time to edit this in a real editor. Should I also put a section about crafting or is that self explanatory?

Okay,time to edit this in a real editor. Should I also put a section about crafting or is that self explanatory?

They can find it in the in-game guide at /sf guide. So no.

Okay,time to edit this in a real editor. Should I also put a section about crafting or is that self explanatory?

They can find it in the in-game guide at /sf guide. So no.

The file is also missing an ending (.md)

The file is also missing an ending (.md)

Just wanted to mention #93 also adds this page (and that it still hasnt gotten a second person to review it)

Just wanted to mention #93 also adds this page (and that it still hasnt gotten a second person to review it)

Closed

Closed


Rewriter produces incorrect debug information for async methods in PDB file

It looks like CC rewriter produces incorrect table of yield/resume offsets for the MoveNext() method of the async state machine. As a result it's not possible to step through async methods with the VS debugger.
First, if you don't define any conditions in the project with CodeContracts enabled, the rewriter still modifies the IL of the assembly slightly and instruction offsets change. However debug info is not updated accordingly.
Second, if you add some conditions to the project, then debug info is updated but still contains incorrect offsets.
To reproduce, you can open the attached solution in the VS and try to step through Method1(). The debugger loses track of the method execution after the first await. If CodeContracts are disabled, then stepping through the method works correctly again.
AsyncDebugging.zip

Note that this is fixed if you create your own build of CodeContracts. It was fixed by using a new version of Cecil if I recall (old version was not async aware). It is not fixed in the public release.


[5.5] Rename example component to keep consistency with laravel/laravel repo

The example Vue.js component was renamed in the laravel/laravel repo in this pull request: https://github.com/laravel/laravel/pull/4447. This was done in order to follow the Vue.js style guide.
I've made the same changes in the vue preset stubs.

@PawelMysior They also changed the component name to example-component?

Right! Missed it, I'll make another PR. Thanks for pointing that out.


[nuspell] Update port to v5.1.1

Describe the pull request
Updates port Nuspell to the latest version.

Does your PR follow the maintainer guide?

Yes

Feature tools tested successfully in the following triplet:
x86-windows
x64-windows
x64-windows-static


z-input: add validity state in inputChange and stopTyping events

Approved with condition: we should open an issue to tackle the compatibility of the required attribute with the custom select component.

@edoardocavazza agreed! I started a little refactor of the select input (soon we're going to have an autocomplete select, and I think it's going to become a complex component), I believe we can integrate this task in the refactoring.


coins/constants: New regtest functionality

Testing:
Coins.py main
coins.py.txt
electrum-firo-env
. . .
if [ -z "${REGTEST}" ]
then
    echo 'normal startup mainnet'
    ./electrum-firo "$@"
else
    echo "startup on the electrumX regtest network with one tcpip server at <IP_ADDRESS>:50001:t"
    ./electrum-firo -v --regtest --oneserver --server <IP_ADDRESS>:50001:t
fi

May I know which test failed please?
Is it logic, linting ?

Thank you


Update FGFXLargeScalePerceptualObscuranceIrradiance.fx

Adding a threshold setting to FGFXLargeScalePerceptualObscuranceIrradiance.fx

@snyviper Many thanks for the commit. Please see the review comments.

Ah, I messed up a little bit with this pull request, please check the one that's still open, it has a lot more info 😄

Hi,
No worries, it happens. :) Make sure to change the function name as
suggested and many thanks for the commit!

Alex

On Sat, Nov 16, 2024 at 5:19 PM Snyviper @.***> wrote:

@AlexTuduran https://github.com/AlexTuduran Ah, I messed up a little
bit with this pull request, please check the one that's still open, it has
a lot more info 😄
—
Reply to this email directly, view it on GitHub
https://github.com/AlexTuduran/FGFX/pull/1#issuecomment-2480609380, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ACYO24REQF37JXAKPMSVTF32A5PBPAVCNFSM6AAAAABR4MBKLCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBQGYYDSMZYGA
.
You are receiving this because you were mentioned.Message ID:
@.***>


Add user info to ufs block read metrics

What changes are proposed in this pull request?
Add user information to ufs block read counter metrics
Why are the changes needed?
Support showing user info in ufs block read metrics.
Does this PR introduce any user facing changes?
N/A

Codecov Report

Merging #13820 (ee341a8) into master (3f343ec) will decrease coverage by 20.96%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master   #13820       +/-   ##
=============================================
- Coverage     43.64%   22.67%   -20.97%
+ Complexity     9093     4202     -4891
=============================================
  Files          1386     1386
  Lines         80552    80556        +4
  Branches       9803     9804        +1
=============================================
- Hits          35158    18269    -16889
- Misses        42450    61072    +18622
+ Partials       2944     1215     -1729

Impacted Files
Coverage Δ

.../java/alluxio/worker/block/DefaultBlockWorker.java
0.00% <0.00%> (-64.16%)
:arrow_down:

...luxio/worker/block/UnderFileSystemBlockReader.java
0.00% <0.00%> (-73.89%)
:arrow_down:

...lluxio/worker/block/UnderFileSystemBlockStore.java
0.00% <ø> (-43.11%)
:arrow_down:

...common/src/main/java/alluxio/grpc/GrpcService.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...common/src/main/java/alluxio/time/TimeContext.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...mmon/src/main/java/alluxio/metrics/MetricInfo.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...mmon/src/main/java/alluxio/time/ThreadSleeper.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...mon/src/main/java/alluxio/concurrent/LockMode.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...mon/src/main/java/alluxio/shell/CommandReturn.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...mon/src/main/java/alluxio/util/ExceptionUtils.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 589 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f343ec...ee341a8. Read the comment docs.

@LuQQiu curious how the user specific metrics will be used? and are we planning to have per-user metrics for other read types?

alluxio-bot, merge this please


Extremely low information density across all blogs

Steps to reproduce

Navigate to https://blogs.windows.com/windows-insider/2020/09/16/announcing-windows-10-insider-preview-build-20215/
Observe only ~40 words appear on the page

Impact

Increases difficulty in reading the page
Increases difficulty in finding the information I need
Decreases likelihood I want to continue participating in the Insider program

Screenshot

The blogs appear to be optimized for mobile at the expense of desktop. Most insiders will likely be desktop users and this provides a very poor experience for them.
On mobile, the site is acceptable, but could use some tweaking for better information density. iPhone 7 Plus:

Another screenshot, when clicking on a tag.


[SPARK-27132][SQL] Improve file source V2 framework

What changes were proposed in this pull request?
During the migration of CSV V2(https://github.com/apache/spark/pull/24005), I find that we can improve the file source v2 framework by:

check duplicated column names in both read and write
Not all the file sources support filter push down. So remove SupportsPushDownFilters from FileScanBuilder
The method isSplitable might require data source options. Add a new member options to FileScan.
Make FileTable.schema a lazy value instead of a method.

How was this patch tested?
Unit test

@cloud-fan @dongjoon-hyun @HyukjinKwon
This PR is the "non-csv-datasource" part of https://github.com/apache/spark/pull/24005. It contains several improvements.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8795/
Test PASSed.

Test build #103368 has started for PR 24066 at commit 34c1ce6.

Test build #103368 has finished for PR 24066 at commit 34c1ce6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103368/
Test PASSed.

Could you rebase to the master, @gengliangwang ?

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8904/
Test PASSed.

Test build #103488 has started for PR 24066 at commit 144b076.

Test build #103488 has finished for PR 24066 at commit 144b076.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103488/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8911/
Test PASSed.

Test build #103498 has started for PR 24066 at commit 6475d4f.

Test build #103498 has finished for PR 24066 at commit 6475d4f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

thanks, merging to master!


fix: ignore metrics for block volume

Signed-off-by: Abhinandan Purkait<EMAIL_ADDRESS>

bors merge


STYLE: Do not declare CumulativeGaussianCostFunction data as pointer

It appears unnecessary to manually manage the memory pointed to by its members, m_OriginalDataArray and m_MeasurePointer.
Defaulted its default-constructor and its destructor.

/azp run ITK.macOS


rehype-katex options

Hi, thanks for this awesome project. I have a question: according to rehype-katex doc, katex options could be passed along. However, I’m not seeing how I could pass katex options (e.g. macro definitions) when specifying rehype-katex as a rehype plugin.
Thanks!

Hi there!
The examples on how to pass (remark and) rehype show this: https://github.com/wooorm/xdm#optionsrehypeplugins

Oh great, thank you!


Fix dimmed ObjectName

Problem discovered when tracking down: https://github.com/storybooks/storybook/issues/1385
The ObjectName component was incorrectly applying the dimmed prop when set to true, by looking to the custom styles property instead of the current theme as intended. I corrected the issue along with adding tests to target this behavior.

Looks good to me, will release it now! 👍
Thank you @jasonphillips !

released as:
<EMAIL_ADDRESS>


Werror as cmake option

Adds the option WERROR to cmake, which will enable Werror for C and C++. To maintain compatibility the option is default OFF.
Related issue: #1003

Coverage remained the same at 99.875% when pulling 1e5334913fbbe52056b9b9185be245835ec5ba21 on offa:cmake_werror_option into 9ae6f015c398fd42692d034389ffb659526fcc66 on cpputest:master.

Appveyor failure seems related to an install issue of mingw.

@offa This is a known issue (#1016). You can trigger a new build, by closing and re-opening the PR. This works... sometimes.

At least it's not code related.

Coverage remained the same at 99.875% when pulling 1e5334913fbbe52056b9b9185be245835ec5ba21 on offa:cmake_werror_option into 9ae6f015c398fd42692d034389ffb659526fcc66 on cpputest:master.


Run Travis build on both OS X and Linux

Our filemonitoring code varies by OS but was only being run on Linux in Travis.

r? @russelldavis (I feel like you asked me if this was possible at one point and I said it wasn't...)

woo 👍


Parameterize tests for concurrent search 3

Description
Parameterizing first batch of ITs with concurrent search enabled as part of this PR.
List of ITs Parameterized in this PR:

AbstractGeoAggregatorModulePluginTestCase.java
AbstractGeoBucketAggregationIntegTest.java
AbstractTermVectorsTestCase.java
AdjacencyMatrixIT.java
CancellableTasksIT.java
ClusterStatsIT.java
DateHistogramIT.java
DateHistogramOffsetIT.java
DelayedShardAggregationIT.java
EquivalenceIT.java
GeoBoundsITTestCase.java
GeoCentroidITTestCase.java
GeoHashGridIT.java
GeoModulePluginIntegTestCase.java
GeoTileGridIT.java
GetTermVectorsIT.java
HighlighterWithAnalyzersTests.java
IndexSortIT.java
MatchPhraseQueryIT.java
MissingValueIT.java
MoreExpressionIT.java
MultiSearchTemplateIT.java
MultiTermVectorsIT.java
PercolatorQuerySearchIT.java
QueryStringWithAnalyzersIT.java
RankEvalRequestIT.java
SearchStatsIT.java
ShardReduceIT.java
ShardSizeTermsIT.java
ShardSizeTestCase.java
SimpleMgetIT.java
StoredExpressionIT.java
SuggestStatsIT.java
TermsShardMinDocCountIT.java
AbstractGeoTestCase.java

Related Issues
Resolves #9443

Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff
[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/25406/
CommitID: a9f2d13
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

https://github.com/opensearch-project/OpenSearch/issues/9464 - flaky test

@sohami /@reta can u please merge this?


Dell U4320Q Not recognized - iMac Mini M1

Checklist

[x] I have searched for existing issues
[x] I have looked through the Monitor Troubleshooting wiki
[x] I have updated MonitorControl to the latest version

Describe the issue
I have 2 external Dell U4320Q monitors connected to my iMac 2020 Mini
Expected behavior
Monitors not being recognized.
Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.
Environment Information (please complete the following information):

macOS version: Bug Sur v 11.2.3
MonitorControl version: 2.1.0 (Bud 721)
Monitor(s): U4320Q
Mac model: Mac mini M1
Monitor Cable(s)/Connection(s): (e.g. DisplayPort)
1 - Thunderbolt USB-C
2 - HDMI

I am having the same issue with my Samsung Monitor on M1 Mac Mini as well.
Environment Information (please complete the following information):
macOS version: Bug Sur v 11.2.3
MonitorControl version: 2.1.0 (Bud 721)
Monitor(s): 34" CJ791 Thunderbolt 3 Ultra Wide Screen Curved Monitor
Mac model: (Base 8GB) Mac mini M1
Monitor Cable(s)/Connection(s): (e.g. DisplayPort)
1 - Thunderbolt USB-C
2 - HDMI

Please see #323


add Clang sanitizer checks in CI

Coverage remained the same at 99.046% when pulling b6b8638b2d52e453e248b38f5b098ffd033c3477 on isaacbrodsky:fsanitize-in-ci into 59a419658b1ca24bd408cab7812128a45b936d11 on uber:master.

Does this supersede https://github.com/uber/h3/pull/710?

Does this supersede #710?

No, that PR appears to be addressing a different issue in the ratio calculation, it doesn't address the divide by zero problem.


introduce ledger connector

Description
This PR restores the Ledger connector. (reverting https://github.com/wevm/wagmi/commit/53ca1f7eb411d912e11fcce7e03bd61ed067959c) and migrating the old connector to v2 of wagmi.
It now loads the @ledgerhq/connect-kit package without going through @ledgerhq/connect-kit-loader's loadConnectKit function.
@ledgerhq/connect-kit is thus added (with a fixed version, 1.1.9) in packages/connectors/package.json
Additional Information
@ledgerhq/connect-kit-loader is removed from the required packages.
Additional security measures taken:
Two new github workflows on the @ledger/hq-connect-kit repository:

one checking any discrepancy between the version in that repo and the one published on npm, to alert ASAP (unlike during the exploit): https://github.com/LedgerHQ/connect-kit/actions/workflows/check_npm_repo.yml

the second using CodeQL to discover vulnerabilities early: https://github.com/LedgerHQ/connect-kit/actions/workflows/github-code-scanning/codeql

Looking pretty good overall. The only thing that gives me pause is this CDN URL getting loaded by @segment/analytics-next. Seems like they have things covered in their SDK (link), but could be a possible vector. It would be nice if there was a flag disabling this, or at least a callout in the docs so folks are aware, e.g. someone can set up a Content Security Policy to block it if they need to.

@tmm I've considered if we really needed analytics (and thus the segment library) and we decided that it could be entirely removed. Less attack surface is a good thing, thanks for your review 👍

Very happy where this is at! Thanks for the updates.
It takes time and effort to maintain third-party connectors. Since Wagmi is an OSS project that depends on sponsors and grants to continue our work, third-party connectors must sponsor Wagmi via GitHub or another method in order to be included in the monorepo (communicated to the team via Slack). Once that is done, we can wrap up any remaining work, merge, and release.


Add Package.swift

Hey @fmo91,
Your project looks very interesting. Please consider this simple pull request to add SPM support.
Best,
Andreas

Hi @andtie . Thank you very much for your PR! I'll merge it tonight.


OCPBUGS-7106: Get OVN-Kubernetes leader identity from the lease

Starting in Kubernetes v1.26, OVN-Kubernetes uses the lease API to publish the leader identity.
To keep backwards compatibility fallback to a configmap.
Signed-off-by: Patryk Diak<EMAIL_ADDRESS>

/jira refresh

/lgtm

/lgtm
this works! sorry for being late to party lol.


No increase in code coverage

Hello,
The model doesn't save the test units as a .py file when there is no increase in code coverage. it saves them as log file. is there an option to override that?

No, currently there isn't, but it would be relatively easy to add. I'm curious, though: how that would be useful?

i had a python code with bug in it. i also had a unit test that didn't reveal the bug. the coverage didn't increase after prompting with chat gpt, so the test cases weren't saved. when i was reading log file, one of the test cases would be able to detect the bug. Just something that i came across.
Any way, propos for the great work.

Thank you :)
I am not quite clear on the situation, though... was the test dropped because it (exposed the bug and) failed, or because it didn't increase coverage?

because it didn't increase coverage.