Error while reusing  BatchMessage object

Package Name: azure-servicebus
Package Version: 7.4.0
Operating System:Linux (Ubuntu 18.04)
Python Version: 3.8.12

Describe the bug
from this we have created service bus client :
servicebus_client = ServiceBusClient.from_connection_string(conn_str=sender_connection_string)
created a sender object:
sender = servicebus_client.get_topic_sender(topic_name=topic_name)
batch_message = sender.create_message_batch()
So when we deepcopying the batch_message instance we got following issue
topic_message_batch = copy.deepcopy(batch_message)
File "/usr/local/lib/python3.8/site-packages/uamqp/message.py", line 141, in getstate
state = deepcopy(state, memo)
File "/usr/local/lib/python3.8/copy.py", line 146, in deepcopy
state["state"] = self.state.value
AttributeError: 'BatchMessage' object has no attribute 'state'
while using 7.0.0 of azure_servicebus  we haven't faced any issues and everying was running fine.

Hi @Vprashant, thank you for opening an issue! I'll tag the appropriate folks so we can look into this as soon as possible.

Hey @Vprashant - apologies for the late response! I was able to reproduce the error with azure-servicebus==7.4.0, and I believe that this is related to some changes that were made in the underlying uamqp library dependency. More specifically, we added support for pickling to uamqp==1.3.0: https://github.com/Azure/azure-uamqp-python/blob/master/HISTORY.rst#130-2021-04-05.
You may not have noticed these changes if you updated directly from azure-servicebus==7.0.0 (uamqp < 1.3.0) to azure-servicebus==7.4.0  (uamqp >= 1.4.3).
Just to double check, can you confirm the uamqp dependency versions that you are using for servicebus 7.0.0 and 7.4.0?

Hey @swathipil - uamqp dependency versions
uamqp==1.2.12
azure-servicebus==7.0.0
uamqp==1.4.3
azure-servicebus==7.4.0
Yes , I haven't used 7.1.1 , I directly move to azure-servicebus==7.4.0 from azure-servicebus==7.0.0

@Vprashant thanks for the quick response!
As a follow-up:
You mentioned that copy.deepcopy(message_batch) worked when you used azure-servicebus 7.0.0 and uamqp 1.2.12. When I try to do the same, I get the following error:
  File "stringsource", line 2, in uamqp.c_uamqp.StringValue.__reduce_cython__ TypeError: no default __reduce__ due to non-trivial __cinit__. Is this not an error that you encounter?
(It's surprising that you didn't, given that we added the uamqp pickling support originally due to this error.)

Hi  @swathipil,
No, I had't faced that above mentioned error; while working with azure-servicebus 7.0.0 and uamqp 1.2.12

Hey @Vprashant - thanks for your patience!
I tested azure-servicebus==7.0.0 with the uamqp version you had, and I am still getting the non-trivial __cinit__ error. Would you be able to run pip freeze on your azure-servicebus==7.0.0 that was working and share it here?
The problem here is with the underlying uamqp.BatchMessage C object. We would need to overload the __reduce__ method in BatchMessage. To modify the uamqp library and release it, it will take a little bit of time.
As a temporary solution, would you be able to add the ServiceBusMessage objects to a list, copy the list, and send the messages? The ServiceBusMessage objects can be deepcopied. Example here:
sender = servicebus_client.get_topic_sender(topic_name=topic_name)
messages = [ServiceBusMessage("Message in list") for _ in range(10)]
messages_copy = copy.deepcopy(messages)
sender.send_messages(messages)
sender.send_messages(messages_copy)

Just in case you are curious, here are a few issues related to this same error:
https://github.com/Azure/azure-sdk-for-python/issues/12901
https://github.com/Azure/azure-sdk-for-python/issues/15772

Hi @swathipil ,We are using a premium tier service and we need to use batching in our solution, for azure-servicebus==7.0.0 version. In my last message I mention the version in the attached image ( pip list | grep azure-servicebus).
$ pip freeze | grep "azure"
azure-common==1.1.26
azure-core==1.9.0
azure-eventhub==5.2.0
azure-functions==1.7.2
azure-servicebus==7.0.0
$ pip freeze | grep "uamqp"
uamqp==1.2.12
So for now, the temporary solution is not solving our batching issue. Let me know if you find something that works on batching service.

Will update you on our plans after I discuss with the team. Thanks!

Hey @Vprashant - we were able to fix this issue in the following PR: https://github.com/Azure/azure-uamqp-python/pull/310
This will fix will be out in the next uamqp release and the uamqp dependency version will be bumped for the next azure-servicebus release. To avoid waiting for the azure-servicebus release, you can install uamqp==1.5.2 after it is released.
More details if you're interested: The uamqp.BatchMessage inherited __getstate__/__setstate__ methods (used in copy.deepcopy) from the Message superclass. The methods needed to be overridden in BatchMessage.

issue-addressed


Focus management

It's not clear from the documentation that focus management is supported. That is, when jumping to a selector, this element would be focused so that keyboard interaction is localized to the newly "jumped to" element.
If this is not supported, I suggest there is an accessibility issue for keyboard and AT users and would be happy to answer any questions you might have about addressing it.
Thanks!

to my knowledge, the library doesn't currently do anything to manage the focus. in terms of addressing accessibility, and focusing the target after the jump is complete, is it as simple as .focus() on the element that's been scrolled to? i'm a bit naive when it comes to accessibility so I'd appreciate your input

ping @Heydon

Hey Michael. Yeah, the element that is animated to should be focused at the
end of the animation (callback function, maybe?) The element should be made
programmatically focusable by giving it tabindex="-1" before you use the
focus() method on it. Hope that helps. Ask if you need anything more :-)
On 2 Dec 2015 19:59, "Michael Cavalea"<EMAIL_ADDRESS>wrote:

ping @Heydon
—
Reply to this email directly or view it on GitHub.

sounds good, i'll take a shot at implementing this in the _end() method. this is the method that fires the callback, at the end of the jump

Oh, that sounds perfect. Nice one!
On 2 Dec 2015 21:15, "Michael Cavalea"<EMAIL_ADDRESS>wrote:

sounds good, i'll take a shot at implementing this in the _end() method.
this is the method that fires the callback, at the end of the jump
—
Reply to this email directly or view it on GitHub
https://github.com/callmecavs/jump.js/issues/16#issuecomment-161435951.

does -1 or 0 make more sense for the tabindex? looking at this, it seems as though 0 may be the better choice, because a negative value means the element would be otherwise unreachable by keyboard navigation

-1 means focusable but only programmatically. This is suitable because
you're only focusing the element to move the user into the right area. 0
would mean the element is permanently focusable, which would not be
suitable because (typically) it would not be an interactive element like a
link or button; just a container. Does that make sense?
On 2 Dec 2015 22:01, "Michael Cavalea"<EMAIL_ADDRESS>wrote:

does -1 or 0 make more sense for the tabindex? looking at this
https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/tabindex,
it seems as though 0 may be the better choice, because a negative value
means the element would be otherwise unreachable by keyboard navigation
—
Reply to this email directly or view it on GitHub
https://github.com/callmecavs/jump.js/issues/16#issuecomment-161447367.

makes perfect sense. thanks for the great explanation

@Heydon running into a problem with adding a tabindex and calling focus() on the element - browsers draw a blue outline around the element, like they would a form element, as seen in the screenshot below. is there any way you know of to avoid this?

the code for this is on the focus branch if you want to play around with it: https://github.com/callmecavs/jump.js/tree/focus

There are a few ways around this. The absolute worst—how do I stress this further?—thing to do is to disable the outline:
element:focus { outline: none }
A better way to do it is to animate that outline into oblivion on focus:
element:focus {
  animation: outline 1s;
}

@keyframes outline {
  to {
    outline-color: transparent;
  }
}

Another option that involves animation, but allows you to “make things prettier”: you can animate anything you want on focus. So you could disable the outline—contradicting what I said earlier; the important thing is that focus is visible—on the focused element, but animate the background from a noticeable different colour—say yellow—to the original colour—say white—and thus make it clear where focus went on the page.
You could of course also drop the animation and make focus noticeable permanently, but that is a design choice.

I actually disagree here. Tabindex="-1" programmatically focused elements
don't necessarily need a focus style. That the element / area is pulled
into view is enough. You can, however, get creative with animated focus
styles. Perhaps this should be communicated to potential authors?
On 4 Dec 2015 13:46, "Michiel Bijl"<EMAIL_ADDRESS>wrote:

There are a few ways around this. The absolute worst—how do I stress
this further?—thing to do is to disable the outline:
element:focus { outline: none }
A better way to do it is to animate that outline into oblivion on focus:
element:focus {
animation: outline 1s;
}
@keyframes outline {
to {
outline-color: transparent;
}
}
Another option that involves animation, but allows you to “make things
prettier”: you can animate anything you want on focus. So you could disable
the outline—contradicting what I said earlier; the important thing is that
focus is visible—on the focused element, but animate the background from a
noticeable different colour—say yellow—to the original colour—say white—and
thus make it clear where focus went on the page.
You could of course also drop the animation and make focus noticeable
permanently, but that is a design choice.
—
Reply to this email directly or view it on GitHub
https://github.com/callmecavs/jump.js/issues/16#issuecomment-161959574.

After thinking about it for a bit, that makes sense. I use animated focus styles for skip links, but not consistently it seems. I thought I read a WebAIM article on it once, but can only find one that advises to use animation to keep (hidden) skip links visible for a short period after you've focused them.
It would be good to add this to the documentation. Maybe something like:

Focus management
To aid keyboard and assistive technologies (AT) users; it is important that focus is moved to scrolled to element. Jump.js does this automagically. By default visual aids of focus are disabled. Authors are free to enable such aids via CSS.

What would happen if an author uses Jump.js to scroll to an interactive element?

my preference would be to include as little CSS in the library as possible. im happy to set outline: none on the element that's jumped to from the JS, but don't want to make a stylesheet required to use the library. i'm leaning towards the solution above - disabling the outline, and mentioning accessibility in the README. that seems to be in line with both of your thinking - does this seem like a reasonable solution?

If there was something that prevented the outline being disabled on interactive elements; I would agree to that resolution.
CSS could look something like this—probably forgot a couple:
[tabindex="-1"]:not(a, input, button, textarea, select, [role*="button"]) {
  outline: none;
}

This is compliant with Jump.js' browser support.

the thing is, I only want to use CSS that I can control from JS. that rule requires getting more than just the element scrolled to, and injecting into the <head>, etc

Fair enough. It would be possible to check against the same list in JavaScript right? Some automation is desirable I think.

@Heydon are thoughts on focusing the target element, and setting outline: none on it?
also, congrats on getting into the collective with your flexbox writeup, Jump is in it this week as well :beers:

@MichielBijl if users are jumping to one of those elements, they can restore the outline in the callback function. I think since that'll be the less common case, it makes sense. thoughts on that?

Oh, thanks! What's the collective?
I think I would personally just leave it to the author to remove that
outline if they so wished.
On 7 Dec 2015 15:39, "Michael Cavalea"<EMAIL_ADDRESS>wrote:

@Heydon https://github.com/Heydon are thoughts on focusing the target
element, and setting outline: none on it?
also, congrats on getting into the collective with your flexbox writeup
<EMAIL_ADDRESS>Jump is in it this week as well [image: :beers:]
—
Reply to this email directly or view it on GitHub
https://github.com/callmecavs/jump.js/issues/16#issuecomment-162543283.

I'm with Heydon on this; some documentation or a reference to this issue, could help authors with understanding the issue with focus outlines. If that is a no go for what ever reason, target.style.outline = 'none' should do fine with a clear warning in the documentation.

@Heydon Tympanus Codrops does it - it's a weekly roundup of web design and development projects. here's the link to this weeks (that we're both in): http://tympanus.net/codrops/collective/collective-197/
@Heydon @MichielBijl okay, i guess I'll take a stab at not touching the outline and letting people handle it themselves. feel like it may lead to a lot of questions tho

@Heydon will be included in v1, behind a flag. the only reason for me disabling it by default is because it requires a CSS change to prevent the blue outline

(y)

@Heydon thanks for bringing it up, and hashing it out with me. my apologies for it taking so long to add

0pp0p00p00pp00p00000000
---------- Forwarded message ----------
From: "Sidebar"<EMAIL_ADDRESS>Date: 29 Dec 2017 17:04
Subject: Get Taxi, Trainline UX, Range Input, Worst Reviewed, 2017 Case
Studies
To<EMAIL_ADDRESS>Cc:
The 5 best design links, every day. Curated by a selection of great
editors.
[image: Sidebar]
https://sidebar.us2.list-manage.com/track/click?u=b5af47765edbd2fc173dbf27a&id=913710426d&e=dd1dd5a5cb
https://sidebar.us2.list-manage.com/track/click?u=b5af47765edbd2fc173dbf27a&id=05eb0917bc&e=dd1dd5a5cb
UI/UX Case Study : A Brand New "Get Taxi Experience"
https://sidebar.us2.list-manage.com/track/click?u=b5af47765edbd2fc173dbf27a&id=e51f9793cc&e=dd1dd5a5cb
medium.com
https://sidebar.us2.list-manage.com/track/click?u=b5af47765edbd2fc173dbf27a&id=ac1dd32ab1&e=dd1dd5a5cb
I tested the existing "GetTaxi" app with 10 participants in problematic
pickup areas around Tel Aviv.
Case Study UX
Submitted by Sacha Greif
https://sidebar.us2.list-manage.com/track/click?u=b5af47765edbd2fc173dbf27a&id=901fa80875&e=dd1dd5a5cb
[image: Share by email]

[image:
Share on Twitter]

[image:
Share on Facebook]

Have Trainline nailed their UX?

uxplanet.org

Quick feature thoughts and improvements for the Trainline app.
Critique UX

Submitted by Sacha Greif

[image: Share by email]

[image:
Share on Twitter]

[image:
Share on Facebook]

A Sliding Nightmare: Understanding the Range Input

css-tricks.com

You may have already seen a bunch of tutorials on how to style the range
input.
CSS

Submitted by Sacha Greif

[image: Share by email]

[image:
Share on Twitter]

[image:
Share on Facebook]

The Best and Worst Identities of 2017, Part 3: The Worst Reviewed

underconsideration.com

Each year this list gets less and less juicy with very few clunkers, which
is a good thing for our visual environment.
Branding

Submitted by Sacha Greif

[image: Share by email]

[image:
Share on Twitter]

[image:
Share on Facebook]

Case Studies: Best of 2017

medium.com

When reading through design case studies we get to go on a trip with the
designer and follow their trail of thought.
Case Study

Submitted by Jan Wennesland

[image: Share by email]

[image:
Share on Twitter]

[image:
Share on Facebook]

Sacha Greif - Paris, France

This email was sent to<EMAIL_ADDRESS>*why did I get this?*

    unsubscribe from this list

    update subscription preferences

Sacha Greif · --- · Paris - · France

Ppp0
---------- Forwarded message ----------
From: "Trainline"<EMAIL_ADDRESS>Date: 14 Jan 2018 6:08 p.m.
Subject: Your journey to London Liverpool Street tomorrow
To<EMAIL_ADDRESS>Cc:
Important last minute information for your journey from Norwich to London
Liverpool Street
View online
http://t.news.thetrainline.com/r/?id=h393d4d79,394628,23dfe519&utm_medium=email&utm_source=trigger&utm_campaign=TL_L_Pre-Departure Trigger - PD3 - 1&utm_content=TL_L_2016_05_25_PRG_PreDeparture_Email_3_OptOut_LEG|3753512&p1=E7Cp7opzeu3yy1KzkK7d6yV7dJZbj9xL
http://t.news.thetrainline.com/r/?id=h393d4d79,394628,23dfe51a&utm_medium=email&utm_source=trigger&utm_campaign=TL_L_Pre-Departure Trigger - PD3 - 1&utm_content=TL_L_2016_05_25_PRG_PreDeparture_Email_3_OptOut_LEG|3753512
Heydon's account
http://t.news.thetrainline.com/r/?id=h393d4d79,394628,23dfe539&utm_medium=email&utm_source=trigger&utm_campaign=TL_L_Pre-Departure Trigger - PD3 - 1&utm_content=TL_L_2016_05_25_PRG_PreDeparture_Email_3_OptOut_LEG|3753512
http://t.news.thetrainline.com/r/?id=h393d4d79,394628,23dfe53a&utm_medium=email&utm_source=trigger&utm_campaign=TL_L_Pre-Departure Trigger - PD3 - 1&utm_content=TL_L_2016_05_25_PRG_PreDeparture_Email_3_OptOut_LEG|3753512
Download App
http://t.news.thetrainline.com/r/?id=h393d4d79,394628,23dfe53b&action=click&publisher_id=168964&site_id_web=115239&site_id_iOS=101908&site_id_android=103816&my_campaign=TL_L_Pre-Departure Trigger - PD3 - 1&my_adgroup=TL_L_2016_05_25_PRG_PreDeparture_Email_3_OptOut_LEG|3753512
•
Best Fare Finder
http://t.news.thetrainline.com/r/?id=h393d4d79,394628,23dfe53c&utm_medium=email&utm_source=trigger&utm_campaign=TL_L_Pre-Departure Trigger - PD3 - 1&utm_content=TL_L_2016_05_25_PRG_PreDeparture_Email_3_OptOut_LEG|3753512
•
Ticket Alert
http://t.news.thetrainline.com/r/?id=h393d4d79,394628,23dfe53d&utm_medium=email&utm_source=trigger&utm_campaign=TL_L_Pre-Departure Trigger - PD3 - 1&utm_content=TL_L_2016_05_25_PRG_PreDeparture_Email_3_OptOut_LEG|3753512
[image: Are you ready?]
http://t.news.thetrainline.com/r/?id=h393d4d79,394628,23dfe53e&utm_medium=email&utm_source=trigger&utm_campaign=TL_L_Pre-Departure Trigger - PD3 - 1&utm_content=TL_L_2016_05_25_PRG_PreDeparture_Email_3_OptOut_LEG|3753512
Heydon, charge your mobile phone!
Remember to activate your mobile ticket before your trip on the day of
travel - this will be waiting for you in your Trainline app.
Mobile ticket FAQ
http://t.news.thetrainline.com/r/?id=h393d4d79,394628,23dfe542&utm_medium=email&utm_source=trigger&utm_campaign=TL_L_Pre-Departure Trigger - PD3 - 1&utm_content=TL_L_2016_05_25_PRG_PreDeparture_Email_3_OptOut_LEG|3753512
Out Monday 15 January
15:00
16:57
Norwich
(Greater Anglia)
London Liverpool Street
Return Tuesday 16 January
10:00
11:50
London Liverpool Street
(Greater Anglia)
Norwich
If you recently made changes to your booking, visit My Account
http://t.news.thetrainline.com/r/?id=h393d4d79,394628,23dfe543&utm_medium=email&utm_source=trigger&utm_campaign=TL_L_Pre-Departure Trigger - PD3 - 1&utm_content=TL_L_2016_05_25_PRG_PreDeparture_Email_3_OptOut_LEG|3753512
for your up-to-date journey details.

Download the app now
http://t.news.thetrainline.com/r/?id=h393d4d79,394628,23dfe546&action=click&publisher_id=168964&site_id_web=115239&site_id_iOS=101908&site_id_android=103816&my_campaign=TL_L_Pre-Departure Trigger - PD3 - 1&my_adgroup=TL_L_2016_05_25_PRG_PreDeparture_Email_3_OptOut_LEG|3753512
http://t.news.thetrainline.com/r/?id=h393d4d79,394628,23dfe547&action=click&publisher_id=168964&site_id_web=115239&site_id_iOS=101908&site_id_android=103816&my_campaign=TL_L_Pre-Departure Trigger - PD3 - 1&my_adgroup=TL_L_2016_05_25_PRG_PreDeparture_Email_3_OptOut_LEG|3753512
Don't forget your... umbrella
We think you'll need it when you get to London on Monday.
Max: 10°CMin: 6°C Rain
Station Details
Our handy station guides help you find facilities and plan a quick exit.
*Norwich *
http://t.news.thetrainline.com/r/?id=h393d4d79,394628,23dfe548&p1=www.thetrainline.com/stations/norwich
London Liverpool Street
http://t.news.thetrainline.com/r/?id=h393d4d79,394628,23dfe549&p1=www.thetrainline.com/stations/london-liverpool-street
Rate our email:
[image: 1 star rating]
http://t.news.thetrainline.com/r/?id=h393d4d79,394628,23dfe54a&utm_medium=email&utm_source=trigger&utm_campaign=TL_L_Pre-Departure Trigger - PD3 - 1&utm_content=TL_L_2016_05_25_PRG_PreDeparture_Email_3_OptOut_LEG|3753512&p1=%40eWA9QUqp9EyQtuPwMOtxyg%3D%3D
[image:
2 star rating]
http://t.news.thetrainline.com/r/?id=h393d4d79,394628,23dfe54b&utm_medium=email&utm_source=trigger&utm_campaign=TL_L_Pre-Departure Trigger - PD3 - 1&utm_content=TL_L_2016_05_25_PRG_PreDeparture_Email_3_OptOut_LEG|3753512&p1=%40eWA9QUqp9EyQtuPwMOtxyg%3D%3D
[image:
3 star rating]
http://t.news.thetrainline.com/r/?id=h393d4d79,394628,23dfe54c&utm_medium=email&utm_source=trigger&utm_campaign=TL_L_Pre-Departure Trigger - PD3 - 1&utm_content=TL_L_2016_05_25_PRG_PreDeparture_Email_3_OptOut_LEG|3753512&p1=%40eWA9QUqp9EyQtuPwMOtxyg%3D%3D
[image:
4 star rating]
http://t.news.thetrainline.com/r/?id=h393d4d79,394628,23dfe54d&utm_medium=email&utm_source=trigger&utm_campaign=TL_L_Pre-Departure Trigger - PD3 - 1&utm_content=TL_L_2016_05_25_PRG_PreDeparture_Email_3_OptOut_LEG|3753512&p1=%40eWA9QUqp9EyQtuPwMOtxyg%3D%3D
[image:
5 star rating]
http://t.news.thetrainline.com/r/?id=h393d4d79,394628,23dfe54e&utm_medium=email&utm_source=trigger&utm_campaign=TL_L_Pre-Departure Trigger - PD3 - 1&utm_content=TL_L_2016_05_25_PRG_PreDeparture_Email_3_OptOut_LEG|3753512&p1=%40eWA9QUqp9EyQtuPwMOtxyg%3D%3D
*Follow us: *
http://t.news.thetrainline.com/r/?id=h393d4d79,394628,23dfe54f
http://t.news.thetrainline.com/r/?id=h393d4d79,394628,23dfe550
Please do not reply to this email as we will not be able to respond.
Registered address and tax
Trainline.com Limited is a company registered in England (with company
registration number 3846791).
Our registered office is at: 120 Holborn, London EC1N 2TD. Trainline.com
Limited is registered with VAT number 791 7261 06, however, train tickets
are currently zero rated for VAT and so VAT receipts are not routinely
offered. You can contact our customer services department by using the
contact details supplied on the contact us page
http://t.news.thetrainline.com/r/?id=h393d4d79,394628,23dfe551&utm_medium=email&utm_source=trigger&utm_campaign=TL_L_Pre-Departure Trigger - PD3 - 1&utm_content=TL_L_2016_05_25_PRG_PreDeparture_Email_3_OptOut_LEG|3753512.
thetrainline is a trading name of Trainline.com Limited.


Fixed using lapply/sapply

@beckettsean @jcheng5
Thanks for your comments. I've changed the influxdb_query function following your suggestions.
Now it should return a list of named dataframes (one for every table in the query).
The response_data object which is obtained after
response_data <- rjson::fromJSON(rawToChar(response$content))

is a tangled list (especially for queries on multiple tables).
Simon

please have a look at my https://github.com/dleutnant/influxdbr/tree/0.9.6 repository. I am currently updating some functions to handle default influxdb statements.

Man... Great work! You saved me a lot of time! Thanks!
Just a couple of questions:

why don't you "merge" your repo with this one?
i've seen that your package returns a xts object "splitted" by columns (or better: a list of xts objects one for every column). Shouldn't be better to have one time series with multiple columns?

Thanks for your comment @svazzole! It returns a list of xts objects to handle different column types. This is due to the fact that xts objects are based on a matrix and store one data type only. E.g. if your measurement field_value_1 of field_key_1 is a numeric and field_value_2 of field_key_2 is a character, the xts object would consists of a character matrix. If you would like to cirumvent this, you can still use the function parameter return_xts = FALSE. However, if this is slows the overall usage, I'll have a look and may consider structural changes
Finally, I am happy to merge to influxdb-r repro! Maybe my code needs some revisions beforehand? @beckettsean Any suggestions?

@dleutnant as of right now yours is the only R library we mention on the client library page. There's no mention of influxdata/influxdb-r.
My preference would be to make you the maintainer of influxdata/influxdb-r and then you can decide the best way forward for the repo, whether that's a merge or just updating the README to point to your project.
@toddboom @jcheng5 does that work for you?


Use a custom StockInfo class for variants

As noted in #481, it might be better to have a custom StockInfo class for variants that includes the min and max price of an item.
Some research required...

It indeed will allow to indicate variant prices appropriately. WDYT @django-oscar/core ?

closing all issues that are feature requests that don't have PR's attached.


Remove the node indexing requirement from docs

After implementing https://github.com/celestiaorg/celestia-core/issues/1019, we will be able to remove from documentation the need to have indexing enabled to run the QGB.

This should be done after bumping version of core


DexRewards: Can't claim ultra kit

Just achieved ultra on dexrewards and can't claim my ultra kit via /kits
-Acherous

Wanted to update that I am now the "nova" rank and can no longer claim aria kit but can claim nova.  Not sure if acting as intended or not

Heya!

Wanted to update that I am now the "nova" rank and can no longer claim aria kit but can claim nova. Not sure if acting as intended or not
This is intended, it's for balancing reasons.

Just achieved ultra on dexrewards and can't claim my ultra kit via /kits
-Acherous
This should now be fixed if you log on :) If not, please let us know via Discord.


Jdk checks

JDK is a string.

Coverage decreased (-0.05%) to 96.612% when pulling a91cb81468b7bf57ab911224a64a5603d60f6e8b on JDKchecks into f54415156d949505c286b40b156533890ecb582a on master.


peertube: fix with openssl 3

Description of changes
This fixes peertube to work with openssl 3. Two things were changed to achieve this:
Webpack needs to be run with NODE_OPTIONS=--openssl-legacy-provider as described in https://github.com/webpack/webpack/issues/14532. This is the case even though PeerTube already uses a recent webpack version (updating it also did not make it work without the workaround).
An upstream patch is applied to the source. Because it did not apply to the tagged version, I had to rebase it and include the file. Also, the yarn lockfile had to be included because fetchYarnDeps doesn’t use the patched file from the main derivation.
Things done

I did not test this on an actual deployment, only with the NixOS system test.

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[X] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

My guess is that adding a yarn.lock file is not recommended as it is large size. Maybe need to find another variant.

Right, we should avoid adding large files where it is possible. Do you have any idea what other solution could be used? One approach could be to patch the source and copy only the lockfile to $out in a runCommand derivation, though I don’t know if that is preferred

Try to see the implementation in mastodon - https://github.com/NixOS/nixpkgs/blob/master/pkgs/servers/mastodon/source.nix

Also, quite a number of other packages seem to include a yarn lock file and this one will be removed with the next version upgrade anyway, so it might not be that problematic.

These changes will affect the size of the history in the git repository.

@GrahamcOfBorg test peertube

Just saw that v4.3.0 was released. It also includes an update of babel-loader, which might remove the need for --openssl-legacy-provider. However, it is still affected by https://github.com/Chocobozzz/PeerTube/issues/5263.

Note that after #193047 you can simply inherit src patches; in fetchYarnDeps

superseded by #194196


Revert "remove migration methods from all classes and blacklist depending libshogun examples"

SerializationASCII heavily depends on migration-framework, so we cannot drop that easy, unfortunately.
This reverts commit 5af68edff0f7ea7100c142d280307a0e7acaf350.

I don't think that ASCII serialisation heavily depends on migration framework.
I think there is another reason why things broke. Will have a look and then send the patch again.

Before you merge this, give me a moment to take a look at the cause

(in the plane back tomorrow)

Should be fixed in #2955

Going to merge #2955 after Travis is ready…


nodejs-runtime: undici fetch error -- unable to use sst dev on requests > 100kb

Error I'm getting when running sst dev on a POST multipart form lambda using APIGatewayV2
fetch failed
|  ↳ at node:internal/deps/undici/undici:12502:13
|  ↳ at async error (file:///Users/user/Desktop/projects/project/.sst/platform/dist/nodejs-
runtime/index.js:11:3)
|  ↳ at async file:///Users/user/Desktop/projects/project/.sst/platform/dist/nodejs-
runtime/index.js:91:5

After investigating a bit further the issue comes from the .json() returning an Unexpected token... invalid JSON etc etc.
 const result = await fetch(AWS_LAMBDA_RUNTIME_API + `/runtime/invocation/next`);
    context = {
      awsRequestId: result.headers.get("lambda-runtime-aws-request-id") || "",
      invokedFunctionArn: result.headers.get("lambda-runtime-invoked-function-arn") || "",
      getRemainingTimeInMillis: () => Math.max(Number(result.headers.get("lambda-runtime-deadline-ms")) - Date.now(), 0),
      identity: (() => {
        const header = result.headers.get("lambda-runtime-cognito-identity");
        return header ? JSON.parse(header) : undefined;
      })(),
      clientContext: (() => {
        const header = result.headers.get("lambda-runtime-client-context");
        return header ? JSON.parse(header) : undefined;
      })(),
      functionName: process.env.AWS_LAMBDA_FUNCTION_NAME,
      functionVersion: process.env.AWS_LAMBDA_FUNCTION_VERSION,
      memoryLimitInMB: process.env.AWS_LAMBDA_FUNCTION_MEMORY_SIZE,
      logGroupName: result.headers.get("lambda-runtime-log-group-name") || "",
      logStreamName: result.headers.get("lambda-runtime-log-stream-name") || "",
      callbackWaitsForEmptyEventLoop: {
        set value(_value) {
          throw new Error("`callbackWaitsForEmptyEventLoop` on lambda Context is not implemented by SST Live Lambda Development.");
        },
        get value() {
          return true;
        }
      }.value,
      done() {
        throw new Error("`done` on lambda Context is not implemented by SST Live Lambda Development.");
      },
      fail() {
        throw new Error("`fail` on lambda Context is not implemented by SST Live Lambda Development.");
      },
      succeed() {
        throw new Error("`succeed` on lambda Context is not implemented by SST Live Lambda Development.");
      }
    };
    request = await result.json();

It looks like the result's body from AWS_LAMBDA_RUNTIME_API is fetching an incomplete response/response that's cut off (~100kb mark)
Example response:
{"version":"2.0","routeKey":"POST /parse-resume","rawPath":"/parse-resume","rawQueryString":"","headers":{"accept":"*/*","content-length":"114640","content-type":"multipart/form-data; boundary=X-INSOMNIA-BOUNDARY","host":"nkdhuh1bkb.execute-api.us-east-1.amazonaws.com","user-agent":"insomnia/9.2.0","x-amzn-trace-id":"Root=1-668e5970-7e4fc31d36dce94d177140fc","x-forwarded-for":"<IP_ADDRESS>","x-forwarded-port":"443","x-forwarded-proto":"https"},"requestContext":{"accountId":"992382568513","apiId":"nkdhuh1bkb","domainName":"nkdhuh1bkb.execute-api.us-east-1.amazonaws.com","domainPrefix":"nkdhuh1bkb","http":{"method":"POST","path":"/parse-resume","protocol":"HTTP/1.1","sourceIp":"<IP_ADDRESS>","userAgent":"insomnia/9.2.0"},"requestId":"asLpriyGIAMEYDg=","routeKey":"POST /parse-resume","stage":"$default","time":"10/Jul/2024:09:50:40 +0000","timeEpoch":1720605040834},"body":"LS1YLUlOU09NTklBLUJPVU5EQVJZDQpDb250ZW50LURpc3Bvc2l0aW9uOiBmb3JtLWRhdGE7IG5hbWU9ImZpbGUiOyBmaWxlbmFtZT0iTWFyaWEgUmVzdW1lLnBkZiINCkNvbnRlbnQtVHlwZTogYXBwbGljYXRpb24vcGRmDQoNCiVQREYtMS4zCiXE5fLl66fzoNDExgo0IDAgb2JqCjw8IC9MZW5ndGggNSAwIFIgL0ZpbHRlciAvRmxhdGVEZWNvZGUgPj4Kc3RyZWFtCngBtL1LzyQ5kp67/37FtxYw1eHucQUas5geYaDFABKmAa2P6kxrIHQdYNT/HzjPaySN5k4yMryaWQ10Rr7pNOOddqPxP7//x/d/fl++H6/1+7fv+7Lar7/ar8svF/13f3z/lS/i3/7j+3/+l+//T6AX+b///vU/gf7wp78t37/+7Xux//3t199B+i/f/+NrUpW+/+fXrCp9/+fXlF76ppe+rt//+v2Hf6Gn/vffUo/96d+sMy/f//YnhuMfLr88bgnQj9v1+suyXr8f2/LLwt9//U3/9stNA7Zuv9yvj+VLf/3r978xmnk8t/WXjQ9WylwvN8rq73/1v18ptz6uVxva8Jf/+OqMrOrsI3v55XW9LfCPf6SB3vP8+pjnN0P+41n49dEsPNR1uzKlL7/EP/7269fyeNCjz43+u//yeD3u9NTyuP7yfETsrxF7/HK78p0wL5sw6qWyLb2lQ8+xQM/LBnqM9LF+92dLr2KBnpet9PiupXfr0HOs0qtlA71bh97aoedYoOdlA721pXd7tfQqFuh52UqP75r23u4deo5VerVsoHfv0Ns69BwL9LxsoLd16F069BwL9LxsoHdp6V0fLb2KBXpettLju6b/2IWa9VGxSq+WDfR8jtf1dvW1kDHWUcUCPS8b6Pkcr/S2zvqoWKDnZSs9vmvau/laqPWrWKVXywZ6PsdD/XwtBHqOBXpeNtDzOV7prZ31U[does not complete]

My guess is there's some kind of data body size limit at ~100kb when running sst dev

I have the same issue

Not sure if it is the same thing, but I was getting a similar error which cleared after restarting sst dev:
|  fetch failed
|  ↳ at node:internal/deps/undici/undici:12502:13
|  ↳ at async file:///home/chrisandrew/workspace/project/.sst/platform/dist/nodejs-runtime/index.js:51:2

I have the same issue.
Can't invoke anymore.


Parallelize asset checkout

We should add the ability for Test Proxy asset checkout to check out assets in parallel. Possibly make this configurable between synchronous and parallel based on the number of unique assets that need to be fetched.

Java core, for example, does 91 restore operations. Clone times take around 1-2 seconds, and fetch + checkout times take the same (with some exceptions like fileshare/blob which take 5-13 seconds for checkout since the recordings are larger).
We could reduce the time here dramatically if we cached the initial clone and added some concurrency:

clone once in some parent cache location and copy the .git directory from the cache to the asset location (e.g. add a --clone-cache flag to restore in CI or something)
fetch refs for each asset in parallel (with batch size)
checkout recordings for each asset in parallel (with batch size)

Ah, java is a bit unique in that they frontload the test proxy restore. So this issue is java specific. https://github.com/Azure/azure-sdk-for-java/blob/main/eng/pipelines/templates/steps/restore-test-proxy-recordings.yml

We do. That's why you're facing problems.

Java core, for example, does 91 restore operations. Clone times take around 1-2 seconds, and fetch + checkout times take the same (with some exceptions like fileshare/blob which take 5-13 seconds for checkout since the recordings are larger).
We could reduce the time here dramatically if we cached the initial clone and added some concurrency:

clone once in some parent cache location and copy the .git directory from the cache to the asset location (e.g. add a --clone-cache flag to restore in CI or something)
fetch refs for each asset in parallel (with batch size)
checkout recordings for each asset in parallel (with batch size)

This is something that we can definitely do. I see where you're coming from with this change.

@scbedd I think if we move the restore operation into the test framework, like the other languages do (or maybe java already does this), then it's all done in parallel and we should gain a few minutes? But only if test proxy does its own sort of caching of the refs.

@scbedd I think if we move the restore operation into the test framework, like the other languages do (or maybe java already does this), then it's all done in parallel and we should gain a few minutes? But only if test proxy does its own sort of caching of the refs.

I've actually come full circle. The proxy supports parallel asset checkout. In Azure/azure-sdk-for-java#36792 we removed the script that runs prior to test start.
All java tests run in parallel.
For each of those startPlayback commands, there is a server thread handling the incoming request.
If two requests are for different assets.json files, they will be restored in parallel. We only force the git process interacting with the recordings to an individual handler per asset directory to prevent conflicts/weirdness.

I think we can close this now, the issue was specifically about the script that has now been removed (see above comment).


Implement missing text props in the SDF Text Renderer

In the SDF Text Renderer the following props should be implemented:

lineHeight
verticalAlign
textBaseline (moved to #134)
maxLines
overflowSuffix

I have an implementation for everything except textBaseline. I've split that out to a separate issue #134. Please let me know @pecoram the importance of that property in the issue so we can prioritize it accordingly.

Low priority


RuntimeError: CUDA out of memory.

Hello,
When i run
python main.py --function test --config configs/cub_stage2.yml --opt "{'test': {'load_token_path': 'ckpts/cub983/tokens/', 'load_unet_path': 'ckpts/cub983/unet/', 'save_log_path': 'ckpts/cub983/log.txt'}}”
I am encountering this error
Traceback (most recent call last):   File "/p/project/atmlaml/benassou1/ega/GenPromp/main.py", line 646, in <module>     eval(args.function)(config)   File "/p/project/atmlaml/benassou1/ega/GenPromp/main.py", line 300, in test     noise_pred = unet(noisy_latents, timesteps, combine_embeddings).sample   File "/p/software/juwelsbooster/stages/2023/software/PyTorch/1.12.0-foss-2022a-CUDA-11.7/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1130, in _call_impl     return forward_call(*input, **kwargs)   File "/p/project/atmlaml/benassou1/ega/GenPromp/sc_venv_template/venv/lib/python3.10/site-packages/diffusers/models/unet_2d_condition.py", line 615, in forward     sample = upsample_block(   File "/p/software/juwelsbooster/stages/2023/software/PyTorch/1.12.0-foss-2022a-CUDA-11.7/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1130, in _call_impl     return forward_call(*input, **kwargs)   File "/p/project/atmlaml/benassou1/ega/GenPromp/sc_venv_template/venv/lib/python3.10/site-packages/diffusers/models/unet_2d_blocks.py", line 1813, in forward     hidden_states = attn(   File "/p/software/juwelsbooster/stages/2023/software/PyTorch/1.12.0-foss-2022a-CUDA-11.7/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1130, in _call_impl     return forward_call(*input, **kwargs)   File "/p/project/atmlaml/benassou1/ega/GenPromp/sc_venv_template/venv/lib/python3.10/site-packages/diffusers/models/transformer_2d.py", line 265, in forward     hidden_states = block(   File "/p/software/juwelsbooster/stages/2023/software/PyTorch/1.12.0-foss-2022a-CUDA-11.7/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1130, in _call_impl     return forward_call(*input, **kwargs)   File "/p/project/atmlaml/benassou1/ega/GenPromp/sc_venv_template/venv/lib/python3.10/site-packages/diffusers/models/attention.py", line 321, in forward     ff_output = self.ff(norm_hidden_states)   File "/p/software/juwelsbooster/stages/2023/software/PyTorch/1.12.0-foss-2022a-CUDA-11.7/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1130, in _call_impl     return forward_call(*input, **kwargs)   File "/p/project/atmlaml/benassou1/ega/GenPromp/sc_venv_template/venv/lib/python3.10/site-packages/diffusers/models/attention.py", line 379, in forward     hidden_states = module(hidden_states)   File "/p/software/juwelsbooster/stages/2023/software/PyTorch/1.12.0-foss-2022a-CUDA-11.7/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1130, in _call_impl     return forward_call(*input, **kwargs)   File "/p/software/juwelsbooster/stages/2023/software/PyTorch/1.12.0-foss-2022a-CUDA-11.7/lib/python3.10/site-packages/torch/nn/modules/linear.py", line 114, in forward     return F.linear(input, self.weight, self.bias) RuntimeError: CUDA out of memory. Tried to allocate 2.00 MiB (GPU 0; 39.56 GiB total capacity; 7.06 GiB already allocated; 1.94 MiB free; 17.07 GiB reserved in total by PyTorch) If reserved memory is >> allocated memory try setting max_split_size_mb to avoid fragmentation.  See documentation for Memory Management and PYTORCH_CUDA_ALLOC_CONF
I changed the batch size to 1, reduced the size of the image,  max_split_size_mb, and still does not work. Could you please help me to fix this problem ?

The code can run on RTX 3090 with memory of 24GB, it seems that your machine is running out of memory (only 7.06 GB already allocated). You can free up more memory and try again.

The code can run on RTX 3090 with memory of 24GB, it seems that your machine is running out of memory (only 7.06 GB already allocated). You can free up more memory and try again.


TAP report parsing error: expected '', but found ''

Describe the bug
TAP report parsing error: expected '', but found ''
https://ci.adoptopenjdk.net/job/Test_openjdk11_j9_sanity.openjdk_x86-64_linux_xl/363/console
20:05:32  TAP Reports Processing: START
20:05:32  Looking for TAP results report in workspace using pattern: **/*.tap
20:05:39  Saving reports...
20:05:39  Processing '/home/jenkins/.jenkins/jobs/Test_openjdk11_j9_sanity.openjdk_x86-64_linux_xl/builds/363/tap-master-files/openjdk-tests/TKG/test_output_16019215963274/TestTargetResult.tap'
20:05:39  Parsing TAP test result [/home/jenkins/.jenkins/jobs/Test_openjdk11_j9_sanity.openjdk_x86-64_linux_xl/builds/363/tap-master-files/openjdk-tests/TKG/test_output_16019215963274/TestTargetResult.tap].
20:05:39  org.tap4j.parser.ParserException: Error parsing TAP Stream: Error parsing YAML [ok 2 - jdk_lang_native_j9_win_0 # skip
20:05:39    ---
20:05:39  ok 3 - jdk_math_j9_0
20:05:39    ---
20:05:39  ok 4 - jdk_util_j9_0
20:05:39    ---
20:05:39  ok 5 - jdk11_tier1_cipher_0
20:05:39    ---
20:05:39  ok 6 - jdk11_tier1_buffer_0
20:05:39    ---
20:05:39  ok 7 - jdk11_tier1_iso8859_0
20:05:39    ---
20:05:39  ok 8 - jdk11_tier1_pack200_0
20:05:39    ---
20:05:39  ]: expected '<document start>', but found '<scalar>'
20:05:39   in 'string', line 2, column 3:
20:05:39        ---
20:05:39        ^
20:05:39
20:05:39  	at org.tap4j.parser.Tap13Parser.parseTapStream(Tap13Parser.java:257)
20:05:39  	at org.tap4j.parser.Tap13Parser.parseFile(Tap13Parser.java:231)
20:05:39  	at org.tap4j.plugin.TapParser.parse(TapParser.java:173)
20:05:39  	at org.tap4j.plugin.TapPublisher.loadResults(TapPublisher.java:572)
20:05:39  	at org.tap4j.plugin.TapPublisher.performImpl(TapPublisher.java:444)
20:05:39  	at org.tap4j.plugin.TapPublisher.perform(TapPublisher.java:403)
20:05:39  	at jenkins.tasks.SimpleBuildStep.perform(SimpleBuildStep.java:112)
20:05:39  	at sun.reflect.GeneratedMethodAccessor19828.invoke(Unknown Source)
20:05:39  	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
20:05:39  	at java.lang.reflect.Method.invoke(Method.java:498)
20:05:39  	at org.jenkinsci.plugins.workflow.steps.CoreStep$Execution.run(CoreStep.java:92)
20:05:39  	at org.jenkinsci.plugins.workflow.steps.CoreStep$Execution.run(CoreStep.java:70)
20:05:39  	at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)
20:05:39  	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
20:05:39  	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
20:05:39  	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
20:05:39  	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
20:05:39  	at java.lang.Thread.run(Thread.java:748)
20:05:39  Caused by: org.tap4j.parser.ParserException: Error parsing YAML [ok 2 - jdk_lang_native_j9_win_0 # skip
20:05:39    ---
20:05:39  ok 3 - jdk_math_j9_0
20:05:39    ---
20:05:39  ok 4 - jdk_util_j9_0
20:05:39    ---
20:05:39  ok 5 - jdk11_tier1_cipher_0
20:05:39    ---
20:05:39  ok 6 - jdk11_tier1_buffer_0
20:05:39    ---
20:05:39  ok 7 - jdk11_tier1_iso8859_0
20:05:39    ---
20:05:39  ok 8 - jdk11_tier1_pack200_0
20:05:39    ---
20:05:39  ]: expected '<document start>', but found '<scalar>'
20:05:39   in 'string', line 2, column 3:
20:05:39        ---
20:05:39        ^
20:05:39
20:05:39  	at org.tap4j.parser.Tap13Parser.parseDiagnostics(Tap13Parser.java:469)
20:05:39  	at org.tap4j.parser.Tap13Parser.onFinish(Tap13Parser.java:431)
20:05:39  	at org.tap4j.parser.Tap13Parser.parseTapStream(Tap13Parser.java:255)
20:05:39  	... 17 more
20:05:39  Caused by: expected '<document start>', but found '<scalar>'
20:05:39   in 'string', line 2, column 3:
20:05:39        ---
20:05:39        ^
20:05:39
20:05:39  	at org.yaml.snakeyaml.parser.ParserImpl$ParseDocumentStart.produce(ParserImpl.java:225)
20:05:39  	at org.yaml.snakeyaml.parser.ParserImpl.peekEvent(ParserImpl.java:158)
20:05:39  	at org.yaml.snakeyaml.parser.ParserImpl.checkEvent(ParserImpl.java:148)
20:05:39  	at org.yaml.snakeyaml.composer.Composer.getSingleNode(Composer.java:122)
20:05:39  	at org.yaml.snakeyaml.constructor.BaseConstructor.getSingleData(BaseConstructor.java:150)
20:05:39  	at org.yaml.snakeyaml.Yaml.loadFromReader(Yaml.java:490)
20:05:39  	at org.yaml.snakeyaml.Yaml.load(Yaml.java:416)
20:05:39  	at org.tap4j.parser.Tap13Parser.parseDiagnostics(Tap13Parser.java:459)
20:05:39  	... 19 more
20:05:39  TAP parse errors found in the build. Marking build as UNSTABLE
20:05:39  TAP Reports Processing: FINISH
[Pipeline] junit
20:05:39  Recording test results

To Reproduce
Steps to reproduce the behavior (or Grinder rerun link):
https://ci.adoptopenjdk.net/job/Grinder/parambuild/?TARGET=sanity.openjdk&CUSTOM_TARGET=&SDK_RESOURCE=upstream&VENDOR_TEST_SHAS=&JDK_BRANCH=openj9&TEST_FLAG=&VENDOR_TEST_DIRS=&ARTIFACTORY_REPO=&ARTIFACTORY_ROOT_DIR=&PLATFORM=x86-64_linux_xl&KEEP_REPORTDIR=true&PERSONAL_BUILD=false&ADOPTOPENJDK_REPO=https%3A%2F%2Fgithub.com%2FAdoptOpenJDK%2Fopenjdk-tests.git&JDK_IMPL=openj9&LABEL=&TKG_BRANCH=master&EXTRA_OPTIONS=&SSH_AGENT_CREDENTIAL=&IS_PARALLEL=false&CUSTOMIZED_SDK_URL=&BUILD_IDENTIFIER=&AUTO_DETECT=true&ADOPTOPENJDK_BRANCH=master&TKG_SHA=&ARTIFACTORY_SERVER=&CUSTOMIZED_SDK_URL_CREDENTIAL_ID=&OPENJDK_SHA=&KEEP_WORKSPACE=false&JDK_VERSION=11&BUILD_LIST=openjdk&USER_CREDENTIALS_ID=&UPSTREAM_JOB_NUMBER=706&ITERATIONS=1&VENDOR_TEST_REPOS=&JDK_REPO=https%3A%2F%2Fgithub.com%2Fibmruntimes%2Fopenj9-openjdk-jdk11&TIME_LIMIT=10&RELEASE_TAG=openj9-0.23.0&OPENJ9_BRANCH=master&OPENJ9_SHA=&JCK_GIT_REPO=&VENDOR_TEST_BRANCHES=&UPSTREAM_JOB_NAME=build-scripts%2Fjobs%2Fjdk11u%2Fjdk11u-linux-x64-openj9-linuxXL&OPENJ9_REPO=https%3A%2F%2Fgithub.com%2Feclipse%2Fopenj9.git&JVM_OPTIONS=&TKG_REPO=https%3A%2F%2Fgithub.com%2FAdoptOpenJDK%2FTKG.git
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

Looks like an error parsing output of a newly added test target (jdk_lang_native_j9_win_0)?
FYI @sophia-guo @renfeiw

Looks like it's a machine issue realted to a missing perl module: 20:13:17  Can't locate Time/HiRes.pm in @INC (@INC contains: /usr/local/lib64/perl5 /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5 .). We need this module to print out timestamp for tap output. It supposed to come with perl, I will update the prerequisites.

Is test-ibmcloud-rhel6-x64-1 newly added? Are those newly added ibmcloud machine configured by Ansible?

@sxa @Haroon-Khel - Can you answer @sophia-guo's question above?  I think this issue needs to move to openjdk-infrastructure repo

@renfeiw -  I see that you have added perl is added to env checks in TKG and that this machine meets the prereqs criteria of perl 5.10.1 or above**, but interestingly does not contain HiRes.pm which seems to be included in other core Perl installations, perhaps we need to explicitly check (though that is certainly unexpected config).
14:11:41  perlVersion :
14:11:41
14:11:41  	This is perl, v5.10.1 (*) built for x86_64-linux-thread-multi
14:11:41

Yes, we will explicitly add this module check in the machineInfo.

@sophia-guo Yes that machine is newly added. I did run our ansible playbooks on the machine, as well as run a build and sanity test on it to make sure it was good to go.
@ShelleyLambert However I did need to explicitly install perl-Digest-SHA on the machine, and on test-ibmcloud-rhel7-x64-1, as per https://github.com/AdoptOpenJDK/openjdk-infrastructure/pull/1564. This solved an error I was getting while running a sanity test on the machine. Ive never had to install this package separately before. On RHEL, perl is installed via yum, so I guess perl-Digest-SHA isnt included in the core perl installation either

@smlambert @sophia-guo @renfeiw Just to be clear - is this definitely a newly added test (when did it come in?) which has a new prereq of the Time::HiRes module and that hasn't been required previously? Sounds superficially like the sort of thing that might be used more pervasively so just wanted to verify that, and if it's on some of the other machines how it got there :-)

@Haroon-Khel Can you check for this module on other machines as it would be good to confirm if this is machine specific? Unless Perl-SHA-Digest has a prereq of Time::HiRes the installation of it is unlikely to resolve this issue

Machines that have Time::HiRes
test-softlayer-rhel74-x64-1
test-aws-rhel8-x64-1
build-marist-rhel77-s390x-1
build-softlayer-centos6-x64-1
test-godaddy-centos7-x64-1
Machines that do not have Time::HiRes
test-softlayer-rhel69-x64-1

I'll install Time::HiRes onto test-ibmcloud-rhel6-x64-1 and we can re run the test. If it passes, Ill add the package to the playbooks

Interesting that it got onto the RHEL7 boxes. Perhaps it's there by default on the version of perl supplied with RHEL7. test-softlayer-rhel69-x64-1 doesn't have the test tags on it so we would probably never have seen it on there previously.

Rerunning the job, using a nightly jdk, in a grinder
https://ci.adoptopenjdk.net/job/Grinder/4117/console
On a separate note, @ShelleyLambert I initially tried rerunning the job in a grinder by clicking Rerun in grinder and it failed here with the error
hudson.AbortException: Failed to copy artifacts from build-scripts/jobs/jdk11u/jdk11u-linux-x64-openj9-linuxXL with filter: **/*.tar.gz,**/*.tgz,**/*.zip,**/*.jar,**/*.Z

Does the Rerun in grinder functionality copy and rerun the build entirely? Or do some of the parameters not get copied over and need to be manually inputted?

just as a note, @smlambert is the github id that I use (@ShelleyLambert is one autocreated for me by IBM that I will not see notifications for)
All tests use Time::HiRes, since we parse all test output and create TAP output for all tests.  We have been doing this for some time without incident (which is why I assumed its part of core Perl installation).  These tests are also not new, they are just reorganized into new test targets.
To answer @Haroon-Khel question in https://github.com/AdoptOpenJDK/openjdk-tests/issues/1998#issuecomment-705519313 "Rerun in Grinder" link copies the exact parameters used in the run you are copying it from.  Someone running a Grinder should be aware that the upstream builds are deleted at a fast past, so you would switch the SDK_RESOURCE from upstream to nightly to pick up the latest nightly build, since that upstream job will have already been deleted (unless you happen to be rerunning with a day or two of the failure).

Grinder, https://ci.adoptopenjdk.net/job/Grinder/4117/console, does not show the previous parsing error nor the missing Time::HiRes error. Ill go ahead and add the package to the rhel playbook

Since the associated PR has been merged and the machine now works I will close this issue.


Unhandled exception downloading from Bluemix liberty app

When downloading an app and ignoring the advice to omit /app/.java and /app/.liberty I was getting unhandled exceptions that "". This broke the download and meant restarting.
After omiting those folders I got a similar (but different) error for a different file which also caused the whole operation to fail leading to a redownload.
Pretty sure the problems with the files is within Bluemix but these errors should still have been caught and handled rather than causing the whole operation to fail

Hello nanowireUK,
I am trying to track down where this issue may have occurred but have a few questions for you.

Have you tried the plugin lately and are you still experiencing the same behavior?
How did you deploy your application? Was it the sample app you get from the "Liberty for Java" runtime on Bluemix?
Is anything printed other than an empty string?

Sincerely,
Luke Stack

Hi Luke,
I used the latest version of the plugin, downloaded on the day of making the report.
Apologies for the empty string, there was a proper error but it doesn't seem to have pasted in correctly. The issue I'm trying to raise is not that there was a problem downloading a particular file but that the whole process aborted in response to an unhandled error on a single file (I saw this with at least two different errors).
The tool should have a 'ignore file errors' option so that any isolated issues doesn't impact the full job.
Using Windows 7 64bit.
Best regards,
Phil

Phil,
Could you try to replicate your experience and provide the proper error that was given? That way I can have some context as to where and why the error was raised and try to handle it in a more graceful manner.
Thanks,
Luke

Hi Luke,
Just tried it again and got the following error when downloading .liberty (which I know isn't recommended to download):
fatal error: runtime: cannot map pages in arena address space
stack.txt
Like I say, the actual error message for the file isn't particularly relevant (I got two different uncaught errors). What I'm suggesting is that there needs to be a flag to 'ignore file errors' and put a catch all in that simply moves on to the next file. My repository contains over 3,000 files and I had to restart 5 times at different stages, each time adding a new omit path before I could finally get all the non-error files.
Thanks,
Phil

Phil,
I understand what you are asking for, but I still need addition information to know where these errors are coming from and how they can be omitted. Would you be willing to run the download command with the "--verbose" option so that I can have more information to help debug this issue? If you could run
cf download YOUR_APP_HERE --verbose > log.txt
and send me log.txt, It would be greatly appreciated.
Thanks,
Luke

Hi Luke,
Of course. I've been trying to replicate the same error but so far no success (I suspect it might be something like a transient filesystem lock). In trying to replicate I have however three different file level errors that all caused the whole process to abort. In two of the cases I would have wanted the job to continue on best effort.
First time around it lost network connection (so failing job is appropriate).
log.txt
Second time, no idea what happened - says a bug in cf: invalid memory address or nil pointer dereference
log4.txt
Next time I omitted /app/.java and got the following error instead (file name too long):
log6.txt
Thanks,
Phil

Didn't mean to close

Phil,
I looked at your logs and have made several modifications to the plugin since. First, I would ask that you install the latest version of the CLI. In log4.txt you experience an error when cf files client-poc /app/.java/jre/lib/rt.jar -i 0 was called. I too experienced this, but the problem seemed to resolve itself when I updated the CLI. I believe that the mkdir issue experienced in log6.txt was a result of a bad path that mixed both forward and backward slashes. This should be resolved with my changes. Lastly, I tried to make the plugin more flexible altogether in it's error handling.
I'd be very appreciative if you could uninstall and re-install the plugin using the latest binaries. I tested the plugin on a Windows VM, but I'd love any additional feedback from actual Windows users.
Thanks,
Luke

Hi Luke,
Tried to do as you requested but unfortunately fell at the first hurdle. I uninstalled the old version and then got the following when I ran cf install-plugin cf-download -r CF-Community:
Looking up 'cf-download' from repository 'CF-Community'
9573888 bytes downloaded...
FAILED
Downloaded plugin binary's checksum does not match repo metadata

Result from cf list-plugin-repo is
Repo Name      Url
CF-Community   http://plugins.cloudfoundry.org/

Phil,
There is currently an open pull request to update the binary checksum to match the latest release. Until the pull request is accepted, you must install the plugin using the binary directly. The README has instructions on how to do so here.

The pull request was merged with the CF-Community repo yesterday. You should now be able to install the plugin the same way you tried before.

Tested this out today and saw no issues so closing. Have opened separate issue on CPU usage whilst downloading


useQuery handle cache

Looks like useQuery is refetching the data all the time, we need to optimize it to cache the data

Based on the react-query doc I set the refetchOnWindowFocus: false as it's true by default
Also, would be cool if we have some refetch policy when a site is minted so the user doesn't have to reload the page (it will be automatically reloaded).
Janison sent us a link about how to suscribe to events but for web3.js. Since we're using ether.js, found this for events subscription.


Adjust styling for no-script image

Need to change height and width, and style with tachyons
https://github.com/Jbarget/cv-amp/blob/master/index.html#L19

fixed with PR #10


Production works with the Gradle Plugin, but fails with the Maven Plugin

Greetings.
Very strange observation: The following Production would compile with the Gradle Plugin, but fail with the Maven Plugin:
Test myTest():
{
   Test result;
}
{
    (
      result=TestProduction1() { return result; }
    )
    |
    (
      result=TestProduction2()
    ) { return result; }
}

Error from the Maven build:
Error:  /home/runner/work/JSqlParser/JSqlParser/target/generated-sources/javacc/net/sf/jsqlparser/parser/CCJSqlParser.java:[3337,9] unreachable statement
Error:  /home/runner/work/JSqlParser/JSqlParser/target/generated-sources/javacc/net/sf/jsqlparser/parser/CCJSqlParser.java:[3345,1] missing return statement

Rewriting it solves the problem:
Test myTest():
{
   Test result;
}
{
    (
        (
          result=TestProduction1() { return result; }
        )
        |
        (
          result=TestProduction2()
        )
    ) { return result; }
}

For details, please refer to: https://github.com/JSQLParser/JSqlParser/pull/1552#issuecomment-1145917623

I'm not that familiar with Gradle, but as far as I can see, the Gradle plugin still uses version 6 of JavaCC (https://github.com/javacc/javaccPlugin/blob/59cd9f786030e08d16afb298ccb850e149d30f70/subprojects/plugin/build.gradle#L35) whereas the Maven plugin already uses version 7. That might explain the different behavior.

Please try version 8.0 as we would like to move everyone over to that version. Also the code generator is split out of the main core so you can fix it yourself rather easily now and also improve it if you are interested.

Oh interesting, I didn't even know about that version 8 project. Perhaps you could consider adding the maven/gradle plugin to the multi module project directly, like they're doing it with the antlr plugin, which might help to keep the plugin up-to-date with the javacc version?

Closed, since adding the extra brackets seems to work-around well.


move variants after boards

Reorder download dialog to put physical boards first.

Can we move Pi0 to the last?

Yes, much better.  Let's put the "Build it yourself Adafruit M4" at the end though.  Also, can we remove the Pi0 custom one?  That's only for the Arcade cabinet, right?

Pi0 is the variant for Adafruit Joybonnet or any Raspberry Pi 0 arcade like the PiCade.

Pi0 is the same as Adafruit Joy Bonnet, the same way as F401 is the same as Brainpad. I think we should keep all the ones that are "bootloader" screenshots for consistency.


allow installation from source using pip

I don't see any issues with this, but I'll leave it to @eeaston to merge it.

I still need to add some checks in common setup

alright, that appears to work!

Hiya - many thanks for this!
I don't mean to be pedantic but most of the changes in this PR seem to be whitespace related. Can we try and cut the changes down to just what's needed? Thanks :)

@eeaston Done. For the record, yapf made the formatting changes.

Great, thanks!


Cleanup syntax with dogma

Coverage decreased (-0.3%) to 72.353% when pulling f175abe99ba9106a4edba0850f6b613d0423f74c on hotfix/dogma into 28db355f26d87e134d2eec21f3bf0fc30d784ab5 on master.


is_major_master.sh

In is_major_master.sh
....
....
echo ">>> Will ask all nodes in the cluster"
NODES=PGPASSWORD=$REPLICATION_PASSWORD psql -h $CLUSTER_NODE_NETWORK_NAME -U $REPLICATION_USER $REPLICATION_DB  -c "SELECT conninfo FROM repmgr_$CLUSTER_NAME.repl_show_nodes WHERE cluster='$CLUSTER_NAME'" | grep host | awk '{print $3}' | cut -d "=" -f2
Only the first value in NODES gets checked, by the "for NODE in "${NODES[@]}"; do" loop.  It  seems like this needs to be declared similar to MASTER_MAP?  Something like
unset NODES
declare -A NODES

Fixed in master! Please check

Yes, this seems to be working now. ~Thanks


[occm] Document which information is exposed by "cloud-node" controller

/kind feature
The Openstack Cloud Controller Manager (occm) allows enabling an integration with the Openstack VMs through the "cloud-node" controller.
Unfortunately, it is not documented anywhere which information exactly will be exposed by the controller and where it will be exposed (i.e. in which annotations of the node resource).
I think it would be really helpful to have this documentation.

allows enabling an integration with the Openstack VMs through the "cloud-node" controller.

@jacksgt not sure I am follow this , just for education purpose, could you please point some where of the code or give some example on the plan / requirement here? thanks

Hello @jichenjc , thanks for your question.
I would like to have some documentation what the "cloud-node" controller of "openstack-cloud-controller-manager" does.
There is extensive documentation how to use the "service" controller, but it is not clear what I should expected when I run occm --controllers=cloud-node (the same applies for the "cloud-node-lifecycle" controller).
In the end, the documentation should state something like:

the cloud-node controller will add the annotation example.com/example to all your nodes
the cloud-node controller will set the .status.foo.bar field on all nodes.
...

ok, it depends on your purpose of generic cloud provider or OCCM
https://github.com/kubernetes/cloud-provider/blob/master/app/controllermanager.go#L393
is the place where cloud-node is defined so I think if you want to update generic things,
that repo might be better places
if it's for OCCM only, we might only want to focus on OCCM unique updates of annotation and fields
the more doc the health of the repo so please let us know what stuffs you want to add

The node controller is not specific to openstack-cloud-controller-manager, it's a common thing for all the cloud controllers.
/close


Enhancement: Addition of space creator to Subscribers at Creation of Space

Logically, the creator of space should be added to the subscriber at creation of space initially. Of course, he/she can remove himself/herself later.

The issue has been closed with PR.


Update missing plugin help links

Description:

Ractive.js: Missing "fade" transition plugin. You may need to download a plugin via http://docs.ractivejs.org/latest/plugins#transitions

Just putting this out there before I forget about these (because I rarely use plugins in most cases). At least the redirect from the old domain is still there, so at least you're not led to nowhere.
The plan after the monorepo PR is to document all Official Plugins™ in the docs site.
Versions affected:
0.9+
Reproduction:
Use fade plugin without loading it.

I found three instance of docs.ractivejs.org and replaced them with the appropriate links to ractive.js.org.


How to validate if atleast one text field is entered out of three text fields?

Are you requesting a feature, reporting a bug or ask a question?
Yes
What is the current behavior?
What is the expected behavior?
I have three text fields and I want to validate if atleast one is entered out of three.
How would you reproduce the current behavior (if this is a bug)?
Provide the test code and the tested page URL (if applicable)
Tested page URL:
Test code
your_code_here

Specify your

browser:
browser version:
surveyjs platform (angular or react or jquery or knockout or vue):
surveyjs version:

You need to process onValidateQuestion event, as shown in this example - https://surveyjs.io/Examples/Library/?id=validators-event&platform=jQuery

@akmr9 Here is the plunker example: https://plnkr.co/edit/LnCbZm?p=info
Thank you,
Andrew

Works great. Thanks.


Unify "saveToFile" API

Also change the default behavior to include all namespaces and to cull it based off of the top module.

@David-Durst, this should fix your https://github.com/leonardt/fault/pull/163#issuecomment-536663783


Adjust line ending for CC attributions

Pull Request Test Coverage Report for Build 1239

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 86.42%

Totals

Change from base Build 1235:
0.0%

Covered Lines:
805

Relevant Lines:
921

💛  - Coveralls

Pull Request Test Coverage Report for Build 1239

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 86.42%

Totals

Change from base Build 1235:
0.0%

Covered Lines:
805

Relevant Lines:
921

💛  - Coveralls


[Fzf-lua] fzf error 2: invalid preview window layout: nohidden:right:0

hi, I wanted to try this plugin but as soon as I want to start the command :lua require('fzf-lua').files()
nothing displays and I have this error:
[Fzf-lua] fzf error 2: invalid preview window layout: nohidden:right:0
I didn't configure anything, just literally installed the pluging and wanted to try it out.
I am using neovim 0.5.1, I also have the classic fzf installed as well as telescope, could it be a conflict ?

I am running fzf 0.20.0 and I use ubuntu 20.04
just to be sure I cleaned my fzf vim by commenting out   Plug 'junegunn/fzf', { 'do': { -> fzf#install() } }
then deleting and reinstalling again.

ok problem solved, I did a sudo apt remove fzf and then out of curiosity I did a fzf --version and I got 0.27.2 displayed. I don't really understand what happened but it seems to have solved the problem.

ok problem solved, I did a sudo apt remove fzf and then out of curiosity I did a fzf --version and I got 0.27.2 displayed. I don't really understand what happened but it seems to have solved the problem.

You had an old version of the fzf binary installed which didn’t support the preview options.
For the record, it doesn’t matter how you install fzf, either globally on your machine or using the plugin junegunn/fzf, the only requirement is having an fzf version that could accept the preview params (0.23 I believe but not sure).
Glad you were able to sort this out.


Cannot show stderr when using Jupyter

Hello,
Could you please have a look about this.
I am using TF and Jupyter. But what makes me confuse is that the log text cannot be shown in Jupyter output cell (but it output correctly in ipython).
I think it is because of the stderr. This issue have been discussed before in #3047. You add several lines to determine whether or not current context is in an interactive environment.
However, even if I use Jupyter, the return value of "sys.flags.interactive" is still zero. and the logger lever can never be setted to "info" and use "stdout" instead of "stderr".
Thanks a lot!

This would be good to fix, meanwhile I've been using this work-around with FDRedirector from here
STDERR = 2
redirect = FDRedirector(STDERR)
import tensorflow as tf
sess = tf.Session("")
node = tf.Print(tf.constant(1), [tf.constant(1)], "longstringlongstring")
def print_to_stderr():
    sess.run(node)   # this prints to stderr
redirect.start();
print_to_stderr()
captured_stderr = redirect.stop()

The downside is that this hangs inside tensorflow print if pipe buffer is exceeded (65k)

@zheng-xq do you think we need a fix like the one you did for interactive? Or just a flag?

Same issue happens exists Jupyter QtConsole, no logs. ipython shows the logs.

It has been 14 days with no activity and this issue has an assignee.Please update the label and/or status accordingly.

This bug still seems valid. This behavior has not changed.

Is there a way to tell whether you're in that particular Jupyter environment?
We are already checking for some interactive environments, and redirecting logs appropriately (from https://github.com/tensorflow/tensorflow/blob/master/tensorflow/python/platform/tf_logging.py#L65):
      _interactive = False
      try:
        # This is only defined in interactive shells.
        if _sys.ps1: _interactive = True
      except AttributeError:
        # Even now, we may be in an interactive shell with `python -i`.
        _interactive = _sys.flags.interactive

      # If we are in an interactive environment (like Jupyter), set loglevel
      # to INFO and pipe the output to stdout.
      if _interactive:
        logger.setLevel(INFO)
        _logging_target = _sys.stdout
      else:
        _logging_target = _sys.stderr

If anyone knows of a better way to determine _interactive, send a PR (or tell me, and I will).

@martinwicke How about adding a check to see if IPython has injected the appropriate attribute?  (I have no current environment to test this at the moment, else i'd do the code change myself.)
      _interactive = False
      try:
        # This is only defined in interactive shells.
        if _sys.ps1: _interactive = True
      except AttributeError:
        # Even now, we may be in an interactive shell with `python -i`.
        _interactive = _sys.flags.interactive

      if not _interactive:
        try:
          # Do we have access to IPython libraries, and if we do has get_ipython been injected?
          from IPython.display import clear_output
          get_ipython
          _interactive = True
        except (ImportError, NameError):
          pass

      # If we are in an interactive environment (like Jupyter), set loglevel
      # to INFO and pipe the output to stdout.
      if _interactive:
        logger.setLevel(INFO)
        _logging_target = _sys.stdout
      else:
        _logging_target = _sys.stderr

Excellent! I will try this.

Seems to work, sent PR. Thanks Loki!

Poifect... my pleasure.

Is there a clean way to fix the issue, or some manual override to make tf.Print works with Jupyter?
FDRedirector is a barely workable solution, as it is not available in latest IPython anymore.


Inconsistent output on node:16-alpine container for busybox ps and procps ps

Describe the bug
In addition to multiple props being inconsistent (as seen below in the Current Output), the started time results in NaN-aN-aN NaN:NaN:aN, when using systeminformation.processes(), if a certain amount of process runtime has elapsed. My findings suggest the invalid started prop is due to the etime output formatting not matching 00:00:00 and instead matches a relative time, i.e. 1h34.
To remedy this issue, I needed to install procps, which then output the etime in the expected format.
To Reproduce
I've created a git repo to illustrate the problem.
Steps to run:
git clone https://github.com/simontong/systeminformation-issue1
cd systeminformation-issue1
docker run --rm -it (docker build -q .)

Current Output
===[ busybox ]===
{
  pid: 7,
  parentPid: 1,
  name: 'node',
  cpu: 0,
  cpuu: 0,
  cpus: 0,
  mem: 0,
  priority: 0,
  memVsz: 10,
  memRss: 40,
  nice: 0,
  started: '2022-12-02 23:59:26',
  state: 'running',
  tty: '136.0',
  user: 'root',
  command: 'node'
}
===[ procps ]===
{
  pid: 1,
  parentPid: 0,
  name: 'node',
  cpu: 0.000018171938509184832,
  cpuu: 0.00001465478912031035,
  cpus: 0.0000035171493888744838,
  mem: 0,
  priority: 19,
  memVsz: 10775264,
  memRss: 41636,
  nice: 0,
  started: '2022-12-06 23:59:27',
  state: 'running',
  tty: 'pts/0',
  user: 'root',
  command: 'node index.mjs',
  params: '',
  path: ''
}

Expected behavior
The return value before and after installing procps should be the same. Either that, or outputting an error message suggesting they need to install procps.
Environment (please complete the following information):

systeminformation package version: 5.16.1
Docker OS: node:16-alpine

Additional context
n/a

@simontong thank you for reporting, I will have a closer look on it and provide a fix as soon as possible.

@simontong busybox ps does not support output params pcpu and pmem, therefore there is a fallback. As this package should work on as much distros as possible without firing error messages and the need of additional installation I did implemented this fallback (where we do not have CPU and MEM values. Hope this makes sense.

Thanks for investigating that, appreciate it.
Were you able to reproduce the other issue with the etime time formatting? It requires waiting a period of time (possibly around an hour?) and then the formatting switches from 00:00 to 1h00 and the code doesn't parse it correctly anymore.

Sorry @simontong … seems that I did not really read your issue report correctly. This time format issue is of course something I need to have a look at. I am sure I will find a way to also handle this correctly. Sorry once again for not reading your comment correctly ;-)

Don't sweat it :)

@simontong I now fixed the started issue in si.processes() and was able to test it on node:16-alpine. Seems to be fine now. Version 5.16.4 just released. Can you check it also on your side?

Big thanks, @sebhildebrandt. That appears to be working now. I just tested it on a container with around 1d01 as the etime and the started time is now 2022-12-10 20:6:24. I assume the single-digit minute is intended (instead of 06)?

@simontong single digit is not really intended ... let me check and provide a fix ...
found it. Version 5.16.6 just published.


Blish HUD shows in the taskbar which makes it also visible when pressing ALT + TAB.

Ɗ.ŁΔŴ at 4/20/2019 8:05:57 PM +00:00

Btw, is it supposed to be like this when u alt tab? The hud showing up like a tab?

REF: https://discordapp.com/channels/531175899588984842/534492012263636992/569252438926688269

Added an option (defaults to "do not show") to toggle showing in the taskbar in #126.


.Net Handlebars planner shouldn't utilize system messages

Current Handlebars planner prompt uses many messages with the "system" role. It causes that planner is unusable with other models than openai models. Many models like for example gemini support only user and assistant message role.
We should change prompt to utilize only messages with user and assistant roles.

Closing as a duplicate of https://github.com/microsoft/semantic-kernel/issues/4870. I'll respond in the other issue, but our plan is to get additional models that have Chat Completion support so that you can use the Handlebars planner with other models other than OpenAI.


Bartwe/sdlgpudx12 0730

Make the functions that don't leave the compilation unit as static
Implement more functionality
Fix a number of warnings

Superseded by https://github.com/thatcosmonaut/SDL/pull/113 and https://github.com/thatcosmonaut/SDL/pull/125


IE doesn't support?

Are you requesting a feature or reporting a bug?
run testcafe-live ie
url is like <IP_ADDRESS>.
It is bug. others works fine. (Edge, Firefox(Mac), Chrome(Mac), safari(Mac))
 Getting Started
(node:1152) UnhandledPromiseRejectionWarning: Error: Protocol "about:" not supported. Expected "https:"
    at new ClientRequest (_http_client.js:131:11)
    at Object.request (http.js:38:10)
    at Domain.<anonymous> (C:\Users\IEUser\Documents\react_e2e\node_modules\testcafe-hammerhead\lib\request-pipeline\destination-request\index.js:97:51)
    at Domain.run (domain.js:242:14)
    at exports.default (C:\Users\IEUser\Documents\react_e2e\node_modules\testcafe-hammerhead\lib\request-pipeline\connection-reset-guard.js:6:27)
    at DestinationRequest._send (C:\Users\IEUser\Documents\react_e2e\node_modules\testcafe-hammerhead\lib\request-pipeline\destination-request\index.js:94:44)
    at new DestinationRequest (C:\Users\IEUser\Documents\react_e2e\node_modules\testcafe-hammerhead\lib\request-pipeline\destination-request\index.js:87:15)
    at sendRequest (C:\Users\IEUser\Documents\react_e2e\node_modules\testcafe-hammerhead\lib\request-pipeline\index.js:346:77)
    at Object.sendDestinationRequest (C:\Users\IEUser\Documents\react_e2e\node_modules\testcafe-hammerhead\lib\request-pipeline\index.js:122:20)
    at next (C:\Users\IEUser\Documents\react_e2e\node_modules\testcafe-hammerhead\lib\request-pipeline\index.js:373:38)
(node:1152) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:1152) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

What is the current behavior?
I wrote above.
What is the expected behavior?
run fine.
How would you reproduce the current behavior (if this is a bug)?
(node:1152) UnhandledPromiseRejectionWarning: Error: Protocol "about:" not supported. Expected "https:"
Provide the test code and the tested page URL (if applicable)
Tested page URL:
sorry secret.
Test code
test('test name', async t => {
    await t.setNativeDialogHandler(() => true)
        .useRole(regularAccUser)
        .navigateTo(url);

Specify your

operating system: Windows 8(Virtual Machine)
testcafe version: 0.20.0
node.js version: v8.11.3

Hi @moffsugita
I am afraid this information is not sufficient to find the cause of the issue. Could you please provide a small example so that we can reproduce it on our side?

I will close the issue because no activity has been encountered for a long time.
Feel free to reopen the issue if the problem persists and you can provide an example to reproduce it.


Can someone create a step by step guide on setting up an Peatio exchange?

Hey!
I'm wondering if someone could create a step by step guide on how to setup a simple Peatio exchange?
Explain like if i was a kid hehe. Thank you!
And if they already exist, please be kind and link a guide! 👍

Yes please.

@Duzzify add me on skype :  algobasket
I can install and integrate every corner of peatio


Implement Continuous Integration

Implement a test suite that can run both locally and on Travis CI, that verifies that the example code passes the test suite for each exercise.
Things to consider:
If some tests are marked as skipped or pending in some way, then CI should remove these annotations so that all the tests run against the example, not just the first test.
If we need to rewrite the files in any way, we should copy the exercise to a tmp directory first, so that we don't accidentally end up committing changes that are just for continuous integration or testing purposes.
We should make it possible to test just one exercise at a time, because testing everything can take a while, and very often people are just working on one exercise and will only need to run the full test suite before committing the change.

@kytrinyx does Travis do Windows?  @kotp and I are concerned that it might not.  Yes, I know, I made a punny.

@rpottsoh I don't know. I don't think so. Will AppVeyor work?

Good question.  I am not familiar with AppVeyor.   Will go read about now.

At quick glance it looks like it provides a VM in which we would need to install Windows for Delphi to run on or is AppVeyor providing Windows too?  This looks promising.   Thanks for pointing it out.

Reference links, @rpottsoh ??

AppVeyor landing page
Documentation

Just noticed file appveyor.yml sitting in xcsharp.  I'm assuming AppVeyor is already in use by some tracks.

Yeah, C#, F#, and it's also turned on for VB.NET and (now) Delphi.

@kotp how do we proceed?  I am out of my element here, but interested to watch, learn and help.

We can work it after your happy anniversary weekend!


Не могу подключиться до перезапуска компьютера

Пользовался AmneziaWG, решил перейти на AmneziaVPN. На первом всё летало, работало отлично, на втором иногда отключает и не может нивкакую обратно подключить(за миллисекунду отключает), только перезапуск компьютера помогает. Killswitch выключен.  We do not provide support for client here.


Feature request: Support Mocha

(The title already says it all)

It's the next point on my list - support more TDD frameworks ;)
Do you have a project with which I can test it (real life) - except mocha itself.

I added mocha support now. See examples/mocha_coveraje for an working example (you can see coverage results for mocha with it).
There are some known (and propably one or two unknown *g*) problems, but I think it's OK for the most tests now...
I'm waiting for https://github.com/visionmedia/mocha/issues/265

Close this, since theres now a basic support for mocha...


Update github-actions.md

Fixes incorrect documentation around AWS_REGION

Proposed changes

Fixes issue with incorrect secret usage env.AWS_REGION to secrets.AWS_REGION

thanks so much for this @njbmartin!

There's another error in that stack-name is also required.


Set JAVA_HOME according to the information provided by java itself

Overview
The script depends on the line containing "Java home" string in the output of the 'mvn --version' command, which doesn't have this line. This is fair for Maven 3.5.4 with JDK 1.8.0 and JDK 10.0.2.
Besides that, I prefer rather check whether $JAVA_HOME is defined in the user's environment, than extract it from the third-party command (which could change it's output somewhere in the future).
Anyway, this PR fixes build of the exonum-java-binding-core.
Thanks.

Interesting that we specifically changed the script to not use JAVA_HOME from the environment: 33376bf4100eb454c1409456d19daf09029479ee
We did that just before release when were integrating native-proxies into master, so there is no detailed enough description in the commit :-) But I believe we did that because Maven (?) set the environment variable incorrectly (so it was set by Maven), but it did so incorrectly on some systems.
Does anyone remember the details (@vitvakatu , @alexander-irbis , @MakarovS )?

I agree this script is absolutely not reliable, I remember there also was some code that printed the java system property 'java.home' by launching the jvm with some command line flags.

In some cases system JAVA_HOME is set to directory in which we can't find libjvm.so.

In some cases system JAVA_HOME is set to directory in which we can't find libjvm.so.

Do you mean the case when supposedly Maven set it, which made us override it (https://github.com/exonum/exonum-java-binding/commit/33376bf4100eb454c1409456d19daf09029479ee)?
Or does java incorrectly report it in some cases?