TypeError: 'NoneType' object is not callable

I want to recompile the model using callback but it does not work. See below. I'm using TF 2.9.
import tensorflow as tf
from tensorflow import keras

# Define the Keras model to add callbacks to
def get_model():
    model = keras.Sequential()
    model.add(keras.layers.Dense(1, input_dim=784))
    model.compile(
        optimizer=keras.optimizers.RMSprop(learning_rate=0.1),
        loss="mean_squared_error",
        metrics=["mean_absolute_error"],
    )
    return model

# Load example MNIST data and pre-process it
(x_train, y_train), (x_test, y_test) = tf.keras.datasets.mnist.load_data()
x_train = x_train.reshape(-1, 784).astype("float32") / 255.0
x_test = x_test.reshape(-1, 784).astype("float32") / 255.0

# Limit the data to 1000 samples
x_train = x_train[:1000]
y_train = y_train[:1000]
x_test = x_test[:1000]
y_test = y_test[:1000]

In below, see in on_epoch_begin method, where recompiling is tried. For this, training can not be done. How to enable recompiling the keras model?
class CustomLearningRateScheduler(keras.callbacks.Callback):
    """Learning rate scheduler which sets the learning rate according to schedule.

  Arguments:
      schedule: a function that takes an epoch index
          (integer, indexed from 0) and current learning rate
          as inputs and returns a new learning rate as output (float).
  """

    def __init__(self, schedule):
        super(CustomLearningRateScheduler, self).__init__()
        self.schedule = schedule

    def on_epoch_begin(self, epoch, logs=None):
        if not hasattr(self.model.optimizer, "lr"):
            raise ValueError('Optimizer must have a "lr" attribute.')
        # Get the current learning rate from model's optimizer.
        lr = float(tf.keras.backend.get_value(self.model.optimizer.learning_rate))
        # Call schedule function to get the scheduled learning rate.
        scheduled_lr = self.schedule(epoch, lr)
        # Set the value back to the optimizer before this epoch starts
        tf.keras.backend.set_value(self.model.optimizer.lr, scheduled_lr)

        self.model.compile(
            optimizer=keras.optimizers.RMSprop(learning_rate=0.1),
            loss="mean_squared_error",
            metrics=["mean_absolute_error"],
        )
        print("\nEpoch %05d: Learning rate is %6.4f." % (epoch, scheduled_lr))

LR_SCHEDULE = [
    # (epoch to start, learning rate) tuples
    (3, 0.05),
    (6, 0.01),
    (9, 0.005),
    (12, 0.001),
]

def lr_schedule(epoch, lr):
    """Helper function to retrieve the scheduled learning rate based on epoch."""
    if epoch < LR_SCHEDULE[0][0] or epoch > LR_SCHEDULE[-1][0]:
        return lr
    for i in range(len(LR_SCHEDULE)):
        if epoch == LR_SCHEDULE[i][0]:
            return LR_SCHEDULE[i][1]
    return lr

model = get_model()
model.fit(
    x_train,
    y_train,
    batch_size=64,
    steps_per_epoch=5,
    epochs=15,
    verbose=0,
    callbacks=[
        CustomLearningRateScheduler(lr_schedule),
    ],
)

Epoch 00000: Learning rate is 0.1000.
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
/tmp/ipykernel_27/3511289952.py in <module>
     58     verbose=0,
     59     callbacks=[
---> 60         CustomLearningRateScheduler(lr_schedule),
     61     ],
     62 )

/opt/conda/lib/python3.7/site-packages/keras/engine/training.py in fit(self, x, y, batch_size, epochs, verbose, callbacks, validation_split, validation_data, shuffle, class_weight, sample_weight, initial_epoch, steps_per_epoch, validation_steps, validation_batch_size, validation_freq, max_queue_size, workers, use_multiprocessing)
   1182                 _r=1):
   1183               callbacks.on_train_batch_begin(step)
-> 1184               tmp_logs = self.train_function(iterator)
   1185               if data_handler.should_sync:
   1186                 context.async_wait()

TypeError: 'NoneType' object is not callable

Is it valid? The error mainly occurs for this, where I try to recompile the model.
class CustomLearningRateScheduler(keras.callbacks.Callback):
    def on_epoch_begin(self, epoch, logs=None):
        self.model.compile(
            optimizer=keras.optimizers.RMSprop(learning_rate=0.1),
            loss="mean_squared_error",
            metrics=["mean_absolute_error"],
        )

@SuryanarayanaY I was able to replicate the issue on colab, please find the gist here. Thank you!

Hi @Suzan009 ,
Thanks for writing us. Calling model.compile() in Custom Callbacks not valid.Whenever we call model.fit() internally TF calls make_train_function() which creates a function that executes one step of training. This function is cached the first time Model.fit or Model.train_on_batch is called. The cache is cleared wheneverModel.compile is called.Hence the error 'NoneType' object is not callable might be popping out.Please refer to source here for more details.
However we can define our own compile() method by Subclassing our model to tf.keras.Model API and then we can override the default train_step() method and configure it wrt loss functions and optimizers as per our requirement.Please find the attached example for one such use case.
Thankyou!

@SuryanarayanaY
I've found an issue that is somewhat similar to mine, https://github.com/keras-team/keras/issues/13368. It was closed as complete on Jun 25, 2021. What does it mean?
I've a case where I need to recompile with different parameter inside the self.model.compile method during the training time. As you said, calling model.compile() in custom callback is not valid. Well, I would argue a bit, see a ticket here https://github.com/keras-team/keras/issues/9477, It looks that it was cetainly possible to do that but this issue was also closed on Jun 25, 2021 by keras author. What a coincident!

@gowthamkpr
I think it's a valid request to able to recompile the model using callback. Here is the gist.
https://github.com/keras-team/keras/issues/9477
https://github.com/keras-team/keras/issues/13368
S0: https://stackoverflow.com/q/75361509/9215780
cc. @ahundt


Fe-related resources are hard to find

What is wrong?
Resources regarding fe are hard to find.
From what I have observed, The fe name is very SEO unfriendly since it can be an abbreviation for a lot of things. When I search for something like "fe awesome" on github/google I end up with results for Frontend (shortened as fe) or other resources that are not related to software development at all.
How can it be fixed
It might be helpful in the future if fe had a more unique/longer alternative name (could be like Ferrum or something). Though I'm really just here to see if anyone has links to an awesome list of sorts that can lead me to implementations or tools that others have been working on.

It's generally a good idea to append "lang" when searching for content regarding a computer language. Works well for C, C#, Rust as well as Fe. If you google for fe-lang I bet you'll find fe-lang.org which is pretty much the main source at the moment.

Naming things is hard. I don't think we'll be changing the name at this point. fe is ungoogleable because it's still obscure; compare with other smart contract languages like "move" and "obsidian", neither of which is googleable without adding "lang". (Both of which are very interesting languages worth looking into, btw)
@skeithc There isn't an "awesome" list yet; if you (or anyone else) is interested in making one, that would be awesome, and we can help assemble any resources we're aware of (which are few and far between so far, but we'll be focusing on extending tooling support, etc this coming year.

I did a search today, and got the below result


Bower referencing old author and unable to download

Have not tried pulling this repo into a project in a little while and it appears the author has changed (from NextStepWebs. When trying to include the project via composer it seems the old URL is still being referenced. Error being returned:
Installing bower-asset/simplemde (1.11.2): Downloading (failed)    Failed to download bower-asset/simplemde from dist: The "https://api.github.com/repos/NextStepWebs/simplemde-markdown-editor/zipball/6abda7ab68cc20f4aca870eb243747951b90ab04" file could not be downloaded (HTTP/1.1 302 Found)
Not sure what needs to be updated, but, right now SimpleMDE seemingly cannot be pulled into a project (at least not via composer, and thus not included in a docker build).
Even when searching for SimpleMDE on https://bower.io/search/ I can see the reference is to the old github author.

At this time, I am implementing the following, not-too-terrible-but-not-ideal workaround.
  "require": {
    ...
    "sparksuite/simplemde-markdown-editor": "1.11.2",
  },
  "repositories": {
    "simplemde": {
      "type": "package",
      "package" : {
        "name": "sparksuite/simplemde-markdown-editor",
        "version": "1.11.2",
        "source": {
          "url": "https://github.com/sparksuite/simplemde-markdown-editor",
          "type": "git",
          "reference": "master"
        }
      }
    }
  },

Feel free to use my fork. It's basically development branch, but built with latest codemirror.
Just type:
bower install https://github.com/Greenek/simplemde-markdown-editor.git\#development --save
or add
"simplemde": "Greenek/simplemde-markdown-editor#development" to bower.json.

@Greenek Would you consider applying to take over maintenance of the project? It appears that this one hasn't had any activity for a number of months now. And we've been waiting even longer for a new release to be tagged.

If @sparksuite is not interested anymore with this project I could take it. For now you can use my fork, I try to keep it updated with new codemirror releases.

The bummer is that Wes is committing to other repositories he owns so he is still active--just appears to be neglecting SimpleMDE (for over four months now). @WesCossick, can we get some word on the status of this repo? Still maintained, abandoned, etc?


Signature faulty with rotate_with_page = False on rotated pages/pdfs

Describe the bug
When you create a signature on a page that has the Rotate Parameter (e.g. /Rotate 90) with the rotate_with_page paramter set to False then the visible Signature will correctly stay horizontal like it should when its opened in a browser.
Should you then open the same file in Adobe Acrobat Reader instead, it will not be visible at all, but still have a clickable invisible box where it should have been visible, and a "selected" box that was rotated with the page.
To Reproduce
Steps to reproduce the behavior:

Create any pdf (I used MS Word)
Rotate the PDF (I used https://smallpdf.com/rotate-pdf)
Sign the pdf with pyHanko:

input_file = 'input path here'
output_file = 'output path here'
signer = signers.SimpleSigner.load(certificate_key, certificate_cert)
    inFile = open(input_file, 'rb')
    w = IncrementalPdfFileWriter(inFile, strict=False)
    fields.append_signature_field(
        w, sig_field_spec=fields.SigFieldSpec(
            'Signature',
            box=(31, 195, 564, 99),
            on_page=0,
            visible_sig_settings=fields.VisibleSigSettings(False)
        )
    )
    meta = signers.PdfSignatureMetadata(field_name='Signature')
    stamp_style = stamp.StaticStampStyle.from_pdf_file(stamp_file,
        border_width=0,
        background_layout=SimpleBoxLayoutRule(
            margins=Margins(0,0,0,0),
            x_align=AxisAlignment.ALIGN_MID,
            y_align=AxisAlignment.ALIGN_MID,
            inner_content_scaling=InnerScaling.STRETCH_FILL
        ),
    )
    pdf_signer = signers.PdfSigner(
        # stamp style: https://pyhanko.readthedocs.io/en/latest/api-docs/pyhanko.html#pyhanko.stamp.StaticStampStyle
        meta, signer=signer, stamp_style=stamp_style
    )

    with open(output_file, 'wb') as outFile:
        # with QR stamps, the 'url' text parameter is special-cased and mandatory, even if it
        # doesn't occur in the stamp text: this is because the value of the 'url' parameter is
        # also used to render the QR code.
        pdf_signer.sign_pdf(
            w, output=outFile,
        )

    inFile.close()

Expected behavior
Signature is visible in Adobe Acrobat reader.
Based on my research, which could very well be wrong, i think the Appearence Annotations need to have either the norotate flag set (if that is even possible) or /Matrix added to rotate it against the page rotation.
Here are the values you would have to add as a /Matrix parameter based on the /Rotate parameter of the page:
                match pagetree_obj['/Rotate']:
                    case 0:
                        matrix = (1.0, 0.0, 0.0, 1.0, 0.0, 0.0)
                    case 90:
                        matrix = (0.0, 1.0, -1.0, 0.0, 0.0, 0.0)
                    case 180:
                        matrix = (-1.0, 0.0, 0.0, -1.0, 0.0, 0.0)
                    case 270:
                        matrix = (0.0, -1.0, 1.0, 0.0, 0.0, 0.0)

Screenshots
When opened in Browser (Opera):

When opened in Adobe Acrobat Reader:

Environment (please complete the following information):

Windows 11

Here is the file that i used to create the screenshots:
faulty signature pyhanko.pdf

This is a side effect of the fact that pyHanko doesn't really look at page rotation settings. See these threads, for example:

https://github.com/MatthiasValvekens/pyHanko/discussions/202
https://github.com/MatthiasValvekens/pyHanko/discussions/156

You could try with NoRotate, but given that that's notoriously finicky it might be better to hardwire the rotation into the annotation content stream after all... Somewhat ironically, this is what Acrobat actually does these days when putting signatures on rotated pages, instead of trying to use the format's "native" way of coping with these things.
I'll check how much effort this would be to implement.


Add UI testing to compare color change

Figure out a way to check if the switch and buttons that change colors are actually changing the colors on screen.
Maybe taking a screenshot and then doing an image comparison might be worth it.
Although this would also require adding some custom matchers for XCUITests

Great Idea.
Maybe also, something like this could work?
extension UIView
{
    func colorOfPoint (point: CGPoint) -> UIColor
    {
        var pixel = UnsafePointer<CUnsignedChar>.alloc(4)
        let colorSpace = CGColorSpaceCreateDeviceRGB()
        let bitmapInfo = CGBitmapInfo.fromRaw(CGImageAlphaInfo.PremultipliedLast.toRaw())!
        let context = CGBitmapContextCreate(pixel, 1, 1, 8, 4, colorSpace, bitmapInfo)

        CGContextTranslateCTM(context, -point.x, -point.y)

        self.layer.renderInContext(context)

        CGContextRelease(context)
        CGColorSpaceRelease(colorSpace)

        return UIColor(red: Float(pixel [0]) / 255.0, green: Float (pixel [1]) / 255.0, blue: Float (pixel [2]) / 255.0 , alpha: Float (pixel [3]) / 255.0)
    }
}

And could be use like this:
override func touchesBegan(touches: NSSet!, withEvent event: UIEvent!)
{
    let touch : UITouch = event.allTouches().anyObject() as UITouch
    let location = touch.locationInView(self.view)
    pickedColor = self.view.colorOfPoint (location)
    // Do something with picked color.
}

So instead of screenshots, we could get the actual color of the UIView and compare. :thinking_face:

Problem is that we don't access to the underlying UIView on XCUITests
–
Esteban Torres
CraftKollective(http://craftkollective.com)Co-Founder
Phone:(+506)8813-0934(tel:(+506)8813-0934)
Skype:esteban.a.torres.hernandez
Twitter:@esttorhe(https://twitter.com/esttorhe)
On Jun 30, 2016, 17:38 -0600, Chris<EMAIL_ADDRESS>wrote:

Great Idea.
Maybe also, something like this could work?
extension UIView {   func colorOfPoint (point: CGPoint) ->UIColor   {     var pixel = UnsafePointer.alloc(4)     let colorSpace = CGColorSpaceCreateDeviceRGB()     let bitmapInfo = CGBitmapInfo.fromRaw(CGImageAlphaInfo.PremultipliedLast.toRaw())!     let context = CGBitmapContextCreate(pixel, 1, 1, 8, 4, colorSpace, bitmapInfo)     CGContextTranslateCTM(context, -point.x, -point.y)     self.layer.renderInContext(context)     CGContextRelease(context)     CGColorSpaceRelease(colorSpace)     return UIColor(red: Float(pixel [0]) / 255.0, green: Float (pixel [1]) / 255.0, blue: Float (pixel [2]) / 255.0 , alpha: Float (pixel [3]) / 255.0)   } }
And could be use like this:
override func touchesBegan(touches: NSSet!, withEvent event: UIEvent!) {   let touch : UITouch = event.allTouches().anyObject() as UITouch   let location = touch.locationInView(self.view)   pickedColor = self.view.colorOfPoint (location)   // Do something with picked color. }
So instead of screenshots, we could get the actual color of the UIView and compare. :thinking_face:
—
You are receiving this because you authored the thread.
Reply to this email directly,view it on GitHub(https://github.com/PiXeL16/CountItApp/issues/3#issuecomment-229818254), ormute the thread(https://github.com/notifications/unsubscribe/AChTorVGI9C9cJR6xRATM6o5Sp9oDX2yks5qRFNzgaJpZM4JCqzy).

Yes, I was thinking on sending params when XCUITests is running, and using that functionality for  printing colors on screen or something that XCUITests can check. But kind of ugly... ¯_(ツ)_/¯


Suppression of final primitive fields doesn't work.

Suppression of final primitive fields doesn't work. The calls are never
intercepted by the MockGateway for some reason. Perhaps it's something
wrong with Javassist?

Tests has been added.

The issue cannot be fixed. The javac inlines values of final static int/long/boolean during compile time. So these values cannot be suspected.


Updating README.md for PubSub, Bigtable, IOT, and Spanner

Updating README.md for PubSub, Bigtable, IOT, and Spanner

Thanks for this!


miaolz123/vue-helmet comparison

Any pros/cons against this project? https://github.com/miaolz123/vue-helmet

That project might be OK smaller apps but it doesn't offer support for server rendering and appears to have a small subset of the features offered here.
At a first glance it appears to be missing support for style tags, body attributes, noscript tags, and subscribing to changes. I'm not sure, but it also appears it won't update tags on prop changes - though I haven't confirmed this. It also does not appear to be production-ready as it has no tests.
This is module is fairly full-featured and production ready.


FormData object not detected by XHR wrapper libraries

The axios XHR wrapper library fails to detect RN FormData objects:
Expected output as seen in browsers: formData.toString() === "[object FormData]"
Actual output from RN:  formData.toString() === "[object Object]"
This appears to be a completeness-of-implementation in RN breaking compatibility.
Detection code in axios, currently broken with RN causing uploads to fail, is as follows:
https://github.com/mzabriskie/axios/blob/master/lib/utils.js
/**

Determine if a value is a FormData

@param {Object} val The value to test
@returns {boolean} True if value is an FormData, otherwise false
*/
function isFormData(val) {
return toString.call(val) === '[object FormData]';
}

We should be able to fix this by overriding toString -- someone want to send a PR?

So, the same problem seems to exist with other object instances:
Browser: new XMLHttpRequest().toString() "[object XMLHttpRequest]"
RN: new XMLHttpRequest().toString() "[object Object]"
So we're looking at a convention that DOM implementations follow. Instead of dealing with conformance issues as they arise individually, I'd suggest implementing this as a mixin and applying it to all DOM-like classes in react-native's browser-like API layer.

@mcorb  @ide Language specs say that the behaviour is consistent. I couldn't find much in XMLHttpRequest specs either. Is it still justified then?

@prometheansacrifice Doesn't hurt to be consistent with the web implementation even if it's not in the specs. Who knows how many more libraries are using the same approach!
@mcorb Would be awesome if you could send a PR to fix this.

I have realised two things after playing around with this - hence I am not sure if we can really do anything about it.
First thing is - overwriting toString is not going to work with axios since it calls Object.prototype.toString that has slightly different behaviour (more on that below). That means any custom things we do with that method on a class level won't do anything.
Second thing is - in most cases toString when called on an object, returns e.g. length of an array. The reason it prints [object Array] when called on Object's prototype is because the behaviour is slightly different. Object.prototype.toString returns the value of the internal [[Class]] property. It's value is a specification defined classification of an object and the values are: "Object", "Array", "Function", "Date", "RegExp", "String", "Number", "Boolean", "Error", "Math", "JSON", "null", "undefined" and "Arguments" for the arguments object. However - it's value for host objects like DOM elements or things like FormData and XMLHttpRequest can vary and is completely implementation-dependent (however it's good to notice that major browsers implemented same behaviour for these two).
More on that here: http://www.ecma-international.org/ecma-262/5.1/#sec-<IP_ADDRESS>
Having said the above, I am not sure if there's any way to overwrite that. One of the solutions (which is quite brittle btw) would be to overwrite Object.prototype.toString in React Native to properly classify host-provided objects (which in our case are FormData, XMLHttpRequest and possibly others).

PS. We could still implement toString as @ide suggested and I proposed in PR #6778, but that would require @mzabriskie to add || val.toString && val.toString() === [...] as a fallback to these checks.

It seems like there's no clear fix or bug here, and the outcome here would just be to support libraries like axios which is a "nice to have" rather than a "key requirement". I'm going to close this issue for now but if someone has a specific suggestion for fixing this I encourage them to open it as a new RFC issue.


live update problem

I have created a live chart and works well. I change the last point data on every update.
The problem start when using zoom function. Chart continues to updating when the zoom function is used. It takes a snapshot on first zoom and uses it every time when zooming is active. How to update zoom zoomableInit?

Any codepen or jsfiddle online demo to show ?
Post it here to help you more.


Project description?

Someone asked me today if we could add a description to the Github repo, which is unfortunately one thing I don't have access to. Could we add please one?
Could be as simple as the "Redux for Dart" description we have in the pubspec.

fixed - thanks for the heads up


feat: add icon for partition keys

We add an icon for artition keys in hive tables. The partition_keys are parsed by the hive loader. We left place for other loaders to put partition keys in the base_metastore_loader as well. The icon for partition keys should be like:

@czgu Great suggestion, updated!

LGTM, just 2 small nit

Updated!

@czgu Thanks for the advice!


Conditionally Apply Various Pipelines via the CR

Is your feature request related to a problem? Please describe.
Right now we are applying all of the pipelines ci/hosted/release this could be confusing to partners since they only care about the ci pipeline.
Describe the solution you'd like.
Update the CRD to have a boolean for for each for each pipeline type, something like the below.

applyCiPipeline: true - true by default in our sample
applyHostedPipeline: false false by default in our sample
applyReleasePipeline: false false by default in our sample

Based on what the user provides when they apply the CR, we would only apply the  tekton Pipelineresource(s) that the user requested. To keep things simple for the operator we can still apply all the tasks so we do not have to worry about looking in the pipeline yaml files to distinguish which task(s) goes with which pipeline(s).
We would then check for these booleans in the applyManifests code found here.
Describe alternatives you've considered.
Open to other ideas, but these are my initial thoughts.
Additional context.
N/A

The list of pipelines and/or their names can change in the future,  so we can instead of boolean have an enum?

/assign


🎉 2.0.0

ℹ About this release

Version: 2.0.0
Type: major
Last Release: 1.2.0 (8/4/2024, 9:30:31 AM) [?]
Commits to merge: 18 [?]

chore

Drop support for node.js v19 and v21 (2fff079)

⚡ BREAKING CHANGES

Drop node.js v21 Support

These node.js versions are no longer supported. For more information see https://nodejs.dev/en/about/releases/
📦 Dependencies

Update @prisma/client from ^5.17.0 to ^5.18.0
Update @sentry/node from ^8.22.0 to ^8.26.0
Update ical-generator from ^7.1.0 to ^7.2.0

📦 Development Dependencies

Added tsx ^4.16.2
Update @eslint/js from ^9.8.0 to ^9.9.0
Update @sebbo2002/semantic-release-docker from ^4.0.2 to ^4.0.3
Update @types/node from ^22.1.0 to ^22.5.0
Update eslint from ^9.8.0 to ^9.9.0
Update mocha from ^10.6.0 to ^10.7.3
Update prisma from ^5.17.0 to ^5.18.0
Update typedoc from ^0.26.3 to ^0.26.6
Update typescript-eslint from ^8.0.0-alpha.62 to ^8.2.0
Removed ts-node

:tada: This PR is included in version 2.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release
v2.0.0

Your semantic-release bot :package::rocket:


converting f-strings to normal strings, contents are not correctly preserved  f'{{test}}' == '{test}' != '{{test}}'

The f-string f"{{test}}" without a variable, it is automatically converted to "{{test}}".
But they are not the same. (See: https://peps.python.org/pep-0498/#escape-sequences ; e.g. f'{{ {4*10} }}' == '{ 40 }')
Expected: f"{{test}}" -> "{test}"
BTW, Thanks for ruff ... !

Thanks for filing!

(Confirmed, the autofix here just removes the prefix, but doesn't un-escape any curly contents.)


Prefill new issue via Help > Report Issues

Fixes #7497

cc @bpasero @joaomoreno

Should it not be identical to our template?

@bpasero I mentioned in the issue https://github.com/Microsoft/vscode/issues/7497

I can't figure out how to do new lines in the query string is the only issue, \n,
 and
 all seem to not work.

Does %0A work?

@joaomoreno https://github.com/Microsoft/vscode/issues/new?body=:0
o.0

Just updated and tested, here's the output:
- VSCode Version: 1.3.0-dev
- OS Version: Darwin x64

Steps to Reproduce:

1.
2.

I'll merge and update the stable/insiders report URLs


Add support of dash border

Close #387
Implemented on #388 (must be merged first)
This PR add a new a BorderType, currently supporting:

Solid (default)
Dash: support exactly the same configuration as borderSides

I also used that PR to make some refactoring to BorderDesignable...

          1 Error

:no_entry_sign:
Any changes to library code need a summary in the Changelog.

          1 Warning

:warning:
Consider adding supporting documentation to this change. Documentation can be found in the docs directory.

  Generated by :no_entry_sign: danger

          1 Warning

:warning:
Big PR

  Generated by :no_entry_sign: danger

I don't think that's a regression, but BorderDesignable with custom sides is not supporting cornerRadius?
For now, I let it as before, so cornerRadius won't work when .dash is selected or if we specify a custom sides.

@tbaranes Thanks for the PR 👍, it is very hard to make cornerRadius, mask, border and shadow all work well together. It is some limitation of UIKit's clipsToBounds. This issue is also related. I have tried to use mask for cornerRadius (currently, we only use mask for cornerRadius  with particular corner) for all the case in #377 , that would be a potential solution to support all requirements including .dash with cornerRadius and border with custom sides with cornerRadius. But I have completed it. If you have time, would you please help me have a look? I need another eyes on it.

I understand. I think that could be a nice move for a future release! I will definitely take a look next week, if I forgot to do it, just ping me 😬

thanks @tbaranes I have updated the link for the related issue https://github.com/IBAnimatable/IBAnimatable/commit/c882a74ea836333c294db214f3263981500c1685#commitcomment-20448367


Network backend for runtime configuration

Currently Envoy reads all runtime config info from the filesystem. Changes to runtime need to be done on a separate copy of the filesystem tree, followed by a symlink swap.
For certain deployment scenarios, it might be easier and flexible to pull runtime info from a REST/gRPC backend similar to the SDS API.
If one were to add a network backend to the runtime, in addition to a file system backend, how should the APIs look like?

This relates to #298 . Lots of runtime configuration are provided as part of RDS api. Granted that there are also a lot of other runtime settings that are not in RDS. But I just wanted to bring up the RDS overlap.

Closing for now. With RDS, CDS, and SDS, adding another network work backend for runtime seems to overcomplicate the system. Its far easier to live with a file-system based backend, as it makes it easier to reason about the state of the Envoy process.


build.gradle broken for stand alone distributions

When I download a .zip from github I get a stand-alone src distribution of the master branch (without any git data include).
Unfortunately, trying to compile Xenon then fails:
./gradlew tasks
FAILURE: Build failed with an exception.

* Where:
Build file '/home/jason/TMP/Xenon-master/build.gradle' line: 22

* What went wrong:
An exception occurred applying plugin request [id: 'org.ajoberstar.grgit', version: '1.3.2']
> Failed to apply plugin [id 'org.ajoberstar.grgit']
   > One of setGitDir or setWorkTree must be called.

This is caused by the plugin on line 22 of the gradle build:
id 'org.ajoberstar.grgit' version '1.3.2'

which only seems to work when the source is in an actual git source tree ?
This seems to be a Groovy plugin ? Anyone know where it is used ?

The org.ajoberstar.grgit plugin seems to be needed for the gradle/release.gradle file that is included.

GitHub pages can now also be hosted from the docs/ directory of the master branch instead of from the gh-pages branch.
I would suggest to move the Xenon website to docs/ dir and update gradle/release.gradle to perform a simple copy from build.

Fixed in latest master


using array index properties, e.g. YAML arrays (at least with a singl…

…e element), causes the existing array value to be modified; guard the static array from accidental modification

This also keeps the config server from appending the default locations.


Element found using by.cssContainingText doesn't contain that text

I've encountered a problem in Chrome, Firefox and IE where some percentage of the time (maybe 10% for Chrome and FF, maybe 50% for IE) my tests fail because a selector using cssContainingText found an element, and then that element didn't contain the text.
Side-note: I'm very much a Protractor newbie, as my code will probably indicate, so I welcome messages that don't solve my problem but do give useful suggestions for improving my work. I wonder if the problem here is just that I don't understand how to make all this asynchronous stuff work in Protractor. It would be easier if I could make incorrectly-written tests fail consistently, as opposed to rarely; any tips for that would be greatly appreciated. I've tried telling my server to respond to requests really slowly, but that doesn't seem to help.
Example 1 (fails about half the time in IE):
browser.get('/view_email?id=1');
var mystr = 'spooogleyoogley';
var email_body = element(by.cssContainingText('div', mystr));
expect(email_body.getText()).toContain(mystr);

The failure message is your basic "expected ACTUAL_STRING to contain DESIRED_STRING", where ACTUAL_STRING contains several thousand characters of email, with the following at the end:
Thanks.spooogleyoogle
[note the missing 'y' at the end.]
The page in question is Angular. When a user loads the page /view_email?id=1, an $http request is issued to find the subject/body/etc. of email 1 -- the body of which ends with "Thanks.spooogleyoogley". The body is put into a div via ng-bind-html, and nothing further happens on the page. When Protractor loads the page, the same thing happens (I have a dummy DB that's reset between test cases to take and respond to requests).
I could imagine that I'm failing to wait for the right condition, except how the heck did protractor even decide which div email_body referred to if it didn't have mystr in it?
Example 2 (fails maybe 10% of the time in Chrome/Firefox)
In this test the browser loads page A, clicks a button to open modal B, and does some more clicking. Extra details: the link in A doesn't exist until an http request is issued and comes back; same with the stuff in B that's going to get clicked on. Since there's a pause between page loads and the things I want to click being clickable, it's possible we don't make it to the modal; but I don't think that affects the problem I'll describe below.
Inside the modal, there are are several boxes containing text that looks like this:
Black
Selected: 20 / 30

White
Selected: 5 / 10

I'm trying to test that the total number of selected items is 25. To get the total number of selected items in the test, I'm using the following code fragment:
var total_selected = item_selection.all(by.cssContainingText('td', 'Selected:')).
    map(function(elem) {
        return elem.getText().then(function(text) {
            var match_regexp = /Selected: *(\d+) *\//;
            return parseInt(text.match(match_regexp)[1]);
        });
    }).then(function(arr) {
        return arr.reduce(function(acc, num){return acc + num});
    });

The failure message is Cannot read property '1' of null, which means the text doesn't match the pattern I expected it to match. When I throw in console.log(text), or expect(text).toBe('asdf'), so I can see what the text is, I just get the empty string.
Again I'm baffled: why was this returned by the selector if the text it contained was the empty string? Unlike in example 1 (which I've never seen fail in Chrome or Firefox), the text field could get mutated after the match happens, but it would get changed from Selected: 10 / 10 to Selected: 5 / 10, which still matches.
I'm sorry to be submitting this using the "issue tracker", since this is almost certainly an issue with my code and understanding rather than an issue with Protractor, but I couldn't find anything else that looked like a support forum, so here we are. Please redirect me if appropriate.
Thanks.spooogleyoogle

This is strange.  If you put in a browser.pause() and look at the page what does the text look like?

I couldn't get browser.pause() to work, so I added taking a screenshot in afterEach per #114. The results are confusing: for Example 1, IE shows a webpage from earlier in the test instead of the show_email page; but I strongly suspect the show_email page is loaded because the expect failure has most of the contents of the email! For Example 2, Chrome won't screenshot, but Firefox shows page A. That suggests the modal didn't open, but I'm not inclined to trust it given what happened with Example 1.
Some followups:
(1) How can I get browser.pause() to work? It's never once worked for me. Do I need to invoke protractor in some special way? Here's the modification I made to my code from above, which did nothing:
     return elem.getText().then(function(text) {
         var match_regexp = /Selected: *(\d+) *\//;
         if (text.match(match_regexp) === null) {
             browser.pause();
         }
         return parseInt(text.match(match_regexp)[1]);
     });

(2) Even if the screenshot is right and the modal isn't opening, there shouldn't be anything that says "Selected:", so there's still something about this that doesn't make sense. We should still find out for sure whether it is.
(3) Note that taking screenshots always fails in Chrome for the reasons outlined in chromedriver#1083, which is frustrating, but at least it works in Firefox and IE (well, it produces a screenshot; it's unclear to me whether it's the right screenshot).
(4) What's the correct way to load a page, wait for it to make an http request to populate its data, and click on a button that exists after the http request is done? Here's what I've done:
beforeEach(function() {
    utils.resetDb();
    browser.get('/#/team/1');
});
it('should open a modal for team 1 and then select all small shirts', function() {
    $('#team_table').body.element(by.cssContainingText('button', 'View shirts')).click();
    // ... more stuff
});

Is that supposed to work, or should I have waits and thens scattered about? It seems to work either all or almost all of the time; and even when I tell the server to delay 2 seconds before sending a response, so the 'View shirts' button doesn't exist for a while, it still seems to work.

I've added lots of screenshots and some logging into my code. What I've learned so far:

If I write my code as follows for Example 1:

var email_body = element(by.cssContainingText('div', mystr));
utils.takeAndSaveScreenshot('email_body-rendered');  // that string just goes in the filename
expect(email_body.getText()).toContain(mystr);

...then I get a nice picture of an email ending with mystr, right after the div was found because it contained mystr, and before the expectation fails saying that the div doesn't contain mystr.
2. I can't seem to convince Firefox to fail any tests, but Chrome is very happy to fail Example 2. I've added the following logging to the code:
return elem.getText().then(function(text) {
         var match_regexp = /Selected: *(\d+) *\//;
         if (text.match(match_regexp) === null) {
             console.log('null found');
         }
         return parseInt(text.match(match_regexp)[1]);
     });

...and it outputs null found 5 times. I tried adding a screenshot, but I can't get a screenshot out of Chrome. It happens that 5 is how many times the string Selected: appears in the modal, which strongly suggests that the modal is in fact being opened. Will add further information about screenshots and logging to this page if I can get any more information out of them.

Another followup:
Example 1 is still, bafflingly, failing.
Example 2 I've managed to "fix" -- I still don't understand why it was giving the error it was giving, but the test is now passing, so I guess I care less. I made a few "wait" functions for myself and started using them religiously. I'll repost them here so others can use them and improve them.
function waitForElement(el, timeout) {
    return browser.wait(protractor.until.elementIsVisible(el), timeout);
}

function waitForClickable(el, pseudo_timeout) {
    waitForElement(el, pseudo_timeout);
    browser.wait(protractor.until.elementIsEnabled(el), pseudo_timeout);
}

function clickWhenClickable(el, pseudo_timeout) {
    waitForClickable(el, pseudo_timeout);
    return el.click();
}

As everyone who took one look at this thread and passed it by probably suspected, this was a PEBCAK error that is possibly too embarrassing to explain. I'll leave this thread with this code, which I think is potentially useful for other people who need to wait for things to happen on their pages, but should be taken with a grain of salt given the degree to which I'm still learning this framework.
function waitForElement(el, timeout_ms) {
    return browser.wait(protractor.ExpectedConditions.presenceOf(el), timeout_ms);
};

function waitForNoElement(el, timeout_ms) {
    return browser.wait(protractor.ExpectedConditions.not(protractor.ExpectedConditions.presenceOf(el)), timeout_ms);
};

function waitForClickable(el, timeout_ms) {
    waitForElement(el, timeout_ms);
    browser.wait(protractor.until.elementIsVisible(el), timeout_ms);
    return browser.wait(protractor.until.elementIsEnabled(el), timeout_ms);
};

function clickWhenClickable(el, timeout_ms) {
    waitForClickable(el, timeout_ms);
    return el.click();
};

// Works for non-Angular pages, such as login pages.
function clickLocatorWhenClickable(locator, timeout_ms) {
    browser.wait(protractor.until.elementLocated(locator), timeout_ms);
    var el = browser.driver.findElement(locator);
    browser.wait(protractor.until.elementIsVisible(el), timeout_ms);
    browser.wait(protractor.until.elementIsEnabled(el), timeout_ms);
    return el.click();
};


Digest stored entropy for CRNG test.

Digest stored entropy for CRNG test.
Via the FIPS lab, NIST confirmed:

The CMVP had a chance to discuss this inquiry and we agree that hashing the NDRNG block does meet the spirit and letter of AS09.42.

However, the CMVP did have a few questions: what hash algorithm would be used in this application? Is it approved? Is it CAVs tested?

SHA256 is being used here and it will be both approved and CAVs tested.
This means that no raw entropy needs to be kept between RNG seedings, preventing
a potential attack vector aganst the randomness source and the DRBG chains.
It also means the block of secure memory allocated for this purpose is no longer
required.
Based over #8789.

[x] tests are added or updated

Nice work, esp since "secure heap" memory isn't needed any more.

The secure memory a (useful) fringe benefit.  The big improvement is not storing the raw entropy in the clear.

Review anyone?

I can take a look on Sunday if nobody else has the time for it.

@mspncp please?

@mspncp please?

Sorry for the delay. I started reviewing yesterday evening, but since I had not been able to follow #8599 in depth, I ended up having some general questions about the CRNG test and reading [NIST.IR.8019]( file:///C:/Users/msp/Documents/OpenSSL/NIST.IR.8019.pdf) until late in the morning. But you will get your review today.

The CRNG test isn't ideal, it seems to be designed for hardware sources rather than software ones.  Hardware sources have different failure modes and throwing away the first sample is very cheap.
Still, the standard mandates this test.

Merged, thanks for the feedback.


colab sample iris seems broken.

See https://github.com/tensorflow/swift-tutorials/issues/9.

Hi Richard,
it would probably be ideal to proactively trap the errors spat out from google colab / swift for tensorflow - that way you could identify common errors / misuse and fire fight en masse.
and / or maybe when this / swift for tensorflow error is thrown - give option for users to click threw to a system status page - with known issue -  until things stabilize.  something to think about.


Consider replacing react for something lighter

In an effort to trim some fat on the front-end I evaluated and removed as many dependencies from my cljs as I could. I noticed through this process that react is fairly large and began searching for other options. Of the wide variety of reactive JS appearing lately inferno seems like one of the most promising. It appears to be lighter and faster than react. https://github.com/trueadm/inferno
I was curious how feasible it would be to transition from react + reagent to inferno. I think the biggest challenges would be writing a layer to translate hiccup into inferno, and replacing the ratom. The first item should not be too difficult as inferno's components look similar to react's. The second issue may require more time.
I could see this being done in one of two ways. 1 re-frame brings necessary functionality into its core. This would break backwards compatibility and not be beneficial for all users. 2 re-frame could offer the choice of reagent or another similar library written around inferno. Depending on the time commitment involved I may be willing to work on the inferno cljs abstraction provided there is any interest in this initiative.

A few comments:

I'm all for React alternatives.  React was a 1st attempt in a novel new direction and, historically, that means fast following alternatives will probably be better because they get to learn from React's mistakes. We've all seen that technical pattern play out before. But, having said that, Facebook has put rather a massive amount of effort into React, and given it a very clear future, so it is a very safe option right now. Any new alternative would want to be pretty damn good, to justify the move away from "safety".

If you do want to use an alternative, then I'd be interested to know why inferno is better than, say,  snabbdom or some of the other strong contenders. Although I can see that inferno is closer in API to React, which might be a consideration.

This isn't really a re-frame issue - this is more of a Reagent issue.  Reagent is a layer over React, and re-frame is a layer over Reagent.  So swapping in an alternative to React will involve a new version of Reagent but there is every chance re-frame will be untouched.  From your comments, you do appear to get this,  but I thought it worth stressing.

As a next step,  I'd fork Reagent and come up with a version which used your favorite virtual DOM library.  And I wouldn't worry too much about keeping the same API as React, to quote Emerson ...

When you strike at a king, you must kill him

I agree with all the above points. I'd also like to mention that any alternative, despite being "better" (however you qualify that; faster, fewer bytes, simpler api) must also contend with the huge offering of react-native. A very large amount of work has been poured into that project, and it introduces a whole new paradigm for multi-platform development. Addons and extensions keep cropping up, too: just last week react native for osx was opened up.
This might very well be another case of first-to-market / widest-adopted takes the cake.

I think for re-frame, the most crucial bits are the r/atom and the r/reaction bits which come from reagent and not from React strictly speaking.
I maybe wrong.

I'm going close this due (1) reservations about the concept  (2) a lack of apparent recent progress. But I'm always open to the new, so it can be reopened if there is compelling new information.


add teams templates documentation

Docs Build status updates of commit f98193b:
:clock10: Pending: waiting for processors (6 builds ahead of you)
:warning: Docs Build is busy, currently there are 6 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit f98193b:
:clock10: Pending: waiting for processors (6 builds ahead of you)
:warning: Docs Build is busy, currently there are 6 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit f98193b:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

teams/teams-ps/teams/Get-CsTeamTemplateList.md
:x:Error

Details

teams/teams-ps/teams/Get-Team.yml
:warning:Warning

Details

teams/teams-ps/teams/index.yml
:warning:Warning

Details

teams/teams-ps/teams/Grant-CsTeamsShiftsPolicy.yml
:warning:Warning

Details

teams/teams-ps/teams/Get-CsGroupPolicyAssignment.yml
:warning:Warning

Details

teams/teams-ps/teams/Get-CsTeamsShiftsPolicy.yml
:warning:Warning

Details

teams/teams-ps/teams/New-CsTeamsShiftsPolicy.yml
:warning:Warning

Details

teams/teams-ps/teams/Get-CsTeamTemplateList.md

Line 0, Column 0: [Error-MAML2Yaml_LoadFileFailed]

Failed to load file: W:/ihal-s/teams/teams-ps/teams/Get-CsTeamTemplateList.md:41:(230) '```powershell
OdataId                            ...'
 Expect Heading, please try to use PlatyPS validate the content

teams/teams-ps/teams/Get-Team.yml

Line 14, Column 9: [Warning-file-not-found] Invalid file link: 'new-team.yml'.
Line 16, Column 9: [Warning-file-not-found] Invalid file link: 'set-team.yml'.

teams/teams-ps/teams/index.yml

Line 15, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Get-CsTeamTemplateList'.
Line 24, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Get-TeamMemberSettings'.
Line 35, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.New-CsGroupPolicyAssignment'.
Line 37, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.New-CsTeamTemplate'.
Line 38, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.New-Team'.
Line 39, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.New-TeamChannel'.
Line 40, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.New-TeamsApp'.
Line 41, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Remove-CsCustomPolicyPackage'.
Line 42, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Remove-CsGroupPolicyAssignment'.
Line 43, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Remove-CsTeamsShiftsPolicy'.
Line 44, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Remove-CsTeamTemplate'.
Line 45, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Remove-Team'.
Line 46, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Remove-TeamChannel'.
Line 47, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Remove-TeamChannelUser'.
Line 48, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Remove-TeamsApp'.
Line 49, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Remove-TeamsAppInstallation'.
Line 50, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Remove-TeamUser'.
Line 51, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Set-CsGroupPolicyAssignment'.
Line 52, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Set-CsTeamsShiftsPolicy'.
Line 53, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Set-Team'.
Line 54, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Set-TeamArchivedState'.
Line 55, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Set-TeamChannel'.
Line 56, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Set-TeamFunSettings'.
Line 57, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Set-TeamGuestSettings'.
Line 58, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Set-TeamMemberSettings'.
Line 59, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Set-TeamMessagingSettings'.
Line 60, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Set-TeamPicture'.
Line 61, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Set-TeamsApp'.
Line 62, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Update-CsCustomPolicyPackage'.
Line 63, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Update-CsTeamTemplate'.
Line 64, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Update-TeamsAppInstallation'.

teams/teams-ps/teams/Grant-CsTeamsShiftsPolicy.yml

Line 18, Column 9: [Warning-file-not-found] Invalid file link: 'Set-CsTeamsShiftsPolicy.yml'.
Line 20, Column 9: [Warning-file-not-found] Invalid file link: 'Remove-CsTeamsShiftsPolicy.yml'.

teams/teams-ps/teams/Get-CsGroupPolicyAssignment.yml

Line 8, Column 9: [Warning-file-not-found] Invalid file link: 'New-CsGroupPolicyAssignment.yml'.
Line 10, Column 9: [Warning-file-not-found] Invalid file link: 'Set-CsGroupPolicyAssignment.yml'.
Line 12, Column 9: [Warning-file-not-found] Invalid file link: 'Remove-CsGroupPolicyAssignment.yml'.

teams/teams-ps/teams/Get-CsTeamsShiftsPolicy.yml

Line 14, Column 9: [Warning-file-not-found] Invalid file link: 'Set-CsTeamsShiftsPolicy.yml'.
Line 18, Column 9: [Warning-file-not-found] Invalid file link: 'Remove-CsTeamsShiftsPolicy.yml'.

teams/teams-ps/teams/New-CsTeamsShiftsPolicy.yml

Line 18, Column 9: [Warning-file-not-found] Invalid file link: 'Remove-CsTeamsShiftsPolicy.yml'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit f98193b:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

teams/teams-ps/teams/Get-CsTeamTemplateList.md
:x:Error

Details

teams/teams-ps/teams/Get-Team.yml
:warning:Warning

Details

teams/teams-ps/teams/index.yml
:warning:Warning

Details

teams/teams-ps/teams/Grant-CsTeamsShiftsPolicy.yml
:warning:Warning

Details

teams/teams-ps/teams/Get-CsGroupPolicyAssignment.yml
:warning:Warning

Details

teams/teams-ps/teams/Get-CsTeamsShiftsPolicy.yml
:warning:Warning

Details

teams/teams-ps/teams/New-CsTeamsShiftsPolicy.yml
:warning:Warning

Details

teams/teams-ps/teams/Get-CsTeamTemplateList.md

Line 0, Column 0: [Error-MAML2Yaml_LoadFileFailed]

Failed to load file: W:/ihal-s/teams/teams-ps/teams/Get-CsTeamTemplateList.md:41:(230) '```powershell
OdataId                            ...'
 Expect Heading, please try to use PlatyPS validate the content

teams/teams-ps/teams/Get-Team.yml

Line 14, Column 9: [Warning-file-not-found] Invalid file link: 'new-team.yml'.
Line 16, Column 9: [Warning-file-not-found] Invalid file link: 'set-team.yml'.

teams/teams-ps/teams/index.yml

Line 15, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Get-CsTeamTemplateList'.
Line 24, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Get-TeamMemberSettings'.
Line 35, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.New-CsGroupPolicyAssignment'.
Line 37, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.New-CsTeamTemplate'.
Line 38, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.New-Team'.
Line 39, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.New-TeamChannel'.
Line 40, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.New-TeamsApp'.
Line 41, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Remove-CsCustomPolicyPackage'.
Line 42, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Remove-CsGroupPolicyAssignment'.
Line 43, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Remove-CsTeamsShiftsPolicy'.
Line 44, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Remove-CsTeamTemplate'.
Line 45, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Remove-Team'.
Line 46, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Remove-TeamChannel'.
Line 47, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Remove-TeamChannelUser'.
Line 48, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Remove-TeamsApp'.
Line 49, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Remove-TeamsAppInstallation'.
Line 50, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Remove-TeamUser'.
Line 51, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Set-CsGroupPolicyAssignment'.
Line 52, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Set-CsTeamsShiftsPolicy'.
Line 53, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Set-Team'.
Line 54, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Set-TeamArchivedState'.
Line 55, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Set-TeamChannel'.
Line 56, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Set-TeamFunSettings'.
Line 57, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Set-TeamGuestSettings'.
Line 58, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Set-TeamMemberSettings'.
Line 59, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Set-TeamMessagingSettings'.
Line 60, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Set-TeamPicture'.
Line 61, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Set-TeamsApp'.
Line 62, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Update-CsCustomPolicyPackage'.
Line 63, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Update-CsTeamTemplate'.
Line 64, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Update-TeamsAppInstallation'.

teams/teams-ps/teams/Grant-CsTeamsShiftsPolicy.yml

Line 18, Column 9: [Warning-file-not-found] Invalid file link: 'Set-CsTeamsShiftsPolicy.yml'.
Line 20, Column 9: [Warning-file-not-found] Invalid file link: 'Remove-CsTeamsShiftsPolicy.yml'.

teams/teams-ps/teams/Get-CsGroupPolicyAssignment.yml

Line 8, Column 9: [Warning-file-not-found] Invalid file link: 'New-CsGroupPolicyAssignment.yml'.
Line 10, Column 9: [Warning-file-not-found] Invalid file link: 'Set-CsGroupPolicyAssignment.yml'.
Line 12, Column 9: [Warning-file-not-found] Invalid file link: 'Remove-CsGroupPolicyAssignment.yml'.

teams/teams-ps/teams/Get-CsTeamsShiftsPolicy.yml

Line 14, Column 9: [Warning-file-not-found] Invalid file link: 'Set-CsTeamsShiftsPolicy.yml'.
Line 18, Column 9: [Warning-file-not-found] Invalid file link: 'Remove-CsTeamsShiftsPolicy.yml'.

teams/teams-ps/teams/New-CsTeamsShiftsPolicy.yml

Line 18, Column 9: [Warning-file-not-found] Invalid file link: 'Remove-CsTeamsShiftsPolicy.yml'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 61cd694:
:clock10: Pending: waiting for processors (6 builds ahead of you)
:warning: Docs Build is busy, currently there are 6 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 61cd694:
:clock10: Pending: waiting for processors (6 builds ahead of you)
:warning: Docs Build is busy, currently there are 6 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 61cd694:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

teams/teams-ps/teams/New-CsTeamTemplate.md
:x:Error

Details

teams/teams-ps/teams/Update-CsTeamTemplate.md
:x:Error

Details

teams/teams-ps/teams/index.yml
:warning:Warning

Details

teams/teams-ps/teams/New-CsTeamTemplate.md

Line 0, Column 0: [Error-MAML2Yaml_LoadFileFailed]

Failed to load file: W:/m2c3-s/teams/teams-ps/teams/New-CsTeamTemplate.md:66:(116) '```json
{
  "id": "061fe692-7da7-4f65-a57b-0472c...'
 Expect Heading, please try to use PlatyPS validate the content

teams/teams-ps/teams/Update-CsTeamTemplate.md

Line 0, Column 0: [Error-MAML2Yaml_LoadFileFailed]

Failed to load file: W:/m2c3-s/teams/teams-ps/teams/Update-CsTeamTemplate.md:63:(101) '```powershell
Update-CsTeamTemplate -OdataId '/ap...'
 Expect Heading, please try to use PlatyPS validate the content

teams/teams-ps/teams/index.yml

Line 37, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.New-CsTeamTemplate'.
Line 63, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Update-CsTeamTemplate'.
Line 64, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Update-TeamsAppInstallation'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 61cd694:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

teams/teams-ps/teams/New-CsTeamTemplate.md
:x:Error

Details

teams/teams-ps/teams/Update-CsTeamTemplate.md
:x:Error

Details

teams/teams-ps/teams/index.yml
:warning:Warning

Details

teams/teams-ps/teams/New-CsTeamTemplate.md

Line 0, Column 0: [Error-MAML2Yaml_LoadFileFailed]

Failed to load file: W:/m2c3-s/teams/teams-ps/teams/New-CsTeamTemplate.md:66:(116) '```json
{
  "id": "061fe692-7da7-4f65-a57b-0472c...'
 Expect Heading, please try to use PlatyPS validate the content

teams/teams-ps/teams/Update-CsTeamTemplate.md

Line 0, Column 0: [Error-MAML2Yaml_LoadFileFailed]

Failed to load file: W:/m2c3-s/teams/teams-ps/teams/Update-CsTeamTemplate.md:63:(101) '```powershell
Update-CsTeamTemplate -OdataId '/ap...'
 Expect Heading, please try to use PlatyPS validate the content

teams/teams-ps/teams/index.yml

Line 37, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.New-CsTeamTemplate'.
Line 63, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Update-CsTeamTemplate'.
Line 64, Column 5: [Warning-xref-not-found] Cross reference not found: 'MicrosoftTeamsPowerShell.Update-TeamsAppInstallation'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit b3318b1:
:clock10: Pending: waiting for processors (6 builds ahead of you)
:warning: Docs Build is busy, currently there are 6 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit b3318b1:
:clock10: Pending: waiting for processors (6 builds ahead of you)
:warning: Docs Build is busy, currently there are 6 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit b3318b1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

teams/teams-ps/teams/Get-CsTeamTemplate.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Get-CsTeamTemplateList.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/New-CsTeamTemplate.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Remove-CsTeamTemplate.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Update-CsTeamTemplate.md
:white_check_mark:Succeeded
View (teams-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit b3318b1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

teams/teams-ps/teams/Get-CsTeamTemplate.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Get-CsTeamTemplateList.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/New-CsTeamTemplate.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Remove-CsTeamTemplate.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Update-CsTeamTemplate.md
:white_check_mark:Succeeded
View (teams-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit d2cad09:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

teams/teams-ps/teams/Get-CsTeamTemplate.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Get-CsTeamTemplateList.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/New-CsTeamTemplate.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Remove-CsTeamTemplate.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Update-CsTeamTemplate.md
:white_check_mark:Succeeded
View (teams-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit d2cad09:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

teams/teams-ps/teams/Get-CsTeamTemplate.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Get-CsTeamTemplateList.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/New-CsTeamTemplate.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Remove-CsTeamTemplate.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Update-CsTeamTemplate.md
:white_check_mark:Succeeded
View (teams-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Hello @levdavid Lev, thanks for the contribution.
I am having trouble finding these cmdlets both in the GA and Preview versions of the module. Are they coming on a future version?
If these cmdlets are the result of importing Skype cmdlets using New-CsOnlineSession (after the Connect-MicrosoftTeams), they should be on https://github.com/MicrosoftDocs/office-docs-powershell/tree/master/skype/skype-ps/skype
Can you kindly confirm? Thank you!

Hello @levdavid Lev, thanks for the contribution.
I am having trouble finding these cmdlets both in the GA and Preview versions of the module. Are they coming on a future version?
If these cmdlets are the result of importing Skype cmdlets using New-CsOnlineSession (after the Connect-MicrosoftTeams), they should be on https://github.com/MicrosoftDocs/office-docs-powershell/tree/master/skype/skype-ps/skype
Can you kindly confirm? Thank you!

Hi Andreas!
We are about to add these cmdlets as preview. The are a part of the new SBS
ConfigAPI repository but will be released within Teams module. Is this the
right place?
On Tue, Jan 19, 2021 at 4:30 AM Andres Mariano Gorzelany <
<EMAIL_ADDRESS>wrote:

Hello @levdavid https://github.com/levdavid Lev, thanks for the
contribution.
I am having trouble finding these cmdlets both in the GA and Preview
versions of the module. Are they coming on a future version?
If these cmdlets are the result of importing Skype cmdlets using
New-CsOnlineSession (after the Connect-MicrosoftTeams), they should be on
https://github.com/MicrosoftDocs/office-docs-powershell/tree/master/skype/skype-ps/skype
Can you kindly confirm? Thank you!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/office-docs-powershell/pull/7043#issuecomment-762811277,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB63EH276LSFGJMYYSB65ZTS2V3PNANCNFSM4VZZCGUA
.

--
Best regards,
Lev

Hi Andreas!
We are about to add these cmdlets as preview. The are a part of the new SBS
ConfigAPI repository but will be released within Teams module. Is this the
right place?
On Tue, Jan 19, 2021 at 4:30 AM Andres Mariano Gorzelany <
<EMAIL_ADDRESS>wrote:

Hello @levdavid https://github.com/levdavid Lev, thanks for the
contribution.
I am having trouble finding these cmdlets both in the GA and Preview
versions of the module. Are they coming on a future version?
If these cmdlets are the result of importing Skype cmdlets using
New-CsOnlineSession (after the Connect-MicrosoftTeams), they should be on
https://github.com/MicrosoftDocs/office-docs-powershell/tree/master/skype/skype-ps/skype
Can you kindly confirm? Thank you!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/office-docs-powershell/pull/7043#issuecomment-762811277,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB63EH276LSFGJMYYSB65ZTS2V3PNANCNFSM4VZZCGUA
.

--
Best regards,
Lev

@levdavid for your PoSh examples, can you make sure to include "PS C:> " (note the space) in front of your cmdlets as well as remove the cmdlet output? Could you also supply an example that uses a complex input object? Many administrators aren't familiar with how to construct hash tables, etc.

@levdavid for your PoSh examples, can you make sure to include "PS C:> " (note the space) in front of your cmdlets as well as remove the cmdlet output? Could you also supply an example that uses a complex input object? Many administrators aren't familiar with how to construct hash tables, etc.

Hi Andreas! We are about to add these cmdlets as preview. The are a part of the new SBS ConfigAPI repository but will be released within Teams module. Is this the right place?

If they will be listed when you run get-command -module MicrosoftTeams this is the right place.
So they will be available in something like 1.1.11-preview ?
Thanks

Hi Andreas! We are about to add these cmdlets as preview. The are a part of the new SBS ConfigAPI repository but will be released within Teams module. Is this the right place?

If they will be listed when you run get-command -module MicrosoftTeams this is the right place.
So they will be available in something like 1.1.11-preview ?
Thanks

That’s my understanding, yes. Since it shouldn’t take long to propagate
document updates, let me update the PR once we release the module
On Tue, Jan 19, 2021 at 9:10 AM Andres Mariano Gorzelany <
<EMAIL_ADDRESS>wrote:

Hi Andreas! We are about to add these cmdlets as preview. The are a part
of the new SBS ConfigAPI repository but will be released within Teams
module. Is this the right place?
If they will be listed when you run get-command -module MicrosoftTeams
this is the right place.
So they will be available in something like 1.1.11-preview ?
Thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/office-docs-powershell/pull/7043#issuecomment-762985535,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB63EH2L4724ON3CI3WVPY3S2W4ENANCNFSM4VZZCGUA
.

--
Best regards,
Lev

That’s my understanding, yes. Since it shouldn’t take long to propagate
document updates, let me update the PR once we release the module
On Tue, Jan 19, 2021 at 9:10 AM Andres Mariano Gorzelany <
<EMAIL_ADDRESS>wrote:

Hi Andreas! We are about to add these cmdlets as preview. The are a part
of the new SBS ConfigAPI repository but will be released within Teams
module. Is this the right place?
If they will be listed when you run get-command -module MicrosoftTeams
this is the right place.
So they will be available in something like 1.1.11-preview ?
Thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/office-docs-powershell/pull/7043#issuecomment-762985535,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB63EH2L4724ON3CI3WVPY3S2W4ENANCNFSM4VZZCGUA
.

--
Best regards,
Lev

That’s my understanding, yes. Since it shouldn’t take long to propagate document updates, let me update the PR once we release the module

Hello @levdavid Lev, how are you? Do you have an estimated ETA? Also, if you have a Microsoft alias, you can link your accounts in GitHub so that a blue "Microsoft submitter" label appears to any PR's or issue you submit. Guidance on it here: https://docs.opensource.microsoft.com/tools/github/index.html
Here is the site you can use to see the mappings between GitHub and Microsoft aliases: https://repos.opensource.microsoft.com/people?q=levdavid
Thank you

That’s my understanding, yes. Since it shouldn’t take long to propagate document updates, let me update the PR once we release the module

Hello @levdavid Lev, how are you? Do you have an estimated ETA? Also, if you have a Microsoft alias, you can link your accounts in GitHub so that a blue "Microsoft submitter" label appears to any PR's or issue you submit. Guidance on it here: https://docs.opensource.microsoft.com/tools/github/index.html
Here is the site you can use to see the mappings between GitHub and Microsoft aliases: https://repos.opensource.microsoft.com/people?q=levdavid
Thank you

Hello,
We have just merged the cmdlets for the preview, so expecting a release in
the next few days.
On Fri, Jan 29, 2021 at 7:12 AM Andres Mariano Gorzelany <
<EMAIL_ADDRESS>wrote:

That’s my understanding, yes. Since it shouldn’t take long to propagate
document updates, let me update the PR once we release the module
Hello @levdavid https://github.com/levdavid Lev, how are you? Do you
have an estimated ETA? Also, if you have a Microsoft alias, you can link
your accounts in GitHub so that a blue "Microsoft submitter" label appears
to any PR's or issue you submit. Guidance on it here:
https://docs.opensource.microsoft.com/tools/github/index.html
Here is the site you can use to see the mappings between GitHub and
Microsoft aliases:
https://repos.opensource.microsoft.com/people?q=levdavid
Thank you
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/office-docs-powershell/pull/7043#issuecomment-769862964,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB63EH5XYHOBFHOH5LEDQK3S4LF43ANCNFSM4VZZCGUA
.

--
Best regards,
Lev

Hello,
We have just merged the cmdlets for the preview, so expecting a release in
the next few days.
On Fri, Jan 29, 2021 at 7:12 AM Andres Mariano Gorzelany <
<EMAIL_ADDRESS>wrote:

That’s my understanding, yes. Since it shouldn’t take long to propagate
document updates, let me update the PR once we release the module
Hello @levdavid https://github.com/levdavid Lev, how are you? Do you
have an estimated ETA? Also, if you have a Microsoft alias, you can link
your accounts in GitHub so that a blue "Microsoft submitter" label appears
to any PR's or issue you submit. Guidance on it here:
https://docs.opensource.microsoft.com/tools/github/index.html
Here is the site you can use to see the mappings between GitHub and
Microsoft aliases:
https://repos.opensource.microsoft.com/people?q=levdavid
Thank you
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/office-docs-powershell/pull/7043#issuecomment-769862964,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB63EH5XYHOBFHOH5LEDQK3S4LF43ANCNFSM4VZZCGUA
.

--
Best regards,
Lev

Hello, We have just merged the cmdlets for the preview, so expecting a release in the next few days.

Ok, thanks!

Hello, We have just merged the cmdlets for the preview, so expecting a release in the next few days.

Ok, thanks!

Docs Build status updates of commit 081260d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

teams/teams-ps/teams/Get-CsTeamTemplate.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Get-CsTeamTemplateList.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/New-CsTeamTemplate.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Remove-CsTeamTemplate.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Update-CsTeamTemplate.md
:white_check_mark:Succeeded
View (teams-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 5382836:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

teams/teams-ps/teams/Get-CsTeamTemplate.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Get-CsTeamTemplateList.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/New-CsTeamTemplate.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Remove-CsTeamTemplate.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Update-CsTeamTemplate.md
:white_check_mark:Succeeded
View (teams-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 15edb67:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

teams/teams-ps/teams/Get-CsTeamTemplate.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Get-CsTeamTemplateList.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/New-CsTeamTemplate.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Remove-CsTeamTemplate.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Update-CsTeamTemplate.md
:white_check_mark:Succeeded
View (teams-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

We have just merged the updates into the teams module, should we wait for the package release to publish the documentation?

Hi @levdavid, thank you again for this PR.
Yes, I think it's a good idea to wait for the new public preview where you merged the updates. As Andres said, it should be 1.1.11-preview.
I don't know why we don't see the "Microsoft submitter" label, maybe in the new PR or issue.

@levdavid for your PoSh examples, can you make sure to include "PS C:> " (note the space) in front of your cmdlets as well as remove the cmdlet output? Could you also supply an example that uses a complex input object? Many administrators aren't familiar with how to construct hash tables, etc.

Also, the examples could be improved as @tseward recommends.

I have actually just removed them because I thought they are not relevant
to our cmdlets, but you are probably right. Let me revert...
On Mon, Feb 15, 2021 at 7:00 AM Andres Mariano Gorzelany <
<EMAIL_ADDRESS>wrote:

@get-itips commented on this pull request.
Hello @levdavid https://github.com/levdavid Lev, how are you?
I see 1.1.11-preview is out, and these cmdlets are in there as expected.
I see that there are more parameters:
[image: image]
https://user-images.githubusercontent.com/36666927/107961789-fa82ec00-6f6b-11eb-8129-2eb22ed58377.png
Can you also add them? Reason why I am asking is because then users open
issues asking them to be added...
Thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/office-docs-powershell/pull/7043#pullrequestreview-590550344,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB63EH2EJVKZ6HATJSN7G6DS7EZG7ANCNFSM4VZZCGUA
.

--
Best regards,
Lev

Docs Build status updates of commit 8cae6aa:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

teams/teams-ps/teams/Get-CsTeamTemplate.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Get-CsTeamTemplateList.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/New-CsTeamTemplate.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Remove-CsTeamTemplate.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Update-CsTeamTemplate.md
:white_check_mark:Succeeded
View (teams-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

added pwsh object-based examples to the docs.

Docs Build status updates of commit e8f9da2:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

teams/teams-ps/teams/Get-CsTeamTemplate.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Get-CsTeamTemplateList.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/New-CsTeamTemplate.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Remove-CsTeamTemplate.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Update-CsTeamTemplate.md
:white_check_mark:Succeeded
View (teams-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 1b06069:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

teams/teams-ps/teams/Get-CsTeamTemplate.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Get-CsTeamTemplateList.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/New-CsTeamTemplate.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Remove-CsTeamTemplate.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Update-CsTeamTemplate.md
:white_check_mark:Succeeded
View (teams-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Feel free to complete the publish as soon as everything looks good @tseward

@levdavid for your Related Links, can you remove the en-us within the URLs? We should be good to go after that!

Just letting you know that there are A LOT of en-us links around the repository besides dead or relative md path links.
Updating our links.

Docs Build status updates of commit e1a0e4c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

teams/teams-ps/teams/Get-CsTeamTemplate.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Get-CsTeamTemplateList.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/New-CsTeamTemplate.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Remove-CsTeamTemplate.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Update-CsTeamTemplate.md
:white_check_mark:Succeeded
View (teams-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

I don't have write access, can anyone merge it for me? Thank you!

I don't have write access, can anyone merge it for me? Thank you!

@Kateyanne  can :)

Docs Build status updates of commit fd86a6d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

teams/teams-ps/teams/Get-CsTeamTemplate.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Get-CsTeamTemplateList.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/New-CsTeamTemplate.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Remove-CsTeamTemplate.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Update-CsTeamTemplate.md
:white_check_mark:Succeeded
View (teams-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

One more question, how long does it take to propagate the changes to a live site? Thank you!

@levdavid I would give it 24 hrs to be safe, though more likely by later this afternoon.


Support in process integration

Fixes https://github.com/containerd/containerd/issues/2183.
For https://github.com/containerd/containerd/issues/2120.
This PR:

Added a new plugin ServicePlugin for internal service. We should either make this invisible to user, or support finer grained dependency declaration in a following-up PR.
Added internal service for Container, Content, Snapshot, Task, Leases, Image, Diff and Namespace. Event service comes from InitContext.Events. Version, Health and Introspection are not that useful to in-process-integration.
Basically, the original service implementation is moved to store.go or local.go as internal implementation, and service.go becomes a simple grpc wrapper.
An example of how this is used https://github.com/Random-Liu/cri-containerd/blob/22439bec2a4b268bc45a637e885f341d7d225e00/cri.go#L88:14.

The cri-containerd side PR is https://github.com/containerd/cri-containerd/pull/653.

This looks good
I still have some concerns about the service plugin type, but I think we can address that in a follow up. Mostly I am not a fan of the way the IDs are used to distinguish the service types and that the service plugins are exposed in the API. I think we can address the API concern in a follow up before the release and service types in a follow up refactor.
Ideally the services will not show up here
$ ctr plugins
TYPE                            ID                    PLATFORMS      STATUS
io.containerd.content.v1        content               -              ok
io.containerd.snapshotter.v1    btrfs                 linux/amd64    ok
io.containerd.snapshotter.v1    overlayfs             linux/amd64    ok
io.containerd.metadata.v1       bolt                  -              ok
io.containerd.differ.v1         walking               linux/amd64    ok
io.containerd.gc.v1             scheduler             -              ok
io.containerd.service.v1        containers-service    -              ok
io.containerd.service.v1        content-service       -              ok
io.containerd.service.v1        diff-service          -              ok
io.containerd.service.v1        images-service        -              ok
io.containerd.service.v1        leases-service        -              ok
io.containerd.service.v1        namespaces-service    -              ok
io.containerd.service.v1        snapshots-service     -              ok
io.containerd.monitor.v1        cgroups               linux/amd64    ok
io.containerd.runtime.v1        linux                 linux/amd64    ok
io.containerd.service.v1        tasks-service         -              ok
io.containerd.grpc.v1           containers            -              ok
io.containerd.grpc.v1           content               -              ok
io.containerd.grpc.v1           diff                  -              ok
io.containerd.grpc.v1           events                -              ok
io.containerd.grpc.v1           healthcheck           -              ok
io.containerd.grpc.v1           images                -              ok
io.containerd.grpc.v1           leases                -              ok
io.containerd.grpc.v1           namespaces            -              ok
io.containerd.grpc.v1           snapshots             -              ok
io.containerd.grpc.v1           tasks                 -              ok
io.containerd.grpc.v1           version               -              ok
io.containerd.grpc.v1           cri                   linux/amd64    ok

Codecov Report

Merging #2203 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #2203      +/-   ##
==========================================
- Coverage   41.11%   41.08%   -0.04%
==========================================
  Files          66       66
  Lines        7544     7550       +6
==========================================
  Hits         3102     3102
- Misses       3961     3967       +6
  Partials      481      481

Flag
Coverage Δ

#windows
41.08% <0%> (-0.04%)
:arrow_down:

Impacted Files
Coverage Δ

metadata/db.go
64.98% <0%> (-1.56%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edf7f41...1128b3d. Read the comment docs.

Mostly I am not a fan of the way the IDs are used to distinguish the service types

So you prefer we define each service as a different plugin type? I'm fine with that. :)

and that the service plugins are exposed in the API.

Yeah, we should hide it.
Another option is to make it possible to declare dependency by type+id, so that CRI can depend on required grpc services, and use those grpc services (either internal implementation or external grpc wrapper). In this way, we don't need another layer of service plugin.
I feel like for now, it might be fine to just hide the service plugin. And we can always switch to the other option, if we think it is a better design in the future. For now they seem very similar to me. :)

LGTM

LGTM

The other problem is that we need to uniqify the ids per plugin type and we need to figure out how to hide them. :)


make doom/blink-cursor interactive

Make doom/blink-cursor an interactive function, so that it can easily be called on demand to flash the cursor line.

Woops! My mistake. Thanks!