Self Hosted / Docker supabase/postgres:<IP_ADDRESS>_arm64 : Worker does not execute requests

[x] I confirm this is a bug with Supabase, not with my own application.
[x] I confirm I have searched the Docs, GitHub Discussions, and Discord.

Describe the bug
Docker install of supabase/postgres:<IP_ADDRESS>_arm64
pg_net installs successfully, creates net schema etc, and functions seemingly operate as expected, however requests do not execute. They do not time out either.
To Reproduce

install postgres docker image supabase/postgres:<IP_ADDRESS>_arm64
create a database
execute create extension pg_net;
Send an example query as per readme:

SELECT net.http_get (
    'https://postman-echo.com/get?foo1=bar1&foo2=bar2'
) AS request_id;

query: SELECT * FROM net.http_request_queue => responds with one row corresponding to the request
query: SELECT * FROM net._http_response => responds with no rows
SELECT net.check_worker_is_up() reports: ERROR:  the pg_net background worker is not up
manually querying SELECT * from pg_stat_activity shows a worker is running - but the backend_type from this query reports "pg_net 0.7.1 worker" - where the query in the check_worker_is_up() function expects "pg_net worker"

At this point the request stays in net.http_request_queue and never times out etc...
NB. A test hosted on supabase sends requests successfully and populates net._http_response with a response, but also shows ERROR:  the pg_net background worker is not up when check_worker_is_up() is executed.
Expected behavior
The request should execute, the row in the request table should no longer be present and a response should be in the response table.
Screenshots

System information

OS: macOS - running docker instance supabase/postgres:<IP_ADDRESS>_arm64

I looked into issue regarding the inaccurate error messages.
In September of 2022 last year, a commit was made to worker.c that incorporated the version number into the return message, i.e. the message went from "pg_net worker" to "pg_net VERSION worker". The net.check_worker_is_up function was not updated to reflect this change.
This issue can be resolved in 3 ways:

Remove the version number from the worker.c return message
Hard code the return number into the net.check_worker_is_up function
Change the comparison in the net.check_worker_is_up function to be general purpose for all new versions.

I prefer the third option because it would prevent this type of issue in the future. I took the liberty of rewriting the offending line:
Old Comparison:
... where backend_type = 'pg_net worker') ...
New Comparison:
... where backend_type ~ 'pg_net \d+(\.\d+){0,2} worker')
As for why your requests are idling, I'm not particularly sure. That's a more complex issue that is not really something I can resolve, at least not quickly. Realistically, the extension should provide information about incomplete requests, but that feature isn't as robust. I'm not sure how effective this would be, but it might be helpful to monitor network traffic in your container using a terminal tool, such as nload, to see if the extension is making any requests.
I suspect your specific issue may have to do with your Docker configuration and its permission to access the internet.

Thanks @TheOtherBrian1
I should have thought the timeout would still function in the case that network conditions/config were the issue here.
At the least, some sort of error messaging 🤔
I have configured the docker container to have internet access (as far as I can tell - i.e. I can curl things from a bash command line within the docker container)
Unsure where to turn now :/
Thanks again

@bentron2000
I spent some time looking through the extensions code, and it seems that many of the errors are written to the PostgreSQL log file. On your set up, it may be located in the var/log/postgresql directory. You should try viewing it if you haven't. If does show the cause, I would be very curious to know what it is.

@TheOtherBrian1
Thanks for looking into this. You've really pointed me in a few directions that helped me today.
It appears as though the devil is in the detail here:
In my repro instructions I put 'create a database' - this is the key issue.
pg_net is does not work (or is not configured to work) on any database other than the postgres database that is present by default in this docker image.
When I install the extension and add a request in the existing postgres database - I have no issues with pg_net - (other than the previously noted bug in check_worker_is_up())
Curiously though - there are no logs where you indicated.
Maintainers: The documentation should either:

Note that pg_net only works with the specific config present in the existing 'postgres' database (and why), or,
Give instructions on how to configure it for an arbitrary database.

@bentron2000
Wow, you are right, it is by default setup only to work on the postgres database, as coded in Line 41 in worker.c
char* database_name = "postgres";
Unfortunately, there were no hints in the documentation alluding to extension configuration. The documentation most certainly should be updated.
In the _PG_Init function in worker.c, there is the following code:
DefineCustomStringVariable(
      "pg_net.database_name",
       "database where the pg_net worker is connected",
        NULL,
        &database_name,
        "postgres",
        PGC_SIGHUP, 0,
        NULL, NULL, NULL);
}

DefineCustomStringVariable comes from the GUC.c library in PostgreSQL, which stands for Grand Unified Configuration. This code makes it possible to set the database_name variable in the postgres.conf file.
Looking further into the code, it seems that the extension creates 3 configurable variables:

pg_net.batch_size (default: 200): An integer that limits the max number of rows that the extension will process from net.http_request_queue during each read
pg_net.ttl (default: 6 hours): An interval that defines the max time a row in the _net.http_response  will live before being deleted
pg_net.database_name (default: 'postgres'): A string that defines which database the extension is applied to

All these variables can be viewed with the following command:
select      *   from pg_settings WHERE name LIKE 'pg_net%'
The postgres.conf, file can be found with the following SQL command:
SHOW config_file;
I'm not too familiar with modifying the postgres.conf, so I Google searched for some hints on how to handle it properly.
I found a supabase post called  Protecting reserved roles with PostgreSQL Hooks that included a section about modifying configuration variables for a "supautils.c" extension:
postgresql.conf
# set the extension as preloaded, this will require a restart
shared_preload_libraries="supautils"

# the reserved roles
supautils.reserved_roles="supabase_storage_admin, supabase_auth_admin"

Extrapolating from that example, my guess is that you could modify your postgresql.conf file with the following line(s) to get pg_net to work:
#The below line may be necessary
#shared_preload_libraries="pg_net"

pg_net.database_name=<"Your_new_database">

You may also be able to change the variable in SQL by using an ALTER SYSTEM query, as outlined by this stackoverflow post
After saving the file, you can execute select pg_reload_conf() to update postgres.conf for your database. If the extension does not respond to the update, it may be necessary to restart your entire server.
If this solves your issue, I'll add some configuration guidelines to the readme.md for future readers.

@TheOtherBrian1
Amazing! That certainly looks like the information required to get this working.
I made a quick attempt to use ALTER SYSTEM to modify the config but the postgres user in the image does not have sufficient permissions for this purpose.
However, adding pg_net.database_name=<"Your_new_database"> to the postgresql.conf file does work - and pg_net operates correctly once this is set.
This is the solution :) Really appreciate the time you've spent here assisting me.
To summarize:
When using pg_net with a database named other than postgres - the variable pg_net.database_name must be set to the name of the database the worker should attach to. This may be able to be done at runtime - however, is best achieved via postgresql.conf.
NB. This suggests that only one instance of pg_net can be enabled per postgres instance.
Thanks again :) B

Thanks all, and sorry for the confusion! I'm updating the README here to clarify on this.


how to build streamsets-datacollector-core ?

how to build streamsets-datacollector-core ?

Instructions are at https://github.com/streamsets/datacollector/blob/master/BUILD.md


ie tag error

the ie tag is not configured properly and fails during render.
The doctype tag is also absent

And the raw tag from teacup is also missing -- it's like the text tag, but does not escape html elements

@jahbini thanks for the heads up! I haven't seen many folks using React to bootstrap their whole page, meta tags and all, so I didn't prioritize ie and doctype tags, but I'd happily merge a PR for 'em.
The raw tag is a little trickier as React does its own escaping.  You can use React's dangerouslySetInnerHTML today.  A raw tag would likely need to make assumptions about what type of tag (div or span for example) to wrap the raw content with.  Not opposed, just haven't needed it yet.

I wanted to use React, but can't stand the bloat, so I adapted Teact to mithril and added back the original rendering scheme.
It now has ie, doctype and render, renderable and tag, too.  And renders into three different DOM schemes: React or Mithril virtual DOM and HTML text.  Server or client side.  Check out http://github.com/jahbini/halvalla


freebayes quits after only one contig

Hello,
This might be similar to issue 170.
Freebayes normally works fine (or at least as I expected), however on a different data set it quits after calling variants for only one contig, which is the first one.
This dataset was generated differently than the others, since it was Sanger fasta+qual from 2005, merged into fastq and then mapped on to the reference genome (built from the same reads) to detect haplotypes. Mapping was done just as I did the others, with bowtie2 and the same settings, only for single end rather than paired.
Is this a filtering problem? or is something else instructing the program to quit after the first contig?
This is the last read in the bam file before it stops:
gnl|ti|1479533009   0   Contig533   115 0   36M3I228M1D15M1I272M1D122M14I2M4I7M1D88M10I35M2D59M4I7M
27I8M   *   0   0   NCCTAGTAG...    !%'%')''((*%%...    AS:i:-535   XN:i:0  XM:i:71 XO:i:11 XG:i:68 NM:i:139    MD:Z:0T1A0G0G0C1G0T2T0A0A0A1G0A1A0A1G2G
1T0C0G0A1G0C72T0G8T2G58C2T9A8A1C61^A4C21C50T39G25G8C0A79G29T23^A30A3T16A5C4C6C9C3G2G1A24G1A2T12^G5A7T38T23T17T20T7^AT40
A9A1A2T4C1T4G0C0T1T1G0  YT:Z:UU
mapping onto a contig which starts like:

Contig533 dna:scaffold scaffold:Aqu1:Contig533:1:1000:1
CTTGGAATACTGGCAGAGTTAACTGGTAAATGAAACTTTAAGAATAAAGAAAGAGAAGAA...

The full dataset was ~3M reads, where 1.8M mapped onto 13k contigs.
Thanks!

Work around this by running one job per contig such as using gnu parallel
(so as to not make tens of thousands of jobs for a cluster).
If running --region for a particular contig does not produce results still,
it may be another issue.
I will be addressing these related issues in the coming week.
On Sep 24, 2015 2:58 PM, "Warren Francis"<EMAIL_ADDRESS>wrote:

Hello,
This might be similar to issue 170
https://github.com/ekg/freebayes/issues/170.
Freebayes normally works fine (or at least as I expected), however on a
different data set it quits after calling variants for only one contig,
which is the first one.
This dataset was generated differently than the others, since it was
Sanger fasta+qual from 2005, merged into fastq and then mapped on to the
reference genome (built from the same reads) to detect haplotypes. Mapping
was done just as I did the others, with bowtie2 and the same settings, only
for single end rather than paired.
Is this a filtering problem? or is something else instructing the program
to quit after the first contig?
This is the last read in the bam file before it stops:
gnl|ti|1479533009 0 Contig533 115 0
36M3I228M1D15M1I272M1D122M14I2M4I7M1D88M10I35M2D59M4I7M
27I8M * 0 0 NCCTAGTAG... !%'%')''((*%%... AS:i:-535 XN:i:0 XM:i:71 XO:i:11
XG:i:68 NM:i:139 MD:Z:0T1A0G0G0C1G0T2T0A0A0A1G0A1A0A1G2G
1T0C0G0A1G0C72T0G8T2G58C2T9A8A1C61^A4C21C50T39G25G8C0A79G29T23^A30A3T16A5C4C6C9C3G2G1A24G1A2T12^G5A7T38T23T17T20T7^AT40
A9A1A2T4C1T4G0C0T1T1G0 YT:Z:UU
mapping onto a contig which starts like:
Contig533 dna:scaffold scaffold:Aqu1:Contig533:1:1000:1
CTTGGAATACTGGCAGAGTTAACTGGTAAATGAAACTTTAAGAATAAAGAAAGAGAAGAA...
The full dataset was ~3M reads, where 1.8M mapped onto 13k contigs.
Thanks!
—
Reply to this email directly or view it on GitHub
https://github.com/ekg/freebayes/issues/197.

It works for that contig if I specify one, not sure why it isn't iterating through them like the other libraries.
Is there something funny with the naming of the files or reads that could make it stop after just one contig? In the --debug it says:
Opening BAM fomat alignment input file: fasta/reniera_sp__jgi-2005.fastq.sorted.filtered.bam ...
done
Number of ref seqs: 13397
Number of target regions: 0
but if I specify the region it says:
Number of ref seqs: 13397
will process reference sequence Contig13245:0..132822
Number of target regions: 1
Does the --target option just require a 3-column BED file for any/all contigs?

The --targets option requires the three column bed file. Unfortunately
while many users need this I have almost never used the feature, opting
instead to run across the entire contig set and then filter post-call, or
run one job/process per region of interest. These options should work. Have
you tried not supplying targets?
As I said I will be working on this issue in the next few days so if you
can reproduce the problem with little data please email me a test.
On Sep 24, 2015 3:29 PM, "Warren Francis"<EMAIL_ADDRESS>wrote:

It works for that contig if I specify one, not sure why it isn't iterating
through them like the other libraries.
Is there something funny with the naming of the files or reads that could
make it stop after just one contig? In the --debug it says:
Opening BAM fomat alignment input file:
fasta/reniera_sp__jgi-2005.fastq.sorted.filtered.bam ...
done
Number of ref seqs: 13397
Number of target regions: 0
but if I specify the region it says:
Number of ref seqs: 13397
will process reference sequence Contig13245:0..132822
Number of target regions: 1
Does the --target option just require a 3-column BED file for any/all
contigs?
—
Reply to this email directly or view it on GitHub
https://github.com/ekg/freebayes/issues/197#issuecomment-142946113.

I only tried the targets to see if that forced it to iterate through all of the contigs, but this stops as the first one in the same way as if I don't use -t.

Does the fasta index contain all the references? Is it valid?
On Sep 24, 2015 4:02 PM, "Warren Francis"<EMAIL_ADDRESS>wrote:

I only tried the targets to see if that forced it to iterate through all
of the contigs, but this stops as the first one in the same way as if I
don't use -t.
—
Reply to this email directly or view it on GitHub
https://github.com/ekg/freebayes/issues/197#issuecomment-142955554.

looks fine as far as I can tell, at least no different from the ones that worked.
$ wc Amphimedon_queenslandica.Aqu1.23.dna.genome.fa.fai
13397  66985 411972 Amphimedon_queenslandica.Aqu1.23.dna.genome.fa.fai
$ grep -c ">" Amphimedon_queenslandica.Aqu1.23.dna.genome.fa
13397
$ grep ">" Amphimedon_queenslandica.Aqu1.23.dna.genome.fa | head

Contig1 dna:scaffold scaffold:Aqu1:Contig1:1:633:1
Contig3 dna:scaffold scaffold:Aqu1:Contig3:1:652:1
Contig4 dna:scaffold scaffold:Aqu1:Contig4:1:654:1
Contig5 dna:scaffold scaffold:Aqu1:Contig5:1:662:1
Contig6 dna:scaffold scaffold:Aqu1:Contig6:1:665:1
Contig7 dna:scaffold scaffold:Aqu1:Contig7:1:715:1
Contig8 dna:scaffold scaffold:Aqu1:Contig8:1:717:1
Contig9 dna:scaffold scaffold:Aqu1:Contig9:1:718:1
Contig10 dna:scaffold scaffold:Aqu1:Contig10:1:720:1
Contig11 dna:scaffold scaffold:Aqu1:Contig11:1:743:1
$ head Amphimedon_queenslandica.Aqu1.23.dna.genome.fa.fai
Contig1	633	52	60	61
Contig3	652	748	60	61
Contig4	654	1463	60	61
Contig5	662	2180	60	61
Contig6	665	2906	60	61
Contig7	715	3635	60	61
Contig8	717	4414	60	61
Contig9	718	5195	60	61
Contig10	720	5979	60	61
Contig11	743	6765	60	61

For some reason the person who made this seemed to number them in reverse order, rather than the longest one first. Since these were Sanger reads, could there be a problem if some read were longer than the contig?

I don't think so. Are you using the most recent version?
On Sep 24, 2015 4:15 PM, "Warren Francis"<EMAIL_ADDRESS>wrote:

looks fine as far as I can tell, at least no different from the ones that
worked.
$ wc Amphimedon_queenslandica.Aqu1.23.dna.genome.fa.fai
13397 66985 411972 Amphimedon_queenslandica.Aqu1.23.dna.genome.fa.fai
$ grep -c ">" Amphimedon_queenslandica.Aqu1.23.dna.genome.fa
13397
$ grep ">" Amphimedon_queenslandica.Aqu1.23.dna.genome.fa | head
Contig1 dna:scaffold scaffold:Aqu1:Contig1:1:633:1
Contig3 dna:scaffold scaffold:Aqu1:Contig3:1:652:1
Contig4 dna:scaffold scaffold:Aqu1:Contig4:1:654:1
Contig5 dna:scaffold scaffold:Aqu1:Contig5:1:662:1
Contig6 dna:scaffold scaffold:Aqu1:Contig6:1:665:1
Contig7 dna:scaffold scaffold:Aqu1:Contig7:1:715:1
Contig8 dna:scaffold scaffold:Aqu1:Contig8:1:717:1
Contig9 dna:scaffold scaffold:Aqu1:Contig9:1:718:1
Contig10 dna:scaffold scaffold:Aqu1:Contig10:1:720:1
Contig11 dna:scaffold scaffold:Aqu1:Contig11:1:743:1
$ head Amphimedon_queenslandica.Aqu1.23.dna.genome.fa.fai
Contig1 633 52 60 61
Contig3 652 748 60 61
Contig4 654 1463 60 61
Contig5 662 2180 60 61
Contig6 665 2906 60 61
Contig7 715 3635 60 61
Contig8 717 4414 60 61
Contig9 718 5195 60 61
Contig10 720 5979 60 61
Contig11 743 6765 60 61
For some reason the person who made this seemed to number them in reverse
order, rather than the longest one first. Since these were Sanger reads,
could there be a problem if some read were longer than the contig?
—
Reply to this email directly or view it on GitHub
https://github.com/ekg/freebayes/issues/197#issuecomment-142958902.

I pulled again and remade the .fai file and there is no difference; it still stops after the first contig.

Would it be possible to share some of the data as a test case? Say, the
first three contigs?
On Sep 25, 2015 12:18 PM, "Warren Francis"<EMAIL_ADDRESS>wrote:

I pulled again and remade the .fai file and there is no difference; it
still stops after the first contig.
—
Reply to this email directly or view it on GitHub
https://github.com/ekg/freebayes/issues/197#issuecomment-143181657.

Hi, I am facing similar problem. It appears freebayes parallel is not able to iterate through all of the regions in the regions file specified. Can I kindly know if there is a work around for this?


How to create a pie chart marker ?

I would like to replace my circle marker to pie chart. I made a google search and found something like leaflet.minicharts, cluster markers, etc.Any suggestions?

You'd probably want to use d3 to draw the pie chart on the map. If you use the leaflet-d3 plugin hexbin layer as an example, you could draw basically anything you want on the map using the same basic code (just without the hexbin part). I've been wanting to make something like that for a while myself but haven't had the time.
I've also been thinking that it would be useful to move questions like these over to Stack Overflow. If you move it over there, reply here with the link and I can take a look at answering it if no one else chimes in. Also, if we make tags for angular2-leaflet and the other plugins, I can start watching them so I can chime in to contribute answers. That'll make stuff more discoverable for future people.
Thanks!

https://stackoverflow.com/questions/44455581/how-to-create-a-pie-chart-marker-on-leaflet-angular2

Yeah, I will look into it.

Is there any  leaflet option to display an html element on specific coordinates? So that i can pass my div element directly to leaflet.

I tried your methord But I'm getting the error,
https://github.com/humangeo/leaflet-dvf/issues/112

That sounds like you just need to include leaflet.js before you include the leaflet-dvf source

@reblace  You mean import at index.html?

Depends on how you have it set up. If it's angular cli or webpack based, you can just import them all in the typescript code (or in a vendor.ts file).
Otherwise, it might work to import them in index.html since they'll all just get put into the global scope that way.

I'm using angular seed by Minko. I will check this. But I got a temporary fix. Used leaflet icon URL and then Google image charts to generate chart.


Murmur reporting as Kinetic Damage type

The Murmur Fusion Rifle special weapon is being listed as a Kinetic type of weapon. The item attributes sent from Bungie list the Murmur as having a damage type of 0 which generally means that it is a kinetic weapon. In this case though, there are selectable perks that alter the weapon element from kinetic to either solar or arc.
Not sure how to address this without creating an exception for Murmur since it is the only weapon with this distinction or by later using the active perks to then designate the damage type for Murmur so that if person A has solar activated, it checks for the solar perk being flagged active and displays Solar as the dmgtype. I think that weapons with an element also list the perk associated with that element so that parsing Icebreaker would show the Solar perk as active (even though you could never deactivate it) and you'd then display Solar damage as the dmgtype.

Murmur should show up for Solar and Arc filters regardless of which perk is actively selected.
If Kinetic is the only damage type sent, then an exception will likely be necessary.

Well, from what I saw in the item attributes, Bungie sets the Murmur's damage type as kinetic (dmgType==0) and then the solar or arc damage perks are applied. I imagine if they include any similar guns in HoW it will be a similar problem, the gun's attribute are set as kinetic and you'd have to look to the perks for void, arc or solar damage in order to determine what element type it's utilizing.

Hmm, I like the idea of the murmur (and possibly future similar guns) to show up for all filters that it can be an element of if it has that perk. When I'm doing an arc burn it would be nice to know that I have a special arc weapon even if my murmur is currently set to be solar.

I think that by using the perk hashes you can do that quite easily. Implementing said perk hash parsing would simultaneously allow doing searches of is: armor piercing et cetera.

this is fixed


Copy docs framework from original package, update API docs via sphinx-apidoc

This PR copies the docs framework from the original spaceKLIP, and makes a few small updates to get the auto API docs working. I used sphinx-apidoc to regenerate the spaceKLIP.rst and modules.rst files, and now this is working locally for me to build all the docs successfully.

No longer needed, since we moved the code back to the original repo


Fix grammar for IDL v2

Closes #1324
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Line 20: service_statement should probably be ServiceStatement
Line 255: operation_statement should probably be OperationStatement
Line 351: resource_statement should probably be ResourceStatement

Good question -- those links refer to anchors that still exist and not grammar rules, so we're ok there.


Ability to configure master branch

It would be great if we could pass an option or ENV var to use a different branch than master for the base branch.

I agree, we would want to use develop for this purpose rather than master

PR for this here: https://github.com/lpender/bummr/pull/36


Invalid MATLAB example?

Hi!
The Matlab test file seems to have a invalid block comment in it. According to the official documentation block comments start with %{ and end with  %}. The test file has the comment start sequence swapped.
https://github.com/pygments/pygments/blob/3e1b79c82d2df318f63f24984d875fd2a3400808/tests/examplefiles/matlab_sample#L28-L30

Good catch, thanks!

Good catch, thanks!


Fixed no-confusing-arrow error in generic-table-row.

Removed a small bug caused by no-confusing-arrow eslint rule.

@miq-bot assign @karelhala
ping @martinpovolny

Thx!


bad link in API docs

lifecycle_hooks.dart points to go/angular-dart-docs/crash_detection.md but should instead point to https://github.com/dart-lang/angular/blob/master/doc/crash_detection.md.
We discovered this because @chalin was reviewing our link check skip patterns.
I looked for other go/ links but didn't find any. I'll fix this internally.

Internally fixed in #165769363


Tracking issue: Prepare validators for SHA224, SHA384, and SHA512

Origial issue: https://github.com/RedHatInsights/insights-data-schemas/issues/41

Duplicate for https://github.com/RedHatInsights/insights-results-smart-proxy/issues/392

Duplicate for https://github.com/RedHatInsights/insights-results-smart-proxy/issues/392


fix: Reset transaction in scope if span is reset

:scroll: Description
The private _transaction is not set anymore when setting a span on Scope. Instead the code relies on the public getter for transaction that already had logic in using the span name as the transaction if available. By doing so the transaction name is set back to null after a transaction finishes.
:bulb: Motivation and Context
Previously events had a transaction string set of transactions that already finished earlier. Because after a transaction finished, the _transaction field in Scopewas never reset.
:green_heart: How did you test it?
Added new new tests. Existing tests still work.
:pencil: Checklist

[x] I reviewed submitted code
[x] I added tests to verify changes
[ ] I updated the docs if needed
[x] All tests passing
[x] No breaking changes

:crystal_ball: Next steps

@lColinDl I don't really follow the issue, the transaction name is bound to the span object, so it is doing what it should do.
If there's a span bound to the scope, return the transaction name otherwise not.
There should not be a transaction name if there's no span in the scope.

There should not be a transaction name if there's no span in the scope.

That's exactly what this PR does, because that's currently not the case.
When a transaction finishes, the transaction name is still added to events from after the transaction.

That's right, but then this code is breaking the transaction feature anyway.
Maybe we should clean the transaction name from the scope here -> https://github.com/getsentry/sentry-dart/blob/25e9b5900ecb2ddc682fe68375964943fe087595/dart/lib/src/sentry_tracer.dart#L113-L118
scope.transaction (String) can be used standalone without the APM feature (spans), the difference is that when using the APM feature, we fallback to the span name instead of using the transaction String, and both should work as well, the current PR breaks the other feature, or I am missing something.

the current PR breaks the other feature, or I am missing something.

I don't see how this PR is breaking existing desired behavior. I intentionally tried to stay as close to the original behavior as possible. Setting the transaction name separately should still work as before. Notice also how all existing tests stayed untouched in their behavior.
Unfortunately I can't quite follow the rest of your argument. If you have a better solution to fixing the problem, I obviously don't mind it.

the current PR breaks the other feature, or I am missing something.

I don't see how this PR is breaking existing desired behavior. I intentionally tried to stay as close to the original behavior as possible. Setting the transaction name separately should still work as before. Notice also how all existing tests stayed untouched in their behavior.
Unfortunately I can't quite follow the rest of your argument. If you have a better solution to fixing the problem, I obviously don't mind it.

You're right, sorry for the confusion, I was misreading the spec.
Can you add a changelog entry? so we can merge it :)
Thanks for doing this.

Can you add a changelog entry? so we can merge it :)

Done: 8e21c1c

Codecov Report
Base: 90.09% // Head: 95.55% // Increases project coverage by +5.45% :tada:

Coverage data is based on head (8e21c1c) compared to base (7f2b01d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1125      +/-   ##
==========================================
+ Coverage   90.09%   95.55%   +5.45%
==========================================
  Files         117        2     -115
  Lines        3605       45    -3560
==========================================
- Hits         3248       43    -3205
+ Misses        357        2     -355

Impacted Files
Coverage Δ

dart/lib/src/scope.dart

dart/lib/src/protocol/sentry_thread.dart

dart/lib/src/http_client/tracing_client.dart

dart/lib/src/protocol/sentry_event.dart

dart/lib/src/sentry_traces_sampling_decision.dart

dart/lib/src/sentry_sampling_context.dart

dart/lib/src/utils/iterable_extension.dart

dio/lib/src/sentry_transformer.dart

dart/lib/src/noop_sentry_span.dart

...event_processor/deduplication_event_processor.dart

... and 105 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Declarative configuration

Does this plugin support Kong's DB-less mode through a configuration file? If so how should I define the options, currently I am getting errors in my config file about unknown_properties

Based on the information here it looks like it’s not supported:
https://docs.konghq.com/1.3.x/db-less-and-declarative-config/#plugin-compatibility https://docs.konghq.com/1.3.x/db-less-and-declarative-config/#plugin-compatibility

On 23 Oct, 2019, at 13:22, affanshahid<EMAIL_ADDRESS>wrote:
Does this plugin support Kong's DB-less mode through a configuration file? If so how should I define the options, currently I am getting errors in my config file about unknown_properties
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/nokia/kong-oidc/issues/136?email_source=notifications&email_token=AK5B63ITNWLC5IZOI5ZVTHLQQAXWXA5CNFSM4JD72VB2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HTZFJGQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK5B63KJIAOTHKD4JTLCQPTQQAXWXANCNFSM4JD72VBQ.

It does seem to be supported and working, I just had to change the configuration a bit, perhaps this could be documented. My config now looks likes this:
services:
  - name: config
    url: http://example.com
    # Entities can store tags as metadata
    tags:
      - config
    # Entities that have a foreign-key relationship can be nested:
    routes:
      - name: config-api
        paths:
          - /config
        strip_path: true
        # preserve_host: true
    plugins:
      - name: cors
      - name: oidc
        config:
          client_secret: secret
          client_id: kong
          bearer_only: 'yes'
          realm: kong
          introspection_endpoint: http://mykeycloak.com/auth/realms/experimental/protocol/openid-connect/token/introspect
          discovery: http://mykeycloak.com/auth/realms/master/.well-known/openid-configuration


Filtering algorithm, delete all label in my custom LiDAR dataset

Hi, I am working with my own custom LiDAR data.  Any help appreciated.
Thanks

hi,did you solove it? Can I talk with you about train own data

hi,did you solove it? Can I talk with you about train own data

Unfortunately, it has not solved yet. I still figure it out. Do you know how to solve it? Or do you have a similar problem?

hi,did you solove it? Can I talk with you about train own data

Unfortunately, it has not solved yet. I still figure it out. Do you know how to solve it? Or do you have a similar problem?

hi,did you solove it? Can I talk with you about train own data

Unfortunately, it has not solved yet. I still figure it out. Do you know how to solve it? Or do you have a similar problem?

May we use email to communicate details, I have some questions consultation ？email address<EMAIL_ADDRESS>

hi, what's your data fomat and data context?and How do you make your data set
------------------ 原始邮件 ------------------
发件人:                                                                                "traveller59/second.pytorch"                                                                                @.>;
发送时间: 2021年3月17日(星期三) 凌晨3:46
@.>;
<EMAIL_ADDRESS>主题: Re: [traveller59/second.pytorch] Filtering algorithm, delete all label in my custom LiDAR dataset (#444)
hi,did you solove it? Can I talk with you about train own data
Unfortunately, it has not solved yet. I still figure it out. Do you know how to solve it? Or do you have a similar problem?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

Hi, I am working with my own custom LiDAR data.  Any help appreciated.
Thanks

Hi,
I also met this problem. Have you solved it? If yes, could you please tell me the cause?
Thx!


[share] vault unavailable

Saved credential to Default vault, but during share flow the vault name is shown as Unavailable

Duplicate of https://github.com/trustbloc/wallet/issues/1471 - closing


split file

please provide the split file (train/val/test.csv ) of five experimental datasets.

We have uploaded dataset split files to this code repository. You can find them at the following path:
./dataset_split_file/

Thx


No options parameters for ToastUIEditor class are listed in the documentation

Describe the bug
No options parameters are listed in the documentation
To Reproduce
Steps to reproduce the behavior:
Go to https://nhn.github.io/tui.editor/latest/ToastUIEditor
Observe that there are no options listed in the table with the title: "new ToastUIEditor(options)"
Expected behavior
I expect that all of the available options with types and descriptions would appear on this table.

see https://nhn.github.io/tui.editor/latest/ToastUIEditorCore

OK then I think what needs to be fixed is the link under this heading: https://github.com/nhn/tui.editor/tree/master/apps/editor#default-options

@J-avery32
Thanks for reporting!


sys/targets: Disable PIE/ASLR when building tests

Due to issues with ASLR + ASan on ppc64le (see #1446), add the -no-pie
flag to the test target so tests will pass.
Signed-off-by: Andrew Donnellan<EMAIL_ADDRESS>
@RashmicaG has tested this, it works around our problems for now

Codecov Report

Merging #1455 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1455   +/-   ##
=======================================
  Coverage   56.49%   56.49%
=======================================
  Files         135      135
  Lines       25777    25777
=======================================
  Hits        14562    14562
  Misses      10544    10544
  Partials      671      671

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4b9981...0cd772a. Read the comment docs.


Possible fix for safari sidebar arrow bug

Closes #1281
Had an idea what might be causing this bug and changed the corresponding part of the code.
I don't actually have a way to test this because I don't have access to an apple device, so that will have to be done by someone else.

I would take myself out for the review. Currently no pad and time.

Closed. Already fixed with #1641


Very nice document!

The new layout and formatting help make this easier to read than the previous incarnation.  I just wanted to add a compliment, rather than picking at it.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 972d8899-c8a4-28c5-fabe-5ab294bac22d
Version Independent ID: 7f772e7a-836c-a18d-df8d-c3d115cb3d9f
Content: Log files for troubleshooting - Configuration Manager
Content Source: sccm/core/plan-design/hierarchy/log-files.md
Product: configuration-manager
GitHub Login: @aczechowski
Microsoft Alias: aaroncz

Thank you @Skatterbrainz for the feedback! I think this is my first opportunity to use the "kudos" tag. :)
Although a followup question before I close this. I actually haven't made any changes to this doc yet, and the format/layout was one thing I was considering changing. (I'm not yet sure 'to what' I would to change it.) Can you share more specifics what it is about the layout/format that you like? How is it structured now that you find easy to use?

It's a combination of several factors that often get overlooked in technical documentation:  font, spacing (and white space), table border margins, and the actual descriptions for each log.  They're concise and easy to understand.  Most of my wishlist ideas would fall on the console side of the relationship than on the web site, at this point anyway.


Reproducibility: control "tools" as well

We currently use some system tools:

install_name_tool on macOS for changing @rpath after building
patchelf on Linux to change RPATH after building

These tools could potentially influence how reproducible the final binaries are. Ideally we get rid of these third-party tools and implement the functionality natively in Rust but that is no small feat.
In the meantime it might be good to install them into their respective virtual environments and use them with a very specific version / lockfile and store that alongside the rendered recipe.

In fact, there is apparently a difference between cctools (from conda-forge) install_name_tool and Apple's version. The cctools one does automatic codesigning after modifying the binary.

First steps have been done and we have a system_tools section now in the recipe that records the versions of tools used. It might still be better and more appropriate to install these tools globally into their own environment though.


samples(discoveryengine): Update Vertex AI Search sample to use regional endpoint if needed

Description
Partial fix for b/349640878

Thank you Holt
I think we want to return the error (not print and continue):
    return fmt.Errorf("creating Vertex AI Search client: %w", err)

Done


Refactor tasks files

We have a lot of lines of code in projects/tasks.py and maybe some of them doesn't belong there or they can be moved to core/tasks.py.
Tasks we can consider moving,

[ ] fileify
[ ] send_notifications
[ ] email_notification
[ ] webhook_notification
[ ] remove_dir
[ ] clear_artifcats
[ ] clear_*_artifacts
[ ] finish_inactive_builds

We want to refactor these files and take a look if there are other task files than can be refactored also.
Ref: #3762

Hey! Can I take this issue?

@shubham76 Go ahead! Make sure to link back to this issue in your PR (I normally do this in the body), especially if the PR only affects one of the subtasks and not the entire issue.

This probably needs a little more hashing out before someone can jump in.

I raised this on the underlying PR comment already.
readthedocs.core is not an obvious spot for code, it doesn't mean much to me and has become a dumping ground for code. I'd prefer we look into a different pattern for moving these files around:

Break up readthedocs.projects.tasks into submodules: readthedocs.projects.tasks.build or readthedocs.projects.tasks.sync, etc
Move to an application where the tasks makes more sense -- if a task operates on versions, it should be in readthedocs.builds.tasks

I'd prefer either over readthedocs.core

Okay! So we shouldn't move the code to readthedocs.core and instead to other submodules as you are suggesting.
In that case, I think I have messed up the PR. I'll start from scratch and try making changes as you had suggested here.

Hey! So how many submodules should we have to move above mentioned files into?

Is this issue still open?

@Alig1493 there is an open PR  for this https://github.com/rtfd/readthedocs.org/pull/3943

I closed #3943 because it is old and had many conflicts. If anyone else wants to attempt this, I'm all for it. Please do try and keep the refactor minimal though!

@ericholscher If this requires a new PR I'd like to take a stab at it.

@Alig1493 go ahead!

@stsewd Before proceeding I noticed that there are 5 failing tests in the updated upstream master, namely in rtd_tests/tests/test_backend.py(3) and rtd_tests/tests/test_celery.py(2) files. Will this be an issue moving forward?

@stsewd I keep getting errors in tests which require for me to connect to a remote repository. Is there any chance that there certain tests that will fail in local?

@dojutsu-user I see. I can't seem to figure out the issue on my end though. Keeps telling me it has failed to connect to remote repositories.

@stsewd My git version shows to be at version 2.7.4

@Alig1493 Can you post an screenshot or some error log??
and also, are you using tox?

@dojutsu-user sure.

@Alig1493 you are not using the correct git version. The first line of your screenshot says that --prune-tags arg is not known.

Hello, I see this issue still exists. I'm new here and would like to take a shot at it.
May I know why https://github.com/rtfd/readthedocs.org/pull/4888 was not merged?

It got staled and with a lot of conflicts I think

Okay, thank you.

is this issue still open?

Hi @Iamshankhadeep
Thanks for your interest in contribution.
There's already PR open for this issue #5333.
I would suggest to please look for another open issues.
Thanks.


Fixed undefined variable error.

When trying to use more than one color buffer, fbo initialization fails due to undefined variable reference.

Thanks!

No, thank you for the awesome modules!


Fix paginator counter on x86-32

Atomic operations with 64 bit values must be aligned for 64-bit on x86-32.
According to the spec:
"The first word in a global variable or in an allocated struct or slice can be relied upon to be 64-bit aligned."
The above wasn't enough for the paginationPageCount on SiteInfo, maybe due to how SiteInfo is embedded.
This commit adds a 4 byte padding before the uint64 that creates the correct alignment.
Fixes #2415

@MarkDBlackwell @moorereason this PR makes the tests pass on both x86-32 and the rest for me.

Here I document for myself (and others) some points you may already know. Per func (*Value) Store (in pkg/sync/atomic):

All calls to Store for a given Value must use values of the same concrete type. Store of an inconsistent type panics[.]

Per Bugs (in pkg/sync/atomic):

On both ARM and x86-32, it is the caller's responsibility to arrange for 64-bit alignment of 64-bit words accessed atomically. The first word in a global variable or in an allocated struct or slice can be relied upon to be 64-bit aligned.

However, per discussion here and here:

If I have an array of structs, are the first words of each and every struct in the array automatically 64-bit aligned, or just the first one?

Just the first one; it depends [upon whether] the size of each element, plus padding, is a multiple of [64 bits]. The key phrase there is "allocated"...A struct inside a slice or array is not allocated by itself, and no particular alignment is guaranteed beyond that of unsafe.AlignOf.

From this, (for 32-bit systems), I take that:

Using pkg/sync/atomic, storing an int64 to any location unaligned to 64 bits panics;
Structs align int64 fields only to 32 bits; and
When a struct is an array element, starting it with an int64 field generally aligns that element only to 32 bits.

An array of SiteInfo is created here by hugolib/hugo_sites.go (I think).
Per the discussion referenced above, on 32-bit machines, perhaps:

Only if a struct's size is a multiple of 64 bits will Go then guarantee for it (in arrays and slices) that all elements are 64-bit aligned;
Currently, the particular, problematic test passes, because now the size of the SiteInfo struct is a multiple of 64 bits (I suppose).

Some research revealed that automatically aligning the size of a struct (on 32-bit machines) to a multiple of 64 bits seems difficult.


Please provide method to determine if a group is legal before adding it and causing exceptions.

Describe the feature
Currently there are 4 rules in place that determine whether or not it is legal to add a new group to columns and rows. Unfortunately you have to try to add it to see if it is valid or not and then handle the exceptions and give an explanation to the hapless user. It would be better if there was a function that could determine whether it is legal to add a given outline ahead of time, so the gesture (on a context menu, for instance) and be dimmed if not valid. This is a far better user experience.
Which edition of ReoGrid is targeted

WPF

Thanks! I think it is a nice idea and should consider to be implemented.


application guard control

Can i use  WDAG control  with third-party antivirus product, I disabled windows defender by group policy  < or  is it compatible  with third party products

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b3d6356b-87ff-8c3a-56ef-1270a823d3ab
Version Independent ID: 4d6ae878-66cf-0e10-bdf3-bdd6054cbc9d
Content: What's new in Windows 10, version 1809
Content Source: windows/whats-new/whats-new-windows-10-version-1809.md
Product: w10
GitHub Login: @dawnwood
Microsoft Alias: trudyha

@officedocsbot assign @jvsam

Hi @RAJU2529 were you able to find the answer to your question since you've opened this issue? If not, maybe this documentation with Windows Defender Antivirus compatibility matrix may help. You may want to check this support help article as well.
If you are experiencing issues on Windows 10 that don't pertain to the documentation, please utilize the proper channel by contacting support and opening a service ticket in your tenant.
Thank you for engaging with the community!

@jvsam Thanks  for the links , i have  checked  above  link, in first link about only  windows  defender antivirus  .  But i asked about windows  defender application guard   with  third party  antivirus  Kaspersky total security . I already   disabled  windows defender gpo permanently to avoid conflicts .
I also checked in second link,  KTS has  already  sets  desired registry  key on windows 10 1903

Hi @RAJU2529 good call. I believe support or that forum can assist you better with your question. Thank you for sharing the link here.

Hi again @RAJU2529, since this documentation is still considered accurate and up-to-date, we will now close this issue. However, feel free to re-open if you have suggestions to improve the quality of this documentation and we will submit them for review. Thanks for being part of the Microsoft Docs community!

@officedocsbot close


Update Missionfile

Q
A

Bug fix?
yes / no

New feature?
yes / no

Needs wipe?
no

Description:

Content:

[ ] Content part

Successfully tested on:

[ ] Local MP
[ ] Dedicated MP

Wind manual override -> Sniping


CPR - Undead Spirit missing configure images

hi, I noticed that my Summon Undead had stopped working (no token/avatar art). So I updated the spell with a fresh copy from the compendium and enabled "Keep Summon Actors Updated". I notice the new CPR - Undead Spirit no longer has the "configure images" feature. I copied my old version across and ran the macro but my summons are still no token/avatar art.
kind regards

On the spell in the inventory press the medkit button then hit configure.

Dang it sorry. Worked a charm many thanks.


Add label when GRC is deployed

Signed-off-by: Dominique Vernier<EMAIL_ADDRESS>

/hold

@qiujian16 I asked @itdove to create this PR so please don't blame him ;-)
We (cloud-services team) need to use the Placement API in our client-side operator to allow a user to "select" a set of managed clusters for which they wish us to configure identity providers.  We need the ability, through the Placement API to identify just those Managed Clusters that have the GRC PolicyController addon enabled.  Since I cannot find any examples of a Placement Predicate that is using anything other than cluster labels we needed to identify a way to add a label to indicate if grc's PolicyController addon is enabled on the ManagedCluster.   This PR would solve that problem for us by looking at the KlusterletAddonConfig and updating the ManagedCluster with the label policycontroller.addon.open-cluster-management.io equal to true.  The ability to automatically add labels for other klusterlet addons that are enabled may be something to investigate but we only need to know about the grc PolicyController for our use case.
If the Placement predicate does support us matching an expression for enabled/disable addons I'm happy to use  that instead but I'd need a link to some code that I could read to understand how to use it.  If there is no support for such an expression I'd really like you to review this PR and we can discuss if we can get this merged in for the 2.4 release.
Attn:  @mdelder @robinbobbitt

@tpouyer I think having placement to select  clusters based a certain set of addons is enabled or not is a valid use case. Placement API does not support it today, but I would want this to be an enhancement in placement.
@itdove would you create an issue in https://github.com/open-cluster-management-io/community/issues with this use case?

Do you plan to lgtm this or or we have to put the issue I will create as a blocker for our project?

/unhold

Do you plan to lgtm this PR or we must put the issue I will create as a blocker for our project?

@qiujian16 I've opened an issue in the project here:  https://github.com/open-cluster-management-io/community/issues/74
@itdove let's close this PR for now and can you work with @qiujian16 to figure out how best to implement solution for the issue https://github.com/open-cluster-management-io/community/issues/74 as quickly as we can.
@qiujian16 until we have a solution for this the work I'm doing with @itdove is blocked and cannot make progress.  How quickly can I get a resolution for this issue?

I will take a look at it today. IF it blocks you, I think we can merge this as a workaround for now. I think we'd better add some comments  on the code to indicate this is a workaround.
We have to pipeline the placement enhancement in the community, I think there is another enhancement about global placement that is also needed? Let's also create an issue for that...

I will take a look at it today. IF it blocks you, I think we can merge this as a workaround for now. I think we'd better add some comments on the code to indicate this is a workaround.
We have to pipeline the placement enhancement in the community, I think there is another enhancement about global placement that is also needed? Let's also create an issue for that...

That sounds like a good plan... merge this PR to give us a work-around and then you can take more time to figure out the right approach for allowing the user of addon enabled/disabled status in the predicate cluster selector.


⚠ Samsung has degraded performance

In 495c93a, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 3396 ms

Resolved: Samsung performance has improved in 4be0bf9.


⚠ Bofrost.at has degraded performance

In f650094, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2128 ms

Resolved: Bofrost.at performance has improved in 6611b93.


Kernel fails to build - linux/netfilter_ipv4/ipt_ECN.h: No such file or directory

Windows Version
Microsoft Windows [Version 10.0.22621.2861]
WSL Version
<IP_ADDRESS>
Are you using WSL 1 or WSL 2?

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>-2
Distro Version
Debian Sid
Other Software
No response
Repro Steps
make -j8
Expected Behavior
Kernel compiles successfully
Actual Behavior
Eventually I get the error:
net/ipv4/netfilter/ipt_ECN.c:17:10: fatal error: linux/netfilter_ipv4/ipt_ECN.h: No such file or directory
17 | #include <linux/netfilter_ipv4/ipt_ECN.h>
|          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Later there are some other similar ones. Now, there's no such file in include/linux/netfilter_ipv4/, but there is one in include/uapi/linux/netfilter_ipv4/, along with every other one that end up not found during kernel compilation. My guess is that somehow make never consults the include/uapi/ folder, most likely due to a mistake in the makefile. I've been unable to find the problem in there, though.
Diagnostic Logs
No response

SOLVED. Turns out I had to do make headers. Which didn't work either because I had the misfortune to untar the tarball into an NTFS system, which apparently doesn't play nice with lower/uppercase. Well done WSL team on including this vital info in compile instructions.


toggleLinksConnections does not collapse provided link

Describe the bug
when calling toggleLinksConnections(d3Links, connectionMatrix) with my graph.links and graph.links[10] (link to collapse) inside onClickNode, nothing happens
Expected behavior
the provider link in paramter should make that link collapse.
Environment:

OS: windows
Browser chrome
react-d3-graph version 2.3.0

Hello @maximegheraille toggleLinksConnections is not primarily designed to be used by the client. It's an internal instrument used by onClickNode  to make the nodes collapse. I'm afraid if you used it as mentioned you'll have undesired side effects or it won't work at all.
Try to collapse nodes & links by enabling config.collapsible configuration.


Show component terms in the order the appear in the term in popup

From Discord:

The new component terms are nice to have, but it doesn't show them in the same order of the compound term, my guess is, it shows them in the order they were added to my terms' list.

I actually don't know how it sorts the terms :-P, it might be alphabetical or something.  Basically it just does a match of the terms and throws them out there, it doesn't try to locate them within the string.  That gets fairly complicated, but that's what's done for the rendering for the reading screen -- maybe the rendering calculations can be repurposed so that the components are shown in more-or-less the same order that they're found in the term.

This would need to somehow use the rendering calculation to locate the components in the original multi-word term, and then print them out.

Before the change:

After:

fixed in develop

Launched in 3.3.3


Changing the destination branch of a pull request after deletion

Feature Description
branch3 -> branch2 -> branch1 -> master
Now, if we have a chain of pull requests, we cannot merge branch1 first, because all other requests to branch1 will be closed without the possibility of reopening.
In bitbucket, this was solved by the fact that when deleting a branch1, all open pull requests change the target to the branch into which branch1 was merged, in our case, this is the master.
Screenshots
Here is an example in the form of a mind map.
Schema before merge branch1:

After merge and deleting branch1:

Retargeting all pull requests targeted branch1 to master sounds reasonable. Or we can have a prompt dialog to let users choose when deleting?

Retargeting all pull requests targeted branch1 to master sounds reasonable. Or we can have a prompt dialog to let users choose when deleting?

Only before we merge branch1. It's easy to forget to do that. Why not do it automatically, as it is implemented in Bitbucket


Unavailable date/time for the pickers

For the datepicker & the timepicker components, it'd be very cool to have the option to make certain days/times unavailable, say for a booking app for instance.

[x] I have searched the issues of this repository and believe that this is not a duplicate.

For date picker pre-v1 you have shouldDisableDate. Nothing for time picker.

We do no longer host this components: #4787. Maybe sometime in the future.

@oliviertassinari what is the reasoning behind this? Date & time pickers are some of the most iconic material design components...

@theiliad iconic, most challenging to implement correctly and less used components. We focus on the components that provide the most value for now. We will extend our scope step by step.


g++ does not come with fedora by default

I've tried it on fedora and it generates a working build.

I signed it!


[Feature request] Online / Offline handling

I have no clue if this is already possible, but here goes.
What if your (custom)driver goes down, can you update your device (in realtime) with an exclamation mark that would take it to the details page of that device?
What if you could send a notification to the brain, as flexible as possible (aka overlay with full customization), if 'some event' occurs? e.g. z-wave motion etc?

I asked for this one awhile back and feel it's a very important item to have as devices can commonly go offline/online for various reasons.

@neophob my question was more or less two-fold;
one- update indeed the device status in real time with maybe a custom message why the exclamation mark appears
two- out-context push notifications if user needs to provide either input or the device has remarks.
with regards to two: a practical use case would be: You could for example use this as an extension of cable salad; where the user has to provide additional one-time information while setting up the device (e.g. user/pass in case of kodi extension)


JSON conversion does not keep some of original data types.

Currently, JSON.stringify and JSON.parse are used to stringify objects. But, some data types like typed arrays, cannot be converted to their original type .
Reproduction
Let's assume we have this POJO data.
{
  id: '7cef963a-895e-4e1f-b93e-9f2085e38e87',
  createdAt: new Date('2024-04-04T21:06:01.463Z'),
  updatedAt: new Date('2024-04-04T21:06:01.463Z'),
  key: Buffer.from([
    65, 65, 207, 252, 215, 0, 245, 135, 1, 7, 165, 188, 172, 33, 19, 215,
  ]),
  blob: new Uint8ClampedArray([1, 2, 3, 4]),
}

This is stringified to:
{
  "id": "7cef963a-895e-4e1f-b93e-9f2085e38e87",
  "createdAt": "2024-04-04T21:06:01.463Z",
  "updatedAt": "2024-04-04T21:06:01.463Z",
  "key": {
    "type": "Buffer",
    "data": [65,65,207,252,215,0,245,135,1,7,165,188,172,33,19,215]
  },
  "blob": {
    "0": 1,
    "1": 2,
    "2": 3,
    "3": 4
  }
}

And, it's parsed to:
{
  id: "7cef963a-895e-4e1f-b93e-9f2085e38e87",
  createdAt: "2024-04-04T21:06:01.463Z",
  updatedAt: "2024-04-04T21:06:01.463Z",
  key: {
    type: "Buffer",
    data: [
      65, 65, 207, 252, 215, 0, 245, 135, 1, 7, 165, 188, 172, 33, 19, 215
    ],
  },
  blob: {
    "0": 1,
    "1": 2,
    "2": 3,
    "3": 4,
  },
}

Typed array and  Buffer are not parsed to their original type.
We need to keep their types after parsing.
List of primitives to keep their original type
here's a list of primitives to keep their original type I found so far:

typed array (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Typed_arrays#typed_array_views)
Buffer (from Node, Bun ...)

Other primitives
I've just found this issue, and I'm checking if other data types like Blob, Symbol, or Date are to be considered.
Please let me know if any of you found other data types to manage.

Good findings. Any PR welcome of course

One of solution is to use default serializer and deserializer from v8 api.
import assert from 'node:assert'
import { deserialize, serialize } from 'node:v8'

const obj = {
  str: 'string',
  num: 0,
  obj: { foo: 'foo' },
  arr: [1, 2, 3],
  bool: true,
  nil: null,
  undef: undefined,
  inf: Infinity,
  date: new Date('Thu, 28 Apr 2016 22:02:17 GMT'),
  map: new Map([['hello', 'world']]),
  set: new Set([123, 456]),
  buffer: Buffer.from([1, 2, 3]),
  typedArray: new Uint8Array([1, 2, 3]),
  typedArray2: new Uint8ClampedArray([1, 2, 3]),
  re: /([^\s]+)/g,
  big: BigInt(10),
}

console.log('original object')
console.log(obj)

const s = serialize(obj)

console.log('serialized')
console.log(s.toString('base64'))

const d = deserialize(s)

console.log('deserialized')
console.log(d)

assert.deepEqual(obj, d)

This can serialize most of data types, but fails when the object contains function or URL instance.
But we can just handle these special cases.
Also, the serialized data is binary, we might need to use JSON.stringify for debug.
What do you think of it?

@ramiel  I tried to find the best data serializer for Node and Bun, I concluded the v8 serialize/deserialize performs the best.
While JSON serialization doesn't consistently reproduce the exact same data after deserialization, v8 does so reliably when both serializing and deserializing are successful.
Also, since Redis can handle binary data, we can directly store the output. We can still generate human-readable serialization results using JSON.stringify for debugging purposes. If you agree with my findings, I can work on it right away. 😄

I'm thinking a bit more about this issue. I'm realizing we don't need to serialize every possible javascript type, but only what can be saved/loaded from mikro-orm and so what can be saved into the database. So, my first question is how did you managed to have a Buffer from mikro-orm?

Yes, I'm using Blob Type provided by mikro-orm. But I didn't made this issue because the Blob Type doesn't have an appropriate toJSON method.
The data received by the cache adapter is an entity that has been processed using toPOJO (wrap(entity).toPOJO()).
If mikro-orm only allowed properties stored directly into the database, we would simply need to handle a few edge cases like Buffer and Typed Array.
However, mikro-orm provides virtual properties that are not stored in the database but can be accessed at the programming level. This means an entity can contain any primitive type - regex, function, Map, and so forth. (Since we don't store the virtual properties, custom types are unnecessary.)
So, in theory, every JavaScript type can be loaded from mikro-orm.
The virtual properties remain after the toPOJO processing. Consequently, the cache adapter must be capable of managing all primitives.

In this case, please go on. Thank you!

@ramiel Any chance it will get reviewed and will be merged to the stable release soon? This is very needed even for Date types and v8 serializer solves this. Thanks

@Stene3 I actually made my own version of the cache adapter. You can check it out here:
https://www.npmjs.com/package/@javien/mikro-orm-redis-cache-adapter

Hey guys, totally forgot about this. Let me merge and release

Merged and released version 4.0.0


Fixed network policy of client_integration_test

//test/common/integration:client_integration_test requires networking
which is not allowed by default. This allows the test to use the
localhost network.
Signed-off-by: Will<EMAIL_ADDRESS>Description: //test/common/integration:client_integration_test requires networking which is not allowed by default. This allows the  test to use the localhost network.
Risk Level: Low
Testing: See  unit_tests  workflow
Docs Changes: N/A
Release Notes: N/A
Fixes #2020

@jpsim @goaway @lfpino

Thanks @WillEngFlow!

@jpsim It looks like this is failing because the exec_properties attribute does not exist on envoy_cc_test upstream. Do you mind adding it for me and piping it into the wrapped cc_test?
envoy_cc_test defined here: https://github.com/envoyproxy/envoy/blob/519774f742bb2500cf5f6a00933c9662337acbb2/bazel/envoy_test.bzl#L143
An example of piping exec_properties through via 'envoy_mobile_jni_kt_test`: https://github.com/envoyproxy/envoy-mobile/blob/cef4ec0a29d3adf09a0df68da3d2aa8c988a7335/bazel/kotlin_test.bzl#L4

Sure I'll plumb that through and see if it helps. I'll do the same for the Swift integration test that similarly had remote exec disabled.

[bazel] allow specifying exec_properties in envoy_cc_test

I've validated that it works: https://github.com/envoyproxy/envoy-mobile/runs/4959253557
My upstream Envoy PR (https://github.com/envoyproxy/envoy/pull/19711) was approved and is being auto-merged. Once that's in, I'll bump the Envoy submodule commit to point to it and you'll be able to rebase this PR.

https://github.com/envoyproxy/envoy-mobile/pull/2027

#2027

Thanks for all the work @jpsim! I'm tracking the submodule update.

I just merged #2027 so if you update, you should be able to pass exec_properties in envoy_cc_test.

I just merged #2027 so if you update, you should be able to pass exec_properties in envoy_cc_test.

Thanks @jpsim! I just pushed the most recent fix. I did get some linter errors on the WORKSPACE file after rebasing (in the pre-push check) but no changes were made to WORKSPACE and my changes checked out so I pushed with --no-verify

@WillEngFlow i also often get errors in the pre-push hook, but pre-commit —all-files works. I need to look into fixing that at some point.
in this case, I think the BUILD file you edited needs to move the attribute to match the definition.

Thanks for seeing this through!

Thanks for all the help for a first time contributor!


Meta typo!

R: @petele
META TYPO!!!!!!
Fixes #6794

:+1:

:tada: This has been pushed live to https://developers.google.com/web/


Fix function comments based on best practices from Effective Go

Every exported function in a program should have a doc comment. The first sentence should be a summary that starts with the name being declared.
From effective go.
I generated this with CodeLingo and I'm keen to get some feedback, but this is automated so feel free to close it and just say "opt out" to opt out of future CodeLingo outreach PRs.

Looks like most of these changes are good like this and this.
I should note, however, that it also does some basic formatting and capitalisation fix ups like this when it doesn't know how to add the function comment nicely, but it sees there are other issues. Do you feel that's out of scope, or useful? Is it blocking at all?
Let me know if you think this was useful :smile:
Note: I've only updated functions that I know CodeLingo can rewrite nicely, but you can install it from the GitHub marketplace to review your PRs automatically and find all issues.


Runtime Integration Test

Closes #104

Current dependencies on/for this PR:

main

PR #125

PR #131
PR #126
PR #123

PR #130

PR #132

PR #113

PR #114

PR #129

PR #111   👈

This stack of pull requests is managed by Graphite.


[SUPPORT] How to utilize cached dataframe in HUDI with Spark

To Reproduce
Steps to reproduce the behavior:
val df = ...
df.persist()

df.filter(filter_condition_1).write.format("hudi").options(options1).mode("append").save(path1)
df.filter(filter_condition_2).write.format("hudi").options(options2).mode("append").save(path2)

df.unpersist()

I checked stages on Spark HistoryServer WebUI, df has been calculated twice, is it possible to utilize cached dataframe in Spark?
Expected behavior
Cached dataframe in Spark should not be calculated twice until releasing action called.
Environment Description

Hudi version : 0.12.0

Spark version : 3.3.0

Hive version : Not used

Hadoop version : 3.3.3

Storage (HDFS/S3/GCS..) : GCS

Running on Docker? (yes/no) : no

Hi, I am facing the same issue in hudi with aws glue? What is the solution for this?

Hi, I am facing the same issue in hudi with aws glue? What is the solution for this?

@logesr , sorry, no more ideas. Just avoid such usage for now


⚠ Mobitopup has degraded performance

In 6f7f241, Mobitopup (https://napcard.voz.tech) experienced degraded performance:

HTTP code: 200
Response time: 19915 ms

Resolved: Mobitopup performance has improved in caff101.


Add backup paths

Docs are here:
https://dashflo.net/docs/api/pterodactyl/v1/#req_a7e189492b784c5cb12eaffa1368a06c

[x] Example - Return an example

[x] Create a backup class and backup attributes interface. Backup class containing attributes property and download and delete methods

[ ] Get backups - Array containing backup class

[ ] Create backups - The backup that was created (return in new Backup())

[x] Get backup details - Backup class containing backup details

[x] Download backup - String. A link for the backup

[x] Delete backup - Boolean OR string containing an error from the panel (return response.json() on an error)

Will test the 3 ive done tomorrow

Testing complete. Backup details getter, backup download and delte methods work.


Programs: short list missing

The list in the new site has the wrong content.

no logos
short description
tags

alright, merged data from directory and mongo to get this, tags used to use the first 6 characters of the mongo id for a colour, so pick one :-)

I like the grey scale better - let's go with this as MVP prior to move to open opportunities


Test with io.js

make sure it works here as well as in nodejs

hacknightslc.com is up and running on iojs with monument. So... looks like everything is working as expected.


Styles don't load because they require unsafe-inline Content-Security Policy (CSP)

Our content security policy (CSP) includes: style-src 'self' docs.ourcompany.com;
However, when we load our api doc using OpenAPI explorer, the style sheet doesn't load, and the console fills up with CSP errors because we don't allow inline styles.
Can the styles be externalized into a stylesheet so sites with a strict CSP can display the stylized version?

At the moment this isn't possible. The reason that it isn't is actually due to the fact that there the dynamic stylings are calculated and injected in based on the theme set in the html attributes. We have been waiting for advanced functionality in CSS to be widely adopted so we can move from javascript to pure css here, but it hasn't happened yet.
To help us prioritize the need for this, could you explain the threat model associated with using the unsafe-inline in the style-src SCP?

Yeah. It's a requirement from our infosec team. I can get details. Basically, I work for a cybersecurity company, and we have some clients who have complained in the past about 'unsafe-inline' even for style-src. I haven't been given info on a specific threat model, but I can dig into that.
And the reality is that if you don't include unsafe-inline, you can't even use <style></style> on the page. All style definitions need to be in an external style sheet. But I get that that solution isn't perfect either.
I may need to see if we can stand up a specific server for our developer audience just for API doc and see if we can get away with unsafe-inline there.

We can easily get around the <style> by using the nonce-value option in the CSP, for where we are using it. Then you can pass that value in to us. The problem is that I can't fathom restricting all future development from using inline styles, since I too work for the security industry (on the app sec side), I'd love to know the attack vector with unsafe-inline, because if there is actually one there, then it would be a great signal for us to actually do this differently.

After extensive research on our side. we haven't been able to find any attacks that can utilize the unsafe-inline for style-src. It's worth mentioning that we did find one strategy that does utilize css via the image-src to perform attacks. That is, if you import malicious CSS into your site through pages, etc... And that CSS contains images or javascript, then the url(LINK) property can be abused to perform an attack. But that attack is blocked by the image-src attribute not the inline styles. (Here is the reference to that attack).
As such we cannot find any security issues with the CSP style-src: 'unsafe-inline', for right now, I am closing this issue.


Read and write info from/to vtk, medit, xdmf

This PR allows to read and write application specific information (e.g. bounds, post-processing data, time steps, etc.) in VTK, MEDIT and XDMF formats.
The information is stored in:

VTK: title line
MEDIT: comment line
XDMF: Information tag

Tests are needed for this. Best add a add_info() method in tests/helpers.py, equip and mesh with same information and assert that input and output information is equal.

Yes, I can do some tests, but first let's decide whether to copy mesh.info.

Okay, I've made up my mind about this.
I want an extra attribute to mesh named commentary, being a (possibly empty) list of strings. When reading a file, the list is to be filled. When writing, all the commentary is to be put at the beginning of the file. If the format does not permit arbitrary comments (like VTK), then issue a warning and write what you can. If the list is empty, write the usual # This file was created by meshio v....
It's probably best to start off from scratch with this, but I'll leave it up to you.

Okay, I will start from scratch.


Display Text via WebGL

Text is still missing in order to have all display components run on any display backend (see comment).
Possible implementations:

Render to 2d Canvas texture, then render texture via WebGL link1
Have a big texture with every letter, render parts of texture (corresponding to the letters) via WebGL link2 link3 link3 docs

Actually approach#1 could be used to create a texture dynamically for all the required letters and fonts at loading time. Then approach#2 can be used to draw individual letters from this dynamically created texture during runtime.

I've thought about this in the past, and I think the best approach would be to create a new "ImageText" component that uses a spritemap, as per approach #2.
That would be useful even outside of WebGL, since games often want custom bitmap fonts.
The idea of automatically rendering a specified style of font using canvas to a bitmap font would complement this approach well.

Since you guys seem experienced with webGL (and I'm not). I see a lot of examples online of demo's that manipulate images (brightness, hue, saturation, blur) using webgl shaders. How hard is it to add these kind of things to crafty?
This way I could recolor/saturate sprites dynamically with the minimal amount of real assets needed.

@matthijsgroen Did you manage to get this to work? I'd like to apply a hue-rotation filter to my images, but I'm not able to find a solution at this moment.
Or perhaps this has been added to the API already? I can't seem to find it in the docs in that case.


Add 76 onnx vision model int8 & f32 model.py

All models has been uploaded to XSJ server.
These files are automatically generated by aztestsetup.py. Next step is to change the input for them one by one.
SHARK-TestSuite/e2eshark/tools/stubs/commonutils.py at main · nod-ai/SHARK-TestSuite (github.com)
, you will need to add parameters to specify input dimensions and then make this line
SHARK-TestSuite/e2eshark/tools/stubs/commonutils.py at main · nod-ai/SHARK-TestSuite (github.com)
use the parameters. Then, in the model.py file, change this line to pass the appropriate input parameters based on the model
SHARK-TestSuite/e2eshark/onnx/models/AlexNet_vaiq_int8/model.py at main · nod-ai/SHARK-TestSuite (github.com)

tests
model-run
onnx-import
torch-mlir
iree-compile
inference

onnx/models/RRDB_ESRGAN_pro_vaiq
failed
notrun
notrun
notrun
notrun

Traceback (most recent call last):
  File "/proj/gdba/shark/chi/src/SHARK-TestSuite/e2eshark/test-run/onnx/models/RRDB_ESRGAN_pro_vaiq/runmodel.py", line 35, in <module>
    model_output = session.run(
  File "/proj/gdba/shark/chi/src/SHARK-TestSuite/e2eshark/e2e_venv/lib/python3.10/site-packages/onnxruntime/capi/onnxruntime_inference_collection.py", line 220, in run
    return self._sess.run(output_names, input_feed, run_options)
onnxruntime.capi.onnxruntime_pybind11_state.InvalidArgument: [ONNXRuntimeError] : 2 : INVALID_ARGUMENT : Got invalid dimensions for input: input for the following indices
 index: 1 Got: 3 Expected: 250
 index: 3 Got: 250 Expected: 3
 Please fix either the inputs/outputs or the model.


docker image

This allows to dockerize rasa_nlu. To run, clone the project and run the following commands:
docker build -t rasa_nlu:1.0 .
docker run -p 5000:5000 --rm --name rasa_test -it rasa_nlu:1.0 -e wit

might take some time to download everything (especially spacy, which gives some troubles today during the download process). Moreover, if run with mitie the first run will require the download of total_words.dat from S3.
After that you might want to run it with the option -d instead of --rm (thus, in detatched mode)
docker run -p 5000:5000 -d --name rasa_test -it rasa_nlu:1.0 -e wit

To test connect to localhost:5000

The CI build failed after fetching Spacy files as well...


NodeJS Package Manager Ability to chose version of Packages

Is your feature request related to a problem? Please describe.
If you are have an existing bot built with an older version of a template, for example a 4.13 bot packages instead of 4.14.1.
When you try to install some packages such as Orchestrator you are only able to install the latest version.
This can be an issue because of conflicting package definitions between the bot and the package.
Describe the solution you'd like
Package Manager should support the ability to chose different versions of the package if available.
Describe alternatives you've considered
Only alternative is to need to update the core packages of the bot any time you want to add a package which adds risk.
Not all packages have compatibility issues sit is purely dependent on the packages.
Additional context
Error adding Orchestrator.
A problem occured during the install of this Component: Error conflicting definitions of Microsoft.EditActions.schema botbuilder-dialogs-adaptive: /Users/bhiggin7/repos/CoreWithQnA_3/CoreWithQnA_3/node_modules/botbuilder-ai-orchestrator/node_modules/botbuilder-dialogs-adaptive/schemas/Actions/Microsoft.EditActions.schema botbuilder-dialogs-adaptive: /Users/bhiggin7/repos/CoreWithQnA_3/CoreWithQnA_3/node_modules/botbuilder-dialogs-adaptive/schemas/Actions/Microsoft.EditActions.schema Error conflicting definitions of Microsoft.EmitEvent.schema botbuilder-dialogs-adaptive: /Users/bhiggin7/repos/CoreWithQnA_3/CoreWithQnA_3/node_modules/botbuilder-ai-orchestrator/node_modules/botbuilder-dialogs-adaptive/schemas/Actions/Microsoft.EmitEvent.schema botbuilder-dialogs-adaptive: /Users/bhiggin7/repos/CoreWithQnA_3/CoreWithQnA_3/node_modules/botbuilder-dialogs-adaptive/schemas/Actions/Microsoft.EmitEvent.schema Error conflicting definitions of Microsoft.OAuthInput.schema botbuilder-dialogs-adaptive: /Users/bhiggin7/repos/CoreWithQnA_3/CoreWithQnA_3/node_modules/botbuilder-ai-orchestrator/node_modules/botbuilder-dialogs-adaptive/schemas/Dialogs/Microsoft.OAuthInput.schema botbuilder-dialogs-adaptive: /Users/bhiggin7/repos/CoreWithQnA_3/CoreWithQnA_3/node_modules/botbuilder-dialogs-adaptive/schemas/Dialogs/Microsoft.OAuthInput.schema Error conflicting definitions of Microsoft.OnAssignEntity.schema botbuilder-dialogs-adaptive: /Users/bhiggin7/repos/CoreWithQnA_3/CoreWithQnA_3/node_modules/botbuilder-ai-orchestrator/node_modules/botbuilder-dialogs-adaptive/schemas/TriggerConditions/Microsoft.OnAssignEntity.schema botbuilder-dialogs-adaptive: /Users/bhiggin7/repos/CoreWithQnA_3/CoreWithQnA_3/node_modules/botbuilder-dialogs-adaptive/schemas/TriggerConditions/Microsoft.OnAssignEntity.schema Error conflicting definitions of Microsoft.OnChooseEntity.schema botbuilder-dialogs-adaptive: /Users/bhiggin7/repos/CoreWithQnA_3/CoreWithQnA_3/node_modules/botbuilder-ai-orchestrator/node_modules/botbuilder-dialogs-adaptive/schemas/TriggerConditions/Microsoft.OnChooseEntity.schema botbuilder-dialogs-adaptive: /Users/bhiggin7/repos/CoreWithQnA_3/CoreWithQnA_3/node_modules/botbuilder-dialogs-adaptive/schemas/TriggerConditions/Microsoft.OnChooseEntity.schema Error conflicting definitions of Microsoft.OnChooseProperty.schema botbuilder-dialogs-adaptive: /Users/bhiggin7/repos/CoreWithQnA_3/CoreWithQnA_3/node_modules/botbuilder-ai-orchestrator/node_modules/botbuilder-dialogs-adaptive/schemas/TriggerConditions/Microsoft.OnChooseProperty.schema botbuilder-dialogs-adaptive: /Users/bhiggin7/repos/CoreWithQnA_3/CoreWithQnA_3/node_modules/botbuilder-dialogs-adaptive/schemas/TriggerConditions/Microsoft.OnChooseProperty.schema Error must have a merged .schema to merge .uischema files *** Could not merge components ***

@benbrown any thoughts on this feature?


Typos in Visualize experiment runs and metrics with TB and AML

Multiple typos in code:
Typo 1
Code in:

Option 2: Export history as log to view in TensorBoard
Setup experiment
First codeblock

import azuremml.core should be import azureml.core
Typo 2
Code in:

Option 2: Export history as log to view in TensorBoard
Run experiment and log metrics
First codeblock

with root_run.child_run("alpha" + str(alpha)) as run should be with root_run.child_run("alpha" + str(alpha)) as run:

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: abae00a4-5326-f074-4270-619f151d3fbe
Version Independent ID: e6b2893d-f10e-c069-9eb6-4c5dd4b0f2bc
Content: Visualize experiments with TensorBoard - Azure Machine Learning
Content Source: articles/machine-learning/how-to-monitor-tensorboard.md
Service: machine-learning
Sub-service: core
GitHub Login: @maxluk
Microsoft Alias: maxluk

Edited to include multiple code typos

@zoekdestep Thanks for bringing this to our attention. Yes, these typos need to be corrected.
Currently, we are in a doc freeze for our upcoming MS Build event, We shall update these bugs in the document as soon as the freeze is removed.

@zoekdestep, thanks again for the catch. I've updated the typos. You should see the updates live in a few hours. I'll proceed to #please-close this issue.


fix(PeriphDrivers): Update RTC SEC and SSEC register size

Description
RTC SEC and SSEC register size is 32bit and 12bits This value is set to 8bits for MAX32670, MAX32660, MAX32672.
This commit set register size to the correct values.
Checklist Before Requesting Review

[X] PR Title follows correct guidelines.
[X] Description of changes and all other relevant information.
[ ] (Optional) Link any related GitHub issues using a keyword
[ ] (Optional) Provide info on any relevant functional testing/validation.  For API changes or significant features, this is not optional.

Links:
https://www.analog.com/media/en/technical-documentation/user-guides/max32670max32671-user-guide.pdf
https://www.analog.com/media/en/technical-documentation/user-guides/max32672-user-guide.pdf
https://www.analog.com/media/en/technical-documentation/user-guides/max32660-user-guide.pdf
Register size as per of UGs

@sihyung-maxim do we need to run the register SVD workflow for this?

/generate-register-files

Our BTM-CI is under maintenance, and the workspace is outdated. Will have to fix next week.


Create reference doc for ASP.NET Core code generation tool

Create a reference doc for the .NET Core CLI's aspnet-codegenerator tool.

Update this link and any others that use it.


Add Class type (i.e. a Record but no default values)

I want an immutable object with typed properties (TypeScript). I want something like a Record, but without default values.
In Scala we have case classes that do this. Would it be possible to add this type to immutable-js?

@OliverJAsh is this in TypeScript?
Did this comment not work out for you?

Yes, it is in TypeScript. Thanks for the link, I'm trying to make sense of it all but a lot of it is going over my head. Seems like it should be simpler?

Unfortunately I don't think this is possible, as what you're asking for is syntactic rather than library code.
A default value must always exist, because you can always do myRecord.myField and it must return something, even if that something is undefined. For example, this is totally fine:
MyRecordType = Record({   myField1: undefined,   myField2: undefined })

We have a slightly nicer syntax coming in a future version that lets you provide coercion functions rather than just default values:
https://github.com/facebook/immutable-js/commit/44b20e4168613a7d28920495115a741b20fef2b4

@OliverJAsh the immutable aspect you require does not require ImmutableJS. You can use the type checking of TypeScript to achieve the same thing (indeed there is a performance benefit to doing so).
Consider:
class A1 {
	private name: string;
	private age: number;
	private hobbies: Immutable.Set<string>;

	constructor() {
		// could set defaults here... or take parameters
		// to assign
	}

	Name(): string {
		return this.name;
	}

	SetName(v: string): A1 {
		if(v === this.name) {
			return this;
		}
		let res = this.dup();
		res.name = v;
		return res;
	}

	Age(): number {
		return this.age;
	}

	SetAge(v: number): A1 {
		if(v === this.age) {
			return this;
		}
		let res = this.dup();
		res.age = v;
		return res;
	}

	Hobbies(): Immutable.Set<string> {
		return this.hobbies;
	}

	SetHobbies(v: Immutable.Set<string>): A1 {
		if(v === this.hobbies) {
			return this;
		}
		let res = this.dup();
		res.hobbies = v;
		return res;
	}

	private dup(): A1 {
		let res = new A1();
		res.hobbies = this.hobbies;
		res.age = this.age;
		res.name = this.name;
		return res;
	}
}

let x1 = new A1();
let x2 = x1.SetName("Paul");

console.log(x1 === x2); // false
console.log(x1.Name()); // undefined
console.log(x2.Name()); // "Paul"

Here the model class A1 is "immutable" in a roughly equivalent sense to the API exposed by containers etc in ImmutableJS.
You will notice the primitive properties (string, number) can be typed as such because a string value is immutable. Array, Object etc are mutable, hence you must use an ImmutableJS container for the types of such properties (e.g. Hobbies).
If you are using the latest nightly version of TypeScript you can avoid methods for the getters and do the following:
class A1 {
	private name: string;
	private age: number;
	private hobbies: Immutable.Set<string>;

	constructor() {
		// could set defaults here... or take parameters
		// to assign
	}

	get Name(): string { // getter
		return this.name;
	}

	SetName(v: string): A1 {
		if(v === this.name) {
			return this;
		}
		let res = this.dup();
		res.name = v;
		return res;
	}

	get Age(): number { // getter
		return this.age;
	}

	SetAge(v: number): A1 {
		if(v === this.age) {
			return this;
		}
		let res = this.dup();
		res.age = v;
		return res;
	}

	get Hobbies(): Immutable.Set<string> { // getter
		return this.hobbies;
	}

	SetHobbies(v: Immutable.Set<string>): A1 {
		if(v === this.hobbies) {
			return this;
		}
		let res = this.dup();
		res.hobbies = v;
		return res;
	}

	private dup(): A1 {
		let res = new A1();
		res.hobbies = this.hobbies;
		res.age = this.age;
		res.name = this.name;
		return res;
	}
}

let x1 = new A1();
let x2 = x1.SetName("Paul");

console.log(x1 === x2); // false
console.log(x1.Name); // undefined
console.log(x2.Name); // "Paul"

@leebyron Is there any reason why 44b20e4 hasn't landed yet?

The constructor could error if not given all the specified parameters. Then if you don't have a remove method, only set, then no default values are needed to fall back on.


Meltano Test bug with files bundles

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/3190
Originally created by @pnadolny13 on 2022-01-28 19:28:42

This is based on this slack thread.
What is the current bug behavior?
What is happening now?
When I try to use the test feature with dbt I get a message saying:
Command 'test_publish_hub' could not be found. File bundle 'dbt' does not define any commands.. It looks like its iterating my plugins by name and getting to my file bundle named dbt before it gets to my transformer named dbt. If I remove the files bundle, my tests work. If I rename my files bundle I get errors.
  transformers:
  - name: dbt
    pip_url: git+https://github.com/Tomme/dbt-athena.git@c8e0458f85aaa8f9b693f99903ba95c41b90573b
    config:
      target: athena
    commands:
      test_publish_hub: test --models marts.publish.meltano_hub.*
  files:
  - name: dbt
    pip_url: git+https://gitlab.com/meltano/files-dbt.git@config-version-2

What is the expected correct behavior?
What should be happening?
The test feature shouldnt consider tests in the files plugin section. Maybe larger than that it might need to accept a plugin.plugin_name combo (i.e. meltano test transformer.dbt:test_123) if a project has multiple plugins with the same name.
Steps to reproduce
How one can reproduce the issue?
Install dbt then add a command starting with the test prefix and run meltano test dbt:test_name.
Relevant logs and/or screenshots
Please use code blocks (```) to format console output
Possible fixes
If you can, link to the line of code that might be responsible for the problem or suggest a fix
Further regression test
Ensure we automatically catch similar issues in the future

[ ] Write additional adequate test cases and submit test results
[ ] Test results should be reviewed by a person from the team

View 9 previous comments from the original issue on GitLab


no credits?

uh? i've added all credits

for momentum?

for momentum? it's clearly momentum athena.json

it seems like your iq its on the ground, you dont understand, momentum took the athena file from lawinv2 so its the same thing, he just took the one from momentum so it has different loadouts.

for momentum? it's clearly momentum athena.json

your iq is 0 right?
it doesnt matter if he took the athena file from momentum, its the same thing as lawinv2 athena file, actually, momentum took lawin's athena file...

okay, but MOMENTUM have credits to lawin, but Reload stole from momentum, and gave no credits, mr retard

bro if momentum gave credit to lawin because they used their defaultprofiles then I don't have to give any credit to momentum if the files are original from lawin


refactor: android timepicker use .Hour|Minute instead of .Current[Hour|Minute]

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
refactor
What is the current behavior? (You can also link to an open issue here)
.Current[Hour|Minute] is used in the prayer to the linker gods and also in the WidgetsObservables. These two properties have been [Obsoleted].
What is the new behavior (if this is a feature change)?
Use .Hour|Minute instead.
https://developer.android.com/guide/topics/ui/controls/pickers.html
https://developer.xamarin.com/guides/android/user_interface/time_picker/
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements

[x] The commit follows our guidelines: https://github.com/reactiveui/reactiveui#contribute
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

Other information:

Looks fine to me.