[XLA] Move some useful Literal conversion code into LiteralUtil

This code looks like it should be in LiteralUtil.  It is useful to have it there for our backend, and probably also for allowing literals to be created with explicit types to the constant data type.

Can one of the admins verify this patch?

@tensorflow-jenkins test this please

Passing this back to @hawkinsp to merge.

@tensorflow-jenkins test this please

I notice dnovillo has made a significant change to the LiteralUtil class recently.  he/she should probably be aware of this change.

ok - this one seems good to merge

it would be really useful to merge this one today.  this evening i will try to fix the F16 support in LiteralUtil, and we might end up with two different merges which both modify the same files.

@hawkinsp this looks good to merge. I've pinged dnovillo to take a look as well.

So, this change is actually going in the opposite direction it should've gone.  LiteralUtil is on the way out.  I'm working on a patch that is getting rid of it.
It's not a big deal that this change is in, but note that I will be moving the new code inside xla::Literal.

awesome, thanks guys.  will submit the f16 fix as soon as I can (later tonight as i have to be a taxi driver now)

I am sorry -- I did merge this. I made a revert but it sounds like that's probably not worth it, so I'll get rid of that.

Yup, no worry about this one.  I'll roll it up with my patch to get rid of
LiteralUtil.
On Tue, Jun 13, 2017 at 12:52 PM, Kay Zhu<EMAIL_ADDRESS>wrote:

@martinwicke https://github.com/martinwicke no worries -- @dnovillo
https://github.com/dnovillo mentioned he will be merging it once it's
synced downstream. Thanks for the merge!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/pull/10164#issuecomment-308228151,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AG9RZ1fjTNY2e0yiQer0C0OlwUd37gKJks5sDuhkgaJpZM4NlVXA
.


[rmw_connext_dynamic] fix cleanup functions

In #45 various clean up functions have been introduced. In various tests (e.g. in test_rclcpp) these functions print error messages:
Error in destruction of rmw publisher handle: failed to delete contained entities for publisher, at ...
Error in destruction of rmw subscription handle: failed to delete subscriber, at ...

I guess I didn't notice the output of the tests since they were passing. I would expect that to cause a failure (return code != 0 or exception) since those messages occur the rmw_*_destroy functions. Probably they're being checked in a C++ destructor and being printed to the screen rather than throwing to avoid throwing in a destructor.

I'm running into an issue where a test case that initializes services/clients in a gtest with prior cases with pub/sub does not send any messages. This may be related, so I'm going to investigate cleanup issues in rmw and see if it helps.

Furthermore the Connext typesupport  does currently not provide any destroy functions for servers / clients.

Closing, since with Foxy now being End-of-Life, this repository is no longer used.


tdqm monitoring not working

i think ima just do print statements who really needs more than that

saw that task ids printed to console didn't match those in redis. Clearing celery queue on exit fixed it


optparse to argparse

Reference Issue
Fixes #1778
What does this implement/fix? Explain your changes.

args = parser.parse_args(), from (options, args) = parser.parse_args()
add_option -> add_argument, and related parameters, such as type, version
options.() -> args.()
changes to %s or %d, as %(s)s and %(d)s respectively

Any other comments?
In CreateDb.py and SearchDb.py:

Need to check on additional parser.add_argument() calls for positional arguments
In SearchDb.py:
Need to check %.1f, %.3f, %%%.3f for modifications as per the %(s)s style

HI @pikulsomesh
Thanks for submitting this. Before I do a more detailed review: you can see that the Travis CI build failed. Looking at the details there, you'll see that this is because the tests for DbCLI failed; this is likely due to one or more mistakes in your code. Those should be fixed.
If you are doing your development from within a working RDKit install, you can run these test yourself by doing python TestDbCLI.py inside the $RDBASE/Projects/DbCLI directory.

Hi Greg
Thanks, I will do that, and make necessary modifications.
ᐧ
Somesh Mohapatra
Graduate Student (Fall 18)
Department of Materials Science and Engineering
Massachusetts Institute of Technology
Contact - +91 7060 33 45 66
E-Mail -<EMAIL_ADDRESS>Website - someshmohapatra.in
On Thu, Mar 15, 2018 at 1:06 PM, Greg Landrum<EMAIL_ADDRESS>wrote:

HI @pikulsomesh https://github.com/pikulsomesh
Thanks for submitting this. Before I do a more detailed review: you can
see that the Travis CI build failed. Looking at the details there, you'll
see that this is because the tests for DbCLI failed; this is likely due to
one or more mistakes in your code. Those should be fixed.
If you are doing your development from within a working RDKit install, you
can run these test yourself by doing python TestDbCLI.py inside the
$RDBASE/Projects/DbCLI directory.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/rdkit/rdkit/pull/1779#issuecomment-373287070, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AHwUua_RXn3nJZd80_yZOUwLiaqJuye_ks5tehnwgaJpZM4SrfRJ
.

@gedeck Changed args to options, at all positions.
Got some issues with the block - if __name__ == '__main__':, where options and args are used, as per optparse.

This was finished with #1835


Bot will repeatedly set trunk as affected if we fix an issue via a pref-flip and represent that as firefoxN: disabled

If a bug is resolved as FIXED by turning off a pref, and we encode that in Bugzilla status flags by setting the status firefoxN to disabled (where N is current trunk), then we get into a state where bugbot will mark firefoxN+1 to affected (and firefoxN+2, etc) when that version becomes trunk.
See for example https://bugzilla.mozilla.org/show_bug.cgi?id=1894614#c17 where this happened , and explanation in https://bugzilla.mozilla.org/show_bug.cgi?id=1894614#c19
This isn't a great situation to end up in.
We probably want to prevent this from happening, maybe by:
(1) Making the bot recognize this situation and not do anything.
or:
(2) having the bot detect this special situation and notify someone (assignee or triage owner) with a comment like the following (hastily written, please don't use this exact text :))
"Bug has been closed, but no version got a status fixed, so the assumption is that future Firefox versions should automatically be marked as affected. This is probably a mistake - should some Firefox version have a fixed status?"

(2) having the bot detect this special situation and notify someone (assignee or triage owner) with a comment like the following (hastily written, please don't use this exact text :))
"Bug has been closed, but no version got a status fixed, so the assumption is that future Firefox versions should automatically be marked as affected. This is probably a mistake - should some Firefox version have a fixed status?"

Or maybe more generally:
(3) have the bot detect and nag about a broader situation that includes this scenario, i.e. bugs that affected some version that were closed as fixed but never had any version flagged as fixed. Wording for the nag might be along these lines:
"Bug is flagged as affecting some version, and was closed as FIXED, but no versions were set to status fixed (or verified). Could you set the status flag to fixed for the version where the fix landed, so we can reason about at-which-point future versions can also be implicitly considered fixed?"

See also: https://github.com/mozilla/bugbot/issues/1535

In such a scenario, the bug should probably show up for the release managers during their regression triage, and they can flag it as fixed when appropriate.
@rvandermeulen what do you think?

Right, but that won't happen until after the bot has intervened to (incorrectly) mark e.g. status-firefox128 as affected, which then requires folks to notice, figure-out-why-the-bot-did-that, and then clean up after it by resetting that flag and then resetting some earlier flag to the state that the bot was expecting.
That feels sub-optimal.

(You're correct that it does show up on the release-manager regression-triage-list, and for now would be cleaned up by that team manually. The reason I noticed this issue in the first place because I'm part of the release manager regression-triage meeting for the 128 release cycle, and I happened to notice the bug-in-question here in an early on-my-own skim of part of the bugs-to-be-triaged.  In my (limited) experience with the release-manager regression-triage-meetings so far, I'm noticing the meeting is quite time-constrained and doesn't always make it through the full bug list -- so if we can avoid making bugs unnecessarily show up in the lists there, it leaves more time for the folks in that meeting to get further in the list to other bugs that may actually need attention.)

That feels sub-optimal.

I totally agree. I want first to confirm with release managers that ignoring setting the flag for such cases would not unwanted impact any of their workflows/queries.

Discussed it with the team and TBH we don't have very strong opinions on this. We can see situations where a false positive could occur with or without this change. But overall, maybe it doesn't make sense to make statusN+1 flag changes to bugs that are set to RESOLVED/VERIFIED? I can see the use case for statusN-1 around uplifts, but what's the case higher release versions?

FWIW:  I'm not necessarily suggesting that the bot not-set-the-flag in this situation.
I lean more towards just catching the situation earlier (around when the bug is closed) and poking the assignee to update the status flags at that point, if appropriate, per my suggested option (3) above ( https://github.com/mozilla/bugbot/issues/2403#issuecomment-2123029283 ), if the bot sees that the bug is closed and yet it can predict that it's going to mark future versions as affected.


ImportError of speech_to_text example

🐛 Bug
Hi,
Run cmd python3 ./examples/speech_to_text/prep_librispeech_data.py --output-root ./data
During the example, the following error occurs when performing the prep_librispech_data.py of speech_to_text:

I think we should import "convert_to_mono" instead of "_convert_to_mono" to fairseq.data.audio.utils.
https://github.com/pytorch/fairseq/blob/1f7ef9ed1e1061f8c7f88f8b94c7186834398690/examples/speech_to_text/data_utils.py#L17-L19
https://github.com/pytorch/fairseq/blob/1f7ef9ed1e1061f8c7f88f8b94c7186834398690/examples/speech_to_text/data_utils.py#L81
Environment

fairseq Version (e.g., 1.0 or master): 1.0
PyTorch Version (e.g., 1.0): 1.9.0
OS (e.g., Linux): Linux
How you installed fairseq (pip, source): pip
Build command you used (if compiling from source):
Python version: 3.8.8
CUDA/cuDNN version: 11.2/8.1

This is a bug in code, just change _convert_to_mono in fairseq/examples/speech_to_text/data_utils.py to convert_to_mono, it works fine

Thanks for reporting the bug! Please pull our latest code for a fix.


Unhelpful --strictFunctionTypes error when first method is self(): this;

TypeScript Version:  2.7.0-dev.20171214
Code
declare class C<T> {
    self(): this;
    covariant(): T;
    contravariant: (t: T) => void;
    m(other: C<{}>): void;
}

new C<number>().m(new C<number>());

Expected behavior:
Error that C<number> isn't C<{}> because C<{}>'s contravariant can accept (t: {}) but C<number> can only accept (t: number).
Actual behavior:
src/a.ts(8,19): error TS2345: Argument of type 'C<number>' is not assignable to parameter of type 'C<{}>'.
  Types of property 'self' are incompatible.
    Type '() => C<number>' is not assignable to type '() => C<{}>'.
      Type 'C<number>' is not assignable to type 'C<{}>'.

it's strange incompatibility error too.
TypeScript Version:  2.6.2
Search Terms:  strange incompatibility
Code
class Relation {
  public code: string;
  public name: string;

  constructor(name: string, code: string) {
    this.code = code;
    this.name = name;
  }

  public static defineRelation(
      eType: { new (name: string, code: string): Relation },
      code: string,
      name: string) {
    return (msg: string) => {
      return new eType(name, code);
    };
  }

  public static defineRelation2(
      code: string,
      name: string,
      eType: { new (name: string, code: string): Relation }) {
    return (msg: string) => {
      return new eType(name, code);
    };
  }
}

function defineCommonRelation2(name: string) {
  return class extends Relation {
    public static defineRelation2(code: string) {
      return Relation.defineRelation2(code, name, this);
    }
  };
}

function defineCommonRelation(name: string) {
  return class extends Relation {
    public static defineRelation(code: string) {
      return Relation.defineRelation(this, code, name);
    }
  };
}

Expected behavior:
defineCommonRelation2, defineCommonRelation should both be ok.
Actual behavior:
defineCommonRelation is not work.
this error is
testDefine.ts(30,10): error TS2417: Class static side 'typeof (Anonymous class)' incorrectly extends base class static side 'typeof Relation'.
  Types of property 'defineRelation' are incompatible.
    Type '(code: string) => (msg: string) => Relation' is not assignable to type '(eType: new (name: string, code: string) => Relation, code: string, name: string) => (msg: string...'.
      Types of parameters 'code' and 'eType' are incompatible.
        Type 'new (name: string, code: string) => Relation' is not assignable to type 'string'.

@killagu I think that example is working as intended. TypeScript checks that overridden static methods conform to the base signature.
When you override defineRelation2, you are overriding a function of type (code: string, name: string, eType: { new (name: string, code: string): Relation }): (msg: string) => Relation with one of type (code: string): (msg: string) => Relation. This is valid since the latter is a subtype of the former -- it just ignores the two extra parameters.
When you override defineRelation, you override a function of type (eType: { new (name: string, code: string): Relation }, code: string, name: string): (msg: string) => Relation with one of type (code: string): (msg: string) => Relation. This is no longer valid as the types of the first parameters no longer match -- someone would pass in a { new (name: string, code: string): Relation } but you're expecting to get a string at that position.

@andy-ms thank you for the answer.


Update DG on implementation of MatchTest

Pull Request Test Coverage Report for Build 356

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 86.925%

Totals

Change from base Build 393:
0.0%

Covered Lines:
2041

Relevant Lines:
2348

💛  - Coveralls

Pull Request Test Coverage Report for Build 403

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 86.925%

Totals

Change from base Build 393:
0.0%

Covered Lines:
2041

Relevant Lines:
2348

💛  - Coveralls


Update README.md

Include examples for user settings use.

Made this more clear in #43
Thanks @rdacdx @Nyholm :+1:


Mountpoint crashes on reading 1 byte file

Mountpoint for Amazon S3 version
mountpoint-s3 0.2.0-70b2b68
AWS Region
eu-west-1
Describe the running environment
Running in EC2 on Amazon Linux 2 using instance profile credentials against an S3 bucket in the same account.
Also same happened on on my Mac using instance profile credentials against an S3 bucket.
What happened?
Mountpoint is constantly crashing when trying to read a 1 byte file. Tried it on several such objects. When they are  wriiten to a file using getObject s3api CLI command, output the following result -
.% (where % is highlighted).
I am attaching the trace logs. Prefetcher is able to find the correct range and also finishing the rpefetching task. But it stops working after that.
Relevant log output
2023-04-21T16:40:51.019337Z TRACE getattr{req=5 ino=5}: mountpoint_s3::fs: fs:getattr with ino 5
2023-04-21T16:40:51.019471Z TRACE open{req=2 ino=5}: mountpoint_s3::fs: fs:open with ino 5 flags 0
2023-04-21T16:40:51.019742Z TRACE read{req=6 ino=5 fh=1 offset=0 size=1}: mountpoint_s3::fs: fs:read with ino 5 fh 1 offset 0 size 1
2023-04-21T16:40:51.019770Z TRACE read{req=6 ino=5 fh=1 offset=0 size=1}: mountpoint_s3::prefetch: read offset=0 length=1 next_seq_offset=0
2023-04-21T16:40:51.019789Z TRACE read{req=6 ino=5 fh=1 offset=0 size=1}: mountpoint_s3::prefetch: to_read=1
2023-04-21T16:40:51.019812Z TRACE read{req=6 ino=5 fh=1 offset=0 size=1}: mountpoint_s3::prefetch: spawning request range=0..1 size=1
2023-04-21T16:40:51.020002Z DEBUG read{req=6 ino=5 fh=1 offset=0 size=1}:prefetch{range=0..1}:get_object{id=21}: mountpoint_s3_client::s3_crt_client::get_object: new request bucket="plutotestankit" key="test/test_sdk_create_object/14899866888963238197/hello" range=Some(0..1) if_match=Some(ETag { etag: "\"5058f1af8388633f609cadb75a75dc9d\"" }) size=Some(1)
2023-04-21T16:40:51.250506Z DEBUG read{req=6 ino=5 fh=1 offset=0 size=1}:prefetch{range=0..1}:get_object{id=21}: mountpoint_s3_client::s3_crt_client: request finished request_id="GQNFMC3TRQWP8DJS" duration_us=230374
2023-04-21T16:40:51.250735Z TRACE read{req=6 ino=5 fh=1 offset=0 size=1}:prefetch{range=0..1}: mountpoint_s3::prefetch: finished

(It stops after this and crashes)

Issue fixed since merging #228.
Also added regression tests (#231) and improved error handling (#233).


Nicer web app icon that works better with the main theme colour in the app switcher

A white shopping cart with a black border would be ideal.

Fixed with 74d82ac3091523638fa86257529358e87e8e7123


Transcluded images with set size overflow on mobile devices

A transcluded image with a set size suitable for a desktop device can overflow on mobile devices, however since there's no horizontal scroll, there's no way to view the overflowing part of the image.
Would a CSS tweak which sets an image max width of the parent element be a sensible decision?
Example: https://notes.thatother.dev/physics/altitude-analogy
EDIT: This appears to happen when there's no fixed size set as well - it seems to be a problem for all transcluded images which are too large for the viewport.

Works flawlessly, thank you!


⚠ Bofrost.at has degraded performance

In c9dd67a, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2448 ms

Resolved: Bofrost.at performance has improved in e00ec03.


debezium upgrade

Search before asking

[X] I had searched in the feature and found no similar feature requirement.

Description
When does the community plan to upgrade the debezium version?
Usage Scenario
The debezium in flink-cdc has been upgraded to 1.9.7. The flink cdc community describes this version as a performance improvement. Seatunnel can imitate flink cdc to upgrade the debezium version.
Related issues
No response
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Yes, upgrade debezium is needed, we need to dive into , and do some test.


Increment version for C SDK releases

Increment sdk version after release of C SDK

This isn't correct due to the date issue:
https://github.com/Azure/azure-sdk-for-c/pull/1914


[Bug Report]  EXHSCAN command syntax error

exec EXHSCAN command return ERR syntax error

This is a documentation error not a code bug. The syntax of exhscan is fully compatible with the syntax of redis hash now. We have corrected the documentation. Thanks for your report.

thank for you reply.

This is a documentation error not a code bug. The syntax of exhscan is fully compatible with redis hash now. We have corrected the documentation. Thanks for your report :).

hi, i found exhscan is not fully compatible hscan about response body.
hscan return the first array type is String and  exhscan return is Long.
it will cause exception when usage lettuce decode response,
because MapScanOutput cann't decode number (integer) response values

@jjz921024 Hello, I understand your question. Can you provide your complete code so that we can reproduce this problem quickly?

@yangbodong22011  I just want to extend lettuce api for support TairHash command.
Except of EXHSCAN, other commands is finish.
The problem is exhscan reponse must be decode ArrayList<Object> that is not friendly for user.
It should compatible with hscan command in lettuce implement,
// it ok, but not friendly
List<Object> exHScan1(K key, ScanCursor scanCursor, ScanArgs scanArgs);

// compatible with hscan API, but is will throw exception because of can't decode long
MapScanCursor<K, V> exHScan2(K key, ScanCursor scanCursor, ScanArgs scanArgs);

I have create a repo for this demo
https://github.com/jjz921024/redis-client-demo

@yangbodong22011 I just want to extend lettuce api for support TairHash command.
Except of EXHSCAN, other commands is finish.
The problem is exhscan reponse must be decode ArrayList<Object> that is not friendly for user. It should compatible with hscan command in lettuce implement,
// it ok, but not friendly
List<Object> exHScan1(K key, ScanCursor scanCursor, ScanArgs scanArgs);

// compatible with hscan API, but is will throw exception because of can't decode long
MapScanCursor<K, V> exHScan2(K key, ScanCursor scanCursor, ScanArgs scanArgs);

I have create a repo for this demo https://github.com/jjz921024/redis-client-demo

Yes, there is indeed an incompatibility here, I have fixed it, the PR is #11


[release-1.15] istioctl x proxy-status via istio agents. (#40623)

Manual cherry pick https://github.com/istio/istio/pull/40623.

@ingwonsong: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ingwonsong: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ds_istio
dced97ecc838f1eb7e9bf3451acd520449e75800
link
true
/test integ-ds

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ingwonsong: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ds_istio
dced97ecc838f1eb7e9bf3451acd520449e75800
link
true
/test integ-ds

integ-ipv6_istio
dced97ecc838f1eb7e9bf3451acd520449e75800
link
true
/test integ-ipv6

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ingwonsong: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ds_istio
dced97ecc838f1eb7e9bf3451acd520449e75800
link
true
/test integ-ds

integ-ipv6_istio
dced97ecc838f1eb7e9bf3451acd520449e75800
link
true
/test integ-ipv6

integ-pilot-multicluster_istio
dced97ecc838f1eb7e9bf3451acd520449e75800
link
true
/test integ-pilot-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ingwonsong: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ds_istio
dced97ecc838f1eb7e9bf3451acd520449e75800
link
true
/test integ-ds

integ-ipv6_istio
dced97ecc838f1eb7e9bf3451acd520449e75800
link
true
/test integ-ipv6

integ-pilot-multicluster_istio
dced97ecc838f1eb7e9bf3451acd520449e75800
link
true
/test integ-pilot-multicluster

integ-pilot-istiodremote_istio
dced97ecc838f1eb7e9bf3451acd520449e75800
link
true
/test integ-pilot-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ingwonsong: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ds_istio
dced97ecc838f1eb7e9bf3451acd520449e75800
link
true
/test integ-ds

integ-ipv6_istio
dced97ecc838f1eb7e9bf3451acd520449e75800
link
true
/test integ-ipv6

integ-pilot-multicluster_istio
dced97ecc838f1eb7e9bf3451acd520449e75800
link
true
/test integ-pilot-multicluster

integ-pilot-istiodremote_istio
dced97ecc838f1eb7e9bf3451acd520449e75800
link
true
/test integ-pilot-istiodremote

integ-pilot-istiodremote-mc_istio
dced97ecc838f1eb7e9bf3451acd520449e75800
link
true
/test integ-pilot-istiodremote-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Custom module frequently breaks all tooltips

Using latest Waybar / Sway on Arch.
I added a custom module that runs an endlessly looping script. I've noticed that if the script outputs an update frequently, say every 0.6s, all Waybar tooltips stop working and won't appear when I hover the mouse over anything. This happens even if the script doesn't output a tooltip and the module is customed with "tooltip": "false".
Example config:
    "custom/cpu": {
        "exec": "/home/jordan/.config/waybar/cpu_graphical 0.6",
        "format": " {} ",
        "tooltip": true,
        "return-type": "json",
        "on-click": "lxtask"
    },

Script: https://github.com/JordanL2/LinuxSetup/blob/master/Sway/config/waybar/cpu_graphical

I'm guessing this is because tooltips have a delay before they appear, and the module updating resets the timer.

I submitted a patch that partially fixes this issue.

Closed by #905


unable to be used from CocoaPods

When used via CocoaPods, the Notepad.framework is built and included, but the individual classes aren't able to be used. For example, import Notepad works just fine, but you can't use the Notepad class in code. Perhaps this is because there is no framework header?
This is in a Swift 3.0 project. I maintain frameworks of my own (e.g. Mapbox-iOS-SDK) so I'm fairly familiar with the process here, though I could be making a dumb mistake.
The pod try Notepad example just has the Notepad.swift etc. files included directly in its own module, which is why it works.

Hey, thanks for the note! Can you link me to an example of a framework header, and I can create one? Or, alternatively you could open up a pull request?

Sure, it should just be as simple as something like this:
https://github.com/mapbox/MapboxGeocoder.swift/blob/master/MapboxGeocoder/MapboxGeocoder.h
In this project's case, maybe:
#import <UIKit/UIKit.h>

FOUNDATION_EXPORT double NotepadVersionNumber;

FOUNDATION_EXPORT const unsigned char NotepadVersionString[];

All of the Swift files should be included automatically since they are part of the module.
I'm not 100% positive this will solve the problem, but I think it should. I will try to experiment more.

Great, thanks! Let me know what you find, and happy to merge anything in — it doesn't hurt to have a framework header regardless!

This was a red herring, since CocoaPods provides an umbrella header file and creates all pods as frameworks.
The real problem is that per http://stackoverflow.com/a/37089794/977220 the Notepad class isn't public by default outside of the framework. Again, it works in your example since the Notepad.swift file is present in the same module as the app.
I'll submit a PR for this. It gets complicated when you try to use a Notepad in IB, since you can't later set the themeFile in code. Making Storage also public is one fix, but that requires a bunch of other stuff be made public as well.
One idea I have here is to introduce a safe setter for themeFile on Notepad so we don't have to expose Storage, but that introduces concurrency issues with setting the themeFile on a Notepad after it's already been rendered once.
¯\_(ツ)_/¯ coding

Another issue here is that Theme refers to Bundle.main.path to find its JSON resources, yet the main bundle is actually the user's app, not the Notepad.framework. I have a fix for this as well.

Awesome, thanks. Yeah — I definitely am going to implement something with IBInspectables/IBDesignables going forward, but feel free to hack away! Looking to build this out so it's extra flexible (roadmap may include loading themes from online, who knows what the future holds).
Regarding exposing Storage, I agree with you. I found it difficult to work with NSTextStorage and the safety of Swift, in terms of the order of initialization in classes. I used a different approach in RFMarkdownTextView that I could get away with as it was Objective-C.

Also, debating between themeFile and theme as the variable. Thoughts?

theme implies a Theme will be passed, which you might also prefer to keep private. themeFile, themeName, or themePath implies a String (in the latter case, allowing you to pass your own full JSON path).

I agree - just checking because I hate camel case ¯_(ツ)_/¯.

Just FYI I will still get to this, but my needs for a project changed and I'm not actively blocked by this anymore so it'll be a little later on. That said this is the best-looking GUI-based Markdown renderer I've seen and I'd like to help tune it up for possible future use!

@incanus do you have the header for CocoaPods in git already? Because if not I have some time on my hands now and can clean some stuff up. Just let me know!

The header isn’t necessary—CocoaPods makes one for you when it packages your project as a dynamic framework.

Ah - so just adding public should work. Do I have to do that for every class?

Fixed by 6a9e702eb72c630d6f770ee0b5d05a095416fb73.


fix(ic-asset): .ic-assets.json allow_raw_access overrides

Description
.ic-assets.json: "allow_raw_access" default overrides previous config entries even if not present in a match entry. This fixes the issue.
  Jira ticket description

Consider the following .ic-assets.json file.
[
	{
		"match": "**/favicons/**/*",
		"allow_raw_access": true
	},
	{
		"match": ".well-known",
		"ignore": false
	},
	{
		"match": "**/*",
		"headers": {
			"X-Frame-Options": "DENY",
			"X-Content-Type-Options": "nosniff",
			"Strict-Transport-Security": "max-age=31536000; includeSubDomains",
			"Referrer-Policy": "same-origin",
			"X-XSS-Protection": "1; mode=block"
		}
	}
]

If there is a file in the favicons/ directory, we would expect its allow_raw_access setting to be true.
However, the "match": "**/*" section also matches for files in the favicons/ directory.  Even though the configuration does not specify a value for allow_raw_access, a default of false is assumed.
So given the above configuration, the actual property seen for allow_raw_access is false.
Note: the default value of allow_raw_access has changed from false to true in dfx 0.14.4 and later, so the problem won’t present exactly the same.
A fix is to reorder the configuration, to put the favicons directory match at the end:
[
	{
		"match": ".well-known",
		"ignore": false
	},
	{
		"match": "**/*",
		"headers": {
			"X-Frame-Options": "DENY",
			"X-Content-Type-Options": "nosniff",
			"Strict-Transport-Security": "max-age=31536000; includeSubDomains",
			"Referrer-Policy": "same-origin",
			"X-XSS-Protection": "1; mode=block"
		}
	},
	{
		"match": "**/favicons/**/*",
		"allow_raw_access": true
	},
]

However, note that there could be similar problems with other default settings.
Expected behavior: No matter the order of the above configuration, files in the favicons/ directory (in this example) should have allow_raw_access true.  Since the "match": "**/*" configuration section does not contain allow_raw_access, it should not affect the configuration of that value.

Fixes https://dfinity.atlassian.net/browse/SDK-1238
How Has This Been Tested?
unit test
Checklist:

[x] The title of this PR complies with Conventional Commits.
[x] I have edited the CHANGELOG accordingly.
[ ] ~I have made corresponding changes to the documentation.~

I pasted the content of jira ticket into pr description

I pasted the content of jira ticket into pr description

I appreciate the effort, but unfortunately it's not sufficient in this case.
The JIRA ticket describes a problem. Its purpose is to describe that problem in enough detail that the assignee can understand what's being asked for, and hopefully reproduce the problem.  It doesn't describe the cause of the problem because it can't: the cause isn't known at the time of writing of the JIRA ticket.
The PR description should describe the change and the reasoning behind it.   The PR author should understand their change well enough to describe what they did and why.  The PR description should give reviewers an idea of what they are looking at.  A succinct yet complete PR description will also demonstrate to reviewers that the PR author understands their own change.

Dear @smallstepman,
In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA.
If you decide to agree with it, please visit this issue and read the instructions there. Once you have signed it, re-trigger the workflow on this PR to see if your code can be merged.
— The DFINITY Foundation

Replaced by https://github.com/dfinity/sdk/pull/3635


[Diagnostics] Improve diagnostics related to pointer initialization

Increase impact of a generic pointer-to-pointer mismatch fix to
match that of a contextual type failure. This allows more specific
fixes to take precedence.

De-prioritize generic argument mismatch fix when both types are
pointers. This allows pointer-to-pointer conversion produce a
more specific fix.

De-prioritize fixes that involve Builtin.RawPointer or OpaquePointer
in parameter positions. This helps to produce better diagnostics
for argument mismatches during pointer initialization e.g.
UnsafeRawPointer(<pointer>).

This is related to diagnostics for new Swift -> C pointer conversions, today they'd just get dropped because generic fixes have a much lower impact...

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - beb23718f8dd263d96d160185fcf9b5daa75bedf

@swift-ci please clean test macOS platform

Build failed
Swift Test OS X Platform
Git Sha - beb23718f8dd263d96d160185fcf9b5daa75bedf

@swift-ci please test macOS platform


Python/PyTorch Version

I was wondering if you would be releasing an adapted version with a newer python and pytorch version, or if you had any better alternatives other than having to install older versions of both?

Actually, you can use the latest versions of Python and PyTorch (I tried the newest PyTorch), and it will work.
The installation instructions we provided match our experimental environment. We did this to fully replicate our results.

您好 请问依赖库中的torch==1.9是可以换成更新版本吗 这不影响吧

可以，没有影响。
实验中采用的是torch==1.9，为了完全复现结果，所以设torch==1.9。
其他版本torch，性能差距不大。


remove checked by default attribute on personal information section

Ppl should explicitly agree to sharing their more personal information with us. So the checkbox asking for consent to publish more personal information should be unchecked by default.

closed by #24


Crash when starting capture in UE5.2

Hi, I add this plugin into my project and set the start capture funtion when the game starts. It will crash and the callstack is below.
LoginId:ee59dbdb47407b5f9a3a199aa4238aae
EpicAccountId:f226dda7fb214bd9b9c0bd4f67d8202e
Unhandled Exception: EXCEPTION_ACCESS_VIOLATION reading address 0x0000000000000088
avformat_59
avformat_59
avformat_59
UnrealEditor_CaptureSubsystem!UCaptureSubsystemDirector::Create_Video_Encoder() [E:\FProjects\UEProj\Study03\Plugins\UE_CaptureSubsystem\Source\CaptureSubsystem\Private\CaptureSubsystemDirector.cpp:531]
UnrealEditor_CaptureSubsystem!UCaptureSubsystemDirector::CreateEncodeThread() [E:\FProjects\UEProj\Study03\Plugins\UE_CaptureSubsystem\Source\CaptureSubsystem\Private\CaptureSubsystemDirector.cpp:326]
UnrealEditor_CaptureSubsystem!UCaptureSubsystemDirector::OnBackBufferReady_RenderThread() [E:\FProjects\UEProj\Study03\Plugins\UE_CaptureSubsystem\Source\CaptureSubsystem\Private\CaptureSubsystemDirector.cpp:205]
UnrealEditor_CaptureSubsystem!TBaseUObjectMethodDelegateInstance<0,UCaptureSubsystemDirector,void __cdecl(SWindow &,TRefCountPtr const &),FDefaultDelegateUserPolicy>::ExecuteIfSafe() [E:\DevTools\UE5\UE_5.2\Engine\Source\Runtime\Core\Public\Delegates\DelegateInstancesImpl.h:552]
UnrealEditor_SlateRHIRenderer
UnrealEditor_SlateRHIRenderer
UnrealEditor_SlateRHIRenderer
UnrealEditor_Core
UnrealEditor_Core
UnrealEditor_RenderCore
UnrealEditor_RenderCore
UnrealEditor_Core
UnrealEditor_Core
kernel32

Hello author, I found the cause of the crash, it is because I used "Get recommend video file name". If I specify to write to a certain file, then there is no problem, but if I don't specify, it will still crash. Is there anyway to fix? Thank you.

Based on your country I think there can be a folder name with non English names in the path and that can also cause the crash !

Few things to check

print the result of  Get recommend video file name and see if the path seems to be correct (but don't begin capture so it doesn't crash)
See if the game has permission to write at that path
You can make your own file path algorithm ( for example save videos at the project folder )

Thanks，I will check it.

I found out that the Capture folder must exist in My Documents.


Add a redirect from /nbclassic to /nbclassic/tree if both notebook>=7 if both notebook>=7 and nbclassic are installed

Fixes https://github.com/jupyter/nbclassic/issues/163

@mcrutch this is ready for review

LGTM! Thank you both @echarles and @mcrutch!


Support publishing to npm automatically?

Web Assembly is awesome and portable. Let's get this language into developer hands in the browser, node and maybe deno via emscripten.
Let's use this thread for discussion.

For onlookers, wren runs via emscripten right here https://wren.io/try/
I've got work going on a project/ folder that would build with minimal config (i.e where is emsdk?) and output some sensible default builds, making it easy to get a build for inclusion elsewhere.

so one relevant question is what does the npm module actually contain.

I was imagining the prebuilt Web Assembly source and to go with that a nice JS API wrapper... to make hosting Wren inside JS apps as easy as it is hosting it inside a C codebase, etc.  Obviously some of this work is done already since it works on the website.


Feature flag to allow null ledger data in responses

This PR is a quickfix for #650 (and #538, #649). It introduces a new feature flag ALLOW_EMPTY_LEDGER_DATA_RESPONSES (default: false). When set to true it renders unavailable ledger data (like close_time) as null instead of sending 500 Internal Server Error response. This is not a breaking change as the default value is false. It can be released in 0.14.1 patch release.

Had to rebase because of the conflict. Thanks for 2nd 👍 .


用echats的line3D画多条频谱曲线的瀑布图，鼠标悬浮显示tooltip的时候取到和显示的总是其中一组数据的值而不是当前数据点的值

用于工业互联网机器故障智能诊断传感器波形图
Version
4.2.1
Steps to reproduce
下面的代码里我放入了自己的频谱数据，可以直接放到https://www.echartsjs.com/examples/zh/editor.html?c=line3d-orthographic&gl=1 官方实例line3d的编辑器里运行看到效果，这里我只放了两条频谱数据，一条y=0，一条y=1，运行时可以看到无论鼠标移到哪一条数据上，显示的都是y=1的那一组数据，而不是当前点的数据，放更多条比如10条时也是一样的现象，而且发现tooltip显示的y总是我data里第一条数据的y，请问这是bug吗？还是我哪里配置的不对？


Fix permissions and minor updates

I'm curious about the permission changes.  Is this something we need to do periodically as new icons are added to themes?

Is this something we need to do periodically...

it should not be needed, just don't make regular files executable

I had no idea I was setting the files executable in the first place.  My workflow is to create the source PDF on a Mac and then use the script you made for me via a Linux Mint VM to batch create the SVGs and a Imagemagik mogrify command to make the PNGs.  I never could quite get the script to work right for me on the Mac but the VM workflow has served me well.
If I were to get in the habit of running chmod -R 666 as part of my workflow, either by adding it to the script or by command, I assume that would that take care of the issue.


TenantProfileCacheRecords is null

Describe the bug
Creation of LoadlAuthenticationResult fails at this line because tenantProfileCacheRecords is null:
    final List<ICacheRecord> tenantProfileCacheRecords = brokerResult.getTenantProfileData();
    final LocalAuthenticationResult authenticationResult = new LocalAuthenticationResult(
                tenantProfileCacheRecords.get(0),
                tenantProfileCacheRecords,
                SdkType.MSAL
        );

I checked the response json used to create brokerResult and it doesn't have a tenant profile field.

Device: OnePlus 7
Android Version: 9
Browser: Using from a Unity app
MSAL Version: 1.0.0-RC9, Common @ 1.0.3

To Reproduce
Login to an Azure AD v2 app using a personal account. Potentially exists in other cases as well, but this is the only case I've tested till now, and kinda makes sense since a personal account doesn't have any tenant data associated with it?
Edit: Tried this with a work account and the same issue exists :(

On further investigation this only happens when a broker app is present. I solved it by setting "broker_redirect_uri_registered" to false in config. On a side note, the name of the field makes me think there's some redirect uri I'm supposed to register?

@ashikns What version of Company Portal / Authenticator are you using? Would like to repro on my end

Microsoft Authenticator version 6.6.3 with one personal and one work account setup. Msal built as localRelease @ ecbe6aa7fb1daa7bb7de1f9c03db7da261485f58, common @ b618219885b86f1c4f4bf84854a24bb178885b1b.
Note that the app is a Unity app built for android (version 2019.1.14f1, built on mono backend). I'll explain the setup in case it's relevant:

Msal built as mentioned above, but I add a createMultiplePCA function that accepts InputStream directly.
A native android library project that consumes msal and provides a wrapper for it that Unity can interface with.
Pca is created by passing UnityMainActivity.getAppContext().

Closing as this appears to caused by combining unsupported versions: pre-release MSAL w/ TenantProfile support + broker versions that do not support it
Feel free to comment-back if you continue to have issues and we can investigate


Revert previously reverted changes + add fix

Several changes were reverted in #454 - the change has been "unreverted" + the fix for the broken test has been added

thanks so much @svuckovicTT !!! lgtm

I'd prefer to merge this WITHOUT squashing. Since there's multiple unrelated commits in this change, it'll be easier for someone to revert/cherry-pick a specific commit down the road, if there's a need. Lmk if you have any objections to that.

I'd prefer to merge this WITHOUT squashing. Since there's multiple unrelated commits in this change, it'll be easier for someone to revert/cherry-pick a specific commit down the road, if there's a need. Lmk if you have any objections to that.

Perhaps we can do them as separate PRs then?  The reason for the hard enforcement of squash is that it drastically simplifies the git history and CI pipeline history, on main.  It enables someone to checkout any commit on main and build and run and pass all unit tests.  If we don't' enforce squashing then there are gaps, this is bad for 2 reasons:

Someone could checkout some commit on main that's in an undefined state, it's just in the middle of some larger change, may or might not pass unit tests, who knows.
Unable to generically use git bisect for regression testing.  If every commit is expected to work and tested to some degree of confidence, then git bisect can freely walk the tree and have a fully automated bisect.

There's definitely tradeoffs with this approach, but having this invariant is extremely powerful and usually outweighs the downsides.  I'd also argue that this method makes it easier to revert or cherry-pick, there are very few cases in my mind where you'd want to only cherry-pick half of a change, if a change could have been broken into pieces it probably should have been separate PRs to begin with.

I'd prefer to merge this WITHOUT squashing. Since there's multiple unrelated commits in this change, it'll be easier for someone to revert/cherry-pick a specific commit down the road, if there's a need. Lmk if you have any objections to that.

Perhaps we can do them as separate PRs then? The reason for the hard enforcement of squash is that it drastically simplifies the git history and CI pipeline history, on main. It enables someone to checkout any commit on main and build and run and pass all unit tests. If we don't' enforce squashing then there are gaps, this is bad for 2 reasons:

Someone could checkout some commit on main that's in an undefined state, it's just in the middle of some larger change, may or might not pass unit tests, who knows.
Unable to generically use git bisect for regression testing.  If every commit is expected to work and tested to some degree of confidence, then git bisect can freely walk the tree and have a fully automated bisect.

There's definitely tradeoffs with this approach, but having this invariant is extremely powerful and usually outweighs the downsides. I'd also argue that this method makes it easier to revert or cherry-pick, there are very few cases in my mind where you'd want to only cherry-pick half of a change, if a change could have been broken into pieces it probably should have been separate PRs to begin with.

Ah, I didn't realize that squashing is enforced - I see your points though, and agree that it's better to squash.
Luckily, the PR will remain, and the commits in the PR itself will remain separate so if anyone needs to cherry pick anything, they can.


Integration tooling

Hello,
just added some fixes in order to be able to use frame source and frame reader library.
Thanks
Julien

I want to respond to him more fully
-Ben
Sent from my phone
On May 7, 2015, at 11:39 AM, David Molnar <notifications<EMAIL_ADDRESS>wrote:
Merged #6https://github.com/Microsoft/prepose/pull/6.
—
Reply to this email directly or view it on GitHubhttps://github.com/Microsoft/prepose/pull/6#event-299568611.

Ok, do you want me to revert it?
From: Ben Livshits<EMAIL_ADDRESS>Sent: Thursday, May 7, 2015 11:42 AM
To: Microsoft/prepose
Cc: David Molnar
Subject: Re: [prepose] Integration tooling (#6)
I want to respond to him more fully
-Ben
Sent from my phone
On May 7, 2015, at 11:39 AM, David Molnar <notifications<EMAIL_ADDRESS>wrote:
Merged #6https://github.com/Microsoft/prepose/pull/6.
—
Reply to this email directly or view it on GitHubhttps://github.com/Microsoft/prepose/pull/6#event-299568611.
—
Reply to this email directly or view it on GitHubhttps://github.com/Microsoft/prepose/pull/6#issuecomment-99973234.

No
-Ben
Sent from my phone
On May 7, 2015, at 11:44 AM, David Molnar <notifications<EMAIL_ADDRESS>wrote:
Ok, do you want me to revert it?
From: Ben Livshits<EMAIL_ADDRESS>Sent: Thursday, May 7, 2015 11:42 AM
To: Microsoft/prepose
Cc: David Molnar
Subject: Re: [prepose] Integration tooling (#6)
I want to respond to him more fully
-Ben
Sent from my phone
On May 7, 2015, at 11:39 AM, David Molnar <notifications@github.commailto:notifications<EMAIL_ADDRESS>wrote:
Merged #6https://github.com/Microsoft/prepose/pull/6.
—
Reply to this email directly or view it on GitHubhttps://github.com/Microsoft/prepose/pull/6#event-299568611.
—
Reply to this email directly or view it on GitHubhttps://github.com/Microsoft/prepose/pull/6#issuecomment-99973234.
—
Reply to this email directly or view it on GitHubhttps://github.com/Microsoft/prepose/pull/6#issuecomment-99973909.


Use Swift Regex instead of NSRegularExpression on macOS 13 and later to improve performance

I'm not sure whether it's worth while, but it seems to be more safe (and performant?). As all, NSRegularExpression seems would be replaced by Swift Regex in the future, which is heavily used to matching xcodebuild's output in this repo.

Hey @Saafo! I agree this would be helpful, and it's something I looked at. There were a few instances where I couldn't directly port over because Swift's Regex doesn't fully support lookbehind. We'd need to wait for its support, change the problematic regexes, or find a temporary middle ground.


Cover scenario when connectionType is none for kubelogin in HelmDeployV0

Task name: HelmDeployV0
Description: Fixing issue https://github.com/microsoft/azure-pipelines-tasks/issues/17958
Documentation changes required: (Y/N)
Added unit tests: (Y/N)
Attached related issue: (Y/N)
Checklist:

[ ] Task version was bumped - please check instruction how to do it
[ ] Checked that applied changes work as expected

@rvairavelu @manolerazvan Could you help review this PR? Thanks


Documentation: add warning to GPU setup instructions that Intel not supported

This is obvious in retrospect and isn't TF specific, but it might save some people some time to say something like "Tensorflow only supports CUDA, which is proprietary to NVIDIA, and not all Macs have an NVIDIA GPU".

We expect people to know what cuda/openCL is (no need to be familiar) if they want to use GPU for computing. Other wise there will be a lot to explain in the docs.


Implement linear search or binary search in Javascript using ES6

I would like to work on this.. if you are ok with it.

@mandardeshpande sure, go ahead.

Hello @frextrite , this looks to be stagnant, would I be able to work on this issue?

@connorphee Just checked. Both algorithms are already implemented. I might've forgotten to close the issue. You can, however, work on any other data structure/algorithm that hasn't already been implemented, create an issue and start working on it.


Makes erlang cookie configurable

High-level description
Erlang cookie serves as a membership token in a distributed system.
Having it configurable would allow different DC/OS clusters to
co-exist without interfering each other.
Corresponding DC/OS tickets (obligatory)
These DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:

DCOS_OSS-4620 Make cluster identity configurable in dcos-net

Checklist for all PRs

[x] Added a comprehensible changelog entry to CHANGES.md or explain why this is not a user-facing change:
[ ] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:
[ ] Read the DC/OS contributing guidelines
[ ] Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): example
[ ] Test Results: [link to CI job test results for component]
[ ] Code Coverage (if available): [link to code coverage report]

PLEASE FILL IN THE TEMPLATE ABOVE / DO NOT REMOVE ANY SECTIONS ABOVE THIS LINE
Instructions and review process
What is the review process and when will my changes land?
All PRs require 2 approvals using GitHub's pull request reviews.
Reviewers should be:

Developers who understand the code being modified.
Developers responsible for code that interacts with or depends on the code being modified.

It is best to proactively ask for 2 reviews by @mentioning the candidate reviewers in the PR comments area. The responsibility is on the developer submitting the PR to follow-up with reviewers and make sure a PR is reviewed in a timely manner. Once a PR has 2 ship-it's, no red reviews, and all tests are green it will be included in the next train.

@GoelDeepak is the cookie value supposed to be treated as a secret? The cluster-id is a public interface and it is not meant to be used for any security purposes.

@GoelDeepak are you planning to add any integration and or unit test for the new configuration option?

@GoelDeepak is the cookie value supposed to be treated as a secret? The cluster-id is a public interface and it is not meant to be used for any security purposes.

No, it is not supposed to be a secret

@GoelDeepak are you planning to add any integration and or unit test for the new configuration option?

Thank you @mhrabovcin for pointing this out.
I'd like to go further and point out that there is a Checklist for all PRs which includes:

Included a test which will fail if code is reverted but test is not. If there is no test please explain here:

That is neither checked nor explained. As a reviewer, I look at this checklist to see if there is a valid justification for no tests.
Please fill in this check box and the others.
As I am someone who has written tests for some configuration values, I am happy to help if desired.

@GoelDeepak are you planning to add any integration and or unit test for the new configuration option?

I wanted to run it through the first round of review to make sure it makes sense. I'll add the tests

@GoelDeepak are you planning to add any integration and or unit test for the new configuration option?

Thank you @mhrabovcin for pointing this out.
I'd like to go further and point out that there is a Checklist for all PRs which includes:

Included a test which will fail if code is reverted but test is not. If there is no test please explain here:

That is neither checked nor explained. As a reviewer, I look at this checklist to see if there is a valid justification for no tests.
Please fill in this check box and the others.
As I am someone who has written tests for some configuration values, I am happy to help if desired.

I am aware of the checklist but before going ahead with the tests I wanted to review the approach.

@GoelDeepak are you planning to add any integration and or unit test for the new configuration option?

Thank you @mhrabovcin for pointing this out.
I'd like to go further and point out that there is a Checklist for all PRs which includes:

Included a test which will fail if code is reverted but test is not. If there is no test please explain here:

That is neither checked nor explained. As a reviewer, I look at this checklist to see if there is a valid justification for no tests.
Please fill in this check box and the others.
As I am someone who has written tests for some configuration values, I am happy to help if desired.

I am aware of the checklist but before going ahead with the tests I wanted to review the approach.


Draw-throw (or too quick play?) causes duplicate cards

One scenario where this happens: select a card, previous player draw-throws, the selected card is duplicated to the hand


Hugo generates inexistent TOC items when there are skipped heading levels

For example:
# H1

...main content...

> ### H3
>
> (some extra content inside blockquote)

with config:
markup:
  tableOfContents:
    startLevel: 1
    endLevel: 2 # So H3 should not render

yields this TOC:

H1

(an empty item)

The empty item isn't expected.

What version of Hugo are you using (hugo version)?

$ hugo version
hugo v0.92.2+extended linux/amd64 BuildDate=unknown

Does this issue reproduce with the latest release?
Yes.

Duplicate of https://github.com/gohugoio/hugo/issues/7128.


Fix test_model_doc to check doc not str. #1191

Thanks for spotting this.

Glad to see you in here coding, by the way. Are there elements of our project that interest you for some future work? I'd love to get you plugged in!

Glad to be coding in here. Are there any elements that need more help than others?
I didn't look too far into it but there were some tests commented out in the doc tests. Do those tests need different implementations?


Not an issue but rather an inquiry and a possible suggestion

I don't know where to leave a question or a suggestion so I'll do both here:
Is there any way to speed up the duels? like let's say somehow making the duels go like how replays with fast forward go, skipping chain animations and speeding up other things
If none of that is possible, is it at all possible to use outside software to speed up the offline client? specifically Cheat Engine's speed hack which works with most offline games, and since this is offline there must be a way to make it work...right? cause I tried it and it didn't work

You're after these:
https://github.com/pixeltris/YgoMaster/blob/34d334693577136b620da76cbfc7cdc015714090/YgoMaster/Data/ClientData/ClientSettings.json#L17-L21
You want to change DuelClientTimeMultiplier to 2.0 for example and maybe set DisableVSync to true. You might also need to disable vsync in your gpu driver settings software.

You're after these:
https://github.com/pixeltris/YgoMaster/blob/34d334693577136b620da76cbfc7cdc015714090/YgoMaster/Data/ClientData/ClientSettings.json#L17-L21
You want to change TimeMultiplier to 2.0 for example and maybe set DisableVSync to true. You might also need to disable vsync in your gpu driver settings software.

Well first of all I gotta say I didn't know about these settings before
That being said....I tried all of that, set all 3 of them to 2, disabled VSync in both the file and my GPU and still...no changes in the client speed or duel speed at all...can you confirm that it works for other people? does it speed it up by a lot or is the difference barely visible?
Can you show me a quick clip of a sped up client?

It works for me (I just tested in on v1.10) and I know a couple of people who have used it in the past. Some people had issues with the vsync thing and is likely what is stopping it from working in your case. There might be some additional vsync settings on your system somewhere causing it to frame lock.

And those people stopped having problems once they "fixed" the Vsync problem? cause I looked online and I'm pretty sure the only Vsync option in my system is the one in NVIDIA's control panel
Do settings like those require a massive GPU or something? mine is 1060 GTX and I highly doubt that isn't enough to speed MD up a little

And those people stopped having problems once they "fixed" the Vsync problem

Yes. I believe they just changed it in the nvidia control panel and then it worked. I'm not sure why it's not working for you unfortunately. I'm pretty sure cheat engine speed hack also works when vsync is properly disabled.
You don't need a strong GPU, I use an older GPU than yours.

Well damn It's frustrating to know that I'm the only or one of the few people who can't get this to work
Ok what about this: the fast forward button: should it actually do what it does in replays (like skip chain animations) or is it here simply a button to speed up the game in general?

The fast forward button in the replay controls wont change the speed for you as it's overridden to use a time multiplier (which isn't working for you). I added those replay controls based on this request to dynamically modify the speed of the game at runtime https://github.com/pixeltris/YgoMaster/issues/18

It would be possible to do but there isn't anything set up in YgoMaster to do this. Additional mods would need to be added in the YgoMasterClient component. Unfortunately I don't have any plans of working on that as the speed multiplier meets my requirements.

https://github.com/pixeltris/YgoMaster/commit/3d3ab330fbab68e41d88f96f6d5646c566d36e88 adds a setting in ClientSettings.json called DuelClientDisableChains which should disable all chain animations. This will be available in the next release or compile the code for yourself.

For anyone having issue. You will need to disable VSYNC with your GPU setting (for me NVIDIA Control Panel)
Afte that just do as @pixeltris have suggested.
For my case it is "TimeMultiplier": 2, and "DisableVSync": true, in ClientSettings.json

For anyone having issue. You will need to disable VSYNC with your GPU setting (for me NVIDIA Control Panel)
Afte that just do as @pixeltris have suggested. For my case it is "TimeMultiplier": 2, and "DisableVSync": true, in ClientSettings.json

I obviously already did all of this and it didn't work, I tried everything under the sun to get this "speed hack" to work but nothing did
Pixeltris also said that even just using Cheat Engine's speedhack should work but it didn't
The bigger problem for me is that I tried this on 2 different laptops and in both cases it didn't work and I have no idea why
See for yourself

@orwasaker have you tried to configure it specficly for the game? (instead of global setting)

I will admit I didn't know you could do that, however I did try disabling it for MD and both Ygomaster.exe and YgomasterClient.exe and none of it worked
Here's 2 pictures showing that I did do all the necessary stuff:

I should also note that I tried once to run MD with FPS displayed, and it displayed 60 FPS
And when I used Cheat Engine's speedhack and increased speed to 2, the game's speed didn't change at all, however the FPS dropped down to 30, and if I set the speed to 4 FPS would become 15
What's driving me crazy is that JMaster's MD hack DID actually speed up my game....like I don't understand at all why his speed hack works but none of this stuff here works
And again I don't understand why it doesn't work on 2 Laptops...like am I just that unlucky?

It's probably some Unity setting that isn't allowing of disabling vsync in this case. You could ask @BullyWiiPlaza if there are any additional Unity changes that he makes.
DisableVSync modifies the setter of UnityEngine.CoreModule.QualitySettings.vSyncCount. It's possible that this might not be called directly and is defaulting to a non-zero value. So the code might need to be changed to call the setter.
There's also this which currently isn't being modified which might be required https://docs.unity3d.com/ScriptReference/Application-targetFrameRate.html

Ok I might message him (kinda doubt if he'd reply or if he'd know what's missing in this formula but it's worth a try)
But from what I understand from your reply here, should I wait for you to change things up in the code to fix this? or should I just keep seeking solutions for it on my own?
I should mention though that it's been a very long time since I tried Plaza's bot/hack, I can't confirm if it would still work now (no reason to believe it wouldn't though, since the Vsync thing has never stopped not working for me)

@orwasaker excuse me if these are silly questions.

Have you actually click on [Apply] button after adjusted the Vsync setting?
Also have you updated your GPU driver yet?

Because these settings just work for me without much trouble at all. I have a Steam Deck which running on Linux using AMD GPU and a Desktop running on windows using NVDIA GPU. Both have this speed multiplier working flawlessly.

I appreciate any support even if it's a silly question
That being said, yes I did press apply
Now for the GPU driver thing, well technically my GPU driver isn't up to date, its last update date is 28/02/2023
I tried updating it but since I live in Syria (a country under heavy sanctions) I'm banned from doing so
I tried using a VPN, the update size is 550 MG which isn't a lot, but using Syrian internet it takes a while, and using a free VPN (due to sanctions it's impossible to buy a VPN) throttles my speed, but regardless I tried downloading it 3 times, and every time it completes downloading, it just shows me the download button again and I have to download it again
I would keep trying but I'm using my data (don't currently have access to a wifi) and this is costing me too much data to keep attempting
BUT IT'S IMPORTANT TO NOTE: the driver dates back to last February, and this "time multiplier" thing goes back beyond that date, hell with the second Laptop it was brand new, and the FIRST thing I tried is Ygomaster's time multiplier (after disabling Vsync etc.) and it didn't work back then either
So I highly doubt it's an issue of an outdated driver


Use /dev/gpiomem (with offset=0), if available

/dev/gpiomem is a map of GPIO-related memory region.
No longer need root for user GPIO access, but without relaxing
permissions on /dev/mem.
See https://github.com/raspberrypi/linux/pull/1112/files

Sweet! Seems to work, thank you :+1:


Tasks Distribution

Hi @WildJimmy & @poojashresthacode
Which project of earlier homework we gonna choose for this homework. It would be better if we decide it soon and start working on our project. Also we should allocate the task too.

Yeah, we can do any of yours. Is it okay ? @WildJimmy @pratibha77118

Hi All,
If you'd like we can use my group's homework for the last assignment (https://github.com/ubsuny/23-Homework3G3), which calculates the spring constant of a given system. It's relatively simple so it should be nice to adapt with the github actions. Let me know if this works for you @pratibha77118 @poojashresthacode

multiple groups can use the same code

Sure!


[QUESTION] context for french translation

Hello,
In order to update the fr json file
Can you tell me (screen?),  When (context?) the following mesages are displayed?
thank you so much
    "proceed-to-dashboard": "Proceed to Dashboard",
    "proceed-guest-button": "Proceed as Guest"

Ah yes, good question - this is for guest mode.
When guest mode is enabled, and the user navigates to the login page, there is a button that lets them skip login and have read-only guest access the dashboard, like this:

The second bit of text probably isn't needed, it's for when the user is already logged in, and they manually navigate to the login page, it looks like this:

Thx for your reply :)
#170


Swedish Krona error

Describe the bug
When using the configuration below and typing more than 2 numbers the textbox changes to "NaN kr":
 <ReactCurrencyInput       intlConfig={{ locale: "sv-SE", currency: "SEK"}}   />
To Reproduce
just insert the component with the given intlConfiguration and type 2 numbers.
Expected behavior
I expected the numbers to be formatted correctly on the Swedish Krona currency and locale
Code Sandbox
https://codesandbox.io/s/new-thunder-xk481x

I have the same issue with Danish Kroner. It has to do with the abbreviations, where both SEK and DKK contains K, which means it will multiple whatever you enter with 1000 and that can result in NaN.
A temporary fix for you would be disabling abbreviations by passing disableAbbreviations like they explain here.


Python/samples/kernel-syntax-examples/openapi_example does not work due to deprecation of ContextVariables

Describe the bug
The sample file will not run as it still makes use of ContextVariables which have been deprecated
To Reproduce
Steps to reproduce the behavior:

Go to python/samples/kernel-syntax-examples/openapi_example
Follow the instructions in the README.md
See error when running openapi_client.py

Expected behavior
The file should run as expected from the README
Error Message
AttributeError: module 'semantic_kernel' has no attribute 'ContextVariables'
Platform

OS: Ubuntu
IDE: VS Code (via WSL2)
Language: Python
Source: main branch of repository

Hi @ColtonBehannon thanks for raising the issue. I'm working on getting this updated right now, actually, and am adding support to be able to import and run OpenAI plugins as well (with auth). This is my priority right now, and should be done soon.

That's great to hear! I actually found a related bug that should probably be in its own issue, but I wanted to bring it up while you're working on this.
The prepare_request method of the RestApiOperation class in kernel_openapi.py incorrectly parses URLs with more than one slash as a result of using urljoin.
Example
OpenAPI Server URL: https://api.website.com/domain/field
OpenAPI Path: /v1/endpoint
Correct full endpoint: https://api.website.com/domain/field/v1/endpoint
What the code returns: https://api.website.com/v1/endpoint
How to identify/reproduce:
url = urljoin(self.server_url, path)
print(f"URL being used for request: {self.server_url}")
print(f"Path being used for request: {path}")
print(f"Full URL being used for request: {url}")

I have replaced the urljoin line with the code below. It has not been tested against various endpoints but it works with the one that I am using (though I'm sure there is a more elegant solution).
if not self.server_url.endswith("/"):
    self.server_url += "/"
if path.startswith("/"):
    path = path.lstrip("/")
url = self.server_url + path

Sorry you had to spend time on this -- I found that during my testing and just fixed it. :)


Bug: image & album descriptions are saved with

When the web app saves image/album descriptions, it sends the description to the server wrapped in a paragraph tag:
description
.

Not a bug.  Those  tags are important.  Each paragraph is saved in its own  like this:
First para
Second para


Fix scrollbars not showing for CodeListing in Safari

Bug/issue #, if applicable: 78783950
Summary
Fixes a bug where codelisting scrollbars are sometimes hidden in Safari, until you resize the screen.
Dependencies
NA
Testing
You can use SlothCreator to test.
Try setting scrollbars to Always Show in macOS settings.
Steps:

Use a resolution that would show horizontal scrollbars. Expand the navigator as much as possible.
Go to http://localhost:8082/documentation/slothcreator/sloth
Assert that scrollbars are always visible in safari and its fully scrollable
Try the same here - http://localhost:8082/tutorials/slothcreator/creating-custom-sloths

Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.

[ ] ~Added tests~ - no need CSS only
[x] Ran npm test, and it succeeded
[x] Updated documentation if necessary

@swift-ci test

@swift-ci test


AdoptOpenJDK variant support

Can you provide the AdoptOpenJDK variant?

Duplicate of https://github.com/docker-library/tomcat/issues/134.
Would require official images of AdoptOpenJDK as a prerequisite (https://github.com/docker-library/official-images/pull/5710).


Test in Laravel 5.5

I think we should be okay, but I saw some changes to getRoutesByName() so I may need to change some things for Laravel 5.5.
Anyone have a good versioning strategy to have a LTS version that works with 5.4?

What about detecting laravel/framework version at runtime via something like app()->version(), and handling both implementations in the same master branch?  This way Ziggy users won't have to think about syncing a Ziggy version with laravel/framework?

Works fine for me in Laravel 5.5 :)

Sweet! I'll run a few more tests myself then close this.


Fix return type annotation on identical()

IDEs returning type mismatches even though code works.

Thank you!


[analyzer] better error message for UNNECESSARY_NAN_COMPARISON

[x] As commented here, it is better to rename the message
[x] null should be surrounded by single quotes in all problem and correction messages.
[ ] As a side note, null inside the description of the messages should also be changed, but they seems to be handled by another team.

For the message, NaN was originally used, since it is documented like that:
https://github.com/dart-lang/sdk/blob/f443f7e21314b0297be7bf60f51beb2e19ad4c3b/sdk/lib/core/double.dart#L53

https://dart-review.googlesource.com/c/sdk/+/270104

This would be considered in the reland.


Stops at "make install", FreeBSD 13, no jail

Build fails at ./build_runtime.sh step. This is end of output where it seems to break.
  Invoking "/var/tmp/build/dotnet/dotnet-core-freebsd-source-build/runtime/eng/native/gen-buildsys.sh" "/var/tmp/build/dotnet/dotnet-core-freebsd-source-build/runtime/src/coreclr" "/var/tmp/build/dotnet/dotnet-core-freebsd-source-build/runtime/artifacts/obj/coreclr/FreeBSD.x64.Release" x64 clang "" "" Release ""  -DCLR_CMAKE_PGO_INSTRUMENT=0 -DCLR_CMAKE_OPTDATA_PATH= -DCLR_CMAKE_PGO_OPTIMIZE=1 -DFEATURE_DISTRO_AGNOSTIC_SSL=1
  WARN: Specific version of clang not found, falling back to use the one in PATH.
  /var/tmp/build/dotnet/dotnet-core-freebsd-source-build/runtime/artifacts/obj/coreclr/FreeBSD.x64.Release /var/tmp/build/dotnet/dotnet-core-freebsd-source-build/runtime/src/coreclr
  Not searching for unused variables given on the command line.
  -- The C compiler identification is Clang 11.0.1
  -- The CXX compiler identification is Clang 11.0.1
  -- Detecting C compiler ABI info
  -- Detecting C compiler ABI info - done
  -- Check for working C compiler: /usr/bin/clang - skipped
  -- Detecting C compile features
  -- Detecting C compile features - done
  -- Detecting CXX compiler ABI info
  -- Detecting CXX compiler ABI info - done
  -- Check for working CXX compiler: /usr/bin/clang++ - skipped
  -- Detecting CXX compile features
  -- Detecting CXX compile features - done
  -- Configuring incomplete, errors occurred!
  See also "/var/tmp/build/dotnet/dotnet-core-freebsd-source-build/runtime/artifacts/obj/coreclr/FreeBSD.x64.Release/CMakeFiles/CMakeOutput.log".
  CMake Error at /var/tmp/build/dotnet/dotnet-core-freebsd-source-build/runtime/eng/native/configuretools.cmake:37 (message):
    Unable to find toolchain executable.  Name: link, Prefix: llvm-.
  Call Stack (most recent call first):
    /var/tmp/build/dotnet/dotnet-core-freebsd-source-build/runtime/eng/native/configuretools.cmake:47 (locate_toolchain_exec)
    /var/tmp/build/dotnet/dotnet-core-freebsd-source-build/runtime/eng/native/configurecompiler.cmake:1 (include)
    CMakeLists.txt:19 (include)

  /var/tmp/build/dotnet/dotnet-core-freebsd-source-build/runtime/src/coreclr
  /var/tmp/build/dotnet/dotnet-core-freebsd-source-build/runtime/artifacts/obj/coreclr/FreeBSD.x64.Release /var/tmp/build/dotnet/dotnet-core-freebsd-source-build/runtime/src/coreclr
  Executing make install -j 33
  make: make: don't know how to make install. Stop

  make: stopped in /var/tmp/build/dotnet/dotnet-core-freebsd-source-build/runtime/artifacts/obj/coreclr/FreeBSD.x64.Release
  /var/tmp/build/dotnet/dotnet-core-freebsd-source-build/runtime/src/coreclr
  ##vso[task.logissue type=error]Failed to build "CoreCLR component".
/var/tmp/build/dotnet/dotnet-core-freebsd-source-build/runtime/src/coreclr/runtime.proj(46,5): error MSB3073: The command ""/var/tmp/build/dotnet/dotnet-core-freebsd-source-build/runtime/src/coreclr/build-runtime.sh" -x64 -release -ci -os FreeBSD /p:OfficialBuildId=20220601.99" exited with code 2.
##vso[task.logissue type=error;sourcepath=/var/tmp/build/dotnet/dotnet-core-freebsd-source-build/runtime/src/coreclr/runtime.proj;linenumber=46;columnnumber=5;code=MSB3073;](NETCORE_ENGINEERING_TELEMETRY=Build) The command ""/var/tmp/build/dotnet/dotnet-core-freebsd-source-build/runtime/src/coreclr/build-runtime.sh" -x64 -release -ci -os FreeBSD /p:OfficialBuildId=20220601.99" exited with code 2.

Build FAILED.

/var/tmp/build/dotnet/dotnet-core-freebsd-source-build/runtime/src/coreclr/runtime.proj(46,5): error MSB3073: The command ""/var/tmp/build/dotnet/dotnet-core-freebsd-source-build/runtime/src/coreclr/build-runtime.sh" -x64 -release -ci -os FreeBSD /p:OfficialBuildId=20220601.99" exited with code 2.
    0 Warning(s)
    1 Error(s)

Time Elapsed 00:39:42.64
Build failed with exit code 1. Check errors above.
##vso[task.complete result=Failed;]msbuild execution failed.

The mentioned log file CMakeOutput.log does not exist. The directory in question does not have a Makefile, so that is why make fails but I cannot figure out how it ends up in that situation.
# ls -l
total 56
-rw-------  1 root  wheel  14636 Jun  1 11:24 CMakeCache.txt
drwx------  4 root  wheel    512 Jun  1 11:24 CMakeFiles
-rw-------  1 root  wheel    137 Jun  1 11:24 cmake_cmd_line.txt
-rw-------  1 root  wheel      0 Jun  1 11:24 optdatapath.txt
-rw-------  1 root  wheel    124 Jun  1 11:24 version.c

Could it have something to do with the message about clang?
# clang++ --version
FreeBSD clang version 11.0.1 (git@github.com:llvm/llvm-project.git llvmorg-11.0.1-0-g43ff75f2c3fe)
Target: x86_64-unknown-freebsd13.0
Thread model: posix
InstalledDir: /usr/bin

OS version etc:
# uname -a
FreeBSD vpcfbsd10.olofdom.se 13.0-RELEASE-p11 FreeBSD 13.0-RELEASE-p11 #0: Tue Apr  5 18:54:35 UTC 2022     root@amd64-builder.daemonology.net:/usr/obj/usr/src/amd64.amd64/sys/GENERIC  amd64

I see it's trying to use clang 11 - did you run install_tools.sh as root? In general, clang from base shouldn't not be used to build anything except system itself - so it should pick up llvm from /usr/local - is this fresh 13.0-R install ?

It has been upgraded from 12.x so there could be things left from older versions. Yes, I ran install_tools.sh as root. It does not install anything when I run it, so I suppose it finds all it needs installed already?

Hi.
I was able to fully build runtime, aspnet, sdk (can be skipped) and installer under FreeBSD 13.0-RELEASE-p11 using 6.0.5 (sdk 6.0.300) tags (updated main to reflect needed changed). Please try with clean / rebuild and let me know :)

I uninstalled and reinstalled llkvm10 and cleaned everything and rebuilt. Got loads of errors about using deprecated functions but just ran build_runtime.sh again and then it worked. Not sure really what happened there.
Thanks for the release!


In index.html, show two categories - finished and unfinished games

Currently, all games are listed in the same column, regardless of their finished status. Create two independent lists for finished/unfinished games.
Clicking an unfinished game takes the user to game.html to play, clicking a finished game takes the user to an analysis.html page (to be created) which shows a  plot a of how the user's guesses converged to the right answer.

solved


Change coverage Data File Env Var for >= 5.0

In 5.0 the ENV Var has changed to DATA_FILE rather than COVERAGE_FILE
-- https://coverage.readthedocs.io/en/coverage-5.0/config.html#run
Test: Run on my MAC and see coverage data analyzed again

Fixes #84

Guess we could just set both environment variables ..


allow copying text confirming repository archive/deletion

Description
When archiving/deleting a repository, a confirmation prompt is shown where the name of the repository needs to be entered.
Previously the name could just be copied from above but now the label has user-select none which sadly prevents copy/paste.

Example URLs
https://github.com/SimonSiefke/ts-node-esm-bug/settings

It is there for a reason, to prevent mistakes

Oof really? I selected and dragged the text all the time. 🤦♂ I’d accept this.
I think this would be an easy one-line of CSS in refined-github.css

It is there for a reason, to prevent mistakes

We’re (probably) adults. That guy who lost a 100k-star repo got what he deserved but now we’re all paying for it with a multi-step form already.
If GitHub cared they would just allow undoing deletion within x days, but UI is easier I guess

I think they changed this already


Add govisord tests & examples

govisord needs to have some kind of test suite to verify that it works, and probably also we should publish example manifests somewhere.

You really need this

Actually, there are manifests in the samples/ directory.  Yes, a test suite would still be good.  I welcome contributions here... The framework has tests, but the daemon doesn't yet.


accountRequired modifier should not consider anonymous accounts by default.

accountRequired modifier should not consider anonymous accounts by default.
:recycle: Current situation & Problem
Currently, the accountRequired(_:setupSheet:) modifier considers any associated account details as a valid account and therefore dismisses the provided setup sheet. However, typically anonymous accounts are not considered full accounts and are only used to have a persistent account identifier. The AccountSetup sheet treats anonymous accounts similarly where it still shows all the signup options.
This PR introduces a new flag passed to the accountRequired(_:considerAnonymousAccounts:setupSheet:) modifier to control the behavior of anonymous accounts. By default anonymous accounts are treated the same as if no account was present.
:gear: Release Notes

Ignore anonymous accounts with the accountRequired modifier by default.

:books: Documentation
Documentation was updated.
:white_check_mark: Testing
--
:pencil: Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

[x] I agree to follow the Code of Conduct and Contributing Guidelines.

Thank you @Supereg!


Android: Full bleed images

iOS has had this and I just launched it on the web. It's always a bit tricky to implement, but the relevant CSS changes can be found in this commit: b4ade7afc08b4366543d7b182a357248551f7ae2
Part of how full bleed images work is that on page load, we check every image after it loads and see if its width is greater than 320px and its height is greater than 50px, and if so add a "NB-large-image". If not, add a "NB-small-image". The JS code for this lives in media/js/newsblur/views/story_detail_view.js:watch_images_load:L132. You'll need the imagesLoaded library, which is at media/js/vendor/imagesLoaded-4.1.0.js.
So there's three states here: unloaded but loading, large, and small. We do this differently between the web and iOS. On iOS, images are kept at their natural size (NB-small-image doesn't do anything, it's mainly to see that an image is small instead of large when debugging) and then grown to full bleed when loaded. On web, we do it the opposite and assume images are large (therefore NB-large-image doesn't do anything) and add NB-small-image when it's small (javascript exposes this as this.naturalWidth). Therefore on the web images will look great on load but will shrink when small. On iOS, images will pop larger after loading.
I believe the web version is better because I notice it less. And when an image fixes itself, it's not a big deal, just as much as an image enlarging itself. So if the cost is the same either way, better to assume the image is large.

@Dejal could you provide more context into how is this implemented on iOS and what is the high level flow on your side?

@sictiru This wasn't something I added. It just uses Javascript and CSS as Sam describes; no native code. The app loads the page HTML, which includes storyDetailView.js, which in turn calls a loadImages() Javascript function to set the CSS for the images.

Take a look at 5295b8d19062370b741bb77e6a2210d6c9956583 to see how I made it work on iOS. Basically negative-margin and a width of calc(100% + 2*margin). That seems to work well in CSS3.

I see the commit but images aren't full bleed yet. Is it only under certain conditions?

@samuelclay Could you attach a screenshot with a full bleed image example from iOS? I don't have access to an iPhone until next week and the fix here might be a quick CSS change after the last commit.

Sure, here's a screenshot from the "Betabeat" publisher:

Looks like a deeper dive is required into the CSS file to make this happen.


Issue #85 - add global parameter for stash-config.properties values

Add parameter config_properties. Accepts a hash. Defaults to {}
eg:
config_properties => {
  'aaaa'   => 'bbbb',
  'cccc'   => 'dddd',
},

@igalic if you have a second to review, should be a quick one.

I'm using this code to add the crowd sso plugin into stash and it's working well for me.  Could we get this PR merged and a new release to the puppet forge please?

thanks @mkrakowitzer and @adamcrews!


Emin/plant error handling

With this pr instead of redirecting user to the search page without saying anything, we will promote a nice descriptive error message and let the user stay in photo screen so that they can take another picture. At the same time I fixed the error with loading icon, it was stuck on loading even after plant doesn't get identified. Now loading is only shown during the process of identification.

With this pr instead of redirecting user to the search page without saying anything, we will promote a nice descriptive error message and let the user stay in photo screen so that they can take another picture. At the same time I fixed the error with loading icon, it was stuck on loading even after plant doesn't get identified. Now loading is only shown during the process of identification.

Well done.

I see the error but it only shows up after it was stuck in the loading view for a good minute. I would suggest displaying the error message for at least 3-4 seconds if that´s possible. I barely had time to read it.
Also, the SearchField is not opening the searchModal anymore. You basically cannot tap on it anymore. It doesn´t show a response by having an opacity.


Request for help command

Regarding your todo in the help command:
https://github.com/Dev-CasperTheGhost/ghostybot/blob/1c0a08c73f7eda0d91a9bd1f8f9d9332ab0b02a0/src/interactions/util/Help.ts#L43
What I have in my bot is that every command has a category key.
Then in my help command I loop through all my commands and create a collection with all the categories and the commands that belong that that category.
const categories: Collection<string, string[]> = new Collection();

for (const command of client.commands.values()) {
  // If the command doesn't have a category, move to the next one
  if (!command.category) continue;

  const category = command.category;

  // If the category isn't in the collection yet, add it along with the command.
  // If the category is already in the collection, add the command to it.
  if (!categories.has(category)) {
    categories.set(category, [command.name]);
  } else {
    const cmd = categories.get(category);
    cmd?.push(command.name);
  }
}

When I need all the categories, I loop through the keys of the collection:
for (const category of categories.keys()) {
  // Add options to select menu
}

When I need the commands for the selected category, I get the respective category:
if (categories.has(selectedCategory)) {
  const commands = categories.get(selectedCategory);

  // Simplified for this issue
  embed.setDescription(`\`${commands?.join('`, `')}\``)
}

I currently don’t have time for this yet, but thanks for looking into this!


Webiste (zappa.ws/zappa) is down

The website linked in the repo (zappa.ws/zappa) is down. It redirects to the following page:

thanks for reporting this, I removed it from the github page.


Update repair-windowsimage.md

##1118
No action taken for this repo.
Queries for #1118:
Not sure if command, "Cleanup-WindowsImage -Path  -AnalyzeComponentStore "
is working. perhaps you can guide me with the correct command if this is working
Run the following command in comparison;
Cleanup-WindowsImage -Path  -AnalyzeComponentStore > error: Parameter cannot be found
Dism.exe /online /Cleanup-Image /AnalyzeComponentStore > working
See Screenshot: https://snag.gy/6x4vDX.jpg
Also, Unable to find repo for this command "Cleanup-WindowsImage -Path  -AnalyzeComponentStore"
But was able to find repo/article for the following command; https://docs.microsoft.com/en-us/windows-hardware/manufacture/desktop/clean-up-the-winsxs-folder but not WinPE Features
Dism.exe /online /cleanup-image /StartComponentCleanup
Dism.exe /online /Cleanup-Image /StartComponentCleanup /ResetBase
Also this : https://docs.microsoft.com/en-us/windows-hardware/manufacture/desktop/reduce-the-size-of-the-component-store-in-an-offline-windows-image
Dism /Image:C:\test\offline /Cleanup-Image /AnalyzeComponentStore
Additionally; Found this technet blog for the following command : https://blogs.technet.microsoft.com/askpfeplat/2015/02/09/how-to-reduce-the-size-of-the-winsxs-directory-and-free-up-disk-space-on-windows-server-2012-r2-and-windows-8-1-or-do-we-even-need-to/
==========================================
Tried to run the commands for the following but failed
See screenshot:
https://snag.gy/Ru6otl.jpg > error: Parameter cannot be found
https://snag.gy/8fiEBI.jpg > A positional parameter cannot be found that accepts argument 'StartComponentCleanup'.
Command for Repair-WindowsImage exist in repository
https://github.com/MicrosoftDocs/windows-powershell-docs/blob/master/docset/windows/dism/repair-windowsimage.md
https://docs.microsoft.com/en-us/powershell/module/dism/repair-windowsimage?view=win10-ps
But user would like to add the following which is not part of the repo.
Repair-WindowsImage -Path  -AnalyzeComponentStore
Repair-WindowsImage -Path  -StartComponentCleanup
Repair-WindowsImage -Path  -StartComponentCleanup -ResetBase
This is the repository for the command: Optimize-WindowsImage
https://docs.microsoft.com/en-us/powershell/module/dism/optimize-windowsimage?view=win10-ps
https://github.com/MicrosoftDocs/windows-powershell-docs/blob/master/docset/windows/dism/optimize-windowsimage.md
These command are also not part of the article/repo, can't find any
Optimize-WindowsImage -Path  -AnalyzeComponentStore
Optimize-WindowsImage -Path  -StartComponentCleanup
Optimize-WindowsImage -Path  -StartComponentCleanup -ResetBase
Other references:
https://docs.microsoft.com/en-us/windows-hardware/manufacture/desktop/use-dism-in-windows-powershell-s14
https://docs.microsoft.com/en-us/windows-hardware/manufacture/desktop/winpe-adding-powershell-support-to-windows-pe
Very much appreciated for any assistance. Thank you.

@dariomws306 @get-itips @tseward
Additional technical assistance and peer review needed for this PR. Thanks.

Closing via https://github.com/MicrosoftDocs/windows-powershell-docs/issues/1118#issuecomment-518058110

@officedocsbot close


Update website with March 2023 JDK20 release

This PR performs the final parts of the release process for JDK20:

Replaces the JDK19 column with JDK20
Replaces "RHEL 9.x" with "RHEL / UBI 9.x" (Same for 8) sine that's what we are shipping our container images on so we should explicitly list it in place of CentOS as something that customers can obtain.
Lists UBI9 rather that CentOS7 as the RPM container platform for JDK20 (NOTE: We can also update the earlier versions to list both versions if reviewers want that done under this PR)
Removes the website banner

Description of change

Checklist

[x] npm test passes
[x] documentation is changed or added (if applicable)
[ ] permission has been obtained to add new logo (if applicable)
[x] contribution guidelines followed here

Hmm weird, netlify job says its done when you click through but the status is not updated and I can't seem to force a new run...

And I don't have permission to edit the PR / make a suggested commit.


Handling go_repository rules

When you use go_repository rules in your WORKSPACE file to declare dependencies.
How do we get the dependencies pulled to go into the GOPATH created by gobazel?

gobazel would not copy source code to GOPATH, instead, it maps source code with FUSE. You can think of it as kind of symlinks. Once all source code files are mapped (with the rules we configured), the Go compiler can find the deps correctly.


Camera only detected with USB 2.1 while connected with a USB C cable that's USB 3.1

librealsense
2.54.2 RELEASE

OS
Windows

Name
Intel RealSense D435I

Serial Number
843112074190

Firmware Version
5.15.1

Advanced Mode
YES

Camera Locked
YES

Usb Type Descriptor
2.1

Product Line
D400

Asic Serial Number
850123052386

Firmware Update Id
850123052386

Please provide a description of the problem

Is this a known issue with some workaround?


Change first day start of week

Thanks for sharing the CalendarKit
I don't want use default first day start. I want set monday start of week.
Thank you.

Hi, @zungx currently CalendarKit takes the 1st day of the week form the user's default calendar settings. Would you like to override this behavior?

Hi @richardtop
I know CalendarKit use user's default calendar settings, but i want fixed day start always is Monday.
I try add extension to change firstweekday
extension Calendar {     var firstWeekday: Int { return 2 } }
Everything ok. but have bug.
when i scroll from Monday to Sunday not reload date cell data. I scroll from 28/05/2018 to 27/05/2018.
See on video https://drive.google.com/file/d/1Hqa2FKVumXftSwvn7nGcs0WgurJS8R0Q/view?usp=sharing
Thank you so much.

This behavior is not supported currently. I'll mark it as an enchancement.

It's possible in the current release of the CalendarKit by configuring it with the custom calendar.


Not able to leveraging Intent classification

Rasa version:
0.14.6
Python version:
3.6.5
Operating system (windows, osx, ...):
windows
Issue:
E.g. Let’s say my intent name is DetectItem. Examples will be I have a Mango I have a Chair Do you need Coffee
Here, I’ll map Mango, Chair and Coffee to an entity called @Item. Now, my @Item entity will be like below.
Fruit - Mango, Banana, Pineapple, Apple
Furniture - Chair, Table, Cupboard Drink - Coffee, Tea
Please note that there is only one entity here called @Item which will have values as Fruit, Furniture and Drink. Mango, Banana etc. would be synonyms for Fruit. Similarly, Chair, Table would be synonym for Furniture and so on.
Now with the above, setup. If I ask “Where is my tea”, Response should be Intent - DetectItem Entity - Item EntityValue - Tea.
Also, please note that the example I gave above is pretty general but in my case it would be completely different(custom) values and those values won’t be common or well-known values. That being said, any general dictionaries won’t help and I have my own dictionary as I mentioned.
I don’t want to provide an example for every possible sentence structure for every entity. Just a few so the model is aware of it. That should directly extract the entity values from the list using lookup and PR.  Entity extraction works fine.
My Concerns is I am not able to leverage Intent classification. If I added an example with entity value the same template asked then Intent classification works well. However, when I asked using synonyms values then wrong intent classified. What should be the approach to leverage Intent classification?
Many thanks in advance.
Content of configuration file (config.yml):
language: "en"

pipeline:
- name: "nlp_spacy"
- name: "tokenizer_spacy"
- name: "intent_entity_featurizer_regex"
- name: "intent_featurizer_spacy"
- name: "ner_crf"
- name: "ner_synonyms"
- name: "intent_classifier_sklearn

Content of domain file (domain.yml) (if used & relevant):

Please ask these kind of questions in our forum


Find/Replace in Minimal theme: not all buttons are visible

Preflight Checklist

[x] I agree to follow the Code of Conduct that this project adheres to.
[x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Describe the bug
When you open the Diagrams.net application in Minimal theme and open the Find/Replace dialog, 4 buttons are displayed vertically. The 4th button (Replace All) however is not completely visible.
To Reproduce
Steps to reproduce the behavior:

Go to Extras -> Theme -> Minimal
Restart Diagrams.net
Go to Diagram -> Find/Replace
See error

Expected behavior
All buttons visible
Screenshots
If applicable, add screenshots to help explain your problem.

draw.io version (In the Help->About menu of the draw.io editor):

draw.io version [e.g. 14.5.1]

Desktop (please complete the following information):

OS: Windows
Browser Firefox
Version 86

Reproduced in 14.5.1 in Chrome Incognito.

Thanks for the report. This will be fixed in the next release.


how to access session from inside and Event Hook

how to access session from inside and Event Hook
/// <reference path="../pb_data/types.d.ts" />

onRecordCreate((e) => {

  e.user ??? how to do this

    e.next(); // Continue with the request
}, "posts");

There is no such field as e.user (if you used an llm to generate this code, please stop!).
Note also that onRecordCreate is a db model hook, aka. it could be triggered by a non-request context (cli, cron, when manually invoking $app.save(record), etc.) and has no information about the request that may have triggered it.
For the request hooks you can check https://pocketbase.io/docs/js-event-hooks/#request-hooks. The event of a request hook inherits all RequestEvent fields and methods from https://pocketbase.io/docs/go-routing/. Or in other words:
onRecordCreateRequest((e) => {
    // see https://pocketbase.io/docs/js-routing/#retrieving-the-current-auth-state
    let auth = e.auth // could be null or auth record (user, superuser, etc.)

    e.next();
}, "posts");

In any case, the issues tracker for this type of posts. For other questions please use the Q&A discussions instead as the threaded format is more suitable for it.

The behavior I'm looking for is to ensure that the createdBy passed is equal to the user's ID, to prevent Identity Spoofing.

You can do that with an API rule such as @request.auth.id != "" && createdBy = @request.auth.id.
You can also enforce the field value with the hook by doing something like:
onRecordCreateRequest((e) => {
    if (e.hasSuperuserAuth()) {
        return e.next() // ignore for superusers
    }

    // overwrite the submitted createdBy with the id of the currently authenticated user
    e.record.set("createdBy", e.auth?.id)

    e.next();
}, "posts");

But again, please for other questions, use the Q&A discussions.

But again, please for other questions, use the Q&A discussions.
oh sorry, i didn't notice it the first time.
I got used scanning the text rather than reading it