FlutterFragmentActivity causing MissingPluginException

In my project I am trying to use biometrics which requires changing the android activity to be a FlutterFragmentActivity.
When using other plugins, a MissingPluginException is thrown.
I have found similar people with the issue in the past.  Most of these posts are multiple years old, and I have attempted their solutions https://stackoverflow.com/questions/62210423/flutter-local-auth-doesnt-work-on-android-28
The solutions then, seemed to be update the activity file with: GeneratedPluginRegistrant.registerWith(flutterEngine);
I have tried adding that, some say that should no longer be required, I have tried it without that in there.  I have also tried in my AndroidManifest.xml to have the fragment activity referenced directly: android:name="io.flutter.embedding.android.FlutterFragmentActivity" , but that hasn't proved successful either.
Steps to reproduce

Create new flutter project
Import barcode scanning plugin: flutter_barcode_scanner: ^2.0.0 note, this example includes the flutter_barcode_scanner specifically but this affects any plugin using method channels
Change main.dart to be code in example code section,  specifically including the following line to a button:  Future<String> scanBarcodeMobile() async {  return await FlutterBarcodeScanner.scanBarcode(      "Red", "Cancel", false, ScanMode.DEFAULT); }
Run project on an android device, verify that scanner button works
Change MainActivity to be FlutterFragmentActivity ( see example code for details)
Run project again, verify that scanner example page works

Expected results
Excepted results is that the change to the flutter fragment activity does not affect the bar code scanning plugin (or other plugins for that matter)
Actual results
After changing the activity, the calls to other plugins causes a crash with:
MissingPluginException (MissingPluginException(No implementation found for method scanBarcode on channel flutter_barcode_scanner))
Code sample
Example project is attached
ExampleProject.zip
Main app files:
import 'package:flutter/material.dart';
import 'package:flutter_barcode_scanner/flutter_barcode_scanner.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
        useMaterial3: true,
      ),
      home: const MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({super.key, required this.title});
  final String title;

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        backgroundColor: Theme.of(context).colorScheme.inversePrimary,
        title: Text(widget.title),
      ),
      body: Center(child:
        ElevatedButton(onPressed: () async {
          await FlutterBarcodeScanner.scanBarcode(
                "Red", "Cancel", false, ScanMode.DEFAULT);
        },child: const Text("Scan barcode"),)
      ),
    );
  }
}

pubspec.yaml
name: fragment_repo
description: "A new Flutter project."
publish_to: 'none' # Remove this line if you wish to publish to pub.dev

version: 1.0.0+1

environment:
  sdk: '>=3.3.4 <4.0.0'

dependencies:
  flutter:
    sdk: flutter
  flutter_barcode_scanner: ^2.0.0
  cupertino_icons: ^1.0.6

dev_dependencies:
  flutter_test:
    sdk: flutter
  flutter_lints: ^3.0.0
flutter:
  uses-material-design: true

MainActivity.kt
package com.example.fragment_repo

import androidx.annotation.NonNull;
import io.flutter.embedding.android.FlutterFragmentActivity
import io.flutter.embedding.engine.FlutterEngine
import io.flutter.plugins.GeneratedPluginRegistrant

class MainActivity: FlutterFragmentActivity() {
    override fun configureFlutterEngine(@NonNull flutterEngine: FlutterEngine) {
        super.configureFlutterEngine(flutterEngine);
        GeneratedPluginRegistrant.registerWith(flutterEngine);
    }
}

AndroidManifest.xml
<manifest xmlns:android="http://schemas.android.com/apk/res/android">
    <application
        android:label="fragment_repo"
        android:name="${applicationName}"
        android:icon="@mipmap/ic_launcher">
        <activity
            android:name=".MainActivity"
            android:exported="true"
            android:launchMode="singleTop"
            android:theme="@style/LaunchTheme"
            android:configChanges="orientation|keyboardHidden|keyboard|screenSize|smallestScreenSize|locale|layoutDirection|fontScale|screenLayout|density|uiMode"
            android:hardwareAccelerated="true"
            android:windowSoftInputMode="adjustResize">
            <!-- Specifies an Android theme to apply to this Activity as soon as
                 the Android process has started. This theme is visible to the user
                 while the Flutter UI initializes. After that, this theme continues
                 to determine the Window background behind the Flutter UI. -->
            <meta-data
              android:name="io.flutter.embedding.android.NormalTheme"
              android:resource="@style/NormalTheme"
              />
            <intent-filter>
                <action android:name="android.intent.action.MAIN"/>
                <category android:name="android.intent.category.LAUNCHER"/>
            </intent-filter>
        </activity>
        <!-- Don't delete the meta-data below.
             This is used by the Flutter tool to generate GeneratedPluginRegistrant.java -->
        <meta-data
            android:name="flutterEmbedding"
            android:value="2" />
    </application>
    <!-- Required to query activities that can process text, see:
         https://developer.android.com/training/package-visibility?hl=en and
         https://developer.android.com/reference/android/content/Intent#ACTION_PROCESS_TEXT.

         In particular, this is used by the Flutter engine in io.flutter.plugin.text.ProcessTextPlugin. -->
    <queries>
        <intent>
            <action android:name="android.intent.action.PROCESS_TEXT"/>
            <data android:mimeType="text/plain"/>
        </intent>
    </queries>
</manifest>

Flutter Doctor output
Doctor output
Flutter 3.19.6 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 54e66469a9 (2 days ago) • 2024-04-17 13:08:03 -0700
Engine • revision c4cd48e186
Tools • Dart 3.3.4 • DevTools 2.31.1

Running flutter doctor...
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel stable, 3.19.6, on Microsoft Windows [Version 10.0.22631.3447], locale en-US)
[√] Windows Version (Installed version of Windows is version 10 or higher)
[√] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[√] Chrome - develop for the web
[√] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.9.3)
[√] Android Studio (version 2023.2)
[√] IntelliJ IDEA Community Edition (version 2021.3)
[√] VS Code (version 1.88.1)
[√] Connected device (4 available)
[√] Network resources

• No issues found!

@BrendanLacey
Since flutter_barcode_scanner is third party package, you'll need to report this in dedicated repo.
I see a similar issue in that repo that you can check : https://github.com/AmolGangadhare/flutter_barcode_scanner/issues/261
Closing from here.


When enter "Story Mode" it will Enter "Song" or "Week" instead of story menu

Describe your problem here.
How to make a game enter a week or a song of the week when entering "Story Mode" I try to use from this one [#937] but it doesn't seem to work
this is the error I got after inserting the code
source/MainMenuState.hx:230: characters 89-95 : Unknown identifier : diffic
source/MainMenuState.hx:230: characters 89-95 : For function argument 'jsonInput'

can someone help me how to do this, please :(
I know this is duplicated of #937 but I got the error so...
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
I edited Achievement.hx, PlayState.hx, MainMenuState.hx, FreeplayState.hx, Discord.hx, CoolUtili.hx, and more idk

> Describe your problem here.
How to make a game enter a week or a song of the week when entering "Story Mode" I try to use from this one [#937] but it doesn't seem to work
this is the error I got after inserting the code
source/MainMenuState.hx:230: characters 89-95 : Unknown identifier : diffic
source/MainMenuState.hx:230: characters 89-95 : For function argument 'jsonInput'
can someone help me how to do this, please :(
I know this is duplicated of #937 but I got the error so...
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
I edited Achievement.hx, PlayState.hx, MainMenuState.hx, FreeplayState.hx, Discord.hx, CoolUtili.hx, and more idk
as someone who has tried it yes these are the exact errors i get when compiling

Show your code unless you expect me to guess your exact issue.

Show your code unless you expect me to guess your exact issue.

This one is the code I took from #937
var weekNumber:Int = 0;
var songsPlaylist:Array<String> = [
	'Satin Panties',
	'High',
	'Milf'
];

PlayState.storyPlaylist = songsPlaylist;
PlayState.isStoryMode = true;
PlayState.storyDifficulty = 2;

PlayState.SONG = Song.loadFromJson(PlayState.storyPlaylist[0].toLowerCase() + diffic, PlayState.storyPlaylist[0].toLowerCase());
PlayState.storyWeek = weekNumber;
PlayState.campaignScore = 0;
PlayState.campaignMisses = 0;
LoadingState.loadAndSwitchState(new PlayState(), true);

After I open this issue I edit some of code to this.
var weekNumber:Int = 0;
var songsPlaylist:Array<String> = [
	'Tutorial'
];

PlayState.storyPlaylist = songsPlaylist;
PlayState.isStoryMode = true;
PlayState.storyDifficulty = 2;

PlayState.SONG = Song.loadFromJson(PlayState.storyPlaylist[0].toLowerCase() + '-hard', PlayState.storyPlaylist[0].toLowerCase());
PlayState.storyWeek = weekNumber;
PlayState.campaignScore = 0;
PlayState.campaignMisses = 0;
LoadingState.loadAndSwitchState(new PlayState(), true);

It's got no error but the game crash after entering story mode.

This mod i did some minor help with includes this. https://gamebanana.com/mods/341936


BetterDiscord not working

Discord recently updated itself to 0.0.10, and BetterDiscord stopped working.
I am using the Stable release of Discord via Flatpak.
This is output of web console after opening the Discord client after BD injection:

if it can help.
I have already tried to reinstall both Discord and BD, no fix.

Run betterdiscordctl update.

This is not fixed? I've run betterdiscordctl update, reinstalled, removed and installed, launching Discord every operation.
BetterDiscord still doesn't show up.


Feature Request: IDE plugin to add files in context by tapping shortcut key

Issue
Issue: It takes time to write '/add ' every time for each file.
Solution:
Double tap to a key from the keyboard when you are in a file, and it will add the file automatically to context. P.s You should have the mouse cursor in the interior of the file.
Probably this can be done by having an IDE plugin in Jetbrains / vscode

Thanks for trying aider and filing this issue.
This would require per-IDE integration with aider, and is probably out of scope.

@EliseiNicolae
If you are working with Jetbrains IDE, you can have a look at https://github.com/Aider-AI/aider/issues/2066.
I have a working solution, that I have been using for a while in my fork of aider.

I'm closing this issue because it has been stalled for 3 weeks with no activity. Feel free to add a comment here and we can re-open it. Or feel free to file a new issue at any time.Note: A bot script made these updates to the issue.


Chat - User mention is not highlighted as mention when mentioning someone in edited comment

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.65-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:

Go to staging.new.expensify.com
Go to chat.
Send a message.
Right click on the message > Edit comment.
Type @.
Select a user from the suggestion list.
Save the edit.

Expected Result:
The user mention in the edited message will be highlighted as mention.
Actual Result:
The user mention in the edited message is not highlighted as mention.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/Expensify/App/assets/115492554/65ba9e54-2158-4f57-90ea-f5708aa63bd8

View all open jobs on GitHub

@adelekennedy I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

We think this issue might be related to the #vip-vsb.

Production

This is technically not in production so its not a blocker but I agree this should be addressed in the PR

We are going to revert this PR https://github.com/Expensify/App/pull/35226 and @dukenv0307 can you please work on implementing this in there too as I think it should be part of the initial implementation (it looks weird when you choose the mention and its not saved that way)

I see the new Pr links this issue so I think we can close it for now


There are colors embedded in the JavaScript

Search for '1px solid' and you will find color references to silver, #aaa, #ddd, #BABABA, #efefef, etc. in w2field.js, w2grid.js, w2toolbar.js, and w2utils.js.  Why was this done and can I fix it?
This is a great library except for how difficult it has been to restyle it to fix nicely into my site.  How are the colors managed?  There are so many colors used all over the .less, why not user variables for the colors to make it easier to restyle, especially the colors?

Moving the styling away from the DOM and into the CSS file (where it makes sense) is on the roadmap for 2.0
I will tag this issue as a feature request and leave it open for now.

with 2.0 released, is this fixed?


chore: import repository https://github.com/babadofar/spring-demo.git

this commit will trigger a pipeline to generate the CI/CD configuration which will create a second commit on this Pull Request before it auto merges

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign
You can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


dev: enable npm config engine-strict

Add engine-strict to .npmrc to enforce minimum npm and node version specified in section engines of package.json.
Thereby also updating the minimum npm version from v7.0.0 to v8.0.0 and node from v16.0.0 to v16.11.0. This is to prevent annoying diffs to package-lock.json when installing new packages.
If you try to execute npm install with an unsupported version, you will now get the following message indicating you to update your setup, e.g. with npm install npm -g and nvm install --lts (in case you are using nvm):
[user@home joinmarket-webui]$ npm i
npm i
npm ERR! code EBADENGINE
npm ERR! engine Unsupported engine
npm ERR! engine Not compatible with your version of node/npm<EMAIL_ADDRESS>npm ERR! notsup Not compatible with your version of node/npm<EMAIL_ADDRESS>npm ERR! notsup Required: {"node":">=16.11.0","npm":">=8.0.0"}
npm ERR! notsup Actual:   {"npm":"1.2.3","node":"v4.5.6"}

Current settings are:
  "engines": {
    "node": ">=16.11.0",
    "npm": ">=8.0.0"
  },

node v16.11.0 has been specified, as it is an LTS release and the first version including npm >=v8.0.0. Please feel free to suggest other minimum version as you see fit. The only goal that must be achieved is preventing package-lock.json conflicts.

I used nvm to switch to node version 15.0.0 and then ran npm install, [...]

Hey! Thanks for verifying!
Hmm.. that does not seem quite right.. with engineStrict enabled, you should be getting an error..
Would you mind double-checking that you are on the correct branch?

Oops sorry, when I tested this it was late and you are correct - I was not on the right branch 😅
Here is the actual ouput:
mk@pop-os:~/Desktop/CODE/joinmarket-webui$ npm install
npm ERR! code EBADENGINE
npm ERR! engine Unsupported engine
npm ERR! engine Not compatible with your version of node/npm<EMAIL_ADDRESS>npm ERR! notsup Not compatible with your version of node/npm<EMAIL_ADDRESS>npm ERR! notsup Required: {"node":"^12.22.0 || ^14.17.0 || >=16.0.0"}
npm ERR! notsup Actual:   {"npm":"7.0.2","node":"v15.0.0"}

npm ERR!


Adding ÖbEngine

Closes #243
Why do you think the link is worth adding on this list?
As stated in #243, ÖbEngine is free modern C++ game engine on top of the SFML 2.5.1, using Lua as its scripting language, working on Windows, Linux and MacOS.
It's sponsored by a few big companies such as JetBrain, DigitalOcean and GitHub, just so you know it's not another project which will go under water in 2 weeks.
Does this project has any License?
It's under the MIT licence

thanks @SuperFola


Check OpenGL copy buffer capabilities

Follow up on #1129

Here's a first take on this:
https://github.com/lxnt/gfx/commit/187872018adf5f70b2bba1fec6f9c6a6679156a2
A getter of all things, and relevant to only one backend at that, but replicated across all.
Couldn't think up anything better.
As for caps vs privcaps - I think caps such as this one, and instance_call, separate_blending_slots, frame_buffer_support, the nonexistent one for glVertexAttribIPointer should be exposed somehow. Otherwise the application code either blindly crashes or reimplements the capability detection.
PS. clear_buffer_supported/glClearBufferfv and friends do not have any corresponding extension, so that TODO should be just dropped.

@lxnt I think you are over-complicating this.
All that needs to be done for this issue is a flag in public Capabilities that tells if you can call copy_buffer().

As for caps vs privcaps - I think caps such as this one, and instance_call, separate_blending_slots, frame_buffer_support, the nonexistent one for glVertexAttribIPointer should be exposed somehow.

instance_call_supported and separate_blending_slots_supported are already exposed in Capabilties.
frame_buffer_support and glVertexAttribIPointer are so marginal I don't think anyone cares about machines that don't support them. We can safely assume the user has these as a baseline. Remember: the main focus of gfx-rs is modern API compatibility.

clear_buffer_supported/glClearBufferfv and friends do not have any corresponding extension, so that TODO should be just dropped.

Agreed.

@lxnt I think you are over-complicating this.
All that needs to be done for this issue is a flag in public Capabilities that tells if you can call copy_buffer().

Well, there were words of checking in the encoder.. But you are right. Here goes a PR.

Ah, right. Checking in the encoder and returning an error early would be nice. Now I see that your original code does that.

Should I submit a PR with checks in the encoder?
If so, is the approach with cap getters in the Buffer trait acceptable, or there is some better way?

@lxnt I don't think we should have the public capability checks in both Encoder and Capabilities. Just the latter should be fine. The encoder needs to know about some of the flags, so that it can return an error if appropriate, but it doesn't need to have the flag getters.
Other than this little thing, yes, the PR would be nice!

Is this issue still applicable? If so, where would the changes go?

@lxnt I don't think we should have the public capability checks in both Encoder and Capabilities. Just the latter should be fine. The encoder needs to know about some of the flags, so that it can return an error if appropriate, but it doesn't need to have the flag getters.
Other than this little thing, yes, the PR would be nice!

Encoder doesn't seem to exist anymore for OpenGL, where would be the right place to add these checks?

Thanks for triaging @GabrielMajeri ! I think this was for pre-ll, marking accordingly and closing.


'txn type' encoding not consistent

Up until round no. 8734689, the type of transactions saved in UTF-8 encoding.
Starting round no. 8734690 it's saved in base64
Restoring the issue:

select distinct(txn -> 'txn' -> 'type') from txn where round between 8734680 and 8734689
?column?
0	pay
1	axfer

select distinct(txn -> 'txn' -> 'type') from txn where round between 8734690 and 8734700
?column?
0	YXhmZXI=
1	cGF5

select distinct(txn -> 'txn' -> 'type') from txn where round between 8734689 and 8734690
?column?
0	pay
1	YXhmZXI=
2	cGF5
3	axfer

implementation note: in idb/postgres/postgres.go just inside func (db *PostgresIndexerDb) AddTransaction(...) creating the json with
jsonbytes := idb.JsonOneLine(txn)
consistently makes txn.txn -> 'txn' -> 'type' be text and not base64, but e2e test fails in a way that needs further observation.


[Bug]: Sugar Reveal gives an error running command.

Issue description
It gives an error when I run Sugar Reveal @samuelvanderwaal
Relevant log output

Priority this issue should have
High (immediate attention needed)

Issue description
It gives an error when I run Sugar Reveal @samuelvanderwaal
Relevant log output

Priority this issue should have
High (immediate attention needed)

Reveal is a very heavy command that requires a custom RPC. It's not going to work on the public default ones.

But I am testing it on devnet shouldn't it work their ofcourse for launching the collection I'll use a cutom mainnet rpc but before I have to test that all works perfectly.

@samuelvanderwaal But I am testing it on devnet shouldn't it work their ofcourse for launching the collection I'll use a cutom mainnet rpc but before I have to test that all works perfectly.

Try using QuickNode's free devnet node and see if it works with that. If not, we may need to allow setting a longer timeout in Sugar.

@samuelvanderwaal But I am testing it on devnet shouldn't it work their ofcourse for launching the collection I'll use a cutom mainnet rpc but before I have to test that all works perfectly.

Try using QuickNode's free devnet node and see if it works with that. If not, we may need to allow setting a longer timeout in Sugar.

I'll try it and get back to you but can you add -t (timeout) option also in sugar reveal though I have a big collection of 6000 NFTs. But I am testing only with 10 NFTs and it still gives error I'll try to it with quicknodes devnet rpc and get back to you ASAP.

bro, it still didn't work. I used a custom devnet rpc also

used quicknodes devnet rpc and it worked so closing the issue thanks.


Appstudio update test-component-pac-odxo

Pipelines as Code configuration proposal

Pipelines as Code CI/test-component-pac-odxo-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
12 seconds
init

✅ Succeeded
42 seconds
clone-repository

✅ Succeeded
1 minute
build-container

✅ Succeeded
20 seconds
sanity-inspect-image

✅ Succeeded
3 minutes
clair-scan

✅ Succeeded
22 seconds
deprecated-base-image-check

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
26 seconds
sbom-json-check

✅ Succeeded
9 seconds
sanity-label-check

✅ Succeeded
11 seconds
sanity-optional-label-check

✅ Succeeded
14 seconds
show-summary

Pipelines as Code CI/test-component-pac-odxo-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
12 seconds
init

✅ Succeeded
42 seconds
clone-repository

✅ Succeeded
1 minute
build-container

✅ Succeeded
3 minutes
clair-scan

✅ Succeeded
20 seconds
sanity-inspect-image

✅ Succeeded
22 seconds
deprecated-base-image-check

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
26 seconds
sbom-json-check

✅ Succeeded
9 seconds
sanity-label-check

✅ Succeeded
11 seconds
sanity-optional-label-check

✅ Succeeded
14 seconds
show-summary

Pipelines as Code CI/test-component-pac-odxo-on-pull-request has successfully validated your commit.


Question:  Can expiration days  be null?

As I review the code I can use it to store data even not from http. For example I am using akavache as to store user results. If user plays a game, I create object with akavache and using "Save" I save it and "Get" to display results. Therefore those in app data never gets expired. Is it possible to that? Akavache exposes this parameter as nullable.

Ok, actually you  described clearly that it is in our hand to handle network, expiration and reretrieve cases. I was confused because i jumped to code first :) I still believe if parameter days could be nullable for the users who dont want their data to be never expired even though we can handle it ourselves, just to remove confusion :)

Yeah, I mean you could just set it to 1000 years in the future too as an option.


Field Widths do not save

With a grid output the the field widths seem to be set some arbitrary value sometimes either hiding the field title or the cell content. When adjusting the width manually this does not save. Also when making the field width wider a scrollbar appears as if there is additional hidden content to the right of the visible fields.
Modifying percent width (even setting to 0) or the maximum width does not have any positive effect.
A good example of this is the Virtual Machines Key Metrics workbook.

The portal framework team is actively working on changing the behavior of grid column sizing everywhere in the portal to meet some accessibility requirements.  We've also been following along, trying to fix things in response to their changes as they go.
unfortunately, because of the holiday lockdowns (which were then extended for JEDI), there appear to be a lot of partially deployed things even within the portal framework itself in the MPAC environment.  in those cases, the portal appears to be making all columns uniform width no matter what we tell it to do.
Workbooks attempts to auto size most columns, using the column header width as a starting point.  some of the columns, like bars, timelines, sparks are fixed widths.
if you have specific examples, paste screenshots, etc here with as much details as you can.  Depending on environment, browser, portalfx version, etc, there are a lot of strange cases right now.


Mobile devices should be served with SD versions

As iPhone and Android won't play most high res MP4 files, they should be served with the SD version by default.

Useless, the players will do so by default.


UI: Update Evaluate/Submit Module Filtering

User Story
As a ECMPS user I want the evaluate/submit module to display all of my unsubmitted workspace data by default so that I can see all of my data at once and apply filters to refine my search
Acceptance Criteria
Given that a user has navigated to the evaluate or submit module
When the functionality is displayed
Then all of the unsubmitted , granted, or required workspace data is displayed
Given that a user has selected filter criteria
When the filter criteria is applied
Then the data displayed is narrowed based on applied criteria
Given that a user has updated filter criteria
When the functionality is displayed
Then the data displayed is narrowed based on applied criteria
Given that a user has removed all filter criteria
When the functionality is displayed
Then the all of the unsubmitted workspace data is displayed
Context
During refinement on 10/3 Chris W discussed wanting to update the filtering of the evaluate and submit module

During 10/18 discussed that this ticket is a low priority and should not be worked on until EPA gives the ok


[Toggle group] Not selectable using keyboard

Toggle group not selectable using keyboard.

@jsardid Any update on this issue? Please share ECD.
Also we found that Calendar icon is also not selectable using keyboard while tabbing. Please suggest if that can be covered under this bug or need to raise separate ticket?

@pwadhwani these two issues have been fixed, and for now they are available in "next".
We'll include these fixes in the next numbered release.


facing issue when used custom pagination

when i'm switching through custom pagination, i'm facing issue the following issue. I'm using swiper v4.4.1.  Can you guys help me with this. Thanks

Your issue is closed because it is not filled correctly. Before you open an issue please review the contributing guideline.
Please fill the issue template correctly and:

Clearly describe the issue including steps to reproduce when it is a bug.
Make sure you fill in the earliest version that you know has the issue.
Provide live link or JSFiddle/Codepen or website with isssue

It will save a lot of time for other contributors to check your issue and fix it.


Help with Spark Cassandra Join ClassCastException

I am getting an error in the Transformation.scala in the computeExchangeRates method when joining the blockDate table with the
exchangeRates, see below.
blocksDate.join(exchangeRates, Seq(F.date), "left")
The error message is:
Exception in thread "main" java.lang.ClassCastException: scala.Tuple8 cannot be cast to scala.Tuple7 at org.apache.spark.sql.cassandra.execution.CassandraDirectJoinStrategy.apply(CassandraDirectJoinStrategy.scala:27)
It seems to be a problem with my setup as the sbt test works fine. I am using cassandra v3.11.13 and Spark 3.3.0. Your help is greatly appreciated

The DataStax Spark Cassandra Connector has no official support for Spark 3.3.0 at the moment, see https://github.com/datastax/spark-cassandra-connector#version-compatibility

Connector
Spark
Cassandra
Cassandra Java Driver
Minimum Java Version
Supported Scala Versions

3.2
3.2
2.1.5*, 2.2, 3.x, 4.0
4.13
8
2.12

3.1
3.1
2.1.5*, 2.2, 3.x, 4.0
4.12
8
2.12

3.0
3.0
2.1.5*, 2.2, 3.x, 4.0
4.12
8
2.12

Thank you, indeed this was the problem. It works now after downgrading to spark 3.2.


Get tests to pass in AppVeyor

vstest.console /logger:Appveyor "C:\projects\sourcecode-smartobjects-services-tests\src\bin\Debug\SourceCode.SmartObjects.Services.Tests.dll" "C:\projects\sourcecode-smartobjects-services-tests\Tests\UTest\bin\Debug\SourceCode.SmartObjects.Services.Tests.UTest.dll"
Microsoft (R) Test Execution Command Line Tool Version 14.0.25420.1
Copyright (c) Microsoft Corporation.  All rights reserved.
Starting test execution, please wait...
Warning: No test is available in C:\projects\sourcecode-smartobjects-services-tests\src\bin\Debug\SourceCode.SmartObjects.Services.Tests.dll C:\projects\sourcecode-smartobjects-services-tests\Tests\UTest\bin\Debug\SourceCode.SmartObjects.Services.Tests.UTest.dll. Make sure that installed test discoverers & executors, platform & framework version settings are appropriate and try again.
Information: Additionally, you can try specifying '/UseVsixExtensions' command if the test discoverer & executor is installed on the machine as vsix extensions and your installation supports vsix extensions. Example: vstest.console.exe myTests.dll /UseVsixExtensions:true
Build success

Major changes:
appveyor.yml
image: Visual Studio 2017
test_script:

vstest.console /Platform:x64 /InIsolation /logger:Appveyor "src\Tests\UTest\bin\Release\SourceCode.SmartObjects.Services.Tests.UTest.dll"


Hero image or image in article card doesn't show alt text value

Even though I set the alt text on hero image while creating the post, it doesn't appear after publishing. It is always blank.
Checked in hero.hbs of the theme and found it is not reading the alt value and setting it to empty always.

How to resolve this?
Images in article cards on home page have similar issue but I couldn't find the source of it. I am new to ghost and this ecosystem, so any help will be appreciated.

I had an issue with the hero image srcset, due to the wget -k command I was using to fetch the static site. I edited the hbs file such that the whole <img ... /> is in the same line. That fixed the issue. It may help

@abarajithan11 Thanks. Can you guide me on how to set the alt attribute dynamically on this image tag? I believe the alt attribute is getting saved with post but I am not sure how to retrieve it.
Is there any helper like img_url to read the alt attribute of the image?

I'm not sure about it. I haven't tried that

@kumarvikram You can use alt="{{alt_image}}"
I will fix this in a next update but for now you can add this code.

@eddiesigner Thanks but it is not working. Just rendering empty alt attribute.

@kumarvikram Sorry, the correct attribute is alt="{{feature_image_alt}}"

I will close this issue now since this was fixed in the latest version.


upgrade to latest spring boot version

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot


No Y axis movements

Thanks Kevin for your fantastic work!
I came across an issue when I was analysing videos. When people walk towards to the camera, the   3d coordinates on y axis are not changed or changed slightly. Could I ask is there any settings to upgrade the performance?
I use Openpose with max accuracy settings to generate 2d data and the VideoPose3D pre-trained model to convert to 3d. The video is very simple, just a person walks towards to the camera with the distance around 7 meters.
Thanks again!
Looking forward to hearing from you!
Aaron

Hi, Aaron,
The estimated 3D joint positions are relative to root joint(hip), so global translation is not supported.
There are some works focus on absolute human pose estimation, such as Absolute Human Pose Estimation with Depth Prediction Network, you can refer to this paper for more information.

Thanks Kevin for your reply and suggestion!
OK, I understand. That could be very useful.
Thanks again for your work and sharing this project!
Regards,
Aaron


Snapshot features: n_degrees_of_freedom and instantaneous_temperature

Note: these are not intended to be features that are required of every engine. However, they could be very useful.
In particular, I'm pretty sure we want something like n_degrees_of_freedom: that shows up in enough other calculations, and will be very much engine dependent. Not having this leads to all sorts of ugliness when I wanted to check instantaneous temperature in the AD TPS example: a lot of code that is OpenMM-specific.
Whether we directly include instantaneous_temperature is a little less vital, in my opinion. A competent user can handle that little bit of code for their engine. For now, I've added it for consideration.

[x] Draft n_degrees_of_freedom and instantaneous_temperature for OpenMM
[x] Draft n_degrees_of_freedom and instantaneous_temperature for Toy engine
[x] Tests for n_degrees_of_freedom and instantaneous_temperature for OpenMM
[x] Tests for n_degrees_of_freedom and instantaneous_temperature for Toy engine
[x] Add docstrings

Came across a problem with this: Need @jhprinz's advice on how to handle it best with respect to proper storage.
Problem:
import openpathsampling.engines.openmm as omm_engine
import openmmtools as omt

test_system = omt.testsystems.AlanineDipeptideVacuum()
template = omm_engine.snapshot_from_testsystem(test_system)
engine = omm_engine.Engine(
    topology=template.topology,
    system=test_system.system,
    integrator=omt.integrators.VVVRIntegrator()
)

engine.current_snapshot = template

print type(template.engine)
# <class 'openpathsampling.engines.openmm.tools.OpenMMToolsTestsystemEngine'>
print type(engine.current_snapshot)
# <class 'openpathsampling.engines.openmm.tools.OpenMMToolsTestsystemEngine'>

snapshot = engine.generate(engine.current_snapshot, [lambda x, foo: len(x) <= 1])[0]
print type(engine.current_snapshot.engine)
# <class 'openpathsampling.engines.openmm.engine.OpenMMEngine'>

I think we want current_snapshot to always return an a snapshot with the OpenMMEngine as engine. Otherwise, accessing these attributes before we've run the simulation (e.g., first frame) will crash, because OpenMMToolsTestsystemEngine has no simulation object to find the
I see two approaches to fix this. Either make sure that we have the right engine when we set current_snapshot, or make sure we have the right engine when we get current_snapshot. The implementation I'm playing with now is based on giving the correct engine when we set it. It involves adding an extra if statement in the setter:
            # After the updates cache the new snapshot
            if snapshot.engine is self:
                # no need for copy if this snap is from this engine
                self._current_snapshot = snapshot
            else:
                self._current_snapshot = self._build_current_snapshot()

This way the thing in self._current_snapshot always comes from this engine.

This approach should work and I also prefer to directly alter the snapshot once you set it. For storage this should not matter at all since the stored engine is completely independent of the current snapshot.
To make sure: You want this so that for sure each snapshot from the engine you have access to all attributes that snapshots from the engine should have. I think that makes sense. Go ahead and add this in this PR if you want.

Passes tests, ready for review!

Looks good.


Why sentry don't use laravel's "remember me" strategy?

laravel there is a remember_token,but sentry there is no this field,why ? I think laravel's strategy is better,could sentry support it to work together with laravel better?

+1

It could, but Sentry is feature freeze now.
This feature is included on our premium Sentinel package.

It's an improvement not a feature.

@StarpTech Sorry to disagree with you, but it's a feature.
You'll need to create a new migration to add a new field to the database, do the necessary code changes to make it work, add tests and bump the minor.
If it was an improvement, you would only bump the patch, as to me, improvements are to make the code more faster, readable, cleaner.. not to implement any new functionality.
Has a said, Sentry is feature freeze, therefore no new features will be implemented at this time.


Getting Index Error

@quark0  Sir,
IndexError: invalid index of a 0-dim tensor. Use tensor.item() in Python or tensor.item<T>() in C++ to convert a 0-dim tensor to a number
I am getting the above error when i try to run the  following command " cd cnn && python test.py --auxiliary --model_path cifar10_model.pt" for cifar 10

Thank you in Advance.

The index error occurs in PyTorch >= 0.5. You could replace loss.data[0] by loss.data and all other related areas, or downgrade the PyTorch version. For more information about this error, you could refer to this link.


Seek never completes with target before buffer and inside small gap limit

Have you read the FAQ and checked for duplicate open issues?
yes
What version of Shaka Player are you using?
2.5.6
Can you reproduce the issue with our latest release version?
yes
Can you reproduce the issue with the latest code from master?
(I am not building the player from source)
Are you using the demo app or your own custom app?
Custom
If custom app, can you reproduce the issue using our demo app?
This issue would be difficult to reproduce using manual controls.
What browser and OS are you using?
Windows 10, Chrome latest
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
What are the manifest and license server URIs?

unencrypted
What did you do?

See This Repo for reproduction.
seek to ~1 minute, then seek backwards 1s at a time (arrow left...) until the video freezes but the reported time continues to change by -1s.
What did you expect to happen?
The video should not freeze.  The player should load buffers and seek in video.
What actually happened?

When the requested time is before the start of the first buffer loaded by up to config.streaming.smallGapLimit, buffers are cleared but not loaded, and the seek does not complete, but the currentTime changes.  (i.e. the video freezes).
When the seeked time is < (time of last first buffer - smallGapLimit) or > (time of last first buffer), normal seeking is resumed.
Note: I have not checked the exact numbers :).

It's often that I can seek in the video, never see a 'seeked' event, and for shaka (and video element) to report a time which is not matching the time displayed in the video.
Question:
Any advice on ideal media (segment size, etc.) and player config for best seeking response would be happily received.
I'm really happy with HTML5 video with straight MP4, but now I need to support encryption, and it's killing my seeking performance, even locally served. - e.g. if anyone knows how to tune the player so that it allows frame seeks backwards with fewer 'stalls then rushes', please pipe up :).

Playing some more, I have just noticed that in very slow reverse seeking, there are 'holes' where the video does not change, but reports a new time.
When seeking frame fwd or frame back inside a 'hole', only a 'seeking' event is generated.
Once you seek beyond the 'hole', you can seek back into it successfully.
When seeking outside of a 'hole', you get seeking, volumechanged, seeked, canplay, canplaytrough.
for the 2 second segment media, the holes are 0.5s in size, and may occur every 3 (!!??) seconds.

I tried playing your repro page, served from a local server, and the video won't play at all. I'm getting errors that suggest that your webm is malformed in some way?
I'm not an expert in the webm format, so I can't say for sure what the exact problem is, but it looks like the parser is expecting the first element to start with an ID of 0x1c53bb6b and it didn't? Something like that. Did you put the wrong media files in the github page or something?

hmmm... that's really strange.
Just now I downloaded as a zip from github, unzipped, then opened 'web server for chrome' (which is pointing to a folder some folders below the 'shakatest-master' folder), navigated to the folder.  As soon as it hits the folder, it displays the index.html, I chose the '10s' version, and it loads the video fine....
Did you clone the repo?  Maybe git is corrupting the webm on extraction?

Turns out the problem was on my end. I was using the SimpleHTTPServer python module for making a local web server, and on further inspection the server was getting tons of broken pipe errors and such. I tried again with a different method, and it played as expected. So I think the web server was probably sending incomplete webm files or something.
Sorry for the confusion. I'll look into it.

So, when you say that video "stalls", do you mean that it stops visually updating? Looking at your code, the "bad reverse" does cause the video to not change (mostly), but it will work fine the moment you stop reversing, so I'm not sure if I would call that a "stall" really.
Examining how your "bad reverse" works, it looks like what is happening is that you are repeatedly performing unbuffered seeks, without giving it any chance to buffer.
You seek forward to 60s, and (as this is an unbuffered seek, as you are seeking far past the end of the buffer) Shaka Player clears the buffer and starts loading this new content.
Then, before it finishes loading, you seek backwards. As there is no loaded content at all, this is technically an unbuffered seek, so it clears the buffer again and begins loading content again.
And so on and so forth.
Occasionally the image will update. This happens when Shaka Player manages to get a playable amount of content in 100ms.
About the "holes" you mention, I am not as sure, but I think what you are seeing is the segment boundaries? As we are buffering ahead but you are playing backwards, whenever you get to a new segment it has to be buffered. config.streaming.smallGapLimit happens to, among other things, control an optimization that causes us to be a bit more generous when trying to figure out when we need to load a new segment... but since you're playing backwards, that config value is having the opposite effect and making everything less generous, causing it to not buffer until a bit too late when it hits a segment boundary. That's just a guess though.
On a side note, have you tried to use trick play mode instead? That's our first-party support for rewinding (and also fast forwarding).

Yes, the test is agressive and abusive to the system :).
ok, revisited today.
For info only, skip to 'I have changed...' below.....
The 'stall' I see is where the video stops updating visually, but the seek bar and currentTime are updated.
Your explanation makes complete sense; but not sure how the version served from gihub (https://btsimonh.github.io/shakatest/) achieves seeks more often, but when served locally very much less often; maybe the caching headers from the server are different, and so it's actually MORE efficient when the same segment is request multiple times?
I think maybe it's the 'holes' which threw me - but previously I definitely had times where the video was stopped, and the time and time displayed mismatched; maybe I just happened to stop seeking at a time when the video time was in one of these 'holes', and so the video did not update.  This then lead me to try the 'reverse' thing to see if I could reproduce with something simple, and I think I interpreted the lack of  display as the same issue?
That the behaviour is avoided by not seeking if performingUpdate is true for either stream is obvious now - this basically gives the player time to finish loading the segments before another seek is done.. and then the next seek is likely to be a buffered seek.
I have changed the report to 'unbuffered seek into a gap created by smallGapLimit never completes'.
I also modified the first comment to reflect the new thoughts.
This is very easily reproduced, e.g. by setting an unreasonably large smallGapLimit:
var config = {
    abr: {
      enabled:false,
    },
    streaming:{
      smallGapLimit:9,
    }
  };

Then on the test page, just seek on the timeline to ~1m, then manually seek bwd (arrow left will go back 1 sec) - once you get beyond the start of the buffers, the seek will not complete until you are 9s before the start of buffers...
I have modified the test repo accordingly, commented out the interval based seek, and modified the readme.  The issue can be easily reproduced served from remote or local - updated on https://btsimonh.github.io/shakatest/ now.
I didn't consider trick play yet; my thought being that since I'm serving locally, actually my data is available very quickly.
Q: I note the suggested caching mechanism using service_worker.  Is there any thought to cache segment data locally - it seems that in an unbuffered seek the segment data is always discarded completely and re-requested, whereas in my case of stepping backwards, for example, off the start of the available segments, the player would benefit from knowing it has all except one of the required segments to hand?

The issue is that if a seek aims for a time which is < smallgaplimit before the first segment, then the seek does not complete, however small the smallgaplimit - by design the player does not load the required segment, and all other segment data has been discarded (is this true?), so the browser cannot recover?

I was sure this was not accurate, but it seems you're right.  With the default config, I can reproduce this easily with our demo content.  For example, playing "Angel One", which is short, you can easily see the buffered ranges in the UI.  Around time 30, it starts clearing segments from the buffer.  At that time, you can run this in the console to reproduce the issue: video.currentTime = video.buffered.start(0) - 0.25 (since the small gap limit is 0.5).
It should also be fairly easy to reproduce this in a unit test.
I'm not sure why this would happen, though.  The seek to a time before the buffer start should count as an unbuffered seek, which would cause the buffers to be cleared and new segments to be fetched.  But this doesn't appear to happen.
In the failed state, StreamingEngine has a lastSegmentReference in both video and audio in mediaStates_.

So, I could expect this to affect anyone who steps back in a video, and is unlucky enough to click on the right portion of the timeline....

You're absolutely right.  It looks as though this could happen to anyone on any content.

thanks @joeyparrish for looking again.  Seems my abuse of the player has lead to some good :).

Yes, definitely.  We appreciate your persistence and patience with us.

Note: In the latest code from the master branch, it can be difficult to see when the early parts of the buffer have been cleared.  This is caused by a change to our default UI configuration.  To revert to the old UI behavior to make this bug easier to reproduce, use:
video.ui.configure('showUnbufferedStart', true);

After my refactors for #1339, this issue is still reproducible at the right time with:
video.currentTime = video.buffered.start(0) - 0.25;

A few notes for posterity as I debug this:
StallDetector waits for GapJumpingController to tell it to look for a stall.  GapJumpingController in this case is waiting on StreamingEngine to append a segment before it does anything.  And StreamingEngine is not fetching anything and has no scheduled updates.  If I force an update with this:
for (const type of ['audio', 'video']) {
  player.streamingEngine_.scheduleUpdate_(
      player.streamingEngine_.mediaStates_.get(type), 0);
}

Then getTimeNeeded_() returns 60, which is equal to video.duration, so we don't fetch anything.
video.buffered.start(0) is 20, and video.currentTime is 19.75.

getTimeNeeded_() is returning the end time of the last segment we appended.  The code which is supposed to handle this is the seeked() callback, which clears the buffer on an unbuffered seek.
The problem is that seeked() also considers the gap limits.  It sees that we are less than smallGapLimit outside of buffered content, so it doesn't clear the buffer.
Experimentally, if I seek 250ms before the buffer start, it won't play through the gap.  At 81ms, it won't play through.  At 80ms, it will finally play through.
These tests are on ChromeOS 80, with the "Angel One" clip in our demo.

If I disable gap-jumping and artificially create a gap at the beginning of playback by changing timestampOffset in StreamingEngine, ChromeOS 80 will play through a gap of up to 999ms in "Angel One".
If I do the same in the middle of the presentation instead of at the beginning, ChromeOS 80 will only play through a gap of up to 20ms.  Interestingly, Chrome shows a single buffered range when it is capable of playing through one of these gap between segments.
It seems that the root issue here, though, is that gap-jumping should take care of this, but it doesn't, because it's waiting for StreamingEngine to append something.  Meanwhile StreamingEngine does not clear the buffer or append anything new, because it knows that gap-jumping should kick in based on the gap-jumping config.  So we need a way to break this circular logic.

It's becoming more clear that the way gap-jumping and stall-detection work may not be fundamentally correct with respect to the browser behavior it's trying to compensate for.  It seems to work well enough in most cases, but this edge case is making me rethink things.
For now, I'm taking this issue out of the v2.6 milestone so that we can take time to look more closely at the design of these components.

:) so glad i did not try to fix it - i would have made it worse!  Thankyou so much for believing in my report!

I also facing a similar issue in shaka player.
The version of Shaka Player is 2.5.10
The issue is reproducible with the latest version.
The Browser is Chrome and OS is macOS 10.15.6
What I did:
Created a custom button to skip 10sec forward and backwards.
Play content on shaka player.
Forwarded it using Skip(10sec)forward button for 4-5 times. Then moved backwards using Skip(10sec)backward button for 6-7 times.
NOTE:
Tried the same things using the seek bar. The issue is reproducible there also sometimes.
For safari its working fine.
Actual
Sometimes the content does not load at all to resume further.
Expectation
The content should play from the resume point.

Issue #3187 seems to be a duplicate.  We can refer to it for another example of repro.

for info:
I'm literally on the verge of using 3.0.8 in production.
My config is:
var config = {
abr: {
enabled:false,
},
streaming:{
smallGapLimit:0,
},
drm: {
servers: {
'com.widevine.alpha': '*** my server ***',
}
}
};
Apart from that it's a pretty vanilla usage pattern.
I believe the 'smallGapLimit:0' avoids the behaviour at the expense of other functionality.
I've not seen any serious stalls for the moment - but I have not run additional diagnostics to check or seriously looked at network traffic.
As we test, I'll ask people to report seeks which do not achieve required locations.
br,
simon

Can you test with v4.3.4? Thanks!

@avelad - thankyou for pinging on this.
how would you like the config to look? (see above for what we're using at the moment....)


Feature request: Add time for delayed show

It would be nice to have detailed under the Delayed jobs the information for when it's going to run again, if Bull can provide it
Also, very nice lib 😄

I believe I've added this feature.  I'll put up a PR!


add min deposit decorator

Codecov Report
Base: 10.61% // Head: 10.82% // Increases project coverage by +0.21% :tada:

Coverage data is based on head (1bced96) compared to base (84fc91c).
Patch coverage: 61.76% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #712      +/-   ##
==========================================
+ Coverage   10.61%   10.82%   +0.21%
==========================================
  Files          57       58       +1
  Lines        8103     8137      +34
==========================================
+ Hits          860      881      +21
- Misses       7183     7192       +9
- Partials       60       64       +4

Impacted Files
Coverage Δ

internal/ante/min_deposit.go
60.60% <60.60%> (ø)

app/ante.go
64.70% <100.00%> (+1.06%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[top_darjeeling,clkmgr] Clock Measurement is wrong for Darjeeling

Darjeeling runs at 1000/250/62.5 MHz. The clkmgr has inbuild measurement primitives. These are however still configured for the Earlgrey frequencies (96/48/24 MHz) like following example shows. (Cnt = 480)
https://github.com/lowRISC/opentitan/blob/e65178ab2dfdd5da7e33d1e56fe759d15dec1fc0/hw/top_darjeeling/ip/clkmgr/rtl/autogen/clkmgr.sv#L602-L623
/cc @neeraj-rv @andreaskurth

These measurement constants should be filled in via templates by topgen.

These parameters are generated via templates in the master branch.


Integrate into Home Assistant core

On the long run it'd be cool to integrate this component into HA itself.
This ticket simply serves as a brainstorming area what should be done in order to integrate it

[x] Async (https://github.com/mammuth/ha-fritzbox-tools/pull/27)
[x] Config validation (https://github.com/mammuth/ha-fritzbox-tools/pull/28)
[x] Support for config flow (https://github.com/mammuth/ha-fritzbox-tools/issues/30)
[x] Format with black
[ ] integration of some other fritz components (currently residing in core): fritz, fritzbox, fritzbox_callmonitor, fritzbox_netmonitor, fritzdect
[ ] Tests (https://github.com/mammuth/ha-fritzbox-tools/issues/31)
[x] Wait some more time so more people can test the functionality in this component
[ ] ... ideas welcome! ...

[ ]  integration of some other fritz components (currently residing in core): fritz, fritzbox, fritzbox_callmonitor, fritzbox_netmonitor, fritzdect

do you want to combine the components into one large component? I think this is something that should be done after an initial release of the component in the core.
Such a huge pull request won't be merged otherwise.

I don't know. But we should think about it. I'm with you in regards of the dect and monitor stuff, but we might integrate the device tracker from beginning for example.
We could also ask more senior contributors on their opinion.

I would totally agree with you! However this would conflict the developer documents:
https://developers.home-assistant.io/docs/en/creating_component_code_review.html#5-make-your-pull-request-as-small-as-possible

I think we could start preparing the integration into core.
Some questions/things to think about:

Should we create a new component next to fritz, fritzbox, fritz_dect, etc. or override one of them? We should probably ask a core contributor what's preferred.
Which platforms/features do we include in the initial PR (to keep the diff as small as possible)
...?

I'm so glad I found this, after searching all over the web on how to add a guest wifi toggle to HA. I would very welcome if this would become a core component. IMO the way to go would be to merge all the currently cluttered components into one namespace on the long run, but start small for now and try to get feedback from core devs ASAP.
Adding yet another component namespace would IMO be the wrong approach, so it's probably best to override a current one. There I'd probably use fritz since this is the most suiteable one for a platform which supports a multitude of devices (FritzBox, FritzDect, ...) all sharing a common API (FritzOS). When overriding a namespace, the new implementation ofc would have to support the existing features of the namespace it's overriding, or chances if it to be accepted into the core are probably quite low.

One more thing would IMO to enable multiple fritzboxes in one network (https://github.com/mammuth/ha-fritzbox-tools/issues/72) as it might require some user visible breaking config changes.

What do you think @mammuth, when would be the time to merge into HA core?
Are there issues left we should address first?
Do you want to open up a PR? I could do too, if you want me to.

I think there are no issues left. But since this integration became quite large already we need to find a good path to move functionality over to core in small pieces.
What do we start with?

That sounds good!
I think the best way would be to setup a few PRs.
The first could be the WiFi switch (including all of the config flow etc)
Then dependent on this PR, we could add all other features into single PRs?
The disadvantage is that we would need to rewrite parts of the config flow to match the individual PRs...
Or we try one large PR and see what happens 😂

I think one large PR is just being closed :wink:

Probably true... 😂

Guys, I spoke with Paulus and the answer is:

Small prs and added to existing Frits integration

Thank you for your great work!
Simone

Guys, I spoke with Paulus and the answer is:

Small prs and added to existing Frits integration

Thank you for your great work!
Simone

Puh... That sounds like a lot of work..

I try to resurrect this old thread ;-)
What if we add one feature at a time to the current core implementation ?
Being part of Shelly integration Team, I learned it takes a while to get used to all coding rules and I strongly think this is the better way to go.
I may help if you think you need a contributor.
Simone

I guess the current first challenge is to understand how to get started here. Especially since the the core integration might be lacking some basics like a more sophisticated config flow, base classes like we have it etc.
Besides, everyone can obviously pick any feature that we found as part of this custom integration and port it into core. So if there are no blockers for you, go for it.

Besides, everyone can obviously pick any feature that we found as part of this custom integration and port it into core. So if there are no other blockers for you, go for it.

I was more hoping in a Team job ;-)

Sure. I wanted to emphasize that everyone can do it, without being blocked by me or other developers of this integration.
Also, disclaimer: I'm currently lacking motivation and time to kickoff this larger project on my own.

I can only agree. I think my supervisors would prefer if I focus on my actual work ...

I was thinking we could start with config_flow.py and binary_sensor.py; quite small but a good base for the next actions.

WiP:
root ➜ /workspaces/core/homeassistant/components/fritz (chemelli74-newfritzfeatures) $ pre-commit run
pyupgrade................................................................Passed
black....................................................................Passed
codespell................................................................Passed
flake8...................................................................Passed
bandit...................................................................Passed
isort....................................................................Passed
Check JSON...........................................(no files to check)Skipped
Don't commit to branch...................................................Passed
yamllint.............................................(no files to check)Skipped
mypy.....................................................................Passed
gen_requirements_all.................................(no files to check)Skipped
hassfest.............................................(no files to check)Skipped

Can I list you 2 as codeowners? Should I add myself ?
Simone

Slowly progressing:

Simone

Submitted a few PR to align code to HASS pre-commit.
If you agree and commit them, then my plan is:

create a router.py where to move classes like FritxboxTools ( I have the code here and working)
create a draft PR for device_tracker so to get help.

For device tracker I'm stuck on:

Device I/O in event loop
Device tracker polling update

Simone

Cleanup is fully merged and even released. Thx a lot to @mammuth ;-)
My current job for device_tracker is basically working: chemelli74-device_tracker branch
If you have wish, would be nice to get help on :

Device I/O in event loop -> common.py line 214
Device tracker polling update

Simone

Today commit fixed the first issue: I/O in event loop 🥳
Now only 1 thing missing:

Device tracker polling update

Simone

Code completed and cleaned up!
Let's share together how to proceed.
@mammuth, @AaronDavidSchneider,  you find me on discord. Maybe a group there would help.
Simone

Can confirm, works great!

Thanks, also working for me, but 2 hints:

The default host should be fritz.box or <IP_ADDRESS>. This should be valid for all standard installations.
The default username should be admin. For a normal user it's not obvious what's the username because you don't need one on the web interface.

FYI, the username becomes more important with the newer 7.25 version: https://avm.de/service/schnittstellen/

If the login type "Login only with FRITZ!Box password" was used up until now, a FRITZ! user
will be created automatically during the update. This FRITZ! user has a randomly chosen
name based on the scheme fritz[0-9] {4}, for example fritz1234, fritz1337 or fritz0042.

The default username should be admin. For a normal user it's not obvious what's the username because you don't need one on the web interface.

If I remember it correctly, we got some reports in the past that functionality didn't work for password-only user accounts. That's why we just went with the suggestion to create a dedicated user.
Not sure whether this is still required, though...

Let's share together how to proceed.
@mammuth, @AaronDavidSchneider, you find me on discord. Maybe a group there would help.

Good idea: https://discord.gg/WAxZKTfTc9

Done 💯  as of 2021.7.0 👍
Simone


PHPLIB-387: Support errors and unordered writes in CRUD spec tests

https://jira.mongodb.org/browse/PHPLIB-387
These improvements complement test revisions in https://github.com/mongodb/specifications/pull/399.
We can wait until the new spec tests are merged so that they can be incorporated into this PR; however, the test runner changes can be reviewed immediately.

@derickr: This is ready for a final review.


Signature help should be triggered by characters in completion snippets

This has come up a couple times before:
#13072
#31290
And has been discussed in the language server protocol repo:
https://github.com/microsoft/language-server-protocol/issues/274
When implementing a language server using the language server protocol, it's common to complete parens and place the cursor between them, for example: println($0). However, this creates a problem: the ( in the snippet doesn't trigger signature help, even though ( is a signature-help trigger-character.
As a workaround, you can provide editor.action.triggerParameterHints as the completion-item command, as discussed in #31290. But this is not a great solution, because editor.action.triggerParameterHints isn't part of the language-server-protocol.
The proper solution would be for VSCode to treat signature-help trigger-characters the same, whether they are being typed by the user, or being inserted as part of a snippet.

But this is not a great solution, because editor.action.triggerParameterHints isn't part of the language-server-protocol.

Adding @dbaeumer - Let's make this a LSP problem first ;-)

The proper solution would be for VSCode to treat signature-help trigger-characters the same, whether they are being typed by the user, or being inserted as part of a snippet.

Not sure about that - the occurrence of such characters in a completions doesn't always mean that signature help is needed and it might lead to false signature help showings. I think  the explicit command is pretty specific but, yeah I agree that this is VS Code specific

I agree with @jrieken that this can be solved in LSP without any further action in VS Code. In LSP we would need to add a information to a completion item whether it should trigger signature help after insertion. If specified the VS Code implementation could trigger the corresponding action.
I will close the issue since VS Code has everything to support this in LSP.


Instructions on how to use with Visual Studio

Could you please give some detailed instructions on how to use TUnit with Visual Studio?
How to get a simple example work within the Test Explorer?

Hey @SongPing sorry the docs were unclear - I've just updated them.
You need to install the preview version of visual studio and enable the new testing server mode. Instructions and screenshot is now on the main readme.

Thanks, for your fast reply!
Now it is much clearer, why I didn't get it to work.
I hope, your documentation update will also help others saving time, not trying it with the current Visual Studio Version.


Migrate to Jest and Github Actions

Welcome to Codecov :tada:
Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


How to handle technical support questions

I would prefer to keep this issue board for bugs and feature requests only. How should we handle technical support questions posted here? I have a couple of ideas:

Redirect users our Gitter community. It is currently dead, but I am hoping it will one day be a vibrant community.
Redirect users to Stack Overflow. At least there, answers can be rewarded.
Allow technical support question in the issue board, tag them accordingly and let the bot eventually close them.
Redirect users to a Discord community. I would prefer Gitter due to it's GitHub integration and how it would better foster a community of developers.

If you have them, I am open to any other suggestions.
I will update issue template with what we conclude.

It's a personal choice of yours since you're currently the lead dev. If it was me I'd go for chat + issues.
So (1 or 4) and 3. Issues are nice because they remain Google-able even after closed, and are less of a barrier to entry than SO for posting. If you worry that organizing issues will become difficult, you can consider the Projects feature where you can drag cards in


Open another window by shift clicking on icon in taskbar

VSCode Version: 1.15.0, though this applies to all versions I've used so far.
OS Version: Windows 10.

Reproduces without extensions: Yes
Since Windows 7, it's possible to click on an icon in the taskbar ('superbar') while holding down shift and it will open a second, third, nth window. It's a small accessibility feature so users won't have to right click the icon and then click the jumplist menuitem of opening another window.
Somehow, VS Code does not support this or actively prevents this. It does have a jumplist menuitem for new window, but shift-clicking the icon does not result in the expected behavior, it simply goes to one of the already opened windows.
It's a small thing, but I would really appreciate it if this could be fixed. Or is the current behavior chosen for a good reason I'm not aware of?
Thanks in advance.

https://github.com/Microsoft/vscode/issues/13905


Suggestion: Adding Editor Notes for RSS Feed

I noticed this quirk several months ago with the release of Issue 423 and, more specifically, the article “Create a Content Compass” by Megan Casey. It has since resurfaced with “How We Hold Our Devices” in Issue 432. Note that both of these articles are (wonderful) book excerpts.
I get notified about new content on ALA via the RSS feed. I began reading Megan's article in my RSS reader, but became slightly confused when the text lead off with “Chapter 2 mentioned…” It didn’t take me long to understand that what I was reading was, in fact, an excerpt from a book, but there was no indication of this fact in the RSS entry. In fact, I would not have been as confused by this had I just opened the actual webpage for the article instead of reading from the RSS feed, as there is a notice on the article page explaining this fact.
My suggestion is to integrate the ExpressionEngine field {article_editors_note} and the related conditional logic found on line 158 of the article template into the RSS feed template. This would end up being very much like the way article footnotes are included in the feed. While this is a very minor detail, I think it can help clear up a little bit of confusion for RSS users like me.

Thanks for letting us know about the lack of editor notes in the RSS feed, @JasonNeel.  We completely agree editor notes would be helpful here, and we'll give an update once they're sorted.

All set, I hope. I've added editor's notes for articles, columns, and blog posts in all our feeds.

Thanks, guys!


[dask] test that Dask automatically treats 'category' columns as categorical features

Based on thread starting at https://github.com/microsoft/LightGBM/pull/3930#discussion_r573107195.
#3908 added some tests that the lightgbm.dask estimators correctly handled Dask DataFrames where some columns are pandas "category" columns. That PR used the parameter categorical_feature to explicitly provide a list of which features should be treated as categorical.
This is unnecessary, since auto is the default behavior and auto tells LightGBM "treat 'category' columns as categorical features" (https://github.com/microsoft/LightGBM/blob/846b512d892426d34fac0749ccfd2d7a31eef877/python-package/lightgbm/basic.py#L513-L514).
This PR removes the unnecessary categorical_features parameter in tests. As of this PR, we'll now be testing not only that lightgbm.dask estimators correctly train on categorical features, but also that it also automatically

Nice!

thanks for pointing it out!


Support for Multiple-Valued Categories

I'd love to see support for multiple category values for a document. This would be great for use cases like tags, multiple colors/sizes on products, etc. I found it surprising that this isn't supported (everything else is so great). It ends up being a show-stopper for me.

+1

There was a technical reason for that.
Take a look at the DynamicDataManager class and its DynamicData subclass. The categories data's representation was meant to optimize resources (keeping the category value for each category for each document in bitmaps). You could implement a work around that but at the cost of having a much larger memory footprint for the same amount of data.


Dark Theme

Great work on this. It would be nice to have a grey/black theme. :-)

Ignore me. I totally missed the color pickers!

lol no worries.


Introduce cheaply clonable ChunkStoreHandle and QueryCacheHandle

These are required for:

Making it easy to construct and pass QueryEngines around:

// TODO(cmc): This needs to be a refcounted type that can be easily be passed around: the ref has
// got to go. But for that we need to generally introduce `ChunkStoreHandle` and `QueryCacheHandle`
// first, and this is not as straightforward as it seems.
pub struct QueryEngine<'a> {
    pub store: &'a ChunkStore,
    pub cache: &'a Caches,
}

Getting ingestion off of the main thread and parallelize it:

#4298

@zehiko just hit that one as he was trying to integrate a QueryHandle into an async Stream (which assumes multi-threaded environment, and therefore static lifetimes, etc).


fix: 🐛 Fixed the Challenges Quiz not showing

✅ Closes: #1577
📥 Pull Request
Description
I have changed the proper tailwind css values that makes the Quiz now look more better, with better appearence
Fixes #1577
Screenshots:
algo-1577.webm
Type of change

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[X] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update

Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes
[X] Any dependent changes have been merged and published in downstream modules

@ajay-dhangar can you review this PR and assign gssoc & hacktoberfest labels too. Is it possible to get level 2 on this PR for pointing out this defect, Also update the level on the issue #1577

@ajay-dhangar can you review this PR, also can U give me Level 2 on this one for finding out this bug or fix

@ajay-dhangar can you review this PR


Fix typescript errors

I was pretty messy with the typescript throughout we should really try to fix all those errors.

Fixed by #7


Feature: Implement separate settings for left and right.

Disclaimer:
Please go through existing feature requests to avoid creating duplicates. If you found a similar issue please post a comment there. If you are uncertain your issue is related to others then create the issue. Obvious ignorance of this rule might get you blocked from posting new issues. Please tick the box below to show that you have followed the guideline.

[x] I have checked for a similar issue and sure it hasn't been reported before.

Description:
Especially in old age you notice that the high frequencies on the left or right are less. It would be cool if you could raise these values separately
User flow & interface:
Create two panels to manipulate the settings for left and right.

I second this request. In my case, my left and right earbuds are independently playing certain frequencies louder or softer than the other, so a simple volume balance control is not sufficient to match the two sides.

Yeap it's not the first time this feature has been asked for. At first I thought it would be too niche to implement, but more and more people are asking for it. I can't give any time estimates as to when it will get implemented however. Thanks

You can do this on Mac already with BackgroundMusic
Sometimes I find eqMac doesn't like BgM already running though, but it does work…

This would be a great enhancement! I've been looking for a Mac system audio EQ tool with independent R/L settings, because I have asymmetric high frequency hearing loss, so there's no way for me to get both channels to sound equivalent with a single stereo EQ.

May I add my voice to this?  A month ago, out of the blue, I suffered Sudden Sensorineural Hearing Loss (SSHL) - it's a largely unexplained event that causes nerve cells to die in one ear, resulting in permanent hearing loss.  Apparently it effects thousands of people a year in the US alone across all age groups.  I've lost a lot of sensitivity to low frequencies in my left ear as a result, and so an EQ app that would allow me to boost certain frequencies on only the left channel at a system level would be amazing.  The fact that others with hearing loss are looking for exactly the same thing suggests there is some demand for this, and it would make quite a profound difference to those of us who love music and are dealing with these kinds of issues.  Thanks in advance if such a feature does make the cut!

I am triaging & trying to fix all open issues before release of eqMac v1.0.0. Excuse the wait.
Just wanted to update you on my thoughts on this:
I think this is still a relevant issue and something I'm looking forward to solve when time comes.
I also experience hearing issues due to riding my loud motorcycle a lot, I have tinnitus and can understand how frustrating hearing issues can be.

I can see that an important use case would be when you have less than ideal placements of speakers in a room or even in a car, resulting in the spectrum analysis of L/R speakers will differ quite a bit. It is a common technique in Car Audio tuning to use a DSP to set delay and EQ separately for every speaker to make sure the sound that eventually reaches the ears is in harmony and not canceling each other too much.

Any news about this issue?

One more use case: One sided audio defect (developing/increasing) in laptop audio speakers or headphones
(membranes slowly start over-resonating in certain frequency range):

Mid to long term you need to replace or repair the hardware, as the defect usually grows to more frequencies over time.
But short term (until repair/replacement becomes possible) you could benefit from a one channel EQ:

Start with a rather narrow-band-filter, identify the frequency with the disturbing resonance (eg 250-500 Hz) and reduce the volume or filter-curve until the disturbance is negligible enough.
Then you habe one fully functioning side, and the other side lacks a bit of fidelity, but contain less or no more of the annoying frequencies.
Without such a system wide one sided EQ, you will need to go for the next best possible workaround, which is to go mono by setting the audio balance to your remaining healthy speaker.


Does security-intro project works, for me it dont, there no compilor error but only runtime errors, please fix it

Lesson 8-Web Application Security/security-intro/

2019-05-08 13:22:18.116  WARN 6124 --- [  restartedMain] ConfigServletWebServerApplicationContext : Exception encountered during context initialization - cancelling refresh attempt: org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'homePageController' defined in file [L:\ProgrammingStuff\JAVA\STS-Projects\BookProjects\SpringBoot2Fundamentals\security-intro\target\classes\com\packt\springboot\securityintro\logic\HomePageController.class]: Instantiation of bean failed; nested exception is org.springframework.beans.BeanInstantiationException: Failed to instantiate [com.packt.springboot.securityintro.logic.HomePageController]: Constructor threw exception; nested exception is java.lang.Error: Unresolved compilation problems:
The blank final field overAnnotatedService may not have been initialized
The blank final field sms may not have been initialized
log cannot be resolved
Type mismatch: cannot convert from Authentication to val
The method getAuthorities() is undefined for the type val
The method getPrincipal() is undefined for the type val
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
2019-05-08 13:22:18.120  INFO 6124 --- [  restartedMain] o.apache.catalina.core.StandardService   : Stopping service [Tomcat]
2019-05-08 13:22:18.135  INFO 6124 --- [  restartedMain] ConditionEvaluationReportLoggingListener :
Error starting ApplicationContext. To display the conditions report re-run your application with 'debug' enabled.
2019-05-08 13:22:18.146 ERROR 6124 --- [  restartedMain] o.s.boot.SpringApplication               : Application run failed
org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'homePageController' defined in file [L:\ProgrammingStuff\JAVA\STS-Projects\BookProjects\SpringBoot2Fundamentals\security-intro\target\classes\com\packt\springboot\securityintro\logic\HomePageController.class]: Instantiation of bean failed; nested exception is org.springframework.beans.BeanInstantiationException: Failed to instantiate [com.packt.springboot.securityintro.logic.HomePageController]: Constructor threw exception; nested exception is java.lang.Error: Unresolved compilation problems:
The blank final field overAnnotatedService may not have been initialized
The blank final field sms may not have been initialized
log cannot be resolved
Type mismatch: cannot convert from Authentication to val
The method getAuthorities() is undefined for the type val
The method getPrincipal() is undefined for the type val
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.instantiateBean(AbstractAutowireCapableBeanFactory.java:1238) ~[spring-beans-5.0.7.RELEASE.jar:5.0.7.RELEASE]
at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBeanInstance(AbstractAutowireCapableBeanFactory.java:1137) ~[spring-beans-5.0.7.RELEASE.jar:5.0.7.RELEASE]
at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:543) ~[spring-beans-5.0.7.RELEASE.jar:5.0.7.RELEASE]
at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:503) ~[spring-beans-5.0.7.RELEASE.jar:5.0.7.RELEASE]
at org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:317) ~[spring-beans-5.0.7.RELEASE.jar:5.0.7.RELEASE]
at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:222) ~[spring-beans-5.0.7.RELEASE.jar:5.0.7.RELEASE]
at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:315) ~[spring-beans-5.0.7.RELEASE.jar:5.0.7.RELEASE]
at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:199) ~[spring-beans-5.0.7.RELEASE.jar:5.0.7.RELEASE]
at org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:760) ~[spring-beans-5.0.7.RELEASE.jar:5.0.7.RELEASE]
at org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:869) ~[spring-context-5.0.7.RELEASE.jar:5.0.7.RELEASE]
at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:550) ~[spring-context-5.0.7.RELEASE.jar:5.0.7.RELEASE]
at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.refresh(ServletWebServerApplicationContext.java:140) ~[spring-boot-2.0.3.RELEASE.jar:2.0.3.RELEASE]
at org.springframework.boot.SpringApplication.refresh(SpringApplication.java:759) [spring-boot-2.0.3.RELEASE.jar:2.0.3.RELEASE]
at org.springframework.boot.SpringApplication.refreshContext(SpringApplication.java:395) [spring-boot-2.0.3.RELEASE.jar:2.0.3.RELEASE]
at org.springframework.boot.SpringApplication.run(SpringApplication.java:327) [spring-boot-2.0.3.RELEASE.jar:2.0.3.RELEASE]
at org.springframework.boot.SpringApplication.run(SpringApplication.java:1255) [spring-boot-2.0.3.RELEASE.jar:2.0.3.RELEASE]
at org.springframework.boot.SpringApplication.run(SpringApplication.java:1243) [spring-boot-2.0.3.RELEASE.jar:2.0.3.RELEASE]
at com.packt.springboot.securityintro.SecurityIntroApplication.main(SecurityIntroApplication.java:10) [classes/:na]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:1.8.0_202]
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[na:1.8.0_202]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[na:1.8.0_202]
at java.lang.reflect.Method.invoke(Method.java:498) ~[na:1.8.0_202]
at org.springframework.boot.devtools.restart.RestartLauncher.run(RestartLauncher.java:49) [spring-boot-devtools-2.0.3.RELEASE.jar:2.0.3.RELEASE]

Caused by: org.springframework.beans.BeanInstantiationException: Failed to instantiate [com.packt.springboot.securityintro.logic.HomePageController]: Constructor threw exception; nested exception is java.lang.Error: Unresolved compilation problems:
The blank final field overAnnotatedService may not have been initialized
The blank final field sms may not have been initialized
log cannot be resolved
Type mismatch: cannot convert from Authentication to val
The method getAuthorities() is undefined for the type val
The method getPrincipal() is undefined for the type val
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
at org.springframework.beans.BeanUtils.instantiateClass(BeanUtils.java:182) ~[spring-beans-5.0.7.RELEASE.jar:5.0.7.RELEASE]
at org.springframework.beans.factory.support.SimpleInstantiationStrategy.instantiate(SimpleInstantiationStrategy.java:87) ~[spring-beans-5.0.7.RELEASE.jar:5.0.7.RELEASE]
at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.instantiateBean(AbstractAutowireCapableBeanFactory.java:1230) ~[spring-beans-5.0.7.RELEASE.jar:5.0.7.RELEASE]
... 22 common frames omitted

Caused by: java.lang.Error: Unresolved compilation problems:
The blank final field overAnnotatedService may not have been initialized
The blank final field sms may not have been initialized
log cannot be resolved
Type mismatch: cannot convert from Authentication to val
The method getAuthorities() is undefined for the type val
The method getPrincipal() is undefined for the type val
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
log cannot be resolved
at com.packt.springboot.securityintro.logic.HomePageController.<init>(HomePageController.java:21) ~[classes/:na]
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) ~[na:1.8.0_202]
at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) ~[na:1.8.0_202]
at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) ~[na:1.8.0_202]
at java.lang.reflect.Constructor.newInstance(Constructor.java:423) ~[na:1.8.0_202]
at org.springframework.beans.BeanUtils.instantiateClass(BeanUtils.java:170) ~[spring-beans-5.0.7.RELEASE.jar:5.0.7.RELEASE]
... 24 common frames omitted

This looks like lombok is not working or present. Can you check on your end?

hm, i think i didn't used lombok, in my project lombok quite can be quite abigious dependency.

pcornelissen@moneysink:~/projects/test/3$ git clone git@github.com:TrainingByPackt/Spring-Boot-2-Fundamentals.git
pcornelissen@moneysink:~/projects/test/3$ cd Spring-Boot-2-Fundamentals/Lesson\ 8-Web\ Application\ Security/security-intro/

$ mvn package
...
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  8.018 s
[INFO] Finished at: 2019-05-09T13:17:34+02:00
[INFO] ------------------------------------------------------------------------

$ mvn spring-boot:run
...
2019-05-09 13:18:33.389  INFO 10679 --- [  restartedMain] o.s.b.d.a.OptionalLiveReloadServer       : LiveReload server is running on port 35729
2019-05-09 13:18:33.430  INFO 10679 --- [  restartedMain] o.s.b.w.embedded.tomcat.TomcatWebServer  : Tomcat started on port(s): 8080 (http) with context path ''
2019-05-09 13:18:33.434  INFO 10679 --- [  restartedMain] c.p.s.s.SecurityIntroApplication         : Started SecurityIntroApplication in 2.15 seconds (JVM running for 2.412)

By default lombok is included, if you have removed it, you need to create all the getters/setters and construnctors etc. by hand.
Lombok is a compile time only dependency and does only what you tell it to. I don't see the harm in that.
You might see the error you have copied in here when you try to start the software from your IDE when the lombok plugin is not present/working and the IDE doesn't use maven to build the software.
I am pretty sure your problem is related to your project/IDE setup. As you can see the code I just checked out works fine without any change.

pcornelissen yes it was my mistake, i dont use for my pet projects intelij, i use STS Eclipse.
When i work for client i use ide which my client use in his project, but anyway thanks for advise . When i got the error i was like wtf , wtf then i installed lombok plugin into my eclipse and well it works.


1.0: Confirm & Proceed button of send screen is not getting enabled.

When we try to send the "Confirm & Proceed" button of send screen is not getting enabled.

Verified this issue on dev app v1.7.0(295)


Cleanup on PolicyUtils

Removed outdated functions that uses users and commented the code using them, that was mostly from Comment feature.
Made functions to return and use Set of Policy as it is more appropriate return type, that also removes unnecessary creation of Map and Map if required can be created by the calling function.
Removed deepcopy and optimized the logic for adding and removing Policies to the object.

Server Workflow
https://github.com/appsmithorg/appsmith/actions/runs/2830398862

/ok-to-test sha=03282cbf9cdb8a3ed6bd9163483a3d41d0d769d6

/ok-to-test sha=e241e2060f6f94ee6f8f96358ec283e05738224e


Don't show the number of moves until all dices have landed

Small annoyance in this otherwise amazing game/site: The number below the dices tells you the number of moves you get before the last dice has "landed" (image + sound). I think it would be better if dices, sound and number are all synced. Maybe speed up the dices a little bit, and slow down showing the number a little?
Thanks again!

I've actually just sped up the dice in the last update! :) I'll try this out

I've actually just sped up the dice in the last update! :) I'll try this out

I've tried different variations of this, but of all of them I prefer it as it is now. It gives users more time to consider their moves, and is clear. It also causes few visual changes throughout the dice rolling, which I think is nicer.
I tried all of the following:

Only set the number after all dice have been selected
Use the placeholder "-" instead of "0" when the dice is rolling
Randomise the placeholder while the dice are rolling

I've tried different variations of this, but of all of them I prefer it as it is now. It gives users more time to consider their moves, and is clear. It also causes few visual changes throughout the dice rolling, which I think is nicer.
I tried all of the following:

Only set the number after all dice have been selected
Use the placeholder "-" instead of "0" when the dice is rolling
Randomise the placeholder while the dice are rolling


Independence of methods

We need to make sure that getParameterSamples also works without running a multistart local optimization method beforehand. Do we want getParameterProfiles also to work without information from parameters.MS?

getParameterProfiles will not (or very poorly) work without a previos succesful
multistart. But you could just run getMultistarts with default settings and display a warning.

I would through a warning or even an error if the user did not run a multi-start optimisation before running profile likelihood calculation.
One could check if the corresponding fields in the parameter struct are empty.

Clearly, getParameterProfiles will perform very poorly without a multistart beforehand (maybe give bad results, in any case take ages), but it would be possible to write some lines of code, such that it would at least work at all. The question is, is it worth this effort? I don't think so, but maybe somebody has a different opinion.

not maybe, most certainly. definitely not worth. either run a multistart or throw an error.

indeed. if the field MS is empty we should return an error. If the user does not employ getMultiStarts but another routine and stores the results to .MS, I would accept that to ensure modularity.

(Hopefully) done now. Sampling and Multistart should work now independently.


Alternative fbp "commands"

As we know, a lot of users have problems, to type the florin ƒ to wire the components.
Therefore , we come now with a set of alternatives.
  @-     =>    at-
  ƒ-      =>    fn-
  ƒ-.      =>    set-
  @-ƒ-      =>    on-fnret-

The new symbols can be mixed with the old ones :-)
Test coverage of the symbols is at 100%
fbp is a little bit faster now (even with the additional symbols)

<button at-click="--wire">play</button>
<video src="..." fn-play="--wire"></video>

  @-ƒ-      =>    on-fnret- should be at-fnret


Explorer background menu looks a bit silly

testing #30722:
The poor explorer background menu is very tiny now (and doesn't look like a menu any more):

Some ideas for useful actions that could be added:

Save Workspace
Save Workspace as
Rename Workspace
Find in Workspace
New Folder

+1 for adding more workspace related actions to this menu (now that we have them). Just to compare, here is the menu when a folder is opened:

I think we can take some of the entries also for the workspace case. Not 100% sure about "Save Workspace". There is also "New Workspace" and "Open Workspace", though they are not so explorer specific.

In this case for consistency I propose that we just copy the workspace sub menu. Also all those actions make sense to me in that context

@isidorn not sure I would agree, for example we also do not show "Open Folder..." in the context menu for an empty folder.
If we want to make the context menu less sparse, I think we should only add entries to the context menu which are relevant to the explorer and not to the workspace (e.g. the "Add Folder to Workspace" action is relevant because it adds a folder to the explorer).
My suggestion was to add more of the entries we have in the single folder case. "Find in Workspace" for example should work nicely (it is just a normal search without includes specified).

I have added the "Find in Workspace..." (also renamed "Find in Folder" to be "Find in Folder..."
As for the other actions proposed here
Only Save Workspace and Save Workspace As, seem to make some sense. However I have not added them yet to not clutter the menu. Let me know if you would still prefer these actions and I can add them

I don't think that a 2-item menu gets already cluttered by adding two more actions:

So I think Save Workspace and Save Workspace As should be added.

I've added the verified label because with 100% enlargement the menu no-longer looks silly ;-)

@weinand adding save actions makes sense imho


Replaced django.utils.importlib with python importlib (Django 1.9)

Thanks for the PR!
Importlib is only available in Python 2.7, I guess we need some way to detect the version of Python and if it's less than 2.7 use the importlib package?
Any ideas?

We could try import and otherwise use old style.
or check version by sys.version_info
def checkInstallation(rv):
currentVersion = sys.version_info
if currentVersion[0] == rv[0] and currentVersion[1] >= rv[1]:
pass
else:
sys.stderr.write( "[%s] - Error: Your Python interpreter must be %d.%d or greater (within major version %d)\n" % (sys.argv[0], rv[0], rv[1], rv[0]) )
sys.exit(-1)
return 0
...
Calling the 'checkInstallation' function checks if Python is >= 2.7 and < 3
requiredVersion = (2,7)
checkInstallation( requiredVersion )


Fix Drive Quickstart error on File names with unicode chars

If a file name has a unicode character such as "Édouard". The current print line will throw an error:
Traceback (most recent call last):
File "quickstart.py", line 50, in
main()
File "quickstart.py", line 47, in main
print('{0} ({1})'.format(item['name'], item['id']))
We simply need to change it to: print(u'{0} ({1})'.format(item['name'], item['id']))

Looks good, but can we add this everywhere in the repo where we use .format?

eh, didn't want to mess with rebasing and getting a new commit message for all the fixes since it contains unrelated files in the adminSDK


realm is written automatically

@gnikulin @jesusff
I just realized, that cmor will write the realm attribute into the output file no matter what. In this example, you see the realm = "REALM" attribute although it is eliminated from all tables including the header due to  https://github.com/WCRP-CORDEX/data-request-table/issues/4 . I'll check the cmor issues if there is a solution. I think for now it's ok.

see https://github.com/PCMDI/cmor/issues/736

This is closed with cmor >= 3.9.0.