Yosys isn't able to import it's own eblif output format?

Steps to reproduce the issue

Generate an eblif with .cname or .conn values in the output
Try and import the file into yosys with read_blif
Get Syntax Error message.

Expected behavior

Be able to read the eblif file into yosys (for simulation / equivalence checking).

This can be closed with #596 pulled.

BTW Do we have any tests for "round tripping via blif"?

Happy to close this issue and open a seperate one for that....


Use codemode=objectgenerator for dc.SecurityMediator.SecurityMediator:AccessCheck

You could reduce the runtime overhead of access checking by code-generating the AccessCheck method. (Shouldn't need to do runtime lookups against the class dictionary - those are often slow.)

Same with GetClassMethodName

When do this, I get AccessCheck+1^dc.SecurityMediator.SecurityMediator.G1 *super-class '%CSP.REST' is not in sub-class '%Studio.Project' hierarchy
So, it is not possible set codemode=objectgenerator, because an InterSystems IRIS class, the %CSP.REST.

That's a very strange error... how is %Studio.Project involved?

I did not used Studio, I used vscode. But %CSP.REST extends the class %Studio.Project, an InterSystems class. So, is impossível to do codemode=objectgenerator. Can I close this issue?


Add transfer/IFT to categories

These categories should probably live in a local file or something else configured locally, but that's for another PR.


Incorrect steps in "Turn off automatic provisioning"

Option to disable auto provisioning is under "Pricing & Settings", not in "Security policy – Data Collection".
Current/wrong:
3. On the Security policy – Data Collection page, under Auto provisioning select Off.
Expected/correct:
3. On the Pricing & Settings page, under Auto provisioning select Off.
Screenshot showing correct path:

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8267e218-3748-2820-3eee-80479705eec2
Version Independent ID: 8c6d5fce-6383-a0f8-7df3-f5e0a77bbad6
Content: Data Collection in Azure Security Center
Content Source: articles/security-center/security-center-enable-data-collection.md
Service: security-center
GitHub Login: @memildin
Microsoft Alias: memildin

@sachinpanwar Thank you for bringing this to our attention!  We are reviewing this, and will update the documentation accordingly.

@sachinpanwar Thank you again for bringing this to our attention!  The document has been updated with current instructions and should be live shortly.
We are going to close this thread as resolved but if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.


Add h2oGPT Client

Fixes #80
Usage
from h2ogpt_client import Client

client = Client("http://<IP_ADDRESS>:7860")

# text completion
response = client.text_completion.create("Hello world")
response = await client.text_completion.create_async("Hello world")

@this Looking great!  Make sure you merge main into your PR as the langchain had breaking changes with 1 extra API item.
Also, gradio team fixed the Chat part.  I'll update that now:
https://github.com/gradio-app/gradio/issues/4081#issuecomment-1548985863

@this How's this PR going?

How's this PR going?

@pseudotensor I'm currently working on the chat_completion API. I was hoping to include that in this PR, but we can merge this and I can create a new PR.

Non-manual test failures on this branch:
============================================================================================================ short test summary info ============================================================================================================
FAILED tests/test_pipeline.py::test_export_copy - ImportError: cannot import name 'inject_newline' from 'test_output.h2oai_pipeline' (/home/jon/h2ogpt/test_output/h2oai_pipeline.py)
FAILED tests/test_requirements.py::test_requirements - ValueError: ['accelerate==0.19.0', 'transformers==4.28.1', 'git+https://github.com/huggingface/peft.git@3714aa2fff158fdfa637b2b65952580801d890b2']
FAILED tests/test_ui.py::test_newline_replace - AssertionError: assert 'You can use ... sorted list.' == 'You can use ... sorted list.'
=========================================================================== 15 failed, 99 passed, 36 skipped, 1 xfailed, 1 xpassed, 12 warnings in 3745.08s (1:02:25) ===========================================================================
(h2ollm) jon@pseudotensor:~/h2ogpt$

Unrelated to this PR.


Is there an event source for System.Net.Sockets

Similar to this article https://docs.microsoft.com/en-us/dotnet/framework/network-programming/how-to-configure-network-tracing

Yes - for .NET Core, there is an eventsource: https://github.com/dotnet/runtime/blob/13733cdd969842de9c36235d730a604ce55ee729/src/libraries/System.Net.Sockets/src/System/Net/Sockets/NetEventSource.Sockets.cs#L10.


Can I join the meetings as an observer.

Now that I better understand the scope from reading the last minutes,  I'd like to at least listen in.

From https://github.com/nodejs/community-committee/issues/48

A standing invitation exists for all @nodejs/TSC members who are not also CommComm members to attend in observer capacity.

So I think you are already invited.

Definitely hop on in @mhdawson, we'd love to have you! As @gibfahn mentioned, all TSC and CTC members have a standing invite.

Where is the dial-in info or is it the standard uber conference ?

@mhdawson we're going to use Google Hangouts. That reminds me, I need to create the event, thanks! The link will be posted in the meeting issue.

k thanks


.Net Standard 2.0

Please, make this project .net standard 2.0 compatible. Now it can't be used in projects targeting full .net framework.

Hi, it's done. You can target net framework since 2.0.3 version. I tested it on .net 4.7.2, but i'm not sure about older framework versions. Feel free to re-open issue, if you have any troubles


RIFE Crashing silentlty

It used to work fine, but suddenly RIFE is crashing silently after a while.
Using the latest commit with latest ComfyUI, with rife49.pth checkpoint (I tried 46, 47 as well) running on a T4 in google colab
Input has only 120 frames.
Output is:
got prompt
Comfy-VFI: Clearing cache...
Comfy-VFI: Done cache clearing
Comfy-VFI: Clearing cache...
Comfy-VFI: Done cache clearing
Comfy-VFI: Clearing cache...
Comfy-VFI: Done cache clearing
Comfy-VFI: Clearing cache...
Comfy-VFI: Done cache clearing
Comfy-VFI: Clearing cache...
Comfy-VFI: Done cache clearing
Comfy-VFI: Clearing cache...
Comfy-VFI: Done cache clearing
Comfy-VFI: Clearing cache...
Comfy-VFI: Done cache clearing
Comfy-VFI: Clearing cache...
Comfy-VFI: Done cache clearing
Comfy-VFI: Clearing cache...
Comfy-VFI: Done cache clearing
Comfy-VFI: Clearing cache...
Comfy-VFI: Done cache clearing
Comfy-VFI: Clearing cache...
Comfy-VFI: Done cache clearing
^C

Yeah having the same issue, I can see the VRAM slowly going up while RIFE is running until it crashes due to OOM. Feel like the clearing cache isnt actually working maybe?

Ok, I think the problem is that the code here only clears the gpu memory cache and not the VRAM cache.
I think the only solution for longer videos is to save the interpolated frames to disk instead of keeping them in memory.

Created a tiny pull request with some improvements:
https://github.com/Fannovel16/ComfyUI-Frame-Interpolation/pull/37


fix: Enhance test stability in drive_tests.js

In the drive_tests.js file, I improved test stability by introducing steps in two test cases: "test drive to external link" and "test drive enabled by default; click link inside data-turbo='false'."
The added  calls ensure that the respective elements (e.g., #drive_enabled_external and #drive_disabled) are present and visible before interacting with them, reducing the chances of element unavailability issues during test execution.
This resolves test failures where elements were not immediately accessible, leading to test timeouts.

@AfolabiOlaoluwa I don't think these changes are necessary. Playwright already automatically waits for an element to be available before performing an action like page.click.
For more details, see https://playwright.dev/docs/actionability

@AfolabiOlaoluwa I don't think these changes are necessary. Playwright already automatically waits for an element to be available before performing an action like page.click.
For more details, see https://playwright.dev/docs/actionability

But test cases aren't passing despite. Should we rather leave it hanging and not fixed?

@AfolabiOlaoluwa adding await to page.click is correct, what we don't need is the page.waitForSelector before page.click. If you can update the branch with those changes I'll merge 👍

adding await to page.click is correct, what we don't need is the page.waitForSelector before page.click. If you can update the branch with those changes I'll merge

I think should have been the comments as a review of the PR rather than the PR being closed. I do think we need to be patient about closing PRs.
I have made amends as I agree with your opinion clearly listed out on https://github.com/hotwired/turbo/pull/993#issuecomment-1715355438.

Thanks @AfolabiOlaoluwa 👍


Add status "badge" in sidebar

It would be awesome if this addon added an appropriately coloured dot beside the story name in the sidebar, and potentially some treatment to the parent so you can see the status at a glance for all stories/components.
Could potentially only identify beta or deprecated ones to reduce noise

Hey that would be neat! I don't know if I can get sidebar access from the storybook addon API, but I'll give it a shot

I don't think this is possible in Storybook v5.
If you can see a way of doing it, or anyone who is editing the sidebar content using addons, then let me know.
Leaving this open in case somebody figures it out.
🙏

Coming back to this issue looking for a similar thing.
As of Storybook 6.2.0 (which is still at a release candidate phase 🙈 ), it will be possible to use a configuration sidebar.renderLabel ! Briefly tested it and we can start prepare for it for when it is stable:

The gist would be:
// .storybook/manager.js
import { addons } from '@storybook/addons';
import { Icons } from '@storybook/components';
import { styled } from '@storybook/theming';
import React from 'react';

const SuffixIcon = styled(Icons)`
  align-self: center;
  display: inline;
  height: 1.125em;
  margin-left: 4px;
  width: 1.125em;
`;

addons.setConfig({
  sidebar: {
    renderLabel: item => {
      // item can be a Root | Group | Story
      if (!item.isLeaf) {
        return item.name;
      }

      return (<>{item.name}<SuffixIcon icon="lightning" /></>);
    },
  },
});

To dig deeper:

https://github.com/storybookjs/storybook/pull/13121
https://github.com/storybookjs/storybook/blob/05078ff2605eec0f79a3de2c60adbe9946a9ce37/lib/ui/src/components/sidebar/Tree.tsx#L140
https://github.com/storybookjs/storybook/blob/b17f10833cfe781f3ea9b9f5a7dd591f0ae27c0d/lib/api/src/modules/provider.ts#L12
https://github.com/storybookjs/storybook/blob/b17f10833cfe781f3ea9b9f5a7dd591f0ae27c0d/lib/api/src/lib/stories.ts#L45

Status badges with title attr hovers so you can see the full status and description are now available on v3.0.0 🎉


Fixed "ReferenceError: dbg is not defined" error when 'dbg' global va…

Issue #977
Bug

If the 'dbg' global variable is not defined, the find_tests function throws "ReferenceError: dbg is not defined" rather than falling back to using default line and column numbers.

The default line and column numbers are 0 rather than 1. This would cause issues when the test was opened/navigated to (open .js file in external editor, see #974).

The function is returning 0 based column numbers rather than 1 based as the editor expects.

Requiring Node to be started with the "--expose_debug_as=dbg" pollutes the global namespace and makes it a little more tricky to test. The debug context can be alternatively accessed via the following:
var debug = vm.runInDebugContext('Debug');

Fix
Changed to use vm.runInDebugContext('Debug') rather than 'dbg' global variable.
Return 1 based column and line numbers.
No need to start Node process with "--expose_debug_as=dbg" .

Hi @jcansdale, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

Thanks for finding all these issues and fixing them too! I've merged in the PR. The fix should be available in our next release.
Thanks again.

No problem. Thanks for accepting my first pull request. :)
BTW, are there any JavaScript (or preferably TypeScript) tests that run as part of this project? I'd like to submit test tests as well.

@jcansdale Good question. Unfortunately we do not have this sort of test currently.
The NTVS tests could be improved a lot, both in terms of quality and coverage. This is something that we really need to look into more, in order to improve our checkin confidence and speed. A subset of our C# tests are run with AppVeyor, and you can manually run additional tests to validate changes on your local machine: https://github.com/Microsoft/nodejstools/wiki/Running-Our-Tests The current NTVS tests mainly focus on Visual studio integration, and many are UI based or have dependencies on things like the file system 😢
It's far too much work to go back and fix all out our legacy tests in a single pass, so I think that introducing new tests that cover a small area well is the correct approach to improve the NTVS testing situation. I'd be happy to provide pointers or assistance to anyone interested in looking into this.


Fix AMD registration

Fixes this error when using Webpack:
ERROR in ./~/is_js/is.js
Module not found: Error: Cannot resolve module 'is' in node_modules/is_js
@ ./~/is_js/is.js 8:8-13:10

Hey @davidmerrique
Thanks for the PR. Actually I have no experience with Webpack.
Are you requiring the module as:
var is = require('is_js');
is.number(42);

@arasatasaygin Yes, that's how I'm requiring it, but Webpack sees define(['is'], function(is) { and tries to use that, instead of the CommonJS implementation which causes the error.
I found a solution that tells Webpack not to use AMD at all for anything in node_modules
module: {
  loaders: [
    { test: /node_modules/, loader: "imports?define=>undefined" }
  ]
}

But why use 'is' for AMD and 'is_js' for CommonJS?

Glad you found a solution @davidmerrique
The module registration for 'is' was occupied so I had to add is.js as 'is_js'
Sorry for the name confusion. Cheers.

+1
Would be cool to have this working out of the box. Spent some time figuring out why it is not working with webpack...


fix(doc): add notice when building on differing architectures

Fixes #541

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

Reformatted markdown too

Could you please also remove this folder: https://github.com/awslabs/generative-ai-cdk-constructs/tree/main/layers/langchain-common-layer/python/genai_core as part of this PR ? It was a miss from a previous one :) Thanks !

Closed by mistake

Could you please also remove this folder: https://github.com/awslabs/generative-ai-cdk-constructs/tree/main/layers/langchain-common-layer/python/genai_core as part of this PR ? It was a miss from a previous one :) Thanks !

done https://github.com/awslabs/generative-ai-cdk-constructs/commit/b96e47766f7ed223f00cf025447687e3fdeca193


Ceedling 0.32: "support paths" causing plugin to get stuck.

I found another "error", but it's something that only partially affects me. With the new :paths: changes in Ceedling 0.32, locations that I define in :support: seem to result in cppcheck getting stuck at Creating Cppcheck xml report... . It only partially affects me though because for my project I am able to just move the :support: paths to :include: and it doesn't get stuck. I can't share many details of the project I'm working on so the most explanation I can give is that this:
:paths:
  :test:
    - +:test/**
    - -:support
  :source:
    - ../Lib/**
  :include:
    - ../Lib/**
    - ../Startup/**
    - ../Src/**
    - ../Inc/**
    - ../Drivers/CMSIS/**
  :support:
    - support
    - ../Drivers/STM32G0xx_HAL_Driver/Inc/**
  :libraries: []

doesn't work and causes it to get stuck. However this:
:paths:
  :test:
    - +:test/**
    - -:support
  :source:
    - ../Lib/**
  :include:
    - ../Lib/**
    - ../Startup/**
    - ../Src/**
    - ../Inc/**
    - ../Drivers/CMSIS/**
    - ../Drivers/STM32G0xx_HAL_Driver/Inc/**
  :support:
    - support
  :libraries: []

works just fine.
In case it is relevant, I want to also note that I'm using CppCheck in WSL, installing it via snap, then downloading the cppcheck-htmlreport separately to my /usr/local/bin.
#!/bin/bash

# Set noninteractive to avoid prompts during installation
export DEBIAN_FRONTEND=noninteractive

CPPCHECK_HTMLREPORT_INSTALL_DIR="/usr/local/bin"

# Install CppCheck
sudo snap install cppcheck
sudo curl -o "$CPPCHECK_HTMLREPORT_INSTALL_DIR/cppcheck-htmlreport" "https://raw.githubusercontent.com/danmar/cppcheck/main/htmlreport/cppcheck-htmlreport"
sudo chmod +x "$CPPCHECK_HTMLREPORT_INSTALL_DIR/cppcheck-htmlreport"

Are you able to provide the output when running the task? e.g.: ceedling --verbosity=obnoxious cppcheck:all
Or at least the > Shell executed command part.

 *  Executing task: ceedling --mixin=cppcheck.yml --verbosity=obnoxious cppcheck:all

🚧 Loaded project configuration at default location using ./project.yml
 + Merging command line mixin using cppcheck.yml
 > Set which Ceedling from config :project ↳ :which_ceedling => gem

Ceedling set up completed in 343 milliseconds
mkdir -p build/gcov/out
mkdir -p build/gcov/results
mkdir -p build/gcov/dependencies
mkdir -p build/artifacts/gcov
mkdir -p build/artifacts/cppcheck
Creating Cppcheck xml report...

Doesn't seem so helpful, I cannot see the actual command executed. Does it freeze also when creating only the text report?

Yes

Let me know if you are able to setup a simple project that reproduce the issue.

The issue may actually be something on my end that I've figured out, let me investigate some then I'll touch back if it isn't, and close the issue if it is.

When it get an HTML report, it has the following which might be related

Maybe with substractive paths can help.

It looks like the issue is due to a particular very large source file that is just causing cppcheck to freeze. I can tell because if I remove the file, then I'm able to get the results I expect. If I try to run with that file, it's .a1 file never generates.

I should note this file was so large I had to split its tests into multiple files and use CMOCK_MEM_DYNAMIC

If there's a way to use options to -i to have cppcheck ignore a particular file, that would be very helpful.

So, maybe Cppcheck is not freezing at all but just working hard on analyzing that large file. Does the file have a lot of preprocessor directives?

Do you think that adding the :exclude section to the configuration options would be helpful? In the mean time, you can specify manually the -i option on the :options sections. e.g.:
:cppcheck:
  :options:
    - -i problematic_file.c

The amount of time it's taking seems more like a freeze. I'll try excluding it tomorrow in the meantime so that the static analysis can at least finish.

It is also worth checking if running the analysis outside Ceedling with just that file works or also hangs. e.g.:
cppcheck problematic_file.c

The file does have a lot of preprocessor directives (or at least its header does), but it still seem like an actual freeze. Specifying the -i manually though does allow me to get expected static analysis results though so I'll do that in the meantime as a fix.

It is also worth checking if running the analysis outside Ceedling with just that file works or also hangs. e.g.:
cppcheck problematic_file.c

It can do this, but when running with the plugin/ceedling it seems like its never going to finish and even using regular cppcheck takes a LONG time. I'm just going to ignore it for now. For the README.md, might want to show how you can ignore a file, just in case someone else runs into a similar situation.

I've just added the config option to exclude files from the analysis, give it a try. Also, if you still want to get the big file analyzed, try setting the check level to normal, that may help reducing the analysis time. e.g.:
:cppcheck:
  :check_level: normal

The exclude does seem to work.
Running just that file alone with ceedling cppcheck also works. Running all with the check_level at normal does allow it to finish too.
In summary, running on my local machine.

Check Level
File Excluded
Approx. Time

Normal
Y
< 1s

Normal
N
2m 50s

Exhaustive
Y
35s

Exhaustive
N
(Still running right now to see if it finishes ever)

This is ran as part of a CI/CD pipeline, so that's why I'm trying to not make it take any longer than it needs to.
I guess the questions I have now are:

What is the differences between normal and exhaustive check levels?
Why this particular file takes so long still.

Looking at the Cppcheck Philosophy, it might be best to have a normal check_level be the default.

Regardless, it does actually finish it seems. It just takes a really long time and with the pipeline machine's capabilities, exhaustive results in too long. This can be closed now unless there's any further changes you want to make that I could test.

Actually, normal check level is Cppcheck's default, I don't remember why I set exhaustive as the default for the plugin. That needs to be changed for sure.
I'm wondering if the big file is from yours or from a publicy available SDK.

It is not publicly available. However, I do notice now that when running with check_level of normal I do get the following message in the html report.

Limiting ValueFlow analysis in function 'XX' since it is too complex. Please specify --check-level=exhaustive to perform full analysis.

I think the best thing to do is set the default to normal, then close the issue because the rest of the issue (the function in question) is something on my end to solve. Thank you!

Looking further into this, part of the issue is definitely the snap package. Manually building the latest cppcheck runs MUCH faster.

@tyler-macinnis
I updated the main branch with a few changes for Ceedling development version. Those include setting the check level to Cppcheck's default (normal).

When I set :check_level: exhaustive I get this
Ceedling set up completed in 88 milliseconds

🧨 EXCEPTION: undefined local variable or method `check_level' for #<Cppcheck:0x0000555b2a666ea0>
🌱 Ceedling could not complete operations because of errors

Running Raw Tests Output Report
-------------------------------
Tests produced no extra console output.

Sorry about that, I've already fixed it.


Calling 'get_max_distance' on TreeNode object renders object uncopiable

Calling 'get_max_distance' on a TreeNode object causes the copy method of that object to throw an error:
In [3]: from skbio import TreeNode
   ...: from io import StringIO
   ...:
   ...: X = TreeNode.read(StringIO('(a:1.,(b:1.0,c:1.0));'))
   ...: X.get_max_distance()
   ...:
   ...:
Out[3]:
(2.0,
 [<TreeNode, name: b, internal node count: 0, tips count: 0>,
  <TreeNode, name: c, internal node count: 0, tips count: 0>])

In [4]: X.copy()
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-4-f95bdccb4e6f> in <module>()
----> 1 X.copy()

...[clipped]...

~/Development/anaconda/envs/qiime2-2018.8/lib/python3.5/copy.py in deepcopy(x, memo, _nil)
    164             copier = getattr(x, "__deepcopy__", None)
    165             if copier:
--> 166                 y = copier(memo)
    167             else:
    168                 reductor = dispatch_table.get(cls)

TypeError: copy() takes 1 positional argument but 2 were given

This can be avoided by deleting the MaxDistTips attribute from each node:
In [5]: for node in X.postorder():
   ...:     delattr(node, 'MaxDistTips')
   ...:
   ...: X.copy()
   ...:
   ...:
Out[5]: <TreeNode, name: unnamed, internal node count: 1, tips count: 3>

I spent a long time on this. Basically the wrong copy constructor gets triggered. Solving this in the general case is problematic as, in this example, MaxDistTips contains TreeNode meaning a copy would lead to an infinite loop. The right thing to do here is warn if not copying attributes, and of course, to not bomb out here. Related to #1196


Mysql setup question

Is there a way to specify a bind address for mysql when building druaplvm?

will i need to prefix that with drupal_ assuming thats the convention you are using for the drupal database?

@haynescw - Nope, that's a system-wide change to MySQL, so it applies to the MySQL daemon itself.

oh yeah, good point, Thanks.


Can Office Add-ins be used to display an Office document in a web page?

Hope this is the right place, but after about 45 minutes I don't see the above topic addressed at:
Article URL
https://docs.microsoft.com/en-us/office/dev/add-ins/
Issue
There are many requests for info about how to embed an Office Document (read-only or editable too) on a generic web page on Stack Overflow, but I don't see this issue addressed in your documentation. The info seems all about embedding web content into an Office Application.
If this is not the intention of the Office Add-ins, fine: just document this COMMON issue in your initial discussion of what the Add-ins do - and can not do! If this is described, it doesn't seem to be that discover-able. Of course I might not have found it yet...
Thx!

This cannot be done with an Office add-in.
You might be able to achieve this by adding an iframe to the web page and setting iframe's src property to the URL of an Office document on OneDrive or Sharepoint. I haven't tried it, but I think the document would open in Office Online.

Perfect! I'm just happy to know what is in scope, versus out of scope. (Not that I have a route forward, aside from going to One Drive and using an embed code from there: usable, but not ideal for me.)
Thanks for the reply!


A11y_SQL database projects extension_Database Project_Database Project_Name Role Value: Incorrect role is defined for the 'read our docs' link as button.

GitHub Tags:
#A11yMAS; #A11yTCS; #A11ySev3; #DesktopApp; #Name Role Value; #WCAG4.1.2; #Win11; #SH-SQL Azure Data Studio-Win32-March23; #Win32; #SQL Azure Data Studio; #AILimited;
"Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier."
Environment Details:
Application Name: SQL Azure Data Studio
Version: 1.41.2 (user setup)
Microsoft Windows 11 Enterprise 10.0.22621 Build 22621
Repro Steps:

Launch Azure Data Studio
Tab till extension and search for “SQL Database Projects” and install it.
Tab till database project and press enter. “Database Project” panel will open.
Tab till 'Read our docs' link.
Verify whether correct role is defined for "Read our docs" as link or not.

Actual Result:
Incorrect role is defined for the 'read our docs' link as button.
Expected Result:
Correct role should be defined for the 'read our docs' control as link. As it is redirecting to new page.
User Impact:
Screen reader user will not be able to get the proper information about the link.
Attachment:

same as https://github.com/microsoft/azuredatastudio/issues/22077

@kisantia
This bug is not same as https://github.com/microsoft/azuredatastudio/issues/22077.
The bug which you mentioned is logged with respect to MAC. The present bug is logged with respect to Win32.
We need to log different bugs for different platforms.
Thanks!

Similar issue is repro in Below screen also
Environment and OS details:
Azure Data Studio Version: 1.42.0 (user setup)
Windows 11 Enterprise Version	22H2
Installed on	28-12-2022
OS build	22621.1413
Experience	Windows Feature Experience Pack 1000.22639.1000.0
Pre-Requisite:

Install Azure data studio From here https://learn.microsoft.com/en-us/sql/azure-data-studio/download-azure-data-studio?view=sql-server-ver16&tabs=redhat-install%2Credhat-uninstall
Once installation done , Install MySQL Extension in Azure data studio
Tab Till  new connection and press enter
Enter a valid server name username and password and press connect

Repro Steps:

Launch Azure Data Studio.
Select the Connections icon (if not already selected) from left bar.
Click on the ellipses '...' and select "New Deployment"
In the Deployment options, select "Azure Database For MySQL" card.
Tab till Microsoft azure terms of use and Microsoft Privacy Statement
Verify that Learn more Microsoft azure terms of use and Microsoft Privacy Statement  defined as link or not

Actual Result:
Learn more, Microsoft azure terms of use and Microsoft Privacy Statement defined as button instead of link.
Notes:
Similar issue repro on Dashboard page also.
Expected Result:
Learn more, Microsoft azure terms of use and Microsoft Privacy Statement should be defined as a link.
Attachment:


Line Material is broken

three version: 126
three-stdlib version: current

Problem description:

Line Material is badly broken
Relevant code:

Check the storybook on alpha
Suggested solution:

I noticed this on drei@beta as well. Not really sure what's going on regarding color as read-only, given that there are public getters and setters.

I noticed this on drei@beta as well. Not really sure what's going on regarding color as read-only, given that there are public getters and setters.

That bug I believe is either the order of calling setValues before Object.defineProperties OR using the property enumerable however, its a bit more broken than that, tbh I might just recopy the original from three and go from there. If you're interested this could be something you could look at?

@joshuaellis i can later this week for sure!

fixed via pmndrs/three-stdlib@174ab6c


Update to Go 1.20

Description

go.mod to 1.20
Dockerfile updated
Replace deprecated rand.Seed function
Update golangci-lint version

Issue link
/
Checklist

Purpose

[ ] Bug fix
[x] New functionality
[ ] Documentation
[ ] Refactoring
[ ] CI

Test

[x] Unit test
[x] E2E Test
[ ] Tested manually

Introduce a breaking change

[ ] Yes (description required)
[x] No

Introduce changes in the Operator

[ ] Yes (description required)
[x] No

/reverify


Masked data iterator

Fixed history, added a test, removed old pull request.
I have found this useful for NLP tasks in recurrent neural networks where there are inputs that should be ignored within input windows, (no 'UNKOWN') class etc.

We are looking into bringing this in. Thanks for adding the test! Have you thought about subclassing it from the data iterator or adding mask as an optional input, to make data iterator handle both case (and re-use what is being done in there)?

Thank you @Bam4d It has been quite a while and sorry for the delay.
Could you please resolve the conflicts?


feat: support proto in object literal (type-check only)

related #38385
close #13933
Related:
https://tc39.es/ecma262/#sec-__proto__-property-names-in-object-initializers
https://github.com/tc39/ecma262/pull/2125

Now I only change the type checker around __proto__ I'll revisit @ExE-Boss's review on emitting __proto__ later, maybe some suggestion from the TypeScript team members

Now I only change the type checker around __proto__ I'll revisit @ExE-Boss's review on emitting __proto__ later, maybe some suggestion from the TypeScript team members

I don't understand the spec process for moving things out of Appendix B. Is there a Stage 1,2,3,4 process? Or does it just need an ad-hoc OK from the committee? Has the __proto__ syntax move finished the process yet?
As long as __proto__ is in appendix B with all the other "icky" stuff, I don't think it's worthwhile supporting it in Typescript.

@sandersn This PR is about the proto literal syntax which is not normative optional.
The optional one is Object.prototype.proto and they're different

@sandersn re:

As long as proto is in appendix B with all the other "icky" stuff, I don't think it's worthwhile supporting it in Typescript.

If Typescript is intended to be used for authoring code that targets the web, then Annex B support is required:

The ECMAScript language syntax and semantics defined in this annex are required when the ECMAScript host is a web browser. The content of this annex is normative but optional if the ECMAScript host is not a web browser.

One could argue that the either of those sentences is true, but also that they are false. I think it's reasonable to err on the side of flexibility and go with "Typescript should either act like, or make it possible to configure as, the web"

The object literal form of __proto__ moved out of Annex B in July, so this syntax is canonical and required by the spec. The behaviour of __proto__ is now just a regular part of the definition of parsing object literals.
The Object.prototype.__proto__ accessor remains normative optional, and I don't believe there's any interest of changing that.

👀 This PR has been 13 months, is there any progression?

I changed the branch name of this PR from "master" to "proto-literal-type-checking". I opened a new PR, please follow #48816.

This would have addressed #38385. Just linking these.


Hello World in JAVA language

What the program do ?

In what programming language it is written?

Hello world in  JAVA language


Python 3

Should support 3.6 at the least.

Now that #4 is merged, would you please consider another pypi release?

@uSpike, I've uploaded your changes to pypi.  I apologize for the delay.


Improve re-sync recovery examples in the tutorial.

This is no longer necessarily as it is clear that the re-sync throws away multiple tokens
now that the whole range of resyncedTokens is marked in the playground.


Whether the framework can support non-HTTP requests

Whether the framework can support non-HTTP requests

support websocket


Update outdated chef conf 2017 page

yeah I want to get this remove automatically via a finish date.


Deprecations: GRPC core

JavaMarshaller
Uses java serialization
Used in examples (requires code changes)
Since 2.3.0
Tasks:

[x] remove the deprecated code
[x] make sure the deprecation is correctly documented in 2.x (since, forRemoval on @Deprecated annotation, use @deprecated javadoc tag to link to the correct new implementation, or describe what to do if a simple replacement does not exist)
[x] validate documentation and examples are correct with regard to the deprecated element

Updated doc to remove any mention of java marshaller in GRPC via https://github.com/oracle/helidon/pull/4441

Closing issue since are tasks required for this issue are fulfilled


stationarity test

Missing functionality
It would be nice if the parameters for adfuller could be configured.
Proposed feature
If you have very large data sets, then using the standard AIC takes too much time and too much RAM.
It would be nice to chose BIC or maxlags.
e.g.
result = adfuller(series.dropna(), autolag='BIC')
or
result = adfuller(series.dropna(), maxlag=30)
Alternatives considered
No response
Additional context
No response

@alexbarros can you please add this issue to your backlog?


BalancerPoolAdaptor.sol Strategist useRelayer callDataDefinition

Scope
This issue is tied to PR #112.
adaptorData from strategists must follow guidelines as per Balancer documentation and other resources. This issue is meant to discuss and finalize guidelines on where to get particular params for preparing adaptorData for Strategists using Balancer. I have ideas for the way to generate the callData and will post them over the next day or so.
See "Resources" at the bottom of this scope description for context.
Below are the primary transactions that a strategist is predicted to carry out:

join() - joining a balancer pool and getting balancer pool tokens (bpts)
exit() - exiting a balancer pool via redeeming their bpt for their underlying assets and fees
swap() - includes singular and batch swaps where internal vault accounting is used.
deposit() - depositing their bpt into a gauge to gain additional liquidity mining rewards.
withdraw() - withdrawing their bpt from a gauge
claim_rewards() - claim rewards from the gauge that they have bpt in.

All of these types of transactions could be carried out with separate functions, but instead, we are using the BalancerRelayer.sol that allows chainedReferences. This is particularly useful when strategists want to join a balancer pool that requires some swapping to occur ahead of time.
ex.) If you need to do multiple swaps with DAI then you can actually do that all in one tx and also have it join the respective pool, let’s say bb-a-usd.

Resources

Balancer Docs - These are comprehensive, and it's suggested to look through the code-base to better understand everything in tandem.
Balancer SDK
Balancer Github Monorepo

This issue is being closed because we have pivoted to a more scope-focused design for the BalancerPoolAdaptor. See PR #126 for details.


Enable researchers to change CIDR block of their workspace

Hi, related to issue #187 we need also to enable researchers to change CIDR block of their workspace and not just admins
https://github.com/awslabs/service-workbench-on-aws/issues/187
Because Public IP address changes when someone restarts it's modem connection and won't be able to connect anymore to his work

Thanks for calling this out Paul! As of right now we do not have that functionality in the UI but a workaround is you can change the CIDR manually in the AWS Account. We will add this additional context to our backlog

This feature was added as part of https://github.com/awslabs/service-workbench-on-aws/pull/269


Put the html code for degree instead of the special character

This causes display issues in some mail clients

Actually, putting the following header could probably also solve the issue, but I have not tested that.
Content-Transfer-Encoding: 8bit
I think the issue is because we currently have a charset of 8 bits with a transfer encoding of 7 bits.
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: 7bit

Encoding in base64 might even be cleaner

Does this work will all email clients?
@Abyss777, can you have a quick look to see if there are any potential issues.

It works with at least thunderbird, macos mail, rainloop.

@tananaev checked it, no issues.
It is really more correct way for degree sign in html.

Merged, thanks @renaudallard for pull request and thanks @Abyss777 for reviewing the change.


Move deprecated endpoint indicator up higher in the request representation

It should be on the same line as the POST /path imo so that people don't spend time reading deprecated APIs.

I've just pushed a change like this: https://adoring-einstein-5ea514.netlify.app/client-server/#post_matrixclientr0account3pid

...we could choose to drop the bigger banner underneath now.

@turt2live , are you happy that this is fixed?
-> https://adoring-einstein-5ea514.netlify.app/client-server-api/#post_matrixclientr0account3pid

yup, thank you!


Code breaks when include BRKGA.hpp

If I add an include the code breaks:
#include "../OptFrame/Heuristics/EvolutionaryAlgorithms/BRKGA.hpp"
$ make
g++ -c -O3 --std=c++17 -fconcepts -D_GLIBCXX_DEBUG mainNPP.cpp -o mainNPP.o
In file included from ../OptFrame/Heuristics/EvolutionaryAlgorithms/BRKGA.hpp:27,
                 from mainNPP.cpp:14:
../OptFrame/Heuristics/EvolutionaryAlgorithms/../../Population.hpp: In member function ‘std::__debug::vector<double> optframe::Population<R, ADS, S>::getFitness(int) const’:
../OptFrame/Heuristics/EvolutionaryAlgorithms/../../Population.hpp:128:26: error: could not convert ‘pos->((const optframe::Population<R, ADS, S>*)this)->optframe::Population<R, ADS, S>::pFitness.std::__debug::vector<std::__debug::vector<optframe::Evaluation> >::operator[]()’ from ‘vector<optframe::Evaluation>’ to ‘vector<double>’
       return pFitness[pos];
                          ^
make: *** [makefile:9: mainNPP.o] Error 1

Source code:
https://github.com/rodoufu/optframe/blob/number_partition/src/MyProjects/mainNPP.cpp

Strange, perhaps it's fixed already... we need to put back all metaheuristics into core functionality, including automated tests. This way, nothing will ever break.

Should be fixed now.


Support for Custom Patches and Environment Files in nvm

I am using an experimental Gentoo setup with LLVM/Clang as the default compiler and without GCC. In this environment, I have encountered some issues while trying to use different versions of Node.js with nvm.
To make Node.js versions work correctly in such environments, it would be extremely helpful if nvm supported the application of custom patches. I would like to propose the implementation of a patch directory, perhaps located at .nvm/patches/${patchname}.patch, where users could place patches to address compatibility issues specific to their environment.
Additionally, having an environment file, such as .nvm/env, would be beneficial. This file would allow users to define custom environment variables like CC=clang++ and CXX=clang++, which would be automatically sourced by nvm when switching between Node.js versions. This would simplify the process and make it more expeditious for users in similar situations.
I understand that this feature may be applicable to only a few situations, but I believe it could greatly assist users working with non-standard setups, particularly those utilizing LLVM/Clang as the primary compiler without GCC.
While I recognize that this request is not urgent, I believe that implementing these features could not only resolve my own challenges, but also help others facing similar issues in the future.

I'm concerned about the dangers of supporting this more directly - node (like all software) should only be used unchanged from how the maintainers released it. Patching software is a fast path towards bugs and security vulnerabilities.

I will say that scoping the feature request to "install-specific env variables" makes it much more reasonable, since then it's up to node what hooks it provides.


optimization for mips64

I've done some optimizations base on mips64(cpu: loongson3a),can the code be submitted to the community?How to submit?Thanks a lot.

@GuXiWei
you can create a pull request to submit your code.

ok thanks.

@GuangweiWang
Hi，I have submitted the code for two weeks（#3005）。I don't know if the code is capable of merging and when。thanks。

@GuXiWei
Ok, Will

@GuangweiWang
Hi, sorry to bother you, any suggestions about the commit (#3005)? thanks a lot :).

@GuangweiWang
hi, could you tell me the progress of the code review?I still have a few patches to submit.thanks a lot.

please patch it first.

@GuangweiWang
hi，I have submitted all the patches。

you can close this issue and use that PR to track the code review.


Add the ability to specify item icons

Is your feature request related to a problem? Please describe.
In all editors functions / method / text items for completions have icons instead of text. For example, how completion looks in VSCode:

Describe the solution you'd like
Is it possible to allow user to specify custom text-based icons? Something like with signs, but for completion items. It would make more nice look :)

There is undocumented g:completion_customize_lsp_label.
Did not know about it, sorry.

That's fine, it's my fault for not documented it well. Also you might be interesting in wik where there is a customization guide on symbol that works per server basic and doesn't require using completion-nvim stuff.

Did not know about it! Thanks. But both approaches will not for custom sources. I created an issue for it in completion-buffers.

Now completion-buffers support g:completion_customize_lsp_label.

Nice! I saw your issues in completion-buffers. You're icons selection is neat! Mind if I put it in wiki for a reference?

Of course!
Here is the newest version.
Here is convenient icon cheat sheet.


mopidy-ytmusic: 0.3.5 -> 0.3.7

Description of changes

Update mopidy-ytmusic to latest version
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 190817 run on x86_64-linux 1

1 package built:

mopidy-ytmusic

Result of nixpkgs-review pr 190817 run on x86_64-linux 1

1 package built:

mopidy-ytmusic

Thank you!


Add Google Authorization

Simulate Android device authorization

Hype! I'll give it a try.

Thanks for your contribution @AKosterin! 👍


Update hypershift and CS image

What this PR does
Updates the hypershift-operator and CS image to have the latest changes of hypershift.
Jira:
Link to demo recording:
Special notes for your reviewer

You also need to run make materialize in the config directory as well

Since we are bumping CS,
I'd like to point out that this change requires a change of the provision shard config.
Similar to what is done here https://github.com/Azure/ARO-HCP/pull/819
Additionally, as that change is going to impact how we interact with the provision shard, it'll also require the dev env to be recreated as it is a breaking change - the current CS commit doesn't contain a migrations script

Do we need to recreate the dev env also when there are no active clusters in the DB?

Ah just read the no-mig-script comment


Enhance security documentation for InfluxData Platform

Enhance the InfluxData security documentation

create a security checklist
collect all product security-related topics and links
add more security-related guidance

Below are current docs related to security issues:
InfluxDB

Configuring InfluxDB

CollectD config option security-level

CollectD config option auth-file
Managing security

Authentication and authorization
HTTPS setup
Managing users and their permissions
Securing your host

Chronograf

Managing Chronograf security

Configuring TLS for Chronograf

Telegraf

CollectD configuration

Kapacitor

Configuring the HTTP API

Relevant issue to track for documenting: https://github.com/influxdata/kapacitor/issues/1690.


ci: initialize e2e workflow

Ⅰ. Describe what this PR does

ci: initialize the e2e workflow.
config: fix the template YAMLs.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist

[ ] I have written necessary docs and comments
[ ] I have added necessary unit tests and integration tests
[ ] All checks passed in make test

/lgtm


fix: lists in table headers

RM-9793

🧰 Changes
Fixes saving lists (other blocks too) in table headers.
🧬 QA & Testing
Kind of hard to test outside the editor. But I've been testing by running make mdx and playing around in the styleguidist playground thingy.

Broken on production.
Working in this PR app.

This PR was released!
🚀 Changes included in v6.75.0-beta.77


Introspect views

Closes #270
Ensure all instrospector return database views and add a boolean isView to the TableMetadata so users can tell them apart.
Todo

[x] document

I'm not sure on how to proceed on the documentation front:

Regarding the generated documentation, if I regenerate it running npm run docs:build it replaces several references to commits and creates a big diff. Therefore I was unsure if I should include it in the PR, please advise.
Regarding recipes or examples, I could not find any reference to the getTables method, would it be interesting to write something in this PR?

Thank you! 💪

Regarding the generated documentation, if I regenerate it running npm run docs:build it replaces several references to commits and creates a big diff. Therefore I was unsure if I should include it in the PR, please advise.

You can leave that out. @koskimas usually preps everything for release, we might automate this in the future in pre-publish with some other steps.

Regarding recipes or examples, I could not find any reference to the getTables method, would it be interesting to write something in this PR?

Generally, most documentation is written inline in ts docs. If you feel like subject at hand demands a recipe or a section in the main README.md, feel free to add that. Maybe an introspection recipe?

Awesome work @diogob! Thank you ❤


[urgent] Double project in Biblio, only one in GISMO: Models and algorithms for ultra-reliable ultra-mobile communication networks.

Bug
Double project in Biblio, only one in GISMO: Models and algorithms for ultra-reliable ultra-mobile communication networks.
Steps to reproduce:

Go to a record, scroll to projects
Search for "Models and algorithms for ultra-reliable ultra-mobile communication networks." as a project
See two projects:

Case where both are assigned:

https://backoffice.biblio.ugent.be/publication/8772988?redirect-url=%2Fpublication%3Fq%3DToward%2Bfine-grained%2Bindoor%2Blocalization%2Bbased%2Bon%2Bmassive%2BMIMO-OFDM%2Bsystem%2B%253A%2Bexperiment%2Band%2Banalysis%26sort%3Ddate-updated-desc#projects
The project is assigned twice:

Context in GISMO:
"in GISMO-backend vind ik alleen 3G098020 : onvolledig in GISMO en niet gekend bij FRIS. Het andere nummer vind ik niet, ook niet als ik op titel zoek. '
Expected behaviour

Only keep "3G098020" searchable and assignable (remove "3G036120") in projects
All records that have been assigned project 3G036120, will move to project 3G098020.

done


Add vision bar and extra icons

Adds a vision bar, similar to the inventory bar, which keeps track of the items visible to the agent.
Adds extra icon (Carrot and Onion) for experimenting

@krmr73 I have never used fork either, but the PR was from our branch to our repo, so I think its okay!


Frontend Project "Pixel Art Generator" Styling

Title and Issue number
Frontend Project "Pixel Art Generator" Styling
Close #3636
Output
Before

After

Checklist:

[x] I have mentioned the issue number in my Pull Request.
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have created a helpful and easy to understand README.md

@MohitGupta121 Kindly review this pull request.

Hi @MohitGupta121
Kindly review this pull request so that I can work on other issues.


Asian faces

I know the pre-trained model has not had enough Asian face dataset.
But I have seen an Asian face dataset:
http://afad-dataset.github.io/
Can it help to improve the model?

Thanks, that might be helpful. I've added it to the list here: https://github.com/ageitgey/face_recognition/wiki/Known-Face-Image-Datasets
Feel free to add others.

I opened a thread on dlib to retrain using this dataset, and I think this is not possible.
https://github.com/davisking/dlib/issues/1407

wow. can't believe i can contribute something.

@ageitgey Can you add http://trillionpairs.deepglint.com/overview please?

Once you register and login to the trillionpairs website you are directed to download the data from:
https://drive.google.com/drive/folders/1ADcZugpo8Z6o5q1p2tIAibwhsL8DcVwH

I found something on a Japanese language website:
The Japanese Female Facial Expression (JAFFE) Database
　http://www.kasrl.org/jaffe.html
　10人の日本人女性、7種類の表情。
Face database
　http://viscog.hku.hk/facedb.htm
　98人の香港中国人(40male, 58female)、正面顔と45度顔。
CAS-PEAL-R1 face database
　http://www.jdl.ac.cn/peal/index.html
　1040人の中国人、角度や表情やライティング等の差分を含め、総画像枚数30900枚。

when the new model of asian face will release? @ageitgey


feature new stuff v1.0.2

:star: PR built and available in a preview environment sundeer-node-http-pr-6 here


Adds Pandas DF JSON materializer

This change adds the PandasJsonWriter to_json function to the existing Pandas materializer example script and updates the materialization notebook.
Changes

examples/pandas/materialization/notebook.ipynb
examples/pandas/materialization/my_script.py

How I tested this

Successfully ran unit tests for py3.11 locally using the following command in the root directory: pytest tests/
Successfully ran unit tests for py3.7-3.10 using docker run command found here.

Notes
N/A
Checklist

[x] PR has an informative and human-readable title (this will be pulled into the release notes)
[x] Changes are limited to a single goal (no scope creep)
[x] Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
[x] Any change in functionality is tested
[x] New functions are documented (with a description, list of inputs, and expected output)
[x] Placeholder code is flagged / future TODOs are captured in comments
[x] Project documentation has been updated if adding/changing functionality.

The image in the notebook doesn't reflect what should be visualized. Otherwise the code looks great, thanks!

What needs to be corrected about the image below?

a) Should there be two separate pictures, one for each materializer?
b) Should there be one single picture, but two sets of independent DAG graphs for each materializer?
c) or something else?

The image in the notebook doesn't reflect what should be visualized. Otherwise the code looks great, thanks!

What needs to be corrected about the image below?

a) Should there be two separate pictures, one for each materializer?
b) Should there be one single picture, but two sets of independent DAG graphs for each materializer?
c) or something else?

this image looks correct now! I was meaning in the notebook the image isn't this one.

The image in the notebook doesn't reflect what should be visualized. Otherwise the code looks great, thanks!

What needs to be corrected about the image below?

a) Should there be two separate pictures, one for each materializer?
b) Should there be one single picture, but two sets of independent DAG graphs for each materializer?
c) or something else?

This image looks correct! I was meaning in the notebook the image isn't this one.
The one in the notebook that's checked in looks like:

I think this was an issue with my PyCharm IDE's Jupyter Notebook integration. I updated my PyCharm and ran all the cells, so the checked-in notebook visualization should be updated.


optimize_from_memory returns zero byte image

Hey there!
Calling
optimize_from_memory(img_byte_arr, bit_depth_reduction=False, color_type_reduction=False, palette_reduction=False, grayscale_reduction=False) results in 0 byte image.
Doing just optimize_from_memory(img_byte_arr) works fine.

Looking at force param. Is that by design?
force | Write to output even if there was no improvement in compression

Hi @RaiaN , this is likely a bug with oxipng. I can't reproduce with the latest v7 so marking this as closed.


Fix a typo NibOwnLoadable to NibOwnerLoadable

Fix a typo NibOwnLoadable to NibOwnerLoadable on the Readme.md

:+1: thx!


allow symlinks into /System in relocatable bottles

This allows Python virtualenvs to be relocatable.

Without this change:
==> Detecting if jrnl-1.9.7.el_capitan.bottle.2.tar.gz is relocatable...
Warning: Absolute symlink:
  /usr/local/Cellar/jrnl/1.9.7/libexec/.Python -> /System/Library/Frameworks/Python.framework/Versions/2.7/Python
  /usr/local/Cellar/jrnl/1.9.7/libexec/include/python2.7 -> /System/Library/Frameworks/Python.framework/Versions/2.7/include/python2.7
  /usr/local/Cellar/jrnl/1.9.7/libexec/lib/python2.7/UserDict.py -> /System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/UserDict.py
  /usr/local/Cellar/jrnl/1.9.7/libexec/lib/python2.7/_abcoll.py -> /System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/_abcoll.py
  /usr/local/Cellar/jrnl/1.9.7/libexec/lib/python2.7/_weakrefset.py -> /System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/_weakrefset.py
  /usr/local/Cellar/jrnl/1.9.7/libexec/lib/python2.7/abc.py -> /System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/abc.py

I think this should always be safe?

let's block PRs like Homebrew/homebrew-core#3351 and Homebrew/homebrew-core#3352 on this for a second

Minor comment, but this looks a lot like the obvious and right thing to do.

@ilovezfs and I were chatting and agree that everything SIPpy is probably also safe though we'd want to scope the exemption to only OS X in that case. I kinda think the minimal change is fine for now unless we discover another use case.

Great to hear you've also thought about this! I briefly wondered about other system locations, but keeping this minimal until a broader need arises makes a lot of sense.
:+1:

We could go further here I think and exclude anything outside HOMEBREW_PREFIX and HOMEBREW_REPOSITORY.

As a bottle that symlinks to e.g. /usr/X11 or something may or may not be usable on another system but it's still definitely relocatable. This check was added to avoid absolute symlinks to Homebrew paths and not system ones.

Added some commits that:

allow bottles to be relocated if they have arbitrary absolute symlinks
add a new check to disallow absolute symlinks within HOMEBREW_PREFIX (in addition to HOMEBREW_PREFIX/opt and HOMEBREW_CELLAR, which the existing checks cover)

Looking good. A few final nits from me then 🚢

Sorry @tdsmith, feel free to push back on any of these changes that aren't really your code.

Thanks for everyone's comments!

I'm not sure which set of changes is potentially problematic here, both Tim & Mike pushed bottle logic tweaks today, but we're seeing some CI rebellion on bottling.
Yosemite, alot:
==> brew bottle --verbose --json alot
==> FAILED
==> Determining alot bottle revision...
==> Bottling alot-0.3.7.yosemite.bottle.tar.gz...
Error: No such dylib name: /usr/local/opt/gpgme/lib/libgpgme.11.dylib

Same thing with El Cap here. Repeated on Yosemite here. PR causing the failures is here.
Will poke at it later today if nobody beats me to it, but need to grab some sleep at this point.

@DomT4 Couldn't reproduce locally 😥

Same; I don't think this is failing in a part that I touched. :/ If anything I think @woodruffw's pickier mach-o code might be having a bad interaction with something?
FWIW on alot I see:
tim@rocketman:~$ brew bottle -vd --json alot
/usr/local/Library/Homebrew/brew.rb (Formulary::TapLoader): loading /usr/local/Library/Taps/homebrew/homebrew-core/Formula/alot.rb
==> Determining alot bottle revision...
==> Bottling alot-0.3.7.el_capitan.bottle.tar.gz...
Changing install name in /usr/local/Cellar/alot/0.3.7/libexec/lib/python2.7/site-packages/gpgme/_gpgme.so
  from /usr/local/opt/gpgme/lib/libgpgme.11.dylib
    to @@HOMEBREW_PREFIX@@/opt/gpgme/lib/libgpgme.11.dylib
...

@MikeMcQuaid @tdsmith Did any of you do export HOMEBREW_RUBY_MACHO=1 before trying locally? If it's indeed an unfortunate interaction with ruby-macho (as it seems to be given the nature of the failure and the fact that the Mavericks bot is unaffected), that would be necessary to be able to reproduce. I'm looking into it, but the dependencies haven't finished building just yet …

I'm not sure which set of changes is potentially problematic here, both Tim & Mike pushed bottle logic tweaks today, but we're seeing some CI rebellion on bottling.

Before anyone wastes any time hunting down the cause: I was able to reproduce and I'll open an issue with all relevant details shortly. Just let me say that the problem is entirely unrelated to the changes here. The problem is very specific to alot and how one of its resources is built.

If any of the recent changes can be identified as the trigger for this problem: It would have to be the introduction of the Python virtualenv stuff. I suppose the build environment in such a virtualenv is sufficiently different from what it was before, that native extensions (or however this is called in Python land) end up being built differently …

To be honest, I forgot HOMEBREW_RUBY_MACHO was running on CI, and since it had passed CI before now it seemed likely to be either:

The move to virtualenv in the formula.
Mike's bottle changes.
Tim's bottle changes.

Since the failure output was on the bottle, and Tim & Mike had both contributed to this thread & would see the message I thought I'd drop it in here 😅.

Makes sense for me to drop in as well, since it's almost certainly exposing a flaw in ruby-macho :smile:

The problem has been documented in Homebrew/ruby-macho#50. Addressing it will probably require some minor architectural changes, thus a fix won't be available instantly. Any input on how ruby-macho should be reacting to similar conditions in the future is very welcome.


Allow for forcing an order of properties in structured JSON response

When having an LLM respond with JSON I often do something along the lines of {reasoning: "...", actual_property_i_care_about: "..."}. The idea is that the reasoning property isn't used on my end but gives the LLM the ability to think first, like with CoT. Of course, this requires the LLM to populate the reasoning term before the other terms.
With the new structured JSON response it would be nice if there were a way to enforce this. Even telling the LLM to put the elements in a specific order is ignored.

I did some digging and it looks like this will require a change to llama.cpp as well as Ollama (alternatively, we could just move the json_schema_to_grammar.cpp over to Ollama and modify it there, but it would be nice to backport the improvement)
As a side note it seems like the fields are ordered alphabetically, which is a workaround at least

#7978

Thanks (:


[DC-1520] Add primary_pid_rid_mapping checks to the clean rdr qc notebook

@brendagutman Nice PR! Just let me know if 135 wasn't a typo. I think it was.

You are correct @lrwb-aou !  I made the update and will merge this when the checks pass. Thanks for finding that!

replaced by another PR. Branch bg/dc_1520_a


Use .fttemplates in project root

Hi there, thanks for this extension  works very well.
Do we have to specify the folder in workspace settings.json for .fttemplates to work ?
at the moment it keeps defaulting to the global extensions .fttemplates folder
Thanks

Moin, thanks for reaching out. You don't need to specify the folder in the settings file. Having the folder at the project root is enough.
The global folder will however still be used in addition to the local .fttemplates folder to read templates. (I should probably make this configurable)
If it doesn't work I would appreciate if you could create a small repo which replicates your issue so I can take a more detailed look :)


add support for JS Self-Profiling data

This adds support for importing data in the format produced by the JS Self-Profiling API.
I'm not too familiar with the internals of this project, so I went the cheap route: there's a fairly straightforward mapping from the Self-Profiling data format to the Speedscope SAMPLED file format, so I've done that mapping and delegated to the Speedscope importer to do the rest of the work.

Hi @nornagon!
Thanks for adding this -- I didn't know this API existed, but it's so cool that it does!
The code as-is certainly isn't the best way of doing it. You probably want to use StackListProfileBuilder, like we do here: https://github.com/jlfwong/speedscope/blob/main/src/import/bg-flamegraph.ts
Before this can merge, this would also need tests. You can see example tests here: https://github.com/jlfwong/speedscope/blob/main/src/import/bg-flamegraph.test.ts
Given that this is also a new profile type, this would also ideally include the files necessary to generate this kind of profile locally, in case other features are added to the profile filetype. You can see example programs e.g. in https://github.com/jlfwong/speedscope/tree/main/sample/programs/javascript.
Which brings me to a question: I tried generating one myself locally to understand this, and ran into errors that say something like [Violation] Document policy violation: js-profiling is not allowed in this document. It seems like this is fixable via setting headers from the server. How have you been generating profiles for this?


Docker Desktop VM failed to start

I'm unable to start docker correctly on windows 10 enterprise eval (vers.1909 Build 18363.752) on virtual box 6.1 running on windows 10  x64 Pro host; I'm always having this error message:

Docker.Core.DockerException:
Docker.Core.Backend.BackendDestroyException:
Unable to start Hyper-V VM: 'DockerDesktopVM' failed to start.
Failed to start the virtual machine 'DockerDesktopVM' because one of the Hyper-V components is not running.
'DockerDesktopVM' failed to start. (Virtual machine ID 15617AFF-90C6-4E2B-8EEB-57010058D0C0)
The Virtual Machine Management Service failed to start the virtual machine 'DockerDesktopVM' because one of the Hyper-V components is not running (Virtual machine ID 15617AFF-90C6-4E2B-8EEB-57010058D0C0).
at Start-MobyLinuxVM, : line 688
at , : line 811
at Docker.Backend.ContainerEngine.Linux.Start(Settings settings, String daemonOptions, Credential credential)
at Docker.Backend.BackendNamedPipeServer.b__8_2(Object[] args)
at Docker.Core.Pipe.NamedPipeServer.<>c__DisplayClass9_0.b__0(Object[] parameters)
at Docker.Core.Pipe.NamedPipeServer.RunAction(String action, Object[] parameters)
System.Management.Automation.RuntimeException:
Unable to start Hyper-V VM: 'DockerDesktopVM' failed to start.
Failed to start the virtual machine 'DockerDesktopVM' because one of the Hyper-V components is not running.
'DockerDesktopVM' failed to start. (Virtual machine ID 15617AFF-90C6-4E2B-8EEB-57010058D0C0)
The Virtual Machine Management Service failed to start the virtual machine 'DockerDesktopVM' because one of the Hyper-V components is not running (Virtual machine ID 15617AFF-90C6-4E2B-8EEB-57010058D0C0).
at Start-MobyLinuxVM, : line 688
at , : line 811
at Docker.Backend.ContainerEngine.Linux.DoStart(Settings settings, String daemonOptions, Credential credential)
at Docker.Backend.ContainerEngine.Linux.Start(Settings settings, String daemonOptions, Credential credential)
 Microsoft.HyperV.PowerShell.VirtualizationException:
 'DockerDesktopVM' failed to start.

Failed to start the virtual machine 'DockerDesktopVM' because one of the Hyper-V components is not running.
 'DockerDesktopVM' failed to start. (Virtual machine ID 15617AFF-90C6-4E2B-8EEB-57010058D0C0)

The Virtual Machine Management Service failed to start the virtual machine 'DockerDesktopVM' because one of the Hyper-V components is not running (Virtual machine ID 15617AFF-90C6-4E2B-8EEB-57010058D0C0).
     Microsoft.Virtualization.Client.Management.VirtualizationOperationFailedException:
     'DockerDesktopVM' failed to start.

Failed to start the virtual machine 'DockerDesktopVM' because one of the Hyper-V components is not running.
at Microsoft.Virtualization.Client.Management.View.EndMethodReturnInternal(IVMTask task, VirtualizationOperation operation, Boolean affectedElementExpected)
at Microsoft.Virtualization.Client.Management.VMComputerSystemBaseView.EndSetState(IVMTask setStateTask)
at Microsoft.HyperV.PowerShell.ExtensionMethods.OperationWatcherExtensions.<>c__DisplayClass4_01.<ConvertActionToFunction>b__0(T x)             at Microsoft.HyperV.PowerShell.ExtensionMethods.OperationWatcherExtensions.PerformOperationWithReturn[T](IOperationWatcher watcher, Func1 startTaskMethod, Func2 endTaskMethod, String taskDescription, VirtualizationObject targetObject)             at Microsoft.HyperV.PowerShell.VirtualMachine.ChangeState(VirtualMachineAction action, IOperationWatcher operationWatcher)             at Microsoft.HyperV.PowerShell.Commands.StartVM.ProcessOneOperand(VirtualMachine vm, IOperationWatcher operationWatcher)             at Microsoft.HyperV.PowerShell.Commands.VirtualizationCmdlet1.ProcessOperands(IList`1 operands, IOperationWatcher operationWatcher)
at Docker.Core.Pipe.NamedPipeClient.d__5.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at Docker.Core.Pipe.NamedPipeClient.Send(String action, Object[] parameters)
at Docker.Actions.DoStart(SynchronizationContext syncCtx, Boolean showWelcomeWindow, Boolean withNotifications)
at Docker.Actions.<>c__DisplayClass26_0.b__0()
at Docker.ApiServices.TaskQueuing.TaskQueue.<>c__DisplayClass18_0.<.ctor>b__1()

I've read about other similar issues but i cannot understand If there's a way to solve this...

Please check this issue to see if anything helps. Currently, using Docker in Commando on a Windows HOST machine is not supported due to some conflicts with nested virtualization. There are some work arounds discussed in that thread that may be able to help.
Closing issue as a duplicate.


accessibility support

Do you plan on adding accessibility support to the calendar?
its the only thing stoping me from using your great calendar component
as accessibility is mandatory on my country.
we need full keyboard support and aria rules all over the place.
thanks.

Hello @kisin. I'm sorry for the latency in responding; I had a connection issue. Yes, I'm working on the new version which focuses on accessibility improvements 😊❤

@kisin date picker is now accessible in version 1.1.0 🎉check it out!


It has a narrow API surface, which doesn't expose a lot of the data available in Linguist. For example, it doesn't expose the maps for file extension -> language, or the list of all languages. It does not expose the sample files for various languages (from Linguist) either, which would be useful for writing test cases.

Practical example where we run into this: The ALL_LANGUAGES constant in our TypeScript code needs to updated manually by running a shell command, which does some text manipulation on one of go-enry's source files. If this list were exposed as API, we could write a small Go binary that writes out a TypeScript file with the constant, and whenever go-enry is updated (or you'd get a PR failure if we check that in and do a golden test). (This specific issue could also be worked around by adding a small TypeScript package to this repo which exposes some utilities for client-side code in Sourcegraph.)

The API is a bit error-prone to use. Some examples:

Languages are strings so can't catch typos
Sometimes language strings can be empty, instead of returning a proper error
It's easy to forget considering the case that the language for a file may be ambiguous
We currrently have a wrapper package lib/codeintel/languages in the Sourcegraph monorepo to work these to some extent.

It would be nice to have a single point for language detection in Go which can be used by code in the monorepo and in other repos like Zoekt. There are five main options here:

Status quo: Slowly grow lib/codeintel/languages and continue using go-enry as today.
Upstream: Submit changes to go-enry upstream (optionally maintain lib/codeintel/languages on top): For example, if the list of all languages were exposed in the public API, then in downstream code, we could re-create the mapping of file extension -> language list (not ideal, as go-enry already has this available, but do-able).
Fork: Fork go-enry (optionally maintain lib/codeintel/languages on top), and make the changes we need there (i.e. skip the upstreaming step in 2.)
Codegen: Move lib/codeintel/languages into this repo + generate some extra code from Linguist.
CGo: Replace usage of go-enry entirely with CGo-based bindings to the Rust code that we already have (or maybe a mix of bindings + some codegen).

Here is a rough comparison table with my current thinking:

Consideration
Status quo
Upstream
Fork
Codegen
CGo

API
Restricted - We can only build on top of what go-enry exposes
Restricted-ish - We might be able to expose more things, but upstream may have resistance to adding some APIs for our use cases
Somewhat flexible - We probably don't want to deviate too much from upstream for ease of maintenance
Flexible - We can do whatever we want
Flexible - We can do whatever we want

Maintenance
Mostly version bumps, fix issues one-by-one when they come up
Mostly version bumps, might require occasionally submitting patches upstream & waiting
Need to update the fork from time to time, likely after upstream updates to a new version of Linguist
Bump the version of Linguist directly, and then update Sourcegraph to use new version of generated code
Bump the version of Linguist directly, and then update Sourcegraph to use new version of generated code. Initially, there may be extra issues related to CGo

Complexity
Nothing extra
Nothing extra
Depends on the extent of changes we make
Depends on the code generation steps
High - CGo generally has worse link times, poor debugger support, complex cross-compilation

Tech (more is worse)
Go
Go
Go
Go + Bazel (+ maybe a little bit of Rust if we keep the codegen for both Rust and Go in Rust)
Go + Bazel + Rust

Performance
OK
OK
OK
OK
Likely 10x - I have not benchmarked it, but basing this off the numbers in the upstream hyperglotglot repo, and the core logic here is mostly unchanged

Performance is mentioned only at the very end, as we currently already have a workaround where we set a 2048 byte size limit for the file contents slice passed to go-enry to avoid spending a lot of time on language detection. We have not done any A/B tests to know whether increasing this limit would help improve language detection in practice (and if so, by how much).

API requirement:

Add a way to map from SCIP language -> Linguist language and back.


Clicked install in my dashboard and it crashed my install

http://www.mytinytown.com/
Is what I get now, I unzipped the package in my packages folder, removed -master and clicked install. Just like I did to install community_store.

I deleted the install and started over, if it happens again I'll post it here, if not I'll close this.

Yes, when I install it crashes my site. This time I put on debugging.
Whoops \ Exception \ ErrorException (E_COMPILE_ERROR) HELP Concrete\Package\CommunityStoreAuthorizeNet\Controller::on_start(): Failed opening required '/home/tinytown/public_html/packages/community_store_authorize_net/vendor/autoload.php' (include_path='/home/tinytown/public_html/updates/concrete<IP_ADDRESS>_remote_updater/concrete/vendor:.:/opt/cpanel/ea-php56/root/usr/share/pear')
`/home/tinytown/public_html/packages/community_store_authorize_net/controller.php
$pkg = parent::install();
$pm = new PaymentMethod();
$pm->add('community_store_authorize_net','Authorize.Net',$pkg);
}
}
public function on_start() {
    require __DIR__ . '/vendor/autoload.php';
}

`

I fixed the issue by removing this line:
public function on_start() {     require __DIR__ . '/vendor/autoload.php'; }

This looks like you've downloaded the master branch and are trying to install that without running composer.
Instead, try downloading a 'release' of this package and installing that:
https://github.com/concrete5-community-store/community_store_authorize_net/releases
(make sure you read the notes in the Readme!)

Why thank you for that info. I am very new to github and had no idea. I've been using Vivid Store and needed something a little better.
Now I must ask, I downloaded the master to the main store, it installed fine, is this going to be a problem?


Bugs in bottleneck distance computation

I'm having an issue with the bottleneck distance function, haven't dug into the code to figure out what's up but hoping that someone can hunt it down.
First issue: passing an empty diagram (in the form of an empty array) just throws an error.
Second issue: I seem to have created multiple instances of diagrams whose distance to themselves are non-zero:
dgmA = np.array([[0.11371516, 4.45734882]])
bottleneck(dgmA,dgmA)

returns 2.17181683. First guess is that this is caused by diagrams with a single point but can't be sure.

Ack, sorry for the trouble! I thought I fixed this already, but it's
possible that either there's an additional bug or that the most recent
version. Hasn't been pushed. I'm traveling at the moment but will have a
look asap.
As a side note, I have been waiting to create a pure python implementation
of Hera for some time...
On Thu, Jan 9, 2020, 10:50 AM Elizabeth Munch<EMAIL_ADDRESS>wrote:

I'm having an issue with the bottleneck distance function, haven't dug
into the code to figure out what's up but hoping that someone can hunt it
down.
First issue: passing an empty diagram (in the form of an empty array) just
throws an error.
Second issue: I seem to have created multiple instances of diagrams whose
distance to themselves are non-zero:
dgmA = np.array([[0.11371516, 4.45734882]])
bottleneck(dgmA,dgmA)
returns 2.17181683. First guess is that this is caused by diagrams with a
single point but can't be sure.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/scikit-tda/persim/issues/28?email_source=notifications&email_token=AAJWDZSUV23GQNE5AEUNXVTQ46EY3A5CNFSM4KE6IIUKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IFFOWPA,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJWDZUSPVSERCJTOVOUY43Q46EY3ANCNFSM4KE6IIUA
.

It looks like a fix for diagrams with multiple points was released in August. I confirmed that still works, but the case of single point diagrams does not work.
@ctralie you think this can be fixed at the algorithm level? A simple short-circuit would be easy to implement.
I've started a PR with a failing test highlighting the issue here #29.

Thanks for doing that @sauln, I will have a look today
On Fri, Jan 10, 2020 at 3:56 PM Nathaniel Saul<EMAIL_ADDRESS>wrote:

It looks like a fix for diagrams with multiple points was released in
August. I confirmed that still works, but the case of single point diagrams
does not work.
@ctralie https://github.com/ctralie you think this can be fixed at the
algorithm level? A simple short-circuit would be easy to implement.
I've started a PR with a failing test highlighting the issue here #29
https://github.com/scikit-tda/persim/pull/29.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/scikit-tda/persim/issues/28?email_source=notifications&email_token=AAJWDZWWUOZVC4F6V6A6343Q5DOHRA5CNFSM4KE6IIUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIVF37I#issuecomment-573201917,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJWDZQXWW4YM2NFXYL6LDLQ5DOHRANCNFSM4KE6IIUA
.

Thank you for helping to make the code better @lizliz , and my apologies again for the bug.  It should be good now.  We will let you know when a new version is up on pypi.  Though before we push to pypi, I will also work to handle empty diagrams more gracefully


Update testing.mdx

change first param from gateName to configName for overrideConfig method

🚀 Deployed on https://6467a22780f2073ccd661305--cozy-fox-0defec.netlify.app


Use correct plural/singular form for resource methods

When we format method names for primitive operation methods, we need to change the typically plural resource name from the discovery doc to the singular form for all primitives except for aggregatedList and list.

Part of the GA release for Compute.


#4216: remove broken isTypeOf call (always undefined in graphql-tools v6)

This change passes all tests (I ran yarn test locally) plus one new test, and "fixes" the TypeError from later comments in issue #4216.
"fixes" is in quotes because I honestly don't understand exactly what is happening here, so I am not sure what the possible impact might be. And I would guess that this line wasn't ever covered by tests to begin with -- I believe it is triggered by fragments against interfaces directly, possibly co-interacting with the union.
I did look at the package.json in the commit when this line was created, and it was using graphql-tools v4, so I am suspicious this may be a consequence of a breaking change in graphql-tools between v4 and v6.
I was unable to find anything replacing it or any upgrade notes in the graphql-tools migration guide.
I created a new test from a minimal repro derived from my actual code. It does reproduce the TypeError from #4216 if line 105 of selection-set-to-object.ts is reverted.
The resulting types look good to me but definitely would like more eyes on it!
Thanks much for this excellent tool.

FWIW, this also works:
        } else if (isInterfaceType(typeOnSchema) && parentType.getInterfaces().includes(typeOnSchema)) {
and it seems like maybe it has the same meaning as the original code? though I am not sure that this predicate is ever needed.

That's great, thank you @benmosher :)
@n1ru4l can you please give it a look? I think you are the last person who worked on that piece of code... :)

@benmosher  let me know if you need any help with this PR. I really want to have it in our upcoming release!

Thanks for the feedback. Added back the check to the predicate as parentType.getInterfaces().includes(typeOnSchema) as discussed. Sorry for the lag, I missed the first few notifications!

@benmosher I couldn't push a rebase to your branch, i assume because it's a fork. No reason to keep this PR hanging.
I created a new PR (with the original commits, just rebased and added the missing test): https://github.com/dotansimha/graphql-code-generator/pull/5039
Thank you @benmosher and @n1ru4l for your work ❤


Allow getter-only properties to serialize as references if they're constructor parameters

To formalize PR #1022, consider the following code.
[JsonObject(IsReference = true)]
private class Condition
{
    public int Value { get; }

    public Condition(int value)
    {
        Value = value;
    }
}

private class ClassWithConditions
{
    public Condition Condition1 { get; }

    public Condition Condition2 { get; }

    public ClassWithConditions(Condition condition1, Condition condition2)
    {
        Condition1 = condition1;
        Condition2 = condition2;
    }
}

[Test]
public void SerializeIsReferenceReadonlyProperty()
{
    Condition condition = new Condition(1);
    ClassWithConditions value = new ClassWithConditions(condition, condition);

    string json = JsonConvert.SerializeObject(value, Formatting.Indented);
    StringAssert.AreEqual(@"{
  ""Condition1"": {
    ""$id"": ""1"",
    ""Value"": 1
  },
  ""Condition2"": {
    ""$ref"": ""1""
  }
}", json);
}

The current json output is
{
  "Condition1": {
    "Value": 1
  },
  "Condition2": {
    "Value": 1
  }
}

but should be
{
  "Condition1": {
    "$id": "1",
    "Value": 1
  },
  "Condition2": {
    "$ref": "1"
  }
}

This test currently fails because ClassWithConditions Condition1 and Condition2 are getter only properties but since they're constructor parameters it should still serialize the references. Adding a setter to these properties results in the expected json output.

Fixed. Thanks


Support bridging custom tokens by contract addresses

Is your feature request related to a problem? Please describe.
No response
Describe the solution you'd like
Since you are not bulk-whitelisting tokens from the unified token list, the bridge page should allow bridging custom tokens by entering their addresses. Optimism bridge does this.
Projects are being forced to deploy their forked bridge UI or use 3rd party bridges.

Describe alternatives you've considered
No response
Additional context
No response

@chicken-juju
Thanks for taking the time to open this issue! We've added this to our backlog, pending to be reviewed.

Hello, since this official bridge has been deprecated, this issue would no longer be possible to remediate


More generic translation for drag and drop repeater field & tooltips …

More generic translation for drag and drop repeater field & tooltips for the icons in repeater field.

Thank you, but not sure if the tooltips might be a bit of an overkill for all repeater buttons?
Also, tooltips should have their own tooltip translation string alongside label.

I do agree that for me as a developer the buttons are pretty self explanatory but when building a system for customers they might not always understand since they don't have to be tech-savy. What we could do is make them optional? Would be really annoying if you have to overwrite the template just for simple tooltips.
I updated the translations so they're their own thing.

I think we should have as few tooltips as possible by default (it should all be accessible and clear of course). Wouldn't it be really annoying if a tooltip popped up immediately every time you hover one of the repeater actions?

Thats what I'm thinking. We could swap the tooltip for title=""

Thats what I'm thinking. We could swap the tooltip for title=""

Exactly what I was thinking. However, then there's no gain on touch devices, which makes me prefer not having it at all...

Theres no mobile gain for tooltips either... it doesnt hurt adding the title anyway

Fair, but makes me wonder when we should add titles vs tooltips.

@danharrin there's a typo in this commit for builder.blade.php
line 111 & line 168, missing a single quote " ' "

Fixed in the next release


docs: update the general guidelines section

Relate #972
Fixes #995
Resolved the markdown-lint issue
Signed-off-by: Yash Pimple<EMAIL_ADDRESS>

I'm confused. I click the deploy preview netlify link above and then click Contributing in the top bar. I don't see your changes reflected?

Found it: homepage > contributing > General information about contributing > Contributing guidelines

HtmlTest and markdown link checks are failing. Please review the Details (by clicking the Details) link above, fix and once those checks are green we'll be on the way to an approval.


Infinite retry

srv
func (u *Users) Read(ctx context.Context, req *pb.ReadRequest, rsp *pb.ReadResponse) error {
       // ...
	return errors.InternalServerError("DATABASE_ERROR", "Error connecting to the database")
}

If an error is returned, it will retry until timeout

@asim hi

Go-micro will retry failed request by default, you disable it by setting MICRO_CLIENT_RETRIES=0.

Go-micro will retry failed request by default, you disable it by setting MICRO_CLIENT_RETRIES=0.
hi @xpunch

After testing, it is found that the following two cannot be solved
client.Retries(0)

export MICRO_CLIENT_RETRIES=0

The details of the issue and the PR are here
https://github.com/asim/go-micro/issues/2110


fastlane_match with app_store_connect_api_key doesn't work cross organization. Bundle id is not found.

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description
Our developer account in invited in multiple organizations. Until enabling 2fa we haven't have any issues with that. Fastlane would search for the bundle id in every account that we have access to.
What we receive right now is: An app with that bundle ID needs to exist in order to create a provisioning profile for it followed with list of apps, all from our own account. This is while we are using the app_store_connect_api_key action. If we fallback to the session based authorisation + application specific password there are no issues there. So adding app_store_connect_api_key is limiting the access to apps to our account only. I don't know if that's Apple's API limitation or a bug in Fastlane.
Command executed
fastlane match
Complete output when running fastlane, including the stack trace and command used

+--------------------------------+-------------------------------------------------------+
|                               Summary for match 2.176.0                                |
+--------------------------------+-------------------------------------------------------+
| app_identifier                 | ["bundle_id"]                                     |
| type                           | appstore                                              |
| git_branch                     | branch                                                 |
| team_id                        | team_id                                            |
| api_key                        | ********                                              |
| readonly                       | false                                                 |
| generate_apple_certs           | true                                                  |
| skip_provisioning_profiles     | false                                                 |
| username                       | account_email                                     |
| storage_mode                   | git                                                   |
| git_url                        | git@gitlab.com:url  |
|                                | es.git                                                |
| shallow_clone                  | false                                                 |
| clone_branch_directly          | false                                                 |
| keychain_name                  | login.keychain                                        |
| force                          | false                                                 |
| force_for_new_devices          | false                                                 |
| skip_confirmation              | false                                                 |
| skip_docs                      | false                                                 |
| platform                       | ios                                                   |
| derive_catalyst_app_identifier | false                                                 |
| fail_on_name_taken             | false                                                 |
| skip_certificate_matching      | false                                                 |
| skip_set_partition_list        | false                                                 |
| verbose                        | false                                                 |
+--------------------------------+-------------------------------------------------------+
[18:10:29]: Cloning remote git repo...
[18:10:29]: If cloning the repo takes too long, you can use the clone_branch_directly option in match.
[18:10:32]: Checking out branch branch...
[18:10:32]: 🔓  Successfully decrypted certificates repo
[18:10:32]: Verifying that the certificate and profile are still valid on the Dev Portal...
[18:10:32]: Creating authorization token for App Store Connect API
[18:10:33]:
[18:10:33]: ==========================================
[18:10:33]: Could not find App ID with bundle identifier 'bundle_id'
[18:10:33]: You can easily generate a new App ID on the Developer Portal using 'produce':
[18:10:33]:
[18:10:33]: fastlane produce -u account_email -a bundle_id --skip_itc
[18:10:33]:
[18:10:33]: You will be asked for any missing information, like the full name of your app
[18:10:33]: If the app should also be created on App Store Connect, remove the --skip_itc from the command above
[18:10:33]: ==========================================
[18:10:33]:
[18:10:33]: An app with that bundle ID needs to exist in order to create a provisioning profile for it
[18:10:33]: ================================================================
[18:10:36]: Available apps:
[LIST OF APPS]
[18:10:36]: Make sure to run fastlane match with the same user and team every time.
+------------------+-----------+
|         Lane Context         |
+------------------+-----------+
| DEFAULT_PLATFORM | ios       |
| PLATFORM_NAME    | ios       |
| LANE_NAME        | ios build |
+------------------+-----------+
[18:10:36]: Couldn't find bundle identifier '[SOME_BUNDLE_ID]' for the user '[SOME_ACCOUNT]'
+------+----------------------------+-------------+
|                fastlane summary                 |
+------+----------------------------+-------------+
| Step | Action                     | Time (in s) |
+------+----------------------------+-------------+
| 1    | Verifying fastlane version | 0           |
| 2    | default_platform           | 0           |
| 3    | app_store_connect_api_key  | 0           |
| 💥   | match                      | 6           |
+------+----------------------------+-------------+
[18:10:36]: fastlane finished with errors
[!] Couldn't find bundle identifier '[SOME_BUNDLE_ID]' for the user '[SOME_ACCOUNT]'

Environment

🚫 fastlane environment 🚫
Stack

Key
Value

OS
11.2

Ruby
2.6.5

Bundler?
false

Git
git version 2.24.3 (Apple Git-128)

Installation Source
~/.rbenv/versions/2.6.5/bin/fastlane

Host
macOS 11.2 (20D64)

Ruby Lib Dir
~/.rbenv/versions/2.6.5/lib

OpenSSL Version
OpenSSL 1.1.1d  10 Sep 2019

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
11.5

System Locale

Error

No Locale with UTF8 found 🚫

fastlane files:
No Fastfile found
No Appfile found
fastlane gems

Gem
Version
Update-Status

fastlane
2.176.0
✅ Up-To-Date

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

did_you_mean
1.3.0

slack-notifier
2.3.2

rouge
2.0.7

xcpretty
0.3.0

terminal-notifier
2.0.0

unicode-display_width
1.7.0

terminal-table
1.8.0

addressable
2.7.0

multipart-post
2.0.0

word_wrap
1.0.0

tty-cursor
0.7.1

tty-spinner
0.9.3

artifactory
3.0.15

colored
1.2

highline
1.7.10

commander-fastlane
4.4.6

faraday_middleware
1.0.0

gh_inspector
1.1.3

rubyzip
2.3.0

security
0.1.3

bundler
1.17.2

simctl
1.6.8

uber
0.1.0

declarative-option
0.1.0

representable
3.0.4

retriable
3.1.2

mini_mime
1.0.2

httpclient
2.8.3

google-api-client
0.38.0

nanaimo
0.3.0

colored2
3.1.2

claide
1.0.3

CFPropertyList
3.0.3

atomos
0.1.3

xcodeproj
1.19.0

plist
3.6.0

public_suffix
4.0.6

tty-screen
0.8.1

babosa
1.0.4

excon
0.79.0

unf_ext
<IP_ADDRESS>

unf
0.1.4

domain_name
0.5.20190701

http-cookie
1.0.3

ruby2_keywords
0.0.4

faraday-net_http
1.0.1

faraday
1.3.0

faraday-cookie_jar
0.0.7

fastimage
2.2.2

json
2.5.1

mini_magick
4.11.0

naturally
2.2.1

xcpretty-travis-formatter
1.0.1

dotenv
2.7.6

jwt
2.2.2

declarative
0.0.20

multi_json
1.15.0

signet
0.14.1

os
1.1.1

memoist
0.16.2

googleauth
0.15.1

rake
13.0.3

digest-crc
0.6.3

webrick
1.7.0

rexml
3.2.4

google-apis-core
0.2.1

google-apis-storage_v1
0.2.0

google-apis-iamcredentials_v1
0.1.0

google-cloud-errors
1.0.1

google-cloud-env
1.4.0

google-cloud-core
1.5.0

google-cloud-storage
1.30.0

emoji_regex
3.2.2

aws-eventstream
1.1.0

aws-sigv4
1.2.2

aws-partitions
1.429.0

jmespath
1.4.0

aws-sdk-core
3.112.0

aws-sdk-kms
1.42.0

aws-sdk-s3
1.88.1

forwardable
1.2.0

logger
1.3.0

date
2.0.0

stringio
0.0.2

zlib
1.0.0

ipaddr
1.2.2

openssl
2.1.2

ostruct
0.1.0

strscan
1.0.0

fileutils
1.1.0

etc
1.0.1

io-console
0.4.7

mini_portile2
2.4.0

nokogiri
1.10.4

psych
3.1.0

mutex_m
0.1.0

generated on: 2021-03-02

Hi @thinklinux
You will need an API Key for every account you have access to.


files loaded from css not included

I have a font-faces css file that includes some custom fonts. The font files are pulled into my output folder by Webpack but aren't being included in the service worker. Is this a deliberate decision or just something not gotten to yet?

Hmm.. Everything generated by webpack should be included. Do you use file-loader or some plugin to transfer files? If plugin, are you sure what offline-plugin is the last in webpack's plugins array?

Oooo, I figured it out. I'm using offline-plugin in Gatsby which has separate build steps for css and js so I had been just using the null-loader for css while building js which meant the css loaded files we're handled then. I switched to extracting the css (and just tossing it — not too expensive as it turns out) and now the font files are being added correctly.

Great and thanks for the info! 👍


enh(twig): keywords, filters, functions

Update Twig keyword, filter, functions list and fixed highlighting
inside tag
Update AUTHORS.TXT
Update CHANGES.md

Resolves #2422

The automatic check fails because real django code is detected as twig. Shall I update the default.txt files?

Well, first which keyword is it that's causing the conflict with Django?  u looks a little funny... perhaps it should be scored 0?
Also, please don't auto-lint... (esp. using entirely different settings than our own eslint).  Please return the file to it's original structure and lets stick with JUST the keyword changes... that includes not changing the tag/template stuff as well... if changes are needed there that should be done separately (or at the very least as a separate commit - so it can be properly reviewed and discussed).
Thanks.

I unterstand the Part with my linter. I‘ll do this. But the changes in the templating part were needed, because otherwise only the first keyword in a Tag would be highlighted. I’ll put these changes in selber are commits. I won’t do a rebase, I’ll open a new and clean PR Thanks

But the changes in the templating part were needed, because otherwise only the first keyword in a Tag would be highlighted.

Yeah, just that had nothing to do with the original issue you raised and just makes reviewing the PR harder... one PR would also be ok if the work was split into two commits making it easier to review them independently...
Although it's usually best to keep things like this separate since often they lead to discussions and then just slow down what should otherwise be a simple PR (adding a few keywords).  If the original PR had JUST included the keyword changes and nothing else it would have likely been merged in minutes.
With the tag thing I'm worried the intention was purposely to highlight only the first as a name... but I'd have to dig into that further... so it'd be much easier to get the keyword improvements moved and then review the other matter separately.


Failed to compile Ubuntu 20.10 (popOS)

Steps to reproduce:
git clone https://github.com/easylogic/editor
cd editor
npm install
npm run dev
with and without root user.

I checked it.
I'll fix it and let you know

I modifed this issue.
please clone it again.

Thank you!


Fix broken links in README.md

Links are case-sensitive and need to be lowercase.

We can skip ci since this only modifies the README file.

Thank you!