Synthetic EVs battery data generator service

The script is a great asset.
I am just thinking about a user at the LEGO table, interacting with the model (Luka and I will explain in our meeting). There must be some predictability to meet expected results following the control influence by the user.

This script is more useful for simulation purposes on the long run.
For the user to see something happening directly when he changes something, we need to adopt another approach.


Error when trying to install the package in -e

containers-sugar version:

Version: 1.2.0
docker-compose version 1.29.2, build unknown

Python version:

Python 3.9.16

Operating System:

No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 22.10
Release:        22.10
Codename:       kinetic
5.19.0-29-generic

Description
Error when creating the environment and installing the package in editable mode
What I Did
$ pip install -e containers-sugar
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
poetry 1.3.2 requires jsonschema<5.0.0,>=4.10.0, but you have jsonschema 3.2.0 which is incompatible.

not really sure about your workflow, but we remove some dependencies.
so, it would  help to have less dependencies' conflict


OWNERS update

What type of PR is this?
Feature
What this PR does / why we need it?
OWNERS update, remove @mrbarge

/lgtm
😭


EPIC: Public VM

Tracking tasks

[ ] Change Brillig to be memory-only (no registers)
[ ] Add MOV opcodes to program type conversions
[ ] Only use u32s for memory addresses
[ ] Support restricted bit sizes; just support 8,16,32, 64, 128, field
[ ] Support SET opcode – SET (size: 8, 16, 32, 64, 128, not field). The SET opcode is currently being called Const in Brillig.
[ ] Add CAST opcode that solely does type conversions
[ ] JUMPIF to treat the conditional predicate as an integer and just check for zeroness instead of treating it a sa boolean
[ ] Add CMOV instruction
[ ] Convert signed division to unsigned arithmetic
[ ] Compile all public functions in a contract into a single bytecode blob with a jump table

Add CAST opcode that solely does type conversions

This is just #3946 and https://github.com/noir-lang/noir/pull/3997, right?


mraa.c: make mraa_gpio_lookup() return proper pin index

Here goes the fix for #817, per our discussion there. I've checked and mraa_gpio_lookup() is actually not used anywhere in the mraa or upm code (including mraa's peripheralman.c).
This, in addition to the fact that Peripheral Manager-specific init code assigns mraa indexes to pinmap field, means to me that this change is going to be transparent to it and no changes needed there, as the values are effectively the same.
I'd leave it to those more familiar with ways Peripheral Manager-specific code uses this function, to decide if that's really the case, but to me it looks as if there's even no need to postpone merging this until the 2.0.

Thanks @vintummala. I've actually analyzed the init function before submitting the PR and it doesn't use the lookup function. Yes, it initializes pinmap fields with the mraa indexes, but namely due to that I believe that changing the lookup function return value doesn't affect anything.
I'll check those examples you mentioned to see if there's any additional context worth taking into account.
@propanu, thanks for approving the request. I'll double-check the examples and merge it if there's nothing affected over there.

So I've analyzed those examples and I still think this change won't break anything, namely due to the way GPIO pins are initialized in peripheralman.c.
Here's why I think so:

In peripheralman.c we initialize GPIOs like this:

//Updating GPIO bus structure
    for (; i < gpios_count; i++) {
        b->pins[i].name = gpios[i];
        //Retrieve this information from PIO once the API is available
        b->pins[i].capabilities = (mraa_pincapabilities_t){ 1, 1, 1, 1, 1, 1, 1, 1 };
        b->pins[i].gpio.pinmap = i;
}

i.e. pinmap field is set to be equal to the index in the pin array.

In the mraa_gpio_lookup() function, we returned the value of pinmap field before my change. After that change, we return the index (i) and they are numerically equal due to initialization described above.
AT examples use this function like this:

gpioIndex = mraa.getGpioLookup(getString(R.string.Button_Edison_Arduino));
<...>
button = new upm_grove.GroveButton(gpioIndex);

where
<string name="Button_Edison_Arduino">IO0</string>

i.e.

before the change that would be mraa.getGpioLookup("IO0") ==> return the pinmap value for the pin with the matching name;
after the change that would be mraa.getGpioLookup("IO0") ==> return the i value for the pin with the matching name. i starts counting from 0, same as the i used to initialize the pinmap field value - so they are numerically equal;

Let me now pause for a couple of days to see if anyone else has any comments or objections and then I'll merge this.

Merged with 2d210621ccc8377201e7301856d5102d254cd468


'list' object has no attribute 'get_body' in ServiceBus trigger

TL;DR
Change the cardinality to one in ServiceBus binding function.json.
Background
Recently, we upgraded the function host version to 3.0.15065 for v3. We also upgraded the Python worker from 1.1.7 to 1.1.8, and the change has been deployed to production on November 16, 2020.
In Python worker release 1.1.8, we fix the function.json "cardinality"="many" handling for ServiceBus triggers.
When setting "cardinality"="many", the Python handler signature should accept a list of messages instead of a single one.
from typing import List
import azure.functions as func

def main(msgs: List[func.ServiceBusMessage]):

Affects on Python Functions Applications
Some ServiceBus triggers may have "cardinality"="many" setting in their function.json file, and if the ServiceBus trigger only handles a single message, this can cause your app to not work as intended.
import azure.functions as func

def main(msg: func.ServiceBusMessage):

Since the msg parameter now has a proper list of messages, instead of a single one.
How To Mitigate
In ServiceBus triggers function.json, change the cardinality to one.
Alternatively, you can keep cardinality=many and change the ServiceBus trigger to process multiple messages in one go. Remember to change the name in function.json into msgs.
from
def main(msg: func.ServiceBusMessage):
    msg.get_body()

to
def main(msgs: List[func.ServiceBusMessage]):
    for msg in msgs:
        msg.get_body()

Sorry for the inconvenience, if you have more questions related to this issue, please let me know and comment below.

If you're facing similar issue in EventHub, please check this announcement.
https://github.com/Azure/azure-functions-python-worker/issues/699


Enable Persistence Flag

Add a flag to Firestore options to easily enable persistence:

https://firebase.google.com/docs/firestore/manage-data/enable-offline

Added with v3.1.0


Update to windows-rs 0.43

Another version came out...

Doesn't seem to be release to crates.io yet: https://crates.io/crates/windows-sys/versions.


How do I make this action work for Forked PR

I'm not sure whether this is channel to ask this question.
I'm planning to setup the alex with reviewdog on the PR from forked repository. I read about the Github limitations to access the reviewdog. Could you please help me to post alex comments on PR using reviewdog.
Error Log:
reviewdog: This is Pull-Request from forked repository.
GitHub token doesn't have write permission of Review API, so reviewdog will
report results via logging command [1] and create annotations similar to
github-pr-check reporter as a fallback.
[1]: https://help.github.com/en/actions/automating-your-workflow-with-github-actions/development-tools-for-github-actions#logging-commands

reviewdog can't comment to the PR from forked repository.
It is a limitation of GitHub Actions.
However, reviewdog creates annotations as a fallback.
Here is an example: https://github.com/reviewdog/reviewdog/pull/965/files

@shogo82148 Thanks..!
I see that https://github.com/reviewdog/reviewdog/pull/888 seems to support posting review comments. But, this is not landed to v0.11.0. Please correct me if I'm wrong.
How do we trigger this action against reviewdog's nightly build? Would it be apt to update the Dockerfile.


side-by-side images in the restructuredtext by sphinx-python

I want to have two images side by side.
Would you please give me an example about what the text should be like in the restructured text and in the conf.py?

Heya, was there not enough information in the documentation?
its basically just
.. subfigure:: A|B

   .. image:: imageA.png

   .. image:: imageB.png

@chrisjsewell
Thanks a lot.
I did as you suggested, the images are rendered as follows:

But I would like to have the following layout:

So what should I do on the subfigure?

If you want the figures side-by-side, remove the | character from the layout. The pipe is used as a sort of line break.
.. subfigure:: AB

   .. image:: imageA.png

   .. image:: imageB.png


Add quit menu item on macOS

Hi,
This fixes #652. I added the quit option in main menu, and current options are now in a separate Edit menu.
I also added productName property in package.json so Electron refers to it for the app name in the menus and everywhere using app.name (and no longer to the name property, which is in kebab case).
Thanks!

Thank you so much!
And thanks for the productName improvement 😁
I'll try to find time this weekend to test it and merge it in 👍

Thank you again @martinriviere for the improvement 🙇
Sorry it took so many months for me to get to it 😅 I was moving to a new house and just finally got back to VHA 🐌


RESEARCH: How to make a Chrome extension

Did Google's sample extension, currently looking through this: https://developer.chrome.com/extensions/overview

More complete developer's guide: https://developer.chrome.com/extensions/devguide


What happen with github.com/micro/cli/v2

I got error
<EMAIL_ADDRESS>invalid version: unknown revision v2.1.2
how to fix this?

@ivybridge-3c33 How did you solve it?

cli was a copy from github.com/urfave/cli/v2 and was not maintained quite well, and was dropped since.
you could replace it with github.com/urfave/cli/v2

cli was a copy from github.com/urfave/cli/v2 and was not maintained quite well, and was dropped since.
you could replace it with github.com/urfave/cli/v2

The way I'm handling it now is the same. It can only be done this way. Because the project hasn't been maintained for too long. Suddenly, there is a migration happening, and the code cannot be compiled.

go-micro/v4 is the latest stable version, better upgrade to it, or, you can just stick to old version without upgrade.


Semantic Temporal Decay rate

Hit @Schmluk .... Is there a parameter which will enable us to semantically control the temporal decay rate for the mesh generation ? like slowly decay the maps for specific class and rapid decay rates for some others.
I experimented with max_weight param inside the tsdf_integrator I had to drastically lower it down to 100 to get faster decay rate. is it possible to control this semantically ? I noticed that mesh of smaller objects with less pixel coverage in the input image are rapidly eaten up by the mesh of its surrounding semantic class ? is it possible to custom control this behavior ? like providing ground truth segmentation for specific semantic classes so it stays within the map for longer period and providing higher uncertainty to other segmentation classes ?
weight_dropoff_epsilon did not seem to do anything I did not understand how that is used ?

Hi @marcokat81
There is currently no parameter for that but it is easily addable. During the map update (in the ClassTsdfIntegartor) for every voxel also the corresponding class voxel is found. You can use that information to change the update rule or update weights.
Are your questions for the single or multi TSDF case? In the latter, it could be that small objects are mostly harder to detect and therefore their probabilities are decreased.
weight_dropoff_epsilon was introduced in voxblox, it reduces the weight for the part of the TSDF that is inside the object.
Hope this helps!

@Schmluk  where is the corresponding voxel found ? is it this
My question is regarding the Multi-TSDF case. Yes Some smaller objects like poles are harder to semantically detect but I still see some pixels show up   .... I decreased the min_allocation_size on the id_tracker so that they are always considered as well ...
may be we can have a higher prior for detections for certain class probabilities ? where are the class probabilities calculated ?

Yes that is it. Notice that class_voxel can be nullptr if no class voxel exists there.
The class probabilities are estimated by the network. They are fused in the ClassProjectiveIntegrator L152.
Thin objects are generally hard to reconstruct, this is an inherent limitation of TSDFs. Yes, the same logic as above can also be used in the single TSDF case.

@Schmluk  which network are you referring to ? are you talking about the segmentation model network ?

Closed due to inactivity.


IndexError: list index out of range in apply_transformation

How to reproduce:

Copy-paste some text with newline(s) in some text editor. Often case with coping from terminal.
ex:

ss

open ptpython
open circle bracket
>>> (
Insert from clipboard
As you can see cursor've moved to beginning of line

close circle bracket
fail

Traceback (most recent call last):
  File "/usr/local/bin/ptpython", line 11, in <module>
    sys.exit(run())
  File "/usr/local/lib/python2.7/dist-packages/ptpython/entry_points/run_ptpython.py", line 71, in run
    title='Python REPL (ptpython)')
  File "/usr/local/lib/python2.7/dist-packages/ptpython/repl.py", line 315, in embed
    cli.run()
  File "/usr/local/lib/python2.7/dist-packages/prompt_toolkit/interface.py", line 389, in run
    self.eventloop.run(self.input, self.create_eventloop_callbacks())
  File "/usr/local/lib/python2.7/dist-packages/prompt_toolkit/eventloop/posix.py", line 153, in run
    t()
  File "/usr/local/lib/python2.7/dist-packages/prompt_toolkit/interface.py", line 326, in redraw
    self._redraw()
  File "/usr/local/lib/python2.7/dist-packages/prompt_toolkit/interface.py", line 346, in _redraw
    self.renderer.render(self, self.layout, is_done=self.is_done)
  File "/usr/local/lib/python2.7/dist-packages/prompt_toolkit/renderer.py", line 436, in render
    extended_height=size.rows,
  File "/usr/local/lib/python2.7/dist-packages/prompt_toolkit/layout/containers.py", line 142, in write_to_screen
    sizes = self._divide_heigths(cli, write_position)
  File "/usr/local/lib/python2.7/dist-packages/prompt_toolkit/layout/containers.py", line 177, in _divide_heigths
    dimensions = [get_dimension_for_child(c, index) for index, c in enumerate(self.children)]
  File "/usr/local/lib/python2.7/dist-packages/prompt_toolkit/layout/containers.py", line 175, in get_dimension_for_child
    return c.preferred_height(cli, write_position.width, write_position.extended_height)
  File "/usr/local/lib/python2.7/dist-packages/prompt_toolkit/layout/containers.py", line 259, in preferred_height
    for s, c in zip(sizes, self.children)]
  File "/usr/local/lib/python2.7/dist-packages/prompt_toolkit/layout/containers.py", line 128, in preferred_height
    dimensions = [c.preferred_height(cli, width, max_available_height) for c in self.children]
  File "/usr/local/lib/python2.7/dist-packages/prompt_toolkit/layout/containers.py", line 395, in preferred_height
    return self.content.preferred_height(cli, width, max_available_height)
  File "/usr/local/lib/python2.7/dist-packages/prompt_toolkit/layout/containers.py", line 128, in preferred_height
    dimensions = [c.preferred_height(cli, width, max_available_height) for c in self.children]
  File "/usr/local/lib/python2.7/dist-packages/prompt_toolkit/layout/containers.py", line 1000, in preferred_height
    cli, width - total_margin_width, max_available_height, wrap_lines),
  File "/usr/local/lib/python2.7/dist-packages/prompt_toolkit/layout/controls.py", line 502, in preferred_height
    content = self.create_content(cli, width, None)
  File "/usr/local/lib/python2.7/dist-packages/prompt_toolkit/layout/controls.py", line 641, in create_content
    document.cursor_position_col),
  File "/usr/local/lib/python2.7/dist-packages/prompt_toolkit/layout/controls.py", line 623, in translate_rowcol
    return Point(y=row, x=get_processed_line(row).source_to_display(col))
  File "/usr/local/lib/python2.7/dist-packages/prompt_toolkit/layout/controls.py", line 583, in get_processed_line
    processed_line = transform(i, get_line(i))
  File "/usr/local/lib/python2.7/dist-packages/prompt_toolkit/layout/controls.py", line 559, in transform
    cli, document, lineno, source_to_display, tokens)
  File "/usr/local/lib/python2.7/dist-packages/prompt_toolkit/layout/processors.py", line 554, in apply_transformation
    cli, document, lineno, source_to_display, tokens)
  File "/usr/local/lib/python2.7/dist-packages/prompt_toolkit/layout/processors.py", line 255, in apply_transformation
    token, text = tokens[col]
IndexError: list index out of range

Hi @kiddick,
Thanks for reporting this issue! Unfortunately, I'm not able to reproduce it right now.
Could you tell me which version of ptpython and prompt_toolkit you are running? (Type pip freeze.)
Thanks!

ptpython==0.35
prompt-toolkit==1.0.5

I've updated ptpyhon to 0.36 and seems everything is ok. And I can't reproduce it too :)

That's good to hear!
So, I'm closing this issue. Don't hesitate to open again or create a new issue if you notice further problems.


Process name of Node.js is empty in jps

I tried to check all JVM process in the system with jps and jcmd, but I couldn't see Node.js process which was started with --jvm option at a glance as below:
$ jcmd
167394 sun.tools.jcmd.JCmd
167359

PID 167359 is Node.js process. Main class is empty.
jps and jcmd refer sun.java.command system property.
graal-nodejs should set it like a Java launcher in OpenJDK.

@YaSuenag, thank you for your contribution. I agree that it makes sense to use sun.java.command property to help various Java tools to identify GraalVM Node.js processes. The only thing that I am not sure about is the selection of graal-nodejs as the identifier. While we use graal-nodejs a lot internally it is neither an official nor the literal name of the launcher. If I understand correctly then the typical value of sun.java.command property is the main class of the application, right? If so, then the usage of com.oracle.truffle.trufflenode.GraalJSAccess would be more appropriate. What do you think?

@iamstolis Thank you for taking care this!
sun.java.command is used for main class of the application as you said, so GraalJSAccess might be more appropriate. But I want to set simple name to catch up Node.js process at a glance for following reasons:

com.oracle.truffle.trufflenode.GraalJSAccess is not human-friendly. Some users cannot know it is the Node.js process.
jps and jcmd uses VirtualMachineDescriptor::displayName to list JVM processes.  It says just "The display name is typically a human readable string that a tool might display to a user".

Please tell me if more suitable name is available.

I want to set simple name to catch up Node.js process at a glance

What about plain node then? It is the name of the launcher/executable. Considering that this name is visible to Java tools only there is also no risk that GraalVM's Node.js would be confused with the original Node.js.

Ok, I agree with you. I updated process name to node.


Use CSS scroll anchoring for most chat scroll pinning

Chat scroll pinning was broken for /search because that adds messages in quick succession and the React effect was only looking at the change in message author.
The general approach was also iffy because we were basically polling the scroll position on updates, but in practice scrolling works best when it is managed asynchronously by the browser.
This takes a different approach:

Use CSS scroll anchoring. This takes care of 90% of what we want with pinning the scroll position to the bottom: If you scroll away from the anchor, the scroll position doesn't change, the browser manages all of this for us. We also get better behavior when you resize the panel; the scroll position will stick to the bottom pretty intelligently.
Because browsers anchor the scroll position to the top until there's any scrolling, this uses an intersection observer to detect when the content becomes scrollable and force it to scroll. I actually like the behavior without that, but have implemented this for consistency with what we had.
When there's a new human message, scroll to the bottom. This means when you commit input in the chat box, we scroll to it.

I've made some subtle UX changes like animating some of the scrolls.
The scroll anchor adds a 5px gutter at the bottom of the content which is the "grippy" region for the scroll. We can avoid that extra space if we want, I took a look at it, it requires a couple of stacking contexts and I thought it wasn't worth it. But we can do it if we want.
Test plan

New Cody chat, ask it to enumerate 50 states in order of accession in a numbered list. The scroll should follow the content as it streams in.
Scroll up, chat to ask it to enumerate the 50 states and their state vegetables. The scroll should jump to the new question when you hit enter; then follow the content.
While content is streaming in, scroll away from it. As new content appears the scroll should not jump back to the bottom.
Do /search foo and the scroll position should keep up with the bottom of the content. (This comes in very fast and I think we should add a heuristic to maybe not do that. But it is better than the behavior today, which quietly drops the new content below the fold.)
Reload the webviews/restart the extension with a long transcript. The restored transcript should be scrolled to the bottom.

@dominiccooney I verified all the 5 steps and they work perfectly for me. I do have a followup question about step 4.
Right now, the search response  comes all at once like a blob of text and with the changes introduced it will be much better to scroll down automagically rather than having to do it manually by hands I was wondering if there might be a way to make the process a tab bit smoother? all I could think of was simulate some kind of streaming but that seems too absurd to simulate streaming just to make the UI look nicer. Alternatively once could break down the entire response into chunks and yield those chunks one at a time.  I would be curious if you have any other thoughts like some special javascript magic.
❤ Great work ❤

@arafatkatze,

Right now, the search response comes all at once like a blob of text and with the changes introduced it will be much better to scroll down automagically rather than having to do it manually by hands I was wondering if there might be a way to make the process a tab bit smoother?

Agree that the search results appear too fast.  There's a few opportunities to make this better; see #714.

it now scrolls back to the bottom whenever you switch back to the Cody pane from another pane.

@toolmantim good catch, I think that is a regression in this PR. Will look.

I've updated this so it doesn't scroll on switch away and back.
In the edge case that you switch away, then LLM response streams in, then switch back we keep the scroll position so you can read from there.
Chromium turns off scroll animations for prefers-reduced-motion. I'm assuming there's some way to set that in vscode.


[v3.4.beta2] Player don’t rotate along/with 3D rotating platform

Godot version
v3.4.beta2
System information
Windows 10, GLES3, Geforce 1070
Issue description
KinematicBody First Person player don’t rotate along/with the 3D platform. It worked fine in Godot v3.3.
Steps to reproduce
Open the provided 3.4 project, run it in Godot 3.4, the player should rotate with the platform, but it doesn’t and eventually fall.
It works fine on the provided Godot 3.3 project (running on Godot 3.3), with a slight noticeable sliding.
Minimal reproduction project
https://drive.google.com/file/d/1UcG5onMGb56CMPEbE3u4GakjYEdV3BEf/view?usp=sharing

Confirmed in bab9c02f472044415845ce284c55c961402c9c7c.


OpenAsync only sending first known cookie from CookieContainer

I believe this issue has existed in the past (#274 appears to be the same issue but was apparently fixed and closed.)
My scenario is this:

Fetch a login page (GET)
Submit the form with credentials (POST)
A bunch of cookies get set upon successful authentication. The CookieContainer associated with the MemoryCookieProvider sees all 8 of them.
I then attempt to re-use the same BrowsingContext via OpenAsync, to hit a URL requiring the various auth cookies.
The server gives me a 401, because only the first of the 8 cookies are showing up in the HTTP request.

I believe this is a bug caused by re-creating the CookieContainer for each RequestState object in HttpRequester. Basically, the cookie header is being retrieved from the BrowsingContext's current ICookieProvider, which ultimately references the underlying CookieContainer. The result of that is passed back into the new CookieContainer (via the cookie header) used on the WebRequest without accounting for the bug in CookieContainer (the whole ; vs , thing mentioned in #274).
Here's the code where the cookie header is being pulled from the existing context: https://github.com/AngleSharp/AngleSharp/blob/5139da94d7dfece420c02f000b3d5729168242af/src/AngleSharp/Network/Default/DocumentLoader.cs#L45-L52
Here's where it is then being used and triggering the bug in CookieContainer:
https://github.com/AngleSharp/AngleSharp/blob/devel/src/AngleSharp/Network/Default/HttpRequester.cs#L136
I have worked around the issue successfully by replacing ; with , in the RequestState constructor but it is perhaps not the greatest solution:
_cookies.SetCookies(_http.RequestUri, cookieHeader.Replace(';',','));
Hope this helps.

Yes this is a duplicate, see #368. Thanks for your detailed post though, I will cross-reference it in the mentioned issue.

@johnhargrove That was exactly the issue I was hitting. Thanks for the workaround, it works.


Suspected regression in kubevirt v0.53.0-rc.0 (live migration on upgrade)

What happened:
When trying to consume the newly released kubevirt v0.53.0-rc.0 in HCO, all upgrade tests were failing because the virt-launchers were not upgraded on kubevirt upgrade, despite having LiveMigrate on .spec.workloadUpdateStrategy.workloadUpdateMethods at KubeVirt CR.
As a result, post-upgrade there are VMIs with kubevirt.io/outdatedLauncherImage label that are still running.
The VM that is being used in the test is defined here:
https://github.com/kubevirt/hyperconverged-cluster-operator/blob/main/hack/vm.yaml
which is live-migratable.
What you expected to happen:
All live-migratable VMsvirt-launchers should be upgraded, and not VMIs withkubevirt.io/outdatedLauncherImage` label should be present on the cluster post-upgrade.
How to reproduce it (as minimally and precisely as possible):
Constantly failing on all upgrade lanes over multiple cloud providers in the CI of:
https://github.com/kubevirt/hyperconverged-cluster-operator/pull/1918
Additional context:
Add any other context about the problem here.
Environment:

KubeVirt version (use virtctl version): v0.53.0-rc.0
Kubernetes version (use kubectl version) :v1.23.3-2047+d464c70a480f1c-dirty
VM or VMI specifications: link
Cloud provider or hardware configuration: AWS, Azure and GCP
OS (e.g. from /etc/os-release): N/A
Kernel (e.g. uname -a): N/A
Install tools: N/A
Others: N/A

@davidvossel

Note:
Full KubeVirt CR post upgrade is available here:
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/kubevirt_hyperconverged-cluster-operator/1918/pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-upgrade-index-azure/1521232245312983040#1:build-log.txt%3A11105
in particular, the workloadUpdateStrategy configuration is present:
         "workloadUpdateStrategy": {
            "batchEvictionInterval": "1m0s",
            "batchEvictionSize": 10,
            "workloadUpdateMethods": [
                "LiveMigrate"
            ]
        }

Maybe some kind of "conflict" with the new MigrationPolicy mechanism?

We have a presubmit e2e test that validate this exact scenario works updating from the latest release to the latest code in main. It hasn't been failing. We're only guaranteeing updates from n-1 releases.
I tested this locally using your VM spec just to validate we aren't missing anything, and the vmi updated as expected when updating from v0.52.0 to v0.53.0.
What version of KubeVirt are you all updating from?

@davidvossel - maybe this is the issue: we couldn't make the v0.52.0 bump to pass the smoke test and it was never merged, so HCO is still using v0.51.0

We are testing upgrade from same HCO minor version (1.7.0), which currently contains kubevirt v0.51.0, and also testing upgrade from the previous HCO minor version (1.6.z), which contains kubevirt v0.49.0. Both of which are failing on all platforms.
David, is there something special in v0.52.0 that would allow a successful upgrade to v0.53.0 ?

It seems to me (at least it is the case for https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/kubevirt_hyperconverged-cluster-operator/1918/pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-upgrade-index-azure/1521232245312983040#1:build-log.txt%3A11105) that you have 3 different cpus(Skylake-Server, Cascadelake-Server, Icelake-Server). This will block the scheduling of the target pod for migration.

This is for this specific run in azure (although we haven't seen this issue before).
The same exact upgrade test also runs on AWS and GCP, and there all of the worker nodes have the same CPU:
AWS:
$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/kubevirt_hyperconverged-cluster-operator/1918/pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-upgrade-prev-index-aws/1521232245346537472/artifacts/hco-e2e-upgrade-prev-index-aws/gather-extra/artifacts/nodes.json | jq .items[].metadata.labels | grep "host-model-cpu.node.kubevirt.io"
  "host-model-cpu.node.kubevirt.io/EPYC": "true",
  "host-model-cpu.node.kubevirt.io/EPYC": "true",
  "host-model-cpu.node.kubevirt.io/EPYC": "true",

GCP:
$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/kubevirt_hyperconverged-cluster-operator/1918/pull-ci-kubevirt-hyperconverged-cluster-operator-main-okd-hco-e2e-upgrade-index-gcp/1521232245493338112/artifacts/hco-e2e-upgrade-index-gcp/gather-extra/artifacts/nodes.json | jq .items[].metadata.labels | grep "host-model-cpu.node.kubevirt.io"
  "host-model-cpu.node.kubevirt.io/Haswell-noTSX-IBRS": "true",
  "host-model-cpu.node.kubevirt.io/Haswell-noTSX-IBRS": "true",
  "host-model-cpu.node.kubevirt.io/Haswell-noTSX-IBRS": "true",

And in the virt-controller logs I'm seeing a lot (thousands) of logs of:
{"component":"virt-controller","level":"info","msg":"reenqueuing Migration vmsns/kubevirt-workload-update-td8hq","pos":"migration.go:198","reason":"vmi is inelgible for migration because another migration job is running","timestamp":"2022-05-02T22:12:42.011486Z"}

virt-controller logs

@davidvossel Will/did, you have time to have a look?
Otherwise, I would take this later today.

Fixing in https://github.com/kubevirt/kubevirt/pull/7691

Thanks, @xpivarc .
#7691 has merged. Waiting for a new KV release containing that fix to verify.

@orenc1 @nunnatsa  Btw. I suspect this was also the root cause why you couldn't bump to 0.52.

we are witnessing the very same issue with the newly released KubeVirt v0.53.0.
I see that #7701 is not included in https://github.com/kubevirt/kubevirt/commits/v0.53.0.
@davidvossel , any plans to release v0.53.1 soon that includes @xpivarc 's fix so we could consume in HCO?

@orenc1
The release should be available today https://github.com/kubevirt/kubevirt/releases/tag/v0.53.1

/close
@orenc1 Release is available https://github.com/kubevirt/kubevirt/releases/tag/v0.53.1
Please reopen if you find any issues.

The reported issue with the upgrade is resolved in v0.53.1, thanks.
However, we can't merge it yet, due to flakiness in some test cases in kubevirt test suite.
I'll open a new issue if needed.

The reported issue with the upgrade is resolved in v0.53.1, thanks. However, we can't merge it yet, due to flakiness in some test cases in kubevirt test suite. I'll open a new issue if needed.

Please do and feel free to ping me.


Fix sample workflow

Miscellaneous fixes for getting the examples/AshkenazimTrio/sample/trigger_files/sample.AshkenaziSon.trigger.json workflow to run successfully.
This was tested after commenting the tandem_genotypes sub-workflow, since I was only interested in variant calling and there was limited documentation regarding the inputs for this sub-workflow (particularly how to generate a score_matrix). I did not comment out the sub-workflow for this commit, and left it as it was.
I added a script rename_urls for renaming all the WDL Github URLs when developing and reverting the URLs to merge, and renamed "Getting Started.md" to "Readme.md" so it shows up on Github. Feel free to cherry-pick commits and avoid these changes if you want.
A few minor notes, I can raise an issue if you'd like:

The pipeline fails when most inputs are provided using a public URL like https://ftp-trace.ncbi.nlm.nih.gov/ReferenceSamples/giab/data/AshkenazimTrio/HG002_NA24385_son/PacBio_SequelII_CCS_11kb/HG002_GRCh38/HG002_GRCh38.haplotag.10x.bam  when size() is called to estimate required disk size like here. The documentation says providing a public URL + SAS token for data stored in a container should work, so it's not immediately clear that using a general public URL isn't an option.
pbsv_call fails when the provided reference has suffix of .fna instead of .fasta

Add threads to be ~{threads} -1 from samtools

Changes merged can close this issue.


Add digital circuit section

I found that a lot of the computer science curriculum does teach about digital circuits and I think knowledge about digital circuits can become extremely useful when working with computers and logic.
I'd like to contribute to this project by adding a digital circuit section to this project. This section will contain lessons about basic digital circuits like AND gate, NAND gate, OR gate, etc, and more complex digital circuit like flip-flops, adders, latches, etc. This section could later be developed to include more complex digital circuits like ALU, RAM, control unit, etc.
I believe this section can complement the boolean logic section very well. I believe this will be very useful for those who wants to work in embedded systems and IoT, which is a growing field. This can also come in handy for those who wants to work on chip and IC design, a blooming field.
I'd love to work on this. When it's complete, I'll submit a pull request for review

@shhossain can you assign this to me please?


Just a question: how to deal with class linkage

Hi guys,
I noticed huge FPS drops on DCS with DXVK. The same map on windows gives me 60 FPS, whereas under Linux / dxvk 9 FPS. With 100% GPU usage. The log is flooded with class linkage isn't supported, so my guess is that those shaders cause the FPS. Is there any way to get around that? Since dxvk doesn't support class linkage?
Software information
DCS World (latest release)
System information

GPU: NVIDIA AD104 [GeForce RTX 4070 SUPER]
Driver: nvidia v: 565.57.01
Wine version: Proton-Experimental
DXVK version:  2.4.1

Apitrace file(s)
Apitrace didn'work. No trace file was produced
Log files
DCS_dxgi.log
DCS_d3d11.log
steam-14891446377488842752.log

What is DCS?
I'm not aware of any game requiring this feature, and if this one did then it would most likely not work at all. Some games pass an empty class linkage thing around which explains the error messages, but probably unrelated to your issue.

Digital Combat Simulator.

Which map do you have issues with

Though the inferno  (Caucasus , Marianas, Sinai to be specific).
Settings:
["graphics"] = {
["AA"] = "OFF",
["BlurFlatShadows"] = 0,
["ColorGradingLUT"] = 0,
["DLSS_PerfQuality"] = 3,
["DOF"] = 0,
["LODmult"] = 1,
["LensEffects"] = 0,
["MSAA"] = 1,
["SSAO"] = 0,
["SSLR"] = 0,
["SSS"] = 0,
["Scaling"] = 0.66,
["ScreenshotExt"] = "jpg",
["Sharpening"] = 0.6,
["Upscaling"] = "OFF",
["anisotropy"] = 1,
["aspect"] = 2.3888888888889,
["box_mouse_cursor"] = false,
["canopyReflections"] = 1,
["chimneySmokeDensity"] = 0,
["civTraffic"] = "low",
["clouds"] = 0,
["clutterMaxDistance"] = 750,
["cockpitGI"] = 0,
["defaultFOV"] = 78,
["effects"] = 3,
["flatTerrainShadows"] = 1,
["forestDetailsFactor"] = 1,
["forestDistanceFactor"] = 0.5,
["fullScreen"] = false,
["heatBlr"] = 0,
["height"] = 1440,
["lights"] = 2,
["maxFPS"] = 180,
["messagesFontScale"] = 1,
["motionBlur"] = 0,
["motionBlurAmount"] = 1,
["multiMonitorSetup"] = "1camera",
["outputGamma"] = 2.2,
["preloadRadius"] = 100000,
["rainDroplets"] = 0,
["scaleGui"] = 1,
["sceneryDetailsFactor"] = 1,
["secondaryShadows"] = 0,
["shadowTree"] = false,
["shadows"] = 3,
["sync"] = false,
["terrainTextures"] = "min",
["textures"] = 1,
["useDeferredShading"] = 1,
["visibRange"] = "Medium",
["water"] = 1,
["width"] = 3440,

Unless you're using an FPS limiter or VSync, 100% GPU - utilization is the best case scenario.

Unless your frame generation takes up to 170ms


feat: Initial simplify memory-related circuits processing

Since queue states ([F; SW] part of witness) aren't actually used by RAM permutation circuit, we can remove this RAM-heavy data from witness for this type of circuits.
This PR is first part of this change, which aims to be backwards compatible with current proving subsystem. Another PR that breaks backwards compatibility will contain removal of this field from the RAM witness completely.

Additional cleanup, especially related to memory queues simulators, will also be in the next PR-s

Did you have a successful generation of proofs after that change? If yes, we can accept

But do you think if it's easier to change circuits code to update the type of witness, so it doesn't even bear those zeroed fields?

@shamatar

Did you have a successful generation of proofs after that change?

Yes

if it's easier to change circuits code to update the type of witness

Yes, but I would like to do this separately, perhaps as part of a general update. Since it would break backward compatibility. But yes, this is generally the next step: https://github.com/matter-labs/zksync-protocol/pull/48


finetune on 4096 context length

How to finetune Falcon-7B-Instruct on input or outputs of 4096 context length ?
how much VRAM i will need ?

Does it work to set --cutoff_len=4096?

Yes, I'm currently fine-tuning the 7B instruct model with 4096 and it's working fine (assuming there's no truncation elsewhere in the code)


Limit global search to 1 worker thread

Instead of spawning a new thread for every keystroke.

[ ] Added an entry to CHANGELOG.md if this change could be valuable to users

Codecov Report

Merging #2020 (4ae3efb) into master (450d695) will increase coverage by 0.05%.
The diff coverage is 0.00%.

 Learn more

I would prefer an approach for a new search to cancel the last search rather than waiting for the last search to finish.
similar to here https://github.com/lapce/lapce/blob/master/lapce-core/src/syntax/highlight.rs#L459

@dzhou121 I've updated implementation to be a lot simpler using worker IDs. Each thread is assigned an ID and regularly checks if the atomic u64 matches itself. If not, it cancels its own job. Only the latest job should survive and do the whole search.

Looks very good!


randomizer thinks you can go backwards in 6B a-01

but there's a one way platform at the bottom
example: {2npc9s_0_3925576202} v0.6.6

You can clip through the platform using the feather. Expert mode expects
you to know this!
On Mon, Dec 28, 2020 at 7:59 PM tckmn<EMAIL_ADDRESS>wrote:

but there's a one way platform at the bottom
example: {2npc9s_0_3925576202} v0.6.6
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/rhelmot/CelesteRandomizer/issues/118, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AATCB5ORT6SU6K7JO6XW6QLSXFAYLANCNFSM4VMXAJ6A
.

--
Audrey Dutcher
she/her/hers
http://rhelmot.io/

oh wow lol, i did not know that was possible!


Fixes REMOVE operations

NewImage doesn't exist on REMOVE operations, so we should only assign the variable if the item has been updated or created.

Eu queria ajudar para ter muito robux com minha lojinha


update outdated info

https://github.com/MicrosoftDocs/microsoft-365-docs/issues/1712

Dear @JohanFreelancer9,
kindly do the copy editor review for this PR.
Dear @mypil, for your information
Thank you

@kwekuako - This is another doc under @twernermsft, would you be the new author for this?
This PR has been copy edited and is ready for final review.
Thank you.
cc: @kenwith

Hi Joyce, yes, you can make me the author. I’ve merged the PR. Thanks.
From: Joyce Y<EMAIL_ADDRESS>Sent: Thursday, May 14, 2020 3:59 PM
To: MicrosoftDocs/microsoft-365-docs<EMAIL_ADDRESS>Cc: Kweku Ako-Adjei<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/microsoft-365-docs] update outdated info (#1918)
@kwekuakohttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkwekuako&data=02|01|kwekua%40microsoft.com|098e62ef49b346e4ecd808d7f85a586c|72f988bf86f141af91ab2d7cd011db47|0|0|637250939226056476&sdata=BT7AvmFL%2FXVSbqgw5p%2Fk8O80fp%2Fh5vK94LOyplj4VA0%3D&reserved=0 - This is another doc under @twernermsfthttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftwernermsft&data=02|01|kwekua%40microsoft.com|098e62ef49b346e4ecd808d7f85a586c|72f988bf86f141af91ab2d7cd011db47|0|0|637250939226066467&sdata=Z%2FvXA6x4EOp7Re5v7QzW7lGSLtfVzR5XPibD62GOtWw%3D&reserved=0, would you be the new author for this?
This PR has been copy edited and is ready for final review.
Thank you.
cc: @kenwithhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkenwith&data=02|01|kwekua%40microsoft.com|098e62ef49b346e4ecd808d7f85a586c|72f988bf86f141af91ab2d7cd011db47|0|0|637250939226066467&sdata=XtSWk%2Bcng2XIH7dEjIkhfD3Z8Fk3bSxWqRT02PSXZYk%3D&reserved=0
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fmicrosoft-365-docs%2Fpull%2F1918%23issuecomment-628929601&data=02|01|kwekua%40microsoft.com|098e62ef49b346e4ecd808d7f85a586c|72f988bf86f141af91ab2d7cd011db47|0|0|637250939226076459&sdata=O5LWBn1VG%2BTs%2BGmsQ3N2styJzhpI9YVlLKRgHLVZ4Ek%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAIPET2ZNZ2HEISPTGJ5JKETRRRZSBANCNFSM4NAR5ISA&data=02|01|kwekua%40microsoft.com|098e62ef49b346e4ecd808d7f85a586c|72f988bf86f141af91ab2d7cd011db47|0|0|637250939226076459&sdata=ck%2BY7ASGahkuvBnPzllZpghzBy6m5B5WIHvJ7HNkBY8%3D&reserved=0.


(IMPORT FAILED) ComfyUI InstantID (Native Support)

Hi,
I'm writing to ask a solution for import failed issue for comfyUI InstantID. I tried to install comfyUI InstantID by git clone and comfyUI manager. But it still does not work.
Here's my device and environment information for your convenience:

system: Ubuntu 22.04.4 LTS
comfyui version: ComfyUI: 219983d969 Manager: V2.34.1

Thank you so much in advance!

without an error message it's impossible to say. probably insightface failed to install

Thanks for your reply. Here's my screenshot

that unfortunately doesn't tell us much, we need the actual error message from the console

that unfortunately doesn't tell us much, we need the actual error message from the console

Thanks. May I know how to get error messages from the console.
If it's use "queue prompt", The above figure may be the all error message I have.
Because I cannot use any InstantID nodes (e.g. instant ID) as I cannot import InstantID .
Another examples: I tried to load from a created workflow are these:

additional information: I tried update comfyUI version before I use it

we the the actual backtrace from the terminal window

I see. Thanks!
Here's the error when I try to fix instant ID in comfyUI:
## ComfyUI-Manager: EXECUTE => ['/home/bingwang/miniconda3/envs/SD_render/bin/python', '-m', 'pip', 'install', 'insightface']  Collecting insightface    Using cached insightface-0.7.3.tar.gz (439 kB)    Installing build dependencies: started    Installing build dependencies: finished with status 'done'    Getting requirements to build wheel: started    Getting requirements to build wheel: finished with status 'done'    Installing backend dependencies: started    Installing backend dependencies: finished with status 'done'    Preparing metadata (pyproject.toml): started    Preparing metadata (pyproject.toml): finished with status 'done'   Collecting onnx (from insightface)    Using cached onnx-1.16.0-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (16 kB)         Collecting easydict (from insightface)    Using cached easydict-1.13-py3-none-any.whl.metadata (4.2 kB)  Collecting cython (from insightface)    Using cached Cython-3.0.10-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (3.2 kB)   Collecting prettytable (from insightface)    Using cached prettytable-3.10.0-py3-none-any.whl.metadata (30 kB)                            Using cached Cython-3.0.10-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (3.6 MB)  Using cached easydict-1.13-py3-none-any.whl (6.8 kB)  Using cached onnx-1.16.0-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (15.9 MB)  Using cached prettytable-3.10.0-py3-none-any.whl (28 kB)  Building wheels for collected packages: insightface    Building wheel for insightface (pyproject.toml): started    Building wheel for insightface (pyproject.toml): finished with status 'error' [!]   error: subprocess-exited-with-error [!]    [!]   × Building wheel for insightface (pyproject.toml) did not run successfully. [!]   │ exit code: 1 [!]   ╰─> [223 lines of output] [!]       WARNING: pandoc not enabled [!]       running bdist_wheel [!]       running build [!]       running build_py [!]       creating build [!]       creating build/lib.linux-x86_64-cpython-310 [!]       creating build/lib.linux-x86_64-cpython-310/insightface [!]       copying insightface/__init__.py -> build/lib.linux-x86_64-cpython-310/insightface [!]       creating build/lib.linux-x86_64-cpython-310/insightface/app [!]       copying insightface/app/face_analysis.py -> build/lib.linux-x86_64-cpython-310/insightface/app [!]       copying insightface/app/mask_renderer.py -> build/lib.linux-x86_64-cpython-310/insightface/app [!]       copying insightface/app/common.py -> build/lib.linux-x86_64-cpython-310/insightface/app [!]       copying insightface/app/__init__.py -> build/lib.linux-x86_64-cpython-310/insightface/app [!]       creating build/lib.linux-x86_64-cpython-310/insightface/model_zoo [!]       copying insightface/model_zoo/model_store.py -> build/lib.linux-x86_64-cpython-310/insightface/model_zoo [!]       copying insightface/model_zoo/model_zoo.py -> build/lib.linux-x86_64-cpython-310/insightface/model_zoo [!]       copying insightface/model_zoo/scrfd.py -> build/lib.linux-x86_64-cpython-310/insightface/model_zoo [!]       copying insightface/model_zoo/inswapper.py -> build/lib.linux-x86_64-cpython-310/insightface/model_zoo [!]       copying insightface/model_zoo/attribute.py -> build/lib.linux-x86_64-cpython-310/insightface/model_zoo [!]       copying insightface/model_zoo/arcface_onnx.py -> build/lib.linux-x86_64-cpython-310/insightface/model_zoo [!]       copying insightface/model_zoo/__init__.py -> build/lib.linux-x86_64-cpython-310/insightface/model_zoo  Failed to build insightface [!]       copying insightface/model_zoo/landmark.py -> build/lib.linux-x86_64-cpython-310/insightface/model_zoo [!]       copying insightface/model_zoo/retinaface.py -> build/lib.linux-x86_64-cpython-310/insightface/model_zoo [!]       creating build/lib.linux-x86_64-cpython-310/insightface/data [!]       copying insightface/data/rec_builder.py -> build/lib.linux-x86_64-cpython-310/insightface/data [!]       copying insightface/data/pickle_object.py -> build/lib.linux-x86_64-cpython-310/insightface/data [!]       copying insightface/data/image.py -> build/lib.linux-x86_64-cpython-310/insightface/data [!]       copying insightface/data/__init__.py -> build/lib.linux-x86_64-cpython-310/insightface/data [!]       creating build/lib.linux-x86_64-cpython-310/insightface/utils [!]       copying insightface/utils/download.py -> build/lib.linux-x86_64-cpython-310/insightface/utils [!]       copying insightface/utils/face_align.py -> build/lib.linux-x86_64-cpython-310/insightface/utils [!]       copying insightface/utils/filesystem.py -> build/lib.linux-x86_64-cpython-310/insightface/utils [!]       copying insightface/utils/constant.py -> build/lib.linux-x86_64-cpython-310/insightface/utils [!]       copying insightface/utils/storage.py -> build/lib.linux-x86_64-cpython-310/insightface/utils [!]       copying insightface/utils/__init__.py -> build/lib.linux-x86_64-cpython-310/insightface/utils [!]       copying insightface/utils/transform.py -> build/lib.linux-x86_64-cpython-310/insightface/utils [!]       creating build/lib.linux-x86_64-cpython-310/insightface/thirdparty [!]       copying insightface/thirdparty/__init__.py -> build/lib.linux-x86_64-cpython-310/insightface/thirdparty [!]       creating build/lib.linux-x86_64-cpython-310/insightface/commands [!]       copying insightface/commands/rec_add_mask_param.py -> build/lib.linux-x86_64-cpython-310/insightface/commands [!]       copying insightface/commands/insightface_cli.py -> build/lib.linux-x86_64-cpython-310/insightface/commands [!]       copying insightface/commands/__init__.py -> build/lib.linux-x86_64-cpython-310/insightface/commands [!]       copying insightface/commands/model_download.py -> build/lib.linux-x86_64-cpython-310/insightface/commands [!]       creating build/lib.linux-x86_64-cpython-310/insightface/thirdparty/face3d [!]       copying insightface/thirdparty/face3d/__init__.py -> build/lib.linux-x86_64-cpython-310/insightface/thirdparty/face3d [!]       creating build/lib.linux-x86_64-cpython-310/insightface/thirdparty/face3d/mesh_numpy [!]       copying insightface/thirdparty/face3d/mesh_numpy/render.py -> build/lib.linux-x86_64-cpython-310/insightface/thirdparty/face3d/mesh_numpy [!]       copying insightface/thirdparty/face3d/mesh_numpy/light.py -> build/lib.linux-x86_64-cpython-310/insightface/thirdparty/face3d/mesh_numpy [!]       copying insightface/thirdparty/face3d/mesh_numpy/io.py -> build/lib.linux-x86_64-cpython-310/insightface/thirdparty/face3d/mesh_numpy [!]       copying insightface/thirdparty/face3d/mesh_numpy/vis.py -> build/lib.linux-x86_64-cpython-310/insightface/thirdparty/face3d/mesh_numpy [!]       copying insightface/thirdparty/face3d/mesh_numpy/__init__.py -> build/lib.linux-x86_64-cpython-310/insightface/thirdparty/face3d/mesh_numpy [!]       copying insightface/thirdparty/face3d/mesh_numpy/transform.py -> build/lib.linux-x86_64-cpython-310/insightface/thirdparty/face3d/mesh_numpy [!]       creating build/lib.linux-x86_64-cpython-310/insightface/thirdparty/face3d/morphable_model [!]       copying insightface/thirdparty/face3d/morphable_model/morphabel_model.py -> build/lib.linux-x86_64-cpython-310/insightface/thirdparty/face3d/morphable_model [!]       copying insightface/thirdparty/face3d/morphable_model/load.py -> build/lib.linux-x86_64-cpython-310/insightface/thirdparty/face3d/morphable_model [!]       copying insightface/thirdparty/face3d/morphable_model/fit.py -> build/lib.linux-x86_64-cpython-310/insightface/thirdparty/face3d/morphable_model [!]       copying insightface/thirdparty/face3d/morphable_model/__init__.py -> build/lib.linux-x86_64-cpython-310/insightface/thirdparty/face3d/morphable_model [!]       creating build/lib.linux-x86_64-cpython-310/insightface/thirdparty/face3d/mesh [!]       copying insightface/thirdparty/face3d/mesh/render.py -> build/lib.linux-x86_64-cpython-310/insightface/thirdparty/face3d/mesh [!]       copying insightface/thirdparty/face3d/mesh/light.py -> build/lib.linux-x86_64-cpython-310/insightface/thirdparty/face3d/mesh [!]       copying insightface/thirdparty/face3d/mesh/io.py -> build/lib.linux-x86_64-cpython-310/insightface/thirdparty/face3d/mesh [!]       copying insightface/thirdparty/face3d/mesh/vis.py -> build/lib.linux-x86_64-cpython-310/insightface/thirdparty/face3d/mesh [!]       copying insightface/thirdparty/face3d/mesh/__init__.py -> build/lib.linux-x86_64-cpython-310/insightface/thirdparty/face3d/mesh [!]       copying insightface/thirdparty/face3d/mesh/transform.py -> build/lib.linux-x86_64-cpython-310/insightface/thirdparty/face3d/mesh [!]       running egg_info [!]       writing insightface.egg-info/PKG-INFO [!]       writing dependency_links to insightface.egg-info/dependency_links.txt [!]       writing entry points to insightface.egg-info/entry_points.txt [!]       writing requirements to insightface.egg-info/requires.txt [!]       writing top-level names to insightface.egg-info/top_level.txt [!]       reading manifest file 'insightface.egg-info/SOURCES.txt' [!]       writing manifest file 'insightface.egg-info/SOURCES.txt' [!]       /tmp/pip-build-env-mi53k9zi/overlay/lib/python3.10/site-packages/setuptools/command/build_py.py:207: _Warning: Package 'insightface.data.images' is absent from the packagesconfiguration. [!]       !! [!]        [!]               ******************************************************************************** [!]               ############################ [!]               # Package would be ignored # [!]               ############################ [!]               Python recognizes 'insightface.data.images' as an importable package[^1], [!]               but it is absent from setuptools'packagesconfiguration. [!]        [!]               This leads to an ambiguous overall configuration. If you want to distribute this [!]               package, please make sure that 'insightface.data.images' is explicitly added [!]               to thepackagesconfiguration field. [!]        [!]               Alternatively, you can also rely on setuptools' discovery methods [!]               (for example by usingfind_namespace_packages(...)/find_namespace:[!]               instead offind_packages(...)/find:). [!]        [!]               You can read more about "package discovery" on setuptools documentation page: [!]        [!]               - https://setuptools.pypa.io/en/latest/userguide/package_discovery.html [!]        [!]               If you don't want 'insightface.data.images' to be distributed and are [!]               already explicitly excluding 'insightface.data.images' via [!]               find_namespace_packages(...)/find_namespaceorfind_packages(...)/find, [!]               you can try to use exclude_package_data, or include-package-data=Falsein [!]               combination with a more fine grainedpackage-dataconfiguration. [!]        [!]               You can read more about "package data files" on setuptools documentation page: [!]        [!]               - https://setuptools.pypa.io/en/latest/userguide/datafiles.html [!]        [!]        [!]               [^1]: For Python, any directory (with suitable naming) can be imported, [!]                     even if it does not contain any.pyfiles. [!]                     On the other hand, currently there is no concept of package data [!]                     directory, all directories are treated like packages. [!]               ******************************************************************************** [!]        [!]       !! [!]         check.warn(importable) [!]       /tmp/pip-build-env-mi53k9zi/overlay/lib/python3.10/site-packages/setuptools/command/build_py.py:207: _Warning: Package 'insightface.data.objects' is absent from thepackagesconfiguration. [!]       !! [!]        [!]               ******************************************************************************** [!]               ############################ [!]               # Package would be ignored # [!]               ############################ [!]               Python recognizes 'insightface.data.objects' as an importable package[^1], [!]               but it is absent from setuptools'packagesconfiguration. [!]        [!]               This leads to an ambiguous overall configuration. If you want to distribute this [!]               package, please make sure that 'insightface.data.objects' is explicitly added [!]               to thepackagesconfiguration field. [!]        [!]               Alternatively, you can also rely on setuptools' discovery methods [!]               (for example by usingfind_namespace_packages(...)/find_namespace:[!]               instead offind_packages(...)/find:). [!]        [!]               You can read more about "package discovery" on setuptools documentation page: [!]        [!]               - https://setuptools.pypa.io/en/latest/userguide/package_discovery.html [!]        [!]               If you don't want 'insightface.data.objects' to be distributed and are [!]               already explicitly excluding 'insightface.data.objects' via [!]               find_namespace_packages(...)/find_namespaceorfind_packages(...)/find, [!]               you can try to use exclude_package_data, or include-package-data=Falsein [!]               combination with a more fine grainedpackage-dataconfiguration. [!]        [!]               You can read more about "package data files" on setuptools documentation page: [!]        [!]               - https://setuptools.pypa.io/en/latest/userguide/datafiles.html [!]        [!]        [!]               [^1]: For Python, any directory (with suitable naming) can be imported, [!]                     even if it does not contain any.pyfiles. [!]                     On the other hand, currently there is no concept of package data [!]                     directory, all directories are treated like packages. [!]               ******************************************************************************** [!]        [!]       !! [!]         check.warn(importable) [!]       /tmp/pip-build-env-mi53k9zi/overlay/lib/python3.10/site-packages/setuptools/command/build_py.py:207: _Warning: Package 'insightface.thirdparty.face3d.mesh.cython' is absent from thepackagesconfiguration. [!]       !! [!]        [!]               ******************************************************************************** [!]               ############################ [!]               # Package would be ignored # [!]               ############################ [!]               Python recognizes 'insightface.thirdparty.face3d.mesh.cython' as an importable package[^1], [!]               but it is absent from setuptools'packagesconfiguration. [!]        [!]               This leads to an ambiguous overall configuration. If you want to distribute this [!]               package, please make sure that 'insightface.thirdparty.face3d.mesh.cython' is explicitly added [!]               to thepackagesconfiguration field. [!]        [!]               Alternatively, you can also rely on setuptools' discovery methods [!]               (for example by usingfind_namespace_packages(...)/find_namespace:[!]               instead offind_packages(...)/find:). [!]        [!]               You can read more about "package discovery" on setuptools documentation page: [!]        [!]               - https://setuptools.pypa.io/en/latest/userguide/package_discovery.html [!]        [!]               If you don't want 'insightface.thirdparty.face3d.mesh.cython' to be distributed and are [!]               already explicitly excluding 'insightface.thirdparty.face3d.mesh.cython' via [!]               find_namespace_packages(...)/find_namespaceorfind_packages(...)/find, [!]               you can try to use exclude_package_data, or include-package-data=Falsein [!]               combination with a more fine grainedpackage-dataconfiguration. [!]        [!]               You can read more about "package data files" on setuptools documentation page: [!]        [!]               - https://setuptools.pypa.io/en/latest/userguide/datafiles.html [!]        [!]        [!]               [^1]: For Python, any directory (with suitable naming) can be imported, [!]                     even if it does not contain any.py` files.
[!]                     On the other hand, currently there is no concept of package data
[!]                     directory, all directories are treated like packages.
[!]               ********************************************************************************
[!]
[!]       !!
[!]         check.warn(importable)
[!]       creating build/lib.linux-x86_64-cpython-310/insightface/data/images
[!]       copying insightface/data/images/Tom_Hanks_54745.png -> build/lib.linux-x86_64-cpython-310/insightface/data/images
[!]       copying insightface/data/images/mask_black.jpg -> build/lib.linux-x86_64-cpython-310/insightface/data/images
[!]       copying insightface/data/images/mask_blue.jpg -> build/lib.linux-x86_64-cpython-310/insightface/data/images
[!]       copying insightface/data/images/mask_green.jpg -> build/lib.linux-x86_64-cpython-310/insightface/data/images
[!]       copying insightface/data/images/mask_white.jpg -> build/lib.linux-x86_64-cpython-310/insightface/data/images
[!]       copying insightface/data/images/t1.jpg -> build/lib.linux-x86_64-cpython-310/insightface/data/images
[!]       creating build/lib.linux-x86_64-cpython-310/insightface/data/objects
[!]       copying insightface/data/objects/meanshape_68.pkl -> build/lib.linux-x86_64-cpython-310/insightface/data/objects
[!]       creating build/lib.linux-x86_64-cpython-310/insightface/thirdparty/face3d/mesh/cython
[!]       copying insightface/thirdparty/face3d/mesh/cython/mesh_core.cpp -> build/lib.linux-x86_64-cpython-310/insightface/thirdparty/face3d/mesh/cython
[!]       copying insightface/thirdparty/face3d/mesh/cython/mesh_core.h -> build/lib.linux-x86_64-cpython-310/insightface/thirdparty/face3d/mesh/cython
[!]       copying insightface/thirdparty/face3d/mesh/cython/mesh_core_cython.c -> build/lib.linux-x86_64-cpython-310/insightface/thirdparty/face3d/mesh/cython
[!]       copying insightface/thirdparty/face3d/mesh/cython/mesh_core_cython.cpp -> build/lib.linux-x86_64-cpython-310/insightface/thirdparty/face3d/mesh/cython
[!]       copying insightface/thirdparty/face3d/mesh/cython/mesh_core_cython.pyx -> build/lib.linux-x86_64-cpython-310/insightface/thirdparty/face3d/mesh/cython
[!]       copying insightface/thirdparty/face3d/mesh/cython/setup.py -> build/lib.linux-x86_64-cpython-310/insightface/thirdparty/face3d/mesh/cython
[!]       running build_ext
[!]       building 'insightface.thirdparty.face3d.mesh.cython.mesh_core_cython' extension
[!]       creating build/temp.linux-x86_64-cpython-310
[!]       creating build/temp.linux-x86_64-cpython-310/insightface
[!]       creating build/temp.linux-x86_64-cpython-310/insightface/thirdparty
[!]       creating build/temp.linux-x86_64-cpython-310/insightface/thirdparty/face3d
[!]       creating build/temp.linux-x86_64-cpython-310/insightface/thirdparty/face3d/mesh
[!]       creating build/temp.linux-x86_64-cpython-310/insightface/thirdparty/face3d/mesh/cython
[!]       gcc -pthread -B /home/bingwang/miniconda3/envs/SD_render/compiler_compat -Wno-unused-result -Wsign-compare -DNDEBUG -fwrapv -O2 -Wall -fPIC -O2 -isystem /home/bingwang/miniconda3/envs/SD_render/include -fPIC -O2 -isystem /home/bingwang/miniconda3/envs/SD_render/include -fPIC -Iinsightface/thirdparty/face3d/mesh/cython -I/tmp/pip-build-env-mi53k9zi/overlay/lib/python3.10/site-packages/numpy/core/include -I/home/bingwang/miniconda3/envs/SD_render/include/python3.10 -c insightface/thirdparty/face3d/mesh/cython/mesh_core.cpp -o build/temp.linux-x86_64-cpython-310/insightface/thirdparty/face3d/mesh/cython/mesh_core.o
[!]       gcc: fatal error: cannot execute ‘cc1plus’: execvp: No such file or directory
[!]       compilation terminated.
[!]       error: command '/usr/bin/gcc' failed with exit code 1
[!]       [end of output]
[!]
[!]   note: This error originates from a subprocess, and is likely not a problem with pip.
[!]   ERROR: Failed building wheel for insightface
[!] ERROR: Could not build wheels for insightface, which is required to install pyproject.toml-based projects
install script failed: https://github.com/cubiq/ComfyUI_InstantID
ComfyUI-Manager: EXECUTE => ['/home/bingwang/miniconda3/envs/SD_render/bin/python', '-m', 'pip', 'install', 'onnxruntime']
ComfyUI-Manager: EXECUTE => ['/home/bingwang/miniconda3/envs/SD_render/bin/python', '-m', 'pip', 'install', 'onnxruntime-gpu']
     Attempt to fixing '['https://github.com/cubiq/ComfyUI_InstantID']' is done.

After restarting ComfyUI, please refresh the browser.
FETCH DATA from: /home/bingwang/Documents/GitHub/ComfyUI/custom_nodes/ComfyUI-Manager/.cache/1514988643_custom-node-list.json [DONE]
FETCH DATA from: /home/bingwang/Documents/GitHub/ComfyUI/custom_nodes/ComfyUI-Manager/.cache/746607195_github-stats.json [DONE]
FETCH DATA from: /home/bingwang/Documents/GitHub/ComfyUI/custom_nodes/ComfyUI-Manager/.cache/1742899825_extension-node-map.json [DONE]`

your pc was not able to build the dependency, it's hard to say what is missing, maybe the build-essentials since you are on ubuntu

Thank you for your reply. That's a pity.
Shall I close this issue or keep open?

you can install the missing dependencies with apt install build-essential

I tried sudo apt install build-essential. But seems it's already a newest version.
build-essential is already the newest version (12.9ubuntu3). The following packages were automatically installed and are no longer required:   libnvidia-container-tools libnvidia-container1 Use 'sudo apt autoremove' to remove them. 0 to upgrade, 0 to newly install, 0 to remove and 47 not to upgrade.

same problem on Windows

same problem on Windows

Can you also provide the details?

Same problem here on windows.
Error says
Traceback (most recent call last):
File "C:\ComfyUI_windows_portable\ComfyUI\nodes.py", line 1879, in load_custom_node
module_spec.loader.exec_module(module)
File "", line 940, in exec_module
File "", line 241, in call_with_frames_removed
File "C:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI_InstantID_init.py", line 1, in
from .InstantID import NODE_CLASS_MAPPINGS, NODE_DISPLAY_NAME_MAPPINGS
File "C:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI_InstantID\InstantID.py", line 13, in
from insightface.app import FaceAnalysis
ModuleNotFoundError: No module named 'insightface'
Cannot import C:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI_InstantID module for custom nodes: No module named 'insightface'

Add the same problem on windows, for anyone else seeing this. CMD error was that insightface was missing.
Used this instruction from reddit and it fixed the problem :
From the ComfyUI root folder (where you have "webui-user.bat" file) check the version of Python aka run CMD and type "python_embeded\python.exe -V"
Depending on Python version (3.10 or 3.11) download prebuilt Insightface package to ComfyUI root folder:
Python 3.10: https://github.com/Gourieff/Assets/raw/main/Insightface/insightface-0.7.3-cp310-cp310-win_amd64.whl
Python 3.11: https://github.com/Gourieff/Assets/raw/main/Insightface/insightface-0.7.3-cp311-cp311-win_amd64.whl
Install latest pip version: "python_embeded\python.exe -m pip install -U pip"
Install Insightface:
Python 3.10: "python_embeded\python.exe -m pip install insightface-0.7.3-cp310-cp310-win_amd64.whl"
Python 3.11: "python_embeded\python.exe -m pip install insightface-0.7.3-cp311-cp311-win_amd64.whl

Had the same problem on windows, for anyone else seeing this. CMD error was that insightface was missing.
Used this instruction from reddit and it fixed the problem :
From the ComfyUI root folder (where you have "webui-user.bat" file) check the version of Python aka run CMD and type "python_embeded\python.exe -V"
Depending on Python version (3.10 or 3.11) download prebuilt Insightface package to ComfyUI root folder: Python 3.10: https://github.com/Gourieff/Assets/raw/main/Insightface/insightface-0.7.3-cp310-cp310-win_amd64.whl Python 3.11: https://github.com/Gourieff/Assets/raw/main/Insightface/insightface-0.7.3-cp311-cp311-win_amd64.whl
Install latest pip version: "python_embeded\python.exe -m pip install -U pip"
Install Insightface: Python 3.10: "python_embeded\python.exe -m pip install insightface-0.7.3-cp310-cp310-win_amd64.whl" Python 3.11: "python_embeded\python.exe -m pip install insightface-0.7.3-cp311-cp311-win_amd64.whl

Youre a legend. This fixed my issue.

在 Windows 上也遇到了同样的问题，其他人也看到了这个问题。CMD 错误是缺少 insightface。
使用 reddit 上的这个说明并解决了该问题：
从 ComfyUI 根文件夹（其中有“webui-user.bat”文件）检查 Python 的版本，即运行 CMD 并输入“python_embeded\python.exe -V”
根据 Python 版本（3.10 或 3.11）将预构建的 Insightface 包下载到 ComfyUI 根文件夹： Python 3.10： https: //github.com/Gourieff/Assets/raw/main/Insightface/insightface-0.7.3-cp310-cp310-win_amd64.whl Python 3.11：https: //github.com/Gourieff/Assets/raw/main/Insightface/insightface-0.7.3-cp311-cp311-win_amd64.whl
安装最新的 pip 版本：“python_embeded\python.exe -m pip install -U pip”
安装 Insightface： Python 3.10：“python_embeded\python.exe -m pip install insightface-0.7.3-cp310-cp310-win_amd64.whl” Python 3.11：“python_embeded\python.exe -m pip install insightface-0.7.3-cp311-cp311-win_amd64.whl

wow,niu b,bro.fixed my issue

Had the same problem on windows, for anyone else seeing this. CMD error was that insightface was missing.
Used this instruction from reddit and it fixed the problem :
From the ComfyUI root folder (where you have "webui-user.bat" file) check the version of Python aka run CMD and type "python_embeded\python.exe -V"
Depending on Python version (3.10 or 3.11) download prebuilt Insightface package to ComfyUI root folder: Python 3.10: https://github.com/Gourieff/Assets/raw/main/Insightface/insightface-0.7.3-cp310-cp310-win_amd64.whl Python 3.11: https://github.com/Gourieff/Assets/raw/main/Insightface/insightface-0.7.3-cp311-cp311-win_amd64.whl
Install latest pip version: "python_embeded\python.exe -m pip install -U pip"
Install Insightface: Python 3.10: "python_embeded\python.exe -m pip install insightface-0.7.3-cp310-cp310-win_amd64.whl" Python 3.11: "python_embeded\python.exe -m pip install insightface-0.7.3-cp311-cp311-win_amd64.whl

After this step I couldn't even start ComfyUI. The cmd window just gives me this:
Traceback (most recent call last):
File "D:\Work\AI\ComfyUI_windows_portable_nvidia\ComfyUI_windows_portable\ComfyUI\main.py", line 261, in
loop.run_until_complete(run(server, address=args.listen, port=args.port, verbose=not args.dont_print_server, call_on_start=call_on_start))
File "asyncio\base_events.py", line 654, in run_until_complete
File "D:\Work\AI\ComfyUI_windows_portable_nvidia\ComfyUI_windows_portable\ComfyUI\main.py", line 166, in run
await asyncio.gather(server.start_multi_address(addresses, call_on_start), server.publish_loop())
File "D:\Work\AI\ComfyUI_windows_portable_nvidia\ComfyUI_windows_portable\ComfyUI\server.py", line 838, in start_multi_address
await site.start()
File "D:\Work\AI\ComfyUI_windows_portable_nvidia\ComfyUI_windows_portable\python_embeded\Lib\site-packages\aiohttp\web_runner.py", line 119, in start
self._server = await loop.create_server(
^^^^^^^^^^^^^^^^^^^^^^^^^
File "asyncio\base_events.py", line 1536, in create_server
OSError: [Errno 10048] error while attempting to bind on address ('<IP_ADDRESS>', 8188): only one usage of each socket address (protocol/network address/port) is normally permitted


"500 Internal Server Error" when attempting to export a key that doesn't exist

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Thank you for opening an issue. Please note that we try to keep the Terraform issue tracker reserved for bug reports and feature requests. For general usage questions, please see: https://www.terraform.io/community.html.
PingOne Terraform provider Version

v0.9.0
Terraform Version

N/a
Affected Resource(s)

pingone_certificate_signing_request
pingone_certificate_export

Terraform Configuration Files
# Copy-paste your PingOne related Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. For
# security, you can also encrypt the files using our GPG public key.

# Remember to replace any account/customer sensitive information in the configuration before submitting the issue

data "pingone_certificate_signing_request" "foo" {
  environment_id = var.environment_id

  key_id = var.key_id_does_not_exist // a key ID that doesn't exist in the environment
}

data "pingone_certificate_export" "foo" {
  environment_id = var.environment_id

  key_id = var.key_id_does_not_exist // a key ID that doesn't exist in the environment
}

Debug Output

=== CONT  TestAccCertificateSigningRequestDataSource_NotFound
    data_source_certificate_signing_request_test.go:49: Step 1/1, expected an error with pattern, no match on: Error running pre-apply refresh: exit status 1

        Error: Error when calling `ExportCSR`: 500 Internal Server Error

          with data.pingone_certificate_signing_request.vribeisjoy,
          on terraform_plugin_test.tf line 7, in data "pingone_certificate_signing_request" "vribeisjoy":
           7: data "pingone_certificate_signing_request" "vribeisjoy" {

--- FAIL: TestAccCertificateSigningRequestDataSource_NotFound (1.82s)

=== CONT  TestAccCertificateExportDataSource_NotFound
    data_source_certificate_export_test.go:49: Step 1/1, expected an error with pattern, no match on: Error running pre-apply refresh: exit status 1

        Error: Error when calling `GetKey`: 500 Internal Server Error

          with data.pingone_certificate_export.sdlmaibroz,
          on terraform_plugin_test.tf line 7, in data "pingone_certificate_export" "sdlmaibroz":
           7: data "pingone_certificate_export" "sdlmaibroz" {

--- FAIL: TestAccCertificateExportDataSource_NotFound (1.67s)

Panic Output

Expected Behavior

Passed tests
Resource should output a "Not found" message

Actual Behavior

Failed tests
Message is not expected

Steps to Reproduce

terraform apply

Important Factoids

References

Raised to platform engineering


Baremetal installation script

Describe the bug
I have done the baremetal installation script on ubuntu behind haproxy reverse proxy. Things work fine in the most part but I can't figure out some things.
Encountered issues
In most docs there seems to be a marketplace in the top left for integrations and apps which I don't see
In the docts it's stated that you can also install apps and integrations manually by adding them to the apps folder on the machine but for the life of me I can't find where these apps should go
Setup

Ubuntu 23
OCIS 6.3.0
HAPROXY reverse proxy with CA signed certs
Hairpin NAT for the openid auth

OCIS_URL=https://<MY DOMAIN>
OCIS_OIDC_ISSUER=https://<MY DOMAIN>
IDP_ISS=https://<MY DOMAIN>
PROXY_HTTP_ADDR=<IP_ADDRESS>:9200
PROXY_TLS=false
IDP_TLS=false

OCIS_INSECURE=true

OCIS_LOG_LEVEL=warn
OCIS_LOG_COLOR=true
OCIS_LOG_PRETTY=true

OCIS_CONFIG_DIR=/etc/ocis
OCIS_BASE_DATA_PATH=/var/lib/ocis

IDM_ADMIN_PASSWORD=secret

Additional context
Could anyone tell me exactly how you install extensions manually or if the marketplace part is also an extension i don't have installed?

@kulmann Could you help?

Hey @fnrcum 👋
You're correct, we've built an app store app - it's in its early phase as of now. It has a few main goals:

Make it easier to discover available apps (that's what we have at the moment)
Encourage people to submit their apps and extensions to our app store (on it.. there are a few more third party apps which are not in the app store, yet)
Make installation an easy one-/few-clicks experience (not here, yet)

If you know where to download apps then the app store app doesn't bring you much value at the moment. Installation still involves download a zip file, placing it in a folder, extracting it, configuring it if needed, restarting ocis. That's described here: https://owncloud.dev/services/web/#web-apps
The app-store app is again an app itself and if you have a custom config.json you can just add the string app-store into the apps array.
If you have a custom csp.yaml file you need to add 'https://raw.githubusercontent.com/owncloud/awesome-ocis/' to connect-src and img-src - if you don't have a custom csp.yaml the built-in default csp rules have those already.
Let me know if that helps.

Hey @fnrcum 👋
You're correct, we've built an app store app - it's in its early phase as of now. It has a few main goals:

Make it easier to discover available apps (that's what we have at the moment)
Encourage people to submit their apps and extensions to our app store (on it.. there are a few more third party apps which are not in the app store, yet)
Make installation an easy one-/few-clicks experience (not here, yet)

If you know where to download apps then the app store app doesn't bring you much value at the moment. Installation still involves download a zip file, placing it in a folder, extracting it, configuring it if needed, restarting ocis. That's described here: https://owncloud.dev/services/web/#web-apps
The app-store app is again an app itself and if you have a custom config.json you can just add the string app-store into the apps array. If you have a custom csp.yaml file you need to add 'https://raw.githubusercontent.com/owncloud/awesome-ocis/' to connect-src and img-src - if you don't have a custom csp.yaml the built-in default csp rules have those already.
Let me know if that helps.

This is my issue, the baremetal installation script was used.
./ocis init --config-path /etc/ocis  and after that, this is the folder structure i have
root@cloud:/home/cloud# ls /etc/ocis/
ocis.env  ocis.yaml

root@cloud:/home/cloud# ls /var/lib/ocis
idm  idp  nats  proxy  search  storage  thumbnails

This is based on the ocis.env
OCIS_URL=https://<domain>
OCIS_OIDC_ISSUER=https://<domain>
IDP_ISS=https://<domain>
PROXY_HTTP_ADDR=<IP_ADDRESS>:9200
PROXY_TLS=false
IDP_TLS=false

OCIS_INSECURE=true

OCIS_LOG_LEVEL=warn
OCIS_LOG_COLOR=true
OCIS_LOG_PRETTY=true

OCIS_CONFIG_DIR=/etc/ocis
OCIS_BASE_DATA_PATH=/var/lib/ocis

IDM_ADMIN_PASSWORD=secret

The ocis.yaml only contains essentially secrets and keys and nothing else so this is where I am having issues understanding where exactly these configurations are and where they need to go.
I am 100% sure I'm either doing something wrong or fundamentally misunderstanding something

You've mentioned a baremetal installation script - could you provide a link to that? 🙈 don't know what exactly you're talking about.
For the app store app: could you post the content of your config.json (redact URLs if you don't want them publicly exposed here). With ocis init there is no custom config.json being created, so I'm quite confused that you don't see the app store.
Regarding the apps folder: You can choose any folder on your disk as the apps folder. You can mkdir /etc/ocis/apps or whatever folder you want to use. Then make it available in oCIS via environment variable:
WEB_ASSET_APPS_PATH: /etc/ocis/apps.

I got the OCIS from the git releases
https://github.com/owncloud/ocis/releases/tag/v6.3.0
And followed the docs here
https://doc.owncloud.com/ocis/4.0/depl-examples/bare-metal.html

I got the OCIS from the git releases https://github.com/owncloud/ocis/releases/tag/v6.3.0
And followed the docs here https://doc.owncloud.com/ocis/4.0/depl-examples/bare-metal.html
As for the store, I have this App Store but it has only the 5 items in the screenshot so if this is what it was supposed to be then my bad, My assumption was that I could install extensions directly from it.

In the future: yes, you're supposed to be able to install from there. and more apps will follow soon.
For now: download and manual installation. It's supposed to improve discoverability as a first step.


deploy:release improvement

In deploy:release there is logic called "Fix collisions". This fix actually breaks the expected result which is release_name to be as specified. If there is conflict it is more proper to report it before the actual release. I propose to add additional task deploy:release:verify before deploy:release. If there is problem the deployment should stop. Only release_name to be responsible for the generated release name.

No more "Fix collisions" logic.


Adding the possibility to reference increments from outside the current templates file

Our objective
We would like to add a new feature to reference increments from outside the current templates.xml file.
Currently, we are able to reference increments inside the same file using incrementRef. See example here:
<increment name="server" description="CRUD OASP4J Server">
    <incrementRef ref="daos"/>
</increment>
    ....
<increment name="daos" description="DAO's">
    ....
</increment>

It would be nice to be able to reference an increment from another templates folder, with a syntax similar to this one:
<increment name="server" description="CRUD OASP4J Server">
    <incrementRef ref="crud_java_server_app::rest_service_impl"/>
</increment>

The first string of the ref is the name of the templates folder from where to get the increment. After the :: we state the increment id to reference.
Related Issues
Part of issue #676.

Current status
From my last PR, the current status of this functionality is the following:

It is possible to reference any increment from any external trigger. The way to do so is defining an incrementref like:

<increment name="server" description="CRUD OASP4J Server">
    <incrementRef ref="crud_java_server_app::rest_service_impl"/>
</increment>

The ref string is split using as delimiter ::. The first part of the string, is the trigger id crud_java_server_app to reference. That trigger contains an increment id rest_service_impl.

Although it is possible to reference any trigger, the generation of templates will only work when both triggers match the input file. For instance, when using as input a yaml file, we cannot generate templates that need a Java entity as input file. That logic will be implemented with issues #679 and #680.

Logic
To implement this functionality, I added the following logic:

In TemplatesConfigurationReader we read the external incrementref and it is added to the list of increment dependencies.
Then we call the ConfigurationHolder, which stores the TemplatesConfiguration of the external trigger (the trigger containing the increment we are referencing to). That class contains all the needed information of the trigger like, increments, templates, path to the templates...
After that, CobiGen automatically detects the needed templates and is able to resolve their path.

ToDo
There is no proper error message when trying to generate templates that need different input files. There are two cases:
First case: If the templates to be generated do not use any VariableAssignment on their name (like environment.prod.ts.ftl) the following error window is shown:

A DeferredDocument is the variable containing the parsed UML input file.
Second case: If the templates to be generated do use VariableAssignment, the error message is the following:

This means that the variables are null because the matcher could not resolve the input file.
We should create some kind of validation process before, so that a proper error message is shown to the user.