Fastclick not selecting input for inline elements within a label element

If there is an inline element inside the label element - the targetElement.tagName isn't 'label', so the findControl function is never hit.
Perhaps check if the parent node is a label then call findControl on the parent node?
FYI using testing iOS 6.0.1

While the 'pointer-events: none' works for most users, it doesn't work well for those with "heavy" fingers, at least in my case.  After seeing older users use the touch interface, in my situation they tend to make heavier taps and it seems to register doubly (to the effect of checking and rapidly unchecking just as they lift their finger).  Their taps tend to be somewhere between a normal tap and a selection touch hold.  Removing fast-click makes it work 100% of the time in duration between a tap and a selection hold.  Do you think this is a limitation of fast-click, or am I doing something wrong?
HTML:
<input type="checkbox">
CSS:
label > * { pointer-events: none; }

input[type=checkbox] {
	display: none;
}
input[type=checkbox] + span {
	display: inline-block;
	position:relative;
	background: #fff;
	border: 1px solid #C8C8C8;
	height: 24px;
	width: 24px;
	padding: 0;
	vertical-align:top;
	margin-left:0.25rem;
	-webkit-transition: background .1s;
	transition: background .1s;
}
input[type=checkbox]:checked + span {
	border: 2px solid #fff;
	outline: 1px solid #C8C8C8;
	background: #2f86c4;
}

@mattcg thanks man, "label > * { pointer-events: none; }" also fixed it for me. Feulf!

@mattcg ,thanks~

If cursor needs to be added try like below:
label { cursor:pointer; } label > * {pointer-events:none;}

label > * { pointer-events: none; }
this works for me. thx!

thanks guys ! hours spent to find this fix  (label > * { pointer-events: none; })

I suppose it should be pointed out that
label > * { pointer-events: none; }

will affect everything within the label and one may need some specific exceptions in addition to some general ones, such as links within labels:
label a { pointer-events: all; }

I haven't fully tested anything though.

/Jquery Fix/
$('input').on('click',function(){
$(this).focus();
});
This worked in my case. Thanks

so good,this is good methods


Start odbc32

Starting odbc32, already enough to connect and get query results from odbc data sources.

Could you rebase and squash?

Done


[WIP] Adjusting DeltaStreamer shutdown sequence to avoid awaiting for 24h

Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.

What is the purpose of the pull request
Right now, any HoodieAsyncService would be awaiting for 24h for its executor to shutdown gracefully. This however poses a problem in cases when such executor is spinning non-daemon threads, as this might prevent JVM from shutting down for those 24h, in cases when executors continue running (for ex, in a crash loop).
Brief change log

Reducing executor graceful shutdown timeout to 1m from 24h
Fixed DeltaSyncService to properly override shutdown method and invoke one from super-class for proper shutting down
Cleaning up some NPEs previously observed in tests
Tidying up

Verify this pull request
This pull request is a trivial rework / code cleanup without any test coverage.
This pull request is already covered by existing tests, such as (please describe tests).
Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

please create a jira and tag

Will take a pass once this is ready for review.

@alexeykudinkin : can we close this one if not required.


[Question]:  How to use the Azure DevOps artifact feed adjacent to the outside feeds ?

Task name
NuGet restore
Task version
2.X
Environment type (Please select at least one enviroment where you face this issue)

[ ] Self-Hosted
[X] Microsoft Hosted
[ ] VMSS Pool
[ ] Container

Azure DevOps Server type
dev.azure.com (formerly visualstudio.com)
Azure DevOps Server Version (if applicable)
No response
Operation system
Windows Latest
Question
Is there any option to which enables the parallel utilization of feeds in side the ADO project and external feed in Nuget.config file?

You can declare multiple package sources in nuget.config. see example here. Then in the nuget restore task use the feeds in my nuget config option from the docs.
However, I believe this will only work for externals feeds that do not require authentication. For external feeds with authentication, I recommend moving away from the restore task. Instead, you could use the NugetAuthenticateV0 task with a script task to call nuget directly. The Nuget Authenticate task would authenticate for the ADO feedn,  then for the external feed you would need an additional task before the nuget script to somehow pass the external feed credentials to nuget in your pipeline, but you would need to figure out how to pass the credentials for the external feed.
Note: this configuration would open you to dependecy confusion or substitution OSS related attacks. see this nuget issue with package source mapping to reduce the risk.


API Environment Keys

Rancher Version:
1.1.2
Docker Version:
1.12
OS and where are the hosts located? (cloud, bare metal, etc):
Bare, RHEL
Setup Details: (single node rancher vs. HA rancher, internal DB vs. external DB)
Single node, external DB.
Environment Type: (Cattle/Kubernetes/Swarm/Mesos)
Cattle
Steps to Reproduce:
Create several environments, and add a few api keys in each.
Results:
List all api keys, regardless of selected environment.
https://rancher.example.net/env/1a666/api
Expected:
Only see keys that apply to current environment. Or, at least show which environment each key works for.
We have a few different tools, that all interact with each environment, so they tend to have the same key name and description in each env, so there's no way to tell which key is for which environment from the UI (that I've found, at least).

Or, there was a bug in the UI, because now it seems to only show the api keys for the current environment. Could toss this into the glitches bin.

Ok, I managed to reproduce this now.
** Steps to reproduce **
As above, then go to Admin/Accounts then to API, it now shows ALL api keys for ALL environments, not just the current one. Reloading the page will get the list back down to show only the current environments API keys again.

Version - 1.2.0-pre4-rc10 : This is still reproducible.  By going to accounts page then API, I can see all environment keys in the environment section.

Version - v1.2.0-pre4-rc14
Verified fixed


Removing directive node is hard

If you create a custom directive, ie. like YouTube directive in examples and insert it into the editor, the node is really hard to remove from the editor content.
If using generic editor with children option, node can be removed by settings the cursor in the nested editor and pressing backspace. But if using generic directive without children option, it's almost impossible to remove added node from the editor. Sometimes I managed to remove it by selecting whole area and then pressing backspace. But that won't seem to work reliably if there isn't other text before and after node.
In my opinion, most user friendly functionality would be a possibility to set cursor on row below node and then pressing backspace. Not sure if related, but if trying to move cursor up and there is an directive/image/etc node, cursor just disappears. Also, clicking directive node should make it "active", which could then be deleted from the editor using backspace.

Solving this is entirely in the space of the custom directive editor implementation. IMO, custom directives (or, for that matter, any custom component) should contain an UI that explicitly lets the user remove them, as they don't behave like objects in regular text editing.
You can check the UI of the table editor that has a trash can in the upper left corner as an example.

The API surface and the complexity of the component is quite large, that's the nature of rich text editing. Rather than developing it in the dark for another several months, I chose to release it with the essentials documented, and develop it further based on the feedback of the users. This being said, I'm happy to accept contributions - not only on the actual codebase but on the docs as well.


[Bug]: uneven sizings of cards on chapters page 🪲

Description

The bug is about the eneven sizings of the card which makes the UI looks bad.
Some cards looks smaller and others look bigger, the styles are inconsistent.
We need to fix this bug to improve the UI.

Expected Behavior

The cards need to have a perfect width and height to look good

Show us the trouble with screenshots
https://github.com/OSCode-Community/OSCodeCommunitySite/assets/92252895/e17a7ae2-6b96-4449-ac9d-84118a9fab79
Which browsers are affected?
Firefox
Which OS are affected?
linux
Enter the version of your web browser
114.54
Device?
Desktop
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSoC'23 contributor
[X] I want to work on this issue

@Vaishnavi-Patil2211 Please assign this issue to me


Add option to disable gzip compression

Because functions gzcompress() and base64_encode() require too much memory when handling a memory exhausted fatal error. I should usualy reserve about 2mb of memory to track this errors.

The ErrorHandler reserves 10mb of memory by default to handle these situations.
https://github.com/getsentry/sentry-php/blob/master/lib/Raven/ErrorHandler.php#L188
If this is still an issue please do re-open.

Just for reference, this has been implemented in version 2.0. The option is called encoding and accepts these values: gzip or json. The first value means that the whole body of the request to a Sentry server will be encoded in base64 and then gzipped. Also, these operations are now done with stream filters, so I think it should improve the performance and required memory


Failed type coercion should be considered validation error?

We have a Date field in a web form.  If the user types in an invalid date string, the type coercion fails with an ArgumentError and stack trace.  I believe this is because type coercion happens before validations are run.  Realistically this should be considered a validation error so that our form can detect a problem with the field and display an error message so the user can fix their typo.
If this is not the correct solution, could you provide an example of how to use a validated Date field with a form?

I'm at vers 2.2.1 and this issue is still there....  I'll try the patch

Closing as per #818.


possibly incorrect documentation "Spawning a fiber and waiting for it to complete"

The documentation Spawning a fiber and waiting for it to complete says This prints:
Before receive
Before send
After receive

I tried the code
channel = Channel(Nil).new

spawn do
  puts "Before send"
  channel.send(nil)
  puts "After send"
end

puts "Before receive"
channel.receive
puts "After receive"

and got the following result:
Before receive
Before send
After send
After receive

Crystal 0.35.1 [5999ae29b] (2020-06-19)
LLVM: 8.0.0
Default target: x86_64-unknown-linux-gnu
debian 10
https://play.crystal-lang.org/#/r/9f46
the result of this program also seems to be incorrectly documented
https://play.crystal-lang.org/#/r/9f49
channel = Channel(Int32).new

spawn do
  puts "Before first send"
  channel.send(1)
  puts "Before second send"
  channel.send(2)
end

puts "Before first receive"
value = channel.receive
puts value # => 1

puts "Before second receive"
value = channel.receive
puts value # => 2

Ah, yeah, I think this behavior changed in some point. I think the docs should say "one possible output is..." because one shouldn't rely on whether send immediately jumps to another fiber or not if there's someone waiting on the other side.


node:6) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 exit listeners added. Use emitter.setMaxListeners() to increase limit

The node has been working fine for the last few days. But after a while I get the following error and the node doesn't anymore:
Attaching to bronzeagenode_app_1
app_1  | [info] Chain is loading.
app_1  | [info] Checkpoints are enabled.
app_1  | [info] Coin cache is enabled.
app_1  | [info] Content server listening on port 9301
app_1  | [info] Opening ChainDB...
app_1  | [info] Chain is loading.
app_1  | [info] Checkpoints are enabled.
app_1  | [info] Coin cache is enabled.
app_1  | [info] ChainDB successfully loaded.
app_1  | [info] Chain State: hash=000000f0cb40108fee818058eef4d1bdd5dd10dae00fe159594139dc92f3af20 tx=8298 coin=8276.
app_1  | [info] Chain Height: 8275
app_1  | [debug] Memory: rss=65mb, js-heap=23/39mb native-heap=25mb
app_1  | [info] Chain Height: 8275
app_1  | [debug] Memory: rss=65mb, js-heap=23/39mb native-heap=25mb
app_1  | [warning] P2SH has been activated.
app_1  | [debug] Memory: rss=66mb, js-heap=23/39mb native-heap=26mb
app_1  | [info] Chain is fully synced (height=8275).
app_1  | [debug] Memory: rss=66mb, js-heap=23/39mb native-heap=26mb
app_1  | [info] Mempool loaded (maxsize=97656.25kb).
app_1  | [info] Miner loaded (flags=mined by decentraland-node).
app_1  | [info] Pool loaded (maxpeers=8).
app_1  | [info] HTTP server listening on <IP_ADDRESS> (port=8301).
app_1  | [info] HTTP server loaded.
app_1  | [info] HTTP API key: REMOVED
app_1  | [info] HTTP Service API key: REMOVED
app_1  | [info] Added 25 hashes to WalletDB filter.
app_1  | [info] Added 3 outpoints to WalletDB filter.
app_1  | [debug] Rolled back to same height (8275).
app_1  | [info] WalletDB is scanning 1 blocks.
app_1  | [info] Scanning from block 000000f0cb40108fee818058eef4d1bdd5dd10dae00fe159594139dc92f3af20.
app_1  | [info] Scanning block 000000f0cb40108fee818058eef4d1bdd5dd10dae00fe159594139dc92f3af20 (8275).
app_1  | [warning] Already saw WalletDB block (8275).
app_1  | [info] Finished scanning 1 blocks.
app_1  | [info] Rebroadcasting 3 WalletDB transactions.
app_1  | [info] WalletDB loaded (depth=2, height=8275, start=0).
app_1  | [error] Verification failure: txn-already-known (code=alreadyknown, score=0, hash=9f7f1ae6abd307cd489d6f38408caf26de2abc7f58ceaf4c1556442ed32e610f)
app_1  | [warning] Verification failed for tx: 9f7f1ae6abd307cd489d6f38408caf26de2abc7f58ceaf4c1556442ed32e610f.
app_1  | [warning] Attempting to broadcast anyway...
app_1  | [error] Verification failure: txn-already-known (code=alreadyknown, score=0, hash=e822d440ab57a14c7a0a4d993c839a1db7a41bb266d36fac548baee3bcbd0a44)
app_1  | [warning] Verification failed for tx: e822d440ab57a14c7a0a4d993c839a1db7a41bb266d36fac548baee3bcbd0a44.
app_1  | [warning] Attempting to broadcast anyway...
app_1  | [error] Verification failure: txn-already-known (code=alreadyknown, score=0, hash=b04f2bb8f24ebe2949201fc643f789d08611d5ba142f01eddddf42fc5fdf48d7)
app_1  | [warning] Verification failed for tx: b04f2bb8f24ebe2949201fc643f789d08611d5ba142f01eddddf42fc5fdf48d7.
app_1  | [warning] Attempting to broadcast anyway...
app_1  | [info] Wallet opened (primary).
app_1  | [info] TXDB loaded for primary.
app_1  | [info] TXDB State: tx=3 coin=3.
app_1  | [info] Balance: unconfirmed=0.0 confirmed=0.0.
app_1  | [info] Loaded wallet with id=primary wid=1 address=REMOVED
app_1  | [info] Pool server listening on <IP_ADDRESS> (port=2301).
app_1  | [info] Node is loaded.
app_1  | [info] Starting miner ...
app_1  | (node:6) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 exit listeners added. Use emitter.setMaxListeners() to increase limit
app_1  | [debug] Error: socket hang up
app_1  |     at createHangUpError (_http_client.js:253:15)
app_1  |     at Socket.socketCloseListener (_http_client.js:285:23)
app_1  |     at emitOne (events.js:101:20)
app_1  |     at Socket.emit (events.js:188:7)
app_1  |     at TCP._handle.close [as _onclose] (net.js:501:12)
app_1  | [error] socket hang up
bronzeagenode_app_1 exited with code 1

@jaimeblasco thanks for reporting, we'll look into this

Seeing this too.

Not needed anymore as we moved to IPFS.


Readme describing the structure of this repo

I don't remember what you called your parameter loader library.  Here is a repo for in and a proposed layout.

the one the facilitates loading the moveit configs

That one could go in moveit itself.  This one should be as generic as possible.


Add logger for Azure Machine Learning

Before submitting

[x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure to update the docs?
[x] Did you write any new necessary tests?

What does this PR do?
This pull request adds an Azure Machine Learning logger to PyTorch Lightning Bolts. Since AML is integrated with MLFlow for experiment tracking (link), this logger subclasses the MLFlow logger.
It will enable users to track their metrics in the Azure ML UI by writing code like:
from azureml.core import Run
from pytorch_lightning.loggers import AzureMlLogger

# This is optional
run = Run.get_context()
azureml_logger = AzureMlLogger(run)

trainer = Trainer(logger=azureml_logger)

This pull request closes #180 .
PR review
Everyone is welcome to comment and review!
Did you have fun?
Yes!

@dkmiller would you mind investigating/explaining to me why I chose to do this when I used AzureML? I believe this will surface up the logs one level higher so you can view them w/o clicking into an experiment (which I believe you will find to be much more useful).
Also, if I remember correctly, it said somewhere in their docs to be careful about making references to the parent run like I'm doing here, so it may be a bad idea (meaning your code is fine as-is).
# get the Azure ML run object
child_run = Run.get_context()
# If I remember correctly, this is some secret sauce...has to do w/ how logs are surfaced in AzureML
run = child_run.parent

Is there a timeline on when this will be available?

@aribornstein I anticipate fixing the conflicts and having this ready for review by the end of this week.

Hello @dkmiller! Thanks for updating this PR.

In the file pl_bolts/loggers/azureml.py:

Line 37:121: E501 line too long (124 > 120 characters)
Line 67:1: W293 blank line contains whitespace

@nateraw @Borda @aribornstein this is ready for review :) . I was able to simplify the logic drastically by leveraging the existing AML :: MLFlow integration.

this cannot run any complete PL training offline as a test, right?

@dkmiller this looks great I'm going to give it a try later today. I really would like us to think if theres any way for us to test this more rigorously on the CI, though (as per @Borda's point).
If not (which I'm afraid may be the case), we can probably just merge this after I am able to play with it.

I know you can configure a local run, but I can't recall if this is something you can do without logging in.

Thank you so much for your contribution @dkmiller! This is a great feature for Lightning to have but unfortunately, we are no longer adding integrations to our repository, due to the maintenance cost on our end. We think it would be great for you to add that integration on your end, please let us know if you want more details on how that would look like.

Thanks for your contribution @dkmiller! This integration is a wonderful addition, but unfortunately our policies around adding integrations to our repo changed recently due to high maintenance cost on our end. I'll reach out privately in slack to see how we can work together to add this integration on your end, and we'd love to help out with testing, reviewing, and making sure everything is working as intended.

@dkmiller mind check the comments and resolve conflicts...

@dkmiller mind check comments from @akihironitta and it seems that due to recent development there are a few conflicts...

@dkmiller mind check comments from @akihironitta and it seems that due to recent development there are a few conflicts...

@dkmiller mind check the last comments and resolve conflicts?

Due to @edenlightning comments, it looks like lightning-bolts is no longer accepting "custom logger" PRs. Closing this one out.


Update Neo4j writer and Roadmap Adapters

Enhance the Neo4j writer by transitioning  it from writing individual MERGE queries for each node and edge to write nodes and edges to a CSV file and generates a LOAD CSV query for bulk import.
Fix the Roadmap Adapters to use the new cell ids to ontology map pkl file

Looks good!


Link in Readme returns 404

https://github.com/Live-Hack-CVE/ when returns a 404:

Sorry didn't mean to mark this as a bug?

@nickorlabs thank you, fixed with https://github.com/projectdiscovery/cvemap/commit/b1553c7e15fe365e4fcb22a03dcee888faf10626


Start jetty in single jvm

This PR adds a dry-run of jetty at container start time. This allows us to run a single JVM process for the jetty server, even if modules with exec options are used.
fixes #182

Also related to #171

@meltsufin I updated to take @gregw's suggestions into consideration, and borrowed from his implementation in appropriate/docker-jetty#66.
PTAL - this is ready for review

Merging now. FYI, these changes require the changes in https://github.com/GoogleCloudPlatform/openjdk-runtime/pull/109 in order to fix #182


Validation error when shadowDatabaseUrl is identical to url (or directUrl)

https://github.com/prisma/docs/pull/4188 raised a valid point that it is bad to use the same database for shadowDatabaseUrl as you are using for url - your database will be overwritten and you will lose data. The PR adds a warning into the docs, but we can actually do one better and just fail validation of the schema in this case.
Internal discussion: https://prisma-company.slack.com/archives/CGMCB82N8/p1670232135999259

Because this is a potentially serious issue if the user doesn't use separate databases, I'm going to approve the docs PR as an interim measure. We can remove the warning from the docs when this work is done.

Another case that could have been prevented by this: https://github.com/prisma/prisma/issues/20842

We already check that url ≠ shadow database url (https://github.com/prisma/prisma-engines/blob/d7eca61ec34d27473cb990402ce406299191[…]ed/schema-engine/connectors/sql-schema-connector/src/flavour.rs — and in the submodules to see where that is used). That wasn't implemented for directUrl when directUrl was added.

@tomhoule Can you provide some more guidance on what approach I can take to try resolve this issue?

The gist of the change would be that if directUrl is defined, we would need to compare (in the function linked above) the directUrl with the shadowDatabaseUrl, and otherwise keep the existing comparison (between url and shadowDatabaseUrl).

@tomhoule I am keen on contributing to this issue, but from what I understand you are saying that this validation should be performed at the engine side right therefore this issue belong to the engine repo? As I see the current client implementation also just feeds the entire schema as a string to the engine, so to perform validation at client side would require some parsing which I assume you think is not the best approach?

Hi @zlimez — I don't work at Prisma anymore so I'm not responsible for the direction. It could be done either way, the TS code has access to some of the engines parser API.

Oh kook thank you I understand @janpio may I know what would be the desired approach adding to the engine backend check or validate before passing the schema to the engine

Yes, this should happen in the engine.
We track all issues in this repository.


Fix Peripherals OHCI test issue

Currently, the BSA spec doesn't hold the requirement for OHCI (USB 1.1), so test case should relax this case to avoid the unexpected failure.

Hi @ownia,
Thanks for the changes.
We had internal discussion and the test will be updated to fail only if there is no ehci 1.1 or xhci usb controller present.
We will consume your changes as part of  the proposed test updates.
Thanks,
ACS team


Use spaces.Space docstring

This PR replaces the markdown description of Spaces by the class docstring of spaces.Space.
The corresponding docstring is currently being updated in Gym to give a more detailed description of what spaces do and improve formatting. I think it would be convenient to have the documentation in one place, as opposed to two.
This is just a suggestion, I can also see good reasons not to use the spaces.Space docstring for the general description of spaces.

Looks good to merge


feat: add prometheus blackbox exporter helm chart

:tada: This PR is included in version 1.0.0-alpha.36 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


feat: add possibility to override default path to config file

Related to https://github.com/ivanhofer/typesafe-i18n/discussions/656
Allow pass additional parameter to cli named as --project, that allow users to override default '.typesafe-i18n.json' path to config file
Save backward compatibility to allow current users change nothing in its workflow.
Tested locally with command
typesafe-i18n -p /Users/whalemare/dev/project/some/relative/path/to/config/.typesafe-i18n.json

Feel free to leave any comments/edits and I will try to make it fully compatible with existed codebase, in case when some issue exists


Fix/test mock

Pull Request Test Coverage Report for Build 2771

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
4 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.05%) to 90.005%

Files with Coverage Reduction
New Missed Lines
%

data-access-layer/db/DBManager/DBManager.js
1
98.97%

common/utils/index.js
3
89.21%

Totals

Change from base Build 2766:
-0.05%

Covered Lines:
8775

Relevant Lines:
9427

💛  - Coveralls


Deploy Checklist: New Expensify 2023-09-22

Release Version: 1.3.73-0
Compare Changes: https://github.com/Expensify/App/compare/production...staging
This release contains changes from the following pull requests:

[x] https://github.com/Expensify/App/pull/19345
[ ] https://github.com/Expensify/App/pull/23390
[x] https://github.com/Expensify/App/pull/23712
[x] https://github.com/Expensify/App/pull/24319
[x] https://github.com/Expensify/App/pull/24407
[ ] https://github.com/Expensify/App/pull/25416
[x] https://github.com/Expensify/App/pull/26029
[x] https://github.com/Expensify/App/pull/26236
[x] https://github.com/Expensify/App/pull/26543
[x] https://github.com/Expensify/App/pull/26710
[x] https://github.com/Expensify/App/pull/26727
[x] https://github.com/Expensify/App/pull/26861
[x] https://github.com/Expensify/App/pull/26934
[x] https://github.com/Expensify/App/pull/26969
[x] https://github.com/Expensify/App/pull/26973
[ ] https://github.com/Expensify/App/pull/26982
[x] https://github.com/Expensify/App/pull/27127
[x] https://github.com/Expensify/App/pull/27203
[x] https://github.com/Expensify/App/pull/27314
[x] https://github.com/Expensify/App/pull/27368
[x] https://github.com/Expensify/App/pull/27437
[x] https://github.com/Expensify/App/pull/27439
[ ] https://github.com/Expensify/App/pull/27459
[x] https://github.com/Expensify/App/pull/27468
[x] https://github.com/Expensify/App/pull/27475
[x] https://github.com/Expensify/App/pull/27505
[x] https://github.com/Expensify/App/pull/27506
[x] https://github.com/Expensify/App/pull/27550
[ ] https://github.com/Expensify/App/pull/27619
[x] https://github.com/Expensify/App/pull/27638
[x] https://github.com/Expensify/App/pull/27640
[x] https://github.com/Expensify/App/pull/27643
[x] https://github.com/Expensify/App/pull/27644
[x] https://github.com/Expensify/App/pull/27645
[x] https://github.com/Expensify/App/pull/27649
[x] https://github.com/Expensify/App/pull/27653
[x] https://github.com/Expensify/App/pull/27656
[x] https://github.com/Expensify/App/pull/27657
[x] https://github.com/Expensify/App/pull/27661
[x] https://github.com/Expensify/App/pull/27664
[x] https://github.com/Expensify/App/pull/27679
[x] https://github.com/Expensify/App/pull/27682
[x] https://github.com/Expensify/App/pull/27702
[x] https://github.com/Expensify/App/pull/27734
[ ] https://github.com/Expensify/App/pull/27739
[x] https://github.com/Expensify/App/pull/27740
[x] https://github.com/Expensify/App/pull/27743
[x] https://github.com/Expensify/App/pull/27749
[ ] https://github.com/Expensify/App/pull/27750
[x] https://github.com/Expensify/App/pull/27753
[x] https://github.com/Expensify/App/pull/27758
[x] https://github.com/Expensify/App/pull/27762
[ ] https://github.com/Expensify/App/pull/27765
[x] https://github.com/Expensify/App/pull/27769
[ ] https://github.com/Expensify/App/pull/27784
[x] https://github.com/Expensify/App/pull/27795
[x] https://github.com/Expensify/App/pull/27797
[ ] https://github.com/Expensify/App/pull/27808
[x] https://github.com/Expensify/App/pull/27834
[x] https://github.com/Expensify/App/pull/27840
[x] https://github.com/Expensify/App/pull/27842
[x] https://github.com/Expensify/App/pull/27845
[ ] https://github.com/Expensify/App/pull/27851
[x] https://github.com/Expensify/App/pull/27859
[x] https://github.com/Expensify/App/pull/27876
[x] https://github.com/Expensify/App/pull/27877
[x] https://github.com/Expensify/App/pull/27880
[x] https://github.com/Expensify/App/pull/27882
[x] https://github.com/Expensify/App/pull/27911
[x] https://github.com/Expensify/App/pull/27921
[x] https://github.com/Expensify/App/pull/27925
[ ] https://github.com/Expensify/App/pull/27932
[x] https://github.com/Expensify/App/pull/27945
[x] https://github.com/Expensify/App/pull/27946
[x] https://github.com/Expensify/App/pull/27955
[x] https://github.com/Expensify/App/pull/27957
[x] https://github.com/Expensify/App/pull/27969
[x] https://github.com/Expensify/App/pull/27978

Internal QA:

[ ] https://github.com/Expensify/App/pull/27844 - @youssef-lr

Deploy Blockers:

[ ] https://github.com/Expensify/App/issues/27094
[ ] https://github.com/Expensify/App/issues/27903
[ ] https://github.com/Expensify/App/issues/27928
[x] https://github.com/Expensify/App/issues/28033
[ ] https://github.com/Expensify/App/issues/28036
[ ] https://github.com/Expensify/App/issues/28042
[ ] https://github.com/Expensify/App/issues/28044
[ ] https://github.com/Expensify/App/issues/28057
[ ] https://github.com/Expensify/App/issues/28063
[x] https://github.com/Expensify/App/issues/28069
[x] https://github.com/Expensify/App/issues/28079
[x] https://github.com/Expensify/App/issues/28086
[ ] https://github.com/Expensify/App/issues/28092

Deployer verifications:

[ ] I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
[ ] I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
[ ] I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

:rocket: All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.73-0 :rocket:

https://github.com/Expensify/App/pull/27851 & https://github.com/Expensify/App/pull/27932 - PROD QA. Ok to check off?

Regression TR iOS 17 slots are left
#23390 failing with #28042
#24407 failing with #26136 repro in offline. Checking it off
#25416 failing with #28048
#26982 failing with #28046
#27459 failing with #28079
#27619 failing with #27365 (not fixed in mweb and iPhone)
#27739 failing with #28054 reproduced in production, ok to check it off?
#27750 failing with #28084  (As per this #27479 shouldn't be available- ok to check it off?)
#27784 -  could you check internally, Our accounts have silver wallet and this PR requires golden wallet with balance

@thienlnam Regression is completed.
#27765 failing with #28069
#27739 failing with #28054 in mweb
#23390 failing with #28042
#25416 failing with #28048
#26982 failing with #28046
#27459 failing with #28079
#27619 failing with #27365 (not fixed in mweb and iPhone)
#27739 failing with #28054 reproduced in production, ok to check it off?
#27750 failing with #28084 (As per this #27479 shouldn't be available- ok to check it off?)
#27784 - could you check internally, Our accounts have silver wallet and this PR requires golden wallet with balance

cc @chiragsalian As he is the App deployer this week

Checking off https://github.com/Expensify/App/issues/28086 as a blocker, it's very lower priority.

Checked off #28057 following cherry pick of fix and re-test in staging

Checking https://github.com/Expensify/App/pull/28089 off, verified internally

checking off:

https://github.com/Expensify/App/pull/27932
https://github.com/Expensify/App/pull/27851
https://github.com/Expensify/App/pull/27619

As these are related to ExpensiHelp page which is normally deployed on main and we can QA it separately and it should not be a staging blocker, this PR will resume it https://github.com/Expensify/App/pull/27988/
Checking off https://github.com/Expensify/App/pull/23390 as the found issue was demoted to normal bug
Checking https://github.com/Expensify/App/pull/26982 off as that is behind beta still'
checking https://github.com/Expensify/App/pull/27739 off as the found issues are in production/ not reproducible
checking https://github.com/Expensify/App/pull/27765 off as that is behind beta too
checking https://github.com/Expensify/App/pull/27459 off as that is behind categories beta
https://github.com/Expensify/App/pull/27784 verified internally https://expensify.slack.com/archives/C03TQ48KC/p1695630600830069
Checking https://github.com/Expensify/App/pull/25416 off as the issue found is not a blocker
Checking https://github.com/Expensify/App/pull/27750 as the save the world is not accessible yet

Graphs looking good
No new crashes standing out

:shipit:


ERROR in Symbol Base64Validator declared

Getting below error in ng serve with enableIvy in Angular 8.
ERROR in Symbol Base64Validator declared in E:/test_project/node_modules/ng2-validation/dist/base64/directive.js is not exported from E:/test_project/node_modules/ng2-validation/dist/base64/directive (import into E:/test_project/node_modules/ng2-validation/dist/index.js)

I Have the same problem with  enableIvy

It seems this repository has been deprecated!
I use  ngx-custom-validators  instead.

I have the same problem when updated to angular 9, I think ng2-validator no longer used with angular 9 and replaced with ngx-custom-validator


Pretty printing of here documents without trailing newline

Consider the following here document:
Heredoc Here "EOF" False (stringToWord "here document")

If pretty printed it looks like that:
<<EOF
here documentEOF

This is clearly not the intended result. Maybe we should add a trailing newline if it is not present in the Word being rendered.

I could implement that if we agree on a solution.

Hmm right now parse(prettyPrint(ast)) == ast for all possible trees (or at least that's the goal) but adding a newline would break that. Is it ever possible for a heredoc to not end in a newline in bash? Maybe we should comment that on the Heredoc constructor instead. What do you think?

I'm not yet sure about that. I stumbled upon that issue while writing a package for shell script generation in the spirit of shell-monad.
I do think it would be nice to force the EOF marker on a separate line because otherwise bash will extend the end of file which could lead to some really unintended results.
Indeed it is IMHO not possible in bash to produce a heredoc without trailing newline.
I'm not sure why a newline list terminator would break the assertion you mentioned above; can you elaborate a bit more on that?

I implemented a solution here.
Didn't test it though.

You're right, it won't break that assertion. The solution looks good to me, feel free to turn it into a pull request.

Ok, I'll do that. I'll wait until #24 gets merged.


[#121003303] Changes for OSX Concourse Pipeline

create YAML files for OSX pipeline
fix existing files to use /usr/bin/python instead of /usr/bin/python2,
because it is missing on OSX (python2 is symlink to python on CentOS)
fix a warning in CAutoTaskProxyTest.cpp, which was breaking the
Release build

@d @xinzweb @hsyuan @vraghavan78

+1

-1

I don't see a corresponding task YAML that references publish_tag_osx.bash
I don't see any downstream tasks consuming any artifact produced by the script publish_tag_osx.bash
The content of that script looks like it will fail, if I'm executing that code in my head correctly


Key errors (chargingInductivePositioning, fuelPercent)

Describe the issue
I'm using Home Assistant and during startup of BMW Connected Drive component I get the errors KeyError: 'chargingInductivePositioning' and KeyError: 'fuelPercent'. These errors don't prevent the component to start and other values are properly reported.
I've opened a similar issue on Home Assistant repository, but maybe it could be a bug on this library ...so here I am!
Expected behavior
No errors on Home Assistant's BMW Connected Drive component startup.
Home Assistant version (if used)

Which Home Assistant version are you using? 0.118.4
And did it work on a previous version, if so what was the last working version? N/A

ConnectedDrive website
If you see any issues with the BMW integration in Home Assistant (or when directly using the library), please make sure to first login to the BMW ConnectedDrive website of your country and check if you can successfully login and query the car status.

[x] I can still successfully login to the BMW ConnectedDrive website and the car status is available there.
[x] I have ConnectedDrive enabled for my vehicle.

Your config.yaml
bmw_connected_drive:
  name:
    username: !secret mini_username
    password: !secret mini_password
    region: 'rest_of_world'

Home Assistant logs
2020-12-01 09:31:29 ERROR (MainThread) [homeassistant.components.sensor] bmw_connected_drive: Error on device update!,
Traceback (most recent call last):,
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 359, in _async_add_entity,
    await entity.async_device_update(warning=False),
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 466, in async_device_update,
    await task,
  File "/usr/local/lib/python3.8/concurrent/futures/thread.py", line 57, in run,
    result = self.fn(*self.args, **self.kwargs),
  File "/usr/src/homeassistant/homeassistant/components/bmw_connected_drive/sensor.py", line 154, in update,
    self._state = getattr(vehicle_state, self._attribute),
  File "/usr/local/lib/python3.8/site-packages/bimmer_connected/state.py", line 125, in __getattr__,
    return self.vehicle_status.attributes[item],
KeyError: 'chargingInductivePositioning',
2020-12-01 09:31:29 ERROR (MainThread) [homeassistant.components.sensor] bmw_connected_drive: Error on device update!,
Traceback (most recent call last):,
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 359, in _async_add_entity,
    await entity.async_device_update(warning=False),
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 466, in async_device_update,
    await task,
  File "/usr/local/lib/python3.8/concurrent/futures/thread.py", line 57, in run,
    result = self.fn(*self.args, **self.kwargs),
  File "/usr/src/homeassistant/homeassistant/components/bmw_connected_drive/sensor.py", line 154, in update,
    self._state = getattr(vehicle_state, self._attribute),
  File "/usr/local/lib/python3.8/site-packages/bimmer_connected/state.py", line 125, in __getattr__,
    return self.vehicle_status.attributes[item],
KeyError: 'fuelPercent',

Number of cars
If you have more than 1 car please mention that here.

[ ] I have 2 or more cars linked to the ConnectedDrive account.
[x] I have a Mini vehicle linked to my account. Car is a brand new Mini Cooper S E Countryman All4.

Could you please provide a vehicle fingerprint?
That would make debugging the issue simpler.
Many thanks!

Here you are my vehicle_fingerprint.zip. Thanks for your support!

It seems like they are no longer sending chargingInductivePositioning and fuelPercent. The same happens in a BMW 330e. Can anyone else confirm?

My BMW X5 45e still returns fuelpercent.
However, chargingInductivePostioning seems removed

Not fixed as of 2021.01:
2021-01-11 01:05:58 ERROR (MainThread) [homeassistant.components.sensor] bmw_connected_drive: Error on device update!
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 359, in _async_add_entity
    await entity.async_device_update(warning=False)
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 466, in async_device_update
    await task
  File "/usr/local/lib/python3.8/concurrent/futures/thread.py", line 57, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/src/homeassistant/homeassistant/components/bmw_connected_drive/sensor.py", line 136, in update
    self._state = getattr(vehicle_state, self._attribute)
  File "/usr/local/lib/python3.8/site-packages/bimmer_connected/state.py", line 125, in __getattr__
    return self.vehicle_status.attributes[item]
KeyError: 'chargingInductivePositioning'
2021-01-11 01:05:58 ERROR (MainThread) [homeassistant.components.sensor] bmw_connected_drive: Error on device update!
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 359, in _async_add_entity
    await entity.async_device_update(warning=False)
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 466, in async_device_update
    await task
  File "/usr/local/lib/python3.8/concurrent/futures/thread.py", line 57, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/src/homeassistant/homeassistant/components/bmw_connected_drive/sensor.py", line 136, in update
    self._state = getattr(vehicle_state, self._attribute)
  File "/usr/local/lib/python3.8/site-packages/bimmer_connected/state.py", line 125, in __getattr__
    return self.vehicle_status.attributes[item]
KeyError: 'fuelPercent'

Not fixed as of 2021.01:
2021-01-11 01:05:58 ERROR (MainThread) [homeassistant.components.sensor] bmw_connected_drive: Error on device update!
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 359, in _async_add_entity
    await entity.async_device_update(warning=False)
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 466, in async_device_update
    await task
  File "/usr/local/lib/python3.8/concurrent/futures/thread.py", line 57, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/src/homeassistant/homeassistant/components/bmw_connected_drive/sensor.py", line 136, in update
    self._state = getattr(vehicle_state, self._attribute)
  File "/usr/local/lib/python3.8/site-packages/bimmer_connected/state.py", line 125, in __getattr__
    return self.vehicle_status.attributes[item]
KeyError: 'chargingInductivePositioning'
2021-01-11 01:05:58 ERROR (MainThread) [homeassistant.components.sensor] bmw_connected_drive: Error on device update!
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 359, in _async_add_entity
    await entity.async_device_update(warning=False)
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 466, in async_device_update
    await task
  File "/usr/local/lib/python3.8/concurrent/futures/thread.py", line 57, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/src/homeassistant/homeassistant/components/bmw_connected_drive/sensor.py", line 136, in update
    self._state = getattr(vehicle_state, self._attribute)
  File "/usr/local/lib/python3.8/site-packages/bimmer_connected/state.py", line 125, in __getattr__
    return self.vehicle_status.attributes[item]
KeyError: 'fuelPercent'

Thanks for pointing this out, will have a look at creating a upstream release and updating the dependency.

Thanks for pointing this out, will have a look at creating a upstream release and updating the dependency.

Still open as we need a new release. Just waiting for #262 to be merged as well.

Still open as we need a new release. Just waiting for #262 to be merged as well.


Replaced WIndows-only code and rebuilt to include Linux binaries

After making a couple of changes to what were Windows-only code bits, I rebuilt the CB libraries.  For Linux builds, I used WSL2 Ubuntu.

Added e192ce8 commit after testing in linux and finding that a vfsmirror.c function was using backslash when building paths.


React-Boilerplate issues - AppBar & Add Docs?

Hey all,
I have some serious issues with react-toolbox in combination with react-boilerplate.

The main problem is, that none of the projects contain an exact tutorial how to integrate into each other, what is definitely understandable. Since a lot of people are using react-boilerplate nowadays, maybe you folks could add another example add where you're integrating both of them and link that one from the docs?

There is a guide in the issues which describes how to integrate rect-toolbox into react-boilerplate here: https://github.com/react-toolbox/react-toolbox/issues/527#issuecomment-226996477 . Unfortunately this does not work for AppBar as described here: https://github.com/mxstbr/react-boilerplate/issues/474#issuecomment-249431952 Could you please have a closer look onto this?

Thanks and greetings from Germany!
Alex
cc @schubidu, @inyigo
References: https://github.com/react-toolbox/react-toolbox/issues/527 https://github.com/react-toolbox/react-toolbox/issues/753 https://github.com/mxstbr/react-boilerplate/issues/474 https://github.com/react-toolbox/react-toolbox/issues/725

I know about a guide but it's not published yet. @rubenmoya can help you out I think!

Yes, I wrote a small guide when I was trying to integrate it myself, there you go: Using React Toolbox with React Boilerplate

@rubenmoya That article is very helpful, however, when I try to create a theme.css with the following contents:
@import '~react-toolbox/lib/colors';

$color-primary: $palette-red-500;
$color-primary-dark: $palette-red-700;

I'm getting ModuleNotFoundError: Module not found: Error: Can't resolve '~react-toolbox/lib/colors'.
I mostly had react-toolbox working, already, but there were a few oddities which your guide fixed. If I can figure out how to import the colors for a theme.css, that would be perfect.

I think you don't need the ~. Postcss imports works nicely with your node modules

@javivelasco That works, but it doesn't actually set the theme values. Even if I include @import '../../theme/_theme.css'; to the styles.cssof the app container, or any container.

@stephengfriend I guess that's because you're using sass variables, I don't really know how to override the css-next variables, but you can change the color overriding the class instead:
@import 'react-toolbox/lib/colors';

.appBar {
  background: var(--palette-red-500);
}

@rubenmoya I was able to change the background, using your example. I was really hoping to be able to set a global theme and then override where necessary. Similar to the examples in the react-toolbox Readme. If you happen to figure this out, I would love to know. I will continue to work on it and if I figure it out, I will report back.

@rubenmoya your fork repository is not working and I got : TypeError: Element from loaders list should have one of the fields 'loader' or 'loaders' error.
I know your position about Sass but this result on manual css override and on slow devices the default themes css appears in first place after being replaced by custom changes...

Damn, yesterday the sass integration of react-toolbox with react-boilerplate worked.
I was able to override the default theme variables for the app_bar component and make the post-css and sass loader cohabit. This was very helpful to erase flashing color on the element load.
But, the production build of react-boilerplate failed just after having generated the final resources. And I think this was because of the double sources type of assets managed in the application.
So I struggled with the webpack production config to pass the production build without errors and this didn't worked.
And now, the solution I found (crawling the entire issues about the subject) doesn't work anymore...
@rubenmoya, when I checkout your fork project I got a webpack loader error :
TypeError: Element from loaders list should have one of the fields 'loader' or 'loaders'
What a pain...
Working on a dev branch to use postcss integration (that doesn't integrate correctly with react-boilerplate) and being unable to override variables is not satisfaying at all.
Lack of good documentation there.

Hi @anthonyvialleton, I pushed a change in the repo to fix that error, check it out!

There is no need for a complex Webpack setup. This covers every case so this issue can be closed.

Check react-toolbox-themr. For now it works from 2.0.0-beta.4


Apply new resource extensions in integration tests

https://github.com/KatanPanel/yoki/runs/4813105503?check_suite_focus=true
Failed because Network resource extensions were changed

Fixed in https://github.com/KatanPanel/yoki/commit/c6d7c611eff708802a73f40e744607dc9af95813.


Wish 225 missing

Stops at wish 224.

Fixed in https://github.com/rvazarkar/NGUInjector/commit/3d3a6df244fe5eebdd59297166878c2c9901d5d4


Download PDF is broken

I cannot download this via PDF.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0a922f18-55a1-cf8d-732e-8420b5466187
Version Independent ID: f70e2d11-4920-b88b-92b2-f3124f4ac8d5
Content: Continuous Testing
Content Source: docs/build-release/test/index.md
Service: unspecified
GitHub Login: @douge
Microsoft Alias: ahomer

@BrianMinister PDF download looks like it is down for the whole site, I am filing a support ticket and I'll update you when it is fixed. Thanks for letting us know.

@BrianMinister Our ops team is working the ticket now and should be resolved soon.

@BrianMinister It's fixed, you should be able to download the PDF of the docs for this area (and the other VSTS areas as well). Thanks again for letting us know about this.


fix: Type error in PaginatorProps

I see how the repo has migrated, but there's no desc. on the new repo and it doesn't seem like ready to migrate. It'd be nice to keep support here minimally while you do the full migration and prepare a readme with changes in https://www.npmjs.com/package/@ajna/pagination


Need help: what does set_params_op do?

When I read the code at line 190 of file logisticRegressionWithLBFGS.py as follows:
self.sess.run(self.set_params_op, feed_dict=params_feed_dict).
I am curious what exactly does it do? It does not return a value. If I commented it, the log message printed by self.print_model_eval() changed. Would someone please explain?

My conclusion is the code assign the values of weights from logistic regression classifier to networks which will be used in inference() from the file logisticRegressionWithLBFGS.py

Sounds true


Cannot verify address using Coldcard Q

I imported a Liana Taproot descriptor into a Coldcard Q. The descriptor was not registered by Liana into the Coldcard but instead imported using "Settings>Miniscript>Import"
I can sign transactions with it just fine using Liana v8.0.0 however I cannot get it to verify addresses:

Ah! I guess it's related to the "name" of the descriptor? The team will get
back to you.
You should be able to derive the addresses directly on the CC to check
them, in the meantime.
It is on the Edge firmware, correct?
On Thu, Nov 28, 2024, 17:33 Antoine Le Calvez @.***>
wrote:

I imported a Liana Taproot descriptor into a Coldcard Q. The descriptor
was not registered by Liana into the Coldcard but instead imported using
"Settings>Miniscript>Import"
I can sign transactions with it just fine using Liana v8.0.0 however I
cannot get it to verify addresses:
Screenshot.from.2024-11-28.19-23-13.png (view on web)
https://github.com/user-attachments/assets/bd06de3b-6504-46df-837c-f39a62072229
—
Reply to this email directly, view it on GitHub
https://github.com/wizardsardine/liana/issues/1490, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADWNZE4U2DBA6HEDMPHRHVL2C5OW7AVCNFSM6AAAAABSVVVHWOVHI2DSMVQWIX3LMV43ASLTON2WKOZSG4YDEOJUGQ4TSMA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Ah! I guess it's related to the "name" of the descriptor? The team will get
back to you.
That’s my theory too, using a Ledger, the wallet is called "Liana-$checksum" but it’s only "$checksum" on the CC.

It is on the current Edge firmware.


Accents other than British

The language model being used seems to predominantly produce British sounding output, even when the input is distinctly American.
Is there any way to add some sort of weight to the model or choose a different model?

True, but we have no way of influencing the model. You can however fine-tune on a specific voice.


[PublishBuildArtifactsV1] Delete hardcoded "/E" option not to copy subdirectories

Task name: PublishBuildArtifactsV1
Description:
Delete from robocopy call hardcoded "/E" option and replace it with variable. This variable will contain "/E" option if "PathToPublish" is not a file, and it will be empty string in case "PathToPublish" is file
Documentation changes required: (Y/N) N
Added unit tests: (Y/N) N
Attached related issue: (Y/N) #14984
Checklist:

[x] Task version was bumped - please check instruction how to do it
[x] Checked that applied changes work as expected

@tatyana-kostromskaya, @anatolybolshakov  Could this be a breaking change for the customers who use this task with a current behavior?

@tatyana-kostromskaya, @anatolybolshakov Could this be a breaking change for the customers who use this task with a current behavior?

I discussed it with @anatolybolshakov. This behavior is not documented so we can consider these changes as bug fixing of unexpected behavior.


Backfill historical data

It'd be nice to provide the ability to collect historical metrics when possible. I've been tracking my zettelkasten in a git repository for about 4 years now, and I'd be very interesting to have all this historical data available for analysis.

Implemented in #1


OIDC auth does not use /.well-known/openid-configuration

OIDC auth does not use /.well-known/openid-configuration. We should use it to also support eg. Keycloak.
See https://github.com/owncloud/cdperf/blob/3b88374ca575e1086052fb7fff9cc77080651a43/src/lib/auth/openIDConnect.ts#L21-L23

Actually this is also quite outdated already. Nowadays we should prefer the webfinger endpoint over the <ocis-url>/.well-known/openid-configuration for IDP discovery.


SuggestedFixes.renameMethodInvocation renames parameters with names matching the method

ATTENTION! Please read and follow:

if this is a question about Error Prone, send it to<EMAIL_ADDRESS>if this is a bug or feature request, fill the form below as best as you can.

Description of the problem / feature request:
SuggestedFixes.renameMethodInvocation(tree, "updated", state) results in:
- obj.foo(bar, foo);
+ obj.foo(bar, updated);

Feature requests: what underlying problem are you trying to solve with this feature?
See above, methods are rewritten incorrectly.
Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.
See above example.
What version of Error Prone are you using?
2.3.4
Have you found anything relevant by searching the web?
no.

Thanks for the report. Sent out a fix internally.

This was fixed by https://github.com/google/error-prone/commit/b7f7883b5eb93d1cc8fc881cfce69bac4f46d98c.


Activity types aren't respected in Send Activity / LG

Describe the bug
When providing an Activity structure in a LG response which changes the Type it's ignored and always sent as a message

Results in the following which is incorrect:

Expected behavior

Able to control the Activity type, for example an event or handoff

[Activity
Name = eventActivity
Value = eventValue
Type = event
]

Whilst that helps for the event type - any other type is ignored as detailed above. e.g. if you set type to "handoff" it is ignored silently.

Whilst that helps for the event type - any other type is ignored as detailed above. e.g. if you set type to "handoff" it is ignored silently.

Yes. "handoff" is not supported . This is an known issue and tracked in SDK .


python stdio process speedup

find ways to make it faster

small optimizations in data passing
https://github.com/giuliojiang/pbrt-v3-IISPT/pull/32


Update the libfuzzer dependency & fuzz README

The fuzzer dependency at https://github.com/rust-fuzz/libfuzzer-sys.git is archived & unmaintained.
This updates it to the new address of the maintained project & updates the README after it introduced two distinct binaries in the fuzz crate.

@bors-libra r+
Good to see you @huitseeker!

:pushpin: Commit ecbb2cb has been approved by bmwill

:hourglass: Testing commit ecbb2cb4412f54c6653c5d29295c456680fa5194 with merge bc702a79c23fdce0d5c0ab572094b9ea345527fa...

:sunny: Test successful - checks-circle_commit_workflow
Approved by: bmwill
Pushing bc702a79c23fdce0d5c0ab572094b9ea345527fa to master...


feat: replacing HashMap with LinkedHashMap

If you have the code to generate a resourcepack and you call the Creative methods in the same order, with the same inputs, you will end up with different resourcepacks in two runs.
This pull request fixes the problem by replacing all HashMap with LinkedHashMap

Good 👍🏽
Some tests would be good too

@Spliterash opened a PR to this PR in your fork to fix some missed maps and sets
https://github.com/SkolkovoLab/creative/pull/2


derive: Add #[automatically_derived] attr

Although maybe synstructure should do this, and I should file an issue there

Done in 91e4630d31abd2455b8b96b9c33bd144fd4305a0

But #24 is where this pays off, and that can never land :(


NUTCH-2959 -- upgrade Tika to 2.9.0

Thanks for your contribution to Apache Nutch! Your help is appreciated!
Before opening the pull request, please verify that

there is an open issue on the Nutch issue tracker which describes the problem or the improvement. We cannot accept pull requests without an issue because the change wouldn't be listed in the release notes.
the issue ID (NUTCH-XXXX)

is referenced in the title of the pull request
and placed in front of your commit messages surrounded by square brackets ([NUTCH-XXXX] Issue or pull request title)

commits are squashed into a single one (or few commits for larger changes)
Java source code follows Nutch Eclipse Code Formatting rules
Nutch is successfully built and unit tests pass by running ant clean runtime test
there should be no conflicts when merging the pull request branch into the recent master branch. If there are conflicts, please try to rebase the pull request branch on top of a freshly pulled master branch.
if new dependencies are added,

are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
are LICENSE-binary and NOTICE-binary updated accordingly?

We will be able to faster integrate your pull request if these conditions are met. If you have any questions how to fix your problem or about using Nutch in general, please sign up for the Nutch mailing list. Thanks!

I'll merge this in a day or so unless anyone has objections.

Converting to draft to manually check for version conflicts.

I bumped some of the more common dependencies to match Tika 2.9.0.  Let me know what you think.

afaics, no issues when running in local mode
in pseudo-distributed mode there is an issue with the commons-io versions: 2.8.0 provided by Hadoop (3.3.6) and 2.13.0 requested by Tika (and crawler-commons)

I've fetched and parsed the Tika standard parsers test documents (see test_tika_parser.sh): the following error appears 44 times in the fetcher (during MIME detection) and 467 during parsing:java.lang.NoSuchMethodError: 'org.apache.commons.io.input.CloseShieldInputStream org.apache.commons.io.input.CloseShieldInputStream.wrap(java.io.InputStream)'

@tballison, any idea how to circumvent this error? Hadoop 3.4.0 will upgrade to commons-io 2.11.0 (HADOOP-18301).

Weird, I just pushed a commit bumping commons-io on my NUTCH-2959 branch, and it isn't showing up in the PR...  I'll wait a bit... Maybe github is out for coffee?

I haven't worked with ant in a while.  According to ant dependencytree, it looks like we don't have to exclude commons-io everywhere -- placing it in the main ivy.xml has the same effect as putting it in  in maven. It applies throughout.
I wanted to document this in case dependencytree isn't showing what's actually happening. :D

I'm guessing that commit won't work if distributed hadoop is bringing its own jars (as you said!).  Does hadoop do any custom classloading so that the job jars are isolated from the runtime jars?
Or, more simply, notionally, should the above commit work?  Or is that a non-starter?

I'm getting a ConnectException when I try to run nutch-test-single-node-cluster.
On hadoop startup, I see:
2023-09-19 10:25:15,186 INFO util.GSet: VM type       = 64-bit
2023-09-19 10:25:15,187 INFO util.GSet: 0.029999999329447746% max memory 7.7 GB = 2.4 MB
2023-09-19 10:25:15,187 INFO util.GSet: capacity      = 2^18 = 262144 entries
Re-format filesystem in Storage Directory root= /tmp/hadoop-tallison/dfs/name; location= null ? (Y or N) y
2023-09-19 10:25:17,593 INFO namenode.FSImage: Allocated new BlockPoolId: BP-993805694-<IP_ADDRESS>-1695133517585
2023-09-19 10:25:17,594 INFO common.Storage: Will remove files: [/tmp/hadoop-tallison/dfs/name/current/fsimage_0000000000000000000.md5, /tmp/hadoop-tallison/dfs/name/current/VERSION, /tmp/hadoop-tallison/dfs/name/current/fsimage_0000000000000000000, /tmp/hadoop-tallison/dfs/name/current/seen_txid]
2023-09-19 10:25:17,625 INFO common.Storage: Storage directory /tmp/hadoop-tallison/dfs/name has been successfully formatted.
2023-09-19 10:25:17,648 INFO namenode.FSImageFormatProtobuf: Saving image file /tmp/hadoop-tallison/dfs/name/current/fsimage.ckpt_0000000000000000000 using no compression
2023-09-19 10:25:17,705 INFO namenode.FSImageFormatProtobuf: Image file /tmp/hadoop-tallison/dfs/name/current/fsimage.ckpt_0000000000000000000 of size 403 bytes saved in 0 seconds .
2023-09-19 10:25:17,718 INFO namenode.NNStorageRetentionManager: Going to retain 1 images with txid >= 0
2023-09-19 10:25:17,744 INFO namenode.FSNamesystem: Stopping services started for active state
2023-09-19 10:25:17,744 INFO namenode.FSNamesystem: Stopping services started for standby state
2023-09-19 10:25:17,747 INFO namenode.FSImage: FSImageSaver clean checkpoint: txid=0 when meet shutdown.
2023-09-19 10:25:17,747 INFO namenode.NameNode: SHUTDOWN_MSG:
/************************************************************
SHUTDOWN_MSG: Shutting down NameNode at tallison-XPS-9320/<IP_ADDRESS>
************************************************************/
+ set -e
+ /opt/hadoop/3.3.6/sbin/start-dfs.sh
Starting namenodes on [localhost]
localhost: ssh: connect to host localhost port 22: Connection refused
Starting datanodes
localhost: ssh: connect to host localhost port 22: Connection refused
Starting secondary namenodes [tallison-XPS-9320]
tallison-XPS-9320: ssh: connect to host tallison-xps-9320 port 22: Connection refused
+ /opt/hadoop/3.3.6/sbin/start-yarn.sh
Starting resourcemanager
Starting nodemanagers
localhost: ssh: connect to host localhost port 22: Connection refused

I can navigate to http://localhost:8088/cluster/nodes and I see that there are zero nodes.
I cannot navigate to http://localhost:9870/.
When I try to run the test_tika_parser.sh, I see:
+ hadoop fs -mkdir -p crawl/seeds_tika/
mkdir: Call From tallison-XPS-9320/<IP_ADDRESS> to localhost:9000 failed on connection exception: java.net.ConnectException: Connection refused; For more details see:  http://wiki.apache.org/hadoop/ConnectionRefused

This is Ubuntu with java 11.
Any ideas what I'm doing wrong?

Btw., I've just rediscovered that using Tika in (pseudo)distributed mode is broken since the upgrade to Tika 2.3.0, see NUTCH-2937. Although, it didn't seem to have affected the MIME detector.

Oh, dear...

Need to set up passphraseless ssh.
Thank you!

Oh, dear...

Would need to wait for Hadoop 3.4.0, then we get commons-io 2.11.0 into the classpath. See also the discussion in apache/hadoop#4455.

Should we merge on the theory that we're already broken and we aren't breaking things any worse?  Or do we just punt until 3.4.0 is available?

Should we merge on the theory that we're already broken and we aren't breaking things any worse? Or do we just punt until 3.4.0 is available?

Let me check whether the MIME detection works with Tika 2.3.0. I'll run the same test script with master which includes Tika 2.3.0...

In the latest commit, I downgraded commons-io to be what we're hoping for in Hadoop 2.4.0

I checked https://issues.apache.org/jira/browse/TIKA-3655, and it looks like we'd have to downgrade to Tika 2.2.1 (December 2021, released during the log4shell fun) to get a working distributed version.

Ok, here the results:

Tika 2.3.0 (current Nutch master)

fetching: not a single NoSuchMethodError
parsing: only one NoSuchMethodError because of CloseShieldInputStream.wrap(...) (when parsing testTMX.tmx)

ParserStatus
    failed=85
    success=624

Tika 2.9.0

fetching: 44 of NoSuchMethodError
parsing: 467 of NoSuchMethodError

ParserStatus
   failed=526
   success=139

Or do we just punt until 3.4.0 is available?

This seems the better. Even then (and if successfully tested with 3.4.0): warn users that they need Hadoop 3.4.0 to run Nutch and esp. parse-tika.

I suggest that we downgrade to Tika 2.2.1 to fix that regression.

Converting this to draft until Hadoop 3.4.0 is released.

I suggest that we downgrade to Tika 2.2.1 to fix that regression.

Good point, @lewismc. I've opened NUTCH-3006 for that.

Paging the nutch-test-single-node-cluster helpdesk.... what do I use for the tika seeds file?  Are you using our github repo, or the tika-parsers-common package specifically?  Or something else? Sorry!
+ hadoop fs -copyFromLocal seeds_tika.txt crawl/seeds_tika
copyFromLocal: `seeds_tika.txt': No such file or directory

Try the full path
Also make sure the directory exists on HDFS
On Thu, Sep 28, 2023 at 14:03 Tim Allison @.***> wrote:

Paging the nutch-test-single-node-cluster helpdesk.... what do I use for
the tika seeds file? Are you using our github repo, or the
tika-parsers-common package specifically
https://github.com/apache/tika/tree/main/tika-parsers/tika-parsers-standard?
Or something else? Sorry!

hadoop fs -copyFromLocal seeds_tika.txt crawl/seeds_tika
copyFromLocal: `seeds_tika.txt': No such file or directory

—
Reply to this email directly, view it on GitHub
https://github.com/apache/nutch/pull/776#issuecomment-1739999655, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAI4TF5FHFFNK6PZRRL3FALX4XQYXANCNFSM6AAAAAA4YQQNCM
.
You are receiving this because you were mentioned.Message ID:
@.***>

what do I use for the tika seeds file? Are you using our github repo, or the
tika-parsers-common package specifically

see the comments in test_tika_parser.sh

With the update to Tika 2.9.1-SNAPSHOT, I get 85 failed parses, most of them are either encrypted documents or "can't retrieve Tika Parser for x"
parse-segment-error-parsing.txt
There is still one NoSuchMethodError, also from commons-io, but this time UnsynchronizedByteArrayInputStream$Builder: at org.apache.tika.parser.pdf.PDFEncodedStringDecoder.decode(PDFEncodedStringDecoder.java:85)

see the comments in test_tika_parser.sh

Sorry! Yep, saw that too late.

I reverted back to 2.2.1, and that's not far enough back -- there were 222 parse failures many with the wrap problem.  I reverted back to 2.0.0, and then had 85 parse failures again.  This time, no wrap problems, just the "can't retrieve parser" and encrypted doc exceptions.

There is just no winning...
We just upgraded POI to 5.2.4, and it uses a bunch of the newer commons-io methods.  If we downgrade POI to 5.2.3, we get a clean build of Tika with commons.io=2.8.0
Can we do anything with shading?  I don't think this will work...
So, it looks like we downgrade Tika to 2.0.0 in nutch, or we make a release of Tika 2.9.1 with POI 5.2.3 and then give up until hadoop upgrades

Even worse, POI 5.2.4 uses features of commons-io > 2.11.0.  This means that POI won't work in hadoop 3.4.0.

Stepping away from the keyboard. :sob:

Alright, the only thing that I think might work is Tika shading commons-io in tika-app, and then Nutch uses tika-app instead of the individual parser-modules etc. for parser-tika.
WDYT?

Tika shading commons-io in tika-app, and then Nutch uses tika-app instead of the individual parser-modules etc. for parser-tika.

And what about the dependency on tika-core in Nutch core, which is used for MIME detection?

That should be ok if we remove CloseShieldInputStream.wrap() from tika-core (and may as well modify all of Tika).

Local build of the shim works with 2.9.1-SNAPSHOT, which includes the latest version of POI which will conflict with commons-io in 3.4.0 if we don't use this shim (and/or if Hadoop doesn't upgrade commons-io further).
ParserStatus
failed=82
success=627
I'll downgrade Tika to 2.9.0 and push a shim release to maven central.

I published the shim artifacts for: https://github.com/tballison/hadoop-safe-tika
It looks like they haven't made it into the main maven repositories yet. :(
Once they do, I think this PR and the hadoop-safe-tika shim will be ready for review.
This represents an ugly work-around, but I did get a clean build locally, and I ran @sebastian-nagel 's nutch-test-single-node-cluster tika tests.
One area for improvement might be to exclude the dependencies from the shim that Nutch already pulls in, like guava, for example.
The release process for the shim is quite easy.  Happy to do that if necessary.

Thank you so much @sebastian-nagel !


list evaluation behaves weirdly

On IOS (Ipad), if I run
(display (cdr (list 1 2 3 4)))
I expect to have (1 2 3).
LispPad says
[eval error] cannot apply arguments to (1 2 3 4)
> (cdr (1 2 3 4)) <- (<repl> ...)

Racket in both sicp and vanilla syntax works no problem. I noticed other situations where cons and list behave differently. Even though the mechanics behind them is different, my understanding is that the behaviour should be the same (but maybe it's just me).
This may have to go to LispKit, but I don't have MacOS to test it.
P.S. It's a great app to study SICP on the go! So using it, thanks!

I am unable to reproduce this. It appears that you are executing this line of code in a context where cdr is defined differently.
When I start up LispPad Go on my iPhone, this is what I get:
> (display (cdr (list 1 2 3 4)))
(2 3 4)

Hi, I must have defined the library functions somewhere, when doing SICP. Closing.


Stream settings: Last non-guest user cannot unsubscribe from private streams

This prevents the last non-guest user in a private stream to be unsubscribed from the stream.
Error is shown when last non-guest user tries to unsubscribe and the option of unsubscribe is removed from the stream popover in this case.
Fixes #11962

Testing Plan:
I have tested manually and have also written tests.
GIFs or Screenshots:

@timabbott you can take a look at this PR.

@timabbott Please take a look at this PR once if you are free.

@timabbott This PR is ready for review.

@timabbott you can review this PR once.

@timabbott this PR is ready for review.

@timabbott please review this PR.

Wouldn't it be better to warn the user that unsubscribing will trigger a stream deletion, and then delete it when they go through with it?
Preventing the last user from unsubscribing will prevent the private stream from getting abandoned, but it's not very user friendly.
If the last user is trying to leave, the stream is dead. Let's delete it.

I agree that this PR does not handle the case when the user subscribing is the last user itself.
I had this in my mind but this PR was not being worked on as we were working on stream admin feature and last stream admin is not allowed to unsubscribe, probably also handling the case of stream deletion (not sure about this though, will add it if not already done).
Thanka for the feedback and for reminding about the stream deletion case!!

Does it make sense to close or redo or rebase this given our current plans with stream administrators no longer existing?

Got back to this while visiting my old PRs. Not sure how we will have the new settings based on group permission settings, but I guess it would be something like we would want to atleast keep one user who is allowed to add others to streams.
I can update the PR to make sure there is atleast one user who can add others to the stream.


gamnit: Blinn-Phong specular lighting, 3 axes of rotation and more

Implement a Blinn-Phong specular lighting shader to replace the previous Lamber diffuse lighting. It creates a reflection effect either from specular_color (as on the shields) or specular_texture (as on the gold tower).

The required material attributes for the specular effect were already present but not implemented. This PR adds similar attributes for normal maps, but leave them as a TODO. The new shader is fine but not optimal, I'll probably need to rewrite it to gain some performance, support normal maps and improve normals per vertex.
Add two angles of rotation to actors for full 3D rotation with Euler angles. All rotation angles follow the right-hand rule and are consistent between the camera and actors.
Other changes:

Intro Cuboid that can be created by Boxed3d::to_mesh.
Better error management when loading models.
Fix missing lock_cursor implementation on desktop. It allows creating FPS like cameras.
Fix and update angle_lerp to follow the style of lerp (where self is the weight).
Improve the template project so 3D objects don't blend in the background and explain the printed performance statistics.

In a future PR, I'll standardize the assets classes and move some service up to Asset. This would allow for easier loading of all assets at once, no matter their type, and offer a standard behavior regarding errors and lazy loading.

The tests fail only on the server rrmartin, they pass on tolkien: http://gresil.org/jenkins/job/CI_github/5186/

test this please

test this please


[$250] Android - Track expense - "It's not here" page shows up briefly when deleting a track expense

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.68-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5277524
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause Internal Team
Action Performed:
Precondition: Login to the Hybrid App with an Expensifail account.
Steps

Open self DM
Create a new track expense
Open the expense report
Click on the Header and click delete
Confirm the delete

Expected Result:
"It's not here" page will not show up when deleting a track expense.
Actual Result:
"It's not here" page shows up briefly when deleting a track expense.
Workaround:
Unknown
Platforms:

[x] Android: Standalone
[x] Android: HybridApp
[ ] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/262db4cf-bf54-4b64-8b04-078b0b906af6

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021862432764600523584
Upwork Job ID:<PHONE_NUMBER>600523584
Last Price Increase: 2024-11-29

Issue OwnerCurrent Issue Owner: @shubham1206agra

The not found shows because shouldShowNotFoundPage, contentShown.current, and isFocused is true.
https://github.com/Expensify/App/blob/decb6955b6f13c1c212f6ed7b70f9d24999cd42a/src/pages/home/report/withReportOrNotFound.tsx#L88-L93
I added the isFocused in https://github.com/Expensify/App/pull/51920 so we don't render null if the screen is still focused to fix https://github.com/Expensify/App/issues/51388. It's been deployed a month ago, so not sure what causes this. My guess is that, previously, when we delete the expense, the screen is blurred already before the report onyx data is deleted.
The comment stated

If the content was shown, but it's not anymore, that means the report was deleted, and we are probably navigating out of this screen.

which means the condition is actually not 100% reliable because we assume the user is probably navigating out of the screen. I think what we can do is delay the delete report similar to this recent PR.

Discussed in the slack thread, the user is not blocked by this issue so demoting, but we should try to fix it with urgency

We can delete track, expense/ios, and task, but the issue only happens on track and expense/iou.

Proposal
Please re-state the problem that we are trying to solve in this issue
"It's not here" page shows up briefly when deleting a track expense.
What is the root cause of that problem?
The RC of this issue comes from the fix implemented by this PR:

https://github.com/Expensify/App/pull/51920

specifically the added !isFocused check here:
https://github.com/Expensify/App/blob/1a6f48ea0e2139a82d0a96578badbf3f761bcf00/src/pages/home/report/withReportOrNotFound.tsx#L91
which when we delete the track expense is false (initially) -> causing the if to not pass -> resulting in the only passing if being the shouldShowNotFoundPage one here:
https://github.com/Expensify/App/blob/1a6f48ea0e2139a82d0a96578badbf3f761bcf00/src/pages/home/report/withReportOrNotFound.tsx#L99-L101
which renders the It's not here page in our case.
What changes do you think we should make in order to solve the problem?
Revert the changes implemented by PR https://github.com/Expensify/App/pull/51920 which would fix this issue and from my tests looks like the other issue (https://github.com/Expensify/App/issues/51388) would not be reproducible anymore even with the fix implemented by the offending PR being reverted.

[!note]
As one can note regarding the other issue's result video below, we do indeed see the Not found page briefly (similar to this issue) after reverting the fix but I don't consider that is an issue given we're in Debug mode. The main thing being that we're fixing this issue where we're not in Debug mode which the user will actually see more often than the other issue which requires Debug mode activated (which is mostly used by developers).
This is my proposal's tradeoff.

Results

Android (Native / mWeb)

Current issue
Other issue

https://github.com/Expensify/App/issues/51388 not only fixes the debug page issue, but also this case:

User A invite user B to a room
User B open the room details page
User A removes B from room
User B sees blank page

@shubham1206agra A way to fix https://github.com/Expensify/App/issues/51388 as well would be to remove the contentShown implementation and have the first if condition simply as:
                if (shouldShowNotFoundPage && !isFocused) {
                    return null;
                }

This would fix all 3 issues, with https://github.com/Expensify/App/issues/51388 looking like this once you are removed from a private room:
https://github.com/user-attachments/assets/91961d94-3b1d-4d59-b937-2d500bb1c739
If we're fine with the behaviour shown above in that issue's case then I leave it to you guys to decide whether we can move forward with this proposal.

This is a similar problem as stated in this issue. So I don't think we want to revive an old bug here.

@shubham1206agra The problem is that our current issue (this one) has the not found page showing because of the !isFocused check, which by the way - right now on staging if we test https://github.com/Expensify/App/issues/51388, we still see a not found page for a split second, meaning the contentShown implementation doesn't really work (at least not in this case).
That's why I suggested to simply remove it since we don't have a specific case which we know of that the contentShown implementation fixes / improves, and the only scenario where we still see the not found page is the Debug mode issue which being in Debug mode - shouldn't be a significant issue that we see the not found page for a split second (which we already see right now on staging even with the current implementation).

I already looked at implementations based on state but I did not want to propose that since we would increase the render count of all pages wrapped by withReportOrNotFound. I stand by the alternative solution detailed in https://github.com/Expensify/App/issues/53301#issuecomment-2508831685, let us know if you think that can be a working solution in this case and whether it passes all the test scenarios on your side.

PR will be opened in ~1 hour.

♻ Status update: PR has been open and ready for review for two days - awaiting review.

♻ Status update: PR has been open and ready for review for 4 days - still awaiting review from @shubham1206agra.

♻ Status update: PR is pending review once again after some code changes following first review.


Nascar Road Racing

This old game shows a very peculiar effect that appears both using DxWnd or using DDrawCompact.
When the 3D part of the race starts, the camera seems to be positioned below the road level with crazy effects of transparencies and invisible scenery.
That could easily accounted by a game bug, but the fact is that dropping the dgVoodoo2 dlls on the game folder everything works perfectly!
Have a look:

I get the same results with dgVoodoo2.
How did you get past the initial crash? The game creates a second primary surface while the first one is still alive, and that causes a crash for me. Multiple simultaneous primary surfaces were never supported by DDrawCompat. I worked around it by suppressing the creation of the second primary, which gets me to the race.
After that, I just see the same issue as with dgVoodoo2: game looks fine at first, until the camera goes under the map and then it looks like on your screenshot. Did you use some special dgVoodoo settings to get it working?

All my tests were done with DxWnd control (I didn't want to use compatibility modes to run the game on a 32bit desktop) so probably it was DxWnd taking care of the multiple primary open, since in emulation mode it opens a single real primary surface and returns to the application a virtual primary surface mapped on a offscreen memory surface.
I now notice that the game also tries to use overlays, so I'll make more tests because I'm adding to DxWnd a sort of overlay emulation (as you already read in my Godfather posts).
The game also seems to use multiple windows or something like that, because when the race starts I see only a black frame, but minimizing and restoring the window resumes the 3D scene.
But, finally, this was another oddity: the 3D scene starts with a "below-ground-level point of view" both with and without DDC, but curiously this doesn't happen when dropping in the game folder the ddraw.dll file from dgVoodoo2.
To answer your question, I used just the ddraw.dll file from dgVoodoo2.63.1, no configuration added.
Since the minimize-restore action is necessary also with DgVoodoo2, I couldn't tell if dgVoodoo2 fixes the initial "below-ground-level" phase by fixing some fow parameter or if it simply quickly skips all bogus frames, anyway I thought it may interest you. I'll do more accurate tests.

The camera issue looked like the physics issue found in modern day games due to excessive FPS. IIRC, the game has a frame rate setting inside the settings, which probably maxes out at 30. I fixed the "camera going under the map" issue by limiting the FPS to 30.


Uses of slice::from_raw_parts with input from FFI would need some manual pre-checks

The preconditions for slice::from_raw_parts contain the following:

data must be non-null and aligned even for zero-length slices. One reason for this is that enum layout optimizations may rely on references (including slices of any length) being aligned and non-null to distinguish them from other data. You can obtain a pointer that is usable as data for zero-length slices using NonNull::dangling().

When the preconditions are not fulfilled, a debug build will fail with the message

unsafe precondition(s) violated: slice::from_raw_parts requires the pointer to be aligned and non-null, and the total size of the slice not to exceed isize::MAX) at library\core\src\panicking.rs:220

and a release build may crash depending on what kind of optimizations the rust compiler allowed itself.
One way such thing can happen is when using the crc32 function like the following:
crc32(0, NULL, 0)

All the uses of slice::from_raw_parts should be audited as to whether the pointer/length pairs can originate from API user input in a similar way, and adjusted to make the preconditions met.

https://github.com/memorysafety/zlib-rs/pull/145 fixes the immediate issue with crc32/adler32 and NULL.  The NULL input is actually useful there because it gives the initial checksum value.
I'm working on other public-facing calls to unsafe functions (core::ptr::read and the from_raw_parts calls) and adding # Safety docs for the remaining functions.
In most cases the resonsibility of satisfying the preconditions just gets passed on to the caller, but for NULL in particular there is often (but not always) a special error that gets returned. So this requires some care to make sure we actually mirror the error output, and I plan to also return errors when stock zlib segfaults on NULL pointers.

On main, the public C api functions now all have a # Safety section that documents the assumptions the function makes. We also now have 100% branch coverage in that file, so edge cases (like NULL pointers) should be checked.
We return Z_STREAM_ERROR in some cases where stock zlib segfaults. Segfaults indicate UB so I believe that us returning a value is within the contract of the function.
Of course, these changes benefit from a second pair of eyes going over the assumptions.
Then there is of course also unsafe code internal to the library, but that already got tested (with miri too)/fuzzed a lot more.

now that the code has been audited, I think we've taken care of this.


Bug with GMatch4py if start with an other example

Hi,
I noticed that if I don't begin with the examples given in your document, GMatch4py fails and gives:
_

TypeError                                 Traceback (most recent call last)
 in
----> 1 result=ged.compare([Gx1, Gx2, Gx3],None)
2 print(result)
gmatch4py/ged/abstract_graph_edit_dist.pyx in gmatch4py.ged.abstract_graph_edit_dist.AbstractGraphEditDistance.compare()
gmatch4py/ged/abstract_graph_edit_dist.pyx in gmatch4py.ged.abstract_graph_edit_dist.AbstractGraphEditDistance.compare()
gmatch4py/helpers/general.pyx in gmatch4py.helpers.general.parsenx2graph()
gmatch4py/graph.pyx in gmatch4py.graph.Graph.init()
TypeError: Expected str, got int

_
If I begin with your example and do the same thing it works!

Hi @pkrezel,
Can you show me a sample of your graph ?
Best,
@Jacobe2169

Hi,
I attached a pickle containing the list of networkx graphs.
can you read it ?
[
LGx.zip
](url)

Hi,
it seems that the problem is linked with the definition of the attributes to be used:
ged.set_attr_graph_used("color", "weight")
I attached the new pickle with graphs containing "weight" as attribute.
LGx.zip

Hi,
I think it is a mistake coming from me.
In my case, I don't have to worry with "ged.set_attr_graph_used" because I want to use all the elements of the graph.
Best.


Fix issues with old pytest version in conda CI

This was already fixed for azure in 364c09c8af4eb1b3755ca4cbcc325c66dbd2bcd2, but seems to have come back for travis.

Seems to have solved the issue, the conda runs are no longer failing with errors about tmppath


Integration with VisiData

Hi,
I have discovered VisiData and I think it could be a great frictionlessdata reader and writer.
It is a free, open-source tool that lets you quickly open, explore, summarize, and analyze datasets in your computer’s terminal and it's writter in Python. A good starting point is this guide of Jeremy Singer Vine.
I'm not able to work on this kind of Python tasks and than I have written an issue in VisiData repo to ask to integrate datapackage in it. I have had this reply from @saulpw its creator:

Sure, I like the idea! This should not be hard for someone familiar with the format to create a loader. If you know of anyone who would like to collaborate, I'm sure we can get something working in an afternoon (or two at most).

I think it could be "win, win, win". For VisiData, for dissemination and use of datapackages and for all open data community.
Thank you

@lwinfree
I moved it to the framework

DONE in<EMAIL_ADDRESS>- https://framework.frictionlessdata.io/docs/console/explore.html

Hi @aborruso,
I think the reason is the missing dependency - https://framework.frictionlessdata.io/docs/console/explore.html#installation
pip install frictionless[visidata]

Also, the CLI output seems to be hiding the real reason "Please install 'frictionless[visidatta]'" - I created an issue for it https://github.com/frictionlessdata/framework/issues/1464

I think the reason is the missing dependency - framework.frictionlessdata.io/docs/console/explore.html#installation

I know, I have installed it.
I have:

saul.pw/VisiData v2.11
fr 5.10.0
and installed 'frictionless[visidata]'

If I try using a file and not zenodo, it works


Add Kafka.  Because.

This will be a great addition to this project.

:+1:
every project needs kafka.
really, it should have been included before product gave the feature requirements

Any news on this? I'm told we need Kafka at any cost.

We can implement it at no cost, in no time at all...


Guidelines for updating/upgrading

Hi,
As an enhancement, tt could be very useful to provide some guidelines regarding update/upgrade procedure.
Regards,

Hi,
Indeed,  we will provide it as soon as possible.
In the meanwhile, to resume the main task consists in merging.


Sample and formatting fixes

Addressing LiveFyre comments for the page
https://docs.microsoft.com/en-us/dotnet/framework/wpf/advanced/dependency-properties-overview
such as:
Code incomplete in this page
public static readonly DependencyProperty IsSpinningProperty =
DependencyProperty.Register(
"IsSpinning", typeof(Boolean),
We'll have to find a way to identify all topics that used to "concatenate" samples in DxStudio
Use rich diff to see what actually changed.
Internal review URL

@rpetrusha that's what I'm fixing. The link you posted is the live version. review has the fix: https://review.docs.microsoft.com/en-us/dotnet/framework/wpf/advanced/dependency-properties-overview?branch=pr-en-us-3060

It's another migration issue that I need to open an issue for. We'll need to find all references that use to refer to multiple snippets with commas. In DxStudio, that would cause the snippets to be rendered consecutively with ... in the middle to abstract part of the code.


Help accessing the passer wheel

I can't recall what e-mail address I had used to register on pypi, it's been a few years!
I want to resume work on https://github.com/affixalex/passer which is the original repository responsible for https://pypi.org/project/passer/ and I've created a new PyPi account with the username affixalex.
Could you add my new account as a maintainer on that wheel?

Hi @affixalex, the email address is the just current maintainer's user name at gmail. You should be able to reset the password and make the changes yourself.

Closing as I assume this was resolved, if not feel free to add another comment.


Animation support.

Just opening a PR to help track what's left to do.
I've started testing this with some real animated models exported from Blender. So far so good, but we're missing support for accessors with normalized integer component types which I might add, but that hasn't been a problem so far.
Regression tests are also needed too I suppose.

In the spirit of the higher-level nature of the library, I also thought it best to remove AnimationSamplers from the adapted Animations and inlined the loaded buffer data for each of the animation Channels' transformations. It's a one to one relationship (I think) between AnimationChannels and AnimationSamplers, so it felt okay.

It's a one to one relationship (I think) between AnimationChannels and AnimationSamplers, so it felt okay.

I'm not sure I agree with this. There are some counterexamples here: https://registry.khronos.org/glTF/specs/2.0/glTF-2.0.html#animations. However,

I also thought it best to remove AnimationSamplers from the adapted Animations and inlined the loaded buffer data for each of the AnimationChannels' transformations.

I still think this is fine. The worst case is we'll have some duplicated data

This implementation is still missing support for sampler outputs that use normalized integers instead of just floats, namely rotations and weights.
See the last two tables in the section linked for more details.
https://registry.khronos.org/glTF/specs/2.0/glTF-2.0.html#animations

Tests are failing with:
Failures:

  test/Text/GLTF/Loader/Internal/AdapterSpec.hs:315:3:
  1) Text.GLTF.Loader.Internal.Adapter.runAdapter Runs a basic GlTF adapter
       uncaught exception: RecConError
       test/Text/GLTF/Loader/Internal/AdapterSpec.hs:(315,3)-(324,5): Missing field in record construction gltfAnimations

  To rerun use: --match "/Text.GLTF.Loader.Internal.Adapter/runAdapter/Runs a basic GlTF adapter/"

  test/Text/GLTF/Loader/Internal/AdapterSpec.hs:315:3:
  2) Text.GLTF.Loader.Internal.Adapter.adaptGltf Adapts a basic GlTF
       uncaught exception: RecConError
       test/Text/GLTF/Loader/Internal/AdapterSpec.hs:(315,3)-(324,5): Missing field in record construction gltfAnimations

  To rerun use: --match "/Text.GLTF.Loader.Internal.Adapter/adaptGltf/Adapts a basic GlTF/"

Randomized with seed<PHONE_NUMBER>

@mrehayden1 How are you feeling about this? Are you ready to merge this?

@sgillespie I've got a branch that adds skinning support too to merge in also now the PR to matrices is merged. Can we do it here or shall I open another PR?

A preview of how animations and skinning are working.
https://github.com/sgillespie/haskell-gltf-loader/assets/547652/5374229b-5f90-46b7-9f12-3caf1a78a299

@sgillespie I've got a branch that adds skinning support too to merge in also now the PR to matrices is merged. Can we do it here or shall I open another PR?

I'll leave that up to you--whatever is easier for you

I've opened a new PR for skinning.

Great! If you resolve the conflicts here, I'll merge

I think i pushed a merge commit before. Did that not resolve any conflicts?

I think i pushed a merge commit before. Did that not resolve any conflicts?

Ah, there's a merge commit, that's why I can't rebase. No worries, I'll do a regular merge

I think i pushed a merge commit before. Did that not resolve any conflicts?

Ah, there's a merge commit, that's why I can't rebase. No worries, I'll do a regular merge

Thanks!
I'll make sure to rebase next time.


[MINOR] fix output of doctest in internal.py

While I'm taking a look & reminding the internal.py, fixed some words and output of doctests.

While I'm here, let me find if there is also minor fixes in other related files.

Codecov Report

Merging #1557 into master will decrease coverage by 2.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1557      +/-   ##
==========================================
- Coverage   94.15%   92.02%   -2.13%
==========================================
  Files          38       38
  Lines        8600     8600
==========================================
- Hits         8097     7914     -183
- Misses        503      686     +183

Impacted Files
Coverage Δ

databricks/koalas/internal.py
96.71% <ø> (ø)

databricks/koalas/usage_logging/__init__.py
25.00% <0.00%> (-69.65%)
:arrow_down:

databricks/koalas/usage_logging/usage_logger.py
50.00% <0.00%> (-50.00%)
:arrow_down:

databricks/koalas/__init__.py
78.43% <0.00%> (-13.73%)
:arrow_down:

databricks/conftest.py
88.67% <0.00%> (-7.55%)
:arrow_down:

databricks/koalas/frame.py
92.72% <0.00%> (-3.04%)
:arrow_down:

databricks/koalas/namespace.py
84.49% <0.00%> (-1.61%)
:arrow_down:

databricks/koalas/generic.py
95.09% <0.00%> (-1.51%)
:arrow_down:

databricks/koalas/plot.py
93.33% <0.00%> (-0.96%)
:arrow_down:

databricks/koalas/utils.py
95.41% <0.00%> (-0.92%)
:arrow_down:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 550e30c...76f5acb. Read the comment docs.


Fix high CPU usage in FluentDataGrid by leveraging an ExpressionCache

An ExpressionCache is added and used to prevent the FluentDataGrid from using Compile on Expression<Func<>> for every TemplateColumn tooltip. Fix #1621

Merging this one to enable Aspire team to test this in preview package


Implement code that instructs the "DNS module" to create the apptoptiate txt records

To pass the let's encrypt challenges, we need to interface with the route53 module and create the txt records to pass the challenges
Next, we are going to wait and poll the DNS server to verify record propagation

This is implemented now.


Update README.md

I was stumped for a while because my queues were not being created when I named them queue1.fifo in the config file.  This is because the . is used to delineate parameter names.
Feel free to edit this if there is a way to actually escape the ., but I could not find that solution.

Found this: single underscore(_) is converted into a dot(.)


Support multiple input arguments

It would be nice to be able to pass multiple arguments to the server action, this would make it easier to pass additional arguments with the bind method as this can be done with server actions normally.
For reference: https://nextjs.org/docs/app/building-your-application/data-fetching/server-actions-and-mutations#passing-additional-arguments

Hi, if you are using useServerAction with an action with type as formData, you can pass in additional data in the second argument of the execute method.

Still thinking about a bind solution, but lmk if this solves your problem.

Hi, just made a release to hopefully make this easier. Please try upgrading to<EMAIL_ADDRESS>and checkout these docs
Going to close this issue for now -- lmk if this still doesn't solve your problem.