New serviceMonitor does not show up in prometheus

What did you do?
Added a new serviceMonitor in  values.yaml for kube-prometheus
    - name: kube-prometheus-nginx-ingress
      selector:
        matchLabels:
          app: nginx-ingress
      endpoints:
        - port: metrics
          interval: 30s
      namespaceSelector:
        any: true

What did you expect to see?
I'd expect to see kube-prometheus-nginx-ingress show up under targets in Prometheus and that Prometheus started scarping the targets.
What did you see instead? Under which circumstances?
No new targets where added and kube-prometheus-nginx-ingress does not show up in the prometheus configuration. The serviceMonitor is created but not "applied".
$ kubectl get servicemonitor kube-prometheus-nginx-ingress
NAME                            AGE
kube-prometheus-nginx-ingress   11m

Environment

Kubernetes version information:

kubectl version
Client Version: version.Info{Major:"1", Minor:"8", GitVersion:"v1.8.3", GitCommit:"f0efb3cb883751c5ffdbe6d515f3cb4fbe7b7acd", GitTreeState:"clean", BuildDate:"2017-11-08T18:39:33Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"8", GitVersion:"v1.8.6", GitCommit:"6260bb08c46c31eea6cb538b34a9ceb3e406689c", GitTreeState:"clean", BuildDate:"2017-12-21T06:23:29Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"linux/amd64"}

Kubernetes cluster kind:
KOPS on AWS

Manifests:

prometheus:
  rbacEnable: false
  alertingEndpoints: []
  config:
    specifiedInValues: true
    value: {}
  externalUrl: ""
  image:
    repository: quay.io/prometheus/prometheus
    tag: v2.0.0

  ingress:
    enabled: false
    annotations: {}
    fqdn: ""
    tls: []
  nodeSelector: {}
  paused: false
  replicaCount: 1
  resources: {}
  retention: 24h
  routePrefix: /
  rulesSelector: {}
  rules:
    specifiedInValues: true
    value: {}

  service:
    annotations: {}
    clusterIP: ""
    externalIPs: []
    loadBalancerIP: ""
    loadBalancerSourceRanges: []
    nodePort: 30900
    type: ClusterIP

  serviceMonitorsSelector: {}
  serviceMonitors:
    - name: kube-prometheus-nginx-ingress
      selector:
        matchLabels:
          app: nginx-ingress
      endpoints:
        - port: metrics
          interval: 30s
      namespaceSelector:
        any: true

Prometheus Operator Logs:

ts=2018-01-14T22:23:58Z caller=operator.go:980 component=prometheusoperator msg="updating config skipped, no configuration change"
ts=2018-01-14T22:24:09Z caller=operator.go:671 component=prometheusoperator msg="sync prometheus" key=monitoring/kube-prometheus
ts=2018-01-14T22:24:09Z caller=operator.go:980 component=prometheusoperator msg="updating config skipped, no configuration change"

When I deploy the Prometheus Operator Helm chart, it sets the serviceMonitorSelector with a preset list of app names:
https://github.com/coreos/prometheus-operator/blob/master/helm/kube-prometheus/values.yaml#L317
With this set, is there a way to add ServiceMonitors for other apps? Does this list need to be customized somehow?
I didn't see a way to pass in values to modify how the serviceMonitorSelector gets populated.

I'm having a similar problem trying to get a ServiceMonitor registered.
I've added the name of the app to the serviceMonitorsSelector configuration which matches the label in my ServiceMonitor, but when checking /config on Prometheus I don't see a scrape config.
My ServiceMonitor is in a different namespace than Prometheus/Prometheus Operator are deployed in.
Is there any additional configuration that I'm overlooking?

The Prometheus object by default only selects ServiceMonitors in the same namespace as the Prometheus object. Starting with the Prometheus Operator v0.19.0 you can set the serviceMonitorNamespaceSelector to select the namespace the ServiceMonitor objects should be selected from.

Thanks @brancz, I just saw that setting this morning. Will give it a shot!

I had same problem, solved by changing serviceMonitorsSelector
Prometheus object generated by helm:

kube-prometheus.yaml
apiVersion: monitoring.coreos.com/v1
kind: Prometheus
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"monitoring.coreos.com/v1","kind":"Prometheus","metadata":{"annotations":{},"labels":{"app":"prometheus","chart":"prometheus-0.0.44","heritage":"Tiller","prometheus":"kube-prometheus","release":"kube-prometheus"},"name":"kube-prometheus","namespace":"monitoring"},"spec":{"affinity":{"podAntiAffinity":{"preferredDuringSchedulingIgnoredDuringExecution":[{"podAffinityTerm":{"labelSelector":{"matchLabels":{"app":"prometheus","prometheus":"kube-prometheus"}},"topologyKey":"kubernetes.io/hostname"},"weight":100}]}},"alerting":{"alertmanagers":[{"name":"kube-prometheus-alertmanager","namespace":"monitoring","port":"http"}]},"baseImage":"quay.io/prometheus/prometheus","externalUrl":"http://kube-prometheus.monitoring:9090","logLevel":"info","paused":false,"replicas":1,"resources":{},"retention":"48h","routePrefix":"/","ruleSelector":{"matchLabels":{"prometheus":"kube-prometheus","role":"alert-rules"}},"serviceAccountName":"kube-prometheus","serviceMonitorSelector":{"matchExpressions":[{"key":"app","operator":"In","values":["alertmanager","exporter-coredns","exporter-kube-controller-manager","exporter-kube-dns","exporter-kube-etcd","exporter-kube-scheduler","exporter-kube-state","exporter-kubelets","exporter-kubernetes","exporter-node","grafana","prometheus","prometheus-operator"]}]},"storage":{"volumeClaimTemplate":{"selector":{},"spec":{"accessModes":["ReadWriteOnce"],"resources":{"requests":{"storage":"5Gi"}},"storageClassName":"general-storage"}}},"version":"v2.2.1"}}
  creationTimestamp: 2018-07-21T19:52:34Z
  generation: 1
  labels:
    app: prometheus
    chart: prometheus-0.0.44
    heritage: Tiller
    prometheus: kube-prometheus
    release: kube-prometheus
  name: kube-prometheus
  namespace: monitoring
  resourceVersion: "4255820"
  selfLink: /apis/monitoring.coreos.com/v1/namespaces/monitoring/prometheuses/kube-prometheus
  uid: 9cd1f2d5-8d1f-11e8-9982-9600000c29a0
spec:
  affinity:
    podAntiAffinity:
      preferredDuringSchedulingIgnoredDuringExecution:
      - podAffinityTerm:
          labelSelector:
            matchLabels:
              app: prometheus
              prometheus: kube-prometheus
          topologyKey: kubernetes.io/hostname
        weight: 100
  alerting:
    alertmanagers:
    - name: kube-prometheus-alertmanager
      namespace: monitoring
      port: http
  baseImage: quay.io/prometheus/prometheus
  externalUrl: http://kube-prometheus.monitoring:9090
  logLevel: info
  paused: false
  replicas: 1
  resources: {}
  retention: 48h
  routePrefix: /
  ruleSelector:
    matchLabels:
      prometheus: kube-prometheus
      role: alert-rules
  serviceAccountName: kube-prometheus
  serviceMonitorSelector:
    # THIS SO FUCKING COUNTERINTUITIVE! why need to block from adding monitors?
    matchExpressions:
    - key: app
      operator: In
      values:
      - alertmanager
      - exporter-coredns
      - exporter-kube-controller-manager
      - exporter-kube-dns
      - exporter-kube-etcd
      - exporter-kube-scheduler
      - exporter-kube-state
      - exporter-kubelets
      - exporter-kubernetes
      - exporter-node
      - grafana
      - prometheus
      - prometheus-operator
  storage:
    volumeClaimTemplate:
      selector: {}
      spec:
        accessModes:
        - ReadWriteOnce
        resources:
          requests:
            storage: 5Gi
        storageClassName: general-storage
  version: v2.2.1

Solution:
Change serviceMonitorSelector in prometheus resource
(using kubectl edit prometheus -n monitoring kube-prometheus)
...
  serviceMonitorSelector:
    matchLabels:
      prometheus: kube-prometheus

Adding Metrics example:
Service to expose nginx metrics
apiVersion: v1
kind: Service
metadata:
  namespace: ingress-nginx
  name: ingress-nginx-metrics
  labels:
    app: ingress-nginx-metrics
spec:
  ports:
    - name: metrics
      port: 10254
      protocol: TCP
      targetPort: 10254
  selector:
    app: ingress-nginx

Service monitor
apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
metadata:
  namespace: monitoring
  name: ingress-nginx
  labels:
    component: ingress-nginx
    prometheus: kube-prometheus
spec:
  endpoints:
    - interval: 30s
      port: metrics
      path: /metrics
  jobLabel: component
  namespaceSelector:
    matchNames:
    - ingress-nginx
  selector:
    matchLabels:
      app: ingress-nginx-metrics

After adding this you should be able to see new target in prometheus UI: https://you-prometheus-ui/targets

Adding nginx dashboard to grafana:

Save dashboard from here https://github.com/kubernetes/ingress-nginx/blob/master/deploy/grafana/dashboards/nginx.yaml (it's a json file)
Change

"pluginName": "Prometheus" -> "pluginName": "prometheus"
"datasource": "Prometheus" -> "datasource": "prometheus"

Import to grafana (need to login, default is admin/admin)

You should see something like:

@brancz Would it be nice to add docs how to integrate with most common services like ingress?

@Paxa yes more documentation on common cases is a great idea. I would prefer it to be generic though, and not based on helm charts or anything.

What these common cases would be? Any ideas?
Btw do you know why nginx ingress has prometheus labels? Some distribution uses it?
annotations:
  prometheus.io/port: '10254'
  prometheus.io/scrape: 'true'

https://github.com/kubernetes/ingress-nginx/blob/cb675b9dbf3175e14ac266e756aab59b7a2d1cd4/deploy/mandatory.yaml#L239

Yes I know where that's coming from, that's an old and outdated way of doing discovery with Prometheus, it's from pre-v1.3.0 Prometheus releases (where Kubernetes discovery was much less powerful and flexible), and we haven't been able to get rid of it everywhere sadly as it still somewhat works with newer versions. We and a number of people of the upstream team agree though that the way the Prometheus Operator solves this is much more in line with how Prometheus target discovery is supposed to work, and recommend against the annotation paradigm.


Add a comment

What changes were proposed in this pull request?
(comment added, no source code changed)
How was this patch tested?
(unit test)
Please make sure the Kmeans input dataset does not contain duplicates, otherwise takeSample() method may take duplicated examples, leading to runtime exception

Can one of the admins verify this patch?

@kzhang28 update or close this?

@srowen I closed it. Thank you for your kind reminder.


Bluetooth: controller: created ll_types for common LL type definitions

Created new LL type definition header.
Based on review suggestion from PR https://github.com/zephyrproject-rtos/zephyr/pull/61473 (https://github.com/zephyrproject-rtos/zephyr/pull/61473#discussion_r1295862285).

Maybe I'm missing a crucial point, but what's wrong with stdbool.h ?

As I understood from the internal review feedback there was concern in using the boolean true / false definitions with bit fields. I assumed it was because the header and definitions would be library / compiler dependent and as I recall even ours had some issues when boolean was not uint8.

As agreed in the controller meeting I am dropping this PR in favour of using 1U and 0U instead.


Updating bootloader via ISCP programmer

After uploading bootloader 1.04 I can't upload firmwares via USB XLoader.
Uploading firmware via ISCP USBasp is OK.

The new USB firmware defaults to USB-MIDI.
A SYSEX string can be sent via MIDI to switch to serial for OS upload.
Alternatively, the new version of MCL has a boot menu with "OS UPGRADE" that will put the USB chip in to serial mode.
So the instructions require you to upgrade MCL first, then the USB microcontroller.
Jump on the discord if you still need help.


WIP - Separate dashboard routes

Who is this PR for?
Dashboard users
What problem does this PR fix?
Dashboards can have long load times without any visible ui
What does this PR do?
Renders a UI immediately so users can see the app while the data loads.
Only requests the data necessary to display the current dashboard to reduce load time.
Javascript QA

[ ] Author checked latest in IE - Absence Dashboard
[ ] Author checked latest in IE - Absence Dashboard
[ ] Author checked latest in IE - Tardies Dashboard
[ ] Author checked latest in IE - Tardies Dashboard
[ ] Reviewer checked latest in IE - Absence Dashboard
[ ] Reviewer checked latest in IE - Absence Dashboard
[ ] Reviewer checked latest in IE - Tardies Dashboard
[ ] Reviewer checked latest in IE - Tardies Dashboard

Automated Testing

[x] Author improved specs for code in need of better test coverage

Does the PR introduce a new feature or new section of code?

[ ] Author included specs for new code

@edavidsonsawyer ah sorry, I bet that's from the node version.  If I download fresh from your repo and yarn install && yarn test I see the same thing when running:
$ node -v
v6.11.3

This is on a different computer than usual, and if I install the latest long-term support version, 8.11.0, things work great.
$ node -v
v8.11.0

We could add the node engine version to the package.json to communicate this for the project and catch things like this in the future, but for now you can also just install the updated version which only takes a minute or two: https://nodejs.org/en/

Hey @edavidsonsawyer!  From the description and conversation here, my read of this PR is that it's still WIP, which is fine.  Let me know if you need anything else here or just ping when this feels ready to ship.

@edavidsonsawyer I apologize, I didn't get to this this morning and am out tomorrow for a family wedding.  You should definitely keep working on top of this on what's next!
I'll ship this next week or @alexsoble if you have time and are able to ship that's great too, no worries either way.

@edavidsonsawyer @kevinrobinson Gave both sets of endpoints a manual QA in Internet Explorer and gave the code another read-through . . . you two had awesome discussions here and I learned a whole bunch!  👍
Shipping now, will deploy and share out the page load timing measurements from production + Internet Explorer.

@edavidsonsawyer @kevinrobinson Tested out the new routes in Internet Explorer and Chrome.
The first thing I noticed is that the timing logging in the console doesn't reflect how long it takes to see data in /schools/:id/absences and /schools/:id/tardies for the user. For those pages, the MountTimer appears almost immediately in the console, while the user sees "Loading..." for a while afterwards, which isn't accounted for in the timing log.
I used the Google Chrome Stopwatch to time how long I saw "Loading..." for the Healey school absences page using the new JSON endpoint, it came out to between 10 seconds and 12 seconds over a couple of tries.
So, with that caveat, here are the timing logs I saw for Chrome:
Chrome: schools/hea/school_administrator_dashboard

Chrome: schools/hea/absences (again, does not include time spent "Loading...")

Here's what I saw for Internet Explorer, using my Virtual Machine:
IE: schools/hea/school_administrator_dashboard

IE: schools/hea/absences
For some reason, I couldn't see any output here in the Developer tools, even after trying a couple of times. I used a stopwatch to time the amount of time between requesting the page and seeing data and got 17 seconds.
Subjectively...
The old/existing dashboard pages felt faster to me than the new ones. This could be because looking at the word "Loading..." for 10 seconds made me much more aware that I was waiting for data to load.

Woah! It says @studentinsights-bot was the author of that last comment but I'm guessing the real author was @kevinrobinson or @edavidsonsawyer... unless the @studentinsights-bot AI is seriously next level...
For what it's worth I think it would be good to profile and optimize the Ruby code first. Watching the JSON-powered, separate-endpoint pages hang on "Loading..." for ~10 seconds gave me the sense that we could gain a lot from speeding up the server-side queries. I also think improving the Ruby code is easier to profile and measure since we don't have to worry about the effect of things like Internet Explorer dev tools.


Inconsistant tags

noticed that some metals are tagged with ingot and the like properly but many exclusively have "#mythicmetals:ect" or just "#material:ingot/nugget/ore" tags, this leads to some funky interactions with other mods such as create, and I would love a fix. I'm using mod version 0.17.3 on 1.19.2 for fabric.

this also includes the armors and weapons added by the mod, i guess i would just like to see properly assigned vanilla tags as it greatly contributes to compatibility.

Could you provide some more meaningful/direct examples of the vanilla tags you mean here? I have been playtesting with Create on 1.19.2 for a while now and had no issues related to tags. In fact via the Alloy Forgery we support most of their recipes.
For some clarification, the Fabric ecosystem uses convention tags, which are all in the #c namespace, for example #c:adamantite_ores. In my case these tags nest their #mythicmetals equivalent. All tools should be present in the main data directory or under the generated data:
https://github.com/Noaaan/MythicMetals/tree/1.20/src/main/resources/data
https://github.com/Noaaan/MythicMetals/tree/1.20/src/main/generated/data/

Closing as stale

None of the ingots have the vanilla tag #C:ingots, nuggets not tagged #C:nuggets

Would it be possible to add #c:<material>_nuggets tags as well? This is especially relevant for copper nuggets, which are also added by several other mods.

Maybe. I did originally consider it, but it is somewhat problematic as you are able to disable all nuggets in the config. You cannot optionally load entries in tag to my knowledge, so supplying raw data (JSON) is very annoying to deal with (it produces a ton of errors if the items aren't present).
I could solve this with tag injection, but I do not think it is the prettiest solution. Mainly since I would be providing a much higher quantity of tags that aren't super-visible to modders. They would be visible in-game or via third party tools, which would be good.
I will deliberate this suggestion a bit, and I might implement it for upcoming versions

You cannot optionally load entries in tag to my knowledge...

Would that not be accomplished by the following?
{
  "replace": false,
  "values": [
    {
      "id": "mythicmetals:copper_nugget",
      "required": false
    }
  ]
}

Temporary commit to add datagen for everything: https://github.com/unilock/MythicMetals/commit/eb05e047126f2c769f6b4cd3cd66209941f08881
It doesn't currently work due to registry stuff(?), but I'm in a rush atm so I'll have to look into it later.


Fix quaternion keyframe optimization for collinear rotation over 180 degrees

Fixes: #87813
Change the correct great-arc distance for 180 degrees rotation.
Bugsquad Edited:
Fixes https://github.com/godotengine/godot/issues/75159

@TokageItLab I am not sure about this. What do you think?

It sounds like it makes sense to check the angles before the axes check.
I remember there are a couple of issues related to this and will test to see if it works correctly (if it is possible to optimize without over thinning the keys) when I have time.

After thinking about it, the original checks is correct. It just missing one key quirk of quaternion.
In short, unit quaternion is a double-covering of SO3 (rotation group). Rotating 360 degrees once brings a quaternion to it's negative. It requires 720 degrees rotation to bring it back to it's original state.
(See plate trick and quantum spin, if you'd like to know more)
So, doing a great arc distance (acos(q1.dot(q2))) gives half the angle rotated between the two quaternions. You can clearly tell by simply checking the distance between it and it's negative (360 degrees rotated). So 180 degrees rotation would be separated by PI/2, not PI.

Thanks! And congrats for your first merged Godot contribution :tada:


@conda-forge-admin, please add bot automerge

Issue:

Environment (conda list):

$ conda list

Details about  conda and system ( conda info ):

$ conda info

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/coredns-feedstock#20.


Get CRuby make test-all passing

[x] https://github.com/ruby/prism/issues/1997

Will probably fix test/ruby/test_m17n.rb and test/ruby/test_regexp.rb

[ ] #2370
[ ] #2323
[ ] TestRubyLiteral#test_string https://github.com/ruby/prism/issues/2331
[x] #2369
[x] #2371
[x] TestParse#test_method_location_in_rescue - line number is off
[x] TestSetTraceFunc#test_thread_add_trace_func - line number is off
[x] TestSyntax#test_method_call_location - line number is off
[x] TestString#test_concat_literals - concat is losing encoding (https://github.com/ruby/prism/issues/2313)
[x] #2309
[x] TestFileExhaustive#test_expand_path_encoding - encoding issue
[x] https://github.com/ruby/ruby/pull/9821: TestCall#test_call_block_order splat with block swallowed
[x] test/ruby/test_shapes.rb: pending https://github.com/ruby/ruby/pull/9812
[x] #2326
[x] Psych_Unit_Tests#test_spec_explicit_families - almost definitely encoding related
[x] test/test_unicode_normalize.rb - probably encoding related
[x] test/objspace/test_objspace.rb - code range/old??
[x] TestZlibGzipReader#test_gets2 - encoding related
[x] #2321
[x] #2312
[x] #2316
[x] #2311
[x] #2318
[x] #2307

test/optparse/test_acceptable.rb
test/optparse/test_cclass.rb
test/optparse/test_did_you_mean.rb
test/optparse/test_optparse.rb
test/optparse/test_optarg.rb
test/optparse/test_noarg.rb
test/optparse/test_reqarg.rb
test/optparse/test_placearg.rb
test/optparse/test_summary.rb

[x] TestMethod#test_method_list - segfaults - https://github.com/ruby/prism/issues/2294
[x] #2314
[x] #2310
[x] https://github.com/ruby/prism/issues/1998
[x] https://github.com/ruby/prism/issues/2245
[x] https://github.com/ruby/prism/issues/2247
[x] https://github.com/ruby/prism/issues/2248
[x] https://github.com/ruby/prism/issues/2249
[x] https://github.com/ruby/prism/issues/2250
[x] https://github.com/ruby/prism/issues/2251
[x] https://github.com/ruby/prism/issues/2252
[x] https://github.com/ruby/prism/issues/2253
[x] TestProfileFrames#test_matches_backtrace_locations_main_thread - segfaults, unknown reason (https://github.com/ruby/prism/issues/2295)
[x] unknown type: T_STRING

test/did_you_mean/core_ext/test_name_error_extension.rb
test/did_you_mean/spell_checking/test_method_name_check.rb
test/did_you_mean/spell_checking/test_variable_name_check.rb
test/error_highlight/test_error_highlight.rb
test/irb/test_eval_history.rb

[x] #2296
[x] test/monitor/test_monitor.rb - # ArgumentError: wrong number of arguments (given 1, expected 0; required keyword: x) (https://github.com/ruby/prism/issues/2299)
[x] Anonymous local variables incorrectly named, will be fixed by #2276
[x] #2298
[x] #2300
[x] #2297
[x] #2324
[x] TestSyntax#test_must_ascii_compatible - https://bugs.ruby-lang.org/issues/20210

Closing in favor of https://github.com/ruby/prism/issues/2791


accept="image/*"

I have been trying to change plugin to do accept="image/*" on input button, but to no avail.
It is always hard to properly restyle the file chooser button, but in this case it seems that you have chosen the way that is not working well with extra attributes like accept="image/*"
or maybe I am wrong? And there is a way?
Otherwise I think there might be better ways how to restyle the button - for example I have used something like this before:
.btn-file {
    position: relative;
    overflow: hidden;
}
.btn-file input[type=file] {
    position: absolute;
    top: 0;
    right: 0;
    min-width: 100%;
    min-height: 100%;
    font-size: 100px;
    text-align: right;
    filter: alpha(opacity=0);
    opacity: 0;
    outline: none;
    background: white;
    cursor: inherit;
    display: block;
}

and with html:
<span class="form-control btn btn-primary btn-file">
  <input type="file" accept=".xlsx">Select .xlsx file to upload</input>
</span>

and then I could add accept attribute, and it worked with restyled button.
But maybe there is a way how to do it with existing code?
If not, then I will do a plugin version with changes to css and also to make accept attribute configurable as well, and then send a pull request.

I have added pull request https://github.com/yogiben/meteor-autoform-file/pull/29 to add configurable accept attribute. No changes in css, as it works perfectly.


bytecode generation in snapshots script

we submitted https://github.com/ethereum-optimism/optimism/issues/10656
this will determine whether there is a better way to do https://github.com/babylonchain/optimism/pull/4

Per Tynes's suggestion, I deleted all generated bytecode files and rollbacked the modification in snapshots script.


All keypoints sharing the same confidence in pose_results

When I ran demo_img_with_mmdet.py, I checked the output pose_results from inference_top_down_pose_model(). All the 17 keypoints share the same confidence value, which seems to be the aggregated confidence of all 17 keypoints. Could you fix the issue to show individual confidence of each keypoint in the demo script?

Hello, thank you for your interest in our work. Our method treats the pose as a whole, so the predicted score is for the entire pose, and we do not assign individual scores to each keypoints.

Hello, thank you for your interest in our work. Our method treats the pose as a whole, so the predicted score is for the entire pose, and we do not assign individual scores to each keypoints.

Hi ! And what about  confidence value. Is it in percents?  If yes, it always less than 10 even for  well illuminated (full body) person  without occlusions with near perfect tracked joints.


[ServiceX] Update certificate used for CMS DID

ServiceXFatalTransformException: (ServiceXFatalTransformException(...), "ServiceX Fatal Error: DID Request Failed for id fbe09e3b-4633-4460-9bc8-abbab9c6a5f0: Cannot authenticate.\nDetails: HTTPSConnectionPool(host='cms-rucio-auth.cern.ch', port=443): Max retries exceeded with url: /auth/x509_proxy (Caused by SSLError(SSLError(1, '[SSL: SSLV3_ALERT_CERTIFICATE_EXPIRED] sslv3 alert certificate expired (_ssl.c:877)'),)) - Cannot authenticate.\nDetails: HTTPSConnectionPool(host='cms-rucio-auth.cern.ch', port=443): Max retries exceeded with url: /auth/x509_proxy (Caused by SSLError(SSLError(1, '[SSL: SSLV3_ALERT_CERTIFICATE_EXPIRED] sslv3 alert certificate expired (_ssl.c:877)'),))")

@clundst changed certificate some time ago.


Several dart2js language tests import internal libraries

The analyzer classifies importing an internal library as a Compile-time error. We wish to no longer allow // ignore-ing such errors. There are some dart2js language tests that import internal libraries, and then ignore the error:
$ git grep -A 1 import_internal_library tests/compiler/dart2js
tests/compiler/dart2js/codegen/model_data/native.dart:// ignore: import_internal_library
tests/compiler/dart2js/codegen/model_data/native.dart-import 'dart:_js_helper';
--
tests/compiler/dart2js/codegen/model_data/native_inlined.dart:// ignore: import_internal_library
tests/compiler/dart2js/codegen/model_data/native_inlined.dart-import 'dart:_js_helper';
--
tests/compiler/dart2js/codegen/model_data/native_unused_parameters.dart:// ignore: import_internal_library
tests/compiler/dart2js/codegen/model_data/native_unused_parameters.dart-import 'dart:_js_helper';
--
tests/compiler/dart2js/member_usage/data/native.dart:// ignore: import_internal_library
tests/compiler/dart2js/member_usage/data/native.dart-import 'dart:_js_helper';
--
tests/compiler/dart2js/rti/emission/native.dart:// ignore: import_internal_library
tests/compiler/dart2js/rti/emission/native.dart-import 'dart:_js_helper' show Native;
tests/compiler/dart2js/rti/emission/native.dart:// ignore: import_internal_library
tests/compiler/dart2js/rti/emission/native.dart-import 'dart:_foreign_helper' show JS;

This can be remedied in 1 of 3 ways:

The analyzer should not report errors for these imports; in which case the analyzer is just missing some condition that would allow a library to import internal libraries.
Importing internal libraries should not be a compile-time error; I doubt this is the solution.
The tests should not contain the imports; I assume they contain the imports for important reasons.

Assigning to @sigmundch for triage.

Indeed - many dart2js unit tests and internal end-to-end tests purposely allow these imports to be able to test low-level features of dart2js.
We'd need something like (1) above. We whitelist these locations by folder when we configure the CFE, so we'd be OK with a similar solution for analyzer or a general rule that allows using this ignore within the sdk repro only?

Yeah I created a similar whitelist for analyzer:
https://github.com/dart-lang/sdk/blob/master/pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart#L433
So 1. is what we're doing now. I wish there was a more general solution :/. I'll close this for now, and I'll link to it in our code.


Impl test using both storage and child_storage

Currently all our test bypass child storage genesis config.
This change TestExternalities to be build with the storage tuple (top storage, child_storage)
All in all I think we should move to another API where top_storage and child_storage are inside the same struct and having build_storage and assimilate_storage use this struct and not two different arguments.
Even add_extra_genesis::build should give only one argument storage which contains both top and childs. But this is let to another PR.
@rphmeier this is a first part, next we have to make with_storage being able to work on child_storage as well.
TODO:

maybe test PartialEq implementation

@thiolliere It will need a corresponding update and PR in the Polkadot repo

OK so I now included changes to basic to be able to handle children as well. I update PR description

sorry for changing the goal of the PR, after some ppl reviewed I haven't seen Gav approval before comitting the changes. I know this is confusing and useless as the PR was fine


fix(STADTPULS-431): always fetch most recently recorded records

This PR is a small fix for the issue that our Supabase calls for sensor records were always returning the first n items. In reality we always want the most recently recorded items, that's why we are now using .order("recorded_at", { ascending: false }) in our calls.
This mainly ensures that our line chart always displays the most recent records even if the max row limit of Supabase is exceeded. Previously all records that were exceeding the limit were simply not present in the response, often the ones that were recorded most recently.
(Handling the max row limit is a separate task already documented in STADTPULS-318).

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Enum ValidValues sinceVersion is always 0

For the golang backend I want to provide a sinceVersion()/inActingVersion() for each ValidValue in an enum.
The spec of June 16 2016 suggests in section <IP_ADDRESS> that sinceVersion is an element attribute of a ValidValue.
When looking at ValidValue tokens it seems that token.version() is always equal to zero for these regardless of how it's set.
I've been testing with the following
--- a/sbe-tool/src/test/resources/basic-types-schema.xml
+++ b/sbe-tool/src/test/resources/basic-types-schema.xml
@@ -13,8 +13,8 @@
         </composite>
         <type name="EDT" description="char array" length="20" primitiveType="char" semanticType="char"/>
         <enum name="ENUM" description="enum as uint8" encodingType="uint8" semanticType="int">
-            <validValue name="Value1">1</validValue>
-            <validValue name="Value10">10</validValue>
+            <validValue name="Value1" sinceVersion="1">1</validValue>
+            <validValue name="Value10" sinceVersion="2">10</validValue>

The validValue and choice elements carried forward the sinceVersion and description of the field rather than what was set on these elements. I've updated the parser to correct this.

Thanks @mjpt777 . I can confirm the fix of #c6822f1 works for me.


[Comments] Batch fixes

Fixes
Issue Number: closes #45, closes #46, https://github.com/OdyseeTeam/odysee-frontend/pull/61
PR Checklist

Toggle...
What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting)
[ ] Refactoring (no functional changes)
[ ] Documentation changes
[ ] Other - Please describe:

Please check all that apply to this PR using "x":

[X] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
[ ] I have checked that this PR does not introduce a breaking change
[ ] This PR introduces breaking changes and I have provided a detailed explanation below

Sorry, i reverted the other one without seeing this @saltrafael !


Error: install npm

I have try install "npm install" show errors:
npm install

<EMAIL_ADDRESS>postinstall /home/jczars/Cointrol/cointrol/webapp/node_modules/handlebars-brunch
node ./postinstall.js

sh: 1: node: not found
npm WARN<EMAIL_ADDRESS>No license field.
npm ERR! Linux 4.10.0-40-generic
npm ERR! argv "/usr/bin/nodejs" "/usr/bin/npm" "install"
npm ERR! node v4.2.6
npm ERR! npm  v3.5.2
npm ERR! file sh
npm ERR! code ELIFECYCLE
npm ERR! errno ENOENT
npm ERR! syscall spawn
npm ERR<EMAIL_ADDRESS>postinstall: node ./postinstall.js
npm ERR! spawn ENOENT
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>postinstall script 'node ./postinstall.js'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the handlebars-brunch package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node ./postinstall.js
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs handlebars-brunch
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls handlebars-brunch
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     /home/jczars/Cointrol/cointrol/webapp/npm-debug.log

This error shows that you do not have 'node' installed.
https://nodejs.org/en/

I have the same and have nodejs 10.12.0


Set up random scenario generation

Want to be able to run a bunch of random scenarios with m voters and n candidates (m close to n) and gather statistics on them
Record quantitative and qualitative results in this repo
May also want to include parameters of a simulation run with each recording of results (probably just need to log m, n, and RNG seed? Maybe log all the ballots?)

Started working on this in https://github.com/DylanSp/decision-maker-experiments/commit/dd308a6e9845f8b3025bb5889580c84b233ecc0f; code is somewhat sloppy, results are just logged to console as text, RNG seed isn't captured/logged anywhere.


Fix broken headings in Markdown files

GitHub changed the way Markdown headings are parsed, so this change fixes it.
See bryant1410/readmesfix for more information.
Tackles bryant1410/readmesfix#1

<3 thanks.


Consumer autocommit lead to crash

With consumer enableAutoCommit option library crashes with fatalError at:
    private func handleOffsetCommitEvent(_ event: OpaquePointer?) {
        guard let opaquePointer = rd_kafka_event_opaque(event) else { <--- here
            fatalError("Could not resolve reference to catpured Swift callback instance")
        }

After some time (I guess after 5 seconds).
It is possible to either disable commit events in that case with enabled_events, either just skip events without opaque pointer.
With auto commit disabled this seems not reproducible.

Alright, I know where this is coming from. What happens here is the following:
When we have enableAutoCommit = false, we use this method to manually commit offsets:

Click to expand
   func commitSync(_ message: KafkaConsumerMessage) async throws {
       // Declare captured closure outside of withCheckedContinuation.
       // We do that because do an unretained pass of the captured closure to
       // librdkafka which means we have to keep a reference to the closure
       // ourselves to make sure it does not get deallocated before
       // commitSync returns.
       var capturedClosure: CapturedCommitCallback!
       try await withCheckedThrowingContinuation { continuation in
           capturedClosure = CapturedCommitCallback { result in
               continuation.resume(with: result)
           }

           // The offset committed is always the offset of the next requested message.
           // Thus, we increase the offset of the current message by one before committing it.
           // See: https://github.com/edenhill/librdkafka/issues/2745#issuecomment-598067945
           let changesList = RDKafkaTopicPartitionList()
           changesList.setOffset(
               topic: message.topic,
               partition: message.partition,
               offset: Int64(message.offset + 1)
           )

           // Unretained pass because the reference that librdkafka holds to capturedClosure
           // should not be counted in ARC as this can lead to memory leaks.
           let opaquePointer: UnsafeMutableRawPointer? = Unmanaged.passUnretained(capturedClosure).toOpaque()

           changesList.withListPointer { listPointer in
               rd_kafka_commit_queue(
                   self.kafkaHandle,
                   listPointer,
                   self.mainQueue,
                   nil,
                   opaquePointer
               )
           }
       }
   }

Which does an unretained pass of this CapturedClosure and then waits for the func handleOffsetCommit(_:) method to execute the closure.
The problem we are running into here is that when enableAutoCommit = true, we don't pass a CapturedClosure to the commit, but our code still expects something in func handleOffsetCommit(_:).
Fixing this would either mean failing softly as in:
guard let opaquePointer = rd_kafka_event_opaque(event) else {
     // No captured closure set (enableAutoCommit = true)
     return
}

Or only expecting a value here after we checked that enableAutoCommit == true.
Thanks for raising this issue!

Yes, exactly! I think that it is possible to remove commit event from poll with enabled_events=0x7fffffff & ~(RD_KAFKA_EVENT_OFFSET_COMMIT) or as suggested above by softly bypassing that situation

Oh, it is even already in place, just small addition:
// KafkaConsumer
        let client = try RDKafkaClient.makeClient(
            type: .consumer,
            configDictionary: config.dictionary,
            events: [.log, .fetch]  /* just add */+ config.enableAutoCommit ? [] : [.offsetCommit],
            logger: logger
        )


fix: build

I tried to compile.
Erro	C2338	static_assert failed: 'Cannot format an argument. To make type T formattable provide a formatter specialization: https://fmt.dev/latest/api.html#udt'	modules	C:\Server\Arena-BR\azerothcore-wotlk\deps\fmt\include\fmt\core.h	1710

@Helias Shall we close this PR? Between today and tomorrow, I'll start updating the module.


nicer landing page

implement landing page in react (or solid)

looks good so far: https://michispebach.github.io/plebnames
sometimes I forget that I can scroll, what do you think of adding something like an arrow that indicates this and can be clicked?
like:


make OS=ios ARCH=ARCH

I don't even know what I'm doing I wanted to get a proxy server

can you describe your question clearly? if there is no update, this issue will be closed.


Can't register property?

I'm trying to use asmcss to register an option, my code looks like:
:root {
  --aspect-ratio--register: true;
}

however, it seems like it's not working when I use it later in a div
<div xs="w:100%; aspect-ratio:4/3">
	...
</div>

when I look at the browser dev panel there is no aspect-ratio property used on that element at all.

I'm importing asmcss in the following way:
      <script
        type="text/javascript" src="/static/js/assembler.min.js"
        data-generate="true"
        data-x-style-attribute="xs"
        data-mode="mobile-first">
      </script>

this is at the end of the body tag


Engage Weekly - January 31st, 2022

This is a weekly public meeting to discuss the engagement across different areas of the Postman API Network, coordinating and planning around the advocacy, education, and community building work occurring within Postman Open Technologies.
Agenda:

Administrative - Taking care of administrative aspects of running this meeting.

Intake

Github
Slack - #api-network-partnerships #api-network-wins
Airtable -- Just for master index.

Public - This meeting will be open to the network, partners, and general public.

Trending - What teams, APIs, and collections are trending lately on the network.

Weekly Review - Worked our way through what is trending

Priorities - What priorities requests have come in from internal and external stakeholders.

Pipedrive - Kin will work process and hand over to Arlemi.
Zoho Sign - Arlemi is working with.
Zoho CRM - Write a blog post.
Treblle - Playing with their API.
Plaid - Write a blog post.
TriSys - Getting them to setup workspace.
Huwawei - What is next for Huwaei?
Twitter - Meeting with this week to discuss their OpenAPI journey.
Github - Have a meeting coming up with Github to discuss their Postman collections / workspace.
Paypal - Discussions about their workspace possibilities.

Campaigns - What are the areas we are focusing on with campaigns and components.

Studio Ghibli - International (under-represented)
Cryptowatch - Websockets opportunity?
Google - gRPC

Find more partners
Microcks story.
Public gRPC APIs? (https://groups.google.com/g/grpc-io/c/EXpZa1vBooo?pli=1)

AmberData
API3 - Breaking Changes podcast.

Opportunities - Identifying where the opportunities are for focusing our attention.

Web3
Websockets

Please add any agenda items you’d like to discuss below, and we will meet weekly, and push forward projects, productions, stories, collections, and tools to support our work.
Meeting:

January 31st, 2022 - 8:30 AM PST
Zoom - Ask for access below.

Websockets echo coming. Need gRPC echo?

Kroger - experimental!

OpenText - https://developer.opentext.com/


Extension - Improve the Substrate Provider to meet the demands of dApps utilizing both EVM and Substrate.

Describe the update
Improve the Substrate Provider to meet the needs of dApps using both EVM and Substrate.

[x] Add a method to check whether the node is connected or not.
[x] Display the EVM address if allowing connectivity for both methods.

Version test : http://<IP_ADDRESS>:8900/s/o6qrxeHdNfCcm5T
Validation passed

@saltict @Thiendekaco please re-check expect for this issue
I prefer expect:

The dApp supports any acc type, it will display that acc type like the previous logic
With Polkadot js application, it is handled separately

Please update this task with:

Enable by domains: https://polkadot.js.org/apps
Enable with method: wallet.enable(null, {evmAccount: true})

Demo link: https://mkr52n.csb.app/

Version test: http://<IP_ADDRESS>:8900/s/ctxJwF8skzYKoHL
Validation passed in case

Connect/perform transactions with account EVM on Polkadot js (https://polkadot.js.org/apps)

Re-check connect/perform transaction with dapp EVM(Moonbeam dapp), dapp Substrate (Acala), Subconnect

Version test: http://<IP_ADDRESS>:8900/s/ctxJwF8skzYKoHL
Validation passed in case

Connect/perform transactions with account EVM on Polkadot js (https://polkadot.js.org/apps)

Re-check connect/perform transaction with dapp EVM(Moonbeam dapp), dapp Substrate (Acala), Subconnect

[ ] Handly case upgrade version when connect with dApp Polkadot js app
Actual:

Show popup request connect after upgrade version
Do not show account EVM on Manage website asset in case cancel connect

Expect: Do not show request connect and auto display account EVM on Manage website asset

Version test: http://<IP_ADDRESS>:8900/s/9eiyEYLSH8gN66K
Validation passed


Cannot find module 'sequelize/types/lib/hooks' or its corresponding type declarations.

Issue
Getting this error while building a project.
../node_modules/sequelize-typescript/dist/hooks/shared/hook-meta.d.ts(2,32): error TS2307: Cannot find module 'sequelize/types/lib/hooks' or its corresponding type declarations.
Not 100% sure but it seems like with this commit the files are no longer under lib directory.
https://github.com/sequelize/sequelize/commit/6b8fbb48d0d12f2c500f69ce79f7f54386c32b40
Versions

sequelize: 6.16.0
sequelize-typescript: 2.1.2
typescript: 4.5.4

Issue type

[x] bug report
[ ] feature request

I apologize for removing the remaining comments from the issue template.

The same is happening to me. I am using nest and I followed this guide
I also have these dependencies installed.
npm install --save-dev @types/node @types/validator
npm install sequelize reflect-metadata sequelize-typescript

Please look into it

sequelize rollback to 6.15.1
npm install<EMAIL_ADDRESS>

+1


I suppose this is an old bootstrap class

I think this class can be removed without tragic consequences. It is a very old bootstrap class

@ratmcarlo :+1:


Links in README redirect to non-HTTPS page

Several links in the README (e.g. https://sharp.pixelplumbing.com/page/changelog) seem to be redirecting to an insecure HTTP URL, even though the server supports TLS.

Thanks for reporting this, I'm sure it was working back in January (see commit 8e70579). It looks like readthedocs added a new option relating to the use of HTTPS that hadn't been selected by default.
I've just ticked the "use HTTPS" box and now see:
$ curl -Is https://sharp.pixelplumbing.com/page/changelog | grep location
location: https://sharp.pixelplumbing.com/en/stable/changelog


Unexpected token ; jspdf.min.js running 1.2.61 with webpack 1.13.1

This works with jspdf.debug.js.
I am using webpack 1.13.1. to reproduce, simply install jspdf
here's my webpack.config
import path from 'path';
import webpack from 'webpack';
const DEBUG = process.argv.includes('dev');
const VERBOSE = process.argv.includes('verbose');

export default {
    entry: './src/app.js',
    output: {
        path: path.resolve('./public'),
        publicPath: '/public',
        filename: 'app.js'
    },
    devtool: DEBUG ? 'eval' : 'source-map',
    console: true,
    cache: DEBUG,
    debug: DEBUG,
    stats: {
        colors: true,
        reasons: DEBUG,
        hash: VERBOSE,
        version: VERBOSE,
        timings: true,
        chunks: VERBOSE,
        chunkModules: VERBOSE,
        cached: VERBOSE,
        cachedAssets: VERBOSE
    },
    plugins: [
        new webpack.optimize.OccurenceOrderPlugin(),
        new webpack.ProvidePlugin({
            '$': 'jquery',
            'jQuery': 'jquery',
            '_': 'underscore',
            'window.jQuery': 'jquery',
            'Promise': 'imports?this=>global!exports?global.Promise!es6-promise',
            'fetch': 'imports?this=>global!exports?global.fetch!whatwg-fetch'
        }),
        ...(!DEBUG ? [
            new webpack.DefinePlugin({
                'process.env': {
                    NODE_ENV: JSON.stringify('production')
                }
            }),
            new webpack.optimize.LimitChunkCountPlugin({maxChunks: 1}),
            new webpack.optimize.DedupePlugin(),
            new webpack.optimize.UglifyJsPlugin(),
            new webpack.optimize.AggressiveMergingPlugin()
        ] : [])
    ],
    resolve: {
        root: [path.resolve(__dirname, '../bower_components'), path.resolve(__dirname, '../src')],
        extensions: ['', '.webpack.js', '.web.js', '.js', '.jsx', '.html'],
        ..
        }
    },

    module: {
        loaders: [
            {
                test: /\.jsx?$/,
                include: [path.resolve(__dirname, '../src')],
                loader: 'babel-loader'
            },
            {
                test: /\.css$/,
                loader: 'style-loader!css-loader'
            },
            {
                test: /\.less$/,
                loader: 'style!css!less'
            },
            {
                test: /\.json$/,
                loader: 'json-loader'
            }, {
                test: /\.(txt|html)$/,
                loader: 'raw-loader'
            }, {
                test: /\.(png|jpg|jpeg|gif|svg|woff|woff2)$/,
                loader: 'url-loader?limit=10000'
            }, {
                test: /\.(eot|ttf|wav|mp3)$/,
                loader: 'file-loader'
            },
        ]
    }
};

Just confirming that I have the same problem

Confirmed, same issue here

Seems to be addressed, fixed and already merged in https://github.com/MrRio/jsPDF/pull/774. But it's not released yet.

I'm having the same Issue here. When are you releasing it? Im using npm

Any idea when this issue with webpack will be fixed and released ?

I've also encountered this while using webpack any updates on this??

If you are installing from npm, one (ugly) way to get around this until there is a release with a fix (see #744):
In your package.json
"dependencies": {
    "jspdf": "git://github.com/MrRio/jsPDF/#76edb3387cda3d5292e212765134b06150030364"
}

So you're pinning to a working commit, incurring some debt to remember to change it back to the next release.

This is now fixed in 1.3.x 👍 https://github.com/MrRio/jsPDF/issues/506


Update npm org name

Part of https://github.com/FlowFuse/admin/issues/211

Want to start the ball rolling on the package renames. Going to start with this one to flush out pipeline issues etc


[GOBBLIN-1619] WriterUtils.mkdirsWithRecursivePermission contains race condition and puts unnecessary load on filesystem

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[X] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-1619] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-1619

Description

[X] Here are some details about my PR, including screenshots (if applicable):

The current implementation recursively calls fs.mkdirs has the following issues:

Race condition for creating parent directories, causing FileNotFound exception even when the file exists on file system
HDFS fs.mkdirs atomically creates missing parent directories. Thus, the recursive approach is making unnecessary calls.

In HDFS, which the current FileSystem interface is built upon, guarantees the parents will be created. So, all FileSystem class implementations should also follow this behavior.
See the FileSystem abstract class documentation:

The behaviour of the filesystem is specified in the Hadoop documentation. However, the normative specification of the behavior of this class is actually HDFS: if HDFS does not behave the way these Javadocs or the specification in the Hadoop documentations define, assume that the documentation is incorrect

Tests

[X] My PR adds the following unit tests OR does not need testing for this extremely good reason:
Unit tests added and change tested internally at LinkedIn on parallel fastingest test pipeline. The parallel test pipeline compared the permissions created with previous implementation and with new implementation. There were not any differences in the way permissions are set, so the change is completely transparent and non-breaking.

Commits

[X] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

@ZihanLi58  can you approve @homatthew  to run travis ?

Codecov Report

Merging #3477 (0e15bb1) into master (8ffe72b) will decrease coverage by 3.16%.
The diff coverage is 80.00%.

@@             Coverage Diff              @@
##             master    #3477      +/-   ##
============================================
- Coverage     46.62%   43.45%   -3.17%
+ Complexity    10359     2034    -8325
============================================
  Files          2076      405    -1671
  Lines         81064    17407   -63657
  Branches       9049     2127    -6922
============================================
- Hits          37795     7564   -30231
+ Misses        39787     9003   -30784
+ Partials       3482      840    -2642

Impacted Files
Coverage Δ

...main/java/org/apache/gobblin/util/WriterUtils.java
46.45% <80.00%> (+7.93%)
:arrow_up:

...a/org/apache/gobblin/util/limiter/NoopLimiter.java
40.00% <0.00%> (-20.00%)
:arrow_down:

...lin/util/filesystem/FileSystemInstrumentation.java
85.71% <0.00%> (-14.29%)
:arrow_down:

...in/java/org/apache/gobblin/cluster/HelixUtils.java
28.26% <0.00%> (-5.08%)
:arrow_down:

...ice/modules/orchestration/AzkabanClientStatus.java

...java/org/apache/gobblin/stream/ControlMessage.java

...bblin/metrics/graphite/GraphiteConnectionType.java

...ion/suite/CompactionWithWatermarkSuiteFactory.java

...va/org/apache/gobblin/runtime/BaseLimiterType.java

...blin/runtime/mapreduce/GobblinOutputCommitter.java

... and 1668 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ffe72b...0e15bb1. Read the comment docs.

+1 LGTM unless the test fails

LGTM


Fixed Yuglify Compression in Heroku

Coverage remained the same at 49.14% when pulling 8a0ef0219402ad08b96d429debbe48cec18c65fa on kave:master into a5b812c02f435133662bf01930623dee18b00bf3 on excellaco:master.


torchvision dependency

torchvision should only be an optional dependency, but as of now it must be installed to import torchrl primitives.

Solved by #75


config: make amqp settings configurable via config or distillery

Addresses #13 . Limitation observed, it does not mix well with use of amqp://... style URIs.

@pma  - is this of interest?


It doesn't work

When trying to run the application, I get this error:
An unhandled exception of type 'System.IO.FileNotFoundException' occurred in Unknown Module.
Could not load file or assembly 'System.Runtime, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The system cannot find the file specified.
When doing an internet search, I find the following:
In Visual Studio's menu, go to Tool > NuGet Package Manager > Manage NuGet Packages for Solution...
Unfortunately, in order to get this option, I have to find the solution, and those listed don't seem to be what I'm looking for:

Please help!
Thanks,
Laura Metzner

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3bfcc1a8-ddda-810c-17b0-56a506045d67
Version Independent ID: 5415878b-e60b-5433-7b4b-efc8259908f0
Content: Create a REST client using .NET Core
Content Source: docs/csharp/tutorials/console-webapiclient.md
Product: dotnet-csharp
Technology: csharp-fundamentals
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

Hello @laurametzner
Have you compared your code to the version here in our sample repository? That should help find any differences. That version does run correctly, and should be able to help you diagnose the issue.
If you have further questions, let us know.

Okay, I'm trying this again. Removed the repository I cloned yesterday. Went to https://github.com/dotnet/samples, clicked the green Clone or download button, go into Visual Studio 2019, and clicked on Clone a repository. Left clicked on File, Open, Open from Github, then pressed the Clone button.Then went to Solution Explorer. Navigated to console-webapiclient. Double-click on webapiclient.csproj. I don't see an option to run the program, so I go into Package Manager Console and type dotnet restore. I get the following output:
...
--------------------------------------------------------------------------------------MSBUILD : error MSB1003: Specify a project or solution file. The current working directory does not contain a project or solution file.PM> pwd
Path                                      ----                                      C:\Users\lgh19\source\repos\dotnet\samples
PM> dotnet rundotnet : Couldn't find a project to run. Ensure a project exists in C:\Users\lgh19\source\repos\dotnet\samples, or pass the path to the project using --project.At line:1 char:1+ dotnet run+ ~~~~~~~~~~    + CategoryInfo          : NotSpecified: (Couldn't find a...sing --project.:String) [], RemoteException    + FullyQualifiedErrorId : NativeCommandError PM>
What now?    On Tuesday, June 16, 2020, 08:11:55 AM PDT, Bill Wagner<EMAIL_ADDRESS>wrote:
Hello @laurametzner
Have you compared your code to the version here in our sample repository? That should help find any differences. That version does run correctly, and should be able to help you diagnose the issue.
If you have further questions, let us know.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Okay, I navigated to C:\Users\lgh19\source\repos\dotnet\samples\csharp\getting-started\console-webapiclient. Did a dotnet restore and dotnet run. I got this:
PM> dotnet restore  Determining projects to restore...  All projects are up-to-date for restore.PM> dotnet runBenchmarkDotNetPowerful .NET library for benchmarkinghttps://github.com/dotnet/BenchmarkDotNethttps://benchmarkdotnet.org/54086/16/2020 6:16:27 AM
reactiveThe Reactive Extensions for .NEThttps://github.com/dotnet/reactivehttp://reactivex.io/43866/14/2020 11:15:34 PM
efcoreEF Core is a modern object-database mapper for .NET. It supports LINQ queries, change tracking, updates, and schema migrations.https://github.com/dotnet/efcorehttps://docs.microsoft.com/ef/91796/16/2020 12:04:52 PM
aspnetcoreASP.NET Core is a cross-platform .NET framework for building modern cloud-based web applications on Windows, Mac, or Linux.https://github.com/dotnet/aspnetcorehttps://asp.net/179366/16/2020 12:43:27 PM
ScaffoldingCode generators to speed up development.https://github.com/dotnet/Scaffolding
3336/11/2020 9:50:28 PM
Docker.DotNet:whale: .NET (C#) Client Library for Docker APIhttps://github.com/dotnet/Docker.DotNethttps://www.nuget.org/packages/Docker.DotNet/11875/9/2020 3:03:30 AM...
Is this the expected output?
Thanks,Laura Metzner    On Tuesday, June 16, 2020, 12:46:46 PM PDT, Laura Metzner<EMAIL_ADDRESS>wrote:
Okay, I'm trying this again. Removed the repository I cloned yesterday. Went to https://github.com/dotnet/samples, clicked the green Clone or download button, go into Visual Studio 2019, and clicked on Clone a repository. Left clicked on File, Open, Open from Github, then pressed the Clone button.Then went to Solution Explorer. Navigated to console-webapiclient. Double-click on webapiclient.csproj. I don't see an option to run the program, so I go into Package Manager Console and type dotnet restore. I get the following output:
...
--------------------------------------------------------------------------------------MSBUILD : error MSB1003: Specify a project or solution file. The current working directory does not contain a project or solution file.PM> pwd
Path                                      ----                                      C:\Users\lgh19\source\repos\dotnet\samples
PM> dotnet rundotnet : Couldn't find a project to run. Ensure a project exists in C:\Users\lgh19\source\repos\dotnet\samples, or pass the path to the project using --project.At line:1 char:1+ dotnet run+ ~~~~~~~~~~    + CategoryInfo          : NotSpecified: (Couldn't find a...sing --project.:String) [], RemoteException    + FullyQualifiedErrorId : NativeCommandError PM>
What now?    On Tuesday, June 16, 2020, 08:11:55 AM PDT, Bill Wagner<EMAIL_ADDRESS>wrote:
Hello @laurametzner
Have you compared your code to the version here in our sample repository? That should help find any differences. That version does run correctly, and should be able to help you diagnose the issue.
If you have further questions, let us know.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.


Update how to run Hugo locally

This PR updates intermediate contribution guidelines based on feedback in https://github.com/kubernetes/website/pull/16814#discussion_r334511843.
/assign @aimeeu
Preview link
https://deploy-preview-16982--kubernetes-io-master-staging.netlify.com/docs/contribute/intermediate/#view-your-changes-locally

Thanks for the quick PR, @zacharysarah!
@sftim - this looks good to me, but I can't officially leave /lgtm.

@zparnold Wrangle on, wrangler! 🤠

/assign @bradtopol

/approve


Book recommendation about Kestrel architecture

Discussed in https://github.com/dotnet/AspNetCore.Docs/discussions/28068

Originally posted by lukasgmt January 11, 2023
Could you recommend any deep dive book that describes the internal Kestrel architecture. Most of the books focus on the ASP.NET, MVC, Razor etc. while I am mostly focused on all the available middlewares and their configurations.
What I am attempting to write is a reverse proxy that:

Is a mitigator of OAuth authentication
Hides OAuth tokens behind cookies
Refresh them inside my reverse proxy depending on how recently the tokens were resolved (in a timer)
Store tokens in Redis in order to share them across replicas of the reversed proxy

I am trying to use embedded Cookie and Authentication middlewares but so far I am failing in properly configuring them.
Would you recommend to implement it on my own or try to reuse some of OAuth + Cookies middeware?

Associated WorkItem - 63807

@Tratcher  what's the best way to deep dive into Kestrel. Let me know if your answer should be added to this doc.

Our docs are the most extensive resource I'm aware of for Kestrel. However, I don't think the internals are that important for your scenario. Have you looked into using YARP? It's a reverse proxy we built on top of AspNetCore/Kestrel. https://github.com/microsoft/reverse-proxy
Here are some examples I found that build something similar using YARP:
https://github.com/manfredsteyer/yarp-auth-proxy
https://damienbod.com/2021/01/11/protecting-legacy-apis-with-an-asp-net-core-yarp-reverse-proxy-and-azure-ad-oauth/

Thanks for contacting us. We believe that the question you've raised have been answered. If you still feel a need to continue the discussion, feel free to reopen it and add your comments.


Support api

Thank you for good project
It very works well but I want use it by api
like /sdapi/v1/img2img
is it support using by api?
Thank you

I will try to make this soon :) Thanks for your feedback!

Added API support with the latest update :)


Add option to disable markdown highlighting in JSDoc comments

Would it be possible to add an option to disable the markdown highlighting in JSDoc comments?
{
    // can be used to explicitly opt into disabling the default behavour
    "jsdoc.disableMarkdownHighlighting": false,

    // explicitly describes the default behavour, disabling it on `false`
    "jsdoc.highlightMarkdown": true,
}

As for my motive (or use case): it's distracting when using JSDoc types in plain JavaScript 😢

Depends on #53885

This functionality now ships as an extension: https://marketplace.visualstudio.com/items?itemName=bierner.jsdoc-markdown-highlighting


Move to using Yaml by default (Fix #833 and #784)

We can see the error messages here, and they look very friendly!
Note that the actual change is finally flipping two switches.  I intend to leave both sets of code in for a while so in the worst case, we can switch right back with no effort.
I also renamed the file bp.util.json.py to the much clearer "data_file.py" - I should have done that at the start but I didn't think of it and didn't want to go back and do it.

No.  I want to do that in a later minor release, just so we change one
thing at a time.
Each of these impacts end-user reliability to some extent...
On Tue, May 29, 2018 at 2:26 PM, Adam Haile<EMAIL_ADDRESS>wrote:

But looks like you didn't change to the new yaml parser??
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ManiacalLabs/BiblioPixel/pull/841#issuecomment-392757551,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPdsjwTYCtdmOGtMtRwjeK255jwmQC6ks5t3T5ggaJpZM4URYxy
.

--
/t
https://tom.ritchford.com https://tom.ritchford.com
https://tom.swirly.com https://tom.swirly.com

Fair. LGTM


Recaptcha integration

Is there an issue linked to it?
What's the behavior of this?

@xdamman https://github.com/opencollective/opencollective/issues/1457


flutter_service_worker.js does not work correctly when used from a subdirectory

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce

Build a Flutter project for web using flutter build web --base-href=/test/.
Copy the output from build/web into a subdirectory of your webserver, e.g. https://www.myexample.com/test .
Open the URL, i.e. https://www.myexample.com/test in Firefox (it can be better seen in Firefox because Chrome seems to have an own caching fallback).
Open the "Inspect" window of Firefox by right-clicking the page and selecting "Inspect". Open the "Network" tab.
Ensure that "Disable cache" is turned off (cache should be used).
Reload the page.

Expected results
In the "Transferred" column you should see the text "service worker", because the service worker has already loaded all files and should now provide it to the browser so that they don't need to be loaded again.
Actual results
However, instead the sizes of the files are displayed, which means that they were downloaded again.
Code sample
Code sample
The code sample can be created using `flutter create test`.

Screenshots or Video

Screenshots / Video demonstration

Logs
It can be fixed using this patch for the flutter_service_worker.js file:
Index: build/web/flutter_service_worker.js
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/build/web/flutter_service_worker.js b/build/web/flutter_service_worker.js
--- a/build/web/flutter_service_worker.js	(revision d76e8b2ab7eb6d45ab6f3d6fcc52c2822df66280)
+++ b/build/web/flutter_service_worker.js	(date<PHONE_NUMBER>385)
@@ -161,6 +161,7 @@
   }
   var origin = self.location.origin;
   var key = event.request.url.substring(origin.length + 1);
+
   // Redirect URLs to the index.html
   if (key.indexOf('?v=') != -1) {
     key = key.split('?v=')[0];
@@ -168,6 +169,23 @@
   if (event.request.url == origin || event.request.url.startsWith(origin + '/#') || key == '') {
     key = '/';
   }
+
+    // Get the URL of the service worker script
+  var serviceWorkerUrl = self.location;
+
+  // Create a new URL that's relative to the service worker script
+  const path = self.location.pathname
+      .split('/')
+      .slice(0, -1)
+      .join('/')
+      .substring(1) + "/";
+
+  if (!key.startsWith(path)) {
+    return;
+  }
+
+  key = key.substring(path.length);
+
   // If the URL is not the RESOURCE list then return to signal that the
   // browser should take over.
   if (!RESOURCES[key]) {

The problem is that "key" contains the subdirectory but the list of files in flutter_service_worker.js does not. So what this modification does is to remove the subdirectories from "key". The path of the subdirectories is retrieved by getting the path of the flutter_service_worker.js file itself, i.e. self.location.pathname.
When using this patch, the service worker works fine and "service worker" appears in the "Transferred" column when reloading the page. When not using this patch, the service worker does not cache any files and the browser has to load them again (or in case of Chrome get them from its own cache).
Flutter Doctor output
Doctor output
Doctor summary (to see all details, run flutter doctor -v):
[!] Flutter (Channel stable, 3.10.5, on macOS 12.6 21G115 darwin-arm64, locale en-DE)
[✓] Android toolchain - develop for Android devices (Android SDK version 32.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 14.2)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2020.3)
[✓] Android Studio (version 2021.3)
[✓] IntelliJ IDEA Ultimate Edition (version 2022.2.3)
[✓] IntelliJ IDEA Community Edition (version 2022.2.3)
[✓] VS Code (version 1.76.0)
[✓] Connected device (5 available)
[✓] Network resources

Thanks for the detailed report and potential fix in the file. Seeing the same behavior as reported.

 stable, master flutter doctor -v
[!] Flutter (Channel stable, 3.10.5, on macOS 12.2.1 21D62 darwin-x64, locale
    en-GB)
    • Flutter version 3.10.5 on channel stable at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 796c8ef792 (2 days ago), 2023-06-13 15:51:02 -0700
    • Engine revision 45f6e00911
    • Dart version 3.0.5
    • DevTools version 2.23.1
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

[!] Flutter (Channel master, 3.12.0-13.0.pre.38, on macOS 12.2.1 21D62
    darwin-x64, locale en-GB)
    • Flutter version 3.12.0-13.0.pre.38 on channel master at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 9760bb0cf0 (3 hours ago), 2023-07-03 13:54:18 +1200
    • Engine revision e6b8292705
    • Dart version 3.1.0 (build 3.1.0-262.0.dev)
    • DevTools version 2.25.0
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/dhs/Library/Android/sdk
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for
      more details.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 13C100
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] IntelliJ IDEA Ultimate Edition (version 2021.3.2)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 65.1.4
    • Dart plugin version 213.7228

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.29.0

[✓] Connected device (3 available)
    • Darshan's iphone (mobile) • 21150b119064aecc249dfcfe05e259197461ce23 • ios
      • iOS 15.3.1 19D52
    • macOS (desktop)           • macos                                    •
      darwin-x64     • macOS 12.2.1 21D62 darwin-x64
    • Chrome (web)              • chrome                                   •
      web-javascript • Google Chrome 109.0.5414.119

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

Deduplicating into https://github.com/flutter/flutter/issues/111866


Update Parameter: "Resource" to "Scope"

This page incorrectly states that "resource": "https://api.securitycenter.microsoft.com" needs to be provded in the POST body when authenticating (getting an access token). The correct value appears to be "scope": "https://api.securitycenter.microsoft.com/.default". I suspect other pages that reference the resource parameter need to be updated too, such as this.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 2a700a4e-82ff-29ce-1b68-247de33652db
Version Independent ID: bff8c6c3-eb28-1846-c711-36a7c67167aa
Content: Create an app to access Microsoft Defender for Endpoint without a user
Content Source: microsoft-365/security/defender-endpoint/exposed-apis-create-app-webapp.md
Service: microsoft-365-security
Sub-service: mde
GitHub Login: @mjcaparas
Microsoft Alias: macapara

@HPS-RobRice Thank you for your feedback. We have made changes to the document via pR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/10617
Once the author approves, the changes will be live.
Thanks
Sri

@msbemba Thank you very much for the contribution and updating the documentation with PR. @HPS-RobRice Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


ConnectionError: connection timeout

Getting the following error
broker task failed
Traceback (most recent call last):
File "/usr/local/lib/python3.7/dist-packages/aioxmpp/stream.py", line 1939, in _run
timeout=timeout)
File "/usr/lib/python3.7/asyncio/tasks.py", line 363, in wait
return await _wait(fs, timeout, return_when, loop)
File "/usr/lib/python3.7/asyncio/tasks.py", line 456, in _wait
await waiter
concurrent.futures._base.CancelledError
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.7/dist-packages/aioxmpp/stream.py", line 892, in _done_handler
task.result()
File "/usr/local/lib/python3.7/dist-packages/aioxmpp/stream.py", line 1987, in _run
raise self._xmlstream_exception
ConnectionError: connection timeout (dead time hard limit exceeded)
stream failed: connection timeout (dead time hard limit exceeded)

I've known about this error for quite some time but never managed to find a solution to it. The error seems to be raised only on specific accounts and other problems are often noticed on these accounts making everything unstable. The best fix for now is to make a new account and use that if possible.

mh really strange, i will try it on another account. Maybe the best way to resolve this issue is to debug all functions where python can raise this error and access the aioxmpp Library

A little update on this issue. After experiencing a little bit myself I have noticed that the event "member expire" event seems to be called whenever this happens. Not sure exactly how this works considering the error is raised because of a cancel error from the xmpp connection, but regardless I might have some workarounds for this issue. One of them might be to recreate the xmpp session or just call Client.restart(). I will look more into it in the future but for now this is still quite rare (i would say it happens on 1-2 of 100 accounts).

Not sure why you closed this issue. No fixes has been made for this particular bug and therefore im opening the issue again.
As to any updates on it I can say that I've been digging a bit and discovered that it has something to do with these aioxmpp stream variables:

soft_timeout
round_trip_time
Both are set to datetime.timedelta(minutes=1) by default but my hypothesis is that this might be too low for some scenarios. I'm currently testing with 5 minutes instead of 1 on one of my projects that have somewhere around 200 bots running simultaneously. This is the only place I've seen the bug before. I'll update this thread when I have the results after running it for a couple of days.

After testing for a while the error has seemed to disappear. Therefore I decided to add the fix to master.


Potential false-positive of rustdoc::broken_intra_doc_links lint

It seems that the bug fixed in 7bfef4b2befee954bc002724c8331612fed3d47f re-appeared. I tested with both Rust 1.80.1 and 1.81.0.
use syn::Ident;

/// Do stuff with [`Ident`].
#[allow(dead_code)]
fn do_stuff(_: Ident) {}

The error message only appears when running cargo doc --document-private-items (just cargo doc is fine). Previously, this didn't cause any hiccups. What is the suggested solution here?

Error Message
warning: `Ident` is both a function and a struct
 --> ../bug.rs:3:21
  |
3 | /// Do stuff with [`Ident`].
  |                     ^^^^^ ambiguous link
  |
  = note: `#[warn(rustdoc::broken_intra_doc_links)]` on by default
help: to link to the function, add parentheses
  |
3 | /// Do stuff with [`Ident()`].
  |                          ++
help: to link to the struct, prefix with `struct@`
  |
3 | /// Do stuff with [`struct@Ident`].
  |

I think in order to be compatible with --document-private-items you would need to write [`struct@Ident`] as suggested in the error message.

Alright, thank!


ISPN-15622 Enable stats in RESP and Memcached by default

https://issues.redhat.com/browse/ISPN-15622

Thanks, @tristantarrant


Add offer + request options to invites

Add offer + request options to invites.
When generating the invite there are 2 cases:

For GitHub, we know the userId we are inviting, so now if offer or request is checked, we create a RemoteUser object for that userId, and init the correct permissions.
For other networks, we don't know the userId(s) who will be receiving the invite, so we add permission token data to the invite URL.

When receiving an invite URL with permission data, the receiver:

Creates a new RemoteUser object for the user who generated the invite
Creates a new RemoteInstance object for the instance who generated the invite, and simulates a InstanceHandshake message from that instance with the appropriate consent bits set (so they appear in the buddylist as having offered or requested access).
If the instance is currently online, it sends the permission code back to the inviter to validate, in a PERMISSION_TOKEN message.
If the instance is currently offline, it sets unusedPermissionToken so that it will send the permission code back later when that instance appears online

When the inviter receives a PERMISSION_TOKEN message it:

Checks if that permission token is still valid for the receiving user
Sets appropriate consent fields
Sends a new InstanceHandshake back to the invitee.

If someone tries to spoof an invite (using an invalid permission token or lying in the isOffering field), they will trick the UI of their own uProxy to think that they have permission, but because the other side will not validate their permission token, they will not be able to get access.

This change is

Small nits mostly -- looks great + sorry for the delay!

Reviewed 17 of 17 files at r1.
Review status: all files reviewed at latest revision, 6 unresolved discussions, some commit checks failed.

src/generic_core/local-instance.ts, line 91 [r1] (raw file):
Do you mean that LocalInstanceState doesn't include invitePermissionTokens because we don't want to save that to storage? Maybe the comment can be "returns all fields of LocalInstanceState plus invitePermissionTokens"

src/generic_core/local-instance.ts, line 108 [r1] (raw file):
Do we need to set it to [] if it's undefined?

src/generic_core/remote-user.ts, line 556 [r1] (raw file):
Just to check: are we taking these out because https://github.com/uProxy/uproxy/issues/1510 is resolved?

src/generic_core/social.ts, line 690 [r1] (raw file):
Maybe add comment: "Quiver, FB, Gmail and Cloud invites do not specify a recipient, so userId will not be defined."

src/generic_ui/polymer/network-invite-user.ts, line 14 [r1] (raw file):
nit: use camelcase: createInviteArgs

src/generic_ui/polymer/network-invite-user.ts, line 143 [r1] (raw file):
nit: newline

Comments from Reviewable

Review status: 15 of 17 files reviewed at latest revision, 6 unresolved discussions, some commit checks failed.

src/generic_core/local-instance.ts, line 91 [r1] (raw file):
No, I mean that LocalInstanceState contains 6 fields:
  instanceId       :string;
  userId           :string;
  userName         :string;
  imageData        :string;
  invitePermissionTokens :{ [token :string] :PermissionTokenInfo };
  exchangeInviteToken : (token :string, userId :string) => PermissionTokenInfo;

However this method only returns 5 fields (it doesn't return exchangeInviteToken since that is a method, not data, and methods shouldn't be written to storage:
  instanceId       :string;
  userId           :string;
  userName         :string;
  imageData        :string;
  invitePermissionTokens :{ [token :string] :PermissionTokenInfo };

Although now that I look at it again maybe there is some way I can refactor this so exchangeInviteToken is not part of LocalInstanceState anymore but is some global standalone method...

src/generic_core/local-instance.ts, line 108 [r1] (raw file):
That initialization (to {}) is taken care of on line 28

src/generic_core/remote-user.ts, line 556 [r1] (raw file):
Yes - because we've removed GTalk

src/generic_core/social.ts, line 690 [r1] (raw file):
Just updated the comment, I just realized data.userId will be set for cloud (it is actually the "userId" of the cloud server we wish to share, as a user in theory could have multiple servers they could potentially share)

Comments from Reviewable

Small comment changes then :+1:

Reviewed 1 of 2 files at r2, 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.

src/generic_core/local-instance.ts, line 91 [r1] (raw file):
Oh got it! Maybe edit the comment to say "This does not ... because we don't want" instead of "This does not ... because it does we don't want"
Also maybe add a TODO for moving exchangeInviteToken outside of LocalInstanceState?

Comments from Reviewable

Review status: 16 of 17 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

src/generic_ui/polymer/network-invite-user.ts, line 14 [r1] (raw file):
Done.

Comments from Reviewable


"MISSING: command" at top level of crate

I don't really know what this means. The item is also clickable, but all it does is create a notification in the bottom right of my screen that says: command 'missing' not found which doesn't explain very much.
On the plus side, it does not seem to be interfering with rust-analyzer's diagnostics in any way.

This has been fixed and should disappear next stable release. https://github.com/rust-analyzer/rust-analyzer/pull/8183
Regarding what this is, this appears when annotations can't be resolved(the 135 implementations thing that appears above structs and the like), this resolving failure happens when macros create items currently which then appears at the top of the file as the text ranges are mapped incorrectly.

@Veykril, with the latest rust analyzer(ra afterwards), I find  a bug:
In my module, I defined struct named AgentPG in file agentPG, and it is declared in the same folder of file mod.rs with``pub mod agentPG;  But still , ra mentioned "MISSING: command"   in file agentPG, and when I click the yellow light button on the right side,  it asked whether to add mod AgentPg or pub mod AgentPg., finally, the mod.rs file could be like this：
pub mod agentPG;//what I add
mod AgentPg;// what added automatically，

As you can see ,the auto generated struct name is incorrect.

This seems unrelated to this PR(the missing command stuff seems to be a side effect).
Can you open a new issue aboue this with more information on the project structure?

@Veykril, thanks for reply.  I mentioned it here：https://github.com/rust-analyzer/rust-analyzer/issues/9707


Website construction/implementation tracker

Creating this issue as a placeholder to track all iterative design & implementation process for the website construction.
Comments will be left here to request changes to be made to the website.

Thanks for the quick update! Some follow-up items:

[ ] For homepage banner - let's use the same color with other subpages
[ ] for the 5 subpages, reorder them so that it shows as Home, Learn, Blog, Contribute, About on the homepage
[ ] On the homepage, is it possible to make the NEST logo a bit smaller, and leave some space between the tagline and the subpage headers?
[ ] For the 'core function' section, the background color could be set as the same with other sections as well?
[ ] For the timeline, I can see the icon color changes when I hover on them, is it possible to show a popup textbox when hovering/clicking on these icons (to show some detailed text)? In addition, is it feasible to have a scrolling horizontal timeline (to show more than 7 items potentially). I found one template here (https://codepen.io/kentchangdesign/pen/jadgvx) but maybe it's too fancy?

@ProjectsOfMLee for the blog subpage - when we have multiple posts, is it possible to have a search functionality, as well as a filter on the side with year/month? In addition, how could the 3 most recent posts on the blog subpage automatically linked to the main page?


Perform fixes over the MongoDB Timestamp and other custom funtions

DRILL-XXXX: PR Title
(Please replace PR Title with actual PR Title)
Description
(Please describe the change. If more than one ticket is fixed, include a reference to those tickets.)
Documentation
(Please describe user-visible changes similar to what should appear in the Drill documentation.)
Testing
(Please describe how this PR has been tested.)

One more thing, please rebase on current master.

@orcascope. Did you see my comments?

@orcascope Bump... Are you planning on completing this.


.available() method succeeds on iPad ( and shouldn't ? )

Hi there,
Thanks so much for this plugin, which has saved me countless hours of frustration and helplessness.
I'm currently working on a universal app, primarily iPhone, but optimized for iPad as well. The app pulls data from HealthKit where available, and falls back to a manual entry option when it's not present (e.g. iOS 7).
While researching how to run an app with the HealthKit entitlement on a device that doesn't have HK, I came across [this solution] (http://stackoverflow.com/a/25658268/697061). Under the Project Info in Xcode, I removed 'healthkit' from the list of 'Required device capabilities' in the Target Properties list. Then, in the General tab > Linked Frameworks and Libraries, I set 'HealthKit.framework' to Optional instead of Required.
So, when I review 'Capabilities' > HealthKit, I see an alert prompting me to 'Add the "HealthKit" key to your info plist file'. However the app nows run on these devices.
Which brings me to my issue: testing on an iPad 2 running iOS 8.2, I noticed that the .available() method in the HealthKit plugin is succeeding, even though HealthKit isn't currently available on iPads. So, my users will see HealthKit-related buttons that attempt to execute queries against HealthKit, because the app assumes HealthKit is available. These queries fail silently in the debugger.
My current code:
		if("device" in window){

			if(window.device.platform == "iOS"){

				if(window.device.version.split(".")[0] == "8"){

					window.plugins.healthkit.available( // succeeds where it shouldn't
						function(isAvailable) {
							controller.set("healthKit", true);
						}
					);

				}
			}
		}

I've tested this on an iPad 2 and 4th-gen iPad, both running iOS 8.2. If this isn't a bug in your code (i.e. Apple's fault), I could always filter out iPads when testing the device capabilities. However, this would mean I would need to issue a subsequent app update when Apple makes HealthKit more widely available.
Can you please advise whether this is a bug or not? If it's not, will you take any action in your codebase to pre-empt Apple's upstream bug? For example, if you ran a check like ( os-version < 8.2 && device-type == "iPad"), you could return a failure for this and previous OS versions, but leave the door open for a fix in subsequent software updates by Apple. This would future-proof your code, and would save developers from having to issue app updates once Apple issues a patch.
Interested to hear your thoughts, and thanks again!

Hey @stickbyatlas thanks for the elaborate issue report.
You code sample reveals the issue: You need to check the value of isAvailable in the callback function of window.plugins.healthkit.available : it's a boolean indicating whether or not HK is available on the device.
I will look into the 'entitlement' related question as well.
Good luck,
Eddy

Hi, I just removed the .plist value from the plugin so this should be iPad compatible out of the box from now on. Thanks for your research on this! Fixed in version 0.3.2.
Note for users of older version of the plugin: iPad usage was only broken on 0.3.1 (not before) because that version added the .plist bit.

Whoops - I had assumed .available took two function params, where the first was equivalent to onSuccess and the second onError. Thanks for clearing that up so quickly!


Start pod infra container when pod is created

When we create a pod that also has an infra container, we should
start the infra container automatically.  This allows users to add
running containers to the pod immediately.
Signed-off-by: baude<EMAIL_ADDRESS>

LGTM

bot, retest this please

LGTM assuming happy tests

Does this mean the pause container gets launched when I do
podman pod create
as opposed to having to do
podman pod start -l
After the pod was created?

@rhatdan Yes.
We should probably reference CRI-O to see when they start theirs.

It looks like CRI-O starts the infra container at pod creation - like this PR would do. I think we're good to merge here.

@rh-atomic-bot r+

@rh-atomic-bot retry


add reason for joing and name columns to user's table

@otsembo Can this be merged to development so that @Muriithi-Gitonga and @mackrineawino can work with it?


Support zos for AQA releases

Signed-off-by: lanxia<EMAIL_ADDRESS>

zos: Grinder link
xlinux: Grinder link

FYI @pshipton I will port this PR into the release branch (v0.8.0-release) after the merge. Then I will update testenv_zos.properties to use ibm-jdk11-zOS-11.0.14 in v0.8.0-release.

What happens when you don't specify JDK11_OPENJ9_REPO and BRANCH in the testenv file? I'm thinking that the builds already specify the OPENJ9 and JDK-X repos and branches. Maybe the testenv only needs to specify TCK, STF, and systemtest repos/branches, and OpenJ9 and OpenJDK comes from the build itself. This would work better for personal builds, ifix builds, etc.

What happens when you don't specify JDK11_OPENJ9_REPO and BRANCH in the testenv file? I'm thinking that the builds already specify the OPENJ9 and JDK-X repos and branches. Maybe the testenv only needs to specify TCK, STF, and systemtest repos/branches, and OpenJ9 and OpenJDK comes from the build itself. This would work better for personal builds, ifix builds, etc.

Currently, we do not handle both job parameters (test repos) and testenv file. It is either-or.
If JDK11_OPENJ9_REPO and BRANCH are not in testenv, I think they will be set to empty, then the default repo and branch in openjdk/build.xml will be used (https://github.com/ibmruntimes/openj9-openjdk-jdk11.git)


Failing to start magicmirror

[25.01.2022 14:41.07.788] [ERROR] App threw an error during load
[25.01.2022 14:41.07.795] [ERROR] Error: Cannot find module 'request'

Require stack:
- /opt/magic_mirror/modules/MMM-Wallpaper/node_helper.js
- /opt/magic_mirror/js/app.js
- /opt/magic_mirror/js/electron.js
- /opt/magic_mirror/node_modules/electron/dist/resources/default_app.asar/main.js
-
    at Module._resolveFilename (node:internal/modules/cjs/loader:940:15)
    at Function.n._resolveFilename (node:electron/js2c/browser_init:249:1128)
    at Function.Module._resolveFilename (/opt/magic_mirror/node_modules/module-alias/index.js:49:29)
    at Module._load (node:internal/modules/cjs/loader:785:27)
    at Function.c._load (node:electron/js2c/asar_bundle:5:13331)
    at Module.require (node:internal/modules/cjs/loader:1012:19)
    at require (node:internal/modules/cjs/helpers:94:18)
    at Object.<anonymous> (/opt/magic_mirror/modules/MMM-Wallpaper/node_helper.js:4:17)
    at Module._compile (node:internal/modules/cjs/loader:1116:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1169:10)

[25.01.2022 14:41.07.800] [ERROR] Whoops! There was an uncaught exception...
[25.01.2022 14:41.07.821] [ERROR] Error: Cannot find module 'request'

Require stack:
- /opt/magic_mirror/modules/MMM-Wallpaper/node_helper.js
- /opt/magic_mirror/js/app.js
- /opt/magic_mirror/js/electron.js
- /opt/magic_mirror/node_modules/electron/dist/resources/default_app.asar/main.js
-
    at Module._resolveFilename (node:internal/modules/cjs/loader:940:15)
    at Function.n._resolveFilename (node:electron/js2c/browser_init:249:1128)
    at Function.Module._resolveFilename (/opt/magic_mirror/node_modules/module-alias/index.js:49:29)
    at Module._load (node:internal/modules/cjs/loader:785:27)
    at Function.c._load (node:electron/js2c/asar_bundle:5:13331)
    at Module.require (node:internal/modules/cjs/loader:1012:19)
    at require (node:internal/modules/cjs/helpers:94:18)
    at Object.<anonymous> (/opt/magic_mirror/modules/MMM-Wallpaper/node_helper.js:4:17)
    at Module._compile (node:internal/modules/cjs/loader:1116:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1169:10) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/opt/magic_mirror/modules/MMM-Wallpaper/node_helper.js',
    '/opt/magic_mirror/js/app.js',
    '/opt/magic_mirror/js/electron.js',
    '/opt/magic_mirror/node_modules/electron/dist/resources/default_app.asar/main.js',
    undefined
  ]
}
[25.01.2022 14:41.07.826] [ERROR] MagicMirror will not quit, but it might be a good idea to check why this happened. Maybe no internet connection?
[25.01.2022 14:41.07.828] [ERROR] If you think this really is an issue, please open an issue on GitHub: https://github.com/MichMich/MagicMirror/issues

It looks like you didn't perform the Install the module dependencies step:
cd MMM-Wallpaper
npm install

Thank you! If someone is using MagicMirror inside docker container - this command will help:
docker exec -it mm npm install --prefix ./modules/MMM-Wallpaper


crash uv_now(ts_loop)

When the enrollment identity fails, continuing the enrollment will crash, which may not necessarily occur, but continuous enrollment will crash, displayed in the uv_now(ts_loop)
Has anyone encountered this problem? I have tried many methods but none have worked, including modifying the uv_loop_t Creation and destruction.

Hello and thanks for the report. I believe this is the same crash that is observed in #193. I have been able to reproduce this crash with ziti-tunnel-apple, but not reliably. I'll be taking a closer look this week.

Duplicate of #193


Dune switch [do not merge]

If we do this, then it compiles with dune, but all the tests and examples fail like
File "/home/berenger/src/ocamlscript/tests/./unpack", line 9, characters 0-26:
Error: Unbound module Ocamlscript

Hence the [do not merge].

related to https://github.com/mjambon/ocamlscript/issues/7