Improve/fix drag-and-drop

Fixes #154

Make drag and drop much smoother (see demo in the issue)
Added react-native-gesture-handler and react-native-reanimated libraries

These libs work much better than react-native's gesture responder system  and Animated APIs
This will allow much better animations and interactions, for example #58 or #130

Lmk what you think!

Hi @pdpino, I tried to run on local but the calendar is frozen and I couldn't perform any action, anything specific I need to set up when running on local?

nvm, I can make it work now.

@hoangnm only installing peer dependencies react-native-gesture-handler v2 and react-native-reanimated v2, following their instructions

Drag & drop are really smoother, this would be a great improvement.

I'm thinking to use this feature as a version 2 and I'll bump the current code base to v1.

Some users might be using in production: yes
But I think the API might still change, e.g. some props:

numberOfDays for the horizontal-pinch gesture
startHour, hoursInDisplay, timeStep for the vertical-pinch gesture
Or others: https://github.com/hoangnm/react-native-week-view/issues/58, https://github.com/hoangnm/react-native-week-view/issues/128, https://github.com/hoangnm/react-native-week-view/issues/141#issuecomment-942321193, https://github.com/hoangnm/react-native-week-view/issues/186

I prefer keeping 0.x, we can worry less about backward compatibility, and finish some of these new features first.

ok @pdpino , that makes sense.

Great PR, merging.


Return different exit codes for different failures

Hey,
another request error/exit code handling.
Hey, nice feature is if restic abort answer with an error code more than 0 or 1.
rsync example:
0      Success
1      Syntax or usage error
2      Protocol incompatibility
3      Errors selecting input/output files, dirs
4      Requested  action not supported: an attempt was made to manipulate 64-bit files on a platform
that cannot support them; or an option was specified that is supported by the client and not by the server.
5      Error starting client-server protocol
6      Daemon unable to append to log-file
10     Error in socket I/O
11     Error in file I/O
12     Error in rsync protocol data stream
13     Errors with program diagnostics
14     Error in IPC code
20     Received SIGUSR1 or SIGINT
21     Some error returned by waitpid()
22     Error allocating core memory buffers
23     Partial transfer due to error
24     Partial transfer due to vanished source files
25     The --max-delete limit stopped deletions
30     Timeout in data send/receive
35     Timeout waiting for daemon connection
For scripting restic its needed.
thanks
greetings
sam

Hey, thanks for suggesting this. Can you please elaborate what your use case is? Why do you need to know exactly what the error code was? What are the cases you need to distinguish in your script and why?

Coming here because I've expected restic to exit with non-zero code when it received a signal. Otherwise it is hard to terminate a script after restic terminated on request. In my case the script just doesn't terminate, deletes data that was not backed up yet (restic said good bye, w/o backing up as requested) and the next backup job unintentionally starts up. I tried to fix this by using trap in my script, but that's brittle and still destroys data now and then.
If everything exits with 0 no matter what, automation is hard. :slightly_smiling_face:

@wjkohnen Huh, that doesn't sound right, but I'm not sure I understood. Could you elaborate on your use case a bit? I understood you're running restic in a script, then you send a signal to restic? Which signal, and why?

Well, it's quite simple. A bash script (with set -e) iterates in a for loop over some directories, in each loop there is a call to restic. I hit ^c, because $reason, restic clean's up due to SIGINT, restic exits with 0, for loop iterates because there's no one telling bash to stop. trap "{ exit 27; }" SIGINT doesn't help.
Restic's code says effectively os.Exit(0) in src/cms/restic/cleanup.go. I've patched that to exit with 1, but it still exits with 0. So I am clearly missing something.

Thanks for describing your situation! It seems to me we have different expectations: I didn't think it was necessary to return an error code when the user requested termination via SIGINT, but I'm open to adding that.

New issue is #1064. Apparently I did not have my use case straight: actually I loop on the terminal over a restic wrapper script. Thanks!

In my restic-runner script for automated backups, I'm depending on the exit code to highlight this in the backup report - if the backup was successful or not.  I just noticed that disk-full scenarios also returns with exit code 0, so the backup logs are a bit misleading on the final result.
I'm not sure we need such a comprehensive list of failures as rsync have.  But having all non-fatal and non-critical scenarios return 0 is usually fine.  But to have a few other exit codes when the backup might or might not have happened correctly (if restic is in doubt, it is a failure) is really needed.

I just noticed that disk-full scenarios also returns with exit code 0, so the backup logs are a bit misleading on the final result.

Hu, that shouldn't be the case, and I'm not able to reproduce this. When the disc is full, restic panics and returns exit code 2 (the Go runtime does that). What did I do differently?

having all non-fatal and non-critical scenarios return 0 is usually fine. But to have a few other exit codes when the backup might or might not have happened correctly (if restic is in doubt, it is a failure) is really needed.

That should be the case. If not, I consider this a bug.

Ahh ... sorry, my mistake!  In my script I do:
 restic $args 2>&1 | log_stream
When checking $? it is reflecting the exit code of the log_stream function, not the restic call.

Okay, found the solution.  Seems I need to set set -o pipefail to get the restic exit code.  I'll test that out, but consider my issue resolved for now.

Nice, thanks for letting us know!

I've thought about this today, and I think we should improve the error handling: Restic should continue if possible (e.g. when just a single file could not be read), but return an error code so the admin is notified something is odd.

I have found what I believe to be a bug:
Running restic key backup / returns 0.  I ran into this when editing a previous command line.
Running restic snapshots -H athena returned 0 but didn't list any snapshots.
Running restic snapshots -H Athena (note the capitalisation) produced a list of snapshots.
I'd expect that like grep, if nothing matches, a non-0 exit is returned.
If you also believe that exiting true on incorrect invocation is aberrant behaviour, should I raise a separate issue for this, or would you be happy to tag this one bug (or whatever is appropriate)?

I like to follow this too, for automation exit codes for different errors is a must..

Hi there,
It is important for scripting to get different exit codes on different conditions.
The current documentation states :

Exit status is 0 if the command was successful, and non-zero if there was any error.
Note that some issues such as unreadable or deleted files during backup
currently doesn't result in a non-zero error exit status.

I happen to backup some directory under Windows with junctions (aka links) which have been moved. Restic reported an error about the file that cannot be accessed:
error: open \\?\C:\resticVSS\Source\Exerciser\flask-venv\bin\python3: The file cannot be accessed by the system.
but apparently also terminated with a non-zero exit code.
In such a case, the fact that the file cannot be accessed is valuable information that needs to be reported, but the error is not at all the same kind as if there were an error in transmitting the information to rsync for example.
I second the OP with the different exit status codes that were proposed.
Best regards and thanks for restic !

@BUFU1610 Can you please provide the full command and its output where the symptoms occurred?

The full command would be
restic -r sftp:user@host:/path/to/externalHDD backup /data
I no longer have that output and since in my rerun the error did not occur again, I cannot reproduce it.
It was an lstat error for one of the subdirs saying that "file or directory does not exist". After that line, restic continued with everything else and recorded "1 error" in the output the whole time - but still exited with 0.

@BUFU1610 Which restic version are you using?

I use restic 0.9.4 compiled with go1.11.6 on Void linux/arm64 on a NanoPi Neo 2.

@BUFU1610 Since restic 0.10.0 the backup commandreturns exit code 3 if warnings occur during the backup. So this is indeed caused by the old restic version.

Here's another use case in which returning a specific exit code would be useful: I have a shell script which helps me automate restic backup, restic prune, etc. It is configured to send me an alert if restic fails, which can be noisy because restic fails if the respository is locked (another restic process using the same repo is running). In such cases (restic fails because the repo is locked) I would like my script to fail without sending me an alert. If the exit code from restic contains info to tell me that it failed because of a lock, it solves this problem.
The current solution I have it to use restic list locks to check if a lock exists before running any restic command that needs a lock, but this is affected by race conditions (more info in my comment here).

Can someone implement this feature pleeease? 🥺
My restic script sends me an alert when restic exits unsuccessfully. Lately, I've been getting lots of "unable to save snapshot: context canceled" errors because of unreliable internet. Because I can't handle different error states, I have to alert on every error state, even benign ones such as this one. 😭

One more example when a distinct exit code could be useful is "Check if a repository is already initialized" article from the official docs. Instead of hunting down arbitrary and variable error string from stderr it would be much more practical to check for a specific return code.
This is a big pain point for scripting and automation. @fd0, @MichaelEischer is there a reason this feature was ignored or deprioritized for so long?

This is a big pain point for scripting and automation. @fd0, @MichaelEischer is there a reason this feature was ignored or deprioritized for so long?

No particular reason except there are far too many issues, PRs etc. waiting for attention at the same time. The number of open PRs is finally approaching a manageable level, which took a few years, so that we can start looking into various issues. It might be possible to fit this issue into restic 0.18/0.19 although there's already quite a lot of things planned for those releases.

I've opened a PR to add dedicated exit codes for a locked repository and for a non-existing repository. These seem to be the main use cases so far.

Thanks @MichaelEischer!
Would it be easy to add an exit code for errors related to unreliable internet?

@quinncomendant Those are much, much harder to handle, as network issues can show up nearly everywhere. It's also not always clear whether a backend error is a network error or a broken server. Being unable to connect to a server can be a problem of your internet connection OR a problem with the server. A "connection error" should never be reported for the latter type of problems.
restic 0.17.0 includes a reworked retry behavior that should be able to tolerate more internet reliability issues.


@babel/runtime should be a dev dependency

Every package in this monorepo specifies @babel/runtime as a dependency:
https://github.com/oliver-moran/jimp/blob/53ff9d1266207f7f674233f465ec358274510511/packages/jimp/package.json#L60-L61
However, this is a redundant package that is never used in the production code. It should be moved to the devDependencies section.

The current package size is 21MB, it is too big for my small project.

PRs welcome :D


Help/Bug with preference configuration

I have the following preferences.json:
{
    "type": "object",
    "properties": {
        "aliases": {
            "type": "array",
            "items": {
                "type": "object",
                "properties": {
                    "name": {
                        "type": "string"
                    },
                    "icon": {
                        "type": "string"
                    },
                    "command": {
                        "type": "string"
                    }
                }
            }
        }
    }
}

The preferences.json seems to be found but the [+] button doesn't do anything.

How can I debug that any further?

Fixed myself, "aliases" seems to be a reserved name.


Where is the "Protocol-Specific WebResponse"?

The code sample here does not do what the title says.  Should it at least cast to HttpWebResponse, or something?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e60878ca-ff38-a605-2713-c82f4698cd53
Version Independent ID: a4ba014d-1106-c9a7-dd9f-4f19ba691e60
Content: How to: Retrieve a Protocol-Specific WebResponse that Matches a WebRequest
Content Source: docs/framework/network-programming/how-to-retrieve-a-protocol-specific-webresponse-that-matches-a-webrequest.md
Product: dotnet-framework
Technology: dotnet-networking
GitHub Login: @karelz
Microsoft Alias: ncldev

Good point. Simple to fix -- see PR #22648.
Based off other samples e.g. in https://docs.microsoft.com/en-us/dotnet/api/system.net.httpwebresponse


Minor fix on text formatting (proposal)

UPDATES.md is the source for our release notes and conforms to Xamarin documentation style where this style is used for user interface navigation/descriptions and not this style.


Building with Android I got: "I'm so sorry!
Boost/1.66.0@conan/stable: Building your package in /Users/delamor/.conan/data/Boost/1.66.0/conan/stable/build/0af83277727e5ba82163757ff72525e5bc1da40e
Boost/1.66.0@conan/stable: Configuring sources in /Users/delamor/.conan/data/Boost/1.66.0/conan/stable/source
Boost/1.66.0@conan/stable: Downloading http://sourceforge.net/projects/boost/files/boost/1.66.0/boost_1_66_0.tar.gz/download...
[==================================================] 97.0MB/97.0MB
Boost/1.66.0@conan/stable: Copying sources to build folder
Boost/1.66.0@conan/stable: Generator txt created conanbuildinfo.txt
Boost/1.66.0@conan/stable: Calling build()
Boost/1.66.0@conan/stable: Using gcc 4.9
-n Bootstrapping the build engine with toolset darwin...
engine/bin.macosxx86_64/b2

Bootstrapping is done. To build and install, run:

    ./b2 install --prefix=<DIR>

Boost/1.66.0@conan/stable: Cross building, detecting compiler...
Boost/1.66.0@conan/stable:
Boost/1.66.0@conan/stable: ERROR: Package '0af83277727e5ba82163757ff72525e5bc1da40e' build failed
Boost/1.66.0@conan/stable: WARN: Build folder /Users/delamor/.conan/data/Boost/1.66.0/conan/stable/build/0af83277727e5ba82163757ff72525e5bc1da40e
ERROR: Boost/1.66.0@conan/stable: Error in build() method, line 71
	flags = self.get_build_flags()
while calling 'get_build_flags', line 124
	flags = self.get_build_cross()
while calling 'get_build_cross', line 102
	raise Exception("I'm so sorry! I don't know the appropriate binary "
	Exception: I'm so sorry! I don't know the appropriate binary format for your architecture. :'(

The recipe boost/1.1.0g@conan/stable comes with Android clang support. Try it and report! Thanks

This issue was moved to conan-community/community#87


GridView - can't set css class on tbody when empty rows

Render GridView widget with empty rows and table bootstrap class table table-hover
tbody (which contains $emptyText) changes it's background color on hover but I can't control that, because class empty is assigned to the div inside tbody
emptyTextOptions should be assigned to the tbody instead of div inside it

Q
A

Yii version
2.0.?

PHP version
7.0

Operating system
Windows

Works alright in current master.

See https://github.com/yiisoft/yii-dataview/blob/master/src/GridView.php#L634


jsxStyleProps minimal and none generates a css attribute in the DOM

Description
using css prop may end up generating an unexpected DOM attribute
panda.config
import { defineConfig } from '@pandacss/dev'

export default defineConfig({
  clean: true,
  eject: true,
  exclude: [],
  include: ['./src/**/*.{ts,tsx}'],
  jsxFramework: 'react',
  // none and minimal generate a css="[object Object]" in the DOM
  jsxStyleProps: 'minimal',
  outdir: 'styled-system',
  preflight: false,
  presets: [],
})

import { styled } from '../styled-system/jsx'

export const App = () => {
  return (

  )
}

generates

foo

Link to Reproduction
https://github.com/ivanbanov/pandacss-css-attr-bug
JS Framework
React
Panda CSS Version
0.13.1

closing since it was fixed in the new versions, it worked find with 0.16.0


Cli 1.0.19

add ci/cd script and update cdk resource packages

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


When inspecting an IceRepository there should be actions for pull and push

If the repository is in the right state, the inspector should offer actions for pulling and pushing.

We now have fetching and merging:

This is now available as part of the Git integration.


Ribbon Icons not maintaining position

Describe the bug
Since Obsidian was updated to allow ordering of the Ribbon toolbar, Workspace Ribbon icons (via Workspace Plus plugin) and other Ribbon icons revert to the order from before the update. Any new Workspace Icons added since that update go automatically to the top of the Ribbon as soon as they are pressed and stay at the top.
Relevant errors (if available)
No response
Steps to reproduce
Steps to reproduce the behavior:

Add Ribbon Workspace Icon in Commander
Order Ribbon icons by drag/drop or in Obsidian settings
Press on a new Ribbon Icon

Expected Behavior
The Icon should stay in place in the Ribbon bar. Instead, new icons move up to the top.
Additional context
No response
Operating system
macOS

I have been wrestling with this problem on my windows 11 setup as well

I'm using Win11. I just started using Commander about a week or so ago. Originally I only added icons from the left menu - search, bookmark list, folder list and recent files. Those icons were at the bottom of my list and everything was fine.
I started using Workspaces (the core function) and added an icon to the Ribbon menu via Commander. I had the Workspaces icon above the icons from the left menu and everything was fine.
A couple days ago I installed the Soomda plugin and added it's icon to the ribbon menu via Commander. I really want it at the bottom of that menu. What I've discovered is that when I load or reload a Workspace - either via the ribbon button, through the command pallet or by keyboard shortcut - the icons rearrange themselves to always have the ones I created (not just added) via Commander on the bottom. Nothing moves if I don't change their position after it changes itself to what I now think of as the Commander Ribbon default order.
Looking through the other issues here, the following may be related:
#67  - icons move on their own
#73 - drag and drop
#117 - adding button causes commander buttons to go to the bottom
#126 - order on tab not saved

+1 Same here. My fix is

save a workspace with all the buttons in correct order
add new button
reload workspace - all buttons will be in order except the new one
arrange your buttons the way you want it and re-save the workspace - you won't have a problem until you add another button - then repeat from step 1
Exception: whenever Kanban is updated the icon is added to the ribbon. I have to hide it and then go through the steps again.


yml file saved in provanance is not working

It is supposed to save the environment yml file, but is showing help menu for conda
http://portal.nersc.gov/project/acme/zhang40/ex_model_to_obs_climo_allsets_fixHadley/prov/environment.yml

Thanks for looking into this. In the function that does this, the command conda env export doesn't seem to be printing the env. It's just a matter of seeing what command will successfully display the env.

This seems to be fixed in 30dcf16b176516a40e3d92c85510c7c28b8de43e. Previously, all worked when shell=False. Then it didn't, so changing it to shell=True made it work... until it didn't. Not sure why. Regardless, having shell=False is the safer way to do it anyways.
See the results below:

@chengzhuzhang, please let me know if this works for you.

The fix worked! Thanks!


Quickstart Create ARM Template For MySQL Flex - Example ARMs for Public & Private Access Are Identical

https://github.com/MicrosoftDocs/azure-docs/blob/76a087b3af20e0bab5373a089ae6258226e26d1b/articles/mysql/flexible-server/quickstart-create-arm-template.md?plain=1#L27C1-L485C4
The two ARM examples are identical, private doesn't show how to lock down inside the vnet.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 93405ac1-2a34-1652-cd8d-53f725e5d6c0
Version Independent ID: f42d487a-a579-f84d-86d8-8949eacec4a1
Content: Quickstart: Create an Azure Database for MySQL - Flexible Server - ARM template
Content Source: articles/mysql/flexible-server/quickstart-create-arm-template.md
Service: mysql
Sub-service: flexible-server
GitHub Login: @shreyaaithal
Microsoft Alias: shaithal

@jklaus
Thanks for your feedback! We will investigate and update as appropriate.

@jklaus
Thank you for bringing this to our attention. You are correct that the two ARM examples in the article you linked are identical. The private example does not show how to lock down inside the VNet.
We apologize for any confusion this may have caused. We will update the article to include a separate example for locking down inside the VNet for the private deployment mode. Thank you for helping us improve our documentation.
Please add your ideas in below link, so our production team can review it and update the same.
Ideas · Community (azure.com)

@jklaus
We are going to close this thread .if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.

@jklaus
I've delegated this to @shreyaaithal, a content author, to review and share their valuable insights.

Hi - what is the ETA for adding a correct ARM template for Private access?

Hi @jklaus , @nparemski2 , the article has been updated with the correct ARM template for Private access.

#please-close


APP-3071: Update the configuration field for privateKey and certificate

Ticket
APP-3071
Description
Update the configuration field for privateKey and certificate
Dependencies
List the other pull requests that should be merged before/along this one.
Checklist

[x] Referenced a ticket in the PR title and in the corresponding section
[x] Filled properly the description and dependencies, if any
[x] Unit tests updated or added
[x] Javadoc added or updated
[x] Updated the documentation in docs folder

Accordingly should we update trustStorePath in BdkSslConfig too?
proxyUrl / proxyUsername / proxyPassword in BdkClientConfig

Accordingly should we update trustStorePath in BdkSslConfig too?
proxyUrl / proxyUsername / proxyPassword in BdkClientConfig

@symphony-youri I would prefer to have it in PR for proxy ticket. @symphony-elias WDYT?


Upgrade scalikejdbc version

Upgrade one more dependency, scalikejdbc to 3.4.1. Needed to do this for some weird edge-case stuff when using the vinyl artifacts in other tools/clients -- we were getting some issues with the version of scala-collection-compat that scallikejdbc 3.3.1 included. It does not appear that there are any issues in rolling this forward.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


installing fails for JPA modeler

My netbeans :
Product Version: NetBeans IDE 8.2 (Build<PHONE_NUMBER>01)
Updates: NetBeans IDE is updated to version NetBeans 8.2 Patch 2
Java: 1.8.0_131; Java HotSpot(TM) 64-Bit Server VM 25.131-b11
Runtime: Java(TM) SE Runtime Environment 1.8.0_131-b11
System: Windows 10 version 10.0 running on amd64; Cp1252; fr_FR (nb)
User directory: C:\Users\taleb\AppData\Roaming\NetBeans\8.2
Cache directory: C:\Users\taleb\AppData\Local\NetBeans\Cache\8.2
I tried with two version of JEddict  4.2.3  and  4.3
the modules that I can't enable are

JPA modeler

JPA classes reverse engeneering

DB Modeler

JSON B Modeler

Database Reverse Engeneering

ORM Converter

Are you manually installing or through update center ?

I used bouth methods
first I prefered to use the update center but no success
then I removed the update center and the downloaded JEddict
then I used the manual solution but the same issue
for update center I m using :
https://github.com/jeddict/uc/releases/download/8.2.P2/updates.xml
what should I do
my computer system is new there is only netbeans and java .
2017-07-07 5:27 GMT+02:00 Gaurav Gupta<EMAIL_ADDRESS>
Are you manually installing or through update center ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jeddict/jeddict/issues/228#issuecomment-313577741,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AWUSCb8Ss_0VtDXm1kXgtt2k0NfFeMz8ks5sLaW7gaJpZM4OP71E
.

Can you share the version of NetBeans IDE.
Removal of the update center does not help. You have to uninstall the plugin.
As per record : https://github.com/MHTaleb/YacineAutoEcole/blob/ffa1c62d9fea8642e7dc5d7c8e30960c124ebf97/src/main/java/entity/newJPADiagram.jpa
You are existing user of Jeddict. So looks like you are migrating from older to new NetBeans version and you have imported all settings of older NetBeans to new NetBeans IDE. If this is the case then , Please uninstall all plugin.

Product Version: NetBeans IDE 8.2 (Build<PHONE_NUMBER>01)
Updates: NetBeans IDE is updated to version NetBeans 8.2 Patch 2
Java: 1.8.0_131; Java HotSpot(TM) 64-Bit Server VM 25.131-b11
Runtime: Java(TM) SE Runtime Environment 1.8.0_131-b11
System: Windows 10 version 10.0 running on amd64; Cp1252; fr_FR (nb)
User directory: C:\Users\taleb\AppData\Roaming\NetBeans\8.2
Cache directory: C:\Users\taleb\AppData\Local\NetBeans\Cache\8.2
2017-07-07 16:48 GMT+02:00 Gaurav Gupta<EMAIL_ADDRESS>
Can you share the version of NetBeans IDE.
Removal of the update center does not help. You have to uninstall the
plugin.
As per record : https://github.com/MHTaleb/YacineAutoEcole/blob/
ffa1c62d9fea8642e7dc5d7c8e30960c124ebf97/src/main/java/
entity/newJPADiagram.jpa
You are existing user of Jeddict. So looks like you are migrating from
older to new NetBeans version and you have imported all settings of older
NetBeans to new NetBeans IDE. If this is the case then , Please uninstall
all plugin.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jeddict/jeddict/issues/228#issuecomment-313703443,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AWUSCQXr58EwDByuQugNzpoZasBMhqYnks5sLkVWgaJpZM4OP71E
.

as  I mentioned I do formated my computer my win 10 is a new install I was
using netbeans 8.1 in my previous install but now in this new windows
install i want to use netbeans 8.2 with jeddict 4.3
I do removed the update center and the installed plugins but no success
2017-07-07 18:31 GMT+02:00 Taleb Mohammed Housseyn<EMAIL_ADDRESS>
Product Version: NetBeans IDE 8.2 (Build<PHONE_NUMBER>01)
Updates: NetBeans IDE is updated to version NetBeans 8.2 Patch 2
Java: 1.8.0_131; Java HotSpot(TM) 64-Bit Server VM 25.131-b11
Runtime: Java(TM) SE Runtime Environment 1.8.0_131-b11
System: Windows 10 version 10.0 running on amd64; Cp1252; fr_FR (nb)
User directory: C:\Users\taleb\AppData\Roaming\NetBeans\8.2
Cache directory: C:\Users\taleb\AppData\Local\NetBeans\Cache\8.2
2017-07-07 16:48 GMT+02:00 Gaurav Gupta<EMAIL_ADDRESS>
Can you share the version of NetBeans IDE.
Removal of the update center does not help. You have to uninstall the
plugin.
As per record : https://github.com/MHTaleb/Yac
ineAutoEcole/blob/ffa1c62d9fea8642e7dc5d7c8e30960c124ebf97/
src/main/java/entity/newJPADiagram.jpa
You are existing user of Jeddict. So looks like you are migrating from
older to new NetBeans version and you have imported all settings of older
NetBeans to new NetBeans IDE. If this is the case then , Please uninstall
all plugin.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jeddict/jeddict/issues/228#issuecomment-313703443,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AWUSCQXr58EwDByuQugNzpoZasBMhqYnks5sLkVWgaJpZM4OP71E
.

It's really wired, Can you also share the screenshot of issue , plugin panel etc.

what do you think abot giving you access using teamviewer 7 ???

Hi Gaurav
It is wired I did remove My netbeans then I did go to My AppData/roaming
and removed all netbeans entries then i cleared my regestry
then a reinstalled netbeans and I tried to install JEDDICT by update center
and now is working fine
don't know why but is fine right now
thank you so much for the response
2017-07-07 19:16 GMT+02:00 Gaurav Gupta<EMAIL_ADDRESS>
It's really wired, Can you also share the screenshot of issue , plugin
panel etc.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jeddict/jeddict/issues/228#issuecomment-313741488,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AWUSCbv7kPSAJC_gE2VOTu5mxXioY282ks5sLmf9gaJpZM4OP71E
.


fix: not increase request count for pay request

Details

Fixed Issues
$ https://github.com/Expensify/App/issues/26767
PROPOSAL: https://github.com/Expensify/App/issues/26767#issuecomment-1706737988
Tests

Open ND and log in with any account(user A)
Go to chat with user B
Send money request to user B
From user B, click on Pay elsewhere
Verify that 2 requests is not shown

[x] Verify that no errors appear in the JS console

Offline tests
Note: Step 1 ~ 3 needs to be done online

Open ND and log in with any account(user A)
Go to chat with user B
Send money request to user B
From user B, click on Pay elsewhere
Verify that 2 requests is not shown

QA Steps

Open ND and log in with any account(user A)
Go to chat with user B
Send money request to user B
From user B, click on Pay elsewhere
Verify that 2 requests is not shown

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/126839717/fbd2fd7c-84b9-4945-ac04-42111d0db9a1

Mobile Web - Chrome
https://github.com/Expensify/App/assets/126839717/46db4aed-5ea8-4f30-8e09-ec16bb356c82

Mobile Web - Safari
https://github.com/Expensify/App/assets/126839717/25ac2cc8-1128-472e-a69a-0df71578ced8

Desktop
https://github.com/Expensify/App/assets/126839717/42ce508d-6d43-4cdb-8af2-f3715a2b66d5

iOS
https://github.com/Expensify/App/assets/126839717/5370f2b8-7f0b-479c-8237-047f86a6f49a

Android
https://github.com/Expensify/App/assets/126839717/19b19fd3-6451-4bb7-a71a-b1612d3b86d5

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

@deetergp
Please take a look

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/deetergp in version: 1.3.72-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.72-11 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


MATLAB: Building with 'Microsoft Windows SDK 7.1 (C++)' error

Hey guys,
currently i'm working on an engineering project where i want to use the Matlab_BaslerCamDriver package offered for the Basler USB 3.0 cams.
Some further informations about the steps and the setup done by myself in the last days:

Basler cam model: Baser acA4024-29um
MATLAB ver R2017b installed under path C:\program\MATLAB\R2017b...
Pylon ver 4 installed under path C:\program\Basler\pylon 4...
Boost ver 1.55.0 for x64 with lib64-msvc-10.0 installed under C:\boost_1_55_0...
installed Windows .Net framework 4
installed Windows SDK 7.1
installed Microsoft Visual C++ 2010 x64 (+x86) Redistributable 10.0.30319 (also checked that the ammintrin.h is set correctly in the Visual Studio 10.0\vc\include folder).
make.m: changed line 45 to  -->     ' ','"',fullfile(getenv('BOOST_ROOT'),'lib64-msvc-10.0'),'"', ...
baslerGetParameter.cpp: changed line 13 to -->      enum ParamType {
in MATLAB under Home --> Set Path included all folders with subfolders for the offered Camera Driver package, Boost folders, Pylon folders, Microsoft Visual Studio 10.0 folders
used MATLAB command mex -setup c++ and it worked correctly so the MEX is configured to use the Microsoft Windows SDK 7.1 (C++) compiling method
tried to use MATLAB command make for compiling the make.m-file but got the following error messages:

>> make
=> Creating Libraries
Building with 'Microsoft Windows SDK 7.1 (C++)'.
Error using mex
cl : Command line warning D9021 : no action performed

cl : Command line warning D9024 : unrecognized source file type 'Files\MATLAB\R2017b\extern\include -IC:\Program', object file
assumed
cl : Command line warning D9027 : source file 'Files\MATLAB\R2017b\extern\include -IC:\Program' ignored
cl : Command line warning D9024 : unrecognized source file type 'Files\MATLAB\R2017b\simulink\include  /DMX_COMPAT_64
/DUSE_MEX_CMD   /D_CRT_SECURE_NO_DEPRECATE /D_SCL_SECURE_NO_DEPRECATE /D_SECURE_SCL=0  /DMATLAB_MEX_FILE /O2 /Oy- /DNDEBUG
C:\Basler_matlab_camdriver\basler_helper\basler_set_get.cpp /Fobasler_set_get.obj ', object file assumed
cl : Command line warning D9027 : source file 'Files\MATLAB\R2017b\simulink\include  /DMX_COMPAT_64  /DUSE_MEX_CMD
/D_CRT_SECURE_NO_DEPRECATE /D_SCL_SECURE_NO_DEPRECATE /D_SECURE_SCL=0  /DMATLAB_MEX_FILE /O2 /Oy- /DNDEBUG
C:\Basler_matlab_camdriver\basler_helper\basler_set_get.cpp /Fobasler_set_get.obj ' ignored

Error in make (line 56)
            mex(flags{:},libraries{k,3},ipaths,lpaths,libraries{k,2})   % build

Actually i don't have any idea how to fix this.
Hope somebody is able to help me out with this error messages.
Thanks in advance!!!!
All the best,
André

Hi Andrè
This does indeed look strange. Can you try the following things to check where the error comes from:

Make sure that the MEX-compiler is set up correctly. Within MATLAB, type
edit([matlabroot '/extern/examples/mex/mexcpp.cpp']);
This will open a C++ example by MATLAB. Copy the content of this file to a new file, located in any folder you can write to, e.g. Desktop, your Documents folder,... Name the file e.g. test_mex.cpp. Now, navigate to that folder in MATLAB, and call the following command
>> mex test_mex.cpp
This should give the following output:
Building with 'Microsoft Windows SDK 7.1 (C++)'.
MEX completed successfully.

If this happens, then your compiler is set up correctly. You can verify that the compiled function works by calling
>> mex_test(1, 2)
which print some data, and not throw any errors.

Check all include paths. Open the make.m file, and run all code up to line 46, i.e. until lpaths = [...];. Then print the values ipaths and lpaths to the MATLAB console and check that all paths in there exist on your disk and "look" correct. I would expect the paths to look something like this:
ipaths = ' -I"C:\program\Basler\pylon 4\include" -I"C:\program\Basler\pylon 4\genicam\library\CPP\Lib\win64_x64" -I"C:\boost_1_55_0" '
lpaths = ' -L"C:\program\Basler\pylon 4\lib64" -L"C:\program\Basler\pylon 4\genicam\library\CPP\Lib\win64_x64" -L"C:\boost_1_55_0\lib64-msvc-10.0" '

The paths can be a bit different - the important part is that all these paths exist and contain the relevant files.

Please let me know how this works out and if you find e.g. strange/bad paths in 2).
Best,
Hannes

Hi Hannes,
wow thank you very much for that fast answer.
I will check this out on Monday next week, because unfortunatelly today i'm busy to some other tasks.
I will let you know what happends to your suggested steps. I'm very interested in getting this driver package running :).
All the best,
André

Hey,
I tried your recommended steps:

-> I created the C++ example as explained and compiled it with the Microsoft Windows SDK 7.1 C++
compiler via MATLAB command:
mex -setup c++ to set the compiler and
mex test_mex.cpp
-> It gave me the following output which told me that the MEX-compiler is set correctly:
Building with 'Microsoft Windows SDK 7.1 (C++)'.
MEX completed successfully.
-> As soon i verified it with:
mex_test(1, 2)
i received the message:
Undefined function or variable 'mex_test'.

The included paths in the variables "ipaths" and "lpaths" are existing and looking correct to me:
ipaths =
'-I"C:\Program Files\Basler\pylon 4\pylon\include" -I"C:\Program Files\Basler\pylon 4\genicam\library\CPP\include" -I"C:\boost_1_55_0"'

lpaths =
'-L"C:\Program Files\Basler\pylon 4\pylon\lib\x64" "C:\Program Files\Basler\pylon 4\genicam\library\CPP\Lib\win64_x64" "C:\boost_1_55_0\lib64-msvc-10.0"'
I tried both steps with MATLAB running in "normal" mode and as an administrator. I attached a screenshot of the make.m file i'm using and trying with ... maybe i made a mistake in this file during the whole testing.
All the best,
André


Remove no part checked. Fixes #303.

This avoids the "No parts of  should be checked" from the individual rules and adds a forAll intro section to explain what that means.
It is done using forall annotations on signatures.  Could someone with deeper knowledge of H-M types double-check that I added it correctly?

This is nice!

Since we were writing Haskell-esque type signatures, we were also inheriting Haskell's implicit forall for all type variables. I.e. it was already implied that things were parametrically polymorphic. The bit about no values being checked was still added in even though the signature explained that part. And we still get implementations that are not law abiding. The fact that we've moved to explicit forall doesn't seem like enough of a justification to me to also remove the bit about no values being checked. Adding an explicit forall is good because it is acting like a springboard to explain parametric polymorphism!
I'm not going to veto this PR, I think people making changes is good and I support it. But, I don't think this solves the underlying problem of people writing unlawful implementations.
Also, if we're now writing PureScript-esque type signatures (or Haskell-esque with GHC's ScopedTypeVariables extension), then we need to be consistent. All of the type variables should be introduced in the forall. E.g. map should be:
map :: forall a b f. Functor f => f a ~> (a -> b) -> f b

not
map :: forall a b. Functor f => f a ~> (a -> b) -> f b

Being inconsistent will lead to further explanations needed about how GHC's ScopedTypeVariables extension actually works and that's far off the beaten path of this spec.

@joneshf:
The goal was not to add forall.  It was explicitly to remove "no values should be checked".  (See #303 for details.)  Adding forall seemed to be a compromise for those cases.  I have no problem removing forall everywhere and just depending upon an expanded section on parametricity.  I actually think that would be better.

@davidchambers: Rather than adding forall to the other signatures, let's look at removing all of them, and simply depending upon a parametricity section.  I'll try to create a separate PR tonight or tomorrow.

@CrossEye, if you don't intend to update this pull request, shall we close it?

I intend to create a replacement, but life has gotten in the way.  Hopefully soon.

Add forall to everything

After @joneshf said that:

Since we were writing Haskell-esque type signatures, we were also inheriting Haskell's implicit forall for all type variables.

What 's the reason to add forall to everything? In my opinion, it generates noise in the law definitions. A section which explains that all laws are parametrically polymorphic is enough for me.
I think we have to get an agreement in #303 before doing the PR. Because it seems that no part to be checked is too much opened to interpretations:

Does it mean parametric polymorphism?
Does it mean inspection?
Does it mean inspection with observable effect?


Jfg 902.user configurations

Work in progress. Please, leave your comments about the solution.

Reviewed and divided into tasks.


Feature request: dead module / file detection

One aspect of a large codebases is the potential for files to simply never be included in the build in the first place. This macro doesn't pick those up, obviously, because they aren't part of the build. However, "dead module detection" is arguably as useful as "dead code detection."
Thought 1) Perhaps an easy way would be using the Compiler include macro for "all packages", maybe:
--macro include('')
But this actually doesn't work... It seems to be implying -cp . as it results in "invalid package" errors...
Thought 2) Perhaps another idea is to actually glob from all source paths in TCell.hx, and report unused modules / files from there.
Thought 3) Just mention in the README, this doesn't pick up types that are never referenced.

I can add an option to let the macro scan all classpaths and report any modules that the compiler doesn't see.

In that case, you don't need this library?

@kevinresol - I feel like we're not communicating well via these comments, but that we're actually in agreement. :+1: I'm merely saying:
An option to scan and include all orphan modules would complement this library (and its goal of code cleanup) nicely. Perhaps not as the default, as that could overwhelm the user on the first try, but certainly as an option.


Add setting to set the Date Format

Feature to select the date format of the transactions, discusses in issue #450
An option to select the Date Format has been included in the configuration menu, just after the setting for language.
Date formats added:

MM/DD/YYYY - Used mainly in the US
DD/MM/YYYY - Common in Europe
YYYY/MM/DD - Used in Asia

I have some problems. I want to do these things:

Fix the refresh for the dates after format is selected - It only refreshes once and I don't know why. Can someone give me a hint?
I'm trying to add a test to the filter. What testing tool we use? Can any of you provide me any reference?

It is my intention to contribute to this project. Thanks a lot!

I'll ensure that the filter is triggered again.
We use Mocha, Chai and Sinon for tests. In the test folder you can see some examples.

I'm sorry I have not pushed the tests. I have written them, but I have not run them because I have problems with sinon-chai. This is the problem:

C:\Users\Joseph\Desktop\ArkProject\ark-desktop>npm install sinon-chai
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules\chokidar\node_modules\fsevents):
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: sha512-WIr7iDkdmdbxu/Gh6eKEZJL6KPE74/5MEsf2whTOFNxbIoIixogroLdKYqB6FDav4Wavh/lZdzzd3b2KxIXC5Q== integrity checksum failed when using sha512: wanted sha512-WIr7iDkdmdbxu/Gh6eKEZJL6KPE74/5MEsf2whTOFNxbIoIixogroLdKYqB6FDav4Wavh/lZdzzd3b2KxIXC5Q== but got sha512-4lGswPDk0jk9f4+fPbGBnfm4bJHFPGsBcKNmXDNCaGQFaMRWZTPPF1osPNtFPCQ3fAlBKocc9vX1gHlJP4tuug==. (1374775 bytes)
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules\7zip-bin-linux):
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: sha512-umB98LN18XBGKPw4EKET2zPDqVhEU1mxXA1Gx0BM+DoBt4hnlZPNkpSMNzmuNbQshi9SzLhqlTAyKcAgNrbV3Q== integrity checksum failed when using sha512: wanted sha512-umB98LN18XBGKPw4EKET2zPDqVhEU1mxXA1Gx0BM+DoBt4hnlZPNkpSMNzmuNbQshi9SzLhqlTAyKcAgNrbV3Q== but got sha512-7w9MerqIF9ufugN+YxiixvCGoxFVpOhu16Im7QvzPCM5GEFLjbUgA7cVAd2eife7l4Ben05GzuKAQMJyAr9GIQ==. (29755 bytes)
npm ERR! code EINTEGRITY
npm ERR! sha512-9stIF1utB0ywNHNT7RgiXbdmen8QDCRsrTjw+G9TgKt1Yexjiv8TOWZ6WHsTPz57Yky3DIswZvEqX8fpuHNDtQ== integrity checksum failed when using sha512: wanted sha512-9stIF1utB0ywNHNT7RgiXbdmen8QDCRsrTjw+G9TgKt1Yexjiv8TOWZ6WHsTPz57Yky3DIswZvEqX8fpuHNDtQ== but got sha512-pEK1ZUxxWLHXAu8Exm/y6iTtlN9DfOwG9lfaoNhXxyAjLzDl8vZwidaqj3+vahTgAlhr2CIYBXn7EAqEVTIX5Q==. (2341 bytes)
npm ERR!      C:\Users\Joseph\AppData\Roaming\npm-cache_logs\2017-12-20T04_15_02_721Z-debug.log

I had to pull #478 changes so I could run the Unit tests in windows.

The online test run was failing because the time and day varies, since the format outputs the local date time (which is different in my machine).
Therefore, the test was fixed to only test the date part and the order, which is what the filter does.

@fluorine
Glad I could help!
Now we (the ark team :D ) probably should my PR first or else we have a "little" mess.
BTW: If my PR gets merged first I suggest you do the following after (for a clean history):

Pull master
Git reset mixed your branch to the master branch
Add one or two commits for your entire logic
Force push

If you'd like to do this and need any help just write me in gitter or so :)

@Nasicus You are right. I will be watching your issue and I'll do what you suggested for a clearer history. Thanks again!

@fluorine Was you waiting on #478 to be merged first?
Also, travis seems to be failing, probably because of these:

There's also a conflict. Fix these and we will give it a test 👌  (sorry - a bit late!)

I hope the best for the project, but I'm not (trying to) contribute to the Ark Platform anymore.
I think any meaningful feedback from the team came too late (a month later) and therefore I prefer to focus on other projects, instead fixing old conflicts on code I don't remember anymore.

No worries @fluorine. We wasn't too sure if it was ready to be reviewed again as Travis was failing. Thanks again.


Plan to enhance Beetle

What would you like to be enhanced
It's planned to:

Apply and test Tumblebug's breaking changes,
Apply and test cm-model v0.0.2 for on-premise model (a.k.a. source infrastructure model),
Update and test API for specifying Provider and Region,
But not limited.

Please feel free to tell us if you have any comments or issues.

It's been planned to

test Beetle APIs with the Honeybee API, which provides an on-premise model, and
update the Beetle guide (https://github.com/cloud-barista/cm-beetle/discussions/105).


How do you broadcast notification to all users?

So I've installed the package and was able to send / receive notifications in desktop as well as mobile. But, it only works when logged in person has enabled notifications and the same logged in person is sending the notification.
I want admin to send notifications to all users. What changes do I need to make in this case?

Instead of $request->user()->notify(new HelloNotification); you'd have Notification::send($users, new HelloNotification);.
See https://laravel.com/docs/5.6/notifications#sending-notifications

Thanks @cretueusebiu .. That was quick! :+1:


Fix: Breadcrumb list is a plain list instead of a values list

:loudspeaker: Type of change

[ ] Bugfix
[ ] New feature
[ ] Enhancement
[ ] Refactoring

:scroll: Description

:bulb: Motivation and Context

:green_heart: How did you test it?
:pencil: Checklist

[ ] I reviewed submitted code
[ ] I added tests to verify changes
[ ] All tests passing
[ ] No breaking changes

:crystal_ball: Next steps

Codecov Report

Merging #201 (95a9627) into main (b41f449) will increase coverage by 4.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #201      +/-   ##
==========================================
+ Coverage   78.36%   82.45%   +4.09%
==========================================
  Files          47        3      -44
  Lines        1428       57    -1371
==========================================
- Hits         1119       47    -1072
+ Misses        309       10     -299

Impacted Files
Coverage Δ

dart/lib/src/protocol/operating_system.dart

dart/lib/src/protocol/dsn.dart

dart/lib/src/protocol/request.dart

dart/lib/src/protocol/mechanism.dart

dart/lib/src/diagnostic_logger.dart

dart/lib/src/protocol/debug_image.dart

dart/lib/src/protocol/sentry_exception.dart

dart/lib/src/hub.dart

dart/lib/src/protocol/sentry_stack_trace.dart

dart/lib/src/hub_adapter.dart

... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b41f449...95a9627. Read the comment docs.


Add test for special case of flat_dict w/no objects

Special-case test needed since TypeError raised here instead of ValueError, to allow general-import mechanism to drop through to struct_dict.

Closed in b7a9f57.


Arc...?

From @0xbadb002 on January 18, 2016 15:34
@ark-lang/owners Did we decide on having Arc in the standard library, or is this still under debate?
Copied from original issue: ark-lang/stdlib#4

Dupe of #633


DM-39313: Add lsst-efd-client.

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

@conda-forge-admin, please rerender


ImageViewFactory.createStillImageView() should parse in AttributeSet

mMainView in BigImageView always have id -1 (NO_ID). This happen because because the SubsamplingScaleImageView is being created with null AttributeSet.
This means I can't check which view I click inside my onClickListener.

PR is welcome!


Slippage --> Nowhere to bump --> Gets sorted out alone

2nd transaction today that requires me to bump slippage.

When I click on click here
It opens an empty box
Then after a few seconds the transaction is confirmed
(0x4ef914544b2fe7b5a34bb2fce464d8fbc25e2d010bfa0cd6997d999887cde6d5 tx id)

To note my slippage is set at 3%

there is always a chance that the slippage behavior gets sorted out alone as its dependent on the network state at the time of execution.
I'm not seeing the transfer in connextscan, is that the right ID? `

I had the same issue with this transfer: https://connextscan.io/tx/0x6a700478ac19f9eee76b4a1d47e89bdec5ba482cce0eaa6aedec9ed8df8d90a6?_gl=115sn2d1_gaMTg1NTIwODk5MC4xNzEzNzk1NDI4_ga_MPYZEDRVQ0*MTcxNDQxNzg5Mi4xOC4xLjE3MTQ0MTc4OTYuMC4wLjA.
Here is the screenshot: https://www.notion.so/connext/Round-4-90e17afcc10d47b2a266273669644cb3?pvs=4#3f099c1c507c425d87eeec42ff949e4d


Amending CI to accomodate 3.7

This PR changes the CI configurations to permit testing on Python 3.7.

Python 3.7 doesn't appear to be available on travis yet, so using 3.7-dev.
bumped all the travis 3.x versions up by 0.1, i.e. 3.4 becomes 3.5.
appveyor does not yet accomodate 3.7, according to documentation

Looks like this is going to be involved. There is a cython wheel on PyPI for 3.7. However, it's only for version 0.28.3, which is going to require a bump to the version that the CI is using.

It'd be unfair of us to ask them to release a 0.25.3 version, so trying to remove cython pin.

CircleCI does not have a final image for 3.7, so using 3.7.0b5

xref to #8987

python -u $OPTIMIZE runtests.py -g -m $TESTMODE $COVERAGE $USE_WHEEL_BUILD -- -rfEX -n 3 2>&1 | tee runtests.log
doesn't work on the 2.7 matrix entry, probably caused by the cython bump.

appveyor images probably available next week, https://github.com/appveyor/ci/issues/2475

@adbugger, I'm trying to get the CI setup working for python 3.7. At the moment there are two test failures that are in test_rotation.py, here. Could you look into them to see what the issue is? Note that I'm using python 3.7-dev at the moment on Travis, so that may be a contributing factor.

It seems like there are some differences in np.einsum behaviour. I think I have a potential fix. For local testing, I'm building python 3.7 from here. I'll upload once local tests pass.

Remember to add 3.7 to the Trove classifiers:
https://github.com/scipy/scipy/blob/14de485c053cc275682bc7de0316fcca72b341f8/setup.py#L44-L49

Is adding the line Programming Language :: Python :: 3.7 enough? I made the possible changes and pushed to my repo, but the travis-ci build here does not seem to be running a python 3.7 build.

There is another test fail at scipy/linalg/tests/test_interpolative.py:84, where time.clock is used. The DepreciationWarning for that function is causing the test to fail. time.perf_counter, or time.process_time is available on 3.x, but not on 2.7. Perhaps the only way to cover both versions is to use time.time(), even though it may not have the resolution required.

@adbugger

Is adding the line Programming Language :: Python :: 3.7 enough

that won't fix it. This PR is attempting to add 3.7 to the CI, so any changes will have to come in here.

@adbugger Programming Language :: Python :: 3.7 is just metadata to list Python 3.7 as supported on https://pypi.org/project/scipy/ (see Programming Language on the left).
To include 3.7 in Travis CI, you'll need something like python: 3.7-dev in your .travis.yml, for example: https://github.com/scipy/scipy/pull/8988/commits/d5eda2bd9c102663181767619b3ff4e99df74972.

So I just tested the potential fix on my repo. The python3.7-dev build on travisCI fails those same two test cases; however when I run the tests locally after building python3.7 from source, all tests pass (Curiously, they pass even without the potential fix).
Mentioning @nmayorov , if you can spot the problem that would be great. Otherwise is it possible to wait for TravisCI to support python3.7?

I'd recommend waiting for TravisCI providing the released 3.7. Their -dev images can sometimes be not very up to date.

Agree, but doesn't hurt to prepare though.

Appveyor now has python 3.7. There are several failures on this CI, all related to:
name = 'Iterator'
    def __getattr__(name):
        # For backwards compatibility, continue to make the collections ABCs
        # through Python 3.6 available through the collections module.
        # Note, no new collections ABCs were added in Python 3.7
        if name in _collections_abc.__all__:
            obj = getattr(_collections_abc, name)
            import warnings
            warnings.warn("Using or importing the ABCs from 'collections' instead "
                          "of from 'collections.abc' is deprecated, "
                          "and in 3.8 it will stop working",
>                         DeprecationWarning, stacklevel=2)
E           DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working

but these are originating from matplotlib and numpy.
TravisCi is failing on two tests, but as discussed before these are on 3.7dev:
FAIL scipy/spatial/transform/tests/test_rotation.py::test_apply_single_rotation_multiple_points
FAIL scipy/spatial/transform/tests/test_rotation.py::test_apply_multiple_rotations_single_point

@pv, this is failing on appveyor due to a DeprecationWarning from numpy, importing from collections.abc. Is there a way of filtering at a higher level than in the individual tests?

Maybe adding to pytest.ini ?

We could probably update the 3.4 tests on appveyor to 3.x, with x>=3.5

Squashed commits.

LGTM now. Any reason not to merge this?

As long as we intend to support 3.4, I think we should retain at least one CI job running on it.
I'd also suggest dropping the TESTMODE=full, PYTHON=3.6 job from appveyor. The 32-bit job runs on py3.6, so I think it's not necessary to add a second py3.6 job. As these jobs run in series, adding a new one adds 20min of waiting.

One note: on the travis side, I've experimented with using the dist: xenial / sudo: true setup for python 3.7, and found that it adds about 5 minutes of extra setup time compared to the 3.4-3.6 versions. In SciPy's case, that amount of time is a bit of a wash, but for smaller packages where the CI takes 1-2 minutes, I've opted not to test on 3.7 because of it.

That's odd, I've not seen anything like +5 mins on the repos I've added it to, there's not been much difference if at all.
For example:
https://travis-ci.org/python-pillow/Pillow/builds/420525797
https://travis-ci.org/pylast/pylast/builds/420438611
https://travis-ci.org/hugovk/test/builds/416839676

I'll make the changes suggested by @pv.

@hugovk Here's the PR where I tried it: https://github.com/altair-viz/altair/pull/1008
And here's the build showing increased times (4.5 minutes) https://travis-ci.org/altair-viz/altair/builds/414625557?utm_source=github_status&utm_medium=notification
If there's something I'm doing wrong, I'd be glad to know what it is!

Changes made in last commit:

Dropped the suggested appveyor job
using 2.7, 3.4, 3.5, 3.6, 3.7, macOS3.7 on travis.

So it looks as if the tests pass, apart from the travis refguide check on python3.6. That issue looks orthogonal to this, in that other PR's have the same issue. I think @ev-br has seen that.

I'd recommend merging.

Okay, in it goes. Thanks @andyfaff, all.


apply wait too high when ingest sst

Bug Report
tcoc 2338\ 2260

What version of TiKV are you using?

v7.1.3
What operating system and CPU are you using?

Steps to reproduce

create workload of batch insert
add index used by transaction or adjustment region size
see apply wait or prewrite duration

What did you expect?
no impact
What did happened?
more impact

Not a bug but a known weakness existing in TiKV when there exists lots of INGEST jobs triggered by operations on regions, such as split, merge or move.
The reason why apply wait duration is high is that the apply processing should wait until the preceding INGEST operation finishes. And we're trying to mitigate it where apply wait duration is high during this processing.
/cc @Connor1996

Yes, we are working on mitigating this


the "table_utils" of the crawling procedure

Hi, wenhu.
When I try the pipeline.py in your code of the crawling procedure, I meet the difficulties with the "table_utils". It seems that your github repository and the resource of pip do not contain the module "table_utils".

Sorry for missing that component. I just uploaded it to the repo.


Is .net version can use like bbox_to_anchor to control legend outside?

I have some data to draw a chart with ten line.
but there's name is to long.
if i use draw legend LowerRight, the legend text will cover line.
it's .net version can draw legend under the chart or not inside?

You can get the legend as a Bitmap then apply it to a PictureBox placed outside your plot somewhere in your application.
formsPlot1.Plot.AddSignal(DataGen.Sin(51), label: "sin");
formsPlot1.Plot.AddSignal(DataGen.Cos(51), label: "cos");
formsPlot1.Render();
pictureBox1.Image = formsPlot1.Plot.RenderLegend();

Let me know if this doesn't do the trick. Good luck! 👍 🚀


fix font being reset to current state font on edit

fix https://github.com/excalidraw/excalidraw/issues/1281

Awesome, thanks!


Increase PHPStan level to 8 with strict rules

This PR sets PHPStan analyse level to the maximum and enables strict rules. This results in 7905 new errors on 2.15 branch and we clearly don't have the time to fix all right now so I created a baseline file.
Nothing should be added to this file ever, except when merging the PR up to higher branches, where more errors might be reported. In such case, the baseline file should be regenerated. Then we can fix the errors step by step when we can. In the meantime, new errors in future PRs will be reported.

It looks crazy, wouldn't be a nightmare during merges?
Why this approach instead of step-by-step?

Fair point. This approach allows to enable all checks we want for future code without having to fix all existing code first. But I don't think it will report more than a few errors when merging PRs that are not up-to-date with upstream or when merging patches up to higher branches.
Maybe regenerating the baseline file for each branch after merging this PR will be easier than updating it manually. I can take care of that if we agree on merging this.

The baseline way seems good to me. @julienfalque can you merge this and than merge upstream making sure on the branches the baseline file is good?
Side note, do we want to do this with a psalm baseline as well?

I'll merge this one :+1:
Regarding Psalm: I have no experience with it and I intended to use this project as a playground to test it. But if anyone wants to do it, I'm fine with that :)

I'm marking this PR as WIP because I want to check if some errors from the baseline file should be in the regular file instead (errors yet to be fixed vs. errors we actually don't want to fix).

I'm still kind of pessimistic with having this huge baseline, I'm afraid after it is merged we would start to think these issues are solved.
Why not increase the level step-by-step and add errors to ignore list grouped by type, like the one with return void?

Because ignoring "by type" is not ideal. It hides all errors of the same kind, but maybe some of them can be fixed while some other can't (e.g. for BC reasons), so we have to check the errors one by one, which is very time consuming. Doing that would take months.
On the other hand, the purpose of the baseline file is to list the errors that have yet to be fixed, we should never consider them fixed. And once merged, contributions to fix remaining errors will be easier.
The has no return type specified exception I added is because we can't fix most of them until we drop PHP 5.6 support. We'll have to remember to remove the exception then and fix the errors properly.

I am a friend of a high phpstan level and the baseline approach. did things like that in some of our projects already.
I would recommend to a lower level though, because level 8 is very strict and might even introduce rules you dont agree with.
we usually try to fix errors on level 0, 1, ,2 step by step (as you did) and then do the rest by baselining arround level 5.
IMO 8 seems to be too high for now.

IMO we do want level 8 and strict rules here. As far as I remember, rules like e.g. forbidding implicit boolean casts in control structures are things we (often) check during code review anyway.

I see. if your goal is 8 you should go for it.
have a look whether running with so many warnings/ignores will affect your phpstan runtime, otherwise 👍

Looks good to me, having the baseline will prevent new issues from being introduced :+1:
After this we can start cleaning out the baseline.

thanks @julienfalque

CONTRIBUTING.md does not mention on how to run phpstan on a development box nor that it is a requirement at all albeit it makes the build fail.
Hidden dependency?

See #4976.


Migrate the PackageServer CSV management to a secondary controller

Introduce a downstream-only controller that is responsible for managing
the PackageServer CSV resource. Previously, this resource was created
and managed by the CVO. In order to comply with SNO expectations in
4.9+, the PackageServer CSV management needs to move to a second-level
operator that can react to high availability expectations exposed by the
in-cluster Infrastructure cluster singleton API.
This controller creates a filtered watch on the PackageServer CSV
resource, and a watch on the Infrastructure cluster singleton API.
When reconciling events, the main reconciliation logic ensures that the
current high availability expectations are present in the CSV resource,
letting the OLM Operator propagate that desired state to the underlying
PackageServer-related resources.
This typically means ensuring PackageServer is deployed with
only a single replica in SNO-enabled cluster environments (denoted
through the SingleReplica topology mode), else is deployed in the
default configuration.
In order to ensure that the PackageServer container image is inline with
the rest of the OLM-related container images, we can continue to use the
find-and-replace functionality that the CVO provides when inspecting the
manifests/image-references file at release payload build time, and when
starting up. This allows us to specify an environment variable to the
psm executable that matches the OLM image specified in the image
references manifest, letting the CVO handle the substitution to the
correct image, and then propagating the value of that environment
variable to the CSV resource when reconciling events.
Future work likely includes migrating from deploying the PackageServer
using the OLM-native CSV API. This would involve the psm executable
rendering and deploying a Deployment, APIService, Service, etc.
resources, which details the need to have a solidified migration
strategy given the CSV places an owner reference on the underlying
resources, and simply removing that CSV will result in a downtime and a
SLA API violation as the underlying resources would be deleted.

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/approve
this looks good to me -- but we should get one more independent review before merging (as per our policy).

/retest

/retest


Delete does not work on iOS

Swipe to delete an entry => Reappears on next start of OnePile.
Related: #89
Trash view is also missing.

Fixed in 1.3


question: How to allow certain HTML tags to be permitted

Is it possible to specify certain HTML Tags that can be permitted in the markdown?   I have legacy files that include some <h2 tags and some minor bold or strikethrough tags.  They show up when enter editor, but upon save, they are stripped out.

Sorry...   Problem is my own form processing which was stripping html tags before saving.  simplemde works fine preserving the appriate tags.  I will adjust my form process to not strip what I want to keep.


Post URL input box size should be dynamically adjusted

I was recommended to post this issue here.
On the spee.ch site after inputting an image, you are presented with the option of setting your own URL and I couldn't help but realise the input box (red) was not the full length as the bar indicates as shown in green:

Here is a gif of the problem while entering a URL:

This was originally experienced on Arch Linux using Firefox Quantum 60.0.1 and can be reproduced in my Vivaldi browser too. I would get my web-dev friend to do a PR but unfortunately he isn't available.

    width: calc(100% - 170px);
}```
Hey, I'm @delta1512's web dev friend he was mentioning. Above is the code snippet you need to fix your problem. I would make a push but I can't find where your stylesheet is. Either it's not in this repo or it's in some strange format I don't understand. Anyway, hope it helps :)

@Aurailus Thanks for taking a look at this. I replied to you on Discord. You should be able to find what you are looking for here: https://github.com/lbryio/www.spee.ch

This issue should be fixed with the scss update using flexboxes.  @Aurailus @delta1512, the style sheets are now located in /client/scss/


Jenkins support with odo commands

oc command supports Jenkins creation and creation of build pipeline.
But it seems same support is lacking with odo commands.
For ex. following command works
oc create -f https://raw.githubusercontent.com/openshift/origin/master/examples/jenkins/pipeline/nodejs-sample-pipeline.yaml
But same command with odo doesn't.
Is there any documentation which demonstrate odo commands instruction to setup Jenkins and Pipeline.

Hi @chaitanyaenr,
Odo is targeting developers, and we want to make developers life easier. One of the ideas behind odo is that developers shouldn't need to write any yaml definitions, You won't be able to directly apply yaml file using odo as you can do with oc. This is not even on odo roadmap.
But we have Pipelines support on our roadmap - https://github.com/openshift/odo/issues/1238.
I don't have any details right now. I don't know when we get to it, but some future odo version will definitely have support for Pipelines in some form.
If you have any suggestions or ideas feel free to continue the discussion on Pipelines epic
issue https://github.com/openshift/odo/issues/1238
/close


Is Bootstrap RFS and RFS engine same ?

Is RFS in the Bootstrap framework and RFS engine itself the same in every way ? because I have found a difference in Base Value configuration.

In Bootstrap = $rfs-base-font-size
In Engine = $rfs-base-value

Bootstrap 4 uses RFS v8, which only supports fluid rescaling for font sizes. Bootstrap 5 will use RFS v9, which supports fluid rescaling for all properties, hence its change in variables.
Docs of RFS v8 are available here: https://github.com/twbs/rfs/tree/v8.0.4

Thanks @MartijnCuppens


Added CrossQ

Description

Added hyperparameters for SB3 CrossQ.
Motivation and Context

[ ] I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation (update in the documentation)

Checklist:

[x] I've read the CONTRIBUTION guide (required)
[x] I have updated the changelog accordingly (required).
[ ] My change requires a change to the documentation.
[ ] I have updated the tests accordingly (required for a bug fix or a new feature).
[ ] I have updated the documentation accordingly.
[x] I have reformatted the code using make format (required)
[x] I have checked the codestyle using make check-codestyle and make lint (required)
[ ] I have ensured make pytest and make type both pass. (required)

Note: we are using a maximum length of 127 characters per line

Could you give me access to your repo or change the branch to something different than master?
I cannot push edits :/

I just gave you access to my repo


Date sorting

When tasks have a due date, does tod sort by the date itself (oldest to newest)?
Based on my testing, it appears that it sorts based on buckets, but I am getting the newest overdue before the oldest overdue.

I have noticed this as well. This sounds like something I would like to work on.
After some (very) brief investigation, it seems that in the case of task listing all_tasks() is called...
Here is an example of project task listing from projects.rs:
/// All tasks for a project
pub async fn all_tasks(config: &Config, project: &Project) -> Result<String, Error> {
    let tasks = todoist::tasks_for_project(config, project).await?;

    let mut buffer = String::new();
    buffer.push_str(&color::green_string(&format!(
        "Tasks for '{}'",
        project.name
    )));

    for task in tasks::sort_by_datetime(tasks, config) {
        buffer.push('\n');
        buffer.push_str(&task.fmt(config, FormatType::List, false));
    }
    Ok(buffer)
}

It seems to call sort_by_datetime() ... my guess is that it sorts by date/time created instead of due.
Any ideas on how to implement sorting by due date/time?

sort_by_datetime() is implemented in tasks.rs on line 480
It looks like 481 is missing the Reverse, which could be the issue? But I'm also finding in my testing it doesn't seem to make a difference, so I think that the Buckets might be overriding my expected behavior.
Let me see if I can find a specific query that works consistently so I can test. Can you give me an example of the exact tasks/situation you are encountering?
@alanvardy it looks like sorting is done on "list process" and "tod task next", but all I can find is by grouping - is it anywhere else? Where is "sort_by_datetime" implemented? When I run "list view" on a project, as far as I can tell, the results are not sorted in any way (they appear to be following the default/manual sort)
One easy way to fix this might be to calculate days overdue and have that as a point that is added (i.e. 1 day overdue = 1 point, sort on that), and then combine and only sort in buckets?

@rvbcldud  are you running the "list view" and trying to figure out sorting there?
I'm running into this when using "list process" and "tod task next" - I have already customized my weighting to return them as closely to match what i had in Todoist as possible. This is the sorting in the native client I am trying to replicate:

Yes! I am doing tod list view
Let me know if you end up finding a consistent query / any other ideas.
Great work

I am using a filter to return tasks tagged as @Work and due | overdue | no due date.
As best as I can tell, the sorting doesn't happen at the granular due date level. Within the code, the sorting happens by score, here:
    /// Determines the numeric value of an task for sorting
    fn value(&self, config: &Config) -> u32 {
        let date_value: u8 = self.date_value(config);
        let priority_value: u8 = self.priority_value(config);

        date_value as u32 + priority_value as u32
    }

date_value is simply the date buckets as described within the config, so as I explained, within "overdue", there isn't differentiation among tasks.
I played around with the code and tested adding a date_skew so that the date_value is skewed by how overdue the task is, and it does, but because it's combined at the end, it means that (at least for my use case) if I have a task 90 days overdue, I have to ensure my priority is more than 90 greater for each level, otherwise the sorting will 'trump' the priority. This then becomes problematic because currently we're using u8, which is limited to 0-255 values.
Is there any way to sort results prior to bucketing? I would think that would solve the issue since then they would be sorted in each 'bucket' before being returned - run sort_by_date first

Using s8 instead of u8 may help because then we could use negative priority instead of add (allows for negative) - I'd prefer for "no due date" to have a slightly negative priority over tasks with a due date.

within "overdue", there isn't differentiation among tasks.

So, in your experience, does it fail to sort by due date only when they are overdue or in general?

Hey guys, just catching up on the conversation here.

list view doesn't seem to be sorted properly (it is supposed to sort by date), it's some really old code. How do we think it should be sorted now that I need to rewrite it? Oldest first? Or should I use the same "value" method for processing?

list process sorts by value, I can definitely go from u8 to something larger like i32.

Is there any way to sort results prior to bucketing? I would think that would solve the issue since then they would be sorted in each 'bucket' before being returned - run sort_by_date first

I can definitely do this. Should we just sort by date and then sort by value for all lists of results across the board?

Issue for borked date sorting: https://github.com/alanvardy/tod/issues/800

I will admit that the weight-based value scoring is powerful but unintuitive and difficult for a new user. I would prefer to define sorting within the code and then let the user select how to sort (or specify as a command line parameter) from the predefined sorting methods.
@alanvardy within the current system is the Struct being sorted (are objects returned in order), or is each object being returned based on the sort by value query?
What I would like to see is two sorting options, maybe "sort_group1" and then "sort_group2", that mirror the official client (Todoist has it "Group By" and then "Sort By", with ascending or descending for each), so you can do something like "Get all P1, sorted by date due, then no due date - then P2, same sorting", and so forth - and then those values being used universally across the board (unless there is the option to override it on the command line).
In code this would mean predefined sorting methods that we then just specify in the config, for example:
"sort1" : "priority",
"sort2" : "date_created",

With the appropriate comparators defined somewhere else in code.
I tried expanding the current sorting to include some sort of date parameter (I tried this on my date_skew branch), but this becomes limited because it requires sorting everything by a value which means that we are essentially assigning every single task object a score which is then exponentially bigger depending on how many tasks you have returned - Todoist limits to 300 tasks per project (on paid plans), but with filters we could feasibly be working through thousands of tasks.

Based on my review of the code, it looks like we are doing simple "sort by key", i.e. Integer-based value sort, is that correct? I did not see any Comparator code.
For reference: https://docs.rs/compare/latest/compare/ - I should just be able to stack Comparators.
I think I could work on writing a custom sort, and then just call that comparator to sort the results.
What buckets do

@alanvardy if you will take the work of fixing date sort, I'll take the assignment of writing the sort/comparator code for custom sorting.

Looking forward to seeing these new changes! Let me know if there is anything else I can help on with this.

@rvbcldud what order would you like to see tasks sorted in?

Ascending order in date, taking into account priority
For example:

Write email (due yesterday) p2
Take out trash (due yesterday) p4
Do laundry (due today) p1
Eat breakfast (due today) p3
Etc...

Provided there are no overdue tasks, I'd like to see my highest priority task due that day first.
Let me know you what you think

Thx.
For me I prefer priority, then due date/time - so all P1 before P2 before P3 before P4, for example:

File Timesheet (due today, p1)
Email boss (not due, p1)
Contact company (p2, due yesterday)
Contact other company (p2, due today)
Call someone (p2, no due date)
Email friend (p3, no due date)
Contact person (p4, due friday)
Call someone (p4, no due date)

I will ensure both are covered!

How would you two deal with a p1 task that is due tomorrow? Would it be first or last?
For myself, I would hope to see a p2 task due today before a p1 task due tomorrow.
But I would probably rather see a p1 task due today before an overdue p2 task
My point is that priority is probably more important when dealing with overdue/today tasks
And date is probably more important when dealing with tasks in the future. If I have a p1 task due in December, it shouldn't come ahead of a p2 task due today right?
Hopefully this is thought provoking.

For me, a p1 task is inherently more important than a P2 task - I do not have a lot of P1 tasks, but they are the ones that are of a core importance. So, even if a P2 task is due, if I don't get my P1 tasks done, then I am not spending time on the most valuable items.
That said, I follow the GTD philosophy and only use due dates on tasks that either must happen by a certain date, or as required for recurring tasks.
I do like adding logic around recurring versus not recurring, because I would probably rather have a recurring task before a not recurring task due - so we can certainly add more buckets beyond what exists within the task itself (for example, I like the logic of "now" for due in the next 4 hours as more important)
Either way, I want to ensure that I make the sorting logic flexible enough that people can rearrange it according to what they plan.  The goal would be to allow someone to specify a sort order in the config - something like a JSON field, for example:
["now","overdue", "priority", "due_date"];
Anything remaining would default to a default sort order.
I also think I could add logic for due dates (with no time) to be due at a certain time.

That is a great question, Alan!
My preferred order outlined above addresses your concern about a higher priority task "starving" a more urgent lower priority task.
You bring up an interesting point regarding overdue tasks though. I would agree on your order proposed.  So perhaps I would want them to be the first thing so I am reminded to reschedule them... I'll have to think about that more.
I hope this helps!

I think that this is covered now with this PR: https://github.com/alanvardy/tod/pull/934
For all the list commands the user can select from one of the following sorts:

Todoist: What comes back from the API unchanged
Value: Sort based on the "weight" configured in `tod.cfg"
Datetime: Sort purely based off of the datetime on the task

Please reopen and let me know if I am closing this erroneously!


Toggle to show LBC / USD price / Both throughout the app

The Issue
Per a suggestion from a community member, it would be nice to have a toggle that would allow content prices to be shown in either LBC or USD (or both?) throughout the LBRY app (this would include any area that currently shows the LBC price)
System Configuration

Anything Else

Screenshots

closing, will only show LBC for the near future


Needs attribution file

See https://github.com/edgexfoundry/app-functions-sdk-go/pull/249 for example.

fixed by #121 and #119


Many uknown attributes

I'm trying to parse the manifest of some apps, for example Sayfe Secure Private Messenger and I see lots of 'uknown' attributes in the resulting file.

Multiple attributes with the same name ('unknown') create a non valid XML
Resulting info is partial, many valuable attributes do not have valid names.

I believe that the problem is in XmlDecompressor
Any ideas ?
Thanks.

Seems to be related to #131

I see more and more of apps that ClassyShark can't handle their manifests...


Fix crash on presenting pan modal over pan modal

Summary
Fix crash on presenting pan modal over pan modal
Related issues:
https://github.com/slackhq/PanModal/issues/157
https://github.com/slackhq/PanModal/issues/142
Requirements (place an x in each [ ])

[ x] I've read and understood the Contributing Guidelines and have done my best effort to follow them.

[x ] I've read and agree to the Code of Conduct.

[ x] I've written tests to cover the new code and functionality included in this PR.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


still not working on window with ruby installed with msys2

Ruby version
ruby 3.1.3p185 (2022-11-24 revision 1a6b16756e) [x64-mingw-ucrt]
Code snippet
any rb file, the lsp server just doesn't work
Description
Ruby LSP> Trying to activate Ruby environment with command: ruby -rjson -e "printf(%{RUBY_ENV_ACTIVATE%sRUBY_ENV_ACTIVATE}, JSON.dump(ENV.to_h))" inside directory: d:\projets\logic_games
Ruby LSP> Skipping lockfile copies because there's no top level bundle
Ruby LSP> Running bundle install for the custom bundle. This may take a while...
Could not find gem 'debug'.
C:/etc/msys64/ucrt64/lib/ruby/3.1.0/uri/generic.rb:760:in check_path': bad component(expected absolute path component): d:/projets/logic_games (URI::InvalidComponentError) 	from C:/etc/msys64/ucrt64/lib/ruby/3.1.0/uri/generic.rb:806:in path='
from C:/etc/msys64/ucrt64/lib/ruby/3.1.0/uri/generic.rb:192:in initialize' 	from C:/etc/msys64/ucrt64/lib/ruby/3.1.0/uri/generic.rb:136:in new'
from C:/etc/msys64/ucrt64/lib/ruby/3.1.0/uri/generic.rb:136:in build' 	from C:/etc/msys64/ucrt64/lib/ruby/gems/3.1.0/gems/ruby-lsp-0.8.0/lib/core_ext/uri.rb:18:in from_path'
from C:/etc/msys64/ucrt64/lib/ruby/gems/3.1.0/gems/sorbet-runtime-0.5.11090/lib/types/private/methods/_methods.rb:277:in bind_call' 	from C:/etc/msys64/ucrt64/lib/ruby/gems/3.1.0/gems/sorbet-runtime-0.5.11090/lib/types/private/methods/_methods.rb:277:in block in _on_method_added'
from C:/etc/msys64/ucrt64/lib/ruby/gems/3.1.0/gems/ruby-lsp-0.8.0/lib/ruby_lsp/utils.rb:9:in <module:RubyLsp>' 	from C:/etc/msys64/ucrt64/lib/ruby/gems/3.1.0/gems/ruby-lsp-0.8.0/lib/ruby_lsp/utils.rb:4:in <top (required)>'
from C:/etc/msys64/ucrt64/lib/ruby/gems/3.1.0/gems/ruby-lsp-0.8.0/lib/ruby_lsp/internal.rb:14:in require' 	from C:/etc/msys64/ucrt64/lib/ruby/gems/3.1.0/gems/ruby-lsp-0.8.0/lib/ruby_lsp/internal.rb:14:in <top (required)>'
from C:/etc/msys64/ucrt64/lib/ruby/gems/3.1.0/gems/ruby-lsp-0.8.0/exe/ruby-lsp:39:in require_relative' 	from C:/etc/msys64/ucrt64/lib/ruby/gems/3.1.0/gems/ruby-lsp-0.8.0/exe/ruby-lsp:39:in <top (required)>'
from C:/etc/msys64/ucrt64/bin/ruby-lsp:32:in load' 	from C:/etc/msys64/ucrt64/bin/ruby-lsp:32:in '
[Error - 11:56:43 PM] Server initialization failed.
Message: Pending response rejected since connection got disposed
Code: -32097
[Info  - 11:56:43 PM] Connection to server got closed. Server will restart.
true
[Error - 11:56:43 PM] Ruby LSP client: couldn't create connection to server.
Message: Pending response rejected since connection got disposed
Code: -32097
[Error - 11:56:43 PM] Server process exited with code 1.
...
[Error - 11:57:09 PM] The Ruby LSP server crashed 5 times in the last 3 minutes. The server will not be restarted. See the output for more information.
Expected output
don't know, it's been a while I'm trying to use this. But actually, I'm not sure what to except from a "had never worked" extension.

ok finally got it begin to work, but much more requirement than stated
gem install debug
gem install prism
gem install ruby-lsp
also those gems strangely fail to install in windows terminal like other. I was forced to install them in a full ucrt64 (or mingw64) msys2 shell.
you might also need to delete .ruby-lsp folder and restart vscode to have it properly starting.