Few questions about the training method of OFA

Hi, @LechengKong. Thanks for open-sourcing your excellent work. After reading your paper, I still have some questions. And I am here to ask for your kind help.

During the joint training, how do you select the shared parameters of different tasks? And how do you customize the loss function of OFA training on graphs from diverse domains?
Have you ever compared the generalization ability of OFA under different training set mentioned in your paper? Intuitively, it should perform better if train and evaluate on the same dataset, but I am still curious about the generalization ability comparison if it exists.

Thank you again, and looking forward to your reply.

Hi @zhangyxrepo,
Thank you for liking our work. To answer your questions:

During the joint training, how do you select the shared parameters of different tasks?

I do not fully understand the question, what do you mean by shared parameters? In OFA, all parameters are shared, meaning that a subgraph from the citation network and a molecular graph will go through exactly the same model and parameter to get their classification results.

And how do you customize the loss function of OFA training on graphs from diverse domains?

We do not customize loss functions for different tasks. All classification tasks in OFA are carried out in a binary classification on the class node (you can refer to the paper to find the definition of class nodes). To be more concrete, suppose we have two samples in the same batch A and B from different domains with different numbers of classes 2 and 4. In the prompted graph of A, we will have 2 class nodes and 4 for B. Note that despite the prompting process, they are just graphs and we can apply the same GNN on them. After applying the GNN, we get the representations of the class node (2 in the graph of A and 4 in the graph of B), and we use the same MLP to map these representations to a scalar value denoting the likelihood of nodes belonging to the class. Eventually, the class node with the highest scalar value is selected as the class of the node. So, for A we select from 2 scalar values, and for B we select from 4 scalar values.

Have you ever compared the generalization ability of OFA under different training set mentioned in your paper?

In terms of generalization ability, you can refer to the zero-shot and few-shot experiment, when the training and evaluation datasets are different. OFA is achieving reasonably well performance on these settings.
Hope this helps. If these do not answer your questions, please let me know, happy to elaborate more.

Hi @LechengKong , thanks for your prompt and clear reply. It helps a lot, but I still have few more questions.

I do not fully understand the question, what do you mean by shared parameters? In OFA, all parameters are shared, meaning that a subgraph from the citation network and a molecular graph will go through exactly the same model and parameter to get their classification results.

I want to apologize first for the inconvenience caused by my vague question. And your answer is corresponding correctly to what I want to ask. But I want to clarify further, do you mean that in the same training epoch with the same loss function and learned model parameters, the two graphs from domain A and domain B respectively are trained at the same time? Intuitively, this approach introduces a wider data distribution during the training phase, which helps improve the generalization ability of the model, but is there any potential performance degradation reported during your training/evaluating?

In terms of generalization ability, you can refer to the zero-shot and few-shot experiment, when the training and evaluation datasets are different. OFA is achieving reasonably well performance on these settings.

OFA's generalization ability in this regard is indeed impressive. But I want to ask whether your compared "train on graphs from domain A - zero/few shot test on graphs from domain A" and "train on graphs from domain A and B- zero/few shot test on graphs from domain A or B"? I am curious whether jointly training on cross-domain graphs would impact the performance of OFA or not.
Thanks again, looking forward to hear from you.

Ah, that's a good question. Short answer is yes, we train samples from different domains together and it works. To understand this, an analogy is that an LLM is trained on the various domains (math and CommonsenseQA are trained in the same epoch), as you have a large enough embedding space/dimension, the models can learn to separate unrelated domains to eliminate negative transfer while enhancing proximal domains to induce positive transfer. To the second part of the question, you are mostly correct, and there is both performance degradation and enhancement. You can compare the results in Table 2 and Table 3. Row ofa-ind-st is trained only on the training set of the evaluated data, row ofa-st is trained on all training set of tables 2 and 3, if ofa-ind-st > ofa-st, there is degradation, and enhancement otherwise. Most of the time, we see performance enhancement, and we attribute this to two reasons: 1, the input is embedded by high-performance LM, which already well-separates unrelated data and clusters related data. 2, data in the same proximity helps each other (pcba helps hiv, arxiv helps PubMed and cora, etc). To reduce degradation, the most straight forward solution is just using a better LLM, minimizing the chance that downstream GNN confounds two unrelated domains.
The second part is also a good point. If I understand your setting correctly, in the main paper, we follow "train on graphs from domain A and B- zero/few shot test on graphs from domain A or B" setting. The model is jointly trained on FB, ARXIV, chemble. We did "train on graphs from domain A - zero/few shot test on graphs from domain A" setting in table 16 (appendix). We observe similar pattern, joint training usually but not always help.

@LechengKong
Thank you for open-sourcing this great work. A quick question: LLM is frozen during training or updated?
Best
Tiany

Hi @Tianyu9748 , the LLM is frozen. In fact, we store the obtained training set node embedding for fast training.

@LechengKong
Thank you for the response.


Windows 11 Feature Request - Snap Layout Support

Show snap layouts when I hover over a window's maximize button.

If WM_NCHITTEST is required then generating WM_NCHITTEST might be the solution.

I looked into it and wrote a sample here to see if it could be incorporated into window_manager
https://github.com/luoluoqixi/flutter_windows11_snap_layouts_examples


Feature/failed txs

Include failed transactions in blocks
Charge fees for failed transactions & record receipts
Add pre-checks for executeTransaction()
Introduce MIN_STAKING_FOR_APP_TX and MIN_BALANCE_FOR_SERVICE_TX for pre-checking

Addressed all comments, PTAL @platfowner

LGTM with some comments/questions.
Thanks for the quick progress!
minor: Could you change the PR title to a more relevant one for future reference?

Ah, I mean more descriptive one. :)

Thanks for the thorough review & all the helpful suggestions. Now merging..!


adds radon to the porject for CC and MI analysis.

adds radon to the porject for CC and MI analysis.

@suka1901 Please open the issue for radon proposal and explain

What is the problem you want to solve by radon?
How does radon solve the problem?


Doesn't throw any error when the URL length limit is crossed

'GlideRecord.add_encoded_query()' method should throw any error if the URL length limit is crossed, this will help in debugging script

similar/same as #18

we support long url's now (as of master branch) - will be part of the next release


[Tizen] Example lighting app using Tizen app framework

Problem
Currently Tizen example lighting app is a simple Linux binary, not a proper Tizen application (with app lifecycle).
Change overview

split Linux and Tizen lighting apps
make LightingManager from Linux app reusable (moved it to lighting-common)

Testing
./scripts/build/build_examples.py --target tizen-arm-light build

@Arkq needs rebase with master to get rid of the retry plugin error (missing tunnel package)


Iussue with editorIndentGuide.activeBackground

The editor marks well the indent line guide but, after a certain number of scrolls, when cursor is hidden on the screen, the color of line disappear.
This feature is useful only if i can see the indent guide marked on the bottom of code, away from cursor... Because of this iussue is not very useful, unfortunately...
This is my setting of property:
 "workbench.colorCustomizations": {
        "editorIndentGuide.activeBackground": "#90EE90"
    },

Screens:
-When cursor is visible on the screen (it is on the top left corner)-

-When cursor is hidden-

VSCode Version: 1.2.3
OS Version: Win 10

Steps to Reproduce:

Adding editorIndentGuide.activeBackground property to User setting
Adding a color to property

Does this issue occur when all extensions are disabled?: Yes

Duplicate of #49173


Python: append postFixup, put matplotlib tests in separate output

Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

@bjornfor 678b917f000a6b6a8affab1c5e69f49de2c5543a is a solution to https://github.com/NixOS/nixpkgs/issues/9204

Thanks for spending time on this!

hmm, unfortunately this isn't working yet for matplotlib. The tests (installCheckPhase) is apparently run after fixup. I thought it was between install and fixup.

Since 678b917f000a6b6a8affab1c5e69f49de2c5543a was needed elsewhere I pushed it as https://github.com/NixOS/nixpkgs/commit/85a87f5155f66dbdfcdb9869f4bd4f2a10fe8e2c


Filtering mapped types declarations

This should help with things like:

go to definition
and symbol renaming

closes https://github.com/microsoft/TypeScript/issues/47813

@typescript-bot perf test this

@sandersn this would be quite a nice improvement for some libraries, is there any chance (without rushing it, of course) that this could get into the approaching 5.0?

ping @weswigham

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot user test tsserver
@typescript-bot test tsserver top100

@weswigham friendly 🏓


PHP Notice with related models

Hi, thanks for extension!
I've 3 models
The first one is model where i'am trying to update records. Another two models it is just a dictionaries.
Two more models it is manyToManyRelation models and i have an error in update first model with records from another, because in
vendor/mootensai/yii2-relation-trait/RelationTrait.php at 127 line started a filling of related model keys(it is ok for one) but when there is 2 or more related models keys does not clean and 146 line give to me PHP Notice – yii\base\ErrorException with undefined key from another model, it is treated with
$fields = []; at 127 line.
Thanks for the great extension one more time.

is it the same project as you gave me your schema?
if it is, which table is it?


RangeError (index): Invalid value: Valid value range is empty on  advance_pdf_viewer: ^1.2.0

Unhandled Exception: RangeError (index): Invalid value: Valid value range is empty: 0
#0      List.[] (dart:core-patch/array.dart:26:52)
#1      _PDFViewerState._loadPage (package:advance_pdf_viewer/src/viewer.dart:140:15)
#2      _PDFViewerState.didChangeDependencies (package:advance_pdf_viewer/src/viewer.dart:119:5)
#3      StatefulElement._firstBuild (package:flutter/src/widgets/framework.dart:4705:12)
#4      ComponentElement.mount (package:flutter/src/widgets/framework.dart:4520:5)
#5      Element.inflateWidget (package:flutter/src/widgets/framework.dart:3490:14)
#6      Element.updateChild (package:flutter/src/widgets/framework.dart:3255:20)
#7      ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:4571:16)
#8      Element.rebuild (package:flutter/src/widgets/framework.dart:4262:5)
#9      StatelessElement.update (package:flutter/src/widgets/framework.dart:4627:5)
#10     Element.updateChild (package:flutter/src/widgets/framework.dart:

In my case, it is the file name which was in UTF-8 characters. Once I changed the pdf file name to english letters, advance_pdf_viewer can read it with or without .pdf extension.

In my case, it is the file name which was in UTF-8 characters. Once I changed the pdf file name to english letters, advance_pdf_viewer can read it with or without .pdf extension.


ubuntu 20.04

sir, can I use it on ubuntu 20.04?

Yes, I think.

Yes, I think.

sir What is the relationship between xDNN and oneDNN?

Yes, I think.

sir What is the relationship between xDNN and oneDNN?

oneDNN is Intel's general Deep learning accelerate library. xDNN is only for LLM operators.

Yes, I think.

sir What is the relationship between xDNN and oneDNN?

oneDNN is Intel's general Deep learning accelerate library. xDNN is only for LLM operators.

That is to say, xDNN may perform better on LLM than oneDNN？

Yes, I think.

sir What is the relationship between xDNN and oneDNN?

oneDNN is Intel's general Deep learning accelerate library. xDNN is only for LLM operators.

That is to say, xDNN may perform better on LLM than oneDNN？

xDNN could do more operation than oneDNN, like input data is FP16 data type and weight data is INT4 data type. xDNN could accept it, but oneDNN need to optimize.

Yes, I think.

sir What is the relationship between xDNN and oneDNN?

oneDNN is Intel's general Deep learning accelerate library. xDNN is only for LLM operators.

That is to say, xDNN may perform better on LLM than oneDNN？

xDNN could do more operation than oneDNN, like input data is FP16 data type and weight data is INT4 data type. xDNN could accept it, but oneDNN need to optimize.

So, what are the differences between xDNN and oneDNN on kernels implemented with AMX, or does xDNN have specific optimizations for LLM kernels?


Update activities visibility, hide a few activities for applicant

Fixes #3479

@sandeepsajan0 A lot of rebasing today :-).

@frjo Done, rebased it with update status PR.

@frjo We can hold on to this PR until https://github.com/HyphaApp/hypha/pull/3501 is not merged. I need to fix a few things in this PR on the top of #3501

@sandeepsajan0 Test and lint fixes needed.

@frjo It is ready for testing.

@frjo Its latest version is ready for testing.

Deploying latest version to test now.


Americanized app

Can you give the option to have miles instead of kilometers and list the date as month,day instead of day,month?

You should be able to switch between km/miles in the Application settings (either use Garmin Express App or the mobile Garmin Connect app on your phone).
I will add the date format with the next update.

Added the ability to change the date format between day.month and month/day.
You will find that also in the app settings in either Garmin Express app or the mobile Garmin Connect app.

Thank you.
From: Gerrit Grunwald<EMAIL_ADDRESS>Reply-To: HanSolo/digital<EMAIL_ADDRESS>Date: Thursday, June 23, 2016 at 10:56 AM
To: HanSolo/digital<EMAIL_ADDRESS>Cc: SHANNON BAILEY<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [HanSolo/digital] Americanized app (#1)
Closed #1.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Added some screenshots on how to change the app settings to the README.md file which is shown here:


Better step failure reporting

Steps that fail should show more detail. For example, if a step's method calls other context methods, it would be nice to have something like a stack trace showing the call stack. This will make it easier to debug failures that happen from step chains.
I'm not sure on the exact implementation, but anything would be better than how it works now :)

There's -v option, which when passed shows up extended Exception message to you. For most exceptions it means "stack trace" ;-)


gdfg

Problem encountered on https://dotnet.microsoft.com/learn/dotnet/hello-world-tutorial/install
Operating System: windows
Provide details about the problem you're experiencing. Include your operating system version, exact error message, code sample, and anything else that is relevant.

Hi @faheemnoman, can you tell us what problem you're having so we can help you?


Timesheet - 25/04/2021 - Kristy Lee

Task 1
User testing governance page and user dashboard. Updating designs based off feedback from user testing. Designed all states for governor application.
Proof of Work

https://www.figma.com/file/k7D7Fwbz08hU6ZESPOsyvE/Governance-V2.0?node-id=55%3A10243

Time Spent
9 hours

Task 2
Ideating on voting system with Bucky
Proof of Work

Private messages

Time Spent
1 hours

Total Time Spent
10 hours
Account Number
a2d73cf3b37a62276ade44a96860495510d0e7d7c468950d4e49ac8a62b3d31d

Approved


Update timer.js

@arturmon your change has error and I have fixed it, kindly review carefully from next time. Thank you!

@arturmon
https://github.com/mycontroller-org/mycontroller/commit/3499e94899473b6fd565b33cb83decf60b4e625a


🐛 fixed empty workload transport distribution

Summary
As described in bug #1745 there are scenarios where a binding object with empty workload section is created.
This might happen when objects selectors selects objects with label 'X' when no such object exists in multiple variations.
This is a valid scenario and transport controller should handle it properly.
This bug was found in e2e tests @vMaroon was doing to the pluggable transport.
Related issue(s)
Fixes #
#1745

/cc @vMaroon
/cc @MikeSpreitzer
/cc @ezrasilvera

@nirrozenbaum is this code being used in the current cicd tests ?  Or you tested it manually on the side ?
/hold

@nirrozenbaum is this code being used in the current cicd tests ? Or you tested it manually on the side ? /hold

@ezrasilvera transport controller still not used in cicd (will be soon hopefully).
this bug was found in manual e2e tests and the fix was tested in a manual test.

/unhold
/approve


feat(autocomplete-theme-classic): align search box properly

This tweaks the styles so that the search box visually aligns on other elements. This applies to the loading indicator too, and optimizes for the largest possible clickable/tappable area on the submit and clear buttons.
Desktop

Mobile

On mobile, the submit icon has to be close to the left edge to align with the icons below. I didn't replicate this exact gap between the clear button and the right edge, because it looked weird. I've tried to find a gap that felt right instead. It looks a bit odd when looking at it on a computer screen, but feels smooth on a mobile device.
I've tried to simplify the calc statements as much as possible so they don't wrap and are easier to read. Whenever a factor or divisor doesn't equal to a fixed decimal value, I used fractions to avoid losing precision.

looks good!
did you play with the spacing css var ?

@Shipow Good catch, I didn't. Once we merge I'll try to see how it plays out.

I feel maybe we should try to reduce the spacing between search icon and query when on mobile (and so the rest of the alignement).

@Shipow That makes sense indeed. Let's do this in another PR.


System.AccessViolationException when I run a parameterized query

I'm getting the following error when I run a parameterized query:
System.AccessViolationException: Attempted to read or write protected memory. This is often an indication that other memory is corrupt.
Code is:
using (DuckDBConnection conn = new DuckDBConnection(connectionString))
                {
                    if (!conn.State.Equals(ConnectionState.Open)) conn.Open();
                    string sql = "SELECT * FROM td_catalog_source where ctl_id=$ctlid;";

                    using DuckDBCommand command = conn.CreateCommand();
                    command.CommandText = sql;

                    command.Parameters.Add(new DuckDBParameter("ctlid", 2));

                    using var result=command.ExecuteReader();
}

Using .Net 8.0, DuckDB.NET.Data.Full 1.0.2, DuckDB.NET.Bindings.Full 1.0.2

Does this happen when you are debugging the code? Are you using Rider?

Yes, while debugging. And yes, I'm using Rider.

..works fine when using positional parameters

Check this for a workaround: https://github.com/Giorgi/DuckDB.NET?tab=readme-ov-file#known-issues


RCTImageLoader crashes when canceling image loads (RN 0.36)

Image Loader Crashing at OSAtomicOr32Barrier (EXC_BAD_ACCESS)
Start of Stack is
- (void)didMoveToWindow
{
  [super didMoveToWindow];

  if (!self.window) {
    // Cancel loading the image if we've moved offscreen. In addition to helping
    // prioritise image requests that are actually on-screen, this removes
    // requests that have gotten "stuck" from the queue, unblocking other images
    // from loading.
    **[self cancelImageLoad];**
  } else if ([self shouldChangeImageSource]) {
    [self reloadImage];
  }
}

Steps to Reproduce / Code Snippets
Put some Network Images on the Page (Specially in a List View) then scroll or change tabs so Images which are not loaded yet are out of the View Port and go back to same tab/viewport and you will see this error.
Expected Results
No Error
Additional Information

React Native version: Latest 0.36.rc.0
Platform(s) (iOS, Android, or both?): iOS
Operating System (macOS, Linux, or Windows?): macOS

Thanks for submitting an issue. Can you update your original post and ensure all the fields required by the template are filled in?

@hramos update the issue. Let me know if you need any more information.

@SunnyGurnani you probably mean to have 0.36.rc.0 in the title instead of 0.30.rc.0?

@anttimo thats correct I have changed the title

This is also similar https://github.com/facebook/react-native/issues/10473

0.36 same issue

This issue has us still using 0.32. I'm not sure why this hasn't become a more pressing issue to fix.

Same as @chandlervdw here. We were constantly updating to the newest version to try if it is fixed. Now that we need to release an update to our app, we downgraded back to React Native 0.31 (for us 0.32 crashes as well with a related network issue) to be able to release an update. That was a sad moment since we also had to downgrade a couple of other libraries.

Same boat - this is a huge issue for us, getting hundreds of crash reports each week from it. I was realllly hoping not to have to got back to 0.31 because there's so many other good bug fixes in there - but I come here daily hoping for a miracle patch ;)

Similar story here.  We upgraded to 0.33 awhile back, and found this issue during testing.  I assumed it would be addressed within the month or two before we were ready to release, but now that date it quickly approaching, and I really don't want to downgrade.
Can this issue not be patched somehow, even something dirty?  The entire app crashing is really not good... even if the images just didn't load, or didn't get cleaned up would be better.
I'll have to learn some more objective-c to see how I can help.  Maybe there's someone who can do a quick technical writeup for why this is actually happening.  For example, what is trying to be achieved with the line: OSAtomicOr32Barrier(1, &cancelled).  Which part is the "BAD_ACCESS"?  I assume the issue is the &cancelled pointer is no longer valid, but how or why does that happen?  I'd love to help, but this language isn't my strong suit.

Is there a rnplay snippet that reproduces the crash?

@hramos I created an app to reproduce the bug https://github.com/gitim/ListViewApp. To reproduce you need scroll intensively, sometimes the bug happens quickly, sometimes you need to scroll more, I think it depends on your network connection.

I can also confirm that this is still crashing, even though the crash rate got much better after upgrading to version 0.36.0.rc.1. We upgraded our production app from 0.28.0 to 0.34.0 two weeks ago. After that, we experienced an enormous increase of crashes, so we decided to release a new app update with 0.36.rc.1 as soon as possible (hence the release candidate and not the stable version) as there were two promising commits in 0.35.0. and 0.36.0,rc.1.
After evaluating the crash rate of this crash after a week on production, the crash rate was reduced by 88%, so it really helped a lot. But still, a proper fix would be amazing.

Did anybody try to disable removeClippedSubviews of ListView, does it reduce crashes?

@gitim yes it does.
I also found that if the server has error or Not found for any image url in the list it increases these crashes even when removeClippedSubviews is disabled.
So I would suggest to set one of the URL which responds as 4xx or 5xx

I created a product pain. Please, vote to pay attention of the core team members to the bug.

@gitim voted.

Thanks @gitim, I'm trying to reproduce with your app right now. With Xcode's memory analyzer I can see a number of zombie NSCFURLSessionTask but I can't reliably repro the crash.

I didn't find reliable way to reproduce, but it is definitely reproducible in this app. After about 3 minutes of attempts it crashed http://www.giphy.com/gifs/l0MYw9QKCyg2ESvsI.

@gitim: one theory I'm trying to verify now. Could you try removing the [_delegates removeObjectForKey:task]; in -[RCTHTTPRequestHandler cancel]? Since the task is still running at that point (and will still call the completion callback), this may lead to an early release.
The other thing I'm investigating is that when running your app in Instruments, it looks like all of the __NSCFLocalDataTask are actually being leaked.

@gitim @javache I think what makes it easier to trigger a crash, is when you throttle the network speed on your machine ...

I can confirm I am seeing this crash as well in my production app. on version 0.36. Was seeing it a lot more before I upgraded to 0.35. My app also has a Listview with many images that load and unload based on the user's scroll position.

@javache I have tried, it didn't help, the app is still crashing.

Hey everyone, I've just put up https://github.com/javache/react-native/commit/fb2f5c50a912aa0dd4ea4551ac448d7b7e171940 which is a potential fix. I have not been able to consistently reproduce a crash, but I could find a significant amount of leaks in NSURLSessionTask which are usually indicating some state is messed up (and could cause crashes).
Summary of my changes:

rewrote -[RCTImageLoader dequeueTasks] to be more thread-safe and efficient
made RCTNetworkTask operations thread-safe
made all RCTHTTPRequestHandler calls happen from the same dispatch queue and tweaked its cancellation logic

Please try out these changes by pointing your local react-native install at that github commit. Once we get some feedback that this solves the issues people have been seeing we'll land it on master and potentially do a new release of 0.37.

Just tried it with our app and it is still crashing on this line. https://github.com/javache/react-native/blob/fb2f5c50a912aa0dd4ea4551ac448d7b7e171940/Libraries/Image/RCTImageLoader.m#L388
I would say that it took longer to crash than before.

I confirm, unfortunately, bug is still here.

The bug is still there for us too ☹

+1 on this issue, this is by far our biggest crash (on RN 0.36)

We've added scroll throttling to help lower crashes, but sadly hasn't fully stopped the issue.
scrollEventThrottle={200}

We replace the official ImageView(RCTImageView) to our own native imageview
const OurOwnImageView =  requireNativeComponent('OurOwnImageView', null);

@javache Since this seems to be impossible to fix, what about a rollback of the changes that introduced this bug and go from there? It was introduced going from 0.31 to 0.32.
We are still stuck on 0.31 because of this bug and it is really limiting to us. Is there any way we can help with this?

@animabear care to share your custom image View?

@pietropizzi  our custom imageview wrote by oc, you can let your ios or android developer do it for you
https://facebook.github.io/react-native/docs/native-components-ios.html

+1 this is the biggest cause of crashes in our app.

Hey everyone, I am willing to pay a $250 bounty to anyone who fixes this bug, and gets their fix merged into master! Let's kill this thing.

I'm going to match @huitsing 's $250 bounty!! So it's now at $500 total. That will buy you a very large turkey for your feast tomorrow (for those in the USA).

Thanks @gabegreenberg ! Specifically, our crash looks like:
Specifically, ours manifests as
Crashed: com.facebook.react.ImageLoaderURLRequestQueue
EXC_BAD_ACCESS KERN_INVALID_ADDRESS 0x0000000371c8beb8
---
RCTImageLoader.m line 258
__30-[RCTImageLoader dequeueTasks]_block_invoke

Hi,
I am using https://github.com/oblador/react-native-image-progress
and I have never seen this error

@agumack what version of RN are you on?

@gabegreenberg from 0.2x and now 0.37

I have use react-native-image-progress amd i have faced the crashes
Have you changed setting for removeClippedViews ?
On Wednesday, November 23, 2016, agumack<EMAIL_ADDRESS>wrote:

@gabegreenberg https://github.com/gabegreenberg from 0.2x and now 0.37
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/issues/10433#issuecomment-262597016,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA5l2JxOuwKPLyCUDQNpGiod7swvMY_Oks5rBIfGgaJpZM4KZhDZ
.

--
Thanks !
Sincerely,
Sunny
917-804-7520

So is the image loading cancelation really necessary? I mean... as you want them to load, not loading them would make a memory leak or set of instructions for loading disposed? I found a way to contour this and do not have a crash, however it does not look like a valid fix for the magnitude of this project

So is the image loading cancelation really necessary? I mean... as you want them to load, not loading them would make a memory leak or set of instructions for loading disposed? Me and my friend found a way to contour this and do not have a crash, and it worked for our purposes, however it does not look like a valid fix for the magnitude of this project

@SunnyGurnani I was unable to reproduce the error in the RN 0.38 and 0.39-rc.0
Have someone tried these versions?

Knowing the commits that introduced this crash help might be a good start to debug this. Maybe some of them could still be reverted.
@SunnyGurnani, @gitim Since you can reliably repro this, could you help bisect this? Can you try going to RN 0.31 and 0.32 to verify the bug was definitely introduced in 0.32? If we can be sure about the release where this was introduced, that only leaves us with ~250 commits, only a subset of which will be related to iOS and images.
@gabegreenberg You've emailed me saying your crash rate spiked recently. Was this because you upgraded to a new RN release and if yes, which one?
Here's the commit history for RCTImageLoader: https://github.com/facebook/react-native/commits/master/Libraries/Image/RCTImageLoader.m
0.32 was cut on Aug 8. Could any of the commits in July and beginning of August cause this?
@javache Have you tried reproducing it on a phone or a simulator? Might be easier to repro on a low-end iPhone?
Upvoted the Product Pains post.

Anyone seeing production crashes - are they more likely to happen on a certain type of device? If yes that might help others reproduce this.

@mkonicek Isn't related to a device, a friend was able to reproduce the issue even in the iOS simulator.
( @pvsousalima )

We just upgraded to RN0.38 and the issue seems to have gone away. We're not disabling removeClippedSubviews.

We've experienced the first crashes related to [RCTImageLoader _loadImageOrDataWithURLRequest:size:scale:resizeMode:progressBlock:partialLoadBlock:completionBlock:]already with version 0.28.0, but really seldom.
Since we've directly upgraded to 0.33.0, the crash rate increased a lot, so I can at least confirm that the main crash cause was introduced with 0.33.0 or before.

I also upgraded to RN0.38 and it doesn't crash for that reason anymore. But it broke our project, even after building it.

@rodriguesbreno - Great! Please bisect.
Knowing in which release exactly* this started happening would help debug it. You can do that by downgrading to an earlier RN version - if you cannot repro, that version is good. If you can repro, that version is bad. Find the first bad one.
@javache Tells me he could repro the memory leak on a slow network, using the Network Link Conditioner to make network traffic slower.

0.35 is bad, it happens in it. What about a list? Like:

[ x ] 0.35
[    ] 0.38

0.35 is bad, it happens in it. What about a list? Like:

[ ] 0.35
[ ] 0.38

@pvsousalima @rodriguesbreno is it online's app did upgrade to RN0.38 or testing environment?

@ymmuse Have tested two apps, one in active development and other created only to test the bug.
Before upgrade to 0.38 was easy to detect the bug. The versions witch we noticed the bug was the 0.36 and 0.37.
Tomorrow will be checking, previous versions (0.34, and 0.33)

0.38  also

@rodriguesbreno Our app using RN0.32 and there are a lot same crash at the online

We @rodriguesbreno noticed no crashes on 0.38 till now. I marked 0.38 as @XHTeng confirmed it.

@XHTeng and @ymmuse Please provide more info. There's a way to reproduce the bug?
Before I've noticed the issue when a listview with lots of images was loading.

@rodriguesbreno  Sadly, i'm not reproduce by myself till now.

@huitsing @gabegreenberg  you can use this solution:

I created a test app which consistently repros this crash for me in the simulator. The app just rapidly hides and shows a few images.
Repro Info

React Native<PHONE_NUMBER>c54b8d5de7bef9f69f6fe6b1b4763d (from master on Nov 23)
iPhone 6s+ Simulator (iOS 9.2)
Using RN packager
Running app in debug mode

Repro Steps

Clone the repro app from https://github.com/rigdern/RNImageRepro
Run the app in the simulator
Click the "Start" button

The app crashes in under a minute. Note that sometimes I see the images flickering and sometimes I don't see them at all. Both eventually result in a crash for me.
I tried @SylviaRu's suggestion but it still crashes.

@rigdern You crash is this place?：

My plan is to solve this problem with crash info: [RCTImageLoader dequeueTasks]_block_invoke .

@SylviaRu No, my crash is usually on one of these lines using RN commit<PHONE_NUMBER>c54b8d5de7bef9f69f6fe6b1b4763d.
Which version of RN are you using?

@SylviaRu You're right. it maybe make app crash, but lots of crash as @rigdern says

We were able to stop the crash by not calling a cancelation block, since we
want the images to load.
On Fri, Nov 25, 2016 at 05:40 max<EMAIL_ADDRESS>wrote:

@SylviaRu https://github.com/SylviaRu You're right. it maybe make app
crash, but lots of crash as @rigdern https://github.com/rigdern says
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/issues/10433#issuecomment-262897162,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABufAhC_6BP9Ef7RsbF58h_35KZOwNQoks5rBpDsgaJpZM4KZhDZ
.

I created a PR (https://github.com/facebook/react-native/pull/11145) which I believe fixes this bug. I can no longer repro the crash using the steps I described in my earlier comment.

@rigdern
Thanks, it seems fixed this crash. But It will crash when calling [task cancel]. Use both yours and SylviaRu's solution will stop crashing.

@nbyh100 Which version of RN are you using?

@rigdern
0.36 0.37 0.38 can reproduce this crash when refreshing (commnd+R) simulator.

@nbyh100 I want to double check that I've understood you. There have been multiple image loader crashes reported across several versions of RN so it's important we get the details right in terms of which crashes have been witnessed in which versions of RN.
You are saying that, even after applying my fix (PR #11145), RN 0.38 still crashes in dequeueTasks on line 254 (canceling the task).
After applying my fix and @SylviaRu's fix to RN 0.38, you don't see any other image loader crashes.
@nbyh100  is the above correct?
@SylviaRu can you provide an explanation for why dequeueTasks crashes and how your change fixes it?

@rigdern
Yes

hey @javache - The commit that was merged, while addressing some crashes, doesn't address the main crash that this thread is addressing around dequeueTasks (which was consolidated into this issue from https://github.com/facebook/react-native/issues/10731), so I'm not sure if this issue should be resolved at this point. Thoughts?

I submitted PR #11296 which I believe fixes the dequeueTasks crash. If anyone wants to test it, let me know if it resolves the crash for you.

Nice! @rigdern we will give these a shot soon - excited about these changes! Thanks.

Thanks @rigdern, if it works and is merged to master, how do we get in touch with you to pay our $250 towards the bounty?

Thanks @rigdern! We're merging your two PRs in and will push to production in the next day or two. I'll definitely report back. I have high hopes! 👍

@gabegreenberg Thanks for the offer but I decline the bounty. I worked on this issue just because it seemed to be affecting a number of people and it looked like an interesting bug. Let me know whether my PRs resolve the crash for you.

Sounds good @rigdern, really appreciate your hard work!! We'll let you know if your PR's resolve the crash or not. Thanks again.

We were also exper

Is Pull Request merged already ?

@SunnyGurnani Yes, both PRs have been merged but they haven't made it into any releases yet:

#11145 iOS: Fix an image loader crash
#11296 iOS: Fix dequeueTasks crash in image loader

@mkonicek Could you cherry-pick these commits to 0.39? 0.40 had breaking change for all iOS 3rd party libraries https://github.com/facebook/react-native/issues/11423 I don't know when we can use 0.40 RN.

@rigdern - We've now had your fixes in production for a few days - the crashes around dequeueTasks have DRASTICALLY been reduced, to the point that I consider this a huge success, so thanks a ton. I see you mentioned that you decline the bounty - but just wanting to be extra clear that we'd be totally happy to send the money your way.
We do still have some crashes in dequeueTasks though, so maybe there's still a problem lurking in there. The number of crashes has gone into the noise rather than primary crash now though.
Thanks again!

@huitsing, that's great to here! That's correct, I declined the bounty but thanks for the offer.
Are you sure that the dequeueTasks crashes you are still seeing are being hit in apps which have the fix? If yes, can you share the exception and stack trace?

Hi @rigdern - we're currently running this in production: https://github.com/huitsing/react-native/commits/0.36.0-zeemee - it is RN 36 base + your two commits.
The crash is on line 242: https://github.com/huitsing/react-native/blob/afea3afe39f9e31063aac027ac6d52026ae7b857/Libraries/Image/RCTImageLoader.m#L242
The stack trace is this:
Crashed: com.facebook.react.ImageLoaderURLRequestQueue
EXC_BAD_ACCESS KERN_INVALID_ADDRESS 0x00000005e0f2beb8

#22. Crashed: com.facebook.react.ImageLoaderURLRequestQueue
0  libobjc.A.dylib                0x191392f30 objc_msgSend + 16
1  ZeeMee                         0x10024c488 __30-[RCTImageLoader dequeueTasks]_block_invoke (RCTImageLoader.m:242)
2  libdispatch.dylib              0x1917d1200 _dispatch_call_block_and_release + 24
3  libdispatch.dylib              0x1917d11c0 _dispatch_client_callout + 16
4  libdispatch.dylib              0x1917df444 _dispatch_queue_serial_drain + 928
5  libdispatch.dylib              0x1917d49a8 _dispatch_queue_invoke + 652
6  libdispatch.dylib              0x1917df940 _dispatch_queue_override_invoke + 360
7  libdispatch.dylib              0x1917e138c _dispatch_root_queue_drain + 572
8  libdispatch.dylib              0x1917e10ec _dispatch_worker_thread3 + 124
9  libsystem_pthread.dylib        0x1919da2b8 _pthread_wqthread + 1288
10 libsystem_pthread.dylib        0x1919d9da4 start_wqthread + 4

Thanks @rigdern! We have merged your two PRs in to a private React Native build, we don't see any other image loader crashes, but still crashes in dequeueTasks on line 254 (canceling the task),the same as @huitsing

Thanks @rigdern!We merged your two PRs, the crashes have been reduced, but still crashes in dequeueTasks, the same as @huitsing & @nmhuang

still crash in 0.39 :(

@njafei as far as I know the last commit from @rigdern will be released with version 0.40

It still crash on 0.38 and 0.39

@aterribili Last fixes goes in 0.40 or 0.41, 0.39 and earlier will have the issue.

Linking a crash report incase this can provide further details
http://crashes.to/s/ee7279ad0b8

This is happening frequently for many users any ideas what would be main cause for this.

@myusuf3 What version of React Native are you seeing the crashes on? What callstack are you seeing? This information is important in order to be able to give you relevant suggestions.
A couple of fixes (https://github.com/facebook/react-native/commit/23423774ba0b97784ff74907eeba2e2ba9394679 and https://github.com/facebook/react-native/commit/2aca02150481ab558f136e816412cd0cff740c5f) went into React Native 0.41 for fixing image loader crashes. If you are using an older version of React Native, you can backport these 2 fixes into your version of React Native. If you are seeing these crashes on React Native 0.41 or newer then I don't have any tips for you. Somebody needs to investigate the remaining image loader crash more deeply.

@rigdern we are on ~0.35.0 but have been for awhile and the bug just exposed itself in the latest release. Not sure what triggered it but looking for a workaround atm. That being said has '0.41.0' been released? I will try backporting those fixes but can't get it to consistently reproduce this error atm.

@myusuf3 Yes, 0.41 was released at the beginning of February. As described in this blog post, a new version of React Native is released at the beginning of each month. 0.43 should be released sometime near the beginning of this month. You can see the full list of releases at https://github.com/facebook/react-native/releases.
The image loader crashes are race conditions and it can be challenging to get the conditions just right to reproduce them consistently. In general, they trigger when an image is canceled while it's in the middle of being loaded.

@rigdern so do those commits fix the issue? We aren't able to reproduce but a significant chunk of users are hitting the issue.

@myusuf3 Probably, those 2 commits fixed the most common image loader crashes. What's the callstack at the time of the crash?

@rigdern
#0. Crashed: com.apple.main-thread
0  libobjc.A.dylib                0x18c55ef30 objc_msgSend + 16
1  App                      0x1002f8fec -[RCTNetworkTask cancel] +<PHONE_NUMBER>
2  App                      0x1002f24d8 __64-[RCTImageLoader _loadURLRequest:progressBlock:completionBlock:]_block_invoke.235 +<PHONE_NUMBER>
3  App                      0x1002f1c4c __118-[RCTImageLoader _loadImageOrDataWithURLRequest:size:scale:resizeMode:progressBlock:partialLoadBlock:completionBlock:]_block_invoke.186 +<PHONE_NUMBER>
4  App                      0x1002f2840 __119-[RCTImageLoader loadImageWithURLRequest:size:scale:clipped:resizeMode:progressBlock:partialLoadBlock:completionBlock:]_block_invoke +<PHONE_NUMBER>
5  App                      0x1002f5790 -[RCTImageView cancelImageLoad] +<PHONE_NUMBER>
6  App                      0x1002f6e84 -[RCTImageView didMoveToWindow] +<PHONE_NUMBER>
7  UIKit                          0x193958e08 -[UIView(Internal) _didMoveFromWindow:toWindow:] + 1544
8  UIKit                          0x193cf6df4 -[UIImageView _didMoveFromWindow:toWindow:] + 80
9  UIKit                          0x193958ad0 -[UIView(Internal) _didMoveFromWindow:toWindow:] + 720
10 UIKit                          0x193958ad0 -[UIView(Internal) _didMoveFromWindow:toWindow:] + 720
11 UIKit                          0x193958ad0 -[UIView(Internal) _didMoveFromWindow:toWindow:] + 720
12 UIKit                          0x193958ad0 -[UIView(Internal) _didMoveFromWindow:toWindow:] + 720
13 UIKit                          0x193958ad0 -[UIView(Internal) _didMoveFromWindow:toWindow:] + 720
14 UIKit                          0x193958ad0 -[UIView(Internal) _didMoveFromWindow:toWindow:] + 720
15 UIKit                          0x193958ad0 -[UIView(Internal) _didMoveFromWindow:toWindow:] + 720
16 UIKit                          0x193958ad0 -[UIView(Internal) _didMoveFromWindow:toWindow:] + 720
17 UIKit                          0x193957f7c __45-[UIView(Hierarchy) _postMovedFromSuperview:]_block_invoke + 156
18 Foundation                     0x18e540510 -[NSISEngine withBehaviors:performModifications:] + 168
19 UIKit                          0x193957df0 -[UIView(Hierarchy) _postMovedFromSuperview:] + 820
20 UIKit                          0x193c55268 __UIViewWasRemovedFromSuperview + 172
21 UIKit                          0x193956e6c -[UIView(Hierarchy) removeFromSuperview] + 512
22 App                      0x1001a9524 -[UIView(React) removeReactSubview:] +<PHONE_NUMBER>
23 App                      0x1001d309c -[RCTUIManager _removeChildren:fromContainer:] +<PHONE_NUMBER>
24 App                      0x1001d4610 -[RCTUIManager _manageChildren:moveFromIndices:moveToIndices:addChildReactTags:addAtIndices:removeAtIndices:registry:] +<PHONE_NUMBER>
25 App                      0x1001d43ac __108-[RCTUIManager manageChildren:moveFromIndices:moveToIndices:addChildReactTags:addAtIndices:removeAtIndices:]_block_invoke +<PHONE_NUMBER>
26 App                      0x1001d6110 __29-[RCTUIManager flushUIBlocks]_block_invoke +<PHONE_NUMBER>
27 libdispatch.dylib              0x18c99d200 _dispatch_call_block_and_release + 24
28 libdispatch.dylib              0x18c99d1c0 _dispatch_client_callout + 16
29 libdispatch.dylib              0x18c9a1d6c _dispatch_main_queue_callback_4CF + 1000
30 CoreFoundation                 0x18dac1f2c __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 12
31 CoreFoundation                 0x18dabfb18 __CFRunLoopRun + 1660
32 CoreFoundation                 0x18d9ee048 CFRunLoopRunSpecific + 444
33 GraphicsServices               0x18f471198 GSEventRunModal + 180
34 UIKit                          0x1939c7818 -[UIApplication _run] + 684
35 UIKit                          0x1939c2550 UIApplicationMain + 208
36 App                      0x100149714 main (main.m:16)
37 libdispatch.dylib              0x18c9d05b8 (Missing)

@myusuf3 I'm not sure if that particular crash is fixed by the 2 commits. Based on this comment, somebody else crashed with this stack as well but never reported back whether my fixes resolved his issue.

I am also seeing a crash in RCTImageLoader, it is actually loading a local image using the require('xxx.png') syntax. Does anyone else experience this problem? Also I am wondering why it is still involving NSURLSession if it is just loading a local image? Thanks!

thread #29: tid = 0x6ed912, 0x0000000192ee7014 libsystem_kernel.dylib__pthread_kill + 8, queue = 'com.apple.root.default-qos', stop reason = signal SIGABRT   frame #0: 0x0000000192ee7014 libsystem_kernel.dylib__pthread_kill + 8
frame #1: 0x0000000192faf450 libsystem_pthread.dylibpthread_kill + 112   frame #2: 0x0000000192e5b400 libsystem_c.dylibabort + 140
frame #3: 0x0000000192f27700 libsystem_malloc.dylibszone_error + 420   frame #4: 0x0000000192f2840c libsystem_malloc.dylibfree_list_checksum_botch + 36
frame #5: 0x0000000192f283d8 libsystem_malloc.dylibsmall_free_list_remove_ptr_no_clear + 680   frame #6: 0x0000000192f1e380 libsystem_malloc.dylibsmall_malloc_from_free_list + 348
frame #7: 0x0000000192f1bba0 libsystem_malloc.dylibszone_malloc_should_clear + 2180   frame #8: 0x0000000192f1e168 libsystem_malloc.dylibmalloc_zone_calloc + 152
frame #9: 0x0000000192f1e0ac libsystem_malloc.dylibcalloc + 40   frame #10: 0x0000000195541950 CoreGraphicsCGSImageDataHandleCreate + 48
frame #11: 0x00000001955383ac CoreGraphicsimg_data_lock + 5260   frame #12: 0x0000000195536ec8 CoreGraphicsCGSImageDataLock + 176
frame #13: 0x000000019534e994 CoreGraphicsripc_AcquireImage + 712   frame #14: 0x000000019554b970 CoreGraphicsripc_DrawImage + 676
frame #15: 0x000000019553ba14 CoreGraphicsCGContextDrawImageWithOptions + 636   frame #16: 0x0000000195bf6db0 ImageIOCGImageCreateCopyWithParametersNew(CGImage*, CGColor*, CGAffineTransform, unsigned long, unsigned long, unsigned long, unsigned long, unsigned long, CGColorSpace*, unsigned int, bool, int, int, bool) + 1756
frame #17: 0x0000000195bc9b94 ImageIOIIOImageSource::createThumbnailAtIndex(unsigned long, __CFDictionary const*) + 2488   frame #18: 0x0000000195bcc8a4 ImageIOCGImageSourceCreateThumbnailAtIndex + 188

frame #19: 0x00000001003595cc MagicPoserRCTDecodeImageWithData(data=0x0000000170452d50, destSize=(width = 30, height = 30), destScale=2, resizeMode=RCTResizeModeContain) + 1032 at RCTImageUtils.m:292 frame #20: 0x0000000100350dd8 MagicPoser__80-[RCTImageLoader decodeImageData:size:scale:clipped:resizeMode:completionBlock:]_block_invoke_3.313((null)=) + 76 at RCTImageLoader.m:644
frame #21: 0x0000000100ce1258 libdispatch.dylib_dispatch_call_block_and_release + 24 frame #22: 0x0000000100ce1218 libdispatch.dylib_dispatch_client_callout + 16
frame #23: 0x0000000100cf1080 libdispatch.dylib_dispatch_root_queue_drain + 1180 frame #24: 0x0000000100cf0b78 libdispatch.dylib_dispatch_worker_thread3 + 140
frame #25: 0x0000000192fab2a0 libsystem_pthread.dylib_pthread_wqthread + 1288 frame #26: 0x0000000192faad8c libsystem_pthread.dylibstart_wqthread + 4

@tianxind Your stacktrace is entirely unrelated to the issue in this thread. Yours appears to be a crash in decodeImageData, and has nothing to do with NSURLSession or cancelImageLoad. I suggest filing a different bug about your crash, so as to not pollute/derail this already-long bug here.

@mikelambert ok I will delete my post

Oh man, this thing has been plaguing me for months now.
(Just posting to make sure this is what everyone else is getting.)

@booboothefool The crash in your screenshot was fixed by https://github.com/facebook/react-native/commit/2aca02150481ab558f136e816412cd0cff740c5f which is included in React Native 0.41 and higher.

Hi there! This issue is being closed because it has been inactive for a while.
But don't worry, it will live on with Canny! Check out its new home: https://react-native.canny.io/feature-requests/p/rctimageloader-crashes-when-canceling-image-loads-rn-036

We are still getting multiple crashes in production on v0.41:


RPI doesnt boot nixos when Serial hat is on

Hello ive tried to use your module to fix this error on Raspberry 3b, but it doesnt help.

Do you have any advice why nixos get stuck on a jumbled boot screen when i connect this hat https://abelectronics.co.uk/p/77/rs485-pi but works fine without? I need to read data from /dev/serial device but have been unsuccessful using Nixos. This serial interface hat works out of the box with RaspberianOS though.
This is my config, i basically just cloned your rpi-example and flashed the sd-image with dd.
{inputs, ...}: {
  imports = [inputs.raspberry-pi-nix.nixosModules.raspberry-pi];
  nix.settings = {
    substituters = ["https://raspberry-pi-nix.cachix.org"];
    trusted-public-keys = ["raspberry-pi-nix.cachix.org-1:WmV2rdSangxW0rZjY/tBvBDSaNFQ3DyEQsVw8EvHn9o="];
  };
  hardware = {
    bluetooth.enable = false;
    raspberry-pi.config = {
      all = {
        options = {
          # ive tried a bunch of options here
        };
      };
    };
  };
}

Help much appreciated, thanks.
Edit: seems like just creating loopback with RX and TX on the GPIO results in the same error

Hey blazp7. Sure, I can try to help.
This repo and nixpkgs both use uboot as the bootloader, and uboot has a serial interface outputting the same information you posted in your screenshot and listening for input, so I would expect a loopback to cause uboot to fail.
Raspbian does not boot with uboot, so it wouldn't have this issue with a loopback.
I'm not sure why connecting the hat is causing issues though. Can you paste your /boot/firmware/config.txt?

Thankfully I have mostly solved the issue. It was a non-problem, i only needed to connect the wires from the serial extension hat to my device. It seems that just letting the rs485 connector/wires dangle in the air is picking up some interference? If i connect the rs485 connector/wires to my device it boots successfully. I can even just pinch the wires together, it still goes through successfully with the boot process.
I was trying to nix overlay uboot with the silent boot flags (links below) but i was unsuccessful. Maybe it is worth consideration still but for now it works!
https://raspberrypi.stackexchange.com/questions/116074/how-can-i-disable-the-serial-console-on-distributions-that-use-u-boot
https://raspberrypi.stackexchange.com/questions/116074/how-can-i-disable-the-serial-console-on-distributions-that-use-u-boot


fix: update required_version format

Description
fix: update required_version format so it is compatible with current regex check in catalog pipeline
Check the relevant boxes:

[ ] Bug fix (nonbreaking change that fixes an issue)
[ ] New feature (nonbreaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Examples or tests (addition or updates of examples or tests)
[ ] Documentation update
[x] CI related update (pipeline, etc.)

Checklist

[ ] If relevant, a test for the change has been added or updated as part of this PR.
[ ] If relevant, documentation for the change has been added or updated as part of this PR.

Merge

Merge using "Squash and merge".
Make sure to use a relevant conventional commit message that is based on the PR contents. The commit message determines whether a new version of the modules needs to be released, and if so, which semver number to use).

:tada: This PR is included in version 1.0.1 :tada:
The release is available on:

GitHub release
v1.0.1

Your semantic-release bot :package::rocket:


Backward/forward compatibility with different version of ORT

Observation
With #662 merged, it became crucial for ort-genai to have certain level of backward/forward compatibility with different version of ORT. However, the current status isn't ideal.
During my work on #724, the following observations was found on Win32.
Forward compatibility
Compile ort-genai with ORT 1.18 headers + DLLs, the wheel produced will refuse to load ORT 1.19 (ort-nightly atm):
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "C:\Users\jialli\AppData\Local\Anaconda3\envs\ort-genai-py311\Lib\site-packages\onnxruntime_genai\__init__.py", line 23, in <module>
    raise e
  File "C:\Users\jialli\AppData\Local\Anaconda3\envs\ort-genai-py311\Lib\site-packages\onnxruntime_genai\__init__.py", line 13, in <module>
    from onnxruntime_genai.onnxruntime_genai import *
ImportError: DLL load failed while importing onnxruntime_genai: A dynamic link library (DLL) initialization routine failed.

The search path is correct. It's a pure DLL initialization thing. I suppose direct linkage with ORT 1.18 causes the initialization routine to expect a fixed memory layout. Using a newer version breaks this expectation.
Manually switching ORT lib to 1.18 fixes the DLL initialization issue.
Backward compatibility
Compile ort-genai with ORT 1.19 headers + DLLs, similar issue exists if you try to load ORT 1.18 :
>>> import onnxruntime_genai as oga
The requested API version [19] is not available, only API versions [1, 18] are supported in this build. Current ORT Version is: 1.18.0
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "C:\Users\jialli\AppData\Local\Anaconda3\envs\ort-genai-py311\Lib\site-packages\onnxruntime_genai\__init__.py", line 22, in <module>
    raise e
  File "C:\Users\jialli\AppData\Local\Anaconda3\envs\ort-genai-py311\Lib\site-packages\onnxruntime_genai\__init__.py", line 12, in <module>
    from onnxruntime_genai.onnxruntime_genai import *
ImportError: DLL load failed while importing onnxruntime_genai: A dynamic link library (DLL) initialization routine failed.

Solution
Implementing #693 on Windows should help. With #724, I see no similar issue on Linux between 1.18 and 1.19. It's still not perfect, but it hugely reduces the possibility of forementioned crashes.
This is just part of the "C++ ABI compatibility" rabbit hole. Win32 actually solves this issue decades ago. The (almost) perfect solution was named COM. Although COM is still widely used by Windows itself, it should not be considered a viable solution in the modern C++ world.

Seems like an env issue


-e flag not working

$ kedro kubeflow run-once -e central
Usage: kedro kubeflow run-once [OPTIONS]
Try 'kedro kubeflow run-once -h' for help.
Error: no such option: -e

$ kedro kubeflow run-once -e central
Usage: kedro kubeflow run-once [OPTIONS]
Try 'kedro kubeflow run-once -h' for help.
Error: no such option: -e

@em-pe Did you try kedro kubeflow -e central run-once?


Minikube unable to find xhyve process by PID

I'm unable to start minikube using the xhyve driver:
$ minikube start --vm-driver=xhyve
Starting local Kubernetes v1.7.5 cluster...
Starting VM...
E0913 09:44:27.100376    3249 start.go:143] Error starting host: Error getting state for host: Unable to find 'xhyve' process by PID: 609.

 Retrying.
E0913 09:44:27.101546    3249 start.go:149] Error starting host:  Error getting state for host: Unable to find 'xhyve' process by PID: 609

Is this something that could be resolved in docker-machine-driver-xhyve? Trying to figure out root cause.

FWIW, I was able to resolve the above issue with rm ~/.minikube/machines/minikube/minikube.pid. I think it may have been caused by minikube not cleaning up when I rebooted my laptop and may be avoided by running minikube stop before reboots.


Add Loading component when switching between pages

Loading
Because of the amount of data we are presenting to users, we want to be sure that between perceived page loads, any component that has to fetch data ( and  for example) should present a <Loading /> component.
A simple Chakra UI spinner will suffice for this task https://chakra-ui.com/spinner

Be happy to take this 😊

We could also make use of the Skeleton component for individual component loading states.
Pretty sure we can change background/color/etc
Just a thought

 Add loading component when switching between pages

On it if available


Improve Rails/EnumUniqueness cop to also handle array duplicates

An extension of the Rails/EnumUniqueness cop (see #3724) to additionally detect duplicate enum keys defined using array syntax.

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[ ] Used the same coding conventions as the rest of the project.
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[ ] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] All tests are passing.
[x] The new code doesn't generate RuboCop offenses.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[x] Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop).

👍


movable but non copyable components

Hello,
According to the code of assign, since it uses perfect forwarding, it should move my non-copyable objects instead of trying to copy it.
To explain:
I'd like to create a component that stores a polymorphism set of actions (feel free to advise a new system if you have any idea). The purpose of this is to create a sequence of actions to perform on that entity, e.g.:

move to x, y during 5 seconds
wait here
move somewhere else
rotate

I'm actually using this sequence of polymorphism object as a separate code into the main logic, but I wanted to merge them in the entity so that each entity can have different set of actions.
Here's the code
#include <memory>
#include <vector>

#include <entt/entt.hpp>

struct noncopyable {
        // just for testing...
        std::vector<std::unique_ptr<int>> actions;
};

int main()
{
        entt::registry reg;
        entt::entity et = reg.create();

        noncopyable sequence;

        reg.assign<noncopyable>(et, std::move(sequence));
}

In the real code, the noncopyable structure holds a vector of unique_ptr of action (described above). But now trying to assign a component and trying to move still tries to copy it at some point:
C:/msys64/mingw64/include/c++/9.2.0/bits/stl_construct.h: In instantiation of 'void std::_Construct(_T1*, _Args&& ...) [with _T1 = std::unique_ptr<int>; _Args = {const std::unique_ptr<int, std::default_delete<int> >&}]':
C:/msys64/mingw64/include/c++/9.2.0/bits/stl_uninitialized.h:83:18:   required from 'static _ForwardIterator std::__uninitialized_copy<_TrivialValueTypes>::__uninit_copy(_InputIterator, _InputIterator, _ForwardIterator) [with _InputIterator = __gnu_cxx::__normal_iterator<const std::unique_ptr<int>*, std::vector<std::unique_ptr<int> > >; _ForwardIterator = std::unique_ptr<int>*; bool _TrivialValueTypes = false]'
C:/msys64/mingw64/include/c++/9.2.0/bits/stl_uninitialized.h:134:15:   required from '_ForwardIterator std::uninitialized_copy(_InputIterator, _InputIterator, _ForwardIterator) [with _InputIterator = __gnu_cxx::__normal_iterator<const std::unique_ptr<int>*, std::vector<std::unique_ptr<int> > >; _ForwardIterator = std::unique_ptr<int>*]'
C:/msys64/mingw64/include/c++/9.2.0/bits/stl_uninitialized.h:289:37:   required from '_ForwardIterator std::__uninitialized_copy_a(_InputIterator, _InputIterator, _ForwardIterator, std::allocator<_Tp>&) [with _InputIterator = __gnu_cxx::__normal_iterator<const std::unique_ptr<int>*, std::vector<std::unique_ptr<int> > >; _ForwardIterator = std::unique_ptr<int>*; _Tp = std::unique_ptr<int>]'
C:/msys64/mingw64/include/c++/9.2.0/bits/stl_vector.h:555:31:   required from 'std::vector<_Tp, _Alloc>::vector(const std::vector<_Tp, _Alloc>&) [with _Tp = std::unique_ptr<int>; _Alloc = std::allocator<std::unique_ptr<int> >]'
main.cpp:6:8:   required from 'decltype(auto) entt::basic_registry< <template-parameter-1-1> >::pool_handler<Component>::replace(entt::basic_registry< <template-parameter-1-1> >&, Entity, Args&& ...) [with Args = {const noncopyable&}; Component = noncopyable; Entity = entt::entity]'
./entt/entt.hpp:8083:35:   required from 'decltype(auto) entt::basic_registry< <template-parameter-1-1> >::assign_or_replace(entt::basic_registry< <template-parameter-1-1> >::entity_type, Args&& ...) [with Component = noncopyable; Args = {const noncopyable&}; Entity = entt::entity; entt::basic_registry< <template-parameter-1-1> >::entity_type = entt::entity]'
./entt/entt.hpp:7445:21:   required from 'entt::basic_registry< <template-parameter-1-1> >::pool_type<Component>* entt::basic_registry< <template-parameter-1-1> >::assure() [with Component = noncopyable; Entity = entt::entity; entt::basic_registry< <template-parameter-1-1> >::pool_type<Component> = entt::basic_registry<entt::entity>::pool_handler<noncopyable>; typename std::decay<_Functor>::type = noncopyable]'
./entt/entt.hpp:7888:16:   required from 'decltype(auto) entt::basic_registry< <template-parameter-1-1> >::assign(entt::basic_registry< <template-parameter-1-1> >::entity_type, Args&& ...) [with Component = noncopyable; Args = {noncopyable}; Entity = entt::entity; entt::basic_registry< <template-parameter-1-1> >::entity_type = entt::entity]'
main.cpp:18:49:   required from here
C:/msys64/mingw64/include/c++/9.2.0/bits/stl_construct.h:75:7: error: use of deleted function 'std::unique_ptr<_Tp, _Dp>::unique_ptr(const std::unique_ptr<_Tp, _Dp>&) [with _Tp = int; _Dp = std::default_delete<int>]'
   75 |     { ::new(static_cast<void*>(__p)) _T1(std::forward<_Args>(__args)...); }
      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from C:/msys64/mingw64/include/c++/9.2.0/memory:80,
                 from main.cpp:1:
C:/msys64/mingw64/include/c++/9.2.0/bits/unique_ptr.h:406:7: note: declared here
  406 |       unique_ptr(const unique_ptr&) = delete;
      |

The problem is that you haven't defined a move constructor for your type. EnTT cannot add it magically for you. :wink:

The problem is that your type isn't movable. EnTT cannot create move constructors and assignment operators for you. Just define them and everything will work like a charm.

Well, the standard says that you usually never need to define your own move / copy constructors as they are automatically generated unless you create your own (the rules are more complex, but in this case it should work).
That's also why this works fine:
https://wandbox.org/permlink/tA9YrQN0H6VF2Cw8
Not sure why it didn't work with entt though...

Good point. Let's reopen the issue. I'll look into it further. :+1:

Ok, this is unexpected other than the source of the problem:
#include <type_traits>
#include <vector>
#include <memory>

struct noncopyable {
    std::vector<std::unique_ptr<int>> actions;
};

int main() {
    static_assert(std::is_copy_constructible_v<noncopyable>);
}

Shouldn't std::is_copy_constructible_v<noncopyable> be false? What's wrong in my reasoning?

Yes, I'm not sure to understand why it reports true. I've tested it with clang, g++ and even MSVC all reports true.

Indeed, an this fails obviously:
int main() {
    static_assert(std::is_copy_constructible_v<noncopyable>);

    noncopyable foo;
    noncopyable bar{foo};
}

That is, it tells you that the type is copy constructible but then it returns an error you try to copy construct it. That's good. :smile:
This is pretty much the problem (without giving you the details of the internals). Any idea?

It looks like it's the std::vector that wrongly report the copyable state of the POD. If using directly the unique_ptr as member variable, std::is_copy_constructible returns false;
#include <memory>
#include <vector>
#include <type_traits>

struct noncopyable {
        std::unique_ptr<int> x;
};

int main()
{
        printf("%d\n", std::is_copy_constructible_v<noncopyable>);
}

As expected:
$ ./a.exe
0

Also, it can be simplified, for some reasons std::is_copy_constructible_v<std::vector<std::unique_ptr<int>>> also evaluates to true.

Ok but it shouldn't be the case. An std::vector<std::unique_ptr<T>> isn't copyable because its object type isn't copyable as well. This is odd. I'm probably missing something obvious here...

To my understanding, std::is_copy_constructible is probably misnomer. I think it only reports if the class has "rules" to be copied. For example, std::vector has a copy constructor defined explicitly (but you simply never use it with non-copyable objects) so that's probably why std::is_copy_constructible says true. While std::unique_ptr has explicitly deleted the copy constructor so std::is_copy_constructible has value of false.
In fact, I wonder if there is a way to really check if an underlying object can be copied no matter what copy constructors are defined, deleted or implicitly defined.

At least we know you can make it work as:
struct noncopyable {
        noncopyable() = default;
        noncopyable(noncopyable &&) = default;
        noncopyable(const noncopyable &) = delete;
        noncopyable & operator=(const noncopyable &) = delete;
        noncopyable & operator=(noncopyable &&) = default;

        std::vector<std::unique_ptr<int>> actions;
};

However, it would be great to find a way to know that the type cannot be copied despite std::is_copy_constructible_v returns true.

So we discussed this issue on both ##c++ and ##c++general and someone already asked this a long time ago (didn't find myself).
So I think the correct use case would be to use a custom SFINAE expression but I think this is a bit of ugly though...

I think I'll add a is_actually_copy_constructible trait to EnTT to work around this.
From what I can see it's a flaw in the standard and there is no plan to fix it because of the backward compatibility. So it's worth it to work around the issue directly in the library.
The traits seems pretty easy to implement after all.

Can you show me the implementation?

Sure. It will be available as part of the library once done. :wink:
If I forget to point it out here, ping me when you see this issue closed.

Uhm, actually it's not that easy. I made a try.
It's easy to define a general purpose is_actually_copy_constructible but it won't intercept anyway something like in your case, where the non-copy constructible type is a data member of another type.
I don't see an easy way to do this but for that of deleting the copy constructor. Have you found a solution in the meantime?

There is a faq section in the wiki, it's updated with the faq.md file from the project.
Would you make a PR for it? Otherwise I can update the file myself, it's not a problem.

Yes, I'll do it :-)

Hi,
The following code, cause the error "The managed type must be at least move constructible and assignable"
`struct noncopyable {
noncopyable() = default;
noncopyable(noncopyable &&) = default;
noncopyable(const noncopyable &) = delete;
noncopyable & operator=(const noncopyable &) = delete;
noncopyable & operator=(noncopyable &&) = default;
     const std::vector<std::unique_ptr<int>>& actions;

};`
Maybe is it related to the same problem?
I'm on master @14e051f9
Thanks


Issue: create_csv_agent return the half-unfinished response

Issue you'd like to raise.
I have one csv file in which 1000 rows and 9 columns are available . When I asked to my agent, provide me the top 10 records, it returns half-unfinished response.
from langchain.llms import OpenAI
from langchain.chat_models import ChatOpenAI
from langchain.agents.agent_types import AgentType
from langchain.agents import create_csv_agent

agent = create_csv_agent(
    OpenAI(openai_api_key="sk-xxxx",temperature=0.6),
    "pinecone_training with 1000 data.csv",
    verbose=True,
    agent_type=AgentType.ZERO_SHOT_REACT_DESCRIPTION,
)
print(agent.run("Please provide me the top 10 records."))

How can I get the complete finished response?
Suggestion:
No response

@dosu-bot
All processing are working well, when I execute my code and asks to my agent provide me the top 10 records.
the Thought, Action and Observation is returning the complete response.
> Entering new AgentExecutor chain...
Thought: I need to get the top 10 records from the dataframe
Action: python_repl_ast
Action Input: df.head(10)
Observation:    Index  Organization Id                         Name  ... Founded                         Industry Number of employees
0      1  E84A904909dF528                   Liu-Hoover  ...    1980                Online Publishing                6852
1      2  AAC4f9aBF86EAeF                Orr-Armstrong  ...    1970                  Import / Export                7994
2      3  ad2eb3C8C24DB87                    Gill-Lamb  ...    2005                Apparel / Fashion                5105
3      4  D76BB12E5eE165B                  Bauer-Weiss  ...    2015                            Dairy                9069
4      5  2F31EddF2Db9aAE                  Love-Palmer  ...    2010            Management Consulting                6991
5      6  6774DC1dB00BD11  Farmer, Edwards and Andrade  ...    2003               Mental Health Care                3503
6      7  116B5cD4eE1fAAc     Bass, Hester and Mcclain  ...    1994                Computer Hardware                2762
7      8  AB2eA15d98b6BD4  Strickland, Gray and Jensen  ...    1987                  Performing Arts                7020
8      9  0c6D831e8DceCfE    Sparks, Decker and Powell  ...    1977  Marketing / Advertising / Sales                2709
9     10  9ABE0c8aee135d6   Osborn, Ford and Macdonald  ...    1990     Investment Banking / Venture                5731

After all the process done then it returns the half-unfinished response like this:
[10 rows x 9 columns]
Thought: I now know the final answer
Final Answer: The top 5 records in the dataframe are:
Index: 1, 2, 3, 4, 5
Organization Id: E84A904909dF528, AAC4f9aBF86EAeF, ad2eb3C8C24DB87, D76BB12E5eE165B, 2F31EddF2Db9aAE
Name: Liu-Hoover, Orr-Armstrong, Gill-Lamb, Bauer-Weiss, Love-Palmer
Website: http://www.day-hartman.org/, https://www.chapman.net/, http://lin.com/, https://gillespie-stout.com/, https://kramer.com/
Country: Western Sahara, Algeria, Cote d'Ivoire, United States of America, Denmark
Description: Ergonomic zero administration knowledge user, Ergonomic radical budgetary management, Programmable intermediate conglomeration, Synergistic maximized definition, Optimized optimizing moderator
Founded: 1980, 1970, 2005, 2015, 2010
Industry: Online Publishing, Import / Export,

> Finished chain.
The top 5 records in the dataframe are:
Index: 1, 2, 3, 4, 5
Organization Id: E84A904909dF528, AAC4f9aBF86EAeF, ad2eb3C8C24DB87, D76BB12E5eE165B, 2F31EddF2Db9aAE
Name: Liu-Hoover, Orr-Armstrong, Gill-Lamb, Bauer-Weiss, Love-Palmer
Website: http://www.day-hartman.org/, https://www.chapman.net/, http://lin.com/, https://gillespie-stout.com/, https://kramer.com/
Country: Western Sahara, Algeria, Cote d'Ivoire, United States of America, Denmark
Description: Ergonomic zero administration knowledge user, Ergonomic radical budgetary management, Programmable intermediate conglomeration, Synergistic maximized definition, Optimized optimizing moderator
Founded: 1980, 1970, 2005, 2015, 2010
Industry: Online Publishing, Import / Export,

After Comma it will not process the other columns.When I choose smallest value like provide me the top 2 or 3 records. it works fine for smallest result and query the data


Show places and location

Is there a way to show places and locations? Like when I type and Google Maps return the list of company names to chose from.

Also I want to know this too


Add configurable links to footer

A test suite can have a list of links in it
The frontend footer will display the list of links if given, otherwise blank
I added links to the existing dev/demo suites (like infrastructure test), not sure if we really want that.

When the suite has a list of links they are shown in the footer.  This screenshot effectively shows no change because the demo suite has the old/default links moved into it

.
When the test suite has no links, it's blank.  (temp removed from demo suite for screenshot)

Codecov Report

Merging #218 (7207514) into main (09c05b1) will increase coverage by 18.16%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main     #218       +/-   ##
===========================================
+ Coverage   76.08%   94.25%   +18.16%
===========================================
  Files         184      114       -70
  Lines        4228     2960     -1268
  Branches      401        0      -401
===========================================
- Hits         3217     2790      -427
+ Misses       1008      170      -838
+ Partials        3        0        -3

Impacted Files
Coverage Δ

dev_suites/dev_demo_ig_stu1/demo_suite.rb
92.30% <100.00%> (+0.04%)
:arrow_up:

...tes/dev_infrastructure_test/infrastructure_test.rb
93.44% <100.00%> (+0.10%)
:arrow_up:

dev_suites/dev_options_suite/options_suite.rb
96.07% <100.00%> (+0.07%)
:arrow_up:

lib/inferno/apps/web/serializers/test_suite.rb
100.00% <100.00%> (ø)

lib/inferno/entities/test_suite.rb
98.03% <100.00%> (+0.12%)
:arrow_up:

client/src/components/Footer/Footer.tsx

...nt/src/components/TestSuite/TestSessionWrapper.tsx

...nt/src/components/InputsModal/InputsRadioGroup.tsx

...ite/TestSuiteDetails/TestListItem/RequestsList.tsx

client/src/api/TestSuitesApi.ts

... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09c05b1...7207514. Read the comment docs.


focused doesn't seem to work in v^1.0.15

My versions:
"svelte": "5.0.0-next.167",
"@animotion/core": "^1.0.15",

I'm running:
		<Action
			do={() => {
				console.log('do 1')
			}}
			focused={() => {
				console.log('focused 1')
			}}
		/>
		<Action
			do={() => {
				console.log('do 2')
			}}
			focused={() => {
				console.log('focused 2')
			}}
		/>

Literally only logs:

Here's a minimal example if you're wondering what other versions I have:
https://github.com/Blankeos/animotion-focused-bug-mre

Downgraded for now.

@Blankeos focused was a separate prop but the behavior was moved to do so it works the same — I don't know how you found it because it was only inside https://github.com/animotionjs/animotion/pull/37 and I forgot to remove it after

Hi @mattcroat thanks for the quick response.
Sorry but can you answer this question?
https://github.com/animotionjs/animotion/issues/36#issuecomment-2351811486
I kind of have a usecase for undo as well.
Specifically for a custom visible state that works with the presentation state.

When do, visible = true
When undo, visible = false

Do you think this new do behavior gives me the option to know when something goes "out of focus"?

@Blankeos open a new issue with an example


Remove optparse support

Since argparse is included in python >= 2.7, we don't add any
dependencies by adding this.
Trying to not break old code that much by allowing use_optparse to be
passed, but it will only be ignored and not affect anything.

We should break if use_optparse is passed – the interfaces are not compatible with each other. Let's throw an exception and say that it's removed.

other than that LGTM

Is the only difference that ArgParseInterface assumes task == argv[0] but OptParseInterface has the --task TaskA syntax? Maybe we could make ArgParse accept both so we don't break old code? Also was there a reason the explicit --task was removed?

the optparse interface doesn't have subcommands so we also register all parameters in a big unordered mess. so it's a bit messy

Ah I see

Closed in favor of #1036


train model seems not OK?

I use
th train.lua -data   -style_image path/to/img.jpg
it gen
model_1000.t7
model_2000.t7
model_3000.t7
......
model_49000.t7
model_50000.t7
but train model_50000.t7 to gen new picture seems not ok, is any wrong from my operate?
th test.lua -input_image tubingen.jpg -model_t7 data/checkpoints/rio.jpg/model_50000.t7
rio.zip
thanks

model_final.t7  size is 13M.   the trained model model_50000.t7 is 2.6M
and report error
Concat.lua:27: bad argument #1 to 'copy' (sizes do not match

I have the same issue that got error:
Concat.lua:27: bad argument #1 to 'copy' (sizes do not match
Is there any solution?

Image dimensions should be multiple of 32.


[Bug]: undefined reference to `absl::lts_20240116::raw_log_internal::internal_log_function[abi:cxx11]'

Describe the issue
I'm attempting to integrate a btree_multiset into our project. So far I haven't needed to build or link the abseil project itself, the btree types seem to be header-only for the most part (yay!).
However, once I got to testing I turned on ASan and ran into this compilation error:
/usr/bin/x86_64-pc-linux-gnu-ld.bfd: obj/blockmap_btree.o: in function `void absl::lts_20240116::container_internal::btree_iterator_generation_info_enabled::assert_valid_generation<absl::lts_20240116::container_internal::btree_node<absl::lts_20240116::container_internal::set_params<blockmap_btree_entry, std::less<blockmap_btree_entry>, std::allocator<blockmap_btree_entry>, 256, true> > >(absl::lts_20240116::container_internal::btree_node<absl::lts_20240116::container_internal::set_params<blockmap_btree_entry, std::less<blockmap_btree_entry>, std::allocator<blockmap_btree_entry>, 256, true> > const*) const':
/depot/out/Asan/../../vendor/abseil-cpp/absl/container/internal/btree.h:1082: undefined reference to `absl::lts_20240116::raw_log_internal::internal_log_function[abi:cxx11]'
clang-16: error: linker command failed with exit code 1 (use -v to see invocation)

I don't actually see any definition of internal_log_function, so I'm guessing it's generated or templated out somewhere during the full abseil build? In any case we don't need or want the logging at all, so I was hoping to basically
#define ABSL_INTERNAL_LOG(severity, message) assert(false, message)
#include "absl/container/btree_set.h"

in our code. Unfortunately that leads to a 'ABSL_INTERNAL_LOG' macro redefined error since there's no #ifdef check first.
Since this is the only instance of logging in the btree types, I went ahead and swapped it out with an assert() that I think is more consistent with the rest of the btree code. Is there any interest in upstreaming this change and/or adding the ability to disable internal logging so that the btree containers can keep being header-only?
diff --git a/absl/container/internal/btree.h b/absl/container/internal/btree.h
index 91df57a3..d590e4a4 100644
--- a/absl/container/internal/btree.h
+++ b/absl/container/internal/btree.h
@@ -58,7 +58,6 @@
 #include <type_traits>
 #include <utility>

-#include "absl/base/internal/raw_logging.h"
 #include "absl/base/macros.h"
 #include "absl/container/internal/common.h"
 #include "absl/container/internal/common_policy_traits.h"
@@ -1078,12 +1077,9 @@ class btree_iterator_generation_info_enabled {

   template <typename Node>
   void assert_valid_generation(const Node *node) const {
-    if (node != nullptr && node->generation() != generation_) {
-      ABSL_INTERNAL_LOG(
-          FATAL,
-          "Attempting to use an invalidated iterator. The corresponding b-tree "
-          "container has been mutated since this iterator was constructed.");
-    }
+    // Attempting to use an invalidated iterator. The corresponding b-tree
+    // container has been mutated since this iterator was constructed.
+    assert(node == nullptr || node->generation() == generation_);
   }

Steps to reproduce the problem
I tried to repro on godbolt.org, but that correctly links in the full library. I did a straight up git clone into my vendor/ folder and started using it without any build config:
#include "absl/container/btree_set.h"

struct blockmap_btree_entry {
    uint32_t time_sec;
    uint32_t blockno;
};
absl::btree_multiset<blockmap_btree_entry> btree = ...

What version of Abseil are you using?
20240116.2
What operating system and version are you using?
Linux, custom Gentoo
What compiler and version are you using?
gcc version 12.3.1 20230825 (Gentoo 12.3.1_p20230825 p2)
clang version 16.0.6

What build system are you using?
GNU Make 4.4.1

Additional context
No response

Since you are using make instead of CMake and mention header-only, I'm going to guess that you forgot to link a library. But I  can't help you since you did not provide reproduction instructions.


enabling diff charts

Grist for the mill: I've enabled diff charts by adding the following code to buildDataTableFromProps:
  buildDataTableFromProps() {
    // debug('buildDataTableFromProps', this.props);
    if (this.props.diffdata) {

        let diffdata = this.props.diffdata
        let oldData = google.visualization.arrayToDataTable(diffdata.old)
        let newData = google.visualization.arrayToDataTable(diffdata.new)
        // must take computeDiff from prototypes since not available with charts early in process
        let computeDiff = google.visualization[this.props.chartType].prototype.computeDiff
        let chartDiff = computeDiff(oldData,newData)

        return chartDiff

    }

(and of course adding a diffdata prop)
The key is getting access to the computeDiff method before having access to the chart for the chartType. Grabbing it from the appropriate prototype in the google.visualization access chain seems to work.

Hey !
Thanks for that !
Could you also give me the shape of the diffdata object so I can integrate this and add to tests ?

Could you give master branch a try and let me know if it 's working for you. I fixed event clearing and added diff support. Will publish once I get confirmation :)
Thanks !

diffdata = null // to skip

diffdata = {
   old:old_dataarray, // like data
   new:new_dataarray, // like data
}

works for piechart, columnchart, and (I believe) scatterchart (haven't tried the latter)
I'm really stretched, but can perhaps try next week
Glad you like it!


Exported csv file Networth calculations broken

Describe the bug
Balance for accounts is not accurately returned/adjusted based on send-many-memo incoming funds
To Reproduce
Steps to reproduce the behavior:

sendstx.com (turns out same similar issue is seen when sending STX with a normal transfer

connect wallet account 1, current balance

send 1 STX from account 1 to account 2 and 3 (memo optional) your wallet via sendstx.com (it should be a wallet with balance, current balance in this case is 3.99 STX (account 2) and 79.63 STX (account 3)

https://explorer.hiro.so/txid/0x1f2b582bc8fcfb78f7a1c3ae4329f6c7ee8dbf400c7ee440dec809f8a2025a58?chain=mainnet

See error:
After receiving 1 STX in account 2 and 3 it is displayed as expected:

But the excel export shows something odd:
Account 2
"Date","Sent Amount","Sent Currency","Received Amount","Received Currency","Fee Amount","Fee Currency","Net Worth Amount","Net Worth Currency","TxHash"
"2024-10-15T20:09:20.000Z","0.00","STX","1.00","STX","0.005","STX","4.994113","STX","0x1f2b582bc8fcfb78f7a1c3ae4329f6c7ee8dbf400c7ee440dec809f8a2025a58"
"2024-10-15T19:41:30.000Z","0.00","STX","1.00","STX","0.005","STX","5.994113","STX","0xd45e75370f4382d0c6a8704121dba7fb2e022453a8e3f0ec0a2d9b46caa90721"
"2024-10-10T00:50:00.000Z","0.00","STX","0.00","STX","0.75","STX","5.994113","STX","0x3b210ae91726525bdf614c95a5b8570146386ee17c7f3540df43444243f4c00e"
"2024-10-07T19:34:17.000Z","0.00","STX","0.00","STX","1.00","STX","5.994113","STX","0x740423c957d61246ed4636556b2b567a882a508757db8588362b8c2ef8e76dd3"
"2024-07-07T04:18:46.000Z","0.00","STX","0.00","STX","0.10","STX","5.994113","STX","0x735f770248c7d5056cd45861542faa8a0ae4ad22a2a72d7679b7331e22cc7768"
"2024-06-19T11:56:52.000Z","0.00","STX","0.00","STX","0.076284","STX","5.994113","STX","0xd0bc075327b32978937622010f4a015bf9c74ea589b78196e5a5970c1cdf458c"
"2024-06-18T04:01:36.000Z","0.00","STX","0.00","STX","0.20","STX","5.994113","STX","0xb1733aad18102f67d1e0f7ae9975ff89c07ccdf0e2513b9b759f1082de1ae10d"
"2024-06-17T06:12:30.000Z","0.00","STX","0.00","STX","0.10","STX","5.994113","STX","0x7005ac8e5153e32866d42db7f264a6d71fd22d8c58076f598415db6c30feb74d"
"2024-06-13T18:21:00.000Z","0.00","STX","0.000002","STX","0.0025","STX","5.994115","STX","0xc3f95259ccae30af6c5594cad466c234e4cd87aaaa3639bef62108612dfd20b4"
"2024-06-13T18:21:00.000Z","0.00","STX","0.000001","STX","0.0025","STX","5.994116","STX","0x85d85ebdf528143282d6717c776fca8485ec68041ebbec64c88c3d2352cfb99d"
"2024-06-09T03:26:05.000Z","0.00","STX","0.00","STX","0.75","STX","5.994116","STX","0xec874827427900ac33bf65c6ff657ffd0b978454b636484461c41b381e3b25a8"
"2024-06-07T11:49:59.000Z","35.0025","STX","0.00","STX","0.0025","STX","-29.008384","STX","0x6980a2f8728a07744a0768d019cfe1056d46d9865b49fa90a8db11ddd45a92bd"

Account 3
"Date","Sent Amount","Sent Currency","Received Amount","Received Currency","Fee Amount","Fee Currency","Net Worth Amount","Net Worth Currency","TxHash"
"2024-10-15T20:09:20.000Z","0.00","STX","1.00","STX","0.005","STX","80.631501","STX","0x1f2b582bc8fcfb78f7a1c3ae4329f6c7ee8dbf400c7ee440dec809f8a2025a58"
"2024-10-15T15:57:40.000Z","0.045","STX","0.00","STX","0.005","STX","80.586501","STX","0x38e4f042621d73ec1749be906ed1f49327aaa01237eb0c408a7d95371242d7f3"
"2024-10-09T15:37:51.000Z","0.00","STX","0.00","STX","0.50","STX","80.586501","STX","0x3badd198d65712c3d1406d354739245f9a4c17b6d42fc26c9fd9253b93d8d524"
"2024-10-07T14:30:48.000Z","0.00","STX","0.00","STX","1.00","STX","80.586501","STX","0x9fa6aa08ed0051638026196801c313d09cefc200fba8d309fba020475d99ddd5"
"2024-10-01T11:49:04.000Z","0.00","STX","0.00","STX","5.00","STX","80.586501","STX","0x46296c576e4be7c33f8a35998695bd5d6ca95ec48840b168b1b3d2d025205a52"
"2024-09-26T11:06:16.000Z","0.00","STX","0.00","STX","2.20","STX","80.586501","STX","0x93ea2326d6ccade488594075aad91f2964a0a83bfc81f61fae231ba9c141c239"
"2024-09-09T16:32:10.000Z","0.00","STX","0.00","STX","0.51","STX","80.586501","STX","0x5e16ac6e03ef1d20d95132c1d25a32773666bb33f6f5aa53a2a3937253c96024"
"2024-09-03T20:27:25.000Z","0.00","STX","0.00","STX","0.75","STX","80.586501","STX","0x27c653dfa95554460886e0f23d838ffa0584e179f2d578d6045226a4c5368ab0"
"2024-08-31T11:35:30.000Z","0.00","STX","0.00","STX","0.75","STX","80.586501","STX","0x24736f218dc57947e7d31d0af2affe0be61b7a6d70385c89fa654630269229a5"
"2024-08-30T11:36:01.000Z","0.00","STX","0.00","STX","6.90","STX","80.586501","STX","0xd9ef4e0173951723fc00bf8ad643b1ea165738a6957ffe7502058958c647d944"
"2024-08-29T01:00:45.000Z","0.00","STX","0.00","STX","0.50","STX","80.586501","STX","0x87cef14ad966ff9d9106323a77019d4311b78ed86149c032c8cfa104c7ef97e3"
"2024-08-15T19:26:04.000Z","0.008078","STX","12.648","STX","0.008078","STX","93.226423","STX","0x667af71b8f61a7c3cd7ce292ea3fc69ef854d285257605e67189b24fc8a7be06"
"2024-08-02T19:48:47.000Z","0.0025","STX","0.00","STX","0.0025","STX","93.223923","STX","0xb006b743e8642c33167b38f19e19dd4f48941d89da3a13475662fa11181deaee"
"2024-07-26T05:19:12.000Z","0.00","STX","21.028038","STX","0.008921","STX","114.251961","STX","0x34fee3f422544d0beb1b30a5633ae77abed8c05f7c7c643712e98ecbe1f2e3eb"

Expected behavior
When a new transaction is made, I don't expect it to influence the net worth value of moments prior to that transaction. Yet it does.
Screenshots
Here is the same from another address: SP2W6RB95KYZ6T990005G2VNT9JJVC0A1V6THMM35

Date
Sent Amount
Sent Currency
Received Amount
Received   Currency
Fee Amount
Fee Currency
Net Worth Amount
Net Worth   Currency
TxHash

2024-10-14T16:22:41.000Z
0
STX
307,245506
STX
0,1
STX
198639,371
STX
0x1e4b7838e64ce5b5b711c87d6dc8d1c37cbd9f9f2c567f697003c53390c6fe63

2024-10-09T10:47:37.000Z
0
STX
0
STX
0,5
STX
198639,371
STX
0x51d4bdcf795b116807ba86b2cc348be5bac57c3bb1d7f1824020a871245ca6e2

2024-10-08T05:56:42.000Z
0
STX
316,736404
STX
0,1
STX
198956,1074
STX
0xb19964439f155d15b000e0226ba45f261cea9ac3ad12ebf890a50908f3e0e99d

2024-10-07T05:49:01.000Z
0
STX
0
STX
1
STX
198956,1074
STX
0x214c8ffc3ff223be700838776fc1228bda9a83c33b9818007e02350c7f087b4f

2024-10-02T19:39:13.000Z
0
STX
384,758086
STX
0,1
STX
199340,8655
STX
0x294c6e57ad5eb1fd091904c71bed59142d8bb78ed3a622ca9d6f165ff8490601

2024-09-24T07:15:55.000Z
0
STX
334,494728
STX
0,1
STX
199675,3602
STX
0x91b74f972034e265484258d4343715dd6232b036e58b77598becaa83055b2f14

2024-09-17T14:01:45.000Z
0
STX
0
STX
0,3
STX
199675,3602
STX
0x1205f3261f7c6bf8ba6ab2108c6b08e63778410c4a48afa87f10020f74e58db3

2024-09-17T08:19:10.000Z
0
STX
398,844584
STX
0,1
STX
200074,2048
STX
0xfe9888f99150532612f0ab47ad9adfb641c74b84636178b824b67ffe5c3e38b2

2024-09-09T12:13:54.000Z
0
STX
273,159985
STX
0,1
STX
200347,3648
STX
0xe631a3c2ddfded82aa30ba6640e29acf42d8d1bce032dd94d2e7dd7ddaf5aaf3

2024-09-08T22:55:01.000Z
0
STX
0
STX
0,751
STX
200347,3648
STX
0x479be6eac60e58bba9e2cc8b13d55b7d9215bab9c1919e2b392767ef0b92bab3

2024-08-30T20:04:23.000Z
0
STX
705,042044
STX
0,1
STX
201052,4068
STX
0x3943254bf70213d87251b5465379d581270f726f1475ebc18c85562a5c671547

2024-08-28T16:55:58.000Z
0
STX
212,439306
STX
0,1
STX
201264,8461
STX
0x94ab9b7673e8db9580a9f0bc0a98befc4856c3584dfada3f75c0f758e9a2d230

2024-08-17T03:55:42.000Z
0
STX
0
STX
0,3
STX
201264,8461
STX
0x455ae10bbddfa6f11a0f4455f2675f54b866d2ed8bb1ba4ef6df3f28170cac27

2024-08-12T13:41:33.000Z
0
STX
389,153601
STX
0,1
STX
201653,9997
STX
0xb42ca93ac54ebc0c6ca741a1e3977858daa4312422b96f38fc34f60bef8c628f

2024-08-04T21:49:37.000Z
0
STX
692,511304
STX
0,1
STX
202346,5111
STX
0x6df78b8b43ffe351f753de8c3ecab8276e0cc4eee265b02a9209a45fbcc20496

2024-07-25T10:14:01.000Z
0
STX
0
STX
0,15
STX
202346,5111
STX
0x21d2fc456c016da8069f401868140cdc85b966f8ff07eee037cb46a33135d8b9

2024-07-21T17:32:18.000Z
0
STX
703,882024
STX
0,1
STX
203050,3931
STX
0xe75069cb4318309c96e2b4f16d4187696276bf1fac6fb81ae3fa9b610f8c0fba

2024-07-19T14:22:37.000Z
0
STX
0
STX
0,01
STX
203050,3931
STX
0x3fabd2937c5e160f2aec475248496a9c72d0bbd12814ce4067a312fdc9edeafb

2024-07-05T10:35:28.000Z
0
STX
732,9834
STX
0,1
STX
203783,3765
STX
0xf9797af4c177dbcae3fa630a981ca6295d026dda089cf7a72242c95fb4b1f8bb

2024-06-30T14:12:14.000Z
0
STX
0
STX
0,1
STX
203783,3765
STX
0x8c6307ee06c75aff6bc589f8dbf496837e824546ce35dd477b663218078c1d4d

2024-06-20T22:31:53.000Z
0
STX
739,552807
STX
0,1
STX
204522,9293
STX
0x2c5062b2ef0d6bddd924782ca4ba49ea5bb3fa5de74727457f265865ec9ca524

And another: SP3N0TH3N7BDG4WBSYV6FE2ASSAPEGWK47EEWD9TV
https://stacks-node-api.mainnet.stacks.co/extended/v1/address/SP3N0TH3N7BDG4WBSYV6FE2ASSAPEGWK47EEWD9TV/balances
"Date","Sent Amount","Sent Currency","Received Amount","Received Currency","Fee Amount","Fee Currency","Net Worth Amount","Net Worth Currency","TxHash"
"2024-10-14T16:22:41.000Z","0.00","STX","2.804672","STX","0.10","STX","1888.749507","STX","0xda07c24b774e9bbc31d54d573f85ba328243ecff1ab8be8bd426b5ff8921ccaf"
"2024-10-13T19:54:12.000Z","0.00","STX","0.00","STX","0.10","STX","1888.749507","STX","0x7c2a15379a6e330d939a385d33da4bf1266c5dc0a45c15fa0907a8f13e82aedf"
"2024-10-10T09:20:35.000Z","0.00","STX","0.00","STX","0.10","STX","1888.749507","STX","0x0b73e0ddbc30ff76065ebb7d2145fb1ffa87e87e8c74d100cd80177aa65baac9"
"2024-10-09T15:37:51.000Z","0.00","STX","0.00","STX","0.50","STX","1888.749507","STX","0x087d1c84076933aaad25e0225c99fec76930f9673255dd9cd72855a523d54fd5"
"2024-10-08T05:56:42.000Z","0.00","STX","2.891309","STX","0.10","STX","1891.640816","STX","0x3847d2b9f52635d4c0e847a7990eabc3f7dc0e28020c22a31ebb76b493d84d26"

Console log
n.a.
Desktop (please complete the following information):
n.a.
Smartphone (please complete the following information):
n.a.
Additional context
I also tested with one recipient, and without a memo then you see a similar issue.
sending STX with a normal STX transfer, same issue:
https://explorer.hiro.so/txid/0x6a04efbdca0cea319fff11bbb777404686fe37cb9d50f24cc10fec8ec14b57c8?chain=mainnet
Before confirmation
"Date","Sent Amount","Sent Currency","Received Amount","Received Currency","Fee Amount","Fee Currency","Net Worth Amount","Net Worth Currency","TxHash"
"2024-10-09T06:46:39.000Z","0.00","STX","0.00","STX","0.50","STX","0.000002","STX","0xe078a2b02258d09a65a03448018410ccb40e4802ca1186dbbe0a3549ae52b70a"
"2024-10-07T03:24:34.000Z","0.00","STX","0.00","STX","1.50","STX","0.000002","STX","0xcb98ff08ff3dc06596ebccb209ab11c038e91a040c2969749bb8dcadec8d7ba7"
"2024-10-02T19:09:16.000Z","0.00","STX","0.000001","STX","0.00018","STX","0.000003","STX","0x70f5789e6b40531a8bc28f4ca476f56dacf972ff105d09a1e1649062bf2f0d8a"
....

After confirmation
"Date","Sent Amount","Sent Currency","Received Amount","Received Currency","Fee Amount","Fee Currency","Net Worth Amount","Net Worth Currency","TxHash"
"2024-10-15T20:36:21.000Z","0.00","STX","1.00","STX","0.005118","STX","1.000002","STX","0x6a04efbdca0cea319fff11bbb777404686fe37cb9d50f24cc10fec8ec14b57c8"
"2024-10-09T06:46:39.000Z","0.00","STX","0.00","STX","0.50","STX","1.000002","STX","0xe078a2b02258d09a65a03448018410ccb40e4802ca1186dbbe0a3549ae52b70a"
"2024-10-07T03:24:34.000Z","0.00","STX","0.00","STX","1.50","STX","1.000002","STX","0xcb98ff08ff3dc06596ebccb209ab11c038e91a040c2969749bb8dcadec8d7ba7"
"2024-10-02T19:09:16.000Z","0.00","STX","0.000001","STX","0.00018","STX","1.000003","STX","0x70f5789e6b40531a8bc28f4ca476f56dacf972ff105d09a1e1649062bf2f0d8a"

now did the networth amount change on these other dates 09T06:46:39.000Z and earlier?

@ He1DAr I think we can disable the csv until we fix it, what's your take?