"dep init" doesn't use local git configuration

"go get" uses local git configuration when fetching dependencies. "dep init" doesn't behave in the same way.
Example:
We have a dependency which is in a private repo (e.g. code.xyz.internal). When we run the following:
go get code.xyz.internal/some-team/some-library.git

it succeeds, due to the following git configuration (within ~/.gitconfig)
[url "ssh://gitolite@code.xyz.internal:2222/"]
        insteadOf = https://code.xyz.internal/

which tells git where to look for a private repo. This will not, however, work with "dep init", which is expected to behave the same way as "go get".
What version of Go (go version) and dep (git describe --tags) are you using?
Go version: 1.8
Dep version: v0.1.0-215-g911cd22
What dep command did you run?
dep init -v
Output:
list versions for code.xyz.internal/some-team/some-library(): unable to deduce repository and source type for "code.xyz.internal/some-team/some-library": unable to read metadata: unable to fetch raw metadata: failed HTTP request to URL "http://code.xyz.internal/some-team/some-library?go-get=1": Get http://code.xyz.internal/some-team/some-library?go-get=1: dial tcp: lookup code.xyz.internal: no such host
What did you expect to see?
Dependencies resolved correctly
What did you see instead?
see above

if you're using gitlab, https works. I posted an update to the FAQ on how to set it up.

code.xyz.internal/some-team/some-library.git is not the same as code.xyz.internal/some-team/some-library when using go get.
When passing a URL with no indicator of the CVS system, we rely on metadata to find the repository. That's why we pass the ?go-get=1 URL query and attempt to parse the page for the <meta> tags.
The error you posted is because you actually tried this for a non-existing URL (code.xyz.internal). I assume the error for the correct URL to be similar, but be the result of not being able to find the metadata.

I'd recommend you create a Gopkg.toml with the following content:
[[constraint]]
  name = "code.xyz.internal/some-team/some-library"
  source = "code.xyz.internal/some-team/some-library.git"
  branch = "master

And try dep init again.

This is related to #174 and #286.

closing this - the underlying issues remain, but this issue is duplicative of other outstanding issues.


Expected 1 space before closing PHP tag; 0 found .

Expected 1 space before closing PHP tag; 0 found show as a fixable issue, but when running the code sniffer fix the issue is not fix and I have to manual make the fix.

I am using version 0.12.0 of WPCS and version 2.9.1 of PHPCS.
<?php if ( get_comment_pages_count() > 1 && get_option( 'page_comments' ) ) : // Are there comments to navigate through? ?>

@CheoWalker Thanks for getting back to me. Your code sample confirms that this is a duplicate of #1017.
This is fixed upstream in PHPCS itself. The fix is contained within the PHPCS 3.0.2 release and will also be in the PHPCS 2.9.2 release.


Clicking a link in an iframe in a popup, that kills the popup, throws an error

I have a form I'm filling and one of the fields requires picking an object from a list in a popup window. The list is inside an iframe on the popup page, and clicking the link in the list closes the popup and places the value in the form on the original page.
My problem is with my setup I'm clicking the link within the iframe kills the popup, and then on exiting the this.withFrame() function I get the error
Error: cannot access member 'switchToParentFrame' of deleted QObject
Here's roughly what my code looks like.
this.withPopup(/popup/, function() {
    this.withFrame('listFrame', function() {
        // do stuff to get the right link selector
        this.click(link);
    });
});

If there's a way to click the link from outside the withFrame() function?

There are many bugs with Popups :

Events are not sent as main page done
Page settings (userAgent, ...) are default on popup (not clone of main page)
Recursives calls of popups make crashes
...

As part of a cleanup effort:
Looks to be a stale help request. Assuming you've moved on to better and cooler things. Please feel free to re-open if this is still an active issue for you and we'll try our best to help out.


Added CHANGELOG files to hadoopFS and Spark clients

Added CHANGELOG files to hadoopFS and Spark clients in order to document the changes of our clients. The files will be updated as part of the clients release process.

Added the last release to the Spark CHANGELOG, but didn't find anything relevant to hadoopFS to I left it blank.

Thanks!


marathon health checks are deprecated

@marcomonaco I assigned this to you because I can't seem to assign it to Tobias M...
https://jira.mesosphere.com/browse/DCOS-14953

@marcomonaco I'm merging this because it is obvious.


Access production server slash admin, the resources and form action url get redirected to localhost:4000

Laravel Version: 9
PHP Version: 8.1
Laravel-admin: 1.*

Description:
When uploading laravel admin to production server and accessing domain.com/admin i always get redirected to localhost:400.  I checked the admin_url using php artisan tinker and it return the domain.com, not localhost. But still the website continue to serve resource file as localhost.
Steps To Reproduce:
1/ Go to domain.com
2/ Observe missing resource files because all the urls are set to localhost:4000

It's very hard to tell.. definitely not the problem of the repo, some server or setup issue it seems like.
What happens when you open /admin/auth/login ?
Have you cleared routes with php artisan route:clear or cache?

Hi Alex. Yes i tried that. and the problem was setting ADMIN_HTTPS = true. I checked and it seemed the app didn't use APP_URL env variable to operate so i forced it like this:
`        $url = $this->app['url'];
    // Force the application URL
    $url->forceRootUrl(config('app.url'));`

It works but there is a problem. Some of the forms generated by resource routes (ajax) have the actions that are generated by this function:
`    /**
* Get current resource route url.
*
* @param int $slice
*
* @return string
*/
public function resource($slice = -2): string
{
$segments = explode('/', trim(\request()->getUri(), '/'));
    if ($slice !== 0) {
        $segments = array_slice($segments, 0, $slice);
    }

    return implode('/', $segments);
}`

That function uses request()->getUri() and it returns http://localhost:4000 on the call of domain.com which i believe it's inside a docker container's environment.

Okay. I found the problem, looks like it's a misconfiguration with nginx by using proxy_pass. I have to put
proxy_set_header Host $host;

For the container to serve domain.com as request url.


Auto Layout

Fix the layout to work on all iPhones.

Have another look at this. Those side bars on the iPhone 6 Plus simulator have been looking weird from the start.


Hotfixes for Master to segment changes from SQLAlchemy

This PR cherry picks changes added to develop that are not related to SQLAlchemy, which is showing severe slowdowns on production environments.  We will keep the develop branch ini its current state (no rollback) but before any updates to the database controller is merged into master, the performance issues need to be resolved.

@mmulich @karenc Please be aware of this change.  We are seeing severe performance regression with SQLAlchemy in production.


Modal in the tab bar bug

Version
Tell us which versions you are using:

react-native-router-flux v3.35.0
react-native v0.34.1

Expected behaviour
display the modal page
Actual behaviour
display half modal page and half tab page
Steps to reproduce

go to tabbar page
use the Modal root scene
in the tabbar page invoke the Modal page action

@charlesluo2014 Please show the code of your router.

Hi @charlesluo2014 - just stumbled on this. I don't have a fix but have just used a workaround, which was to give my modal absolute position attached to the bottom of the screen.
For example, a modal component and associated styles could look like the below. (NOTICE THE ABSOLUTE POSITIONING IN THE STYLESHEET):
const MyModal = (props) => (
  <TouchableOpacity onPress={() => { Actions.pop(); }}>
    <View style={styles.modalStyle}>
      <Text>modal</Text>
    </View>
  </TouchableOpacity>
);

const styles = StyleSheet.create({
  modalStyle: {
    position: "absolute",  // LOOK HERE
    bottom: 0, // LOOK HERE
    left: 0, // LOOK HERE
    height: deviceHeight,
    width: deviceWidth,
    backgroundColor: "rgba(0,0,255,0.2)",
  }
})

<Router>
  <Scene key="modal" component={Modal}>
    <Scene
      key="main"
      tabs
      hideNavBar
      component={MyMainView}
    >
      <Scene key="page1" component={Page1}  title="Page 1" icon={TabIcon} />
      <Scene key="page2" component={Page2} title="Page 2" icon={TabIcon} />
    </Scene>
    <Scene
       key="myModalView"
       component={MyModal}
    />
    .....
  </Scene>
</Router>

Not very familiar with the source code for react-native-router-flux, but at first glance I think the issue might have something to do with the special treatment of TabBar Components in the supplied DefaultRenderer.


npm run build shows heap limit Allocation failed

command npm run build throws this error:
FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory

Best solution will be no error with application running on local host

I can try and resolve this issue....please assignn it to me

Please assign the issue to me, will try to resolve it asap
it’s probably because of a memory leak, an addition/version upgrade of a library, or a difference in how Node.js manages memory between versions (e.g. Node.js version <= 10 and Node.js version > 10).


Add a default endpoint in S3server

Context : We want to test an external software with our S3server.
Look like the software needs an DNS resolved endpoint, and doesn't support IP.
It would be nice to have a default endpoint configured in s3server , example : s3server.scality.test.
Workaround :
Copy configuration from docker (/usr/src/app/config.json), modify it and add your enddpoint on the server (/usr/src/app/config_NEW.json)
"regions": {
...
"s3.scality.test": ["s3.scality.test"],
"localregion": ["localhost"]
And restart docker with this new configuration file:
docker run  --net=host -v /home/scality/config_NEW.json:/usr/src/app/config.json scality/s3server

Hey @jbrusq ,
If you specified an host name (e.g. s3.scality.test), you can provide your own config.json using Docker volume.
First, add a new region to your config.json that you created locally:
"regions": {

     ...

     "localregion": ["localhost"],
     "specifiedregion": ["s3.scality.test"]
},

Then run your s3server using Docker Volume:
docker run -v $(pwd)/config.json:/usr/src/app/config.json --net=host -d scality/s3server

Hi @nicolas2bert ,
Look like the solution you described is the same as the one from the ticket ;)
I just say that it would be nice to have a default endpoint  "s3.scality.test", and avoid updaing the configuration...
Jerome

Hello,
Also the region is not return by a "get-bucket-location" request:
$ aws s3api --endpoint http://<endpoint_name>  get-bucket-location --bucket bucket
{
"LocationConstraint": null

}
Can we fix this ?
Thanks.

We do not have get-bucket-location implemented.
What the use case really is for it? Because we don't have regional deployments anyway.

Hi,
The use case is precisely having Rings deployed on several geographies and being able to query the region from the application.
Thanks,
Pierre

Le 26 oct. 2016 à 19:46, Nicolas HUMBERT<EMAIL_ADDRESS>a écrit :
We do not have get-bucket-location implemented.
What the use case really is for it? Because we don't have regional deployments anyway.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

--
https://www.scality.com/backup/?utm_source=signatures&utm_medium=email&utm_campaign=backup2016

Ok, I got it @pgueant, can you create a separate issue so?
Thanks.


watchEffect should allow multiple onInvalidate calls

What problem does this feature solve?
Right now each effect 'remembers' only the last callback passed to onInvalidate:
watchEffect((onInvalidate) => {
  // do some work and then...
  onInvalidate(() => console.log('foo'))
  onInvalidate(() => console.log('bar'))
})

the first console.log won't ever be called. While in this example it's trivial to shove both console.logs to a single cleanup function it can get pretty hairy when the effect gets complex.
My exact use case was reacting to audio device selection changes by creating multiple MediaStream instances conditionally and hooking them up with some other parts of the app. Since MediaStreams are created conditionally I had several if statements and each of them called onInvalidate passing some cleanup function. I was surprised that some resources weren't properly released when I changed the devices.
This feature request doesn't require any end user facing API changes, rather changing of Vue internals to keep track of multiple callbacks instead of just the last one.
In the meantime I solved my use case by creating a crude wrapper around watchEffect that does what I need. While it was easy to implement this workaround I think it would greatly improve watchEffect ergonomics if we had it in Vue out of the box.
import { watchEffect as vueWatchEffect } from 'vue'
/**
 * Vue's watchEffect remembers only the last cleanup function. This wrapper
 * allows to register multiple cleanup functions
 */
export const watchEffect: typeof vueWatchEffect = (effect, opts) => {
  return vueWatchEffect((onInvalidate) => {
    let invalidated = false

    const cleanupFns = new Set<() => void>()
    const registerCleanupFn = (cleanupFn: () => void) => {
      if (invalidated) {
        cleanupFn()
      } else {
        cleanupFns.add(cleanupFn)
      }
    }

    const doCleanup = () => {
      invalidated = true
      cleanupFns.forEach((cleanupFn) => {
        cleanupFn()
      })
      cleanupFns.clear()
    }

    onInvalidate(doCleanup)
    effect(registerCleanupFn)
  }, opts)
}

What does the proposed API look like?
no changes

My personal workaround is this function:
function fixOnCleanup(onCleanup: (cleanupFn: () => void) => void): (cleanupFn: () => void) => void {
	const cleanupFns: Array<() => void> = [];
	onCleanup(() => {
		for (const cleanupFn of cleanupFns) {
			cleanupFn();
		}
	});

	return (cleanupFn: () => void) => {
		cleanupFns.push(cleanupFn);
	};
}

watch(valueRef, (newValue, oldValue, onCleanup_) => {
	const onCleanup = fixOnCleanup(onCleanup_);

	onCleanup(() => {
		...
	});
});

closing as this seems to have been implemented in https://github.com/vuejs/core/pull/9927


Translate epub

I think your app is very good and has fast processing speed. However, I wanted to ask if you have any plans to develop the feature of translating epub files. Currently, there are many books and documents in epub format, so it would be great if you could add the ability to translate this format. Thank you very much!

Check out this GitHub repository, it should address your request:
https://github.com/jesselau76/ebook-GPT-translator


Clarify corresponding lotus conf var for deal-start-window

The README says:
You should set correctly your --deal-start-window value to be a bit larger than your miner node configuration, to cover the time required to download and import data. If this value is incorrectly set, your miner node will reject proposals because the DealStartEpoch attribute is too soon for you to accept.

it is not immediately clear what lotus config var this refers to. needs clarification.

I can add some extra comment there to say that it's related to ExpectedSealDuration, but probably isn't the only factor considered. Unfortunately, I haven't found a miner that could explain in detail how to do an exact calculation for them so they usually set it up 1.20x that value or similar.
In any case the semantics of this flag are clear: we want a value to set the DealStartEpoch in the proposal, and not get your miner to reject the deal. I'd guess every miner should be able to answer that question since it's part of their configuration and contract.

i think it is this StartEpochSealingBuffer var that is corresponding to that thanks to consulting with @reiers on slack

@f8-ptrk, if you come up with a compelling answer, feel free to drop it here so I can add it to the docs.
I'd prefer some storage provider to write this part correctly since probably they'll do better than me.

i am going at the thing right now and will see what i find out after running a a bit and then adjust if i think it makes sense - i was confused what exactly this was referring to on the lotus side


Create a rugged tensor in golang

Click to expand!
Issue Type
Feature Request
Source
source
Tensorflow Version
latest or any
Custom Code
No
OS Platform and Distribution
any
Mobile device
any
Python version
3.9
Bazel version
No response
GCC/Compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current Behaviour?
I'm currently not able to create a rugged tensor from golang. I wonder if there's a way to do it or if there's gonna be

Standalone code to reproduce the issue
if you create a newTensor right now, all elements in the lists needs to be the same size

Relevant log output
No response

Hi @juancrescente,
Can you please elaborate about your Feature. Also, kindly specify the Use Cases for this feature. Thank you!

Yes, we have a model that accepts an array as an input feature. This array can be of different length like this in python:
words = tf.ragged.constant([["So", "long"], ["thanks", "for", "all", "the", "fish"]])
Right now there's no way to do that (that we are aware of) in golang and we'd love to be able to do it.

Hi,
Thank you for opening this issue. Since this issue has been open for a long time, the code/debug information for this issue may not be relevant with the current state of the code base.
The Tensorflow team is constantly improving the framework by fixing bugs and adding new features. We suggest you try the latest TensorFlow version with the latest compatible hardware configuration which could potentially resolve the issue. If you are still facing the issue, please create a new GitHub issue with your latest findings, with all the debugging information which could help us investigate.
Please follow the release notes to stay up to date with the latest developments which are happening in the Tensorflow space.


SAI-4731   : supporting feature flag in solr

@noblepaul looks like host level support is not there yet?

@noblepaul let's plan for updated demo on Monday's sync


NTR: [dihydrouridine synthase activity] PMID:34798057 |

Please provide as much information as you can:

Suggested term label:

NTR: dihydrouridine synthase activity
Should we also add mRNA dihydrouridine synthase activity?

Definition (free text)

since def of  GO:0017150   tRNA dihydrouridine synthase activity
Catalysis of the reaction: tRNA-uracil + acceptor = tRNA-dihydrouridine + reduced acceptor.
I am assuming:
Catalysis of the reaction: RNA-uracil + acceptor = RNA-dihydrouridine + reduced acceptor.

Reference, in format PMID:#######

PMID:34798057 | Transcription-wide mapping of dihydrouridine reveals that mRNA dihydrouridylation is required for meiotic chromosome segregation.

Gene product name and ID to be annotated to this term

PomBase:dus3 (with substrates nda2 & nda3)

Parent term(s)

Current parent of   GO:0017150   tRNA dihydrouridine synthase activity
is
GO:0016627   oxidoreductase activity, acting on the CH-CH group of donors
(I am not sure if this can be improved?)

Children terms (if applicable) Should any existing terms that should be moved underneath this new proposed term?

GO:0017150   tRNA dihydrouridine synthase activity
will move under the new proposed term

Cross-references
For enzymes, please provide RHEA and/or EC numbers.
Can also provide MetaCyc, KEGG, Wikipedia, and other links.

I do not know these.

Any other information

Requested by the curating author:

Look what Carlos did:
https://curation.pombase.org/pombe/curs/d86816507d979037#
Impressive huh? I love it when the community connect functions to processes.

Is there some RHEA or EC?

This is a more general term that only specifies that it's an RNA that is modified; not sure if RHEA would make something where the 'substrate' is not THAT specific. However, I'll do a search in RHEA on the CHEBI term for a U residue and see what falls out.

CHEBI:74443 5,6-dihydrouridine 5'-monophosphate(1−) residue as a substrate; however, all instances in RHEA use it as a residue in a tRNA. Paper is fairly new.
So dus3 can use either tRNA or mRNA as a substrate.
I think making the new term mRNA specific might be a better idea here.

Do you perhaps want a term that 'mRNA dihydrouridine synthase activity' This would be a sib of the tRNA term.

yes I would prefer...
hence

Should we also add mRNA dihydrouridine synthase activity?

v

Yes Val; this tree would be consistent with others, such as pseudouridine synthase activity (with tRNA, snRNA, rRNA children)

+id: GO:0106413
+name: dihydrouridine synthase activity
children: GO:0106414 (NTR) and GO:0017150
+id: GO:0106414
+name: mRNA dihydrouridine synthase activity

Thanks Harold!

I asked Carlo if this was the first report of  mRNA dihydrouridinylation
"Pretty close but not the first. While our Mol Cell paper was in its final review stage, another paper came out that describe DUS3-dependent mRNA dihydrouridilation in human cells: Dai et al., Activity-based RNA-modifying enzyme probing reveals DUS3L-mediated dihydrouridylation. Nat Chem Biol (2021). "
A nice paper for UniProt to curate @Antonialock ?
and then for PAINTING (good triangulation) @marcfeuermann

Hi @ValWood ,
PMID:34798057 is a real gold mine. I curated DUS3 in UniProtKB/Swiss-Prot, both human and S.pombe entries.
I would have a bunch of questions comments

PMID:34798057 describes the RNA-dihydrouridine synthase activity for all 4 dus paralogs (dus1, dus2, dus3 and dus4) in S.pombe. Have you curated them in GO? I will curate the human orthologs.

I requested Rhea reactions for the mRNA dihydrouridine synthase activity, and dus3 (as well as dus1, dus2 and dus4) can work both with NADPH and NADH.

We therefore created 2 reactions, that are not yet public
Rhea:69851 a 5,6-dihydrouridine in mRNA + NAD+ = a uridine in mRNA + H+ + NADH
Rhea:69855 a 5,6-dihydrouridine in mRNA + NADP+ = a uridine in mRNA + H+ + NADPH
We also created generic reactions for RNAs
Rhea:69843 a 5,6-dihydrouridine in RNA + NAD+ = a uridine in RNA + H+ + NADH
Rhea:69847 a 5,6-dihydrouridine in RNA + NADP+ = a uridine in RNA + H+ + NADPH
@hdrabkin Should I can create a ticket for new GO terms that covers the mRNA dihydrouridine synthase activity, or do you have everything in hand?
Thanks
Sylvain

Hi @sylvainpoux ; this has been created last week
I +id: GO:0106414
+name: mRNA dihydrouridine synthase activity
Note on the RHEA reactions.
Although these might be useful for other uses of RHEA, we won't be able to use them to create logical defs because, as you can see for the tRNA diHu activities, they all use the same CHEBI id for the U residue, so that the logiclal defs using those will be the same.

Thanks @hdrabkin !

Hi Sylvain, nice wasn't it!
This is what I have so far:
https://www.pombase.org/reference/PMID:34798057
mainly curated by the author.
I have not been able to use
+id: GO:0106414
+name: mRNA dihydrouridine synthase activity
yet because of a problem with the GO pipeline the term is not yet available.
but I think the pombe GO will be covered from this paper.

This GO term still isn't accessible?

Hi Val,
apparently not. I contacted Alex (@alexsign) and Pascale (@pgaudet) before the break. Apparently, there was a problem with some Xref that is causing a failure in the GO processing
Thanks
Sylvain

I just confirmed that GO:0106414 is in fact in the editors file. It is also in the snapshot go-basic.obo; it is displaying in MGI's go browser.
It is also available in the go-basic.obo that I just downloaded from the GO web site (public).

Thanks @hdrabkin
I will check with @kimrutherford  if Canto is updating the ontologies at PomBase...
Val


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_e5546cef-53ed-4f2a-ba50-f2498dc1d4bf/pull/1 is merged into live branch.
Auto archive content to https://github.com/OPS-E2E-PPE/docs-archive-test-target_e5546cef-53ed-4f2a-ba50-f2498dc1d4bf.git

Docs Build status updates of commit 3088745:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error]

Cannot sync git repo to specified commit because branch Release_Archive_master_2020-04-15-03-23-20 has been deleted or has been force pushed: fatal: couldn't find remote ref refs/heads/Release_Archive_master_2020-04-15-03-23-20

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Update Japanese README

I fixed README-ja.md little.
大ブロック can't be understood completely, and there were parts that were not translated.
So I fixed the Japanese there.
NOTE: I'm Japanese.

thanks!


Fix robots.txt

Looks like we're disallowing everything.

Seems to be working now; I'm going to call this done.


enable MediaControl configuration after player creation

Summary of changes:

add MEDIACONTROL_OPTIONS_CHANGE event for consistency with Container's events
add configure method to MediaControl and call it from Core.configure (TODO: check whether any MediaControl-specific options were actually changed before calling it, to prevent erroneous event triggering)
add test

Coverage increased (+0.2%) to 76.31% when pulling c0de5e3d88ff52eb8be4cb6dad6765c6a0146168 on markmatney:enable-mediacontrol-configuration into 349140041e14f8d2e8f7fb8be6cfee74b48b5f6d on clappr:master.

lgtm!


Deploy err

Hi,williamcanin.
I meet some err when deploy this to github.io.
Do you know what happened?
ps.It works well at localhost.

Hi,williamcanin. I meet some err when deploy this to github.io. Do you know what happened?
ps.It works well at localhost.

Hi, I guess I have the same probem. Could you tell me the solution to it？Thank u.

Hi,williamcanin. I meet some err when deploy this to github.io. Do you know what happened?
ps.It works well at localhost.

Hi, I guess I have the same probem. Could you tell me the solution to it？Thank u. The issue

Read the project's README.md, but specifically the last note in the introduction!
I explain that the Typing Jekyll Template is not a theme that natively supports building on GitHub, because it uses plugins and GitHub does not manage them. One example is the "imager" plugin.
You have to clone it to your machine, build your site and upload the built site to your domain.


allow cloud profiler to be used

a secure way to get profiling data while running on gcp
https://cloud.google.com/profiler/docs/profiling-go
if we decide to adopt cloud profiler across the board, we may consider ripping out pprof completely
we can use pprof, but we would have to register the pprof endpoints on the application port, as cloudrun only allows a single port.
we can block external traffic to /debug/pprof with cloud armor, and only access via the *.run.app host
both options would require enabling
pprof would still require

tunneling
curl endpoint with identity token

Fix issues?

sorry, ptal


Add support for Camel-2.x on WildFly-18

wildfly-18.0.1 => cxf-3.3.3
camel-2.24.2 => cxf-3.2.10
camel-2.24.3 => cxf-3.2.11
camel-2.25.0 => cxf-3.3.5

https://ci.fabric8.io/view/wildfly-camel/job/wildfly-camel-2.x/

Done

@tdiesler do you have any time estimation when a final version will be released with this change?

Sure, every milestone has a release date
https://github.com/wildfly-extras/wildfly-camel/milestone/37

great. so april fool time


Updating colors for the Help Site, add fine print to footer

cc @Expensify/design @maddylewis @caitlinwhite1 @strepanier03
Details
This updates a few colors for the help site:

I cleaned up the Sass vars to make it more readable
I used new color primitives that we just merged, nice!
I made the LHN links use our text-supporting color
I made most paragraph text use our text-supporting color
Fixed a few other inconsitencies

This also adds a fine print footer to the site as well.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/343710
Tests

[ ] Verify that no errors appear in the JS console

Offline tests

QA Steps

[ ] Browse the help site (help.expensify.com) and make sure the changes above are appearing

Screenshots/Videos

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Lovely updates!

I used new color primitives that we just merged, nice!

:chefkiss:

Just pulled main!

Oh amazing, thanks Stites!

🚀 Deployed to staging by https://github.com/stitesExpensify in version: 1.4.12-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
cancelled 🔪

🍎 iOS 🍎
cancelled 🔪

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/stitesExpensify in version: 1.4.12-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
cancelled 🔪

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/stitesExpensify in version: 1.4.12-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.12-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


[BUG] bindValue method is ignored

Prerequisites

[x] Able to reproduce the behaviour outside of your code, the problem is isolated to Laravel Excel.
[x] Checked that your issue isn't already filed.
[x] Checked if no PR was submitted that fixes this problem.

Versions

PHP version: 7.2.12-1+0~20181112102304.11+stretch~1.gbp55f215
Laravel version: 5.7.14
Package version: 3.1.3

Description
When you implement the WithCustomValueBinder interface, the bindValue method is not called
Steps to Reproduce

create a new laravel project with composer create-project laravel/laravel test
change into the directory with cd test
install the excel package with composer require maatwebsite/excel
create a test command with php artisan make:command TestCommand
put the following code in the handle method of the command

Excel::import(new TestImport(), 'test.xlsx');

create a test import with php artisan make:import TestImport
make sure the following code is placed in the file:

<?php

  namespace App\Imports;

  use Maatwebsite\Excel\Concerns\ToCollection;
  use PhpOffice\PhpSpreadsheet\Cell\Cell;
  use PhpOffice\PhpSpreadsheet\Cell\DataType;
  use Maatwebsite\Excel\Concerns\WithCustomValueBinder;
  use Maatwebsite\Excel\Concerns\ToModel;
  use PhpOffice\PhpSpreadsheet\Cell\DefaultValueBinder;

  class TestImport extends DefaultValueBinder implements WithCustomValueBinder, ToModel
  {
      public function bindValue(Cell $cell, $value)
      {
          var_dump('bind');
          die();
      }

      public function model(array $row)
      {
          var_dump('row');
          var_dump($row);
          die();
      }
  }

place a file called 'test.xlsx' in the 'storage/app' subdirectory of your project
call the command with php artisan command:name

Expected behavior:
The following text appears on the console:
string(3) "bind"

Actual behavior:
The following text appears on the console:
string(3) "row"
array(2) {
  [0]=>
  string(4) "test"
  [1]=>
  string(5) "value"
}

EDIT: I also made sure the laravel installation could access the database with some valid credentials, otherwise a MySQL related exception was thrown

Thanks for your extensive bug report @tostiheld , we'll be looking into this for a future release.

Good to know. How will we know when this is fixed, since you closed the issue already?

PhpSpreadsheet value binders are meant for exports. bindValue only get's called when using cell->setValue(). It's a wrong assumption in the current import docs.
See: https://phpspreadsheet.readthedocs.io/en/develop/topics/accessing-cells/#using-value-binders-to-facilitate-data-entry
As far as I know we don't do any data manipulation besides what PhpSpreadsheet already does out of the box.
Best is to transform the data in the model() method.

PhpSpreadsheet value binders are meant for exports. bindValue only get's called when using cell->setValue(). It's a wrong assumption in the current import docs.
See: https://phpspreadsheet.readthedocs.io/en/develop/topics/accessing-cells/#using-value-binders-to-facilitate-data-entry
As far as I know we don't do any data manipulation besides what PhpSpreadsheet already does out of the box.
Best is to transform the data in the model() method.

How about when data validation with Maatwebsite\Excel\Concerns\WithValidation is needed? I can't preprocess that in model method!


Resolving the confusion of “protocolIn”/“protocolOut” with a better parameter design

Relevant to Issue #13
The current “protocolIn”/“protocolOut” parameters are confusing. Considering the IP protocols:

TCP is a bi-directional protocol on the same socket pairs
UDP can be used uni-directional or bi-directional on the same socket pairs

It is a bit confusing to specify different protocols in the same IP flow for different directions.

@emil-cheung
I think "confusing" is the wrong term to use here. Rather, allowing the API consumer to separately specify protocolIn and protocolOut opens up the possibility that they could request an illogical configuration, such as protocolIn = TCP and protocolOut = UDP. To me, that is an error and the API should respond as such, but it would be better if this possibility was removed.
My preference would be to adopt the RFC 6733 convention of separately specifying Protocol and Direction (with the additional option of "both" as well as "in" and "out") for an IPFilterRule. The BIG issue with the current definitions is that there is no "NONE" option for the protocol. So if you want to watch 4K video and request THROUGHPUT_L on the downlink for this, the current API definition means you will also get THROUGHPUT_L on the uplink, which is an unnecessary expense. Specifying "Protocol" and "Direction" separately would allow the high throughput to be requested only for the downlink.
The other issue I have with both the current definition (protocolIn and protocolOut) and separately specifying Direction is that "in" and "out" might be considered ambiguous. I've spent my whole career thinking in terms of "uplink" and "downlink", whilst in North America they think in terms of "forward" and "reverse", but again these definitions might not be obvious to a developer. As we explicitly identify the "UE" and "AS", I'd suggest the Direction options should be "UEtoAS", "AStoUE" or "BOTH".

I propose that we use this issue to discuss the paramter design for "in" and "out" and closing the issue #35 which is from my perspective a duplicate.

@eric-murray I totally agree with your proposal to adopt RFC 6733 convention.

@eric-murray
The intention to name 'remoteAddr' is not due to UE calling the API.b
It is to generalize 'UE-to-AS' communication as well as 'UE-to-UE' (defined by 3GPP and may applicable to dedicated networks or private networks).

Update https://github.com/camaraproject/QualityOnDemand/pull/37/files with 'FROM_UE"/"TO_UE" accordingly.

See new issue #51 which preserves the proposed solution from #37


performance tests

Is there a plan to put some performance tests there? So that folks can benchmark JIT code quality, figure out the performance bottleneck and potentially optimize it.

Not in the near future. You can use cpp-ethereum to benchmark EVMJIT.


Suggestion about config options and some issues.

Hello.
Firstly, great thanks for your work. This mod is awesome!
Secondly, I have some suggestion about adding more config options. Now (in version <IP_ADDRESS>) in config file I can change energy production and energy usage. But I can't change:

capacity of energy cubes,
voltage (capacity) of energy cables,
flow rate of liquid cables
etc.

For example, I want to create modpack with Mekanism, TE4, Thermal Dynamics, Ender IO (etc). And I want all capacitors from different mods have the same capacity (for example, Resonant Energy Cell = Vibrant Capacitor = Ultimate Energy Cube) and all energy conduits have the same voltage (Resonant Fluxduct = Ender Energy Conduit = Ultimate Energy Cable). But now I can't change these values in Mekanism.
Thirdly, I have some issues:

I can place some blocks (parts of multi-block constructions, such as Induction Casing) into myself and get x-ray glitch.
Some blocks have wrong texture in inventory (such as Solar Neutron Activator).

P. S. Thank you for your work!
P. P. S. Sorry for my English. I'm from Russia.

Added all the suggested config properties :)
Also, the bugs you mentioned should be fixed for the next release.


Add section on running openshift-tests for test suites

Regarding TRT-245
View the rendered pages produced by CI so you can see what the changes will look like when merged.
TODO: retry the different combinations given that I figured out the --provider options and have a gcp credentials file (and can extract one from the cluster-bot cluster):

[x] conformance test on gcp cluster
[x] conformance test on aws cluster
[x] upgrade test on gcp cluster
[x] upgrade test on aws cluster
[x] ensure azure upgrade works

/test links

/test links

/test links

/retest-required

/retest

/assign @hongkailiu

/test links

/test links

/retest

/retest

/retest

/retest

/retest


divvunspell fails to find suggestions hfst-ospell does

It seems that hfst-ospell does a better job considering all possible
tokenisations of a word; divvunspell fails to offer some suggestions when they
are multiple tokenisations (due to multichar symbols).
After a lot of work, I derived this explanation by finding a minimal failing
example; I hope this effort helps with fixing the bug!
Script to reproduce (run in an empty directory):
echo -e "cat\nca\ncb\ncbt" > multichar
echo -e "cbt:cat\ncb:ca" > orth
echo '?*' | hfst-regexp2fst -o anystar.hfst
hfst-strings2fst -j -m multichar < orth \
| hfst-concatenate anystar.hfst - \
| hfst-concatenate - anystar.hfst \
| hfst-repeat -f 1 -t 3 \
| hfst-disjunct - anystar.hfst \
| hfst-fst2fst -w > errmodel.default.hfst
echo "cat" | hfst-strings2fst -j -m multichar | hfst-fst2fst -w > acceptor.default.hfst
cat > index.xml <<-EOF
<?xml version="1.0" encoding="utf-8"?>
<hfstspeller dtdversion="1.0" hfstversion="3">
    <info>
        <title>cat</title>
	<locale>xxx</locale>
	<producer>xxx</producer>
	<description>cat</description>
    </info>
    <acceptor type="general" id="acceptor.default.hfst">
        <title>cat</title>
	<description>cat</description>
    </acceptor>
    <errmodel id="errmodel.default.hfst">
        <title>error</title>
	<description>cat</description>
        <type type="default"/>
        <model>errmodel.default.hfst</model>
    </errmodel>
</hfstspeller>
EOF

zip test.zhfst index.xml errmodel.default.hfst acceptor.default.hfst
echo "cbt" | hfst-ospell -S test.zhfst
echo "cbt" | divvunspell -S -z test.zhfst

Output of the previous commands,
$ bash run
updating: index.xml (deflated 61%)
updating: errmodel.default.hfst (deflated 67%)
updating: acceptor.default.hfst (deflated 39%)
"cbt" is NOT in the lexicon:
Corrections for "cbt":
cat    0.000000

Reading from stdin...
Input: cbt		[INCORRECT]

There is no timeline on when this might be resolved. I have tested the behaviour with both a ZHFST and BHFST file and there is no difference (which is good).

Sorry, I want to clarify: you were able to reproduce the bug, and behavior is
the same between .zhfst and .bhfst files?
Or you were unable to reproduce the bug at all?
If the former, would you be willing to outline where in the code I should look?
I can try to come up with a patch.

I can reproduce the bug, but I have absolutely no suggestion as to where the issue might be coming from or how you might go about debugging it, sorry.

as far as I can tell divvunspell uses characters (or grapheme clusters in newest versions) and does no multichar tokenisation, at least for the input. I think this is probably the right way to go, surface levels of finite-state morphologies shouldn't contain arbitrary multicharacter sequences, it's more often causing hard to debug bugs than is useful.

I agree with @flammie: multichars should be all and only characters/grapheme clusters, and divvunspell should do no multichar tokenisation. This will make error modelling and debugging much easier. What needs to be ensured is that grapheme clusters are always defined as multichars in the fst's, I am not sure that is always the case.
For the acceptor, this is already being handled automatically (especially since the tokeniser fst's have the opposite requirement - no multichars at all on the surface level). So the part to investigate is the error model.


React forms

Events for React forms and input fields are not auto-completing. There is a work around:
  const updateInputValue = (input, newValue) => {
  let lastValue = input.value;
  input.value = newValue;
  let event = new Event("input", { bubbles: true });
  let tracker = input._valueTracker;
  if (tracker) {
    tracker.setValue(lastValue);
  }
  input.dispatchEvent(event);
};

This is a bit more complicated to implement because the copy of the DOM in a content script doesn't have the _valueTracker attrinute that is attached. We'll have to keep track of those in the page scripts and then from the content script request that method be called when we add text to the value.


Update dependency from javax to jakarta

reference: https://mvnrepository.com/artifact/javax.annotation/javax.annotation-api

@ronmamo can you kindly review this and consider a new release of this library with the update?


Update cherami-thrift to get the latest

Coverage decreased (-0.1%) to 54.374% when pulling 456f774a9987a69bdbf48f6312571d57cbde864c on update_thrift into 9c0860b7e9fbe334ab010455e49aeb537e4dc3dd on master.


Display the dimensions of the iframe on resize

I think it would be very useful to display the dimensions of the iframe when it gets resized similarly to the functionality of browsers when you have dev tools open.
This is a feature I wish I could have every time I use storybooks, which is just about every day on the project I'm currently working on(thanks a lot for the awesome product!).
For the reason above, I added the functionality and opened a PR for it here  https://github.com/storybooks/storybook-ui/pull/70
I'd love feedback on the addition and would love to work with you all to get it to the point that it can be merged in!

Closed via #70
Thanks for the contribution @ijsnow


#109 Add CS Fixer to Travis

This is untested. OTOH, Travis output doesn't appear on GitHub anyways and can be ignored, so we could move forward with this and see how it behaves.

Please don't merge this yet, it seems completely broken currently due to some file permissions issue.

Wir werden es herausfinden :wink:


Use VPN only for certain domains/hostnames

it is possible to set up by client?

What you are requesting is something we call selective proxying. We are tracking this request in #887.


message_list: Live update trailing bookend on stream deactivation.

We were not updating the trailing bookend on deactivation of stream
if the user was narrowed to deactivated stream and this commit fixes
this.
For subscribed streams, we just show the trailing bookend with
content as 'This stream has been deactivated' and hide the
Unsubscribe button.
For unsubscribed streams, we change the content of trailing bookend
to 'This stream has been deactivated' and hide the Subscribe button.
Fixes #15999.

Testing Plan:  Tested manually in the development environment.
GIFs or Screenshots:

This is great, merged, thanks @sahil839!  I think there's nothing to do for that corner case.


poly-decomp API has changed

Looks like poly-decomp API changed slightly in the newest version
Trying to instantiate a Polygon body from concave vertices results in an error: decomp.Polygon is not a constructor
As a workaround it's possible to use the old version: https://github.com/schteppe/poly-decomp.js/commit/4558762effada60404c10c46d1d995c9512d87f5

Thanks for the heads up!


Automate generating framework endpoints

This PR seeks to make adding new triggers to vulnpy easier by automating each framework's view generation.
This is certainly not final and can use more work later on, but this is a good stopping point. I also did consider deduping some of the inter-framework code similarities, but I decided against it right now. A class could help, but I think that would add more complexity than it merits. Right now each framework does its own tiny different thing in its own file - let's not make it more complicated for now.

@lazorchakp I was successfully able to automate TRIGGER_MAP! one less step to do when adding a new trigger!


CB Error: Connection error.

I have attached script which is used to get messaging service from ClearBlade,  when I try to establish the connection the following error occurs. May I know what the source of this error is?
We have a portal that is build with react and its seems the below URL is working fine and it accepting the request and logging successfully but when I try to connect the same URL using  Python-SDK.
Error
CB Error: Connection error. Check that https://platform.iotright.com/api/v/1/user/auth is up and accepting requests.
from snapconnect import snap
from clearblade.ClearBladeCore import System, Query
import time
from clearblade.ClearBladeCore import cbLogs
global comm
from decouple import config
#"/x1B/xE4/xA7" --> SynapseBrick

dim_level = 0

cbLogs.DEBUG = False
cbLogs.MQTT_DEBUG = False

SystemKey = config('SYSTEMKEY')
SystemSecret = config('SYSTEMSECRET')

url = config('URL')

mySystem = System(SystemKey, SystemSecret, url)

cbUser = mySystem.User(config('CB_USERNAME'), config('CB_PASSWORD'))

mqtt = mySystem.Messaging(cbUser)

def on_connect(client, userdata, flags, rc):
    print("Connected with result code "+str(rc))

    client.subscribe("/lighting/nodes/#")

def on_message(client, userdata, msg):
    print(msg.topic+" "+str(msg.payload))
    nodeAddr = str(msg.payload.decode('utf-8'))
    print(nodeAddr)
    comm.rpc("/x1B/xE4/xA7", "get_dim_level")
    print("msg published")

def on_disconnect(client, userdata, rc):
    print("client disconnected mqtt; attempting reconnection")
    client.reconnect()

def rpcSuccess(obj):
    global responseFlag
    print('rpc success')

def get_dim(level):
    global dim_level
    dim_level = level
    print("dim level ",dim_level)

mqtt.on_connect = on_connect
mqtt.on_message = on_message
mqtt.on_disconnect = on_disconnect

comm = snap.Snap(funcs={'get_dim':get_dim, 'rpcSuccess':rpcSuccess})
# comm.rpc("/x1B/xE4/xA7", "test")
comm.open_serial(1,'/dev/snap0')

mqtt.connect()

print('MQTT connected')

while(True):
    time.sleep(1)

I have tried with this URL https://platform.iotright.com/api/v/1/user/auth as you mentioned, and facing the same issue?

@iamjai-dev You must be connecting as a user, do you know if your user has the right permissions for the message topic you are subscribing to? I tried to work with another system on the same instance (platform.iotright.com) and I am not able to replicate it. If the problem persists let me know. We can potentially schedule a call.

@yashjain28 Ya the user I am connecting with has a role admin. But the problem persists, let me know when you are free we can schedule a call. Thanks.

I can talk now or we can schedule a call for 11:30 am central time tomorrow. If you can confirm, share your work email so that I'll share a zoom link.

@yashjain28,  For your information I have solved the issue by using the Paho-MQTT client library and it's connecting to ClearBlade now without any issue.


Lemma 7.4.2, adjointCarleson_adjoint, BoundedCompactSupport

As discussed yesterday, open for further discussion

BoundedCompactSupport now uses Memℒp f ⊤ as discussed

This looks great! Thanks!


Rio up don't deploy anything (github repo)

Describe the bug
Hello,
Today we try to deploy a Riofile from github(https://github.com/live-translate/rio-demo) with rio up command =>
rio -n cd-demo up https://github.com/live-translate/rio-demo
On rio dashboard, we can see Watcher & Commit. But nohting is deploy.
We launch logs command and found this :
rio-controller | E0516 21:00:07.303740 1 controller.go:135] error syncing 'default/tools': handler stack-service-build: failed to create default/default-tools-stack-011cb-1eabf tekton.dev/v1alpha1, Kind=TaskRun for stack-service-build default/tools: admission webhook "webhook.tekton.dev" denied the request: mutation failed: cannot decode incoming new object: json: unknown field "managedFields", requeuing

To Reproduce

launch this command

rio -n cd-demo up https://github.com/live-translate/rio-demo

Expected behavior
The stack is build & deploy.
Kubernetes version & type (GKE, on-prem): kubectl version
Client Version: version.Info{Major:"1", Minor:"16+", GitVersion:"v1.16.6-beta.0", GitCommit:"e7f962ba86f4ce7033828210ca3556393c377bcc", GitTreeState:"clean", BuildDate:"2020-01-15T08:26:26Z", GoVersion:"go1.13.5", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.2", GitCommit:"52c56ce7a8272c798dbc29846288d7cd9fbae032", GitTreeState:"clean", BuildDate:"2020-04-16T11:48:36Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}

Type:
Rio version: rio info
Rio Version: v0.7.0 (4afd4901)
Rio CLI Version: v0.7.0 (4afd4901)
Cluster Domain: xxxxx..on-rio.io
Cluster Domain IPs: xx.xxx.xxx.xxx
System Namespace: rio-system
Wildcard certificates: xxxxx.on-rio.io(true)

Additional context
rio system logs
output:
rio-controller | E0516 20:58:45.236998       1 controller.go:135] error syncing 'default/tools': handler stack-service-build: failed to create default/default-tools-stack-011cb-1eabf tekton.dev/v1alpha1, Kind=TaskRun for stack-service-build default/tools: admission webhook "webhook.tekton.dev" denied the request: mutation failed: cannot decode incoming new object: json: unknown field "managedFields", requeuing
rio-controller | E0516 20:58:45.257294       1 controller.go:135] error syncing 'default/tools': handler stack-service-build: failed to create default/default-tools-stack-011cb-1eabf tekton.dev/v1alpha1, Kind=TaskRun for stack-service-build default/tools: admission webhook "webhook.tekton.dev" denied the request: mutation failed: cannot decode incoming new object: json: unknown field "managedFields", requeuing
rio-controller | E0516 20:58:45.287595       1 controller.go:135] error syncing 'default/tools': handler stack-service-build: failed to create default/default-tools-stack-011cb-1eabf tekton.dev/v1alpha1, Kind=TaskRun for stack-service-build default/tools: admission webhook "webhook.tekton.dev" denied the request: mutation failed: cannot decode incoming new object: json: unknown field "managedFields", requeuing
rio-controller | E0516 20:58:45.338310       1 controller.go:135] error syncing 'default/tools': handler stack-service-build: failed to create default/default-tools-stack-011cb-1eabf tekton.dev/v1alpha1, Kind=TaskRun for stack-service-build default/tools: admission webhook "webhook.tekton.dev" denied the request: mutation failed: cannot decode incoming new object: json: unknown field "managedFields", requeuing
rio-controller | E0516 20:58:45.429495       1 controller.go:135] error syncing 'default/tools': handler stack-service-build: failed to create default/default-tools-stack-011cb-1eabf tekton.dev/v1alpha1, Kind=TaskRun for stack-service-build default/tools: admission webhook "webhook.tekton.dev" denied the request: mutation failed: cannot decode incoming new object: json: unknown field "managedFields", requeuing
rio-controller | E0516 20:58:45.604618       1 controller.go:135] error syncing 'default/tools': handler stack-service-build: failed to create default/default-tools-stack-011cb-1eabf tekton.dev/v1alpha1, Kind=TaskRun for stack-service-build default/tools: admission webhook "webhook.tekton.dev" denied the request: mutation failed: cannot decode incoming new object: json: unknown field "managedFields", requeuing
rio-controller | E0516 20:58:45.934623       1 controller.go:135] error syncing 'default/tools': handler stack-service-build: failed to create default/default-tools-stack-011cb-1eabf tekton.dev/v1alpha1, Kind=TaskRun for stack-service-build default/tools: admission webhook "webhook.tekton.dev" denied the request: mutation failed: cannot decode incoming new object: json: unknown field "managedFields", requeuing
rio-controller | E0516 20:58:46.584908       1 controller.go:135] error syncing 'default/tools': handler stack-service-build: failed to create default/default-tools-stack-011cb-1eabf tekton.dev/v1alpha1, Kind=TaskRun for stack-service-build default/tools: admission webhook "webhook.tekton.dev" denied the request: mutation failed: cannot decode incoming new object: json: unknown field "managedFields", requeuing
rio-controller | E0516 20:58:47.874076       1 controller.go:135] error syncing 'default/tools': handler stack-service-build: failed to create default/default-tools-stack-011cb-1eabf tekton.dev/v1alpha1, Kind=TaskRun for stack-service-build default/tools: admission webhook "webhook.tekton.dev" denied the request: mutation failed: cannot decode incoming new object: json: unknown field "managedFields", requeuing
rio-controller | E0516 20:58:50.443671       1 controller.go:135] error syncing 'default/tools': handler stack-service-build: failed to create default/default-tools-stack-011cb-1eabf tekton.dev/v1alpha1, Kind=TaskRun for stack-service-build default/tools: admission webhook "webhook.tekton.dev" denied the request: mutation failed: cannot decode incoming new object: json: unknown field "managedFields", requeuing
rio-controller | E0516 20:58:55.574404       1 controller.go:135] error syncing 'default/tools': handler stack-service-build: failed to create default/default-tools-stack-011cb-1eabf tekton.dev/v1alpha1, Kind=TaskRun for stack-service-build default/tools: admission webhook "webhook.tekton.dev" denied the request: mutation failed: cannot decode incoming new object: json: unknown field "managedFields", requeuing
rio-controller | E0516 20:59:05.824721       1 controller.go:135] error syncing 'default/tools': handler stack-service-build: failed to create default/default-tools-stack-011cb-1eabf tekton.dev/v1alpha1, Kind=TaskRun for stack-service-build default/tools: admission webhook "webhook.tekton.dev" denied the request: mutation failed: cannot decode incoming new object: json: unknown field "managedFields", requeuing
rio-controller | E0516 20:59:26.329795       1 controller.go:135] error syncing 'default/tools': handler stack-service-build: failed to create default/default-tools-stack-011cb-1eabf tekton.dev/v1alpha1, Kind=TaskRun for stack-service-build default/tools: admission webhook "webhook.tekton.dev" denied the request: mutation failed: cannot decode incoming new object: json: unknown field "managedFields", requeuing
rio-controller | E0516 21:00:07.303740       1 controller.go:135] error syncing 'default/tools': handler stack-service-build: failed to create default/default-tools-stack-011cb-1eabf tekton.dev/v1alpha1, Kind=TaskRun for stack-service-build default/tools: admission webhook "webhook.tekton.dev" denied the request: mutation failed: cannot decode incoming new object: json: unknown field "managedFields", requeuing
rio-controller | E0516 21:01:29.237971       1 controller.go:135] error syncing 'default/tools': handler stack-service-build: failed to create default/default-tools-stack-011cb-1eabf tekton.dev/v1alpha1, Kind=TaskRun for stack-service-build default/tools: admission webhook "webhook.tekton.dev" denied the request: mutation failed: cannot decode incoming new object: json: unknown field "managedFields", requeuing

@Hantse A good chance that rio doesn't work with k8s 1.18. Thanks for reporting this, I will fix it in the next release.

Ok, thank you for your feedback !
You have an idea about the next release date ?
It's simple to upgrade rio ? (rio upgrade ?)
Kind regards,

Within a month. To upgrade rio, you just need to download the latest binary and rerun rio install.


Minor updates to pyfixest functionality

Hi @matteocourthoud, thanks for this truly awesome resource! I have slightly updated pyfixest's description - it by now no longer depends on pyhdfe, and I have implemented some methods for DiD estimation with staggered adaption. I've also fixed one typo =) Best, Alex

Amazing! Thanks a lot Alex, and great job with pyfixest!


About prompt generation

When adding the sd_lora shortcut interface in WEBUI, the prompt creation is strange.

my txt2img setting
"prompt": "4k.best quality, ultra high res, (realism by Gustave Courbet:0.7), photo-realistic,lora:more_details:0.3",
"negative_prompt": "deepnegative,deformity,blurry,paintings, sketches, (low quality, worst quality, normal quality:1.5), ((monochrome)), ((grayscale)),",
Chat message: 1girl
Generated prompt

4k.best quality, ultra high res, (realism by Gustave Courbet:0.7), photo-realistic,<lora:more_details:0.3>, 1girl<lora:prettymg2:1.0><lora:prettymg2:1.0>

The lora tag appears twice, as shown above. Additionally, the lora tag is displayed without a separator before it.

Fixed the separator.
In my environment, the tag appears twice did not occur.
What version are you using?

I'm using latest version.

This should also be the latest version, but it did not occur.
I'll try to fix it if the same thing happens.


sys/netbsd: adding ipc and system management syscalls

Syscalls added:
Manual: msgctl
compat_14_msgctl
compat_50___msgctl13
Manual: semctl
compat_14___semctl
compat_50_____semctl13
____semctl50
Manual: shmctl
compat_14_shmctl
compat_50___shmctl13
rasctl: manual
swapctl: manual
modctl: manual

Hi @ais2397. So far no one with NetBSD expertise has reacted. Overall your PR looks fine to me, is it in a ready-to-be-merged state?

Hi @ais2397. So far no one with NetBSD expertise has reacted. Overall your PR looks fine to me, is it in a ready-to-be-merged state?

Yes

Great, then I'm finally merging this :)


Tensorflow Dataset API continues to be broken, list_files no longer works

Issue type
Bug
Have you reproduced the bug with TensorFlow Nightly?
No
Source
pip
TensorFlow version
tf v2.17.0-rc1-2-gad6d8cc177d
Custom code
Yes
OS platform and distribution
Linux Ubuntu
Mobile device
No response
Python version
3.11.9
Bazel version
No response
GCC/compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current behavior?
list_files from Tensorflow Dataset API is now broken in TF 2.17. I cannot follow the example located here: https://www.tensorflow.org/guide/data#consuming_sets_of_files
After the issues where employing TFRecords and using generators blows up memory, now list_files won't even work. I've attached code that will list the appropriate files using both pathlib and glob libraries. Both return lists.
What on earth is going on here.
Standalone code to reproduce the issue
#!/usr/bin/env python3
import os ; import sys
from pathlib import Path
import glob

import tensorflow as tf

output_path = Path('test_text')
if not output_path.exists(): output_path.mkdir(parents=True)

num_files = 10
write_out_string = 'abcdef'
for fnum in range(num_files):
    output_file = output_path / f'sample_{fnum:03d}.txt'
    with open(output_file, 'w') as f:
        f.write(write_out_string)

# First, try with Python's pathlib glob, make sure it can see the files
print("With pathlib.")
print(list(output_path.glob('*txt')))
print()

# Next, try to with Python's glob
print("With glob")
glob_path = output_path / '*txt'
print(list(glob.glob(str(glob_path))))

list_ds = tf.data.Dataset.list_files(str(glob_path))

for bf in list_ds.take(5):
    print(bf.numpy())

Relevant log output
With pathlib.
[PosixPath('test_text/sample_009.txt'), PosixPath('test_text/sample_007.txt'), PosixPath('test_text/sample_000.txt'), PosixPath('test_text/sample_006.txt'), PosixPath('test_text/sample_004.txt'), PosixPath('test_text/sample_008.txt'), PosixPath('test_text/sample_005.txt'), PosixPath('test_text/sample_002.txt'), PosixPath('test_text/sample_001.txt'), PosixPath('test_text/sample_003.txt')]

With glob
['test_text/sample_009.txt', 'test_text/sample_007.txt', 'test_text/sample_000.txt', 'test_text/sample_006.txt', 'test_text/sample_004.txt', 'test_text/sample_008.txt', 'test_text/sample_005.txt', 'test_text/sample_002.txt', 'test_text/sample_001.txt', 'test_text/sample_003.txt']
2024-07-15 15:39:17.545697: I tensorflow/core/common_runtime/gpu/gpu_device.cc:2021] Created device /job:localhost/replica:0/task:0/device:GPU:0 with 46673 MB memory:  -> device: 0, name: NVIDIA RTX 6000 Ada Generation, pci bus id: 0000:16:00.0, compute capability: 8.9

Traceback (most recent call last):
  File "/home/dryglicki/code/list_files/demonstrate_list_files.py", line 28, in <module>
    list_ds = tf.data.Dataset.list_files(str(glob_path))
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ssd0/miniforge3_2024-04/envs/tensorflow_2d17/lib/python3.11/site-packages/tensorflow/python/data/ops/dataset_ops.py", line 1318, in list_files
    string_ops.reduce_join(file_pattern, separator=", "), name="message")
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ssd0/miniforge3_2024-04/envs/tensorflow_2d17/lib/python3.11/site-packages/tensorflow/python/util/traceback_utils.py", line 153, in error_handler
    raise e.with_traceback(filtered_tb) from None
  File "/ssd0/miniforge3_2024-04/envs/tensorflow_2d17/lib/python3.11/site-packages/tensorflow/python/framework/constant_op.py", line 108, in convert_to_eager_tensor
    return ops.EagerTensor(value, ctx.device_name, dtype)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: object __array__ method not producing an array

For what it's worth, pre-globbing and using from_tensor_slices does allow for one to iterate through the filenames.
But if list_files is indeed deprecated, somebody say so!

Another issue. This will also fail if TFRecordDataset is in the chain. If I need to open a separate ticket or issue or post more code, please let me know. But the TFRecordDataset issue appears both when wrapped by interleave or when pre-globbing and using those file names in TFRecordDataset directly.

@dryglicki,
I tried to execute both the official document code and mentioned code with latest tensorflow stable version 2.17.0, observed that both are executed without fail/error. Kindly find the gist of both and update if the understanding is correct.
Official doc and code
Thank you!

All right, I can confirm if I use 3.10.14 and force pip install tensorflow[and-cuda]==2.17.0 I can get it to work.

All right, found the source of the problem. It's dependency collision.
matplotlib installed via conda brings numpy 2.0 which runs over the numpy 1.X version installed via pip for tensorflow.


Makes tickets stored in MongoDb expire automatically

Makes tickets stored in MongoDb expire automatically by setting the expireAt field to be a date type.
Previously it was being set to the ticket's TTL so the Mongo index for auto-deletion had no effect.
This change assumes that the CAS and Mongo server dates are in sync.  If they are not, tickets may be deleted from MongoDb earlier than expected (solution would seem to be to set ticket.getProperties().getStorageTimeout() appropriately).
Closes #2748

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Please correct your statement on why not get_it :-)

with watch_it there is a reactive extenstion to get_it for quite a while now.

you missed, that for some years there were the get_it_mixin around and since last August there is the watch_it package that is the companion package for get_it.

I'm aware of watch_it, but watch_it only provides Widget/UI reactivity, not inter-state reactivity. I.e., in the overused count example, I couldn't have a Count class registered with get_it, and then have a CountPlusOne class who's state watches that of Count (without Streams, ValueNotifiers, etc. which have their own problems that prevent correct composition across states).

What is the problem using a Stream or Valuelistenable? why mixing state management with business logic?

In addition to the items mentioned here (under "why not rx and streams"), there is also a big issue w.r.t. composition, see page 14 here.

why mixing state management with business logic?

Business logic can be stateful--what happens when you want to fetch the current signed in user's posts in a social media application? In this situation, and virtually every other regarding how to build some piece of software, it is easiest to model the problem exactly as described via its underlying data and that data's requirements:

have a state of current signed in user
have a state that uses the current signed in user to grab the posts of that current user

Now if you want to discuss local/ephemeral state, you may use an individual ValueNotifier for just a singular state. But that also isn't as easy to set up as a one line:
final (state, setState) = use.state(); // or useState(); if you are using hooks

One main difference ReArch brings to the table here is that you may use this same "effects" API (use.state above, but there are dozens of others) to write both widgets and your global state/business logic to create cohesion across your app.

hmm, thanks for your Thesis, will check it out

have a state that uses the current signed in user to grab the posts of that current user
why whould a state grab any data? I'm not sure that this makes it easier to understand what is going on in your app.

I'm working for over a year on a fairly big social media app and we didn't face any of your listed problems. However we use flutter_commands in addition to watch_it as the reactive link for our business logic.

why whould a state grab any data? I'm not sure that this makes it easier to understand what is going on in your app.

Because it enables declarative code, which in turn enables automatically reactive code. This particular social app example could look something like:
/// Represents the current signed in user.
User currentUserCapsule(CapsuleHandle use) => throw 'impl hidden';

/// Fetches a user's posts via REST API.
Future<List<Post>> Function(User user) fetchUserPostsAction(CapsuleHandle use) => throw 'impl hidden';

/// Represents the posts of the current signed in user.
Future<List<Post>> currentUserPostsCapsule(CapsuleHandle use) {
  final user = use(currentUserCapsule);
  return use(fetchUserPostsAction)(user);
}

The currentUserPostsCapsule is a simple composition of the two other pieces of state/logic, all while remaining highly testable and completely satisfying many well known design principles/patterns like SOLID (for free due to the nature of ReArch's design).
There are other ways to achieve this exact kind of behavior, but I'd argue they aren't as simple as just modeling your app in terms of data flow (which, at the end of the day, is all any application is--just one big data in and out machine).

However we use flutter_commands in addition to watch_it as the reactive link for our business logic.

Had to look up flutter_command since I haven't heard of it before--based on what I'm reading you might really like ReArch haha

A Command is an object that wraps a function that can be executed by calling the command, therefore decoupling your UI from the wrapped function.

In ReArch, you don't need any layers of indirection like this since capsules provide dependency inversion over any functions they contain too. In our example above, all a widget has to do is use(fetchUserPostsAction) and they get their own copy of the function that they can call with any user that might be local/ephemeral state.

Definitely will look into it.
How is your view on the currently hyped Signals packages?
Am 15. Apr. 2024, 17:25 +0200 schrieb Gregory Conrad @.***>:

why whould a state grab any data? I'm not sure that this makes it easier to understand what is going on in your app.
Because it enables declarative code, which in turn enables automatically reactive code. This particular social app example could look something like:
/// Represents the current signed in user.
User currentUserCapsule(CapsuleHandle use) => throw 'impl hidden';

/// Fetches a user's posts via REST API.
Future<List> Function(User user) fetchUserPostsAction(CapsuleHandle use) => throw 'impl hidden';
/// Represents the posts of the current signed in user.
Future<List> currentUserPostsCapsule(CapsuleHandle use) {
final user = use(currentUserCapsule);
return use(fetchUserPostsAction)(user);
}
The currentUserPostsCapsule is a simple composition of the two other pieces of state/logic, all while remaining highly testable and completely satisfying many well known design principles/patterns like SOLID (for free due to the nature of ReArch's design).
There are other ways to achieve this exact kind of behavior, but I'd argue they aren't as simple as just modeling your app in terms of data flow (which, at the end of the day, is all any application is--just one big data in and out machine).

However we use flutter_commands in addition to watch_it as the reactive link for our business logic.
Had to look up flutter_command since I haven't heard of it before--based on what I'm reading you might really like ReArch haha
A Command is an object that wraps a function that can be executed by calling the command, therefore decoupling your UI from the wrapped function.
In ReArch, you don't need any layers of indirection like this since capsules provide dependency inversion over any functions they contain too. In our example above, all a widget has to do is use(fetchUserPostsAction) and they get their own copy of the function that they can call with any user that might be local/ephemeral state.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

How is your view on the currently hyped Signals packages?

Funny you mention that; I actually just added a section to the README on that after the question arose a day or two ago in #137.
https://github.com/GregoryConrad/rearch-dart#why-not-signals
Copy pasted for easy reference:
Why not Signals?
Signals only constitute a subset of ReArch's functionality.
If you took ReArch and removed:

Containers, instead opting for global singletons
The builtin side effects, instead opting for only a few hard-coded types of signals
Side effect composition
The ability for capsules to define their own API for interactions, instead allowing only .value

To explain this a bit more: what if you want custom state validation logic alongside your state?

Then you'd arrive at ReArch.
So, if you like Signals, you'll likely love ReArch,
because you'll get all of the benefits of Signals
but with many more features (mostly due to ReArch's side effects model).
The only main difference is in the API,
but that is easy enough to adjust to--signals and capsules tend to map one-to-one.

OK, I spend some time trying to understand the whole concept and honestly I find the code with capsules etc very hard to read. I'm pretty sure when writing it it might be different but compared with a combination of watch_it with flutter_commands it feels way harder to understand what is going on in the code.
Maybe coming from Rust that might be different, but I'm not sure that it makes live for Flutter developers really easier.
I think I can understand the motivation behind it but IMHO using proper OO design helps a lot to document what your app is doing even if it will take a lot more code to write.
Curious how much traction you will get with that package.

I find the code with capsules etc very hard to read.
I felt the same (coming from Riverpod), but after a time adapting mentally it's just pretty. A part of all the benefits that his creator mention, personally, from my experience I would highlight the speed of writing/refactoring code it brings. And once you adapt to it I would say it's easier (I only know Riverpod).

Example:
Future<Ret<String, dynamic>> authTokenCapsule(CapsuleHandle use) async {
  // TODO: check if it is close to expire

  // TODO: schedule expire handler and delete it

  final config = use(appConfigCapsule);
  final configSetter = use(appConfigSetterCapsule);

  final authToken = config.authToken;

  if (authToken != null) return Ret.success(value: authToken);

  final username = ConsoleUtilsV2.readValue('API username: ');
  final password = ConsoleUtilsV2.readPassword('API password: ');

  final res =
      (await use(backendApiLoginCapsule).login(username, password)).logFailed();

  if (res.failed) throw (res.errMessage!);

  final newAuthToken = res.value!;

  final newConfig = config.copyWith(authToken: newAuthToken);

  newConfig.saveToFile();

  configSetter(newConfig);

  return Ret.success(value: newAuthToken);
}

Dio _authHttpClientCapsule(CapsuleHandle use) {
  return Dio(
    BaseOptions(
      validateStatus: (status) => switch (status) {
        200 => true,
        401 => true,
        _ => false,
      },
    ),
  );
}

BackendApiLoginController backendApiLoginCapsule(CapsuleHandle use) {
  final httpClient = use(_authHttpClientCapsule);

  return BackendApiLoginController(login: (username, password) async {
    final res = await handleResponse(httpClient.post(loginApiUrl, data: {
      'username': username,
      'password': password,
    }));

    if (res.success) {
      return Ret.success(value: res.response.data as String);
    }

    return Ret.error('Status code: ${res.statusCode}');
  });
}

class BackendApiLoginController {
  final Future<Ret<String, dynamic>> Function(String, String) login;

  BackendApiLoginController({
    required this.login,
  });
}

I guess that is my main pain point. Dart isn't a first class functional language which leads to not optimal syntax if you try to use it purely functional. f# is an amazing example how good FP code can look like.
I'm an OOP guy and still think its a pretty good paradigm especially for full applications.
On the server I think FP is a better fit.

Fair enough. If you like OOP and want to stick to that exclusively in your apps, then ReArch isn’t for you. I used to love OOP some years ago, but got increasingly frustrated with it as time went on. I could never make things exactly like I envisioned them.
as far as the functional aspects, I tried to make ReArch not too reliant on anything FP-specific to the point where it wouldn’t fit in Dart, and I’d say ReArch achieves that. There are things like AsyncValue, but that’s no sin in my book since Flutter itself has an AsyncSnapshot and Riverpod also has a similar AsyncValue.
I do hear what you’re saying about using functional approaches in an OOP language, but I don’t think ReArch goes too far down that rabbit hole unlike some other Dart/JS libraries I’ve seen.


build: Declare GO in makefile before first use

This is to avoid the below warning as $(GO) is not defined before calling GOARCH= $(GO) env GOARCH.
$ make
env: ‘GOARCH’: No such file or directory
contrib/scripts/check-logging-subsys-field.sh
contrib/scripts/check-fmt.sh
...

/test

/test


Set up formatting in build system

It would be nice to be able to format all of the source and header files in the project with a single command. Maybe integrate it with Meson in some way, or use GitHub actions?

There's now a script in the root of the repo called format.py which will format all of the source and header files using clang-format. The issue with that is that it needs to be kept up to date with all of the new source and header files that get created.
It really should be integrated with the build system at some point, but I'm not really sure how I would go about doing that using Meson.

All done! Just remember to add any new source or header files to the build.meson file.


Warning should be ERROR - Incorrect phase-encoding direction, assuming PA (posterior-to-anterior)

When running "fieldmapless" we get this message Incorrect phase-encoding direction, assuming PA (posterior-to-anterior) when the phase encoding direction is not specified.
Although fieldmapless runs without knowledge of the polarity, applying estimation on the wrong axis (when assuming AP/PA) could be extremely problematic.
This warning, IMHO, should be an error.
This affects the 20.2.x series and will likely become irrelevant with the integration of SDCFlows 2.0 (the new API makes the phase encoding direction a required parameter).

This has been done 21.0. I would vote for keeping the behavior as-is for 20.2.

Sounds reasonable.


Increment rtx rtp packet sequence number only when trasmitted

Fix for wrong sequence numbers
Currently the nack responder (responder_interceptor.go) generates RTX RTP packet which has not right sequence numbers. It does not increment the sequence number by one according to RFC rfc4588

For either multiplexing scheme, the sequence number has the standard definition; i.e., it MUST be one higher than the sequence number of the preceding packet sent in the retransmission stream.

I am proposing fix for it and appreciate any feedback as this is my first pull request in GO lang.

Nice find @oto313! How did you find this, I am really impressed! If you run go test -v locally you have some build/test failures.

Maybe we make this part of Get? Auto-increments (if needed)
We should write some tests that it does the auto increment as expected

Hi @Sean-Der. Thanks. I was investigating why retransmission not worked in my use case and I was investigating it with wireshark and I compared retransmission packets with google webrtc implementation.

If you run go test -v locally you have some build/test failures.
Sorry the build/tests are fixed

Maybe we make this part of Get? Auto-increments (if needed)
part of which Get?


ImportError: /home/xu/mmdetection/mmdet/ops/dcn/deform_conv_cuda.cpython-37m-x86_64-linux-gnu.so: undefined symbol: cudaSetupArgument

Checklist

I have searched related issues but cannot get the expected help.

Describe the bug
Bug occurs when I test the demo.py.
ImportError: /home/xu/mmdetection/mmdet/ops/dcn/deform_conv_cuda.cpython-37m-x86_64-linux-gnu.so: undefined symbol: cudaSetupArgument
Reproduction

What command or script did you run?

from mmdet.apis import init_detector

Did you make any modifications on the code or config? Did you understand what you have modified?

NO

Environment

OS: [Ubuntu 16.04]
GCC [5.4.0]
PyTorch version [1.3.0]
How you installed PyTorch [conda install torch]
GPU model [GTX 1080Ti]
CUDA and CUDNN version [CUDA Version 9.0.176]

Error traceback
from mmdet.apis import init_detector
Traceback (most recent call last):
  File "<input>", line 1, in <module>
  File "/home/xuhuanhua/mmdetection/mmdet/apis/__init__.py", line 2, in <module>
    from .inference import (inference_detector, init_detector, show_result,
  File "/home/xuhuanhua/mmdetection/mmdet/apis/inference.py", line 11, in <module>
    from mmdet.core import get_classes
  File "/home/xuhuanhua/mmdetection/mmdet/core/__init__.py", line 6, in <module>
    from .post_processing import *  # noqa: F401, F403
  File "/home/xuhuanhua/mmdetection/mmdet/core/post_processing/__init__.py", line 1, in <module>
    from .bbox_nms import multiclass_nms
  File "/home/xuhuanhua/mmdetection/mmdet/core/post_processing/bbox_nms.py", line 3, in <module>
    from mmdet.ops.nms import nms_wrapper
  File "/home/xuhuanhua/mmdetection/mmdet/ops/__init__.py", line 2, in <module>
    from .dcn import (DeformConv, DeformConvPack, DeformRoIPooling,
  File "/home/xuhuanhua/mmdetection/mmdet/ops/dcn/__init__.py", line 1, in <module>
    from .deform_conv import (DeformConv, DeformConvPack, ModulatedDeformConv,
  File "/home/xuhuanhua/mmdetection/mmdet/ops/dcn/deform_conv.py", line 9, in <module>
    from . import deform_conv_cuda
ImportError: /home/xuhuanhua/mmdetection/mmdet/ops/dcn/deform_conv_cuda.cpython-37m-x86_64-linux-gnu.so: undefined symbol: cudaSetupArgument

Bug fix

I try to use PyTorch version [1.2.0](pip install) based on some recommendations in #1554 .
Ner Error traceback
>>> from mmdet.apis import init_detector
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/xuhuanhua/mmdetection/mmdet/apis/__init__.py", line 2, in <module>
    from .inference import (inference_detector, init_detector, show_result,
  File "/home/xuhuanhua/mmdetection/mmdet/apis/inference.py", line 11, in <module>
    from mmdet.core import get_classes
  File "/home/xuhuanhua/mmdetection/mmdet/core/__init__.py", line 6, in <module>
    from .post_processing import *  # noqa: F401, F403
  File "/home/xuhuanhua/mmdetection/mmdet/core/post_processing/__init__.py", line 1, in <module>
    from .bbox_nms import multiclass_nms
  File "/home/xuhuanhua/mmdetection/mmdet/core/post_processing/bbox_nms.py", line 3, in <module>
    from mmdet.ops.nms import nms_wrapper
  File "/home/xuhuanhua/mmdetection/mmdet/ops/__init__.py", line 2, in <module>
    from .dcn import (DeformConv, DeformConvPack, DeformRoIPooling,
  File "/home/xuhuanhua/mmdetection/mmdet/ops/dcn/__init__.py", line 4, in <module>
    from .deform_pool import (DeformRoIPooling, DeformRoIPoolingPack,
  File "/home/xuhuanhua/mmdetection/mmdet/ops/dcn/deform_pool.py", line 7, in <module>
    from . import deform_pool_cuda
ImportError: /home/xuhuanhua/mmdetection/mmdet/ops/dcn/deform_pool_cuda.cpython-37m-x86_64-linux-gnu.so: undefined symbol: _ZN3c104impl28tls_excluded_tensor_type_setEv

Hi @Xuhuanhua ,
This might because the CUDA environment you are currently running is different from that for compiling the code. You may check the version using nvcc -V and echo $CUDA_HOME.

Hi @ZwwWayne ,
I check the version of CUDA using nvcc -V:
nvcc: NVIDIA (R) Cuda compiler driver
Copyright (c) 2005-2016 NVIDIA Corporation
Built on Tue_Jan_10_13:22:03_CST_2017
Cuda compilation tools, release 8.0, V8.0.61

while I check the version using cat /usr/local/cuda/version.txt:
CUDA Version 9.0.176

And terminal has no output when I use echo $CUDA_HOME.
Question

Which is CUDA environment I am currently running？
Which is CUDA environment for compiling the code？

I do not know either.
But this is indeed the problem, you could make them be the same 9.0 version and try further.

I use torch.__version__ = 1.1.0 and torch.version.cuda = 9.0.176.
**And then new error occurs: **
>>> from mmdet.apis import init_detector
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/xuhuanhua/mmdetection/mmdet/apis/__init__.py", line 2, in <module>
    from .inference import (inference_detector, init_detector, show_result,
  File "/home/xuhuanhua/mmdetection/mmdet/apis/inference.py", line 11, in <module>
    from mmdet.core import get_classes
  File "/home/xuhuanhua/mmdetection/mmdet/core/__init__.py", line 6, in <module>
    from .post_processing import *  # noqa: F401, F403
  File "/home/xuhuanhua/mmdetection/mmdet/core/post_processing/__init__.py", line 1, in <module>
    from .bbox_nms import multiclass_nms
  File "/home/xuhuanhua/mmdetection/mmdet/core/post_processing/bbox_nms.py", line 3, in <module>
    from mmdet.ops.nms import nms_wrapper
  File "/home/xuhuanhua/mmdetection/mmdet/ops/__init__.py", line 2, in <module>
    from .dcn import (DeformConv, DeformConvPack, DeformRoIPooling,
  File "/home/xuhuanhua/mmdetection/mmdet/ops/dcn/__init__.py", line 4, in <module>
    from .deform_pool import (DeformRoIPooling, DeformRoIPoolingPack,
  File "/home/xuhuanhua/mmdetection/mmdet/ops/dcn/deform_pool.py", line 7, in <module>
    from . import deform_pool_cuda
ImportError: libcudart.so.10.1: cannot open shared object file: No such file or directory

Do you recompile the ops after your change the Cuda version?

How to recompile the ops or others?

Once you change your Cuda version/environment, always remember to reinstall the MMDet (run the build command) following the guide

I always reinstall the MMDet following the guide when I change the CUDA version, but it didn't help me.
My solution
rm -rf mmdetection
conda remove -n open-mmlab --all
Finally I reinstall the MMDet following the guide .
Especially，I install PyTorch and mmdetection using:
conda install pytorch==1.1.0 torchvision==0.3.0

pip install -v -e .

My opinion
When we install the mmdetection, it will generate a build folder and some .so files.
Therefore, once we change our CUDA version/environment, we maybe need to remove the build folder and all .so files, and reinstall the mmdetection.

https://github.com/open-mmlab/mmdetection/issues/1577


[Feature] modal support use directive to define the footer

What problem does this feature solve?

What does the proposed API look like?
In Template
<nz-modal>

Content one

Content two

Content three

    Modal Footer:
    <button nz-button nzType="default" (click)="handleCancel()">Custom Callback</button>
    <button nz-button nzType="primary" (click)="handleOk()" [nzLoading]="isConfirmLoading">Custom Submit</button>

</nz-modal>

In nzContent component
createComponentModal(): void {
  const modal = this.modalService.create({
    nzTitle: 'Modal Title',
    nzContent: NzModalCustomComponent
  });
}
// ---

@Component({
  selector: 'nz-modal-custom-component',
  template: `

Content one

Content two

Content three

     Modal Footer:
     <button nz-button nzType="default" (click)="destroyModal()">Custom Callback</button>

  `
})
export class NzModalCustomComponent {

  constructor(private modal: NzModalRef) { }

  destroyModal(): void {
    this.modal.destroy({ data: 'this the result data' });
  }
}

I'm trying to make a self contained modal component but having some issues... I'm currently doing the following in MyModalComponent:
# HTML
<ng-template #modalFooter>
   <button (click)="clickHandler()"> ...
</ng-template>

# TS
@ViewChild('modalFooter') public footerTemplate: TemplateRef<any>;

ngOnInit() {
   this.modal.getInstance().nzTitle = 'My Title';
   this.modal.getInstance().nzFooter = this.footerTemplate;
}

But this is causing the animation to be janky because the header and footer aren't rendered until after the animation starts.
If I put this.modal.getInstance().nzFooter = this.footerTemplate;  in the constructor instead then the animation is smooth but the template onClick bindings aren't connected
Is there a better solution for this?


MAT_DIALOG_DEFAULT_OPTIONS as part of public-api

Bug, feature request, or proposal:
Bug
What is the expected behavior?
Import MAT_DIALOG_DEFAULT_OPTIONS and use it in module providers
What is the current behavior?
Can't import MAT_DIALOG_DEFAULT_OPTIONS from @angular/material. Also can't find a type for it in public-api
What are the steps to reproduce?
Easy to reproduce, just try to import it anywhere
What is the use-case or motivation for changing an existing behavior?
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular 5.13, Material 5.0.3, Typescript: 2.4.2
OS: Ubuntu 17.04
Is there anything else we should know?

anything changed?


Question : is it possible to load modules from multiple location ?

Description
I have system-wide installation of ZIM (in Arch linux), I wonder is it possible to extend module loading mechanism to include user specific location, for example $HOME/.zim/modules ?
I would like to add a new module and test it locally before I made contribution (maybe only I will be using this module so I don't have guarantee that it will be merged anyway). Besides of that it can be useful feature. I briefly looked at the ZIM source-code (but I am not fluent in zsh, just can write simple bash script) and it seems it only use $ZIM_HOME location to search for submodules.
I am aware that this need to be done carefully, considering configuration because I can image that if it will use the same zmodules list for both locations (built-in and user), it will involve making search mechanism smarter, to choose user source when there is no built-in module, but it will preserve ordering of modules loading easy.
Regards

@grzesuav, zim loads all modules in ${ZIM_HOME}/modules/${^zmodules}(/FN), which means all non-empty subdirectories of ${ZIM_HOME}/modules that are listed in the zmodules array. You can see that logic in the ${ZIM_HOME}/init.zsh script.
We currently don't support having both a system-wide and a user-specific zim configuration at the same time.

Not that it's the greatest way to handle it but you can add pathinfo to a module name e.g.: ../../../../home/user/.zim/modules/modulename
Ugly but works.

@grzesuav If you want a system-wide installation, then you need to only use and update the system-wide installation. This is my number one issue with system-wide installations; non-root users can't make modifications. Searching multiple file paths means opening more files than really necessary, and it's non-optimal.
Instead, why not drop a folder with a .zim repo and a .zshrc into /etc/skel, so it will be copied to each user's home folder when a user is created? If this isn't a use case (you're not going to be making multiple additional users), then you don't have a use-case for a system-wide zim install, and you probably are best served by copying your .zim add .z* files into the home directories of the users you use.

Thanks for response,
in arch-linux there is a rich repository with packages created by users, there is also zsh-zim-git package, preferred way to install packages it to do it this way. Just wanted to have both - system wide installation and ability to adjust it locally. I will try to keep it in user folder.
Regards

@grzesuav the alternative is to keep zsh-zim-git installed, and also have a .zim folder in your home directory for the user you want to add functions to. This means you get a default of zim (where you source the global install) and in the user with custom functionality, you source a local install instead. Again, I think the right answer is to just do a per-user install, but that seems like a decent compromise and gives you the best of both worlds at the cost of having to do a git pull AND rebuild the -git package occasionally (as opposed to only having to upgrade one install).


Improve kendo-PRO installation process

We should support two ways of installing kendo PRO:

via bower (using the jspm-git plugin)
via a vendors folder (as used today in the sample app)

The sample apps uses the vendors folder approach right now so that we can atleast get the plugin running and develop wrappers. In parallel we can take another stab at the jspm-git approach and perhaps fix issues we encounter.
Todo for jspm-git approach:
https://github.com/aurelia-ui-toolkits/aurelia-kendoui-plugin/issues/76, https://github.com/aurelia-ui-toolkits/aurelia-kendoui-plugin/issues/77, https://github.com/aurelia-ui-toolkits/aurelia-kendoui-plugin/issues/87
Todo for vendors approach:
https://github.com/aurelia-ui-toolkits/aurelia-kendoui-plugin/issues/75

I wonder if we can configure credentials for jspm-git so headless build servers can also run jspm install without getting stuck on the credentials prompt

This is certainly possible as I saw KendoUI PRO installation process description (somewhere in Kendo help pages) that show several methods for "hiding" the credentials in a platform independent way for precisely same reason you brought up

@adriatic I think we can close this issue. we have 3 ways of installing kendo (basic, jspm-git and vendors approach), and have documented the installation steps and have samples repositories for all mentioned approaches

Indeed - this turned out a lot better than I expected, mostly due to @JeroenVinke :-)


prow: make test rerun command argument match the job name

Describe the feature request
If the prow/e2e_pilotv2_auth_sds.sh test fails, the command to rerun it is:  /test istio_auth_sds_e2e. Notice how the argument istio_auth_sds_e2e is not prow/e2e_pilotv2_auth_sds.sh. Let's make these the same so that humans don't make the time-consuming mistake of trying to do /test prow/e2e_pilotv2_auth_sds.sh, as witnessed in https://github.com/istio/istio/pull/12203#issuecomment-479726114.
Describe alternatives you've considered
There is really no reason why the arguments shouldn't match...
Additional context
Looks like the tests all reside in https://github.com/istio/istio/tree/master/prow. Sounds like that's the entrypoint for performing the Prow job renames.

/cc @utka @ostromart

Any thoughts on this?

I think it is a good idea.

Looking into that a little bit more. I think there is more necessary change for separating tests for  branches in testgrid. This two changes do not work together.

I think we can just get rid of the "context" argument on all the jobs

I will get this done soon, tracking in https://github.com/istio/test-infra/issues/1460. I am going to close this one since its hard to track two at once