App is not running. I have checked Here SDK REF APP v1.3.0 in Android Mobile.

I have recorded screen video. You can watch here:
https://drive.google.com/file/d/1sXeQe6OUl8XXd3OjI1wX4DWJoUDAvkyr/view?usp=sharing

Problem is i am not getting any logs in my debug console

Hi,
please note, you still have to use Flutter 2.8.0 at the moment, see the readme file. Flutter 2.10.x integration is currently under discussion, but we know that there are issues. Please use Flutter 2.8.0 or 2.8.1 for the time being.


Vulnerability roundup 77: fontforge-20190413: 1 advisory

search, files

[ ] CVE-2019-15785 (nixos-19.09, nixos-unstable)

Scanned versions: nixos-19.09: 5f506b95f9f; nixos-unstable: c1966522d7d. May contain false positives.

The CVE is for fontforge 20190813 to 20190820. The version mentioned here is 20190413, so it's not affected :)

https://nvd.nist.gov/vuln/detail/CVE-2019-15785/cpes?expandCpeRanges=true lists 20190413 as affected version

But maintainer says in https://github.com/NixOS/nixpkgs/issues/88291#issuecomment-632376760 that CVE-2019-15785 is not relevant for us. Closing.


Update teams-developer-portal.md

minor update

Docs Build status updates of commit e361920:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/build-and-test/teams-developer-portal.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 7ac9fcc:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/build-and-test/teams-developer-portal.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit d9b819e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/build-and-test/teams-developer-portal.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit c41c823:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/build-and-test/teams-developer-portal.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Add Import Squad Section to Players tab

Yet Another Squad Builder outputs it's data into a text box on the screen instead of downloading a file.   To help enable easier input into the tool.  Each player tab should have an optional Multiline text input field that the data can be pasted into.
There should be an import button, and the squad data should be updated and as if the Import Wizard had been used.

This is now implemented, just copy and paste the compelete json file, and select import.


Possible timestamping or udp server or other issue with this motion server

I wont pursue a fix for this issue further for now but this is for dropping the note that this server has definitely inherited from its upstream code either a timestamping issue or a udp server limit issue or other issue. It appears that it is very inconsistent between bow aiming in BotW and shrine platform movement in BotW which excludes the emulation being wrong because a Wii Remote Plus motion server works fine so the issue is strictly centered around the motion server itself (possibly the timestamps sent by the server are incorrect or the udp server has technical issues considering it can't even support more than 1 client or there's another issue). In any case there's also an issue report at its upstream here https://github.com/TheDrHax/ds4drv-cemuhook/issues/3

Closed as per latest fixes


Feature Request: Run Auto-Move Check on All Notes

I have a massive amount of notes that I would like to sort into files. I would prefer to not have to edit each one (by adding a space at the bottom) to run the check but rather be able to run a command to check all of my notes and move them if appropriate.

Hello. Currently the entire vault is checked when the reindexing occurs.(e.g. with a major update)
A solution for the time being.

Create a new folder in the root of the vault.
Move all files and folders in the vault whose name prefix is not a period to the folder created in step 1.
Move the notes and folders moved in step 2 back to their original location.

This will trigger the note rename event and ANM will check them.

This doesn't seem to work , is there another way to force this?

It'd be nice if the Auto Note Mover: Move the note command could be triggered on multiple selected notes instead of just within a note's body

A scheduled sweep at a given time or when the app closes would be excellent options.

So I found a hack if you have the following problem:
You have used nested tags for organization and have all notes in a single file. Now you want to separate the files into individual folders. So you want to map tags to folders e.g. sw-dev/javascript should go to a folder sw-dev/javascript. You also want the freedom to map the tags security/ssl, security/threat-modelling etc. to one single folder "security".
This is possible via a workaround using this plugin (Auto Note Mover) and "Tag Wrangler" in combination.
So for the simplest case (mapping 1:1) you do this:

Create the destination folder manually
Setup the following Auto Note Mover rule: "folder name" --- "#tag/to/map1"
Note the "1" index at the end of the tag. You have to add an arbitrary number or character at the end of your tag for this to work
Rename the tag using Tag Wrangler: rename from #tag/to/map to #tag/to/map1
Now Auto Note Mover will detect a change and will move the files to the new folder
Rename the tag #tag/to/map1 back to #tag/to/map

Now for the more complex case you can do the same essentially but it also allows you to flatten hierarchy and e.g. catch all files of a parent tag if you're using nested tags. E.g. you want to move all files of security/ssl, security/tls, security/threat modelling, etc. to a single folder "security":

Create the destination folder manually
Activate regex matching in Auto Note Mover plugin for tags
Setup the following Auto Note Mover rule: "folder name" --- "^#security1.*"    (note: without the ")
Note the "1" index at the end of the tag. You have to add an arbitrary number or string at the end of your tag for this to work
Rename the parent tag using Tag Wrangler. For this go to the global tags view in Obsidian and rename the parent tag there directly. So rename "security" to "security1"
Now Auto Note Mover will detect a change and will move the files to the new folder.
Rename the parent tag in Obsidian global tag view back from "security1" to "security"

This worked for me when reorganizing my notes.


Work out why there is not 'about to reboot' indication on the final page.

Sorry, this repository is long-since deprecated in favor of Docker Toolbox (whose usage is now also discouraged in favor of Docker for Windows and Docker for Mac).


Is Conductor a right choice for 1M+ workflows per day?

The use case is messaging platform where message goes through different stages, some are simple and some are complex. Using workflow feels like a good fit to model it - some steps/tasks are async in nature and cannot be run synchronous.
Do you think Conductor can handle 1M+ workflows per day? Or 500 workflow initiations per second?
Thanks.

Hey @xaka, Conductor can handle 1M workflows. We're running similar ballpark workflows in production. There is still a concurrent decide issue, which we're trying to resolve by providing distributed locking interface, which can be best implemented with your own Zookeeper or similar locking system.
If you think you can patch bugs or improvements to solve your use case, and likewise for general community's use cases, you should be fine.

@kishorebanala Thank you for the updates. It will be great if you can share some information on the decider issues. Is it documented ? If no, what are the risks we are running against.
Also, what we have observed for high throughput workloads is as follows :

Make sure your first task is not a huge fork. It will increase the response times for create workflow. This is because it will recursive put all tasks in the queues.

You can consider making ES indexing async. Optionally, you can also provide a separate pool for the completable futures.

You can consider disablingSystemTaskWorkers in a "server" deployment and having a separate "executer" deployment with system task workers enabled for processing HTTP tasks. This will really help in avoiding periodic peaks in gc on the server.

Ensure that you set a timeout on HTTP tasks (not the task timeout) but a hard read and connect timeout. As you must have observed conductor timeouts have very small guarantees.

Make sure you are not throttled on Redis. Also, use Redis not MySQL for high write throughput workloads. It is worth considering a clustered Redis so that you can scale horizontally.

Make sure you have some strategy to achieve your workflow runs. Redis will fill up really fast and you cannot have eviction policies because we don't set TTL. Again, you cannot rely on LRU based approach, simply because it might evict other keys like tasks.

Make sure your worker tasks are idempotent.

Ensure that you are either fine with multiple invocations or merge the PR on idempotent workflow creations.

Consider auto-scaling executors / workers based on queue depth and consumption rate to avoid huge pile-ups (based on use case and load pattern)

Consider making HTTP task sync by changing the concrete implementation, if your use case demands.

@xaka

@mudit3774 Thanks for some great suggestions. We'll consider adding some of these to best practices section in documentation.
For 4., Conductor timeouts are strictly enforced on simple tasks, and we'd still have to debug and verify this for system tasks, especially HTTP.

Consider writing a service/process to archive workflows after execution.

We're still waiting on PR creator to cleanup before merging.

@kishorebanala thanks for the updates.
For 4,
My understanding might be incorrect, but it seems that the task timeouts are enforced using the sweeper. So, I can tune it for stricter guarantees by changing sweep frequency, the trade-off being running the sweeper frequently.
For 6: We have actually implemented the StatusUpdateLister to just archive the workflow on terminal states. We could potentially consider adding support for "archival-policy" for workflows like "on-completion", "no-archival" etc.
We could delegate it to another system but wouldn't it make sense to provide it as a part of the offering and could be considered in the roadmap if it is usable across clients.

The strategy for archiving the workflows could be specific to use case, for eg: Immediately on completion, or x days after completion etc.
But, it definitely makes sense to provide a default implementation as a separate module, that archives immediately through WorkflowStatusListener. I've added this to wishlist. I'm closing this issue as we've digressed from the original question. Feel free to open new issues with any suggestions or requests for enhancements.

@mudit3774 For 6: Can tell me how to configure data archiving，or point the code

@mudit3774 hi
For  3: Can you elaborate on the implementation plan for question 3
My understanding might be incorrect,it means that start workflow on server1,and poll task on server2  use same db?

It also depends on the way you run your workflows. The implementation of SQS consumer is slow and just 1 consumer per host. For me, it can consume just 3-5 messages per second being the bottleneck for the number of concurrently executed workflows.

Hey @mudit3774  were you ever able to get more than one consumer per host? We're having serious performance issues with starting workflows with events (in our case, AMQP). We're only getting throughput of 3-5/s for events like you, whereas sending a POST request maxes out at around 60-70/s. This is very disappointing; we expected for event based workflow starts to be faster than HTTP.
Maybe we're missing some magic configurations? We're on Conductor v3.5.3.
Thanks.


Feature/artifact-created-hook

Make manual approval configurable, by leveraging an artifact created hook for auto-deployment.
Addresses issue https://github.com/aws-samples/automate-deployment-and-version-update-of-kda-application/issues/4

Needs to be validated with Java and Python deployment


Disable array controlls

Array select and "add" button disabled if currentLength is equal maxLength
Fixes #140

@IgorZiegler don't forget to find a proper name for this PR


Cant add Custom View as shown in the Sample Image in Readme.md

Without any subviews the drawer controller works fine.
But when i added an imageview at the top center Horizontally.
Running the app on the simulator gives a blank Drawer Screen.
Any Idea why this may be Happening.

@iAviatorJose Hi!
Please take a screen shot 📷


Fix Get-VisualStudioExtensions function name typo

Description
Improvement
Related issue:
Check list

[ ] Related issue / work item is attached
[ ] Tests are written (if applicable)
[ ] Documentation is updated (if applicable)
[ ] Changes are tested and related VM images are successfully generated

/azp run windows2016, windows2019

Thank you for contribution!


No KATs published

I couldn't find any test vectors for komihash.
Could you please publish some so that I (and others) can verify implementations and ports are correct?

I did see two of the Ports you linked in your docs have ONLY two test vectors ( "test1" and "test2" ) which are poor tests, and also do not agree on the resultant hash ( BIG problem ).
So official KATs are critical, IMHO.

Thanks for the note. I've added test vectors to the project page, enjoy.


Add option tiller_listen_localhost to to disable listen localhost

Hi,
My case is using flux-helm-operator integration with Tiller TLS, if we set --listen=localhost:44134 flux wont be able to find tiller

Thanks, forgot about the fmt 👍

Ah can you do me a favor and bump https://github.com/gruntwork-io/terraform-kubernetes-helm/blob/master/.circleci/config.yml#L11 to 0.12.9 on this branch? Otherwise the fmt hook will fail in our CI because https://github.com/hashicorp/terraform/issues/21434 wasn't fixed until 0.12.6 and I see the fmt you ran includes the heredoc fixes. Thanks!

Done 👍

Thanks! Just kicked off the build. Should be able to merge if that passes!

Ah once we bumped terraform, another unrelated file fmt changed because the bug is now fixed... Can you run terraform fmt on examples/k8s-tiller-kubergrunt-minikube/main.tf? That should be the last remaining fmt issue.
Thanks, and sorry for the back and forth.

Sure will kick run it tonight and push

Done @yorinasub17 let me know if there is any changes needed

Merging this in. Thanks for the contribution!


Long delay before being able to process messages

I've created a minimal test application, consisting of two processes – one that writes and one that reads. For testing purposes, I've sent a little less than 100 messages.
Is there supposed to be a rather long delay, maybe 15 seconds, before the consumer starts to see new messages after it has been started? As soon as it begins consuming new messages, communication is instant.

Enabling debug mode shows me the following information:
kafka-node:ConsumerGroup joinGroupResponse {"members":[{"subscription":["kafka-test"],"version":0,"id":"kafka-node-client-10ccd9c4-a5ba-49e9-be52-2891df3958a7"}],"generationId":15,"groupProtocol":"roundrobin","leaderId":"kafka-node-client-10ccd9c4-a5ba-49e9-be52-2891df3958a7","memberId":"kafka-node-client-10ccd9c4-a5ba-49e9-be52-2891df3958a7"} from kafka-node-client +22s
22 sec. That's quite a bit isn't it? All other operations shown take 1-10 milliseconds.

I did some more testing, and this problem only occurs when using ConsumerGroup. With Consumer, it starts receiving messages immediately. The code:
#!/usr/bin/env node

const express = require('express');
const kafka = require('kafka-node');

const consumerOptions = {
    groupId: 'kafka-test-consumer-2-1',
    autoCommit: false,
};

const consumerGroup = new kafka.ConsumerGroup(consumerOptions, 'kafka-test');

consumerGroup.on('message', (msg) => {
    console.log(`Incoming message: ${JSON.stringify(msg)}`);

    consumerGroup.commit((err, data) => {
        console.log(data);
    });
});

Looks like that's time spent waiting for a response from your group coordinator (a specific broker).
Usually this takes about second or so.
Maybe shorten your session timeout?

Hey, I having the exact same problem, when I consume without groupId I can see in the DEBUG mode
  kafka-node:ConsumerGroup joinGroupResponse {"members":[{"subscription":["testTopic"],"version":0,"id":"kafka-node-client-226833ab-dc70-4463-a0d5-3610553fac24"}],"generationId":26,"groupProtocol":"roundrobin","leaderId":"kafka-node-client-226833ab-dc70-4463-a0d5-3610553fac24","memberId":"kafka-node-client-226833ab-dc70-4463-a0d5-3610553fac24"} from kafka-node-client +14ms

but with the same properites just adding the groupId - the members is empty array.
 kafka-node:ConsumerGroup joinGroupResponse {"members":[],"generationId":43,"groupProtocol":"roundrobin","leaderId":"kafka-node-client-4e9d59d9-079a-49bc-9868-f88a8ded8ad2","memberId":"kafka-node-client-76ef5c7f-08f3-4798-a8d2-9044c7e2d175"} from kafka-node-client +1s

and or the consuming is really slow - or it just not consumes!
I tried to decrease the session timeout from 15000 to 10000 - but the same result.
Help please.

Hi,
I having the same problem and decrease the session timeout from 6000 - but the same result and the consumer is Not work.

in this scenario when i use the consumer client with default options, the 'offsetOutOfRange' fire several time.

My first test was ConsumerGroup and second is a simple consumer.

I have also noticed initial 15+ seconds delay when using consumer group, is there any solution to this problem?

@jampanij it shouldn't take that long to join the group. You can turn on debugging and see what it's spending time doing.

@hyperlink I am new to Kafka, how to enable debugging?

@jampanij run it with DEBUG=kafka-node:* environment variable.

I've experienced this with librdkafka and I was able to resolve it by setting the metadata.max.age.ms property to a lower value then the default.
See this Stack Overflow post for an explanation:
https://stackoverflow.com/questions/41975747/why-does-kafka-consumer-takes-long-time-to-start-consuming


⚠ Hartman Foundation has degraded performance

In 730e773, Hartman Foundation (https://gordonhartman.com/) experienced degraded performance:

HTTP code: 200
Response time: 2418 ms

Resolved: Hartman Foundation performance has improved in 809256f.

Resolved: Hartman Foundation performance has improved in 809256f.


gomobile build broken

Your environment.

Version: Release or SHA
Browser: include version
Other Information - stacktraces, related issues, suggestions how to fix, links for us to have context

What did you do?
Running gomobile bind . no longer seems to work. git bisect reported this commit: https://github.com/pion/webrtc/commit/7edfb701e09e89258d4b3235cded99befc8058fd
I'm not actually sure why, perhaps it has to do with exposing an interface as an API? I will do some research and see if I can figure it out.
What did you expect?
What happened?

maybe show more error message?

Thanks for sharing how you fixed it @kevmo314! Would it be worth putting shims in a public repo, or do you think it’s better to do it per project?
I don’t think we should change pion/webrtc for this. Unless the changes are simple I don’t want to negatively impact others users not doing mobile.

Thanks for sharing how you fixed it @kevmo314! Would it be worth putting shims in a public repo, or do you think it’s better to do it per project?
I don’t think we should change pion/webrtc for this. Unless the changes are simple I don’t want to negatively impact others users not doing mobile.

It is unfortunately quite hard to fix, so we likely can't fix it directly. I think the shims are actually better per project since you can add logic into the shim which is what I'm doing and that cleans up the calling site.
That being said probably some documentation or examples might be worthwhile.


Video plugin throw error on when _update_videoCover

Init SunEditor with HTML

1

<iframe width="100%" height="700px" src="..."

Do you think we miss to set context.video._element as oFrame in video._update_videoCover?

The 2.36.0 version has been updated.
If this issue has not been resolved, please reopen this issue.
Thank you.

The 2.36.0 version has been updated.
If this issue has not been resolved, please reopen this issue.
Thank you.


user and group should before a directory can be owned by them

I ran into this when writing a wrapper cookbook based on this example.

@mburns, thanks for the fix :wink:

Fix released in 0.2.0.


Linux support

I have modified the code to make it work on Linux environment. In normal circumstances it should build with different flags depending weather the OS is of type Darwin or Linux. However I haven't the chance to test on my Mac because i had some issues installing the glm dependency.

Please include only the minimum necessary changes.

Code updated.

Works great in Ubuntu, thanks!


feat: receiver cli args

Codecov Report

Merging #124 (81a5e69) into develop (e66f3aa) will decrease coverage by 3.53%.
The diff coverage is 44.93%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff             @@
##           develop     #124      +/-   ##
===========================================
- Coverage    67.62%   64.09%   -3.53%
===========================================
  Files           37       40       +3
  Lines          942     1036      +94
===========================================
+ Hits           637      664      +27
- Misses         305      372      +67

Impacted Files
Coverage Δ

taskiq/cli/watcher.py
0.00% <ø> (ø)

taskiq/cli/worker/process_manager.py
0.00% <0.00%> (ø)

taskiq/cli/worker/run.py
0.00% <0.00%> (ø)

taskiq/receiver/params_parser.py
96.87% <ø> (ø)

taskiq/result_backends/dummy.py
100.00% <ø> (ø)

taskiq/utils.py
72.72% <25.00%> (-27.28%)
:arrow_down:

taskiq/middlewares/prometheus_middleware.py
26.78% <26.78%> (ø)

taskiq/brokers/zmq_broker.py
45.71% <28.57%> (+5.17%)
:arrow_up:

taskiq/abc/broker.py
83.87% <70.00%> (-1.53%)
:arrow_down:

taskiq/receiver/receiver.py
89.69% <91.30%> (ø)

... and 13 more

... and 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Fake up a namespace enclosing declaration when generating expando namespace members

This causes the LHS property names to appropriately shadow the names available within the namespace when doing lookup for type names during type node creation.
Fixes #31882
Also fixes #31676 (typo introduced in this change - the hasModifier check should just be ModifierFlags.Default rather than ModifierFlags.ExportDefault)

@typescript-bot cherry-pick this to release-3.5

@typescript-bot cherry-pick this to release-3.5

@typescript-bot cherry-pick this to release-3.5

meh, apparently once a PR is merged you can;t force it to take a new commit with a patch to the build infra :P looks like i'll open it by hand, fiiiiiine


Small optimizations to pipeline

Adding a new trigger takes a different path compared to update to alertEngine to reduce calls to Infinispan
Remove ExecutorService submits to keep more stuff in a single core to improve performance in limited CPU-core scenario

I think the title of the PR no longer matches all the changes :-)


Added azure-workitems source and converter

Description

Provide description here

Type of change

[ ] New feature

Related issues

Fix #1

Migration notes

Describe migration notes if any

Extra info

Add any additional information

Created PullRequest to answer this question https://app.slack.com/client/T033FMD9A73/C0350CRSC3C/thread/C0350CRSC3C-1671186096.781429

I have read the CLA Document and I hereby sign the CLA

Thank you for the contribution @Christopher-Haumann !!!


Have TypeSafeId impl Default

I think it's safe to let TypeSafeId impl Default.
StaticType already requires T to be default-able so by extension TypeSafeId<T> should be default-able (unless I'm missing an obvious case as to why it shouldn't).
I propose for the default impl to just call Self::new(). What do y'all think? Happy to raise a PR if we come to a consensus.
Why?
Currently you cannot #[derive(Default)] on a struct with a TypeSafeId field as you'll get a E0277 error on the field. The easiest work around is to just manually impl Default on the host-struct, but this is verbose and potentially unnecessary as the default impl ends up being something like:
type AccountId = TypeSafeId<Account>;

pub struct Account {
    pub account_id: AccountId,
}

impl Default for Account  {
    fn default() -> Self {
        Self { account_id: AccountId::new() }
    }
}

We should just be able to do
type AccountId = TypeSafeId<Account>;

#[derive(Default)]
pub struct Account {
    pub account_id: AccountId,
}

I'm not sure how I feel about generating random values in a Default. It doesn't feel very "default" to me.
For instance, uuid::Uuid::default() returns Uuid::nil().

You're right - that's a very good point! The default implementation should be somewhat deterministic. I say "somewhat" above due to the time-element of TypeIds; I don't think we can guarantee generating a totally deterministic value like Uuid::nil()... so I'm now a bit torn.
Since these IDs are supersets of Uuid, we could also leverage Uuid::nil() as a default (i.e. in the example above Account::from_uuid(Uuid::nil())). However, I don't think this will return the same base32 suffix every time (I haven't tested it myself yet).


⚠ Bofrost.lu has degraded performance

In adafa53, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1144 ms

Resolved: Bofrost.lu performance has improved in fb61b08 after 8 minutes.


[Question] Which node classification to use for which model?

Hi,
Which one of the 4 node classification tasks should be used for the model 'deep walk', 'node2vec','NetMF', and 'NetSMF'?.

Hi @aj280192,
These four methods belong to unsupervised network embedding. Thus, you should use unsupervised_node_classification.

Hi @cenyk1230 ,
Can the graph clustering task be used for these models?...


Conflict description for default index kind

In this document it's mentioned that default index kind is hash:
By default, the indexing policy uses Hash indexing for strings,
https://docs.microsoft.com/en-us/azure/cosmos-db/sql-api-query-metrics#indexing-policy
While in below document it's mentioned that default kind is range:
The default indexing policy for newly created containers enforces range indexes for any string or number.
https://docs.microsoft.com/en-us/azure/cosmos-db/index-overview#index-types
Kindly help to update one of them which is not correct.
Should be range as it's more recommended per below doc:
https://docs.microsoft.com/en-us/azure/cosmos-db/index-policy#includeexclude-strategy

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5108574a-cc34-22e6-1bf8-9ea50264ea4f
Version Independent ID: 29d8f8d8-3e26-a10e-0893-a507456b3477
Content: SQL query metrics for Azure Cosmos DB SQL API
Content Source: articles/cosmos-db/sql-api-query-metrics.md
Service: cosmos-db
Sub-service: cosmosdb-sql
GitHub Login: @SnehaGunda
Microsoft Alias: sngun

@hellojxg Thank you for the feedback. We are actively investigating and will get back to you soon.

@hellojxg I was going through multiple articles and you have rightly pointed out that there is a conflict in these docs. By default it should be range index on strings. However, it is being assigned to the content author to evaluate and update as appropriate.

@hellojxg thanks for pointing out, it should be range index on strings, I fixed the doc in thee the above PR. Changes will be live tomorrow. We will close this issue now.
#please-close


docs: add Chinese translations

🔗 Linked issue
#340

❓ Type of change

[x] 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
Close #340

📝 Checklist

[x] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

I am not so sure if we want to maintain translations for docs, given the fact that:

We duplicate the sources of truth. Every time we update something, we need to spend extra effort updating translations or we create misalignment
ofetch is not a very user-facing library I suppose?
AI nowadays could provide very accurate translations already

Thanks for PR dear @AllenYu0118 and willing to help on translations. I think @antfu is correct as keeping the docs up to date can be challenging in the future. We might think of automated translations in website in the future. I have moved the follow to this thread: https://github.com/unjs/website/issues/207

I agree with your idea,  thank for your response.🤔


Localization/Comments/Javadoc

Make sure everything has comments, localization where needed, and that Javadoc builds without errors

Finished


Suddenly it restarted Obsidian.

Hi, i've been using the  theme for a week now, tonight while I was working on my browser Obsidian collapsed, restarted the opened vaults I had, the Terminal's Vauls appeared with the default theme, and unistalled.

Hi, this issue is unrelated to any specific theme. It could be due to interference from plugins or an Obsidian bug.


deis auth:cancel is not deleting the user account

[stacktrace failed call] (https://gist.github.com/smothiki/9820dd7486e9654e3c77)
Its actually throwing 500 but we never caught it .
mothikis-MacBook-Pro:tests smothiki$ deis auth:cancel
Please log in again in order to cancel this account
username: test
password:
Logged in as test
Cancel account "test" at http://deis.smothiki.io? (y/N) y
Account cancelled

looks related to https://github.com/deis/deis/pull/2865 in a sense, though really the client should've caught that 500 error


Update Spooler to Direct Version

Use direct contact with logs, and reference logs more exactly for spooler history.

Using signals requires the spooler to be open to record the entry.
Using signals is potentially lossy if many things are cancelled.
Adds in UID for each job, so they can be more directly referenced without ambiguity.
Better readability in meerk40t.log

See:
https://github.com/meerk40t/meerk40t/pull/1540

Yeah, a lot of this was just to get some stuff a bit more graceful than they currently felt like they were. Especially relying on signals to convey the data to then get stored. This would, in theory store that data even with CLI jogs, etc.
In theory the csv stuff would be best done as a sort of report. Like info on all jobs, or just important jobs (I didn't automatically delete them (but probably should)), all those with this flagged info bit.


App Service backup limits

Hi,
On App Service, mismatch on # of backup between this page and another reference: https://learn.microsoft.com/en-us/azure/app-service/manage-backup (this one seems the more "up to reality" aligned to service operation, every hour)
Also, in the portal when changing on the "Scale up (App Service plan)", it is mentioned in "included features":

on basic sku nothing of "daily backup"
on Standard "10 daily backups"
or Premium V2 / V3 : "50 daily backups"

If all info could be aligned ;)
Jean-Philippe

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 36f49a06-90b1-cbe1-3853-2c38277b79f8
Version Independent ID: 02ff6f6c-3ef6-b48f-060d-b290419e0aba
Content: Azure subscription limits and quotas - Azure Resource Manager
Content Source: articles/azure-resource-manager/management/azure-subscription-service-limits.md
Service: azure-resource-manager
Sub-service: management
GitHub Login: @tfitzmac
Microsoft Alias: tomfitz

@jephlu
Thanks for your feedback! We will investigate and update as appropriate.

@jephlu Thanks for your feedback.
Assigning to content author  @tfitzmac for review.

@msangapu-msft - can you take a look at this request and see if the two articles need to be reconciled?

We have a new feedback system in place, so we need to close the remaining GitHub issues. We have created an issue in our internal tracking system.
#please-close


Refactor embed object

Refresh the IA of the embed object and refactor the @mixin for simplicity and improve flexibility.

Completed.


Updated badphotography, hash type - 4

I tried with 50 images, all images look good to me, so i think this update should be resolved the issue now.
The output images:
imgs.zip

These look great, exactly what we need for the archetype reproductions


generator.yml: Add make_variables

This is mainly a proof of concept, I will rewrite generator.yml completely with these definitions if we are happy with them.

This is mainly a proof of concept, I will rewrite generator.yml completely with these definitions if we are happy with them.

I have tried to logically chunk things up, the individual commits/messages should paint a nice picture and we get a successful TuxSuite run on both mainline and next :)
https://github.com/nathanchance/continuous-integration2/actions/runs/506217309
https://github.com/nathanchance/continuous-integration2/actions/runs/506217533

I have tried to logically chunk things up, the individual commits/messages should paint a nice picture and we get a successful TuxSuite run on both mainline and next :)
https://github.com/nathanchance/continuous-integration2/actions/runs/506217309
https://github.com/nathanchance/continuous-integration2/actions/runs/506217533

With the fix to the BOOT value and adding i386 support, we now have two completely green runs:
mainline: https://github.com/nathanchance/continuous-integration2/actions/runs/506461732
next: https://github.com/nathanchance/continuous-integration2/actions/runs/506462059

With the fix to the BOOT value and adding i386 support, we now have two completely green runs:
mainline: https://github.com/nathanchance/continuous-integration2/actions/runs/506461732
next: https://github.com/nathanchance/continuous-integration2/actions/runs/506462059

Thanks for the review!

Thanks for the review!


[EP-1855] Updated response mapping to match native SDK

Fields added:

type - transaction type value
result - transaction result value (0: Success, 1: Declined)
message* - the transaction result message
judoId* - the Judo ID value
cardCategory - the cards category  - ex: Classic
cardCountry - the ISO code of the country
cardFunding - the card funding type - ex: Debit

* - only available on RN iOS, since types not present in the native Android SDK response

@marcghelas regarding this note:

only available on RN iOS, since types not present in the native Android SDK response

let's update the response model in Android SDK

@marcghelas regarding this note:

only available on RN iOS, since types not present in the native Android SDK response

let's update the response model in Android SDK

Looks good to me.

Looks good to me.


Missing translations for field error messages

I was looking for a simple to use scheduler, based on (or usable with) react and material-ui and found this as a very good match (hoping that recurrence is on a high position of the agenda :smile: ), thank you for your work...
As I'm and my users are German, translation is one of the key features. Generally it works fine with the translations-prop, but if verification of fields (default and custom) fails, the error messages are still in English (understandable as they weren't mentioned in the prop). Is there a way to translate those error messages in the current version, or is this feature missing?

Agree, the translations should include the validation messages, I guess we missed that.
Another option that you can implement right now without delay, is to use customEditor , you can define your own form, inputs, validations etc... Check the customEditor demo in the ReadMe

Thank you so far, I'll take a deeper look on the demo and check if its worth it, or if my users and me can wait for an updated version...

v2.7.14 have  translations.validation object

It works like a charm... thank you very much!


[BUG]: kubernetes orchestrator fails trying to create clusterrolebinding instead of rolebinding

Contact Details [Optional]
<EMAIL_ADDRESS>System Information
encountered with zenml 0.43.0 but affects latest version
What happened?
The Kubernetes orchestrator, when creating a service account to run pipeline pods (as per https://docs.zenml.io/v/docs/stacks-and-components/component-guide/orchestrators/kubernetes#additional-configuration), tries to create a ClusterRoleBinding to the "edit" ClusterRole. This however would mean that this service account would have global access to all namespaces, which is a security concern, so in a securely set up production cluster creating this ClusterRoleBinding would be prohibited.
At the same time, it shouldn't be necessary to create this ClusterRoleBinding to begin with, as the service account should only need "edit" entitlements for the target namespace in which it is going to run the pipeline. This means the orchestrator should create a RoleBinding instead of a ClusterRoleBinding to the "edit" ClusterRole here: https://github.com/zenml-io/zenml/blob/main/src/zenml/integrations/kubernetes/orchestrators/manifest_utils.py#L290
Reproduction steps

...
Relevant log output
HTTP response body:
{"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"c
lusterrolebindings.rbac.authorization.k8s.io is forbidden: User
\"system:serviceaccount:testnamespace:zenml\" cannot create resource
\"clusterrolebindings\" in API group \"rbac.authorization.k8s.io\" at the
cluster
scope","reason":"Forbidden","details":{"group":"rbac.authorization.k8s.io","kind
":"clusterrolebindings"},"code":403}

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Fixed with https://github.com/zenml-io/zenml/pull/3211


Error on toPdf

When I try to save the file as a pdf I get
/Users/margaretbyrne/Desktop/tfg-webber-aio-api/node_modules/nodeice/lib/index.js:266
                callback(err, data[1], data[0]);
                                  ^

TypeError: Cannot read property '1' of undefined

Am I missing some dependancy? I can't seem to export as pdf!

+1


Feature/update payex colors

Description
Updates for PayEx's colors, fonts, logos. Updated Material Icons for PayEx to use "Sharp"
Motivation and Context
PayEx's design guide is out of date and this is a start to get a working design guide for PayEx.
How Has This Been Tested?
Changes are mostly done in .less files so no unit tests are added. Existing unit test all pass.
Review has been done via Malin Gutemyr (working with design from PayEx)
Screenshots (if appropriate):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have updated the CHANGELOG document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Sorry! trigger happy, såg inte din kommentar till Phung, @VikingTristan

Ja jag såg att den failade. Ska jag bara restore min branch och köra om jobbet?

Ja jag såg att den failade. Ska jag bara restore min branch och köra om jobbet?

nono its okay ^^


Athlinks is returning a lot of duplicates

Figure out why we're getting duplicate results in the RFTZ 2024 5k and 10k scrapes.
I had to add a sleep to make my athlinks driver work again. For whatever reason, waiting for the button to be available wasn't sufficient.
So, I'd prefer not to get the duplicates, but I've spent way too much time on this today.

FWIW, when I tried dumping the element ids of each of the elements that I was searching, I found that eventually we get a bunch of duplicates. I suspect this is a bug somewhere outside my code. I thought that perhaps if I tried doing the find_all inside an element rather than on the client that it might help:
diff --git a/src/athlinks.rs b/src/athlinks.rs
index 27a672d..2246e99 100644
--- a/src/athlinks.rs
+++ b/src/athlinks.rs
@@ -178,7 +178,8 @@ const BUTTON_CSS: &str = "#pager>div>div>button";

 async fn print_placements(c: &Client) -> AResult<()> {
     c.wait().for_element(Css(BUTTON_CSS)).await?;
-    let placements = stream::iter(c.find_all(Css(".row.mx-0")).await?)
+    let content = c.find(Css("#content")).await?;
+    let placements = stream::iter(content.find_all(Css(".row.mx-0")).await?)
         .filter_map(Placement::from_element)
         .collect::<Vec<_>>()
         .await;

but it didn't.

Turns out, it's a bug in the RFTZ results. If the "Full Course" is selected, and you paginate to the page that starts with the 501st finisher, instead of getting 50 results, you get all the remaining results.
Weird, but I'm not going to spend any more time on it, at least not until I have more Athlinks scraping to do.


fix(Studies): qidoSupportsIncludeField should be true by default

fix #772

Fixed here: https://github.com/OHIF/Viewers/pull/801


Start all labs with a ready Kubernetes

Current Behavior

Desired Behavior

Resources

Alternatives / Additional Context

Current Behaviour

User needs to install minikube in the Katacoda environment before starting the lab.

Desired Behaviour

minikube should be pre-installed and user just need to have install mesheryctl directly.

Hey @leecalcote , Can you assign this issue to me

Oh, my goodness. I missed these comments, @devansh42. Your issue description is so much better than mine. ;)

@leecalcote  consul still using Minikube as backend image, rest have Kubernetes set.
https://github.com/layer5io/service-mesh-labs/blob/master/Meshery-Adapters/consul-meshery-adapter/index.json


[sdk] ssl.SSLError: [SSL: WRONG_VERSION_NUMBER] wrong version number

Environment

KFP version: 1.8.1
KFP SDK version: 1.6.2
All dependencies version:
kfp                          1.6.2
kfp-pipeline-spec            0.1.16
kfp-server-api               1.8.5

Steps to reproduce
It happens on GCP, on a Kubeflow 1.5 cluster
To reproduce you should execute the following code:
from kfp import Client
kfp_client = Client(
    host="",
    client_id="",
    other_client_id="",
    other_client_secret="",
    namespace="aNamespace"
)

kfp_client.set_user_namespace(namespace="aNamespace")
pipeline_id = kfp_client.get_pipeline_id(name="aPipelineName")
print(pipeline_id)

Expected result
I should get a pipeline id
Instead, I get
Traceback (most recent call last):
File "/Users/user/.pyenv/versions/lib/python3.9/site-packages/urllib3/connectionpool.py", line 703, in urlopen
httplib_response = self._make_request(
File "/Users/user/.pyenv/versions/lib/python3.9/site-packages/urllib3/connectionpool.py", line 386, in _make_request
self._validate_conn(conn)
File "/Users/user/.pyenv/versions/lib/python3.9/site-packages/urllib3/connectionpool.py", line 1040, in validate_conn
conn.connect()
File "/Users/user/.pyenv/versions/lib/python3.9/site-packages/urllib3/connection.py", line 416, in connect
self.sock = ssl_wrap_socket(
File "/Users/user/.pyenv/versions/lib/python3.9/site-packages/urllib3/util/ssl.py", line 449, in ssl_wrap_socket
ssl_sock = ssl_wrap_socket_impl(
File "/Users/user/.pyenv/versions/lib/python3.9/site-packages/urllib3/util/ssl.py", line 493, in _ssl_wrap_socket_impl
return ssl_context.wrap_socket(sock, server_hostname=server_hostname)
File "/Users/user/.pyenv/versions/3.9.9/lib/python3.9/ssl.py", line 500, in wrap_socket
return self.sslsocket_class._create(
File "/Users/user/.pyenv/versions/3.9.9/lib/python3.9/ssl.py", line 1040, in _create
self.do_handshake()
File "/Users/user/.pyenv/versions/3.9.9/lib/python3.9/ssl.py", line 1309, in do_handshake
self._sslobj.do_handshake()
ssl.SSLError: [SSL: WRONG_VERSION_NUMBER] wrong version number (_ssl.c:1129)

Hi @pablofiumara!
where you able to create kfp_client? Can you share what you set as host?
Could you share what line results in the exception?
Do you have a pipeline with name aPipelineName?

Hi @gkcalat ! Thank you very much for your answer.
I was able to create a kfp_client. I set https://cluster-name.endpoints.my-gcp-project.cloud.goog/pipeline as host
The following line results in the exception
pipeline_id = kfp_client.get_pipeline_id(name="aPipelineName")
I have a pipeline with name aPipelineName

@pablofiumara could you please repeat all steps share the full Traceback (all outputs)?

@gkcalat Thanks for your answer. Here's the full traceback
File "/Users/user/.pyenv/versions/3.9.9/lib/python3.9/runpy.py", line 197, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/Users/user/.pyenv/versions/3.9.9/lib/python3.9/runpy.py", line 87, in _run_code
exec(code, run_globals)
File "/Users/user/src/stovell/project/src/stovell/kubeflow/pipelines/my-project/publish.py", line 44, in
pipeline_id = kfp_client.get_pipeline_id(name=PIPELINE_NAME)
File "/Users/user/.pyenv/versions/project/lib/python3.9/site-packages/kfp/_client.py", line 413, in get_pipeline_id
result = self._pipelines_api.list_pipelines(filter=pipeline_filter)
File "/Users/user/.pyenv/versions/project/lib/python3.9/site-packages/kfp_server_api/api/pipeline_service_api.py", line 1212, in list_pipelines
return self.list_pipelines_with_http_info(**kwargs)  # noqa: E501
File "/Users/user/.pyenv/versions/project/lib/python3.9/site-packages/kfp_server_api/api/pipeline_service_api.py", line 1313, in list_pipelines_with_http_info
return self.api_client.call_api(
File "/Users/user/.pyenv/versions/project/lib/python3.9/site-packages/kfp_server_api/api_client.py", line 364, in call_api
return self.__call_api(resource_path, method,
File "/Users/user/.pyenv/versions/project/lib/python3.9/site-packages/kfp_server_api/api_client.py", line 181, in __call_api
response_data = self.request(
File "/Users/user/.pyenv/versions/project/lib/python3.9/site-packages/kfp_server_api/api_client.py", line 389, in request
return self.rest_client.GET(url,
File "/Users/user/.pyenv/versions/project/lib/python3.9/site-packages/kfp_server_api/rest.py", line 230, in GET
return self.request("GET", url,
File "/Users/user/.pyenv/versions/project/lib/python3.9/site-packages/kfp_server_api/rest.py", line 208, in request
r = self.pool_manager.request(method, url,
File "/Users/user/.pyenv/versions/project/lib/python3.9/site-packages/urllib3/request.py", line 74, in request
return self.request_encode_url(
File "/Users/user/.pyenv/versions/project/lib/python3.9/site-packages/urllib3/request.py", line 96, in request_encode_url
return self.urlopen(method, url, **extra_kw)
File "/Users/user/.pyenv/versions/project/lib/python3.9/site-packages/urllib3/poolmanager.py", line 375, in urlopen
response = conn.urlopen(method, u.request_uri, **kw)
File "/Users/user/.pyenv/versions/project/lib/python3.9/site-packages/urllib3/connectionpool.py", line 813, in urlopen
return self.urlopen(
File "/Users/user/.pyenv/versions/project/lib/python3.9/site-packages/urllib3/connectionpool.py", line 813, in urlopen
return self.urlopen(
File "/Users/user/.pyenv/versions/project/lib/python3.9/site-packages/urllib3/connectionpool.py", line 813, in urlopen
return self.urlopen(
File "/Users/user/.pyenv/versions/project/lib/python3.9/site-packages/urllib3/connectionpool.py", line 785, in urlopen
retries = retries.increment(
File "/Users/user/.pyenv/versions/project/lib/python3.9/site-packages/urllib3/util/retry.py", line 592, in increment
raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='cluster-name.endpoints.gcp-project.cloud.goog', port=443): Max retries exceeded with url: /pipeline/apis/v1beta1/pipelines?filter=%7B%22predicates%22%3A+%5B%7B%22op%22%3A+1%2C+%22key%22%3A+%22name%22%2C+%22stringValue%22%3A+%22project+ (Caused by SSLError(SSLError(1, '[SSL: WRONG_VERSION_NUMBER] wrong version number (_ssl.c:1129)')))
make: *** [publish] Error 1

Thank you, @pablofiumara. It seems that the issue is unrelated to GCP distribution of Kubeflow.
I am closing this as you have another thread in pipelines repo. Follow up over there.


Object spread fails in jsx: "Cannot read property 'expression' of undefined."

ESLint: Cannot read property 'expression' of undefined. Please see the 'ESLint' output channel for details.
is outputted by ESLint with for this code:
const a = {};
const foo = () => (
	<Link
		to={{
			pathname: '/bar',
			query: { ...a },
		}}
	/>
);

config:
{
  "parser": "babel-eslint",
  "extends": [
    "plugin:import/errors",
    "plugin:import/warnings",
    "airbnb"
  ],
  "plugins": [ "babel", "react", "jest" ],
  //...
}

versions: (all are latest)
"babel-eslint": "^8.2.1",
"eslint": "^4.17.0",
"eslint-plugin-babel": "^4.1.2",
"eslint-plugin-react": "^7.6.1",

copy of https://github.com/eslint/eslint/issues/9960 I'm not sure where it belongs yet

I got exact the same error. The object spread syntax works outside JSX but fails inside it. It seems not solely related to eslint. I tried to run babel commands to transpile my code and it failed too on the same error.

Thank you for the issue. Now that @babel/eslint-parser has been released, we are making this repository read-only. If this is a change you would still like to advocate for, please reopen this in the babel/babel monorepo.


Incorrect readme instructions for CSS

This section is incorrect in my app. Not sure why or how you get the actual scss into your project since its a link to the other repo. But this section doesn't work
If you are using SCSS, modify your application.css.scss

// import bootstrap-sprockets before bootstrap if using bootstrap >= 3.2
@import 'bootstrap-sprockets';
@import 'bootstrap';
@import 'bootstrap-datetimepicker';

application.scss is now the default.
And @import 'bootstrap-datetimepicker'; should be
@import 'bootstrap-datetimepicker.css';
Thanks

Same problem, but to import bootstrap-datetimepicker.css don't solves the problem for me: the CSS file is not loading really, you can see it in rails log or in the browser console (Chrome).
@bluengreen It is working for you with .css extension? Did you found another solution. Thanks.

Oh, I've found a solution. This is my new application.scss:
/*
 *= require_tree .
 *= require_self
 *= require bootstrap-datetimepicker
 */

@import 'bootstrap-sprockets';
@import 'bootstrap';

@bluengreen is correct.  You should be doing @import 'bootstrap-datetimepicker.css';, if your manifest file is a sass file, application.css.scss.
The other thing they could do, is just add a bootstrap-datetimepicker.scss file to the gem and it should be just fine.
Let me know if you want me to just make a pull request.


WIP - Improve Importer Logging

The basis for this is to beef up importer logging #1121. This is a work in progress and I would value your feedback, especially @alexsoble since you've been doing some work in the importers.
Current State
There is an ImportRecord created for each run of the importers. This record contains overall timing information along with some specific timing information @alexsoble added to give immediate insight into our importer performance issues.
There is a basic page off of the admin homepage that reports when each run was started and whether it completed.
This PR (so far)
In this first addition to the PR, I've added ImportRecordDetail which represents a run of an individual importer. The import_record_details has the following columns:

:import_record_id (id of the related import_record)
:importer (class name of the file_importer for this record)
:time_started (time the import started)
:time_ended (time the importer ended, should be set with most failures as well)
:status (current status of the importer: pending, started, failed, completed. this is updated int the database when the status changes)
:error_message (if a failure was detected, this should contain the error message)
:rows_processed (#of rows that import_row was called on.)
:rows_excluded (#of rows excluded by the school fiter primarily) (the sum of rows_processed and rows_excluded should equal the number of lines in the CSV file)
:rows_created (#of processed rows resulting in a new record in the database)
:rows_updated (#of processed rows resulting in an updated record in the database)
:rows_deleted (#of rows deleted from the database. Currently used by StudentSectionAssignments and EducatorSectionAssignments for stale assignments)
:rows_rejected (#of processed rows that are rejected. For example, an EducatorSectionAssignment where the Educator or Section doesn't exist in the database)

I've also pushed the refactoring of the importers in the direction of a base class to reduce the amount of boilerplate code in each importer.
Specifically I've created the BaseCsvImporter from which all current importers inherited. This base class provides the following:

An implementation of #import that essentially: logs the start, calls a before_import hook in the derived class (if it exists), reads the CSV file, and for each row...filters school appropriately and calls import_row on the derived class, calls an after_import hook in the derived class (if it exists), and finally logs the importer completion for ImportRecordDetail.

It proxies the logging functions from ImportRecordDetail through method_missing.

Work to do

Adding specs to thouroughly test ImportRecordDetail and BaseCsvImporter in isolation.
Updating the import record front end to add ImportRecordDetail
Test end to end with import.thor.
Think through adding some sort of ImportEngineDetail for the import post processors like creating the json for the student searchbar.

Cool, thanks @jhilde! Just reviewed.

Many thanks @alexsoble. So overall, would you be more comfortable with a return to importers that inherit from Struct? No worries, I'm fine either way.

@jhilde I think even with the inheritance, we have a couple signals in the code that @kevinrobinson taught me to watch out for as a "code smells":

Use of delegate: means that when you call a method it's not obvious which class to look in for the method definition
Use of if self.respond_to?: means that you have to check in two class files to read the flow of control

If we can use inheritance in a way that avoids delegate and if self.respond_to? and keeps the flow of control in one file, I'm all for it! Might be a little less D.R.Y. than using delegate and if self.respond_to? but worth it for what we gain in readability of flow-of-control.

@alexsoble Great!
To get rid of the delegate: I'll either just have importers call import_record_detail.log_* directly.
To get rid of the self.respond_to?, I'll create no-ops for before_import and after_import. If they're overridden in the individual importers, that code will be called. Otherwise it will just be a quick no-op.
Thanks for helping me think through this!

@jhilde Cool, curious to see what that will look like. If it keeps all the flow of control code clear to read in one place it should be 👍 .

@alexsoble I made those changes. Will be iterating on the ui to show the import_record_details and specs that exercise BaseCsvImporter.

Hey @jhilde! I'm going to suggest @kevinrobinson review this when he gets a chance to.
The before_import, after_import strategy is an interesting approach. It definitely makes what's happening more explicit, it still splits up the import process across two files though.
I'll defer to @kevinrobinson. Thanks @jhilde!

@alexsoble Sounds good.
My chief reason for the inheritance is to DRY out the import method. Just seems really problematic to have copy and pasted code in each of the importers.
When I added the deletes for the Assignment importers, I was really frustrated that I had to include a list of importers that import.thor needs to call delete on. In my OO view of the world, import.thor shouldn't have any knowledge of importer internals. It should simply know that it can call import on importers and they work.
That's just my opinion though, happy to flatten them out and put all the code back to the individual importers.

@alexsoble @jhilde Sure, I'm happy to help.  From skimming quickly, it sounds like some great programming discussion :)  I'll take a closer look later tonight, and then let's get this better logging shipped!


Meltano/GitLab equivalent of "Request changes" on an MR

Migrated from GitLab: https://gitlab.com/meltano/handbook/-/issues/70
Originally created by @aaronsteers on 2022-03-05 19:02:03

GitHub has this feature for explicitly "requesting changes" on a PR. This is a polite way of indicating that an approver has "rejected" or "declined to approve" the change in its current form - which is different and stronger than not having approved yet. In Gitlab there is no similar option: we can "add comments" and we can "approve" but we cannot explicitly decline to approve a request.
Why does this matter
Increasingly, we have a broad group of approvers each looking at different things and each prioritizing different things. We have seen at least a few cases where MRs have been merged without resolving the review feedback - and most of these are in cases where multiple approvers are looking at different aspects, and meanwhile another approver provided their approval based on a different set of criteria.
GitHub's UI
For comparison, note that GitHub has an explicit "reject" option, politely named "request changes".
Click to expand

Which shows the merge is explicitly blocked using a red icon next to the reviewer's name.
Click to expand

Proposal
The only option that immediately comes to mind is the use of a "Requested changes" emoji on the MR. Perhaps 👎 is too strong and/or too overloaded, but perhaps there's another we could use? And then authors and other reviewers would know to check for this emoji vote on the MR before merging - and follow up with the raiser of that emoji to ensure feedback is addressed before merging.
See below for some emojis I'm trying out as possible. (Obviously we'd pick just one.)

View 3 previous comments from the original issue on GitLab


streamlink: patch tests for compatibility with Requests 2.26

Motivation for this change
Fails to build currently: https://hydra.nixos.org/build/153000251
Applying upstream patch from streamlink/streamlink#4022
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 138201 at 299d4d72 run on x86_64-linux 1

2 packages built successfully:

streamlink
streamlink-twitch-gui-bin

Result of nixpkgs-review pr 138201 run on x86_64-linux 1

2 packages built:

streamlink
streamlink-twitch-gui-bin


Use base01 for contrasting floating windows against main window

Currently hover windows don't appear properly because their background color is base00 which is shared with the main window. This branch changes the background color for these windows to base01.
Before:

Now:

The backgrounds are the same colour because the hover windows have a border option to show the barrier between the two.


Initial working gradle/liquibase integration.

To allow developers to test rollbacks locally, and to get us a head start if we ever decide to actually roll something back in production.
We might well want to parameterize it more, but having it exist at all seems like a necessary start.

That's a great point—added bcb51f63917f4932ebed91e990f66c29e2052581.


Fixed wrong vmrunner imports

The way the import is done is still not the proper way to do it. This is still not a python module, for that it will require a setup.py as well. I'll see to this later.

Hey test


⚠ Turnos 24x7 has degraded performance

In b6cfca8, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 6559 ms

Resolved: Turnos 24x7 performance has improved in f5915d8.


HIP-xxx - Pause Hex Boosting Rewards For All Radios.md

This HIP aims to pause and remove Service Provider Hex Boosting that was passed in HIP-84, to be completely reworked with current available equipment that was not available previously in mind and new economics to better scale with nationwide and beyond.

This can be closed.  Proceeding with
https://github.com/helium/HIP/pull/916


Bug with test status via API

When a test is starting, after starting the agents and distributing files, perftest/{id}/api/sample returns the following
{   "status": "TESTING" }
Till the test starts generating results, the above will show. Once the test starts generating results, then we get the appropriate agent and metrics details. But in both cases, the status is shown as "TESTING". This causes issues when we're using the API to retrieve live statistics.
Proposed solution: Add another status type, maybe "SCRIPT_INITIALIZING", which will show as status until the test generates statistics. Once the test begins to show statistics then maybe the status can be set to TESTING.
Thanks for the help.

Any update on this? It's causing a few showstoppers for us because we need to use a buffer time before curling nGrinder for the stats.


Getting Errror In Angular-CLI SSR

Hi, I tried all the steps from https://github.com/angular/angular-cli/wiki/stories-universal-rendering
After running this command npm run build:ssr && npm run serve:ssr, got the below error:
`ERROR in ./server.ts
Module build failed: TypeError: Cannot read property 'afterCompile' of undefined
at successfulTypeScriptInstance (D:\ssr\node_modules\ts-loader\dist\instance

s.js:147:28)
at Object.getTypeScriptInstance (D:\ssr\node_modules\ts-loader\dist\instance
s.js:48:12)
at Object.loader (D:\ssr\node_modules\ts-loader\dist\index.js:16:41)
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR<EMAIL_ADDRESS>webpack:server: webpack --config webpack.server.config.js -- progress --colors
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>webpack:server script.
npm ERR! This is probably not a problem with npm. There is likely additional log
ging output above.
npm ERR!      C:\Users\eshiksha\AppData\Roaming\npm-cache_logs\2018-03-08T07_46_
29_034Z-debug.log
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR<EMAIL_ADDRESS>build:ssr: npm run build:client-and-server-bundles && npm ru n webpack:server
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build:ssr script.
npm ERR! This is probably not a problem with npm. There is likely additional log
ging output above.
npm ERR!      C:\Users\eshiksha\AppData\Roaming\npm-cache_logs\2018-03-08T07_46_
29_091Z-debug.log`

https://github.com/TypeStrong/ts-loader/releases/tag/v4.0.0
I think this is because TypeScript dropped support for webpack 2/3, as pointed out  by @georgebonney in  #9783 .
Downgrading to ts-loader 3.5.0 should temporarily solve this problem

@Hayden-Yu Yes you are right, it worked on ts-loader 3.5.0


What feed format is best?

RSS 1.0? 2.0? Atom? Is there any difference in use or reader adoption?

I've found that RSS seems to be the best if you're wanting to use this with iTunes, if that helps?

RSS 2*

I've found that RSS 2 seems to be the best if you're wanting to use this with iTunes, if that helps?

I have found this as well, when publishing a podcast.
For all other use cases, I prefer authoring Atom 1.0. It feels like, because it is newer, it had the benefit of hindsight and was able to smooth over some of the rougher edges of RSS.

The problem is that the biggest data provider on the planet uses Atom to feed it's system of news (Google) but that said they are also smart enough to reformat RSS as Atom before feeding it (I wish more companies normalized like that.)

There is a gigundous amount of prior art here, both as gems and in blog post tutorial form. The top 10 Google results:

batsov recommends Atom.
snaptortoise/jekyll-rss-feeds seems to use RSS 2 / Atom.
agelber/jekyll-rss uses RSS 2.
Drew Inglis recommends RSS 2 / Atom.
Our good friend Joel Glovier also recommends RSS 2 / Atom.
Mikel with the cool last name recommends RSS 2 / Atom.
Mr. Landau here recommends RSS 1, but it's a year old.
Dave Coyle offers templates for both Atom 1.0 and RSS 2.0.
Our dear friend and long-time Jekyll user Zanshin recommends Atom.

For reference, <rss version="2.0" xmlns:atom="http://www.w3.org/2005/Atom"> = "RSS 2 / Atom".
I'd probably err on the side of Atom, as it's a little more formalized than RSS. We could always offer a configuration option (!!!!!! :christmas_tree: your favourite!).
Looks like you're using RSS 2.0, yeah? https://github.com/jekyll/jekyll-rss-feed/blob/master/lib/feed.xml#L6-L13

:+1: on an option, that gives the user the authority.

I was kidding about the option. We have too many options already!

I wasn't kidding about the option, you are forcing a format where no particular format is considered the defacto standard as competing services use competing formats.  iTunes likes RSS, Google likes Atom, Facebook likes both, Yahoo likes RSS, our own services accept both.
I won't comment about the two many options part because it's clear that Jekyll doesn't force convention where convention is needed and options out, but in this case there is no convention that is widely accepted, just "preferences" and the keyword there is what should be done.

you are forcing a format

Using this plugin is opt-in, so we aren't forcing anything. The point is to try to limit the number of choices the users have to make to make a site. Jekyll is already pretty complicated, adding an option would make it even more so.

Your argument is facetious to the fact that this is under the Jekyll umbrella which makes it a defacto plugin that will be used by more than not and you are deliberately gimping people because of a problem in Jekyll while claiming that this is not really a piece of Jekyll because it's opt-in.

this is under the Jekyll umbrella which makes it a defacto plugin that will be used by more than not

:+1:

This argument is outside the scope of this issue now. Convention is better than configuration for new users and old users alike.

I wanted to share this: https://github.com/stve/jekyll-atom
I never release the gem as I was seeking feedback, but it's based off the discussion in jekyll/jekyll-help#7
I'm happy to continue mainting or hand this off if it's found to be useful.

It sounds like Rss 2 / atom gets us the best of both worlds?

I do write my own "damn" Jekyll RSS/Atom plugin that's maintained for people, just like I have to maintain my own "damn" Jekyll fork to give them what they need fixed in Jekyll2 as well and like many programmers who are tired of maintaining these "damn" forks, I was looking for a way to offload it onto something that would do it right but fair enough, I'll stop here as requested good luck with the plugin.

Where does the "/ Atom" come in? Just because the feeds include an <atom:link>?

Both RSS2 and Atom are viable formats. I'm curious, could the gem provide both? I see an advantage to the site having both feeds available, and then letting the consumer of the feed pick whichever they want.

Doing both does sound like a good approach, if laborious. An old prof of mine (@dret) used to study XML and various formats for syndication. I asked him RSS vs. Atom and he said, "Atom, full stop." I asked him to elaborate and he acted like I was crazy and that there was no debate. So there's that. Maybe he'll chime in now that I've copied him.
When does iTunes use RSS? Are we talking about podcasts here? If so, that's a different thing altogether. For podcasts, they do indeed require RSS.

@mlissner I prefer Atom as well, and in our custom CMS it's the only option currently available (for the past 8 years). We're currently looking to add RSS 2 because we've run into issues where various "widgets" (digital signs as an example) that are capable of consuming remote data for display only support RSS. We've only run into it a handful of times, but it does cause an issue now and then.

could the gem provide both

Pending the discussion over in https://github.com/jekyll/jekyll-rss-feed/issues/4, I think that may be the best approach. As it's been stated multiple times here, there's no clear winner, and I don't know that an either/or option does anyone any good (readers or publishers).
How does /feed.xml (RSS2) and /atom.xml output (in parallel) sound?

Where does the "/ Atom" come in

I may have made that up based on @parkr's comment. I'd never heard of it before. But please feel free to drop some knowledge around formats here if you have any (that's why I opened the issue).

I'm happy to continue mainting or hand this off if it's found to be useful.

@stve I googled around, but didn't see your plugin before heading down this (admittedly short) path. Pending the discussion above, what do you think about combining the two efforts into jekyll-feed (dropping the -atom and -rss)? It looks like you you've got a sold atom template, if you could pull request it here, and otherwise the Ruby looks identical (with the need to abstract both to support multiple files if we head that route).

@benbalter if RSS is only needed for iTunes podcasts (which I assume are really out of scope?) and really niche digital signs, I suspect you could get away with only offering Atom. Not that offering both is a terrible idea...

I've yet to convert over to Jekyll, though I'm in the process, but have been following along for a few months. I'd argue that purely from an open source project standpoint, including a core gem/plugin should only include Atom. I don't claim to be an expert, but I know from experience with another open source blogging engine/CMS we decided early on to only support Atom in core because of its solid RFC and standardized spec. For a general overview of the differences, see this comparison.
As previously mentioned, it's still an optional feature, and those with preference or need for RSS 2.0 options are available.

Where does the "/ Atom" come in

I may have made that up based on @parkr's comment. I'd never heard of it before. But please feel free to drop some knowledge around formats here if you have any (that's why I opened the issue).

For reference, <rss version="2.0" xmlns:atom="http://www.w3.org/2005/Atom"> = "RSS 2 / Atom".

This just means that the feed is RSS 2.0, and includes an <atom:link> element (for which there is no equivalent in RSS2). It is not really a best-of-both unicorn, it's just RSS 2.0.

Pending the discussion above, what do you think about combining the two efforts into jekyll-feed (dropping the -atom and -rss)? It looks like you you've got a sold atom template, if you could pull request it here, and otherwise the Ruby looks identical (with the need to abstract both to support multiple files if we head that route).

@benbalter I'd be happy to. I'll try to send a pull request later today.

Hoping to summarize where things are at right now best I can:
Reasons to use RSS

iTunes only supports RSS due to enclosures (but podcasts are not the primary use case for Jekyll or this plugin).
Wide adoption: most people still seem to think of them as RSS feeds (regardless of the standard used), as evidenced by the posts @parkr linked to, many of which didn't even appear to contemplate using Atom (and underscore the need for a plugin which can pull in upstream updates more easily than a blog post).

Reasons to use Atom

Less widely adopted by publishers (but it's unclear if any consumers, e.g., feed readers don't support the standard)
A superior standard in terms of extensibility and future-proofness

Reasons not to use Both

Adds a non-negligible amount of complexity to the code
We should take the time to research the current best-of-breed standard, and if there's a clear winner, make the choice for our users, rather than pushing that complexity on to them.

Suggestion
Unless there's evidence that what we'd expect to be a mainstream consumer of Jekyll feeds (e.g, Feedly, IFTTT, Outlook, etc) doesn't support Atom (which my quick research doesn't seem to suggest is the case), I'm going to suggest we adopt Atom, and only Atom, by adopting @stve's Atom template (and refining it from there as needed).
While RSS seems to be more popular among publishers, perhaps for brand recognition reasons, Atom seems to be the superior technology, with near-equal support, IMHO.

I don't care which way you go, I just wanted to point out that the "non-negligible" seems guessed because that's wholly based on implementation no? So you can't assume unless you actually put it to the 1-3 hour test.

Reasons to use RSS

Plugin can be found when somebody searches for "Jekyll RSS"

As evidenced by the current name of this project, RSS is to feed as Kleenex is to facial tissue.
But, yeah, I'm a big fan of Atom, and I can attest that Feedly and IFTTT both support Atom perfectly well.

They do, and I believe they both format RSS as Atom internally.  Feedly more so because it started out as the alternate to Google Reader which preferred Atoms so they are in bed with it for good I'm to assume.

Does Atom support any features that are not in RSS 2.0? What about vice versa? I know I've encountered problems with RSS-format feeds not including stuff like update timestamps, or Atom's equivalent of <id> to avoid duplicate feed entries.

I know I've encountered problems with RSS-format feeds not including stuff like update timestamps

Me too. This is the main reason why I use Atom only.

+1 for Atom... and more importantly +1 for using only one single format!


chore(docs): add colorSchemes examples to button component

Closes #
📝 Description
Add ColorScheme examples for <Button /> component
⛳ Current behavior (updates)
Current examples for the Button component don't include the possible color variants of the Button component.
🚀 New behavior
Shows examples for every possible color scheme of a Button component.
💣 Is this a breaking change (Yes/No):
No
📝 Additional Information

Beautiful! Thanks again @rezamajidi for opening this PR!
@allcontributors please add @rezamajidi for docs.


Function wasserstein_nms_op not implemented

The question is I found the wasserstein_nms_op function is not implemented, which only leaves a pass.

(The source code is presented here)
This function is used to compute NMS between different boxes using Wasserstein distance, and when I ran the training code it tells me this function is not implemented properly. Is there a problem here?

I meet the same problem?So do you solve it?

I have the same question,do you implement the function yourself?

I have the same question,do you implement the function yourself?

I have the same question,do you implement the function yourself?


Handle undefined and null values

Hello,
I noticed that if the log is either null or undefined, the obj.length === 1 check fails :)
Not sure if this is the desired place to check for that? I would also be reasonable to check for that before calling getMessage.

Seeing the same issue, I think there's an incompatible log in the latest Next.JS version, so this is actually a pretty big problem.

Will get this sorted this afternoon!

This is published in v2.1.1. Thanks @timoweiss!

Thank you @atkinchris ! sorry for the linting/formatting issues


chart not filling-up div

See screenshot
I want the chart to nicely fill up the area. Is this a bug? Or am I doing something wrong?
Thanks!
HTML
<div class="chart-wrapper">
    <chart class="chart" [options]="options"></chart>
</div>

CSS
.chart {
    border: 3px solid yellow;
    width: 100% !important;
}

.chart-wrapper {
    border: 3px solid orangered;
    width: 100% !important;
}

[]

I think this is not the library's issue. Google how to make highcharts chart max width.

You're probably right.... I fixed it by applying "display:block" to the chart div.... Must be the bootstrap class "container" leaking onto your component or something. You may want to add it to the docs though

The main live demo in the readme shows how to do this http://plnkr.co/edit/pnkc8Iw9cSrCYn9zr0VZ?p=preview

do this:
chart {
    width: 100% !important;
    margin: 0 auto;
    display: block;
}

Hi,
If you are burning all midnight oil for this.I would
just suggest to make use existing class of the charts
Which helps to adjust the size of the image
i.e.
.highcharts-root{
width:500px !important;
display:block;
}


Change sometimes printed as "%NaN +%inf %NaN"

Hi! I just tried out criterion, and the first time that I ran my benchmark successfully (without panics) it outputted this:
Benchmarking rb_tree_vecs allocate_exact: Analyzing
rb_tree_vecs allocate_exact
                        time:   [8.0364 us 9.6646 us 11.727 us]
                        change: [   NaN%   +inf%    NaN%] (p = 0.00 < 0.05)
                        Change within noise threshold.
Found 5 outliers among 100 measurements (5.00%)
  3 (3.00%) high mild
  2 (2.00%) high severe

The second time I ran it (with small modifications) it outputted an expected
Benchmarking rb_tree_vecs allocate_exact: Analyzing
rb_tree_vecs allocate_exact
                        time:   [8.1839 us 8.4555 us 8.7618 us]
                        change: [-18.556% -6.5726% +5.6153%] (p = 0.36 > 0.05)
                        No change in performance detected.
Found 8 outliers among 100 measurements (8.00%)
  2 (2.00%) low mild
  4 (4.00%) high mild
  2 (2.00%) high severe

Perhaps something goes wrong when a panic is encountered during a benchmark? Or maybe it's because it was the first benchmark that finished successfully. Anyway, it probably shouldn't at least be printing NaN, and maybe not inf.

Hey, thanks for trying Criterion.rs!
I think it's likely that this was simply a corrupted measurement file, probably caused by https://github.com/japaric/criterion.rs/issues/139. I'd ask you to provide the damaged file, but it will have been deleted by now.
I'm going to close this as a duplicate for now, but if you think that's not correct or if you can find a way to cause it to happen again, please reopen.

Cool, I'll try out the commit later when I can.


Convert to Standard formatting

Closes #60

Fixed merge conflicts.

Oh, need to add support for Mineflayer promises before it can be merged. Ah.


Unitful as a package extension

On 2nd thought, let's keep it Number to support other number types besides Unitful
Here is how I might have tried to do it with extensions, but it may not work anyway:
    _ext = Base.get_extension(@__MODULE__, :MIRTjim_Units)
    if isnothing(_ext)
        const RealU = Real
    else
        const RealU = Union{Real, _ext.Unitful.Length}
    end


Change the link of demo url in About section.

so long

Hi @MadhanDevlpr 🙂
Sorry for replying at this late. Do you need some help or guidance?


Using localStorage with web components

It seems that if you use web components as the elements being sorted that there is a problem with storing their array order.  Even though the array order seems fine, the identifiers never change, it seems that when using the shadow DOM that they can not be organized appropriately the next time the page is refreshed.  If you simply wrap them in a upper level simple element the storage capability works fine.

Сreate example on jsbin.com (draft).


Relax server-side validation for shoot templates

How to categorize this PR?
/area usability ops-productivity
/kind enhancement
What this PR does / why we need it:
Relaxes server-side validation of shoot templates as suggested in #3910.
Which issue(s) this PR fixes:
Fixes #3910
Special notes for your reviewer:
Release note:
It is now possible to specify the shoot purpose as `infrastructure` and to leave the machine image version empty in a ManagedSeedSet's `shootTemplate`.

/cc @timebertt


Provide more examples

Some of these label usages are rather unidiomatic (those for styling) and are better covered by functions. I'm aware that the label docs explicitly state styling as a use case but that should probably be changed instead. In the end, labels are about identification of a specific element rather than styling of a group of related elements. In particular, an element can also only have one label.


Bookstore: Initialize project with components

In this PR. I initialized the bookstore app with components.
Changes

Created and set up a React app
Set up linters
Created components
Added a routing system

Thank you, @VICTOR-CHUKWU.


Upload and play videos in issues - which is a very common need for mobile and frontend devs

Feature Description
Hi, thanks for the wonderful self-hosted git server! It would be great if we could upload videos and play them in the issues page. You know, GitHub does support this, and this is very valuable for mobile or frontend developers to discuss bugs. A live example may be https://github.com/flutter/flutter/issues/103847#issuecomment-1423082608 - we can see that, there are a ton of videos in the issue discussion. Without those videos, it is much harder to discuss.
Screenshots
No response

EDIT: From https://discord.com/channels/322538954119184384/322538954119184384/1078266109976916058, related issue:

https://github.com/go-gitea/gitea/pull/22892

So I can upload videos without problems and my Android phone does play them very well in it's Chrome Browser?
So you just want to embed it?

That should be possible already with "workarounds":
You simply need to upload your video as a normal attachment file, and then write the corresponding <video src="$ATTACHMENT_PATH"> as per that PR.
I don't know why that shouldn't work?

I guess yes! Looking forward to the next release :)


global process events

When downloading several files at a time, the progress callback (for example when using download-status) should notify the progress globally instead of for each individual download progress.

Might be hard to do since everything is done concurrently, i.e all files is downloaded at the same time.

Now that several files can be downloaded concurrently and there's a global tasks array, maybe each one of the downloads instead of emit the events themselves would emit them internally, being the Download manager that listen to them and emit the progress events for the total of them.

Still trying to figure out how to do this now that I'm using got instead of request.

Yes, I've also seen that you removed the events so download-status could be used... :-/

This is still happening in 4.1.0.

Yes, I don't think I'll add global events in the near future.

If it's not possible to have a global progress bar, one for each download would be a good thing, although dificult. It could be done by using store & restore cursor position commands.

Wat. :horse:

Cool, I'll try it later.


Consider examples for "failure" crate?

Recently, Failure was announced (discussions here, also here). Is it too early to think about recipes (equivalent to  error-chain) for it?

@ludwigpacifici Thanks for pointing this out!
Imho we should wait a little before Failure gets more traction and possibly matures a little.
The error-chain crate had a lot of time to mature and enjoyed wide adoption before it got included in cookbook. I'd not want to promote a crate before both community and author are confident enough in the crate API stability (which I'm guessing is quite early for Failure)
@withoutboats might have some thoughts on the subject as far as I know they are working with @aturon on proposed crate list for the cookbook.

So failure has taken the de facto error handling position in the ecosystem.  I think a rip and replace would be reasonable.  Here's something kinda official https://github.com/rust-lang-nursery/failure/issues/181

While failure has gained some popularity I'm not entirely sure it has much development traction as its repo is not super active especially in regard to 1.0. Post the initial release it has been barely updated in crates.io with no releases since Nov 30, 2017 and it looks barely more active than error_chain.
With error_chain still having 2x daily downloads than failure I don't think that we should just decide by ourselves that the idiomatic and production ready error handling in rust is now all about failure.
I'd like to invite wg-ecosystem to the discussion
ping @KodrAus

Thanks @Dylan-DPC!
I can see two issues here:

failure's design is in flux and I feel inclined towards waiting untill things take shape (the same reason why there is no tokio/async chapter yet)
the issue raised in https://github.com/rust-lang-nursery/ecosystem-wg/issues/22. how do we choose the best/most idiomatic crate when there are several equivalent contenders?

failure had a new release fairly recently: https://github.com/rust-lang-nursery/failure/releases/tag/0.1.3.
and it is closing the gap on error-chain wrt. daily and all-time downloads.
My real goal is to get failure into the Rust playground, but I see we have a chicken and egg problem here ;-(

Failure has been deprecated, so this can probably be closed.


Add Event emissions for various actions

We should add logical event emissions with useful data across all contracts in the system. Anytime an action is being taken, we should emit and properly document a useful event.

Thinking of this as event scheme:
Core contracts
L1VotePool.sol
_castVote

CastVote(uint proposalId, uint voteAgainst, uint voteFor, uint voteAbstain)

L2GovernorMetadata.sol
_addProposal

ProposalAdded(uint proposalId, uint voteStart, uint voteEnd)

L2VoteAggregator.sol
initialize

Emit on initialize? In general, consider using openzeppelin-contracts/contracts/proxy/utils/Initializable.sol, or overkill?

castVote

(already exists) VoteCast(address indexed sender, uint proposalId, uint support, uint weight)

bridgeVote

VoteBridged(uint proposalId, uint voteAgainst, uint voteFor, uint voteAbstain)

Wormhole contracts
WormholeL1ERC20Bridge.sol
initialize

Emit on initialize?

deposit

Deposit(address indexed sender, address indexed targetAddress, uint targetChain, uint256 amount, uint deliveryCost)

_withdraw

Withdraw(address indexed account, uint amount)

should we pull more data from the message so we can emit sourceChain, sourceAddress, etc? If we do, should this event be emitted in _receiveWithdrawalWormholeMessages instead?

WormholeL1GovernorMetadataBridge.sol
initialize

Emit on initialize?

bridgeProposalMetadata

BridgeProposalMetadata(uint proposalId, uint voteStart, uint voteEnd, uint targetChain, uint cost, address targetGovernor)

WormholeL1VotePool.sol
No events needed; L1VotePool:_castVote already emits VoteCast
WormholeL2ERC20.sol
initialize

Emit on initialize?

l1Unlock

L1Unlock(address indexed account, address indexed targetAddress, uint256 amount, uint targetChain, address targetToken)

WormholeL2GovernorMetadata.sol
No events needed; L2GovernorMetadata:_addProposal already emits ProposalAdded
WormholeL2VoteAggregator.sol
No events needed; L2VoteAggregator:bridgeVote already emits VoteBriged
WormholeReceiver.sol
setRegisteredSender

RegisteredSenderSet(uint16 sourceChain, indexed address sourceAddress)

receiveWormholeMessages
This is a virtual method, but we could define an event in WormholeReceiver that we expect all descendants to emit.

WormholeMessageReceived(uint16 sourceChain, address sourceAddress, bytes message)

Thinking of this as event scheme:
Core contracts
L1VotePool.sol
_castVote

CastVote(uint indexed proposalId, uint voteAgainst, uint voteFor, uint voteAbstain)

For reference, what OZ uses in their Governor is here
event VoteCast(address indexed voter, uint256 proposalId, uint8 support, uint256 weight, string reason);

We might want to mirror that more closely and do
event VoteCast(address indexed caller, uint proposalId, uint voteAgainst, uint voteFor, uint voteAbstain);

Maybe useful to know who called it? Otherwise can remove it. Also is there one L1VotePool per governor, or is it a singleton? If a singleton we should include the governor address
Consider indexing proposalId in all of these events, not familiar enough with the arch to know if ability to filter events by proposal ID is useful

L2GovernorMetadata.sol
_addProposal

ProposalAdded(uint indexed proposalId, uint voteStart, uint voteEnd)

This means a proposal that already was created on L1 had it's metadata added to the L2 contract? Perhaps the full set of proposal metadata should be included, e.g. proposer, targets, etc.? Or if we only add the required metadata instead of all of it, then the current version makes sense. OZ version for reference.
Similar question about singleton / including governor address

L2VoteAggregator.sol
initialize

Emit on initialize? In general, consider using openzeppelin-contracts/contracts/proxy/utils/Initializable.sol, or overkill?

What happens in initialize vs. construction? Since we're on L2, execution is cheap so we prob don't need minimal proxies. The constructor/initializer should emit "regular" events, such as setting an owner, etc.

castVote

(already exists) VoteCast(address indexed sender, uint indexed proposalId, uint support, uint weight)

bridgeVote

VoteBridged(uint proposalId, uint voteAgainst, uint voteFor, uint voteAbstain)

Same comments as the L1 _castVoteabove here, and consider adding the caller to VoteBridged

Wormhole contracts
WormholeL1ERC20Bridge.sol
initialize

Emit on initialize?

Same answer as above intialize

deposit

Deposit(address indexed sender, address indexed targetAddress, uint targetChain, uint256 amount, uint deliveryCost)

Seems good, consider indexing the targetChain

_withdraw

Withdraw(address indexed account, uint amount)

should we pull more data from the message so we can emit sourceChain, sourceAddress, etc? If we do, should this event be emitted in _receiveWithdrawalWormholeMessages instead?

Gut reaction is that if you have the data available, emitting it may be useful and should be cheap, so may as well
For everything below, no comments aside from what's already been mentioned:

Consider always indexing chains and token addresses (e.g. L1Unlock does not index targetToken)
Consider emitting the caller if that is useful

WormholeL1GovernorMetadataBridge.sol
initialize

Emit on initialize?

bridgeProposalMetadata

BridgeProposalMetadata(uint16 indexed targetChain, address indexed targetGovernor, uint indexed proposalId, uint voteStart, uint voteEnd, uint cost)

WormholeL1VotePool.sol
No events needed; L1VotePool:_castVote already emits VoteCast
WormholeL2ERC20.sol
initialize

Emit on initialize?

l1Unlock

L1Unlock(address indexed account, address indexed targetAddress, uint256 amount, uint16 targetChain, address targetToken)

WormholeL2GovernorMetadata.sol
No events needed; L2GovernorMetadata:_addProposal already emits ProposalAdded
WormholeL2VoteAggregator.sol
No events needed; L2VoteAggregator:bridgeVote already emits VoteBridged
WormholeReceiver.sol
setRegisteredSender

RegisteredSenderSet(uint16 indexed sourceChain, indexed address sourceAddress)

receiveWormholeMessages
This is a virtual method, but we could define an event in WormholeReceiver that we expect all descendants to emit:

WormholeMessageReceived(uint16 indexed sourceChain, address indexed sourceAddress, bytes message)


Readme

You use
% asdf

to show what commands to run as a non-super user. This should be
$ asdf

Should it be, really?
In my shell (and I think zsh in general) it's % asdf (and # asdf for root).
Also, "console" syntaxes (e.g. in pygments) work with %, so it's apparently conventional enough to make it there.

I use zsh, yes, but bash is the default terminal in most unix operating systems. Please use the syntax that is most common. Its just convention

You probably mean "default shell", not terminal, which I think is indeed true.
Personally I like % more, and use these everywhere, so would prefer to keep these, unless it's really bad or confusing, which I'm not convinced it is.
And given that a lot of people actually use zsh as an interactive shell, which you seem to confirm, maybe it's time to change that stupid convention, or at least make it weaker.

Alright sounds fine. Maybe ill start doing that too.


[MODEL]respond_to_missing? to silence Ruby 2.4 warnings

I ran into a bunch of warnings when using Elastic results with
Ruby 2.4+ and trailblazer/cells, because #method_missing? without
#respond_to_missing? makes Forwardable think all of the Result
attributes are private methods.
https://robots.thoughtbot.com/always-define-respond-to-missing-when-overriding

I've signed the CLA.


(suggestion) Theater for 2012 Theme

I found a video that had the theater theme from 2012 turned on for a split second. Heres the original video where it came from: https://www.youtube.com/watch?v=1cLMc5jPpH8

Maybe some time you can implement this, some day. Thank you!

This is an entirely different layout (the mid 2011 beta version of Cosmic Panda) that is currently not planned. A big part of this layout is the ability to choose multiple player sizes on the fly, which is too risky to implement due to how YouTube's modern website works. One update could completely break the layout beyond repair.
Also, supporting theater mode (or anything similar) on pre-2014 layouts would require reworking a significant portion of the extension, and could very likely cause major issues elsewhere, so that's why this is not planned at the moment.


actions: mark-for-op, hours as well as days

When creating a mark-for-op action inside a cloud custodian policy you can define the number of days until the operation is carried out.
How hard would it be to add an optional hours parameter, so that operations could be executed hours after the policy was executed, rather than days? It might also be useful to have a minutes option.
eg.
actions:
  - type: mark-for-op
    op: stop
    hours: 4

sounds good

Thanks you for doing the work to add Hours for mark-for-op.  I wanted to ask about a design decision that caught me a bit by surprise and understand the reasoning behind it.
The use case we are looking to support it to give users ~1 hour to tag their resources within our Sandbox account before those resource were removed.
When generating the current datetime you round down the minutes to "0".
n = datetime.now(tz=self.tz).replace(minute=0)
What this means is that if I set the policy action to something like:
    actions:
      - type: mark-for-op
        op: terminate
        hours: 1

Then the user only has up to the start of the next hour before their instance is eligible for termination. For example, if a user creates an instance at 00:59 UTC, then the instance becomes eligible for termination in 1 minute (i.e. 01:00 UTC).
I wanted to understand why the time is rounded down to the hour. I guess I expected that if I say 4 hours it's not 3 - 4 hours. But maybe there is something I am missing.
I'm happy to submit a PR to change not round down, if that make sense. I've made the change in my own branch already and it seems to work fine, by changing the line to:
n = datetime.now(tz=self.tz)
Thanks again!

OK, I see that when filtering for marked-for-op it only looks like it works if the datetime is rounded to the hour. Still seems to me it would be ideal to have better fidelity now that hours are supported.
Haven't tracked down the code quite yet for this, but happy to make this work with better fidelity assuming it make sense.


horizontal bar graph

is it possible to rotate the bar graph so that the bars are horizontal instead of vertical?

https://github.com/esbullington/react-d3/pull/277


Create an initial set of feature tests

Can use the existing setup structure in the src/test folder.

Initial set of tests are in. Closing this. plan is to continue to contribute new tests as often as fits in the schedule.


Pull request with type [CREATE] for user [Jing099] and object type [ConfigurationItem] - titled [Test CI 2022]

Automated pull request from the Endpoint Configuration Manager Community hub.

drop it