HaneefaNew PR

Checklists
General Checks

[X] the branch is up to date with main/master
[X] the code works when pulled and run locally
[X] All CI checks pass
[x] all conflicts are resolved (if any)
[x] PR has a descriptive title
[x] PR has appropriate labels and milestones for easy identification
[x] PR it is assigned to the owner
[x] reviewers are assigned
[x] the PR contributes only one focused change
[x] It is in the appropriate column in the project board (if necessary)
[x] has short and clear description
[x] is linked to an issue (if it is related)
[x] feedback is addressed (if any and if it is appropriate feedback.)

Markdown

[x] the markdown source is formatted
[x] spelling and grammar is correct in all text
[x] The markdown looks correct when you preview the file
[x] all links and images work
[x] any embedded code snippets are formatted

@danielhalasz As per your comment, I Just pushed only the requested file. Can you check and review please?

@Haneefa-Shaik , very good job.
Some notes:

The title of PR could be Haneefa: Student bio is more clear and descriptive.
Make sure to add Projects, Milestone and link the issue.

Thank you @talmurshidi for your valuable suggestions and i did them.

@Haneefa-Shaik, very good.
Maybe you forget to change the path of the photo because it is not working in your bio file
This is the correct path ![Haneefa](/student-bios/assets/Haneefa-photo.jpg)
Also do not forget to create an issue and link it to this repository and its name could be Haneefa: Create student bio and you can write some details and description for it.

#171 fixed


Add command "version"

This command should read version from package.json (in sync manner):
$ npm-statistic version
  npm-statistic version 1.2.1

Added and tested.


clang: Logic error

Bug Type: Result of operation is garbage or undefined
File: proxy/http/HttpTransact.cc
Function/Method: issue_revalidate

[approve ci clang-analyzer]

I don't think this fixed the issue (see https://ci.trafficserver.apache.org/clang-analyzer/github/3600/2018-05-08-103245-12320-1/)


PowerRename: UI option for changing case

Add an option to change the case of the string.
Leading
UPPER
lower

Agreed.  Needs a way to convert Camel-Case filenames to all lowercase.

Title case would also be appreciated. For the purpose of determining what constitutes a whole word, it should always interpret parentheses, brackets, plusses, tildes, double-quotes, semi-colons, graves, braces, and all but the last dot as whitespace, and with options to interpret underscores and/or dashes as whitespace as well.
TITLE CASE
Do not capitalize:
a, abaft, about, above, afore, after, along, amid, among, an, apud, as, aside, at, atop, below, but, by, circa, down, for, from, given, in, into, lest, like, mid, midst, minus, near, next, of, off, on, onto, out, over, pace, past, per, plus, pro, qua, round, sans, save, since, than, thru, till, times, to, under, until, unto, up, upon, via, vice, with, worth, the, and, nor, or, yet, so
AP TITLE CASE
Do not capitalize:
a, for, so, an, in, the, and, nor, to, at, of, up, but, on, yet, by, or

You could make regex the solution, with the replacement pattern modifiers \u, \l, \U, \L, \E.
I don't think this is in ECMAScript, but it's in PCRE2 & Boost, so it's a well-known regex feature.
https://www.regular-expressions.info/replacecase.html

We just released 0.20 and this should be resolved there.  Please try it out.


Fix webview sample deserializing after an extension update

Issue: webviews that get deserialized will use localResourceRoots from the deserialized extension version.  This means if the extension gets updated by the marketplace, the deserialized webview will use the wrong localResourceRoot by default, causing the deserialized version to fail to load any resources.
If you set the panel.webview.options during the deserialize, you can override it to the new resource roots.
Since this is a sample that others would copy, it seems like good practice to make it clear that extensions which deserialize and limit localResourceRoots should do this. A more involved extension could use this to change their internal build structure but still work across updates.
More context: I put a PR to vscode  (https://github.com/microsoft/vscode/pull/114661) to fix this on the platform side, but it was suggested to do this as an extension-level workaround instead.
How to test this: (a bit involved, we need to simulate an extension update)

Build the cat-coding webview sample extension
Copy the package.json, out, media dirs into a new folder called sample-version1. The package.json has version 0.0.1.
Move this into a folder somewhere called test-ext-dir.
Launch vscode with that as the extensions dir: code --extensions-dir=/path/to/test-ext-dir
Open the webview (cmd-shift-p "cat coding")
Close vscode
Rebuild cat-coding webview with this patch applied, copy it to sample-version2 (keep both versions in the extensions dir)
Relaunch vscode again with the same ext-dir.
without this patch, it would fail to load the js file in the webview (the count would stay at 0). But with the patch, it's able to load the javascript and start counting.

Thanks!

Thanks!


Angular 5 integration

Hi @ricklupton,
Thanks for your great library. It's really awesome.
I would like to integrate it with Angular 5.
Have you tested if this works with Angular 5?
Thanks

Hi, glad you're finding it useful! I haven't used Angular 5, but I think d3-sankey-diagram should work with it just as well as any other d3 library. If you figure out something that would be useful to share, please do.


PR: Resolve issue where splash screen was incorrectly rendered if conda environment is not activated

At startup, add sys.prefix\Librar\bin to os.environ['PATH'] so that Qt will render the splash screen properly on Windows if running in an un-activated environment.
See #22374

Hello @mrclary! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file spyder/app/start.py:

Line 56:1: E402 module level import not at top of file


AccessDenied when publising images on S3

Hi,
I got the following error when running the npx reg-suit run command:
AccessDenied: Access Denied
    at Request.extractError (/home/tocab/Projects/Test/formation-react/node_modules/aws-sdk/lib/services/s3.js:585:35)
    at Request.callListeners (/home/tocab/Projects/Test/formation-react/node_modules/aws-sdk/lib/sequential_executor.js:106:20)
    at Request.emit (/home/tocab/Projects/Test/formation-react/node_modules/aws-sdk/lib/sequential_executor.js:78:10)
    at Request.emit (/home/tocab/Projects/Test/formation-react/node_modules/aws-sdk/lib/request.js:683:14)
    at Request.transition (/home/tocab/Projects/Test/formation-react/node_modules/aws-sdk/lib/request.js:22:10)
    at AcceptorStateMachine.runTo (/home/tocab/Projects/Test/formation-react/node_modules/aws-sdk/lib/state_machine.js:14:12)
    at /home/tocab/Projects/Test/formation-react/node_modules/aws-sdk/lib/state_machine.js:26:10
    at Request.<anonymous> (/home/tocab/Projects/Test/formation-react/node_modules/aws-sdk/lib/request.js:38:9)
    at Request.<anonymous> (/home/tocab/Projects/Test/formation-react/node_modules/aws-sdk/lib/request.js:685:12)
    at Request.callListeners (/home/tocab/Projects/Test/formation-react/node_modules/aws-sdk/lib/sequential_executor.js:116:18)
    at Request.emit (/home/tocab/Projects/Test/formation-react/node_modules/aws-sdk/lib/sequential_executor.js:78:10)
    at Request.emit (/home/tocab/Projects/Test/formation-react/node_modules/aws-sdk/lib/request.js:683:14)
    at Request.transition (/home/tocab/Projects/Test/formation-react/node_modules/aws-sdk/lib/request.js:22:10)
    at AcceptorStateMachine.runTo (/home/tocab/Projects/Test/formation-react/node_modules/aws-sdk/lib/state_machine.js:14:12)
    at /home/tocab/Projects/Test/formation-react/node_modules/aws-sdk/lib/state_machine.js:26:10
    at Request.<anonymous> (/home/tocab/Projects/Test/formation-react/node_modules/aws-sdk/lib/request.js:38:9)
    at Request.<anonymous> (/home/tocab/Projects/Test/formation-react/node_modules/aws-sdk/lib/request.js:685:12)
    at Request.callListeners (/home/tocab/Projects/Test/formation-react/node_modules/aws-sdk/lib/sequential_executor.js:116:18)
    at callNextListener (/home/tocab/Projects/Test/formation-react/node_modules/aws-sdk/lib/sequential_executor.js:96:12)
    at IncomingMessage.onEnd (/home/tocab/Projects/Test/formation-react/node_modules/aws-sdk/lib/event_listeners.js:307:13)
    at IncomingMessage.emit (events.js:205:15)
    at IncomingMessage.EventEmitter.emit (domain.js:471:20) {
  message: 'Access Denied',
  code: 'AccessDenied',
  region: null,
  time: 2019-07-10T09:16:26.196Z,
  requestId: 'ECBE4148B06567A6',
  extendedRequestId: 'MtF0i9hBX7aoPS0SOkAdqnSDiyJFCAxE0TeHn499ahF523r8vgoYK5ISW2+iixiHbtItty/ejMk=',
  cfId: undefined,
  statusCode: 403,
  retryable: false,
  retryDelay: 83.03007054278937
}

But my AWS credentials seems to work fine.
I have created a test file at the root of my project with the following code:
const AWS = require('aws-sdk');
const fs = require('fs');

const s3 = new AWS.S3({apiVersion: '2006-03-01'});

const readStream = fs.createReadStream('./screenshot/index.png');
const params = {
  Bucket: 'reg-suit-59',
  Key: 'image',
  Body: readStream
}
s3.upload(params, function (err, data) {
  if (err) console.log(err, err.stack);
  else     console.log(data);
});

And it has published the image on my S3 bucket.
Here is my regconfig.json file:
{
  "core": {
    "workingDir": ".reg",
    "actualDir": "screenshot",
    "thresholdRate": 0,
    "addIgnore": true,
    "ximgdiff": {
      "invocationType": "client"
    }
  },
  "plugins": {
    "reg-keygen-git-hash-plugin": true,
    "reg-notify-gitlab-plugin": {
      "privateToken": "xxxxxxxxxxxxxxxx"
    },
    "reg-publish-s3-plugin": {
      "bucketName": "reg-suit-59"
    }
  }
}

Thanks in advance for any help.
Regards,

Hi.
Sorry, I’m not familiar with AWS / IAM :bow:
reg-suit S3 plugin uses few S3 APIs:

put object
get object
list object

https://github.com/reg-viz/reg-suit/blob/master/packages/reg-publish-s3-plugin/src/s3-publisher-plugin.ts
Please confirm your AWS IAM user has these permissions :pray:

Thank you for pointing me the code part.
In fact the problem is not about IAM permissions (here my IAM user has full access to S3).
It is more about the default public-read ACL.
When creating a S3 bucket on AWS, the default configuration block the public access.
Deactivating the blocking solved the problem.
Thanks for your support.


565 lab 12 create repair

This Pull Request is for the verification, testing, and approval of both repair sections for Lab 12.
To test the Form Repair, run the ALL application and enter the following url:
localhost:3000/Lab12/Exercise/FormRepair
To test the Database Repair, run the ALL application and enter the following url:
localhost:3000/Lab12/Exercise/DatabaseRepair

[ ] No discrepancies across browsers. Eg. chrome vs safari
[ ] Pages pass W3C Validation for HTML (https://validator.w3.org)
[ ] CSS (https://jigsaw.w3.org/css-validator/)
[ ] Google sign-in is operational
[ ] Accessibility functions
[ ] Pages can scale without distorting page
[ ] No dead links
[ ] Navbar is consistent across the site
[ ] Pages are screen-reader accessible
[ ] Contrast meets standards for accessibility
[ ] Pages are keyboard accessible
[ ] Passes WAVE Evaluation Tool chrome extension

Also merge in dev to this branch and the target branch


Corrupted image URLs

Hi!
Have been testing this, aswell as your plugin, but it does not work at all in my tests.
This is how the image links are rendered in the DOM:
https://{domain}/cdn-cgi/image/width=1536,height=1024,fit=crop,quality=90,gravity=auto,sharpen=1,metadata=none,format=auto,onerror=redirect/wp-content/uploads/2022/11/developers.jpg
And no images are visible.
Is this code still maintained? Saw a similar question in another issue, with no response.

Nevermind, I had not activated image transform for the Zone in cloudflare. Working now.

I`m glad you sorted it.


Generating the bitstream after running command persisting after deleting hls-syn folder

i get the following error after removing the hls-syn when trying to generate the bitstream
when entering: ./make-hw.sh cnvW2A2 pynqZ1-Z2 a
ERROR: [SIM 211-100] 'csim_design' failed: compilation error(s).
INFO: [SIM 211-3] *************** CSIM finish ***************
4
while executing
"source [lindex $::argv 1] "
("uplevel" body line 1)
invoked from within
"uplevel #0 { source [lindex $::argv 1] } "
INFO: [Common 17-206] Exiting vivado_hls at Tue Mar 12 18:41:16 2019...
ERROR: [SIM 211-100] 'csim_design' failed: compilation error(s).
Error in Vivado_HLS

Also having the same issue with the same error message being thrown.

Which Vivado version are you using?

I'm using Vivado version 2018.2, but im only using the 30 day trail version, would that make a difference?

Hello,
Same issue, any suggestion?
Thank you :)

I'm not able to replicate, hardware generation works under RedHat6 with 2018.2. Cna you please attach the log of your error?

As far as I can tell that's the only log of the error that was given when I tried to execute it, but ill give the whole log of the execution if I missed something. Thanks in advanced for the help though its really appreciated.
xilinx-tiny-cnn already cloned
Calling Vivado HLS for hardware synthesis...
****** Vivado(TM) HLS - High-Level Synthesis from C, C++ and SystemC v2018.3 (64-bit)
**** SW Build 2405991 on Thu Dec  6 23:36:41 MST 2018
**** IP Build 2404404 on Fri Dec  7 01:43:56 MST 2018
** Copyright 1986-2018 Xilinx, Inc. All Rights Reserved.
source /home/blinkyang/Documents/AI/Vivado/2018.3/scripts/vivado_hls/hls.tcl -notrace
INFO: [HLS 200-10] Running '/home/blinkyang/Documents/AI/Vivado/2018.3/bin/unwrapped/lnx64.o/vivado_hls'
INFO: [HLS 200-10] For user 'blinkyang' on host 'blinkyang-VirtualBox' (Linux_x86_64 version 4.15.0-46-generic) on Thu Mar 14 13:52:58 EDT 2019
INFO: [HLS 200-10] On os Ubuntu 18.04.2 LTS
INFO: [HLS 200-10] In directory '/home/blinkyang/Documents/AI/BNN-PYNQ-master/bnn/src/network/output/hls-syn'
HLS project: cnvW2A2-pynqZ1-Z2
HW source dir: /home/blinkyang/Documents/AI/BNN-PYNQ-master/bnn/src/network/cnvW2A2/hw
BNN HLS library: /home/blinkyang/Documents/AI/BNN-PYNQ-master/bnn/src/library/hls
INFO: [HLS 200-10] Opening project '/home/blinkyang/Documents/AI/BNN-PYNQ-master/bnn/src/network/output/hls-syn/cnvW2A2-pynqZ1-Z2'.
INFO: [HLS 200-10] Adding design file '/home/blinkyang/Documents/AI/BNN-PYNQ-master/bnn/src/network/cnvW2A2/hw/top.cpp' to the project
INFO: [HLS 200-10] Adding test bench file '/home/blinkyang/Documents/AI/BNN-PYNQ-master/bnn/src/network/cnvW2A2/hw/../sw/main_python.cpp' to the project
INFO: [HLS 200-10] Adding test bench file '/home/blinkyang/Documents/AI/BNN-PYNQ-master/bnn/src/library/host/foldedmv-offload.cpp' to the project
INFO: [HLS 200-10] Adding test bench file '/home/blinkyang/Documents/AI/BNN-PYNQ-master/bnn/src/library/host/rawhls-offload.cpp' to the project
INFO: [HLS 200-10] Opening solution '/home/blinkyang/Documents/AI/BNN-PYNQ-master/bnn/src/network/output/hls-syn/cnvW2A2-pynqZ1-Z2/sol1'.
INFO: [SYN 201-201] Setting up clock 'default' with a period of 5ns.
INFO: [HLS 200-10] Setting target device to 'xc7z020clg400-1'
INFO: [SIM 211-2] *************** CSIM start ***************
INFO: [SIM 211-4] CSIM will launch CLANG as the compiler.
ERROR: [SIM 211-100] 'csim_design' failed: compilation error(s).
INFO: [SIM 211-3] *************** CSIM finish ***************
4
while executing
"source [lindex $::argv 1] "
("uplevel" body line 1)
invoked from within
"uplevel #0 { source [lindex $::argv 1] } "
INFO: [Common 17-206] Exiting vivado_hls at Thu Mar 14 13:53:03 2019...
ERROR: [SIM 211-100] 'csim_design' failed: compilation error(s).
Error in Vivado_HLS

Sorry for all the issues, but I finally got it resolved. After retrying it multiple tiimes, it ended up just being a picky root variable. I ended up setting XILINX_BNN_ROOT to the directory again, but instead of using an indirect reference with "~" i did a direct reference from the home directory and it worked. I'm really grateful for all the help though.

Hi @blinkyang could you please elaborate more on your solution?
I tried your fix(no ~ in the env var) but still having the same error.

echo $XILINX_BNN_ROOT
/home/work/bnn/bnn/src/

Environment is Description:	Ubuntu 18.04.1 LTS
Shell verison: GNU bash, version 4.4.19(1)-release (x86_64-pc-linux-gnu)

Hi @paulr92v, can you elaborate on your error? Is this happening right after a fresh clone?

Hi, Yes it is happening after fresh clone.The fact is that the vivado hls synthesis gave me the same error even from the gui. Actually I think I found the problem: Ubuntu 18.04.1. I tried on Ubuntu 16.04.4 and working correctly.

Hi,
actually Ubuntu 18.04 is not among the supported OS for Vivado Design Suite.

Yes, you are right. Thanks!
Paul

I got it working on Ubuntu 18.04.2 LTS though which is weird, but I just now remembered that I had a fresh Ubuntu OS too, so I also installed build-essentials right before I tried changing the XILINX_BNN_ROOT so that may also be the issue too, but if it works great!

Ok, seems the problem has been solved. Closing the issue now


[BACKEND] Fix regression in pipeliner pre-checks.

During some previous refactoring we changed the logic and started pipeling cases that had incompatible shared encoding. This was missed because one of the lit test had not been updated :(

Thank you! Good catch!


Fix shop and locale id for missing snippets

Description
Please describe your pull request:

Why is it necessary? Otherwise snippets referenced in the code but missing form the .ini files are imported into the database with shopID 111 and localeID 0
What does it improve? Import such snippets with the correct default shopID 1 and localeID 1
Does it have side effects? Nope

Questions
Answers

BC breaks?
no

Tests pass?
yes

How to test?
Execute the test case while reverting the other commits (or copy the test case to a clean shopware 5.2.9), the test will fail

The following unwanted mutations of section will happen with each subsequent run because from 2. onwards array access on a string is performed:

[1,1] (array)
'1:1' (string)
'111' (string)
...

This then ends up in the database as shopID 111 and localeID 0.

hi @samuelvogel
thanks for your PR :+1: there was already a ticket for this problem. I will reference them to each other
http://issues.shopware.com/issues/SW-15132

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-16870.
Please use this issue to track the state of your pull request.

Thanks @samuelvogel. Merged with 27b609683b6ddd90c65e6585d1505ca04f8b8937.


Failed to find button

I've been getting the find button error at 7.6 and above, for GO! and Move On. Had to reinstall 7.5 for it to keep working. (I'm using MuMu Player)

That is strange since I didn't change any button finding code between 7.5 -> 7.6.  Can you enable debug messages for adb and see if there is any difference between a successful find and a fail?

It seems solved, after trying and getting the fail in 7.6, and getting it back at 7.5, I restarted my PC and it got fixed, so I updated again to the last version, and after restartingmy PC the error got fixed. Sorry for the troubles.


Remove second parameter from session.Close

It should be inferred from the internal session state by Close().

Possible duplicate of #86.

I don't think so. #86 is about sending the correct error codes, which involves changes to crypto, parsing, … This issue is about the question when to send connection close frames, which should be auto-detected by session.

Yeah, but it requires a way to set the correct error code within the session, for the Close() method to send them with the ConnectionClose Frame.
So it probably makes sense to fix #86 first.

We already have that! Just return a protocol.QuicError. We just need to use them throughout the server ;)


Preserve swipe gesture when used with react-slick

Awesome component I'd like to integrate with Slick (react-slick). Everything works as or better than expected, except for the touch swipe gesture that is not passed to Slick.
Meaning, when I'm rendering this component as Slick slides, I can't swipe using touch gestures (works with the mouse).
Is there a possible fix for this ? Where should I look for it ? I can't use this component is breaking touch support for Slick which is a must-have for me, but I really want to use it because it's otherwise brilliant.

@Coriou - Sorry you're having trouble. Swipe gestures seem to work for me on the react-slick integration example. Maybe I'm missing something. The react-slick integration example code is here. Let me know what you find.

@ethanselzer - Hey, you're right, it works. I have just spent 3 or 4 hours trying to debug this issue I'm having, without any form of success whatsoever.
I even re-created a Pen, in which the touch swipe gesture works as expected, yet it doesn't work in my project with the exact same code.
I tried removing all of my own style, I tried upgrading / downgrading the versions of the underlying Slick Carousel (both style and JS). I tried moving my component to different parts of my app, I tried having it render as a "top" element (not in any other container)...
Honestly, I feel totally hopeless, I just wasted hours and hours and I still don't have a single clue as to what is wrong.
Don't think it's an issue with this component though, as when I try to reproduce outside of my project it works fine.
If anyone has ANY idea, please feel free to let me know because right now I just don't know what to do...

Hey, I actually was able to reproduce it ! I don't know what changes, again this issue is a complete mystery for me.
I created a test repo with my buggy code. If you run it you will see everything working as expected, except that it will not allow for that swipe carousel gesture from a touch device (will work with the mouse).
Here's a little video of what it does. You will see that when I move my mouse from left to right, or left to right, I'm actually holding down a click trying to swipe from one slide to another but nothing happens. All the other controls are functional and the magnification is also working in place.
Tested with :

simulated touch events in Firefox & Chrome
iOS simulators (iOS 12 only, but tried different devices)
real iOS devices

Do you know which is the latest "working" version @kskonecka ? If not, which version were you using last ? I'd like a downgrade a try when I get a chance.

@Coriou, @kskonecka - Thanks for your great feedback. It has been very helpful. I think the issue may be corrected in v2.7.3. Please have a look.

Hey @ethanselzer, thank you so much for looking into this issue.
As a test, I've bumped the version of my test repo and swipe is working as expected !
I'll make sure to let you know if I have any issues in my real project, however I don't expect any.
Thanks for the great component and support on this issue !
Can close for now

Fixed by v2.7.3


Build fails on OS X

Just a heads up, glium is crapping out on me on both alpha and nightly. It seems like the actual errors are in rust-core-foundation and rust-cocoa.

Thanks for reporting!
This will be fixed with https://github.com/tomaka/glutin/pull/191


Var type

Having a Var data type may be worth including in monix. Something along the lines of:
import monix.execution.{ Ack, Cancelable, Scheduler }
import monix.reactive.{ Observable, OverflowStrategy }
import monix.reactive.observers.Subscriber
import monix.reactive.subjects.ConcurrentSubject

final class Var[A] private (
  initial: A,
  strategy: OverflowStrategy.Synchronous[A]
)(implicit scheduler: Scheduler)
    extends Observable[A] { self =>

  private[this] var value: A   = initial
  private[this] val underlying = ConcurrentSubject.behavior(initial, strategy)

  def unsafeSubscribeFn(subscriber: Subscriber[A]): Cancelable =
    underlying.unsafeSubscribeFn(subscriber)

  def apply(): A =
    self.synchronized(value)

  def `:=`(update: A): Ack =
    self.synchronized {
      value = update
      underlying.onNext(update)
    }

}

object Var {
  def apply[A](
    initial: A,
    strategy: OverflowStrategy.Synchronous[A] = OverflowStrategy.Unbounded
  )(implicit scheduler: Scheduler): Var[A] = {
    new Var[A](initial, strategy)
  }
}

Be aware that when using Var for reactive state management, you will run into frp-glitches like mentioned in #467.


Background masks aren't necessarily in the right place

The background masks should all start at 1.05 times the radius those annuli go out to, and there seems to be big differences between clusters

Actually this was because physical radii were being converted to pixel cases incorrectly in some cases - in the ann_radii function.


outputAbsolutePaths option on command-line don't work

Bug Report

TSLint version: 5.4.3
TypeScript version: 2.4.0
Running via bash

Actual behavior
I run
tslint -p tsconfig.json -c tslint.json --outputAbsolutePaths false "src/**/*.ts"
tslint -p tsconfig.json -c tslint.json --outputAbsolutePaths true "src/**/*.ts"
tslint -p tsconfig.json -c tslint.json --outputAbsolutePaths 1 "src/**/*.ts"
tslint -p tsconfig.json -c tslint.json --outputAbsolutePaths 0 "src/**/*.ts"
tslint -p tsconfig.json -c tslint.json --outputAbsolutePaths "src/**/*.ts"

Allways return absolute path on report:
/home/myuser/project/src/app/products/gondolaprices/components/somescript.ts
ERROR: 39:13   strict-boolean-expressions  This type is not allowed in the 'if' condition because it is always truthy. It may be null/undefined, but neither 'allow-null-union' nor 'allow-undefined-union' is set. Only booleans are allowed.

Expected behavior
src/app/products/gondolaprices/components/somescript.ts
ERROR: 39:13   strict-boolean-expressions  This type is not allowed in the 'if' condition because it is always truthy. It may be null/undefined, but neither 'allow-null-union' nor 'allow-undefined-union' is set. Only booleans are allowed.

--outputAbsolutePaths has no options, so you cannot explicitly disable it. You disable absolute paths (and therefore implicitly enable relative paths) by just omitting --outputAbsolutePaths.
If tslint -p tsconfig.json -c tslint.json "src/**/*.ts" does not print relative paths, that would be a bug.

Great! I update to  version 4.5.1 and problem solved! :)
./node_modules/.bin/tslint -p tsconfig.json -c tslint.json -t stylish "src/**/*.ts"


sort/import default is not good.

First of all, this package is so underrated. The sorting works. I like it.
Perhaps, the sort/import rule default was a bummer. It has butchered my imports in the worst possible way. I wanted to turn it off, but as I look at the docs, there is the group option. That one, I really like it as well. Maybe the group option should be the default?
Is it possible to add react group? Where I can put react at the top?

Thanks for the kind words 🙂

Perhaps, the sort/import rule default was a bummer.

The main reason I didn't add a default is I don't know the various sorting preferences of different people and want to leave it up to them rather than enforcing something specific.

Is it possible to add react group? Where I can put react at the top?

Do you mean always having react as the first import?  If so, you could add a sort group with a regex expression to target react and set it's order to 1.
{ "regex": "^react$", "order": 1 }

Can you double check on this:
"sort/imports": [
    "warn",
    {
      "groups": [
        {
          "type": "side-effect",
          "order": 3
        },
        {
          "regex": "\\.(png|jpg|svg)$",
          "order": 5
        },
        {
          "type": "dependency",
          "order": 2
        },
        {
          "type": "other",
          "order": 4
        },
        { "regex": "^react$",
          "order": 1
        }
      ]
    }
  ]

As It doesn't put react to the top.

Group order is extremely important and the reason why your example isn't working.  When the plugin determines which sort group an import falls in, it will match sort groups top to bottom in the array and use the first matching sort group.  In your example, a react  import will be captured by the dependency sort group, so it will never get to the regex sort group your defined.
If you configure your sort groups like this it will work.
"sort/imports": [
    "warn",
    {
      "groups": [
        {
          "type": "side-effect",
          "order": 3
        },
        {
          "regex": "\\.(png|jpg|svg)$",
          "order": 5
        },
        { "regex": "^react$",
          "order": 1
        },
        {
          "type": "dependency",
          "order": 2
        },
        {
          "type": "other",
          "order": 4
        }
      ]
    }
  ]

https://github.com/mskelton/eslint-plugin-sort/blob/main/docs/rules/imports.md#group-order

The groups' order is important. Noted. the code works too. I'm closing this.


Query Profiles Error

Describe the bug
After I launch  a drillbit from Eclipse (See tutorial here: https://github.com/paul-rogers/drill/wiki/Launch-a-Drillbit-From-Eclipse), I logged into localhost:8047 to see if Drill functions well, and basically it did. But when I submitted a query and click the tag "Profile" to see the profile of this query, a error with error message was reported:
RESOURCE ERROR: Failed to get profiles from persistent or ephemeral store.\n\n\n[Error Id: f4c362c7-124d-452a-a209-82633ca6098e ]

Fortunately, I fixed this problem by chance, and the operation is quite simple: open the debug configuration of Eclipse, then add DRILL_LOG_DIR =/a path directed to a certain directory in the Environment tab. However, I can not see underlying relationship between the two things, so I deemed this as a bug and report it here.
Desktop (please complete the following information):

OS: Ubuntu 20.04.3 LTS
Browser: Firefox
Version: Drill 1.20 snapshot

@jnturton Can we close this issue?

I've added this information to the relevant Dev wiki page, thank you for sharing it.


implement 'defaultLiteral' for type: literal

in some of the ValueConstraints hash ("default"), there is a type literal, while having a defaultLiteral.

in a separate commit can also have logic to deal with fields for repeatable``mandatory and editable. If they are not defined then the defaults are:
Repeatable is true, mandatory is false, and editable is true.


DOC-2498: Add docs_area to Deploy docs

Fixes DOC-2498

This change is

Closing as this has been incorporated in https://github.com/cockroachdb/docs/pull/12950


TTS: Unclear / Inconsistent behavior of nesting prosody

Request
this is a copy of https://github.com/Azure-Samples/Cognitive-Speech-TTS/issues/295 since I got no response there, I thought that repo was not in use anymore
Need clarification and / or documentation on expected TTS behavior with prosody tag, applying different settings to different parts of a prompt.
Nesting prosody with different combinations seems to apply the properties to a complete prompt (rate & pitch), while in other cases it seems to work as expected (rate & contour).
If you could clarify and explain what the expected behavior and recommended usage is, it would help produce correct SSML from our application in various scenarios.
Context
The goal is to have a faster/slower voice, and still allow prosody adjustments on individual words or sentences.
According to the documentation, prosody is a valid tag inside of prosody: https://learn.microsoft.com/en-us/azure/ai-services/speech-service/speech-synthesis-markup-voice#adjust-prosody
All tests are performed in the Speech Studio, the actual use case is an application via the JavaScript SDK.
Flattening and merging prosody tags is something we would ideally like to avoid to save the effort
Case 1: Rate & Pitch
extreme values are used for demonstration purposes
Prompt description

Say "Hello. How are you doing?" in English
Applying -20% rate
"How are you doing?" should have a pitch "+30%"

Test case
Using the following SSML, we can test

Nesting the pitch change inside of the rate tag (manually created)
Using the Speech Studio UI, a flat prosody structure is produced

<speak xmlns="http://www.w3.org/2001/10/synthesis" xmlns:mstts="http://www.w3.org/2001/mstts" xmlns:emo="http://www.w3.org/2009/10/emotionml" version="1.0" xml:lang="en-US"><voice name="en-US-JennyNeural"><bookmark mark="nested" />
<prosody rate="-20.00%">Hello. <prosody pitch="+30%">How are you doing?</prosody></prosody>
<bookmark mark="flat" />
<prosody rate="-20.00%">Hello. </prosody><prosody rate="-20.00%" pitch="+30.00%">How are you doing?</prosody>
</voice></speak>

Result

The nested SSML applies the pitch change to the full paragraph.
The flat SSML applies the rate correctly only to the wrapped sentence

Expectation
Both produce the same result.
Case 2: Rate & Contour
Prompt description

Applying -20% rate
Custom contour on "Verstanden."

Test case
Using the following SSML, we can test

Original pronunciation without contour (baseline)
Nesting the cntour change inside of the rate tag (manually created)
Using the Speech Studio UI, a flat prosody structure is produced

<speak xmlns="http://www.w3.org/2001/10/synthesis" xmlns:mstts="http://www.w3.org/2001/mstts" xmlns:emo="http://www.w3.org/2009/10/emotionml" version="1.0" xml:lang="de-DE"><voice name="de-DE-KatjaNeural">
<bookmark mark="no contour" />
<prosody pitch="-20.00%">Alles klar was geht ab bei dir. Verstanden.</prosody>
<bookmark mark="nested" />
<prosody pitch="-20.00%">Alles klar was geht ab bei dir. <prosody contour="(8%, +85%) (47%, -10%) (100%, -18%)">Verstanden.</prosody></prosody>
<bookmark mark="flat" />
<prosody pitch="-20.00%">Alles klar was geht ab bei dir. </prosody><prosody pitch="-20.00%" contour="(8%, +85%) (47%, -10%) (100%, -18%)">Verstanden.</prosody></voice></speak>

Result
Both contour variations seem to produce the same results

@lukas-parloa thank you for using Azure Speech and raise this issue.
@Kerry-LinZhang could you help to triage?

Thanks for the feedback,
let me make it clear:

both pitch and rate tag are expected to be applied to the full paragraph, right? @lukas-parloa
for the inconsistent behavior of nesting prosody reported in 【Case 2: Rate & Contour】 @newhillchan could you please take a look

Hi @lukas-parloa issue is under investigation, I will keep you updated for the progress

investigation ETA 9/15

Hi @lukas-parloa it seems we cannot repro it now, would you please double confirm it, and if you can still repro the issue, please send us again the SSML, thanks a lot.

Well received, keep tracking on it, will keep you updated for it

Debug ongoing, these two tags should have the same behavior.

Tracking with owner for it

@Kerry-LinZhang Any update by now?

Closing as unsupported because of no update since November. @Kerry-LinZhang @yulin-li FYI


Change docs format from HTML to Markdown

This change vastly simplifies the future work of bringing the JavaHamcrest wiki pages into the website (this will be in a future pull request).
This pull request changes the documentation format from HTML to Markdown, and using Jekyll to generate static HTML from the Markdown. For more details on this, see the GitHub reference "Using Jekyll as a static site generator with GitHub Pages".
The intent of this specific change is to exactly duplicate the existing look and feel of the website. You can verify this by comparing the sites side-by-side:

Original HTML site: hamcrest.org/JavaHamcrest/
Updated Markdown site: tumbarumba.github.io/JavaHamcrest/

This sounds great! Fancy doing JMock? ;-)

Thanks! I'm assuming your comment was also a +1, so I've merged this.
I haven't used JMock for a while, but I'm sure I can have a look at some stage. Let me finish messing around with the Hamcrest docs first :-)


[Services 5] Relocate Service Containers

This PR only moves files and updates any relevant import paths.
All containers are now located in - js/containers

@MatApple please rebase so that we can keep the merge train rolling... 🚂


Troubleshoot bug 1087

This fixes #1087. It changes the Bazel builds to link all our dependencies
against the same SSL version (BoringSSL). It compiles libcurl from source,
which is consistent with out Bazel works in general, and forces libcurl to link
against the same BoringSSL version.
To reproduce the problem I created an example using both Cloud Bigtable
and Google Cloud Storage. I believe this example should be preserved because
it is useful in its own right.
When compiling against BoringSSL the implementation of base64 encoding and
decoding in the storage client is completely different, because BoringSSL has
retired some of the functions we needed (BIO_f_base64() for example).

This change is

/cc: @drethage

PTAL. This is ready for review now.


📊 Adding UN IGME dataset

@Marigold Random question - my VScode seems to have reformatted dag/main.yml so that the steps for each recipe are indented. Is that a big problem or is it okay to merge it like this? Not sure why it has happened..

@spoonerf Go for it, leading spaces before - are apparently the best practice for YAML files. VSCode would format it similarly for me.


Fix: XDG_CONFIG_HOME compatible

Per the Issue creationix/nvm#1088
I haven't really tried it, so would be good if someone tried it at least.

I'm still not clear why the folder name should be "nvm" and not ".nvm" inside the XDG config folder. Can you explain?

Going by what i'm currently seeing my own $XDG_CONFIG_HOME, this is it:
(venv) lilja in ~ on master % ls -al .config/
total 0
drwx------   6 lilja  lilja   192 Nov 21  2017 .
drwxr-xr-x+ 64 lilja  lilja  2048 Aug 15 09:36 ..
drwx------   6 lilja  lilja   192 Aug 13 16:35 configstore
drwx------   3 lilja  lilja    96 Mar  8 13:48 gtk-2.0
drwxr-xr-x   6 lilja  lilja   192 Dec 27  2017 timelogs
drwxr-xr-x   4 lilja  lilja   128 Nov  6  2017 yarn

Granted I don't have a lot of folders here, but there doesn't seem to be any folders that keep the dot-prefix before the folder names here.

Interesting; I'm not super familiar with XDG but if that's the convention then that's fine.

Don't understand why the other test cases are failing. Could anyone help me out?

I've got a fix in your PR #1891, thanks. Will merge once that's passed.

Anything else you need for a merge?


improving UI of the form and adding storage features✨

i want to improve the  UI of the form and adding storage features. @vishanurag can you assign me this issue.

Please assign this issue to me @vishanurag


Create general Block Cipher Modes of Operations

When I was first adding features to Gestalt like AES, I didn't future proof and make general Block Cipher Modes of Operation functions like ECB, CBC, CTR, etc. Currently we have those modes of operations but they are block cipher specific. For example in src/lib.cpp:
void Message::aes_encrypt_ecb(std::string key)
{
	size_t msgLen = msg.length();
	size_t paddedMsgLen = msgLen + 16 - (msgLen % 16);
	unsigned char* input = new unsigned char[paddedMsgLen];
	std::memcpy(input, msg.c_str(), msgLen);

	applyPCKS7Padding(input, msgLen, paddedMsgLen);
	AES aesObject(key);

	for (size_t blockIndex = 0; blockIndex < paddedMsgLen; blockIndex += 16) {
		aesObject.encryptBlock(input + blockIndex);
	}

	msg.assign(reinterpret_cast<char*>(input), paddedMsgLen);

	delete[] input;
}

So whenever we eventually add more block ciphers like DES, 3DES, ChaCha20, etc. We would also have to create specified functions to perform each mode of operation for each block cipher, which would be tedious and balloon the code unnecessarily. I propose we do something similar to how OpenSSL/ BoringSSL does it, for exmaple:
void CRYPTO_cbc128_encrypt(const unsigned char *in, unsigned char *out,
                           size_t len, const void *key,
                           unsigned char ivec[16], block128_f block)
{
    size_t n;
    const unsigned char *iv = ivec;

    if (len == 0)
        return;

#if !defined(OPENSSL_SMALL_FOOTPRINT)
    if (STRICT_ALIGNMENT &&
        ((size_t)in | (size_t)out | (size_t)ivec) % sizeof(size_t) != 0) {
        while (len >= 16) {
            for (n = 0; n < 16; ++n)
                out[n] = in[n] ^ iv[n];
            (*block) (out, out, key);
            iv = out;
            len -= 16;
            in += 16;
            out += 16;
        }
    } else {
        while (len >= 16) {
            for (n = 0; n < 16; n += sizeof(size_t))
                *(size_t_aX *)(out + n) =
                    *(size_t_aX *)(in + n) ^ *(size_t_aX *)(iv + n);
            (*block) (out, out, key);
            iv = out;
            len -= 16;
            in += 16;
            out += 16;
        }
    }

...

If you know another way/ better way I'm not set on the way OpenSSL/ BoringSSL does this. As long as it works as intended, and is simple.

Here is a comprehensive list of the block cipher modes of operations I believe would be good to add to Gestalt:

ECB (needs to be parallelized)
CBC (decryption needs to be parallelized)
CTR (parallelized)
CFB
OFB

To implement these is is highly encouraged to use and reference the sp800-38a NIST standard, and try to use the same naming convention of functions and variables as in sp800 38a. Also keep similar documentation as is in the standard
Along with the authentication modes of operation AES methods:

CMAC
AES-CCM
AES-GCM

To implement these is is highly encouraged to use and reference the sp800-38b, sp800-38c, and sp800-38d NIST standards respectively, and try to use the same naming convention of functions and variables as in these standards. Also keep similar documentation as is in the standard


Release 1.2.1

Coverage decreased (-0.2%) to 94.625% when pulling 6a7c5bb1e66270fbd87cb3c29f38c91dddedd38d on develop into 2f7208768205649899fa50fb8e82fcacabae670b on main.


Add Support For Set Types In Config Beans

Currently, one can create a Config from a bean whose fields are based on such primitive types as List, Map or even a raw Config. However, it doesn't support the Set collection type yet.
In the pull request that will follow, we propose piggy-backing on ConfigBeanImpl#getListValue to support the `Set type.

Fixed in #496


code broken when not run in US CDT timezone

The graph annotations are mostly wrong! We hate timezones. Will fix asap

fixed - needed to add 'tz' to annotations


issue-1950: add separate references to england and wales

Description
fibo-be-ge-ukj:EnglandAndWalesJurisdiction declares fibo-fnd-law-jur:hasReach
lcc-3166-2-gb:EnglandAndWales, which I could not find. So in this branch I replaced it with two references to both England and Wales individually.
Fixes: #1950
Checklist:

[x] I'm familiar with the FIBO developer quide. My contribution meets all the requirements described there.
[x] My contribution follows the principles of best practices for FIBO.
[x] My changes have been reconciled with latest master and no merge conflicts remain.
[x] This PR is related to exactly one issue. The issue is referenced by using a GitHub keyword such as "fixes", "closes", or "resolves".
[x] Hygiene tests have been applied by a PR with "(WIP)" in title.
[x] The issue has been tested locally using a reasoner (for ontology changes).

@mereolog this PR passed hygiene tests despite using a non-existent reference to LCC &lcc-3166-2-gb;England. Can those not be checked? Either by live access or by using a cached copy of LCC (it rarely changes).

@aamedina Hi Adrian, I still use the aliases - Pete implemented the code based subdivisions for a number of reasons, including but not limited to ease of use for programmers. However, the aliases will remain due to requirements for them by business users in a number of domain areas. I'm actually fine with the way that you had it, but our rules state that we need two approvals.
Note that there are metadata changes I would like to see: (1) add a change note, referencing this issue and stating what was changed, and (2) revise the version IRI to '20230701'.
Thanks!
Elisa

@mereolog this PR passed hygiene tests despite using a non-existent reference to LCC &lcc-3166-2-gb;England. Can those not be checked? Either by live access or by using a cached copy of LCC (it rarely changes).

We do not check resources outside the 'edmcouncil' domain.
As far as I can tell we never did - probably because we do not have governance over "external resources".
I think I can add an additional check where all resources are checked for their types - but it will produce just warnings. Otherwise, I suspect that we shortly will have to turn it off because it will block the ontology development.

I think this just another review from @rivettp? Anything on my end that needs to happen?

I think this just another review from @rivettp? Anything on my end that needs to happen?

Hi Adrian, if you would please merge the master branch back into this one, it should (in theory) run back through all of the checks. If Pete doesn't have time to re-approve this, @mereolog can do so. I think this is the last issue we will be addressing before the 2023 Q3 release, FYI. Thanks for checking!

Hmm, can you try re-running the build? Looks like there was an issue with pulling the docker image in Jenkins. Maybe cold booting?
docker pull "$JD_TO_PULL"— Shell Script10s

+ docker pull edmcouncil/ontology-publisher:stable

Error response from daemon: Head "https://registry-1.docker.io/v2/edmcouncil/ontology-publisher/manifests/stable": received unexpected HTTP status: 503 Service Unavailable

script returned exit code 1


upload: fix flags

Codecov Report

Merging #858 (0f4ba58) into master (0fcb72e) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 0f4ba58 differs from pull request most recent head 66307cf. Consider uploading reports for the commit 66307cf to get more accurate results

@@           Coverage Diff           @@
##           master     #858   +/-   ##
=======================================
  Coverage   83.08%   83.08%
=======================================
  Files          47       47
  Lines        3257     3257
=======================================
  Hits         2706     2706
  Misses        419      419
  Partials      132      132


[Doc Improvement][Update meeting API reference]

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/apps-in-teams-meetings/API-references.md
92
24
link
:white_check_mark:

msteams-platform/apps-in-teams-meetings/create-apps-for-teams-meetings.md
98
2
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 2e416a8:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/API-references.md
:white_check_mark:Succeeded
View

msteams-platform/apps-in-teams-meetings/create-apps-for-teams-meetings.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@surbhigupta12, the doc is linked to PR 5185. We have received approval from Wajeed on the same.


Add links back to project on project sub pages

[ ] Unbilled expenses page
[ ] Add expenses page
[ ] Ticket pages
[ ] Invoice pages
[ ] Approve account page
[ ] Possibly others, any page that is about a specific project

                        Back to project details <FontAwesomeIcon icon={faArrowLeft} />

i want this code to be put on all those pages, there is probably a smart way for me to do this by making a new variable or something right? it would also need the Font awesome import
 import { FontAwesomeIcon } from "@fortawesome/react-fontawesome"; import { faArrowLeft } from "@fortawesome/free-solid-svg-icons";
It wou

[ ] Unbilled expense page title should read Un-billed expense "Un-billed Expenses for Project 10 ($92.00 total)" where Project 10 is a link to the project details page UnBilledExpenses.tsx
[ ] Adding an expense to a project needs a similar treatment, the title should read "Add Expense for Project 8" Where project 8 is a link to the details page
[ ] The component ReturnToProject should not be viewable while on the project details page


audit: check for version aliases.

Current version aliases should be provided for versioned formulae so people can brew install<EMAIL_ADDRESS>to provide pin-like behaviour.
Another attempt at #1850 (reverted in #2088) with the brew readall changes split into another (incoming) PR.

Note that the problem last time was that it wasn't tested when HOMEBREW_DEVELOPER is not set. Did you have a chance to test this without that set?

@ilovezfs This has entirely removed all the brew readall changes.


Update dependencies to (also) support<EMAIL_ADDRESS>

Addresses #202, #203 by also supporting Svelte 4 (and latest kit).
In our testing there have been no adverse effects after the upgrade, this simply stops having to use npm install --force to restore in a project.

Thank you, will test this on the browser test suite, if everything checks out there will be a patch version within a day or so.


opentracing support

similar to https://github.com/zalando-zmon/zmon-worker/pull/317
needs same fix when opentracing_utils is done

Please update README badges:
.. image:: https://img.shields.io/badge/OpenTracing-enabled-blue.svg
   :target: http://opentracing.io
   :alt: OpenTracing enabled

:+1:

👍


fix the integration tests for compares with very large differences.

the problem:
i have a very large difference set when I run the integration tests. It looks like my PNGs are being build with a transparent background while the refs have a solid white background.
So when I ran the integration tests I got this error:
Rendering /ddi/xhtml2pdf/git/xhtml2pdf/testrender/data/source/test-list.html
Traceback (most recent call last):
File "./testrender.py", line 269, in
main()
File "./testrender.py", line 213, in main
pdf, pages, diff = render_file(filename, output_dir, ref_dir, options)
File "./testrender.py", line 101, in render_file
output_dir, options)
File "./testrender.py", line 56, in create_diff_image
diff_value = int((result.strip()))
ValueError: invalid literal for int() with base 10: '2.15983e+06'
instead of this:
Rendering /ddi/xhtml2pdf/git/xhtml2pdf/testrender/data/source/test-list.html
Image /ddi/xhtml2pdf/git/xhtml2pdf/testrender/output/test-list.page0.png differs from reference, value is 2159830
the fix:
use the decimal module to handle the different count, as a very large difference count wil come back as an exponent in a string, which int can not handle

Thanks for fixing this! And sorry about the long wait!


Alt and FLush methods called in VAICOMPRO.export.lua are not implemented

In dcs.log there appear several error messages like these:
ERROR   Lua::Config (Main): Call error LuaExportBeforeNextFrame:[string "C:\Users\tbari\Saved Games\DCS.openbeta\Scripts\VAICOMPRO\VAICOMPRO.export.lua"]:61: attempt to call method 'Alt' (a nil value)
stack traceback:
[C]: in function 'Alt'
[string "C:\Users\tbari\Saved Games\DCS.openbeta\Scripts\VAICOMPRO\VAICOMPRO.export.lua"]:61: in function 'BeforeNextFrame'
[string "C:\Users\tbari\Saved Games\DCS.openbeta\Scripts\VAICOMPRO\VAICOMPRO.export.lua"]:110: in function <[string "C:\Users\tbari\Saved Games\DCS.openbeta\Scripts\VAICOMPRO\VAICOMPRO.export.lua"]:109>
Lua::Config (Main): Call error LuaExportAfterNextFrame:[string "C:\Users\tbari\Saved Games\DCS.openbeta\Scripts\VAICOMPRO\VAICOMPRO.export.lua"]:72: attempt to call method 'Flush' (a nil value)
stack traceback:
[C]: in function 'Flush'
[string "C:\Users\tbari\Saved Games\DCS.openbeta\Scripts\VAICOMPRO\VAICOMPRO.export.lua"]:72: in function 'AfterNextFrame'
[string "C:\Users\tbari\Saved Games\DCS.openbeta\Scripts\VAICOMPRO\VAICOMPRO.export.lua"]:119: in function <[string "C:\Users\tbari\Saved Games\DCS.openbeta\Scripts\VAICOMPRO\VAICOMPRO.export.lua"]:118>.
It seems like Methods Alt and FLush are not implemented.
I remmed out those calls and errors don't appear any more but I'm not sure this is the right way.
Thanks

Please edit your title to be more descriptive than "bug"

Thanks, they are a left over from the previous implementation prior to the DX loop. Will look to find the calls and remove them. You can ignore the error for now.

Many thanks

Removed in latest build <IP_ADDRESS>


Service Integration Guidelines

Hi there, thanks for this amazing project.
I'm looking for how an external contributor could integrate an external service and how to properly propose and submit the work.
Would be very nice to have a detailed walkthrough on how to do that and especially what are the limitations/boundaries to follow.
I just searched for past issues/discussion (eg. BTCPay Integration issue) and from what I got from there, I have some questions:

I'm right saying that the way to do it is to write a custom bash script?
The application/service must be compiled from source or it is acceptable to pull down already pre-built binaries for ARM? Is it running a Docker container allowed?
what is the policy for outbound connections? For Blockchain data sourcing, is acceptable to fetch from APIs (eg. from block explorers) or the project imposes to lookup from the services already present?
For inbound connections to expose the service, what's the policy to follow? (eg. Reverse Proxy on host/<service_name> ) A new entry should be added to the already existent Nginx webserver (I got it from looking at the BTCPat Server installer script) or the service should expose his own web server and How to avoid namespace collisions with others?
There is a sandbox/virtualized image to run the tests against? or a physical device should be used?

I think it really make sense to collect some guidelines.
From the top of my head I can at least partially answer some of the raised questions

Yes. Have a look at the bonus.* files in home.admin/config.scripts (in the repo).
Currently we do not officially use docker. While I'm not entirely sure I believe that the fact that we still regard the Raspberry Pi 3 (1GB) as a supported platform plays a role here.
In general outbound connections must be opt-in. A user needs to beware of this and activate it herself.
If the service to be integrated has a web interface then we are currently switching to make sure that this is running on one unique port on localhost. Remote access should default to be made via Tor (Browser). Nginx as a reverse proxy helps to solve certain issues (e.g. with certificates).
I'm not aware of a sandbox. I develop in parts in a Windows IDE, a Linux VM (am64) - but always do integration and testing on the physical device.

About point 2, it's ok to download pre-compiled binaries then? @frennkie

I would say that we strongly prefer to not use binaries that are pre built unless there is a strong way to gain trust that it's not tampered with. The best example here is that both bitcoind and lndare being downloaded as binaries (and then checksums are checked). We also trust stuff installed withapt-get install`. But there are also some existing examples where the apps are compiled (even if this take 20+ minutes).

Thanks for the swift response. It's much more clear now. I'll try to do my best


Better unpacked dump detection

PendingRestore::hasNoDbDumpsDirectory checks for any type of files
PendingRestore::getAvailableDbDumps checks for dumps only

There are few ways to solve the issue. This PR uses PendingRestore::getAvailableDbDumps to check existence of dumps; another way - add the same file extension filter to PendingRestore::hasNoDbDumpsDirectory. I prefer the current approach to make codebase smaller and do not repeat the logic. But I'm ok to fix PendingRestore::hasNoDbDumpsDirectory if you think it's better.
BTW, it was the only usage of PendingRestore::hasNoDbDumpsDirectory. I haven't removed this method because it was public and not marked as @internal (which means it will be BC break).

PS: I discovered this issue debugging my CI check (probably caused by the DB connection misconfiguration), the message was really confusing:

"dumps" is plural because it should be plural for zero :)
PPS: How about listing all extracted files in the NoDatabaseDumpsFound message? This will improve debugging experience a lot. I can create a PR.

PS: I discovered this issue debugging my CI check (probably caused by the DB connection misconfiguration), the message was really confusing:
"dumps" is plural because it should be plural for zero :)

From your comment I'm not sure if this is just a comment for your specific project, or if you see this as an issue for this package.
The "Importing database dumps …" message is only shown when dumps are available to import.
Or is this all related to the other PR of yours (#61) and the message was shown to you because you use bz2 for your dumps?

Hey @stefanzweifel

From your comment I'm not sure if this is just a comment for your specific project, or if you see this as an issue for this package.

sorry for not being clear.

The "Importing database dumps …" message is only shown when dumps are available to import.

not exactly. Firstly, both my PRs fixed this issue, but from different angles :)
Previous code called PendingRestore::hasNoDbDumpsDirectory  that returned false: there are .bz2 in the dir.
Then str()->plural($dumps) called where $dumps is an empty array (or Collection—I don't remember). Why empty - because PendingRestore::hasNoDbDumpsDirectory checks for ANY files, PendingRestore::getAvailableDbDumps takes into account file ext (and .bz2 was missing in the list).


Adding stuff

@parakhj : Thanks for your contribution! The author, @davidmu1, has been notified to review your proposed change.

@parakhj : Thanks for your contribution! The author, @davidmu1, has been notified to review your proposed change.


Fix error in running example inference for add_sub_notebook

When I follow the add_sub_notebook to try PyTriton, I meet this error in the following cell:
with ModelClient("localhost", "AddSub") as client:
    result_batch = client.infer_batch(a_batch, b_batch)

for output_name, data_batch in result_batch.items():
    print(f"{output_name}: {data_batch.tolist()}")

The error logs can be found below:
Error occurred during calling model callable: Traceback (most recent call last):
  File "/home/xiaodongye/miniconda3/envs/pytorch_source/lib/python3.8/site-packages/pytriton/proxy/inference_handler.py", line 117, in run
    outputs = self._model_callable(inputs)
TypeError: _add_sub() takes 0 positional arguments but 1 was given

After adding @batch to _add_sub, the issue is gone.

Thank you for your contribution, R0CKSTAR. I appreciate your effort to fix our notebook. However, before I can accept your pull request, I need you to sign the Contributor License Agreement (CLA) and send it to<EMAIL_ADDRESS>The CLA is available for download here: https://github.com/triton-inference-server/server/blob/main/Triton-CCLA-v1.pdf
I apologize for any inconvenience this may cause you. I hope to hear from you soon and merge your patch. If you have any questions or concerns, please let me know.

Thank you for your contribution, R0CKSTAR. I appreciate your effort to fix our notebook. However, before I can accept your pull request, I need you to sign the Contributor License Agreement (CLA) and send it to<EMAIL_ADDRESS>The CLA is available for download here: https://github.com/triton-inference-server/server/blob/main/Triton-CCLA-v1.pdf
I apologize for any inconvenience this may cause you. I hope to hear from you soon and merge your patch. If you have any questions or concerns, please let me know.

Thanks for the review, Piotr. I have already signed the CLA in the previous commit (https://github.com/triton-inference-server/pytorch_backend/pull/91).


#10 Passing function call information to another instance

Might have to define how to inform function calls from users.

I'll send this information to @hoonkim

Need to get information from @TaeyoungJang 's API gateway

Function call would be sent through RabbitMQ so I ask @hoonkim to make a queue to receive mine

So, @zzttt  all instances would have their own Queue? or just gonna use Queue of Openstack?

all instances you manage.  I think you might have to make a few instances, I'll send msg to yours. just let me know what the instances you use(address of the instances on OpenStack).

RuneHTTP merged

Function Call Example.
{     "user" : "kim",     "project" : "rune",     "function" : "getTime",     "params" : [         "seoul", "kr", "nano"     ] }

check it @hoonkim

@TaeyoungJang
checking what?

@hoonkim  will send function's result to @TaeyoungJang  through ResponseFunctionCall which I pass on the argument of call method in wisp_monitor
the result data might have to be a dictionary type ( type check was implemented by @TaeyoungJang )
so I suggest that @hoonkim make a dictionary type JSON data for the result

@zzttt
Response is received should be contained execution time of functions.

@TaeyoungJang
Resource state of instances and execution time will be sent on a response when the function call 's requested


Got this error 403 error while downloading

PS H:\course> youtube-dl -v  -u    https://www.udemy.com/java-the-complete-java-developer-course/
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'-u', u'PRIVATE', u'https://www.udemy.com/java-the-complete-java-developer-course/']
Type account password and press [Return]:
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2016.01.01
[debug] Python version 2.7.11 - Windows-7-6.1.7601-SP1
[debug] exe versions: none
[debug] Proxy map: {}
[udemy:course] Downloading login popup
[udemy:course] Logging in as
[udemy:course] java-the-complete-java-developer-course: Downloading webpage
[udemy:course] java-the-complete-java-developer-course: Downloading course JSON
[udemy:course] 533682: Enrolling in the course
[udemy:course] 533682: Downloading course curriculum
[download] Downloading playlist: The Complete Java Developer Course
[udemy:course] playlist The Complete Java Developer Course: Collected 106 video ids (downloading 106 of them)
[download] Downloading video 1 of 106
[udemy] Downloading login popup
[udemy] 3132918: Downloading webpage
[udemy] 3132918: Downloading lecture JSON
[udemy] 533682: Enrolling in the course
[udemy] 3132918: Downloading lecture JSON
ERROR: Unable to download JSON metadata: HTTP Error 403: FORBIDDEN (caused by HTTPError()); please report this issue on
https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be
sure to call youtube-dl with the --verbose flag and include its complete output.
File "c:\python27\lib\site-packages\youtube_dl\extractor\common.py", line 330, in _request_webpage
return self._downloader.urlopen(url_or_request)
File "c:\python27\lib\site-packages\youtube_dl\YoutubeDL.py", line 1886, in urlopen
return self._opener.open(req, timeout=self._socket_timeout)
File "c:\python27\lib\urllib2.py", line 437, in open
response = meth(req, response)
File "c:\python27\lib\urllib2.py", line 550, in http_response
'http', request, response, code, msg, hdrs)
File "c:\python27\lib\urllib2.py", line 475, in error
return self._call_chain(*args)
File "c:\python27\lib\urllib2.py", line 409, in _call_chain
result = func(*args)
File "c:\python27\lib\urllib2.py", line 558, in http_error_default
raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
sorry cant show the username but i have entered it while doing this

This is paid only course, have you paid for it?

No but I have seen this method on a YouTube video where he only said u will only need to register for this it worked for him


Subscriptions should refresh when there are more able peers

The scenario is such that when you subscribe initially, currently you are stuck with that peer. There is missing logic yet to recover subscriptions when the node you are subscribed to drops the network, but additionally to that, whenever you get new peer connections which are closer to the  location of the contract they should substitute your current subscriptions in order to be more efficient on the number of messages sent around when relaying updates etc.

@iduartgomez Are you working on this issue? If not, I'd like to attempt it if that's ok

You can go ahead, is in the backlog.
I can guide you through the chages needed if necessary too, and give a detailed reply. But will need to take a good look at the source and I won't be able next couple days.
Either way, is free to take.

Actually... while I am working on fixes I am modifying some related things re. how we keep track of subscriptions, etc. so is probably better to wait for https://github.com/freenet/freenet-core/pull/907 to be merged @dowdyma1

I think susbcriptions need some rethinking as there are some flaws on how we are doing them currently, any changes may affect this issue and both things may be improved at the same time in turn. So maybe is better to hold off a bit more for now re. this.


"SERIALIZER MUST BE A NORMALIZER" during export

During export, after upgrade to akeneo 3.0 i have this error:
16:01:36 ERROR     [batch] Encountered an error executing the step: Serializer must be a normalizer An error occurred during the export execution. Error #0 in class LogicException: Serializer must be a normalizer 16:01:36 ERROR     [batch] Encountered an error executing the step: Serializer must be a normalizer 16:01:36 ERROR     [app] Exception occurred while flushing email queue: Connection could not be established with host localhost [No route to host #113]
I think error is trown in line https://github.com/NijiDigital/akeneo-labelized-export-bundle/blob/6e5b36f99dce910160cc71df9250a0edd7ff1674/Normalizer/Product/Standard/PropertiesNormalizer.php#L39
Is there a way to adapt this bundle to work also with 3.0 version of akeneo?
Thank you

Indeed, this bundle is not yet compatible with Akeneo 3.0. We plan to migrate it for next month.
But if you need it before and are willing to fix it yourself, feel free to do it and open a merge request with your fix.

Thanks for you answer @bpresles , i will try.
I've noted also an other point that maybe you can manage in the new release, i will report it in a new issue.
Thank you


Return type for @callback handle_disconnect (and a few others) is too restrictive

The return type for the callback:
@callback handle_disconnect(reason :: term(), socket :: Socket.t()) ::
              {:ok, new_socket}
              | {:stop, stop_reason :: term(), new_socket}
            when new_socket: Socket.t()

should support all the return types of Slipstream.Callback.handle_callback_return per its GenServer-like behaviour.
For example, I am returning a {:continue, :whatever} tuple from handle_disconnect/2 so I can call a GenServer continue function post-disconnect. This works fine, however Dialyzer complains.
The same applies to handle_message/4, handle_reply/3, etc

Looks good, thanks!


Make Angular Material work in offline compiler

When trying to offline compile my Angular app, I get this error:
Error encountered resolving symbol values statically. Reference to a local (non-exported) symbol 'coreModules'.
I'm trying to use the MdTooltipModule in my bootstrap module, but it doesn't compile 👎

#832 has been closed as a duplicate of this issue, but I don't think they are the same.
I'm running an app with AoT offline compiler and Material modules (icon, button, card, input, menu, toolbar), and it's working very well.
But it is not working with Universal. I get the same "window is not defined" error, as mentioned in #832.
After a quick look at the code, Material umd bundles are full of reference to "window". Is that normal ?

@cyrilletuzi I'm trying to work with Universal as well, no luck so far. You can bypass the window error by putting var window = undefined in those umd bundles, but after that I ran into an issue:
/.../node_modules/@angular2-material/core/ripple/ripple.js:10
import { NgModule, Directive, ElementRef, HostBinding, Input } from '@angular/core';
^^^^^^
SyntaxError: Unexpected token import

I'm really not a webpack/node guy, but it's probably just a configuration issue, although I really can't find out what I should do. Any idea?

@orangesoup Thanks for the var window = undefined; trick, it worked. Of course it is not a good solution, but I don't know how to fix that correctly, any idea @jelbourn @hansl ?
@orangesoup Your import problem is just a config problem. Your tsconfig.json for ts-node must be set as :
"target": "es2015",
 "module": "commonjs"

See #308
We haven't had the opportunity yet to ensure that everything works with Universal, but it will be coming within the next few milestones. Happy to have community contributions to help improve this sooner, though.
I'm actually going to close this issue now, since everything should be good for AoT AFAIK, and Angular Universal is tracked via #308.

@cyrilletuzi You mean I have to manually build material with that tsconfig?

@orangesoup no you don't need to build on server side, but as Angular 2 is in TypeScript, which is not understood by node natively, you need to use ts-node with that config.

Any solution so far?
I am using Universal and unable to import the material modules.
Always the same error - "window is no defined"

@dotansimha @orangesoup See a temporary workaround here in #308


Suport for Longs

I know the GraphQL spec doesn't have support for longs, only for ints (32-bit signed integer) https://facebook.github.io/graphql/#sec-Built-in-Scalars, but since you already have a GraphQLLong, you might as well add full support for them.
Currently the ANTLR parser correctly parses integer numbers into an IntVal, and then in GraphqlAntlrToLanguage.getValue() you do
if (ctx.IntValue() != null) {
            IntValue intValue = new IntValue(Integer.parseInt(ctx.IntValue().getText()));
            newNode(intValue, ctx);
            return intValue;
        } else ...

I think you could just create a LongValue price you could do something like
if (ctx.IntValue() != null) {
			try {
				Integer value = Integer.parseInt(ctx.IntValue().getText());
				IntValue intValue = new IntValue(value);
            	newNode(intValue, ctx);
            	return intValue;
			} catch (NumberFormatException e) {
				Long value = Long.parseLong(ctx.IntValue().getText());
				LongValue longValue = new LongValue(value);
            	newNode(longValue, ctx);
            	return longValue;
			}
        } else  ...

and then change Scalars.GraphQLLong so that it coerces from a LongVal into a Long rather than expect a StringVal.

See #93 and #94.

Looks good, it's been open for a while!!

Long is now supported, see #94.


Issue-not issue : MQTT config

Hi, thanks for sharing this great project with us ! I am in the process of implementing this. The m5stack has been flashed but for the time being I use no RFID add on, just the buttons.
My config in Arduno for MQTT :
const char* mqtt_clientId = "M5stack-alarm";
const char* mqtt_state_topic = "home/alarm";
const char* mqtt_command_topic = "home/alarm/set";
const char* mqtt_state_full = "armed_away";
const char* mqtt_state_part = "armed_home";
const char* mqtt_state_off = "disarmed";
const char* mqtt_state_pending = "pending";
const char* mqtt_command_full = "ARM_AWAY";
const char* mqtt_command_part = "ARM_HOME";
const char* mqtt_command_off = "DISARM";
const char* display_state_full ="Fully Armed";
const char* display_state_part ="Partially Armed";
const char* display_state_off ="Switched Off";
const char* display_state_pending ="Pending";
const char* display_present_card = "Please present Card!";
const char* button_a_text = "Off";
const char* button_b_text = "Home";
const char* button_c_text = "Away";
My config of the mqtt entry in configuration.yaml  :
alarm_control_panel:

platform: mqtt
state_topic: "home/alarm"
command_topic: "home/alarm/set"

and finally my config in the Lovelace card :
entity: alarm_control_panel.mqtt_alarm
name: M5Stack Alarm Panel
states:

arm_home
arm_away
type: alarm-panel

Is this a correct configuration ?
I do  not see any changes when pressing the M5Stack buttons ...
Thanks for your help !
Tony

yep it does that without the rfid board
you would need to comment out the line
// Initialize RFID reader
// mfrc522.PCD_Init();             // Init MFRC522


DOC: add XLON to table

I believe XLON was added in 1.0, but just didn't make it into the table for some reason.

LGTM


isOnSetup

What problem does this feature solve?
To distinguish whether codes are in a setup context.
Setup is called only once, and its return is called multiple times due to dependency changes. Some apis need to be restricted to setup
OnMounted is automatically called in setup，onScopeDispose needs to be manually disposed and used separately
What does the proposed API look like?
if(isOnSetup()){}else{}

You can use getCurrentInstance() to detect if you can call onMounted() and other composition api functions. Maybe you are putting things inside of the function returned in setup while they should be outside:
setup() {
  return () => {
    const data = ref() // this should go up
    // ... return jsx
  }
}


SourceLink doesnt support URLs with special chars

(better title would be that SRCSRV doesn't support that, but sourcelink could work around it)
Context:
Many (all ?) GIT viewers (e.g. cgit, gitweb) have raw URLs with HTTP params, e.g.
 http://git.zx2c4.com/cgit/plain/Makefile?id=84627609f5a7634732fe1d718e7d1c18254e64c8

SRCSRV doesn't like that
When using http protocol support, the URL is used to generate the local file path (where it'll be saved), which fails because of the special (e.g. ?) chars, with a cryptic error in VS 0x80004005 (you're not helping SRCSRV).
What can you do about it ?
Immediatly
Reject URLs with special chars when indexing
Powershell to the rescue
You could use an indexing strategy that wouldn't rely on SRCSRV http support, but use a powershell command for URL download instead. It's probably slower (400ms powershell startup time on my machine), requires the user to "trust" the command (get a warning in VS), but also opens up the range of possible features (e.g. could do the LF->CRLF conversion on the fly, or could use credentials).
Here's a PDBSTR indexing using powershell that works :tm:
SRCSRV: ini ------------------------------------------------
VERSION=2
SRCSRV: variables ------------------------------------------
TRGFILE=%targ%\%fnbksl%(%var2%)
SRCSRVTRG=%TRGFILE%
RAWURL=%var3%
SRCSRVCMD=powershell -NoProfile -Command "(new-object net.webclient).DownloadFile('%RAWURL%','%TRGFILE%')"
SRCSRV: source files ---------------------------------------
C:\foobar\src\johndoe.cs*foobar/2d029c15787cd340eb666c39704732f86082dc53/src/johndoe.cs*http://git/cgit/foobar.git/plain/src/johndoe.cs?id=2d029c15787cd340eb666c39704732f86082dc53
...

Now you may wonder why am I not extracting stuff (URL root, SHA1, project) to variables ?
Glad you asked ! That is because I want a common variables section for every project, to allow/simplify merging assemblies (Hint: I'm the author of ILRepack), and their indexed pdbs.

Hi @gluck! I wonder if there is a way to get srcsrv.dll to actually support ? characters.

Simply with the http provider, I doubt it, that's also what MS support replied to this guy:
http://stackoverflow.com/a/18186709/615903

Well that sucks! I just reproduced it:

.\Exe\bin\Release\SourceLink.exe index -pr .\SourceLink\SourceLink.fsproj
-pp Configuration Release `
-u 'https://raw.githubusercontent.com/ctaggart/SourceLink/{0}/%var2%?a=abc'

Another simple work-a-round is to use a proxy or rewrite the URLs. Several web servers support rewriting URLs. Which one are you using. You can also repurpose the SourceLink-Proxy Node app I made to do what you want. http://blog.ctaggart.com/2015/07/sourcelink-10-with-private-github.html

I'm using cgit behind apache, and I already did that (mod_rewrite), mostly wanted to share the issue/findings, as well as give thoughts around the Powershelll approach.
Also the warning/error will probably help others spend less time troubleshooting this one.
Thx !

That is a good idea. Glad you got it working. Can you share the mod_rewrite config details?

Sure, that may be specific to our setup though. I remapped /raw/PROJECT/SHA1/PATH to the cgit raw URL (one of the benefits is that I can change from cgit to another viewer if the need arise).
    RewriteEngine  on
    RewriteRule    "^/raw/([^/]*)/([0-9a-fA-F]*)/(.*)$"  "/cgit/$1.git/plain/$3?id=$2" [PT]

My hope is that the Visual Studio implementation will eventually not use srcsrv.dll to download the code. May be that refactoring can be done with the portable pdb changes #93. It is definitely an orthogonal change.
cc @tmat


⚠ ClamAV has degraded performance

In 0220208, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 91 ms

Resolved: ClamAV performance has improved in ab4ca69.


[Mouse utilities] Mouse highlighter adds support for middle button

Description of the new feature / enhancement
Please add support for the middle button in the mouse highlighter. Because many mice have middle button. Thanks!
Scenario when this would be used?
When using the middle key, there is no color cue. This is bad for some people.
Supporting information
No response

As click is yellow and right-click is blue, so the middle click could be red (to show how to use the middle click on task bar)
the red circle can travel from bottom to top when you scroll down
or traveling from top to bottom when scrolling up
Add some simple Icon for the modifiers :

⇑ for Shift
^ for Ctrl (to explain zoom in web browser)
! for Alt
# for Super (windows)
¤ for Command (apple keyboard only ^^)

[⇑]+[^]+[#]+[B]


⚠ Bofrost.fr has degraded performance

In 9a905b4, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1250 ms

Resolved: Bofrost.fr performance has improved in 72eaca1 after 6 minutes.


Region "isrealcentral" has spelled "Israel" incorrectly

In ServiceTags_public.json:

List of regions called out in doc for being different than standard:

I would also love some context for why the above region names do not conform to azure region standard naming. Is it simply because the names cannot be changed now that this document has been published?
However it seems for Israel, since it is a spelling mistake, it should be corrected in ServiceTags_public.json instead of being added to that list in the document.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 08217244-82bb-13b5-46f7-454801d8f865
Version Independent ID: 4a8b0a32-bf57-7544-c60d-6b7f250c4477
Content: Azure service tags overview
Content Source: articles/virtual-network/service-tags-overview.md
Service: virtual-network
GitHub Login: @mbender-ms
Microsoft Alias: mbender

@jnlycklama, Thanks for your feedback.
We shall review this and get back to you shortly.

@jnlycklama, I have assigned this thread to author for further review.
@mbender-ms, Request you to please review this.

Researching issue with PM for Service Tag.

@mbender-ms any updates?

@jnlycklama No update yet. Will ping PM again.

@KapilAnanth-MSFT The JSON list is question is maintained by the product team, not the docs team. We do not have any control over the content of the file, which I believe is auto-generated weekly. I've alerted the PM for Service Tags. However, this should be marked as a Product Issue, not a docs issue.

@mbender-ms - sure.
@jnlycklama, we have informed our Product group about this issue.
They should be updating the tags soon.


Encrypted configs not working

Description:
Secret key prompt is passed over when using an encrypted value in ballerina.conf. Doesn't read from secret.txt either (both ballerina build and ballerina run).
Steps to reproduce:
"Configure Secrets as Configuration Items" in https://ballerina.io/learn/how-to-deploy-and-run-ballerina-programs/
Affected Versions:
1.1.0-rc2

Tested this and this seems to happen only when trying to run a .bal file or a module. Running the JAR file using ballerina run program.jar or java -jar program.jar is working.

Closing this since this issue was fixed in #20371

Reopening this since this problem is still there for the default config file (ballerina.conf).

This issue is fixed with latest refactor with creating jars with same compiler process. Verified in ballerina 1.2.0. Hence closing issue.


chore: update celestia-app version

Overview

Checklist

[ ] New and updated code has appropriate documentation
[ ] New and updated code has new and/or updated testing
[ ] Required CI checks are passing
[ ] Visual proof for any user facing features like CLI or documentation updates
[ ] Linked issues closed with keywords

Codecov Report

Merging #120 (e12794b) into main (d3ccfbd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #120   +/-   ##
=======================================
  Coverage   61.44%   61.44%
=======================================
  Files          11       11
  Lines         625      625
=======================================
  Hits          384      384
  Misses        194      194
  Partials       47       47

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Event link broken

Subject: Event link broken
Description:
I went to the weekly online event and did find near the top the link "Event link"
When clicking this, it seems to be broken.
Results:
it went to a 404 page not found catch all.
It should have gone to ... not entirely sure why the link even is there.
Backend version: develop-dab83918
Frontend version: develop-dab83918
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:96.0) Gecko/20100101 Firefox/96.0
Page: https://couchers.org/event/783/67th-weekly-online-event-sunday
User: richee (2740)

This is for not including the https


Testing data by LTLA

The number of tests (capacity, processed) seems to only be available at the national level. Is there a plan to start releasing test numbers by LTLA?

Hi @radka-j
Thanks for getting in touch. I'm afraid this falls in the domain of our data team. My best recommendations is to get in touch via the email provided on the website and make a request.
Sorry I couldn't be of more help.

That makes sense, thank you for pointing me in the right direction!


Bulk edit, batch 3 of today's validation fixes for column headers.

Docs Build status updates of commit 9891fce:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/web-service-reference/disableappresponse.md
:white_check_mark:Succeeded
View

docs/web-service-reference/distinguishedgroupby.md
:white_check_mark:Succeeded
View

docs/web-service-reference/domains-soap.md
:white_check_mark:Succeeded
View

docs/web-service-reference/errorcode-int.md
:white_check_mark:Succeeded
View

docs/web-service-reference/eventdata.md
:white_check_mark:Succeeded
View

docs/web-service-reference/excludes.md
:white_check_mark:Succeeded
View

docs/web-service-reference/extendedproperties-nonemptyarrayofextendedfielduris.md
:white_check_mark:Succeeded
View

docs/web-service-reference/extendedproperty.md
:white_check_mark:Succeeded
View

docs/web-service-reference/flagstatus.md
:white_check_mark:Succeeded
View

docs/web-service-reference/forwardallowed.md
:white_check_mark:Succeeded
View

docs/web-service-reference/forwarditem.md
:white_check_mark:Succeeded
View

docs/web-service-reference/getattachmentresponse.md
:white_check_mark:Succeeded
View

docs/web-service-reference/getholdonmailboxesresponse.md
:white_check_mark:Succeeded
View

docs/web-service-reference/getinboxrulesresponse.md
:white_check_mark:Succeeded
View

docs/web-service-reference/getnonindexableitemdetailsresponsemessage.md
:white_check_mark:Succeeded
View

docs/web-service-reference/getnonindexableitemstatistics.md
:white_check_mark:Succeeded
View

docs/web-service-reference/getorganizationrelationshipsettingsrequest-soap.md
:white_check_mark:Succeeded
View

docs/web-service-reference/getphonecallinformationresponse.md
:white_check_mark:Succeeded
View

docs/web-service-reference/getumpropertiesresponse-um-web-service.md
:white_check_mark:Succeeded
View

docs/web-service-reference/getuseravailabilityrequest.md
:white_check_mark:Succeeded
View

docs/web-service-reference/getuserretentionpolicytagsresponsemessage.md
:white_check_mark:Succeeded
View

docs/web-service-reference/globalmessagecount.md
:white_check_mark:Succeeded
View

docs/web-service-reference/globalparentfolderids.md
:white_check_mark:Succeeded
View

docs/web-service-reference/hasendtimechanged.md
:white_check_mark:Succeeded
View

docs/web-service-reference/ismeeting-calendareventdetails.md
:white_check_mark:Succeeded
View

docs/web-service-reference/ispermanentfailure.md
:white_check_mark:Succeeded
View

docs/web-service-reference/isrecurring-calendareventdetails.md
:white_check_mark:Succeeded
View

docs/web-service-reference/isresend.md
:white_check_mark:Succeeded
View

docs/web-service-reference/itemattachment.md
:white_check_mark:Succeeded
View

docs/web-service-reference/journalfolderpermissionlevel.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@lindalu-MSFT , Please review. Thanks much!


Plain english

It would be good for it to be written in plain english that Desktop Virtualisation User does not grant administration privileges on VMs in that application group.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: f4dfda11-b9d8-d493-ffe0-5e1d8859e7b9
Version Independent ID: d468d73d-d708-0e4d-4f4e-e776abb0e321
Content: Built-in Azure RBAC roles Azure Virtual Desktop
Content Source: articles/virtual-desktop/rbac.md
Service: virtual-desktop
GitHub Login: @Heidilohr
Microsoft Alias: helohr

@JackFDLee-FA
Thanks for your feedback! We will investigate and update as appropriate.

@Heidilohr
Can you please check and add your comments on this doc update request as applicable.

Sorry for the delay - thanks for the feedback. I've altered the text to call this out. The change should be visible later today.
#please-close


image file name can be in Chinese or other languages

when upgrade   docusaurus   to   v0.74  ,  The following error occurred：
SyntaxError: D:\doc\helpcenter\my-website\docs\新控制器空间\控制器硬件999999.md: The only valid numeric escape in strict mode is '\0'. (9:149)
|
The possible reason is that the name of the picture is in Chinese, not in alphabet,
I suggest that the image name can be in Chinese or other languages

This is not a problem with the Chinese characters. The URL string contains characters like \4 and \8 which are parsed to be escape characters but unfortunately "The only valid numeric escape in strict mode is '\0'". You need to escape the backslashes like

i  write       in  md  file,

the same  md  file and  image file    on docusaurus     V0.73    is ok  ,but  v0.74   is  error

Could you confirm that it's a CJK-caused issue by trying out my solution? That's the best we can do by looking at the error message.

the same md file and image file on docusaurus V0.73 is ok ,but v0.74 is error

v2 is still in alpha so lots of breaking changes are introduced. Backward compatibility is not always ensured. However I also don't know which change exactly caused your problem

on the version of v0.75, I did the following tests:
Test 1: if the image file name is in Chinese, an error will occur
Picture name:
中文.png

In the MD file:

![](/ Images /4/82/中文. PNG)

Test 2: everything else is the same, only the image file name is a letter, running normally
Picture name:

qqq.png

In the MD file:

![](/ images/4/82/qqq.png)

By my interpretation, this is not about the path in the MD file, but where you referenced it using require. If you are testing it on alpha75 where the error occurs, the best explanation may be because of Webpack 5.
Also, to help others find out what's wrong, you should probably follow the issues template and provide a way to reproduce.

I tested with my app by creating an image static/img/图片.jpg and referencing it in a blog page using

No errors occurred.

I tested with my app by creating an image static/img/图片.jpg and referencing it in a blog page using

No errors occurred on either alpha-74 or alpha-75. So it's not a problem with the CJK path itself. Please try escaping the backslashes.

I see the issue here. The error is reported after the image loader starts processing the URL:
jsxNode.value = `<img ${node.alt ? `alt={"${escapeHtml(node.alt)}"} ` : ''}${
    node.url
      ? `src={require("${inlineMarkdownImageFileLoader}${pathUrl}").default}`
      : ''
  }${node.title ? ` title="${escapeHtml(node.title)}"` : ''} />`;

It seems the issue is platform dependent, so I can't offer further help on this other than possibly trying another directory name that doesn't start with a digit.

1、 os
版本	Windows 10 家庭中文版
版本号	20H2
安装日期	2021/4/4
操作系统内部版本	19042.928
体验	Windows Feature Experience Pack 120.2212.551.0
2、node  -v
v14.15.0
3、Docusaurus   v0.75
4、Test process

create  img   file

static/img/图片.png

in  md file

![](/img/图片.png)

result

We have a function "posixPath" that is supposed to escape the slashes, but for some reasons there's a edge case that prevent escaping \ when there are non-ASCI chars.
export function posixPath(str: string): string {
  const isExtendedLengthPath = /^\\\\\?\\/.test(str);
  const hasNonAscii = /[^\u0000-\u0080]+/.test(str); // eslint-disable-line

  if (isExtendedLengthPath || hasNonAscii) {
    return str;
  }
  return str.replace(/\\/g, '/');
}

It looks like the code was originally copied from a lib:

https://github.com/sindresorhus/slash/blob/main/index.js
https://github.com/sindresorhus/slash/pull/16

Will try to fix it in https://github.com/facebook/docusaurus/pull/4736, but not sure if removing this hasNonAscii check is safe

My testing process and testing environment are as follows:

operating system: Windows 10 Chinese version

2、 node ： v14.15.0
3、docusaurus ： v2 0.75

Create a picture file with the name in Chinese as follows:

Static/img /图片.jpg

···

5. In the MD file,

![](/img/图片.png)

6. when yarn start   startup  webpack  ,There was an error in the result，

------------------ 原始邮件 ------------------
发件人:                                                                                "facebook/docusaurus"                                                                                ***@***.***>;
发送时间: 2021年5月6日(星期四) 晚上9:38
***@***.***>;
***@***.******@***.***>;
主题: Re: [facebook/docusaurus]  image file name can be in Chinese or other languages (#4730)

We have a function "posixPath" that is supposed to escape the slashes, but for some reasons there's a edge case that prevent escaping \ when there are non-ASCI chars.
 export function posixPath(str: string): string {   const isExtendedLengthPath = /^\\\\\?\\/.test(str);   const hasNonAscii = /[^\u0000-\u0080]+/.test(str); // eslint-disable-line   if (isExtendedLengthPath || hasNonAscii) {     return str;   }   return str.replace(/\\/g, '/'); }

It looks like the code was originally copied from a lib:

https://github.com/sindresorhus/slash/blob/main/index.js

sindresorhus/slash#16

Will try to fix it in #4736, but not sure if removing this hasNonAscii check is safe

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

My testing process and testing environment are as follows:

operating system: Windows 10 Chinese version

2、 node ： v14.15.0
3、docusaurus ： v2 0.75

Create a picture file with the name in Chinese as follows:

Static/img /图片.png

···

5. In the MD file,

![](/img/图片.png)

6. when yarn start   startup  webpack  ,There was an error in the result，

7、 7. If I change the  name of the picture file from Chinese to English, as follows:
```yml
static/img/test.jpg

in  md file :
Running is OK
------------------ 原始邮件 ------------------
发件人:                                                                                "facebook/docusaurus"                                                                                @.>;
发送时间: 2021年5月6日(星期四) 晚上9:38
@.>;
<EMAIL_ADDRESS>主题: Re: [facebook/docusaurus]  image file name can be in Chinese or other languages (#4730)
We have a function "posixPath" that is supposed to escape the slashes, but for some reasons there's a edge case that prevent escaping \ when there are non-ASCI chars.
export function posixPath(str: string): string {   const isExtendedLengthPath = /^\\?\/.test(str);   const hasNonAscii = /[^\u0000-\u0080]+/.test(str); // eslint-disable-line   if (isExtendedLengthPath || hasNonAscii) {     return str;   }   return str.replace(/\/g, '/'); }
It looks like the code was originally copied from a lib:
https://github.com/sindresorhus/slash/blob/main/index.js
sindresorhus/slash#16
Will try to fix it in #4736, but not sure if removing this hasNonAscii check is safe
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

sorry ,There's something wrong with my network connection. I can't connect to Canary right now
------------------ 原始邮件 ------------------
发件人:                                                                                "facebook/docusaurus"                                                                                @.>;
发送时间: 2021年5月6日(星期四) 晚上10:49
@.>;
<EMAIL_ADDRESS>主题: Re: [facebook/docusaurus]  image file name can be in Chinese or other languages (#4730)
test in upcoming canary release and let me know if it works
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Version: 2.0.0-beta. 0 can support Chinese image names, thank you
------------------ 原始邮件 ------------------
发件人:                                                                                "facebook/docusaurus"                                                                                @.>;
发送时间: 2021年5月6日(星期四) 晚上10:49
@.>;
<EMAIL_ADDRESS>主题: Re: [facebook/docusaurus]  image file name can be in Chinese or other languages (#4730)
test in upcoming canary release and let me know if it works
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


SyntaxError: Invalid or unexpected token in firebase-admin/lib/auth/base-auth.js:421

Operating System version: Docker
Firebase SDK version: 11.7.0
Firebase Product: auth
Node.js version: 18.16.0
Yarn version: v1.22.19

Step 3: Describe the problem
Trying to verifyIdToken on the backend results in a runtime error:
2023-05-01 16:35:59 /node_modules/firebase-admin/lib/auth/base-auth.js:421
2023-05-01 16:35:59         if (properties?.providerToLink) {
2023-05-01 16:35:59                               ^
2023-05-01 16:35:59
2023-05-01 16:35:59 SyntaxError: Invalid or unexpected token
2023-05-01 16:35:59     at Module._extensions..js (node:internal/modules/cjs/loader:1308:10)

I have tried updating the library, Node and it happens both locally and on Google Cloud
Relevant Code:
    decodedToken = await admin.auth().verifyIdToken(token);

token is already Bearer ${token} and it's split and that's provided to verifyIdToken

It turns out the issue was somewhat unrelated to Firebase. I had to switch from esm to esm-wallaby and that fixed the issue.


NDIS 6.85 and /CETCOMPAT

@ybendito Please look at this PR https://github.com/virtio-win/kvm-guest-drivers-windows/pull/654
Maybe we can remove one of your commits.

@ybendito Please look at this PR #654
Maybe we can remove one of your commits.
Removed, for /CETCOMPAT please refer
https://bugzilla.redhat.com/show_bug.cgi?id=2002603


toolbar not show in readonly mode

showToolbar default value is true, it work good in editable mode. But, when I need some custom toolbar (such as the buttons (edit, delete) has the same UI with o-menubar-btn) in readonly mode, it's not working. And I found the code <o-editor-menu-bar :editor="editor" :toolbar="editorMenuBar" v-if="editable && showToolbar"> in QuasarTiptap.vue. I think users should control the toolbar by showToolbar them self, the editable is not needed.

I think the editor should have the same UI toolbar on the same position. In order to unify editing experience. If you feel no need to make this change, maybe tell me why. Thanks.


Question: Custom visibleTimeStart and visibleTimeEnd on click/zoom

This is more of a question than a bug report.
Is it possible to have custom visibleTimeStart and visibleTimeEnd when a user clicks on a specific time from a DateHeader?
I am using visibleTimeStart and visibleTimeEnd when the Timeline is first time rendered, so initially I am showing 12 hours and that makes the DateHeader easily read, but for example when I zoom out to see a whole month, and then click on 1st of the month, then the Timeline is set to 24 hours, which then formats the hours just to (HH), and it gets confusing. I know formatting can be changes, but on some zoom levels there is so little space, so there is limit to how many numbers can you fit in DateHeader cell.
So is it possible to set custom visibleTimeStart and visibleTime end on clicking the time from DateHeader, and also while zooming in and out of the timeline?

@dotundefined I would recommend experimenting with the beta version. It has more support for formating using custom headers


Moved laws tests to Munit

Codecov Report

Merging #274 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #274   +/-   ##
=======================================
  Coverage   62.25%   62.25%
=======================================
  Files          38       38
  Lines        1285     1285
  Branches        7        8    +1
=======================================
  Hits          800      800
  Misses        485      485

Impacted Files
Coverage Δ

.../main/scala/laserdisc/protocol/ReadInstances.scala
80.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24d2d86...8442270. Read the comment docs.