Build: Fresh vscode repository clone fails building vscode-sqlite3

Issue Type: Bug

A gyp build error started several days ago

I can/could build checkouts before October 15 (right before work was done on vscode-sqlite3

After yarn cache clean and git -gc failed to fix, tried fresh repository clone

Same build  error building

I have made no changes to any of the tool dependencies, Node, Python, VS Community, yarn et cetera

I am thinking there is possibly some dependency change I have not picked up?  Seems odd since a fresh repository has the same error

Searched issues and found nothing relevant

I can successfully build before the first commit below which was a commit adding logging for
vscode-sqlite3 - @bpasero  any ideas?

October 15 fails
git checkout  2dcc9b085c5288e92fcc862f71f2dff4b03b4bc1 -b insiders-1.28.1-addlogging
October 15 works
git checkout  55b9f52f93c14f9ee17bc4cdf60c352322b88bfc -b grav
From the the log, the  following option for gyp is suspicious since I have VS Community 2017
if that's what it's referring to?
gyp info spawn args   'msvs_version=2015',

I don't know the build tools sufficiently to debug myself...
Microsoft Windows [Version 10.0.17134.345]
(c) 2018 Microsoft Corporation. All rights reserved.

C:\Dev\VSC Dev\vc2\vscode>git clean -xfd
Removing node_modules/

C:\Dev\VSC Dev\vc2\vscode>git clean -xfd

C:\Dev\VSC Dev\vc2\vscode>yarn
yarn install v1.10.1
$ node build/npm/preinstall.js
[1/4] Resolving packages...
[2/4] Fetching packages...
info<EMAIL_ADDRESS>The platform "win32" is incompatible with this module.
info<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
info<EMAIL_ADDRESS>The platform "win32" is incompatible with this module.
info<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
[3/4] Linking dependencies...
warning " ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>[4/4] Building fresh packages...
[8/16] ⠠ vscode-nsfw
[6/16] ⠠ node-pty
[7/16] ⠠ spdlog
[10/16] ⠐ vscode-sqlite3
error C:\Dev\VSC Dev\vc2\vscode\node_modules\vscode-sqlite3: Command failed.
Exit code: 1
Command: node-gyp rebuild
Arguments:
Directory: C:\Dev\VSC Dev\vc2\vscode\node_modules\vscode-sqlite3
Output:
C:\Dev\VSC Dev\vc2\vscode\node_modules\vscode-sqlite3>if not defined npm_config_node_gyp (node "C:\Program Files\nodejs\node_modules\npm\bin\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" rebuild )  else (node "" rebuild )
gyp info it worked if it ends with ok
gyp info using<EMAIL_ADDRESS>gyp info using<EMAIL_ADDRESS>| win32 | x64
gyp info spawn C:\ProgramData\Miniconda2\python.EXE
gyp info spawn args [ 'C:\\Program Files\\nodejs\\node_modules\\npm\\node_modules\\node-gyp\\gyp\\gyp_main.py',
gyp info spawn args   'binding.gyp',
gyp info spawn args   '-f',
gyp info spawn args   'msvs',
gyp info spawn args   '-G',
gyp info spawn args   'msvs_version=2015',
gyp info spawn args   '-I',
gyp info spawn args   'C:\\Dev\\VSC Dev\\vc2\\vscode\\node_modules\\vscode-sqlite3\\build\\config.gypi',
gyp info spawn args   '-I',
gyp info spawn args   'C:\\Program Files\\nodejs\\node_modules\\npm\\node_modules\\node-gyp\\addon.gypi',
gyp info spawn args   '-I',
gyp info spawn args   'C:\\Users\\Christopher\\.node-gyp\\iojs-2.0.11\\common.gypi',
gyp info spawn args   '-Dlibrary=shared_library',
gyp info spawn args   '-Dvisibility=default',
gyp info spawn args   '-Dnode_root_dir=C:\\Users\\Christopher\\.node-gyp\\iojs-2.0.11',
gyp info spawn args   '-Dnode_gyp_dir=C:\\Program Files\\nodejs\\node_modules\\npm\\node_modules\\node-gyp',
gyp info spawn args   '-Dnode_lib_file=C:\\Users\\Christopher\\.node-gyp\\iojs-2.0.11\\<(target_arch)\\iojs.lib',
gyp info spawn args   '-Dmodule_root_dir=C:\\Dev\\VSC Dev\\vc2\\vscode\\node_modules\\vscode-sqlite3',
gyp info spawn args   '-Dnode_engine=v8',
gyp info spawn args   '--depth=.',
gyp info spawn args   '--no-parallel',
gyp info spawn args   '--generator-output',
gyp info spawn args   'C:\\Dev\\VSC Dev\\vc2\\vscode\\node_modules\\vscode-sqlite3\\build',
gyp info spawn args   '-Goutput_dir=.' ]
gyp info spawn C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\15.0\Bin\MSBuild.exe
gyp info spawn args [ 'build/binding.sln',
gyp info spawn args   '/clp:Verbosity=minimal',
gyp info spawn args   '/nologo',
gyp info spawn args   '/p:Configuration=Release;Platform=x64' ]
Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.Cpp.Platform.targets(67,5): error MSB8020: The build tools for v140 (Platform Toolset = 'v140') cannot be found. To build using the v140 build tools, please install v140 build tools.  Alternatively, you may upgrade to the current Visual Studio tools by selecting the Project menu or right-click the solution, and then
selecting "Retarget solution".   All rights reserved.

C:\Dev\VSC Dev\vc2\vscode>git clean -xfd
Removing node_modules/

C:\Dev\VSC Dev\vc2\vscode>git clean -xfd

C:\Dev\VSC Dev\vc2\vscode>yarn
yarn install v1.10.1
$ node build/npm/preinstall.js
[1/4] Resolving packages...
[2/4] Fetching packages...
info<EMAIL_ADDRESS>The platform "win32" is incompatible with this module.
info<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
info<EMAIL_ADDRESS>The platform "win32" is incompatible with this module.
info<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
[3/4] Linking dependencies...
warning " ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>[4/4] Building fresh packages...
[8/16] ⠠ vscode-nsfw
[6/16] ⠠ node-pty
[7/16] ⠠ spdlog
[10/16] ⠐ vscode-sqlite3
error C:\Dev\VSC Dev\vc2\vscode\node_modules\vscode-sqlite3: Command failed.
Exit code: 1
Command: node-gyp rebuild
Arguments:
Directory: C:\Dev\VSC Dev\vc2\vscode\node_modules\vscode-sqlite3
Output:
C:\Dev\VSC Dev\vc2\vscode\node_modules\vscode-sqlite3>if not defined npm_config_node_gyp (node "C:\Program Files\nodejs\node_modules\npm\bin\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" rebuild )  else (node "" rebuild )
gyp info it worked if it ends with ok
gyp info using<EMAIL_ADDRESS>gyp info using<EMAIL_ADDRESS>| win32 | x64
gyp info spawn C:\ProgramData\Miniconda2\python.EXE
gyp info spawn args [ 'C:\\Program Files\\nodejs\\node_modules\\npm\\node_modules\\node-gyp\\gyp\\gyp_main.py',
gyp info spawn args   'binding.gyp',
gyp info spawn args   '-f',
gyp info spawn args   'msvs',
gyp info spawn args   '-G',
gyp info spawn args   'msvs_version=2015',
gyp info spawn args   '-I',
gyp info spawn args   'C:\\Dev\\VSC Dev\\vc2\\vscode\\node_modules\\vscode-sqlite3\\build\\config.gypi',
gyp info spawn args   '-I',
gyp info spawn args   'C:\\Program Files\\nodejs\\node_modules\\npm\\node_modules\\node-gyp\\addon.gypi',
gyp info spawn args   '-I',
gyp info spawn args   'C:\\Users\\Christopher\\.node-gyp\\iojs-2.0.11\\common.gypi',
gyp info spawn args   '-Dlibrary=shared_library',
gyp info spawn args   '-Dvisibility=default',
gyp info spawn args   '-Dnode_root_dir=C:\\Users\\Christopher\\.node-gyp\\iojs-2.0.11',
gyp info spawn args   '-Dnode_gyp_dir=C:\\Program Files\\nodejs\\node_modules\\npm\\node_modules\\node-gyp',
gyp info spawn args   '-Dnode_lib_file=C:\\Users\\Christopher\\.node-gyp\\iojs-2.0.11\\<(target_arch)\\iojs.lib',
gyp info spawn args   '-Dmodule_root_dir=C:\\Dev\\VSC Dev\\vc2\\vscode\\node_modules\\vscode-sqlite3',
gyp info spawn args   '-Dnode_engine=v8',
gyp info spawn args   '--depth=.',
gyp info spawn args   '--no-parallel',
gyp info spawn args   '--generator-output',
gyp info spawn args   'C:\\Dev\\VSC Dev\\vc2\\vscode\\node_modules\\vscode-sqlite3\\build',
gyp info spawn args   '-Goutput_dir=.' ]
gyp info spawn C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\15.0\Bin\MSBuild.exe
gyp info spawn args [ 'build/binding.sln',
gyp info spawn args   '/clp:Verbosity=minimal',
gyp info spawn args   '/nologo',
gyp info spawn args   '/p:Configuration=Release;Platform=x64' ]
Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.Cpp.Platform.targets(67,5): error MSB8020: The build tools for v140 (Platform Toolset = 'v140') cannot be found. To build using the v140 build tools, please install v140 build tools.  Alternatively, you may upgrade to the current Visual Studio tools by selecting the Project menu or right-click the solution, and then
selecting "Retarget solution".  System Windows_NT 10.0.17134
gyp ERR! command "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild"
gyp ERR! cwd C:\Dev\VSC Dev\vc2\vscode\node_modules\vscode-sqlite3
gyp ERR! node -v v8.12.0

@aeschli can you fill in the details what you did to get the 2015 build tools? We should then maybe also update https://github.com/Microsoft/vscode/wiki/How-to-Contribute

I fixed it by installing the VS2015 build tools http://download.microsoft.com/download/5/F/7/5F7ACAEB-8363-451F-9425-68A90F98B238/visualcppbuildtools_full.exe (check the window 8 sdk)
That said it would be nicer if all that is needed are the windows-build-tools, like we had it before.
I just read that there's an setting on the build tools to install the 2015 compiler:
yarn global add windows-build-tools --vs2015
@cleidigh can you try that out? I'll try it out on Monday.

@aeschli
@bpasero
Thanks guys, I'm back up and building ( which is good considering how behind I am my October IssueAssignments ;-)
That said, I still had to wrestle a bit to get things building.  Short explanation: yarn solution failed.
I got an npm solution working.  I will clarify this weekend after a few more tests.

I used yarn global add windows-build-tools, and everything works well.
Today, after I run git clean -x, yarn install cannot success again.
It says vscode-sqlite3 won't build, because python not able to run.
My python is installed by windows-build-tools, so it's not in PATH.
After add c:\user\me\.windows-build-tools\python27, install success.

I used yarn global add windows-build-tools, and everything works well.
Today, after I run git clean -x, yarn install cannot success again.
It says vscode-sqlite3 won't build, because python not able to run.
My python is installed by windows-build-tools, so it's not in PATH.
After add c:\user\me\.windows-build-tools\python27, install success.

I used yarn global add windows-build-tools, and everything works well.
Today, after I run git clean -x, yarn install cannot success again.
It says vscode-sqlite3 won't build, because python not able to run.
My python is installed by windows-build-tools, so it's not in PATH.
After add c:\user\me\.windows-build-tools\python27, install success.

I think @joaomoreno hit this too

@cleidigh can you maybe see if https://github.com/nodejs/node-gyp/issues/633 helps for you?

@bpasero My issue was on macOS, bad Python installation. A re installation of Python with Homebrew fixed it.

I think Python was tissue for @GongT , required pass environment variable.
My issue is that no variation on a yarn -based install works.  Installing with npm succeeds.
I'm still experimenting trying to find a conflict perhaps with the VS community 2017

@bpasero
I tried to get back to the point where I had the Windows-build-tools disabled or uninstalled.  This would get me back to where I was with only VS 2017 commandline tools which was my original installation, working up to the point of your tweaks on vscode-sqlite3.
Now I can still successfully compile when I don't think I should.  I investigated and it turns out I already have GYP_MSVS_VERSION=2015 set.  I think this happened when I successfully installed the tools with
npm install --global windows-build-tools --vs2015
See what I found in the tool repository:

I'm guessing that I am only able to build because the VS 2017 tools are still installed and I found references that Microsoft now has  BOTH 2015 and 2017 build tools together.  Right now I'm in the position where things are working at the moment but I think I have installs that did not complete what were partially removed so now I don't know what's making things work.
I don't want to go down a rabbit hole, but I don't think my installation prior was out of the ordinary so still think at a minimum we may need some adjustment to the notes as you said.  I'm thinking I will have to completely uninstall VS to reproduce the steps.
Do you want me to try to do that?

I updated https://github.com/Microsoft/vscode/wiki/How-to-Contribute to indicate that you need to install windows-build-tools with the --vs2015 option. Since sqlite3 is explicitly asking for VS2015, I do not think we should encourage people to build with the 2017 version. Besides, this is not working currently anyways with node-gyp (see here).

@bpasero
sounds good
I will post issue on the Windows-build-tools rep to see if they have any responses on the install failure
using yarn.  I think that scenario come up for others.

@bpasero I've added setup troubleshooting section in my forked version of How-to-Contribute.md. Lists solutions to issues I bumped into while setting up vscode for the first time. Please let me know if it helps to update How-to-Contribute.md, I'll raise a PR.


Typo errors occur when the website language is not English

Many pages have this problem.
e.g.
design-and-ui-intro

This is known issue with our localization tools; the loc team is developing a fix.


Parse package name and latest version from artifactory

Feature Request
Description
Badge in terra-doc-template looks for package in npm repository, However we have package published in internal repo and would like to reference.
Additional Context / Screenshots
We could have new prop called internalNpmPackage in DocTemplate. If we have user defined value for the prop then we build href  and img src with internal repository url otherwise always fallback to normal npm lookup.

Cosiderations
We have npm package published to internal artifactory and would like to fetch package name and latest version to display.

Discussed updating this to make the badge be more customizable to handle internal repos.

Ran into an issue that made me think about this issue. The doc site has a stale deployment where the npm badge pulls the latest version from the released npm package, but the docs show an older version. This causes confusion as the user will think they are looking at the latest released docs.
This can happen if npm publish is successful but the doc site deploy fails.
This made me think that this badge should be pulling the version directly from the package.json file instead of pulling from npm service. I think this could mitigate all the concerns noted on this issue.

@mjhenkes would that require compiling two versions of the site and then toggling them to change which documentation you are referencing?

Talked with @mmalaker  and @amichaelparker about this today. VoiceOver in Safari seems to get trapped in the SVG DOM loaded as a background image in this img.
Planning to update this so it is no longer a dynamically generated SVG via badgegen.
Tech Design
Replace this rendering with the following which would use a new prop packageVersion.
// do some cool styling in here via the .badge class to make this look nice.
 const badge = (
    <a className={cx('badge')} href={`https://www.npmjs.org/package/${packageName}`}>
      Version:{`${packageVersion}

  );

In our example files, we pull the packageName from the package.json file for the component. We could pull the package version as well and pass this into the <DocTemplate /> component.
import { name, version } from '../../../../package.json';

<DocTemplate
    packageName={name}
    packageVersion={version}
/>

Considerations

To keep this passive, we should only conditionally render the markup if the packageVersion prop is set, otherwise, fallback to the current rendering.
We could add a packageUrl prop that users could pass in. We could look into defaulting this to https://www.npmjs.org/package/${packageName} if you don't pass in a packageUrl


Documentation & margins

can you add documentation for the project or at-least for the public methods? I have two layouts in a frame layout with both widths as match_parent. I want to animate top layout to bottom and I achieved it. I want the animated view to have margin 10dp in left and right with width as match_parent. I tried it but can't achieve it. Can you please help.

+1 Document needed.


Adopt versioning scheme

This changeset:

Switches the project to semantic versioning.
Adds a changelog.
Adds scripts to prepare a release.
Adds a \dnd@deprecate command to shortcut deprecation warnings.
Updates the installation instructions in the README to refer to the future release artefact.

After merging this, an owner or collaborator will need to do two things.

Backfill the previous release tags:
git tag -a -m 'Version 0.1' v0.1 c6452fcf764be0729638b30c82a630dff2e32806
git tag -a -m 'Version 0.2' v0.2 b6dcfa88e84a1946b34ee2665081132a088e8ae6
git tag -a -m 'Version 0.5' v0.5 8aedd1ca6eb57a5b04666cef2e45842fbbafc794
git push --tags

These hashes to commits that bumped the version number in the README.

Bump the current release following the instructions in the README.

The reason we need to make these changes after merging this branch is that GitHub won't merge the tags from my fork. Alternatively, I could push the tags to my fork and an owner or collaborator could push them to this repo.
Resolves #67.

I am assuming I can backfill the previous tags against master right now?

I am assuming I can backfill the previous tags against master right now?

Oh, of course. Not sure why I thought they'd have to be done after.

So two questions:

Do we have to have bash installed for this?
Do we need the package script? Presumably someone can just go to the release page and download as zip?

Do we have to have bash installed for this?

Yes, but Git for Windows includes Bash. As does the Linux for Windows subsystem.

Do we need the package script? Presumably someone can just go to the release page and download as zip?

It's useful for a one-line install since it moves the contents to a dnd/ subfolder. It also bundles the PDF, which is similar to other LaTeX projects.
We could eliminate it by adding a line or two to the install instructions.

I think I would prefer to generate the pdf and scrot manually. Something like the 0.1 release that I put up.

Sure, updated the install instructions to use the automatic source archive GitHub creates.


add s3 storage provider

[ ] allow configuring s3 storage when running make future STORAGE=s3

[ ] add s3 storage provider for reva
[ ] add scality, minio or ceph s3 storage to docker-compose.yml file
[ ] add testing

etag propagation for changes triggered outside of ownCloud out of scope

use it to represent what is there

Identified challenges:
stat
While the s3 protocol does have a HEAD request that could be used to implement stat it fails for directories. When executing a stat request for a dir object (= a key ending in /) at least minio returns a 404. At first I thought that was because directories don't really exist so I created one at foo/. That allows a HEAD request. Yay! Unfortunately, if you now add a sub object foo/bar.txt a HEAD against foo/ will return a 404 ... I consider that a bug ... but what do I know ... in any case HEAD is not a reliable way to stat folders. Could we infer the stat from a listobjects request?
listObjects(V2)
While listobjects can be used to get mtime and etag for objects (=files) and dir objects (=objects with a key ending in /) dir objects will be aggregated to CommonPrefixes when using a Delimiter (ttypically / to have directories). I am using the word aggregated, because only the common prefix of all sub keys remains. No mtime, no etag. Common prefixes (= subdirectories) are even kept in a list separate from the file objects, so we have to build a sorted file listing ourself.
While we could implement a storage provider that fills in the mtime all zeros or now() (this is what minios mc cli tool does) it would cause the sync to either never happen (all zeros) or always happen (mtime = current time). Neither is an option. We need a more query friendly intorface for metadata.  In that case we have to fall back to periodic polling. When starting up we fetch the whole bucket content and periodically update it. The mtime (and etag) of directories can then be calculated based on the child elements. Keep in mind that this is a cache, not a database. It could be stored persistent, eg. with quarkdb.
attaching metadata to dirs
If dir objects vanish behind a 404 in minio ... can we use them to attach metadata like a file id ... or share information?

basic implementation in https://github.com/cernbox/reva/pull/63

https://github.com/cernbox/reva/pull/63 has been merged


revert last migration - reverts all if param is empty object

Since introduction of to: 0 to revert all migrations I think a bug was introduced;
umzug.down({}).then(function (migration) {
   // will be same as using {to: 0} i.e. will revert ALL migrations
});

using undefined as params works as expected. If this is intentional, I think readme should be updated so users will know of this as well.

I think {} is almost equal to {to: falsyValue}. IMHO is that we don't need to exactly specify this in the documentation. However passing an empty object instead of nothing may indicate that there is a bug somewhere (or programmer is lazy :smile:). But allowing it makes umzug more flexible.
BTW up() runs all the migrations but down() reverts only the latest one.

Lazy no, it was more like setting up the option object (because I was thinking that there might come more params/opts in the future). So I was always sending the options into the up/down calls and was flabbergasted when it reverted all the migrations after umzug upgrade. I thought it's a bug, but I think this behaviour surely is not what somebody expects after reading the docs:)

This just bit me too. I was setting options to an empty object, and then in certain conditions adding to: 0 to that object. But it's reverting all migrations regardless. Very glad I didn't first encounter this in a production environment! In my mind this is most definitely a bug. Certainly isn't lazy programming in my case. If the to key doesn't exist at all it should obviously be treated as default, which the docs clearly say is to only revert one single migration.

Now, I'm thinking this once again.  It can't be considered valid so there are two options available: a) throw an error or b) consider nothing (valid) has been passed. I vote for last one.

Yeah, to me, an empty object means "default options". It's a normal pattern to have a passed options object merged in to a default options object behind the scenes. That's what I expected here.

Fixed in 1.9.1

I'm designing v2.0 and this will be fixed in it.

Fixed by https://github.com/sequelize/umzug/pull/231


Tour doesn't display until browser is resized

I am facing this issue mainly when there are ajax calls on a webpage.

Duplicate of #530


cassandra: make consistency levels more of less configurable

This change is

Please document that these consistency levels are the default ones.


Test error on private_test_e2e dataset

Hello, I would like to ask what I have no problem testing on the mini dataset, but it is wrong to test on the private_test_e2e dataset?

(navsim) tongyy@server:~/TYY/navsim/scripts$ ./evaluation/run_transfuer.sh
2024-05-23 15:49:00,634 INFO {/mnt/datadisk/tongyy/TYY/navsim/navsim/planning/script/builders/worker_pool_builder.py:20}  Building WorkerPool...
2024-05-23 15:49:00,770 INFO {/mnt/datadisk/tongyy/TYY/navsim/navsim/planning/utils/multithreading/worker_ray_no_torch.py:51}  Not using GPU in ray
2024-05-23 15:49:00,770 INFO {/mnt/datadisk/tongyy/TYY/navsim/navsim/planning/utils/multithreading/worker_ray_no_torch.py:77}  Starting ray local!
2024-05-23 15:49:02,660 INFO worker.py:1749 -- Started a local Ray instance.
2024-05-23 15:49:03,740 INFO {/mnt/datadisk/tongyy/.conda/envs/navsim/lib/python3.9/site-packages/nuplan/planning/utils/multithreading/worker_pool.py:101}  Worker: RayDistributedNoTorch
2024-05-23 15:49:03,740 INFO {/mnt/datadisk/tongyy/.conda/envs/navsim/lib/python3.9/site-packages/nuplan/planning/utils/multithreading/worker_pool.py:102}  Number of nodes: 1
Number of CPUs per node: 136
Number of GPUs per node: 0
Number of threads across all nodes: 136
2024-05-23 15:49:03,740 INFO {/mnt/datadisk/tongyy/TYY/navsim/navsim/planning/script/builders/worker_pool_builder.py:31}  Building WorkerPool...DONE!
Loading logs:   0%|                                                                                | 0/1 [00:00<?, ?it/s]
Error executing job with overrides: ['agent=transfuser_agent', 'agent.checkpoint_path=/mnt/datadisk/tongyy/TYY/navsim/exp/training_transfuser_agent/2<IP_ADDRESS>.42.58/lightning_logs/version_0/checkpoints/epoch19.ckpt', 'experiment_name=transfuser_agent_eval', 'split=private_test_e2e']
Traceback (most recent call last):
File "/mnt/datadisk/tongyy/TYY/navsim/navsim/planning/script/run_pdm_score.py", line 46, in main
scene_loader = SceneLoader(
File "/mnt/datadisk/tongyy/TYY/navsim/navsim/common/dataloader.py", line 83, in init
self.scene_frames_dicts = filter_scenes(data_path, scene_filter)
File "/mnt/datadisk/tongyy/TYY/navsim/navsim/common/dataloader.py", line 50, in filter_scenes
and len(frame_list[scene_filter.num_history_frames - 1]["roadblock_ids"]) == 0
TypeError: object of type 'NoneType' has no len()
Set the environment variable HYDRA_FULL_ERROR=1 for a complete stack trace.

Hi, this failure is expected because you're trying to run the PDM Score on the private test set. This set intentionally has held-out information (i.e., for the route and bounding box annotation) to enable a fair competition where participants cannot overfit or cheat for the leaderboard results.
You can still run your model on private_test_e2e and upload a submission file to huggingface to participate in the challenge. Have a look at docs/submission.md for further information.
Best,
Daniel

Ok, thanks. But I encountered this error when creating the submission pickle file. How can I solve it?

(navsim) tongyy@server:~/TYY/navsim$ ./scripts/submission/run_cv_create_submission_pickle.sh
[2024-05-23 18:49:43,569][timm.models._builder][INFO] - Loading pretrained weights from Hugging Face hub (timm/resnet34.a1_in1k)
[2024-05-23 18:49:53,587][timm.models._hub][INFO] - [timm/resnet34.a1_in1k] Safe alternative available for 'pytorch_model.bin' (as 'model.safetensors'). Loading weights using safetensors.
[2024-05-23 18:49:53,917][timm.models._builder][INFO] - Missing keys (fc.weight, fc.bias) discovered while loading pretrained weights. This is expected if model is being adapted.
[2024-05-23 18:49:54,442][main][INFO] - Building Agent Input Loader
Loading logs: 100%|█████████████████████████████████████████████████████████████████████████████████████████████████████| 1/1 [00:00<00:00,  2.09it/s]
Error executing job with overrides: ['agent=transfuser_agent', 'split=private_test_e2e', 'experiment_name=submission_cv_agent_20240523', 'team_name=YuyuTong', 'authors=YuyuTong'<EMAIL_ADDRESS>'institution=plusgo', 'country=suzhou']
Traceback (most recent call last):
File "/mnt/datadisk/tongyy/.conda/envs/navsim/lib/python3.9/site-packages/torch/serialization.py", line 354, in _check_seekable
f.seek(f.tell())
AttributeError: 'NoneType' object has no attribute 'seek'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/mnt/datadisk/tongyy/TYY/navsim/navsim/planning/script/run_create_submission_pickle.py", line 32, in main
output = run_test_evaluation(
File "/mnt/datadisk/tongyy/TYY/navsim/navsim/planning/script/run_create_submission_pickle.py", line 81, in run_test_evaluation
agent.initialize()
File "/mnt/datadisk/tongyy/TYY/navsim/navsim/agents/transfuser/transfuser_agent.py", line 51, in initialize
state_dict: Dict[str, Any] = torch.load(self._checkpoint_path)["state_dict"]
File "/mnt/datadisk/tongyy/.conda/envs/navsim/lib/python3.9/site-packages/torch/serialization.py", line 791, in load
with _open_file_like(f, 'rb') as opened_file:
File "/mnt/datadisk/tongyy/.conda/envs/navsim/lib/python3.9/site-packages/torch/serialization.py", line 276, in _open_file_like
return _open_buffer_reader(name_or_buffer)
File "/mnt/datadisk/tongyy/.conda/envs/navsim/lib/python3.9/site-packages/torch/serialization.py", line 261, in init
_check_seekable(buffer)
File "/mnt/datadisk/tongyy/.conda/envs/navsim/lib/python3.9/site-packages/torch/serialization.py", line 357, in _check_seekable
raise_err_msg(["seek", "tell"], e)
File "/mnt/datadisk/tongyy/.conda/envs/navsim/lib/python3.9/site-packages/torch/serialization.py", line 350, in raise_err_msg
raise type(e)(msg)
AttributeError: 'NoneType' object has no attribute 'seek'. You can only torch.load from a file that is seekable. Please pre-load the data into a buffer like io.BytesIO and try to load from it instead.
Set the environment variable HYDRA_FULL_ERROR=1 for a complete stack trace.


Add an option to enable anti-aliasing for SVG format.

@davidcl does it seem ok to you (code and documentation about settings)?

Why not making the default antialiasing to "on" for svg output ?

Why not making the default antialiasing to "on" for svg output ?

Because, anti-aliasing on horizontal lines make them larger than vertical lines (in axes for example):

I think this must be fixed before activating this option by default.

I think that this is rather a browser+platform dependent issue. Have you compared the rendering between Chrome, firefox and IE ?

I think that this is rather a browser+platform dependent issue. Have you compared the rendering between Chrome, firefox and IE ?

Of course! All of them display the same large horizontal lines...

Why not making the default antialiasing to "on" for svg output ?
@mottelet this is now done by default and customizable using %plot --antialiasing False

Of course! All of them display the same large horizontal lines...
@vincentcouvert fixed in the latest iteration with style attribute patching for polylines

Great !


[Bug][complement datax task] param is not properly replaced

when run the complement datax task, the param($[yyyyMMdd]) is not properly replaced with schedule time
Which version of Dolphin Scheduler:
[1.3.6]

release to 1.3.8 fixd by #6009


QueryAtoms with atom list queries should not have the atomic number set

Here's the bug:
In [4]: Chem.MolFromSmarts('[Li,Na,K,Ca,Mg]').GetAtomWithIdx(0).GetAtomicNum()
Out[4]: 3

And this is an example of the kind of problem it causes:
In [3]: Chem.MolToSmiles(Chem.MolFromSmarts('[Li,Na,K,Ca,Mg]'))
Out[3]: '[LiH]'

While we're at it, might as well think about fixing this one too:
In [5]: Chem.MolFromSmarts('C-,=C').GetBondWithIdx(0).GetBondType()
Out[5]: rdkit.Chem.rdchem.BondType.SINGLE

Moving this out of 2018_03_4 because the changes are too hard to disentangle from other SMARTS-related  enhancements that will not be in the patch release.


feature: provide signed certificate for node

Right now, the node version ignores any certification rejections for any requests.
The LCU docs provide a riotgames.pem certificate which could be passed along with the requests and in return remove the certification rejection flag for the http requests.

I know I'm bumping an old issue, and I only tested this for the official client API, but this should be pretty easy to implement. It looks like ws allows for using a custom https.Agent ("Any other option allowed in http.request() or https.request()") and so does node-fetch. I'll open up a PR if I end up using this package.

Sounds good, let me know if you want me to assign you this issue if you end up using the library.

I think I'll use it, feel free to assign me this issue. Do you want me to commit the certificate to the repo or download it in one of the npm scripts or..?

Great, glad to see that you're interested. As for the sourcing of the certificate I think it's best to download it through an npm script. We don't know if the URL or certificate may change and hard-coding that would become a maintainability burden and it means that programs could fail at any time.
To make the addition as backwards-compatible as possible I suggest we add a certificate field to the credentials object which is returned by authenticate and then each API will consume this field to access the certificate. We could then have authenticate() take an optional object accepting the path to the .pem file.

That sounds like a great way to handle it with respect to backwards-compatibility and maintainability. I'll have a PR ready sometime soon!

This issue can be closed now. :)

Resolved in #44


Add Github token app

What?
Github token app PR base setup.
Added all the necessary files.

Let's add them in new releases.


class skhubness.neighbors.HNSW should support fractional norms

Hi,
Since this class makes use of nmslib, I think that it should also support fractional norms. The code below shows an example on using fractional norm with nmslib:
import numpy as np
import nmslib
X= np.random.randn(100,7)
index= nmslib.init(method= 'hnsw', space= 'lp', space_params= {'p': 0.1}, data_type= nmslib.DataType.DENSE_VECTOR)
index.addDataPointBatch(X)
index.createIndex()
Thanks for all,
Ivan

Thanks for reporting this. Allowing all spaces that nmslib supports is certainly desirable.

Fractional norms and various other metrics supported by nmslib will be available in the upcoming scikit-hubness v0.30. (No PyPI yet, but one can already install from the sources).


Change signing error message to not be shown for lldb-mi

The executable that is signed is not lldb-mi but debugserver
@edumunoz

I thought about making this GDB only. let me know if you think that's a better idea.

:+1:


Measurement information

SCP suggested some things that should be confirmed (probably for each port?):

[ ] Plants removed
[ ] Litter removed

In Google form.


Bar Chart - Each bar with different color.

Can the bar-chart accept data like the pie-chart or radar-chart, each bar to have different color.
Can it be done using the data format of the bar-chart, with unique data-set for the each bar can be done, constraint is with the labels array.
var data = {
labels : ["Quarter1"],
datasets : [
{
fillColor : "rgba(220,220,220,0.5)",
strokeColor : "rgba(220,220,220,1)",
data : [65]
},
{
fillColor : "rgba(151,187,205,0.5)",
strokeColor : "rgba(151,187,205,1)",
data : [50]
}
]
}
can we take the label inside the datasets?
Is there a way to do this, or i need to hack a way around this?

I needed this! +1

@martypowell that did the trick for thank you

Go with this it will definitely help you.
window.onload = function(){
			    var ctx = document.getElementById("myChart").getContext("2d");
			    window.barFill = new Chart(ctx).Bar(business, {
			    	scaleShowGridLines : false,
			        responsive : true
			    });

			    barFill.datasets[0].bars[0].fillColor = "rgb(239,98,69)";
			    barFill.datasets[0].bars[1].fillColor = "rgb(239,70,91)";
			    barFill.datasets[0].bars[2].fillColor = "rgb(61,59,66)";
			    barFill.update();
			}

@ramtml thanks in advance, but how to set the color when it's hover?? :)

highlightFill ?

V2.0 does all of this natively. See the examples!

Nick, the barFill.datasets[0].bars[0].fillColor approach works great, except it resets following tooltip / hover activation.  Is this a feature or issue?  Is there a work-around?
Thanks in advance and Cheers!
Jody

This is a long-time issue as the the fillColor of a bar overrides on bar's hover.
Also, it's impossible to set an individual bar fillColor depending on bar's label in the array we pass through "labels" key before datasets.
Will there ever be an improvement in this or it's better to simply use something else?

FYI:

It isn't mentioned yet in the documentation
In the stable release v1.0.2, the enhancement can be found at src/Chart.Bar.js but neither Chart.js nor Chart.min.js seem to include it (files in master branch are fine)

This is possible along with a lot of other improvements in version 2.0, set
to launch in the coming weeks.
On Wed, Mar 30, 2016 at 11:13 AM Álvaro G. Vicario<EMAIL_ADDRESS>wrote:

FYI:

It isn't mentioned yet in the documentation
In the stable release v1.0.2, the enhancement can be found at
src/Chart.Bar.js but neither Chart.js nor Chart.min.js seem to include
it (files in master branch are fine)

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/nnnick/Chart.js/issues/128#issuecomment-203507353

This is possible along with a lot of other improvements in version 2.0

I assumed 1.0.2 already has it and it was a build error. In fact I've just upgraded to latest master and I'm definitively using arrays in fillColor :-?

Yeah. Some of the breaking chages in 2.0 are a move to css-like style
properties.  So in this case you'll want to pass an array of colors to
backgroundColor instead of fillColor
On Wed, Mar 30, 2016 at 1:30 PM Álvaro G. Vicario<EMAIL_ADDRESS>wrote:

This is possible along with a lot of other improvements in version 2.0
I assumed 1.0.2 already has it and it was a build error. In fact I've just
upgraded to latest master and I'm definitively using arrays in fillColor
:-?
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/nnnick/Chart.js/issues/128#issuecomment-203568696


CIF v1.0 problem registering addHandler

Hello,
I am trying to register a handler for an onpagenavigation event, using:
https://docs.microsoft.com/en-us/dynamics365/customer-service/channel-integration-framework/reference/microsoft-ciframework/addhandler
My code is as follows:
`const msdynamics = document.createElement("script");
    msdynamics.onload = () => {
        console.log("loaded msdynamics ", Microsoft);
        Microsoft.CIFramework.addHandler(
            "onpagenavigate",
            function (eventData: any) {
                console.log("xxx onpagenavigate ", eventData);
                return Promise.resolve();
            }
        );
    };

    msdynamics.setAttribute(
        "src",
        document.referrer + "webresources/Widget/msdyn_ciLibrary.js"
    );

    let domain = new URL(document.referrer);

    msdynamics.setAttribute("data-cifid", "CIFMainLibrary");
    msdynamics.setAttribute("data-crmurl", domain.origin);

    document.head.appendChild(msdynamics);`

    My handler function is not called, the event seems to be raised but I only see an error like this:

    `Uncaught (in promise) Map(2) {'message' => 'Timeout occurred as no response was received from listener window', 'n' => 'onpagenavigate - raiseEvent'}`

    Any help appreciated ...

Hello,
Thanks for contacting us. Unfortunately, we're unable to handle support requests for the product here. To contact Support, consider one of the options described here: Get support for your Dynamics 365 product
Closing this issue.
Thanks,
Jaya


feat: support overload manager

What type of PR is this?
support overload manager

What this PR does / why we need it:
Which issue(s) this PR fixes:

Related #1966 #1048

How to set the approximate fixed heap value of the system through a script needs to be considered further.


how to get test.txt

There is no "test_" related file in ConvAI2 dataset. So how to get test.txt ??
your Chapter 4 shows that the validation set is constructed from the training set.
However there  exist  "validation set"  in ConvAI2.
Does that mean  you take the  "validation set"  in  ConvAI2  as test set in your experiment?

Partition train_self_original_no_cands.txt for train.txt and valid.txt
Use valid_self_original_no_cands.txt for test.txt
More info in ./data
And the test set in ConvAI2 is not publicly available.


Trailing comma in Main.sublime-menu

ST2 complains when installing this. It's simple to fix by hand, but it's a syntax error.

ST2 has been EOLed by now, so I'm closing this as a wontfix.


[Feature Request] headless mode

Usecase: running catai instances on cloud vms and accessing the UI over the network

Can you explain more?
What blocking you from doing it right now?

My bad! I've found the config.


Ambilight works only without hw acceleration (surface) - videos stuttering!

First at all thanks @mpolednik for the awesome work!
I'm using the script kodi.hue.ambilight on the raspberry pi and the fire tv stick 4k (both fresh install).
The addon doesn't work - it works only by deactivating hardware acceleration (surface)
But by deactivating the videos begins to stutter!
Update
This doesn't work for me: https://github.com/koying/SPMC/wiki/How-do-I-get-Hue,-boblight,-hyperion...-to-work-with-Mediacodec-Surface%3F
Is there a solution for this to fix?

Exactly the same for me...any ideas?

Any news on this? Ambilight would be really great, but in this state the plugin doesn't make any sense...

Update
This doesn't work for me: https://github.com/koying/SPMC/wiki/How-do-I-get-Hue,-boblight,-hyperion...-to-work-with-Mediacodec-Surface%3F
Is there a solution for this to fix?
unfortunately I think that workaround works only if you're using SPMC, which is a modified version of Kodi :(


http status codes not handled

"amtctrl status" crashes with stack dump when it receives an http status code of 401 - Unauthorized.
I find the error handler in client.py, line 97:
        if resp.status_code == 200:
...
        else:
            print("Status: %s" % resp.status_code)
            print(pp_xml(resp.content))
            return 1

but seems it is not catching
Traceback (most recent call last):
  File "/usr/bin/amtctrl", line 5, in <module>
    pkg_resources.run_script('amt==0.6.0', 'amtctrl')
  File "/usr/lib/python2.7/site-packages/pkg_resources.py", line 540, in run_script
    self.require(requires)[0].run_script(script_name, ns)
  File "/usr/lib/python2.7/site-packages/pkg_resources.py", line 1455, in run_script
    execfile(script_filename, namespace, namespace)
  File "/usr/lib/python2.7/site-packages/amt-0.6.0-py2.7.egg/EGG-INFO/scripts/amtctrl", line 114, in <module>
    sys.exit(main())
  File "/usr/lib/python2.7/site-packages/amt-0.6.0-py2.7.egg/EGG-INFO/scripts/amtctrl", line 102, in main
    print(amt.wsman.friendly_power_state(client.power_status()))
  File "/usr/lib/python2.7/site-packages/amt-0.6.0-py2.7.egg/amt/client.py", line 145, in power_status
    "PowerState")
  File "/usr/lib/python2.7/site-packages/amt-0.6.0-py2.7.egg/amt/client.py", line 171, in _find_value
    doc = ElementTree.fromstring(content)
  File "/usr/lib64/python2.7/xml/etree/ElementTree.py", line 1300, in XML
    parser.feed(text)
  File "/usr/lib64/python2.7/xml/etree/ElementTree.py", line 1642, in feed
    self._raiseerror(v)
  File "/usr/lib64/python2.7/xml/etree/ElementTree.py", line 1506, in _raiseerror
    raise err
xml.etree.ElementTree.ParseError: syntax error: line 1, column 63

I think this is fixed with https://github.com/sdague/amt/commit/2f82054c2a6ab721655f9d5c3670738d4a56801b

if not, reopen the issue.

OK now. Thanks for fixing.


ensure code quality

Make sure we have all the required tooling setup to ensure good code quality.
git:pre-commit

prettier
tslint
sort keys in package.json

git:push

run tests

build

generate and report coverage
use code quality tool

periodically

renovate (keep node dependencies up to date)
security vulnerabilities

Code Quality Research
Decision Criteria:

Good integration with GitHub (checks API and inline commenting, with possibility to add actions)
Best algorithms for static code analytics for javascript
Possibility to be warned for new Tasks (like FIXME, TODO, etc.)

Available Tools:

Codacy (GitHub App)
Plugin System with support for a broad range of different plugins

Code Climate

Codebeat
All the analysis tools are self written (not based on open source).

Sonar

maybe add https://github.com/Glavin001/tslint-clean-code

SonarCloud

not investigating more right now - don't think there is enough added value when using one of the above tools


refactor(frontend):replace to monorepo

copilot:all

🤖 Generated by lychee action
Summary

Status
Count

🔍 Total
844

✅ Successful
322

⏳ Timeouts
0

🔀 Redirected
0

👻 Excluded
521

❓ Unknown
0

🚫 Errors
0

Full action output
Full Github Actions output


Fixed React Fiber deprecation of using ref with stateless function components

Issue: #1539
In short, React Fiber deprecated the ability to add ref to a stateless function component.
What I did
Converted LeftPanel and Shortcuts from stateless function components to React.Components.
It should be said that it seems the documentations of developing storybook slightly outdated and missing some information.
Another thing to mention is that I had to use eslint-disable for the components since according to some ESLint React plugin rule they shouldn't be a regular React.Component.
I hope I did an okay fix. Please, let me know.
How to test

clone the repo with fix
run npm install
run npm link
go to lib/ui and run there npm link
go to app/react and over there do the following:
run npm i react@next react-dom@next --only=dev
run `npm link '@storybook/ui'
run npm link

After the flowing you should create a React project using React Fiber.
Needs over there to set-up storybook and then run npm link '@storybook/react'.
The errors for issue #1539 should gone
Fix issue 1539

It seems there is no relation to the code and the failing hooks. Can someone from the maintainers have a look?

I get this in the page of ci/circleci: build_accept_deploy/deploy

From what I've checked I've finished the PR a week ago, and since then, I only rebase from master.
Can anyone from the members of the repo tell me if anything else needs to be done? I would be happy if this PR will be merged since I already use React 16

That's a shame you had no response for so long =(
As for reproduction step, does it work with npm run bootstrap instead of manual linking?


Tx stuck unconfirmed

Has anyone encountered bug whereby transactions get 'stuck' unconfirmed?
I have an issue whereby a 2 of 3 multi-sig wallet can receive incoming tx, and can sign outgoing tx but the funds get 'stuck' and remain unconfirmed for days.
Here are a couple of the tx ids for reference:
a2ed60dc31748fdce1a65dbe740a55bbc2b8fc806324d52d79ecd32ff4d0feda
53a84fe4c940d4725295ad0d7026f8a712b587e3ec07c5c0399ba1d1aa774265
If I inspect the tx in sparrow wallet I see 'insufficient funds!' under the amount, but the wallet has the funds for the transfer.
Version: Sparrow Wallet 1.7.6
Pop!_OS 22.04 LTS x86_64
Help appreciated.

Unconfirmed transactions are simply not yet included in the blockchain, because miners select the transactions paying the greatest fees first, and your transactions have a lower fee rates than others. For example, the first transaction above has a fee rate of under 50 sats/vb, and the going fee rate for inclusion into the next block is currently over 200 sats/vb.
You will either need to wait for the mempool to reduce, or use RBF or CPFP to increase the fee rate of these transactions.

Hi Craig
Yeah i think you're right!
I had no idea transaction fees had gone that high.
Let me know if I need to do anything to mark this thread as closed.


terms and conditions update

Navbar updated  - logo changed
toggle updated
dark mode added to page
Before

After

@Its-Aman-Yadav Hi aman whats happening in this repo.
Why assigning PR without looking at the issues?
invite me to the repo to manage labels. lot of things going wrong.


[ci skip] adding user @Tobias-fischer

Hi! This is the friendly automated conda-forge-webservice.
I've added user @Tobias-fischer as instructed in #4.
Merge this PR to add the user. Please do not rerender this PR or change it in any way. It has [ci skip] in the commit message to avoid pushing a new build and so the build configuration in the feedstock should not be changed.
Please contact conda-forge/core to have this PR merged, if the maintainer is unresponsive.
Fixes #4

Hi @wolfv - this feedstock currently does not have any maintainers (the one listed in the meta.yaml does not exist on GitHub). Could you please merge so I can look at the osx-arm64 migrator?


Removed Version='1' from Field Definitions

Deployment fails when Version is included in field definitions.

Thanks Scott. I'll process this PR


Removed deprecated llm attribute for load_chain

Removed deprecated llm attribute for load_chain
Currently load_chain for some chain types expect llm attribute to be present but llm is deprecated attribute for those chains and might not be persisted during their chain.save.
Fixes #5224 (issue)
Who can review?
@hwchase17
@dev2049

@hwchase17 thanks for the comment, I have made the changes.

I guess this also isn’t backwards compatible… would be nice to maintain that

@hwchase17 added


The Kubecost page cannot read data from Prometheus

I set Kubecost to read data from existing Prometheus, but could not display the data on the page and got the following error.
Cost Allocation page:

Setting Page:

kubecost version: v1.73.0, free
prometheus: v2.18.2
Is it because the kubecost and Prometheus versions are incompatible, or the free version of Kubecost does not support access to existing Prometheus?
gz#974

Hi @hyj-github can you upgrade to latest? This should be fixed in later versions of kubecost.

Hi @hyj-github can you upgrade to latest? This should be fixed in later versions of kubecost.

You mean the new version of Kubecost will connect to existing Prometheus?
Is this problem caused by the Kubecost version?
Can you recommend a version of Kubecost compatible with Prometheusv2.18.2?

Yes, the newest version of kubecost. version 1.87.3 (latest) should be compatible with prometheus 2.18.2.

I found the following quote in the official document：
Note: integrating with an existing Prometheus is only officially supported under Kubecost paid plans.
Does it indicate that the free version does not integrate with existing Prometheus？

This integration is fully functional with free Kubecost, it’s just best
efforts support.
On Fri, Oct 29, 2021 at 10:47 PM hyj-github @.***>
wrote:

I found the following quote in the official document：
Note: integrating with an existing Prometheus is only officially
supported under Kubecost paid plans.
Does it indicate that the free version does not integrate with existing
Prometheus？
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kubecost/cost-model/issues/977#issuecomment-955153769,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACI252CLM5BAGEUXGVAPKTUJOBG5ANCNFSM5G6ON3JA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--
Webb
Kubecost, Co-founder

I found the following quote in the official document：
Note: integrating with an existing Prometheus is only officially supported under Kubecost paid plans.
Does it indicate that the free version does not integrate with existing Prometheus？

Yes, the newest version of kubecost. version 1.87.3 (latest) should be compatible with prometheus 2.18.2.

I want to upgrade Kubecost to V1.87.3 using helm3, do I need to reinstall using helm3 install?
Or just need to update with helm3 upgrade?

Yes, the newest version of kubecost. version 1.87.3 (latest) should be compatible with prometheus 2.18.2.

I updated the version to 1.87.3, but I still have the same problem.

This integration is fully functional with free Kubecost, it’s just best efforts support.
On Fri, Oct 29, 2021 at 10:47 PM hyj-github @.***> wrote: I found the following quote in the official document： Note: integrating with an existing Prometheus is only officially supported under Kubecost paid plans. Does it indicate that the free version does not integrate with existing Prometheus？ — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#977 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACI252CLM5BAGEUXGVAPKTUJOBG5ANCNFSM5G6ON3JA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
-- Webb Kubecost, Co-founder

Do you know how to solve this problem?

Could you share a bit more about how you upgraded and verified that the upgrade happened? That query does not exist in 1.87.3

Could you share a bit more about how you upgraded and verified that the upgrade happened? That query does not exist in 1.87.3

I downloaded cost-Analyser-1.87.3 using Helm3 and then updated release with Helm3 Upgrade, setting Prometheus not to be installed in value.yaml. The update success message is displayed.
The release information is queried.

Could you share a bit more about how you upgraded and verified that the upgrade happened? That query does not exist in 1.87.3

I found that the reason for the error is that one PVC corresponds to two PVS, and one of them is deleted. Then use the same statement on Prometheus to query normal, but the same error occurs on kubecost. I have deleted one PV, but it still appears in the error message. Feel that the request did not reach Prometheus.
Is it possible that kubecost caches the previous error request results and returns them directly？

Could you share a bit more about how you upgraded and verified that the upgrade happened? That query does not exist in 1.87.3

I found that the reason for the error is that one PVC corresponds to two PVS, and one of them is deleted. Then use the same statement on Prometheus to query normal, but the same error occurs on kubecost. I have deleted one PV, but it still appears in the error message. Feel that the request did not reach Prometheus. Is it possible that kubecost caches the previous error request results and returns them directly？

@dwbrown2 @AjayTripathy

I found that this error only occurs when I query the data for that day. Data from previous query dates is returned with dates.
@dwbrown2 @AjayTripathy

Now query the cost of the day will not appear the above error, but only show kubecost cost? What's going on?

Now query the cost of the day will not appear the above error, but only show kubecost cost? What's going on?

@dwbrown2 @AjayTripathy

Hi @hyj-github -- is it possible you're looking at the deprecated details.html page? That's since been replaced by /allocations.html . Is the error occurring there?

Hi @hyj-github -- is it possible you're looking at the deprecated details.html page? That's since been replaced by /allocations.html . Is the error occurring there?

All I've been looking at is the details.html page, can't find /allocations.html

I'm not sure what version you're running now but that page has been deprecated for many months.

Based on what I'm hearing, it seems to me something is not upgrading properly. Are you maybe upgrading the chart but not pulling the correct kubecost images or hardcoding them in your values.yaml?

@hyj-github Please join our slack and re-post this issue in the #support channel to receive further help.


tests: change sample dir to git submodule

- What I did
This commit remove the text/samples directory and add the git submodule
to horusec-examples repository. This commit also update the tests to
read the files from text/examples/samples instead just text/samples.
Co-authored-by: Matheus Alcantara<EMAIL_ADDRESS>- How to verify it
- Description for the changelog

@matheusalcantarazup for merge this PR is necessary all commits signed, you can signed your commig using git commit -s --amend --no-edit

@matheusalcantarazup  only sync your branch and signed your commits for me merge this PR :)


clangd returns an error after changing file extension from .cpp to .tpp.

Problem
Hi! When I'm changing file extension from .cpp to .tpp clangd returns an Unable to handle compilation, expected exactly one compiler job in '' error.
Screen recording 2024-11-29 15.52.44.webm
Logs
V[15:56:24.706] <<< {"id":269,"jsonrpc":"2.0","method":"textDocument/codeAction","params":{"context":{"diagnostics":[{"code":"fe_expected_compiler_job","message":"Unable to handle compilation, expected exactly one compiler job in ''","range":{"end":{"character":0,"line":0},"start":{"character":0,"line":0}},"relatedInformation":[],"severity":1,"source":"clang"}],"triggerKind":2},"range":{"end":{"character":0,"line":0},"start":{"character":0,"line":0}},"textDocument":{"uri":"file:///home/sasha2k62024/TurboINI/container.tpp"}}}

I[15:56:24.707] <-- textDocument/codeAction(269)
I[15:56:24.709] --> reply:textDocument/codeAction(269) 2 ms, error: invalid AST
V[15:56:24.710] >>> {"error":{"code":-32001,"message":"invalid AST"},"id":269,"jsonrpc":"2.0"}

I[15:56:24.710] --> textDocument/clangd.fileStatus
V[15:56:24.710] >>> {"jsonrpc":"2.0","method":"textDocument/clangd.fileStatus","params":{"state":"idle","uri":"file:///home/sasha2k62024/TurboINI/container.tpp"}}

[Error - 3:56:24 PM] Request textDocument/codeAction failed.
[object Object]

System information
Linux penguin 6.6.50-05090-g02ec56928355 #1 SMP PREEMPT_DYNAMIC Fri, 8 Nov 2024 00:13:13 +0000 x86_64 GNU/Linux

Output of clangd --version:
Debian clangd version 18.1.8 (++20240731024826+3b5b5c1ec4a3-1~exp1~20240731144843.145)
Features: linux+grpc
Platform: x86_64-pc-linux-gnu

Operating system:
Linux

.tpp is not a file extension that clang recognizes as a C++ file type.
You can nonetheless get clangd to process a .tpp file as C++ if you specify a -xc++ flag explicitly in the compile command (using, for example, a clangd config file).

@HighCommander4 Thanks a lot!


How to send mail?

I have just started using Drupal VM.  I love the way Mailhog is already integrated into the VM.  However, I would like to be able to send emails generated by Drupal webform module to the actual recipient rather than having it captured by Mailhog.
I have stopped the mailhog service on the VM; however, when I submit the webform, I receive the following message: Unable to send e-mail. Contact the site administrator if the problem persists.
Any suggestions on what needs to be done to be able to send emails to the desired recipient from the VM?

You also need to update PHP's sendmail_path by setting the following variable inside config.yml:
php_sendmail_path: "/usr/sbin/sendmail -t -i"

And then run vagrant provision to make sure it gets updated in PHP (and PHP is restarted); at that point, if the email provider accepts the emails from your IP address, the email should go through :)


classToPlain failed when there is array of objects

Hi, when I send request with array of object in the body and I get error, this is my request:

And this is the error I get

I tried to debug like so:

And this is what I got

is it ok that it checks the inner of the object and not the outside "roles" ?
thanks in advanced !

After reading a lot of duplication, I found out that @Type solve it, for now it's good probably need to be fixed

Yes, you need to specify the received type if it's not a built-in primitive.


Chore: add build tags to e2etest

Closes: #2174
What is the purpose of the change
Add build tags to make e2e tests not run on go test ./...
Documentation and Release Note

Does this pull request introduce a new feature or user-facing behavior changes? (yes / no) no
Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? (yes / no)no
How is the feature or change documented? (not applicable   /   specification (x/<module>/spec/)  /  Osmosis docs repo   /   not documented)not applicable

I updated README and changed test-e2e in makefile. Thank you for your review and suggestion @p0mvn.


Move __STDC_FORMAT_MACROS to build system

__STDC_FORMAT_MACROS changes the behavior of inttypes.h to allow
defining format macros for printf-like functions. It needs to be defined
before any include is done, otherwise due to include chains and header
guards it may not take effect.
Instead of having to define it everywhere it is used, move the define to the
build system. Also update ecl and DriverFramework submodules to deal with the
changed definitions.

New approach to #5006

Accidental submodule change?
src/lib/DriverFramework and src/lib/ecl

How will this be used? What is it the advantage? Would you please give a code example of before and after the change?

@dagar no. They also need to be updated: see the end of the commit/PR message:
(...) Also update ecl and DriverFramework submodules to deal with the
changed definitions.

Not sure what's the project policy wrt splitting the commits since the changes on the Firmware repository depend on the change to the submodules and the changes to submodule depend on this one.

@davids5 this is used to get the definitions of printf format macros like PRIu64, PRIu32 etc. They are only defined by the inttypes.h header if __STDC_FORMAT_MACROS is defined before the include.
People try to do this by defining it just before including inttypes.h but this is error prone. If a header before that one is included (as it was the case in the code changes), there's a possibility the macro doesn't take effect because headers are guarded from multiple inclusion (either via #pragma once or via header guards).
Here what we do is to move the definition to the build system, so it's guaranteed the macro is defined. We still have to include inttypes.h

Would you please give a code example of before and after the change?

I'm not sure what you mean. Please, see the diff. Before you had to define the macro mentioned above in each place you wanted to use the PRI* macros (and be error prone as explained above). Now you don't.

@lucasdemarchi - Thank you. I understand the implications of the guards and the issue with the defines. I think I am asking a simpler question.
My concern is the effects with nuttx (including foreign header files) and the advantage over using %lld.

@davids5 it works fine with nuttx.  This define should never be in a header in the first place.
Advantage over using %lld, is that %lld may not be the right format macro. In fact, it isn't on a 64 bit cpu and you will receive a warning if you have attribute format on that function:
/tmp/a.cpp: In function ‘int main()’:
/tmp/a.cpp:8:18: warning: format ‘%llu’ expects argument of type ‘long long unsigned int’, but argument 2 has type ‘uint64_t {aka long unsigned int}’ [-Wformat=]
  printf("%llu", u);
                  ^

Then what several people do is to add a cast to another type just to make the warning go away, probably introducing the warning on other processors. With this macro it's very simple: if you have a uint64_t variable, you use PRIu64. If it's uint32_t, you use PRIu32 and so on.

@dagar @LorenzMeier what's the policy with submodules? Should I split the commit?  The related PR on the other repositories are:
https://github.com/PX4/DriverFramework/pull/124
https://github.com/PX4/ecl/pull/174

As long as everyone is happy with this we can merge the submodules, then rebase this PR onto master with a submodule update.

Rebased and applied, thanks!


Have the ability to store (and use) custom queries in the configuration

Fixed in https://github.com/mangelajo/track/commit/29f96389bb16110ddaaf4c195c29bfb294ae9182


Ajax request failed with status: Unauthorized

Hi,
I have an error when i try to use link in result table.

Can you help me with this problem?

Do you have access to workitem 1801 normally or is the url malformed? - Open a workitem and change the id in the url to 1801 to check. Also what do those error message say in english?
Is this on vsts or an onpremise installation of tfs, if so what version?

Yes, i have access to this workitem .
In English error message is "Ajax request failed with status: Unauthorized."

Microsoft Visual Studio Team Foundation Version 14.102.25423.0

1.4.8 Fixed

It's working.
Thx for your fast response.


Make ttyd work inside the docker image

This was interesting. tmux 2.9 has an option window-size now that behaves differently, and that was only exposed when using ttyd through the browser.
Fixed that too in 0.6.4.
See https://github.com/tmux/tmux/blob/master/CHANGES (window-size)


timeout tweak

minor optimization / code golf

Coverage decreased (-0.01%) to 99.41% when pulling a47b8077b2df94fe0390f42796f5a795ef49b345 on aeosynth:socket into 6705b3cdaf3e0b472623e7d271ca686a97e61276 on bitinn:master.

Coverage decreased (-0.01%) to 99.41% when pulling a47b8077b2df94fe0390f42796f5a795ef49b345 on aeosynth:socket into 6705b3cdaf3e0b472623e7d271ca686a97e61276 on bitinn:master.

thx!


UWP: Debugger throws break in PayloadValidator

Platform

UWP

Issue
Debugging a card using the AdaptiveCardVisualizer always throws Debugger.Break() from PayloadValidator.cs (Line 68). I'm pretty sure it works with any card but, for repro purposes, I've used TextBlock.Markdown.json

So it looks like we do have some schema validation going on... in the UWP visualizer. I'll see if I can fix up the schema in a way that generates decent documentation and doesn't cause the visualizer to get crabby.

merged


Update WORKSPACE to latest rules_swift dependencies

Addresses #162

❯ bazel build //:plank
Starting local Bazel server and connecting to it...
INFO: Invocation ID: 49c86098-edfd-487c-8f1d-f59f38d8a3ac
INFO: Rule 'build_bazel_rules_swift' modified arguments {"commit": "001736d056d7eae20f1f4da41bc9e6f036857296", "shallow_since": "1547844730 -0800"} and dropped ["tag"]
INFO: Rule 'build_bazel_apple_support' modified arguments {"commit": "77c9d5371949352c00bc74d4755c93e00199172b", "shallow_since": "1547834515 -0500"} and dropped ["tag"]
INFO: Rule 'bazel_skylib' modified arguments {"commit": "f83cb8dd6f5658bc574ccd873e25197055265d1c", "shallow_since": "1543273402 -0500"} and dropped ["tag"]
INFO: Analysed target //:plank (15 packages loaded, 188 targets configured).
INFO: Found 1 target...
Target //:plank up-to-date:
  .bazel/bin/plank
INFO: Elapsed time: 30.979s, Critical Path: 14.69s
INFO: 5 processes: 5 darwin-sandbox.
INFO: Build completed successfully, 13 total actions


[Failing Test]: JuliaSetTestIT.test_run_example_with_setup_file broken for Python post-commit test suites

What happened?
https://ci-beam.apache.org/job/beam_PostCommit_Python39/
https://ci-beam.apache.org/job/beam_PostCommit_Python38/
https://ci-beam.apache.org/job/beam_PostCommit_Python311/
https://ci-beam.apache.org/job/beam_PostCommit_Python310/
Example:
https://ci-beam.apache.org/job/beam_PostCommit_Python39/2437/testReport/apache_beam.examples.complete.juliaset.juliaset.juliaset_test_it/JuliaSetTestIT/test_run_example_with_setup_file/
E         subprocess.CalledProcessError: Command '['/home/jenkins/jenkins-slave/workspace/beam_PostCommit_Python39/src/build/gradleenv/-1734967050/bin/python3.9', '-m', 'build', '--sdist', '--outdir', '/tmp/tmpz8_pabuv', '/home/jenkins/jenkins-slave/workspace/beam_PostCommit_Python39/src/sdks/python/apache_beam/examples/complete/juliaset']' returned non-zero exit status 1.
E         ,            output of the failed child process b''
apache_beam/utils/processes.py:99: RuntimeError
Seems like the test suites started failing the same day https://github.com/apache/beam/pull/28385 was merged so I suspect that PR.
Assigning to the PR author.
Issue Failure
Failure: Test is continually failing
Issue Priority
Priority: 1 (unhealthy code / failing or flaky postcommit so we cannot be sure the product is healthy)
Issue Components

[X] Component: Python SDK
[ ] Component: Java SDK
[ ] Component: Go SDK
[ ] Component: Typescript SDK
[ ] Component: IO connector
[ ] Component: Beam YAML
[ ] Component: Beam examples
[ ] Component: Beam playground
[ ] Component: Beam katas
[ ] Component: Website
[ ] Component: Spark Runner
[ ] Component: Flink Runner
[ ] Component: Samza Runner
[ ] Component: Twister2 Runner
[ ] Component: Hazelcast Jet Runner
[ ] Component: Google Cloud Dataflow Runner

Duplicate of https://github.com/apache/beam/issues/29020.


TLS 1.3 support in DefaultTlsServer

I am trying to implement a TLS 1.3 server using BouncyCastle.Cryptography 2.0.0:
public class BcTlsServer : DefaultTlsServer
{
    private BcTlsServer() : base(new BcTlsCrypto(new SecureRandom()))
    {
    }

    protected override TlsCredentialedSigner GetRsaSignerCredentials()
    {
        ...
    }

    public override ProtocolVersion[] GetProtocolVersions()
    {
        return new[] { ProtocolVersion.TLSv13 };
    }
}

using it like this:
var tlsProto = new TlsServerProtocol(stream);
var server = new BcTlsServer();
tlsProto.Accept(server);

When a TLS 1.3 enabled client attempts to connect it throws a TlsFatalAlert in GetCredentials (The reason for that is because m_context.SecurityParameters.KeyExchangeAlgorithm is set to 0 inside GetCredentials).
What is the proper way to add support for TLS 1.3 and is it supported? What other methods do I need to override?
Since there are no longer key exchanges and signature algorithms in TLS 1.3, I also tried directly returning a TlsCredentials implementation from my certificatein the GetCredentials method:
public override TlsCredentials GetCredentials()
{
    var certStruct = DotNetUtilities.FromX509Certificate(cert).CertificateStructure;
    var tlsCertificate = new BcTlsCertificate(this.crypto, certStruct);
    var bcCertificate = new Certificate(new[] { tlsCertificate });
    return new MyCredentials(bcCertificate);
}

I was able to make this work using a X509 certificate with EC private key:
public override TlsCredentials GetCredentials()
{
    // The X509 certificate I am importing is using an EC private key (secp384r1)
    var x509Cert = new X509Certificate2("cert.pfx", "secret", X509KeyStorageFlags.Exportable);

    var crypto = new BcTlsCrypto(new SecureRandom());
    var tlsCertificate = new BcTlsCertificate(crypto, DotNetUtilities.FromX509Certificate(x509Cert).CertificateStructure);
    var bcCertificate = new Certificate(
        CertificateType.X509,
        TlsUtilities.EmptyBytes,
        new CertificateEntry[] { new CertificateEntry(tlsCertificate, null) });

    var privateKey = x509Cert.GetECDsaPrivateKey();

    var keyPair = DotNetUtilities.GetKeyPair(privateKey);
    var algo = new SignatureAndHashAlgorithm(HashAlgorithm.sha384, SignatureAlgorithm.ecdsa);
    var cryptoParams = new TlsCryptoParameters(this.m_context);
    return new BcDefaultTlsCredentialedSigner(
        cryptoParams,
        crypto,
        keyPair.Private,
        bcCertificate,
        algo);
}

The problem is that this enforces me to use a X509 certificate with EC private key, while in theory it should be possible to use TLS 1.3 with a X509 certificate with RSA private key and use ECDHE or DHE for key exchange. How can this be achieved?

@darind Apologies for taking so long to reply. The rules for TLS are quite complicated (TLS 1.3 only simplifies the problem considerably). The best current example is the ProvTlsServer class from the bc-java project. I made a copy of that and simplified it down the example pasted below.
The main points are to record the client's signature schemes and trusted issuers, as well as configuring which signature schemes you wish to support, and the corresponding credentials to use for each.
AbstractTlsServer will call SelectCipherSuite on cipher suites it finds in common b/w client and server (and otherwise prevalidated). It is a convenient method to override to ensure that we have usable credentials for that suite (which includes checks against the client signature schemes and trusted issuers, if any).
This is not well-tested, so if you try it and need help getting it to work, let me know.
using System;
using System.Collections.Generic;
using System.Linq;

using Org.BouncyCastle.Asn1.X509;
using Org.BouncyCastle.Crypto;
using Org.BouncyCastle.Math.Raw;
using Org.BouncyCastle.Tls;
using Org.BouncyCastle.Tls.Crypto;
using Org.BouncyCastle.Tls.Crypto.Impl.BC;
using Org.BouncyCastle.X509;

namespace Org.BouncyCastle.Example
{
    public class DefaultTls13Server
        : AbstractTlsServer
    {
        private static readonly int[] DefaultCipherSuites = new int[]
        {
            /*
             * TLS 1.3
             */
            CipherSuite.TLS_AES_256_GCM_SHA384,
            CipherSuite.TLS_AES_128_GCM_SHA256,
            CipherSuite.TLS_CHACHA20_POLY1305_SHA256,
        };

        private class Credentials
        {
            internal Certificate Certificate { get; set; }
            internal AsymmetricKeyParameter PrivateKey { get; set; }
        }

        // For each SignatureScheme value we support, store the corresponding credentials
        private readonly Dictionary<int, Credentials> m_credentials = new Dictionary<int, Credentials>();

        private IList<int> m_peerSigSchemes = null;
        private TlsCredentials m_selectedCredentials = null;
        private IList<X509Name> m_clientTrustedIssuers = null;

        public DefaultTls13Server(BcTlsCrypto crypto)
            : base(crypto)
        {
            // TODO Fill in m_credentials according to which SignatureScheme values we support e.g.:
            //m_credentials[SignatureScheme.ecdsa_secp384r1_sha384] = new Credentials { ... };
        }

        protected override int[] GetSupportedCipherSuites()
        {
            return TlsUtilities.GetSupportedCipherSuites(Crypto, DefaultCipherSuites);
        }

        protected override bool SelectCipherSuite(int cipherSuite)
        {
            TlsCredentials cipherSuiteCredentials = null;

            int keyExchangeAlgorithm = TlsUtilities.GetKeyExchangeAlgorithm(cipherSuite);
            if (!KeyExchangeAlgorithm.IsAnonymous(keyExchangeAlgorithm))
            {
                cipherSuiteCredentials = SelectCredentials(keyExchangeAlgorithm);

                if (null == cipherSuiteCredentials)
                    return false;
            }

            bool result = base.SelectCipherSuite(cipherSuite);
            if (result)
            {
                m_selectedCredentials = cipherSuiteCredentials;
            }
            return result;
        }

        public override TlsCredentials GetCredentials()
        {
            return m_selectedCredentials ?? throw new TlsFatalAlert(AlertDescription.internal_error);
        }

        public override int GetSelectedCipherSuite()
        {
            m_peerSigSchemes = m_context.SecurityParameters.ClientSigAlgs.Select(SignatureScheme.From).ToList();

            return base.GetSelectedCipherSuite();
        }

        public override void ProcessClientExtensions(IDictionary<int, byte[]> clientExtensions)
        {
            base.ProcessClientExtensions(clientExtensions);

            m_clientTrustedIssuers = TlsExtensionsUtilities.GetCertificateAuthoritiesExtension(clientExtensions);
        }

        private TlsCredentials SelectCredentials(int keyExchangeAlgorithm)
        {
            switch (keyExchangeAlgorithm)
            {
            case KeyExchangeAlgorithm.NULL:
                return SelectServerCredentials13();

            default:
                return null;
            }
        }

        private TlsCredentials SelectServerCredentials13()
        {
            X509Name[] issuers = m_clientTrustedIssuers.ToArray();
            byte[] certificateRequestContext = TlsUtilities.EmptyBytes;

            foreach (int peerSigScheme in m_peerSigSchemes)
            {
                if (!m_credentials.TryGetValue(peerSigScheme, out var candidateCredentials))
                    continue;

                if (!IsSuitableCredentials(candidateCredentials))
                    continue;

                return CreateCredentialedSigner13(peerSigScheme, candidateCredentials);
            }

            return null;
        }

        private TlsCredentials CreateCredentialedSigner13(int signatureScheme, Credentials credentials)
        {
            return new BcDefaultTlsCredentialedSigner(
                new TlsCryptoParameters(m_context),
                Crypto as BcTlsCrypto,
                credentials.PrivateKey,
                credentials.Certificate,
                SignatureScheme.GetSignatureAndHashAlgorithm(signatureScheme));
        }

        private bool IsSuitableCredentials(Credentials credentials)
        {
            var certificate = credentials.Certificate;
            if (certificate.IsEmpty)
                return false;

            if (TlsUtilities.IsNullOrEmpty(m_clientTrustedIssuers))
                return true;

            var crypto = Crypto as BcTlsCrypto;

            var chain = certificate.GetCertificateList();
            int pos = chain.Length;
            while (--pos >= 0)
            {
                var issuer = BcTlsCertificate.Convert(crypto, chain[pos]).X509CertificateStructure.Issuer;
                if (MatchesIssuers(m_clientTrustedIssuers, issuer))
                    return true;
            }

            var eeCert = new X509Certificate(BcTlsCertificate.Convert(crypto, chain[0]).X509CertificateStructure);
            return eeCert.GetBasicConstraints() >= 0
                && MatchesIssuers(m_clientTrustedIssuers, eeCert.SubjectDN);
        }

        private static bool MatchesIssuers(IList<X509Name> issuers, X509Name name)
        {
            foreach (var issuer in issuers)
            {
                if (name.Equivalent(issuer))
                    return true;
            }
            return false;
        }
    }
}


add daily automatic rebuilds

closing this one b/c I don't wanna eat up all my CI time unnecessarily


git guide: Show how to push the current branch generically.

Automated message from Dropbox CLA bot
@showell, it looks like you've already signed the Dropbox CLA. Thanks!


Add nengo_spinnaker_setup command.

This command automatically creates nengo_spinnaker config files (in the right places) based on easily-answered questions.
This PR is waiting on:

[ ] project-rig/rig#165 being merged and released
[ ] The setup.py dependency for rig being updated accordingly

An example invocation:
$ nengo_spinnaker_setup
:0: FutureWarning: IPython widgets are experimental and may change in the future.
What type of SpiNNaker system to you have?
    0: A single four-chip 'SpiNN-3' board
    1: A single forty-eight-chip 'SpiNN-5' board
    2: Multiple forty-eight-chip 'SpiNN-5' boards
    3: Other
Select an option 0-3: 0

Would you like to auto-detect the SpiNNaker system's IP address?
    0: Auto-detect
    1: Manually Enter IP address or hostname
Select an option 0-1 (default: 0): 0

Make sure the SpiNNaker system is switched on and is not booted.
<Press enter to continue>

Discovering attached SpiNNaker systems...

Successfully created config file in /home/jonathan/.config/nengo/nengo_spinnaker.conf

Note that if a config file already exists, --force must be used:
$ nengo_spinnaker_setup
Config file /home/jonathan/.config/nengo/nengo_spinnaker.conf already exists. Use --force to overwrite.
$ nengo_spinnaker_setup --force
[...]

System wide, user-specific and project-specific config files can also be generated:
nengo_spinnaker_setup --system
nengo_spinnaker_setup --user
nengo_spinnaker_setup --project

(Note: the failed travis run is due to the unreleased state of project-rig/rig#165 -- travis should be re-run   when this has been released).

Cool :)

OK this should be good to go! Feel free to squash and merge when you're happy.


Add get_indexes method to FDBDatastore

This adds support for v3.GetIndices calls.

Note: This implementation will need to change once https://github.com/AppScale/appscale/pull/3176 goes in.
The changes here aren't reflected in a build, but here's one anyway: http://ocd.appscale.net:8080/job/Daily Build/6937/
Demo (loading the datastore viewer for an app with composite indexes)
master
2019-10-25 22:19:00,236 ERROR web.py:1496 Uncaught exception POST / (<IP_ADDRESS>)
HTTPServerRequest(protocol='http', host='<IP_ADDRESS>:8888', method='POST', uri='/', version='HTTP/1.1', remote_ip='<IP_ADDRESS>', headers={'Content-Length': '47', 'Version': 'v1', 'Accept-Encoding': 'identity', 'Appdata': 'composite-indexes:a@a.com:a@a.com:gmail.com', 'Protocolbuffertype': 'Request', 'Host': '<IP_ADDRESS>:8888', 'Module': 'default'})
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/tornado/web.py", line 1415, in _execute
    result = yield result
  File "/usr/local/lib/python2.7/dist-packages/tornado/gen.py", line 870, in run
    value = future.result()
  File "/usr/local/lib/python2.7/dist-packages/tornado/concurrent.py", line 215, in result
    raise_exc_info(self._exc_info)
  File "/usr/local/lib/python2.7/dist-packages/tornado/gen.py", line 876, in run
    yielded = self.gen.throw(*exc_info)
  File "/usr/local/lib/python2.7/dist-packages/appscale/datastore/scripts/datastore.py", line 197, in post
    version_id=request.headers.get('Version'))
  File "/usr/local/lib/python2.7/dist-packages/tornado/gen.py", line 870, in run
    value = future.result()
  File "/usr/local/lib/python2.7/dist-packages/tornado/concurrent.py", line 215, in result
    raise_exc_info(self._exc_info)
  File "/usr/local/lib/python2.7/dist-packages/tornado/gen.py", line 876, in run
    yielded = self.gen.throw(*exc_info)
  File "/usr/local/lib/python2.7/dist-packages/appscale/datastore/scripts/datastore.py", line 266, in remote_request
    response, errcode, errdetail = yield self.get_indices_request(app_id)
  File "/usr/local/lib/python2.7/dist-packages/tornado/gen.py", line 870, in run
    value = future.result()
  File "/usr/local/lib/python2.7/dist-packages/tornado/concurrent.py", line 215, in result
    raise_exc_info(self._exc_info)
  File "/usr/local/lib/python2.7/dist-packages/tornado/gen.py", line 215, in wrapper
    result = func(*args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/appscale/datastore/scripts/datastore.py", line 560, in get_indices_request
    indices = datastore_access.get_indexes(app_id)
AttributeError: 'FDBDatastore' object has no attribute 'get_indexes'
2019-10-25 22:19:00,236 ERROR web.py:1908 500 POST / (<IP_ADDRESS>) 1.40ms

branch
2019-10-25 22:22:58,686 DEBUG datastore.py:237 GetIndices
2019-10-25 22:22:58,686 INFO web.py:1908 200 POST / (<IP_ADDRESS>) 1.11ms


Chef not pulling in Unmanaged Hosts

Cookbook version
7.2.7 (Unable to use latest, due to issues with Apache 2.4 within our Env)
Chef-client version
Chef: 12.21.3
Platform Details
CentOS release 6.9 (Final)
Linux version 2.6.32-696.13.2.el6.x86_64
Scenario:
Trying to add unmanaged hosts through data bags
Steps to Reproduce:
Added the data bag as below:
$ knife data bag show nagios_unmanagedhosts m******** -F json
{
  "id": "m********",
  "use": "server",
  "host_name": "575689-m********",
  "address": "<IP_ADDRESS>",
  "environment": "lon-prod",
  "action": "create"
}

Referenced it as below:
$ knife node show nagios_lon-prod -a nagios.unmanagedhosts_databag
nagios_lon-prod:
  nagios.unmanagedhosts_databag: nagios_unmanagedhosts

On the chef-client run, it seems to ignore any databags in unmanaged hosts.
Other attributes of note:
$ knife node show nagios_lon-prod -a nagios.multi_environment_monitoring
nagios_lon-prod:
  nagios.multi_environment_monitoring: false
$ knife node show nagios_lon-prod -a environment
nagios_lon-prod:
  environment: lon-prod
$ knife node show nagios_lon-prod -a nagios.monitored_environments
nagios_lon-prod:
  nagios.monitored_environments:

Expected Result:
Chef client to pull in unmanaged hosts and add them to the correct .cfg files for Nagios.
Actual Result:
There are no unmanaged hosts that are added to the Nagios instance through chef.

@davidpickwell is this still happening with the current release of the cookbook?


Bigquery-Usage-ADC

Describe your changes :

I worked on the allowing users to use ADC in BigQuery Usage as we do in BigQuery Connector.

Type of change :

[x] Improvement
[x] New feature

Checklist:

[x] I have read the CONTRIBUTING document.
[x] I have performed a self-review of my own.
[x] I have tagged my reviewers below.
[x] I have commented on my code, particularly in hard-to-understand areas.
[x] My changes generate no new warnings.

Reviewers
@ayush-shah

@codingwithabhi can you add the close() method implementation as well?

@codingwithabhi can you add the close() method implementation as well?

sure


Update _config.yml

What is the point of this PR? It does not make sense. @JasperDW you have only replaced the template date with your own information. So?


Topics / services without world name

A lot of ign-gazebo's transport API includes the world name, for example, for the diff_drive world:
$ ign gazebo diff_drive.sdf &
$ ign topic -l
/clock
/gazebo/resource_paths
/model/vehicle_blue/odometry
/model/vehicle_green/odometry
/stats
/world/diff_drive/clock
/world/diff_drive/dynamic_pose/info
/world/diff_drive/pose/info
/world/diff_drive/scene/deletion
/world/diff_drive/scene/info
/world/diff_drive/state
/world/diff_drive/stats

It was initially done this way because we want to eventually support running multiple worlds in parallel. But from the user's point of view, who is using a single world most of the time, this just makes the topics inconvenient to work with. For example, it makes GUI configs less portable because they need topics with world names hardcoded in them.
See relevant discussion on the pull request that added a /clock topic.
Possible solutions

Remove the world name from all topics
Use world-agnostic topics when there's a single world, but namespace them when there are multiple worlds
Have a global namespace like like Gazebo-classic's "~" - this could be just the first namespace provided, for example, by the /gazebo/worlds service.

This task is important to allow us to remove all GUI plugins from the world SDF files and still have good usability. And this is important for reusing SDF files across Gazebo-classic and Ignition.

it makes GUI configs less portable because they need topics with world names hardcoded in them.

#278 resolves the GUI issue


Slack: Bug fix/feature addition - Fix ordering bug in ask_question and add ability to lookup user by email address

Please ensure your pull request (PR) adheres to the following guidelines:

Please refer to our contributing documentation for any questions on submitting a pull request, link: Contribution Guide

Pull Request Checklist
Please check if your PR fulfills the following requirements:

[x] Testing of all the changes has been performed (for bug fixes / features)
[x] The readme.html has been reviewed and added / updated if needed (for bug fixes / features)
[x] Use the following format for the PR description: <App Name>: <PR Type> - <PR Description>
[x] Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.
[x] Verify all checks are passing.
[x] Do NOT use the next branch of the forked repo. Create separate feature branch for raising the PR.
[x] Do NOT submit updates to dependencies unless it fixes an issue.

Pull Request Type
Please check the type of change your PR introduces:

[ ] New App
[x] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation
[ ] Other (please describe):

Security Considerations (REQUIRED)

[x] If you are exposing any endpoints using a REST handler,
please document them in the readme.html.
[x] If this is a new connector or you are adding new actions

[x] Please document in the readme.html all methods (eg, OAuth) used to authenticate
with the service that the connector is integrating with.
[x] If any actions are unable to run on SOAR Cloud, please document this in the readme.html.

[x] Are you introducing any new cryptography modules? If yes, please elaborate their purpose:
[x] Are you are accessing the file system? If yes, please verify that you are only accessing paths returned through
the Vault API.
[x] Are you are marking code to be ignored by Semgrep with nosemgrep?
If yes, please provide justification in an additional comment next to the ignored code.

Release Notes (REQUIRED)

Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.

Fixed a bug where order of values passed in to "responses" on the "ask question" action were not maintained. This provided a poor user experience, especially in the case of "yes, no" inputs, as the order would often flip

Fixed a bug where user ID's that start with "W" would fail in "get user" (See https://api.slack.com/changelog/2016-08-11-user-id-format-changes)

Added the ability to lookup a user by their email address

What is the current behavior? (OPTIONAL)

Describe the current behavior that you are modifying.

The ordering of values passed in to the "responses" parameter in "ask question" is not maintained

"get user" lookup of User IDs that start with W always fail

It is not possible to lookup a user by their email address

What is the new behavior? (OPTIONAL)

Describe the behavior or changes that are being added by this PR.

Order of values passed in to the "responses" parameter in "ask question" action are maintained

"get user" lookup for User IDs that start with W now succeed

It is possible to lookup a user by their email address in addition to their unique ID

Other information (OPTIONAL)

Any other information that is important to this PR such as screenshots of how the component looks before and after the change.

Pay close attention to (OPTIONAL)

Any specific code change or test case points which must be addressed/reviewed at the time of GA release.

Screenshots (if relevant)

Thanks for contributing!

Hello @dallanwagz, This is regarding email_address parameter in ask_question

In list_users action in the current app, we are getting email as None due to permissions mentioned in the app readme for this action. In order to get the email address for users listed in list_users action, we need to give user ‘user:read:email’ permission. This is because we are giving contains for the parameter email_address of get_user action. This would help us use the output emails of list users in get user action's input.

When adding an email address parameter as not required and changing the user_id to not required in get_user action, we would suggest you to add a check in get_user action that either of user_id or email_address should be provided. If none of them is given, the action should return proper error message.

Could you please look into this?

@achandya-crest

OK - Are you asking me to update the readme? If so, I can.

OK - Will do today

@achandya-crest Any update as to when this will be merged? Do you need anything from me?

@dallanwagz We are validating the changes right now. I will keep you posted.
Also, we have to change min_phantom_version to 6.0.0 according to the developer best practices, is it fine for you?

Hello @dallanwagz,
In the get user action, in case of an invalid user_id and valid email_address action will fail as it will consider just the user_id parameter and ignore email_address. Is it an expected scenario from your end?

@achandya-crest There isn't a valid use case to provide both email_address and user_id. It should be one or the other as they are both optional fields.

Ok then we will let it be as it is. Thanks.


error when implementing experiments

Hi,
I'm currently trying to reproduce your result following your instruction.
But when running run_vq_size_ablation.sh, I met an error says that it cannot import name 'quantize_' from "torchar.quantization".
After googling this error, some says that it's due to the reason that the version of torchao lower than 0.4.0, but it seems that your environment requires the version torchao to be no higher than 0.3.0.
So I want to check with you, maybe u can help me with the error?
Looking forward to your reply.
Thank you so much for the help.

still have the error during run recipes/eleuther_eval.py

looks like the version of transformer package is to high, so i want to check with you the verison of transformer package u used.

but after degrading the version of transformer, nothing happened when executing evaluation

It seems that downgrading the transformer to 4.44.1 can solve the problem.


Finetuning with weights in bfloat16

The memory consumption is now ~20GB compared to before at ~38GB.
The training iteration speed-up ~1.5x-2x.

Does memory fit a 3090 even in the LoRA case?

It's tight but yeah it could work:

I can double-check on our 3090 machine.

better check IMO

Attempted to test it but got hold up by this problem: #101

The finetuning fits into the 3090:

I had to install pytorch nightly to get around the issue #101 though. Perhaps we should hold off merging this? Or we could say this requires pytorch nightly. Or we could investigate whether changing the implementation can avoid the error.

Great, I would merge and say that 3090 requires nightly
then we’ll investigate complex again

Amazing, let’s merge!


PSGetModuleInfo.xml invalidates the module .cat file

Team,
After publishing and installing a module from PS Gallery we get one additional file called PSGetModuleInfo.xml. After calling Test-FileCatalog I get "ValidationFailed" result. This way our customers cannot verify the module content.
Thanks,
f012rt

@SydneyhSmith so tagging this with 3.0 resolved means this won't ever be fixed in 2.0 and we should not sign the scripts?

You can Authenticode sign individual files (where applicable), or nuget sign the package.

I create a script to verify the publisher signing and give detailed results to find what @4c74356b41's issue was.
https://gist.github.com/TravisEz13/70263b0bd6b1e747dac2d116245f419e
It gives this result for the module, which looks like this

@4c74356b41 - You can 100% publish and install signed modules - what the issue is here is that the 'PSGetModuleInfo.xml' should be hidden on the filesystem, which it definitely is on windows

@ThomasNieto thanks for bringing this up, we are happy to explore if this fits into PowerShellGet 3.0....do you have any suggestions as to what you would like to see in PowerShellGet to fix this....one option would be to use the Save-PSResource cmdlet without the parameter -IncludeXML (which is currently available in 3.0), another way for users to check would be a -PublisherCheck parameter on Install (which has not yet been implemented)

@SydneyhSmith - re the above it would make sense to move to a single file for User installs & a single file for System wide installs as opposed to individual files dotted around in each installed module version folder? This would also make Get-InstalledModule quicker too

@TravisEz13 thats true, thats for figuring that out. funny enough, it started working after I removed those 2 files from the cat file. but the cat file still doesn't pass the check :)

@SydneyhSmith can we get this bug fix / enhancement worked on before v3 GA so there is no breaking change? The fix @kilasuit recommended https://github.com/PowerShell/PSResourceGet/issues/286#issuecomment-719848944 I feel is the best solution for this problem with added benefits to making discovery faster.


Add new method int Transformer: commentModuleInProfile

Addition of a new tranformer method:

comments a module listed in the profile

@ppalaga would it be possible to release this project with this update? I'd like to use the change in https://github.com/l2x6/cq-maven-plugin

I forgot to create a test, I'll add it in a moment, sorry for that

Test is there

@cstamas do you happen to have some more changes to add before we release 4.4.0?

No, just got with the release

4.4.0 is in Central now https://repo1.maven.org/maven2/org/l2x6/pom-tuner/pom-tuner/4.4.0/pom-tuner-4.4.0.pom

Let me release 4.16.1

See https://github.com/l2x6/cq-maven-plugin/actions/runs/12295608334