Error: Warmup(Generation("'bool' object has no attribute 'dtype'"))

System Info
lorax latest docker, 2 A100, unbuntu 22.04
Information

[X] Docker
[ ] The CLI directly

Tasks

[ ] An officially supported command
[ ] My own modifications

Reproduction
When loading qwen-32b-chat.

2024-04-18T01:17:55.125611Z  INFO lorax_router: router/src/main.rs:296: Warming up model
2024-04-18T01:17:55.167710Z  INFO lorax_launcher: flash_causal_lm.py:793 Warming up to max_total_tokens: 488
2024-04-18T01:17:55.167711Z  INFO lorax_launcher: flash_causal_lm.py:793 Warming up to max_total_tokens: 488
2024-04-18T01:17:55.548798Z ERROR lorax_launcher: interceptor.py:41 Method Warmup encountered an error.
Traceback (most recent call last):
File "/opt/conda/bin/lorax-server", line 8, in
sys.exit(app())
File "/opt/conda/lib/python3.10/site-packages/typer/main.py", line 311, in call
return get_command(self)(*args, **kwargs)
File "/opt/conda/lib/python3.10/site-packages/click/core.py", line 1157, in call
return self.main(*args, **kwargs)
File "/opt/conda/lib/python3.10/site-packages/typer/core.py", line 778, in main
return _main(
File "/opt/conda/lib/python3.10/site-packages/typer/core.py", line 216, in _main
rv = self.invoke(ctx)
File "/opt/conda/lib/python3.10/site-packages/click/core.py", line 1688, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/opt/conda/lib/python3.10/site-packages/click/core.py", line 1434, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/opt/conda/lib/python3.10/site-packages/click/core.py", line 783, in invoke
return __callback(*args, **kwargs)
File "/opt/conda/lib/python3.10/site-packages/typer/main.py", line 683, in wrapper
return callback(**use_params)  # type: ignore
File "/opt/conda/lib/python3.10/site-packages/lorax_server/cli.py", line 89, in serve
server.serve(
File "/opt/conda/lib/python3.10/site-packages/lorax_server/server.py", line 321, in serve
asyncio.run(
File "/opt/conda/lib/python3.10/asyncio/runners.py", line 44, in run
return loop.run_until_complete(main)
File "/opt/conda/lib/python3.10/asyncio/base_events.py", line 636, in run_until_complete
self.run_forever()
File "/opt/conda/lib/python3.10/asyncio/base_events.py", line 603, in run_forever
self._run_once()
File "/opt/conda/lib/python3.10/asyncio/base_events.py", line 1909, in _run_once
handle._run()
File "/opt/conda/lib/python3.10/asyncio/events.py", line 80, in _run
self._context.run(self._callback, *self._args)
File "/opt/conda/lib/python3.10/site-packages/grpc_interceptor/server.py", line 165, in invoke_intercept_method
return await self.intercept(
File "/opt/conda/lib/python3.10/site-packages/lorax_server/interceptor.py", line 38, in intercept
return await response
File "/opt/conda/lib/python3.10/site-packages/opentelemetry/instrumentation/grpc/_aio_server.py", line 82, in _unary_interceptor
raise error
File "/opt/conda/lib/python3.10/site-packages/opentelemetry/instrumentation/grpc/_aio_server.py", line 73, in _unary_interceptor
return await behavior(request_or_iterator, context)
File "/opt/conda/lib/python3.10/site-packages/lorax_server/server.py", line 81, in Warmup
max_supported_total_tokens = self.model.warmup(batch, request.max_new_tokens)
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/flash_causal_lm.py", line 796, in warmup
_, batch = self.generate_token(batch, is_warmup=True)
File "/opt/conda/lib/python3.10/contextlib.py", line 79, in inner
return func(*args, **kwds)
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/flash_causal_lm.py", line 936, in generate_token
raise e
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/flash_causal_lm.py", line 933, in generate_token
out = self.forward(batch, adapter_data)
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/flash_causal_lm.py", line 890, in forward
logits = model.forward(
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/custom_modeling/flash_qwen2_modeling.py", line 484, in forward
hidden_states = self.model(
File "/opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
File "/opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl
return forward_call(*args, **kwargs)
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/custom_modeling/flash_qwen2_modeling.py", line 428, in forward
hidden_states, residual = layer(
File "/opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
File "/opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl
return forward_call(*args, **kwargs)
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/custom_modeling/flash_qwen2_modeling.py", line 351, in forward
attn_output = self.self_attn(
File "/opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
File "/opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl
return forward_call(*args, **kwargs)
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/custom_modeling/flash_qwen2_modeling.py", line 213, in forward
qkv = self.query_key_value(hidden_states, adapter_data)
File "/opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
File "/opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl
return forward_call(*args, **kwargs)
File "/opt/conda/lib/python3.10/site-packages/lorax_server/utils/layers.py", line 606, in forward
result = self.base_layer(input)
File "/opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
File "/opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl
return forward_call(*args, **kwargs)
File "/opt/conda/lib/python3.10/site-packages/lorax_server/utils/layers.py", line 402, in forward
return self.linear.forward(x)
File "/opt/conda/lib/python3.10/site-packages/lorax_server/utils/layers.py", line 288, in forward
if self.bias is not None and self.bias.dtype != x.dtype:
AttributeError: 'bool' object has no attribute 'dtype'

2024-04-18T01:17:55.549099Z ERROR warmup{max_input_length=1024 max_prefill_tokens=1024 max_total_tokens=1512}:warmup: lorax_client: router/client/src/lib.rs:34: Server error: 'bool' object has no attribute 'dtype'
2024-04-18T01:17:55.559823Z ERROR lorax_launcher: interceptor.py:41 Method Warmup encountered an error.
Traceback (most recent call last):
File "/opt/conda/bin/lorax-server", line 8, in
sys.exit(app())
File "/opt/conda/lib/python3.10/site-packages/typer/main.py", line 311, in call
return get_command(self)(*args, **kwargs)
File "/opt/conda/lib/python3.10/site-packages/click/core.py", line 1157, in call
return self.main(*args, **kwargs)
File "/opt/conda/lib/python3.10/site-packages/typer/core.py", line 778, in main
return _main(
File "/opt/conda/lib/python3.10/site-packages/typer/core.py", line 216, in _main
rv = self.invoke(ctx)
File "/opt/conda/lib/python3.10/site-packages/click/core.py", line 1688, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/opt/conda/lib/python3.10/site-packages/click/core.py", line 1434, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/opt/conda/lib/python3.10/site-packages/click/core.py", line 783, in invoke
return __callback(*args, **kwargs)
File "/opt/conda/lib/python3.10/site-packages/typer/main.py", line 683, in wrapper
return callback(**use_params)  # type: ignore
File "/opt/conda/lib/python3.10/site-packages/lorax_server/cli.py", line 89, in serve
server.serve(
File "/opt/conda/lib/python3.10/site-packages/lorax_server/server.py", line 321, in serve
asyncio.run(
File "/opt/conda/lib/python3.10/asyncio/runners.py", line 44, in run
return loop.run_until_complete(main)
File "/opt/conda/lib/python3.10/asyncio/base_events.py", line 636, in run_until_complete
self.run_forever()
File "/opt/conda/lib/python3.10/asyncio/base_events.py", line 603, in run_forever
self._run_once()
File "/opt/conda/lib/python3.10/asyncio/base_events.py", line 1909, in _run_once
handle._run()
File "/opt/conda/lib/python3.10/asyncio/events.py", line 80, in _run
self._context.run(self._callback, *self._args)
File "/opt/conda/lib/python3.10/site-packages/grpc_interceptor/server.py", line 165, in invoke_intercept_method
return await self.intercept(
File "/opt/conda/lib/python3.10/site-packages/lorax_server/interceptor.py", line 38, in intercept
return await response
File "/opt/conda/lib/python3.10/site-packages/opentelemetry/instrumentation/grpc/_aio_server.py", line 82, in _unary_interceptor
raise error
File "/opt/conda/lib/python3.10/site-packages/opentelemetry/instrumentation/grpc/_aio_server.py", line 73, in _unary_interceptor
return await behavior(request_or_iterator, context)
File "/opt/conda/lib/python3.10/site-packages/lorax_server/server.py", line 81, in Warmup
max_supported_total_tokens = self.model.warmup(batch, request.max_new_tokens)
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/flash_causal_lm.py", line 796, in warmup
_, batch = self.generate_token(batch, is_warmup=True)
File "/opt/conda/lib/python3.10/contextlib.py", line 79, in inner
return func(*args, **kwds)
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/flash_causal_lm.py", line 936, in generate_token
raise e
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/flash_causal_lm.py", line 933, in generate_token
out = self.forward(batch, adapter_data)
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/flash_causal_lm.py", line 890, in forward
logits = model.forward(
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/custom_modeling/flash_qwen2_modeling.py", line 484, in forward
hidden_states = self.model(
File "/opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
File "/opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl
return forward_call(*args, **kwargs)
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/custom_modeling/flash_qwen2_modeling.py", line 428, in forward
hidden_states, residual = layer(
File "/opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
File "/opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl
return forward_call(*args, **kwargs)
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/custom_modeling/flash_qwen2_modeling.py", line 351, in forward
attn_output = self.self_attn(
File "/opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
File "/opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl
return forward_call(*args, **kwargs)
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/custom_modeling/flash_qwen2_modeling.py", line 213, in forward
qkv = self.query_key_value(hidden_states, adapter_data)
File "/opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
File "/opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl
return forward_call(*args, **kwargs)
File "/opt/conda/lib/python3.10/site-packages/lorax_server/utils/layers.py", line 606, in forward
result = self.base_layer(input)
File "/opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
File "/opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl
return forward_call(*args, **kwargs)
File "/opt/conda/lib/python3.10/site-packages/lorax_server/utils/layers.py", line 402, in forward
return self.linear.forward(x)
File "/opt/conda/lib/python3.10/site-packages/lorax_server/utils/layers.py", line 288, in forward
if self.bias is not None and self.bias.dtype != x.dtype:
AttributeError: 'bool' object has no attribute 'dtype'

2024-04-18T01:17:55.560073Z ERROR warmup{max_input_length=1024 max_prefill_tokens=1024 max_total_tokens=1512}:warmup: lorax_client: router/client/src/lib.rs:34: Server error: 'bool' object has no attribute 'dtype'
Error: Warmup(Generation("'bool' object has no attribute 'dtype'"))
2024-04-18T01:17:55.643388Z ERROR lorax_launcher: Webserver Crashed

Expected behavior
none

@KrisWongz Can you please share the arguments to the command you used when you ran into this issue?

Sure @magdyksaleh

docker run --gpus all
--shm-size 1g
-p 8081:80
-v /home/unionlab001/Model/qwen-32b:/data ghcr.io/predibase/lorax:latest
--model-id /data/Qwen1_5-32B-Chat
--trust-remote-code
--quantize bitsandbytes-nf4
--max-batch-prefill-tokens 1024
--max-input-length 1024
--max-total-tokens 1512
--num-shard 4 \

Looks like this may be an issue specific to Qwen + nf4 quantization. We'll take a look.


[Wiki] Swap order of lines in Caddyfile

domain {
        root * /link/to/dist
        route /api* {
                uri strip_prefix /api
                reverse_proxy api.addr.x.x
        }
        route {
                try_files {path} /index.html
                file_server
        }
}

file_server needs to be bellow try files. and in this way it works perfectly

The pros: you get automatic HTTPS and you can just publish port 443 directly.

I believe the first bit is if you wish to have multiple domains setup in a single caddy instance as well
domain.etw {
...```

And I think the wiki one has it set for a single domain on a single Caddy instance. Good catch on that and I can leave a note as well. As for the `file_server` and `try_files`, that's been updated. Thanks!

Perfect, going to close this now, thanks for the heads up since it's been awhile since I used Caddy :)


Sun Temple not working properly on Xiaomi Redmi Note 3 (5.5 inch, PowerVR)

Hey, I tried the Sun Temple demo with the plugin, and the left part of the screen is just completly black, while the right side has the distorted lens effect thats needed for VR. Can you help?
I made a new sun temple project, and tested it without the plugin.
Added the plugin folder, and compiled the plugin.
Tested it than on the device.
I have a Xiaomi Redmi Note 3 with 5.5 inches and PowerVR graphics.
Greetings, Eddy

Hi,
Unfortuantely there is no Redmi 3 but it's looks strange. Would you be so king to get a screenshot?

Hi,
I did try out the First Person Shooter demo, and there it works all normal and good. Only on the SunTemple demo it works strange.

Go it, thank you! We'll try to solve this out asap.

As quick fix attempt - please try to enable mobile hdr.

We checked the scene and it turns out that some PostProcessing volumes conflict in the scene. If you delete Global PostProcess and PostProcess_1/2/3 it will work as expected (altough will run a bit slow). Disabling post processing sounds like a horrible idea at first but please keep in mind that VR rendering needs to be done to two eyes per-frame which will already slow down the application pretty well and there is not much room for post-processing to begin with. The only thing that must be enabled for lens distortion to work is MobileHDR. We have updated the README to reflect this.

I am using a project with BP and first person controller and I am following the Instuctions but I get an error message from Unity:
Message
Plugin 'UE4Cardboard' failed to load because module 'UE4Cardboard' could not be found.  Please ensure the plugin is properly installed, otherwise consider disabling the plugin for this project

I have no extra postprocessing volumes in my scene and i only get the right eye rendering.

@nkindt will help us with it :)

Hey guys!
i found a solution for the above mentioned problem.

Disable those settings and it should work.

Hi There,
i followed setup steps, with unreal 4.11 can't get project to open, it gives message first that component
UE4Editor-UE4Cardboard.dll is missing and ask for rebuild, after click rebuild it gives another message with failed to build the project and i may need to build it manually, after i open the vs 2015 to build project manually it gives some error regarding SimpleMHD class and it cannot inistantiat abstract class, any help please ?

Hi all, could solve my problem
i have managed to fix for 4.11 , also changed names of classes to be unique than simplemhd so we now have our own plugin, hope we can fix the continues drift in picture
here my latest fork git
https://github.com/ANGames/UE4Cardboard.git
hope it help

when i played vr preview just play to simpleHMD not changed

how to apply plugin.. ? my editor change nothing....

Hi @engahmedfawzy! Awesome work, would you be so kind to make pull request?

@kangdonghoon please describe what you are doing and what you can see in logs?

@zulman thanks a lot for encourage im software engineer and I think I can help fixing drift issue but problem I don,t understand how simple get its values  and how drift should calculated,  lets continue to drift issue if someone explain to me current calculation equations vs correct ones under the drift opened topics, will be waiting a hand of help :)
Thanks

 i was applied. like this screen shot
 and didn't change anything

@kangdonghoon
I use Project Setting ~> Rendering ~> Mobile HDR
Fix this problem.

hey lens dis working :( i use unreal 4.11.2

plugin is visible and enabled
mobile HDR enabled
PP deleted and disabled
When i package and run it on my note 5 no lens distortion just split screen like simple hmd maybe i need to download unreal 4.10 or 4.11.1 ?
Please help

Sorry, but can someone help me out.
I get a:
Missing or incompatible modules in UE4Cardboard plugin
Plugin UE4Cardboard failed to load because module 'UE4Cardboard' could not be found.
Any solution for this?
Thank you.


[BUG]: V11 Incompatibility

Discord Username
Orionox
Browsers
Native Foundry Client
What Happened?
the module is preventing scenes from being loaded
Reproduction Steps
1. Activate module
2. Load scene
3. screen is blank

Relevant Log Output
foundry.js:753 TypeError: Error thrown in hooked function '' for hook 'updateScene'. Cannot read properties of null (reading 'flags')
[Detected 1 package: wall-height]
    at getSceneSettings (utils.js:37:32)
    at set currentTokenElevation [as currentTokenElevation] (patches.js:29:32)
    at WallHeightUtils.updateCurrentTokenElevation (patches.js:66:34)
    at Object.fn (patches.js:369:16)
    at #call (foundry.js:730:20)
    at Hooks.callAll (foundry.js:687:17)
    at ClientDatabaseBackend.callback (foundry.js:13669:13)
    at foundry.js:13642:43
    at Array.map (<anonymous>)
    at #handleUpdateDocuments (foundry.js:13642:33)

Currently there is a bug that prevents V11 scenes from loading, this will be fixed on the next release.

Any update for this issue?

Sorry for the delay, OIF just got updated to V11 and should be working smoothly now.
V2.0.0 still WIP


Games not working:

Space engineers DLC (https://store.steampowered.com/dlc/244850/Space_Engineers/)

Did you download it and put it in Steam files?


This could be an example for your API

Below there is some code that could serve as an example how to get issues for a certain milestone, but I am not content with the solution:

I could not figure out how to only retrieve the issues for a certain milestone.  Any advice?

Consequently, it is too slow.  It gets all the issues and then throws away the ones not matching.  Due to server communication, this is a non-acceptable slow-down.

There might be a more clever way to resolve a milestone title to a milestone id (without downloading all the milestones).

Any ideas?
{-# LANGUAGE FlexibleContexts          #-}
{-# LANGUAGE LambdaCase                #-}
{-# LANGUAGE NoMonomorphismRestriction #-}
{-# LANGUAGE OverloadedStrings         #-}
{-# LANGUAGE NamedFieldPuns            #-}

import Data.Foldable
import Data.Maybe
import Data.Text (Text)
import qualified Data.Text as Text
import qualified Data.ByteString.Char8 as BS

import System.Environment ( getArgs, getEnv )
import System.Exit ( exitFailure )
import System.IO ( hPutStrLn, stderr )

import GitHub.Auth ( Auth( OAuth ) )
import GitHub.Data.Issues ( Issue( Issue, issueMilestone, issueNumber, issueTitle, issueClosedBy, issueUrl ) )
import GitHub.Data.Name ( Name( N ) )
import GitHub.Data.Milestone ( Milestone( milestoneNumber, milestoneTitle ) )
import GitHub.Data.Options ( stateClosed )
-- Did not help:
-- import GitHub.Data.Options ( IssueState(..), IssueRepoMod(..) ) -- not exported:, FilterBy(..) )
import GitHub.Data.URL ( URL, getUrl )

import qualified GitHub.Endpoints.Issues.Milestones as GH ( milestones' )
import qualified GitHub.Endpoints.Issues as GH ( issuesForRepo' )

envGHToken = "GITHUBTOKEN"
owner = "agda"
repo  = "agda"
theRepo = owner ++ "/" ++ repo

main :: IO ()
main = getArgs >>= \case { [arg] -> run (Text.pack arg) ; _ -> usage }

usage :: IO ()
usage = putStrLn $ unlines
  [ "Usage: ClosedIssuesForMilestone <milestone>"
  , ""
  , "Retrieves closed issues for the given milestone from github repository"
  , theRepo ++ " and prints them to stdout."
  ]

-- | Retrieve closed issues for the given milestone and print to stdout.
run :: Text -> IO ()
run mileStoneTitle = do

  -- Get authentication token from environment.
  auth <- OAuth . BS.pack <$> getEnv envGHToken

  -- Resolve milestone into milestone id.
  mileStoneVector <- crashOr $ GH.milestones' (Just auth) (N owner) (N repo)
  mileStoneId <- case filter ((mileStoneTitle ==) . milestoneTitle) $ toList mileStoneVector of
    []  -> die $ "Milestone " ++ Text.unpack mileStoneTitle ++ " not found in github repo " ++ theRepo
    [m] -> return $ milestoneNumber m
    ms  -> die $ "Milestone " ++ Text.unpack mileStoneTitle ++ " ambiguous in github repo " ++ theRepo

  -- Get list of issues.
  issueVector <- crashOr $ GH.issuesForRepo' (Just auth) (N owner) (N repo) $ stateClosed
    -- Symbols not exported, thus, this does not work:
    -- IssueRepoMod $ \ o ->
    --   o { issueRepoOptionsMilestone = FilterBy mileStoneId
    --     , issueRepoOptionsState     = Just StateClosed
    --     }

  -- Filter by milestone.
  let issues = reverse
        [ i
        | i <- toList issueVector
        , m <- maybeToList $ issueMilestone i
        ,  milestoneNumber m == mileStoneId
        ]

  -- Print issues.
  forM_ issues $ \ Issue{ issueNumber, issueTitle } -> putStrLn $
    "  [#" ++ show issueNumber
    ++ "](https://github.com/" ++ theRepo ++ "/issues/" ++ show issueNumber
    ++ "): " ++ Text.unpack issueTitle

-- | Crash on exception.
crashOr :: Show e => IO (Either e a) -> IO a
crashOr m = either (die . show) return =<< m

-- | Crash with error message
die :: String -> IO a
die e = do hPutStrLn stderr e; exitFailure

Satisfactory version (using github-0.28) at: https://github.com/agda/agda/blob/35e2c803ca110af5fb7c8bc90c3f4038fbe2c047/src/release-tools/closed-issues-for-milestone/Main.hs


added date and time function

Added date and day function to tell day and date

Duplicate of https://github.com/Melissa-AI/Melissa-Core/pull/83.


convert should recover orphaned blocks

A volume might have allocation blocks that are marked in the volume bitmap as in use but not actually assigned to an extent. There might be data in these blocks that would be lost if a conversion didn't take care to preserve them.
One way to do this might be to create a new file in the destination volume and copy the orphaned blocks as that file's contents.

Note that recovered data might be a data fork or a resource fork. The copied blocks should be assigned to both forks; if the data is a resource map, then it will at least be viewable in ResEdit and possibly be usable if the file's correct type can be guessed.
(Of course, it might also be a data fork and a resource fork, but we can't help that since we can't tell where anything was supposed to begin or end among the recovered blocks.)

I have a working implementation of this, but it's too sensitive and not specific enough: It also creates the recovery file on volumes that have no orphaned blocks, because the creation of the recovery file has to happen before the catalog is finalized (and its space allocated), but no real files have been copied (and their blocks visited) yet, so the orphan check at that time thinks almost everything is orphaned.
The existing “how many blocks haven't been visited yet?” check (which was originally a debugging method) won't work at that point in the process; I'll need to implement a new, separate traversal of the source catalog's leaf row, marking off blocks in a separate copy of the VBM.

Whoops, I already filed this. Duplicate of #58.


Browser as ENV variable (NOWEB)

Idea:
Add browser as a env.variable
https://github.com/devlikeapro/whatsapp-http-api/blob/f2d0001b118541e968287f75cf9242691c5de225/src/core/session.noweb.core.ts#L126

For the record - it's not possible to change the title for WEBJS engine - it must be one of well know browser and OS anyway (because the engine actually ask web.whatsapp site to get the page)
Looking at this on NOWEB, we need to first fix a bug in the engine

https://github.com/WhiskeySockets/Baileys/pull/485


readme: Add circleci badge

Codecov Report

Merging #2784 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #2784   +/-   ##
=======================================
  Coverage   99.91%   99.91%
=======================================
  Files          23       23
  Lines        1233     1233
=======================================
  Hits         1232     1232
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fcef54...a35d2ce. Read the comment docs.


THCI: update thci with MGMT_PANID_QUERY method.

Current coverage is 69.02% (diff: 100%)

Merging #727 into master will decrease coverage by 0.37%

@@             master       #727   diff @@
==========================================
  Files           102        102
  Lines         15373      15373
  Methods        2100       2101     +1
  Messages          0          0
  Branches       1829       1829
==========================================
- Hits          10668      10611    -57
- Misses         4128       4181    +53
- Partials        577        581     +4

Powered by Codecov. Last update aeba71b...e4482e6


Revert "Revert "[eas-json] validate EAS Submit inputs better""

Why
Apply changes from https://github.com/expo/eas-cli/pull/2198 with fixes
How
Same as for https://github.com/expo/eas-cli/pull/2198, but I made constraints for validating ascApiKeyId and ascAppId more loose and added some comments.
Test plan
Tests

/changelog-entry chore Add better validation for EAS Submit inputs


Instagram Log in "message": "Invalid state parameter provided"

Hello,
All was working great in testing, now I'm into production-level testing with quite a few users and experiencing severe problems. It only seems to occur on the first log in, so may be an Instagram API issue, but likely something with the callback?
I believe I was running 0.8.0 ionic-cloud, and will retry on the next production with 0.11.0 (@latest), however, I can't see that any auth has changed since?
In the code, I call:
  this.auth.login('instagram').then(()=>{
    this.navCtrl.push(HomePage);
    this.navCtrl.setRoot(HomePage);
  })

After the user has entered their credentials, an error shows up with:
 {"meta": {"request_id": "c6735e79-d754-4032-c009-df07a2eb1106", "status": 400, "version": "2.0.0-beta.0"}, "error": {"type": "BadRequest", "link": null, "message": "Invalid state parameter provided"}}
in the In-app browser.
Ionic info:
Cordova CLI: 6.5.0
Ionic Framework Version: 2.1.0
Ionic CLI Version: 2.2.1
Ionic App Lib Version: 2.2.0
Ionic App Scripts Version: 1.1.4
ios-deploy version: 1.9.0
ios-sim version: 5.0.8
OS: macOS Sierra
Node Version: v7.2.0
Xcode version: Xcode 8.2.1 Build version 8C1002

  "dependencies": {
    "@angular/common": "2.2.1",
    "@angular/compiler": "2.2.1",
    "@angular/compiler-cli": "2.2.1",
    "@angular/core": "2.2.1",
    "@angular/forms": "2.2.1",
    "@angular/http": "2.2.1",
    "@angular/platform-browser": "2.2.1",
    "@angular/platform-browser-dynamic": "2.2.1",
    "@angular/platform-server": "2.2.1",
    "@ionic/cloud-angular": "0.11.0",
    "@ionic/storage": "^1.1.7",
    "ionic-angular": "2.1.0",
    "ionic-native": "2.2.11",
    "ionicons": "3.0.0",
    "rxjs": "5.0.0-beta.12",
    "zone.js": "0.6.26"
  },

UPDATE: It seems to be when more than one user is logging in at the same time. Definitely needs attention..

Update: I have built a new project with "@ionic/cloud-angular": "0.16.0",, and replicated the issue showing that it is more than one user that causes the problem. Here's a video (apologies for focus, struggle to do one handed, haha).
https://youtu.be/SYUe04VBlU0
Would be awesome to get a fix soon or I'll have to think about setting up a server//other solutions.
Thanks :)

Hi @nicksmithr, thank you for bringing this to our attention, and apologies for the issues it may have caused you. I believe I've just put in a fix that should address this, can you confirm that you're able to login with multiple devices at the same time now?

Hi @ericb unfortunately it didn't. I tried with 2 iPhones and a Pixel at the same time, and only the Pixel logged in. I no longer get the same error message, but one iPhone is stuck re-loading, and another re-directs to the "Error" Instagram API log in page.
Oddly 2 iPhones at the same time worked; and when I log in on the iPhone a few hundreds ms before the Android. But not if Android logs in first? I'm unsure if OS has any inference here?

All seems good for now @ericb will let you know any problems I have with Beta testers. Thank you for the fix 👍

Great, glad to hear it. 👏


tasks/ruby/easy/hello.rb

Pull Request Type
What kind of change does this PR introduce?
[ ] Solved an issue/task
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:
What is the current behavior?

Issue Number: #1085
What is the new behavior?

Other information

@nikohoffren
Kindly review my PR and please merge it.

Merged

This is an automated message from Fork, Commit, Merge [BOT].

Thank you for your contribution! Your pull request has been merged. The files have been reset for the next contributor.
What's next?
If you're looking for more ways to contribute, I invite you to check out my other projects. Just click here to find more. These projects contain real issues that you can help resolve. You can also check out the Influences section in the README to find more projects similar to this one.
Also please leave a star to this project if you feel it helped you, i would really appreciate it.
I look forward to seeing your contributions!


Autofixing

We should have the ability to support autofixing

A first version for eslint check would help already, don't know if this is easier than the whole feature.

Done in #82


Setting config in cli arguments

This is the best way I could come. Please improve it if possible or let me know if there are easier ways to do it.
// in file shipitfile.js

  // If cli has "key=value" arguments
  // then update shipit config
  // e.g. $ shipit staging deploy key=./deployment_id_rsa
  shipit.on('init', function(){
    var _config = {};
    for (var i in process.argv) {
      var arg = process.argv[i];
      if (arg.includes('=')) {
        var parts = arg.split("=");
        if (0 < parts[0].length){
          _config[parts[0]] = parts.slice(1).join("=");
          shipit.add(arg, function(){}) // add empty tasks
        }
      }
    }
    shipit.config = _.merge(shipit.config, _config);
  })

@Zhomart If it were me, I would use http://yargs.js.org/ or something similar and use it to pass the config items I want to set via cli.
I don't think we need to bake it in.

@timkelty if you don't mind, can you provide simple example please?

Something like
var argv = require('yargs')
.option('key', {
  type: 'string',
})
.option('servers', {
  type: 'string',
})
.argv;

module.exports = function (shipit) {
  require('shipit-deploy')(shipit);

  shipit.initConfig({
    default: {
      key: argv.key,
    },
    staging: {
      servers: argv.servers
    }
  });
};

Thank you @timkelty. However, I don't want to add one more dependency, I'll use env variable.

Yeah, I'm with @Zhomart ... I want to keep my package dependencies focused and not cluttered


Created postgres nomad job

Created postgres nomad job and created volume in nomad client.

This PR is for issue #18


Add contributing guidelines and code of conduct

Code of conduct is adapted from Contributor Covenant. Contributing guidelines are adapted from STEMMRoleModels.

@tyarkoni Is there anything else we need to make it easy for any potential first time contributors? Currently, this PR will add a code of conduct and contributing guidelines, which include style preferences (PEP8 + numpydoc, unless you'd prefer something else) for the project. Would a pull request or issues template be useful?
Also, I put your email address in the code of conduct as the point of contact, but I can change it to someone else if you want (e.g., me, @angielaird, or anyone else who's willing and able to fulfill that responsibility).

This PR only has minor changes and is ready to merge, I think. @tyarkoni do you mind if I merge it?

Fire at will!

Thanks! Hopefully including a code of conduct and contributing guidelines will make it easier for third parties to get involved with NiMARE.


takePicture captures first frame from output buffer instead of current frame

When you take a picture, the picture taken isn't actually the picture in your frame when the image was supposed to be captured. Instead, the first (at least, I think it's the first..) frame that is outputted to the AVCaptureStillImageOutput instance is the frame that is captured by captureStillImageAsynchronouslyFromConnection. I'm looking for some help on this, as I'm not really sure what the problem is.

i think this is related to  : https://github.com/facebook/react-native/issues/725
you need to create an array as singleton. add all objects on manager's init method to that. and on a callback or some time later check if an object doesn't have a reactTag. if object doesn't have a reactTag it's a temp object for react and will not be on the js side.
for reactTag look at "UIView+React.h"

@kocyigityunus Sorry, I'm not quite sure I'm seeing the correlation here. Do you think you can elaborate on how this affects the captureStillImageAsynchronouslyFromConnection callback?

i think there is 2 layer when started. and only one of them continuing to update after first round. and ypu are trying to take picture from the first one.

That definitely sounds possible. But my callback doesn't reference a view (which, as per your instruction, I would use to check for reactTag), so I'm not sure how I could make sure the callback is referencing the right objects. Would I want to somehow associate each object with the current camera view's reactTag during the init?

@kocyigityunus Maybe the best solution is to store the objects inside the camera view?

actually. on the init method at the manager. reactTag is always null. after first round or after some method call the reactTag fill with the right id to one of two objects. so i think you can continue to manager as a singleton manager. but you need to seperate that two views.
i am still trying to learn this manager things etc.

Yeah I'm new to this too. And Objective-C programming hahah. I'm going to try and store all state in RCTCamera, and then delegate manager method invocations to the RCTCamera. This should keep the manager stateless (which I think is preferred?)

That worked!

congratulations. i think this will be a great reference project for beginners.


Update rmarkdown.md

Put directly link on "RMarkdown".

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot


mapStateToProps not initialize state

I use redux-dynamic-modules/todo-example after run below error.
src/containers/root/FilterLink.js:6
TypeError: Cannot read property 'visibilityFilter' of undefined

const mapStateToProps = (state, ownProps) => ({
   active: ownProps.filter === state.root.visibilityFilter,
});

I use<EMAIL_ADDRESS>in my project too same error.

Which version of react-redux are you using?

@HASSANDL We are aware of an issue with<EMAIL_ADDRESS>which we have yet to resolve. Stay tuned

@abettadapur Very very thanks. downgrade to<EMAIL_ADDRESS>problem solved.

Closing this for now, as it is tracked by #27


docs: define preheat api using swagger

Signed-off-by: lowzj<EMAIL_ADDRESS>Ⅰ. Describe what this PR did
define preheat api using swagger

apis/types/error_response.go:14:62: "occured" is a misspelling of "occurred"
./apis/swagger.yml:585:51: "occured" is a misspelling of "occurred"

need update.

Codecov Report

Merging #204 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #204   +/-   ##
=======================================
  Coverage   81.43%   81.43%
=======================================
  Files          28       28
  Lines        1282     1282
=======================================
  Hits         1044     1044
  Misses        207      207
  Partials       31       31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e07f494...dc0b051. Read the comment docs.

LGTM


Particles

The Particle Cloud integration should work now. Therefore this PR can be checked and merged.

The Particle Cloud integration should work now. Therefore this PR can be checked and merged.


Proposal: Disable/Enable credential providers at runtime

Goals

Disable/enable credential providers at run time
Bonus: Allow credential providers to enable/disable based on the calling client

Background
Credential providers declare there capabilities via marked Android manifest entries. Clients discover credential providers by querying for the canonical entries via the PackageManager. For the Save/Hint flows there are no additional "handshakes" and the client will then assume the credential provider is capable of handling their request.
Of course credential providers are free to decide to not handle a hint/save request once it sent, but this is not ideal as it interferes with credential provider choice logic.
Possible Solutions:
1.  Enable/disable OpenYOLO components via PM.setComponentEnabledSetting().
Pros:

Keeps the spec simple

Cons:

Can not filter based on client.
Credential providers do not have the opportunity enable/disable in response to discovery.

2. BBQ handshake
Pros:

Credential providers are able to enable/disable in response to discovery and can filter per client.

Cons:

Complicates the spec.
BBQ requests introduce a sizable latency (~2 secs per request is the current timeout)

I think the ability to disable providers at runtime is going to be a short term problem, while OpenYOLO is still not fully baked. That said, providing some guidelines as to how to do this, preferably without changing the protocol, would be wise. I would opt for option 1 from your possible solutions.

We did get the same issue on our end. If a user is not logged in, we didn't want to propose ourself as a possibility for save or hint.
But as you mentioned on the option 2, the latency is huge and I don't think it's worth it.
For now I think we are going to handle option 1 by either propose of the user to logged in (but it will break the flow of the third party app) or by just saying "We cannot do that until you logged in yourself".

It seems worth considering client/spi versioning (i.e. is my client compatible with a given credential provider) when thinking about this issue. The two problems are very similar and may share a solution.

I believe solution 1: Enable/disable OpenYOLO components via PM.setComponentEnabledSetting(), should be the approach recommended.


feat: support text scaling (sp instead of dp)

Add new ScalarValue<TextUnit> and const functions for the unit. There's a @Composable one to provide font scaling automatically. If the provided text unit is in ems, it's considered relative to 16sp, the default font size of the map.

#134  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

(1) Fully expecting to redo this if/when scaling is supported in native. Will link the issue
(2) I don't think supporting TextUnit is possible for those properties. a ScalarValue<TextUnit> is internally represented as SP. If it was initially provided as EM, we would divide it by the textSize expression, but if it was initially provided as SP, we wouldn't. That information is lost at the time of the EM -> SP conversion.
I think this is better thought of as an "SP unit" rather than a "TextUnit unit". To reduce confusion, we could update the documentation to say "in multiples of the text size" instead of "in ems".
(3) I'm also unsure, but in any case the documentation for TextStyle and LocalTextStyle refers specifically to a Text component. I think it's reasonable for a map component to have its own internal text style, and the value passed in here is merely configuration for that style. Or in other words, imagine a component like this:
@Composable
fun fun App() {
  FakeMap(fontSize = 1.em)
}

@Composable
fun FakeMap(fontSize: TextUnit) {
  ProvideTextStyle(someTextStyle) {
    Text("example", fontSize = fontSize)
  }
}

Even in that component, the font size passed in is relative to the text style internal to FakeMap, not the local text style outside that component. Our map (or map layer) is essentially that.
https://github.com/sargunv/maplibre-compose/pull/136 makes some tweaks

There's one more issue, that symbol layers defined in the base JSON style don't get scaled. Technically fixable, but I think it'd be weird to redefine the meaning of the json style spec, so I think it's better to leave that API as DP, while making our composable API support SP.

Hmm, I may have a workable idea to make all the sp/em properties support TextUnit fully. What if TextUnitValue wasn't a ScalarValue<TextUnit>, but rather a direct descendant of ExpressionValue? And then it was backed by a class, with a type discriminator and functions to map it to an dp/em float expression? SymbolLayer's composable could do that mapping before passing it to the SymbolLayer wrapper class (passing the textSize expression into the em converters)
public class TextUnitValue internal constructor(
  internal val expr: Expression<FloatValue>,
  internal val type: TextUnitType,
) :
  ExpressionValue,
  MatchableValue,
  InterpolateableValue<TextUnit>,
  ComparableValue<TextUnit>,
  EquatableValue {
  internal fun toDpExpression(
    textSizeExpression: Expression<FloatValue>,
    fontScale: Float,
  ): Expression<FloatValue> {
    return when (type) {
      TextUnitType.Sp -> expr * const(fontScale)
      TextUnitType.Em -> expr * textSizeExpression * const(fontScale)
      else -> error("Unsupported text unit type: $type")
    }
  }

  internal fun toEmExpression(textSizeExpression: Expression<FloatValue>): Expression<FloatValue> {
    return when (type) {
      TextUnitType.Sp -> expr / textSizeExpression
      TextUnitType.Em -> expr
      else -> error("Unsupported text unit type: $type")
    }
  }
}

There's one more issue, that symbol layers defined in the base JSON style don't get scaled. Technically fixable, but I think it'd be weird to redefine the meaning of the json style spec, so I think it's better to leave that API as DP, while making our composable API support SP. Upstream will need to figure out how to handle this (breaking change to the style spec? new scale property?) too, and we can follow their lead rather than solving it ourselves.

on web, I think there is not even really the notion of sp at all, so its natural that the spec doesn't really mention this.
Instead, every browser has its own way to deal with this. E.g. IIRC if you scale your font size to 200% on Android, all web content is displayed at 200% (including MapLibre). So, the accessibility font size is respected, and in MapLibre web automatically, too, but does more than just to scale the text.

Some data points:

Google Maps on Android scales text on the map independently of the rest of the map style.
Google Maps on web (Chromium on Android) doesn't respond to the accessibility font scale setting at all
MapLibre on web (same browser) doesn't respond to the accessibility font scale setting at all

I haven't tried desktop yet, not checked what Compose- does on web / desktop / iOS.
https://github.com/user-attachments/assets/f9587661-39f8-413a-8081-a07d0859f921
https://github.com/user-attachments/assets/d05998e4-5a27-4ad1-b784-32bb37b8c9a8
https://github.com/user-attachments/assets/3d4e03bc-67c6-4ca2-aa6e-ae9016f7d65c


Prior art example: iframes and the DOM they contain

@caridy You mentioned this in a SES meeting, and I'd appreciate some elaboration.

Today, the object graphs of both, the main window and a same-domain iframe can be mixed, meaning you can hold references to objects from another realm, additionally, the iframe has access to various DOM APIs. Once the iframe is removed (we call it detach) from the DOM, all those DOM APIs associated to the iframe, and accessible to the functions in memory are automatically placed in a state that will throw if those APIs get called because the iframe does not have an origin anymore. That's not the same behavior for language features, since those do not require access to the host behavior.


Tasks to import vectors from local/s3 files, Geopedia and GeoDB.

EOTask to import vectors from:

local file
s3 file (depends on AWS credentials specified in sentinelhub-py config)
Geopedia table (depends on geopedia credentials specified in sentinelhub-py config)
GeoDB collection (to run test, client id and secret should be in the environment)

Should I add git+git://github.com/dcs4cop/xcube-geodb.git to a list of requirements?

Should I add git+git://github.com/dcs4cop/xcube-geodb.git to a list of requirements?

Hm, I'm leaning towards having this as a package extension dependency. That is because the package does not have a full/stable support for pip, only for conda. As you can see here installing it with pip won't install package dependencies so we also have to add those.
In either case, please add it in a form of
xcube-geodb @ git+git://github.com/dcs4cop/xcube-geodb.git

Only this way the setup will install it, otherwise it will be ignored.

One more thing: Please add documentation page for the new module.


HANS-268: Integrate create care recipient page with serverless component

Same as #13 - tests fail for me. But also I'm not sure moving the nhs number hashing out of the model is the right thing to do.

imo model should reflect what's stored in database. Since we do not store plain-text nhs numbers, the model shouldn't do the job of controller.

Same as #13 - tests fail for me. But also I'm not sure moving the nhs number hashing out of the model is the right thing to do.

Exact command you provided works for me, can you retry with clean docker rebuilt project?

Same as #13 - tests fail for me. But also I'm not sure moving the nhs number hashing out of the model is the right thing to do.

imo model should reflect what's stored in database. Since we do not store plain-text nhs numbers, the model shouldn't do the job of controller (in our case form).

I don't disagree, but if we're going to say "the model should only concern itself with the database storage" then we should also move subscription API responsibility out of it for consistency.  From a conceptual viewpoint either the Django model should take strong responsibility for all the business logic (including storage) or we should identify a specific alternative place that logic should live, and leave the Django model to only handle the database.
This is what I meant by cutting against the grain: I get the feeling that the more logic we move out of the Django model, the more we're going to be tripping up the admin interface. Happy to be proved wrong if we've got a good pattern for doing it, but I'm worried about creating work for ourselves by having to work around too much of Django to make it worthwhile.

@henrywrightPSC @regularfry

Django is reasonable strong on this and says that all relevant domain logic belongs with the models - see the design pattern here on active records

Additional field (plain-texted nhs_number) is not domain logic though. Going by that, we should also couple the model with dob, given_name, family_name fields which doesn't make any sense (imo).
If we were storing plain-text nhs_number, then the logic of implementing a function masking it in the output should be a part of a model.

I don't disagree, but if we're going to say "the model should only concern itself with the database storage" then we should also move subscription API responsibility out of it for consistency.

Completely agree on that point, and it's not a part of model logic. I did use a Form as a controller, perhaps it should be moved away to separate module/class? (I don't think it's necessary, as Form in Django quite nicely fills the controller role).

@henrywrightPSC @regularfry

Django is reasonable strong on this and says that all relevant domain logic belongs with the models - see the design pattern here on active records

Additional field (plain-texted nhs_number) is not domain logic though. Going by that, we should also couple the model with dob, given_name, family_name fields which doesn't make any sense (imo).
If we were storing plain-text nhs_number, then the logic of implementing a function masking it in the output should be a part of a model.

I don't disagree, but if we're going to say "the model should only concern itself with the database storage" then we should also move subscription API responsibility out of it for consistency.

Completely agree on that point, and it's not a part of model logic. I did use a Form as a controller, perhaps it should be moved away to separate module/class? (I don't think it's necessary, as Form in Django quite nicely fills the controller role).

I'm convinced @michal-kras!

@henrywrightPSC @regularfry

Django is reasonable strong on this and says that all relevant domain logic belongs with the models - see the design pattern here on active records

Additional field (plain-texted nhs_number) is not domain logic though. Going by that, we should also couple the model with dob, given_name, family_name fields which doesn't make any sense (imo).
If we were storing plain-text nhs_number, then the logic of implementing a function masking it in the output should be a part of a model.

This is exactly it: we don't want a field, but Django only wants us to pass data into the model's scope via fields.  All we really want is a def set_nhs_number method but hooking that into Django is painful.
I think using the Form as the controller works.

Nearly there...
 $ docker-compose exec web python manage.py test
Found 25 test(s).
Creating test database for alias 'default'...
System check identified no issues (0 silenced).
.................EE......
======================================================================
ERROR: test_admin_upload_csv_file_successfully (management_interface.test_views.AdminCareProviderLocationTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/app/management_interface/test_views.py", line 133, in test_admin_upload_csv_file_successfully
    response = self._get_upload_file_response(csv_file)
  File "/app/management_interface/test_views.py", line 68, in _get_upload_file_response
    response = self.client.post(
  File "/usr/local/lib/python3.10/site-packages/django/test/client.py", line 852, in post
    response = super().post(
  File "/usr/local/lib/python3.10/site-packages/django/test/client.py", line 441, in post
    return self.generic(
  File "/usr/local/lib/python3.10/site-packages/django/test/client.py", line 541, in generic
    return self.request(**r)
  File "/usr/local/lib/python3.10/site-packages/django/test/client.py", line 810, in request
    self.check_exception(response)
  File "/usr/local/lib/python3.10/site-packages/django/test/client.py", line 663, in check_exception
    raise exc_value
  File "/usr/local/lib/python3.10/site-packages/django/core/handlers/exception.py", line 56, in inner
    response = get_response(request)
  File "/usr/local/lib/python3.10/site-packages/django/core/handlers/base.py", line 197, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/usr/local/lib/python3.10/site-packages/django/utils/decorators.py", line 134, in _wrapped_view
    response = view_func(request, *args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/django/views/decorators/cache.py", line 62, in _wrapped_view_func
    response = view_func(request, *args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/django/contrib/admin/sites.py", line 242, in inner
    return view(request, *args, **kwargs)
  File "/app/management_interface/admin.py", line 124, in import_care_recipients
    created_care_recipients, errors = self._bulk_create_care_recipients(
  File "/app/management_interface/admin.py", line 183, in _bulk_create_care_recipients
    if form.errors:
  File "/usr/local/lib/python3.10/site-packages/django/forms/forms.py", line 200, in errors
    self.full_clean()
  File "/usr/local/lib/python3.10/site-packages/django/forms/forms.py", line 438, in full_clean
    self._clean_form()
  File "/usr/local/lib/python3.10/site-packages/django/forms/forms.py", line 459, in _clean_form
    cleaned_data = self.clean()
  File "/app/management_interface/forms.py", line 56, in clean
    self.cleaned_data["subscription_id"] = self._create_subscription()
  File "/app/management_interface/forms.py", line 67, in _create_subscription
    return ManagementAPIClient().create_subscription(
  File "/app/internal_integrations/management_api/client.py", line 17, in __init__
    self.base_url = base_url or get_management_api_settings().base_url
  File "/app/internal_integrations/management_api/settings.py", line 15, in get_management_api_settings
    return ManagementAPISettings()
  File "/usr/local/lib/python3.10/site-packages/pydantic/env_settings.py", line 39, in __init__
    super().__init__(
  File "/usr/local/lib/python3.10/site-packages/pydantic/main.py", line 341, in __init__
    raise validation_error
pydantic.error_wrappers.ValidationError: 1 validation error for ManagementAPISettings
base_url
  field required (type=value_error.missing)

======================================================================
ERROR: test_admin_upload_csv_file_with_broken_row (management_interface.test_views.AdminCareProviderLocationTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/app/management_interface/test_views.py", line 142, in test_admin_upload_csv_file_with_broken_row
    response = self._get_upload_file_response(csv_file)
  File "/app/management_interface/test_views.py", line 68, in _get_upload_file_response
    response = self.client.post(
  File "/usr/local/lib/python3.10/site-packages/django/test/client.py", line 852, in post
    response = super().post(
  File "/usr/local/lib/python3.10/site-packages/django/test/client.py", line 441, in post
    return self.generic(
  File "/usr/local/lib/python3.10/site-packages/django/test/client.py", line 541, in generic
    return self.request(**r)
  File "/usr/local/lib/python3.10/site-packages/django/test/client.py", line 810, in request
    self.check_exception(response)
  File "/usr/local/lib/python3.10/site-packages/django/test/client.py", line 663, in check_exception
    raise exc_value
  File "/usr/local/lib/python3.10/site-packages/django/core/handlers/exception.py", line 56, in inner
    response = get_response(request)
  File "/usr/local/lib/python3.10/site-packages/django/core/handlers/base.py", line 197, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/usr/local/lib/python3.10/site-packages/django/utils/decorators.py", line 134, in _wrapped_view
    response = view_func(request, *args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/django/views/decorators/cache.py", line 62, in _wrapped_view_func
    response = view_func(request, *args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/django/contrib/admin/sites.py", line 242, in inner
    return view(request, *args, **kwargs)
  File "/app/management_interface/admin.py", line 124, in import_care_recipients
    created_care_recipients, errors = self._bulk_create_care_recipients(
  File "/app/management_interface/admin.py", line 183, in _bulk_create_care_recipients
    if form.errors:
  File "/usr/local/lib/python3.10/site-packages/django/forms/forms.py", line 200, in errors
    self.full_clean()
  File "/usr/local/lib/python3.10/site-packages/django/forms/forms.py", line 438, in full_clean
    self._clean_form()
  File "/usr/local/lib/python3.10/site-packages/django/forms/forms.py", line 459, in _clean_form
    cleaned_data = self.clean()
  File "/app/management_interface/forms.py", line 56, in clean
    self.cleaned_data["subscription_id"] = self._create_subscription()
  File "/app/management_interface/forms.py", line 67, in _create_subscription
    return ManagementAPIClient().create_subscription(
  File "/app/internal_integrations/management_api/client.py", line 17, in __init__
    self.base_url = base_url or get_management_api_settings().base_url
  File "/app/internal_integrations/management_api/settings.py", line 15, in get_management_api_settings
    return ManagementAPISettings()
  File "/usr/local/lib/python3.10/site-packages/pydantic/env_settings.py", line 39, in __init__
    super().__init__(
  File "/usr/local/lib/python3.10/site-packages/pydantic/main.py", line 341, in __init__
    raise validation_error
pydantic.error_wrappers.ValidationError: 1 validation error for ManagementAPISettings
base_url
  field required (type=value_error.missing)

----------------------------------------------------------------------
Ran 25 tests in 1.603s

FAILED (errors=2)
Destroying test database for alias 'default'...

Missed a commit?

Nearly there...
 $ docker-compose exec web python manage.py test
Found 25 test(s).
Creating test database for alias 'default'...
System check identified no issues (0 silenced).
.................EE......
======================================================================
ERROR: test_admin_upload_csv_file_successfully (management_interface.test_views.AdminCareProviderLocationTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/app/management_interface/test_views.py", line 133, in test_admin_upload_csv_file_successfully
    response = self._get_upload_file_response(csv_file)
  File "/app/management_interface/test_views.py", line 68, in _get_upload_file_response
    response = self.client.post(
  File "/usr/local/lib/python3.10/site-packages/django/test/client.py", line 852, in post
    response = super().post(
  File "/usr/local/lib/python3.10/site-packages/django/test/client.py", line 441, in post
    return self.generic(
  File "/usr/local/lib/python3.10/site-packages/django/test/client.py", line 541, in generic
    return self.request(**r)
  File "/usr/local/lib/python3.10/site-packages/django/test/client.py", line 810, in request
    self.check_exception(response)
  File "/usr/local/lib/python3.10/site-packages/django/test/client.py", line 663, in check_exception
    raise exc_value
  File "/usr/local/lib/python3.10/site-packages/django/core/handlers/exception.py", line 56, in inner
    response = get_response(request)
  File "/usr/local/lib/python3.10/site-packages/django/core/handlers/base.py", line 197, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/usr/local/lib/python3.10/site-packages/django/utils/decorators.py", line 134, in _wrapped_view
    response = view_func(request, *args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/django/views/decorators/cache.py", line 62, in _wrapped_view_func
    response = view_func(request, *args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/django/contrib/admin/sites.py", line 242, in inner
    return view(request, *args, **kwargs)
  File "/app/management_interface/admin.py", line 124, in import_care_recipients
    created_care_recipients, errors = self._bulk_create_care_recipients(
  File "/app/management_interface/admin.py", line 183, in _bulk_create_care_recipients
    if form.errors:
  File "/usr/local/lib/python3.10/site-packages/django/forms/forms.py", line 200, in errors
    self.full_clean()
  File "/usr/local/lib/python3.10/site-packages/django/forms/forms.py", line 438, in full_clean
    self._clean_form()
  File "/usr/local/lib/python3.10/site-packages/django/forms/forms.py", line 459, in _clean_form
    cleaned_data = self.clean()
  File "/app/management_interface/forms.py", line 56, in clean
    self.cleaned_data["subscription_id"] = self._create_subscription()
  File "/app/management_interface/forms.py", line 67, in _create_subscription
    return ManagementAPIClient().create_subscription(
  File "/app/internal_integrations/management_api/client.py", line 17, in __init__
    self.base_url = base_url or get_management_api_settings().base_url
  File "/app/internal_integrations/management_api/settings.py", line 15, in get_management_api_settings
    return ManagementAPISettings()
  File "/usr/local/lib/python3.10/site-packages/pydantic/env_settings.py", line 39, in __init__
    super().__init__(
  File "/usr/local/lib/python3.10/site-packages/pydantic/main.py", line 341, in __init__
    raise validation_error
pydantic.error_wrappers.ValidationError: 1 validation error for ManagementAPISettings
base_url
  field required (type=value_error.missing)

======================================================================
ERROR: test_admin_upload_csv_file_with_broken_row (management_interface.test_views.AdminCareProviderLocationTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/app/management_interface/test_views.py", line 142, in test_admin_upload_csv_file_with_broken_row
    response = self._get_upload_file_response(csv_file)
  File "/app/management_interface/test_views.py", line 68, in _get_upload_file_response
    response = self.client.post(
  File "/usr/local/lib/python3.10/site-packages/django/test/client.py", line 852, in post
    response = super().post(
  File "/usr/local/lib/python3.10/site-packages/django/test/client.py", line 441, in post
    return self.generic(
  File "/usr/local/lib/python3.10/site-packages/django/test/client.py", line 541, in generic
    return self.request(**r)
  File "/usr/local/lib/python3.10/site-packages/django/test/client.py", line 810, in request
    self.check_exception(response)
  File "/usr/local/lib/python3.10/site-packages/django/test/client.py", line 663, in check_exception
    raise exc_value
  File "/usr/local/lib/python3.10/site-packages/django/core/handlers/exception.py", line 56, in inner
    response = get_response(request)
  File "/usr/local/lib/python3.10/site-packages/django/core/handlers/base.py", line 197, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/usr/local/lib/python3.10/site-packages/django/utils/decorators.py", line 134, in _wrapped_view
    response = view_func(request, *args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/django/views/decorators/cache.py", line 62, in _wrapped_view_func
    response = view_func(request, *args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/django/contrib/admin/sites.py", line 242, in inner
    return view(request, *args, **kwargs)
  File "/app/management_interface/admin.py", line 124, in import_care_recipients
    created_care_recipients, errors = self._bulk_create_care_recipients(
  File "/app/management_interface/admin.py", line 183, in _bulk_create_care_recipients
    if form.errors:
  File "/usr/local/lib/python3.10/site-packages/django/forms/forms.py", line 200, in errors
    self.full_clean()
  File "/usr/local/lib/python3.10/site-packages/django/forms/forms.py", line 438, in full_clean
    self._clean_form()
  File "/usr/local/lib/python3.10/site-packages/django/forms/forms.py", line 459, in _clean_form
    cleaned_data = self.clean()
  File "/app/management_interface/forms.py", line 56, in clean
    self.cleaned_data["subscription_id"] = self._create_subscription()
  File "/app/management_interface/forms.py", line 67, in _create_subscription
    return ManagementAPIClient().create_subscription(
  File "/app/internal_integrations/management_api/client.py", line 17, in __init__
    self.base_url = base_url or get_management_api_settings().base_url
  File "/app/internal_integrations/management_api/settings.py", line 15, in get_management_api_settings
    return ManagementAPISettings()
  File "/usr/local/lib/python3.10/site-packages/pydantic/env_settings.py", line 39, in __init__
    super().__init__(
  File "/usr/local/lib/python3.10/site-packages/pydantic/main.py", line 341, in __init__
    raise validation_error
pydantic.error_wrappers.ValidationError: 1 validation error for ManagementAPISettings
base_url
  field required (type=value_error.missing)

----------------------------------------------------------------------
Ran 25 tests in 1.603s

FAILED (errors=2)
Destroying test database for alias 'default'...

Missed a commit?

Ok, that's a bit of pandora box we're opening here.
TLDR: add env_variable: MANAGEMENT_API_BASE_URL=https://fowvgbazdl.execute-api.eu-west-2.amazonaws.com/Prod/
They should pass, but clearly they are not unit tests anymore:

We can live with it
We can move them to separate package like: tests/integration
We can refactor them to mock out network dependencies

WDYT @regularfry ?

In this case I think I'd want a mock of the ManagementAPIClient class rather than mocking out the network call.  Don't mock what you don't own, and all that. It'll end up with a better structure.
I think we also want an integration test, mind, but the more important thing to me is getting the network call out of the unit test run.

In this case I think I'd want a mock of the ManagementAPIClient class rather than mocking out the network call. Don't mock what you don't own, and all that. It'll end up with a better structure.
I think we also want an integration test, mind, but the more important thing to me is getting the network call out of the unit test run.

This sounds good to me, will do.


added INSTALL_REQUIRES and updated README

Added gpustat to INSTALL_REQUIRES, otherwise it will fail while executing the get_freest_gpu function
Install tk - specifically for allegro_hand_dextreme task

The proposed commit fixed a problem that occured for me after the original installation :+1:

Thanks for testing out the changes @wredsen.
However, I am not sure if this repository is being actively maintained and how my PR is going to get merged.


Newer Version Than 1.5

Could the most current version be made available at maven central?
1.5 appears to be the most current version available but the documentation implies there is a 3.0-SNAPSHOT available, too?
Or, is the new version available at a different plugin repository?

3.0.0 has been released today, should soon be on Maven Central


Scope work for dumping the content of DST registers (ideally via DPRINT, or Watcher).

This is implemented in #4809.


General Updates

@sewagodimo @KaitCrawford @codiebeulaine  please review.
Updated .po file and general style.


Sieve of Eratosthenes algorithm

I want to do using C++

Can I do this ?

May I do this please!!

I have tried it , please check it, thanks

@galihsatriawan : please share the PR for reference

Enhancements are very much appreciated. Feel free to add a folder if you wish to provide solution in a different language

@jenistenxavier  can i work on this?

This is the referenced #281

Implemented Sieve ofEratosthenes algorithm in Java
This is the reference #394


Fix for Issue 704

This PR was raised to address the below mentioned PR.
https://github.com/Seagate/cortx/issues/704.

Did you test this yourself? Please add a screenshot of the command line after running the conversion.

@johnbent - I did not test it but this is the generic procedure for conversion.

Venky, please test this yourself and add a screenshot.


WIP: ANC Logic - prescribe Mebendazole

#113
#160

Before 24 weeks EGA:

After 24 weeks EGA:

@nedSaf please review


Close background inspectors of reloaded extensions

The background page inspector is the most important tool for extension development.
Unfortunately, when the chrome-extensions-reloader reloads an extension, it shuts everything down, including its inspector. As a result, we have to reopen the background inspector each time we save changes... which is painful and makes this extension useless
I am pretty sure there is a way to reload extensions without closing those background inspectors. For instance, the “Reload” button provided on the Chrome’s extension page keeps them opened. Any idea?

As far as I know, the only way for extension to reload another extension, is by using  chrome.management.setEnabled() and that what makes the background page inspection window to close itself.
Do you know of any other way to do so?

Unfortunately, I have no idea.
There is a method called chrome.runtime.reload()... It’s a bit surprising and frustrating that they didn’t add a reload method to the management object, isn’t it?

Indeed :)

One way to do it is to reload the chrome://extensions page.
chrome.tabs.query({url: 'chrome://extensions'}, function(tabs) {
  if (tabs.length === 0) {
    //Create a new tab of chrome://extensions
  } else {
    chrome.tabs.reload(tabs[0].id)
  }
});


[1669] Update production database URL

Context
The database was renamed to the default name created by terraform
Changes proposed in this pull request
Use the default connection string
Guidance to review
Check it's the same setting as the other environments
Link to Trello card
https://trello.com/c/HSsFc0wX

 Rename apply for TT database


E2E: Operator setup with --dry-run

Add test to check the validity the yaml from mirrord operator setup

I think this would be a redundant test when we add also setup of operator then using it?

I think this would be a redundant test when we add also setup of operator then using it?

Yeah but it would be a good place to start from when we do the full tests


Edit-Distance.c

Given two strings str1 and str2 and below operations that can be performed on str1. Find the minimum number of edits (operations) required to convert ‘str1’ into ‘str2’.
Test case :
Input:
sunday
saturday
Output:  3
Last three and first characters are same.  We basically
need to convert "un" to "atur".  This can be done using
below three operations.
Replace 'n' with 'r', insert t, insert a

I have noticed a certain thing

example should at the end of the file and out of function body

spacing is not in an ordered manner
eg.   function()
{
// this is the wrong way
}
     //right way
    function() {
               // this is the right method
     }

opening "{" braces will be at the end of the function definition line, not in the new line

Understood. I made suitable changes to the code as per my understanding.

I have made all the changes. You can go through it.


Add MMM ROAS Priors Case Study

Related to https://github.com/pymc-labs/pymc-marketing/issues/905
I adapt my case study https://juanitorduz.github.io/mmm_roas/  where I implement the model from the paper “Media Mix Model Calibration With Bayesian Priors”, by Zhang, et al., where the authors propose a convenient parametrization the regression model in terms of the ROAs (return on advertising spend) instead of the classical regression (beta) coefficients.
Here, we try to use the PyMC marketing lif-test approach to reproduce the results.

Also added pyprojroot following https://ericmjl.github.io/data-science-bootstrap-notes/use-pyprojroot-to-define-relative-paths-to-the-project-root/

📚 Documentation preview 📚: https://pymc-marketing--916.org.readthedocs.build/en/916/

@twiecki I worked on a more engaging intro. Please let me know what you think about it :)

Great stuff. One minor point of confusion, even though you say it in the intro, is that we don't model the confounder here, even though we might want to and that would be a great solution as well, just here we don't have it but can get around this through experimentation.

done! thanks

View entire conversation on ReviewNB

+1

View entire conversation on ReviewNB

+1

View entire conversation on ReviewNB

XD!

View entire conversation on ReviewNB

+1

View entire conversation on ReviewNB

XD. I will do!

View entire conversation on ReviewNB

Thank you, @twiecki, for your feedback! I addressed all the comments in https://github.com/pymc-labs/pymc-marketing/pull/916/commits/893ac51ab6d514d7753d1f758a41867b92f8aab5 . Apologies for so many typos. I thought I had fixed them before 🙈


Added localization support for Danish

Added danish translations and implemented the logic for it in country_localizations and country_parser files.

@Faberen and @Lukan707 Thank you for your contribution, Released in v2.0.27.


Right click menu

Types of changes

[x] New feature (non-breaking change which adds functionality)

Adds a right-click context menu to the workspace - making a number of actions more accessible.

The menu is selection-aware - so shows options relevant to the current selection (group/ungroup for eg).
There's a bit more work around i18n to handle - but propose to do that post beta.3

Coverage decreased (-0.03%) to 68.235% when pulling ad32677263c3219161f0382973df9be550f52f13 on right-click-menu into 22879f8c23265eae0d61d22ac837e6659ba80ece on master.


Mv manpages

This moves the manpages in the doc directory into standard manX directories.
Once merged, bin/mk-manpages in www repo will need to be updated.

Considering you have one commit starting with WIP:, perhaps this PR should be marked accordingly?

i'll merge/squash and remove the WIP.  it's not a WIP any more.

Add this patch as well, that covers docs production on Windows and VMS:
diff --git a/util/process_docs.pl b/util/process_docs.pl
index 8b8de81..2c54f02 100644
--- a/util/process_docs.pl
+++ b/util/process_docs.pl
@@ -28,26 +28,23 @@ use OpenSSL::Util::Pod;
 my %options = ();
 GetOptions(\%options,
            'sourcedir=s',       # Source directory
-           'subdir=s%',         # Subdirectories to look through,
+           'section=i@',        # Subdirectories to look through,
                                 # with associated section numbers
            'destdir=s',         # Destination directory
            #'in=s@',             # Explicit files to process (ignores sourcedir)
-           #'section=i',         # Default section used for --in files
            'type=s',            # The result type, 'man' or 'html'
            'remove',            # To remove files rather than writing them
            'dry-run|n',         # Only output file names on STDOUT
            'debug|D+',
           );

-unless ($options{subdir}) {
-    $options{subdir} = { apps   => '1',
-                         crypto => '3',
-                         ssl    => '3' };
+unless ($options{section}) {
+    $options{section} = [ 1, 3, 5, 7 ];
 }
 unless ($options{sourcedir}) {
     $options{sourcedir} = catdir($config{sourcedir}, "doc");
 }
-pod2usage(1) unless ( defined $options{subdir}
+pod2usage(1) unless ( defined $options{section}
                       && defined $options{sourcedir}
                       && defined $options{destdir}
                       && defined $options{type}
@@ -62,8 +59,8 @@ if ($options{debug}) {
         if defined $options{destdir};
     print STDERR "DEBUG:   --type      = $options{type}\n"
         if defined $options{type};
-    foreach (keys %{$options{subdir}}) {
-        print STDERR "DEBUG:   --subdir    = $_=$options{subdir}->{$_}\n";
+    foreach (sort @{$options{section}}) {
+        print STDERR "DEBUG:   --section   = $_\n";
     }
     print STDERR "DEBUG:   --remove    = $options{remove}\n"
         if defined $options{remove};
@@ -75,8 +72,8 @@ if ($options{debug}) {

 my $symlink_exists = eval { symlink("",""); 1 };

-foreach my $subdir (keys %{$options{subdir}}) {
-    my $section = $options{subdir}->{$subdir};
+foreach my $section (sort @{$options{section}}) {
+    my $subdir = "man$section";
     my $podsourcedir = catfile($options{sourcedir}, $subdir);
     my $podglob = catfile($podsourcedir, "*.pod");

great, merged your diff. thanks!

rebased and push -f'd

Grand.  Now, we wait for the CIs to be done.

Darnit...  with the GH hickup, it seems we don't get an appveyor build on this unless something new is pushed...  Meh...

I just tested on VMS, works beautifully.
Re the commits, I assume you're going to squash them all into one?

Yes, squash into one.
Need to prototype the web mk-manpages change first I think, so that the website still works....

Just did a force update, changed the commit message.

done, and did a quick hack for the website.  thanks!


[REQUEST] Better show where all the configuration should go

Pledge
I'd offer $20 in BTC or LN for this but it would help others much more than myself who already found stuff the hard way.
Is your feature request related to a problem? Please describe.
The relay hitting limits doesn't communicate well what's limiting it and which config to touch to fix that.
Describe the solution you'd like

[ ] At startup, the relay should log out all the config files it is considering and using. If configs get merged, it should show the list and indicate which config overwrites which.
[ ]  When hitting limits it should hint at what to do. "db FATAL:  sorry, too many clients already. Try increasing configs A, B and C inside the project folder's config files D, E and F if using docker. ..."

Should have split this into two requests because one is a feature and the other one is a bug fix.


Rework stream_data.can_toggle_subscription handling of deactivated streams

I believe that this function is misleading:
export function can_toggle_subscription(sub) {
    // If stream is public then any user can subscribe. If stream is private then only
    // subscribed users can unsubscribe.
    // Guest users can't subscribe themselves to any stream.
    return sub.subscribed || (!page_params.is_guest && !sub.invite_only);
}

I think it's not a live bug, because you can't be subscribed to a deactivated stream, and they're made invite-only during deactivation, but logically, we should perhaps not be relying on that invariant not be doing the "can you join public streams" check if the stream is deactivated.
Noticed while reviewing https://github.com/zulip/zulip/pull/20133.
@sahil839 FYI.  I'm not sure what exactly we want to rework here, but I'd find it a lot more readable if this explicitly called out that case, and/or had a call to user_can_join_public_streams or something.  But it may not be worth doing too much editing on that given the stream groups migration plans, which may result in our not doing that shape of check anyway.

It's not clear to me what we need to change here - "can you join public streams" just depends on whether the user is guest or not.
The only way to check whether stream is deactivated or not as per the current code is verifying that the sub object passed is not undefined.

Maybe the right answer is just a comment, that in theory this should check whether the stream is archived/deactivated, but that's implied because !sub.subscribed will always be true for such streams.


Add isClose, a replacement for approxEqual

This is a replacement for PR #7187, because I had to remove my old account on GitHub.
My original comment was:
As suggested in PR #7173, I wrote a new version of approxEqual (called isClose to avoid naming conflicts), which is based on the thoughts given in [1]. The purpose of both functions is the same, namely providing a utility for comparing floating point numbers. This is necessary, because operations on floating point numbers inevitably produce rounding errors and therefore cannot be compared reasonable using ==.
The main difference is, that this function has much stronger default values for the error allowed, based on the capabilities of the used floating point type. This helps in catching errors, especially as approxEqual is mainly used in unittests. This addresses issue #15881. Together with PR #7180 this can be considered a fix for that issue.
The new function is furthermore symmetric, to avoid users being confused or have to remember the order of the operands. This addresses issue #15763.
After this PR has been approved I think, it would be wise to continue with the following roadmap:

replace all occurences of approxEqual in Phobos by isClose. With one exception, approxEqual is only used in unittests. The exception is secantMethod in std/numerical.d.
deprecate approxEqual in favour of isClose. (I don't know if I'm in the position to deprecate anything, nor to ask for it, but I think, this would be a good idea in the long-run.)
After some time, remove approxEqual alltogether.

[1] https://www.python.org/dev/peps/pep-0485/

Don't worry. It's not that important to me (else I would have pinged) - I thought, it might be a problem, because a new name is introduced.
Patches on the way.

Thanks.

This is a pretty significant change, and IMO notable enough to be included in the release notes.  Can you submit a follow-up PR to add the corresponding file in changelog/ describing this change? (We're still using that for generating release notes, right?)

I'm currently working on replacing all occurences of approxEqual in Phobos with corresponding calls to isClose; see #7340. Essentially I'm through, but from my first try I remember, that some tests in std.complex failed on 32bit computers, because the calculation of log() is less accurate. I have to experiment a little with the autotesters to get that right but maybe I'll manage to still finish that this year. :-)
After that PR has been accepted, I plan to file another, which deprecates approxEqual and adds a changelog-entry (I actually planed to ask if I should do so, but thanks to your post now I know I should :-) ). OK?


Ubuntu deploy script is incorrect

References 'attack_range', rather than 'attack_range_local'
Also refers to the use of terraform, which is not used in this project. Please remove.

fixed. Thank you


Syntax highlighting disappears due to refresh.

Describe the bug
A clear and concise description of what the bug is.
Syntax highlighting disappears due to refresh.
To Reproduce
Steps to reproduce the behavior:

Open a post page with code.
Click REFRESH
Syntax highlighting disappears

Expected behavior
A clear and concise description of what you expected to happen.
Syntax highlighting outlives refresh
Screenshots
If applicable, add screenshots to help explain your problem.
Platform:
iOS Firefox and other environments

OS: [e.g. iOS, Android, macOS]
Browser [e.g. chrome, safari, firefox]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Duplicate #83


When using library inside of a component the CSS is bugging after page is reloaded.

I am trying to use the library to generate a drop down menu from a button within a component.
Like so:

The library is working on most cases, however if I reload the page and try to use the drop down again this happens:

The functionality is still there (e.g. if I click on the text fields that popped up they still redirect where they are supposed to, however the css is bugged).
Anyone experienced this too or knows where the problem might be?
Here the snippet of my code where I use the Menu

Thanks

Hi @paoloviselli , your code looks good to me. The only issue is MenuButton wraps a Button which is not necessary. You might use Button for the menuButton prop directly. But I think this is not related to the styling bug in your code.
Are you using the default index.css that comes with the npm package? If so, is the css still applied after page is reloaded?

Hi @szhsin I am using the default index.css however the CSS kept disappearing each time I reloaded the page.
I had to install Material UI for other components and I ended up using also their Menu and the MUI Menu, used in the same exact code does not present that issue.
However the weird thing was that I was using your Menu library on another page of my project and it was not presenting this issue at all. The only difference in this use was the fact that is was not nested into any components. Might be that the problem?
Hope this helps.

Nesting the menu into components is totally fine. You could use browser dev tools to inspect what css has been applied to menu before and after the page is reloaded.
Also, you don't have to use the index.css.  The css rules in the file can be copied into your project stylesheets or CSS-in-JS solution.


Topslam: Waddington Landscape Recovery for Single Cell Experiments

https://doi.org/10.1101/057778
Authors
Zwiessele, M. and Lawrence, N.D.
Year
2016
Abstract

We present an approach to estimate the nature of the Waddington (or epigenetic) landscape that underlies a population of individual cells. Through exploiting high resolution single cell transcription experiments we show that cells can be located on a landscape that reflects their differentiated nature. Our approach makes use of probabilistic non-linear dimensionality reduction that respects the topology of our estimated epigenetic landscape. In simulation studies and analyses of real data we show that the approach, known as topslam, outperforms previous attempts to understand the differentiation landscape. Hereby, the novelty of our approach lies in the correction of distances before extracting ordering information. This gives the advantage over other attempts, which have to correct for extracted time lines by post processing or additional data.

Experimental Methods
Simulation of differentation patterns and apply four different landscape creation approaches: PCA, ICA, t-SNE, and their method (Bayesian GPLVM)
Also apply these methods to qPCR data of 437 cells across mouse developmental stages (one to 64 cell state)
Computational Methods
Their method extracts the latent representation dimensionality (can be thought of as cell states?) and determines a non-linear model of single cell data. This underlying model is used to build a graph (or some sort of clustering or ordering of cells) to uncover trajectories.
Code is made available here


Add destroys annotation

Adds @Destroys annotation to properly order tasks that have a create/consume/destroys relationship.

I mentioned this to Gary on Slack already, but a few things about this feature:

I like that this uses a separate thing from inputs/outputs vs just annotating a particular input or output as something special.
destroys doesn't affect up-to-date checks, so changing a task's destroys property will not cause it to execute again.  For tasks that have no inputs/outputs, this isn't a problem (since they can't be up-to-date).  If you modify a custom task/built-in task with inputs/outputs to also have something that is destroyed, then someone may be surprised when the task remains up-to-date.
I'm not sure how this fits together with @CacheableTasks. I think in the short term, if your task destroys something, we need to disable caching.  Otherwise, we need to make sure we delete things even when the task's outputs come from the build cache. We've never considered Delete to be a cacheable task, so a task that declares it deletes things shouldn't be cacheable in general.

To limit the scope of this, could we put TaskDestroys/getDestroys only on Delete for 4.0 and move it to Task later?  That would avoid any weirdness with someone trying to use destroys in a way we hadn't imagined it yet.

To limit the scope of this, could we put TaskDestroys/getDestroys only on Delete for 4.0 and move it to Task later?

I don't feel like there is a strong argument for this and I don't understand the concern.  The things that you mention are good points, but none of those scenarios are different than what we have today.  The only difference is that you now have a way to explicitly state that a task does something that it always did (i.e. deletes a file).  Personally, I would rather clear up any possible confusion about what this annotation means through documentation rather than by making it less usable.
I think there are other stories that we should tackle that address the annotation's impact on up-to-date-ness as well as cache-ability, but this seems to me to be a reasonable step that provides value and doesn't introduce undesirable behavior.

I wouldn't bother putting too much effort into supporting tasks that both destroy something and produce outputs, until we have a real use case for such a thing. That is, I think it's ok to simply mark a task that destroys something as 'not reusable', which would mean don't reuse the outputs either locally or from the cache. I'd even treat this case as an error and fix if we ever find a real use case for this.
A task that both takes inputs and destroys something is a different story, for example a task that destroys a service and which takes the tooling to destroy the service as input. We should support this combination - all it means is to build the inputs prior to running the task, and later doing smart things to avoid building the inputs when there is nothing to destroy (just like we would do for tasks with no source, where there is nothing to produce). Very short term it would be ok to treat this case as an error and fix later.

+1 for disabling or failing if a task has destroys and outputs.
We have some task validations that might be useful here: (an example) https://github.com/gradle/gradle/blob/1308e2a9e93d902bbaf9a5200e6a83df570f243e/subprojects/core/src/main/java/org/gradle/api/internal/project/taskfactory/AbstractInputPropertyAnnotationHandler.java#L42-L42

I haven't see activity for this recently. Is this still intended for 4.0?

@eriwen yes, we are still targeting 4.0 for this. Gary and Jendrik will finish this up on Thursday/Friday. The only remaining issue is a slight performance regression caused by this change, which we want to mitigate.


Run your code

Please tell me how to run your code

Install anaconda python distribution .
Install Tensorflow
Download/Clone the repository to desktop
Open terminal type: jupyter notebook
Open the desired notebook that you want to run
Make sure data/file paths are properly set


Build is breaking component names in navPush

Short description of the problem:
Cannot use component names directly in a template.
What behavior are you expecting?
Should be able to place components by name in navPush but getComponent returns null in nav-util.
Steps to reproduce:

Add a button with navPush to another page:<button ion-button navPush="TabsPage">
  Continue
</button>

Click on the button after running serve
See nav-util.js:23 invalid page component: TabsPage

Note: If you set it in the component to a property it will work, code:
export class TutorialPage {
  tabsPage = TabsPage;
}

then on the button:
<button ion-button [navPush]="tabsPage">
  Continue
</button>

Which @ionic/app-scripts version are you using? 1.0.0
Other information: (e.g. stacktraces, related issues, suggestions how to fix, stackoverflow links, forum links, etc)
Can be reproduced in the nav/basic and tabs/advanced e2e tests running a prod build.
When I ran the prod build with the following it worked fine:
ionic-app-scripts build --aot --minifyCss --optimizeJs

If you need to test e2e this commit should be undone: https://github.com/driftyco/ionic/commit/ce7afd0327d1e5a6d6c7aed1d0825a75992265b3

I'll reopen if needed.
Thanks,
Dan


Technology spec viewer should be available for flex technologies

opens an empty pop-up:

The node(s) need to be have one of the following presentation_groups:

biomass
carbon_capturing
chps
electricity_production
heat_pumps
hydrogen_production
p2g
p2h
p2kerosene
traditional_heat

If none of these are satisfactory, see ETEngine's Api::V3::ConvertrerPresenterData.

@antw thanks for the clear explanation.
I think we should add a new p2p presenter group which shows some new items:

the charging capacity (input) in MW
the storage volume in MWh
the round-trip efficiency in % (this one is tricky as it consists of an input efficiency and an output efficiency in the ETM)

@noracato could you try your hand on adding this new presenter group and adding the P2P technologies to this group?

household batteries
OPAC
large scale batteries


Retina quality favicon

The new favicon.ico contains optimized 16 and 32px sized layers. Before it only had a 16px layer.
Before/after:

I can't really see the difference though 😄 but yeah, it's a merge! Thanks.


Release/v1.0.0

Before merging, we should release the service and run the integration tests locally.

@clukas1, all tests are passing:


Preserve Yaml structure

Currently, the application is changing the order of the YAML file's content when it introduces the description block.
This is the original YAML file:

This is the modified YAML with the documentation generated by the app:

We need to add the description section after the name one and keep the other sections in the same order they had before running the app.

Looks like an issue with yaml.safe_load() call to read yaml file into python dict.
There are two possible resolutions here -

use yaml.load(), which preserves the order in yaml file. But should not be used with untrusted data.
creating own implementation of yaml.safe_load to preserve the order of yaml file.

Going with the 2nd approach as it looks safe.

So, the issue was while writing to yaml file. Introduced a new dependency ruamel.yaml just for write.
ruamel.yaml - to write to yaml file, preserves the order of keys.
PyYaml - to read the yaml file (existing flow). Wanted to remove this and use ruamel.yaml but don't feel confident since there are no test cases to validate.

Yes!
I'll do


fix bad link in README

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
/kind documentation

thank you for your contribution