Create Spaces [16]

Description
As a user, I want to create projects from the system. A project is a higher context for work items and other data in the system. A work item always "belongs" to exactly one project and all data in the system is always displayed in the context of a specific project. Projects are "owners" of work items and work item links.
Functional Acceptance Criteria

The user can create a project from the "create project" view.
Creating a project requires a name (alphanumeric value).
It is not possible to create a project with an empty name.
Projects are working in a way that users in the system are global and can be associated with more than one project (will be a later story).
Projects are working in a way that cross-linking of work items between projects is possible (will be a later story).

Note: as mentioned above, users are "global" to the system and can be "member" of more that one project at the same time. This is not a direct functional requirement, but a hint for design decisions.
Note: projects are "owners" of work items and work item links. Work items and projects should be designed that cross-linking of work items between projects are possible later. TBD is the ownership of the work item link instance on cross-linked work items. This is not a direct functional requirement, but a hint for design decisions.
Note: on the scope of this story: as part this story, we will extend our object model by introducing a 1:n relationship between the newly created "project" and work items. On the back end, we will have to introduce a CRU(D) service for projects and extend work item creation with a mandatory "project" parameter. How that parameter is passed and stored needs to be discussed as part of implementation.
The front end needs to add UI to create a new project and introduce the notion of a "selected" project that is passed when creating a work item. As part of migration, we will have to create a default project and assign all existing issues to that project.
Out of scope (explicitly not addressed by this user story): authorization, orgs, teams, areas, configuration of process for a project (WI types, etc.) and moving work items between projects.
Non-functional Acceptance Criteria

The "create project" view is easily accessible from anywhere in the system UI.
Creating a project adds the new project in-place to the project selector.
The result of the implementation of this story should also be a basic data model and a concept for organizing projects and other entities.

Dependent Stories

Userstory #358

Tasks

Create Repository for project crud(l) #509
Create API Endpoint for project crudl #510
Update work item create/update to include optional "project field" if empty, assign to a default project
*migrate all existing work items to default project #511
Update search services (wi list and @searchrepo) to allow filtering by project #512
Make project field in work item create/update mandatory

this can be done once the front end is ready to pass a project with work item create/update (#358)

Start of discussion: about the nature of a project: what are the boundaries? Do users are per-project or per-installation? Are all WIs always per-project? Can there be WIs that are cross-project? Do all these matter in the context of the short-term goal?

WI's are imo part of one project but other projects can include a WI in their value props, epics, etc.

Will we support users moving work items between projects?

@michaelkleinhenz A few comments for the questions you've raised:
cc @maxandersen @aslakknutsen

Do users are per-project or per-installation?

I see projects as a namespace to hold a team, i.e. every project in the system has a set of users who work on it. The same human user behind the project should be registered by the system only once (for instance, sign up at developers.redhat.com). But at the same time, the user would have different (or even no roles) in different projects in the system, so users may need to be onboarded to be a member of a project team. Users should not be required to sign up multiple times into various project instances.
So, imho, every project has a team that is used to link projects with various registered users in the system.
This would tie somewhat into the permissions model, as you may need unregistered users to perform certain operations, like commenting on WIs. All such concerns could be extracted out to separate stories.

Are all WIs always per-project? Can there be WIs that are cross-project?

I'd see projects as owners of WIs, i.e. the project namespace should contain the WIs in that project. WIs could be linked from one project to another, with different link types (duplicated by, depends on, related to etc). From a functional perspective, projects have work items, and work items have links to other work items in the same or different projects. I believe #322 and #323 do not deviate from my understanding of WI links.
I sense there is a technical concern here on how you want to store the links and manage them, so I won't comment much at the risk of misguiding the team on technical aspects, but I can take those questions if needed.
Again, feel free to split the overall story on WI links.

@michaelkleinhenz :
@joshuawilson had shared this from the Westford meeting. We could refer to it while working on Projects.

@nimishamukherjee ah, I now understand the concerns about the Area/Category. For this topic, I think the PDD reads that Area (in the above image) and category are different things. Categories are like components in Jira, Areas are the hierachy of the project structure.
On the users: the diagram suggests that users are local to the project. For many reasons and also @VineetReynolds remarks I would consider users in the diagram differently from "accounts" in the system, which should be global.

@all updated the story with the new info.

@michaelkleinhenz I would argue components are a "weaker" form of what area is. the main difference between area and components are that components are a "flat" hierarchy but then instead one issue can be in multiple components. Question is if we want to have the strict hiearchy or allowing for mulitple areas is relevant.

one thing to remember here is that Projects are intended to cover more than just planner WorkItems - projects is also what should show up in webide, builds, etc.

I am guessing the length of the Sprint (Time-box) and/or Release be defined at the Project level? Shouldn't that be part of the acceptance criteria? Since we are sticking with Scrum version of Agile for the Summit deliverable, should that be the default option at the project level for now?

@maxandersen on the components: yes, thats also my impression. And like for the projects, I would go for a flat model first and add hierarchy later. I'll add that to the categories story.

@maxandersen on the projects: yes, I'd think projects are the "functional root" of other data.

@RanjithRV I would put the time configuration in the iteration to allow flexibilty on the timebox per sprint (like, we need 2 days more because of holidays). The iteration stuff is not yet written down in stories, but I am on it :-)
But yes, at some point, the project does need more metadata, maybe also a "default iteration length". I would add that in a later story when we do the iterations.

@RanjithRV I think the length of sprint is defined on the sprint/iteration itself not on the project.
the sprint/iteration i think makes sense to have within one project.
But one could argue that you could have multiple projects follow the same sprint model (think devtools), and I even think in jira sprints live outside projects, allowing multiple projects and boards to collabroate on sprint planning.

This issue refers to projects as:  "Projects are "owners" of work items and work item links."
Does "container" make more sense as a description for a project? Isn't a project just a title and a groups of links to work items, users, other projects, etc.?   Thx!

In scope
As part this story, we will extend our object model by introducing a 1:n relationship between the newly created "project" and work items. On the back end, we will have to introduce a cru(d) service for projects and extend work item creation with a mandatory "project" parameter. How that parameter is passed and stored needs to be discussed as part of implementation.
The front end needs to add UI to create a new project and introduce the notion of a "selected" project that is passed when creating a work item.
As part of migration, we will have to create a default project and assign all existing issues to that project.
Out of scope
The following things will explicitly not be addressed by this user story:

authorization
teams
areas
configuration of process for a project (wi types, etc.)
moving work items between projects.

Further evolution
In our current linking story, links are not associated with a project, and thus cross-project links are trivially possible. If we chose to partition the system along project boundaries in the future, we'll need to split existing links. Having one project be the owner of a cross-project link does not make sense for symmetric relationships (related-to, etc.)
I believe what Michael means by "nested projects" are what the PDD calls "areas". Introducing them later would entail migrating existing issues to a newly created "default area" per project.

Thanks Thomas. This seems reasonable. Just checking that you can move a WI
between an iteration within a project? Is that on the table?
On Tue, Nov 1, 2016 at 5:52 AM, Thomas Mäder<EMAIL_ADDRESS>wrote:

In scope
As part this story, we will extend our object model by introducing a 1:n
relationship between the newly created "project" and work items. On the
back end, we will have to introduce a cru(d) service for projects and
extend work item creation with a mandatory "project" parameter. How that
parameter is passed and stored needs to be discussed as part of
implementation.
The front end needs to add UI to create a new project and introduce the
notion of a "selected" project that is passed when creating a work item.
As part of migration, we will have to create a default project and assign
all existing issues to that project.
Out of scope
The following things will explicitly not be addressed by this user story:

authorization
teams
areas
configuration of process for a project (wi types, etc.)
moving work items between projects.

Further evolution
In our current linking story, links are not associated with a project, and
thus cross-project links are trivially possible. If we chose to partition
the system along project boundaries in the future, we'll need to split
existing links. Having one project be the owner of a cross-project link
does not make sense for symmetric relationships (related-to, etc.)
I believe what Michael means by "nested projects" are what the PDD calls
"areas". Introducing them later would entail migrating existing issues to a
newly created "default area" per project.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/almighty/almighty-core/issues/357#issuecomment-257527189,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ARTwq-DQYVWxyl7x5kXtIBcmz-PhNR4sks5q5wvigaJpZM4KVAgC
.

Question on this statement:
'...The front end needs to add UI to create a new project and introduce the notion of a "selected" project that is passed when creating a work item...'
Will a user always be working in the context of a "current" project? Or, will the user have the option of selecting a project when creating a new work item?

@Mgranfie For me, it's not part of this userstory

@ldimaggi I did not find any info on that. I guess it's a decision for UX to make.

@Mgranfie wrt

Just checking that you can move a WI
between an iteration within a project? Is that on the table?"

This would be under the sprint/iteration planning stories. Short answer - I'd expect WIs to be moved between iterations.

@Mgranfie yes, WIs can be moved between iterations. See #412 for that.

Backend Tasks:

Create Repository for project crud(l)
Create API Endpoint for project crudl
Update work item create/update to include optional "project field" if empy, assign to a default project
-> migrate all existing work items to default project
Update search services (wi list and searchrepo) to allow filtering by project
Make project field in work item create/update mandatory

Front end tasks:

"Create Project" dialog
An affordance to invoke the "create project dialog" (menu entry, for example)

Switzerland: 20 points.

13 Points

We're now able to create projects==spaces. Closing this issue!


[Page] Resolve Errors & Warnings

closes #333
closes #401
Note (05/02/24)
The sbl-filing branch used is main --  latest working commit 0ddf51bd4bd0ab7aefac8cbb02c7797077885620
branched off 331-filing-routing_phase2-live-data
Changes

feat(Resolve Errors): Single-Field Errors
feat(Resolve Errors): Multi-Field Errors
feat(Resolve Errors): Register-Level Errors
feat(Resolve Errors): Alerts present depending on errors or no errors
feat(Resolve Errors): Swappable between Step 1 (Syntax Errors) and Step 2 (Logical Errors/Register Errors); navigates to warnings on Step 2 (no errors)
enhancement(Upload): added an enableLongPolling boolean to useGetSubmissionLatest; default false
enhancement(Resolve Errors): Implemented 'react-markdown' -- Validation Description
chore(Resolve Errors): TypeScript handling in FilingErrors.helpers.ts
chore(Upload): Hide FilingNavButtons if still loading
feat(Resolve Errors): if a get submission latest fails, there is an Alert that pops up

Next PRs

Pagination
Accessibility pass
Table styling size adjustments
Download linking the validation report

How to Test

yarn install to install react-markdown
Select an institution and upload with the csv files provided (Syntax Errors and then Logical/Register Errors)
Ensure the right Alert occurs based on the error (or no errors) per segment
Verify all proper data is present per field-level section

Test CSV's to use
all-errors-warnings-no-syntax-errors.csv
sblar_syntax_errors_large.csv
sblar_syntax_errors.csv
Note: If Syntax Errors are present, then validation for the logical errors/warnings do not occur. Hence, why the test CSV's has either syntax errors or logical errors; not both.
Screenshots

Markdown

SingleFieldErrors
Success
Register-Level

We should address this outside of this PR since this styling change could affect all links through the app.

Sounds good, can we make a ticket for it, then this is good to go @shindigira!


Update comment to be more accurate

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.12%. Comparing base (bdc7515) to head (11a942a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #87   +/-   ##
=======================================
  Coverage   61.12%   61.12%
=======================================
  Files          20       20
  Lines        1196     1196
  Branches      212      212
=======================================
  Hits          731      731
  Misses        388      388
  Partials       77       77

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

OK sorry, I must have been looking at different upstream version at the time I saw this :)


Question regarding xmlsec.SignatureContext.sign

Hi,
I just wanted to check if there is a way to force xmlsec.SignatureContext.sign to include the <X509SubjectName> and <X509IssuerSerial> tags while signing xml documents.
Right now, I'm doing this (most of the code is taken from the test_sign_generated_template_pem_with_x509 method in test_sign.py)
    root_node       = etree.fromstring(xmlstr)

    signature_node  = xmlsec.template.create(root_node,
                                             xmlsec.Transform.EXCL_C14N,
                                             xmlsec.Transform.RSA_SHA1)

    root_node.append(signature_node)

    # Add the <ds:Reference/> node to the signature template.
    ref = xmlsec.template.add_reference(signature_node, xmlsec.Transform.SHA1)

    # Add the enveloped transform descriptor.
    xmlsec.template.add_transform(ref, xmlsec.Transform.ENVELOPED)

    # Add the <ds:KeyInfo/> and <ds:KeyName/> nodes.
    key_info = xmlsec.template.ensure_key_info(signature_node)
    xmlsec.template.add_x509_data(key_info)

    # Create a digital signature context (no key manager is needed).
    ctx = xmlsec.SignatureContext()

    # Load private key (assuming that there is no password).
    filename = 'public-pk.pem'
    key = xmlsec.Key.from_file(filename, xmlsec.KeyFormat.PEM, '<password>')

    assert key is not None

    # Load the certificate and add it to the key.
    filename = 'public-cert.pem'
    key.load_cert_from_file(filename, xmlsec.KeyFormat.PEM)

    # Set key name to the file name (note: this is just a test).
    key.name = os.path.basename(filename)

    # Set the key on the context.
    ctx.key = key

    ctx.sign(signature_node)

Thanks,
Naresh

You'd have to poke around xmlsec itself. This library is just a small wrapper around the C library.

Hi. I think the following code should help.
signature_node  = xmlsec.template.create(root_node,                                              xmlsec.Transform.EXCL_C14N,                                              xmlsec.Transform.RSA_SHA1) xmlsec.template. add_x509_data (xmlsec.template. ensure_key_info(signature_node))
more information about xmlsec.templates can be found here:
https://www.aleksey.com/xmlsec/api/xmlsec-templates.html#XMLSECTMPLKEYINFOADDKEYNAME

@bgaifullin You have proved time and again that you know way more about xmlsec than I do. You're now a collaborator. Take it as you will.

:+1:

thank you.

@nareshenoy, Do you still need help?

Hello @bgaifullin we are having same issue right now. We tried using your suggestion but unfortunately:
xmlsec.template.add_x509_data(xmlsec.template. ensure_key_info(signature_node))

just adds the X509Certificate node and we also need the X509IssuerSerial, we found this template on xmlsec https://www.aleksey.com/xmlsec/api/xmlsec-templates.html#XMLSECTMPLX509DATAADDISSUERSERIAL but unfortunately seems its not currenty supported by python-xmlsec

I will see how to this method to python-xmlsec

Now, xmlsec has methods to add issuer_serial and issuer_subject_name.
You can find details in documentation


Exec[bootstrap pip] Executes Every Puppet Run

I have the following code snippet..
  class { 'python':
    version    => 'system',
    pip        => 'latest',
    provider   => 'pip',
    dev        => 'present',
    virtualenv => 'present',
    gunicorn   => 'absent',
  }

And I get the following on every puppet run...
Notice: /Stage[main]/Python::Install/Exec[bootstrap pip]/returns: executed successfully
Notice: /Stage[main]/Python::Install/Package[pip]/ensure: created

Because the get-pip.py script puts the executable for pip in /bin/pip rather than /usr/local/bin/pip as specified in the install.pp manifest...
https://github.com/stankevich/puppet-python/blob/master/manifests/install.pp#L74
Applying to CentOS 7.  Not sure if this is the same for other distros.

After manually creating a symlink /usr/local/bin/pip to /bin/pip the Exec[bootstrap pip] notice stops as expected.
However the Package[pip] notice still displays...
Notice: /Stage[main]/Python::Install/Package[pip]/ensure: created

One possible reason might be that the pip provider for the package resource might use pip freeze instead of pip list.
pip freeze doesn't appear to list pip itself or setup_tools, but pip list does.

I am having this same issue as well.

Im having the same issue. The exec:
exec { 'bootstrap pip':
    command => '/usr/bin/curl https://bootstrap.pypa.io/get-pip.py | python',
    creates => '/usr/local/bin/pip',
    require => Package['python'],
}

Unfortunately the command does not create /usr/local/bin/pip (but rather /bin/pip).  I have silenced it with:
exec{ 'Hack the python boostrap idempotency issue':
    command     => '/bin/ln -s /bin/pip /usr/local/bin/pip',
    refreshonly => true,
    subscribe   => Exec['bootstrap pip'],
}

Which has stopped it running over and over again.  the refreshonly and subscribe ensures that this new exec will only run when the bootstrap one does and the bootstrap one should not run after the new exec has.

I wrote up a quick PR for this to support /bin/pip, /usr/bin/pip and /usr/local/bin/pip as it definitely picks /usr/bin/pip on Centos 7.  I have not tested Fedora or other Redhat flavours but this would support any OS as they tend to pick either /usr/bin/pip or /usr/local/bin/pip.
The constant pip ensure: created was due to provider/package/pip.rb not supporting understanding that pip freeze does not include pip.  In 4.5.0 that was finally fixed in the provider.
Puppet 4.5.0 PIP-6120
PR: #318

Same here for both 1.7.16 and 1.9.1 versions with the following code:
python::pip { 'pip':
    ensure     => '8.1.0',
    pkgname    => 'pip',
    virtualenv => $::myapp::virtualenv_path,
}

(Nvm, I put my comment in the wrong ticket, sorry)


⚠ SkipTheCommericals has degraded performance

In 25161e7, SkipTheCommericals ($STC) experienced degraded performance:

HTTP code: 200
Response time: 2246 ms

Resolved: SkipTheCommericals performance has improved in 388ab23.


nvidia support

Make sure it works there too. Might be tricky since I don't have any of their hardware.

https://github.com/ssube/onnx-web/commit/8359bd5b9969051dde4686223f602cdb77b15901 added initial support, which seems to work correctly, but requires the onnxruntime-gpu package and CUDA 11.6 (probably any 11.x).


[WeldxFile] update signature matches parent

Changes
The iterable or mapping argument can be truly optional.
So update with only passing kwargs can work.
Checks

[ ] updated CHANGELOG.rst
[ ] updated tests
[ ] updated doc/
[ ] update example/tutorial notebooks
[ ] update manifest file

I think there is no need for a changelog entry, because the update interface has just been overriden on master and was not yet released.


NEXT-37442 Fix variant listing config when cloning products or deleting variants

I'm not entirely sure whether this change classifies as a BC break, because I changed one JS function to be async.
If that is the case, let me know and I'll revert that change and keep using then().
It would also be very helpful if this change could be backported to 6.5. If I can somehow assist in doing so, let me know.
1. Why is this change necessary?
When cloning a product or deleting its variants, the mainVariantId in the storefront presentation settings is not updated accordingly. This can result in a 404 page when navigating to the product from the storefront.
This issue was partially addressed with commit https://github.com/shopware/shopware/commit/c2ed3e9e600bafae63cfe8720820e593226c6f24
However this commit introduced a bug which changes the original product on duplication.
2. What does this change do, exactly?
It resets the mainVariantId when the referenced variant, is deleted.
Additionally we now clone the storefront presentation settings when cloning the product. Previously the original product was also modified because a reference was used.
3. Describe each step to reproduce the issue or behaviour.
See ticket.
4. Please link to the relevant issues (if any).
https://issues.shopware.com/issues/NEXT-37442
5. Checklist

[x] I have rebased my changes to remove merge conflicts
[ ] I have written tests and verified that they fail without my change
[x] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Any Updates on this PR?


STYLE: Remove samplenr which was used in commented-out code in Compute

This particular samplenr variable was only used as argument for commented-out progressObserver->UpdateAndPrintProgress calls.
Those progressObserver->UpdateAndPrintProgress calls were already commented-out with commit e9de4b1281a07d2fdbaa96db865f3c7aaaf4e5d2 (May 25, 2016): https://github.com/SuperElastix/elastix/blob/e9de4b1281a07d2fdbaa96db865f3c7aaaf4e5d2/src/Common/itkComputeJacobianTerms.hxx#L235-L236
Follow-up to pull request https://github.com/SuperElastix/elastix/pull/1111 "COMP: Fix -Wshadow warnings on local samplenr variable"

@mstaring FYI, I'll just merge this PR now, but if we ever want to have this unused variable (samplenr) back here (and actually use it to implement progress updating), it's easy to put it back any time later.


implement new style function for sigmoid

This PR fixes F.sigmoid to use the new-style function node interface of #2970.
I am trying to implement new style function. It seems to pass the unit test.
But there are some problem about this PR.

Since the #3096 is not merged, the double-grad tests are not written.
I do not know the right way to dispatch from backward to backward_cpu or backward_gpu.

Since the transition to new-style functions will involve replacing optimized backward implementations that directly call CUDA elementwise kernels with slower combinations of abstracted forward operations, and these forward operations are all fully generic for CPU and GPU, maybe new functions should have one mandatory implementation in terms of forward operations (backward) and two optional ones for better performance (backward_cpu and backward_gpu, same as old-style functions) in the case that the user does not require double differentiation support?

@jekbradbury Thank you for the kind reply! Now, I know how to implement the double differentiation . So, I must implement the backward by using the combinations of forward operations so that the grad is also generated forward operations.
Then, what should I do is below?

leave the old functions backward_cpu and  backward_gpu.
implement the generic backward by using the forward operations.

But what code should dispatch to backward, backward_cpu or backward_gpu.

I just mean that if the backwards execution engine knows whether the user requires double differentiation support, it could use that information to dispatch to either backward, backward_cpu, or backward_gpu. That way the work Chainer developers have done optimizing CUDA implementations for backward_gpu wouldn’t be wasted in the very common case that double differentiation isn’t needed.

I also feel we should keep the current optimized backward implementation. Otherwise, the performance will be deteriorated. I will create an issue for this problem.

link to #3147.

@beam2d review this please.

@beam2d I fixed them as you said. Please check them.

Jenkins, test this please.

LGTM!

Thank you!


Buff Melee Energy Weapons

About the PR
Media

[ ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl:

add: Added fun!
remove: Removed fun!

These are the current values from SS14, correct?

These are indeed current values from SS14, do I need to rename it to merge?

Sorry if I mess up anything, this is my first PR.

No, I'm working on an update branch at the moment, so I can pull in this change while I'm doing that. I did a quick check, and it looks like the original commit was skipped entirely at some point. Its name was i can this. i can that. i am doctor mario i can all (#14662)
Looks like it did a little more than just change these values here, so it'd be ideal to get the whole commit and have that in the history, which I'll go ahead and grab. You can close this.

Alright, I shall close this then.


Requests like interface for smooth transition to dapr

In what area(s)?

Feature request

Context : Dapr-Python-Sdk
API Usage
I have created dapr_api_wrapper which is a requests like interface over dapr client for smooth transition from requests to dapr
from dapr_api_wrapper import requests as dapr_requests

test_body = {
  "id": "12345",
  "api_key": "1234567",
  "updated_at": str(datetime.now()),
  "num": 1234567,
  "is_auth": True,
}

resp = dapr_requests.post(
  app_id="myawesome-svc",
  url_path="http://myawesome-svc-svc/test",
  data=test_body,
  content_type="application/json",
  headers={"key1": "value1"},
  http_query_params={"querykey1": "queryvalue1"},
)
resp_json = resp.json()

resp_text = resp.text

resp_bytes = resp.bytes()

Questions

Can add this feature be added to dapr-python-sdk?
If not, is it okay to publish the above pip module on PyPI?

Better to discuss it in dapr/python-sdk


Disable scroll on the composer TextInput (close #2413)

In iOS, a multiline textinput has a scrolling behavior of its own. This created a scrollview-within-scrollview problem on iOS, because we embed the entire composer in a scrollview.
Disabling the scrolling behavior on the textinput solves this issue.
Closes #2413

Nice. Thanks for the hard work. <3

This is either not fully fixed or has been unfixed; it happened to me today on iOS 17/Bsky 1.67.0 (6)


Fix SerializeComponents::serialize_recursive by removing extraneous generic parameter

Fixes #590

This change is

Woops, I messed up, I'll fix this


Shortcut for quick-adding in browser

Hi, thank you so much for your work on linkding. It's been hugely useful for me for nearly a year now. I'd really like the ability to hit a shortcut like ctrl+shift+b or something to instantly attempt to add the current selected tab or tabs to my linkding.

You already created an issue for this, I have moved it to the extension's repo: https://github.com/sissbruecker/linkding-extension/issues/33


Revisit extending typing.List and typing.Dict in ListConfig and DictConfig

I tried it before and could not make it work.
can try again for 2.1.

Some context on why I think extending MutableSequence and MutableMapping is the way to go:
https://treyhunner.com/2019/04/why-you-shouldnt-inherit-from-list-and-dict-in-python/
I will take a closer look at this for 2.1.

not going to happen.

May I ask what is blocking you?

This is a breaking change and I don't think it's worth it.
OmegaConf containers are extending MutableSequence and MutableMapping and this should be good enough.


[SPARK-38503][K8S] Warn if VolcanoFeatureStep.getAdditionalPreKubernetesResources is used in executor side

What changes were proposed in this pull request?

Add warn for getAdditionalPreKubernetesResources in executor side

Why are the changes needed?
Only spark.kubernetes.scheduler.volcano.podGroupTemplateFile is going to be supported in v3.3, and it only be called when building driver side feature steps.
Does this PR introduce any user-facing change?
No
How was this patch tested?

K8S IT passed
CI passed

cc @dongjoon-hyun

[info] KubernetesSuite:
[info] - Run SparkPi with no resources (9 seconds, 179 milliseconds)
[info] - Run SparkPi with no resources & statefulset allocation (8 seconds, 592 milliseconds)
[info] - Run SparkPi with a very long application name. (8 seconds, 593 milliseconds)
[info] - Use SparkLauncher.NO_RESOURCE (8 seconds, 579 milliseconds)
[info] - Run SparkPi with a master URL without a scheme. (8 seconds, 682 milliseconds)
[info] - Run SparkPi with an argument. (8 seconds, 600 milliseconds)
[info] - Run SparkPi with custom labels, annotations, and environment variables. (8 seconds, 604 milliseconds)
[info] - All pods have the same service account by default (9 seconds, 567 milliseconds)
[info] - Run extraJVMOptions check on driver (4 seconds, 481 milliseconds)
[info] - Run SparkRemoteFileTest using a remote data file (8 seconds, 623 milliseconds)
[info] - Verify logging configuration is picked from the provided SPARK_CONF_DIR/log4j2.properties (16 seconds, 299 milliseconds)
[info] - Run SparkPi with env and mount secrets. (17 seconds, 24 milliseconds)
[info] - Run PySpark on simple pi.py example (9 seconds, 572 milliseconds)
[info] - Run PySpark to test a pyfiles example (11 seconds, 669 milliseconds)
[info] - Run PySpark with memory customization (9 seconds, 583 milliseconds)
[info] - Run in client mode. (7 seconds, 336 milliseconds)
[info] - Start pod creation from template (9 seconds, 692 milliseconds)
[info] - SPARK-38398: Schedule pod creation from template (9 seconds, 666 milliseconds)
[info] - Test basic decommissioning (42 seconds, 9 milliseconds)
[info] - Test basic decommissioning with shuffle cleanup (42 seconds, 465 milliseconds)
[info] - Test decommissioning with dynamic allocation & shuffle cleanups (2 minutes, 41 seconds)
[info] - Test decommissioning timeouts (41 seconds, 795 milliseconds)
[info] - SPARK-37576: Rolling decommissioning (8 minutes, 27 seconds)
[info] VolcanoSuite:
[info] - Run SparkPi with no resources (11 seconds, 119 milliseconds)
[info] - Run SparkPi with no resources & statefulset allocation (10 seconds, 594 milliseconds)
[info] - Run SparkPi with a very long application name. (10 seconds, 582 milliseconds)
[info] - Use SparkLauncher.NO_RESOURCE (10 seconds, 586 milliseconds)
[info] - Run SparkPi with a master URL without a scheme. (10 seconds, 563 milliseconds)
[info] - Run SparkPi with an argument. (10 seconds, 626 milliseconds)
[info] - Run SparkPi with custom labels, annotations, and environment variables. (9 seconds, 601 milliseconds)
[info] - All pods have the same service account by default (10 seconds, 593 milliseconds)
[info] - Run extraJVMOptions check on driver (5 seconds, 617 milliseconds)
[info] - Run SparkRemoteFileTest using a remote data file (10 seconds, 800 milliseconds)
[info] - Verify logging configuration is picked from the provided SPARK_CONF_DIR/log4j2.properties (16 seconds, 217 milliseconds)
[info] - Run SparkPi with env and mount secrets. (18 seconds, 401 milliseconds)
[info] - Run PySpark on simple pi.py example (10 seconds, 574 milliseconds)
[info] - Run PySpark to test a pyfiles example (12 seconds, 717 milliseconds)
[info] - Run PySpark with memory customization (10 seconds, 617 milliseconds)
[info] - Run in client mode. (7 seconds, 239 milliseconds)
[info] - Start pod creation from template (11 seconds, 742 milliseconds)
[info] - SPARK-38398: Schedule pod creation from template (9 seconds, 691 milliseconds)
[info] - Test basic decommissioning (44 seconds, 866 milliseconds)
[info] - Test basic decommissioning with shuffle cleanup (44 seconds, 124 milliseconds)
[info] - Test decommissioning with dynamic allocation & shuffle cleanups (2 minutes, 42 seconds)
[info] - Test decommissioning timeouts (43 seconds, 717 milliseconds)
[info] - SPARK-37576: Rolling decommissioning (1 minute, 7 seconds)
[info] - Run SparkPi with volcano scheduler (10 seconds, 660 milliseconds)
[info] - SPARK-38187: Run SparkPi Jobs with minCPU (31 seconds, 601 milliseconds)
[info] - SPARK-38187: Run SparkPi Jobs with minMemory (30 seconds, 562 milliseconds)
[info] - SPARK-38188: Run SparkPi jobs with 2 queues (only 1 enabled) (13 seconds, 364 milliseconds)
[info] - SPARK-38188: Run SparkPi jobs with 2 queues (all enabled) (25 seconds, 364 milliseconds)
[info] - SPARK-38423: Run SparkPi Jobs with priorityClassName (19 seconds, 300 milliseconds)
[info] - SPARK-38423: Run driver job to validate priority order (16 seconds, 464 milliseconds)
[info] Run completed in 29 minutes, 6 seconds.
[info] Total number of tests run: 53
[info] Suites: completed 2, aborted 0
[info] Tests: succeeded 53, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[success] Total time: 1829 s (30:29), completed 2022-3-10 11:09:53

We had better have another JIRA for this PR because this removes a conf, @Yikun .

@dongjoon-hyun Yes for sure.

In total, I made two PRs.

https://github.com/apache/spark/pull/35807
https://github.com/apache/spark/pull/35809

@dongjoon-hyun Thanks for your patient, will add a warn in first line, I think it's fair enough.

[info] VolcanoSuite:
[info] - Run SparkPi with volcano scheduler (11 seconds, 662 milliseconds)
[info] - SPARK-38187: Run SparkPi Jobs with minCPU (33 seconds, 98 milliseconds)
[info] - SPARK-38187: Run SparkPi Jobs with minMemory (33 seconds, 717 milliseconds)
[info] - SPARK-38188: Run SparkPi jobs with 2 queues (only 1 enabled) (17 seconds, 613 milliseconds)
[info] - SPARK-38188: Run SparkPi jobs with 2 queues (all enabled) (32 seconds, 118 milliseconds)
[info] - SPARK-38423: Run driver job to validate priority order (17 seconds, 899 milliseconds)
[info] Run completed in 2 minutes, 29 seconds.
[info] Total number of tests run: 6
[info] Suites: completed 2, aborted 0
[info] Tests: succeeded 6, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[success] Total time: 282 s (04:42), completed 2022-3-15 12:30:24

To avoid confused hidden change I move execut ut resource cleanup stuff in to a separate PR: https://github.com/apache/spark/pull/35857

@dongjoon-hyun It's fine from me. : )

Merged to master for Apache Spark 3.4.0.


[Exam] Quiz component for exams

Checklist

[x] I tested all changes and all related features with different users (student, tutor, instructor, admin) on the test server https://artemistest.ase.in.tum.de.
[x] Client: I documented the TypeScript code using JSDoc style.

Motivation and Context

The current implementation of the quiz exercises for the different modes includes too many features which are not needed / shouldn't be available during an exam.
Description

Extracted the base functionality of a quiz participation into a new component.
The participation is now an input of the component instead of being loaded via the url param.
The bar with the quiz-step icons is displayed on the left side and it can be navigated to the step by clicking it.
Steps for Testing

can only be tested locally until student exam participations aren't loaded into the exam view
Setup:

Import and embed the component into a component which contains a quiz participation (e.g. the quiz component). You can also comment out the other component so that only the one to test is displayed.
Pass the participation into the quiz-exam-component.

Test:

Log in to Artemis
Create a quiz with every type of quiz question
Navigate to where the component is displayed (e.g. a quiz open for practice)
Check that the quiz' components are displayed correctly and that you can interact with them
Check that you can navigate to a specific quiz question via the bottom bar

Screenshots

I tested it as well locally and everything is working fine. Good job 👍

Just one small issue. For me the left quiz-bar is over the quiz-exam-footer (both have z-index: 10). We should change the one of the quiz-bar


Guidelines are misaligned with strokes and dots

Currently Guidelines are being defined by name, font-wide values in the master. The Thickness is then extended upwards, starting at the named value. But since strokes (and dots) are expanded in both directions, this results in guidelines and strokes that are mismatched, as in:

There are a few different ways this could be addressed:

Center Guidelines: Center them on the named height values rather than extend them vertically. This will at least center-align everything consistently. It does mean that thick strokes over thin guidelines will extend on both sides of the guideline, which is not ideal.
Define many more custom font-wide heights: We would add names heights like “BaselineXL”, “BaselineL”. “BaselineR”, etc. then use these.  We could also center the guidelines on the height value (preferred by me), or just leave the behaviour as is and let the designer tweak it.
Switch to using instance-specific height values: This would allow us to tweak the guidelines to be in ideal positions, even when the thickness is different from the strokes/dots. We could also center the guidelines on the height value (preferred by me), or just leave the behaviour as is and let the designer tweak it.
Add an alignment adjustment option (preferred): This would involve adding a alignment preference option to each guideline in each instance. When setting a guideline you would choose the font-wide named value, the thickness, and an alignment chosen from these 7 options:
-- Center (default)
-- Top (top of guideline is at chosen value)
-- Top of stroke (top of guideline is at chosen value + half of stroke width)
-- Top of dot (top of guideline is at chosen value + half of dot width)
-- Bottom (bottom of guideline is at chosen value, this is the current default)
-- Bottom of stroke (bottom of guideline is at chosen value - half of stroke width)
-- Bottom of dot (bottom of guideline is at chosen value - half of dot width)
Adjust the stroking/dotting algorithm to force the letters into height-limited boxes: This would be a major change in strategy, and require quite a bit of revision to the algorithms. When I looked at this long ago, our current strategy of expanding strokes in all directions won out, and I still agree, so I’d not want us to pursue this.

I’d prefer the alignment adjustment option. I’d be willing to go with switching  to using instance-specific values or defining many more custom font-wide height values. In any case I’d prefer that the default be to use the value to define the center, not the bottom, of the guideline.

Switch to using instance-specific height values

This is already possible. The "Height" dropdown can take a number as well as a named metric.


[Feature request] enable user to pick language

According to my understanding of the documentation, currently the language used for Conversation is the one set in the properties. In my view it should be possible to define a different language in the configuration file. Even better would be, if each user could pick the preferred language.

Each user can select their own language, because the language set in the user profile is used.

Each user can select their own language, because the language set in the user profile is used.

Good to know. I thought that because the language setting is under general settings, it is applied globally. Nevertheless it would be helpful if a different language could be picked. In fact, I do like HA to be displayed in German but would prefer Assist to talk Swiss German.

I agree with that. I like my HA to be in English, but would like use assist in Dutch.
So for now my HA is in Dutch as well..

Yep, I would prefer my HA to be English and assist in Finnish. I have the setup with my iPhone, all UI is English, but Siri talks Finnish.
My reasoning for both HA and iPhone UI vs spoken content:

Translations from English to Finnish for technical things are usually not that great (GUI in English)
If I run into a problem, I prefer to be able to google for a solution in English as there is more content to search online (GUI in English)
I pronounce better Finnish than English (Spoken UI in Finnish)
Siri and Assist deal with a more humane everyday things where naming is more standard (compared to obscure network settings I prefer to handle over GUI) (Spoken UI in Finnish)


faster functions for a check if given (RA,Dec) fall on silicon

@barentsen can you take a look at this pull request

@rpoleski, the official repo for K2fov is actually KeplerGO/K2Fov, you should probably make the pull request there (@mrtommyb, is that correct?)
That said, I skimmed over the code, and the changes are reasonable and desirable. I'd like @barentsen to confirm that the tests are reasonably comprehensive, but otherwise I'd be in favour of merging.
@rpoleski , have you timed the speed up  for a large set of coordinates (say 10,000?) What sort of improvement do you see?

For ~12,500 stars it's 0.584 sec vs. 83.3 sec in old version. The execution time is similar for ~13 stars (0.084 sec). For a single star new version is slower: 0.0824 vs. 0.00681. I'm guessing in new version for small lists the time is limited by kd-tree construction inside Astropy.

Thanks for working on this @rpoleski.  I have merged your pull request into the master branch over at KeplerGO:K2fov, and made the modifications explained above.
@mrtommyb This pull request can be closed.  Please pull changes from KeplerGO:K2fov into mrtommyb:K2fov.


Patient-view:  context.encounter should be named encounterId

The patient-view context holds three fields: userId, patientId and encounter.
As the encounter field also holds an id field, it should be renamed to encounterId in line with the other fields.

The current version of the patient-view hook does call the encounter field encounterId, and I verified that what's included in the STU update content does as well. Where are you seeing the hook context called encounter?

Not sure - but that means this issue can be dropped,


Updateimage to run yum update

Starting with the Redhat ubi:python-39  UBI image I want too update the library packages on the image to pickup updates before building the detect-secrets container upon it.   ie grab updates to fix any vulnerabilities.

Closing ...meant for staging branch


Update deprecated package urls

Updated read me - Authentication section

Updated Node.JS based authentication package url - [ms-rest-nodeauth] to  [@azure/ms-rest-nodeauth] https://npmjs.com/package/@azure/ms-rest-nodeauth
Updated browser based authentication package url - [ms-rest-browserauth] to [@azure/ms-rest-browserauth]
https://npmjs.com/package/@azure/ms-rest-browserauth

Thanks!


fix: 修复在页脚开启时候 getViewHeight 超出范围的问题。

General
修复在页脚开启时候 getViewHeight 超出范围的问题。
此bug会导致PageWrapper在开启contentFullHeight时，看不到页脚（需要滑动）
快速修复，暂未考虑将 useContentViewHeight.ts 在 footer 内调用将带来的问题，应该也没啥问题。

✏ Mark the necessary items without changing the structure of the PR template.

[x] Pull request template structure not broken

Type

ℹ What types of changes does your code introduce?

👉 Put an x in the boxes that apply

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist

ℹ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

👉 Put an x in the boxes that apply.

[x] My code follows the style guidelines of this project
[x] Is the code format correct
[x] Is the git submission information standard?
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

有bug，先取消。


request "edit message" action in My Messages command

Extension
https://www.raycast.com/thomaslombart/messages
Description
an "edit message" action that uses Messages edit reply feature could be useful and i don't believe currently implemented
Who will benefit from this feature?
users who use raycast to interact with Messages and frequently fat finger typos that result in messages completely removed from the original intention
Anything else?
No response

Thanks for the feature request. Unfortunately, it's not possible to add any kind of "updates" action as written in the README, so I'll close this one as not planned 🙂


Implemented Default for Bson, Document, and ObjectId

Implemented Default for Bson, Document, and ObjectId. I also fixed some warnings with the tests.

Looks great actually. I will merge now. cc @kyeah

OID default should generate a new id via .new, i believe; what do yall think?

Well, it depends on what you need for Default. Could @NathanFlurry tell us why you need Default for those structs?

I'm actually a bit unsure that having Default for ObjectId is a good idea. At least in terms of usage with MongoDB, an all-zero value of ObjectId seems like a very bad idea (you can just use regular integers as your _id fields if you want to have control over the value), and having it generate a new one seems a little weird also given that two calls to ObjectId::default() won't return the same thing, which I feel like violates how Default is expected to behave.

@zonyitoo I implemented Default for these structures so I can use methods like unwrap_or_default() on them.
I agree that the implementation for ObjectId is a bit odd, but I did it that way because I believe that the result of default() should always be the same and not generate different values every time, like ObjectId::new() does. Maybe Default just doesn't fit on ObjectId at all.

I'm not certain it's really worth it just to avoid having to do opt_oid.unwrap_or_else(ObjectId::new()). Another common use of default I can think of is to save having to explicitly initialize every field of a struct (e.g. Foo { x: 1, y: 2, .. Default::default() }, but that doesn't apply here either. I think it's fairly obvious to a user that something called RandomState won't be the same every time it's created, whereas ObjectId might not be as obvious to someone who isn't familiar with the implementation (which is by design not required knowledge for using BSON/MongoDB).
The only argument in favor of implementing ObjectId::default I can think of is so that users can derive Default on structs that they want to serialize/deserialize to and from the database. This is also a pretty clear argument against having it being initialized to all zeroes. I don't think it would actually be terrible to implement it as a wrapper around ObjectId::new for this purpose, but I think it's a good idea to add a (doc) comment mentioning that it won't always return the same value.

 Given that the only reason I can think of to even have Default on ObjectId is to be able to serialize/deserialize structs, it seems extremely risky to just have silent failures; I can't imagine that many people would bother checking the resulting struct/bson doc to see if the ObjectId is all zeros even if we told them to, especially given that there isn't any easy way to do so, as the array field is (correctly) non-public. I think I'm back to recommending against having Default implemented for ObjectId, only more strongly than before.

I agree, too much unexpected behavior and I guess it doesn't really fit in this situation.

I am Ok with that. How about @saghm @kyeah

LGTM. Thanks for bearing with me when I kept changing my mind!

Will be released tonight (GMT+8)


Viewing records issue

It's difficult to determine which car is the "active" one while viewing records. TM keeps a list of active cars - however the list is not sorted, the order changes, and cars within are not easily identifiable.
An update to VehicleState should allow for a fix.
This may also apply to spectating (untested).

removed janky solution #13
only show when 1 replay is on-screen
did not actually apply to spectating


The fuzz tests were added for the tensorflow::core::function::Runtime class

The fuzz tests were added for the tensorflow::core::function::Runtime class.

Please use the macro tf_cc_fuzz_test found in tensorflow/security/fuzzing/tf_fuzzing.bzl instead of tf_cc_shared_test. This macro automatically includes "@com_google_fuzztest//fuzztest" and "@com_google_fuzztest//fuzztest:fuzztest_gtest_main", so you need to remove them from the deps list. You can also remove "@com_google_googletest//:gtest_main", since it is not needed.

@fcoUnda, Done

Hi @fcoUnda Can you please review this PR ? Thank you!

Hi @fcoUnda Can you please review this PR ? Thank you!

Hi @fcoUnda Can you please review this PR ? Thank you!


Add a warning when include PI (processing instructions) are used with v3

Description
XInclude should be used instead of ENTITY references and
XML Processing Instructions (PIs) that allow external inclusions. [1]
Add a warning when include PIs (<?rfc include='<reference>' ?>) are used with xml2rfc v3.
[1] https://datatracker.ietf.org/doc/html/rfc7991#appendix-B.1
Code of Conduct

[X] I agree to follow the IETF's Code of Conduct

FWIW, I disagree with the part "XInclude should be used instead of ENTITY references". ENTIRY references are a standard XML feature. We should not profile XML. (And yes, the other part about warning about the PI is good).


Mac: Xamarin Studio 5.10.3 (build 51) Error when opening Package Console Extension window

I get the following when the the window opens:
Command 'xcopy' not found.
  +CategoryInfo: InvalidOperation, Reason: CommandNotFoundException
  +FullyQualifiedErrorId: PackageManagementInternalError
Command 'xcopy' not found.
  +CategoryInfo: InvalidOperation, Reason: CommandNotFoundException
  +FullyQualifiedErrorId: PackageManagementInternalError
Command 'xcopy' not found.
  +CategoryInfo: InvalidOperation, Reason: CommandNotFoundException
  +FullyQualifiedErrorId: PackageManagementInternalError
Command 'xcopy' not found.
  +CategoryInfo: InvalidOperation, Reason: CommandNotFoundException
  +FullyQualifiedErrorId: PackageManagementInternalError
Command 'xcopy' not found.
  +CategoryInfo: InvalidOperation, Reason: CommandNotFoundException

  +FullyQualifiedErrorId: PackageManagementInternalError

And then if I try to run a command such as
Install-Package KeenClient

It then says
Invalid URI: The URI scheme is not valid.

Have I missed a setup step somewhere? Your screenshots are all from Windows, so I suppose this addin might only work on Windows. It doesn't explicitly state that in the readme though.

The addin works on all platforms, not just Windows.
Not sure where the xcopy command is being run from. It is not something the NuGet extensions addin will run itself. Do one of your NuGet packages have an init.ps1 file? I would guess that an init.ps1 is being run and it is running the xcopy command.
What url are you using as the package source? Does it work with the built-in Add Packages dialog? If you run the following command after attempting the install what does the callstack look like?
$error[0].Exception.StackTrace


Revised C++ API docs and dependencies

This PR provides complete docs for the C++ API only. I manually structured the breathe RST directives in an attempt to organize the API in a fairly logical way. It would be good for any reviewers to build locally to verify the choices, though you can get sense of it from the RST files present here too.
One significant change made in this work is the removal of all documentation related dependencies from OCIO_INSTALL_EXT_PACKAGES, which is now limited to core library dependencies. I made this change because the differences in installing Doxygen across platforms are non-trivial, which are much more easily mitigated by installing Doxygen via a platform-specific package manager. I've included shell scripts for each platform (supporting bash only, with GitBash for Windows) to install these dependencies with native package managers if anyone is interested (this is what the CI is now using). I added a note to the install instructions about this too.
One improvement related to removing the Python dependencies from OCIO_INSTALL_EXT_PACKAGES is that the build is now faster, as I found that previously due to using an external site-packages directory and conflicting versions, Python was re-installing PyPi package dependencies on top of each other in some cases. Now it's up to the user to provide Doxygen, Sphinx, and the necessary Python packages, and the default version of each should be sufficient. All dependencies are listed in the installation instructions, along with the previously mentioned bash scripts. This will also encourage contributers to install these once, which eases repeated builds while testing docs.
An important note: merging this PR will break the current API docs on RTD. I need to do investigation into the RTD build process to set it up properly, which I will investigate soon. We could wait to merge this until that point. I primarily wanted to put it up for review now to not get too far without feedback. I'll now start chipping away at the Python portion and update this PR when that is ready, probably in a week or so.

I should also mention two general CMake changes:

There is not only one call to find_package(Python) done at a global scope, which removes the previously duplicated logs of finding Python during configuration. The FindPython result vars are now available in every CMake module without doing anything extra (after FindExtPackages.cmake is imported).
I moved the full OCIO_VERSION macro construction from OpenColorABI.h.in to the root CMakeLists.txt. This is an important change because otherwise OCIO_VERSION evaluates differently at different stages of configuration, and differs between CMAKE_BUILD_DIR and CMAKE_BINARY_DIR. Now they match, and this macro is used to populate the C++ RST files with the full namespace. You'll note that they are each *.rst.in files, for this reason, which helps Breathe produce clean docs. I added a loop to the docs CMakeLists.txt which finds and configures all *.in files within the docs/ dir, so that convention can now be used freely anywhere in the docs, particularly where version specific info is needed.

In the document V2_DOC_README.md you can add:
To ease the documentation build and test on MacOS one could add the next three lines in the ~/.zshrc file:
- alias python=/usr/local/bin/python3
- alias pip=/usr/local/bin/pip3
- [optional] alias chrome=open -a "Google Chrome"

You can then type "chrome ./docs/build-html/index.html" to access the HTML documentation.

I'm going to close this to avoid spamming this PR with a lot of updates while I continue work on the branch. @hodoulp thank you for the feedback. I will take it into account in the next (non-draft) PR.


refactor(ast): store ScopeId in AST nodes

Add scope_id field to all AST nodes which can constitute a scope (Program, Function, BlockStatement etc).

#3302  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on  Graphite

@rzvxa Can you help us review this PR stack, I want to have a second pair of eyes 😅

@rzvxa Can you help us review this PR stack, I want to have a second pair of eyes 😅

Sure thing, Although it might take me a few hours before reviewing this.
@overlookmotel Quick question, why not store node_id? so we can have both Scope and CFG information deferred from that? I wasn't following the chain of events that led to this PR, Can you bring me up to date with the context of problem we are trying to solve here?

@rzvxa Can you help us review this PR stack, I want to have a second pair of eyes 😅

Sure thing, Although it might take me a few hours before I'm done with the review.
@overlookmotel Quick question, why not store node_id? so we can have both Scope and CFG information deferred from that? I wasn't following the chain of events that led to this PR, Can you bring me up to date with the context of problem we are trying to solve here?

We are building up the prerequisite for #3251 (comment)
We want to put scope and symbol table into ast traverse so we can access the data at least.

So why not store node_id? It can point to both the scope and symbol data associated with the node, It has a bit more overhead because of indirection but would future proof the AST referencing since in the future we can easily add and remove information associated with that ID. I have no objection, Just curious to know the reasoning.

Sure thing, Although it might take me a few hours before I'm done with the review.

@overlookmotel will be afk for the next few days so take your time 😀

So why not store node_id?

I'm too eager to have a working solution right now for finding all the edge cases, so we are going after smaller changes right now. Once we have everything passing, we'll reevaluate our decisions and infrastructure (for the 10th time).

Surprised (but pleased) to see the addition of ScopeId to a bunch of AST types barely registers on benchmarks. There's basically no cost to doing this.

@rzvxa Not ignoring your questions above, just have to run now. Will come back to it.

So why not store node_id? It can point to both the scope and symbol data associated with the node, It has a bit more overhead because of indirection but would future proof the AST referencing since in the future we can easily add and remove information associated with that ID. I have no objection, Just curious to know the reasoning.

@rzvxa To come back (finally) on this question...
First of all, this v1 implementation is a rough attempt to implement what we need right now (scope and binding information) as swiftly as possible so we can proceed with the React+TS transforms that we're currently blocked on. The easiest way to do that without re-inventing any wheels was just to reuse Semantic.
However, we can't use all of Semantic. AstNode contains AstKind, which contains refs to AST nodes. This is incompatible with having &mut refs to AST nodes in the enter_* and exit_* visitors. It's the same problem as before - aliasing references.
So currently, in terribly inefficient fashion, we run semantic on the AST, and then throw away most of the data it produces. Clearly, this will need a complete rethink once we have transformer milestone 1 complete. So none of this is set in stone.
But at this point, given the problem of aliasing references, I'm unclear what AstNodeId would give us - since we can't use the node ID to get back to an AST node. Am I missing something?
More broadly, the approach I was thinking of was to start by giving the transformer the minimum of information it needs, and then adding more if and when it becomes clear that we need it - rather than starting out by giving it the whole kitchen sink and then trying to pare it back. The control flow graph, for example, I think we should try to avoid using in the transformer if at all possible. Maybe we need it in some cases, but hopefully not. If we do use it, then we have to somehow keep it in sync in every transform, which will become quite a burden.
The other big reason why I don't have a clear answer to your question is simply that I don't really understand Semantic and its uses yet. I've not had time to dig into it properly. I've been delaying doing that until after the immediate need (the missing TS transforms) is completed. So apologies that I just don't know enough to engage with your question as thoroughly as I'd like.


AttributeError: ... object has no attribute '_tracker'

Problem
I'm getting the following stack trace and I'm not sure why.  It seems like such a simple case -- just creating an object.

Traceback (most recent call last):
[...]
  File ".../testing/mock_data.py", line 194, in _add_run
    run = Run.objects.create(
          ^^^^^^^^^^^^^^^^^^^
  File ".../.venv/lib/python3.11/site-packages/django/db/models/manager.py", line 85, in manager_method
    return getattr(self.get_queryset(), name)(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File ".../.venv/lib/python3.11/site-packages/django/db/models/query.py", line 453, in create
    obj.save(force_insert=True, using=self.db)
  File ".../models/run.py", line 127, in save
    super().save(*args, **kwargs)
  File ".../.venv/lib/python3.11/site-packages/django/db/models/base.py", line 739, in save
    self.save_base(using=using, force_insert=force_insert,
  File ".../.venv/lib/python3.11/site-packages/model_utils/tracker.py", line 373, in inner
    tracker = getattr(instance, self.attname)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'Run' object has no attribute '_tracker'

Removing my own save() didn't help
The class is derived directly from models.Model and tracker = FieldTracker() is after all of the fields.
Is there any other debugging or tracing I could provide to show why _tracker isn't added to the class?
Environment

Django Model Utils version:  4.3.1
Django version: 3.2.19
Python version: 3.11
Other libraries used, if any:

Code examples
Give code example that demonstrates the issue, or even better, write new tests that fails because of that issue.
I'm going to try some tracing to provide more info.

Aha!.... I turn off signals in some of my unit tests to speed up tests when my object factory is running.
Anyone else googling and finding this error, it's likely you've disabled signals.
Will leave open in case team wants to call this out in the docs?


Efficient layouts

covert all the layout to use constraint layout.

@AliAzaz -- Would you like to take this up ?

I would like to do this.

yes sure @Abhishek765

I would like to do this

@nitinnatural I would like to do this.

@jokopriyono - Please go ahead!


ERC721 _mint and onERC721Received

ERC721 transfers are required to call onERC721Received if the receiver is a contract. I don't know if this is specified in the EIP, but we might have to do the same in _mint. Currently we are not.
This needs some discussion because it would be a breaking change. Additionally, it may not be obvious that _mint will call an external contract, and as always this opens up the possibility for reentrancy.
Thanks @alcuadrado for pointing this out.

From the EIP:

Creating of NFTs (“minting”) and destruction NFTs (“burning”) is not included in the specification. Your contract may implement these by other means. Please see the event documentation for your responsibilities when creating or destroying NFTs.

(the events documentation only discusses emitting a Transfer event, which we do)
Note that only safeTransferFrom is required to call onERC721Received, transferFrom does not have that requirement. We could add a new _safeMint function that performs the check.
As a workaround until this issue is fixed, a contract minting tokens may achieve this behaviour in the following way:
function _safeMint(address to, uint256 tokenId) internal {
  _mint(address(this), tokenId);
  safeTransferFrom(address(this), to, tokenId);
}

only safeTransferFrom is required to call onERC721Received

Good point.

We could add a new _safeMint function that performs the check.

I like this idea! Makes a lot of sense to me.

Hm, we don't have an internal _safeTransferFrom... We should add both _safeTransferFrom and _safeMint. Does this sound ok?

Yes, given that we do have _transferFrom. Note that we should go for the variant with the data parameter.

Hi guys @nventuro @balajipachai I think I understood what is required to fix this issue. What is the state of things? May I move forward?

@alanarvelo there is an open PR (https://github.com/OpenZeppelin/openzeppelin-solidity/pull/1748), but it hasn't received attention for some time now. I'd suggest taking a look at it and at the review comments - if I recall correctly some bugs were introduced by it. Other than that, by all means go ahead! 🎉

https://github.com/OpenZeppelin/openzeppelin-solidity/pull/1748 was just closed as stale. The PR is mostly good but it has some changes to the existing functions that are incorrect and should be reverted.
Whoever wants to pick this up please do!

I am picking it up and will get back with more questions.
Thank you.

Hi @logeekal, I submitted a PR two days ago tackling this. Feel free to take a look at it and shoot questions or suggestions

Hi @frangio should we close this issue? Any other particular issue that I can help on?
Thanks.

Yes thanks for pointing it out!


fix(dotnet): use snupkg format for dotnet symbol packages

The legacy format is not supported by NuGet's own symbols server, and the
SymbolSource server is currently experiencing a certificate expiration event,
which seems to be a somewhat recurring issue (NuGet/Home#6082).
More info: https://docs.microsoft.com/en-us/nuget/create-packages/symbol-packages-snupkg

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Add Velas Mainnet & Testnet

Please add Velas Mainnet & Testnet :
https://github.com/safe-global/safe-deployments/pull/71
Thank you.

Velas testnet was merged by mistake and will be removed: https://github.com/safe-global/safe-eth-py/pull/513


Ore Processors cannot be unanchored.

Ore Processors are the only machine which, once assembled, cannot be moved.
Reproduction:

Create an ore processor in an inconvenient location.
Watch everyone cry.
Block off major hallways with ore processors.
Get banned.

They also cannot be disassembled, so it is literally impossible to move them once they're down.

fixed


[BUG] Relay sdk doesn't have option to Allow trusted Microsoft services

Library name and version
Azure.ResourceManager.Relay 1.1.1
Describe the bug
RelayNetworkRuleSetData class doesn't have parameter to Allow trusted Microsoft services. From the portal there is the option.

Expected behavior
.NET sdk should also have a parameter ( probably boolean ) to Allow trusted Microsoft services in relay firewall.
Actual behavior
TrustedServiceAccessEnabled this param is missing
Reproduction Steps
Create a GetRelayNetworkRuleSet on relay namespace
Environment
No response

Thank you for your feedback.  Tagging and routing to the team member best able to assist.

Hey @ashishranjan2011 , thank you for reaching out to us about the Azure SDK for .NET. Unfortunately, this issue is related to the service side and not the SDK side which the swagger spec doesn't expose such option, so we are not able to help you with it. Therefore, we are closing this issue for now. If you need more assistance, please open an Azure support request. We apologize for any inconvenience this may cause you.
We value your feedback and we want to make sure that your problem is solved. If you think that we have misunderstood your issue or closed it incorrectly, please feel free to comment on this thread and reopen the issue. We will be happy to assist you further. Thank you for your understanding and cooperation.


Allow setting vNIC pci address

What this PR does / why we need it:
This will allow users to specify an optional PCI address for network interfaces.
This is particularly needed for users who are concerned with PCI addresses stability and would like to set their own.
Which issue(s) this PR fixes :
Related #1325
Special notes for your reviewer:
Release note:
Allow users or higher level applications to set a specific PCI address for guest interfaces to maintain stability.

need to add a functional test.

/cc @stu-gott @cynepco3hahue @davidvossel @fabiand can you guys please review it? :)
@phoracek comments were addressed. Don't like to see this code rot. Please let me know if you have any concerns. Thanks!

ci test please

I just wonder if the plan is to add PCI Address support to every device class individually, or if you considered to generalize this - to make it applicable to other device classes as well?

My plan was only to allow setting PCI addresses for nics (now) and disks (in another PR) and maybe vgpu in the future. Libvirt also sets PCI addresses for controllers. Hope we are not planning to allow changing this via API.
@fabiand , I think I'm missing something - What did you have in mind? How do you see this generalization? Different addresses need to be set on each device, it's important to control it on a device based level - so I don't see how it can be generalized.

Maybe we can create additional struct PCIDevices move all relevant devices under it and add it under Devices struct.

Ok, maybe we should. I'm just not sure what's the purpose. Did you think to use it for validations or anything else?

Ok, maybe we should. I'm just not sure what's the purpose. Did you think to use it for validations or anything else?

I checked your response to @fabiand and it works for me, so just ignore my comment :smile:


paste buffer with bracketed paste

this ensures the command does not automatically execute

Some more context:

If -p is specified, paste bracket control codes are inserted around the buffer if the application has requested bracketed paste mode. This primarily prevents a paste from executing right away, since the underlying terminal (zsh in my case) knows that the input text is pasted in and should be reviewed before editing.
This has been working great for me the last 1mo+ without any side effects


PATCH: Add resource server scopes to terraform import

The response that fetches resource servers included only 2 fields: id and name
Because of this, the scopes filed was always an empty slice and thus never populated during a terraform import.

🔧 Changes

📚 References

🔬 Testing

📝 Checklist

[ ] All new/changed/fixed functionality is covered by tests (or N/A)
[ ] I have added documentation for all new/changed functionality (or N/A)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.05%. Comparing base (01a8ebc) to head (b248151).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1079   +/-   ##
=======================================
  Coverage   72.05%   72.05%
=======================================
  Files          94       94
  Lines       12938    12938
=======================================
  Hits         9322     9322
  Misses       3069     3069
  Partials      547      547

Flag
Coverage Δ

72.05% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


DarkHex & Hex Fixes and Updates

Error on player board representation fixed (no flood fill applied; missing info)
Fixed naming convention for the parameters, common term is "number of rows" rather than "column size" etc.
Reduced the default board size to a more reasonable value.
Fixed game logic for hex
Board size with a row or col 2 fixed

I think I am getting a precision error on playthroughs on the push

I think I am getting a precision error on playthroughs on the push

Can you try reverting python_mfg_predator_prey.txt ?

Hi Bedir,
Can you elaborate on the bug?
Is it easy to send us a serialized state string or action history where some demonstrably incorrect happens?

Yeah sure thing. I realized the bug on the test I added to hex_test.cc.
In Hex and DarkHex we do want to evaluate uneven boards at times, and that is why I converted the board sizes to num_cols and num_rows before, but I actually did it in a way that it will always be larger on the num_cols then num_rows (board looking cleaner) which was problematic since we were printing the other way and checking for terminal state using the unaltered position rather than altered version.
Here is the output where it clearly shows that the connection is not properly satisfied (due to row-column sizing issue I mentioned):
. y p
 . y p
  . z p
   . z .
Spiel Fatal Error: /home/bedir/Documents/open_spiel/open_spiel/games/hex_test.cc:39 CHECK_TRUE(state->IsTerminal())

And here is the output where it is now fixed.
. y q
 . y q
  . y q
   . X .

This actually causes the game to never reach a terminal state at times (which causes infinite game time...) I am not sure how did this slip my tests before :)

@lanctot any update on this?

Yeah, sorry, I do intend to go through it with @TWAnthony tomorrow and hopefully pull it in this week.

No worries that's perfect :)


Unable To Record

hi, i'm running locast2tuner with plex, i'm able to add and watch channels but unable to record.  It'll claim it's recording but it doesn't.  I do have a donate account with locast so i'm really at a loss why it's not working.

I'm not sure if this is a locast2tuner issue, since streaming works. However, do you have any locast2tuner logs? Do you see any requests from Plex at the time the recording happens? If you start locast with verbose = 1, you should see the different HTTP requests coming from Plex.

i made the changes in the config file, is it just locast2tuner --syslog to see the logs?

It depends on how you run locast2tuner.  Do you use the docker instance? Or do you use the ubuntu package? Mac homebrew?

I'm using the raspian install
On Fri, May 21, 2021, 4:38 PM Wouter de Bie @.***>
wrote:

It depends on how you run locast2tuner. Do you use the docker instance? Or
do you use the ubuntu package? Mac homebrew?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/wouterdebie/locast2tuner/issues/54#issuecomment-846245686,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACSMXPV5FU4POYT3YOUUAXLTO3AC5ANCNFSM45JYWSSQ
.

it should log in /var/log/syslog then..

here are my logs, at  19:15:10 i tried recording.  I don't see anything in
plex indicating it's actually recording and nothing else is in the logs
after that
May 21 19:13:15 raspberrypi locast2tuner[9815]: May 21 19:13:15.327 INFO
Login succeeded!
May 21 19:13:15 raspberrypi locast2tuner[9815]: May 21 19:13:15.853 INFO
Using cached FCC facilities at /var/lib/locast2tuner/facilities
May 21 19:13:17 raspberrypi locast2tuner[9815]: May 21 19:13:17.328 INFO
Loading stations for New York (cache: true, cache timeout: 3600, days: 8)..
May 21 19:13:17 raspberrypi locast2tuner[9815]: May 21 19:13:17.367 INFO
Starting http server for New York on http://<IP_ADDRESS>:6077
May 21 19:13:17 raspberrypi locast2tuner[9815]: May 21 19:13:17.368 INFO
Starting 4 workers
May 21 19:13:17 raspberrypi locast2tuner[9815]: May 21 19:13:17.375 INFO
Starting "actix-web-service-<IP_ADDRESS>:6077" service on <IP_ADDRESS>:6077
May 21 19:13:17 raspberrypi locast2tuner[9815]: May 21 19:13:17.375 INFO
Tuners:
May 21 19:13:17 raspberrypi locast2tuner[9815]: May 21 19:13:17.376 INFO
+----------+----------+-----+--------------------------------------+------------------+-----------------------+
May 21 19:13:17 raspberrypi locast2tuner[9815]: May 21 19:13:17.377 INFO  |
City     | Zip code | DMA | UUID                                 | Timezone
| URL                   |
May 21 19:13:17 raspberrypi locast2tuner[9815]: May 21 19:13:17.378 INFO
+----------+----------+-----+--------------------------------------+------------------+-----------------------+
May 21 19:13:17 raspberrypi locast2tuner[9815]: May 21 19:13:17.378 INFO  |
New York |          | 501 | 453fc7b1-d7e4-5d9a-820a-4b3a2e7bdf49 |
America/New_York | http://<IP_ADDRESS>:6077 |
May 21 19:13:17 raspberrypi locast2tuner[9815]: May 21 19:13:17.379 INFO
+----------+----------+-----+--------------------------------------+------------------+-----------------------+
May 21 19:13:17 raspberrypi locast2tuner[9815]: May 21 19:13:17.380 INFO
locast2tuner started..
May 21 19:15:10 raspberrypi locast2tuner[9815]: May 21 19:15:10.824 INFO
<IP_ADDRESS>:55256 "GET /discover.json HTTP/1.1" 200 287 "-"
"PlexMediaServer/<IP_ADDRESS>23-d0ce30438" 0.000077
May 21 19:15:10 raspberrypi locast2tuner[9815]: May 21 19:15:10.828 INFO
<IP_ADDRESS>:55256 "GET /lineup_status.json HTTP/1.1" 200 73 "-"
"PlexMediaServer/<IP_ADDRESS>23-d0ce30438" 0.000114
On Fri, May 21, 2021 at 5:17 PM Wouter de Bie @.***>
wrote:

it should log in /var/log/syslog then..
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/wouterdebie/locast2tuner/issues/54#issuecomment-846264608,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACSMXPWGATWDVBDEVSCE2CLTO3EXHANCNFSM45JYWSSQ
.

--
Joshua A. Cohen
31 Payne Road
Bethel CT, 06801
(203) 312-3213
@.***

Yeah, this seems to be a Plex problem. Plex doesn't even seem to start the recording. If you stream and look at the logs it should show you what it looks like.
From the locast2tuner perspective, a recording or a direct stream is exactly the same.

Agreed - I just tried a recording here from Plex and it worked fine.
Check the Plex logs to see what's happening - If it thinks it is recording and then the show doesn't show up, then Plex is definitely making that decision for some reason.

Not sure how new your install is, but the whole Plex ecosystem seems to need you to log out and log back in to recognize your paid-for account in different parts of the system.  I recall doing that a few times across web browser and the Plex application (along with restarts of Plex) trying to get the DVR to show any recording buttons after I first installed it.  As Wouter de Bie said, from the locast2tuner perspective there's no difference whether you're watching or recording content streams -- so this should really be closed as it's not an issue with locast2tuner.

Closing this, since this doesn't seem to be a locast2tuner problem, but a Plex issue.


My first successful "blj"

yay for bug
i go near the fountain on the green left to it
look downhill right at the edge of the map
ground pound and quickly jump backwards
get stuck and travel a parallel universe

doesnt happen anymore


GH-101: Rename DeDup Classes/Interfaces to Filter

Resolves #101

I think I'm fine with the solution.
@mbogoevici ?

Pushed - @artembilan - it's a bit simpler now, if the container listener factory is configured - we wrap the MMLA with a filtering adapter.

The trouble with making it true by default is it really can only be used of the AckMode is set to one of the MANUAL options.

Merged as https://github.com/spring-projects/spring-kafka/commit/b1dc76e3a974f09b52c962f90351999eb5880af9


Instruction page to be seen after first login

From @JosephMcArthur on October 16, 2014 16:43
Mock up and copy here. https://www.dropbox.com/s/op8brcfcfmsap7p/Screenshot 2014-10-16 17.42.46.png?dl=0
Copied from original issue: OAButton/oab-chromeaddon#19

Instruction page is now on account page on the site, and users are sent there on first login of plugin anyway now, so the instructions in the button are no longer necessary. This also gives us one source of instructions to manage, and different plugin / bookmarklet / widgets can point there.


Issues with kubelet: Orphaned pod found

I run into issues with thousends of such log entries in kubelet. I found this because kubelet is using much CPU and I checked the logs.
Orphaned pod "017d4c65-6c26-11e9-8013-9600002440c4" found, but volume paths are still present on disk : There were a total of 2398 errors similar to this. Turn up verbosity to see them.

How can I resolve this?

Can you share a little bit more info on your setup? Especially what you have deployed and more kubelet logging would help too. This also helps in reproducing any issue that you encounter. Maybe https://github.com/kubernetes/kubernetes/issues/60987 has a relation with your issue, we can reopen if you can provide more information on the problem.


HTTP Error 502.3 - Bad Gateway (Error Code   0x80072ee2)

In my solution i have 2 projects. one of them is netstandard1.5  class library containing Db Models and DbContext Classes and i named it [project].Core

in my other Core Web Application i named it [project].Web and added my [Project].Core Reference.

I added Db Migration update the databse. Everything works great.
if i don't use this dbcontext the web app works fine.
But when i tried to get data from my Dbcontext I getting an error

i visited many github repos try to find any solution but i couldn't. i also renamed my web project to [project].Site but it did't help.
and the thing is after i getting this error in my browser then if  i refresh the browser few mins later the error this gone and my app works perfectly . i still don't understand why it happening...

0x80072EE2 is ERROR_WINHTTP_TIMEOUT. Looks to me that for whatever reason the application take a long time to start and the AspNetCoreModule is timing out trying to start the application. To confirm you can check event log - AspNetCoreModule writes startup errors there. You can also turn on stdOutLogging in your web.config to see what is happening. You may want to take a look at my post where I describe steps to troubleshoot 502.3 errors.

@moozzyk  thanks you. right now i am going to investigate using your post and i will get back to u with result. thanks again......
and another thing i have to say that when i cutting down my table number in my database its working fine. but when i using all my table in my database only then the problem arriving.

@himadrinath - once you get more details and you confirm your issue is related to database you may want to file a new issue in the EntityFramework repo.

@moozzyk i will do that. once i get the reason...

@moozzyk after installing 1.0.0 (Tools Preview 2) the problem automatically solved. i think may be the problem is EntityFramework related not IISIntegration. before Db migration takes couple of mins and now its take couple of sec. Thanks for u replies. i read your post and its help me to understand asp core startup and how iis and Kestrel working together and process the request. thanks again


feat: full screen previewer

Thank you for your contribution to the KodaDot NFT gallery.
this pr is to add the full screen previewer feature on gallery item, also fix some display issue i commited in #5309
FYI: @prachi00 since the break point is set to 930px so i remove the styles you commit in #5134, it caused some display issue in new break point
👇 _ Let's make a quick check before the contribution.
PR Type

[x] Bugfix
[x] Feature
[ ] Refactoring

Context

[x] Closes #4764
[ ] Requires deployment <>

Before submitting pull request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality
[x] I've posted a screenshot of demonstrated change in this PR

Optional

[ ] I've tested it at </bsx/collection>
[ ] I've tested PR on mobile
[ ] I've written unit tests 🧪
[ ] I've found edge cases

Had issue bounty label?

[x] Fill up your KSM address: Payout

Community participation

[x] Are you at KodaDot Discord?

Screenshot 📸

[x] My fix has changed something on UI; a screenshot is best to understand changes for others.

@exezbcz please do the ui check :)

hey hey, nice

can you make the buttons look like this please?
they are 35px
they are in figma - gallery item handoff, icon section https://www.figma.com/file/gHSzqGPeQ9qK4L0qIDcTjY/gallery-item-handoff?node-id=1270%3A5615&t=rutwiIgwZu2HqYYh-1

Why did you change NeoIcon to use svg? I prefer that you use fontawesome expand icon since it's the same and then change color according to theme

Why did you change NeoIcon to use svg? I prefer that you use fontawesome expand icon since it's the same and then change color according to theme

reverted using NeoIcon @roiLeo

can you please make the button visible on all touch devices - not only mobile

last thing:

can you please make the button visible on all touch devices - not only mobile

this still does not work, it should be shown by default, not after click on the img
otherwise good!

updated

Mobile navbar changed

hmm seems it's the result of the break point change, i'll fix it

pay 35 usd


Suggestions from barcode

Currently, the suggestions try to find the input text in the product names.
The idea of this feature is that if a part of a barcode is typed in (that is, only numbers), we try to find products with a similar barcode (instead of product name search).
I'm about to PR that.

Fixed by #430.


[Topi] Allow batch_matmul to broadcast along batch dimension.

We found that requiring explicit broadcasting along the batch dimension for batch_matmul could cause serious memory issues during constant folding, since it would effectively multiply the size of weights by the input batch size. This PR allows implicit broadcasting along the batch dimension for batch_matmul without increasing compute or memory requirements. This should in fact give pretty significant speedups in cases where we previously applied explicit broadcasting. I also noticed that we had an unused C++ definition of batch_matmul and removed it to prevent confusion.

@mbrookhart, @csullivan, @rkimball can you guys take a look at this PR?

cc @yzhliu @icemelon9 @masahi

I need to make a few fixes after the merge with the dynamic shapes PR, which involved several changes to batch_matmul.

@masahi can you take a quick look at this PR?

Thanks @jwfromm @mbrookhart @csullivan @rkimball


Go fails silently on attempted Hover install

(Hover is currently not installed. Thus, I can't share the results of hover doctor.)
Error output
go get -u github.com/go-flutter-desktop/hover completes silently, with no logs. However, the terminal errors out upon me trying to use hover, saying that there is no command 'hover':
~ master*
❯ go version
go version go1.13.8 darwin/amd64

~ master*
❯ go get -u github.com/go-flutter-desktop/hover

~ master* 19s
❯ hover build
zsh: command not found: hover

Above is my exact terminal inputs and outputs.

Can you try:
$ git clone https://github.com/go-flutter-desktop/hover.git
Clonage dans 'hover'...
remote: Enumerating objects: 24, done.
remote: Counting objects: 100% (24/24), done.
remote: Compressing objects: 100% (15/15), done.
remote: Total 475 (delta 11), reused 16 (delta 9), pack-reused 451
Réception d'objets: 100% (475/475), 151.07 Kio | 568.00 Kio/s, fait.
Résolution des deltas: 100% (258/258), fait.

$ cd hover
assets  cmd  go.mod  go.sum  internal  LICENSE  main.go  README.md  renovate.json

$ go install

$ hover help
Hover helps developers to release Flutter applications on desktop.

Usage:
  hover [flags]
  hover [command]

Okay, that works. Thanks for the quick response.

I think this is a duplicate of #306


Ali: Welcome to JS : 3 Weeks

MY FORK
Learning Objectives
1. What is Programming

[x] Data in, Data Out: You understand that computer programs are used to
transform data, and can explain a JS program from this module in terms of
the data that goes in and the data that comes out.
[x] Three Audiences: You can explain how a single file of code is used to
communicate with 3 different audiences:
[x] Developers: You can explain how code formatting, comments, logs and
variable names make it easier (or harder!) for a developer to understand a
program.
[x] Computers: You can explain how a computer follows your instructions to
store, read and modify data in program memory.
[ ] Users: You can explain how the computer creates a dynamic user
experience by following different executions paths depending on user
input.
[ ] Tracing Variables: You can complete a trace table for a program that
uses only variables, and can check your work using the "trace" button.

2. Just Enough JavaScript

[ ] JavaScript Syntax: Given a program, you can identify these parts of
JavaScript syntax:
[ ] Primitives
[ ] Operators
[ ] Identifiers
[ ] Keywords
[ ] Checks
[ ] Blocks
[ ] Function Calls
[ ] Listening and Reading: You can read code out loud, and understand your
classmates when they read code to you. You don't need to understand how a
program works to master these learning objectives!
[ ] Listening You can exactly re-write a program that a classmate has read
[ ] Reading You can read a program out loud and guide your classmates to
re-write exactly the same code without them seeing the program. Every
indentation, semi-colon, comment and spelling in their program must be
identical to yours.
[ ] Static vs. Dynamic Analysis: You can explain and use these two ways of
studying a program, each can help you understand different aspects of your
code. To help understand this concept, the options panel in Study Lenses
is organized into static and dynamic study options:
[ ] Static: Studying the text in a code file without running it. Some
static study methods are creating a flowchart, analyzing variables,
filling out a trace table, and drawing on code.
[ ] Dynamic: Running code and studying the computer's behavior. Some
dynamic study methods are running code and reading console logs, using the
trace button, and stepping through in the debugger or JS Tutor.
[ ] Tracing Execution: You can complete a "steps" trace table for all JS
language features in Just Enough JavaScript, and can correct your table
using console output from the "trace" button.
[ ] Analyzing Variables: You can list all the variables in a program, and
answer these 5 questions for each variable:

Where is the variable declared?
What is the variable's scope?
Is the variable initialized with a value?
How many times is its value used (read) in the program?
How many times is the variable assigned a new value?
What types are assigned to this variable during the program's execution?

[ ] Completing Programs: You can successfully fill in blanks for a program
when the missing words are provided, including distractors.
[ ] Translating Pseudo Code: Given a program written in Pseudo Code, you
can translate it to working JavaScript.
[ ] Comparing Programs: You can compare two programs with similar code and
explain if they have the same behavior or not. If they do not, you can
explain how they behave differently and why.
[ ] Constructing Programs: You can reconstruct a program's lines and
indentation, successfully ignoring distractor lines.

3. Understanding Programs

[ ] Stepping Through: You can pause a script in a your browser's debugger,
arrange the debugger, collapse extra panels, and step through a script
written with Just Enough JS. At each point in execution you can make a
prediction of the next line before executing, and can check your
prediction using the scopes panel.
[ ] Imperative Programming: You can explain what the Imperative
Programming paradigm is, and can explain how you know the programs in
Welcome to JS are Imperative.
[ ] Program Goals: You understand that a full JavaScript program can be
explained as a series of smaller goals, and can write names for the goals
in a simple working program.
[ ] Logging: You can tracing specific aspects of a program's execution and
log them to the console.
[ ] Tracing Backwards You can trace backwards from a program's output to
it's input.
[ ] Naming Variables: You can analyze how a variable is used in a program
and give it two names:

[ ]Generic: You can give a generic name to a variable based on how it is
used in the program.
[ ]Specific: You can give a specific name to a variable based on how it's
used and the program's domain (the program's specific data and use-case).

[ ] Describing Programs: You can read a program and describe it with
comments using to the methodology from /describing-programs:

Zoom Out
Zoom In
Find Connections
Describe Goals

[ ] Code Review: Given a working program you can review the code for
clarity, correctness and style.
[ ] Same Behavior, Different Code: You can study simple programs with the
same behavior (data in, data out) but different source code and explain
how the differences matter for each audience.

4. Developing Programs
Learn to modify and write larger programs in JavaScript. You'll cover many of
the hidden skills necessary to develop quality software and to work
collaboratively on a code base.

[ ] Linting: You can find and fix simple linting errors in JavaScript
programs.
[ ] Program Life Cycle: You can explain the two phases of a program's life
cycle.

Creation Phase
Execution Phase

[ ] Fixing Errors: You can use the structured comment to describe an error
in your program, and can make several educated guesses at how to fix the
error.
[ ] Fixing Bugs: You can use the structured comment to describe and fix a
bug in small programs.
[ ] Modifying Programs: You can make small changes in a program to change
its behavior without breaking it.
[ ] Refactoring: Given a working program, you can make changes to the code
without changing the program's behavior.
[ ] Writing Programs: Given a description of a program's behavior (user
story + test cases), you can plan goals for the program and write code to
pass the tests.
[ ] Reverse Engineering: Given a working program with unreadable code, you
can:
[ ] Give the program a name.
[ ] Describe the program's behavior with a user story, acceptance criteria and
test cases.
[ ] Plan goals for the program.
[ ] Develop your own working program with the exact same behavior.
[ ] Imagining Programs: Given an empty page, you can imagine and develop your
own programs using Just Enough JavaScript. This includes:
[ ] A title.
[ ] A description with a user story, acceptance criteria and test cases.
[ ] Commented goals.
[ ] Fully working Code.

Week-1
I Need Help With
I need more practice and more time
What went well?
I learnt basic logic of JS
What went less well?
I am still learning the Syntax and working mentality of JS
Lessons Learned
Basic Tools About JS
Sunday Prep Work
I will start after did more exercises of JS
Week-2
I Need Help With
TI tried to do the exercises of this week but I could not do them then I started to repeat old classes and lessons.
What went well?
I have studided by sololearn and some other sources. It was efficient to refresh some informations.
What went less well?
I could not understand the Debugger
Lessons Learned
Variables and values
Sunday Prep Work
I will start to study on Friday.

@alisanlii  what the problem with the debugger?
can you add your check-in for week 2

@alisanlii OMG, it is the most important tool in programming, it helps you to find bugs and fix them, that is why we called a debugger, it also allows you to go through your code line by line, so you can understand your code.


Custom Solution Request

Would you be interested in taking on a paid project to take this existing solution and having it incorporate the Distance Matrix API so it can use walking distance to calculate?

write me to<EMAIL_ADDRESS>and we can discuss it


[FEA] Update the function computeNumJoinRows in GpuHashJoin.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I wish the RAPIDS Accelerator for Apache Spark would [...]
https://github.com/NVIDIA/spark-rapids/blob/b8c4f364dfccb22ee39a6cf566449f9812493554/sql-plugin/src/main/scala/org/apache/spark/sql/rapids/execution/GpuHashJoin.scala#L262-L270
Describe the solution you'd like
We should solve the TODO as https://github.com/rapidsai/cudf/issues/9053 has been fixed.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context, code examples, or references to existing implementations about the feature request here.

cc @jlowe. Please take a look if you have time. Thank you.

This is a duplicate of #2440.  The fix is not as simple as we suspected, as we've tried twice unsuccessfully to use the join output size estimation.  It is possible to complete, but it requires updating the code to support batching either the left or right sides of the join.  Currently it only supports chunking one side, determined statically at query planning time.  It needs to be more dynamic.