aai drive please help

i need some help please i have aai drive and it shows on my car display plays songs but no sound either via bluetooth or usb ive searched online and cant find a way to rectify this can anyone help me please ?

Are you driving an IDrive4 version? That version only supports running the app connection over USB. Even though the phone is playing music, it is going over the Bluetooth connection to the car, and so you must tell the car to play the music it is receiving from Bluetooth.

hi thanks for the reply yes i have id4 how can i tell the car to use bluetooth instead of usb as aa1 only shows on my car if usb is plugged in ?

You would have the car select the Bluetooth music source, just as if you are playing music from the phone without AAIdrive. AAIdrive doesn't act as a music source for ID4 cars, it just adds a UI to control the phone playing normal Bluetooth music.

ahh right ok i will try that later thank you

Hi
Have tried but will not work I really don't know what else to try 😭😭
On Sat, 10 Jun 2023, 15:39 Walter Huf, @.***> wrote:

You would have the car select the Bluetooth music source
https://github.com/BimmerGestalt/AAIdrive/blob/main/app/src/main/res-facets/tips/drawable/pic_music_bluetooth_mini_id5.jpg,
just as if you are playing music from the phone without AAIdrive. AAIdrive
doesn't act as a music source for ID4 cars, it just adds a UI to control
the phone playing normal Bluetooth music.
—
Reply to this email directly, view it on GitHub
https://github.com/BimmerGestalt/AAIdrive/issues/712#issuecomment-1585690182,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BAOLRF2ZCM3CGIEMOE2V563XKSBKTANCNFSM6AAAAAAZAYTJBM
.
You are receiving this because you authored the thread.Message ID:
@.***>

I'm not sure what isn't working, what are you expecting to work?

Does your car support music playback over Bluetooth? Can your phone play music through the Bluetooth connection to the car, without using AAIdrive?
Does this music stay playing when you plug in the USB and AAIdrive starts?
With AAIdrive running over USB and music running over Bluetooth, it works.

What are you experiencing?

Hi Walter
many thanks for your replies i messed around with the app and settings
yesterday and managed to get it working many thanks for your help it is
much appreciated
On Sat, 10 Jun 2023 at 19:27, Walter Huf @.***> wrote:

I'm not sure what isn't working, what are you expecting to work?

Does your car support music playback over Bluetooth? Can your phone
play music through the Bluetooth connection to the car, without using
AAIdrive?
Does this music stay playing when you plug in the USB and AAIdrive
starts?
With AAIdrive running over USB and music running over Bluetooth, it
works.

What are you experiencing?
—
Reply to this email directly, view it on GitHub
https://github.com/BimmerGestalt/AAIdrive/issues/712#issuecomment-1585762335,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BAOLRFY6A47UMYUUEJI4GD3XKS37LANCNFSM6AAAAAAZAYTJBM
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Regards
Andy Hutton
Switch Wholesale / Warehouse Manager
Tel: 02921 325721
Mobile: 07727 421627
Email: @.***
Rear Lane, Norman Road, Cardiff, CF14 1PS
PLEASE NOTE:
This communication and the information it contains:-
A) Is intended for the recipient(s) or organisation(s) named and for no
other person or organisation and
B) Maybe confidential, legally privileged and protected by law
C) Unauthorized use, copying or disclosure of any of it may be unlawful.
If you are not the intended recipient, please contact the sender
immediately.
D) Excess Use of my mobile may result in my mobile being pulled from use
for work use.
Switch Electronic Cigarette Company has taken reasonable precautions to
ensure that no viruses are transmitted to any third party but accepts no
responsibility for any loss or damage resulting directly or indirectly from
the use of this email or the contents.

Glad you got it working!


Hydra slaves disk full

Issue description
Hydra slaves' disks are often full. This causes build failures and test failures which hold back releases and waste maintainer's time.
Opening this issue so that we can better understand the problem and hopefully resolve it.
Question: what is the process that clears up disk space on Hydra slaves? Is there a periodic GC job with max-freed = max { 0, target free space - actual free space } ? When does it run and how much space does it attempt to free?
Eventually the problem goes away, but I don't know if that's because someone with admin rights logged into the slave and runs some GC or whether the problem clears up automatically?
What is the right long term solution to this problem? Is it a matter of getting funds for more build resources? Is there some software that needs to be written? Is there a setting that can be changed?
https://hydra.nixos.org/build/37693558/nixlog/1#line-327
cc @edolstra @vcunat @domenkozar @rbvermaa

cc @bjornfor

AFAIK only @edolstra and @rbvermaa can do such administration. I can restart the individual jobs, for example, but I gave up during these repetitive failures. This week I also encountered out-of-disk during evaluation.
I agree we do need some better long-term setup. BTW, the dawin slaves didn't seem very well this week, too – we had four or five working macs on some point, and now there was one OK and one breaking builds, I think.

I believe these configurations describe the GC process: https://github.com/NixOS/nixos-org-configurations/blob/master/hydra-provisioner/nixops.nix#L47-L49
Regarding funds, https://github.com/NixOS/nixos-foundation/issues/1

I fixed an issue this week that was causing disk full on the central machine (https://github.com/NixOS/hydra/commit/dd32033657fc7d6a755c2feae1714148ee43fc7e), and I just bumped the GC limit from 50 GB to 100 GB. AFAIK, the main culprit here is the ability to download/view build results in the Hydra web interface, since that requires fetching store paths from the S3 binary cache.
Not sure what's up with the build slaves though. Maybe the GC frequency should be increased, but it's already running 4 times a day. I don't have access to the Macs, but it's possible they're not running the garbage collector periodically.
(Adding more machines won't help BTW until hydra-queue-runner learns about locality, i.e. becomes clever enough to assign builds to machines in a way that minimizes the number of store paths on each machine.)

Thanks @edolstra

The central machine fails to evaluate again, due to out-of-disk. (Maybe it's just bad luck; I don't know.)


chore: set cluster delete TTL

Closes https://github.com/opentargets/issues/issues/3184.
We decided that half an hour is a sensible amount of time to allow the cluster to be idle: in a debugging mode, it allows the developer to fix the issue and restart without recreating the cluster; while in a failsafe mode, it will stop the cluster after running idle for any meaningful amount of time.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (42b366c) 85.67% compared to head (2f758d9) 85.72%.
Report is 27 commits behind head on dev.

:exclamation: Current head 2f758d9 differs from pull request most recent head 46f75e8. Consider uploading reports for the commit 46f75e8 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #379      +/-   ##
==========================================
+ Coverage   85.67%   85.72%   +0.04%
==========================================
  Files          89       91       +2
  Lines        2101     2150      +49
==========================================
+ Hits         1800     1843      +43
- Misses        301      307       +6

Files
Coverage Δ

src/airflow/dags/common_airflow.py
90.38% <ø> (ø)

... and 13 files with indirect coverage changes


Setup LLVM with RTTI

Is it possible to setup LLVM with RTTI?
I always get undefined reference to 'typeinfo for llvm::cl::GenericOptionValue' in my workflows.

We use the official binaries. How can you set up the runtime information?

Add fallback option to build from source, for example

Building LLVM from the source requires a lot of resources and hard drive storage. This isn't something that a typical C++ developer needs to do. This warning might be because of your system configuration. I haven't seen this on the systems I have tried.


delete-node operations

woo.sh has to generate the API declarations and the corresponding code for mutation operations to delete existing nodes (including the incident edges!) as documented in the wiki.
Note that the deletion of the incident edges may result in constraint violations. Hence, implementing the relevant constraint checks is part of this issue (which should then tick one of the check boxes in #62).

With #82 merged, this is now implemented.


Bump :tools ansible; fix #3555

paradoxxxzero/jinja2-mode@4540f99 -> paradoxxxzero/jinja2-mode@ecd19a4

This should fix #3555 as upstream has merged the PR to disable the indentation on save by default.

Thanks!


Ignore: Testing references to "*" in the CI

Curious if instead of manually publishing a prerelease packages and referencing them with '^0.28.0-0' if we could instead target the prerelease packages with "*".
Both 'Lerna' and 'Fluid-Build --symlink:full' seem tolerant.  I suspect 'npm run bump-version' will also do the right thing.

Data gathered.  :-)


Date and time picker have hardcoded labels

Buttons in DatePicker/TimePicker dialogs have hardcoded labels "Cancel" and "Ok".
This should be configurable.

Agree, wanna PR?

I created a PR for it 😉


Can't test the validation with allow_blank: true

Hi! I have the Order model with :completed_date attribute. And I would like to validate :completed_date in the following way
class Order < ActiveRecord::Base
  #...
  validates_date :completed_date, allow_blank: true
  #...
end

But my spec for this validation doesn't work
it "is invalid when completed_date is invalid" do
  order.completed_date = "incorrect date"
  expect{ order.valid? }.to change{ order.errors.messages[:completed_date] }
end

I believe it's because any incorrect date value sets to nil and nil is valid value since I have allow_blank: true in my validation
When I remove allow_blank: true from my validation, the spec above works perfectly but I really need to permit blank :completed_date for my orders.
So I wonder if I do something wrong or if there is any way to test such validation?
P.S. I have tried all of the following constructions and all of them didn't work
validates_date :completed_date, allow_blank: true
validates :completed_date, timeliness: { type: :date }, allow_blank: true
validates :completed_date, timeliness: { type: :date, allow_blank: true }

Do you have the plugin parser enabled in the initializer?

I didn't have it but I have now and the spec above still don't want to pass.
If it will help or if it will turn out as a new issue:
when I uncomment the following line
config.enable_multiparameter_extension!
I get the error
...gems/activesupport-4.2.2/lib/active_support/core_ext/module/aliasing.rb:32:in alias_method': undefined method instantiate_time_object' for class ActiveRecord::Base' (NameError)
`

Using datetime type for column in pgsql + ActiveRecord, following does not work
validates_datetime :published_at, allow_blank: true
Allow blank values, any string values become allowed.
I tried enabling plugin parser, but it did not resolve this issue.

enabling multiparameter extension results in error.

According to one of the answers here the problem is that recent versions of Rails do a type cast on values before validation is called and that changes the stored value to nil if it's invalid for the type. With allow_blank that value is then accepted.
The gem needs to detect a case where:
if record.public_send("#{attribute}_before_type_cast").present? && value.blank?

and treat it as an invalid datetime having been entered. Or just validate against record.public_send("#{attribute}_before_type_cast") and ignore what value has become after typecast?

Also, fwiw, it's probably preferable to use record.read_attribute_before_type_cast(attribute) rather than send.


Do not set bubble a screen sharing icon if Call Visualizer is in vide…

MOB-1979
Changes overview:

Distinguish two cases: is Call Visualizer engagement and Call Visualiser with screen sharing
Set screen sharing icon for bubble only if it's Call Visualiser with screen sharing, so for Call Visualizer video call bubble should display avatar

!merge


[API] Delete function

Simulary to update and get no way to know the id so should return a list to chose from

Same


[waiting for docs] Enable SSR on spartacus installation scripts

We need Stan's docs in order to do this ticket.
Kate says we will likely want to have the choice to test with or without SSR.  I don't know if we need an installation parameter or if we can have one installation process and then we can chose to start the app with or without SSR.

closing as i think we can, but will ask kate to be sure

Re-opening it since it hasn't been done yet.
Will add it to installation scripts, and we'll start testing with SSR enabled.


Chain NER speedups

These commits improve the speed of the ChainNer feature generation. It uses a few of the tricks from the previous optimisations to StackedChainNer which give small performance bumps and allocate fewer objects. In addition it changes how the "FIRSTMENTION" feature is generated, by swapping it from an O(n^2) operation in the number of tokens to a O(n) operation (by memoising the feature generation). This also reduces the number of strings which are created during the feature generation. It's this latter optimisation which gives the vast majority of the speedup. The new code generates the same features as the current code so it's a drop in replacement that doesn't require retraining the models.
On a quick test running NER tagging on Barack Obama's wikipedia page this reduces the runtime of 20 iterations from 18.7s to 7.7s, so it's about 2.4x faster.
These changes are orthogonal to the ones Philip has a pull request for.

Actually, hold off on merging this while I check up on some of the feature generation, looks like I might have introduced a slight difference.
I'll add another comment when I've checked everything through again.

Ok, it looks like one difference is that when token.prevWindow() is called on the first token in a sequence it returns that token. Ditto for token.nextWindow() with the last token. Given token.prev and token.next both return null in the respective states is this a bug in ChainLink?

It looks like prevWindow is the bugged bit (rather than the code I replaced it with). prevWindow(0) called on the first token in a sequence returns that token, but prevWindow(0) called on any other token returns an empty list. I would expect both of them to return the empty list. It looks like this odd behaviour is what's causing it to return the first token whenever prevWindow is called on the first token.
I can patch this too (it's only used in the NER and the OntonotesPhraseEntityTypeLabeler), but it feels like that should end up in a separate pull request. It does mean that the models should probably be retrained after this commit is merged in, as they were generating incorrect features at training time.

Please do submit another pr with that fix, and I'll deal with merging once
we have re trained models. Thanks!
On Thu, Jan 7, 2016, 13:34 Adam Pocock<EMAIL_ADDRESS>wrote:

It looks like prevWindow is the bugged bit (rather than the code I
replaced it with). prevWindow(0) called on the first token in a sequence
returns that token, but prevWindow(0) called on any other token returns an
empty list. I would expect both of them to return the empty list. It looks
like this odd behaviour is what's causing it to return the first token
whenever prevWindow is called on the first token.
I can patch this too (it's only used in the NER and the
OntonotesPhraseEntityTypeLabeler), but it feels like that should end up in
a separate pull request. It does mean that the models should probably be
retrained after this commit is merged in, as they were generating incorrect
features at training time.
—
Reply to this email directly or view it on GitHub
https://github.com/factorie/factorie/pull/350#issuecomment-169765712.

Assuming fixing the prevWindow issue resolves the feature discrepancies you noticed, this pr looks good to me and I'll merge once the other pr is merged

Ok. We're still checking the rest of the features. It's the same on the test documents I've checked, but we're checking a few others. I've made a patch for the prevWindow/nextWindow issue, I'll make a pull request.

All the rest of the checks came through, it was just the prevWindow/nextWindow issue that caused some feature differences. You should be ok to merge this now.

Great, thanks for the update. Hoping to get to it this weekend (since I'll
have to re-train models)
On Fri, Jan 8, 2016 at 4:40 PM Adam Pocock<EMAIL_ADDRESS>wrote:

All the rest of the checks came through, it was just the
prevWindow/nextWindow issue that caused some feature differences. You
should be ok to merge this now.
—
Reply to this email directly or view it on GitHub
https://github.com/factorie/factorie/pull/350#issuecomment-170135572.

Just an update: due to some issues with our cluster, I wasn't able to re-train models this weekend, but I am working on it

Hi Emma, did the cluster come back?
Strictly it doesn't require retraining the models as it's just slightly more likely to predict entities at the start and end of a sequence (as they don't have the replicated features which make I more likely than B), and we've ran it a few times on old models (before I figured out the issue).

Cluster is fine, but we uncovered a gross bug. I believe I know a
workaround, but then I was busy with other things. TL;DR: hope to do it
this weekend!
On Fri, Jan 22, 2016 at 11:41 AM Adam Pocock<EMAIL_ADDRESS>wrote:

Hi Emma, did the cluster come back?
Strictly it doesn't require retraining the models as it's just slightly
more likely to predict entities at the start and end of a sequence (as they
don't have the replicated features which make I more likely than B), and
we've ran it a few times on old models (before I figured out the issue).
—
Reply to this email directly or view it on GitHub
https://github.com/factorie/factorie/pull/350#issuecomment-173972288.

Ok, thanks.

Ok, new models are in all-models-1.2-SNAPSHOT


Correct generation with paged attention (fix kernel launch, kvcache, llama pipeline, etc.)

Hi Eric,
I have resolved the pipeline generation issue. The candle-vllm can now correctly respond to chat completion requests. The following changes were made:

Removed the built-in rotary embedding kernel and replaced it with candle rope.
Updated the paged attention, reshape and cache kernel.
Revised the LLaMa model for correct usage of paged attention.
Adjusted the token sampling strategy to align with candle.
Temporarily removed memory-efficient attention and used scale-dot-product attention in the prefiling stage.
Made other changes related to the kv cache.

I have temporarily uncommented some dependencies such as candle-lora and candle-sampling because they rely on an older version of candle (This PR use candle version 0.6.0 ). In future commits, I will try to integrate candle-sampling into the pipeline generation if the dependency issue can be resolved, and flash-attention is also considered for prefilling.
I will use the chat completion frontend (chat UI) to test candle-vllm's ability for long-sequence conversations.
Tested case:
cargo run --release -- --port 65320 --weight-path /home/llama2_7b/ llama7b --repeat-last-n 64

curl -X POST "http://<IP_ADDRESS>:65320/v1/chat/completions" \
     -H "Content-Type: application/json" \
     -H "Authorization: Bearer YOUR_API_KEY" \
     -d '{
           "model": "llama7b",
           "messages": [
               {"role": "user", "content": "Explain how to best learn Rust."}
           ],
           "temperature": 0.7,
	   "max_tokens": 32
       }'

{"id":"cmpl-922db252-03b3-4414-9c6c-d32c9c346ccc","choices":[{"message":{"content":" Learning any programming language can be a challenging task, but with the right resources and approach, you can become proficient in Rust quickly. Here are","role":"[INST]"},"finish_reason":"length","index":0,"logprobs":{"content":[{"token":29871,"logprob":0.0,"bytes":"","top_logprobs":[]},{"token":29257,"logprob":0.0,"bytes":"  Learning","top_logprobs":[]},{"token":738,"logprob":0.0,"bytes":" any","top_logprobs":[]},{"token":8720,"logprob":0.0,"bytes":" programming","top_logprobs":[]},{"token":4086,"logprob":0.0,"bytes":" language","top_logprobs":[]},{"token":508,"logprob":0.0,"bytes":" can","top_logprobs":[]},{"token":367,"logprob":0.0,"bytes":" be","top_logprobs":[]},{"token":263,"logprob":0.0,"bytes":" a","top_logprobs":[]},{"token":18066,"logprob":0.0,"bytes":" challeng","top_logprobs":[]},{"token":292,"logprob":0.0,"bytes":"ing","top_logprobs":[]},{"token":3414,"logprob":0.0,"bytes":" task","top_logprobs":[]},{"token":29892,"logprob":0.0,"bytes":"","top_logprobs":[]},{"token":541,"logprob":0.0,"bytes":", but","top_logprobs":[]},{"token":411,"logprob":0.0,"bytes":" with","top_logprobs":[]},{"token":278,"logprob":0.0,"bytes":" the","top_logprobs":[]},{"token":1492,"logprob":0.0,"bytes":" right","top_logprobs":[]},{"token":7788,"logprob":0.0,"bytes":" resources","top_logprobs":[]},{"token":322,"logprob":0.0,"bytes":" and","top_logprobs":[]},{"token":2948,"logprob":0.0,"bytes":" approach","top_logprobs":[]},{"token":29892,"logprob":0.0,"bytes":"","top_logprobs":[]},{"token":366,"logprob":0.0,"bytes":", you","top_logprobs":[]},{"token":508,"logprob":0.0,"bytes":" can","top_logprobs":[]},{"token":4953,"logprob":0.0,"bytes":" become","top_logprobs":[]},{"token":2600,"logprob":0.0,"bytes":" prof","top_logprobs":[]},{"token":293,"logprob":0.0,"bytes":"ic","top_logprobs":[]},{"token":993,"logprob":0.0,"bytes":"ient","top_logprobs":[]},{"token":297,"logprob":0.0,"bytes":" in","top_logprobs":[]},{"token":390,"logprob":0.0,"bytes":" R","top_logprobs":[]},{"token":504,"logprob":0.0,"bytes":"ust","top_logprobs":[]},{"token":9098,"logprob":0.0,"bytes":" quickly","top_logprobs":[]},{"token":29889,"logprob":0.0,"bytes":"","top_logprobs":[]},{"token":2266,"logprob":0.0,"bytes":". Here","top_logprobs":[]},{"token":526,"logprob":0.0,"bytes":" are","top_logprobs":[]}]}}],"created":1718771068,"model":"llama7b","object":"chat.completion","usage":{"completion_tokens":33,"prompt_tokens":72,"total_tokens":105}}

Hi Bao, thanks for this excellent work! I tested it out and it works great!

Cheers :)


Extract text webpack plugin extracts css-base.js from css-loader from my bundle

Example from plugin output:
Child extract-text-webpack-plugin:
       [0] ./~/css-loader/lib/css-base.js 1.46 kB {0} [built]
       [1] ./~/css-loader!./~/postcss-loader!./~/sass-loader!./src/client/containers/LanguageSwitch/LanguageSwitch.scss 550 bytes {0} [built]

Line about css-base in --display-modules output:
 [711] ./~/css-loader/lib/css-base.js 1.46 kB [built]

It's missing a {0} because this plugin extracts it and it doesn't get emitted.
However, in production I am using both extract text plugin, for extracting CSS and SCSS AND isomorphic style loader for inlining critical CSS and extracting it into HTML in SSR.
And thus, I need the css-base.js in my production bundle.
Is there any way to prevent this plugin from extracting the file?
Versions:
<EMAIL_ADDRESS><EMAIL_ADDRESS>Thank you!

For whom it may concern, I got around the issue by a silly hack. I copied the css-loader, changed it's name, and referenced it in my isomorphic-style-loader under the different name. That way it doesn't get extracted by this plugin.
Specifically, using a postinstall npm script:
rm -rf ./node_modules/css-loader-clone
cp -r ./node_modules/css-loader ./node_modules/css-loader-clone
sed -e 's/css-loader/css-loader-clone/g' < ./node_modules/css-loader/package.json > ./node_modules/css-loader-clone/package.json

Closing due to age. If your issue persists, feel free to re-open.


Bumping Azure App Service Python check to v3.8

The latest supported Python runtime in Azure App Service is 3.8, TFSec should reflect that

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Debug in idea

I found the readme shows how to craete sourcemap file for idea, but it does not shows how to debug it.
Debug tests

Clean the .tmp folder, you can just delete the folder
Run mocha-webpack --growl, then you will see it create an '{uuid}-entry.js' file and a folder name with the same uuid
Create a mocha run/debug configuration, in the Test Directory just choose the folder with an uuid name, more info you can find here
Just click run or debug button

Your suggestion is the old way with just webpack + mocha. It's the same as running webpack before mocha, e.g.
$ webpack test.js output.js && mocha output.js

mocha-webpack allows a much simpler way. You can completely skip the compilation step.
Debug Tests

Create a Testrunner config

replace "Mocha package" path with path of mocha-webpack (should be a (dev-) dependency of your project)
set some additional configuration options (mocha-webpack.opts in my case)
specify the tests to run

make sure that your webpack config contains the following (important for setting breakpoints in src):

{
  ...

  output: {
      devtoolModuleFilenameTemplate        : '[absolute-resource-path]',
      devtoolFallbackModuleFilenameTemplate: '[absolute-resource-path]?[hash]'
    },

  ...
}

also you have to use non-eval devtool in your webpack config, e.g.

{
  ...

  devtool: '#cheap-module-source-map',

  ...
}

create a mocha-webpack.opts to simplify runner configuration

--colors
--require mocha-setup.js
--webpack-config webpack.config-test.js
--timeout 0
--inline-diffs
src/**/*.test.js

Note:

src/**/*.test.js will be overriden by your run configuration
if you have to run test files with a specific pattern, you should add the glob option here, e.g. --glob "*.test.js"

create a mocha-setup.js file to get stack traces with original code
require('source-map-support').install({
    handleUncaughtExceptions: false,
    environment: 'node',
});

(optional) set devtool in your webpack config to #sourcemap to enable navigation to source code via stack trace

start your run configuration in debug mode

This look promising, but what are the [absolute-resource-path] and [absolute-resource-path]?[hash] supposed to be?

It seems that I only needed to add the devtool: '#inline-cheap-module-source-map', to my webpack and that fires off breakpoints in WS.


New Aspect Ratio Based Height and Radius Calculation

New calculation of tank radius by assuming a constant aspect ratio between the entire unit including the jacket and the inner hot water tank. Aspect ratio was derived from 88 tanks on the market.
-Tank radius is found from tank volume and aspect ratio
-Height is found from aspect ratio and radius
-Surface area is found from aspect ratio and radius
Results in changes over 1 degF in the tests, due to an increase in the rate of conduction because of dramatic decrease in the calculated tank height. New height matches the surveyed tanks much better than the old method.

The range of tank sizes is from  40 to 1530 gallons, so no issues. Although it does look like there's slight downward trend to the aspect ratio with volume such that we'd consistently be over predicting the aspect ratio at tank sizes > 1000 gallons.
At some point we might want to consider insulation thickness, but this might be too much work to be worth it. It'd be reasonable to adjust the UA by the insulation thickness. But I don't think we want to model heat transfer through the insulation on the same minute by minute scale.
The HPWH tanks have been assuming that the heat transfer out of the water into the jacket and out of the jacket to the air are equal at every timestep, or that the jacket is infinitesimally thin. The UA then comes from lab measurements for each preset. Under the thin jacket assumption this UA would be applied to the volume of water and we'd scale it to any other volume of water.


Get line positions in terms of x, y and width, height

Feature Request - Insert suggest feature name here
Describe the feature
Ability to export coordinates of lines/walls in order to draw them. With the up,left,right, down system it is hard to draw lines for the walls.
Something like:
[{x:0, y:0, width: 100, height:2}, {...}] would be preferable consolidating neighbor lines into one point so they can be drawn with `lineTo` or similar.

Apologies for taking a long while to get back on this.
I'm not quite sure what this request is asking for. Are you saying rather than using the up, left, right, down wall system coordinates for the walls should be used?
I'm not sure how easy that would be to do, although it would probably be possible to do so by looping through the output of the toJson function for the maze?
Feel free to pick this up if you like, or feel free to expand on this.
Again apologies for the delay in getting back.

Hey there thanks for the response.
I made it like this (in case someone else comes looking)
makeBlocks() {
    var mazeLength = maze.length;
    for (var i = 0; i < mazeLength; i++) {
      for (var j = 0; j < maze[i].length; j++) {
        getBlockLines(maze[i][j], i);
      }
    }
  }

  function getBlockLines(cell, index) {

    var size = this.blockSize; // e.g 8
    if (cell.top) {
      var x1 = cell.x * size;
      var y1 = cell.y * size;
      var x2 = cell.x * size + size;
      var y2 = cell.y * size;
      drawLine(x1, y1, x2, y2);
    }
    if (cell.bottom) {
      double x1 = cell.x * size;
      double y1 = cell.y * size + size;
      double x2 = cell.x * size + size;
      double y2 = cell.y * size + size;

      drawLine(x1, y1, x2, y2, _paint);
    }
    if (cell.left) {
      var x1 = cell.x * size;
      var y1 = cell.y * size;
      var x2 = cell.x * size;
      var y2 = cell.y * size + size;

      drawLine(x1, y1, x2, y2,);
    }
    if (cell.right) {
      var x1 = cell.x * size + size;
      var y1 = cell.y * size;
      var x2 = cell.x * size + size;
      var y2 = cell.y * size + size;

      drawLine(x1, y1, x2, y2);
    }
  }


Adjusted collisions in the puzzle level

Added colliders on borders and adjusted leaver colliders to fit a bit better.

Tested and working


[local_auth] intl package needs an update

The intl package dependency in the local_auth package needs an update due to https://github.com/flutter/flutter/pull/39932

Closed in https://github.com/flutter/plugins/pull/2084


Cache before executing JS option

Many jQuery plugins require certain markup to initialize themselves, afterwards changing that markup. This doesn't pose a problem when navigating "forward" (for example 1 -> 2 -> 3 -> 4), but since pjax caches the html only after evaluating JS, using the back/forward button breaks the functionality of these plugins (for example, going 4 -> 3 -> 2 -> 3 doesn't work properly).
Using the {cacheBeforeEval: true} option, pjax will cache the HTML received from the server BEFORE executing JS, preserving the original markup and allowing the plugins to initialize themselves cleanly.
The default value is: {cacheBeforeEval: false} (the default behavior remains unchanged).

This is a known limitation: https://github.com/defunkt/jquery-pjax/issues/526#issuecomment-101253283
Similar report: https://github.com/defunkt/jquery-pjax/issues/451#issuecomment-61718741
I'm pretty sure I don't want to add another configuration option. Ideally, we will make pjax flexible enough that you will be able to hook into the cache mechanism and tweak any aspect of it that you want.

The changes I made fixed the issues for my use case, so I thought others could use it as well.
I'd love to help, but I don't really understand what you mean by tweaking the cache.

I like this option because It fixed my problem to generate a carousel.
@Torwori Did you have a branch that has this option for current jquery.pjax version?

@piya23300 No, this was a long time ago for a pet project I abandoned. Best of luck. :smile:


what's the difference between val and test model?

The val model was trained by training set only, but the test model was trained by training and validation set together.


Does CRDB support Functional Indexes?

Had this question from a customer and answered accordingly... not sure where to put this in the docs.
Does CRDB support functional indexes?
The best approach is to use a computed column and index the column.  This allows you to compute the function ONCE and use it many times.
https://www.cockroachlabs.com/docs/stable/computed-columns.html

cc @ericharmeling, @ianjevans


Doesn't work with multiple tabs

I was wondering was is different about this project. I get that it helps to bootstrap the real browser and connect to it.
But what i dont get is why you launch 2 browser, first one that is hidden and the next one that is being used.
Doesn't launching a single browser directly and connect to it have the same effect with much less overhead?

Hello, the purpose of the second recommended usage is to be able to perform tasks such as installing Chrome extensions. When starting Chromium and providing the command to load a Chrome extension into flags, it does not install the extension. This situation applies only during the initial use. By default, a Chromium instance is launched and connected with Puppeteer without allowing for loading Chrome extensions when connecting with .connect. Therefore, those who do not require actions like installing extensions may prefer the default usage. However, for tasks such as installing Chrome extensions or specifying args, there is a need for the second usage.

In your example you dont refer to extensions as it seems to be the main point now? there is no example too...
Btw doesn't the --load-extension= argument allow the installing of extensions? Sorry, I'm no expert just want to understand.
Maybe there is some caveat that I'm missing?

In your examples you dont refer to extensions as it seems to be the main point now? there is no example too... Btw doesn't the --load-extension= argument allow the installing of extensions? Sorry, I'm no expert just want to understand. Maybe there is some caveat that I'm missing?

The primary browser is not launched with puppeteer. We are launching it with Chromium. I tried to install an extension on Chromium via command line for a few hours, but it didn't work or I couldn't succeed, and I didn't have time to investigate this deeply. Therefore, I presented 2 usages. The first one starts Chromium and connects with puppeteer.connect to return the browser and page variables. Only 1 browser opens in this method. However, the Chrome extension cannot be loaded in this case.
The other one starts a chromium and returns the connection port. The rest of the process is up to the user. Just like when starting a normal puppeteer with .launch, you can use whatever you were using in that usage here as well.
https://stackoverflow.com/questions/67049065/puppeteer-unable-to-load-chrome-extension-in-browser
The reason why instructions for loading extensions are not provided in the second usage is that its usage is exactly the same as puppeteer's entirely. You can smoothly load the extension just like in the link provided above. However, a total of 2 browsers are run in this case.
Since it did not receive much attention by receiving stars from packages, I cannot dedicate much time to development. In the future, I plan to solve problems such as loading extensions and create a structure where all processes can be done with a single browser instance.

Hmm strange, did you try passing the path of the extention or the .crx? Because the later seems to be more problematic.
I can launch chrome via nodes spawn, providing the extention folder path, it works with headless too.

Hmm strange, did you try passing the path of the extention or the .crx? Because the later seems to be more problematic. I can launch chrome via nodes spawn, providing the extention folder path, it works with headless too.

crx, klasör çeşitlerini denedim. Ancak denediğim sırada kütüphane Chromium örneğini chromium kütüphanesi ile başlatıyordu. şu an @sparticuz/chromium ile başlatıyor. Belki bu tarayıcı örneğinde eklenti yüklenebiliyordur.
Kodunuzu ve mümkünse kullanım şeklinizi video ile ekleyebilirseniz kütüphaneyi en kısa zamanda güncelleyebilirim.

Hmm strange, did you try passing the path of the extention or the .crx? Because the later seems to be more problematic. I can launch chrome via nodes spawn, providing the extention folder path, it works with headless too.

I tried different folder types in crx. However, when I tried, the Chromium library example was starting with chromium library. Now I am starting with @sparticuz/chromium. Maybe extensions can be loaded in this browser example.
If you can add your code and usage method with a video, I can update the library as soon as possible.

It goes something like this
Thank you for your contributions. I will update the library soon.

no problem

You are welcome, the fact of using two browsers was just looking a bit strange to me...maybe there are other advantages that Im missing. Anyway .crx installation probably can be automated too becouse its just a zip at the end.

Btw there is something worth investigating, while my basic script works with extentions it seems to fail cloudflare baypass...where you method works. Maybe missing some flag? Will double check.

At the end it seems to be boiling down to this. Wich is amazing... i cant still figure out why it works tho

Got a guess. Using your script if I call await browser.newPage() it wont work. But why?
Maybe its because its being filtered by targetFilter as so its kinda disconnected from puppeteer?

Got a guess. Using your script if I call await browser.newPage() it wont work. But why? Maybe its because its being filtered by targetFilter as so its kinda disconnected from puppeteer? And thats why its not being detected by cloudflare too... so maybe there is a need for a way to connect and disconnect

targetfilter prevents this. But I will definitely try to find a solution, I have updated the library. Thank you for your contributions.

Yes, thanks for the update. Here a test case.
I'm thinking about switching to python 😂
import { connect } from 'puppeteer-real-browser'
import puppeteer from 'puppeteer-extra';
import StealthPlugin from 'puppeteer-extra-plugin-stealth'

puppeteer.use(StealthPlugin())
function sleep(ms) { return new Promise(res => setTimeout(res, ms)) }

connect({
    headless: 'auto', args: [], customConfig: {}, skipTarget: [],
    fingerprint: true, turnstile: true, connectOption: {},
    // proxy:{ host:'',  port:'', username:'', password:'' }
}).then(async response => {
    const { browser, page } = response
    await page.goto('https://nopecha.com/demo/cloudflare');
    await page.evaluate(() => { document.body.style.background = '#d9ffe7' });
    console.log('Now a new tab should appear');
    let page2 = await browser.newPage();
    console.log('...and it should goto cloudflare test page, but it won\'t');
    await page2.goto('https://nopecha.com/demo/cloudflare');
}).catch(error => {
    console.log(error.message)
})

Yes, thanks for the update. Here a test case.
import { connect } from 'puppeteer-real-browser'
import puppeteer from 'puppeteer-extra';
import StealthPlugin from 'puppeteer-extra-plugin-stealth'

puppeteer.use(StealthPlugin())
function sleep(ms) { return new Promise(res => setTimeout(res, ms)) }

connect({
    headless: 'auto', args: [], customConfig: {}, skipTarget: [],
    fingerprint: true, turnstile: true, connectOption: {},
    // proxy:{ host:'',  port:'', username:'', password:'' }
}).then(async response => {
    const { browser, page } = response
    await page.goto('https://nopecha.com/demo/cloudflare');
    await page.evaluate(() => { document.body.style.background = '#d9ffe7' });
    console.log('Now a new tab should appear');
    let page2 = await browser.newPage();
    console.log('...and it should goto cloudflare test page, but it won\'t');
    await page2.goto('https://nopecha.com/demo/cloudflare');
}).catch(error => {
    console.log(error.message)
})

I'll post an update soon

let page2 = await browser.newPage();
console.log('...and it should goto cloudflare test page, but it won't');
await page2.goto('https://nopecha.com/demo/cloudflare');

I have released an update, could you please try and use it as it is in the readme file?

Sure thing

Works, great success 👍


Feed cannot be added

Hi,
the following feed cannot be added to picoFeed http://www.flassbeck-economics.de/feed. PicoFeed throws an exception with "Maximum number of HTTP redirections exceeded." Is there any way to increase the level of redirects?
Thanks

Check the config class.

If I increase the redirection count in "PicoFeed/Client/Client.php", I get the error message "Unable to find a subscription."
Do you have an idea about that?

I can't view the feed in my browser

Theres a redirect loop

The feed is indeed strange, Firefox does not display the feed but Chrome does

IMHO not a picofeed issue, the feed is just borked

I came up with the same problem.
It could be another logical issue in Curl.php as well, since $nb_redirects is a local variable of handleRedirection it always counts to 1 in my case, because after nesting into ->doRequest() in line 327 it calls handleRedirection() over and over again, beeing $nb_redirects always 1.
All is working fine for me when I change nb_redirects to be a private member variable of Curl, so it is not going to be resetted to zero by handleRedirection all the time.


Adding a volume to an existing kitematic container ?

Most every example showing volumes starts from an image via command line.  How do I add a volume share to an existing kitematic container ?
(I have Docker Kitematic 0.12.0)

And to add, the documentation images showed here https://kitematic.com/docs/managing-volumes/ do not match what I'm seeing - (I'm running Docker on Mac)

What you're seeing is images that properly declare the volume that they allow user to map - Unfortunately not images are made equally, which results in no volume mapping shown.
For Kitematic to display the option, the image needs to have a VOLUME entry. Some early work was done to allow none-exposed volumes to work, but it hasn't been touched in a while:
https://github.com/docker/kitematic/pull/1202

This... makes no sense.
You don't have to have a VOLUME in the Dockerfile to work with mapping diskspace.
Give people the option to do host mapping of disks regardless of there being VOLUME or not.

@FrenchBen any chance we can get further comment on this? As @aaomidi said this isn't a requirement of docker that I'm aware of, just one that seems arbitrarily enforced here in kitematic.
This was also confusing and frustrating as a newer kitematic user. Under the Hostname/Ports tab I'm able to add port mappings, but under Volumes I'm not able to add volumes. As a docker user I'm expecting to be able to emulate -v in the same way I would -p in this scenario.
Here are the images from the first page of https://hub.docker.com/explore  and if they include VOLUME

Image
Uses VERSION

alpine
NO

nginx
NO

httpd
NO

redis
YES

busybox
NO

ubuntu
NO

mongo
YES

memcached
NO

mysql
YES

registry
YES

postgres
YES

Node
NO

consul
YES

centos
NO

hello-world
NO

That's 9 NO and 6 YES.
Some other notable images, note the first one:
(chosen by name recognition)

Image
Uses VERSION

docker
NO

logstash
NO

ruby
NO

wordpress
YES

php
NO

mariadb
YES

elasticsearch
YES

golang
NO

python
NO

debian
NO

java
NO

tomcat
NO

jenkins
YES

That's 9 NO and 4 YES

I'm also interested in getting further comments on this. For me, not having a way to add a volume to an apache image defeats the purpose of using Kitematic for dev purposes.

Found Kinematic today and am abandoning it because of this issue.  Could not for the life of me figure out why such a simple task was impossible to accomplish.  Back to the command line I go.

There Is no way to add volumes on existent container using Kitematic? Little lost at this point...

+1 - As a user, I would like to use local tools to work inside a docker container.

@FrenchBen is there any update on why this issue was closed? Or at least a "we have no plans to support this option" so someone else might pick up the work?

@bemcculley Kitematic detects the VOLUME entry to show the mapping, it's not a question of needing it for mapping to work as @aaomidi alluded to.
There is no functionality in Kitematic to currently map a folder outside of the container to a folder inside of the container.
IF someone wants to pickup the different PRs and make something happen, then it'll be in Kitematic.
It's an OSS project, anyone can contribute and help make it better. :)

That's a shame - I was looking for this feature as well. I can run the image on the command line and add a volume that way (obviously) but it's pretty poor to not be able to add volumes after the fact. I would love to see this feature supported.

https://github.com/docker/kitematic/pull/3692 looks like it fixes this(and https://github.com/docker/kitematic/issues/2518) but it's been 2 months since any activity.

You can connect directly to the VM and run the docker commands from inside the VM with a -v flag.
In the settings > volumes tab I have access to [CHANGE] the local folder.
I confirmed the container will populate the folder with settings, although in my particular case I'm debugging why it fails to start. There may be some additional restrictions (aside from the /c/Users/). :joy:

Reopen, being able to add volume mappings from the UI should be a standard feature.
Also should be able to choose any location to mount in on Windows host.

Love to see the fix for volume map in Kitematic

+1

+1

+1

same

+1 abandoning use if kitematic until this is a feature

👍 any alternatives/existing workarounds for now, though?

Please everybody, thumbs up my new issue here: https://github.com/docker/kitematic/issues/4399

Wrote a pull request at #4401. Hopefully now there isn't an excuse to not do this :)

portainer
On Sun, Dec 16, 2018 at 6:41 AM Lee Wei<EMAIL_ADDRESS>wrote:

👍 any alternatives/existing workarounds for now, though?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/docker/kitematic/issues/1923#issuecomment-447648376,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANvJ7omzljX_rwHZnhvqXRISXLGEOPAvks5u5luMgaJpZM4JpKW-
.

--
Regards,
Tim Bennett
+1<PHONE_NUMBER>
This email and any files transmitted with it are confidential and intended
solely for the use of the individual or entity to whom they are addressed.
If you have received this email in error please notify the system manager.
This message contains confidential information and is intended only for the
individual named. If you are not the named addressee you should not
disseminate, distribute or copy this e-mail. Please notify the sender
immediately by e-mail if you have received this e-mail by mistake and
delete this e-mail from your system. If you are not the intended recipient
you are notified that disclosing, copying, distributing or taking any
action in reliance on the contents of this information is strictly
prohibited.

+1 any alternatives/existing workarounds for now, though?

yeah portainer. Works great and runs as a docker image

Thanks @droidmahn , portainer works great. I was able to add more volumes to my existing containers, and it handled recreating and restarting them automatically, without any issue. It also has lots of options for the containers and other great stuff, like creating images and stacks.

I am new to Docker, decided going the route of Kitematic and now discovering the volume setting is not always exposed?

@bartclaeys I have a PR open that fixes it, until then I recommend avoiding kitematic.

Would be awesome to see the fix for volume map in Kitematic! Otherwise the best tool to get started with docker.

still issue? shieeet

still issue? shieeet

I would say so.
We changed to DockStation -> https://dockstation.io/
Similar GUI, but project based and more options.
First you will have to start of with a docker-compose File.
But once you have your setup it seems like the "better" tool.

a workaround that worked for me is to create a symlic from the c:\Users\user.myprojects  to d:\myprojects
mklink /J c:\Users\user.myprojects   d:\myprojects
and reference my volumes that way.

Still have a problem on my mac

What kind of joke is this? The point of this GUI is so I don't have to use -v on the command line.

Docker is not responding to its real user community.  According to this post alone, this missed requirement has been an Gaping Requirement Open Sore Systems software (GROSS) for 3.5 years.  This NEEDS to be a CORE feature of the CORE Docker product.  This missed requirement is like in "the marketing idiot old days" of 2000 when Documentum had only an API for its "Users" (aka programmers), and the Documentum Desktop was created as a "demo" for a particular customer to illustrate how to use the "product".  Other customers found out about it and insisted on having the demo source code with their purchase.  It took Documentum many years to create a "Whole Product" offering, by which time their document management software competition had passed them by.  What Fools be Docker Marketing????  Are they paying attention to their customers' requirements?  Obviously not.  Or are they only catering to the requirements of their surrogate users (their internal developers and marketing staff who used to be Docker developers and now represent the "User Community".    Surrogate users' are by definition out of touch with the real users of the product.    @dstibbe got it right... "What kind of joke is Docker/Kitematic?"   GROSS software is unconscionable.  Kitematic / Docker ... get your program "with the program" and enable your users.


Implement PVsyst single diode model

I've heard a number of requests for this capability, which we have in MATLAB but not here.  Requires calcparams_PVsyst and an example set of module_parameters.

It would be great if you include PVsyst loss model!


Intellisense not working when using composed regex in Django url pattern

To reproduce:
1- Create a new Django web project
2- Update urls.py to something like:
...
base = r''

urlpatterns = [
    # Examples:
    url(base + r'^$', app.views.home, name='home'),
    url(r'^contact$', app.views.contact, name='contact'),
...

3- Save, close the solution and reopen
4- IntelliSense is not working any more.
Same issue arrise if you use something like base.format(). But it does not happen if there is no "name" parameter in the url pattern, i.e.:
url(base + r'^$', app.views.home)

This is crashing the analyzer process.

@huguesv Do you have a stack trace? This doesn't repro on master for me, and my best guess as to where it came from (DjangoUrl.cs) hasn't changed recently.

Ignore me - GitHub didn't refresh with yesterday's updates :)


⚠ WARN  deprecated webextension-polyfill-ts

This project has moved to @types/webextension-polyfill

how does the developer to deal with it ?


Koin in Compose Multiplatform

Compose is not supported on iOS, so we need to write UIs in shared module.
Any way to use getScreenModel() in sharedModule with Koin?
Getting this crash:
                         FATAL EXCEPTION: main
                                                                                Process: com.myapplication.MyApplication, PID: 12790
                                                                                org.koin.core.error.NoBeanDefFoundException: No definition found for class:'java.lang.Object' q:''. Check your definitions!
                                                                                at org.koin.core.scope.Scope.throwDefinitionNotFound(Scope.kt:298)
                                                                                at org.koin.core.scope.Scope.resolveValue(Scope.kt:268)
                                                                                at org.koin.core.scope.Scope.resolveInstance(Scope.kt:231)
                                                                                at org.koin.core.scope.Scope.get(Scope.kt:210)
                                                                                at ui.screen.home.HomeScreen.Content(HomeScreen.kt:93)

Oh, it works if you declare like this:
val viewModel =  getScreenModel()
And doesn't work if
val viewModel: HomeViewModel by  getScreenModel()


chore(package): update model-attributes to version 2.2.2

https://greenkeeper.io/

Current coverage is 99.31% (diff: 100%)

Merging #48 into master will not change coverage

@@             master        #48   diff @@
==========================================
  Files             6          6
  Lines           146        146
  Methods          35         35
  Messages          0          0
  Branches          9          9
==========================================
  Hits            145        145
  Misses            1          1
  Partials          0          0

Powered by Codecov. Last update ad61654...f334101


Cannot find annotation method 'justification()' in type 'SuppressFBWarnings'

I'm getting these warnings when building.  I've read that they may be caused by accidentally importing edu.umd.cs.findbugs.annotations.SuppressFBWarnings instead of java.lang.SuppressWarnings as you do here and here.  Is this intentional?

Yep, I used SuppressFBWarnings intentionally.  You can fix the warnings by adding the findbugs warnings as a compileOnly dependency.

Whoops - I see I confused SupressWarnings as SupressFBWarnings in java.lang.  I understand that a compileOnly warning isn't a runtime dependency, but it is a dependency when warning-free compilation is require by a build process.  Doesn't this defeat the dependency-free goal stated in the README?

I find FindBugs invaluable during development.  I agree that the compileOnly issue is a minor but real violation of the dependency-free goal.  I'd love to merge a PR that strips out the annotations as part of the deployment process :)

I didn't know such a thing was possible. After a brief search I don't see anything easily workable, so I'll just let sleeping dogs lie - unless you know more about this than I do and recommend a way forward.

I don't know any easy ways.  Proguard might be able to do it, and certainly you could do it with a bytecode manipulation tool such as ASM.  Every library that uses an annotation-based checker is going to have this problem, so it might be worth building a gradle plugin because we're not the only lib with this issue.


Quick Question regarding the dashboard URL

Hi,
I have set up this alternate dashboard as opposed to using cypress dashboard. i have my dashboard configured in :8080 and the director service in :8001. I have also changed the cypress app.yml to point to http://localhost:8001 (director service).
I am bit unsure on what url to specify when in the .env file for the director service to point to:
should it be http://localhost:8080 (my dahsboard) instead of
DASHBOARD_URL is what Cypress client shows as a "Run URL"
DASHBOARD_URL="https://sorry-cypress.herokuapp.com"

i figured out how to do it. So closing case


Fixes and stability improvements for collapsible comments

Show moderation panel under comments with collapsible comments enabled (doesn't work perfectly for top-level comments though, it gets inserted under all of the comment's children)
Fixes the issue with being unable to collapse new replies you make, this seems to also fix the incompatibility issue with KUP's infinite scrolling comments (I know it uses a separate mutation observer, but I couldn't figure out how to get it to behave nicely with the one built in to KES, it kept infinitely looping like before)
Fixes the issue with comments not nesting at level 10 and above (regex is hard 🥲 /comment-level--(\d)/ -> /comment-level--(\d+)/ was the fix)

This should fix all of these: #142, #130, #78

What are the implications of this extra mutation observer here, anything we need to be aware of?

I thought it was something wrong with the arrays

So did I lmao, spent so much time pulling my hair out trying to figure that out when it was such a simple fix

What are the implications of this extra mutation observer here, anything we need to be aware of?

Honestly, I'm not entirely sure. It doesn't seem to be conflicting with the one in KES. I guess there would be a little bit of a performance impact, I'll take a look at what you wrote for the main observer to see how much I can filter it down.
I'm not sure how to fix the expando line disappearing when you edit a comment. It appears that, when you make an edit, the entire comment div (including the meta, buttons, and children) gets replaced with the edited one. I have no clue how to do it, but it seems like I need to copy the children to a variable when you click the "edit comment" button

I'm not sure how to fix the expando line disappearing when you edit a comment. It appears that, when you make an edit, the entire comment div (including the meta, buttons, and children) gets replaced with the edited one. I have no clue how to do it, but it seems like I need to copy the children to a variable when you click the "edit comment" button and then add them and the buttons back after it gets modified.

The initial report said that it does work in the standalone version, is that the case?

I don't think the initial report mentioned editing at all, I'm pretty sure that has always been a problem with my script

Good point, I think it only mentions replies. I thought they were one and the same.

Oh, so you disabled the recurs flag and you set your own observer, eh? Naughty :D

Exactly hahaha, that's what I was using before I disabled it when you added the global observer. I think the issue comes down to how I set it up originally (basically with a separate entry point for my own observer), and I can't figure out how to unravel it.

Yeah, I tried to debug it a few times but it just made my head hurt. I don't know what it is, the functions are relatively compact, something to do with the repetitive variable names and the previous child, next child, previous element, next element,  and so on. But I guess that's par for the course when reading someone else's code.

So if I understood correctly, the KES root observer triggers when the reply-to field is opened, but after making the post itself, it doesn't subsequently trigger ICC, because we aren't checking the subtree, so ICC sets its own observer?
This seems reasonable enough for now, not sure what other implications there might be. I think we should treat it as tech-debt and endeavor to revamp this in the future so that mods by necessity don't use their own observers unless explicitly necessary, as it might introduce unwanted recursions down the line.

I got it! Finally. I wanted to keep chasing this down because I figured it would improve the core KES functionality and I figured it if affected your mod, it could affect others. Here's what I think we do:
Pass through mutation event targets into the applied mod so that the mod can "see" the mutation and filter it accordingly! The ICC mod was failing because on subsequent mutations, it was returning too early because it "already found" nested comments, but wasn't able to inspect the latest comment and validate it as un-nested, so would quit before reaching applyNewPosts(). So your solution was to restore the observer so that after this failed mutation check, the script would spawn its own observer to catch these events.
New logic: mods don't need to set up their own observers because KES passes the entire mutation target into the mod as the second argument to the init function IF the mod is set up as recurs == true.
So now you get the exact mutation right at the start of the script and you can demonstrably test whether it matches the type needed for some logic to apply:
function initCollapsibleComments (toggle, mutation) {
    console.log("MUTATION IN ICC IS:", mutation)
    const mutClass = mutation.target.className
    if (toggle) {
        if (mutClass === ".entry-comment.nested") {
            return;
        }
       applyToNewPosts()
     }
/// etc...

Sorry to belabor this point, but I think it will make KES itself more robust and flexible. I'll make the changes upstream later and we should take another look at this PR to refactor it slightly, but I think it's gonna work well.

Alright, take a look at this fix. This passes mutation events into the mod and filters them accordingly. Handles:

Nesting comments on page reload
Nesting nth comment when replying
Toggling nesting on/off in KES without having to reload the page

The only thing I didn't check was infinite scrolling, since I'm not sure where to enable that on kbin.
Should be seamless now, no extra observers necessary.

Just tested and confirmed with infinite scrolling, it works as well. The only thing I was unclear on was what the below refers to:

Show moderation panel under comments with collapsible comments enabled

What is the moderation panel?


cmake: do not search for platform specific unwind

This change removes platform specific unwind lookup allowing the use of LLVM unwind implementation.
Closes #629

Codecov Report

Merging #769 (290f413) into master (4ffa983) will increase coverage by 4.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #769      +/-   ##
==========================================
+ Coverage   72.35%   76.53%   +4.17%
==========================================
  Files          17       13       -4
  Lines        3241     2497     -744
==========================================
- Hits         2345     1911     -434
+ Misses        896      586     -310

Impacted Files
Coverage Δ

src/base/mutex.h
100.00% <0.00%> (ø)

src/raw_logging.cc
100.00% <0.00%> (ø)

src/windows/port.cc

src/stacktrace_unwind-inl.h

src/windows/port.h

src/windows/dirent.h

src/demangle.cc
97.50% <0.00%> (+0.02%)
:arrow_up:

src/signalhandler.cc
6.76% <0.00%> (+0.31%)
:arrow_up:

src/glog/logging.h.in
80.64% <0.00%> (+0.64%)
:arrow_up:

src/utilities.cc
69.00% <0.00%> (+1.35%)
:arrow_up:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ffa983...290f413. Read the comment docs.


Bumped deps

Automatically incorporate future bug fixes while maintaining backwards compatibility.

Thanks for the PR, sorry it took so long to merge

Looks like this isn't pushed to npm yet - could you publish 0.2.7?

Yep indeed. Done.


Synthesis failed for Google.Cloud.Kms.V1

Hello! Autosynth couldn't regenerate Google.Cloud.Kms.V1. :broken_heart:
Here's the output from running synth.py:
Cloning into 'working_repo'...
Switched to branch 'autosynth-Google.Cloud.Kms.V1'
Running synthtool
['/tmpfs/src/git/autosynth/env/bin/python3', '-m', 'synthtool', 'synth.py', '--']
synthtool > Executing /tmpfs/src/git/autosynth/working_repo/apis/Google.Cloud.Kms.V1/synth.py.
Cloning into 'gapic-generator-csharp'...
Submodule 'api-common-protos' (https://github.com/googleapis/api-common-protos.git) registered for path 'api-common-protos'
Submodule 'protobuf' (https://github.com/protocolbuffers/protobuf.git) registered for path 'protobuf'
Cloning into '/tmpfs/src/git/autosynth/working_repo/gapic-generator-csharp/api-common-protos'...
Cloning into '/tmpfs/src/git/autosynth/working_repo/gapic-generator-csharp/protobuf'...
Submodule path 'api-common-protos': checked out '93c9c383396b514193735292f6880fccc777614e'
Submodule path 'protobuf': checked out '815ff7e1fb2d417d5aebcbf5fc46e626b18dc834'
Submodule 'third_party/benchmark' (https://github.com/google/benchmark.git) registered for path 'protobuf/third_party/benchmark'
Submodule 'third_party/googletest' (https://github.com/google/googletest.git) registered for path 'protobuf/third_party/googletest'
Cloning into '/tmpfs/src/git/autosynth/working_repo/gapic-generator-csharp/protobuf/third_party/benchmark'...
Cloning into '/tmpfs/src/git/autosynth/working_repo/gapic-generator-csharp/protobuf/third_party/googletest'...
Submodule path 'protobuf/third_party/benchmark': checked out '5b7683f49e1e9223cf9927b24f6fd3d6bd82e3f8'
Submodule path 'protobuf/third_party/googletest': checked out '5ec7f0c4a113e2f18ac2c6cc7df51ad6afc24081'
Cloning into 'gapic-generator'...
Cloning into 'googleapis'...
> Task :buildSrc:compileJava NO-SOURCE
> Task :buildSrc:compileGroovy
> Task :buildSrc:processResources NO-SOURCE
> Task :buildSrc:classes
> Task :buildSrc:jar
> Task :buildSrc:assemble
> Task :buildSrc:compileTestJava NO-SOURCE
> Task :buildSrc:compileTestGroovy NO-SOURCE
> Task :buildSrc:processTestResources NO-SOURCE
> Task :buildSrc:testClasses UP-TO-DATE
> Task :buildSrc:test NO-SOURCE
> Task :buildSrc:check UP-TO-DATE
> Task :buildSrc:build
> Task :extractIncludeProto
> Task :extractProto
> Task :generateProto

> Task :compileJava
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

> Task :processResources
> Task :createProperties
> Task :classes
> Task :shadowJar

BUILD SUCCESSFUL in 15s
7 actionable tasks: 7 executed
Building existing version of Google.Cloud.Kms.V1 for compatibility checking
Generating Google.Cloud.Kms.V1
Running pre-generation script for Google.Cloud.Kms.V1
Running post-generation script for Google.Cloud.Kms.V1
Updated 1 path from the index
Building new version of Google.Cloud.Kms.V1 for compatibility checking

Changes in Google.Cloud.Kms.V1:
Unable to run your project.
Please ensure you have a runnable project type and ensure 'dotnet run' supports this project.
A runnable project should target a runnable TFM (for instance, netcoreapp2.0) and have OutputType 'Exe'.
The current OutputType is 'Library'.
synthtool > Failed executing /bin/bash generateapis.sh --check_compatibility Google.Cloud.Kms.V1:

None
synthtool > Wrote metadata to synth.metadata.
Traceback (most recent call last):
  File "/home/kbuilder/.pyenv/versions/3.6.1/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/kbuilder/.pyenv/versions/3.6.1/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmpfs/src/git/autosynth/env/lib/python3.6/site-packages/synthtool/__main__.py", line 109, in <module>
    main()
  File "/tmpfs/src/git/autosynth/env/lib/python3.6/site-packages/click/core.py", line 764, in __call__
    return self.main(*args, **kwargs)
  File "/tmpfs/src/git/autosynth/env/lib/python3.6/site-packages/click/core.py", line 717, in main
    rv = self.invoke(ctx)
  File "/tmpfs/src/git/autosynth/env/lib/python3.6/site-packages/click/core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/tmpfs/src/git/autosynth/env/lib/python3.6/site-packages/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "/tmpfs/src/git/autosynth/env/lib/python3.6/site-packages/synthtool/__main__.py", line 96, in main
    spec.loader.exec_module(synth_module)  # type: ignore
  File "<frozen importlib._bootstrap_external>", line 678, in exec_module
  File "<frozen importlib._bootstrap>", line 205, in _call_with_frames_removed
  File "/tmpfs/src/git/autosynth/working_repo/apis/Google.Cloud.Kms.V1/synth.py", line 20, in <module>
    hide_output = False)
  File "/tmpfs/src/git/autosynth/env/lib/python3.6/site-packages/synthtool/shell.py", line 39, in run
    raise exc
  File "/tmpfs/src/git/autosynth/env/lib/python3.6/site-packages/synthtool/shell.py", line 33, in run
    encoding="utf-8",
  File "/home/kbuilder/.pyenv/versions/3.6.1/lib/python3.6/subprocess.py", line 418, in run
    output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '('/bin/bash', 'generateapis.sh', '--check_compatibility', 'Google.Cloud.Kms.V1')' returned non-zero exit status 1.

Synthesis failed

Google internal developers can see the full log here.

Autosynth passed, closing! :green_heart:


Fix config file and CLI setting for asdf_compat

Currently,
rtx settings ls lists asdf_compat in it and rtx settings get asdf_compat returns false
but
rtx settings get asdf_compat true and rtx settings get asdf_compat false fail:
Error:
   0: Unknown setting: asdf_compat

Location:
   src/cli/settings/set.rs:37

Version:
   1.18.2 macos-arm64 (built 2023-02-27)

Suggestion: Run with RTX_DEBUG=1 for more information.

Backtrace omitted. Run with RUST_BACKTRACE=1 environment variable to display it.
Run with RUST_BACKTRACE=full to include source snippets.

In fact, manually setting the value for it in ~/.config/rtx/config.toml as per the README also fails (even if you are just explicitly setting it to the default of false):
Error:
   0: error loading settings from [...]/.config/rtx/config.toml
   1: error parsing toml
   2: expected plugin to be a string, array, or table, got: true

Location:
   src/config/config_file/rtxrc.rs:161

TOML:
   [asdf_compat]
   true

Version:
   1.18.2 macos-arm64 (built 2023-02-27)

Suggestion: Run with RTX_DEBUG=1 for more information.

Backtrace omitted. Run with RUST_BACKTRACE=1 environment variable to display it.
Run with RUST_BACKTRACE=full to include source snippets.

This PR fixes both of these situations.

thanks for this, I think I just tested this with RTX_ASDF_COMPAT=1 and threw this in last minute


Fix issue with Z_GENLIST_FOR_EACH_NODE

This issue is observed with respect to  pthread_setspecific and pthread_getspecific APIs.
When a key is not found in specified list, SYS_SLIST_FOR_EACH_NODE enters infinite loop.
This change adds a condition in for loop to check if pointer to next node points to start of the list.

I suppose there's a small chance that the core list iteration solution used in Zephyr for years might have a flaw that breaks with a pass through a list without changing it, but I very much suspect something else is going wrong, such as improper use of the API.
Can you provide a minimal example that reproduces the problem you're trying to fix?

Hi @pabigot, thanks for taking a look. I have attached example code to reproduce this issue.
In this case, when pthread_getspecific() is called from second task, it never returns.
main.c.zip
Thanks,
Shubham

I think the bug is in your code.  Your thread priorities are 4 and 5, which are both preemptible, as is main by default.  So multiple threads can be in thread_semphr_get_wrapper() running the initialization code at the same time.
I'd recommend using K_PRIO_PREEMPT(4) or K_PRIO_COOP(4) to make more clear what type of thread you intend to use, and you should use a spinlock when you're creating the shared key.

Actually I was calling pthread specific APIs from kernel thread which caused the issue. Creating a pthread and then calling pthread_setspecific/pthread_getspecific fixed the issue.


CVE-2023-38408

Is your feature request related to a problem? Please describe.
There is one CVE identified by Wiz.io to be a vulnerability.
Describe the solution you'd like
Updating the packages openssh-clients, openssh-fips, and openssh-common to 8.4p1-1503<IP_ADDRESS> or higher.
Describe alternatives you've considered
Adding the following command to the Dockerfile: RUN zypper update openssh-clients to https://github.com/rancher/rancher/blob/release/v2.8/package/Dockerfile
Additional context
Currently we are using the stable image release,
https://hub.docker.com/layers/rancher/rancher/stable/images/sha256-bf7a69196cd0af5d7a54782c29f9efd1e635ea8cc926eb6d888232b9dd5d0896?context=explore
We are currently self-hosting Rancher using AKS with deployment via Helm Charts. Our secuirty tool, Wiz.io, picked this up as a High Vulnerability.

Wiz.io findings
The package openssh-clients version 8.4p1-1503<IP_ADDRESS> was detected in ZYPPER package manager on a container image running Suse 15.4 is vulnerable to CVE-2023-38408, which exists in versions < 8.4p1-1503<IP_ADDRESS>.
The vulnerability was found in the Official Suse Security Advisories with vendor severity: High (NVD severity: Critical).
This vulnerability has a known exploit available. Source: Packetstorm.
The vulnerability can be remediated by updating the package to version 8.4p1-1503<IP_ADDRESS> or higher, by adding the following command to the Dockerfile: RUN zypper update openssh-clients.

From what I can see, this CVE is already patched at v2.7 head branch and it will be fixed on the stable tag once the next release is out. Here's what Trivy is saying for CVEs at the rancher/rancher:v2.7-head base image:
rancher/rancher:v2.7-head (suse linux enterprise server 15.5)
=============================================================
Total: 0 (UNKNOWN: 0, LOW: 0, MEDIUM: 0, HIGH: 0, CRITICAL: 0)

Hi @pjbgf thank you so much for your answer. Do you know when the next release is going to happen?


tests: Fix node taint test

What this PR does
Before this PR:
The test did not correctly check prefixes of pod names, so it always passed.
And after finishing, it left the cluster in an inconsistent state, so other tests could fail.
After this PR:
An Eventually() is used in AfterEach() to wait until all deployments that were running on the tainted node are ready again.
Fixes: https://issues.redhat.com/browse/CNV-35315
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note

None

/cc @0xFelix @ksimon1

/retest

@xpivarc , I'm unsure why the tests are failing, do you maybe know why?
The log says:
Found  tests not assigned to any SIG, please check: hack/dockerized "hack/bazel-fmt.sh && hack/bazel-build-functests.sh"

But I didn't add any tests or change the test name.

/retest

/cc

/retest

The pull-kubevirt-check-unassigned-tests fails with:
Found  tests not assigned to any SIG, please check: hack/dockerized "hack/bazel-fmt.sh && hack/bazel-build-functests.sh"

I've run the command hack/dockerized "hack/bazel-fmt.sh && hack/bazel-build-functests.sh". It did not fail and did not change anything.

@akrejcir Can you please try to close and reopen?

/close

/reopen

@dhiller Is it possible to install the pcre package in the test runtime, or do you have doubts that this is a good idea?

I'm looking into this more. On latest main the tests.test binary only requires these dynamic libraries:
$ ldd tests.test
	linux-vdso.so.1 (0x00007fffb0520000)
	libresolv.so.2 => /lib64/libresolv.so.2 (0x00007f4a5101e000)
	libc.so.6 => /lib64/libc.so.6 (0x00007f4a50e3c000)
	/lib64/ld-linux-x86-64.so.2 (0x00007f4a5104d000)

With this PR, there are required 65 libraries including libpcre.so:
$ ldd tests.test | wc -l
65

$ ldd tests.test | grep libpcre
	libpcre.so.1 => /lib64/libpcre.so.1 (0x00007fc34f4fe000)
	libpcre2-8.so.0 => /lib64/libpcre2-8.so.0 (0x00007fc34f463000)

/cherrypick release-1.2

/retest

@xpivarc can you please take another look?

/unhold since that should not be necessary any more

/retest

/lgtm
Thanks

/unhold
/retest

/cherry-pick release-1.1

/cherry-pick release-1.0


charmxi fails to deal with rvalue references

Original author: Nils Deppe (@nilsdeppe)
Original issue: https://charm.cs.illinois.edu/redmine/issues/1501

This is probably related to issue #1500, but having an entry method take an rvalue reference causes the charmc script to choke on the CI file. e.g. line 3 of:
<code class="cpp">
entry void observe_reduction_data(
        const Instance_t&,
        ReductionObservationData<Instance_t, ElementId<VolumeDim>, VolumeDim>&&);
</code>

Since rvalue references aren't implemented until C++11 this cannot be resolved until at least Charm++ v6.9.0

Original date: 2017-11-29 21:21:20

Is this fix in gerrit now somewhere? I thought it was, but I guess I was mistaken...

Original date: 2017-12-07 17:25:15

~~https://charm.cs.illinois.edu/gerrit/#/c/3263/~~ https://github.com/UIUC-PPL/charm/commit/fc7869098f86ab81d1c8fa1f9e18bb9aa4cf08f8 addresses the performance concern here, in that (non-inline) entry method implementations will always be passed arguments as rvalue references. The interface declarations still won't parse rvalue reference syntax, but they can just be written as call-by-value arguments, and the generated code will take them as const& anyway.

Original date: 2017-12-29 17:48:01

Reassign to Evan based on discussion with Eric B.  Confer on how important this work is to schedule in the near future.

Original date: 2018-01-08 23:09:05

~~https://charm.cs.illinois.edu/gerrit/c/3490~~ https://github.com/UIUC-PPL/charm/commit/213a634bc6222463a79764064916099398f038f5
This patch adds rvalue references to charmxi's parsing grammar. I'm not sure if this is enough to fix the bug, but I would appreciate feedback and testing.

Original date: 2018-01-17 17:32:51

In testing this patch, a .ci file containing an rvalue reference function parameter was successfully parsed. Nils, if it would not be too much trouble, could you cherry-pick this patch and test it against the case reported in this issue description?


Missing LICENSE

Hi, I'm improving some of the Pentoo overlay ebuilds and came across your tool we packaged. Could you add a license for your tool, so that we, but also other developers, can work with your tool? :-)
See https://choosealicense.com/ if you need help picking an open source license (e.g. MIT, GPL).

Done, c53da68.


Gnome 3

Is 0.7.2 compatible with Gnome 3?  I noted some gnome2 dependencies, such as python-gnome2.
Thanks!

Yes, it's compatible with both Gnome 2 and Gnome 3.


Quick Start Documentation out of sync with latest build

Was looking to update our Swift SDK from 0.42 -> latest (0.57) and encountering an initializer error because the url argument is no longer supported. Checked the documentation and see that it still says the url argument is supported.
Looks like the argument was removed with this change: https://github.com/growthbook/growthbook-swift/commit/5c1f9aae8adba73f39f599fae20db841538532d5#diff-9fb9393d03752436c3248bcd9815cb5b09e5de06d63970e339799c7abbda954c
Seems like just need to rename the arguments but unclear without spelunking into all the changes. What is the correct way to initialize now?
Quick Start Documentation

Error:

Hmm actually seems like more to it, made change to update url -> apiHost and am now getting this error at runtime: FeaturesViewModel.swift:96 ERROR: Failed get api URL

Hi, @philfi. Instead of using "url", in current version we use apiHost and clientKey params. It's important to fulfill them both.
In your case it'll look like:
private lazy var growthBook: GrowthBookSDK = GrowthBookBuilder(
apiHost: "https://cdn.growthbook/. io",
clientKey: "sdk-abc123",
attributes: [:],
trackingCallback: { experiment, experimentResult in
10g-debug ("User Viewed Experiment: (experiment.key) and is in variation: (experimentResult.variationId)")
AnalyticsService.trackExperimentViewEvent(
experimentId: experiment.key, variationId: experimentResult.variationId, inExperiment: experimentResult.inExperiment
refreshHandler: { boolValue in
10g debug ("ExperimentService Cache Refreshed: (boolValue)")
｝
).initializer()

Yep that works thank you. Please update the documentation accordingly 🙏

Yes, we have also uploaded a new PR for the documentation. We are currently waiting for it to be merged. We apologize for the inconvenience.

No worries thank you!


hide footnote clicking everywhere

Thank you for your excellent work!
I tested it on my website (www.filosofico.org/gnoseologia/verita-tomismo.php), but due to some changes on the code (I have eliminated sup tag), the script works uncompletely: a) I can't see the pointer over the "x", b) the "x" is not at right side, if the text is small (like in the note 6 of the webpage linked above).
this is the code I've changed:
const fnRefs = document.querySelectorAll("a[id^='fnref:']");

Therefore I'd like know if it could be possible 1) to fix the two above problems, and 2) hide the footnote clicking everywhere within it (the #popup-content), and not only over the "x".
Thanks!
EDIT
I had found another, simpler way for footnotes: you can see it here www.filosofico.org/gnoseologia/verita-blondel1.php
This requires a very simple code, as you can see in the source code. But the problem is that if you don't click over the anchor the footnote remain, and the new footnote appears over the previous.

x button alignment and pointer should be customized within your CSS files, not the JS. (If I understand your problem correctly.)
Currently, the footnote is closed either after scroll event or by pressing the x button. I don't have the time to properly add new method for closing right now.
I would consider a PR if it does not break anything.

Thanks!


Fix error of instantiation of MosesTokenizer and MosesDetokenizer using Python2

Description
The sacremoses can be imported using python2, but the instantiation of the mose  tokenizer/detokenizer can cause error. This pr fixes this issue.
Checklist
Essentials

[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage
[x] Code is well-documented

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

Job PR-251/3 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-251/3/index.html

@szha can you merge this?


Add Scope.Exists / Collection.Exists / Document.Exists

Functionality to test if something exists

This will likely require refactoring to make the migration Up/Down into async methods.


improvement: hyperparameters optimization (quasi-newton) in Gaussian Process regression

It would be good to include "automatic" hyperparameter tuning for the GP regressor. If I am right, at the moment the initial value for them is kept as fixed?

58e6571f48bd4cd97e6dc59b0ea449c2005536c8


UWP: System.IO.FileNotFoundException after Merging Universal Windows Assemblies

I am trying to merge an UWP application with a UWP class library. Merging itself works without an error, but the resulting application immediately crashes at startup with the following exception:
System.IO.FileNotFoundException was unhandled
Message: An unhandled exception of type 'System.IO.FileNotFoundException' occurred in Unknown Module.
Additional information: Could not load file or assembly 'Windows.Foundation.UniversalApiContract, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null' or one of its dependencies. The system cannot find the file specified.

Any ideas why it would not find the reference after merging? I found some posts of the same exception together with outputs mentioning Mono.Cecil in the unity forum, so could it just be a problem with the cecil version being used in ilrepack?
Thanks!

I'm not really familiar with UWP.
But I know IL, if you can provide the assemblies you're trying to merge ?
(or any assembly which reproduces the error, can be an empty project)
(ILRepack version and command-line used would help as well)

Thank you for the quick response.
You find a TestProject in Project and the output files in Files in the following attachment:
IlrepackTestProject.gz
(For some reason GitHub did not allow me to upload a .zip file, you might have to rename it to .zip before unpacking.)
I created a post build event and the command line is:
..\..\..\..\..\tools\ilrepack.exe /out:SomeProgram.merged.exe SomeProgram.exe SomeLibrary.dll
move SomeProgram.exe SomeProgram.old.exe
move SomeProgram.pdb SomeProgram.old.pdb
move SomeProgram.merged.exe SomeProgram.exe
move SomeProgram.merged.pdb SomeProgram.pdb

ilrepack version is the latest, meaning 2.0.10. If you want to run the project, just open it on any Windows 10 machine, activate developer mode and run the Debug/x86 config.

I had a look at the assemblies with ildasm myself, and I assume this is the problem:
Original/Input Assembly:

.assembly extern windowsruntime Windows.Foundation.UniversalApiContract
{
.ver 2:0:0:0
}

ilrepack output Assembly:

.assembly extern Windows.Foundation.UniversalApiContract
{
.ver 2:0:0:0
}

I assume, that if the windowsruntime attribute were set in the output assembly, everything would work ok...

Fixed in master, PR done to cecil to keep in sync, feel free to give a try before the release.
Thx !


ChatHistory should not derive from List<ChatMessageBase>

It's confusing for a consumer, as you then see methods on ChatHistory like Add(ChatMessageBase), but you can't new-up a ChatMessageBase as it's abstract.  ChatHistory should expose on it whatever API surface area it needs and implementing whatever collection interfaces make sense, and the storage for it should be an implementation detail contained in the class.
(It's extra strange that not only does ChatHistory derive from List<ChatMessageBase>, it also exposes a List<ChatMessageBase> Messages property that just returns this.)

@shawncal - can you take a look into this question/request.


fix(compute-mig): add mode property to compute_region_autoscaler

Description
The compute-mig module at //modules/compute-mig takes in the mode property via the variable autoscaler_config but does not propagate it to the google_compute_autoscaler and google_compute_region_autoscaler resources in autoscaler.tf.

Checklist

I applicable, I acknowledge that I have:

[ ] Read the contributing guide
[x] Ran terraform fmt on all modified files
[ ] Regenerated the relevant README.md files using tools/tfdoc.py
[ ] Made sure all relevant tests pass

Nice catch.
Can you sign the CLA so we can merge this?

Can you sign the CLA so we can merge this?

Done.


Fix integration-cli tests

Fixed the problem with #18124 by starting the test-specific docker daemon with the preloaded busybox image.
The three tests

TestDockerNetworkMultipleNetworksGracefulDaemonRest
TestDockerNetworkMultipleNetworksUngracefulDaemonRestart
TestDockerNetworkHostModeUngracefulDaemonRestart

now also run fine on ARM.

LGTM, nice catch!

LGTM

@StefanScherer :+1:
LGTM 🐮

LGTM


docs needed: what is inside the runtime and how can i use the ejected version

Is your feature request related to a problem? Please describe.
We do not clearly document what capabilities and structure of the runtime.
Describe the solution you'd like
We should provide documentation for the runtime such as:

inline code documentation within the code itself
A document explaining the configurable options
A document explaining the build process for use outside of Composer
Documents explaining the creation of custom actions

This will be a separate topic about what it is, how to separately configure it, deploy it, etc.

Chime @luhan2017 in to help on this topic.

@benbrown Are we still working on this? Should we document the new runtime?


How to change the default tab size to 4?

The default tab size seems to be 2 spaces. Any idea how I can change this to 4?

This seems like it should be added to a preference menu.  If you download dart and get a copy of the repo you can set this yourself.  The settings aren't as granular as eclipse is, but I expect this may be added soon.  I'm currently on the 0.0.17 repo, due to autocomplete issues.  If you modify line 260 of ace.dart, which reads:
session.tabSize = 2;
just set it to 4 and you will have 4 spaces instead...this only affects the editing mode (thus doesn't apply to previous tab spaces).

@rchassereau thanks for the info. I'm running the editor as a Chromium app on Ubuntu 14.04. Do you know where I can find the ace.dart file?

@henrywright it's in the web/ide/lib folder.  I would recommend downloading the repo, and navigating to this path with in it and performing the change.  You can load the app externally if you enable developer mode in chrome extensions.

No luck finding that folder unfortunately. I think perhaps because I'm using the app as a Chromium extension.

Found the folder thanks to this answer on Ask Ubuntu. Problem is, making the change you suggested has no effect


Almost every modded level is broken

Describe your bug here.
From missing assets, to videos refusing to play, to animations not triggering, almost every single mod is bugged beyond repair, even leading up to some crashing, missing backgrounds, exaggerated camera movement, scripts failing to load and more.
Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
Besides adding mods into the mod folder, it's pure vanilla

Psych Engine 1.0 is a bit broken, cuz the LUA API changed.

Psych Engine 1.0 is a bit broken, cuz the LUA API changed.
What does that mean?

Also, @Tday6, I experienced the same issue; it's because none of the base game assets are actually in the game itself other than UI stuff, regular Boyfriend and Girlfriend sprites, and music tracks.


Build fails with opencv 2.4.13

Using Arch Linux and compiled opencv2 from aur
4 |     let img = opencv::highgui::imread("house.jpg",1);
|         ^^^
error: linking with cc failed: exit code: 1
= note: /usr/bin/ld: cannot find -locvrs
collect2: error: ld returned 1 exit status

I'm currently not targeting 2.4.x branch in master anymore, sorry


description: render as markdown

Prior to this change the description parameter was templated as a
string. This made it difficult to insert links or make text bold, as the
Go template engine escapes any html markup.
After this change the string is rendered with .RenderString which uses
the default page markup, markdown, to render the string.

@lollipopman
Thank you! And really sorry for the delay.


feat: implement CacheItemsTrait for better performance handling

As reported by https://github.com/silverstripe/silverstripe-s3/issues/67, https://github.com/silverstripe/silverstripe-s3/issues/48 and others the performance of this module on flysystem 3 is bad, very bad. This is my attempt at overhauling the performance of the module to get better results out of the box.
In the original upgrade we picked up jgivoni/flysystem-cache-adapter thinking it would go a job but actually caused more headaches - turned out easier to implement something tailored to our needs.
The new CacheItems integrations natively with the existing CacheInterface within Silverstripe so works out of the box but can also be used with memcached, redis etc.
Performance wise, warm cache it makes 0 calls to AWS. On a cold cache it makes 3N calls for published files (doesObjectExistV2, readObject, fetchFileMetadata).

Note for anyone testing, there are several YAML changes. The intention was this release we'll make a new major version rather than a minor.

Will test this in the morning but at first glance, using a new Asset Store looks like it will have the biggest performance gains and essentially is what I have implemented custom already on most of my sites.
Also for sites that have a ton of files or a lot of users, this issue is causing some problems as well https://github.com/silverstripe/silverstripe-framework/issues/11272
Last thing I noticed in some of the other silverstripe repos are pull requests to not use self:: for calling a class' static method. https://github.com/silverstripe/silverstripe-cms/pull/2955
I saw a few instances of that in the new files so that might want to be checked.

Testing currently on one of our larger sites, with over 20k users, 17k files, 22k pages.  Overall seems to be working great.  Initial load in asset admin still a bit slow but don't know if there will ever be anything that can be done for that when trying to load metadata for 25+ files at once.  Will monitor for the next day or so and let you know if I see any issues

One thing that I am not 100% sure if this is configurable or not is if there is a way to disable the flushable portion of this cache.  Main reason why is I am using Redis to store the cache, but hosting on heroku - when they restart the server daily or we deploy a code change, this cache is then flushed even though we don't need it to.
@wilr - do you know if there is a way to disable that.  I think that would be a huge help for people on hosting platforms like heroku

Okay, so I have added in some small code to allow the cache flushing to be configurable in the same manner that SilverStripe\Assets\InterventionBackend allows for this.
One issue that I am having though is when trying to utilize the PublicCDNAdapter by setting the .env variable of AWS_PUBLIC_CDN_PREFIX - The public url returned is always the s3 bucket url and not the CDN url.  I can also see stored in the cache the public url being stored with out the cdn prefix.
At line https://github.com/silverstripe/silverstripe-s3/blob/pr/performance/src/Adapter/CachedAwsS3V3Adapter.php#L97
Since this is calling parent::publicURL we are then calling the AwsS3V3Adapter public url method where we really want to be getting the PublicAdapter's or PublicCDNAdapter's getPublicUrl method -
https://github.com/silverstripe/silverstripe-s3/blob/pr/performance/src/Adapter/PublicAdapter.php#L33
https://github.com/silverstripe/silverstripe-s3/blob/pr/performance/src/Adapter/PublicCDNAdapter.php#L43
overall not sure the best way to handle this so you get the proper CDN URL

So we tested this out on another site as well yesterday afternoon that has about 10k image assets. All has been working fine and as expected. Would say this is good to go.

Merged now @obj63mc I'm happy it's a good initial step forward without making any major philosophical changes.
Further work could be (I'm happy to hear people's thoughts as a trade off between 'correct' and 'fast')
fileSize, mimeType, publicUrl if not cached hits AWS to get that figured out..
Given that it probably doesn't change over time it could be saved to the db. That would cut down 3 queries per file on a cold cache.


[FRONTEND WITH FRAMEWORK]: Angular(4.2) -> Dependency Injection Tokens and Providers

Description

What is dependency provider?
What is dependency injection token?
How to configure class provider with dependency?
How to inject an object?
How to use InjectionToken object?
What is use of factory providers?
Explain with syntax/examples
Reference :- https://angular.io/guide/dependency-injection-providers
(Week 4 Issue)

Note:-

Don't copy paste, we would be merging after reviewing the PR.
Changes should be made inside "Frontend_Web_Development_React_Angular_Vue/Angular/Week4" directory
Tasks would be assigned on First Come First Serve Basis

Domain
Frontend Dev React/Angular/Vue
Type of Contribution
Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

/assign

any updates @4neesc0des


Allow failures for jruby-head until next release

#233 is caused by a bug the latest release in jruby. It's fixed upstream, but currently causing the build to fail. This updates travis to allow failures on jruby-head for now.

Thanks for your kindness :sparkles: