Confusing warning in PLOAD_IMAGE_NOTIFY_ROUTINE documentation

"Warning  The actions that you can perform in this routine are restricted for safe calls. See Best Practices"
Two things:

What is, "are restricted for safe calls" supposed to mean?
The Best Practices link is clearly incorrect. It's possible that a corrected link would answer #1, though I can't find anything on MSDN defining or describing "safe  calls".

Thanks!
-scott

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a9d0bfa8-68c2-0594-eaf3-8a77d4404157
Version Independent ID: c8e2634a-a965-fb18-e68f-07b6682605ae
Content: PLOAD_IMAGE_NOTIFY_ROUTINE (ntddk.h) - Windows drivers
Content Source: wdk-ddi-src/content/ntddk/nc-ntddk-pload_image_notify_routine.md
Product: windows-hardware
Technology: wdk-api-reference
GitHub Login: @barrygolden
Microsoft Alias: bagold

Hi @scottnoone thanks for the feedback.  I found the problem with the Best Practices link.  Will you let me know if that link clarifies at all?  If not happy to try and get more info on it.

Closing out for now, please re-open if you'd like to request doc updates


ENH mini bench

Fixes #605.
This implements decorator to create mini benchmarks runnable with benchopt run --mini mini_file.py.
This allows to run the following benchmark:
from benchopt.mini import solver, dataset, objective
import jax

@dataset(
    size=100,
    random_state=0
)
def simulated(size, random_state):
    key = jax.random.PRNGKey(random_state)
    key, subkey = jax.random.split(key)
    X = jax.random.normal(key, (size,))
    return dict(X=X)

@solver(
    name="Solver 1",
    lr=[1e-2, 1e-3]
)
def solver1(n_iter, X, lr):
    beta = X
    for i in range(n_iter):
        beta -= lr * beta

    return dict(beta=beta)

@objective(name="Benchmark HVP")
def evaluate(beta):
    return dict(value=(0.5 * beta.dot(beta)).item())

Not completely sure this is useful but got it done by playing with another benchmark, it would be nice to have feedback on whether it seems usable or not.
(No doc or test yet)
Checks before merging PR

[ ] added documentation for any new feature
[ ] added unit test
[ ] edited the what's new (if applicable)

Codecov Report

Merging #641 (724f685) into main (9955d4c) will decrease coverage by 1.21%.
The diff coverage is 29.62%.

:exclamation: Current head 724f685 differs from pull request most recent head 51c1de3. Consider uploading reports for the commit 51c1de3 to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main     #641      +/-   ##
==========================================
- Coverage   56.14%   54.94%   -1.21%
==========================================
  Files          45       46       +1
  Lines        2882     3016     +134
  Branches      530      550      +20
==========================================
+ Hits         1618     1657      +39
- Misses       1144     1238      +94
- Partials      120      121       +1


Markdown in posts is not rendered; it IS rendered in About page

I followed the instructions at https://github.com/barryclark/jekyll-now .
Using the online default editor at gh, I have filled in my own text for my About page and my first Post.
When my blog is displayed, and also when I look at About.md or .md in github, the markdown in About is rendered, but that in  is not--it is just displayed as text, with "_" not causing italics and so forth.
I have tried a couple of steps suggested to me by https://github.com/jekyll/jekyll-archives/issues/28, but some of the discussion there is over my head. I'm new to github and jekyll, and I'm not a web developer, so html and so forth is  to me!
One thing that might have introduced problems is that at one point I used the Settings page of my repository to choose the Merlot theme for my gh pages site. This had no effect, even though I could see the "theme: ...." entry in the config file. Eventually removed that line because it didn't seem to achieve anything and I wondered if it was causing my problem.
I'm not sure if my non-rendering problem predated that change. Don't know enough about git/github to roll back to prior version.
How would you suggest I proceed?
If you want to look at my repo, it's at https://github.com/NormBirkett/NormBirkett.github.io.
Any help you can offer would be greatly appreciated.
UPDATE:
I just noticed something odd. See this screenshot:

The "##" for a heading is not rendered, but the numbered para format is applied. Weird.
Also, I have confirmed that all changes introduced when I used the github pages gui to apply the merlot theme have been backed out now.

GOOD NEWS: This was an ID10T problem! I hadn't formatted my markdown correctly. Now that I've followed the rules of github-flavored markdown, all is well.
My apologies to anyone who spent any time on this.


ENH: special.rel_entr: avoid premature overflow

Describe your issue.
Looks like there's opportunity for improvement in scipy.special.rel_entr. Presumably, it takes the ratio x/y before taking the logarithm because it's faster than taking the difference of two logs, but this can overflow when the correct result is finite. Perhaps a compromise is to check for the overflow and, in that case, take the time to compute the two logs separately.
This came up gh-20673 as a Hypothesis counterexample rather than a real use case, which is why I consider it an enhancement request.
Reproducing Code Example
import numpy as np
from scipy import special
x = np.asarray([2., 3., 4.])
y = np.asarray(np.finfo(np.float64).tiny)
special.rel_entr(x, y)  # array([1418.17913143, 2128.48509246,           inf])
x * (np.log(x) - np.log(y))  # array([1418.17913143, 2128.48509246, 2839.13085157])

Error message
-

SciPy/NumPy/Python version and system information
main

It is clearly desirable to avoid premature overflow.
I wonder if taking log and then subtract would increase numerical error if x is very close to y. And if it does, whether it is significant for practical applications.

@fancidev

If x and y are greater than one, taking the log and then subtracting might reduce the accuracy, as the domain of logarithm is “larger” than its image. On the other hand, accuracy is not compromised if the arguments are less than one, which may be typical if rel_entr is applied to two probability values.

I checked this idea experimentally, and in general, the division approach has better accuracy than the logarithm approach. With three exceptions, the x * log(x / y) approach has equal or better accuracy than the x * (log(x) - log(y)) approach.
The three exceptions:

Overflow. If x / y == inf, then log subtraction is more accurate. (This is the lower-right white area of the graph below - here error is infinite for the ratio approach.)
Underflow. If x / y == 0, then log subtraction is more accurate. (This is the upper-left white area of the graph below - here error is infinite for the ratio approach.)
Subnormal numbers. If x / y is a subnormal number, then log subtraction is more accurate. (This is the diagonal band of yellow squares above the main diagonal. This has finite error, but is still quite inaccurate.)

Other than these three exceptions, the division approach is more accurate.
Here's a comparison of the error of the two methods:

(Note: Errors have been clipped at 95% to make the graphs readable. Some cells have thousands of ULP of error. See full notebook for details.)
With that in mind, here is the logic I would propose:
# assume all of the corner cases have already been handled
ratio = x / y
if ratio == inf or ratio < np.finfo(np.float64).tiny:
    return x * (log(x) - log(y))
else:
    return x * log(ratio)

The ratio == inf check handles case 1. The ratio < np.finfo(np.float64).tiny check handles cases 2 and 3.
If you look only at the area where x < 1 and y < 1, which is the bottom-left quadrant of the graph, then the x * log(x / y) approach still has equal or better accuracy than the x * (log(x) - log(y)) approach.
Notebook source

Very interesting analysis @nickodell ! I suspect the "clipped" values with large error could be related to x and y that are close.
To illustrate this, I tried a contrived example:
import numpy as np
from mpmath import mp
mp.dps = 1000
x = 1234
y = np.nextafter(x, 100)
print(f'{np.log(y/x)=}')
print(f'{np.log(y) - np.log(x)=}')
print(f'{float(mp.log(y)-mp.log(x))=}')
print(f'{float(mp.log(mp.mpf(y)/x))=}')
print(f'{np.log1p((y-x)/x)=}')

Output:
np.log(y/x)=-2.2204460492503136e-16
np.log(y) - np.log(x)=-8.881784197001252e-16
float(mp.log(y)-mp.log(x))=-1.842574355293615e-16
float(mp.log(mp.mpf(y)/x))=-1.842574355293615e-16
np.log1p((y-x)/x)=-1.842574355293615e-16

So for those two numbers that are really close, log(y/x) is off by 20%, log(y)-log(x) is off by 380%, and log1p gives the correct answer.
The contrived example shows that if we insist on the accuracy from a numerical perspective, there's a fair bit of work to do.

That's a really smart idea. Here's another graph of function error for the log1p method. (I used np.log1p((x - y) / y) rather than np.log1p((y-x)/x), though.)

So I could piece together a more accurate rel_entr() from three sources: log1p for the diagonal, where x and y are very close, ratio for everywhere else, and log difference for places where there is under/overflow.

@mdhaber

This came up 20673 as a Hypothesis counterexample rather than a real use case, which is why I consider it an enhancement request.

By the way, I was looking into Hypothesis testing today, and I was unable to find the Hypothesis test case which exercises rel_entr. I tried searching for "hypothesis," but that finds a lot of false positives. Could you share which test case found this counterexample?

It was probably https://github.com/mdhaber/scipy/blob/dd62d13d771bf07c045495e1ad878765fffcc95a/scipy/special/tests/test_support_alternative_backends.py


*: add send_response macro that helps interactive with grpc sinks

There are many gRPC sink types, some of them have fail() and success() methods and some of them only have fail(). It is difficult to write a function that handles all of the sinks, but macros can. In this PR, I add a new macro which handles most of the use cases and reduces about 150 lines of redundant code.

/run-all-tests

/run-all-tests

I talked with @BusyJay offline, we think we can provide result functions for every sink types in the grpcio, so I am going to close this PR.


Barebones: Declared empty Initialize Platform

This change delcares the sjsu::InitializePlatform() as an empty
function in the barebones example to further reduce the number of
dependancies in the binary further making the project more barebones.

Coverage remained the same at 87.862% when pulling 2188cfec4ef877d82cdf6e879aedf5aaaefab11c on barebones-deifned-initialize-platform into 536b9b01b38860f2eb22480911d5c5cbaf82a1ae on master.


compilation err

Hi, thanks for your project.
When I try
<#@ template debug="true" hostspecific="true" language="C#" #>
<#@ import namespace="Newtonsoft.Json" #>
<#@ import namespace="System.Collections.Generic" #>
<#@ import namespace="System" #>
<#@ import namespace="System.IO" #>
<#@ import namespace="System.Linq" #>
<#@ import namespace="Microsoft.AspNetCore.Http" #>
<#@ import namespace="Microsoft.AspNetCore.Mvc" #>
<#@ import namespace="Microsoft.AspNetCore.Mvc.ApiExplorer" #>
<#@ import namespace="System.Reflection" #>
<#@ import namespace="Microsoft.AspNetCore.Mvc" #>
<#@ import namespace="System.Text.RegularExpressions" #>
<#@ import namespace="System.Threading.Tasks" #>
<#@ import namespace="System.Reflection" #>
<#@ import namespace="System.Runtime" #>
<#@ import namespace="System.Xml" #>
<#@ import namespace="System.Xml.Linq" #>
<#@ Assembly name="EnvDTE" #>
<#@ Assembly name="Microsoft.AspNetCore.App" #>
<#@ output extension=".ts" #>
<# /* Environment.CurrentDirectory */ #>

//AUTOGENERATED DO NOT EDIT THIS FILE <#= DateTime.Now.ToString() #>

I get
(0,0): ERROR The type or namespace name 'Newtonsoft' could not be found (are you missing a using directive or an assembly reference?)
(0,0): ERROR The type or namespace name 'AspNetCore' does not exist in the namespace 'Microsoft' (are you missing an assembly reference?)
(0,0): ERROR The type or namespace name 'AspNetCore' does not exist in the namespace 'Microsoft' (are you missing an assembly reference?)
(0,0): ERROR The type or namespace name 'AspNetCore' does not exist in the namespace 'Microsoft' (are you missing an assembly reference?)

The template engine and language currently has no notion of using NuGet packages, target framework monikers and many things that would be needed to have templates work as smoothly as they did under .NET Framework. Using anything beyond the very basics available in .NET Core is going to be difficult. The right expectation to keep is that T5 will pretty much work (for now) for very simple templates that:

use C# (i.e. <#@ template language="C#" #>)
don't rely on a specific host (i.e. <#@ template hostspecific="false").
independent of the IDE (i.e. no <#@ Assembly name="EnvDTE" #>).
don't require external assembly references (i.e. no @Assembly directive).

See my comment in mono/t4#8 about the goal and scope of T5. If you wish for more complete support so that you have to make the least amount of changes in your templates then mono/t4 is a better place to ask and look for that as @mhutch has much more ambitious plans for T4.
I'm going to close this as out of scope.


Example is not working. so I modified it.

Changed Android kotlin minium support version.(1.6.10 → 1.7.10)

> Kotlin version (1.6.10) is lower than Flutter's minimum supported version of 1.7.0. Please upgrade your Kotlin version.
> Kotlin version (1.7.0) will soon be dropped. Please upgrade your Kotlin version to a version of at least 1.7.10 soon.

Changed go_router library (^3.1.1 → ^14.2.7)

>  Error: The class 'NavigatorObserver' can't be used as a mixin because it isn't a mixin class nor a mixin.
+ Input routes into 'routerConfig' parameter in MaterialApp.router.

Hi @Shoryu-Y You are one of the greatest developers.
trun_page_transition library gives many good insprit to me.
So I tried to fix your example code.
Thanks!
Have a nice day!

Thank you for your pull request! I appreciate the improvements you've suggested.
I will review it within the next 24 hours
Thanks again, and I look forward to collaborating further!

Thank you for your pull request! I appreciate the improvements you've suggested. I will review it within the next 24 hours
Thanks again, and I look forward to collaborating further!

Ofcourse I will :)

I've confirmed that the example app works. Thank you!


Microsoft.SqlServer.Management.Smo.FailedOperationException - DllNotFoundException

Hi, we have started getting an exception since updating our SMO NuGet packages to the latest version (currently: 161.41011.9)
Here is my code:
           SqlConnectionStringBuilder ConnStr = new SqlConnectionStringBuilder(DBConnectionString);
           SMOServerConnection = new ServerConnection(new SqlConnection(DBConnectionString));
           server = new Server(SMOServerConnection);
           DB = new Database(server, ConnStr.InitialCatalog);

I am getting the following error on the last line when assigning a new database instance: Microsoft.SqlServer.Management.Smo.FailedOperationException: 'SetParent failed for Database 'MyDB'. '
The inner exception states the reason being: DllNotFoundException: Unable to load DLL 'Microsoft.Data.SqlClient.SNI.x86.dll': The specified module could not be found. (Exception from HRESULT: 0x8007007E)
I have checked the bin folder and as per the documentation on GitHub, the two required dlls are present in the output.
I have tried, removing and reinstalling all NuGet packages associated with my project however, this has not had any effect.
My project is built against .NET 4.7.2
Does anyone have any clue as to what I am doing wrong?
Thank you in advance

I have managed to get to the root of my issue which was the need to reference the Microsoft.Data.SqlClient Nuget Package in the console project that was calling the class library that was causing the issue.


run-build and run-tests need to have their version of the run-matlab-command-action updated

Currently both actions are deployed with an old version of the module, so the -sd startup flag bug is still present.

Fixed in v2 release of run-build


fix(explore): save chart not working

SUMMARY
Saving a chart is currently broken due to referencing an incorrect property on the response object.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

[x] Has associated issue: closes #12177
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

Codecov Report

Merging #12178 (d748464) into master (942e321) will decrease coverage by 3.42%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12178      +/-   ##
==========================================
- Coverage   66.75%   63.33%   -3.43%
==========================================
  Files         994      484     -510
  Lines       49068    29742   -19326
  Branches     4979        0    -4979
==========================================
- Hits        32756    18836   -13920
+ Misses      16184    10906    -5278
+ Partials      128        0     -128

Flag
Coverage Δ

cypress
?

javascript
?

python
63.33% <ø> (-0.93%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/db_engines/hive.py
0.00% <0.00%> (-85.72%)
:arrow_down:

superset/databases/commands/create.py
32.65% <0.00%> (-59.19%)
:arrow_down:

superset/sql_validators/postgres.py
50.00% <0.00%> (-50.00%)
:arrow_down:

superset/db_engine_specs/hive.py
54.61% <0.00%> (-29.62%)
:arrow_down:

superset/views/database/mixins.py
59.64% <0.00%> (-22.81%)
:arrow_down:

superset/db_engine_specs/presto.py
70.56% <0.00%> (-12.78%)
:arrow_down:

superset/db_engine_specs/mysql.py
79.59% <0.00%> (-12.25%)
:arrow_down:

superset/databases/commands/update.py
85.71% <0.00%> (-8.17%)
:arrow_down:

superset/databases/dao.py
94.11% <0.00%> (-5.89%)
:arrow_down:

superset/views/database/validators.py
78.94% <0.00%> (-5.27%)
:arrow_down:

... and 529 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 942e321...d851472. Read the comment docs.


env nil check

if not  has any env, c.envState.GetActiveEnvironment() retun nil, so  environment.MetaData.ID will be panic
func (c *Controller) onSubmitRequest(id string) {
	c.view.SetSendingRequestLoading(id)
	defer c.view.SetSendingRequestLoaded(id)
	MetaDataID := ""
	environment := c.envState.GetActiveEnvironment()
	if environment != nil {
		MetaDataID = environment.MetaData.ID
	}
	res, err := c.restService.SendRequest(id, MetaDataID)
	if err != nil {
		fmt.Println("failed to send request", err)
		return
	}

	resp := string(res.Body)
	if res.IsJSON {
		resp = res.JSON
	}

	c.view.SetHTTPResponse(id, domain.HTTPResponseDetail{
		Response:   resp,
		Headers:    mapToKeyValue(res.Headers),
		Cookies:    cookieToKeyValue(res.Cookies),
		StatusCode: res.StatusCode,
		Duration:   res.TimePassed,
		Size:       len(res.Body),
	})
}

Thanks for reporting this. its fixed now :)

Nice work
---Original---
From: "Mohsen @.>
Date: Fri, Apr 5, 2024 03:09 AM
To: @.>;
Cc<EMAIL_ADDRESS>Subject: Re: [mirzakhany/chapar] env nil check (Issue #16)
Thanks for reporting this. its fixed now :)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>


implement batch constraint for doe

@Osburg did the same here: https://github.com/experimental-design/bofire/pull/322
So with which solution should we go on?

A

@Osburg did the same here: #322
So with which solution should we go on?

Oh I did not see that one. Sorry, I thought we agreed we would do the doe constraint after you do the polytope sampler and interpoint constraint, but I might as well missunderstood that. Anyways, I am fine with proceeding with Aaron's implementation, since I am still playing around with a formating that would make pyright and black to not complain.

@KappatC Ah, yes this is possible. Sorry in that case! Was working on the batch constraints this weekend anyways and just continued bc I was already on it...

So, we close this PR and go forward with the one from @Osburg?

@jduerholt sure, let me play a bit around it first and then I ll close it

@Osburg nw, thanks for working on this in any case. Maybe in the future we just try to coordinate a bit better, so that we don't do duplicate work
yes, sure, this was my bad! Will watch out better next time!


'Failed to load plugin' when unloading a deleted plugin

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/26803090-failed-to-load-plugin-when-unloading-a-deleted-plugin?utm_campaign=plugin&utm_content=tracker%2F6855523&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F6855523&utm_medium=issues&utm_source=github).

Fixed in PR #550.


Default paths and search path for Igor are incorrect on Linux

Currently the plugin doesn't work on Linux as far as I can tell.
My runtime directories are all set where you'd expect (/home/user/.local/share/GameMakerStudio2-Beta/Cache/runtimes/), the user data path is a bit more interesting, as this may be wrong (/home/farinata/.local/share/GameMakerStudio2-Beta/User).
Is this a mistake that I'm making, or is Linux just not supported?

Heyo, Linux should be supported in theory but I've never tested it myself. What do you mean by "doesn't work"? Does the plugin not load? Does compilation throw an error? etc.

@thennothinghappened I tried setting this up in Ubuntu and I'm stuck exactly where @JellyTale is.
I did set up everything on Windows first just to be sure. And on Linux, I installed GameMaker on my Ubuntu machine from the official Beta .deb file and GameMaker itself works as it should.
I found the Linux-equivalent directories for the Beta Runtimes and User directories (same ones as @JellyTale) and even after restarting GMEdit, the dropdown menu for "Versions" does not display anything despite there being a couple in my Runtimes folder.

I think what @JellyTale meant by "the user data path is a bit more interesting, as this may be wrong" is that—at least in my case—the User directory is empty even if you sign-in through GameMaker itself. But that's definitely not a GMEdit-Constructor issue.

I reckon there's two issues going on here:

users must be stored somewhere else — both in windows and macos the users directory does not live side by side to runtimes.
the structure of linux runtime installs must look a bit different, since the way runtimes are indexed by Constructor is to check if Igor exists at a specific path within them.

Ah, try removing /User.

@thennothinghappened Now a "Dumps" option appears:

The /Dumps folder contains these two files:

dump_pid
timestamp

Not sure if this is correct.
I did a search for Igor files on my entire machine and these are the results:
/home/posho/.local/share/GameMakerStudio2-Beta/Cache/runtimes/runtime-2024.600.0.609/bin/igor/linux/x64/Igor
/home/posho/.local/share/GameMakerStudio2-Beta/Cache/runtimes/runtime-2024.1100.0.707/bin/igor/linux/x64/Igor

There are inside the same directory as my Beta Runtimes path.

Alright, I've just pushed two commits to main which should both no longer pick up Dumps as a user, and should make runtimes show up. Still not sure where your user directory lives - if you'd be able to run a search for license.plist, that might turn up results.

@thennothinghappened Thank you! I pulled the changes and the runtimes do show up!

The "User" dropdown now shows nothing. I also looked for any license.plist file on my computer and didn't get a single result. I signed out of my Opera account on GameMaker and logged back with my Legacy YoYoGames account just to see if that somehow did anything, but still nothing. The /User folder is still empty as well.

Hm, my next guess then would be try opening the IDE, change a setting in preferences, then run a search for local_settings.json. I'm not sure what else to look for to identify profiles. If this file does not exist, then profiles must be structured completely differently on Linux for some reason beyond me.

Yup, that did the trick!

Running the search gives me this:
/home/posho/.config/GameMakerStudio2-Beta/green.tie.rgm_36623/local_settings.json
/home/posho/.config/GameMakerStudio2-Beta/unknownUser_unknownUserID/local_settings.json
/opt/GameMaker-Beta/aarch64/local_settings.json
/opt/GameMaker-Beta/x86_64/local_settings.json

Now it works! Thank you so much!

Cool! I've just gone ahead and made a new release version available, so Linux is now properly supported unless there's any other issues. I'll close this issue now as it was issues with paths, but of course do make a new issue if there's any other problems.

Thank you so much! I'll fiddle around this weekend and will let you know if I find anything weird. 👍
Cheers!


changed string iso formatting

improved datetime from str to iso conversion in coerce_output.
Standart python datetime module cant parse correctly all iso string types

Hi @Mo1far thanks for this contribution.
Can you also add a test case that validate this special isoformat parsing ?
Thanks again for your contribution.

Added tests and resolve mistakes


crash when querying video formats

Hi,
I'm using pyicic on Windows 7 x64 with Python 3.5 x64 and tisgrabber_x64.dll. The camera is a DMM 24UP031-ML. This line in the example script crashes Python most of the time (but not always) without any error message:
formats = cam.list_video_formats()
The only thing I get is the Windows error message.
Any idea what might be the problem?

If you follow the definition of list_video_formats you'll see that a fixed size (80 x 40) char array is being created and passed to the underlying function. If this array if the wrong size and/or the data being written doesn't fit in the array you may well get a crash. I don't have a camera at this stage so all I can suggest is playing with this size or investigating if there is a recommended size you can use instead.

Thanks for the hint. I'll play around with the char array a little. Maybe I can come up with a fix.

The example in tisgrabber.h does use the same size array, but yes, still experiment with it.

I ran into the same problem as ZacDiggum, and followed the advice of morefigs,
and found some potential solutions.
I'm using a DMK 27BUP031 camera that has 66(!) formats in the list. The changes listed
next have been tested with Python 3.5, 64-bit and Python 2.7, 32-bit.
Fix, option 1.
Replace the function list_video_formats in IC_Camera.py with this version:
def list_video_formats(self):
    """
    :returns: list -- available video formats.
    """
    return [self.get_video_format(idx) for idx in range(self.get_video_format_count())]

This is the simplest solution, and sidesteps the problem of the fixed size allocation in
the character buffer. In fact, this option is mentioned in the C header file tisgrabber.h
at line 679, "Simpler approach of enumerating video formats. No 2D char array needed."
Using a list comprehension is also more "Pythonic", and avoids more ctypes manipulations.
Fix, option 2.
This option is to actually fix the buffer problem. The issue appears to be that the
use of hard-coded 80 and 40 are reversed from what is required.
Replace line 655 in IC_GrabberDLL.py with:
POINTER((c_char * 40) * 80),
In function list_video_formats(), in IC_Camera.py:
A. Replace the assignment to vf_list with:
vf_list = ((c_char * 40) * 80)()
B. The last parameter in the call to IC_GrabberDLL.list_video_formats should be 40, not 80:
c_int(40))
As I understand it, with these changes, each format can now be up to 39 characters
(one less than 40), and there can be up to 80 formats in the list.
Of course, this is only a partial fix, because the number of formats that can be handled
is now hard-coded at 80, and some future (or present) camera may exceed this number of
formats.
I have tested this on only the one camera mentioned earlier.

Fix option 1 sounds like the way to go. If someone makes a pull request for that I can add it, or I can do it myself in the nearish future.

This issue is resolved and should be closed.

Thank you @adrian-pps  and @morefigs!

Thank you
On 22-Nov-2017 4:53 PM, "ZacDiggum"<EMAIL_ADDRESS>wrote:
Thank you @adrian-pps https://github.com/adrian-pps and @morefigs
https://github.com/morefigs!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/morefigs/py-ic-imaging-control/issues/13#issuecomment-346322246,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APEdvwsooWIvzwLoqzQJWEN-qToL7s9Gks5s5AQUgaJpZM4NTFJZ
.


Add log gather when pod doesn't get ready by timeout

When Wait For Pods To Be Ready hits the timeout, we can't tell why it happened. So, trying to get clear info by capturing pod logs and namespace events (on failure only)

PR validation

Bunch of tests leveraging on the keyword (for regression): coming soon
Simulating failure (from local) in a Model Serving test:


Latest failing when building in shipping configuration

The latest version at commit https://github.com/sinbad/SPUD/commit/db196b31413e9d17e758df058d1c1784046fdb5a is now failing when building the project in shipping configuration with the following error:
Plugins\SPUD\Source\SPUD\Public\SpudMemoryReaderWriter.h(20): Error C2504 : 'FMemoryReader': base class undefined

Should be fixed now.


[12.0] Redo TimePicker/DatePicker templates

Is your feature request related to a problem? Please describe.
TimePicker/DatePicker styling is problematic, being way too reliant on template parts, and styling deeply baked into C# code.
Any third-party theme can be broken easily by minor improvements in these controls.
Describe the solution you'd like

Reduce template parts to minimum
Use TemplateBinding as much as possible, keeping styling logic in XAML template only
If needed, introduce some kind of TimePickerTemplateSettings class, with readonly properties of pre-computed values useful in XAML template. Something like https://github.com/AvaloniaUI/Avalonia/blob/master/src/Avalonia.Controls/SplitView/SplitViewTemplateSettings.cs

Describe alternatives you've considered
No response
Additional context
No response

Yea, this is a common issue with UWP controls. They didn't get the memo on how to design proper lookless controls.
Resizing of the DatePicker and TimePicker has been a longstanding issue. It has a very large minimum horizontal width it shouldn't have. Any redesign needs to make the control responsive to smaller widths as well.


Voting on minecraft-server-list doesnt work

Fixed, it would not accept the Votifier settings unless it could successfully connect, so the settings were not in from previous testing. Now that the port was accessible, I was able to add and confirmed voting on this site returns essence


Cannot reference njit static methods from no-python code.

Reporting a bug

[*] I am using the latest released version of Numba (most recent is visible in
the change log (https://github.com/numba/numba/blob/master/CHANGE_LOG).
[*] I have included below a minimal working reproducer (if you are unsure how
to write one see http://matthewrocklin.com/blog/work/2018/02/28/minimal-bug-reports).

class X1(object):

    @staticmethod
    @numba.njit
    def f():
        return X1.g()  # Not allowed, even though referencing a simple numba function.

    @staticmethod
    @numba.njit
    def g():
        return 99

@numba.njit
def a():
    return X1.g()

print X1.g() # OK
print a() # Fail
print X1.f() # Fail

Although it can be determined that 'X1.g' is a reference to numba function that numba could deal with in no-python mode, it doesn't seem that it currently works.
Not sure if this is a bug, or a request for a new feature. Currently, I have to move these static functions into the global namespace to work around it.
I would think this is (almost) already possible since its already possible to reference globals (literals) by name in numba functions. The difference here is referencing a global class, and the reference to X1 is known to be a class reference by the time the function is compiled.
Feasibly, numba could rewrite:
<class reference> <'.'> <method_name> ==>  function_ref("#classname_method_name")

... or more generally (or something of general that allows nested (but statically resolvable references). For example:  X1.attribute_of_type_class.OtherInnerClass.g_numba_function is statically resolvable reference when it appears in numba dectorated function.

I am having the same issue. I think this should be considered a bug.
numba.core.errors.TypingError: Failed in nopython mode pipeline (step: nopython frontend)
Untyped global name 'SimulationFunctions': Cannot determine Numba type of <class 'type'>
``


Breaks if request does not have user agent

Describe the bug
Code Breaks if request does not have user agent
To Reproduce
send empty user agent
/app/joshpwa/node_modules/es6-crawler-detect/src/lib/crawler.js:103
agent = agent.replace(this.compiledExclusions, '');
^
TypeError: Cannot read property 'replace' of undefined
at Crawler.isCrawler (/app/joshpwa/node_modules/es6-crawler-detect/src/lib/crawler.js:103:19)

@sharad2802 can you please test this PR, it might fix your issue.


Sharing my results and a thank you...

I want to thank keithito and everyone who has contributed to this project. I know nothing about how neural networks truly work other than the basics, but the people responding to questions on here are helpful and friendly to newbies like myself. The documentation is also easy to follow. Thank you for making this and sharing it!
I decided try turning a YouTuber's voice into text-to-speech. The person I chose was EthosLab. His voice has specific characteristics and enunciations. I was curious if those would still show up when using text-to-speech. I was also curious how the end result would sound using a voice that wasn't reading from a script or a book.
All voice clips were taken from his YouTube videos and manually turned into a dataset. The dataset only has 50 minutes of audio. However, someone mentioned that copying the dataset and making minor changes to speed/pitch can be used as a way to help increase training data for small datasets. So I doubled the size of the dataset by copying all existing audio files and increased the speed by 1%. That meant I had 1.6 hours of audio, but half of it was duplicated with some minor modifications. I also trained on top of the already trained LJ Speech model that keithito provided. I trained for about 30,000 steps. In my opinion the end result turned out good!
This is what the original speaker sounds like. Watch any of his videos to get a feel for his voice: www.youtube.com/user/ethoslab
Here are the results. I tried to mimic Etho's video style and used his text-to-speech voice to narrate everything: https://www.youtube.com/watch?v=OSZ0nq--ihg
In my opinion, copying the dataset and slightly changing the speed on the duplicate data significantly helped make the the voice clearer and not overfit. I trained the model once without the duplicate data and the results weren't nearly as good as the second time I trained with the duplicate data. Might have been a coincidence though.

HI @isaiah658 ，
what tool do you use to  Speed up the speed of audio while maintain its pitch?
Thanks

@peter05010402 I used Audacity. Since the files are small, I would import about 200 files at a time, use the Edit Chains and Apply Chains feature to batch apply the speed effect, and export the modified files. Although, a recent Audacity update appears to have made Macros take the place of Edit and Apply Chains. So the process has changed a bit. If you want to change the audio speed without changing the pitch, you can use the Change Tempo effect in Audacity. Personally though I wanted to use the Change Speed effect. The idea behind increasing the dataset is not about changing the speed. It's about changing the dataset slightly in some way that the neural network has two or more of the same sentences, but with small variations. It's sort of equivalent to saying the same sentence multiple times. It might be said a little differently each time. Those variations seem to help the neural network learn what is actually important and not overfit the data. At least that's how it worked for myself and a few other people.


Async postconditions in generic methods

This PR contains fixes for #235 and #275. Main change in this PR was made in EmitAsyncClosure class.
Special generic type mapping was added to correlate potentially different generic arguments from enclosing generic method to closure generic class.

Any other comments on this stuff? The change was relatively major, so I would like to get additional feedback on this...
/cc @sharwell

@SergeyTeplyakov I have found a few cases for which BadImageFormatException is thrown.
Some of them are reproducible before fix and some were introduced by the fix. I have prepared 192 combinations of class generic arguments and method arguments. With class and struct constraints. I will present a list of failing scenarios ASAP.

There is also some questionable behavior for closure class signature.
public class OuterClassGeneric<T0> where T0 : class {
  public class InnerGeneric<T1> {
    public static async Task<T0> AsyncTest1(T0 v0, T1 v1) {
      Contract.Ensures(Contract.Result<T0>() != null);
      return await Task.FromResult(v0);
    }
  }
}

rewriter generates the following closure method for the method above:
.class nested private auto ansi '<AsyncTest1>AsyncContractClosure_0`1'<class T0, T1, T1>
	extends [mscorlib]System.Object

Second T1 generic type parameter is probably not needed.

Previously CheckPost method content was:
TaskStatus status = task.Status;
if (status == TaskStatus.RanToCompletion && __ContractsRuntime.insideContractEvaluation <= 4)
{
  try
  {
    __ContractsRuntime.insideContractEvaluation++;
    __ContractsRuntime.Ensures(task.Result != null, null, "Contract.Result<T0>() != null");
  }
  finally
  {
    __ContractsRuntime.insideContractEvaluation--;
  }
}
return task;

now it looks like:
TaskStatus status = task.Status;
if (status == TaskStatus.RanToCompletion)
{
  __ContractsRuntime.Ensures(task.Result != null, null, "Contract.Result<T0>() != null");
}
return task;

Is it intended change?

@hubuk About last comment: the chnage is intented, because async postconditions are all about multi threading where thread static checks like __ContracatsRuntime.insideContractEvaluation just makes no sense.

@hubuk Thanks a lot for clear test cases, I'll fix them and will update PR before pushing it to master.

@hubuk FIxed everything that you've mentioned. Including two test cases that you've provde.
Once you'll sign off I'll move forward and will prepare new release of the CodeContracts.

It seems that issue with  public static Task<T> DefaultValue<T>(T obj) method is not reproducible even without the fix. Second issue is fixed by 2163f15.
LGTM :+1:

@hubuk Great. Moving forward to 1.10 release!


pull request for e2e test at 01/27/2017 13:26:23

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Creating a kivy virtual environment fails on OS X 10.11

Hi! Installed using Kivy.app.
kivy command in terminal works, import kivy works.
Trying to create a virtual environment for a test project, here is what happens then... Please help? Googling didn't help...
MacBook-Pieceofduke:pong pieceofduke$ mkvirtualenv pong -p kivy
Running virtualenv with interpreter /usr/local/bin/kivy
Using base prefix '/Applications/Kivy.app/Contents/Resources/./venv/bin/../../../Frameworks/python/3.5.0'
New python executable in /Users/pieceofduke/.virtualenvs/pong/bin/python
Installing setuptools, pip, wheel...
Complete output from command /Users/pieceofduke/....envs/pong/bin/python - setuptools pip wheel:
Traceback (most recent call last):
File "", line 7, in
File "/usr/local/lib/python3.5/site-packages/virtualenv_support/pip-8.1.2-py2.py3-none-any.whl/pip/init.py", line 16, in
File "/usr/local/lib/python3.5/site-packages/virtualenv_support/pip-8.1.2-py2.py3-none-any.whl/pip/vcs/subversion.py", line 9, in
File "/usr/local/lib/python3.5/site-packages/virtualenv_support/pip-8.1.2-py2.py3-none-any.whl/pip/index.py", line 30, in
File "/usr/local/lib/python3.5/site-packages/virtualenv_support/pip-8.1.2-py2.py3-none-any.whl/pip/wheel.py", line 39, in
File "/usr/local/lib/python3.5/site-packages/virtualenv_support/pip-8.1.2-py2.py3-none-any.whl/pip/_vendor/distlib/scripts.py", line 14, in
File "/usr/local/lib/python3.5/site-packages/virtualenv_support/pip-8.1.2-py2.py3-none-any.whl/pip/_vendor/distlib/compat.py", line 66, in
ImportError: cannot import name 'HTTPSHandler'
...Installing setuptools, pip, wheel...done.
Traceback (most recent call last):
File "/usr/local/lib/python3.5/site-packages/virtualenv.py", line 2332, in
main()
File "/usr/local/lib/python3.5/site-packages/virtualenv.py", line 711, in main
symlink=options.symlink)
File "/usr/local/lib/python3.5/site-packages/virtualenv.py", line 944, in create_environment
download=download,
File "/usr/local/lib/python3.5/site-packages/virtualenv.py", line 900, in install_wheel
call_subprocess(cmd, show_stdout=False, extra_env=env, stdin=SCRIPT)
File "/usr/local/lib/python3.5/site-packages/virtualenv.py", line 795, in call_subprocess
% (cmd_desc, proc.returncode))
OSError: Command /Users/pieceofduke/....envs/pong/bin/python - setuptools pip wheel failed with error code 1

I don't think that running Kivy in a virtualenv was ever supported this way (by using the packaged kivy.app). Or was it?
You could try installing Kivy into the virtualenv by building it from source: https://gist.github.com/jegger/9549865

@jegger is right, Kivy.app is not meant to be used that way, try installing manually.


Service collection-auto-discover fails if Configuration collection-auto-discover is not set

In gitlab by @sylvaingaudan on Aug 10, 2017, 10:17
Service collection-auto-discover fails if Configuration collection-auto-discover is not set:
io.arlas.server.app.CollectionAutoDiscoverConfiguration.getFields because fieldsComaSeparated is null:
=> NullPointerException on return Arrays.asList(fieldsComaSeparated.split(","));

In gitlab by @sfalquier on Aug 18, 2017, 15:24
added ~2424199 and removed ~2424198 labels

In gitlab by @sfalquier on Aug 18, 2017, 17:52
assigned to @sfalquier

In gitlab by @sfalquier on Aug 18, 2017, 18:39
mentioned in commit 7722da456c1c0bcc50694e121c52add1e6f88dc8

In gitlab by @sfalquier on Aug 21, 2017, 09:38
mentioned in merge request !82

In gitlab by @MohamedHamouGisaia on Aug 25, 2017, 09:14
closed via merge request !82

In gitlab by @MohamedHamouGisaia on Aug 25, 2017, 09:14
closed via commit 3bcf1a9168de7a59f92f316987aae6caec21f28c

In gitlab by @MohamedHamouGisaia on Aug 25, 2017, 11:48
mentioned in commit 3bcf1a9168de7a59f92f316987aae6caec21f28c


Error Install Cartoview Docker

Hello, an error is generated when installing cartoview master in ubuntu server 16.04
Make run
django.core.serializers.base.DeserializationError: Problem installing fixture '/code/scripts/json/default_oauth_apps.json': Application has no field named u'updated'
Makefile:6: fallo en las instrucciones para el objetivo 'sync'
make: *** [sync] Error 1

replace the Makefile content with the following:
up:
	# bring up the services
	docker-compose up -d

sync: up
	# set up the database tablea
	docker-compose exec cartoview python manage.py migrate
	docker-compose exec cartoview python manage.py loaddata sample_admin.json
	docker-compose exec cartoview python manage.py loaddata default_oauth_apps.json
	docker-compose exec cartoview python manage.py loaddata app_stores.json
	docker-compose exec cartoview python manage.py loaddata initial_data.json

prepare_manager: up
        #make migration for app_manager
	docker-compose exec cartoview python manage.py makemigrations app_manager
migrate_account: up
	docker-compose exec cartoview python manage.py migrate account
migrate:
	docker-compose exec cartoview python manage.py migrate --noinput
wait:
	sleep 5
logs:
	docker-compose logs --follow
logs_tail:
	docker-compose logs --follow --tail 100
logs_tail_cartoview:
	docker-compose logs --follow --tail 100 cartoview
logs_tail_geoserver:
	docker-compose logs --follow --tail 100 geoserver
down:
	docker-compose down
reset: down up wait sync

collect_static: up
	docker-compose exec cartoview python manage.py collectstatic --noinput
run: up wait prepare_manager sync collect_static

static_db: up sync wait collect_static

update:
	docker-compose exec cartoview pip install cartoview --no-cache-dir -U
	docker-compose restart cartoview
new_app: collect_static
	docker-compose restart cartoview


build: run integration tests on production

Adds GitHub Actions config for running integration tests on production.

Closing in favor of #26


[Frontend] Support suffix in completions API (fill-in-the-middle)

For code models that have been trained with an infilling task.
Handle model-specific FIM encoding rules in a similar way to how we're handling different tool parsers.
For example, can be enabled for for Codestral by adding command line arg --fim mistral (as well as --tokenizer-mode mistral in this case).

Planning to simplify this, would be better for it to work more like chat templates than tool parsers.

This is exciting! Looking forward to review

FYI @patrickvonplaten if you'd like to check the Mistral part. Is there a small Mistral model on the HF hub that we could use for this in tests?

I guess codestral might be too big? https://huggingface.co/mistralai/Codestral-22B-v0.1
The 7B-v0.3 should also work reasonably well for FIM though: https://huggingface.co/mistralai/Mistral-7B-Instruct-v0.3

Thanks @patrickvonplaten, yes I was hoping for something smaller than codestral 22B ... will try with the 7B thanks!


Bug: Validation rules max_size

To be honest when I use this rule it works as usual. But when adding this query builder update rules it always raises the error message that has been created.
`if ($this->request->getMethod() == 'post') {
$rules = [
'name' => 'required|alpha_space',
'image' => [
'label' => 'Image',
'rules' => 'max_size[image,2048]|mime_in[image,image/gif,image/jpeg,image/png]',
'errors' => [
'max_size' => 'Allowed maximum size is 2MB', //Always display this error message
even though the uploaded file is 1KB
'mime_in' => 'The Image type is not allowed. Allowed types : gif, jpeg, png'
                ],
            ]
        ];

        if (!$this->validate($rules)) {
            $data['validation'] = $this->validator;
        } else {
            $newData = ['a'=>1]
            $model->update('1',$newData);

;`

Are you using the latest develop branch?

I wasn't able to reproduce it, sorry. It's probably something with your code logic? You can also check if you have any rules set in your model.


re-enable integration tests

Does it make sense to close this branch and maybe just open an Issue to track the need to run all e2e tests under CI?

@levicook we could, I believe we already have that ticket. Not sure what we gain either way though


Question: Can UWP ComboBox max item display limit be overridden?

I'm using the UWP ComboBox (VS 2019). There is apparently a built in max display limit of approximately 9 items depending on item height. So for example, I have a ComboBox with 12 items, when initially opened (with a mouse click) it displays 9 of the items even though there is plenty of real estate to display all 12 items.
If ComboBox is opened on a touch screen with a finger touch it displays ~6 items, even though there is plenty of real estate to display all 12 items.
Notes:

You can scroll through list to see all items.
MaxDropDownHeight = Default (Infinity)

Is there a way to override this behavior and just have all items display when ComboBox opened?

I think there is not anything exposed that would allow you to fix this.. @MikeHillberg maybe you know some secrets?

I think there is not anything exposed that would allow you to fix this.. @MikeHillberg maybe you know some secrets?

Moving forward is there any chance Microsoft will be updating the UWP ComboBox to allow display of all items?

Moving forward is there any chance Microsoft will be updating the UWP ComboBox to allow display of all items?

ComboBox is not a control shipped in Winui2, meaning changing it would require an OS update or Winui3.  We could examine this once WinUI3 ships.

ComboBox is not a control shipped in Winui2, meaning changing it would require an OS update or Winui3.  We could examine this once WinUI3 ships.

I would highly recommend this update.

I would highly recommend this update.

I didn't do the testing, maybe you can try re-template the ComboBox and set MaxDropDownHeight to a larger number. Currently it's hard coded with 504

https://github.com/microsoft/microsoft-ui-xaml/blob/c464079156f3731165ba5068277935c8ed174207/dev/ComboBox/ComboBox_themeresources.xaml#L393

I didn't do the testing, maybe you can try re-template the ComboBox and set MaxDropDownHeight to a larger number. Currently it's hard coded with 504

https://github.com/microsoft/microsoft-ui-xaml/blob/c464079156f3731165ba5068277935c8ed174207/dev/ComboBox/ComboBox_themeresources.xaml#L393

In generic.xaml (v10.0.18362.0) I do see a hardcoded MaxDropDownHeight = "504" for the ComboBox.
My project is actually using generic.xaml (v10.0.17763.0) which does not contain a MaxDropDownHeight (for any control).
Just to be sure I changed MaxDropDownHeight = "1200" in v10.0.18362.0, but had no effect.
I also explicitly set MaxDropDownHeight on the ComboBox control itself in the xaml, again to no effect.
This behaviour is apparently baked into the ComboBox control

In generic.xaml (v10.0.18362.0) I do see a hardcoded MaxDropDownHeight = "504" for the ComboBox.
My project is actually using generic.xaml (v10.0.17763.0) which does not contain a MaxDropDownHeight (for any control).
Just to be sure I changed MaxDropDownHeight = "1200" in v10.0.18362.0, but had no effect.
I also explicitly set MaxDropDownHeight on the ComboBox control itself in the xaml, again to no effect.
This behaviour is apparently baked into the ComboBox control


The plugin logs heartbeats of the shown tag when I am away after being used for a while

Expected Behavior
The plugin should only log heartbeats when I am browsing a webpage, for example, when I move my mouse pointer or scroll on a webpage.
Current Behavior
The plugin logs heartbeats of the shown tag when I am away, no matter I have Chrome in focus or minimize it. This only starts to happen after I use the WakaTime plugin for a while. When I uninstall and reinstall the plugin, the problem is gone for one or two days and then back again.
Possible Solution

No suggestions.
Steps to Reproduce
See Current Behavior.
Context (Environment)
This has happened both on Ubuntu and macOS. I currently have Chrome of Version 106.0.5249.119 (Official Build) (64-bit) on Ubuntu 22.04 LTS.
Detailed Description

No info.
Possible Implementation

No suggestions.

Some addtional information on Context (Environment): on Ubuntu it seems the issue only occurs with LightDM, with gdm (GNOME Display Manager) it works fine.

It logs heartbeats with Opera using the Chrome Plugin too. I had to uninstall it, because I just worked 4 Hours on a project while I was not even near the computer.

closing this
there is new version of the extension that fixed this


mip-carousel支持传入索引参数

mip-carousel支持传入索引参数

Pull Request Test Coverage Report for Build 61

0 of 0   changed or added relevant lines in 0 files are covered.
9 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.2%) to 86.394%

Files with Coverage Reduction
New Missed Lines
%

src/components/mip-carousel.js
9
95.49%

Totals

Change from base Build 60:
-0.2%

Covered Lines:
2827

Relevant Lines:
3158

💛  - Coveralls

Pull Request Test Coverage Report for Build 64

0 of 0   changed or added relevant lines in 0 files are covered.
9 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.2%) to 86.394%

Files with Coverage Reduction
New Missed Lines
%

src/components/mip-carousel.js
9
95.49%

Totals

Change from base Build 60:
-0.2%

Covered Lines:
2827

Relevant Lines:
3158

💛  - Coveralls


Please update the dependency in reademe

I have added an additional dependency in the readme (pyclesperanto-prototype) which I think is required for running the notebooks. Please let me know if I am incorrect about this.

Awesome, thanks for spotting this @rayanirban !


fix: :bug: truncates loRa name lengths and adds tooltips where necessary

What type of PR is this? (check all applicable)

[ ] Refactor
[ ] Feature
[x] Bug Fix
[ ] Optimization
[ ] Documentation Update
[ ] Community Node Submission

Have you discussed this change with the InvokeAI team?

[ ] Yes
[x] No, because: I'm merely addressing a GitHub Issue

Have you updated all relevant documentation?

[ ] Yes
[x] No

Description
This PR fixes LoRa model name lengths that may be too long and negatively affect the layout.
I did this by truncating loRa model names to 24 characters and adding a tooltip if it exceeds that length.
Related Tickets & Documents

Closes #5496

QA Instructions, Screenshots, Recordings

Merge Plan

Added/updated tests?

[ ] Yes
[x] No : I don't wanna

[optional] Are there any post deployment tasks we need to perform?

I don't think this is the right way to solve this problem. Hardcoding the length leads to this:

The label should be cutting itself off via CSS, but for whatever reason that is not happening. It's probably some weird flexbox thing. Usually min-width: 0; fixes flex overflow but that ain't working.
I'm about to do swap all of the primitive components out to use a new Invoke UI library package. I'll address this issue after that.


Add option to break after = in assignment

I would like to see an option in rustfmt to break after the = in an assignment when the right-hand-side is "complex". I admit I don't know what "complex" is — possibly if the right-hand-side is subject to block/visual formatting. Here are a couple examples:
let var1 = if condition {
    true_part
} else {
    false_part
};

let var2 = some_value
    .chained()
    .method()
    .calls();

To me, it would be nicer to see this as:
let var1 =
    if condition {
        true_part
    } else {
        false_part
    };

let var2 =
    some_value
        .chained()
        .method()
        .calls();

In both cases, it seems more readable to me to keep the block together at the same indent level, especially when the variable name gets long.
let it_gets_harder_to_see_them_together = if condition {
    true_part
} else {
    false_part
};

let some_value_winds_up_in_right_field = some_value
    .chained()
    .method()
    .calls();

Compare
let it_gets_harder_to_see_them_together =
    if condition {
        true_part
    } else {
        false_part
    };

let some_value_winds_up_in_right_field =
    some_value
        .chained()
        .method()
        .calls();

You can also replace long variable names with patterns or reasonable variables with type hints.
let GetsHarder { to_see: them_together } = if condition {
    true_part
} else {
    false_part
};

let var1: GetsHarder<ToSee, ThemTogether> = if condition {
    true_part
} else {
    false_part
};

To be clear, I want to keep block formatting. I just would like the option to have the block start indented on the next line.
PS. I didn't want to include this as a motivating example, because it's hardly rustfmt's fault, but editors like IntelliJ will insert "smart" type hints inline automatically. This pads out the line length in a way that rustfmt can't see, and it's why I don't suggest basing this on line length, but rather on whether the right-hand-side is "complex", block-formatted, or something like that.

Indeed, I was surprised when trying to customize my rustfmt.toml that there were close to no customization when it comes to assignments. Then again, looking at how everyone code, I think I am the oddball with my
let a = {
    fct()
        .foo()
        .bar()
};

I'm also looking for an option to prevent the following line-break after a long expression assignment (once it reaches past the 80-character line-width rule):
mod tests {
     #[test]
     fn test1() {
         let principal =
             Principal::new(ID::new_v4(), RoleDiscriminants::Consumer);
     }
}

I would rather enforce this style with block indentation:
mod tests {
     #[test]
     fn test1() {
         let principal = Principal::new(
             ID::new_v4(),
             RoleDiscriminants::Consumer
         );
     }
}

Is it possible to enforce arguments are placed on newlines instead of the entire expression put onto a new line?

+1 for this. Sometimes, async and lambdas need to be differentiated from simple multi-line allocations
For example:
let logic_invoked_immediately/* sometimes-great-IDE-supported-long-inlay-hint-inserted-here */ = if let Some(something) = do_something {
    something
}else {
    fallback
};
let logic_run_later/* sometimes-great-IDE-supported-long-inlay-hint-inserted-here */ = |param_1| {
    do_ops_with(&param_1);
    param_1.do_something_else();
    param_1
};

let this_one_differentiates_from_immediately_invoked_logics =
    |param_1|  {
        do_ops_with(&param_1);
        param_1.do_something_else();
        param_1
    };

let this_might_be_executed_later_either =
   async move {
      do_some_async_calc().await
   };

CLion rust plugin formatter is much more permissive on these kind of line breaks, IMO it helps me a lot to improve readability and reduce confusions from any logic's execution points.

Would be nice for my usecase because currently VSCode-inserted type signatures make my code constantly reflow

+1 on this, although I want to use this option to prevent precisely the "nicer" way you suggested (I dislike it).


[WFLY-15257] Update elytron-oidc-client LocalDescription.properties

WFLY-15257

Hello, theashiot. I'm waiting for one of the admins to verify this patch with /ok-to-test in a comment.

Closing this one


[Gally]: master <- dev

Automatically created by Git-Ally

:tada: This PR is included in version 1.10.183 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Extra hands aren't shown.

Extra hands have their own sprite. Unfortunately the hands do not show. Gotta fix that somehow.

This was resolved by #19


Fix Cron e2e test.

Signed-off-by: Vighnesh Shenoy<EMAIL_ADDRESS>
Provide a description of what has been changed
Checklist

[x] Commits are signed with Developer Certificate of Origin (DCO - learn more)
[x] Tests have been added
[x] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
[x] A PR is opened to update the documentation on (repo) (if applicable)
[x] Changelog has been updated and is aligned with our changelog requirements

Fixes #

Relates to #3217

/run-e2e cron*

/run-e2e cron* Update: You can check the progress here

Kinda realized this is useless, since the arm-smoke script is not even going to be called.


No difference between RougeL and RougeLsum

🐛 Bug

To Reproduce
I finetune BART on CNN/DailyMail dataset using lightning transformers.

Code sample
https://github.com/PyTorchLightning/lightning-transformers/blob/master/lightning_transformers/task/nlp/summarization/model.py#L43

Expected behavior
Each document and summary in CNN/DailyMail have multiple sentences, so RougeL and RougeLsum should be different.

Environment

OS (e.g., Linux): Linux
Python & PyTorch Version (e.g., 1.0): Python 3.9, Pytorch 1.10
How you installed PyTorch (conda, pip, build command if you used source): pip
Any other relevant information:

Additional context
I've checked the code for computing  RougeL and RougeLsum.
It seems that the only difference is that a separator '\n' is inserted after each sentence when calculating RougeLsum.
However, the '\n' is not treated as a special token when calculating lcs and the final score.

cc: @stancld


Add yarn.lock to .npmignore

This file should not be published yet it is found in the latest version

Will merge this, but leaving open for now as a reminder to do release as well.


[stacked_generator] Failed generate with Query Param

I try to generate routes with query param and i catch this error.

And generator forgeted to import my models from app.dart

Hey, what is QueryParam? It's not something we built for. You can remove that. It's not required.

It worked correctly with previous version. It is especially needed if using web version. That way data can be passed in the url to take user directly to correct screen by id.

I see, I see. I've never used that, it's also not in our example app which is why it's broken. I'll work on this as soon as I get a chance.

@maciekczwa can you give me a full example of what's supposed to be generated please. It'll make the fix easier. In your example above why is title not in the path property? Or is that just because this is pseudo code?

I wanted title to be named. If I remember good there was a problem with special characters (like spaces, national characters) in path parameters, when you use QueryParam they are getting url encoded.
The GenericPageView contains some additional parameters which can be passed outside of the url.
Generated working code:
class Routes {
  static const String _genericPageView = '/page/:pageId';
  static String genericPageView({@required dynamic pageId}) => '/page/$pageId';
  static const all = <String>{
    _genericPageView,
  };
}

class StackedRouter extends RouterBase {
  @override
  List<RouteDef> get routes => _routes;
  final _routes = <RouteDef>[
    RouteDef(Routes._genericPageView, page: GenericPageView),
  ];
  @override
  Map<Type, StackedRouteFactory> get pagesMap => _pagesMap;
  final _pagesMap = <Type, StackedRouteFactory>{
    GenericPageView: (data) {
      var args = data.getArgs<GenericPageViewArguments>(
        orElse: () => GenericPageViewArguments(),
      );
      return MaterialPageRoute<dynamic>(
        builder: (context) => GenericPageView(
          key: args.key,
          pageId: data.pathParams['pageId'].getInt(),
          pageTitle: data.queryParams['title'].optString(),
          siblingPagesData: args.siblingPagesData,
        ),
        settings: data,
      );
    },
  };
}

/// ************************************************************************
/// Arguments holder classes
/// *************************************************************************

/// GenericPageView arguments holder class
class GenericPageViewArguments {
  final Key? key;
  final SiblingPagesData? siblingPagesData;
  GenericPageViewArguments({this.key, this.siblingPagesData});
}

Target view class:
class GenericPageView extends StatelessWidget {
  final int pageId;
  final String? pageTitle;
  final SiblingPagesData? siblingPagesData;

  GenericPageView({Key? key, @PathParam('pageId') required this.pageId, @QueryParam('title') this.pageTitle, this.siblingPagesData})
      : super(key: key);
}

App:
@StackedApp(
  routes: [
    MaterialRoute(page: GenericPageView, path: "/page/:pageId")
  ])

Awesome, thanks. I'll see where that code went. It was most likely removed during our refactor.
I'll find an older version and then I'll merge it back in at some point.

@FilledStacks, I wont to ask U. Can u fix var to final. Because my linters swear at it.

Yes you should. Since you are not reassigning it.

@ziqq if I get some time I can. It's a small fix, you can probably find the place and make a PR for it then I'll merge it in.

@FilledStacks. Strange, I ran the generator and got what I was supposed to do without changing the source code. Magic, I don't think so. The only thing I did was update a couple of dependencies.
But generator forgot import my models.

And i catch this same error

Where should that be added?

Where should that be added?

On top. And in old version i have my models imports but i don't find it in new version.

I see, add it in, make a PR and I'll publish it.

I can't add PR becouse i didn't has time. Plz make fix and update package.

The same here. We'll look at it sometime in this week, maybe next week.


Update Uno.PackageDiff for easier-to-access errors

Will log failing API changes to build output, to save having to download artifacts.
Note: Added breaking change for testing, will be removed
GitHub Issue (If applicable): #

PR Type
What kind of change does this PR introduce?

Build or CI related changes

What is the current behavior?

What is the new behavior?

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] Tested code with current supported SDKs
[ ] Docs have been added/updated which fit documentation template. (for bug fixes / features)
[ ] Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
[ ] Wasm UI Tests are not showing unexpected any differences
[x] Contains NO breaking changes
[ ] Updated the Release Notes
[ ] Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

Lovely.


Add an option to force using non-default credentials for local instances

If machines within same domain have opened AEM instance ports it is very unsafe to use default AEM credentials, because then any external user is able to install any CRX package and run any Java code because of OSGi bundle hot deployment. It is some kind of backdoor and this mechanism will protect against it.
Imagine
aem {
    config {
        instanceSafeCredentials = true
    }
}

then build will detect if default credentials are used, if yes, then it will automatically change credentials on AEM to customized ones.
maybe introduce aemAudit task which will do such specialized things

Secure-cq should be used instead. Closing


Add support for cosmwasm backend

Motivation / Context

Cosmwasm backend and contracts have been released for go-perun. Add support for configuring the perun-node to use the cosmwasm backend.
Description

Core package of the perun-node (session) is blockchain agnostic. However, components like key management, identity management are specific to each blockchain. So,  add implementations for managing keys for the cosmos backend.
Also, update the configuration parameters of the node, so that users can easily choose between ethereum or cosmos backend with simple configuration changes.
Relates to

Testing

The end-to-end tests for payment API should work for cosmos backend as well.
Thread Safety

I would love this!


Nerf trajopt example on cuda

Hey Tim,
I'm trying to get the nerf trajectory optimization example running on cuda. I was able to get it running on cpu, and edited lines 171-179 as follows:
# --------------------------------- Load NERF -------------------------------- #
    model = DensityNeRF()
    model_path = os.path.join(os.path.dirname(__file__), "nerf_model.tar")
    model.load_state_dict(
        torch.load(model_path, map_location="cuda")["network_fn_state_dict"],
        strict=False,
    )
    # -------------------------- Create L4CasADi Module -------------------------- #
    l4c_nerf = l4c.L4CasADi(model, device="cuda")

However, when I run this, the second nlp solver seems to hang:
(l4casadi) adam@adam-ubuntu:~/Sandbox/l4casadi/examples/nerf_trajectory_optimization$ python nerf_trajectory_optimization.py
This is Ipopt version 3.14.11, running with linear solver MUMPS 5.4.1.

Number of nonzeros in equality constraint Jacobian...:       36
Number of nonzeros in inequality constraint Jacobian.:     2700
Number of nonzeros in Lagrangian Hessian.............:       90

Total number of variables............................:       18
                     variables with only lower bounds:        0
                variables with lower and upper bounds:        0
                     variables with only upper bounds:        0
Total number of equality constraints.................:        6
Total number of inequality constraints...............:      300
        inequality constraints with only lower bounds:        0
   inequality constraints with lower and upper bounds:      300
        inequality constraints with only upper bounds:        0

iter    objective    inf_pr   inf_du lg(mu)  ||d||  lg(rg) alpha_du alpha_pr  ls
   0  1.0161843e+02 1.19e+00 1.00e+02  -1.0 0.00e+00    -  0.00e+00 0.00e+00   0
   1  3.5003351e+01 4.43e-08 2.22e+00  -1.0 4.80e+03    -  3.01e-01 1.00e+00f  1
   2  1.0827344e+01 4.02e-08 1.13e+00  -1.0 2.26e+03    -  8.49e-01 1.00e+00f  1
   3  2.7440984e+00 1.55e-09 2.47e-11  -1.0 1.85e+03    -  1.00e+00 1.00e+00f  1
   4  4.0409223e-01 2.04e-08 4.75e-01  -2.5 1.44e+03    -  9.40e-01 1.00e+00f  1
   5  7.3485968e-02 6.77e-10 2.87e-11  -2.5 1.15e+03    -  1.00e+00 1.00e+00f  1
   6  4.1873740e-02 4.36e-10 1.37e-11  -3.8 5.28e+02    -  1.00e+00 1.00e+00f  1
   7  4.0472866e-02 6.24e-11 6.51e-12  -3.8 2.85e+02    -  1.00e+00 1.00e+00f  1
   8  4.0419962e-02 9.64e-12 8.72e-12  -5.7 5.41e+01    -  1.00e+00 1.00e+00f  1
   9  4.0419926e-02 6.06e-13 1.36e-11  -8.6 1.88e+00    -  1.00e+00 1.00e+00h  1

Number of Iterations....: 9

                                   (scaled)                 (unscaled)
Objective...............:   2.9568343777355507e-02    4.0419925943644970e-02
Dual infeasibility......:   1.3623588368538719e-11    1.8623445299792427e-11
Constraint violation....:   6.0595972684041044e-13    6.0595972684041044e-13
Variable bound violation:   0.0000000000000000e+00    0.0000000000000000e+00
Complementarity.........:   9.9614675922336054e-09    1.3617326198583336e-08
Overall NLP error.......:   9.9614675922336054e-09    1.3617326198583336e-08

Number of objective function evaluations             = 10
Number of objective gradient evaluations             = 10
Number of equality constraint evaluations            = 10
Number of inequality constraint evaluations          = 10
Number of equality constraint Jacobian evaluations   = 10
Number of inequality constraint Jacobian evaluations = 10
Number of Lagrangian Hessian evaluations             = 9
Total seconds in IPOPT                               = 0.594

EXIT: Optimal Solution Found.
/home/adam/anaconda3/envs/l4casadi/lib/python3.10/site-packages/torch/jit/_check.py:177: UserWarning: The TorchScript type system doesn't support instance-level annotations on empty non-base types in `__init__`. Instead, either 1) use a type annotation in the class body, or 2) wrap the type in `torch.jit.Attribute`.
  warnings.warn(
CUDA is available! Using GPU cuda.
This is Ipopt version 3.14.11, running with linear solver MUMPS 5.4.1.

Number of nonzeros in equality constraint Jacobian...:       36
Number of nonzeros in inequality constraint Jacobian.:     5400
Number of nonzeros in Lagrangian Hessian.............:      171

Any thoughts on what the issue might be? I'm using a conda environment with python 3.10 and torch 2.3.0.

Hi Adam,
I looked into this. For unknown reasons, the second c++ jit forward pass freezes. It seems like the DensityNeRF model has something which the c++ jit fusion engine can not handle. As of now, I am unsure what exactly the underlying problem is. [1]
For now, the (dirty) fix is to add torch.jit.set_fusion_strategy([('STATIC', 0)]) at the top of your python script. This will likely affect the performance of the model; however, I am unsure how much.
I'll potentially have another look at this later this week. Please let me know if this unblocks you for now.
Best
Tim
[1] https://discuss.pytorch.org/t/slow-forward-on-traced-graph-on-cuda-2nd-iteration/118445/6

Thanks Tim! Your tip worked, I was able to run the script.
I'm also curious in general about the performance difference between gpu and cpu. I noticed that in most of the examples gpu tends to perform similar or worse than cpu. Have you also observed this on your end?

Hi Tim,
Got it, that makes sense. Thanks so much for the detailed answer and example!
I did also notice that you are evaluating the NeRF in a for loop (i.e. batch size of 1 as you mentioned). You mentioned that solvers are not designed to take advantage of batching - is there a reason why it isn't possible to evaluate the NeRF density over the whole trajectory as a single batched input? I ask since we are looking into traj opt in implicit maps, and wondering if batching would be possible/provide a speed up.
Thanks,
Adam

Hi Adam,
Again, these are very valid points! My argument in the last post that "solvers" can not handle batches was slightly sloppy. In the NeRF example, CasADi is the limiting factor. My understanding is that CasADi does not have a notion of a "batched dimensions". As such, in the NeRF example, if we pass a batched vector ([150, 3]) to the L4CasADi NeRF function, the forward pass will work (output -> [150, 1]). However, as a Jacobian, CasADi will expect the L4CasADi function to return a vector of size [150, 3, 150, 1] when we only want to calculate a vector of [150, 3, 1]. Similarly, for the Hessian ([150, 3, 150, 1, 150, 3, 150, 1] vs [150, 3, 1, 3, 1]). As you can see, this will produce a massive overhead.
Now, I am not an expert in CasADi, and it would make sense to double-check this or ask in the CasADi Github if there is a way to somehow leverage the batching capabilities of Torch/L4CasADi. If there is a way to cleverly leverage torch's batching capabilities (e.g. maybe via the sparsity propagated in CasADi 🤔), I would be more than happy to adapt L4CasADi to make this work.
Best
Tim

https://github.com/casadi/casadi/discussions/3715

Hi Adam,
I figured out a way to potentially leverage such parallel calls better: https://github.com/casadi/casadi/discussions/3715
While planning to implement this, it will most likely take some time until I find the time to do this properly (this will be some larger changes to L4CasADi)
If this is okay with you, I will close the issue for now.
Best
Tim

Hey Tim,
Thanks for looking into this! This would definitely be very beneficial for our use cases. Yes you can feel free to close this issue, I'll stay tuned for updates and also keep you posted if I find anything on my end.
Best,
Adam


Turn off -Werror or -Wimplicit-function-declaration by default for C code?

I ran into the OpenSSL build failure recently with -Werror. Out of curiosity, I looked at the issue tracker and it seems like the use of -Werror is a source of repeated build problems. Some examples:

https://github.com/rbenv/ruby-build/issues/1998 due to -Werror + -Wimplicit-function-declaration in OpenSSL
https://github.com/rbenv/ruby-build/issues/1747 due to -Werror + -Wimplicit-function-declaration in Ruby itself, I think
https://github.com/rbenv/ruby-build/issues/1489 due to -Werror + -Wimplicit-function-declaration in OpenSSL

This had a dupe:  https://github.com/rbenv/ruby-build/issues/1764

https://github.com/ffi/ffi/issues/869 due to -Werror + -Wimplicit-function-declaration in Ruby FFI

Dupe of this GitHub issue: https://github.com/rbenv/ruby-build/issues/1709#issuecomment-964526168 (converted to Discussion #1870)
Another dupe: https://github.com/rbenv/ruby-build/issues/1699 (converted to Discussion #1946)

Whenever something like this happens, it ends up wasting time for a bunch of people as evidenced by these threads, and it's not clear (at least, to me) what the benefit of having that error is if someone is going to recommend (the very reasonable) workaround of using -Wno-error=implicit-function-declaration. Would it make sense to change the default, by adding a  -Wno-error or -Wno-error=implicit-function-declaration prefix to the appropriate environment variables?

Yes, this is annoying but this -Werror=implicit-function-declaration is the default on macOS (and not on Linux, hence why it does not always get caught early). First, it does not seem advisable to disable something the OS does by default.

if someone is going to recommend (the very reasonable) workaround of using -Wno-error=implicit-function-declaration.

Actually it can be a pretty dangerous workaround, because then the compiler does not know precise argument types and could end up passing arguments incorrectly, which could cause all kinds of problems (e.g., if the prototype is var-args it'd probably crash or corrupt the arguments on aarch64).
It is also always a clear bug in the source for not properly including functions it uses, and missing an include e.g. can result in incorrect compilation, not defining the macros as needed, not using an intrinsified version of the function, etc.
Also BTW recent CRuby enables that flag by default, and it would be very bad to disable something CRuby enables on purpose: https://bugs.ruby-lang.org/issues/18615
Since CRuby enables it for their CI and they test on macOS this should not happen anymore for CRuby.
Regarding OpenSSL, I'd wish they check their CI before releasing (they do enable the flag in CI as well) but apparently they did not for 1.1.1q.


Document if as adverb for use

The problem
These lines:
https://github.com/skinkade/crypt-random/blob/c1bf9393ab736ac5e5de2d0c3f56078c178cc071/lib/Crypt/Random.pm6#L5-L6
Seem to use :if as an adverb for selectively importing modules.
Suggestions
Check out its usage, and document it.

It does not seem to be in the Synopsis

It's using if, a very clever module from the ecosystem. Might be interesting to document it anyway, since it adds a small twist to the usual syntax.

If it's using an ecosystem module, then we can close this ticket.


Add option pool_lifetime option to ldap

This patch adds another option to the ldap connection. Next to the other pool
connections, it is now possible to set the pool_lifetime.
Some LDAP Server abandon connections after some time without notifying the client. This option allow to set a maximal pool lifetime, to also close connections on the client.
All Submissions:

[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[x] Have you added an explanation of what problem you are trying to solve with this PR?
[x] Have you added information on what your changes do and why you chose this as your solution?
[x] Have you written new tests for your changes?
[x] Does your submission pass tests?
[x] This project follows PEP8 style guide.

I tested this PR rebased onto  v8.0.1 and found no issues. Thank you for this nice commit.

@shaardie Would you have time to add a test for this functionality? The limited testing we have for the LDAP attribute store is in tests/satosa/micro_services/test_ldap_attribute_store.py. It would be great to see the tests evolve.

@shaardie Would you have time to add a test for this functionality? The limited testing we have for the LDAP attribute store is in tests/satosa/micro_services/test_ldap_attribute_store.py. It would be great to see the tests evolve.

Yes, I can not see that the other parameter used in the ldap3 connection are tested. Otherwise I would have just followed the test strategy and extended it. I think this is a more general problem in this microservice and should be tackled outside of the scope of this particular Pull Request.
Unfortunately, I will not have time the next weeks to write such tests.
But explicitly for this parameter: We are running this already successful  in production for quite some time.

Any update here? This PR is approved for quite some time now.

Hej @skoranda,
I added a test to test different configs set on the ldap3.Connection including the new introduced pool_lifetime.
I am not an expert in writing tests for Python code. Is this sufficient?
If yes, I maybe try to add tests for the other ldap PR I wrote.

@shaardie just a quick note to let you know I saw this and will try to get to it in the next two weeks. Thanks.

Any progress on this one?


AWS chart data

AWS chart data should be pulling data from cost not the old total property.
Fixes https://github.com/project-koku/koku-ui/issues/693
Historical charts:

AWS overview:

Codecov Report

Merging #696 into master will increase coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #696      +/-   ##
==========================================
+ Coverage   79.92%   79.98%   +0.05%
==========================================
  Files         221      221
  Lines        3378     3378
  Branches      542      542
==========================================
+ Hits         2700     2702       +2
+ Misses        599      597       -2
  Partials       79       79

Impacted Files
Coverage Δ

src/components/charts/commonChart/chartUtils.ts
75.4% <100%> (ø)
:arrow_up:

src/components/charts/trendChart/trendChart.tsx
72.04% <0%> (+1.07%)
:arrow_up:

...arts/historicalTrendChart/historicalTrendChart.tsx
73.8% <0%> (+1.19%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cc7ce3...824d914. Read the comment docs.


Improve screen view auto tracking accuracy by excluding irrelevant view controllers

Is your feature request related to a problem? Please describe.
SnowPlow library tracks the transition between screens in iOS apps by swizzling viewDidAppear and sending information about the previous and next controller. However, this approach is causing issues because UIViewController is a superclass of many classes that should not be tracked, such as UIPredictionViewController, UISystemInputAssistantViewController, UICompatibilityInputViewController, and our own internal reusable components. These classes are sending information about themselves, which is unnecessary and generates the "Not a screen!" error message instead of indicating which screen it is.
Although upon the release of the 5.0 version this has been resolved for the controllers that don't start with the main bundle path:
https://github.com/snowplow/snowplow-ios-tracker/blob/9e66ffc59465529b85138179e6ed707c3393ddef/Sources/Core/ScreenViewTracking/UIKitScreenViewTracking.swift#L69-L76
Describe the solution you'd like
We have been using this tracker since the 1.6.0 version. In the past this behavior was prevented from happening by swizzling the old SPTracker.track method checking the SPEvent SPScreenView data. This was possible since the class was publicly available. However, this was not an option on upgraded the next versions so we bypassed it again by swizzling the NotificationCenter.post(name:object:userInfo:) method.
The SnowPlow library should only track the transition between screens that are relevant to the app or client and exclude those that don't want to be tracked.
Describe alternatives you've considered
With the introduction of plugins in the latest release, there was hope to replace the swizzling with it. However, the current design for plugins are to add more information to events rather than applying filters.
So we came up with this alternatives:
Alternative 1: Add the ability to create plugins that could filter screen view events.
Alternative 2: Add the ability to exclude certain view controller classes from being tracked by injecting a closure, protocol or method to replace the bundle check and add freedom to the client to create a custom filter.
https://github.com/snowplow/snowplow-ios-tracker/blob/9e66ffc59465529b85138179e6ed707c3393ddef/Sources/Core/ScreenViewTracking/UIKitScreenViewTracking.swift#L72-L76
Additional context
This issue is affecting our app's tracking accuracy and causing confusion in interpreting the tracking data. It would be helpful to add a way to exclude the relevant view controller classes from tracking to avoid this issue.
Thanks

We have been analyzing the events that contain a 'Not a screen!' and we have seen that we have a large quota of view controllers reported that we are not interested in. Some examples would be navigation controllers that trigger the viewDidAppear, other reusable components like bottom sheets and so on.

Do you want to further filter view controllers to track within the main bundle?

Yes, that would fit my request, but being free to decide to include or not could depend on the client too. Maybe the main bundle filtering could fit as a default behavior? 🤔

Release 5.2.0 now adds the ability to filter events using plugins – this enables you to filter out the unwanted events using a custom tracker plugin (see docs here). Hope that helps! Please feel free to reopen the issue in case this does not solve the problem.

Thank you for notifying me about the latest release 5.2.0. I tested the new feature using plugins, and I'm pleased to inform you that it works flawlessly.
Thank you for addressing the issue and providing a solution that works perfectly.


[#141] reproducible inversions

closes #141
adds these methods to the API:

NZSHM22_AbstractInversionRunner.setRepeatable(boolean repeatable)
NZSHM22_AbstractInversionRunner.setSelectionIterations(long iterations) This shadows selectionInterval when set
NZSHM22_AbstractInversionRunner.setInversionAveragingIterations(Integer iterations)

merged


App chart fixes/improvements for api-spec

Towards https://github.com/giantswarm/giantswarm/issues/7349

This is now running in a cluster for test purposes. See https://github.com/giantswarm/tenant-cluster-installations/pull/40 for the app manifest.


Test comment counter

Hi Sir :wave:
I have done some work in the branch which is described below :+1:

[ ] Add mock comments js file
[ ] Add 4 tests code in the counter.test.js file

Good job on your code! It's time to merge it!


Implementation of sidebar component.

Components that require updating:

Sidebar- a new component

Tech to be used:

Next.js
React
Typescript

What is the expected deliverable:
Take the proof of concept (HTML/CSS) and implement it. This means take it from static and add React. Build it to be modular and without dependencies on other components.
Justification: vital component

@lloan, my component from #52, already implemented much of React. I misunderstood how the tasks would be broken up. I think this can be "unblocked."
If you think it's ok, I can make a new branch and continue to add mobile support and some knobs to storybook (for example, to toggle the menu on mobile). I can add a close button inside of the sidebar for mobile.
I don't think this will take more than a few hours (most of that for handling the submenus on mobile).

This works fine @Maxbrain0 - only reason I split them up is in case we had people who only wanted to build the static version of it. But this sounds great.
Thanks!

@JacobSNGoodwin this is done right? Anything else you are working on for this component? Otherwise, let's mark it closed and move it to completed. Thanks a ton!

@lloan, Yeah, it's done. Maintaining the scroll state was the only upgrade I didn't get to.


How to revoke certificate

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:
/kind bug
/kind feature

Is there any way to use cert-manager to revoke an issued certificate? We got a certificate which has a wrong alternative name in it due to a copy 'n paste error of the ingress description and would like to revoke that.

Hi @christianhuening, no, just delete the certificate and issue a new one with the correct details. If you delete all copies of the private key, then the certificate is truly gone. Only if you suspect the private key has been copied by others do you need to actively revoke it.
Even then, revoking is mostly pointless, since certificate revocation has shown to not work well at Internet scale, since it relies on everyone on the Internet maintaining and/or check a global pool of revoked certificates. And none of the ideas to fix that have worked. Instead, systems like Let's Encrypt rely on issuing certificates for a short period of time (90 days), so that a compromised certificate quickly expires.

@whereisaaron thanks! worked great!

Will users get expiration email notification for the deleted certificates if they are not revoked?

@ZhiminXiang Yes, until the deleted certificates expire or the user unsubscribes (Presently this is a global action and would unsubscribe from all certificate expiration warnings for the issuing ACME account).


Problems with versions

Hello!
I am having trouble finding the correct versions for each python package. I am currently using these:

PyTorch 0.3.1 (torch-0.3.1-cp27-cp27mu-linux_x86_64)
TorchVision 0.2.1

Are these the correct versions?

Yes, PyTorch 0.3.1 works fine with TorchVision 0.2.1

Also, for anyone interested:

You can find pytorch 0.3.1 compiled with cuda 90 at https://download.pytorch.org/whl/cu90/torch/
torchvision 0.2.0 cuda 90 at  https://download.pytorch.org/whl/torchvision/ (direct link https://download.pytorch.org/whl/torchvision-0.2.0-py2.py3-none-any.whl)


permissions error

Sorry for the simple question, but when I try to clone using
git clone git@github.com:kenperlin/chalktalk.git --depth=1
I get a permissions error.  Not a frequent user of git, so perhaps a simple fix for this?
thanks
Steve Lewis

git clone https://github.com/kenperlin/chalktalk.git --depth=1 is the correct command. I will update the wiki.

Thanks.  That seemed to work for the cloning, but the cd and install
generated these errors.
Thanks for any further help.
Steve
Last login: Wed Nov  8 12:27:03 on ttys000
Stephens-MacBook-Air-2:~ steve$ https://github.com/kenperlin/chalktalk.git
--depth=1
-bash: https://github.com/kenperlin/chalktalk.git: No such file or directory
Stephens-MacBook-Air-2:~ steve$ git clone
https://github.com/kenperlin/chalktalk.git --depth=1
Cloning into 'chalktalk'...
remote: Counting objects: 195, done.
remote: Compressing objects: 100% (190/190), done.
remote: Total 195 (delta 5), reused 51 (delta 2), pack-reused 0
Receiving objects: 100% (195/195), 8.46 MiB | 13.30 MiB/s, done.
Resolving deltas: 100% (5/5), done.
Checking connectivity... done.
Stephens-MacBook-Air-2:~ steve$ cd ./chalktalk/server/
Stephens-MacBook-Air-2:server steve$ npm install
Error: Cannot find module './lib/cookies'
at Function.Module._resolveFilename (module.js:326:15)

at Function.Module._load (module.js:277:25)

at Module.require (module.js:354:17)

at require (internal/module.js:12:17)

at Object.<anonymous>

(/usr/local/lib/node_modules/npm/node_modules/request/index.js:18:29)
at Module._compile (module.js:410:26)

at Object.Module._extensions..js (module.js:417:10)

at Module.load (module.js:344:32)

at Function.Module._load (module.js:301:12)

at Module.require (module.js:354:17)

at require (internal/module.js:12:17)

npm ERR! Darwin 14.5.0
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "install"
npm ERR! node v4.2.6
npm ERR! npm  v2.14.12
npm ERR! code MODULE_NOT_FOUND
npm ERR! Cannot find module './lib/cookies'
npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR!     https://github.com/npm/npm/issues
Stephens-MacBook-Air-2:server steve$ cd ./chalktalk/server
-bash: cd: ./chalktalk/server: No such file or directory
Stephens-MacBook-Air-2:server steve$ ls
editor.html main.js npm-debug.log package.json
Stephens-MacBook-Air-2:server steve$ cd ../chalktalk/server
-bash: cd: ../chalktalk/server: No such file or directory
Stephens-MacBook-Air-2:server steve$ cd chalktalk
-bash: cd: chalktalk: No such file or directory
Stephens-MacBook-Air-2:server steve$ cd..
-bash: cd..: command not found
Stephens-MacBook-Air-2:server steve$ ls
editor.html main.js npm-debug.log package.json
Stephens-MacBook-Air-2:server steve$ npm install
Error: Cannot find module './lib/cookies'
at Function.Module._resolveFilename (module.js:326:15)

at Function.Module._load (module.js:277:25)

at Module.require (module.js:354:17)

at require (internal/module.js:12:17)

at Object.<anonymous>

(/usr/local/lib/node_modules/npm/node_modules/request/index.js:18:29)
at Module._compile (module.js:410:26)

at Object.Module._extensions..js (module.js:417:10)

at Module.load (module.js:344:32)

at Function.Module._load (module.js:301:12)

at Module.require (module.js:354:17)

at require (internal/module.js:12:17)

npm ERR! Darwin 14.5.0
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "install"
npm ERR! node v4.2.6
npm ERR! npm  v2.14.12
npm ERR! code MODULE_NOT_FOUND
npm ERR! Cannot find module './lib/cookies'
npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR!     https://github.com/npm/npm/issues
Stephens-MacBook-Air-2:server steve$
On Wed, Nov 8, 2017 at 1:01 PM, Karl Toby Rosenberg <
<EMAIL_ADDRESS>wrote:

git clone https://github.com/kenperlin/chalktalk.git --depth=1 is the
correct command. I will update the wiki.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/kenperlin/chalktalk/issues/34#issuecomment-342902391,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJA2rXMOwYB9fXjsksesfbHSZJRXoKWpks5s0eyAgaJpZM4QWyS6
.

Is Nodejs installed? https://nodejs.org/en/

Thanks.  I thought I had it installed, but must have removed it for some
reason, or I had an older version?  Anyway, it now runs, thanks
Still have to get acquainted with the operation of the program itself.  Are
there any online interactive working demos or local ones I could install?
Did I miss that?
On Wed, Nov 8, 2017 at 1:12 PM, Karl Toby Rosenberg <
<EMAIL_ADDRESS>wrote:

Is Nodejs installed? https://nodejs.org/en/
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kenperlin/chalktalk/issues/34#issuecomment-342905527,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJA2rZb9CjhCvcaTHUUeJP-TShnSAJ97ks5s0e77gaJpZM4QWyS6
.

We haven't created interactive demos yet, but pressing Space within Chalktalk toggles help mode, which shows what gestures and options are available. (That can be helpful for beginners.) We are actively thinking about and experimenting with ways to improve the first-time use experience. As for sketch creation, take a look at this wiki page and this starter file, which should help if you want to try playing with making sketches.


tuner.scale_batch_size() to update DataModule hparams

What does this PR do?
Updates DataModule hparams for tuner.scale_batch_size()
Fixes 12768
Does your PR introduce any breaking changes? If yes, please list them.
No
Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes? (if necessary)
[ ] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[ ] Did you list all the breaking changes introduced by this pull request?
[ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

[ ] Is this pull request ready for review? (if not, please submit in draft mode)
[ ] Check that all items from Before submitting are resolved
[ ] Make sure the title is self-explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃

@awaelchli I have tried this, without touching the _lightning_get_all_attr_holders, and this seems to work.

This looks great! Would you mind extending the test test_auto_scale_batch_size_set_model_attribute in tests/tuner/test_scale_batch_size.py with a call to self.save_hyperparameters in the datamodule and adding the necessary assertion?

@awaelchli sure

Hi @tanmoyio! Thanks for working on this!
Here's the TODO list in this PR!

[ ] Add a changelog entry
[ ] Extend the existing test to cover the change of this PR (https://github.com/PyTorchLightning/pytorch-lightning/pull/12806#issuecomment-1107933705)

Let us know if you need help!

@akihironitta I have added the unit tests, let me know if I need to modify anything, then I modify the changelog when everything is ready to go.

@tanmoyio Would you mind having a look at the test failures? Also, could you update the changelog?

@akihironitta sorry, I should have done that earlier, will take a look into that.

@akihironitta is it fine now ?

I think this PR needs some more work.

What if batch_arg_name is different in model and datamodule?
What if the argname is not present in both datamodule and model?
Maybe a few more edge cases...

do you want to work on it or I can push updates? @tanmoyio

@rohitgr7
Alright, these are the probable scenarios I can think of, for hparams

batch_size is present in both
batch_size is present in one of datamodule/model
batch_size is present in none of datamodule/model
what if batch_arg_name is different in both model/datamodule
what if batch_arg_name is same in both model/datamodule but not batch_size

I will work on the PR, let me know if there is anything else I need to include

@tanmoyio
we should not consider batch_size anywhere and only rely on batch_arg_name for all the cases.


Need a test reporter with visual diffing

@nkbt
Comparing a collection with another one is a bit tedious and looks like this currently:

Ideally we'd have a visual diff of the collection. But I kinda don't want to lose the nyan cat (yeah really) lol, is there something we could do here?

Yeah, I found it quite not fun for myself either recently but did not have a chance to look at the solution.

Fixed by #194


Fix double-decoding QP.

The code copies all email-headers unchanged and unfiltered, so it must
copy the body unchanged, too.
Otherwise a double-decoding of the body will occur, which leads to
stripped trailing equal-signs (because they are considered "soft line
breaks" in compliance with RFC 2045, Section 6.7, paragraph 5).

ping.
I don't know what makes travis fail all the jobs for this PR (https://travis-ci.org/jkraemer/mail-gpg/builds/337298149) but to me it looks like my code-changes are not the problem. Am I right? Otherwise please tell me!

Thanks and sorry for the delay. Re travis - the pass phrase setting does not seem to work in this environment, thats why it always fails.

Could this go into a release, soon?

Ping...

Done :)

Yeah, thank you! :)