Sorry, couldn't find lyrics for this song!

First I got the #71 issue. When replaced the files it worked for one or two songs and now i'm getting:
"Sorry, couldn't find lyrics for this song!" for all songs...

I have the same problem. Initially, I obtained #71 issue. Then, replacing the files, this problem was solved, but a new problem appeared: every song (title and artist) is truly recognized, but it doesn't show any lyrics. "Sorry, couldn't find lyrics for this song!"

Exactly the same problem here, running on Ubuntu 16.04 64

same issue here. Any fix yet?

I have the same problem on Windows x64 and I really miss the app :(

i hace same problem! :(

same problem here... Linux-x64

same here - osx Sierra

hun, something is wrong with all the /
In my case the url is:
http://www.musixmatch.com/u002Flyrics/u002FQueensr%C3%BFche/u002FSuite-Sister-Mary-2003-Digital-Remaster
When it should be:
http://www.musixmatch.com/lyrics/Queensr%C3%BFche/Suite-Sister-Mary-2003-Digital-Remaster

Unicode number 0002 is the "Start of text" character, there must be an issue with the URL generated. Will have to look at the code to figure out where this is happening.
Source:  https://unicode-table.com/en/search/?q=0002

So any fix yet?

The MusicMatch scraper no longer works, seemingly due to their limited free plan. Author also took down the MusicMatch dependency, but somehow the latest code is still not released yet.
So easiest way to fix this is to overwrite the search module with the latest code like what we did in #71 . Simply replace the original files in yourlyricfierfolder/resources/app/render/ by the ones below.
fix_lyrics_not_found.zip

OMG, IT WORKS!!! Thank you @tienthanh8490 !!!!

Just works!

It definitely works! Thanks @tienthanh8490

Thanks @tienthanh8490, worked perfectly!

Perfect! Thanks @tienthanh8490

It works, Thanks @tienthanh8490

Could you please try last release?
https://github.com/emilioastarita/lyricfier/releases/tag/0.2.6
thx!

@emilioastarita The new version crashed on first start. Seems to be compatibility issue with macOS latest version. This is the log I got.
Process:               lyricfier [78104]
Path:                  /Volumes/VOLUME/*/lyricfier.app/Contents/MacOS/lyricfier
Identifier:            com.electron.lyricfier
Version:               0.2.6 (0.2.6)
Code Type:             X86-64 (Native)
Parent Process:        ??? [1]
Responsible:           lyricfier [78104]
User ID:               501

Date/Time:             2017-10-04 23:31:24.121 +0800
OS Version:            Mac OS X 10.12.6 (16G29)
Report Version:        12
Anonymous UUID:        152DE4D8-4308-178D-E6F2-EFD343D92F89

Sleep/Wake UUID:       C57232AF-AA17-4210-A563-04A30DD59DF3

Time Awake Since Boot: 1800000 seconds
Time Since Wake:       240 seconds

System Integrity Protection: enabled

Notes:                 Translocated Process

Crashed Thread:        0

Exception Type:        EXC_CRASH (SIGABRT)
Exception Codes:       0x0000000000000000, 0x0000000000000000
Exception Note:        EXC_CORPSE_NOTIFY

Termination Reason:    DYLD, [0x1] Library missing

Application Specific Information:
dyld: launch, loading dependent libraries

Dyld Error Message:
  Library not loaded: @rpath/Electron Framework.framework/Electron Framework
  Referenced from: /Volumes/VOLUME/*/lyricfier.app/Contents/MacOS/lyricfier
  Reason: image not found

Binary Images:
       0x103d7e000 -        0x103d7eff7 +com.electron.lyricfier (0.2.6 - 0.2.6) <107BF4A4-1BF7-306B-944D-7DED190A60FE> /var/folders/*/lyricfier.app/Contents/MacOS/lyricfier
       0x108ed9000 -        0x108f16dc7  dyld (433.5) <322C06B7-8878-311D-888C-C8FD2CA96FF3> /usr/lib/dyld

Model: MacBookPro12,1, BootROM MBP121.0167.B33, 2 processors, Intel Core i5, 2.9 GHz, 16 GB, SMC 2.28f7
Graphics: Intel Iris Graphics 6100, Intel Iris Graphics 6100, Built-In
Memory Module: BANK 0/DIMM0, 8 GB, DDR3, 1867 MHz, 0x80AD, 0x483943434E4E4E434C544D4C41522D4E5544
Memory Module: BANK 1/DIMM0, 8 GB, DDR3, 1867 MHz, 0x80AD, 0x483943434E4E4E434C544D4C41522D4E5544
AirPort: spairport_wireless_card_type_airport_extreme (0x14E4, 0x133), Broadcom BCM43xx 1.0 (<IP_ADDRESS>.1a1)
Bluetooth: Version 5.0.5f1, 3 services, 27 devices, 1 incoming serial ports
Network Service: Wi-Fi, AirPort, en0
Serial ATA Device: APPLE SSD SM0256G, 251 GB
USB Device: USB 3.0 Bus
USB Device: Card Reader
USB Device: Bluetooth USB Host Controller
Thunderbolt Bus: MacBook Pro, Apple Inc., 27.1

@tienthanh8490 thanks for reporting. I think that the problem have to do with the build. I rebuilded with newer versions of the packager. Could you please re-download the new zip? If it fails I will try with a mac tomorrow.

@emilioastarita It still fail, similar error. Let me know if anything I can help.

@tienthanh8490 thanks for testing. Maybe could you try running yarn install (or npm) and then yarn run start. If that works also could be useful that you try produce the build yourself with yarn run dist. Let me know if you have any problem with this commands.

@emilioastarita Just tried building with npm, it works for the first song, then when I change to another song it crashed. Seems like a v8 error ?
[80614:1005/012247.715625:FATAL:partition_alloc.cc(934)] Check failed: page->num_allocated_slots != -1.
0   Electron Framework                  0x000000010686f43c crashpad::CloseMultipleNowOrOnExec(int, int) + 970204
1   Electron Framework                  0x0000000106836c53 crashpad::CloseMultipleNowOrOnExec(int, int) + 738803
2   Electron Framework                  0x000000010684e6b1 crashpad::CloseMultipleNowOrOnExec(int, int) + 835665
3   Electron Framework                  0x00000001094eaa9c crashpad::CloseMultipleNowOrOnExec(int, int) + 47612988
4   libnode.dylib                       0x000000010af23021 v8::internal::DeferredHandles::Iterate(v8::internal::ObjectVisitor*) + 19633
5   libnode.dylib                       0x000000010b3ad179 v8::internal::AllocationSpaceName(v8::internal::AllocationSpace) + 21993
6   libnode.dylib                       0x000000010b3bb2d0 v8::internal::AllocationSpaceName(v8::internal::AllocationSpace) + 79680
7   libnode.dylib                       0x000000010b3adf70 v8::internal::AllocationSpaceName(v8::internal::AllocationSpace) + 25568
8   libnode.dylib                       0x000000010b3a6717 v8::internal::operator<<(std::__1::basic_ostream<char, std::__1::char_traits<char> >&, v8::internal::MachineType) + 73127
9   libnode.dylib                       0x000000010b3a430e v8::internal::operator<<(std::__1::basic_ostream<char, std::__1::char_traits<char> >&, v8::internal::MachineType) + 63902
10  libnode.dylib                       0x000000010b1c1aa3 v8::internal::Heap::CreateFillerObjectAt(unsigned char*, int, v8::internal::ClearRecordedSlots) + 7555
11  libnode.dylib                       0x000000010b1c02d5 v8::internal::Heap::CreateFillerObjectAt(unsigned char*, int, v8::internal::ClearRecordedSlots) + 1461
12  libnode.dylib                       0x000000010b1bf813 v8::internal::DeferredHandleScope::Detach() + 110595
13  libnode.dylib                       0x000000010b1ce7be v8::internal::Heap::CreateFillerObjectAt(unsigned char*, int, v8::internal::ClearRecordedSlots) + 60062
14  libnode.dylib                       0x000000010b26cec6 v8::internal::IdentityMapBase::NextIndex(int) const + 950
15  Electron Framework                  0x000000010687ffc1 crashpad::CloseMultipleNowOrOnExec(int, int) + 1038689
16  Electron Framework                  0x000000010948c07f crashpad::CloseMultipleNowOrOnExec(int, int) + 47225375
17  Electron Framework                  0x000000010948a0d2 crashpad::CloseMultipleNowOrOnExec(int, int) + 47217266
18  Electron Framework                  0x000000010687ffc1 crashpad::CloseMultipleNowOrOnExec(int, int) + 1038689
19  Electron Framework                  0x000000010684837b crashpad::CloseMultipleNowOrOnExec(int, int) + 810267
20  Electron Framework                  0x00000001068486cc crashpad::CloseMultipleNowOrOnExec(int, int) + 811116
21  Electron Framework                  0x0000000106848a83 crashpad::CloseMultipleNowOrOnExec(int, int) + 812067
22  Electron Framework                  0x000000010684bf0a crashpad::CloseMultipleNowOrOnExec(int, int) + 825514
23  Electron Framework                  0x00000001067fb0ca crashpad::CloseMultipleNowOrOnExec(int, int) + 494186
24  Electron Framework                  0x000000010684b92f crashpad::CloseMultipleNowOrOnExec(int, int) + 824015
25  CoreFoundation                      0x00007fff81415321 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
26  CoreFoundation                      0x00007fff813f621d __CFRunLoopDoSources0 + 557
27  CoreFoundation                      0x00007fff813f5716 __CFRunLoopRun + 934
28  CoreFoundation                      0x00007fff813f5114 CFRunLoopRunSpecific + 420
29  Foundation                          0x00007fff82e08252 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 277
30  Electron Framework                  0x000000010684c5ae crashpad::CloseMultipleNowOrOnExec(int, int) + 827214
31  Electron Framework                  0x000000010684bd6c crashpad::CloseMultipleNowOrOnExec(int, int) + 825100
32  Electron Framework                  0x000000010684804e crashpad::CloseMultipleNowOrOnExec(int, int) + 809454
33  Electron Framework                  0x0000000106861183 crashpad::CloseMultipleNowOrOnExec(int, int) + 912163
34  Electron Framework                  0x00000001071b0c1c crashpad::CloseMultipleNowOrOnExec(int, int) + 10675644
35  Electron Framework                  0x0000000106a1d68b crashpad::CloseMultipleNowOrOnExec(int, int) + 2732075
36  Electron Framework                  0x00000001084dee18 crashpad::CloseMultipleNowOrOnExec(int, int) + 30787512
37  Electron Framework                  0x0000000106a1c8e4 crashpad::CloseMultipleNowOrOnExec(int, int) + 2728580
38  Electron Framework                  0x00000001065fa90a AtomMain + 74
39  Electron Helper                     0x00000001065f1f26 main + 38
40  libdyld.dylib                       0x00007fff96b75235 start + 1
41  ???                                 0x0000000000000011 0x0 + 17

Yes it seems a problem with the v8 bundled in electron (1.8.1). I downgraded to 1.7.8. Could you try again with last commit:
git pull
npm install
npm run start

@emilioastarita Yea 1.7.8 seems to be more stable - it stopped crashing.
Just a minor issue - when I switch to an instrumental song (no lyric found), there is an uncaught exception
Uncaught TypeError: Cannot read property 'lyric' of null
    at searcher.search (/Users/thanhnguyen/lyricfier/render/SongRender.js:60:31)
    at async.parallel (/Users/thanhnguyen/lyricfier/render/Searcher.js:41:17)
    at /Users/thanhnguyen/lyricfier/node_modules/async/dist/async.js:3861:9
    at /Users/thanhnguyen/lyricfier/node_modules/async/dist/async.js:421:16
    at iteratorCallback (/Users/thanhnguyen/lyricfier/node_modules/async/dist/async.js:998:13)
    at /Users/thanhnguyen/lyricfier/node_modules/async/dist/async.js:906:16
    at /Users/thanhnguyen/lyricfier/node_modules/async/dist/async.js:3858:13
    at callback (/Users/thanhnguyen/lyricfier/node_modules/async/dist/async.js:4261:17)
    at plugin.search (/Users/thanhnguyen/lyricfier/render/Searcher.js:26:32)
    at Request.doReq [as _callback] (/Users/thanhnguyen/lyricfier/render/plugins/Genius.js:28:17)

Thanks i've fixed that. I will prepare another release soon

@tienthanh8490 when you have some time could you please try the mac new release ? thx!

Hi, the new Mac version is crashing too. I provide you the log:
Process:               lyricfier [15203]
Path:                  /private/var/folders/*/lyricfier.app/Contents/MacOS/lyricfier
Identifier:            com.electron.lyricfier
Version:               0.2.7 (0.2.7)
Code Type:             X86-64 (Native)
Parent Process:        ??? [1]
Responsible:           lyricfier [15203]
User ID:               501
Date/Time:             2017-10-04 23:57:54.081 +0200
OS Version:            Mac OS X 10.12.6 (16G29)
Report Version:        12
Anonymous UUID:        EF446C4F-6390-F4D1-A728-B7372929CAE8
Time Awake Since Boot: 31000 seconds
System Integrity Protection: enabled
Notes:                 Translocated Process
Crashed Thread:        0
Exception Type:        EXC_CRASH (SIGABRT)
Exception Codes:       0x0000000000000000, 0x0000000000000000
Exception Note:        EXC_CORPSE_NOTIFY
Termination Reason:    DYLD, [0x1] Library missing
Application Specific Information:
dyld: launch, loading dependent libraries
Dyld Error Message:
Library not loaded: @rpath/Electron Framework.framework/Electron Framework
Referenced from: /private/var/folders/*/lyricfier.app/Contents/MacOS/lyricfier
Reason: image not found
Binary Images:
0x1046cf000 -        0x1046cfff7 +com.electron.lyricfier (0.2.7 - 0.2.7) <107BF4A4-1BF7-306B-944D-7DED190A60FE> /var/folders/*/lyricfier.app/Contents/MacOS/lyricfier
0x10de79000 -        0x10deb6dc7  dyld (433.5) <322C06B7-8878-311D-888C-C8FD2CA96FF3> /usr/lib/dyld

@fjpalacios thanks for reporting. I've uploaded a new version. Could you please try this one? Sorry but I don't have a mac to test before releasing. Thanks!

Hi. This version is now working for me on Windows 10. Thank you so much :)

@emilioastarita Just tested, latest version seems stable enough for release. Thanks! (Y)

@emilioastarita yep, the latest release works like a charm for me too. Thanks!

thanks to all testers! I'm closing this issue.


Ability to provision out of band OAuth clients

Need a REST API to provision out of band OAuth clients.
Refer: https://wso2.org/jira/browse/APIMANAGER-5716

This is fixed in APIM 3.0.0


svg.call(d3.zoom().on('zoom',function(){})) warning : Argument of type 'ZoomBehavior<Element, unknown>' is not assignable to parameter of type '(selection: Selection<BaseType, unknown, HTMLElement, any>, ...args: any[]) => void'.

typescript verison 4.3.5
d3 version 7.1.0
code:
svg.call(d3.zoom().on('zoom',function(){}))
typescript warning:
Argument of type 'ZoomBehavior<Element, unknown>' is not assignable to parameter of type '(selection: Selection<BaseType, unknown, HTMLElement, any>, ...args: any[]) => void'.
Types of parameters 'selection' and 'selection' are incompatible.
Type 'Selection<BaseType, unknown, HTMLElement, any>' is not assignable to type 'Selection<Element, unknown, any, any>'.
Types of property 'select' are incompatible.
Type '{ (selector: string): Selection<DescElement, unknown, HTMLElement, any>; (selector: null): Selection<null, undefined, HTMLElement, any>; (selector: ValueFn<...>): Selection<...>; }' is not assignable to type '{ (selector: string): Selection<DescElement, unknown, any, any>; (selector: null): Selection<null, undefined, any, any>; (selector: ValueFn<...>): Selection<...>; }'.
Types of parameters 'selector' and 'selector' are incompatible.
Types of parameters 'groups' and 'groups' are incompatible.
Type 'BaseType[] | ArrayLike' is not assignable to type 'Element[] | ArrayLike'.
Type 'BaseType[]' is not assignable to type 'Element[] | ArrayLike'.
Type 'BaseType[]' is not assignable to type 'Element[]'.
Type 'BaseType' is not assignable to type 'Element'.ts(2345)

What is svg? It should be a d3 selection.

const svg = d3.select('svg')
use this code resolve it。
const svg = d3.select('svg') function zoomed (event: any) {   console.log(event) } const zoom = zoom().on('zoom', zoomed) as any svg.call(zoom)

What is svg? It should be a d3 selection.

What is svg? It should be a d3 selection.
const svg = d3.select('svg')

use this code resolve it.
const svg = d3.select('svg') function zoomed (event: any) {   console.log(event) } const zoom = zoom().on('zoom', zoomed) as any svg.call(zoom)

What is svg? It should be a d3 selection.
const svg = d3.select('svg')

use this code resolve it. const svg = d3.select('svg') function zoomed (event: any) { console.log(event) } const zoom = zoom().on('zoom', zoomed) as any svg.call(zoom)

While it solved the problem, this is not a good idea, using as any is essentially the same as turning off TypeScript


[BugFix] Fix potential race condition of compaction manager

What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #14339
Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[x] 2.5
[ ] 2.4
[ ] 2.3
[ ] 2.2

run starrocks_admit_test

@Mergifyio backport branch-2.5


:manage_home in user resource should check ownership

Description
If a home directory exists on a host, but is owned by the wrong user, :manage_home should correct it- at least optionally. The use case here is hosts that have users temporarily. In my case, human users may exist on production hosts for emergencies, but must then be removed. If the users are re-added later with different UIDs (which may happen because people leave/join the company and the UIDs aren't being directly managed,) ownership gets all screwy.
Chef Version
Chef: 12.11.18
Platform Version
Amazon Linux AMI release 2016.03
Replication Case
Create a user on a host with the "user" resource and :manage_home. Delete the user (and remove the role or recipe that adds it.) Create a new user with the same UID as the old one, then recreate the user with the "user" resource again.
Client Output
(not relevant)
Stacktrace
(not relevant)
NOTE: CHEF CLIENT BUGS ONLY
(not relevant)

the workaround here is for the cookbook to manually delete the homedir -- the 'bug' here isn't with the user provider implementation but that utils like userdel -r will flat out refuse to remove the homedir if its not owned by the user.   it seems like this could also be avoided by consistently using manage_home on all the resources that remove/add users.
not a high priority since there's a workaround.
i can see where this is a 'gotcha' with the user resource and that the underlying userdel/usermod/useradd utilities are annoyingly non-declarative.


isAccessTokenExpired seems to behave differently from v2.2 to 2.10

I upgraded  from "google/apiclient": "2.2.2", to "google/apiclient": "2.10.1".  in my code curl call, I have been doing a refresh token.
public function refreshToken()
    {
        if ($this->googleClient->isAccessTokenExpired() || empty($this->oauth2Token)) {
            $result = $this->googleClient->fetchAccessTokenWithAssertion();
            if (!isset($result['access_token'])) {
                throw new \Exception('unexpected response: ' . json_encode($result));
            }
            $this->oauth2Token = $result['access_token'];
        }
        return $this->oauth2Token;
    }

Either \Google\Client::isAccessTokenExpired is not returning true
Or \Google\Client::fetchAccessTokenWithAssertion is not returning a token.
Once my process hit the hour mark, I get
{"error":{"code":401,"message":"Request had invalid authentication credentials.
Expected OAuth 2 access token, login cookie or other valid authentication credential.
See https://developers.google.com/identity/sign-in/web/devconsole-project.","status":"UNAUTHENTICATED"}}

The code will creates a new token in google/apiclient": "2.2.2"

@LindaLawton Thank you.  It's not a big deal.  But It use to be possible to check isAccessTokenExpired().
This is how  i create my client
/**
     * @return \Google_Client
     * @throws \Google_Exception
     */
    public function getClient()
    {
        if (empty($this->client)) {
            $gmbConfig = $this->settings;
            // check if json file exist
            if (!$gmbConfig) {
                throw new \Exception("Could not read environment configuration.");
            }

            $this->client = new \Google_Client([
                'retry' => [
                    // this is how many times it will try after initial attempt
                    // total will be first attempt + retries (in this case 5 attempts)
                    'retries' => 4
                ]
            ]);
            $this->client->setSubject($gmbConfig['userToImpersonate']);
            $this->client->setScopes($gmbConfig['scope']);
            $this->client->setAuthConfig($gmbConfig['authJson']);
            $this->client->setAccessType("offline");
            $this->client->setApprovalPrompt("force");
            $this->apiUrl = $gmbConfig['apiUrl'];
        }

        return $this->client;
    }

This token is only good for 360 seconds with "google/apiclient": "2.2.2" I could check for token expire and it would return false after an hour. Now it does not return true even after the token expires.  Perhaps we were using  isAccessTokenExpired() incorrectly and getting away with it.  Until we updated the library.


New failing tests for private/missing methods

From our discussion on PR #21, I've pushed a couple of new tests to my test_bad_methods branch. One tries to use a method that doesn't exist and one tries to call a private method.  The current dispatch function currently just returns the object that is passed in.  I didn't submit a pull request, because I'm not sure if my assumptions were right in this case.
The invokeMethod method never gets called, because neither of those will be reported as callable by is_callable() (as of php 5.0.5, is_callable will not return true for private and protected methods).
I tried refactoring the dispatch function to make it work they way I was expecting, but I'm about to run out of battery on this laptop, which is my hard limit for coding on a Friday night.  However, if you simply remove the is_callable in dispatch(), the MethodNotAccessible test no longer fails.

Closed along with #24.


Can't create Plugin

julia> using PkgTemplates: @with_kw_noshow, @plugin, FilePlugin
julia> @plugin struct Changelog <: FilePlugin
           file::String = "CHANGELOG.md"
       end
ERROR: UndefVarError: `PkgTemplates` not defined
Stacktrace:
 [1] top-level scope
   @ ~/.julia/packages/PkgTemplates/LISo2/src/plugin.jl:67

Am I doing something wrong?
Julia Version 1.9.2
[14b8a8f1] PkgTemplates v0.7.38

you need to have:
using PkgTemplates: PkgTemplates, @with_kw_noshow, @plugin, FilePlugin
because the @plugin macro assumed that the PkgTemplates is defined where it is called.
We could fix this by interpolating all the functions generated in the macro, but it would take a bit.


Update to Moto 4.1.2

This PR updates to moto 4.1.2 and relax aws provider version requirements.

This is probably ready but I should test it locally too!

I've now also tested locally with terraform-provider-aws-4.54.0 and terraform13-1.3.8... seems good!


TrackingAPI: returnSignature "true" does not deliver signature image

https://developer.ups.com/api/reference?loc=en_US#operation/getSingleTrackResponseUsingGET!in=query&path=returnSignature&t=request
claims that, if you set returnSignature to "true" signature image is provided. Turns out that shipment.package.deliveryinformation.signature is null. Using the same inquiry number with old XML service provides a pdf.

I'm also experiencing this issue - this seems like a clear regression in API functionality compared to the legacy XML based API.

Same issue here.

@UPSRahul Can we please get some response on this? This is critical functionality.

Hi, since a signature is sensitive, the signature will only be available if the package has a relationship to the account making the Track API call. For further help, please reach out to the UPS Help Desk: https://developer.ups.com/contactus


ExpressInstall, log out/login

Right now after running the expressInstall, when you are done you're given a startZitiController and other helpful functions but if you make a new shell, the functions aren't sourced. Discuss this in the doc.
Consider moving these sorts of functions to the env file that gets sourced/generated

As a workaround while this enhacement proceed, after the expressInstall has finished we can:

Manually download the ziti-cli-functions.sh to the directory created by the expressInstaller
Add a couple lines in the user's .profile, so every new login will source that file

. ~/.ziti/quickstart/$(hostname)/$(hostname).env
source ~/.ziti/quickstart/$(hostname)/ziti-cli-functions.sh
So, every new shell will have the functions associated.


About bybit_perpetual

Describe the bug
Hallow. When i connecting to bybit_perpetual i got error: retcode <10001> accountType only support UNIFIEDaccount.  When connecting to bybit then ok. Got balance.
Steps to reproduce

Load hummingbot
Enter api info
Get error

Release version
2.1.0
Type of installation
Docker
Attach required files
No response

Thanks for the report,
Duplicated with this error
https://github.com/hummingbot/hummingbot/issues/7267


Improve Testing in PR

Looks like GITHUB_TOKEN isn't actually passed in the pipelines, think jx-helpers was actually pulling it from the credentials file or something. Will look into supporting this, but for the time being I'll just add the token as an env var.

Installing Peacock from make in PR to test latest version
Throwing an error if Github token isn't passed

/test peacock-verify

/test verify

/test peacock-verify

Peacock-ception

?

/test peacock-verify


Additional TieringPolicy and ProtectedItemExtendedInfo details for RecoveryServicesBackup

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

@anjorsh You need to update AssemblyInfo.cs, .csproj and AzSDK.Props. See https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/78/Mgmt-.NET-SDK-release-process?anchor=sdk-generation-from-updated-spec

I have updated AssemblyInfo.cs, and .csproj.
I’m not sure about what changes are required in AzSdk.RP.Props. We update this file when we add new API version, but there is no new API version in this PR.


Local Weather

Using Android 5.1 Lollipop on a Kyocera, the local weather location sometimes gets "stuck" for days and won't update to a new location, even though my GPS is working fine. I'm using weather underground for my provider, if that makes any difference. The erroneous location persists regardless of clearing app cache and it doesn't matter if I have enhanced location enabled or disabled.

After clearing all data, re-entering my weather underground API key, and enabling local weather, SimpleWeather now just crashes when trying to get weather for the current location. Because it is now set for that, it also crashes on startup, which means this app is now useless. I did update the app on Thursday evening and that seems to be when the issue started. I'm uninstalling the app now.
BTW,  If your updated app isn't on f-droid, I'll likely not install it again.


Improve readme build guidance

With the bouncycastle pgp stuff, it is now essential to call
source .environment

after changing to the gmd-sdk directory, but prior to running mvn clean install

Also be fore mvn clean test in testing section. Basically before any builds are done need to source the .environment file or specify meaningful values for the variables

This was addressed by #37


Reflection issue in Androids Scene-viewer

Description
Reflection appears not to translate adequately from model-viewer to scene-viewer
We are experiencing issues with the AR experience of 3D models holding reflections (metal like) on Android devices (scene-viewer). iOS (apple-quicklook) works fine.
Trying the URL (https://preview.eyefun.nl/test/reflections/index2.html) leads to results shown as attached.
AR view Android (screenshot): android-scene-viewer.jpg
AR view iOS (screenshot): apple-quicklook.jpg
The AR view on Android devices looks frosted, not as shiny as it should.
Because the model-viewer results are similar on Android and iOS, we think something may go wrong when scene-viewer takes over on Android devices.
Attached you'll find the glb-file, testReflection2.glb
Testing our model on https://arvr.google.com/scene-viewer-preview produces 0 faults.
Any ideas?
Live Demo

https://preview.eyefun.nl/test/reflections/index2.html

Browser Affected

[ ] Chrome
[ ] Edge
[ ] Firefox
[ ] Helios
[ ] IE
[ ] Safari

OS

[x] Android
[ ] iOS
[ ] Linux
[ ] MacOS
[ ] Windows

Versions

model-viewer: v0.10.0
three.js: r??

testReflection2.glb.zip

@eyefun This is a complicated issue. First, model-viewer, scene-viewer and quick-look all use different lighting (we cannot specify lighting to those apps, and they are generally calculating it on the fly with the camera to match your environment, and using heavy approximations).
As for shiny materials looking blurry, beyond the differences in the lighting, there is a known issue with SceneViewer's renderer, Filament, blurring shiny materials, which is especially notable in the khronos-DamagedHelmet comparison here. @tpsiaki

We're running into the same issue with PBR materials. Is there any update to this or best practices for handling this?

Identical issue from 4 months ago: https://stackoverflow.com/questions/60542324/google-model-viewer-no-reflections-on-object-on-android

@judasbenhur Have you tried using the webxr AR mode instead of SceneViewer? WebXR stays in the browser, so it uses the same renderer as the 3D view and keeps all the resources loaded; that'll be the best way to get consistency.
Thanks for pointing me to the SO question; I need to find a way to get notified of those.

@elalish can you point me into the right direction for implementing this webxr AR mode? When you say it stays in the browser, does that mean it'll still be able to be rendered in AR?

@judasbenhur Indeed, WebXR is a new API for in-browser AR & VR. As long as you're using the latest (v1.0) model-viewer and Chrome 83+ on Android, it's already the default AR experience. See https://modelviewer.dev/examples/webxr.html

@elalish Filament's processing of IBLs doesn't explain the difference shown here. It's more likely that the difference (since it's between ARCore and ARKit) is in the generation of the dynamic env map (ARCore provides a 16x16 cubemap, it won't be sharp no matter what).

@romainguy thats 16x16 px I assume? That would explain a lot. Is there any plan to improve this resolution in Scene Viewer?

Yes, it's 16x16px per face.

@elalish whats the best way to verify/test that the viewer stays in the browser? I'm still seeing reflection and brightness mis-matches between model and scene viewer.
I've confirmed to be using version 1.0.0. on a Samsung Galaxy S7 with
Chrome 83.x. I've set the ar mode inside the  element as follows: ar-modes="webxr". Am I missing anything else?

@judasbenhur Just put an HTML element as a child of model-viewer; if you're in webXR, it'll still show up when you've entered AR. I'm currently tracking down some bugs on failing to enter webXR, which you may have run into.

Hi there, @eyefun, @elalish, @judasbenhur  and @romainguy:
I am precisely experiencing a problem that is related to the issue of reflections/refractions of light, although in my case on a translucent material such as glass.
I have a glass ball in GLTF/GLB that looks like this (screenshot of BJS Sandbox):

The WebGL visualization through modelviewer already shows the glass, but with a very little "presence", both in Android-Chrome, and on iOS-Safari, even taking into account that in the PBR channel of baseColor have been introduced subtle traces of dirt, to give more realism to the whole:

Of course, not being able to add an environment to the reflection in the glass is a big problem here.
Same way, when we switch to AR on Android-Sceneviewer, the glass is barely visible, ruining much of the (augmented) realism:

However, in iOS-Quicklook some magic is done and it looks really convincing and appealing:

As an important info, note that the USDZ used in iOS has been generated, by means of Reality Converter, from the GLTF/GLB used in Android, so I understand that either this software has introduced some component that makes the crystal appear or directly ARKit-Metal interprets better this specific aspect of reflectance than ARCore-Filament.
This said, any "reflection" on this subject will be welcome.
Thanks for your time.

@vortice3D The problem here is that glTF as is does not have a way to specify a glass material, which is the purpose of the transmission extension, which we don't support quite yet. The alpha channel of the base color is technically for partially empty surfaces, like gauze, hence the lack of reflectivity. I've seen decent results just by setting alpha to be less transparent, but it's certainly a hack and this is why different renderers treat it differently. Once everyone is using the transmission extension instead things will be much more consistent.

The specific IBL used will also affect the appearance dramatically.

@vortice3D The problem here is that glTF as is does not have a way to specify a glass material, which is the purpose of the transmission extension, which we don't support quite yet. The alpha channel of the base color is technically for partially empty surfaces, like gauze, hence the lack of reflectivity. I've seen decent results just by setting alpha to be less transparent, but it's certainly a hack and this is why different renderers treat it differently. Once everyone is using the transmission extension instead things will be much more consistent.

I had already thought of adjusting the texture of the base colour channel, as a last resort.
As you say, that's a hack, but if there's no other solution we'll have to try it.
Best regards.

The specific IBL used will also affect the appearance dramatically.

Thanks for the immediate response, @romainguy.
I will report what you say to the 3D artist.


State of the API Report - Who Works with APIs  - Blog Post

Can we get up to 1000 words on the Who Works with APIs section of the State of the API Report.

Blog post - https://docs.google.com/document/d/1kQj52vWD6futkAqjIO_eHoWjX44P6EM7fjg0td2kqKo/edit?usp=sharing
I'll Slack Linda and let her know about its availability. Will be the basis for #116

In the editorial queue: https://postmanlabs.atlassian.net/browse/BE-126

Let's keep this conversation open until the blog post is made public -- that is the value here, for the community. Once public we can publish the link here as a record, and close.


write_canonical heavy segfault

v2.20.1
?- Y=[Y|X], X=[X|Y], write_canonical([X]), write_canonical([Y]).

������@��@�>�����������������
HA��@�ȶbuUxɶbuU^[[1;8R^[[?65;1;9c�p�
Segmentation fault (core dumped)

$ R65;1;9c

Note: Last line is the shell prompt $ and some further output R65;1;9c (perhaps system depending)
Note: This output is input, too (sort of buffer overflow)
$ R65;1;9c <ret>
R65: command not found
1: command not found
9c: command not found

Additional info:
?- Y=[Y|X], X=[X|Y], write_canonical(X), write_canonical(Y).
.'(X,Y)'.'(Y,X)   Y = [Y,X|Y], X = Y. % ok

?- Y=[Y|X], X=[X|Y], write_canonical([X]).
   Y = [Y,X|Y], X = Y.  % [X] not written

?- Y=[Y|X], X=[X|Y], write_canonical([X]), write_canonical(Y).
'.'(Y,X)   Y = [Y,X|Y], X = Y. % [X] not written

% Finally, the core dump
?- Y=[Y|X], X=[X|Y], write_canonical([X]), write_canonical([Y]).


Relay plugin failing when running multiple jest tests in parallel

Here are versions of swc and plugins I use:
    "@swc/core": "1.3.52",
    "@swc/jest": "0.2.26",
    "@swc/plugin-relay": "1.5.59",
    "jest_workaround": "0.75.4",

Unless I run tests one by one (with --runInBand), I keep getting errors like this one:
 FAIL  functions/access-control/access-control-utils.spec.ts
  ● Test suite failed to run

    failed to handle: called `Result::unwrap()` on an `Err` value: PoisonError { .. }

      at Compiler.transformSync (node_modules/@swc/core/index.js:241:29)
      at transformSync (node_modules/@swc/core/index.js:348:21)
      at Object.process (node_modules/@swc/jest/index.js:73:45)
      at ScriptTransformer.transformSource (node_modules/@jest/transform/build/ScriptTransformer.js:542:31)
      at ScriptTransformer._transformAndBuildScript (node_modules/@jest/transform/build/ScriptTransformer.js:671:40)
      at ScriptTransformer.transform (node_modules/@jest/transform/build/ScriptTransformer.js:723:19)

I broke down what happens based on CLI options I pass to Jest.
No options (using defaults) 🤒
Test Suites: 364 failed, 1 skipped, 54 passed, 418 of 419 total
Tests:       2 skipped, 359 passed, 361 total
Snapshots:   5 passed, 5 total
Time:        17.521 s, estimated 28 s

--maxWorkers=2 --maxConcurrency=1 😵💫
Test Suites: 364 failed, 1 skipped, 54 passed, 418 of 419 total
Tests:       2 skipped, 359 passed, 361 total
Snapshots:   5 passed, 5 total
Time:        44.874 s

--runInBand ✅
Test Suites: 0 failed, 1 skipped, 418 passed, 418 of 419 total
Tests:       0 failed, 3 skipped, 3351 passed, 3351 total
Snapshots:   9 passed, 9 total
Time:        251.08 s

Single test 😮
Run 1 😢
yarn test src/actions/accountMembers.spec.ts
yarn run v1.22.19
$ cross-env NODE_ENV=test TZ=UTC jest src/actions/accountMembers.spec.ts

 RUNS  src/actions/accountMembers.spec.ts
thread '<unnamed>' panicked at 'assertion failed: prev.start > max', /Users/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/wasmer-co FAIL  src/actions/accountMembers.spec.ts_info.rs:224:9
  ● Test suite failed to run

    failed to handle: assertion failed: prev.start > max

      4 |
      5 | import { selectMembers } from './accountMembers';
    > 6 |
        | ^
      7 | describe('Returns the sorted account members list', () => {
      8 |   const store = {
      9 |     accountMembers: fromJS({

      at Compiler.transformSync (node_modules/@swc/core/index.js:241:29)
      at transformSync (node_modules/@swc/core/index.js:348:21)
      at Object.process (node_modules/@swc/jest/index.js:73:45)
      at ScriptTransformer.transformSource (node_modules/@jest/transform/build/ScriptTransformer.js:542:31)
      at ScriptTransformer._transformAndBuildScript (node_modules/@jest/transform/build/ScriptTransformer.js:671:40)
      at ScriptTransformer.transform (node_modules/@jest/transform/build/ScriptTransformer.js:723:19)
      at Object.<anonymous> (src/actions/accountMembers.spec.ts:6:18)

Test Suites: 1 failed, 1 total
Tests:       0 total
Snapshots:   0 total
Time:        0.518 s

Run 2 🎉
$ cross-env NODE_ENV=test TZ=UTC jest src/actions/accountMembers.spec.ts
 PASS  src/actions/accountMembers.spec.ts
  Returns the sorted account members list
    ✓ Invited team members (with role "Invited") are at the end of the list (1 ms)
    ✓ Team members are sorted by updated_at (most recent first) (1 ms)
    ✓ Invited team members (with role "Invited") are sorted by updated_at (most recent first)

Test Suites: 1 passed, 1 total
Tests:       3 passed, 3 total
Snapshots:   0 total
Time:        0.759 s

I tried on an m1 mac and on an Ubuntu docker container – same results.
I tried to reproduce in a small & fresh project with similar settings to the ones we have in our codebase, but couldn't :(

Hope to get some reproducible repo. Otherwise all of the fix would be a guesswork, cannot able to tell if it's fixed or not.

This might be a little unorthodox, but would you be open to hop on a call so I can show you what's going on (in Netlify's codebase itself)? I'm not sure what part of our setup might be causing these failures, but you might immediately spot the culprit!

I wish I could do, but I don't think my full-time job allows to me to peek production codebase of other companies unless I go through legal approval & some other processes.

Oh I assure you I'd only show you config files and non-sensitive code. No PII or sensitive data will show up on the screen!

I think this is fixed. Can you try updating @swc/core?

Closing as stale


Upgrade depends

fixed #314

Thanks for the quick response!
Oddly, I'm still getting the message:
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20<EMAIL_ADDRESS>For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

@lilith san,
Sorry. It wasn't fixed enough.
I fixed it and bump major version, so please use @v4.
Thank you!


Unable to signup with github

I am trying to signup and it says to try with a different account

I am sent to https://sourcekarma.vercel.app/api/auth/signin?error=OAuthCreateAccount , which says

Try signing in with a different account.
Sign in with GitHub

Clicking the button goes in circles.

I have no idea about this issue, sorry and thanks for opening it!

I am also facing this problem when I try using my Github account to sign in. I even disabled brave shield but I still got the same error.

I'm also running into this issue.
In case it helps, here's the sequence of requests I see in my Firefox console (it won't work on Chrome either):

POST https://sourcekarma.vercel.app/api/auth/signin/github
302 redirecting to https://github.com/login/oauth/authorize?scope=&state=...&redirect_uri=https%3A%2F
302 redirecting to https://sourcekarma.vercel.app/api/auth/callback/github?code=...&state=...
302 redirecting to https://sourcekarma.vercel.app/api/auth/error?error=OAuthCreateAccount
302 redirecting to https://sourcekarma.vercel.app/api/auth/signin?error=OAuthCreateAccount
304 with the error page shown above

I'm a bit sad, I was keen to try it! :)


Transformations from AAIS stat plan to HDS

Implement the transformation for three lines of business to support the COVID-19 BI Data Call POC.

Covid 19 BI Data Call POC is complete.  The transformations are completed for that purpose.


feature(dingus) WIP : initial ciceromark dingus

Signed-off-by: Jerome Simeon<EMAIL_ADDRESS>Issue #111
A dingus based on the markdown-it demo, but focused on templatemark.

Coverage remained the same at 91.555% when pulling bba019d264938c12ea4589ea85f424ce620f3bb2 on jeromesimeon:js-dingus into ec9d4a48e6154d4e1f8eb894a35e19a2f898e2aa on accordproject:master.


Search in Discover does not always return results

The following requests were sent to the server, items that have these tags show up in the Discover view, but the search requests return no results.
{"request":{"api":"v1","id":"z76acdeqd81wnrk9","command":"search","keyword":"retro"}}
{"request":{"api":"v1","id":"emvu48i8f8b8olxr","command":"search","keyword":"vintage"}}
This request, on the other hand, does return results
{"request":{"api":"v1","id":"xc8mna4y11tw3ik9","command":"search","keyword":"test"}}

It's hard to know what the problem is. I think those keywords aren't in the dht for some reason. Either they expired and we're removed. Or somehow the original store request didn't propagate right.
I'm going to add republish functionality soon. Maybe once every 24 hours or so. I think that will take care of that. Unless there are bigger dht issues I don't know about.

Is this still a problem @jjeffryes ?


Add a provider level metadata field for schedule

At the provider level (i.e. https://github.com/sul-dlss/dlme-airflow/blob/main/catalogs/aims.yaml#L1) not at the collection level, add a schedule metadata parameter that accepts an airflow schedule pattern (https://airflow.apache.org/docs/apache-airflow/1.10.1/scheduler.html) to set in the DAG arguments https://github.com/sul-dlss/dlme-airflow/blob/main/dlme_airflow/services/harvest_dag_generator.py#L53 replacing our place holder "@once" value.
If not found in the provider collection, the default should be "@daily".

Closed by https://github.com/sul-dlss/dlme-airflow/pull/215


[Enhancement] [Refactor] Introduce PENDING_CANCELLED

When a pipeline driver has already been cancelled but still at PENDING_FINISH state, it will be cancelled again and again in the poller util not PENDING_FINISH anymore, which will output lots of WARNING log [Driver] Timeout, query_id=xxxx.
if (driver->fragment_ctx()->is_canceled()) {
     // cancel this driver.
}

However, each Driver::set_cancelled is guaranteed that invoked once, so cancelled many times is meaningless.
Therefore, introduce PENDING_CANCELLED state to indicate that the driver is at PENDING state and has already been cancelled.
BTW, refactor to make driver handle some common events and simplify the logic of poller.
/// A pipeline driver switch states according to the following graph:
/// NOT_READY
///   │
///   │
///   ▼
/// READY ────────────► RUNNING ───────────────────────────────────┬──────────────────────────────────┐
///   ▲                   │                                        │                                  │
///   │                   │                                        ▼                                  │
///   │                   │            ┌───────────────────────────────────────────────────────┐      │
///   └── on_ready ───────┼────────────┤PRECONDITION_BLOCK      INPUT_EMPTY        OUTPUT_FULL │      │
///                       │            └───────────────────────────┬───────────────────────────┘      ▼
///                       ▼                                        │                                  │
///                       │                                        │                                  │
///                       ├────────────────────◄───────────────────┴───────────►──────────────────────┤
///                       │                                    ┌──────────►───────────────────────────│
///                 on_finishing[is_still_pending_finish]      │    on_cancelling[is_still_pending_finish]
///                       │                                    │                                      │
///                       ├───────────────────► PENDING_FINISH ┘     PENDING_CANCELLED ◄──────────────┤
///                       │                          │                       │                        │
///                 on_finishing                     │  on_pending_finished  │                 on_cancelling
///                       │                          ▼                       ▼                        │
///                       └───────────────────────►FINISH                CANCELLED ◄──────────────────┘

What type of PR is this:

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.0
[ ] 2.5
[ ] 2.4
[ ] 2.3

Since we already reduce logging times to 100 and calling Driver::cancel_operators multiple times doesn't have too much overhead, we needn't introduce PENDING_CANCELLED for now.
                    size_t expired_log_count = driver->fragment_ctx()->expired_log_count();
                    if (expired_log_count <= 100) {
                        LOG(WARNING) << "[Driver] Timeout, query_id=" << print_id(driver->query_ctx()->query_id())
                                     << ", instance_id=" << print_id(driver->fragment_ctx()->fragment_instance_id());
                        driver->fragment_ctx()->set_expired_log_count(++expired_log_count);
                    }


Broken hide animation!!!

Previously, I had this code:
- (void)setView:(UIView *)view hiddenAtEndOfAnimation:(BOOL)hidden atPage:(Page)page {

	IFTTTHideAnimation *hideAnimation = [[IFTTTHideAnimation alloc] initWithView:view];

	[hideAnimation addKeyFrame:[[IFTTTAnimationKeyFrame alloc] initWithTime:page.left andHidden:!hidden]];
	[hideAnimation addKeyFrame:[[IFTTTAnimationKeyFrame alloc] initWithTime:page.right - 1 andHidden:!hidden]];

	[hideAnimation addKeyFrame:[[IFTTTAnimationKeyFrame alloc] initWithTime:page.right andHidden:hidden]];

	[self.contentAnimator addAnimation:hideAnimation];
}

but with the latest version, this is impossible, as there is no simple init that only sets the view. Highly dissapointed.

I found out a very hacky way for this:
- (void)setView:(UIView *)view hiddenAtEndOfAnimation:(BOOL)hidden atPage:(Page)page {

	IFTTTHideAnimation *hideAnimation = [[IFTTTHideAnimation alloc] init];

	[hideAnimation setValue:view forKey:@"_view"];

	[hideAnimation addKeyframeForTime:page.left value:[NSNumber numberWithBool:!hidden]];
	[hideAnimation addKeyframeForTime:page.right - 1 value:[NSNumber numberWithBool:!hidden]];

	[hideAnimation addKeyframeForTime:page.right value:[NSNumber numberWithBool:hidden]];

	[self.contentAnimator addAnimation:hideAnimation];
}

which it works but it's ugly. I don't understand why was it crashing with New value must have the same interpolatable type as existing keyframe values. though, when I was using @(hidden).


Allow publishers to view draft step-by-steps without signon

Trello: https://trello.com/c/9ZMVHe0u
Motivation
Nearly all of the step-by-steps that are created need to be reviewed by people in departments who don't have signon access.  Content designers have been getting around this limitation by following a complicated process to create a preview app to send to factcheckers, but this process will become harder to support as more and more step-by-steps are created.
There is already a pattern used by Mainstream and Whitehall publishers that allows a list of auth_bypass_ids to be passed into the payload sent to publishing-api. This id is used by authenticating-proxy to decode a query string passed into the URL of the draft step-by-step. If the ids match, the user can view the content, otherwise, they will be asked to sign in.
Tech debt
The code used to create the auth_bypass_id and JWT token passed into the query string are duplicated from Publisher:

https://github.com/alphagov/publisher/blob/master/app/helpers/paths_helper.rb#L30
https://github.com/alphagov/publisher/blob/master/app/models/edition.rb

A card has been added to the backlog to address this.

Publisher's approach is hooked to the edition ID which should mean that the token is different for a new draft of a published version.
I think this will generate a single auth token which will be the same for all drafts of each step by step (as it's based on the content ID).  Is this OK?

@sihugh Do step-by-steps have an equivalent to an Edition?

Not yet! ;-).  I'm fine with it if you are, it's just worth being aware
that this is the behaviour
On Tue, 17 Jul 2018 at 12:04, Leena Gupte<EMAIL_ADDRESS>wrote:

@sihugh https://github.com/sihugh Do step-by-steps have an equivalent
to an Edition?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/alphagov/collections-publisher/pull/426#issuecomment-405544475,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAvLrXoS0ExHS6VuJhNYD6aHR0W7ym75ks5uHcTRgaJpZM4VRLko
.

@sihugh @tijmenb I've addressed all of your suggestions in https://github.com/alphagov/collections-publisher/pull/427


Class auto-complete doesn't work ((( why so???

VSCode Version: 1.20.1
OS Version: macOS High Sierra 10.13.1

Steps to Reproduce:

When I write sass styling in my style.sass file, class autocomplete doesn't work, why so? i should write every time from beginning
I have attached file for proof

Does this issue occur when all extensions are disabled?: Yes

Currently, there is only intellisense for selectors, properties, and values in css. There is an existing feature request to add completions for class names, https://github.com/Microsoft/vscode/issues/28442. Closing this issue as a duplicate.


Jasmine 2.0.0 added

Jasmine has been updated from 1.3.1 to 2.0.0.
Now on opening SpecRunner.html in the browser, the example specs pass.

@smcgregor @irdan Jasmine 2.0.0 has been added and the SpecRunner.html runs the basic example Jasmine specs. Also, test_loader.js now loads jasmine 2.0.0.
Now, ExtensionSpec.js and the scripts under javascripts/background_scripts need to be changed to follow jasmine 2.x syntax.
Please let me know what you think about this. Also, this PR is not ready to be merged. Work is needed to get the existing scripts running.
Thanks,
Sambuddha

So the bigger issue here is that the tests are being run in the old way. On privly-applications all the tests are run by Karma, which has different design and testing concerns.
Have you written a test for Karma yet? I recommend doing that in privly-applications then returning to the Chrome repo and taking another look at this.
I closed the PR, but feel free to continue the discussion.


fix: build issue while applying full story plugin when disabled

Description

apply plugin: 'fullstory' wrap the plugin with the condition, if the full story is enabled.

Closing the PR, create by mistake


GROOVY-10374: Provide more tuple classes

https://issues.apache.org/jira/browse/GROOVY-10374

Why create an issue ticket at all if this was incoming?  Should discussion occur on the issue ticket or the pull request?  Now that you have the sunk cost of implementation, is there really any way to stop this from happening?
-1

I do not care the sunk cost very much. In fact, I have closed many PRs without merging in the recent years, though most of them cost me hours.
I agree with you that we had better to discuss in the issue ticket, PR or mailing list. As I am not sure whether it's accepted by others or not, the PR was created for reviewing and not pushing to master directly.


Git plugin crashes after upgrading to El Capitan

I've just upgraded my system to El Capitan, and my terminal began crashing once I press tab while typing a Git command. No idea how to get an error output, any ideas ?

You can run functions -T _git which will toggle debugging of the git completion function and hopefully get you a helpful error message.

You have to run that and then try tab-completing a git command if it wasn't clear.

@mcornella here is the output;

@mcornella thanks for the tip about showing the error.

What was the problem?

@mcornella dunno, just disabled the git-completion plugin


Pin versions as per raiden requirements

As synced via https://github.com/raiden-network/raiden/blob/develop/requirements/requirements.txt
I also unpinned the raiden version, as that was also complaining.
Tested using the dockerfile docker/Dockerfile like so:
$docker build -f docker/Dockerfile -t test .
...
$ docker run test:latest version
Traceback (most recent call last):
  File "/opt/venv/bin/scenario_player", line 6, in <module>
    from scenario_player.__main__ import main
  File "/opt/venv/lib/python3.7/site-packages/scenario_player/__main__.py", line 6, in <module>
    from .main import main
  File "/opt/venv/lib/python3.7/site-packages/scenario_player/main.py", line 27, in <module>
    from scenario_player.runner import ScenarioRunner
  File "/opt/venv/lib/python3.7/site-packages/scenario_player/runner.py", line 30, in <module>
    from scenario_player.definition import ScenarioDefinition
  File "/opt/venv/lib/python3.7/site-packages/scenario_player/definition.py", line 9, in <module>
    from scenario_player.utils.configuration import (
  File "/opt/venv/lib/python3.7/site-packages/scenario_player/utils/__init__.py", line 1, in <module>
    from scenario_player.utils.legacy import (
  File "/opt/venv/lib/python3.7/site-packages/scenario_player/utils/legacy.py", line 30, in <module>
    from raiden.settings import RAIDEN_CONTRACT_VERSION
ImportError: cannot import name 'RAIDEN_CONTRACT_VERSION' from 'raiden.settings' (/opt/venv/lib/python3.7/site-packages/raiden/settings.py)
(scenario-player) X280 /home/nls/devel/scenario-player$

Merging build stages into a single stage appears to solve the issue

So now, we can review?

Reviewing


Make :resource option optional

Currently error is thrown if :resource is nil.
I'd like to cover cases in which authorization will not depend on particular database entity, but only on user.
@rpelyush

https://github.com/rpelyush/gardien/issues/8

It should be mentioned in the doc (I'll add comment).

As far as I remember it's already mentioned.


pip install fails with --install-option="--prefix=/install"

I was trying to create a minimal docker image for home-assistant with includes PyEssent as a dependency, while I am not reliant on it and could just remove it it was failing with the install-option for prefixing the path.
Would be nice to have this fixed for anyone trying to create minimal images with your repo as a dependency :-D

Do you have more info? Like the exact error message?

Closed due to lack of response, feel free to reopen if you have the requested info.


[Feature Request] Config Options

Is your feature request related to a problem? Please describe.
As my library increased, I noticed some features I'd like to have access to.
Describe the solution you'd like
I would like the option to have more configuration options for the UI:

Make ENTRIES_IN_HOME_SECTIONS a config option
Config option to show manga cover in the homescreen section, and not the chapter cover.
Add a button "continue reading" in the manga view.

Thanks! These are all great features to have. Will work on them when I have the time.


added executable/output/nb & fixed paths

added executable "run-legend-data-monitor.py" that calls main() in src/legend_data_monitor/run.py
added src/legend_data_monitor/main.py
new folder "out/" to store output files (.log, .pdf, .pkl)
moved "config.json" in parent directory

Codecov Report

:exclamation: No coverage uploaded for pull request base (dev@2044192). Click here to learn what that means.
The diff coverage is n/a.

:exclamation: Current head 22b1a66 differs from pull request most recent head f68891d. Consider uploading reports for the commit f68891d to get more accurate results

@@          Coverage Diff          @@
##             dev      #3   +/-   ##
=====================================
  Coverage       ?   0.21%
=====================================
  Files          ?      10
  Lines          ?     940
  Branches       ?       0
=====================================
  Hits           ?       2
  Misses         ?     938
  Partials       ?       0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Template: Create env to store testnet, mainnet, etc and associated config

Do this after mostly finishing the deploy command b/c that might affect how transaction signing is done (& where keys are stored).

We now have config.json


"No decoder found" for Pixel API33-recorded videos

Hello,
First of all, thank you for all your hard work!
I have been using your library to trim videos and have encountered the following issue:
Library Version: 1.5.5
Video used in all instances:
Shot with the default camera on a Pixel 6 running Android 13
Video details:

Size: 26,432,412 bytes
Dimensions: 1080×1920
Codecs: HEVC, AAC
Colour Profile: HD (1-1-1)
Duration: 11 seconds
Audio channels: Stereo

I have been unable to start processing on the same device that recorded it: Pixel 6 API 33
Error:
Transformation job error
com.linkedin.android.litr.exception.TrackTranscoderException: No decoder found.Media transformation failed for job id: [jobId]
Media format: {track-id=1, durationUs=10664266, mime=application/meta, language=```, max-input-size=113}

    at com.linkedin.android.litr.utils.CodecUtils.getAndConfigureCodec(CodecUtils.java:207)
    at com.linkedin.android.litr.codec.MediaCodecDecoder.init(MediaCodecDecoder.java:34)
    at com.linkedin.android.litr.transcoder.AudioTrackTranscoder.initCodecs(AudioTrackTranscoder.java:60)
    at com.linkedin.android.litr.transcoder.AudioTrackTranscoder.<init>(AudioTrackTranscoder.java:50)
    at com.linkedin.android.litr.transcoder.TrackTranscoderFactory.create(TrackTranscoderFactory.java:91)
    at com.linkedin.android.litr.TransformationJob.createTrackTranscoders(TransformationJob.java:175)
    at com.linkedin.android.litr.TransformationJob.transform(TransformationJob.java:97)
    at com.linkedin.android.litr.TransformationJob.run(TransformationJob.java:77)
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:463)
    at java.util.concurrent.FutureTask.run(FutureTask.java:264)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1137)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:637)
    at java.lang.Thread.run(Thread.java:1012)

This error seems interestingly related to configuring an audio track codec, so I've ignored the audio track and this was the result:
Transformation job error
com.linkedin.android.litr.exception.TrackTranscoderException: No decoder found.Media transformation failed for job id: null
Media format: {track-id=1, durationUs=10664266, mime=application/meta, language=```, max-input-size=113}

    at com.linkedin.android.litr.utils.CodecUtils.getAndConfigureCodec(CodecUtils.java:207)
    at com.linkedin.android.litr.codec.MediaCodecDecoder.init(MediaCodecDecoder.java:34)
    at com.linkedin.android.litr.transcoder.VideoTrackTranscoder.initCodecs(VideoTrackTranscoder.java:78)
    at com.linkedin.android.litr.transcoder.VideoTrackTranscoder.<init>(VideoTrackTranscoder.java:69)
    at com.linkedin.android.litr.transcoder.TrackTranscoderFactory.create(TrackTranscoderFactory.java:78)
    at com.linkedin.android.litr.TransformationJob.createTrackTranscoders(TransformationJob.java:175)
    at com.linkedin.android.litr.TransformationJob.transform(TransformationJob.java:97)
    at com.linkedin.android.litr.TransformationJob.run(TransformationJob.java:77)
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:463)
    at java.util.concurrent.FutureTask.run(FutureTask.java:264)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1137)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:637)
    at java.lang.Thread.run(Thread.java:1012)

I am not manipulating anything but the duration of the video in my configs of the TrackTransforms, so I'm not sure what configuration might cause this codec initialisation error. I will provide any extra details if they're requried.
Thank you!

Looks like your video has a metadata track, which LiTr (for some reason) is recognizing as audio and is trying to transcode. This is very weird. Could you share your video with me? You can use Google Drive or something.
As a workaround, you can skip all non-audio or video tracks entirely when creating a List<TrackTransform>, I am pretty sure that will take of this problem.

Phew, you had me worried there for a minute. 😅
Closing this issue for now. Let me know if you need help with anything else or find a bug. Thank you for using LiTr!


acorn not installed, but it's a peerDependency of acorn-dynamic-import

versions:

node 10.15.1
npm 6.7.0
@storybook/react ^4.1.11 (which requires<EMAIL_ADDRESS>
when i install just @storybook/react into my project, i get the following error:
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
i've looked into acorn-dynamic-import (a plugin for acorn), and the issue isn't on their end. i've looked into acorn, but they're the main library and the problem isn't with them. i've looked into @storybook/react, but they're merely requiring webpack, the problem isn't with them. i've also opened a ticket with npm to see if there's a dependency resolution issue somewhere. the last place i haven't checked with is you guys, though i have my doubts here, both acorn and acorn-dynamic-import are "peer" dependencies in your dependency list.
i've been chasing this issue for a few weeks now, and i can't seem to get any traction with it. but if there's any thoughts on what else i should be looking into, that would be super helpful. the last bit that seems like it might be off is that webpack is using yarn, but i'm using npm in my project for dependency installation.

It's an npm bug. See #8656

there's an incoming fix for<EMAIL_ADDRESS>(which hasn't dropped yet)
https://npm.community/t/unmet-peerdependency-but-its-listed-as-a-dependency/5322

npm reverted @sokra's fix for the final<EMAIL_ADDRESS>release: https://github.com/npm/cli/pull/152
It's unclear when npm will get around to fixing the issue.

oof. it's been like this for years, so i guess it's not that bad to just keep using yarn. but man, that's a strange decision on their part.

I have the problem with 6.10.3


[10.x] Fixed server Closing output on invalid $requestPort

Laravel: 10.6.2
PHP: 8.1.17
On a docker deploy I get a random Undefined array key error when the server try to manage the Closing response on a undefined $requestPort.
The server command is:
php artisan serve --host=<IP_ADDRESS> --port=80 >> storage/logs/artisan-serve.log 2>&1

Maybe the problem is getRequestPortFromLine parse, but for now maybe the best option is check the $this->requestsPool[$requestPort] value before continue with the output.

@taylorotwell I have added a logger to src/Illuminate/Foundation/Console/ServeCommand.php and now I can see the problem.
Accepted event can be registered from multiple IPs on same port, but the ServeCommand is using only the port to manage the requests, then is trying to log two different requests on same port as the same request.
[2023-04-11 10:52:07] stage.DEBUG: [Tue Apr 11 08:52:07 2023] XXX.XXX.XXX.214:42202 Accepted
[2023-04-11 10:52:07] stage.DEBUG: [Tue Apr 11 08:52:07 2023] XXX.XXX.XXX.212:32768 Accepted # Accepted Request 1 on port 32768
[2023-04-11 10:52:07] stage.DEBUG:
[2023-04-11 10:52:10] stage.DEBUG: [Tue Apr 11 08:52:10 2023] XXX.XXX.XXX.214:42202 Closing
[2023-04-11 10:52:10] stage.DEBUG: [Tue Apr 11 08:52:10 2023] XXX.XXX.XXX.218:32768 Accepted # Accepted Request 2 on port 32768
[2023-04-11 10:52:10] stage.DEBUG:
[2023-04-11 10:52:10] stage.DEBUG: [Tue Apr 11 08:52:10 2023] XXX.XXX.XXX.212:32768 Closing # Closing Request 1 on port 32768
[2023-04-11 10:52:10] stage.DEBUG: [Tue Apr 11 08:52:10 2023] XXX.XXX.XXX.218:32768 Closing # Request 2 can not be managed because the port was closed (removed from `$requestsPool` when closing Request 1).
[2023-04-11 10:52:11] stage.ERROR: Undefined array key 32768 {"exception":"[object] (ErrorException(code: 0): Undefined array key 32768 at /app/vendor/laravel/framework/src/Illuminate/Foundation/Console/ServeCommand.php:255)
[stacktrace]
#4 /app/vendor/symfony/process/Process.php(1272): Illuminate\\Foundation\\Console\\ServeCommand->Illuminate\\Foundation\\Console\\{closure}('err', '[Tue Apr 11 08:...')
#5 /app/vendor/symfony/process/Process.php(1370): Symfony\\Component\\Process\\Process->Symfony\\Component\\Process\\{closure}('err', '[Tue Apr 11 08:...')
#6 /app/vendor/symfony/process/Process.php(1290): Symfony\\Component\\Process\\Process->readPipes(false, true)
#7 /app/vendor/symfony/process/Process.php(838): Symfony\\Component\\Process\\Process->updateStatus(false)
#15 /app/vendor/symfony/console/Command/Command.php(312): Illuminate\\Console\\Command->execute(Object(Symfony\\Component\\Console\\Input\\ArgvInput), Object(Illuminate\\Console\\OutputStyle))
#17 /app/vendor/symfony/console/Application.php(1040): Illuminate\\Console\\Command->run(Object(Symfony\\Component\\Console\\Input\\ArgvInput), Object(Symfony\\Component\\Console\\Output\\ConsoleOutput))
#18 /app/vendor/symfony/console/Application.php(314): Symfony\\Component\\Console\\Application->doRunCommand(Object(Illuminate\\Foundation\\Console\\ServeCommand), Object(Symfony\\Component\\Console\\Input\\ArgvInput), Object(Symfony\\Component\\Console\\Output\\ConsoleOutput))
#19 /app/vendor/symfony/console/Application.php(168): Symfony\\Component\\Console\\Application->doRun(Object(Symfony\\Component\\Console\\Input\\ArgvInput), Object(Symfony\\Component\\Console\\Output\\ConsoleOutput))
#21 /app/artisan(37): Illuminate\\Foundation\\Console\\Kernel->handle(Object(Symfony\\Component\\Console\\Input\\ArgvInput), Object(Symfony\\Component\\Console\\Output\\ConsoleOutput))
#22 {main}
"}
[2023-04-11 10:52:11] stage.DEBUG: [Tue Apr 11 08:52:11 2023] PHP 8.1.17 Development Server (http://<IP_ADDRESS>:80) started

I think that the requestsPool key should be the IP and the port.
Regards!

@eusonlito what do you mean exactly? Should we revert this PR or...?

@driesvints the previous (and current) version of $requestsPool is not handling requests as unique, since it is based only on the port, and not on the IP and port.
My patch is just to avoid the error when trying to close the same request twice.
Ideally, $requestPool should have the host and IP as a key to be able to handle each request uniquely.
I could send a PR to test this implementation.

Yes feel free to try a PR if you want 👍


[snapshot] Take screenshot of entire device screen instead of just the app window

Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.

Motivation and Context

Currently screenshots are taken of the app windows, which isn't necessarily the same size as the app screen which means they can't be used to upload to the app store

https://github.com/fastlane/fastlane/issues/13610
Description

Take screenshot of the screen instead of the window

Run snapshot on all devices and verified the output screenshot resolutions match that expected in the appstore

I signed it!
On Sun, 2 Jun 2019 at 18:58, googlebot<EMAIL_ADDRESS>wrote:

Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project (if not, look below for help).
Before we can look at your pull request, you'll need to sign a Contributor
License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/
https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I
signed it!) and we'll verify it.
What to do if you already signed the CLA Individual signers

It's possible we don't have your GitHub username or you're using a
different email address on your commit. Check your existing CLA data
https://cla.developers.google.com/clas and verify that your email is
set on your git commits
https://help.github.com/articles/setting-your-email-in-git/.

Corporate signers

Your company has a Point of Contact who decides which employees are
authorized to participate. Ask your POC to be added to the group of
authorized contributors. If you don't know who your Point of Contact is,
direct the Google project maintainer to go/cla#troubleshoot (Public
version https://opensource.google.com/docs/cla/#troubleshoot).
The email used to register you as an authorized contributor must be
the email used for the Git commit. Check your existing CLA data
https://cla.developers.google.com/clas and verify that your email is
set on your git commits
https://help.github.com/articles/setting-your-email-in-git/.
The email used to register you as an authorized contributor must
also be attached to your GitHub account
https://github.com/settings/emails.

ℹ Googlers: Go here
https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Ffastlane%2Ffastlane%2Fpull%2F14841
for more info.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/fastlane/fastlane/pull/14841?email_source=notifications&email_token=AAK7TD67HBU4XVOHHBOG5DTPYQC47A5CNFSM4HSDFJE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWX2XEA#issuecomment-498051984,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAK7TD6AYFWWV6RU6YGYY63PYQC47ANCNFSM4HSDFJEQ
.

I signed it!
On Sun, 2 Jun 2019 at 23:52, googlebot<EMAIL_ADDRESS>wrote:

We found a Contributor License Agreement for you (the sender of this pull
request), but were unable to find agreements for all the commit author(s)
or Co-authors. If you authored these, maybe you used a different email
address in the git commits than was used to sign the CLA (login here
https://cla.developers.google.com/ to double check)? If these were
authored by someone else, then they will need to sign a CLA as well, and
confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull
request author add another comment and the bot will run again. If the bot
doesn't comment, it means it doesn't think anything has changed.
ℹ Googlers: Go here
https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Ffastlane%2Ffastlane%2Fpull%2F14841
for more info.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/fastlane/fastlane/pull/14841?email_source=notifications&email_token=AAK7TD4S2AWUN3YE7QE3PJTPYRFKHA5CNFSM4HSDFJE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWX7TEQ#issuecomment-498071954,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAK7TD2GQB2KLAE3V4WWH2TPYRFKHANCNFSM4HSDFJEQ
.

Currently screenshots are taken of the app windows, which isn't necessarily the same size as the app screen

Do we know why and how this happens?

Note, I think there is another PR doing identical or similar changes. Before this is merged, these should both be looked at to make sure this all works together.

I'm not sure why views don't fill the screen on some devices, sometimes there's just a few pixels at the bottom of the screen which are left blank giving the discrepancy.
Here on a iPhone 6s Plus the view stops just 2 pixels from the bottom of the screen, giving the discrepancy between window.screenshot() and XCUIScreen.main.screenshot()

Could possibly make this an optional thing, in case there's some reason you would want to take a screenshot of the window instead of the screen. But seeing as the purpose of these screenshots is for uploading to the app store, taking a screenshot of the screen instead of the window should always output the desired resolution

But seeing as the purpose of these screenshots is for uploading to the app store, taking a screenshot of the screen instead of the window should always output the desired resolution

Probably.
I am a bit unsure because of how that code is not even that old and there was some previous complicated logic: https://github.com/fastlane/fastlane/commit/9031c665823250064008986d3ecfe58325644e1b But going back in history for that line, it seems to have been present for quite some time, and I don't really understand what was there before: https://github.com/fastlane/fastlane/commit/f410f2a6d9d20ae8e6747db978cae7142a03d781#diff-1a1173200436690d61ef63b6702ae6d6R131

Here on a iPhone 6s Plus the view stops just 1 pixel from the bottom of the screen and 1 from the top, giving the discrepancy between window.screenshot() and XCUIScreen.main.screenshot()

Thanks for that illustration, the problem makes a lot more sense with that.

Does device vs. app window maybe have to do something with statusbars?
Here is some code that also uses app.windows.firstMatch that is left in the file: https://github.com/fastlane/fastlane/blob/7e26ef5d16658a5eef364ff8be8e6e0578d8ca3f/snapshot/lib/assets/SnapshotHelper.swift#L277

Does device vs. app window maybe have to do something with statusbars?

I don't believe so, The view will happily go under the status bar so not sure that's affecting this

Here is some code that also uses app.windows.firstMatch that is left in the file:
https://github.com/fastlane/fastlane/blob/7e26ef5d16658a5eef364ff8be8e6e0578d8ca3f/snapshot/lib/assets/SnapshotHelper.swift#L277

That will probably have the same issue. Most discrepancies are with the height so window and screen width will be the same, but at least on iPad 3rd gen for my app the window width is less than the screen/device width.

https://github.com/fastlane/fastlane/issues/13610#issuecomment-506463242 and following have some confirmations from users that this change improves the result.

That let / var line wasn't to do with this pull request. it was from some other changes when I pulled in master, probably should have put that fix elsewhere but guess it doesn't matter now!
Thanks all!


Warn when running an infinite epoch and overriding "epoch end" accumulating hooks

🚀 Feature
When the user configures Trainer(max_steps=-1, max_epochs=-1) an endless epoch runs, so overriding training_epoch_end or validation_epoch_end with val_check_interval==float can be a problem because they will keep outputs in memory indefinitely.
Motivation
Many users are not aware of the impact of overriding these hooks so infinite epochs open the door to "memory leaks".
Pitch
Raise a warning in this case informing the user of this behaviour.
Additional context
Proposed in https://github.com/PyTorchLightning/pytorch-lightning/issues/11480#issuecomment-1014594779

If you enjoy Lightning, check out our other projects! ⚡

Metrics: Machine learning metrics for distributed, scalable PyTorch applications.

Lite: enables pure PyTorch users to scale their existing code on any kind of device while retaining full control over their own loops and optimization logic.

Flash: The fastest way to get a Lightning baseline! A collection of tasks for fast prototyping, baselining, fine-tuning, and solving problems with deep learning.

Bolts: Pretrained SOTA Deep Learning models, callbacks, and more for research and production with PyTorch Lightning and PyTorch.

Lightning Transformers: Flexible interface for high-performance research using SOTA Transformers leveraging Pytorch Lightning, Transformers, and Hydra.

cc @borda @carmocca @awaelchli @ninginthecloud @daniellepintz @rohitgr7 @justusschock @kaushikb11

I'd like to work on this, could you assign this issue to me?

Hey @VedPatwardhan,
Yes, go on !

@carmocca I was thinking it also applies to the case of only max_steps=-1 being specified because it means an endless epoch, right?

I had a doubt while writing a test for the change being made. In the test_config_validator.py file, inside the test_fit_val_loop_config function, if a warning is created, then the BoringModel class is instantiated, could you please guide me what that class is all about, and do I need to instantiate the BoringModel class for the warning generated too? Also, what other properties of the model do I need to change before calling trainer.fit(model)?
Thanks in advance.

Here's one suggestion to test.

Create a new class that extends the BoringModel and implements the training_epoch_end.
Construct a Trainer which has settings configured for infinite training.
Call trainer.fit and confirm that you see a warning emitted from the configuration validator

You can follow the pattern for the validation_epoch_end and val_check_interval==float scenario described in the issue too.

Okay, I'll do that.

@ananthsub could you please help me understand what's going wrong? I think I've made the change, but many of the tests are failing.


Git Operations Test Server

The test coverage around git operations heavily relies on gitkit for self-contained tests. For E2E tests we also rely on directly accessing SaaS providers (e.g. GitHub) to ensure that our git implementation is consistently working across all out supported platforms.
Unfortunately, different SaaS providers support a different range of crypto algorithms, Git protocol versions, etc. Our upstream dependencies may introduce changes that may break specific features with said SaaS providers.
Instead of creating E2E tests for every single major SaaS provider, we could instead create or improving the existing git server to enable us to test features we want to support, and therefore quickly understand regression before releasing changes.
Below is a brain dump of specific features that are based on different issues that users have reported, and ideally a git test server would support:

HTTP specific settings

[ ] Be able to switch ON/OFF support for HTTP/1.1 and HTTP/2.
[ ] Reject Basic Auth when provided empty set of user/password.
[ ] Algorithm specific settings

[ ] TLS Ciphers

Git protocol specific settings

[ ] HTTP Dump Server
[ ] HTTP Smart Server
[ ] Git Protocol v2

SSH specific settings

[x] No simultaneous connections https://github.com/fluxcd/gitkit/pull/1
[x] Short timeout connections https://github.com/fluxcd/gitkit/pull/1
[ ] Single operation connections
[ ] Add random latency https://github.com/fluxcd/gitkit/pull/6
[x] Algorithm specific settings https://github.com/fluxcd/gitkit/pull/1

[x] Key Exchange Algorithm
[x] MACs
[x] Ciphers
[x] HostKey Algorithmn

These items should enable the test coverage to extend to support each one of the points above.

Now are are in course to be mono git implementation, a lot of this could actually be implemented and upstreamed.  The E2E use cases would be enough to detect changes problems.


Fixes #98: Add location endpoint docs

@lelouchB I've left the img_url fields empty since they would need to be changed later anyway.

@tim-richter
Nice, I will merge this as soon as the location endpoint becomes live.
Thanks


[FR] Prompt to set the path

Here is a Nitro config from a loosely related thread...
- hostname: project.test
  path: ~/Sites/projects
  version: "7.4"
  webroot: path/to/site/public
  xdebug: false
  blackfire: false

When adding a new Nitro site, you will see the following prompt:
Enter the webroot for the site [public]:

Can we get a similar prompt for the path?
Enter the path for the site [~/path/to/current-folder]:

Those two values obviously go hand-in-hand. Looking at the config example above, it's clear that specifying a webroot of public barely gets halfway there. It's not safe to assume that our current directory should be the path.
My ideal setup would have looked something like this...
Enter the path for the site [~/Sites/projects/path/to/site]:  ~/Sites/projects

Enter the webroot for the site [public]:  path/to/site/public  <--- Moved "path/to/site"

Would it be possible to add another prompt to manage the path value?

Hmmm, the add command accepts an argument for the path. You can use nitro add ~/Sites and it will use the path provided. Not exactly what you're asking for but wondering if that would work for your use case?

This is actually using nitro create to spin up a customized starter Craft site in a brand new Nitro container.

In that case, the path is defined and created for you as part of the download. There are quite a few options on the create command, might be worth looking at nitro create -h for more details.

That sounds promising! Except it doesn't look like there are any other flags beyond -h, --help...
❯ nitro create -h
Create project

Usage:
  nitro create [flags]

Examples:
  # create a new default craft project (similar to "composer create-project craftcms/craft my-project")
  nitro create my-project

  # bring your own git repo
  nitro create https://github.com/craftcms/demo my-project

  # you can also provide shorthand urls for github
  nitro create craftcms/demo my-project

Flags:
  -h, --help   help for create

Can I also use any flags destined for composer create-project? And if so, how could I steer the nitro.yaml to reflect my desired path and webroot?
I am mounting an entire development folder, which is why the path and webroot are so important during setup.

Hi, we are closing this issue as we have decided to retire Nitro, so no additional work will occur on this project. You can read the official blog post here https://craftcms.com/blog/retiring-craft-nitro. We appreciate everyones feedback and involvement and we look forward to refocusing our efforts on Cloud!
If you're looking for a new local development environment, we recommend DDEV and have a knowledge base article to help you with the transition: https://craftcms.com/knowledge-base/migrating-from-craft-nitro-to-ddev.


DeleteAsync() fails with column b.Id does not exist

Description
I have a PostgreSQL table named case_fees with a composite primary key (tenant_name, case_id, and id).  I am doing a bulk reload of the fees for a case so I want to delete all existing rows in the underlying table where the tenant_name and case_id match (notice that I am not looking at the third element of the primary key, id, which the id of a fee).
Basically, I want to execute the following query:
DELETE FROM case_fees WHERE tenant_name = "sd_ca" AND case_id = "668"
My code looks like this:
int rowsAffected = await this.dbContext.Fees.AsQueryable().Where(f => f.TenantName == tenantName).Where(f => f.CaseId == unencryptedCaseId).DeleteAsync();
Exception
If you are seeing an exception, include the full exceptions details (message and stack trace).
2019-10-19 16:21:00.404 -05:00 [Verbose] [PLADPLTRPATRICK] [0HLQKR8TO3L47:00000001] Deleting Fees for tenant sd_ca and case 668
2019-10-19 16:21:00.463 -05:00 [Debug] [PLADPLTRPATRICK] [0HLQKR8TO3L47:00000001] Compiling query model:
'from Fee f in DbSet<Fee>
where [f].TenantName == __tenantName_0
where [f].CaseId == __unencryptedCaseId_1
select new <>f__AnonymousType0{
    TenantName = [f].TenantName,
    CaseId = [f].CaseId,
    Id = [f].Id
}
'
2019-10-19 16:21:00.470 -05:00 [Debug] [PLADPLTRPATRICK] [0HLQKR8TO3L47:00000001] Optimized query model:
'from Fee f in DbSet<Fee>
where [f].TenantName == __tenantName_0
where [f].CaseId == __unencryptedCaseId_1
select new <>f__AnonymousType0{
    TenantName = [f].TenantName,
    CaseId = [f].CaseId,
    Id = [f].Id
}
'
2019-10-19 16:21:00.501 -05:00 [Debug] [PLADPLTRPATRICK] [0HLQKR8TO3L47:00000001] (QueryContext queryContext) => IEnumerable<<>f__AnonymousType0> _InterceptExceptions(
|__ source: IEnumerable<<>f__AnonymousType0> _ShapedQuery(
|   |__ queryContext: queryContext,
|   |__ shaperCommandContext: SelectExpression:
|   |       SELECT f.tenant_name AS "TenantName", f.case_id AS "CaseId", f.id
|   |       FROM case_fees AS f
|   |       WHERE (f.tenant_name = @__tenantName_0) AND (f.case_id = @__unencryptedCaseId_1),
|   |__ shaper: (QueryContext queryContext | ValueBuffer f) => new <>f__AnonymousType0{
|           TenantName = string TryReadValue(f, 0, Fee.TenantName),
|           CaseId = string TryReadValue(f, 1, Fee.CaseId),
|           Id = string TryReadValue(f, 2, Fee.Id)
|       }
|__ ),
|__ contextType: data_sync_service.Server.ApplicationDbContext,
|__ logger: DiagnosticsLogger<Query>,
|__ queryContext: Unhandled parameter: queryContext)

...

2019-10-19 16:21:00.654 -05:00 [Error] [PLADPLTRPATRICK] [0HLQKR8TO3L47:00000001] Loading cases file failed: SaveCaseFeesToDatabase() for tenant sd_ca failed to save 101 case fees for case 668: SaveFees() failed to store fees for tenant sd_ca and case ID 668: 42703: column b.Id does not exist
data_sync_service.Server.Exceptions.CasesStoreRepositoryException: SaveCaseFeesToDatabase() for tenant sd_ca failed to save 101 case fees for case 668: SaveFees() failed to store fees for tenant sd_ca and case ID 668: 42703: column b.Id does not exist ---> data_sync_service.Server.Exceptions.DatabaseRepositoryException: SaveFees() failed to store fees for tenant sd_ca and case ID 668: 42703: column b.Id does not exist ---> Npgsql.PostgresException: 42703: column b.Id does not exist
   at Npgsql.NpgsqlConnector.<>c__DisplayClass161_0.<<ReadMessage>g__ReadMessageLong|0>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at Npgsql.NpgsqlConnector.<>c__DisplayClass161_0.<<ReadMessage>g__ReadMessageLong|0>d.MoveNext() in C:\projects\npgsql\src\Npgsql\NpgsqlConnector.cs:line 1032
--- End of stack trace from previous location where exception was thrown ---
   at Npgsql.NpgsqlDataReader.NextResult(Boolean async, Boolean isConsuming) in C:\projects\npgsql\src\Npgsql\NpgsqlDataReader.cs:line 444
   at Npgsql.NpgsqlDataReader.NextResult() in C:\projects\npgsql\src\Npgsql\NpgsqlDataReader.cs:line 332
   at Npgsql.NpgsqlCommand.ExecuteDbDataReader(CommandBehavior behavior, Boolean async, CancellationToken cancellationToken) in C:\projects\npgsql\src\Npgsql\NpgsqlCommand.cs:line 1218
   at Npgsql.NpgsqlCommand.ExecuteNonQuery(Boolean async, CancellationToken cancellationToken) in C:\projects\npgsql\src\Npgsql\NpgsqlCommand.cs:line 1042
   at Npgsql.NpgsqlCommand.ExecuteNonQuery() in C:\projects\npgsql\src\Npgsql\NpgsqlCommand.cs:line 1025
   at Z.EntityFramework.Plus.BatchDelete.Execute[T](IQueryable`1 query) in C:\Repos\ZZZ\Z.EntityFramework.Plus\shared\Z.EF.Plus.BatchDelete.Shared\BatchDelete.cs:line 378
   at System.Threading.Tasks.Task`1.InnerInvoke()
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location where exception was thrown ---
   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot)
--- End of stack trace from previous location where exception was thrown ---
   at data_sync_service.Server.Repositories.DatabaseRepository.SaveFees(String tenantName, String unencryptedCaseId, List`1 fees) in d:\src\cap\data-sync-service\data-sync-service\Server\Repositories\DatabaseRepository.cs:line 53
   --- End of inner exception stack trace ---
   at data_sync_service.Server.Repositories.DatabaseRepository.SaveFees(String tenantName, String unencryptedCaseId, List`1 fees) in d:\src\cap\data-sync-service\data-sync-service\Server\Repositories\DatabaseRepository.cs:line 69
   at data_sync_service.Server.Repositories.CasesStoreRepository.SaveCaseFeesToDatabase(String tenantName, List`1 caseFeeWrappers) in d:\src\cap\data-sync-service\data-sync-service\Server\Repositories\CasesStoreRepository.cs:line 127
   --- End of inner exception stack trace ---
   at data_sync_service.Server.Repositories.CasesStoreRepository.SaveCaseFeesToDatabase(String tenantName, List`1 caseFeeWrappers) in d:\src\cap\data-sync-service\data-sync-service\Server\Repositories\CasesStoreRepository.cs:line 140
   at data_sync_service.Server.Repositories.CasesStoreRepository.StoreCases(String tenantName, List`1 cases) in d:\src\cap\data-sync-service\data-sync-service\Server\Repositories\CasesStoreRepository.cs:line 48
   at data_sync_service.Server.Controllers.api.CaseDataSyncController.LoadFile(CaseDataLoadRequest payload) in d:\src\cap\data-sync-service\data-sync-service\Server\Controllers\api\CaseDataSyncController.cs:line 72

Further technical details

EF version:  2.2.4
EF Plus version:  2.0.8
Database Provider:  PostgreSQL 11.5-R1

It seems like the problem has to do with the generated query trying to use the Id field when that should not be required for this delete query....

Hello @rpatrick00 ,
Do you think you could provide a project sample with this issue?
It will help my developer investigate the issue more efficiently.
We now always ask for a project sample even if the issue is easy to reproduce. As a free product, we must find some way to save time to offer an overall better experience for everyone and release fixes faster.
You can send it to<EMAIL_ADDRESS>if you need to keep the source private
Best Regards,
Jonathan

Performance Libraries
context.BulkInsert(list, options => options.BatchSize = 1000);
Entity Framework Extensions • Entity Framework Classic • Bulk Operations •  Dapper Plus
Runtime Evaluation
Eval.Execute("x + y", new {x = 1, y = 2}); // return 3
C# Eval Function • SQL Eval Function


Advertise iris.experimental.stratify in README.

See https://github.com/SciTools/iris/issues/3515#issuecomment-1309054877.

Thanks @bjlittle!


Restrict access to user or group

I enabled the require user assignment and restricted access to some users, works well with authorized users.
Not authorized users receive the "internal server error" page
this is the server log:
[2021-01-20 07:59:23,051] ERROR in app: Exception on /auth/redirect [GET]
Traceback (most recent call last):
File "C:\Program Files (x86)\Python37-32\lib\site-packages\flask\app.py", line 2292, in wsgi_app
response = self.full_dispatch_request()
File "C:\Program Files (x86)\Python37-32\lib\site-packages\flask\app.py", line 1815, in full_dispatch_request
rv = self.handle_user_exception(e)
File "C:\Program Files (x86)\Python37-32\lib\site-packages\flask\app.py", line 1718, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "C:\Program Files (x86)\Python37-32\lib\site-packages\flask_compat.py", line 35, in reraise
raise value
File "C:\Program Files (x86)\Python37-32\lib\site-packages\flask\app.py", line 1813, in full_dispatch_request
rv = self.dispatch_request()
File "C:\Program Files (x86)\Python37-32\lib\site-packages\flask\app.py", line 1799, in dispatch_request
return self.view_functionsrule.endpoint
File "C:\Program Files (x86)\Python37-32\lib\site-packages\ms_identity_web\flask_blueprint_init_.py", line 45, in aad_redirect
afterwards_go_to_url=post_sign_in_url)
File "C:\Program Files (x86)\Python37-32\lib\site-packages\ms_identity_web_init_.py", line 40, in assert_adapter
return f(self, *args, **kwargs)
File "C:\Program Files (x86)\Python37-32\lib\site-packages\ms_identity_web_init_.py", line 131, in process_auth_redirect
raise oae
File "C:\Program Files (x86)\Python37-32\lib\site-packages\ms_identity_web_init_.py", line 108, in process_auth_redirect
self.parse_redirect_errors(req_params)
File "C:\Program Files (x86)\Python37-32\lib\site-packages\ms_identity_web_init.py", line 213, in _parse_redirect_errors
raise OtherAuthError("Unknown error while parsing redirect")
ms_identity_web.errors.OtherAuthError: Unknown error while parsing redirect
This issue is for a: (mark with an x)
- [ ] bug report -> please search issues before submitting
- [ ] feature request
- [X ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

On Azure application properties Enable "User assignment required"

Expected/desired behavior

Page like "you don't have access to the application"

OS and Version?

Windows 7, 8 or 10. Linux (which distribution). macOS (Yosemite? El Capitan? Sierra?)
W10

Versions

python 3.7

Hi Pavants,
Thanks for the detailed report. We will be adding functionality for filtering by security group, by application roles, and/or user assignment in another chapter as a more advanced scenario.
We would also likely benefit from surfacing AAD error better in the UI!
Regards,
Sam

Hi Pavants,
Thanks for the detailed report. We will be adding functionality for filtering by security group, by application roles, and/or user assignment in another chapter as a more advanced scenario.
We would also likely benefit from surfacing AAD error better in the UI!
Regards,
Sam


Polling error

error: [polling_error] {"code":"ETELEGRAM","message":"ETELEGRAM: 409 Conflict: terminated by other getUpdates request; make sure that only one bot instance is running"}
How do I fix this?

Read the error
You sure there's only one instance running?
On Wed, 24 Apr, 2019, 11:41 AM Rajwadkar07<EMAIL_ADDRESS>wrote:

error: [polling_error] {"code":"ETELEGRAM","message":"ETELEGRAM: 409
Conflict: terminated by other getUpdates request; make sure that only one
bot instance is running"}
How do I fix this?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/out386/aria-telegram-mirror-bot/issues/18, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AJBXB6AEM7P6BPK3LAJGAP3PR722HANCNFSM4HIAUXKA
.

U r trying to run bot instance 2nd time

I am the one who started this thread. I am sure there is only one instance running. Is there any workaround for this? I need to get this bot working asap. Now I am trying by creating a new Git and Heroku account. will that work?

No. Try creating a new bot but that still won't answer the question of why
there is another session running
On Wed, 24 Apr, 2019, 12:59 PM Rajwadkar07<EMAIL_ADDRESS>wrote:

I am the one who started this thread. I am sure there is only one instance
running. Is there any workaround for this? I need to get this bot working
asap. Now I am trying by creating a new Git and Heroku account. will that
work?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/out386/aria-telegram-mirror-bot/issues/18#issuecomment-486103588,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJBXB6HPFNN67EASHG34T6TPSAD67ANCNFSM4HIAUXKA
.


Update the vendoring of github.com/opencontainers/selinux

THis should make libpod easier to build on non linux platforms.
Signed-off-by: Daniel J Walsh<EMAIL_ADDRESS>

@vbatts @baude @mheon @umohnani8 @TomSweeneyRedHat PTAL

LGTM once tests green

bot, retest this please

LGTM

Congrats on PR #1000 @rhatdan
@rh-atomic-bot r+

Me thinks @rhatdan was hiding in the weeds waiting to grab PR #1000.  Nice milestone all for Podman!
Oh yeah, belated LGTM.

@mheon Do I get a reward?

@rhatdan There were cookies, but I ate them all :cry:

🍪🍪🍪🍪🍪🍪


Connect to SAP HaaS database with direct sql port

Does the PyHDB driver support connect to SAP HaaS database with direct sql  host/port pair ?
Here I got error "pyhdb.exceptions.DatabaseError: only secure connections are allowed" as I did not find where to pass the secure parameters in pyhdb.connect(....).

Hi BigNuoLi, I was struggling with same issue but looks like they haven't made it compatible with HaaS yet. I've found workaround here: https://github.com/SAP/PyHDB/issues/107

Hi, sarthak0403,
Thanks a lot.
I follow your solution to change my forked codes, and I can access my HaaS DB now.
👍


Wizard "Clear" fields

Is your feature request related to a problem? Please describe.
When I set up a summary in the wizard, I fill out the top fields. Then I go and select a Parent Object and click Confirm. After I confirm, there's no way to get out of that selection without refreshing.
Describe the solution you'd like
"Clear" buttons next to the "Confirm" buttons for Parent Object and Child Object. They would clear all the details below the field but none of the details above
Describe alternatives you've considered
Multi-page wizard
Additional context
Not a show-stopper, but could be useful for people who misunderstand what object is parent v. which is child at first. Or if someone selects Account Contact Role instead of Account by accident.

Closing as this related to the now deprecated "new" VF wizard.