AMBARI-24416. Component Versions Are Not Reported On Initial Status Commands Anymore

In Ambari 2.6, some status commands were able to supply the version of the component they were running for. This was needed especially during upgrades to correct situations where components would fail to start but the processes were actually running and reporting.
During heartbeat registration, Ambari asked the agent to get the version in the next status command:
https://github.com/apache/ambari/blob/branch-2.6/ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java#L416-L419
The status command would place the version information from the structured out into the "extra" mapping, which would then be handled here via an event:
https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java#L599-L603
We need to replace this functionality so that component versions are reported on registration of agents.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/3486/
Test PASSed.


Output css rather than inline

I'm having trouble figuring out how to output all the scss into a css file during development. Just like an app.js file is automatically injected into the app html I'd need a css file to be injected too. I'm guessing the ExtractTextPlugin is involved, I've tried playing around with it but nothing seemed to work.
Anyone had the same issue that could point me into the right way?
Thank you.

Have a look at /build/vue.conf.js, there's a call to a utils function which has an extract parameter.
Set this to true.
Just be warned that this will seriously slow down rebuilds during development, I can't recommend this.

Sweet thanks, I'll give it a try later. I need the css to be extracted too just because the app I'm building is being tested in a different environment so I need to reference the js and css files into the files of the app in the other env because js and css injection isn't working for some reason.

Will close this for now.


Try to make the Preferences/AppOptions initialization slightly more efficient

Please note: This patch contains a couple of micro-optimizations, hence I understand if it's deemed unnecessary.
Move the AppOptions initialization into the Preferences constructor, since that allows us to remove a couple of function calls, a bit of asynchronicity and one a loop that's currently happening in the early stages of the default viewer initialization.
Finally, move the Preferences initialization to occur a tiny bit earlier since that cannot hurt given that the entire viewer initialization depends on it being available.

/botio xfatest

/botio xfatest


Show number of document locations next to the "Locations" button

It will be really useful to make the "Locations" button say "Show 1 location" or "Show 3 locations" for the current viewed document.

moved to eic


bevy_reflect: Get owned fields

Objective
Sometimes it's useful to be able to retrieve all the fields of a container type so that they may be processed separately. With reflection, however, we typically only have access to references.
The only alternative is to "clone" the value using Reflect::clone_value. This, however, returns a Dynamic type in most cases. The solution there would be to use FromReflect instead, but this also has a problem in that it means we need to add FromReflect as an additional bound.
Solution
Add a drain method to all container traits. This returns a Vec<Box<dyn Reflect>> (except for Map which returns Vec<(Box<dyn Reflect>, Box<dyn Reflect>)>).
This allows us to do things a lot simpler. For example, if we finished processing a struct and just need a particular value:
// === OLD === //
/// May or may not return a Dynamic*** value (even if `container` wasn't a `DynamicStruct`)
fn get_output(container: Box<dyn Struct>, output_index: usize) -> Box<dyn Reflect> {
  container.field_at(output_index).unwrap().clone_value()
}

// === NEW === //
/// Returns _exactly_ whatever was in the given struct
fn get_output(container: Box<dyn Struct>, output_index: usize) -> Box<dyn Reflect> {
  container.drain()[output_index]
}

Discussion

Is drain the best method name? It makes sense that it "drains" all the fields and that it consumes the container in the process, but I'm open to alternatives.

Changelog

Added a drain method to the following traits:

Struct
TupleStruct
Tuple
Array
List
Map
Enum

Do you have real use cases for those scenarios?

I don't really have any actual scenarios. I was just looking at the Struct trait and realized that there was no way for me to get an owned value back from it.
Here's a rather contrived example of when this could be useful:
#[derive(Reflect, FromReflect, Clone, PartialEq, Debug)]
struct Data {
  #[reflect(ignore)]
  value: String
}

#[derive(Reflect, FromReflect, Clone, PartialEq)]
struct SomeStruct {
  data: Data
}

let expected = SomeStruct {
  data: Data {
    value: String::from("Hello World")
  }
};

let dyn_struct: Box<dyn Struct> = Box::new(expected.clone());
// 1.
let field_cloned: Box<dyn Reflect> = dyn_struct.field("data").unwrap().clone_value();
// 2.
let field: Data = <Data as FromReflect>::from_reflect(field_cloned.as_ref()).unwrap();

assert_eq!(expected.data, field); // <- Panic!
// thread 'blah' panicked at 'assertion failed: `(left == right)`
//  left: `Data { value: "Hello World" }`,
// right: `Data { value: "" }`',

This cause of the failure here is due to ignoring Data::value. This causes a problem when we get to the two labeled steps that we need to perform in order to get the owned value.

We call Reflect::clone_value. Because Data is a struct, the returned Box<dyn Reflect> is actually a Box<DynamicStruct>. This is why we need to include step 2.
We then call FromReflect::from_reflect to get back the actual type. Because we ignored Data::value, the derived FromReflect implementation has no idea how to clone that value. So it defaults to using Default::default() to generate the ignored field.

This is why we end up with a blank string and a panicked assertion.
By using something like drain, we can actually take the value directly. No cloning or FromReflect-ing involved.
let dyn_struct: Box<dyn Struct> = Box::new(expected.clone());
let field: Data = dyn_struct.drain().pop().unwrap().take::<Data>().unwrap();
assert_eq!(expected.data, field);

Now, I say this is a contrived example since we (1) already know and have the concrete type of the data we want and (2) we could simply update FromReflect to be smarter (maybe using a #[reflect(cloneable)] attribute).

But yeah— no real-world example on hand. I do see that the compile-time cost could make this part of the PR not really worth it right now (or at least in need of more discussion). I can remove the changes on structs, tuple structs, and enums for the time being.

bors r+


Cannot look in with bash

Bug description
Can we get bash shell, so I can browse the files. I need to update some of the local foundry files, but bash fails to open on the container.
Steps to reproduce
Open docker terminal.

see this
Expected behavior
i would like to copy files and edit files inside
Container metadata
latest release

Relevant log output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

You can open a shell at /bin/sh.  This is the busybox shell based on dash.
docker run --rm -it --entrypoint /bin/sh felddy/foundryvtt:release
/home/foundry # sh --help
BusyBox v1.34.1 (2022-07-19 20:11:24 UTC) multi-call binary.

Usage: sh [-il] [-|+Cabefmnuvx] [-|+o OPT]... [-c 'SCRIPT' [ARG0 ARGS] | FILE [ARGS] | -s [ARGS]]

Unix shell interpreter

I hope this helps.


deprecate the repo

We changed ReSwift so the proof of concept here doesn't work the way it did before. See https://github.com/ReSwift/ReSwift/issues/303

I also think we should archive the repo afterwards. It'll pop up in the team overview otherwise. Archiving it may open up the opportunity for others to write a new version from scratch because there seems to be no competition -- but that's all just ad hoc reasoning :)

I don't think we should archive the repo, but we can also deprecate this in cocoapods. I'd hope that if a rewrite were to occur it should occur in this repo.

@Ben-G looks like you're the only one with permissions for this project in Cocoapods. Could you please run pod trunk deprecate ReSwiftRecorder and/or add myself/divine as owner(s)?


GLFW Build on macOS - GNU old-style field designator extension warning

Hello, so whenever I build the GLFW build of Borealis on macOS (I never got this warning in Ubuntu), I get the following repeated 50 times:
../library/include/borealis/views/button.hpp:135:5: warning: use of GNU old-style field designator extension [-Wgnu-designator]
    disabledBorderColor : "",
    ^~~~~~~~~~~~~~~~~~~~~
    .disabledBorderColor =

Is there a way to silence it?
I'm using macOS Big Sur (11.0.1), meson 0.57.1 from brew, and the latest version of the Xcode Developer utils.

Don't silence it, fix it 😉
Does replacing : with . work?

I'll try that

It gives a whole new error:
../library/include/borealis/views/button.hpp:55:5: error: use of undeclared identifier 'shadowType'
    shadowType . ShadowType::GENERIC,
    ^
../library/include/borealis/views/button.hpp:56:31: error: expected unqualified-id
    hideHighlightBackground . true,
                              ^
../library/include/borealis/views/button.hpp:56:5: error: use of undeclared identifier 'hideHighlightBackground'
    hideHighlightBackground . true,
    ^

Okay, actually, I'm going to try what the compiler suggested (since it's the compiler)

It's not the right syntax lol, the right syntax is .member = value

Alright, I fixed it! I'm going to open a Pull Request shortly.

Fixed in #156


python3Packages.uvloop: enable on python3.8

Motivation for this change
Allow build pass by disabling test. Isolated issue to test_sockets.py::TestAIOSockets::test_sock_close_add_reader_race.
This test is supposed to be skipped for asynico, but it isn't for some reason,
so we disable it instead.
See uvloop#284 (https://github.com/MagicStack/uvloop/pull/284) for full details. Don't know why this test isn't properly skipped.
Causing hydra build failure.
ZHF: #80379
Will backport to 20.03.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip". In progress
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

ping @jonringer (you disabled python38Packages.uvloop)
@NixOS/nixos-release-managers

I feel comfortable disabling this test is because I interpret this section of source
https://github.com/MagicStack/uvloop/blob/0e72f817ebb99cf432f72e9d7478e482c6ca0f3e/tests/test_sockets.py#L197-L200
as meaning it's supposed to be skipped anyways, and the failing test (asyncio version vs uvloop) seems to be only running the native asyncio library as a comparison.

Locally running nixpkgs-review pr 84223:
https://github.com/NixOS/nixpkgs/pull/84223
42 package marked as broken and skipped:
clang-sierraHack digitalbitbox linuxPackages_4_4.evdi linuxPackages_hardkernel_4_14.bcc linuxPackages_hardkernel_4_14.bpftrace linuxPackages_hardkernel_4_14.can-isotp linuxPackages_hardkernel_4_14.chipsec linuxPackages_hardkernel_4_14.digimend linuxPackages_hardkernel_4_14.evdi linuxPackages_hardkernel_4_14.mba6x_bl linuxPackages_hardkernel_4_14.nvidia_x11 linuxPackages_hardkernel_4_14.nvidia_x11_legacy390 linuxPackages_hardkernel_4_14.nvidiabl linuxPackages_hardkernel_4_14.prl-tools linuxPackages_hardkernel_4_14.rtl8814au linuxPackages_hardkernel_4_14.rtl8821au linuxPackages_hardkernel_4_14.rtl8821ce linuxPackages_xen_dom0.sch_cake linuxPackages_xen_dom0_hardened.sch_cake octave-jit octoprint php72Packages-unit.php_excel php72Packages-unit.v8 php72Packages-unit.v8js php72Packages.php_excel php72Packages.v8 php72Packages.v8js php73Packages-unit.php_excel php73Packages-unit.v8 php73Packages.php_excel php73Packages.v8 php74Packages-unit.pcs php74Packages-unit.php_excel php74Packages-unit.v8 php74Packages.couchbase php74Packages.pcs php74Packages.php_excel php74Packages.v8 python27Packages.caffe python37Packages.notify python38Packages.libselinux python38Packages.notify
32 package built:
datasette google-music-scripts mtprotoproxy python37Packages.aiorun python37Packages.asyncpg python37Packages.databases python37Packages.entrance python37Packages.entrance-with-router-features python37Packages.fastapi python37Packages.google-music python37Packages.httpx python37Packages.orm python37Packages.pproxy python37Packages.qiskit-ibmq-provider python37Packages.sanic python37Packages.sanic-auth python37Packages.sentry-sdk python37Packages.starlette python37Packages.uvicorn python37Packages.uvloop python38Packages.aiorun python38Packages.asyncpg python38Packages.databases python38Packages.fastapi python38Packages.google-music python38Packages.httpx python38Packages.orm python38Packages.pproxy python38Packages.starlette python38Packages.uvicorn python38Packages.uvloop sourcehut.listssrht

@GrahamcOfBorg build python37Packages.uvloop python38Packages.uvloop

Looks great, thanks!

main reason i disabled it was that it would hang. and prevent me from reviewing packages. If it's able to build reliably, then I'm more than happy to have it enabled again


Merge staging into production, 2024 Apr 04 edition

Changes:

Dependencies:

black bumped from 21.10b0 to 24.3.0
typing-extensions bumped from <IP_ADDRESS> to 4.0.1
click bumped from 7.1.2 to 8.0.0

Tests

main_app.tests.test_views.CsvExportTest updated to use subtests
main_app.tests.test_views.ChantCreateViewTest had several tests added to ensure the get_initial method works as expected

Ajax Concordance List - view removed
[x] Chant Create

we now pre-populate the form's "Office" field using the same office as the most recently modified chant in the same source (should work the same way as the "Feast" field)

[x] CSV Export

We now display the source's siglum in the "siglum" column, rather than each chant's individual siglum

There wasn't much to test for this one. @dchiller and/or @lucasmarchd01, can you quickly glance this over to make sure nothing is amiss? With an approval, we should be able to deploy this tomorrow.


[alerter]bugfix: fix the error according to the monitorid query.

[alerter]bugfix: fix the error according to the monitorid query.

@all-contributors please add @aystzh for code


OculusXRSDKDeviceManager error: The name 'Debug' does not exist in the current context

Describe the bug
When the switches to the Android platform after importing the MRTK, the following error is generated upon switching:

To reproduce
Steps to reproduce the behavior:

Import the MRTK packages to a new Unity project
Switch to the Android platofrm
See error

Expected behavior
Switching to the Android platform will not generate errors.
Your setup (please complete the following information)

Unity Version 2019.4.20f1

Target platform (please complete the following information)

Oculus Quest (Android)

Additional context
This issue happens with UPM and .unitypackages.

Looks like this was broken by me. Taking a look

Unity fails to build any example scene for the Android platform with this issue as well.

@elbuhofantasma https://github.com/microsoft/MixedRealityToolkit-Unity/pull/9373 should fix this!


Use draft.js as rich text editor

- Do you want to request a feature or report a bug?
A Feature
- What is the current behavior?
Very minimal rich text (Markdown) editor
- If the current behavior is a bug, please provide the steps to reproduce.
- What is the expected behavior?
A nice editor experience, something along the lines of Medium
- Please mention your node.js, and operating system version.
n.a.

I'm working on a Phenomic based site and I'm very excited about your CMS, can't wait for you to finish the transition to React!
Just came across some really cool libraries and was thinking it would be awesome if you could use these for the rich text editor! So check this demo out first, it's running medium-draft which is an extension on draft.js. Not only these are built in React, but there's already a plugin which can output Markdown and one which can import.
I'm not sure what your plans are for the editor, but if you used this stack that would be wonderful! N.b. at least from a user's point of view, I haven't developed with them.

Hi @daaain.
When porting the CMS to React, we started using Draft.js for rich text editor.
Draft is really cool, but it still misses a few things we think are important (such as a nested document tree, which allows for the usage of tables, in eg.)
In our experience so far, ProseMirror stood out as the best match for the CMS needs (PR #149)
Thanks for participating in the discussion. I'm closing this issue, but feel free to reopen if something new appears.


Allow use of path appended to server address

Implemented fix to allow the use of an additional path appended to the host of the server address.  The path included in the server address is now included in the websocket and web request endpoints.

Thanks @LS-Erik, I've made some small changes and added a test file to make sure the common scenarios are working as expected
https://github.com/colyseus/colyseus-unity3d/blob/c7c55bada0ea34c22a368212d68df86a2728f1bd/Assets/Colyseus/Tests/Editor/ColyseusTests/ColyseusRequestTest.cs#L19-L78


Link to the distance API page

Forgot that this requires a manual step to wire the page into the website.
Since this is a area we can have manual error, we might want to introduce a CI check for the website, testing build, that all pages are references, etc.

Coverage remained the same at 100.0% when pulling<PHONE_NUMBER>95a37a177fe4753557486b7e6bc93b on isaacbrodsky:fix-distance-api-reference into cdd681934a7704521dc884117657af29ff75fc22 on uber:master.


non-k8s: KubeArmor panics when not-enabled policy type is received

Bug Report
General Information

Environment description - Any environment
Kernel version - Not relevant
Orchestration system version in use - Not relevant

To Reproduce

Modify make run target in KubeArmor's Makefile to something like below such that host policy is disabled:
cd $(CURDIR); DEBUG=true sudo -E ./kubearmor -k8s=false -logPath=/tmp/kubearmor.log -enableKubeArmorPolicy -defaultFilePosture block -defaultCapabilitiesPosture block -defaultNetworkPosture block

Once KubeArmor is running, send the below host policy by running karmor vm policy --gRPC=:32767 add <path-to-policy> :
apiVersion: security.kubearmor.com/v1
kind: KubeArmorHostPolicy
metadata:
  name: block-pkg-mgmt-tools-pingu-vm
spec:
  severity: 10
  message: "apt was attempted to be executed"
  tags:
  - ALERT
  nodeSelector:
    matchLabels:
      kubearmor.io/hostname: pingu
  process:
    matchPaths:
    - path: /usr/bin/sleep
  action:
    Block

You'll see that KubeArmor panics and dies with the below log:
     panic: runtime error: invalid memory address or nil pointer dereference
    [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x189052c]

    goroutine 424 [running]:
    github.com/kubearmor/KubeArmor/KubeArmor/policy.(*PolicyServer).HostPolicy(0xc00460c3c0, {0x1c94900?, 0xc0039e5990?}, 0xc003be38c0)
            /usr/src/KubeArmor/KubeArmor/policy/policy.go:62 +0xac
    github.com/kubearmor/KubeArmor/protobuf._PolicyService_HostPolicy_Handler({0x1c94900, 0xc00460c3c0}, {0x22822a8, 0xc00471ef60}, 0xc004689780, 0x0)
            /usr/src/KubeArmor/protobuf/policy_grpc.pb.go:203 +0x1a6
    google.golang.org/grpc.(*Server).processUnaryRPC(0xc00022d200, {0x22822a8, 0xc00471eed0}, {0x228afa0, 0xc00472d080}, 0xc0048fe000, 0xc0046086c0, 0x335bd18, 0x0)
            /go/pkg/mod/google.golang.org/grpc@v1.63.2/server.go:1369 +0xdf8
    google.golang.org/grpc.(*Server).handleStream(0xc00022d200, {0x228afa0, 0xc00472d080}, 0xc0048fe000)
            /go/pkg/mod/google.golang.org/grpc@v1.63.2/server.go:1780 +0xe8b
    google.golang.org/grpc.(*Server).serveStreams.func2.1()
            /go/pkg/mod/google.golang.org/grpc@v1.63.2/server.go:1019 +0x8b
    created by google.golang.org/grpc.(*Server).serveStreams.func2 in goroutine 436
            /go/pkg/mod/google.golang.org/grpc@v1.63.2/server.go:1030 +0x125

Similar behavior is observed when container policy is disabled.
Expected behavior
KubeArmor should not panic and just log OR send back the response that policy enforcement for this kind (KubeArmorPolicy/KubeArmorHostPolicy) is not enabled.

Related to https://github.com/kubearmor/KubeArmor/issues/1321

I'm interested in working on this issue @DelusionalOptimist

Hi , I was hoping to contribute to KubeArmor and had setup my environment and the github repo, can someone tell me how to get started further, how do i learn more about it , I haven't used it before and am finding the issue a bit confusing , where do i use the 1st step and what is it used for ?


Solve a memory leak in CFLocaleGetSystem()

These objects have a real (live) retain count rather than being immortal on Swift; do not overretain as it is not a no-op. rdar://88461050

@swift-ci please test and merge

@swift-ci please test and merge

@swift-ci please test and merge

@swift-ci please test and merge

@swift-ci please test


How to not loose values or not read values twice (synchronisation)

The Energy meters made by www.janitza.de update their internal modbus registers every 0.2 seconds.
When I poll these values each 0.2 seconds over TCP, I want to:

not loose an updated value because in my setup each value is important
not read a value twice (or discard a duplicated value an immediately try to catch the next updated value)
But because afaik modbus does not provide any synchronisation method. I'm not sure how and where to solve this. Does anyone have an idea?

( https://www.janitza.de/betriebsanleitungen.html?file=files/download/manuals/current/UMG96RM/EL/Janitza-Manual-UMG96RM-EL-Modbus-adress-list-and-formulary-en.pdf )

I understand what you mean, and this is not an answer to how to do that but rather suggestions.
From what you describe I understand that you want to calculate energy. I have to say that the method you've chosen is not used for that purpose. That one is more lime monitoring purposes. Imagine your request for some reason is longer than 0.2? First, you must use ticker to send requests, in that case, you can send a new request while you did not get a previous one. You must handle that. And what does connection lose for a minute? Then your data is not reliable. It is never reliable. Then what is the purpose to get data if you cannot reliably estimate it?
The solution on meter there is impulse output. For instance, one pulse is 100W. It is very hard to miss impulse. So, you use PLC and calculate impulses. You can also measure the time between impulses, and you can also show current consumption and other valuable and reliable data.


[BUG] the SecurityClient.PurgeDeleted method is not behaving Synchronously

Describe the bug
A clear and concise description of what the bug is.
Exception or Stack Trace
Azure.RequestFailedException: 'Service request failed.
Status: 409 (Conflict)
Content:
{"error":{"code":"Conflict","message":"Secret is currently being deleted.","innererror":{"code":"ObjectIsBeingDeleted"}}}
Headers:
Cache-Control: no-cache
Pragma: no-cache
Server: Microsoft-IIS/10.0
x-ms-keyvault-region: eastus2
x-ms-request-id: 029e790c-d967-41a7-a1f8-cb9a8875668b
x-ms-keyvault-service-version: <IP_ADDRESS>5
x-ms-keyvault-network-info: addr=<IP_ADDRESS>;act_addr_fam=InterNetwork;
X-AspNet-Version: 4.0.30319
X-Powered-By: ASP.NET
Strict-Transport-Security: max-age=31536000;includeSubDomains
X-Content-Type-Options: nosniff
Date: Wed, 07 Aug 2019 21:12:05 GMT
Content-Length: 121
Content-Type: application/json; charset=utf-8
Expires: -1
To Reproduce
Follow the docs to setup a KeyVault and credentials for testing - https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/keyvault/Azure.Security.KeyVault.Secrets/Readme.md
Follow the docs to enable soft-delete mode using cli - https://docs.microsoft.com/en-us/azure/key-vault/key-vault-soft-delete-cli
Run the following code to purge a deleted key
The last line in the code snippet fails because the PurgeDeleted method is still pending.
Code Snippet
            // Create a new secret client using the default credential from Azure.Identity
            SecretClient client = new SecretClient(
                vaultUri: new Uri("https://ux-bash-keyvault.vault.azure.net/"),
                credential: new DefaultAzureCredential());

            Secret value = client.Set("my-soft-delete-test", "keyValue");
            client.Delete("my-soft-delete-test");
            client.PurgeDeleted("my-soft-delete-test");
            client.Set("my-soft-delete-test", "keyValue"); //operation fails because PurgeDeleted is not synchronous

Expected behavior
Expecting to be able to reuse a key name when PurgeDeleted is complete.
Setup (please complete the following information):

OS: [Windows 10]
IDE : [Visual Studio 2019]
Version of the Library used - Azure.Security.KeyVault.Secrets -Version 4.0.0-preview.2

Additional context
An async method for PurgeDeleted also exists. This behavior was observed on PurgeDeleted which is expected to perform synchronously.
Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[x] Bug Description Added
[x] Repro Steps Added
[x] Setup information Added

Looks like the link to the KeyVault Readme is changing.

@KSchlobohm thanks for pointing this out! We'll take a look at this!

Thank you for the feedback! Unfortunately, deleting keys or secrets in a soft delete-enabled vault is not immediate, and purging requires subsequently trying to get the delete object repeatedly until it no longer exists. Generally, we try to avoid multiple operations in the client library to avoid performance issues by default in client applications. While we decide how to address this issue, you can use a retry loop like we do in our test infrastructure.

Unfortunately, the service does not provide a way to efficiently pull using, for example, a long-running operation like with Create Certificate. We will document that users can poll in a loop similar to how we do in tests if needed.

Can we change the name of the method to be async and alter the method so that it returns control flow to the application when the operation is completed?

As of the release 1.0.0 we have updated this method to return a DeletedSecretOperation which is an LRO poller you can use to determine when the delete operation is complete.

The method itself is async, but the server returns right away before a secret it purged. There's nothing the client can poll on. The only way to know that we can create a new secret is to actually try to create a secret, but in most practical cases if a customer was purging a secret they wouldn't want it created again. At least, we can't do that on behalf of customers for that reason.
Instead, if you have a practical scenario in which you're trying to create a key after purging, you'd have to do so in a loop as explained above until it works. However, you can always create a new secret with the same name and a new version is created. This works for secrets, keys, and certificates.


Create version tags of images on release, so users can install stable versions

At the moment, on release we build the podvm container images and tag them as latest, but don't create a version tag e.g. v0.6.0 of these images, so users can't go back to previous release if they want to.
We also don't produce any tags for the webhook and cloud-api-adaptor images, so if changes are made post release for new function that introduces incompatibilities, then users won't be able to easily find the release version.
To fix these I think we should create tags for each release and we can update the kustomization overlays to point to the version based release. This would mean people could use the release tag to install the stable version of peer pods.

@stevenhorsman on the 0.7.0 I pinned the cloud-api-adaptor image (https://github.com/confidential-containers/cloud-api-adaptor/pull/1239) but I used the commit sha-1 of the built release candidate image. Here we have chicken-and-eggs problem (again) to automate this: if the cloud-adaptor:<RELEASE> image is built at the time we cut the release, how can we have the kustomization overlays updated before tagging? :)
I think we will have a similar problem for the webhook image.
Are the podvm images referenced somewhere in the code? If not, yeah, I need no problem on tagging them at the time we cut the release.


having darker popups

Is your feature request related to a problem? Please describe.
is there any way to have a draker sidebars like for NvimTree?
I have tested different setups but I couldn't make it work. (the contrast option has no change)
Describe the solution you'd like
add an option to have darker popups.

hey @mohammadne can you give more details on what are the expectations? Also, can you share some configs you've tried please?

closing due to no more feedback


Fixes #issue
What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.1
[ ] 3.0
[ ] 2.5
[ ] 2.4

[FE PR Coverage Check]
:disappointed: fail : 11 / 19 (57.89%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/system/ComputeNode.java
0
2
00.00%
[423, 424]

:large_blue_circle:
com/starrocks/system/HeartbeatMgr.java
5
11
45.45%
[197, 198, 199, 200, 202, 310]

:large_blue_circle:
com/starrocks/system/FrontendHbResponse.java
6
6
100.00%
[]


LinkedIn Profile Integration for Contributors

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Summary 💡
Description:
I have added a new feature to our project's About page, which I believe will enhance our contributors' profiles and make it easier for our audience to connect with them on LinkedIn.
How It Works:
The LinkedIn button appears next to the contributor's name and bio in their respective cards on the About page.
When users click on the LinkedIn button, it will open a new tab or window and take them directly to the contributor's LinkedIn profile.

Benefits:
Enhanced Networking: This feature makes it seamless for our audience to connect with our contributors, providing them with an opportunity for networking and professional development.
Increased Contributor Engagement: By showcasing our contributors' LinkedIn profiles, we can boost their engagement and visibility within our project's community and industry.
Credibility and Trust: It adds an extra layer of credibility and trust as it verifies the authenticity of the contributors, making our project more reliable.
Professionalism: It's a professional touch that can help our project stand out and show that we value and support our contributors' professional growth.
User Engagement: Users are more likely to engage with our contributors when they can easily connect with them on a popular professional platform like LinkedIn.
Examples 🌈
No response
Motivation 🔦
i was not able to connect with some of the contributors by searching them on linkedin so wanted a connection button here

Added Linkedin Button


Spellchecking

Summary of the Pull Request
Since we are now doing spellchecking, I thought I'd help out.

References
#4799

PR Checklist

[X] CLA signed. If not, go over here and sign the CLA
[X] Tests added/passed

Detailed Description of the Pull Request / Additional comments
Spell Checks

Validation Steps Performed

Yes let us remove those

except some commands use the lowercase variant, and those commands are documented here, so... that is where things get tricky

@pi1024e: You can add entries into patterns to specifically accept a long string (technically text matching pattern you added is removed before it parses things looking for unrecognized items).
An example pattern:
\b(?:)powershell -noprofile\b

I'm going to have to change how the output works, in theory you'd want to be told to remove entries from the whitelist, but right now you'll only see that if you add one misspelling or if you run w/ debug... For the time being, I'd suggest making an extra local branch in your repository on top of this branch and having it have a single misspelling -- you'd never create a PR from this branch nor merge it. You can then use the output to remove whitelist entries from this branch.
I was trying to avoid having the bot be too chatty, but I think people will probably be ok (or at least you would) w/ being told how to remove things from the whitelist.

Right now the spell checker is actively ignoring .yml files. You could work on removing that exclusion:
https://github.com/microsoft/terminal/blob/31efd69149c3b23c000c7491f98254356b1eaf34/.github/actions/spell-check/excludes.txt#L52
I think the reason I excluded .yml files is that they often have shas in them, but a glance at this repository indicates that they don't, so one could (should?) remove that exclusion.


Length of I2C Bus wires

I have my FF-Gotek in a external case connected to my Amiga 2000. The FF-OSD BluePill is inside the A2000. In the FF-Gotek there is a OLED connected parallel.
The connection of the I2C Bus is over a cable, 50cm, pluggable. This setup works sometimes, but not reliable.
May the length if the cable be the problem? Any ideas to make it working reliable?

Pull-up resistors in the i2c display may be too high for the wire capacitance. You could try 1k resistors soldered from each of SDA and SCL, both connecting to VCC.

Sorry not in the i2c display, in your FF-OSD. Try replacing the 4.7k resistors, or double them up (to halve the effective resistance).

I can confirm that it can work fine over that length of I2C.
I have a similar arangement running over a 1.8 Meter (M-M PS/2) sheilded cable from the FF-GOTEK to my FF-OSD also with an OLED fitted in parrallel inside the FF-GOTEK. I'm also running a rotary encoder over seperate conductors of the same cable.
In my case it worked fine with out any modifications just the 4.7K pullups at the FF-OSD end.

I can confirm that reducing the
pull-up resistor to 2k make it work here.
Thanks for helping me.


no responce

when I launch the .exe with the config file seeming like it's correct it says that it successfully logged in, it shows the status thing but doesnt respond to my messages. How could I fix this?

Fixed?

Fixed?


Unable to build micro_speech for Sparkfun Edge

@tensorflow/micro
System information

Host OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu
TensorFlow installed from (source or binary): source
Tensorflow version (commit SHA if source): 44400dfcde6e39aca68c4bc103c2e4e15b5379c5
Target platform (e.g. Arm Mbed OS, Arduino Nano 33 etc.): Sparkfun Edge

Describe the problem
I'm trying to build the micro_speech example for Sparkfun Edge from the master branch, but getting a few compile errors.
Please provide the exact sequence of commands/steps when you ran into the problem
I am following the steps at:
https://github.com/tensorflow/tensorflow/tree/master/tensorflow/lite/micro/examples/micro_speech
The very first step,
make -f tensorflow/lite/micro/tools/make/Makefile TARGET=sparkfun_edge TAGS="cmsis-nn" micro_speech_bin
results in the following compile errors and warnings:
tensorflow/lite/micro/kernels/cmsis-nn/softmax.cc: In function 'void tflite::ops::micro::activations::SoftmaxQuantized(const TfLiteTensor*, TfLiteTensor*, const tflite::SoftmaxParams&)':
tensorflow/lite/micro/kernels/cmsis-nn/softmax.cc:97:30: error: 'input_shape' was not declared in this scope
     const int trailing_dim = input_shape.DimensionsCount() - 1;
                              ^~~~~~~~~~~
tensorflow/lite/micro/kernels/cmsis-nn/softmax.cc:97:30: note: suggested alternative: 'initstate'
     const int trailing_dim = input_shape.DimensionsCount() - 1;
                              ^~~~~~~~~~~
                              initstate
tensorflow/lite/micro/kernels/cmsis-nn/softmax.cc:99:60: error: 'output_shape' was not declared in this scope
         MatchingFlatSizeSkipDim(input_shape, trailing_dim, output_shape);
                                                            ^~~~~~~~~~~~
tensorflow/lite/micro/kernels/cmsis-nn/softmax.cc:99:60: note: suggested alternative: 'outer_size'
         MatchingFlatSizeSkipDim(input_shape, trailing_dim, output_shape);
                                                            ^~~~~~~~~~~~
                                                            outer_size

Any help is super appreciated. Cheers!

@dmanning23 sorry for the late reply on this. Is this still an issue? I tried it on the latest baseline and it seem to work.

make -f tensorflow/lite/micro/tools/make/Makefile TARGET=sparkfun_edge TAGS="cmsis-nn" clean clean_downloads
make -f tensorflow/lite/micro/tools/make/Makefile TARGET=sparkfun_edge TAGS="cmsis-nn" micro_speech_bin


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_ccl1qmvrk2/clone/recipe/meta.yaml:15: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_ccl1qmvrk2/clone/recipe/meta.yaml:21: missing_wheel: For pypi packages, wheel should be present in the host section
WARNING: /tmp/abs_ccl1qmvrk2/clone/recipe/meta.yaml:39: missing_description: The recipe is missing a description
ERROR: /tmp/abs_ccl1qmvrk2/clone/recipe/meta.yaml:39: missing_dev_url: The recipe is missing a dev_url
ERROR: /tmp/abs_ccl1qmvrk2/clone/recipe/meta.yaml:39: missing_license_family: The recipe is missing the about/license_family key.
Errors were found


Vnet to VNet

https://github.com/Azure/azure-content/blob/master/articles/vpn-gateway/virtual-networks-configure-vnet-to-vnet-connection.md
@deneha
this page uses the old UI, old command line and not ARM.
can u update it?

@sahin Thanks for raising this issue.  You are welcome to suggest changes to documentation using the GitHub functionality.  We'll forward the suggestions to the author of the page.

Unfortunately, there is no documentation with the new arm and new virtual networks, I connected to support , I asked for hands on help. if I have anything I will send, but if the author can be quick and update for the new ARM and new virtual network. it will be super great. We really need it.

@sahin I'll let our team know about this request.
@cherylmc Could you please review this issue?

I'll check with the product team on this. This particular article would not be updated, as it is valid for the classic Service Management VNets, which still exist in production for many customers. I would write a new article specifically for Resource Manager. The first article would likely be PowerShell.

@cherylmc thanks. I contacted the support but they seem they cannot help that much. I really really need vnet - vnet Resource Manager very urgently. When do you think u can write one?

We are working on that at the moment. It looks like I should have something ready next week.

@cherylmc , I was getting hands on help from azure support.
old vn  is <IP_ADDRESS>/22 mll-us-east
Gateway <IP_ADDRESS>/29

new ARM VN <IP_ADDRESS>/22 mll-eastus2-network
Gateway subnet <IP_ADDRESS>/29 # <IP_ADDRESS> - <IP_ADDRESS>

    New-AzureLocalNetworkGateway -Name mll-us-east-local-network-old `
    -Location "East US" -AddressPrefix "<IP_ADDRESS>/22" `
    -GatewayIpAddress "<IP_ADDRESS>" -ResourceGroupName mll-eastus2-resource

    $ipaddress = New-AzurePublicIpAddress -Name mll-eastus2-network-gateway-ip `
    -ResourceGroupName mll-eastus2-resource -Location "East US 2" `
    -AllocationMethod Dynamic

    # create a sub net in the new portal UI
    # Gateway subnet <IP_ADDRESS>/29

    $subnet = Get-AzureVirtualNetworkSubnetConfig -Name GatewaySubnet `
    -VirtualNetwork (Get-AzureVirtualNetwork -Name mll-eastus2-network -ResourceGroupName mll-eastus2-resource)

    # <IP_ADDRESS> the first ip of the gateway subnet of new ARM vnet

    $ipconfig = New-AzureVirtualNetworkGatewayIpConfig `
    -Name ipconfig -PrivateIpAddress <IP_ADDRESS> `
    -SubnetId $subnet.id -PublicIpAddressId $ipaddress.id

    New-AzureVirtualNetworkGateway -Name mll-eastus2-network-gateway -ResourceGroupName mll-eastus2-resource `
    -Location "East US 2" -GatewayType Vpn -IpConfigurations $ipconfig `
    -EnableBgp $false -VpnType RouteBased

    Get-AzurePublicIpAddress -Name mll-eastus2-network-gateway-ip -ResourceGroupName mll-eastus2-resource

    Set-AzureVNetGatewayKey -VNetName mll-us-east `
    -LocalNetworkSiteName mll-eastus2-network -SharedKey XXXX

    ------

    Switch-AzureMode AzureResourceManager

    $vnet01gateway = Get-AzureLocalNetworkGateway -Name mll-us-east-local-network-old -ResourceGroupName mll-eastus2-resource

    $vnet02gateway = Get-AzureVirtualNetworkGateway -Name mll-eastus2-network-gateway -ResourceGroupName mll-eastus2-resource

New-AzureVirtualNetworkGatewayConnection -Name us-east2-us-east-connection `
    -ResourceGroupName mll-eastus2-resource -Location "East US 2" -VirtualNetworkGateway1 $vnet02gateway `
    -LocalNetworkGateway2 $vnet01gateway -ConnectionType IPsec `
    -RoutingWeight 10 -SharedKey 'XXXX'

Sounds like you are good to go, then! The article should be out there sometime later this week.

I'll ping back with the link when it's live. It looks like your settings are slightly different than what I am working with, so I'll run them by the product group PM that owns the technology. Thanks for providing!

@cherylmc thx.

Here's the link to the new doc. Hope this helps! https://azure.microsoft.com/documentation/articles/vpn-gateway-vnet-vnet-rm-ps/

@sahin It looks like this issue has been resolved.  I'm closing this issue.  Please comment if the issue should be reopened.


[AutoRelease] t2-imagebuilder-2023-03-16-26263(can only be merged by SDK owner)

https://github.com/Azure/sdk-release-request/issues/3928
Live test success
https://dev.azure.com/azure-sdk/internal/_build?definitionId=978
BuildTargetingString
azure-mgmt-imagebuilder
Skip.CreateApiReview
true

issue link:https://github.com/Azure/sdk-release-request/issues/3928

/check-enforcer override


Automated cherry pick of #2635: bugfix:

Cherry pick of #2635 on release/2.11.
#2635: bugfix:

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.11@9632f45). Click here to learn what that means.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             release/2.11   #2636   +/-   ##
==============================================
  Coverage                ?   7.15%
==============================================
  Files                   ?     456
  Lines                   ?   72477
  Branches                ?       0
==============================================
  Hits                    ?    5184
  Misses                  ?   66863
  Partials                ?     430

Flag
Coverage Δ

#aFlag
7.15% <0%> (?)

Impacted Files
Coverage Δ

pkg/compute/guestdrivers/kvm.go
3.59% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9632f45...825b92f. Read the comment docs.

/lgtm

/approve


Refuse to use commonjs modules in favor of esm

Benefits:
This will not provide any performance enhancement or any other technical benefits.
Goal:
unify the system of modules throughout the project, regardless of the language and runtime environment.
Blocked:
The electron is currently working very poorly with esm. In addition, there is a share of modules that can not work with esm syntax.
Related:

https://github.com/electron/electron/issues/21457

I hate commonjs, but I have no way to go from node to electron

I hate commonjs, but I have no way to go from node to electron

There are also problems with the electron builder, eslint.

Maybe this can help? https://github.com/xiaoxiangmoe/vite-plugin-commonjs-externals

Add commonjs external support for vite. Mainly to provide vite support for electron.

@danieledler The main obstacle is not vite. The electron does not support the ESM system in runtime very well.

https://github.com/electron/electron/issues/21457#issuecomment-1099904505

Re check this after electron v28 released

There is also a new major release 5 of Vite that might require the shift to ESM: https://vitejs.dev/guide/migration.html#deprecate-cjs-node-api

https://github.com/cawa-93/vite-electron-builder/discussions/974


feat(chromecast)!: Fork receiver app v1

To prepare for a v2 client and receiver app, this copies receiver.html (with some additional comments) to receiver-v1.html.  After merging this change, the registration for the v1 receiver app ID will be changed to point to receiver-v1.html.  This will free us to make breaking changes in receiver.html under a new app ID.
It is important for a smooth transition to make a copy of receiver.html first and not simply rename it, because there will be a transition period where some Chromecasts under test will still refer to the old URL.  This should be < 48 hours after merge.

No, git will always see it as a new file.  However, the overall history is still preserved.  You can see the development of v1 over time in receiver.html's history.


Does this still work?

What I want to know is does this work? If it does, I would recommend applying this technique to the other functions in the bot.

Rejected


feat: basic integration testing with packit + testing-farm + tmt

Introduce a minimal setup for integration tests of
insights-ansible-playbook-verifier. The tests are written using pytest.
The tests are wrapped as single "integration" test for tmt [1], which
makes it possible to run them automatically e.g. in testing-farm.
Extend the packit configuration to trigger tests on testing-farm after
the completion of the build jobs.

/packit test


Installing Ruby Fails: cannot set prseent on sure no implict conversion of Hash into string

Hi, Trying to install rubies with RVM and always getting stuck with the error:
change from 'absent' to 'present' failed: Could not set 'present' on ensure: no implicit conversion of Hash into String . This happens if I try to install one version of Ruby or any number of versions. The code passes puppet parser validate so the syntax is valid. Any idea on how to fix this?
Thanks!
    rvm_system_ruby {
      'ruby-2.5.1':
        ensure      => present,
        proxy_url   => $proxy_url;
      'ruby-2.3.4':
        ensure      => present,
        default_use => true,
        proxy_url   => $proxy_url;
      'ruby-2.4.1':
        ensure      => present,
        default_use => false,
        proxy_url   => $proxy_url;
    }

I'm going to close this based on its age. Please reopen this if you can still reproduce the error with the latest version.


doc: Misc cleanups

:tada: This PR is included in version 1.77.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


auditwheel can't repair some wheels

With Scipy:
auditwheel: error: cannot repair "/home/anubis/git/scipy/build/scipy-1.7.0.dev0+ababababab-py3-none-linux_x86_64.whl" to "manylinux_2_5_x86_64" ABI because of the presence of too-recent versioned symbols. You'll need to compile the wheel on an older toolchain.

#6 suffers from a similar issue, we run into limitations in auditwheel and how it is designed to be a CLI. Bundling libraries into wheels is not hard, we just need to fix the rpath files that link against them, so I think it would make sense to put that functionality into an external package we could use here.

This is not relevant anymore as of #26.


Built-in types and global scope methods and constants

There is no global scope in .NET so those methods and constants will be implemented in classes. Check the the list of API differences.
Progress on built-in types:

[ ] AABB
[ ] Array
[ ] Color
[ ] ColorArray
[ ] Dictionary
[ ] Image
[ ] InputEvent
[ ] InputEventAction
[ ] InputEventJoystickButton
[ ] InputEventJoystickMotion
[ ] InputEventKey
[ ] InputEventMouseButton
[ ] InputEventMouseMotion
[ ] InputEventScreenDrag
[ ] InputEventScreenTouch
[ ] IntArray
[x] Matrix3
[x] Matrix32
[ ] Nil
[ ] NodePath
[ ] Plane
[x] Quat
[ ] RID
[ ] RawArray
[ ] RealArray
[x] Rect2
[ ] String

Add extension methods for Godot's String methods missing in System.String.

[ ] StringArray
[x] Transform
[x] Variant

Used for implicit conversions.

[x] Vector2

Missing decimals method.

[ ] Vector2Array
[x] Vector3
[ ] Vector3Array

Some of these types may be unnecessary or implemented in a different way.

I'm wondering do you have already  plans on how you will implement Arrays? My main concern with arrays is the fact that resizing them will cause GC so it will be very bad idea to do this kind of stuff inside loop. From the other side using methods like append() is very easy and pleasant. Previously I was programming with java game library libGDX, which have successfully (in my opinion) found a middle ground. In general in libGDX when you wanted to use array which can modify its content dynamically you were able to create array which had some amount of items 'in reserve'.
Like you could define array which could allocate 100 entries during it's creation, despite the fact  that you put only 10 items inside. Then you are able to dynamically add/remove new items without resizing array (which in java is causing GC).
Here is libGDX array class api: https://libgdx.badlogicgames.com/nightlies/docs/api/com/badlogic/gdx/utils/Array.html
And here is the implementation: https://github.com/libgdx/libgdx/blob/master/gdx/src/com/badlogic/gdx/utils/Array.java

Also I have similar concerns when it comes to dictionaries. As I said I don't know how they work in c# but in java using those is causing GC. Because of that in libGDX they are reimplemented as well...
LibGDX map api: https://libgdx.badlogicgames.com/nightlies/docs/api/com/badlogic/gdx/utils/ArrayMap.html
LibGDX map implementation: https://github.com/libgdx/libgdx/blob/master/gdx/src/com/badlogic/gdx/utils/ArrayMap.java

@kubecz3k List class in C# does this: it won't allocate until you hit the capacity, or "reserve", and you can specify the capacity in the constructor. Similar to C++ vectors.
I'm not sure how optimized Mono's implementation of Dictionary is in terms of allocations though.

burn that bridge when you get to it. you're a lot more likely to have your application thrash because of sub-standard select-n+1 solutions or I/O thrashing than you are from a GC pause.

Done. There may be missing some tiny bits here (specially for the possible need of extension methods for Dictionary and Arrays since we are using Dictionary<object, object> and List<T>/T[]).


package.json small update

package.json has the little up ticks again that probably will cause issues

ok why does it do this


integrate protobuf with memory pooling

Current dependencies on/for this PR:

main

PR #112

PR #113   👈

This comment was auto-generated by Graphite.


Error when processing resource files with null/empty annotations

Kpt reads KRM resources from files, adds annotations config.kubernetes.io/index and config.kubernetes.io/path, processes them and writes them back to respective file paths in original order. There is an edge case where kpt is not creating/adding annotations if the annotations field is already specified in resource files and is null/empty.

@pwittrock Why are we returning nil here instead of err. As this logic is used everywhere, nil fields are not being matched without explicit error which is leading to confusion. How should PathGetter behave if there are nil fields.
metadata:
     annotations:

For this yaml input with nil annotations, but field exists, kyaml doesn't add annotations.
cc @mortent


Fix staging sprayproxy duplicated GH_APP_WEBHOOK_SECRET

GH_APP_WEBHOOK_SECRET is defined in the config at the repo level so using a "patch add" was resulting in duplicated variable:
spec:
  template:
    spec:
      containers:
      - args:
        env:
        - name: GH_APP_WEBHOOK_SECRET
        - name: GH_APP_WEBHOOK_SECRET
          valueFrom:
            secretKeyRef:
              key: webhook.secret
              name: pipelines-as-code-secret

Instead, patch the varialble using a strategic merge. In addition to fix the duplicate, this methodology do not rely on container or variable indices so also change the SPRAYPROXY_SERVER_BACKEND to use same mechanism for robusness and consistency reasons.

@hugares thanks for the fix. Personally I also prefer the more explicit patches instead of the replace directives.

/approve

/test appstudio-hac-e2e-tests

/retest

/retest

/retest

/retest

@enarha Could you re-apply LGTM and approved label

@sayan-biswas @enarha This is the last kube-linter issue for spray proxy, could you help getting it in then I will promote the change to prod once I see it working on staging

/retest-required

/retest-required

/retest

/retest

/lgtm


Add AirPlay support

As a player user I want to be able to cast content over AirPlay without any issues.
Remark: See observations in #111 and #113.
Acceptance criteria

AirPlay can be enabled in the demo.
The user experience is good for all kinds of contents (audio, video, on-demand, live, DVR, without protection or with Akamai token / DRM).
AirPlay can be used with playlists as well.

Tasks

[ ] 👺 Report error messages correctly when AirPlay is enabled (and if possible). Maybe display a more user-friendly message if not possible.
[ ] 🥷 Check that very long playlists work well (especially when resource loaders are involved).
[x] Check network and memory profiles.
[ ] If possible optimize forward and backward playlist navigation to minimize item creation (and thus master playlist retrieval).
[x] Check that continuous audio playback in background works (automatic chaining and backward / forward navigation).

If we keep the current investigation branch:

[ ] Find if there is a better AVQueuePlayer update strategy than update current item, then append other ones after a while.
[ ] Make collection suffix extraction safer if needed.
[ ] Restore player item settings (buffer size, live edge behavior, etc.).
[ ] Restore automaticallyLoadedAssetKeys support if meaningful.
[ ] Restore chunk size and DVR live edge size calculations.
[ ] Allow forward / backward navigation from a failed item.
[ ] Update code documentation.

With a separate project:

[ ] Check AirPlay stability with playlists on older iOS versions to better understand if we are facing regressions or if the situation has improved in iOS 16.
[ ] Improve resource loader stability.
[ ] Improve DRM key session stability (if needed).

Some ideas:

An idea to explain instabilities in playlists: Navigating back moves to the next item, like before an id was attached as associated object. Maybe this id gets lost when using AirPlay? To verify it we should try to append the id to the URL as parameter (loading and failing items included) and extract it from there.
We should use Timelane to make the item delivery visible in Instruments. This will help up debug the item loading process.
Moreover, and though I am not convinced this is the issue, we should attempt sharing resource loaders among items as well (DRM namely seems more stable than Akamai token protection in playlists).

Interesting playlist playback scenarios:

Fast advance through the items, return to the first item fast.
Fast advance through the items, return to the first item slowly. Advance.
Move backwards and let an item play entirely.
etc.

Some ideas if a workaround is needed:

Override currentItem in the RawPlayer subclass.
Disassemble to find ivars or internal methods we could use to implement a fix.

A few things to keep in mind when testing:

It appears some instabilities currently arise when an item fails to play while navigating the playlist.
If an item is full played navigating back fails. So we either need to reset the position to zero (later likely provide a hook so that playback can be resumed at the previous location) or to account for this fact when finding the last playable item before the current one.

After some investigations and from my point of view :
An AVPlayerItem that failed to play within an AVQueuePlayer, seems to be ignored for the rest of the queue player (rawPlayer) life.
With Airplay, this behavior can lead to some weird issues.
To avoid these undesired cases, before to populate our queue player (rawPlayer), generating new objects (PlayerItem) can do the trick and solve our issue.
Here is the fix :
storedItems = Deque(storedItems.map { PlayerItem($0.playerItem) })
storedItems.suffix(from: previousPlayableItemIndex).forEach { item in
        rawPlayer.insert(item.playerItem, after: nil)
}

Another fix idea: Disable external playback while updating the items (maybe restoring after a delay to be determined). This might help the player and the AirPlay proxy to stay in sync.

Token- and DRM-protected content restart at the beginning when navigating the playlist forward or backward over AirPlay:

Play a first DRM-protected content and seek somewhere in it.
Navigate to the second item.
Navigate back. Playback restarts at the beginning.

Restoration of the previous position works when playback happens locally, though.
Not sure this is really an issue (we should likely be able to either restart at 0 or at a desired time, see #161). Still this likely proves that the fact that resource loading or content key retrieval takes place affects where playback can resume.

Another idea: Our issues seem related to the fact that the player and its AirPlay internal counterpart are out-of-sync when altering an AVPlayerQueue containing several items.
In the case of Player, though, the truth resides in the storedItems. We could imagine have a single AVPlayer fed with the current item in storedItems and we could likely implement a working player, though without the ability to chain items (buffering in advance), something required for continuous background playback.
Still, if reducing the queue to a single item makes AirPlay stability better, we can apply the following approach:

When advancing to the next item or returning to the previous one, we simply insert the item to be played alone in the queue.
If AirPlay is enabled we wait a bit before we replicate storedItems in the AVPlayerQueue. This way we can make changes more stable and still preload items to continue playback afterwards.
If AirPlay is not enabled the storedItems can be immediately replicated to the AVPlayerQueue, as the result seems stable in this case.

When navigating the playlist fast while AirPlay is active the state returned by the player may not reflect what actually is happening on the Apple TV receiver (e.g. slider at the wrong position, playback button in the wrong state).
Stopping AirPlay fixes such issues immediately. This is why I suspect this is a sync bug between AVQueuePlayer and the AirPlay management controller, which we cannot probably do much about.

Comparison of playback stability with the dummy resource loader from above (even delayed) and our current implementation for Akamai streams shows that the latter is far less stable. So there must be something we do wrong. If we find it we can hopefully solve issues with our current resource loader.

Here are some tips to potentially log more information about obscure network errors.

Recap
Here is a quick recap of the known AirPlay issues and how they can be mitigated:
Playlist navigation issues
Insertion and removal of items in the queue confuses the player when using AirPlay.
Mitigations

Remove all items instead of individual insertions and removals.
When recreating the queue from scratch only insert a single item first, then append other items after a delay. This makes the queue behave like a single-player AVPlayer and avoids instabilities.

Error resilience
Items might break during playback, especially when using AirPlay. If items are cached no recovery is possible. Even with assets a player item created from the asset again might stay in the unknown state forever.
Mitigations

Don't store AVPlayerItem or AVAsset but what is needed to build them (URL, resource loader delegate, content key session delegate). Then create items again when needed.

Resource loader ordering
Resource loader responses might not be received in order when using AirPlay, leading to the wrong content being played, especially when navigating items fast.
Mitigations
Have a URL scheme strongly related to the item for which resource loading is made. This way resource loading correctly matches requests and responses it seems.
Resource loader stability
Resource loading has stability issues, even in the case of a very simple implementation.
Mitigations
It seems the following helps, but this requires further investigation:

Add a small delay before delivering a response.
Avoid Combine in resource loader implementation.

Unresolved issues
With all the above mitigations in place the result is quite stable on a good WiFi network but still it seems that on some network (probably a bit overcrowded) latency between sender and receiver can still lead to inconsistent states. I am not sure these issues can be further mitigated, though, as this seems related to how AirPlay works internally between involved devices.

Error messages
When using AirPlay and a resource loader delegate the error message is lost after the error has climbed up to the player item. The error domain and the code are still correct but as a result the message displayed to the user is still not very user-friendly.
We could write code to return a generic message when we have no localized error description is available but we can also live with the current situation, as discussed with @waliid. We can still improve error reporting later if this really is a problem.

Automatically loaded asset key support
I initially intended to restore support for automatically loaded asset keys but, as discussed with @walid, there is no real need at the moment. We can namely always add this feature later if there is an identified need (e.g. faster story display by loading no keys) but at the moment this just seems overkill.
Rationales

This adds API complexity which most users will never need.
This increases the need for tests as some combinations (e.g. no keys) might change player item lifecycle in subtle ways (e.g. I found a crasher with indefinite durations when duration is not required as automatically loaded asset key).

Future implementation considerations
From an API perspective we could later add an automaticallyLoadedKeys property to the Asset type, next to the exiting configuration closure.
When creating the corresponding AVPlayerItem we would have to be careful since automaticallyLoadedAssetKeys = nil seems to be equivalent to an empty key list, not to the default ["duration"] list applied for items created without key list (see AVPlayerItem header documentation).

I removed the resource loader delay discussed above. It would namely be a shame that, because we want to achieve perfect AirPlay stability (something that is likely not feasible) all token-protected content would require some delay to be loaded.
We could of course only add this delay when AirPlay is active but I recommend we remove the delay for the moment and see how this goes. If required we can still restore it later (and apply a smarter criterium based on AirPlay route status).


Local replay vault watching/reloading

Fixes #1141.
This patch implements lazy loading of the local replay vault and automatic updates when replays have been added to or removed from the local replay directory.

Uses WatchEvents to detect changes in the local replay directory
Works for both played games and manually added/removed replay files
Updates the list accordingly and respects previous sorting
Replays from played games are now written to the cache directory first and then moved atomically  to the replays directory to prevent parsing it before it is written
No changes to UI

Test coverage is not great. What would you like to have tested exactly?
It's been 10 years or so since I've written any Java, so be gentle. ;)

Good job! ;-)


Is this lib production ready?

I'm wondering because it looks like it's no longer under active development. Did you ever use this in production?

@nandosousafr sorry to bug you, but I'm wondering if you can answer my question...

Hi @abitdodgy, sorry for the delay.
I dont think is ready for production. It lacks lots of features! Actually, the only feature implemented is the payment creation.
Also, there's a critical issue:
https://github.com/nandosousafr/pagseguro_ex/issues/1
If you want we definitely can work together to make it ready for production. I'm looking forward to work more on  OSS these days. If so, just submit the issues so we can reason about them together.
If you want to contact me directly my email is nandosousafr at gmail dot com


Fix energy card cloning, and cardholder displaying for energy cards

Fixed #206 and #220.
This PR copys some of the code from CardItemScreen to CardEnergyScreen as well as the Card holder detection code from CardItemContainer to CardEnergyContainer
This also adds the special case for the CardCloner and the PacketCopyPasteCard to allow energy cards to render correctly in the tooltip, as well as copy the overclocker settings. (Energy cards only have 1 slot, because they don't have a filter)

Should no longer be needed in later versions


[HMR] Ensure Hot Loading is working on Android

We've done quite many changes to HMR since @satya164 added the Hot Loading option to the dev menu. This task is to make sure Hot Loading works on a brand new project. Also, we need to gate the feature for now, we don't want to release up until we're sure it's stable.

Using the latest v0.21.0-rc I can't seem to figure out how to enable HMR, should there be a dev menu option?
I simply ran react-native init then npm install --save<EMAIL_ADDRESS>

@JohnyDays For now you need to install from master - http://facebook.github.io/react-native/docs/android-setup.html#content

Thanks, I'll give it a look and give some feedback :+1:

@JohnyDays 😄

For anyone stuck in making it work, there is no need to install from master, here are the steps for a new project:

react-native init
npm install --save<EMAIL_ADDRESS>react-native upgrade (Choose yes for everything it asks)
You're done! An option to enable hot reload should appear in the android dev menu

Oh! I thought @martinbigio removed it before the RC. Finally we have HMR for Android in a public release :tada:

It seems to work perfectly, but everytime a change happens, this error pops up

And it keeps stacking up at the bottom of the app, so if I save the file 5 times, it appears 5 times (consistently)

Figured out the problem. The source maps are being requested from
http://localhost:8081/index.android.map?platform=android&runModule=false&entryModuleOnly=true&hot=true,
it should be requested from the remote url/ip (e.g <IP_ADDRESS>). Is this packager related, or android-specific? At the end of the generated HMR patch, the sourcemaps are referenced as
//# sourceMappingURL=/index.android.map?platform=android&dev=true&hot=true

Hmm though @mkonicek removed it. It wasn't intended to have the option visible on the menu yet

Ohh, this is 0.21RC. We'll remove the option from the menu there. If everything goes well we should be able to open the feature on 0.22 :)

@JohnyDays Thanks so much for working on adding support for having multiple clients!. Please let us know if you find any bug or if there're other feature requests you think we should implement. We'll need help on testing this, so the more people use it before it's open the better :)

I'm having some trouble getting the android version to compile my java code changes consistently.
I have react-native cloned into the node_modules folder, and when I run react-native run-android it doesn't seem to pick up on them, regardless of me changing branches or whatever I do.
I tried doing cd android && ./gradlew clean but had the same result. Is there something obvious I'm missing?

@JohnyDays follow the instructions here - http://facebook.github.io/react-native/docs/android-setup.html#content

Symlinking won't work, coz watchman, which RN uses to watch files, doesn't support symlinks.

Yeah I have my machine (arch-linux) setup with the sdk, and gradle daemon, all the build tools and genymotion.
The builds always succeed, my problem seems to be related to the file system changes not being picked up.
I started a new project and it works perfectly again, it's probably a linux-interop problem.

Shaping up! Still get those warnings though :cry:

PS: I just spent way more time than I should trying to make that gif under 10mb, sorry for the terrible colors

@martinbigio Just a heads up, i reimplemented the changes to attachHMRServer.js from b2b41da37f70c2b0da381ad86a701443f13b27f4 and b2b41da37f70c2b0da381ad86a701443f13b27f4,  so there wouldn't be any problems with conflicts. I should be able to open the PR today, cheers :beer:

Wow, this indeed will be helpful for a lot of people!.
I recently added support for redux stores and modules that export pure functions and modified this file (https://github.com/facebook/react-native/commit/436db67126f1e64d1889c2d084b77c98c8d63f8d). Most likely you'll have to rebase.

Just updated to rn-0.22 and the warnings(as shown by @JohnyDays) are still there

Yep, I am also getting this on genymotion with react-native 0.22. I also tried setting debug server host & port to point to my development machine, no luck.

@martinbigio I did some digging on this when i was working on multiple clients, and it appears to be related to source maps. e.g even if you are requesting from a remote ip, the source maps still point to localhost.

Genymotion sets a special ip to access localhost  from the simulator, however to fetch the sourcemaps we're using localhost...

The problem is that JS lacks of this logic: https://github.com/facebook/react-native/blob/1f94a00785a472d135d121958d5c2fa73ec94103/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevServerHelper.java#L158-L160
cc @mkonicek

Shouldn't it be the java sending this information to the packager? Such as genymotion=true or localhost=<IP_ADDRESS> in the url

Yup, we're going to expose this on the AndroidConstants native module. @satya164 will send a PR in a couple of hours :)

same error as above still
react-native version:
➜  AwesomeReactNative git:(master) ✗ react-native -v
react-native-cli: 0.2.0
react-native: 0.22.2


[DOC] Helm chart repo Bad gateway

Provide a link to that doc page:
https://github.com/fluid-cloudnative/fluid/blob/master/docs/en/userguide/get_started.md
What is the defect and your suggestions on improvement:
Command helm repo add fluid https://fluid-cloudnative.github.io/charts results in Bad Gateway error,
Error: looks like "https://fluid-cloudnative.github.io/charts" is not a valid chart repository or cannot be reached: Get "https://fluid-cloudnative.github.io/charts/index.yaml": Bad Gateway

It works for me. Which version of helm in your env?
$ helm repo add fluid https://fluid-cloudnative.github.io/charts
"fluid" has been added to your repositories

$ helm version
version.BuildInfo{Version:"v3.6.2", GitCommit:"ee407bdf364942bcb8e8c665f82e15aa28009b71", GitTreeState:"clean", GoVersion:"go1.16.5"}

@Sharathmk99 I guess the 502 bad gateway is because of the reliability of github repo.  Can you retry it?

It works for me too


Create a landing page

📝 Description
A landing page or the first user page should be developed with the following sections in it.

Title with Image
Description
Description
Contributors

🖼 Screenshots
No response
📋 Additional Information
Feel free to create your own design first for a better developing experience.

I want to work on this issue.
Kindly assign it to me under Hactoberfest 2022.

Landing Page would look something like this.

Okay Looks good, You can start working on this issue, and feel free to comment if you face any doubt


⚠ Jenkins Plugins Artifactory has degraded performance

In a9cbbd7, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1168 ms

Resolved: Jenkins Plugins Artifactory performance has improved in ae39320 after 38 minutes.


Mysql migration deployment

rename deploymentconfig.yaml to deployment.yaml
Migrate DeploymentConfig to Deployment
Fix also test suite for new CI
Add tarball with sources

[test]


Apply some fixes

from upstream.
GUS should set DMA TC IRQ flag even when IRQ disabled.
Correct top-of-stack value store by FSTENV
FSCALE should always return 0.0 if ST(0) input is 0.0

Thanks!


Remove docker tag espressif/idf-rust:latest

The image espressif/idf-rust:last is obsolete and was replaced by other tags, since they're more specific.
Suggested options: Either remove the tag or point the tag to all.
What is your opinion @SergioGasquez ?

I would suggest deleting the idf-rust:latest tag

Tag deleted!


Mapping too slow with nested object

Hello!!!
We are testing your mapping class and we have a problem. Our class has a complex object list (Unidad).
The first time mapping is very slow , apox. 2 minutes.  The second time is immediately.
What can we do to improve the performance?
WPF App:
public partial class App : Application
{
private void OnStartup(object sender, StartupEventArgs e)
{
        Mapper_Inspector_Punitiva mapper = new Mapper_Inspector_Punitiva();
        mapper.RegisterMapping();
        Mapper.Compile();
        Mapper.PrecompileCollection<List<pesada_punitiva>, List<Pesada>>(); // 2 minutes

    }
}

Class:
[Serializable]
public class Pesada
{
public long id_pesada { get; set; }
public List unidades_punitiva { get; set; }
}
    [Serializable]
public class Unidad
{
    public long id_pesada { get; set; }
    public int id_balanza { get; set; }
    public System.DateTime fecha_pesada { get; set; }
    public int id_unidad { get; set; }

    public List<Grupo> grupos_punitiva { get; set; }
    public List<Infraccion> infracciones_punitiva { get; set; }
}

[Serializable]
public class Grupo
{
public long id_pesada { get; set; }
public System.DateTime fecha_pesada { get; set; }
public int id_balanza { get; set; }
public int id_unidad { get; set; }
public int id_grupo { get; set; }
public long? peso_maximo { get; set; }
public int? peso_grupo { get; set; }
public int? tolerancia_adicional { get; set; }
public int? tipificacion_matricula_cantidad_neumaticos_dnt { get; set; }
public string tipificacion_matricula_suspension_dnt { get; set; }
public string tipificacion_matricula_tipo_neumaticos_dnt { get; set; }
public List ejes_punitiva { get; set; }
}
[Serializable]
public class Eje
{

    public long id_pesada { get; set; }
    public System.DateTime fecha_pesada { get; set; }
    public int id_balanza { get; set; }
    public int id_unidad { get; set; }
    public int id_grupo { get; set; }
    public int id_eje { get; set; }
    public long? distancia_eje { get; set; }
    public int? peso_eje { get; set; }
    public int? tolerancia_adicional { get; set; }
    public int? tipificacion_matricula_cantidad_neumaticos_dnt { get; set; }
    public string tipificacion_matricula_suspension_dnt { get; set; }
    public string tipificacion_matricula_tipo_neumaticos_dnt { get; set; }
    public int? peso_maximo { get; set; }
    public List<InfoSensorPeso> info_sensor_peso_punitiva { get; set; }
}

Mapping:
        Mapper.Register<pesada_punitiva, Pesada>();
        Mapper.Register<unidad_punitiva, Unidad>();
        Mapper.Register<grupo_punitiva, Grupo>();
        Mapper.Register<eje_punitiva, Eje>();

Dear Mariana1980,
Thanks a lot for your input!
First of all I'd like to clarify some points:

You specified it happened on Startup_App on Mapper.PrecompileCollection<List<pesada_punitiva>, List<Pesada>>(); is that right (trying to precompile collections)? Or does it happen when you try to really map List<pesada_punitiva> to List<Pesada> using Mapper.Map<List<pesada_punitiva>, List>(src)?
Do you use exactly the same mapping types in your client code that you've specified in registration phase List<pesada_punitiva> to List<Pesada>
Can you send me a declaration for all of your Source (Domain level objects) and Destination (DTO). Like you did for Eje, Grupo, Unidad, Pesada, so I need declarations for pesada_punitiva, unidad_punitiva, grupo_punitiva, eje_punitiva in order to reproduce it.
I tried on my side with nested collections plus nested associations - precompilecollection works 3-6ms and mapping performed very fast as well - of course it depends which kind of volume you are trying to map.

Looking forward for your answers,
Thanks,
Yuriy

Dear Mariana1980,
I've just created a test project to test performance. You can downloaded from here
The results are pretty interesting! I ran the tests on 2 machines (Test project's been built with .NET 4.0 ).
The first one is native windows machine with VS2013:

The second one is my VMWARE FUSION 8 Virtual machine on my MAC with VS2015:

I've tried to debug whether the first time map uses Mapper.PrecompileCollection<List<Order>, List<OrderViewModel>>() from cache and yes I confirm that it was taken from cached the first and the second time in the test mapping has been taken from cache.
I can tell you for sure 100% this is how JIT optimization translates from MSIL to windows native code - so it depends on many factors but the code is executed the same way twice and it is pre-cached - so it completely depends on .Net JIT compiler.
Regarding your question I don't know exactly if you have the same context can you answer my previous question and let's see what I can do.
Thanks for your input,
Yuriy

Hello Yuriy!!
Thanks for your soon answer!!!
We used precompile because the mapping was too slow (2 minutes)  in the line:
 List<Pesada> lstPesada_aux = Mapper.Map<List<pesada_punitiva>, List<Pesada>>(new List<pesada_punitiva>());

With Precompile the performance is the same (2 minutes) in the line
Mapper.PrecompileCollection<List<pesada_punitiva>, List<Pesada>>();

but in this case the mapping works vary fast, after precompile.
This is without loading data.
Now, we have your TestMapperSpeed project with our classes, but in this case the application dies after mapping the empty list.
You can downloaded from [here] (https://www.dropbox.com/s/lqsubfuepyxrs0z/TestMapperSpeed.zip?dl=0)
We compile with .NET 4.5
Thanks for your time,
Mariana

Dear Mariana,
Thanks a lot for your valuable input! It's very good test for Expressmapper having such huge amount nested associations and collections.
So I checked it on my side Mapper.PrecompileCollection<List<pesada_punitiva>, List<Pesada>>(); works and it caches Func<List<pesada_punitiva>, List<Pesada>> so any upcoming mapping will use it from the cache.
Here is the first result using Mapper.PrecompileCollection (using your solution, log has been added for precompile collection and mapping as separate logs):

Here is the second result without precompilation collection step (using your solution with commented Mapper.PrecompileCollection and mapping executing twice):

So from that point if you don't use precompilation it will be compiled when you try mapping first time which is obvious and explained at http://expressmapper.org.
Regarding the why it was stuck on your machine - maybe different hardware and software as I tried on both machines and it worked out for me.
What and why it takes so long time to precompile collection? :
There are 2 compilations are happening when you try to compile:

Mapper.Map<TSource, TDestination>(source)
Mapper.Map<TSource, TDestination>(source, destination)

The first one works in your case very fast as it is simple algorithm even with your number of classes involved (116 classes plus multiple usages inside).
The second one takes a lot time when it tries to compile to Func<> because there are a lot of code to compile in your case as we are tracking instances of objects and many other things.
You can take a look at real expression trees for your case for the first case
here  file size 76KB and for the second case here file size 13MB. Which is completely fair with such complex mappings as yours and with our code to support to map to existing destination without creating extra instances of destination type.
If you don't need mapping to existing destination Mapper.Map<TSource, TDestination>(source, destination) I think I can help you out. I can release version with extended functionality to compile only source mappings that improve your performance probably in 5-8 times but if you do need mapping from source to existing destination then it is valid time to compile 12MB of text. I'm going to create new ticket to compile only source mappings.
Looking forward for your feedback.
Thanks,
Yuriy

Hi Yuriy, thanks for your reply.
With this WPF app, the first time the mapper delays 2 minutes, second time only few seconds.
My processor is Intel Core(TM)i5-3470<EMAIL_ADDRESS>RAM is 8 GB.
Can you test this application and tell us which are your test times.
You can downloaded from [here] (https://www.dropbox.com/s/zgks9uy8pdima3d/TestExpressMapper.rar?dl=0)
Thanks a lot.

Dear Mariana1980,
It is fixed and it is included in 1.7 release.
Please use the following:
Mapper.Compile(CompilationTypes.OnlySource) and Mapper.PreCompileCollection<SourceCollectionType, DestinationCollectionType>(CompilationTypes.OnlySource)  - in case you would like to precompile or just use normal mapping without precompilation.
It is working for me lightlingly fast since these changes. Please let me know how it is working for you.
Thanks a lot for such great input!
Looking forward to hearing from you.

Dear Yuriy!!
We tested our application with 1.7 ExpressMapper and it works perfectly!!!!!!!!
Thanks a lot for your soon answer!!!!!
We are in contact!!


[usbdev,dv] usbdev device address seq

This PR includes usbdev_device_address_vseq, in which we send transactions to different addresses and verify them.

@alees24 kindly review it.
Thanks


AttributeError: 'Namespace' object has no attribute 'orig_data_list_file_path' when run luna16_prepare_images.py

1. Thank you for the good tutorials! 😊
I'm having some problems trying to do experiments on the luna16 dataset. In section 3.1 prepare your data part,  I run luna16_prepare_env_files.py as instructed and successfully generated the json file, but when I try to run luna16_prepare_images.py, i get an error as the title says. And i also didn't find "orig_data_list_file_path" in luna16_prepare_env_files.py.
So I'm a little confused about 'orig_data_list_file_path' now, am I missing some steps?
2. Screenshot about my current situation
2.1 Config file

2.2 Error message

Hi @Can-Zhao, can you help to take a look at this issue and share some information？
Thanks in advance!

@Can-Zhao I still haven't figured out how to solve this problem, looking forward to your reply.

Hi @halftheworldaway , please change orig_data_list_file_path to data_list_file_path. I will submit a PR to fix it. Thank you so much for catching it!