Find on a column indexed returned an unexpected warning

Given a table simple:
curl --location 'http://localhost:8181//v1/default_keyspace' \
--header 'token: Cassandra:Y2Fzc2FuZHJh:Y2Fzc2FuZHJh' \
--header 'Feature-Flag-tables: true' \
--header 'Content-Type: application/json' \
--data '{
    "createTable": {
        "name": "table_simple",
        "definition": {
            "columns": {
                "email": {
                    "type": "text"
                },
                "age": {
                    "type": "int"
                },
                "name": {
                    "type": "text"
                },
                "country": {
                    "type": "text"
                },
                "human": {
                    "type": "boolean"
                }
            },
            "primaryKey": "email"
        },
         "options": {
            "ifNotExists": true
        }
    }
}'

And given a simple SAI index

curl --location 'http://localhost:8181//v1/default_keyspace/table_simple' \
--header 'token: Cassandra:Y2Fzc2FuZHJh:Y2Fzc2FuZHJh' \
--header 'Feature-Flag-tables: true' \
--header 'Content-Type: application/json' \
--data '{
    "createIndex": {
        "name": "idxcountry",
        "definition": {
            "column": "country",
             "options": {
                "ascii": true,
                "normalize":true,
                "caseSensitive": true
             }
        },
        "options": {
            "ifNotExists": true
        }
    }
}'

Inserting a few rows

curl --location 'http://localhost:8181//v1/default_keyspace/table_simple' \
--header 'token: Cassandra:Y2Fzc2FuZHJh:Y2Fzc2FuZHJh' \
--header 'Feature-Flag-tables: true' \
--header 'Content-Type: application/json' \
--data-raw '{
    "insertMany": {
        "documents": [
            {
                "email"<EMAIL_ADDRESS>                "name": "lunven",
                "age": 42,
                "country": "France",
                "human": true
            },
            {
                "email"<EMAIL_ADDRESS>                "name": "alice",
                "age": 39,
                "country": "Australia",
                "human": true
            },
            {
                "email"<EMAIL_ADDRESS>                "name": "Lottini",
                "age": 43,
                "country": "Italy",
                "human": true
            },
            {
                "email"<EMAIL_ADDRESS>                "name": "Gupta",
                "age": 25,
                "country": "USA",
                "human": true
            }
        ]
    }
}'

When searching on country (indexed)

curl --location 'http://localhost:8181//v1/default_keyspace/table_simple' \
--header 'token: Cassandra:Y2Fzc2FuZHJh:Y2Fzc2FuZHJh' \
--header 'Feature-Flag-tables: true' \
--header 'Content-Type: application/json' \
--data '{
  "find": {
      "filter" : {"country" : "France"},
      "projection" : {}
}}
'

ERROR

When searching on columns part of the index we got an unexpected warning

{
    "data": {
        "documents": [
            {
                "country": "France",
                "name": "lunven",
                "human": true,
                "email"<EMAIL_ADDRESS>                "age": 42
            }
        ],
        "nextPageState": null
    },
    "status": {
        "warnings": [
            "The filter includes columns that are not indexed. \n\nThe table default_keyspace.table_simple has the primary key: email(text).\nAnd has indexes on the columns: [None].\nThe request filtered on the un-indexed columns: country.\n\nThe query was executed without taking advantage of the primary key or indexes on the table, this can have performance implications on large tables.\n\nSee documentation at XXXX for best practices for filtering."
        ]
    }
}

When searching on a field that is a BOOLEAN as a string we got an ERROR 500

curl --location 'http://localhost:8181//v1/default_keyspace/table_simple' \
--header 'token: Cassandra:Y2Fzc2FuZHJh:Y2Fzc2FuZHJh' \
--header 'Feature-Flag-tables: true' \
--header 'Content-Type: application/json' \
--data '{
  "find": {
      "filter" : {"human" : "true"},
      "projection" : {}
}}
'

Giving the results

{
    "data": {
        "documents": [],
        "nextPageState": null
    },
    "status": {
        "warnings": [
            "The filter includes columns that are not indexed. \n\nThe table default_keyspace.table_simple has the primary key: email(text).\nAnd has indexes on the columns: country.\nThe request filtered on the un-indexed columns: human.\n\nThe query was executed without taking advantage of the primary key or indexes on the table, this can have performance implications on large tables.\n\nSee documentation at XXXX for best practices for filtering."
        ]
    },
    "errors": [
        {
            "message": "Server failed: root cause: (java.lang.RuntimeException) io.stargate.sgv2.jsonapi.exception.catchable.ToCQLCodecException: Error trying to convert to targetCQLType `BOOLEAN` from value.class `java.lang.String`, value \"true\". Root cause: no codec matching value type",
            "errorCode": "SERVER_UNHANDLED_ERROR"
        }
    ]
}

I think the first one is fixed. Need confirmation.
The second one for Root cause: no codec matching value type we need better error handling.

confirm that we are refreshing the keyspace cache in the driver before and after a DDL operation, there will still be a propagation delay between instances. This looks like the JVM did not pickup the new index, we could also look at updating the warning message to say something about schema propagation time.
created #1744 for the codec error, solve the schema caching in this ticket

@clun Could you double-check if you could reproduce the first error now? I think the problem has been fixed by the below code in PR #1519, which was merged on the same day when you opened this issue:
  @Override
  public void onTableUpdated(@NonNull TableMetadata current, @NonNull TableMetadata previous) {
    // Evict from the cache because things like indexes can change for CQL Tables
    schemaCache.evictCollectionSettingCacheEntry(
        Optional.ofNullable(tenantId),
        current.getKeyspace().asInternal(),
        current.getName().asInternal());
  }

It maybe has a propagation delay problem, but no matter how fast I tried, I still could not reproduce the error now.


Do not call plsfnam if output filename is empty

Hi.
This patch will fix the following problem.
(Please review carefully because I'm new to this library as well as to OCaml ;)
problem
Functions of the plot module could cause crashes.
This can be reproduced e.g. by just using plot_fun as in the tutorial.
Plot.plot_fun Maths.sin 1. 3.14;;

With no output filename specified, PLplot asks the output device first, and then the filename.
In my environment without this patch, the program crashes just after entering the device number.
The output looks like below.
Plotting Options:
 < 1> ps         PostScript File (monochrome)
...
 <22> svgcairo   Cairo SVG Driver
 <23> pngcairo   Cairo PNG Driver
...

Enter device number or keyword: 23
Can't open .
...
Can't open .

*** PLPLOT ERROR, IMMEDIATE EXIT ***
Too many tries.
Program aborted

environment
FYI, I can repro the problem on

Ubuntu 18.04
libplplot 5.13.0 (from apt repository)
OCaml 4.08.1
opam 2.0.5
owl 0.6.0 (from opam)

This looks very good to me, thank you @ktahar


Rails/Blank skips offense when defining the blank? method

We found a case that we need to disable the Rails/Blank cop when we're creating the blank? method.
So, it adds an offense when we have:
def blank?
  !present?
end

But it should accept because it's the method definition.

[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[ ] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[ ] Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

The Rails cops are supposed to be enforced on Rails apps, where the present? method is defined on every object. Are you enforcing Rails cops on a non-Rails application? I feel like I'm missing something here.

I use this cop enabled for the entire rails project using the default configuration.
I have some methods that are supporting my cucumber features and I define a blank? method there.
Should we set some default configuration to ignore non-rails folders?

Should we set some default configuration to ignore non-rails folders?

Perhaps not, I was just a bit confused. This PR looks good to me.

Thanks!


use IN BOOLEAN MODE if boolean mode operators detected

MySQL full-text search runs in "natural language" mode by default, making it hard to search for code, and making it ignore commonly used words such as "function" that may be very relevant in phabricator.
Boolean mode full-test search is more effective in some of those cases, and this patch makes phabricator use boolean mode when it detects boolean mode operators in the search query:
http://dev.mysql.com/doc/refman/5.0/en/fulltext-boolean.html
This enables a search for exact phrases using double quotes, it does not ignore words used in majority of the documents, etc. Since full-text search in natural language mode ignores such special characters anyway, this change should not "break" existing uses - though results will be different in some cases.
The "order by" section below unchanged. Changing the MATCH part there to boolean mode would not make much sense since boolean searches do not order by relevance. Leaving it as-is should be fine in most cases.

Uh, somehow lost a line there - need to unescape double quotes in boolean mode. Will be back with another patch.

Saw your question in IRC -- I think the long term fix for this is probably to provide better engine options:
https://secure.phabricator.com/T355
I have part of an Elastic Search implementation here:
https://secure.phabricator.com/D790
If that were closer to completion I'd say let's just finish it off, but it could be a while. I think this is a reasonable interim step if your experience is that it produces better searches.
I'm a little sketched out by the escaping behavior -- can you explain what's going on there in more detail? If MySQL parses tokens here using a different grammar than in normal contexts (as it does for LIKE), it might be appropriate to add a new escape flag to qsprintf() so that we're handling escaping at a consistent layer.

Elastic search is even harder to get to properly index and search source code - by default it is optimized for regular text searches. I am sure it can be done, but this works good enough for us at this time. We are starting to use Elastic a lot, so we may be able to contribute to Elastic solution as well.
As for escaping, I am not sure why double-quotes get escaped in the first place, but in a boolean mode that prevents exact phrase search. I will look into adding that escape flag before resubmitting the patch.

We don't actually index source code right now -- are you planning to add that? Or is this just for searching comments and stuff?
My thinking was that doing repository-specific searches in Diffusion might make more sense than searching everything from the main search. For Git and Mercurial, they could use VCS search functions (e.g., git grep / git pickaxe). Are there cases that wouldn't cover? (I haven't spent too much time thinking about this since it's not a common use case for me -- I personally do code search exclusively with "git grep".)

Oh, I guess I should have mentioned that as well. Yes, we added a simple-yet-effective and configurable script that indexes our repos, puts them into search tables, etc. We also added "repository" filter to the search page, "Repository Source" pick to document type filter, and so on. We often need to search for pieces of code across our different projects, so searching within a single repository would not work for us. This was going to be a subject of some future pull requests.

Ah, cool. I also landed a separate symbol index recently which hasn't been well-integrated or documented, but you can see it in action here:
https://secure.phabricator.com/diffusion/symbol/mpull/
(replace "mpull" with any other symbol to execute a lookup for it)
It currently powers cross-referencing from Differential to Diffusion -- if you click a symbol or function name in a revision on secure.phabricator.com and jump to its definition. I'm planning to integrate that into Diffusion as a direct search, and maybe into the main search index. It's not as exhaustive as full code search but should be easier/faster for cases where you're looking for a function/class definition.


TV remote from control centre sometimes work sometime doesn't

Hi,
Thanks for the great plugin, the TV mode is really well thought and works great great in Home app. I got some strange issue with TV remote in control centre though, sometimes I can see the remote and use it without problem. Other times I don't even see the remote.
No sure if it has some conflict with other TV remote plugins. I can only see one of them - either Harmony remote or the other remote. Does the remote get registered during startup of HomeBridge? Is there any limitation on how many remotes one HomeBridge instance support?
Thank you in advance!

Hi,
As described in #54, it is an issue with homebridge / homekit. In currently beta 1.0.0 f my plugin, and latest version oh Homebridge, it is possible to have multiple hubs, but all other plugins you are using should adopt the "external accessory" way. I am continuing my work on this, because current beta might stil have problems since I made a bad choice by not adding the first TV device of my plugin as an external accessory.


Awkward Sentence in Documentation

I am having trouble understanding this sentence:

By default library connect to database provided in "default" group.

It is on this page:
https://github.com/bcit-ci/CodeIgniter/wiki/Using-MongoDB-in-Codeigniter
Can some please explain a bit more about what this means?

That's a users' wiki page, not official documentation.
And this is a bug tracker ... Please ask your questions on our forums instead.


Routing: Fix bug of vertical parking failure.

Fix $[IDG-Apollo-4346].
When the vehicle is in front of the parking spot, and on the lane next
to the nearest lane to the parking spot, the parking action will fail
because of the following error:
Failed to extract segments from routing.
and the relative error of pnc map like:
Failed to find nearest point: x:<PHONE_NUMBER>0172278 y: 4433040.1114324955 z: 0
Cause:
The lane segments of the routing response don't contain the lane nearest
to the parking spot because the vehicle is in front of the parking spot.
When the vehicle approach to the parking spot, no project point can be
found on the routing segments and thus CreateReferenceLine failed.
Solution:

Add SupplementParkingRequest function. When the routing segements
doesn't contain the lane nearest to the parking spot, add it into the
sgement list.
Modify the way of searching the parking spot according to the vehicle
state as well as the way of searching the nearest lane to the
vehicle(GetNearestPointFromRouting).

@JasonZhou404
Hi Jason,
Do you have instant message or email that I can contact you?
<EMAIL_ADDRESS>I would like to send an email to ask some details regarding to parking algorithm.
hopefully can make contribution :)
Thanks


Delete permissions needed for package promotion?

We are running into problems when trying to promote packages from one Artifactory repository to another.
To be precise, we are using the following scenario:
First, packages are built and uploaded in the classic way (via conan upload) to a "Quality" repository.
If everything is ready and some tests are executed, the packages shall be promoted to a "Production" repository.
We use the conan art:promote command from the bottom of this page:

https://github.com/conan-io/conan-extensions/tree/main/extensions/commands/art
to promote the packages.
But when doing so, we get this error message:

ERROR: Error requesting api/copy/Quality/user/channel/package-name/version/channel/recipe-rev/package/package-id/package-rev/?to=/Production/user/package-name/version/channel/recipe-rev/package/package-id/package-rev&suppressLayouts=0: {
	"messages" : [ {
		"level" : "ERROR",
		"message" : "User doesn't have permissions to override 'Production:user/package-name/version/channel/recipe-rev/package/package-id/package-rev/.timestamp'. Needs delete permissions."
	} ]
}

The user permissions for the "Production" repository indeed only include read and write permissions, but not delete or overwrite permissions.
However, this is by intention: In fact, deleting and overwriting in the "Production" repo in general is usually forbidden in our organization, because we always want to be able to reproduce the build, and therefore we want to prevent packages from being (accidentally) deleted or overwritten.
So my questions are:

Is this behaviour intended?
Is it really necessary, to have the delete permissions, is there no way to implement the promotion without them?

BTW: It seems, only the .timestamp file prevents the promotion - I don’t quite understand, why it already exists in the destination folder, or why it has to be modified at all…

Thanks for your report @NilsKlimanis
This is an interesting issue. The thing is that the .timestamp file defines the revision timestamp and that revision timestamp can be quite important, as it defines the order of revisions, and revisions resolve to latest by default. It is true that package-revisions shouldn't be an issue, as it should only exist 1, but recipe-revisions would be way more typical.
I think we need to think a bit more about this, the creator of the extension @AbrilRBS has already this ticket assigned.
In the meantime, I'd try to avoid the situation workarounding it. If the package is already existing in the target repository, maybe it can be removed, or not added in the first place to the package-list that is being promoted. There are some mechanisms in Conan, for example when creating package lists to only include packages built in a certain job (--graph-binaries=). It might also be possible to run some queries to the target repo and remove things from the package list to avoid it.

Thanks for your reply!
Just to be precise here: We start with a competely empty Production repo, there is no package uploaded or promoted yet. The promotion fails at this very first package. So your suggested workaround would not work here, because there is absolutely nothing on the destination side.
As I said, I dont understand, why the .timestamp on the destination repo is there in the first place. It seems as it was copied, but then some instance tries to update this timestamp afterwards...


Many IOCTL codes falsely return incorrect function

In Port.c in function SyncComEvtIoDeviceControl, IOCTL codes SYNCCOM_ENABLE_APPEND_STATUS, SYNCCOM_DISABLE_APPEND_STATUS, SYNCCOM_ENABLE_APPEND_TIMESTAMP, SYNCCOM_DISABLE_APPEND_TIMESTAMP, SYNCCOM_ENABLE_RX_MULTIPLE, SYNCCOM_DISABLE_RX_MULTIPLE, SYNCCOM_ENABLE_IGNORE_TIMEOUT, SYNCCOM_DISABLE_IGNORE_TIMEOUT all leave status at it's default value of STATUS_INVALID_DEVICE_REQUEST.

Good eye. I can't believe I overlooked that. I'll get that fixed in the next release.

Thanks!


Update AccessTokenPlugin

I think this will add some functionality to the plugin, since it's not all types of authorization header. In my current project, the title was: "Authorization: token "
Also, I added this case to the tests and made a small refactoring of this file.

I am new to the topic of creating and contribute in the side of the library(frameworks). This project contains a lot of dependencies on other frameworks(Alamofire, Result, etc.) , what do I need to do to correctly compile and test Moya?

          2 Warnings

:warning:
Any changes to library code should be reflected in the Changelog. Please consider adding a note there and adhere to the Changelog Guidelines.

:warning:
Consider adding supporting documentation to this change. Documentation can be found in the docs directory.

SwiftLint found issues
Warnings

File
Line
Reason

AccessTokenPlugin.swift
25
Lines should not have trailing whitespace.

AccessTokenPlugin.swift
28
Lines should not have trailing whitespace.

AccessTokenPlugin.swift
30
Lines should not have trailing whitespace.

AccessTokenPlugin.swift
80
Lines should not have trailing whitespace.

AccessTokenPlugin.swift
85
Lines should not have trailing whitespace.

AccessTokenPluginSpec.swift
19
Lines should not have trailing whitespace.

AccessTokenPluginSpec.swift
30
Lines should not have trailing whitespace.

AccessTokenPluginSpec.swift
37
Lines should not have trailing whitespace.

AccessTokenPluginSpec.swift
42
Lines should not have trailing whitespace.

AccessTokenPluginSpec.swift
44
Lines should not have trailing whitespace.

AccessTokenPluginSpec.swift
49
Lines should not have trailing whitespace.

AccessTokenPluginSpec.swift
51
Lines should not have trailing whitespace.

AccessTokenPluginSpec.swift
57
Lines should not have trailing whitespace.

AccessTokenPluginSpec.swift
59
Lines should not have trailing whitespace.

AccessTokenPluginSpec.swift
62
Lines should not have trailing whitespace.

  Generated by :no_entry_sign: Danger

Codecov Report

Merging #1611 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1611   +/-   ##
=======================================
  Coverage   87.82%   87.82%
=======================================
  Files           5        5
  Lines         156      156
=======================================
  Hits          137      137
  Misses         19       19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bdb72b...b84c189. Read the comment docs.

what do I need to do to correctly compile and test Moya?

@SeRG1k17 Thanks for contributing and welcome 😃 You will need Carthage and run carthage bootstrap to build the dependencies.
About this PR:
We have another PR open that does what you're requesting here, see #1521. Unfortunately, we haven't had enough Moya contributors to review and decide if this is something we want to merge.

@SD10 My pull request contains a lot less changes then #1521. And it can be the subpart of that request.
Although, having looked at it, I had some doubts

You will need Carthage and run carthage bootstrap to build the dependencies.

Do we have this documented somewhere?

@BasThomas you even wrote this one 😄 Just that there is a specific command to update the libraries if possible, where bootstrap just runs on defaults. We could improve it but adding a flag to cache libraries, though.
About this PR we will have to decide what to do, because we already have a PR in the works, which is a bigger rewrite.

@SeRG1k17 would you please remove the @autoclosure from the plugin as well? We agreed to remove it as it causes a lot of chaos, where we just wanted to make it easier for people to pass the token 😅

@sunshinejr @SD10
Also I see two completely different approaches to improvement:
1) Add token property to protocol.
public protocol AccessTokenAuthorizable {

    /// Represents the authorization header to use for requests.
    var authorizationType: AuthorizationType { get }
    var token: String? { get }
}

Then, remove init from plugin and get token in prepare(_:target:) like as:
let token = authorizable.token

Rework init closure as:

    public init(tokenClosure: @escaping (TargetType) -> String) {
        self.tokenClosure = tokenClosure
    }

Then get token in  prepare(_:target:) like as:
let token = tokenClosure(target)

OR
Rework plugin protocol, add associatedtype:
public protocol PluginType {

    associatedtype Target: TargetType

    /// Called to modify a request before sending.
    func prepare(_ request: URLRequest, target: Target) -> URLRequest
//...
}

This will not receive in closure a protocol object, but a specific type.
However, this change will require updating the code of all the plug-ins.

@SeRG1k17 I don't think we should focus on improving the AccessTokenPlugin in this PR. That was the goal of #1521. I think we should keep it simple and only add the ability to set a custom header since this is what is most commonly requested.

@SeRG1k17 Are you able to make the changes described above?

[ ] Make the value property return an optional String
[ ] Use a hardcoded string value instead of String(describing:)

We also need to:

[ ] Add a CHANGELOG entry
[ ] Update the docs

@SD10 I think it's ready.

@SD10 yeah, tough one. I'd try merging master into development as we need to do it anyways. If it doesn't help, then let's rebase the PR.

@SD10 I merged it

@SeRG1k17 Sorry this one has been so confusing. We have a really messy git history too... I would've preferred we did a rebase instead of merging the branch multiple times.
Can you try to squash/clean up the history?
It looks like the CHANGELOG is corrupted now too 😓 I could possibly take over later if this is too much for you?

@SD10 I need make rebase from Moya/development to my/development. Right?
And add all my changes again?

Hey guys @SeRG1k17 @SD10 - I've rebased the PR and did reset some comments, it seems like the history is little bit more clear now and we can proceed 😉

This will require an update to docs_CN/Authentication.md so I'll tag #1357

Thanks a lot for contributing to Moya! I've invited you to join the Moya GitHub organization – no pressure to accept! If you'd like more information on what that means, check out our contributor guidelines and feel free to reach out with any questions.

@ashfurrow Thanks a lot. I will try to help develop this project. A few new ideas are already on the way :)

Awesome!
Looking forward to see it merged into master

@oluckyman this needs a major version release as it's breaking, but I think we are near to complete the scope for it 😉


How to access/protect envoy admin API?

Hello,
we would like to use envoy as proxy with the main functionality to do blue/green deployments.
The idea is to manipulate envoy clusters via the admin API from a remote server to automatically route traffic to the blue/green environment and later automatically to production.
I found it really hard to get into the API of envoy. Even after several hours of reading it is still not clear for me if I can simply send API requests with curl to the admin API or is only gRPC supported?
I tried to build the gRPC protofiles (https://github.com/envoyproxy/data-plane-api/tree/master/api) but it seems like there is no documentation on how to do it?
Another missing information is the topic "How do I protect the admin API?". Is there a way to protect the API? For example with x.509 certificates?
Cheers

There are two things going on here.

Envoy supports querying an API to obtain configuration data. These requests originate from an Envoy instance and are made against some API implementation external to Envoy. The protobuf bindings in envoyproxy/data-plane-api are used for the v2 API. The v1 API uses JSON.
Envoy can be configured to start an admin interface which provides commands to view things like stats, clusters, listeners, and server info.

To configure Envoy to obtain configurations from an API server, you end up defining one or more static clusters which refer to the API server host(s). I've not tried this, but in the cluster configuration you can configure TLS for the upstream (API) hosts to secure the requests.

Hello @zuercher,
thanks for your reply. That makes it a bit clearer for me.
For now, we decided to not use envoy.
Don't get me wrong, I think envoy is a great product with a lot of features. But the complexity combined with the missing documentation is the killing factor for us. I hope that this will be fixed in the future. ☺
Cheers


added all CV for strings update process

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: mvgaliev sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Libsass Error on Compile

Hey,
I'm getting the following error at compile time:
Warning: /vagrant/rails/public/assets/bower-components/bourbon/app/assets/stylesheets/css3/selection:4: error reading values after @if

I am using Bourbon 3.2.3 and Grunt-Sass 0.17.0 from within Grunt.
Any ideas on how to solve this?

The selection mixin doesn’t exist in Bourbon 3.2.3; it’s new as of 4.1.0. Are you sure your project is actually using 3.2.3?

Sorry, my Bower had got confused. All working now. Is Bourbon 4 being updated for LibSass?

Yeah, we’re slowly working on it. It’s really helping a lot that LibSass is pushing development and feature parity with Ruby Sass now.

Brilliant to hear. Only just started using Bourbon after removing Compass as Bourbon is sooo much simpler.

Nice! That’s great to hear; thanks for the kind words.

I'm using bourbon 4.1.1, compiling with grunt sass and am getting the same error.
"/bower_components/bourbon/app/assets/stylesheets/css3/selection:4: error reading values after @if"
any thoughts?

@iwoodruff LibSass compatibility will be fixed in v4.2.

thanks for the feedback.

For anyone still ending up here, you should be able to now bourbon update and resolve this error.


tiltfile/engine: metrics for multi-container usage

Would love feedback on how to report these stats for best slice-ability.
This PR records info on:

number of containers running each ref
number of resources with mutli-container live update

@nicks this is ready for re-review

cc @jazzdan -- this is the one I'd love to get into the next release. (I'm heading out now but if this gets approved, feel free to merge on my behalf if I'm not around.)


📌 Make peer dependencies optional

close: #76. supersedes #77 which was closed unexpectedly

Tried testing locally by running pnpm link ../sk-auth from dependent svelte-headlessui-starter but didn't get a clean link so please consider this pull cloudy with a 20% chance of rain. In other words, community feedback appreciated. 🙂

Tried testing locally by running pnpm link ../sk-auth from dependent svelte-headlessui-starter but didn't get a clean link so please consider this pull partly cloudy with a 20% chance of rain. In other words, community feedback appreciated. 🙂

Closing due to inactivity.

Followed up in a fork and discovered peer dependency meta will only cover build-esm warnings. The kit warnings also present in dependents requires either the sveltekit peer dep is removed or some kind of syntax for specifying peer dependency meta I'm not aware of. At any rate svelte-preprocessor doesn't specify kit as a peer dependency so I don't see why SK Auth would want to either. As a result, I'd recommend simply dropping the peerDependencies property in the manifest altogether.

Followed up in a fork and discovered peer dependency meta will only cover build-esm warnings. The kit warnings also present in dependents requires either the sveltekit peer dep is removed or some kind of syntax for specifying peer dependency meta I'm not aware of.
At any rate svelte-preprocessor doesn't specify kit as a peer dependency so I don't see why SK Auth would want to. As a result, I'd recommend simply dropping the peerDependencies property in the manifest altogether to squelch the warnings. I've tested installing with PNPM 6 + 7 without peer dependencies specified and the lib prepared itself as expected.

Followed up in a fork and discovered peer dependency meta will only cover build-esm warnings. The kit warnings also present in dependents requires either the sveltekit peer dep is removed or some kind of syntax for specifying peer dependency meta I'm not aware of.
At any rate svelte-preprocessor doesn't specify kit as a peer dependency so I don't see why SK Auth would want to. As a result, I'd recommend simply dropping the peerDependencies property in the manifest altogether to squelch the warnings. I've tested installing with PNPM 6 + 7 without peer dependencies specified and the lib functions as expected.


Update to Squirrel 1.0.1

This PR updates to Squirrel 1.0.1, which fixes a few installer failures that Electron users might hit, as well as enables the Slack app to change its shortcut icon based on the OS
https://github.com/Squirrel/Squirrel.Windows/releases/tag/1.0.1

:+1: Published in 1.0.1


Possibility of an outdated information about mobile phone support

Article has a note that declares: "Duplicate detection works with Dynamics 365 for tablets, but isn't available for Dynamics 365 for phones."

In history this was the case. Mobile support was only for tablets and not for mobile phones. However this should be thing of a past. I just ran a test on Dynamics mobile client and the duplicate check worked just fine.
If I am correct in my assumption of this article holding outdated information, I would request the referred note to be removed from the article, as it is at the moment causing confusion with our customers.
Thank you,
lemerika/microsoft

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1ec2130e-e177-cbe3-1b3f-6225d07faa05
Version Independent ID: 38bad136-38b2-79a8-06b3-24505125cb77
Content: Detect duplicate data with match codes and rules - Power Platform
Content Source: power-platform/admin/detect-duplicate-data.md
Service: power-platform
GitHub Login: @jimholtz
Microsoft Alias: jimholtz

@Lemerika
Taking this to internal thread.


memory leak when press test

Expected behavior
Actual behavior
Steps to reproduce or test case
Redis version
Redisson version

org.redisson
redisson-spring-boot-starter
3.23.1

Redisson configuration

According to the trace buffer leak caused by apache dubbo


[WIP] Code cleaning of small issues

Summary
Details and comments
Fixes #

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 66.673%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

qiskit_ibm_runtime/utils/utils.py
0
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
3277

Relevant Lines:
4915

💛  - Coveralls


Update to Vaadin 19

@johannest - The two grid scroll recipes have stopped working with Vaadin 19. Do you have time to check if you can figure out what broke them?

@johannest - The two grid scroll recipes have stopped working with Vaadin 19. Do you have time to check if you can figure out what broke them?

Thanks @marcushellberg for the heads up. I'll try to fix it as soon as possible

@marcushellberg I tried to fix these without luck. One change is that "outerscroller" is now "scroller" but fixing that doesn't make these still stable enough. Feel free to drop these problematic recipes from the cookbook. I'll try to fix these later and then make a PR

Closing this in favor of #200
As requested in https://github.com/vaadin/cookbook/pull/190#issuecomment-808069101 I removed the recipes using outerscroller. @johannest could you take a look at those later?


Fix minor code issues

[x] adapters to separate packages (resolved by #21)
[ ] better data transfer between activities, fragments.. more code to other classes
[x] fix after click on stream button and back to other fragment than torrent app crashing after few seconds

Will try to replicate the bug and see what is causing it

I still don't seem to be able to replicate the bug, do you have an error message?

better data transfer between activities, fragments.. more code to other classes
Ok I will start do this

https://github.com/greenrobot/EventBus for  communication between Activities, Fragments, Threads, Services, etc

@xdk78 Does it mean we can close this issue for 1.2 or you still have things you want to add?

I think is good for now


Added prop-types and using that instead of React.PropTypes because it…

… throws an error in 15.5.0. (https://facebook.github.io/react/blog/2017/04/07/react-v15.5.0.html)

Duplicate with #265 ?

Yup its a dupe


10-docker2singularity.sh PATH overrides 10-docker.sh

10-docker2singularity.sh currently contains:
#!/bin/sh
export PATH="/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"

It's copied to /.singularity.d/env/10-docker2singularity.sh in the resulting singularity image.
However, since 10-docker2singularity.sh sorts (ASCII) after 10-docker.sh, any PATH set by a Dockerfile ENV directive (represented in 10-docker.sh) will be overwritten with the PATH set in 10-docker2singularity.sh.
Is 10-docker2singularity.sh still necessary (naive question)? If so, could it perhaps be renamed to, e.g., 9-docker2singularity.sh, so any PATH that is set in the source Docker image via Dockerfile ENV directive will still apply?

In that it's a singularity build with a sandbox, it's probably no longer necessary (but perhaps needed to be). Have you tried removing it and building a container?

Hi @vsoch , following your suggestion, I removed scripts/env/10-docker2singularity.sh, built a modified docker2singularity image, and used it to export Debian, CentOS, and Alpine Singularity images. In all cases their /.singularityenv.d/env/10-docker.sh set PATH to what it would have been set to when executing a corresponding Docker container via docker run -it --entrypoint=/bin/sh <IMAGE>. So 10-docker2singularity.sh does seem unnecessary at this point?

It does indeed!

Since the branches each correspond to a different Singularity version (unfortunately many are different) to move forward, you'd want to choose the branch to edit, and PR to it. The master branch (should be) the latest version of the branches. It's a bit messy, but I'm not sure there is a better way to go about it.

OK, will do. Should the PR go to the 3.2.1 branch?

Yes! And after that, I'll PR 3.2.1 to master so it's up to date. Thank you!

Is the v3.2.1 branch supposed to work as-is? I get the following error:
$ git checkout v3.2.1
$ docker build -t docker2singularity-local:v3.2.1-orig .
...
$ docker run -v /var/run/docker.sock:/var/run/docker.sock -v /tmp/singularity:/output --privileged -t --rm docker2singularity-local:v3.2.1-orig  alpine:3.10.1
docker: Error response from daemon: OCI runtime create failed: container_linux.go:344: starting container process caused "exec: \"docker-entrypoint.sh\": executable file not found in $PATH": unknown.

Sounds like the entrypoint file wasn't added?

I'll be able to test this in a few minutes, sorry doing a million things right now.

Can you try with singularityware/docker2singularity:v3.1

That one works:
$ git checkout v3.1
$ docker build -t docker2singularity-local:v3.1 .
...
$ docker run -v /var/run/docker.sock:/var/run/docker.sock -v /tmp/singularity:/output --privileged -t --rm docker2singularity-local:v3.1  alpine:3.10.1
...
INFO:    Build complete: /tmp/alpine_3.10.1-2019-07-11-5def832712fb.simg
(10/10) Moving the image to the output folder...
      2,752,512 100%   50.86MB/s    0:00:00 (xfr#1, to-chk=0/1)
Final Size: 3MB

Ah interesting, I think it's likely that I started working on that branch, but then didn't actually finish. The last released version is v3.1.

Let's do this - start with v3.1, and then pull request to v3.2.1.

Will do.

Fixed in #63 , building now to release and then update master.


Remove Appraisal dependency

Appraisal doesn't add anything to this project that isn't better served by Bundler.with_original_env and BUNDLE_GEMFILE. Remove the dependency, and replace the functionality with a simpler approach.

Love it. TIL Bundler.with_original_env could be used this way


updating alt text

Updated alt text.
Fix #222
Test URLs

Before: https://main--888de--aemsites.hlx.page/
After: https://222-nav-icon-alt--888de--aemsites.hlx.page/

Testing instructions
Verify alt text has been updated

I only want to merge from Develop into Main, so I'm closing this.


Now the "dimension" (see below) is basically a Dictionary of a Custom  label-category Data-class.
The only issue is, that 3 elements  that are in this dictionary are of other data-types ("id", "role", "size").
The elements of the label-category data-class are "Indikator" and "Period".
Does anyone know a good way how to deserialize that into a normal class structure?
Thanks!
 {"dataset":{
            "label":"The Economic Tendency Indicator and other indicators by Indicator and Period",
            "source":"National institute of economic research",
            "updated":"9999-12-31T22:59:59Z",
            "value":[102.4]

            "dimension":{
                "id":["Indikator","Period"],
                "role":{"time":["Period"]}
                "size":[1,1],
                "Indikator": { "label":"Indicator","category": {"index":{"KIFI":0},"label":{"KIFI":"The Economic Tendency Indicator"} }                },
                "Period":{"label":"Period","category":{"index":{"2019M02":0},"label":{"2019M02":"2019M02"}}},
            },
        }}

Jil doesn't do much in the way of mapping between different structures (it does some stuff for different formats, and supports wrapping primitives, but not much else).
If you use Jil, you'd probably have to have a set of classes that exactly match what's in the JSON and then a separate chunk of code to map it something normal.
Other JSON libraries (like Newtonsoft's) might be a better fit for your use case, but I'm not familiar enough with it to say for sure.


Quantum state classes

Summary
Adds quantum state classes to quantum_info package. These can be evolved by operator class objects, instructions or circuits.
Details and comments

Adds QuantumState abstract base class
Adds Statevector class for complex statevector. Can be evolved by Operators and circuits containing gate instructions.
Adds DensityMatrix class for density matrices. Can be evolved by Operators, QuantumChannels, and circuits containing gates, reset, and kraus instructions.

TODO

[x] Tests for Statevector
[x] Tests for DensityMatrix
Integration with partial_trace and state_fidelity functions (follow up PR)

@ajavadia ready for review

@ajavadia _evolve is removed from Operators and base class but it is a helper internal method in QuantumChannels that states classes use in their implementation of evolve for those objects. The _evovle method of channels isn't intended to be called by the user directly (thus the underscore).

Updates

Added Statevector.from_label and DensityMatrix.from_label class methods that construct from a label of Pauli eigenstates 0,1,+,-,r,l.

Removed __init__ from instructions or circuits from class init and added .from_instruction class method that can initialize a Statevector or Density matrix from an instruction/circuit assuming the initial state is the all zero state (different initial states and be achieved the standard way of Statevector(init_state).evolve(circuit)).

@ajavadia @ewinston made the changes, should be good to go now


git-fame: init at 2.5.2

If some ruby boffin could help with this that would be super. At the moment the
git-fame binary doesn't end up in /bin. calling
/nix/store/jxq90d7jlfj1d457lkasmi03g9l0vykh-ruby2.3.3-git_fame-2017-01-14/lib/ruby/gems/2.3.0/bundler/gems/git-fame-rb-64748dfb18b0/bin/git-fame
works however.

cc @zimbatm @Mic92 re ruby packaging

@zimbatm I've applied your changes, however running $(nix-build --no-out-link -A gitAndTools.git-fame)/bin/git-fame doesn't work; running $(nix-build --no-out-link -A gitAndTools.git-fame)/lib/ruby/gems/2.3.0/gems/git_fame-2.5.2/bin/git-fame does though
$ $(nix-build --no-out-link -A gitAndTools.git-fame)/bin/git-fame
/nix/store/3d7a11zliyy2djcphlq5mx6rr1yxlll3-bundler-1.14.6/lib/ruby/gems/2.3.0/gems/bundler-1.14.6/lib/bundler/rubygems_integration.rb:408:in `block in replace_bin_path': can't find executable git-fame (Gem::Exception)
        from /nix/store/3d7a11zliyy2djcphlq5mx6rr1yxlll3-bundler-1.14.6/lib/ruby/gems/2.3.0/gems/bundler-1.14.6/lib/bundler/rubygems_integration.rb:434:in `block in replace_bin_path'
        from /nix/store/86ahl0dm6j72f34rh191dafp8jhda9kp-git-fame-2.5.2/bin/git-fame:18:in `<main>'

@expipiplus1 yeah there's something wrong with the ruby env. I've pushed a little change but it doesn't fit the main issue.

fixed in 531a5b1afeb10ca4c347f2c7d8386e1187b456bf
Gemfile was not correctly updated.


 So the grammar in all readme.md is something that I need to check asap!

little bit restructured main readme file to comply with some hoch englisch


Wip - Add lighthouse config

TP-??? Your PR title here

Why

What

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.11%. Comparing base (1a172dc) to head (f2fd732).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1201   +/-   ##
=======================================
  Coverage   93.11%   93.11%
=======================================
  Files         582      582
  Lines       44053    44053
  Branches     3180     3180
=======================================
  Hits        41022    41022
  Misses       2415     2415
  Partials      616      616

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Optimise Struct Fields + Fixes

In v1.1.0 we made changes to the alignment of several structs (particularly Buffer) in order to ensure the broker is compatible with 32bit systems. In the process we discovered that other structs were not aligned in an optimised manner. This PR contains changes which align optimise all structs are 8bit aligned and packed into their most memory alignments.
This PR also contains other minor fixes:

Locks were being copied in the Inflight, Buffer structs. These are now passed by address where appropriate.
The method signature for writer WriteTo implemented an int instead of int64. This has been corrected and references to the method updated.
Small changes to comments for clarity.

Codecov Report

Merging #24 (122531b) into master (86e0a58) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #24   +/-   ##
=======================================
  Coverage   98.86%   98.86%
=======================================
  Files          19       19
  Lines        2028     2028
=======================================
  Hits         2005     2005
  Misses         20       20
  Partials        3        3

Impacted Files
Coverage Δ

server/internal/circ/reader.go
100.00% <ø> (ø)

server/internal/packets/fixedheader.go
100.00% <ø> (ø)

server/internal/packets/packets.go
100.00% <ø> (ø)

server/internal/topics/trie.go
100.00% <ø> (ø)

server/listeners/http_sysinfo.go
94.23% <ø> (ø)

server/listeners/listeners.go
100.00% <ø> (ø)

server/listeners/mock.go
95.45% <ø> (ø)

server/listeners/tcp.go
100.00% <ø> (ø)

server/listeners/websocket.go
78.26% <ø> (ø)

server/persistence/persistence.go
100.00% <ø> (ø)

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86e0a58...122531b. Read the comment docs.


Push the latest version to nuget

I started writing an application for Spotify, but when I wanted to setup Implicit Grant using the local web server, I could not pass the port number to the HTTP server. I can't use port 80 for this app because my critical IIS service uses it. I glanced over the code and it seems like the Github copy allows passing in a port number for the HTTP server, this is not the version that is pushed to nuget. Can you please push the latest to version to nuget?
Thanks

Done, updated the Nuget-Package and published a new release


[child_process.ahk] Strange line wrapping bug

This is strange because I was unable to reproduce it with other command line outputs, only that of adb, and it seems to occur randomly.
For example, when I call ls for a folder through adb shell, the directory names are wrapped to the next line randomly.
#Requires AutoHotkey v2.0
#SingleInstance Force
Proc := child_process("adb shell ls /sdcard/Android/media", , true)
Proc.Call()
Result := RTrim(Proc.GetLastStdout(), "`r`n")
Msgbox Result

The results below are all produced with the same code above:
1.
br.com.escolhatecnologia.vozdonarrador
ch.blinkenlights.android.vanilla
com.cxinventor.file.explorer
com.foxdebug.acode
com.google.android.gms
com.kiriengine.app
com.lyonbros.turtl
com.nextcloud.client
com.vson.lexie
dk.tacit.android.foldersync.lite
is.xyz.mpv
org.telegram.messenger

br.com.escolha
tecnologia.vozdonarrador
ch.blinkenlights.android.vanilla
com.cxinventor.file.explorer
com.foxdebug.acode
com.google.android.gms
com.kiriengine.app
com.lyonbros.turtl
com.nextcloud.client
com.vson.lexie
dk.tacit.android.foldersync.lite
is.xyz.mpv
org.telegram.messenger

br.com.escolha
tecnologia.vozdonarrador
ch.blinkenlights.android.va
nilla
com.cxinventor.file.explorer
com.foxdebug.acode
com.google.android.gms
com.kiriengine.app
com.lyonbros.turtl
com.nextcloud.client
com.vson.lexie
dk.tacit.android.foldersync.lite
is.xyz.mpv
org.telegram.messenger

@thqby Thank you so much for the fix. :) Can you also have a look at Socket.ahk? It appears to have a similar problem when receiving text, though I'm not 100% sure yet if it's server-side issue.

Socket messages have no boundaries, and when you receive a message, there may be a part of it that arrives later.

Perhaps add the option to define boundaries like \r\n?

Use RecvLine to receive the message
https://www.autohotkey.com/boards/viewtopic.php?p=503678#p503678
This is the jsonrpc implementation

Thanks. :)

@thqby Hi again, I just noticed regarding child_process.ahk, it's not wrapping text randomly now but sometimes it cuts off one or two characters in the beginning.

what?

After some further testing, it seems whenever the 0 character is present it will sometimes be dropped. It probably has something to do with relying on truthy/falsy for getting stdout?
Try this:
#Requires AutoHotkey v2.0
#SingleInstance Force
Loop {
	Proc := child_process("adb shell ls /sdcard/test", , true, {encoding: "UTF-8"})
	Proc.Call()
	Result := Proc.GetLastStdout()
	Tooltip Result
}

If there is a file with the name like 0001000 under /sdcard/test, the zero will be randomly missing either from the beginning or the end.

I don't have adb, so use cmd.exe /c dir /b, but can't reproduce it.

Yes this one only happens in adb as well. There might be others sharing the same problem but I haven't found it yet. I can confirm though that adb is working properly if I use ComObject("WScript.Shell").

Maybe it's fixed. https://github.com/thqby/ahk2_lib/commit/4ad45656027efc7581774a6117a42f2990313980

I thought that would fix it, but it did not. Then I found there was another check relying on a truthy condition
else if !line
		break
```, changing this to also check for blank string finally solved it.


Bugfix/issue 559 part1 disable cron in forked repo

Please write user-readable short description of the changes:
part of #559

disable nightly test on forked
fix urllib3 pip package version

other thoughts will be posted in another pr, we need to merge this pr asap.
Currently, this info is annoying, I find many have forked our public repo will receive a notify about fail testing.
https://github.com/rohankumardubey/proton/actions


fix(client): Vague Error messages

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
~- [x] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)~
[x] My changes do not use shortened URLs or affiliate links.

Closes #17413

Finally I have noticed that you depend on the CI for while fixing up PRs, IMHO you should test things locally before pushing to ease the notifications barrage it triggers for everyone subscribed to the thread.

You should probably have different returns for each of those last validations on username and report, returning early. Anyways I'll merge this.


Required Yolo 5s in detectnet

Hey @dusty-nv
I know yolo is not supported and pre processing and post processing definition are different. I have been through all issues also.
I am ready to code all required logic but can you please help with where to start and what to change.
Thanks
Rahul

@rlrahulkanojia here is where the pre- and post-processing is for ONNX detection model:
https://github.com/dusty-nv/jetson-inference/blob/19ed62150b3e9499bad2ed6be1960dd38002bb7d/c/detectNet.cpp#L728
https://github.com/dusty-nv/jetson-inference/blob/19ed62150b3e9499bad2ed6be1960dd38002bb7d/c/detectNet.cpp#L813

Thanks for quick reply!

@rlrahulkanojia Hi there! Did you succeed in coding support for YOLO? I would be also be interested in that - any hints are appreciated!


Bulk add tags to documents

Nunaliit needs a way to bulk add tags to a list of documents. The first use case for this feature is using the grid view. In this view a user should be able to select multiple documents in the grid view and then submit a tag to add to each selected document.

Initial design investigation. Going to start with seeing if the canvas can be modified for multiselect.

New canvas type grid selection, or maybe can use the current canvas and have a new multiselect option provided to the canvas!
New display type bulk edit. Current display implementations are couchDisplay, couchDisplayTiles, displayRibbon and displayRibbon2.
Currently a ‘displayRender’ event is dispatched each time a selection is made (https://github.com/GCRC/nunaliit/wiki/Nunaliit-Documentation-for-Developers#webapp_dispatcher_event_types_displayRender). couchDisplayTiles handles a msg.docs and msg.docIds payload for the selected event to display multiple documents. Use that same selected event fired by the canvas to know what documents are selected.
When saved need to loop through documents, update the data and then save to db. Data modification file select.js has some code to reference for how to do this. Code is not available for reuse.


Changes to add the Bluetooth tab to Settings so that BT Inbound and Outbound Pairing can be done

Hi @KaraOttewell, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

This change will only build and run with our next release.  Hold off on merging this until we release new bits.

Hi there @KaraOttewell; Could you also fill out the microsoft cla (even for internal)?

@KaraOttewell, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;

:+1:
@bfjelds Can you signoff on this with a +1?

This change will only build and run with our next release. Hold off on merging this until we release new bits.


generic_utils.py fix progbar crash batched data

Please add a unit test, to demonstrate what is being fixed

@fchollet this one should be ready to merge, many of my other PRs depend on it

Closing in favor of https://github.com/fchollet/keras/pull/7113


zgen load only supports github

I have one of my repos on bitbucket that I wish to load with zgen. Currently the only way to accomplish this is to clone the repository manually and using zgen load with the path option.
It would be very useful if we could define git repository paths to checkout arbitrary locations. Github is just one location which can host ZSH scripts.

Poor documentation!
I have now updated the readme file to show different ways to pass repository to zgen load 30e212e
It may be a good idea to add shortcuts to other git hosting services too.. We'll see if there's enough demand for that.

Nice, that actually does allow you to use other repositories. Too bad bitbucket offers the url git@bitbucket.org:user/repo.git for private repos. It doesn't fit the supported usage patterns.
It's not a big deal to rewrite that into a git:// url, but since it's directly supported by git, it would be nice if zgen allowed it as well.

I'll see if I can manage to craft a pattern for that

That should do the trick. Thanks.


(PDB-2256) Fix terminus bug with large binary catalog data

The terminus includes code to help users diagnose the source of data
that cannot be converted to UTF-8. There are several sources of this,
but one is having an incorrect (or known) character set for portions of
the catalog. When this invalid character data is large, it would cause
the terminus to hang trying to include debugging information.
This patch changes the terminus to only look for the first instance of
bad data. It will also avoid doing the extra calculations needed for the
error context unless debug mode is enabled. When not in debug mode there
should be no impact on performance.

@vzctl @olivierHa can you try this out and see if it fixes your problem? I used a manifest like the one described here and it's working fine for me.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-enterprise.delivery.puppetlabs.net/job/enterprise_puppetdb_init-multijob_githubpr-stable/103/
Test PASSed.

Yes, it fixes the problem, there are no performance issues with and without debug output. Thanks @senior for fixing it up!

Testing this now :dancer:

Works for me using the catalogs for testing the original patch as well as some new ones generated per the ticket description :+1:, any idea what's going on with travis @senior?

Travis looks to be an unrelated timeout, gonna merge this in


add QueryHelper class and WsFederationMessage tests

@lovemaths,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


update get_embedding function to account for new openai client

Because of OpenAI python client 1.0.0 upgrade, we can no longer have openai.Embedding
See similar issue here:
https://github.com/langchain-ai/langchain/issues/12943

@bbytiger Thank you for the pull request. Implementing this change may pose a compatibility issue for users on the old OpenAI version 0.28 and below. To maintain backward compatibility, could we consider incorporating a version-aware implementation? Specifically, utilize this implementation for versions above 1, and stick to the old implementation for those on version 0.28 and below. If it’s not too much to ask for, we could consider relocating the old and new implementations to separate files. Subsequently, we could import the appropriate function based on the user's OpenAI version, ensuring a cleaner and version-specific implementation


Update Glarysoft.GlaryUtilities to version <IP_ADDRESS>

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

What is this about?

newer PR made this unnecessary #19870


C1: QA fixes - 5

@coderabbitai review

@coderabbitai I haven't requested for any review in the past hour, why am I getting rate limit?

@coderabbitai review

@coderabbitai review - I've added this twice, why is it not reviewed yet? is it because of large amount of file changes?

@coderabbitai it's been 14 hours already


Unify structs and C structs

Follow-up to Allow adding methods to C structs
Wrappers of C libraries are currently hindered because C/lib structs are not full-featured and have very strange and buggy behavior when it comes to constructors (see #557), so in order to make a proper interface for the library one has to make another type that represents this struct and convert to and from this type. Note, however, that these small structs are often abundantly used in libraries, and things like a huge array of structs is not rare. Copying and converting such an array N times per second is not good for performance, and neither are the ubiquitous conversions between the two types for function arguments and return values.
lib L
  struct S
    a : Int32
    b : LibC::Char*
  end
end

struct S
  def initialize(@a : Int32, @b : LibC::Char*)
  end

  protected def initialize(s : L::S)
    @a, @b = s.a, s.b
  end
  protected def to_c : L::S
    L::S.new(a: @a, b: @b)
  end
end

I would like to note that currently structs and lib structs behave mostly the same, and have the same field layout, as this example shows:
str = "abc"
arr = [S.new(5, str.to_unsafe), S.new(7, str.to_unsafe)]

larr = [] of L::S  # needed because "can't execute `larr[1]` - Array(L::S) in `larr` was never instantiated"
larr = (pointerof(arr) as Pointer(Array(L::S))).value

p larr[1] #=> L::S(@a=7, @b=Pointer(UInt8)@0x435274)

Obviously, the example is vile, but my point is if the layout is the same then we should merge these two types into one thing.
The only problem is the ability to add fields anywhere in the code, which breaks everything.
struct S
  @c = ":("
end

So my suggestion is to make structs defined inside lib to be just like normal structs, but without the ability to add more fields to them.  The syntax will also create the usual members in that struct, to not break backwards compatibility: initialize with 0 args that zeroes all fields, initialize with N args that sets all members, and property for each member. It is also important to be able to override all of these (maybe zeroing all bytes is not wanted, and maybe some special behavior for setters is wanted).
Sure, the inability to add fields still makes the structs "not full-featured" but how often does one really need to add fields to an existing type? This is a bad practice anyway.
The next step would be discussing what happens with inheritance. I think it should be possible to inherit from these structs and even add fields, as that doesn't affect interoperability. It would also be nice to have downcasting that drops the extra fields...

This is something we will definitely consider. I at least know @waj doesn't like it that there are two different struct types, one for C and another for Crystal, and the cost of copying between them, both in terms of more code written and executed, is real.
My main doubt is: what happens with C unions? Maybe they too, could be like Crystal structs, only that when you read/write instance variables they act in a different way (they read/write from/to the union).
If we go this way maybe it's better if such structs are marked with an attribute. For example @waj suggested "extern". Maybe something like this:
@[Extern]
struct Foo
  @x : Int32
  @y : Int32
end

This would tell the compiler to maybe generate the "zero" initializer (zero all fields), generate properties (although these will still be kind of magical, because to_unsafe can be implicitly used there), and disable checking that @x and @y are initialized in all of the initialize methods. Then these structs can live in Crystal's side (not inside a lib) and they can appear in docs, etc.

Some issues to implement this (though I think it's still possible):

When setting a C struct field, to_unsafe is automatically invoked if needed, while that doesn't happen in regular structs
When storing a Proc inside a C struct field, this is represented as a single pointer, and a check is done so that a closure can't be passed. In regular crystal structs this is stored as a normal Proc (two pointers).

But I think all of that can be solved: 1 by doing something special in the semantic phase (the same thing we are doing with C structs) and 2 by changing this logic for structs marked as C structs.
I still think this is a good way to do it, syntactically:
@[Extern]
struct Foo
  @x : Int32
  @y : Int32
end

We could even have this:
@[Extern(:union)]
struct Foo
  @x : Int32
  @y : Float64
end

Which means the fields overlap, and of course some type safety is lost, but one doesn't have to create two separate definitions and a wrapper.
I would still keep C structs and unions in lib declarations, because one might now need to expose these to a user.
I will need to check this syntax and semantics with @waj and @bcardiff (might take a few weeks) and then, if agreed, try to implement it.

There is some uncertainty about this particular approach, so I would like to continue exploring possible solutions.
I am starting to doubt the approach of confining C constructs inside a special lib namespace. After all, the only things present there that actually communicate with an external library are the functions and the globals. Who's to say that the enums that the external library defines aren't also perfectly usable in its object-oriented interface? Nothing wrong with constants and tidy structs either.
I don't know any other language that insists on isolating external libraries this much. Julia only has a construct to call a C function and a construct to get a C global. Nim has a construct to mark a function as a C function, otherwise it looks normal. I'm not aware of any language with a special syntax for "C struct".
Just to prove that functions and globals are all that's needed out of lib, they are all I use in one of my libraries.
If I was designing this, I would take the exact same approach as the mentioned languages. Completely ditch lib and give freedom to the developer.
The only concern here is that it may not be so easy to hide these functions anymore. But if a proper private module becomes part of the language, this stops being a problem.


[Improve] - Add new simple request model to the endpoints

Create a new simple request template, and add to all endpoints.
The model need two fields.

[x] Id of User
[x] Name of User

Endpoints

[x] Clients
[x] Services
[x] Categories
[x] Customer Order

Test Control

[ ] Clients
[ ] Services
[ ] Categories
[ ] Customer Order


PDF builds should use Sphinx provided LaTeX Makefile which uses Latexmk (and possibly xindy)

It seems PDF builds at RTD by default use something like this
pdflatex -interaction=nonstopmode /home/docs/checkouts/readthedocs.org/user_builds/sphinx/checkouts/master/doc/_build/latex/sphinx.tex
makeindex -s python.ist sphinx.idx
pdflatex -interaction=nonstopmode /home/docs/checkouts/readthedocs.org/user_builds/sphinx/checkouts

i.e. they don't simply proceed via make -C <buildir> all-pdf which would use the Sphinx provided Makefile (there are ways to pass options to pdflatex if needed). The latter uses Latexmk which does automatically the correct number of pdflatex runs.
This causes issue https://github.com/rtfd/readthedocs.org/issues/2857, but may cause more issues starting with Sphinx 1.8.
Indeed at Sphinx 1.8, a new user configuration value latex_use_xindy is provided to support indexing of terms beyond English ascii letters. Only the Sphinx provided Makefile + Latexmk configuration file latexmkrc has the correct invocation of xindy which depends on the document language.
If RTD used by default the Sphinx provided LaTeX Makefile, already for Sphinx 1.7.x, and certainly for Sphinx >= 1.8 this would solve #2857 and support the new latex_use_xindy Sphinx option painlessly.
Notice that with latex_engine set by user to xelatex, xindy usage will be default. Indeed makeindex is broken with UTF-8 index files. With lualatex such broken files causes a PDF build abort, and with xelatex they appear to work, but by luck, and the index in PDF is ill-formed.

We aren't going to execute any pdfs builds through the Makefile, we avoid the Makefile completely. Is there a solution that doesn't require using the Makefile?

And as already indicated the makeindex way will become with Sphinx 1.8 replaced by xindy way for non-English projects. Thus any hard-coded project independent code is bound to raise problems.

For pdflatex engine, Sphinx 1.8 still uses makeindex per default even for non-English (non-Japanese) documents. But for xelatex/lualatex it will use xindy because makeindex is incompatible with UTF-8.

Thanks for the detailed information! We might be calling on you more to help because I don't think any of us are well experienced with latex, and the need to perform multiple passes on PDF build seems like a silly latex design from the outside.
A couple things:

We definitely won't use the Makefile for building PDFs. It's too error prone for a general use case like ours -- Sphinx makefiles are optional even.
3 or 5 passes means 3 or 5 times the build resources, so we are extremely conservative making changes here. It's silly the latex engines require this, but alas.
The point to use xindy is helpful. There have been discussions of supporting xelatex instead of pdflatex, so perhaps a RTD config option to use xelatex/xindy makes a bit more sense now.
We could try to use latexmk as a wrapper directly, instead of pdflatex, this sounds promising. We could either require a special setting option in our config to force this, or we could check for a latexmk config in the repository (i prefer explicit configuration over magic though).

If table of contents is at start of document and is long it will offsets all page numbers of indexed terms

That is not such a problem for 'manual' type project because the numbering is reset after the table of contents, but 'howto' documents will have that problem.

I am not sure to understand what you mean about Makefile being error prone.

As far I can remember, Makefile generation is optional, also for windows I think they generate a bat file, so maybe some users can be updating one file or another and not both. Users may don't have a makefile, etc.

A user may indeed have possibly broken custom Makefile related to using  sphinx-build. But I am talking here about the other Makefile which is created by latex builder together with quite a few other files and end up in latex build repertory. This is entirely of Sphinx devising it is not a user Makefile. I am not thinking about local builds by RTD user, but only about the builds offered by RTD when hosting a user project documentation. If these builds are hosted on Windows platforms, yes then there is a problem, because Sphinx does not currently provide this for Windows. If the builds are hosted on Unixen, then we are talking here about a Makefile which is customized only via the user project option (like the choice of using xelatex or pdflatex). The Makefile is recreated by Sphinx on each clean "make latex". It has nothing to do with the "top" Makefile which dispatches to the various builders "html", "latex", "man", "epub", etc... Those Makefile are often heavily customized by Sphinx user projects, but this is not the case of the LaTeX Makefile.
but: via latex_additional_files, a user can overwrite the produced Makefile by any file Makefile of his choice/devising. You probably do not want to execute blindly via make such unknown Makefile, as this may cause a security risk? (I don't know how sandboxed runs are).
The idea here could be rather to force use the Sphinx generated Makefile. The issue is that it is a template which has variables depending on how user has configured LaTeX in the conf.py.
However this will use Latexmk, which itself depends on configuration files (latexmkrc). This configuration file can also be overriden by user via  latex_additional_files in conf.py. AFAIK this can be used to replace pdflatex by anything. So again you probably want to only use a latexmkrc of your own.
Basically, you of course don't need this latex Makefile, as in case of pdflatex builds, it only issues latexmk -pdf -dvi- -ps- foo.tex, but inside the latexmkrc you have the configuration for either using makeindex or using xindy. The way xindy is called depends on the language of the project, and for Cyrillic it has special extras. At 1.8.0 currently the xindy rule was converted to Perl, so this all becomes a bit complicated to unravel. Basically for English project, it would look like this if written manually on a Unixen
$pdflatex = 'pdflatex %O %S';
$makeindex = '[ ! -s %S ] && : > %D || xindy -L english -C utf8  -M sphinx.xdy -M LICRlatin2utf8.xdy -I xelatex %O -o %D %S';

wow! (the initial bit is in case there is no .idx file, as xindy does not behave like makeindex in case of absent or empty .idx file). Now using xindy with English+pdflatex is not needed, but I only wanted to illustrate how that could go. You see here that additional xindy modules are needed which are created by Sphinx 1.8 not by earlier version which did not support xindy.
I may now start looking very scary.
To recap:

currently pdflatex, makeindex runs are hard-coded in a certain way,

you could  use rather Latexmk, by

executing latexmk -pdf -dvi- -ps-  foo.tex

having set-up a latexmkrc file like this
$pdflatex = 'pdflatex %O %S';
$makeindex = 'makeindex -s python.ist %O -o %D %S';

This will handle correctly Sphinx projects using pdflatex and not using xindy (and not having extensions managing glossaries). It will not handle correctly projects who want xelatex and/or xindy... (or Japanese documents, they use platex+ dvipdfmx). But it is not worse than current hardcoded pdflatex runs.
I hope I did not get too scary before that conclusion...

I tried a little more today to build the Chinese version of requests with latexmk inside our Docker image locally (outside all of the Read the Docs steps) and I wasn't able to make it work.
I was trying to do this, to see if we can start allowing some experimental testing with this under a Feature flag in production. Although, I don't want to enable anything like this unless we have a few projects tested and we know that this is working.
@jfbu do you have in mind any project that I can use for testing this that "just builds" without doing anything strange/weird or any kind of customized modification? It would be good to have a couple of them for these different cases that we were mentioning: German, Chinese, Japanese, and other non-ASCII languages.


Blindly applying expo doctor recommendations can create toxic updates

This seemingly innocent PR https://github.com/NWACus/avy/pull/554 created an update that sent test builds into a death spiral on startup. The only way to resolve was to download a new app store build, but I had a nervous wait for that build to finish before I knew it was ok.
My interpretation of what happened is that the new expo-* packages referenced in that PR have a corresponding native update, and if you publish JS that takes a dependency on those packages then you're effectively declaring that the app binary has been built with the correct native versions.
The problem is compounded by the fact that we kick off builds and updates in parallel, and updates finish faster, so a bad update gets published and there's no way for users to resolve. Until the new build is ready, even an uninstall/reinstall cycle doesn't help, because they reinstall an old build and immediately download the toxic update again.
Suggested resolution steps

revert #554
treat expo doctor warnings as warnings, not errors. applying new package versions should be part of the steps when actively releasing new binaries, and not something that's done frequently

expo-dev-client contains native code. I think the statement is more general - we should be able to tell when any commit changes native code, and force that to bump the native runtime version.

we should be able to tell when any commit changes native code, and force that to bump the native runtime version

linting yarn.lock changes against that concept would be ideal, not sure how many different ways there are for each package to structure their internals though. I don't know if they have to have ios and android directories, for example. but that'd be better than nothing!

Running against dev builds instead of Expo Go would also have demonstrated this problem immediately, and is considered an Expo best practice.

In general, this issue describes the failure mode that occurs when we issue an OTA with changes to native code; there's no immediate work to be done here - we simply need to be more diligent in which updates we issue when.


imagescan -L does not look for scanners in Docker properly

I have an Epson scanner, currently at /dev/bus/usb/001/004. A udev rule symlinks it to /dev/epson_scanner.
In a Docker container base on debian:stable-slim, sane-find-scanner and scanimage -L discovers the scanner, only if the device is mapped the the same name as in the host:
These fail:
    devices:
      - "/dev/epson_scanner:/dev/usb/scanner0"
      - "/dev/epson_scanner:/dev/bus/usb/001/005"
      - "/dev/bus/usb/001/004:/dev/usb/scanner0"

These succeed:
    devices:
      - "/dev/epson_scanner:/dev/bus/usb/001/004"
      - "/dev/bus/usb/001/004:/dev/bus/usb/001/004"

I expect that symlink devices will be recognised by scanimage -L even in Docker, which has been able to deal with them for several years.

This is the wrong repo. This is a web development stack. You're looking for something else.

Sorry, moved there: https://gitlab.com/sane-project/backends/-/issues/756.


Bug Fixes and System Logs Page

Fixes #439
Fixes #433
Fixes #379
This change fixes several general bugs and adds a system
Supergiant logs and notification section under the Supergiant
system tabs.

Coverage decreased (-0.2%) to 55.144% when pulling 999ddb4c93f99dc0d063d9043e5ed93c578e32db on gopherstein:master into 2bd4e007597c4e00ad676854518add3efc364f98 on supergiant:master.


sudo startxfce4 error

When running the following command
sudo startxfce4
I receive the following error:
(xfce4-session:14534): GLib-CRITICAL **: g_propagate_error: assertion `src != NULL' failed
Failed to connect to Xfconf daemon: //bin/dbus-launch terminated abnormally with the following error: EOF in dbus-launch reading address from bus daemon

Anyone know how to fix this?
Thanks!

i got the exact same one. im using the acer r11 chromebook but its too plain so i want to get ubuntu. i hope someone can fix this also.

@macroghan & @jimbo10001,
I don't know if you noticed but there is a form that we ask you to complete when opeinng a new issue.
It gathers some important details which helps us help you, I'm providing it below, please complete it.
Please paste the output of the following command here: sudo edit-chroot -all

Please describe your issue:
If known, describe the steps to reproduce the issue:

Thanx,
-DennisL

name: precise
encrypted: no
Entering /mnt/stateful_partition/crouton/chroots/precise...
crouton: version 1-20161116131524~master:9db73043
release: precise
architecture: amd64
xmethod: xorg
targets: xfce
host: version 8743.85.0 (Official Build) stable-channel cyan
kernel: Linux localhost 3.18.0-13101-g57e8190 #1 SMP PREEMPT Tue Nov
15 18:22:39 PST 2016 x86_64 x86_64 x86_64 GNU/Linux
freon: yes
Not unmounting /mnt/stateful_partition/crouton/chroots/precise as
another instance is using it.
On Thu, Nov 24, 2016 at 5:57 AM, DennisL<EMAIL_ADDRESS>wrote:

@macroghan https://github.com/macroghan & @jimbo10001
https://github.com/jimbo10001,
I don't know if you noticed but there is a form that we ask you to
complete when opeinng a new issue.
It gathers some important details which helps us help you, I'm providing
it below, please complete it.
Please paste the output of the following command here: sudo edit-chroot
-all
Please describe your issue: If known, describe the steps to reproduce the
issue:
Thanx,
-DennisL
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dnschneid/crouton/issues/2899#issuecomment-262781760,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AWnHwbM8zB0mieduK64LQuBRhQjQ16dQks5rBZe_gaJpZM4K3vs_
.

@jimbo10001,
Well that's a start, now:
Please describe your issue:
If known, describe the steps to reproduce the issue:

-DennisL


On planet rotation

Adding on planet rotation

Any updates on this branch? Will it be ready for review this weekend?

Code: ✅
Scripts have comments that explain the code. Variable names follow guidelines.
Functionality
It is possible to rotate the camera while right clicking. which seems to work ok currently but I have a couple suggestions to possibly improve this.
Improvements

Currently the mouse rotates only up and down. I think the feature would work better if there was more control over rotating. Not sure how it would be implemented currently though.
Also the camera jolts to look at the sky when you first right click, and then you can rotate down towards the planet but also more up and towards nothing. Is it possible to make the camera start at the current angle and have a slightly reduced limit so you can just look where the planet is?
The original request from Adon was to have the planet gameplay feel similar to the space gameplay. My interpretation of this would be that the camera kind of orbits the planet. and the player follows this positioning. This may be a very complicated feature and I may have seen it differently to others, so I don't mind if others disagree with this point.

Other Notes

You have two scripts: planetMaterialManager.cs and ApplyMaterial.cs in this branch which From what I understand this would solve the issue of the planet textures carrying through. However I cannot see if these have been implemented yet. Is this still a Work in Progress at this point?

they are scripts from former branch, forgot to delete them before pushing.

I had a look through the branch. I like the changes to controlling it and clamping the rotation. Definitely improved. I did notice that it's possible to rotate the camera while paused which just needs an if timescale is 0 check. The camera also snaps up and then back down when you spawn in. The player rotating with the mouse moving side to side also doesn't seem to do anything since the rotation changes whenever you move in a direction anyway. Also, the camera still feels closer than it was, but I am unsure if that is just a placebo.
Would it be possible to basically copy the X camera movement to the Y movement to have a full range of camera freedom? Or does that not work?
Good changes overall! Feels much better!

I had a look through the branch. I like the changes to controlling it and clamping the rotation. Definitely improved. I did notice that it's possible to rotate the camera while paused which just needs an if timescale is 0 check. The camera also snaps up and then back down when you spawn in. The player rotating with the mouse moving side to side also doesn't seem to do anything since the rotation changes whenever you move in a direction anyway. Also, the camera still feels closer than it was, but I am unsure if that is just a placebo.
Would it be possible to basically copy the X camera movement to the Y movement to have a full range of camera freedom? Or does that not work?
Good changes overall! Feels much better!

Have tried that before and it didn't work, it wont apply.


Published version 3.4.3 does not contain type definitions

Package.json doesn't have a "types" property anymore. There is a directory named types.d.ts/, but it's generated the same way as the other directories, and its package.json has pointers to non-existing files in ../cjs and ../esm. I don't think Typescript would be able to resolve types this way anyway (except maybe in TS 4.5 beta, which has some ESM support now).

I 've met the same issue.
According to this doc

Also note that if your main declaration file is named index.d.ts and lives at the root of the package (next to index.js) you do not need to mark the types property, though it is advisable to do so.

However there is neither index.js in the root nor types field defined in the published package.json file.


Use tree with knp menu bundle

Hey guys i'm trying to use Tree with knp menu bundle to build a dynamic menu but for the moment i didn't get anywhere can you help me out please ?
<?php
/**
 * Created by PhpStorm.
 * User: bogda
 * Date: 3/22/2016
 * Time: 1:20 PM
 */

namespace AppBundle\Menu;

use AppBundle\Entity\MenuItem;
use Doctrine\ORM\EntityManager;
use Knp\Menu\FactoryInterface;
use Symfony\Component\Routing\Router;

class MenuBuilder
{
    private $factoryInterface;
    private $em;
    private $router;
    private $menuName;
    private $menu;

    public function __construct(FactoryInterface $factoryInterface, EntityManager $em, Router $router)
    {
        $this->factoryInterface = $factoryInterface;
        $this->em = $em;
        $this->router = $router;
    }

    public function createAdminMenu(array $options)
    {
        $menuManager = $this->em->getRepository('AppBundle:MenuManager');

        $result = $menuManager->findOneByName('admin menu');

        $repo = $this->em->getRepository('AppBundle:MenuItem');

        $nodes = $repo->findByRootNodes($result->getId());

        $menu = $this->factoryInterface->createItem('root');

        $menu->setChildrenAttribute('class', 'nav navbar-nav');

        return $this->loadMenu($nodes, $result->getId(), $options, $menu);
    }

    public function loadMenu($nodes = null, $menuId = null, array $options, $menu = null)
    {
        $repo = $this->em->getRepository('AppBundle:MenuItem');

        foreach($nodes as $node)
        {
            $menu->addChild($node->getName(), ['uri' => $node->getRoute()])
                ->setAttribute('divider_prepend', $node->getDividerPrepend())
                ->setAttribute('divider_append', $node->getDividerAppend())
                ->setAttribute('dropdown', $node->getDropDown());

            $children = $repo->getChildren($node);

            foreach($children as $child)
            {
                $menu[$node->getName()]->addChild($child->getName(), ['uri' => $child->getRoute()])
                    ->setAttribute('divider_prepend', $child->getDividerPrepend())
                    ->setAttribute('divider_append', $child->getDividerAppend())
                    ->setAttribute('dropdown', $child->getDropDown());

                $childNode = $repo->getChildren($child);

                $this->loadMenu($children, '', $options, $menu);

            }
        }

        return $menu;
    }
}

please describe the issue you have, otherwise nobody can help you.
Btw, asking on StackOverflow might be better (as this issue tracker is not related to KnpMenu)

Hey stof thanks for responding. :-) i'm having trouble using tree without the methods that i found in documentation to build the tree. as you can see i'm trying to build the tree from 0 and add knp over it. but i get the root items then i get the second level and on the third level it shows the items as root nodes and doesn't add them in the right place.

Well, I see at least 1 issue in your KnpMenu code: when calling loadMenu recursively, you always pass it the root MenuItem. this is why they end up as top-level items. this is how things should look like IMO:
<?php
/**
 * Created by PhpStorm.
 * User: bogda
 * Date: 3/22/2016
 * Time: 1:20 PM
 */

namespace AppBundle\Menu;

use AppBundle\Entity\MenuItem;
use Doctrine\ORM\EntityManager;
use Knp\Menu\FactoryInterface;
use Knp\Menu\ItemInterface;
use Symfony\Component\Routing\Router;

class MenuBuilder
{
    private $factoryInterface;
    private $em;
    private $router;
    private $menuName;
    private $menu;

    public function __construct(FactoryInterface $factoryInterface, EntityManager $em, Router $router)
    {
        $this->factoryInterface = $factoryInterface;
        $this->em = $em;
        $this->router = $router;
    }

    public function createAdminMenu(array $options)
    {
        $menuManager = $this->em->getRepository('AppBundle:MenuManager');

        $result = $menuManager->findOneByName('admin menu');

        $repo = $this->em->getRepository('AppBundle:MenuItem');

        $nodes = $repo->findByRootNodes($result->getId());

        $menu = $this->factoryInterface->createItem('root');

        $menu->setChildrenAttribute('class', 'nav navbar-nav');

         $this->loadMenu($nodes, $options, $menu);

        return $menu;
    }

    private function loadMenu(array $nodes, array $options, ItemInterface $menu)
    {
        $repo = $this->em->getRepository('AppBundle:MenuItem');

        foreach($nodes as $node)
        {
            $childMenu = $menu->addChild($node->getName(), ['uri' => $node->getRoute()])
                ->setAttribute('divider_prepend', $node->getDividerPrepend())
                ->setAttribute('divider_append', $node->getDividerAppend())
                ->setAttribute('dropdown', $node->getDropDown());

            $children = $repo->getChildren($node);

            $this->loadMenu($children, $options, $childMenu);
        }
    }
}

note btw that calling $repo->getChildren($node); for each item of the tree means that the number of queries needed to build the menu will get insane. You should probably refactor the way you load your tree of entities to optimize the building of the menu.

tested the above code that you provided btw thank you very much still the issue persists on 3d level it shows the item on second level and the third level is empty :D

In the end a used childHierarchy and modified a few methods to be what i wanted :dancer:

yes @bogdaniel that is the best option you have so far.

yeah .. :D but i wanted to do my way .. and learn new stuff :D but still .. sometimes you have to compromise a little to gain more. :-)

hi @bogdaniel I am having the same issue, what did you found as solution ?

as i've said i used childHierarchy to build the tree and in the repository class i modified the queries a little to fit my needs.


Remove deprecation warnings with use of this.container.lookupFactory

Add branching logic to remove deprecation warnings on using this.container.lookupFactory.
Discussion around this issue here:
http://discuss.emberjs.com/t/best-practices-accessing-app-config-from-addon-code/7006/20

@andrewmp1 this issues is related, https://github.com/pixelhandler/ember-jsonapi-resources/issues/105 what do you think about using the getOwner polyfill? https://github.com/rwjblue/ember-getowner-polyfill

@andrewmp1 here is another use of this.container I'd like to upgrade at some point, https://github.com/pixelhandler/ember-jsonapi-resources/blob/master/addon/utils/related-proxy.js#L87

@andrewmp1 And in the test here is a method using lookupFactory that may need an upgrade, https://github.com/pixelhandler/ember-jsonapi-resources/blob/master/tests/helpers/resources.js#L46-L64

@andrewmp1 one more that is similar and could use the same treatment, https://github.com/pixelhandler/ember-jsonapi-resources/blob/master/addon/mixins/adapter-api-host-proxy.js#L15

Per our chat lets move toward a 2.0 release and remove container use all together. any use of container.lookupFactory will use getOwner(this)._lookupFactory (until .factoryFor is available).


What is init_word?

Why do we need to use --init_word in train if we have --placeholder_tokens ?
What kind of init_word exists?
How will the geniracy result change if you specify a different init_word?

Placeholder_token is what you'd use in your prompt to activate your embedding.
e.g. A photo of *

would be your placeholder token. In indicates to the code that you want to get the embedding from your saved file, rather than look up an embedding from the in-built dictionary. Some newer implementations have done away with tokens, e.g. automatic1111's UI for stable diffusion will use the filename of the embedding, so you could say "A photo of JohnSmith" and have a file called JohnSmith.pt in your embeddings directory.

init_word is the word you want to copy the embedding of to start the process. e.g. If you're trying to build a new embedding for a man, you might start with 'man' as your initial word to copy the embedding of, and then the process will try to change that embedding to match your new examples.

@CodeExplode pretty much summed it up :) Thanks!

Closing this since the question was answered. Feel free to reopen if you need more help.


Crashing while taking a build

Unity is crashing constantly while trying to build my application with spout sender on the camera. When I turn off the component I am able to build the application.

Which version of Unity are you using?

2017.3.0 .it was working yesterday. Is there anyways I can give you the
logs ?
On Mon, Mar 19, 2018, 9:12 PM Keijiro Takahashi<EMAIL_ADDRESS>wrote:

Which version of Unity are you using?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/keijiro/KlakSpout/issues/9#issuecomment-374258196,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AE1s5FtYJAUFnerEkM2cWceo-ixqUgpcks5tf9HSgaJpZM4SwHa7
.

First, thank you for your great work, Keijiro, it is absolutely amazing.
We are having exactly the same problem working with Spout, constant crashes on build.
Using Unity 2017.4.0.
Cheers,

First of all, please check the build architecture set to x86_64. KlakSpout doesn't support the 32-bit (x86) architecture.
If you still have problem with that, please send a minimum project that reproduces the problem.

Yep, in my case it was because of that.
Thank you very much!

FYI: I added x86 support in the latest version.
I'm closing this issue. Please feel free to reopen for further questions.


Release version 2.7.0

Features

Added support for PoE devices
Bootloader improvements

Bugs

Memory consumption fix

Misc

Code changes: https://github.com/luxonis/depthai-core/pull/171

@szabi-luxonis depthai shared doesn't have a PR as no commits were needed. Should I link to a tag on same commit?

@szabi-luxonis depthai shared doesn't have a PR as no commits were needed. Should I link to a tag on same commit?

Then still tag depthai-shared as 2.7.0 for consistency, same as previously.


Missing GLIBC_2.29

ImportError: /lib/x86_64-linux-gnu/libm.so.6: version `GLIBC_2.29' not found (required by /opt/hostedtoolcache/Python/3.8.6/x64/lib/python3.8/site-packages/chaine/crf.cpython-38-x86_64-linux-gnu.so)

Looks like this has something to do with Ubuntu 18.04

Looks like this has something to do with Ubuntu 18.04

https://stackoverflow.com/questions/2856438/how-can-i-link-to-a-specific-glibc-version
https://stackoverflow.com/questions/38399550/linking-to-specific-glibc-version-in-cython

https://stackoverflow.com/questions/2856438/how-can-i-link-to-a-specific-glibc-version
https://stackoverflow.com/questions/38399550/linking-to-specific-glibc-version-in-cython


Add a build-info.json file to the built apps

Fixes https://github.com/dart-lang/site-webdev/issues/1004
Only commit app (gh-pages) if at least one file other than the build file has changed.
Also sorts example names list when matching multiple examples.

Here is an example of a committed build-info.json file:

http://angular-examples.github.io/forms/4/build-info.json

@thso could you review this?


[Sandbox API] CRI status cleanup

Sandbox info includes a lot of metadata about pause container (runtime handler, snapshotter info, etc), this PR moves that code to podsandbox package and extends Sandbox.Status APIs to pass new fields.
Don't access pause container when running a pod container.
Minor fixes to get sandboxed shims running.

/test pull-containerd-sandboxed-node-e2e


Inconsistent behaviour of BN_add_word()

I used BN_add_word() to increment a 12 bytes memory, however, the result is not consistent.
Code:
#include <stdio.h>
#include <string.h>
#include <openssl/evp.h>

static void increment_nonce(unsigned char *const restrict nonce)
{
	BIGNUM *bn_nonce = BN_bin2bn(nonce, 12, NULL);
	BN_add_word(bn_nonce, 2);
	BN_bn2bin(bn_nonce, nonce);
	puts(BN_bn2dec(bn_nonce));
	BN_free(bn_nonce);
}

int main(int argc, const char *argv[])
{
	unsigned char nonce[12];
	memset(nonce, 0, 12);

	for (int i = 0; i < 4; ++i) {
		increment_nonce(nonce);

		for (size_t j = 0; j < 12; ++j)
			printf("%u ", nonce[j]);
		putchar('\n');
		putchar('\n');
	}

	return 0;
}

Output:
2
2 0 0 0 0 0 0 0 0 0 0 0

618970019642690137449562114
2 0 0 0 0 0 0 0 0 0 0 2

618970019642690137449562116
2 0 0 0 0 0 0 0 0 0 0 4

618970019642690137449562118
2 0 0 0 0 0 0 0 0 0 0 6

Questions:
Why the function increment the last byte of the memory from the second iteration onwards?
How to do it properly?
Is the function the same as sodium_increment?

The BN_bin2bn and BN_bn2bin expect big endian representation of the big number in the memory. And, BN_bn2bin outputs the minimum number of bytes needed to represent the number. So in the first cycle the BN_bin2bn sees 12 byte zero bignum value however BN_bn2bin it outputs just the first byte with the value 2 because that is the shortest representation. However in the second cycle the BN_bn2bin now sees 12 byte bignum value with the value of 0x020000000000000000000000 which is then incremented by 2 to make 0x020000000000000000000002.
If you need little endian value in the nonce with a fixed size use BN_lebin2bn and BN_bn2lebinpad.

And of course this is not particularly efficient because the bin2bn conversion routines allocate memory for the new bignum if used with NULL bn parameter.

If you're just trying to do a counter-based fixed-width nonce, however, BIGNUM is probably not the thing to use in the first place. Think about whether it's actually possible to overflow beyond, say, a uint64_t in whatever protocol you're using.

Thanks for the suggestions.