Using the Monaco Editor in a browser without VSCode

Now that VS Code is open source, it also means that the Monaco Editor is open source (at-least to some extent).
I would really like to use this editor in my own web application for editing TypeScript files. The only problem is I can't find any documentation about how to do this. I know its possible because the editor is on TypeScript Playground and a few other places.
As far as I can tell, the open sourcing of VS Code is the first time the source code of the Monaco editor has been made public. Also, I think that the VS Code repository is the primary source of the Monaco editor (someone from Microsoft please confirm?).
So far, there have been many questions about using the Monaco Editor on Stack Overflow and other forums, but I have yet to see an official reply from Microsoft.
Can someone please provide some documentation on using the Monaco Editor in a web site, or perhaps release the source code of TypeScript Playground (There is nothing to hide now that we have the Monaco source in the VS Code repository).
Currently, the only thing keeping me from using TypeScript as a JavaScript replacement is the fact that I can't easily use the Monaco Editor inside of my web application. I'm currently using the ACE Editor with a  Tern plugin I created. I don't want to go through all of the work of creating full Intellisense support for TypeScript inside of ACE because its a significant undertaking- Instead I'd rather contribute to the Monaco editor and use it as a replacement for ACE (and replace JavaScript with TypeScript).

+1 for this. Doing proper context code completion in CodeMirror and Ace is a nightmare. An open source editor that had good hooks to this kind of thing would be gold. We just need some docs on using it ;)

@sevin7676 you are correct that the Monaco editor is contained in the vscode repository and we are working on making the Monaco Editor more easy to consume independent of VS Code.

+1 making some docs on Monaco editor. So far this editor beats both codemirror and ace :)

This is almost same as #815

I'm eagerly awaiting this also. Don't forget to close this UserVoice suggestion when it's complete. https://visualstudio.uservoice.com/forums/293070-visual-studio-code/suggestions/7782546-release-monaco-javascript-code-editor

+1, the other options like codemirror or ace does not even come close compared with typescript playground

+1 Waiting for this!

+1
Any news on this? I'm waiting for this so I can embed the editor on our product's config page where the user can edit custom TypeScripts that are run on a server and provide our API definition.
Thanks!

It is still on our backlog but it didn't make it to the for the GA milestone, sorry.

I've been using code mirror to bootstrap http://alm.tools/. Would really like to migrate to Monaco (mostly because of https://github.com/alm-tools/alm/issues/13). I have time, it's a labor of love 🌹

Thanks! I'll let the team know @Microsoft/vscode

+1 The editor at the typescriptlang playground is amazing! Especially the speed, intellisense, and VS look-and-feel.
Been working a lot with other code editors that offer intellisense, but none come close to Monaco. Eagerly waiting :)
Thanks for keeping us updated, egamma

+1 yes please

:+1:

I managed to get the editor working using something similar to darrinm's solution but I still haven't figured out how to add extra libraries to the auto completion system. The azure-based playgrounds out there seem to have a way to include code libraries but the API seems different for the version in VS Code and I haven't been able to figure it out yet :(

:+1:

@egamma do you have a rough date on when this might be available?

+1 please make it possible

+1 ,I think that this feature will bring closer to this project many people who don't use the vs code yet

+1 really looking forward this, Monaco is hidden too deep in azure and Microsft should definitely make the best WebIDE available as a standalone service.

@mbana we made good progress on this during the April decompression iteration (e.g. #4640). However, we need more time to work on docs. It is a candidate for May but we do not have the May iteration plan yet.

@egamma, thank you. I looked at the PR - there's a lot of commits there and I am not entirely familiar with with VSCode code-base just yet.

Is there a minimal example available that I could look at?
Out of interest, is VSCode taking the approach Eclipse took in allowing one to build ship a custom IDE with only a chosen set of features enabled?

All the best! Love the VSCode.

@mbana I've linked to the PR as an illustration of progress, not that you can use it already.

Out of interest, is VSCode taking the approach Eclipse took in allowing one to build ship a custom IDE with only a chosen set of features enabled?

This is not our main focus but you can create a branded custom IDE, the product.json file is the means towards branding.
Glad you like VS Code

Is there any difference between Monaco Editor and Winjs (http://try.buildwinjs.com/)? They both seem similar. Will Monaco be better than Winjs?

@gujiman The WinJS site seems to use a version of monaco, since it uses classes like monaco-editor vs-dark. The WinJS library itself does not seem to contain any code editor controls.

The intellisense/autocomplete in Winjs appears to be very slow.  I suggest looking at http://vbguyny.github.io/Ace.Tern/demo.html which uses the ACE editor plus the Tern libraries to create a very powerful and fast editor.

@gujiman WinJS is irrelevant, it is a collection of UI controls which does not contain a source code editor.
If you are looking for good examples of Monaco in browser you can check http://www.typescriptlang.org/play/index.html or Visual Studio Live if you have an Azure Subscription.
@egamma Is there any possibility to access Visual Studio Live source code? I know https://github.com/projectkudu/kudu is open source but front end code is not available, right?

Please see the May plan we will make progress on this topic https://github.com/Microsoft/vscode/issues/6105

Great news! Thank you egamma!

I've been meaning to get a prototype of vscode as editor in chrome devtools workspaces in my free time. Would be great to have documentation.

@egamma Thanks a lot for your Q&A yesterday in Shanghai. I read the plan and looks like Monaco will be a separate repo? is this happening already? Can we have the URL?
BTW: hope you had a great time in China :)

@ups216 its been done https://www.npmjs.com/package/monaco-editor-core which is just shipped (pushed to npm) from this repository and I'm experimenting migrating alm to it as well https://github.com/alm-tools/alm/issues/120 :rose:

@basarat have you considered using something like https://github.com/lerna/lerna to help manage the mono-repo approach (single repo, multiple npm packages) ? Do you think there will be other goodies in VSCode that make sense to extract as separate npm packages?

It looks like progress is being made on this :)
https://code.visualstudio.com/updates#vscode

+1 looking forward to get the full Javascript solution of vscode. This is exciting!

\o/ https://github.com/Microsoft/monaco-editor

@maxdec , thank you for the link.
The issue is now resolved!
https://github.com/Microsoft/monaco-editor

Just made a release of alm that uses monaco : 0.1.0. Let me know how it goes :rose:

Will VSCode use this newly extracted Monaco? Will they be synchronised? Will they diverge?

Seem like it already done. You could npm it
https://github.com/Microsoft/monaco-editor

GHEdit is a project that has "ported" large sections VSCode to run in a browser. If you have an interest in doing that here is the project page:
https://github.com/spiffcode/ghedit
It's targeted at editing, searching, and browsing Github repos. Live version:
https://spiffcode.github.io/ghedit


fix(e2e): fix eslint playwright/expect-expect rule and configure as error

@quentinderoubaix Thank you for your review!


Minor optimizations

This PR refactors the ReorderBuffer::commitMicroOps method by using binary search to find the list of uops with the same instruction id. This improves the complexity from O(n) to O(logn). *
Changes the DispatchIssueUnit::tick method to use a dynamic array instead of initializing a vector for each method call. This eliminates  ~ 14m memory allocations for stream-triad.
Replaced std::vector to std::list in LoadStoreQueue::startLoad as it provides O(1) deletion compared to O(n) (worst-case).
Turn off the creation of special files by default as it creates a significant performance drag during startup.
* - I did try and implement the idea of having pointers to all the child uops from a parent uop (parent is just the first uop) but this created a lot of code complexity and didn't provide a significant performance benefit and also couldn't fix all the bugs. The code for this resides in the optimizations branch.

#rerun tests

These are great optimisations. Thanks Mutalib! Again, these changes will be moved over to PR #273 so that we can merge them into dev asap without the last commit (Turn off special File generation by default) included.


Transparency support

Transparencies display black in  component and the cropped result image.
Cool library thank you.

Hi, it just renders the src you pass to it, my guess is that you’re taking
a file input and converting it to JPG, and the crop example I provided also
coverts to JPG if I recall but you can change the png easily it just makes
the conversion slower.
On Fri, 7 Dec 2018 at 01:16, Michael Lee<EMAIL_ADDRESS>wrote:

Transparencies display black in component and the cropped result image.
Cool library thank you.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/DominicTobias/react-image-crop/issues/227, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAuZ-lGRlGZhj3nMAq34w6uCbAZAiyssks5u2cFngaJpZM4ZHnK1
.

That works excellent thank you, sorry to not review further before posting.


Questions about CDR claim parameters

I successfully ran the quick start demo gputest1,2,3 these days on Ubuntu 22.04, all the behaviors are performed as expected. With great appreciation to the maintainers and commiters, I still do have some questions on resource ResouceClaim and ResourceClaimTemplate.
OS: Ubuntu22.04LTS
kernel:6.5.0-35-generic
GPU: RTX4080 Laptop
cuda:12.3
driver:545
cluster: 1.29 by kind in the demo, 2 nodes, one master, one worker

Question1:
What is the different of feild ResourceClaimTemplate between gputest1 and gputest2? Is it true that one ResourceClaimTemplate claimed in two Pods rather than two containers leads to # Each container asking for 1 distinct GPU?
Question2:
Is there a way for 2 containers of one Pods to claim to distinct single GPU each?
Question3:
Comparing gputest1 and gputest3, the main difference are below.
A. using ResourceClaim instead of ResourceClaimTemplate
B .name of ResourceClaim or ResourceClaimTemplate
C. another spec in ResourceClaimTemplate.
Cloud anyone tells me how are these differents result in the SharingGPU or DistinctGPU?
Thanks again for the devotion of you, and hope you could answer me sooooooon.

Question5:
Does ResourceClaim mean binding to exactly one single GPU, so that all the containers using this ResourceClaim can share one GPU? And does ResourceClaimTemplate mean binding to any single GPU?

What is the different of feild ResourceClaimTemplate between gputest1 and gputest2? Is it true that one ResourceClaimTemplate claimed in two Pods rather than two containers leads to # Each container asking for 1 distinct GPU?

A ResourceClaim has resources directly bound to it, and any pod that references it will have shared access to those resources.
A ResourceClaimTemplate provides a template for a ResourceClaim that will be generated on the fly for each pod that references it. In this way each claim will have their own unique ResourceClaim with their own unique resources bound to it.

Is there a way for 2 containers of one Pod to claim to distinct single GPU each?

Note: Below is the API that was valid from Kubernetes 1.26-1.30. It has changed slightly for 1.31 but the mechanism is similar.
---
apiVersion: resource.k8s.io/v1alpha2
kind: ResourceClaimTemplate
metadata:
  namespace: gpu-test
  name: unique-gpu
spec:
  spec:
    resourceClassName: gpu.nvidia.com

---
apiVersion: v1
kind: Pod
metadata:
  namespace: gpu-test
  name: pod
  labels:
    app: pod
spec:
  containers:
  - name: ctr0
    resources:
      claims:
      - name: gpu0
  - name: ctr1
    resources:
      claims:
      - name: gpu1
  resourceClaims:
  - name: gpu0
    source:
      resourceClaimTemplateName: unique-gpu
  - name: gpu1
    source:
      resourceClaimTemplateName: unique-gpu

Cloud anyone tells me how are these differents result in the SharingGPU or DistinctGPU?

My answer to question (1) hopefully clarifies this already. Each reference to a ResourceClaimTemplate triggers the creation of a unique ResourceClaim (to which unique resources will eventually be bound). Each reference to a ResourceClaim gives shared access to the resources bound to it.


Heatmap problem in renderMode: 'image'

In the past (Version 4.6.4), in ol.layer.Heatmap, when I set 'renderMode' to be 'image', the gradient of the point becomes 'black' and the gradient I set before disappeared. And setting 'renderMode' to be 'vector' display normally.
let layerOptions = {
    ...
    renderMode: 'image',
    gradient: ['#00c3ff', '#ffff1c', '#e9e9e9']
};
return new ol.layer.Heatmap(layerOptions);

The renderMode property is now ignored by the Heatmap layer.


New I/O client worker thread cpu 100%

Undertow server and java springboot application;
cpu usage 100% and memory used less than 10%
jstack info:

Netty version: 3.2.1.Final
Jdk version: openjdk 1.8.0_292
OS : Docker container 2C 4G cnetos7
Any idea will be helpful!!!

More information needed.


Kythe Schema Documentation SVG links broken in some cases. [phab:T199]

Created by craigbarber at 2017-01-04 00:47:52:
A non-trivial amount of the SVG image links with the Kythe schema documentation are broken, leading users to 404 errors.
Example: http://www.kythe.io/docs/schema#variable
Many of the SVG links for the variable section are broken.

craigbarber wrote at 2017-01-05 22:42:09:
After discussing the issue with Cody, it turns out this problem only manifests when the trailing "/" is omitted from the URL.


Fix routes

Allow ypconfig to add, change and remove routes.

Please hold this PR for now. I found bugs in it.


could you sent a invite Slack link to me?

@benyang2015 sure, share your email and I'll send an invite to you.


Feature/Modelling-HTS-Client-Tests-Fact-table

Added an Intermediate table to select the latest encounter for a combination of PatientPK and SiteCode
Added a FactHTSClients test that displays the latest HTS testing encounter data for a patient

Just a question @nobert-mumo why are we having a Last encounter for HTS tests?

@Marymary-dev you mean why we are creating an intermediate table for HTS tests ?


Fix option to show only errors

This did the trick? Because I tried in CLI to use that option, and couldn't get it to work properly...

This works for me.

This works for me, you could try --warning-severity=0 otherwise

I tried with --runtime-set show_warnings 1 and --runtime-set show_warnings 0, but the correct is --runtime-set show_warnings true? Guess that's why it didn't work...

@dingo-d Both 1 or true not working in your case?

@ernilambar Only 1 didn't work.


chore: upgrade to prettier v2 + enforce import types

Description
This PR upgrades Prettier to v2 + enforces TypeScript’s import type syntax where applicable. It’s submitted as a separate PR so we can merge it easily.
As a part of this PR, we reformat the codebase heavily:

add import type everywhere where it’s required, and
re-format the code to account for Prettier 2’s breaking changes: https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes

This PR is submitted against release to make sure all new code by team members will adhere to new formatting standards, and we’ll have fewer conflicts when merging bundle-optimizations into release. (I’ll merge release back into bundle-optimizations once this PR is merged.)
Why is this needed?
This PR is needed because, for the Lodash optimization from https://github.com/appsmithorg/appsmith/commit/7cbb12af886621256224be0c93e6a465dd710ad3, we need to use import type. Otherwise, babel-plugin-lodash complains that LoDashStatic is not a lodash function.
However, just using import type in the current codebase will give you this:

That’s because Prettier 1 can’t parse import type at all. To parse it, we need to upgrade to Prettier 2.
Why enforce import type?
Apart from just enabling import type support, this PR enforces specifying import type everywhere it’s needed. (Developers will get immediate TypeScript and ESLint errors when they forget to do so.)
I’m doing this because I believe import type improves DX and makes refactorings easier.
Let’s say you had a few imports like below. Can you tell which of these imports will increase the bundle size? (Tip: it’s not all of them!)
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";

It’s pretty hard, right?
What about now?
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";

Now, it’s clear that only lodash will be bundled.
This helps developers to see which imports are problematic, but it also helps with refactorings. Now, if you want to see where codemirror is bundled, you can just grep for import \{.*\} from "codemirror" – and you won’t get any type-only imports.
This also helps (some) bundlers. Upon transpiling, TypeScript erases type-only imports completely. In some environment (not ours), this makes the bundle smaller, as the bundler doesn’t need to bundle type-only imports anymore.
Type of change

Chore (housekeeping or task changes that don't impact user perception)

How Has This Been Tested?
This was tested to not break the build.
Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[x] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Test plan has been approved by relevant developers
[ ] Test plan has been peer reviewed by QA
[ ] Cypress test cases have been added and approved by either SDET or manual QA
[ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
[ ] Added Test Plan Approved label after reveiwing all Cypress test

/build-deploy-preview env=release

/build-deploy-preview

@iamakulov Thanks for enabling the use of import type.
I noticed some of the files having other changes, it seems to arise out of a difference in the single line character length limit.

Do you have any speculations on how this could have happened and what we can do to avoid this in the future?

Do you have any speculations on how this could have happened and what we can do to avoid this in the future?

Yup! That’s a one-time change caused by the upgrade to Prettier v2 (which was a breaking change precisely due to slight formatting updates). See here for more: https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes

/ok-to-test

/ok-to-test

/ok-to-test

/perf-test

/perf-test

/ok-to-test

/ok-to-test

/perf-test


Hedge to resources

EidosSystem now owns a HypothesisHandler, and hedging is done in EidosSystem's main pipeline method.  As a consequence, the lexical terms are in a resource file for language specific
versions... fyi @gcgbarbosa @marcovzla

Heads up then, @gcgbarbosa @marcovzla.  It is merged and you have English in your Portuguese.


Using bypass fqdn option on a delivery service requires http(s) in the form field

This results in bypass error of:
Issue another request to this URL: 'http://http:0/foo'

getaddrinfo(3) failed for http:0
Couldn't resolve host 'http'

please remove the http(s) requirement on form field

+1.  That field is called http_bypass_fqdn not http_bypass_url.  The field should contain an FQDN and not a URL, so we should NOT have a restriction on http(s)://
The current work-around is to edit the field directly in the database.

This is a problem with the form validation in Traffic Portal, but I just checked traffic_ops_golang and didn't find any validation of httpBypassFqdn there either. So, this is really a 2-part fix:

Change the pattern validation in TP to match a valid FQDN (rather than a URL)
Add API validation in traffic_ops_golang to ensure it's a valid FQDN

Issue for part 2: #2770


Quantile Hausdorff distance is not deterministic

Dear Abdel,
First, thank you very much for your implementation and great review of evaluation metrics.
I may have found a problem with your Hausdorff distance (HD) implementation. In your paper (An Efficient Algorithm for Calculating the Exact Hausdorff Distance), you write that the implementation is easily extendible to the quantile HD (Section 3.6). Unfortunately, I found that the quantile HD based on your algorithm does not yield deterministic results and the results are different compared to other implementations (note that the exact HD seems to be correct). I think the non-deterministic results might arise due to random sampling and the different results to other algorithms due to the early breaking in your algorithm.
I created three ground truth / segmentation examples (download here), which all yield different 95th HD in different runs. You can download the examples here (mha and png images) and run your script (version 2017.04.25) to reproduce my findings:
./EvaluateSegmentation ./EXAMPLE1_GROUNDTRUTH.mha ./EXAMPLE1_SEGMENTATION.mha -use<EMAIL_ADDRESS>Can you please comment on this and do you have a fix for this issue?
Best,
Fabian

I found the same issue. Maybe we can run five times and take an average.


Minor text edits and breaking out css js to own files for future deve…

Please see the full comments at the bottom of the page.
Minor text/grammar edits
New header titles for the charts - just a suggestion, up to you to make the change. There might be a better way to word it.
Broke out css/js into their own files so that charts could be added in other areas and any changes in css/js would be global.
TODO: Break out the charts js from MainPage.js into its own file.

Didn't see your changes. But I will implement them in the new CORE version of the plugin asap!
Thanks for the help


Add instructions to set Sublime Text as default git editor

Problem
Students are often confused when git drops them into Vim to edit a commit message.
Proposal
Add instruction to the Git setup portion of the prework to set Sublime (or Atom) as default text editor.

Relevant part of prework (mac version): https://github.com/codefellows/code-201-prework/blob/master/prework/mac/4_git.md#git-config
Example Git instructions: https://help.github.com/articles/associating-text-editors-with-git/#using-atom-as-your-editor

Actually, now that we're going Atom, that needs to be changed in here, too...

Changed link to Atom-Git marriage instructions.

Is this different than the subl section https://github.com/codefellows/code-201-prework/blob/master/prework/mac/3_sublime_text.md#subl ?
Yes this will be updated to Atom.


forge 1.8.9

please make forge 1.8.9

You're free to do it yourself, however I'm not going to port this to forge.


Design: sources

The work for this task is to design this feature and present one or more proposals (before implementing).
Expected Behavior
It should be possible for Pipelines to execute against multiple kinds of "sources".
The exact definition of what a "source" is a bit murky but generally we want this to be the same as a knative build CRD source, since ultimately that is how the Source will be used (once it is passed down to a Task as an input).
As far as the knative build CRD is concerned, a source could be:

git
gcs
a custom image

And we would want to support other sources in the future as well, which should be arbitrarily extensible.
Also in #2 @pivotal-nader-ziada pointed out that we might want to be able to use outputs of Tasks as inputs to subsequent Tasks (e.g. mount a built image directly into a subsequent Task as a source).
Requirements

It should be possible to use git, gcs or a custom image as a source
It should be possible to add other kinds of sources (in a first iteration, this could require changing the pipline crd controller but in the long run it should be possible to do without forking the implementation)
For Tasks and Pipelines that need it, it should be possible to access additional information about sources, e.g. for a git source you might want to use the commit ID, the branch name, the committer, the author, etc.

Actual Behavior
In our examples we show what a possible github source could look like:

Additional Info
Though event triggering is outside the scope of the Pipeline CRD, we need to make sure that when an event DOES trigger a pipeline to run (by creating a PipelineRun and probably also a PipelineParams), that it is possible to provide all relevent info, so it might be worth exploring what info is contained in event such as github Pull Request events
See #11 re. ensuring the same sources/inputs are used throughout a Pipeline.

This design work has been covered in #39! Thanks @shashwathi and @pivotal-nader-ziada !! :champagne:


WIP: TEAMNADO-2457 Convert Export Manifest Notifications To Toast Notifications

What's Included:

Export Manifest loading, success and error state removed from side panel
When export is initiated, info toast alert appears that reads "Manifest ${name} exporting. This may take some time. Please wait." This toast alert does not disappear after eight seconds, but only when dismissed by clicking the X.
When successful, the info (loading) notification is replaced with a success notification that reads "Manifest ${name} Exported. [Line Break] [link to download manifest]Download Manifest[/link]". This toast alert does not disappear after eight seconds, but only when dismissed by clicking the X.
When error, the info (loading) notification is replaced with an error notification that reads "Something went wrong. Please refresh the page and try again." This toast alert does not disappear after eight seconds, but only when dismissed by clicking the X.
While exporting, action toggles are disabled to prevent user attempting to export multiple manifests at a time (which is not currently supported)
addNotifications hook is enhanced to take in an additional options parameter, which includes a hasTimeout option (which can be set to false to disable the alerts disappearing), a link option (if the notification has a link), and a keyOfAlertToReplace option, in the event that a new alert should replace a previous one.

Codecov Report

Merging #32 (92b707c) into main (c62aa7b) will decrease coverage by 0.55%.
The diff coverage is 70.58%.

@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
- Coverage   89.77%   89.21%   -0.56%
==========================================
  Files          41       41
  Lines         626      640      +14
  Branches      109      107       -2
==========================================
+ Hits          562      571       +9
- Misses         64       69       +5

Impacted Files
Coverage Δ

src/components/Notifications/Notifications.tsx
100.00% <ø> (ø)

...anifestDetailSidePanel/ManifestDetailSidePanel.tsx
85.71% <40.00%> (+4.17%)
:arrow_up:

.../SatelliteManifestPanel/SatelliteManifestPanel.tsx
63.93% <43.33%> (-4.34%)
:arrow_down:

src/contexts/NotificationProvider.tsx
96.87% <100.00%> (+4.01%)
:arrow_up:

src/hooks/useExportSatelliteManifest.ts
100.00% <100.00%> (ø)

src/hooks/useNotifications.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c62aa7b...92b707c. Read the comment docs.


[SPARK-13242] [SQL] Fall back to interpreting complex when expressions

This follows @davies suggestion over on https://github.com/apache/spark/pull/11221 but rather than hard coding a limit on the number of branches, it does a heuristic check on the generated source code size.
This isn't ideal, but will work well in practice and mirrors the approach in https://github.com/apache/spark/pull/7076

Can one of the admins verify this patch?

@davies Thanks for taking a look at this. I've incorporated your fixes -- though I think you meant 10K rather than 1K as the source code threshold?

I meant 1K source code for this expression. If a Java method jave more than 8K bytes code, JIT will not compile it, we should leave enough space for other staff.

Jenkins, OK to test.

Ah... I figured 10K of source code would compile to at most 4K bytecode. But I can see the case for requiring it to be smaller still. I'll adjust to 1K.

@davies sorry, I think my extra commit may have confused Jenkins?

@davies Hi, I guess this missed the window for 1.6.1? Codegen errors of this sort on complex expressions represent a regression with respect to 1.5.2 which are preventing us from being able to upgrade. Falling back to interpreting (as in this PR) is not an ideal solution, but at least it would get our code running again.

@joehalliwell Do you mind me to take over this one? so we can merge this quickly.

Not at all, please do!


Feature Request: Rotation of Images

Enable users to rotate images within Annotation Lab to facilitate more precise annotation and analysis of data. This feature would allow seamless manipulation of image orientation directly within the annotation interface, enhancing user efficiency and accuracy.
Key Benefits

Enhanced Annotation Precision: Users can adjust image orientation to ensure annotations align accurately with object boundaries and features.
Improved Workflow Efficiency: Eliminates the need for external image editing tools solely for rotation, streamlining the annotation process.
Flexible Data Handling: Supports datasets with varying image orientations, accommodating different perspectives and orientations without preprocessing.

Implementation Details

User Interface Integration: Integrate a user-friendly rotation tool directly within the Annotation Lab interface, accessible via intuitive controls.
Angle Adjustment: Allow rotation in increments (e.g., 90-degree rotations) or provide a free rotation option for finer adjustments.
Undo/Redo Functionality: Include the ability to undo rotations or revert to original orientation to correct mistakes or experiment with different angles.

Use Case Scenarios

Medical Imaging: Rotating medical scans for precise annotation of anomalies or features.
Agricultural Monitoring: Adjusting satellite imagery to align with crop rows or terrain features for accurate annotation.
Industrial Quality Control: Rotating images of manufactured parts to annotate defects or product features effectively.

The addition of image rotation capabilities in Annotation Lab would significantly enhance its utility across various domains, empowering users to annotate data more accurately and efficiently. This feature aligns with the platform's goal of providing robust tools for data annotation and analysis, catering to diverse user needs and scenarios.

The image rotation task has been initiated, but I don't believe we need this functionality because the output results may differ from the originals. Therefore, I am closing this feature for now.


Getting icon in terminal, terminal has no visibility for copilot

VS Code Version:1.84.0
OS Version: Windows_NT x64 10.0.22621
Logs:

2023-11-06T17:21:34.830Z [INFO] [auth] Logged in as theklr
2023-11-06T17:21:35.200Z [INFO] [chat] copilot token chat_enabled: true
2023-11-06T17:21:35.207Z [INFO] [auth] Got Copilot token for theklr
2023-11-06T17:21:35.283Z [INFO] [auth] Logged in as theklr
2023-11-06T17:21:35.286Z [INFO] [chat] copilot token chat_enabled: true
2023-11-06T17:21:35.287Z [INFO] [auth] Got Copilot token for theklr
2023-11-06T17:24:55.911Z [INFO] [chat fetch] engine https://api.githubcopilot.com/chat
2023-11-06T17:24:55.911Z [INFO] [chat fetch] modelMaxTokenWindow 4096
2023-11-06T17:24:55.911Z [INFO] [chat fetch] chat model gpt-4
2023-11-06T17:24:58.413Z [INFO] [chat fetch] request.response: [https://api.githubcopilot.com/chat/completions], took 2501 ms
2023-11-06T17:25:10.590Z [INFO] [streamMessages] message 0 returned. finish reason: [stop]
2023-11-06T17:25:10.591Z [INFO] [streamChoices] request done: headerRequestId: [f396a958-07be-4c15-b755-714799d47395] model deployment ID: [x3b0892d9e5fc]
2023-11-06T17:25:10.747Z [INFO] [chat fetch] engine https://api.githubcopilot.com/chat
2023-11-06T17:25:10.747Z [INFO] [chat fetch] modelMaxTokenWindow 8192
2023-11-06T17:25:10.747Z [INFO] [chat fetch] chat model gpt-3.5
2023-11-06T17:25:11.699Z [INFO] [chat fetch] request.response: [https://api.githubcopilot.com/chat/completions], took 951 ms
2023-11-06T17:25:11.701Z [INFO] [streamMessages] message 0 returned. finish reason: [stop]
2023-11-06T17:25:11.702Z [INFO] [streamChoices] request done: headerRequestId: [048e96d5-fadd-40a2-ad83-bc9c182bbc8d] model deployment ID: [x2191bfb807ec]
2023-11-06T17:38:40.881Z [INFO] [chat fetch] engine https://api.githubcopilot.com/chat
2023-11-06T17:38:40.881Z [INFO] [chat fetch] modelMaxTokenWindow 4096
2023-11-06T17:38:40.881Z [INFO] [chat fetch] chat model gpt-4
2023-11-06T17:38:44.261Z [INFO] [chat fetch] request.response: [https://api.githubcopilot.com/chat/completions], took 3379 ms
2023-11-06T17:38:44.294Z [INFO] [streamMessages] message 0 returned. finish reason: [stop]
2023-11-06T17:38:44.296Z [INFO] [streamChoices] request done: headerRequestId: [07f114bd-645a-4cdc-ad89-1ee49838065f] model deployment ID: [x3b0892d9e5fc]
2023-11-06T17:38:44.384Z [INFO] [chat fetch] engine https://api.githubcopilot.com/chat
2023-11-06T17:38:44.384Z [INFO] [chat fetch] modelMaxTokenWindow 8192
2023-11-06T17:38:44.384Z [INFO] [chat fetch] chat model gpt-3.5
2023-11-06T17:38:45.626Z [INFO] [chat fetch] request.response: [https://api.githubcopilot.com/chat/completions], took 1242 ms
2023-11-06T17:38:45.627Z [INFO] [streamMessages] message 0 returned. finish reason: [stop]
2023-11-06T17:38:45.627Z [INFO] [streamChoices] request done: headerRequestId: [78e343cf-139e-4bd9-900f-eeb75a208477] model deployment ID: [x2191bfb807ec]
2023-11-06T17:46:35.210Z [INFO] [auth] Logged in as theklr
2023-11-06T17:46:35.434Z [INFO] [chat] copilot token chat_enabled: true
2023-11-06T17:46:35.434Z [INFO] [auth] Got Copilot token for theklr
2023-11-06T18:11:35.442Z [INFO] [auth] Logged in as theklr
2023-11-06T18:11:35.664Z [INFO] [chat] copilot token chat_enabled: true
2023-11-06T18:11:35.664Z [INFO] [auth] Got Copilot token for theklr
2023-11-06T18:36:35.666Z [INFO] [auth] Logged in as theklr
2023-11-06T18:36:35.869Z [INFO] [chat] copilot token chat_enabled: true
2023-11-06T18:36:35.870Z [INFO] [auth] Got Copilot token for theklr
2023-11-06T18:43:11.424Z [INFO] [chat fetch] engine https://api.githubcopilot.com/chat
2023-11-06T18:43:11.424Z [INFO] [chat fetch] modelMaxTokenWindow 4096
2023-11-06T18:43:11.424Z [INFO] [chat fetch] chat model gpt-4
2023-11-06T18:43:14.188Z [INFO] [chat fetch] request.response: [https://api.githubcopilot.com/chat/completions], took 2763 ms
2023-11-06T18:43:21.493Z [INFO] [streamMessages] message 0 returned. finish reason: [stop]
2023-11-06T18:43:21.494Z [INFO] [streamChoices] request done: headerRequestId: [a0f26e3d-5b42-47b9-a5ce-c9c9afd56dbc] model deployment ID: [x3b0892d9e5fc]
2023-11-06T18:43:21.602Z [INFO] [chat fetch] engine https://api.githubcopilot.com/chat
2023-11-06T18:43:21.602Z [INFO] [chat fetch] modelMaxTokenWindow 8192
2023-11-06T18:43:21.602Z [INFO] [chat fetch] chat model gpt-3.5
2023-11-06T18:43:21.971Z [INFO] [chat fetch] request.response: [https://api.githubcopilot.com/chat/completions], took 369 ms
2023-11-06T18:43:21.972Z [INFO] [streamMessages] message 0 returned. finish reason: [stop]
2023-11-06T18:43:21.973Z [INFO] [streamChoices] request done: headerRequestId: [d2cb5930-8d3b-4f61-b010-a2e8b21c1ce0] model deployment ID: [x2191bfb807ec]

Steps to Reproduce:

attempt a run in vs code terminal
copilot icon appears, click on icon
See chat drawer display
Get response:

 As an AI, I don't have access to your terminal history. Could you please provide the command you want to know about? I can then help explain what it does.

I cannot reproduce this behavior, do you have a command that this reliably occurs for?

Seems like it appeared before the updates with copilot. Feel free to close


verifyStartStop(usage)

Hi MasterMartbob,
Congratulations!
Thanks for the code. I am getting multiple emails, because the logic in  verifyStartStop(usage) seems to be a bit convoluted. Either you or I should make sure it works as intended.
Maybe one should be able to decide how often to be sent emails, once idleThreshold is exceeded.
BTW Are there other commands  that we, could use? It would be great if one could retrieve the statistics as well.
Ideally, your code that produces email-alerts should be combined with the other project, namely jamesbarnett91/tplink-energy-monitor. What is the chance of that?
Regards
Giorgio

I fix the probem with the power_mw. The problem was that Revision2.0 of HS110 is using power_mw but revision 1.0 use power. I made the change to support both.
You seem to have an other bug because for me I receive the email one time when it start and one time when it stop. So you are receiving a email every read is that it ? Show me your .env file but remove your email and password.
For the idle yes it is a problem I will fix that so it will be sent only one time or every x amount of time.
We could probably make our own stats and graph them tell me what you would like to see because the other project jamesbarnett91/tplink-energy-monitor was focusing on power consumption and that is not really a concern for me with the pump. So I won't try to merge those two project.
You could look at the api I'm using https://www.npmjs.com/package/tplink-cloud-api if you see other information you would like to leverage.

There you can get latest code the fix for the idleThreshold is there.

Hi MasterMartbob,
Thanks again.
I have not yet tried your newest version.
I know that the pump started during the night, but did not receive any emails.
The terminal window seems to show that the process terminated.
The terminal output includes the following "path: '/?appName=Kasa_Android&termID=aad6…”
I did not think the name Kasa_Android had anything to do with what I am running.
How did this intrude in my running process?
Should I be worried about that?
I have kept the whole file. The same output has appeared more than once.
Sometimes the normal process resumed, but after the last occurrence the process must have stopped totally, hence the next suggestion.
SUGGESTION: if we are going to print to screen the “usage” could we also have a timestamp next to each one?
Also I would find it more useful if the data was all on one line and comma separated.
Instead of {
voltage_mv: 236513,
current_ma: 18,
power_mw: 0,
total_wh: 28,
err_code: 0
}
I would prefer {2020-03-29T11:24:53.240,voltage_mv: 236513,current_ma: 18,power_mw: 0,total_wh: 28,err_code: 0}
As far as receiving multiple email, that has stopped.
As far as the output on the log, we could record the total_wh at the end of each line as follows
[2020-03-29T11:24:53.240] [INFO] monitor - Pump Stopped, # 2, total_wh:28
The #2 in the example line above would be a nice addition to quickly detect how many emails one should have received!
You are correct, Any statistic information could be obtained from the logfile as long as the total_wh is recorded there on each line.
So, upon reflection, there is no real need to merge the two projects.
I hope you don’t mind me making such suggestions. I could implement them, but if possible it would be better to have bit of software that works well for both, rather than creating branches.
Regards
Giorgio Antonelli

On 30 Mar 2020, at 5:56 am, MasterMartbob<EMAIL_ADDRESS>wrote:
I fix the probem with the power_mw. The problem was that Revision2.0 of HS110 is using power_mw but revision 1.0 use power. I made the change to support both.
You seem to have an other bug because for me I receive the email one time when it start and one time when it stop. So you are receiving a email every read is that it ? Show me your .env file but remove your email and password.
For the idle yes it is a problem I will fix that so it will be sent only one time or every x amount of time.
We could probably make our own stats and graph them tell me what you would like to see because the other project jamesbarnett91/tplink-energy-monitor was focusing on power consumption and that is not really a concern for me with the pump. So I won't try to merge those two project.
You could look at the api I'm using https://www.npmjs.com/package/tplink-cloud-api https://www.npmjs.com/package/tplink-cloud-api if you see other information you would like to leverage.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/MasterMartbob/tplink-hs110-pump-monitor/issues/1#issuecomment-605682885, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA7U7ML4IAWLCKITWPTA2BTRJ6KV3ANCNFSM4LVYBEPA.

Yes I have the same problem that the process stop in the middle of the night. I will have to get more information on that before I can fix that.  For the log it should be simple to add your request but Im not sure of the use of adding the total_wh every time pump start or stop. If you want to amke the change I really don't mind just make a pull request afterward and I'll integrate it to the master branch.

I did a modification for the log to be in one line and added the timestamp. I outputed every read in the log file as well so maybe I will have more information when it goes down.

I think I now know why I have sometimes received multiple emails
I suspect I may have multiple apps running, because I may not have terminated one properly before starting another!
I will need to ensure that only one node is running at any one time.


Error status codes cluttering Browser console. Any other solution?

When testing whether a chunk has been uploaded, I have to return HttpStatusCode > 400 etc., in case if the chunk has already been uploaded to server. But this causes my Browser console to have lots of red messages showing request failures.
I am wondering if there is any other way of achieving the same purpose I.e aborting chunk file object on client when such red flag comes from server in response code.
Can I use any other HttpStatusCode that prevents those red messages in Browser console and rather shows regular messages in console?

Have a look at #127 for background, but essentially you can send back any status code from you server and add that to the permanentErrors array. My suggestion would be 204 No Content.

OK. Thanks for replying. I will check it and tell you the feedback.


Linkfix: Adaptive Cards (2021-07)

This PR is the result of running a Link Repair script on the included content. This script is primarily being run to cleanup links to function correctly in Air Gapped Clouds (AGC). Here's a breakdown of what the script that generated the changes in this PR fixes:

docs.microsoft.com Fully Qualified Domain Name (FQDN) Links to either Relative (if in same Repo/DocSet/ContentSet) and Site Relative if not
azure.microsoft.com/documentation/articles that reflect to Docs to either Relative (if in same Repo/DocSet/ContentSet) and Site Relative if not
All known flavors of MSDN/TechNet domains (we know of 8 or 9 now) that reflect to Docs to either Relative (if in same Repo/DocSet/ContentSet) and Site Relative if not

This also includes cleanup of the appended query string for MSDN (redirectedfrom=MSDN).

Fixes articles that are redirected in .openpublishing.redirection.json and updates the link to the current final location (this has a lot of customer usability fixes).

Please note the Contributor Guide: Links has been updated with the following link-type preference order:
By order of preference, links hosted on Docs should be Relative if they are in the same repository and docset. If they are in a different docset, even if in the same repository, they should be Site Relative. Links to content hosted on Docs shouldn't use a complete URL, otherwise known as Fully Qualified Domain Names (FQDN). Using a complete URL from Docs to other content on Docs will cause that link to be non-functional in air-gap environments.

Microsoft Reviewers: Open in CodeFlow

Docs Build status updates of commit e6e1390:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

AdaptiveCards/authoring-cards/universal-action-model.md
:bulb:Suggestion

Details

AdaptiveCards/authoring-cards/universal-action-model.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Hi @v-kents the relative links don't work when I visit them through the "view file" view. Is there a better way to test that the new links would work?

@rahulamlekar If they're in the same repo, they should "just work" Cross-repo ones will 404 as the target location doesn't have the same branch name. If you change the ?branch=pr-en-us-408 to ?branch=master (or main if that's what the repo uses), they will resolve correctly. (as they will also do once merged into master here)

#sign-off (bulk updates to links)


Exchange Account Auto Completion ?!?

I just had a huge WTF moment realizing that Anchor is providing deposit adresses for exchange accounts.

You're right, and those 100% should be chain-specific and that feature shouldn't be bleeding into other chains.
We'll make sure that change gets into the next release.

1.1.0-beta-1 has the fix for this and will be included in the final 1.1.0 release.


Fix Delay#exponential() JavaDoc.

exponential() is capped at 30 seconds and not 30 milliseconds.

Thanks a lot for proposing a pull request to fix #799. The issue was fixed yesterday with f5d5520b8f9280e5aba1ea95a92ae797de89ac8a so I'm closing your pull request without a merge.


[flutter_tool] Don't download CanvasKit if it's already in flutter_web_sdk

Don't download CanvasKit from CIPD if it's already included in the flutter_web_sdk engine artifacts.
We are building CanvasKit locally in the Flutter engine now, and soon will be bundling it with flutter_web_sdk. This change causes flutter_tool to use the built version rather than the one from CIPD when the built version is available.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Going forward, will we still need to support downloading from the canvaskit URL, or is the idea to only use the prebuilt?

The plan is to only use the prebuilt version

It sounds like this is for a soft transition we need to make then? Could you link a bug in the code here with a note that it can all be deleted once the work is completed?

Done. PTAL


Release v1.0.0-rc.4 for notation-go

Release v1.0.0-rc.4 for notation-go:

[ ] Update dependency to use notation-core-go version v1.0.0-rc.3
[ ] Decide on main commit for a release
[ ] Cut branch named v1.0.0-rc.4 based on agreed upon main commit
[ ] Cut a tag named v1.0.0-rc.4

@priteshbandi @patrickzheng200 @JeyJeyGao @shizhMSFT @vaninrao10 @rgnote @gokarnm @iamsamirzon @toddysm @FeynmanZhou

LGTM

Will create new issue once commit is decided


nuGet release

Hey there,
It would be really nice to have a sharpCompress nuGet release, so that people can use it without having to manually get and update the DLL or download the whole source.
Thanks in advance for you help,
Best regards,
-Z440

My bad, all is right with nuget releases, actually.
My project being .NET Framework 3.0 and yours .NET Framework 3.5, the nuget package simply didn't showed up while searching....


Breakout Patient Registration Form into Patient Registration and Patient Health Profile Forms

To improve the clarity and organization of patient data, the existing patient registration form in the CARE system needs to be split into two distinct forms:

Patient Registration Form: This will capture basic patient details.
Patient Health Profile Form: This will capture detailed medical history and health-related information.

Patient Registration Form
Patient Identification/Demographic Details

Phone Number
Name
Father/Husband/Mother/Wife’s Name (new)
Sex
Age
Address (add a short text field for "Landmark")
Emergency Phone Number and Name (new)

Social Profile

Occupation
Ration Card Status
Socio-economic Status (new):

Well off: treatment and food
Middle class: costly treatment - difficult, food - okay
Poor: basic treatment - difficult, food - okay
Very poor: food support needed

The description for socio-economic status options can be shown in the UI as a hint on hover of (i).

Has Domestic Healthcare Support? < No / Yes, family member / Yes, paid caregiver > (new)

Patient Health Profile Form
Medical History

Comorbidities (updated):

Spectrum mentioned above
Stroke
Cancer
Cardiovascular disease
Respiratory diseases
Kidney disease
Gastro-Intestinal disease
Neurological disease
Musculoskeletal
Old age-related issues
Accident/trauma
Autoimmune
Others - text

Presenting Health Condition
Ongoing Medications

Health Profile

Height and Weight (new)
Blood Group
Allergies (Should appear on patient dashboard)
Immunization Records (Should over Hep B, Hep A in addition to COVID)
Wellness Records
Disability Status
Mobility Status (new):

Cannot move at all in bed
Can turn with help in bed
Can turn by self in bed
Needs help to sit up on bed
Can sit up on bed without help
Can stand with help
Can stand without support
Walk with support
Walk without support
Full range of mobility

Use of Assistive Devices:

Air bed
Waterbed
Wheelchair
Walker
Oxygen concentrator
BiPAP
Special Wheelchairs
Electric Wheelchair
Crutches
Adjustable cot
Stool Commode
Backrest
Tripod
Cushions
Oxygen Cylinder
Oxygen Concentrator
BiPAP
CP Chair
DVT Pump
Behind-the-Ear (BTE) Hearing Aid
Hearing aid
Cochlear Implant
Eyeglasses /Contact Lense
Speech-Generating Devices (SGDs)
Voice Amplifier
Footdrop preventive devices

Enteral and Urological Access Devices (new):

Ryle’s tube
Gastrostomy/jejunostomy
PEG
Artificial Stoma (yes/no)
Continuous indwelling catheter
Intermittent Catheterisation
Condom Catheter
Suprapubic Catheter (SPC)
Urostoma

Data Migration:
Migrate all relevant fields from the current patient registration form that pertain to the patient's health profile into this new table.

@vinutv here is the doc https://ohcnetwork.notion.site/The-MVP-for-OP-consultation-3485939968d645e9a8d6baae383bf555

We dont really need a separate table for this right now, we can just keep everything in the same table and use the same API for multiple forms. a PATCH request with the same endpoint will only update what is needed.

@gigincg when is this expected? Dr. Athul needs this to start getting IAPC to actively scale. Please provide some timeline


[FEAT] Allow wildcards in 'include' config option

Is your feature request related to a problem? Please describe.
As of pyprland 2.2.7 it is not possible to import all files within a specific folder.
The setting
[pyprland]
include = ["~/.config/overrides/pyprland/*.toml"]

yields the following error:
2024-04-15 23:46:37,033 [CRITICAL] pypr :: Config file not found! Please create /home/dante/.config/overrides/pyprland/*.toml :: command.py:105

Describe the solution you'd like
Using the config example above, ideally the following happens every time pyprland is starting or the config is reloaded

The wildcard gets resolved into a list of files
The list of files is sorted alphabetically to ensure consistent configuration file import behaviour.
The config files are imported as per order of the list

Possibly it might be required to replace a single entry in the include list by the resolved list of elements, while keeping the total order. E.g in an example:
[pyprland]
include = ["~/.config/overrides/pyprland/*.toml" , "/tmp/ultimate_override.toml"]

yields the following file list
include = [
  "/home/dante/.config/overrides/pyprland/01_first_file.toml",
  "/home/dante/.config/overrides/pyprland/02_second_file.toml",
  "/tmp/ultimate_override.toml"
]

Describe alternatives you've considered
None I can think of.

It may require something like a "glob:" prefix to avoid complexity in case someone has "?" in the filename and don't want to use globbing...
Or something like {globbing: true, path: "/foo/*.toml"} in the list...
Please share your thoughts...

Another idea, maybe the most simple without degrading the feature: ability to pass a folder name, which will be listed searching for .toml files... (sorted alphabetically)

Another idea, maybe the most simple without degrading the feature: ability to pass a folder name, which will be listed searching for .toml files... (sorted alphabetically)

That describes the behavior I am looking for well.

in case someone has "?" in the filename

As far as I understand Linux, the ? character in a filename needs to be masked everywhere, including shells as it already has a special meaning.
Are you pointing to the combination of TOML 'literal string' and the python glob: potentially misbehaving?

Are you pointing to the combination of TOML 'literal string' and the python glob: potentially misbehaving?

Yes, but not only, it's overall complications with the different escaping of "?" to get it to work as a literal or as a regex, it will generally not be armful but I don't like the idea that much, I think I'll go for the folder solution with sounds the most straightforward.

I am using it now, really helps making things easier to organize indeed.
In the main file I have all the most simple plugins defined and listed, plus:
[pyprland]
include = ["~/.config/hypr/pyprland.d"]

Then even plugins can be self-loaded from their own config file, not being in the main plugins array:

Awesome, thanks for implementing!


Add log folds/groups/sections for CI services

Add output when molecule is running in some CI services (Travis, Github Actions, GitLab Pipelines) to make the logs easier to jump through.
This is a follow up to #2851
PR Type

Feature Pull Request

CI Docs:

Travis log folding is explained here, here, and here (CI vars documented here).
Github Action output groups are explained here (CI vars documented here).
GitLab Pipelines collapsible sections are explained here (CI vars documented here).

Screenshots and Tests
Travis CI:

[x] implement based on Travis CI experience as documented in various places.
[x] test/validate molecule with Travis CI. Tested with this job on Travis (nb molecule works just fine in this job, but the job itself failed because the tests haven't been fully ported to molecule 3).
[x] take a screenshot with Travis CI.

Github Actions:

[x] implement based on Github Actions docs.
[x] test/validate molecule with Github Actions. Tested with this job on Github Actions.
[x] take a screenshot with Github Actions.

GitLab Pipelines:

[x] implement based on GitLab Pipelines docs.
[x] test/validate molecule with GitLab Pipelines. Tested with this job on GitLab Pipelines
[x] take a screenshot with GitLab Pipelines.

nb: The title in GitLab has to be all one color, or it ends up with funky output.

Tested on all 3 platforms. I think this is ready to merge.

Tested on all 3 platforms. I think this is ready to merge.

Just noticed a straggler TODO (already done) so I rewrote history and removed it.

@cognifloyd I cannot state how happy I am to see this implemented as I wanted to see it myself for years. Sadly my iterm does not yet support this feature and very few terminals seems to support it.
i am not surprised it became popular on CI systems as doing it in HTML is quite easy.
I will be happy to list this as no1 feature of 3.2 release. Still, I would like to request few changes to prepare it for the future: mainly name the feature collapsable_sections, foldable_sections or similar and avoid naming it and the classes around "CI".
While the current implementation works only with few particular CI systems, it is not something unique to CI and sooner or later will be enabled for terminals too. Make it generic and we enable it when we detect a context that supports it, and do nothing when is not supported.

Following the chain of links:
https://gitlab.freedesktop.org/terminal-wg/specifications/-/issues/3 is a discussion around adding folding to terminal emulator spec (seems unlikely to be accepted based on the primarily negative response)
https://gitlab.freedesktop.org/terminal-wg/specifications/-/issues/4 takes a step back from the presentation (folding) to add semantic markers that could be used by a terminal emulator to add log folding
More description of the propsal in #4 is at http://per.bothner.com/blog/2019/shell-integration-proposal/
So there might be escape sequences at some point that can denote the start/end of output. Terminal emulators might add support for turning that into folding or collapsible sections. Support in CI environments would also need them to support that standardized sequence.
So, maybe I'll call this mark_sections. And I'll divide this into two utility functions:

get_section_marker_style() -> Optional[str] returns the name of the section_marker_style. For now this would be one of travis_ci_fold, github_action_group, gitlab_ci_section, or None.
dispatch_section_markers() very similar to the current implementation.

Or, instead of doing a function, we can actually expand this out into a more extensible command pattern.
from abc import ABC, abstractmethod

class SectionMarker(ABC):
    @classmethod
    @abstractmethod
    def can_handle():
        """"Investigate environment to see if section markers are supported."""

    @abstractmethod
    def start_marker(section_id: str, title: str = None):
        """"Print the start marker. title may include markers and emoji."""

    @abstractmethod
    def end_marker(section_id: str):
        """"Print the end marker."""

This is a lot heavier weight in terms of objects. Do we need to go this far?

I switched the target branch to devel - I'm guessing this is for 3.2 and master is for 3.1?
I'll work on refactoring these in a bit.

@cognifloyd nope. the only branch receiving patches is the default branch (master). All the others are temporary and usually deleted after merge and reused later.

@cognifloyd Look at https://github.com/ansible-community/molecule/pull/2975/files which I created to facilitate your change.


Multisig example that actually uses multiple signatures?

I have been able to use the multisig stuff to interact with the peatio management API which is good.
However I have not had any reason to use multiple signatures and I cannot see any of your examples with multiple signatures either ... eg, you have
generated_jwt = JWT::Multisig.generate_jwt(jwt_payload, { peatio: private_key }, { peatio: "RS256" })
So I was just wondering what was the requirement driving the introduction of the multiple signature JWT?
Can you give me an example that requires more than one signature or point me at one on the web somewhere?
Thanks.

https://stackoverflow.com/questions/50031985/what-is-a-use-case-for-having-multiple-signatures-in-a-jws-that-uses-jws-json-se
"You sign a token with several signature algorithms (let say RS256, ES384 and PS512). epending on the audience capabilities (only supports ES384 algorithm)"
Multiple algorithms sounds more likely than multiple parties signing for a combined token.
When I first saw the multiple signatures in peatio I thought perhaps your intention was for multiple services to sign .. but now I think otherwise.  Please correct me if I'm wrong.


cowsay: 3.8.3 -> 3.8.4

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for cowsay is: Program which generates ASCII pictures of a cow with a message
meta.homepage for cowsay is: https://cowsay.diamonds
meta.changelog for cowsay is: https://github.com/cowsay-org/cowsay/releases/tag/v3.8.4
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 3.8.4 with grep in /nix/store/i7mkmqlh50av8i392m87qx2pqizsx91d-cowsay-3.8.4
found 3.8.4 in filename of file in /nix/store/i7mkmqlh50av8i392m87qx2pqizsx91d-cowsay-3.8.4

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath

cowsay
pokemonsay

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/i7mkmqlh50av8i392m87qx2pqizsx91d-cowsay-3.8.4 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A cowsay https://github.com/r-ryantm/nixpkgs/archive/7a6ffaba3eb99d55142a1a767a9ec02d70e9a0c5.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/7a6ffaba3eb99d55142a1a767a9ec02d70e9a0c5#cowsay

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/i7mkmqlh50av8i392m87qx2pqizsx91d-cowsay-3.8.4
ls -la /nix/store/i7mkmqlh50av8i392m87qx2pqizsx91d-cowsay-3.8.4/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 3 packages built:

cowsay
cowsay.man
pokemonsay

Maintainer pings
cc @rbvermaa @anthonyroussel for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 363543

aarch64-darwin

:white_check_mark: 3 packages built:

cowsay
cowsay.man
pokemonsay


runtime: morestack on gsignal signal: trace/breakpoint trap due to g0 stack misattribution

In rare cases on linux/amd64 race builds we've seen crashes that look like:
fatal: morestack on gsignal

signal: trace/breakpoint trap (core dumped)

The root cause is signal delivery on a sigaltstack allocated very close to the g0 stack. When cgo is enabled, mstart estimates the g0 stack bounds (cgo side), but this is a rough estimate and the g0 stack.lo may actually be beyond the end of the g0 stack.
On signal delivery, adjustSignalStack may then incorrectly determine that the signal was delivered on the g0 stack . Since the overlap is likely to be very close to g0 stack.lo, functions in signal handling have a high probability of "running out of stack space" and calling morestack. Boom.
Here's one example of overlap I captured:
Our SP on sigtrampgo entry: 0x7f99841fe328
sigaltstack from sigcontext: [0x7f99841ef000, 0x7f99841ff000)
g0 stack from gp.m.g0.stack: [0x7f99841fded8, 0x7f99849fdad8)
mstart contains a fudge factor of 1024 to try to address this inaccuracy, but checking against pthread_attr_getstack indicates that the mstart SP is actually 9616 bytes below the top of the stack (that may be off by 1 page (4096), I need to double check. Either way > 1024 bytes).
cc @cherrymui @aclements

There is pthread_attr_getstack which can provide accurate stack bounds. However, I'm not convinced we can use this portably. e.g., glibc's implementation looks like it always succeeds, but NetBSD's appears to be able to return NULL for the stack address.

There is pthread_attr_getstack which can provide accurate stack bounds. However, I'm not convinced we can use this portably. e.g., glibc's implementation looks like it always succeeds, but NetBSD's appears to be able to return NULL for the stack address.

#26061 is related.

#26061 is related.

Shall we do a backport for this? I certainly affects 1.15 and I believe 1.14 as well.

Shall we do a backport for this? I certainly affects 1.15 and I believe 1.14 as well.


Inconsistent colors in the terminal.

Im not sure the technical term for this specific color used in the terminal (i.e. primary, secondary...) but there is a shade of text that is the same as the background color.
This first screenshot is using the regular solarized dark (not themed workbench) and you can see the text.

The second screenshot is using solarized dark (themed workbench) and you can't see the text in the terminal.

As a workaround, I added this to my settings.json:
    "workbench.colorCustomizations": {
        "[Braver's Solarized Dark (themed workbench)]": {
            "terminal.ansiBrightBlack":"#586e75"
        },
    },


Add CPU Adam

Added CPU Adam. For now, fp32 mode has passed the unit test, while the unit test of fp16 mode should be redesigned.

merge to feature.zero not develop?

Hi, is this a duplicate PR of #288 . If so, I will close this PR.


Bug: string tokens are split into individual characters

What type of issues are you dealing with?
Alternate syntax related (likely "Won't Fix")
What happened?
https://github.com/MinecraftCommands/syntax-mcfunction/assets/43310372/9c5c7f0a-a3d6-4afe-a03b-ffcb30c24b9d
Extension version: 0.6.0
Which text editors are you seeing the problem on?
VSCode
Include a code snippet
say "Something" Something

actually, this should be fixed. looking into it

fixed


no --version option

Neither sga-guard nor sga-ssh expose a --version option.  You might find this helpful as you start to get wider usage (right now, if you asked a user "what version of guardian-agent are you running", it's not so easy to get an accurate answer)

Fixed in 93b1ade67fcfa87fb14d505fa7b26844b9eb92ef


Added death screen instigator and death screen damageType

Purpose
Added Death Screen DamageType for any event. Also added DeathScreen instigator for any death where player is killed by other AI or player.
Testing
You can test DamageType by simply falling from a great height. Instigator can be tested by being killed from Skeleton in GooeysQuests.

@Cervator Guess we are back to this branch. Here are the changes I discussed with you earlier

Righto. No time to test tonight, but poking others for any remaining review. We can rebase this clean of some of the silly commits :-)
Oh, also:
@GooeyHub: ok to test

Hooray Jenkins reported success with all tests good!

Rebasing would be great.

@VaibhavBajaj : I took a look at this and I have a few suggestions if you're open:

Didn't you mention that you were going to add the instigator as well? This could be done in a similar way to how the damage type is retrieved, just add an additional label and store the data using event.getInstigator() instead. In fact, you could even provide information what tool caused the damage using event.getDirectCause(), which might be useful if players get killed with a item like a special sword.
You seem to have added .iml files, which shouldn't be have added since they're in the default TS .gitignore. You might want to consider updating your local .gitignore with the one from the main repo.
Since you have decided to go with the DoDamageEvent approach, you can revert all the changes made to the other files from the previous approach like CharacterComponent, ClientInfoComponent and HealthAuthoritySystem.

🙂

@VaibhavBajaj : Any updates on this one? I could just submit a separate PR putting some changes on top of this one if you're a little busy. This is one of the simpler PRs which could probably be merged soon 🙂.

@iojw I completely forgot about this one :P. I would be able to wrap this up today or sometime tomorrow unless you have already done so.

@iojw Hey, if you want to go ahead with deathScreen modifications, by all means go ahead. I have confirmed I will have free time tomorrow but my Mid Term 3 is coming up day after and I will have to prep for that. If you could wait till Saturday, I would be able to wrap it up else please go ahead. If you face any questions with parts of code, you can ping me on webchat or more preferably comment on the PR since then I am sent an email and I check my emails.

@VaibhavBajaj No problem there's no hurry at all. I was just pinging you as I thought you might have missed it.

@VaibhavBajaj & @iojw - either of you have a moment to finish this one off so we can merge it? :-)

@cervator: A bit swarmed at the moment, will finish this up soon!

@iojw no problem at all! :-)

@iojw @VaibhavBajaj
What's the relation between this and #2809?
I know iojw is working on the other pull, so what's happening with this one? Is it to be merged with iojw's?

@jellysnake This can be closed when #2809 is merged. The commits with this one are a little messed up, so I cleaned them up in another PR.

Closed via #2809 and also thanks to @VaibhavBajaj for the initial work 👍


REST-API-Style conventions need to be followed

See http://localhost:4000/decisions/conventions-for-rest-uris.html

Every team DONE!


Add package_index.template generation

I've removed armv7 binaries since the other tools are not supporting this architecture.
I've added the prerelease check and added the automatic generation and upload of the package_index.template

Test release here


Support Dark Mode

Changes the button classes to the ones used in sidekiq.
fixes #260

Coverage decreased (-0.2%) to 91.272% when pulling 8c05cea17bd8e1eb4bb752d0b330617d403e6ed7 on Atrox:master into 7ca90f95f1f8776e84546e69d82f7f6ab1b31233 on ondrejbartas:master.

Poke @ondrejbartas / @Atrox

Hello @Atrox could you please rebase from master 🙏🏼?
ℹ The Slim templates has been removed

Thanks for the update @Atrox 🙌🏼 seems fine to me! ✅
@CHTJonas do you mind to make quick test again? we'd like to include this in the next release.


Styles endpoint integration

I've chosen GitHub + TravisCI instead of zeit - imho it's simpler, more flexible and transparent. See https://github.com/MartinKavik/html-css-db.

Nice!


KnownArgumentNames validation rule

Pull Request Test Coverage Report for Build 448

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 80.3%

Totals

Change from base Build 444:
0.0%

Covered Lines:
2250

Relevant Lines:
2802

💛  - Coveralls

@crisu83 please rebase instead of merging master, it makes the diff much easier to read

@Jalle19 The error message for Syntax error is taken from the reference impl.


envoy.reloadable_features.grpc_bridge_stats_disabled deprecation

Your change #16284 (grpc: block stat collection in grpc bridge filter with runtime) introduced a runtime guarded feature. It has been 6 months since the new code has been exercised by default, so it's time to remove the old code path. This issue tracks source code cleanup so we don't forget.

Hi, I have done it.
#19627


Add Python 3.6 to build matrix

Codecov Report

Merging #59 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #59   +/-   ##
=======================================
  Coverage   81.81%   81.81%
=======================================
  Files          12       12
  Lines         407      407
  Branches       51       51
=======================================
  Hits          333      333
  Misses         53       53
  Partials       21       21

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e07a7b7...afdf945. Read the comment docs.


Dynamically append and remove a node.

I want to append and remove a node to tree.

Is there an approach you had in mind for removing a node?  The only way I can think of removing a node (from the actual node itself, i.e. a delete button on the node itself) out of the box is emit an event with the node to the containing controller and then walk the tree data and remove it from there.  It seems less than ideal, is there another mechanism that would allow that kind of thing?

what would you imagine the tree doing?
On Wed, Jun 24, 2015 at 11:50 PM, Jake Buob<EMAIL_ADDRESS>wrote:

Is there an approach you had in mind for removing a node? The only way I
can think of removing a node (from the actual node itself, i.e. a delete
button on the node itself) out of the box is emit an event with the node to
the containing controller and then walk the tree data and remove it from
there. It seems less than ideal, is there another mechanism that would
allow that kind of thing?
—
Reply to this email directly or view it on GitHub
https://github.com/wix/angular-tree-control/issues/42#issuecomment-115008639
.

I didn't know if there was something in place for a node to have knowledge of its parent so it could send the parent with the event and the directive could remove the node from the parent's children, or if there was an event already that a node could fire to its parent to remove itself.  If either of those options sound interesting, I could submit a PR.

Any insight into this @yoavaa? I'm interested in doing the same thing that @buob is describing. I have a button next to each node which intends to remove said node from the tree, but to actually repaint the tree requires somehow walking the treeModel to find this node and removing it. Unless of course we're exposed the path to the current node somehow. It seems like there could / should be an easier way to do this.

in another issue we have a discussion on getting, for a node, the path of parents to the root (or rather, the path to a node). While this is possible, it is not trivial and I am not sure about the API. It has to be a function that we can expose similar to the other tree label template variables (e.g. http://wix.github.io/angular-tree-control/#labels-template and http://wix.github.io/angular-tree-control/#events).
Do you think adding a $parents which is a function returning an array of nodes will help?

@yoavaa That should definitely help. I too have a usecase that requires deleting nodes!

@buob @sethkrasnianski Did you guys manage to find a workaround for this?

@paambaati what is the usecase?
If it is that when a node is clicked you want to remove it, you can use the $parentNode parameter you get in events. With it you can get the parent node of the clicked node and remove it from the parent.

I think we were using a version before $parentNode was available, so we ended up just storing parentNode on each node ourselves before sending it to tree control and removing it that way.

I am updating my treeModel by splicing children OUT of the structure. Although the tree model updates as expected, the tree's transcludeScope goes out of synch with the new data structure.
The result is that the tree's label continues to display the removed node's data even while the scope's node property is properly updated.
Am I missing something necessary in order to successfully remove nodes?

Just an update to my prior question:
I discovered transcludeScopes for removed nodes remain synchronized with treeModel updates whenever NOT using the custom template option.


Spot checks for delayed chipper startup

See https://github.com/phetsims/chipper/issues/764 and https://github.com/phetsims/tasks/issues/1002 for background information.
I've dev-deployed https://phet-dev.colorado.edu/html/charges-and-fields/1.1.0-dev.7 with the patch for those issues, which will delay the sim require.js startup until suitable conditions (i.e. iframe that isn't hidden) exist.
Some example HTML (can be saved as a file and viewed in a browser) that can help trigger the issue is:
<!DOCTYPE html>
<html>
  <head>
    <meta charset="UTF-8">
    <title>Hidden Sim test</title>
  </head>
  <body>

  <div hidden id="container">
    <iframe width="800" height="600" src="https://phet-dev.colorado.edu/html/charges-and-fields/1.1.0-dev.7/phet/charges-and-fields_en_phet.html" id="iframe" allowfullscreen scrolling="no" title="Some Title"></iframe>
  </div>

  <button id="testButton">Toggle Hidden</button>

  </body>

  <script type="text/javascript">
    const container = document.getElementById( 'container' );
    const button = document.getElementById( 'testButton' );
    button.addEventListener( 'click', ( event ) => {
      if ( container.hidden ) {
        container.removeAttribute( 'hidden' );
      }
      else {
        container.hidden = true;
      }
    } );
  </script>
</html>

I'd recommend trying out the phet and phet-io brand files in multiple configurations (LoL, anywhere iframes are concerned, and particularly any place the sim may be hidden) to see if this breaks anything.
I'd also appreciate some cross-browser testing to ensure that this won't break on any of our supported platforms.
@ariel-phet, anything else you think should be tested for this change?

@KatieWoe I think this would be good to basically test on all supported platforms and in the ways @jonathanolson mentions above. High priority for the moment since not much in the testing queue, but will get bumped down if other things come up.

Additionally, the above HTML is now at the link https://phet-dev.colorado.edu/olsonjb/hidden-test.html, so I'd like that tested on all platforms if possible.

Testing Platforms

[ ] iOS 11 + Safari
[ ] iOS 12 + Safari

[ ] macOS 10.10 + Safari
[ ] macOS 10.11 + Safari
[ ] macOS 10.11 + Chrome
[ ] macOS 10.12 + Safari
[ ] macOS 10.12 + Chrome
[ ] macOS 10.13 + Safari
[ ] macOS 10.13 + Chrome
[ ] macOS 10.14 + Safari
[ ] macOS 10.14 + Chrome

[ ] Win7 + IE
[ ] Win7 + Chrome
[ ] Win7 + FF

[ ] Win10 + Edge
[ ] Win10 + Chrome
[ ] Win10 + FF

[ ] ChromeOS

Test the following items:

https://phet-dev.colorado.edu/html/charges-and-fields/1.1.0-dev.7/phet/charges-and-fields_all_phet.html
https://phet-dev.colorado.edu/html/charges-and-fields/1.1.0-dev.7/phet/charges-and-fields_all_iframe_phet.html
https://phet-dev.colorado.edu/html/charges-and-fields/1.1.0-dev.7/phet/xhtml/charges-and-fields_all.xhtml
https://phet-dev.colorado.edu/olsonjb/hidden-test.html
https://developers.legendsoflearning.com/public-harness/index.html?startPayload={"languageCode"%3A"en"}&url=https%3A%2F%2Fphet-dev.colorado.edu%2Fhtml%2Fcharges-and-fields%2F1.1.0-dev.7%2Fphet%2Fcharges-and-fields_all_phet.html%3FlegendsOfLearning

@jonathanolson the hidden/unhidden html doesn't seem to load (nothing on the progress bar) on Win 10 firefox.

Sim looks fine on the hidden/unhidden page of iOS 12 safari.  But the page can be scrolled up and down.
https://drive.google.com/file/d/1gCA2uQmrh6Kgs_-WjOnG5dC7XXqQRgYK/view?usp=sharing

https://phet-dev.colorado.edu/olsonjb/hidden-test.html not working on Win7 + IE.

Safari 10.1.2 on Mac 10.10.5 won't show the sim when the hidden button is clicked much like in Edge.
Error:
SntaxError: Can't create duplicate variable that shadows a global property: 'container'
N (anonymous function)

QA is done.  Let me know if the comments above should be issues and where they should go.

Thanks!


[SPARK-38517][INFRA] Fix PySpark documentation generation (missing ipython_genutils)

What changes were proposed in this pull request?
Currently, Python documentation build fails as below:
Extension error:
Could not import extension nbsphinx (exception: No module named 'ipython_genutils')
make: *** [Makefile:35: html] Error 2
                    ------------------------------------------------
      Jekyll 4.2.1   Please append `--trace` to the `build` command
                     for any additional information or backtrace.
                    ------------------------------------------------
/__w/spark/spark/docs/_plugins/copy_api_dirs.rb:130:in `<top (required)>': Python doc generation failed (RuntimeError)
	from /__w/spark/spark/docs/.local_ruby_bundle/ruby/2.7.0/gems/jekyll-4.2.1/lib/jekyll/external.rb:60:in `require'
	from /__w/spark/spark/docs/.local_ruby_bundle/ruby/2.7.0/gems/jekyll-4.2.1/lib/jekyll/external.rb:60:in `block in require_with_graceful_fail'
	from /__w/spark/spark/docs/.local_ruby_bundle/ruby/2.7.0/gems/jekyll-4.2.1/lib/jekyll/external.rb:57:in `each'
	from /__w/spark/spark/docs/.local_ruby_bundle/ruby/2.7.0/gems/jekyll-4.2.1/lib/jekyll/external.rb:57:in `require_with_graceful_fail'
	from /__w/spark/spark/docs/.local_ruby_bundle/ruby/2.7.0/gems/jekyll-4.2.1/lib/jekyll/plugin_manager.rb:89:in `block in require_plugin_files'
	from /__w/spark/spark/docs/.local_ruby_bundle/ruby/2.7.0/gems/jekyll-4.2.1/lib/jekyll/plugin_manager.rb:87:in `each'
	from /__w/spark/spark/docs/.local_ruby_bundle/ruby/2.7.0/gems/jekyll-4.2.1/lib/jekyll/plugin_manager.rb:87:in `require_plugin_files'
	from /__w/spark/spark/docs/.local_ruby_bundle/ruby/2.7.0/gems/jekyll-4.2.1/lib/jekyll/plugin_manager.rb:21:in `conscientious_require'
	from /__w/spark/spark/docs/.local_ruby_bundle/ruby/2.7.0/gems/jekyll-4.2.1/lib/jekyll/site.rb:131:in `setup'

https://github.com/apache/spark/runs/5504729423?check_suite_focus=true
This PR proposes to simply install ipython_genutils to fix up the build for now.
Why are the changes needed?
To fix the broken build.
Does this PR introduce any user-facing change?
No, deb-only.
How was this patch tested?
CI in this PR should test it out.

Im gonna merge this in to unblock other PRs.


Sap

Required items, please complete
Change(s):

See guidance below

Reason for Change(s):

See guidance below

Version Updated:

Required only for Detections/Analytic Rule templates
See guidance below

Testing Completed:

See guidance below

Checked that the validations are passing and have addressed any issues that are present:

See guidance below

Guidance <- remove section before submitting

Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:
Thank you for your contribution to the Microsoft Sentinel Github repo.

Details of the code changes in your submitted PR.  Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process.  Providing associated Issues that this resolves also easily connects the reason.

Change(s):

Updated syntax for XYZ.yaml

Reason for Change(s):

New schema used for XYZ.yaml
Resolves ISSUE #1234

Version updated:

Yes
Detections/Analytic Rule templates are required to have the version updated

The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly.  If your submission requires a custom parser or function, it must be submitted with the PR.

Testing Completed:

Yes/No/Need Help

Note: If updating a detection, you must update the version field.

Before the submission has been made, please look at running the KQL and Yaml Validation Checks locally.
https://github.com/Azure/Azure-Sentinel#run-kql-validation-locally

Checked that the validations are passing and have addressed any issues that are present:

Yes/No/Need Help

Note: Let us know if you have tried fixing the validation error and need help.

References:

Guidance for Detection checks
General contribution guidance
PR validation troubleshooting

Hi @oferInbar,
I will review and share the update meanwhile can you please fix validation failures.
Thanks

Hi @aprakash13,
Can you please review the analytic rules and share your feedback.
Thanks

@aprakash13 , @v-mchatla  please note that the schema validation and KQL tests are expected to fail as we have workspace functions used and these always fail.
if this is the only issue please consider approving the PR.
thanks!

Hi @aprakash13,
Can you please review the analytic rules and share your feedback.
Thanks

Hi @v-vdixit,
Can you please review the content and share your feedback.
Thanks

Hi @v-vdixit,
I hope you have started working on it. Can you please share your feedback once done with the review.
Thanks

Hi @v-vdixit, please share your feedback accordingly.
Thanks

Hi @devikamehra
Can you please review the detections and share your thoughts.
@v-vdixit - share your feedback on other content.
Thanks

Hi @v-mchatla @oferInbar all content except analytic rules and functions looks good to me, Thanks!

@v-vdixit what's wrong with the functions?

@oferInbar Functions are being checked by @v-mchatla, we will update you soon. Thanks!


Cannot find file 'ReactRefreshEntry.js'

Describe the bug
I have a monorepo that uses lerna, I have 3 projects, one api and two frontends, both frontends uses react and presents the same exact error, this error
marketplace: multi C:/Users/userName/programacion/A<EMAIL_ADDRESS>C:/Users/userName/programacion/A Trabajo/readl/node_modules/react-dev-utils/webpackHotDevClient.js ./src/index.jsx marketplace: Cannot find file: 'ReactRefreshEntry.js' does not match the corresponding name on disk: 'C:\Users\UserName\programacion\A Trabajo\readl\node_modules\@pmmmwh\react-refresh-webpack-plugin\client\A trabajo'.
I have already tried to reinstall all the project, update the dependencies, creating the folder inside @pmmmwh\react-refresh-webpack-plugin\client where the file is not found and copy and paste the files there, also tried to update, desactivate, uninstall the react devtools as recomended in issue #10242 , #9893 , #9922 , and #10500
Did you try recovering your dependencies?

Yes, version of yarn 1.22.5
Environment

I'm using yarn not npm
Environment Info:    current version of create-react-app: 4.0.3   running from C:\Users\userName\AppData\Roaming\npm\node_modules\create-react-app    System:     OS: Windows 10 10.0.19042     CPU: (4) x64 Intel(R) Core(TM) i3-7020U CPU @ 2.30GHz   Binaries:     Node: 14.15.1 - C:\Program Files\nodejs\node.EXE     Yarn: 1.22.5 - C:\Program Files (x86)\Yarn\bin\yarn.CMD     npm: 7.20.1 - C:\Program Files\nodejs\npm.CMD   Browsers:     Chrome: Not Found     Edge: Spartan (44.19041.1266.0), Chromium (96.0.1054.62)     Internet Explorer: 11.0.19041.1202
npmPackages:     react:  17.0.2     react-dom:  17.0.2     react-scripts:  4.0.3   npmGlobalPackages:     create-react-app: Not Found  npm notice npm notice New major version of npm available! 7.20.1 -> 8.3.0 npm notice Changelog: https://github.com/npm/cli/releases/tag/v8.3.0 npm notice Run npm install -g<EMAIL_ADDRESS>to update! npm notice
Steps to reproduce

I can't really reproduce the issue in other projects, but, heres how i do it in mine
1.yarn install
2.lerna bootstrap
3.yarn start
Expected behavior

the project start without errors
Actual behavior

marketplace: multi C:/Users/userName/programacion/A<EMAIL_ADDRESS>C:/Users/userName/programacion/A Trabajo/readl/node_modules/react-dev-utils/webpackHotDevClient.js ./src/index.jsx
marketplace: Cannot find file: 'ReactRefreshEntry.js' does not match the corresponding name on disk: 'C:\Users\UserName\programacion\A Trabajo\readl\node_modules@pmmmwh\react-refresh-webpack-plugin\client\A trabajo'.

Issue solved, the problem was the name of the folder that contains the project folder


The following directories listed in your path were found to be non-existent [WSL2]

Following https://github.com/tloen/alpaca-lora
When I attempt to run the finetuning code from it
===================================BUG REPORT===================================
Welcome to bitsandbytes. For bug reports, please submit your error trace to: https://github.com/TimDettmers/bitsandbytes/issues
================================================================================
/home/USERNAME/.local/lib/python3.10/site-packages/bitsandbytes/cuda_setup/main.py:136: UserWarning: WARNING: The following directories listed in your path were found to be non-existent: {PosixPath('/home/USERNAME/.conda/envs/textgen/lib')}
warn(msg)
/home/USERNAME/.local/lib/python3.10/site-packages/bitsandbytes/cuda_setup/main.py:136: UserWarning: /home/USERNAME/.conda/envs/textgen did not contain libcudart.so as expected! Searching further paths...
warn(msg)
/home/USERNAME/.local/lib/python3.10/site-packages/bitsandbytes/cuda_setup/main.py:136: UserWarning: WARNING: The following directories listed in your path were found to be non-existent: {PosixPath('unix')}
warn(msg)
CUDA_SETUP: WARNING! libcudart.so not found in any environmental path. Searching /usr/local/cuda/lib64...
CUDA SETUP: WARNING! libcuda.so not found! Do you have a CUDA driver installed?
CUDA SETUP: CUDA runtime path found: /usr/local/cuda/lib64/libcudart.so
/home/USERNAME/.local/lib/python3.10/site-packages/bitsandbytes/cuda_setup/main.py:136: UserWarning: WARNING: No GPU detected! Check your CUDA paths. Proceeding to load CPU-only library...
warn(msg)
CUDA SETUP: Loading binary /home/USERNAME/.local/lib/python3.10/site-packages/bitsandbytes/libbitsandbytes_cpu.so...
/home/USERNAME/.local/lib/python3.10/site-packages/bitsandbytes/cextension.py:31: UserWarning: The installed version of bitsandbytes was compiled without GPU support. 8-bit optimizers and GPU quantization are unavailable.
warn("The installed version of bitsandbytes was compiled without GPU support. "
CUDA seems to be working as I followed nvidia's installation instructions and ran the sample program listed here https://ubuntu.com/tutorials/enabling-gpu-acceleration-on-ubuntu-on-wsl2-with-the-nvidia-cuda-platform#4-compile-a-sample-application
My card showed up as expected in the sample test so I would assume CUDA is working (version 12.1 was listed)

I am having a very similar issue, using WSL2.
/home/USERNAME/kohya_ss/venv/lib/python3.10/site-packages/bitsandbytes/cuda_setup/paths.py:27: UserWarning: WARNING: The following directories listed in your path were found to be non-existent: {PosixPath('/home/USERNAME/kohya_ss/venv/lib/python3.10/site-packages/cv2/../../lib64')}
warn(
/home/USERNAME/kohya_ss/venv/lib/python3.10/site-packages/bitsandbytes/cuda_setup/paths.py:105: UserWarning: /home/USERNAME/kohya_ss/venv/lib/python3.10/site-packages/cv2/../../lib64: did not contain libcudart.so as expected! Searching further paths...
warn(
/home/USERNAME/kohya_ss/venv/lib/python3.10/site-packages/bitsandbytes/cuda_setup/paths.py:27: UserWarning: WARNING: The following directories listed in your path were found to be non-existent: {PosixPath('unix')}
warn(
CUDA_SETUP: WARNING! libcudart.so not found in any environmental path. Searching /usr/local/cuda/lib64...
CUDA SETUP: CUDA runtime path found: /usr/local/cuda/lib64/libcudart.so
CUDA SETUP: WARNING! libcuda.so not found! Do you have a CUDA driver installed?
CUDA is installed and works just fine with my Stable Diffusion install.

Looks like it's because of an issue with either WSL2 or Nvidia's CUDA installer.  https://github.com/microsoft/WSL/issues/5663
I was able to fix it by making a softlink.
sudo ln -s /usr/lib/wsl/lib/libcuda.so /usr/local/cuda/lib64/libcuda.so


Blank Screen

Hi, i know currently exist multiple issues with this topic, but this issue ( as #106) its my own opinion while i build my custom navigation library using react-router, i testing and render many forms and methods to render the stack.
Example Stack and navigation:

Go forward:
1)Login > 2)Register > 3)Terms And Conditions = OK

Go back:
ERROR: Blank screen! = 1)Login < 2)Register < 3)Terms And Conditions
(I used back button of native NavBar with Header Config Component)

With Error (Blank Screen)

Fixed:

To take into account

When 2)Register screen have stackAnimation="none" this fix the error :)

if in onDismissed callback delayed goBack to prevent re-render or dispatch new state while transtioning or animated screen.

Posible javascript Solution for bare projects
  // when screen dismissed (onDismissed callback)
  const onDismissed = async (ctx: ContextDismissAppear) => {
    setTimeout(()=>goBack(),1000);
  };

Posible javascript Solution for Expo projects - (No testing) - check createNativeStackNavigator and add setTimeout in onDismissed callback

Posible solution in native platform?

Thanks, Sorry my english
Environment
react-router-native: 5.1.2,
react-native: 0.61.5
react-native-screens: 2.0.0-beta.2
Device info : iOS

@punisher97 i have tried in IOS and it didn't works.

@punisher97 i have tried in IOS and it didn't works.

@appify-waheed Hi, you can setting stackAnimation="none" in previous screen?, in my example it's Register

@punisher97 same after passing
stackAnimation="none"
may be i have some other issue.

I replace native back button with custom back, thanks


Question about FPS in inference

Hi there again. I want to ask a bit about the inference speed of the model in scene reconstruction (image to voxels). Have your team measured this? Currently in the codebase i'm seeing 3 different stages for inferencing (image2noveldepth, noveldepth2tsdf, tsdf2voxel), I am very curious about this. Hope to hear from you soon.

Hello @haiphamcse, I haven't calculated the frames per second (FPS) yet, but the inference time is primarily influenced by the number of views you'd like to generate. Each view typically requires about 2 seconds for generation. Additionally, the tsdf fusion process also scales linearly with the number of views.
However, the inference time can be significantly reduced by directly extracting the occupancy from the density volume, similar to the approach demonstrated in BTS paper: https://fwmb.github.io/bts/"

Hi there, thank you for your reply. Have the team done any test on the way to extract the occupancy out other than the TSDF fusion of novel views yet? To my best knowledge, to obtain the results in the paper 13.84 IoU we need to generate a lot of novel depth (~30 frames), it is neccessary or a smaller amount of frames will still give comparable results

Hello @haiphamcse, I haven't experimented with obtaining the occupancy directly from the density field. In the case of SemKITTI, rotating views (angle != 0) only yielded marginal improvements, likely because the dataset mostly consists of front-facing images. I remembered sampling only 10 views with an angle of 0 and an interval of 1 meter also give roughly the same performance."

Thank you for your reply. I will close the issue now.


Remove jQuery Hotkeys dependency

@steveathon currently we already require users to have jQuery as part of their site. What are your thoughts on removing the jQuery Hotkeys dependency and having our own implementation? This only takes up one method at the moment so we should be able to do it without affecting the rest of the code.

I'm happy to look at options where we can reduce dependency sizes and drop the overall project size down. What did you have in mind?

As far as I know the only dependencies we have are jQuery Hotkeys and jQuery. I've looked over the jQuery Hotkeys source and I don't think it would be hard for us to create our own implementation in pure JavaScript. Also we're using very little of the jQuery library. We're mostly just using the selector and a few functions like addClass all of which can be done in pure JavaScript.
Not only would removing both of these would make it easier on our users since we'd have no dependencies but we'd also greatly reduce our file size. Depending on how much you wanted to do on #3 this might be all we need to do to solve that.
I also want to throw out there the option of leaving our own hotkey implementation out and make it an official plugin later on. That would also reduce our file size as the Hotkeys implementation would only be added if the user added it.

I agree that this would be helpful. As of now, users may have difficulty locating the proper jquery.hotkeys script.
I was able to use: https://github.com/jeresig/jquery.hotkeys/blob/master/jquery.hotkeys.js - Can I get verification that this is in fact the correct version of jquery.hotkeys we should be using?
But other versions of a script named the same exist as well; the few of these I tried did not work properly with bootstrap-wysiwyg.
I could not seem

https://gist.github.com/ppbntl19/455f68af728382e001070d9cced0c70e
Support for a simple toolbar  without using  Font-awesome and jQuery Hotkeys .

@ppbntl19 I haven't had a chance to try/delve into your code. I see you didn't remove references to the actual hotkeys under default options. Does that mean hotkeys still work without the jQuery Hotkeys dependency? Or you just disabled the requirement and left that legacy code in there?