Fix variable and method name collisions in Enlight_Hook_HookArgs and generated hook proxy classes

Note: This PR fixes a critical bug that was introduced in c4b22d8bed975713c99160550beaeb17b8311bbb. Even though it was only merged into the 5.5 branch and hence was not released yet, this PR should be treated with high priority.
TL;DR This PR fixes several issues in generated hook proxy classes as well as the Enlight_Hook_HookArgs class, which resulted in both weird behaviour and fatal errors when using specific names for methods or names for arguments of hookable methods.
Sorry for the long explanation. It's a quite complicated issue and impossible to explain how it arises from the code in only a few sentences.
1. Why is this change necessary?
Currently using any of the following argument names when declaring methods that are made hookable by implementing the Enlight_Hook interface in the respective class result in various errors:

$method
$context
$hookManager
$class

The values of any arguments using one of these names would be either overwritten by the generated proxy class or overwrite all or parts of the context required to execute the hook correctly. Consider this simple class:
class MyHookableClass implements \Enlight_Hook
{
    public function hookableMethod($context, $hookManager)
    {
        echo get_class($context) . "\n";
        echo get_class($hookManager) . "\n";
    }
}

When adding a hook to MyHookableClass::hookableMethod() and calling it, e.g. $instance->hookableMethod(new \DateTime(), new \DateTime()), the values of $context and $hookManager are overwritten before the method or any hook is called. Hence the output is
Enlight_Hook_HookExecutionContext
Enlight_Hook_HookManager

instead of the expected
DateTime
DateTime

Having a hookable method that uses the argument names $class and/or $method even results in a fatal error, because they corrupt the created Enlight_Hook_HookArgs:
class MySecondHookableClass implements \Enlight_Hook
{
    public function hookableMethod($class, $method)
    {
    }
}

When adding a hook to MySecondHookableClass::hookableMethod() and calling it, e.g. $instance->hookableMethod('class', 'method'), we get a fatal error:
PHP Fatal error:  Uncaught Error: Call to a member function __pushHookExecutionContext() on string

Furthermore the following method names can effectively not be delcared by classes implementing Enlight_Hook, because that interface reserves their usage for purposes internal to the hook execution and the generated proxy class just overrides any original implementation (without calling the parent):

getHookMethods()
executeParent()
pushHookExecutionContext()
popHookExecutionContext()
getCurrentHookProxyExecutionContext()
getActiveHookManager()
executeOriginalMethod()

The first two methods getHookMethods() and executeParent() have always been declared in Enlight_Hook, the other five methods were added to the interface by #1501 (via c4b22d8bed975713c99160550beaeb17b8311bbb). This behaviour adds constraints on how a hookable class can be implemented, by preventing the class from declaring methods using the listed names.
The following write up explains the different problems in detail.
1.1. $method, $context and $hookManager and reserved methods
In #1501 I rewrote the execution of hooked methods to add a predictable execution model of replace hooks. A generated proxy class extends the original class and overrides all hooked methods. Additional helper methods defined in Enlight_Hook_Proxy are added to the proxy class to make the execution and tracking of the hook possible. This creates two problems:

When overriding a hooked method, the new implementation declares three helper variables $method, $context and $hookManager before calling executeHook() on the latter:
https://github.com/shopware/shopware/blob/b59e9ef936d3aee47fbb4281a82ef9aecea03001/engine/Library/Enlight/Hook/ProxyFactory.php#L354-L362
If any of the method arguments use any of the names $method, $context and $hookManager, their values will be overwritten before being used to execute the overridden method. This is actually a critical bug that was introduced in c4b22d8bed975713c99160550beaeb17b8311bbb and needs fixing before release.

Adding helper methods to the proxy class reserves their names and effectively prevents any hookable classes from using those method names themselves, because the original implementation will always be overridden. Its highly unlikely that the new method names added to the Enlight_Hook_Proxy interface will ever by used by a hookable class. However, the hook system should not dictate which method names can be used in a hookable class and which don't.

1.2. $class (and $method, again)
While investigating the described behvaiour, I found that the argument names $class and $method have actually never worked correctly since the existence of hook proxies in Shopware. That is due to how Enlight_Hook_HookArgs handles the special arguments 'class' (the hook subject, i.e. the instance of a hooked class which the hooks are being executed on) and 'method' (the name of the hooked method whose hooks are being executed).
Prior to this PR, the inherited constructor of Enlight_Hook_HookArgs expected a single array containing both the subject and method of the hook execution as well as all method arguments that were passed to the hooked method, all wrapped in a single associative array:
https://github.com/shopware/shopware/blob/b59e9ef936d3aee47fbb4281a82ef9aecea03001/engine/Library/Enlight/Event/EventArgs.php#L52-L61
When creating the hook args, subject and method were added to an array using the keys 'class' and 'method', respectively. That array was then merged with the associative array containing all method arguments using array_merge():
https://github.com/shopware/shopware/blob/b59e9ef936d3aee47fbb4281a82ef9aecea03001/engine/Library/Enlight/Hook/HookExecutionContext.php#L76-L82
Internally Enlight_Hook_HookArgs then used the special keys 'class' and 'method' when calling Enlight_Hook_HookArgs::getSubject() or Enlight_Hook_HookArgs::getMethod() to the return the hook subject or method, respectively:
https://github.com/shopware/shopware/blob/b59e9ef936d3aee47fbb4281a82ef9aecea03001/engine/Library/Enlight/Hook/HookArgs.php#L37-L54
To prevent these two special arguments from being returned when calling Enlight_Hook_HookArgs::getArgs(), the first two elements of the internal _elements were sliced off (associative PHP arrays are still ordered by the order in which the elements were added):
https://github.com/shopware/shopware/blob/b59e9ef936d3aee47fbb4281a82ef9aecea03001/engine/Library/Enlight/Hook/HookArgs.php#L56-L63
All this becomes a problem as soon as any definition of a hookable method uses the argument names $class and/or $method. When generating the respective proxy class, the method arguments are collected and wrapped in an associative array, using the argument names as keys for the respective argument values. Merging such an arguments array on to the array containing the special 'class' and 'method' elements overwrites the existing values of 'class' and/or 'method'. For example:
<?php
class MyHookedClass
{
    public function anyHookedMethod($class, $method, $someOtherArgument)
    {
    }
}

$specialVariables = [
    'class' => new MyHookedClass(),
    'method' => 'anyHookedMethod',
];
$methodArgs = [
    'class' => '5A',
    'method' => 'strtolower',
    'someOtherArgument' => 'whatever',
];

$mergedArgs = array_merge($specialVariables, $methodArgs);
var_dump($mergedArgs);

Output:
array(3) {
    'class' =>
    string(2) "5A"
    'method' =>
    string(10) "strtolower"
    'someOtherArgument' =>
    string(8) "whatever"
}

Both the values of 'class' and 'method' were overwritten by the values passed to the hooked methods. Hence the whole hook execution context is gone and calling getSubject() or getMethod() on the hook args now return 5A and strtolower, respectively.
The fact that this breaks the exection of the hook and results in a fatal error is probably the reason why no hookable method has ever used $class nor $method as argument names. However, just like described in 1.1., a generated proxy class should not impose any limitations on how the hookable class is designed.
2. What does this change do, exactly?
This PR fixes all issues described in 1. by changing the following:

1.1. Name collisions:

The generated implementation of overridden, hooked methods in the proxy class is changed to not declare/overwrite any variables.
All methods added to the Enlight_Hook_Proxy interface by PR #1501 (c4b22d8bed975713c99160550beaeb17b8311bbb) are prefixed with __ to prevent collisions with original methods declared in the extended, hookable classes.
All property names of the generated proxy class are prefixed with __ to prevent collisions with original properties declared in the extended, hookable class.

1.2. Special hook args:

Enlight_Hook_HookArgs now has two dedicated properties $_subject and $_method for the values previously stored in the special 'class' and 'method' args, respectively, instead of using the args array (partly breaking).

Please note that the changes necessary to fix 1.2. are partly breaking, because it is no longer possible to get the hook subject by calling $args->get('class') or the hooked method's name by calling $args->get('method'). However, the existing methods Enlight_Hook_HookArgs::getSubject() and Enlight_Hook_HookArgs::getMethod() still work as before. Hence I consider this as partly breaking, because IMO the correct way to retrieve the subject or method has always been to call the dedicated methods. When calling Enlight_Hook_HookArgs::get() the intention should have always been to get an argument that was passed to the hooked method.
3. Describe each step to reproduce the issue or behaviour.

1.1 Name collisions:

Create a hookable class and implement a public method using one or more of the argument names $method, $context and $hookManager. Try to call the method on a class instance (it must be instantiated by Enlight_Class to get the hook proxy) and check the arguments passed to the original method.
Create a hookable class and implement method using one of the names reserved by Enlight_Hook_Proxy, e.g. executeOriginalMethod(). Try to call the method on a class instance (it must be instantiated by Enlight_Class to get the hook proxy).

1.2. Special hook args:

Create a hookable class and implement a public method using one or both of the argument names $class and $method. Try to call the method on a class instance (it must be instantiated by Enlight_Class to get the hook proxy). This should result in a fatal error.

4. Please link to the relevant issues pull requests (if any).

Fix execution model of replace hooks (#1501)

5. Which documentation changes (if any) need to be made because of this PR?
n/a
6. Checklist

[x] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-21604
Please use this issue to track the state of your pull request.

thanks for your contribution @svenmuennich :+1: :tada: :blue_heart:


Versatilize input order for distance_two_points

Algebra.distance_two_points takes 2 inputs: the max value used for the two points and the min value used for the two points. This change eliminates the need for these values to be in the specific (max, min) order.

Thanks!


update-radios-and-checkboxes-guidance-with-dropbox-info

This PR:

updates radios and checkboxes guidance
updates radios and checkboxes examples

These changes are based on a review of the content in the Dropbox Paper file for Radios, there is more information here:
https://github.com/alphagov/govuk-design-system-backlog/issues/59#issuecomment-429818508

You can preview this change here:
Built with commit e93ca022099be54fde4f2888a76ee7c41fcd1b4d
https://deploy-preview-586--govuk-design-system-preview.netlify.com


Completion positionned at the start of the command with ValueParameterModifiers after completing once

SpongeVanilla version: 1.16.5-8.0.0 (commit 2f5a93109a79207ebf754b3105697d7446b7c7f3)
Java version: 8
Operating System: Windows 10
Plugins: Cosmos

Hey, I'm currently trying to manipulate ValueParameterModifiers to solve a problem I'm facing with the MANY_ENTITIES built-in parameter of brigadier.
I discovered a bug that put my additionnal completion strings at the start of the command.
My modifier:
private static final class EntitiesModifier implements ValueParameterModifier<List<Entity>> {

    @Override
    public Optional<? extends List<Entity>> modifyResult(Parameter.Key<? super List<Entity>> parameterKey, ArgumentReader.Immutable reader, CommandContext.Builder context, @Nullable List<Entity> value) throws ArgumentParseException {
        if (value == null || value.isEmpty()) {
            throw reader.createException(Component.text("No entities found"));
        }

        return Optional.of(value);
    }

    @Override
    public List<String> modifyCompletion(final CommandContext context, final String currentInput, final List<String> completions) {
        completions.add("Kazz96");
        completions.add("NewCompletion");

        return completions;
    }
}

A standard command example:
Command.Parameterized command = Command.builder()
        .addParameter(
            Parameter.builder(new TypeToken<List<Entity>>() {})
                .addParser(ResourceKeyedValueParameters.MANY_ENTITIES)
                .modifier(new EntitiesModifier())
                .key(Parameter.key("targets", new TypeToken<List<Entity>>() {}))
                .build()
        )
        .addParameter(Parameter.bool().key("state").build())
        .executor([...executor...])
        .build();

Before I start completing :

After:

As you can see, only the extra completion choices are displayed at the start.
Then if I press tab, the completed string is put at the start of the command
Thanks for reading this issue

There is a valid bug here.
However, based on this issue I need to point out that while I added modifiers for you, you seem to misunderstand their limitations. Adding a completion is not going to make the parameter accept it, they are intended as a filter and operate on the result of a parameter. So, adding a new completion is not going to work in this case anyway.
In general, you should NOT be using a modifier unless you are altering the existing potential results. If you want to add something new, use firstOf and a separate element.


assets uri -> file uri

Any idea on transforming "assets-library://" uri to "file://" uri? I need to transform the image into base64.

hey @ggomaeng! to turn an image asset to base64 you need blob support. Using the react-native-fetch-blob library you can do something like https://gist.github.com/dabit3/c8185f8ab37992e9c9e6e4a31add98ee#file-app-js-L59 which would return the base64 for a specific image uri.
Expo doesnt have support for react-native-fetch-blob yet, progress for this is being tracked here https://expo.canny.io/feature-requests/p/blob-support. When it lands I can probably add it into this library.

it look like expo added the function. how is it to implement these in your code?

I havent played around with the functionality yet, but ill update the project when I do. It looks like you can convert an image to base64 before uploading it by doing something like:
https://github.com/expo/react-native-blob-test/blob/master/index.common.js#L97

Hi, I tried to upload using react-native's blob support, but it seems like they have some issues(Fix Blob Compatibility · Issue #109 · react-native-community/discussions-and-proposals) on latest RN and I couldn't upload files using method above.
I ended up using expo's FileSystem.copyAsync to save assets-library file into expo's cache directory, and upload file using base64.
here is the gist https://gist.github.com/foloinfo/0e82f1b7b3065d2807645f5a33b0a58a
I hope this helps some ppl.


mbtile file gdal ERROR 6: Unsupported tile characteristics

I am having trouble with the generated mbtiles file when using mb-util from the command line. I have a metadata.json in the folder/ and tiles are all inserted without error. I am unsure why gdal cannot recognize this file (nor qgis) and gdal is updated and normally reads mbtile files.
mb-util folder/ foo.mbtiles     (where folder has the structure: folder/z/x/y)
...
DEBUG:mbutil.util:tiles (and grids) inserted.
DEBUG:mbutil.util:analyzing db
DEBUG:mbutil.util:cleaning db
829400 tiles inserted (1655 tiles/sec)
$ gdalinfo foo.mbtiles
ERROR 6: Unsupported tile characteristics
gdalinfo failed - unable to open 'foo.mbtiles'.

total user error. My images were all in a strange size, 100x100, rather than 256x256. While the metadata.json file had the correct lat/long bounds, the smaller image sizes weren't being archived in the mbtile file correctly. Changing them fixed it.


cleanup a compiler warning about a multiline comment

this was introduced in one of the recent conformer generator commits

@ptosco : this is likely the easiest review ever. :-)


Add open-to-elb security group

This security group allows ingress connections from the ELB security group over port 443

LGTM

https://circleci.com/gh/tobyclemson/terraform-aws-ecs-load-balancer/8

https://circleci.com/gh/tobyclemson/terraform-aws-ecs-load-balancer/9


Recursively apply remove filter rule if filter is a true scalar value

Which issue does this PR close?

Closes #.
Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

Whoops -- I think I accidentally merged this with a clippy error -- will fix

Clippy fix in https://github.com/apache/arrow-datafusion/pull/3182


Qualys on WinAgent: Requested registry access is not allowed

Environment
Agent: 2.133.3
OS: Windows 10.0.14393
VSTS agent running inside an Azure VM with Qualys agent
Issue Description
If a security application (eg. qualys) is installed some registry keys (uses registry as credential storage) are not readable by NETWORK SERVICE user and vsts agent failed to run Azure Powershell Script tasks. The tasks are already failing in the setup phase (before running the user task) where the agent wants to list the installed software.
Affected registry keys are under:

HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\Microsoft\Windows\CurrentVersion\Uninstall
HKEY_LOCAL_MACHINE\SOFTWARE

The task fails with a Requested registry access is not allowed. exception and prevents any build.
As the registry permissions are a windows feature the agent should be able to deal with locked registry keys and should be able to proceed.
Error logs
2018-07-26T06:06:48.6592868Z ##[section]Starting: PowerShell: xxxxxxx
2018-07-26T06:06:48.6851546Z ==============================================================================
2018-07-26T06:06:48.6851927Z Task         : Azure PowerShell
2018-07-26T06:06:48.6852210Z Description  : Run a PowerShell script within an Azure environment
2018-07-26T06:06:48.6852495Z Version      : 2.0.11
2018-07-26T06:06:48.6852859Z Author       : Microsoft Corporation
2018-07-26T06:06:48.6853181Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkID=613749)
2018-07-26T06:06:48.6853512Z ==============================================================================
2018-07-26T06:06:50.2634580Z Added TLS 1.2 in session.
2018-07-26T06:06:50.7792363Z ##[error]Requested registry access is not allowed.
2018-07-26T06:06:50.8091236Z ##[section]Finishing: PowerShell: xxxxxxxx

"Workarounds"

Allow NETWORK SERVICE to read these keys (security credentials are readable by all vsts users!)
Uninstall security software

see also https://github.com/Microsoft/vsts-agent/issues/1707

We are looking into this. Right now, as clearly noted, the task does require registry access for us to support a wider range of customer scenarios. Will update after due consideration.

@rajatagrawal-dev
It's ok that the VSTS task needs access to the registrys but one protected key should not prevent the task from running at all.

@mblaschke agree with you, but this is as per current design of task. We have taken a note of this and will consider as part of our next enhancement thanks

Switching Azure DevOps (VSTS) agents to containers (windows docker containers) seems to solve this issue and is more then just a workaround (easier and faster VM handling).
Still it's not good that a security solution (which is forced in big companies) is breaking such tasks.


Universities from z10

With the implementation of https://github.com/phanecak-maptiler/planetiler-openmaptiles/pull/8 in the tiles, universities/college POIs can appear in the tiles as early as z10, with different ones appearing at different times based on their size (larger size=earlier appearance, down to z14 for the smallest ones). This PR changes the earliest possible zoom level for colleges and universities from z14 to z10, allowing them to render whenever they appear in the tiles.
Screenshots below, though note that the icon rendering is currently broken due to universities appearing in the tiles as class=office rather than class=college, which appears to be due to https://github.com/phanecak-maptiler/planetiler-openmaptiles/pull/29. This wouldn't be hard to patch in Americana, but I don't know if it'd be good practice since it's clearly an OMT/planetiler bug.
Examples:
Michigan State at z11 (localhost link):

Cornell at z12 (localhost link):

University of Arizona at z13 (localhost link):

Berry College at z13 (localhost link):

So the "office" bug is definitely on the openmaptiles side as I've been able to replicate it in an openmaptiles build:

I've just set up:
https://d1zqyi8v6vm8p9.cloudfront.net/rhode-island.json
This has the openmaptiles fix in openmaptiles/openmaptiles#1607 which can be used for testing/render samples.

No University in Rhode Island is large enough to trip the zoom 10 criterion, so I'm currently rendering an extract of Michigan that we can use for testing.
We do have zoom 11 and 12 examples however:
Zoom 11: University of Rhode Island, Alton Jones Campus (localhost link)

Zoom 12: University of Rhode Island main Campus (localhost link)

The zoom 11 example is interesting because it's a massive rural facility that "includes a 75-acre lake, ponds, streams, trails, and a 19th-century farm". Not really a college campus but used by the university as a conference center and presumably for some kind of woodland research type usages.  I'll have to think about this some more because I'm not sure if this is really an amenity=university or some other type of facility that happens to be owned by the University.
The z12 icon makes total sense in context with this example, but a university at zoom 11 is incredibly prominent on the map to the point where I wonder if it really belongs.  It's at a peer level with cities.  But if the Alton Jones case is an outlier that "isn't really a university in the sense of what that tag means and just a conference and retreat center owned by the university".  So I don't want to put a lot of stake in this singular Rhode Island example.
I think for some of these huge midwestern universities, calling them "on par with cities in towns" is probably correct parity for universities that boast (in the example of Michigan State) a student population of 40,000.
So In short I'd like to see some render samples and get concurrence that such low zoom treatment is the right call, especially for the z10/11 level where there really aren't much in the way of other POIs shown.

Here is the Michigan State University example (localhost link) using a Michigan tile render (same URL as the RI example, just change rhode-island to michigan):

I think this works quite nicely.

I'm not seeing Michigan State at z10 on the current PR preview
We'll need to investigate why that is (presumably tile-side)

Indeed, MSU now renders from z11 onward. In fact, I struggle to find any other university that renders at z11 now, not to mention at z10.
It's hard to tell, but I think at some point in the 3.15 upgrade things in maptiler switched from deciding how to render based on the fraction of the world's area a university takes up to being a fraction (10%) of a tile's area (relevant code here I think). Maybe that somewhat shifted the levels at which things appear?
Although actually, all of my original examples from the original PR still appear at the zoom levels I specified then (but now with the correct icon). All the ones that you posted from your state-level extracts seem to render a zoom level later: the Alton Jones campus appears at z12, and the main URI campus appears at z13 for me now. Maybe there was some weird thing where using the extract calculated the tile/planet size strangely, or a maptiler versioning thing on your local machine?


Exclude specific file and folder

Description

Exclude specific file and folder

'intermediates' folder
'.class' file

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation update
[x] Refactoring, Maintenance
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

import os.path
extension = os.path.splitext(filename)[1][1:].strip() 로 확장자 판단하는 것을 제안드립니다.


az containerapp and az container app are two valid and completely different commands, they have same sub-commands and this does not feel right

Please provide us with the following information:

This issue is a: (mark with an x)

[x] documentation issue or request

Issue description
It is customary in professional software development to make sure that one does not mix things up. Good naming is a cornerstone of this. While confusing behavior is usually "hopefully mitigated" by documenting the discrepancies, I like to raise the issue of this strange convention. I fully understand it is per some company policy but this is anecdotal. Human errors are possible and this one will be especially hard to detect.
To add to the confusion further, sub-commands such as az container app create and az containerapp create do intersect.
As an example, Microsoft support managed to mix the two in my most recent inquiry to them. Their answer was 50% on container app and 50% on container instance and the support engineer does not seem to even notice.
Such discrepancies redirect developer efforts to take special care on remembering these and such. That efforts are taken from actual work and creating value.
Steps to reproduce

https://learn.microsoft.com/en-us/cli/azure/container/app?view=azure-cli-latest
https://learn.microsoft.com/en-us/cli/azure/containerapp?view=azure-cli-latest

Expected behavior [What you expected to happen.]
The extensions and commands should not be different by one space.
There should be a way to make the user clearly understands what cloud resource they are about to work with.
Actual behavior [What actually happened.]
Additional context
The reporter (me) was not at first believe this was even possible.

Thank you for sharing! We are aware of this issue. There's no immediate plan to address it, but it is on our backlog.

@SophCarp I am so delighted it is not dismissed.


Enhance the top-researchers section

The top-researchers sesction is not look so attractive.
I would like to enhance its design and also add hover-effect.

@Harshdev098 Please assign me this issue under the label of hacktoberfest'24, hacktoberfest-accepted, level-2/3.


Implement location-based search

Why these changes are being introduced:
The GeoData app needs to allow for geospatial searching.
Relevant ticket(s):

GDT-136

How this addresses that need:
This adds form elements for the geospatial fields we’ve added to TIMDEX: geobox and geodistance. Because these fields are relatively complex and all their arguments are non-nullable, each of them has its own drop-down that toggles a boolean param (:geobox and :geodistance, respectively) to pass the field’s arguments into the TIMDEX query.
Certain client-side form validations have been added (e.g., range for lat/long entries), as well as corresponding controller validations in case a user bypasses the form.
In order to achieve the multiple query permutations (no geo fields, both geo fields, one of either geo field), additional query objects have been added. This is based on the recommendation of the graphql-client gem, which suggests using statically declared heredocs as inputs. However, that gem also recommends making queries out of several smaller heredocs, using GraphQL conveniences like fragments, so our implementation may not be exactly what the gem maintainers intended.
Side effects of this change:

Introducing an additional monolithic query object for each permutation doesn’t feel scalable or OO. We likely don’t have to time to investigate this now, but it would be interesting to consider alternative methods to constructing queries, and possibly also different GraphQL client gems.
The controller validations are an important failsafe, but they are not especially friendly. We may want to consider additional client-side validations to reduce the likelihood of encountering the controller validations in the wild.
Writing this feature revealed that the Enhancer and Query Builder models are functionally identical. This was intentional to prepare the app for additional query enhancements. As we’ve now abstracted that to TACOS, we should consider at some point whether we still need both of these models.
The form partial and corresponding JS are getting unwieldy. Refactoring these would be a good maintenance activity. Further, the interactive elements are becoming complex enough that E2E testing is worth considering.
The labels for the new form elements are grotesquely long, but they also need to convey a lot of information. I’m hoping that UXWS can help with this.
Most cassettes have been regenerated due to schema updates.

Developer

[x] All new ENV is documented in README
[x] All new ENV has been added to Heroku Pipeline, Staging and Prod
[ ] ANDI or Wave has been run in accordance to
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
[ ] Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

[ ] The commit message is clear and follows our guidelines
(not just this pull request message)
[ ] There are appropriate tests covering any new functionality
[ ] The documentation has been updated or is unnecessary
[ ] The changes have been verified
[ ] New dependencies are appropriate or there were no changes

Requires database migrations?
NO
Includes new or updated dependencies?
NO
Includes schema updates?
YES
Includes updated VCR cassettes?
YES

Tagging this for review despite CI failure because I'm not sure why CI is failing. The tests pass for me locally, and I'd like the reviewer to try running them locally as a first step.
The codeclimate issues are mostly related to complexity, which is not surprising. I'm open to any suggestions on that front, including breaking down the validation methods further. In many cases, though, it seems to be just above the threshold, in which case I'm less likely to take the alert seriously.
The DRY flagging of the JS code is also relevant, but I'm not sure it's worth fixing. I could be persuaded otherwise.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

80 of 82 (97.56%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.4%) to 99.099%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

app/controllers/search_controller.rb
52
54
96.3%

Totals

Change from base Build<PHONE_NUMBER>:
-0.4%

Covered Lines:
440

Relevant Lines:
444

💛  - Coveralls

The codeclimate issues are mostly related to complexity, which is not surprising. I'm open to any suggestions on that front, including breaking down the validation methods further. In many cases, though, it seems to be just above the threshold, in which case I'm less likely to take the alert seriously.
The DRY flagging of the JS code is also relevant, but I'm not sure it's worth fixing. I could be persuaded otherwise.

Thanks for the detailed review, Matt!! I'll get to work on these changes momentarily.

@matt-bernhardt I think this catches everything, but it's quite likely I missed something. Please let me know either way.
The changes to the form are unrelated to your initial review:

Placeholders are now sample values. The downside to this is that we are not providing the same richness of information to all users, as not all screen readers process placeholders. I plan to raise this issue during UX review.
The instructions for each field are now in a span below the input. This allows us to assign aria-describedby and makes the fieldsets a bit less cluttered to my eye. (Incidentally, this would also be a relocation candidate for the placeholder text.)

Validation of distance units wasn't specifically requested, either, but your comment made me think it would be useful to handle that 500 error you were seeing with invalid units. You'll note that in the flash error, I didn't technically list all of the possible units, as it seemed easier to encourage users to abbreviate them. (Part of this is due to some oddness in the OpenSearch conventions; if I were searching in inches, I would not think to use 40inch).
Thanks again for the in-depth review!


add tags in resources vpc, instance, ipadress, template and vpc

User could tags only network, I've added tags parameter to more cloudstack resource.
Actually we can tags everything except security group but api docs about tags ask for resourceType and their is no simple way to know what can be this values.
I've found some of them and added the tags parameter.
There is a refactoring to test tags in resource.
Finally, I couldn't run acceptance tests only because I'm not sure what should inside env vars and how it could affect my cloudstack.
Maybe just some comments could help

Thank you @svanharmelen for the review and sorry for the long delay.
This is now fixed, we have tested these new tags and everything works, acceptance test can be ran.

Thanks @ArthurHlt! LGTM!


Add evohome water heater

Breaking Change:
None
Description:
Adds a water_heater to the evohome integration.
Related issue (if applicable): None
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for configuration.yaml (if applicable):

uncahnged -

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[x] The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
[x] New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
[x] Untested files have been added to .coveragerc.

If the code does not interact with devices:

[x] Tests have been added to verify that the new code works. (N?A)

@MartinHjelmare I'd be grateful if you had time for this one too.

@MartinHjelmare Hi, are you happy with this? -D

We block this PR until https://github.com/home-assistant/home-assistant/pull/23899 is merged

I migrate the PR to new climate PR. If you update the schema, we can merge it into our PR

Can anyone tell me why I'm not getting a decent error message:
2019-05-23 20:56:33 ERROR (MainThread) [homeassistant.setup] Unable to prepare setup for platform evohome: Platform not found.
2019-05-23 20:56:33 DEBUG (MainThread) [homeassistant.core] Bus:Handling <Event call_service[L]: domain=persistent_notification, service=create, service_data=title=Invalid config, message=The following components and platforms could not be set up:

 - evohome.climate

Please check your config., notification_id=invalid_config>

@pvizeli This PR was originally to add a water_heater only.  It touched upon climate barely at all, until @MartinHjelmare asked me to do some refactoring. Now I'm asked to make the whole integration compatible with the new schema...
I have had a look, and there is a lot of work to do to take on the new schema.
I don't know how your going to get all the other climate entities migrated in short order, and so I am worried that climate-1.0 will take a long time to be merged into HA... meanwhile my water_heater will not be available to users.
My PR is going to be biggish... In my case, I'll have to add the storage API (to cache refresh tokens, as the vendor is now so much more strict with API limits on OAuth & I couldn't do this refactor without that).
And my modes/states are a lot more complicated than what you've made allowable - are you willing to consider extending the new schema further?  For example: PRESET_CUSTOM?
So I'm asking if I can just have this PR accepted into dev, rather than climate-1.0.
In any case, I think you're missing a trick - in modern heating systems, the zones (i.e. rooms) can have a hierarchy - they will usually inherit a MODE/PRESET from the controller (i.e. house), but: for example, the 'house' can have HOME preset , but one of the rooms may be in BOOST.
Is there any scope for adding a controller and a hierarchy of PRESETs?

Look like the branch is corrupt with strange code...

OMG - 53 files changed! what happened there!  Will see if I can fix it.
@pvizeli My question is - can I just add the water_heater and make a few tweaks to the integration on dev, then have a separate PR for climate-1.0 branch?

@pvizeli OK, I rebased.  This PR is not yet ready to merge to the climate-1.0 branch, but the original changes were almost exclusively limited to water_heater.py, with only refactoring of climate.py because @MartinHjelmare asked me to rename some attributes, etc.
You can see water_heater.py was just over 100 new lines, and this PR is now >800 lines changed with the migrating.
Can I just not get the water_heater merged (with some changes to __init__.py to support the next PR), then I'll do another PR for climate`?


fix issue with url + fix bug

Fix crash if url contains accents.
Improve url encoding.

This one actually breaks firebase audio file urls. Please check issue #617 and #543 for more info.


Making method rpc_interface public in sc-cli

I was discussing with @JoshOrndorff on https://github.com/paritytech/cumulus/pull/380 and he pointed out that the function rpc_interface in sc-cli can actually be useful for users who need to customize their RunCmd command.
I don't mind making it public but I think it would be better if it is attached to something that make sense instead of being a free public function. So I moved it to the cli's "arg enum" RpcMethods.

We've solved paritytech/cumulus#380 a different way, so this PR is no longer needed there. Since it has also gotten stale I'll close it, but I'm fine with reopening it.


Unable to open in unreal engine 5.4

Anytime I try to open the project in the folder I get the following error. " fuse could not be compliled. try rebuilding from source manually.

As this is a c++ project, you need to have visual studio with the required modules and runtimes set up to compile and run it - see Epic's documentation for setting up visual studio for Unreal. If you can't compile the project even with the required setup, you will be able to get a more complete error by attempting to compile it through visual studio.

Remove IncludeOrderVersion from
Fuse.Target.cs
FuseEditor.Target.cs
and set DefaultBuildSettings to BuildSettingsVersion.V5


Support activating seeds from outside playground & dashboard

Issues

https://github.com/threefoldtech/tfgrid-sdk-ts/issues/920

Updates

[x] Playground

https://github.com/threefoldtech/tfgrid-sdk-ts/assets/31689104/73c9db94-90de-49e9-a1c0-9770f49264bc

[x] Dashboard

https://github.com/threefoldtech/tfgrid-sdk-ts/assets/31689104/4642dc15-10ef-4412-807c-d402d900dcea

Good Job!
small note:
I'm Agree with @AhmedHanafy725 , and as the playground flow is nicer, you can adjust the dashboard flow/buttons.


Button tag helper

It would be nice to have a tag helper for <button> elements to maintain consistency of syntax with other elements (i.e., not having to use Html.NameFor when all other elements use asp-for.) This may be petty and aesthetic but I thought I would ask anyways. :lollipop:

Seems reasonable. We're trying to avoid adding features at this point in the current release, but sounds like something we could look at adding in a future release.

Closing because we have no plans to support this.

Thank @Eilon!

Note we do now have a tag helper in the box which targets <button> elements: The FormActionTagHelper does this and generates formaction attributes based on asp-controller, asp-action, … attributes in the .cshtml file. But we don't support reading asp-for and generating id, name or value attributes based on it.

Nice, I didn't catch that that was added. Thanks for the update!


fix: use approvals instead of approval

to keep naming consistent i changed approval to approvals

@hewigovens merging this to unblock server work progress


Clean bower.json

As it occurred at https://github.com/StarcounterPrefabs/Launcher/issues/218
We have some dependencies that are not saved in bower.json
We need to investigate the code and find those, to make bower installs, update, prune work consistently.

@miyconst could you please take this?

I did actually some clean up recently in juicy-composition branch, so you can double check it there.

Seems fixed on develop branch


Test default envs more aggressively

Higher Ray version in local tests and both higher Ray version and alternate Python version in release tests

#925  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dongreenberg and the rest of your teammates on  Graphite


Migrate use of theme to gatsby-theme-marmalade-ai

company-website should use gatsby-theme-marmalade-ai, rather than gatsby-theme-codebushi.
Depends on the completion of Issue #2 before this Issue can be resolved.

Resolved by Pull Request #47.
No need to do this migration.


run clippy on board support packages

Runs clippy on all board support packages using the nightly compiler and --all-features. Ignore clippy lints from auto-generated PAC codes because it has a lot of errors.
An example of what the clippy CI output looks like can be found on this PR on my fork. Unfortunately, the nicely formatted annotation will not work on PRs with branches coming from forked repos due to this issue, however the CI post-merge will have the annotation, and clippy errors will still block PRs, which is good.
TODOs:

[x] push fixes to two clippy errors found, USB MaybeUninit & a drop in wifi.rs
[x] show what a PR annotation looks like
[x] test USB fix
[x] change USB buffer code to singleton!(: [u8; BUFFER_SIZE] = [0u8; BUFFER_SIZE]).unwrap()
[ ] test wifi fix (@twitchyliquid64 will give this a shot)

Nice!
I can test out the removal of drop(b) - I remember that was necessary when I was writing it ~3 months ago, but maybe the compilers gotten smarter since then.
As for the USB buffer change - LGTM.

Nice!
I can test out the removal of drop(b) - I remember that was necessary when I was writing it ~3 months ago, but maybe the compilers gotten smarter since then.
As for the USB buffer change - LGTM.

Thanks @twitchyliquid64! USB change looks good, so once wifi change looks good we can merge

Thanks @twitchyliquid64! USB change looks good, so once wifi change looks good we can merge

@twitchyliquid64 will you be able to test this change out soon? 😁

@twitchyliquid64 will you be able to test this change out soon? 😁

Sorry for the delay, just tested it and it looks spiffy!

Sorry for the delay, just tested it and it looks spiffy!

Is this good to merge?

Is this good to merge?

No worries, thanks for checking! Yeah let’s merge
On Sat, Jan 23, 2021 at 10:55 AM Twitch<EMAIL_ADDRESS>wrote:

Is this good to merge?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/atsamd-rs/atsamd/pull/381#issuecomment-766160762, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AC5YNWXUK755MSA65IBINETS3MLT3ANCNFSM4V46YLZQ
.

No worries, thanks for checking! Yeah let’s merge
On Sat, Jan 23, 2021 at 10:55 AM Twitch<EMAIL_ADDRESS>wrote:

Is this good to merge?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/atsamd-rs/atsamd/pull/381#issuecomment-766160762, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AC5YNWXUK755MSA65IBINETS3MLT3ANCNFSM4V46YLZQ
.


pika support codis slot mgirate

support all codis slot migrate command in pika
add switch for supporting codis slot migrate, could configure in configuration file or from redis-cli 3. config set /get slotmigrate yes/no
add command slotsreload for loading keys into slot keys and slotsreloadoff for forced stop
reloading keys
info command display wether in slotsreloading status or not
dbsize could show keys number precisely and without delay if slotmigrate is yes

Nice Job!


Suggest to cancel english-teacher-timer when english-teacher-mode disabled

it's fixed, tks for your advise


Add leisure=track

Thanks for this contribution, but you need to explain way you want to add this. We won't merge an uncommented PR.

I guess this is map race tracks @hannesj?
http://wiki.openstreetmap.org/wiki/Tag:leisure%3Dtrack

Thanks for this contribution, but you need to explain way you want to add this. We won't merge an uncommented PR.
Show all checks

@manuelroth I think GitHub supports issue and PR templates now. https://github.com/blog/2111-issue-and-pull-request-templates We could add one.

Sorry for the lack of explanation. I found that one feature lacking in osm2vectortiles compared to mapbox vector tiles is the track areas at sports stadiums. The pull request is to mitigate this issue. See the comparison below for the streets style.
Osm2vectortiles:

Mapbox:


Querying date using Rest API where clause

If I send this where clause in a rest api call :
{'updatedAt': {'>':'2016-01-01T00:00:00.000Z'}
(updatedAt greater than 2016-01-01)
With this url for example :
http://localhost:1337/api/rest/tournament?where={%27updatedAt%27:{%27%3E%27:%272016-02-02T10:57:08.976Z%27}}
This will output data without filtering by updatedAt :
[
  {
    "name": "Test1",
    "createdAt": "2016-02-01T21:00:14.925Z",
    "updatedAt": "2016-02-02T22:28:58.793Z",
    "id": 1
  },
  {
    "name": "Test2",
    "createdAt": "2015-12-03T10:57:08.992Z",
    "updatedAt": "2015-12-03T10:57:08.992Z",
    "id": 2
  }
]

Test2 should not be returned.
What is the correct way to querying date using where clause (in the rest api) ?

Hi @Aure77 - would you mind adding information about which adapter and Sails version you're using? Thanks!

Sails version : 0.12.0-rc6
Db Adapter<EMAIL_ADDRESS>

@Aure77 So @particlebanana did some work tracking this down, and here's the situation:  In this particular case, the fix is in waterline-criteria (a dependency of sails-disk).  Will keep you posted on that (we'll do a patch for 0.11.x).  Thanks again!
I also wanted to take some time to provide background on this for your future reference, and for anyone else reading this who wants to learn more about how Waterline is architected or interested in contributing.  tldr; There are a few different longer-term roadmap items we're working on that will help make issues like these easier to prevent cross-adapter in the future.

The reason the fix is in waterline-criteria is because waterline-criteria is a dependency used by sails-disk (it is also used in waterline core, but that's just coincidence).  Currently, adapters are responsible for coercing incoming criteria themselves.  This is a decision we made initially so that individual adapters could apply their own understanding of data types.  This works fairly well, but it does mean that behavior can be inconsistent across adapters (e.g. if you were to try the exact same thing using sails-postgresql, it should work).
We'll always need to apprehend issues like these on a case by case basis (as I mentioned above, keep an eye out for a patch that will address this for apps using either 0.11.x or 0.12.x.)  But longer term, we have some plans for Sails v1.0 that will help make this easier to resolve by providing a deeper separation between:

(A) the code which interprets usage in your app and figures out how best to query models (Waterline core)
(B) the code which compiles criteria dictionaries into e.g. SQL or Mongo queries and communicates with the underlying database (adapters), and
(C) the code that builds the physical-layer schema in the first place; i.e. automigrations (currently part of Waterline core, planning to pull that out into Sails core for v1)

This will allow us to do more in Waterline core as far as type validation/coercion, since the way data type of attributes is expressed will more clearly specify its logical type (e.g. "string") vs. its physical type (e.g. "VARCHAR(255)").
However, relevant to this specific case, "date" will likely never be treated as a top-level logical type.  It's hard to say for sure of course-- but we've learned some pertinent lessons in that department when building rttc, and at this point my hunch is that we should continue to have dates come in as either UTC (timezone-agnostic) ISO strings like '2016-02-05T10:51:34.299Z') or js (epoch ms) timestamps (e.g.<PHONE_NUMBER>490).  Of course, to do this, that means that these values will need to continue to be interpreted when building physical queries in the adapter.
Which brings up another consideration which was also brought up recently by the guys at Postman:  Adapters need standardized access to the logical schema (e.g. "string" or "json") and the physical schema (e.g. "datetime" or "geojson").  The latter can vary across adapters, and may or may not even be specced in your model today.  Currently, adapters grab hold of this information initially, then maintain private state.  But a better approach would be for Waterline core to always coerce incoming criteria and values to match the logical schema, and that's the plan.
In addition, Waterline core could provide a (preferably immutable) reference to the physical schema obtained by an initial call to the adapter's .describe() method.  This would allow Waterline to flush itself as the schema changes or connection info changes, and prevent adapters from having to maintain their own state (assuming a similar solution was implemented for the connection pool obtained from the underlying driver-- which is something we've begun work on, since it is necessary for easier-to-use native transaction support).
So to wrap that up, here's a quick recap:

Waterline adapters will always be responsible for mapping incoming logical criteria to the relevant physical type in the database.  This is necessary to empower adapter authors with enough flexibility to take advantage of advanced database-specific features.
However, adapters shouldn't have to be responsible for ensuring that criteria and data provided at runtime match the expected logical type.  In other words, to stick to your example, an adapter will still be responsible for recognizing that your updatedAt column is a "DATETIME" and that an incoming '2016-01-01T00:00:00.000Z' in {'updatedAt': {'>':'2016-01-01T00:00:00.000Z'} } needs to be understood and compiled as a datetime comparison, rather than as a string comparison.  But, since we know logically that updatedAt is supposed to be a string, if something like {'updatedAt': {'>': new Readable() } } is provided, it'll be rejected before it ever makes it down to the adapter.

@Aure77 just published a patch of sails-disk-- would you try it out when you have a sec?
# in the root folder of your Sails app:
npm install sails-disk@beta --force

Thanks!

After updating sails-disk, I am always experiencing same issue.
But I found a solution by changing quote type (' -> ") :
{"updatedAt": {">":"2016-01-01T00:00:00.000Z"}
About the related pull request, where.js seems to already handle date in comparison ? :
https://github.com/balderdashy/waterline-criteria/blob/1f6eccfa571fb5121fabdacb0bfb474335432117/lib/filters/where.js#L193

@Aure77 correct, using query params in the blueprint API, you'll always need to use JSON encoding (double quotes) My bad, should have caught that earlier, but couldn't tell from your original post because of the URL encoding.  Regardless, I don't believe this should have worked prior to the update because sails-disk wasn't passing in the expected schema to wl-criteria (unless i'm missing something)

0.12.1 has been released which points to the updated version of Waterline and its dependencies.  Tested and confirmed that this is fixed!


Bump version to 5.7.1-SNAPSHOT

we usually have 27 files - figuring out what is extra file (maybe void concern, one moment)

we usually have 27 files when bumping - figuring out what is extra file (maybe void concern, one moment)

Ah ok, it's new GCS plugin


Update delegates.json

Adding in our validator.

Let me know if this is going to be processed, or if i should resubmit.

You need to generate a signature so we can verify the information, using this script:
https://gist.github.com/unconst/6965a01bad729eec375ac6a97734c0ae/

I can re-open this when you add the signature

I can re-open this when you add the signature

You are after the secretPhrase correct? (Not secretSeed) ?

I used the seedPhrase. Quotes were tripping me up.
Validator signature: d8c2efb836e7a311cd15a9567487314b1f2c3bb5e8fa71d9b7b28f887360220e25bd1c14ff7627098b084730d878c77a479555d8a7071c5634e8209e0395588a

I used the seedPhrase. Quotes were tripping me up.
Validator signature: d8c2efb836e7a311cd15a9567487314b1f2c3bb5e8fa71d9b7b28f887360220e25bd1c14ff7627098b084730d878c77a479555d8a7071c5634e8209e0395588a

Hi, this sig is not passing the verification. Please double-check the text entered is the same

Closed for #1218


Add 'make lint', restructure 'compliance' pipeline

Added 'lint', 'lint-frontend', 'lint-backend' targets
Added 'lint-frontend', 'lint-backend' ci steps and restructure the 'compliance' pipeline to have a clear separation between frontend and backend and use parallelism where possible. Also, the main build pipelines now depend on 'compliance' so they will skip if it fails.
Added dependencies on ci steps so they skip when 'compliance' fails
Fixed issue with golangci-lint download on Windows
Moved JS linters to devDependencies
Removed deprecated 'js' and 'css' targets

Should be ready for review.
I have encountered this "not something we can merge" git error a few times while testing. Not sure exactly what to do about it. Those steps have pull: default, maybe it needs to change to pull: always? Drone documentation seems lacking on what pull does or I'm to dumb to find it.

Codecov Report

Merging #10861 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #10861   +/-   ##
=======================================
  Coverage   43.49%   43.50%
=======================================
  Files         592      592
  Lines       82979    82979
=======================================
+ Hits        36094    36100    +6
+ Misses      42399    42392    -7
- Partials     4486     4487    +1

Impacted Files
Coverage Δ

modules/indexer/stats/db.go
50.00% <0.00%> (-9.38%)
:arrow_down:

modules/git/utils.go
65.67% <0.00%> (-4.48%)
:arrow_down:

modules/queue/workerpool.go
55.87% <0.00%> (-2.14%)
:arrow_down:

services/pull/pull.go
35.00% <0.00%> (-0.89%)
:arrow_down:

modules/git/repo.go
47.28% <0.00%> (-0.84%)
:arrow_down:

models/notification.go
64.71% <0.00%> (+0.83%)
:arrow_up:

services/pull/temp_repo.go
31.62% <0.00%> (+2.56%)
:arrow_up:

services/pull/patch.go
64.51% <0.00%> (+2.58%)
:arrow_up:

modules/git/command.go
89.56% <0.00%> (+2.60%)
:arrow_up:

services/pull/check.go
55.48% <0.00%> (+5.48%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cd4704...e206b68. Read the comment docs.

by by css and js targets


pull request for e2e test at 01/02/2017 01:45:07

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Examples cannot be accessed due to SSL error

It seems some SSL certificates ran out of time.
https://www.jaxon-php.org/examples/simple/hello.html
file_get_contents(): SSL operation failed with code 1. OpenSSL Error messages: error:14090086:SSL routines:ssl3_get_server_certificate:certificate verify failed

Working on it. Meanwhile, you can check the example code in this repo: https://github.com/jaxon-php/jaxon-examples

You can also see a real world use of the library in this package: https://github.com/lagdo/jaxon-dbadmin/tree/main/app
Or these

https://github.com/lagdo/jaxon-supervisor
https://github.com/lagdo/twitter-feed
https://github.com/lagdo/polr-admin


How to add the current time to the default file name

How to add the current time to the default file name.  I tried -o %(duration>%H-%M-%S)s which didn't work

I used -o test.flv for testing but it had no effect.


[DansTonChat] Random other websites get displayed instead

https://bridge.suumitsu.eu/?action=display&bridge=DansTonChat&format=Html
→ right now, shows content from NextInpact.
Mail report by Pierrecastor  (in French)

J'utilise fresh-rss en 1.4.0, et pour détaillé l'historique :
Le 2016-10-13, à 14h56, je reçois ma dernière quote de DTC, la #18019
Le 2016-10-13, à 19h15, je reçois un flux du nouvel obs : http://api.rue89.nouvelobs.com/2016/10/13/wonder-woman-incarne-les-femmes-a-lonu-choix-a-cote-plaque-265412
Suivie d'autres articles du nouvel obs
Le 2016-10-17 à 8h40, le flux passe sur nextinpact :
https://www.nextinpact.com/news/101777-blockly-programmation-graphique-google-debarque-sur-ios.htm
Puis change le 2016-10-18 à 17h01 pour commondreams : http://www.commondreams.org/views/2016/10/18/meet-peoples-action-22-candidates-fighting-all-us
Pour ensuite repasser par nextinpact et enfin revenire en ce moment sur nouvel obs.

This is caused by https://github.com/RSS-Bridge/rss-bridge/blob/master/index.php#L128 and the next few lines. Since any data from the $params field is removed, no parameters are left. Thus, depending on the bridge called first, the FileCache will generate the same file name for entire different bridges (as the file name is build solely from $params).
This bug was introduced by https://github.com/RSS-Bridge/rss-bridge/commit/ac0a9a90ad13049d503a4c4e222d7ca3f1bde6d3 which removed the complete URL from the algorithm, in order to return cached files if the format changes.
So, in order to fix this, either revert the commit or initialize the cache before removing parameters from $params.
I just pushed https://github.com/RSS-Bridge/rss-bridge/commit/85149add6150cc925c558a3e6e422e1fc1eceec0 which should solve this. Can you confirm?

Fixed the fix via https://github.com/RSS-Bridge/rss-bridge/commit/5790ebc6ba98cd563758dddb563d332f92f4ae95 ($params actually needs to be initialized before being used...)

It's fixed, issue doesn't appear. Nicely done :)


⚠ Bofrost.lu has degraded performance

In b4da968, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1297 ms

Resolved: Bofrost.lu performance has improved in b46bf47 after 6 minutes.


refactor(navbar): split ListNavDropdown component

Based on our team's decision, we no longer require approval of the refactoring pull request. Instead, we will review and approve the refactoring once all changes related to a specific component have been completed.


Add methods to check the level of a User object

The User object should have methods to check whether a user is of a certain level or not i. e. is_admin to replace the equivalent User.level == 'admin'. The rationale here is that as we begin to grow the size of the codebase we will begin to see more statements that read User.level == 'xxxxx' to restrict/allow the rendering of certain parts of a template.

closing in favor of: https://github.com/biocore/qiita/issues/493


Can this be used to generate method signatures automatically from a C/C++ library header?

I'm trying to workup ICU bindings for Lua but my initial attempt to use LuaNativeObjects didn't turn out like I expected. Somehow I thought the various subfiles src/*.noobj.lua that have object/method/function signatures could be auto-generated given the C/C++ source code and header files for the library I want to wrap (in this case icu4c). It turns out all I was able to accomplish was generating c code and a loadable Lua module that included any C functions I manually provided signatures with input/output types for.
Is there some way to automatically generate those signatures from a header file? At least as a starting point?

Sorry there isn't a parser for C/C++ headers.  The .nobj.lua files are hand written.  The main benefit of using LuaNativeObjects is that it can generate most of the C code needed for Lua bindings (and LuaJIT FFI bindings).
There are some C++ bindings generators for Lua that you can try:
https://stackoverflow.com/questions/52564364/automated-lua-binding-using-c
I looked over the ICU C API docs a little bit and it doesn't seem like an API that will be easy to created Lua bindings for.  Not sure how Lua strings can be converted safely to UChar (16-bit chars) or how to allocate and initialize a dynamic UChar * string.
I didn't look at the ICU C++ API, maybe it has an easier to use Unicode string object.
I think a lot of the ICU functions will need some custom C code in the bindings functions.  NObjects supports wrapping C code in the bindings functions See an example here from lua-llthreads.
Here are some example Lua bindings that  use it:
https://github.com/Neopallium/lua-buf
https://github.com/Neopallium/lua-llnet
https://github.com/Neopallium/lua-zmq
https://github.com/Neopallium/lua-llthreads - This Lua bindings for pthreads is a good example of a complex binding.

Thanks @Neopallium, that's very helpful information.

There are some C++ bindings generators for Lua that you can try:
https://stackoverflow.com/questions/52564364/automated-lua-binding-using-c

I simple take a look at it.

oolua: 404
luabind: stop maintenance
at 2010
manualbind: not full auto binding,
user needs to call lua_*()
luaaa: only a hpp
LuaBridge: many h

IMO, there are the same type of
node-addon-api, a library to
provide many h files to use
C++ to write nodejs addon.
NativeObject.lua is another type. It translate lua to C/luajit FFI code like cython, a tool to
translate python to C/C++.
However, many things are different.

not all lua can be translated. must be *.nobj.lua
Don't support output C++
Must inline C code by c_source, however, cython allow to use python to write
C code:

import cython as c
from cython.cimports.libc import malloc, free

def f(num: int) -> None:
    # convert python's int to c's int
    n: c.int = num
    # convert c.p_void to c.p_char
    p: c.p_char = c.cast(c.p_char, malloc(n))
    free(p)

I believe cython is a full compiler with a parser of python and a code generator
of C/C++. NativeObject.lua is a template engine to generate fixed C code/luajit
FFI code by the source of nobj.lua
This project is lack of enough documents, so just give some information coming
from me.

LuaNativeObjects is mostly a templating engine for building Lua bindings.  My goal for this project was to make the generator handle all the pushing/popping of values from the Lua stack, to avoid manual tracking of the values on the Lua stack.  Also it handles a lot of the details of defining Lua-style objects to wrap C-style objects (structs with methods) and doing type checking.
For the LuaJIT support I focused on performance, making sure that the JIT compiler doesn't fall back to interpreter execution (which it has to do for normal Lua C bindings).
The lack of documentation is because this project was created for my own uses (see all my Lua bindings on github).


Update the issue with the list of types potentially impacted

@vivmishra

@AlexGhiondea, I made a few changes so that links would resolve properly. But this is intended to be an app compat topic, isn't it? If it is, it needs some required sections (which are in !Template.md),  For example:
Scope
Major
Version Introduced
4.7.1
Source Analyzer Status
NotPlanned
And it also needs

[x] Quirked

[ ] Build-time break

so that the migration tool knows what to do with it.

Since this is a known issue rather than an app compat issue, @AlexGhiondea, ignore my comments.  I'll also undo some of my changes -- I don't think that linking is supported from known issues through <xref:> or asset IDs.

@vivmishra I don't understand what you are asking for.

@rpetrusha anything else needed for this?


Paraviewweb: Does LightViz can load .pvsm file?

Hi! I am new here and use paraviewweb lately to display OpenFOAM data. I found that I can successfully load .pvsm file in Visualizer, but the file cannot be loaded in Light-Viz.
Does LightViz can load .pvsm file? And if not, is there another way to display OpenFOAM data in LightViz?
Thanks!

Thanks Jourdain. I can generate .foam dataset file now, but new problem coming out: the Light-Viz is staying at the “Loading Data” page. Is the file too large for the Light-Viz? Does the Light-Viz have limit of the size for data loading?

Problem solve now! And find that the Light-Viz seems do not have legend for the color code?

Light-Viz seems not have much as Visualizer, including can display different part of the geom, legend...

LightViz is really a demo app meant to provide ideas. It is not really meant to be used in production.

what a pity! the user interface of LightViz is very good. Anyway, thanks.


Zig libraries need to manage their own memory

I was looking for a diffing library to use on a Zig project, and diffz looked like the best candidate. Even with just the diffing portion of diff-match-patch, and a lack of recent commits (it happens), I figured hey, community-supported library, it's got the part I actually need, and maybe I could take some time to continue the port.
I was disappointed to see that the library uses an arena as though it were a garbage collector. In a ziglib, functions are expected to take a generic Allocator, and behave accordingly, by freeing any memory they don't return. If the user wants to use an ArenaAllocator, that's fine, free is a no-op unless the allocation happens to be the last one performed, so one ends up with the performance benefits, while maintaining the flexibility which is a core competency of the language.
I assume this unfortunate state of affairs came to be because this version of diff-match-patch is a port from a garbage collected language, C♯ presumably.  It's just a pity, because Zig provides such excellent tools for finding memory leaks, use after free, and double free, and the library has a robust test suite. Proper memory management could have been added during the port, and then this would be a real Zig library, not just a promising sketch of one.
Anyway, now there's an issue to track this, in case anyone wants to close it...

fixed by #23


test(customFileds): Add tests with exporting custom fields

Summary
Resolves #54
Todo

Tests

[ ] Unit
[x] Integration
[ ] Acceptance

[x] Documentation

Coverage remained the same at 93.317% when pulling f9a08bb88a05287f1ef3bf58ed7e7ea004c9e83c on 54-export-custom-fields-documentation into 3127a3fda9fc7f66fefcfcf7014a0c023b89b4df on master.

Coverage remained the same at 93.317% when pulling f9a08bb88a05287f1ef3bf58ed7e7ea004c9e83c on 54-export-custom-fields-documentation into 3127a3fda9fc7f66fefcfcf7014a0c023b89b4df on master.

Coverage remained the same at 93.317% when pulling 818cfad791d17dde93d03d36c33b7bd7b6858418 on 54-export-custom-fields-documentation into 3127a3fda9fc7f66fefcfcf7014a0c023b89b4df on master.

Coverage remained the same at 93.317% when pulling 818cfad791d17dde93d03d36c33b7bd7b6858418 on 54-export-custom-fields-documentation into 3127a3fda9fc7f66fefcfcf7014a0c023b89b4df on master.


Sync dubbo docs to website

https://github.com/apache/incubator-dubbo-docs/pull/30 is not synced to website. We need to check other docs as well.

Why closing this issue?

@ralf0131 Concrete is which article to add this picture?

Not quite sure, can you dig it?

Not quite sure, can you dig it?

I seemed to understand the meaning of the people. He should be refer to this article needs to be modified.

@caojiele hello, I'm a newcomer and would love to contribute.

can I assaign this task


Fix link to DRLM example

As title

Hey @KanchiShimono, changes LGTM, thanks!
Could you rebase this diff (I pushed a change that updated README), and i'll get it stamped?

@YLGH
Thanks for reply and review!
I rebased and pushed branch again!

I just found new inference example is added under the examples/dlrm/inference, so I updated link in inference source code.


icon stuff

PRing just so I can point at it easily. It doesn't work.

conversation in https://forum.lvgl.io/t/trying-to-use-new-svg-support-failing-to-render-anything/18574

got SVG rendering to work, a bit. viewBox breaks it, I haven't found how to size it correctly, and this SVG lib does not handle style= in SVGs at all. Closing this.


[provider-extension] Download admission webhook repositories with curl instead of git

How to categorize this PR?

/area dev-productivity
/kind enhancement
What this PR does / why we need it:
With this PR admission webhook repositories are downloaded as archives using curl instead of git. This is way faster in most of the cases.
Additionally, some issues discovered by shellcheck have been fixed.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:

NONE

/cc @ScheererJ

/lgtm
/approve


A QC Dashboard shows the number of detectors balance between different models over time

Create a dynamic dashboard that will show number of detectors count over two weeks dynamic time period from different models. Ken already created that datasets in mart level. We need to make the connection between that mart table and kibana usinsg logstash to push the data for visualization and then schedule the data update everyday early night around 3.30 am to update the data in daily basis.  This visualization will compare the number of detectors for the below models-
a. HOV and ML total number of daily detectors
b. HOV and ML detectors daily count from five minutes performance model
c. HOV and ML detectors daily count from Imputed model
d. HOV and ML detectors daily count from cleanhouse
e. Number of Bad, Good and Total Detectors

Thanks for this @mmmiah and I have created a new issue (#426) to document/fix the detector_status data issue we are seeing since 10/8/24.

Per @mmmiah this work is completed so we can close this issue.


Navbar: Option to Configure Profile menu Signout button text

Prerequisites

[X] I have searched for duplicate or closed issues
[X] I have read the contributing guidelines

Describe the issue
Profile Menu Signout button should be configurable to provide custom text

Reduced test cases
No response
What operating system(s) are you seeing the problem on?
No response
What browser(s) are you seeing the problem on?
No response
What is the issue regarding ?
@trimble-oss/modus-web-components
What version of npm package are you using ?
0.1.42
Priority
High
What product/project are you using Modus Components for ?
Trimble Creator (Drawings)
What is your team/division name ?
Industry Clouds
Are you willing to contribute ?
Yes
Are you using Modus Web Components in production ?
Yes

@cjwinsor Yes during the process of internationalization in Construction cloud UI  we have identified this 'Sign out' text could not be localized. Currently we support Japanese language other than default English. and for the most part we have translated and some are yet to be translated
we have created this ticket to track the missing translations

Add property to overwrite the Sign Out text, defaulting to standard.

@VinoSakthiv Feel free to contribute this change, it has been approved.


complete transpose gif

Take the figures created in #25 and show the two watersheds. Then move the storm from it's original location to the new location.

take yahara and move it
wateruse viz code has spatial transformation stuff
map repo on wdwatkins github

Just a static png.


Added an optional parameter to manage ciphers list to the Connection#initializer

When I try to connect to vcloud I run into "SSL_connect returned=1 errno=0 state=error: dh key too small (OpenSSL::SSL::SSLError)" error
The problem is due to the different versions of SSL between client and server.
As suggested in this article https://zackhobson.com/2014/02/10/ssl_and_ruby_part_2/, it's enough providing the ciphers list in the connection.
So I solved this problem by adding an optional parameter to the Connection#initliaze
initialize(host, username, password, org_name, api_version, opts={})
Then I use this new paramter in setup_request(params, payload=nil, content_type=nil)
unless @opts.empty?
req_params.merge!({ssl_ciphers: @opts[:ssl_ciphers] }) if @opts[:ssl_ciphers]
end

Coverage increased (+0.02%) to 71.355% when pulling 12634ff74da51e92e9595411f48f1e24f5df4c8d on monical75:master into 45425d93acf988946cac375b803100ad01206459 on vmware:master.


playbot IRC attributes no longer work

Apparently the README claims that things like ~mini and ~nightly work, but they aren't currently implemented in the Rust rewrite. Maybe they wouldn't be too hard though?
cc @jonas-schievink

Ah these actually didn't exist in the python version. I've implemented them in #187, but then removed them to keep the same interface.

Ah ok, I'll leave this open to update the README then

Ok, updated README


Add support for cuDF

First off, I love this library, you've done an awesome job for creating it!
Secondly, can you add support for cuDF dataframes?

Thanks. Glad you find it helpful.
I'll need to look at the differences between cuDF and pandas dataframes. I'm aware of cuDF but have not used them.  Let me look into it and see.

Hi @chris1610 ! I just came across this issue due to the cuDF mention. This looks like a really cool project.
Happy to help answer any questions about cuDF if useful.


Make the backend configurable

Currently we support only Kubernetes backend.
But some users still require to use their existing backends like S3 or Dynamo tables outside Kubernetes.
It would be great to make the backend configurable to support those existing systems.
Here's a possible API design for custom backend.
---
apiVersion: infra.contrib.fluxcd.io/v1alpha1
kind: Terraform
metadata:
  name: tf-controller-ng-cc5a1ac4
  namespace: flux-system
spec:
  interval: 1h
  path: ./_artifacts/20-zz-terraform
  approvePlan: "auto"
  backend:
    customConfiguration: |
      backend "s3" {
        bucket = "mybucket"
        key    = "path/to/my/key"
        region = "us-east-1"
      }
  varsFrom:
  - kind: Secret
    name: aws-vars
  sourceRef:
    kind: GitRepository
    name: flux-system
    namespace: flux-system

Hi, I am interested in working on this

Thank you @fsequeira1

@fsequeira1 have you got a chance to tackle this issue please?

@chanwit it is not forgotten but still haven't got an opportunity to work on it

Thank you, @fsequeira1.
I just wanted to check about it, as it's also in the roadmap of Q1, which is 15 days left.
But I can postpone it to Q2 if you think it won't be landing by the Q1 milestone.
Please feel free to let me know which one works for you.

@chanwit I think it's better to postpone to Q2 but I will try to deliver it asap

Thank you @fsequeira1
I'll move it to Q2.

@fsequeira1 here's a design of the customDefinition block that could help you speeding things up.
Please define customDefinition as *string and if it's specified, you can dump the whole string to override the backend block, for example.
---
apiVersion: infra.contrib.fluxcd.io/v1alpha1
kind: Terraform
metadata:
  name: tf-controller-ng-cc5a1ac4
  namespace: flux-system
spec:
  backend:
    customConfiguration: |
      backend "s3" {
        bucket = "mybucket"
        key    = "path/to/my/key"
        region = "us-east-1"
      }

Assuming this implies Terraform Remote Backends, as listed here ?
If so, +1 for S3 and Consul as they are the most common backends in my experience with customers.

Yes it is

@fsequeira1 have you got any update on this please?

@chanwit I can create a pr with the backend part, but it still lacks validation of the backend and support for secrets.

fixed by #288


Deprecated Gradle features (Gradle 7.x)

Seeing this warning when building with Gradle 7.2:
Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

Running with --warning-mode all:
The JavaExec.main property has been deprecated. This is scheduled to be removed in Gradle 8.0. Please use the mainClass property instead. See https://docs.gradle.org/7.2/dsl/org.gradle.api.tasks.JavaExec.html#org.gradle.api.tasks.JavaExec:main for more details.

Any news on this @ph4r05?
As main is used, the plugin is incompatible with Gradle 8 where the method is removed.

There are also other deprecations that need to be taken care of, like accessing project at execution time.


Add a Read-Write Allow API to libtock_platform.

This API and implementation are very similar to the Read-Only Allow API in https://github.com/tock/libtock-rs/pull/348.

bors r+


Review changes for #307

Correcting typos in tutorial notebook of https://github.com/NeuralEnsemble/elephant/pull/307 and changing notebook status to non-executed.

please open a PR from within INM-6
or merge it on your own
also, we need to check that readthedocs builds
and I cannot do this because you've pushed it from your user account

here is the build failure https://readthedocs.org/projects/elephant-docs-development/builds/10706169/
so it cannot execute this particular tutorial
please revert back the changes concerning cell outputs removal
or execute it on your own and remove all warnings

sorry, now there's a merge conflict with your recent updates in the notebook. Let me see if I can solve this manually...


Unexpected incompatible type

I wrote codes with the maybe feature like this:
-module(test_eqwalizer).

-feature(maybe_expr, enable).

-export([main/1]).

-spec main(Args :: list(binary())) -> {ok, binary()} | {error, any()}.
main(Args) ->
    maybe
        true ?= (length(Args) =/= 0) orelse {error, empty_args},
        true ?= is_binary(lists:last(Args)) orelse {error, badargs},
        {ok, <<"ok">>}
    end.

I suppose the type spec is correct. However, the eqwalizer reports the error incompatible_types.
The entire output is as below:
error: incompatible_types
   ┌─ src/test_eqwalizer.erl:11:17
   │
11 │         true ?= (length(Args) =/= 0) orelse {error, empty_args},
   │                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   │                 │
   │                 _ orelse _.
Expression has type:   'true' | {'error', 'empty_args'}
Context expected type: {'ok', binary()} | {'error', term()}

See https://fb.me/eqwalizer_errors#incompatible_types
   │

  'true' | {'error', 'empty_args'} is not compatible with {'ok', binary()} | {'error', term()}
  because
  'true' is not compatible with {'ok', binary()} | {'error', term()}
  because
  'true' is not compatible with {'ok', binary()}

error: incompatible_types
   ┌─ src/test_eqwalizer.erl:12:17
   │
12 │         true ?= is_binary(lists:last(Args)) orelse {error, badargs},
   │                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   │                 │
   │                 _ orelse _.
Expression has type:   'true' | {'error', 'badargs'}
Context expected type: {'ok', binary()} | {'error', term()}

See https://fb.me/eqwalizer_errors#incompatible_types
   │

  'true' | {'error', 'badargs'} is not compatible with {'ok', binary()} | {'error', term()}
  because
  'true' is not compatible with {'ok', binary()} | {'error', term()}
  because
  'true' is not compatible with {'ok', binary()}

2 ERRORS

Could you please give me an explanation ?

To support this example, we need complex reasoning about patterns and types to eliminate the types matched by the left hand side of ?= from the right hand side.
This is something we currently do not support but would like to, although it is very difficult in the general case (where the pattern is more complex than an atom).
I plan to investigate this during the coming year.

I plan to investigate this during the coming year.

@VLanvin isn't this needed for maybe support? In the meantime should we have eqwalizer not run in maybe blocks? Or all maybe blocks will need % eqwalizer:fixme comments?

isn't this needed for maybe support? In the meantime should we have eqwalizer not run in maybe blocks? Or all maybe blocks will need % eqwalizer:fixme comments?

A lot can already be done with maybe blocks and eqWAlizer, such as binding variables via patterns, e.g., {ok, V} ?= foo(Arg). The type of V here will be correctly refined according to the spec of foo/1.
More complex behaviour that mixes predicates, patterns, and booleans such as what is being proposed here, is what is not supported currently.
I don't think it's worth disabling eqWAlizer in maybe blocks for such cases, as we can indeed use % eqwalizer:fixme comments. If the use-case becomes too frequent, then we can re-consider.


Cherry pick refactor_docs

Signed-off-by: nshankar13<EMAIL_ADDRESS>

We don't need to backport these changes individually. I suggest just merging main to release-v0.11 as more doc changes are made.


Use local disk datastore and merge with EC2 user-data

Is it possible to have a datastore which reads cloud-init user-data on local disk, one we've baked into the AMI we're building from, and have that merge/append to the EC2 user-data that has been supplied?
We would like to enforce cloud-init config in the AMI, but still allow user specified user-data in the EC2 instance to take effect.
Apologies if this is a well documented feature, I've had no luck finding examples of this.

Just realised this isn't the official cloud-init repo, apologies.


Always test broadcast in copyto

Fix #6115.
This PR is based on #6118 because https://github.com/cupy/cupy/issues/5848#issuecomment-972480441

#6118 is merged.

Jenkins, test this please.

Jenkins, test this please.


Make a bunch of changes to improve coverage

Proposed Changes

Remove some sweeping exclusions in .coveragerc
Add more tests for translation.dio package
Remove some redundant paths in factory.py
Remove some unnecessary import forwarding
Add add_length_ratio_term arg to score_functions.modified_hamming (was always True)
Extract as_list function for wrapping in/casting to list
Add line-level ignores elsewhere (mostly user-friendly errors)

Codecov Report

Merging #93 (d65982b) into master (5052577) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            master       #93    +/-   ##
==========================================
  Coverage   100.00%   100.00%
==========================================
  Files           34        54    +20
  Lines         1569      1833   +264
  Branches       225       271    +46
==========================================
+ Hits          1569      1833   +264

Impacted Files
Coverage Δ

src/rics/translation/dio/_single_value.py
100.00% <ø> (ø)

src/rics/mapping/score_functions.py
100.00% <100.00%> (ø)

src/rics/translation/_translator.py
100.00% <100.00%> (ø)

src/rics/translation/dio/_pandas.py
100.00% <100.00%> (ø)

src/rics/translation/dio/_sequence.py
100.00% <100.00%> (ø)

src/rics/translation/factory.py
100.00% <100.00%> (ø)

src/rics/utility/__init__.py
100.00% <100.00%> (ø)

src/rics/utility/collections/misc.py
100.00% <100.00%> (ø)

src/rics/translation/fetching/__init__.py
100.00% <0.00%> (ø)

src/rics/translation/offline/__init__.py
100.00% <0.00%> (ø)

... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us.


Boost quick access window score to stay on top && make result distinct

@jjw24 please take a look.

the only issue with just checking on title is if you open same web page a couple of times, they will all have the quick access key appended even though only one of them have been assigned

the only issue with just checking on title is if you open same web page a couple of times, they will all have the quick access key appended even though only one of them have been assigned

Well I believe they will have differnent title name, because the title name is not the process name.

You were saying...?    😛

I dont think there is a way to identify that an opened window is the same cached window

You were saying...?    😛

Emmmm🤔

I dont think there is a way to identify that an opened window is the same cached window

Yeah, because they should be different reference. Comparing title or maybe include subtitle may be enough I think. Though at some specific situation it will not be matched.

I add the gitignore to avoid adding things from .vscode (vs is sometimes too slow for me for a simple edit🤣🤣)

Yeah let's leave the issue where there could be duplicate windows eg. duplicate web pages for now, it will just appened the quick shortcut both. One downside is you could be typing in one dup page, tab out, then quick shortcut back to the other dup page where you were not typing on.
If there is a way to distinguish/resolve this then we can pr it later.


How to use this as a package?

@ismailelbadawy  this configuration of setup.py has worked for me:
from setuptools import setup

setup(
    name='SOcial ANalysis',
    url='',
    author='Maarten Grootendorst',
<EMAIL_ADDRESS>    #packages=['soan'],
    description='Used to analyze whatsapp data',
    long_description=open('README.md').read(),
    install_requires=['numpy', 'Pillow', 'scipy', 'sklearn', 'regex', 'emoji', 'seaborn',
                     'datetime', 'pandas', 'requests', 'wordcloud', 'pattern', 'palettable'],
    version='0.1',
    license='MIT',
)

NOTE:  I had issues with some dependencies of requests (particularly with mysql-config package). Running sudo apt-get install libmysqlclient-dev did the trick.

Thank you @natlachaman . That did the trick.


Fix error in the regular expression to find added/removed ips

Error in regular expressions in General class (general.py):

added_ip_re
removed_ip_re

To fix this bug, you need to change the part of the regular expression string from (?=\D) to (?=(?!/)\D).

The decision was not efficient. Also added_net_re and removed_net_re are involved.
To fix this bug for added_ip_re and removed_ip_re:

(?=\D) --> (?=(?!/)\D|$)

To fix this bug for added_net_re and removed_net_re:

(?=\D) --> (?=\D|$)


fix: handle chrome's pretty print button

Trying to fix #340
I tested it locally, and it works.
A way to build that worked for me:

use node v10 - fnm use 10 or nvm use 10
npm i and ignore node-gyp errors
npm run release (builds minified files) and load unpacked like stated in the readme file

I tested your update and it works perfectly for me in Chrome Version 117.0.5938.62 (Official Build) (arm64).
It definitely would be good to update the sass version at some point to get rid of that crusty old node-gyp dependency that caused so many years of pain.

Thanks for the PR. Im planning to address the issue this weekend

@bukowskiadam do you think it would be a good idea to retrieve the first 'pre' node using a simple for loop? just in case they go crazy with more elements in the future.

@chinhoe I think there is more to improve in the code. Now, with my fixed code, I get two scrollbars like this 👇🏻

Looping over elements might break some pages as I did blindly removing the first element if it's not a PRE. Every direct child (body > pre) would be then a victim.

we understand again in these few days that the plugin is very useful 😄 when will the pr be merged?

True story, closing. I confirm that the newest stable chrome is back to normal because they got rid of the checkbox. Thank you all for the attention!

I think the Pretty Print checkbox is back in the latest Chrome update?


Add support for downloads metadata

Description
Add support for "downloads" metadata
Motivation and Context
fixes #120
Types of changes

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the code style of this project.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

@whmilton @mralexgray what do you guys think?

going to merge from no response 😞

Pssh, no need for a sad face! When in doubt, merge! I am juggling a bunch of open source projects and while I do try to catch up on GH issues on weekends, I can't always. So my response time can be like 1~2 weeks. Anyway, I think download counts sound useful!
I did notice you changed one place to using template strings... but now that I'm looking into it support for template strings has been in Node since version 4.0?! So I'm totally cool with that.

😄 yeah template strings are cool!
No problem! Just pulling your strings, I am working on the react part of this over the weekend. Excited to keep working on this project!


Unable to build for Fedora 23 on a Fusion VMWare VM

I have a brand new VM with Fedora 23, using VMWare Fusion on a Mac.
In addition to your script, I also need to install the python-devel. After patching the lib64/lib for python, the build eventually run into errors with no install package being built.

Testing Time: 1899.72s

Failing Tests (1):
Swift :: stdlib/FloatingPointConversionTraps.swift.gyb
Expected Passes    : 6968
Expected Failures  : 100
Unsupported Tests  : 623
Unexpected Failures: 1
*** Failed while running tests for swift (check-swift-all-linux-x86_64)
utils/build-script: command terminated with a non-zero exit status 1, aborting
utils/build-script: command terminated with a non-zero exit status 1, aborting
I plan to run "utils/build-script -t" separately to see if there are any diagnostic why the thing aborted.

[1056/1922] Linking CXX shared library lib/libLTO.so
FAILED: : && /usr/bin/clang++  -fPIC -fPIC -fvisibility-inlines-hidden -Wall -W -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wcovered-switch-default -Wnon-virtual-dtor -std=c++11 -fcolor-diagnostics -g  -Wl,-z,defs    -Wl,--version-script,/home/kelvinchan/tmp/swiftbuild/build/Ninja-DebugAssert/llvm-linux-x86_64/tools/lto/LTO.exports -shared -Wl,-soname,libLTO.so -o lib/libLTO.so tools/lto/CMakeFiles/LTO.dir/LTODisassembler.cpp.o tools/lto/CMakeFiles/LTO.dir/lto.cpp.o  lib/libLLVMX86CodeGen.a lib/libLLVMX86AsmPrinter.a lib/libLLVMX86AsmParser.a lib/libLLVMX86Desc.a lib/libLLVMX86Info.a lib/libLLVMX86Disassembler.a lib/libLLVMARMCodeGen.a lib/libLLVMARMAsmPrinter.a lib/libLLVMARMAsmParser.a lib/libLLVMARMDesc.a lib/libLLVMARMInfo.a lib/libLLVMARMDisassembler.a lib/libLLVMAArch64CodeGen.a lib/libLLVMAArch64AsmPrinter.a lib/libLLVMAArch64AsmParser.a lib/libLLVMAArch64Desc.a lib/libLLVMAArch64Info.a lib/libLLVMAArch64Disassembler.a lib/libLLVMCore.a lib/libLLVMLTO.a lib/libLLVMMC.a lib/libLLVMMCDisassembler.a lib/libLLVMSupport.a lib/libLLVMTarget.a lib/libLLVMX86CodeGen.a lib/libLLVMX86Desc.a lib/libLLVMX86AsmPrinter.a lib/libLLVMX86Utils.a lib/libLLVMX86Info.a lib/libLLVMARMDesc.a lib/libLLVMARMAsmPrinter.a lib/libLLVMARMInfo.a lib/libLLVMAsmPrinter.a lib/libLLVMSelectionDAG.a lib/libLLVMAArch64Desc.a lib/libLLVMAArch64AsmPrinter.a lib/libLLVMAArch64Info.a lib/libLLVMMCDisassembler.a lib/libLLVMAArch64Utils.a lib/libLLVMCodeGen.a lib/libLLVMTarget.a lib/libLLVMInstrumentation.a lib/libLLVMBitWriter.a lib/libLLVMLinker.a lib/libLLVMObjCARCOpts.a lib/libLLVMipo.a lib/libLLVMScalarOpts.a lib/libLLVMInstCombine.a lib/libLLVMProfileData.a lib/libLLVMObject.a lib/libLLVMMCParser.a lib/libLLVMMC.a lib/libLLVMBitReader.a lib/libLLVMVectorize.a lib/libLLVMTransformUtils.a lib/libLLVMAnalysis.a lib/libLLVMCore.a lib/libLLVMSupport.a -lrt -ldl -ltinfo -lpthread -lz -lm -Wl,-rpath,"$ORIGIN/../lib" && :
clang: error: unable to execute command: Killed
clang: error: linker command failed due to signal (use -v to see invocation)
I suspect this clang got killed on linking because of memory. Will need to set higher memory for VM and retry...

I found that the main swift build script does not always pass the number of  threads to all sub components.  So some steps in the build may be using  the default for ninja which i have found to be very stressfull for low resource systems. I can successfully build on a machine with an 4core/4hyperthread  processor and 12g of ram.
It should be noted that my script is pulling the master branch, which is often broken,  i usualy wait 12 hours after it fails, update and run it again.  Once they get to a stable tag on 2.2 i will switch it to that one.

I reconfigured my fedora VM to a modest 4gb ram and 2 core, and it apparently further built without any "obvious" errors. I see there's a ~/tmp/swiftbuild/package/wift-linux-x86_64-fedora-2015-12-25--22:50:24.tgz and a usr/bin/swift. I will test and play with it. Thanks a whole lot putting this together. I would also like to try the package/tar other "fedora-like" dist.

Note: From a brand new VM from Fusion, I will need to yum install python-devel, as well as edit the script at the lines concerning git and change to:
https://github.com/apple/swift.git swift
etc.
etc.

I will update the script for the python-devel  dependancy, if you get it to compile on other redhat/centos/fedora distros then letme know and i will add it to the readme, i have only really tested it on fedora 22 and fedora 23.

All your changes have been incorporated, plus I have managed to eliminate the need to run the "patch" process by symlinking the directories needed to be patched before the build.


Respect page units when current transformation matrix is passed to cairo

Fixes #545. Also fixes a typo in cairo_SetWorldTransform where input 'matrix' argument was not used.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: shibaev sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@monojenkins build Mono Jenkins Windows

@monojenkins build Mono Jenkins Linux


DRILL-5098: Improving fault tolerance for connection between client a…

…nd foreman node.
     Note: Adding tries config option in connection string.
           Improving fault tolerance in Drill client when trying to make first connection with foreman.
           The client will try to connect to min(tries, num_drillbits) unique drillbits unless a successfull
           connection is established.

+1


Looking for refund

Hello,
Please cancel my subscription and provide a refund—the Bolt. New app is not prod-ready, and the generated Next.js app is full of errors.
Thank you.

Same here.

They still haven't replied to me about anything.

@ccharade has been refunded.
@yrkh please email<EMAIL_ADDRESS>for refund requests, thanks!

I sent an email for a refund too, haven't heard from them.
I've successfully repeated the same task and prompt for about 15 to 20 times with the same result, after getting a message about successfully implementing the changes, which isn't true. Ended up wasting millions of tokens

Hi Utibe, what a waste of time!  I have been told I am being refunded. When it shows up on my bank statement, I'll post an update.

Same here. asked for a refund in the above email. The tool is no near close production level tool. It's absolute garbage in terms of code it produces. lost 3 days trying to make it work. keeps giving me crap. i followed every best practice out there

@utibe-ettebong

Refund please too. İ get maximum tokens limit error i bought 200 dollar package. I cant develop waste of time

I want tooo..
200$ packages...but bolt..is not ready...

The below mail was sent to you on 30.11.2024
I would like to inform you that I did not intend to continue using your subscription service for the new term. However, as I did not cancel the subscription in time, an amount of [20 usd ] has been deducted from my account.
I kindly request your consideration in this matter and ask for a refund of the charged amount. Please let me know if any further information is required to process my request.
Thank you in advance for your understanding and support.

Hello, I hope this message finds you well. I am writing to request a refund for a subscription charge that was applied to my account in error. But no one return information.


[Bug] Minor - podkrepi.bg/Home page button "Включи се" should be the same color like the standard "Напред"/"Назад" navigation buttons

Describe the bug
At page podkrepi.bg/Home page button "Включи се" should be the same color like the standard "Напред"/"Назад" navigation buttons
To Reproduce
Steps to reproduce the behavior:

Go to podkrepi.bg/Home page
Scroll down to "Подкрепи ни като":

Expected behavior
Включи се" should be the same color like the standard "Напред"/"Назад" navigation buttons
Screenshots

Desktop (please complete the following information):
OS: Windows 10
Browser Edge
Version Version 98.0.1108.50 (Official build) (64-bit)
Additional context
Verified with UX alexvtomov

I think we could close this issue since it refers to the old appearance of Homepage which is no longer valid.
@kachar, could you please confirm?