fix: should not be able to set welcome message for threads created from policy room

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/29454
PROPOSAL: https://github.com/Expensify/App/issues/29454#issuecomment-1759813271
Tests

Go to a policy room like #admins
Send a message in the room.
Create a thread A from the message.
Click on the report header.
Click on settings.
Verify that "Set welcome message" is not shown here
Back to that thread A, go deeplink by adding: /welcomeMessage
Verity that Not found page is displayed

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to a policy room like #admins
Send a message in the room.
Create a thread A from the message.
Click on the report header.
Click on settings.
Verify that "Set welcome message" is not shown here
Back to that thread A, go deeplink by adding: /welcomeMessage
Verity that Not found page is displayed

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/129500732/2ceb06aa-a63f-4dd0-86ef-43a09eaa0d66

Android: mWeb Chrome
https://github.com/Expensify/App/assets/129500732/689ccb75-f3de-4e86-b1e1-2da7c5b6d86a

iOS: Native
https://github.com/Expensify/App/assets/129500732/b0a55eed-5930-4417-ace1-4ab65b6f9c97

iOS: mWeb Safari
https://github.com/Expensify/App/assets/129500732/b887961b-f6e9-49f9-9bb1-fe1d29a05a77

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/129500732/87c59955-1d8b-4bb0-9111-59660dceec4f

MacOS: Desktop
https://github.com/Expensify/App/assets/129500732/e1d19e9a-dc09-4eb2-950e-2fb349420ba1

Please pull main when ready for next review

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/108292595/644455ed-eb53-4af8-a0b8-b9d8a9d2074a

Android: mWeb Chrome
https://github.com/Expensify/App/assets/108292595/91ab7aa7-4c06-4d46-b9a4-763d1d8216e0

iOS: Native
https://github.com/Expensify/App/assets/108292595/c30de8db-e71a-47ae-8728-ad9837152ced

iOS: mWeb Safari
https://github.com/Expensify/App/assets/108292595/4d96f403-055a-4c2b-a8d6-2751fe9bcad2

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/108292595/4450dcbf-df20-4abc-b446-bf908d40c517
https://github.com/Expensify/App/assets/108292595/afda5ee1-b761-49cd-8e47-9f71d2377734

MacOS: Desktop
https://github.com/Expensify/App/assets/108292595/6650b2cb-5e35-49fa-bf98-c6a5300aa4e3

@dukenv0307 please pull main to fix author checklist failure

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.0-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Misc fixes

Fixes the sync version -- it wasn't updated w/ Windows & new globrex changes

Fixes the new "giveup" -- there was a typo & can't strict-compare regex against string

Added extra test for shits & giggles (because this was the use case that was failing for me)

globster ... nice one Terkel.
Thanks a lot Luke!


chore(release) Deduplicating grep-kong-version.sh script

Summary
Currently this script lives in both the kong and kong-ee repos, but we only use it in those repos to pass the Kong version to KBT.
Full changelog
N/A
Issue reference
Depends on https://github.com/Kong/kong-build-tools/pull/557
Fixes FT-3166

@bungle @dndx Can one of you please hit the merge button?


fix(sh,zsh): here document

Consider the following shell file:
cat << EOF
EOF extra
# zsh syntax thinks the above line is the end of heredoc
EOF
# sh syntax thinks the above line is the end of heredoc even if it has trailing space
the below is the actual EOF
EOF

(GitHub also misunderstands)
From https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_07_04,

The here-document shall be treated as a single word that begins after the next  and continues until there is a line containing only the delimiter and a <newline>, with no <blank> characters in between.

Therefore a shell must print the heredoc part, i.e. the body except for the first and the last lines.
dash <IP_ADDRESS>, bash 5.0, and zsh 5.8 behaves as such on Ubuntu 20.04.5 LTS.

Note that this does not work with:
echo `cat << EOF
backtick following EOF seems allowed
EOF`

# echo $(cat << EOF
# paren following EOF seems disallowed
# EOF)

I'll include the changes for your first test case. The second one, with a backtick expression, is difficult.

@cecamp regarding<<- EOF syntax, the leading tabs are ignored.

the zsh part is already part of https://github.com/chrisbra/vim-zsh/blob/master/syntax/zsh.vim please confirm. If yes, please remove this part from your PR here. I'll send updated zsh files to Bram in a bit.

zsh patch is removed.

I tried the example from the first message:
cat << EOF
EOF extra
# zsh syntax thinks the above line is the end of heredoc
EOF
# sh syntax thinks the above line is the end of heredoc even if it has trailing space
the below is the actual EOF
EOF

and it seems to work fine for shell syntax. So let me close it.


Clean up debug output and add FQ object names

This removes log noise and outputs full object names.

@ostromart: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
2380bf510c39a244783b4529bde56b42f14db998
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
2380bf510c39a244783b4529bde56b42f14db998
link
/test integ-telemetry-k8s-tests_istio

unit-tests_istio
2380bf510c39a244783b4529bde56b42f14db998
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
2380bf510c39a244783b4529bde56b42f14db998
link
/test integ-telemetry-k8s-tests_istio

unit-tests_istio
2380bf510c39a244783b4529bde56b42f14db998
link
/test unit-tests_istio

integ-local-tests_istio
2380bf510c39a244783b4529bde56b42f14db998
link
/test integ-local-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
2380bf510c39a244783b4529bde56b42f14db998
link
/test integ-telemetry-k8s-tests_istio

unit-tests_istio
2380bf510c39a244783b4529bde56b42f14db998
link
/test unit-tests_istio

integ-local-tests_istio
2380bf510c39a244783b4529bde56b42f14db998
link
/test integ-local-tests_istio

integ-distroless-k8s-tests_istio
2380bf510c39a244783b4529bde56b42f14db998
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
2380bf510c39a244783b4529bde56b42f14db998
link
/test integ-telemetry-k8s-tests_istio

unit-tests_istio
2380bf510c39a244783b4529bde56b42f14db998
link
/test unit-tests_istio

integ-local-tests_istio
2380bf510c39a244783b4529bde56b42f14db998
link
/test integ-local-tests_istio

integ-distroless-k8s-tests_istio
2380bf510c39a244783b4529bde56b42f14db998
link
/test integ-distroless-k8s-tests_istio

release-test_istio
2380bf510c39a244783b4529bde56b42f14db998
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@ostromart: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
2380bf510c39a244783b4529bde56b42f14db998
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

In response to a cherrypick label: new pull request created: #21677


Maybe a BUG

In the model.py seems exits a bug.This part below returns a float for reshape but reshape just accept int32. seems need to convert
def conv_out_size_same(size, stride): return math.ceil(float(size) / float(stride))
@carpedm20

This is fixed. Thanks for report

Hi
After resolving this issue, it is still not testing. I have trained on my own dataset. Why it is not taking while testing?


New package: WAAMTools v0.1.0

Registering package: WAAMTools
Repository: https://github.com/Jarrod-Angove/WAAMTools.jl
Created by: @Jarrod-Angove
Version: v0.1.0
Commit: d2f09573735a304ffafd90c42aaf4730aafbbdea
Git reference: HEAD
Release notes:

Initial release. Very early in development, but I want to share it with some colleagues.

This is a julia package that is intended to make the day-to-day data crunching at the university of Alberta WAAM lab a little easier.

It doesn't sound like this should be registered in the General registry, see https://github.com/JuliaRegistries/General#should-i-register-my-package-now.
I would strongly recommend making your own registry. It's a lot less scary than it sounds.

This is a julia package that is intended to make the day-to-day data crunching at the university of Alberta WAAM lab a little easier.

It doesn't sound like this should be registered in the General registry, see https://github.com/JuliaRegistries/General#should-i-register-my-package-now.
I would strongly recommend making your own registry. It's a lot less scary than it sounds.

You are totally right, I got a little lost and confused, but I figured it out after failing the automated merge. Thanks for the help!


Base option in loader's config

It would be nice to have base option in loader's config in order to be able to set twig templates base path. This request is similar to this in twig.js.

Resolving (aka finding) other twig templates is done with webpack itself, loaders shouldn't be responsible for that. Please take a look at https://github.com/webpack/docs/wiki/configuration#resolveroot

Thank you for your response.
I've checked your suggestion and it's not working with, for instance, twig include statements.
Consider the following structure:
/templates/
    a.twig
    b.twig

If I put {% import './templates/b.twig %} in a.twig it will search b.twig in /templates/templates/b.twig relative to a.twig no matter how root is resolved.
Check this line: https://github.com/zimmo-be/twig-loader/blob/master/lib/compiler.js#L12
resourcePath is the path of the current file.
In my example resourcePath = 'templates' and token.value = './templates/b.twig' so path.resolve(path.dirname(resourcePath), token.value) = '/templates/templates/b.twig'

I doubt your example would work even in plain Javascript. Why not just put ./b.twig ?
Even if there's a bug with generating the hash, I think adding a base option to the loader would be a bad solution to the problem...

Why not just put ./b.twig ?

You see, I'm using twig to render templates both on frontend and backend sides (with php).
On the backend I've set my template path in Twig_Loader_Filesystem.
If I'll use ./b.twig in my a.twig - backend script will be using a path relative to the base path, which is set in  Twig_Loader_Filesystem , i.e. /b.twig, while frontend script will be using path relative to a.twig, i.e /templates/b.twig

I doubt your example would work even in plain Javascript.

I've managed to make it work by modifying compiler.js and loader.js. In case you're interested I can submit a PR.

Even if there's a bug with generating the hash, I think adding a base option to the loader would be a bad solution to the problem...

I agree, maybe it's not a best solution. Not to mention I had to overload Twig.compiler.compile method in order to pass base option to compiler.js. On the other hand I couldn't find any other solution to my problem. And twig.js also has base option for this scenario.


Rename usages of 'package' to 'module' in CLI commands and compiler

Purpose

This PR will rename all usages of 'package' to 'module' in CLI commands and compiler

Security checks

Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes
Ran FindSecurityBugs plugin and verified report? yes
Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes

Closing this PR since there are other changes which needs to be incorporated to the same PR. Will open another PR after the changes are finalized.


Clock Timer not firing in Samsung SM-T500 series

Describe the bug

If you study the attached AIA file with an Samsung SM-T500 series (which is what we recommended to Hong Kong and Sure Start) you will notice that the clock timer is not firing regularly as it should.  Interestingly the same project in iPhone seems to be working (aside from layout issues)
TimerTest.aia.zip
Affects

[ ] Designer
[ X] Blocks editor
[ X] Companion
[ ] Compiled apps
[ ] Buildserver
[X ] Debugging
[ ] Other... (please describe)

Expected behavior

The app is designed so that if the device is tilted (non-zero x y acceleration) then the ball rolls and the timer starts firing and changing the score and when the device is level and not moving (near zero x y acceleration) the timer is disabled and scoring stops.
A student (Pravin Paz) in the Master Trainers program wanted to see how this can be done.
There might be other tablets this bug also affects but it is worrisome that the Samsung model we recommended to hundreds of kids is failing in this relatively simple task.
Please advise.
Steps to reproduce

When you run the app the ball moves but the score does not change and timer does not fire.

@stezelMIT, the same issue I have seen on Samsung community. here, I am attaching the link of the post please check this and follow the steps mention there...

https://eu.community.samsung.com/t5/galaxy-s9-series/timer-issues-in-clock/td-p/1303118
https://eu.community.samsung.com/t5/galaxy-s21-series/google-clock-app-no-sound-on-completion-of-timer/td-p/4397258


Updates to dot release process

The idea is to release in about a week. When the bug list is ready the release is started at T-7. There are no previous dates, e.g. T-15. I can reduce the dates to start maybe at T-5, but just wanted to make sure there is enough time for bug fixing and testing.

@amyblais Propose we shorten the dot release cycle as much as possible. If we used this for 4.10.1, I think we'd release on or around the same date and I'd prefer it was half of that to push bug fixes out quicker.
Maybe we try shortening the proposal by half and try it out? We can always adjust it.
Other notes

why the 3-day separation between code complete and RC cut?
which day Once bug fix release is ready to cut: is this targeted for?

Otherwise the plan looks quite solid 👍


Call service failure

System Health details
System Information

version
core-2023.3.6

installation_type
Home Assistant OS

dev
false

hassio
true

docker
true

user
root

virtualenv
false

python_version
3.10.10

os_name
Linux

os_version
5.15.90

arch
x86_64

timezone
America/New_York

config_dir
/config

Home Assistant Community Store

GitHub API
ok

GitHub Content
ok

GitHub Web
ok

GitHub API Calls Remaining
5000

Installed Version
1.31.0

Stage
running

Available Repositories
1246

Downloaded Repositories
24

Home Assistant Cloud

logged_in
true

subscription_expiration
April 20, 2023 at 8:00 PM

relayer_connected
true

remote_enabled
true

remote_connected
true

alexa_enabled
false

google_enabled
true

remote_server
us-east-1-3.ui.nabu.casa

can_reach_cert_server
ok

can_reach_cloud_auth
ok

can_reach_cloud
ok

Home Assistant Supervisor

host_os
Home Assistant OS 9.5

update_channel
stable

supervisor_version
supervisor-2023.03.3

agent_version
1.4.1

docker_version
20.10.22

disk_total
30.8 GB

disk_used
9.9 GB

healthy
true

supported
true

board
ova

supervisor_api
ok

version_api
ok

installed_addons
Home Assistant Google Drive Backup (0.110.3), Terminal & SSH (9.6.1), File editor (5.5.0), Google Assistant SDK (2.5.0), NGINX Home Assistant SSL proxy (3.2.0), Simple Scheduler (2.1), Samba share (10.0.0), Mosquitto broker (6.2.0), Zigbee2MQTT (1.30.3-1), Cloudflared (4.0.14), Studio Code Server (5.5.6), Grafana (8.2.1)

Dashboards

dashboards
4

resources
19

views
17

mode
storage

Recorder

oldest_recorder_run
March 23, 2023 at 8:29 AM

current_recorder_run
April 1, 2023 at 5:21 PM

estimated_db_size
105.80 MiB

database_engine
sqlite

database_version
3.38.5

Checklist

[X] I have enabled debug logging for my installation.
[X] I have filled out the issue template to the best of my ability.
[X] This issue only contains 1 issue (if you have multiple issues, open one issue for each issue).
[X] This issue is not a duplicate issue of currently previous issues..

Describe the issue
Getting an error for "Failed to call service switch/turn_on.  'BlueprintDataUpdateCoordinator' object has no attribute 'api' when attempting to flip switch.integration_switch  Also noticing sensor.integration_sensor has the following in it "quia et suscipit suscipit recusandae consequuntur expedita et cum reprehenderit molestiae ut ut quas totam nostrum rerum est autem sunt rem eveniet architecto"  Not sure if it is related.
Reproduction steps
I copied all files over to a new folder in custom_components, added the integration and typed in my username and password for Pitboss.  I tried to flip the integration switch and received the error
Debug logs
Logger: homeassistant.components.websocket_api.http.connection
Source: custom_components/pitboss/switch.py:54
Integration: Home Assistant WebSocket API (documentation, issues)
First occurred: 12:16:16 AM (7 occurrences)
Last logged: 10:55:36 AM

[140501655326000] 'BlueprintDataUpdateCoordinator' object has no attribute 'api'
[140501624798704] 'BlueprintDataUpdateCoordinator' object has no attribute 'api'
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/websocket_api/commands.py", line 199, in handle_call_service
    await hass.services.async_call(
  File "/usr/src/homeassistant/homeassistant/core.py", line 1808, in async_call
    task.result()
  File "/usr/src/homeassistant/homeassistant/core.py", line 1845, in _execute_service
    await cast(Callable[[ServiceCall], Awaitable[None]], handler.job.target)(
  File "/usr/src/homeassistant/homeassistant/helpers/entity_component.py", line 213, in handle_service
    await service.entity_service_call(
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 686, in entity_service_call
    future.result()  # pop exception if have
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 961, in async_request_call
    await coro
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 726, in _handle_entity_call
    await result
  File "/config/custom_components/pitboss/switch.py", line 54, in async_turn_off
    await self.coordinator.api.async_set_title("foo")
AttributeError: 'BlueprintDataUpdateCoordinator' object has no attribute 'api'

Diagnostics dump
No response

Yes the integration is not ready for use yet. Most of the code is still just copied from the template.
I'm hoping to have a basic working version in the next week or two.

Yes the integration is not ready for use yet. Most of the code is still just copied from the template.
I'm hoping to have a basic working version in the next week or two.

Copy.  I was just looking around and seen the integration and got exited and wanted to try it.  Let me know if I can help with anything, I have a very basic understanding of HA, but I can test for you if needed.  Thanks for looking into this!

Okay, I pushed a proper release with basic implementation. It's still missing some features and I haven't tested everything yet, but feel free to give it a try. Any feedback (including things that are flat-out broken) is welcome!
(You should also be able to install via HACS as a custom repo)


Downt Downloads the Content Sometimes

Sometimes it give sthe error: Udemy Says : Resource not found. either you are not enrolled in course or server didn't respond with course information webpages. but after trying again with same command it starts downloading. (In this 3rd time).  FYI- i have changed my id, password and username
C:\Users\USERANME\Downloads\udemy-dl-master>python udemy-dl.py -u<EMAIL_ADDRESS>-p password https://www.udemy.com/learn-c-plus-plus-from-beginner-to-advanced/learn/v4/overview -r 480
[] : Downloading webpage..
[] : Extracting course information..
[] : Downloading 'learn c plus plus from beginner to advanced'.
[] : Trying to login as (EMAIL@mail.com)...
[+] : Logged in successfully.
[] : Downloading course information webpages ..
[-] : Udemy Says : Resource not found. either you are not enrolled in course or server didn't respond with course information webpages.
[] : Re-run udemy-dl against full course url (e.g :- https://www.udemy.com/course/learn/v4/overview)
[*] : Trying to logout now...
[+] : Logged out successfully.
C:\Users\USERANME\Downloads\udemy-dl-master>python udemy-dl.py -u<EMAIL_ADDRESS>-p password https://www.udemy.com/learn-c-plus-plus-from-beginner-to-advanced/learn/v4/overview -r 480
[] : Downloading webpage..
[] : Extracting course information..
[] : Downloading 'learn c plus plus from beginner to advanced'.
[] : Trying to login as (EMAIL@mail.com)...
[+] : Logged in successfully.
[] : Downloading course information webpages ..
[-] : Udemy Says : Resource not found. either you are not enrolled in course or server didn't respond with course information webpages.
[] : Re-run udemy-dl against full course url (e.g :- https://www.udemy.com/course/learn/v4/overview)
[*] : Trying to logout now...
[+] : Logged out successfully.
C:\Users\USERANME\Downloads\udemy-dl-master>python udemy-dl.py -u<EMAIL_ADDRESS>-p password https://www.udemy.com/learn-c-plus-plus-from-beginner-to-advanced/learn/v4/overview -r 480
[] : Downloading webpage..
[] : Extracting course information..
[] : Downloading 'learn c plus plus from beginner to advanced'.
[] : Trying to login as (EMAIL@mail.com)...
[+] : Logged in successfully.
[] : Downloading course information webpages ..
[] : Found (76) lectures ...
[] : Extracting (76/76) |========================================| 100.00%
[] : Downloaded course information webpages successfully..
[] : Trying to logout now...
[+] : Logged out successfully.
[] : Counting no of chapters..
[+] : Found ('19') chapter(s).

@RuthlessRuler this is not the problem but a simple handle to to server response. see issue #63 , i already have discussed this in details there so i 'm closing the issue.


Stage attribute to only overwrite if very explicitly stated

In some cases there may be stages that are statically creating/referring to files with defined (non parameterized) paths that should only run once. It may be desirable to prevent these from accidentally computing again if an --overwrite flag is specified.
There should be a ignore_overwrite=True attribute that can be given to the @stage decorator, which will only actually overwrite that stage if it is explicitly listed with --overwrite-stage
(e.g. it ignores the --overwrite only flag)

Alternatively could call it explicit_overwrite_only

I actually think the better way of handling this situation is to simply not return the object itself as an artifact, but rather manually compute/save the object within the stage and return the path to it as the artifact.
(I'm wary of further muddying up decorators and making overwrite rules more confusing.)

Re-opening this, I think with the addition of #113 it's more feasible to use cachers as a way of also tracking more singleton/less-single-experiment-specific outputs, which may entail wanting to ensure we don't accidentally overwrite things.
I think instead of ignore_overwrite though, it should be allow_overwrite, with a default value of True


PR: #761 - Add automatic NPM publish via Travis CI

Resolves #761
Checklist

[ ] I have made a material change to the repo (functionality, testing, spelling, grammar)
[x] I have read the [Contribution Guide] and my PR follows them.
[x] I updated my branch with the master branch.
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation about the functionality in the appropriate .md file
[ ] I have added in line documentation to the code I modified

Short description of what this PR does:
I added a Travis deploy config that uses lerna publish to automatically publish changed packages to NPM if a tagged commit was pushed on master branch (usually the result of running lerna version)
It creates a .npmrc in the $HOME folder so lerna publish knows where to publish the packages and which token to use. This is needed because the npm publish command is executed inside the packages/foo folder and we don't want to copy a .npmrc to every package folder. See https://github.com/lerna/lerna/issues/1705 for reference. ( Thanks @aslafy-z )
❗ For this to work the environment variable NPM_TOKEN has to be set. An admin with publish rights for the @sendgrid scope at NPM has to generate a new auth token and run the following command to add the encrypted variable to the Travis config. This PR should only be merged if this happened.
travis encrypt NPM_TOKEN="<NPM_AUTH_TOKEN>" --add

See the Travis CI Documentation for reference

I did some changes to the PR because I tested my configuration in an example repo.
You can see the Travis Jobs here: https://travis-ci.org/joostme/lerna-travis-test/builds/438322920
The only change I did is adding a condition to the deploy section to only run on node 8. The previous version would have executed the deployment for every node version configured in the .travis.yml. The example Travis pipeline above shows that it is only executed in the node 8 job.

Hello @joostme,Thanks again for the PR! It's HACKTOBERFEST! We want to show our appreciation by sending                                              you some special Hacktoberfest swag. If you have not already, could you please fill out                                              this form so we can send it to you? Thanks!                                             Team SendGrid DX

Hello @joostme,Thanks again for the PR!                                         You have earned 7 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.                                         Please take a moment to checkout this link to find more issues to get you past the required threshold or to simply continue the celebration.                                         Also, please be sure you have officially registered with us here by November 1, 2018 to qualify.                                         If you have any questions you can email us at<EMAIL_ADDRESS>                                        Thank you and Happy Hacktobering!                                         Team SendGrid

Resolved by 37473ad95a20258196d7cf256ea391508872d65e


EVM Integration

EVM Integration

Integrate Ethereum wallet and demonstrate Eth L1 and Base L2
Copy and paste solana plugin and recreate with EVM
Swapping action, wallet provider

Reward: $1500 USD in $degenai as seen on https://ai16z.github.io/

Gm @madjin
would love to work on this one.
Couple of questions and remarks:

Just need to figure our which services we want to use in Base/ETH. I suggest Aerodrome/Uniswap, but maybe using li.fi/enso/0x scales better.
What's good alternative for pump.fun on Base/Ethereum?


Button color with other skin

When I change the AdminLTE skin (I set it to blue), the header is set to the good color, but all buttons still purple.

You're right. Thanks!

You might want to republish your assets, or just see the modifications here and do them in your published backpack.base.css if you've already modified it.

Hi @tabacitu
Sorry but I have the same issue and not understand what to do exactly.
I republished my assets with php artisan backpack:base:install after I deleted adminlte and backpack folder in my public/vendor folder.
Or do I have to modify my backpack.base.css manually?


Badge status always "pending"

URL
package.json

There had been issue in past like #368 where status was stuck because of git dependency. I'm not using any sort of those dependencies still the dependencies status is stuck at "pending" forever.

Awesome! Thanks @alanshaw :rocket:


Thermostat on/off in Leaving water temperature mode

Hi all,
First of all, it is awesome what has been put together here!
I have a Rotex hpu hybrid (RHYHBH08AAV3) with a BRP069A61 lan module. All in all the system does not really run correctly. I am hoping that with this or perhaps the collected general knowledge someone can help me.
A few things about my system. It is used in a 2 family house, i have two hybrid cubes, the room heating uses leaving water temperature mode (room temperature mode does not provide enough heat, the controller is in the heating room and the Temperature is all over the place, it could be that i have not found the right settings). On my system the lan module gives me the SG1/2 contacts that are connected to the solar inverter. The intent was to use the extra solar energy to produce warm water. Unfortunately, if i am lucky, the heat produces warm water once a week using the smart grid function ( also in summer when the room heating is off). There is no reason as to when I runs.
From what I understand the thermo on/off only works using the room thermostat to set the leaving water temperature? Has anyone had success getting the BRP069A61 to work for producing warm water using the espaltherma as controller? If the x85a was also connected to espaltherma could that assist in forcing the system to produce warm water?
Any and all suggestions would be greatly appreciated!!!

Hi, I have a totally different setup, but the thermostat just enables room heating here. When thermostat = off, it's like the room heating being in summer mode. The actual heat pump still runs on auto pilot with thermostat enabled or disabled (i.e. It heats the water tank whenever the water in there gets too cold). I think what you want /need is smartgrid not thermostat? From your text above, the solar inverter commands are not understood by SG? Are you sure they are connected properly / compatible? The relevant on/off combinations for SG1/2 are shown in the wiki.

Ah, and you need to enable SG and thermostat in the Rotex settings menu. It may ignore it otherwise!

thanks for the quick answer!!
Yes, I am looking at getting the smart-grid function to work, my guess is also that the signal is not being interpreted correctly.  I am also looking at controlling the room heating a bit better (in terms of turning it off according to the weather forcast), but that is not the most important thing.
After all the trouble I have had with the system in trying to use the smart-grid function, anything is possible.
I am more than willing to look at everything again and test anything.
The BRP069A61 module (https://www.daikin.eu/content/dam/document-library/Installer-reference-guide/ctrl/BRP069A61, BRP069A62_4PEN464229-1_2017_08_Installer reference guide_English.pdf) is a bit different than what is described in ESpaltherma. I think that the principle should be the same.
The BRP069A61 has a SG0 and SG1, that are very similarly configured as the SG1/SG2.

From my understanding the SG0/1 are simple contact circuits that when closed are "turned on".  At least that is what the installer described it as. From the way it looks, using the Solar Inverter’s output switch when a specific amount of power is produced the Smart-grid tuns on/off. Also, when simply shorting the contacts connecting the SG0 contact 1 to the SG0 contact 2 the light also turns on and off. Who knows, there might be more logic / digital signal behind it.  Recently I have connected the ESPaltherma to the sg0/1 contact to relays controlled by ESPaltherma. The SG light turns on and off when SG commands are sent to the ESPaltherma.
My Rotex only has a "LAN module" installed setting that needs to be enabled and 4 other settings that so the communication with the Lan modul and the control is given to the Lan module. Those are set and i think it works otherwise the once a week usage of solar power would not be possible :)
thanks in advance!!

thanks again for the help.
the issue was fixed and the ESP including SG contacts work like a charm. The issue was that when Daikin installed and configured the Lan Module they changed some setting that made the heater prefer gas over the heat pump. After having a closer look at all the settings, the issue was found.


@envelop/response-cache clarify handling of null or empty values

Recently we've seen some issues with stale data coming from our GraphQL server. It's pretty green field so the general entities involved could be anything, so let's just say we have Product, Query.product and Mutation.createProduct:
type Query {
  products: [Product!]!
}

type Mutation {
  addProduct(input: ProductInput!): Product!
}

input ProductInput {
  name: String!
}

type Product {
  id: ID!
  name: String!
}

Whenever we handle createProduct, we invoke cache.invalidate([typename: "Product"]), so every operation related to Product would get invalidated - or so we thought. Turns out this only invalidates operations where a Product entity has been included in the response. If Query.products at some point returned an empty list, the response would not get invalidated on a subsequent Mutation.createProduct invocation. An exemplary test in response-cache.spec.ts should clarify:
  it('purges cached empty query operation execution result via imperative cache.invalidate api using typename', async () => {
    const spy = jest.fn(() => []);
    let id = 1;
    const schema = makeExecutableSchema({
      typeDefs: /* GraphQL */ `
        type Query {
          products: [Product!]!
        }

        type Mutation {
          addProduct(input: ProductInput!): Product!
        }

        input ProductInput {
          name: String!
        }

        type Product {
          id: ID!
          name: String!
        }
      `,
      resolvers: {
        Query: {
          products: spy,
        },
        Mutation: {
          addProduct(_, { input }) {
            const mockProduct = {
              id: id++,
              name: input.name,
            };
            return mockProduct;
          },
        },
      },
    });

    const cache = createInMemoryCache();
    const testInstance = createTestkit([useResponseCache({ session: () => null, cache })], schema);

    const query = /* GraphQL */ `
      query test {
        products {
          id
          name
        }
      }
    `;

    await testInstance.execute(query);
    await testInstance.execute(query);
    expect(spy).toHaveBeenCalledTimes(1);

    cache.invalidate([{ typename: 'Product' }]);

    await testInstance.execute(query);
    expect(spy).toHaveBeenCalledTimes(2);
  });

  ● useResponseCache › purges cached empty query operation execution result via imperative cache.invalidate api using typename

    expect(jest.fn()).toHaveBeenCalledTimes(expected)

    Expected number of calls: 2
    Received number of calls: 1

      532 |
      533 |     await testInstance.execute(query);
    > 534 |     expect(spy).toHaveBeenCalledTimes(2);
          |                 ^
      535 |   });
      536 |
      537 |   it('variables are used for constructing the cache key', async () => {

      at Object.toHaveBeenCalledTimes (packages/plugins/response-cache/test/response-cache.spec.ts:534:17)

Is there a recommended approach to this? I'm tempted to give a fix a try, but it'd rather wait for feedback because it might as well be intended design. Technically, I think we could parse the schema, track which fields have what type and use that to invalidate results with null / empty values.

Thank you for your very complete issue report :-)
You are right, the way the plugin is implemented today is based on visiting the result of the query execution instead of the request document. This is because a request can contain abstract types (like unions or interfaces) and the actual type can only be found by visiting the result of the execution.
That's a tradeoff, and I'm not sure which one between abstract types and empty responses are the most commonly found case.
Perhaps we could make our own visitor handling Lists and empty values differently. For now, it is based on @graphql-tools/utils's visitResult which just map over the values of the list, meaning we can't react to empty lists.

I don't want to make empty promises, but if I can make the time it'd like to at least fix it in a way that works for us and monkey patch it via patch-package. Would you be open to a contribution or would you rather work on it once you decide if it's worth implementing?


Sync feature branch with main

Description

PSA: Do not squash this commit unless we want to handle the conflicts a second time
A few notable changes.

I needed to add a replace statement to the callbacks go.mod (I think we can figure out how to remove it before we tag anything)
it is pulled in via the testing package

go: github.com/cosmos/ibc-go/modules/apps/callbacks tested by
        github.com/cosmos/ibc-go/modules/apps/callbacks.test imports
        github.com/cosmos/ibc-go/v8/testing imports
        github.com/cosmos/ibc-go/modules/light-clients/08-wasm/types: missing go.sum entry for module providing package github.com/cosmos/ibc-go/modules/light-clients/08-wasm/types (imported by github.com/cosmos/ibc-go/v8/testing); to add:
        go get<EMAIL_ADDRESS>

Because of the above, I needed to make our CI play nice with our callbacks simapp now requiring the wasm static libs. (again hopefully temporary)

Any of these changes that we want to revert I think we can do a in a follow up, this PR is already quite messy and I think it would be easier to figure out these issues in isolation instead of adding to this monster of a PR 👹

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against correct branch (see CONTRIBUTING.md).
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards and Go style guide.
[ ] Wrote unit and integration tests.
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/).
[ ] Added relevant godoc comments.
[ ] Provide a commit message to be used for the changelog entry in the PR description for review.
[ ] Re-reviewed Files changed in the Github PR explorer.
[ ] Review Codecov Report in the comment section below once CI passes.

1328 files changed 😱

1328 files changed 😱

I definitely was not expecting to go down this rabbit hole yesterday 🥲

I definitely was not expecting to go down this rabbit hole yesterday 🥲

Unfortunately there is always a 🐰🕳 lurking around every corner... But thank so much for doing this, @chatton!

Now that the wasm dep has been removed from ibc-go go.mod, the callbacks replace can be removed?

Now that the wasm dep has been removed from ibc-go go.mod, the callbacks replace can be removed?

yep we should actually be able to remove a bunch of the hacks now 🥳

@colin-axner I was able to remove all the hacks in the last commit 🥳


Add document about functions of cuDNN workspace

Please see also #1122

Do you have a link to a detailed description of the workspace size?

It is wrote in pdf of cuDNN SDK.

So, please write something like this: 'Check "cuDNN Library User Guide" for detail.'

LGTM!


New aka.ms link

Aka.ms link name
PracticeAssessments
Category (Optional. Select None to auto-select)
None

Thank you for submitting aka.ms/PracticeAssessments. Your link already exists at akaSearch.net. 🙏✅


enable Asset Leasing through Feature Management.

It would be nice to mention that you need to first enable Asset Leasing through Feature Management.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 711a62b9-9929-466e-b58b-c56d832deeef
Version Independent ID: b482ae02-f63c-ee8d-2f23-0f57a241f48a
Content: Asset leasing home page - Finance | Dynamics 365
Content Source: articles/finance/asset-leasing/asset-leasing-homepage.md
Service: dynamics-365-finance
Product: ****
Technology: ****
GitHub Login: @moaamer
Microsoft Alias: moaamer

@ErikJohnMSFT, thanks for the feedback. @moaamer, please review and consider making updates.

@tonyafehr I agree to indicate the asset leasing is under feature management. I will work with @roschlom to get this update. Thanks.

Bug 573565 logged to track this issue.

@tonyafehr this have been addressed in CONTENT DELIVERABLE 572925 Update -  Asset leasing home page.
I've resolved bug 573565  as duplicated.
Thanks @roschlom  for your help here.


return dummy data for monthly emissions

Pull Request

updated DTOs to account for monthly emissions

removed opDate from ApportionedEmissionsDTO (added it to hourly and daily return DTOs)
removed beginDate and endDate from ApportionedEmissionsParamsDTO (added it to hourly and daily param DTOs)
updated variable names where necessary
added MonthlyApportionedEmissionsDTO
added MonthlyApportionedEmissionsParamsDTO

updated maps to match the DTOs
controller: added getMonthlyEmissions()
service: added getMonthlyEmissions()
unit tests

refactored swagger and validator decorators to remove code duplication


api: fix health status with tls enabled

this pd does:

init http client for handler in main function. Fix #968
reuse dialClient in redirector.go
disable keep alive

LGTM.

/run-all-tests


4.0.0: sphinx warnings

+ /usr/bin/python3 setup.py build_sphinx -b man --build-dir build/sphinx
running build_sphinx
Running Sphinx v4.0.2
making output directory... done
loading intersphinx inventory from https://docs.python.org/objects.inv...
intersphinx inventory has moved: https://docs.python.org/objects.inv -> https://docs.python.org/3/objects.inv
building [mo]: targets for 0 po files that are out of date
building [man]: all manpages
updating environment: [new config] 5 added, 0 changed, 0 removed
reading sources... [100%] security/index
WARNING: autodoc: failed to import class 'Encoder' from module 'hpack'; the following exception was raised:
No module named 'hpack'
WARNING: autodoc: failed to import class 'Decoder' from module 'hpack'; the following exception was raised:
No module named 'hpack'
WARNING: autodoc: failed to import class 'HeaderTuple' from module 'hpack'; the following exception was raised:
No module named 'hpack'
WARNING: autodoc: failed to import class 'NeverIndexedHeaderTuple' from module 'hpack'; the following exception was raised:
No module named 'hpack'
WARNING: autodoc: failed to import class 'HPACKError' from module 'hpack'; the following exception was raised:
No module named 'hpack'
WARNING: autodoc: failed to import class 'HPACKDecodingError' from module 'hpack'; the following exception was raised:
No module named 'hpack'
WARNING: autodoc: failed to import class 'InvalidTableIndex' from module 'hpack'; the following exception was raised:
No module named 'hpack'
WARNING: autodoc: failed to import class 'OversizedHeaderListError' from module 'hpack'; the following exception was raised:
No module named 'hpack'
WARNING: autodoc: failed to import class 'InvalidTableSizeError' from module 'hpack'; the following exception was raised:
No module named 'hpack'
looking for now-outdated files... none found
pickling environment... done
checking consistency... done
writing... hpack.1 { installation api security/index } done
build succeeded, 9 warnings.

I suspect an error in your installation or environment. The full instructions on how to generate the docs are wrapped into tox and work in our CI and locally for me:
tox -e docs which is equivalent to a make html with an already installed hpack package.
Can you test that and report back please?

No only setuptools build_sphinx assumes that module will be available in root directory of the project. For some reason you've choose to put source code under src/hyper. That breaks many things in setuptools and this why you've been forced to wrap many things in tox.
This is why I've created that ticket (if it was not obvious).
I would suggest to move src/hyper/ to hyper/ on next release.

Sorry, your original issue was not obvious to identify as you did not provide any comment or explanation of what problem you are encountering.

Command is in first line of that ticket:
+ /usr/bin/python3 setup.py build_sphinx -b man --build-dir build/sphinx


How to use controller?

I am building a quiz application and have next button to change the question and answer on both sides of the card. But the problem is, if the card is on answer side(backside), clicking the next button shows answer for the next question. I want to automatically reverse the card to the question side with the next button click, if it is on the answer side.

FlipCardController _controller;

@override
void initState() {
  super.initState();
  _controller = FlipCardController();
}

child: FlipCard(
  controller: _controller,
)

void doStuff() {
  // Flip the card a bit and back to indicate that it can be flipped (for example on page load)
  _controller.hint(
    duration: UIConfig.projectFlipHintDuration,
    total: UIConfig.projectFlipHintTotal,
  );

  // Tilt the card a bit (for example when hovering)
  _controller.hint(
    duration: UIConfig.projectFlipHintDuration,
    total: UIConfig.projectFlipHintTotal,
  );

  // Flip the card programmatically
  _controller.toggleCard();
}


feat: service settings as a bean

Enables usage of [Service]Settings as a separate bean, as suggested in https://github.com/GoogleCloudPlatform/spring-cloud-gcp/pull/1364#discussion_r1036178245
Changes were based on POC by @zhumin8 and POC fixes by @emmileaf

@diegomarquezp I missed this earlier in review. But can you open a separate PR to update the relevant javadoc comments affected by this change?
https://github.com/googleapis/gapic-generator-java/blob/33d3070d535e93421a7b6fae1f5cbbd445cc2dfc/src/test/java/com/google/api/generator/spring/composer/goldens/EchoSpringAutoConfigurationGrpc.golden#L86-L98
and
https://github.com/googleapis/gapic-generator-java/blob/33d3070d535e93421a7b6fae1f5cbbd445cc2dfc/src/test/java/com/google/api/generator/spring/composer/goldens/EchoSpringAutoConfigurationGrpc.golden#L560-L564

@zhumin8 will do!


[FIRASqliteStore recordsForQuery:parameterValues:error:withFilter:] bug

[REQUIRED] Step 2: Describe your environment
Xcode version: 9.3 (ObjC)
Firebase SDK version: 4.13.0
Firebase Component: FirebaseAnalytics (4.2.0),  FirebaseCore (4.0.20), FirebaseInstanceID (2.0.10)
[REQUIRED] Step 3: Describe the problem
Hi,
In our ios application, we use Firebase for event logging and show native and interstitial ad banners with  Google-Mobile-Ads-SDK (7.30.0). After adding Firebase and GAD libraries and updating our app on AppStore, this crash is occured http://crashes.to/s/e5bc42b17e5
I think the prefix of FIRA belongs to Firebase or may be GAD classes. I cant reproduce the issue with simulator or test devices but on the production platform (appstore version), this crash is occured with an iPhone 5S 11.3.0 device. The crash has a little count now but I am wondering what the reason of it. It is related to another issue of our GAD crashes  (http://crashes.to/s/5f40366342d)? Or the new version of Firebase?
Steps to reproduce:
The crash might be when the application is on background or when sending an event on purchasing step. Dont know the exact step.
Relevant Code:
Pod I am using;
Using AFNetworking (3.2.0)
Using CNPPopupController (0.3.3)
Using Crashlytics (3.10.1)
Using EAIntroView (2.12.0)
Using EARestrictedScrollView (1.1.0)
Using FLAnimatedImage (1.0.12)
Using Fabric (1.7.6)
Using Firebase (4.13.0)
Using FirebaseAnalytics (4.2.0)
Using FirebaseCore (4.0.20)
Using FirebaseInstanceID (2.0.10)
Using Google-Mobile-Ads-SDK (7.30.0)
Using GoogleAnalytics (3.17.0)
Using GoogleToolboxForMac (2.1.4)
Using HCSStarRatingView (1.5)
Using IQKeyboardManager (5.0.8)
Using SDWebImage (4.3.3)
Using SMPageControl (1.2)
Using UICKeyChainStore (2.1.1)
Using nanopb (0.3.8)
You can download the app from https://itunes.apple.com/us/app/translate-assistant/id1348751689?mt=8
Thanks

Tracked internally at b/79920348

It is related with the new issue https://github.com/firebase/firebase-ios-sdk/issues/1487

@kaannesinn can you try updating to Firebase 5.0+ and seeing if the crash still occurs?
The first crash appears to be a crash in the Google Mobile Ads SDK, and the second crash has 0 occurrences.

@morganchen12 I updated 5.0+ after 1 week from this issue and updated our app on AppStore. Most of the crashes are gone yes.
Yes I know it is from GAD. The 2nd crash doesnt occur again but the 1st one exists on the new version of the app with #1487 issue.
I am closing this issue and we can continue with the new one.
Thanks


Total number of images: 0 Number of successfully aligned images: 0

Hi,
I ran the align_dataset_mtcnn.py with this instruction: python align_dataset_mtcnn.py AlGore AlGore-aligned/
and this message appeared:
Total number of images: 0
Number of successfully aligned images: 0
my database is LFW and I use 8 jpg files of Al_Gore folder. can you guide me what makes this result?
best,

I think you need to provide folders containing images inside AlGore folder. You can't have the images directly inside the folder.

hi
i m getting same error.i have compiled
python src/align/align_dataset_mtcnn.py ~/datasets/lfw/raw ~/datasets/lfw/lfw_mtcnnpy_160 --image_size 160 --margin 32
and getting error --
/home/mukesh/datasets/lfw/raw/lfw/Paul_Kagame: [Errno 21] Is a directory: '/home/mukesh/datasets/lfw/raw/lfw/Paul_Kagame'
Total number of images: 5749
Number of successfully aligned images: 0
please help.
thanks

you have the directory Paul_Kagame in the path /home/mukesh/datasets/lfw/raw/lfw/,  delete it and try again

thanks but in directory Paul_kagame and all other directories, only images are there.

then you have to change the code to handle the subfolders that contains images otherwise it won't work

okay, thanks


Avoid causing crashes when a component has a null string.

This needs some discussion.
I would like to be a little more flexible with components and strings.  Currently if you let a null string be sent to the serializer for saving a world, it crashes the game.  It would lower the bar to entry for new module developers if we allowed for null values without crashes, less things to know and code around.
Could we be a little more lenient in these cases?  Is there any other considerations to making this kind of change?  Possibly this could be extended to other types as well?

Refer to this link for build results (access rights to CI server needed):
http://jenkins.terasology.org/job/TerasologyPRs/179/
Hooray Jenkins reported success with all tests good!

Bump - @immortius @flo @MarcinSc anybody else interested?

I generally agree, but the only way to ensure you don't have crashes is not to have null values, ultimately. If something is intended to be null, I'ld suggest Optional should be used instead.
That said, I would agree with either what you've done, or having null strings serialize/deserialize to empty string. Null is safer in case existing code depends on it.

Should I apply the same null allowance to the other type handlers as well?  There are some that handle null well,  and some that dont.

I think making the other type handlers null save is a good idea.

Here is the more complete version touching other type handlers that could also crash when null.  Did I miss anything?

Refer to this link for build results (access rights to CI server needed):
http://jenkins.terasology.org/job/TerasologyPRs/181/
Hooray Jenkins reported success with all tests good!


Expand GlyphData.json with "unknown" chars

See https://twitter.com/KhaledGhetas/status/1356280238624419840
Make sure any changes go back to Glyphs, as they are the source of the document. See if I can use it directly instead of maintaining a WF-specific "fork" of the document?
Also see https://github.com/schriftgestalt/GlyphsInfo/issues/29

Not sure the problem I've encountered fits this issue specifically, but may be related. In the DeAetna Revival font, I was unaware there are exist Romanian diacritical marks, since the glyphs don't seem to be mapped to any Unicode points. Here's the Glyphs panel from Adobe Illustrator:

I wonder if these could be surfaced in Wakamai Fondue? Or maybe the case is too infrequent to warrant a change...


Path problem with jsn queries

I just tried the examples and noticed that half of them don't seem to be working because the queries are trying to call examples/jsn? rather than just jsn?.   Moving the example html files to the main directory fixes them as a workaround.
Example output (the last two queries fail):
q)QUERY:
QUERY: examples/base.html
QUERY: external/document-register-element.js
QUERY: kdb-wc.js
QUERY: examples/jsn?enlist {.h.tx[`jsn]:(.j.j');;1}[]
QUERY: examples/jsn?enlist ([] sym: 50?(5?`5);time:.z.T+til[50]*00:00:10; price: 50?40*50?1.0)

Just curious what is your browser (didn't have this problem in mine)?
Probably this is because I don't add the explicit server name to urls. I'll fix it.

That fixed it; works great now.  I'm using Firefox Nightly to connect to a remote q process, but also tried an ancient version of Firefox with a local q process and saw the same behavior.
BTW, thanks for sharing this!  I had hacked together a crude dashboard with R and Shiny for my kdb processes, but it performed terribly and leaked memory.  I was dreading having to learn some javascript to build a nicer dashboard, but it looks like this will do nicely.


Updated Changelog with all changes going into 0.23

[X] Have you provided a meaningful PR description?

Updated CHANGELOG with latest changes since 4da339d

coverage: 86.48% (-0.01%) from 86.494%
when pulling a29df7a3a7173d3c89af8280ee7aa9fc428fe219 on changelog/0.23
into ab10b5f528b6cb7aa71e365aa2ef211ca4dd82e2 on main.


basic esv7 support

i played around with the code and added basic esv7 support

@langerma, CI failed because it couldn't find ES client package.
it looks like ES client v3, v5, v6 package in vendor have been removed in c476432.
Also for v6 and v7, may I know why do you use gopkg.in url instead of github.com?
Thank you.

it was just a quick and dirty hack. and i do not really know how to use the vendoring thingy in go so i just went with the es client versions from gopkg


"Unable to get property 'focusFirst' of undefined or null reference" on IE11

I get this error:

Unable to get property 'focusFirst' of undefined or null reference

on this line (currently line 406) of dialog-polyfill.js:
dialog.removeChild(this.dialogPolyfillInfo.focusFirst);

in both my own test and https://rawgit.com/GoogleChrome/dialog-polyfill/master/tests/modal-dialog-stacking.html

@samthor Can this now be closed due to #29?

@puf Can you close this since #29 was merged?


If a sftp_download entry represents a symlink and delete_origin is true, only remove the symlink.

Motivation for changes:
Currently if a entry represents a symlink and delete_origin is true, the target of the symlink gets removed, but not the symlink itself. This changes the behaviour such that if an entry represents a symlink, only the symlink is removed.
Detailed changes:
If a sftp_download entry represents a symlink and delete_origin is true, only remove the symlink.
Currently is a entry represents a symlink, the target of the symlink gets removed rather than the symlink itself. This change corrects that and ensure that in the case of a symlink entry, only the symlink itself gets removed.
This also contains a fix for the test_sftp_server to use absolute() rather than resolve() when canonizing paths. Without this change lstat (which shouldn't follow symlinks which resolve does) fails to work correctly.

Just need to hold off on this request for now, it appears that the sftp_list plugin uses normalise to follow symlinks in the first place (i missed this in my tests cases as it uses the symlink name as the title. I'm going to update the sftp_list to be configurable to not follow symlinks and roll it into this change to make it more complete.


Support for changing tag_ prefix

Hi!
We need in our integration of the exporter, tags exported without the prefix tag_.
What do you think of supporting an env variable, a parameter inside the config.yml or something similar for changing the prefix to whatever you want?

Hey, not against it but would like to understand the underlying problem a little bit more.

It's just a case that we have, we are using gitlab and by default it uses a query like {environment: "xxxx"}. We have the environment tag and the exporter it's exporting it like tag_environment (as expected).
We have forked the repository and changed it for making it work without editing gitlab config, so my question was if it was nice to have a configuration to override the tag_ prefix

Hey @sanchezpaco - You should be able to relabel on prometheus - https://prometheus.io/docs/prometheus/latest/configuration/configuration/#relabel_config - So from my perspective we should not implement it. Or did i misunderstood you?


[Events] Documentation/Cookbook

Hi,
I have an have question.
I couldnt find documentaiton/cookbook on events, their usage etc.
Adding it 'd be beneficial for any newbie like me.
Thanks
Cheers

You can find them here, there's a chapter about it.

Thanks @zhuchun , can you please explain for a layman whats the difference between [Event(true) and false. Where would i use which one?

The [Event(false)] is triggered if any entity that has this kind of component in the group changes. [Event(true)] instead is only triggered if the specific component on the same entity, where the listener is attached, is changing. So you are basically "binding" the listener to a specific entity.

Thanks :)

BTW, there's an important thing missing, check this out Component Listener is not working.
TL;DR Add a generated GameEventSystems to your feature/system.


Delete cached data that gets collected when watching online

Describe your suggested feature
When you watch an episode/movie online (without downloading it) it keep cached data of that in the app directory and that is understandable so you won't wait a long time when you re-enter that same episode again but the problem is there's no choice of deleting this cached data, anyway I tried to watch a movie today and when I checked the app settings I noticed it's 500mb more and I couldn't clear it by tapping "clear cache" you can only clear it by tapping "clear storage" by then I'll lose my saved shows, fortunately I have root access on my phone and I found the cached data and I cleared it it was in data/data/com.xyz.jmir1..../files/media and I got rid of 500mb of cache.
Other details
I am writing this so I can ask if you could add a button that automatically deletes this by clicking it. Thanks for this amazing app.
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
[X] I have written a short but informative title.
[X] If this is an issue with an extension, I should be opening an issue in the extensions repository.
[X] I have updated the app to version <IP_ADDRESS>.
[X] I will fill out all of the requested information in this form.

There's an option now in the setting>advanced to clear chapter/episode data on app close in the data section. That should help reduce the space.

it's on by default, didn't help that much I alwaysgo to the app root directory and delete files/media it helps reducing the space by a lot, watching just one episode of anime that is just 20min makes tge cache size around 150mb so right now doing it manually is the more sufficient.

Aniyomi got a new internal player now and it doesn't save the cache of buffer in app data anymore


USHIFT-427: Disable clusterresourcequota and user informers

These two APIs are not available in MicroShift, so informers are useless here.

The removal of RBR controller LGTM.
@benluddy please chime in on the cluster quotas

/approve

/hold

Closing this PR because a fix directly in OCP would be preferred instead of a carried patch like this.


libpkgconf: 2.1.1 -> 2.2.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/pkgconf/versions.
meta.description for libpkgconf is: Package compiler and linker metadata toolkit
meta.homepage for libpkgconf is: https://github.com/pkgconf/pkgconf
meta.changelog for libpkgconf is: https://github.com/pkgconf/pkgconf/blob/pkgconf-2.2.0/NEWS
Updates performed

Version update

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.2.0 with grep in /nix/store/lxxw5r9qwsjvmizx62cbxz8c8px65q2v-pkgconf-2.2.0
found 2.2.0 in filename of file in /nix/store/lxxw5r9qwsjvmizx62cbxz8c8px65q2v-pkgconf-2.2.0

Rebuild report (if merged into master) (click to expand)

17 total rebuild path(s)

17 package rebuild(s)

First fifty rebuilds by attrpath

bdep
bpkg
build2
cava
cavalier
entangle
libbpkg
libodb
libodb-sqlite
libpkgconf
muon
muonStandalone
onagre
opensmtpd
pkgconf
pkgconf-unwrapped

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/lxxw5r9qwsjvmizx62cbxz8c8px65q2v-pkgconf-2.2.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A libpkgconf https://github.com/r-ryantm/nixpkgs/archive/068981b87b1de8dc60911bf1f857d91e13f77abe.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/068981b87b1de8dc60911bf1f857d91e13f77abe#libpkgconf

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/lxxw5r9qwsjvmizx62cbxz8c8px65q2v-pkgconf-2.2.0
ls -la /nix/store/lxxw5r9qwsjvmizx62cbxz8c8px65q2v-pkgconf-2.2.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package failed to build:

onagre

34 packages built:

bdep
bdep.doc
bdep.man
bpkg
bpkg.doc
bpkg.man
build2
build2.dev
build2.doc
build2.man
cava
cavalier
entangle
libbpkg
libbpkg.dev
libbpkg.doc
libodb
libodb-sqlite
libodb-sqlite.dev
libodb-sqlite.doc
libodb.dev
libodb.doc
libpkgconf
libpkgconf.dev
libpkgconf.doc
libpkgconf.lib
libpkgconf.man
muon
muon.man
muonStandalone
opensmtpd
pkgconf
pkgconf.doc
pkgconf.man

Maintainer pings
cc @zaninime @AndersonTorres for testing.

@NixOS/nixpkgs-merge-bot merge

@NixOS/nixpkgs-merge-bot merge

Result of nixpkgs-review pr 308251 run on x86_64-linux 1

35 packages built:

bdep
bdep.doc
bdep.man
bpkg
bpkg.doc
bpkg.man
build2
build2.dev
build2.doc
build2.man
cava
cavalier
entangle
libbpkg
libbpkg.dev
libbpkg.doc
libodb
libodb-sqlite
libodb-sqlite.dev
libodb-sqlite.doc
libodb.dev
libodb.doc
libpkgconf (pkgconf-unwrapped)
libpkgconf.dev (pkgconf-unwrapped.dev)
libpkgconf.doc (pkgconf-unwrapped.doc)
libpkgconf.lib (pkgconf-unwrapped.lib)
libpkgconf.man (pkgconf-unwrapped.man)
muon
muon.man
muonStandalone
onagre
opensmtpd
pkgconf
pkgconf.doc
pkgconf.man


Migrate Message/MessageConfirmation to zod

Summary
This migrates the validation of Message to zod.
Changes

Remove MessageValidator and associated schemas.
Add test-covered MessageSchema/MessageConfirmationSchema and infer types from them.
Propagate type requirements.
Update tests accordingly.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

17 of 17 (100.0%)  changed or added relevant lines in 6 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.04%) to 93.641%

Files with Coverage Reduction
New Missed Lines
%

src/routes/transactions/entities/tests/human-description.builder.ts
3
60.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.04%

Covered Lines:
6492

Relevant Lines:
6702

💛  - Coveralls


Strongly typed targets

What do you think about using CraneStation/target-lexicon for target parsing? This looks like a very reasonably written library that would allow for replacing the target string checking code with strongly typed checks against a Triple struct.
I would be happy to contribute this if you like the idea.

An interesting idea! I don't think we'd benefit too much from it though in the sense that the string based checks have stood the test of time well and work reasonable enough for this crate. Perhaps some other build scripts would benefit though!


add hover and size of social icons of footer in find doctor page

Description
add hover effect in social icons of footer and resize the footer
Related Issues

Closes #867

Type of PR

[X] Feature enhancement

Screenshots / videos (if applicable)
https://github.com/user-attachments/assets/394e85ef-90d8-4539-859c-8d227f6a79f2
Checklist

[X] I have gone through the contributing guide
[X] I have updated my branch and synced it with project main branch before making this PR
[X] I have performed a self-review of my code
[X] I have tested the changes thoroughly before submitting this pull request.
[X] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[X] I have commented my code, particularly in hard-to-understand areas.

Additional context:
[Include any additional information or context that might be helpful for reviewers.]

@varshith257 please review once and merge this pr

Why subscribe button and news letter section misaligned?

Why subscribe button and news letter section misaligned?

It is asking it was earlier you can see here
https://github.com/user-attachments/assets/ccf39d40-4b75-41c7-a54a-d614223590a9

@varshith257 i have made it just like home page see below .
https://github.com/user-attachments/assets/117f337a-7940-4e21-a549-8085a2e6e3b2


Signed value handling in RW sensors

Issue related to
Sunsynk Home Assistant Add-On
Describe the issue/bug
I want to add register 206 (grid trickle feed) sensor definition, while official sunsynk app and web interface does not permit a negative value, writing negative value with a modbus client actually works and provides expected behaviour. I would like to have easy way to automate adjusting this value (to correct for discrepancy between sunsynk meter and revenue meter), so rw sensor seems like a best idea.
However, when i have added my custom sensor definition
SENSORS += NumberRWSensor(206, "Grid Trickle Feed", WATT, 1,min=-500, max=500)
When attempting to write negative value i get a crash.
Expected behavior
Negative value to be written to the inverter
Your environment

Home Assistant version: 2022.2.x
Addon version: latest
Inverter make: Sunsynk
Inverter Model: N/A
Inverter Firmware: N/A

Logs
2023-06-02 17:40:39,582 CRITICAL sunsynk.sunsynk Writing sensor grid_trickle_feed=-1 [(206,)=(-1,)]
Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/umodbus/functions.py", line 1515, in values
    struct.pack(">" + conf.MULTI_BIT_VALUE_FORMAT_CHARACTER, value)
struct.error: argument out of range

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/src/app/./run.py", line 320, in <module>
    LOOP.run_until_complete(main(LOOP))
  File "/usr/local/lib/python3.9/asyncio/base_events.py", line 642, in run_until_complete
    return future.result()
  File "/usr/src/app/./run.py", line 298, in main
    await write_sensors()
  File "/usr/src/app/./run.py", line 274, in write_sensors
    await STATE[ssi].inv.write_sensor(
  File "/usr/local/lib/python3.9/site-packages/sunsynk/sunsynk.py", line 65, in write_sensor
    await self.write_register(address=addr, value=regs[idx])
  File "/usr/local/lib/python3.9/site-packages/sunsynk/usunsynk.py", line 45, in write_register
    await asyncio.wait_for(
  File "/usr/local/lib/python3.9/asyncio/tasks.py", line 478, in wait_for
    return fut.result()
  File "/usr/local/lib/python3.9/site-packages/async_modbus/core.py", line 233, in write_registers
    request = self.protocol.write_multiple_registers(
  File "/usr/local/lib/python3.9/site-packages/umodbus/client/serial/rtu.py", line 169, in write_multiple_registers
    function.values = values
  File "/usr/local/lib/python3.9/site-packages/umodbus/functions.py", line 1517, in values
    raise IllegalDataValueError
umodbus.exceptions.IllegalDataValueError:  The value contained in the request data field is not an allowable value
    for the server.

What happens with the pymodbus driver?

pymodbus driver doesn't work for me at all (for a different reason)
2023-06-02 18:23:25,216 INFO    options Loading HASS OS configuration 2023-06-02 18:23:25,233 DEBUG   : pymodbus driver options: {'port': 'serial-tcp://<IP_ADDRESS>:502', 'server_id': 1, 'timeout': 10, 'read_sensors_batch_size': 60} 2023-06-02 18:23:25,233 INFO    sensors Using Single phase sensor definitions. 2023-06-02 18:23:25,234 INFO    helpers Importing /share/hass-addon-sunsynk/mysensors.py... 2023-06-02 18:23:25,234 INFO    helpers   custom sensors: grid_trickle_feed, grid_trickle_feed_ro 2023-06-02 18:23:25,234 DEBUG   filter step unit:W, id:rated_power 2023-06-02 18:23:25,235 DEBUG   asyncio Using selector: EpollSelector 2023-06-02 18:23:25,235 INFO    : Connecting to serial-tcp://<IP_ADDRESS>:502 2023-06-02 18:23:25,235 INFO    sunsynk.pysunsynk PyModbus 3.2.2 TCP: <IP_ADDRESS>:502 2023-06-02 18:23:25,235 DEBUG   pymodbus.logging Connecting to <IP_ADDRESS>:502. 2023-06-02 18:23:25,235 DEBUG   pymodbus.logging Connecting. 2023-06-02 18:23:25,245 DEBUG   pymodbus.logging Client connected to modbus server 2023-06-02 18:23:25,247 INFO    pymodbus.logging Protocol made connection. 2023-06-02 18:23:25,247 DEBUG   asyncio <asyncio.TransportSocket fd=6, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=6, laddr=('<IP_ADDRESS>', 55844), raddr=('<IP_ADDRESS>', 502)> connected to <IP_ADDRESS>:502: (<_SelectorSocketTransport fd=6 read=polling write=<idle, bufsize=0>>, <pymodbus.client.tcp.AsyncModbusTcpClient object at 0x7fb67e6fa700>) 2023-06-02 18:23:25,248 INFO    pymodbus.logging Connected to <IP_ADDRESS>:502. 2023-06-02 18:23:25,248 INFO    : Reading startup sensors rated_power, serial, battery_shutdown_capacity, battery_low_capacity, prog6_time, prog2_time, prog1_time, prog3_time, prog4_time, prog5_time 2023-06-02 18:23:25,249 DEBUG   pymodbus.logging send: 0x0 0x1 0x0 0x0 0x0 0x6 0x1 0x3 0x0 0x3 0x0 0x5 2023-06-02 18:23:25,249 DEBUG   pymodbus.logging Adding transaction 1 2023-06-02 18:23:28,284 INFO    pymodbus.logging Protocol lost connection. 2023-06-02 18:23:28,287 DEBUG   pymodbus.logging Client disconnected from modbus server: trying to send 2023-06-02 18:23:28,287 DEBUG   pymodbus.logging Getting transaction 1 2023-06-02 18:23:28,288 INFO    pymodbus.logging Protocol lost connection. 2023-06-02 18:23:28,288 WARNING pymodbus.logging Ignoring launch of delayed reconnection, another is in progress 2023-06-02 18:23:28,289 DEBUG   pymodbus.logging Client disconnected from modbus server: None 2023-06-02 18:23:28,289 DEBUG   pymodbus.logging Waiting 100 ms before next connection attempt. 2023-06-02 18:23:28,290 ERROR   sunsynk.sunsynk timeout reading register 3 (5) 2023-06-02 18:23:28,290 INFO    : ############################################################ 2023-06-02 18:23:28,290 INFO    : No response on the Modbus interface serial-tcp://<IP_ADDRESS>:502, try checking the wiring to the Inverter, the USB-to-RS485 converter, etc 2023-06-02 18:23:28,290 INFO    : ############################################################ 2023-06-02 18:23:28,290 CRITICAL : This Add-On will terminate in 30 seconds, use the Supervisor Watchdog to restart automatically. 2023-06-02 18:23:28,393 DEBUG   pymodbus.logging Connecting. 2023-06-02 18:23:28,403 DEBUG   pymodbus.logging Client connected to modbus server 2023-06-02 18:23:28,403 INFO    pymodbus.logging Protocol made connection. 2023-06-02 18:23:28,403 DEBUG   asyncio <asyncio.TransportSocket fd=6, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=6, laddr=('<IP_ADDRESS>', 55856), raddr=('<IP_ADDRESS>', 502)> connected to <IP_ADDRESS>:502: (<_SelectorSocketTransport fd=6 read=polling write=<idle, bufsize=0>>, <pymodbus.client.tcp.AsyncModbusTcpClient object at 0x7fb67e6fa700>) 2023-06-02 18:23:28,404 INFO    pymodbus.logging Connected to <IP_ADDRESS>:502.

If you just have PORT: tcp://<IP_ADDRESS>:502 instead of serial-tcp://?

btw, what other modbus client did you write it with?

just tcp:// doesn't work (my converter does not convert modbus tcp to modbus rtu so i need the addon to send modbus rtu over tcp)
The client i'm using is Modbus Poll

Ok, my only suggestion for now is that you do the inverse of this - https://github.com/kellerza/sunsynk/blob/main/sunsynk/helpers.py#L49
So for a negative number, add 0xFFFF before you write it

That's what i'm doing now (in node red), and i have found another bug, when using Sensor with -1 factor the resulting value is off by 1.

SENSORS += NumberRWSensor(206, "Grid Trickle Feed", WATT, 1,max=65536)
SENSORS += Sensor(206, "Grid Trickle Feed RO", WATT, -1)

however, 65466 = 0xFFBA, Signed 0xFFBA = -70

Try this in mysensors. If it works we need to replace NumberRWSensors class & fix the function I linked above for signed
import attrs
from typing import Union
from sunsynk import WATT
from sunsynk.rwsensors import ResolveType, NumberRWSensor, resolve_num
from sunsynk.sensors import RegType, Sensor, SensorDefinitions, ValType

SENSORS = SensorDefinitions()

@attrs.define(slots=True, eq=False)
class NumberRWSensor2(NumberRWSensor):
    """Numeric sensor which can be read and written."""

    min: Union[int, float, Sensor] = attrs.field(default=0)
    max: Union[int, float, Sensor] = attrs.field(default=100)

    @property
    def dependencies(self) -> list[Sensor]:
        """Get a list of sensors upon which this sensor depends."""
        return [s for s in (self.min, self.max) if isinstance(s, Sensor)]

    def reg_to_value(self, regs: RegType) -> ValType:
        """Decode the register."""
        res = super().reg_to_value(self.masked(regs))
        return res if res >= 0 else res - 1  # signed needs to -0x10000

    def value_to_reg(self, value: ValType, resolve: ResolveType) -> RegType:
        """Get the reg value from a display value, or the current reg value if out of range."""
        fval = float(value)  # type:ignore
        minv = resolve_num(resolve, self.min, 0)
        maxv = resolve_num(resolve, self.max, 100)
        val = int(max(minv, min(maxv, fval / abs(self.factor))))
        if len(self.address) == 1:
            if val < 0:
                val = 0x10000 + val
            return self.reg(val)
        if len(self.address) == 2:
            return self.reg(val & 0xFFFF, int(val >> 16))
        raise NotImplementedError

SENSORS += NumberRWSensor2(206, "Grid Trickle Feed", WATT, -1, min=-500, max=500)

It works.


added type interface definition to index.ts for viewInterface

Resolved this warning message exporting viewInterface.

@nicktaras I reviewed this, it looks good. But could you resolve conflicts before merging?

Thanks @snowwhitedev. I've fixed the conflicts.


Example static files are ignored by the build.sh script

Problem
We have a nice script for building examples now but it puts all generated wasm / js in the examples/static folder. This means that any static files for specific examples are ignored.
Proposed Change

Remove examples/static
Modify examples/build.sh to generate files in the example's static folder

@numerodix would you be interested in picking up this task? It's related to https://github.com/yewstack/yew/issues/1289

Thanks for thinking of me, @jstarry :)
This is something I was thinking of doing as part of #1289. Why don't I get started on that one then. :)

No problem 😄


Component throws a lot of SOC sensor not valid: errors within ~50ms when SOC sensor is unavailable

Version of the custom_component

Version 1.10.0
Configuration
Using the Hyundai / KIA Connect custom_component to connect to my car: https://github.com/Hyundai-Kia-Connect/kia_uvo
Describe the bug
At last boot, it took a bit of time until the Hyundai component was able to provide the SOC sensor (timestamp 11:13:16, according to its log). This component kinda freaked out on that, with multiple log lines within ~50ms....


Disable the autosaver completely when publishing through composer

Previously the autosave could still launch once after the "publish" button has been clicked from the composer view.
This prevents that from happening.
This caused occasionally an extra page version to be created which is visible to the user because the "page is pending for approval" popup appears straight after the page has been published.

Why my.disableAutosave(); isn't enough?

@mlocati It seems in some occasions it is still posting an autosave request
after the publish button is clicked. I don't know exactly why that
happens but disabling the autosaver completely seems to work because it
disables the autosaver requests in all cases, even if it is fired for some
reason.
to 18. huhtikuuta 2019 klo 16.42 Michele Locati<EMAIL_ADDRESS>kirjoitti:

Why my.disableAutosave(); isn't enough?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/concrete5/concrete5/pull/7733#issuecomment-484514223,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGTAVH4X2PGI5IRJ4JJKIDPRB3D7ANCNFSM4HG45XPQ
.

Here is the reason why the save never happens when the autosaver is completely disabled:
https://github.com/concrete5/concrete5/blob/18b605ddc1d69be461f3cdd0b85ed9f3ab826f58/concrete/js/build/core/composer/save-coordinator.js#L162-L164
When calling my.disableAutosave();, it will only clear up the existing save requests at that point. If a save request is initiated after that call for some reason (and apparently a reason exists because this happens), it will be still executed because the autosaver is still enabled, although the possibly queued save requests were cleared.

As you can see, my.disableAutosave(); is named misleadingly as it will not actually disable autosave:
https://github.com/concrete5/concrete5/blob/4691ca19a7ec7debbdee216ae0798a994ca8d3c7/concrete/views/panels/details/page/composer.php#L63-L67
It will only clear the existing save queue:
https://github.com/concrete5/concrete5/blob/18b605ddc1d69be461f3cdd0b85ed9f3ab826f58/concrete/js/build/core/composer/save-coordinator.js#L94-L97

I can confirm that this fixes the issue described in the PR description.
I'd say this is a critical fix to apply, I'm actually looking to hotfix this on a bunch of sites.

I can also confirm this.
Using a fresh 8.5.1 full install.

I created a Blog Entry page.
In Composer I added a title, thumbnail, and added some text in the Content block
I published the page.
I opened the page in Composer and added some text to the Composer block.
I published the page.
After refreshing the page I get the "Page is Pending Approval" modal.
I clicked the "Approve Version" button.
When I open the Page Settings panel, and go to the Version section, there are two versions created.

There is another issue that appears to prevent previous versions from being approved and displayed.

After the duplicate versions are created, try to approve any version except for the latest one.
The refreshed page shows the latest version and the "Page is Pending Approval" model pops up again.
Approving the page then approves the latest version.

To approve and display previous versions, you need to delete any newer versions. In effect versioning is broken.


add rizhiyi lunaxee product by yottabyte in vendor list

add rizhiyi lunaxee product by yottabyte in vendor list

Thanks, @svrnm
I see the PR has been approved, but the  comment "Merging is blocked" shows as below and i didn't see my commit in main branch, would you please let me know is
there anything i need to do?  thanks


rocSOLVER Enhancements - presume you meant no longer

rocSOLVER
Enhancements
Linear solvers for general non-square systems:
GELS now supports underdetermined and transposed cases
Inverse of triangular matrices
TRTRI (with batched and strided_batched versions)
Out-of-place general matrix inversion
GETRI_OUTOFPLACE (with batched and strided_batched versions)
Argument names for the benchmark client now match argument names from the public API
Fixed Issues
Known issues with Thin-SVD. The problem was identified in the test specification, not in the thin-SVD implementation or the rocBLAS gemm_batched routines.
Benchmark client no longer crashes as a result of leading dimension or stride arguments not being provided on the command line.

@whosystem Thanks for catching the error!  We'll get that fixed.

Thank you for the feedback. The fixed defect for rocSOLVER is corrected in the Release notes document for ROCm v4.3.
AMD ROCm Documentation Team

Hi @whosystem
Thanks for reaching out.
Issue is fixed now. Please check the documentation for the updated information.
Feel free to open a new issue, if any, for quick resolutions.
Thank you.


Introduce a common set of extendable messaging tests

Not sure if this is the best / most maintainable solution, but it provides a way to have a set of 'common' JMS extension tests that can be reused for ActiveMQ, AMQP, JMS, SJMS & SJMS2 + test different combinations of JMS broker & client.
The README in integration-tests/messaging explains how it works.

I wonder how well will these new test-jars behave inside platform. Have you tested it by any chance?

Yes, I did a basic platform test, the generated itest modules looked fine and I ran tests successfully.

The activemq test passed for me locally. Let's merge

... and congrats to PR #3000!


Align conda-forge.yml with ignition repo

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

The linux_aarch64 emulate build is taking too much, I switched to cross-compile even there.

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender

@conda-forge-admin please restart ci

Probably makes sense to set
https://github.com/traversaro/gz-math-feedstock/blob/ec605ba6dae0d67ffea45e7e220fefa6d92ff40f/conda-forge.yml#L2
to linux-64 instead.

Probably makes sense to set https://github.com/traversaro/gz-math-feedstock/blob/ec605ba6dae0d67ffea45e7e220fefa6d92ff40f/conda-forge.yml#L2
to linux-64 instead.

I can't find the log, but unfortunatly this resul in an error. I wanted to get a first build with aarch64 in so to unblock the sdormat13 build, then we can investigate the issue in a dedicate PR.

Probably makes sense to set https://github.com/traversaro/gz-math-feedstock/blob/ec605ba6dae0d67ffea45e7e220fefa6d92ff40f/conda-forge.yml#L2
to linux-64 instead.

I can't find the log, but unfortunatly this result in an error. I wanted to get a first build with aarch64 in so to unblock the sdormat13 build, then we can investigate the issue in a dedicate PR.

See https://github.com/conda-forge/gz-math-feedstock/pull/4 .