Is this still maintained?

It's been several months and several major bug fix PRs have sat with no response. I was under the impression that MoP was part of Stream Native's commercial Pulsar solution, however it seems to be completely unmaintained. There has been no work put forward on outstanding bugs, seemingly even when the solution has already been provided. I've gotten no response on my open PRs dating back to March. We've been building out own MoP version with these patches for most of the year now. Is this project still officially maintained? If so is there a timeline I can expect to get replies to the PRs that are currently open which address major bugs?

AFAIK, this project is not actively maintained though we have customers using mop. The core maintainers are focusing on other projects. I have pinged my colleagues and hoped to get some responses.

@mattisonchao We were using 2.10, and now we're using 3.1.1. We've noticed the bug present in all versions we've tested so far, and have been running in production with both PRs applied for quite a while now. We've been patching 2.10 builds ourselves, and recently just patched the <IP_ADDRESS> MoP build with the PRs recently and have run it through a series of our own integration tests that rely on MoP to test for regressions.

We are actively using this plugin for commercial use, and we heavily depend on many MQTT features. I assume many of these bugs may not be something others have run into, since MQTT is often just used for simple telemetry. I'm happy to contribute to the project, have a lot of experience with MQTT and have done some work on the VerneMQ MQTT broker as well. I'm happy to give back to an opensource project. Is there anything I can do to make this easier? I assume MoP might not be a priority project as KoP is likely a more popular plugin, and I assume most of you are concerned with Pulsar.
MoP has been incredibly useful for us. We deal with robotics systems working on cellular networks, and Pulsar is incredibly useful for handling large volumes of telemetry, and MQTT is very useful for dealing with these devices which don't have reliable connectivity. I'd love to continue improving this project, and wonder if that's something I can continue to do. I'd rather maintain this project than fork it.

I have another bugfix that I found when running the MoP proxy on a cluster that does not have TLS enabled. Seems there is a null pointer exception as something expect the pulsarServiceUrlTls metadata to not be null. I'm assuming Stream Native never ran across this issue since you're probably always running with TLS enabled.


[BEAM-13749] Exclude per-key order tests on Twister2 runner

r: @emilymye

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run Java PostCommit

Retest this please

Run Java PostCommit


Create polygons etc programmatically

Hi,
I have been spending the last few hours figuring out on how to create and edit features programmatically (without using the control bar UI). I figured out how to edit existing features but I can't get create to work properly.
Could someone give me an example how to create a polygon and add it to the map? I have been trying this which throws the drawstart event and adds a tooltip (with broken css) to the map:
var polygon = new L.Draw.Polygon(map);
polygon.enable();

However, there seems to be missing something because I can't click on the map and start editing.
When I call polygon.addHooks() I can start editing the polygon but then get 2 tooltips on the map, one fixed in the upper left corner.

I have it working now. Turned out to be an issue with my build setup and the bower file missing in the 0.2.3 tagged version. When using the master branch with the correct bower file it is working now.


Support absolute paths with packages/ folder

We’ve been using Lerna in Create React App, and I really like its approach. I think we should support a similar workflow (even without Lerna itself) for the “absolute paths” feature.
I imagine it working like this:

In addition to src, you can create a special top-level folder called packages.
Inside packages, you can create folders like app, stuff, lol, and they all “see” each other so you can import things from app/whatever.js or lol/wow.js. You can also import any packages from src (but not vice versa). The entry point is still src/index.js.
We won’t add any magic handling that breaks Node resolution mechanism. Instead, whenever you npm start, npm test, or npm run build, we will run a utility that creates symlinks from node_modules of the root project to every folder in packages. It reports a hard error if there is a conflict. This means the authors can add server rendering after ejecting without scratching their heads, and that all the tooling assuming Node resolution mechanism keeps working.

package.json
public/
src/
  index.js # can import app/banana.js or harry-potter/wand.js
packages/
  app/
    banana.js # can import harry-potter/wand.js
  harry-potter/
    wand.js # can import app/banana.js
node_modules/
  app -> packages/app
  harry-potter -> packages/harry-potter
  other-deps

Am I missing why this would be a bad idea?

We've been using linklocal for this type of thing.
https://github.com/timoxley/linklocal

What problem would this solve? I see lerna as being useful as for example now users can easily use the eslint config of create-react-app in any package they want.
Could I publish this package harry-potter to npm? So that I could use it another package as well? Is that the idea?

How does this help? Can anyone who will benefit from this comment?

This seems like an acceptable solution to me, if well documented. It sounds like under this proposal that it would make sense to put most domain models under packages/ and so in an OO system, one would not have much under src/, though tests/ should still go under src/ and import domain models under test from packages.
That's a clear change from what we're used to thinking, that 'everything goes under source'.  Am I holding it right?
Also, it sounds like things under src/ would not be accessible via absolute paths, only things under packages/. This should be made really clear in the documentation... We have a folder called src/testHelpers. Implementing this solution would mean moving it to packages (in order for src/banana.tests.js to be able to import a testHelper file by absolute path).
So I guess in the final analysis, if anyone has been using the NODE_PATH=src workaround, to implement this solution, one would have to reorganize all the folders and rewrite the imports. Is there a solution that would keep the same folder structure people have already built with create-react-app?

The problem we're trying to solve is:
import 'path/to/banana.js' instead of the brittle `import '../../banana.js'.
Absolute paths to your app's files instead of relative paths.
The current workaround is to add an environment variable before running commands:
NODE_PATH=src/ && npm run start
But apparently some people have problems with that workaround, perhaps because of a conflict between the name of their file and the names of folders and files under node_modules/. Though honestly I can't help but wonder if that's an edge case.

@gaearon Why not just point to src/ instead of adding packages? I'm sure there is a great reason that's just not clear to me yet.

Why not just point to src/ instead of adding packages? I'm sure there is a great reason that's just not clear to me yet.

I was wondering this to, you could also symlink any directory in src. And then still keep src/index.js as entry point. No?

Why not just point to src/ instead of adding packages? I'm sure there is a great reason that's just not clear to me yet.

@mandysimon88 that is what we are talking about. Every file in your project can refer to some other file. You need absolute paths in every file so this solution (in some sense) forces you to put everything in packages/.

How does this help? Can anyone who will benefit from this comment?

Please refer to discussion in https://github.com/facebookincubator/create-react-app/issues/636.

Why not just point to src/ instead of adding packages? I'm sure there is a great reason that's just not clear to me yet.

It is too brittle in my experience. People won’t realize what is happening unless there is some explicit opt-in, and I think packages is a good way to signal the intention, as well as to make people think twice about how to name root folders (instead of accidentally aliasing something that already exists in node_modules).

Is there a solution that would keep the same folder structure people have already built with create-react-app?

 This feature would be strictly additive. You could migrate to it one helper at a time, if you’d like, or even keep using NODE_PATH. Or you could copy all top-level folders from src into packages and have src/index.js re-export whatever package you like, thus providing a quick migration path.

It is too brittle in my experience. People won’t realize what is happening unless there is some explicit opt-in, and I think packages is a good way to signal the intention, as well as to make people think twice about how to name root folders (instead of accidentally aliasing something that already exists in node_modules).

Just some reference how an other language solved this problem. Because what Dart does is something very similar as you are proposing @gaearon. It will see anything in the lib folder as a regular installed package where the name of the package is gotten from how you call the app in package.json. Say the app is called my-app then:
package.json # name: my-app
public/
src/
  index.js # can import app/banana.js or harry-potter/wand.js
lib/
  dom.js # top level file, can be imported as `my-app/dom.js`
  fruits/
    banana.js # can import my-app/harry-potter/wand.js
  harry-potter/
    wand.js # can import my-app/fruits/banana.js
node_modules/
  my-app/
    app -> lib/app
    harry-potter -> lib/harry-potter
  other-deps

The adventage of this, is that you don't have to worry about how you would call the directory in the lib (or packagedirectory).

Should you go ahead and do this, you should configure eslint-plugin-import to resolve files correctly. I see that the rules are currently disabled, but that's something that should be done at some point.

How does this help? Can anyone who will benefit from this comment?

Please refer to discussion in #636.

That issue is where I came from. This solves the problem stated in the original request terribly at best.
Take the f8app, stop using @providesModule and apply this solution. Can you imagine ending up with a better structure?

terribly at best.

This is a pretty strong statement. Can you help me understand what is “terrible” about this proposal?

To clarify, it is terrible for being a solution to the original request in #636.
This solution basically suggests that we should move stuff we want to import using absolute paths to a directory in packages/. The problem is that we want to import almost everything using absolute paths. If I were to use this pattern, I would have to move my actions, components, helpers, 18n, theme.js, env.js and config.js to somewhere in packages. That's my whole app!

That's my whole app!
That's the whole point! Structure your app as  packages instead of a monolith

@Pajn it is? If I had to use this pattern, I'd just move some directories to packages and it would work, but then src would be almost empty. What's next? We remove src?

Or are you expecting me to make every component a package? Am I supposed to have a thousand React components laid flat in packages?

Could this be done without copying files by putting packages in src/node_modules (see #607) and checking for conflicts?

@modernserf yes, but don't you think that's a bit ugly?

A developer would and should expect a directory called node_modules to be managed by npm.
CRA targets beginners. What happens when a beginner faces with a problem and reads on SO that they should try removing node_modules and doing an npm i? The original node_modules might even be hidden by the editor. "Why do they ask me to remove my code?"
Most editors, libraries and .gitignores do not follow the best practice and treat all directories named node_modules as the one at the root. Even React Native has this wrong. (It should've been /node_modules/ and not node_modules/.)

You should just treat node_modules as a reserved name.

@AlicanC
Wouldn't having a single folder called "app" in packages satisfy your use case? You could even have src/index.js reexport app/index.js and then any module is addressable as app/whatever.
Of course it's a bit more typing than if you give implicit namespaces but I think explicitness is favourable in this particular case.

it already is. If I had to use this pattern, I'd just move some directories to packages and it would work, but then src would be almost empty. What's next? We remove src?

Then it would be mostly empty for you. I don't see a problem here. You choose a convention where everything lives in an absolutely addressable package. That's fine but then people new to your codebase need to know where the entry point is. So it makes sense to me that src stays at top level because that'll be the first place people look (and they can see what you reexport if you really decide to move everything into packages).

I don't like it, but sure.
Which official Facebook projects can we expect to see dogfooding this pattern?

A developer would and should expect a directory called node_modules to be managed by npm.

It's a common misunderstanding: node_modules does not imply "managed by NPM", it's how Node natively resolves paths, hence why NPM uses the name.
A root /node_modules folder would be thirdparty modules from NPM, something like /src/node_modules would be local modules from your project. No need to reinvent the wheel to get clean paths that avoid "../../.." type of paths :)

Which official Facebook projects can we expect to see dogfooding this pattern?

As you probably know, Facebook is using Haste everywhere in its product code. You might have noticed it is not very popular in the open source community. Some things that work well for Facebook also require a lot of infrastructure that others don’t have.
Create React App explicitly does not follow everything the way Facebook does it. In fact, it would not exist if it followed the usual dogfooding principle because, for example, Facebook doesn’t actively use Webpack and instead has super powerful development servers in the cloud that compile the code. The situation in the open source community is just different, and with this project we tried to break our usual principles and go where people are. I think the success of this project speaks that breaking the rules is a good idea sometimes.
That said, project structure with packages is used by Babel, Jest, and Create React App itself. I don’t see why it wouldn’t work for apps, especially as it is pretty much the same thing as absolute imports (requested numerous times and enabled in many popular boilerplate projects), but more explicit.

I'm a big fan of this approach. It encourages encapsulation of like logic for a local package used in the packages folder.
For example I have a packages/components folder that holds all my dumb/presentation React components. This lets me safely know that any component found in there must be given properties to configure its behavior and likewise has no reliance on whatever state management you're using.
Further it also creates a structure such that if you wanted to open source components inside of packages the migration path is a lot more straightforward as you're already considering them as a package.
Big fan of this approach.

Coming from the rather large React codebase of wp-calypso where we heavily rely on absolute imports, I think this is a great idea. Although not necessary at all for a small project, when a project becomes large, absolute imports have a huge value and can save a lot of developer time.
Having this be an option in CRA may help provide a way for new developers to encounter the concept in a friendly way with a suggested implementation rather than trying to discern how to do it themselves (or giving up since there is no "right way").

I think it may be a good idea to consider teaching people this pattern:

This seem to not only work with create-react-app, but everywhere. You don't need any symlinks or whatever.

So, where would your __tests__ folder go, and how would it use imports? For example: src/testHelpers/MyUniqueJestMatchers.js… In banana.tests.js:
import MyUniqueJestMatchers from ‘src/testHelpers/MyUniqueJestMatchers’. My point is that not everything that one might need to import is actually best described as a “node_module”. Under your logic, everything in src/ needs to go in src/node_modules at which point you just have two folders for no other reason than to avoid the name collision of having two node_modules in the root directory. Hence, the packages suggestion.

On Sep 28, 2016, at 2:08 PM, Kasper Peulen<EMAIL_ADDRESS>wrote:
I think it may be a good idea to consider teaching people this pattern:
https://cloud.githubusercontent.com/assets/1035299/18926166/15048172-85b7-11e6-9021-877437f04477.png
This seem to not only work with create-react-app, but everywhere. You don't need any symlinks or whatever.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/facebookincubator/create-react-app/issues/741#issuecomment-250250336, or mute the thread https://github.com/notifications/unsubscribe-auth/AMQpjHd5Y82onznTIja63FmOmJc4tc0Nks5quq0zgaJpZM4KFvTW.

I think node_modules, while “working out of the box”, will be confusing to a lot of people and very hard to explain. It’s a cleaner suggestion technically but I just don’t see it as viable/attractive from the usage point of view.

Yeah I agree it’s confusing.

On Sep 28, 2016, at 2:58 PM, Dan Abramov<EMAIL_ADDRESS>wrote:
I think node_modules, while “working out of the box”, will be confusing to a lot of people and very hard to explain. It’s a cleaner suggestion technically but I just don’t see it as viable/attractive from the usage point of view.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/facebookincubator/create-react-app/issues/741#issuecomment-250265235, or mute the thread https://github.com/notifications/unsubscribe-auth/AMQpjJJ5WARZLWqgz7zWzo_SE0ZbVFgRks5qurjPgaJpZM4KFvTW.

Okay, I kind of agree with the point, that if you will put everthing in src/node_modules, except the entry point, then packages solution looks cleaner.
Im not really sure if the solution I propose is harder to explain to beginners. External node modules are in /node_modules, internal modules are in /src/node_modules. I think it is more confusing for experienced devs than for beginners, just learning about those concepts.
I must that if we choose to go for symlinks, I would prefer the name 'lib' above 'packages'. For one, to not confuse this with lerna. Two, it seems like we will just put libraries there, not packages to publish to npm. It seems like someone would need to use something like lerna for that, so lets not use that name then.
Also, I would prefer to import "name-of-app/harry-potter" instead of import "harry-potter" to avoid any problems if I ever want to use  the package harry-potter from npm. Also it seems to indicate in a more clear way where this package is located.
This is also the convention used by Dart, and I think it works well there.

Am I missing why this would be a bad idea?

@gaearon How about webpack? I just tried this strategy manually in my create-react-app. But won't it be complicated for making sure that webpack understand which node_modules needs to be compiled with babel, and which not? For example, if I add a new directory to packages while I already started npm start, will that work?

For example, if I add a new directory to packages while I already started npm start, will that work, or would I need to restart the command?

I want to do this via symlinks so that they also work in editors, and third party tools (e.g. style checkers, storybooks, etc).

I don't have very much experience with big React applications, and actually not even with production React applications. I've just started to study it recently, so my opinion may not count much.
I personally don't see it as a big deal using src instead of adding an extra packages folder and link src inside of node_modules.
Based on the simple apps I've been developing I'd put an absolute import most of the time, and this way I'd have everything in packages with an almost empty src folder.
I've just created a symlink in node_modules pointing to src and using import Something from 'src/components/Something/' seems a good way to use it. The opt-in would be that you'd need to prefix src, and thus it'd make it much clearer that you're importing from the src folder and not from an external package.

First off, I'm looking forward to this "import from packages" feature! I know it seems to be underway, but just to throw in my little two cents since it gives a slightly different perspective than what was conveyed here.... Perhaps it will be helpful for docs, or simply understanding how it might be used in the wild.
Importing is just about the last thing keeping me from adopting CRA on a real project. As a designer who works in code, I need to be aggressive in keeping code as flexible as is reasonable and in reducing "developer work" (complexity introduced through the realities of implementation). Others in this thread have said that absolute paths work better on mature apps, and that's certainly true. But I think they are equally useful in the earliest stages of a project---especially you carry the responsibility for deciding what to build in addition to how to build it. When a project is still a rough prototype, I'm constantly renaming things, creating new directory structures, moving files around, decomposing the UI in shifting ways, as what the product is gradually comes together. Especially as component directories become more nested, relative paths add a strong but subtle pressure to not make these changes...or at least to not keep the organization of the code in line with design changes. And this, in turn, adds an increasing pressure not to make design changes, or makes it harder to implement them. Find and replace, or just finding where that component is now when importing, is much easier with absolute paths.
When I moved onto webpack almost three years ago I solved this with some hacky globbing script to allow pathless imports. I wouldn't recommend it for CRA (naming doesn't scale, requires more knowledge of the codebase, occasional memory issues in Node, long bootup time), but it has worked well enough for my purposes. The packages idea seems like a nice compromise.

@gaearon

Am I missing why this would be a bad idea?

Poor symlinks support in windows?

@Guria Do Lerna or pnpm work on Windows? I haven’t investigated this much so if you could share what exactly the limitations are, it would be helpful.

Windows user here.
Lerna is working fine on me, just needed to run it with Administrator priviledge

Hi,
I have currently big react app with nested directories. Relative paths in such nested structure are tragic approach, i need to think how many ../ i should give in file. Without create-react-app I used babel-root-import. In past I worked in PHP environment and relative paths was always anti-pattern, every framework had solution for that. I think packages directory is not a solution because like sad @AlicanC

The problem is that we want to import almost everything using absolute paths

I agree in 100%. I think most of us need global import possibility to change import ../../file to for example ~/app/file.

Am I missing something here?
With babel-root-import you'd write import SomeExample from '~/some/example.js'; with this packages proposal you'd presumably write  something likeimport SomeExample from 'packages/some/example.js';
Isn't the only difference the name of the big directory you stick you're code in ("packages" instead of "src" or "~"/root)? If this were my personal setup I'd also use something like babel-root-import or just src for absolute paths, but the reasons given here for using packages in CRA makes sense IMO. I do expect my personal src to only include index.js, and then I'll never think about it again.
I can see static assets getting slightly weird, but I guess you could just have "css" or "images" or "videos" or "assets" packages. Which, come to think of it, sorta makes sense! It's like a media library.

Am I missing something here?
With babel-root-import you'd write import SomeExample from '~/some/example.js'; with this packages proposal you'd presumably write something likeimport SomeExample from 'packages/some/example.js';
Isn't the only difference the name of the big directory you stick you're code in ("packages" instead of "src" or "~"/root)? If this were my personal setup I'd also use something like babel-root-import or just src for absolute paths, but the reasons given here for using packages in CRA makes sense IMO. I do expect my personal src to only include index.js, and then I'll never think about it again.
I can see static assets getting slightly weird, but I guess you could just have "css" or "images" or "videos" or "assets" packages. Which, come to think of it, sorta makes sense! It's like a media library.

@gaearon  Quick question, this proposal doesn't appear to clash with fixing the current "relative path hell".
Is there a reason not to allow absolute imports from src/ now and consider improvements in the future?
(A lot of new devs are using this excellent project and with every day passing more are learning to use '../../../actions/jinx.js' as "how things work")

What else needs to be done here @gaearon?

It's an interesting idea, but it won't work well on Windows. Basically, you'll be forced to constantly run cmd/powershell as Administrator which would be a nightmare in some work environments.
I don't like the semantics of node_modules trick that has been already described above, but when you think about it, it achieves the same result with less hacks. The only difference would be that in one case the explanation would come from CRA documentation while in other you'll be required to understand Node.js a little bit.

Might it be possible to utilise Webpack's resolve-aliases feature for this particular case?
I have been using it in recent projects for exact that reason (absolute paths)

I don't know if this solves the problem in the way that it needs to be solved, but I have my own approach that seems to be much simpler.
I usually just add the path to the webpack config aliases. Say I have a folder structure like the following:
> webpack.config.js
+ src/
    > index.js
    > App.jsx
    + store/
        > index.js
        > actions.js
    + components/
        > ...?
        + NestedComponents
            > ...?

It's not a perfect example, I know. You can set up your aliases in your webpack config like this:
aliases: {
    '@store': path.resolve('src/store'),
    '@components': path.resolve('src/components')
}

Then in your code you can do this:
~/App.jsx

import store from '@store'
import Component from '@components'
import AnotherComponent from '@components/NestedComponents'

Is there any reason a standardized system similar to the one presented here would not work?

I'm coming to the conclusion that the best way forward is to just document the src/node_modules "hack". It's compatible with all the tooling. We just need to fix small issues like #1042.

Superseded by #1065.

Thanks @mandysimon88 for putting me on the right track with your suggestion:
NODE_PATH=src/ && npm run start
However it did not work for me till I changed it to:
NODE_PATH=src/ npm run start
which I think makes sense ... anyway I could then get rid of relative import paths in my app (which are quite terrible indeed) without having to change the Webpack config (which create-react-app does not support unless you "eject").

Glad I stumbled upon this. I've put NODE_PATH=src/ in my .env file and now I can use this import Button from 'components/Button from any file. Thank-you all.

just fyi if using flow,
[options]
module.system.node.resolve_dirname=node_modules
module.system.node.resolve_dirname=src

to map it the same way.

Does the NODE_PATH=src/ solution work for react-native?

@gaearon I'd like to help by submitting a PR where this is added to the readme

Adding NODE_PATH=src/ in .env works great! Thanks!
Just to add on this: In case you run your own eslint config on top by having your own .eslintrc.yml you need to add
settings:
  import/resolver:
    node:
      paths:
        - ./src

to it to resolve the absolute paths correctly.

@will-stone's solution of adding NODE_PATH=src/ to .env works for import {something} statements, but not for @import {something}.scss statements for SASS.

You can use the --include-path option in the cli for that

For some reason, my .env file with NODE_PATH=src/ is ignored. When I run npm start, I get module not found errors to my components. But if I run NODE_PATH=src/ && npm start, I get it working. Any ideas?

Yeah, I noticed this too. I solved it with cross-env:
npm install --save cross-env

Then in package.json:
...
"scripts": {
    "start": "cross-env NODE_PATH=src/ react-scripts start",
...

Hope this helps.

It’s a bug in 1.0.0. See https://github.com/facebookincubator/create-react-app/issues/2225 for updates.

I am somewhat late to this discussion but I'd like to support @FFX01 suggestion, which is, more or less, what I use.  Please stop forcing developers to an arbitrarý folder structure.  Placing things into src/node-modules or any other place, for that matter, is not a good idea.
I currently use WebPack's resolve.alias to create virtual folders for components, store, utils, jest utils.  I have adopted a leading underscore instead of @FFX01 's at-sign, but any symbol would do, whatever makes sure that your virtual folders would never collide with an existing package. By using resolve.alias
This is a sample of imports I have in my code:
import isPlainClick from '_utils/isPlainClick';
import { selSector, selUsername } from '_store/selectors';
import { logout, ensureUser } from '_store/actions';
import Menu from '_components/menu';
import Login from '_components/login';

Where is _utils actually located?  Actually, you don't need to know.  Nor are you forced to keep it in a fixed position under src, as it would happen if the only absolute directory reference is src.  Nor are you forced to tinker with other tools that regularly ignore node_modules.
Besides, using resolve.alias instead of the Webpack's DefinePlugin you restrict the use to a particular problem (which is the one we want solved) and prevent abuse.
For example, just like we have a .env file we could have a .alias file containing a simple object literal.  This is why I used an underscore instead of any other symbol, as it still makes for a valid JS identifier and spares us from quoting the property names:
{
  _utils: './utils',
  _components: './components',
  // ....
}

All relative folder references would be solved relative src/ which should be recommended (and not forced, please).
Thanks and sorry for my lateness.

The reason why I personally don't rely on Webpack resolve.alias for that is that only Webpack would know where the modules are, whereas tests and coverage tools, or the code editor's Intellisense, wouldn't automatically know where they are.

@cecilemuller
In testing, I use jest.mock to replace dependencies, for example:
jest.mock('_store/selectors.js', () => ({
  configSelectors: {
    get: jest.fn((state, name) => state.config[name]),
  },
}));

In this case I am mocking an import with a mock function, but with an .alias file it would be possible to automate the creation of a moduleNameMapper (http://facebook.github.io/jest/docs/en/configuration.html#modulenamemapper-object-string-string)  configuration for jest tests.
I have no solution for editors, except praying for a plugin, eventually.

I'm using babel-plugin-module-resolver in a RN project and it works well with absolute paths and requires minimum configuration.

We’re going to keep supporting NODE_PATH=src as described in earlier comments.
This is enough to keep this issue at bay for now.
We might revisit this later.

For those using react-scripts-ts:

add NODE_PATH=src/ to the .env file (thanks will-stone!)
add "baseURL": "./src" to your tsconfig.json file.

Using the above accepted solution I still can't achieve the following:
import { componentA, componentB } from 'components'
instead I still have to do the following:
import componentA  from 'components/componentA/componentA'
import componentB  from 'components/componentB/componentB'
My component structure is the following:
 src
  components
     componentA
       componentA.js
     componentB
       componentB.js
     index.js

@jasan-s as support questions probably belong on StackOverflow, can you paste your question there and include the contents of your index.js file?

@jasan-s I think that should work if the contents of your 'components/index' is correct ... haven't tried it out with import, only with require, but if your index.js successfully imports the components from the subpaths and then exports them then I don't see why it wouldn' work? Maybe it's the difference between import and require ...

@leob  I get an error using it with import.
index.js file looks as follows:
export  componentA from './componentA/componentA
export  componentB from './componentB/componentB

I'll try stack overflow, see if i can get some help there as well.

@jasan-s try
export  {default as componentA} from './componentA/componentA
export  {default as componentB} from './componentB/componentB

that works :) thanks @will-stone

Wow, {default as ...} syntax that's new for me ... like I said I tried it with require only.

Don't know about you guys but I much prefer using babel-plugin-root-import:
// .babelrc

{
  "presets": [
    "react-app"
  ],
  "plugins": [
    "babel-plugin-transform-es2015-modules-commonjs",
    ["babel-plugin-root-import", {
      "rootPathSuffix": "src/"
    }]
  ]
}

In any component you can import like so:
// From
import someFile from '../../../../utils/someFile';

// To
import someFile from '~/utils/someFIle';

The ~ acts as your project src/ path. Much cleaner imo, not had any issues with it.

@Ehesp I didn't think it was possible to use babel plugins with an un-ejected CRA, if that's the case then this wouldn't be a solution users could add, but maybe something that could be considered by the CRA team to be put directly in to react-scripts? Is it cross platform compatible?

@will-stone Ah yes sorry this is an ejected app!

can't you just symlink ~ to src/ ?

Having checked out VueJS for a while, I'm all in favour of using the "@" prefix to denote the src dir.

I was able to use paths from src folder without dots by adding
NODE_ENV = node_modules:src

to .env file. Cheap and fast solution.

@alexeyraspopov is there technically any benefit to using
NODE_ENV = node_modules:src

over
NODE_PATH=src/

?

My bad, I apologize, it should be NODE_PATH of course. Edited my comment above.

I think the question still remains: do we need to add node_modules to the path, or is this done regardless and we can just specify src?

A quick test shows that you can just set NODE_PATH = src.

Was just about to comment that lol. It does bring vs code's cmd+click feature, but I'm fine with that for shorter imports.

I still can't make this work properly. I have in NODE_PATH=src/ in .env. However, some imports still fail.
This fails:
// Home.jsx
import { Link } from './Links'

This works:
// Home.jsx
import { Link } from './../atoms/Links'

Folder structure:
src/
    app/
        atoms/
            Links.jsx
        pages/
            Home.jsx
        main.jsx
    assets/
```

@alexdevero setting NODE_PATH=src/ would like nable you to import from absolute base path like so in home.jsx.          import Link from 'app/atoms/Links'

@alexdevero setting NODE_PATH=src/ would enable you to import from absolute base path like so in home.jsx.         import Link from 'app/atoms/Links'

That worked. Thank you very much @jasan-s.
Is it somehow possible, without ejecting, to enable import { Link } from './Links' or import { Link } from 'Links'?


Operations with mail notification have failed

Version Info
v18
Describe the bug
Steps followed:
Step 1.
We have cloned the project to Eclipse through the below link
“https://github.com/servicecatalog/oscm.git”
Step 2.
Setup the java preferences from jre to jdk. Then started building the project with.
Firstly run the target
Build.LIB then Build.BES.
The deployable artifacts in/oscm-build/result/package are successfully generated.
Step 3.
The Artifacts are deployed in the respective container
Example:
docker cp /workspace/oscm-build/result/package/oscm-portal/oscm-portal.war 		oscm-core:/opt/apache-tomee/webapps/
Docker setup:

1.
	Installed Docker & Docker Compose.
	Created directory docker with following command:

	mkdir /docker

2.
	Then run the deployer 1 with the below command:

	“docker run --name deployer1 --rm -v /docker:/target servicecatalog/oscm-deployer”

	After this two files are created (ie .env & var.env) and we have edited the var.env file

	Then deployer 2 with the below command:

	“docker run --name deployer2 --rm -v /docker:/target -v 						/var/run/docker.sock:/var/run/docker.sock -e INITDB=true -e STARTUP=true 			servicecatalog/oscm-deployer”

Step 4.
Then we log in to the portal with through
”https://hostname.fqdn:8081/oscm-portal/ ”
with the given credentials

  Username: administrator
  Password: admin123

Step 5.
i) Then we created the marketplace from the below steps
Go to Service catalog Manager->Under that Market place-> Inside that Create market place
ii) Registering new users
Go to Account->Register New Users
Here We are Facing the issue Operation Failed.
Here newly register user also Not Getting Email.
iii) We try to create organization from the following steps
Go to service catalog Manager->Under operation->create organization
Here We are Facing the issue operation Failed
iv) Adding currency to oscm
Go to service catalog Manager->Under operation->Create Payment Service Provider
v) We created Technical Service
Go to Technical Service -> Register Service Definition
-> Import Service Definition
-> Update Service Definition
-> Export Service Definition
         Above Service Definitions are working fine.

vi)Defining price model
Go to service catalog Manager->Under Price model->define for service
working fine
vii)Assigning Marketplace
Assigned the marketplace
vi) When i go to Marketable Service -> Activate Or Deactivate Services
I Tried to activate the Service but facing operation failed issue.
vi) After that Go to Market Place -> Select Market Place
Here I clicked the Browse All Services But it displaying
Services Not Found
Problem Facing:

Operation Failed
2.We Setup and configured var.env files but email is not getting.
Services also not Found.

As i saw in architecture and documentation the default services are available in marketplace,
currently we are not using any cloud adapters we just need to see the default services.
Please help me where am facing the problem and what am missing .Is that cloud adaptor is mandatory to enable the default services also?
Screenshots
If applicable, screenshots to help explain your problem.

@jarunkumarb
Whoops! This is a long description. Basically, you are on the right track. However, the mail service is absoloutly mandatory for OSCM. Thus, if the mail settings are incorrect or the service is not fully functional, OSCM will fail to send mail notifications and show such general error message. In the given case it's the login email to the new user, containing the initial credentials and login URL. You'll find details about the failed operation in the log files (login to oscm-core with docker command and view the files under /logs. In most cases error details can be found in System.log)
So, let's shorten the story. Actually, the mail settings you have set in var.env would be more interesting here than the stuff you have put here. There is better chance that I can help you, if you'd just share me the values of the SMTP settings you have given in var.env. Just mask the parts that should not be disclosed here.
See also the final comment in https://github.com/servicecatalog/oscm/issues/470

Duplicate to #477.


how to search  code in local disk?

any config example?

I guess the config file should look something like:
{
"dbpath" : "data",
"repos" : {
"My_local_repo" : {
"url" : "file://location/to/your/repo"
}
}
}

Yes that's right. I'll add an example to config-example.json as well.


✨ Add NZBGet download client

Thank you for contributing to Homarr! So that your Pull Request can be handled effectively, please populate the following fields (delete sections that are not applicable)
Category

One of: Bugfix / Feature / Code style update / Refactoring Only / Build related changes /  Documentation / Other (Please specify!)

Feature
Overview

Briefly outline your new changes...

Added NZBGet to the Sabnzbd module.
Changed Sabnzbd naming to "Usenet" to reflect that both NZBGet & Sabnzbd can be used now.
Implemented NZBGet API

Issue Number (if applicable)

Related issue: #00

#282
New Vars (if applicable)

If you've added any new build scripts, environmental variables, config file options, dependency please outline here.

I added a new library that helps in working with the NZBGet api: "nzbget-api": "0.0.3"
Screenshot (if applicable)

If you've introduced any significant UI changes, please include a screenshot.

I'll switch target branch to dev as requested

Can we merge?

Can we merge?

yup, merging now ! @jonjon1123 thank you so much for this PR once again. Sorry It had to take time to get approved

Amazing 🤩 Is there anything else we want to merge for 0.10.4?


'tput reset' (cls-like command) won't work

Related to: #1369 #1441 (and probably others)

Description: I usually define alias cls='tput reset' to get a unix equivalent for
Build number: 14393.447 (but apparently still not solved).
Steps to reproduce: just maximize the console window and execute tput reset
Expected result: the full screen scrollback clears (like cls in cmd.exe).
Actual result: interestingly, not only occurs what happens with just clear (like the other reports), but also the actual console window shrinks (smaller vertical size).

Notes:
What tput reset does is similar to the related bugs: it prints an escape code (obtained from terminfo database).
In particular, you can get the same result with: echo -e '\033c\033[!p\033[?3;4l\033[4l\033>'
This escape code was extracted by this little trick: tput reset | sed -n l
Trying with another TERM produces similar results: TERM=rxvt tput reset.
Additional info: https://www.gnu.org/software/termutils/manual/termutils-2.0/html_chapter/tput_1.html

Isn't \033c not fully implemented?  There is another thread that.

Ah, you are right: I just checked it tput reset is sending \033c\033[!p\033[?3;4l\033[4l\033> and the part after \033c is the same as tput init (equivalent to 'printf \033[!p\033[?3;4l\033[4l\033>').
Apparently, I forgot that I also chose tput reset in case I messed with the terminal (ej. ncurses) or used cat on a binary file by accident.
So, I guess, I restrict the scope of this report to the resizing behaviour (this it doesn't happen in linux).

Does it set the terminal exactly back to 80x24 (size of a hardware terminal)?

I just counted: it sets width to 80 columns and doesn't modify the height.
Is this some kind of expected behaviour? Again, I never remember something similar in linux, but probably because of the particular terminal programs I used.

@japm48 Yup. Look at the subsequence 033[?3;4l.  This says "set 80 column mode and fast scroll mode" according to the xterm documentation

So aside from the broken \033c, I have to say that this is the expected behavior according to the spec.

OK, I just tried with a Linux install, installed xterm and typed those commands, there is no resize behaviour at all. But according to the spec it does what is expected.
Thanks for the explanation.

@japm48 On a Linux version of xterm, does tput print that control sequence?

I just made some tests.
tput reset prints:

In Xterm and Konsole (they set TERM=xterm):
\033c\033[!p\033[?3;4l\033[4l\033> (same as before)
In LXTerminal and Gnome Terminal (they set TERM=xterm-256color):
\033c\033]104\a\033[!p\033[?3;4l\033[4l\033>
In a ssh session (TERM=rxvt):
\033>\033[1;3;4;5;6l\033[?7h\033[m\033[r\033[2J\033[H\033[r\033[m\033\*[2J\033[H\033[?7h\033[?1;3;4;6l\033[4l\033=\033[?1000l\033[?25h
(there is "new line" in * I don't know how to escape that)

In the GUI window is never resized in those cases.
Also:

In a getty virtual console (Ctrl+Alt+Fn) (TERM=linux):
\033c\033]R

But of course there is no GUI

@japm48 Yeah, I already figured it out. xterm ignores those control sequences unless it is launched with the mode -132.

OK, you just answered just after I pressed send :)
In that case, should the default behaviour be changed to match the Linux defaults?

@japm48 I dunno, we'll see.  The console team probably just implemented that control sequence because they were reading down the control sequence documentation and just did it, not realizing that it was ignored on real xterm.

Thanks. It's interesting to learn all that, and I didn't know where to search.
I'll wait for an official response, meanwhile I'll be using mintty, which behaves more like linux.

@japm48 You give me too much credit. I just read the terminfo/ncurses FAQ yesterday and then did some web-search-fu.

@japm48 @fpqc
Thanks for shedding light on this. Yes, I implemented CSI ? 3 h/l correctly, initially because we were using vttest to judge our terminal capabilities, and that's what it uses to clear the screen and setup (IIRC).
This is just one of many cases where the actual behavior of the terminal does not directly match any of the previous specs I read, but instead was documented in another previously unknown spec. I'll make a bug number for tracking and disabling this by default.
Yes, ESC c is not implemented at the time, I might be able to slip that in with fixing this though.

@zadjii-msft You know, it would be pretty cool if you teamed up with the Powershell people and added something like "Powerterm", which would spawn a terminal-processing-mode-compatible version of Powershell in a conhost window with terminal processing enabled (They should be able to backport the code from the Linux edition of Powershell to the  Windows one).
This would also fix that Win32-Openssh problem I mentioned over on that issues page (the one I pinged you on).

The right equivalent for CLS is surely tput clear anyway.  That is, in effect, what the clear_console command does.

Closing dangling console tag. If I follow this one, it correctly it came down to:

so, I should restrict the scope of this issue to the window resizing behaviour (this it doesn't happen in linux).

I just tried printf '\e[8;50;100t' and the terminal resize sequences appear to work for me in Windows Console on 17713. What sequence tput reset sends is controlled by your TERM variable and terminfo. There's really no "correct" answer to that, and there is no specific "Linux" behaviour. [DEC VT200 terminals are notoriously difficult to resize without a trash compactor.] Further discussion to the Windows Console Issue Tracker.


Add total records counter

Features
🚀 Add total records counter

@JakeDluhy exactly. The subtitle of the list view shows the number of all records of that resource in the database and the active quick-filter tab should show the number of records matching that filter.


[Doc Improvement][Update bots-conv-channel][3315611]

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/resources/bot-v3/bot-conversations/bots-conv-channel.md
86
15
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/resources/bot-v3/bot-conversations/bots-conv-channel.md
86
15
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.


Investigate ExcelJS (Excel manipulation library) and Jacob (lexer/parser) libraries

ExcelJS
https://github.com/guyonroche/exceljs
Reasons:

Add colors to XLSX files
reduce size of required library

Jacob
https://github.com/Canna71/Jacob
http://dailyjs.com/2015/03/05/jacob/
Reasons:

Reduce size of the parser (now the parser is about 50% of Alasql code)
Make parsing faster

You could also look into if you could use
https://github.com/thinkpad20/sql
and compile the C code via emscripten to asm.js for this part of the library - check out
http://ejohn.org/blog/asmjs-javascript-compile-target/

xlsx has a branch that allows exporting fill and font colors.   Passing thought re size of parser, is it possible to make xlsx external to alasql and imported via a separate

xlsx has a branch that allows exporting fill and font colors.
I could not find this branch. Could you provide url? It is a really good news.

The current branch is https://github.com/protobi/js-xlsx.  Formats are specified by the .s attributes in a cell, as in {v: 1.618, s: { numFmt: "0.00", fill: { bgColor: { rgb: "#FFFFAA00"}}}}
Aim to present this a pull request as complete unit testing and no further edge cases arise, and am supporting this until then.

Please confirm that this issue can be closed


Last valid point as read_type

Demand for new functionality:
Example call:
df = c.read(['BA:CONC.1'], '05-Jan-2020 08:00:00', '05/01/20 11:30am', 60, read_type=tagreader.ReaderType.LastValid)
This should return data with a time step of 60 seconds. At each time step the data returned should be the last valid data point recorded before this.
Example: for the example call the first time step is 05-Jan-2020 08:00:00. The value given back should here be the last valid data point before this. This data point could be 1 second before or 1 month before, whatever is in the IMS.
The next time step is 05-Jan-2020 08:01:00. The value given back will be the same as for the first time step unless there is new valid time steps between 08:00:00 and 08:01:00. If there are several, the one closest to 05-Jan-2020 08:01:00 should be chosen.

Agreed. I have also come across problems where this would be useful.
This function would be equivalent to pandas "forward fill" function: https://pandas.pydata.org/docs/reference/api/pandas.core.resample.Resampler.ffill.html#pandas.core.resample.Resampler.ffill
A workaround is to export RAW data from tagreader and then resample the data with pandas forward fill.

For the moment we do mostly maintenance and bug fixes for the Tagreader repo and do not implement new functionality at this time. But we have decided to put this issue into our board and discuss if we should look into it. I will update you once we decide what to do.


System.TypeLoadException Could not load type IdentityManager.Configuration.IdentityManagerServiceFactory

here is my implementation, copied from the Vimeo video, latest nugget's all updated to current versions?
using Microsoft.Owin;
using IdentityManager;
using IdentityManager.Configuration;
using IdentityManager.AspNetIdentity;
using Owin;
using IdentityManager.Models;
using Microsoft.AspNet.Identity.EntityFramework;
using Microsoft.AspNet.Identity;
[assembly: OwinStartupAttribute(typeof(IdentityManager.Startup))]
namespace IdentityManager
{
public partial class Startup
{
public void Configuration(IAppBuilder app)
{
ConfigureAuth(app);
        app.Map("/idm", idm =>
            {
                var factory = new IdentityManagerServiceFactory();
                factory.IdentityManagerService = new Registration<IIdentityManagerService, ApplicationIdentityManagerService>();
                factory.Register(new Registration<ApplicationUserManager>());
                factory.Register(new Registration<ApplicationUserStore>());
                factory.Register(new Registration<ApplicationRoleManager>());
                factory.Register(new Registration<ApplicationRoleStore>());
                factory.Register(new Registration<ApplicationDbContext>());

                idm.UseIdentityManager(new IdentityManagerOptions
                {
                    Factory = factory
                });
            });
    }
}

public class ApplicationUserStore :UserStore<ApplicationUser>
{
    public ApplicationUserStore(ApplicationDbContext ctx)
        : base (ctx)
    {
    }
}

public class ApplicationRoleStore : RoleStore<IdentityRole>
{
    public ApplicationRoleStore(ApplicationDbContext ctx)
        : base(ctx)
    {
    }
}

public class ApplicationRoleManager : RoleManager<IdentityRole>
{
    public ApplicationRoleManager(ApplicationRoleStore roleStore)
        : base(roleStore)
    {
    }
}

public class ApplicationIdentityManagerService : AspNetIdentityManagerService<ApplicationUser, string, IdentityRole, string>
{
    public ApplicationIdentityManagerService(ApplicationUserManager userMgr, ApplicationRoleManager roleMgr)
        : base(userMgr, roleMgr)
    {
    }
}

}
Can anyone see what I am doing wrong?

Did you get the sample working?

No I didn’t, still no go, to be honest I haven’t played with this since the post, was hoping someone would see some stupid mistake I couldn’t
From: Brock Allen
Reply-To: IdentityManager/IdentityManager
Date: Tuesday, 4 August 2015 12:53 am
To: IdentityManager/IdentityManager
Cc: Jason Coley
Subject: Re: [IdentityManager] System.TypeLoadException Could not load type IdentityManager.Configuration.IdentityManagerServiceFactory (#153)
Did you get the sample working?
—
Reply to this email directly or view it on GitHubhttps://github.com/IdentityManager/IdentityManager/issues/153#issuecomment-127221736.

I guess the next question is "what is the error"?

{"Could not load type 'IdentityManager.Configuration.IdentityManagerServiceFactory' from assembly 'IdentityManager, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null'.":"IdentityManager.Configuration.IdentityManagerServiceFactory"}
From: Brock Allen
Reply-To: IdentityManager/IdentityManager
Date: Tuesday, 4 August 2015 12:55 am
To: IdentityManager/IdentityManager
Cc: Jason Coley
Subject: Re: [IdentityManager] System.TypeLoadException Could not load type IdentityManager.Configuration.IdentityManagerServiceFactory (#153)
I guess the next question is "what is the error"?
—
Reply to this email directly or view it on GitHubhttps://github.com/IdentityManager/IdentityManager/issues/153#issuecomment-127222426.

Happens in the Startup Configuration
app.Map("/idm", idm =>
            {

                var factory = new IdentityManagerServiceFactory();

                factory.IdentityManagerService = new Registration<IIdentityManagerService, ApplicationIdentityManagerService>();

                factory.Register(new Registration<ApplicationUserManager>());

                factory.Register(new Registration<ApplicationUserStore>());

                factory.Register(new Registration<ApplicationRoleManager>());

                factory.Register(new Registration<ApplicationRoleStore>());

                //factory.Register(new Registration<ApplicationDbContext>());

                idm.UseIdentityManager(new IdentityManagerOptions

                {

                    Factory = factory

                });

            });

From: Brock Allen
Reply-To: IdentityManager/IdentityManager
Date: Tuesday, 4 August 2015 12:55 am
To: IdentityManager/IdentityManager
Cc: Jason Coley
Subject: Re: [IdentityManager] System.TypeLoadException Could not load type IdentityManager.Configuration.IdentityManagerServiceFactory (#153)
I guess the next question is "what is the error"?
—
Reply to this email directly or view it on GitHubhttps://github.com/IdentityManager/IdentityManager/issues/153#issuecomment-127222426.

I’ll have a shot at it again tomorrow, when I’m fresh, 1am here right now, will start from scratch and see if I can sort it.
From: Brock Allen
Reply-To: IdentityManager/IdentityManager
Date: Tuesday, 4 August 2015 12:55 am
To: IdentityManager/IdentityManager
Cc: Jason Coley
Subject: Re: [IdentityManager] System.TypeLoadException Could not load type IdentityManager.Configuration.IdentityManagerServiceFactory (#153)
I guess the next question is "what is the error"?
—
Reply to this email directly or view it on GitHubhttps://github.com/IdentityManager/IdentityManager/issues/153#issuecomment-127222426.

Oh sorry -- I missed it in the title (I was only reading the body of your issue).
So it compiles but you get a runtime load exception? Odd.

I'll hold my hands up on this issue. I did exactly the same thing as in the code above - the issue is a namespace / assembly clash. Update the namespace and assembly name for your project to something other than "IdentityManager" e.g. ".IdentityManager".
Hope that helps! :)

Ah that's probably it. Can you check that @JasonColeyNZ?

Perfect, that was it, thank you very much!


README refers to distutils-sig for questions, but isn't discuss.python.org used now?

The readme says: Questions and comments should be directed to the distutils-sig mailing list. Bug reports and especially tested patches may be submitted directly to the bug tracker. However on the mailing list I can find prodding to move a packaging related to https://discuss.python.org/ instead - which looks like it's taking things over regarding packaging discussions.
So is distutils-sig still used? If not, maybe the readme should be changed!

It's still used.


[PDI-13264] load file content in memory step errors when filename is defined in field

Array Out Of Bounds Exception was fixed
error message was translated into English

@mbatchelor @pamval @mchen-len-son @bmorrise please review

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -Dsurefire.runOrder=alphabetical -B -fn -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd clean install && mvn -B -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd site

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  engine/src/main/java/org/pentaho/di/trans/steps/loadfileinput/LoadFileInput.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes: <0.1% (click to expand)
org.pentaho.di.trans.step.StepMeta

Branch Change: -0.7% :small_red_triangle_down:
Complexity Change: -0.6% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:
Line Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.dbproc.DBProcMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.dimensionlookup.DimensionLookupMeta

Branch Change: -1.2% :small_red_triangle_down:
Complexity Change: -0.7% :small_red_triangle_down:
Instruction Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.groupby.GroupByMeta

Branch Change: -2.1% :small_red_triangle_down:
Complexity Change: -2.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.tableoutput.TableOutputMeta

Branch Change: -0.9% :small_red_triangle_down:
Complexity Change: -0.8% :small_red_triangle_down:

org.pentaho.di.trans.steps.gpload.GPLoadMeta

Branch Change: -0.9% :small_red_triangle_down:
Complexity Change: -0.8% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.ui.repository.pur.repositoryexplorer.model.UISecurityRole

Branch Change: -1.8% :small_red_triangle_down:
Complexity Change: -1.5% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:
Line Change: -0.5% :small_red_triangle_down:

@mbatchelor @pamval @mchen-len-son @bmorrise please review

@pamval @mbatchelor @duarteteixeira @smaring please review

@bmorrise @pamval please review


Add title prefix for tw/grub2-bls

On TW with grub2-bls the entry order is only based on the filename. This patch adds version prefix (snapshot ID) in the filename for the non-ro entries, and 0 for the ro ones

cc @TobiPeterG

This issue sounds more like an issue on the grub-bls side. The bootloader specification specifically mentions that the version specified in the entry file is used for sorting
https://uapi-group.org/specifications/specs/boot_loader_specification/#sorting
"version is a human-readable version for this menu item. This is usually the kernel version and is intended for use by OSes to install multiple kernel versions with the same title field. This field is used for sorting entries, so that the boot loader can order entries by age or select the newest one automatically."
Also, we set the sort-key, so it should be sorted by that at least.
I'm not sure if we should "fix" this on our side with a workaround.

Also, how would we remove this workaround again when it gets fixed?
Also, the file name is used in other parts as well, isn't it?

This issue sounds more like an issue on the grub-bls side.

It is, yes.

The bootloader specification specifically mentions that the version specified in the entry file is used for sorting https://uapi-group.org/specifications/specs/boot_loader_specification/#sorting

Yes, but also the filename:
"""
At the end, if necessary, when sort-key is not set or those fields are not set or are all equal, the boot loader should sort using the file name of the entry (decreasing version sort), with the suffix removed.
"""

I'm not sure if we should "fix" this on our side with a workaround.

I can try to fix it in grub2-bls, but this will take months.

Also, how would we remove this workaround again when it gets fixed?

I am not sure that it will fixed. But if this happens then a 'remove-all-kernels' / 'add-all-kernels' recreate the entries with the new name.

The file name is used in other functions as well, isn't it?

How this change affect those functions?

This issue sounds more like an issue on the grub-bls side.

It is, yes.

The bootloader specification specifically mentions that the version specified in the entry file is used for sorting https://uapi-group.org/specifications/specs/boot_loader_specification/#sorting

Yes, but also the filename:
""" At the end, if necessary, when sort-key is not set or those fields are not set or are all equal, the boot loader should sort using the file name of the entry (decreasing version sort), with the suffix removed. """

Yes, after the sort-key at least.

I'm not sure if we should "fix" this on our side with a workaround.

I can try to fix it in grub2-bls, but this will take months.

ouch, that's not great of course.
However, I see multiple places in sdbootutil where the config file is used directly. We would have to change all of them.
Also, again, how canwe revert this? Having two naming schemes isn't optimal and I would not like to have this permanently. But when we revert it, the affected entries would not be recognized by sdbootutil anymore.

Also, how would we remove this workaround again when it gets fixed?

I am not sure that it will fixed. But if this happens then a 'remove-all-kernels' / 'add-all-kernels' recreate the entries with the new name.

But then sdbootutil has to always carry the logic to detect these different file names, wouldn't it? How else would sdbootutil find the to-be-removed entries?

The file name is used in other functions as well, isn't it?

How this change affect those functions?

We wouldn't be able to find the entries with sdbootutil anymore when it's not changed at these other places as well, at least in those functions.

However, I see multiple places in sdbootutil where the config file is used directly. We would have to change all of them.

Maybe I can refactor the code a bit, to compose the entry file name in a single place.

Also, again, how canwe revert this? Having two naming schemes isn't optimal and I would not like to have this permanently. But when we revert it, the affected entries would not be recognized by sdbootutil anymore.

Right. Sadly software out there is full of those imperfections and limitations, and somehow we need to deal with them. There are other bootloaders that support BLS (zipl, and one other for powerpc), and they will have their quirks and bugs too, and we should adapt to those (I do not think that they are opensource)
The BLS does not says that the filename should be formatted in any specific way, and sdbootutil make an early decision that seems that does not cover all the situations.

However, I see multiple places in sdbootutil where the config file is used directly. We would have to change all of them.

Maybe I can refactor the code a bit, to compose the entry file name in a single place.

Also, again, how canwe revert this? Having two naming schemes isn't optimal and I would not like to have this permanently. But when we revert it, the affected entries would not be recognized by sdbootutil anymore.

Right. Sadly software out there is full of those imperfections and limitations, and somehow we need to deal with them. There are other bootloaders that support BLS (zipl, and one other for powerpc), and they will have their quirks and bugs too, and we should adapt to those (I do not think that they are opensource)
The BLS does not says that the filename should be formatted in any specific way, and sdbootutil make an early decision that seems that does not cover all the situations.

OK, then maybe an alternative solution. I don't like the idea of setting a prefix to 0. How about this: We set snapper- as prefix for tumbleweed, when it's a entry created as ro snapshot and we move the snapshot number right behind it.
So we would have e.g.
opensuse-tumbleweed-469-6.8.7-lqx2-2-liquorix.conf as regular entry
and
snapper-opensuse-tumbleweed-470-6.8.7-lqx2-2-liquorix.conf
Would this sort correctly? I wouldn't mind using this naming scheme for systemd-boot as well, it includes the sort-key and version :)

The refactor is a good idea any way, I'm not a fan of having the magic numbers/strings all over the script, but it also didn't bother me too much yet lol.
The path for the snapshtos is also hardcoded in some places, don't like that either.

I don't like the idea of setting a prefix to 0.

Me neither ...

How about this: We set snapper- as prefix for tumbleweed, when it's a entry created as ro snapshot and we move the snapshot number right behind it. So we would have e.g. opensuse-tumbleweed-469-6.8.7-lqx2-2-liquorix.conf as regular entry and snapper-opensuse-tumbleweed-470-6.8.7-lqx2-2-liquorix.conf

I think this will work. I added 0- to avoid the issue when token-id is is hash that start with a number. Adding only snapper- will fix the issue if for the non-RO we adder ${snapshot-number}- as prefix, as the number will be sorted first.

Wait, what is the issue? The snapper entries would always be below the regular entries, wouödn't they? If the token-id is part of the name, it starts with a number, and otherwise it starts with opensuse, which is also beofre snapper.

Would this sort correctly? I wouldn't mind using this naming scheme for systemd-boot as well, it includes the sort-key and version :)

lets start with the refactor and adding the snapper prefix, from there we can iterate to find a good naming schema

That's a good idea :)

Wait, what is the issue? The snapper entries would always be below the regular entries, wouödn't they? If the token-id is part of the name, it starts with a number, and otherwise it starts with opensuse, which is also beofre snapper.

Yes and no. The snapper entries should be listed below, but the token_id can be many things: can be opensuse, something provided by the user, or the machine id (see https://github.com/openSUSE/sdbootutil/blob/main/sdbootutil#L362).  So there is a chance that the token contains numbers that alter the order.

Wait, what is the issue? The snapper entries would always be below the regular entries, wouödn't they? If the token-id is part of the name, it starts with a number, and otherwise it starts with opensuse, which is also beofre snapper.

Yes and no. The snapper entries should be listed below, but the token_id can be many things: can be opensuse, something provided by the user, or the machine id (see https://github.com/openSUSE/sdbootutil/blob/main/sdbootutil#L362). So there is a chance that the token contains numbers that alter the order.

But if "snapper-" is always in front of the filename, how can that happen? Or do you mean the regular entries could have a token that makes them move after the snapper entries?

But if "snapper-" is always in front of the filename, how can that happen? Or do you mean the regular entries could have a token that makes them move after the snapper entries?

No, that is what I mean. We need to add '0-' or 'snapper-'. I added now 'snapper-', this will fix the ordering.
 I am still using - as separator

But if "snapper-" is always in front of the filename, how can that happen? Or do you mean the regular entries could have a token that makes them move after the snapper entries?

No, that is what I mean. We need to add '0-' or 'snapper-'. I added now 'snapper-', this will fix the ordering.
 Can you provide an example where it would break without adding "1-" as prefix for the regular entry?

I might be dumb. Can you provide an example where it would break without adding "1-" as prefix for the regular entry?

If token_id="$machine_id", and $machine_id="20fe...", then "1-" will be shown later than "20fe...-", but adding "snapper-" as a prefix, "1-" will be shown before than "snapper-20fe..."

In this example, we would have the entries

Ah you are asking without adding the prefix then? In that case if "token_id" is used provided and start by some letter after 's' it will be put after snapper, right?
For example, token_id=$(cat /etc/kernel/entry-token) (see settle_entry_token), and token_id="xyz", then "xyz-.." will be put after "snapper-xyz-.."

Ah alright, now it makes sense. Thank you :)
Didn't think about this scenario. Hmm. The "1-" in front is still not very nice. But I guess checking if the entry_token contains opensuse and if not, adding it as prefix to the file name is a bit too complicated, right?

The "1-" in front is still not very nice. But I guess checking if the entry_token contains opensuse and if not, adding it as prefix to the file name is a bit too complicated, right?

Pff... we can use rpmdev-vercmp, but is in the rpmdevtools package, and I we should not depend on it. We can use zypper vcmp but some users are using dnf as package manager.
The last option is rpm --eval "%{lua:print(rpm.vercmp('1.2-1', '2.0-1'))}" (saw in stackoverflow). Do you want to use this?

Also, 'snapper-' is bigger than 'opensuse-', so 'snapper-' will appears always on top : S

oof I think this is all too complicated.
Do I understnad you correctly that the snapper- doesn't work?
Then the 0- and 1- is probably the best solution, even though I really don't like it. :D

oof I think this is all too complicated.

This works:
'1-opensuse-tumbleweed-6.9.5-1-default-1.conf' > '0-opensuse-tumbleweed-6.9.5-1-default-1.conf'
This also works:
'1-opensuse-tumbleweed-6.9.5-1-default-1.conf' > 'snapper-opensuse-tumbleweed-6.9.5-1-default-1.conf'
But this does not:
'opensuse-tumbleweed-6.9.5-1-default-1.conf' < 'snapper-opensuse-tumbleweed-6.9.5-1-default-1.conf'
In the initial code I implemented the first one, in this current code I implemented the second one

Alright, then let's keep it that way. :)
Will have a look at the code later on :)

This should also work:
'system-opensuse-tumbleweed-6.9.5-1-default-1.conf' > 'snapper-opensuse-tumbleweed-6.9.5-1-default-1.conf'

This should also work:
'system-opensuse-tumbleweed-6.9.5-1-default-1.conf' > 'snapper-opensuse-tumbleweed-6.9.5-1-default-1.conf'

Uh adding system is better, I like that :)

Uh adding system is better, I like that :)

Done : )

code-wise, it's looking good so far. Have you tested the changes thoroughly? I don't want to introduce breaking changes again lol
(so UI, install command, remove command etc.)

Oh one thing: the current entries won't be recognized anymore, right? We should handle this as well, as e.g. Aeon uses systemd-boot by default already with sdbootutil.

code-wise, it's looking good so far. Have you tested the changes thoroughly?

I tested in the new TW / GRUB2-BLS images and in the TW / sd-boot ones, to see that the entries have a different name schema.
But not the UI, I was planning to remove this feature

I don't want to introduce breaking changes again lol (so UI, install command, remove command etc.)

What breaking change did we introduced?

Oh one thing: the current entries won't be recognized anymore, right? We should handle this as well, as e.g. Aeon uses systemd-boot by default already with sdbootutil.

Not exactly? The current entries are fine for the current systems. Aeon uses sd-boot and this name schema did not change. You can see in the code that only in non transactional with grub2 the name is not different, but there is not a released image with this combination yet


[Feature] Insert messages

Is your feature request related to a problem? Please describe.
I cannot insert messages at specific points in the chat.
Describe the solution you'd like
Ability to insert messages anywhere in the chat for better customization and guidance.
Describe alternatives you've considered
I have to write a random message so I can edit it and its response.
Additional context
An idea is to add a plus sign (+) before and after every message to insert one or multiple messages.
Thank you. Really appreciate your work.


Add check for undefined header in Column resizer

Changes

When resizing the last column that is column manager in expand mode, the table crashes with error "cannot read properties of undefined" which seem to occur from using getHeaderWidth function. So I added a check within that function to see whether if header is undefined and return 0.
Closes #1004
Testing

Tested column manager table in Storybook with extra prop isResizable=true and columnResizerMode='expand'

Docs

Added changeset

@elephantcatdog the storybook story works.

So this doesn't show the error anymore, but it doesn't allow me to actually resize the column in the example the user sent in. Does it work for you in the storybook story?

The storybook story works-ish..? I'm not too confident about the expected behavior though:
![column resize test](https://user-images.githubuserc
For user's example, I think it works too but it increases the width of the table instead which makes the horizontal scroll appear while things look unchanged..?

ontent.com/22462084/227565395-2e4b4453-878b-4770-a974-6f48db36fee1.gif)
I was thinking that we disable resizing for the the selection/first column, should we do the same for column manager column? That would keep the table width the same too. But I'm not sure what the expected behavior should be.

@LostABike Oooh, I see now. I was trying to make the column manager column bigger, but I actually don't see a reason for that to be bigger IMO. In that case, I tested it and this looks good to me.

It fixes the error but now I can make columns smaller than table.

I can't seem to reproduce this 😮 I used the user's example to run locally in vite, which I believe was what you did as well. Could you elaborate on how you were able to reproduce that bug?

Could you elaborate on how you were able to reproduce that bug?

https://user-images.githubusercontent.com/83585998/229789879-fdb1976a-87ea-4752-89fd-d990a4901636.mov
I think it's something with how we calculate min width of the column based on table width.

Sounds good to me. Lets merge this PR and reopen the issue.


BAU: Fix e2e tests timeout issue

There is a commit made to app/views/prove_identity/prove_identity.html.erb in verify-frontend which replaces heading-large with govuk-heading-l. (Source: https://github.com/alphagov/verify-frontend/commit/a10ba86528de564602337a8aadbbc2e069f959bd?diff=split). This causes e2e tests to wait indefinitely for non-existent header level 1 labelled with heading-large. This change updates e2e tests to look for header level 1 labelled with govuk-heading-l. This should fix the timeout issues.
I ran e2e tests and they passed.
  A non-matching journey
    when eIDAS is not selected
      ✓ should succeed (6780ms)
    when eIDAS is selected
      ✓ should succeed (5213ms)
    when eIDAS assertions are unsigned
      ✓ should succeed (4869ms)

  3 passing (17s)

Done in 24.84s.

Author: @adityapahuja

Closing the pull request. Verify team will look into it.


ISPN-9025 Transaction leak when API invoked with invalid arguments

https://issues.jboss.org/browse/ISPN-9025

@danberindei In case you missed the previous question... Pedro prefers using this::someMethod as an argument to some method calls. Will you convince him to cache the method handle?

Otherwise this PR looks good.

@danberindei This PR is still waiting for your attention.

I also suggest adding this as well: https://github.com/infinispan/infinispan/pull/5458/files#diff-439b4a1c3c5af3b0206440bb243e742cR63

run performance tests please

@danberindei @rvansa updated as requested :(

@rvansa done! don't forget to let CI do a full run :)

run performance tests please

I don't think the EntityCollectionInvalidationTest failure is related, despite I really dislike to see such failure. Integrating.

Looks like performance didn't change too much by caching the creator function. And the -2.95% throughput on repl non-tx writes with 100 threads is a bit worrisome...

Uh, I haven't noticed that one. Could you guess the cause @pruivo ?
I wouldn't expect a noticeable difference for a one lambda allocation, that hides easily into the noise.

IMO, it is noise. If it was something serious, it would affect all the writes and the dist-writes with 100 threads are fine.

run performance tests please

@danberindei The noise might not be in the run we trigger here but also in the baseline run (being too good).


Travis builds timing out

Off late, most Travis builds seem to hang at:
adding /home/travis/.cache/sccache to cache
creating directory /home/travis/.cache/sccache
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#build-times-out-because-no-output-was-received

The build has been terminated

The linked FAQ seems quite generic. Anyone with more Travis experience?

Have a look at this.

Ah, Google pointed me to that as well, deleted the cache, and Job # 578.1 seems to be building.


Prover demo

@bkolad, We made some pretty significant changes to the SDK while you were gone. This PR is big, and will probably need a few iterations - let's plan hop on a call and go through  it all as a team on Monday. Before then, here's a summary of what happened to help get you up to speed.
Broadly speaking, these changes fall into three camps - updates to feature-gating / dependencies (necessary to allow building under Risc0), API changes, and functional changes. The API changes are made with the goal of making the state transition function a black box to the full node implementation.
There are three major API changes, which I recommend you review separately.

Combine the apply_batch/apply_proof API. Previously, the apply_batch and apply_proof methods required their arguments to be typed - which meant that the full node implementation needed to run a deserializer. This gave the full node discretion over what should happen when the serialization was invalid, which we don't want - the STF should decide for itself what to do in that case. This commit updates the API to work on serialized inputs - which meant that apply_batch/apply_proof now have identical signatures - so the commit merged them into a single apply_blob method.
Have apply_blob return a receipt. Rather than returning a set of events, apply_blob now returns a structured receipt - which allows it to communicate to the full node exactly what it wants to have stored and served via RPC in a generic way.
Pass a witness into begin_slot() and return it from end_slot. This is necessary to support zk verification.

There is also one significant functional change. RevertableDelta has been simplified so that all writes are immediately applied to the underlying Delta, only writes are cached. This change spans the four commits from "Simplify revertable delta. Bug fixes in apply_blob" to "Cleanup. Introduce OrderedReadsAndWrites type.". This change was introduced to fix a bug which caused the prover and the verifier to disagree about what the contents of the witness should be. At this point, I'm not certain of the exact cause of that bug because the caching logic was too complex to debug properly. The new logic fixes the bug and is easier to reason about.


Connect from local machine to Cloud Virtual Machine

Hello @vladmandic,
I recently can across your stream-rtsp project, so far I have successfully run it on my local machine. However, I want to be able to view my local rtsp stream on a  cloud virtual machine. What approach will you recommend? also, do I need to set up a turn/stun server for this project? Thanks

@gigwegbe this package is intended to work in peer-to-peer mode and as long as server and client ips are directly reachable, it should be ok regardless of location. it's not intended to work with stun server as-is (although it could be made to work, but it would require implementing an additional handshake).


cinnamon.nemo: Workaround duplicate right-click menu items

Description of changes
Don't populate nemo actions from /run/current-system/sw/share, they should only be loaded exactly once as $out/share.

Helps https://github.com/NixOS/nixpkgs/issues/190781 (don't close it for now).

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@ofborg build cinnamon.nemo
@ofborg test cinnamon


Generate image sequence from the saved mask data

##I've made a python script that converts the npy files saved in a folder to png with full black and full whites. It has a basic gui.
import tkinter as tk
from tkinter.filedialog import askdirectory
from PIL import Image
import os
import numpy as np
def set_everything_not_black_to_full_white(image):
"""Sets all pixels in an image that are not black to full white.
Args:
    image (Image): The image to modify.

Returns:
    The modified image.
"""
image = np.array(image)
image[image != 0] = 255
return Image.fromarray(image)

def convert_npy_to_png(npy_file):
"""Converts a numpy image file to a grayscale png file.
Args:
    npy_file (str): The path to the numpy image file.

Returns:
    None.
"""
image = Image.fromarray(np.array(np.load(npy_file)).astype(np.uint8)).convert("L")
image = set_everything_not_black_to_full_white(image)
image.save(npy_file.replace(".npy", ".png"))

def main():
"""The main function."""
# Create the GUI window.
root = tk.Tk()
# Create a label for the folder selection.
folder_label = tk.Label(root, text="Select a folder containing npy image files:")
folder_label.pack()

# Create a text entry box for the folder selection.
folder_entry = tk.Entry(root)
folder_entry.pack()

# Create a button to select the folder.
select_folder_button = tk.Button(root, text="Select Folder", command=lambda: select_folder(folder_entry))
select_folder_button.pack()

# Create a button to convert the npy files to png files.
convert_npy_files_button = tk.Button(root, text="Convert NPY Files to PNG Files", command=lambda: convert_npy_files(folder_entry.get()))
convert_npy_files_button.pack()

# Start the GUI event loop.
root.mainloop()

def select_folder(folder_entry):
"""Selects a folder and updates the folder entry.
Args:
    folder_entry (tk.Entry): The text entry box for the folder selection.

Returns:
    None.
"""
# Get the selected folder.
folder = askdirectory()

# Update the folder entry.
folder_entry.delete(0, "end")
folder_entry.insert(0, folder)

def convert_npy_files(folder):
"""Converts all npy files in the specified folder to grayscale png files.
Args:
    folder (str): The path to the folder containing the npy files.

Returns:
    None.
"""
# Get all the npy files in the folder.
npy_files = [f for f in os.listdir(folder) if f.endswith(".npy")]

# Convert each npy file to a png file.
for npy_file in npy_files:
    convert_npy_to_png(os.path.join(folder, npy_file))

if name == "main":
main()


Err-001 Page does not load

When deploying the Page it does not refer to the proper CSS and JS. It needs to also clear the CSS.
Change and re-deploy.

There was a problem with the paths for the CSS/JS. Amend paths.
Problem solved.


only id data parsing

If I try to get data from below json format from my .net json api
{
"values": [
{
"id": "2021-01-19T17:36:59.627",
"count": "<IP_ADDRESS>.01",
"some_boolean": "<IP_ADDRESS>.011-01-01",
"module": "Batch",
"state": "ACTIVE"
},
{
"id": "2021-01-19T17:36:59.628",
"count": "<IP_ADDRESS>.02",
"some_boolean": "<IP_ADDRESS>.011-01-02",
"state": "INACTIVE"
},
{
"id": "2021-01-19T17:36:59.629",
"count": "<IP_ADDRESS>.03",
"some_boolean": "<IP_ADDRESS>.011-01-03",
"state": "ACTIVE"
}
]
}
Its only parsing "id"
rest all giving error
Kindly help me to get data from diff format given below
{
"values": [
{
"id": "2021-01-19T17:36:59.627",
"count": "<IP_ADDRESS>.01",
"some_boolean": "<IP_ADDRESS>.011-01-01",
"module": "Batch",
"state": "ACTIVE"
},
{
"id": "2021-01-19T17:36:59.628",
"count": "<IP_ADDRESS>.02",
"some_boolean": "<IP_ADDRESS>.011-01-02",
"module": "Batch1",
"state": "INACTIVE"
},
{
"id": "2021-01-19T17:36:59.629",
"count": "<IP_ADDRESS>.03",
"some_boolean": "<IP_ADDRESS>.011-01-03",
"module": "Batch2",
"state": "ACTIVE"
}
]
}
I tried to modify using given json but  could get only "id" data into prom 2021-01-19T17:36:59.629, rest all giving error
waiting for your reply

can we get all other data read as "id" only,
bcos non other data are like "count" or "boolean"

Please verify if the data you want to collect can be exported as time series or not. You can read more about Prometheus data model and metric types.
You can also try to use metric labels for enumeration in some cases.


Cannot call a function inside the LitElement class from a

<vaadin-grid-column>
          <template is="card-tray">
            <campaign-card
              campaignId$="{{item.id}}"
              name$="{{item.name}}"
              scientist$="{{item.scientist.name}}"
              createdDate$="{{item.created_date}}"
              campaignStatus$="{{item.status}}"
              synthesisType$="{{item.synthesis_type}}"
              url="[[getUrl(item.id)]]"
            >
            </campaign-card>
          </template>
        </vaadin-grid-column>

This is the content inside the vaadin grid within the render function. Inside the template there is a function named getUrl(item.id). The function definition is made inside the LitElement class. Through this function call, I want to compute the URL to be sent as a prop to the  component. But, the function isn't called and gives warning as:
method 'getUrl' is not defined
How can we solve this?

Hello, please don't use Polymer templates inside lit-html templates. They won't work.
You should use renderer property instead, and pass it to vaadin-grid-column.
Check out this example: https://glitch.com/edit/#!/vaadin-grid-renderer?path=app.js

@web-padawan  can we also use renderer property inside  in  lit-html? Seems like vaadin-grid is not correct element for my requirement.

Can we also use renderer property inside <iron-list> in lit-html?

No, consider using lit-virtualizer instead.

@web-padawan , thanks it worked for virtualized list. But, how can we implement infinite scrolling in it?

url="[[getUrl(item.id)]]" is a Polymer binding, and Polymer's template system has no reference to the containing LitElement. There's really not a way to make this work on our end. Thanks @web-padawan for the pointers.


Better handling of lazy loading in webkit-based browsers

Fixes #1032 & #1136

Thanks @thejameskyle , I thought I had merged this earlier, just saw it open

Would you mind making a quick bug fix release of slick for me? I would like it up on cdnjs

1.5.0 is now released. It should hit cdnjs and jsdeliver soon

Thanks!


Bump Dependencies #2809324065

Bumps dependencies for product-is. Link : https://github.com/wso2/product-is/actions/runs/2809324065

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.jenkins-is-staging seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


[camera]revert the weakSelf in FLTThreadSafeEventChannel

Why this bug?
introduced in https://github.com/flutter/flutter/issues/109910
This is the same reason why we can't use weakSelf in FLTThreadSafeFlutterResult - it's only retained within a call stack, not in the heap. So when dispatched back to main, the wrapper has been gone.
Workaround
As a temp workaround, I will simply revert the change in FLTThreadSafeEventChannel to fix the bug. An alternative workaround is to make FLTThreadSafeEventChannel an ivar and keep it around during streaming. I have verified that both works.
In this particular example, we don't have to worry about strongSelf making engine API being called after engine is torn down. This is because engine would have to be dispatched to the main thread to be torn down, which must happen after the current block that we just enqueued.
Long term solution
However, I dislike this approach, because all our thread safe wrappers cannot be re-used as general utilitys - they can only be used in this particular context of camera plugin.
In the long term, I think a more general solution is to always use strong reference to the wrapper itself (where the retain cycle will be broken after the work is done dispatching), but pass in weak reference of the plugin, and use the plugin reference to tell if the engine is torn down or not (instead of using wrapper reference). This approach will make the wrapper working for both ivar and local variable/argument scenarios, while still avoiding calling engine API after engine is torn down.
List which issues are fixed by this PR. You must list at least one issue.
Fixes https://github.com/flutter/flutter/issues/109910
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flxtter/plugins repo does use dart format.)
[x] I signed the CLA.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
[x] I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

It looks like this pull request may not have tests.

Hmm...
https://github.com/flutter/cocoon/blob/153bd47bff0d222c6c80f7da3b764cd96161d473/app_dart/lib/src/request_handlers/github_webhook.dart#L473-L476

@jmagman oh I initially pushed without tests. test was added later. so we should be good

@jmagman oh I initially pushed without tests. test was added later. so we should be good

Oh okay good, thanks!


updated some stuff

Thanks for your contribution!
I've update some test method, could you please check out test coverage?

I changed little bit, and i add .env file.


how to use this gem with conjuction with ransack

hello there ,
how is possible use  1.6 version of gem with  ransack ?
i am tryed to use  PublicActivity::Activity.ransack(params[q])
but it fails on  unknow path

Sorry, I never used ransack so cannot help, will close this as outdated. If it's still an issue to anyone, please open a new ticket


Update tf.nn.in_top_k to use v2 kernel.

This fix is a follow up to PR #11197 so that tf.nn.in_top_k uses V2 kernel now.
This fix follows the API compatibility workflow (3 weeks).
This fix also updates related tests so that gen_nn_ops could be removed.
This fix fixes #9717.
NOTE: In the original PR #11197, the _in_top_kv2 was incorrectly called even the comments specified to wait for 3 weeks. That was fixed by commit https://github.com/tensorflow/tensorflow/commit/3e3eebd6adb3512b69e28b6e7acce9a59527f699
(Thanks @vrv for the fix).
Signed-off-by: Yong Tang<EMAIL_ADDRESS>

@vrv what do you think?

Jenkins, test this please.

/CC: @gunan the windows jenkins appears to be broken.
I haven't seen the coordinator error before, assuming it's some rare flakiness.
Jenkins, test this please.

@gunan, scratch that, windows build appears to be back online. thanks!