Fix FindBugs problems

@seut Please review

Current coverage is 81.11% (diff: 0.00%)

Merging #4504 into master will decrease coverage by 0.12%

@@             master      #4504   diff @@
==========================================
  Files          1293       1293
  Lines         44111      44111
  Methods           0          0
  Messages          0          0
  Branches       7009       7009
==========================================
- Hits          35833      35780    -53
- Misses         5591       5638    +47
- Partials       2687       2693     +6

Powered by Codecov. Last update 3236aa2...4c65c20


Line break in post's title

Hi there,
I'd like the title of my post to split into three lines.
---
title: "into three lines"
categories:
...
---

I've been trying to do this for quite a few hours now, but didn't succeed.
Is this disabled by any chance?
Thanks a lot!

Not possible unless you want to hack the theme. Page h1 doesn’t accept HTML, which you’d need to do line breaks.

Oh, I get it, the strip_html in
{{ page.alt_title | default: page.title | default: site.title | markdownify | strip_html }}
. I'll rather leave it as is... Thanks!


Date picker un-consistent format

https://flatpickr.js.org/examples/#basic
Your Environment

flatpickr version used: Current
Browser name and version: Chrome Mobile / PC
OS and version: Windows / Android

Date picker un-consistent format when refresh / load page. To demonstrate bug, go to in CHROME:
https://flatpickr.js.org/examples/
in chrome press F12 (developer tools) and select some phone display (screen width less than 576 px)
Refresh Page: and you will see all date pickers in wrong format of mm/dd/yyyy
This is causing a lot of function behaviour in projects.

You are right, now I have set the disableMobile to true and the format is consistent, although their is a short flickering of the default format of mobile devices. But Thanks a lot!


actor: add timer tests

Signed-off-by: Long Dai<EMAIL_ADDRESS>Description
Add unit tests for actor.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've  completed the relevant tasks for this PR, out of the following list:

[ ] Code compiles correctly
[ ] Created/updated tests
[ ] Unit tests passing
[ ] End-to-end tests passing
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Specification has been updated / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Provided sample for the feature / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

please help review @artursouza

please help review @artursouza

The E2E tests and build are not passing. The change does a refactoring too, not only adding tests. Please, make sure the E2E tests are passing before we can review.


How To add the corret configuration to build the program?

For me, only appears ChinaServer and RiotGamesServer to use in configurations manager
Visual studio 2022, Brasil

Select RiotGamesServer if you are not Chinese. That's it.


[MB-16972] Update loadtest certs

Jira ticket
Summary
Renew Loadtest Cert and p7b file.

Messages

:book:
:link: MB-16972

  Generated by :no_entry_sign: dangerJS against 6828d53e43c35f4b5aeb7d56a19fa7617e91e8d0

lgtm


$transaction performance issue within Docker

Bug description
When running a service inside docker, the API call using $transaction kills the docker image by ramping up the CPU usage to 100%.
How to reproduce

create a node server with an API using prisma.$transaction
run the server locally, and run the server within docker
test concurrent requests using script

curl -X GET "http://localhost:{port}/api/v1/endpoint"
ab -k -c 20 -n 250 "http://localhost:{port}/api/v1/endpoint"

Expected behavior
Server without docker runs fine where docker one crashes.
Prisma information

Environment & setup

OS: Mac OS
Database: Postgres
Node.js version: v14.17
Docker version: v20.10
Docker base image: node:14-alpine

Prisma Version
3.2.1

It's maybe linked to https://github.com/prisma/prisma/issues/9584

It's maybe linked to #9584

Maybe - but the issue described here doesn't happen on Prisma 2.29 for us, it only started coming up after we upgraded to Prisma 3.x. Basically if we're using $transaction, it'll work a few times but after a few requests, CPU usage will shoot up to 100% and never goes back down. This doesn't happen when running on Mac, only when running it in a Docker / Linux environment. I'd expect it to be related to the Linux or Alpine drivers.

Can you create a small reproduction project and put it on GH so we can reproduce this? Thanks.

Hi @janpio ,
I've created a small reproduction project: https://github.com/sjaakiejj/prisma-transaction-bug
Whilst creating this project, I discovered the issue only appears when interactiveTransactions are included as a preview feature. Let me know if you have any issues setting this up or reproducing it yourself.

Hi @janpio ,
I've created a small reproduction project: https://github.com/sjaakiejj/prisma-transaction-bug Whilst creating this project, I discovered the issue only appears when interactiveTransactions are included as a preview feature. Let me know if you have any issues setting this up or reproducing it yourself.

Just ran into this in prod: I can second that this does seem to be due to interactive transactions (switching to non-interactive transactions does not spike CPU usage to 100% after stress testing it).

Hey, this issue has been fixed via https://github.com/prisma/prisma-engines/pull/2619. We've added a stress test (which reproduces the deadlock issue) to make sure we don't run into this again. Feel free to re-open or ping me if needed.


only laravel

I'd rather use a powerful old man (CodeIgniter4) than a newly matured young man (Laravel).

Lightweight and simplicity: CodeIgniter4 is known for its lightweight and simplicity. It has comprehensive and easy-to-understand documentation, which helps developers to easily familiarize themselves with it and start using it.

Fast performance: CodeIgniter4 provides fast performance due to its lightweight and optimized code structure. This is especially important for projects that require quick data processing.

Flexibility: CodeIgniter4 provides developers with the flexibility to easily adapt to the needs of their projects. This flexibility allows developers to easily apply their required configurations and changes.

Easy installation and setup: CodeIgniter4 has a simple installation and setup process, which helps developers to quickly start their projects and require less time for initial configurations and settings.

User community: CodeIgniter4 also has an active and vibrant user community that can assist developers throughout the development process and support their projects.

CodeIgniter4 has made significant advancements in development, with responsive and friendly developers. Additionally, CodeIgniter offers official packages such as Shield, Settings, Tasks, Queue and more. These packages provide additional functionality and tools to developers, enhancing the overall development experience and productivity. The community around CodeIgniter is active and supportive, contributing to its growth and evolution over time.
Perhaps if CodeIgniter4 focused more on advertising and marketing, CodeIgniter4 wouldn't be as underrated. Additionally, many websites currently use CodeIgniter4 for development but may not express it openly.
CodeIgniter4 is currently being developed on a daily basis by contributors. Its documentation is becoming clearer, and new features are being added regularly. Moreover, it is compatible with various PHP versions ranging from 7.4 to 8.3, ensuring that developers are not limited by their PHP version choices. This active development cycle, along with its compatibility across PHP versions, makes CodeIgniter4 a versatile and evolving framework for web development.
However, it should be noted that the choice between CodeIgniter4 and Laravel depends on the specific requirements and constraints of each project, and each has its own advantages and disadvantages.


Avoid logger.fatal on agent forwarding errors

In attempt to keep the agent running and avoid hard crashes, we return
client errors from forwarding when encountered. This wil cause the
goroutine for that file to exit, but keep the agent running serving
other behaving files where client config is correct.
On server errors, unless we drop the logs, we exit and assume the
process will restart and retry the failures. A more robust solution
should be introduced be will not be at this time.

Great, thanks! Any ETA on this being released and the agent/docker image being updated?
Perhaps a solution that monitors the endpoint and pauses all collection of logs on any downtime and waits until healthy to continue?

Any news on this being released at all? We'd like to get our timber agent running again but can't until this is live!

@jralph Sorry for the delay on this. v0.9.0 just went out and includes a fix for this issue. That release includes our binaries as well as a docker container. Enjoy!

@carkmorwin Thanks for the release! We've got it running now but we're experiencing really really high cpu usage in 0.9.0 compared to 0.8.*. 0.9.0 seems to be using considerably more cpu (over 100x more).

@jralph I'll take a look. There is a place where a syscall was introduced that I'm assuming is the culprit but will confirm.

@jralph Filed an issue that you can track. #161


1.6.0 on pypi

Do you intend to release 1.6.0 to pypi?

Latest version now available at https://pypi.python.org/pypi/pghoard/1.7.0


Fix compilation with clang 7.0.1

clang 7.0.1 is noting that there's an issue with compiling the tests
because they're overloading another method in the same scope with a
different, incompatible signature
Signed-off-by: Enji Cooper<EMAIL_ADDRESS>

Could you paste the logs for the failure and describe in more detail in the commit message what "an issue" is? I don't understand where the name conflict is coming from.

@jmmv: sure! Will do when I get home

Oh, wait. I realized how this is happening.
I have some local changes for adding setup fixtures on my branch which haven't been committed yet, so this issue is local to my branch.


Unauthorized error while upgrading kamal-proxy

Upgrading kamal-proxy won't work when using ghcr.io registry:
Error response from daemon: Head "https://registry-1.docker.io/v2/basecamp/kamal-proxy/manifests/v0.8.1": unauthorized: incorrect username or password

My config:
registry:
  server: ghcr.io
  username:
    - KAMAL_REGISTRY_USERNAME
  password:
    - KAMAL_REGISTRY_PASSWORD

When using the default registry (Docker Hub), it works as expected.

Do you provide your github password or a token?

Do you provide your github password or a token?

GitHub authentication works flawlessly. The issue arises only when upgrading the Kamal proxy, as it requires authentication with Docker Hub.

Not sure I understand. Your config uses ghcr.io and for that you should use a token from github, like a personal access token (classic).

Not sure I understand. Your config uses ghcr.io and for that you should use a token from github, like a personal access token (classic).

The issue isn't related to GitHub authentication. Let me clarify:
After upgrading Kamal from 2.0.0.rc2 to 2.2.1, I ran kamal proxy reboot, as recommended in the release notes. However, this command failed with an "unauthorized" error. I suspect the issue arises because the kamal-proxy image is being pulled from Docker Hub, but I'm using the GitHub registry and am not authenticated with Docker Hub. When I switched the registry to Docker Hub, the command worked successfully.

@tobiasalmstrand is it possible you had old/invalid Docker Hub credentials on the machine(s) you're deploying to?
Kamal can pull the proxy image without being logged in to Docker Hub (the image is public). However if you had previously logged in to Docker Hub, but the stored credentials are no longer valid, then you would run into that error. Docker will attempt to use saved credentials when pulling the image.
If you want to switch back to ghcr.io, you can docker logout to remove the saved credentials. (Although, switching to use Docker Hub as your registry for deployments would have already updated them, too.)

@kevinmcconnell Yes, that’s definitely possible. Thank you for the clarification!


Adding a UIView to the button

Hi folks,
I'm trying to add a uiview (kinda like a counter) to the floating button, like this:

But, instead I'm getting this:

Even though, the Debug view hierarchy in xCode is showing me this:

I'm using the following to add the UIView:
Floaty.global.button.addSubview(floatingCounter!)
Anyone has any tips please?

@choujar
floatingCounter.layer.zPosition = CGFloat.greatestFiniteMagnitude
Should fix that problem

Hi @Badi3 - I actually fixed it by adding a separate UIView (with a UILabel inside) and dynamically placing it based on the position of the floating button. But I'll try your solution and get back to you!
Thanks!


x/sys/windows: EnumProcesses cuts the PIDs buffer size

Sorry if it's the wrong place to report, but I don't see another place to discuss an issue with golang.org/x/sys.
What version of Go are you using (go version)?

$ go version
go version go1.20.1 windows/amd64

Does this issue reproduce with the latest release?
Yes, it's a problem with a separate module.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
set GO111MODULE=
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\rmazur\AppData\Local\go-build
set GOENV=C:\Users\rmazur\AppData\Roaming\go\env
set GOEXE=.exe
set GOEXPERIMENT=
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOINSECURE=
set GOMODCACHE=C:\Users\rmazur\go\pkg\mod
set GOOS=windows
set GOPATH=C:\Users\rmazur\go
set GOPROXY=https://proxy.golang.org,direct
set GOROOT=C:\Program Files\Go
set GOSUMDB=sum.golang.org
set GOTMPDIR=
set GOTOOLDIR=C:\Program Files\Go\pkg\tool\windows_amd64
set GOVCS=
set GOVERSION=go1.20.1
set GCCGO=gccgo
set GOAMD64=v1
set AR=ar
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set GOWORK=
set CGO_CFLAGS=-O2 -g
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-O2 -g
set CGO_FFLAGS=-O2 -g
set CGO_LDFLAGS=-O2 -g
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -Wl,--no-gc-sections -fmessage-length=0 -fdebug-prefix-map=C:\Users\rmazur\AppData\Local\Temp\go-build4014544235=/tmp/go-build -gno-record-gcc-switches
gdb --version: GNU gdb (GDB) 10.2

What did you do?
Calling windows.EnumProcesses with a slice [1024]uint32 as the first argument does not result in passing 4096 as the size of the input array. Instead, the len() of the slice is used, cutting the size to 1024 bytes.
The code that generates the windows.EnumProcesses function does not take into account the discrepancy between the input slice type and what the system call expects ([]uint32 vs a byte array).
What did you expect to see?
windows.EnumProcesses should pass len(processIds)*4 as the input array size to the Windows system call.
What did you see instead?
len(processIds) is used instead:
https://github.com/golang/sys/blob/1911637744c199cdad74ee1ee74d19ce61e3d9fa/windows/zsyscall_windows.go#L3524

Thanks for reporting this issue @roman-mazur.
mkwinsyscall does a best effort to generate correct wrappers, always expanding a Go slice to two arguments: a pointer to the slice followed by it's length. IMO this is mostly a sane assumption, e.g. it works for []byte and in more complex cases (see FormatMessage). Unfortunately, EnumProcesses expects the length in bytes, even though it fills a DWORD array. We should fix that.
Do you want to give it a try (see the Contribution Guide)? Else I'll pick it.
A good solution would be to redefine //sys EnumProcesses to generate an unexported function that accepts an explicit length, like this:
//sys	enumProcesses(processIds *uint32, nSize uint32, bytesReturned *uint32) (err error) = psapi.EnumProcesses

Then implement the EnumProcesses exported function in syscall_windows.go with the old parameters (processIds []uint32, bytesReturned *uint32), but calling enumProcesses instead with the appropriate length.

I was thinking at first about adjusting the generated code to be len()*4 if it's a []uint32 slice, but the logic would not be simple.
I like your idea of treating EnumProcesses as an exception. Will try to do it a bit later this week.


Fix/dtfs2 4548 gef webpack

Updates GEF-UI to same build process as portal
Removes E2E tests from UI's
Minor changes to Portal build file and config
Move GEF-UI to core-js syntax instead of modules

"Removes E2E tests from UI's" What do you mean by this please? I think if a UI is changed the e2e tests for that UI should run?


sm_compile_to_remote.sh missing?

The shell script named above is generated during CodeGen. However it does not exist in the repository.

The shell script named above is generated during CodeGen. However it does not exist in the repository.

@haochenuw I have met same problem with you,  is your problem solved?

@tyrone-yu  +1, is your problem solved?


Should the server create the kinesis channel if it doesn't exist?

Or should we create the channel ahead of time?

Is this done?

(I think we discussed it possibly earlier this week)

I think we said, no, the server should not create it.  It will just be part of the setup tasks.


Cleanup of demos

Two minimal changes to the demos:

no need for interface_name: position
no dependency on ros2_controllers (all controllers are listed explicitly)

@mergifyio backport humble iron


Enable filtering by multiple partnership levels on organizations.

We should be able to filter organizations according to their partnership level.  User should be able to select multiple partnership levels, which should be combined with 'or' (i.e., show me silver or bronze).  For now, don't worry about temporal nature of partnerships: show all organizations that have, or have ever had, a particular partnership level.

@gvwilson, when you say partnership, do you mean Membership?
Also, I don't think we track partnership levels (silver, bronze etc.) -- we only track variant (partner/affiliate/sponsor) and contribution type (financial/person-days/other).

Ahh, ok, I've just had a look at #1034 and I see there are new variants (bronze, silver etc.).

Yes, sorry, Membership, and I've added the new levels.


TensorFlow dependency has a version incompatibility on macOS

Thanks for putting this library together, we're looking at using it in the near term to perform image loading and saving within Swift for TensorFlow's models (pending PR for this ).
One issue we encountered is that if you attempt to build the current version of the library on macOS via SwiftPM, you will hit a version mismatch. By default, SwiftPM targets macOS 10.10, but we needed to set a minimum macOS version of 10.13 for Swift for TensorFlow. This causes a problem when building with one of our toolchains on macOS, triggering an error here.
To enable the import of TensorFlow in this project on macOS, I believe you'll need to add
    platforms: [
        .macOS(.v10_13),
    ],

just after the package name in Package.swift. One downside of this is that it will limit your backwards compatibility on macOS to 10.13.
In the meantime, I've pegged our import of Swim to 3.6.1, the release before the TensorFlow extensions were added. With that, we can use this framework, but I wanted to point this out for future commits.

I encountered the same issue and the fix suggested by @BradLarson works well. I'd suggest to wrap the it in a #if canImport(...) so it doesn't affect backward compatibility for "regular" (i.e. non S4TF) toolchains or Linux.
#if canImport(TensorFlow)
    platforms: [.macOS(.v10_13)],
#endif

@t-ae , please, let me know if you'd like a PR.

@BradLarson
Sorry for late reply. Somehow I completely missed this issue.
Now there's new version 3.6.2 which restricts macOS versions.
@vojtamolda
Thank you for the suggestion. But it seems #if canImport doesn't work well in Package.swift.
So I just add platforms without it.

Thanks for the quick response! I just tested 3.8.1 and everything works like a charm. Sorry about the confusion with #if canImport.

We also might be fixing this in the near term (or it may already be fixed) by lifting the platform requirements on our end. I know that was being worked on, but I haven't checked what the latest status was.


Bridge 0.17.0: Incorrect detection of pending changes when accessing project details of a project with auto-provisioned project

Using Keptn 0.17.0 and the keptn-gitea-provisioner-service, I created a new project, e.g.:
keptn create project jes4 --shipyard=shipyard.yaml

This will auto create a repo and asign it to the project, e.g.:
Current Behaviour
When editing the project in Bridge, something weird is happening and this seems to cause Bridge to think that I have changed some values:

Expected Behaviour
As I did not change any values, I am not expecting the popup regarding unsaved changes

This behavior might change with #8510

Found the problem:
this.dataChanged is called when this.selectedForm is GitFormType.NO_UPSTREAM, which is only possible with automaticProvisioning.
https://github.com/keptn/keptn/blob/c4845c9b568351ab2c93320095d4f061584b7463/bridge/client/app/_views/ktb-settings-view/ktb-project-settings/ktb-project-settings-git-extended/ktb-project-settings-git-extended.component.ts#L60-L62
@Kirdock do you remember why this was added by @laneli initially?

Found the problem:
this.dataChanged is called when this.selectedForm is GitFormType.NO_UPSTREAM, which is only possible with automaticProvisioning.
https://github.com/keptn/keptn/blob/c4845c9b568351ab2c93320095d4f061584b7463/bridge/client/app/_views/ktb-settings-view/ktb-project-settings/ktb-project-settings-git-extended/ktb-project-settings-git-extended.component.ts#L60-L62
@Kirdock do you remember why this was added by @laneli initially? Otherwise we could get rid of this easily and in my opinion without any issues.

Yes. Else the selection and the required data is not emitted. Therefore if you select NO_UPSTREAM the create button would not be enabled without it

Found the problem:
this.dataChanged is called when this.selectedForm is GitFormType.NO_UPSTREAM, which is only possible with automaticProvisioning.
https://github.com/keptn/keptn/blob/c4845c9b568351ab2c93320095d4f061584b7463/bridge/client/app/_views/ktb-settings-view/ktb-project-settings/ktb-project-settings-git-extended/ktb-project-settings-git-extended.component.ts#L60-L62
@Kirdock do you remember why this was added by @laneli initially? Otherwise we could get rid of this easily and in my opinion without any issues.

Yes. Else the selection and the required data is not emitted. Therefore if you select NO_UPSTREAM the create button would not be enabled without it

Ok, but then we need this just in createMode? Means if (this.selectedForm === GitFormType.NO_UPSTREAM && this.isCreateMode) {

No, the root cause is probably here:
https://github.com/keptn/keptn/blob/dd276ff4005d50a2b97bcbdd914b9b8580209b6b/bridge/client/app/_views/ktb-settings-view/ktb-project-settings/ktb-project-settings-git-extended/ktb-project-settings-git-extended.component.ts#L58
This should be changed to
this.selectedForm = !this.gitUpstreamRequired && this.isCreateMode ? GitFormType.NO_UPSTREAM : GitFormType.HTTPS


there is some misunderstood parts

In https://github.com/rust-lang-nursery/rustc-guide/blob/master/src/hir.md there is a sentence about "It is a desugared version of the abstract syntax tree"
I am not a native English speaker. So I just understand it in my mother language. When I tried to translate this sentence into Chinese which is my mother language. This looks like saying that HIR is a kind of abstract syntax tree.
If this sentence does not cause ambiguity in English, please close and ignore this issue.

My understanding matches yours. The HIR is like an AST but with all the syntactic sugar removed.

Definitely not all sugar is removed when lowering to HIR. What differs
between the two is the purpose - AST must faithfully represent code,
whereas HIR does not.
On Fri, Apr 20, 2018, 08:17 Who? Me<EMAIL_ADDRESS>wrote:

Is there a different way of phasing the sentence that would be easier to
translate?
Also, thanks for opening this issue :) I think it is important for the
guide to be accessible to non-native-English speakers.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/rust-lang-nursery/rustc-guide/issues/116#issuecomment-382979600,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AApc0lMDmvV42x1wRRUKZjTr5WnZk5Moks5tqW9WgaJpZM4TcFAp
.

@nagisa Thanks for the clarification :)

This looks like saying that HIR is a kind of abstract syntax tree.

From what I've gathered when trying to use the compiler internals, you could say a hir::Crate is a more compiler-friendly representation of the AST where we've changed the precise way things are stored and desugared some bits to make analysis easier.


switch to ghostrace for syscall decoding

partially done in 426f27179efaada50cb38c9ddb75ee3de3976858

This is obsoleted by the new syscall infrastructure. If anything, ghostrace should be using usercorn to decode syscall parameters now :)


Add Clementine.app v1.3rc1

done
pull request to main cask

Thank you for the contribution. It needed some fixes, so they were made in 0df50018f046637b2d8d39051dc6ee347a85cb93. Your contribution is still included (and still credited to you), with the appropriate modifications. Please feel free to ask about any of the changes.

So, were there any other fixes except getting rid of regex?

Nope.

ok, cool :smile:


Tolerate uninitialized node

This ensure master components gets scheduled, even if CCM[1] hasn't
initiazlied the node yet.
[1] https://kubernetes.io/docs/tasks/administer-cluster/running-cloud-controller/
Fix: #800

Not tested yet...

coreosbot test this please

/assign @colemickens

@klausenbusk Is that taint only set when the CCM is activated? Is there any downsides to tolerating this taint when CCM is not activated on KCM, or running in the cluster? (I can't think, but wanted to explicitly make sure you'd thought about it).

@klausenbusk Is that taint only set when the CCM is activated?

Per the doc:

kubelets specifying --cloud-provider=external will add a taint node.cloudprovider.kubernetes.io/uninitialized with an effect NoSchedule during initialization. This marks the node as needing a second initialization from an external controller before it can be scheduled work. Note that in the event that cloud controller manager is not available, new nodes in the cluster will be left unschedulable. The taint is important since the scheduler may require cloud specific information about nodes such as their region or type (high cpu, gpu, high memory, spot instance, etc).

Is there any downsides to tolerating this taint when CCM is not activated on KCM, or running in the cluster? (I can't think, but wanted to explicitly make sure you'd thought about it).

The taint is only set by kubelet when started with --cloud-provider=external, so I can't think of any downsides when not-in-use.

Please also see: https://github.com/kubernetes-incubator/bootkube/pull/804, which add the require logic to the hack/quickstart script to support CCM.

coreosbot run e2e

Very delayed response - but I'm wondering if we should just have critical control-plane components tolerate all taints?


some small spelling fixes.

@ramtinmovahed
Thank you for your contribution. We'll merge the changes.
#sign-off


CLI does not generate a reliable config.json if Transform blocks that require merges are in the manifest

If in a Presentation cmfpackage.json we have a transform block that performs an array merge or remove, this block will override the default merge/remove blocks at https://github.com/criticalmanufacturing/cli/blob/45b007a74b58b03b9bcec45bc1c76a8e8e257fb6/cmf-cli/resources/templateFiles/HTML/config.json#L2 as JDT will only apply the last matching merge/remove block in the file.
A workaround is to specify all merges/removes in the last transform block, but this can be difficult to orchestrate if we are using multiple presentation packages. Also, because the package token replacement happens at https://github.com/criticalmanufacturing/cli/blob/45b007a74b58b03b9bcec45bc1c76a8e8e257fb6/cmf-cli/Handlers/PackageType/PresentationPackageTypeHandler.cs#L103 and JDT injection only happens at https://github.com/criticalmanufacturing/cli/blob/45b007a74b58b03b9bcec45bc1c76a8e8e257fb6/cmf-cli/Handlers/PackageType/PresentationPackageTypeHandler.cs#L111 we cannot use the CLI tokens in the transform blocks, which means the package list must be hardcoded in the cmfpackage.json file, which is a maintenance burden.
Instead of just injecting, CLI should analyze the JDT transform paths and merge them in the correct keys. This will likely require that more tokens are available or that the file is built via a JSON Object, which is less flexible for templating.

We're not implementing this in the foreseeable future as this transform approach is deprecated in favor of templating the config.json file for v10 forward.
I'm closing this issue as this is a known quantity and use will be residual.


Redirect to the custom page after saving a new record is not working

I have specified redirect url like redirectUrl: "/admin/customPage" in the new action handler response. However It's not redirecting to given path. Just replaces url in the browser.

probably becasue there is no route /admin/customPage - you probably ment /admin/pages/customPage. You can use ViewHelper#pageUrl to generate urls automaticaly.


Upgrade cdb extension to 0.9.3 #4962

@Kartones please review

+:100:

Fixing the test failure in https://github.com/CartoDB/cartodb-postgresql/pull/127


Custom Element type based defineProps does not convert attribute to number in production build

Vue version
3.3.0-alpha.9
Link to minimal reproduction
https://github.com/jlangstrom/ts-vue-ce-props
Steps to reproduce
Hi friends,

Clone repo
npm install
npm run issue:test:e2e:dev
npm run issue:test:e2e:prod

The README in the repo describes the tests.
What is expected?
Both tests to pass regardless if using dev build or production build.
What is actually happening?
The e2e test with production build fails.
When using Typescript and type based compile time prop definitions. The props are not converted into runtime props in the production build. This seems to have an impact on the Vue3 custom element casting its props defined as numbers into numbers from string.
When sending a prop through an attribute on the custom element that is defined as being a number it will still be a string in the web component in a production build.
System Info
No response
Any additional comments?
Here I've done a fork that attempts to fix the issue in the compiler-sfc. You can probably comment on how to do it better.
Have a nice day. Thank you for reading.

The issue can no longer be reproduced using the latest version of Vue.


[src] Created testing framework to test Bazel repository rules outside of Bazel invocation using pure shell scripting

[src] Added an example git repository named small-repo to be used by git repository rules test-kit
[src] Created x4 basic use cases for testing the git_cached_repository rule

Loved the Wizard of Oz reference. Very cute 😄

Thanks :blush:

Critical thing is that I think the tests shouldn't touch HOME directory of the developers (unless it's a dedicated HOME folder per test).

Tests are running in a containerized environment when running locally. On CI they are running "locally" since they are wrapped by GitHub actions containerized environment.

Important thing is that you use functions from files without calling source on them... you rely on the main test file to source all the files, but it makes it less readable.

Sourced sh files from every other file they are being used

I made a suggestion on how functions can be named so we can know that they come from your testing framework and from which file exactly.

Couldn't find your suggestion, used the GitHub suggestion feature?

I'm against checking in a full git repo. If you already made a mechanism for committing changes, it's only few more steps to generate a git repository without pushing binaries here.

This is exactly the way Bazel is testing the git repo rules, this testing framework is inspired by theirs and I think that it is better to use an immutable repo as I've replied to this comment.

Confession

It depends on the use case, for this one I think it will be easier to use straight forward bash commands rather than using a python subprocess for different shell script/command that you require to execute or creating wrappers for python libs so short it won't be necessarily
In addition as we've discussed previously, python has its environmental issues that we have and still witnessing on a daily basis that shouldn't be a problem with straight forward bash scripting.
And by looking at the Bazel shell testing framework, seems like it is good to be close to how to source operates :smile:
Let's give it a run since this was our initial choice which is already implemented and see how it goes, specially when we could use it to check other Bazel rules that we have internally.

Couldn't find your suggestion, used the GitHub suggestion feature?

I don't know why it disappeared... :-(
I suggested a new way for naming bash functions you declare on.
If the function comes from assert.sh then all public functions needs to be called "assert_<name>"

Reply to https://github.com/wix-playground/wix_build_tools/pull/4#discussion_r622838256

Didn't notice anything... didn't read through the file... but words like write or read or log might be taken in bash.

I've renamed the function names that could potentially be taken already and used your <filename>_<function-name> suggestion.

Only on tests that used $HOME/.git-cache

Running tests in a containerized environment shouldn't be an issue, this is a git_cached rule behavior that must be tested imo.

Couldn't find your suggestion, used the GitHub suggestion feature?

I don't know why it disappeared... :-(
I suggested a new way for naming bash functions you declare on.
If the function comes from assert.sh then all public functions needs to be called "assert_<name>"

I've took your suggestion and used it on files such as utils and assert containing function names that might collide with others.

What promises that when running locally they will run in "containerized env"? The makefile?

I want to believe that people don't tent to execute scripts from all over the place on repositories they aren't familiar with 😄
makefile is self explanatory about the action it run with help description on each and the execution confined to the makefile relative location.

I wonder if we can at least download this tar.gz from some other place and not push it to the repository. Google repositories usually have binaries (see all the jars in bazel and in the intellij plugins but in a git eco-system - this becomes problematic.

Please see premature optimization comment in here, we'll surely get to it on the next stages of this framework. We'll probably find additional gaps to solve after test running it.

Very well then 😀

🚀


Animation is slow in mobile devices (Specially in Android devices), any suggestion or fix?

Code Eg:
sprite.animations.add('congrats', Phaser.Animation.generateFrameNames('Congratulations', 1, 140, "", 4), 20, true);  sprite.animations.play('congrats', 20, false,true);

Thank you for taking the time to open your issue. However, Phaser 2 is now maintained in the Phaser CE GitHub repo. If the issue still exists in Phaser CE then please submit your PR there and I'm sure the community will be only too happy to merge it.


Toggle FPS camera mode in components

Hi @harrycollin @agviegas @MadsHolten @HoyosJuan,
How do I toggle to first person mode in openbim-components. Is components.camera.navigationmodes.firstPersonMode() correct?
I tried that but it didn't work. Any suggestions?

Here's my code for reference. https://github.com/keshavanarayan/viewer/blob/2b7b5977b9df3009c54eafe0206ffe9d4a07a8e8/src/main.js#L29

Hey @keshavanarayan you can use camera.controls to access the camera controls instance, which will give you all the functions you need to control the camera around. Again, no need to tag folks in the issue 🙂 Let us know how it goes. Cheers!


Add cfg to Peripheral fields

The cfg conditional compilation attribute was only set on impl blocks of peripherals. This commit also sets it on the fields themselves to be more consistent.
Also adds Armv8-M Baseline to the blacklist of the ITM peripheral (cf rule FMQF of the Armv8-M ARM).

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @korken89 (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

I tested by compiling the crate for all thumb* targets (except the neon ones) successfully.

The commented line (28) in build.rs creates the clippy error:
//println!("cargo:rustc-cfg=armv7em");

It was added by @adamgreig here.
Should we remove the comment, merge the two blocks, ignore the clippy lint?

The commented line (28) in build.rs creates the clippy error:
//println!("cargo:rustc-cfg=armv7em");

It was added by @adamgreig here.
Should we remove the comment, merge the two blocks, ignore the clippy lint?

I'd remove the commented out code, replacing with a note as to why armv7em isn't there (if appropriate).

The commented line (28) in build.rs creates the clippy error:
//println!("cargo:rustc-cfg=armv7em");

It was added by @adamgreig here.
Should we remove the comment, merge the two blocks, ignore the clippy lint?

I'd remove the commented out code, replacing with a note as to why armv7em isn't there (if appropriate).
Edit: We should merge the two identical if statement arms as well.

Done! The "e" in armv7em means that the DSP extension is included, but the cortex-m crate does not seen to use it at the moment.

Looking good. Just a couple of questions about v6m vs v8m.base. I'm sure what you've done is right, but I felt it was worth double checking.

Looking good. Just a couple of questions about v6m vs v8m.base. I'm sure what you've done is right, but I felt it was worth double checking.

Thanks! I can not see the questions that you have 👀

They're inline comments that should appear in the source code diff view.

Hah. And I need to click 'Submit'...

Adding conditional compilation to the fields of this structure is a breaking change. For the same reason as https://github.com/rust-embedded/cortex-m/pull/180/files#r360940824
The reason these fields are not conditionally compiled is because destructuring this structure or referencing its fields would otherwise become inconvenient (e.g. see cortex-m-rtfm where the fields are referenced but never used). As cfg(armv6m) and the others are not built-in conditions every crate that needs to access the fields of this structure needs to pretty much replicate verbatim the build script used in this crate (see the cargo:rustc-cfg= print statements in the build script).

Adding conditional compilation to the fields of this structure is a breaking change. For the same reason as https://github.com/rust-embedded/cortex-m/pull/180/files#r360940824

You are right and I did not think about mentioning the fact that this is indeed a breaking change! Does it have any consequences on the changes themselves? I guess because of that it will have to be tagged as a new major version?

The reason these fields are not conditionally compiled is because destructuring this structure or referencing its fields would otherwise become inconvenient (e.g. see cortex-m-rtfm where the fields are referenced but never used). As cfg(armv6m) and the others are not built-in conditions every crate that needs to access the fields of this structure needs to pretty much replicate verbatim the build script used in this crate (see the cargo:rustc-cfg= print statements in the build script).

Makes sense! Would you say it is better to leave it as it was before then? I think that having cfg on the Peripheral fields could bring some frustration when trying to destructure this struct for all targets (as one would need to copy the build.rs println!s and the same cfg than in the definition of the Peripheral struct). It might be hard to know how to fix the compiler errors when facing that. Having cfg on the impl will only bring errors when actually trying to use the field, which might happen less often.
But as it was said in the other PR, it also makes more sense to have cfg everywhere for completeness.

I'm starting to wonder if inferring the Processor model (e.g. Cortex-M4), and its associated peripherals, from the architecture/instruction-set (e.g. ARMv7E-M), which is given by the target (e g. thumbv7em-none-eabi) is actually a good idea.
As the instruction sets are backwards compatible, what if I wanted to write a portable binary that ran on a Cortex-M3, M4 and M33, and used runtime feature detection to determine what peripherals were available? I would want ARMv7-M instructions, but acess to the M33's peripherals. Or what if some future peripheral is added to some mythical Cortex-M5, but which otherwise implements ARMv7E-M? Or, what if some CPU doesn't have the features outlined in the relevant ARM as Optional?
The LLVM backend generally has a distinction between TARGET and CPU. I wonder if we can make use of that, and if we can, whether we should.

Is the main goal of those cfg is to save memory? I guess you could have runtime feature detection and remove all the cfg at the expense of increasing memory.
It is true that some Arm C compilers (the ones that I know) give you the option of choosing either the architecture or the CPU but in Rust there is only the target switch. Having the possibility to choose a specific CPU could help having more precise cfg but there still would be optional features. For example for the Cortex-M33, the presence of a FPU, DSP, Security Extension and more is optional.
The way I think about those cfg is that they only remove peripherals we are sure they are not implemented but leave the implemented and optional ones, just in case.

I guess I need to rebase because of 6ac19a5ae74432b68a290dd79b18ce4ee09b20d4.
About the changes: should I remove the cfg to the Peripheral structure definition and only keep them on the impl (as it was before, but updated)?

So #193 is in now, so we're fine with #[cfg] on individual fields, right?

So #193 is in now, so we're fine with #[cfg] on individual fields, right?

I would say so! It would also mean that if a consumer of this crate wants to target multiple architectures, he would have to somehow use the same build configs:
    if target.starts_with("thumbv6m-") {
        println!("cargo:rustc-cfg=cortex_m");
        println!("cargo:rustc-cfg=armv6m");
    } else if target.starts_with("thumbv7m-") {
        println!("cargo:rustc-cfg=cortex_m");
        println!("cargo:rustc-cfg=armv7m");
    } else if target.starts_with("thumbv7em-") {
        println!("cargo:rustc-cfg=cortex_m");
        println!("cargo:rustc-cfg=armv7m");
        println!("cargo:rustc-cfg=armv7em");  // (not currently used)
    } else if target.starts_with("thumbv8m.base") {
        println!("cargo:rustc-cfg=cortex_m");
        println!("cargo:rustc-cfg=armv8m");
        println!("cargo:rustc-cfg=armv8m_base");
    } else if target.starts_with("thumbv8m.main") {
        println!("cargo:rustc-cfg=cortex_m");
        println!("cargo:rustc-cfg=armv8m");
        println!("cargo:rustc-cfg=armv8m_main");
    }

Those would become more "standard".

bors r+

I think needs the clippy allow from #189 to land first, then it will build.

bors r+

@jonas-schievink - you added the needs-decision label. Does this still need a decision?

Yeah, https://github.com/rust-embedded/cortex-m/pull/181#issuecomment-568524422 has not been addressed yet.

But didn't https://github.com/rust-embedded/cortex-m/pull/193 fix that?

No, that future-proofed cortex-m for when new fields get added, but libraries can still move all current fields out of Peripherals. If we cfg-gate some of them then these libraries will have to basically copy the entire build.rs from cortex-m, I believe.
That doesn't mean we shouldn't do this, since IMO it does make things more clear, but this is a pretty big drawback. Maybe we can find a better solution that directly addresses what RTFM wants to do (which is use certain core peripherals for itself and only hand the remaining ones to the user), but I don't know how that would look.
Sounds like a good thing to bring up at the next meeting though.

Ok, the outcome of the meeting was:

In the normal case, people shouldn't need to have a build.rs file, and cfg gating structure fields means you do need a build.rs file if you want to destructure the struct (as you need to know when fields are and are not present).
defining CPU features based on LLVM architecture target is not valid - running thumbv6m-none-eabi code on a Cortex-M7 is perfectly valid, especially if you want a portable binary.
If we do want to stop people using features they don't have on the particular Cortex-M they are aiming at / are running on, we need a better system than cfg gates based on LLVM architecture. This includes sorting out eabi and eabifp (which doesn't indicate the presence or not of an FPU, only the passing of float arguments in FPU registers).

So, I think we agreed we'd close this.

On the whole I agree with https://github.com/rust-embedded/cortex-m/pull/181#issuecomment-600263444 but one alternative idea: we could instead add some cortex-m features such as cortex-m3, cortex-m4, cortex-m7 which we use to cfg-gate the relevant entries. They would make sense for the peripheral entries, since they relate to actual CPU rather than target architecture, and they don't need a build file in cortex-m or in other crates. Users building (admittedly very rare) portable binaries can enable multiple features to have access to all peripherals. Crates wanting to destructure Peripherals like cortex-m-rtfm could replicate these features (there's not many and they make sense for a cortex-m-specific crate; they could even be useful to gate other rtfm features?) or could enable all the CPU features (perhaps all are even enabled by default) which would ensure that the Peripherals struct is "full".
That way, most users can have a smaller Peripheral struct that relates to just their CPU without the overhead of loads of unused/inaccessible fields, we can simplify cortex-m's build.rs as well as having it make more sense than the current not-quite-right "thumbv6m == cortex-m0" logic, and crates wanting to destructure Peripherals wouldn't need to add their own build.rs.
I'll open a separate issue on cortex-m-rt about the FPU thing.

Thanks for the update! The main reason for this PR was to address one comment of my other PR adding the SAU peripheral that is still pending.
I idea around adding cortex-m features per CPU should probably be discussed in another issue.
I have updated this one, removing the cfg gate on the peripherals but keeping the updates on the comments and existing cfg. I believe those changes are still valid and correct.

bors r+

@jonas-schievink I modified this PR to only be an update of code documentation and add armv8m_base where it was only before armv6m.
It's still a breaking change but only for Armv8-M Baseline developpers who were trying to use the ITM but maybe that's fine because the ITM is not available on Armv8-M Baseline?

bors r=thejpster


chore: fix incorrect proto path in helloworld tutorial

This change reverts #366. The proto/ directory, as described in the guide, is created under the root of the crate. Not under src/.
I've also included a fix to the grpcurl endpoint.

When will this merge?

sorry for the delay, been on vacation :)


Make Work Items available inline with Requested Repairs

Make New Work Items and Work Items available inline with Requested Repairs. This will make it easier to match the Requested Repairs with the Work Items to be evaluated during the Site Assessment.

This has been done.


Treesitter grammar proto

Description of changes
New package.
https://github.com/mitchellh/tree-sitter-proto/
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 259909 run on x86_64-linux 1

2 packages failed to build:

diffsitter
tree-sitter-grammars.tree-sitter-proto

Result of nixpkgs-review pr 259909 run on x86_64-linux 1

1 package failed to build:

diffsitter

1 package built:

tree-sitter-grammars.tree-sitter-proto

diffsitter can't be built on the master branch either (aka not-my-fault).

Result of nixpkgs-review pr 259909 run on x86_64-linux 1

2 packages built:

diffsitter
tree-sitter-grammars.tree-sitter-proto

diffsitter got fixed in the meantime.


[Question]: Does the Gallery have API for fetching packages by user?

Hello. I'm sorry if it's a wrong place to ask these questions, so feel free to redirect me where needed.
My question is - is it possible to get a list of packages by user via nuget.org's API? In short, I want to make a badge which would show the number of downloads per user/org.
Thanks in advance.

Hello, you should be able to use the search API with nuget.org's search syntax to do this:
ILogger logger = NullLogger.Instance;
CancellationToken cancellationToken = CancellationToken.None;

SourceRepository repository = Repository.Factory.GetCoreV3("https://api.nuget.org/v3/index.json");
PackageSearchResource resource = await repository.GetResourceAsync<PackageSearchResource>();
SearchFilter searchFilter = new SearchFilter(includePrerelease: true);

IEnumerable<IPackageSearchMetadata> results = await resource.SearchAsync(
    "owner:microsoft",
    searchFilter,
    skip: 0,
    take: 20,
    logger,
    cancellationToken);

foreach (IPackageSearchMetadata result in results)
{
    Console.WriteLine($"Found package {result.Identity.Id} {result.Identity.Version}");
}

Some notes:

The search syntax is nuget.org specific. This may not work on other package sources
The nuget.org search API has limits on how many results it will return. You may not be able to fetch all data for accounts with thousands of packages

Oh, awesome, thanks


fix hinton labels

is coherent with the swapped labels

It's a matter of convention. For
$$
\rho=\begin{pmatrix}a & b\\c & d\end{pmatrix}=a\ket0\bra0 + b \ket0\bra1 + c\ket1\bra0 + d\ket1\bra1,
$$
the value of the plot at row $i$ and column $j$ is always $\rho_{ij}$. Now there are two ways to interpret the labels:

With the original labels the element at row $\bra i$ and colum $\ket j$ is $\braket{i|\rho|j}$.
With the new labels the element at row $\ket i$ and column $\bra j$ is the the corresponding element $\ket i\bra j$ of $rho$.

IMO we should keep the original labels, as they align with the standard mathematical notation for matrices (usually when plotting a matrix we plot its action on the column, for example the first column is $\rho\ket0$).

The two ways to interpret the labels are not completely interchangeable, I believe there is a transposition to switch from one to another

Can I close this @abocquet?


Ansible inventory doesn't created during converge

Hi, it has been broken with 1.1.1.
$ molecule --version
1.1.1
$ molecule create
Bringing machine 'ansible-role-php-01' up with 'virtualbox' provider...
==> ansible-role-php-01: Importing base box 'bento/centos-6.7'...
==> ansible-role-php-01: Matching MAC address for NAT networking...
==> ansible-role-php-01: Checking if box 'bento/centos-6.7' is up to date...
==> ansible-role-php-01: Setting the name of the VM: ansible-role-php_ansible-role-php-01_1450454874140_66041
==> ansible-role-php-01: Fixed port collision for 22 => 2222. Now on port 2202.
==> ansible-role-php-01: Clearing any previously set network interfaces...
==> ansible-role-php-01: Preparing network interfaces based on configuration...
    ansible-role-php-01: Adapter 1: nat
    ansible-role-php-01: Adapter 2: hostonly
==> ansible-role-php-01: Forwarding ports...
    ansible-role-php-01: 22 => 2202 (adapter 1)
==> ansible-role-php-01: Running 'pre-boot' VM customizations...
==> ansible-role-php-01: Booting VM...
==> ansible-role-php-01: Waiting for machine to boot. This may take a few minutes...
    ansible-role-php-01: SSH address: <IP_ADDRESS>:2202
    ansible-role-php-01: SSH username: vagrant
    ansible-role-php-01: SSH auth method: private key
    ansible-role-php-01: Warning: Connection timeout. Retrying...
    ansible-role-php-01: Warning: Remote connection disconnect. Retrying...
==> ansible-role-php-01: Machine booted and ready!
==> ansible-role-php-01: Checking for guest additions in VM...
==> ansible-role-php-01: Setting hostname...
==> ansible-role-php-01: Configuring and enabling network interfaces...
==> ansible-role-php-01: Mounting shared folders...
    ansible-role-php-01: /vagrant => /Users/bbo/src/gitlab.com/owox-ops-team/ansible-role-php
==> ansible-role-php-01: Machine not provisioned because `--no-provision` is specified.
$ molecule converge
ERROR: Unable to find an inventory file, specify one with -i ?
ERROR:

  RAN: '/Users/bbo/.local/bin/ansible-playbook playbook.yml --inventory-file=.molecule/ansible_inventory --sudo --connection=ssh --limit=all --user=vagrant --timeout=30 --diff'

  STDOUT:

  STDERR:

I suppose due to:
https://github.com/metacloud/molecule/blob/46a6e28/molecule/commands.py#L143

Ah, I see the issue. Create writes the state file showing the machines are running, but since it doesn't call  converge, the inventory file doesn't get created.  I'll get a fix out for this shortly.
In the meantime, if you create your machines on the first run by using converge instead of create it will work as expected.


collection not accessible

cannot access property of object array.
var get = require('get-value');
get({a:['a','aa','aaa']}, 'a.2');
// => 'aaa'
get({c:[{},{b:1},{}]}, 'c.1');
// => { b: 1 }
get({c:[{},{b:1},{}]}, 'c.1.b');
// => undefined

hmm, it's a good idea. seems like more of a feature request than a bug though.

this works currently


[Boss Mechanic] - Can only Fight with Spells (Ability cooldowns greatly reduced)

Concept:

Boss can only take damage from spells (or extremely reduced damage from auto attacks).
The damage taken from spells is amplified.
The cooldowns for anyone in the area while fighting the boss is greatly reduced.
-The character mana regeneration is greatly increased.
-Boss fights by using Telegraphed abilities
-Boss does AOE Lotus Orb effect which reflects all spells back to targets.

Thank you for your post. Could you expand on it? As it is, there is very little to go on here.


Switch to PROD pools

/cc @MattGal

Failure unrelated to pool switch.

Sorry, I didn't see this before I created and merged #436.


ExceptionMapper not thread safe

ExceptionMapper is accessed from multiple request threads but the underlying Map is a HashMap; could be refactored to use a ConcurrentHashMap or methods could be made synchronized

I can't claim to be very knowledgeable about the inner workings of Spark, but from a quick read of the sources, I think this is not necessarily a big problem. The exception mappings are done in SparkInstance.exception(), which is synchronized (and AFAIK, multiple instances are not intended to be used). MatcherFilter accesses the mappings without synchronization, but in a read-only fashion. As long as exceptions are mapped before SparkInstance.init()is called, we're good - of course, nothing prevents users from adding routes or filters before exception mappings, which could cause a race condition. I guess the solution would be to either synchronize access (or use a concurrent map) or require that exceptions are not mapped after initialization.


fetch support for ADD JAR queries

I'm using rbhive on HiveServer2 to execute arbitrary commands and, if there is a response, to capture that.  The fetch command works generally quite well.  However, it seems to not support "ADD JAR ..." type commands for loading UDFs.
I can alternatively use the execute command.  However, this has the disadvantage of not loading results in a simple way and of suppressing all errors.
Is there a way to modify fetch so that it supports arbitrary queries?
Thanks,
Kevin

@andytinycat I got this issue with cdh5
options = { :transport => :buffered, :hive_version => :cdh5, :transport => :sasl, :sasl_params => {}}
RBHive.tcli_connect("hive-server-address", 10000, options) do |connection|
    connection.execute("ADD JAR /nfs/shared/path/to/myjar.jar")
    ...
end

The error I got is
RBHive::TCLIConnectionError:
       Error while processing statement: /nfs/shared/path/to/myjar.jar does not exist

I could go to the server and verify that the file exists: ls -l /nfs/shared/path/to/myjar.jar.
Do you have any idea why?


[Improvement][Storage-Space]: Add new permission domain

Connector Name
module/storage-space (Storage Space Connector)
Suggested feature
Create new permission model for Key Value Store.
Related issues
No response

This feature got deviated from the original plan


Check if notifications is disabled but in python

Is it possible to check whether notifications is disabled (app or overall), so that I can skip the notification and do something else? I would prefer to be able to check before trying to show the notifications rather than checking retrospectively if the notification was shown or not, in python?

@Sxvxgee Hi, the github issues in the documentation repos are solely intended for feedback specifically related to documentation. For developer support, I suggest you open an issue on the Microsoft Q & A site where support engineers can help you with your question.


hook failed: "update-status"  when relating for more than one application

adding hw-observer for one application worked fine(let say nova-compute), but when adding it for other application in the same model i.e ceph-osd or ubuntu(which are on metal) it is getting failed with the below error.
detailed error log:
unit-hardware-observer-11: 14:22:39 INFO unit.hardware-observer/11.juju-log Writing file to /etc/hardware-exporter-config.yaml.
unit-hardware-observer-11: 14:22:39 INFO unit.hardware-observer/11.juju-log Writing file to /etc/hardware-exporter-config.yaml - Done.
unit-hardware-observer-11: 14:22:39 ERROR unit.hardware-observer/11.juju-log Uncaught exception while in charm code:
Traceback (most recent call last):
File "/var/lib/juju/agents/unit-hardware-observer-11/charm/./src/charm.py", line 173, in
ops.main(HardwareObserverCharm)  # type: ignore
File "/var/lib/juju/agents/unit-hardware-observer-11/charm/venv/ops/main.py", line 451, in call
return main(charm_class, use_juju_for_storage=use_juju_for_storage)
File "/var/lib/juju/agents/unit-hardware-observer-11/charm/venv/ops/main.py", line 436, in main
_emit_charm_event(charm, dispatcher.event_name)
File "/var/lib/juju/agents/unit-hardware-observer-11/charm/venv/ops/main.py", line 144, in _emit_charm_event
event_to_emit.emit(*args, **kwargs)
File "/var/lib/juju/agents/unit-hardware-observer-11/charm/venv/ops/framework.py", line 340, in emit
framework._emit(event)
File "/var/lib/juju/agents/unit-hardware-observer-11/charm/venv/ops/framework.py", line 842, in _emit
self._reemit(event_path)
File "/var/lib/juju/agents/unit-hardware-observer-11/charm/venv/ops/framework.py", line 931, in _reemit
custom_handler(event)
File "/var/lib/juju/agents/unit-hardware-observer-11/charm/./src/charm.py", line 144, in _on_config_changed
self._on_update_status(event)
File "/var/lib/juju/agents/unit-hardware-observer-11/charm/./src/charm.py", line 90, in _on_update_status
if not self.model.get_relation("cos-agent"):
File "/var/lib/juju/agents/unit-hardware-observer-11/charm/venv/ops/model.py", line 237, in get_relation
return self.relations._get_unique(relation_name, relation_id)
File "/var/lib/juju/agents/unit-hardware-observer-11/charm/venv/ops/model.py", line 864, in _get_unique
raise TooManyRelatedAppsError(relation_name, num_related, 1)
ops.model.TooManyRelatedAppsError: Too many remote applications on cos-agent (3 > 1)
unit-hardware-observer-11: 14:22:40 ERROR juju.worker.uniter.operation hook "config-changed" (via hook dispatching script: dispatch) failed: exit status 1
unit-hardware-observer-11: 14:22:40 INFO juju.worker.uniter awaiting error resolution for "config-changed" hook
unit-hardware-observer-11: 14:26:18 INFO juju.worker.uniter awaiting error resolution for "config-changed" hook
unit-hardware-observer-11: 14:27:40 INFO juju.worker.uniter awaiting error resolution for "config-changed" hook
unit-hardware-observer-11: 14:27:41 INFO unit.hardware-observer/11.juju-log Setting exporter-log-level to: INFO
unit-hardware-observer-11: 14:27:41 INFO unit.hardware-observer/11.juju-log Setting exporter-port to: 10000
unit-hardware-observer-11: 14:27:41 INFO unit.hardware-observer/11.juju-log Setting redfish-password to:
unit-hardware-observer-11: 14:27:41 INFO unit.hardware-observer/11.juju-log Setting redfish-username to:
unit-hardware-observer-11: 14:27:41 INFO unit.hardware-observer/11.juju-log Detected changes in exporter config.
unit-hardware-observer-11: 14:27:41 INFO unit.hardware-observer/11.juju-log Attempt 1 of /redfish/v1/
unit-hardware-observer-11: 14:27:41 INFO unit.hardware-observer/11.juju-log Response Time for GET to /redfish/v1/: 0.19726872816681862 seconds.
unit-hardware-observer-11: 14:27:42 INFO unit.hardware-observer/11.juju-log Attempt 1 of /redfish/v1/SessionService/Sessions
unit-hardware-observer-11: 14:27:42 INFO unit.hardware-observer/11.juju-log Response Time for POST to /redfish/v1/SessionService/Sessions: 0.1827135756611824 seconds.

There are 2 grafana-agent and then cause this problem. It may be not a real issue, should remove one of grafana-agent in the environment.


international sms

Does it work on internation sims ?
just asking ^_^

First of all, I'm sorry, I've been busy with school lately and will not be able to respond to issues in a timely manner.
I am not sure if the program supports international numbers (not 86+) as the program collects interfaces for websites in mainland China. But you can give it a try. :)

dont work in arg


fix focus outline placement button

Fixes

Fixes #1110 by @sarayourfriend
Description

FIxes the play pause button outline placement as suggested by @sarayourfriend
SIDE NOTE -> I had already submitted this PR but I had to delete my forked repo because I had by mistake messed up the main branch in that repo, sorry, won't happen again. This caused my previous PR to auto-close.
Testing Instructions

Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the default branch of the repository (main) or a parent feature branch.
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[x] I added or updated tests for the changes I made (if applicable).
[x] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

as discussed earlier, I will resubmit the dev dependency update PR (now closed) once #1131 is merged and ready to go : )

@dhruvkb @sarayourfriend could you both review this when you have a chance?

I am a little confused about what I am supposed to do here ... :smiling_face_with_tear:

@dhruvkb thanks for clearing that up, I committed your requested changes as is. 👍


Wiki is borked 🐛

Firefox on Ubuntu19
Worked a few days ago. Went to the wiki yesterday it looked like this. Today I also went to the wiki and it's still borked so reporting this bug. Looks like it might be a deployment snafu, but I dunno

That's usually what it looks like when you're on a page that doesn't exist anymore. Try just going to https://wiki.aragon.org and navigating from there.


Mutex does not lock

I have a Singleton Node script.
In the initialization script I try to do the following:
func _init():
    print("point a")
    var mutex = Mutex.new()
    mutex.lock()
    mutex.lock()
    print("point b")

The code above should never reach to point b, but it just ignores the Mutex.

You should fill out the issue template since Mutexes are implemented differently on each platform and Godot version.
If you are on Windows for example Godot uses WaitForSingleObject to acquire a mutex. According to the docs  the wait-funtions can be called on the same thread multiple times without blocking if it already has ownership of the mutex.
I don't know how this behaves on other platforms though. That said i think i recently saw @RandomShaper implement threads and mutexes using the C++11 standart lib (for 3.2 and master)

@mbrlabs is right. Mutexes in Godot are expected to be recursive, so a single thread can lock multiple times without unlocking.
I'd close this as no bug and only reopen in case something can be added that actually means there's a bug.

Is it properly documented in the Mutex class reference? If so this can indeed be closed.

It isn't, neither in 3.2 nor latest.


Optimize for large datasets

Reference ticket: https://trello.com/c/SjvSTkdW/537-optimize-pipeline-for-large-geospatial-datasets
The pipeline was failing due to large geospatial datasets. The pipeline during the flattened process will now run in batches to avoid Out of Memory issues.

Codecov Report
Attention: 39 lines in your changes are missing coverage. Please review.

Comparison is base (ba8f98b) 78.94% compared to head (8e1a150) 78.77%.
Report is 3 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
- Coverage   78.94%   78.77%   -0.17%
==========================================
  Files          67       67
  Lines        3558     3572      +14
==========================================
+ Hits         2809     2814       +5
- Misses        749      758       +9

Files
Coverage Δ

digital_land/commands.py
67.93% <15.21%> (-1.64%)
:arrow_down:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Submission ombahiwal EdvineilHP

LINK TO THE GIT-EXERCISE

Good in general, but

source branches not on forks
minor: no reviewers assigned
commit messages not readable


Bump Django to 2.1.6

Django 1.11.x before 1.11.19, 2.0.x before 2.0.11, and 2.1.x before 2.1.6 allows Uncontrolled Memory Consumption via a malicious attacker-supplied value to the django.utils.numberformat.format() function (CVE-2019-6975).

Why not go straight to 2.1.7?

I thought 2.1.6. is the latest.


feat(Algebra/DirectSum/Decomposition): extensionality lemma for maps from a decomposition

Two linear maps from a module with a decomposition agree if they agree on every piece.
Also replaces some bad simps lemmas with manual ones.

bors merge


Error with MSB bit in EDIF writer

There's error during EDIF export.
If top-module has multi-bit input/output, EDIF writer during export always reverts bit order.
If bits of output port have different functions, then resulting function mapping will be incorrect.

But during EDIF export bits order changed, so INV functions is on portRef (member Q 1)).
If some external user desides to connect to the EDIF module depending on it's RTL functionality,
then his device will react unexpectedly.
But if invert bit order in input Verilog file, then in resulting EDIF order will be changed twice.
module testmodule (A, Q);
input [0:1] A;
output [0:1] Q;
INV inst0 (.A(A[0]), .Q(Q[0]));
BUF inst1 (.A(A[1]), .Q(Q[1]));
endmodule

Result:
    (cell testmodule
      (cellType GENERIC)
      (view VIEW_NETLIST
        (viewType NETLIST)
        (interface
          (port (array Q 2) (direction OUTPUT))
          (port (array A 2) (direction INPUT))
        )
        (contents
          (instance inst1
            (viewRef VIEW_NETLIST (cellRef BUF (libraryRef LIB))))
          (instance inst0
            (viewRef VIEW_NETLIST (cellRef INV (libraryRef LIB))))
          (net (rename id00001 "A[0]") (joined
            (portRef (member A 1))
            (portRef A (instanceRef inst1))
          ))
          (net (rename id00002 "A[1]") (joined
            (portRef (member A 0))
            (portRef A (instanceRef inst0))
          ))
          (net (rename id00003 "Q[1]") (joined
            (portRef (member Q 0))
            (portRef Q (instanceRef inst0))
          ))
          (net (rename id00004 "Q[0]") (joined
            (portRef (member Q 1))
            (portRef Q (instanceRef inst1))
          ))
        )
      )
    )

In this case output port Q[0] uses INV as expected.

I suppose this problem is related
https://github.com/YosysHQ/yosys/issues/568

See https://github.com/YosysHQ/yosys/pull/830#issuecomment-468809795 and http://svn.clifford.at/handicraft/2019/vivadoedif: The current behavior is to always use array index 0 for the MSB array element, and to use the name Verilog uses for the bit in the rename clause. This mirrors the exact behavior of Xilinx Vivado.
We can add support for other "EDIF flavors", but for that we would need to know what other tool you want us to emulate and what the exact behavior of that tool is.


Remove 'insert key' refs

Description
This is from docs team. Removing some references to 'Insights' and to 'insert key' (as that has been deprecated in favor of license key). Also rewrote some of the 'report custom data' doc as I noticed it seemed a little out of date and incorrect.

@zuluecho9 did you still need this merged?


Update phpunit

As per title. For now I've decided to use https://packagist.org/packages/dms/phpunit-arraysubset-asserts as it's easier than changing test for views :)

@alcaeus we need to either drop PHP 7.2 or postpone this update to 2.2

Dropping 7.2 is out of the question for now. We can change the constraint to ^8.2 || ^9.0.

I'll see what needs to happen with array subsets. It's not critical for 2.1 so I'll take it off the roadmap

Taken care of in #2248.


fix stats for Mattermost and add tests

What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area outputs
What this PR does / why we need it:

fix the stats for Mattermost which was using for another receiver.
add some tests
format a bit

ps. I can add tests for the other if no one is against
Which issue(s) this PR fixes:
None
Special notes for your reviewer:

@cpanato: The label(s) area/outputs cannot be applied, because the repository doesn't have them

In response to this:

What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area outputs
What this PR does / why we need it:

fix the stats for Mattermost which was using for another receiver.
add some tests
format a bit

ps. I can add tests for the other if no one is against
Which issue(s) this PR fixes:
None
Special notes for your reviewer:

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign leogr after the PR has been reviewed.
You can assign the PR to them by writing /assign @leogr in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Welcome @cpanato! It looks like this is your first PR to falcosecurity/falcosidekick 🎉

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Issif
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Issif]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 1c7e7cdb716d1c1b897b140e9a91b068d469178f


Looking for IAM policy for creating EKS clusters

Description
The "docs" folder in ht repo is missing. There is a reference to a iam policy document for EKS that is not found at this link: https://discuss.hashicorp.com/t/eks-cluster-not-destroyed-completely-getting-error-unauthorized/18569
the page comes up 403 and the docs folder is missing entirely.
Short of that, I have been been searching for a minimum policy for eks cluster creation. Is it possible for anyone to post something here?

The policy is highly dependent on what configuration you are trying to provision. My recommendation would be to use a tool like https://github.com/iann0036/iamlive that will generate the policy based on the API calls used when creating your cluster


Add support for iojs's fs.access method.

Coverage remained the same when pulling 93b011d47a711bd8b04ec4d2967d6b9629222407 on JiangJie:master into b64e55565e3d1f7c42eb155ec3cf5edbcb508977 on normalize:master.

was gonna somehow polyfill this for nodejs but this shall do for now

The property check is redundant. It is already done by thenify-all

Could you please land this ?
I'd like to use fs.access in my koa app

oops sorry. published!


fix for #1142 and #1149 after this change 3rd column in stacked view…

fix for #1142 and #1149 after this change 3rd column in stacked view is not appearing anymore

Coverage remained the same at 76.517% when pulling 8acc9664fcf033ac4b7dcda3a3e4710b2d83270b on domind:fix-#1149-#1142 into 12b2d2baadd2fe4815ea04fe9f9240a1687876d7 on gregnb:master.

interested :)

Closing in favor of https://github.com/gregnb/mui-datatables/pull/1312


[BUG] xgrammar does not follow the constraint

xgrammar does not follow the integer constraint and generate a floating number for an integer filed.
Schema
https://github.com/sgl-project/sglang/blob/1f4514601e4c6595bb7b79dd24347ad01fa1d119/test/srt/test_json_constrained.py#L30
Error
======================================================================
FAIL: test_json_openai (__main__.TestJSONConstrained)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/root/sglang/test/srt/test_json_constrained.py", line 109, in test_json_openai
    assert isinstance(js_obj["population"], int), f"{js_obj=}"
AssertionError: js_obj={'name': 'Paris', 'population': 2.0}

Reproduce:
branch: https://github.com/sgl-project/sglang/tree/xgrammar-fail
python3 test/srt/test_json_constrained.py TestJSONConstrained.test_json_openai

Hi, I'm researching inference-serving frameworks that implement Grammar-Constrained Decoding (GCD) for Context Free Grammar (CFG) and you guys are the first to include the recent xgrammar. I'm trying to reproduce this error with the specified branch but I get the following new one:
File "/home/rog0d/miniconda3/envs/sglang/lib/python3.10/site-packages/sglang/srt/constrained/bnf_cache.py", line 44, in __init__
self.grammar_cache = GrammarMatcherInitContextCache(
TypeError: Dummy() takes no arguments

When deploying the container provided here with xgrammar as the backend,
docker run --gpus all \
    --shm-size 32g \
    -p 30000:30000 \
    -v ~/.cache/huggingface:/root/.cache/huggingface \
    --env "HF_TOKEN=<hf_token>" \
    --ipc=host \
    lmsysorg/sglang:latest \
    python3 -m sglang.launch_server --model-path meta-llama/Llama-3.2-3B-Instruct --host <IP_ADDRESS> --port 30000 --grammar-backend xgrammar

I get the same Dummy() error.  Is there something different I'm missing? I've traced it back to this PR.
I would like to test SGLang with CFG (apart from JSON and Regex) using outlines and xgrammar, if I manage to test it I'll gladly contribute it here.
One possible solution could be to reproduce vLLM OpenAI compatible server and its workflow as they have a guided_grammar parameter.

@roG0d You need to compile and install xgrammar: https://github.com/mlc-ai/xgrammar
pip install pybind11 ninja

mkdir build
cd build
cmake .. -G Ninja
ninja
cd ../python
pip install -e .
add ./python to PYTHON_PATH

@roG0d Yes it is not uploaded to pypi yet. We will further integrate it soon and avoid this compile step.

xgrammar: https://pypi.org/project/xgrammar/

That issue is fixed in XGrammar v0.1.5.


feat: Add view binding for Reference app

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #515
Description
N/A
Alternative(s) considered
N/A
Type
Choose one: Feature
Screenshots (if applicable)
Checklist

[x] I have read and acknowledged the Code of conduct
[x] I have read How to Contribute
[x] I have read the Developer's guide
[x] I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA
[x] I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach
[x] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project
[ ] I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally
[x] I have built and run the reference app(s) to verify my change fixes the issue and/or does not break the reference app(s)

@epicadk I have made the changes you have asked for. Since there was a lot of merging and permission issues I decided to open a new PR.

@jingtang10 Thanks, please merge it. I don't have write access.


[SDP-1008] Add missing space when building the query

What
Add missing space when building the query
Why
The previous code was creating the string %sGROUP BY... instead of %s GROUP BY.
Known limitations
I wonder why the unit tests were succeeding in the PRs but failing in local host.
Checklist
PR Structure

[x] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[x] This PR does not mix refactoring changes with feature changes (split into two PRs otherwise).
[x] This PR's title starts with the name of the package, area, or subject affected by the change.

Thoroughness

[x] This PR adds tests for the new functionality or fixes.
[x] This PR contains the link to the Jira ticket it addresses.

Configs and Secrets

[x] No new CONFIG variables are required -OR- the new required ones were added to the helmchart's values.yaml file.
[x] No new CONFIG variables are required -OR- the new required ones were added to the deployments (pr-preview, dev, demo, prd).
[x] No new SECRETS variables are required -OR- the new required ones were mentioned in the helmchart's values.yaml file.
[x] No new SECRETS variables are required -OR- the new required ones were added to the deployments (pr-preview secrets, dev secrets, demo secrets, prd secrets).

Release

[x] This is not a breaking change.
[x] This is ready for production.. If your PR is not ready for production, please consider opening additional complementary PRs using this one as the base. Only merge this into develop or main after it's ready for production!

Deployment

[ ] Does the deployment work after merging?

stellar-disbursement-platform-backend-preview is available here:SDP:      https://sdp-backend-pr121.previews.kube001.services.stellar-ops.com/healthAP:       https://sdp-ap-pr121.previews.kube001.services.stellar-ops.com/healthFrontend: https://sdp-backend-dashboard-pr121.previews.kube001.services.stellar-ops.com


Installing mediapipe w/ pip doesn't work on MacOS using python 3.7.9 (64-bit)

Overview
Hello! Hope this reaches you well. Would love to start using mediapose with my work, but I'm having some trouble with my pip install.
I'm running into the same No matching distribution found error as {#1325, #1466, #1961}. Their proposed solutions regarding python version and build unfortunately didn't work for me.
System Information

python == 3.7.9 (64-bit)
pip == 21.0.1
OS: Mac 10.14.6

Screenshot

MediaPipe PyPI supports macOS 10.15 and above. See details at https://github.com/google/mediapipe/blob/master/docs/getting_started/troubleshooting.md#python-pip-install-failure

I'm using macOS Monterey and I still have this error from terminal

:

I'm using macOS Monterey and I still have this error from terminal:

Please do verify that the python version is higher than 3.7 and run python3 -m pip install mediapipe.

Just wondering if anyone found a canonical way to handle or troubleshoot this, (installing on mac with pip), other than building from source .... We tried fiddling and upgrading versions like people have suggested on this thread, to no avail.
We have some issues with M1 processor architecture on MacOS 11.2 where we can safely build from source, but we'd also like to have the ability to automatically fetch mediapipe in conda based installs which we have as part of our dev-ops routines.


[BUG] No method to list Assessments of SecurityAssessmentCollection to get SecurityAssessmentResources

Library name and version
Azure.ResourceManager.SecurityCenter 1.1.0
Describe the bug
In order to access the SecurityAssessmentResources of Azure Defender for Cloud, we use the SecurityAssessmentCollection Class, but there exists no method in the class to list all Assessments, only methods to fetch specific one by ResourceIdentifier.
There's also no other way to get the ResourceIdentifiers of SecurityAssessmentResources, making it impossible to access them altogether using the library.
SecurityAssessmentCollection has a private property _securityAssessmentAssessmentsRestClient of type AssessmentsRestOperations, which has the method 'ListAsync' to list all Assessments within a scope, but this class is internal and the function is not used in SecurityAssessmentCollection to provide a method of listing all Assessments within a scope.
Expected behavior
SecurityAssessmentCollection should have a List method, utilizing the List method of _securityAssessmentAssessmentsRestClient, to provide a way of listing all Assessments within a scope. Or any other way to list the Assessments.
Actual behavior
There exists no way of listing the Assessments within a scope, and therefor no way of accessing any SecurityAssessmentResource overall.
Reproduction Steps
Nothing to reproduce.
Environment
No response

add @ArthurMa1978 for help

@ArthurMa1978 any idea if this can be fixed?


Angular rail detector set to on mouse out

Describe the bug
The navigation rail's active item color doesn't change until the user moves the mouse out. This only seems to happen when a rail is inside the drawerLayout.
What is the expected behavior?
Should behave.
What are the steps to reproduce?

Go to https://pxblue-components.github.io/angular-dev/?path=/story/components-drawer--within-a-drawer-layout
Set variant to rail
Click around but don't move the mouse cursor out of the rail area. Observe that the color won't change
Move the mouse out. Now you see the color applied correctly.

Screenshots or links to minimum reproduction example
https://user-images.githubusercontent.com/8997218/105866264-d0b85400-5fc1-11eb-8720-49103860a080.mov
Environment
MacOS Chrome
Anything else to add?
Only seen on storybook so far.

This is 100% a storybook issue.  There's a couple solutions here that come to mind, none of which are good fixes.

Wrap the DrawerLayout story in a component so that we can manually invoke change detection whenever the variant changes.  This will render our story source tab useless in storybook, so this is why I want to avoid this solution (might not work).
Split the DrawerLayout story into 2.  One for all non-rail variants.
Remove rail variant from the DrawerLayout story.

This is storybook issue and could be fixed with latest version of Story Book.

Look in to option 2 (Split the DrawerLayout story into 2. One for all non-rail variants.)


Bugfixes for CMORizer data util functions and WGetDownloader arguments

Description

Closes #3145

Fix description per function

unpack_files_in_folder: added some files extensions that are supported by shutil

save_variable: added days, hours and minutes in the output filenames for relevant frequencies.

fix_dim_coordnames: changed so it only loops on dim_coords (e.g. an input cube with a depth aux_coord would turn it into a new longitude) and made so that it fetches the coord_infos directly from the CMOR_TABLES according to the project (default OBS6) instead of the manual input of incorrect information.

WGetDownloader.download_file: replaced the output argument to put it in a joined form (--output-file=file instead of -O file) and prefixed the filename by the output directory. Maybe it is distribution specific but the argument --directory-prefix was not consumed on my attempts.

Before you get started

[x] ☝ Create an issue to discuss what you are going to do

Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

[x] 🛠 This pull request has a descriptive title
[x] 🛠 Code is written according to the code quality guidelines
[ ] 🛠 Documentation is available
[ ] 🛠 Tests run successfully
[x] 🛠 The list of authors is up to date
[ ] 🛠 Any changed dependencies have been added or removed correctly
[x] 🛠 All checks below this pull request were successful

To help with the number of pull requests:

🙏 We kindly ask you to review two other open pull requests in this repository

Thank @Neah-Ko , I will take a look as soon as I can. Could you please try to add a more descriptive title in this PR?

Hi @bouweandela
I am referring to you because I understood from ESMValCore issues tab that you were in charge of supporting new python versions (at least the 3.11 one).
I am writing this comment in reaction to the codacy code analysis above.
The pylint check is failing because of an unrecognized instruction: match
Python 3.10 introducted structural pattern matching which finally allows us to do proper switch case like statements in python.
I couldn't find a precise release version that supports those but looking for "structural pattern matching" in the documentation. However, I found that the current latest stable version 2.17 changelog mentions fixing some issues to support this feature.
And the highlights of pylint v2.9 claims that this version supports python 3.10.
Since ESMVal is now python 3.10 compatible (and maybe 3.11 soon), it would be nice that pylint gets updated as well.

Actually, @valeriupredoi had been working on Python 3.11 support in ESMValGroup/ESMValCore#1776.
Unfortunately, you can't use any of those nice new features until they are available in all the Python versions we support. At the moment that are these versions: https://github.com/ESMValGroup/ESMValTool/blob/ebf2afd706c83431ba75b3afc7b0b1a1e12b1491/.github/workflows/test.yml#L18. We try to follow NEP 29.

@Neah-Ko I'm trying to get us support Python=3.11 soon; unfortunately that doesn't depend directly on us, but rather, on a couple dependencies that themselves need to start supporting the latest Python, so am working with them speed up the process :beer:


Fix Race in Micrometer Test

When timers have dynamic tags, creation of the timers is deferred until the first completion of a timer with a set of tag values.
Use awaitility to wait for the timer to be created before checking the count.
cherry-pick to 2.9.x

... and cherry-picked to 2.9.x


Using magic-chunks with a netcoreapp1.0 project

Hello,
As I essentially want to transform appsettings.json during the MSBuild phase, I tried adding magic-chunks to my project but the following error message pops up:

Package MagicChunks <IP_ADDRESS> is not compatible with netcoreapp1.0 (.NETCoreApp,Version=v1.0). Package MagicChunks <IP_ADDRESS> supports: net45 (.NETFramework,Version=v4.5)

Any ideas? Any intent of support netcoreapps ?
Thanks,
DB

Hi,
Correct. Current implementation based on .NET 4.5, .NET Core.
Migration to .NET is planned, but I can't provide exact ETA for the moment.
I'll update here once it happens.

Magic Chunks migrated to .NET Standard for the moment.
Will be released as part of 1.3.0.

Latest fixes were released to Nuget and VS Marketplace.


feat: add support for virtual devices

Added commands for creating virtual devices and generating events on their behalf.
Checklist

[x] I have read the CONTRIBUTING document
[x] Any required documentation has been added
[x] My code follows the code style of this project (npm run lint produces no warnings/errors)
[x] I have added tests to cover my changes

Closing this PR in favor of #327 to preserve the context of these comments since the command name change resulted in so many file names.


Break out setup into the deploy CK part and add-k8s

Currently there are two options for deploying kubeflow on CK: deploy CK as part of the kubeflow setup, or have a CK environment manually add the k8s cloud, and then do deploy-to. There should be a way to do the full thing, or just add the k8s cloud.

You should be able to add and remove arbitrary Kubernetes clusters with these commands:
python scripts/cli.py k8s add
python scripts/cli.py k8s remove

Though these are both just thin wrappers around juju add-k8s and juju remove-k8s, respectively

Closing since I think this is handled, otherwise feel free to reopen


Implement kernel functions

[ ] Implement linear kernel function.
[ ] Implement another kernel function (e.g. RBF).

Use optimized classes from the following frameworks as much as possible:

NumPy: http://www.numpy.org/
SciPy: http://www.scipy.org/
scikit-learn: http://scikit-learn.org/stable/index.html

Use implementations from here:
https://github.com/scikit-learn/scikit-learn/blob/master/sklearn/gaussian_process/kernels.py


add scalafix+scalameta+scalaparse+scalatex+ammonite-ops+geny+scalaj-http

this rabbit hole was deep.

tested locally:
[info] Project acyclic-----------------: SUCCESS (unchanged, not rebuilt)
[info] Project akka--------------------: SUCCESS (unchanged, not rebuilt)
[info] Project fastparse---------------: SUCCESS (unchanged, not rebuilt)
[info] Project genjavadoc--------------: SUCCESS (unchanged, not rebuilt)
[info] Project geny--------------------: SUCCESS (unchanged, not rebuilt)
[info] Project macro-paradise----------: SUCCESS (unchanged, not rebuilt)
[info] Project scala-------------------: SUCCESS (unchanged, not rebuilt)
[info] Project scala-java8-compat------: SUCCESS (unchanged, not rebuilt)
[info] Project scala-js----------------: SUCCESS (unchanged, not rebuilt)
[info] Project scala-parser-combinators: SUCCESS (unchanged, not rebuilt)
[info] Project scalacheck--------------: SUCCESS (unchanged, not rebuilt)
[info] Project scalafix----------------: SUCCESS (project rebuilt ok)
[info] Project scalameta---------------: SUCCESS (unchanged, not rebuilt)
[info] Project scalatest---------------: SUCCESS (unchanged, not rebuilt)
[info] Project sourcecode--------------: SUCCESS (unchanged, not rebuilt)
[info] Project utest-------------------: SUCCESS (unchanged, not rebuilt)
[info] >>> The dbuild result is------------: SUCCESS (project rebuilt ok)

fyi @lihaoyi @olafurpg @xeno-by @hoffrocket

thanks Olafur, I added your comments in 56c9c953512510d1ea0952b052e34f385b5d1886


Stub run crashes on PEDDY

Description of the bug
The crash:
ERROR ~ Cannot invoke method collectEntries() on null object

 -- Check script './workflows/../subworkflows/nf-core/utils_nfcore_pipeline/main.nf' at line: 110 or see '.nextflow.log' file for more details
ERROR ~ Pipeline failed. Please refer to troubleshooting docs: https://nf-co.re/docs/usage/troubleshooting

 -- Check '.nextflow.log' file for details
-[nf-core/raredisease] Pipeline completed with errors-

Back-tracing it I found that the versions file is invalid for the stub run in the modules/nf-core/peddy/main.nf process.
Here is how it looks now:
    stub:
    def prefix = task.ext.prefix ?: "${meta.id}"
    """
    touch ${prefix}.ped_check.csv
    touch ${prefix}.vs.html
    touch ${prefix}.het_check.csv
    touch ${prefix}.sex_check.csv
    touch ${prefix}.peddy.ped
    touch ${prefix}.html

    touch versions.yml
    """

Edit: Looks like this will need to be fixed in the nf-core module.
Command used and terminal output
No response
Relevant files
No response
System information
No response

Just a follow up. When copying the version code from the run script, I got a yaml file but with invalid content:
"NFCORE_RAREDISEASE:RAREDISEASE:PEDDY":
    peddy: Matplotlib created a temporary config/cache directory at /local/slurmtmp.3277329/matplotlib-88q0dnw3 because the default path (/home/<user>/.config/matplotlib) is not a writable directory; it is highly recommended to set the MPLCONFIGDIR environment variable to a writable directory, in particular to speed up the import of Matplotlib and to better support multiprocessing.
0.4.8

Guess this is easily solved.

With this added this and the full stub run it ran through for me (same as the regular process, plus tail -1)
    cat <<-END_VERSIONS > versions.yml
    "${task.process}":
        peddy: \$( peddy --version 2>&1 | tail -1 | sed 's/peddy, version //' )
    END_VERSIONS

Closing this as the issue was fixed in #576


[feat]: Optimized Sorting Algorithm

Implement a highly optimized sorting algorithm (e.g., radix sort, shell sort) and compare its performance against standard sorting algorithms (e.g., quicksort, mergesort).

@Swapnil-Singh-99 assign me this issue for hacktoberfest

Complete two issue first

@Swapnil-Singh-99 I have completed my two issue, please assign me this issue

@Swapnil-Singh-99 Please label it with hacktoberfest


Add doc for Get-CCMDeploymentStep

Description Of Changes
Add missing documentation for Get-CCMDeploymentStep
Motivation and Context
One of the commands in ChocoCCM was missing a doc page. :(
Testing

[x] I have previewed these changes using the Docker Container or another method before submitting this pull request.

Change Types Made

[ ] Minor documentation fix (typos etc.).
[ ] Major documentation change (refactoring, reformatting or adding documentation to existing page).
[x] New documentation page added.
[ ] The change I have made should have a video added, and I have raised an issue for this.

Issue #

Change Checklist

[x] Requires a change to menu structure (top or left hand side)/
[x] Menu structure has been updated

Related Issue
N/A

@vexx32 I made a new commit with a couple small changes, but other than those, this looks good to me, and I have enabled auto merging on this PR, so it should merge in once the CI builds complete.


compatibility with git plugins

Fixed in v.03 https://github.com/timvink/mkdocs-print-site-plugin/releases/tag/v0.3