HNC: Update namespace labels when a namespace has a critical condition

Currently namespace labels of a namespace are not updated if the namespace has a critical condition (see here).
Ideally, when a namespace has a critical condition, we should update the labels to reflect the namespace hierarchy that we are certain about. We propose the following namespace label updating strategies for each critical condition:

CritParentMissing

CritParentMissing means the parent of a namespace is missing (e.g., the parent is deleted). In this case, we propose to view the namespace that has the condition as a root of a namespace tree and it should only contain depth=0 label. Namespace labels of the descendants of the namespace should include the path from a descendant up till the namespace. Following is an example:
Suppose we have a tree as below where r is the parent of a; a is the parent of b; b is the parent of c.
r
|
a
|
b
|
c
If we delete r, each namespace will have following conditions and proposed labels:
a: Condition: CritParentMissing; Proposed Label: a/depth=0
b: Condition: CritAncestor; Proposed Labels: b/depth=0; a/depth=1
c: Condition: CritAncestor; Proposed Labels: c/depth=0; b/depth=1; a/depth=2
The hierarchy based on proposed labels becomes:
a
|
b
|
c

CritParentInvalid

CritParentInvalid means the parent of a namespace is invalid and causes a cycle. In this case, we propose to view a namespace that has  CritParentInvalid as a root and it should only contain the depth=0 label. Namespace labels of the descendants of the namespace should include the path from a descendant up till the namespace. Following is an example:
Suppose we have a tree as below where r is the parent of a; a is the parent of b and c; b is the parent of d.
r
|
a - b - d
|
c
If we set c to be parent of a, each namespace will have following conditions and proposed labels:
r: Condition: nil; Proposed Label: r/depth=0
a: Condition: CritParentInvalid; Proposed Label: a/depth=0
b: Condition: CritAncestor; Proposed Labels: b/depth=0; a/depth=1
d: Condition: CritAncestor; Proposed Labels: d/depth=0; b/depth=1; a/depth=2
c: Condition: CritAncestor; Proposed Labels: c/depth=0; a/depth=1
The hierarchy based on proposed labels becomes:
r
a - b - d
|
c

CritAncestor

CritAncestor means a critical error (i.e., CritParentMissing and/or CritParentInvalid) exists in an ancestor namespace. In this case, the namespace labels include the path from the current namespace till the root as described above.

cc:
@adrianludwin
@adrianchung
@yiqigao217

This all lgtm.
/cc @rjbez17
What do you think of all this?

Oh, except for one thing: if a is the parent of c, and c is the parent of a, then both a and c should have the CritParentInvalid condition, not just a. That is, all namespaces involved in a cycle should have this condition set. Did you try it and see?

Yes. If you set a to be parent of c first then tried to set c as parent of a, only a will have CritParentInvalid condition. c will have CritAncestor condition.
Here is an example command and outputs.
$ k create ns a-1
namespace/a-1 created

$ k create ns b-1
namespace/b-1 created

$ k hns set b-1 --parent a-1
Setting the parent of b-1 to a-1
Succesfully updated 1 property of the hierarchical configuration of b-1

$ k hns tree a-1
a-1
└── b-1

$ k hns set a-1 --parent b-1
Setting the parent of a-1 to b-1
Succesfully updated 1 property of the hierarchical configuration of a-1

$ k hns tree a-1
a-1 (1)
└── b-1 (2)

Conditions:
1) CritParentInvalid: cycle when making "b-1" the parent of "a-1": current ancestry is "a-1 <- b-1"
2) CritAncestor: Propagation paused in the subtree of a-1 due to a critical condition

$ k describe hierarchyconfigurations hierarchy -n a-1
Name:         hierarchy
Namespace:    a-1
Labels:       <none>
Annotations:  <none>
API Version:  hnc.x-k8s.io/v1alpha1
Kind:         HierarchyConfiguration
Metadata:
  Creation Timestamp:  2020-04-22T15:20:29Z
  Generation:          3
  Resource Version:    36141694
  Self Link:           /apis/hnc.x-k8s.io/v1alpha1/namespaces/a-1/hierarchyconfigurations/hierarchy
  UID:                 ccf77469-84ac-11ea-ae7e-42010a8a0192
Spec:
  Parent:  b-1
Status:
  Children:
    b-1
  Conditions:
    Affects:
    Code:  CritParentInvalid
    Msg:   cycle when making "b-1" the parent of "a-1": current ancestry is "a-1 <- b-1"
Events:    <none>

$ k describe hierarchyconfigurations hierarchy -n b-1
Name:         hierarchy
Namespace:    b-1
Labels:       <none>
Annotations:  <none>
API Version:  hnc.x-k8s.io/v1alpha1
Kind:         HierarchyConfiguration
Metadata:
  Creation Timestamp:  2020-04-22T15:20:29Z
  Generation:          2
  Resource Version:    36141695
  Self Link:           /apis/hnc.x-k8s.io/v1alpha1/namespaces/b-1/hierarchyconfigurations/hierarchy
  UID:                 ccf47a83-84ac-11ea-ae7e-42010a8a0192
Spec:
  Parent:  a-1
Status:
  Conditions:
    Affects:
      Namespace:  a-1
    Code:         CritAncestor
    Msg:          Propagation paused in the subtree of a-1 due to a critical condition
Events:           <none>

IIUC, current behavior makes sense. When we first set a to be parent of c, it is valid and HNC accepts that. When setting c to be parent of a, we view c as an invalid parent because c is the child of a. Therefore we put the CritInvalidParent on a. I guess the assumption here is that a is still a valid parent of c since it is set first.
Consider another example: set a to be parent of b; b to be parent of c, so far so good. Now if we set c to be parent of a, a cycle is created since c is a grandchild of a. CritInvalidParent will be put on a to indicate that c should not be a parent of a. However, it might be confusing if we also put the CritInvalidParent condition on c because b is the parent of c and there is nothing wrong with this relationship (i.e., b is a valid parent).
WDYT?

Thanks for investigating that. K8s objects should be "stateless" - it shouldn't matter what order a series of changes are made in, they should always result in the same outcome. For example, imagine we restart HNC - the order in which we sync a and c will affect which conditions we end up displaying. This seems unfortunate.
I think we should file a separate bug to ensure that both a and c get the same condition. It shouldn't matter who was "first" - they both now have the same problem. Make sense?

Maybe we should change CritInvalidParent to CritCycle or something like that?

Thanks for the reply. I think that makes sense. Right now it is nondeterministic which namespace will get CritParentInvalid condition when restarting HNC (I restarted HNC and this time b-1 got the condition instead of a-1 in my example above).
Changing the name SGTM.
I will fire a separate bug to address this issue.


[release/6.3] PMC define web startup project directory

Fixes #1290
cc @Pilchie

(Wrong branch. Will change once GitHub UI stops glitching)

Go ahead and merge when CI passes.

@AndriySvyryd Did we do anything on this repo to fix this issue?

Unable to open the physical file "F:\workspace.7_work\1\s\bin\AnyCPU.Debug-netcoreapp3_0\Microsoft.ML.Tests\netcoreapp3.0\TestDatabases\iris.mdf". Operating system error 3: "3(The system cannot find the path specified.)".
File activation failure. The physical file name "F:\workspace.7_work\1\s\bin\AnyCPU.Debug-netcoreapp3_0\Microsoft.ML.Tests\netcoreapp3.0\TestDatabases\iris_log.ldf" may be incorrect.

...we might need to cherry-pick it into release/6.3

@bricelam You can go ahead and cherry-pick https://github.com/aspnet/EntityFramework6/commit/ea8ded0aea6aa90c411cea3cecf71a1b2f90a926
I'm going on vacation and won't be able to do it today


Restrict apply user

Currently, every user who can write a comment digger apply,  can apply.
I think it can restricting execution by using github.actor context information.
For example, if action.yaml could be written as shown below, wouldn't it be possible to restrict the users who execute it?
    - uses: actions/checkout@v4
      with:
        clean: false
        ref: refs/pull/${{ github.event.issue.number }}/merge
      if: ${{ github.event_name == 'issue_comment' && inputs.configure-checkout == 'true' && github.actor == inputs.apply_user }}

https://github.com/diggerhq/digger/issues/272

hey @sat0ken this is indeed a very important feature. I like this idea of implementing this way. By the way we have support for OPA based checks in the backend component. Here is a demo video of it in action: https://www.loom.com/share/dd81941447184f66b2f6ed930066cb40?sid=e7113f54-b0a4-45a6-a054-6450c60b7714
If you would like to try it out please join our slack and message me for more details :)


added obey for ifarmpandas

LGTM, but you're missing the period at the end of the sentence. Fix that and I'll merge.


Issue while deploying module template to Globe

Please help.

This means that the Serverpod command is not able to find the client project at the path: ../project_name_client.
Make sure that the client project exists at that path, or configure a different path in the generator.yaml file. The client project is required to run the code generator.

This means that the Serverpod command is not able to find the client project at the path: ../project_name_client.
Make sure that the client project exists at that path, or configure a different path in the generator.yaml file. The client project is required to run the code generator.

New project.
And i can see client project generated by serverpod.
And i can see path set by serverpod.
Then why this error?

Are you getting this error locally or only in a CI environment?
If it is only in the CI env, you are probably not uploading the client.


[Removal]: Request to be removed from the blacklist(5)

Hotspot Name
Decent Aquamarine Pike
Hotspot b58 Address
1191cegq2svtrobJDPK173uym4cDCsuSGqxjMFiXUv8cFHewEq6
Discord Handle
zhanghao125
Hotspot Manufacturer
RAK
Removal Reason
I have changed the machine to field deployment according to the requirements of the project and applied for lifting the blacklist，Please confirm the hotspot status again
Modifications
No
Extra forwarders
No
Extra antennas
No
Additional Information
I have changed the machine to field deployment according to the requirements of the project and applied for lifting the blacklist，Please confirm the hotspot status again

We have taken into account this removal request in the next iteration of the denylist. It may take some time before it's processed. This is an automated comment due to the volume of addition and removal requests. A future tool is in the works to provide more insight into the analysis approach made by the Helium team and community members that maintain this list.


Support DNS01 Self Check args

Great to see this project supporting cert-manager on ocp.  I am trying to use with DNS01 route53 acme and am having issues with the propagation check part of the certificate generation.
Patching the deployment to set the nameservers works fine as per the cert-manager docs.
Is there a way that these extraArgs can be configured for the OpenShift OLM version of cert-manager?

Looks like this can be done, but right now you have to be careful to include the already-existing arguments as well as the extra ones you want to add:
https://github.com/openshift/cert-manager-operator/pull/68/files

/remove-lifecycle stale
/lifecycle frozen

Yeah, this feature is available and documented now. You can use certmanager.spec.controllerConfig.overrideArgs for this purpose. Please refer to: https://docs.openshift.com/container-platform/4.13/security/cert_manager_operator/cert-manager-customizing-api-fields.html for more details. Also, https://docs.openshift.com/container-platform/4.13/security/cert_manager_operator/cert-manager-operator-issuer-acme.html#cert-manager-acme-dns01-aws_cert-manager-operator-issuer-acme documents when you would need to set those args especially under situations where there is an overlap in private and public DNS zone.
/close


thunderbird*: 102.7.2 -> 102.8.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for thunderbird-unwrapped is: A full-featured e-mail client
meta.homepage for thunderbird-unwrapped is: https://thunderbird.net/
meta.changelog for thunderbird-unwrapped is: https://www.thunderbird.net/en-US/thunderbird/102.8.0/releasenotes/
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 102.8.0 with grep in /nix/store/15m0kk1grwkvc5xgm4lyfcwmq6q27mv3-thunderbird-unwrapped-102.8.0
found 102.8.0 in filename of file in /nix/store/15m0kk1grwkvc5xgm4lyfcwmq6q27mv3-thunderbird-unwrapped-102.8.0

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath
thunderbird-unwrapped
thunderbirdPackages.thunderbird
thunderbirdPackages.thunderbird-102

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/15m0kk1grwkvc5xgm4lyfcwmq6q27mv3-thunderbird-unwrapped-102.8.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A thunderbird-unwrapped https://github.com/r-ryantm/nixpkgs/archive/0582f13e3c5bde89ea518d2603090df2e7f0404f.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/15m0kk1grwkvc5xgm4lyfcwmq6q27mv3-thunderbird-unwrapped-102.8.0
ls -la /nix/store/15m0kk1grwkvc5xgm4lyfcwmq6q27mv3-thunderbird-unwrapped-102.8.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

thunderbird
thunderbird-unwrapped

Maintainer pings
cc @edolstra @lovesegfault @nbp @vcunat for testing.

https://www.mozilla.org/en-US/security/advisories/mfsa2023-07/

I've been using thunderbird since then all the time, except for a short tryout of thunderbird-bin.

Well yes, of course the commit fixing the updater would need to be dropped for 22.11.  Otherwise there were no conflicts.


I can not turn on the plugin

blender v2.80.44
launched as admin

Happening here as well, tried in 2.79 and latest version of 2.8

Same in 2.8

This happens with the development version of the plugin too.

This happens to me aswell in 2.79 and 2.8.

Same here, Blender 2.8 Mac

try the development branch.

Thanks for reporting, it's fixed now. Update to the latest cats development version with the build-in updater (dropdown cats in user preferences) and if you use 2.80, to the latest Blender 2.80 beta version (https://builder.blender.org/download/)


Wrong download link for RC 6

The install link for v6 RC2 is incorrect
node-gyp configure                                                                                [15:12:49]
gyp info it worked if it ends with ok
gyp info using<EMAIL_ADDRESS>gyp info using<EMAIL_ADDRESS>| darwin | x64
gyp http GET https://nodejs.org/download/release/v6.0.0-rc.2/node-v6.0.0-rc.2-headers.tar.gz
gyp http 404 https://nodejs.org/download/release/v6.0.0-rc.2/node-v6.0.0-rc.2-headers.tar.gz
gyp WARN install got an error, rolling back install
gyp ERR! configure error
gyp ERR! stack Error: 404 response downloading https://nodejs.org/download/release/v6.0.0-rc.2/node-v6.0.0-rc.2-headers.tar.gz
gyp ERR! stack     at Request.<anonymous> (/usr/local/lib/node_modules/node-gyp/lib/install.js:210:14)
gyp ERR! stack     at emitOne (events.js:95:20)
gyp ERR! stack     at Request.emit (events.js:182:7)
gyp ERR! stack     at Request.onRequestResponse (/usr/local/lib/node_modules/node-gyp/node_modules/request/request.js:962:10)
gyp ERR! stack     at emitOne (events.js:90:13)
gyp ERR! stack     at ClientRequest.emit (events.js:182:7)
gyp ERR! stack     at HTTPParser.parserOnIncomingClient [as onIncoming] (_http_client.js:469:21)
gyp ERR! stack     at HTTPParser.parserOnHeadersComplete (_http_common.js:103:23)
gyp ERR! stack     at TLSSocket.socketOnData (_http_client.js:359:20)
gyp ERR! stack     at emitOne (events.js:90:13)
gyp ERR! System Darwin 15.4.0
gyp ERR! command "/usr/local/bin/node" "/usr/local/bin/node-gyp" "configure"
gyp ERR! cwd /Users/corbinu/Developer/git/couchnode
gyp ERR! node -v v6.0.0-rc.2
gyp ERR! node-gyp -v v3.3.1
gyp ERR! not ok

Should be https://nodejs.org/download/rc/v6.0.0-rc.2/node-v6.0.0-rc.2-headers.tar.gz
not https://nodejs.org/download/release/v6.0.0-rc.2/node-v6.0.0-rc.2-headers.tar.gz
Also is there some way to specify the URL manually? Don't see anything about it in the documentation.

Likely a wrong setting in ci
/cc @jasnell

This is also present in the latest nightly builds.

You can try the following option node-gyp configure --dist-url=https://nodejs.org/download/rc

Yes, likely ci issue while passing vars to build -- release_urlbase needs to be changed if a job is manually.

Closing, not a node-gyp issue, see https://github.com/nodejs/node/issues/6237 and https://github.com/nodejs/node/issues/6312.


Can only standard chess pgn format moves be supported?

Can only standard chess pgn format moves be supported?
For example, can you support Asian traditional chess pgn like janggi?

In theory, the standard can support almost all chess variants since it could store positions and moves as text (EPDs and moves in coordination). The code of the chessboard has a base class (BoardCore) that is designed for chess variants. We have tested that class for extending ones for Chess960, Xiangqi, Jeiqi, XChess... all could work well.
Thus the answer is: both the standard and code could support those chess variants. However, I don't know about them! I hope someone knows, is willing to support, and jumps in to help.


EXPERIMENTAL MODULE ONLY ISSUE  - addRipple

When working with MD, clicking button wants to add ripple effect, but that does not work. I think it is related to the usage of a svelte wrapper, so it cannot find the component.

Close - no ES imports components


Add a dedicated configuration file to generate 'src/app/encoder.cpp' …

…and 'src/app/chip-zcl-zpro-codec-api.h'
Problem
So far src/app/chip-zcl-zpro-codec-api.h and src/app/encoder.cpp has been generated
using times to times by manually adding the related templates to to the chip-templates.json and
removing it before checking-in the code since this code does not really belongs to application folders.
It is error prone. An in fact I broken it with #4155 since attributes appears multiple times because of
the second endpoint.
This PR splits the zap-templates folder in two, with one folder for the examples and one fodler for
chip related code.
Summary of changes

Split zap-templates folder in two
Split helper-chip.js into multiple helpers and move those helpers where they belongs
Add a new scripts/tools/zap_generate_chip.sh script to generate the src/app content
Add scripts/tools/zap_generate_chip.sh to scripts/tools/zap_regen_all.py
Create a partial for the licensing header instead of relying on js for it
Fix the attribute issue mentioned above
Remove asChipUnderlyingType since it relies on asUnderlyingZclType and we should be able to fix the issue directly once #4192 lands and it really does not introduce any problem to remove it

Also the out-of-sync issue will only be worse when #4126 lands. This PR creates a place to host the CHIPClusters.zapt and CHIPClusters-src.zapt too.

@hawk248 @BroderickCarlin @jelderton @saurabhst ?

@hawk248 @BroderickCarlin @jelderton @saurabhst ?


Is it thread safe?

Is ttlcache thread safe? If so, why not put it in the features?

It is thread safe.


:wrench: chore(BalAccordion): color support for accordion

Summary
As a helper component to provide additional info to customer we used BalAccordion with grey background to distinguish it from rest of the form. Needless to say, this was not pretty CSS hack, so we would like for the backround color support to be added to BalAccordion component.

This would be the desired look (using --bal-color-grey-2) in this example
Additional Information
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi @predrag-arsic just set the color with a custom css class like has-background-grey-2


[stable/drone] switch to kube-runner

Is your feature request related to a problem? Please describe.
It seems that DRONE_KUBERNETES_ENABLED is deprecated in favor of the new drone/drone-runner-kube Image (kube-runner.docs.drone.io).
Describe the solution you'd like
Let's use kube-runners instead of the (legacy) drone/controller.
Should have:

Deployment for drone/drone-runner-kube:latest
ServiceAccount ($releasename-runner-kube), Role and RoleBinding

https://kube-runner.docs.drone.io/installation/installation/#step-3-install
Nice to have:

ServiceAccount ($releasename-runner-kube-builder), Role and Rolebinding
Support for multiple different runners
Ingress for the new runner dashboard

Probably out of scope:

restrictive PodSecurityPolicies attached to ServiceAccounts that allow/forbid privileged builds

Configuration could look like this:
# values.yml

# breaking change:
# sets the server's DRONE_KUBERNETES_ENABLED variable to false
# but starts kube-runner Deployments instead
server:
  kubernetes: true

runner:
  kubernetes:
  - name: team1
    namespace: drone-runner-kube
    serviceAccount: drone-runner-kube
    replicas: 2
    affinity: ...
    resources: ...
    ui:
      enabled: true # creates a Service for the runner dashboard
      username: admin
      password: password123 # or:
      secret: drone-runner-kube-dashboard # requires a secret containing username and password
      ingress: # creates Ingress
        enabled: true
        annotations: ...
        hosts: ...
    extraEnvVars:
      # https://kube-runner.docs.drone.io/installation/reference/
      DRONE_NAMESPACE_DEFAULT: drone-builds-team1
      DRONE_NAMESPACE_RULES: drone-builds-team1:team1/*
      DRONE_SERVICEACCOUNT_DEFAULT: drone-runner-kube-builder
  - name: team2
  ...

Describe alternatives you've considered
Treat kube-runner as agent:
# values.yml

agent:
  replicas: 2

image:
  agent:
    repository: docker.io/drone/drone-runner-kube
    tag: latest

server:
  kubernetes: false

Contra:

Agent template requires changes and becomes really complicated
You have to set kubernetes to false for this to work which looks strange for a "cloud native" setup with kube-runners
Maybe people still depend on agents

Additional context

@christian-roggia, @zakkg3, what do you think?
I could supply most of the templates required.

I support this. I just hacked up the existing chart to get kube runner working (so I could get features like metadata annotations). Is it popular to run anything other than the kube runner? Could we simplify this chart by removing that support going forward?

@pauvos i think your pr for sec policy its going to be merged, feel free to open another pr for this.

Following up on my previous comment -- that fork didn't go far enough to support the kube-runner. I've spent some time making it work in my repo found here: https://github.com/jonathan-mothership/helm-charts-drone
If it works for others I can submit a PR to this chart.

Following up on my previous comment -- that fork didn't go far enough to support the kube-runner. I've spent some time making it work in my repo found here: https://github.com/jonathan-mothership/helm-charts-drone
If it works for others I can submit a PR to this chart.

sharing is caring, feel free to submit a PR. please document as best as possible, read the docs on how to submit a PR, leave defaults to disable (as the docs say) and so on.
thanks!

@jonathan-mothership I heavily modified your repository and created a pull request https://github.com/helm/charts/pull/20831
@zakkg3 I did it here https://github.com/helm/charts/pull/20831

And also, I added support for k8s secrets, as .drone.yaml can refers to passwords stored in k8s Secret objects


escaping missing for keyword [start] in orderBy

start(... ).. ..orderBy( identifier("node").property("start") )

results as
start...  order by node.start

but should be
start...  order by node.`start`

version neo4j-cypher-dsl 1.7

@jexp
Is there a up to date list of Neo4j Keywords available anywhere?

Good question, only in the parser and the manual
The refcard is probably the most compact variant: http://neo4j.com/docs/stable/cypher-refcard

That's actually an interesting one…
Current Neo4j supports this
create  ({where: 'baz'})
MATCH (n) WHERE (n.where CONTAINS 'baz' OR n.foobar STARTS WITH 'a' OR n.foobar ENDS WITH 'b') RETURN n

I wonder if we should escape properties in the rebooted version all the time as well or not at all.

Wont change the behavior for the time being.


NUMBERS-58: Fix MathJax for mvn javadoc plugin v3

This fixes MathJax support for maven javadoc plugin version 3.
I also fixed a latex formula that I found was broken when testing the output javadocs contained equations.

Coverage remained the same at 92.805% when pulling ded2e3e73376fb9f22ebd163e1932e7396d34534 on aherbert:fix-NUMBERS-58 into 55e07ae99581327c278abc955c7bb3413c285dac on apache:master.


Support for data provider names as is

PhpUnit data provider support names and will it be useful to show them as is :)
    /**
     * Standard set of values for testing string supported values
     *
     * @return array[]
     */
    public static function stringDataProvider(): array
    {
        return [
            '[a-z] string' => ['string'],
            '[a-Z] string' => ['String'],
            '[a-Z0-9] string' => ['String1234'],
            'UTF-8 string' => ['ěščřžýáíéůúňťĚŠČŘŽÝÁÍÉŮÚŇŤ'],
            'Special characters string' => ['~*!-.:/\\"\''],
        ];
    }

    /**
     * @dataProvider stringDataProvider
     */
    public function testSuccess($foo): void
    {
        ...
    }

I'm sorry, but I don't understand what this does.
Could you give me a few examples?

@ecrmnn When you try the example from the issue description, the expected result is:
success [a-z] string [0.001s]
success [a-Z] string [0.000s]
success [a-Z0-9] string [0.000s]
success UTF-8 string [0.000s]
success Special characters string [0.000s]

But current implementation drop the names of data provider steps like in the attached screenshot

We would accept a pull request that fixes this.

@ventrec I created a PR to add this functionality ;)

It work like a charm. Many thanks

@zeleznypa Awesome! I'm very happy with the outcome as well!


shorten cluster name

avoid testing edge case for ACM the purpose of this CI is to validate our dependent component functions to our expectation
Signed-off-by: Hao Liu<EMAIL_ADDRESS>

CI change to fix current integration CI need merge to main before kicking off integration


Error: Plugin not found no installed plugin with that id

Setting up Grafana ScyllaDB's data source but got the following error:

I get the same error and see this when I open the data source


Make comment contrast color a bit more readable.

Thanks for this theme -- loving it :) This is a bit of a nitpick, and pardon we already have options to tweak the comment color, but I sent this (see comment below, apologies) to a buddy of mine and he's like "this comment is hardly visible". Could we improve on that?
Thanks in advance :)

Thanks for this theme -- loving it :) This is a bit of a nitpick, and pardon we already have options to tweak the comment color, but I sent this (see comment below, apologies) to a buddy of mine and he's like "this comment is hardly visible". Could we improve on that?
Thanks in advance :)


Update parser.py

Keep tags during flattening of sequence chains
Without fix, tags seem to be lost in some cases:
$ python3 -c "import jsgf; print(jsgf.parse_expansion_string('this (is){tag1} a (test){tag2}'))"
Sequence(Literal('this'), Literal('is'), Literal('a'), Literal('test'))

With fix, tags remain:
$ python3 -c "import jsgf; print(jsgf.parse_expansion_string('this (is){tag1} a (test){tag2}'))"
Sequence(Literal('this'), RequiredGrouping(Literal('is')) with tag 'tag1', Literal('a'), RequiredGrouping(Literal('test')) with tag 'tag2')

Thanks for catching and fixing this! :+1:

You're welcome! Thanks for the great library.


Feature Enhancement - Additional behavior to Close a Polygon

In a range of other software that has a polygon feature to select, the options to close the polygon include:

Left Clicking
Clicking the starting apex/point
Pressing Enter/Return

At the moment, double clicking on the last apex/point that you place can be a little confusing and can result in adding in an additional apex/point.
An extension on this would be allowing us to edit the placement of the polygon apex/point while in the creation portion of the tool. Typically, clicking an existing point will allow you to drag it about, and then the next time you click (not on an existing apex/point), it will create the new apex/point, after the one that you just edited.
This can be tied into #693 to allow for manual editing of the magic wand selection area.

Closing the polygon:

Current options are double-click and Esc key, I will check whether adding Enter key support will overlap with anything.
What do you mean by left clicking?

Editing polygon points:

After the polygon is created you can edit it. E.g., drag points and add/remove points with Ctrl. Is it something you are looking for?

Hello @kichinsky sorry, I meant right click
Editing after the polygon has been created can be useful, however most of the time we would want to edit the polygon while we are creating it.

@skywalkerisnull I'm not sure what the experience should be to allow editing while creating.

Currently, the cursor shows where the next point will be and technically it can overlap with existing points (so we can't use just left click). I can imagine what using some modificator (e.g., the Ctrl key) will switch the mode from adding a new point to editing.

Thanks for clarifying with the right click. Unfortunately, I'm currently avoiding using it, as it triggers the menu in all browsers as a default behavior. I will check if I can prevent that without sacrificing something. :)

Hey @kichinsky
Google Earth (desktop program) has a pretty good workflow for how to edit when creating:
https://youtu.be/GVjaZ-wW0-o
In most programs that I use where you right click, it doesn't create a point where you right click. It closes (if possible) the current polygon. So in your image above with the cat, it would close the polygon with the solid blue lines, and it would not expand to add in the point with the dashed/dotted lines connecting to it.
No worries, make sense about bringing up the browser context menus. I am fairly certain that there is a way to have JavaScript prevent the browser context menu coming up and possibly replace it with your own using something similar to:
document.oncontextmenu = function() {
    return false;
}


BYOL momentum update function is defined, but not used in the training script

https://github.com/PatrickHua/SimSiam/blob/fca181ed52274088fb39b92f3a9a57f97858e5d3/models/byol.py#L84
I am trying to apply different contrastive learning algorithms to some other fields. I found your implementation is really elegant and useful. However, I found that the BYOL model will not call the momentum update function.
So, is it a BUG, or I have missed it?

I know ... I just can't figure out a way to fit this line of code in the training.

I know ... I just can't figure out a way to fit this line of code in the training.

@PatrickHua May I know about your concerns on the updating?

Bump on this. Is the function well defined but not implemented? It seems to me that you could put it in main.py but I'm not sure if that would mess anything up

anyone who solve this problem?

i added below code in "main.py"
if args.model == 'byol':              model.update_moving_average()             else : pass
and annotate line 80 in byol.py
#raise NotImplementedError('Please put update_moving_average to training')
please, check i'm right.

I'm also having this problem, there is a problem calling this function, what should I do, has anyone solved it

Yes, I also encountered this issue. During the training process of BYOL, when I trained several epochs, its accuracy remained zero, which is different from my training of SimSiam.  SimSiam achieved an accuracy of over 30% at the beginning of the training, and I also found that you did not call update_moving_average() function in your byol.py file, so I referred to other people's code and called it in main.py. The calling code is as follows:
If args. model. name=="byol":
model.module.update_ moving_ average()
Add the original  the parameters of the update_moving_average() function were set in advance, and the momentum update parameter was set to 0.996. Therefore, I rerun it several times, but after training several epochs, the accuracy remained zero. So, I'm not sure how to solve this problem.

I got it, during the training process, after several epochs were trained, the accuracy was 0. The reason for this is that the testing used here is the knn method, which needs to be set  parameter “knn_monitor:True” in the "./configs/byol_cifar10.yaml“ file in order to perform knn testing and avoid the phenomenon of an accuracy of 0. After the byol training is completed, a linear evaluation will be conducted, and this evaluation will not show an accuracy of 0. At first, I thought the byol model had collapsed (but in reality, the training loss was gradually decreasing).
setting “knn_monitor:True” in the "./configs/byol_cifar10.yaml“ file can solve this issue.
Therefore, the main issue is still the setting the parameter ”knn_monitor:True“ in the "./configs/byol_cifar10.yaml“ file The monitor parameter is true only.

Yes, I also encountered this issue. During the training process of BYOL, when I trained several epochs, its accuracy remained zero, which is different from my training of SimSiam. SimSiam achieved an accuracy of over 30% at the beginning of the training, and I also found that you did not call update_moving_average() function in your byol.py file, so I referred to other people's code and called it in main.py. The calling code is as follows:
If args. model. name=="byol": model.module.update_ moving_ average()
Add the original the parameters of the update_moving_average() function were set in advance, and the momentum update parameter was set to 0.996. Therefore, I rerun it several times, but after training several epochs, the accuracy remained zero. So, I'm not sure how to solve this problem.

Could you tell me where you add the calling code?


Improve range queries by specifying max number of results

Improve range queries by specifying max number of results to retrieve in a
given range.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 4 Dec 2009 at 10:01

Implemented by passing the "limit" query parameter: if zero, no limit is
considered.

Moreover, it is now possible to omit the end key in range queries: this way, all
values from the start key up to the limit will be selected.

Original comment by<EMAIL_ADDRESS>on 16 Dec 2009 at 3:57

Changed state: Fixed
Added labels: Milestone-0.2

Original comment by<EMAIL_ADDRESS>on 8 Dec 2009 at 9:35

Added labels: Priority-Low
Removed labels: Priority-Medium


Bundle of patches for 1.1.20.patch2

wmagent 1.1.20 branch version of:

Record a bunch of SetupCMSSWPSet configuration to the logs #8989
Record site status changes timestamp and allow grace period for drain… #8998
Change CMSSW release to >= 10.4.X for LogCollect with edmCopyUtils #9004

 Fix #9010 - Bundle of patches for 1.1.20.patch2


ERROR  [worker reload] [worker init] ENOENT: no such file or directory, mkdir '/tmp/nitro'

Environment
- Operating System: `Linux`
- Node Version:     `v16.17.0`
- Nuxt Version:     `3.2.3`
- Nitro Version:    `2.2.3`
- Package Manager<EMAIL_ADDRESS>- Builder:          `vite`
- User Config:      `modules`, `fetch`, `env`, `runtimeConfig`, `publicRuntimeConfig`, `privateRuntimeConfig`, `nitro`, `alias`, `ssr`, `strapi`, `vite`, `meta`
- Runtime Modules:  `<EMAIL_ADDRESS>`<EMAIL_ADDRESS>`<EMAIL_ADDRESS>- Build Modules:    `-`

Reproduction

npm run dev is normal
deploy in docker, and start with npm run dev failed

Describe the bug

can't start in docker

ipa         |   at mkdirSync (node:fs:1334:3)
ipa         |   at getAddress (.nuxt/dev/index.mjs:824:5)
ipa         |   at .nuxt/dev/index.mjs:828:23
ipa         |   at ModuleJob.run (node:internal/modules/esm/module_job:185:25)
ipa         |   at async Promise.all (index 0)
ipa         |   at async ESMLoader.import (node:internal/modules/esm/loader:281:24)
ipa         |   at async loadESM (node:internal/process/esm_loader:88:5)
ipa         |   at async handleMainPromise (node:internal/modules/run_main:65:12)

Additional context
No response
Logs
No response

It turns out the problem was caused by no enough disk space. I would suggest that nuxt throws comprehensible errors

Glad things were resolved. I suspect the error is coming from Node rather than Nuxt. Improving the error message would be nice if possible. I can't really tell without the full stack trace + error but it's likely coming from calling mkdirSync here:
https://github.com/unjs/nitro/blob/6541373545ee2716566bce46c7568ad2c3164cdf/src/runtime/entries/nitro-dev.ts#L13-L25
cc: @pi0 if he has any ideas, but I'm not personally sure there's a performant way to handle this edge casae


Opaleye Enum

When deserializing postgres types, compare only the type name instead of the schema. The documentation said this was a feature, but it was inconsistent with the implementation.
So now, regardless of PG version or schema-qualified type, we should be only comparing the unqualified type names.

lgtm, assuming it's been tested and works

I tested on pg 13, but not on earlier versions


Mark LoggingError abstract since it is missing errorType and shouldn't be created directly

We have logic in our error handling code that assumes that all errors we raise ourselves will have certain properties, including errorType.  However, the base class for all our errors, LoggingError, is missing this property.
Creating a LoggingError directly will result in any telemetry props added being lost if that error ever goes through a wrapping/normalization codepath.  Two examples where we have this bug are in DataProcessingError.create and FluidDataStoreContext.rejectDeferredRealize.  The latter one made a recent investigation more difficult since we didn't have the packageName available.
This PR makes LoggingError abstract with an abstract string errorType that derived classes must provide.  In order to support callers of new LoggingError who need a concrete implementation to use, this also adds the class GenericFluidError which uses errorType genericError.  This errorType is already used throughout our code and even partner code to indicate a generic fatal error, so it's well-suited for this purpose.  I think this class will be the default replacement for new Error throughout the code as well, see #9752

@anthony-murphy - Our conversation in #9862 is giving me a little bit of pause here.  Basically you are suggesting that there is an additional breed of error which I hadn't considered seriously:  An error originating in our code (shouldn't call it "external" or "untrusted") but which has no errorType (yet).  Asserts fall in this category too for the time being.
I've been applying a lens equating having errorType set to being an error we would return (not throw) through a result-based API.  Asserts are thrown.  The "Runtime is closed" error from #9862 would still be thrown, perhaps - this is the case I hadn't considered much before.
Anyway, back to this PR - Basically, if you want to have an error w/o errorType after this, you need to just use new Error.  If you want to add props to it, you have to normalize it, which equates it with "external"/"untrusted" errors.
I will ponder this, I could see it either way as to whether that's ok for now, or better to leave LoggingError as an option for these cases.  Maybe tweaking some naming somewhere would help.

@anthony-murphy - Our conversation in #9862 is giving me a little bit of pause here. Basically you are suggesting that there is an additional breed of error which I hadn't considered seriously: An error originating in our code (shouldn't call it "external" or "untrusted") but which has no errorType (yet). Asserts fall in this category too for the time being.
I've been applying a lens equating having errorType set to being an error we would return (not throw) through a result-based API. Asserts are thrown. The "Runtime is closed" error from #9862 would still be thrown, perhaps - this is the case I hadn't considered much before.
Anyway, back to this PR - Basically, if you want to have an error w/o errorType after this, you need to just use new Error. If you want to add props to it, you have to normalize it, which equates it with "external"/"untrusted" errors.
I will ponder this, I could see it either way as to whether that's ok for now, or better to leave LoggingError as an option for these cases. Maybe tweaking some naming somewhere would help.

it's also a question of what developers should do. i kind of perfer people just throw new Error() by default, as i always worry about our categorization(errorType) loosing meaning due to over/early categorization. I'd rather applying categorization only be done in very well understood cases, or based on feedback that our clients don't know how to handle something. A non-categorized logging error is useful, as i way want properties, but again don't know the type, this is just a step up from Error.

Yeah I'm leaning towards leaving LoggingError available, and updating normalize/wrap to copy props over if present.
The other important thing LoggingError provides over Error is errorInstanceId which is pretty useful.  I wonder what a better name would be for LoggingError that would make it feel right to use ubiquitously in place of new Error.
I'll update this PR later this week (and should probably open an issue to articulate the problem which is normalize drops props)

Yeah I'm leaning towards leaving LoggingError available, and updating normalize/wrap to copy props over if present.
The other important thing LoggingError provides over Error is errorInstanceId which is pretty useful. I wonder what a better name would be for LoggingError that would make it feel right to use ubiquitously in place of new Error.
I'll update this PR later this week (and should probably open an issue to articulate the problem which is normalize drops props)

my 2 cents. i'm fine with LoggingError. It may not be a perfect name, but if we are consistent about its usage and telling people to use it the name won't matter much.

https://github.com/microsoft/FluidFramework/pull/10657 does the new plan of copying props over as part of normalizeError and wrapError.
There's some further follow-up needed in this space.  e.g. this bug:  errors instrumented with LoggingError (with no errorType specified) will be marked in telemetry as untrustedOrigin.  I will open a bug to track that.  And some general improvements needed in this area, the concepts are very confusing.


bug(global): documentation and/or functionality incorrect for YAML frontmatter

Expected Behavior
Ignored YML directives should work like this:
# kics-scan disable=555ab8f9-2001-455e-a077-f2d0f41e2fb9

##
# Some GitHub workflow
#
---
name: Workflow

And like this
##
# Some GitHub workflow
#
---
# kics-scan disable=555ab8f9-2001-455e-a077-f2d0f41e2fb9
name: Workflow

Actual Behavior
The ignore does not occur when the YAML is formatted like this:
##
# Some GitHub workflow
#
---
# kics-scan disable=555ab8f9-2001-455e-a077-f2d0f41e2fb9
name: Workflow

This actually took me some time to debug because the official documentation actually says that KICS will only work when the ignore directive happens after the front-matter block, when the opposite is actually true. Per the documentation:

NOTE: For YAML when trying to ignore the whole resource this file should start with --- and
then the KICS comment command as you can see on the following example:
---
# kics-scan ignore-block
apiVersion: v1
kind: Pod
metadata:
name: memory-demo-1
namespace: mem-example

Steps to Reproduce the Problem
Create a YAML file with an ignore after the front-matter, per the documentation, that breaks a rule.
Specifications

Version: 1.4.9
Platform: macOS (Docker container linux/amd64)
Subsystem: Megalinter

I have zero clue what scope entails in the directive the bot gave me... better documentation on that would be helpful.


Storing autoform schema in mongo database or nested objects

What i want to do is to store Meteor Autoform schema in database, but it does not work, because simple schema accepts only objects like this
new SimpleSchema({
    person: {
    type: "Object",
    optional: true
},
"person.name": {
    type: "String:
}
})

and mongo db is returning objects like this
new SimpleSchema({
  person: {
    type: "Object",
    optional: true,
    name: {
      type: "String"
    }
 }
})

... so it returns error when i retrieve it and try to use it in Autoform which expects instance of SimpleSchema
I would like to also make things easier for myself (I am building app with many forms with common moving parts) and would like to write something like that
var person = {
      type: Object,
      optional: true,
      name: {
          type: String
      }
      DOB: {
          type: Date
    }
}
new SimpleSchema({
    actor: person,
    theatre: theatreList
    ....
})

so i can reuse my objects in the schema in the future

You may have to escape the dots in the property names when saving into mongo, and then unescape them when retrieving.

@onsta I know this issue is closed but I found a way to do what you were asking. I hope it helps out others
First Take your form object and save out each type keys value as a string like so

var schema = {
   "title":{
      "type":"String",
      "label":"Title",
      "max":200
   },
   "copies":{
      "type":"Number",
      "label":"Number Only",
      "min":0,
      "autoform":{
         "afFieldInput":{
            "type":"tel"
         }
      }
   },
   "booleanEx":{
      "type":"Boolean",
      "label":"Checkbox",
      "autoform":{
         "afFieldInput":{
            "type":"boolean-checkbox"
         }
      }
   },
   "lastCheckedOut":{
      "type":"Date",
      "autoform":{
         "type":"pickadate",
         "timezoneId":"America/New_York"
      },
      "label":"Date Picker",
      "optional":true
   },
   "pictures":{
      "type":"[Object]",
      "label":"Photos with Captions"
   },
   "pictures.$":{
      "type":"Object"
   }
}

Once this is done we can encode the object like using encodeURIComponent(JSON.stringify(form))
the result should look something like this
%7B%22title%22%3A%7B%22type%22%3A%22String%22%2C%22label%22%3A%22Title%22%2C%22max%22%3A200%7D%2C%22copies%22%3A%7B%22type%22%3A%22Number%22%2C%22label%22%3A%22Number%20Only%22%2C%22min%22%3A0%2C%22autoform%22%3A%7B%22afFieldInput%22%3A%7B%22type%22%3A%22tel%22%7D%7D%7D%2C%22booleanEx%22%3A%7B%22type%22%3A%22Boolean%22%2C%22label%22%3A%22Checkbox%22%2C%22autoform%22%3A%7B%22afFieldInput%22%3A%7B%22type%22%3A%22boolean-checkbox%22%7D%7D%7D%2C%22lastCheckedOut%22%3A%7B%22type%22%3A%22Date%22%2C%22autoform%22%3A%7B%22type%22%3A%22pickadate%22%2C%22timezoneId%22%3A%22America%2FNew_York%22%7D%2C%22label%22%3A%22Date%20Picker%22%2C%22optional%22%3Atrue%7D%2C%22pictures%22%3A%7B%22type%22%3A%22%5BObject%5D%22%2C%22label%22%3A%22Photos%20with%20Captions%22%7D%2C%22pictures.%24%22%3A%7B%22type%22%3A%22Object%22%7D%7D

Now you can save that into the database without any issues.
Next part is decoding the message and evaluating each type
 schema : function () {
    var form = Forms.findOne();
    if(form) {
      function evalObjectTypes(obj) {
        for (var k in obj)
        {
          if (typeof obj[k] == "object" && obj[k] !== null) {
            evalObjectTypes(obj[ k ]);
          } else {
            if(k === 'type') {
              try {
                var val = eval(obj[k]);
                obj[k] = val;
              } catch (e) {
                obj[k] = obj[k];
              }
            }
          }
        }
      }

      var de = JSON.parse(decodeURIComponent(form.formSchema));
      evalObjectTypes(de);

      return new SimpleSchema(de);
    }
  }

And boom there you go. The only thing to watch out for is if you are allowing users to insert documents make sure they dont insert any functions because of eval


Make sure of purpose of README.md

DESCRIPTION
In order to start dealing with hack-showcase review documentation it is necessary to determine the exact purpose of this document.
AC

[ ] Determine the exact purpose of /hack-showcase/README.md

I personally have some doubts about the purpose of this file.


Update team.md

Fixed a couple of formatting errors

@jaanli can you approve? I fixed a couple of formatting errors.


[EV-1204] WebSocket connections

Issue being fixed or implemented
Preliminary addition of WebSocket capability to proxy the RPC server implementation
What was done
See above
What has been tested
Nothing
What needs to be tested
Integration tests for the new WebSocket service

@antouhou Do we still need it or we can close it?

@antouhou @shumkov I think we can close this, right?


[HUDI-1121][DOC]Provide a document describing how to use callback

Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contributing.html before opening a pull request.

What is the purpose of the pull request
Add description of the config of write commit callback to describe how to use callback
Brief change log
(for example:)

Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request
This pull request is a trivial rework / code cleanup without any test coverage.
Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@yanghua @leesf please take a look when free


Extension market doesn't load

hi, i'm with vscode on the 1.55.0 version on a 32-bit windows 7 ultimate machine and the extension market doesn't load, it just continues infinetly with the loading animation without loading at all
everytime i start vscode in this notebook i get this error

Thanks! on version 1.55.1 the issu was solved


Nextflow Secrets

Can nf-test be configured to get nextflow secrets? I'm getting some NoCredentialsError from within the test that I don't see from a nextflow cli run itself.

bumping this issue as soon this could be a deal breaker for some nf-core pipelines

Hello, is this issue going to be addressed anytime soon? It's really crucial for my development right now

I have just created a testcase using secrets and it worked as expected. Could you give it a try? Thanks!
test_process.nf
process TEST_PROCESS {

  publishDir "${params.outdir}"

  secret 'MY_ACCESS_KEY'

  output:
     path "*.txt", emit: output_file

  """
  echo "\$MY_ACCESS_KEY" > "token.txt"
  """

}

test_process.nf.test
nextflow_process {

  name "Test process with secrets"

  script "./test_process.nf"
  process "TEST_PROCESS"

  test("Should create 5 files") {

    when {
      params {
        outdir = "output"
      }
      process {
        """
        """
      }
    }

    then {
      assert process.success
      assert path("${launchDir}/output/token.txt").text == "Hello world\n"
    }

  }

}

Setting the Nextflow Secret to "Hello world":
nextflow secrets set MY_ACCESS_KEY "Hello world"

Running the test:
nf-test test test_process.nf.test

@lukfor thank you for your response! I think I wasn't clear enough in my previous message. I can provide secrets for the environment that I execute nf-test in like you suggested, by using nextflow secrets set, that's fine and will meet my needs most of the times. What I would actually like to do, is to be able to set secrets values in either nf-test config or test case, so the test run would be kind of environment agnostic and not dependent on its secrets.

Thanks, for clarification.
I have two points:

I am not sure if this is technically easily possible—we need to avoid overwriting already set secrets or we need to restore them after the test run.
My feeling is that adding these secrets to the nf-test.config file or testcase in plaintext goes against the idea of secrets. What do you think, @sateeshperi? What are the use cases and scenarios in nf-core? Running pipelines with secrets or testing the integration of secrets?

Happy to discuss! 🚀


libc: Move queue.h from include to include/nuttx

Summary
to avoid the conflict with libuv's queue.h.
Replace the patch https://github.com/apache/incubator-nuttx-apps/pull/1321
Impact
Code refactor
Testing
Pass CI

Please ignore the mix case warning from arch/arm/src/phy62xx.

Seems like some files still need to be updated
In file included from wdog/wd_gettime.c:30:
Error: /github/workspace/sources/nuttx/sched/wdog/wdog.h:75:8: error: unknown type name 'sq_queue_t'
   75 | extern sq_queue_t g_wdactivelist;
      |        ^~~~~~~~~~

I will try to run the build locally and feedback


bug: v3 text input and text area, select default focused border color is different

What version of daisyUI are you using?
v3.0.0
Describe your issue
Not sure what happened, but default color of focused border is different for text input and text area, select

What browsers are you seeing the problem on?
Chrome
Reproduction URL (optional)
No response

fix merged

Thank you 🙏


TimePoint is missing

Hello,
I am using version 1.1.0 installed via NuGet. TimePoint is missing in the following namespace ChartJs.Blazor.ChartJS.Common.Time.
Could you please check and fix it?
Thanks!
Br,
Nikolay Papunov

Do you mean TimeTuple?

I would like to create line chart with Datetime for x. I saw the sample code in the repo and there TimePoint was used. I can see the class in the repo as well but not in the NuGet. If the new method is to use TimeTuple, I am fine to use it. Could you please provide quick sample?

As mentioned in the readme

Unlike the documentation, the samples should always be up to date with the current development on master. That means, that the code you see in the samples folder on master might not actually compile on the current nuget version. To browse the samples for the latest nuget version, see the samples on the releases branch.

So here's the time line chart one.

Btw, please see #122 in regards to the samples.


cargo vet init hits stack overflow on wasmtime

STR:
git clone git@github.com:bytecodealliance/wasmtime.git
cd wasmtime
git submodule update --init
cargo et init

results:
thread 'main' has overflowed its stack
fatal runtime error: stack overflow
zsh: abort      cargo vet suggest

Also, for rustc, |cargo vet init| succeeds but I get a stack overflow on the subsequent |cargo vet|.

should be fixed now


Cameradar v4

This PR introduces many breaking changes, mainly to the library, which is why Cameradar will move to v4 once this is merged.
Improvements and features

The Cameradar API is now much simpler to use (fixes #209)
UX has been improved

Spinner removed (fixes #211)
Better logs using disgo
Two new verbosity levels: debug being the default and verbose showing extra logs for each curl request

Unit tests are now consistent (fixes #210)
End to end tests in CI are now more reliable

Added custom routes
Added a second camera
Added two authentication methods in tests

Removed unmaintained documentation

Contributing guide has been removed. It was very outdated and considering the low amount of contributions at the moment (🙁) I don't think it's worth the maintenance cost
Documentation of the library in the readme was removed in favor of godoc. AFAIK no one uses cameradar as a library at the moment so I don't think it was necessary for it to be such a focus of the readme file.

Cameradar API
In the 3.0.0 version, the API of the cameradar API forces you to:

Initialize, manipulate and clean a curl handle
Call 5 or 6 functions from the library, with 4 to 6 arguments each, to perform a complete scan and attack process
Print your own summary of the attack

In the 4.0.0 version, instead, you create a cameradar.Scanner, pass it the options you want, and then simply call Scan, Attack and PrintStreams on it. It is much more intuitive, clean and simple. The logic of the order in which to attack and many other things were moved from the client side to the API side.
User Experience

The new interface is cleaner, provides a better picture of what is going on during the attack process and keeps the same attack summary as the previous interface has.
Its debug and verbose mode are significantly more readable than the previous --log mode.

Pull Request Test Coverage Report for Build 682

339 of 339 (100.0%)  changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 668:
0.0%

Covered Lines:
530

Relevant Lines:
530

💛  - Coveralls


New version: SonicVisualiser.SonicVisualiser version 4.5.2

Pull request has been created with komac v2.1.0 :rocket:
Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

Installation failed with exit code -1978334957
2024-03-29 18:41:40.609 [CLI ] ShellExecute installer failed: 1633
MSI (s) (E4:10) [18:41:40:389]: Product: Sonic Visualiser -- Installation failed.
This installation package is not supported by this processor type. Contact your product vendor.

(Automated response - build 876.)


refactor and add test for node-agent command

refactored the initialBackoff flag to have the same style like other flags (the current one changes the default value in the command flag based on environment variable, which seems not right)
refactored the validation to a single function
added tests for the validation logic

We probably should refactor some of the functions out and make the main.go small and only related to the command line parsing.
https://github.com/istio/istio/issues/13439

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: yangminzhu
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: quanjielin
If they are not already assigned, you can assign the PR to them by writing /assign @quanjielin in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

security/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yangminzhu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-k8s-presubmit-tests.sh
5731074bbb50cb632a2727cf3ea720b07453da6b
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-k8s-presubmit-tests.sh
5731074bbb50cb632a2727cf3ea720b07453da6b
link
/test integ-mixer-k8s-presubmit-tests-master

prow/integ-pilot-k8s-presubmit-tests.sh
0244054438d8b95ec844ecbc11c8729197d7a6f3
link
/test integ-pilot-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-pilot-k8s-presubmit-tests.sh
0244054438d8b95ec844ecbc11c8729197d7a6f3
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
0244054438d8b95ec844ecbc11c8729197d7a6f3
link
/test integ-security-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wattli @incfly All tests passed, could you approve if there is no changes needed in this PR? we can continue the refactor and add more tests in following PR. Thanks!

/lgtm
/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: incfly, yangminzhu
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

security/OWNERS [incfly]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

could you pls hold until @JimmyCYJ  https://github.com/istio/istio/pull/14305 to get in first ? that one is must for 1.2 cut. thanks !

@quanjielin Sure I can wait for this one, but the 2 PRs doesn't block each other and we have plenty time as 1.2 will cut at least 2 weeks later.

@yangminzhu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
0244054438d8b95ec844ecbc11c8729197d7a6f3
link
/test integ-security-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
0244054438d8b95ec844ecbc11c8729197d7a6f3
link
/test integ-security-k8s-presubmit-tests-master

prow/istio-presubmit.sh
0244054438d8b95ec844ecbc11c8729197d7a6f3
link
/test istio-presubmit-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
0244054438d8b95ec844ecbc11c8729197d7a6f3
link
/test integ-security-k8s-presubmit-tests-master

prow/istio-presubmit.sh
0244054438d8b95ec844ecbc11c8729197d7a6f3
link
/test istio-presubmit-master

prow/istio-unit-tests.sh
0244054438d8b95ec844ecbc11c8729197d7a6f3
link
/test istio-unit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
0244054438d8b95ec844ecbc11c8729197d7a6f3
link
/test integ-security-k8s-presubmit-tests-master

prow/istio-presubmit.sh
0244054438d8b95ec844ecbc11c8729197d7a6f3
link
/test istio-presubmit-master

prow/istio-unit-tests.sh
0244054438d8b95ec844ecbc11c8729197d7a6f3
link
/test istio-unit-tests-master

prow/integ-framework-local-presubmit-tests.sh
0244054438d8b95ec844ecbc11c8729197d7a6f3
link
/test integ-framework-local-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
0244054438d8b95ec844ecbc11c8729197d7a6f3
link
/test integ-security-k8s-presubmit-tests-master

prow/istio-presubmit.sh
0244054438d8b95ec844ecbc11c8729197d7a6f3
link
/test istio-presubmit-master

prow/istio-unit-tests.sh
0244054438d8b95ec844ecbc11c8729197d7a6f3
link
/test istio-unit-tests-master

prow/integ-framework-local-presubmit-tests.sh
0244054438d8b95ec844ecbc11c8729197d7a6f3
link
/test integ-framework-local-presubmit-tests-master

prow/integ-pilot-local-presubmit-tests.sh
0244054438d8b95ec844ecbc11c8729197d7a6f3
link
/test integ-pilot-local-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
0244054438d8b95ec844ecbc11c8729197d7a6f3
link
/test integ-security-k8s-presubmit-tests-master

prow/istio-presubmit.sh
0244054438d8b95ec844ecbc11c8729197d7a6f3
link
/test istio-presubmit-master

prow/istio-unit-tests.sh
0244054438d8b95ec844ecbc11c8729197d7a6f3
link
/test istio-unit-tests-master

prow/integ-framework-local-presubmit-tests.sh
0244054438d8b95ec844ecbc11c8729197d7a6f3
link
/test integ-framework-local-presubmit-tests-master

prow/integ-pilot-local-presubmit-tests.sh
0244054438d8b95ec844ecbc11c8729197d7a6f3
link
/test integ-pilot-local-presubmit-tests-master

prow/integ-galley-local-presubmit-tests.sh
0244054438d8b95ec844ecbc11c8729197d7a6f3
link
/test integ-galley-local-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
0244054438d8b95ec844ecbc11c8729197d7a6f3
link
/test integ-security-k8s-presubmit-tests-master

prow/istio-presubmit.sh
0244054438d8b95ec844ecbc11c8729197d7a6f3
link
/test istio-presubmit-master

prow/istio-unit-tests.sh
0244054438d8b95ec844ecbc11c8729197d7a6f3
link
/test istio-unit-tests-master

prow/integ-framework-local-presubmit-tests.sh
0244054438d8b95ec844ecbc11c8729197d7a6f3
link
/test integ-framework-local-presubmit-tests-master

prow/integ-pilot-local-presubmit-tests.sh
0244054438d8b95ec844ecbc11c8729197d7a6f3
link
/test integ-pilot-local-presubmit-tests-master

prow/integ-galley-local-presubmit-tests.sh
0244054438d8b95ec844ecbc11c8729197d7a6f3
link
/test integ-galley-local-presubmit-tests-master

prow/integ-security-local-presubmit-tests.sh
0244054438d8b95ec844ecbc11c8729197d7a6f3
link
/test integ-security-local-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

New changes are detected. LGTM label has been removed.

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: incfly, yangminzhu
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

security/OWNERS [incfly]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yangminzhu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
1a82f4b594fa80b187a775486a7359cc9a3b48f1
link
/test e2e-simpleTests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-simpleTests-master


Cannot git-add files under  cmd/cloud-api-adaptor

When I tries to stage changes to the files under cmd/cloud-api-adaptor with git add, I got the following error.
$ git add cmd/cloud-api-adaptor/main.go
The following paths are ignored by one of your .gitignore files:
cmd/cloud-api-adaptor
hint: Use -f if you really want to add them.
hint: Turn this message off by running
hint: "git config advice.addIgnoredFile false"

This is due to .gitignore has the following lines.
# Binaries
agent-protocol-forwarder
cloud-api-adaptor
kata-agent

@jtumber-ibm You mentioned that modifying .gitignore is not necessary at https://github.com/confidential-containers/cloud-api-adaptor/pull/329#discussion_r1060514354
But, I still encounter the issue. What did you exactly mean by the comment? Can we modify .gitignore something like this?
# Binaries
/agent-protocol-forwarder
/cloud-api-adaptor

@jtumber-ibm You mentioned that modifying .gitignore is not necessary at #329 (comment)
But, I still encounter the issue. What did you exactly mean by the comment? Can we modify .gitignore something like this?
# Binaries
/agent-protocol-forwarder
/cloud-api-adaptor

The above is the fix which works. I faced this issue when refactoring for aws provider and had used the same entry in gitignore - https://github.com/bpradipt/cloud-api-adaptor/commit/a2271250e32f68bf82e1eb0ad314ebefeb3a0c00


Make KWoC less stressful for mentors

If a mentor registers more than 2 projects, contact them and say "You might get stressed because of some low-quality patches, as we have seen in the past. Hence we request you to kindly submit at max 2 projects".

Instead of suggesting, "Choose a project, contact mentor and contribute", we should say "Choose a project, read our student's manual(link it). We strongly expect you to proceed after reading the manual and following the instructions written in it. Read the project's contributors' guideline. Find some issues and contribute."

When a mentor submits a project, ask them to set up "contributors' guideline" for their project and reference it from their README. If they don't have it, help them set up from the examples [1] [2].

Do not make mentor's email id public, a communication channel/forum should be the only way to contact them (like GSoC orgs). Personal emails are supposed to be ignored. If the mentor doesn't feel like setting up a forum and prefers personal emails, they can put their email id in the communication channel link. No big deal.

Request mentors to add a code of conduct to their repositories, which is mandatory to be read by every contributor of their repository. Even after a warning, if a student misbehaves, they can surely be banned from the repository. (This is perfectly fine and happens in organizations with very big impacts e.g. sympy)

Communicate to students more. Put up learning materials like https://www.learnitgirl.com/ -> Learning materials. Send it to them. Also, send them basic FAQs at the beginning, some of them are
Q: "How do I get started with a project?"
A: (to be elaborated) Set up the repository (See github guidelines) and use the project. Read their contributor's guidelines or a-link-to-template-contributor's-guidelines. (How about opensource.guide articles ? ) See the open issues and try to fix them. You can comment on the issue if you think you have searched the internet enough for solutions and read the related materials/documentation completely)

(Open for discussions)

All of this is great! But the main underlying issue is that most students are not at all wiling to even read a document. There have been many times, I have pointed out to a document and got only 10% rate of reading which is pretty sad. Sorry if I sound ranting, but this is the big issue and right now I have very little idea about how to solve it.

I agree with you @pranitbauva1997. That is a big problem. Even I read the GSoC student's manual while writing one for KWoC last year. But it turned out that I already knew a bunch of the things written inside it because of reading things from here and there (READMEs, forums, mentor's previous emails in the forum, emails from GSoC etc.)
Hence, instead of just putting up Manuals on the website, we need to put up good bits of the instructions all over the places.
The new generation of students seems to be heavily influenced by Quora (Pinging @djokester to get involved in the discussion). Maybe we can put up some FAQs there. Surprisingly new people tend to read Quora answers more and pdfs less.

@OrkoHunter This is a great idea. We can have a standard reply crafted and for all KWoC related Quora question, we will stick that along with the other words by someone who is actually writing the answer. What do you think @djokester?

To communicate this from next time on, a code of conduct post must be made on KOSS's blog as well, regardless of whether a Quora answer is put up or not.

Yes @kaustubhhiware, along with a blog, we can put a good referencable link for the Code of Conduct on the website itself.

What we can do is a few of us host Quota sessions every weekend a month or
two before KWoC. This enables us to get a wide range of questions. We can
choose wisely and answer those to the best of our abilities.
A second thing is that most of the students is not worth investing our
times upon. It's bad to say this as a mentor but I find a lot of students
to be a lot of talk and no work. They just never find a starting point.
They keep on pestering someone or the other but there is absolutely zero
output. I think this year's student evaluation will reflect that upon me as
a mentor.
On Dec 15, 2017 13:19, "Himanshu Mishra"<EMAIL_ADDRESS>wrote:

I agree with you @pranitbauva1997 https://github.com/pranitbauva1997.
That is a big problem. Even I read the GSoC student's manual while writing
one for KWoC last year. But it turned out that I already knew a bunch of
the things written inside it because of reading things from here and there
(READMEs, forums, mentor's previous emails in the forum, emails from GSoC
etc.)
Hence, instead of just putting up Manuals on the website, we need to put
up good bits of the instructions all over the places.
The new generation of students seems to be heavily influenced by Quora
(Pinging @djokester https://github.com/djokester to get involved in the
discussion). Maybe we can put up some FAQs there. Surprisingly new people
tend to read Quora answers more and pdfs less.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kossiitkgp/kwoc-2017/issues/143#issuecomment-351937025,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ARHj0vYCzRBFtq19aTHEqI2fat1P0dRPks5tAiSFgaJpZM4RDHcz
.

I found @djokester's idea of a Quora session partially effective. Despite the idea being attractive, I noticed that not a lot of people ask questions in these sessions which are related(see this answer written by @djokester himself). Though there is a topic of KWoC on Quora, not a lot of people are reading answers given by some of the mentors

See the point here is completely different. Kindly do not bring up answers
that do not reflect what I want to.point out.
I am known on Quota for two reasons. IIT Kharagpur and GSoC.
So any session relayed to the two of these will be successful. I received
more than 12 questions and all of them related to KWoC when I hosted a
session on KWoC. I A2Aed them to @OrkoHunter.
I have no issues with Open Source and JEE related topics. I ranted in that
question because my followers don't let me expand my topics of expertise.
On Dec 15, 2017 17:13, "Dhruv Apte"<EMAIL_ADDRESS>wrote:

I found @djokester https://github.com/djokester's idea of a Quora
session partially effective. Despite the idea being attractive, I noticed
that not a lot of people ask questions in these sessions which are
related(see this answer
https://www.quora.com/How-do-you-feel-when-you-“take-questions”-on-Quora/answer/Samriddhi-Sinha?srid=CnjP
written by @djokester https://github.com/djokester himself). Though
there is a topic of KWoC on Quora, not a lot of people are reading answers
given by some of the mentors
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kossiitkgp/kwoc-2017/issues/143#issuecomment-351986057,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ARHj0ieQ-Krov6rQxvjXEC_vjlMbzg-8ks5tAltxgaJpZM4RDHcz
.

 What I wanted to point out is that people might not ask specifics as related to the session. :smile: . As you mentioned about the questions, we can, um possibly use those answer links as a 'guide' instead of the original PDF ones. This might generate more interest among the contributors instead.

@the-ethan-hunt If you read the first comment on this issue mentioning Quora, it is not about the type of questions people ask, it is that new people read Quora with more trust and attention. Hence it is irrelevant to what people would ask because we already know most of the questions. Hence we ourselves will put our frequently asked questions and get it answered over there.
New people joining the thread: Please read the points mentioned above carefully and comment your criticism with brevity.

I don't think you should cap mentor projects at 2. I submitted 3 programming projects (Node.js) and 1 non-programming project. (awesome-social-science) I recd a LOT of patches on the non-programming one. If asked to choose any two, I would probably not have chosen the non-programming one.

I find a lot of students to be a lot of talk and no work. They just never find a starting point.

True also. Several people who mailed me the standard "please tell me how to contribute in detail" never did anything. It's not a bad thing, it's not annoying, it's not unexpected. But it reflects badly on the program. If I have the chance to register as a mentor again, I won't register any programming projects at all.
Everything else I wanted to say have already been covered. @OrkoHunter thanks for spending time on this, I am sure this program will get better each year :+1:


Faulty error message for Wifi registration fixed

hacktoberfest close #78
The error message during wi-fi registration has been fixed.


Exapend/collapse group bug

When I extend the first group and then I collapse it the second group is duplicated like in the picture.
Has anyone ever had this bug? And could help me?
Thanks

I am using the same library and not able to reproduce your bug. Please check your code, you might be doing something wrong

It's ok. I found the problem but forgot to close the issue.
Le 25 juil. 2017 15:55, "Raj Suvariya"<EMAIL_ADDRESS>a écrit :

I am using the same library and not able to reproduce your bug. Please
check your code, you might be doing something wrong
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/thoughtbot/expandable-recycler-view/issues/82#issuecomment-317745071,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIqUwGTVkwulhZ6dF7sJzVHlJKWmgcYZks5sRfPOgaJpZM4ONI9Q
.

Nice that you shared your resolution, thank you for the contribution.

@ValBrunhes Can you provide the way how you fixed this problem and what was the problem?


only run doctests on numpy 1.13

This is an alternative to #344 where I attempt to avoid running the doctests except in a single case on Travis which is currently set to use numpy 1.13.
Alternatively, we can update the docstrings to match 1.14 and use that version for the doctests.

Deleting pywt/tests/test_doc.py should fix things I think

Thanks @rgommers.  somehow I had missed this comment at the time.  I didn't even realize we had a test_doc.py!  #344 is succeeding now too.  Can you merge either that PR or this one (once CI completes) and close the other?  I don't have a strong preference either way.  I just want to get CI working properly again for other pending PRs.

doctests are still being run for some reason.  I am going to close this in favor as #344 which uses legacy printing on numpy 1.14 so that the doctests pass.


Mlagents upgrade

PR Description
This is the python part of the mlagents upgrade. It is one of three PRs that should be reviewed and merged together. See details at https://github.com/Kinds-of-Intelligence-CFI/animal-ai-unity/pull/44

This PR needs to be more informative. What are the changes and how will they affect our implementation of mlagents?:
https://github.com/Unity-Technologies/ml-agents/releases/tag/release_22.
Edit the PR description and explain the changes in detail (there are important changes/additions such as "Added no_graphics support", "Bumped numpy version to >=1.23.5,<1.24.0", "The minimum supported Unity version was updated to 2023.2.", etc. These changes really need to be detailed out and explained how they would change the functionality of AAI python side of things (and potentially unity side too).
We're only using the ml-agents-env sub package for your reference.

This PR needs to be more informative. What are the changes and how will they affect our implementation of mlagents for AAI? (i.e. new functionality, bug fixes, changes, potential conflicts, etc):

I don't agree; this would mean for every dependency version bump developers would have to duplicate the changelog into the PR description. Where I think it is useful to include details like this in a dependency version bump PR is if the version is being bumped to make use of a particular feature/big fix. I see this PR instead just as a "the version hasn't been updated in ages and so desperately needs doing" PR. I added another sentence to the main PR to illustrate this a bit more.

These changes really need to be detailed out and explained how they would change the functionality of AAI python side of things (and potentially unity side too).

Hopefully not at all*, except we will need a major version bump for this change since it's  breaking (because of the python version bump).
I am a bit suspicious that the TOML isn't going to play nice - I think the dockerising the E2E tests stuff you're working on will be really useful for unearthing things like that.

the only customer facing change I can see is that annoyingly the camera outputs are transposed in the new version. This would affect users who are e.g. trying to run a pretrained agent across the major version bump this change needs - but they shouldn't be doing that anyway

As this PR is mainly focused on upgrading the mlagents version (the version we are using works fine, we need to evaluate and justify the benefits of upgrading to the latest version). (For example) You mentioned the camera outputs are transposed in 3.0.0, what's the implication here, how will this affect AAI? People who use AAI and are not technical need to know (myself and the other members will know what this means but it's for other current/future members to see what the change implies). Numpy version bump is also a massive one as we've had major difficulties with dependency-related conflicts in the past, mainly to do with numpy being incompatible with other packages such as PyTorch.
You need to detail these out here along with the other changes that will come along as we need to understand how all of this will affect the use of mlagents for AAI. Please also use the PR template in the repo, it's there for a reason. This PR description is unacceptable for a major (breaking) change for this repo. It's not a simple change you're working on (i.e. a patch) which would be OK with this description but this isn't the case here.

PR Description
This is the python part of the mlagents upgrade. It is one of three PRs that should be reviewed and merged together. See details at Kinds-of-Intelligence-CFI/animal-ai-unity#44

This PR needs to be more informative. What are the changes and how will they affect our implementation of mlagents for AAI? (i.e. new functionality, bug fixes, changes, potential conflicts, etc):
I don't agree; this would mean for every dependency version bump developers would have to duplicate the changelog into the PR description. Where I think it is useful to include details like this in a dependency version bump PR is if the version is being bumped to make use of a particular feature/big fix. I see this PR instead just as a "the version hasn't been updated in ages and so desperately needs doing" PR. I added another sentence to the main PR to illustrate this a bit more.

I strongly disagree with your statement:

I see this PR instead just as a "the version hasn't been updated in ages and so desperately needs doing" PR.
Mlagents was not updated in ages as there was nothing to update to for a while (mlagents is deprecated). The latest version came online last October and the newest a few weeks ago. We shouldnt just upgrade mlagents just for the sake of it. We need to have reasons as the version were using works and is not broken. See my issue: https://github.com/Kinds-of-Intelligence-CFI/animal-ai-python/issues/5. I've specifically mentioned to evaluate mlagents first before upgrading. Note that this issue is for mlagents 3.0.0.exp.1.

Again, this PR should be a standalone and have its own appropriate and detailed PR. Currently, it's not and it can't be merged.

the version we are using works fine, we need to evaluate and justify the benefits of upgrading to the latest version

In general we should try to keep dependencies as up to date as possible. This version was trapping on Python 3.9, so I don't agree that it works fine.

You mentioned the camera outputs are transposed in 3.0.0, what's the implication here, how will this affect AAI?

I can't think of any significant impacts from the transposition - are there any on your mind that you're worried about?

we've had major difficulties with dependency-related conflicts in the past, mainly to do with numpy being incompatible with other packages such as PyTorch

Being stuck on Python 3.9 probably didn't help, so hopefully this bump will help smooth things out a bit dependency-wise. Since I'm doing a fresh build to bump the unity editor version again, I'll make a fresh pyenv to double check for any version conflict issues.

Please also use the PR template in the repo, it's there for a reason. This PR description is unacceptable for a major (breaking) change for this repo.

I'm sorry that you find the PR description I wrote unacceptable. Given that the change had to be made across three repos, I think it's reasonable to have one PR carry the main detail of the change and the others to reference it (other developers I've worked with didn't seem to take issue with this). Perhaps you could take a look at the description of the unity PR where I included the detail, and draft a suggestion of what you would have liked to see here, so that I have a better understanding of what you're looking for?

We shouldnt just upgrade mlagents just for the sake of it. We need to have reasons as the version were using works and is not broken.

Users were having issues with being pinned to an old version of Python. These kinds of issues tend to accumulate when dependencies aren't updated for a while.

Again, this PR should be a standalone and have its own appropriate and detailed PR.

I don't think it can be standalone, because upgrading mlagents on the python side will break the integration with mlagents on the unity side. Do you know a way we could make these changes independently?

the version we are using works fine, we need to evaluate and justify the benefits of upgrading to the latest version

In general we should try to keep dependencies as up to date as possible. This version was trapping on Python 3.9, so I don't agree that it works fine.

Python 3.9 is still used across projects. But, of course it was a limitation so I agree on that.

You mentioned the camera outputs are transposed in 3.0.0, what's the implication here, how will this affect AAI?

I can't think of any significant impacts from the transposition - are there any on your mind that you're worried about?

None that come to mind but it's still a topic to discuss. For example, how would this affect training instances? Or do we simple need to update the documentation to reflect this new change so users don't get surprised?

we've had major difficulties with dependency-related conflicts in the past, mainly to do with numpy being incompatible with other packages such as PyTorch

Being stuck on Python 3.9 probably didn't help, so hopefully this bump will help smooth things out a bit dependency-wise. Since I'm doing a fresh build to bump the unity editor version again, I'll make a fresh pyenv to double check for any version conflict issues.

The conflicts were not related to 3.9 per se, but the way mlagents configured specific dependency versions. But, the python bump means we need to use at least 3.10, which helps with maintenance. Do we need to update the tests in this repo to use 3.10?

Please also use the PR template in the repo, it's there for a reason. This PR description is unacceptable for a major (breaking) change for this repo.

I'm sorry that you find the PR description I wrote unacceptable. Given that the change had to be made across three repos, I think it's reasonable to have one PR carry the main detail of the change and the others to reference it (other developers I've worked with didn't seem to take issue with this). Perhaps you could take a look at the description of the unity PR where I included the detail, and draft a suggestion of what you would have liked to see here, so that I have a better understanding of what you're looking for?

Again, this PR should be a standalone and have its own appropriate and detailed PR.

I don't think it can be standalone, because upgrading mlagents on the python side will break the integration with mlagents on the unity side. Do you know a way we could make these changes independently?

No harm done. My main point here is that this change is breaking, and would require a standalone PR (by standalone, I mean that it should have it's own weight), and not just be treated as a simple PR, with a simple description. We need to understand what is being changed here. I've stated what is missing in the PR. Kindly provide these details.

We shouldnt just upgrade mlagents just for the sake of it. We need to have reasons as the version were using works and is not broken.

Users were having issues with being pinned to an old version of Python. These kinds of issues tend to accumulate when dependencies aren't updated for a while.

I was unaware that users were having trouble with 3.9. Anyone in the team and/or external users? What were the issues?


entering large data in roms

Fixes # 627 (partial)
Describe the changes you have made in this PR -
I have added a dblclick event function to enter  data directly in rom and eeprom in a copy and paste way.
added functions in modules.js,eeprom.js
Screenshots of the changes (If any) -

Coverage decreased (-0.4%) to 83.902% when pulling da3a15851ae876565247739d3c059bde96790d21 on jha11aditya:rom_paste into e39c964038192434c8e08e941410db1d1979f1b3 on CircuitVerse:master.

Implemented it in #1990, thanks!


Terminal double-spacing everything

After updating the package a couple weeks ago, my terminal has been double spacing everything. I've been using this package for a good year now and it was always fine before that. No idea what happened, but it gets quite annoying trying to read output with spacing like this:

Any ideas?

Whats your atom version? Have you tried uninstalling and reinstalling the terminal?

update to atom 1.28.2 thats all I can suggest, I dont have or can duplicate that issue you describe.
If after you updated you still experience the issue, and have legacy console enabled as described in https://github.com/platformio/platformio-atom-ide-terminal/pull/575/files I suggest you try to disable it.
If that also fails, you should start  by disabling non core packages one by one testing in between and close reopen a terminal to see if issue persists, until the issue is gone, or you run out of extrenal extension to disable,
If the issue still persists, youre SOL. As I said I cant duplicate your issue.

AH yes, you can also downgrade or force install platformio-ide-terminal 2.8.2 IF AND ONLY you want to keep Atom 1.27.2

Upgrading Atom to 1.28.2, resetting it to factory defaults as described in the debugging docs, and re-installing packages did the trick.
Thanks for the assistance!

YW. :smile:

Turns out the issue is being caused by the city-lights-UI theme - but even un-installing the theme doesn't fix it, I had uninstalled it and all other packages before going ahead with the factory reset. So when I was re-installing packages one-by-one and checking the terminal after each one, I found it was the culprit. And then of course I had to reset all over again.  😆

There is a PR adding support for that theme, I wonder if that fixes it.
see https://github.com/platformio/platformio-atom-ide-terminal/pull/572
@ivankravets PR's waiting for merge please review.


feat: add vault_license_reporting var to opt out of automated license utilization reporting

This adds a variable vault_license_reporting to allow enterprise customers to opt out of the automated license utilization reporting.
The default for the variable is false, which means that no config changes are made and the license utilization is reported to HashiCorp automatically.
If the user sets the value to true, the license reporting is disabled in the main configuration file with the reporting stanza:
reporting {
    license {
        enabled = false
   }
}

Setting the value to true on Vault releases which do not yet support the reporting feature results in a warning in the Vault server log.

I just noticed that we could probably achieve the same configuration by using the vault_custom_configuration value. However, adding the feature flag for this opt out is more explicit.


[CARBONDATA-3984] Compaction on table having range column after altering datatype from string to long string fails.

Why is this PR needed?
When dataType of a String column which is also provided as range column in table properties is altered to longStringColumn. It throws following error while performing compaction on the table.
VARCHAR not supported for the filter expression;
What changes were proposed in this PR?
Added condition for VARCHAR datatype in all conditional expressions.
Does this PR introduce any user interface change?

No

Is any new testcase added?

No

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4055/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/2317/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4067/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/2328/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4068/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/2329/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4076/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/2336/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/2346/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4086/

@Karan980 the PR title shouldn't be so long, give a small but descriptive title and details you can explain in PR description.

@Karan980 the PR title shouldn't be so long, give a small but descriptive title and details you can explain in PR description.

Done

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4092/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/2351/

LGTM