Clarify what blank() is for or remove it entirely

If we want to just turn the screen on and off we could probably do that at the hardware level.  For a buffer backed game I"m not super sure what the advantage of blanking the screen is with non blank data in the buffer.  I think blank() could easily be confused with clearDisplay().

I think I'd suggest replacing blank() with screenOn() and screenOff() or similar, so the function - and how it's different than clearDisplay() is clear.

This makes more sense in a low-level library (#32).  I pulled it into ArduboyCore since when there is ONLY the screen (no buffer) it loses it's ambiguity.  Blank means blank.  I think perhaps if we keep it we should consider just mapping it to clearDisplay()... so whichever one you call results in blanking the buffer when it's next pushed to the display.

Ping.

I think renaming it is a good idea unless there is a convention to use blank() that I'm not aware of. Keeping blank(), mapping it, and depreciating it now with removal in the next major version would be a good idea.

I think we rename as follows:
clearDisplay -> clearBuffer()
blank -> blankDisplay()

And deprecate the old functions.  Thoughts?

Renamed clearDisplay to clear() and left blank alone since really it's a hardware function in core.  The docs already explain the difference.  Save the rest of this battle for another day.
Deprecated clearDisplay().  PR done.


[WIP]remove AWS-specfic default user agent

Current default user agent string is AWS specific. So the customization
is moved to AWS JS SDK.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kstich There won't be a user agent header in the request. The default user agent removed in this change is only the dependency. Currently the middleware that injecting the user agent to the HTTP request lives in the AWS-specific customization. We should either move all the user agent customization to the AWS customization or move the middleware customization to this middleware. I think the previous option makes more sense because it assumes HTTP requests


New package: ExperienceReplay v0.1.0

Registering package: ExperienceReplay
Repository: https://github.com/p-w-rs/ExperienceReplay.jl
Created by: @p-w-rs
Version: v0.1.0
Commit: 71622d81c2d0a716e1d1450c66bd70014e56b2ae
Git reference: HEAD
Description: An implementation of an experience replay buffer for use in deep rl

As the bot message says, the problem is in https://github.com/p-w-rs/ExperienceReplay.jl/blob/71622d81c2d0a716e1d1450c66bd70014e56b2ae/Project.toml#L10
It is not allowed to declare compatibility with Julia 2.0 (which will not exist for the foreseeable future, and if it ever does exist, your package is almost certainly not going to be compatible with it)
I would also very strongly recommend that you add some tests before registration.
[noblock]


Fix missing db_time field

Not sure how this got past tests for the original pull request #225, but since the filter is on an annotation, the filter field must match the annotation field.

Oh wow, I'm a bit baffled too


Dataset MovingMNIST: split=None returns test dataset

🐛 Describe the bug
I've found a bug in the code for torchvision's MovingMNIST dataset, which causes only the test dataset to be returned when split=None. According to the documentation, when split is set to None, the entire dataset should be returned. However, this is not currently happening.
https://github.com/pytorch/vision/blob/b403bfc771e0caf31efd06d43860b09004f4ac61/torchvision/datasets/moving_mnist.py#L13-L19
I've tested this with the following code:
from torchvision import datasets
import torch

dataset = datasets.MovingMNIST(root="data", download=True)
dataset[0].size() # returns torch.Size([10, 1, 64, 64]), but I expected torch.Size([20, 1, 64, 64])

I believe the bug is caused by lines 58-62 in the code, which handle None and test splits together:
https://github.com/pytorch/vision/blob/b403bfc771e0caf31efd06d43860b09004f4ac61/torchvision/datasets/moving_mnist.py#L42-L62
To fix this, I propose the following two changes:

Separate the handling of None and test splits in the code.
Only process lines 46-50 when split is not None.

Reference issue: #6981
I'm happy to help on this issue, please assign to me on this one.
Versions
PyTorch version: 2.0.0
Is debug build: False
CUDA used to build PyTorch: None
ROCM used to build PyTorch: N/A
OS: macOS 13.2.1 (arm64)
GCC version: Could not collect
Clang version: 14.0.0 (clang-14<IP_ADDRESS>)
CMake version: Could not collect
Libc version: N/A
Python version: 3.10.9 | packaged by conda-forge | (main, Feb  2 2023, 20:26:08) [Clang 14.0.6 ] (64-bit runtime)
Python platform: macOS-13.2.1-arm64-arm-64bit
Is CUDA available: False
CUDA runtime version: No CUDA
CUDA_MODULE_LOADING set to: N/A
GPU models and configuration: No CUDA
Nvidia driver version: No CUDA
cuDNN version: No CUDA
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True
CPU:
Apple M1 Pro
Versions of relevant libraries:
[pip3] mypy-extensions==1.0.0
[pip3] numpy==1.24.2
[pip3] torch==2.0.0
[pip3] torch-tb-profiler==0.4.1
[pip3] torchvision==0.15.1
[conda] numpy                     1.24.2          py310h3d2048e_0    conda-forge
[conda] pytorch                   2.0.0                  py3.10_0    pytorch
[conda] torch                     2.0.0                    pypi_0    pypi
[conda] torch-tb-profiler         0.4.1                    pypi_0    pypi
[conda] torchvision               0.15.1                   pypi_0    pypi
cc @pmeier

Thanks for the detailed report @Shu-Wan! This indeed seems wrong. IIUC, it should be enough to replace the else branch with an elif:
diff --git a/torchvision/datasets/moving_mnist.py b/torchvision/datasets/moving_mnist.py
index afff0bfa3b..ac5a2b1503 100644
--- a/torchvision/datasets/moving_mnist.py
+++ b/torchvision/datasets/moving_mnist.py
@@ -58,7 +58,7 @@ class MovingMNIST(VisionDataset):
         data = torch.from_numpy(np.load(os.path.join(self._base_folder, self._filename)))
         if self.split == "train":
             data = data[: self.split_ratio]
-        else:
+        elif self.split == "test":
             data = data[self.split_ratio :]
         self.data = data.transpose(0, 1).unsqueeze(2).contiguous()

Wondering why our tests missed this.

I'm happy to help on this issue, please assign to me on this one.

Go for it!

Welp, that was not smart:
https://github.com/pytorch/vision/blob/f0a1df315db3c0fdec3d638895f6173809030bba/test/test_datasets.py#L1520-L1529
We should assert there that the first dimension has 20 elements for split=None.

Let's also change
https://github.com/pytorch/vision/blob/f0a1df315db3c0fdec3d638895f6173809030bba/test/test_datasets.py#L1510
to a different number like 5 or whatever to avoid confusing the number of samples with the number of frames.

@Shu-Wan we are preparing for the 0.15.2 bug fix release. Since MovingMNIST was released with 0.15, it would be good to get this fix in. Do you happen to have time to send patch soon? If not, are you ok with me taking over so we can get it released?

Hi Philip,
I will take care of this today. It should be an easy fix.
On Mar 22, 2023, at 4:44 AM, Philip Meier @.***> wrote:

@Shu-Wanhttps://github.com/Shu-Wan we are preparing for the 0.15.2 bug fix release. Since MovingMNIST was released with 0.15, it would be good to get this fix in. Do you happen to have time to send patch soon? If not, are you ok with me taking over so we can get it released?
—
Reply to this email directly, view it on GitHubhttps://github.com/pytorch/vision/issues/7439#issuecomment-1479408790, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADZWW7PU6LFZRMQWOKOZ6YTW5LQZJANCNFSM6AAAAAAWDFFL5U.
You are receiving this because you were mentioned.Message ID: @.***>


table designer error on Ledger table

Version: 1.40.1
Commit: 3a32679ab590c1023ab4de6f191769e7e127d25b
Date: 2022-11-22T18:22:25.529Z
VS Code: 1.67.0
Electron: 17.4.11
Chromium: 98.0.4758.141
Node.js: 16.13.0
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 22.2.0
Steps to Reproduce:

Create Ledger table in database via T-SQL (script below)
Try to open table in Designer

Does this issue occur when all extensions are disabled?: Yes/No

   at Microsoft.SqlTools.ServiceLayer.TableDesigner.EnumUtil`1.GetName(T enumValue) in D:\a\_work\1\s\src\Microsoft.SqlTools.ServiceLayer\TableDesigner\EnumUtils.cs:line 34
   at Microsoft.SqlTools.ServiceLayer.TableDesigner.TableDesignerService.GetTableViewModel(TableInfo tableInfo) in D:\a\_work\1\s\src\Microsoft.SqlTools.ServiceLayer\TableDesigner\TableDesignerService.cs:line 922
   at Microsoft.SqlTools.ServiceLayer.TableDesigner.TableDesignerService.<>c__DisplayClass18_0.<<HandleInitializeTableDesignerRequest>b__0>d.MoveNext() in D:\a\_work\1\s\src\Microsoft.SqlTools.ServiceLayer\TableDesigner\TableDesignerService.cs:line 99
--- End of stack trace from previous location ---
   at Microsoft.SqlTools.ServiceLayer.TableDesigner.TableDesignerService.<>c__DisplayClass17_0`1.<<HandleRequest>b__0>d.MoveNext() in D:\a\_work\1\s\src\Microsoft.SqlTools.ServiceLayer\TableDesigner\TableDesignerService.cs:line 85

@caohai as per the discussion with the ledger table team, we need to be able to open the table designer and it should be treated just like a normal table, new ledger features will not be exposed in table designer.

@caohai as per the discussion with the ledger table team, we need to be able to open the table designer and it should be treated just like a normal table, new ledger features will not be exposed in table designer.

@alanrenmsft  sounds good I'll take a look this week.

@caohai any reason not to close this issue?


Can it be used?

Is this ready to be used? If so, how would I go about using it?

Figured it out, leaving this for reference.
https://crates.io/crates/sourceview
extern crate sourceview;
use sourceview::View;

Helped a lot!


Issue with documentation about how to use plugins

Part 1
When using plugins with marko-starter it throws an error:
TypeError: Cannot assign to read only property 'name' of function.
Click to expand full error
[marko-starter plugins] Installed plugin: lasso
(node:24324) UnhandledPromiseRejectionWarning: TypeError: Cannot assign to read only property 'name' of function 'function (lasso, config) {

    var sassHandler = {
        properties: {
            path: 'string',
         ...<omitted>...
}'
    at plugins.forEach (/home/max/Development/prowearegenkicom/auth/node_modules/marko-starter/src/plugin-manager.js:39:17)
    at Array.forEach (<anonymous>)
    at Object.exports.installPlugins (/home/max/Development/prowearegenkicom/auth/node_modules/marko-starter/src/plugin-manager.js:32:11)
    at beforeStartPromise.then (/home/max/Development/prowearegenkicom/auth/node_modules/marko-starter/index.js:75:25)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:160:7)
    at Function.Module.runMain (module.js:703:11)
    at startup (bootstrap_node.js:194:16)
    at bootstrap_node.js:618:3
(node:24324) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:24324) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

To reproduce use a project.js like:
module.exports = require("marko-starter").projectConfig({
  plugins: [
    'lasso-sass',
  ],
});

with package versions:
"lasso-sass": "3.0.0",
"marko": "4.7.4",
"marko-starter": "2.0.2",

Part 2
If instead you use a project.js like:
module.exports = require("marko-starter").projectConfig({
  plugins: [
    {
      plugin: 'lasso-sass',
    },
  ],
});

You'll get a different error:
TypeError: plugin.install is not a function
Click to expand full error
[marko-starter plugins] Installed plugin: lasso
(node:25444) UnhandledPromiseRejectionWarning: TypeError: plugin.install is not a function
    at plugins.forEach (/home/max/Development/prowearegenkicom/auth/node_modules/marko-starter/src/plugin-manager.js:41:12)
    at Array.forEach (<anonymous>)
    at Object.exports.installPlugins (/home/max/Development/prowearegenkicom/auth/node_modules/marko-starter/src/plugin-manager.js:32:11)
    at beforeStartPromise.then (/home/max/Development/prowearegenkicom/auth/node_modules/marko-starter/index.js:75:25)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:160:7)
    at Function.Module.runMain (module.js:703:11)
    at startup (bootstrap_node.js:194:16)
    at bootstrap_node.js:618:3
(node:25444) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:25444) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

The debugging experience with lasso/marko has been frustrating to say the least.

Following up on this, the correct way to specify plugins are to use a project.js like:
module.exports = require("marko-starter").projectConfig({
  lassoConfig: {
    plugins: [
      "lasso-marko",
      "lasso-sass",
    ],
  },
});

From: https://github.com/marko-js/markojs-website/blob/master/project.js
So the real issue here is the lack of correct documentation. I still have no idea what the top level plugins is for.

@MaxMilton Sorry for the confusion. We should definitely update the documentation to reflect this. Would be interested in working on updating the docs? Thanks!

Sure, I'll have a go at updating the readme when I have some free time :)


Provide a detailed documentation of operator-sdk CLI

Currently, It might not be clear on what each operator-sdk CLI command does and when it should be used. Some of the commands are briefly explained in the user_guide but not all.
We should have a detailed doc sdk-cli-reference.md to explain operator-sdk CLI usage.

Sub Tasks:
-[ ] provide detailed example for operator-sdk up local command.

/dibs


[AUTOMATED] Update Version Pinning for Terraform to support 0.13 (#60)

What

Update Version Pinning for Terraform to support 0.13

Why

This is a relatively minor update that the CloudPosse module already likely supports.
This allows module consumers to not individually update our Terraform module to support Terraform 0.13.

what

Describe high-level what changed as a result of these commits (i.e. in plain-english, what do these changes mean?)
Use bullet points to be concise and to the point.

why

Provide the justifications for the changes (e.g. business case).
Describe why these changes were made (e.g. why do these commits fix the problem?)
Use bullet points to be concise and to the point.

references

Link to any supporting github issues or helpful documentation to add some context (e.g. stackoverflow).
Use closes #123, if this PR closes a GitHub issue #123

merge from upstream


fix(btc): wrong direction when click the input address

https://github.com/Magickbase/ckb-explorer-public-issues/issues/634

Verified


Abandoned gem?

Is this gem still active?
The old pgbackups heroku addon has been deprecated so heroku_cloud_backup doesn't work anymore.

I'm not currently using heroku anymore, so I'd maybe recommend this gem as a replacement: https://github.com/kjohnston/pgbackups-archive

@kamui thank you for the response. Unfortunately, pgbackups-archive doesn't support uploading to Google Storage.


Updated to work with current Timber version

Your Tree didn't work with the current version. Seems like some stuff changed.

Thanks for PR!
timber version in build.gradle should be updated, and every v/d/i/w/e methods are not necessary anymore.
I'll take over these tasks. :)

Sorry for being late, v1.0.0 has been released!

(Note that class and package names has been changed.)

No worries, thanks for the lib.


Think what to do with communicator

communicator should hold pointer to vector of clients because they will update on appstate while new players (or second player) joining game

We really don't need communicator now. Can we remove it?


Raise error when trying to create a wallet with an already existing name

What this PR resolves:
Changes proposed in this PR:

Version:
Fixes: #

@ahussein moved


added Null value check in vectorString of Github Scan

Github Scan Parser fails if the vectorString is null. Github API might return null value for vectorString if it's not available. Added a check to only parse if vectorString is not None

@L3m0nb4tt3ry I was hoping to push this directly into a hot fix, but there is a lot of extra baggage on the commit logs after rebasing. Will redo this PR based against another branch and git credit to you in the title


Tests are failing

See https://github.com/brainglobe/cellfinder-napari/actions/runs/5312974479. Something to do with multiprocessing.

This should therefore be fixed in cellfinder_core I think.


Update to latest babel

Update to the latest version of babel and related packages.

Fix any deprecations
Take advantage of any new features that have been added

Fixed by #60


JSON target types only accept strings or numbers, found: {"latitude":null,"longitude":null}

Hi Prisma Team! My Prisma Client just crashed. This is the report:
Versions

Name
Version

Node
v16.20.0

OS
windows

Prisma Client
4.14.1

Query Engine
d9a4c5988f480fa576d43970d5a23641aa77bc9c

Database
postgresql

Logs
prisma:tryLoadEnv Environment variables loaded from E:\Mobile app\Bazaar\.env
prisma:client checkPlatformCaching:postinstall
prisma:client checkPlatformCaching:ciName
prisma:tryLoadEnv Environment variables loaded from E:\Mobile app\Bazaar\.env
prisma:client dirname E:\Mobile app\Bazaar\node_modules\.prisma\client
prisma:client relativePath ..\..\..\prisma
prisma:client cwd E:\Mobile app\Bazaar\prisma
prisma:client protocol graphql
prisma:client clientVersion 4.14.1
prisma:client clientEngineType library
prisma:client:libraryEngine internalSetup
prisma:client:libraryEngine:loader Searching for Query Engine Library in E:\Mobile app\Bazaar\node_modules\.prisma\client
prisma:client:libraryEngine:loader loadEngine using E:\Mobile app\Bazaar\node_modules\.prisma\client\query_engine-windows.dll.node
prisma:client:libraryEngine library starting
prisma:client:libraryEngine library started
prisma:client:libraryEngine sending request, this.libraryStarted: true

Client Snippet
export const fetchData= async (req: Request, res: Response) => {
  try {
    const items = await prisma.cattle.findMany({
      where: {
        location: {
          gte: {
            latitude: 12.34,
            longitude: 56.78,
          },
          lte: {
            latitude: 90.12,
            longitude: 180.34,
          },
        },
      },
    });

...reso logic
  } catch (error: any) {
    ...throw logic
  }
};

Schema
model test{
  id    Int     @id @default(autoincrement())

location Json
  createdAt  DateTime           @default(now())
  updatedAt  DateTime?          @updatedAt
}

Prisma Engine Query
 const items = await prisma.test.findMany({
      where: {
        location: {
          gte: {
            latitude: 12.34,
            longitude: 56.78,
          },
          lte: {
            latitude: 90.12,
            longitude: 180.34,
          },
        },
      }
      ,
    });

Hey @i-am-dev-Siddhesh thanks for the report. Would you mind trying on the latest version? Thanks.

(Possibly related issue/domain in the past https://github.com/prisma/prisma/issues/10836)


Bluetooth: Controller: Missing dependency for BT_CTLR_CENTRAL_ISO and BT_CTLR_PERIPHERAL_ISO when !BT_LL_SW_SPLIT

Describe the bug
Both BT_CTLR_CENTRAL_ISO and BT_CTLR_PERIPHERAL_ISO can be enabled without BT_CONN is enabled, which can cause build errors.
To Reproduce
Steps to reproduce the behavior:

Without enabling BT_CONN (e.g. do not enable BT_CENTRAL or BT_PERIPHERAL), enable BT_LL_SW_SPLIT and BT_CTLR_CENTRAL_ISO or BT_CTLR_PERIPHERAL_ISO.
make
See error

Expected behavior
Expect the build system to ignore the BT_CTLR_CENTRAL_ISO=y or BT_CTLR_PERIPHERAL_ISO=y and give a warning that it could not be applied when BT_LL_SW_SPLIT=y.
Impact
Annoyance
Logs and console output
N/A
Environment (please complete the following information):

Commit SHA or Version used: 33c253c813d8cc56209ce0b572e127cd6eaa941b

Additional context
N/A

We use the follow construct:
config BT_CTLR_CENTRAL_ISO
	bool "LE Connected Isochronous Stream Central" if !BT_LL_SW_SPLIT
	depends on BT_CTLR_CENTRAL_ISO_SUPPORT && BT_CENTRAL
	default y if BT_ISO_CENTRAL
	help
	  Enable support for Bluetooth 5.2 LE Connected Isochronous Stream
	  Central role in the Controller.

config BT_CTLR_CENTRAL_ISO
	bool "LE Connected Isochronous Stream Central (Split Link Layer) [EXPERIMENTAL]" if BT_LL_SW_SPLIT
	select BT_CTLR_SET_HOST_FEATURE
	select EXPERIMENTAL if BT_LL_SW_SPLIT

config BT_CTLR_PERIPHERAL_ISO
	bool "LE Connected Isochronous Stream Peripheral" if !BT_LL_SW_SPLIT
	depends on BT_CTLR_PERIPHERAL_ISO_SUPPORT && BT_PERIPHERAL
	default y if BT_ISO_PERIPHERAL
	help
	  Enable support for Bluetooth 5.2 LE Connected Isochronous Stream
	  Peripheral role in the Controller.

config BT_CTLR_PERIPHERAL_ISO
	bool "LE Connected Isochronous Stream Peripheral (Split Link Layer) [EXPERIMENTAL]" if BT_LL_SW_SPLIT
	select BT_CTLR_SET_HOST_FEATURE
	select EXPERIMENTAL if BT_LL_SW_SPLIT

This leads to the depends on being OR-ed, as seen in the menuconfig 's help:
ame: BT_CTLR_CENTRAL_ISO
Prompt: LE Connected Isochronous Stream Central
Prompt: LE Connected Isochronous Stream Central (Split Link Layer) [EXPERIMENTAL]
Type: bool
Value: y

Help:

  Enable support for Bluetooth 5.2 LE Connected Isochronous Stream
  Central role in the Controller.

Direct dependencies (=y):
     BT_CTLR_CENTRAL_ISO_SUPPORT(=y) && BT_CENTRAL(=y) && BT_CTLR(=y) && BT_HCI(=y) && BT(=y)  (=y)
  || BT_CTLR(=y) && BT_HCI(=y) && BT(=y)  (=y)

Default:
  - y
    Condition (=y):
       BT_ISO_CENTRAL(=y)

Possible solution is to duplicate the depends on BT_CTLR_PERIPHERAL_ISO_SUPPORT && BT_PERIPHERAL  for BT_LL_SW_SPLIT = y

@cvinayak would it be time to remove the experimental definitions?

@cvinayak would it be time to remove the experimental definitions?

No, upstream implementation is not feature complete nor fully conformance tested for ISO features.


Weird format of returned NameID object

The Subject NameID we get back from FKIS has a weird format: "C=DK,O=Pølsevognen,CN=Hans Jensen,Serial=1234" which is difficult to translate into a proper user object.

When we get all attributes we will probably get the correct data. Dependent on #65.

This is not a Bug, this is simply the formatting of the X509SubjectName attribute as returned by Context Handler. When we can properly parse and map this to the user object (issue #48 ) this will not be an issue anymore.


Host list flag to only list children of group

This adds a supplemental flag for the host list command that narrows the listing to hosts that are children of some group. It is actually just a shortcut for the query string that does this, but it's sufficiently common of a need that I think it makes sense.
Fixes #131

Coverage decreased (-0.2%) to 99.786% when pulling 7419b8ba0c6325e158ce7662ed320a41f29189b9 on AlanCoding:131_group_host_list into e8ba98398e006425b59cc78d6709beab88837604 on ansible:master.

Coverage remained the same at 100.0% when pulling 1ebb406a6d40267e1a37928c8ff28bebe3f12518 on AlanCoding:131_group_host_list into e8ba98398e006425b59cc78d6709beab88837604 on ansible:master.


Implement new component using existing theme

Hi,
I am new to the concept of styled-components and will like to know if it is possible to somehow reuse the styles already in the dashboard to build and extend additional components to be using the same theme styles.
For example, if i want to implement my own post component like this https://github.com/booleanhunter/ReactJS-AdminLTE/tree/master/src/components/post
How can i re-use the styles?

This is a good question, I had to look into it myself.  It turns out that styled-components provides a decorator/wrapper withTheme that injects the theme object which was provided to the parent into any child component.  I checked and this even works past react-router, which blocks passing other props.  See this for use: styled-components theming
Unfortunately, I haven't created any documentation for the theme variables outside of the source itself, but  look in src/styles and specifically variables.js.  I think it's fairly clear, but then I wrote it...
I had planned to eventually add those components to this library, so if you feel like contributing either components or documentation so others can do the same, I'd welcome it.

How about adding the variables and the skins to the exported modules?
Something like this:
import './main.css';

import Dashboard from './components/Dashboard';
import Header from './components/Header';
import Sidebar from './components/Sidebar';
import Variables from './styles/variables';
import Skins from './styles';

module.exports = {
  Dashboard,
  Header,
  Sidebar,
  Variables,
  Skins,
};

This will allow developers reuse the colors to write additional components, and if they switch skin, it will also switch their components.
what do you think?

I could certainly add those to the exported modules, but it wouldn't tie the components to the theme that is currently in use.  The developer would be able to reuse the colors, etc to write the component, but they'd have to control theme state on their own.
If the use case is to have a separate component that could be used as a child under <Dashboard /> with matching theme, I think withTheme is the only way to go.  A component could then be developed that had certain default theme parameters, but could be overridden by the provided wrapper.  I could wrap and ship withTheme as part of this package, but it would make it larger, which I'm not keen on.

I agree, <ThemeProvider> is the way to go here. If i will have some time I might implement it myself and create a PR for you, if you want to see if you want to add it.

I'm adding a reference to this in the README.  It could probably be expanded upon, but I've been thinking it's best for this package for withTheme to remain separate, so that's how I wrote it in.  Documentation for the theme variables will also be TBD.  I will close this issue with that commit.


no request handler registered after installing with vim-plug

After switching from Vundle to vim-plug, re-installing all my plugins without any error, I get the following error when I try to start a kernel:
Error detected while processing function IPyConnect[1]..remote#define#request:
line    2:
Error invoking '/home/soulthym/.config/vim/bundle/nvim-ipy/rplugin/python3/nvim_ipy:function:IPyConnect' on channel 82 (python3-rplugin-host):
no request handler registered for "/home/soulthym/.config/vim/bundle/nvim-ipy/rplugin/python3/nvim_ipy:function:IPyConnect"

Any idea of what's going wrong? I couldn't find a solution in past issues

Did you run UpdateRemotePlugins after re-installing?

I actually forgot to do that, it totally fixed it!
Thanks, I added it to my update script


How to use Casdoor with NGINX with custom location?

I have my nginx conf like this, but I cant get Casdoor to work
location / {
			rewrite static https://mydomain:8443/uac/static/ redirect;
		    try_files $uri $uri/ =404;
	    }

location /uac/ {
			proxy_redirect off;
			proxy_set_header Host $host;
			proxy_set_header X-Real-IP $remote_addr;
			proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
			proxy_set_header REMOTE-HOST $remote_addr;
			proxy_pass http://<IP_ADDRESS>:8080/;

	    }

I would like to access Casdoor with https://mydomain:8443/uac ，how should I setup my nginx conf?

@jdjingdian Casdoor must be deployed at root: https://mydomain:8443

hello, Have you solved this problem?

@BBM-Freehub yes, any domain would work. HTTPS would be better. Sub path is not supported


Unable to unpin pinned folders from taskbar right click menu

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.65.2
OS Version: Windows 11

Issue:

I pinned several folders to the vscode right click taskbar menu. I then changed the root folder name of my windows user (C:/Users/{I changed this}). It was a difficult process to change my user folder name since it's linked to my microsoft account, I remember messing with regedit and permissions etc.
After doing so, I was unable to unpin the previously pinned folders. When I click the unpin icon, it just refreshes the menu and nothing happens. When I click to open, it just opens a blank file with the same file name as the folder that says "Select a language to get started. Start typing to dismiss, or don't show this again", which makes sense since I changed my user folder name so the path doesn't exist anymore.
Steps to Reproduce:
Simply making a folder, pinning it, and deleting it does not reproduce the issue. I'm not sure exactly how to reproduce other than what I said above as I don't want to go through the trouble of trying to rename the folder of my user again.
I just want a way to hard reset the pinned folders of my task bar right click menu.

Does https://github.com/microsoft/vscode/issues/69365#issuecomment-467791945 help?

I am not sure how these folders get pinned, is this something handled by VS Code or Windows?


Benchmark program should obey message-digest return codes

Issue: The benchmark program programs/test/benchmark.c, specifically the macro TIME_AND_TSC, doesn't check the newly introduced error codes from the message-digest functions. If alternative message-digest implementations fail, the benchmark application won't notice and return inappropriate running times.

ARM Internal Ref: IOTSSL-2080

This issue was fixed in https://github.com/ARMmbed/mbedtls/commit/51d7cfe026fa3f33d86a80d27ea9013830f33992
Still exists in mbedtls-2.7 though

fixed with #1617


[fix][broker] Only validate superuser access if authz enabled

Motivation
In #19455, I added a requirement that only the proxy role could supply an original principal. That check is only supposed to apply when the broker has authorization enabled. However, in one case, that was not the case. This PR does a check and returns early when authorization is not enabled in the broker.
See https://github.com/apache/pulsar/pull/19830#issuecomment-1492262201 for additional motivation.
Modifications

Update the PulsarWebResource#validateSuperUserAccessAsync to only validate when authentication and authorization are enabled in the configuration.

Verifying this change
This is a trivial change. It'd be good to add tests, but I didn't include them here because this is a somewhat urgent fix. There was one test that broke because of this change, so there is at least some existing coverage.
Documentation

[x] doc-not-needed

Matching PR in forked repository
PR in forked repository: https://github.com/michaeljmarshall/pulsar/pull/39

Since there will not have a scenario like this disabled authentication & enabled authorization, so it will work.

Correct. The broker actually fails on startup if that is the configuration:
https://github.com/apache/pulsar/blob/6621fd3451a52bb7447ebeb845c83ac2f310b718/pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java#L695-L698

/pulsarbot run-failure-checks

@michaeljmarshall Is it possible to add a test to make we will not be impacted in the future?

Looks like there are some legitimate test failures. I fixed the first. The second is activeBrokerParse added by https://github.com/apache/pulsar/pull/9191. It looks like that test enables authorization, but it doesn't look configured. I think we can remove those config lines, but I'm not certain.

The second is activeBrokerParse added by #9191. It looks like that test enables authorization, but it doesn't look configured. I think we can remove those config lines, but I'm not certain.

I decided to remove the configuration to enable authorization. It was not actually used in the previous tests and it was forcing the failure here. If we want to test authorization in that test, we need to enable authentication as well.

/pulsarbot run-failure-checks

There are more, legitimate test failures. This one is next testNamespacesApiRedirects. Interestingly, it looks like that test might have a hint as to why the activeBrokerParse was enabling authorization:
https://github.com/apache/pulsar/blob/3a069ed07ea0e03405b72458a585f93bf95b2d77/pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/NamespacesTest.java#L706-L707
When running the activeBrokerParse locally, it is flaky, and it appears that it passes on master when there are several 307 redirects, but fails on my branch without any of those redirects.

This is the part of the code that has the "hack" described in the above comment:
https://github.com/apache/pulsar/blob/3b76dd435d1bb7f5f933dbc15307255c7c928ca4/pulsar-broker/src/main/java/org/apache/pulsar/broker/web/PulsarWebResource.java#L512-L519
https://github.com/apache/pulsar/blob/3b76dd435d1bb7f5f933dbc15307255c7c928ca4/pulsar-broker/src/main/java/org/apache/pulsar/broker/web/PulsarWebResource.java#L536-L547

After discovering the hack, I noticed that the "easiest" solution is to add the check for authentication back in. I don't have time to dig into the (surprising) coupling of authorization and geo replication, so I created an issue https://github.com/apache/pulsar/issues/20023.

@michaeljmarshall Is it possible to add a test to make we will not be impacted in the future?

@codelipenghui - given that it made a test fail, I think we're "covered" because I updated the test. I think the more ideal solution will be to refactor this logic so that it is in the AuthorizationService.

Codecov Report

Merging #19989 (04f9e98) into master (68c10ee) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master   #19989      +/-   ##
============================================
- Coverage     72.89%   72.82%   -0.08%
+ Complexity    31619    31594      -25
============================================
  Files          1861     1861
  Lines        137356   137383      +27
  Branches      15117    15123       +6
============================================
- Hits         100131   100054      -77
- Misses        29271    29371     +100
- Partials       7954     7958       +4

Flag
Coverage Δ

inttests
24.38% <0.00%> (-0.06%)
:arrow_down:

systests
24.95% <0.00%> (-0.09%)
:arrow_down:

unittests
72.13% <100.00%> (-0.06%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...rg/apache/pulsar/broker/web/PulsarWebResource.java
64.34% <100.00%> (+0.39%)
:arrow_up:

... and 102 files with indirect coverage changes

I'll take care of cherry picking this later tonight. There are some merge conflicts to resolve.

Cherry picking complete.


Add linter rule for imports

https://eslint.org/docs/rules/sort-imports

I don't see rule about relative and absolute imports.
We have to try that too.
Maybe this is an other rule


Simulator Log View

basic table which shows the command which have been sent to the simulator.
Can be extended later on to have a link to the block which initiated the command.
Didn't manage to remove the whitespace in that table
Added react-table module

I think including a table module might be a little over kill. You can render a table like this in React:
const data = [{foo: ''} ... ];

return (

Foo Column Header

      {data.map(d =>
{d.foo}
)} // maps data array to list of react "tr" components

)

Does the ui framework we have in the project have a table component built in?
I think we’re using Microsoft’s fluent ui.
Maybe take a look at this?
https://developer.microsoft.com/en-us/fluentui#/controls/web/detailslist

I don't think that the RobotSimulatorSlice should keep a history of the commands. It's not his job and why should he? If he cares about other view's use-cases he will become too big.
In the log view I also want to show multiple logs. Like from the past n runs. Don't want to put all this burden on the RobotSimulatorSlice.
The other points mentioned I will refactor my code. Thanks for reviewing so fast!

Redux is designed to store all state, idea idea being without it state is stored in many different places split up in different areas of the application. It becomes very hard to manage.
So if you think separating the log state into different parts is a good idea I’d suggest creating another slice for the state instead of storing it in the component itself.

That makes sense. Would it make sense to simply create a new redux slice
for a log command? We generally don't want react components to keep state
like event history.
On Sun, Jun 21, 2020, 11:22 AM JamesWP<EMAIL_ADDRESS>wrote:

Redux is designed to store all state, idea idea being without it state is
stored in many different places split up in different areas of the
application. It becomes very hard to manage.
So if you think separating the log state into different parts is a good
idea I’d suggest creating another slice for the state instead of storing it
in the component itself.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/FRUK-Simulator/Simulator/pull/61#issuecomment-647141965,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEZSQPRCYP4AEVSZLS6MF2DRXYQRXANCNFSM4OD3MZKA
.

So if you think separating the log state into different parts is a good idea I’d suggest creating another slice for the state instead of storing it in the component itself.

React components can also become unmounted and destroyed, losing all state and this seems like a persistent set of data so its definitely better to hoist it up into redux - but I definitely agree the robotSimulator might not be the best place to put it. Maybe a "monitorSlice" or something?
Here is an example of a reducer that "listens" to actions that belong to a different slice of state: https://github.com/FRUK-Simulator/Simulator/blob/master/src/BlocklyInterface/blocklySlice.ts#L29
In this case, you could add cases to your reducer for each of the robotSimulator commands

ok, I think I got the point regarding moving the state into it's own slice away from the component. I will move it to ExecutionSlice which goes into it's own directory.
I just wonder how this would scale if I have 10000 commands and add another one. Will the entire content of the table be reacreated? The listener of the state change can't know which item has been added/changed and therefor needs to recreate all rows from scratch.

React only create the elements on screen if they need to be created, if the state has one item appended to it then yes the state will be copied momentarily as the master copy is updated.  But react only creates one new HTML element for the new row.
But maybe there would be a limit where we would need to remove old things but I think it’s a problem for future us to solve :D

Will the entire content of the table be reacreated?

React has a way of dealing with this as well to determine what in a list needs to be updated in the actual DOM. See https://reactjs.org/docs/lists-and-keys.html#keys. As long as each element in the list

thanks for the explanations.
I update the PR and pulled the state out of the component and put it into it's own slice.
Also removed react-table and replaced with simple HTML table.

Implemented all required changes from last comment. Thanks a lot - I learned again much :-)

edited some comments just right now and uploaded another change

Two things, the log view should show the most recently executed action, otherwise its just showing stale data always, either reverse the order or scroll to show the last item when you add another one.
i also just noticed that it mentions 'percent' but the value goes between -1 and 1 not -100 and 100.

new commands will now be added at the top.
I normalized the range to use -100 to 100 in the UI and -1 to 1 internally


The position drop-down filtering the underlying derivative is broken.

The position drop-down filtering the underlying derivative is broken. This is probably due to the new updates to Kite page, where the context menu for position is now moved to end of the table. Please refer: https://support.zerodha.com/category/trading-and-markets/kite-web-and-mobile/others/articles/kite-positions-update

fixed. take latest 4.13
I have just fixed filtering for now, not sure what other things have also broken :) will do full check later.

The issue seems to be derived from the statement GM_getValue(GMPositionsName, defaultPositions); where positions are not getting returned.

No, the issue was change in html dom.

Thanks. The filtering is fixed post update.


[HIPIFY] quick start questions on hipify-clang

Problem Description
Hi, I am pretty new to hipify-clang tool. I am trying to porting a cuda based project to rocm(hip) project.
as rocm-pytorch image has provided hipify-clang by default, so I'd thought hipify-clang can work in rocm-pytorch images.
while during usage, it always complain:
error: cannot find CUDA installation; provide its path via '--cuda-path', or pass '-nocudainc' to build without CUDA includes

so  looks hipify-clang requires a cuda environment.  so  a few questions in mind:

what's the usage case for hipify-clang in a rocm-pytorch image?
Does it mean, for porting existing cuda project to rocm, user need to build hipify from source in an CUDA environment first, as cuda docker doesn't provide pre-built hipify tool?

Thanks for quick answer
David
Operating System
ubuntu 20.04
CPU
Intel(R) Xeon(R) Platinum 8480C
ROCm Version
ROCm 6.0.0
ROCm Component
HIPIFY
Steps to Reproduce
No response
(Optional for Linux users) Output of /opt/rocm/bin/rocminfo --support
No response
Additional Information
No response

Hello @ZJLi2013,

what's the usage case for hipify-clang in a rocm-pytorch image?

Please address this question to https://github.com/ROCm/hipify_torch.

Does it mean, for porting existing cuda project to rocm, user need to build hipify from source in an CUDA environment first, as cuda docker doesn't provide pre-built hipify tool?

Nope, users can install the corresponding ROCm package with HIPIFY tools (hipify-clang + hipify-perl). hipify-clang needs CUDA installed in the system, whereas hipify-perl doesn't.
Please, refer to the documentation for the details:
https://github.com/ROCm/HIPIFY/blob/amd-staging/docs/hipify-clang.rst
https://github.com/ROCm/HIPIFY/blob/amd-staging/docs/hipify-perl.rst

Closing as answered.


Unable to narrow parameterized generic types for functions

TypeScript Version:  2.8
Code
function test<T extends 'a' | 'b'>(x: T) {
  if (x === 'a') {
    const z1 = x;
  }
}

function test2(x: 'a' | 'b') {
  if (x === 'a') {
    const z2 = x;
  }
}

Expected behavior:
z1 and z2 should have the same type, which is a
Actual behavior:
function test is unable to narrow parameter x, with the if check, and z2 resolves to x

With strictNullChecks enabled your code won't even compile, because the type null is not compatible with the type 'a' | 'b'.
Without strictNullChecks the value null is implicitly compatible with every type. When you call test(null) the compiler resolves to any because it can't figure out the type of T. Based on null the compiler can't deduct any sensible type. You could expect that it should return 'a' | 'b', because T must extend from it, but that would still only be a "guess". There's no T-type known.

I think I communicated the issue wrong, it was not about the actual return type but the type guard in the implementation, I edited the first post to reflect that.


Workaround for GitHub search API bug

If an issue title contains a number that is surrounded by two spaces, the in:title search qualifier is ignored, and the number property of issues is also taken into account. Issues that are returned based on said number property also always have a score of 100, which places them before the actual issue.
To work around this limitation, the og:title issue lookup function now iterates over all returned issues and returns the first one that exactly matches the OpenGraph title.

Linking #119 here. @jdanyow could you give this a review?

Any update on this @jdanyow? 🙂

Any update on this @jdanyow? 🙂

aiming to ship an update with this fix in the next day or two

@PhilipTrauner / @RohanNagar I've shipped an update using the code from this PR with a slight modification: instead of returning null at the very end I kept the logic that would return the first match.
I want to do some more testing before returning null when none of the items in the issue search response match on title.

I fully understand why you'd want to err on the side of caution with this one, but the fix you deployed doesn't resolve the actual problem this PR was meant to address. Posts that contain issue identifiers for which no comment issue has been created yet still resolve to the wrong issue (e.g. https://philip-trauner.me/blog/post/pedantic-elgato-thunderbolt-3-pro-dock-review).

@PhilipTrauner I agree, this isn't fully fixed yet. I've kept #119 open.


PHP ^8.2 and Laravel 11 Support

Any interest in updating this with PHP 8 and Laravel 11?

New release tagged here https://github.com/digikraaft/laravel-model-suspension/releases/tag/v3.1.0


How to connect SalesGPT with Streamlit Chat

I found SalesGPT as a very powerful and interesting framework!
The only issue is how to connect or transform console mode into a more user-friendly "chat" format.
For example, how to integrate it with https://pypi.org/project/streamlit-chat/ output.
Any updates for this option are welcome!
Thanks
Andrii

@andirey thanks so much for this feature request.
Putting on the product roadmap and help needed! :)
Thanks, Filip


Support NCCL 2.18.1

Tasks

[x] Read Release Notes (cuTENSOR / cuSPARSELt / cuDNN / NCCL).
[ ] Fix code and CI to support the new vesrion.

FlexCI: Update .pfnci/schema.yaml and .pfnci/matirx.yaml.
Library Installer: Update cupyx/tools/install_library.py.

[ ] Backport the above PR.
[ ] Fix documentation.

Update Requirements section in the Installation Guide

[ ] Backport the above PR.
[ ] Implement new features using the version, if any.

CI will be added in #7748


Add wide vector shader option to Custom Drawable Layer

Introduce a new way to draw lines into the library's CustomDrawableLayer interface, by using a third party shader on the Metal platform.
This shader makes use of instancing, and that is implemented into the toolkit for the Metal backend. OpenGL instancing is not implemented by this PR, but the base interface is common and compatible.
The DrawableBuilder is added two methods to build Wide vector polylines: addWideVectorPolylineLocal and addWideVectorPolylineGlobal. These make use of local (tile) coordinates, and global (geographic) coordinates respectively.
ExampleCustomDrawableStyleLayerHost class in ExampleCustomDrawableStyleLayer.mm contains the updated examples for adding wide vector polylines through the CustomDrawableLayer interface.

Could you share some more context about this PR for future reference?

Can some kind of test be added?

@louwers : This is currently only available through the CustomDrawable API, therefore can't be included in the regular render test suite.
The API tests for CustomDrawableLayer currently don't support Metal, so we can't include a relevant test there either, since we only have a Metal shader in place.


Remove turtlebot3 packages from .rosinstall

Description of changes:
In the same vein as https://github.com/aws-robotics/aws-robomaker-sample-application-cloudwatch/pull/67 and https://github.com/aws-robotics/aws-robomaker-sample-application-persondetection/pull/66, this removes turtlebot3 packages from the .rosinstall file, so that these packages are no longer obtained by source code through rosws update, but rather directly by binary through rosdep install, which should be the preferred method.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

I will additionally do manual testing on RoboMaker simulation.

Looks like this won't work for our esoteric Kinetic + Gazebo 9 case.


Remove unneeded class prefixes

Pull Request Test Coverage Report for Build<PHONE_NUMBER>5
Details

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.02%) to 56.83%

Files with Coverage Reduction
New Missed Lines
%

src/SFML/Window/WindowImpl.cpp
4
52.29%

Totals

Change from base Build<PHONE_NUMBER>4:
-0.02%

Covered Lines:
11881

Relevant Lines:
19874

💛  - Coveralls

SFMLBuildMaster: Build this please.

SFMLBuildMaster: Build this please.


BasicDecoderOutput with None lengths in networks_seq2seq_nmt example

URL(s) with the issue:
https://www.tensorflow.org/addons/tutorials/networks_seq2seq_nmt
Description of issue:
It is not clear what the output of the BasicDecoder is. The output variable is is from type BasicDecoderOutput and has two attributes: rnn_output and sample_id. The output should be (in my opinion) of shape (batch_size, target_leghts, vocab_size) and (batch_size, target_leghts) respectively. When I print the variable in the training loop the larget_lengths is None. Why is this not an issue for the calculation of the loss? and how do I get the real predictions inside the train_step function e.g. to calculate metrics?
Submit a pull request?
Currently not since I don't understand the solution myself. But afterwards, I would create a pull request to share the information.

It just means that the shape is not known when building the graph. Can you try using tf.print instead and see if the actual value is printed?


Prometheus URL has very high latency during deployment

We are running a Spring Boot v2.5.12 with Spring Cloud v2020.0.5 micro-service on Kubernetes v1.23.8 cluster with deployments managed by Helm3.
The cluster is monitored by a Datadog agent v0.91.0.
During the deployment phase of the pods, the /management/prometheus URL latency is as high as 10-15s, which causes overall degradation of the service SLOs for a brief period of 1-2min.
The annotations specified in deployment template are given below:
annotations:
        ad.datadoghq.com/{{ .Chart.Name }}.check_names: |
          ["openmetrics"]
        ad.datadoghq.com/{{ .Chart.Name }}.init_configs: |
          [{}]
        ad.datadoghq.com/{{ .Chart.Name }}.instances: |
          [
            {
              "prometheus_url": "http://%%host%%:{{ .Values.container.management.port | default 9002 }}/management/prometheus",
              "namespace": "",
              "metrics": ["*"]
            }
          ]

What would be the recommendations from your team to overcome this performance issue?

This issue tracker is primarily used to track bugs in the Agent codebase to completion. For issues directly related to your use of the agent, we have a dedicated team who can investigate your reports directly. Please contact Datadog support and and send them a flare demonstrating the issue.
Thanks!


v1.18.3 to v1.19.1 upgrade failed - crashing with exec: "k3s-server": executable file not found in $PATH

Environmental Info:
K3s Version:

1.18.3 & 1.19.1
Node(s) CPU architecture, OS, and Version:

Linux ip-10-0-7-10 5.3.0-1035-aws #37-Ubuntu SMP Sun Sep 6 01:17:09 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Cluster Configuration:

1 master
Describe the bug:

Attempted an upgrade from k3s v1.18.3 to v1.19.1. After the upgrade was run, k3s was continuously crashing with fatal "executable file not found..." error.
Steps To Reproduce:

Installed k3s 1.18.3 on a fresh Ubuntu 18.04 VM on AWS EC2:

# curl -sfL https://get.k3s.io | INSTALL_K3S_VERSION=v1.18.3 sh -
[INFO]  Using v1.18.3 as release
[INFO]  Downloading hash https://github.com/rancher/k3s/releases/download/v1.18.3/sha256sum-amd64.txt
root@ip-10-0-7-10:~# curl https://github.com/rancher/k3s/releases/download/v1.18.3/sha256sum-amd64.txt
Not Foundroot@ip-10-0-7-10:~#
root@ip-10-0-7-10:~#
root@ip-10-0-7-10:~# curl -sfL https://get.k3s.io | INSTALL_K3S_VERSION=v1.18.3+k3s1 sh -
[INFO]  Using v1.18.3+k3s1 as release
[INFO]  Downloading hash https://github.com/rancher/k3s/releases/download/v1.18.3+k3s1/sha256sum-amd64.txt
[INFO]  Downloading binary https://github.com/rancher/k3s/releases/download/v1.18.3+k3s1/k3s
[INFO]  Verifying binary download
[INFO]  Installing k3s to /usr/local/bin/k3s
[INFO]  Creating /usr/local/bin/kubectl symlink to k3s
[INFO]  Creating /usr/local/bin/crictl symlink to k3s
[INFO]  Creating /usr/local/bin/ctr symlink to k3s
[INFO]  Creating killall script /usr/local/bin/k3s-killall.sh
[INFO]  Creating uninstall script /usr/local/bin/k3s-uninstall.sh
[INFO]  env: Creating environment file /etc/systemd/system/k3s.service.env
[INFO]  systemd: Creating service file /etc/systemd/system/k3s.service
[INFO]  systemd: Enabling k3s unit
Created symlink /etc/systemd/system/multi-user.target.wants/k3s.service → /etc/systemd/system/k3s.service.
[INFO]  systemd: Starting k3s

Did a few sanity checks to make sure cluster was healthy:

# kubectl get nodes
NAME           STATUS   ROLES    AGE     VERSION
ip-10-0-7-10   Ready    master   6m27s   v1.18.3+k3s1
# kubectl get pods -A
NAMESPACE     NAME                                     READY   STATUS      RESTARTS   AGE
kube-system   local-path-provisioner-6d59f47c7-cdrfm   1/1     Running     0          8m27s
kube-system   metrics-server-7566d596c8-7x2v4          1/1     Running     0          8m27s
kube-system   helm-install-traefik-j9nxw               0/1     Completed   1          8m27s
kube-system   svclb-traefik-pmvcq                      2/2     Running     0          8m6s
kube-system   coredns-8655855d6-bf8tj                  1/1     Running     0          8m27s
kube-system   traefik-758cd5fc85-lfp9b                 1/1     Running     0          8m6s

After the cluster had been running a little over 10 minutes, performed an upgrade:

# curl -sfL https://get.k3s.io | INSTALL_K3S_VERSION=v1.19.1+k3s1 sh -
[INFO]  Using v1.19.1+k3s1 as release
[INFO]  Downloading hash https://github.com/rancher/k3s/releases/download/v1.19.1+k3s1/sha256sum-amd64.txt
[INFO]  Downloading binary https://github.com/rancher/k3s/releases/download/v1.19.1+k3s1/k3s
[INFO]  Verifying binary download
[INFO]  Installing k3s to /usr/local/bin/k3s
[INFO]  Skipping /usr/local/bin/kubectl symlink to k3s, already exists
[INFO]  Skipping /usr/local/bin/crictl symlink to k3s, already exists
[INFO]  Skipping /usr/local/bin/ctr symlink to k3s, already exists
[INFO]  Creating killall script /usr/local/bin/k3s-killall.sh
[INFO]  Creating uninstall script /usr/local/bin/k3s-uninstall.sh
[INFO]  env: Creating environment file /etc/systemd/system/k3s.service.env
[INFO]  systemd: Creating service file /etc/systemd/system/k3s.service
[INFO]  systemd: Enabling k3s unit
Created symlink /etc/systemd/system/multi-user.target.wants/k3s.service → /etc/systemd/system/k3s.service.
[INFO]  systemd: Starting k3s
Job for k3s.service failed because the control process exited with error code.
See "systemctl status k3s.service" and "journalctl -xe" for details.

Expected behavior:
k3s would become healthy and stable on version 1.19.1.
Actual behavior:
k3s crashing repeatedly.
Additional context / logs:

Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: k3s.service: Found left-over process 2438 (containerd-shim) in control group while starting unit. Ignoring.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: This usually indicates unclean termination of a previous run, or service implementation deficiencies.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: k3s.service: Found left-over process 2447 (containerd-shim) in control group while starting unit. Ignoring.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: This usually indicates unclean termination of a previous run, or service implementation deficiencies.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: k3s.service: Found left-over process 2540 (containerd-shim) in control group while starting unit. Ignoring.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: This usually indicates unclean termination of a previous run, or service implementation deficiencies.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: k3s.service: Found left-over process 3458 (containerd-shim) in control group while starting unit. Ignoring.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: This usually indicates unclean termination of a previous run, or service implementation deficiencies.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: k3s.service: Found left-over process 3575 (containerd-shim) in control group while starting unit. Ignoring.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: This usually indicates unclean termination of a previous run, or service implementation deficiencies.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: k3s.service: Found left-over process 2488 (pause) in control group while starting unit. Ignoring.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: This usually indicates unclean termination of a previous run, or service implementation deficiencies.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: k3s.service: Found left-over process 2516 (pause) in control group while starting unit. Ignoring.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: This usually indicates unclean termination of a previous run, or service implementation deficiencies.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: k3s.service: Found left-over process 2631 (pause) in control group while starting unit. Ignoring.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: This usually indicates unclean termination of a previous run, or service implementation deficiencies.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: k3s.service: Found left-over process 2814 (coredns) in control group while starting unit. Ignoring.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: This usually indicates unclean termination of a previous run, or service implementation deficiencies.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: k3s.service: Found left-over process 2875 (metrics-server) in control group while starting unit. Ignoring.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: This usually indicates unclean termination of a previous run, or service implementation deficiencies.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: k3s.service: Found left-over process 3496 (pause) in control group while starting unit. Ignoring.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: This usually indicates unclean termination of a previous run, or service implementation deficiencies.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: k3s.service: Found left-over process 3602 (pause) in control group while starting unit. Ignoring.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: This usually indicates unclean termination of a previous run, or service implementation deficiencies.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: k3s.service: Found left-over process 3897 (entry) in control group while starting unit. Ignoring.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: This usually indicates unclean termination of a previous run, or service implementation deficiencies.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: k3s.service: Found left-over process 3917 (traefik) in control group while starting unit. Ignoring.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: This usually indicates unclean termination of a previous run, or service implementation deficiencies.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: k3s.service: Found left-over process 3988 (entry) in control group while starting unit. Ignoring.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: This usually indicates unclean termination of a previous run, or service implementation deficiencies.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: Starting Lightweight Kubernetes...
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: k3s.service: Found left-over process 2438 (containerd-shim) in control group while starting unit. Ignoring.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: This usually indicates unclean termination of a previous run, or service implementation deficiencies.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: k3s.service: Found left-over process 2447 (containerd-shim) in control group while starting unit. Ignoring.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: This usually indicates unclean termination of a previous run, or service implementation deficiencies.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: k3s.service: Found left-over process 2540 (containerd-shim) in control group while starting unit. Ignoring.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: This usually indicates unclean termination of a previous run, or service implementation deficiencies.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: k3s.service: Found left-over process 3458 (containerd-shim) in control group while starting unit. Ignoring.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: This usually indicates unclean termination of a previous run, or service implementation deficiencies.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: k3s.service: Found left-over process 3575 (containerd-shim) in control group while starting unit. Ignoring.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: This usually indicates unclean termination of a previous run, or service implementation deficiencies.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: k3s.service: Found left-over process 2488 (pause) in control group while starting unit. Ignoring.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: This usually indicates unclean termination of a previous run, or service implementation deficiencies.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: k3s.service: Found left-over process 2516 (pause) in control group while starting unit. Ignoring.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: This usually indicates unclean termination of a previous run, or service implementation deficiencies.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: k3s.service: Found left-over process 2631 (pause) in control group while starting unit. Ignoring.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: This usually indicates unclean termination of a previous run, or service implementation deficiencies.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: k3s.service: Found left-over process 2814 (coredns) in control group while starting unit. Ignoring.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: This usually indicates unclean termination of a previous run, or service implementation deficiencies.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: k3s.service: Found left-over process 2875 (metrics-server) in control group while starting unit. Ignoring.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: This usually indicates unclean termination of a previous run, or service implementation deficiencies.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: k3s.service: Found left-over process 3496 (pause) in control group while starting unit. Ignoring.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: This usually indicates unclean termination of a previous run, or service implementation deficiencies.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: k3s.service: Found left-over process 3602 (pause) in control group while starting unit. Ignoring.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: This usually indicates unclean termination of a previous run, or service implementation deficiencies.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: k3s.service: Found left-over process 3897 (entry) in control group while starting unit. Ignoring.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: This usually indicates unclean termination of a previous run, or service implementation deficiencies.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: k3s.service: Found left-over process 3917 (traefik) in control group while starting unit. Ignoring.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: This usually indicates unclean termination of a previous run, or service implementation deficiencies.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: k3s.service: Found left-over process 3988 (entry) in control group while starting unit. Ignoring.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: This usually indicates unclean termination of a previous run, or service implementation deficiencies.
Sep 22 17:35:21 ip-10-0-7-10 k3s[685]: time="2020-09-22T17:35:21Z" level=fatal msg="exec: \"k3s-server\": executable file not found in $PATH"
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: k3s.service: Main process exited, code=exited, status=1/FAILURE
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: k3s.service: Failed with result 'exit-code'.
Sep 22 17:35:21 ip-10-0-7-10 systemd[1]: Failed to start Lightweight Kubernetes.

Full log - k3s.log.gz

Tried the same upgrade a second time on a new VM and it worked at expected, so must have hit an intermittent issue that is not consistently reproducible.

Were you by any chance low on disk space?

I think the chances of that are pretty low. I used a fresh Ubuntu VM with 10GB root disk and minimal install. Before k3s installation, there was almost 9GB free.
root@ip-10-0-7-10:~# df -h
Filesystem      Size  Used Avail Use% Mounted on
udev            1.9G     0  1.9G   0% /dev
tmpfs           389M  712K  389M   1% /run
/dev/nvme0n1p1  9.7G  805M  8.9G   9% /
tmpfs           1.9G     0  1.9G   0% /dev/shm
tmpfs           5.0M     0  5.0M   0% /run/lock
tmpfs           1.9G     0  1.9G   0% /sys/fs/cgroup
/dev/loop0       98M   98M     0 100% /snap/core/9993
/dev/loop1       29M   29M     0 100% /snap/amazon-ssm-agent/2012
tmpfs           389M     0  389M   0% /run/user/1000

I doubt running a vanilla k3s for 10-15 minutes and doing an upgrade will fill up that much space. But since I shutdown the environment, I guess I can't say with 100% certainty.
I ran through the steps in the description for a third time and did not hit the issue again. There was about 8GB free after the upgrade.

@dnoland1 was there any process running in the background, i.e. watch kubectl get pod, which could have triggered the data-dir extraction while the k3s service was coming back up and hence likely also performing the extraction? I've noticed corruption resulting in segfaults and other odd behavior on systems with very slow disk i/o (most often for me, arm/arm64 on mini-sd) attributable, I think, to this bug: #1938

@dweomer That's an interesting question and theory. I think there's a good chance I was running watch -n1 "kubectl get nodes; kubectl get pods -A" in another terminal so I could monitor the upgrade process of the nodes and pods.

Hopefully this is fixed with https://github.com/rancher/k3s/pull/2349

Tried to reproduced this issue upgrading from v1.18.3+k3s1 to v1.19.1+k3s1 while running watch -n1 "kubectl get nodes; kubectl get pods -A" from another terminal.
Upgrade was successful, Node was up and Pods in running running state. But during upgrade found fatal log messages
curl -sfL https://get.k3s.io | INSTALL_K3S_VERSION=v1.19.1+k3s1 sh -
[INFO]  Using v1.19.1+k3s1 as release
[INFO]  Downloading hash https://github.com/rancher/k3s/releases/download/v1.19.1+k3s1/sha256sum-amd64.txt
[INFO]  Downloading binary https://github.com/rancher/k3s/releases/download/v1.19.1+k3s1/k3s
[INFO]  Verifying binary download
[INFO]  Installing k3s to /usr/local/bin/k3s
[INFO]  Skipping /usr/local/bin/kubectl symlink to k3s, already exists
[INFO]  Skipping /usr/local/bin/crictl symlink to k3s, already exists
[INFO]  Skipping /usr/local/bin/ctr symlink to k3s, already exists
[INFO]  Creating killall script /usr/local/bin/k3s-killall.sh
[INFO]  Creating uninstall script /usr/local/bin/k3s-uninstall.sh
[INFO]  env: Creating environment file /etc/systemd/system/k3s.service.env
[INFO]  systemd: Creating service file /etc/systemd/system/k3s.service
[INFO]  systemd: Enabling k3s unit
Created symlink /etc/systemd/system/multi-user.target.wants/k3s.service → /etc/systemd/system/k3s.service.
[INFO]  systemd: Starting k3s
Job for k3s.service failed because the control process exited with error code.
See "systemctl status k3s.service" and "journalctl -xe" for details.

Logs:
Oct 14 23:11:43 ip-172-31-7-248 k3s[38942]: time="2020-10-14T23:11:43Z" level=fatal msg="extracting data: symlink coreutils /var/lib/rancher/k3s/data/1933e1efa2359d4f4d58bafb81c9367f94d978df6fc26e281b9badd400300673-tmp/bin/tty: file exists"

Validated fix using commit id 6b11d860374f938623479b0d06aeb3c1ac87ce86
Upgrade from v1.18.3+k3s1 to commit 6b11d860374f938623479b0d06aeb3c1ac87ce86 was successul. Above fatal logs not present.
kubectl get nodes
NAME              STATUS   ROLES    AGE   VERSION
ip-172-31-10-88   Ready    master   37s   v1.18.3+k3s1

curl -sfL https://get.k3s.io | INSTALL_K3S_COMMIT=6b11d860374f938623479b0d06aeb3c1ac87ce86 sh -
[INFO]  Using commit 6b11d860374f938623479b0d06aeb3c1ac87ce86 as release
[INFO]  Downloading hash https://storage.googleapis.com/k3s-ci-builds/k3s-6b11d860374f938623479b0d06aeb3c1ac87ce86.sha256sum
[INFO]  Downloading binary https://storage.googleapis.com/k3s-ci-builds/k3s-6b11d860374f938623479b0d06aeb3c1ac87ce86
[INFO]  Verifying binary download
[INFO]  Installing k3s to /usr/local/bin/k3s
[INFO]  Skipping /usr/local/bin/kubectl symlink to k3s, already exists
[INFO]  Skipping /usr/local/bin/crictl symlink to k3s, already exists
[INFO]  Skipping /usr/local/bin/ctr symlink to k3s, already exists
[INFO]  Creating killall script /usr/local/bin/k3s-killall.sh
[INFO]  Creating uninstall script /usr/local/bin/k3s-uninstall.sh
[INFO]  env: Creating environment file /etc/systemd/system/k3s.service.env
[INFO]  systemd: Creating service file /etc/systemd/system/k3s.service
[INFO]  systemd: Enabling k3s unit
Created symlink /etc/systemd/system/multi-user.target.wants/k3s.service → /etc/systemd/system/k3s.service.
[INFO]  systemd: Starting k3s
root@ip-172-31-10-88:~#

kubectl get nodes
NAME              STATUS   ROLES    AGE   VERSION
ip-172-31-10-88   Ready    master   65m   v1.19.2+k3s-6b11d860


⚠ Bofrost.de has degraded performance

In 7cf28fd, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1440 ms

Resolved: Bofrost.de performance has improved in 0f447a9 after 2 hours, 16 minutes.


[Bug] be使用ipv6地址，进行ssb压测时，全部挂掉

Search before asking

[X] I had searched in the issues and found no similar issues.

Version

version, 测试过2.1.5 3.0.1 版本

hosts 配置信息

3409:8d20:1833:da29::19 DORIS-CMCC-001
3409:8d20:1833:da29::11 DORIS-CMCC-002

添加 BE，也有配置 enable_fqdn_mode = true

ALTER SYSTEM ADD BACKEND "DORIS-CMCC-001:9050";
ALTER SYSTEM ADD BACKEND "DORIS-CMCC-002:9050";

执行 ssb 压测， https://doris.apache.org/docs/benchmark/ssb

在执行过程中，后端BE会挂掉

日志

fe-001.log.tar.gz
be-001.log.tar.gz
be-002.log.tar.gz
How to Reproduce?
No response
Anything Else?
No response
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hello, if it is convenient to add my wechat, we will have a look together, my wechat signal is: Liyy_222_8993

Explain the above questions:
brpc does not support ipv6 hostname resolution, resulting in connection initialization failure, nullptr is returned.
Calling get_client without checking nullptr results in coredump.
This PR fixes the nullptr check : https://github.com/apache/doris/pull/40074

Explain the above questions: brpc does not support ipv6 hostname resolution, resulting in connection initialization failure, nullptr is returned. Calling get_client without checking nullptr results in coredump. This PR fixes the nullptr check : #40074

好的，等新版发布之后，我验证一下


Add opaque table overlay during wire:loading

A UI tweak to improve the perceived responsiveness of tables.
The effect is the same as can be seen here

Can you please add a $table->loadingOverlay() ($this->hasLoadingOverlay, $this->hasLoadingOverlay()) configuration option to enable this, disabled by default. Also some documentation.
Some people like the fact that you can interact with the table while it is loaded.

Also, please merge in 3.1 into your branch.

@danharrin Sure. Just checking out the codebase for the best place to implement this. A new trait? If you can point me to an existing trait / whatever that follows the approach you're talking about, I'll use that as a reference.

Like CanDeferLoading

@danharrin Updated. Although I'm not sure if the Filament\Tables\Concerns\HasLoadingOverlay trait is necessary? Things work fine with just the Filament\Tables\Table\Concerns\HasLoadingOverlay trait.
Do you want me to extract the overlay to a separate component? It's only used in 2 places (the table and grid views). If so, let me know where I should put it / name it.

@binaryfire, could you provide a screen recording showing this change?
I'm not too sure about it yet for a couple reasons.
One being the fact that this may get in the way of other loading indicators/states if we decide to reintroduce any in the future (if performance issues allow us to...).

@zepfietje No problems. This is something I'm really missing after migrating from a Vue SPA. On medium / slow connections (and even fast high latency connections) there's no feedback that anything is happening after changing something on a table. It makes the whole app feel unresponsive.
Here's a couple of videos showing the overlay on a throttled connection.
Table: https://www.youtube.com/watch?v=WrMOxbz85vU
Grid: https://www.youtube.com/watch?v=AvXsCn15iq8
All the other datatables packages I've used have something along these lines.

Works nicely for search too

Thanks, @binaryfire.
Would this be more performant than the per-row loading skeleton we had in v2, @danharrin @pxlrbt?
I'm ok with reintroducing a default loading state, as long as it doesn't cause performance issues again.
Just want to make sure we've thought this through before merging.
From your videos, the first thing that comes to mind is we need the overlay to have a pulse animation. Otherwise it's still just a static layer which doesn't add much feedback.

@zepfietje Yeah it definitely is more performant. I intentionally went for an overlay rather than a per-row option for that reason. You're only changing a single class rather than a class-per-row. The overhead with this is almost zero.

@zepfietje Is there any benefit to per-row indicators though? All those actions (searching, sorting, pagination) modify the entire table. I'm not sure what the extra complexity would bring and showing multiple indicators would look a bit strange IMHO.
Regarding adding a circle or pulse- that'd be easy. We can just center it in the overlay and perhaps make it optional via a named argument.

Loading skeleton with rows provides a better UX in my opinion.
Also, that'd allow for a nice loading state without too many visual jumps for deferred table loading.
Not saying it's the final solution, but we should definitely explore it in this PR.

Ok no worries. Maybe someone else can offer some insights. I couldn't think of any performant per-row options tbh.
Adding / removing classes per-row is going to need JS diffing so it'll incur a performance penalty. And I don't think you can add divs to
 elements, so the only way to add individual row overlays that could be made visible by toggling a single class would be adding a div to each cell. That'd create different performance issues because of the resulting dom size.

We could target the rows from the parent table element with Tailwind using something like [&_tr]:bg-red-500?

I'm not familiar with that syntax. Is that Sass?
Something like this might work:

But there's no overlay / placeholder, so you'd have to manipulate the
 styles via .loading-active .loading-state
Another option could be adding a pseudo-element to each cell as an overlay. Pretty sure that would work with s (as opposed to
's):
@keyframes pulse {
  0% {
    opacity: 0.5;
  }
  50% {
    opacity: 1;
  }
  100% {
    opacity: 0.5;
  }
}

.loading-state td::after {
  content: '';
  display: none;
  position: absolute;
  top: 10%;  /* inset from top edge */
  left: 10%; /* inset from left edge */
  right: 10%; /* inset from right edge */
  bottom: 10%; /* inset from bottom edge */
  background: #E0E0E0; /* Grey background for skeleton loader */
  z-index: 1;
  border-radius: 10px; /* rounded edges */
  animation: pulse 1.5s ease-in-out infinite; /* Add pulse animation */
}

.loading-active .loading-state td::after {
  display: block;
}

.loading-active .loading-state td > * {
  visibility: hidden; /* hide contents of underlying cell */
}

This is just pseudo-code, I'd have to play around to see if it would work. It means that instead of a bar across each row, we'd have smaller bars across each cell. But you're relying on the browser's CSS engine to render the changes which should be way faster than JS. There's no dom modifications going on and it's GPU-accelerated.
I can give it a shot if you'd be happy with that UI outcome.

Should we remove the ->loadingOverlay() option if we get the cell option working and just make it default?

Works pretty well. Haven't tested this with loads of records but it's pure CSS so it shouldn't have any noticeable performance impact: https://www.youtube.com/watch?v=M9pTeiAzthw
The same pseudo-element is applied to all cells so I had to find generic one-size-fits-all padding settings. It means the loading skeletons won't line up perfectly with the column headers, but they get pretty close.
I haven't pushed an update for this yet- let me know what you think and I'll tidy it up and push it up tomorrow.

We removed the loading skeleton in v3, since the performance sending all of those elements over the wire, and diffing them in the browser, was staggering. I'd rather not re-introduce that please.

@danharrin Hey Dan, have you taken a look at this PR? It's not doing any of that. This is a pure CSS solution without any of those performance issues.

@danharrin Actually sorry, I haven't pushed it yet :) Will do it tomorrow and you can have a look

@pxlrbt @danharrin @zepfietje That's what I've done (CSS indicators).
Just pushed the changes. They're inline in table.blade.php atm and should be extracted to a css file but it's enough to give you an idea.
Video of the result: https://www.youtube.com/watch?v=M9pTeiAzthw

I don't think we really need a method to enable it. If it's working performance wise, it should be fine. I think we should introduce a new class .fi-ta-cell-content though that wraps the content itself so we can target that with the loading state. The top: 35% solution sounds hacky as it doesn't really account for image and icon columns and probably also others.

@pxlrbt Yeah good call. I'll make those changes tomorrow.

Updates:

Removed HasLoadingOverlay configuration traits
Wrapped action and column cell content in .fi-ta-cell-content instead of targeting all  elements
Tested with loads of records, didn't notice any difference in performance 🎉

Wrapping the content was a good idea. The indicators line up perfectly with the column headers and the checkboxes are no longer affected (they turn grey during loading anyway).
Video: https://www.youtube.com/watch?v=5rMZurkIGjw
The CSS needs to be extracted from table.blade.php but not sure where to put it. There's currently no css dir or Tailwind config file in the tables package.
Haven't played around with the grid view yet, will do that soon.

Nice work, @binaryfire.
Really like the direction.

By the way, I think we should also look into column specific loading indicators (like a different skeleton for icon columns for example).

@zepfietje Don't think we need different skeletons if we have the .fi-ta-cell-content class that wraps the actual content without any padding etc.

Yeah maybe we won't use it eventually, but it's nice to explore it I think.
Like having circular images actually show circular skeletons.

@zepfietje @pxlrbt Hey guys. Added logic for the grid layout: https://www.youtube.com/watch?v=3vBDq2chgCA
I've taken this as far as I can- hopefully one of you can tweak it. The rest is a UI/UX CSS thing which isn't my strength. Pseudo-elements cover the entire size of the element they're ::after so you need to know exactly what to wrap with .fi-ta-cell-content to make things look right. I'm just pulling at threads now eg. I removed the padding from the overlay and it looks fine on grid but now it's taking up the full height of table rows.
Summary so far:

Added .fi-loading to table and grid parent elements when wire:loading

CSS is currently in container.blade.php and needs to be extract and refactored to use @apply

Added fi-ta-cell-content in various places to swap out content for the loader when loading.

Cool, @binaryfire!
We could also handle the loading skeleton on a per-column basis using Tailwind CSS classes like [.fi-table.fi-loading_&]:after.
I think I prefer that, since it keeps styling in the component view files, and allows for easier customization per component. Not sure how much bigger the DOM would get though.

No worries! This was one of the main things I've been missing since moving from Vue :) Glad we've found a solution.
Any CSS-based should be fine performance-wise. As long as you're not adding/remove classes dynamically with Livewire or Alpine (other than 1 or 2 on the parent elements) it'll be fast.

Hey @danharrin. Yeah the styling isn't right in its current state. Your suggestion sounds good- there are probably many other ways to approach it too. I'm not great with CSS and UI (personally I'd be happy with the original simple overlay lol). I suggest asking @zepfietje or @pxlrbt. Someone with good CSS chops should be able to make it look right.

Are there still plans to implement some version of this? If not, I think the original optional overlay would be a good alternative? Waiting for tables to change on high latency connections with no feedback feels like the app has frozen.

Whoops, I didn't mean for it to close

I don't think I can reopen it, can you? Target 3.x

"Allow edits by maintainers" got unchecked when it was closed. I just rechecked it - can you re-open it now?
Can't see a way of re-opening it on my end.

@danharrin Or maybe this: https://github.com/gitbucket/gitbucket/issues/378#issuecomment-789511309

I think you need to make a new PR from the same branch


feat(wandb): improve log of functions

Name of functions is now much nicer.

Legend:

top -> new version
bottom -> previous version

Thanks!


Added corn in butter

About the PR
Added corn in butter and increased the cooking time of popcorn.
https://github.com/space-wizards/space-station-14/assets/123451459/a6912bd9-9823-4ad5-93ba-44544b124ac8
Why / Balance
Just a new dish for a greater variety of dishes.
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
:cl: Just_Art

add: Added corn in butter.
tweak: Increased popcorn cooking time.

what is corn in butter lol

freedom :us:

also you should edit the rsi copyright, dont think this is in tg

Local tests are ok


[bug] replace does not work on Python playground

rule:
  pattern: '$A = lambda: $B'
fix:
  '$A + $B'

Superseded by #405


pcr-branch-table.py Runtime Error IDA Pro 7.2

undefined function __loaders__pcr-branch-table.accept_file

Looks like you put pcr-branch-table.py in your loaders directory. pcr-branch-table.py is a different IDA script, not a loader. Only smd_sg.py should be placed in your loaders directory (per the README)

Also, I don't know if these scripts will work with IDA 7.2. They are written in Python 3, which I think was added in 7.4?


Refactor Facet struct

Codecov Report
Patch coverage: 94.54% and project coverage change: +9.23% :tada:

Comparison is base (129cb18) 77.41% compared to head (467c0d2) 86.65%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
+ Coverage   77.41%   86.65%   +9.23%
==========================================
  Files           7        8       +1
  Lines         465      502      +37
==========================================
+ Hits          360      435      +75
+ Misses        105       67      -38

Files Changed
Coverage Δ

src/AsteroidThermoPhysicalModels.jl
100.00% <ø> (ø)

src/facet.jl
91.96% <91.22%> (+20.81%)
:arrow_up:

src/shape.jl
97.87% <96.15%> (+47.87%)
:arrow_up:

src/TPM.jl
100.00% <100.00%> (ø)

src/roughness.jl
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Error for installation using pip on win10

I followed the instruction as below:
pip install torchaudio -f https://download.pytorch.org/whl/torch_stable.html
or
pip install torchaudio
but got the error:

Looking in links: https://download.pytorch.org/whl/torch_stable.html
Collecting torchaudio
  ERROR: Could not find a version that satisfies the requirement torchaudio (from versions: none)
ERROR: No matching distribution found for torchaudio

Anyone can help me to fix it?

See https://github.com/pytorch/audio/issues/50 for details.

I am getting same error.


Refactor UpdateDeployment

I attempted to reduce the complexity of the #perform method by relying
on the class to encapsulate its dependencies.  Since this class is only
used to call #perform once, this is similar to extracting a method
object for the #perform method.  All unit tests pass.  I made all the
new methods private to prevent clients from calling them directly.  I
also made an attempt to order them by relevance, though I am open to
suggestions for reordering.  This class has a lot of responsibility and
in future refactorings it might be a good idea to break it up into
smaller objects with fewer responsibilities.

I went over this with @jaresty when we were community pair and talked through some of the design decisions and agreed with them. I really like the idea of extracting smaller portions of logic into digestible functions and then making the "main" function essentially a large composition of helper methods, especially considering so many of these dense classes are difficult to reason about and keep a working mental model of their logic.
I don't feel comfortable merging this PR with him because I think other people on the team should have a chance to look at it and ask questions if they have any, so I'll let someone else merge it in.

Looks much better to Max and me! We are big fans. Dragging it into the prioritization section of the backlog to give other people a chance to look at it and a pair to properly run integration tests on it.

Overall it looks good and I do like the change into smaller components. Some parts feel like they can still be broken down or even moved to their own class.


Get API key and TAC Accept from Environment

Use JBX_API_KEY and JBX_ACCEPT_TAC environment variables to pass the Key and agree to the TAC, instead of modifying the jbxapi library file.

Released v3.4.0 with this change. Thanks for the pull request!


Fix a crash when extracting album art

The crash happened when the album path contains non ascii characters (like äöü). I'm not sure if the solution I implemented is the best way to get around this...

Thanks for catching this bug, and for including a test!
I have two comments on the fix:

To make Unicode errors due to inconsistency go away, there are two choices: lift everything to Unicode or lower everything to bytes. It looks like you've chosen the former, but the standard in beets is the latter: paths should always be byte strings. Can you check whether this will work if you instead just encode filename to bytes and then combine it with album.path as it is?
I think this is a regression from unicode_literals that was not present in the previous release, so we don't actually need a Changelog entry.

Sorry for the delay. I changed as you suggested (hopefully :wink:) and it's still working as expected. I'm a bit unsure about the way I did the conversion: I used the bytestring_path helper method of the util module.

Looks great; thanks! If you feel like it, there's now a a = a + b that could go back to being a += b, but that is non-urgent.

Oops! I missed that something is wrong on Py26: https://travis-ci.org/sampsyo/beets/jobs/51269255
Can you please look into the test failure? I'm not totally sure what's up with it...

Hmm, that's strange. If you look at https://travis-ci.org/sampsyo/beets/builds/51265874, everything is fine. The only thing I changed with the second commit is the changelog. I'd guess, this should not break the test :smile:.
Do you (or anybody else) have a hint for me where to start to search for a solution?

There's definitely a random side to it:

when I run it locally with tox it fails most of the time
when I run it locally in a python 2.6 virtualenv it never seems to fail

Maybe it's concurrency-related?

Found: the art in image.mp3 is sometimes a png image →gives extracted.png, or a jpeg image → gives extracted.jpeg and the test fails.

$ ffprobe test/rsrc/image.mp3
[...]
    Stream #0:1: Video: mjpeg, yuvj444p(pc, bt470bg/unknown/unknown), 2x3 [SAR 72:72 DAR 2:3], 90k tbr, 90k tbn, 90k tbc
    Metadata:
      title           : the artist
      comment         : Artist/performer
    Stream #0:2: Video: png, rgb24, 2x3 [SAR 2835:2835 DAR 2:3], 90k tbr, 90k tbn, 90k tbc
    Metadata:
      title           : album cover
      comment         : Cover (front)

There are 2 images in this mp3, one png and one jpeg. MediaFile.art seems to pick one arbitrarily - and randomly on python 2.6.
Easy solutions for that test:

remove the jpeg stream from image.mp3 (not really a good idea, and it would break some mediafile tests)
expect extracted.* and not .png (probably sufficient for now)
use another audio test file

This raises the problem of using Mediafile.art instead of Mediafile.images which would be better suited. However that raises several questions for the embedart plugin.

Great! Thanks for you help! I tend to change the test so it expects extracted.*.

I've changed the test case so it searches for extracted.[png|jpeg|jpg].


Retrieve runner registration tokens using a shell command

Summary
Currently, to retrieve registration tokens used by runners, you need to connect to gitlab-ci web interface. It would be nice to retrieve registration token directly on shell using command line.
Step to reproduce

go to gitlab-ci install directory
grep -R REGISTRATION_TOKEN * (where REGISTRATION_TOKEN is the registration token you get on the web interface)
the token is not found

Expected behavior
To have a command to retrieve runner next registration token, in order to be able to automate runners installation process and be able to use configuration management tools such as puppet, chef or ansible to install gitlab-ci and gitlab-ci-runners.
Relevant logs and/or screenshots:
Token seems to be generated in config/initializers/2_app.rb, at line 4 :
RUNNERS_TOKEN = SecureRandom.hex(10)

Possible fixes

When generating token, save it on a file that can be greped.
Add a command to retrieve token

+1 for this.

+1 for this

Hi
I have exactly the same need
Is it possible in the latest release to retrieve the registration token programmatically ?
Thanks
Damien

+1 please fix this

This project is deprecated, please use https://gitlab.com/gitlab-org/gitlab-ci-multi-runner instead.

gitlab.com is sooooooooo slow since moving it to Azure though @axilleas - it was fine before that but now, loading https://gitlab.com/gitlab-org/gitlab-ci-multi-runner/issues/new?issue[assignee_id]=&issue[milestone_id]= to create a new issue for this took 30 seconds!
Azure's disk IO performance so incredibly bad it's not really surprising, just like AWS everyone is having to employe people to build tools to work around their MITM oh sorry, I meant 'cloud''s problems.

Seriously though, it's such a put off for logging bugs and its not Gitlab's (as a product) fault - it's the platform underneath.
But yes I do understand Microsoft's dirty little lock-in / advertising trick of giving free cloud monies for ycombinator backed projects - still though, Azure isn't trustworth (unless you like SHA-1's issues by bluecoat oh I mean Symantec, oh I mean Blue Coat... oh I mean... you get the point.

created again on gitlab's bug tracker: https://gitlab.com/gitlab-org/gitlab-ci-multi-runner/issues/1727

Lol, thank you @vincentdoba :heart:


Implementation for Blazor (Server-Side)

Hi Timothy!
It's great what you have accomplished so far with this middleware.
For people who doesn't work with MVC apps do you have any workaround for Blazor apps?
I'm kinda struggling on this part (idk what to do on the razor page).
@using (Html.BeginForm("SomeMethod", "SomeController")) {   @(Html.Recaptcha<RecaptchaV2Checkbox>(RecaptchaSettings?.Value)) }
Thanks in advance!

Hi, i can't commit to this library supporting Blazor at this time. Further i personally have absolutely no experience dealing with Blazor. That all being said. If you can't use the MVC helper in the razor page you always try calling it directly via the helper class as it's static.
var html = RecaptchaHelper.Recaptcha<RecaptchaV2Checkbox>(RecaptchaSettings?.Value);

You can then use whatever method Blazor uses for sending client side html to the user by passing it the HtmlString in the html variable.
Further, you can create an instance the RepcaptchaService class and call it's methods directly rather than depending on an attribute. I can't say i recommend, or support this.


Scheduled Jobs: saving error logs only (Task #6652)

To prevent too much logging, we only store error logs.
To know when the script ran last time, we store last_run_date on the scheduled job record.

Codecov Report

Merging #573 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master     #573      +/-   ##
============================================
- Coverage     25.49%   25.46%   -0.03%
- Complexity     1023     1024       +1
============================================
  Files            89       89
  Lines          3405     3408       +3
============================================
  Hits            868      868
- Misses         2537     2540       +3

Impacted Files
Coverage Δ
Complexity Δ

src/Shell/CronShell.php
0% <0%> (ø)
12 <0> (+1)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46c2098...43b76b8. Read the comment docs.