Incorrectly removing async from extern "C" blocks

Describe the bug
When running rustfmt async is removed from my functions:
To Reproduce
Add any extern block with async, run cargo fmt and the async will be removed:
#[wasm_bindgen(module = "clock")]
extern "C" {
    #[wasm_bindgen]
    async fn strike_thirteen();
}

becomes
#[wasm_bindgen(module = "clock")]
extern "C" {
    #[wasm_bindgen]
    fn strike_thirteen();
}

Expected behavior
My async stays
Meta

rustfmt version: 1.4.15-stable
From where did you install rustfmt: rustup
How do you run rustfmt: cargo fmt (also VSCode + rust-analyzer)

Thank you for the report @pauldorehill. This is a duplicate of #4288 that's already been addressed in source but just hasn't been released yet. Closing accordingly

Ah apologies... I only searched open

No worries! We've got quite a lot of unreleased changes on the master branch, and myriad associated issues that have been closed, so it can be trickier than usual to tell sometimes. Thanks again for reaching out!


Add test suite guidance to documentation

Add test suite descriptions to the documentation. This is intended to provide developers with a sense for how to design their tests for a particular suite and which suite to add test cases to.
Checklist

[X] Developer's Guide has been updated
[X] Documentation has been built locally and changes look as expected

@xylar, @alicebarthel, @lconlon, @mark-petersen and others: I'm hoping that this PR can serve as a discussion board for what our test suite philosophy is (especially for OMEGA). I put in some placeholder text for how many cores and what duration we expect for PR and nightly suites. We also talked about creating a release suite, which is not included here but could be.
@matthewhoffman and @trhille Right now, this is in a general section of the docs which implies that it applies to MALI testing too. MALI folks could weigh in if there is a similar testing philosophy, or I could make it clear that this only applies to ocean testing.

@mark-petersen @lconlon @trhille I've removed you as reviewers since we've gotten 3 reviews so far but you are still welcome to provide feedback if you like.

Thanks, @alicebarthel and @matthewhoffman, for giving this a look!

@cbegeman, I'll merge this though I had assigned it to you previously, which means you are the one with the power (and expectation) to merge it.

@cbegeman, no problem.  I just wanted you to know what the typical expectation is with who the PR is assigned to.  That's not necessarily obvious.


Chatterino Nightly Debian/Ubuntu does nothing.

Checklist

[X] I'm reporting a problem with Chatterino
[X] I've verified that I'm running the most recent nightly build or stable release
[X] I've looked for my problem on the wiki
[X] I've searched the issues and pull requests for similar looking reports

Describe your issue
I install using the .deb file. I've tried both versions of the install, and nothing happens. No icon, no binary to execute in the terminal.
Screenshots
No response
OS and Chatterino Version
Chatterino 2.3.5 (commit 9583b4965 modified) built with Qt 5.15.2 Running on Debian GNU/Linux 11 (bullseye), kernel: 5.10.110-15808-ge5740beba59b

Sorry the deb package is fucked. I've not been able to fix it properly. Try the other build system (qmake vs cmake), one works more than the other. I've honestly been thinking of just deleting ubuntu/debian packaging.
Duplicate of #3245.


The remote server returned an error: (403) Forbidden

Ran PowerShell script and getting the following error after authenticating using weblogin
Apply-PnPTenantTemplate : The remote server returned an error: (403) Forbidden.
At C:\Users{usrname}\OneDrive\SACHA\RnD\setupSitedesignStudio.ps1:25 char:1

Apply-PnPTenantTemplate -Path .\SiteDesignsStudio.pnp -Parameter @{Te ...

  + CategoryInfo          : NotSpecified: (:) [Apply-PnPTenantTemplate], WebException
  + FullyQualifiedErrorId : System.Net.WebException,SharePointPnP.PowerShell.Commands.Provisioning
 .Tenant.ApplyTenantTemplate

Successfully setup with out using weblogin.

Getting same error if not using -WebLogin in a tenant without MFA.
In a tenant with MFA, I am getting the same 403 Forbidden error.
What is the fix here?
At https://github.com/pnp/sp-site-designs-studio, you say.
"API Permissions
In order to allow the lookup of users and groups in the current tenant, The permission Directory.AccessAsUser.All to Microsoft Graph API is requested.
CAUTION: The solution is installed globally on the tenant, it means this permission, when granted, will be granted to the whole tenant. However, it will allow the application to only see the groups and users the current user is allowed to see. Thus, it should not cause any security breach. It will only be needed for the ability to grant Site Designs to specific principals. The other features will be working seamlessly without this granted permission."
But it seems a MFA issue to me.
Can you help?

Hello,
Indeed, it seems to have several issues with MFA, I initially added the options for MFA, leveraging WebLogin option... but it turns out that this authentication method has several caveats in PnP PowerShell... :(
I will do my best to provide a workaround guide for MFA forced tenants using app principal authentication :)
Stay tuned!
Regards,
Yannick


Update README.md

At least in my case I needed python to built the project.

Thanks - this is needed by libopencm3 👍


Merge Main into RustLayout

The HelloWorld standalone project changed a lot of files and moved them around. How come I don't see those changes here?

Yep, all looks good.


feat: add useStorage

Description
Add useStorage, which is simpler and more direct compared to useStorageAsync and is used more often in daily scenarios.

I think there's still a serious problem with not listening for storage changes. That's why I didn't introduce the useStorage method before, uni-app doesn't provide an API to handle this kind of listening.
Suppose a user uses useStorage to get the data with key test in page A, then opens page B, then uses useStorage to get and modify the data in page B, and then returns to page A. Is the data with key test held by the user in page A new or old? From the code, it looks like it's still old. I'm concerned that this will result in a bad experience.
What do you guys think? Will be nice to listen to your thoughts! @okxiaoliang4 @edwinhuish

我认为应该跟useStorageAsync共用一份核心代码，因为差别就只有是否是异步的，监听逻辑我认为也应该类似于useStorageAsync目前使用的拦截器，因为拦截器可以拦截到开发者直接使用uni storage进行更新的情况，并且在H5的时候可以考虑直接内部改用vueuse/core中的useStorage这样可以做到多个窗口同步数据

我认为应该跟useStorageAsync共用一份核心代码，因为差别就只有是否是异步的，监听逻辑我认为也应该类似于useStorageAsync目前使用的拦截器，因为拦截器可以拦截到开发者直接使用uni storage进行更新的情况，并且在H5的时候可以考虑直接内部改用vueuse/core中的useStorage这样可以做到多个窗口同步数据

The code in uni-use useStorageAsync is too outdated compared to the latest code in vueuse. The new useStorage I submitted actually aligns with the useStorage in vueuse. I think it's necessary to update the old useStorageAsync to make it consistent with the latest useStorage code.

I think there's still a serious problem with not listening for storage changes. That's why I didn't introduce the useStorage method before, uni-app doesn't provide an API to handle this kind of listening.
Suppose a user uses useStorage to get the data with key test in page A, then opens page B, then uses useStorage to get and modify the data in page B, and then returns to page A. Is the data with key test held by the user in page A new or old? From the code, it looks like it's still old. I'm concerned that this will result in a bad experience.
What do you guys think? Will be nice to listen to your thoughts! @okxiaoliang4 @edwinhuish

Listen for the storage changes will cause very impactful on performance.
I think the code are fine, but need some impove:

Add a key prefix, to make sure it won't confused with other keys which access directly to storage.
Add debounce to write storage
Store all values to a reactive/ref variable, for some case like below:

Page A

const store = useStorage('store_key', 'foo');

store.value = 'bar';

console.log(store.value); // bar

Page B

// Call useStorage with key 'store_key', will access directly from local variable in 'useStorage' context
const store = useStorage('store_key', 'foo');

console.log(store.value); // Here should be also 'bar'.

Also, I'm agree with @okxiaoliang4 , useStorageAsync and useStorage should be use same code. If useStorageAsync outdated, then renew it.

I think there's still a serious problem with not listening for storage changes. That's why I didn't introduce the useStorage method before, uni-app doesn't provide an API to handle this kind of listening.
Suppose a user uses useStorage to get the data with key test in page A, then opens page B, then uses useStorage to get and modify the data in page B, and then returns to page A. Is the data with key test held by the user in page A new or old? From the code, it looks like it's still old. I'm concerned that this will result in a bad experience.
What do you guys think? Will be nice to listen to your thoughts! @okxiaoliang4 @edwinhuish

Listen for the storage changes will cause very impactful on performance.
I think the code are fine, but need some impove:

Add a key prefix, to make sure it won't confused with other keys which access directly to storage.
Add debounce to write storage
Store all values to a reactive/ref variable, for some case like below:

Page A
const store = useStorage('store_key', 'foo');

store.value = 'bar';

console.log(store.value); // bar

Page B
// Call useStorage with key 'store_key', will access directly from local variable in 'useStorage' context
const store = useStorage('store_key', 'foo');

console.log(store.value); // Here should be also 'bar'.

Add a key prefix, to make sure it won't confused with other keys which access directly to storage.

The key for userStorage is defined by the user themselves; we can't define its prefix, nor can we control it.

Add debounce to write storage

  const { pause: pauseWatch, resume: resumeWatch } = pausableWatch(data, () => write(data.value), {
    flush,
    deep,
    eventFilter,
  });

function update(event?: StorageEventLike) {
    if (event && event.storageArea !== storage) return;

    if (event && event.key == null) {
      data.value = rawInit;
      return;
    }

    if (event && event.key !== key) return;

    pauseWatch();
    try {
      if (event?.newValue !== serializer.write(data.value)) data.value = read(event);
    } catch (error) {
      onError(error);
    } finally {
      // use nextTick to avoid infinite loop
      if (event) nextTick(resumeWatch);
      else resumeWatch();
    }
  }

The pausableWatch function in vueuse already allows for pauseWatch(). With frequent updates to a large amount of data in localStorage, there's no longer a need to worry, and no need for debounce anymore.

Store all values to a reactive/ref variable, for some case like below:

I tested again, referring to your code, and there were no issues. The mini-program also passed the test. My code is as follows:
// pageA
const store = useStorage('store_key', 'foo');

const changeTest = () => {
  store.value = 'bar';
  console.info(store.value) // bar
};

const toNext = () => {
  uni.navigateTo({
    url: "/pages/pageA",
  });
};

<button @click="toNext">{{ store }}</button>
<view>{{ store }}</view>

const store = useStorage('store_key', 'foo');

const changeTest = () => {
  store.value = String(new Date().getTime());
  console.info(store.value) // bar
};

const toPrev = () => {
  uni.navigateBack({
    delta: 1,
  });
};

<button @click="toPrev">{{ store }}</button>
<view>{{ store }}</view>

Moreover, I believe the useStorage function should only be defined once in /stores/xx, similar to Pinia. It shouldn't be redundantly redefined across multiple pages with default values given. Even with such redundant definitions, the above code can still pass the test.

Also, I'm agree with @okxiaoliang4 , useStorageAsync and useStorage should be use same code. If useStorageAsync outdated, then renew it.

The code I submitted for useStorage is 90% similar to the latest code in vueuse's useStorage. Except for replacing UniStorage and custom events, the code is almost identical to the latest in vueuse. Why can't we let useStorage pass the test and stabilize before updating useStorageAsync? I think the closer we get to the latest version of vueuse, the fewer mistakes we can make.

我认为应该跟useStorageAsync共用一份核心代码，因为差别就只有是否是异步的，监听逻辑我认为也应该类似于useStorageAsync目前使用的拦截器，因为拦截器可以拦截到开发者直接使用uni storage进行更新的情况，并且在H5的时候可以考虑直接内部改用vueuse/core中的useStorage这样可以做到多个窗口同步数据

I don't believe useInterceptor is the only solution; custom events can also solve the issue. The essence of updating here and then notifying other pages to update is fundamentally just a function call, as I understand it.

key prefix is something like:

const prefix = '__UNI_STORAGE__';

function useStorage({ key: string }) {
  function read() {
    const keyWithPrefix = prefix + key;
    const raw = storage.getItem(keyWithPrefix);
    return JSON.parse(raw);
  }

  // Same for write()
}

When some on use this function in one page and unfortunately also access storage with same key in another page.
Page A
const store = useStorage('user');

// Another code....

Page B
// Set value to storage with same 'key' (At least it looks the same) will not affect the 'store' variable of page A
const user = storage.setItem('user',  ‘john’);

In my understanding, useStorage most important thing is "persistedstate", and should simplify the user's job. It will not like pinia, and shouldn't.
It should be something take and use.

I never use pausableWatch before.
After read the doc and code, it's not the one I mean Add debounce to write storage. The code of pausableWatch seems a little complicate. I prefer the normal debounce way ( setTimeout ), it's good enough and the important things is, it can effectively control the frequency of writing data to storage, it can effectively improve the performance.
My suggestion: if simple code can work well, don't import third part code. It will make the things complicate.

The third point "Store all values to a reactive/ref variable", just I'm saying before, useStorage should be something simple and easy to use.
And should avoid possible mistake of user.

I tested again, referring to your code, and there were no issues

Because you access the data with difference page, and reloaded data from storage. You can try it with same page but difference components.

In my understanding, useStorage most important thing is "persistedstate", and should simplify the user's job. It will not like pinia, and shouldn't.
It should be something take and use. Also can be paired with pinia.
In your code way, it's better to use pinia, and it's already very reliable.

You should check how to use useLocalStorage. It's chosen here because it's effective for data that stays stored. I know Pinia also has plugins for persistent storage. Otherwise, what's the point of this repository? Just to offer more options to users?

I tested again, referring to your code, and there were no issues

Because you access the data with difference page, and reloaded data from storage. You can try it with same page but difference components.

I've already said above, the problem isn't big, it's seldom used this way.
useLocalStorage must be used like Pinia. Otherwise, might as well directly use uin.storage.

I think there's still a serious problem with not listening for storage changes. That's why I didn't introduce the useStorage method before, uni-app doesn't provide an API to handle this kind of listening.
Suppose a user uses useStorage to get the data with key test in page A, then opens page B, then uses useStorage to get and modify the data in page B, and then returns to page A. Is the data with key test held by the user in page A new or old? From the code, it looks like it's still old. I'm concerned that this will result in a bad experience.
What do you guys think? Will be nice to listen to your thoughts! @okxiaoliang4 @edwinhuish

the stores/userInfo.js
export const userStore = useStorage("x-userStore", {
    num: 0,
    deep:{
       a: 1
    }
});

pageA
import { userStore } from "@/stores/userStore";
const toNext = () => {
  uni.navigateTo({
    url: "/pages/pageB",
  });
};

<button @click="toNext">userStore num is {{ userStore.num }}</button>
<button @click="toNext">userStore deep.a is {{ userStore.deep.a }}</button>

pageB
import { userStore } from "@/stores/userStore";
const toNext = () => {
  uni.navigateTo({
    url: "/pages/pageA",
  });
};
const change = () => {
    userStore.value.num += 1;
    userStore.value.deep.a += 1;
}
<button @click="change">userStore num ++ {{ userStore.num }}</button>
<button @click="change">userStore deep.a ++ {{ userStore.deep.a }}</button>
<button @click="toPrev"> to page A</button>

I have already tested the code above, and there are no issues. You can give it a try @ModyQyW . Thanks

I think there are some misunderstandings. In pageB, it should be uni.navigateBack() but not uni.navigateTo.

我认为应该跟useStorageAsync共用一份核心代码，因为差别就只有是否是异步的，监听逻辑我认为也应该类似于useStorageAsync目前使用的拦截器，因为拦截器可以拦截到开发者直接使用uni storage进行更新的情况，并且在H5的时候可以考虑直接内部改用vueuse/core中的useStorage这样可以做到多个窗口同步数据

我感觉 H5 直接内部改用 @vueuse/core 中的 useStorage 可能不太好，会带来额外的心理负担。
useStorageAsync 目前使用的拦截器不支持同步 api，所以这应该是目前最大的困难。

我认为应该跟useStorageAsync共用一份核心代码，因为差别就只有是否是异步的，监听逻辑我认为也应该类似于useStorageAsync目前使用的拦截器，因为拦截器可以拦截到开发者直接使用uni storage进行更新的情况，并且在H5的时候可以考虑直接内部改用vueuse/core中的useStorage这样可以做到多个窗口同步数据

The code in uni-use useStorageAsync is too outdated compared to the latest code in vueuse. The new useStorage I submitted actually aligns with the useStorage in vueuse. I think it's necessary to update the old useStorageAsync to make it consistent with the latest useStorage code.

Good point. PR welcome.


use poetry to manage deps, add py38 tests

this is probably not going to work... poetry wants to always use the poetry.lock file
which means having that file checked in while supporting multiple versions of python with differing requirements does not really work


Grade First Homework

@mattkwiecien

Hi @Swissler5 ! Before I submit your final grade, can you close your original issue to create your first homework? Once you do that and complete the the PR I open I'll enter your grade 😄


No bluetooth with Raspberry Pi 0 w

Wifi okay but no bluetooth on list.

This is likely not an issue with the bluetooth as such, but due to some reason headunit is not recognising the dongle as phone and not sending the accessory start request.
We start bluetooth only after the dongle receives an accessory start request indicating that the Android Auto is available and initiated from the headunit.
Which build did you try? If you used the build from release v0.1.1, try using one of the latest builds from main branch. There are some additional changes in main that makes it work on more headunits.
If that also doesn't work, try to collect some logs from the RPi using ssh.

This looks like a timeout issue, I'll try to find a solution to avoid the timeouts. Thanks for reporting.


[FEATURE]: Add vercel-pg driver to drizzle.config.ts + improve docs

Describe what you want

I am on Vercel PostgreSQL using @vercel/postgres which provides VercelPgDriver
Within drizzle.config.ts the driver does not accept any option like vercel-pg, only pg
I need to install pg additionally just for the Drizzle Studio, shouldnt it use @vercel/postgres as well?

This raises the following questions for me:

Shouldnt drizzle.config.ts use the same driver by either driver: vercel-pg OR a fully configured drizzle client drizzle(sql);?

Also it took me a while to figure out that from my local dev environment I need to use connectionString: process.env.POSTGRES_URL + '?sslmode=require' instead if host, user, etc. -> This is not documentated at all.
Related: #990
Update: Using Drizzle for a while I found out that more drivers are missing, e.g. neon or bun-sqlite but on the other hand it has platform specific drivers like turso and d1

Drizzle-Kit is now automatically choosing pg, @vercel/postgres or @neondatabase/serverless. Is anyone even aware of the open issues?
This one seems to fixed now.


Upstream naga_oil

naga_oil is a foundational crate for Bevy, but doesn't get enough love from community maintainers. We should include it in the monorepo so that it gets more care and attention. The crate was originally left out of the repo under the "useful to other external users" metric. However, since then, we have included other crates like bevy_color in the monorepo under and haven't seen uptake from external users that benefits naga_oil maintenence.
On the horizon, WESL promises to solve a lot of problems that we currently rely on naga_oil for. However, in the meantime, there are a number of important initiatives that would benefit from improvements made to naga_oil, including future initiatives like upstreaming bevy_hanabi and improvements to AsBindGroup that may require code generation strategies. Additionally, there are number of outstanding bugs ex. https://github.com/bevyengine/naga_oil/issues/54 that are more likely to get fixed if they live in our issue tracker.
Changes

History imported so we can have a record all the hard work @robtfm has done here.
The crate has been renamed to bevy_naga_oil so that its version can be reset to match the rest of the bevy crates.
Internal crates point to bevy_naga_oil.

Realizing that the squash merge will obliterate the history, unfortunately.

Thanks for all the copyediting @BenjaminBrienen! It's very much appreciated.

Realizing that the squash merge will obliterate the history, unfortunately.

If it's interesting to keep the history then someone with privileges could merge it instead?


Unable to use provider with api_user_service_key

Confirmation

[X] My issue isn't already found on the issue tracker.
[X] I have replicated my issue using the latest version of the provider and it is still present.

Terraform and Cloudflare provider version
Terraform v1.2.9
on linux_amd64
registry.terraform.io/cloudflare/cloudflare v3.24.0
Affected resource(s)

cloudflare_origin_ca_certificate

Terraform configuration files
# CLOUDFLARE_API_USER_SERVICE_KEY environment variable is given

terraform {
  required_version = "1.2.9"

  required_providers {
    cloudflare = {
      source  = "cloudflare/cloudflare"
      version = "3.24"
    }
  }
}

provider "cloudflare" {}

data "cloudflare_ip_ranges" "ips" {}

output "cloudflare_ip_cidrs" {
  value = data.cloudflare_ip_ranges.ips.cidr_blocks
}

Link to debug output
https://gist.github.com/mattmichal/7076354c10e4ae56c1524c4223a56ba7
Panic output
No response
Expected output
Provider is configured and data calls can be executed.
Actual output
** CLOUDFLARE_API_USER_SERVICE_KEY only
│ Error: error creating new Cloudflare client: invalid credentials: key & email must not be empty
│
│   with provider["registry.terraform.io/cloudflare/cloudflare"],
│   on providers.tf line 18, in provider "cloudflare":
│   18: provider "cloudflare" {}

Steps to reproduce

Set CLOUDFLARE_API_USER_SERVICE_KEY environment variable
Add cloudflare provider to a project
Execute plan operation

Additional factoids
My initial error was due to configuring both CLOUDFLARE_API_TOKEN and CLOUDFLARE_API_USER_SERVICE_KEY variables. An error is returned as expected due to the changes in #1907.
** CLOUDFLARE_API_TOKEN and CLOUDFLARE_API_USER_SERVICE_KEY
│ Error: Invalid combination of arguments
│
│   with provider["registry.terraform.io/cloudflare/cloudflare"],
│   on providers.tf line 13, in provider "cloudflare":
│   13: provider "cloudflare" {}
│
│ "api_token": only one of `api_key,api_token,api_user_service_key` can be
│ specified, but `api_token,api_user_service_key` were specified.

After seeing that PR and the 3.24.0 release notes, I removed the API token because the user service key is required in my production project due to references to cloudflare_origin_ca_certificate resources.
References
No response

this has already been addressed in #1923 and slated for the next release. if you'd like to use it now, you can build an unreleased version to use.

I confirmed that #1919 describes the same issue. It seems like I searched open issues and not closed issues when looking for existing reports.


gitignore ignores file: indexed_recordio_split.cc and indexed_recordio_split.h

If you download the repo and push it to another repo, you'll find dmlc-core/src/io/indexed_recordio_split.cc and dmlc-core/src/io/indexed_recordio_split.h are lost. I Checked it by inputting this command:
git check-ignore -v dmlc-core/src/io/indexed_recordio_split.cc

output:
.gitignore:30:*exe*     dmlc-core/src/io/indexed_recordio_split.cc

So there is a mistake in .gitignore line 30, *exe*. I Think *exe is good

Thank you for sharing, opened a PR to fix it https://github.com/dmlc/xgboost/pull/10854 .


Migration to Float type in the US region of demo server is causing error on data insertion

Describe the bug
The prisma demo servers are throwing an error when we migrate an Int field to a Float and try to insert data in it.
To Reproduce
Steps to reproduce the behavior:

Bootstrap a simple prisma project using the cli(choose US demo servers)
Add a field test: Int to the datamodel
Run prisma deploy
Change the type to Float and rerun the deploy
Try to insert some data with the createUser mutation

Expected behavior
Creation of the user should not result in an error
Screenshots

Log of the failing request from AWS

Versions (please complete the following information):

Connector: MySQL(Demo Server)
Prisma Server: Demo Server (ie latest beta 1.26-beta-1)
prisma CLI:
OS: macOS mojave 10.14.2

This is still happening @divyenduz

Can confirm. This goes both ways, including Float -> Int.

Easiest workaround for those facing this issue:

Remove field(s) in question; deploy
Add fields back in (with proper Int or Float type); deploy

I am no longer able to reproduce this


Make RequireJS work with can.import

Looks like there is already code: https://github.com/bitovi/canjs/pull/1396/files#diff-95ad04d772620344cfa50f85ba7adb64R96
I guess we just need a test to verify it is working?

It doesn't work.
Sent from my iPhone

On Feb 19, 2015, at 6:00 AM, Matthew Phillips<EMAIL_ADDRESS>wrote:
Looks like there is already code: https://github.com/bitovi/canjs/pull/1396/files#diff-95ad04d772620344cfa50f85ba7adb64R96
I guess we just need a test to verify it is working?
—
Reply to this email directly or view it on GitHub.

Interesting, is there an existing demo page or something to test with? Otherwise I'll create one.

There's a test page for steal's integration.
Sent from my iPhone

On Feb 19, 2015, at 7:46 AM, Matthew Phillips<EMAIL_ADDRESS>wrote:
Interesting, is there an existing demo page or something to test with? Otherwise I'll create one.
—
Reply to this email directly or view it on GitHub.

One issue is that we are importing can/view/stache/stache which for amd it should just be can/view/stache. This is only true of amd so I think we can just denormalize it in this one place.

I really don't like doing an amd check in autorender but can't think of a better way.

Yeah, this will be gone in 3.0
Sent from my iPhone

On Feb 19, 2015, at 9:01 AM, Matthew Phillips<EMAIL_ADDRESS>wrote:
I really don't like doing an amd check in autorender but can't think of a better way.
—
Reply to this email directly or view it on GitHub.

Closed via #1460


[libmariadb] Include bundled zlib and openssl

This pull request adds using vcpkg's openssl and zlib with libmariadb.
The first one fixes autolink issues when linking agains python27 or libpng (due to the fact that both inflate functions are autolinked with zlib and libmariadb)
The second change enables libmariadb to use SSL functions.

Please sign CLA first.

Signed

pbc regression will be fixed in #12732


authenticateMessage

Is the function of authenticateMessage function to verify signature? how to use? I tried a variety of parameter formats but it didn't work, Can you give me an example?

:link: zboto Link

This was solved through slack, the signature shouldn't not have the Signature Type on it. You should use the RAW signature.


Transform month view in mobile screen

Clear and concise description of the problem
Hello everyone! Currently, I'm using the month view to display the event schedule, but it doesn't show as I wish. I want to achieve something similar to the image below. Also, we need to preserve the functionality of event creation. Is it possible to achieve this using this library?

@gaurangt20 To achieve this look would require you to write a Custom Month View. I'm afraid I don't understand what you mean by "preserve the functionality of event creation". Big Calendar doesn't natively handle that. It provides the necessary event handlers for a developer to write their own implementation.


setValue doesn't work with DatePickerElement

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
Repro: https://stackblitz.com/edit/stackblitz-starters-fz6utl?file=src%2FApp.tsx
Creating a react-hook-form-mui DatePickerElement and calling setValue doesn't work. There aren't errors, but the picker never updates with the new value.
To confirm this works with MUI, the repro also has a native MUI DatePicker matched to the same underlying Luxon date. The DatePicker value updates successfully.

Expected behavior 🤔
setValue should allow setting a DatePickerElement value as MUI does today.
Steps to reproduce 🕹
Repro: https://stackblitz.com/edit/stackblitz-starters-fz6utl?file=src%2FApp.tsx

@m-dierker you are not on the right context. If you want to use run your own useForm then you have to provide that context to the  similar to this example:
https://github.com/dohomi/react-hook-form-mui/blob/master/apps/storybook/stories/FormContainer.stories.tsx#L79
Alternatively you can use a child component of your form and there you can use useFormContext and that will have the right context for you as well as  is providing the  context automatically


First crack at ConfirmInformation component

Fixes issue 16, needs refactored and broken out, and the display is not fixed, but http://i0.kym-cdn.com/entries/icons/original/000/005/600/its-something.jpg

Looks like a great start! A couple of notes:

Why was moment.js added? I didn't see it used.
Some of the properties there are a bit defunct, and some of them are not worked out yet. We should go over the properties listed in https://docs.google.com/spreadsheets/d/1hvMqhOtIaQr6uYyc-nizXLp8cNtKuajuEeJj6Ysbw08/edit#gid=0. One question we still need to answer is what to count as 'annual income'.

Moment.js is a dependency of one of the charting libraries, and in order
for the app to build I needed that specific version of moment.js defined.
On Wed, Oct 11, 2017 at 9:09 AM, knod<EMAIL_ADDRESS>wrote:

Looks like a great start! A couple of notes:

Why was moment.js added? I didn't see it used.
Some of the properties there are a bit defunct, and some of them
are not worked out yet. We should go over the properties listed in
https://docs.google.com/spreadsheets/d/1hvMqhOtIaQr6uYyc-
nizXLp8cNtKuajuEeJj6Ysbw08/edit#gid=0
https://docs.google.com/spreadsheets/d/1hvMqhOtIaQr6uYyc-nizXLp8cNtKuajuEeJj6Ysbw08/edit#gid=0.
One question we still need to answer is what to count as 'annual income'.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/codeforboston/cliff-effects/pull/73#issuecomment-335803926,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHAAWXXUtnKZ17Nt0unuTw0f3TWahMOUks5srL4HgaJpZM4P0yFE
.


fix yaml load warning

Address following warning:
YAMLLoadWarning: calling yaml.load() without Loader=... is deprecated
Please read https://msg.pyyaml.org/load for full details.
Fixes #142

Dequeued:
05:02:22
05:02:22  ======================================================================
05:02:22  ERROR: removing_default_ttl_does_not_affect_existing_rows_test (ttl_test.TestTTL)
05:02:22  ----------------------------------------------------------------------
05:02:22  Traceback (most recent call last):
05:02:22    File "/jenkins/workspace/scylla-master/next/scylla-dtest/ttl_test.py", line 149, in removing_default_ttl_does_not_affect_existing_rows_test
05:02:22      self.prepare(default_time_to_live=1)
05:02:22    File "/jenkins/workspace/scylla-master/next/scylla-dtest/ttl_test.py", line 34, in prepare
05:02:22      self.cluster.populate(nodes).start()
05:02:22    File "/jenkins/workspace/scylla-master/next/scylla-ccm/ccmlib/cluster.py", line 199, in populate
05:02:22      binary_interface=binary)
05:02:22    File "/jenkins/workspace/scylla-master/next/scylla-ccm/ccmlib/scylla_cluster.py", line 55, in create_node
05:02:22      initial_token, save, binary_interface)
05:02:22    File "/jenkins/workspace/scylla-master/next/scylla-ccm/ccmlib/scylla_node.py", line 67, in __init__
05:02:22      initial_token, save, binary_interface)
05:02:22    File "/jenkins/workspace/scylla-master/next/scylla-ccm/ccmlib/node.py", line 110, in __init__
05:02:22      self.import_config_files()
05:02:22    File "/jenkins/workspace/scylla-master/next/scylla-ccm/ccmlib/scylla_node.py", line 528, in import_config_files
05:02:22      self.__update_yaml()
05:02:22    File "/jenkins/workspace/scylla-master/next/scylla-ccm/ccmlib/scylla_node.py", line 614, in __update_yaml
05:02:22      data = yaml.full_load(f)
05:02:22  AttributeError: 'module' object has no attribute 'full_load'


Issue update branch selection disable

Gitea version (or commit ref): 1.11.4
Git version:
Operating system:
Database (use [x]):

[x] PostgreSQL
[ ] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[ ] No
[x] Not relevant

Log gist:

Description
Why on an existing issue, the branch dropdown box is disabled ?
We can affect branch during creation, but not during update.
...
Screenshots

Duplicate of #3620


Pattern:- Leadspace Block :- Spacing mismatch at top and bottom of page.

Issue Description:- As per specs there should be 64px spacing between heading and top of page where as it is less than 64px.
There should be 64px spacing between cta copy button and horizontal line where as it is more than 64px.
Steps to reproduce the issue

Enter url in the browser.
Select 'Leadspace Block' in pattern section.
3.Check the spacing between top of page and heading text
Check the spacing difference between cta copy button and horizontal border line.

OS:- Mac, Windows 10
Browsers:- Chrome , Firefox, Safari, Edge.

Spoke with @ltitle. The specs had an error in it, the tokens we used were correct


Support configurable area thresholds

Connects to https://github.com/mapzen/vector-datasource/issues/202
Adds support for a configurable area threshold value in pixels. This is a per layer value that will be applied to all polygonal features. Any feature whose area is less than this value will be dropped from tiles.
@zerebubuth could you review please?

Is the first step to have a globally-configurable value, rather than one per layer?

Did we ultimately want a separate setting per layer? If so, I think we might as well just go right to that.

I think so... or, at least, that's what I thought @nvkelso was asking for. Perhaps I got it wrong?

The only downside really is having to specify it multiple times if we always want it to be the same, but we gain more flexibility. I made it per layer in 004ca68.

:+1:

Yep, configurable by layer. water might have a different value than landuse, etc.


Support Eclipse mainnet on solana-playground

Eclipse is the first Ethereum's EVM L2 : https://twitter.com/EclipseFND
It uses Solana Virtual Machine, smart contracts are written with Anchor/Rust. Would it be possible for solana playground to support that network ? Thank you!

Mainnet is not yet public I believe. Thank you for the quick response!

Mainnet is not yet public I believe. Thank you for the quick response!


22614 - Only allow 1 citizenship for Canadians.

*Issue:22614 *https://github.com/bcgov/entity/issues/22614
Description of changes:

convert citizenships from combobox to figma design (3 radios and 1 combobox)
update tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

/gcbrun

Temporary Url for review: https://bcregistry-btr-dev--pr-205-iq1kevhf.web.app


Add internet detector utility

This adds a script to detect if internet connection is active or not by adding an icon in the taskbar and also changing the background based on if internet is detected or not.

How does this script interact with FakeNet? Should FakeNet be handled specifically?

How does this script interact with FakeNet? Should FakeNet be handled specifically?

If fakenet response is the one we would get with internet, our tool (as other programs like malware) thinks the internet is on. The default fakenet response shouldn't match the ones we are expecting, so without modifying the default fakenet configuration, it will think there is no internet.
@mr-tz do you have a proposal to improve the implementation? What do you exactly mean with handling fakenet specifically?
Note: I think this tool could be hosted in the fakenet repository and even been part of fakenet, it would need to be discussed with the fakenet maintainers to see if it is feasible once we have a working and tested version.

I'd expect it to not warn users that the Internet is reachable if FakeNet is running.

This raises a good thought.
While the tool works with FakeNet active, you would see a lot of requests generated in order for the tool to function. We can potentially reduce the request interval, but this would cause a delay in detecting internet which is a trade-off we need to consider.
What interval would be fair enough to detect a real internet connection in enough time for a user to be aware while also not being too intrusive in a FakeNet output? Also note, due to adding backup internet connectivity URL's, there are now multiple requests that are issued consecutively, rather than a single one.

I was able to remove the PyQt5 dependency. :)

Added nicer tooltips that tell explain what the icons mean: "Internet Detected" vs "Internet Not Detected"

I remember some filtering work FakeNet did on Internet connectivity checks to reduce noise. Maybe @tinajohnson can chime in on this?
I'm not sure what a good interval would be, maybe 20 seconds?

Chatting with FakeNet team, it sounds like we can add the tool to "Diverter's ProcessBlackList and HTTPListener's ProcessBlackList":
see the second paragraph here ("You may also want to enable..." : https://github.com/mandiant/flare-fakenet-ng?tab=readme-ov-file#anonymous-listener

I also updated the tool to use a pink icon when internet is active and gray when not, as well as convert everything over to a VM Package and have it install a scheduled task to run every 2 minutes.
It is a .pyw file in order to not have a terminal interface popup for it to run.

Also note, this will fail to pass the test_upload due to requiring certain files to be existent in the main branch already:
https://github.com/mandiant/VM-Packages/pull/1121/files#diff-bb3df9f8d616b7a9b00f92220dafa6cc20883cdd518f04b8e2c3e3993dfe9fe6R15

@emtuls

Also note, this will fail to pass the test_upload due to requiring certain files to be existent in the main branch already:
https://github.com/mandiant/VM-Packages/pull/1121/files#diff-bb3df9f8d616b7a9b00f92220dafa6cc20883cdd518f04b8e2c3e3993dfe9fe6R15

We need to split this PR as the package need to succeed to be pushed to MyGet: one PR only for the tool, one PR for the package. Sorry for the confusion.

Apologies for missing the ping here but I did have a conversation about using FakeNet's blacklist config with @emtuls privately. A correction to my original comment on the same - adding the process name to just the Diverter's ProcessBlackList config should do the trick as that will act as a global blacklist.

Great work @emtuls 🎉

Just some minor improvement suggestions 😉

can we change the pink icon to have more contrast with the pink taskbask? (for example with a more intense/lighter pink) it is a bit difficult to see when it is hidden and it does not hurt when it is not:

it would be nice that the icon is always visible. It seems I can move it manually to the taskbar and then it stays there. It would be nice if the tool could place it there. I propose you open an issue your this and research if it is possible after this PR has been merged. As it can be placed manually in the taskbar, I do not consider this a blocker and I would like to start using the tool! 🎉

I have updated it to just use the colored version, which I think looks great with the pink taskbar.
Unfortunately, I don't think there's a way to force the icon to stay on the tray in the taskbar...For me, it starts there, but sometimes gets moved, but it can be moved back down manually. Couldn't find any way to force it to stay on the bottom.


Feature Request: Support multiple Amazon accounts

Hi @dloza,
I'd love to understand your use case more. Have you tried running the tagger twice (e.g. once as Amazon user A and again as user B)? I do this myself: once for my amazon account and once for my spouse's account. This ought to work fine with one Mint account (and let me know if it doesn't for some reason).
Thanks!
Jeff

Thanks for the report @ashenkin. This is a regression; I'll get a fix out shortly. Cheers.

Turns out the issue was with the starting URL, which recently changed in response to a new Amazon login flow. I've added the appropriate URL params back such that you are always presented with the account selector, allowing multiple amazon users to be selected (instead of attempting to use the last signed in one). Please try version 1.61 or later and reopen if the issue persists. Thanks!


Bayes Estimators: Loss functions with flexible signature

Implementation proposal to the signature change of the loss_fun used for Amortized Bayes Estimators as discussed in https://github.com/stefanradev93/BayesFlow/issues/121.
It stays as simple as before to use norm_ord, but the optional loss_fun argument expects a function object with two arguments, rather than the difference of parameters and network output.

Great idea!

Thanks!


refactor: Document library use of cargo2port

When src/lib.rs was added, cargo2port was made available for library use, but the functions were still organized in such a way as to reflect the cargo2port command line.
This refactors the library code to make the functions more usable outside of the cargo2port command line context.

You can check this out with halostatue/crate2port, which provides a different binary on top of the cargo2port base library. It differs from #6 in that you do not need to specify crate:name@version, but only need to specify name@version.

Merged. Thanks!


How to load SERAC weights

Hi, Im using the ckpt found in :https://drive.google.com/drive/folders/1rVWN7z05CHkIwbOJ5Cy3E0seWSpU6SeT.
And I want to load it so that Ill be able to evaluate the model, my hparams file is:
`# Model
alg_name: "SERAC"
archive: ./results/models/SERAC/llama-2-7b.bk
device: 0
model_name: meta-llama/Llama-2-7b-hf
model_class: LlamaForCausalLM
small_name: Cheng98/llama-160m
tokenizer_class: LlamaTokenizer
tokenizer_name: meta-llama/Llama-2-7b-hf
cls_name: distilbert/distilbert-base-cased
cls_class: AutoModel
inner_params: []
model_parallel: false
# Method
alg: SERAC
lr: 1e-5
edit_lr: 1e-2
seed: 0
lr_lr: 0.0
cedit: 0.1
cloc: 1.0
cbase: 1.0
dropout: 0.0
final_eval: True
supervised: false
train_base: False
no_grad_layers: null
soft_weighting: false
checkpoint_grad: false
cross_attend: false
cos: false
freeze: null
square: true
bound_embeds: false
use_all_negatives: false
freeze_cntr: false
dist_heads: 1
lora: null
batch_size: 1
model_save_pt: 500
edit_bs: 1
silent: False
#max_epochs: 1
max_iters: 10000
log_interval: 500
val_interval: 500
early_stop_patience: 40000
early_stop_key: "loss/total_edit_val"
eval_only: False
half: False
save: False
debug: False
log_errors: False
unlikelihood: True
val_batch_size: 1
accumulate_bs: 10
val_steps: 500
opt: Adam
grad_clip: 100.
# Output
results_dir: ./results
`
And Im getting an error when loading: "Shouldn't have any unexpected keys"
where the unexpected keys are:"
['replacement.model.layers.0.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.1.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.2.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.3.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.4.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.5.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.6.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.7.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.8.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.9.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.10.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.11.self_attn.rotary_emb.inv_freq']"
Any idea what am I missing?

It appears that your model is not in the Huggingface format for the LLaMA model. The model weights' name does not match the LLamaForCausalLM class. You need the official LLaMA weights and then convert them to the Huggingface format. I suggest you update the transformers package and re-download the model weights.
Here are the correct names for the Huggingface format of the LLaMA model weights:
'model.layers.29.self_attn.q_proj.weight'
'model.layers.29.self_attn.k_proj.weight'
'model.layers.29.self_attn.v_proj.weight'
'model.layers.29.self_attn.o_proj.weight'
'model.layers.29.self_attn.rotary_emb.inv_freq'
'model.layers.29.mlp.gate_proj.weight'
'model.layers.29.mlp.down_proj.weight'
'model.layers.29.mlp.up_proj.weight'
'model.layers.29.input_layernorm.weight'
'model.layers.29.post_attention_layernorm.weight'
'model.layers.30.self_attn.q_proj.weight'
'model.layers.30.self_attn.k_proj.weight'
'model.layers.30.self_attn.v_proj.weight'
'model.layers.30.self_attn.o_proj.weight'
'model.layers.30.self_attn.rotary_emb.inv_freq'
'model.layers.30.mlp.gate_proj.weight'
'model.layers.30.mlp.down_proj.weight'
'model.layers.30.mlp.up_proj.weight'
'model.layers.30.input_layernorm.weight'
'model.layers.30.post_attention_layernorm.weight'
'model.layers.31.self_attn.q_proj.weight'
'model.layers.31.self_attn.k_proj.weight'
'model.layers.31.self_attn.v_proj.weight'
'model.layers.31.self_attn.o_proj.weight'
'model.layers.31.self_attn.rotary_emb.inv_freq'
'model.layers.31.mlp.gate_proj.weight'
'model.layers.31.mlp.down_proj.weight'

Hi, do you have any further questions?

Im trying to understand, what can be more official than:" meta-llama/Llama-2-7b-hf"
But even If I do get this official version, I dont understand where those:
['replacement.model.layers.0.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.1.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.2.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.3.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.4.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.5.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.6.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.7.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.8.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.9.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.10.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.11.self_attn.rotary_emb.inv_freq']"
Weights are fitting into? they will always be unexcepted, or there is something in the code that add those objects to the model?

Hi,
I'm sorry for not expressing myself clearly earlier. I tried to reproduce your issue but couldn't get the same results. Then, I checked the names of my LLaMA 2 model weights and found that they are named like model.layers.29.self_attn.q_proj.weight. So, I suspect that your model might be an earlier version of LLaMA 2 that hasn't been converted to the Hugging Face format, or your transformers package might be outdated. I found a similar issue in this issue.
You can try updating the transformers package first. If this doesn't resolve your issue, please feel free to contact us.
Thank you!

It appears that you are using a different version of llama-160m from us. Please try JackFram/llama-160m to align with our setting.

Hi, have you solved your issue yet?

Sorry for any inconvenience.
It appears that you are using a different version of llama-160m from us. Please try JackFram/llama-160m to align with our setting.

Hi, I tried JackFram/llama-160m, but the error still persists when running SERAC method and the error message is as follows:
metrics, edited_model, _ = editor.edit(
  File "/home/hli/project/KnowledgeEdit/EasyEdit/examples/../easyeditor/editors/editor.py", line 271, in edit
    edited_model, weights_copy = self.apply_algo(
  File "/home/hli/project/KnowledgeEdit/EasyEdit/examples/../easyeditor/models/serac/serac_main.py", line 68, in apply_to_model
    self.init_model(model, tok, hparams)
  File "/home/hli/project/KnowledgeEdit/EasyEdit/examples/../easyeditor/models/serac/serac_main.py", line 34, in init_model
    self.alg.load_state_dict(d["model"], False)
  File "/home/hli/project/KnowledgeEdit/EasyEdit/examples/../easyeditor/trainer/algs/SERAC.py", line 123, in load_state_dict
    assert len(res.unexpected_keys) == 0, print(res.unexpected_keys)
AssertionError: None

And the ouput of res.unexpected_keys is:

['replacement.model.layers.0.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.1.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.2.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.3.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.4.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.5.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.6.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.7.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.8.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.9.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.10.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.11.self_attn.rotary_emb.inv_freq']

I checked the code and found that this error was caused by
d = torch.load(params.archive, map_location='cpu')
self.alg.load_state_dict(d["model"], False)

and the params.archive was set to the path of the JackFram/llama-160m.
Do you have any ideas to solve this? Thank you.


add contiguous iterable base class and remove layout param from storag…

The idea is to use this also for views with contiguous layout.
Some strided views have a static layout (e.g. the reshape_view) as well as the new xview can potentially have a static layout.
In this case we want to get fast iterators for the static layout.

Also layout_type and contiguous_layout should be removed from xcontainer and all classes inheriting from xcontiguous_layout since they are already defined there.

the previous PR was actually missing the removal of the layout parameter for the storage_begin... methods on xiterable and xconst_iterable.
I've now removed them, but I am wondering – following our discussion in the other PR – if we shouldn't remove these functions altogether, and make sure they're never instantiated / called on the "wrong" function leave (which I guess is already the case)?

@wolfv Removing storage_begin / storage_end for expressions for which it never make sense can be done in a dedicated PR. From what I see, the expressions for which it makes sense usually provide their own implementation, but I'm not 100% sure they all do that.
Also can you make xcontiguously_iterable inherit privately from xiterable and import API with using declarations? This is to avoid method masking.


[release]: Logstash OSS with OpenSearch Output Plugin 8.9.0

Did you read the on-boarding document
Yes
What is the name of your component?
Logstash OSS with OpenSearch Output Plugin
What is the link to your GitHub repo?
https://github.com/opensearch-project/logstash-output-opensearch
Targeted release date
Aug 10, 2023
Where should we publish this component?
Docker Hub
Artifacts on opensearch.org
What type of artifact(s) will be generated for this component?

Docker image
tar.gz artifacts for linux with x64
tar.gz artifacts for linux arm64
tar.gz artifacts for macos x64

Have you completed the required reviews including security reviews, UX reviews?
N/A
Have you on-boarded automated security scanning for the GitHub repo associated with this component?
Yes.
Additional context
None

Hi @dlvenable ,
I see that logstash was on-boarded to 1-click release process https://github.com/opensearch-project/logstash-output-opensearch/pull/188
Are the above artifacts addition to the ruby-gems publication or are the completely different?
Thanks!

Closing the issue as logstash OSS with output plugin https://opensearch.org/downloads.html


fix: update all dependencies

Resolves #5
Resolves #9
Resolves #12

Codecov Report

Merging #25 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #25   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           1      1
  Lines           4      4
=====================================
  Hits            4      4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 589539b...5889fd5. Read the comment docs.


iOS Build Infrastructure

iOS publishing is not fully automated.
It has manual processes that are tedious and error prone.
Ideal outcomes of resolving this issue will

update the version in podspec based on custom.props as part of VSO pipeline.
transfer framework binary from VSO for public consumption through VSO pipeline
update url in podspec through VSO pipeline.
publish pod to cocoapod as part of VSO pipeline.

closed via #3291


New note started from Search window is not listed in Search window until clicking Refresh or a dummy search.

Open Search Window, start a new note (either from menu or Ctrl+N), close the new note window. The new note is not listed in the Search window, "Refresh" button is enabled. Either clicking "Refresh" button or running a dummy search starts showing the new note.
When a new note is created, it should be right away shown in the list  of notes for consistency.

Obviously, Davo needs to weigh in on this one as it depends on the overhead involved -- and I believe that from other posts there is some significant overhead saved by not updating automatically, especially since the search form, as I recall, involves calling a separate module.
Having come from Tomboy I think I understand your concern. There I kept the search window open, but find myself using ng differently. Now I only have to need to open it from time to time as I usually work with relatively small subets of my notes at any given time. As a result the ng list of the 10 most recent notes that appears from the notification icon in the system tray fits the bill perfectly. I am happy NOT to keep the window open, especially  since I find it busier and less attractive than the old Tomboy search window. Furthermore, new notes DO appear in the popup from the tray right away.

Obviously, Davo needs to weigh in on this one as it depends on the overhead involved -- and I believe that from other posts there is some significant overhead saved by not updating automatically, especially since the search form, as I recall, involves calling a separate module.
Having come from Tomboy I think I understand your concern. There I kept the search window open, but find myself using ng differently. Now I only have to need to open it from time to time as I usually work with relatively small subets of my notes at any given time. As a result the ng list of the 10 most recent notes that appears from the notification icon in the system tray fits the bill perfectly. I am happy NOT to keep the window open, especially  since I find it busier and less attractive than the old Tomboy search window. Furthermore, new notes DO appear in the popup from the tray right away.

Yes, as aguador says, the manual update model is desirable for users with very large numbers of notes. They like be able to open the search window, find a note they want to work on, do so, then work on the next one in sequence and perhaps work their way down the list. Having the list refresh itself confuses that work flow.  The list is refreshed whenever you close/open the search window or hit 'Refresh'.
But No, its not really a performance issue, I keep the note metadata in a internal data structure, sorted, so, I can refresh the visible list quite quickly at any time.
I, personally, am often surprised the list has not been updated !  So, maybe we need to look at making that optional ?  "Auto Refresh" on/off   ?  I worry just how complicated the user interface has become however. I like having lots of options but new users do find it confusing....
turgutgenc1, are you an old time Tomboy user or a new to the tomboy world ?
Davo

Yes, as aguador says, the manual update model is desirable for users with very large numbers of notes. They like be able to open the search window, find a note they want to work on, do so, then work on the next one in sequence and perhaps work their way down the list. Having the list refresh itself confuses that work flow.  The list is refreshed whenever you close/open the search window or hit 'Refresh'.
But No, its not really a performance issue, I keep the note metadata in a internal data structure, sorted, so, I can refresh the visible list quite quickly at any time.
I, personally, am often surprised the list has not been updated !  So, maybe we need to look at making that optional ?  "Auto Refresh" on/off   ?  I worry just how complicated the user interface has become however. I like having lots of options but new users do find it confusing....
turgutgenc1, are you an old time Tomboy user or a new to the tomboy world ?
Davo

I'm an old time Tomboy user (and I had to adopt to nValt on Mac for the last few years because Tomboy kept crashing on Mac). I have been concurrently using Tomboy on Windows with rotational storage, and nValt on Mac with hundreds of notes (close to 900) without an issue with immediate search while typing. So, I think providing auto refresh option might be a good idea for wider range of users.
To give you more insight from the usage characteristics perspective, I am NOT using the same notes over and over again, I tend to visit 50-100 different notes every day. That's why just having the systray icon with 10 most recent notes would not fit my bill. I am using these notes apps to access my small notes faster than finding and opening a file in finder/file explorer. I'm not using the mouse either, I am using keyboard shortcuts to activate the app, switch in between panes/tabs, search, open&close, copy&paste etc. Systray icon doesn't do anything for me either (well, except staying there as an identifier of running application).
After major things are fixed in Tomboy-Ng, I might be asking a menu for keyboard shortcuts, maybe an import function for a pile of regular text files... Which in fact would be very much useful to me at the moment.

I'm an old time Tomboy user (and I had to adopt to nValt on Mac for the last few years because Tomboy kept crashing on Mac). I have been concurrently using Tomboy on Windows with rotational storage, and nValt on Mac with hundreds of notes (close to 900) without an issue with immediate search while typing. So, I think providing auto refresh option might be a good idea for wider range of users.
To give you more insight from the usage characteristics perspective, I am NOT using the same notes over and over again, I tend to visit 50-100 different notes every day. That's why just having the systray icon with 10 most recent notes would not fit my bill. I am using these notes apps to access my small notes faster than finding and opening a file in finder/file explorer. I'm not using the mouse either, I am using keyboard shortcuts to activate the app, switch in between panes/tabs, search, open&close, copy&paste etc. Systray icon doesn't do anything for me either (well, except staying there as an identifier of running application).
After major things are fixed in Tomboy-Ng, I might be asking a menu for keyboard shortcuts, maybe an import function for a pile of regular text files... Which in fact would be very much useful to me at the moment.

Pre-release version now available that addressed this issue. Please see https://github.com/tomboy-notes/tomboy-ng/releases/tag/v0.31
If you do use it, please watch for anything unexpected and please report what you find, good or bad.

Pre-release version now available that addressed this issue. Please see https://github.com/tomboy-notes/tomboy-ng/releases/tag/v0.31
If you do use it, please watch for anything unexpected and please report what you find, good or bad.

OK, just tested with 0.31f and the search window refreshes to show a new note once it has been saved automatically or closed. Eliminating the note also removes it from the search list immediately.

OK, just tested with 0.31f and the search window refreshes to show a new note once it has been saved automatically or closed. Eliminating the note also removes it from the search list immediately.

Tested with 0.31h version, auto refresh works! Thank you!

Tested with 0.31h version, auto refresh works! Closing this, thank you!


Cleanups related to legacy nid support

Fixes #14393

24 hours has passed since 'approval: done' was set, but this PR has failing CI tests.  Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually.

@levitte  the fixup broke one of the tests - I'll probably revert it. Of course also the test could be adjusted but thinking about this I do not think it is worth it and some third party scripts might also depend on that "canonical" value being used there.

@levitte OK to drop the fixup?

@levitte ping for the re-approval.

24 hours has passed since 'approval: done' was set, but this PR has failing CI tests.  Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually.

Merged to master. Thank you for the reviews!


feat: adding transactions and fixing HasData issue

Description

Add transactions
Fixes HasData issue

Testing required outside of automated testing?

[x] Not Applicable

Screenshots (if appropriate):

[x] Not Applicable

Rollback / Rollforward Procedure

[x] Roll Forward
[ ] Roll Back

Reviewer Checklist

[ ] Description of Change
[ ] Description of outside testing if applicable.
[ ] Description of Roll Forward / Backward Procedure
[ ] Documentation updated for Change

Fixes #69

:tada: This PR is included in version 3.11.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Fix #3626: updateLocale merge issue

This addresses #3626.
A fix was suggested in the comments but a PR wasn't submitted. I've refactored the suggested fix which will check if the locale to update exists (if not found in the currently loaded locales) and load it before merging. This mitigates the merge with the current set locale if the submitted locale isn't found in the loaded locales array.
Not sure if it should continue to merge if the locale to merge with can't be loaded, but this could be another issue to discuss.

@cmyers Can you add a test?

@icambron new to qunit but I'll give it a go.

Actually, another thought: I looked at the loadLocale code and it looks like it checks the cache anyway. So you probably don't even need the locales[locale] || part. Just let loadLocale check for you.

That's a good catch, I'll revisit then add a test.

LGTM. Thanks!

So basically try to load it if its not loaded already? That's mostly for node.js, I guess.

Yup

Merged in d26f97e1aeeea63d033a79d599db6a1ff7f7b7b7


Make recorder .flv videos scrollable (#512)

I have written an implementation to fix the scrollable video using ffmpeg command, which will also reduce the video size as mentioned by @leonard84
I have also opened a related pull Request testcontainers/vnc-recorder#4 by adding ffmpeg to the docker image, which (I saw) necessary to avoid using another container and also simplify the fix.
Just to mention that some test won't pass untill the new vnc-recorder docker image is available with tag 1.2.0.
(Thank to @kiview for his assitance during hack-commit-push (last june) which make contributing to testcontainers more clear for me.)
Fixes #512.

Some tests doesn't pass :
ChromeWebDriverContainerTest. simpleTest
CustomWaitTimeoutWebDriverContainerTest. simpleTest
SpecificImageNameWebDriverContainerTest. simpleTest
due to ExpectedConditions.visibilityOfAllElementsLocatedBy(By.cssSelector("#search h3") that is not met, but when using just By.cssSelector("#search") all tests pass.
I will try find out why and commit a fix

The tests was fixed by changing the Css Selector to look for parent element #search then for child elements with h3 tag (See last commit):
ChromeWebDriverContainerTest. simpleTest
CustomWaitTimeoutWebDriverContainerTest. simpleTest
SpecificImageNameWebDriverContainerTest. simpleTest

Updated docker image is published: https://hub.docker.com/layers/testcontainers/vnc-recorder/1.2.0/images/sha256-1e14fc21b1dd7c28978f82f90008e4a603cc62744631cd299d3f846a08821ea9?context=repo

I have updated to use the new testcontainers/vnc-recorder:1.2.0.
I canceled my last fix of about Css Selector due to changes in org.testcontainers.junit.BaseWebDriverContainerTest#doSimpleExplore in master (and now all tests pass).
I tried to switch to mp4 but some tests was unstable, so I prefer to have a separated ticket for it (I can work on it) and also indicate whether should we make flv available as an option or not for backward compatibility.

I've merged from master, as we've had a problem with GitHub Actions that needed to be fixed in the master branch.

@rnorth sounds good.

I'll take an action to amend this PR, adding a parameter for format which will default to FLV. In 1.16.0 we'll change the default to MP4.

Just note that it does not suffice to change the extension mp4 requires -movflags faststart to create stream able video.

@rnorth @kiview  I have added MP4 support with FLV as default.
I have also changed ChromeRecordingWebDriverContainerTest, the tests required minimum duration to correctly process video with ffmpeg (I'm still in doubt for this one)
I also updated documentation by mentioning mp4 support.
@leonard84 I used -movflags faststart options for mp4.
Please let me know if I missed something.
Thanks.

@kiview / @rnorth could you take another look.

@kiview / @rnorth could you take another look.

I have just updated with the latest commit from master.
could you please have a look ? (so it can be soon merged to the main branch).
Thank you

I have just updated with the latest commit from master.
could you please have a look ? (so it can be soon merged to the main branch).
Thank you

Thanks everyone for letting me contribute to this awesome project, hope it will be useful to the community  :smiley:

@oussamabadr thank you so much for contributing it! 💯
The timing was a bit uneasy given the reduced capacity of the team, and I am very sorry it took so long, but we're very happy with the result!
Expect it to be released very soon :)

Hi,
For me the screen recording is no longer working after this change. It seems that ffmpeg does not produce any output.
Can someone please check?
Thanks and kind regards,
Kay

@AB-xdev
This PR was released in 1.15.2.
The default is FLV, but you can specify MP4 as well.

@kiview

This PR was released in 1.15.2.
The default is FLV, but you can specify MP4 as well.

Thank you for the ultra-fast feedback 👍
However I meant the change that the default format is mp4 (or at least it should be as stated in the comment above).
Backstory:
We have an (non critical) issue in our project that basically says "Change Testconatiner-Test videos from FLV to MP4".
However we read that you will change it anyways with 1.16.0 and thought that we can simply sit this out and fix it on the fly when we update to 1.16 😄

@AB-xdev we forgot to switch the default in 1.16.0, sorry 😅

@AB-xdev we do! It is the right default value and will make many users' lives easier, just we need to do it in a "major" release, to not confuse our users. So, 1.17.0 then 😅


[BUG] Luos Statistics are not reported

Describe the bug
When asking statistics with Pyluos, those statistics are often not reported to python console.
Network configuration
4 st-microelectronics MCUs (L0, F0, G4, L4) with about 20 services.
How to reproduce the bug
Simply ask statistics in loop, and the bug will pop in less than a minute.
Additional context
A colleague has the same bug on his Windows Dell Laptop. But in his case, he doesn't receive the statistics at all.

With other setups, the first statistic is not received, but the other ones are OK.

Embedded luos engine is OK.
The statistics are always received when a tempo is incremented in pyluos code.

Pyluos bug => this issue can be closed.


AttributeError: 'TSocket' object has no attribute 'is_open'

The removal of isOpen breaks backwards compatibility with older versions of Thrift, it will throw errors at is_open:
`/home/datascience/conda/lib/python3.6/site-packages/thrift_sasl/init.py in open(self)
65
66   def open(self):
---> 67     if not self._trans.is_open():
68       self._trans.open()
69
AttributeError: 'TSocket' object has no attribute 'is_open'
`
This is linked to this commit:
https://github.com/cloudera/thrift_sasl/commit/892ead18c163eec873fab68d7409053f50a8f0df
Reverting back to an older tag (v0.3.0) seems to get around this problem.

I have similar problem:
 65
 66   def open(self):

---> 67     if not self._trans.isOpen():
68       self._trans.open()
69
AttributeError: 'TSocket' object has no attribute 'isOpen'

@szelenka @yanchvlad - I merged in PR #13 so could you see if that fixes your issues?

@gregrahn Can you maybe tag a new release? 0.3.1 maybe?

@gglanzani That's the plan given no problems =)

The PR #13 started to break things.. When will this bug be fixed ? I am planning to revert back to penultimate commit.

@anilpai are you using both thrift and thriftpy? Possible to show the stack trace? The current implementation after #13 trys for thrift's isOpen, otherwise uses thriftpy's is_open.
My understanding of the issue is that the thrift transport has different implementations outside of this library.

need a new tag 0.3.1

hi,
Here there is a problem. When I am working with the connection of impyla with impala and kerberos, with the version of thrift-sasl-0.3.0 I get the error:
AttributeError: 'TSocket' object has no attribute 'isOpen'
If I upgrade to 0.2.1 everything is OK, but I have other problem, the connection with hive and kerberos doesnt work and I need the version 0.3.0 because in the previous version tell me:
method readall doesnt exist.
What Can I do for both versions works?
Thanks in advance

@gregrahn Any update on v0.3.1?

@gregrahn Any update on v0.3.1?


initial reslilient parser

passes all the pretty printing tests from ziggy/Ast.zig
format specifiers:

{pretty} calls prettyPrint()
{} calls dump().  i've found this very useful for Tree visualisation.

added new tests: "comments", "top level non-struct values", "line string", "misc", "invalid"
TODO

provide the previous, uniform Ast.init() api which i think is used elsewhere

decide how to handle diagnostics

add more formatting options like indentation
decide how to log errors
decide what to do about empty string input panic @Tokenizer.zig:190:55

I've opened this as a draft because i wanted to show what I've done and maybe get some feedback as to whether this looks like a good direction.
This closely follows the style of https://matklad.github.io/2023/05/21/resilient-ll-parsing-tutorial.html and seems to handle some invalid inputs so far.  Loris, I know you prefer to avoid recursion when possible but this is a recursive decent parser with 'fuel' that gets partially drained on each call to peek() and re-filled on each advance().
So far I've been enjoying writing this code.  Whenever I've run into problems, I just print out the tree with the empty dump specifier "{}" and its been easy to inspect and fix things.
There is still a lot to do to integrate w/ the rest of the code base.  I welcome any advice toward that too.

@kristoff-it I think this is ready for review. There are still some TODOs but Schema.check() seems to be working now and I'm not sure what to work on next.


Add try/except to account for line wrap

On some linux systems the call from df -k (mount) is wrapped and has
3 lines, and on (most) systems 2 lines are there. This change accounts
for both of these situations by trying the 3 line and failing over to
the 2 line response handling from df.

thanks!  just merged


Symbol Editor Add-in doesn't work with SDE Military Overlay

Currently, the Military Overlay template has a workflow where users

are editing symbolized features locally with a file geodatabase
decide that they would like to share their data out as editable feature services, so they store their data in an enterprise geodatabase. They do this by copying the data into their enterprise geodatabase and repointing the data source of the existing map layers to this new enterprise location.

Once the data source of the map layers are referencing the enterprise geodatabase, the military symbol editor add-in no longer works. However, it also no longer throws any kind of error. I can search for symbols, edit the symbol and label attributes, but when i try and add them to the map, the symbol doesn't get added.
Eventually, it would be nice to have the symbol editor add-in work with the military overlay schema in an enterprise GDB.
However, for the short term, we need some sort of warning to be built into the editor that says it only works with file geodatabases.
If someone else could repro this case, that would be great.

Using an SDE used to work (I believe @BobBooth tested this ). Are you sure it is not the same issue reported in #96 where there are multiple military feature GDBs in a project and the addin is defaulting to the first one it finds (which may not be the one on the map).
Can you provide more detail on which GDB should be used in this scenario with multiple GDBs?

@csmoore this was my workflow that broke the symbol editor add-in.

I opened our new Military Overlay template, which has a file geodatabase for Bc2 and a file geodatabase for D. Symbol Editor works minus the confusion I reference in #96.
I add the schema that is hosted on our nsec sde database to the project. I repoint the data layers of the 2525D map to reference the sde geodatabase. I then remove the 2525D file geodatabase. At this point, the symbol editor stops working.

I guess the problem might be that I'm replacing the file geodatabase with the enterprise geodatabase, which is causing the symbol editor to break.

@Dbarnes1 - OK I can test this scenario - please provide the SDE layer details (offline) when you get a chance

@csmoore I tested the symbol editor in the pull request #98 in a non-MilitaryOverlay template and it does not allow me to edit features in an enterprise geodatabase.
I copied the Units file geodatabase from the 2525D file geodatabase associated with the Military Overlay Template to a PostgreSQL enterprise geodatabase; then added this enterprise geodatabase feature class to the active map, and then set the symbology to use the dictionary renderer. When I attempted to add an infantry unit to the map, I received the following error...

The editor expects the feature classes containing the 2525 schema to be in the ArcGIS Pro project file geodatabase. This error is a showstopper; users have to be able to edit features in enterprise geodatabases.

@elinz - thanks for the info - I can prioritize this existing issue after the PR if there are no objections.
This is also sounds like potential another issue (in addition to the one first reported in this issue) of a known limit that there can only be one GDB per standard in the project (sounds like there are two 2525D ones - one FGDB and one EGDB - I would be curious if the behavior is different if the FGDB were removed)

I am unclear on what the desired end result is for this issue. If the only issue we are trying to solve is being able to write to a SDE database using the Military Overlay Template then we have accomplished solving this issue. The one concern if I am currently only working with the Military Symbol Editor (MSE) I do not have the ability to repoint the MSE to a already configured SDE. Without the Military Overlay Template I do not have the ability to create features inside of a SDE database.
I think that this is going to be an issue for Military Tools for ArcGIS users who will want to edit their database holdings of military symbology. @lfunkhouser @nfeuerstein @Dbarnes1 @csmoore Please share your thoughts on these findings.

If 1. the project you open has an EGDB(SDE) with the Military Overlay data model or 2. you add/replace a new EGDB in your project things should work. But I may not fully understand what you mean by repointing to a new Military Overlay EGDB.

From: Lyle<EMAIL_ADDRESS>Sent: 12/14/2016 6:37 PM
To<EMAIL_ADDRESS>Cc: Christopher<EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: Re: [Esri/military-symbol-editor-addin-wpf] Symbol Editor Add-in doesn't work with SDE Military Overlay (#97)
I am unclear on what the desired end result is for this issue. If the only issue we are trying to solve is being able to write to a SDE database using the Military Overlay Template then we have accomplished solving this issue. The one concern if I am currently only working with the Military Symbol Editor (MSE) I do not have the ability to repoint the MSE to a already configured SDE. Without the Military Overlay Template I do not have the ability to create features inside of a SDE database.
I think that this is going to be an issue for Military Tools for ArcGIS users who will want to edit their database holdings of military symbology. @lfunkhouserhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_lfunkhouser&d=DgMFaQ&c=n6-cguzQvX_tUIrZOS_4Og&r=ochc7XKgLpe-0gXlfvFSsw&m=1sBm89_HklZghaveKFDMh2G4ri-ykxPu39Y_W-AJ-AQ&s=dFpNzhFf9oqWetrSIxtVAZY6NI43cPIgfuJOnvmzDGQ&e= @nfeuersteinhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_nfeuerstein&d=DgMFaQ&c=n6-cguzQvX_tUIrZOS_4Og&r=ochc7XKgLpe-0gXlfvFSsw&m=1sBm89_HklZghaveKFDMh2G4ri-ykxPu39Y_W-AJ-AQ&s=anwUHXG32Hv5FsvQrYy0wpPiQn0g2wEa_mCfGrMDmKY&e= @Dbarnes1https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Dbarnes1&d=DgMFaQ&c=n6-cguzQvX_tUIrZOS_4Og&r=ochc7XKgLpe-0gXlfvFSsw&m=1sBm89_HklZghaveKFDMh2G4ri-ykxPu39Y_W-AJ-AQ&s=R9F77mYcxqEdIHgB3himmLW3UpLL0iBi939AXR3RkA0&e= @csmoorehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_csmoore&d=DgMFaQ&c=n6-cguzQvX_tUIrZOS_4Og&r=ochc7XKgLpe-0gXlfvFSsw&m=1sBm89_HklZghaveKFDMh2G4ri-ykxPu39Y_W-AJ-AQ&s=EGuhrBD99OWNdu7kIcnW8AOzd1IE0IQShIoAHblyju4&e= Please share your thoughts on these findings.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Esri_military-2Dsymbol-2Deditor-2Daddin-2Dwpf_issues_97-23issuecomment-2D267191159&d=DgMFaQ&c=n6-cguzQvX_tUIrZOS_4Og&r=ochc7XKgLpe-0gXlfvFSsw&m=1sBm89_HklZghaveKFDMh2G4ri-ykxPu39Y_W-AJ-AQ&s=mNEdyhvGGFfbAj4aaqUKjNl_Vd7d-Ouq--e1xt4sXcE&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AC8peYncNlc8zC4smI8PoD6okibzv01aks5rIH3JgaJpZM4KVTZQ&d=DgMFaQ&c=n6-cguzQvX_tUIrZOS_4Og&r=ochc7XKgLpe-0gXlfvFSsw&m=1sBm89_HklZghaveKFDMh2G4ri-ykxPu39Y_W-AJ-AQ&s=YFIEOYSuvp6ObNCGZxwwghHt-wvvhcAU4KCJCEOUj7o&e=.

After discussing with @csmoore and @Dbarnes1 they set me straight. This issue has been fixed.

@Dbarnes1 please verify and close

@topowright thanks for taking a second look. Verified, closing.


Might need to add a troubleshooting statement.

The lack of the site rendering usually boils down to 3 things

wrong Hugo version
cloning w/out submodules
cached pages fixed by doing hugo server --disableFastRender

Adding these to the Readme might save out community members some headache down the road

Also only opening this as it's come up several times, and while fairly easy to fix given my familiarity with the site, it is not something everyone would know to do.


datasets support

add dataset page, support Chinese datasets download
support SOTA Chinese models

https://github.com/alibaba/EasyNLP/pull/48


[TERRA-578] Return from create / start aws commands immediately

Return from create / start aws commands immediately
describe resource may be used to check status
No changes at this time to delete, stop commands
Start command behaviors are now consistent b/w AWS and GCP. These are fairly quick to complete (under 5 min). Further stop / delete confirmation is likely important for the user since it mat otherwise lead to user being charged
Also included: minor UT fixes

locat test -
terra-cli (dexamundsen/terra-578) >> terra resource create sagemaker-notebook --name=dex-notebook-517-5
Creating notebook instance. It may take a few minutes before it is available

terra-cli (dexamundsen/terra-578) >> terra resource list
NAME                            RESOURCE TYPE         STEWARDSHIP TYPE      DESCRIPTION
…
dex-notebook-517-5              AWS_SAGEMAKER_NOT...  CONTROLLED            (unset)

// Resource creation not complete

terra-cli (dexamundsen/terra-578) >> terra resource describe --name=dex-notebook-517-5
Name:         dex-notebook-517-5
….
SageMaker Notebook instance name:   dex-notebook-517-5-dex-ws-513
SageMaker Notebook instance type:   ml.t2.medium
SageMaker Notebook instance status: (unavailable)

Logs:
2023-05-18 00:14:10.052 PDT [main] ERROR bio.terra.cli.service.WorkspaceManagerService - WSM exception status code: 409, response body: {"message":"Another operation is running on the resource; try again later","statusCode":409,"causes":[]}, message: {"message":"Another operation is running on the resource; try again later","statusCode":409,"causes":[]}
2023-05-18 00:14:10.060 PDT [main] ERROR bio.terra.cli.service.WorkspaceManagerService - WSM exception status code: 409, response body: {"message":"Another operation is running on the resource; try again later","statusCode":409,"causes":[]}, message: {"message":"Another operation is running on the resource; try again later","statusCode":409,"causes":[]}
2023-05-18 00:14:10.060 PDT [main] ERROR b.t.c.s.userfacing.resource.UFAwsSageMakerNotebook - bio.terra.cli.exception.SystemException: Error getting AWS SageMaker Notebook credential.: Another operation is running on the resource; try again later

// Creation complete

terra-cli (dexamundsen/terra-578) >> terra resource describe --name=dex-notebook-517-5
Name:         dex-notebook-517-5
…
SageMaker Notebook instance status: InService

terra-cli (dexamundsen/terra-578) >> terra notebook stop --name=dex-notebook-517-5
Notebook instance stopped
terra-cli (dexamundsen/terra-578) >> terra resource describe --name=dex-notebook-517-5
Name:         dex-notebook-517-5
…
SageMaker Notebook instance status: Stopped

terra-cli (dexamundsen/terra-578) >> terra notebook start --name=dex-notebook-517-5
Notebook instance starting. It may take a few minutes before it is available
terra-cli (dexamundsen/terra-578) >> terra resource describe --name=dex-notebook-517-5
Name:         dex-notebook-517-5
..
SageMaker Notebook instance status: Pending

terra-cli (dexamundsen/terra-578) >> terra resource describe --name=dex-notebook-517-5
Name:         dex-notebook-517-5
..
SageMaker Notebook instance status: InService

Thanks for jumping on this so quickly!
Do we need associated test changes to loop on describe to wait for ready, so that we don't try to delete the workspace as part of happy path cleanup before the notebook is ready?

Yes, I will add the test changes in the same PR (it will break in verily-src otherwise). Instead of a loop on describe, we can use the existing waitForNotebookstatus function directly (which was earlier used in create and start)

Thanks for jumping on this so quickly!
Do we need associated test changes to loop on describe to wait for ready, so that we don't try to delete the workspace as part of happy path cleanup before the notebook is ready?

Yes, I will add the test changes in the same PR (it will break in verily-src otherwise). Instead of a loop on describe, we can use the existing waitForNotebookstatus function directly (which was earlier used in create and start)

Update - using the describe approach since it more closing reflects user behavior

Maybe we get really aggressive with the retry timeout and move it up to 60 minutes for now? Otherwise LGTM

I would recommend the reverse - starting with lower timeouts now will surface fixes or improvements needed. A longer timeout might mask issues that we would face during regular operation.
in other words, I would rather have (some of) the errors show up earlier


Add option to run multiple templates in recipe + some code simplifications

Erlon - let's try to finalize this today.  Can you respond the comments above. We can also talk.


Build from source using flatpak-builder-tools

It would be nice to build lbry-app from source using flatpak-builder-tools's yarn builder.
~Not working WIP.~
WIP at wip/build-from-source

@nedrichards have you dealt with pre-built node modules before with other flathub apps? I don't know why but the keytar package insists on re-downloading a pre-build package which was already downloaded from generated-sources.json. It says the npm cache doesn't exists when it's been set as a ENV variable. I've never really built/developed a node.js app from source so this uncharted territory for me :/
WIP at wip/build-from-source
$ flatpak-builder --ccache --keep-build-dirs --force-clean --repo=lbry-repo lbry-app io.lbry.lbry-app.json
Emptying app dir 'lbry-app'
Downloading sources
Starting build of io.lbry.lbry-app
Cache hit for libsecret, skipping build
Cache hit for libnotify, skipping build
Cache hit for nodejs, skipping build
Cache hit for yarn, skipping build
Cache miss, checking out last cache hit
========================================================================
Building module lbry-app in /home/julian/Projects/io.lbry.lbry-app/.flatpak-builder/build/lbry-app-4
========================================================================
Running: yarn cache clean --offline
yarn cache v1.3.2
success Cleared cache.
Done in 0.02s.
Running: yarn install --offline --cwd /run/build/lbry-app/main
yarn install v1.3.2
[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
info<EMAIL_ADDRESS>The platform "linux" is incompatible with this module.
info<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
info<EMAIL_ADDRESS>The platform "linux" is incompatible with this module.
info<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
info<EMAIL_ADDRESS>The platform "linux" is incompatible with this module.
info<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
info<EMAIL_ADDRESS>The platform "linux" is incompatible with this module.
info<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
info<EMAIL_ADDRESS>The platform "linux" is incompatible with this module.
info<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
info<EMAIL_ADDRESS>The platform "linux" is incompatible with this module.
info<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
info<EMAIL_ADDRESS>The platform "linux" is incompatible with this module.
info<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
[4/5] Linking dependencies...
[5/5] Building fresh packages...
[1/6] ⠂ keytar-prebuild<EMAIL_ADDRESS>| linux | x64
[6/6] ⠂ node-sass:       npm config set proxy http://example.com:8080
[3/6] ⠂ electron
[-/6] ⠂ waiting...
error /run/build/lbry-app/main/node_modules/keytar-prebuild: Command failed.
Exit code: 1
Command: prebuild-install || node-gyp rebuild
Arguments:
Directory: /run/build/lbry-app/main/node_modules/keytar-prebuild
Output:
prebuild-install info begin Prebuild-install version 2.5.1
prebuild-install info looking for local prebuild @ prebuilds/keytar-prebuild-v4.0.4-node-v57-linux-x64.tar.gz
prebuild-install info npm cache directory missing, creating it...
prebuild-install info looking for cached prebuild @ /home/julian/.npm/_prebuilds/https-github.com-electron-userland-electron-builder-binaries-releases-download-v4.0.4-keytar-prebuild-v4.0.4-node-v57-linux-x64.tar.gz
prebuild-install http request GET https://github.com/electron-userland/electron-builder-binaries/releases/download/v4.0.4/keytar-prebuild-v4.0.4-node-v57-linux-x64.tar.gz
prebuild-install WARN install getaddrinfo EAI_AGAIN github.com:443
gyp info it worked if it ends with ok
gyp info using<EMAIL_ADDRESS>gyp info using<EMAIL_ADDRESS>| linux | x64
gyp http GET https://nodejs.org/download/release/v8.9.2/node-v8.9.2-headers.tar.gz
gyp WARN install got an error, rolling back install
gyp ERR! configure error
gyp ERR! stack Error: getaddrinfo EAI_AGAIN nodejs.org:443
gyp ERR! stack     at Object._errnoException (util.js:1024:11)
gyp ERR! stack     at errnoException (dns.js:55:15)
gyp ERR! stack     at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:92:26)
gyp ERR! System Linux 4.16.7-300.fc28.x86_64
gyp ERR! command "/app/bin/node" "/app/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /run/build/lbry-app/main/node_modules/keytar-prebuild

Error: module lbry-app: Child process exited with code 1

I've experienced the same failure on other projects, node-gyp just seems broken offline.

Thanks @TingPing I found nodejs/node-gyp/issues/665 & nodejs/node-gyp/issues/1191#issuecomment-301243919 which seem to offer a hacky solution.
I downloaded the node.js headers to $BUILDDIR/node-js-headers and pointed the npm_config_nodedir environment variable to the same path and now node-gyp doesn't complain about missing headers and builds so more packages.
New archive:
{
    "type": "archive",
    "url": "https://nodejs.org/download/release/v8.9.2/node-v8.9.2-headers.tar.gz",
    "sha256": "35ac226795678ef2b9a8f55c3eb65984bb49f71858e771c9719452d14926e83e",
    "dest": "node-js-headers"
}

ENV:
"build-options" : {
    "env": {
        "electron_config_cache": "/run/build/lbry-app/electron-cache",
        "npm_config_nodedir": "/run/build/lbry-app/node-js-headers"
    }
}

Still more issues, lbry uses electron-builder which doesn't seem to get the --offline flag from yarn by default, so I guess I need to figure that out... Node.js really wasn't designed to be build offline -_-
========================================================================
Building module lbry-app in /home/julian/Projects/io.lbry.lbry-app/.flatpak-builder/build/lbry-app-5
========================================================================
Running: yarn cache clean --offline
yarn cache v1.3.2
success Cleared cache.
Done in 0.03s.
Running: yarn install --offline --cwd /run/build/lbry-app/main
yarn install v1.3.2
[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
info<EMAIL_ADDRESS>The platform "linux" is incompatible with this module.
info<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
info<EMAIL_ADDRESS>The platform "linux" is incompatible with this module.
info<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
info<EMAIL_ADDRESS>The platform "linux" is incompatible with this module.
info<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
info<EMAIL_ADDRESS>The platform "linux" is incompatible with this module.
info<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
info<EMAIL_ADDRESS>The platform "linux" is incompatible with this module.
info<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
info<EMAIL_ADDRESS>The platform "linux" is incompatible with this module.
info<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
info<EMAIL_ADDRESS>The platform "linux" is incompatible with this module.
info<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
[4/5] Linking dependencies...
[5/5] Building fresh packages...
$ electron-builder install-app-deps && node build/downloadDaemon.js
  • electron-builder version=20.7.1
  • loaded configuration file=/run/build/lbry-app/main/electron-builder.json
  • loaded parent configuration file=/run/build/lbry-app/main/node_modules/electron-webpack/electron-builder.yml
  • rebuilding native production dependencies platform=linux arch=x64
  • rebuilding native dependency name=keytar-prebuild
Error: /app/bin/node exited with code 1
Error output:
warning You don't appear to have an internet connection. Try the --offline flag to use the cache for registry queries.
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8)
prebuild-install info begin Prebuild-install version 2.5.1
prebuild-install info looking for local prebuild @ prebuilds/keytar-prebuild-v4.0.4-electron-v54-linux-x64.tar.gz
prebuild-install info looking for cached prebuild @ /home/julian/.npm/_prebuilds/https-github.com-electron-userland-electron-builder-binaries-releases-download-v4.0.4-keytar-prebuild-v4.0.4-electron-v54-linux-x64.tar.gz
prebuild-install http request GET https://github.com/electron-userland/electron-builder-binaries/releases/download/v4.0.4/keytar-prebuild-v4.0.4-electron-v54-linux-x64.tar.gz
prebuild-install WARN install getaddrinfo EAI_AGAIN github.com:443
sh: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8)
gyp info it worked if it ends with ok
gyp info using<EMAIL_ADDRESS>gyp info using<EMAIL_ADDRESS>| linux | x64
gyp info spawn /usr/bin/python2
gyp info spawn args [ '/app/lib/node_modules/npm/node_modules/node-gyp/gyp/gyp_main.py',
gyp info spawn args   'binding.gyp',
gyp info spawn args   '-f',
gyp info spawn args   'make',
gyp info spawn args   '-I',
gyp info spawn args   '/run/build/lbry-app/main/node_modules/keytar-prebuild/build/config.gypi',
gyp info spawn args   '-I',
gyp info spawn args   '/app/lib/node_modules/npm/node_modules/node-gyp/addon.gypi',
gyp info spawn args   '-I',
gyp info spawn args   '/run/build/lbry-app/node-js-headers/include/node/common.gypi',
gyp info spawn args   '-Dlibrary=shared_library',
gyp info spawn args   '-Dvisibility=default',
gyp info spawn args   '-Dnode_root_dir=/run/build/lbry-app/node-js-headers',
gyp info spawn args   '-Dnode_gyp_dir=/app/lib/node_modules/npm/node_modules/node-gyp',
gyp info spawn args   '-Dnode_lib_file=/run/build/lbry-app/node-js-headers/$(Configuration)/iojs.lib',
gyp info spawn args   '-Dmodule_root_dir=/run/build/lbry-app/main/node_modules/keytar-prebuild',
gyp info spawn args   '-Dnode_engine=v8',
gyp info spawn args   '--depth=.',
gyp info spawn args   '--no-parallel',
gyp info spawn args   '--generator-output',
gyp info spawn args   'build',
gyp info spawn args   '-Goutput_dir=.' ]
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8)
gyp: Call to 'pkg-config --libs-only-l libsecret-1' returned exit status 0 while in binding.gyp. while trying to load binding.gyp
gyp ERR! configure error
gyp ERR! stack Error: `gyp` failed with exit code: 1
gyp ERR! stack     at ChildProcess.onCpExit (/app/lib/node_modules/npm/node_modules/node-gyp/lib/configure.js:336:16)
gyp ERR! stack     at emitTwo (events.js:126:13)
gyp ERR! stack     at ChildProcess.emit (events.js:214:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:198:12)
gyp ERR! System Linux 4.16.7-300.fc28.x86_64
gyp ERR! command "/app/bin/node" "/app/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /run/build/lbry-app/main/node_modules/keytar-prebuild
gyp ERR! node -v v8.9.2
gyp ERR! node-gyp -v v3.6.2
gyp ERR! not ok
error Command failed with exit code 1.

    at ChildProcess.childProcess.once.code (/run/build/lbry-app/main/node_modules/builder-util/src/util.ts:251:14)
    at Object.onceWrapper (events.js:317:30)
    at emitTwo (events.js:126:13)
    at ChildProcess.emit (events.js:214:7)
    at maybeClose (internal/child_process.js:925:16)
    at Socket.stream.socket.on (internal/child_process.js:346:11)
    at emitOne (events.js:116:13)
    at Socket.emit (events.js:211:7)
    at Pipe._handle.close [as _onclose] (net.js:554:12)
From previous event:
    at runCallback (timers.js:789:20)
    at tryOnImmediate (timers.js:751:5)
    at processImmediate [as _immediateCallback] (timers.js:722:5)
From previous event:
    at rebuild (/run/build/lbry-app/main/node_modules/electron-builder-lib/src/util/yarn.ts:149:27)
    at <anonymous>
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
Error: module lbry-app: Child process exited with code 1

Thread seems abandoned. Closing.


update self exclusion fields after successful update request

Coverage remained the same at 52.786% when pulling b74de8b7cd0b181756c0fe7e5b21ea63956961d6 on nazaninreihani:fix-self-exclusion-update into d6506277ea393850a12c917dfeaf9eb40dd871f2 on binary-com:dev.