Remove UIWebview API  from ios implementation

Device: all iOS devices
SDK version: 5.0.2
OS version: 13.4.1

Step 3: Describe the problem:
Seems like  GoogleSignIn  pod  is  still using UIWebview  API. I'm working on react-native app which  uses https://github.com/react-native-community/google-signin. This  library  is using GoogleSignIn SDK. AppStore  does not accept iOS apps  using  UIWebview  anymore.
Could you transfer the  SDK  to  WKWebView?
Information regarding GoogleSignIn  using UIWebview is taken  from  here: https://github.com/react-native-community/google-signin/issues/851.
Steps to reproduce:

Try to upload an app using GoogleSignIn  to the  AppStore.

Observed Results:
Binary gets rejected by AppStore.
Expected Results:
The app  to  get  an update.

+1

This is happening as I'm still seeing the use of UIWebView and the app is getting rejected on App Store here's the terminal output with pod update
Installing AppAuth (1.3.0)
Installing GTMAppAuth (1.0.0)
Installing GTMSessionFetcher 1.4.0 (source changed to `https://cdn.cocoapods.org/` from `trunk`)
Installing GoogleSignIn 5.0.2 (was 4.4.0 and source changed to `https://cdn.cocoapods.org/` from `trunk`)

Now when I do grep -r "UIWeb" . It gives this output:
./Pods/AppAuth/Source/AppAuth.h:    for the auth request. `UIWebView` and `WKWebView` are explicitly *not*
./Pods/AppAuth/README.md:for the auth request. `UIWebView` and `WKWebView` are explicitly *not*
./Pods/GoogleSignIn/CHANGELOG.md:- Supports sign-in via UIWebView rather than app switching to a browser,```

+1 on this

+1

I am using Google Sign-In in my App and the app is getting rejected on App Store, received mail with following message
ITMS-90809: Deprecated API Usage - New apps that use UIWebView are no longer accepted. Instead, use WKWebView for improved security and reliability.
I use "grep -r UIWebView ." command in project Terminal and getting Google Sign-In related files using UIWebView.

@samtstern you seem to be active around this repo, can you confirm that you're still using UIWebView? Thank you!

I solved this issue in my project updating my SDK 4.4.0 to 5.0.0.
Ussing "grep -r UIWebView ." command at therminal, returns some files with contents UIWebView only comments at the code or binary files. My RN versions is 0.59.9, and this version contains UIWebView in React lib.
The I do:
Remove four files on Xcode
{PROJECT_NAME}/Libraries/React.xcodeproj/React/Views
RCTWebView.h

RCTWebView.m

RCTWebViewManager.h

RCTWebViewManager.m

Remove two lines on Xcode
Pods/Development Pode/React/Support Files/React-umbrella.h
#import "React/RCTWebView.h"

#import "React/RCTWebViewManager.h"

By update Google SDK, I needed update react-native-google-signin 1.2.2 to 2.1.1, code is very similar.

Hey all.  Google Sign In versions 4 and earlier are compiled with references to UIWebView, which Apple has been discouraging the use of.  It looks like they've just begun rejecting apps that include these references, although I'm not sure exactly what the policy is.  The solution is to upgrade to the latest Google Sign In SDK (Version 5) which does not make use of UIWebView.
If you are using React Native you may be getting UIWebView references from RN, which is unrelated to Google Sign In:
https://github.com/facebook/react-native/issues/26255

@samtstern I'm getting that issue with GoogleSignIn (5.0.2) so it's still not solved.

@mayur43s I'm guessing you're using some other dependency that uses UIWebView, then.

@vonovak Can you please see my comment above. grep -r "UIWeb" . clearly shows that GoogleSignIn is using a reference to UIWebview along with other dependent pods.

I’m also thinking that GoogleSignIn still has UIWebView. If I remember correctly, I was able to upload a build only after I removed googlesignin dependency. I’ll try to check this again today to be 100% sure.

@mayur43s those references do not point to code usage but only to comments, and my understanding is that apple checks the application code after you upload the ipa, where there should be no comments included.

Hey all. Google Sign In versions 4 and earlier are compiled with references to UIWebView, which Apple has been discouraging the use of. It looks like they've just begun rejecting apps that include these references, although I'm not sure exactly what the policy is. The solution is to upgrade to the latest Google Sign In SDK (Version 5) which does not make use of UIWebView.
If you are using React Native you may be getting UIWebView references from RN, which is unrelated to Google Sign In:
facebook/react-native#26255

issue from Google SDK when i use Google SIgn in SDK (5.0.2) which is latest.my app was rejected by the apple.
if i remove google SDK then my build successfully uploaded.

@vonovak But the app is getting rejected due to reference even although that's not in code. @ydv0121 yes when you remove it the app gets submitted successfully but when you use that pod the build gets rejected.

@vonovak But the app is getting rejected due to reference even although that's not in code. @ydv0121 yes when you remove it the app gets submitted successfully but when you use that pod the build gets rejected.

yes so is it confirm issue from the google signin SDK?

@vonovak But the app is getting rejected due to reference even although that's not in code. @ydv0121 yes when you remove it the app gets submitted successfully but when you use that pod the build gets rejected.

yes so is it confirm issue from the google signin SDK?

Yes but @vonovak & @samtstern doesn't believe us.

I will see if we can get the word UIWebView removed from the pod's CHANGELOG.md even though I don't think that should be ending up in the ipa file.

I reinstalled @react-native-community/google-sign-in, latest version, ran pod install, archived and the app and it was accepted.

@samtstern Yes but that word is being used some other dependency files as well:
./Pods/AppAuth/Source/AppAuth.h:    for the auth request. `UIWebView` and `WKWebView` are explicitly *not*
./Pods/AppAuth/README.md:for the auth request. `UIWebView` and `WKWebView` are explicitly *not*
./Pods/GoogleSignIn/CHANGELOG.md:- Supports sign-in via UIWebView rather than app switching to a browser,

Thanks @mayur43s
I can definitely see how AppAuth.h is causing an issue ... that is code that would be inside the app.  But I can't see how README.md and CHANGELOG.md from pods would be causing an issue.
Does anyone have more information from Apple about their rejection?  Can you prove it's coming from a reference in a file within GoogleSignIn?

@samtstern see my comment  above


Refactor builtin plugins

Builtin Plugins Migration
Background

There have been several attempts to include plugins along with FiftyOne. To ensure consistency in implementation among both built-in and external plugins, we need to normalize how plugins are included in FiftyOne and FiftyOne Teams.
Current State
Currently, there is no concept of built-in plugins, only a list of BUILT_IN_OPERATORS and BUILT_IN_PANELS. These contradict the list of PluginContexts that are typically loaded for external plugins. This approach also does not support the concept of a built-in JS panel or plugin.
Changes
1. plugin_context.register(MyClass, builtin=True)

This approach allows us to annotate an artifact during construction and registration.
These parameters can be used in the future to easily reflect class metadata.

2. New fiftyone/fiftyone/builtins Directory

This directory would be loaded as if it were another FIFTYONE_PLUGINS_DIR.
Note: This will impact the behavior of the SDK and list_plugins(), as built-in plugins will be included. We can discuss how we want this to work.
It would mimic the structure of fiftyone-plugins/plugins, enabling a typical plugin structure and removing the need for BUILT_IN_OPERATORS and BUILT_IN_PANELS.

3. Migrate Existing Built-In Panels and Operators

Move existing built-in panels and operators from various areas of the codebase to the new directory.

Components to Migrate:

Core Operators
Query Performance Panel
Data Quality Panel
Model Evaluation Panel
Model Evaluation Operators
Data Lens Python Operators + Utils
Data Lens JS Panel (+ Registration)

Summary by CodeRabbit

New Features

Introduced new parameters to enhance operator and plugin listing functionalities, allowing users to filter built-in operators and plugins.
Added new classes and functions for improved operator registration and execution.
New YAML configuration files for both operators and panels, detailing core functionalities and available features.
Added built-in panels for model evaluation.

Documentation

Updated documentation for developing plugins, including enhanced examples and clearer instructions on the plugin structure and requirements.

just note that this makes it easy to for non-builtins to be marked as builtin, which could lead to problems
Resolve this by only resolving builtin based on path.

Now all plugins (including JS) are aware of being builtin, and its all based on one way of defining a plugin: the PluginDefinition / fiftyone.yml. Builtin is now determined based on where this file is. If its in the expected builtin plugin directory then it is considered a builtin plugin.


in comment line 11:  lilsts -> lists   (typo?)

Why did you close this?

I'm sorry, it was a mistake on my part. I am only learning how to use git. Who exactly closes this?
Sent from my iPhone

On Mar 17, 2015, at 10:47, Robert Widmann<EMAIL_ADDRESS>wrote:
Why did you close this?
—
Reply to this email directly or view it on GitHub.

You already closed it, but I have the power to close and reopen these things to, which is what I'd like to do.  If you don't have any more changes to make, I'm going to reopen and merge this.  It's a great change to have.

Thank you. No more changes at this point.  I hope to pick up all the nuances soon. ;)
Marek
Sent from my iPad

On Mar 17, 2015, at 12:49, Robert Widmann<EMAIL_ADDRESS>wrote:
You already closed it, but I have the power to close and reopen these things to, which is what I'd like to do. If you don't have any more changes to make, I'm going to reopen and merge this. It's a great change to have.
—
Reply to this email directly or view it on GitHub.

Alright then.
:boat:


Android Studio 2.2.1, not working

The plugin doesn't work with Android Studio 2.2.1. Worked well with AS2.0 if i remember correctly

Confirmed as well:
Android Studio 2.2
Build #AI-145.3276617, built on September 15, 2016
JRE: 1.8.0_76-release-b03 x86_64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o

Does "not working" mean that on restart of IDE to complete install, you never get past the splash screen ? Then yes, it's not working, AS 2.2.2

The exact issue was that the 'add' button, which displays the image picker, was non responsive.
As of AS 2.3 the issue has been resolved and the plugin works correctly.


fix: prepare action for release

Changing name of the action as apparently name should be unique.

Please take a look @Souvikns


Core allocation/reservation logic renovation

The other thing is, when we score nodes while attempting to reserve resources, we need to make sure the candidate node satisfies the following condition

the node fits the predicates
the node has not been reserved
the node is scheduable

right now the score is calculated based on resource only, that will lead the issue that reserve resources on a node that might not have a certain label to satisfy a node-selector, or against a affinity/anti-affinity constraint. which is an invalid reservation.

New commits pushed with the smoke tests and further clean up. To link this back to the comment from @yangwwei:
comment 1: (https://github.com/apache/incubator-yunikorn-core/pull/89#issuecomment-584913754) remarks:

internal unreserve: fixed the issue found (commit 1)
tryAllocate correctly unreserves (commit 2)
if reserved allocation fails try all nodes (commit 1)

comment 2 (https://github.com/apache/incubator-yunikorn-core/pull/89#issuecomment-585361646) remarks

running predicates for each allocation try for each  node in all cycles will cause a huge slow down. For example in a 100 node cluster 1 predicates check is run if there are enough resources available on the node. If we do it before that check and let it lead us and we have 99 nodes that do not fit the ask we would have run the predicates 100 times for the same alloc. Caching the predicate run is not possible as node usage can change and thus the predicate outcome would change. I think that is 1) is thus a no go.
the score used is really basic at the moment. However I could argue for or against all scores. A large node might have a longer average runtime per allocation (service type load) and thus release less often. Without metrics we really cannot argue for one or the other or for a 3rd alternative.
Yes we need better metrics, I will follow up with a new jira

For the test failures: I have seen a number of them and they are transient. The tests use a manual scheduler (steps based on a counter). The manual scheduling in the smoke tests is I think the cause of the issue. The duration of the scheduling cycle is short and also cut even shorter when nothing needs to be done. We probably waste scheduling cycles because we have nothing to do. When events are later processed we have no scheduling cycles to progress.
I am thinking about a better solution or even using continuous scheduling in the smoke tests.

LGTM, @wilfred-s  pls merge with a proper commit message.
Let's track the flaky tests in a separate issue.


incorrect reporting of duplicate function

Getting a ton of errors reporting that a function is a duplicate in global scope, when it isn't.
The file is in the source path, and is included in various components, one of which is then extended by other components.

There are hard to track down without an example, because in most cases, it's dependent upon multiple factors in your project. Can you provide a working example project or steps to reproduce?

@georgejecook are you still seeing this as an issue?

no


fix http2 bytebuf leak issue[wip]

Codecov Report

Merging #1460 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1460      +/-   ##
============================================
- Coverage     73.49%   73.46%   -0.03%
+ Complexity     7852     7848       -4
============================================
  Files           556      556
  Lines         42885    42888       +3
  Branches       5377     5377
============================================
- Hits          31518    31509       -9
- Misses         9812     9819       +7
- Partials       1555     1560       +5

Impacted Files
Coverage Δ
Complexity Δ

...github/ambry/network/http2/Http2NetworkClient.java
84.90% <100.00%> (+0.14%)
17.00 <0.00> (ø)

...ava/com/github/ambry/router/NonBlockingRouter.java
78.02% <100.00%> (+0.10%)
54.00 <0.00> (ø)

...n/java/com/github/ambry/clustermap/MockDiskId.java
80.00% <0.00%> (-5.72%)
12.00% <0.00%> (-1.00%)

...github/ambry/rest/AsyncRequestResponseHandler.java
87.87% <0.00%> (-2.36%)
21.00% <0.00%> (ø%)

...java/com/github/ambry/network/SSLTransmission.java
70.15% <0.00%> (-0.93%)
75.00% <0.00%> (ø%)

...c/main/java/com/github/ambry/network/Selector.java
78.21% <0.00%> (-0.79%)
77.00% <0.00%> (-1.00%)

...ain/java/com/github/ambry/router/PutOperation.java
92.45% <0.00%> (-0.66%)
124.00% <0.00%> (-2.00%)

...src/main/java/com/github/ambry/commons/BlobId.java
93.03% <0.00%> (-0.35%)
72.00% <0.00%> (-1.00%)

...ls/src/main/java/com/github/ambry/utils/Utils.java
76.78% <0.00%> (-0.31%)
118.00% <0.00%> (-1.00%)

...in/java/com/github/ambry/store/BlobStoreStats.java
71.45% <0.00%> (+0.20%)
103.00% <0.00%> (ø%)

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2261cfb...a59a02d. Read the comment docs.


ConnectTimeout not working for ConnectAsync

FTP OS: Windows
Computer OS: Windows 10 21H2
FluentFTP Version: 37.0.0
Target framework: .NET Framework 4.7.2
When calling ConnectAsync() and the host doesn't exist it takes 21 seconds before there is a timeout.
Below is the code I use.
using (var conn = new FtpClient())
{
conn.Host = "<IP_ADDRESS>";
conn.Credentials = new NetworkCredential("ftptest", "ftptest");
conn.ConnectTimeout = 5000;
await conn.ConnectAsync();
}
When calling Connect() the timeout works fine.
Logs :

# ConnectAsync()
# ConnectAsync()
Status:   Connecting to <IP_ADDRESS>:21
Status:   Connecting to <IP_ADDRESS>:21
Exception thrown: 'System.Net.Sockets.SocketException' in System.dll
Exception thrown: 'System.Net.Sockets.SocketException' in mscorlib.dll
Exception thrown: 'System.Net.Sockets.SocketException' in mscorlib.dll
Exception thrown: 'System.Net.Sockets.SocketException' in mscorlib.dll
Exception thrown: 'System.Net.Sockets.SocketException' in mscorlib.dll
Exception thrown: 'System.Net.Sockets.SocketException' in mscorlib.dll

# Dispose()
# Dispose()
Status:   Disposing FtpClient object...
Status:   Disposing FtpClient object...
Status:   Disposing FtpSocketStream...
Status:   Disposing FtpSocketStream...
Status:   Disposing FtpSocketStream...
Status:   Disposing FtpSocketStream...

Thanks for reporting this.

FTP OS: Windows 10 21H2
FluentFTP Version: 32.4.4
Target framework: .Net Core 2.x (UWP)
FtpClient ftp = new FtpClient("ftp://" + ip + "/");
ftp.Credentials = new NetworkCredential(Login, Password);
ftp.DataConnectionType = FtpDataConnectionType.PASVEX;
ftp.ConnectTimeout = 2500;
await ftp.ConnectAsync();

I measured that it takes ~20 seconds to time out.

Can you try this @Wufus.
Release.zip
I added tests and it worked for me. If you want you can try the same tests and see, its under ConnectionTests > ConnectTimeoutAsync.

Released.
https://www.nuget.org/packages/FluentFTP/39.0.1
I'm closing this ticket as my unit tests are passing.
If you still have this issue, make a new ticket.


TileEngine layerCollidesWith missbehaving?

Hi! I'm trying out this engine and I have this basic code (slightly modified from the tileengine example):
kontra.init()

let { initInput, onInput, TileEngine, dataAssets } = kontra;

initInput()

kontra.load('player.png', 'tilesheet.json', 'tilesheet.png').then(function(){
    let tilesheet = dataAssets.tilesheet
    let tileEngine = TileEngine(tilesheet)

    var player = kontra.Sprite({
        x: 32 * 10,
        y: 32 * 16,
        image: kontra.imageAssets.player,
        width: 32,
        height: 32,
        collisionBox: {
            x: (32 * 10) + 1,
            y: (32 * 16) - 1,
            width: 30,
            height: 30,
        },
        resetCollisionBox: function(){
            this.collisionBox = {
                x: this.x + 2,
                y: this.y - 2,
                width: 28,
                height: 28,
            }
        },
    })

    tileEngine.add(player)

    onInput(['arrowleft', 'swipeleft', 'dpadleft'], () => {
        player.resetCollisionBox()
        player.collisionBox.x -= 32
        // don't move the player if he collides with the collision layer
        if (tileEngine.layerCollidesWith('blocks', player.collisionBox)) {
            return;
        }

        player.x -= player.width;
    });
    onInput(['arrowright', 'swiperight', 'dpadright'], () => {
        player.resetCollisionBox()
        player.collisionBox.x += 32
        // don't move the player if he collides with the collision layer
        if (tileEngine.layerCollidesWith('blocks', player.collisionBox)) {
            return;
        }

        player.x += player.width;
    });
    onInput(['arrowup', 'swipeup', 'dpadup'], () => {
        player.resetCollisionBox()
        player.collisionBox.y -= 32
        // don't move the player if he collides with the collision layer
        if (tileEngine.layerCollidesWith('blocks', player.collisionBox)) {
            return;
        }

        player.y -= player.height;
    });
    onInput(['arrowdown', 'swipedown', 'dpaddown'], () => {
        player.resetCollisionBox()
        player.collisionBox.y += 32
        // don't move the player if he collides with the collision layer
        if (tileEngine.layerCollidesWith('blocks', player.collisionBox)) {
            return;
        }

        player.y += player.height;
    });

    var loop = kontra.GameLoop({
        update: function() {
            player.update()
        },
        render: function() {
            tileEngine.render()
        }
    })
    loop.start()
})

But it seems to be detecting collisions when it shouldn't. For example, on this instance:

I'm trying to move to the left, and it's not letting me, when it should.
Here are the tilesheet and player files:

Here is the tilesheet.json
{ "backgroundcolor":"#090a00",
 "compressionlevel":-1,
 "height":20,
 "infinite":false,
 "layers":[
        {
         "data":[    0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
                     0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
                     0, 0, 1, 4, 5, 15, 16, 4, 11, 4, 4, 4, 9, 5, 5, 13, 13, 4, 0, 0,
                     0, 0, 14, 7, 5, 23, 24, 5, 0, 0, 0, 0, 11, 1, 0, 0, 0, 12, 0, 0,
                     0, 0, 13, 13, 12, 9, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 13, 0, 0,
                     0, 0, 14, 13, 8, 7, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 5, 0, 0,
                     0, 0, 12, 12, 14, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 4, 0, 0,
                     0, 0, 1, 5, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0,
                     0, 0, 11, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 15, 16, 0, 0, 0,
                     0, 0, 10, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 23, 24, 1, 0, 0,
                     0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 4, 0, 0, 0,
                     0, 0, 1, 0, 3, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 5, 0, 0,
                     0, 0, 9, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 0, 0,
                     0, 0, 8, 7, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 9, 0, 0,
                     0, 0, 13, 7, 14, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 11, 11, 0, 0,
                     0, 0, 8, 12, 0, 3, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 9, 9, 0, 0,
                     0, 0, 7, 13, 15, 16, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 15, 16, 0, 0,
                     0, 0, 1, 5, 23, 24, 11, 0, 0, 0, 0, 0, 0, 0, 1, 5, 23, 24, 0, 0,
                     0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
                     0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0],
         "height":20,
         "id":1,
         "name":"blocks",
         "opacity":1,
         "type":"tilelayer",
         "visible":true,
         "width":20,
         "x":0,
         "y":0
        }],
 "nextlayerid":2,
 "nextobjectid":1,
 "orientation":"orthogonal",
 "renderorder":"right-down",
 "tiledversion":"1.9.2",
 "tileheight":32,
 "tilesets":[
        {
         "columns":8,
         "firstgid":1,
         "image":"tilesheet.png",
         "imageheight":256,
         "imagewidth":256,
         "margin":0,
         "name":"tilesheet",
         "spacing":0,
         "tilecount":64,
         "tileheight":32,
         "tilewidth":32
        }],
 "tilewidth":32,
 "type":"map",
 "version":"1.9",
 "width":20
}

Am i doing something wrong?
Thanks!

I can look at this later, but from a quick look at the code it might be the collision box code is giving you a larger hit box? For example, when you move left the collision box is reset to be slightly above the player (this.y - 2), so if that extra 2 pixels goes into the tile above the players new position, it'll register a collision. It
I would recommend making the collision box smaller than the player, which it looks like your doing but might have reversed the y sign?
var player = kontra.Sprite({
    x: 32 * 10,
    y: 32 * 16,
    image: kontra.imageAssets.player,
    width: 32,
    height: 32,
    collisionBox: {
        x: (32 * 10) + 2,
        y: (32 * 16) + 2,
        width: 28,
        height: 28,
    },
    resetCollisionBox: function(){
        this.collisionBox = {
            x: this.x + 2,
            y: this.y + 2,
            width: 28,
            height: 28,
        }
    },
})

Oh for the love of god, that was it lol
It's always the typos!
Thanks!


Optimization: concat function

Which issue does this PR close?

Closes https://github.com/apache/arrow-datafusion/issues/9742
Rationale for this change
optimize concat and concat_ws function.
Benchmark(only concat)
Gnuplot not found, using plotters backend
concat function/concat(old)/1024
                        time:   [91.562 µs 91.725 µs 91.905 µs]
Found 8 outliers among 100 measurements (8.00%)
  6 (6.00%) high mild
  2 (2.00%) high severe
concat function/concat(new)/1024
                        time:   [17.831 µs 17.877 µs 17.934 µs]
Found 9 outliers among 100 measurements (9.00%)
  7 (7.00%) high mild
  2 (2.00%) high severe

concat function/concat(old)/4096
                        time:   [357.95 µs 358.98 µs 360.02 µs]
Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high severe
concat function/concat(new)/4096
                        time:   [71.003 µs 71.168 µs 71.326 µs]
Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high mild

concat function/concat(old)/8192
                        time:   [758.82 µs 761.43 µs 764.82 µs]
Found 2 outliers among 100 measurements (2.00%)
  1 (1.00%) high mild
  1 (1.00%) high severe
concat function/concat(new)/8192
                        time:   [141.11 µs 141.44 µs 141.79 µs]

Attention
For the purpose of benchmarking, I haven't officially replaced the concat and concat_ws function yet. If the community finds this PR meaningful, I will proceed with the replacement.
What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

I also filed https://github.com/apache/arrow-datafusion/issues/9742 to track this improvement

Marking as draft as I think this PR is no longer waiting on feedback. Please mark it as ready for review when it is ready for another look

Thanks again @JasonLi-cn  🙏


4.1 compiler generates invalid programs for structs which use measure types

The combination of a struct, a measure type and no optimization can create incorrect programs which fail verification by peverify, and raise InvalidProgramException when run.
Repro steps

Take the following code:
type AStruct<[<Measure>]'u> =
    struct
    end

[<EntryPoint>]
let main argv =
    let x = AStruct()
    0

Compile the code without optimization using version 4.1 of the F# compiler:
PS> &"C:\Program Files (x86)\Microsoft SDKs\F#\4.1\Framework\v4.0\Fsc.exe" --optimize- .\Program.fs
Microsoft (R) F# Compiler version 4.1
Copyright (c) Microsoft Corporation. All Rights Reserved.

Run the code:
PS> .\Program.exe

Unhandled Exception: System.InvalidProgramException: Common Language Runtime detected an invalid program.
   at Program.x@7..ctor()
   at Program.main(String[] argv)

Verify the code:
PS> peverify.exe Program.exe

Microsoft (R) .NET Framework PE Verifier.  Version  4.0.30319.0
Copyright (c) Microsoft Corporation.  All rights reserved.

[IL]: Error: [...\Program.exe : Program::main][offset 0x00000005][found ref 'Program+x@7'][expected value 'Program+AStruct'] Unexpected type on the stack.
[IL]: Error: [...\Program.exe : Program+x@7::.ctor][offset 0x00000009] Return from .ctor when this is uninitialized.
2 Error(s) Verifying Program.exe

Expected behavior
Program runs without crashing, and verification with peverify completes without reporting any errors.
Actual behavior
The program crashes with an InvalidProgramException, and verification with peverify reports 2 errors.
Known workarounds
Either:

Use a class instead of a struct
don't use a measure type
Turn on optimization

Related information

Operating system: Windows 10 (Anniversary Update)
.NET Runtime, CoreCLR or Mono Version: .Net 4.6.2
Indications of severity: prevents use of measure types with structs

This is related to 0fe9edd58d485c79ae048643ad71e00721c7f6ab - reverting the changes it made prevents the errors described above from happening.
I'll investigate further tomorrow.

@cartermp This is a regression unfortunately

Noted.  Added to the list to document.

A few more observations:

The original failing code above used an implicitly dimensionless unit of measure:
type AStruct<[<Measure>]'u> =
    struct
    end

[<EntryPoint>]
let main argv =
    let x = AStruct() // This doesn't work
    0

Implicitly using a measure type also fails:
type AStruct<[<Measure>]'u> =
    struct
        val X : float<'u>
    end

[<Measure>] type u

[<EntryPoint>]
let main argv =
    let x = AStruct() // This also doesn't work
    printfn "%g" (x.X + 1.0<u>)
    0

However, explicitly specifying a dimensionless unit works:
type AStruct<[<Measure>]'u> =
    struct
    end

[<EntryPoint>]
let main argv =
    let x = AStruct<1>() // This is fine
    0

And explicitly providing a measure type works:
type AStruct<[<Measure>]'u> =
    struct
    end

[<Measure>] type u

[<EntryPoint>]
let main argv =
    let x = AStruct<u>() // This is fine
    0

The reason that the explicit versions continue to work after the commit which added isLocalTypeFunc to the match expression ((1) below), is that they are passed as Const not TyLambda, so their path of execution is unchanged i.e. they pass through (2) below:
and GenBindRhs cenv cgbuf eenv sp (vspec:Val) e =
    match e with
    | Expr.TyLambda _ | Expr.Lambda _ ->
        let isLocalTypeFunc = IsNamedLocalTypeFuncVal cenv.g vspec e

        match e, isLocalTypeFunc (* (1) *) with
        | Expr.TyLambda(_, tyargs, body, _, _), true when
            (
                tyargs |> List.forall (fun tp -> tp.IsErased) &&
                (match StorageForVal vspec.Range vspec eenv with Local _ -> true | _ -> false)
            ) ->
            // type lambda with erased type arguments that is stored as local variable (not method or property)- inline body
            GenExpr cenv cgbuf eenv sp body Continue
        | _ ->
            let selfv = if isLocalTypeFunc then None else Some (mkLocalValRef vspec)
            GenLambda cenv cgbuf eenv isLocalTypeFunc selfv e Continue
    | _ -> // (2)
        GenExpr cenv cgbuf eenv sp e Continue

I looked into this a bit more. Here are some other ways that work to fix this:
type AStruct<[<Measure>]'u> =
    struct
    end

[<EntryPoint>]
let main argv =
    let x = fun () -> AStruct() // This works, you can also do: let x () = AStruct()
    printfn "%A" (x())
    0

or
type AStruct<[<Measure>]'u> =
    struct
        val X : float<'u>
    end

[<Measure>] type u

[<EntryPoint>]
let main argv =
    let x = AStruct().X + 1.0<u> // This also works
    0

As far as I can see it seems quite specific. I'm making an attempt to fix it here: https://github.com/Microsoft/visualfsharp/pull/2404


Ollama-rs integration

This PR integrates Ollama-rs and feature-gates it with the ollama feature.

Re-Implements OllamaEmbedder using the new client, the embedding_ollama.rs example is working.

Implements the language_models::llm::LLM trait for Ollama, the llm_ollama.rs example is working.

Also allows OpenAI compatible Ollama usage by implementing async_openai::config::Config for OllamaConfig, this part is not feature-gated as it does not require Ollama-rs package.

Closes #148 : Initially we had talked about adding an option to auto-pull a model if it does not exist and such, but with Ollama-rs integrated, we can simply leave that to the user. The pull code is a simple one-liner using the Ollama-rs client, and our tools request the client be created from the outer scope and passed in using Arc. So if one needs to pull a model, they can do it before passing in the model with their own logic (e.g. with retries, timeouts, cancellations)

Opens up the way for #149 as we will basically have access to function calls when the PR: https://github.com/pepperoni21/ollama-rs/pull/51 is merged!

[!NOTE]
@prabirshrestha Im currently opening this as a draft, because I couldn't implement the stream function for the LLM trait, and would like your opinion / help on that part! Ollama-rs has a streaming call itself, and I just have to map the items of this stream to the one that LLM trait wants, but for some reason I couldn't do it yet.
I will still be working on that, but would love your input if any 🙏🏻
EDIT: Streaming is done.

Have you tried using async_stream with yield. There are some usage patterns in the codebase already such as this and this. If you have issues with threading you can use flume which can be found here.

Have you tried using async_stream with yield. There are some usage patterns in the codebase already such as this and this. If you have issues with threading you can use flume which can be found here.

Looking into it, thanks!

I mapped the stream item using map_ok and the error with map_err, and returned resulting stream with Ok(Box::pin(stream)) and it works quite nicely!
Just one more question, what should be the contents of value of StreamData? I'm looking at the codebase but its still not clear to me, should I perhaps return the things returned by Ollama other than the message content as a Value?

Value is the raw json response from the server in case the user wants to access other properties from json. Most folks will only care about the content.
I'm wondering if we Item should be Result<Option<StreamData>, LLMError>> instead of Result<StreamData, LLMError>. I had mentioned my concerns https://github.com/Abraxas-365/langchain-rust/issues/140. Else based on the LLM provider we need to have a different error. Other option is to have the same error for all LLMs but since we are ending the call anyway I think Option is lot easier to work with.

Yea I think returning Option instead would be better DX instead of error handling. I will update the code with that, along with the edit to return the entire response as Value. 👍🏻

I'm ok changing to Option in a different PR.

Updated, also added a TODO note for that Option.

I have no idea why the build is failing btw :o

Merged. Thanks!

Thanks for the merge! Just saw the messages, was on road today.
I plan on handling the function call PR when Ollama-rs is updated as well, and maybe we may have to change a few lines on token count calculation implemented in this PR for Ollama, nothing big though 🙏🏻


Transfer - gauge gradle

Use org.gauge namespace to publish the plugin instead.

The decision to plublish the artifact as org.gauge was taken as the transfer of the plugin was not initiated. Please refer https://discuss.gradle.org/t/transfer-ownership-of-gauge-plugin/31099

gauge-gradle-plugin is published here.


Delete GroupsinKaizala.md

Deleting on behalf of Nitin

Docs Build status updates of commit a91b975:
:warning: Validation status: warnings

File
Status
Preview URL
Details

Articles/PartnerDocs/Kaizala_overview.md
:warning:Warning

Details

Articles/PartnerDocs/GroupsinKaizala.md
:white_check_mark:Succeeded

Articles/PartnerDocs/Kaizala_overview.md

[Warning] Missing attribute: title. Add a title string to show in search engine results.
Line 0: [Warning] Invalid file link:(~/PartnerDocs/GroupsinKaizala.md).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit ef70e15:
:warning: Validation status: warnings

File
Status
Preview URL
Details

Articles/PartnerDocs/Kaizala_overview.md
:warning:Warning

Details

Articles/PartnerDocs/GroupsinKaizala.md
:white_check_mark:Succeeded

Articles/PartnerDocs/Kaizala_overview.md

[Warning] Missing attribute: title. Add a title string to show in search engine results.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Remote lxd resources

Adds ability to customize the resources an LXD container uses when deployed (Network/Storage). Primarily this allows for customizing these resources for different remote deployment targets.
Changes:

Can specify Network/Storage/Profile to be used for deplyoment in Bravefile Service section or deploy CLI command
Can associate a default Profile/Network/Storage with a remote, which will be used if none provided in Bravefile/CLI
If Profile/Network/Storage still not provided, loads Host configured Profile/Network/Storage for backwards compatability

Note that selecting a disk device to launch the container with will show up when running brave units.
brave units

NAME            STATUS  IPV4            VOLUMES         PORTS
mongodb-amd64   Running <IP_ADDRESS>       root:->/        27017:27017

Would you be able to update the documentation (https://bravetools.github.io/bravetools/docs/bravefile/) to reflect how the bravefile service section has changed?

Added to the example in the service section of the docs demonstrating the use of the new fields added.


Document how to update the server when the OpenAPI specification has been updated

done

PR is blocked, see this comment

@gkowalski I've now updated several times the implementation following an update of the OpenAPI specifications. I will write the update process once and reuse it for all our API implementations.


363 find a way to add images to delivery sign up

Describe your changes
Closes #363
Add images to programs

Update for dispatchers:

Hey folks, as requested you can now add photos to programs so we can show riders what the deliveries look like. I've gone ahead and updated the photos from the spreadsheet for

TODO:
- [ ] I think a generic description or notes would be good here. I think we have something in the db we should just expose it #392

[x] Bug where when I delete a photo and upload a new one the deleted photo sticks around
[x] Tests

Checklist before requesting a review

[x] I have performed a self-review of my code
[x] If it is a core feature, I have added tests.
[x] Are there other PRs or Issues that I should link to here?
[x] Will this be part of a product update? If yes, please write one phrase
about this update in the description above.

Looking good so far! Maybe let's add a small header above the photos on the campaign signup to say "Photos campaign delivery" or something better than that.

Good idea!

I think I'd change "Campaign photos" to something a bit more descriptive:
 Delivery examples
{Program name} usually delivers {Enum.join(program.items)}

Other than that, tested and good to go.

I don't think they're always delivery examples though, eg sometimes they me be maps
May I'll leave it as photos of the delivery but not do the "usually delives" bit?
Also see #392

I realized #392 was already done, but I added a little photo description field to follow the spreadsheet example:


Per Page Presets change after changing page size

So when the pagination starts off, my preset per-page options are [10,25,50,100,250]. If I select 250 from the dropdown, 250 (im assuming, never counted) results show up. The per-page dropdown then gets set to 100 and the list is updated to have the options [10,25,50,100]. 250 is no longer an option, even if you set it back to 10 per page. In my offline usage, i am seeing 267 pages @ 10 per page (by default), so I know I have 250+ results. Any idea why this would be happening?

Weird, thanks for reporting. I'm not able to reproduce using the demo at http://begriffs.github.io/angular-paginate-anything/ what version of the library are you using?

Happy to help. I'll look into it further today and get you the version
number.
On Fri, Jun 3, 2016 at 12:36 PM Joe Nelson<EMAIL_ADDRESS>wrote:

Weird, thanks for reporting. I'm not able to reproduce using the demo at
http://begriffs.github.io/angular-paginate-anything/ what version of the
library are you using?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/begriffs/angular-paginate-anything/issues/96#issuecomment-223628883,
or mute the thread
https://github.com/notifications/unsubscribe/ABPOdDDEtM1lP9SZ2EBnvu01LMkAu77Yks5qIFgogaJpZM4Itf2-
.

Ok, no error here. As I dug through to find the problem, it was traced back
to my server side, where I essentially implemented my own version of your
clean-pagination gem. I had a MAX_PAGE_SIZE set to 100. Seems to be ok
after setting that.
Sorry for the false report, clearly the javascript is behaving as expected
:)
On Mon, Jun 6, 2016 at 1:03 PM Chase Pollock<EMAIL_ADDRESS>wrote:

Happy to help. I'll look into it further today and get you the version
number.
On Fri, Jun 3, 2016 at 12:36 PM Joe Nelson<EMAIL_ADDRESS>wrote:

Weird, thanks for reporting. I'm not able to reproduce using the demo at
http://begriffs.github.io/angular-paginate-anything/ what version of the
library are you using?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/begriffs/angular-paginate-anything/issues/96#issuecomment-223628883,
or mute the thread
https://github.com/notifications/unsubscribe/ABPOdDDEtM1lP9SZ2EBnvu01LMkAu77Yks5qIFgogaJpZM4Itf2-
.

OK, glad you figured it out.


Add annotation for G101 linter suppression

Description
Annotating another case of G101: Hardcoded credentials. This is the same instance found in #6238 that needs annotation. Stories for fixing these issues long term have already been created at: https://dp3.atlassian.net/browse/MB-7728

Warnings

:warning:

It looks like you are attempting to bypass a linter rule, which is not within
security compliance rules.
** Contains prohibited linter override "#nosec". **
Please remove the bypass code and address the underlying issue. cc: @transcom/Truss-Pamplemoose

:warning:
Please add the JIRA issue key to the PR title (e.g. MB-123)

  Generated by :no_entry_sign: dangerJS against 5c68c0208682c380ecc14b5709f3529b4b3c0026


repo collaborator can access all repositories of an organisation

Description
create a new user "guest"
(with no assignment to an organization)
in an organization with multiple repos create a new repo "test"
add guest as collaborator to test with "read" right.
logout
login as guest
guest can see all repositories of the org.
expected: guest should only be able to see the test repo.
Gitea Version
1.17.0
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
No response
How are you running Gitea?
downloaded windows binaries
Database
PostgreSQL

What's the organization's visibility? What's your other repositories' visibility?

organisation: public
repositories: public

public repository of public organization could be read by any user from that site.

thank you for the information.
this a bit confusing. what do you mean by "site" ?
i created the user -> user does not see any repository.
i added the user to the repository, not the organization -> user can see all repositories.
if this is as intended, then pls close the ticket and perhaps add this use case to the documentation.
thanks for the project and the good support.

What is the organisation visibility?
Is the Organisation PRIVATE, LIMITED or PUBLIC?
Is the User restricted?

@init-rz we need some more information about this in order to determine if this is working as intended or if there is a bug.

sorry, for late reply.
yes everything was set to "public" (default when creating organization/repo)

We close issues that need feedback from the author if there were no new comments for a month. :tea:


No need to escape path separator in INF

@AndrewGaspar,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

Thanks @AndrewGaspar this should be on the live site in a few minutes


performance sample count should be parameter in loadgen

Hello, currently performance_sample_count is passed as a parameter to the QSL constructor. Based on conversation with Dilip, this should be a parameter in loadgen instead. I assume this should be a TestSettings parameter that loadgen can then pass to QSL through GenerateLoadableSets?

This makes sense. The source of the samples shouldn't care about the a test or system constraint like the performance_sample_count.
Initially this sounds like just code cleanup, but if you think this will help with auditing this might make sense to prioritize. Is that the idea?

Yes, we could leverage this for auditing.
If you don't have anyone in mind, we can take care of this.

I do not have anyone in mind, so I'll put NVIDIA down. Thank you!


Fix cittedby for author page publications with multiple citeids

In author pages, a publication can aggregate together different google scholar citeids separated by comas like so :
https://scholar.google.fr/scholar?oi=bibs&hl=fr&cites=13804486329402855616,16026341598281412798,10132482875122586386,14743974300235144616&as_sdt=5
The current version only picks the first id which is a shame.
Changing the regexp seems to work just fine, but i don't know if it might break something elsewhere.

This seems like a reasonable solution. I'm gonna use this patch for my application and hope the admins can merge this for the next (minor) release; I say minor release because it might break other applications that assume citeids are always integers.

The current typing of the data structures assumes that the field "cites_id" is an integer. See
https://github.com/scholarly-python-package/scholarly/blob/master/scholarly/data_types.py#L166
If we want to convert it into a list of integers, then the data_types.py needs to change, and also the parsed result should be a list of integers (or a list with a single integer in it)

Right, I was going for cites_id to be of str type, with 0-9 and , being the allowable characters. We can validate this inside a setter method if needed. I can't think of a scenario where someone wants to do numerical operations with cites_id so I don't see the point of keeping them as integers or a list of integers.

If we want to allow multiple cites_id, then it needs to be explicit and be
a List. After that, each individual element can be an int or a string with
only digits.


Fix file name sanitization for zips with OS incompatible path separators

Ran into an issue with .zip files created from PowerShell Compress-Archive and a few other sources that contained "" as path separator instead of "/" from which sanitized_name() then returned incorrect PathBuf objects on Linux & Mac where entire path was a single long component causing issues in user code.
So Zip files can contain both / and \ as separators regardless of the OS, and as we want to return a sanitized PathBuf that only supports the OS separator let's convert incompatible separators to compatible ones.
If one doesn't do this then PathBufs will be returned that can have entire paths in the file name such as "src\lib.rs" on Linux/Mac, instead of "srv", "/", "lib.rs" as 3 separate components.

Although the zip-spec clearly states that all path separators are forward slashes, I think this does make sense in the sanitize function. Thank you for your contribution! :+1:

Thanks!


Improve codegen performance

Our code generation process could be faster: after running git clean -fdx then time make generate on my Macbook, it takes:
real	3m11.452s
user	8m37.271s
sys	0m22.347s

to build, find the services we support, parse the definition files, output our generated services, run rustfmt on them and adjust the documentation output to work with rustdoc.
Using this profiling guide I've found we tend to spend a good chunk of time interacting with our BTreeMap used in our botocore definitions. We use the BTreeMap because we want stable sorting of the keys: without stable sorting, the code diffs can be noisy when ordering of our generated file changes. See https://doc.rust-lang.org/std/collections/index.html for more info.
We could try using https://github.com/bluss/indexmap instead of BTreeMap to keep ordering but not deal with the O(log n) performance for both inserting and lookups. There's at least a few services that have a lot of items in them so O(log n) can be a bit rough.
Also, our use of doco.rs for adjusting the documentation may be able to be improved. https://github.com/rusoto/rusoto/blob/master/service_crategen/src/doco.rs#L37 may be able to switched to some kind of buffered writer.
This isn't a high priority at the moment, but it's something that can pay dividends as we continue to add more supported services. 😄

@matthewkmayer I'd be very interested in looking into this

Having investigated IndexMap I have a branch but it is waiting on this PR https://github.com/bluss/indexmap/pull/45 that enables Rayon as a feature flag. 🤞 it gets merged soon and can test

After the two PRs above we're down to these times for clean, build and run:
real	2m24.398s
user	7m18.002s
sys	0m14.760s

While swapping BTreeMap out for something else remains an option, I think we're good enough for now. 🎉
A PR for the collection type update would be nice to see if compile/run cycle times improves.


EXC_BAD_ACCESS Inside IvarAccess.h

Inside IvarAccess.h:
        case '@': {
            __block id out = trapped;

            xprotect( ^{
                uintptr_t uptr = *(uintptr_t *)iptr;
                if ( !uptr )
                    out = nil;
                else if ( uptr & 0xffffffff ) {
                    id obj = *(const id *)iptr; //EXC_BAD_ACCESS here
#ifdef XPROBE_MAGIC
                    [obj description];  // or EXC_BAD_ACCESS here
#endif
                    out = obj;
                }
            } );

            return out;
        }

This happens when I try to load my simulator app while it's running with the alcatraz plugin.

This normally happens when when there is a class somewhere in your app is using unsafe_unretained and has a pointer to an invalid object. I’ve pushed a minor change to exclude ReactiveCocoa which is one framework you might have problems with.


Android: Improve performance of sensor readings

Context
Once sensor listeners are registered, onSensorChanged() (and subsequently getRotatedValues()) get called multiple times per second. Obtaining WindowManager on each of those calls is superfluous and can be avoided by extracting it to a lazy class val. getRotatedValue() can also be called before checking sensor type, and used for each one of them, resulting in less code repetition.

Needs rebase after one of your recent merged PRs.

Thanks!


feat(points): Support earning points for depositing into earn pool

Description
For RET-1090. Adds support for depositing into earn pools.
Test plan
Manual and unit tested. See video below (excuse my laggy simulator!).
https://github.com/user-attachments/assets/38a8f8a1-5ac4-4c06-8ad1-ca4afd9563a8
Related issues

Fixes RET-1090

Backwards compatibility
Yes.
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will:

[x] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

oh, the long title unveiled the wrapping issue. addressed in #5652


[#108834896] Workaround for a dead-lock bug in Pivotal Tracker

Avoid concurrent API call because it causes dead-lock in their server-side.

LGTM

Explain what will be brought in the PR title rather than what you did.
IIUC the PR description, this PR slows the pivotal API calls down to avoid their dead-lock bug?

@yugui Yes that is correct. They have some dead-lock issue if we send these request asynchronizedly at the same time. I will rewrite the description.

LGTM

@yugui thank you, I misunderstood and changed the description only :bow:


Fixing Long-Flag Syntax and Missing Key-Path in txClient

Problem
Due to recent changes in the Dockerfile for txsim, the txClient in the e2e tests fails to run because of incorrect syntax used for long flags and a missing option to specify the key path where the keyring is located.
Acceptance Criteria
Fix the mentioned issue and ensure e2e tests pass with no issue.

Is this still a bug? The test-e2e CI task has been failing for a while but it's not clear to me if it's b/c of this or any of the other issues listed in https://github.com/celestiaorg/celestia-app/issues/4028

The concerns raised about the txclient in this issue, i.e.,

incorrect syntax used for long flags and a missing option to specify the key path

appear to have been addressed in the main branch. As the issue is no longer relevant, I’m closing it.


the new version 0.4.1 causes pyhive stuck

when downgrade to v0.3.0 the problem is gone.
how to reproduce:
from pyhive import hive

conn = hive.Connection(host='YOUR_HOST', port=10000, auth='LDAP', username='xx', password='yy', database='default')

def exec(sql):
    cursor = raw_c.cursor()
    cursor.execute(sql)
    cursor.fetchall()

exec('YOUR_SQL')

stack trace:
Traceback (most recent call last):
  File "testdb.py", line 42, in <module>
    exec('YOUR_SQL')
  File "testdb.py", line 30, in raw_exec
    cursor.fetchall()
  File "/usr/local/lib/python3.6/site-packages/pyhive/common.py", line 136, in fetchall
    return list(iter(self.fetchone, None))
  File "/usr/local/lib/python3.6/site-packages/pyhive/common.py", line 105, in fetchone
    self._fetch_while(lambda: not self._data and self._state != self._STATE_FINISHED)
  File "/usr/local/lib/python3.6/site-packages/pyhive/common.py", line 45, in _fetch_while
    self._fetch_more()
  File "/usr/local/lib/python3.6/site-packages/pyhive/hive.py", line 386, in _fetch_more
    response = self._connection.client.FetchResults(req)
  File "/usr/local/lib/python3.6/site-packages/TCLIService/TCLIService.py", line 714, in FetchResults
    return self.recv_FetchResults()
  File "/usr/local/lib/python3.6/site-packages/TCLIService/TCLIService.py", line 733, in recv_FetchResults
    result.read(iprot)
  File "/usr/local/lib/python3.6/site-packages/TCLIService/TCLIService.py", line 3470, in read
    self.success.read(iprot)
  File "/usr/local/lib/python3.6/site-packages/TCLIService/ttypes.py", line 6583, in read
    self.results.read(iprot)
  File "/usr/local/lib/python3.6/site-packages/TCLIService/ttypes.py", line 2867, in read
    _elem115.read(iprot)
  File "/usr/local/lib/python3.6/site-packages/TCLIService/ttypes.py", line 2741, in read
    self.stringVal.read(iprot)
  File "/usr/local/lib/python3.6/site-packages/TCLIService/ttypes.py", line 2521, in read
    _elem95 = iprot.readString().decode('utf-8') if sys.version_info[0] == 2 else iprot.readString()
  File "/usr/local/lib64/python3.6/site-packages/thrift/protocol/TProtocol.py", line 185, in readString
    return binary_to_str(self.readBinary())
  File "/usr/local/lib64/python3.6/site-packages/thrift/protocol/TBinaryProtocol.py", line 234, in readBinary
    s = self.trans.readAll(size)
  File "/usr/local/lib64/python3.6/site-packages/thrift/transport/TTransport.py", line 62, in readAll
    chunk = self.read(sz - have)
  File "/usr/local/lib/python3.6/site-packages/thrift_sasl/__init__.py", line 173, in read
    self._read_frame()
  File "/usr/local/lib/python3.6/site-packages/thrift_sasl/__init__.py", line 177, in _read_frame
    header = self._trans.read(4)
  File "/usr/local/lib64/python3.6/site-packages/thrift/transport/TSocket.py", line 126, in read
    buff = self.handle.recv(sz)    # got stuck here

Looks like a duplicate of 22


promote int to real, double-based divide function

to_real()
Add a special function:
real to_real(int);

[ ] code
[ ] tests
[ ] doc in manual

Suggested implementation:
double to_real(int x) { return x; }

Would this clearer with a static cast?
div()
Add a special function
real div(real,real);

[ ] code
[ ] tests
[ ] doc in manual

Suggested implementation:
double div(double x, double y) { return x / y; }

Motivation
The motivation is that I'm implementing some mark-recapture models that involve integer populations, but I need a fractional bound on a real parameter that's currently cumbersome to write:
data {
  int<lower=0> M;                       // marked
  int<lower=0> C;                       // captured
  int<lower=0,upper=min(M,C)> R;        // recaptured
}
transformed data { // HACK!
  real theta_max;
  theta_max <- M;
  theta_max <- theta_max / (C - R + M);
}
parameters {
  real<lower=0,upper=theta_max> theta;  // proportion marked
}
...

I would prefer to get rid of the transformed data division hack and just write:
parameters {
  real<lower=0,upper=div(M, C - R + M)> theta;  // proportion marked
}

Without the constraint, you get inconsistent values of theta that are above the upper bound.

These are easy enough to address.
@thelseraphim or @mitzimorris: if you have free cycles, this should be straightforward to tackle.

It hasn't been implemented yet.  The suggestion is for a function
real div(real x, real y);

so that we can do:
real x = div(1, 2);

and get 0.5 rather than the 0 we get with 1 / 2.  This is a minor issue.


React 16 support?

Hello!
RN 0.43 require to use react-16.
It'll be great to update this lib to use React 16.
Can we do that?

Should be compatible now. The only annoyance is not matching peer
dependency but that is not a blocker.
It makes sense to add react 16 to peer deps tho. Together with es6 classes
and publish major release
--
Nik Butenko
<EMAIL_ADDRESS>http://github.com/nkbt

I checked and it looks like we still can maintain older versions of React as peerDeps, so it should be safe to add v16 to the peers without major release.

@nkbt Nice! Thanks!

React v16.0 isn't released yet, but everything that works in v15.5.0, will keep working in v16.0, so this can be closed I think :-)
CC: @nkbt

@MichaelDeBoey what about <TransitionMotion />? Do we still need a <div /> to wrap child components?

Do we know when the support for React 16 will be released. I'm getting the following error after upgrading to React 16:
Cannot read property 'objectOf' of undefined
The error is happening in Motion.js:44 because of PropTypes:
defaultStyle: _react.PropTypes.objectOf(_react.PropTypes.number)

Motion with prop-types was release quite a long time ago.

I realized the problem is coming from swagger-ui which is using an older version of react-collapse v2.3.1
Sorry about that.

Are you able to tag a version from Master that "supports" React v16?
"react-motion": "0.5.1",
error<EMAIL_ADDRESS>|| ^15.3.0 doesn't satisfy found match of<EMAIL_ADDRESS>This has been resolved on the master branch.

I've published 0.5.2 with react 16 peerDependency, give it a shot!


Assertion failed error

As requested by the error message, filing a bug. The Haskell backend is at commit https://github.com/kframework/kore/commit/ec02c41d2ff5b970729cd980269a11b686e1e614 .
Error message:
kore-exec: [1752259445] Error (ErrorException):
    Assertion failed
    CallStack (from HasCallStack):
      assert, called at src/Kore/Equation/Application.hs:202:27 in kore-<IP_ADDRESS>-Jthz0usch8GLdmRl8yBuKn:Kore.Equation.Application
      attemptEquation, called at src/Kore/Step/Axiom/EvaluationStrategy.hs:122:13 in kore-<IP_ADDRESS>-Jthz0usch8GLdmRl8yBuKn:Kore.Step.Axiom.EvaluationStrategy
    Please file a bug report: https://github.com/kframework/kore/issues
Created bug report: kore-exec.tar.gz

Bug report file:
kore-exec-1.tar.gz

BTW, this happens in more than one multisig proof.

By any chance, does your semantics have simplification rules or function rules with quantifiers?

I don't think I have any explicit #Exists or Forall. I think all rules have implicit universal quantifiers, so those are not relevant. I didn't intentionally use implicit existential variables (question-mark ones) in function/simplification rules. I tried using one in a simplification rule and got the following error from kompile, so I guess I'm not using them at all:
[Error] Compiler: Cannot encode equations with existential variables to KORE.
 If this is desired, please use #Exists with regular variables.
 Offending variables: [?Type]

FWIW, this happens when a proof for a recursive definition reaches the point where the backend has to apply the claim itself to the configuration to finish the proof. That claim passes question-mark variables to functions.
Also FWIW, other proofs for loops/recursive stuff seem to work.

I managed to extract an example that reproduces this error much faster:
kore-exec.tar.gz

@virgil-serbanuta what command are you running, exactly?

Looks like the failing assertion was introduced in PR #2438

The assertion fails because we try to evaluate a term that contains an Equation Variable:
/* Fl Fn D Spa */
LblcanSignFunction'LParUndsRParUnds'EXECUTION-PROOF-HELPERS'Unds'Bool'Unds'UserRole{}(
    /* Fl Fn D Sfa */ EquationVar'Unds'15:SortUserRole{}
)

If we remove the assertion that enforces that at the term evaluation stage, the run seems to pass successfully.

  axiom{R} \implies{R} (
    \and{R} (
      \not{R} (
        \or{R} (
          \exists{R} (Var'Unds'5:SortMap{},
            \and{R} (
              \top{R}(),
              \and{R} (
                \in{SortExpressionList{}, R} (
                  X0:SortExpressionList{},
                  Lbl'LSqBUndsRSqBUnds'PSEUDOCODE-SYNTAX'Unds'ExpressionList'Unds'ExpressionCSV{}(Lbl'StopUnds'PSEUDOCODE-SYNTAX'Unds'ExpressionCSV{}())
                ),\and{R} (
                \in{SortMap{}, R} (
                  X1:SortMap{},
                  Var'Unds'5:SortMap{}
                ),
                \top{R} ()
              ))
          )),
          \or{R} (
          \exists{R} (Var'Unds'13:SortUsize{},
          \exists{R} (Var'Unds'15:SortUserRole{},
          \exists{R} (Var'Unds'16:SortMap{},
          \exists{R} (Var'Unds'14:SortExpressionCSV{},
            \and{R} (
              \equals{SortBool{},R}(
        LblcanSignFunction'LParUndsRParUnds'EXECUTION-PROOF-HELPERS'Unds'Bool'Unds'UserRole{}(Var'Unds'15:SortUserRole{}),
        \dv{SortBool{}}("true")),
              \and{R} (
                \in{SortExpressionList{}, R} (
                  X0:SortExpressionList{},
                  Lbl'LSqBUndsRSqBUnds'PSEUDOCODE-SYNTAX'Unds'ExpressionList'Unds'ExpressionCSV{}(Lbl'UndsCommUndsUnds'PSEUDOCODE-SYNTAX'Unds'ExpressionCSV'Unds'Expression'Unds'ExpressionCSV{}(inj{SortUsize{}, SortExpression{}}(Var'Unds'13:SortUsize{}),Var'Unds'14:SortExpressionCSV{}))
                ),\and{R} (
                \in{SortMap{}, R} (
                  X1:SortMap{},
                  Lbl'Unds'Map'Unds'{}(Lbl'UndsPipe'-'-GT-Unds'{}(inj{SortUsize{}, SortKItem{}}(Var'Unds'13:SortUsize{}),inj{SortUserRole{}, SortKItem{}}(Var'Unds'15:SortUserRole{})),Var'Unds'16:SortMap{})
                ),
                \top{R} ()
              ))
          ))))),
          \bottom{R}()
        ))
      ),
      \and{R}(
        \top{R}(),
        \and{R} (
          \in{SortExpressionList{}, R} (
            X0:SortExpressionList{},
            Lbl'LSqBUndsRSqBUnds'PSEUDOCODE-SYNTAX'Unds'ExpressionList'Unds'ExpressionCSV{}(Lbl'UndsCommUndsUnds'PSEUDOCODE-SYNTAX'Unds'ExpressionCSV'Unds'Expression'Unds'ExpressionCSV{}(Var'Unds'0:SortExpression{},VarEs:SortExpressionCSV{}))
          ),\and{R} (
          \in{SortMap{}, R} (
            X1:SortMap{},
            VarM:SortMap{}
          ),
          \top{R} ()
        ))
    )),
    \and{R} (
      \equals{SortInt{},R} (
        LblcountCanSignFunction'LParUndsCommUndsRParUnds'EXECUTION-PROOF-HELPERS'Unds'Int'Unds'ExpressionList'Unds'Map{}(X0:SortExpressionList{},X1:SortMap{}),
        LblcountCanSignFunction'LParUndsCommUndsRParUnds'EXECUTION-PROOF-HELPERS'Unds'Int'Unds'ExpressionList'Unds'Map{}(Lbl'LSqBUndsRSqBUnds'PSEUDOCODE-SYNTAX'Unds'ExpressionList'Unds'ExpressionCSV{}(VarEs:SortExpressionCSV{}),VarM:SortMap{})),
      \top{R}()))
  [org'Stop'kframework'Stop'attributes'Stop'Source{}("Source(/home/virgil/runtime-verification/verified-smart-contracts/multisig/protocol-correctness/proof/execution-proof.k)"), org'Stop'kframework'Stop'definition'Stop'Production{}("syntax #RuleContent ::= #RuleBody [klabel(#ruleNoConditions), symbol]"), contentStartLine{}("427"), contentStartColumn{}("8"), org'Stop'kframework'Stop'attributes'Stop'Location{}("Location(427,8,428,39)"), owise{}(), UNIQUE'Unds'ID{}("69752c727f774667b4457933ea2816d708efaf8c0790bb0a794101f9da9b2fba")]

simplifyTermLike is called at one point with:
/* Sfc */
\exists{_PREDICATE{}}(
    EquationVar'Unds'15:SortUserRole{},
    /* Sfc */
    \exists{_PREDICATE{}}(
        EquationVar'Unds'16:SortMap{},
        /* Sfc */
        \and{_PREDICATE{}}(
            /* Sfc */
            \equals{SortMap{}, _PREDICATE{}}(
                /* Fl Fn D Sfc */
                Lblconcat'LParUndsCommUndsCommUndsRParUnds'MAP-EXECUTE'Unds'Map'Unds'KItem'Unds'KItem'Unds'Map{}(
                    /* Fl Fn D Sfc */
                    /* Inj: */ inj{SortUsize{}, SortKItem{}}(
                        /* Fl Fn D Sfa */
                        Lblu'LParUndsRParUnds'PSEUDOCODE-SYNTAX'Unds'Usize'Unds'Int{}(
                            /* Fl Fn D Sfa */ ConfigVarV:SortInt{}
                        )
                    ),
                    /* Fl Fn D Sfa Cli */
                    /* Inj: */ inj{SortUserRole{}, SortKItem{}}(
                        /* Fl Fn D Sfa Cl */
                        LblBoardMember'Unds'PSEUDOCODE-SYNTAX'Unds'UserRole{}()
                    ),
                    /* Fl Fn D Sfa */
                    Lblopaque'LParUndsRParUnds'MAP-EXECUTE'Unds'Map'Unds'Map{}(
                        /* Fl Fn D Sfa */ ConfigVarVarUndsRemainder0:SortMap{}
                    )
                ),
                /* Fn Sfc */
                /* InternalMap: */ Lbl'Unds'Map'Unds'{}(
                    /* element: */ Lbl'UndsPipe'-'-GT-Unds'{}(
                        /* Fl Fn D Sfc */
                        /* Inj: */ inj{SortUsize{}, SortKItem{}}(
                            /* Fl Fn D Sfa */
                            Lblu'LParUndsRParUnds'PSEUDOCODE-SYNTAX'Unds'Usize'Unds'Int{}(
                                /* Fl Fn D Sfa */ ConfigVarV:SortInt{}
                            )
                        ),
                        /* Fl Fn D Sfc */
                        /* Inj: */ inj{SortUserRole{}, SortKItem{}}(
                            /* Fl Fn D Sfa */ EquationVar'Unds'15:SortUserRole{}
                        )
                    ),
                    /* opaque child: */ /* Fl Fn D Sfa */
                    EquationVar'Unds'16:SortMap{}
                )
            ),
            /* Sfa */
            \equals{SortBool{}, _PREDICATE{}}(
                /* Fl Fn D Sfa Cl */ \dv{SortBool{}}("true"),
                /* Fl Fn D Sfa */
                LblcanSignFunction'LParUndsRParUnds'EXECUTION-PROOF-HELPERS'Unds'Bool'Unds'UserRole{}(
                    /* Fl Fn D Sfa */ EquationVar'Unds'15:SortUserRole{}
                )
            )
        )
    )
)

@virgil-serbanuta It looks like a symbol you introduced has no evaluators:
  symbol Lblconcat'LParUndsCommUndsCommUndsRParUnds'MAP-EXECUTE'Unds'Map'Unds'KItem'Unds'KItem'Unds'Map{}(SortKItem{}, SortKItem{}, SortMap{}) : SortMap{} [functional{}(), org'Stop'kframework'Stop'attributes'Stop'Source{}("Source(/home/virgil/runtime-verification/verified-smart-contracts/multisig/protocol-correctness/proof/map/map-execute.k)"), priorities{}(), right{}(), terminals{}("11010101"), klabel{}("concat"), org'Stop'kframework'Stop'attributes'Stop'Location{}("Location(16,19,16,92)"), no-evaluators{}(), left{}(), format{}("%cconcat%r %c(%r %1 %c,%r %2 %c,%r %3 %c)%r"), function{}()]

Is this intentional?

Yes, it is intentional. I think I also added a "no-evaluators" attribute on it.
The Haskell backend does not send terms that might be undefined to the SMT solver, even if the side condition implies their definedness. In order to work around that, I needed a constructor-like symbol for maps, and an unevaluated function worked just fine.

@virgil-serbanuta The error that you see appears to be a consequence of the fact that the simplifier is unable to match your symbol with a map when applying the rule that I posted here yesterday. How exactly should this rule work?

Before answering:
The Haskell backend error message instructed me to file a bug report, so, I guess, anything that does not produce an assertion failure would probably be better.
Also, this rule looks something like this:
  rule countCanSignFunction([_:Expression, Es:ExpressionCSV], M)
      => countCanSignFunction([Es], M)
    [owise]

so I'm not sure why is this matching attempted. Is it part of the owise condition?
The actual answer:
I think that this rule should simply fail to apply to a countCanSignFunction whose map is a concat. If the Haskell backend thinks it needs to apply it, and reaches this point, it should probably say "I guess I can't apply function definition rules here after all" and it should leave the term unevaluated, and it should try to see if any simplification axiom can be applied instead.
I think (though I might be wrong) that this is what happens when trying to apply the non-owise definition rules for countCanSignFunction.
To generalize, I think that, when trying to apply a rule like f(X |-> Y M) => f(M) to f(Y:Map) or to f(opaque(M)) or to anything similar, it would just give up on applying this rule, exactly because it can't match X |-> Y M to opaque(M).

I'm not sure why is this matching attempted. Is it part of the owise condition?

Yes, the owise generates \not \exists clauses in the rule.

Because we rename equation variables before matching, it is safe to remove this assertion.

@ttuegel It's not that assertion that's failing though; it's this one


#589: Make the constructors of FkHitRefresh compliant with ConstructorOnlyInitializesOrCallOtherConstructors

Fix for https://github.com/yegor256/takes/issues/589
The goal of this PR is to make the class FkHitRefresh compliant with the rule ConstructorOnlyInitializesOrCallOtherConstructors by delegating the construction of the file to touch to a private static method.

@essobedo Thanks for the pull request, let me find a reviewer..

@longtimeago review this one, please

@essobedo see one remark above, thanks!

@essobedo much better now :)
Thanks!

@rultor merge

@rultor merge

@longtimeago Thanks for your request. @yegor256 Please confirm this.

@longtimeago thank you for the review

@essobedo you are welcome :)

@yegor256 please confirm

@yegor256 please confirm

@yegor256 This PR is waiting for a confirmation for more than a week now, so could you please do something about it? confirm it or reject it but please do something about it.

@essobedo one comment above

@yegor256 thank you for the review and the remark. Please have a look to the new version of the PR. Thank you in advance.

@yegor256 please review the PR

@yegor256 please review the PR

@rultor try to merge

@rultor try to merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@yegor256 thx

@rultor try to merge

@yegor256 Done! FYI, the full log is here (took me 10min)

@elenavolokhova please, help us to evaluate quality here, as per par.24

@rultor please deploy

@rultor please deploy

@davvd OK, I'll try to deploy now. You can check the progress here

@rultor please deploy

@davvd Done! FYI, the full log is here (took me 20min)

@longtimeago
According to our quality rules:

The code reviewer found at least three problems in the code.

Only one issue was found during review.
Please confirm that you will try to find at least three problems next time.

@elenavolokhova I confitm

@davvd Quality is acceptable here.

@davvd Quality is acceptable here.

@elenavolokhova thanks for the QA review, we'll work better next time

@longtimeago paied 10 mins to @elenavolokhova for QA review (payment ID is 79180755); Much appreciated! 22 mins was added to your account, payment ID 79180778, time spent is 382 hours and 14 mins; you're getting extra minutes here (c=7); +22 to your rating, your total score is +6596


[QA-491] Possible problems implementation

This PR is for error handling for possible problems the program may run into. The full list of problems and explanation  is documented in error_handling.md under documentation folder
Build and test:

./environment_setup.sh to set up bazel environment
./build_and_test.sh to build the programs and run all tests

Run the program:
E.g

./bazel-bin/src/send --shm /shmName --file sendFile
./bazel-bin/src/receive --shm /shmName --file receiveFile

Didn't achieve to copy: each time the sender throws

I have found why:
https://stackoverflow.com/questions/24385254/at-what-size-of-file-seekg-or-tellg-fails
seekg will fail for files more than 2GB.

The beta version will be used for this PR, readFilePipe and writeFilePipe will be rewritten as one readFile and writeFile method for all Ipc methods in the next PR


logs error

I still have this error no mather what I setup for path and no mathere where is folder logs, with all premission 777
"Logging is enabled but we can't write in the logging path"
for now logs folder is in ../public/mpos/logs

Hello! each time the server is restarted from this error.
I also went through this problem and solved it like this.
Installed webmin, and ran the cronjobs for him.
http://i.imgur.com/oCtMhYv.png


Build fails

running make I get:
protoc -I rpc rpc/rpc.proto --go_out=plugins=grpc:rpc
google/protobuf/empty.proto: File not found.
google/protobuf/timestamp.proto: File not found.
rpc.proto: Import "google/protobuf/empty.proto" was not found or had errors.
rpc.proto: Import "google/protobuf/timestamp.proto" was not found or had errors.
rpc.proto:66:5: "google.protobuf.Timestamp" is not defined.
rpc.proto:68:5: "google.protobuf.Timestamp" is not defined.
rpc.proto:69:5: "google.protobuf.Timestamp" is not defined.
rpc.proto:70:5: "google.protobuf.Timestamp" is not defined.
rpc.proto:133:5: "google.protobuf.Timestamp" is not defined.
rpc.proto:134:5: "google.protobuf.Timestamp" is not defined.
rpc.proto:143:5: "google.protobuf.Timestamp" is not defined.
rpc.proto:144:5: "google.protobuf.Timestamp" is not defined.
rpc.proto:7:21: "google.protobuf.Empty" is not defined.
rpc.proto:8:18: "google.protobuf.Empty" is not defined.
rpc.proto:8:50: "google.protobuf.Empty" is not defined.
rpc.proto:9:17: "google.protobuf.Empty" is not defined.
rpc.proto:9:49: "google.protobuf.Empty" is not defined.
rpc.proto:10:53: "google.protobuf.Empty" is not defined.
rpc.proto:11:15: "google.protobuf.Empty" is not defined.
rpc.proto:15:49: "google.protobuf.Empty" is not defined.
rpc.proto:16:63: "google.protobuf.Empty" is not defined.
rpc.proto:20:15: "google.protobuf.Empty" is not defined.
rpc.proto:20:47: "google.protobuf.Empty" is not defined.
make: *** [Makefile:36: rpc/rpc.pb.go] Error 1

This is a Fedora 31 where libprotoc is v3.6.1. FWIW, go is go version go1.13.3 linux/amd64

Thanks.


Publish in action GH marketplace

Follow FAIR software recommendations and publish action in GH marketplace.

Done, https://github.com/marketplace/actions/tortellini-action. Shoudl we close this issue?


Don't mutate process.env.NODE_ENV

I'm working on an Express app that builds Ghost into a subroute, and am having issues with Ghost mutating process.env.NODE_ENV.
I'd like to suggest that something like this be done instead:
// stage.js
module.exports = process.env.NODE_ENV || "development";

Then anywhere that needs to know the current env would just do
var stage = require('./stage');

This way, consumers of Ghost don't get weird side effects.

By all means send a PR, but please, just call it env or node-env. Stage is confusing IMO.

Ok, sure thing. I can send over a PR for this.

Isn't the only instance of NODE_ENV mutation in core/index.js?
That appears to use: process.env.NODE_ENV || "development";

@emars yes, that's the only place that mutates the process.env.NODE_ENV property - we do it just once.
But if you change this to export a module, everywhere which checks process.env.NODE_ENV (of which there are many) would also need to be updated to check the new module.

Sorry for the delay on the PR. I'll submit one soon.

I was looking into this issue it I found that ~20 or so tests end up failing when I refactored to use the module because they depend on the fact that NODE_ENV changes throughout the test.
Is this a good workaround?
// env.js
module.exports = function() {
    return process.env.NODE_ENV || "development";
}


How long will it take if i want training the model from scratch ?

I want to use bert-base-chinese to train a model, and judge whether an image and chinese sentence match

It varies according to your hardware setting and data size. In our setup, it takes 4 days with 8 V100. You can find more details on Section 3 of the paper.


Bundle id changer doesn’t work

Hi there! With the new app version there’s a bug:
i have “Install options” on and when i type in the new bundle id, it doesn’t change it.
Thanks in advance 😌

Should be fixed in 81dd1f644d45a00b2b842adeec4985f52121e1fe, a new version is coming soon. Thanks!


Enable code checks for pull requests

I notice you added a CI workflow at some point to run build, test, etc... However it seems that whenever a new PR is opened these aren't being forced to run and pass before merge.
It would be a good idea to enable this, we can help write some further tests so that we don't see regressions in future.

CI works on each pull request. The following changeset commit makes it look like that, but that's another issue.
See https://github.com/graphprotocol/graph-client/pull/246

@ardatan Ah, maybe something is missing. A few of these examples on the latest version should definitely cause build errors like I'm seeing with this one.
https://github.com/graphprotocol/graph-client/issues/248

@matthewlilley It is a missing test for your use case in GraphQL Mesh repository. I am closing this issue and let's track there.


Fix issue where non set optional values were transformed

fix: #583 and be compatible with backward which mentioned in #590

@rubenvanassche 😃  I think it's helpful. If you think this change useful too, please consider merging this.

Good solution, never would have though about that one. Hopefully it will not break performance too hard. Thanks

@rubenvanassche Probably just a nitpick, also didn't test it at all so I'm just talking out of my head right now: do we really want to do get_object_vars() inside the foreach loop? Can't we do $objectVars = get_object_vars($data); or something like this outside the loop, and referencing that variable inside the loop? I think it'd help a little if you have massive datasets if we didn't query all the object vars in every iteration from the exact same dataset.


Fake opam support of the exec subcommand

Is your feature request related to a problem? Please describe.
I am contributing on an OPAM-based OCaml project with both Nix and non-Nix people. I setup opam-nix for my convenience, but not everyone goes through it to work on the project in question. Now, for non-Nix OPAM-based scripts, it is common to prefix commands by opam exec -- to make sure that they are run in the correct environment. Because the fake opam command does not support exec, though, those scripts do not work for me. Depending on the version of opam-nix, I get either:
$ opam exec -- echo foo
2.0.0

or
$ opam exec -- echo foo
opam-nix fake opam doesn't understand these arguments: exec -- echo foo

Describe the solution you'd like
I would like for the fake opam command to recognize the exec subcommand. Considering that the fake opam only exists when in a Nix context, then opam exec should basically be a no-op running the given command (eg. opam exec - echo foo just runs echo foo).
Describe alternatives you've considered
For now, I am just stripping all uses of opam exec from scripts before running anything. This is doable and not very difficult. Alternatively, I could provide yet another fake opam in my Nix flake, taking precedence over opam-nix's, and recognizing exec. I feel the best would still be for it to be supported in opam-nix.

Yay :tada:


FW/Aliases: Inconsistent sorting

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[x] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug
The name sorting at 'Firewall' -> 'Aliases' (/ui/firewall/alias) is different than at 'Firewall' -> 'Diagnostics' -> 'Aliases' (/ui/firewall/alias_util).
In my opinion the sorting on the Diagnostics page is better because the internal aliases (prefixed with __) are at the bottom.
To Reproduce
Steps to reproduce the behavior:

Go to 'Firewall' -> 'Aliases'
Click on 'Name'

Expected behavior
Sorting to be same as at the Diagnostics page.
Describe alternatives you considered
None
Screenshots
Sorting at 'Firewall' -> 'Aliases' (/ui/firewall/alias)

Sorting at 'Firewall' -> 'Diagnostics' -> 'Aliases' (/ui/firewall/alias_util)

Relevant log files
None
Additional context
None
Environment
OPNsense 22.7.6-amd64
FreeBSD 13.1-RELEASE-p2
OpenSSL 1.1.1q 5 Jul 2022
AMD GX-412TC SOC (4 cores, 4 threads)

grids use natural sorting (for all fields), you can always exclude the internal types if it clutters your view.

This is a possible solution but would result in (up to) 12 additional clicks each time i load the page.
And i still find it inconsistent that /api/firewall/alias/searchItem (where the sorting happens) returns a different order than /api/firewall/alias_util/aliases/ (Firewall: Diagnostics: Aliases)


Would be nice if study summary table displayed info matching info in the metadata file

We had some confusion when searching the study table by title due to the fact that it is searching against the title in the metadata file, and this does not match the title in the study summary table itself. If would be nice if this information was in sync.

Thanks for the feedback and agree. Note that you can search by the study summary name using the search box on the right of the window

Cool - thanks! I wasn't understanding that but now I see.
On Aug 26, 2015, at 11:08 AM, Antonio Gonzalez <notifications<EMAIL_ADDRESS>wrote:
Thanks for the feedback and agree. Note that you can search by the study summary name using the search box on the right of the window
[screen shot 2015-08-26 at 11 06 45 am]https://cloud.githubusercontent.com/assets/2014559/9500438/b986c8dc-4be2-11e5-9a05-be5d9543a49b.png
—
Reply to this email directly or view it on GitHubhttps://github.com/biocore/qiita/issues/1445#issuecomment-135110222.

this has been superseded by the redbiom interface.


feat: override operation field types/nullability via directives

Description
Add directiveFieldMappings option to typescript-operations plugin to overriding operation field types via directives.
Related https://github.com/dotansimha/graphql-code-generator/issues/7356
I fixed @jenseng's implementation to follow master and pass tests.
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[x] I have followed the CONTRIBUTING doc and the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

Sorry for the delay in replying :bow:

I wonder whether it instead would make sense that the field types are wrapped within a generic.
That would allow more flexibility as well as allow chain ability of directives.

I too think that is a great idea! I will update this pull request or create a new one!

I updated the codes and PR description! please review them :pray:


How to remove spaces and blank lines in css file with gulp-clean-css ?

In the past I used gulp-minify-css to remove spaces and black lines.
Here is my gulpfiles.js code segment.
gulp.task('css', function () {
  return gulp.src('./css/**/*.css')
    .pipe(minifycss({
            compatibility: 'ie7'
        }))
    .pipe(gulp.dest('./build'));
});

It worked well.
Now I try to use  gulp-minify-css replace with  gulp-clean-css.
gulp.task('css', function () {
  return gulp.src('./css/**/*.css')
    .pipe(plumber())
    .pipe(autoprefixer({
        browsers: ['> 5%']
    }))
    .pipe(cleanCSS({
        advanced: false,
        compatibility: '',
        keepBreaks: false,
        keepSpecialComments: 0
    }))
    .pipe(gulp.dest('./build'));
});

It can not achieve the desired effect.  Where did I make the mistake?
What should I do?

This may be an issue that would need to be posted on https://github.com/jakubpawlowicz/clean-css/tree/3.4 - may not be an issue with the wrapper itself. It looks fine to me... Thoughts? @scniro

@erwstout that's what I am thinking as well. I see the "never" task has significantly different options passed to it. @titancat can you clarify what your expected result is? I assume you just with to minify the css but am unsure. I'd start by just removing the options to see what you get, but yes, if there is a minification error you'd want to investigate with clean-css itself.

@scniro @erwstout Maybe I should open an issue on clean-css.


protoc-gen-ng: Incorrect generation for AsObject interfaces in *.pb.ts files

Hi, thank you for this cool plugin protoc-gen-ng, we use it in our Angular app to abstract all the low level gRPC stuff from the business logic layers, and it works quite well!
Also, we use the AsObject interfaces to assert correct types/shape of mock data by binding request and response parameter to those types for our mock server (written in node/TS using @grpc/grpc-js).
import { Server } from '@grpc/grpc-js';
import { handleUnaryCall } from '@grpc/grpc-js';
import { SnakeCasedPropertiesDeep } from 'type-fest';
import * as resource from './generated/resource.pb';

type handleSnakyUnaryCall<Request, Response> = handleUnaryCall<
  SnakeCasedPropertiesDeep<Request>,
  SnakeCasedPropertiesDeep<Response>
>;

const listResources: handleSnakyUnaryCall<resource.ListResourcesRequest.AsObject, resource.ListResourcesResponse.AsObject> = (
  requestData,
  callback
) => { /* ... */ }

const addResourceServices = (server: Server): void => {
  const protoFileName = 'resource.proto';
  const descriptor = (getProtoDescriptorByProtoPath(protoFileName) as MakeService<'Resource'>).resource;
  server.addService(descriptor.ResourceService.service, {
    listResources,
    /* ... */
  });
};

/* then it's added to the Server instance */

But in the generation for proto maps I found an issue. So let's look at the generated maps.pb.ts in this repository (around line 460 in the generated file):
export module MessageWithMap {
  /**
   * Standard JavaScript object representation for MessageWithMap
   */
  export interface AsObject {
    mapStringString?: { [prop: string]: string };
    mapStringMsg?: { [prop: string]: MapSubMessage };
    mapStringBytes?: { [prop: string]: Uint8Array };
  }

The type of mapStringMsg should be { [prop: string]: MapSubMessage.AsObject };, because MapSubMessage is the class itself. I am not sure, if this would also be desirable for the 'AsProtobufJSON' helper, but I think so. So basically, nested types are not resolved for these helpers.
To reproduce:
I just cloned the repo and after npm install I called
$(pwd)/node_modules/.bin/grpc_tools_node_protoc --plugin=protoc-gen-ng=$(pwd)/dist/protoc-gen-ng/main.js --ng_out=config=packages/protoc-gen-ng/ngx-grpc.conf.js:packages/protoc-gen-ng/test/out -I packages/protoc-gen-ng/test/proto $(find ./packages/protoc-gen-ng/test/proto
-iname "*.proto")

The issue is fixed in v3.0.0, see CHANGELOG for details

Hi @smnbbrv,
in current v3.0.1 this issue is still not fixed. I'm sorry for taken that long to respond, but we needed to upgrade Angular first :)
To reproduce:

clone repo
npm i
mkdir ./packages/protoc-gen-ng/test/out
$(pwd)/node_modules/.bin/grpc_tools_node_protoc --plugin=protoc-gen-ng=$(pwd)/dist/protoc-gen-ng/main.js --ng_out=config=packages/protoc-gen-ng/ngx-grpc.conf.js:packages/protoc-gen-ng/test/out -I packages/protoc-gen-ng/test/proto $(find ./packages/protoc-gen-ng/test/proto -iname "*.proto")
See file packages/protoc-gen-ng/test/out/maps.pb.ts line 455

In https://github.com/ngx-grpc/ngx-grpc/commit/c1a86a6eebeae3e28da1cde30527ee7488ee5d2c it passes some options, are we supposed to configure this somehow, that nested AsObject types are used?

Hi @smnbbrv, do you accept PRs, maybe we can try to fix this?

Hi @oco2000
of course


Rename home.js to router.js

Feature
Why is this feature being added?
home.js says nothing about the functionality of the file. It's main job is as the "Home" scene's router.
What should your feature do?
Change home.js to router.js and fix any/all references.

@sethbergman mind if I grab this from you? It cascades into the Nav refactor

go for it!

can I take up this issue ?

@ishucr7 sorry to hoard it, but this issue directly correlates to another that I'm in the process of working on. Please let me know if you need help finding another issue! We would love to see your contribution.

Okay ! Kindly help me find another issue as I am a beginner and would love
to contribute
On Sep 7, 2017 4:45 AM, "Kyle Holmberg"<EMAIL_ADDRESS>wrote:

@ishucr7 sorry to hoard it, but this issue directly correlates to another
that I'm in the process of working on. Please let me know if you need help
finding another issue! We would love to see your contribution.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@ishucr7 I just made #477 - it looks like something you should be able to implement with little trouble.
If that is too much, I recommend upgrading some documentation here: #386
Lastly, feel free to scour our site for improvements and file issues as you see them! Create an issue concerning our current documentation if you feel it is "not up to snuff" in any manner.

Renaming the filename router.js may be OK but, if following convention, the component should also be renamed Router as well (to match the file name). This may cause confusion with the react-router Router. Perhaps it should be renamed something different? OCRouter? OperationCodeRouter?

@AryanJ-NYC I'll be trying to re-organize all the nav/router issues I own into more separate tasks and will explain the reasoning behind every choice. Looking at it now, perhaps index.js is the best move, but I'll explain why later tonight.

Evesy

Let me get off the phone. Lol


null value in _TabBarViewState._handleTabControllerAnimationTick

Steps to reproduce
I am not sure how to reproduce it, this is something only happening on production for my app, I guess is only happening in release mode. Crashlytics is spaming my console with this error.

Add TabBarView widget with a DefaultTabController as parent
Change tabs

Expected results
No error should be thrown
Actual results
FlutterError - Null check operator used on a null value. Error thrown .
Code sample
Code sample
There is no way to create a minimal reproducible sample

Screenshots or Video

This is the function breaking, !_controller!.indexIsChanging is null

Logs
Logs
Fatal Exception: FlutterError
0  ???                            0x0 _TabBarViewState._handleTabControllerAnimationTick + 1911 (tabs.dart:1911)
1  ???                            0x0 AnimationLocalListenersMixin.notifyListeners + 161 (listener_helpers.dart:161)
2  ???                            0x0 AnimationController.value= + 395 (animation_controller.dart:395)
3  ???                            0x0 TabController._copyWithAndDispose + 158 (tab_controller.dart:158)
4  ???                            0x0 _DefaultTabControllerState.didUpdateWidget + 501 (tab_controller.dart:501)
5  ???                            0x0 StatefulElement.update + 5652 (framework.dart:5652)
6  ???                            0x0 Element.updateChild + 3824 (framework.dart:3824)
7  ???                            0x0 ComponentElement.performRebuild + 5505 (framework.dart:5505)
8  ???                            0x0 StatefulElement.performRebuild + 5643 (framework.dart:5643)
9  ???                            0x0 Element.rebuild + 5196 (framework.dart:5196)
10 ???                            0x0 StatefulElement.update + 5666 (framework.dart:5666)
11 ???                            0x0 Element.updateChild + 3824 (framework.dart:3824)
12 ???                            0x0 ComponentElement.performRebuild + 5505 (framework.dart:5505)
13 ???                            0x0 StatefulElement.performRebuild + 5643 (framework.dart:5643)
14 ???                            0x0 Element.rebuild + 5196 (framework.dart:5196)
15 ???                            0x0 BuildOwner.buildScope + 2904 (framework.dart:2904)
16 ???                            0x0 WidgetsBinding.drawFrame + 989 (binding.dart:989)
17 ???                            0x0 RendererBinding._handlePersistentFrameCallback + 448 (binding.dart:448)
18 ???                            0x0 SchedulerBinding._invokeFrameCallback + 1386 (binding.dart:1386)
19 ???                            0x0 SchedulerBinding.handleDrawFrame + 1311 (binding.dart:1311)
20 ???                            0x0 SchedulerBinding._handleDrawFrame + 1169 (binding.dart:1169)

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.19.5, on macOS 14.4.1 23E224 darwin-arm64, locale en-AR)
    • Flutter version 3.19.5 on channel stable at /Users/martinpelli/Development/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 300451adae (12 days ago), 2024-03-27 21:54:07 -0500
    • Engine revision e76c956498
    • Dart version 3.3.3
    • DevTools version 2.31.1

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/martinpelli/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15C500b
    • CocoaPods version 1.15.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] IntelliJ IDEA Ultimate Edition (version 2023.3.2)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.88.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.84.0

[✓] Connected device (4 available)
    • Pelli’s iPhone (mobile) • 00008130-000A59E83660001C            • ios            • iOS 17.4.1 21E236
    • iPhone 15 Pro (mobile)  • B0ACA5DD-71DF-4E17-B4DC-14497D3A7917 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-17-0 (simulator)
    • macOS (desktop)         • macos                                • darwin-arm64   • macOS 14.4.1 23E224 darwin-arm64
    • Chrome (web)            • chrome                               • web-javascript • Google Chrome 123.0.6312.107
    ! Error: Browsing on the local area network for iPhone de Ezequiel. Ensure the device is unlocked and attached with a cable or associated with the same local
      area network as this Mac.
      The device must be opted into Developer Mode to connect wirelessly. (code -27)

[✓] Network resources
    • All expected network resources are available.

• No issues found!

I believe this is a duplicate of https://github.com/flutter/flutter/issues/86222.
Kindly follow up in the original issue for updates.
Closing in favor of the issue linked above.
Thank you


Drill Calcite 1.16.0-r2 to merge CALCITE-2242

To leverage FilterRemoveIsNotDistinctFromRule rule in Drill it should use input RelBuilder to create Filter RelNode. CALCITE-2242 solves it.

@amansinha100 Please review

+1


Update spotless-maven-plugin to 2.28.0

Codecov Report

Merging #563 (276f0c1) into main (9e6308b) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #563      +/-   ##
============================================
- Coverage     92.60%   92.51%   -0.10%
+ Complexity     2410     2407       -3
============================================
  Files           250      250
  Lines          5047     5047
  Branches        543      543
============================================
- Hits           4674     4669       -5
- Misses          247      249       +2
- Partials        126      129       +3

Impacted Files
Coverage Δ

...ain/java/net/datafaker/providers/base/Barcode.java
85.71% <0.00%> (-4.77%)
:arrow_down:

.../datafaker/transformations/sql/SqlTransformer.java
87.40% <0.00%> (-0.75%)
:arrow_down:

.../java/net/datafaker/service/FakeValuesService.java
87.10% <0.00%> (-0.22%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more