[SPARK-30154][ML] PySpark UDF to convert MLlib vectors to dense arrays

What changes were proposed in this pull request?
PySpark UDF to convert MLlib vectors to dense arrays.
Example:
from pyspark.ml.functions import vector_to_dense_array
df.select(vector_to_dense_array(col("features"))

Why are the changes needed?
If a PySpark user wants to convert MLlib sparse/dense vectors in a DataFrame into dense arrays, an efficient approach is to do that in JVM. However, it requires PySpark user to write Scala code and register it as a UDF. Often this is infeasible for a pure python project.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
UT.

Test build #115396 has started for PR 26910 at commit 794a10b.

Test build #115396 has finished for PR 26910 at commit 794a10b.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115396/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20201/
Test PASSed.

Test build #115401 has started for PR 26910 at commit afc71af.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20206/
Test PASSed.

Test build #115401 has finished for PR 26910 at commit afc71af.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115401/
Test FAILed.

Test build #115424 has started for PR 26910 at commit e2bb6c0.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20227/
Test PASSed.

Test build #115424 has finished for PR 26910 at commit e2bb6c0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115424/
Test PASSed.

@cloud-fan, I know UDT became private and we plan to redesign it later.
However, what about we allow the case when the UDT is cast into its own sqlType, or do you know why we don't allow this case?
scala> val df = Seq(Tuple1(org.apache.spark.ml.linalg.Vectors.dense(1.0, 2.0, 3.0))).toDF("vec")
df: org.apache.spark.sql.DataFrame = [vec: vector]

scala> df.selectExpr("cast(vec as string)").show()
+-------------+
|          vec|
+-------------+
|[1.0,2.0,3.0]|
+-------------+

scala> df.selectExpr("cast(vec as struct<type:tinyint,size:int,indices:array<int>,values:array<double>>)").show()
org.apache.spark.sql.AnalysisException: cannot resolve '`vec`' due to data type mismatch: cannot cast struct<type:tinyint,size:int,indices:array<int>,values:array<double>> to struct<type:tinyint,size:int,indices:array<int>,values:array<double>>; line 1 pos 0;
'Project [unresolvedalias(cast(vec#74 as struct<type:tinyint,size:int,indices:array<int>,values:array<double>>), None)]
+- Project [_1#71 AS vec#74]
   +- LocalRelation [_1#71]

  at org.apache.spark.sql.catalyst.analysis.package$AnalysisErrorAt.failAnalysis(package.scala:42)
  at org.apache.spark.sql.catalyst.analysis.CheckAnalysis$$anonfun$$nestedInanonfun$checkAnalysis$1$2.applyOrElse(CheckAnalysis.scala:146)
  at org.apache.spark.sql.catalyst.analysis.CheckAnalysis$$anonfun$$nestedInanonfun$checkAnalysis$1$2.applyOrElse(CheckAnalysis.scala:137)
  at org.apache.spark.sql.catalyst.trees.TreeNode.$anonfun$transformUp$2(TreeNode.scala:310)
  at org.apache.spark.sql.catalyst.trees.CurrentOrigin$.withOrigin(TreeNode.scala:72)

Currently, UDT can be cast to string but cannot be its own sqlType (https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/linalg/VectorUDT.scala#L88-L99).
It's internally InternalRow so I think it seems fine to allow this case for now.

Test build #115495 has started for PR 26910 at commit 5aacfbc.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20298/
Test PASSed.

Quote from @mengxr

what happens if I use a Pandas UDF to wrap the vector_to_array function, Does the array data get boxed somewhere in the conversion path ?

I think if this is true, this should be array type issue, not related to my vector_to_array function. Isn't it ? @HyukjinKwon

I don't think such things happen anyway. The problem is UDF itself as it needs to convert Catalyst type to Scala type and needs to convert it back.

Test build #115495 has finished for PR 26910 at commit 5aacfbc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115495/
Test PASSed.

@HyukjinKwon @mengxr @srowen Any more comments ? Thanks:)

Once we allow https://github.com/apache/spark/pull/26910#issuecomment-566842696 then I think we won't need this function.

@HyukjinKwon I don't think UDT change should block this PR. Even we can cast it to the sqlType, it is still tedious for a PySpark user to do this simple conversion. And Pandas UDF doesn't support nested columns. So they need to move the nested columns to top level.

@WeichenXu123 You haven't address the comment on running doctest yet.

@mengxr, sure, Once we allow cast or extraction from UDT directly, we can deprecate and remove out this API later.

Test build #115554 has started for PR 26910 at commit a41d01a.

Test build #115554 has finished for PR 26910 at commit a41d01a.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115554/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20357/
Test PASSed.

Test build #115565 has started for PR 26910 at commit 22865e0.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20365/
Test PASSed.

Test build #115565 has finished for PR 26910 at commit 22865e0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115565/
Test PASSed.

Test build #115639 has started for PR 26910 at commit d257dce.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20438/
Test PASSed.

Test build #115639 has finished for PR 26910 at commit d257dce.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115639/
Test PASSed.

LGTM. Merged into master. Thanks!


Several lists with pagination are paginated all at once

If I have a page where I have two lists with mixitup, and both of them have pagination, clicking a pager link on one of the lists changes the page on that list, as well as on the other list.
I'd expect the pagination links only to apply to the list they belong to.
Versions used:
MixItUp Pagination v1.1.0
mixitup 2.1.11

Ok, same solution as with #49 - though the behavior is pretty surprising - I wonder why the selectors are not scoped to the parent element?

This is to allow's the freedom to place your pager UI wherever you want in the document, but appreciate it's not intuitive. They will be locally scoped in the pagination extension for the upcoming MixItUp v3 - with a config option to make them global.

Ah, I understand - same should be true for all selectors (target, filter, sort, ...), right? I think the config option is the right way to go - I now have a weird workaround in place where I generate the class-names, so I'm looking forward to the new version.


pkg/prometheus: optional secret in scrapeconfig

This commit enables the creation of a Prometheus when
additionalScrapeConfigs is defined but points to a non-existent secret
and additionalScrapeConfigs.optional is set to true.
Formerly, the creation of the Prometheus would error; this change adds
support to respect the optional field.
Fixes: #2457

Thank you so much @squat!


[Bug]: SyntaxError: Unexpected token '?'

Please confirm that you have:

[X] Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
[X] Reproduced the issue in the latest CLI version.

In which of these areas are you experiencing a problem?
Other
Expected behavior
Installed according to documentation, but getting a syntax error running shopify version
Actual behavior
~$ shopify version
file:///usr/local/lib/node_modules/@shopify/cli/node_modules/@shopify/cli-kit/dist/public/node/cli.js:11
        process.env.DEBUG = process.env.DEBUG ?? '*';
                                               ^

SyntaxError: Unexpected token '?'
    at Loader.moduleStrategy (internal/modules/esm/translators.js:133:18)

Reproduction steps

sudo npm install -g @shopify/cli @shopify/theme
shopify version

Operating System
Ubuntu 22.04.2 LTS
Shopify CLI version (check your project's package.json if you're not sure)
can't get
Shell
bash
Node version (run node -v if you're not sure)
v12.22.9
What language and version are you using in your application?
ruby 3.0.2p107

hey @bergstar, the CLI requires node 16 or higher to work. Once you update your node installation the error should go away 👍


New package: StefanLobbenmeier.youtube-dl-gui version 2.5.4

Pull request has been created with komac v2.8.0 :rocket:
Microsoft Reviewers: Open in CodeFlow

Verify:

Hi @herquimos,
This PR is ready to merge. It just needs your agreement to the CLA. Let me know if you have any questions.


plz help

2019-08-12 17:16:06.469549: I tensorflow/core/platform/cpu_feature_guard.cc:142] Your CPU supports instructions that this TensorFlow binary was not compiled to use: AVX2 FMA
2019-08-12 17:16:06.893987: I tensorflow/core/platform/profile_utils/cpu_utils.cc:94] CPU Frequency:<PHONE_NUMBER> Hz
2019-08-12 17:16:06.894534: I tensorflow/compiler/xla/service/service.cc:168] XLA service 0x5052630 executing computations on platform Host. Devices:
2019-08-12 17:16:06.894586: I tensorflow/compiler/xla/service/service.cc:175]   StreamExecutor device (0): ,
2019-08-12 17:16:07.171002: W tensorflow/compiler/jit/mark_for_compilation_pass.cc:1412] (One-time warning): Not using XLA:CPU for cluster because envvar TF_XLA_FLAGS=--tf_xla_cpu_global_jit was not set.  If you want XLA:CPU, either set that envvar, or use experimental_jit_scope to enable XLA:CPU.  To confirm that XLA is active, pass --vmodule=xla_compilation_cache=1 (as a proper command-line flag, not via TF_XLA_FLAGS) or set the envvar XLA_FLAGS=--xla_hlo_profile.

This seems to be an installation problem.
Which command are you executing? At the moment I don't see how this problem relates to this project, so I would rather close it.

I just made the command python create_tfrecord.py. but when i see tfrecord folder i do not see any document please help.

Could you please post some information about your environment?
As for Tensorflow issues the following information would be helpful:

OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
TensorFlow installed from (source or binary):
TensorFlow version (use command below):
Python version:
CUDA/cuDNN version:
GPU model and memory:

You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with: 1. TF 1.0: python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)" 2. TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"
Also could you please post the full stack trace starting from executing the command till the end of the error message? Thanks


Rename AnimationQueue to Sequence and fix #151.

My suggestion is that we check this in "as is" because "it works" and then make the fixes I suggested in the email thread...

Works for me. +1

Did you expect me not to? As long as that other stuff is implemented, it all works for me.

Sorry, I was answering a github prompt.  It asked me if I wanted to dismiss your review that asked for changes when checking in, I said yes, and it asked why!

Oh...lol. Gotcha. Have never seen that.

First time I ever saw it either!!! :-o


information toast has close button out of the box

It probably can be renamed from "information" to "transaction is in block"
and then: Transaction hash: 69Z802OH(long string here)  plus see the transaction id

It probably can be renamed from "information" to "transaction is in block"
and then: Transaction hash: 69Z802OH(long string here) plus see the transaction id

As I got from the code, the transaction has not yet been sent to block when the information notification shows up. It means we could not show View Tx for it at that time.
No matter what, the issue of "information toast has close button out of the box  " could be fixed.

As I got from the code, the transaction has not yet been sent to block when the information notification shows up. It means we could not show View Tx for it at that time.

then lets not even show the transaction hash, what can user do with that?

As I got from the code, the transaction has not yet been sent to block when the information notification shows up. It means we could not show View Tx for it at that time.

then lets not even show the transaction hash, what can user do with that?

It just informs that tx has been generated and started broadcasting to the block.
When the tx is confirmed in the block, there will be another successful notification showing the block Id.

It just informs that tx has been generated and started broadcasting to the block. When the tx is confirmed in the block, there will be another successful notification showing the block Id.

then lets skip the hash notif

we wont show the hash notif, can we please solve the x-mark out of the box for these notifs (check all please)


Improve display of current heating mode

Hey,
it looks like your plugin determines the current heating mode by checking the target temperature against the actual indoor temperature. As long as the target temperature isn‘t reached, it‘s assumed that the thermostat is heating, and if it‘s warm enough inside, the thermostat should be off. This works in most cases, but since I had some problems from time to time with Tado, there should be a better approach. Could you use the heatingPower.percentage value instead? If it‘s greater than 0, the thermostat is definitely heating, else it is off.
Best regards,
Benno

Makes sense, I changed it in the latest version 0.3.2!


[SegmentedControl] Disabled items not supported

Hi,
it looks like the SegmentedControl.Item component doesn't support the disabled state out-of-the-box.
I can trick it by using the aria-disabled attribute, and changing the look and feel via CSS, but the Item is still clickable.
If I use pointer-events: none; it works, but I cannot customize the cursor.
Since the rendered component is a button, I wonder why it has been decided to remove disabled.
Do you know any good workaround?
Thanks,
Luca

Disabled items weren't implemented because of time constraints
We'll add this in one of the future versions


[Documentation] [5.x] New Async Functionality Missing From Docs

The API docs here:
https://expressjs.com/en/5x/api.html
And the migration guide:
https://expressjs.com/en/guide/migrating-5.html
Both currently fail to mention the killer feature of express 5, which is async/promise support middleware and routes.
Some of this might be https://github.com/expressjs/express/pull/4321 didn't ship yet, but either way, happy to start a PR with documentation changes reflecting the update. Please let me know if that would be appreciated.

Hi, I would like to contribute to this issue. Could you please assign this to me?
Thanks!


[AutoPR dns/resource-manager] typo: dns/Microsoft.Network

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/4686

This PR has been merged into https://github.com/Azure/azure-sdk-for-js/pull/699


schema(:type, field) changed behavior for embeds since ecto 3.5 release

Environment

Elixir version (elixir -v): 1.11.2 otp-23.1.4
Database and version: MySQL 5.7
Ecto version (mix deps): 3.5.5 from 3.4.6
Database adapter and version (mix deps): MyXQL
Operating system: MacOS 10.7

Current behavior
Failure to compile with this error:
** (RuntimeError) casting embeds with cast/4 for :foo field is not supported, use cast_embed/3 instead
    (ecto 3.5.5) lib/ecto/changeset.ex:541: Ecto.Changeset.cast_type!/2
    (ecto 3.5.5) lib/ecto/changeset.ex:515: Ecto.Changeset.process_param/7
    (elixir 1.11.2) lib/enum.ex:2181: Enum."-reduce/3-lists^foldl/2-0-"/3
    (ecto 3.5.5) lib/ecto/changeset.ex:501: Ecto.Changeset.cast/6

Digging into the function we're using __schema__(:type, field) to find out if the field is embedded or not, I dug into documentation to see an example and only found some test cases relevant. Seems like there is a new :parameterized type or something along the lines here that's breaking behavior.
Neither test here
https://github.com/elixir-ecto/ecto/blob/master/test/ecto/parameterized_type_test.exs#L42
and here
https://github.com/elixir-ecto/ecto/blob/master/test/ecto/schema_test.exs#L38
protect against changes in this function wrt embedded_schema.
Expected behavior
Compilation succeeds.
I fixed this internally by changing our behavior to match, but having a test to prevent this in the future might be nice.
before
{:embed,
 %Ecto.Embedded{
   cardinality: :many,
   field: :posts,
   on_cast: nil,
   on_replace: :delete,
   ordered: true,
   owner: Ecto.EmbeddedTest.Author,
   related: Post,
   unique: true
 }}

after
{:parameterized, Ecto.Embedded,
 %Ecto.Embedded{
   cardinality: :many,
   field: :posts,
   on_cast: nil,
   on_replace: :delete,
   ordered: true,
   owner: Ecto.EmbeddedTest.Author,
   related: Ecto.EmbeddedTest.Post,
   unique: true
 }}

I don't really know where to make that change, but I hope this gives you enough info to help test for it in the future. Happy holidays and thanks for all the effort and work y'all put into this!

To see if a fields is an embed, prefer using the :embeds and (:embed, name) reflection functions. Those will work regardless of version, as the actual type may indeed change.

Thanks for the response. Is it not at least worth documenting in the CHANGELOG when this changes? This is a public function which did cause a breaking change which would have been much quicker to resolve looking through it. We were using :type to do analysis on more than just :embeds so :type was the more appropriate approach for how we're using it since we're scanning all fields. We can definitely use the suggestion to make it always work, it's just not intuitive as to why we'd do that.

Thanks for the response. Is it not at least worth documenting in the CHANGELOG when this changes? This is a public function which did cause a breaking change which would have been much quicker to resolve looking through it. We were using :type to do analysis on more than just :embeds so :type was the more appropriate approach for how we're using it since we're scanning all fields. We can definitely use the suggestion to make it always work, it's just not intuitive as to why we'd do that.

Good call, changelog updated!

Good call, changelog updated!


Fix for "forms.office.com"

Crosspost from https://github.com/nextdns/metadata/pull/1074

Can't start when "Click to start" is pressed
The domain c.office.com has been CNAME blocked c.msn.com by Steven Black's hosts and Ad-wars
Link: https://forms.office.com/Pages/ResponsePage.aspx?id=DQSIkWdsW0yxEjajBLZtrQAAAAAAAAAAAAO__SYWlsFUMFZERjEzMTRNS0JCRjVaWVExRkZTMEtGWi4u

I don't know if Ad-wars is an upstream source of yours, so I thought I mention this person's issue here.
Thanks for all you do!
Cheers

Adaway reported https://github.com/AdAway/adaway.github.io/issues/348
Dan Pollock – someonewhocares emailed

Thanks everybody!
Closing.


Upgrade nix logic

I've created this PR to refresh a bit the nix files and upgrade nixpkgs for a future pull request which support conduit-1.3.
However I discovered a build issue with gdal-2.4.0 provided by nixpkgs. That's why this PR pin gdal to 2.3.0. I'll open an issue to track this later.

I'm closing this MR, it is 3 years old, surely had bitrot and I don't use gdal anymore in my work. @ghorn for reference, perhaps you care.


Recursive types.

Right now, this isn't currently possible.
/**
 * 'User' implicitly has type 'any' because it does
 * not have a type annotation and is referenced directly
 * or indirectly in its own initializer.
 */
const User = t.interface("User", {
  name: t.string(),
  friends: t.array(User)
});

Within the current capabilities for the package, a workaround would be using t.reference("User") instead of directly referencing the variable. This works, but it's arguably more confusing.
A potential solution for this issue is lazy evaluation (much like how Zod currently does it)
const User: ts.InterfaceDeclaration = t.lazy(() =>
  t.interface("User", {
    name: t.string(),
    friends: t.array(User)
  })
);

Closed by #5


[WIP] Fix plot_vector_source_estimates

This PR fixes the bug raising ValueError. The initial commit mitigates the issue.
Closes #7083

We don't have the ValueError but now, updating automatically the scale_factor of the second hemi removes the glyphs of the first one. This is still not fixed.

Modifying the scale_factor after the for loop that calls add_data fixed it for me.

Still draft/WIP?
Please add a test that fails on master but passes on this PR

Whoops. It's not WIP anymore indeed.

The test I just added fails on master and raises ValueError but it's expected to be green in here.

@larsoner now it uses the mean across the hemi's width.

Thanks @GuillaumeFavelier


Not able to convert browser.actions() class

Hi,
Migrate Command is giving an error while converting the following.
await browser.actions().doubleClick(this.btnDoubleClick).perform();
await browser.actions().mouseDown(this.btnDoubleClick).mouseUp().perform();
await browser.actions().mouseMove(this.btnDoubleClick).click().perform();
ERR ./protractorTests/pages/buttons.page.js Transformation error (Error transforming ./protractorTests/pages/buttons.page.js:16)
Error transforming ./protractorTests/pages/buttons.page.js:16

    await browser.actions()

            ^

Can not transform "actions" command as it differs too much from the WebdriverIO implementation. We advise to refactor this code.
For more information on WebdriverIOs replacement command, see https://webdriver.io/docs/api/webdriver#performactions
at ./protractorTests/pages/buttons.page.js:16:14
All done.
Results:
1 errors
0 unmodified
0 skipped
0 ok
action commands from protractor are ot able to migrate

@SomeswararaoMarati as mentioned in the error message it is not feasible to transform these statements. They are too different in their syntax. Therefor unfortunately these lines have to be migrated manually.

I will keep this open in case someone wants to tackle this challenge. PRs welcome!


Update to Quarkus 3

Hey there,
Here is an upgrade to Quarkus 3. It would be nice if you could merge it and release a new major version before April 25th so that's it's ready for the 3.0 announcement.
Thanks!

Thanks @gsmet.
Seems there are no breaking change in the build items used by the extension, but I guess it's probably safer to release a new major anyway.

@rquinio1A yes it's a bit more explicit that this version is compatible with Quarkus 3 when having a new major version.
Please ping me with the version when releasing, thanks!

@gsmet 3.0.0 has been released!

Nice, thanks a lot!


Gradient accumulation support?

Describe the feature and the current behavior/state:
Gradient accumulation is extremely useful when working with large images/volumetric data, using low-end hardware, or training on multiple GPUs. For me, the most important feature is to be able to use larger batch sizes without exhausting memory.
Currently, there does not seem to be a straightforward way to use gradient accumulation in Keras.
What I have tried:
In TF1, we created a wrapper that can be used on any optimizer, which changes how and when the update should happen. I have tried to implement such a method in TF2, greatly inspired by the attempt by other developers at TF-addons, such as @fsx950223 and @stefan-falk https://github.com/tensorflow/addons/pull/2525. However, I have not managed to get expected behaviour (see here to see some of the experiments I performed, and here for the optimizer wrapper implementation).
I therefore looked around for alternative solutions and found this suggestion on stack overflow. I have expanded upon this idea and it seems to be working. After some thorough debugging and benchmarking, I have made a simple solution available in this repo, such that at least one simple solution for GA exists in TF2.
Proposed solution:
The idea is extremely simple. Overload the train_step method of the tf.keras.Model and add gradient accumulation support there. In the end, I have produced a simple model wrapper, which does that for you, which you ideally should be able to apply to any tf.keras.Model to enable gradient accumulation, like so:
model = tf.keras.Model(...)
model = GAModelWrapper(n_gradients=k, inputs=model.input, outputs=model.output)

However, there is definitely some work left to be done to make it handle all scenarios, but it seems to be working fine on the use cases I have tested until now.
So what remains?
Currently, I am unsure whether this is the best approach. Perhaps there is a better way of solving this. A challenge might be to get distributed training working with multiple GPUs. I believe that was the biggest obstacle with the optimizer wrapper solution.
Are there any devs working on adding gradient accumulation support in Keras?
Are you willing to contribute it: Yes

Perhaps something like this can be used as a workaround:
https://blog.ivanukhov.com/2024/01/31/gradient-accumulation.html

Perhaps something like this can be used as a workaround:

This only addresses the Adam optimizer. If you want to wrap "any" optimizer, use this instead:
https://github.com/andreped/GradientAccumulator?tab=readme-ov-file#why
If you dont want to wrap the optimizer itself, you can also wrap the model. You can see how to do that from the link above.
There is also a thorough documentation on how to add gradient accumulation to an existing model pipeline here:
https://gradientaccumulator.readthedocs.io/en/latest/background/gradient_accumulation.html

NOTE: That in Keras 3, they seem to have made a solution for gradient accumulation now:
https://github.com/keras-team/keras/pull/18948#issuecomment-1858991628
It is a PoC and not feature complete, but a step in the right direction :]

The approach was illustrated on Adam, but it is not limited to that. The code is very general. It is a matter of replacing which class is inherited from.
The optimizer wrapper in GradientAccumulator, on the other hand, adds a lot of fragile complexity. It does not play well with the latest version of TensorFlow where the internals of optimizers have been redesigned. Moreover, it is limited to SGD according to the documentation. Please correct me if that is not the case.
https://gradientaccumulator.readthedocs.io/en/latest/examples/distributed_training.html

It does not play well with the latest version of TensorFlow where the internals of optimizers have been redesigned. Moreover, it is limited to SGD according to the documentation. Please correct me if that is not the case.

Thats not the case. We have not upgraded the code itself to work with the latest 2.x versions, but I believe the Legacy Optimizer class is still there, which makes it work also for newer versions of TensorFlow. The implementation you showed is similar to what I made once in TF1, and that worked fine for adam, but even then I had an optimizer wrapper that worked well for both SGD, Adam, and other optimizers I normally used:
https://github.com/AICAN-Research/H2G-Net/blob/main/src/utils/accum_optimizers.py#L11
The optimizer wrapper implementation in gradient-accumulator should work with "any" commonly used optimizer, Adam included. But it is likely a better options to extend the optimizer wrapper, if you want to support more obscene optimizers.
What you are referring to is doing gradient accumulation in a distributed setting. I do not think there is any implementation in TF2 that works correctly in this scenario. Maybe Hugging Face has one, but the best is just to move to Keras 3 if that is of interest, IMO.
The implementation you showed does not work correctly in a distributed setting. You need more logic to handle how to handle replicas. That is not easy to solve, and why there does not seem to be a solution that does this properly. It is also not possible to do this in a model wrapper setting, as the syncronization from replicas results in an error. The optimizer wrapping is the only solution. Optimizer wrapping is actually what Keras 3 does as well.
But if you attempt to do GA where you split the model in two, across two GPUs, the optimizer wrapping solution should work. But if you want to split the batch across four GPUs, it does not. There is some logic missing and not trivial to solve, IMO.

What you are referring to is doing gradient accumulation in a distributed setting. I do not think there is any implementation in TF2 that works correctly in this scenario. Maybe Hugging Face has one, but the best is just to move to Keras 3 if that is of interest, IMO.

Yes, that is my use case. Distributed training on several GPUs with the mirrored strategy.

The implementation you showed does not work correctly in a distributed setting. You need more logic to handle how to handle replicas. That is not easy to solve, and why there does not seem to be a solution that does this properly. It is also not possible to do this in a model wrapper setting, as the syncronization from replicas results in an error. The optimizer wrapping is the only solution. Optimizer wrapping is actually what Keras 3 does as well.

That logic resides in the optimizer one inherits from, which was Adam in the example given. They are all distributed-training aware. The implementation works well. Do you have any specific concerns?

That logic resides in the optimizer one inherits from, which was Adam in the example given. They are all distributed-training aware. The implementation works well. Do you have any specific concerns?

Well thats very interesting. It could be that we should try to not override most of the new Optimizer class for newer TF versions. That way, this might just magically work. My issue, is that I have gotten it mechanically to work before, using multiple GPUs in a distributed setting, but the main problem is that I do not get the expected GPU memory use across each GPU and I fail to see the same benefit of increasing the batch size by 4 by splitting across 4 GPUs, as I see for a single-GPU sequential setup.
But if you have managed to get it working for Adam, we could try to run benchmarks in Kaggle (2 GPUs available for free). And if that works, we could just rewrite the Optimizer wrapper to use the new Optimizer class, which may require a lot less code :]
Are you interested in posting that issue here:
https://github.com/andreped/GradientAccumulator/issues
And then we could maybe make a PR for it, @IvanUkhov, if we find that your solution works for newer TF versions.


Update MSDN links, Part 28

@NextTurn : Thanks for your contribution! The author, @hrasheed-msft, has been notified to review your proposed change.

@NextTurn Thanks very much for your contribution. We're going to address changing these links in the private repo, where we can validate relative links and check them in a staged environment. We'll close this (and related) PRs. Thanks again.


One frame of bold data deleted from projecting from t1w space to MNI

Hi I came across a wired thing when running bold preprocessing, the bold preprocessing dropped one frame (from 601 to 600 frames) while projecting from t1w space to MNI. And it happened for every run from every session.

raw data
fslinfo sub-03_ses-rest_task-rest_run-1_bold.nii.gz
data_type	INT16
dim1		84
dim2		84
dim3		48
dim4		601
datatype	4
pixdim1		2.476191
pixdim2		2.476191
pixdim3		3.000000
pixdim4		1.000000
cal_max		0.000000
cal_min		0.000000
file_type	NIFTI-1+`
T1w space
fslinfo sub-03_ses-rest_task-rest_run-1_space-T1w_desc-preproc_bold.nii.gz
data_type	FLOAT32
dim1		62
dim2		69
dim3		50
dim4		601
datatype	16
pixdim1		2.476000
pixdim2		2.476000
pixdim3		3.000000
pixdim4		1.000000
cal_max		0.000000
cal_min		0.000000
file_type	NIFTI-1+
MNI space
fslinfo sub-03_ses-rest_task-rest_run-1_space-MNI152NLin2009cAsym_res-2_desc-preproc_bold.nii.gz
data_type	FLOAT32
dim1		97
dim2		115
dim3		97
dim4		600
datatype	16
pixdim1		2.000000
pixdim2		2.000000
pixdim3		2.000000
pixdim4		1.000000
cal_max		0.000000
cal_min		0.000000
file_type	NIFTI-1+

I was using ninganme/deepprep:23.1.0 and running
nextflow run /opt/DeepPrep/deepprep/nextflow/deepprep.nf -c /output/MDTB_deepprep/WorkDir/nextflow/run.config -w /output/MDTB_deepprep/WorkDir/nextflow -with-report /output/MDTB_deepprep/QC/report.html -with-timeline /output/MDTB_deepprep/QC/timeline.html --bids_dir /data --output_dir /output/MDTB_deepprep --fs_license_file /output/freesurfer_license.txt --bold_only --bold_surface_space  --bold_volume_space MNI152NLin2009cAsym --bold_volume_res 02 --bold_task_type rest
and an example summary report of bold preproc is below

Original orientation: LAS
Repetition time (TR): 1s
Phase-encoding (PE) direction: Anterior-Posterior
Single-echo EPI sequence.
Slice timing correction: Applied
Susceptibility distortion correction: FMB (fieldmap-based) - phase-difference map
Registration: FreeSurfer bbregister (boundary-based registration, BBR) - 6 dof
Non-steady-state volumes: 0

Any idea on this? I've also tested fmriprep, their ouptut has the correct number of frames.
Thanks!
Xingyu

Hi! @xingyu-liu,
I just tested two data to run the bold_only type of data and there was no missing frame number.
I looked at the command you used, among which -c /output/MDTB_deepprep/WorkDir/nextflow/run.config -w / output/MDTB_deepprep/WorkDir/nextflow -with-report /output/MDTB_deepprep/QC/report.html -with-timeline /output/MDTB_deepprep/QC/timeline.html,These do not need to be filled in.
The /opt/DeepPrep/deepprep/nextflow/deepprep.nf command you should be followed by bids_dir,output_dir,participant; Maybe you can try it again using the deepprep command I tested:
nextflow run /opt/DeepPrep/deepprep/nextflow/deepprep.nf /data /output/MDTB_deepprep participant --bold_task_type rest --fs_license_file /output/freesurfer_license.txt --bold_only --bold_volume_space MNI152NLin2009cAsym --resume
If you still have any questions, please contact me in time！

Thanks for the quick response!
The nextflow command was what I copied from the log file. The command I was actually running is
docker run -it --rm --gpus all \     -v ${output_root}:/output \     -v ${data_dir}:/data \     ninganme/deepprep:23.1.0 \     /data /output/${dataset}_deepprep participant \     --fs_license_file ${fs_license_f} \     --bold_only \     --bold_surface_space '' \     --bold_volume_space MNI152NLin2009cAsym \     --bold_volume_res 02 \     --bold_task_type 'a'
I did run deepprep for several datasets, all of them were fine except for this particular dataset (https://openneuro.org/datasets/ds002105/versions/1.1.0), and the number of frame was correct until projecting to MNI template, which is kind of weird.

Thank you for finding a bug for us! @xingyu-liu
At present, the bug has been solved. Please pull the latest code of deepprep, or pull the latest docker of deepprep for testing.
If you have any questions, please communicate with us in time~

Hi！太感谢你们开发deepprep了，实在很好用。不好意思总要提出需求麻烦你们，还另有一些小点不知道是否方便添加一下微信交流一下（我的号码是：duanchiheihei）。如果不方便也没有关系的，忽略就好啦。谢谢！


Update integrating-in-devices.md

PK and DPK have the same definition.  Better to use PK since if someone emailed WMLA and ask I'd like to license the DPK they would not know what this is...  thanks.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Docs/Overview/integrating-in-devices.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


SilentAbort Exception error view

Currently, a SilentAbortException is not handled very specific.
A SilentAbortException is a special Exception which stops code execution but doesn't show an error in GUI.
If such SilentAbortException happens in a button action (= click), currently nothing was send to the client.
Current server will send an ErrorView with new property: silentAbort (boolean)
If ErrorView with silentAbort is set -> don't show a message and "cancel"

I've added, that silent-abort messages aren't shown on screen. Right now I don't really know what I should cancel when I'm receiving a silent-abort message.


Fix FatalErrorException Compile Error

FatalErrorException: Compile Error: Declaration of Moneybird\IncomingInvoice::settle() must be compatible with Moneybird\Payable::settle(Moneybird\Service $service, Moneybird\Payable $invoice, $sendEmail = false) in /srv/http/moneybird.git/vendor/bluetools/moneybird-php-api/Moneybird/IncomingInvoice.php line 21

Thanks!


@pothos/plugin-prisma incorrect typing for @typescript-eslint

I and using @pothos/plugin-prisma and whenever I generate Prisma schema pothos-types.ts is generated.
In pothos-types.ts file, for all models without relations following typing is used:
Relations: {};

But this is considered to be very unsafe typing. And linting with ESLint actually fails on this with following error:
Don't use `{}` as a type. `{}` actually means "any non-nullish value".
- If you want a type meaning "any object", you probably want `Record<string, unknown>` instead.
- If you want a type meaning "any value", you probably want `unknown` instead.
- If you want a type meaning "empty object", you probably want `Record<string, never>` instead  @typescript-eslint/ban-types

Would it be possible to change the typing in case there are no relations for given model?

Maybe it will be better to avoid linting generated code? You're not in control of that code, and you are not supposed to directly change it, so, linting it seems to be a waste of CPU cycles. Linting is subjective by definition (it does stylistic errors detection etc.), and code generator won't be able to satisfy all possible linting rules defined in every project that uses this library.

Hey, I think the above advise to not lint generated code is probably the best path forward.
I appreciate the concern around using good typescript patterns in the generated code, but In this case, this lint rule doesn't make any sense for these generated types.  The generated types are used very specific ways, and have specific semantics they need to follow for everything to work correctly.  Lint rules that make sense in application code, don't always make sense in library code.  I think one thing we could do is emit a comment at the top of the file to disable eslint.  The way empty objects are being used here is perfectly safe for the way these types are used.  The issue with a lot of lint rules like this is that they don't always apply to every situation.


[BEAM-6677] Job Server on Dataproc cluster support

Previously we assumed that Job server instance should be set up on Jenkins.
This pr extends the existing cluster with job server setup. Thanks to that we won’t have to setup a dedicated Jenkins job step to setup the job server and manage the communication between Jenkins (job server_)and Fataproc (the cluster). We open up a tunnel with appropriate JobServer ports to make the cluster usage easier.
Of course, setting up the cluster without the job server is still possible. To do that one needs to not pass the JOB_SERVER_IMAGE variable,
Other than that, this PR includes some convenient improvements (default values for GCLOUD_ZONE and DATAPROC_VERSION) and a fix for flink init action

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang
SDK
Apex
Dataflow
Flink
Gearpump
Samza
Spark

Go

---
---
---
---
---
---

Java

Python

---

---
---
---

Pre-Commit Tests Status (on master branch)

---
Java
Python
Go
Website

Non-portable

Portable
---

---
---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@mxm @angoenka could you take a look?

@angoenka Thanks! Applied fixes and got one question (above). Could you take a look again?

Thanks for merging and reviews! :)


MBD4-related recessive tumor predisposition syndrome

Preferred gene-related syndrome label
MBD4-related recessive tumor predisposition syndrome
Synonyms
Parent term (use OLS, or your favorite ontology browser)
tumor predisposition syndrome 2
Definition
MBD4-related recessive tumor predisposition syndrome is an autosomal recessive cancer predisposition condition including different kinds of tumors or malignancies which manifest in young adults. The most frequent features of this syndrome include acute myeloid leukemia (AML), myelodysplastic syndrome, colorectal polyposis and carcinoma, and uveal melanoma.
**Definition source (Please give PubMed ID, if applicable, in format PMID:#######)
Childhood, Adolescent and Young Adult Cancer Predisposition Gene Curation Expert Panel
Children terms (if applicable) Should any existing terms be re-classified as children underneath this new proposed term?
Your nano-attribution (ORCID) or URL for a working group
https://orcid.org/0009-0004-3069-7846

@keparis thank you for this request!
In reviewing this request, MONDO:0859267 'tumor predisposition syndrome 2' has db-xref OMIM:619975 that has synonyms 'MBD4-ASSOCIATED NEOPLASIA SYNDROME; MANS' as well as the gene association: MBD4, and description:
Tumor predisposition syndrome-2 (TPDS2) is an autosomal recessive cancer predisposition syndrome characterized by the onset of various types of tumors or malignancies in young adulthood. The most common clinical manifestations include acute myeloid leukemia (AML), myelodysplastic syndrome, colorectal adenomatous polyposis and carcinoma, and uveal melanoma.
If acceptable, I will add the definition, synonyms, gene association and clin gen preferred name, MBD4-related recessive tumor predisposition syndrome, to the term, MONDO:0859267 'tumor predisposition syndrome 2."

Great, thank you so much!
On Wed, Nov 13, 2024 at 2:09 PM katiermullen @.***>
wrote:

@keparis https://github.com/keparis thank you for this request!
In reviewing this request, MONDO:0859267 'tumor predisposition syndrome 2'
has db-xref OMIM:619975 https://omim.org/entry/619975 that has synonyms
'MBD4-ASSOCIATED NEOPLASIA SYNDROME; MANS' as well as the gene association:
MBD4, and description:
Tumor predisposition syndrome-2 (TPDS2) is an autosomal recessive cancer
predisposition syndrome characterized by the onset of various types of
tumors or malignancies in young adulthood. The most common clinical
manifestations include acute myeloid leukemia (AML), myelodysplastic
syndrome, colorectal adenomatous polyposis and carcinoma, and uveal
melanoma.
If acceptable, I will add the definition, synonyms, gene association and
clin gen preferred name, MBD4-related recessive tumor predisposition
syndrome, to the term, MONDO:0859267 'tumor predisposition syndrome 2."
—
Reply to this email directly, view it on GitHub
https://github.com/monarch-initiative/mondo/issues/8214#issuecomment-2474499562,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BLGZKP466YUKKT2PB5ZZ4DT2AOPVDAVCNFSM6AAAAABO72B2TSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZUGQ4TSNJWGI
.
You are receiving this because you were mentioned.Message ID:
@.***>


fix: use proper path for the XWayland sockets, fixes #7849

Fixes #7849

yeah this works, tested it on my end aswell, thanks for the quick fix

uhh... idk if this is related. but i just updated... and all xwayland apps doesnt turn on anymore... pls fix asap @vaxerski

uhh... idk if this is related. but i just updated... and all xwayland apps doesnt turn on anymore and keep saying stuff like cant connect to X server or cant get display :0 ... pls fix asap @vaxerski
currently using hyprland-git
EDIT: now i swapped to normal extra/hyprland package from arch. and its all fine... ill be staying there for now... im gonna live a stable life :D

This was the PR to fix it

ohh i see. ill see what will happen after the release to aur..


Throttle mouse events

Fixes #246

Nice, that works pretty good!

Thanks for testing it out! I do notice that it has the downside that it can drop the last few movements if you're going too fast, so the cursors end up misaligned, but I'm hoping that won't be much of an issue in practice.

Yup that was of the things that would hang me up on my attempt. I always wanted the cursor to be at the current position which is why the timeout works great. The debounce function was a good alternative but I just couldn't get it work as expected.
I for this throttling implementation I added two counters for the unthrottled and throttled events, and it was a big difference.


error on the dashboard if no test are made

error on the dashboard if no test are made

OS: Ubuntu 20.04 server
Architecture: dell poweredge r720

Screenshots

speedtest-tracker_logs1 (1).txt

Same here after getting your latest release last night...

Go to /results and then you should be able to access the settings page. Manually set your timezone there and that should resolve the issue

#234 is the original issue


gRPC variable autocomplete – show time is terribly slow

Describe the bug
The variable autocomplete list is opening incredibly slow when using it in a gRPC request. Using it can result in broken layout.
To Reproduce
Steps to reproduce the behavior:

Create some environment and populate it with variables.
Create a gRPC request.
Try to use the autocomplete in the gRPC host section.
(Optional) Compare time-to-show to a REST request.

Expected behavior
List is shown in same time as for a REST.
Screenshots
Note the position of the autocomplete window.

Desktop (please complete the following information):
Version: Insomnia 2021.2.2
Release date: 3/29/2021
OS: Windows_NT x64 10.0.19041
Electron: 9.3.5
Node: 12.14.1
V8: <IP_ADDRESS>-electron.0
Architecture: x64
node-libcurl: libcurl/7.73.0-DEV OpenSSL/1.1.1g zlib/1.2.11 brotli/1.0.9 WinIDN libssh2/1.9.0_DEV nghttp2/1.41.0
Additional context
Compared to the REST autocomplete for the gRPC contains additional items not coming from an environment.

Well, the bugfixing is not so popular as it was… 👎🏻 Fortunately anyone can use the new features instead, of course. 😕

Hi @bravequickcleverfibreyarn, thank you for reporting this, and apologies for the radio silence for a long while.
I tried reproducing a bit your issue in the latest Insomnia stable build, and was not able to.
As an experiment I tried pasting about 1000 environment variable entries, and tried using those within a gRPC request and didn't notice any major slowness.
Are you still noticing slowness with our latest build?

@filfreire, I am sorry, I am not working with gRPC these days so I have little space to verify it. Maybe it could be related to then environment I have no longer access to.
I guess, this is eligible for closing.

@bravequickcleverfibreyarn no worries! Please feel free to report any issues you may find with Insomnia in the future, we'll try to keep a close look at them 🙇


home page

move 'all rentals' to last tab, 'upcoming rentals' should be default
constant column width

Including this in #172 fix


rename the cx key in google search

Why are these changes needed?

Rename the confused key cx to google_search_id
Related issue number

Close #40
Checks

[ ] I've included any doc changes needed for https://github.com/pingcap/LinguFlow/.
[ ] I've added tests (if relevant) corresponding to the changes introduced in this PR.
[ ] I've made sure all auto checks have passed.

@lucklove PTAL.


Master

Updated the known issue section with the requirement that files, folder names or user ID's cannot contain the following characters: /:*?"<>|#{}^[]`%_

@Olga-MSFT Do you expect to fix this at some point? If so, I suggest filing an issue here in GitHub and tagging it with the 'known issue' tag, then linking to it in the docs.

One more wording tweak. other than that looks good.

I just went ahead and made the tweaks I wanted in a separate commit and merged everything in.


Docker sunset of free Teams

As you are maybe already aware https://github.com/docker/hub-feedback/issues/2314 GitHub will sunset free Teams. This change will lead to frozen public images if the owner doesn't apply to the OpenSource Program or buys the Team. (That's at least my interpretation, but as it's currently a manner of hours until this changes it's also not put into stones).
Is there any plan how Goldpinger will handle this? Alternatives could be for example github, google, quay or ecr.
Thank you in advance,
Best regards,
Björn

The proposal was revered by DockerHub


#2360: fix bug where Groovy 3 internal generated methods were detected as test methods

Fixes #2360
Did you remember to?

[x] Add test case(s)
[x] Update CHANGES.txt

Please hold off on merging this until I get approval from my employer (Salesforce). Hopefully the process will only take a few days. Thanks!

Ok, I got approval! Merge away if it looks good.

Thanks for the fix 👍


Bug for OmniSharp server load timed out. Use the 'omnisharp.projectLoadTimeout'

Environment data
dotnet --info output:
VS Code version:1.16.0
C# Extension version:1.12.1
Steps to reproduce
Expected  behavior
Actual behavior
1: vscode set "omnisharp.projectLoadTimeout": 600,
2: src file patch a test code: ... ". current is " + timeoutDuration));//it's a test patch，file path:CShappPath/out/src/omnisharp/server.js,
    const promise = new Promise((resolve, reject) => {
        let listener;
        // Convert the timeout from the seconds to milliseconds, which is required by setTimeout().
        const timeoutDuration = this._options.projectLoadTimeout * 1000;
        // timeout logic
        const handle = setTimeout(() => {
            if (listener) {
                listener.dispose();
            }
            reject(new Error("OmniSharp server load timed out. Use the 'omnisharp.projectLoadTimeout' setting to override the default delay (one minute). current is " + timeoutDuration));
        }, timeoutDuration);
        // handle started-event
        listener = this.onOmnisharpStart(() => {
            if (listener) {
                listener.dispose();
            }
            clearTimeout(handle);
            resolve();
        });
    });

3:but console log write:[ERROR] Error: OmniSharp server load timed out. Use the 'omnisharp.projectLoadTimeout' setting to override the default delay (one minute). current is 10000
4: what ? currrnet is 10000??  Help me please!  thanks!!!

Could you clarify the issue with C# for VS Code here? It sounds like you're changing the JavaScript in your extension?

I set attribute "omnisharp.projectLoadTimeout": 600
but code this._options.projectLoadTimeout this value is 10. Why?
My english very bad,Forgive me please.

Could you copy and paste your settings.json here? I have no idea why this would have a value of 10 since it's default is 60: https://github.com/OmniSharp/omnisharp-vscode/blob/master/src/omnisharp/options.ts#L48 and https://github.com/OmniSharp/omnisharp-vscode/blob/master/package.json#L362.

Thanks!
VSCode work computer is in the company
Copy JSON tomorrow at work!

sorry!
i find project folder override settings.json file,this json body have override "omnisharp.projectLoadTimeout": 10
I always find user level setting.json file ,Ignore project level also hava a setting.json,This is my fault. I'm sorry.
Thank you!

Not a problem. I'm glad you found the issue!

I had the same problem with Omnisharp, Where intelligence was not working even with a Console application. I had to install .Net Framework 4, 4.5 and 4.7.2.
Hope this will help in case of issue with Omnisharp.
Thanks,
Shashi Bhan


feat(replica): do periodic sync on files & dir

We open file in O_DIRECT mode which minimizes the cache effects but doesn't
guarantee that data is written to the disk. Periodic sync ensures that both
data and metadata is flushed to the disk at every 5 seconds. See man page of
open system call for more details. Also since fsync on fd's also doesn't
guarantee the same so fsync on directory is also required.
In this commit a goroutine is launched to perform sync on data files and
directory. Also sync and close the replicas gracefully before fataling upon
error or killing the replicas.
Signed-off-by: Utkarsh Mani Tripathi<EMAIL_ADDRESS>

Is this issue reproduced by performing node restarts and did we observed inconsistent blocks across replicas?
If so, does this regular sync (say 5 seconds) helps (with the current way of checking for chain and meta files during sync process)?


github.com/fnproject/cloudevent

there's no spec implementation [in go or anything] afaik for https://github.com/cloudevents/spec -- we have a chance to take the lead on this, though for the most part it's pretty minimal, I foresee somebody doing this. gonna ship 0.1 this week hopefully with some basic support for:
type CloudEvent
func NewCloudEvent(data, contentType string) CloudEvent
func EventFromRequest(*http.Request) CloudEvent
func (*CloudEvent) MarshalJSON() ([]byte, error)
func (*CloudEvent) UnmarshalJSON([]byte) error

this should help in handling some of the weird-ness around the json stuff in particular, and we can also implement the binary http format with a clean interface that we can tote around in fn, fdk-go, cli and also even functions eventually. going to finagle with how to play nice with extensions, one option is letting users embed this into another struct that has particular formats for their extensions, but idk.

not sure about extensions, hoping for something really flexible. they don't have a defined structure other than being a map, but most users will want to serialize them into their own structs without having to do further serialization of the specific extensions themselves. if we just use map[string]interface{} then users will have to do type casting of go native types to put those fields into typed fields of a struct.
but yea, we can evolve it over time. want to keep it really minimal overall and let users build out their specific logic on top of it, and simply implement the spec in the lib.

this exists now


Conflicting info between docs and starter kits

The solution for issue #898 added the "Don't bundle, minify, or optimize modules" to the Tools/Publishing docs.
Although the recommendation is not to bundle/minify, the TS and JS starter kits' rollup.config file includes the terser plugin with very specific minification options. This is very confusing as to which one developers should follow.
Which one is correct? Could you please advise?

That's a good point. In this case, the docs on the site are correct and contains our most up-to-date recommendation which is to not bundle, minify, or optimize.
The starter kit repos include a lot of tools and configurations as examples but that can be overwhelming and considered excessive. We've had thoughts about having multiple examples with different levels of complexity, even incorporating into our labs CLI package but so far we've only added a very minimal element starter with npx @lit-labs/cli init.

The starter kit includes a docs site for the element, and uses Rollup to bundle the JS just for the docs site. That bundle is not published to npm.

I think that would be great. It could also go in the README for both the static site and bundling sections. We would greatly appreciate a PR for that!

Hi @justinfagnani @augustjk, I just submitted the PR for the JS starter project. Would you mind having a look? If everything looks okay, I'll do the same for the TS project.
Please let me know your thoughts,
Thanks!


Add zero gyro based on alliance

If red alliance is selected in Driver Station the robot will zero the gyro and rotate 180 to face "forward" based on being red alliance.

Sorry thought it was already merged.  I see no conflicts after I made a minor update to remove drivebase from one of the methods.


feat: Event's page card

Tasks:

Label's
Expandable card action
Only functional CSS (decorative CSS will be another issue)

I will start working on this


ERR_INVALID_ARG_TYPE on pre-release (v2023.9.10371012)

The pre-release (v2023.9.10371012) build of vscode-isort stopped working yesterday, with this error in Output -> isort:
undefined
CWD: /cargo/api
[ERROR 2023-1-10 8:2:53.364]: [TypeError: The "file" argument must be of type string. Received undefined
	at new NodeError (node:internal/errors:371:5)
	at validateString (node:internal/validators:120:11)
	at normalizeSpawnArguments (node:child_process:505:3)
	at spawn (node:child_process:693:13)
	at Object.execFile (node:child_process:327:17)
	at /home/gidev/.vscode-server/extensions/ms-python.isort-2023.9.10371012/dist/extension.js:1:71194
	at new Promise (<anonymous>)
	at l (/home/gidev/.vscode-server/extensions/ms-python.isort-2023.9.10371012/dist/extension.js:1:71163)
	at t.textEditRunner (/home/gidev/.vscode-server/extensions/ms-python.isort-2023.9.10371012/dist/extension.js:1:73253)
	at async u.resolveCodeAction (/home/gidev/.vscode-server/extensions/ms-python.isort-2023.9.10371012/dist/extension.js:1:78965)
	at async V.resolveCodeAction (/home/gidev/.vscode-server/bin/441438abd1ac652551dbe4d408dfcec8a499b8bf/out/vs/workbench/api/node/extensionHostProcess.js:98:38557)] {
  code: 'ERR_INVALID_ARG_TYPE'
}

Can you share the entire Log after setting "isort.logLevel": "debug"? and your settings?

This is the log after setting "isort.logLevel": "debug":
Name: isort
Module: isort
[DEBUG 2023-1-13 8:35:54.181]: Configuration: {"name":"isort","module":"isort"}
Python extension loading
Waiting for interpreter from python extension.
Python extension loaded
undefined
CWD: /cargo/api
[ERROR 2023-1-13 8:36:0.159]: [TypeError: The "file" argument must be of type string. Received undefined
	at new NodeError (node:internal/errors:371:5)
	at validateString (node:internal/validators:120:11)
	at normalizeSpawnArguments (node:child_process:505:3)
	at spawn (node:child_process:693:13)
	at Object.execFile (node:child_process:327:17)
	at /home/gidev/.vscode-server/extensions/ms-python.isort-2023.9.10371012/dist/extension.js:1:71194
	at new Promise (<anonymous>)
	at l (/home/gidev/.vscode-server/extensions/ms-python.isort-2023.9.10371012/dist/extension.js:1:71163)
	at t.textEditRunner (/home/gidev/.vscode-server/extensions/ms-python.isort-2023.9.10371012/dist/extension.js:1:73253)
	at async u.resolveCodeAction (/home/gidev/.vscode-server/extensions/ms-python.isort-2023.9.10371012/dist/extension.js:1:78965)
	at async V.resolveCodeAction (/home/gidev/.vscode-server/bin/441438abd1ac652551dbe4d408dfcec8a499b8bf/out/vs/workbench/api/node/extensionHostProcess.js:98:38557)] {
  code: 'ERR_INVALID_ARG_TYPE'
}

settings on the remote container (where this is running) are:
{
	"isort.logLevel": "debug",
	"isort.serverEnabled": false
}

Do you want to see settings elsewhere?  The extension was working fine, and then I think an update to VSCode caused this issue to start occurring.  I don't think it was triggered by an isort extension update.

My VSCode version info:
Version: 1.75.1
Commit: 441438abd1ac652551dbe4d408dfcec8a499b8bf
Date: 2023-02-08T21:34:01.965Z
Electron: 19.1.9
Chromium: 102.0.5005.194
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 22.3.0
Sandboxed: No

This means that a python has not been selected. It should handle that case better.

VSCode does know about the python in my dev container, and other things like flake8 and mypy work as expected.  Pylance is working as expected.
Are you saying that there's something misconfigured on my end?  Or that there's some issue in the pre-release of the isort extension?

@markedwards isort is not picking up the right python. As a workaround you can set "isort.interpreter":["<path to python>"].

I set this and I still get the same error:
{
	"isort.interpreter": ["/usr/local/bin/python"],
	"isort.serverEnabled": false
}

This is a regression. Will look into it.

Ah, I see that I was wrong above about a VSCode update causing this.  For some reason I thought I started seeing this bug using the build you provided on #163.  But I was mistaken, I think the VSCode update blew away that build and I never actually confirmed that.
I've reinstalled the build from #163 and I can confirm that is working fine.  So it is indeed something that changed in the isort extension.

vscode-isort release (v2022.8.0) and pre-release (v2023.9.10371012) were conflicting with esbonio. It vaguely looked like something to do with the language server, so after looking for Issues, I decided to try the latest code (827f5576f51c6da9034e27bfb287b3b2018e9359). I built and manually installed the vsix. Setting serverEnabled to false produced the same error as markedwards reported above. And as expected, the workaround (manually setting the interpreter) does not work for me as well (same error). Good news is that setting serverEnabled to true when running the latest solves for my usecase (it even resolves the correct interpreter without requiring the setting for what that is worth). So ultimately I guess this is a long-winded +1 to this Issue, but maybe it will be helpful to someone.

This should be fixed in pre-release 2023.9.10451716

confirmed for me, v2023.9.10451716 with serverEnabled set to False works! (including with esbonio) thank you!! (even though I'm not the original poster)

Also confirmed fixed.  Thanks @karthiknadig.


Author profile does not show links

[] This is a question about using the theme.
[X] I believe this to be a bug with the theme --- not Jekyll, GitHub Pages or one of the bundled plugins.
[ ] This is a feature request.
[X] I have updated all gems with bundle update.
[X] I have tested locally with bundle exec jekyll build.

Environment informations

Minimal Mistakes version: v.3.3.6
github-pages or jekyll gem version: 89
Operating system: OSX

Expected behavior
As per Configuration and https://mmistakes.github.io/minimal-mistakes/docs/layouts/#author-profile
author:
  name   : "Your Name"
  avatar : "bio-photo.jpg"  # placed in /images/
  bio    : "My awesome biography constrained to a sentence or two goes here."
  email  : # optional
  uri    : "http://your-site.com"

should make the author uri visible with an icon, as well as others, if filled in.
Actual behavior
Non of the possible authorprofile links is visible. Neither in the https://mmistakes.github.io/minimal-mistakes/about/ example sidebar that should have author uri  uri :"https://mademistakes.com"

Thanks for the great theme!

After additional testing found that it's my browser's AdBlock that disables these links. Why would it? :$

It's a known issue with adblockers and Font Awesome. The links are there, you're just not seeing them because your adblocker is removing them.
Here's the upstream issue if you want more context. https://github.com/FortAwesome/Font-Awesome/issues/1799

Thanks for your quick reply and the context.

Hi I'm actually having a similar problem- my social media links are showing up, but the FontAwesome icons are not.
_config.yml:
author:                                                                                name: proof-by-accident                                                                                avatar: "/images/prof_pic.jpg"                                                                         twitter: ProofByAccident                                                                               github: proof-by-accident                                                                              reddit: proof_by_accident
I added the Reddit link following the "Layout Customization" page, but no icons appeared.  Do I have to download the icon images and store them somewhere specific or something?

@proof-by-accident No idea. If you share a link to a public repo and the site I can maybe troubleshoot. Otherwise it's impossible for me to tell what might have went wrong for you.

Sure, sorry about that I hadn't published the site yet so I was trying to get away with minimal effort...
Here's the repo and here's the site.

It's a known issue with adblockers and Font Awesome. The links are there, you're just not seeing them because your adblocker is removing them.
Here's the upstream issue if you want more context. FortAwesome/Font-Awesome#1799

Yes adblocker is the issue in my case..

using ubuntu18 and chrome as browser. It is not displaying. How Can I see the actual author profile output?

Is there any workaround to this without having users disable their adblock social lists?

@Destaq I found that the default code is commented out.I just uncomment those and it worked fine in my local machine(os-ubuntu18, browser-chrome). Nothing related to adblocker or anything

@HabibRh26 Could you please explain how you did that? I'm not sure what 'default code' it is that you are referencing.

default code meaning when you download the theme then the codes are commented with #,uncomment those and run, Hope it will work

wow... add block... why I didn't know that.... TT


Unable to pass Client ID/Secret for increased Unauthenticated Rate Limit

As per https://developer.github.com/v3/#rate-limiting I should be able to pass a client secret and client ID as part of my request to increase my rate limit for unauthenticated calls (in my case I'm doing a repos.getStatsContributors() call).
Is it possible to include this in the call and I'm missing it?

Take a look at the authenticate method here: https://github.com/mikedeboer/node-github#authentication

Yep, misunderstood the appropriate use of the authenticate stuff, thanks for the pointer.


Change internal encoding of strings to CESU-8

Use CESU-8 encoding internally for strings instead of UTF-8. This simplifies handling of strings, since in this case we don't need special handling for surrogate pairs.
This is still work in progress.
Current status (measured on x86 linux):
                           Benchmark |         RSS
(+ is better) |        Perf
(+ is better) |
                           --------- |                          --- |                         ---- |
                          3d-cube.js | 156->152 (2.564) | 0.429->0.417 (2.797) |
              access-binary-trees.js | 96->92 (4.167) | 0.382->0.369 (3.403) |
                  access-fannkuch.js | 44->48 (-9.091) | 1.111->1.053 (5.221) |
                     access-nbody.js | 68->68 (0.000) | 0.617->0.565 (8.428) |
         bitops-3bit-bits-in-byte.js | 44->44 (0.000) | 0.407->0.39 (4.177) |
              bitops-bits-in-byte.js | 40->36 (10.000) | 0.519->0.509 (1.927) |
               bitops-bitwise-and.js | 32->36 (-12.500) | 0.438->0.433 (1.142) |
            controlflow-recursive.js | 292->288 (1.370) | 0.384->0.384 (0.000) |
                date-format-xparb.js | 108->104 (3.704) | 0.422->0.26 (38.389) |
                      math-cordic.js | 52->48 (7.692) | 0.491->0.463 (5.703) |
                math-partial-sums.js | 44->40 (9.091) | 0.294->0.285 (3.061) |
               math-spectral-norm.js | 52->56 (-7.692) | 0.392->0.379 (3.316) |
                     string-fasta.js | 64->60 (6.250) | 3.79->2.172 (42.691) |
                     Geometric mean: |       RSS reduction: 1.4238% |            Speed up: 10.505% |

fyi, measurements with RaspPi2
                           Benchmark |         RSS
(+ is better) |        Perf
(+ is better) |
                           --------- |                          --- |                         ---- |
                          3d-cube.js |          132->   132 (0.000) |       3.7904-> 3.756 (0.908) |
              access-binary-trees.js |           88->    88 (0.000) |       2.8832->2.8456 (1.304) |
                  access-fannkuch.js |           40->    40 (0.000) |      10.1056->9.8144 (2.882) |
                     access-nbody.js |           64->    64 (0.000) |       4.7656->4.6792 (1.813) |
         bitops-3bit-bits-in-byte.js |           36->    36 (0.000) |       3.3376->3.2632 (2.229) |
              bitops-bits-in-byte.js |           36->    36 (0.000) |        4.468->4.4256 (0.949) |
               bitops-bitwise-and.js |           32->    32 (0.000) |       4.3424->4.2184 (2.856) |
            controlflow-recursive.js |          220->   220 (0.000) |       3.3696->3.2576 (3.324) |
                date-format-xparb.js |          100->   100 (0.000) |      3.0168->1.8536 (38.557) |
                      math-cordic.js |           48->    48 (0.000) |       4.9792->4.8968 (1.655) |
                math-partial-sums.js |           40->    40 (0.000) |       2.7184-> 2.644 (2.737) |
               math-spectral-norm.js |           52->    52 (0.000) |       3.3016-> 3.256 (1.381) |
                     string-fasta.js |           52->    52 (0.000) |     27.4368->19.016 (30.692) |
                     Geometric mean: |            RSS reduction: 0% |            Speed up: 7.9482% |

Hi, I've finished refactoring the built-ins to use CESU, so I think there won't be any major updates to this patch anymore, only some tweaks. @ruben-ayrapetyan, @egavrin, @zherczeg, please review.
Latest measurements with RasPi2:
Benchmark |         RSS(+ is better) |        Perf(+ is better) |
--------- |                          --- |                         ---- |
3d-cube.js | 132 -> 128 (3.0303) | 3.7 -> 3.696 (0.1081) |
access-binary-trees.js | 84 -> 88 (-4.762) | 2.846 -> 2.828 (0.6325) |
access-fannkuch.js | 48 -> 44 (8.3333) | 9.874 -> 9.874 (0) |
access-nbody.js | 64 -> 64 (0) | 4.674 -> 4.632 (0.8986) |
bitops-3bit-bits-in-byte.js | 36 -> 36 (0) | 3.088 -> 3.152 (-2.073) |
bitops-bits-in-byte.js | 36 -> 36 (0) | 4.224 -> 4.308 (-1.989) |
bitops-bitwise-and.js | 28 -> 28 (0) | 4.06 -> 4.084 (-0.591) |
controlflow-recursive.js | 216 -> 212 (1.8519) | 3.138 -> 3.12 (0.5736) |
date-format-xparb.js | 100 -> 100 (0) | 3.042 -> 1.798 (40.8941) |
math-cordic.js | 44 -> 44 (0) | 4.166 -> 4.172 (-0.144) |
math-partial-sums.js | 36 -> 36 (0) | 2.508 -> 2.55 (-1.675) |
math-spectral-norm.js | 48 -> 52 (-8.333) | 3.178 -> 3.178 (0) |
string-fasta.js | 56 -> 52 (7.1429) | 26.888 -> 9.534 (64.5418) |
Geometric mean: |       RSS reduction: 0.6443% |           Speed up: 11.0395% |

I do like the direction. I am happy that so much code can be removed. Please check all & usage, I think most of them are unnecessary. And please avoid for loops when simpler loops are available.

@zherczeg, thanks for your comments, I've updated the patch.

Is it needed to add cesu8 instead of utf8? As far as I understand CESU-8 is a variant of UTF-8, so I think we can leave utf8 and mention CESU-8 only in comments.
In some places there are mix of utf8 and cesu8:
lit_utf8_size_t read_size = lit_read_code_unit_from_cesu8 (current_p, &current_char);

Regardless style, this PR is OK for me.

LGTM

@egavrin, I don't think mixing the notation would cause any confusion, since, as you said, CESU-8 is a variant of UTF-8. On the other hand, keeping everything as utf8 would be misleading in my opinion, since in that case some functions would not behave as implied by their names, while others would. Of course, lots of comments could help with this, but still, I think naming functions by their behavior is much clearer.

@dbatyai we can simply write in documentation that we're implementing "UTF-8 in CESU-8", but we can leave as is.

@egavrin, I updated the patch to keep utf8.

Good to me. make push


[fix] [broker] [fix] [broker] Consumer status is inconsistent because operations addConsumer and disconnect of PersistentSubscription compete with each other

Motivation
E.g. consumer.subscribe and topic.unload executed at the same time:

Time
consumer.subscribe
topic.unload

1
consumer.subscribe

2
create persistent topic

3
create persistent subscription

4

topic.unload

5

topic.close

6
persistent-subscription.addConsumer
persistent-subscription.disconnect

7
add consumer finish
Because dispathcer is empty, no consumers are closed

8
response client: success

9
consumer.receiveMessage

After step 9:

consumer considers the subscription successful
broker considers topic unload success

But the consumer will not receive any message.
Modifications
Make two operations addConsumer and disconnect executed sequentially.
Documentation
Check the box below or label this PR directly.
Need to update docs?

[ ] doc-required
(Your PR needs to update docs, and you will update later)

[x] doc-not-needed
(Please explain why)

[ ] doc
(Your PR contains doc changes)

[ ] doc-complete
(Docs have been already added)

@gaoran10 @Technoboy-  please take a look, Thanks. ^_^

/pulsarbot run-failure-checks


identity verification

not able to open my mails

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 276c38fe-aa72-6afa-23d8-14ff206c6f50
Version Independent ID: 9ffe59dd-c667-4802-1da0-6917638804c5
Content: Troubleshoot two-step verification - Azure Active Directory
Content Source: articles/active-directory/user-help/multi-factor-authentication-end-user-troubleshoot.md
Service: active-directory
GitHub Login: @eross-msft
Microsoft Alias: lizross

Apparently there's an outage: monitor this page for updates: https://azure.microsoft.com/en-us/status/

One of my domains is affected, too. Not only e-mails, I'm unable to access Office365/Azure AD Admin Center. Nothing using Two Step verification is working.

Same here, all 2FA services are failing in my domain, unable to access anything!

We are investigating the Azure MFA issues being faced by subset of users in the Europe and Asia-Pacific Region. Keep an eye on the Azure Status page for updates.

I am in North America and none of my 2FA are working either.  It is not just "Europe and Asia-Pacific Region"

seconded. In north america, unable to 2FA to multiple deloittenet.com apps.

Toronto, Canada -> The same issue here! Can you provide any ETA?

Over 5 hours of not being able to logon with 2FA - Please can we have a ETA?

Cannot access my emails through Office 365 OWA using two step verification.

Same here. Education institution in the Texas, USA.

This is ridiculous....

Same here. Montgomery, AL

Same in VA Are all types of MFA out of service or just the texting and calling?

 Not getting 2FA emails or texts. No way to access support for my corporate account without first logging in (which obviously I can't do). I tried calling general Microsoft support and -- no joke -- the person asked how you spell "Azure." Have now emailed critical support and still no response an hour later. Really bad.

How long until the remaining infrastructure that still has trouble gets the fix/hotfix and gets relief?

I am in North America as well. i am having trouble with One Drive because of not being
able to receive the codes via text or phone call.

Located in CIS, Russian Federation.
Text messages and calls don't get through for 2FA.

I can't do anything, I can't even log into my Polycom phone to make a call. What were these people smoking when they decided that one's entire electronic presence should be controlled by a very volatile MFA service?

Same in Germany. Can not access emails or any other Microsoft Online service. Any ETA would be great from the company's side!!

More precisely, neither emails nor sms messages are reaching my phone.

MFA is not working here either........ USA... Not working since last night. Any ETA?????

Same here.  I'm in the USA.  None of my MFA options work and no way to get into my account.  I'm posting this comment via GitHub.

Need an ETA. How can MS let this happens ??

That someone knows any change? I can't login in FL

unable to login using the 2 factor authentication - its not texting or calling my phone

https://twitter.com/msft365status

unable to login using the 2 factor authentication - it's not texting or calling my phone.  North America region.

First I didn't get the Emergency Presidential Alert Text, now I can't even get a 2FA text to get into my calendar at work. Super harsh.

      First I didn't get the Emergency Presidential Alert Text, now I can't even get a 2FA text to get into my calendar at work. Super harsh.

Me too

How long does this take it over 12 hours now ?

The twitter status page advises admins to check the status page. However, I am unable to login to the admin portal without 2FA. Shouldn't they have the fail open option (if the 2nd factor burps)?

Dear all, I just entry, I am in FL, Try.  Good afternoon

I was able to login successfully, finally (via Text Message SMS) - Europe Region.

@zakirahman Thanks for the response! We will investigate and update as appropriate.

The issue has now been resolved. MFA and Exchange faced an outage earlier today but are back up and running. Please run a refresh and post to MSDN if you are still facing problems. From there we will be able to help you reach a solution.
https://social.msdn.microsoft.com/Forums/en-US/home?forum=windowsazureactiveauthentication
If you are testing with the Authenticator app, please run a refresh within the app itself.
We apologize for the inconvenience this has caused.


Sendable expressions instead of mainactor

This PR mainly replaces @MainActor with @Sendable to not force the call site to be on the MainActor to address #3.
I had to refactor most tests to make them pass. And isolate some state to fix Concurrency warnings. I'll add some review comments.

Nice work!

Nice work! Seems to be small conflict from your previous PR, but other than that things look good.

Sorry for the delay. The conflicts are resolved now. Tests pass for me locally for (I only tested for the macOS destination just now).


Distance between located person and robot

Hi Team,
do you have a python script enabling the distance calculation (for collision avoidance) between a person (his coordiantes xyz are available) and a robot. What i did is following:

using an example (overview-urdf.py) from your repositoty i m able to calculate the xyz of all the axes

In order to avoid:

interpolation approach for defining new points between all the axes
generating theirs xyz values
identifying the nearest point from the robot points to the person

the goal is to stop the robot when a predefined safety distance is reached between human (at the moment only the position of his hand) and the nearst robot point
regards,

@dadouz Is this issue still up to date?


Initial DPI scale for win standalone

This is now working, we just need to figure out how to scale a non-resizable plugin.


chore(release): cut v1.0.0-rc.2

[X] I have cherry-picked any changes labelled needs-cherry-pick-vX.Y.Z

[X] I have made all of the following version and patch updates:

Updated the container image tag in charts/osm/values.yaml
Updated the chart and app version in charts/osm/Chart.yaml
Updated the image tags used in the demo manifests
Regenerated the Helm chart README.md

[X] I have checked that the base branch for this PR is correct as defined by the release guide

Is this a release candidate? Yes

Codecov Report

Merging #4361 (657c1fb) into release-v1.0 (7351ad3) will increase coverage by 0.06%.
The diff coverage is n/a.

:exclamation: Current head 657c1fb differs from pull request most recent head 6549c52. Consider uploading reports for the commit 6549c52 to get more accurate results

@@               Coverage Diff                @@
##           release-v1.0    #4361      +/-   ##
================================================
+ Coverage         69.10%   69.16%   +0.06%
================================================
  Files               212      212
  Lines             14450    14450
================================================
+ Hits               9985     9994       +9
+ Misses             4413     4404       -9
  Partials             52       52

Flag
Coverage Δ

unittests
69.16% <ø> (+0.06%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/crdconversion/crdconversion.go
74.43% <0.00%> (+6.76%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39aaae4...6549c52. Read the comment docs.


Web Socket query string params support

Describe the bug
If you try to connect on one ws url with some query string params the button "connect" is disabled.
But if you edit the source code to remove the "disabled" html attribute and you click on "connect" this work perfectly.
To Reproduce
Steps to reproduce the behavior:

Go to 'Realtime' tab
Type an ws url with some query string params
See 'connect' button is disabled

Expected behavior
The button shouldn't be disabled
The regex should probably be edited to accept query string params
Desktop (please complete the following information):

OS: Windows 10
Browser: Firefox developer edition
Version: 80.0b4

Can you tell which URL produced disable"Connect" button? From my side, it looks okay even if there are multiple query string parameters used.

I have the problem with an url of this type (this is fake domain and fake access_token)
wss://test.test.fr/?access_token=UQUhIlQ-ZLZlveQLYYmpuUl2U6qrllDGu5LIUUcUDVYg2P6glZotUEGgAlQdx6gO1l1KZoUUKOrl4aQQgelMKQ62aoMx2Umr5hQG2lk2rvuu_UllUAE8GQGU5G4L9pPmQAp77xkZqt7IMzgTlhlHCL4O2lUUQQiclxPayP2

The last forward slash / is what causing the issue.
Try this:
wss://test.test.fr?access_token=UQUhIlQ-ZLZlveQLYYmpuUl2U6qrllDGu5LIUUcUDVYg2P6glZotUEGgAlQdx6gO1l1KZoUUKOrl4aQQgelMKQ62aoMx2Umr5hQG2lk2rvuu_UllUAE8GQGU5G4L9pPmQAp77xkZqt7IMzgTlhlHCL4O2lUUQQiclxPayP2


change the default cu2qu approximation error?

fontmake currently uses the cu2qu default value for the cubic to quadratic conversion, i.e. a factor of 0.0025 of the EM square. Of course, we have an -e option to set a custom value, however I wonder if others also share my concern that the current default might be too relaxed and should/could be changed in order to get more accurate results on average, especially for casual users who might not even be aware they can tweak the conversion tolerance.
Related https://github.com/googlei18n/cu2qu/issues/76

since version 1.2.6 (commit cbb2642f1ca7f47219aa2f31ef48de4a5aed07b7), fontmake requires cu2qu >= 1.2.0, which uses 0.001 as default approximation error for cubic to quadratic conversion.
To keep using the previous value, one can pass the option -e 0.0025.


Order lost whe page refreshes while using image collection

While sorting a image collection order lost when page refreshes .
gallery.html
<div id="grid-container" class="cbp-l-grid-agency grid">
                    {{#each images getCurrentCategory}}
                    {{> image}}
                    {{/each}}
                    {{> addInfo}}
</div>

gallery.js
 var el = document.getElementById('grid-container');
    var sortable = Sortable.create(el, {
    group: "localStorage-example",
    store: {
        get: function (sortable) {
            var order = localStorage.getItem(sortable.options.group);
            console.log(order);
            return order ? order.split('|') : [];
        },
        set: function (sortable) {
            var order = sortable.toArray();
            console.log(order);
            localStorage.setItem(sortable.options.group, order.join('|'));
        }
       }
 })

Try dev-branch, perhaps the problem has been solved;
Use the search, maybe already have an answer;
If not found, create example on jsbin.com (draft) and describe the problem.


undefined method `archive_polymorphic_path'

Rails 3.2.0
IR 1.3.0
I'm getting the following exception whenever I use the url helper for a custom action.
undefined method `archive_polymorphic_path' for #<PrototypesController:0x00000101739540>

Here is the controller where the custom action is defined:
class PrototypesController < ApplicationController
  inherit_resources

  belongs_to :account, :optional => true do
    belongs_to :project
  end

  custom_actions :resource => [:archive]
end

And here is the url helper I try:
archive_resource_path( prototype )

I was able to find a workaround thanks to this post. The alternative to using the helper with the action prepended is passing the action as an option to the resource_(path/url) helper.
resource_path( prototype, :action => :unarchive)
This is inconsistent with non polymorphic routes but works for now.


Validate name in llama stack build

The first time I ran llama stack build, I quickly hit enter at the
first prompt asking for a name, assuming it would use the default
given in the help text. This caused a failure later on that wasn't
very obvious. I was using the docker format and a blank name caused
an invalid tag format that failed the image build.
This change adds validation for the name parameter to ensure it's
not empty before proceeding.
Signed-off-by: Russell Bryant<EMAIL_ADDRESS>

I'm attempting to sign the CLA, but the form gives me an error upon submission. I have contacted<EMAIL_ADDRESS>about it.


focus on map-page when idea not in the picture

This is a problem we encountered and we don't know a good solution, but maybe you have one.
I am on the geo-map and I see Vienna (e.g. the default focus on the city). When I look for another place, the focus is adjusted to that spot (that works perfectly).
There are also some cases when an "idea" I am searching for on the map is not within my focus (e.g. "Alpha-Kurs" which is only in Laa an der Thaya). Right now the idea is highlighted, but the focus is not adjusted to that spot. So I would have to zoom out and look all around the world (more or less), to find the highlighted spot. The solution here would be to reset the focus on the spot which is highlighted.
HOWEVER, I can also imagine the case when I set my focus on Vienna and just want to see which of the spots I see on my screen right now are actually churches. So I type in the idea "churches". In that case, I would not want the focus to readjust so that all churches on our map appear on my screen.
All the solutions we can think of are rather complicated, I think (e.g. checking if there is a highlighted spot visible to me the way my focus is currently adjusted and only changing the focus, if in my current focus, there is no highlighted spot visible). At least to me, that sounds super complicated. If you do not have a feasible solution, we would probably stick to the way the map behaviour is right now.

quick thought:

we should actually display somewhere (probably next to the "Gemeinsame Orte/Ideen/Accounts" explainer) how many entities actually matched the current query. then i would at least have an indication that there are e.g. "2 Treffer" that i need to locate somewhere on the map.
in cases where a filter has only a single match we could center the map automatically (like we already do for place filters)

showing the hits is certainly good; I think we can do that
also your second point sounds good.... however will people understand, that the map doesn't adjust, if there are just two hits which are not visible to me with my current focus... on the other hand, there are only very few cases where an idea has only ONE location..., so I think, that would be a good solution. Thank you!!!

match count is now displayed, auto-focus behavior still needs to be implemented


make notification sound selection a dropdown

So this doesn't happen

Issue created by BlueBubbles Bot in the BlueBubbles commnity on behalf of @jojejo in #android-development.

This has been removed. Closing


Clean up typo in chat websocket javascript client

It so happened that the code works, because both variables exist,
but the code was not clean.

Excellent!


User States Zoom Not Working; Default should be Incident Extent

Describe the bug
Periodically the map will zoom you to the middle of the Texas. In particular, when you turn a filter on or off. But no change in the map should occur. If a change in zoom must occur, follow instructions under "Expected behavior."
To Reproduce
Steps to reproduce the behavior:

Go to the map
Turn on a filter
Bug: Zooms to the middle of Texas

Expected behavior

No change in the map should occur.
If a change in the map occurs, it should be to the last user.state
If a user.state does not exist, and a map change needs to occur, it should default to the furthest extent of the current incident.

Screenshots

This should do fine.


log_view_coordinates for 2D views

It should be possible to use log_view_coordinates to set the viewing orientation of 2D views.

Dupe of #1387 ?

Good catch!


feat(validator): Indy validator and indy-testnet files

Added new code that talks to indy pool. It submits request to indy it received and sends response back.
The python code will be updated in the future so that users can simply pip install them and run (although it is incomplete at the moment). The directory structure reflects this intention.
Also included are updated version of indy-testnet files. The code described above needs this environment to properly run.

resolve the issue #959

@petermetz Thanks for your comment. As you commented, the current main language on Cactus is TypeScript so your suggestion seems natural to terms of the current codes. However, as we discussed, in order to start collaboration with other projects, it is needed to adapt not only TypeScript but also other programming languages such as python.
Then, I think that it should be dealt as another issue to adapt TypeScript package, but this issue is not directly related with this pull-request. Could you review this pull-request again?

@petermetz Thank you for your comment.
It is nice to have interoperability between API server and connector (possibly not just for Indy but other ledgers too).
I think we can design a wrapper to make indy validator (in python) to be callable, but I suspect that it could take some time to design a standard interface between API server in typescript and (arbitrary) connector in python.
For that reason, can I ask this code to be accepted for the time being, and consider the designing/implementing such interface as other task?

@petermetz Thank you for your comment.
It is nice to have interoperability between API server and connector (possibly not just for Indy but other ledgers too).
I think we can design a wrapper to make indy validator (in python) to be callable, but I suspect that it could take some time to design a standard interface between API server in typescript and (arbitrary) connector in python.
For that reason, can I ask this code to be accepted for the time being, and consider the designing/implementing such interface as other task?

@izuru0 Sure thing.

@izuru0 It seems that he created a new pull request #1117 having the same codes instead of squashing. So I think it is no problem to close this PR #1099. Is it OK?
@petermetz So would you mind if you review the new PR #1117 again?

@izuru0 It seems that he created a new pull request #1117 having the same codes instead of squashing. So I think it is no problem to close this PR #1099. Is it OK?
@petermetz So would you mind if you review the new PR #1117 again?

@takeutak @izuru0 Any chance that you could just do the squash instead of me reviewing the entire PR again? It takes 30 seconds to squash, if you don't know how to do it I can help.

Codecov Report

Merging #1099 (f0c60ee) into main (6d1de27) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1099      +/-   ##
==========================================
- Coverage   73.14%   73.11%   -0.04%
==========================================
  Files         246      246
  Lines        8617     8617
  Branches      996      996
==========================================
- Hits         6303     6300       -3
- Misses       1783     1786       +3
  Partials      531      531

Impacted Files
Coverage Δ

...t-tooling/src/main/typescript/common/containers.ts
74.07% <0.00%> (-1.24%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d1de27...f0c60ee. Read the comment docs.


Style Tweaks

[ ] change menu background to dark blue
[ ] make hover text for phone and email white. currently it is dark blue on dark blue, can't read
[ ] Change out background splash image to i-team image
[ ] Map views: Include address underneath title of location.
[ ] Once login is created, add a save button underneath the checklists. Add a save button as the sticky cita on the My Checklist page
[ ] Make glossary words dark blue
[ ] Have intercom dialogue box slide up versus blinking open. Otherwise it is difficult to see where it is coming from. Android user hit back button and it did something funky with intercom, it was hard to get out of it
[ ] Add dark blue checklist icon to left of My Checklist on step pages to make it look more like a cta

[ ] change menu background to dark blue
[ ] make hover text for phone and email white. currently it is dark blue on dark blue, can't read
[ ] Change out background splash image to i-team image

Most of these sound great. Just a few questions:
• Checklist save button: My assumption is that all actions on the checklist (i.e. check/uncheck) will be automatically saved. Is there a reason not to do that, and require explicit action from the user whenever they want to save? (also, I think this feature should probably move into a separate issue regarding user login features, since it's more than a tweak of present styling)
• Intercom: Unfortunately, I have no control over the Intercom dialog box style or functionality - that's all their code. If there's anything you can configure from their settings, though, go for it.
• Glossary words: Making these blue sounds good. Should they still have the dotted underline, or do you want to get rid of that?

Yes to dotted line, especially since color blindness may factor in
On Monday, May 16, 2016, Mark Rossetti<EMAIL_ADDRESS>wrote:

Most of these sound great. Just a few questions:
• Checklist save button: My assumption is that all actions on the
checklist (i.e. check/uncheck) will be automatically saved. Is there a
reason not to do that, and require explicit action from the user whenever
they want to save? (also, I think this feature should probably move into a
separate issue regarding user login features, since it's more than a tweak
of present styling)
• Intercom: Unfortunately, I have no control over the Intercom dialog box
style or functionality - that's all their code. If there's anything you can
configure from their settings, though, go for it.
• Glossary words: Making these blue sounds good. Should they still have
the dotted underline, or do you want to get rid of that?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/rossettistone/bizport/issues/112#issuecomment-219508340

--
Lisa Ratner
User Experience Designer
UX-by-Lisa.com http://UX-by-Lisa.com
<EMAIL_ADDRESS>(650) 207-3682


Changes needed to be able to make it on Slackware64 15.0

I just changed the destination of the binary from usr/lib to usr/libexec in both Makefile and .desktop files.
It builds and runs fine now.

👍


Rework resource routes to remove boilerplate and reduce chances of mistakes.

The current routes for our REST apis in mcapi have a lot of duplicated checks and boilerplate. It makes it difficult to correctly add new methods. Some of the checks are also done on the route and others are done in the methods. Update the way these are done.

Upgraded some packages (rethinkdbdash, and koa-router). Fixed up routes and checks. Resources are now easier to add.


build fixes

Split executable tool and library
Remove warning

This is an older PR, but I like some of the ideas in here (such as making the tool build optional). I'll leave this PR up.


Global connection pool setting for app.config

Programmatic configuration allowed setting up connection pools on global level. Add same functionality to configuration through app.config. Also removing DefaultValue=null for optional configuration elements, because null doesn't work anyway.

@Svizel -
Sorry for the delay; this is now in Gerrit awaiting code review. Here is a ticket for tracking: http://issues.couchbase.com/browse/NCBC-919
Thanks for the submission!
-Jeff