Singleton AutocompleteManager, Separate View's Model From AutocompleteManager

:rotating_light: WIP - Not Ready For Merge :rotating_light:
This PR seeks to change autocomplete-plus such that AutocompleteManager is a singleton.

[x] Rename select-list-element to suggestion-list-element
[x] Add suggestion-list
[x] Modify main.coffee to manage a single AutocompleteManager instance
[x] Track providers in an associative array, associating providers with scopes
[x] Modify provider registration functions to discard editor binding during provider registration
[x] Determine scope(s) for editor provided during provider registration
[x] Manage suggestion-list-element across editors
[ ] Ensure decoration and view migrate across editors without problems
[ ] Ensure autocomplete doesn't trigger during composition
[ ] Make modest FuzzyProvider enhancements

:rotating_light: WIP - Not Ready For Merge :rotating_light:
This PR contributes to completion of #184.

@nathansobo This PR integrates service-hub into autocomplete-plus. Would appreciate a review of the portion that integrates it, if you're open (in autocomplete-manager.coffee).

@joefitzgerald Awesome. I'll take a look today.

Not sure how broadly I should comment on various things since this mainly deals with using services. I'll start there.
I'm wondering if the consumer-provider relationship should be inverted. So you provide your provider as a service to the autocomplete package, targeting a specific version. Then the autocomplete will consume services that people provide for various versions. Also, I think providers should be based on scope selectors. Scope descriptors and scope selectors are different sides of the same coin, but they shouldn't be confused. Selectors are designed for matching.
So adding a provider would look like this:
atom.services.provide "autocomplete.provider", "2.0.0",
  scopeSelector: ".source.ruby .method",
  provide: ({prefix, scope, bufferPosition}) -> # ...

Some other thoughts:

Should we pass an object to the provider containing relevant information? This allows us to expand what we provide over time.
Do we force subclassing Provider for new providers? If so, I don't think we should. The interface should be as simple as possible because subclassing Coffee from other JS languages is a pain.
Should we make a synchronous provideSync method and an async provide method? Haven't fully thought through the implications of blending these together, but it does seem like building suggestions might need to support an async API. Of course if things take too long it will be a bad user experience.

I should add that I'm really glad to see you using new APIs such as overlay views. We're interested in your feedback on the experience of using them.

@nathansobo, I've been using overlay views here, and in AtomLinter,  I made a few suggestions that might help keep them usable as more libraries utilize them. https://github.com/atom/atom/issues/4401.

@park9140 Lots of good ideas in there. May take a while to have bandwidth to implement them.

@nathansobo, if you don't get to it first I'll probably throw down a pull request for it, assuming I can make some headway on the rest of my list of things to do.

I'm wondering if the consumer-provider relationship should be inverted.

Interesting. I had assumed that it is the package providing who is implicitly responsible for providing the service (and managing the versioning of it). If the direction is inverted, how does autocomplete-plus:

Rev the API
Know which services to consume?

Also, I think providers should be based on scope selectors.

Completely agree. Will update the approach accordingly.
So adding a provider would look like this:

Should we pass an object to the provider containing relevant information? This allows us to expand what we provide over time.

Yes, this is already happening in an options object passed to the provider - which is new. Open to alternate ways to achieve the same outcome.

Do we force subclassing Provider for new providers? If so, I don't think we should. The interface should be as simple as possible because subclassing Coffee from other JS languages is a pain.

We are also anti subclassing and trying to provide a graceful migration path from v1.0.0 of the API to v2.0.0 (which will be Provider class -less prior to the merge of this PR). I also aim to deprecate Suggestion and use anonymous objects instead.

Should we make a synchronous provideSync method and an async provide method?

That we're even commenting in this PR is a result of two things:

We want autocomplete to not suck
We want to add asynchronous support to the Provider API (I need it for go-plus, many others need it) and then make suggestion display asynchronous also (we'll probably initially ship with something that waits for all promises to resolve, and then figure out how to update the suggestion list as suggestions roll in)

Thanks so much for the thorough review in here - great stuff that I will address shortly.

@joefitzgerald, @nathansobo

I'm wondering if the consumer-provider relationship should be inverted.

In dependency injection we commonly register multiple services with the same interface and request all impementors of that interface.  @nathansobo, if I am reading the service-hub implementation correctly, we could consume autocomplete-provider at a particular semver and then we would generate multiple callbacks for each autocomplete-provider that has been registered?  If this is not true could we make it true?

@joefitzgerald

If the direction is inverted, how does autocomplete-plus:

Rev the API

It should be possible to consume providers targeting multiple given interfaces. So autocomplete would consume all providers providing 1.0.0, 1.1.0, etc. It might have multiple consumers to shim back to the other interface.

Know which services to consume?

It would only consume autocomplete-plus.provider services matching known versions.

if I am reading the service-hub implementation correctly, we could consume autocomplete-provider at a particular semver and then we would generate multiple callbacks for each autocomplete-provider that has been registered?

Yeah, that was the idea. Your callback gets fired with any provided services matching your name and semver range. It's many-to-many.

I should add that it's definitely subjective whether packages implementing providers should call provide on the service hub. But it does seem like a pretty natural fit. Even the vocabulary matches up.

@nathansobo Many providers will want to provide for many scopes. Would you see it as idiomatic to provide for each specific scope, or would it be better for us to accept an array of selectors?
atom.services.provide "autocomplete.provider", "2.0.0",
  scopeSelector: ".source.ruby .method",
  provide: ({prefix, scope, bufferPosition}) -> # ...

There's also the case of a provider which should be run always (e.g. autocomplete-snippets).

@nathansobo, I really like this switch to having the api providers calling service hub.  It clears up my previous concerns about providers needing to all implement disposability since it seems more natural for a provided service to implement onDispose()
@joefitzgerald

Many providers will want to provide for many scopes. Would you see it as idiomatic to provide for each specific scope, or would it be better for us to accept an array of selectors?

It seems to me that we may want to think of the service registration as just that.  The providers, all provide an instance of the same completion interface,  so the service everything could be providing is, auto-complete.completions.
We should really think about making the interface provide the category of completions, so that we can make a configuration that sorts by category.  If we had this and defaulted, fuzzyprovider to something like fallback and default the configuration so that fallback category is always last, we could allow other providers to provide similar functionality and not write extra code for the fuzzy provider.

@joefitzgerald  Selector strings can also have , in them to target multiples, so it seems like that could be used rather than an array of multiple strings. This would still force you to call provide once for each scope selector you wanted to match against. An alternative would be to call provide with an object mapping scope selectors to provider functions, but there's less room to give providers other methods in the future.

@park9140 >> https://gitter.im/atom-community/autocomplete-plus
As an aside, FuzzyProvider = pile of :hankey:. I only keep it around until we have a chance to spur a provider writing contest (perhaps with the assistance of the Github team), after which time I believe it's an anti-pattern to have a fallback.
Said another way: autocomplete-plus should provide suggestions if it has good suggestions that are contextually informed. If it cannot, it should not provide suggestions at all.

Do you already have a 1.0 interface via the service hub? If not, might I suggest using 0.x versions while this API is in flux?

Do you already have a 1.0 interface via the service hub? If not, might I suggest using 0.x versions while this API is in flux?

This won't be merged until the API is cemented. But no, there is no existing 1.0 interface via service-hub. We could modify the version for the existing API to 0.1.0, and make the new API 0.2.0.

Said another way: autocomplete-plus should provide suggestions if it has good suggestions that are contextually informed. If it cannot, it should not provide suggestions at all.

I've always been a huge fan of "matching word from an open buffer". It's not intelligent, but it can often be pretty productive. I often prefer it to "smarter" completion because its behavior is so regular. One huge improvement in my mind would be to sort the matching words by proximity to the current location since locality is usually a good predictor of appropriateness.

We could modify the version for the existing API to 0.1.0, and make the new API 0.2.0.

Does it even make sense to provide the existing API via the service hub? Why not expose the new API from day 1 and just keep the existing API on the main module as it currently is?

Does it even make sense to provide the existing API via the service hub? Why not expose the new API from day 1 and just keep the existing API on the main module as it currently is?

@nathansobo The only reason would so we can deprecate and remove the mainModule API very quickly. But I'm not tied to providing it that way. What I do know is that the last time we made a breaking change, it caused a bunch of issues, and this might be a halfway house that allows us to guide people through the change a little more smoothly.
Reality is we may just make PRs against the most used providers and call it a day.

@nathansobo is there a selector for all scopes?

The only reason would so we can deprecate and remove the mainModule API very quickly.

My instinct is to deprecate the main module API and leave it in place for a while since it's doing no harm. You can use grim to actually warn its users. Then you can focus on exposing a newer, better API via the service hub moving forward. If you want to maintain the old API forever via the service-hub then I guess it makes sense to provide it, but it might be nice to cut to the new one so long as people are making changes.

is there a selector for all scopes?

* should match anything, if I understand your question correctly.

Depending on the API, you could default to * if they don't provide a selector. Obviously if you use the route of using selectors as keys in an object you couldn't default it and people would have to use * explicitly.

@nathansobo Would you mind joining us in https://gitter.im/atom-community/autocomplete-plus? We want to discuss dispose semantics in the inverted model you described.

@nathansobo This is ready to :ship:. Would appreciate your review of the code as it currently stands. This includes use of scoped-property-store for storage of provider registrations and the global / provider blacklists. We have also inverted the service-hub directionality, autocomplete+ is now the consumer of providers.


🐛 [Bug report]: Unnecessary Multiple Re-rendering making multiple graphql call

Describe the bug
A clear and concise description of what the bug is.
Expected behavior
multiple unnecessary re-rendering and graphql calls are observed.
Screenshots
If applicable, add screenshots to help explain your problem.

do these requests have the same query payload?

yeah! noticed that problem. any updates @Angryman18 for this issue?

Im kinda out of context for now about what is the issue @priyankarpal

:)


Matěj z

GANomaly now can run on GPU (successfully tested).
Only thing that was not fully tested is appling results into GenerativeAD.experiment(result..., data, savepath; save_entries...)

Looks good

Seems ok.


fix: cursor changing on window move and resize

Describe your PR, what does it fix/add?
Fix inconsistent mouse cursor during window moving and also use the "corner"cursors during window resizing.
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
The corner cursors might look kind of out-of-place if dragging from near the middle of the window, or from the wrong side when tiled? Not sure.
Is it ready for merging, or does it need work?
Yes.

sorry, completely forgor.
The hand is different, it should be the open hand
and also there is an issue, if resizing a tiled window when there are 2 windows the icon is corner but we are limited in only 1 axis

Properly showing the cursor for resizing tiled windows seems to be annoying to implement and a bit outside of the original "fix" scope of this PR. How about just merging this one with every cursor showing "grab" and then maybe implement directional resizing cursors in a later PR?

sure.


Npm ERR! Failed at the<EMAIL_ADDRESS>postinstall script ‘node install.js’

Hello,
I've tried electron for the first time last night and am getting errors.
I updated to the latest version of node.js and npm and still got errors.
I deleted my "electron-quick-start" directory and tried again, using npm install --loglevel verbose and got the attached log.
npm-debug.log.txt
The error is listed below:

npm ERR! Windows_NT 10.0.14393
npm ERR! argv "C:\Program Files\nodejs\node.exe" "C:\Program Files\nodejs\node_modules\npm\bin\npm-cli.js" "install" "--loglevel" "verbose"
npm ERR! node v7.1.0
npm ERR! npm v3.10.9
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>postinstall: node install.js
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>postinstall script 'node install.js'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the electron package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR! node install.js
npm ERR! You can get information on how to open an issue for this project with:
npm ERR! npm bugs electron
npm ERR! Or if that isn't available, you can get their info via:
npm ERR! npm owner ls electron
npm ERR! There is likely additional logging output above.
npm verb exit [ 1, true ]
npm ERR! Please include the following file with any support request:
npm ERR! J:\electron\electron-quick-start\npm-debug.log

Node 7.1 has issues installing Electron amongst other issues with other packages.
https://github.com/nodejs/node/issues/9542
https://github.com/electron/electron/issues/7919
Downgrade to 7.0.0 or use LTS 👍

Was using Nodejs 7. Downgraded to version 6 and everything works so far.


Fold & Unfold

Issue Type: Feature Request
Please add two additional functions to fold and unfold all first level structures in a current editor:

functions
data definitions
...

Ctrl+Shift+Alt+[ - fold all text blocks in an editor
Ctrl+Shift+Alt+] - unford all text blocks in an editor
It will be an easy way to decrease/increase visible lines of a code and simplify the navigation though the code.
The "fold all" command will be very useful
VS Code version: Code 1.55.1 (08a217c4d27a02a5bcde898fd7981bda5b49391b, 2021-04-07T15:06:02.360Z)
OS version: Windows_NT x64 10.0.19041

sorry, I've found the solution:

Ctrl+Shift+1 - fold all
Ctrl+Shift+0 - unfold all


Added llama2-13b-chat-v1 on bedrock

Description: Added llama2-13b-chat-v1 for Bedrock client
Issue: #13316
Dependencies: None

Please make sure your PR is passing linting and testing before submitting. Run make format, make lint and make test to check this locally.
See contribution guidelines for more information on how to write/run tests, lint, etc:
https://github.com/langchain-ai/langchain/blob/master/.github/CONTRIBUTING.md
If you're adding a new integration, please include:

a test for the integration, preferably unit tests that do not rely on network access,
an example notebook showing its use. It lives in docs/extras directory.

If no one reviews your PR within a few days, please @-mention one of @baskaryan, @eyurtsev, @hwchase17.

Looks like you beat me to it, exactly the same changes I'd staged! Looks good to me +1! @3coins @hwchase17

+1

This was fast, I did the exact changes :)

Open question: shouldn't this technically (also) be in BedrockChat, since it's a chat model? https://github.com/langchain-ai/langchain/blob/master/libs/langchain/langchain/chat_models/bedrock.py

Fyi, we just created a pull request to add it, ourselves: https://github.com/langchain-ai/langchain/pull/13403

Open question: shouldn't this technically (also) be in BedrockChat, since it's a chat model? https://github.com/langchain-ai/langchain/blob/master/libs/langchain/langchain/chat_models/bedrock.py

Yes it should be

Hi there, when can we get a new release with this change? I have been using a manually updated version of langchain for that, will feel more comfortable when we get the official update. Thanks!

@baskaryan
Can you help with merging this.

believe all functionality was covered in #13403 so closing this pr, let me know if i'm missing something!


[KAFKA-5996] JsonConverter generates Mismatching schema DataException

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-test-coverage/315/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-test-coverage/316/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-test-coverage/317/

@rhauch This is a minor change, and a test has been added to support it. This PR should be ready for a final review.

@rhauch I have added some changes to the test, should now be aligned with JIRA.

@rhauch Ok, most details has been resolved.

@hachikuji  Might want to take a look before merge.

@hachikuji
Can you take a look ?


Training progress collapses after reloading (in colab)

I am trying to train a DQN agent on colab for Atari Breakout.
After 12 hours the kernel shuts down and when I reload it, the performance of the save model remains during inference, but quickly collapses when I continue to train it.
I have encountered the same issue with my own implementation of DQN Breakout and I believe that the problem is somehow related to not saving and reloading the opimizer parameters of Adam properly, ... but I haven't found a solution yet. ... Normally model. save should also save the optimizer weights and it should be no problem to continue the training ... But somehow I have this problem with stable baselines as well as with my own imlementation ... Could it be a bug keras? ... ???

Hello,
I see possible problems:

I'm afraid we do not save the target network parameters properly (in that case, that is a bug)
there is also the adam state as you pointed out, but a way to check that is to replace Adam with SGD, or to call train multiple times without re-loading the model
I don't remember if the exploration status (when using epsilon greedy exploration) is saved...

Related #301

Fixed in SB3: https://github.com/DLR-RM/stable-baselines3/issues/435


Export settings  does not export 'Support signing of unecrypted mail' setting

If I set 'Support signing of unecrypted mail' option, then export the settings, then clear K9 mail app. data, then import the settings, the 'Support signing of unecrypted mail' option does not get set.

Found the bug. 'openpgpSupportSignOnly' in GlobalSettings vs. 'openPgpSupportSignOnly' in K9. Is it safe to just edit the GlobalSetting without bumping the version?

This issue still persists in version 5.208

It's not been backported to the 5.2x branch.


Add v3 migration docs ✍

The guide can be previewed here.

:tada: This PR is included in version 3.0.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Segmentation fault (core dumped) every time I run sabre

Hello!
I am having a problem lately. I have a script that used to work before (maybe I changed something that I cannot remember...) but since today I get an error message. The script just does some steps (that work fine) and then calls sabre like this:
sabre pe -f ${demux_dir}/temp_S0_R1_001.fastq -r ${demux_dir}/temp_S0_R2_001.fastq -b $sample_names_file -u $unmatched_R1 -w $unmatched_R2 -c -m 1

However, it crashes every time throwing this error (as seen in the log files):
demuxbysabre.sh: line 38: 15825 Segmentation fault      (core dumped) sabre pe -f ${demux_dir}/temp_S0_R1_001.fastq -r ${demux_dir}/temp_S0_R2_001.fastq -b $sample_names_file -u $unmatched_R1 -w $unmatched_R2 -c -m 1
Not sure what could be the problem!! I installed sabre through conda, btw. Not sure if that matters. Thank you!

Nevermind! I found the problem.  I sent the output to a directory that I did not create in advance. Although it was completely my fault, it might be useful to get an error message, but at least the program works well! Thanks again.


Option to use proxy for http_client endpoints

I don't think we want this and should instead be using a ProxySelector.

    /**
     * Sets the HTTP proxy that will be used by connections created by this client. This takes
     * precedence over {@link #proxySelector}, which is only honored when this proxy is null (which
     * it is by default). To disable proxy use completely, call {@code proxy(Proxy.NO_PROXY)}.
     */
    public Builder proxy(@Nullable Proxy proxy) {
      this.proxy = proxy;
      return this;
    }

By default the system proxy selector is used, which seems like a reasonable default to me that uses env variables
     * <p>If unset, the {@link ProxySelector#getDefault() system-wide default} proxy selector will
     * be used.


Vendor MCM v0.43.0

What this PR does / why we need it:
This PR vendors MCM v0.43.0
Release note:

NONE

@ary1992 could you run make check and make build locally, and resolve the errors? There has been a jump of 4 minor versions of MCM with this vendoring so thats why they are failing.

Hi @ary1992
Could you check why check and build step are failing?


Character Creator Window Cleanup (and changes for the non gamer tutorial creator)

I've cleaned up the Character Creator's code. Functionality & UI remains the same.
Some of the window's methods were moved to EtraGUIUtility so that we could reuse some of the UI in other projects (such as the non gamer tutorial creator).

Hold up, there's a typo in rect extensions, will fix that tomorrow

Will test it out. Should be good!


IconButton has isRounded, but CloseButton does not.

Description
IconButton's props have isRounded, but CloseButton does not.
Problem Statement/Justification
CloseButton should also be supported, since they have almost the same role.
Proposed Solution or API
No response
Alternatives
No response
Are you willing to participate in implementing this feature and create a pull request include the implementation?
None
Additional Information
No response

Hi! @hirotomoyamada Is this a good solution?

I added this code to the css part of the CloseButton component.
...(isRounded ? { borderRadius: "9999px", border: "1px solid #000" } : {}),

@zvolcsey
Hi, thanks for the comment!
Yes, that code is correct.

Hi! @hirotomoyamada Thanks for the answer!
I'll raise a PR today.


Minesweeper implementation with react and redux

Thanks, but we're trying to keep this page focused on plain React examples.


Non account struct parsed as account in IDL

Hi,
It might be a fringe case but if you have a struct with the account annotation and also a struct deriving AnchorSerialize, AnchorDeserialize bearing the same name, both struct definitions will end up as accounts in the IDL
use anchor_lang::prelude::*;

declare_id!("Fg6PaFpoGXkYsidMpWTK6W2BeZ7FEfcYkg476zPFsLnS");

#[program]
pub mod bug {
    use super::*;

    pub fn initialize(_: Context<Initialize>) -> Result<()> {
        Ok(())
    }
}

#[derive(Accounts)]
pub struct Initialize<'info> {
    pub something: Account<'info, Something>,
}

#[account]
pub struct Something {
    pub first: u64,
}

mod other {
    use anchor_lang::prelude::*;

    #[derive(AnchorDeserialize, AnchorSerialize)]
    pub struct Something {
        pub second: u64,
    }
}

running anchor build (using anchor 0.27.0) will result in following idl:
{
  "version": "0.1.0",
  "name": "bug",
  "instructions": [],
  "accounts": [
    {
      "name": "Something",
      "type": {
        "kind": "struct",
        "fields": [
          {
            "name": "second",
            "type": "u64"
          }
        ]
      }
    },
    {
      "name": "Something",
      "type": {
        "kind": "struct",
        "fields": [
          {
            "name": "first",
            "type": "u64"
          }
        ]
      }
    }
  ]
}

Fixed in https://github.com/coral-xyz/anchor/pull/2824.


feat(samwho/spacer): scaffold samwho/spacer

samwho/spacer - CLI tool to insert spacers when command output stops
Check List

[x] Read CONTRIBUTING.md

[x] Read OSS Contribution Guide

[x] All commits are signed

This repository enables Require signed commits, so all commits must be signed

[x] Avoid force push
[x] Do only one thing in one Pull Request
[x] Execute cmdx s to scaffold code
[x] Install and execute the package and confirm if the package works well

Thank you for your contribution!


feat: support Ref: 'AWS::Region'

Description of changes:
Support Ref: 'AWS::Region'
Description of how you validated changes:
Added unit tests and end-to-end tests
Checklist:

[x] Write/update tests
[x] make pr passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #855 into develop will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #855      +/-   ##
===========================================
+ Coverage    94.56%   94.57%   +<.01%
===========================================
  Files           67       67
  Lines         2834     2839       +5
  Branches       508      509       +1
===========================================
+ Hits          2680     2685       +5
  Misses          82       82
  Partials        72       72

Impacted Files
Coverage Δ

samtranslator/intrinsics/actions.py
98.58% <100%> (+0.05%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4339ff1...4963cc5. Read the comment docs.


build failure on OSX 10.9.5 (Mavericks)

This one is only reproducible with AppleClang <IP_ADDRESS>00054 (comes with OSX 10.9.5). I checked that it's not reproducible on OSX 10.10 nor OSX 10.11.
/tmp/lean20151201-1738-t7dcjb/src/util/list_fn.h:128:5: error: static_assert failed "map: return type of f is not equal to input type"
    static_assert(std::is_same<typename std::result_of<F(From const &)>::type, To>::value,
    ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/lean20151201-1738-t7dcjb/src/library/blast/backward/backward_rule_set.cpp:145:12: note: in instantiation of function template specialization 'lean::map2<lean::blast::gexpr, lean::blast::backward_rule, <lambda at /tmp/lean20151201-1738-t7dcjb/src/library/blast/backward/backward_rule_set.cpp:145:36> >' requested here
    return map2<gexpr>(*rule_list, [&](backward_rule const & r) { return r.get_proof(); });

Just for the record, we had the same problem this summer (Jul 6). fb833a724b953bf17abe8f12680c8a28d7d1a472
We can also reproduce the problem in an old version of Ubuntu clang (i.e. 3.4). I think it's just because these versions of clang have inferior capabilities on template argument inference and failed to infer the type of F. (possibly related to this llvm bug).


Please update meteor package to 1.5.5

I'm missing the ability to pass a node to new ClipBoard() in the 1.4.2 release.

Done! https://atmospherejs.com/zenorocha/clipboard

Thanks for reporting @welelay ;)

Thank you !
That was fast :-)


Is is it possible to collect coverage with vitest-environment-miniflare?

Currently I end up with 0% coverage over all files.

Yes

We have a new approach to Vitest testing: @cloudflare/vitest-pool-workers, which supports basic istanbul based instrumented code coverage. There are issues with getting native coverage working though. See https://github.com/cloudflare/workers-sdk/issues/5266
Closing this issue as future work with be focussed on improving the new approach.


How to reset the binding of events and remove the adDisplayContainer clear、remove ima plugin clear?

Sometimes, when i hit a unknown error,
i want to reset the binding of events and remove the adDisplayContainer clear、 remove ima plugin clear that allows player events to control without being affected by videojs-ima plugin.
So how to make it? Thx~

Hello @JonasWater ,
I am a little unclear of what is being asked. If you can share a code sample that reproduces the issue, that may be helpful for finding a fix.
For resetting the IMA SDK, we recommend calling the destroy() methods for the AdDisplayContainer, the AdsLoader, and the AdsManager.
Let me know if you have any questions,
Thank you,
Jackson
IMA SDK team

Thank for your reply~ @Kiro705
Okay, the scenario I encountered: When loading the ima plugin fails, I want to remove the ima plugin from the current environment, for example: deregister the plugin and remove all event bindings, because I found that after destroying AdDisplayContainer, AdsLoader, AdsManager, The player's play event is still affected by ima
So is there any way to clear the videojs-ima plugin or IMA SDK?
Thx~

Hello @JonasWater ,
Do you know if there is an API provided by videoJS to de-register the plugin? I do not think this plugin has a specific method to do so.
Also, do you know what causes the IMA plugin to fail? Fixing that could also resolve your issue.
Thank you,
Jackson
IMA SDK team


React Native Support

Will nedb work in a react native application? The react-native-fs module will allow access to the devices file system but is it possible to override the default persistence method to utilize something like that?

I was wondering the same

See #427 - that should give you that possibility.

There's a library which is forked from this one which is RN-specific (https://github.com/smartdemocracy/react-native-local-mongodb/), although from what I can garner not much fundamentally has changed. We use it in our project pretty successfully.


Include esp_tls.h header

Hello,
would it be possible to include the esp_tls.h header? I think this would be useful to be able to make https requests.
Best regards.

I guess you have not noticed this?
Anyway, I've included this header, even though as per ^^^ it is not necessary for HTTPS requests using ESP-IDF's HTTP client (wrapper): https://github.com/esp-rs/esp-idf-sys/issues/47

I guess you have not noticed this?
Anyway, I've included this header, even though as per ^^^ it is not necessary for HTTPS requests using ESP-IDF's HTTP client (wrapper): 85561be

Oh, no I haven't noticed it. That makes it easier, thanks!


fix(designer): Fix designer load for existing hybrid triggers

Fix designer load for existing hybrid triggers

Can you have a description on how to hit this issue previously?


Supported windows versions are not valid

I have checked this Group policy on the following operating systems and found that it is not available on this OS.
Windows 8.1 -> 6.3 (Build 9600): Final Build
Windows 8 -> 6.2 (Build 9200): Final Build
Windows Server 2012 -> 6.2 (Build 9200): Final Build
Windows Server 2012 r2 -> 6.3 (Build 9600): Final Build
Windows Server 2008 r2 -> 6.1 (Build 7601): Final Build
Windows Server 2008
Windows 7 -> 6.1 (Build 7601): Final Build
This Group Policy is only applicable on Windows 10, Windows Server 2019.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2715cb88-3ce3-1ba7-b4cb-7893e9d490ea
Version Independent ID: a38a2b48-6cdd-bb25-5cb3-e00124b9effd
Content: Interactive logon Don't display username at sign-in (Windows 10) - Windows security
Content Source: windows/security/threat-protection/security-policy-settings/interactive-logon-dont-display-username-at-sign-in.md
Product: w10
Technology: windows
GitHub Login: @Dansimp
Microsoft Alias: dansimp

Good point. The page itself says, in the Reference section, that "A new policy setting has been introduced in Windows 10 starting with Windows 10 version 1703."
Allow me to open a PR to correct the "Applies to" section, as per your confirmation above.

My only uncertainty here is Windows Server 2016, but I am guessing that it should be available there, as long as the server build version is up to date.

My only uncertainty here is Windows Server 2016, but I am guessing that it should be available there, as long as the server build version is up to date.

edit: I will choose the safe route for my PR, using only your recommended wording at first: "This Group Policy is only applicable on Windows 10, Windows Server 2019."

I have also tested it on latest build of Server 2016 and it is not available on that too.

Thank you for confirming this. I chose to use the wording "Applies to: Windows 10, Windows Server 2019" just as my PR title says.

Thank you for confirming this. I chose to use the wording "Applies to: Windows 10, Windows Server 2019" just as my PR title says.

When changes will reflect on page? Because it's still the same

First of all, my PR #6469 needs to be accepted & merged into the public branch. When that happens, this issue ticket will be closed automatically.
After that, it will take anything between 1-2 days and a week for the change to migrate from the public branch to the docs.microsoft.com page.


[Good first issue | Feature]Ensure Uniqueness of Composite Primary Key

Problem
This tool aims to support composite primary keys, but it seems that it does not guarantee the uniqueness of composite primary keys.
Proposed Solution
Add validation to the metadata to ensure the uniqueness of composite primary keys during validation.
Additional context
TBD

After our assessment ( @MooooCat ) , this task is not aligned with our goals and direction, so we are closing this ISSUE and will no longer pursue it.

After our assessment ( @MooooCat ) , this task is not aligned with our goals and direction, so we are closing this ISSUE and will no longer pursue it.

This is a boundary issue of SDG, which is more like a problem in the field of data cleaning.


JSON for defaults and forms

RapidJSON replacement of Jsoncpp in ssc and wxJSON in wex.
Save defaults as JSON with calculated values as -777 and indicators as -888
See save_as_JSON branches of lk, wex, ssc and SAM for current progress

Defaults are saved as JSON. Indicators do not work with equations.
Next step here is forms as JSON


Track order changes in hasMany

Firstly, this addon is extremely helpful! Thanks a million!
We ran into a situation where hasMany relationship items are reordered. However, the change is not recognised. I believe this is due to sorting prior to comparing arrays' items:
https://github.com/danielspaniel/ember-data-change-tracker/blob/master/addon/utilities.js#L62
We believe that the above use case is rather common when users need to reorder a list of items.
What are the advantages for sorting before comparing and is it substantial enough to outweigh the above use case?

Hmm .. boy @denzo you make an interesting point.
I never thought that there would be a case where hasMany items would be considered changed based on the position in the hasMany.
When you reorder though, the property "position" ( or whatever you call it ) will change, but the actual order that is in the hasMany should not matter, since you are sorting by position anyway to get your sorted order.
So, in short, yes, sorting makes comparison way faster.
And I think what is happening is that you are wanting to have the hasMany recognize changes in the properties of the hasMany items ( like position in your case ), but change tracker does not do that.
That is a more involved feature that I backed off on a while ago because I could not figure out an easy to use API for it ( even though I could code it )

@danielspaniel Thank you for the quick response.
I agree that having a "position" attribute on each item is a common approach to persisting the order of items. It also, totally makes sense to not to track property changes for performance reasons.
In our case, however, our API stores all the items in an array like field in a NOSQL type database. Therefore, the order of the items on client needs to match the order of the items in the database.
This is my understanding of tracking changes of "hasMany":

An item has been added or removed. didChange = one.length !== other.length
An item has been replaced at a specific index. didChange = one[i] !== other[i]

This only my opinion (it doesn't take into account "polymorphic" relationships as I've never had a chance to explore them and my knowledge on them is very limited):
Sorting items prior to comparing **only** addresses the situation where content of "hasMany" changed order but the items are the same. At the point of writing I could not come up with a use case where a developer would change the order of "hasMany" items and not expect for it to be marked as `didChange = true`.
I'd like to highlight that in a situation when an item has been replaced at a specific index (point 2 above), sorting prior to comparing does not make it faster as there's no guarantee that the replaced item isn't last.
I do believe, objectively, that the reason for sorting prior to comparing is not very strong.
Would love to hear your thoughts @danielspaniel as I might be missing some crucial points.

I think your right @denzo.
Very well laid out argument. So well, that I realized that I was 100% wrong about sorting being faster in this case, because as you say, even unsorted, your checking array speed will be O(n) linear since you ( after checking length ) just go through the items 1 .. n as you said one[n] === other[n]  .. not really rocket science there.
I think I was originally thinking:
People would NOT want to consider that the hasMany changed if the position in the array changed. Not sure why I thought that .. but ?? as you say .. can't think of that case anymore
So, if you want to change the code in function
export const hasManyChanged = function(one, other, polymorphic) {
  if (isEmpty(one) && isEmpty(other)) {
    return false;
  }

  if ((one && one.length) !== (other && other.length)) {
    return true;
  }

  if (polymorphic) {
    one = Ember.A(one).sortBy('id');
    other = Ember.A(other).sortBy('id');
    for (let i = 0, len = one.length; i < len; i++) {
      if (serializedModelChanged(one[i], other[i])) {
        return true;
      }
    }
    return false;
  }

  one.sort();
  other.sort();
  for (let i = 0, len = one.length; i < len; i++) {
    if (one[i] !== other[i]) {
      return true;
    }
  }
};

and submit a PR, let me know, otherwise I will do it.
Also, you could ( just as a thought ) use model fragments to store these "unstructured data" models. , which would make this a hasMany fragmentArray ...
But either way .. seems like the hasManyChanged method can be super simplified as you suggest.

That's awesome news! I'll whip up a PR tomorrow.
@danielspaniel Thanks for hearing me out.

ok, great @denzo . I just updated the tests on master so you are ready to easily change the code and then change one line in the test that will fail. Should be nice and simple

@danielspaniel Here is the promised PR https://github.com/danielspaniel/ember-data-change-tracker/pull/15
Let me know if I missed anything.

all set in:
https://github.com/danielspaniel/ember-data-change-tracker/releases/tag/v0.5.5


Updated QuantEcon menubar

Implementing the new menubar across QE sites.

[ ] once merged conduct a clean run on ec2

Thanks @DrDrij, will merge this and queue up a clean build on AWS.


Revert "Remove GH action for deployment"

Reverts statsig-io/docs#2107

🚀 Deployed on https://66ff26e20c21d754614de9cb--cozy-fox-0defec.netlify.app


Back/home button

How to add back/home button to this player like action bar?

You can use YouTubePlayerView.addView(View view) to add an icon to the top of the player.

ok thank you


Add logger as a dependency, ostruct to the Gemfile for tests

There was a warning in ruby-head (3.4) that in Ruby 3.5 logger and ostruct will not be built-in gems, but regular gems.
/home/runner/work/dalli/dalli/test/helper.rb:13: warning: logger was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.5.0. Add logger to your Gemfile or gemspec.
/home/runner/work/dalli/dalli/test/helper.rb:14: warning: ostruct was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.5.0. Add ostruct to your Gemfile or gemspec.

This change avoids that warning.
Perhaps the ostruct dependency can be ommitted, I found no usages of it in the source code of dalli.

@olleolleolle can you please address the Rubocop warnings?  Thanks.

@petergoldstein Thanks, I revisited the change, and was able to remove the ostruct, and pass linting.


HTTPS via appsettings.json, much more easier!

How to use Kestrel in ASP.NET Core apps
https://docs.microsoft.com/en-us/aspnet/core/fundamentals/servers/kestrel?view=aspnetcore-2.1&tabs=aspnetcore2x#how-to-use-kestrel-in-aspnet-core-apps

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3ac102a5-e9ad-0046-f217-446f1ad263c5
Version Independent ID: a47523e2-0c30-dee4-0037-5f58836fa37f
Content: Add an HTTPS endpoint using Kestrel to a Service Fabric app in Azure
Content Source: articles/service-fabric/service-fabric-tutorial-dotnet-app-enable-https-endpoint.md
Service: service-fabric
GitHub Login: @rwike77
Microsoft Alias: ryanwi

Sample appsettings.json:
{
"Kestrel": {
"EndPoints": {
"DevHttp": {
"Url": "http://*:5000"
},
  "DevHttpsInlineCertFile": {
    "Url": "https://*:5001",
    "Certificate": {
      "Path": "localhost.pfx",
      "Password": "Password01!"
    }
  },

  "DevHttpsInlineCertStore": {
    "Url": "https://*:5002",
    "Certificate": {
      "Subject": "localhost",
      "Store": "My",
      "Location": "CurrentUser",
      "AllowInvalid": "true"
    }
  },

  "DevHttpsDefaultCert": {
    "Url": "https://*:5003"
  },

  "DevHttps": {
    "Url": "https://*:5004",
    "Certificate": {
      "Path": "localhost.pfx",
      "Password": "Password01!"
    }
  }
},
"Certificates": {
  "Default": {
    "Path": "localhost.pfx",
    "Password": "Password01!"
  }
}

}
}

Thanks for the question! We are investigating and will update you shortly.

@kai-wang- I have assigned this to the content author to review and see if we can update the document.

@Kai-wang what is the specific documentation ask in this issue?

I tried the doc (Tutorial: Add an HTTPS endpoint to an ASP.NET Core Web API front-end service using Kestrel) to enable Kestrel/HTTPS in Service Fabric environment. However, the instructions are too complicated. Relatively appsettings.json provides easier way to enable https which is widely used.

Furthermore, I found another way to load SSL certificate from Azure Key Vault, the app is running in Docker container. This avoid the dependency to Service Fabric.
My point is: Enabling https with SSL certificate is very common requirement for production environment.  Service Fabric, as a host, should provide easier way to achieve this goal.

Thanks for the suggestion--I've captured it in our work backlog. #please-close


feat: Move from rest-hooks to @rest-hooks/react pkg

BREAKING CHANGE:

Requires @rest-hooks/react instead of rest-hooks
No longer support shape-based fixtures

use shapeToEndpoint from @rest-hooks/legacy to convert

Motivation

Moving people toward @rest-hooks/react - so we need it as peerdep
Solution

Codecov Report

Merging #2274 (9aba684) into master (f36a6cb) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2274      +/-   ##
==========================================
- Coverage   98.17%   98.12%   -0.06%
==========================================
  Files         120      120
  Lines        1923     1923
  Branches      289      289
==========================================
- Hits         1888     1887       -1
- Misses         18       19       +1
  Partials       17       17

Impacted Files
Coverage Δ

...ore/src/state/legacy-actions/createReceiveError.ts
83.33% <0.00%> (-16.67%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Changed order of elements on news page

👷 Deploy Preview for balkantransport processing.
🔨 Explore the source changes: 390a5ad654f09136c30c821ac3071a998bf8859c
🔍 Inspect the deploy log: https://app.netlify.com/sites/balkantransport/deploys/618aed552129340007f96bba


Upgrade Apache Commons Collections to v3.2.2

Version 3.2.1 has a CVSS 10.0 vulnerability. That is the worst kind of
vulnerability that exists. By merely existing on the classpath, this
library causes the Java serialization parser for the entire JVM process
to go from being a state machine to a turing machine. A turing machine
with an exec() function!
https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2015-8103
https://commons.apache.org/proper/commons-collections/security-reports.html
http://foxglovesecurity.com/2015/11/06/what-do-weblogic-websphere-jboss-jenkins-opennms-and-your-application-have-in-common-this-vulnerability/

Made the change in snapshot-2015-08-10-with-commons-3.2.2 branch.
Master branch is to track upstream.
Thanks for the PR.


retry extensions: implement "other priority" extension

Implements a RetryPriority which will keep track of attempted
priorities and attempt to route retry requests to other priorities. The
update frequency is configurable, allowing multiple requests to hit each
priority if desired.
As a fallback, when no healthy priorities remain, the list of attempted
priorities will be reset and a host will selected again using the
original priority load.
Extracts out the recalculatePerPriorityState from LoadBalancerBase to
recompute the priority load with the same code used by the LB.
Signed-off-by: Snow Pettersen<EMAIL_ADDRESS>Risk Level: Medium, new extension
Testing: UTs
Docs Changes: n/a
Release Notes: n/a

@alyssawilk do you mind taking this one on?


Questions about the app

It takes a long time to process the video using the command, if you use the app, can the speed be faster? https://getrecut.com/ This product can process the video in a few seconds after importing the video, but it can only judge based on the sound, and not on the video screen changes.

The app doesn't render faster than the cli. You can preview different editing thresholds faster in the app though.


static dump of a dat

After convo with @talos, seems wise to have a 'dat dump' , that is, a binary version of a dat that could be packaged and stored on s3 or some place, where another dat has the ability to dat pull from.
This is particularly useful in cases where a producer doesn't have the server resources/capacity to host a bunch of dats, or when a dat needs to be transferred from one place to another

:+1:

After a whole year of feedback from the community, we recently published a new version of dat... and it makes this issue obsolete. Would you mind trying out the new dat with npm install -g dat? You can read about the new dat announcement on the website and how it works in the docs.


Fix aspnet/Mvc#3196 Razor Compilation Allocations

This change significantly reduces the amount of string and List
allocations that occur during compilation by changing the way
LiteralChunks are combined.
This is a low impact fix that addresses the performance issue, the design
issues that caused it still exist.
The problem here lies in what Razor fundamentally does - it parses HTML/C#
into tokens, and then combines them back into 'chunks' a representation
friendly to code generation. When presenting with a large block of static
HTML, Razor parses it into individual HTML tokens, and then tries to join
them in back into a single chunk for rendering. Due to details of Razor's
representation of chunks/tokens, the process of combining literals is too
expensive.
Mainly, what's done here is to not try to combine instances of
LiteralChunk. The process of merging them is too expensive and requires
lots of interm List and string allocations.
Instead we produce a new 'chunk' ParentLiteralChunk, which doesn't do so
much up-front computing. Various pieces of the code that deal with
LiteralChunk need to be updated to deal with ParentLiteralChunk also,
which is the bulk of the changes here.
Note that we still have the potential for LOH allocations to occur during
codegen, but it's likely to occur O(1) for each large block of HTML
instead of O(N) as it did in the old code.

:watch:

Before

I actually had to kill the process :laughing: I have no idea how much it would have eventually allocated.
After

This still needs a lot of love. Compilation time dropped from 5+ mins down to 4 seconds.

:shipit:


truckRestrictionPenalty

Is there somewhere an option to pass in truckRestrictionPenalty=soft to the truck_route method like mentioned here https://developer.here.com/documentation/routing/dev_guide/topics/example-truck-route-violating-restriction.html ?
I dug through the code and found nothing.

@mightym - truckRestrictionPenalty=soft is part of routing API version 7 and we are supporting version 8 which is the latest version.
You can find more information about version 7 to version 8 migration here.
truckRestrictionPenalty param is not there in version 8 -
Routes that violate truck restrictions:
Routing v7 had a strict approach to truck restrictions. There, no route which violated some truck restriction(s) was ever returned. It was possible to change this behavior with the truckRestrictionPenalty parameter, but even then Routing v7 provided only a generic notice: Code: routingOptionViolated, Text: truckRestriction.
In v8 if no route can be found that obeys all specified options and truck parameters, and avoids all applicable restrictions, a route that violates some of them will be returned by default. A set of critical notices explaining which restrictions could not be avoided will also be provided.

@sackh Ah! Awesome mate. And thanks a lot for taking your time for such an elaborated explanation.


lose the height when send_global_velocity

Currently, I get a problem when I use dronekit-python to run a function call send_ned_velocity(velocity_x, velocity_y, velocity_z, duration)
http://python.dronekit.io/guide/copter/guided_mode.html#guided-mode-copter-velocity-control
def send_ned_velocity(velocity_x, velocity_y, velocity_z, duration):
    msg = vehicle.message_factory.set_position_target_local_ned_encode(
        0,       # time_boot_ms (not used)
        0, 0,    # target system, target component
        mavutil.mavlink.MAV_FRAME_LOCAL_NED, # frame
        0b0000111111000111, # type_mask (only speeds enabled)
        0, 0, 0,  # x, y, z positions (not used)
        velocity_x, velocity_y, velocity_z,  # x, y, z velocity in m/s
        0, 0, 0,  # x, y, z acceleration (not supported yet, ignored in GCS_Mavlink)
        0, 0)     # yaw, yaw_rate (not supported yet, ignored in GCS_Mavlink)
    # send command to vehicle on 1 Hz cycle
    for x in range(0, duration):
        vehicle.send_mavlink(msg)
        time.sleep(1)

I set velocity_x=2,velocity_y=0, velocity_z=0 and duration=3. It seems that the copter should fly north at the same height. But in the real test, it flies north and down. It can not hold the same height continuously. And the height changes obviously.
Is it a bug or a flaw of the barometer? Anyone has the same experience?
I don't know  if I should change the barometer to a sonar? Or find another better function to execute the function? Could anyone tell me how to fix it?

No idea. Perhaps raise this for discussion on https://gitter.im/dronekit/dronekit-python


Fix display of some emoji on Windows

Problem
In many Windows browsers (Chrome, Firefox, Edge), certain older emoji (pre-2012) render in monochrome using the Segoe UI Symbols font. Newer emoji are rendered in the Segoe UI Emoji font.

Solution
If the css fontFamily string for an element includes Segoe UI Emoji as a final fallback, all emoji are rendered correctly.
This PR appends the fallback font in the getFontFamilyString utility function. So for example if the user's selected font is Cascadia, the result will be Cascadia,Segoe UI Emoji.

Can't test on my end so I'll trust it works great :)


Migrate apache httpd importer

Thanks @pombredanne .  @TG1999 -- would you like me to make the changes @pombredanne has suggested and push my updated code before you start your review, or shall I wait for your comments?

@johnmhoran please address @pombredanne review comments and push the updated code.

Thank you @TG1999 -- will do.


Bounces all dead links to /index.html

this is better than 404s

I'm not sure this will result in 200 as the site isn't a proxy. will test on the deploy preview to see the behavior

works as 200. I've also changed /install.sh (used for old getenvoy CLI) to serve from CDN instead of via a github redirect


Calls to COM interfaces return objects with refCount = 0

The COM contract states that the function should call AddRef before returning the COm object to the caller. The caller is then responsible for calling Release. (See: https://msdn.microsoft.com/en-us/library/ms692481.aspx)
However, it seems that lib3mf does not do this and sets all Com Pointers to refcount = 0, requiring the caller to call AddRef (against the COM contract).
Is this expected? Am I missing something?

Please see https://github.com/3MFConsortium/lib3mf/issues/51


shouldQueueEvents should not check options.queueMessages

          Why is all of this still gated under a condition that fails if `options.queueMessages` is false? This is [RTL3](https://sdk.ably.com/builds/ably/specification/main/features/#RTL3), right? That spec item doesn't mention anything about queueMessages, what do they have to do with each other?

Originally posted by @SimonWoolf in https://github.com/ably/ably-cocoa/pull/1005#discussion_r999661537
┆Issue is synchronized with this Jira Task by Unito

Currently it combines if options set to not queue messages and whether conditions are met. That shouldn't be the case as mentioned by Simon. Options should be checked only before adding to the queue.

Fixed in https://github.com/ably/ably-cocoa/pull/1941/commits/586c255ed85ee6320549e9cca149cdff41522185


Problem customizing HTMLImageElement

I'm trying to customize HTMLImageElement (), below is my code.
There is no error during the execution however, the image is not loaded, but the node was added to the DOM tree. Also, no request to fetch the image was made.
I'm using the version 1.7 in Chrome 62
customElements.define('g-img', class extends HTMLImageElement {
constructor() {
super();
}
}, { extends: 'img' });
let img = document.createElement('g-img', { is: 'img' });
img.src = 'http://path.com/to/my/image.jpg';
document.body.appendChild(img);

customElements do not support custom builtin extends so I am not planning to fix this because it's not a standard behavior.
Apologies if this is not the answer you were looking for.


Example usage with Astro?

Hello. I would like to know if its possible to use this with the Astro framework?

Using the is:inline directive (https://docs.astro.build/en/reference/directives-reference/#isinline) should work after importing the script.
example:
<div>
  <style is:inline>
    me {
      background-color: red;
    }
  </style>
...
</div>

Gonna convert this to a discussion as it may be an ongoing thing. Kudos @AceroM for your insight as a fellow Astro user :+1: Could add a very short note about it in the Technical FAQ- but I'd generally like to avoid adding content that applies to only one framework.


Deprecated centralIstiod flag in 1.9

Isn't this targeted in 1.8?

The plan is  we will support both flag in 1.8.  Old flag will be deprecated in 1.9.

It is already deprecated (but still supported) in 1.8.  In 1.9, it can be removed. :)

@brian-avery @ericvn could you kindly create 1.9 milestone?

@linsun Milestone created with https://github.com/istio/bots/pull/286.


Add vertical option?

:+1:

This could be hacked very easy by providing the width of the social links container.

oh veryyyyy true


feat: upgrade libraries for dependabot alerts

Great work @lohxt1 !
Keep it up !!
This is a significant step forward in enhancing the security of the project


Node.js doesn't quit while stop debugging.

Issue Type: Bug
Everytime starting debugging asp.net core react app, after stop debugging, four more nodejs processes hanging in Task Manager. it quickly consumed all memory and make computer not responsive.
VS Code version: Code 1.24.1 (24f62626b222e9a8313213fb64b10d741a326288, 2018-06-13T17:51:32.889Z)
OS version: Windows_NT x64 10.0.15063

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-7500U CPU @ 2.70GHz (4 x 2904)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: unavailable_softwarevideo_decode: enabledvideo_encode: enabledvpx_decode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
15.88GB (6.97GB free)

Process Argv
C:\Program Files\Microsoft VS Code\Code.exe

Screen Reader
no

VM
0%

Extensions (11)

Extension
Author (truncated)
Version

html-snippets
abu
0.2.1

ng-template
Ang
0.1.9

vscode-eslint
dba
1.4.12

gitlens
eam
8.3.5

EditorConfig
Edi
0.12.4

tslint
eg2
1.0.31

classic-asp
ili
0.0.4

python
ms-
2018.5.0

csharp
ms-
1.15.2

debugger-for-chrome
msj
4.6.0

vscode-icons
rob
7.23.0

![nodejs](https://user-images.githubusercontent.com/7731284/41439708-0bbbe24a-6fe9-11e8-8af1-f70ef151dad4.jpg)

In debugging, process (id=13360) is a child process under dotnet.exe process (id=11188)

Out of debugging, the process (id=13360) didn't get killed and its parent is gone.

Please file this against the csharp extension.


Graceful shutdown of one workflow instance.

I have one use case, where I need to tell worflow-manager to stop listening to new tasks and complete already running tasks.
I have checked all APIs available ,but I could not find any solution for it. If you could help me on this use case that would be very great.

You are in control of submitting new tasks. So, you could just stop submitting new tasks and then use the admin APIs to watch for current tasks to finish. Does that work for you?

Thank you for response.
In my use case, there are set of workflow instances running. I wanted to take down one instance without affecting other workflow instance.
I can very well kill that instance I wanted to take down, according to Nirmata's design other instances will pick-up running tasks(if idempotent) automatically.
But, in my case, these tasks are very time consuming ones, so I don't want to terminate them abnormally. So I was looking for any other ways to tell workflow manager to stop listening to new tasks, then I can wait till completion of already running tasks and terminate that instance.
Thank you again.

OK - it's definitely possible. I don't have time to do it right now. I'd appreciate a PR or I'll get to it when I can.

I forked the project, will add the feature of stopping workflow gracefully in workflowmanager API.
Before I start, could you please tell me, if any thing I need to know.
Thank you.

You'd:

Add an API to WorkflowManager - something like gracefulShutdown(maxWait)
The main work is in SimpleQueue - Call shutdown on the executorService then awaitTermination

Something like that

Thank you for the quick response, will send pull request once done with that.


Taiwan Province is Chinese territory.

Taiwan Province is Chinese territory. But i can't see it on my map.

＋1

China map in this project is based on http://www.gadm.org/country shapefile. And there is no Taiwan province.

It's a pity to hear that. But we will see Chinese Developers won't use it until you fixed it. Maybe, I should give you more evidence to support my opinion. Now, there is one reason that Chinese Developers
is not a small part of Github which means you will lose your contributors in China. Ummm... I have to say... it's a hard thing...(⊙﹏⊙)

Yes, we can learn something from Google Maps. There are two domains:

https://www.google.com/maps
https://www.google.cn/maps
yeah!

@zhoukekestar I would propose a better solution is to fork the project, and build in a feature to choose a custom shapefile. Asking all people to inherit a data set based on politics is anti-opensource.
This provides added utility and is apolitical.

Sounds great!

@motleydev I agree with you and like your idea about custom shapefiles. But this is quite a big feature and :( unfortunately lately, I don't have much time. For now, I simplified process of adding new maps, I'll add step-by-step instructions about adding new maps to README, and would happily accept PRs with new maps 😃

We can have debates on whether Taiwan is part of China or not (absolutely not) for years. But it's really funny seeing someone threatening others such way. Especially somebody from a country that tries to DDoS github

I agree with @motleydev . And that's the solution about this issue.  I'm sorry to intrude on you @caspg.  Yep, your project is awesome. Thanks anyway. For you, Mr. @stegben , I'd like to talk with you in chinese .

君子务本，本立而道生
by Confucius.

Thanks for your invitation, but no. As I mentioned, the talk might last for years. Nobody have time for that.
By the way, citing a rather irrelevant ancient quote does not make your words more persuasive.
p.s. @caspg thanks for such a great project. I apologize if this discussion bothers you.


Simplify search query

Fixes

Fixes #3243 by @obulat
Description

Instead of using elasticsearch_dsl for creating the search query, this PR uses a simple dictionary for the 4 query clauses: filter, must_not, must and should. This dictionary is then used to create a much cleaner query which is almost identical in function to the existing query.
The biggest difference is that the url parameter queries (license, aspect ratio, width, extension, etc.) are actually filters. They remove all of the non-matching items from the results, instead of simply assigning them a lower score. Not calculating the score should also in theory make the filters faster.
Query examples
To make these queries similar to the production queries, I checked "Hide content" in the Flickr ContentProvider object form in Django admin. This should dynamically add this provider to exclude query.
No parameters
http://localhost:50280/v1/images/?format=json&page_size=1
Updated
{'bool': {
    'must': [{'match_all': {}}],
    'must_not': [{'term': {'mature': True}}, {'terms': {'provider': ['flickr']}}],
    'should': [{'rank_feature': {'boost': 10000, 'field': 'standardized_popularity'}}]
}}

Old
{'bool': {'must': [{'bool': {'filter': [{'bool': {'must_not': [{'term': {'mature': True}}]}},
                                                  {'bool': {'must_not': [{'terms': {'provider': ['flickr']}}]}}]}}],
                    'should': [{'rank_feature': {'boost': 10000,
                                                 'field': 'standardized_popularity'}}]}}

q search with filters
http://localhost:50280/v1/images/?q=cat&format=json&license=by,cc0&aspect_ratio=wide&page_size=1
Updated
{'bool': {
    'filter': [{'terms': {'license': ['by', 'cc0']}}, {'terms': {'aspect_ratio': ['wide']}}],
    'must': [{'simple_query_string': {'default_operator': 'AND', 'fields': ['title', 'description', 'tags.name'], 'query': 'cat'}}],
    'must_not': [{'term': {'mature': True}}, {'terms': {'provider': ['flickr']}}],
    'should': [{'simple_query_string': {'boost': 10000, 'fields': ['title'], 'query': 'cat'}}, {'rank_feature': {'boost': 10000, 'field': 'standardized_popularity'}}]
}}

Old
{'bool': {
    'must': [{'bool': {'must': [{'bool': {
                 'filter': [
                   {'bool': {'should': [{'terms': {'license': ['by', 'cc0']}}]}},
                   {'bool': {'should': [{'terms': {'aspect_ratio': ['wide']}}]}},
                   {'bool': {'must_not': [{'term': {'mature': True}}]}},
                   {'bool': {'must_not': [{'terms': {'provider': ['flickr']}}]}}
                 ],
                 'must': [{'simple_query_string': {
                                 'default_operator': 'AND', 'fields': ['tags.name', 'title', 'description'],  'query': 'cat'}}]}}],
                 'should': [{'simple_query_string': {'boost': 10000,  'fields': ['title'], 'query': 'cat'}}]}}],
                  'should': [{'rank_feature': {'boost': 10000, 'field': 'standardized_popularity'}}]}},}

title search (without q) with excluded_source param
http://localhost:50280/v1/images/?title=cat&format=json&excluded_source=stocksnap&page_size=1
New
{'query': {'bool': {
    'must': [{'simple_query_string': {'fields': ['title'], 'query': 'cat'}}],
    'must_not': [{'terms': {'source': ['stocksnap']}},{'terms': {'provider': ['flickr']}}, {'term': {'mature': True}}],
     'should': [{'rank_feature': {'boost': 10000, 'field': 'standardized_popularity'}}]}}
}

Old
{ 'query': {'bool': {
    'must': [{'bool': {'filter': [{'bool': {'must_not': [{'terms': {'source': ['stocksnap']}}]}},
                                                  {'bool': {'must_not': [{'term': {'mature': True}}]}},
                                                  {'bool': {'must_not': [{'terms': {'provider': ['flickr']}}]}}],
    'must': [{'simple_query_string': {'fields': ['title'], 'query': 'cat'}}]}}],
     'should': [{'rank_feature': {'boost': 10000, 'field': 'standardized_popularity'}}]
}}}

Unit tests
I added unit tests for  the newly extracted search_controller.create_search_query method. I wish it was easy to parametrize these tests, but because we need to check the whole query for each test, it's not easy to do.
While writing the tests, I realized that the categories filter doesn't work anymore. In the search_controller, we still try to handle it converting the deprecated categories param to the current category parameter. However, the serializer does not pass the deprecated categories to the controller! So, I just removed the deprecated categories param from the controller.
Another thing I learned when writing the tests is that license and license_type filters don't interact at all, so they create 2 completely separate terms filters. We should probably combine them, taking an intersection of the two license lists as the ES query filter (e.g., if license=by-nc&license_type=commercial would not return any results with by-nc because the commercial filter would exclude them).
Testing Instructions

Set DEBUG_SCORES=True to the api/.env file so that the Elasticsearch queries a logged in the web Docker container logs.
Run the API using just up.
Go to localhost:50280/admin (use deploy/deploy to log in), and check "Hide content" for one of the providers so that one of the providers is excluded dynamically in the queries (to match the current prod settings).
Try the queries from the PR description and look at the queries logged in Docker logs.
Also compare the queries to the ones on the main branch and see that they are different.
Checklist

[ ] My pull request has a descriptive title (not a vague title likeUpdate index.md).
[ ] My pull request targets the default branch of the repository (main) or a parent feature branch.
[ ] My commit messages follow best practices.
[ ] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[ ] I tried running the project locally and verified that there are no visible errors.
[ ] I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

One note about the tests: they're quite specific right now, in that they test the specific functions, and I wonder if they would be less fiddly in the future if we make adjustments to how the search query is built by doing a more "integration" style test by checking the actual query sent to Elasticsearch. This is done elsewhere using pook to intercept the Elasticsearch client call. Not a request for change here because I'm not confident it's correct, but wanted to suggest it in case you had thoughts about the particular testing approach. I could also see the integration style test being more fiddly because it relies on the ES client's implementation of how it sends the query... on the other hand, that's an important thing we should know if it changes. There are trade-offs, in any case.

Thank you for the suggestion, @sarayourfriend. I will leave the tests as they are here, but checking the ES queries seems valuable. Maybe we should use both?


fix typo for shepherd

What type of PR is this? (check all applicable)

[ ] ♻ Refactor
[ ] ✨ New Feature
[ ] 🐛 Bug Fix
[x] 📝 Documentation Update
[ ] 👷 Example Application
[ ] 🧑💻 Code Snippet
[ ] 🎨 Design
[ ] 📖 Content
[ ] 🧪 Tests
[ ] 🔖 Release
[ ] 🚩 Other

Description

This PR adds this typo fix.
Related Tickets & Documents

Resolves #1575
Mobile & Desktop Screenshots/Recordings

Added code snippets?

[ ] 👍 yes
[x] 🙅 no, because they aren't needed

Added tests?

[ ] 👍 yes
[x] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

No tests? Add a note

small typo fix
Added to documentation?

[ ] 📜 readme
[ ] 📜 contributing.md
[ ] 📓 general documentation
[x] 🙅 no documentation needed

No docs? Add a note

small typo fix
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?

@EbonyLouis could you please review this PR for typo fix.


Hiccuping with drawing functions

Some people (including me) experience problems when lot of drawing function are involved, lag spike every 2s or so (exp. entity info example from overlunky), i noticed after the vanilla one were added that they also have the same problem.
It's a lag every couple seconds. Does not seam to be issue with processing power (i run i7 4790K) which should have more then enough to do stuff, someone on the discord who also mentioned this problem had even better CPU.
Maybe it has something to do with how often the drawing callbacks are executed? But it does not seam to be problem with empty callback

Just cleaning up issues here. This hiccupping still seems to occur when doing e.g. get_entity() for 2000 entities every guiframe, but using cached position data to draw those same entities seems absolutely fine. So just don't do too many things in a guiframe I guess.


binding on select option change not working

Version
2.3.3
Reproduction link
https://jsfiddle.net/duvguoyy/1/
Steps to reproduce
Select an Aircon Brand, you can see that the <pre/> tag I've made to check all the values of my datas: 			form_submissions, hasn't been updated as expected.
But when you just focus in and focus out the input number bellow the Aircon Brand: Area, the select has been bind, and my <pre/> has been populated.
It's making the same for my children selects.
What is expected?
When I change a value from a select box with a v-model="arr[index]", it should be binded by vuejs.
What is actually happening?
It's working only after I've focus in and focus out an input text (or number), it should work whenever I change a value on a select box.

The current behavior is that v-model does not create reactive fields that do not exist for you, so although the value is being set, they don't trigger updates. The design encourages you to declare your model fields upfront instead of using an empty object.
However when using dynamic path segments in the binding it seems impractical to declare the fields beforehand, so I've added a patch that makes your code work in d333a49.
That said, it seems better to use an Array for form_submissions here (which already works in current version).


Added remote includes to Spring tutorials

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/72596fb339b2bd1aa94a817ebdf1ba0a7812eef8/
Edited pages:

v20.2/build-a-spring-app-with-cockroachdb-jdbc.md
v20.2/build-a-spring-app-with-cockroachdb-jpa.md
v20.2/build-a-spring-app-with-cockroachdb-mybatis.md
v21.1/build-a-spring-app-with-cockroachdb-jdbc.md
v21.1/build-a-spring-app-with-cockroachdb-jpa.md
v21.1/build-a-spring-app-with-cockroachdb-mybatis.md

Looks good. And remote fragment includes are in master now, fwiw.

Awesome. We'll need to do a larger refactor over the next quarter or two. I can open issues for specific languages/tutorials.


Document deployment zip structure

Description
Ensure there is clear documentation of what the deployed payload needs to be structurally. We occasionally see folks archiving the project root and not the output of a dotnet publish, etc. This should hopefully help lead to succesful deployments

This is now live: https://learn.microsoft.com/en-us/azure/azure-functions/dotnet-isolated-process-guide?tabs=windows#deployment-payload


allow for fontsize prop on input component

I needed to be able to set a custom font size for an input. I could make a custom Input component, but couldn't think of a reason why not to allow for setting font-size prop by default. Please let me know if there is a different approach you would recommend.

Thanks! I think your change shows how it should have been written in the first place :)


Add company role data to Amplitude to measure internal Lovability

@kelsey-brown , can I get your help uploading this company role data into Amplitude, and then joining that with event data so I can track lovability data directly in Amplitude (rather than my own custom built/hacky Google sheets?)
Role data: https://docs.google.com/spreadsheets/d/1-lLVUr5cFSxNEj0v5_m0PjpO5YFuGik5qJfz_gbgC0g/edit#gid=779671194
How I'm joining email data: https://docs.google.com/spreadsheets/d/1-lLVUr5cFSxNEj0v5_m0PjpO5YFuGik5qJfz_gbgC0g/edit#gid=1530973111

@akalia25 can we add this as a lookup in Amplitude?

Hey @kelsey-brown and @akalia25 , any update on this?

@akalia25 we can take a look at this during data review today!

Hey @chenkc805, this is completed and the data is in Amplitude. You now add the role/dept to the internal lovability charts on Amplitude :)


EOS-19065: Revert the feature temporarily

Problem: this feature requires support from Motr side as well (in other
words, as of #1721 Hare assumes that Motr provides additional JSON
file). The feature is not fully implemented by Motr side,
Solution: revert the feature temporarily

VM Deployment is failing, Is it expected?

Yes @SwapnilGaonkar7 deployment will fail.. as it has motr dependency

@knekrasov if this deployment job PASSes, we can close this PR without reverting the changes.
http://eos-jenkins.colo.seagate.com/job/Cortx-Main/job/centos-7.8.2003/job/Partition Main Deploy 3N/177/

Closing this PR as no need to revert, because Motr has fixed the issue.


node softmax_cross_entropy_with_logits

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Google Colab

TensorFlow version:1.14.0

Python version:3.6.8

Describe the problem
** I have created custom model for cifar 10 dataset. I m unable to use tf.nn.softmax_cross_entropy_with_logits_v2 gets   Invalid argument: logits and labels must be broadcastable: logits_size=[128,10] labels_size=[1,128]
The entire source code can be viewed at
https://colab.research.google.com/drive/11tyipxzE9qkmlwkiPhs-A8I2OvT5Jebi

In order to expedite the trouble-shooting process, please provide a minimal standalone code to reproduce the issue reported here. Thanks!

I have given shared permission you can check now

@joyjeni
Can you please help me with the files. It helps us to reproduce the issue in our environment.Thanks!

It's fixed from my end. It was the behavior with calculating the loss on batches

I am closing this issue since it looks to be fixed. Thanks!

It's fixed from my end. It was the behavior with calculating the loss on batches

@joyalbin
Hello, I have encountered the same error:
"Error recorded from training_loop: logits and labels must be broadcastable: logits_size=[4000,2] labels_size=[8,2]"
How to fix this error?

Getting the same kind of error
Output exceeds the size limit. Open the full output data in a text editor---------------------------------------------------------------------------
InvalidArgumentError                      Traceback (most recent call last)
Cell In[31], line 3
1 batch_size = 16
2 epochs = 15
----> 3 history = model.fit(train_dataset,
4             batch_size = batch_size,
5             validation_data = validation_dataset,
6             epochs = epochs,
7             callbacks = callbacks)
File [d:\Anaconda\envs\keras\lib\site-packages\keras\engine\training.py:1184](file:///D:/Anaconda/envs/keras/lib/site-packages/keras/engine/training.py:1184), in Model.fit(self, x, y, batch_size, epochs, verbose, callbacks, validation_split, validation_data, shuffle, class_weight, sample_weight, initial_epoch, steps_per_epoch, validation_steps, validation_batch_size, validation_freq, max_queue_size, workers, use_multiprocessing)
1177 with tf.profiler.experimental.Trace(
1178     'train',
1179     epoch_num=epoch,
1180     step_num=step,
1181     batch_size=batch_size,
1182     _r=1):
1183   callbacks.on_train_batch_begin(step)
-> 1184   tmp_logs = self.train_function(iterator)
1185   if data_handler.should_sync:
1186     context.async_wait()
File [d:\Anaconda\envs\keras\lib\site-packages\tensorflow\python\eager\def_function.py:885](file:///D:/Anaconda/envs/keras/lib/site-packages/tensorflow/python/eager/def_function.py:885), in Function.call(self, *args, **kwds)
882 compiler = "xla" if self._jit_compile else "nonXla"
...
[[node categorical_crossentropy/softmax_cross_entropy_with_logits (defined at [C:\Users\ATI\AppData\Local\Temp\ipykernel_3960\2751684548.py:3](file:///C:/Users/ATI/AppData/Local/Temp/ipykernel_3960/2751684548.py:3)) ]] [Op:__inference_train_function_42206]
Function call stack:
train_function


The inferred type of '_sfc_main' cannot be named without a reference to ...

Describe the bug
This looks like the same issue, i can not build success always when I use higher version vue.
#[The inferred type of '_sfc_main' cannot be named without a reference to](ttps://github.com/vuejs/core/issues/7038)
Reproduction
https://github.com/vuejs/core/issues/7038
Steps to reproduce
No response
System Info
node: 18.12.1
plateform: windows11
vite: 4.2.1
vue: 3.2.47

Validations

[X] Read the FAQ.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] The provided reproduction is a minimal reproducible example of the bug.

console out
[vite:dts] Start generate declaration files...
✓ built in 170ms
src/knowledge-example/knowledge-example.vue.ts:5:7 - error TS2742: The inferred type of '_sfc_main' cannot be named without a reference to '.pnpm/@vue+shared@3.2.47/node_modules/@vue/shared'. This is likely not portable. A type annotation is necessary.

5 const _sfc_main = /*#__PURE__*/_defineComponent({
        ~~~~~~~~~

[vite:dts] Declaration files built in 1144ms.

The same problem

any solution

Should be fixed in 3.0.0-beta.2.


fix gouroutine leak when sharedcontroller has been started

lasso PR

Problem
If there's something wrong with downstream clusters and usercluster controller has to restart frequency, will cause goroutine leaks with management controller factory.
When the usercluster controller starts to handle a downstream cluster, we also start management controllers here  where the goroutine leaks problem happens.
Solution

Rancher will start a usercluster controller for each downstream cluster and will start management controller factory here. The management controller factory will start only once because it checked started state here. If there's something wrong with the downstream cluster and usercluster controller has to stop, it canceled the context and skip goroutine here. The management controller factory context is never canceled if Rancher is still running so that each time we start a usercluster controller, the goroutine leaks here. So we also need to check started state to avoid creating more goroutine leaks if the controller has started.

It set started state in Start() function but never set unstarted state for shutting down works when channel done. The controller may fail to start when we restart it.

Testing
Engineering Testing
Manual Testing

Deploy HA Rancher and set up Prometheus dashboard for controllers. Refer to: https://github.com/rancher/rancher/wiki/How-to-setup-prometheus-dashboard-for-controllers
Add an import cluster to Rancher and run the following scripts to test usercluster controller restart.

#!/bin/bash

# =============== Usage ===============
# ./test.sh <cluster-id> <limit-times> <interval>
# ./test.sh c-xxxx 100 3
# Need to running on the node which can access to Rancher local cluster(Need to running on the node which can access to Rancher local cluster).
# =======================================

clusterid=$1
limit=$2
interval=$3

n=1
while [ $n -le $limit ]
do
    cluster=$(kubectl get clusters.management.cattle.io $clusterid -o json)
    for k in $(jq '.status.conditions | keys | .[]' <<< $cluster); do
        value=$(jq ".status.conditions[$k]" <<< $cluster);
        type=$(jq -r '.type' <<< "$value");
        if [ $type == 'Provisioned' ]; then
            kubectl patch clusters.management.cattle.io $clusterid --type='json' -p='[{"op": "replace", "path": "'/status/conditions/$k/status'", "value":"False"}]'
            break
        fi
    done
    sleep $interval
    let n++
done

Get go_goroutines{job="rancher-metrics"} in Prometheus Graph page. Before fixing this issue(tested with v2.5.14), we can see the goroutine continued growth when we finish running the script.

Tested with fixed dev version, we can compare with the goroutine metrics that prove the goroutine leaks problem fixed.

:white_check_mark: PASSED
Reproduction Environment

Component
Version / Type

Rancher version
2.5.15

Installation option
helm

RKE binary version used
1.2.20

If Helm Chart k8s cluster
1.20.15

Cert Details
let's encrypt

Helm version
v2.16.8-rancher1

Downstream cluster type
rke1 amazon ec2

Downstream K8s version
v1.20.15

Logged in user role
administrator

Browser type
google chrome

Browser version
103.0.5060.134

ADDITIONAL SETUP

Helm commands for Rancher installation:

helm install rancher rancher-latest/rancher \
  --namespace cattle-system \
  --set hostname=$URL_VAR \
  --set replicas=3 \
  --set ingress.tls.source=letsEncrypt \
  --set letsEncrypt.email=$EMAIL_VAR \
  --set letsEncrypt.ingress.class=nginx \
  --version 2.5.15

Reproduction steps

Starting from the default homepage /g/clusters

Hover over Global ==> local ==> click System
Hover over Resources ==> click Workloads
Click the ellipsis (three dots) next to the rancher deployment under cattle-system ==> click Edit
Click Environment Variables ==> Add Variable
Key ==> CATTLE_PROMETHEUS_METRICS
Value ==> true (no quotes around true)
Click Save ==> wait for deployment to finish redeploying

Create a downstream rke1 amazon ec2 cluster
Run the following script in a shell that has exported the local cluster's kubeconfig file

#!/bin/bash

# =============== Usage ===============
# ./test.sh <cluster-id> <limit-times> <interval>
# ./test.sh c-xxxx 100 3
# Need to running on the node which can access to Rancher local cluster(Need to running on the node which can access to Rancher local cluster).
# =======================================

clusterid=$1
limit=$2
interval=$3

n=1
while [ $n -le $limit ]
do
    cluster=$(kubectl get clusters.management.cattle.io $clusterid -o json)
    for k in $(jq '.status.conditions | keys | .[]' <<< $cluster); do
        value=$(jq ".status.conditions[$k]" <<< $cluster);
        type=$(jq -r '.type' <<< "$value");
        if [ $type == 'Provisioned' ]; then
            kubectl patch clusters.management.cattle.io $clusterid --type='json' -p='[{"op": "replace", "path": "'/status/conditions/$k/status'", "value":"False"}]'
            break
        fi
    done
    sleep $interval
    let n++
done

Go to the /metrics endpoint once the script has started, check it throughout as well
Once the script ends check the amount of go routines compared to the start

Additional Info
RESULTS
:white_check_mark: Expected
Expected the go routines not to drastically increase
:x: Actual
The go routine amount increased substantially
Screenshots

Validation Environment

Component
Version / Type

Rancher version
v2.5-6f124d5b970d22ac815996021d0b1aba75da476d-head

Rancher commit link
https://github.com/rancher/rancher/commit/6f124d5b970d22ac815996021d0b1aba75da476d

Installation option
helm

RKE binary version used
1.2.20

If Helm Chart k8s cluster
v1.20.15

Cert Details
let's encrypt

Helm version
v2.16.8-rancher1

Downstream cluster type
rke1 amazon ec2

Downstream K8s version
v1.20.15

Logged in user role
administrator

Browser type
google chrome

Browser version
103.0.5060.134

ADDITIONAL SETUP

Helm commands for Rancher installation:

helm install rancher rancher-latest/rancher \
  --namespace cattle-system \
  --set hostname=$URL_VAR \
  --set replicas=3 \
  --set ingress.tls.source=letsEncrypt \
  --set letsEncrypt.email=$EMAIL_VAR \
  --set letsEncrypt.ingress.class=nginx \
  --set rancherImageTag=v2.5-head

Validation steps

Starting from the default homepage /g/clusters

Hover over Global ==> local ==> click System
Hover over Resources ==> click Workloads
Click the ellipsis (three dots) next to the rancher deployment under cattle-system ==> click Edit
Click Environment Variables ==> Add Variable
Key ==> CATTLE_PROMETHEUS_METRICS
Value ==> true (no quotes around true)
Click Save ==> wait for deployment to finish redeploying

Create a downstream rke1 amazon ec2 cluster
Run the following script in a shell that has exported the local cluster's kubeconfig file

#!/bin/bash

# =============== Usage ===============
# ./test.sh <cluster-id> <limit-times> <interval>
# ./test.sh c-xxxx 100 3
# Need to running on the node which can access to Rancher local cluster(Need to running on the node which can access to Rancher local cluster).
# =======================================

clusterid=$1
limit=$2
interval=$3

n=1
while [ $n -le $limit ]
do
    cluster=$(kubectl get clusters.management.cattle.io $clusterid -o json)
    for k in $(jq '.status.conditions | keys | .[]' <<< $cluster); do
        value=$(jq ".status.conditions[$k]" <<< $cluster);
        type=$(jq -r '.type' <<< "$value");
        if [ $type == 'Provisioned' ]; then
            kubectl patch clusters.management.cattle.io $clusterid --type='json' -p='[{"op": "replace", "path": "'/status/conditions/$k/status'", "value":"False"}]'
            break
        fi
    done
    sleep $interval
    let n++
done

Go to the /metrics endpoint once the script has started, check it throughout as well
Once the script ends check the amount of go routines compared to the start

Additional Info
RESULTS
:white_check_mark: Expected
No go routine increase
:white_check_mark:Actual
No go routine increase
Screenshots


Device information feature

Device information feature has been included to the end of issue description automatically
Sample application included to the project for fast usage.
Programmatically shake code has been added to the sample activity as comment line for those who are failed to shake emulator.
Minor version upgrade

@TayfunCesur Client Version olarak ifade edilen parametre app'in versiyonu değil mi? Bunu BuildConfig.VERSION_NAME'den alalım mı eğer öyleyse ?

Yes this is true. Client Version is BuildConfig.VERSION_NAME but as I know, we can't access the client's version from the library. Because each module has own BuildConfig. If we do this in the library, we will have library's version which is 1.0.6 :)


Add image to authenticated encryption silde for encryption module

This adds just this one image from wikipedia makes the slide less abstract.

I actually found the explanation in the slide too abstract and it was leaving it totally to the students' imagination to figure out how one is going to implement the AE. I think it is useful to show them at least one example of how AE could be implemented concretely. I chose EtM because GCM which is one of the most used mode in practice, is essentially EtM (You could verify authenticity of the GCM ciphertext without decrypting it).
I added an explanation for Key2 in the note. I think it is good to emphasizes the MAC is keyed. It is a point that is not clear from the slide.


Translations

German missing, some strings in Failed and Batch Resources are not translatable yet.

Translations are now handled here: https://hosted.weblate.org/projects/moox/jobs/


Kubectl outputs unecessary empty line

kubectl version 1.15.x
[root@iaasn00126855 out]# kubectl version
Client Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.3+vmware.1", GitCommit:"23e2c41321122d2e0c20eb0111a8abedfbf0fd41", GitTreeState:"clean", BuildDate:"2019-08-19T18:44:31Z", GoVersion:"go1.12.9", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.3+vmware.1", GitCommit:"23e2c41321122d2e0c20eb0111a8abedfbf0fd41", GitTreeState:"clean", BuildDate:"2019-08-19T18:42:30Z", GoVersion:"go1.12.9", Compiler:"gc", Platform:"linux/amd64"}

Kubectl throws extra line only when get all is performed.
[root@test out]# kubectl get all -n 103000-pra-dev
NAME               READY   STATUS    RESTARTS   AGE
pod/kaniko-mn785   1/1     Running   0          79s

[root@test out]#

/sig cli
/area kubectl
/kind bug
/priority P3

I'm able to reproduce this on 1.15.x (up to the recently released 1.15.6) but it appears fixed on 1.16.x.


Fix using numbers in copilot-indentation-alist

As mentioned in #252
Despite using emacs for almost 1.5 decades, my elisp still sucks so feel free to close this and fix it properly.
I've tested this still appears to work with both variable and number values in this alist.

Awesome! Thanks for fixing this. I will merge soon.


Blitz Finance

[x] I will not ping the Discord about this pull request.

Please provide the following information for your token.
Please include change to the src/tokens/solana.tokenlist.json file in the PR
At minimum each entry should have

Token Address: 7PE5UrRFqHXMmMXvnoMxfpnec9EYLeYiXU4B22c4nRP7
Token Name: BLITZ
Token Symbol: BTZ
Logo : https://cdn.jsdelivr.net/gh/Bllitz12/blitzfinance/logoblitz.jpg
Link to the official homepage of token:
Coingecko ID if available (https://www.coingecko.com/api/documentations/v3#/coins/get_coins__id_):

Please submit proper PR with only your changes.


UniversityAdmin - no session found to save

It does not recover the active session.

Solved by https://github.com/studyportals/UniversityAdmin/pull/1294/commits/81597bf81b03f165ca98efd2a00ada075f900120


Solve question 8

I believe this is correct. It agrees with Kevin's notes from the final exam review and solves the problem correctly for the inputs I've tried (I hardcoded in Kevin's test case for now). I also get the optimal O(n^2) running time by precomputing the subarray sums.
I've heavily commented it, because dynamic programming is funky.
This would close #6

I'll bring it in and :100:


Chore refactors

I abandoned the move of the compiled main.css file, since I can't make it compatible with both sass and vanilla css imports, we'll wait for the next major.
This introduces a change of arch by moving stuff around, doing minor es6 refactors, a nice readme, better DX with webpack, linting, named exports, coverage published on Coveralls, dedicated changelog file, and some more 😃
This it will be easier to review separate commits, I'll wait for this to rebase.

Changes Unknown when pulling<PHONE_NUMBER>5e0fd3d13087c20e9268284828e80a on dist into ** on master**.

Changes Unknown when pulling 6a8bc547e28172fc20456e938b0733019260ca55 on dist into ** on master**.

Changes Unknown when pulling 3fe01ee21cfab94f31a55a423e4613a22e7c05fc on dist into ** on master**.

Changes Unknown when pulling 6da4d9a07f2d9e17d1bee8003cfa858b33e948ee on dist into ** on master**.

Doesn't removal of the prepublish script mean that this library will no longer work with es5 projects?

@chrisirhc Hum what can cause it not to work with es5 projects? Sorry if I'm missing something

The prepublish script ensures that there the es6 code is transpiled into es5 (in dist/) so it can work with es5 projects. Unless you're using something else to ensure interoperability?

The name of the prepublish npm hook is a bit confusing since it make people think that it will only be run before the package is published, which is not the case since it's also executed upon install.
Removing it ensure that people installing this package using the --production flag will be able to use the library, since they won't be able to transpile the code, and improve install time. Imagine if every package did this rather than publishing builded files directly.
We only need to pay attention to build before publishing to avoid any mistake, but that's really the only con.

I don't think that's right. That prepublish running on install is only if you install the package through the git repository URL. If you install the package from npm (not a git URI), it doesn't run the prepublish script because it assumes the package from the npm repository is already in the published state.

See https://blog.greenkeeper.io/what-is-npm-s-prepublish-and-why-is-it-so-confusing-a948373e6be1

I think we we're looking for is the version script.

Thanks for making my 🌍  fall apart Chris, I was pretty certain it did and encountered the behavior a few times, must be my imagination.

👍 No problem 😄 . And this stuff may have changed in npm 4/5 anyways. I haven't read up on the latest developments.

Note that the current version of gh-pages is using the generated webpack bundles.
You only need to:
npm run docs

And it will build, checkout, commit, push and go back to master.

@Apercu if you intend to work on #208, you need to assign it to yourself to avoid duplication of work. It's currently assigned to @amilajack .

@chrisirhc Done.

Also, please update this PR's description. What's the main goal of this PR? Once it's done, let's leave it at that. This PR is growing extremely large. What's the absolute necessary changes vs nice to haves?

Changes Unknown when pulling dc79e1a3b96d3327b6c741eae5ce47f613ec90af on dist into ** on master**.

Changes Unknown when pulling 95c1e248706c1a143fdf685a937cb56141e07683 on dist into ** on master**.


Cython for building single python library from python module

Hello,
I have a project structure like this:
mainmodule/
    __init__.py
   module.py
   submodule1/
      __init__.py
      submodulefile1.py
...

Can I make one single library, which contains all code of my mainmodule by Cython?
Thank you!

See here:
https://github.com/cython/cython/tree/master/Demos/freeze
Note that this is a question, not a bug or feature request. It is better suited for the cython-users mailing list.


Use new .NET SDK

Switch to new .NET SDK  (partly used https://learn.microsoft.com/en-us/dotnet/core/porting/upgrade-assistant-overview but didn't work so well)
Switch to net472 (but didn't try the move to net8.0 that would probably require to update some dependencies)
Remove most libs in AutoEmbedLibs/ but kept ICSharpCode.AvalonEdit.dll as the version on NuGet was missing some symbols
Remove some Sentry and GDrive code
Remove the VSIX project as I was too lazy to try upgrading it

👋@Benualdo

I'll check it out tomorrow to see if the viewer compiles easily now. Thanks!

Sorry for the delay, I could build the tool without any issue thanks!
Now I'm gonna look if I can still update the lib to latest version with all the modifications on this branch.


Retry starting XCTest runner multiple times

Proposed Changes
Retry the starting the XCTest runner on connection error.
Testing
todo
Issues Fixed
During an launchApp command, xctest may not be able to run for a while because the simulator is not fully initialised (due to permissions being set). This causes errors in the CLI to be reported about XCTest runner. This fix will retry starting XCTest runner multiple times, making it far more likely that the simulator is fully initialised before an error is emitted.

@berikv is this a change we should go ahead with or is it not needed anymore?