[SR-2028] "return" in func returning void should not have an argument

Previous ID
SR-2028

Radar
None

Original Reporter
swifdy19%7 (JIRA User)

Type
Bug

Environment
Xcode 8.0 beta (8S128d), Swift 3

Additional Detail from JIRA

Votes
6

Component/s
Compiler

Labels
Bug, DiagnosticsQoI, Parser

Assignee
None

Priority
Medium

md5: 48aff532232ae357d7d9a61770f616ba

Issue Description:
func test()
{
    return   // Warning: Expression following 'return' is treated as an
                    // argument of the 'return'

    print("foo")      // should not print, but it does
}

This is the first time I encounter this behavior as well. Like "Flower (JIRA)", I was expecting to see the warning message "Code after return will never be executed".
I think simply a return in a line by itself should mean only one thing: Stop here, exit the scope, and never ever go to the next line.
I consider the behavior to be a bug.


Add Accept option to request node

This PR will add the possibility to set an Accept Option (see RFC 7252, section 5.10.4 to the request node. It is still WIP, so feedback and comments are highly appreciated!

Pull Request Test Coverage Report for Build 652296510

7 of 11 (63.64%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-3.3%) to 87.192%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

coap/coap-request.js
7
11
63.64%

Totals

Change from base Build 652074299:
-3.3%

Covered Lines:
122

Relevant Lines:
136

💛  - Coveralls

Meanwhile I think it is better to let the user set this option (as in the HTTP node) by the headers option in message objects which is why I will close this PR.


[CI] Docker Hub credential failure?

Current Behavior
Meshery build and release workflows are failing to run the Docker Extension build.
Desired Behavior
See https://github.com/meshery/meshery/runs/6697081647?check_suite_focus=true for an example.

Contributor Guides and Resources

🛠 Meshery Build & Release Strategy
📚 Instructions for contributing to documentation

Meshery documentation site and source

🎨 Wireframes and designs for Meshery UI in Figma
🙋🏾🙋🏼 Questions: Layer5 Discussion Forum and Layer5 Community Slack

I think the with in this line, should be changed to secrets.
Also, the secrets field and its corresponding value should reside under workflow_call instead of push event. https://github.com/meshery/meshery/blob/13a7d1f931489c092daddcd092b6f1a341071967/.github/workflows/build-and-release-dde.yml#L11
I am not sure how to test if I'm right or wrong.


Consume the reusable workflows from upbound/uptest@standard-runners

Description of your changes

Relevant PR: https://github.com/upbound/uptest/pull/184
This PR replaces the larger runners we are using for the:

e2e, publish-service-artifacts workflows
lint, publish-artifacts jobs
to the standard ubuntu-22.04 workflow runners. This will also allow us to check whether any CI jobs need larger runners in this repo.

Unfortunately, the e2e workflow (uptest) running on the standard runner cannot be tested with this PR. I'm planning to test the e2e workflow on a separate repository. We have switched to the family providers in uptest runs, so I hope there's no need for the larger runners for uptest runs. This also depends on the time given to the e2e workflow and the resource providers needed to run a test.
Another test we need to do is the publish-service-artifacts workflow that we use to build the family packages and push them to the Upbound package registry. Building and pushing a larger number of provider packages from a single job requires more resources on the runner. Another parameter affecting the compute resources we consume on the workflow runners is the package size and recently, we have reduced the resource provider package size considerably by removing the Terraform CLI and Terraform provider. Although we have control over how many provider packages will be processed per CI child action, increasing the child action count increases the load on the package registry, as these children are currently run in parallel. We could run these child actions sequentially if needed, at the expense of increased release build & push time. We would like to experiment on these parameters using the standard runners once this PR is merged.
Another job of interest is the local-deploy job as it builds and deploys the monolith on a kind cluster. The monolith is heavy on the CPU and the memory the API server process consumes. We will be able to test it with this PR.
Btw, the lint job is already failing on the larger Ubuntu-Jumbo-Runner workflow runner because currently it consumes ~40GB of memory. So it should fail with the smaller standard runners that we are switching to with this PR. We are working on this. This PR is for checking the rest of the CI jobs on the standard runners.
I have:

[x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

So, from the output of https://github.com/upbound/provider-aws/actions/runs/8084771313, the remaining unknowns are the publish-service-artifacts and the e2e workflows. We also need to work on the lint job, which cannot even fit on a Ubuntu-Jumbo-Runner runner as of now.

A relatively heavyweight uptest is running here, with 4 providers installed:

The AWS provider family config package
3 resource providers: provider-aws-{networkfirewall, ec2, s3}

An uptest run for the Cluster.eks example manifest also failed with a disk space error here:

Looks like running the jlumbroso/free-disk-space action in the beginning of the e2e workflow helps with the disk space issue. Please see the following uptest runs:

Firewall.networkfirewall -> https://github.com/ulucinar/upbound-provider-aws/actions/runs/8085639241/job/22093639643
Cluster.eks -> https://github.com/ulucinar/upbound-provider-aws/actions/runs/8085642042/job/22093648022

Looks like the jlumbroso/free-disk-space action also helped with the publish-artifacts job, which was previously failing without it:
https://github.com/ulucinar/upbound-provider-aws/actions/runs/8086192235/job/22095397427?pr=40


from six import integer_types (en masse)

http://six.readthedocs.io/#six.integer_types
long was dropped from Python 3 so in the PR we replace all copies of isinstance(x, (int, long)) with isinstance(x, integer_types) which will do the right thing on both Python 2 and Python 3.

@robertwb I have a hard time making sense of the Jenkins output.  What have I done wrong here?

Jenkins is quite java centric. For Python, you have to look at the console
output (on the right). Here it appears you have a lint error, run "tox -e
lint" locally to reproduce.
On Thu, Feb 1, 2018 at 3:05 PM, cclauss<EMAIL_ADDRESS>wrote:

@robertwb https://github.com/robertwb I have a hard time making sense
of the Jenkins output. What have I done wrong here?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/beam/pull/4571#issuecomment-362431861, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAdqgcMh_FNhRP23SSSU-s75GBzVFSPdks5tQkMqgaJpZM4R2TWc
.

Were you able to figure this out?

Please give me 24 hours.

It was... Running pylint for module apache_beam:
************* Module apache_beam.io.range_trackers_test
C:104, 0: Line too long (81/80) (line-too-long)

Jenkins: retest this please.

LGTM


Update loosely_coupled_architecture.md

Fixes issue #142
References used:

https://medium.com/@marciosete/loosely-coupled-architecture-6a2b06082316
https://searchapparchitecture.techtarget.com/tip/Can-a-loosely-coupled-architecture-reduce-technical-debt

Proposed changes for the style guide.
Current template:

Proposed change:

Since we are mostly following the latter one that's why updated the style guide.

Suggested changes has been done.


x/pkgsite: image in readme and privacy

If a readme includes images, they're showed directly on pkg.go.dev.
It could cause privacy/security issue:

the image could be used to track users (statistics/IP/etc...)
if the image is "malicious", and the web browser has a bug, it could crash it, or execute arbitrary code

We should probably have an image proxy (similar to what Github does).
I'm surprised nobody reported it already.
I haven't found any similar issue on the tracker.
Maybe I didn't search correctly.

Closing this as a duplicate of https://github.com/golang/go/issues/37128.

sorry for the duplicate, I couldn't find this other issue in my search.


📃: Sudoku solver web development project

:red_circle: Title : Sudoku Solver Web Development Project
:red_circle: Aim : To develop a web application that allows users to input a Sudoku puzzle and provides an instant solution using a backtracking algorithm.
:red_circle: Brief Explanation : This project involves creating a web-based Sudoku solver that enables users to enter a Sudoku puzzle and have it solved automatically. The web application will feature a user-friendly interface with a grid for puzzle input and a button to trigger the solution process. The core functionality will rely on a backtracking algorithm to find the solution. The app will be built using HTML, CSS, and JavaScript for the frontend
Screenshots 📷
NA

:white_check_mark: To be Mentioned while taking the issue :

Full name : Riya Rane
What is your participant role? GSSOC , HACTOBERFEST

Happy Contributing 🚀
All the best. Enjoy your open source journey ahead. 😎

Can you please assign me this project under Gssoc-ext 2024

Can you please assign me this project under Gssoc-ext 2024

You can raise another issue as this issue has already been assigned and completed.


不支持 Swift?

显示错误
Could not build Objective-C module 'KTVHTTPCache'

混编支持

In Swift I am getting Build Error
Could not build Objective-C module 'KTVHTTPCache'
Could you please suggest how to use in swift?


Poor IPsec performance on Kubernetes

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?

Kubernetes version 1.27.2 on KVM VMs with Open VSwitch-based virtual networking. Cilium 1.13.0 / 1.13.2 for cluster networkng. MTU is 65000 on the virtual NICs all the way down to the OVS bridge on the host.
3-node cluster with two workers. Each VM has 8 GiB of RAM, and 6 vcpu cores (3 vcpus x 2 cores). Cilium transparent encryption enabled using the following helm parameters:
encryption.type="ipsec"
encryption.enabled=true
encryption.ipsec.interface="eth0"
encryption.ipsec.keyFile="keys"
encryption.ipsec.mountPath="/etc/ipsec/keys"
encryption.ipsec.secretName="cilium-ipsec-keys"
Ran iperf3 server in a pod on one worker, and iperf3 client (single threaded) from a pod on the second worker to connect to the first. The following are the iperf3 command-line details.
iperf3 -s -p            # in server pod on worker1
iperf3 -c <server_pod_ip> -p  -t 60   # in client pod on worker2
When transparent encryption is not enabled, I see a throughput of around 2.7 Gbps. Once I enable transparent encryption, the throughput drops to 200 Mbps.

Cilium Version
1.13.0 / 1.13.2
Kernel Version
6.3.3 (CentOS Stream 9, kernel version 6.3.3-1.el7.elrepo.x86_64)
Kubernetes Version
1.27.2
Sysdump
cilium-sysdump-20230705-141625.zip
Relevant log output
No response
Anything else?
Here are individual flame graphs of the client and server side CPUs.
Client flame graphs

Server flame graphs

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Taking a look, there are two things that stand out:

All the graphs except two show idle CPU time as the majority. This is expected for IPSec. It is difficult to saturate more than one CPU with IPSec traffic, as the kernel's RSS mechanism will tunnel all traffic onto a single core (at least on the receiving side).
Large stacks starting with tcf_classify, with the majority of the stack taken up by bpf_skb_event_output. Looks like there are a couple of different programs which are sending lots of data in the perf ring buffer up to userspace, which is taking up a lot of CPU. I dug around and there are two areas where we send trace events on every IPSec packet (in your environment).

cil_from_overlay -> send_trace_notify
tail_handle_ipv4 -> handle_ipv4 -> send_trace_notify (called in handle_ipv4 here

I'll dig into this more as time is available and talk with some other folks to gather more information about what is going on here.

Nice investigation @learnitall!
I believe we should switch TRACE_PAYLOAD_LEN to 0 in https://github.com/cilium/cilium/blob/755eae8377fc4c353337af31be5d502c333b9f3c/bpf/bpf_overlay.c#L410-L412
according to https://github.com/cilium/cilium/blob/755eae8377fc4c353337af31be5d502c333b9f3c/bpf/lib/trace.h#L172-L178
It's probably not the only place where we incorrectly set TRACE_PAYLOAD_LEN.

Oh, nice! I didn't expect it would make a big difference.

I went through and found two other places where I think this change is appropriate and then finished up some testing today. I will post more details tomorrow with a PR, but here is a quick before/after on a netperf TCP stream test on Cilium 1.14:
Before:
(Each row is a separate netperf client)
Throughput,Throughput Units,Elapsed Time (sec)
464.06,10^6bits/s,180.04
461.25,10^6bits/s,180.02
441.73,10^6bits/s,180.00
482.26,10^6bits/s,180.04

Server Node:

Client Node:

After:
Throughput,Throughput Units,Elapsed Time (sec)
698.48,10^6bits/s,180.03
643.81,10^6bits/s,180.05
780.22,10^6bits/s,180.05
552.11,10^6bits/s,180.03

Server node:

Client node:

Averaging these runs and comparing the two, there's a 45% increase in throughput with the change.
Patch:
diff --git a/bpf/bpf_overlay.c b/bpf/bpf_overlay.c
index f7a1880ea8..566b79e8e8 100644
--- a/bpf/bpf_overlay.c
+++ b/bpf/bpf_overlay.c
@@ -123,8 +123,7 @@ static __always_inline int handle_ipv6(struct __ctx_buff *ctx,
                ctx_change_type(ctx, PACKET_HOST);

                send_trace_notify(ctx, TRACE_TO_STACK, *identity, 0, 0,
-                                 ctx->ingress_ifindex, TRACE_REASON_ENCRYPTED,
-                                 TRACE_PAYLOAD_LEN);
+                                 ctx->ingress_ifindex, TRACE_REASON_ENCRYPTED, 0);

                return CTX_ACT_OK;
        }
@@ -408,8 +407,7 @@ skip_vtep:
                ctx_change_type(ctx, PACKET_HOST);

                send_trace_notify(ctx, TRACE_TO_STACK, *identity, 0, 0,
-                                 ctx->ingress_ifindex, TRACE_REASON_ENCRYPTED,
-                                 TRACE_PAYLOAD_LEN);
+                                 ctx->ingress_ifindex, TRACE_REASON_ENCRYPTED, 0);

                return CTX_ACT_OK;
        }
@@ -588,8 +586,7 @@ int cil_from_overlay(struct __ctx_buff *ctx)
 #ifdef ENABLE_IPSEC
        if (is_esp(ctx, proto))
                send_trace_notify(ctx, TRACE_FROM_OVERLAY, 0, 0, 0,
-                                 ctx->ingress_ifindex, TRACE_REASON_ENCRYPTED,
-                                 TRACE_PAYLOAD_LEN);
+                                 ctx->ingress_ifindex, TRACE_REASON_ENCRYPTED, 0);
        else
 #endif
        {

@learnitall Thanks for fixing this! Is there any way we can install the latest commits using Helm/CLI?

@learnitall preliminary findings with the latest commit suggest that there is a definite improvement in throughput. The drop in throughput is no longer as precipitous - I see a 70% drop in throughput with IPsec on, as opposed to 92.5% earlier. I don't know what percentage drop should be considered par. Will report more findings as we have it. cc: @tejas-sangol

That's great @amukherj, glad to hear there is a bit of an improvement. @tejas-sangol the commit was released as part of 1.14.1 last week

@amukherj If you have updated flamegraphs, we can take a look to see if there are any other low-hanging fruits. That said, this is likely the consequence of the RSS limitation (last limitation at https://docs.cilium.io/en/stable/security/network/encryption-ipsec/#limitations). Removing that RSS limitation is a larger work item which hasn't been prioritized so far.


[BUG] JWT logout has no matching route

What is the bug?
When you login with a JWT using a request header or a query parameter, the token is stored in the authentication cookie.
Hence, there is a logout mechanism for JWT as sell. However, when you click the logout button, the resulting AJAX request returns a 404 because the logout route does not exist.
How can one reproduce the bug?
Steps to reproduce the behavior:

Login with a JWT.
Click Logout
Check the network requests for a 404
Nothing happens on the screen

What is the expected behavior?
The user should be logged out and depending on JWT config settings see a non authenticated state.
What is your host/environment?

OS: MacOS
Version: 2.11
Plugins: Only security

Do you have any additional context?
I believe this is just a faulty route path definition in JWT's routes: https://github.com/opensearch-project/security-dashboards-plugin/blob/main/server/auth/types/jwt/routes.ts#L29
That path does not correspond to the url used by the logout component.

[Triage] Hi @jochen-kressin, thank you for filing this issue. This seems like a good change that would improve the state of things. We can mark this as triaged.


Selecting char and then clicking off causes crash

When I select the "character" and then click off of it without correctly using an action, the API appears to crash.
Reproduction Steps:

Click character
Click elsewhere - a different tile, etc.

Results in urban-memory Docker container exiting, requires a manual restart of container.
Results in this Docker error:
parseCharacter
cacheCharacter {
  operator: { name: 'bob', operatorId: 'affe525a-1140-4c13-bfd1-d22d1970d31a' },
  class: {
    name: Translatable { translations: [Object] },
    ap: 2,
    maxAp: 6,
    initiativeModifier: NaN
getOperator is deprecated, should look up by operator uuid instead of socket id
TypeError: Cannot read properties of undefined (reading 'game')
    at /app/src/websocket/game/events/tile_interaction.ts:18:27
    at step (/app/src/websocket/game/events/tile_interaction.ts:33:23)
    at Object.next (/app/src/websocket/game/events/tile_interaction.ts:14:53)
    at fulfilled (/app/src/websocket/game/events/tile_interaction.ts:5:58)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
error Command failed with exit code 1.

It seems like just re-clicking the avatar again also causes a crash. oopsie


Short solution needed: "Redis connect example" (lua-redis)

Please help us write most modern and shortest code solution for this issue:
Redis connect example (technology: lua-redis)
Fast way
Just write the code solution in the comments.
Prefered way

Create pull request with a new code file inside inbox folder.
Don't forget to use comments to make solution explained.
Link to this issue in comments of pull request.

Redis connect example


Enhance gemma2 Layer Normalization Functionality

Description

Enhanced the fast_rms_layernorm_gemma2_compiled function by adding a torch.compile decorator for improved performance.
Added detailed comments to clarify the implementation and future considerations.

Changes walkthrough 📝
Relevant filesEnhancement

gemma2.pyEnhance fast_rms_layernorm_gemma2_compiled with torch.compile

unsloth/models/gemma2.py
Added a new implementation of fast_rms_layernorm_gemma2_compiled function.  Introduced torch.compile decorator for optimization.  Included comments regarding the use of torch.compile.

+13/-0

/add_docs

/add_docs

/ask what is the PR about?

/help


Add e2e tests for listing resources

Description
This PR adds e2e tests for listing resources and makes changes for simulator to use dualzone config in github actions workflow.
Recreating PR #8281 including fix from PR #8392.

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[x] Cleanup (Code refactoring and cleanup, that may add test cases)
[ ] build/CI

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

How did you try to break this feature and the system with this change?

@blueorangutan package

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el7 ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 8156

@blueorangutan test matrix

@vishesh92 a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

[SF] Trillian test result (tid-8690)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42844 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8410-t8690-xenserver-71.zip
Smoke tests completed. 127 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_05_list_volumes_isrecursive
Failure
0.03
test_list_volumes.py

test_07_list_volumes_listall
Failure
0.03
test_list_volumes.py

[SF] Trillian test result (tid-8691)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 51160 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8410-t8691-vmware-67u3.zip
Smoke tests completed. 127 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_02_balanced_drs_algorithm
Error
417.07
test_cluster_drs.py

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el7 ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 8185

@blueorangutan test matrix

[SF] Trillian test result (tid-8715)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42534 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8410-t8715-kvm-centos7.zip
Smoke tests completed. 128 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

[SF] Trillian test result (tid-8713)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44772 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8410-t8713-xenserver-71.zip
Smoke tests completed. 128 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

the vmware version:
Smoke tests completed. 127 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_02_balanced_drs_algorithm
Failure
125.08
test_cluster_drs.py

@blueorangutan package

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el7 ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 8541

@blueorangutan test matrix

@DaanHoogland a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

[SF] Trillian test result (tid-9098)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42437 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8410-t9098-xenserver-71.zip
Smoke tests completed. 129 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

[SF] Trillian test result (tid-9100)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42975 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8410-t9100-kvm-centos7.zip
Smoke tests completed. 129 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

[SF] Trillian test result (tid-9099)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 51455 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8410-t9099-vmware-67u3.zip
Smoke tests completed. 129 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File


 Just changing it to std::string fixed the problem.

I'd like to tackle this next week.

As pointed out by @jasssonpet, the underlying issue is that SymbolLoader does not resolve module names to framework bundles correctly, leading to searching for a data or function symbol in the wrong bundle. Our class resolution logic has somewhat subverted this issue, because we resolve classes through the Objective-C runtime which looks into all bundles, ambient and explicit alike.
Currently this means that any function or extern data symbol exported from a framework has a chance of not being resolved at runtime.


Android client possible?

I like this project for its simplicity/minimalism and think a android client would be kinda neat.
Even though I don't really want to get back into android development, this could be something I might actually tackle.
Before doing so I thought I'd ask if there are any major concerns from your side.
I do know python quite well and think that re-implementing the client logic in java/kotlin shouldn't be to hard (I say that without having read the code yet).
The only immediate concern I have is the whole NTP thing.
On android there's no "easy" way of changing the NTP server in use.
Apparently it can be done through adb but that's not really user-friendly.
Do you think it would be possible to extend wavesync in such a manner that clients´:

request the time from the server
given the server-time, request-time and local-time calculate an offset
using the offset to reconstruct the chunks

I've never worked on anything which requires perfect synchronization so I'm not sure if there's a fatal flaw in my logic.

First thing: Would you like to stream audio from the mobile to the wavesync (to get multiroom audio controlled conveniently from mobile) - or receive the audio on the mobile and play it.
I would seriously LOVE the ability to stream from my mobile - I currently use a bluetooth dongle, capture it's output and synchronise audio using rpis - hacky. Bluetooth dongle is simpler to use for my family than mobile-controlled sound daemons - which can hook up to spotify or play local collection.
I don't have a usecase for streaming TO THE android really - but can imagine it might be useful.  Both cases have different problems. ;-)
Android as a source
NTP is not problem in this case at all. System adds a delay to have enough time to synchronise audio in a laggy network. Mobile connected to any NTP should be accurate to within +/- 50ms without problems - probably better. System uses higher delay (200ms, or 1 second) - and this could be increased and work with mobile accuracy of even +/- 1s.
The problem might be with intercepting the audio stream on a non-rooted Android device - but that might have got better since I've checked it. "HiFy" app for example (not really popular) is supposed to connect spotify (not sure why explicitly that) to AirPlay. There's a "AirAudio" app - but requires root.
If accepting "root" requirement - this is certainly doable. If not - it needs some checks. It would still be usable for me with required root. It's certainly doable as a music "player" but I'm not sure you'd want to write own player; that would rather be counterproductive, it has to be simple and integrate with the environment.
I considered porting this to "termux" and staying with Python too, but there's problem with interception and audio at all.
Android could talk directly to receivers (be a wavesync server) or talk to the server (which currently talks to Pulseaudio using Unix socket - this could be changed easily) - and let the server chunk the audio.
Android as a player / receiver
The receivers need to have the time synchronised much more accurately. In local environment you could probably force NTP packets leaving on port 123 to reach your server instead. Still I believe most mobiles are synchronized to within 1-5ms and this should suffice in most natural conditions.
No problems with intercepting audio though - not sure if no problems with output buffer control.
Android control
I considered adding REST interface to wavesync server and doing a simple app to control volume in different rooms. My volume knob in kitchen is quite unreachable. I manage with SSH, my wife not really.

When receiving, the working root solution, could be to use AirAudio, do a DLNA server on pulseaudio and push audio to wavesync...
When streaming TO the android: Receivers currently receive the server time automatically every 1-second in status frame - in local network this MIGHT be just enough (pings will be usually <1ms anyway). Adding a time-ping feature is not a big problem probably, but maybe not necessary. Server currently doesn't receive data from receivers.

Thanks for the big write-up, really appreciated :)
Also, sorry for not being super clear about it but yeah, I was thinking *Android as a player / receiver".
My use-case is:
I have a baller HTPC setup in the living-room and a android tablet in the bathroom.
As my HTPC is running all the time (and playing music), I'd love to just hit a button on the tablet and have the music playing in the bathroom as well.
The app could also include a simple control interface, that shouldn't be to big of a deal especially if you provide a nice REST interface.
As you aren't to concerned about NTP and seem to not have any other immediate concerns for a receiver I guess this will be a upcoming project of mine unless someone else wants to work on it.
I have very limited private time so it's not like I have to work on this :sweat_smile:
As such I can't promise to have something to show off anytime soon.
Just wanted to get an initial idea on how things might be looking :)

No prob at all. Glad you found it somehow useful. I won't be able to pickup a Android project by myself but can offer any help necessary.
Weird solutions include also https://github.com/termux/play-audio and https://steemit.com/utopian-io/@rufans/how-to-play-mp3-files-from-command-line-with-termux
If mpv can do it - so could wavesync in a console with audio interface changed.


[Icon Request]: Vue Composables

Housekeeping

[X] I'm sure this issue is not a duplicate

Icon Type

[ ] File Icon
[X] Folder Icon

Icon Type

[X] Extension
[ ] Filename
[ ] Language ID

Original Icon
I don't have an icon yet.
Icon Information
Similar idea to encapsulate logic for Vue inspired by React Hooks.
Important: Vue Composables and React hooks have a similar purpose/origin but are conceptionally different from each other. So it would be wrong to use the same icon, as Vue Composables are not per se "hooks".
https://vuejs.org/guide/reusability/composables.html
More Information:
No response

How do we know that they are composables? are they a specific extension? what's the extension?

I thought maybe just set an icon for a folder named 'composables'

ohhh, okay. can you rename the title to be more clear then? IE: [Icon Request] Composables Folder?


Payload indicators only available if email content added

When configuring the training landing page in a simulation with the option "Create your own landing page" it is necessary to add the Dynamic tag
"Insert email content" before the "Payload Indicators" checkbox can be activated (it is greyed out otherwise).
Documentation is only stating that depending on the selection of the "select technique" wizard page this option is available, but not that the Dynamic tag must be added as well.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c312fd69-72cd-bc86-4fe1-993b60b97bc6
Version Independent ID: b7887ba6-4775-39f0-e368-68f140ce233d
Content: Simulate a phishing attack with Attack simulation training - Office 365
Content Source: microsoft-365/security/office-365-security/attack-simulation-training.md
Product: m365-security
Technology: mdo
GitHub Login: @chrisda
Microsoft Alias: chrisda

@chkockle, confirmed and fixed.
Thanks for the feedback.
Closing


Base rate update watcher

resolves #341

Lets make sure the netlify build succeeds before starting a review @devpanther

Lets make sure the netlify build succeeds before starting a review @devpanther

That was automatic, did not start one and besides the netlify error is not from my changes

That was automatic, did not request and besides the netlify error is not from my changes

That is my fault because I updated https://github.com/ubiquity/ubiquibot/blob/development/.github/CODEOWNERS which apparently automatically requests reviews, even on drafts. Perhaps there is a way to disable that, or, we will need to remove this feature entirely.
I hope that somebody else can handle this research because I'm underwater on some other matters for the rest of the week.

From the docs:
Code owners are not automatically requested to review draft pull requests

What happened:

@devpanther opened a ready to review PR
I converted the PR to draft as not ready

TLDR; @devpanther pls for future PRs open a draft PR first

Ready for review @0xcodercrane @rndquu

@0xcodercrane requests resolved

Mistakenly closed with comment

overall looks good to me. waiting for @pavlovcik 's input.

Unfortunately this is a huge pull request and I am unable to test it. I perused through and everything checks out but I do not fully understand all of the changes. I delegate my review to @0xcodercrane

@0xcodercrane check the comments and merge this in if everything checks out for you.

All reviews resolved @0xcodercrane


Add What Every Programmer Should Know About Memory

What Every Programmer Should Know About Memory is a modern classic. The paper explains in a really simple and interesting way how memory works and how a programmes should go about using memory.

Thank you for contributing!
I'd ask you to change the icon to 📜 (scroll)

I'll fix that, and make the merge prettier for the git log.

Thank you for taking extra time to make it prettier, I appreciate that!
Next time I'll be more optimistic with merging, sorry for the hustle.


Update Payment_Request.py

I suggest changing it to a generalized format and then you can provide an example yml and xlsx files so people can run it as well

I like the idea but how would I keep my code running on my PC if it doesn't have a path specific to my files?  Would I have two copes of the code?  One for Github and one for myself?


refactor binary search tree using reflection

@erneman1 please add task number to the PR title, as we usually do.


嵌套在CustomScrollView使用抛出异常

RT: 我在CustomScrollView中的嵌套使用，在自动滚动的过程中会抛出如下异常:
flutter: Another exception was thrown: ScrollController not attached to any scroll views.

我在listview里面嵌套也是这个错

不知道你的实际情况，说一下我的解决方案：如果是从网络请求的数据，请加上if...else...判断，在数据回来之前return一个Container

Widget _widgetPlanList() {
final controller = new SwiperController();
return Swiper(
controller: controller,
// index: _swiperIndex,
itemBuilder: _swiperBuilder,
itemCount: menuList.length,
itemWidth: ScreenUtil().setHeight(750),
itemHeight: ScreenUtil().setHeight(1040),
scrollDirection: Axis.horizontal,
onTap: (index) {
print('onTap点击了第$index个');
},
onIndexChanged: (int i) {
setState(() {
_activeIndex = i;
});
print('onIndexChanged点击了第$i个');
});
}
没有注释index:_swiperIndex前，我也是报一样的错误，注释掉就好了
跳转到指定索引：controller.move(index);

@zhaowenxin 我压根没有使用这个属性...

遇到了这个问题，求结局方案

@MayIGetKepler 解决方案就是放弃这个repo，作者根本不关心issue

@MayIGetKepler 解决方案就是放弃这个repo，作者根本不关心issue

有什么好的推荐吗

同样问题在这里
Performing hot restart...
Syncing files to device Redmi Note 7...
Restarted application in 1,793ms.
I/flutter (15332): 调用了API=http://test.app.cmp520.com:8118/api/public/getadverts
I/flutter (15332): ══╡ EXCEPTION CAUGHT BY WIDGETS LIBRARY ╞═══════════════════════════════════════════════════════════
I/flutter (15332): The following assertion was thrown building NotificationListener:
I/flutter (15332): ScrollController not attached to any scroll views.
I/flutter (15332): 'package:flutter/src/widgets/scroll_controller.dart': Failed assertion: line 110 pos 12:
I/flutter (15332): '_positions.isNotEmpty'
I/flutter (15332):
I/flutter (15332): Either the assertion indicates an error in the framework itself, or we should provide substantially
I/flutter (15332): more information in this error message to help you determine and fix the underlying cause.
I/flutter (15332): In either case, please report this assertion by filing a bug on GitHub:
I/flutter (15332):   https://github.com/flutter/flutter/issues/new?template=BUG.md
I/flutter (15332):
I/flutter (15332): When the exception was thrown, this was the stack:
I/flutter (15332): #2      ScrollController.position (package:flutter/src/widgets/scroll_controller.dart:110:12)
I/flutter (15332): #3      PageController.animateToPage (package:flutter/src/widgets/page_view.dart:120:41)
I/flutter (15332): #4      _TransformerPageViewState.didUpdateWidget (package:transformer_page_view/transformer_page_view.dart:527:25)
I/flutter (15332): #5      StatefulElement.update (package:flutter/src/widgets/framework.dart:3879:58)
I/flutter (15332): #6      Element.updateChild (package:flutter/src/widgets/framework.dart:2753:15)
I/flutter (15332): #7      ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3750:16)
I/flutter (15332): #8      Element.rebuild (package:flutter/src/widgets/framework.dart:3565:5)
I/flutter (15332): #9      StatelessElement.update (package:flutter/src/widgets/framework.dart:3796:5)
I/flutter (15332): #10     Element.updateChild (package:flutter/src/widgets/framework.dart:2753:15)
I/flutter (15332): #11     RenderObjectElement.updateChildren (package:flutter/src/widgets/framework.dart:4601:32)
I/flutter (15332): #12     MultiChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4992:17)
I/flutter (15332): #13     Element.updateChild (package:flutter/src/widgets/framework.dart:2753:15)
I/flutter (15332): #14     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3750:16)
I/flutter (15332): #15     Element.rebuild (package:flutter/src/widgets/framework.dart:3565:5)
I/flutter (15332): #16     StatefulElement.update (package:flutter/src/widgets/framework.dart:3894:5)
I/flutter (15332): #17     Element.updateChild (package:flutter/src/widgets/framework.dart:2753:15)
I/flutter (15332): #18     SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4883:14)
I/flutter (15332): #19     Element.updateChild (package:flutter/src/widgets/framework.dart:2753:15)
I/flutter (15332): #20     SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4883:14)
I/flutter (15332): #21     Element.updateChild (package:flutter/src/widgets/framework.dart:2753:15)
I/flutter (15332): #22     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3750:16)
I/flutter (15332): #23     Element.rebuild (package:flutter/src/widgets/framework.dart:3565:5)
I/flutter (15332): #24     StatelessElement.update (package:flutter/src/widgets/framework.dart:3796:5)
I/flutter (15332): #25     Element.updateChild (package:flutter/src/widgets/framework.dart:2753:15)
I/flutter (15332): #26     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3750:16)
I/flutter (15332): #27     Element.rebuild (package:flutter/src/widgets/framework.dart:3565:5)
I/flutter (15332): #28     BuildOwner.buildScope (package:flutter/src/widgets/framework.dart:2278:33)
I/flutter (15332): #29     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding&PaintingBinding&SemanticsBinding&RendererBinding&WidgetsBinding.drawFrame (package:flutter/src/widgets/binding.dart:700:20)
I/flutter (15332): #30     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding&PaintingBinding&SemanticsBinding&RendererBinding._handlePersistentFrameCallback (package:flutter/src/rendering/binding.dart:286:5)
I/flutter (15332): #31     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:1012:15)
I/flutter (15332): #32     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:952:9)
I/flutter (15332): #33     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding._handleDrawFrame (package:flutter/src/scheduler/binding.dart:864:5)
I/flutter (15332): #37     _invoke (dart:ui/hooks.dart:219:10)
I/flutter (15332): #38     _drawFrame (dart:ui/hooks.dart:178:3)
I/flutter (15332): (elided 5 frames from class _AssertionError and package dart:async)
I/flutter (15332): ════════════════════════════════════════════════════════════════════════════════════════════════════
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.
I/flutter (15332): Another exception was thrown: ScrollController not attached to any scroll views.

@chenxianqi  同样的问题，请问解决了吗

还没解决吗

I found the solution!!
Your Swiper must be wrap with StreamBuilder or something that rebuild more than once Swiper.
In my case,
`StreamBuilder(
stream: slides,
initialData: [],
builder: (context, AsyncSnapshot snap) {
List slideList = snap.data.toList();
            return slideList.isNotEmpty
                ? Swiper(
                    itemBuilder: (BuildContext context, int index) {
                      return Image.network(
                        slideList[index]['image'],
                        fit: BoxFit.fill,
                      );
                    },`

Check the slideList not empty.

If you want to use Swiper in other ScrollView ( like ListView ), consider boxing it  using Container OR other Widget that could offer the certain size.
Container(
      constraints: BoxConstraints(maxHeight: 200, maxWidth: 200),
      child: Swiper()
)

The reason is described at Unbounded constraints.

不知道你的实际情况，说一下我的解决方案：如果是从网络请求的数据，请加上if...else...判断，在数据回来之前return一个Container @CrazyCoderShi @xuwankang

多谢，你的回答解决了我的问题

我是嵌套到ListView里面使用
      height: 154.0,
      child: Swiper()```
 我使用Container固定高度解决了这个问题

If you want to use Swiper in other ScrollView ( like ListView ), consider boxing it using Container OR other Widget that could offer the certain size.
Container(
      constraints: BoxConstraints(maxHeight: 200, maxWidth: 200),
      child: Swiper()
)

The reason is described at Unbounded constraints.

I have this issue and i realized tha with a heighted Containter it works, but y have a Swipe whith variable heights, do you know to deal with that dinamic height?


Getting Syntax error while Training

Hi,
I was running this on the LJSpeech-1.1 dataset,  preprocessing part ran smoothly. (with default hparams).
while training I'm getting this error
Traceback (most recent call last):
File "train.py", line 9, in
from tacotron.synthesize import tacotron_synthesize
File "/mnt/Tacotron-2/tacotron/synthesize.py", line 10, in
from tacotron.synthesizer import Synthesizer
File "/mnt/Tacotron-2/tacotron/synthesizer.py", line 12, in
from tacotron.models import create_model
File "/mnt/Tacotron-2/tacotron/models/init.py", line 1, in
from .tacotron import Tacotron
File "/mnt/Tacotron-2/tacotron/models/tacotron.py", line 194
log('  Tacotron Parameters       {:.3f} Million.'.format(np.sum([np.prod(v.get_shape().as_list()) for v in self.all_vars]) / 1_000_000))
^
SyntaxError: invalid syntax
any help would be appreciated!
Thanks!!!

I got the same problem.
Did you find a solution?

I do not use new version of Tacotron, but I think he is try to devide np.sum() by 1000000. but he wrote 1000000 as 1_000_000. Change this to number format, or just delete that line.

Thanks, easy as that! After deleting it in the Tacotron model you have to do the same for the Wavenet model


Trait page not loading reliably in search UI

This page is not loading reliably in the UI: https://www.ebi.ac.uk/gwas/efotraits/EFO_0004725
It will load one or other of the tabs but not all of them (e.g.e studies but not associations). After refreshing, sometimes a different tab is successful.

@sprintell says: Its the Solr API failing periodically.  This is one of the endpoints that page is calling : https://www.ebi.ac.uk/gwas/api/v2/efotraits/EFO_0004725/studies?includeChildTraits=true&includeBgTraits=false&size=5&page=0&_=1689763984159
also: https://www.ebi.ac.uk/gwas/efotraits/EFO_0803533

Now seems like it is always failing

@ala-ebi should please update this ticket on what was fixed, it seems its working now

Now not working again

https://www.ebi.ac.uk/gwas/efotraits/EFO_0803533
this term also isnt loading correctly

A user reporting this page was giving an error, but seems to work now: https://www.ebi.ac.uk/gwas/efotraits/EFO_0005741

EFO_0004725 is now loading  made Solr config changes in order to fix the issue, for 'EFO_0803533' & ' MONDO_0005351' we are getting error from OLS while trying to retreive child traits @ljwh2 should we follow up with OLS team w.r.t same

Resolved by changing to OLS4

@sajo-ebi will check and ensure its properly deployed.

fix deployed in Prod


Lost text of last message after use the lens.

Lost text of last message after use the lens (long tap on textView in inputToolBar) in chat. Bug with small messages (text).
It's demo project, downloaded from repo 01.02.
Lib version: 7.2.0
iOS version: 9.2.1
Device: iPhone 5

Any ideas? I can provide movie with this bug, if you want.

Same happen to me

Any moving?

@OrWest Can you provide more info? I can't replicate the issue. Thx! 😄

@OrWest - I'm going to close this for now since we can reproduce it.
If you have anymore information, please update here and we can re-open. If you can setup steps to reproduce in our demo project, that would be most helpful. Thanks! 😄

I think this bug relates to textField. So in actual iOS version this bug doesn't reproducible already.


Literal type usage

The Literal type was introduced with PEP 586 in Python 3.8 and can be used with Pydantic. With typing-extensions the Literal type can also be used in Python 3.6+.
Would it be ok to introduce Literal?

Hi, I just checked out PEP-586, can you tell me where you plan to introduce it?
Thank you.

Here: https://github.com/StellarCN/stellar-model/blob/main/stellar_model/model/horizon/operations.py#L133-L134
asset_type: Literal["native", "credit_alphanum4", "credit_alphanum12"]
type: Literal["payment"]
type_i: Literal[1]

I'm uncertain why type and type_i are not part of the model, but at least for asset_type it makes sense.

I think using Enum is a better choice here.
from pydantic import BaseModel

class AssetType(Enum):
    native = "native"
    credit_alphanum4 = "credit_alphanum4"
    credit_alphanum12 = "credit_alphanum12"

class DemoOp(BaseModel):
    asset_type: AssetType

demo_op = DemoOp.parse_obj({'asset_type': 'credit_alphanum4'})
assert demo_op.asset_type == AssetType.credit_alphanum4
# If we use Literal here, the user still has to compare strings here
# assert demo_op.asset_type == 'credit_alphanum4'


TypeError: MTProto is not a function

just installed both required modules at their latest version and ran the script.

fixed this by modifying the first line from:
const MTProto = require('telegram-mtproto')
to:
const MTProto = require('telegram-mtproto').MTProto
which is weird because the module exports that function by default...

it's not weird
Close this issue, please

When your examples throw errors there is an issue. Please update them first

@ThatBrianDude rtfm

My bad, I must have removed the { } without noticing because I copy pasted the example from here:
https://github.com/zerobias/telegram-mtproto/blob/master/examples/node-storage.js
Not sure what happened there, I apologize


[tool] ⚡ Install the corresponding APK in flutter run

Fix #111585. The PR makes the tool installs exactly the generated APK file, which corrects the console's output too. Also, SHA1 will be generated for all generated APKs in the batch.
Filename comparison (DEBUG Mode)

Install APK file
Before
After

No flavor
app.apk
app-debug.apk

Flavor configured
app.apk
app-flavor-debug.apk

Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

I'm not sure if any external tools are using app.apk in their usages, that's the only thing I'm concerning.

It's likely that there are tools depending on the app.apk copy. It may be reasonable for backwards compatibility to continue copying the first apk and deprecate the usage of the copy. We can add a TODO and phase it out later.

https://github.com/flutter/flutter/pull/112768/checks?check_run_id=8940587074 The failure doesn't seem to be related.

It may be reasonable for backwards compatibility to continue copying the first apk and deprecate the usage of the copy.

It's unclear how to deprecate a usage like this. The tool itself is not using the file at present, and other tools won't access the file through flutter_tools, so we can't raise a deprecate message for it.

This PR has been reverted because is blocking the tree. \cc @christopherfujino @AlexV525

@christopherfujino @gspencergoog Could you help me with dumping the tests log? I can't access to the tree's dashboard due to my network issues currently, or maybe a tracking issue. Thanks!

@christopherfujino @gspencergoog Could you help me with dumping the tests log? I can't access to the tree's dashboard due to my network issues currently, or maybe a tracking issue. Thanks!

I will open a tracking issue and link from here


styleActiveLine breaks Android

With styleActiveLine set to true, on Android's Chrome, CodeMirror's gains a strange editing behavior: typing a character on any line inserts that character where intended, but also inserts a blank line immediately before this line.

none of my sites r showing up for Android but for computer

This is probably related to #4194

I had the same problem. The only way I could fix it is to use cm.setOption("inputStyle", "textarea"). Unfortunately this breaks other things (like selection). My current solution is to use the input style option and a custom keyboard with arrow keys and the other special keys.

styleActiveLine has definitely improved on Android!  However, it still fails in this case: if I go to the end of a line (except the first?), and type a character, then the character gets inserted where it should, but the cursor also gets moved to the next line (so if you kept typing, it goes on the next line).  This seems to be some kind of "temporary" issue, though, because repeating the process, or trying it on a different line, doesn't reproduce the error; I need to reload to get it to happen again.
This behavior seems localized to styleActiveLine, because it doesn't happen with e.g. demo/marker.html.

I spent a while trying to reproduce this (with Chrome Android), but it never happened for me. Which line did you put the cursor on, and what did you type?

Given your failure to reproduce, I investigated further.  Looks like this behavior is localized to the SwiftKey keyboard entry.  (Both Samsung keyboard and Hacker's Keyboard didn't have this behavior.)  Not sure how to figure out what keystrokes SwiftKey is actually sending when typing a single character...
Here are screenshots when, with SwiftKey, I click on the end of the second line, then type the letter "x".  (The second and third screenshots would normally have a keyboard up, but I couldn't easily take a screenshot with the keyboard up.)


How to get elf information?

Used to be, i could simply iterate through elf_sections_tag.sections() and get what I wanted, but that is no longer the case.  What is the current way to get things like e.g. the elf section size and location for each section?

I guess i should point out my ultimate goal is to get os size (and possibly in the future location)

Hi!
What about https://docs.rs/multiboot2/0.23.0/multiboot2/struct.BootInformation.html#method.elf_sections, isn't this what you need?

Yeah, I can't see any public methods to actually get the data i want out.

Yeah, I can't see any public methods to actually get the data i want out.

Which data do you want to get?

i'll check it out this evening.  my ultimate goal is to find the location and size of my kernel in memory, and i was hoping to use the elf tags to do so.

groovy, this seems to have done the trick, thanks!

Fixed with v0.23.1.


[BEAM-5122] Disable testUsesDlq due to flakiness

Disable testUsesDlq temporarily due to flakiness. Based on input from Anton (akedin).

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.


BF: pin futures version

Futures got more aggressive about rejecting Python 3 installs - see
https://github.com/ogrisel/wheelhouse-uploader/issues/24.  Pin to older
version.

Actually, wouldn't,
'futures; python_version == "2.7"'

as suggested in https://pypi.org/project/futures/  be better? Unless this would also require some higher minimum version of setuptools ...

OK - that does seem to work.  I didn't investigate the setuptools dependency.

Not 100% sure but @ogrisel may be on holiday this week ...


Write debug info to comm.log*

Do NOT merge!

Build with BUILD_WITH_MPI and DEBUG_TRACE_COMM
Execute mpirun -n 4 ../build/couette in /example
Run /example/process_comm_log.py
This creates comm.log in /example

Corresponds to #57

TODO: Delete this branch after the refactor


Currently requires explicitly setting ip in happi

the docker container does not reach out into <IP_ADDRESS>, and thus it needs to be different.
LAN ip should work, but somewhat more efficent is renaming a loopback outside of 127.* as then it does not leave the machine at all.

For linux:
sudo ip addr add <IP_ADDRESS> dev lo
yaqd clear-cache
yaqd scan --host <IP_ADDRESS>

can also edit /etc/hosts to add <IP_ADDRESS>      yaq then you can just do yaqd scan --host yaq
I did a similar trick on windows, but don't recall the exact command.
This is performant as it is just a loopback alias
IP address chosen at random, unlikely to interfere with anything. perhaps would be safer to go with a 10. or 192.168 ip address, as that is reserved for LAN.
once the yaqd cache is filled, it should just work with happi without manual editing

Note that the alias does not survive reboot on linux, not sure why not, or if there is some way (other than of course startup script) to keep it permanent...


Reorganize favorite sidebar

What's the Problem?
Pinned items on favorite sidebar can't be moved to sort it differently.
Solution/Idea
Be able to drag the pinned items  and drop for reorder them.
Alternatives
Be able to drag the pinned items  and drop for reorder them.
Priorities

Capability
Priority

This proposal will allow developers to accomplish W
Must

This proposal will allow end users to accomplish X
Should

This proposal will allow developers to accomplish Y
Could

This proposal will allow end users to accomplish Z
Won't

Files Version
v1.5
Windows Version
Windows 10 10.0.18362
Additional comment
No response

Implemented in Files v2!


Not working in the built and release mode

I have integrated the device calendar plugin in my project and all the functions are working fine when I run the code but when I run it in release mode or make a built to release, these functionalities are not working

I am not having this problem. I think you need to be more specific what is not working for you in order to get better help.

Can confirm that adding events to a calendar does not work in release mode. I have used thoroughly tested this in debug mode and it works fine. In release mode, I am attempting to catch the error which fails the following is check. It is clearly a ResultError but somehow `ex is ResultError returns false. In summary, I have no way to figure out what the problem is.
try {
   await _calendarPlugin.createOrUpdateEvent(deviceEvent)
} catch (ex) {
  if (ex is ResultError) {
    print('result error');
  }
}

Apparently this library throws a List<ResultError> instead of a single ResultError. Here is my code:
final calendarsResult = await _calendarPlugin.retrieveCalendars();
if (!calendarsResult.isSuccess) {
  throw 'Failed to retrieve calendars';
} else if (calendarsResult.data == null || calendarsResult.data!.isEmpty) {
  throw 'Could not find any calendars';
}

calendarsResult.data!.forEach((calendar) {
  print('${calendar.id} ${calendar.name}, default: ${calendar.isDefault}, readOnly: ${calendar.isReadOnly}');
});

In debug mode in successfully retrieves all calendars and print the data correctly. In release mode, calendar.id, calendar.name, etc. are all null. So the core problem is that I don't actually have a calendarId to save events to because it is null.

@ARAVINDKARATE @zakton5  Please provide more details, such as:

manufacturer of the phones (I think Samsung's local calendar was once problematic)
were said calendar local only, or were they synced with a specific cloud service provider (Google / Microsoft / Apple / Proton etc)
Version of your phone and the plugin, maybe run a flutter doctor -v while you're at it
were calendar permissions granted to the app at the time

I found the section on the R8 proguard issue. I followed those steps and everything works well now.


Equation Solver Module

I think a set of equation solvers from linear to quartic should be implemented and optimized for getting exact solutions as well as approximations. I have made a simple example for a cubicSolve function

/// # Cubic Equation Solver
///
/// Solves the cubic equation of the form `ax^3 + bx^2 + cx + d = 0` - **eq: 1**
/// Should follow some variation of the following algorithm
/// - important:  a, b, c, d should all be real numbers.
/// - reference:   [Cubic Equation](https://en.wikipedia.org/wiki/Cubic_equation)
///
/// Procedure:
/// 1.  Divide both sides of equation by a.
///     i. In the case that a == 0 fallback onto the `quadraticSolve`.
///     ii. other wise move on to step 2.
///     The equation should now look as follows x^3 + (b/a)x^2 + (c/a)x + d/a = 0.
/// 2.  Calculate the discriminant D
///     i. Let r_1 = b/a ,  r_2 = c/a , and r_3 = d/a.
///     ii. Let `G = (3*r_2 - r_1^2)/9` and `F = (9*r_1*r_2 - 27*r_3 - 2*r_1^3)/54`
///     iii. Then `D = G^3 + F^2`
///   a. If `D > 0` , one real root with 2 complex conjugate roots.
///   b. if `D = 0` , all roots are real and atleast 2 are repeated.
///   c. If `D < 0`, all roots are real and unequal.
/// A.  `D > 0`,  where `cbrt` and `sqrt`  are the cuberoot and squareroot respectively.
///     1. The only real solution: ` x_1 = cbrt(F + sqrt(D)) + cbrt(F - sqrt(D)) - (1/3)*r_1`
///     2.  First Complex  solution :  `x_2 = Complex(-(1/2)(cbrt(F + sqrt(D)) + cbrt(F - sqrt(D))) - (1/3)*r_1 , (cbrt(3)/2)*cbrt(F + sqrt(D)) - cbrt(F - sqrt(D)))`
///     3.  Second Complex  solution:  `x_3 = Complex(-(1/2)(cbrt(F + sqrt(D)) + cbrt(F - sqrt(D))) - (1/3)*r_1 ,  -(cbrt(3)/2)*cbrt(F + sqrt(D)) - cbrt(F - sqrt(D)))`
/// B.  For `D = 0`  and `D < 0 ` Reduce Equation to Depressed Cubic
///     1. Make the substitution of `x = t - b/(3a)` in **eq: 1**  resulting in:
///              `t^3 + p*t + q = 0` -  **eq: 2** where:
///              `p = (3*a*c - b^2)/(3*a^2)` and `q =  (2b^3 - 9*a*b*c + 27*a^2*d)/(27*a^3)`
///              i. If `p = q = 0` then all roots `t_1 = t_2 = t_3 = 0`
///              ii. If `4*p^3 + 27*q^2 = 0` and  `p != 0` then  `t_1 = 3*q/p` and ` t_2 = t_3 =  -3*q/(2*p)`
///              iii. If `D < 0`  then `t(k) = 2*sqrt(-p/3)*cos((1/3)*acos((3*q/(2*p)*sqrt(-3/p))) - 2*pi*k/3)` for  `k = 1,2,3`
///     2. Convert back to x using `x(k) = t(k) - b/(3*a)`
///
///   - note: General Optimizations can be performed for trigonometric identities or for making approximations based upon values  of a ,b , c, and d
///
///
///
///
func cubicSolve<R: Real, C: Complex>(a: R, b: R, c: R, d: R) -> [C] {
    if a == 0 { return quadraticSolve(a: b, b: c, c: d) }

    let r_1 = b/a
    let r_2 = c/a
    let r_3 = d/a

    let g = (3.0*r_2 - r_1^2.0)/9.0 // G
    let f = (9*r_1*r_2 - 27*r_3 - 2*r_1^3)/54 // F

    let d = g^3 + f^2 // discriminant
    if d > 0 {
        let x_1 = cbrt(f + sqrt(d)) + cbrt(f - sqrt(d)) - (1/3)*r_1
        let x_2 = Complex(-(1/2)(cbrt(f + sqrt(d)) + cbrt(f - sqrt(d))) - (1/3)*r_1 , (cbrt(3)/2)*cbrt(f + sqrt(d)) - cbrt(f - sqrt(d)))
        let x_3 = Complex(-(1/2)(cbrt(f + sqrt(d)) + cbrt(f - sqrt(d))) - (1/3)*r_1 ,  -(cbrt(3)/2)*cbrt(f + sqrt(d)) - cbrt(f - sqrt(d)))
        return [x_1, x_2, x_3]

    } else if d = 0 {
        let p = (3*a*c - b^2)/(3*a^2)
        let q =  (2b^3 - 9*a*b*c + 27*a^2*d)/(27*a^3)
        let conversionFactor = -(-b/(3*a))

        if p == 0 && q == 0 {
            return [0, 0, 0]
        } else if p != 0 && 4*p^3 + 27*q^2 == 0 {

            let t_1 = 3*q/p
            let t_2 = -3*q/(2*p)
            let t_3 = -3*q/(2*p)
            return [t_1 + conversionFactor, t_2 + conversionFactor, t_3 + conversionFactor]
        }

    } else if d < 0 {
        return (1...3).map {
            2*sqrt(-p/3)*cos((1/3)*acos((3*q/(2*p)*sqrt(-3/p))) - 2*pi*$0/3) + conversionFactor
        }
    }
}

Checking discriminant == 0 is hard.
However, it always requires a solver version that only returns the real root.
For example, I don't need the points of interaction of two bezier curve which come from imaginary world. :)


Adds travis and codecov badges

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@fb23c63). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             master    #20   +/-   ##
=======================================
  Coverage          ?   100%
=======================================
  Files             ?      1
  Lines             ?      9
  Branches          ?      0
=======================================
  Hits              ?      9
  Misses            ?      0
  Partials          ?      0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb23c63...1c0cb4e. Read the comment docs.


data-grid

The react grid layout doesn't render all of the grids when they have coordination. It only renders when data-grid isn't present.

problem solved


ManyToMany not always in json with ownerSide=false

Overview of the issue
The "non Owner" side of ManyToMany relationship is not always present in JDL, (making fluent methods in the generator break)
entity A
entity B

//works:
relationship ManyToMany {
    A{b) to B{a}
}

//works:
relationship ManyToMany {
    A to B
}

//DOES NOT work:
relationship ManyToMany {
    A{b) to B
}

If this is a "feature" not a bug, how can the generator know that Set<A> will not be present in B.java to avoid calling b.getAS().add(this); in A.java
If we want to keep this behavior (not having Set<A> in B) the logique in my opinion should be in the generator not in the .json.
Or maybe this case will juste disappear when the generators code starts using the .jdl as it's input, and if we want it back we will need to code the right way in the generator.

Motivation for or Use Case
This clearly can be avoided by changing the JDL, but it should be a known issue to avoid wasting other peoples time.
This is a bug because, the generated code does not compile
JHipster Version(s)
6.1.2 (don't think it's a regression) it's a side effect of adding fluent methods for add...

[X] Checking this box is mandatory (this is just to show you read everything)

I'll test this out and fix it. Thanks for reporting this issue!

I wonder if it's not an issue with the generator, that should allow unidirectional many to many...

The fix is quite easy:

in the entity parser, add a check and fill the other side
update tests and add a new one in the entity parser

@MathieuAA This is what I tried to explain in the issue, sadly didn't have time to work on it, I'm in a bit of pickle these days with some projects so sorry, I can't help any further for now.

Don't worry! I'll try to get to the bottom of this :) again, thanks for reporting this one


Support Alicloud OSS

Title
Support  Alicloud OSS
Motivation
I am currently working for alibaba, and I encounter marvelous  smartopen lib when I am coding. However, it doesn't support Alicloud OSS.
So I figured I should add oss support myself.
Contributing to opensource community is always my dream.
Tests
still working on integration tests.
Work in progress
70% finished, would love to hear your comments.
Checklist
Before you create the PR, please make sure you have:

[x] Picked a concise, informative and complete title
[x] Clearly explained the motivation behind the PR
[ ] Linked to any existing issues that your PR will be solving
[ ] Included tests for any new functionality
[ ] Checked that all unit tests pass

Hi, had a brief look at the changes, looks like you're on the right track. Let me know when the code is ready for a review. Thanks!

Any updates?


[WIP]: 635: Persist nameserver entries

I'm opening a PR to get your instant feedback on changes I'd like to introduce to the nameserver component to make it retain extra nameserver entries on restarts.
In this PR, there are multiple TODO items (denoted as TODO(mp)) which require your attention.
I'll fix related docs once I'm done with the code.
The PR would fix #635 and #1654.

As an additional idea, you could act on ContainerDestroyed to remove the stopped flag since that container is not coming back.

Ghm. I was thinking about the following situation:

Nameserver stops.
A container is destroyed.
Nameserver is re-launched.

Please correct me if I'm wrong, but in such situation Nameserver won't receive the ContainerDestroyed event for the container which was destroyed at the step (2), so it might leak.

As discussed verbally:

Nameserver stops.
A container is destroyed.
Nameserver is re-launched.

. 4. Nameserver re-syncs its data with the current list of all containers and removes the destroyed one.

you've added a whole bunch of binaries.

There is some relevant discussion at #1179. It seems we have a fundamental problem in the different mechanisms for adding and removing (on die) DNS entries.

Closing due to inactivity


Null safety and flutter2

Need to upgrade to support null safety and flutter2

Thank you for bringing my attention to that.
I'll try to do that over the weekend!

Null safety and Flutter 2 is now supported: https://github.com/Afonsocraposo/buttons_tabbar/commit/94988fd0826ad5485b904cb23ead6d4fa29795df
Update your pubspec.yaml to version:
dependencies:
  ...
  buttons_tabbar: ^1.2.0


Avoid 3-fold repetitions

See https://github.com/ornicar/lichess-puzzler/commit/3e3377e3ea576785126780c7c7a9291b37c46453 for a clean diff
The transition to a class isn't really necessary but I thought it would be useful for this at first.

Glad to see this fixed! I'll write a script to retroactively apply this filter to the puzzle database.


New assembly syntax

Our crate is currently broken on nightly because we need to update our assembly syntax or keep using legacy assembly. I will get around to this if nobody else does soon. This will break compatibility with nightlies older than a few weeks at maximum, so this will probably be a breaking change (@phil-opp please confirm this).

I don't think that anything is broken right now, the CI jobs succeeded with the latest nightly (apart from clippy): https://github.com/rust-osdev/x86_64/actions/runs/145726670 . We're using llvm_asm! instead of asm! since version 0.10.2, perhaps you're on an older version?
I'm of course open to switching to the new asm! macro anyway, so feel free to send in a PR if you like. We can publish it as a semver-breaking version to avoid breaking people on older nightlies if we want to.

Huh, I could have sworn I saw the latest build being broken because of this when I posted it. My bad. Regardless, moving to the new asm! macro would be great


Support RadioHead library

The RadioHead library is an abstraction to help user implement wireless communication over RF modules (such as nRF24L01+).
It is under Open Source Licensing GPL V2. Unfortunately, I did not found any source code repository (but sources are available for download).

Done. Thanks :+1:

library.json
Library Registry


Divide by 0 exception message

The code is
logger.exception('You can\t divide by zero')
Looks like you dropped the ' between the \ and the t.
Should be
logger.exception('You can\'t divide by zero')

will take a look

fixed


Custom Polymorphic model binding with complex properties in child classes

I have followed the Polymorphic Custom Model Binder using this post. However it illustrates a basic scenario assuming simple type properties for the child classes. It doesn't explores the possibility of a child class having a complex property. It would be helpful to share some thoughts on it.
E.g.
public abstract class Device
{
public string Kind { get; set; }
}
public class Laptop : Device
{
public string CPUIndex { get; set; }
}
public class SmartPhone : Device
{
public string ScreenSize { get; set; }
public Dimension PhoneDimension{ get; set; }
}
where Dimension is a complex type
public class Dimension
{
public double height{ get; set; }
public double width{ get; set; }
}

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cfb00531-4ac6-8bf6-9bd8-1eed6446397f
Version Independent ID: ed418d09-6c33-699a-0d48-9aabc99457be
Content: Custom Model Binding in ASP.NET Core
Content Source: aspnetcore/mvc/advanced/custom-model-binding.md
Product: aspnet-core
Technology: aspnetcore-mvc
GitHub Login: @ardalis
Microsoft Alias: riande

Hello! Thanks for contacting us. This sounds like a general question about using ASP.NET Core. While we try to look at and respond to all issues, for questions like this we recommend posting to a community support group like Stack Overflow with the asp.net-core tag.

Stack Overflow
ASP.NET Core Slack
ASP.NET Gitter

Potential bugs in the ASP.NET Core framework and product feedback can be reported at dotnet/aspnetcore issues (include full repro steps and cross-link to a repro project in GH when appropriate). For Visual Studio, use the Report a Problem gesture or Suggest a Feature gesture within VS, which open internal issues for the VS team. For Visual Studio Code, you can open an issue at microsoft/vscode issues.


Backport: Increase the coverage of the apiId cache

Backport: Increase the coverage of the apiId cache
Backport to 2.5.4-SNAPSHOT

Applied to the 2.5.4-SNAPSHOT version.


[Regression]: DayOfWeek,DayOfYear transformation are missing

DayOfWeek,DayOfYear transformations are missing in UI when mapping from Date to Integer. I'm sure I've seen those transformations before.
Also it would make sense to add DayOfMonth transformation. (or did I miss it?)

Date/Time field actions appear only when target field is Date/Time field. There were some bugs field action is applied to source field in very limited cases, but disabled it as it's confusing.
@jpav can you respond about DayOfMonth?

Yeah I see, but DayOfYear was number and DayOfWeek too(but could be also string such as 'Monday'..). I agree that it's confusing.

Those field actions consume Date/Time and return a number. In order to apply field actions on target field, both of input and output must be Date/Time.
Those field actions only make sense for source field, which requires #278 to be implemented ahead.

Now that I'm getting more knee-deep in the UI code, I really see what a mess this is. It's definitely very confusing the way things are now. I'm now thinking we're doing this completely backwards in the UI. The "flow" of a transformation should start with the source field(s), followed by one or more transformations, then end with the mapping(s) to the target field(s). With this in mind, it seems to me that we really need the UI to do the opposite of what it's currently doing and provide only source field transformations (i.e., field actions), with the end transformation being either a mapping, combine, or separate. Having said all that, since things work the way they do now, these DayOfXXX functions basically aren't currently supported by the UI, so although I agree it would otherwise make sense to have a DayOfMonth transformation too, it's a moot point at the moment.

Blocked by #278

Hi @igarashitm Since we have already Source side transformation, I suppose that we could move forward to design the DayofMonth transformation now? And this kind of transformation appear only  when user select a Date and time value on source and  target field? Currently, we could support Date, time, month and year as a type of value? Thanks~

Great~Thanks!Tomo @igarashitm


DBZ-2753: Making the BROKER and ZOOKEEPER URLs default to host 0.0.0.…

…0 which would be default container host address with respective ports 2888 and 9092 rather than exiting the container when the ENV variable is not present. The process will still fail in the case when the default access points not reached with a timeout error

@jpechane @rk3rn3r for your review.

@rareddy Applied, thanks


Cannot create new machine with compute image without boot volume

When attempting to use a compute flavor (as listed), the provision fails with message, "Policy doesn't allow compute_flavor:create:image_backed to be performed."
Compute images require a boot to volume rather than local.  See https://github.com/chef/knife-rackspace/issues/91
It appears fog supports booting to a volume, but I don't see that option from the vagrant-rackspace plugin documentation.

It looks like this is the preferred method for compute images, which require a volume to boot: https://developer.rackspace.com/docs/cloud-servers/v2/api-reference/svr-basic-operations/#post-create-bootable-volume-and-server-servers


fix: sanity fixes update, fix id

@moondao final pull request mate, let's do this quick

@moondao after fix the code, do npm run check-sanity, and you should pass the ci check and can be approved quickly

@moondao after fix the code, do npm run check-sanity, and you should pass the ci check and can be approved quickly

please tell me which part code should be fixed?

@moondao you did a good job bro, just remind TrustWallet team to check on us

@moondao you did a good job bro, just remind TrustWallet team to check on us

so now i just need to wait?

yes and remind approver on their pull request https://github.com/trustwallet/assets/pull/6078

ok thank you.

@moondao can you remind @catenocrypt or @zachzwei on the pull request, they should approve now because it should be done within a working day lol


ERROR:rasa.core.channels.facebook:Exception when trying to handle webhook for facebook message.

Rasa version:
1.0.7
Rasa X version (if used & relevant):
0.19.0
Python version:
3.6.8
Operating system (windows, osx, ...):
ubuntu 19.04
Issue:
Can able to receive messages from FB Messenger. But bot could not respond. In fact unable to find next action. There is no memorised next action (debug) and also facebook exception (error).
Error (including full traceback):
DEBUG:rasa.core.processor:Received user message 'Hi' with intent '{'name': 'greet', 'confidence': 0.9773842096328735}' and entities '[]'
DEBUG:rasa.core.processor:Logged UserUtterance - tracker now has 4 events
DEBUG:rasa.core.policies.memoization:Current tracker state [None, {}, {'prev_action_listen': 1.0, 'intent_greet': 1.0}]
DEBUG:rasa.core.policies.memoization:There is no memorised next action
DEBUG:rasa.core.policies.memoization:Current tracker state [None, None, None, {}, {'prev_action_listen': 1.0, 'intent_greet': 1.0}]
DEBUG:rasa.core.policies.memoization:Launch DeLorean...
DEBUG:rasa.core.policies.memoization:Current tracker state [None, None, None, {}, {'prev_action_listen': 1.0, 'intent_greet': 1.0}]
DEBUG:rasa.core.policies.memoization:There is no memorised next action
DEBUG:rasa.core.agent:Deleted lock for conversation '2373945415998316' (unused)
ERROR:rasa.core.channels.facebook:Exception when trying to handle webhook for facebook message.
Traceback (most recent call last):
  File "/home/hari/environment_directory/rasa-tutorial/first/lib/python3.7/site-packages/rasa/core/channels/facebook.py", line 94, in _handle_user_message
    await self.on_new_message(user_msg)
  File "/home/hari/environment_directory/rasa-tutorial/first/lib/python3.7/site-packages/rasa/core/channels/channel.py", line 68, in handler
    await app.agent.handle_message(*args, **kwargs)
  File "/home/hari/environment_directory/rasa-tutorial/first/lib/python3.7/site-packages/rasa/core/agent.py", line 441, in handle_message
    return await processor.handle_message(message)
  File "/home/hari/environment_directory/rasa-tutorial/first/lib/python3.7/site-packages/rasa/core/processor.py", line 74, in handle_message
    await self._predict_and_execute_next_action(message, tracker)
  File "/home/hari/environment_directory/rasa-tutorial/first/lib/python3.7/site-packages/rasa/core/processor.py", line 337, in _predict_and_execute_next_action
    action, policy, confidence = self.predict_next_action(tracker)
  File "/home/hari/environment_directory/rasa-tutorial/first/lib/python3.7/site-packages/rasa/core/processor.py", line 164, in predict_next_action
    action_confidences, policy = self._get_next_action_probabilities(tracker)
  File "/home/hari/environment_directory/rasa-tutorial/first/lib/python3.7/site-packages/rasa/core/processor.py", line 550, in _get_next_action_probabilities
    tracker, self.domain
  File "/home/hari/environment_directory/rasa-tutorial/first/lib/python3.7/site-packages/rasa/core/policies/ensemble.py", line 342, in probabilities_using_best_policy
    probabilities = p.predict_action_probabilities(tracker, domain)
  File "/home/hari/environment_directory/rasa-tutorial/first/lib/python3.7/site-packages/rasa/core/policies/keras_policy.py", line 252, in predict_action_probabilities
    X = self.featurizer.create_X([tracker], domain)
  File "/home/hari/environment_directory/rasa-tutorial/first/lib/python3.7/site-packages/rasa/core/featurizers.py", line 408, in create_X
    X, _ = self._featurize_states(trackers_as_states)
  File "/home/hari/environment_directory/rasa-tutorial/first/lib/python3.7/site-packages/rasa/core/featurizers.py", line 335, in _featurize_states
    self.state_featurizer.encode(state) for state in tracker_states
  File "/home/hari/environment_directory/rasa-tutorial/first/lib/python3.7/site-packages/rasa/core/featurizers.py", line 335, in <listcomp>
    self.state_featurizer.encode(state) for state in tracker_states
  File "/home/hari/environment_directory/rasa-tutorial/first/lib/python3.7/site-packages/rasa/core/featurizers.py", line 102, in encode
    "BinarySingleStateFeaturizer was not prepared before encoding."
Exception: BinarySingleStateFeaturizer was not prepared before encoding.
WARNING:asyncio:Executing <Task finished coro=<SanicPluginsFramework._handle_request() done, defined at /home/hari/environment_directory/rasa-tutorial/first/lib/python3.7/site-packages/spf/framework.py:471> result=None created at /home/hari/environment_directory/rasa-tutorial/first/lib/python3.7/site-packages/sanic/server.py:365> took 0.006 seconds

Command or request that led to error:

def run(serve_forever=True, debug=False):
  logging.basicConfig(stream=sys.stdout, level=logging.DEBUG)
  logger = logging.getLogger(__name__)

  # load your trained agent
  interpreter = RasaNLUInterpreter("models/current/nlu")
  MODEL_PATH = "models/current/core"

  action_endpoint = EndpointConfig(url="https://ogmoneybot-actions.herokuapp.com/webhook")

  max_history = 3
  agent = Agent(MODEL_PATH, interpreter=interpreter, action_endpoint=action_endpoint,
  policies=[
  MemoizationPolicy(max_history=max_history),
  AugmentedMemoizationPolicy(),
  KerasPolicy(MaxHistoryTrackerFeaturizer(BinarySingleStateFeaturizer(),
                                            max_history=max_history)),MappingPolicy(),FallbackPolicy(nlu_threshold=0.3, core_threshold=0.3)])

  #training_data_file='data/stories.md'
  #data = agent.load_data(training_data_file)
  #agent.train(data)

  #agent = agent.load(MODEL_PATH, interpreter=interpreter, action_endpoint=action_endpoint)

  input_channel = FacebookInput(
        fb_verify="some value",
        # you need tell facebook this token, to confirm your URL
        fb_secret="some value",  # your app secret
 fb_access_token="some value"
        # token for the page you subscribed to
  )
  # set serve_forever=False if you want to keep the server running
  if serve_forever:
    agent.handle_channels([input_channel], int(os.environ.get('PORT', 5004)))
    #agent.handle_channel(HttpInputChannel(5004, "/app", input_channel))
  return agent

Content of configuration file (config.yml) (if relevant):
# Configuration for Rasa NLU.
# https://rasa.com/docs/rasa/nlu/components/
language: en
pipeline: supervised_embeddings

# Configuration for Rasa Core.
# https://rasa.com/docs/rasa/core/policies/
policies:
  - name: MemoizationPolicy
  - name: KerasPolicy
  - name: MappingPolicy
  - name: "FallbackPolicy"
    nlu_threshold: 0.3
    core_threshold: 0.3
    fallback_action_name: "action_default_fallback"

Content of domain file (domain.yml) (if relevant):
entities:
- balance_type
- dob

intents:
  - help
  - greet
  - goodbye
  - balance_enquiry
  - report_issue
  - transaction_info
  - current_location
  - service_receipt
  - affirm
  - deny
  - mood_great
  - mood_unhappy
  - ask
  - ask_response

slots:
  balance_type:
    type: categorical
    values:
    - mobile
    - wallet
  mobile_balance:
    max_value: 1.0
    min_value: 0.0
    type: float
  service_category:
    type: categorical
    values:
    - mobile_bill_payment
    - topup
    - voucher
    - charity
  service_type:
    type: categorical
    values:
    - prepaid
    - postpaid
  telecom_operator:
    type: categorical
    values:
    - zain
    - ooredoo
    - viva
  wallet_balance:
    max_value: 1.0
    min_value: 0.0
    type: float

templates:
  utter_cheer_up:
    - text: 'Here is something to cheer you up:'
      image: https://i.imgur.com/nGF1K8f.jpg
  utter_default:
    - text: Sorry, I didn't understand that
  utter_did_that_help:
    - text: Did that help you?
  utter_goodbye:
    - text: Bye
  utter_greet:
    - text: Hey! How are you?
  utter_happy:
    - text: Great carry on!
  utter_help:
    - text: I can help you view your balances, transaction history, report issues if any.
  utter_mobile_balance:
    - text: 'Your mobile balance is: {mobile_balance}'
  utter_telecom_usage_info:
    - text: Bye
  utter_wallet_balance:
    - text: 'Your wallet balance is: {wallet_balance}'
  utter_which_balance:
    - text: Which balance?
      buttons:
      - title: Operator balance
        payload: /balance_enquiry{"balance_type":"mobile"}
      - title: Wallet balance
        payload: /balance_enquiry{"balance_type":"wallet"}

actions:
- action_fetch_mobile_balance
- action_fetch_wallet_balance
- utter_cheer_up
- utter_did_that_help
- utter_goodbye
- utter_greet
- utter_happy
- utter_help
- utter_mobile_balance
- utter_telecom_usage_info
- utter_wallet_balance
- utter_which_balance

I don't think this is related to facebook messenger, but rather how you're training/loading your bot. I assume you've trained your bot with rasa train and the config file you specified? Can I ask why you're not just starting it with rasa run instead of with the custom code?

I don't think this is related to facebook messenger, but rather how you're training/loading your bot. I assume you've trained your bot with rasa train and the config file you specified? Can I ask why you're not just starting it with rasa run instead of with the custom code?

Thank you akelad for your response. Yes trained with rasa train and also tested with "rasa run --credentials credentials.yml -c facebook" as well. Still the result is same. Credentials.yml contains the correct credentials of facebook as well.


add cupyx.scipy.ndimage.fourier_shift, fourier_gaussian, fourier_uniform

This adds the fourier_shift function from ndimage. These functions take a Fourier-domain image and apply the complex exponentials that would be needed to give a (circular) shift in the spatial domain. (i.e. based on the Fourier shift theorem).
It seems like we might already have a utility like _reshape_nd here somewhere else, but I'm not sure. If desired we could move it to cupy.core.internal.
_get_output_fourier_complex was copied from SciPy
The SciPy implementation is in C and could be emulated via an ElementwiseKernel. This separable implementation only has to take the complex exponential of a 1d array along each axis rather than at every n-d element, though, so I think it might be faster.

Benchmarking indicates that it is up to ~200 times faster than SciPy for sufficiently large inputs.
import numpy as np
import cupy as cp
import scipy.ndimage as ndi

print(" case | timing | acceleration")
print("------|--------|-------------")
for dtype in [np.complex64, np.complex128]:
    for shape in [(16, 16), (512, 512), (4096, 4096), (256, 256, 256), (64, 64, 64, 64)]:

        a = cp.random.randn(*shape).astype(dtype)
        a = a + 1j * cp.random.randn(*shape).astype(dtype)
        a_cpu = a.get()

        perf_cpu = repeat(
            ndi.fourier_shift, (a_cpu, 5), n_warmup=1, n_repeat=10
        )
        # print(f"shape={shape, np.dtype(dtype).name},  CPU | {perf_cpu}")

        perf_gpu = repeat(fourier_shift, (a, 5), n_warmup=20, n_repeat=100)
        accel = perf_cpu.cpu_times.mean() / perf_gpu.gpu_times.mean()
        print(f"shape={shape, np.dtype(dtype).name},  GPU | {perf_gpu} | {accel}")

case
timing
acceleration

shape=((16, 16), 'complex64'),  GPU
fourier_shift       :    CPU:  259.434 us   +/- 9.128 (min:  248.098 / max:  289.571) us     GPU-0:  265.398 us   +/- 9.740 (min:  253.056 / max:  295.584) us
0.119

shape=((512, 512), 'complex64'),  GPU
fourier_shift       :    CPU:  242.909 us   +/-10.986 (min:  232.220 / max:  289.472) us     GPU-0:  260.337 us   +/-10.977 (min:  246.784 / max:  307.136) us
33.431

shape=((4096, 4096), 'complex64'),  GPU
fourier_shift       :    CPU:  247.149 us   +/- 8.721 (min:  238.362 / max:  304.858) us     GPU-0: 2707.958 us   +/- 2.065 (min: 2704.256 / max: 2720.768) us
207.857

shape=((256, 256, 256), 'complex64'),  GPU
fourier_shift       :    CPU:  361.868 us   +/-14.145 (min:  348.473 / max:  414.055) us     GPU-0: 4156.544 us   +/- 2.868 (min: 4153.280 / max: 4177.472) us
153.500

shape=((64, 64, 64, 64), 'complex64'),  GPU
fourier_shift       :    CPU:  462.723 us   +/-20.095 (min:  448.648 / max:  588.778) us     GPU-0: 6233.556 us   +/-190.690 (min: 6143.744 / max: 6674.432) us
130.562

shape=((16, 16), 'complex128'),  GPU
fourier_shift       :    CPU:  231.031 us   +/- 5.431 (min:  225.306 / max:  249.774) us     GPU-0:  235.647 us   +/- 5.492 (min:  229.792 / max:  254.912) us
0.118

shape=((512, 512), 'complex128'),  GPU
fourier_shift       :    CPU:  256.580 us   +/-26.733 (min:  244.917 / max:  434.671) us     GPU-0:  277.703 us   +/-26.485 (min:  266.080 / max:  455.680) us
30.315

shape=((4096, 4096), 'complex128'),  GPU
fourier_shift       :    CPU:  249.217 us   +/- 9.349 (min:  240.328 / max:  284.779) us     GPU-0: 4819.422 us   +/- 5.673 (min: 4810.752 / max: 4831.200) us
119.193

shape=((256, 256, 256), 'complex128'),  GPU
fourier_shift       :    CPU:  367.907 us   +/-16.750 (min:  347.834 / max:  480.342) us     GPU-0: 6462.972 us   +/- 6.579 (min: 6453.248 / max: 6496.032) us
100.121

shape=((64, 64, 64, 64), 'complex128'),  GPU
fourier_shift       :    CPU:  464.110 us   +/-21.806 (min:  447.258 / max:  567.377) us     GPU-0: 9009.900 us   +/- 2.527 (min: 9006.080 / max: 9023.488) us
93.633

cc @coderforlife for awareness: I had already done this function for cupyimg as it is used within scikit-image functions, but I have not worked on anything else from the ndimage.fourier submodule.

@grlee77 I have never actually used any of the ndimage.fourier functions. I have looked at them, and many of them look to mostly jus tpre-compute some values (like exponentials for Guassians) and then do an element-wise multiplication. I have always just done the multiplication myself.

I went ahead and added fourier_gaussian and fourier_uniform as well. They are also separable and thus can be implemented very similarly to the fourier_shift case.
The test structure is nearly the same too. Mainly it is just the function name and the second argument name/range that is different across these three functions.

These all seem way simpler than the scipy implementations (which I always thought was overkill).

These all seem way simpler than the scipy implementations (which I always thought was overkill).

Yeah, actually these implementations when using NumPy instead of CuPy are faster than SciPy's in most cases. SciPy's C implementation wins in 1D, but for 2D/3D this separable approach can be 3-5 times faster.
I think the SciPy approach is more justified for the elliptical filter case (not implemented in this PR). It is the only case that is non-separable along the axes (you have to compute the Euclidean distance from the f=0 coordinate at each frequency location).

FTI, _fix_sequence_arg is now in cupyx.scipy.ndimage._util and not cupyx.scipy.ndimage.filters.

pfnCI, test this please.

Jenkins CI test (for commit 1ff2a919b913554ad66c5dd41db0a97ee8791b9c, target branch master) failed with status FAILURE.

This should now be ready to test

pfnCI, test this please.

Thanks! Merging will be done after the CI passes.

Jenkins CI test (for commit<PHONE_NUMBER>e7ab15382fb783f536fab55df64bd3, target branch master) failed with status FAILURE.

I see the reason for the failure. The tests as written require scipy >= 1.4 to run due to use of the newer scipy.fft module. We should be able to fall back to scipy.fftpack instead for older SciPy.

Hopefully the most recent commit will change the previous CI failure. I didn't see a really easy way to run the real-valued tests on older scipy because the behavior of the real-valued FFTs in scipy.fft behave like numpy.fft and not scipy.fftpack. We also can't use numpy.fft instead of scipy.fft because it always returns double precision results while scipy's does not.

pfnCI, test this please.

pfnCI, test this please.

Jenkins CI test (for commit 52a0891b215c94056d74d333c4a233541e444b24, target branch master) succeeded!


Add CI badge to README.md

Motivation
Let users know this project has a CI workflow and its latest result.

This is resolved by #70.