BindGateway to dataset with multiple datasources

Hi,
I have an dataset that have two datasources. Log bellow.

How can I bind the gateway to the datasource?
If my report has only one datasource in the dataset, the UpdateGateway actions works.
Starting: Update Gateway
Task         : Power BI Actions
Description  : Release Task Power BI Actions
Version      : 5.3.16
Author       : Maik van der Gaag
Help         :
Starting Power BI Actions extension
Required Module is needed. Importing now...
Trying to import the incorporated module for PowerBI
##[warning]The names of some imported commands from the module 'PowerBi' include unapproved verbs that might make them less discoverable. To find the commands with unapproved verbs, run the Import-Module command again with the Verbose parameter. For a list of approved verbs, type Get-Verb.
Trying to change the Gateway
Getting Power BI Workspace properties; Business
##[warning]No action taken! Gateway DataSource- '' for Dataset- 'Customers' could not be matched; ensure the gateway and datasource already exists
Done processing Power BI Actions
Done running Power BI Actions extension.
Finishing: Update Gateway

@maikvandergaag
Any ideia how I can solve this?

Hi @maikvandergaag, @zbroinx. I also have this problem. After my investigations as I understood need only change '-eq' to 'in' in this line: https://github.com/maikvandergaag/msft-extensions/blob/54a807df183fe11ea5133b809db998d26524b560/azuredevops/powerbiactions-new/powerbiactionsnew/ps_modules/PowerBi/powerbi.psm1#L76

@dimabutenko you should be able to fork and the do a pull request. If that isn't possible please let me know

I created pool request #284 but it has 2 of 5 checks passed.

@dimabutenko: Change looks good checks that fail are other pipelines that seem to have been triggered. Will fix that this week. For now the pull request is committed.


Travis CI: this connects to #76

Travis config looks good.
But we agreed not to install yarn as a global npm dependency because the yarn team recommends that you don't, and if you already have yarn installed using their installer, the used version depends on the order global npm pacakges and yarn are in your $PATH.
It has been added as a prerequisite instead.

I will have yarn installed manually for Travis CI and remove it from the global script.

I am not in favor of yarn. The yarn cli requires write access to global install directory. Even when starting the app with yarn it requires access to the global directory. This must be why they recommend not installing from npm. None of the other cli tools we use require write access to the global directory. On mac I either have to run 'sudo yarn' or give the current user permissions to the global directory.

Correction: The global write access is only when yarn is installed with npm in the global directory. Sorry for the confusion. @artlowel thanks for the clarification.


[plot] Add a mouse tool to move the plot view

This kind of tool is very useful for mask for example.
It is the same feature as the keyboard arrows. But providing this feature only with the keyboard is not enough, people usually search a tool to do that.

Do you mean for panning? (Panning is currently implemented but limited to the keyboard arrow keys)

The mouse pan interaction is already implemented in the Plot: Plot.setInteractiveMode("pan") but there is no action associated to it.

I agree they search for a tool to do that and we can put it. Although I think  using the arrows is better because one does not change mouse interaction mode.

And you can use keyboard arrows while drawing the mask... But we can still provide an action to enable panning mode.


[Authorization] Role assignment name description

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[x] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[x] No refresh required for updates in this PR

Contribution checklist:

[ ] I commit to follow the Breaking Change Policy of "no breaking changes"
[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[ ] Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.

[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in a stable version
[ ] Removing properties in a stable version
[ ] Removing API version(s) in a stable version
[ ] Updating API in a stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

@rolyon , looks good to me for the description change. let me know if this PR is ready to merge.

Hi @raych1
Thanks for reviewing. Is it okay that there are 3 build failures?
If okay, then you can merge.
thanks

Hi @raych1
If checks are okay, this is pull request is ready to merge.

Looks like this change is not included in the latest 2022-04-01 API.
https://github.com/Azure/azure-rest-api-specs/blob/020f48c422ec455cdee9f6516f2d0172d13e77a3/specification/authorization/resource-manager/Microsoft.Authorization/stable/2022-04-01/authorization-RoleAssignmentsCalls.json#L693


Error handling loses stack traces

Currently stack traces are completely swallowed and as a result errors are hard to debug with non-specific messages -- it would be better to log exceptions with log.exception() instead of log.error(). As a starting point, the following hack helped me a lot: https://github.com/iceboundflame/BiblioPixel/commit/8b68beb60890795e5413d6f9c8c440ab7f5ac4c4

Yeah... the intent there was to keep scary stack traces out of users view and just "properly" handle them instead with various error handling. But it doesn't always work if completely unexpected errors pop up.
Honestly not sure if I'd want to take the change you made as it could have other effects. Gotta think about it.

Agreed, the change I made isn't really correct because we don't want to replace all log.error() calls with log.exception(), as not all error-level log entries have an exception to log. It'd probably be better to call log.exception from every site that's currently swallowing an exception.

The PR above is the cleaner approach I mentioned; what do you think?


Allow backend to export operations to file

This PR provides a mechanism to export an operation to a zip file. The file is placed in a new archive content store, and can be reviewed by retrieving the export from the archive content store,  and then opening the archive viewer on a user's computer. This is a continuation of PRs #2  and #3.
UI Changes

A new option to export an operation has been added to the administrator's operation list.
Clicking this button queues an export with the database.
Only one export can be enqueued at a time. This is enforced on the frontend by disabling the archive button for any pending archives. (the backend has it's own mechanism for enforcing a single enqueued export)
Once an export has been started, it can be re-archived, and the frontend button will be re-enabled. Note: If a user simply waits on this page, the button will not re-enable. A page refresh is required.

Backend Changes

A new "Archive" data store has been introduced. This can be the same data store that is used for evidence, however, it has been separated to allow for easier review of archives (so that they are not interspersed with random evidence).
A new export processor has been added, and enabled on the dev web server. The processor checks the database exports queue, and once at least one item is in the queue, it will, sequentially, start generating exports, writing them (mostly) directly to the content store.
Content stores have been updated to allow uploading a file with a specific name, to enable exports
The backend enforces a single enqueued export by checking for the existence of a record (matching operation id and operation status). Should it find a match, the insert will fail. Otherwise, the insert succeeds, ensuring we always have 0 or 1 enqueued records for the (operation_id, "pending" status id ) tuple

Notes

The exporter should allow for concurrent exports over multiple processes. The processor will perform row-locking to ensure that only one processor can claim an export at a time. In the dev webserver, only a single processor exists.
For production purposes, there is currently no way to export. We need to decide if one instance of Web equates to one instance of the exporter (as is done on the dev server), or if the exporter needs another main file, as with the api server.
While most files are streamed from the normal/evidence content store directly to the archive content store, terminal recordings, due to their format, need to be handled specially. These will be read completely from the evidence store, then sanitized (converted into a single, long json string), then written out. As such, the memory requires for the processor grow to include the size of the biggest terminal recording, plus a bit more.
This solution is mysql specific, and requires innodb to provide the row-level locks.

For debugging locally you can run the following to see a list of exported archives:
$ docker-compose exec backend sh -c 'ls /tmp/contentstore/*.zip'

And then "download" one:
$ docker cp $(docker-compose ps -q backend):/tmp/contentstore/{zip-file-name}.zip .

Alternatively you can check /var/lib/docker/volumes on linux, however I don't think this is exposed on macos

Additionally, you'll want to generate the necessary assets make the asset viewer work. You can do this via:
cd frontend && npm run build-archive-viewer


Cannot list folder contents if a blob with the same name exist on the same level

OS: Windows 10.0.18363
Version: v0.9.0
Repro steps:

Mount blob container with goofys to a linux VM and create a blob in a folder in that container.
OR create folders and empty blobs in the same level with the same name.
Right click on a blob container of storage account --> Select "Open in File Explorer" --> Select "Open in new window"
In the new window click on one of the folders to open

Actual:
Before clicking to open a folder

After clicking on the folder to open

This is how it looks from the Azure Storage Explorer

There is a blob file under the environments folder, which cannot be listed from the VSCode extension

More Info:
Fails the same way when opening in existing workspace either.

This is a limitation of VS Code and isn't something we can fix on our end unfortunately.

If this is still causing problems for you, please file an issue on https://github.com/microsoft/vscode


upgrade to typespec 0.44.0

Description
Fix https://github.com/Azure/autorest.csharp/issues/3403

upgrade typespec to 0.44.0

Checklist
To ensure a quick review and merge, please ensure:

[ ] The PR has a understandable title and description explaining the why and what.
[ ] The PR is opened in draft if not ready for review yet.

If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review

[ ] The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

[ ] Build is completely green

Submissions with test failures require tracking issue and approval of a CODEOWNER

[ ] At least one +1 review by a CODEOWNER
[ ] All -1 reviews are confirmed resolved by the reviewer

Override/Marking reviews stale must be discussed with CODEOWNERS first

Do you have the SDK regen PR?


attributes missing from published crate?

Couldn't find attributes in the latest published crate (use tabbycat::attributes::*;) - maybe time to republish?
The rest seems to work well though :-)

Ah they're behind a feature (maybe call that out in the readme.md?)

Ah you have already - sorry I just failed to read that bit.

never mind. happy to see the problem solved. :P


Add "Report issue..." menu item to ? menu

From<EMAIL_ADDRESS>on 2011-09-06T08:45:23Z
Spyder Version:  2.1.0beta1
Python Version:  2.7.1
Qt Version:      4.7.1, PyQt4 (API v1) 4.8.3 on Linux
I thought it will be convenient to report Spyder issues directly from UI. That's why I've added an option to ? menu. The changes can be pulled from my clone at https://code.google.com/r/techtonik-bootstrap/ 52fa285fbbb1 and 734c4aec4d06 so far.
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=751

From pierre.raybaut on 2011-09-06T08:06:32Z
This sounds interesting, thanks!
I'll take a look at it.
Status: Accepted
Labels: -Type-Defect Type-Enhancement Cat-SpyderGUI Milestone-Release2.1

From<EMAIL_ADDRESS>on 2011-09-06T22:01:52Z
I don't mind creating pull requests, but being a committer saves everybody's time for trivial fixes. Thanks.

From pierre.raybaut on 2011-09-06T08:17:33Z
I really like it.
I'm merging this with the default repo.
BTW, I'm inviting you to be a project member. In the future, you may commit to the main repository when your changes are tested/mature enough.
Status: Fixed


Support Makie’s modern interface – removed explicit references to AbstractPlotting and MakieLayout

Remove explicit references to the AbstractPlotting and Makie Layout modules inside makie as they are removed since Makie version 0.13.
I check the changes against Makie 0.13.4 and 0.14.2.
Compilation wise it was fine but i did notice some weird changes in Makie's scaling of objects. Rays with scale factor of 0.2 appear bigger then everything in the scene. Will need to handle it when we upgrade to a newer Makie.

Codecov Report

Merging #214 (f1b616c) into main (da018bc) will decrease coverage by 0.89%.
The diff coverage is 18.27%.

@@            Coverage Diff             @@
##             main     #214      +/-   ##
==========================================
- Coverage   56.58%   55.68%   -0.90%
==========================================
  Files          67       65       -2
  Lines        6366     6318      -48
==========================================
- Hits         3602     3518      -84
- Misses       2764     2800      +36

Impacted Files
Coverage Δ

src/NotebooksUtils/NotebooksUtils.jl
0.00% <0.00%> (ø)

src/Vis/Emitters.jl
0.00% <0.00%> (ø)

src/Vis/Visualization.jl
6.22% <18.84%> (+0.10%)
:arrow_up:

src/OpticSim.jl
90.90% <100.00%> (+2.02%)
:arrow_up:

src/Vis/Vis.jl
100.00% <100.00%> (ø)

src/Geometry/Primitives/Qtype.jl
75.00% <0.00%> (-8.34%)
:arrow_down:

src/Optical/LensAssembly.jl
48.22% <0.00%> (-7.95%)
:arrow_down:

src/Optical/Emitters/Emitters.jl
75.00% <0.00%> (-5.00%)
:arrow_down:

src/Optical/OpticalInterface.jl
63.23% <0.00%> (-4.30%)
:arrow_down:

src/Geometry/CSG/Intersection.jl
48.57% <0.00%> (-2.14%)
:arrow_down:

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da018bc...f1b616c. Read the comment docs.


vscode-extensions.iciclesoft.workspacesort: init at 1.6.0

Motivation for this change
Continuing on my quest to add in the vscode extensions I use.
This one sorts the workspace folders alphabetically.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:

vscode-extensions.iciclesoft.workspacesort

Result of nixpkgs-review pr 119889 at bd6b8968 run on x86_64-linux 1

1 package built successfully:

vscode-extensions.iciclesoft.workspacesort

3 suggestions:

warning: missing-phase-hooks
configurePhase should probably contain runHook preConfigure and runHook postConfigure.
Near pkgs/misc/vscode-extensions/vscode-utils.nix:21:12:
   |
21 |     inherit configurePhase buildPhase dontPatchELF dontStrip;
   |            ^

warning: build-tools-in-build-inputs
unzip is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/misc/vscode-extensions/vscode-utils.nix:25:5:
   |
25 |     buildInputs = [ unzip ] ++ buildInputs;
   |     ^

warning: missing-phase-hooks
buildPhase should probably contain runHook preBuild and runHook postBuild.
Near pkgs/misc/vscode-extensions/vscode-utils.nix:21:12:
   |
21 |     inherit configurePhase buildPhase dontPatchELF dontStrip;
   |            ^


Cannot use config file if DATABASE_URL env var is set.

I know what you are going to say, "don't set DATABASE_URL".
However I am deploying to a digital ocean app (their platform as a service). And they automatically set an environment variable of DATABASE_URL.
Basically, what I am requesting, is a way to use the config (for me, I want to configure the tables and functions accessible to martin) while the DATABASE_URL env var exists.
Maybe we add a way to ignore the DATABASE_URL environment variable; be it with a flag or an entry in the config file, or some other creative way.
Or maybe you fine fine developers have other ideas on an implementation.
Anyway, hopefully you all agree that this is worth fixing, or augmenting.
Thanks a bunch,
Patrick

Well, we could officially stop supporting env vars...

I have zero rust experience and a very busy December, but I can try and putt away at it. I wouldn't be able to commit to a deadline.
At minimum I would be happy to do the documentation if someone else gets to the code. But it would be kind of fun to do.

sounds good!

I just created #1052 to track it.  Lets close this to avoid confusion.


Require CMake 3.5.1; upgrade Google Benchmark to 1.5.0

CMake 3.5.1 is the version required by the latest versions of gRPC and Google Benchmark. See discussion google/benchmark#613.
Remove version check around find_package(XCTest).
Also, add a dependency on objc protos that was missing but somehow implicitly being added before.
#no-changelog

Ignoring Xcode 10.2 failures based on #4254.


DaemonSet - schedule the DaemonSet Pods on Nodes that run GameServers

In case of multiple Node Pools, how can we update DaemonSet to be scheduled only on the Node Pools that have Game Servers? we can do that by using Node Selectors https://kubernetes.io/docs/concepts/workloads/controllers/daemonset/#running-pods-on-select-nodes
We should document that.

This should be aligned with #74


Consent Updates

This branch makes implements the following changes to the consent and onboarding process:

Update graphics and animation for "We'll Test Your Understanding" screen
Update UI and copy for "What to Expect" screen
Use a tutorial alert instead of "All Set!" screen

@jakekrog
Please resubmit with only the tutorial changes.

Since it appears this PR cannot be accepted, I will close it later tonight.


Confirm/determine programming libraries used for QR code/barcode/link selection

Consider programming requirements for both Android and iOS.
Thinking it's just google vision for the barcodes/QR, but possibly look into other libraries that aren't paid.
Document findings of approaches considered, and why they should be selected or excluded as we need this information in the TDD. Place findings in the documents as a draft, no need for extensive polishing within this task. Some content may be moved out later to the Programmers Guide.
Additionally, if implementation appears to be simple, developing a proof of concept (or locating an existing one built by someone else) would also be great for our next presentation.

I have placed a file describing libraries for this this in the team A milestone 2 folder


DP-1184 Type before comment does not cause retokenizing

One-commit version of https://github.com/JetBrains/jetpad-projectional/pull/254.

Looks good to me. I don't see an explicit OK from @katepol so I won't merge now. I will leave it for @katepol.

@aleksei-berezkin have you thought of proceeding without DerivedEvent class?

@katepol Probably it will be useful for me in future, have some plans. If not, I'll get rid of it.


vmagent:add validation when generate static scrape config

fix https://github.com/VictoriaMetrics/operator/issues/665

Thanks for contribution!


Epic Family update

Consult https://github.com/RoyaleAPI/cr-api-ux/wiki/Family-Config for detailed description of all the fields. Here are some tips:

color: should be all lower case
key: will be used in the URL. Convention is to use all lower case
emblem: do not include the file extension .png
description and links: delete the lines if you have none
tag:  do not include the # hash tag with the clan tags

Fill in the configuration below:
name: -Epic- Clan Family
key: epic
color: black
emblem: Skull_03
sort: trophy
info:
description: >
Epic is family of 5 clans in New Zealand but with members
from around the world.  We all share a passion for the game,
we’re a friendly bunch with a happy vibe. The Epic way is
about both casual and competitive playing styles
and we value both. Show us what you got.
clans:
 - name: -Epic-
   tag: LGGVV
 - name: -Epic- Thunder
   tag: 2U0QJLQR
 - name: -Epic- Bootcamp
   tag: P8UJG9L
 - name: -Epic- Empire
   tag: Y0Q9VLYC
 - name: -Epic- Adventure
   tag: YYVLGQG0
 - name: -Epic- Victory
   tag: #LVGRUUJL
…

Have edited 'key' to supported format. Added a 6th clan -Epic- Victory


[backport 1.3] [FLINK-6612] Allow ZooKeeperStateHandleStore to lock created ZNodes

Backport of #3939 onto the release-1.3 branch.
In order to guard against deletions of ZooKeeper nodes which are still being used
by a different ZooKeeperStateHandleStore, we have to introduce a locking mechanism.
Only after all ZooKeeperStateHandleStores have released their lock, the ZNode is
allowed to be deleted.
THe locking mechanism is implemented via ephemeral child nodes of the respective
ZooKeeper node. Whenever a ZooKeeperStateHandleStore wants to lock a ZNode, thus,
protecting it from being deleted, it creates an ephemeral child node. The node's
name is unique to the ZooKeeperStateHandleStore instance. The delete operations
will then only delete the node if it does not have any children associated.
In order to guard against oprhaned lock nodes, they are created as ephemeral nodes.
This means that they will be deleted by ZooKeeper once the connection of the
ZooKeeper client which created the node timed out.

Merged in f58fec70fef12056bd58b6cc2985532ccb07625e


Add x-commit-hash field to the opam file when releasing

We should incorporate the commit hash in the metadata of the package when releasing, in addition to make things easier to reproduce (tags aren't always handled as seriously as they should) it will help other git based tools to pull in the right source tree, in particular it will be very useful for duniverse!

Closed by #224


iOS Project AppStore Connect latest_testflight_build_number return wrong version string

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description

My Xcode Project / info.plist for version string seems like this (not short version string) <IP_ADDRESS> for example. Until now i upload my apps manually. Currently I am on <IP_ADDRESS> successfully uploaded app to TestFlight. Now I am on automating the distribution to Test Flight. But the latest_testflight_build_number retrieves me <IP_ADDRESS> instead of <IP_ADDRESS>
Some one have experience with this problem?
Command executed

  latest_build_version = latest_testflight_build_number(version: version,
                                                        username: "xxxx",
                                                        team_id: team_id_value,
                                                        app_identifier:app_id_value,
                                                        initial_build_number: (version + "0"))

Complete output when running fastlane, including the stack trace and command used

 [10:32:45]: fastlane detected a Gemfile in the current directory
[10:32:45]: however it seems like you don't use `bundle exec`
[10:32:45]: to launch fastlane faster, please use
[10:32:45]:
[10:32:45]: $ bundle exec fastlane jenkins_build_single scheme:XXXXX method:app-store config:XXXXX
[10:32:45]:
[10:32:45]: Get started using a Gemfile for fastlane https://docs.fastlane.tools/getting-started/ios/setup/#use-a-gemfile
[10:32:45]: ------------------------------
[10:32:45]: --- Step: default_platform ---
[10:32:45]: ------------------------------
[10:32:45]: Driving the lane 'ios jenkins_build_single' 🚀
[10:32:45]: ---------------------------------------------------------------------------------------------------------
[10:32:45]: --- Step: /usr/libexec/PlistBuddy -c PRINT\ :CFBundleShortVersionString ../XXXXX/XXX/Info.plist ---
[10:32:45]: ---------------------------------------------------------------------------------------------------------
[10:32:45]: $ /usr/libexec/PlistBuddy -c PRINT\ :CFBundleShortVersionString ../XXXX/XXXX/Info.plist
[10:32:45]: ▸ 6.2.19
[10:32:45]: Brand:   XXXXX
[10:32:45]: Method:  aXXXXX
[10:32:45]: Version: XXXXX
[10:32:45]: Config:  XXXX
[10:32:45]: ------------------------
[10:32:45]: --- Step: git_branch ---
[10:32:45]: ------------------------
[10:32:45]: BranchName: XXXXXXX
[10:32:45]: App_id: XXXXXX
[10:32:45]: --------------------------------
[10:32:45]: --- Step: clear_derived_data ---
[10:32:45]: --------------------------------
[10:32:45]: Derived Data path located at: /Users/XXXX/Library/Developer/Xcode/DerivedData
[10:32:45]: Successfully cleared Derived Data ♻
[10:32:45]: Latest TestFlight Build number with following parameters:
[10:32:45]: version:   6.2.19
[10:32:45]: team_id:  XXXXX
[10:32:45]: app_identifier: XXXXX
[10:32:45]: --------------------------------------------
[10:32:45]: --- Step: latest_testflight_build_number ---
[10:32:45]: --------------------------------------------
[10:32:45]: Login to App Store Connect (xxxxxxxxx)
[10:32:47]: Login successful
[10:32:47]: Fetching the latest build number for version 6.2.19
[10:32:48]: Latest upload for version 6.2.19 is build: <IP_ADDRESS>
[10:32:48]: 6
[10:32:48]: 2
[10:32:48]: 19
[10:32:48]: 0
[10:32:48]: Build Version: <IP_ADDRESS>
[10:32:48]: ------------------------------------
[10:32:48]: --- Step: increment_build_number ---
[10:32:48]: ------------------------------------

Environment

✅ fastlane environment ✅
Stack

Key
Value

OS
10.14.6

Ruby
2.3.7

Bundler?
false

Git
git version 2.20.1 (Apple Git-117)

Installation Source
/usr/local/bin/fastlane

Host
Mac OS X 10.14.6 (18G87)

Ruby Lib Dir
/System/Library/Frameworks/Ruby.framework/Versions/2.3/usr/lib

OpenSSL Version
LibreSSL 2.6.5

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
10.3

System Locale

Variable
Value

LANG
de_DE.UTF-8
✅

LC_ALL

LANGUAGE

fastlane files:

This issue will be solved with this PR
https://github.com/fastlane/fastlane/pull/14872/commits/d71921c6d21d731815d832489f31e51b59d31c09


Improvement to return type of useMouse

I noticed that the return type of useMouse isn't exactly reflective of the data returned.
If we made it shaped more like this:
export type MousePosition = MousePositionOver | MousePositionOut

type MousePositionOver = {
  x: number
  y: number
  pageX: number
  pageY: number
  clientX: number
  clientY: number
  screenX: number
  screenY: number
  elementWidth: number
  elementHeight: number
  isOver: true
  isDown: boolean
  isTouch: boolean
}

type MousePositionOut = {
  x: undefined
  y: undefined
  pageX: undefined
  pageY: undefined
  clientX: undefined
  clientY: undefined
  screenX: undefined
  screenY: undefined
  elementWidth: undefined
  elementHeight: undefined
  isOver: false
  isDown: false
  isTouch: boolean
}

This preserve additional type information since, if you check that mouseData.isOver is true, the inside of that conditional will see all the values as numbers and not have to check each property individually.
Also, if we switch from null to undefined for the missing values, you can use default values during destructuring:
const { x = 0, y = 0, isOver } = useMouse(ref)

The change from null to undefined would be breaking, so if you prefer we could put off merging that until a planned major version bump, but the rest should be safe.

This sounds good to me!

Hey, so while trying to modify the hook, I noticed a few things that might be an issue.
First, on line 32, element.getBoundingClientRect is being called inside a reducer which breaks the semantics and guarantees of reducers.
Information should never be retrieved from non-deterministic sources inside a reducer. Their output should be a pure function of their input. Same for any instances of getting properties of window inside the reducer.
All of that information should be passed into the reducer via the action, not retrieved directly inside it. It will produce very strange results if anyone tries to use react time-travel debugging on that reducer, and memoization/caching will also fail to work correctly.
I can't add those more specific return types because the way the code is currently written, there is no guarantee that the pointer position (or any other information) will be present in the state when the pointer is over the element. I think this hook may need a significant amount of re-writing before we can make statements about it's return types with any certainty.


Modularize OBJLoader

Did this one as a test to make sure I was understanding what you were up to (also because this is the first of these examples that I want to use), please review.
I could probably do a bunch more of these.  Maybe I could even whip up a python script to do some automated regexp search-n-replace and add the "export" line to files.  Seems repetitive enough that it could be automated, and there are quite a few files to go through.

Note: On my first commit I thought I was done because the OBJLoader example was working.  But when I went to use this OBJLoader from my own Typescript project I realized I had more work to do because I was getting a bunch of THREE is not defined runtime errors that the sample did not get, hence the second commit where I removed a bunch more occurrences of THREE.
So the way that both of us had changed the HTML to look something like this, might not be the best test of whether we are successfully modularizing it:
		<script src="../build/three.js"></script>

		<script type="module">

			import {OBJLoader} from "./jsm/loaders/OBJLoader.js";

because it seems in this case the OBJLoader.js still has access to the global variable THREE.  Maybe need to set up the demos to bring in three.js with an import as well in order to prevent the "example" code from having access to THREE in order to do a true test?


Screenshots are outdated.

[The screenshots needs update to show eventhub based actions]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6b4942cb-cb22-7ef0-d78c-c5967a879d2d
Version Independent ID: 6eb84072-fa26-7434-5376-9c5a901cedff
Content: Manage action groups in the Azure portal - Azure Monitor
Content Source: articles/azure-monitor/alerts/action-groups.md
Service: azure-monitor
Sub-service: alerts
GitHub Login: @dkamstra
Microsoft Alias: dukek

@anoobbacker, thank you for bringing it to our attention. I am assigning it to our content team for review and update.
@dkamstra, can you please review the screenshots under Configure actions and update it with the one showing Event Hub action type.

#re-assign: @AbbyMSFT

#reassign: @jacegummersall

Hi @anoobbacker,
We appreciate your comments and your dedication to the quality of our documentation.
The screenshot has been updated.
Please feel free to continue to send feedback!
Thanks,
Abby
#please-close


[Portal] Missing Docs & General Confusion

I've been trying to figure out how to use Portal.js (since there's no official docs, yet)
https://github.com/facebook/react-native/blob/master/Libraries/Portal/Portal.js
now although the comment at the top says:
* Never use `<Portal>` in your code. There is only one Portal instance rendered
* by the top-level `renderApplication`.

if I don't render <Portal> I get: Calling showModal but no Portal has been rendered.
from reading the docs, it sounds like <Portal> is being auto-rendered somehow...
it is still unclear to me if I should be using Portal at all...
it doesn't seem to be integrated with Modal - which seems to offer a nicer interface...
in any case;
after tinkering around for a bit, I got an example working, if anyone's interested:
import React from 'react-native';
const { View, StyleSheet, AppRegistry } = React;

import Portal from 'react-native/Libraries/Portal/Portal';

import MainAppView from './MyApp/MainAppView';

class MyPortalExample extends React.Component {

  componentDidMount() {
    const tag = Portal.allocateTag();

    setTimeout( ()=> {

      Portal.showModal(tag, this._modalComponent());

    }, 1000);

    setTimeout( ()=> {

      Portal.closeModal(tag);

    }, 2000);
  }

  _modalComponent() {
    return (<View style={styles.modal} />);
  }

  render() {
    const MainAppView = (<View/>); // load what ever you need
    return (
      <View style={styles.screen}>

        <MainAppView />

        <Portal />
      </View>
    );
  }
}

const styles = StyleSheet.create({

  screen: {
    flex: 1,
    // needed since the <Portal> modalsContainer style is using `position: 'absolute'`
    backgroundColor: 'transparent'
  },

  modal: {
    width: 200,
    height: 200,
    backgroundColor: 'rgba(255,255,255, 0.5)'
  }
});

AppRegistry.registerComponent('MyPortalExample', () => MyPortalExample);

am I using it correctly?

Sorry this is confusing, but Portal is only used in Android right now which hasn't been released yet.
Any reason to not just use Modal?

I've put up D2397933 internally to add a comment to this effect.  If you can't do what you want with <Modal>, please open a new issue.

Portal is only used in Android right now

can you elaborate why?

Basically because Android didn't have a need for a native version because we weren't doing any hybrid apps yet.
The native version that  uses on iOS is better because it let's the modal cover the entire screen, whereas in a hybrid native/ReactNative app where the ReactNative view might just be some fraction of the screen (e.g. if you have a native nav bar or header that renders a ReactNative root view), then the RN rootView can't render outside its bounds (i.e. render on top of the nav bar) using pure JS (e.g. , which is why we created a native modal component to get around that.

Can we please get this documented properly?  There is huge demand for something like this for Android https://github.com/brentvatne/react-native-overlay

Check this out! https://github.com/niftylettuce/react-native-loading-spinner-overlay


Possible to combine scenarios with Google Sheets test cases?

I'm trying to combine scenarios with google sheets for the test cases. Is this supported? If so, is there something wrong with my syntax? The below causes the following error:
scenarios:
  - config:
      - vars:
          csvFilePath: industries.csv
      - vars:
          csvFilePath: industries-with-descriptions.csv
    tests: https://docs.google.com/spreadsheets/d/1OsJDtkyshJVzOp-iw_ZAEbM2ZflNHEqIbpo/edit?usp=sharing

npx promptfoo@latest eval
TestSuite Schema Validation Error:

  {"_errors":[],"scenarios":{"0":{"_errors":[],"tests":{"_errors":["Expected array, received string"]}},"_errors":[]}}

Please review your promptfooconfig.yaml configuration.
/Users/jedidiah/.npm/_npx/81bbc6515d992ace/node_modules/promptfoo/dist/src/evaluator.js:388
                    ]).map((test) => {
                       ^

TypeError: (scenario.tests || [{}]).map is not a function
    at Evaluator.evaluate (/Users/jedidiah/.npm/_npx/81bbc6515d992ace/node_modules/promptfoo/dist/src/evaluator.js:388:24)
    at evaluate (/Users/jedidiah/.npm/_npx/81bbc6515d992ace/node_modules/promptfoo/dist/src/evaluator.js:806:15)
    at runEvaluation (/Users/jedidiah/.npm/_npx/81bbc6515d992ace/node_modules/promptfoo/dist/src/commands/eval.js:114:56)
    at async doEval (/Users/jedidiah/.npm/_npx/81bbc6515d992ace/node_modules/promptfoo/dist/src/commands/eval.js:240:5)

Node.js v20.10.0

Thanks for flagging - This is unsupported right now

Got it. Thank you 🙏🏻


Code folding icon is blurry

Godot version
4.0alpha1
System information
Windows 10, GLES3,  NVIDIA Quadro P2000
Issue description

The code-folding icon is a bit blurry compared to 3.x versions. Code font size is 18 in both screenshots, the upper one is 3.4.2 and 4.0alpha1 is below. It gets even worse the bigger number you set the code font size(image below). It doesn't happen in 3.4.2 stable.

I guess it's because Godot 4.0alpha1 uses a bigger sprite on it? I'm unsure if it should be called a bug, but I'm not comfortable with this, and I believe there are some people who think the same way. I'd like it to be fixed, or to have an option to get around rather than just disabling Code Folding.
Steps to reproduce
You can reproduce the issue by just downloading 3.4.2 and 4.0alpha1 with no settings modified. To be precise, I edited 3.4.2's Text Editor Highlighting in the screenshot, but I don't think it affects the problem in any way
Minimal reproduction project
No response

The icon is now scaled to fit the line height, which is a good thing when using zoom at run-time. You can notice this isn't being done for the indentation symbols, which results in them being too small.
To fix this, we can design the code folding SVG icon at double its original size.


Fix IndexOutOfBoundsException in the KeyShared subscription when dispatching messages to consumers

Fixes #7941
Motivation
Fix IndexOutOfBoundsException in the KeyShared subscription when dispatching messages to consumers
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)

Documentation

Does this pull request introduce a new feature? (no)

/pulsarbot run-failure-checks


Set thread cpu time in setExecutionStatistics()

Description
This PR remove a TODO: put thread cpu time setting logic in setExecutionStatistics()
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)

[ ] Yes (Please label as backward-incompat, and complete the section below on Release Notes)

Does this PR fix a zero-downtime upgrade introduced earlier?

[ ] Yes (Please label this as backward-incompat, and complete the section below on Release Notes)

Does this PR otherwise need attention when creating release notes? Things to consider:

New configuration options
Deprecation of configurations
Signature changes to public methods/interfaces
New plugins added or old plugins removed

[ ] Yes (Please label this PR as release-notes and complete the section on Release Notes)

Release Notes
If you have tagged this as either backward-incompat or release-notes,
you MUST add text here that you would like to see appear in release notes of the
next release.
If you have a series of commits adding or enabling a feature, then
add this section only in final commit that marks the feature completed.
Refer to earlier release notes to see examples of text
Documentation
If you have introduced a new feature or configuration, please add it to the documentation as well.
See https://docs.pinot.apache.org/developers/developers-and-contributors/update-document

Codecov Report

Merging #6711 (24dd71f) into master (1beaab5) will decrease coverage by 22.99%.
The diff coverage is 42.85%.

@@             Coverage Diff             @@
##           master    #6711       +/-   ##
===========================================
- Coverage   66.44%   43.45%   -23.00%
===========================================
  Files        1075     1390      +315
  Lines       54773    67511    +12738
  Branches     8168     9783     +1615
===========================================
- Hits        36396    29338     -7058
- Misses      15700    35720    +20020
+ Partials     2677     2453      -224

Flag
Coverage Δ

integration
43.45% <42.85%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ot/broker/broker/AllowAllAccessControlFactory.java
100.00% <ø> (ø)

...t/broker/broker/BasicAuthAccessControlFactory.java
0.00% <0.00%> (ø)

.../helix/BrokerUserDefinedMessageHandlerFactory.java
52.83% <0.00%> (-13.84%)
:arrow_down:

...org/apache/pinot/broker/queryquota/HitCounter.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...che/pinot/broker/queryquota/MaxHitRateTracker.java
0.00% <0.00%> (ø)

...ache/pinot/broker/queryquota/QueryQuotaEntity.java
0.00% <0.00%> (-50.00%)
:arrow_down:

...ker/routing/instanceselector/InstanceSelector.java
100.00% <ø> (ø)

...ceselector/StrictReplicaGroupInstanceSelector.java
0.00% <0.00%> (ø)

...roker/routing/segmentpruner/TimeSegmentPruner.java
0.00% <0.00%> (ø)

...roker/routing/segmentpruner/interval/Interval.java
0.00% <0.00%> (ø)

... and 1418 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27b61fe...24dd71f. Read the comment docs.


[SPARK-48574][SQL] Fix support for StructTypes with collations

What changes were proposed in this pull request?
Fix for ExtractValue expression
Why are the changes needed?
This fix is needed in case we change default collation.
Does this PR introduce any user-facing change?
Yes, it fixes a problem.
How was this patch tested?
Added tests in CollationSQLExpressionsSuite.scala
Was this patch authored or co-authored using generative AI tooling?
No.

@cloud-fan This is ready for merge now. Resolved conflicts of test oredering in CollationSQLExpressionsSuite.

@HyukjinKwon could we merge this change in?

Merged to master, thank you @mihailom-db

late LGTM


Systemd Unit Fails to Read Config

Current Behavior
Using systemctl start openvpn-auth-oauth2 on the provided .deb package on Ubuntu 24.04, the following logs appear in systemctl status openvpn-auth-oauth2:
Jul 11 15:53:42 vpn-host systemd[1]: Started openvpn-auth-oauth2.service - OpenVPN authenticator.
Jul 11 15:53:42 vpn-host openvpn-auth-oauth2[345675]: time=2024-07-11T15:53:42.733Z level=ERROR msg="error loading config: validation error: oauth2.client.id is required"

Starting the service manually as nobody with the appropriate supplemental group works, however:
nobody@vpn-host:/$ openvpn-auth-oauth2 --config /etc/openvpn-auth-oauth2/config.yaml
time=2024-07-11T16:06:37.408Z level=INFO msg="discover oidc auto configuration with provider generic for issuer https://login.microsoftonline.com/[REDACTED]/v2.0"
time=2024-07-11T16:06:37.702Z level=INFO msg="start HTTP server listener on :9000"
time=2024-07-11T16:06:37.702Z level=INFO msg="connect to openvpn management interface unix:///run/openvpn.sock"
time=2024-07-11T16:06:37.703Z level=INFO msg="openvpn-auth-oauth2 started with base url https://vpn-host.[REDACTED]:443"
time=2024-07-11T16:06:37.703Z level=INFO msg="connection to OpenVPN management interface established."
time=2024-07-11T16:06:37.704Z level=INFO msg="OpenVPN Version: OpenVPN 2.6.9 x86_64-pc-linux-gnu [SSL (OpenSSL)] [LZO] [LZ4] [EPOLL] [PKCS11] [MH/PKTINFO] [AEAD] [DCO] - Management Version: 5"

Despite the failure to load config, it is opening the file and parsing it correctly, as different errors occur when the file does not exist:
Jul 11 15:53:07 vpn-host openvpn-auth-oauth2[345589]: time=2024-07-11T15:53:07.222Z level=ERROR msg="error loading config: file provider: open /etc/openvpn-auth-oauth2/test.yaml: no such file or directory"

or when the file is not syntactically-valid YAML:
Jul 11 16:01:30 vpn-host openvpn-auth-oauth2[346569]: time=2024-07-11T16:01:30.130Z level=ERROR msg="error loading config: file provider: yaml: did not find expected comment or line break"

Expected Behavior
The systemd unit should start and run successfully.
Steps To Reproduce
The instructions are a Chef cookbook, but to approximate:

1. On AWS, provision a Ubuntu 24.04 host with necessary resources (e.g. a login with `sudo`), and shell in;
2. `sudo apt install openvpn`;
3. `wget https://github.com/jkroepke/openvpn-auth-oauth2/releases/download/v1.21.4/openvpn-auth-oauth2_1.21.4_linux_amd64.deb` and `sudo dpkg -i openvpn-auth-oauth2_1.21.4_linux_amd64.deb`;
4. Configure [as per the wiki](https://github.com/jkroepke/openvpn-auth-oauth2/wiki/Configuration) using the YAML config file in the unit's recommended location of `/etc/openvpn-auth-oauth2/config.yaml`, and set the appropriate group/mode (note some minor variation, such as `/run/openvpn.sock`--this doesn't seem material to this bug, however);
5. `sudo systemctl start openvpn` (and validate a successful config);
6. `sudo systemctl start openvpn-auth-oauth2`.

Environment

openvpn-auth-oauth2 Version:

version: 1.21.4
commit: 8c8a89455ee81c90bd6236124617cc202d05f065
date: 2024-07-01T20:14:23Z
go: go1.22.4

OpenVPN Server Version:

OpenVPN 2.6.9 x86_64-pc-linux-gnu [SSL (OpenSSL)] [LZO] [LZ4] [EPOLL] [PKCS11] [MH/PKTINFO] [AEAD] [DCO]
library versions: OpenSSL 3.0.13 30 Jan 2024, LZO 2.10
DCO version: N/A
Originally developed by James Yonan
Copyright (C) 2002-2023 OpenVPN Inc<EMAIL_ADDRESS>Compile time defines: enable_async_push=no enable_comp_stub=no enable_crypto_ofb_cfb=yes enable_dco=yes enable_dco_arg=yes enable_debug=yes enable_dependency_tracking=no enable_dlopen=unknown enable_dlopen_self=unknown enable_dlopen_self_static=unknown enable_fast_install=needless enable_fragment=yes enable_iproute2=no enable_libtool_lock=yes enable_lz4=yes enable_lzo=yes enable_maintainer_mode=no enable_management=yes enable_option_checking=no enable_pam_dlopen=no enable_pedantic=no enable_pkcs11=yes enable_plugin_auth_pam=yes enable_plugin_down_root=yes enable_plugins=yes enable_port_share=yes enable_selinux=no enable_shared=yes enable_shared_with_static_runtimes=no enable_silent_rules=no enable_small=no enable_static=yes enable_strict=no enable_strict_options=no enable_systemd=yes enable_unit_tests=no enable_werror=no enable_win32_dll=yes enable_wolfssl_options_h=yes enable_x509_alt_username=yes with_aix_soname=aix with_crypto_library=openssl with_gnu_ld=yes with_mem_check=no with_openssl_engine=auto with_sysroot=no

Server OS:

Distributor ID:	Ubuntu
Description:	Ubuntu 24.04 LTS
Release:	24.04
Codename:	noble
Linux vpn-host 6.8.0-1009-aws #9-Ubuntu SMP Fri May 17 14:39:23 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

OpenVPN Client (flavor, OS): various
OIDC Provider: Entra ID

openvpn-auth-oauth2 logs
Jul 11 15:53:30 vpn-host systemd[1]: Started openvpn-auth-oauth2.service - OpenVPN authenticator.
Jul 11 15:53:30 vpn-host openvpn-auth-oauth2[345640]: time=2024-07-11T15:53:30.193Z level=ERROR msg="error loading config: validation error: oauth2.client.id is required"
Jul 11 15:53:30 vpn-host systemd[1]: openvpn-auth-oauth2.service: Main process exited, code=exited, status=1/FAILURE
Jul 11 15:53:30 vpn-host systemd[1]: openvpn-auth-oauth2.service: Failed with result 'exit-code'.

openvpn server logs
(For some reason, OpenVPN doesn't appear to be logging to the usual location. Nevertheless, I can confirm a full end-to-end test works with my OpenVPN client when `openvpn-auth-oauth2` is running as root.)

Anything else?
Let me know if you need any further information :)

Let me know if you need any further information :)

Any results, if you run

dmesg | grep audit | grep openvpn-auth-oauth2

as root?

Let me know if you need any further information :)

Any results, if you run

dmesg | grep audit | grep openvpn-auth-oauth2

as root?

Exactly nothing. I forgot to mention, as part of minor config variance, that I did install an apparmor local policy, /etc/apparmor.d/local/usr.bin.openvpn-auth-oauth2:
/etc/openvpn/pki/* r,
/run/openvpn.sock rw,

(For TLS certificates in the testing config and the OpenVPN socket itself. The former is actually no longer required, and I might evict it soon.)

apparmor local policy

should the /etc/openvpn-auth-oauth2 path not included?

apparmor local policy

should the /etc/openvpn-auth-oauth2 path not included?

Oh, that's included from the base policy:
root@vpn-host:~# cat /etc/apparmor.d/usr.bin.openvpn-auth-oauth2
# vim:syntax=apparmor

abi <abi/3.0>,

include <tunables/global>

/usr/bin/openvpn-auth-oauth2 flags=(attach_disconnected) {
  include <abstractions/base>
  include <abstractions/nameservice>

  @{etc_ro}/openvpn-auth-oauth2/** r,

  @{run}/openvpn{,-server}/* rw,

  @{sys}/kernel/mm/{hugepages,transparent_hugepage}/{,**} r,

  # Site-specific additions and overrides. See local/README for details.
  include if exists <local/usr.bin.openvpn-auth-oauth2>
}

I'm assuming that was installed by the package, and does include @{etc_ro}/openvpn-auth-oauth2/** r :)
That's indeed necessary--per recommendation, I broke out some of the secrets into restrictively-moded files in /etc/openvpn-auth-oauth2, and refer to them using file:// URLs (with absolute paths).

I guess the issue must be in some of the over-engineered systemd properties that I had enabled. systemd uses namespaces and secomp to restrict file access.

I'll happily await some tests; if you need this system to test some theories/fixes, I proffer it :)
Good luck!

I'll happily await some tests; if you need this system to test some theories/fixes, I proffer it :)
Good luck!

While I have access to free resources at Azure (e.g. VMs), I in vacation at least for one week until next saturday.

no worries, then, take your time :)
In the meantime, these servers are merely running the daemon as an unprivileged user in a tmux session--it'll hold out for a little while.

Guess comment this lines out
https://github.com/jkroepke/openvpn-auth-oauth2/blob/8c8a89455ee81c90bd6236124617cc202d05f065/packaging/usr/lib/systemd/system/openvpn-auth-oauth2.service#L34-L62
should also resolve the issue for now

I actually tracked this down to an issue unrelated to permissions at all: it's the EnvironmentFile shipped with the project :)
# This file is sourced by the openvpn-auth-oauth2.service

# CONFIG_FILE is the path to the configuration file and used in the systemd service file only.
CONFIG_FILE=/etc/openvpn-auth-oauth2/config.yaml

# https://github.com/jkroepke/openvpn-auth-oauth2/wiki/Configuration

CONFIG_OPENVPN_ADDR=unix:///run/openvpn/server.sock
CONFIG_OAUTH2_ISSUER=https://login.microsoftonline.com/<tenant-id>/v2.0
CONFIG_OAUTH2_CLIENT_ID=
CONFIG_OAUTH2_CLIENT_SECRET=
CONFIG_HTTP_LISTEN=:9000
# Define a random value with 16 or 24 characters
CONFIG_HTTP_SECRET=
# Define the public http endpoint here.
CONFIG_HTTP_BASEURL=http://localhost:9000

Note that env vars are loaded later than config, meaning the former overrides the latter. That means this example skeleton config, with invalid values, unexpectedly overrides the user's config.yaml in the default configuration. (As I wasn't about to use env vars, I didn't even bother to check this file.)
The easy workaround, of course, is to just comment out the lines--and it might be preferable if upstream did so, both so they're there as examples that most users will use, and to avoid this precise footgun :)
After doing so, I tested the systemd unit without any systemd-level overrides, and it seems fine.

The easy workaround, of course, is to just comment out the lines

You are right, this should be comment out by default to avoid this scenario. Are you interested in a PR?


(Save to Github) is now working [BUG] !

Version: 0.30.1 (9th December 2021)

Performed Steps as per detailed installation guide:

create the git_repositories file
private/public key files exist within your /.ssh
defines the key/url mapping in /.ssh/config
write config file as the following

TCPKeepAlive yes

Host *
  ServerAliveInterval 240
  ServerAliveCountMax 2
  TCPKeepAlive yes
  AddKeysToAgent yes

Host github.com
  HostName github.com
  User git
  IdentityFile ~/.ssh/id_ed25519

- Steps to reproduce

Open OKIT designer
Save to Git
See entry of github and select it
write design json filename
Nothing saved to github repo !

I would appreciate any help or recommendations
@toxophilist
@scross01

@mahmoudrabie Following the save to git do you see it in the git tab on the left of the screen.
Also do you see any errors in the okit log file / docker console log.
Finally can you open a terminal connection to the docker container and confirm you can connect to github and clone your repo

Andrew,
Following your advice and checking the log I did see an error in the log.
Next, I attempted to connect to GitHub from the container command line
and receive the following:
bash-4.2# *ssh github*
The authenticity of host 'github.com (<IP_ADDRESS>)' can't be
established.
ECDSA key fingerprint is
SHA256:p2QAMXNIC1TJYWeIOttrVc98/R1BUFWu3/LiyKgUfQM.
ECDSA key fingerprint is
MD5:7b:99:81:1e:4c:91:a5:0d:5a:2e:2e:80:13:3f:24:ca.
Are you sure you want to continue connecting (yes/no)? *yes*
Warning: Permanently added 'github.com,<IP_ADDRESS>' (ECDSA) to the
list of known hosts.
PTY allocation request failed on channel 0

Hi philstepson! You've successfully authenticated, but GitHub does
not provide shell access.
Connection to github.com closed.

Seems like when there is an attempt to connect with a new fingerprint
for a unique instance of a container that we wouldn't see this message
to respond 'yes' to unless we are in the container itself.
Thanks,
Phil
Untitled Document **
Phil Stephenson
**
Saint Louis, MO US

On 12/10/21 7:50 AM, Andrew Hopkinson wrote:

@mahmoudrabie https://github.com/mahmoudrabie Following the save to
git do you see it in the git tab on the left of the screen.
Also do you see any errors in the okit log file / docker console log.
Finally can you open a terminal connection to the docker container and
confirm you can connect to github and clone your repo
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/oracle/oci-designer-toolkit/issues/507#issuecomment-990989793,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIBLSJIFS5BOL6CMZX3M33UQIAQ3ANCNFSM5JYLR6RQ.

Thanks a lot @toxophilist for your prompt response
I have checked the container log and found the following error
ERROR: Cmd('git') failed due to: exit code(128)

  cmdline: git clone --branch=main --no-single-branch -v git@github.com:mahmoudrabie/my-private-repo.git /okit/instance/git/github.com/my-private-repo

  stderr: 'Host key verification failed.

fatal: Could not read from remote repository.

Please make sure you have the correct access rights

and the repository exists.

'

Traceback (most recent call last):

  File "/okit/okitweb/okitWebDesigner.py", line 426, in git_panel

    repo = Repo.clone_from(url, git_repo_dir, branch=branch, no_single_branch=True)

  File "/usr/local/lib/python3.6/site-packages/git/repo/base.py", line 1032, in clone_from

    return cls._clone(git, url, to_path, GitCmdObjectDB, progress, multi_options, **kwargs)

  File "/usr/local/lib/python3.6/site-packages/git/repo/base.py", line 973, in _clone

    finalize_process(proc, stderr=stderr)

  File "/usr/local/lib/python3.6/site-packages/git/util.py", line 329, in finalize_process

    proc.wait(**kwargs)

  File "/usr/local/lib/python3.6/site-packages/git/cmd.py", line 408, in wait

    raise GitCommandError(self.args, status, errstr)

git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)

  cmdline: git clone --branch=main --no-single-branch -v git@github.com:mahmoudrabie/my-private-repo.git /okit/instance/git/github.com/my-private-repo

  stderr: 'Host key verification failed.

fatal: Could not read from remote repository.

Please make sure you have the correct access rights

and the repository exists.

'

I would appreciate your advice

@mahmoudrabie try adding the following to your ssh config
Host *
StrictHostKeyChecking no
UserKnownHostsFile=/dev/null

Thanks a lot, @toxophilist for your support
I have added the lines above and here is my config file

TCPKeepAlive yes
Host *
StrictHostKeyChecking no
UserKnownHostsFile=/dev/null
ServerAliveInterval 240
ServerAliveCountMax 2
TCPKeepAlive yes
AddKeysToAgent yes
Host github.com
HostName github.com
User git
IdentityFile ~/.ssh/id_ed25519

then I have restarted the okit container and found the following error before going to call (save to GitHub) function

ERROR: Cmd('git') failed due to: exit code(128)
cmdline: git clone --branch=main --no-single-branch -v git@github.com:mahmoudrabie/my-private-repo.git /okit/instance/git/github.com/my-private-repo
stderr: 'Host key verification failed.
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.

Any help or recommendations are more than welcome

@mahmoudrabie Did you do this  in the container if so a restart will erase it. You can edit your external file and rebuild

Thanks a lot @toxophilist for your support
I have completed the following steps again:
(1) Review and update the.ssh/known_hosts
(2) Update the .ssh/config (UserKnownHostsFile ~/.ssh/known_hosts)
(3) Generate a new SSH key
(4) Update .ssh/config with the new key
(5) Add the key using ssh-add
(6) Add the new SSH key to your GitHub account
(7) Test the successful connection to Github using the following commad (ssh -T<EMAIL_ADDRESS>Now, it is working fine


Time as Vertical Access

Any tips & level of difficulty getting this Kanban to be a scheduling board where:

The vertical access is time for each task
The cards have height proportional to the time the individual task takes
The columns will be for resources (in our case repair stations)

Resolved by laneSortFunction - https://github.com/rcdexta/react-trello#other-functions
Resolved by card.style  - https://github.com/rcdexta/react-trello/blob/master/stories/Styling.story.js#L86
Ok ;)

@dapi This is really good. Thanks a lot. Any idea how I can have a grid or some other way of representing the calendar days as a background, and allow folks to place cards at day/week boundaries even if there is a gap between the end of one task to the next?
(I suppose we could ask folks to put in a gap task, so that all the cards in a column remain adjacent) but it would still be good to have a Y-Axis label or background grid - that is some way indicated the calendar.)

@DrYSG hi!
Sorry for long time answering. Really I have no ideas


added support to freeze fns

fixes #80

@behrica Did you test this across restarts of your JVM?

My current example code has an other freeze / unfreeze issue, which forces me to delete the clerk cache on JVM start.
So I did not test it.

I tested with this code:
(ns test

  (:require [nextjournal.clerk :as clerk]
            [tablecloth.api :as tc]
            [nextjournal.clerk :as clerk]
            [nextjournal.clerk.hashing :as h]
            [weavejester.dependency :as dep]))

(comment
  (require '[com.rpl.nippy-serializable-fn])
  (clerk/clear-cache!)
  (clerk/serve! {:browse? true})
  (clerk/serve! {:watch-paths ["notebooks" "src"]}))

(defn my-fn [] nil)

(def b {:fn my-fn
        :y (do (println "slow") (Thread/sleep 10000) :a)})

and it worked.
After JVM restart, and (clerk/show! ...)  the "slow" did not get printed, and the evaluation was fast.
-> b came from cache

The test case you've made here uses a bound function of no arguments that doesn't make reference to any outside variables in its closure. For this to be a general solution, it would also need to work on (for example) anonymous functions that do close over bindings. The announcement blog post for the library you've added here includes, in the comments at the bottom, this quote:

All JVM instances that could end up deserializing a fn instance are required to be launched from the same precompiled jar
https://tech.redplanetlabs.com/2020/01/06/serializing-and-deserializing-clojure-fns-with-nippy/

Because of these limitations, I think we'll end up with a solution that uses in-memory caching for functions, but which does not try to write them to disk.

I took a stab at an alternative approach in #82. This does not change the types that nippy can serialize but instead fixes a but that Clerk did not use the already existing in-memory cache for results that were not freezable using nippy. this has the upside of working for any result (as you've noted, there's a lot more types besides Clojure functions that nippy will not serialize by default). Please let me know if this works for you.

Going to close this in favor of #82 for now. I'd like to better understand the limitations of this before considering it. Clerk's nippy cache is really meant to store results across for longer periods and across JVM restarts, conditions for which we know the guarantee that the code backing the functions must not change can certainly be violated.
That said, it's possible to bring in this dependency and play with this in users space without requiring modifications to Clerk and I encourage you or other folks to do this and report back.


Multifile compilation support and tinier output with --js option

Hi this patch does the following:
UPDATE : I just added namespacing for templates, based on the directory structure.
So you can have this structure:

templates
myTempl.coffee => this.templates["myTempl"] = ...

myModule
mySpecificTempl.coffee => this.templates["myModule"]["mySpecificTempl"] = ...

Allows compilation of all files in a directory producing a single file with only one instance of the skeleton boilerplate code. So you can do this coffeekup --js ./templates which yields a single 'templates.js' . The output file name is coming from the namespace option.

Watching is supported on all the contributing files.

Extract method refactoring on compiler ops inside coffeekup.coffee to eliminate duplication (and size)

Split internal method calls in cli.coffee to simplify

4a. Updated README to give examples of using the extended CLI and also added ./browser/examples/sugar to give you an idea the improvements

Had to fix the optsparser path from coffee-script to get it going...it's on the other pull requests too.

I just appended this request with support for hardcoded helpers from the CLI.
You can pass an -i path/to/helpers/directory and it will read in the file contents to include as 'hardcode' inside each template.
Check out the 'sugar' example. I updated docs to demonstrate this as well.

I was just about to open an issue for adding this. Beautiful, thank you so much.

Glad I could help! Let me know if you need help


README contains unclear explanation for meaning of SEQUENCING_REASON field

Responding to this question https://github.com/GenSpectrum/LAPIS/issues/328#issuecomment-1673295486, I noticed that the explanation of the sequencing reason appears to not be entirely clear:
For example: X (dem sequenzierenden Labor) doesn't make sense by itself, it might be that an unbekannt is missing
Also: "Grund für die Sequenzierung" appears not to match well with "Ja/Nein", maybe it is meant to say something like: "Targeted sequencing?" then "Ja/Nein" would make more sense:

Hallo @corneliusroemer,
thank you for your feedback.
You are entirely correct, and the 'unbekannt' got lost.
We will rework the documentation to correct this mistake and unclear description.
Best regrads
@HannesWuensche


Add links to docs an PyPI

A quick followup on #17.
The current docs don't link to the sourcecode or issue tracker in any way, and are a bit of a dead end in that sense.
Also link to the docs from PyPI.

Wow, that was fast, thanks!


Update to work with React Native 0.40

According to 0.40 release changelog a breaking change is introduced for iOS modules, needing a major version bump to work with this release.

Pull Requested #5
I've tested it in a new project using npm install from my branch, it worked!

Closed by merging https://github.com/taggon/react-native-intl/pull/5


Adds svgs icons

@smcgivern  can you review?

Looks good, I added two commits to tweak a couple of things.


Only allow proposals that have a path to be enacted

The hash protection scheme means we can only enact actions that were designed to be applied on top of the current one. We now want to additionally guarantee that all current proposals have a sequence of enactments that will get them enacted. This is what we need to do:

[x] Add allEnactable predicate and its decision procedure.
[x] Check that new proposals point to an existing proposal or the current state.
[ ] Remove proposals that become impossible to enact at the epoch boundary.
[ ] Prove that 'all proposals point at some previous proposal or the current state' is an invariant.

@WhatisRT I have completed the first two tasks.  I have questions about the other two.


[WIP] Digdag push validation on the server side.

Hello, @muga , @yoyama
Could you advise me how to implement a validation?
digdag push requires validation on the server side.
It requires two things at least. And this issue will Fix two issues.

task validation(#859).
schedule validation(#922).

I implement the first one. Second schedule validation seems to require SchedulerManager class.
https://github.com/hiroyuki-sato/digdag/commit/5004fb635e4ec598255f66593c45d7ab7f4ce5e6#diff-84a9dc43263ac1f78fa3b2aca8234f6fR576
I'm not familiar with Google Guice. I'm not sure how to instantiate it. Do you have any idea for that?
This code almost copies of digdag check code.
https://github.com/treasure-data/digdag/blob/master/digdag-cli/src/main/java/io/digdag/cli/Check.java
Best regards.

Hi @hiroyuki-sato, thank you for taking this improvement.

I'm not familiar with Google Guice. I'm not sure how to instantiate it. Do you have any idea for that?

ScheduleManager is already injected in digdag-server ServerModule. Please add the ScheduleManager parameter to the constructor in ProjectResource like WorkflowCompiler. Then, we can use the object in the class without the object creation explicitly. Your code change basically sounds good to me.

@muga Thank you for the advice.
I implement it. I'll add integration tests later.
validate tasks.
digdag push hoge
2019-02-26 16:39:41 +0900: Digdag v0.9.33
Creating .digdag/tmp/archive-5515688681553749096.tar.gz...
  Archiving fuga.dig
  Archiving scripts/myscript.sh
Workflows:
  fuga.dig
error: Status code 400: {"message":"io.digdag.core.repository.ModelValidationException: Validating workflow failed\n+fuga+setup contains invalid keys: 'sh': \"{\"sh\":\"echo start ${session_time}\"}\"","status":400}

validate schedule.
2019-02-26 16:42:19 +0900: Digdag v0.9.33
Creating .digdag/tmp/archive-6443414997521903051.tar.gz...
  Archiving fuga.dig
  Archiving scripts/myscript.sh
Workflows:
  fuga.dig
error: Status code 400: {"message":"hourly>: scheduler requires mm:ss format: test","status":400}

@hiroyuki-sato it's cool. thanks!

@muga. Please take a look when you have time.
I created ValidateProjectIT.java for testing this PR.
Is it better to place those tests in another class?
Those comment part doesn't need to this class. I will just remove it.
What do you think?. I'm not sure it possible to validate more.
                        // validate workflow and schedule
//                        Set<String> required = new HashSet<>();
                        for (WorkflowTask task : wf.getTasks()) {
                            // raise an exception if task doesn't valid.
                            task.getConfig();
//                            String require = config.getOptional("require>", String.class).orNull();
//                            if (require != null && required.add(require)) {
//                                f.ln("  -> %s", require);
//                            }

@muga Thank you for the comment. I removed unnecessary comments and moved validation into a separate method. Please take a look when you have time.

@yoyama Thank you for the comment. There is still a much-unused import statement. That's why I can't use Optimize imports feature in IntelliJ. 😢
Anyway, I removed those imports which I added.
Please take a look when you have time.

merged..

Thank you!


AWS Node Pool Leaves Spot Requests as Open

What kind of request is this (question/bug/enhancement/feature request): bug
Steps to reproduce (least amount of steps as possible):
Attempt to use a spot instance where capacity-not-available is occurring.
Result:
Rancher's Node Pool leaves dozens to hundreds of open spot requests if they all keep returning capacity-not-available it doesn't handle the error properly and cancel the request, instead it just times out waiting for the node and then opens a new request.
Other details that may be helpful:
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): 2.3.3
Installation option (single install/HA): HA

This is still relevant

This is still valid
Sent from my iPhone

On Sep 8, 2021, at 22:06, stale[bot] @.***> wrote:

This repository uses a bot to automatically label issues which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community issues better. If the issue is still relevant, please add a comment to the issue so the bot can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the bot will automatically close the issue in 14 days. Thank you for your contributions.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Still a valid issue
Sent from my iPhone

On Nov 8, 2021, at 11:46, stale[bot] @.***> wrote:

This repository uses a bot to automatically label issues which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community issues better. If the issue is still relevant, please add a comment to the issue so the bot can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the bot will automatically close the issue in 14 days. Thank you for your contributions.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


feat: Amazon Bedrock support (Claude models)

Reference Issues/PRs

https://github.com/princeton-nlp/SWE-agent/issues/27
What does this implement/fix? Explain your changes.

This PR fixes https://github.com/princeton-nlp/SWE-agent/issues/27 (Claude models only).
It adds a BedrockModel class built on top of anthropic[bedrock].
docker run --rm -it -v /var/run/docker.sock:/var/run/docker.sock \
    $(env | grep AWS_ | xargs printf ' -e %s') \
    sweagent/swe-agent-run:latest \
    python run.py --image_name=sweagent/swe-agent:latest \
    --model_name bedrock:anthropic.claude-3-sonnet-20240229-v1:0 \
    --data_path https://github.com/pvlib/pvlib-python/issues/1603 \
    --config_file config/default_from_url.yaml  --skip_existing=False

Looking good! Thanks a lot for putting in the time! Lmk when it's ready to merge!

Retesting since the merge from main introduced some bugs (missing rich_argparse pkg when using the swe-agent-run image)

claude-2 is now an alias for claude-2.0 (see https://github.com/anthropics/anthropic-sdk-python/issues/255), made the change in AnthropicModel. @klieret ready to go 🤘

Wait, one last thing: So when people specified --model claude-2 or --model claude, it picked claude-2.1, right? Then I think we should actually keep this behavior for now (this would both be in line with the anthropic issue and for reproducibility of the research results).

Wait, one last thing: So when people specified --model claude-2 or --model claude, it picked claude-2.1, right? Then I think we should actually keep this behavior for now (this would both be in line with the anthropic issue and for reproducibility of the research results).

I'll change the alias name (claude --> claude-2) and the target (claude-2.0 --> claude-2.1)


refactoralign node id in explain with nereids node id #25068

Proposed changes
cherry pick pr 25068 for branch 2.0
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.47 seconds
stream load tsv:          562 seconds loaded<PHONE_NUMBER>9 Bytes, about 126 MB/s
stream load json:         20 seconds loaded<PHONE_NUMBER> Bytes, about 112 MB/s
stream load orc:          65 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select:          29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size:<PHONE_NUMBER>5 Bytes

run buildall


Example Kubernetes port annotation does not use port number

In this line which is given as an example of annotation usage,
- source_labels: [__address__, __meta_kubernetes_service_annotation_example_io_scrape_port]
  action: replace
  regex: ([^:]+)(?::\d+)?;(\d+)
  replacement: $1:$2
  target_label: __address__

I am puzzled that the replacement is $1:$2; I expect it to be $1:$3 so that the port number specified in the annotation is used.
For instance I see a similar line matching my expectation here.

This is because the second group ((?::\d+)) isn't captured (eg it starts with (?:).

Ooh.   TIL.


Ascii mode

Problem
Old school ascii mode, just like in gnuchess. The player has uppercase letters and the enemy has lowercase letters.
p = pawn, k = king, q = queen, b = bishop, r = rook, n = knight

This is a good idea and could be implemented easily.
Maybe we could have another clap cli argument like --ascii to run chess-tui in ascii mode and replace every piece by it's character, we also will need to see how it renders on the board making sure it is not too small

Fyi, I am working on this, and I will create a PR soon.
https://github.com/pSnehanshu/chess-tui/tree/feat/ascii-mode

Here you go #60


Documentation is not updated.

Hey, I have checked the documentation of this framework. I was unable to get the purpose of this framework. Can you please update this?

Yes, I'm on it will update you soon once the documentation is ready.


v2 - Option to add songs from a playlist

It would be great to be able to add music directly from my own playlists rather than searching for each song.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Wrong repo


Overlay Eample - Show the popup in front of the other overlays

This fixes the rendering issue for the example mentioned here: #11282

Fixes #11282.


examples in macOS not correct showing

MacOS 11.6 .net core 6.0

Yes, this is a known unfixable issue with MacOS and C#. The function needed to add in the workaround for this Mac specific problem it is not exposed via Raylib-CS or Raylib-CS-Lo (A GLFW function)
Sadly it's not possible to make this work in C#, only C/C++ where it can access GLFW directly. MacOS's OpenGL driver requires a work around to scale the stencil buffer on high DPI displays, and without the workaround it just won't work properly. Apple has deprecated OpenGL so they will not be fixing any driver bugs.

Thanks for your detailed information.

@JeffM2501 you should make a issue on c raylib repo and have raysan expose the function

The current system is using a rlgl call this seems to work


Update Host Watchdog timeout event name

Update host watch dog timeout event name to match in both hostboot-dump-collection enabled and disabled state.
Move the configuration file generation outside the executable block
Test:
Tested and creates the expected PEL.

Can one of the admins verify this patch?

add to approvelist

Please provide link to corresponding upstream changes.

Please provide link to corresponding upstream changes.

https://gerrit.openbmc.org/c/openbmc/openpower-debug-collector/+/62812
https://gerrit.openbmc.org/c/openbmc/openpower-debug-collector/+/62813

I think at this point, lets just get the general commit message comments addressed upstream and then we can refresh this and get it all merged. https://gerrit.openbmc.org/c/openbmc/phosphor-logging/+/62810 will also need to be merged upstream and we'll have to ask Reed to bump to it.

The third commit does not have respective upstream patch, as dump code is not upstream yet.

Since code isn't merged upstream yet, I bet you can just comment on https://gerrit.openbmc.org/c/openbmc/openpower-debug-collector/+/42328/36/dump/dist/meson.build and note that the conf variable should be renamed.

Done. Thank you!


small refactor in some sorting algorithms for better readability

Small change to make it more readable using the spread operator.

Codecov Report

Merging #3 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master     #3   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          76     76
  Lines        1596   1596
  Branches      282    282
=====================================
  Hits         1596   1596

Impacted Files
Coverage Δ

src/algorithms/sorting/bubble-sort/BubbleSort.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e0ac74...488b7a4. Read the comment docs.

@PeterShershov thank you for your fix! Spread operator you've used is better for readability of course.


Erase double vertical alignment

No need to vertical move after select because Select already make that.

Actually, I think this change is unnecessary after #849, where I change how the movement happens when iterating.

Actually, I think this change is unnecessary after #849, where I change how the movement happens when iterating.

Agree!


Cosmos: id not populated on Attach

When trying to delete an entity created using a different database context instance than the one currently in use, an exception is thrown.
Exception message: Unable to track an entity of type 'Item' because alternate key property 'id' is null. If the alternate key is not used in a relationship, then consider using a unique index instead. Unique indexes may contain nulls, while alternate keys must not.
Stack trace: Exception thrown: 'System.InvalidOperationException' in System.Private.CoreLib.dll
   at Microsoft.EntityFrameworkCore.ChangeTracking.Internal.NullableKeyIdentityMap`1.Add(InternalEntityEntry entry)
   at Microsoft.EntityFrameworkCore.ChangeTracking.Internal.StateManager.StartTracking(InternalEntityEntry entry)
   at Microsoft.EntityFrameworkCore.ChangeTracking.Internal.InternalEntityEntry.SetEntityState(EntityState oldState, EntityState newState, Boolean acceptChanges)
   at Microsoft.EntityFrameworkCore.ChangeTracking.Internal.InternalEntityEntry.SetEntityState(EntityState entityState, Boolean acceptChanges, Nullable`1 forceStateWhenUnknownKey)
   at Microsoft.EntityFrameworkCore.ChangeTracking.Internal.EntityGraphAttacher.PaintAction(EntityEntryGraphNode`1 node)
   at Microsoft.EntityFrameworkCore.ChangeTracking.Internal.EntityEntryGraphIterator.TraverseGraph[TState](EntityEntryGraphNode`1 node, Func`2 handleNode)
   at Microsoft.EntityFrameworkCore.ChangeTracking.Internal.EntityGraphAttacher.AttachGraph(InternalEntityEntry rootEntry, EntityState targetState, EntityState storeGeneratedWithKeySetTargetState, Boolean forceStateWhenUnknownKey)
   at Microsoft.EntityFrameworkCore.DbContext.SetEntityState(InternalEntityEntry entry, EntityState entityState)
   at Microsoft.EntityFrameworkCore.DbContext.SetEntityState[TEntity](TEntity entity, EntityState entityState)
   at Microsoft.EntityFrameworkCore.DbContext.Attach[TEntity](TEntity entity)
   at EFCoreAzureCosmosDBExperiments.Program.TestCrossContextNonTrackedRDAsync() in C:\Users\alexf\Source\Repos\EFCoreAzureCosmosDBExperiments\EFCoreAzureCosmosDBExperiments\Program.cs:line 27
   at EFCoreAzureCosmosDBExperiments.Program.Main() in C:\Users\alexf\Source\Repos\EFCoreAzureCosmosDBExperiments\EFCoreAzureCosmosDBExperiments\Program.cs:line 17

Steps to reproduce

Create a new console application running the latest public release of .NET Core 3.0, which, as of writing, is Preview 3, and replace the source code with the files contained in the following ZIP archive. The project file is also provided for reference.
EFCoreAzureCosmosDBExperiments.zip
Modify the CosmosContext class to connect to whatever instance or emulator of Azure Cosmos DB you have running.
Run the program and follow the on-screen instructions to run examples where the exception is thrown, and where the program operates correctly.

Further technical details
EF Core version: 3.0.0-preview3.19153.1
Database Provider: Microsoft.EntityFrameworkCore.Cosmos
Operating system: Windows 10 1908 Build 17763.379
IDE: Visual Studio 2019 16.0.0

Note that the comment on line 55 of Program.cs is innacurrate; it is leftover from when I was trying to fix the issue.

What's interesting is that it seems that the exception will occur even if just attaching the entity to the context.

Apparently, the issue is that because the ID property I have on the model is a Guid, while the primary key for any document by default is a string approximately equal to $"{Descriminator}|{ID}", as far as I can tell, whenever a previously queried entity is attached to a new context, the process of inferring the primary key, serialized as id in the JSON for the document, is failing. Attempting to manually set this property via the use of shadow properties, seems to not be working because the entity needs to be attached first, which causes an exception.

Same behaviour is experienced with latest nightly build.

Apparently, if the entity is simply reloaded via using DbContext.Entry<TEntity>(...) to get an EntityEntry<TEntity> and calling ReloadAsync(), then it can be removed by the context instance. This should be made more obvious in documentation if it is intended behaviour.

This is still an issue in the latest build from the dotnetfeed.blob.core.windows.net Entity Framework Core feed. The only mitigation, now that the Reload workaround stopped working, is to have a string property called id case sensitive. This is very frustrating.

@TheFanatr Instead of calling Attach/Remove you'll need to get the entry and set the store id explicitly:
var itemEntry = context.Entry(createdItem);
itemEntry.Property<string>("id").CurrentValue = "Item|" + createdItem.ID;
itemEntry.State = EntityState.Deleted;

We'll investigate whether this value can be generated automatically for non-add scenarios in the future.

@AndriySvyryd Thank you for providing this workaround, however I am still a little frustrated. The value used to be generated correctly for deletion as long as itemEntry.ReloadAsync() was called before the entity was marked for removal (using the .NET Core 3.0 Preview 5 release), which is no longer the case, and also the value is currently always generated correctly and deletion can occur without needing to directly use any of the EntityEntry<TEntity> APIs as long as there is a string property called id, but then the initial value needs to be generated manually as follows and the value is incorrectly stored to the database without the discriminator as seen in the image below.
public string id { get; set; } = Guid.NewGuid().ToString();

The incorrect storage can be fixed by concatenating the discriminator to the beginning of the string but then that causes other issues and inconveniences, and I have found no way to get any other property name and type combination to map to id in the JSON, even when using the ModelBuilder instance provided to OnModelCreating on the CosmosContext to set the property up using the ToJsonProperty method nor by manually adding the Cosmos:PropertyName annotation to the property, the property configured as a key, and the property configured as an alternate key.
It feels as though this functionality is not yet implemented, but no exceptions are being thrown. Am I using these features incorrectly?

@TheFanatr I'll also investigate why Reload stopped working.
The id property is in shadow state by default, meaning its value is stored in the context and is lost when you attach the entity to a different context, by adding and id property to the CLR type you are providing a place to store the value between contexts. Currently the id name is hardcoded, but we'll consider adding ways of mapping it to a different property after 3.0
What problems did you run into when setting id to the Guid value without discriminator? As long as you do it consistently it should also work, Cosmos just needs it to be unique across the collection.

Related: https://github.com/aspnet/EntityFrameworkCore/issues/16186

For Attach to work we need to generate key values: https://github.com/aspnet/EntityFrameworkCore/issues/13575

I have a fix implemented on a local copy of the master branch via inheriting StateManager from a class and overriding StateChanging to include a call to ValueGenerationManager.Generate(entry) and adding the aforementioned derived class's type to the internal service collection via modifying the CosmosServiceCollectionExtensions.AddEntityFrameworkCosmos to include a EntityFrameworkServicesBuilder.TryAdd call that replaces the default IStateManager service.

This is messy because it does not account for other values that are generated, and more specifically, making sure that those generators don't run and replace existing data. But as for generating the shadow properties required for the Cosmos DB provider to work correctly, this suffices for me as it also fixes the problem of Reload not working.

I've never touched the source to Entity Framework Core in my life so this took some long hours (15+) of debugging; maybe it should be more clear somewhere that this provider is not to be used in it's current state. To further back that up, I've now found that loading reference navigation properties does not work and will post an issue soon enough.

@TheFanatr Reload should be working in the nightly builds. The current limitations of the Cosmos provider are listed on this page

I did try with the nightly builds on the 30th, and it did not work. I set up a reproduction project and just debugged it myself with the Entity Framework Core source from master. I can send post it if you would like.

The failure mode was an exception saying that the model was not finalized.

@TheFanatr If Reload doesn't work then please create a new issue with a small repro project that uses an officially built nightly package

Ok, sounds good.


Update Pages “InvasiveInspectionForTermitesPage”

Automatically generated by Netlify CMS

👷 Deploy Preview for chic-shortbread-66a66b processing.

Name
Link

🔨 Latest commit
eaeee5b694fdb6a3dc6df4806c2ca1bd35792e11

🔍 Latest deploy log
https://app.netlify.com/sites/chic-shortbread-66a66b/deploys/6553f886d0115100084b6615