[Bug] Permission checks fail on Kubernetes 1.24

Kyverno Version
1.10.x
Kubernetes Version
1.24.x
Kubernetes Platform
EKS
Description
Hi Kyverno team.
I am trying to apply the following ClusterPolicy rule to my Kubernetes cluster.
apiVersion: kyverno.io/v1
kind: ClusterPolicy
metadata:
  name: restart-daemonset-on-secret-change
  annotations:
    policies.kyverno.io/title: Restart DaemonSet On Secret Change
    policies.kyverno.io/category: other
    policies.kyverno.io/severity: medium
    policies.kyverno.io/subject: DaemonSet
    kyverno.io/kyverno-version: 1.10.0
    policies.kyverno.io/minversion: 1.10.0
    kyverno.io/kubernetes-version: "1.24"
    policies.kyverno.io/description: >-
      If Secrets are mounted in ways which do not naturally allow updates to
      be live refreshed it may be necessary to modify a DaemonSet. This policy
      watches a Secret and if it changes will write an annotation
      to one or more target DaemonSets thus triggering a new rollout and thereby
      refreshing the referred Secret. It may be necessary to grant additional privileges
      to the Kyverno ServiceAccount, via one of the existing ClusterRoleBindings or a new
      one, so it can modify DaemonSets.
spec:
  mutateExistingOnPolicyUpdate: false
  rules:
  - name: update-secret-in-daemonset
    match:
      any:
      - resources:
          kinds:
          - Secret
    preconditions:
      all:
      - key: "{{request.operation}}"
        operator: Equals
        value: UPDATE
      - key: "{{request.object.metadata.ownerReferences[0].kind}}"
        operator: Equals
        value: DaemonSet
      - key: '{{request.object.metadata.annotations."kyverno.domain.tech/read"}}'
        operator: Equals
        value: allow
      - key: "{{ equal_fold('{{request.object.data}}', '{{request.oldObject.data}}') }}"
        operator: NotEquals
        value: true
    mutate:
      targets:
        - apiVersion: apps/v1
          kind: DaemonSet
          name: "{{request.object.metadata.ownerReferences[0].name}}"
          namespace: "{{request.object.metadata.namespace}}"
      patchStrategicMerge:
        spec:
          template:
            metadata:
              annotations:
                kyverno.dif.tech/secretversion: '{{request.object.metadata.resourceVersion}}'

But getting this error.
one or more objects failed to apply, reason: admission webhook "validate-policy.kyverno.svc" denied the request: path: spec.rules[0].mutate.targets.: auth check fails, require additional privileges, update the ClusterRole 'kyverno:background-controller:additional':failed to get the Group Version Resource for kind DaemonSet;

Already created  ClusterRole with ClusterRolebinding which it required at the ClusterPolicy apply time. Just for you information in the Kubernetes version 1.25.5 and 1.26.5 will be enough to give an access only for kyverno-background-controller  service account and it works fine (In the kubernetes version 1.24 I have tried in the ClusterRole even all * in apiGroups, resources and verbs. It doesn't work too).
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
  name: kyverno:background-controller:additional
rules:
- apiGroups: ["apps"]
  resources: ["daemonsets", "deployments", "statefulsets"]
  verbs: ["get", "list", "watch", "create", "update", "patch", "delete"]
---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
  name: kyverno-background-controller-additional-binding
roleRef:
  apiGroup: rbac.authorization.k8s.io
  kind: ClusterRole
  name: kyverno:background-controller:additional
subjects:
- kind: ServiceAccount
  name: kyverno-admission-controller
  namespace: kyverno
- kind: ServiceAccount
  name: kyverno-background-controller
  namespace: kyverno
- kind: ServiceAccount
  name: kyverno-cleanup-controller
  namespace: kyverno
- kind: ServiceAccount
  name: kyverno-cleanup-jobs
  namespace: kyverno
- kind: ServiceAccount
  name: kyverno-reports-controller
  namespace: kyverno

I have tried to get some logical errors from API server logs too (nothing).
Steps to reproduce

The same version of Kyverno with the same ClusterRole and ClusterRolebindings (only with kyverno-background-controller service account) works fine in the Kubernetes version 1.25.5 and 1.26.5

Expected behavior
I expect to work with this ClusterPolicy rule in the Kubernetes 1.24.x because I got this information from your official page Combability matrix (1.10.x | 1.24 | 1.26).
Screenshots
No response
Kyverno logs
E0619 14:14:22.568154       1 handlers.go:38] webhooks/policy/validate "msg"="policy validation errors" "error"="path: spec.rules[0].mutate.targets.: auth check fails, require additional privileges, update the ClusterRole 'kyverno:background-controller:additional':failed to get the Group Version Resource for kind DaemonSet; failed to get the Group Version Resource for kind DaemonSet" "gvk"={"group":"kyverno.io","version":"v1","kind":"ClusterPolicy"} "gvr"={"group":"kyverno.io","version":"v1","resource":"clusterpolicies"} "name"="restart-daemonset-on-secret-change" "namespace"="" "operation"="CREATE" "uid"="" "user"={"username":"kubernetes-admin","uid":"","groups":["system:masters","system:authenticated"],"extra":{"accessKeyId":[""],"arn":[""],"canonicalArn":[""],"principalId":[""],"sessionName":[""]}}

Slack discussion
No response
Troubleshooting

[X] I have read and followed the documentation AND the troubleshooting guide.
[X] I have searched other issues in this repository and mine is not recorded.

In the same cluster 1.24 works fine same ClusterPolicy rule with the Kyverno version 1.8.5

I just applied your policy to a 1.24 cluster after assigning the necessary permissions using this aggregating ClusterRole:
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
  labels:
    app.kubernetes.io/component: background-controller
    app.kubernetes.io/instance: kyverno
    app.kubernetes.io/part-of: kyverno
  name: kyverno:update-daemonsets
rules:
- apiGroups:
  - apps
  resources:
  - daemonsets
  verbs:
  - update

$ k apply -f perms.yaml
clusterrole.rbac.authorization.k8s.io/kyverno:update-daemonsets created

$ k apply -f cpol.yaml
clusterpolicy.kyverno.io/restart-daemonset-on-secret-change created

$ helm ls -n kyverno
NAME    NAMESPACE       REVISION        UPDATED                                 STATUS          CHART           APP VERSION
kyverno kyverno         1               2023-06-20 19:12:24.1334319 -0400 EDT   deployed        kyverno-3.0.1   v1.10.0

Are you sure it is looking to this ClusterRole with name kyverno:update-daemonsets? Even from logs it says I require kyverno:background-controller:additional

I tested it again right now. Kubernetes version v1.24.13
kubectl get deployment -n kyverno
NAME                            READY   UP-TO-DATE   AVAILABLE   AGE
kyverno-admission-controller    1/1     1            1           48m
kyverno-background-controller   1/1     1            1           48m
kyverno-cleanup-controller      1/1     1            1           48m
kyverno-reports-controller      1/1     1            1           48m

This is all clusterroles
kubectl get clusterrole | grep kyverno
kyverno-cleanup-jobs                                                   2023-06-21T07:38:22Z
kyverno:admission-controller                                           2023-06-21T07:38:22Z
kyverno:admission-controller:core                                      2023-06-21T07:38:22Z
kyverno:background-controller                                          2023-06-21T07:38:22Z
kyverno:background-controller:additional                               2023-06-21T07:38:22Z
kyverno:background-controller:core                                     2023-06-21T07:38:22Z
kyverno:cleanup-controller                                             2023-06-21T07:38:22Z
kyverno:cleanup-controller:core                                        2023-06-21T07:38:22Z
kyverno:rbac:admin:policies                                            2023-06-21T07:38:22Z
kyverno:rbac:admin:policyreports                                       2023-06-21T07:38:22Z
kyverno:rbac:admin:reports                                             2023-06-21T07:38:22Z
kyverno:rbac:admin:updaterequests                                      2023-06-21T07:38:22Z
kyverno:rbac:view:policies                                             2023-06-21T07:38:22Z
kyverno:rbac:view:policyreports                                        2023-06-21T07:38:22Z
kyverno:rbac:view:reports                                              2023-06-21T07:38:22Z
kyverno:rbac:view:updaterequests                                       2023-06-21T07:38:22Z
kyverno:reports-controller                                             2023-06-21T07:38:22Z
kyverno:reports-controller:core                                        2023-06-21T07:38:22Z
kyverno:update-daemonsets                                              2023-06-21T07:53:39Z

The content of the ClusterRole which you wrote same as mine which I created
kubectl get clusterrole kyverno:update-daemonsets -o yaml | kubectl neat
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
  labels:
    app.kubernetes.io/component: background-controller
    app.kubernetes.io/instance: kyverno
    app.kubernetes.io/part-of: kyverno
  name: kyverno:update-daemonsets
rules:
- apiGroups:
  - apps
  resources:
  - daemonsets
  verbs:
  - update

The same output it says I need ClusterRole kyverno:background-controller:additional than kyverno:update-daemonsets
Error from server: error when creating "helm/kyverno/kyverno/kyverno/templates/08-clusterpolicy-daemonsets.yaml": admission webhook "validate-policy.kyverno.svc" denied the request: path: spec.rules[0].mutate.targets.: auth check fails, require additional privileges, update the ClusterRole 'kyverno:background-controller:additional':failed to get the Group Version Resource for kind DaemonSet; failed to get the Group Version Resource for kind DaemonSet

Thank is the output of ClusterRole which it requires
kubectl get clusterrole kyverno:background-controller:additional -o yaml | kubectl neat
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
  labels:
    app.kubernetes.io/instance: kyverno
    app.kubernetes.io/part-of: kyverno
  name: kyverno:background-controller:additional
rules:
- apiGroups:
  - apps
  resources:
  - daemonsets
  - deployments
  - statefulsets
  verbs:
  - get
  - list
  - watch
  - create
  - update
  - patch
  - delete

And ClusterRoleBinding which gives to SA to work with ClusterRole
kubectl get clusterrolebinding kyverno-background-controller-additional-binding -o yaml
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
  creationTimestamp: "2023-06-21T07:38:22Z"
  labels:
    dif.tech/argocd: kyverno-dt-dev-euc1-infra
  name: kyverno-background-controller-additional-binding
  resourceVersion: "238669103"
  uid: a2d04c78-b7b3-46f0-abbe-102df49bc605
roleRef:
  apiGroup: rbac.authorization.k8s.io
  kind: ClusterRole
  name: kyverno:background-controller:additional
subjects:
- kind: ServiceAccount
  name: kyverno-background-controller
  namespace: kyverno

The result is the same.

We are seeing similar error on same versions when trying to update to new helm chart and new kyverno version.
Kyverno Version
1.10.x
Kubernetes Version
1.24.x
Kubernetes Platform
EKS
Example policy
apiVersion: kyverno.io/v1
kind: ClusterPolicy
metadata:
  name: test-namespace-team-label
spec:
  mutateExistingOnPolicyUpdate: true
  rules:
    - name: reuse-namespace-team-label
      context:
        - name: nsTeam
          apiCall:
            urlPath: "/api/v1/namespaces/{{request.object.metadata.namespace}}"
            jmesPath: "metadata.labels.team"
      match:
        any:
          - resources:
              kinds:
                - Deployment
      mutate:
        targets:
          - apiVersion: apps/v1
            kind: Deployment
        patchStrategicMerge:
          metadata:
            labels:
              +(team-mma): "mma-test"

result
Error from server: error when creating "test-label-policy.yaml": admission webhook "validate-policy.kyverno.svc" denied the request: path: spec.rules[0].mutate.targets.: auth check fails, require additional privileges, update the ClusterRole 'kyverno:background-controller:additional':failed to get the Group Version Resource for kind Deployment; failed to get the Group Version Resource for kind Deployment

We've tried a bunch of different RBAC constellations but cannot get it to work.

My colleague has also managed to run things fine on a local cluster, so we are scratching our heads here and I'm getting ready to blame EKS at this point 😅

It does not matter in which ClusterRole the additional permissions are granted. We are fixing the message for the first patch to remove the "additional" ClusterRole for that reason. Kyverno will perform a SubjectAccessReview against itself to see if it has the required permissions. So if you don't get a "yes" back from the command kubectl auth can-i update daemonsets --as system:serviceaccount:kyverno:kyverno-background-controller then Kyverno will throw that error. There is also one more fix I see for this being proposed in PR #7628 which may be related.

I'll keep hijacking a bit here, as issue seems similar.

(create, update, delete, get all give yes)
Any other debugging tips? 😄
But perhaps referenced https://github.com/kyverno/kyverno/pull/7628/ might fix it

This could also be fixed already in the release branch. Please try on a test cluster using the latest code in main by following the instructions here.
Also, btw, please try and use code blocks and paste text rather than taking screenshots of code and terminal output. We can't search screenshots.

So, as I understand it is issue right now and I can get the fixed version from Main branch. Officially it will be fixed in the future Helm chart release am I right?

There is some fix available in main which was cherry picked to the 1.10 release branch. Pulling from main is not supported and should not be used for anything other than testing. Fixes will be made available in the 1.10.1 release which is expected "soon".

This could also be fixed already in the release branch. Please try on a test cluster using the latest code in main by following the instructions here.
Also, btw, please try and use code blocks and paste text rather than taking screenshots of code and terminal output. We can't search screenshots.

@chipzoller Aye we were just in progress of testing main after seeing this suggestion in another issue.
The same policy as in my comment above is working when applying using a deployment from main branch.
Hoping to see that 1.10.1 soon ™, thanks! ❤
(and sorry about the lazy screenshots 😄)

1.10.1 and 1.10.2 are now available. Closing.


Docker task is incorrectly labeling the base image name when there is a "copy --from" statement

Required Information
With a Dockerfile like
FROM scratch as base

FROM scatch as final
COPY --from=base

it returns =base but it should returns scratch. This issue is related to how the dockerfile is parsed
Question, Bug, or Feature?
Type: Bug

When is this one being released to Azure DevOps?
Thanks

This hasn't been affecting us until this morning - suddenly all our builds are failing.

This issue can be closed, duplicate of https://github.com/microsoft/azure-pipelines-tasks/pull/15176, fixed w/ https://github.com/microsoft/azure-pipelines-tasks/pull/15114.

There are still other cases where the base image parsing does not work correctly.
E.g. see #16380 (which - apparently due to bot/workflow failure - is not being looked at).

Are people working on this repository even looking at open issues? The fact, that they don't have activity may not be because an issue is not important, but rather that it got overlooked. So instead of it being auto-closed, it may be rather a reason to bump it up.

It seems that no one is looking at issues, except for bots. :(

Any news on this?

Could anyone take a look at the problems indicated in the comments?


Error on saving interactive plot to HTML: UnicodeEncodeError: 'charmap' codec can't encode character '\U0001f50d' in position 3366: character maps to

Hello. First of all, this library is amazing!
I am trying to save the interactive plot to HTML, but I am getting this error:
UnicodeEncodeError: 'charmap' codec can't encode character '\U0001f50d' in position 3366: character maps to <undefined>

It seems this Unicode char is a LEFT-POINTING MAGNIFYING GLASS:
https://www.fileformat.info/info/unicode/char/1f50d/index.htm
And I think this error in happening because I set enable_search=True, which includes a search box with a magnifying glass symbol on it:
plot = datamapplot.create_interactive_plot(
    coords,
    df['group'].values,
    hover_text=hover_data,
    cluster_boundary_polygons=False,
    color_cluster_boundaries=False,
    enable_search=True
)
plot.save('datamapplot.html')
plot

However, when setting enable_search=False, the HTML is saved fine.
P.S.: I am using Windows 10.

Hmm, I have not seen that issue on systems I've used (it seems to accept the magnifying glass just fine). Perhaps I can make the icon/character user settable. In the meantime you can solve the problem by editing these lines in your installation and simply replacing the magnifying glass character with something that will save correctly on your system (just the text "enter search query here" would do for example).

Hmm, I have not seen that issue on systems I've used (it seems to accept the magnifying glass just fine). Perhaps I can make the icon/character user settable. In the meantime you can solve the problem by editing these lines in your installation and simply replacing the magnifying glass character with something that will save correctly on your system (just the text "enter search query here" would do for example).

Thanks for the quick reply.
Just changed the magnifying glass to something like "Search: " and worked fine.
Thanks!

I am getting the error aboe as well in a Jupyter environment (via Docker).
Linux jupyter-xx 5.14.0-427.28.1.el9_4.x86_64 #1 SMP PREEMPT_DYNAMIC Fri Jul 19 14:40:47 EDT 2024 x86_64 x86_64 x86_64 GNU/Linux
LANG=en_US.UTF-8
LANGUAGE=en_US.UTF-8
LC_CTYPE="en_US.UTF-8"
LC_NUMERIC="en_US.UTF-8"
LC_TIME="en_US.UTF-8"
LC_COLLATE="en_US.UTF-8"
LC_MONETARY="en_US.UTF-8"
LC_MESSAGES="en_US.UTF-8"
LC_PAPER="en_US.UTF-8"
LC_NAME="en_US.UTF-8"
LC_ADDRESS="en_US.UTF-8"
LC_TELEPHONE="en_US.UTF-8"
LC_MEASUREMENT="en_US.UTF-8"
LC_IDENTIFICATION="en_US.UTF-8"
LC_ALL=en_US.UTF-8


How to serialise entire tree in a file?

I have a usecase where I would I want to prepare a large tree pre-process and save the pre-processed tree as a file for the trie to be created faster. Is there a mechanism to do so.

I say plus one. I also need the serialization for ConcurrentRadixTree in different formats. Binary. Text. Json if possible.


SLM double quote conversion in section 13

Double quote is converted into &#34 in section 13 antenna drawing section

I noticed this conversion problem in section 0 of the Prepared by field for TEJA00CHL so this probably effects other fields as well and not just section 13.

This appears to be an issue with the data itself. There's nothing in the software thats escaping the string. This probably happened during import.
It does raise a question though. Is the correct solution just to fix our data or is the correct solution to forcibly unescape all text strings during serialization.


OU-298: fix default nginx path to look for static files

This PR fixes the path the ubi8/nginx-120 uses to look for files

/lgtm


Cannot install with composer require konnco/filament-import

`composer require konnco/filament-import
./composer.json has been updated
Running composer update konnco/filament-import
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.
Problem 1
- Root composer.json requires konnco/filament-import * -> satisfiable by konnco/filament-import[0.0.1, 0.0.2, 1.0.0, ..., 1.6.1].
- konnco/filament-import[0.0.1, ..., 0.0.2, 1.0.0, ..., 1.2.1] require illuminate/contracts ^9.0 -> found illuminate/contracts[v9.0.0, ..., v9.52.16] but these were not loaded, likely because it conflicts with another require.
- konnco/filament-import[1.2.2, ..., 1.6.0] require filament/filament ^2.0 -> found filament/filament[v2.5.3, ..., v2.17.56] but it conflicts with your root composer.json require (^3.2).
- konnco/filament-import 1.6.1 requires illuminate/contracts ^10 -> found illuminate/contracts[v10.0.0, ..., v10.48.22] but these were not loaded, likely because it conflicts with another require.
Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions.
You can also try re-running composer require with an explicit version constraint, e.g. "composer require konnco/filament-import:*" to figure out if any version is installable, or "composer require konnco/filament-import:^2.1" if you know which you need.
Installation failed, reverting ./composer.json and ./composer.lock to their original content.`

I have the exact same problem. Laravel 11 & Filament 3.

Looks like this should solve it https://github.com/konnco/filament-import/pull/159 ,but it is not merged.

@frankyso Any info about it ?

Same issue here @frankyso with Laravel 11 and Filament 3.


fixed #1186 removed user component which does not exists

Related Issue
Closes #1186

Description

the problem was that we are importing a component which doesn't exists only.
Screenshots
before :

after:

Checklist

[ ] My code adheres to the established style guidelines of the project.
[ ] I have included comments in areas that may be difficult to understand.
[x] My changes have not introduced any new warnings.
[x] I have conducted a self-review of my code.

this issue is solved #1162


header in tag section in photo-detail view has alignment error

Describe the bug
Bug is observered in mobile view
To Reproduce

Go to 'results'
Click on 'image'
Scroll down to 'tag' section
See error

Screenshots

Smartphone (please complete the following information)

Device: (ex. iPhone6)
OS: (ex. iOS8.1)
Browser (ex. stock browser, safari)
Version (ex. 22)

Additional context
Would like to work on it. Can CC team assign this to me?

Firstly there are 2 header tags and secondly, I wanted to know what do you mean by saying alignment error, like what is your expected behavior?

By alignment I meant that the border above heading and horizontal line are not aligned.

Thanks for spotting this! Go ahead and work on this :) Please remember to keep it to one PR per issue

With the new redesign this is no longer an issue. But thanks for your contribution


Bump min required version to 1.53.0

due to an update of cfg-expr

You'll have to send PRs to gtk3 and gtk4 as well then since they need this crate.

Yes, already sent the gtk4 one and working on the gtk3 one.


Delete a protocol from the App

Overview
This is a new requirement that popped up during development. When a protocol file is added to the OT app, a copy is made in the app's protocol directory and the original file is left alone in the filesystem. If a user wants to remove a protocol from the protocols landing page, we should enable the user to delete the imported copy from the protocol card's 3-dot menu
Implementation details
If a user has a protocol in User/Downloads/, they select it in the upload slide-out in the app, We make a copy of that protocol and put it in /secretAppFolder/, when they click "remove" in the app, we move the copy to the trash, but the original file is still present in User/Downloads/
Design
Warning modal: https://www.figma.com/file/bVtCogdwiXj3ndpk4AWXCx/Milestone-1%3A-Read-and-Execute?node-id=1297%3A90568
Acceptance criteria

[ ] The user should be able to delete the imported copy of a protocol, removing that protocol from their protocols landing page

[ ] The original file should be untouched in the user's filesystem

[ ] The user should be prompted with a confirmation modal after they select "delete protocol" in the 3-dot menu

@reachojhaneha Would this ticket need a selector for the delete protocol option in the 3-dot menu or the confirmation modal?

yes mike, thanks for bringing this. I will add the selectors


Enable delegation on sepolia

### Tasks
- [x] Deploy delegation contract (https://sepolia.etherscan.io/address/0x469788fE6E9E9681C6ebF3bF78e7Fd26Fc015446#code)
- [x] Deploy delegation subgraph https://github.com/snapshot-labs/snapshot-subgraph/pull/15
- [x] Update snapshot.js to use new subgraph https://github.com/snapshot-labs/snapshot.js/pull/979

@ChaituVR I see the graphQL endpoint is active and it is possible to delegate on snapshot UI but it is throwing an error when fetching the delegates and current delegate

Could you plz share the link for this @tknoch-symphony

@ChaituVR https://testnet.snapshot.org/#/delegate/karate-combat-dev.eth


attrs in 'creating' event handler only contains 'created_at' and 'updated_at'

I have an object with an model.on('creating', (model, attrs) => { console.log(attrs) }) for some reason attrs is always:
{ updated_at: 2016-10-24T22:54:16.918Z,
  created_at: 2016-10-24T22:54:16.918Z }

but model is
User {
  attributes:
   { email<EMAIL_ADDRESS>     password: 'test123',
     name: 'Oli',
     username: '',
     updated_at: 2016-10-24T22:58:06.414Z,
     created_at: 2016-10-24T22:58:06.414Z },
  _previousAttributes: {},
  changed:
   { email<EMAIL_ADDRESS>     password: 'test123',
     name: 'Oli',
     username: '',
     updated_at: 2016-10-24T22:58:06.414Z,
     created_at: 2016-10-24T22:58:06.414Z },
  relations: {},
  cid: 'c1',
  _events:
   { creating: [Function],
     updating: [Function],
     fetching: [Function],
     'fetching:collection': [Function] },
  _eventsCount: 4,
  _knex: null }

Why am I not seeing attrs as:
   { email<EMAIL_ADDRESS>     password: 'test123',
     name: 'Oli',
     username: '',
     updated_at: 2016-10-24T22:58:06.414Z,
     created_at: 2016-10-24T22:58:06.414Z }

That being said, the row is correctly inserted in the table (including email, name, username, etc. attributes).

Ok so my insert looked like this
          User
            .forge(attrs)
            .save(null, { transacting })

The weird thing is that it would actually insert all the attributes to the database but .on('saving') would just see { updated_at, created_at }.
I modified the code like this:
          User
            .forge(attrs)
            .save(attrs, { transacting })

And now it still works but the .on('saving') callback sees all attributes. I am wondering if there's any way to call .save() with the {transacting} option without having to specify the first argument so that it does a regular .save() but with a transaction.

Hi! I discovered the same "problem".
According to the documentation for "creating" (and "saving")
@param {Object} attrs    Attributes that will be inserted.
So I think that this is not the documented behaviour. What I (and some other libs) had to do to overcome this problem is to check if the model isNew() and then use model.attributes or if not use attrs.
I'm not proposing a solution, I'm supporting the claim that either the docs or the code should be changed @tgriesser


[SPIKE] Redirect to/from External Checkout

Context
In the 1st phase of the project we want to proceed with external, original Shopware's Checkout. In the future we will implement our Internal Checkout.
This task is about analysing the way of interfaction with the Shopware Checkout. How to redirect users from Cart to Checkout. How to take care of the context / session. How to redirect back to the Thank Yoy Page.

Notes made by @mkucmus
https://github.com/elkmod/SwagVueStorefront/issues/25


Create Microsoft Edge extension

Can you create an extension to give Edge ability to play APNG?

No, Edge does not support the technologies necessary for this. And, more importantly, I do not use Edge :)


Wiki on how to host it yourself is missing

Currently the wiki pages on how to host the editor yourself are gone, which is a shame.
Also it would be beneficial if the main README linked to the 3 subproject READMEs.

What "3 subproject READMEs" do you mean?

https://github.com/lucko/LuckPermsWeb/blob/master/editor/README.md
https://github.com/lucko/LuckPermsWeb/blob/master/treeview/README.md
https://github.com/lucko/LuckPermsWeb/blob/master/verbose/README.md

These don't exist on the v2 branch.

Fixed it

Also it would be beneficial if v2 got merged into master or v2 became the default branch.

Merging is not done until most if not all bugs have been fixed in the site.
And I don't think it would be good/worth it making v2 the default branch.


Error in IMAP command FETCH: Invalid messageset

Describe the bug
Authentification is working :heavy_check_mark:
Emails are being identified :heavy_check_mark:
Can't retrieve/fetch the emails :cry:
[...]

time="2020-06-19T21:21:51+02:00" level=error msg="Error reaching mailserver" Error="Error in IMAP command FETCH: Invalid messageset (0.001 + 0.000 secs)." Server="XX.XX.xx:000"

[loop]

Expected behavior
Emails should be fetched and sent to the dedicated Mattermost channel.
Release version
v1.11.1 (last available)
Architecture

Ubuntu 18.04
Docker Swarm

Additional context

Provider's IMAP perfectly works on another apps (e.g. Desktop Client Mail, NextCloud, etc.).
I found this issue online, which may be related. Is there a workaround or a way to patch it? https://help.bittitan.com/hc/en-us/articles/115008100607-Error-in-IMAP-command-FETCH-Invalid-messageset
I tried to repeat the process multiple times, also with an empty mailbox (0 mail); same error.

Thank you in advance for your attention and support :pray:

Hi @agentlibre thanks for opening an issue here at mail2most.
Can you give me some more information about this issue:

Do you use some E-Mail provider or an on premise mail server?
If it is on premise, what mailserver are you using and what version?

I will try to reproduce the issue if possible to provide a fix.

Hi @cseeger-epages, thanks for the follow-up.
I am using Switzerland's first E-mail provider, Infomaniak. No on-premise mail server.

@agentlibre i have added an option that allowes you to ignore UID from the server and mail2most generates them from the messageID by itself (hopefully to be unique). This option is called
    # GenerateLocalUIDs creates a uid from message data instead of fetching the uid from the server
    # this can be helpfull when getting Invalid messageset errors since some DoveCot mailserver died not implement IMAP correctly
    GenerateLocalUIDs = false

see issue-50/invalid-messageset/mail2most.conf for an example configuration or just add GenerateLocalUIDs = true to your [Profile.Mail] config.
Since i can not test if this works properly while infomaniak only has a payed webmail service i need your feedback if the fix works properly.
I rebuild all binarys from this branch for you to test:
windows-amd64.tar.gz
windows-386.tar.gz
linux-arm64.tar.gz
linux-arm.tar.gz
linux-amd64.tar.gz
linux-386.tar.gz

PR merged


When a banner is notice only it still needs to show the "manage preferences" link.

When you create a notice only notice and it is served, on its own, by a banner, the banner doesn't have the "Manage Preferences" link which is the only way to see the details of the notice currently.
The expected behavior is that the banner shows the link when in Notice Only mode.
Screenshot:

@mfbrown  can we confirm this is done?


Event base API implementation

Hello,
Sorry if this has been discussed already, I can not find anything related.
Is there any plan to integrate some kind of event base API into the framework?
For example for Kafka event, instead of adding a Rest API link, adding a topic  name, such as:
@app.subscribe("event_test")

I would be expecting the different query parameter/object marshalling to be working the same way than it does for the usual Rest API.
We can also imagine that response can be returned, which would automatically be sent to an other topic.

Have you looked at https://github.com/encode/broadcaster?

Thanks for the help here @Mause ! :clap: :bow:
If that solves the original problem, then you can close this issue @BennyDjo  :heavy_check_mark:

Sorry for the long delay! 🙈  I wanted to personally address each issue/PR and they piled up through time, but now I'm checking each one in order.


Add hyperlink support

Hi,
First of all thanks for this project. I like the API simplicity for creating the spreasheet files.
I need to define hyperlinks, for example:
new HyperlinkCell("https://github.com/sveinungf/spreadcheetah/", "spreadcheetah's Repository");
where we have the URI and the display text.
Currently, the URI is displayed as plain text, wihtout hyperlink formatting.

I don't know if you have something that covers that scenario already, but I couldn't find it.
Thanks!

Thanks for the feedback!
This is not currently supported, but I'll add it in a future version.

An option could also be to use a HYPERLINK formula, which is supported. It won't get hyperlink formatting automatically, but you can use a style for that:
var urlStyle = new Style();
urlStyle.Font.Color = Color.FromArgb(5, 99, 193);
var urlStyleId = spreadsheet.AddStyle(urlStyle);

var uri = new Uri("https://github.com/sveinungf/spreadcheetah");
var displayText = "SpreadCheetah's Repository";
var formula = new Formula($"HYPERLINK(\"{uri.AbsoluteUri}\",\"{displayText}\")");
var cell = new Cell(formula, urlStyleId);

That's great. Works like a charm.
Well, it's up to you to close this issue if this will be the official approach to creating hyperlinks or leave it open if you'll work on a native approach to it.

Great! I'll close the issue for now. It can be reopened later if there would be a compelling reason for doing it differently.


Fallback to direct read from memory is now in case of any error, not only for ENOSYS

We, at pyroscope.io, are using pyspy & rbspy which both are using this library underneath. For cases when process_vm_readv() is forbidden ( due to seccomp settings in Docker, or by disabling SYS_PTRACE capabilities for user ) the fallback to direct memory read is not working. Imo, it should be possible to do a fallback to direct memory read in case of any case when process_vm_readv() is failing.
Some of our users, who are using Docker, Podman or Heroku, don't have possibilities to change permissions on their platform to be able to use process_vm_readv(). For those cases, the only way is to read memory directly from /dev/<pid>/mem.
@benfred Please take a look at this change. I am open for discussion.

Does profiling with py-spy still work without SYS_PTRACE even with this code?  py-spy also uses ptrace calls to pause the process, to figure out OS threadids and get the native stack trace (though all  of these can be disabled with --non-blocking I guess).
For the uses cases you provided - do you know the error codes that are returned? I think it'd be better to fallback only on known cases, rather than doing this unconditionally.

"Does profiling with py-spy still work without SYS_PTRACE even with this code?"
Yep, it does. Please look at this simple test that I created for this purpose ( remember to clone with --recursive ):
https://github.com/AdrK/test-read-process-memory
Usage:
podman build --no-cache --tag test-read-process-memory .
podman run -it --entrypoint bash test-read-process-memory
Inside container:

Then login to this container in another window and call the test:

Regarding the fallback on specific error. I wonder, why should we care about the reason on which the process_vm_readv() failed? Why would some errors cause a fallback, and other a failure? Imo, we should do a fallback on any error, and not treat error differently. Please let me know what you think. The error caused by process_vm_readv() in my case is EPERM. If you wish I will do the fallback on ENOSYS and EPERM, but please consider the above.

@AdrK from the screenshots that looks like its just testing this crate - I was wondering if py-spy still works (since its doing other ptrace calls than just process_vm_readv which will also be blocked in docker ).

Ahh, sorry, I somehow missed that you are asking about py-spy.
Well, we are using pyspy in non-blocking mode, so there is no ptrace attach & continue calls in our case. But I don't understand why does it matter from read-process-memory point of view? Usage of ptrace might be an issue in pyspy or other spy, but from this crate pov this seems to be not relevant.

@benfred This was addressed here right? https://github.com/benfred/read-process-memory/commit/c2d650df87c02744de0e8729e8fe43b4a7a891f5 If that's the case, then this PR can be closed.


[pigeon] Support static constant values

I'm looking to define constant values to represent error codes.
I can't find any documentation on what happens to any constants that are defined and where they should be defined.
I'm going to try and add them to the class defined for @HostApi .
This does seem to suggest that the documentation should cover off what is permitted in the HostApi and FlutterApi classes.

After testing it looks like constants are not supported.
I would suggest this is a pretty important implementation detail otherwise we will be left to maintain matching constants list on both sides of the wire.
Support for static constants would seem fairly straight forward and solve a large class of problems (including obviating the short term need for enum support).
/// The collection of methods we use to call into the platform code.
@HostApi()
abstract class SoundsToPlatformApi {
  /// The list of specific errors that can be passed from the platform to dart.
  static const errnoGeneral = 1;
  static const errnoUnsupportedCodec = 2;

I have found a way to pass static constants through the api which avoid having to maintain mappings in the host code.
This is still fairly ugly but provides a work around until static consts are supported.
When creating an argument class:
class StartCar
{
int carId;
int mode;
int const_suv_mode;
int const_sports_mode;
}
You then need another 'helper' class.
class StartCardConsts
{
static const suv_mode = 1;
static const sports_mode = 2;
}
When constructing the argument class:
var args = StartCar();
args.carId = xx;
args.mode = StartCardConsts.suv_mode;
args.const_suv_mode = StartCardConsts.suv_mode;
args.const_sports_mode = StartCardConsts.sports_mode;
HostApi().startCar(args);
The resulting java/ios code will now have getters for each of the modes so you can write
if (args.mode == args.getConstSuvMode())

being able to declare consts in the pigeons files and using them across the code seems useful to me as well

Would love to have this


Embedchain upgrade to latest version error

🐛 Describe the bug
Using embedchain version 0.1.124 everything works fine, but when upgrading to 0.1.125, chroma errors occur.
TypeError: SegmentAPI.get_or_create_collection() got an unexpected keyword argument 'embedding_function'

@AbhigyaWangoo Thank you for your reply, but it doesn't work for me.

What specifically won't work for you?

@AbhigyaWangoo


Fix chmod on local path for non-root installs

Current code tries a chmod on /usr/local/bin even for non-root users which fails with chmod: cannot access '/usr/local/bin/taskcat': No such file or directory

Another fix is to make the [[ .. ]] condition POSIX compliant.
On my Ubuntu machine, the install code shows errors
[INITALIZING taskcat Installer!!] /bin/sh: 4: [[: not found /bin/sh: 15: [[: not found Using default tag: latest

@viralmutant  Accepting this pull under Apache 2.0
Apologies for the delay in processing.
approved by tt0119085650


Add Firefox user id 1001 to README common problems

This is a suggestion to add a note in README: Common problems to describe the issue about accessing the Firefox browser in a Docker image.

https://github.com/cypress-io/github-action/issues/735 described about running Firefox in a container and the README: Firefox section used to say:

"In order to run Firefox, you need to use non-root user (Firefox security restriction)."
"Note: the magical user id 1001 works because it matches permissions settings on the home folder, see issue #104"
In the meantime the Firefox example in https://github.com/cypress-io/github-action/blob/master/.github/workflows/example-firefox.yml does not use a Docker container anymore. Firefox was added to the GitHub runner images in March 2020, so it is no longer necessary to resort to using Firefox in a container as far as GitHub is concerned. Using Firefox from a container made the test set up and conditions for the GitHub Action unnecessarily complex.
So now there is no Cypress README document which mentions about using the magical user id 1001 to access Firefox in a container. For completeness, it should probably be described in this repository.

Per the request here, I'm going to open a PR to make this a reality. https://github.com/cypress-io/github-action/pull/938#issuecomment-1590081602

Thanks to @alexjyong this issue has been resolved by PR #900 and can now be closed!


feat(webpack): svg loader rules have been updated

When SVG files are imported (both as ReactComponent or url) and thus inlined in the bundle are also included, in a mistaken way, in the build/static/media and consequence into the asset-manifest.json.
This behaviour is critical when using Service Worker because at the start of the application the browser will send all the pre-cache request for all these SVG files that don't need at all.
This PR resolves #9167
This is a working example created by ejecting the config of a cra template:
my-app.zip

Hi @mrmckeb, following the svgr/webpack documentation (https://react-svgr.com/docs/webpack/) the 'babel-plugin-named-asset-import' seems to be unnecessary, what do you think? It can be removed?

@lucabattistini why not only add the option emitFile: false to the file-loader. This works for me.
            {
              test: /\.svg$/,
              use: [
                {
                  loader: require.resolve('@svgr/webpack'),
                  options: {
                    prettier: false,
                    svgo: false,
                    svgoConfig: {
                      plugins: [{ removeViewBox: false }],
                    },
                    titleProp: true,
                    ref: true,
                  },
                },
                {
                  loader: require.resolve('file-loader'),
                  options: {
                    name: 'static/media/[name].[hash].[ext]',
                    emitFile: false,
                  },
                },
              ],

@artola because according to the webpack v5 doc, file-loader is deprecated in favor of asset modules

excuses for pinging, any progress here?


Adds human-readable ACH parsing to the webui

Ports the human-readable formatting from the command line achcli to the webui.
Note: It might be worth changing the input and output textareas to vertical rather than horizontal to accommodate the wrapping that can happen with the human-readable content.
cc @adamdecaf

Appreciate the PR @markalex; will review soon!

Codecov Report

Merging #933 (50da5a3) into master (e4d4cc1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #933   +/-   ##
=======================================
  Coverage   91.30%   91.30%
=======================================
  Files          66       66
  Lines        5246     5246
=======================================
  Hits         4790     4790
  Misses        283      283
  Partials      173      173

Strange, even on master branch, the web-ui buttons aren't working for me when I run it locally:

I see another altered file locally: wasm_exec.js. I didn't make any changes to it so I did not include it in the PR. Looks like a generated file that is needed given the cp command as the first step in execution
> make build-webui && ./bin/webui
cp /usr/local/go/misc/wasm/wasm_exec.js ./cmd/webui/assets/wasm_exec.js

I'll add it to the PR.

wasm_exec.js comes from the Go distribution you're using. The latest is used when building in CI but we haven't updated it in the git tree. Makes me think we should .gitignore it since that file is autogenerated.

I haven't tried it locally, but assume Mark and Vince have. Looks good!

See what you think now. The button text is simpler and it no longer errors if user attempts to convert a format to itself (JSON -> JSON, for example).

Sweet!

Thanks all for getting this merged!


Batch upsert with AsyncClient fails with Unsupported Media type

Hi,
I tried to make a batch upsert using the AsyncClient:
async with AsyncClient(hostname=CONTEXT_BROKER_HOST, port=CONTEXT_BROKER_PORT, tenant=DEFAULT_TENANT) as client:
    await client.batch.upsert(entities, update=True)

But following error log is produced:
ngsildclient.api.asyn.client - INFO - Connecting client ...
ngsildclient.api.exceptions - INFO - problemdetails={'type': 'Unsupported Media type', 'title': 'Unsupported Media type', 'detail': 'No content type header provided'}
ngsildclient.api.exceptions - INFO - pd_type='Unsupported Media type'
ngsildclient.api.exceptions - INFO - exception=None

With the synchronous client everything works fine.

I did some investigation and it seems that this commented line could be the reason.

Uncomment this line did work for me. I provided a PR, but of course there could be a reason why the header was initially left out that I missed.

Hi,
I totally agree with you. I just needed a hot fix for my PoC :)

Fixed in v0.5.1.


Remove hard-coded paths

Original title: Remove hard-coded paths and URLs

Paths: done
URLs: oh boy

Split: #10


Add file operation

Description
Generated assembly needs to be displayed in a file. Refer to this for python file operations.
Note

Bounty points alloted is only for a single extension per PR.

Can I be assigned ?

can i  be assinged?

@pushkar-gr assigned

can i get assigned

@sid-nc assigned

Can i get assigned next?

@sid-nc  Can you check it ?

O I was unassigned :(

@pushkar-gr open pr

can i be assigned

can I be assigned?

@taruunb assigned

Yo @skudlur what am I supposed to do ?
Ive changed the code for writing it to a file

@pushkar-gr open a PR so I can review

@skudlur how ?

can i use file handling? or do i have to use pathlib?

do i have to use pathlib or can i use file handling?

use file handling

okay

have you recieved the pr?

Will review in sometime and ping you back
On Fri, Oct 13, 2023, 21:18 taruunb @.***> wrote:

have you recieved the pr?
—
Reply to this email directly, view it on GitHub
https://github.com/acmpesuecc/riscv-instr-gen/issues/3#issuecomment-1761734098,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJGTV44BN6FFTX6CJNCETDDX7FPD7AVCNFSM6AAAAAA56CHZFWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRRG4ZTIMBZHA
.
You are receiving this because you were mentioned.Message ID:
@.***>

is this open??

if this is not closed yet
can i get assigned?

can i get assigned if this is still open?

could you check my pr?

can I get assigned to this ?

@PandaTGOS assigned

I was working on another issue can i still work on this ?

can i get assigned to this?

I'd like to be assigned to this.


toposens-library: 1.2.4-1 in 'noetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository toposens-library to 1.2.4-1:

upstream repository: https://gitlab.com/toposens/public/toposens-libraries.git
release repository: https://gitlab.com/toposens/public/toposens-library-release.git
distro file: noetic/distribution.yaml
bloom version: 0.10.7
previous version for package: 1.2.4-4

I'm going to close this PR out, since it is very likely a new bloom release is needed.  If this is in error, feel free to reopen.


How to save and load the npy format model with imagenet-resnet.py?

The provided models for imagenet-resnet.py are in .npy format.  But I didn't find the code for saving or loading npy models in imagenet-resnet.py. There is load-resnet.py, but the Readme says that it is used to load and run the caffe model. Is it possible to use the downloaded models with imagenet-resnet.py?

Yes. Just the --load option. It works for both npy and the checkpoint.

Sorry. It works only for evaluation.
Because for evaluation it has:
        session_init=get_model_loader(model_file),, which supports both format.
However for training it is         config.session_init = SaverRestore(args.load), which only accepts saver checkpoint.

Duplicate of #117 .


Fix Build.cmd to include examples binaries in release zip file

The release zip file includes source files under "examples" folder. the fix is to include examples binaries in release zip file.
Refer to #289

Current coverage is 82.13%

Merging #399 into master will not affect coverage as of 8a2c0d6

@@            master    #399   diff @@
======================================
  Files           45      45
  Stmts         4645    4645
  Branches       416     416
  Methods
======================================
  Hit           3815    3815
  Partial        190     190
  Missed         640     640

Review entire Coverage Diff as of 8a2c0d6

Powered by Codecov. Updated on successful CI builds.


How to setup 10.2 and 10.3 with multiple CD's

So for Jaguar and Panther, there are multiple discs but when you set up only the first disc is bootable, the second disc doesn't boot and the installation after the first disc doesn't boot from the virtual HDD either.
Has anyone been able to get through this issue?

I’ve just used the install DVD, not the CDs.But it should still be possible using the CDs by ejecting the first image and “inserting” the next when prompted.-Em On Nov 19, 2023, at 3:29 AM, mihirpotnis @.***> wrote:
So for Jaguar and Panther, there are multiple discs but when you set up only the first disc is bootable, the second disc doesn't boot and the installation after the first disc doesn't boot from the virtual HDD either.
Has anyone been able to get through this issue?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

Ah yes, I figured out that the boot order has to be setup as HDD first, then CD and then the installation will continue.
Thanks


Renderer folder is not copied when adding it as npm dependency

Had the problem again, that if I installed the package with "@vaadin/angular2-polymer": "file:../angular-polymer", that the whole "renderer" folder was missing in the target project. Had to copy it over manually. Maybe a import is missing?

@BorntraegerMarc I've updated the package.json and .npmignore confix, should fix this. Please try installing with feature/renderer branch.


GH-35537 [MATLAB] Create shared test class utility for numeric arrays.

Rationale for this change
To avoid writing duplicate tests, we created an an Abstract Test Class called hNumericArray which defines tests that can be shared by all numeric array types. Concrete test classes can inherit from this class to automatically get the shared test points.
What changes are included in this PR?

Defined new abstract test class hNumericArray
Modified tFloat32Array to inherit from hNumericArray
Modified tFloat64Array to inherit from hNumericArray

Are these changes tested?

Qualified the tests still pass on macOS.

Are there any user-facing changes?
There are no user-facing changes in this PR. This PR only has test-related changes.

Closes: #35537

@kevingurney would you mind reviewing this?

(I think that @sgilmore10 and @kevingurney did pair programming.)

Ah, +1 then!

@assignUser and @kou - that's correct! @sgilmore10 and I have been pair programming on these MATLAB interface pull requests.


Refactor shuffling logic

So, my current implementation of shuffling feels more and more inconsistent then more I look at it. I would like to improve it, but I have some concerns.
Currently, when shuffle is enabled, there is no stopping point. Each song in the stream is randomly played once and then all songs become eligible to be played again. I think that once all songs have been played once that playback should not continue UNLESS 'repeat stream' is enabled.
This brings a couple of problems:

What happens if the user presses 'Skip song' and they are on the last eligible song in the shuffle. Should playback just stop? Should all items in the stream become eligible targets for shuffling again? I feel like either of these scenarios would warrant a notification indicating why playback just stopped or why the entire stream just started over.

What happens if the user skips through all songs but one, pauses Streamus for a day, then comes back. They hit play, that song ends, playback stops. I guess a notification should be shown saying that all songs have been exhausted and they'll need to hit play again?

Another concern that was brought to my attention was the fact that shuffling currently always plays the first song in the stream before randomly selecting the rest. I agree that this is a problem, but I have some concerns:

Should the active song change when shuffle is toggled on/off? My thought is 'No, this is just a state and your active song is not affected'

So, when adding a playlist to an empty stream, if shuffle is enabled, the first active song in the stream should be random instead of first by index. However, the button for 'toggle shuffle on/off' is hidden until your stream has items in it. This means it is not possible to enable or disable shuffling through the UI until a playlist is added. That's a bad UX. So -- maybe all the buttons should always be shown even if your stream is empty?

I'll add other concerns as they arise.

Also, investigate #309 when refactoring shuffling.

Also, I want shuffling to start at a random index if you add a playlist to an empty stream with shuffling enabled. It's no good to start on the first song every time.

When shuffling has been enabled and you skip through some songs, then disable shuffling, should it go back to previous song played by history or by sequence?


Provide prebuilt AMI image per region

What happened:
We currently rely on the user to build their packer images. This takes a while and will potentially a bad first impression with new users
What you expected to happen:
I would like to have some AMI published with every release that are used by default, if no local AMI is found.

/assign


Enable AV1 decoding in MSDK

Signed-off-by: Yan Wang<EMAIL_ADDRESS>

@wangyan42164 do you have a patch to enable AV1 in sample_decode? I'd like to have a try with AV1.

@wangyan42164 do you have a patch to enable AV1 in sample_decode? I'd like to have a try with AV1.

https://github.com/Intel-Media-SDK/MediaSDK/pull/2080

@xhaihao You need the following cmake command to build MSDK with this PR:
cmake -DMFX_ENABLE_AV1_VIDEO_DECODE=ON -DAPI:STRING=latest

@wangyan42164 do you have a patch to enable AV1 in sample_decode? I'd like to have a try with AV1.

#2080

Thanks @dvrogozh

@xhaihao You need the following cmake command to build MSDK with this PR:
cmake -DMFX_ENABLE_AV1_VIDEO_DECODE=ON -DAPI:STRING=latest

Thanks for the info @wangyan42164

vainfo output shows AV1 decoding is supported on my machine,
$> vainfo | grep AV1
libva info: VA-API version 1.8.0
libva info: User environment variable requested driver 'iHD'
libva info: Trying to open /usr/lib/x86_64-linux-gnu/dri/iHD_drv_video.so
libva info: Found init function __vaDriverInit_1_8
libva info: va_openDriver() returns 0
      VAProfileAV1Profile0            : VAEntrypointVLD
      VAProfileAV1Profile1            : VAEntrypointVLD

However the command below doesn't work for me
$> sample_decode av1 -i av1.ivf

[ERROR], sts=MFX_ERR_UNSUPPORTED(-3), AllocFrames, m_pmfxDEC->Query failed at /home/xhh/graphics/ex/gstreamer/MediaSDK/samples/sample_decode/src/pipeline_decode.cpp:1138

[ERROR], sts=MFX_ERR_UNSUPPORTED(-3), Init, AllocFrames failed at /home/xhh/graphics/ex/gstreamer/MediaSDK/samples/sample_decode/src/pipeline_decode.cpp:557

[ERROR], sts=MFX_ERR_UNSUPPORTED(-3), main, Pipeline.Init failed at /home/xhh/graphics/ex/gstreamer/MediaSDK/samples/sample_decode/src/sample_decode.cpp:745

AV1 is not supported in both GetMaxWidth () and GetMaxHeight ()
https://github.com/Intel-Media-SDK/MediaSDK/blob/master/_studio/mfx_lib/shared/src/mfx_vpx_dec_common.cpp#L31-L57
After working around the above error, I got another error
$> sample_decode av1 -i av1.ivf

[ERROR], sts=MFX_ERR_INVALID_VIDEO_PARAM(-15), Init, m_pmfxDEC->Init failed at /home/xhh/graphics/ex/gstreamer/MediaSDK/samples/sample_decode/src/pipeline_decode.cpp:565

[ERROR], sts=MFX_ERR_INVALID_VIDEO_PARAM(-15), main, Pipeline.Init failed at /home/xhh/graphics/ex/gstreamer/MediaSDK/samples/sample_decode/src/sample_decode.cpp:745

AV1 is not supported in CheckFrameInfoCodecs ()
https://github.com/Intel-Media-SDK/MediaSDK/blob/master/_studio/mfx_lib/shared/src/mfx_common_int.cpp#L193-L301

vainfo output shows AV1 decoding is supported on my machine,
$> vainfo | grep AV1
libva info: VA-API version 1.8.0
libva info: User environment variable requested driver 'iHD'
libva info: Trying to open /usr/lib/x86_64-linux-gnu/dri/iHD_drv_video.so
libva info: Found init function __vaDriverInit_1_8
libva info: va_openDriver() returns 0
      VAProfileAV1Profile0            : VAEntrypointVLD
      VAProfileAV1Profile1            : VAEntrypointVLD

However the command below doesn't work for me
$> sample_decode av1 -i av1.ivf

[ERROR], sts=MFX_ERR_UNSUPPORTED(-3), AllocFrames, m_pmfxDEC->Query failed at /home/xhh/graphics/ex/gstreamer/MediaSDK/samples/sample_decode/src/pipeline_decode.cpp:1138

[ERROR], sts=MFX_ERR_UNSUPPORTED(-3), Init, AllocFrames failed at /home/xhh/graphics/ex/gstreamer/MediaSDK/samples/sample_decode/src/pipeline_decode.cpp:557

[ERROR], sts=MFX_ERR_UNSUPPORTED(-3), main, Pipeline.Init failed at /home/xhh/graphics/ex/gstreamer/MediaSDK/samples/sample_decode/src/sample_decode.cpp:745

AV1 is not supported in both GetMaxWidth () and GetMaxHeight ()
https://github.com/Intel-Media-SDK/MediaSDK/blob/master/_studio/mfx_lib/shared/src/mfx_vpx_dec_common.cpp#L31-L57
After working around the above error, I got another error
$> sample_decode av1 -i av1.ivf

[ERROR], sts=MFX_ERR_INVALID_VIDEO_PARAM(-15), Init, m_pmfxDEC->Init failed at /home/xhh/graphics/ex/gstreamer/MediaSDK/samples/sample_decode/src/pipeline_decode.cpp:565

[ERROR], sts=MFX_ERR_INVALID_VIDEO_PARAM(-15), main, Pipeline.Init failed at /home/xhh/graphics/ex/gstreamer/MediaSDK/samples/sample_decode/src/sample_decode.cpp:745

AV1 is not supported in CheckFrameInfoCodecs ()
https://github.com/Intel-Media-SDK/MediaSDK/blob/master/_studio/mfx_lib/shared/src/mfx_common_int.cpp#L193-L301

Thanks for test. Give me one second.
Let's make sure it is library or sample_decode issue.

@xhaihao I have updated this PR. Could you please try it again? I have tested it by sample_decode on my side. Thanks.

@wangyan42164  Thanks for the new version. It works for most cases but I still get errors for a few cases. I may share you the clips if you need them.

@wangyan42164 Thanks for the new version. It works for most cases but I still get errors for a few cases. I may share you the clips if you need them.

Please share them for more investigation. Thanks.

@wangyan42164  Thanks for the new version. It works for most cases but I still get errors for a few cases. I may share you the clips if you need them.

Please share them for more investiagtion. Thanks.

@wangyan42164  Thanks for the new version. It works for most cases but I still get errors for a few cases. I may share you the clips if you need them.

Please share them for more investiagtion. Thanks.

We plan to fix it later.


Is there a way/workaround to print non-ascii characters?

Is there a way/workaround to print non-ascii characters?
Either by in int 10h or in video memory in 32-bit mode? Or is there a hardware/bios limitation?
It could be a weird question but I would like to know if this can be achieved.
If not, so the only way is to draw the non-ascii characters using graphics mode?

When the BIOS loads the kernel, it olny knows about the stack, pointers, and ASCII.


[Feature] Expect to leak an API specified cell to add an icon button, and can implement a click event

初始清单

[X] 这真的是个问题吗？
[X] 我已经在 Github Issues 中搜索过了，但没有找到类似的问题。

问题
Expect to leak an API specified cell to add an icon button, and can implement a click event，Similar to the filter button

You can fully extend it yourself through registerSheetMainExtension. We currently have no plans to design other ways for users to directly extend Canvas.


Enhance Regex Support in Standard Library for JS Backend

This pull request significantly improves regex support in Effekt's standard library for the JavaScript backend. It introduces capture groups, group indices, and regex flags, addressing current limitations and providing a more powerful regex interface.
Key Enhancements:

Support for capture groups and their indices
Implementation of regex flags
Stateful regex object for sequential matching

Current Limitations:
Effekt's regex support is currently limited, lacking support for capture groups and advanced regex features. This implementation bridges this gap for JavaScript environments.
New Features:

Capture Groups: Ability to use and access capture groups in regex patterns
Group Indices: Retrieve the starting index of each capture group
Regex Flags: Support for standard regex flags (e.g., 'i' for case-insensitive matching)
Stateful Matching: Global flag ('g') set by default for sequential matching

Backwards compatibility
This change is not backwards compatible.
Feedback on the API design and usability from experienced Effekt developers is highly appreciated.

The tests are failing since examples/casestudies/lexer.effekt.md uses text/regex.
Here are some more modules importing text/regex: https://github.com/search?q=repo%3Aeffekt-lang%2Feffekt+"text%2Fregex"+path%3Aexamples%2F**%2F*.effekt&type=code

The tests are failing since examples/casestudies/lexer.effekt.md uses text/regex. Here are some more modules importing text/regex: https://github.com/search?q=repo%3Aeffekt-lang%2Feffekt+"text%2Fregex"+path%3Aexamples%2F**%2F*.effekt&type=code

I refactored the lexer example to account for the changes. The other occurrences shouldn't be affected since I'm only changing the JS backend? Please correct me if I oversaw anything.

Thank you for your thorough review. I've implemented your suggestions, making the code more idiomatic. The addition of typed flags should notably enhance usability. I plan to add the test cases tomorrow.

I'll take a look. This error usually means that UFCS (foo.bar(baz) standing for bar(foo, baz)) failed.

Is there a way to run certain tests only for the JS-Backend? I would like to add test for the new features, but it seems that the chez-backend is not happy with that. At least I have no trouble running the test succesful on my machine using only the JS-Backend.

You can add the file into ignored here for the backends it should not run on together with a comment why it's disabled: https://github.com/effekt-lang/effekt/blob/master/effekt/jvm/src/test/scala/effekt/StdlibTests.scala
So for example for Chez-$something backends:
abstract class StdlibChezTests extends StdlibTests {
  override def ignored: List[File] = List(
    // Not implemented yet
    examplesDir / "stdlib" / "bytes",
    examplesDir / "stdlib" / "io",

    // Not implemented: advanced regex features
    examplesDir / "stdlib" / "string" / "regex.effekt",
  )
}

It looks like this test even fails on JS:
https://github.com/effekt-lang/effekt/actions/runs/10919082132/job/30306075187?pr=592#step:11:402

It seems to work for me locally so it might be a NodeJS version issue?
Did the API for regexes change there?

Don't know how to resolve this if we want to keep the functionality. We could update NodeJS: that might be a wise move anyway since even the extended support for NodeJS 12.x ended 2 years and 4 months ago (30 Apr 2022). Current oldest somewhat supported LTS version is NodeJS 18.x (where security support ends in 7 months).

EDIT 2: I think that NodeJS 12.x does not support the d (GenerateIndices()) flag since it was only introduced in ES9 and implemented in NodeJS 16.x according to MDN.

I just tested it locally and can confirm that. I will try to add a condition that the d flag will only works if the node version is   >16.x and change the test to only run if node is >16.x
Do you see any problems with that?

We can just require a newer node version, that shouldn't be a problem.

Thanks for the PR! I think it is great to have improved regex support in the language.
I have one major concern, which is the compatibility with the LLVM backend. In general, I do not care so much anymore about the Chez and ML backends. However, we should aim for feature completeness of the LLVM backend.
Adding JS-only features now will make this more and more difficult in the future.
@phischu what is your opinion when viewing this from the LLVM perspective?

Which of the extensions that are proposed in this PR are compatible with the regular expressions in POSIX?
(https://www.man7.org/linux/man-pages/man3/regex.3.html)

master is updated to NodeJS 16.x, you can just revert the last commit and rebase :)

To clarify: I am not proposing that you should implement the LLVM part. I just want to know what the intersection between posix regex and your proposed features is.

Which of the extensions that are proposed in this PR are compatible with the regular expressions in POSIX?
(https://www.man7.org/linux/man-pages/man3/regex.3.html)

The POSIX standard for Regex does only include basic support for capture groups. Only the extraction of the content is possible here, but generating indices for those is not. Stateful matching is definitely not known in the POSIX world.
Flags are a bit more difficult in compatibility. Usually flags are passed as additional command line arguments which makes it dependent on the used program if they are compatible or not.
Does that answer the question?

u can just revert the last commit and rebase

Thank you :)

I have implemented the following changes as suggested previously:

The Global Flag is now handled directly. The exec function returns a Regex object that captures the string in the capture field. This allows subsequent calls on the returned object to iterate (lazily) through all matches. A shorthand for map on the Regex Object is provided, which maps directly onto the captured Match for an ergonomic API. This also eliminates the need for a global or io modifier to prevent inlining. Both attributes previously prevented the use of regex queries in areas where these effects are not allowed.
The examples have been added to the tests and verified to work as expected.
The GenerateIndices flag has been removed as an option and is now enabled by default.

Please feel free to share your thoughts on the current design.

Currently, the tests fail for both LLVM and the Chez backend because they lack the flags interface. To proceed, I will disable the regex tests on those backends. As long as the regex engine of a backend supports flags, implementing those should be straightforward, as the only stateful Flag (Global) is now directly expressed in Effekt.


New version: PrismLauncher.PrismLauncher version 7.2

[x] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-pkgs/pull/113683&drop=dogfoodAlpha

didn't see that there was a pr already


Open in browser

Adds a new command to open a service URL in Browser. Does a bit of refactoring to use knative model objects and reference them from the UI objects.

looks good, thanks for the help


missing 'train' module

trying to follow this document: https://www.tensorflow.org/versions/r0.9/how_tos/distributed/index.html
can't import tf.train because train doesn't exist.
i looked through the repo; it appears that's a correct appraisal. TF does not have a train package.
??

Please do fill in the issue template to include more info.
tf.train should work and many people run the classes in it regularly.

Automatically closing due to lack of recent activity. Please reopen if further information becomes available.


Add RHDEVDOCS-2965

JIRA: RHDEVDOCS-2965

My comments are suggestion for future work on this doc. It all looks great, so I simply made suggestions if the doc gets edited or revised down the line.

LGTM from docs point of view!

Thanks a lot @jc-berger
Here is a new PR to address them: https://github.com/redhat-certification/chart-verifier/pull/119


Attempt Gothic 1 port

Progress (Branch gothic1)

[x]  Port ConsoleCommands to Gothic 1 (see LeGo dev branch)

[x] Resolve parsing errors: The scripts are fully parsable without any problems

[ ] Find addresses (and hope that all functions are similar to Gothic 2). Proceed in this order, to fail ASAP (find out it does not work rather sooner than later)

Mouse movement and disabled auto turning:

mouseUpdate == sub_4D3D90_X from LeGo
Cursor_Ptr
Cursor_sX
Cursor_sY
oCAniCtrl_Human__Turn
oCNpc__TurnToEnemy_737D75

Shooting projectiles in manual direction:

oCAIArrow__SetupAIVob + stack offsets (function arguments)
zSinCosApprox
zCVob__GetRigidBody
zCRigidBody class offsets

Trace ray and focus collection:

zCWorld__TraceRayNearestHit_Vob
zTTraceRayReport class offsets
zCArray_zCVob__IsInList
zCVob__TraceRay
oCNpc__SetFocusVob
oCNpc__SetEnemy

Aiming animation:

oCAIHuman__BowMode_696296 + stack offsets (function arguments)
oCNpc__GetAngles

When reaching here, free aiming itself should work, proceed with the remaining addresses in no particular order

[ ] Resolve discrepancy between hit chance calculation (skill level (G2) versus dexterity (G1))

[ ] Replace attaching FX to the aim vob by Wld_PlayEffect (in Gothic 1, since it does not support oCItem.effect) or remove the trail strip PFX from the PFX file completely in Gothic 1. Attach the suffix _G2 to the other PFX file

[ ] Adjust critical hits for Gothic 1: The damage is doubled and, unlike in Gothic 2, allows exceeding the protection values of the target when a normal shot wouldn't (this is desired in Gothic 1 and already happening in its default damage calculation!)

[ ] Re-integrate freeAimCriticalHitAutoAim() into the core scripts for both Gothic 1 and Gothic 2 and return a different critical hit chance for Gothic 1 (e.g. return Npc_GetTalentValue(hero, NPC_TALENT_BOW);).

Before anything, the console command package of LeGo needs to be ported. Two engine addresses need to be found.
Side note: For Gothic 1 compatibility, the Ikarus class oCNpc needs to be adjusted (in the Gothic 1 scripts):
oCNpc.name1 -> oCNpc.name_1

Progress:

ConsoleCommands implemented (see LeGo dev branch)
Resolved parsing errors: The scripts are fully parsable without any problems

Left to do:

Find addresses (and hope that all functions are similar to Gothic 2)
Resolve discrepancy between hit chance calculation (skill level (G2) versus dexterity (G1))

Instead of oCNpc.name1, you can use offset, which in combination with MEMINT_SwitchG1G2 and  makes sciritps compatible even with class differences...

Thanks, it is corrected in LeGo (see revision 127)
@CarnageMarkus Do you remember how you got the address for the cursor movement for Gothic 1 (sub_4D3D90_X)? I am not sure if this address is correct. In Gothic 2 it is correct, but in Gothic 1 a hooked function is called way too often (approximately 100x per frame). This causes the game to freeze.

@CarnageMarkus The address 0x4C7F40 works better for me. I will test it with the cursor functionality and update it in the LeGo SVN if it works.

Gothic 1 does not make (consistent) use of the camera modes. Instead, for magic and ranged combat the normal camera mode is used. The free aiming camera mode is necessary to have the head of the player model not obstruct the reticle.
In order to fix this problem, the op code has to be overwritten at every position where the camera modes are set for magic and ranged combat. This will take a while.

Projectiles in Gothic 1 are destroyed on impact. There is no implementation of bouncing off. Consequently, there is a lot less possible with respect to collisions and collectable projectiles. Handling of the projectile AI (oCAIArrow) is quite different from Gothic 2, but might still be close enough to implement projectiles that are stuck in the surface. If that is not possible, the collectable projectile feature will not be implemented in Gothic 1.

The provisional trial strip for Gothic 1 (PFX) is not very pretty and has to be improved.

Adjust recoil for Gothic 1. The mouse movement is of different speed. The recoil impact needs to be generally higher,

The mouse is very squishy in Gothic 1: The camera keeps on moving when the mouse already stopped, and eases into the new position. This should be fixed to have more responsive aiming.


cmdlets are not persisted when executed in sequence too quickly

Hello, is there any documentation around what the delay should be when performing back to back cmdlets with TPM?
We are noticing that when perform grant commands in sequence (say Granting different policies to a user). If we execute them too quickly in sequence, the changes are sometimes not persisted.

Hi @ckarawani,
Would suggest raising a support request with details on the Teams PowerShell Module version used, Specific cmdlets & the user(s) this persistence issue happened with. Team can check and suggest accordingly.

@ckarawani Considering the nature of the issue, as advised, please open a service ticket in your tenant and follow with them for the resolution. We proceed to close it as here we are limited to documentation fixes and improvements only.
We will be very happy if you can share the outcome or resolution with us if you see documentation update is required. We will certainly update this documentation with that valuable information. Thanks again, for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.

@yogkumgit this behaviour is consistent across  multiple tenants and is been noticed since I can remember (since 2.3.1 at least).
I think it needs to be documented if the cmdlets do not support chaining or should not be run sequentially without some form of delay.

been noticed since I can remember (since 2.3.1 at least).

Just to point out, I have a noticed the same behaviour in my tenant.

Hi @ckarawani & @f0oster,
Can you please try this scenario now with the latest Teams PowerShell Version and confirm? There have been improvements recently on this.
Also, this behavior is not expected with the latest versions, so if you still see any issues - would suggest raising a support request with the details around the tenant and the cmdlets used etc. for the team to check.
@yogkumgit - No documentation changes for this are needed at this time.
Regards,

hey @pbafna03, are there specific resources I can send pwsh transcripts to?
365 Support has communicated multiple times to us that they do not support TPM for Pwsh and they can only really support uses cases revolving web administration via browser.
From what I can tell, it's still present on the older commands that are still recycling the older Sfb commands such as the "Grant" commands for policies, but I can certainly put some time to confirm this.

Hi @ckarawani ,
Grant commands for policies have also gone through modernization in the latest versions.
If you still notice this with the latest versions, best is to report via Support only - https://docs.microsoft.com/en-us/microsoft-365/admin/get-help-support?view=o365-worldwide. Can reference that the issue is being faced with the Teams PowerShell Module latest version #, so that it reaches the relevant team.

hey @f0oster, just wanted to circle back on this. I cannot reproduce this problem anymore using latest TPM 4.3.0 as I
have successfully chained a bunch of Grant commands which were correctly persisted immediately.  Thank you @pbafna03 for the follow up on this and sorry it took a while to get back to you.

hey @f0oster, just wanted to circle back on this. I cannot reproduce this problem anymore using latest TPM 4.3.0 as I have successfully chained a bunch of Grant commands which were correctly persisted immediately. Thank you @pbafna03 for the follow up on this and sorry it took a while to get back to you.

Thanks for the info. I'll be sure to test also.


Rebuild for gdal34 and geos3101

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

We have a narrow dependency path here, see conda-forge/gdal-feedstock#585 , so lets try migrating geos and gdal at the same time.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Hmmm, dependencies are resolved now, but cmake is failing :/
2021-12-04T21:00:44.0145866Z CMake version: 3.21.3
2021-12-04T21:00:44.0245534Z CMake Error: CMake was unable to find a build program corresponding to "Unix Makefiles".  CMAKE_MAKE_PROGRAM is not set.  You probably need to select a different build tool.
2021-12-04T21:00:44.0246566Z CMake Error: CMAKE_C_COMPILER not set, after EnableLanguage
2021-12-04T21:00:44.0247553Z -- Configuring incomplete, errors occurred!

If you want me to tighten up the git history, I certainly can, please let me know. Hopefully this is all green.

I went ahead and cleaned it up, hopefully I did not jinx it :)

@akrherz great! Thanks!


(Temporary Draft) feat/publish groundtruth as trackedobj (for S/P evaluation)

Types of PR

[ ] New Features
[ ] Upgrade of existing features
[ ] Bugfix

Link to the issue
Description
How to review this PR.
Others

Formal version of this feature is merged in https://github.com/tier4/scenario_simulator_v2/pull/1024. So, I close this temporary PR.


Fix the signature and function body of the disconnect function.

Function disconnect should not have a message parameters. It's not get passed to the stomp function (https://github.com/jmesnil/stomp-websocket/blob/master/src/stomp.orig.js#L138).


Update API documentation to clarify which APIs cache data, memory implications & relevant ReplicatorConfig settings

Update API documentation to clarify which APIs cache data, memory implications & relevant ReplicatorConfig settings as per this request: https://github.com/Azure/service-fabric-issues/issues/1427

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 81cce417-df6e-bbac-5083-9e48f5efd6b2
Version Independent ID: e713be8d-2f15-11c6-4e85-32de85e1cc3a
Content: Guidelines & Recommendations for Reliable Collections in  Azure Service Fabric
Content Source: articles/service-fabric/service-fabric-reliable-services-reliable-collections-guidelines.md
Service: service-fabric
GitHub Login: @TylerMSFT
Microsoft Alias: twhitney

Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.
CC @aljo-microsoft @masnider

@MedAnd
API documentation is here for Reliable Collections:
https://docs.microsoft.com/dotnet/api/microsoft.servicefabric.data.collections?view=azure-dotnet

@aljo-microsoft - for full details please refer to production support request ID<PHONE_NUMBER>00319 which we are still working through with @zuhairp assistance.
In summary this request is to update the public documentation for all ReliableDictionary APIs to clarify the affect on memory of calling different Reliable Collection methods.
For example:

Does TryGetValueAsync(ITransaction, TKey) cache the TValue of a TKey in memory?
For how long is the TValue value cached by default?
Under high load scenarios how can any default caching time be reduced, are there any settings to control the caching & cache invalidation/clean-up behavior?
Does ContainsKeyAsync(ITransaction, TKey) cache the TValue of a TKey in memory etc?
Does CreateKeyEnumerableAsync(ITransaction) cache the TValue of a TKey in memory or is each TKey/TValue pair loaded from storage per iteration and never cached by default?

PS. Hope the above makes sense?

@preethasubbarayalu
Could you provide content for this question?

Friendly ping... any update 😎 ?

@MedAnd

Does TryGetValueAsync(ITransaction, TKey) cache the TValue of a TKey in memory?

Yes

Does ContainsKeyAsync(ITransaction, TKey) cache the TValue of a TKey in memory etc?

All the keys are in memory always. Value are removed from memory depending upon sweep policy.
In ContainsKeyAsync, TValue is not loaded so it is not cached.

Does CreateKeyEnumerableAsync(ITransaction) cache the TValue of a TKey in memory or is each TKey/TValue pair loaded from storage per iteration and never cached by default?

CreateKeyEnumerableAsync only iterates over keys, which are always in memory in today's implementation. So, values are not loaded in this API calls.
See tstore.cs CreateKeyEnumerableAsync, especially ReadMode.Off which means don't read value.
In CreateEnumerableAsync which returns key and values, we only read values but don't cache it, otherwise, we will have to cache the whole db as we are enumerating over all keys/values. See, Readmode.ReadValue at tstore.cs CreateEnumerableAsync
The third enum of ReadMode is CacheResult which is used when you read only one key as here

@MedAnd, I believe the above response should satisfy the question.
#please-close

@Nickomang - will the above clarification be expanded & included in the official Service Fabric documentation & best practices?


add release automation script

As the title.

The output of this automation script is like the diff in this PR
https://github.com/splunk/eventgen/pull/337


Update action-progress

Option to display remaing time in ticks
Expand support for amethyst items

I merged #4719 so this PR conflicts now... Why did you open 2 PRs instead of just updating the other one you'd already created?

To be honest... I thought #4719 was already merged when I created this, but I didn't double check, sorry!


embed: support user defined grpc services.

Fixes #7200
Hi again,
My original design does not progress well, the main problem is that the code generated by gRPC does not export corresponding ServiceDesc. Please refer https://github.com/grpc/grpc-go/blob/master/examples/helloworld/helloworld/helloworld.pb.go#L123
It seems we have to setup a func(*grpc.Server) instead.
/cc @xiang90 @heyitsanthony

Current coverage is 64.08% (diff: 20.00%)

No coverage report found for master at 89f7cc5.

Powered by Codecov. Last update 89f7cc5...4374d94

looks good to me. Defer to @heyitsanthony

lgtm

@disksing Thanks!


docs: fix broken link adr-008-app-caller-cbs.md

Description

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against the correct branch (see CONTRIBUTING.md).
[ ] Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
[ ] Code follows the module structure standards and Go style guide.
[ ] Wrote unit and integration tests.
[ ] Updated relevant documentation (docs/).
[ ] Added relevant godoc comments.
[ ] Provide a conventional commit message to follow the repository standards.
[ ] Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
[ ] Re-reviewed Files changed in the GitHub PR explorer.
[ ] Review SonarCloud Report in the comment section below once CI passes.

is this an actual broken link? I seem to be able to access it? (ref https://ibc.cosmos.network/architecture/adr-008-app-caller-cbs/)
maybe .md is assumed suffix?

@DimitrisJim when i navigate around the code (vs-code), it seems does not work.
if it is not intended behavior, i think we can close the PR
thanks for reviewing anw

Within the context of the github repository I think the link is probably fine and works correctly. I think if you're navigating using your local dev env then it may attempt to take you to the root of your filesystem and then it is sad.
We can change if you want ¯_(ツ)_/¯ I don't feel strongly

Since the links work, I'll close this for now :)


Switch from serializing podcasts and saving them as a JSON in the local storage folder to a database using EntityFramework with SQLite

See EF 7 documentation

Hey,
Willing to help you on this one.

Sure thing. Not sure how well it's documented for UWP, but you can try taking a look here.

Getting started with UWP: https://docs.efproject.net/en/latest/platforms/uwp/index.html

Yep, was going to follow this.
From what i see in the project implementing ILocalStorageService would be enough (and maybe renaming the interface to support both storage methods).
One question though : do you want to store the same way (blob like) or relational with tables ?
Also would you mind adding hacktoberfest label ? :blush:

I think having it relational would help us in the long run :)
You can rename to be a little more generic. Can't wait to see what you come up with :)

@jeromechrist do you mind If I create the pull request? I will be easier to track your changes like that, rather than reviewing the whole thing at the end.

@robertiagar sure go ahead, i just finished a few minutes ago.
I've added the corresponding unit test, passing

You can still go back to using LocalStorage, injecting the service in simple IoC still works like previously.
A few noteworthy details :

I had to change Uri types to string from Podcast & Episode entity because EF couldn't figure out how to store it (which is understandable since it's a complex type).  I think it's achieveable through the InitialMigration Migration class if you specifies the mapping to be a string but it adds complexity / hide the concrete DataModel from just looking at the entities.
I've added relations between Podcast / Episode with navigation properties and Ids used by convention by EF (see PodcastId & EpisodeId)
Migrations are applied when AppShell is instanciated : not sure if it's the best place, typically we put that kind of logic inside the bootstrapper of the App

an exemple of what is store inside the SQLite database :

Let me know if you need some changes.

I can do a squash commit if you'd like to see all the changes in 1 commit.

Created the pull request and left 1 comment, did you get it?

@robertiagar yes, done !

@jeromechrist thanks for the help, I merged it. There are a few more issues, that are open if you're willing to help out :)


Added Opus TedTalks

Dataset : http://opus.nlpl.eu/TedTalks.php

@lhoestq I saw some common changes you made on the other PR's (Similar Opus Datasets). I fixed those changes here. Can you please review it once ?
Thanks.

merging since the CI is fixed on master


External Metadata Loading Changes/Fixes

Added json import for laika.py for external metadata load, calls were present, but never imported.  Also added cloudscan.py ability to pull meta data from file similar to that of laika.py.

Hello rc1405,
Thanks for your contribution. I think it makes a lot of sense to keep the two clients in line with each other in terms of functionality.
The code looks good overall, but I would like one minor change before we accept it. For the code base, we try to standardize on 4 spaces to break apart the code blocks. I see that you only used two. If you wouldn't mind updating the code, I would be happy to get the pull request in.
Thanks!

Indentations fixed.  Thanks!

Thanks rc1405!


Rewrite promises to allow callback option

New promise allows to create:

a promise from another publisher, as before, but this time if the publisher finishes before sending at least 1 event, the promise will fail with an specific error (Observable.Single semantic)
as before, if the publisher decides to emit more than 1 event, only 1st is sent to downstream
now there's a brand new option to create Promise from callback... Optionally the operation can event be cancellable, like this:

Publishers.Promise<String, Error> { completion in
    DispatchQueue.global().asyncAfter(deadline: .now() + 2) {
        completion(.success("42"))
    }
    return AnyCancellable {
        // Optionally cancel actions in here.
        // Or keep variables in order to keep reference-type alive, for example:
        // _ = somethingToHoldStronglyWhileOperationIsOngoing
        // The _ is enough to keep it alive :)
    }
}.sink { result in
    print(result)
} receiveValue: { value in
    print(value)
}

tests

This Promise will also beautifully bridge to Swift co-routines! When time comes, I will create inits and variables to go back and forth between Promise and co-routines, which means, you will be able to write an entire function in co-routine (async func, merging thing using await or async let), and then, once you want to compose the co-routines chain with a Combine chain, it's just a matter of wrapping it in a Promise :)


Some sort of title over input fields in addition to having the selected page look different?

Not needed


any way to save or make a config of the settings

any way to save the settings, its so annoying to have to put in my settings every time I join a game.

added


#F02 Footer html content

@JimLynx
Adding initial content and layout for footer so that it can be styled accordingly.
Links can be adapted to whatever content (Privacy Policy, FAQ etc) is included in the footer later

@JimLynx  is this a duplicate of #53 ?

ok so html content and styling are 2 separate or one combined pull?

@JimLynx they're essentially the same thing you're working on, just HTML and CSS, would technically be two commits if you want, but I suppose if you want to split that into two PRs 🤔 Could add the HTML, un-styled, request the PR to go through, then after sorted, work on the CSS as a second PR. I don't think we need two separate "issues" though.

@JimLynx I'll go ahead and close this "Issue" here, and if you could go ahead and continue working on #53 . Thanks!


API for password reset

fix #19
API URI : https://main-cu-coders.herokuapp.com/forget
Method: POST
Expected params: email
Responses :

property name
value
message
description

success
true
Please visit your e-mail inbox for reset link
Reset link generated and sent to the user

success
false
User is not registered
Email id is not valid

success
false
Internal server Error
Database connection error

Postman results

https://deepsource.io/gh/cu-coders/backend/run/0d1b636a-0c64-4135-a2cb-aa72ef887b3b/javascript/


Validate main file if referenced file changes

if I change included file it doesn't revalidate main file.
Original plugin is somehow aware of included files and applies linter to master file if included is changed.

In the original extension, it maintains the dependency relationship dynamically. It's kind of over-engineered.
A simple workaround is to re-validate all open documents.

Or:
for file in openedFiles:
    if file.content.contains(changedFile):
        lint(file)

Not 100% accurate but should be good enough.

Fixed. There is a minot limit: you need to save the referenced file in order for the main file to catch the change.


added lang support for go, js, and cs

Went ahead an implemented the lang support for go, cs, and javascript.
One thing I believe we need to come to consensus of is the version of each compiler/interpreter that should be downloaded. As it stands, the most recent version is downladed through 'sudo apt-get install [compiler/interpreter]'. But this may not match up with the language versions hardcoded in the program/may break the endpoints with future updates. Thus, as aforementioned, I propose we standardize the version downloaded in the apt-get install command to avoid such inconsistencies. Wanted to run it by you first though Jaagrav.
Thanks for the great api. Cheers!

Thanks for the PR, will do some checks before I deploy this.
I agree with what you say, in fact I was planning on making that hard coded version part dynamic, i.e. use spawn in order to get the version and return the compiler version instead how it is currently. I got a bit lazy there but yes thanks for bringing light to this, will fix it soon. Standardizing the version might not be the right way to do this, instead keeping it latest and returning the right version would probably be better, what do you think?

Thanks for the PR, will do some checks before I deploy this.
I agree with what you say, in fact I was planning on making that hard coded version part dynamic, i.e. use spawn in order to get the version and return the compiler version instead how it is currently. I got a bit lazy there but yes thanks for bringing light to this, will fix it soon. Standardizing the version might not be the right way to do this, instead keeping it latest and returning the right version would probably be better, what do you think?

Yeah, I think the dynamic approach/using the latest version is also ideal!


add best/worst stats to stats page

add highlighting to the best stats for particular stats

most entries
most wins
-most losses
etc

dont need this atm


stop to discovery addon when its managed cluster is not found

Signed-off-by: Wei Liu<EMAIL_ADDRESS>

/cc @ldpliu please take a look at cluster set e2e part, thanks

/cc @ldpliu please take a look at cluster set e2e part, thanks

It looks good to me

/lgtm


Add auganizer 1.1.4

Thank you for the contribution. It will be merged in a different pull request due to some simple recommended alterations. Your contribution is still included (and still credited to you), with the appropriate modifications, when applicable.
Changes:

Empty lines were in the wrong places.

OK, I'll keep the convention in mind for future PRs!