Use javascript api build to build .vue errror, in lib mode

Describe the bug
When I use javascript api to build vue lib, there an error. build vite build is ok.
Vite v4.3.9 building for production...
✓ 1 modules transformed.
✓ built in 18.92s
[vite:vue] At least one <template> or <script> is required in a single file component.
file: /home/projects/vitejs-vite-dwr7fb/src/App.vue

Reproduction
https://stackblitz.com/edit/vitejs-vite-dwr7fb
Steps to reproduce

pnpm i
pnpm build

System Info
System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 16.14.2 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 7.17.0 - /usr/local/bin/npm
  npmPackages:
    @vitejs/plugin-vue: ^4.1.0 => 4.2.3
    vite: ^4.3.2 => 4.3.9

Used Package Manager
pnpm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

You can add configFile:fase in buid.ts
build({
  plugins: [vue()],
  configFile: false,
  build: {
    lib: {
      entry: resolve(__dirname, './src/main.ts'),
      formats: ['es'],
    },
  },
});


append dragElm when $rootElement is still document

When $rootElement is document,$rootElement.append(dragElem) may cause an error "TypeError: Cannot read property 'createDocumentFragment' of null"
This commit can fix this problem,I think so.

Coverage remained the same at 37.402% when pulling 84b1dcd5015dac5e38a043ccce0efee0c34f1139 on lee1994522:master into ee3c61ca31ac6f3ed34d3f8fff0daeab94115906 on angular-ui-tree:master.

Compared to #cc9b12a , #84b1dcd removed $compile

Merged https://github.com/angular-ui-tree/angular-ui-tree/pull/729 which also solves this issue.


Auto Finalizing Purchase on iOS.

The only thing with auto finalising on iOS is that server-side receipt validation is rendered redundant. There would be no way to roll back the transaction if receipt validation failed after calling PurchaseAsync. I was calling FinalisePurchase depending on receipt validation success or failure. But if auto finalise is now enforced, and the fact that IsAcknowledged is Android-specific, what would be the best way to roll back the purchase if receipt validation fails on iOS?

From: James Montemagno @.>
Sent: Friday, September 23, 2022 10:40:58 PM
To: jamesmontemagno/InAppBillingPlugin @.>
Cc: sachinkanadia @.>; Author @.>
Subject: Re: [jamesmontemagno/InAppBillingPlugin] IsAcknowledged is always False on iOS (Issue #493)
Closed #493https://github.com/jamesmontemagno/InAppBillingPlugin/issues/493 as completed.
—
Reply to this email directly, view it on GitHubhttps://github.com/jamesmontemagno/InAppBillingPlugin/issues/493#event-7450463061, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AELKSS546GJXX7EOJMR4UMDV7YPWVANCNFSM6AAAAAAQTO2AU4.
You are receiving this because you authored the thread.Message ID: @.***>
Originally posted by @sachinkanadia in https://github.com/jamesmontemagno/InAppBillingPlugin/issues/493#issuecomment-1256760803

Receipt validation is still important. This library always finalized purchases on iOS except in the 5.x and 6.x betas. In 6.4 which i rolled back we turned it off by default based on feedback. You can turn off auto receipt validation: https://github.com/jamesmontemagno/InAppBillingPlugin#version-5--6-major-update
I don't think rolling back a purchase is a thing really


Terminology change from original article is more confusing than in the article

Hi there,
I'm keen to use this plugin, but the terminology that you've changed from the original article does make the process less clear.
In particular:

Source Armature: The armature you want to have animation on it

I take this to mean - this is the armature you don't have animations for, but want to apply animations from the source

This is the main thing that bothers me "Source" implies that this armature is some kind of input, and this doesn't really match up with its intended purpose.
I can see why "Target" armature could go either way (Are we targeting it for input or output?) and this may also be confusing, however, in conjunction with a clear idea of the corresponding input, it wouldn't be a problem.
Perhaps a better convention could be

"Master":
the rig that's already animated
"Puppet":
the rig we wish to animate

Thanks for your advice, I apologize for the confusing names I choose.
As I am not a native English speaker, its a bit difficult for me to choose a precise word for a variable, so I just pickup the first word appear in my head. The armature which needs animation is called "source" is just because while I program this, that armature belongs to me, and the animated armature comes from others.
I will try to re-organize terminologies in code and docs while I got some time to work on this project again.

Might add a PR for this, and tidy up some of the other strings if I get time.
Thanks for understanding, and great work on the plugin


Added target and metric to components

Added scaleTarget and scaleMetric to ComponentSpec
Made changes to ksvc_reconciler to add annotations to component as required

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1911
Type of changes
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update

Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Ran with below configuration and verified the deployment using describe.
apiVersion: serving.kserve.io/v1beta1
kind: InferenceService
metadata:
  name: torch-transformer
  annotations:
    autoscaling.knative.dev/target: "4"
spec:
  predictor:
    scaleTarget: 2
    scaleMetric: rps
    model:
      modelFormat:
        name: pytorch
      storageUri: gs://kfserving-examples/models/torchserve/image_classifier
  transformer:
    scaleTarget: 4
    scaleMetric: rps
    containers:
      - image: kserve/image-transformer:latest
        name: kserve-container
        command:
          - "python"
          - "-m"
          - "model"
        args:
          - --model_name
          - mnist

Logs

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Checklist:

[ ] Have you added unit/e2e tests that prove your fix is effective or that this feature works?
[ ] Has code been commented, particularly in hard-to-understand areas?
[ ] Have you made corresponding changes to the documentation?

Release note:

NONE

/test all

/test all

/test kubeflow-kserve-presubmit

/test kubeflow-kserve-presubmit

/retest

/retest

/retest

/retest

/retest

/retest

@yuzisun Will start my review

/test kubeflow-kserve-presubmit

/test kubeflow-kserve-presubmit

/retest

/lgtm
/approve


[W6.4b][W14-B1]Chua Wei Wen

Added 4 more non-functional requirements to DeveloperGuide.md

@chuaweiwen
Good job on this one.
Some comments added. Please ack & close the PR after reading comments.


Save button is positioned strangely in image editor on mobile

When in its desktop state, the image editor looks like this:

This looks great, however on mobile it's a bit confusing as the save/delete buttons appear in the middle of the options (not at the end as you would expect). I think it would be more intuitive if these were placed at the very bottom so the user knows they must save even after editing the focal point; at the moment it gives the impression that it is separate and doesn't require manual saving:

Yes, you are right.

Frankly I have the same impression on desktop, since the Save/Delete buttons are clearly part of the left-hand column.
A simple fix would be to move those buttons under the three columns on desktop – I imagine they would then be positioned at the end of the whole form on mobile:

Thoughts and design propositions welcome!

Another potential design:

However I'm not sure how well this would convert over to mobile.

Fixed in #3771.


Constant name "threshold" doesn't conform to UPPER_CASE naming style

https://github.com/lbonanomi/scripts/blob/d4369094fb277f5c08521500b3186b83b4c530b9/grouper.py#L17

Issues for naming style are now ignored.


Idea: include script-name, traceback with error messages

A thread started by Marco van Hulten 1/27/20 asks about including the script name and line number when reporting an error, which would be helpful for debugging when there are number of scripts which call each other.
Currently the error handler reports the error name, a general error message for the type of error, and possibly text that was provided by the internal routine that detected the error.  It also shows the command that was trying to run (as it appears after parsing).  We could add the script-name here. To report the line-number from the script we'd have to add more data structures, but it should be possible.
The discussion goes on to suggest giving an option to report the tree of calls and the command that last ran in each.  Un-parsed commands are not saved once parsed. It would not be hard to save the last-parsed command in its original form but not the whole history of un-parsed or parsed commands. Once commands successfully run they are not kept. I do not see a way to recover the last command run before each script call, but the stack of calling scripts would be straightforward.
@AndrewWittenberg

This is done. Adding a line that includes the script call as it was made, including any arguments to the script.
For example, here's a call to "GO polymark" where the number of color levels specified is larger than the allowed number:
yes? LET xpts = 180 + 50*COS(2*3.14*I[I=1:50]/60)
yes? LET ypts = 15  + 20*SIN(2*3.14*I[I=1:50]/60)
yes? LET sst = 25 - ypts + RANDN(ypts)
yes? plot/vs xpts,ypts
yes? GO polymark POLYGON/KEY/LEV=300 xpts,ypts,sst,star
 **ERROR: invalid command: "300": Number of contour levels must be between 1 and 250
POLYGON/KEY/LEV=300/coord_ax=Z  PLMxpoly+PLMxpolymark, PLMypoly+PLMypolymark, PLMpolydata
Command file, command group, or REPEAT execution aborted
Running script: polymark POLYGON/KEY/LEV=300 xpts,ypts,sst,star

The new line comes after the error messages generated by Ferret/PyFerret.
If there are error messages created by scripts, it so happens that the new "Running script" line comes before the ones generated by the script say in a "query" argument-checking command.  So a bad argument to the "go land" script does this:
yes? go land thick dummy
Command file, command group, or REPEAT execution aborted
Running script: land thick dummy
 **ERROR: argument 2 can be "basemap", "overlay", or "fast"

Fantastic, thanks!
One small suggestion would to change "Running script:" to "Executed by script:".  This might be a little less confusing when it comes at the end of the output, since "running" might make a user think that something is still running.

-- I see what you mean.  Or maybe just "error in script".  It might also be nice to set off the script call so it's more obvious.  Also I think I'll add the word "GO " which isn't inside Ferret at that moment but would make things clearer.
Command file, command group, or REPEAT execution aborted
Executed by script:  *** go polymark POLYGON/KEY/LEV=300 xpts,ypts,sst,star ***

or
Command file, command group, or REPEAT execution aborted
Script call was:   *** go polymark POLYGON/KEY/LEV=300 xpts,ypts,sst,star ***


[Frontend] A prototype for one_shot_dynamic transform

[sc-63049]
See also an internal document regarding this issue.

superseded by #773


Is there a way to set datetimepicker time mode?

In datetimepicker we get the datepicker option which allows us to set the configurations for the datepicker side, but I see there's no timepicker option, so we cannot config whatever in the timepicker side.
I want to set the timepicker mode to 'ampm' but I don't know if there's an alternative way to do it.
Thanks in advance.

No answer about it?


fix: Add warning when existing parameters are updated

Description
I was looking at #2265 and saw that a lot of tests (34) and examples (22) would be affected by making it an error to update parameters with check_already_exists=False. This makes it seem like a larger change. As an intermediate I propose to implement a warning so users and developers can adjust their scripts before it becomes an error. Similar to adding a deprecation warning.
If this change makes it in before the next release, then users can start adapting their code before the errors begin.
Related #2265
Type of change
Minor change to the way parameters are updated.

[x] Bug fix (non-breaking change which fixes an issue)

Key checklist:

[x] No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
[x] All tests pass: $ python run-tests.py --all (or $ nox -s tests)
[x] The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).
Further checks:

[x] Code is commented, particularly in hard-to-understand areas
[x] Tests added that prove fix is effective or that feature works

Lychee error is not from this change. Currently looking into the benchmark regression to see if it has to do with the logging.

Lychee error is not from this change. Currently looking into the benchmark regression to see if it has to do with the logging.

Looks like a small regression which is probably random, not too worried about it.

Looks like a small regression which is probably random, not too worried about it.

Yeah I figured it was probably random since the test was so simple. Looking into was more of an exercise to learn how to run them locally. Takes forever on my laptop

Thanks, I agree a warning is better than an error for this.
I would say let's hold off on this for the 23.9 release so we can test it a bit and see how annoying the warning is.
Also only tangentially related, we have a few of these kinds of settings now where the user could choose a different default option, do you know a nice way of making a "global" settings file for a pip-installed package?

Thanks, I agree a warning is better than an error for this. I would say let's hold off on this for the 23.9 release so we can test it a bit and see how annoying the warning is.

If the warning is unwanted, I can just start working on option (2) that I suggested in the original issue. I only intended the warning to be a temporary measure until the larger breaking change was implemented.

a nice way of making a "global" settings file for a pip-installed package

One of the recommended ways for this is to use configuration files that are parsed at the initialisation of a class (in this case, the Settings class) or at the time of import: it would be good to have something in either INI, TOML, YAML or JSON format that can be kept git-ignored for and by users, and otherwise without its existence we can use the defaults for a particular setting (in this case, displaying a warning on updating existing parameters). On pip installations (users), the file can live in the $HOME directory (or, preferably in the PyBaMM root directory because we can provide an API to read and write it)
Some examples are:
pytest: pytest.ini
coverage: .coveragerc
tox: tox.ini
The easiest of file formats to parse would be JSON (no external dependencies), though, my personal preference has always been TOML due to its readability (note: requires toml which is included in Python 3.11+ and is read-only, requires external dependencies for writing). For YAML, we already get pyyaml installed (required by both jupyter and pybtex in the extras). In our case, we provide an extensive API with programmatic access rather than a CLI application, which means that providing write access to such a settings file would be essential (it is difficult to override some of these settings without a CLI as easily).
A minimal example could be like
[pybamm.plotting]
# override, use six words instead of four
max_words_in_line = 6

It would also provide fine-grained control because of how the TOML format is defined: a table can be expressed and nested too:
[pybamm.smoothing]
tolerances.j0__c_e = 1e-8
tolerances.j0__c_s = 1e-8

is the same as
[pybamm.smoothing.tolerances]
j0__c_e = 1e-8
j0__c_s = 1e-8

and the Settings class can just read the TOML instead of hardcoding these values inside its Python file. If such functionality is required at some point, we could open an issue based on this comment

I am going to close this for now and revisit this ticket later. I am still assigned to the issue as a reminder


Applying to image instance segmentation

Hello
How are you?
Thanks for contributing to this project.
I am going to apply your method to custom image instance segmentation rather than video instance segmentation.
The custom dataset is annotated with COCO image instance segmentation format.
Is it possible?

Hi,
Thanks for your attention~
Yes, it is totally doable.
In fact, the IDOL model is an instance segmentation network with an external contrastive embedding head.
If this contrastive head is removed, it will becomes an image  instance segmentation model.


[BEAM-2221] KafkaIO API clean up.

Removed withKeyCoder() and withValueCoder() methods.

Their meaning changed
when KafkaIO added support for Deserializers. The coders can be explicitly
specified using withKeyDeserializerAndCoder(). This makes it explicit to
the user Deserializer is still required and JavaDoc explains why both
are required in addition to deserializers.

Removed 'readWithCoders()' and 'writeWithCoders()' methods. These were supposed to be utility methods to show how to use CoderBasedKafkaDeserializer. But they are too prominently placed and they were misused in multiple places. E.g. KafkaIOTest used VarInt coders even though the Kafka messages were plain big endian encoded ints and longs. They tests still passed!.

These utility methods  are moved CoderBasedKafkaSerializer (this class implements both Deserializer and Serializer interface). JavaDoc includes usage examples.

+R: @jkff cc: @aviemzur.

Can we mark the readWithCoders and writeWithCoders methods with @Deprecated? These go against the PTransform guide:

Do not use coders as a general serialization or parsing mechanism for arbitrary raw byte data. (anti-examples that should be fixed: TextIO, KafkaIO).

Fixed up the comments a little; merged. Thanks!

@rangadi @jkff removing CoderBasedKafkaSerializer without providing an alternative seems like a bit of a regression in terms of being able to read Avro from Kafka out of the box. Would it make sense to ship serializer/deserializer classes for Avro in kafka/serialization?

@peay My understanding was that there exists a standard Serializer/Deserializer for Avro in the Kafka ecosystem (https://github.com/confluentinc/schema-registry/tree/master/avro-serializer/src/main/java/io/confluent/kafka/serializers) so we don't need to provide our own.

@peay The first version of the patch kept CoderBasedKafkaSerializer ( https://github.com/apache/beam/pull/2986/commits/89a840a9291dc8de2462e4ce76293d84a24f06f0 ) and added utility methods (readerWithCoders()' & writerWithCoders()`). These are a bit complex because of need to support coders of any type. It is much simpler to add own Serializer based a specific coder.
Would an example (perhaps in in tests) help? We could point to that in JavaDoc.

@jkff this is actually what I mostly use, but I believe this only supports serialization/deserialization with a Confluent Schema Registry, which uses a special wire format that includes a reference to the Avro schema registered into the Schema Registry.
Serializing raw Avro (i.e., without Avro container binary format or schema registry payload) to a topic requires you to keep track of what's in there yourself if you want to read it later, but this can be useful and not everyone uses a schema registry, which made using KafkaIO + CoderBasedKafkaSerializer/AvroCoder convenient.
One option indeed would be to add some documentation/examples on how to make a custom serializer/deserializer based on a coder as suggested by @rangadi.
Alternatively, if you feel that recommending to wrap coders still clashes too much with the style guide, maybe Beam could ship with a lightweight serializer/deserializer pair that directly uses Avro's DatumWriter/DatumReader? Beam has good integration with Avro across the board, so I think it would be consistent to provide some basic Avro support built in KafkaIO out of the box. This would also make migration from Beam <= 0.6 easier.

+1 for Avro serializers and deserializer, either based on coders or directly implemented. Based on coders might be better (will also serve as a simple example of using coders as serializers).

It does not need to be part of KafkaIO.java proper. Just in the same package is fine.

Please, no using coders as serializers. The only reason this question keeps coming up at all is that currently all the fancy and convenient Avro/Proto stuff implemented by the Coder's is usable only through the Coder's themselves, and is not packaged as a library proper.
The right thing to do here is:

refactor AvroCoder and ProtoCoder into utility classes, making AvroCoder and ProtoCoder themselves simply thin wrappers over those
introduce Kafka serializers/deserializers that also use those utility classes

Yes, that sounds good. 90% of the code in AvroCoder is to check for determinism anyway, serialization itself is essentially just a oneliner along the lines of (new GenericDatumWriter<>(schema)).write(value).

Sounds good. Thanks!


feat: update alert/report icons and column order

SUMMARY

new icons for alert and report state: Success, Working, Error, Not triggered, On Grace
Column reorder to put last execution time on first column
update email and slack icon to lighter color and add right margin
update slack icon svg

BEFORE/AFTER SCREENS
Alert State:
Error

Success

On Grace

Working

Not Triggered

Report State
Success

Error

HOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

[ ] Has associated issue:
[x] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

Is it just me or the size of the status icons looks kind of odd? The warning icon is too large while the others are too small.

It looks like it's only warning that's a bit larger. I'm guessing it's the underlying SVGs size and viewBox properties. This may be intentional, to draw attention to the failed ones? @mihir174 can you confirm?

Actually, they all look the same size in the designs

We should either add another variant of the icon alert-solid-small like we do with other icons or we can apply a width and height (and probably position) styles.

Codecov Report

Merging #12081 (b43205c) into master (69185ee) will decrease coverage by 3.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12081      +/-   ##
==========================================
- Coverage   66.76%   63.65%   -3.12%
==========================================
  Files         959      476     -483
  Lines       47215    29371   -17844
  Branches     4620        0    -4620
==========================================
- Hits        31525    18697   -12828
+ Misses      15555    10674    -4881
+ Partials      135        0     -135

Flag
Coverage Δ

cypress
?

javascript
?

python
63.65% <ø> (-0.66%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/db_engines/hive.py
0.00% <0.00%> (-85.72%)
:arrow_down:

superset/sql_validators/postgres.py
50.00% <0.00%> (-50.00%)
:arrow_down:

superset/db_engine_specs/hive.py
54.61% <0.00%> (-29.62%)
:arrow_down:

superset/db_engine_specs/presto.py
69.95% <0.00%> (-12.45%)
:arrow_down:

superset/db_engine_specs/sqlite.py
65.62% <0.00%> (-9.38%)
:arrow_down:

superset/utils/celery.py
96.42% <0.00%> (-3.58%)
:arrow_down:

superset/examples/world_bank.py
97.10% <0.00%> (-2.90%)
:arrow_down:

superset/db_engine_specs/postgres.py
97.56% <0.00%> (-2.44%)
:arrow_down:

superset/examples/birth_names.py
96.51% <0.00%> (-2.33%)
:arrow_down:

superset/views/database/mixins.py
80.70% <0.00%> (-1.76%)
:arrow_down:

... and 491 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69185ee...b7371db. Read the comment docs.

@riahk yea there is a strange spacing with alert-solid-small have to use '-6 -6 24 24' to fix it


broken image in main README

Describe the bug
missing graphic in front page README
doesn't look great first impression on the project
Screenshots

The path to the image is
<img src="/botfront/docs/terminalizer/botfront-setup.gif?raw=true" width="100%">
I looked into the repo to try and see if I could find that image, but cannot see anything similar
there's an images directory but nothing similar there:
https://github.com/botfront/botfront/tree/master/botfront/docs/images
I did locally try to build the docs, but getting a separate error with that:
docker build -t botfront/botfront-docs botfront/docs

unable to prepare context: unable to evaluate symlinks in Dockerfile path: lstat /Users/dcollier/dev/rnd/botfront/botfront/docs/Dockerfile: no such file or directory

commit b8f160ce6e91dd88c991d853bae14fe27f3bf755
Author: Nathan Zylbersztejn<EMAIL_ADDRESS>Date:   Sat Dec 7 19:24:10 2019 -0500

    docs(readme): more detailed description of the project (#360)

    * ci: removed cypress runner image

    * fix: wrong default API host in default-settings.docker-compose.dev.json

    * docs(readme): more detailed readme

commit 3116ce6c36041cffd20079cfde09a491d0f2e611
Author: Nathan Zylbersztejn<EMAIL_ADDRESS>Date:   Wed Nov 20 22:33:49 2019 -0500

    docs: readme gif

commit 7273a09f88e9cceabf1dce1a62369a15cdabc4fd
Author: Nathan Zylbersztejn<EMAIL_ADDRESS>Date:   Wed Nov 13 14:50:03 2019 -0500

    docs: replace anim on readme

commit 084293e47017cc5f42a83e68db876ed27d915da2
Author: Nathan Zylbersztejn<EMAIL_ADDRESS>Date:   Mon Nov 11 22:30:36 2019 -0500

    docs: readme updates

commit a1ca45eaca10284601c01e801b423f8910388d3b (origin/docs/next-version)
Author: Nathan Zylbersztejn<EMAIL_ADDRESS>Date:   Mon Nov 11 22:30:36 2019 -0500

    docs: readme updates

commit 7d8b2012226e8115e05118696a2fedf7a25aef79
Author: Matthieu Joannon<EMAIL_ADDRESS>Date:   Thu May 2 17:04:32 2019 -0400

    chore: first commit

commit 7273a09f88e9cceabf1dce1a62369a15cdabc4fd
Refs: [HEAD], v0.18.1-1-g7273a09f
Author:     Nathan Zylbersztejn<EMAIL_ADDRESS>AuthorDate: Wed Nov 13 14:50:03 2019 -0500
Commit:     Nathan Zylbersztejn<EMAIL_ADDRESS>CommitDate: Wed Nov 13 14:50:03 2019 -0500

    docs: replace anim on readme
---
 botfront/docs/images/botfront_animation.gif | Bin 4306578 -> 5840403 bytes
 1 file changed, 0 insertions(+), 0 deletions(-)

diff --git a/botfront/docs/images/botfront_animation.gif b/botfront/docs/images/botfront_animation.gif
index 27151111..6dc47cab 100644
Binary files a/botfront/docs/images/botfront_animation.gif and b/botfront/docs/images/botfront_animation.gif differ


Add ID for additional category description

Questions
Answers

Description?
Specifc ID is missing

Type?
improvement

BC breaks?
no

Deprecations?
no

Fixed ticket?
Fixes 29383

How to test?
Open category page with addtional description

Possible impacts?
n/a

e.g. special CSS styling of this text

e.g. special CSS styling of this text

If just for styling then it should be class, not id.

I used ID as same is used in the normal category description.

I used ID as same is used in the normal category description.

Yeah but this is an error we can't get rid of because of retro compatibility, I would agree with @SharakPL to use a class if you don't mind 🙏

Changed to class

@PrestaShop/qa-team could be tested by a dev easily as it's just code context and not containing user-facing changes

Yep, can be tested by a dev, thanks for the ping @NeOMakinG and thanks for the PR @JBWModules !


Support Poly1305 with EVP MAC interface

This is based on the EVP MAC interface created by Richard in PR #7393. Poly1305 support in EVP PKEY is not removed so far, but I guess that could be removed, or leave it there to stay compatibility with older versions?
#7387 will be closed, so we move to this one instead.
Only commit dd221e4 is valid in this PR - I didn't figure out a way of submitting a PR without previous commits of Richard...
The test case in this PR illustrates the usage of the new EVP MAC interface.

Checklist

[x] documentation is added or updated
[x] tests are added or updated

This does need a bti of rework at this point.  I'd suggest looking at #7494 for inspiration, I think that's the closest to Poly1305 in terms of what needs to be implemented.

Yep, will do that later

Just take a quick glance through #7494 , fortunately the rework is not so much

Rework and rebase to master since #7393 has been in.

Rebased to master. ctrl_str is also added. Please continue to review this, @openssl/committers . Thanks!

Hmmm, I found the EVP_MAC via EVP_PKEY for Poly1305 does not work well...

Great, travis-ci is happy now

Review comments are addressed.

Regarding git and squashing things at the end, you might want to look into git commit --fixup=... and git commit --squash=... , as well as git rebate -i --autosquash

Usually I squash the commits in a PR by calling the ghmerge tool in openssl/tools, which is handy. Or another way could be I squash the commits in this PR and make a force update, that works as well

Ahh, and I guess there should be a period of grace time before merging this, right?

Hmm, the --fixup and --squash options are very handy for rebase -i --autosquash, I did this before by hand-changing the pick flag to s in the -i interface...

Ahh, and I guess there should be a period of grace time before merging this, right?

With a change like this, that's a good idea, yeah

Hmm, the --fixup and --squash options are very handy for rebase -i --autosquash, I did this before by hand-changing the pick flag to s in the -i interface...

I know, right? I did the same as you, and often formatted commit messages to remind myself what it was for. Now I use --fixup all over the place!

Ha, congrats for the improvement on efficiency!
And now all Cis are happy with this change so I am going to add the green ready label and wait for some grace period before merging. Thanks man for the reviews!

Squashed and pushed to master as c1da4b2afe62644f42f95a8788cd80b0a4925e0c

I'm afraid the grace period got a little too long ;-)
Rebase?

Hmm, the --fixup and --squash options are very handy for rebase -i --autosquash, I did this before by hand-changing the pick flag to s in the -i interface...

... and combined with git annotate these options unfold their full power if your pull request consists of several commits, because in most cases the annotation will immediately tell you the correct commit hash to use for --fixup resp. --squash.

I'm afraid the grace period got a little too long ;-)

Huh? This was already merged on 5th Nov. I forget to close the PR, closing now...


add internal links script

This PR adds a script to make sure that all internal links have backslashes at the end of them (except images and those with a "#" in the link, indicating that there is a section that is being referenced)

Should we update the PR template to ensure people run the script? When do we need to run it then?

eh this is not a make or break thing, i can bundle it in with the ahrefs/semrush monthly duties


Allow to add user defined variables to Scene

@omomthings you can now update continuous scene loading with scene variables

ok i'll check that now, also the public repo is not up to date after some improvements, I work on a separate private repo so i have made this one just to let you see how it look like. thank you for the improvement! ;)


install/kubernetes: update nodeinit image to latest version

Renovate does not pick up new version as tag is in sha format rather than regular semver.
Related: #32181

/test

Reopened in https://github.com/cilium/cilium/pull/33427 as I needed to open PR from cilium branch


Change libspirv to spvtools namespace

This CL changes all of the libspirv namespace code to spvtools to match
the rest of the code base.

Please rebase and resolve conflicts.


onTap function

Thanks for the great package.
Just having an issue getting a call back from the onTap function.
InteractiveChart(
initialVisibleCandleCount: 40,
candles: _data,
style: ChartStyle(),
onTap: (candle) => print("Tapped"),
Tapped never prints when I click on the candle sticks.

I've got the same problem as you. Codes below should be changed.
So I fixed it and, now, it works well as I expected.
https://github.com/fluttercandies/flutter-interactive-chart/blob/8bce5d633379995685b4a2351d8a5f9f81955997/lib/src/interactive_chart.dart#L208-L224
@h65wang Is there any rule for pull requests? I will request a pull.
cc @MeshariA

I've got the same problem as you. Codes below should be changed. So I fixed it and, now, it works well as I expected.
https://github.com/fluttercandies/flutter-interactive-chart/blob/8bce5d633379995685b4a2351d8a5f9f81955997/lib/src/interactive_chart.dart#L208-L224
@h65wang Is there any rule for pull requests? I will request a pull.
cc @MeshariA

Can you please share the change you made?

Hi @MeshariA
https://github.com/fluttercandies/flutter-interactive-chart/pull/10/files
I give a pull request. See the link above
cc. @h65wang

@kcoms555 Thank you, I've merged your PR, and will release a new build soon.


Update Pages “contact”

Automatically generated by Netlify CMS

👷 Deploy Preview for distracted-davinci-ed3898 processing.
🔨 Explore the source changes: f3cba60cf95c511e90eb7f55fc03c3cf38475cfe
🔍 Inspect the deploy log: https://app.netlify.com/sites/distracted-davinci-ed3898/deploys/611d2aacef56920008d7b2b0


node: Remove permanent ARP entry when remote node is deleted

When IPsec or NodePort is enabled, we add a permanent ARP entry (remote node IP => remote node MAC addr) upon receiving a NodeUpdate event. The entry is needed to facilitate calls to fib_lookup() from the datapath.
Up until now, the permanent entry was not removed when the remote node was deleted. This could lead to a problem, when a packet destined to a new node which reused the IP addr of the deleted node was dropped due to the wrong MAC addr until NodeUpdate event for the new node had been received.
This PR fixes the problem by removing obsolete ARP entries.
Reviewable per commit.
Fixes #10197.

This change is

test-me-please

test-me-please

Coverage increased (+0.0004%) to 44.473% when pulling 2d9ff70a4aaba0eb5f0eedfe448ebf64d255300b on pr/brb/rm-arp-entry into b6f2e75d5b98bc200817da41f96c6522866cdd4a on master.

@aanm Can we merge this? I'm going to add the tests after I've finished my work on a major feature.

@aanm Can we merge this? I'm going to add the tests after I've finished my work on a major feature.

I'll defer that decision to @joestringer.

@brb please file an issue to follow up on the tests just to make sure it doesn't get dropped. Manual testing of something like this is as good as no testing, it could regress at any time.
The change itself looks pretty straightforward and has relevant signoffs so LGTM.

Also, I marked this as a bugfix as this seems like it could cause neighbour cache to grow unchecked if there is much node churn.

@joestringer @aanm Created an issue for testing: https://github.com/cilium/cilium/issues/10341.


about char pretrained embedding

Thank you for this excellent open source code.
But I have one question about the pre-trained embedding for charaters,In the class "Data",we load the pre-trained embedding for characters,but i donot known where to use it,maybe I have to add one parameter called "pretrained_char_embedding",and pass it into the class CharBilstm(for example),and modify the code like below:
        if pretrain_char_embedding is not None:             self.char_embeddings.weight.data.copy_(torch.from_numpy(pretrain_char_embedding))         else:             self.char_embeddings.weight.data.copy_(                 torch.from_numpy(self.random_embedding(alphabet_size, embedding_dim)))

@fengxiachong  thank you very much for your report.
Yes, the previous version only includes the interface of the pretrained character embeddings but not use it.  I just implemented the usage of the pretrained char embedding, you may use the updated code.
Generally, the pretrained character embedding works for languages such as Chinese which includes a large character alphabet. Based on my experience, sometime the model is not stable by adding the pretrained char embedding in Chinese. In this case, you may try to normalize the embedding first.
Appreciate if you give me a feedback about whether the pretrained char embedding works well or not in your experiments.

Thank you very much~


link to RecycleView from ListView docs

Suggestion from IRC user sapienTech - include a note in the ListView docs about RecycleView. It would probably work best to replace the "ListView is experimental" notice we currently have. :) We could also note that it's experimental and the API is subject to change, etc., but that would help generate bug/feature reports for RecycleView and prevent people from trying to dive into the complex ListView API when they may not need to.
I haven't used RecycleView much myself yet, so I wanted to put this out there and see what other devs think.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/21783820-link-to-recycleview-from-listview-docs?utm_campaign=plugin&utm_content=tracker%2F42681&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F42681&utm_medium=issues&utm_source=github).

I don't think RecycleView is ready for prime time. As matham started used it last week, the API is still changing, making any app using it obsolete. But i would like to put it back into Kivy when it's ready :)

I've added a note.


linorobot2_hardware/firmware, function destroyEntities() error.

when I run this
cd linorobot2_hardware/firmware
pio run --target upload -e teensy40

I have an error like this.
But, status was success. So, when I commend
$ ros2 launch linorobot2_bringup bringup.launch.py
It works. And I can see a node linorobot2_base that have a /cmd_vel subscriber.
Also, commend
$ ros2 run teleop_twist_keyboard teleop_twist_keyboard
It works. Motors are working.
But, When I quit these and reboot my jetson nano, I can see zombie nodes like /rplidar_... and /publisher.
I think it's because of destroyEntities().
So, When I command
$ ros2 launch linorobot2_bringup bringup.launch.py
again, there are no
| Root.cpp             | create_client     | create
| SessionManager.hpp   | establish_session | session established
only I can see Root.cpp. Also, There is no linorobot2_base node. There is no /cmd_vel subscriber.
I will  use different ROS_DOMAIN_ID on each independent ROS2 system : https://docs.ros.org/en/foxy/Tutorials/Beginner-CLI-Tools/Configuring-ROS2-Environment.html
to kill my zombie nodes.
And I will try
$ ros2 launch linorobot2_bringup bringup.launch.py
again. But I want to solve destroyEntities().
Please, help me. Thanks.

those are only warnings and will not cause any issues.


The Idris Rewrite

The original plan was to build up a robust Rust version of elba, wait for new packages to be created, and then piggyback off of those for an Idris rewrite. However, the second step isn't really happening, so I think we should just jump straight into rewriting elba in Idris now and deal with all the new packages that need to be made. By having elba be written in the language it's for, we can hopefully kickstart the package community and improve adoption (you don't need two separate language toolchains now).
The new version of elba should ideally accomplish the following (in order from most to least plausible/realistic/sensical?):

Match the Rust version feature-wise. This goes without saying.

Be Blodwen compatible. Not only should elba be able to adapt to the changes made in Blodwen (*.ttc files which go in build/ folders instead of *.ibcs strewn about in the same folder as their source file, etc.), but elba and any dependency that it needs should be able to be compiled with Blodwen. The elba rewrite should also probably support Idris 1.x in some capacity and transparently work with both versions.

Clean up remote support. elba's support for remote indices/registries is still a bit lacking since we don't have a real index or registry to work with. Now that we have a working website backend, we can work to properly test remotes and their associated features (this includes fixing some potential bugs with the dependency solver). This should resolve #33, #35, and #37.

Work more robustly in certain situations. This refers to nothing in particular, just the fact that the Idris rewrite should try to work more gracefully (or at least fail more gracefully) when things go wrong (e.g. files go missing, the build directory can't be acquired, etc.).

Switch to Dhall for all configuration files. This is probably the most ambitious and least realistic idea: it would require writing a complete Dhall interpreter in Idris, something which exists for nothing except Haskell at the moment. However, because Dhall is so flexible, it opens the door to some advanced functionality and programmability; cpkg is the only precedent I can think of at the moment for using Dhall.

The plan is to develop the rewrite on its own branch in this repository and keep the Rust version as the master branch; once the Idris version stars nearing completion, which can fork the Rust version into its own branch and switch the Idris version to master. Throughout this process, there are gonna be new libraries added to the elba org for common things that can be used by the entire Idris ecosystem (path handling, semver handling, etc.). Ideally, elba would be finished around the time that an official release of "Idris 2" happens so that we can coincide nicely with that release.

I felt quite uneasy after reading your new plan. Bascially it's because I don't believe we can build the whole ecosystem in idris  for the pm. I started to realize these days that idris is indeed a research language and no one would expect to build product level applications in idris. If you look in to the idris channel in reddit and mail lists, you will find that they are always talking about the language features and proofs, and only the discussions about practical things (like git, tar and networking) are missing. All in all, I think it's impossible to self-host the pm in idris now.

Idris is a research language, yes, but Haskell is also technically still a "research language"; in any case, Idris was meant to be a language that could be used both for proofs and for general-purpose programming. The problem with waiting for other people to make libraries is that there is no real upper bound on when that could happen; the proper libraries could fall in place tomorrow or never, so I think it makes sense to at least attempt to implement elba in Idris now.

Haskell has made a good balance between research and engineering in the past 30 years. But even beening developed over 30 years, Haskell still has packages that can be listed in only one single web page, while Rust already has over 20k+ crates in 3 years.
Yes, we indeed need someone to kick off the community and focus on engineering. But this is far beyond our original goals on elba. I think I was hoping to give assistance to community by building a robust package manager, but not being the community itself, building all missing pieces in idris, and without a working pm.
I still think that we should stick with the rust version now until it's totally working online.

I think that's a reasonable plan to follow; I think we'll keep developing the Rust version and expanding its featureset then, but we'll also add some Idris libraries to the elba org which might be helpful for future development.


build_tests_3_4 fails with "Failed to find newest available Simulator runtime: Could not find any supported simulator runtimes"

Test result
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8817820081453931809/+/u/run_test.dart_for_build_tests_shard_and_subshard_3_4/test_stdout

Duplicate of https://github.com/flutter/flutter/issues/99039. Please rebase your PR to ToT.


Failed to load coverage: The file was not recognized as a valid object file

Thanks for creating this project; it looks like a really nice way to abstract over -Z instrument-coverage!
I was just testing this out on CI for PyO3 and it seems like some unintended files are being picked up by the tool when building for the PyO3 workspace. See https://github.com/PyO3/pyo3/runs/3271084242?check_suite_focus=true

Try cargo clean. I just did and it worked :+1:


Support linting generateName

Signed-off-by: Charlie Getzen<EMAIL_ADDRESS>
Closes https://github.com/helm/helm/issues/9488
What this PR does / why we need it:
Ensures that linting works when generateName is used instead of name.
Special notes for your reviewer:
If applicable:

[ ] this PR contains documentation
[x] this PR contains unit tests
[ ] this PR has been tested for backwards compatibility

First, let me say that I want to support generateName. It would be nice to have it work well in Helm. But, there are some checks in helm that fail when I try to use it. In my case I did this by using helm create and then modifying the deployment.
Could you provide an example of a working chart that uses generateName?

Hey, thanks for taking a look. After a brief search, I can't find any public charts that use generateName.
We've been using generateName with helm successfully for internal charts. The only portion that fails for is linting.
Are there other portions of helm that don't work with generateName?


Limit on the number of subsections?

Hi,
I have an appendix:
[appendix]
== Questions and Answers
==== What is Apache Spark?
==== What is PySpark?
...
...
...
I have 52 of "====" subsections, but only 51 of them appear in the generated PDF.
Is there a limit on the number of subsections?
Thank you!
best regards,
Mahmoud

No, there is no limit.
Perhaps the last one is getting cut off. Can you share a complete sample document that is impacted by this issue?

I can not post the actual document: since it is not published yet, but hope this helps.
The last one: "How to Read Objects from DynamoDB?" does not appear in the generated pdf:
this is the command I use:
asciidoctor --backend=pdf --require=asciidoctor-pdf  --destination-dir=_build --out-file=book.pdf master.adoc; \
Thank you!
Mahmoud
$ grep '^====' appendix_QA.adoc
==== What is Apache Spark?
==== What is a Cluster Manager?
==== What is PySpark?
==== What is MapReduce?
==== How is Spark different from MapReduce?
==== How do you Compare Spark and Hadoop
==== What are Spark's data abstractions?
==== What is a SparkSession?
==== What are ((actions)) and ((transformations))?
==== What is a SparkContext?
==== What is an RDD?
==== How to create an RDD from a text file?
==== How to create an RDD from a Python collection?
==== What are Spark's Actions?
==== What is a Pair RDD?
==== What is a classic Word Count problem?
==== How to filter RDD
==== What is a DataFrame?
==== How to create a DataFrame from a text file?
==== How to create a DataFrame from a Python collection?
==== How to use DataFrame.groupBy()?
==== What is a Parquet file format?
==== How to create a Parquet file format using PySpark?
==== How to add a new column to a DataFrame?
==== How to read a Parquet file format using PySpark?
==== What are Partitions and Partitioning?
==== How to Partition a DataFrame based on Column Value?
==== What is the function of coalesce()
==== How to create an RDD with specific number of partitions?
==== How to use reduceByKey() Transformation
==== How to use groupByKey() Transformation
==== How to use combineByKey() Transformation
==== How to use mapPartitions() Transformation
==== How to use map() Transformation
==== How to use flatMap() Transformation
==== How to use join() on 2 RDDs?
==== Is there a Graph API in Spark?
==== What is a PageRank Algorithm?
==== What are Broadcast Variables?
==== How is machine learning implemented in Spark?
==== What is Spark SQL?
==== How to Create a DataFrame from JSON
==== What is Lazy Evaluation in Spark?
==== What are the various levels of persistence in Spark?
==== What is Lineage Graph?
==== How do you monitor Spark jobs?
==== What is foreach()?
==== Explain Spark's countByKey() operation
==== What is Spark Streaming?
==== How to read LIBSVM data format?
==== How to generate sliding data?
==== How to Read Objects from DynamoDB?
===== Input
===== Read by Python
===== Read by PySpark

I can not post the actual document: since it is not published yet

That's why I said sample document.
If you want me to take the time to fix this, then you need to take the time to create a complete reproducible document.

Btw, your section titles are out of sequence. You should be seeing a warning about this:
[appendix]
== Questions and Answers

==== What is Apache Spark?

You can't jump from level 1 to level 3.

You found the solution: "You can't jump from level 1 to level 3."
The problem is fixed by not jumping from level 1 to level 3.
Thank you very much for your help.
best regards,
Mahmoud

\o/


remove image steam listener on dispose

@jasonttf Could you remove that file? I'd be glad to merge it then.

Can we get this merged? This issue really needs to be addressed. I'm willing to write a pull request to resolve asap, but I don't want to step on @jasonttf's toes.

@jasonttf Can we get this ready to merge? This issue really needs to be addressed.

@theLee3 Let's see, I temporarily replaced the .lock file, I will remove it again after the merge. Also manually resolved a conflict. Will it fly?

@theLee3 If you can confirm that it works, I'll publish it. My first tests show no problems.

Works well, and leak is resolved. Great job.

Published then. Just out of curiosity: how did you see the leak? Direct error in your app or only by using some profiling-analyzing tool to look for it specifically?

BlocObserver error logging showed that the CropController was constantly being accessed after disposal, which I tracked to the the Listener.


Add GPU metrics to GpuFileSourceScanExec

Fixes #524.
This provides GPU-specific metrics to the FileSourceScanExec override in the plugin.  Apache Spark doesn't support format-specific metrics directly, so this adds a workaround by piggybacking the metrics map onto the format options map.
This looks like it's adding a ton of code to GpuFileSourceScanExec, and it is, but almost all the code comes from Spark's FileSourceScanExec.  With this change, GpuFileSourceScanExec no longer tries to construct a wrapped instance of FileSourceScanExec (which lead to a number of cases where shims needed to be built across the Spark versions), but instead provides implementations of the overridden methods directly.
Opening this PR in draft form first to get some feedback on the approach.  The key part of the implementation is the new ReaderOptionsWithMetrics class (I'm terrible at naming things).  I'm open to other suggestions on how to handle the GPU metrics.  This PR only updates the Spark 3.0.0 shim version of GpuFileSourceScanExec for now.  If the approach is approved then I will apply a similar change to the other shim versions and potentially be able to combine the implementations such that it can be extracted from the shim layer.

It looks OK to me.
A lot of the scan code appears to be related to partitioning and planning how to read bucketed code.  We probably should add in more tests for reading bucketed code, and look at the code coverage for these areas just to be sure we didn't mess anything up, and to give us more confidence that we are doing it right in newer versions of Spark.

fyi  spark 3.1.0 has another param in the FileSourceScanExec  - optionalNumCoalescedBuckets. so probably still need a shim or some sort if we want to keep that functionality. (https://issues.apache.org/jira/browse/SPARK-31350)
I was actually in process of adding a bucketing test because I ended up copying a bunch of functions as well for the small file optimization, I was trying to use tables and its being a bit of a pain to add, seeing some weirdness  the catalog.
One issue, like you mention,  which we already had but this makes it worse is how we keep this code up to date and discover changes in spark side.   One example of this is already the optionalNumCoalescedBuckets we could have worked fine without noticing that was there.  We may need to think up more extensive auditing mechanisms.

@tgravescs @revans2 I found what I think is a cleaner way to implement the metrics, which is leveraging the fact that we know we're using a file format that we control.  That seems cleaner than abusing the options map to piggyback metrics on it.
This is just about ready to go.  Running into a single, weird test failure in the Mortgage test where the first query results in zero rows.  Not sure how that's happening yet.

Thanks to @revans2 the test failure has been fixed.  This is now ready for review.

build

build

build


Compatibility with datatables 2.0

Hello Daniel,
do you plan to make yadcf compatible with datatables 2.0 ?

See https://github.com/vedmack/yadcf/issues/680
CC @vedmack

thanks for the link, i close this one to avoid duplicate

@aureltime Yes I am, see this test page for example https://jsfiddle.net/vedmack/8bur71tk/
The current yadcf version that supports DT 2 is yadcf 2.0.1.beta.3
Feel free to provide test pages so I can apply the required modification faster

new showcase page https://yadcf.web.app

Hello Daniel,
thank you for the update.
In the showcase DT 2.0.0 is used; with a newer version (2.0.8) an error occurs, see fiddle
https://jsfiddle.net/msuo0e14/
"jQuery.Deferred exception: Cannot read properties of undefined (reading 'split')", "TypeError: Cannot read properties of undefined (reading 'split')
    at yadcfVersionCheck (https://raw.githack.com/vedmack/yadcf/master/2.0/jquery.dataTables.yadcf-2.0.js:832:49)

thx for the report, fixed in 2.0.1.beta.7, you can see here: https://jsfiddle.net/vedmack/gLjrf5ax/. I will update the showcase later on

When I use the language option from datatables, I get an error from yadcf.
"jQuery.Deferred exception: Cannot read properties of undefined (reading 'map')", "TypeError: Cannot read properties of undefined (reading 'map')
    at appendFilters (https://raw.githack.com/vedmack/yadcf/refs/heads/master/2.0/jquery.dataTables.yadcf-2.0.js:3282:33)
    at initAndBindTable (https://raw.githack.com/vedmack/yadcf/refs/heads/master/2.0/jquery.dataTables.yadcf-2.0.js:5014:11)
    at Object.init (https://raw.githack.com/vedmack/yadcf/refs/heads/master/2.0/jquery.dataTables.yadcf-2.0.js:5224:11)
    at HTMLDocument.<anonymous> (https://fiddle.jshell.net/_display/?editor_console=true:443:9)
    at e (https://code.jquery.com/jquery-3.6.4.min.js:2:30158)
    at t (https://code.jquery.com/jquery-3.6.4.min.js:2:30460)", undefined

With datatables 1.13.5 and yadcf 0.9.4b47 this problem did not occur.
fiddle: https://jsfiddle.net/zc10mgsa/2/

I found something else strange in DT2.0. If umlauts are used in column_data_type: 'rendered_html', they are lost.

example: https://live.datatables.net/bisaxayu/1/edit


Resolution mismatching for interpolation

Thank you so much for sharing your code.
I use TOFLow to interpolate 2k images, their resolution is 2560x1440.
16 can divide 2560 and 16 can also divide 1440.
However, after doing interpolation, the resolution of my result is 2096x1184. How could I resolve this problem?
Thank you.

Thank you. I'll try it.


chore: add code for paragraph-text morphing

Summary by CodeRabbit

New Features

Enhanced configurability of input widgets with new dependency tracking and update mechanisms.
Introduced dynamic font size updates for paragraph widgets, improving typography control.
Added a constant mapping for font sizes to widget types, enhancing rendering flexibility.
Exposed additional constants for the WDSPhoneInputWidget, improving modularity.

Bug Fixes

Improved widget state management through the addition of read-only update hooks.

[!WARNING]
Tests have not run on the HEAD 67e82111583536a2c7ac0d90a6e94b6603c9e722 yet
Tue, 03 Sep 2024 07:48:38 UTC

/build-deploy-preview skip-tests=true

/build-deploy-preview skip-tests=true


display different message to user if only have v1 external service

What does this change?
For #11304
How to test
Log in with a user that has a role of 'StaffWithRestricted'
Visit http://localhost:3000/works/a24nhdcv and see the following message:

Visit http://localhost:3000/works/a24nhdcv/items and see the following message:

How can we measure success?
Have we considered potential risks?
Limited as it only affects a limited number of users.
It is possible that if the user has already visited an item with v2 external services and authorized, then they will be able to see the images, but still receive this message. We could try and address this, but felt it was not a great use of time given the limited impact of the issue and the fact it will resolve once all iiif manifests have been regenerated.

It is possible that if the user has already visited an item with v2 external services and authorized, then they will be able to see the images, but still receive this message. We could try and address this, but felt it was not a great use of time given the limited impact of the issue and the fact it will resolve once all iiif manifests have been regenerated.

Is this why I see the message on http://localhost:3000/works/rp9jnamu/items ?

Is this why I see the message on http://localhost:3000/works/rp9jnamu/items ?

yep


PHP: fix ZTS build

Upmerge version of #17325

Is this dup of #17325?

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,020,300      Total (=)      2,020,300

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,154,429      Total (=)     11,154,429

 No significant differences in binary sizes


enabled client-only install, tested v11.5

closes #15

Thanks @timrburnham -- this looks like a great cleanup as well!


Storage - Blobs NIO ReadMe and Samples issues

Section link

Reason:

java.lang.IllegalArgumentException: URI does not contain an "endpoint=" parameter. FileSystems require a URI of the format "azb://?endpoint="
java.lang.IllegalArgumentException: There was an error parsing the configurations map. Please ensure all fields are set to a legal value of the correct type.

Suggestion:
Change to
    private static final String CONTAINER_STORES = "dir,file"; // A comma separated list of container names
    private static final StorageSharedKeyCredential SHARE_KEY_CREDENTIAL
            = new StorageSharedKeyCredential("<account_name>", "<account_key>");
    private static final Map<String, Object> CONFIG = new HashMap<String, Object>(){{
        put(AzureFileSystem.AZURE_STORAGE_SHARED_KEY_CREDENTIAL, SHARE_KEY_CREDENTIAL);
        put(AzureFileSystem.AZURE_STORAGE_FILE_STORES, CONTAINER_STORES);
    }};
    private FileSystem myFs = FileSystems.newFileSystem(new URI("azb://?endpoint=<account_endpoint>"), CONFIG);

@joshfree, @tg-msft, @kyle-patterson and @rickle-msft for notification.

@hongli750210 Thank you for reporting this. I'll add this now.


Tmp

Pull request for portfolio project. Used Angular for project.

One thing you should do to reduce the size of this pull request is to add the files in the webapp folder (but not the subfolders like WEB-INF) that are auto-generated by ng build to gitignore (and running the "git rm --cached FILENAME" command as described in the other comment), since anyone downloading this can just run ng build themselves.

In the webapp folder, there are a number of .js files along with two subdirectories "WEB-INF" and "assets".


Add flag to include branch name in commit output

I love this project, and I use it daily. In this daily usage, I've identified just one possible improvement: the addition of the branch name to the commit message. I work in multiple branches for different features, and need to reference the branch name in my daily standup. If git standup included a flag that enabled outputting the branch name before the commit (i.e. [branch_name] Commit message), I (and hopefully others) may be able to rely on git standup even more comprehensively.
Is this possible today and I've just missed it?

Bump!

Feature branches for me are more of a memory jog than my commit messages, so I'd love to be able to see the branch names as well :+1:

I work in a tonne of branches every day so this feature is needed for me.
I've created my own very simple version of git-standup, called git-scrum:
Just run:
npm install git-scrum -g
It allows you to output your last days work into the console allowing you to view what branch a particular commit was for. Just run the command:
> git-scrum

It's certainly not got all the bells and whistles git-standup has with all the different flags, but it provides the information I need so maybe it'll help some other people who are in the same boat.

+1

+2

+1

+1 - while i appreciate the feature branch part of git-scrum the list seems to be missing squashed commits on the main branch from my feature branches. A solution that shows both is what I'm after, tracking both work on feature branches and features that I've merged.


feat: Add filter target supply artists feature flag

The type of this PR is: Feature

This PR resolves CX-1665
Description

PR Checklist (tick all before merging)

[ ] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[ ] I have tested my changes on iOS and Android.
[ ] I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
[ ] I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
[ ] I have documented any follow-up work that this PR will require, or it does not require any.
[ ] I have added an app state migration, or my changes do not require one. (What are migrations?)
[ ] I have added a CHANGELOG.yml entry or my changes do not require one.

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

is this one still relevant? 🤔

nop, I'll close this PR.


Don't use $('.ul.dropdown') in the React integraiton example

From this page:
http://semantic-ui.com/introduction/integrations.html
  componentDidMount() {
    $('.ui.selection.dropdown').dropdown({

This is not something you should encourage newcomers to do. Using refs and ReactDOM.findDOMNode is the correct way to access your DOM nodes after render.
Further reading: https://github.com/ryanflorence/react-training/blob/gh-pages/lessons/05-wrapping-dom-libs.md

Agreed, referencing the selector manually is not the React way.
You can do the required changes yourself if you want, that example is stored in a jsfiddle you can find here https://github.com/Semantic-Org/Semantic-UI-Docs/edit/master/server/documents/introduction/integrations.html.eco

I'd update the jsfiddle link if someone wants to recommend a different example.

@DelvarWorld @IonutBajescu and any others landing here, there is now an officially supported Semantic-UI-React project that implements components in the React paradigm without jQuery: https://github.com/TechnologyAdvice/stardust
I'll soon port it to Semantic-UI-React.
Cheers


Logging convention

This PR will ensure a logging standard for the ingress of mailman, listserv, w3c archives and addresses issue #353

Codecov Report

Merging #546 (8860639) into main (506ca42) will increase coverage by 0.04%.
The diff coverage is 82.75%.

@@            Coverage Diff             @@
##             main     #546      +/-   ##
==========================================
+ Coverage   75.13%   75.18%   +0.04%
==========================================
  Files          27       27
  Lines        3302     3308       +6
==========================================
+ Hits         2481     2487       +6
  Misses        821      821

Flag
Coverage Δ

unittests
75.18% <82.75%> (+0.04%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

bigbang/ingress/listserv.py
83.28% <0.00%> (ø)

bigbang/ingress/utils.py
70.00% <50.00%> (-0.52%)
:arrow_down:

bigbang/ingress/w3c.py
77.00% <50.00%> (+0.38%)
:arrow_up:

bigbang/bigbang_io.py
82.25% <100.00%> (+0.14%)
:arrow_up:

bigbang/ingress/abstract.py
85.55% <100.00%> (ø)

tests/ingress/test_listserv.py
90.69% <100.00%> (+0.07%)
:arrow_up:

tests/ingress/test_w3c.py
100.00% <100.00%> (ø)

tests/unit/test_listserv.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 506ca42...8860639. Read the comment docs.


Broken autoindent inside lua-heredoc

Hello.
Unlike regular lua files, autoindent inside lua-heredoc seem doesn't work as expected:

Hi @Serega124 , seems that the issue can be reproduce with autoclose.nvim disabled.
For example (here | represents cursor):
lua << END
require('test').setup {|}
END

I press enter and it becomes:
lua << END
require('test').setup {
  }
END

Therefore this should be the issue of Neovim itself?

Yes, seems you are right


I redraw bedrock icon to 15x15 pixel.

Yeah, i think, the bedrock players gonna be happy.
So, i don't redraw the main buttons & share and setting button. I left it as is for myself. (Because of this, I did not turn to Lambd. When I wanted to, it was too late.)

If you need a middle, it seems that 13x13 will be small.. So.. I don't know.
There screenshot's:

(-Idk how to send to full resolution.-) Okay, i got it.

Looks great, thank you very much :)
Gonna be added in the next beta

Added in 0.2.0 :)


Blocks containing Google Maps API Call create error in 8.4.0RC1

I'm getting the following error when using the add-on "Styled Maps" or when using a simple code block containing Google Maps API code. The same work in previous releases.
Argument 1 passed to Concrete\Core\Area\Layout\Layout::setAreaObject() must be an instance of Concrete\Core\Area\Area, null given, called in /site/site/public_html/updates/concrete5-8.4.0RC1/concrete/blocks/core_area_layout/controller.php on line 65

Apologies for taking so long to pick this up again. The issue is environment specific. I've just copied to a local development WAMP (Windows 10, PHP 7.1.16 and MySQL 5.7.21) and there's no issue. The server is CentOS running Apache, PHP 7.1.16 and MySQL 5.6.38).
The WAMP uses the Server API "apache2handler" and the other (not working) uses "cgi-fcgi". Sorry don't know my server stuff that well.


Does Router Reflector support shared by two different Kubernetes Clusters

After some test, I found that Router Reflector works fine in one cluster with following topology.

Now I want to set up two Kubernetes clusters and want those two clusters share one Router Reflector with below topology, I think this should works fine, as I assume those two Kubernetes Cluster should have no impact to the Router Reflector.

But after some test, I found that Router Reflector is not working in above scenario.
And I enter the container of Router Reflector and check logs under /var/log/calico/bird/current and found following logs:
2018-04-25_01:35:09.33668 bird: Started
2018-04-25_01:39:09.51716 bird: Graceful restart done
2018-04-25_01:39:19.67653 bird: Reconfiguration requested by SIGHUP
2018-04-25_01:39:19.67664 bird: Reconfiguring
2018-04-25_01:39:19.67664 bird: Removing protocol Global_9_111_255_77
2018-04-25_01:39:19.67665 bird: Removing protocol Global_9_111_255_155
2018-04-25_01:39:19.67665 bird: Removing protocol Global_9_111_255_152
2018-04-25_01:39:19.67665 bird: Reconfigured
2018-04-25_01:46:22.93048 bird: Reconfiguration requested by SIGHUP
2018-04-25_01:46:22.93049 bird: Reconfiguring
2018-04-25_01:46:22.93049 bird: Adding protocol Global_9_111_255_77
2018-04-25_01:46:22.93050 bird: Adding protocol Global_9_111_255_155
2018-04-25_01:46:22.93050 bird: Adding protocol Global_9_111_255_152
2018-04-25_01:46:22.93050 bird: Reconfigured
2018-04-25_01:46:32.83278 bird: Reconfiguration requested by SIGHUP
2018-04-25_01:46:32.83279 bird: Reconfiguring
2018-04-25_01:46:32.83279 bird: Removing protocol Global_9_111_255_77
2018-04-25_01:46:32.83279 bird: Reconfigured
2018-04-25_01:46:34.25715 bird: Reconfiguration requested by SIGHUP
2018-04-25_01:46:34.25725 bird: Reconfiguring
2018-04-25_01:46:34.25726 bird: Removing protocol Global_9_111_255_155
2018-04-25_01:46:34.25726 bird: Reconfigured
2018-04-25_01:46:36.87297 bird: Reconfiguration requested by SIGHUP
2018-04-25_01:46:36.87310 bird: Reconfiguring
2018-04-25_01:46:36.87310 bird: Removing protocol Global_9_111_255_152
2018-04-25_01:46:36.87311 bird: Reconfigured
2018-04-25_01:47:04.29171 bird: Reconfiguration requested by SIGHUP
2018-04-25_01:47:04.29172 bird: Reconfiguring
2018-04-25_01:47:04.29172 bird: Adding protocol Global_9_111_255_155
2018-04-25_01:47:04.29173 bird: Reconfigured
2018-04-25_01:47:04.35617 bird: Reconfiguration requested by SIGHUP
2018-04-25_01:47:04.35617 bird: Reconfiguring
2018-04-25_01:47:04.35618 bird: Adding protocol Global_9_111_255_152
2018-04-25_01:47:04.35618 bird: Reconfigured
2018-04-25_01:47:14.06215 bird: Reconfiguration requested by SIGHUP
2018-04-25_01:47:14.06229 bird: Reconfiguring
2018-04-25_01:47:14.06229 bird: Adding protocol Global_9_111_255_77
2018-04-25_01:47:14.06230 bird: Reconfigured
2018-04-25_01:52:39.28994 bird: Reconfiguration requested by SIGHUP
2018-04-25_01:52:39.29009 bird: Reconfiguring
2018-04-25_01:52:39.29010 bird: Adding protocol Global_9_111_255_91
2018-04-25_01:52:39.29011 bird: Reconfigured
2018-04-25_01:52:41.34188 bird: Reconfiguration requested by SIGHUP
2018-04-25_01:52:41.34206 bird: Reconfiguring
2018-04-25_01:52:41.34206 bird: Adding protocol Global_9_111_255_21
2018-04-25_01:52:41.34207 bird: Reconfigured
2018-04-25_01:52:55.40053 bird: Reconfiguration requested by SIGHUP
2018-04-25_01:52:55.40069 bird: Reconfiguring
2018-04-25_01:52:55.40070 bird: Adding protocol Global_9_111_255_46
2018-04-25_01:52:55.40070 bird: Reconfigured
2018-04-25_01:53:08.31321 bird: Global_9_111_255_152: Received: Other configuration change
2018-04-25_01:53:08.31952 bird: Global_9_111_255_21: Received: Other configuration change
2018-04-25_01:53:08.32623 bird: Global_9_111_255_46: Received: Other configuration change
2018-04-25_01:53:08.33466 bird: Global_9_111_255_91: Received: Other configuration change
2018-04-25_01:53:08.38322 bird: Global_9_111_255_155: Received: Other configuration change
2018-04-25_01:53:08.50961 bird: Global_9_111_255_77: Received: Other configuration change
2018-04-25_01:53:11.42800 bird: Reconfiguration requested by SIGHUP
2018-04-25_01:53:11.42808 bird: Reconfiguring
2018-04-25_01:53:11.42809 bird: Removing protocol Global_9_111_255_77
2018-04-25_01:53:11.42809 bird: Reconfigured
2018-04-25_01:53:11.74188 bird: Global_9_111_255_21: Error: Bad peer AS: 64512
2018-04-25_01:53:11.74232 bird: Reconfiguration requested by SIGHUP
2018-04-25_01:53:11.74233 bird: Reconfiguring
2018-04-25_01:53:11.74233 bird: Removing protocol Global_9_111_255_155
2018-04-25_01:53:11.74233 bird: Global_9_111_255_152: Error: Bad peer AS: 64512
2018-04-25_01:53:11.74234 bird: Reconfigured
2018-04-25_01:53:11.74234 bird: Global_9_111_255_46: Error: Bad peer AS: 64512
2018-04-25_01:53:11.99226 bird: Reconfiguration requested by SIGHUP
2018-04-25_01:53:11.99227 bird: Reconfiguring
2018-04-25_01:53:11.99228 bird: Removing protocol Global_9_111_255_152
2018-04-25_01:53:11.99228 bird: Reconfigured
2018-04-25_01:53:12.34530 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 39784)
2018-04-25_01:53:12.65521 bird: Global_9_111_255_91: Error: Bad peer AS: 64512
2018-04-25_01:53:13.34748 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 36727)
2018-04-25_01:53:16.53752 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 55665)
2018-04-25_01:53:16.83553 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 35248)
2018-04-25_01:53:20.54448 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 46079)
2018-04-25_01:53:21.54444 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 46354)
2018-04-25_01:53:24.55012 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 56219)
2018-04-25_01:53:25.55108 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 39444)
2018-04-25_01:53:27.86814 bird: Reconfiguration requested by SIGHUP
2018-04-25_01:53:27.86815 bird: Reconfiguring
2018-04-25_01:53:27.86815 bird: Removing protocol Global_9_111_255_21
2018-04-25_01:53:27.86816 bird: Removing protocol Global_9_111_255_46
2018-04-25_01:53:27.86816 bird: Removing protocol Global_9_111_255_91
2018-04-25_01:53:27.86816 bird: Reconfigured
2018-04-25_01:54:19.30854 bird: Reconfiguration requested by SIGHUP
2018-04-25_01:54:19.30865 bird: Reconfiguring
2018-04-25_01:54:19.30865 bird: Adding protocol Global_9_111_255_21
2018-04-25_01:54:19.30866 bird: Adding protocol Global_9_111_255_46
2018-04-25_01:54:19.30866 bird: Adding protocol Global_9_111_255_91
2018-04-25_01:54:19.30866 bird: Reconfigured
2018-04-25_01:54:21.63859 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 54302)
2018-04-25_01:54:21.63905 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 41413)
2018-04-25_01:54:22.64086 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 59410)
2018-04-25_01:54:25.64517 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 54765)
2018-04-25_01:54:25.64583 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 60050)
2018-04-25_01:54:27.64858 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 57489)
2018-04-25_01:54:29.65133 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 40466)
2018-04-25_01:54:30.65382 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 35078)
2018-04-25_01:54:32.65676 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 43583)
2018-04-25_01:54:33.65776 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 54443)
2018-04-25_01:54:35.66149 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 49551)
2018-04-25_01:54:37.66779 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 33676)
2018-04-25_01:54:38.66686 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 51077)
2018-04-25_01:54:40.67071 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 36235)
2018-04-25_01:54:41.67236 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 53992)
2018-04-25_01:54:42.67376 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 65040)
2018-04-25_01:54:44.67672 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 46258)
2018-04-25_01:54:46.68051 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 42112)
2018-04-25_01:54:46.68052 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 49757)
2018-04-25_01:54:49.68630 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 59868)
2018-04-25_01:54:51.68926 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 37792)
2018-04-25_01:54:51.68993 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 52015)
2018-04-25_01:54:54.69447 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 49887)
2018-04-25_01:54:56.69804 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 56744)
2018-04-25_01:54:56.69834 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 63794)
2018-04-25_01:54:59.70333 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 59579)
2018-04-25_01:55:01.70659 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 36986)
2018-04-25_01:55:01.70701 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 58765)
2018-04-25_01:55:04.71012 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 34724)
2018-04-25_01:55:05.71196 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 51670)
2018-04-25_01:55:05.71205 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 56835)
2018-04-25_01:55:09.71855 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 56343)
2018-04-25_01:55:09.71861 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 33709)
2018-04-25_01:55:09.71908 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 32788)
2018-04-25_01:55:13.72610 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 42195)
2018-04-25_01:55:14.72628 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 50254)
2018-04-25_01:55:14.72672 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 36244)
2018-04-25_01:55:18.73297 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 35463)
2018-04-25_01:55:18.73300 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 44523)
2018-04-25_01:55:19.73375 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 40123)
2018-04-25_01:55:22.73946 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 48672)
2018-04-25_01:55:23.73997 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 34465)
2018-04-25_01:55:24.74187 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 61876)
2018-04-25_01:55:27.74671 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 60284)
2018-04-25_01:55:27.74716 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 55915)
2018-04-25_01:55:28.74825 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 34392)
2018-04-25_01:55:32.75428 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 37214)
2018-04-25_01:55:32.75508 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 55594)
2018-04-25_01:55:32.75514 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 55522)
2018-04-25_01:55:36.76187 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 60021)
2018-04-25_01:55:37.76339 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 42861)
2018-04-25_01:55:37.76344 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 41678)
2018-04-25_01:55:40.76813 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 39215)
2018-04-25_01:55:40.76814 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 34888)
2018-04-25_01:55:42.77265 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 39807)
2018-04-25_01:55:45.77709 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 52937)
2018-04-25_01:55:45.77710 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 56122)
2018-04-25_01:55:46.77969 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 46400)
2018-04-25_01:55:49.78409 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 46305)
2018-04-25_01:55:50.78628 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 38069)
2018-04-25_01:55:51.78846 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 43337)
2018-04-25_01:55:53.79205 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 58828)
2018-04-25_01:55:55.79294 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 58232)
2018-04-25_01:55:56.79524 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 37550)
2018-04-25_01:55:57.79732 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 36339)
2018-04-25_01:55:58.79894 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 50434)
2018-04-25_01:56:01.80323 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 34590)
2018-04-25_01:56:02.80477 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 33937)
2018-04-25_01:56:03.80596 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 36376)
2018-04-25_01:56:06.81097 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 47851)
2018-04-25_01:56:06.81127 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 60037)
2018-04-25_01:56:08.81369 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 40575)
2018-04-25_01:56:10.81696 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 52640)
2018-04-25_01:56:10.81789 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 39120)
2018-04-25_01:56:13.82245 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 48127)
2018-04-25_01:56:14.82458 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 59916)
2018-04-25_01:56:15.82680 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 40572)
2018-04-25_01:56:17.82982 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 57935)
2018-04-25_01:56:18.83116 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 36049)
2018-04-25_01:56:19.83258 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 59284)
2018-04-25_01:56:22.83846 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 58493)
2018-04-25_01:56:23.83914 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 43370)
2018-04-25_01:56:23.84005 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 44279)
2018-04-25_01:56:27.84605 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 51343)
2018-04-25_01:56:27.84712 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 34202)
2018-04-25_01:56:28.84815 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 41136)
2018-04-25_01:56:31.85268 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 58492)
2018-04-25_01:56:32.85398 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 43425)
2018-04-25_01:56:32.85412 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 43147)
2018-04-25_01:56:35.85974 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 37824)
2018-04-25_01:56:36.85927 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 50429)
2018-04-25_01:56:37.86110 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 55093)
2018-04-25_01:56:40.86629 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 55206)
2018-04-25_01:56:41.86793 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 56486)
2018-04-25_01:56:41.86795 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 35765)
2018-04-25_01:56:45.87462 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 42539)
2018-04-25_01:56:45.87475 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 45828)
2018-04-25_01:56:46.87637 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 61075)
2018-04-25_01:56:50.88206 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 59754)
2018-04-25_01:56:50.88208 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 58948)
2018-04-25_01:56:51.88477 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 50762)
2018-04-25_01:56:55.88966 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 34434)
2018-04-25_01:56:55.89129 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 39995)
2018-04-25_01:56:56.89279 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 47542)
2018-04-25_01:57:00.89983 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 47356)
2018-04-25_01:57:00.90025 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 47106)
2018-04-25_01:57:00.90052 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 61471)
2018-04-25_01:57:04.55116 bird: Reconfiguration requested by SIGHUP
2018-04-25_01:57:04.55116 bird: Reconfiguring
2018-04-25_01:57:04.55117 bird: Removing protocol Global_9_111_255_21
2018-04-25_01:57:04.55117 bird: Reconfigured
2018-04-25_01:57:04.86271 bird: Reconfiguration requested by SIGHUP
2018-04-25_01:57:04.86280 bird: Reconfiguring
2018-04-25_01:57:04.86280 bird: Removing protocol Global_9_111_255_46
2018-04-25_01:57:04.86281 bird: Reconfigured
2018-04-25_01:57:04.90546 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 54385)
2018-04-25_01:57:04.90627 bird: BGP: Unexpected connect from unknown address <IP_ADDRESS> (port 61118)
2018-04-25_01:57:05.15902 bird: Reconfiguration requested by SIGHUP
2018-04-25_01:57:05.15910 bird: Reconfiguring
2018-04-25_01:57:05.15910 bird: Removing protocol Global_9_111_255_91
2018-04-25_01:57:05.15915 bird: Reconfigured

I have two clusters with following configurations:
Cluster1, etcd for cluster1 is at <IP_ADDRESS>.
<IP_ADDRESS> gyliu-ubuntu-3
<IP_ADDRESS> gyliu-ubuntu-2
<IP_ADDRESS> gyliu-ubuntu-1

Cluster2, etcd for cluster1 is at <IP_ADDRESS>
<IP_ADDRESS> gyliu-icp-1.novalocal  gyliu-icp-1
<IP_ADDRESS> gyliu-icp-2.novalocal  gyliu-icp-2
<IP_ADDRESS> gyliu-icp-3.novalocal  gyliu-icp-3

Router Reflector and its etcd
<IP_ADDRESS> gyliu-icp-4.novalocal gyliu-icp-4

/cc @caseydavenport @tmjd any comments for this? What can I do if I want to share one Router Reflector between two clusters? Thanks.

Seems the kube controller on Cluster1 will clean calico nodes for Cluster2, any configurations that I can use to resolve this issue?

Yeah, for this one I think the only thing you can do is run separate etcd instances for each cluster. I'd recommend doing that anyway.
As for using a single route reflector across two clusters - at a BGP level it should work fine, however the current calico/routereflector container will only work in a single cluster and it needs to share an etcd with the Calico nodes in that cluster.
I'd like to enhance Calico's native RR capabilities to support something like this, but it's still a WIP and needs some more thought.
For now, you could probably set up a RR in each cluster, and then set up a third external RR using a static BIRD config (rather than using calico/routereflector) in order to get routes between the two clusters.

For now, you could probably set up a RR in each cluster, and then set up a third external RR using a static BIRD config (rather than using calico/routereflector) in order to get routes between the two clusters.

Thanks @caseydavenport , any document for this? How to set up a  third external RR using a static BIRD config (rather than using calico/routereflector)?

I think this is a decent start: https://docs.projectcalico.org/v3.1/usage/routereflector/bird-rr-config

Thanks @caseydavenport
I followed the steps at https://docs.projectcalico.org/v3.1/usage/routereflector/bird-rr-config , and it works fine for pods in two clusters can communicate with each other.

@gaopeiliang the two clusters should have different asNumber.

@gyliu513 what is the reasoning behind that? I think it will be ok to use the same asNumber for both clusters (and logically nodes from both clusters could belong to the same autonomous system).

@ffilippopoulos sorry, I did not do the test of using same asNumber for the two clusters, so not sure if it works. Would be happy to see if someone do the test with same asNumber and check if it works.
FYI @caseydavenport @tmjd


Update docs of i_CTRL-R_CTRL-R

The documentation of i_CTRL-R_CTRL-R, i_CTRL-R_CTRL-P and
i_CTRL-R_CTRL-O didn't include an explanation about what stays in the '.'
register after them, and worked differently.
The command of i_CTRL-R_CTRL-R works the same as the command i_CTRL-R in
respect to this register, but the commands of i_CTRL-R_CTRL-P and
i_CTRL-R_CTRL-O inserts the commands to the '.' register, and not the
text produced as a result of this command.
This commit adds this documentation to the documentation in the help of
these commands.
Fixes #5771

I'll include it, thanks.


allow for classrooms to configure times & and sizes per class

allow for classrooms to configure times & and sizes per class much like https://github.com/OSC/bc_classroom_jupyter/pull/10 on the jupyter repo

This relies on a bug fix in ood, but even so, I'm moving on it now.


4.x: Cherry-pick across CI improvements from main

This cherry-picks assorted minor CI improvements from main -- most notably, the test that shows that we can upgrade from 3.4.

lgtm assuming CI passes.  I'm not 100% confident we're not missing additional bug fixes relevant to the upgrade CI tests passing, but this passing CI would be a strong sign that we're all good.