Government User

this is where we put all conversations regarding this work

Ok here is a list of task as defined by our conversation.

Sign up will lead to page that have 2 buttons.  a) Government User Sign up   b) non-Government User Sign Up
b will go to the current sign up form, a will go to form that ask for Organization Name. string
When sign up with gov. Role will be = "gov_request"
Add Manage Gov. Request in admin under manage user.
Manage government User will have a list of  request. when click approve... change role to "gov".  If not approve TBD.
add organization to the user view/edit module
check that if duplicate email then error message pop up
check that forgot password working
check if profile image works

yes, with clarifications:

the sign up for government users is identical to that of non-gov users except:

no github signup
add organization field

The role is gov-request, not gov_request
forgot password includes the email portion (the entire workflow of it really)

Gotcha

You found out what happen to user when gov user is rejected? Thanks

Let's just remove the request role for now.
On Tue, Nov 8, 2016 at 9:36 AM, Wayne Vo<EMAIL_ADDRESS>wrote:

You found out what happen to user when gov user is rejected? Thanks
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/BCDevExchange/devex/issues/5#issuecomment-259204447,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEtDEQn-5ybLcvTShD908YSqxx9JZeCks5q8LMCgaJpZM4Kpw4g
.

Sorry what do you mean?
On Tue, Nov 8, 2016 at 11:02 AM, ccoldwell<EMAIL_ADDRESS>wrote:

Let's just remove the request role for now.
On Tue, Nov 8, 2016 at 9:36 AM, Wayne Vo<EMAIL_ADDRESS>wrote:

You found out what happen to user when gov user is rejected? Thanks
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/BCDevExchange/devex/issues/5#issuecomment-259204447
,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEtDEQn-
5ybLcvTShD908YSqxx9JZeCks5q8LMCgaJpZM4Kpw4g>
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/BCDevExchange/devex/issues/5#issuecomment-259227691,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFbQawFiwC7DsV4N0LTBLUAumaBM_ldoks5q8MdbgaJpZM4Kpw4g
.

--
Wayne Vo
MelaVo Media Ltd.
Web Developer & Designer
778-230-3652

when the user is rejected, just remove the -request role.  We can figure out what to do from a business standpoint a little later.  Eventually we would like to send them an email letting them know, but there is yet to exist a business process to send them through.

I push all my changes to the branch gov user. I am testing and will commit any other bugs for Monday, but everything should be ok.  Fyi.  when reject I made it user so it different from approve so we can test.  Thanks

Let me know if you have any changes or if ok I can do a pull request. Thanks

Hi @melavo, I went through and there were only two things that I made note of.

Please move the organization field down below the email field on the form
Always have the 'user' role present. So a request has both gov-request and user, then gov and user, or simply user if denied.
Other than that things are looking great! Thanks!

Also, make sure that you take care of all merge issues for the final pull request.  Thanks.  I will stay out of there.

I have to deal with a family emergency, will change tonight. I will do a
pull request after these tweaks. thanks
On Monday, November 14, 2016, ccoldwell<EMAIL_ADDRESS>wrote:

Also, make sure that you take care of all merge issues for the final pull
request. Thanks. I will stay out of there.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.<
https://ci6.googleusercontent.com/proxy/TVG2OKO9YLCzIgbMKLsCISj-dPAmsjjxJMyzIcTfL6rlNQ0B0sJt0vmYCyWcRemkqtfofZ9U4WpJZNh0o_cu69Hp54zNWn3sXAXfBiBqfmgVjhiu6Nnm8nN6JzHlDGVXyx1PEQNK1ZoQ0JpYmmsKwRLIjIHkIg=s0-d-e1-ft#https://github.com/notifications/beacon/AFbQa8HKuPK5cSHY_UvO_aqFGVEKKqOwks5q-K1UgaJpZM4Kpw4g.gif

--
Wayne Vo
MelaVo Media Ltd.
Web Developer & Designer
778-230-3652

Sorry, I don't understand what you mean by #2.
On Monday, November 14, 2016, ccoldwell<EMAIL_ADDRESS>wrote:

Hi @melavo, I went through and there were only two things that I made
note of.

Please move the organization field down below the email field on the
form
Always have the 'user' role present. So a request has both gov-request
and user, then gov and user, or simply user if denied.
Other than that things are looking great! Thanks!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.<
https://ci3.googleusercontent.com/proxy/JVFKOwcboNN7f2uGQHZmEOWjadAHNMrbBA6rtpXEcR9lxV3YiMMR_c-EYDv1rHxU62f4xaxxWOabPOV9HHeDv6p5fl_FCM35stxOMJWxUEPG4xyOxpntRsiRQNmCMp4QMM5LpYUB6JfT4unO4H8iJiRujhtg_w=s0-d-e1-ft#https://github.com/notifications/beacon/AFbQawo9zzi_3Dvkap6NP2VuFWZXJllMks5q-Kz7gaJpZM4Kpw4g.gif

--
Wayne Vo
MelaVo Media Ltd.
Web Developer & Designer
778-230-3652

Hi Wayne, I mean this:
when a new government user is created they will have two roles:

user
gov-request
when they are accepted:
user
gov
when they are rejected:
user

thats it.
Chris
On Mon, Nov 14, 2016 at 12:50 PM, Wayne Vo<EMAIL_ADDRESS>wrote:

Sorry, I don't understand what you mean by #2.
On Monday, November 14, 2016, ccoldwell<EMAIL_ADDRESS>wrote:

Hi @melavo, I went through and there were only two things that I made
note of.

Please move the organization field down below the email field on the
form
Always have the 'user' role present. So a request has both gov-request
and user, then gov and user, or simply user if denied.
Other than that things are looking great! Thanks!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.<
https://ci3.googleusercontent.com/proxy/JVFKOwcboNN7f2uGQHZmEOWjadAHNM
rbBA6rtpXEcR9lxV3YiMMR_c-EYDv1rHxU62f4xaxxWOabPOV9HHeDv6p5fl_
FCM35stxOMJWxUEPG4xyOxpntRsiRQNmCMp4QMM5LpYUB6JfT4unO4H8iJiR
ujhtg_w=s0-d-e1-ft#https://github.com/notifications/beacon/AFbQawo9zzi_
3Dvkap6NP2VuFWZXJllMks5q-Kz7gaJpZM4Kpw4g.gif

--
Wayne Vo
MelaVo Media Ltd.
Web Developer & Designer
778-230-3652
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/BCDevExchange/devex/issues/5#issuecomment-260458556,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEtDGQUxOf7_paAn_sypzo9YuTkqNisks5q-MmngaJpZM4Kpw4g
.

Right now role is stored as string, Do you want me to keep it as string or
change it to array since we now have more then one role per user.  Thanks
On Tue, Nov 15, 2016 at 9:56 AM, ccoldwell<EMAIL_ADDRESS>wrote:

Hi Wayne, I mean this:
when a new government user is created they will have two roles:

user
gov-request
when they are accepted:
user
gov
when they are rejected:
user

thats it.
Chris
On Mon, Nov 14, 2016 at 12:50 PM, Wayne Vo<EMAIL_ADDRESS>wrote:

Sorry, I don't understand what you mean by #2.
On Monday, November 14, 2016, ccoldwell<EMAIL_ADDRESS>wrote:

Hi @melavo, I went through and there were only two things that I made
note of.

Please move the organization field down below the email field on the
form
Always have the 'user' role present. So a request has both
gov-request
and user, then gov and user, or simply user if denied.
Other than that things are looking great! Thanks!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.<
https://ci3.googleusercontent.com/proxy/JVFKOwcboNN7f2uGQHZmEOWjadAHNM
rbBA6rtpXEcR9lxV3YiMMR_c-EYDv1rHxU62f4xaxxWOabPOV9HHeDv6p5fl_
FCM35stxOMJWxUEPG4xyOxpntRsiRQNmCMp4QMM5LpYUB6JfT4unO4H8iJiR
ujhtg_w=s0-d-e1-ft#https://github.com/notifications/beacon/AFbQawo9zzi_
3Dvkap6NP2VuFWZXJllMks5q-Kz7gaJpZM4Kpw4g.gif

--
Wayne Vo
MelaVo Media Ltd.
Web Developer & Designer
778-230-3652
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/BCDevExchange/devex/issues/5#issuecomment-260458556
,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEtDGQUxOf7_paAn_
sypzo9YuTkqNisks5q-MmngaJpZM4Kpw4g>
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/BCDevExchange/devex/issues/5#issuecomment-260716084,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFbQa8j_2Hkej88-Iq7zGbvm1bcbDx0Yks5q-fJkgaJpZM4Kpw4g
.

--
Wayne Vo
MelaVo Media Ltd.
Web Developer & Designer
778-230-3652

the model shows that user.roles is an array of strings, so it already
handles multiple
On Tue, Nov 15, 2016 at 10:40 AM, Wayne Vo<EMAIL_ADDRESS>wrote:

Right now role is stored as string, Do you want me to keep it as string or
change it to array since we now have more then one role per user. Thanks
On Tue, Nov 15, 2016 at 9:56 AM, ccoldwell<EMAIL_ADDRESS>wrote:

Hi Wayne, I mean this:
when a new government user is created they will have two roles:

user
gov-request
when they are accepted:
user
gov
when they are rejected:
user

thats it.
Chris
On Mon, Nov 14, 2016 at 12:50 PM, Wayne Vo<EMAIL_ADDRESS>wrote:

Sorry, I don't understand what you mean by #2.
On Monday, November 14, 2016, ccoldwell<EMAIL_ADDRESS>wrote:

Hi @melavo, I went through and there were only two things that I made
note of.

Please move the organization field down below the email field on
the
form
Always have the 'user' role present. So a request has both
gov-request
and user, then gov and user, or simply user if denied.
Other than that things are looking great! Thanks!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.<
https://ci3.googleusercontent.com/proxy/JVFKOwcboNN7f2uGQHZmEOWjadAHNM
rbBA6rtpXEcR9lxV3YiMMR_c-EYDv1rHxU62f4xaxxWOabPOV9HHeDv6p5fl_
FCM35stxOMJWxUEPG4xyOxpntRsiRQNmCMp4QMM5LpYUB6JfT4unO4H8iJiR
ujhtg_w=s0-d-e1-ft#https://github.com/notifications/
beacon/AFbQawo9zzi_
3Dvkap6NP2VuFWZXJllMks5q-Kz7gaJpZM4Kpw4g.gif

--
Wayne Vo
MelaVo Media Ltd.
Web Developer & Designer
778-230-3652
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/BCDevExchange/devex/issues/5#
issuecomment-260458556
,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEtDGQUxOf7_paAn_
sypzo9YuTkqNisks5q-MmngaJpZM4Kpw4g>
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/BCDevExchange/devex/issues/5#issuecomment-260716084
,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFbQa8j_2Hkej88-
Iq7zGbvm1bcbDx0Yks5q-fJkgaJpZM4Kpw4g>
.

--
Wayne Vo
MelaVo Media Ltd.
Web Developer & Designer
778-230-3652
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/BCDevExchange/devex/issues/5#issuecomment-260728049,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEtDGGFywjtYaJXCMv_p5hfqN-WTAgBks5q-fytgaJpZM4Kpw4g
.

Done and did a pull request. Thanks
On Tue, Nov 15, 2016 at 11:09 AM, ccoldwell<EMAIL_ADDRESS>wrote:

the model shows that user.roles is an array of strings, so it already
handles multiple
On Tue, Nov 15, 2016 at 10:40 AM, Wayne Vo<EMAIL_ADDRESS>wrote:

Right now role is stored as string, Do you want me to keep it as string
or
change it to array since we now have more then one role per user. Thanks
On Tue, Nov 15, 2016 at 9:56 AM, ccoldwell<EMAIL_ADDRESS>wrote:

Hi Wayne, I mean this:
when a new government user is created they will have two roles:

user
gov-request
when they are accepted:
user
gov
when they are rejected:
user

thats it.
Chris
On Mon, Nov 14, 2016 at 12:50 PM, Wayne Vo<EMAIL_ADDRESS>wrote:

Sorry, I don't understand what you mean by #2.
On Monday, November 14, 2016, ccoldwell<EMAIL_ADDRESS>wrote:

Hi @melavo, I went through and there were only two things that I
made
note of.

Please move the organization field down below the email field on
the
form
Always have the 'user' role present. So a request has both
gov-request
and user, then gov and user, or simply user if denied.
Other than that things are looking great! Thanks!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the
thread.<
https://ci3.googleusercontent.com/proxy/
JVFKOwcboNN7f2uGQHZmEOWjadAHNM
rbBA6rtpXEcR9lxV3YiMMR_c-EYDv1rHxU62f4xaxxWOabPOV9HHeDv6p5fl_
FCM35stxOMJWxUEPG4xyOxpntRsiRQNmCMp4QMM5LpYUB6JfT4unO4H8iJiR
ujhtg_w=s0-d-e1-ft#https://github.com/notifications/
beacon/AFbQawo9zzi_
3Dvkap6NP2VuFWZXJllMks5q-Kz7gaJpZM4Kpw4g.gif

--
Wayne Vo
MelaVo Media Ltd.
Web Developer & Designer
778-230-3652
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/BCDevExchange/devex/issues/5#
issuecomment-260458556
,
or mute the thread
<https://github.com/notifications/unsubscribe-
auth/AAEtDGQUxOf7_paAn_
sypzo9YuTkqNisks5q-MmngaJpZM4Kpw4g>
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/BCDevExchange/devex/issues/5#
issuecomment-260716084
,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFbQa8j_2Hkej88-
Iq7zGbvm1bcbDx0Yks5q-fJkgaJpZM4Kpw4g>
.

--
Wayne Vo
MelaVo Media Ltd.
Web Developer & Designer
778-230-3652
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/BCDevExchange/devex/issues/5#issuecomment-260728049
,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEtDGGFywjtYaJXCMv_
p5hfqN-WTAgBks5q-fytgaJpZM4Kpw4g>
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/BCDevExchange/devex/issues/5#issuecomment-260736269,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFbQa1LX4n2v364ozEODyl6tR4c27Iz0ks5q-gOGgaJpZM4Kpw4g
.

--
Wayne Vo
MelaVo Media Ltd.
Web Developer & Designer
778-230-3652

Thanks @melavo for the great work! Closing this issue.


Project not working with v3.x of tinkerwell

With the release of tinkerwell v3 this project stopped working. This seems to be related to the order of arguments and the contents thereof that are being passed to the PHP binary

Any update on a new version to support Tinkerwell v3?


Implement async support for all applicable peripheral drivers

While we have a tracking issue for async drivers with embedded-hal-alpha traits (#70), we should additionally implement async drivers for peripherals which do not have traits pre-defined. We can still provide our own APIs and make these useful.
As we make progress on #70 and I have a better idea of how things are looking, I will update this comment to (eventually) include a task list tracking which drivers need work.

I'll look into AES

I'll be working on SHA!

Async support for USB Serial JTAG added in #632

Maybe it would be helpful to go through our existing drivers and figure out which are capable of asynchronous operation, then we can create a task list here to track the progress and hopefully make it easier for people to contribute.

I'm working on RSA

@JurajSadel @SergioGasquez any updates on your progress? If you don't have time to work on these it might be nice to push your current efforts to a branch so somebody else could wrap it up.

I started working on SHA, abandoned it (it was not working) for other stuff, then DMA was refactored in several ways. Today, I started reimplementing my changes from scratch using an updated base branch, here are my changes: https://github.com/esp-rs/esp-hal/compare/main...SergioGasquez:esp-hal:feat/dma-sha. It still not working, so I will try to work on it

@jessebraham I have my work here: https://github.com/JurajSadel/esp-hal/tree/feature/async-aes it does something but it's not correct yet.

I will start looking into async I2S next

I'll implement async PARL_IO next

Hi, the async read i2c method in esp32c3 is not working. 😄

Will take a look into USB for s2 and s3

I'm working on TWAI in #951

Just noting, the list in the original comment needs to be updated to include new peripherals on the ESP32-P4 (but this is pretty low-priority).

I think this issue has probably outlived its usefulness, we can create issues per-driver as needed (some of these exist already).


Add tests (excluding smoke) to CI GitHub Action

For #9842
Add tests step (excluding smoke tests) to the CI GitHub action.

[x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
[x] Title summarizes what is changing.
[ ] Has a news entry file (remember to thank yourself!).
[ ] Appropriate comments and documentation strings in the code.
[ ] Has sufficient logging.
[ ] Has telemetry for enhancements.
[ ] Unit tests & system/integration tests are added/updated.
[ ] Test plan is updated as appropriate.
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).
[ ] The wiki is updated with any design decisions/details.

Codecov Report

Merging #9924 into master will decrease coverage by 61.21%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #9924       +/-   ##
==========================================
- Coverage   61.21%      0%   -61.22%
==========================================
  Files         564      10      -554
  Lines       30061      31    -30030
  Branches     4545       4     -4541
==========================================
- Hits        18403       0    -18403
+ Misses      10629      31    -10598
+ Partials     1029       0     -1029

Impacted Files
Coverage Δ

src/client/debugger/constants.ts
0% <0%> (-100%)
:arrow_down:

src/client/common/platform/constants.ts
0% <0%> (-100%)
:arrow_down:

src/client/interpreter/locators/services/conda.ts
0% <0%> (-100%)
:arrow_down:

src/client/common/process/constants.ts
0% <0%> (-100%)
:arrow_down:

src/client/constants.ts
0% <0%> (-80%)
:arrow_down:

...ience/jupyter/jupyterDebuggerRemoteNotSupported.ts
0% <0%> (-60%)
:arrow_down:

...t/datascience/jupyter/jupyterDataRateLimitError.ts
0% <0%> (-50%)
:arrow_down:

src/client/language/textRangeCollection.ts

.../application/diagnostics/commands/launchBrowser.ts

...c/client/interpreter/autoSelection/rules/system.ts

... and 551 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92cf27a...c030545. Read the comment docs.

Codecov Report

Merging #9924 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #9924      +/-   ##
=========================================
- Coverage   61.21%   61.2%   -0.02%
=========================================
  Files         564     564
  Lines       30061   30061
  Branches     4545    4545
=========================================
- Hits        18403   18398       -5
- Misses      10629   10633       +4
- Partials     1029    1030       +1

Impacted Files
Coverage Δ

src/client/common/utils/platform.ts
64.7% <0%> (-11.77%)
:arrow_down:

src/client/linters/pydocstyle.ts
86.66% <0%> (-2.23%)
:arrow_down:

src/client/datascience/debugLocationTracker.ts
76.56% <0%> (-1.57%)
:arrow_down:

src/client/common/process/proc.ts
14.49% <0%> (-0.73%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92cf27a...d2d07e8. Read the comment docs.


feat(Toolbar): add menu prop

wip

Warnings

:warning:
There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

  Generated by :no_entry_sign: dangerJS


sha512.badssl Certificate failed

Hi,
I'm using your app and the application is showing error when clicking the button. It say that sha512.badssl certification error. SSL Certificate for target is expired

Hi @aancw, thanks for getting in touch.
That error is not coming from HTTP Toolkit at all though. The certificate for that site really has expired. When visiting it in any browser on any device you like you will see this error, even without using HTTP Toolkit.
In fact, I'm not sure what your setup is, but it looks like the browser you're showing isn't actually being intercepted by HTTP Toolkit at all. If it was, the 'Issuer' would say 'HTTP Toolkit CA'. If you do try to visit the site using a browser intercepted by HTTP Toolkit, you will see a "Certificate has expired" error, but within a normal secure response, because the HTTPS connection (from your browser to HTTP Toolkit) will work correctly, and only the upstream connection (HTTP Toolkit to the server) will fail because of the failed certificate.
Does that make sense? In both cases, HTTP Toolkit isn't doing anything wrong here - the problem is that that server's certificate really has expired. This is tracked by the team running that service here: https://github.com/chromium/badssl.com/issues/501. I'd suggest getting in touch with them directly if you want to help get that fixed.

I know that the problem is in the server. What i mean, can this server url changed? Because this app cannot running without proxy. I'm using this app for the article but the demo showing error when pinning the request.

Nevermind, I've forked the repo and change the url that work for this app and signed the apk too.
https://github.com/aancw/android-ssl-pinning-signed-demo

Ah, I see! Sorry, I had no idea what you were talking about before. That makes a lot more sense now, thanks for the screenshot and info.
This is now fixed in the app, there's an updated v1.3.0 available that should work correctly: https://github.com/httptoolkit/android-ssl-pinning-demo/releases/tag/v1.3.0

Hi,
The app need to be signed so android can install the apk. I've tried it in my repo and successfully install the app. With your build, it's failed to install. If you don't mind, I can pull request my change to your repo and make setup tutorial for github workflow.

I think the v1.3.0 APK is signed already, isn't it? I was doing this manually before, but it's now automated: https://github.com/httptoolkit/android-ssl-pinning-demo/commit/04a5c5dc6f49c9ea62ccc66cbd63ca6e4cf077b5.
If you download it, you can test that for yourself:
$ apksigner verify --print-certs ./pinning-demo.apk
Signer #1 certificate DN: CN=Tim Perry, OU=Unknown, O=HTTP Toolkit, L=Barcelona, ST=Barcelona, C=ES
Signer #1 certificate SHA-256 digest: 03235c7ac4d8111ea7b56152841acdb8d9570968885826d00c604b3bbb8c7b68
Signer #1 certificate SHA-1 digest: 985c29731c39325874d93f2f0f0e47af4f1828bd
Signer #1 certificate MD5 digest: df7af10590483a886870630400079767

I think that error above is because you have an app installed with the same package id but a different signature. The signature is different in this build because I've just generated a new key store for this, but if you uninstall the old version before you install the new version it should work. I don't think that matters too much, I don't expect many people are going to be upgrading between versions here, it's just a demo app.

Nice, last time I fork the repo, the apk is not signed. That's why I make update on ci.yml to sign the apk.


fix(api): Fix malformed PAPI error message

Overview
This fixes a malformed error message caught by the snapshot tests in #16062:
Nozzle layout configuration of style SINGLE is unsupported in API Versions lower than 2.20. is not yet available in the API version in use.

Test Plan and Hands on Testing
I'm relying on automated tests.
Changelog

Rework the underlying exceptions so that if you construct them with just a single unnamed string argument, it's used directly as the message, without any surprise concatenation. I think this is least surprising to the caller, given our codebase's existing exception conventions.

Also, for niceness:

typing.overloads, for clarity.
In the mode where we generate the exception message automatically from api_element+since_version+current_version, handle some additional cases of partially missing information.

Review requests
None.
Risk assessment
Low.

Hmm. Not sure why the snapshot tests on this PR aren't showing a diff.


1.12 otg+v9.5 r1

Fixed nullpointer for SaplingListener causing a Crash at Sapling Grow Event when the biome returns null.
Fixed SpawnPointY, now spawning you in either liquid or air and not in stone.
Generator-Settings= in server.properties can now be used to declare the preset. level-name= is not longer required but still works as a fallback.

PR causes crash and bugs in specific server environment, retracted PR until this issue has been resolved and thoroughly tested again.


Enhancing Data Visualization Scripts #515

Description
Used plotly and numpy to randomly generated data with seed. Also saved the images and updated the README.md
Fixes #515
Have you read the Contributing Guidelines on Pull Requests?

[X] Yes
[ ] No

Type of change
Please delete options that are not relevant.

[X] New feature (non-breaking change which adds functionality)
[X] Documentation Update

Checklist:

[X] My code follows the style guidelines(Clean Code) of this project
[X] I have performed a self-review of my own code
[X] I have created a helpful and easy to understand README.md
[X] My documentation follows Template for README.md
[X] My changes generate no new warnings
[X] I have added tests/screenshots(if any) that prove my fix is effective or that my feature works.

Hi, I made the changes and just wanted to verify if it is correct before pushing the code. Please check and let me know

Hi, I made the changes and just wanted to verify if it is correct before pushing the code. Please check and let me know

Yes, these are perfect. You can push these changes to the PR

@antrikshmisri @santushtisharma10 The changes I suggested will be updated by @ELITA04. Other than that if you find any changes kindly convey to @ELITA04

@all-contributors please add @ELITA04  for code and documentation


fix interpreter for uninstall script

the original interprepter is apparently for OSX instead of linux.
I'm maintaining a debian package called linuxbrew-wrapper, and
the patch comes from that package. I'm now
doing the package content transition as the linuxbrew upstream transition.
Actually Debian/Ubuntu users can use that package.
Well please inform me when doing large changes. Thanks :-)

@CDLuminate you may wish to subscribe to https://github.com/Linuxbrew/brew/issues/1 , which is the mailing list for important Linuxbrew updates.

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

The Travis failure has nothing to do with your change, so restarting the build.

:+1: Thanks, Lumin.

Bob, would you like to merge this?


Unable to load dynamic server library in hardened environment (tmp mounted as noexec)

I installed ollama on a hardened Ubuntu 22 system successfully. When running ollama run mistral, I am getting the following error message:
Error: Unable to load dynamic library: Unable to load dynamic server library: /tmp/ollama2322208974/cpu_avx2/libext_server.so: failed to map segment from shared object
The root cause seems to be that on this system, /tmp is mounted as noexec. I was able to fix the issue by setting another temporary directory in /etc/systemd/system/ollama.service by adding the line
Environment="TMPDIR=/usr/share/ollama/tmp"
I suggest addressing the issue by using a temporary directory within the /usr/share/ollama directory if /tmpis mounted as noexec, or to at least mention this issue in the documentation.

I had a similar issue, and in my case just updating Ollama fixed it :)

Hey @crenz, really sorry you ran into that problem. Could you check if the update to Ollama sorted it out for you? We're going to close this issue for now, but if you're still stuck, please let us know!


Software answering to "$im" command

As the tittle says the software is answering to "$im" command (lol)
ikd if it's is really an issue, sorry for waste your time if it isn't so @Kevinwkz .
This already trolled me 2 times xd.

That's a good one tho, even not being a "issue", I wanna make sure everything is clean. Will fix it later, ty for informing me :)


"EXTREME FRIENDLY URL" and ?

When "EXTREME FRIENDLY URL" is set to "true" posts and pages with titles using ? do not work.

Improves in extreme friendly url for Bludit v3.0.0.


Font URL imports within SCSS file not being properly resolved

Describe the bug

After using vite build and inspecting the assets that are generated, I cannot see my scss URLs being transformed.
Here's a source scss font import:

After running vite build --base=/app/dist/  I expect paths to be resolved like so:

Instead upon inspecting the resulting output what I get is the same URLs (path still starts with ./fonts):

My understanding according to the docs is that ./ is supposed to be resolved to a public url as per my configured base url of /app/dist/?
What could be causing the issue is that I don't have an index.html since my project is a laravel project and I have laravel load the vite resources for me depending on whether the devserver is running:

This is also a Vue2 project so I'm using the vite-plugin-vue2 plugin. Here's my vite.confg.js file:
const { createVuePlugin } = require('vite-plugin-vue2')

// https://sebastiandedeyne.com/vite-with-laravel/
export default ({ command }) => ({
    base: command === 'serve' ? '' : '/app/dist/',
    publicDir: 'fake_dir_so_nothing_gets_copied',
    build: {
        manifest: true,
        outDir: 'public/dist',
        rollupOptions: {
            input: {
                app: 'resources/js/app.js',
            }
        }
    },
    plugins: [createVuePlugin()],
    resolve: {
        alias: {
            '@': require('path').resolve(__dirname, 'resources/js'),
            '~': require('path').resolve(__dirname, 'resources/scss'),
            vue: 'vue/dist/vue.esm.js'
        }
    }
})

I can get all my js, images etc to work, just these webfont paths are causing some grief.

Reproduction
Run vite build --base=/app/

System Info
Output of npx envinfo --system --npmPackages vite,@vitejs/plugin-vue --binaries --browsers:

Used package manager: yarn
Logs

Before submitting the issue, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the docs.
[x] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[x] Provide a description in this issue that describes the bug.
[x] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/vue-next instead.
[x] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.

Would you check that this is still an issue against the latest version of Vite? In case it is, please provide a minimal reproduction as a github repro.


left side bar - "make search" term

magnifying glass moves the cell id or string to the right sidebar as a term


[HELP] What is causing connection refused?

When i read a value from firebase, i have no problems. When i write to another path, using different FirebaseData and different FirebaseJsonData objects, i get a connection refused error. I had no issues with this few days ago, help  :) .
Is my code a problem, is some firebase settings a problem, is it just the network?

It is because the SSL client can't connect to the server for some reason.

The internet access issue due to WiFi AP, router and ISP
The invalid or not existed host.  If you are hard code the FIREBASE_HOST, you may need to print out to check whether it's still correct or not. In some situation that the memory that this host name is stored is corrupted  from the memory allocation or improper handling and then the memory leaks.


Test default_ems_class_to_parent in ALL THE REPOS!1!11

cc @agrare @Fryguy

Bounced to rebase kubernetes provider on master.

Looks like everything passed cross-repo testing except for nuage (which we expected). Think that makes us ready to merge the core PR, then follow-up with the provider ones, right?


Get system metrics

In order to get better at performance testing we need to gather system metrics, at least memory and cpu usage. I see two options, but there may be more:

Use OpenTelemetry in some way so we send this information to the OTLP endpoint, just as we do with traces or other metrics.
Use Kubernetes directly to get these system metrics directly from pods.

The host and runtime instrumentations for Go could be useful too:

https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/instrumentation/host/example/main.go
https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/instrumentation/runtime/example_test.go


Bug fixes and browser compatibility fixes

hi Mike,
I made some changes to your project which should enable it to work in IE7+ and FF (and Chrome of course). I also fixed some bugs with "All" and "Selected" buttons. Can you please merge them into you project?
thanks,
Jon.

Thanks, unfortunately the diffs show that every single line changed, perhaps end of line characters changed? I'll need to grab separately and try to diff with another tool.

I combined and recommitted ef6d54c and a74fb23 in pull request 34.

Thanks!

No problem. And I only combined the first two commits, so if you still want the third one you should leave this open.

Oops, sorry. Reopened.


Add client block/unblock methods

Fixed: commit d784dda
do_block_client(mac) & do_unblock_client(mac)


Patch to show text in dropdowns

Coverage remained the same at 89.809% when pulling b42c39de0e0404d10e75c1efa72c1536fd08c74e on crackjack:patch-1 into 1ceafd8ff63e5888d5c0bcb9ff6f5d4e03769fcf on digi604:js-unlinting-fixes.

This patch works for me. Thank you.

@crackjack can you please against latest master to see if this PR is still necessary?

Closing inactive PR, please reopen if necessary.


Updated C28131, C28616 (WIP)

Updated to new format, clarified wording and examples

Docs Build status updates of commit ae1ac5a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

windows-driver-docs-pr/devtest/28616-multithreaded-av-condition.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit d8a6e94:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

windows-driver-docs-pr/devtest/28131-driverentry-saving-pointer-to-buffer.md
:white_check_mark:Succeeded

windows-driver-docs-pr/devtest/28616-multithreaded-av-condition.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Learn Build status updates of commit a2632dd:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

windows-driver-docs-pr/devtest/28131-driverentry-saving-pointer-to-buffer.md
:white_check_mark:Succeeded

windows-driver-docs-pr/devtest/28616-multithreaded-av-condition.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 12abf97:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

windows-driver-docs-pr/devtest/28131-driverentry-saving-pointer-to-buffer.md
:white_check_mark:Succeeded

windows-driver-docs-pr/devtest/28616-multithreaded-av-condition.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


sap_hana_preconfigure: Add RHEL 8.8 to the list of supported RHEL versions

... as per SAP note 2235581 version 78.
Also add the minimum required RHEL kernel versions as per SAP note 2235581 version 41.

Solved by #501.


Master -> develop 1.51

METRIC
VALUE

NEW VULNERABILITIES
0

NEW BUGS
0

NEW SECURITY HOTSPOTS
0

NEW CODE SMELLS
0

NEW DUPLICATED LINES DENSITY
0.0

https://sonarqube.cuahsi-workstation.com:9000/dashboard?id=hydroshare-4451


typos etc in public_vm.md

fix typos etc
Please provide a paragraph or two giving a summary of the change, including relevant motivation and context.
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

[ ] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
[ ] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
[ ] Every change is related to the PR description.
[ ] I have linked this pull request to relevant issues (if any exist).

Hi. We've recently decided on a policy that we will not be merging trivial PRs unless someone has done a significant contribution already. Really sorry. The recent usage of Github commits as a metric mean we have to manage this a bit.

Hi. We've recently decided on a policy that we will not be merging trivial PRs unless someone has done a significant contribution already. Really sorry. The recent usage of Github commits as a metric mean we have to manage this a bit.

Uh ok, I find a jarring grammar mistake and offer to fix it, and you decline? Will you just leave it unfixed then?

As I said, I'm really sorry about the policy. We will be rounding up the typo fixes soon.


Failed CRC check

Getting this error in esphome despite it seeming to be successful on a wb3l chip.
Processing office-test1 (board: wb3l; framework: arduino; platform: libretiny @ 1.7.0)
---------------------------------------------------------------------------------------------
Warning! Non-Git installations are NOT SUPPORTED.
Configuring upload protocol...
AVAILABLE: uart
CURRENT: upload_protocol = uart
Looking for upload port...
Using manually specified: /dev/ttyUSB0
Uploading .pioenvs/office-test1/firmware.uf2
|-- Detected file type: UF2 - esphome 2024.11.1
|-- Connecting to 'Beken 7231T' on /dev/ttyUSB0 @ 115200
|   |-- Success! Chip info: BK7231S_1.0.6
|-- Writing '.pioenvs/office-test1/firmware.uf2'
|   |-- esphome 2024.11.1 @ 2024-11-27 06:26:49 -> wb3l
|-- The current command timeout of 1.0 second(s) is too low for reading 782336 bytes CRC. Increasing to 2 second(s).
|-- ValueError: Chip CRC value 0 does not match calculated CRC value 1F8FB63C
|   |-- File "/root/.platformio/penv/.libretiny/lib/python3.11/site-packages/bk7231tools/serial/cmd_ll_chip.py", line 73, in check_crc
*** [upload] Error 1
```

Anything else I can check or does this seem like a bug?

This means that communication with the chip is most likely lost in the final stage of the flash process. Check if your wiring is connected properly and that you're using a reliable 3.3V power supply.
You can use ltchiptool directly (GUI or CLI) to flash the UF2 file. This way, you can use verbose logging to see what packets are received from the chip.
https://docs.libretiny.eu/docs/flashing/tools/ltchiptool/

I'll try a different usb to serial adapter along with a separate power supply tomorrow.

I was able to flash it with the same esphome build using this https://github.com/openshwprojects/BK7231GUIFlashTool
and it passed CRC check

I used ltchiptool directly woth cli and got the same CRC error as with esphome cli

The thing is, when you use ltchiptool directly you can enable verbose logging. That output would likely help finding where the issue is. If you can, try doing that and post the flashing logs here.
The flag -vv will show debug and verbose messages.


Unable to load service index for v3 nuget feeds when passing credentials

$Cred = Get-Credential $Username
Register-PSResourceRepository -Name $AuthenticatedFeed -URL "https://pkgs.dev.azure.com/<teamname>/_packaging/<feedname>/nuget/v3/index.json" -Trusted

Find-PSResource -Repository $AuthenticatedFeed -Credential $Cred
Find-PSResource: Unable to load the service index for source https://pkgs.dev.azure.com/<teamname>/_packaging/<feedname>/nuget/v3/index.json.

If I register the same feed with v2, https://pkgs.dev.azure.com/<teamname>/_packaging/<feedname>/nuget/v2, I can use the same Find-PSResource call passing in $cred and it functions
Using Powershell 7.0.0,
PowerShellGet 3.0.0-beta1
$Cred is using a PAT token with full access to remove any doubt if it's an issue on the authentication side as the password.

Hi,
Was there a fix implemented for this issue?
I've been experiencing this exact error with GitLab v3 Nuget feed: https://docs.gitlab.com/ee/user/packages/nuget_repository/
Steps to Reproduce

Create deploy token (username: build-deploy-token) with read_package_registry, write_package_registry permissions.

# Enter build-deploy-token as username and token secret as password
$Creds = Get-Credential
Register-PSResourceRepository -Name "GitLab" -Uri "https://gitlab.<domain>.com/api/v4/projects/<id>/packages/nuget/index.json" -Trusted -Verbose
# Name doesn't matter as it fails to load service index
Find-PSResource -Name "Test" -Repository "GitLab" -Credential $Creds -Verbose

# Output:
# PS > Find-PSResource -Repository "GitLab" -Credential $Creds -Verbose -Name test
# VERBOSE: Searching in repository GitLab
# VERBOSE: credential successfully set for repository: GitLab
# VERBOSE: Error retrieving resource from repository: Unable to load the service index for source https://gitlab.<domain>.com/api/v4/projects/<id>/packages/nuget/index.json.

@alerickson - can this please be reopened? The above example is still reproducing the problem.


Analytics for acom widget

resolves: MWPW-154526

@saragajic11 I know you built this based on the example used on the mobile widget. I think we should consolidate all these analytics into a single JS file. We can also delete lines 7 -24 we don't need anyone of those values. Other than that, this is perfect.

Hi @Blainegunn , I have done some refactoring and put all analytics for acom_widget in one file. Please check the following commit

Codecov Report
Attention: Patch coverage is 78.72340% with 10 lines in your changes missing coverage. Please review.

Project coverage is 93.58%. Comparing base (05ac401) to head (e496ef3).

Files with missing lines
Patch %
Lines

acrobat/scripts/alloy/acom-widget.js
80.64%
6 Missing :warning:

acrobat/blocks/acom-widget/acom-widget.js
75.00%
4 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##            stage     #773      +/-   ##
==========================================
- Coverage   93.72%   93.58%   -0.15%
==========================================
  Files          40       41       +1
  Lines        4955     5002      +47
==========================================
+ Hits         4644     4681      +37
- Misses        311      321      +10

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Unable to playback kinesis video stream under video capture frame project

Description
When i run the playbackKinesisVideoStream.py
raise error_class(parsed_response, operation_name)
botocore.errorfactory.ResourceNotFoundException: An error occurred (ResourceNotFoundException) when calling the GetDataEndpoint operation: The requested stream is not found or not active.

Type of issue

[ ] Bug

Checklist:

[ ] I have read the project guidelines.
[ ] I have checked all the existing projects, before submitting a new project issue.
[ ] I have checked previous issues to avoid duplicates.
[ ] This issue will be meaningful for the project.

@AtiqZaman this error shows that you haven't created your kinesis video stream on AWS kineses. When python code looks for stream name, it is not there. So make sure to create a kvs stream on AWS kinesis and replace the name of stream in code to your stream name.
Follow below steps to create a stream on AWS kinesis :

Signin to AWS management console

Login to AWS account, if u don't have, first create a new account

search for kinesis video stream in search bar

click on creat stream button

Type the name of stream, choose below configurations and click on create video stream btton

After creating this stream make sure to replace the stream name in python code as shown below

These steps will resoolve the issue of resource not found.
Then run your code :)


uhyve Unable to create VM

$ uhyve target/x86_64-unknown-hermit/debug/hello_world
thread 'main' panicked at 'Unable to create VM: OsError(16)', /home/giles/.cargo/registry/src/github.com-1ecc6299db9ec823/uhyve-0.0.23/src/bin/uhyve.rs:181:10
stack backtrace:
   0:     0x56016c0fd697 - std::backtrace_rs::backtrace::libunwind::trace::h746c3e9529d524bc
                               at /rustc/1700ca07c6dd7becff85678409a5df6ad4cf4f47/library/std/src/../../backtrace/src/backtrace/libunwind.rs:90:5
   1:     0x56016c0fd697 - std::backtrace_rs::backtrace::trace_unsynchronized::h86340908ff889faa
                               at /rustc/1700ca07c6dd7becff85678409a5df6ad4cf4f47/library/std/src/../../backtrace/src/backtrace/mod.rs:66:5
   2:     0x56016c0fd697 - std::sys_common::backtrace::_print_fmt::h43f85f9b18230404
                               at /rustc/1700ca07c6dd7becff85678409a5df6ad4cf4f47/library/std/src/sys_common/backtrace.rs:67:5
   3:     0x56016c0fd697 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::hc132ae1a5b5aa7cd
                               at /rustc/1700ca07c6dd7becff85678409a5df6ad4cf4f47/library/std/src/sys_common/backtrace.rs:46:22
   4:     0x56016c11c5cc - core::fmt::write::hdf023a0036d2a25f
                               at /rustc/1700ca07c6dd7becff85678409a5df6ad4cf4f47/library/core/src/fmt/mod.rs:1078:17
   5:     0x56016c0f85b2 - std::io::Write::write_fmt::h8580846154bcb66a
                               at /rustc/1700ca07c6dd7becff85678409a5df6ad4cf4f47/library/std/src/io/mod.rs:1519:15
   6:     0x56016c0ff805 - std::sys_common::backtrace::_print::h7ee55fed88d107a3
                               at /rustc/1700ca07c6dd7becff85678409a5df6ad4cf4f47/library/std/src/sys_common/backtrace.rs:49:5
   7:     0x56016c0ff805 - std::sys_common::backtrace::print::h54a7d3e52a524177
                               at /rustc/1700ca07c6dd7becff85678409a5df6ad4cf4f47/library/std/src/sys_common/backtrace.rs:36:9
   8:     0x56016c0ff805 - std::panicking::default_hook::{{closure}}::h60921e857bf55a40
                               at /rustc/1700ca07c6dd7becff85678409a5df6ad4cf4f47/library/std/src/panicking.rs:208:50
   9:     0x56016c0ff35a - std::panicking::default_hook::hf0f9afb1017317fc
                               at /rustc/1700ca07c6dd7becff85678409a5df6ad4cf4f47/library/std/src/panicking.rs:225:9
  10:     0x56016c0fffa1 - std::panicking::rust_panic_with_hook::h8d66bf42b407aaea
                               at /rustc/1700ca07c6dd7becff85678409a5df6ad4cf4f47/library/std/src/panicking.rs:591:17
  11:     0x56016c0ffae7 - std::panicking::begin_panic_handler::{{closure}}::hde71edcd925d0c5e
                               at /rustc/1700ca07c6dd7becff85678409a5df6ad4cf4f47/library/std/src/panicking.rs:497:13
  12:     0x56016c0fdb5c - std::sys_common::backtrace::__rust_end_short_backtrace::h8a3c7d6cea578919
                               at /rustc/1700ca07c6dd7becff85678409a5df6ad4cf4f47/library/std/src/sys_common/backtrace.rs:141:18
  13:     0x56016c0ffa49 - rust_begin_unwind
                               at /rustc/1700ca07c6dd7becff85678409a5df6ad4cf4f47/library/std/src/panicking.rs:493:5
  14:     0x56016c11b6f1 - core::panicking::panic_fmt::h20225113c4a2f8fd
                               at /rustc/1700ca07c6dd7becff85678409a5df6ad4cf4f47/library/core/src/panicking.rs:92:14
  15:     0x56016c11b513 - core::option::expect_none_failed::hc6d6d4cea4fdc285
                               at /rustc/1700ca07c6dd7becff85678409a5df6ad4cf4f47/library/core/src/option.rs:1268:5
  16:     0x56016bfd8999 - uhyve::main::h25caef88d415da46
  17:     0x56016bfd3823 - std::sys_common::backtrace::__rust_begin_short_backtrace::hbfc576f104f953ad
  18:     0x56016bfd3b49 - std::rt::lang_start::{{closure}}::hca78c41f3c1bcf7b
  19:     0x56016c1003c7 - core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once::h54c39b9b8451875a
                               at /rustc/1700ca07c6dd7becff85678409a5df6ad4cf4f47/library/core/src/ops/function.rs:259:13
  20:     0x56016c1003c7 - std::panicking::try::do_call::hcdfba51a06e21b42
                               at /rustc/1700ca07c6dd7becff85678409a5df6ad4cf4f47/library/std/src/panicking.rs:379:40
  21:     0x56016c1003c7 - std::panicking::try::hb36953ccd24f930d
                               at /rustc/1700ca07c6dd7becff85678409a5df6ad4cf4f47/library/std/src/panicking.rs:343:19
  22:     0x56016c1003c7 - std::panic::catch_unwind::hbb374cd03beb3824
                               at /rustc/1700ca07c6dd7becff85678409a5df6ad4cf4f47/library/std/src/panic.rs:396:14
  23:     0x56016c1003c7 - std::rt::lang_start_internal::h97dca9624db2aa85
                               at /rustc/1700ca07c6dd7becff85678409a5df6ad4cf4f47/library/std/src/rt.rs:51:25
  24:     0x56016bfd8bb2 - main
  25:     0x7f3171aadb6b - __libc_start_main
  26:     0x56016bfd30ca - _start
  27:                0x0 - <unknown>

any ideas?

Do you use Linux? Is kvm available on your system? Please show me the output of following command  RUST_LOG=debug uhyve -v target/x86_64-unknown-hermit/debug/hello_world.

Hi Thanks for your help i needed reboot  https://github.com/kubernetes/minikube/issues/6468#issuecomment-616027583

@gilesbradshaw Does it work with minikube? I never tested it.

ah sorry I don't know I was just reffing that as where I found suggestion to reboot :)

@stlankes I think we should handle the error more gracefully. Understanding the panic is probably not that easy for most people. I am reopening the error as a reminder. Maybe someone finds some time to fix this.

I'll merge https://github.com/hermitcore/uhyve/pull/42, but it does not fix the issue I had in mind. In general there are two types of errors:

A bug inside our code.
An error on user level (e.g. no access to KVM as described here, passing invalid parameters to uhyve, ...).

In case of a bug it is great if there is a stack trace so it can be tracked down, however in case of a user error the stack trace is confusing the user and uhyve should just terminate and print the appropriate message.

Do you prefer something like this?

I am not sure. That change means we treat every error the appears within vm::create_vm as a user error, which I guess it not true and there may very well be a bug in the code. I feel like we need to distinguishboth cases, but I am not sure how to do that.


Revert "Add files via upload"

Reverts JetBrains/swot#17173
Hi, i'm reverting this pull request because you used a wrong domain for the emails, the official domain for the emails is<EMAIL_ADDRESS>the proof is here as you can see: https://www.iismatteifortunato.edu.it/ufficio-relazioni-pubblico/
check the emails present in that page...
i'm writing this because i tried to apply for the license, but the website says that email is not valid

@philipto

@Tortillas-IT Pull request merged. Thank you.


Fix code scanning alert no. 2: Clear-text logging of sensitive information

Fixes https://github.com/Dargon789/electrum/security/code-scanning/2
To fix the problem, we need to avoid logging the password in clear text. Instead, we can log a message indicating that the password was found without revealing the actual password. This way, we maintain the functionality of informing the user that the password was successfully found without exposing sensitive information.
We will modify the print statement on line 96 to remove the actual password from the log message. Instead, we will log a generic message indicating that the password was found.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.
Summary by Sourcery
Bug Fixes:

Prevent the clear-text logging of the password.

Fix code scanning alert no. 2: Clear-text logging of sensitive information #11


Da/kernel errors

Problem
addresses #260
Solution
improved error messages

Note I also patched a bug I reported here (#265) - needs a full solution later but this will help a lot in the meantime


Update index.php

Fixed player API

?

It was to fix the player API, but you fixed it before me.


docs: update contribution guide to mention DCO

(see commit message)

Read the changes in context: https://deploy-preview-224--cue.netlify.app/docs/contribution_guidelines/


Update developers.list

Hi @rebeccasf
Welcome! Would you like to provide a simple description about the open source projects you are working on? and (perhaps) what resources are needed for RISC-V CI?

Hi, I am working on porting chromium browser for risc-v

@lazyparser i have uploaded my SSH pub key in my profile. Please check. Thanks again.


Allow txn relay while in needs block state

#1338  👈
feature/proof-of-stake

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @lazynina and the rest of your teammates on  Graphite


iframes vs. instanced p5 in learn page examples

While writing some webgl examples for the Learn page I've noticed that some of the embedded sketches are using iframes instead of instance mode. Is there a reason to stick to iframes as a convention? Or would instance mode be preferable? I think that instance mode would make some of these pages easier to build and maintain.

Using iframes means that multiple sketches using global mode can be running on the same page at the same time. While instance mode is designed to do the same, the syntax of global mode is simpler than instance mode and is probably what most beginners are taught to use when starting out, so for tutorials it's probably preferred to use global mode (which means we don't have much alternatives besides iframes).


Generator should specify which file causes an error

Running mix thrift.generate with a directory that has a bunch of thrift files in it, I get this error:
** (MatchError) no match of right hand side value: {:error, {32, :thrift_parser, ['syntax error before: ', '\']\'']}}
    lib/thrift/parser.ex:19: Thrift.Parser.parse/1
    lib/thrift/parser/parsed_file.ex:13: Thrift.Parser.ParsedFile.new/1
    lib/thrift/parser.ex:57: Thrift.Parser.parse_file/1
    lib/thrift/generator.ex:11: Thrift.Generator.generate!/2
    lib/mix/tasks/thrift.generate.ex:32: anonymous fn/3 in Mix.Tasks.Thrift.Generate.run/1
    (elixir) lib/enum.ex:1623: Enum."-reduce/3-lists^foldl/2-0-"/3
    lib/mix/tasks/thrift.generate.ex:31: Mix.Tasks.Thrift.Generate.run/1
    (mix) lib/mix/task.ex:296: Mix.Task.run_task/3

I don't think any of my files have thrift syntax errors, which is another issue that I'll try to track down, but this doesn't tell me which file is causing the error.

Closed by #128


backgroundRefresh on nil jwks

Upon implementing and testing this package I noticed that if the initial call to (*JWKS).refresh() fails nil is returned as the *jwks.
	err = jwks.refresh() 	if err != nil { 		return nil, err 	}
As a consequence of this no further refreshing is done. Would it be possible to implement some functionality to allow a backgroundRefresh to be done even if the initial call to request gives an error? Hope my question is clear enough.

The .refresh method is not exported to package users. Perhaps you mean keyfunc.Get?
If that's what was meant, it may be possible that the error from this portion is not nil. In this case, the error needs to be checked and handled by the package user.
https://github.com/MicahParks/keyfunc/blob/master/get.go#L45-L48
It's possible I missed something, but I'd likely need more details. Are you able to write a complete example that reproduces the behavior you've found to be unexpected?

Yes, I did mean keyfunc.Get().
And yes, exactly those lines, if the error is not nil it means that the jwksvariable will be nil. Say for instance that the request times out on reboot, but one would like the keyfunc package to keep refreshing and trying the endpoint no matter. I can live with that this is something that should be handled by the package user, but was merely wondering if it would be a wanted feature to add this functionality in the package.
Small example to demonstrate:
func main() {
	jwks, err := keyfunc.Get(jwksEndpointURL, keyfunc.Options{
		RefreshInterval: time.Minute,
	})
	if err != nil {
		// simply warn that we had a problem, rather than closing
		log.Warnf("error retrieving keys, %v", err)
	}

	// further down in program, we might get a request to process a token
	if jwks == nil {
		// deny request, we dont have keys
	} else {
		// process token
	}

	// next time get a request, jwks might have been refreshed and we can process
}```

My point is that if the refresh were allowed still, even though we had an error first time, it might be a nice feature rather than having to implement retry logic by your self. Hope I made myself clearer.

From my perspective, it appears all the behavior is expected.

might be a nice feature rather than having to implement retry logic by your self

Currently, there is no automatic retry feature in keyfunc. Without any changes to the keyfunc package, I would recommend not proceeding with nil *keyfunc.JWKS and handling the error via retries in the calling code by blocking.
I'm not sure if an automatic retry feature in the keyfunc package is a feature I'd like to add. An automatic retry feature that asynchronously (non-blocking) retrieves the JWK Set may cause a different class of more complex unexpected behavior, a JWT might be not validated by the application at one moment, but the same JWT validated at a later time. There is a way to include automatic retries that would block via a function, but at this time, I think that's best left up to the package user.
I would recommend designing applications to gather all required connections (like databases/keyfunc) and assets in a blocking manner before allowing the application to proceed and failing to start the business logic if there is an error unsolved by retries. In my experience, it helps reduce complexities and the variety of errors. For keyfunc, there's the extra note that it can reuse an old JWK Set it has from last time if a non-critical refresh fails. Unfortunately, if a critical refresh fails in keyfunc, it needs to be handled asynchronously through RefreshErrorHandler in keyfunc.Options

I understand your reasoning and thank you for the quick response.

Hi, first of all: thanks for this great repository!
I have a similar issue, but with the GetMultiple method instead of the Get method:
When using keyfunc.GetMultiple to retrieve JWKs from multiple URLs with a configuration to refresh those keys, then during runtime some of the URLs might have a downtime and when they are up again all will self-heal after a background refresh - and that's neat!
But what if one of many URLs isn't accesible at startup, due to let's say maintenance? In that case blocking and waiting for all URLs to be ready like in @suntriber s use case might not be necessary, because the service could still handle most requests. Can we have the keyfunc.GetMultiple function still load from all working URLs and have the rest loaded later via background refresh?
So far I couldn't find a way to achieve this from outside the library without reimplementing large parts of it. But adding a new parameter to the keyfunc.Options could solve this in a much simpler way.
What's your opinion on that? Is my use-case too niche, or would others also like to have that?

@ErenDursun, that is pretty niche. However, that may be easy to support through keyfunc.Options. Why don't you create a separate issue requesting this and I'll see if I can implement it after work?

@suntriber I think the newly added feature supports your initial use case. See #90 and the associated pull request for more details. It's possible I didn't full understand the issue on the first go around or didn't see the value until the keyfunc project supported multiple JWK Sets natively.

Hi,
Yes this newly added feature does indeed support my use case. I did however implement a work around but next refactoring I'll certainly consider using this instead as it would remove some complexity from our code base.
Thanks for the tag and kudos for a great lib!


Level 13 display issue with new push.

Bug description
Map at zoom level 13 is showing all data normally visually at level 13 as if the there is no time set on the slider.
The slider should show data from the time period.
at Zoom level 14 it all pops back to the way it should be working.
If this is a client side issue let me know.

The boundary data looks to be working but the roads and railways are still having problems.

My first thought was that perhaps we accidentally dropped dates off the tiles at <=z13 but that seems not to be the case:

We can also rule out any weirdness with the OHM.org web code itself, since we see the same issue on our standalonge MGBL timeslider demo:
https://openhistoricalmap.github.io/mbgl-timeslider/demo/#13.293/40.73001/-73.84360/1850,-4000-2020

But the problem is not related to our most recent changes on the timeslider, since this bug is also present even when we run the timeslider without the play button changes we made last week:

We'll look closer at this and see if there's some subtler difference in these tiles that is making <=z13 non-boundary elements fail in the timeslider filters.

Just to zero in, here's a feature at z12 (vtiles) which is z13 Leaflet, and this is the freeway on the east side of above GIFs that is present at <=z13 but absent when >13

It sure looks like the start_date is present and accounted for

And here's an example of the Border that is working:
https://recordit.co/s6UK51w7c5

Hmm, I notice that the border that is working includes a full yyyy-mm-dd date while the one that fails is just yyyy. I wonder if our pad_date functions are failing at lower zoom tiles for some reason. One test for that would be to find something that's not a border with a yyyy data and see if it is also ignored.

@gregallensworth can you take a look at this and see if you can divine why the tiles aren't filtering at <=z13? Lots of notes above. I suspect it's going to be a tile issue, but for the life of me I can't see what the cause is

Now we have #237, where an amenity area is not filtering as expected despite having a start and end date, but that's regardless of zoom level. Maybe not related, but this feels related. And since I confirmed the bug in this issue in the MBGL timeslider demo using a previoulsy known-working slider (pre animation) , I feel like it's gotta be something about the tile changes we made, but I'll be darned if I can see what might be causing that

OK, getting somewhere in debugging this. I opened a PBF with known missing layers and compared the ones that work and the ones that don't -- the ones that don't work are lacking osm_id:

And we have code specifically that ignores anything without an osm_id, which was part of our initial reliance on Natural Earth for coastlines:
https://github.com/OpenHistoricalMap/mbgl-timeslider/blob/15b8296aacfcbd45fb03cfffef9a793ace9ee870/mbgl-control-timeslider-control.js#L386-L387
Now, either we got rid of NE reliance fully and we can omit that code or we still rely on NE some and we need to get osm_id back into the tiles.

And just to close the loop here that osm_id is the source of the bug, here's transport_lines from two zooms, one that works (has osm_id) and one that doesn't:

I agree with Dan's diagnosis. See #237 which is this same issue: features lacking a osm_id always pass any time filter, as they are considered eternal. In #237 is discussion and a PR about omitting that filtering clause.

This is now working as expected as shown here https://recordit.co/cGUCNuxe8E


Disclaimer in the README for object literal methodology

What would you like to be added:
Add a warning in (or completly remove?) the object literals section about validation and default values.
Why is this needed:
if the developper using the SDK decides to go with the object literals approach, he might face valid objects that don't define default/const values enforced by builders (e.g. #104)

+1  my preference is to remove it completely


Why not just do a PR into SemiseparableMatrices.jl?

Somehow I missed the issue.
The reason we kept it separate is because the implementation is kind of specialized for faster factorization with a somewhat strange handling for the "almost" part if you look at the code (or the finish_part_setindex! function).


Implement EJson.

And insert it between Data and Bson.
It is its own subproject, which meant pulling out things like
quasar.fp into a subproject.

What's the utility of pulling ejson out of core? Right now you have core -> ejson -> foundation with no other incoming dependencies, so it's not accomplishing anything yet. What will depend on either ejson or foundation in the future?

And the real motivation here is to Functor-ize the "data" type so that we can embed other things in it and use it as part of the AST Coproduct?
I wonder if the values that don't fit cleanly into EJson can be captured using that mechanism. Will there be other values like that, or is OID a one-off?
Alternatively, why not just have OID as a first-class value in EJson?

In the short-term (like, next couple weeks) backend and will depend on ejson, but we’ll still have core -> backend -> ejson -> foundation, so ejson could be folded into backend until the point when we pull frontend out, which will also need to depend on ejson (but that’s not short-term).

The goal isn’t so much functorization as it is to use the EJson spec, and we don’t want to write another non-functored data type.
So, the problem with OID is it’s necessarily backend-specific, so it’s not part of the EJson spec. In a query, we can just treat OID("...") as a function, but when loading data or returning results, we need to include it somehow. In theory, each backend could do whatever it wants – { "$oid": "132434AF123C" } for Mongo, { "hadoopId":<PHONE_NUMBER>1239848 } for Hadoop, etc. To some extent, it’s no different than if the Mongo backend wanted to be able to return regexes, or some other backend-specific type – other than OIDs tend to show up a lot more often.
We could add a final case class Oid(...) and use Const[Oid, ?] :+: EJson in places, which at least allows us to include OIDs in the precise/readable formats, but it’s still not part of EJson.
My personal stance is “let the backend sort it out”, but that’s negotiable.

After absorbing the discussion on SD-990, I wonder how you're planning to proceed here. If several of these types are going to go away and become values with with metadata annotations, then I see no reason to single out OID for special encoding in this PR. Either all of them should get pulled out of the EJson type, or OID might as well have its own constructor for the time being. And figuring out the spec for metadata seems like a big deal to hold up this PR for. So is there value in getting this merged even if it looks more like Data than the way we want EJson to end up?

I’m currently converting it all to metadata. I don’t think it’s worth pushing out an EJson that is so unlike what we want it to be. Granted, there are still things to sort out in the SD-990 discussion, but by making the changes, I’m likely to see exactly what those things are.
So, this PR might close if it drags on, but I’ll keep it in progress for now.

ok, this is back in review.

Have we documented the representation for the extension types, especially dates and intervals? Because for one thing it needs to be documented somewhere, and for another, it's hard for me to figure it out from this implementation.
It seems like at the moment we have no typed representation for these within EJson, but only in Data. If Data eventually goes away, will we have no precise way of representing these values? Or maybe I'm misunderstanding the current thinking.

It’s not documented yet – parts of it are in the comments of SD-990, but it’s not all in one place. And there are still questions to answer, like do we want to support multiple formats (e.g., both y-m-d and y-doy for date).
But there is a precise representation in EJson. The type is stored in the metadata, in a field named _ejson.type (_ejson. being a prefix reserved by the spec to allow for extension in future versions without stomping on fields and values used by others). So, a value of
{ "year": 1983, "month": 3, "day_of_month": 15 } @ { "_ejson.type": "_ejson.date" }

is typed as a Date. Although, as John mentions in the ticket, that should eventually be handled by a pattern alias.
The fields for Time are hour, minute, second, and nanosecond; and the fields for Timestamp combine the fields for dates and times. Interval has the fields years, months, days, hours, minutes, seconds.
Similarly, backends can take advantage of the type field as well:
"2933AF83452B" @ { "_ejson.type": "_bson.oid" }

This all needs to go into an ejson-spec repo, in a separate org (https://github.com/ejson). And this implementation should be extracted into a library there, when time permits.

@mossprescott / @wemrysi: I think I responded to everything, and pushed fixes.

Still skeptical about adding/subtracting with Date and Interval, but I suppose it could be defined precisely. If it's going to be unimplemented for the time being then I guess it can stay.
Any thoughts on my question about strongly-typed values in the absence of Data?

It seems like at the moment we have no typed representation for these within EJson, but only in Data. If Data eventually goes away, will we have no precise way of representing these values? Or maybe I'm misunderstanding the current thinking.

Do I need to explain what I mean better?

I think you do, because I thought I answered it.

Just pushed a few of the changes – didn’t change the representation of binary yet.

Ok, more changes. I think this covers everything mentioned so far, except to discuss @mossprescott’s question re: strongly-typed values.

Had one last comment, but other than that LGTM, :+1:

Ok, made a final(?) change to store the binary data size in the metadata.

Need to change the test to not expect padded binary data, right?

I made that change in an earlier commit (https://github.com/quasar-analytics/quasar/pull/1199/commits/6f687b47b2ab716493a7b23752ac2aabfc76bbc9#diff-6d8ce8b92326f87e2a63ee0cbf488fe6L60 – when I first added the size component). Unless I missed one somewhere else …

:+1:

[Current coverage][cc-pull] is 79.26%

Merging [#1199][cc-pull] into [master][cc-base-branch] will increase coverage by 0.20%

@@             master      #1199   diff @@
==========================================
  Files           169        172     +3
  Lines          9844      10075   +231
  Methods        9571       9852   +281
  Messages          0          0
  Branches        111         97    -14
==========================================
+ Hits           7783       7986   +203
- Misses         2061       2089    +28
  Partials          0          0

Powered by Codecov. Last updated by [1ff9cb9...f84805f][cc-compare]
[cc-base-branch]: https://codecov.io/gh/quasar-analytics/quasar/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/quasar-analytics/quasar/compare/1ff9cb970a0db92716b0d902f4bfd9f6622f0af5...f84805f3348846f2ea22b5b270830840a5e9abfc
[cc-pull]: https://codecov.io/gh/quasar-analytics/quasar/pull/1199?src=pr


dataset download

hello， thanks for you work. can you upload dataset to google drive or baidu yun pan? it's hard to download data from huggingface.

Hi! Uploading all the data again is a little bit demanding. You may download our dataset by using git lfs on huggingface. Did you meet any problem when download it? Maybe we can help you with it.

我在hf-mirror 使用hfd工具下载，一张张图片下载，下载过程非常容易中断，已经下载一天了，才下载了一点点，能不能直接使用上次数据集的压缩包啊

@dswahu 那请稍等哈，我们准备一下

Hi! Uploading all the data again is a little bit demanding. You may download our dataset by using git lfs on huggingface. Did you meet any problem when download it? Maybe we can help you with it.

我可以使用git lfs下载数据，但是得到的图片内容大小是错误的，我对比了一下size，下载的应该是图像的指针内容

Hi! Uploading all the data again is a little bit demanding. You may download our dataset by using git lfs on huggingface. Did you meet any problem when download it? Maybe we can help you with it.

我可以使用git lfs下载数据，但是得到的图片内容大小是错误的，我对比了一下size，下载的应该是图像的指针内容

是的，这样下载后还需要pull一次，具体你要搜下hf的下载教程

@egbertYeah @dswahu https://drive.google.com/file/d/1Jgy4-68F8Xj16tNHzgBoDwRlsKvm92Sf/view?usp=sharing
这个是压缩包google drive链接

@egbertYeah @dswahu https://drive.google.com/file/d/1Jgy4-68F8Xj16tNHzgBoDwRlsKvm92Sf/view?usp=sharing
这个是压缩包google drive链接

谢谢

@egbertYeah @dswahu https://drive.google.com/file/d/1Jgy4-68F8Xj16tNHzgBoDwRlsKvm92Sf/view?usp=sharing
这个是压缩包google drive链接

谢谢

不客气


Update deploy-clients-cmg-azure.md

Summarize the change in the pull request title
Describe your change, specifically why you think it's needed.
Fixes #Issue_Number (if necessary)

@RobYork : Thanks for your contribution! The author, @aczechowski, has been notified to review your proposed change.

Good add, thanks @RobYork.
#sign-off
No further action needed from you.


openroad build fails

  07:58:36 | /root/conda-eda/conda-eda/workdir/conda-env/conda-bld/openroad_1687851890260/work/src/gui/src/search.h:264:10: error: 'mutex' in namespace 'std' does not name a type
  07:58:36 |   264 |     std::mutex shapes_init_mutex_;
  07:58:36 |       |          ^~~~~
  07:58:36 | /root/conda-eda/conda-eda/workdir/conda-env/conda-bld/openroad_1687851890260/work/src/gui/src/search.h:41:1: note: 'std::mutex' is defined in header '<mutex>'; did you forget to '#include <mutex>'?
  07:58:36 |    40 | #include "odb/dbBlockCallBackObj.h"
  07:58:36 |   +++ |+#include <mutex>
  07:58:36 |    41 | #include "odb/geom.h"
  07:58:36 | /root/conda-eda/conda-eda/workdir/conda-env/conda-bld/openroad_1687851890260/work/src/gui/src/search.h:267:10: error: 'mutex' in namespace 'std' does not name a type
  07:58:36 |   267 |     std::mutex fills_init_mutex_;
  07:58:36 |       |          ^~~~~
  07:58:36 | /root/conda-eda/conda-eda/workdir/conda-env/conda-bld/openroad_1687851890260/work/src/gui/src/search.h:267:5: note: 'std::mutex' is defined in header '<mutex>'; did you forget to '#include <mutex>'?
  07:58:36 |   267 |     std::mutex fills_init_mutex_;
  07:58:36 |       |     ^~~
  07:58:36 | /root/conda-eda/conda-eda/workdir/conda-env/conda-bld/openroad_1687851890260/work/src/gui/src/search.h:270:10: error: 'mutex' in namespace 'std' does not name a type
  07:58:36 |   270 |     std::mutex insts_init_mutex_;
  07:58:36 |       |          ^~~~~
  07:58:36 | /root/conda-eda/conda-eda/workdir/conda-env/conda-bld/openroad_1687851890260/work/src/gui/src/search.h:270:5: note: 'std::mutex' is defined in header '<mutex>'; did you forget to '#include <mutex>'?
  07:58:36 |   270 |     std::mutex insts_init_mutex_;
  07:58:36 |       |     ^~~
  07:58:36 | /root/conda-eda/conda-eda/workdir/conda-env/conda-bld/openroad_1687851890260/work/src/gui/src/search.h:273:10: error: 'mutex' in namespace 'std' does not name a type
  07:58:36 |   273 |     std::mutex blockages_init_mutex_;
  07:58:36 |       |          ^~~~~
  07:58:36 | /root/conda-eda/conda-eda/workdir/conda-env/conda-bld/openroad_1687851890260/work/src/gui/src/search.h:273:5: note: 'std::mutex' is defined in header '<mutex>'; did you forget to '#include <mutex>'?
  07:58:36 |   273 |     std::mutex blockages_init_mutex_;
  07:58:36 |       |     ^~~
  07:58:36 | /root/conda-eda/conda-eda/workdir/conda-env/conda-bld/openroad_1687851890260/work/src/gui/src/search.h:276:10: error: 'mutex' in namespace 'std' does not name a type
  07:58:36 |   276 |     std::mutex obstructions_init_mutex_;
  07:58:36 |       |          ^~~~~
  07:58:36 | /root/conda-eda/conda-eda/workdir/conda-env/conda-bld/openroad_1687851890260/work/src/gui/src/search.h:276:5: note: 'std::mutex' is defined in header '<mutex>'; did you forget to '#include <mutex>'?
  07:58:36 |   276 |     std::mutex obstructions_init_mutex_;
  07:58:36 |       |     ^~~
  07:58:36 | /root/conda-eda/conda-eda/workdir/conda-env/conda-bld/openroad_1687851890260/work/src/gui/src/search.h:279:10: error: 'mutex' in namespace 'std' does not name a type
  07:58:36 |   279 |     std::mutex rows_init_mutex_;
  07:58:36 |       |          ^~~~~
  07:58:36 |   310 |   std::lock_guard<std::mutex> lock(data.insts_init_mutex_);
  07:58:36 |       |                                         ^~~~~~~~~~~~~~~~~
  07:58:36 |       |                                         insts_init_
  07:58:36 | /root/conda-eda/conda-eda/workdir/conda-env/conda-bld/openroad_1687851890260/work/src/gui/src/search.cpp:310:31: error: 'lock' was not declared in this scope; did you mean 'lockf'?
  07:58:36 |   310 |   std::lock_guard<std::mutex> lock(data.insts_init_mutex_);
  07:58:36 |       |                               ^~~~
  07:58:36 |       |                               lockf
  07:58:36 | /root/conda-eda/conda-eda/workdir/conda-env/conda-bld/openroad_1687851890260/work/src/gui/src/search.cpp: In member function 'void gui::Search::updateBlockages(odb::dbBlock*)':
  07:58:36 | /root/conda-eda/conda-eda/workdir/conda-env/conda-bld/openroad_1687851890260/work/src/gui/src/search.cpp:329:8: error: 'lock_guard' is not a member of 'std'
  07:58:36 |   329 |   std::lock_guard<std::mutex> lock(data.blockages_init_mutex_);
  07:58:36 |       |        ^~~~~~~~~~
  07:58:36 | /root/conda-eda/conda-eda/workdir/conda-env/conda-bld/openroad_1687851890260/work/src/gui/src/search.cpp:329:8: note: 'std::lock_guard' is defined in header '<mutex>'; did you forget to '#include <mutex>'?
  07:58:36 | /root/conda-eda/conda-eda/workdir/conda-env/conda-bld/openroad_1687851890260/work/src/gui/src/search.cpp:329:24: error: 'mutex' is not a member of 'std'
  07:58:36 |   329 |   std::lock_guard<std::mutex> lock(data.blockages_init_mutex_);
  07:58:36 |       |                        ^~~~~
  07:58:36 | /root/conda-eda/conda-eda/workdir/conda-env/conda-bld/openroad_1687851890260/work/src/gui/src/search.cpp:329:24: note: 'std::mutex' is defined in header '<mutex>'; did you forget to '#include <mutex>'?
  07:58:36 | /root/conda-eda/conda-eda/workdir/conda-env/conda-bld/openroad_1687851890260/work/src/gui/src/search.cpp:329:41: error: 'struct gui::Search::BlockData' has no member named 'blockages_init_mutex_'; did you mean 'blockages_init_'?
  07:58:36 |   329 |   std::lock_guard<std::mutex> lock(data.blockages_init_mutex_);
  07:58:36 |       |                                         ^~~~~~~~~~~~~~~~~~~~~
  07:58:36 |       |                                         blockages_init_
  07:58:36 | /root/conda-eda/conda-eda/workdir/conda-env/conda-bld/openroad_1687851890260/work/src/gui/src/search.cpp:329:31: error: 'lock' was not declared in this scope; did you mean 'lockf'?
  07:58:36 |   329 |   std::lock_guard<std::mutex> lock(data.blockages_init_mutex_);
  07:58:36 |       |                               ^~~~
  07:58:36 |       |                               lockf
  07:58:36 | /root/conda-eda/conda-eda/workdir/conda-env/conda-bld/openroad_1687851890260/work/src/gui/src/search.cpp: In member function 'void gui::Search::updateObstructions(odb::dbBlock*)':
  07:58:36 | /root/conda-eda/conda-eda/workdir/conda-env/conda-bld/openroad_1687851890260/work/src/gui/src/search.cpp:346:8: error: 'lock_guard' is not a member of 'std'
  07:58:36 |   346 |   std::lock_guard<std::mutex> lock(data.obstructions_init_mutex_);
  07:58:36 |       |        ^~~~~~~~~~
  07:58:36 | /root/conda-eda/conda-eda/workdir/conda-env/conda-bld/openroad_1687851890260/work/src/gui/src/search.cpp:346:8: note: 'std::lock_guard' is defined in header '<mutex>'; did you forget to '#include <mutex>'?
  07:58:36 | /root/conda-eda/conda-eda/workdir/conda-env/conda-bld/openroad_1687851890260/work/src/gui/src/search.cpp:346:24: error: 'mutex' is not a member of 'std'
  07:58:36 |   346 |   std::lock_guard<std::mutex> lock(data.obstructions_init_mutex_);
  07:58:36 |       |                        ^~~~~
  07:58:36 | /root/conda-eda/conda-eda/workdir/conda-env/conda-bld/openroad_1687851890260/work/src/gui/src/search.cpp:346:24: note: 'std::mutex' is defined in header '<mutex>'; did you forget to '#include <mutex>'?
  07:58:36 | /root/conda-eda/conda-eda/workdir/conda-env/conda-bld/openroad_1687851890260/work/src/gui/src/search.cpp:346:41: error: 'struct gui::Search::BlockData' has no member named 'obstructions_init_mutex_'; did you mean 'obstructions_init_'?
  07:58:36 |   346 |   std::lock_guard<std::mutex> lock(data.obstructions_init_mutex_);
  07:58:36 |       |                                         ^~~~~~~~~~~~~~~~~~~~~~~~
  07:58:36 |       |                                         obstructions_init_
  07:58:36 | /root/conda-eda/conda-eda/workdir/conda-env/conda-bld/openroad_1687851890260/work/src/gui/src/search.cpp:346:31: error: 'lock' was not declared in this scope; did you mean 'lockf'?
  07:58:36 |   346 |   std::lock_guard<std::mutex> lock(data.obstructions_init_mutex_);
  07:58:36 |       |                               ^~~~
  07:58:36 |       |                               lockf
  07:58:36 | /root/conda-eda/conda-eda/workdir/conda-env/conda-bld/openroad_1687851890260/work/src/gui/src/search.cpp: In member function 'void gui::Search::updateRows(odb::dbBlock*)':
  07:58:36 | /root/conda-eda/conda-eda/workdir/conda-env/conda-bld/openroad_1687851890260/work/src/gui/src/search.cpp:363:8: error: 'lock_guard' is not a member of 'std'
  07:58:36 |   363 |   std::lock_guard<std::mutex> lock(data.rows_init_mutex_);
  07:58:36 |       |        ^~~~~~~~~~
  07:58:36 | /root/conda-eda/conda-eda/workdir/conda-env/conda-bld/openroad_1687851890260/work/src/gui/src/search.cpp:363:8: note: 'std::lock_guard' is defined in header '<mutex>'; did you forget to '#include <mutex>'?
  07:58:36 | /root/conda-eda/conda-eda/workdir/conda-env/conda-bld/openroad_1687851890260/work/src/gui/src/search.cpp:363:24: error: 'mutex' is not a member of 'std'
  07:58:36 |   363 |   std::lock_guard<std::mutex> lock(data.rows_init_mutex_);
  07:58:36 |       |                        ^~~~~
  07:58:36 | /root/conda-eda/conda-eda/workdir/conda-env/conda-bld/openroad_1687851890260/work/src/gui/src/search.cpp:363:24: note: 'std::mutex' is defined in header '<mutex>'; did you forget to '#include <mutex>'?
  07:58:36 | /root/conda-eda/conda-eda/workdir/conda-env/conda-bld/openroad_1687851890260/work/src/gui/src/search.cpp:363:41: error: 'struct gui::Search::BlockData' has no member named 'rows_init_mutex_'; did you mean 'rows_init_'?
  07:58:36 |   363 |   std::lock_guard<std::mutex> lock(data.rows_init_mutex_);
  07:58:36 |       |                                         ^~~~~~~~~~~~~~~~
  07:58:36 |       |                                         rows_init_
  07:58:36 | /root/conda-eda/conda-eda/workdir/conda-env/conda-bld/openroad_1687851890260/work/src/gui/src/search.cpp:363:31: error: 'lock' was not declared in this scope; did you mean 'lockf'?
  07:58:36 |   363 |   std::lock_guard<std::mutex> lock(data.rows_init_mutex_);
  07:58:36 |       |                               ^~~~
  07:58:36 |       |                               lockf
  07:58:40 | make[2]: *** [src/gui/CMakeFiles/gui.dir/build.make:288: src/gui/CMakeFiles/gui.dir/src/search.cpp.o] Error 1

looks like https://github.com/The-OpenROAD-Project/OpenROAD/pull/3370 missed one of the necessary includes.

dropping this, since this is merged upstream.


Bug: broken links on download page

The download page
https://openwhisk.apache.org/downloads.html
contains links to Cloudant package, however they are all broken.
Please fix the links or remove them.

We haven't released a post-incubation version of openwhisk-package-cloudant.  It looks like someone was overly eager in removing the incubating subdirectory from our dist svn.  There's been some recent discussion on whether we can revive this package or not.  I'll assign this to me to keep track of the issue.  The resolution will be either to make a 2.1.0 release of the package or to remove it from the downloads page.


Have to check array with longer suffixes first.

https://github.com/NaturalNode/natural/blob/8071055f103f2d9fead395c5b823e0b247fb13a7/lib/natural/stemmers/porter_stemmer_es.js#L196
You have to check first the upper array and then this one: Array('en', 'es', 'éis', 'emos')

Sorry but this is not an improvement. It is a bad implementation of the original algorithm.

Yes, that is exactly what I mean by labelling it with improvement. The current implementation requires improvement.
Hugo

So, if I exchange the two arrays that are being tested, then it works as expected for Spanish? I am checking because I don't know what I am doing (in Spanish) if I make the change.
Hugo

I saw that there is no unit test for the Porter stemmer for Spanish. I wrote a quick test following the Italian test. Applied it to the Snowball vocabulary and it gives more than 2476 errors (of the 28390 entries). See the log.
Anyone knows what is going on? Is the stemmer for Spanish not finished?
Hugo

The Porter stemmer for Spanish has three issues I already pointed out. That's why it is giving so many errors.
I implemented it properly here:
https://github.com/dmarman/lorca/blob/master/src/stemmer.js
to solve this issue the code should look like something like this:
if (wordAfter2a == wordAfter1) {
                if((suf = this.endsInArr(rvText, ['arían', 'arías', 'arán', 'arás', 'aríais', 'aría', 'aréis',
                                                    'aríamos', 'aremos', 'ará', 'aré', 'erían', 'erías', 'erán',
                                                    'erás', 'eríais', 'ería', 'eréis', 'eríamos', 'eremos', 'erá',
                                                    'eré', 'irían', 'irías', 'irán', 'irás', 'iríais', 'iría', 'iréis',
                                                    'iríamos', 'iremos', 'irá', 'iré', 'aba', 'ada', 'ida', 'ía', 'ara',
                                                    'iera', 'ad', 'ed', 'id', 'ase', 'iese', 'aste', 'iste', 'an',
                                                    'aban', 'ían', 'aran', 'ieran', 'asen', 'iesen', 'aron', 'ieron',
                                                    'ado', 'ido', 'ando', 'iendo', 'ió', 'ar', 'er', 'ir', 'as', 'abas',
                                                    'adas', 'idas', 'ías', 'aras', 'ieras', 'ases', 'ieses', 'ís', 'áis',
                                                    'abais', 'íais', 'arais', 'ierais', '  aseis', 'ieseis', 'asteis',
                                                    'isteis', 'ados', 'idos', 'amos', 'ábamos', 'íamos', 'imos', 'áramos',
                                                    'iéramos', 'iésemos', 'ásemos'])) != '')
                {
                    word = word.slice(0, -suf.length);
                }else if((suf = this.endsInArr(rvText, ['en', 'es', 'éis', 'emos'])) != '') {
					word = word.slice(0, -suf.length);
                    if(this.endsIn(word, 'gu')){
                        word = word.slice(0, -1);
					}
				}
            }

Sorry that I don't do it myself, I just don't have the time now...

Ok, thanks for the guidance, I will check it out and make a PR later this weekend.
Hugo

Did the test against the snowball vocabulary, and it almost works...One error remains:

vocabulary is wrong, you cannot have a word with two accents.
Although I don't know why it is replacing properly the first one from méxico, but not the second one from querétar..
did you got any other error?
Domingo

No, that's the only error left.
Hugo

I would then check why querétar is left with the accent... The regex for that looks good for me.
I implemented in the function in a different way though:
removeAccent(word)
    {
        var accentedVowels = ['á', 'é', 'í', 'ó', 'ú'];
        var vowels = ['a', 'e', 'i', 'o', 'u'];

        for(var i in accentedVowels){
            word = word.replace(accentedVowels[i], vowels[i]);
        }

        return word;
    }

Sorry, I didn't state that explicitly, but I'm already using your implementation that you posted in the other issue #400:
https://github.com/dmarman/lorca/blob/master/src/stemmer.js
and that leaves us with this one error.
Hugo

Ok :) Remove it from the list. It's a wierd word and bad formed.

I committed the new stemmer to the repo including a unit test with test data: commit
Thanks for your input!
Hugo

Nice Job! 🎉
If you want, you can add to this repro this syllaber I did for Spanish:
https://github.com/dmarman/lorca/blob/master/src/syllabler.js
and this sentiment analysis:
https://github.com/dmarman/lorca/blob/master/src/sentimenter.js
This one needs some improvement, but it kinda works...

I think sentiment analysis would be a great addition to the library. We already had a request for such functionality. See here. Did you use an existing algorithm for this? And can we generalize this to other languages in a straightforward way? If it can be used as a framework for other languages, where language files are kept separate that would be great. I see that you are using a number of vocabularies to configure the sentimenter. Could you elaborate a bit on the algorithm? Or do you have some documentation?
Hugo