[Improve] util class naming improvements

[Improve] util class naming improvements
The naming of util classes in the project needs to be more consistent. Most are named xxUtils, while a few are named xxUtil. We should standardize the naming conventions for improved clarity.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

+1

Thank you for your contribution.. LGTM 👍


Peer Review for German

I'm submitting a...

[ ] Bug report.
[x] Feature request.

Feature request
I just finished the translation of german for the most part (98% as some strings, as you probably know, make no sense being translated). If it matters, I am a german native, but I dont tend to pay too much attention to being grammarly correct, but it should be fine.
I am a teacher for a school course that is interested in godot, so I would be really happy to either have this integrated or a clear path into integrating it locally. I've tested the local version. It works, but I am running into small issues, like missing a script parser and the build templates, that might be my mistake, so if you dont mind, please send me to the correct information!
Love the project hope it works out for you guys selling the course!

I realise I put more formal phrases in there. I went through the offending cases again and found a few rough translations that I fixed. The original translation must have had a few auto translations.


Introduce minimal virtual keyboard support

Due to the lack of correct author information I have to close this PR and create a new one


Enable parallel testing

This changes the database configuration to support parallel testing.
Cucumber features were broken up so that the longest running feature
(Forms) won't hold up the whole test suite.
Also includes fixes for the API tests. Since they share class names with
tests for the app controllers, they fail if executed in different
processes because of the way they share includes.
You can run the cucumber tests in parallel by doing
bin/rake parallel:create #creates the extra dbs
bin/rake parallel:prepare

bin/rake parallel:features

This took the cucumber suite from 3m45s down to 1m15s on my Mac Pro (a.k.a. trashcan). You can also execute the plain old test suite in parallel, but I found it actually runs slower that way.

Seems to give me guaranteed capybara-webkit crashes, on Ubuntu. Someone with a mac will have to review this.


A.uniq: hasOwnProperty is not a function

I'm using A.uniq on an array of Tuples. Unfortunately, that results in an exception being thrown:
@mobily/ts-belt/dist/cjs/Array/index.js:446
        if (!b.hasOwnProperty(key)) {
               ^
TypeError: b.hasOwnProperty is not a function

I guess you should be using Object.prototype.hasOwnProperty.call(b, key) instead.

@mmiszy 👋 could you provide a simple code example, please?

Sure: https://runkit.com/embed/c5nesq8njosj

Object.prototype.hasOwnProperty.call(b, key) this did a trick, thanks! fixed and published in v3.4.0 🚀


Wanna see my hot pics?💋💋💋

Hi!😻😻😻 Wanna see my hot pics?💋💋💋 Go to this site and find me here. ❤❤❤ My nick is sexygirl662 👇👇👇
https://tinyurl.com/ulpu2gz

@tivie please mark this as spam


Mixins?

Note sure under which heading it would be applicable, but are you interested in adding https://github.com/SpongePowered/Mixin/ ?
It's a library that helps to write mixins for Java as annotated abstract classes / interfaces. at runtime the code is grafted onto the original classes.

I have deliberately tried to focus on libraries and keep frameworks out, sorry.


ci: Make sure bindings.rs is up-to-date

Recent PRs show that this file is sometimes not updated after generator changes. Make the CI fail to ensure it's always representing the same version of gen in-tree.
I hope extraneous whitespace removal is okay - there's no rusftmt run the CI script itself :grimacing:

I thought the bindings were up-to-date, but Q.E.D.: https://github.com/microsoft/windows-rs/pull/832/checks?check_run_id=2730709154 :)

Perfect illustration. 😄

And now it all passes :tada:


[HPRO-629] Change "General Consent" to "Primary Consent"

Any impact on the CSV exports?

Yes, as we are renaming it in CSV export as well. But, I think sites will be notified ahead regarding this change so it should be fine.


Imageoptim all the things. Increase clickable area on add/delete/fork.

@crodriguez1a Realized after the face that you already used kraken, Still got a few % savings though


Investigate/fix list pagination queries

Open payments API requires { pagination: { first, cursor }} as the query params for GETting lists of incoming & outgoing payments:
https://github.com/interledger/open-payments/blob/02a6d505d79124cce776054df89e28f02c8e5d59/openapi/resource-server.yaml#L321-L326
https://docs.openpayments.guide/reference/list-outgoing-payments
However, it seems like we ignore the root pagination parameter when we parse the pagination query parameters when we are handling those calls in backend:
https://github.com/interledger/rafiki/blob/a0302b390192f001fc4baa6bc55ae8dcfb13143a/packages/backend/src/open_payments/payment_pointer/routes.ts#L50
https://github.com/interledger/rafiki/blob/a0302b390192f001fc4baa6bc55ae8dcfb13143a/packages/backend/src/shared/pagination.ts#L9-L20
We should either:

Update Open Payments API to not have pagination as the root element
Update the backend query param parsing to include pagination

Closed in favour of https://github.com/interledger/open-payments/issues/227


python3Packages.sphinxext-opengraph: 0.9.0 -> 0.9.1

Description of changes
https://github.com/wpilibsuite/sphinxext-opengraph/releases/tag/v0.9.1
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg build python311Packages.sphinxext-opengraph

Result of nixpkgs-review pr 275872 at 4fda1073 run on x86_64-linux 1

6 packages built successfully:

kitty
kitty.kitten
kitty.shell_integration
kitty.terminfo
python310Packages.sphinxext-opengraph
python311Packages.sphinxext-opengraph


Health report , wrong calculation

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
In previous dashboards the Max Range (new) was correct ( S Plaid 21" , new 560Km),
in the actual Version Max range (new) is now 616Km (which is correct for 19")
max range (now) is correct for my car with 21" (540Km) , so the Max range (new) seems wrong

Expected Behavior
Max range (new) seems wrong
Steps To Reproduce
No response
Relevant log output
see screenshot

Screenshots
No response
Additional data
No response
Type of installation
Docker
Version
v1.27.5

@jheredianet is this similar to #3787 resolved in PR #3795 ?

Will be resolved in a future TeslaMate release. Thanks Juan.


Missing temp CTE table on Patch call

I am in the process of migrating from v3 to v5 and come across a change to the Patch support. I'm trying to narrow it down some more now, but the issue appears to be if the Patch filter is a little complex:
        this._db.Patch<User>(u => u.ExternalReferences.References.Any(r => r.Reference ==externalReference))
            .Set(u => u.PhotoUrl, photoUrl);

The above fails with:
````42P01: relation "mt_temp_id_list2cte" does not exist```
The generated SQL look like (as 2x:
update public.mt_doc_user as d
set data = public.mt_transform_patch_doc(data, :p1), mt_last_modified = (now() at time zone 'utc'), mt_version = :p2
where ctid in (select ctid from mt_temp_id_list2CTE);

update public.mt_doc_user as d set primary_email = data ->> 'PrimaryEmail', member_of = CAST(ARRAY(SELECT jsonb_array_elements_text(CAST(data ->> 'MemberOf' as jsonb))) as varchar[]), secondary_emails = CAST(ARRAY(SELECT jsonb_array_elements_text(CAST(data ->> 'SecondaryEmails' as jsonb))) as varchar[])
where ctid in (select ctid from mt_temp_id_list2CTE);

That is the entire statement, where you can see no mt_temp_id_list2CTE is generated

Very, very nasty SQL, but actually not that rough to fix most likely. I'll try to take a look at this today

@jeremydmiller Many thanks. It's not ideal what I'm doing here, granted (I will look at improving :)), but this did indeed use to work in v3.

This one's a little bigger than I feared. And it impacts several other cases like DeleteWhere(). Sorry to do this, but this might get kicked back yet again.

FINALLY.


Display whether packages include libraries, executables, or both.

Package search results should show whether a package consists of library targets, or executable targets and should show how many of each.
More data will be collected about the products (for use in #60) but will not be displayed on the search results.

Done!


Have a container image packaging ansible, tools + k8s-infra (or galaxy collection)

Requirement
Have a container image packaging ansible, tools, some aliases (to create/delete VM, deploy k8s) & k8s-infra (or maybe move it as a galaxy collection. WDYT @jacobdotcosta )
Example
FROM centos:7

ENV LANG en_US.UTF-8
ENV LC_ALL en_US.UTF-8

RUN yum check-update; \
    yum install -y gcc libffi-devel python3 epel-release; \
    yum install -y python3-pip; \
    yum install -y wget; \
    yum clean all

RUN pip3 install --upgrade pip; \
    pip3 install --upgrade virtualenv; \
    python3 -m pip install ansible

Command to be used to build/run it
docker build . -t ansible
docker run -it ansible

I had created this issue to document the contents of the container which I was building. Could you take a look at it?

Deploying on AWX
Successes so far:

Full deploy of VM on OpenStack, with securization
Created shared user to be used on all VM

Current issues are:

Add shared SSH key to custom OS user
k8s installation alignment
Test Hetzner deployment


Publish

Docs Build status updates of commit 65fe01f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

docs/404.md
:white_check_mark:Succeeded

docs/concepts/requirements-for-running-office-add-ins.md
:white_check_mark:Succeeded
View

docs/develop/create-sso-office-add-ins-aspnet.md
:white_check_mark:Succeeded
View

docs/excel/make-custom-functions-compatible-with-xll-udf.md
:white_check_mark:Succeeded
View

docs/outlook/append-on-send.md
:white_check_mark:Succeeded
View

docs/outlook/limits-for-activation-and-javascript-api-for-outlook-add-ins.md
:white_check_mark:Succeeded
View

docs/outlook/outlook-on-send-addins.md
:white_check_mark:Succeeded
View

docs/powerpoint/get-the-whole-document-from-an-add-in-for-powerpoint.md
:white_check_mark:Succeeded
View

docs/reference/manifest/customfunctionssourcelocation.md
:white_check_mark:Succeeded
View

docs/reference/manifest/defaultsettings.md
:white_check_mark:Succeeded
View

docs/reference/manifest/dictionary.md
:white_check_mark:Succeeded
View

docs/reference/manifest/extensionpoint.md
:white_check_mark:Succeeded
View

docs/reference/manifest/highresolutioniconurl.md
:white_check_mark:Succeeded
View

docs/reference/manifest/iconurl.md
:white_check_mark:Succeeded
View

docs/reference/manifest/method.md
:white_check_mark:Succeeded
View

docs/reference/manifest/mobileformfactor.md
:white_check_mark:Succeeded
View

docs/reference/manifest/officeapp.md
:white_check_mark:Succeeded
View

docs/reference/manifest/officemenu.md
:white_check_mark:Succeeded
View

docs/reference/manifest/officetab.md
:white_check_mark:Succeeded
View

docs/reference/manifest/override.md
:white_check_mark:Succeeded
View

docs/reference/manifest/requirements.md
:white_check_mark:Succeeded
View

docs/reference/manifest/resources.md
:white_check_mark:Succeeded
View

docs/reference/manifest/rule.md
:white_check_mark:Succeeded
View

docs/reference/manifest/set.md
:white_check_mark:Succeeded
View

docs/reference/manifest/sets.md
:white_check_mark:Succeeded
View

docs/reference/manifest/sourcelocation.md
:white_check_mark:Succeeded
View

docs/reference/manifest/supporturl.md
:white_check_mark:Succeeded
View

docs/reference/objectmodel/preview-requirement-set/office.context.mailbox.item.md
:white_check_mark:Succeeded
View

docs/reference/objectmodel/preview-requirement-set/outlook-requirement-set-preview.md
:white_check_mark:Succeeded
View

docs/tutorials/outlook-tutorial.md
:white_check_mark:Succeeded
View

docs/tutorials/share-data-and-events-between-custom-functions-and-the-task-pane-tutorial.md
:white_check_mark:Succeeded
View

docs/word/get-the-whole-document-from-an-add-in-for-word.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Create Palindrome.cpp

Thanks for your contribution but please stick to Contributing Guidelines.
We only accept contributions about STL in C++


az storage fs command crashes when run with AZURE_STORAGE_CONNECTION_STRING env variable

Describe the bug
Command Name
az storage fs access show
Errors:
from_connection_string() missing 1 required positional argument: 'conn_str'
Traceback (most recent call last):
python3.8/site-packages/knack/cli.py, ln 215, in invoke
    cmd_result = self.invocation.execute(args)
cli/core/commands/__init__.py, ln 654, in execute
    raise ex
...
cli/command_modules/storage/_client_factory.py, ln 231, in cf_adls_service
    return t_adls_service.from_connection_string(connection_string=connection_string)
TypeError: from_connection_string() missing 1 required positional argument: 'conn_str'

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
`export AZURE_STORAGE_CONNECTION_STRING=$(az storage account show-connection-string --subscription XXX --name YYY | jq .connectionString)
az storage fs access show -f {} -p {}

Expected Behavior
Environment Summary
macOS-10.15.3-x86_64-i386-64bit
Python 3.8.3
Installer: HOMEBREW

azure-cli 2.8.0

Extensions:
azure-firewall 0.3.0
aks-preview 0.4.52
azure-devops 0.18.0
resource-graph 1.0.0
storage-preview 0.2.10

Additional Context

add to S173

@yonzhan this is not a feature-request but a bug
stacktrace:
from_connection_string() missing 1 required positional argument: 'conn_str'
Traceback (most recent call last):
  File "/usr/local/Cellar/azure-cli/2.8.0/libexec/lib/python3.8/site-packages/knack/cli.py", line 215, in invoke
    cmd_result = self.invocation.execute(args)
  File "/usr/local/Cellar/azure-cli/2.8.0/libexec/lib/python3.8/site-packages/azure/cli/core/commands/__init__.py", line 654, in execute
    raise ex
  File "/usr/local/Cellar/azure-cli/2.8.0/libexec/lib/python3.8/site-packages/azure/cli/core/commands/__init__.py", line 718, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
  File "/usr/local/Cellar/azure-cli/2.8.0/libexec/lib/python3.8/site-packages/azure/cli/core/commands/__init__.py", line 711, in _run_job
    six.reraise(*sys.exc_info())
  File "/usr/local/Cellar/azure-cli/2.8.0/libexec/lib/python3.8/site-packages/six.py", line 703, in reraise
    raise value
  File "/usr/local/Cellar/azure-cli/2.8.0/libexec/lib/python3.8/site-packages/azure/cli/core/commands/__init__.py", line 688, in _run_job
    result = cmd_copy(params)
  File "/usr/local/Cellar/azure-cli/2.8.0/libexec/lib/python3.8/site-packages/azure/cli/core/commands/__init__.py", line 325, in __call__
    return self.handler(*args, **kwargs)
  File "/usr/local/Cellar/azure-cli/2.8.0/libexec/lib/python3.8/site-packages/azure/cli/core/__init__.py", line 536, in default_command_handler
    client = client_factory(cmd.cli_ctx, command_args) if client_factory else None
  File "/usr/local/Cellar/azure-cli/2.8.0/libexec/lib/python3.8/site-packages/azure/cli/command_modules/storage/_client_factory.py", line 246, in cf_adls_directory
    return cf_adls_file_system(cli_ctx, kwargs).get_directory_client(directory=kwargs.pop('directory_path'))
  File "/usr/local/Cellar/azure-cli/2.8.0/libexec/lib/python3.8/site-packages/azure/cli/command_modules/storage/_client_factory.py", line 242, in cf_adls_file_system
    return cf_adls_service(cli_ctx, kwargs).get_file_system_client(file_system=kwargs.pop('file_system_name'))
  File "/usr/local/Cellar/azure-cli/2.8.0/libexec/lib/python3.8/site-packages/azure/cli/command_modules/storage/_client_factory.py", line 231, in cf_adls_service
    return t_adls_service.from_connection_string(connection_string=connection_string)
TypeError: from_connection_string() missing 1 required positional argument: 'conn_str'

thanks for feedback. fixed in https://github.com/Azure/azure-cli/pull/13273. please try with latest azure cli.

I'm having the exact same problem with the latest version:
$ az version
{
  "azure-cli": "2.11.1",
  "azure-cli-core": "2.11.1",
  "azure-cli-telemetry": "1.0.6",
  "extensions": {}
}


Update icalparser.py

Resetting start and end date while walking the calendar. This prevents that some events are missing if there is an all_day-Event in between some events.
Consider the following settings:
startdate: 01.12.2020 00:00:00
enddate: 31.12.2020 23:59:59
Events:
10.12.2020 18:00:00 EventA
22.12.2020 AllDay     EventB
31.12.2020 17:00:00 EventC
While iterating through the calendar, the enddate-settings are reseted during the allday-event to 31.12.2020 00:00:00 and then EventC is missing in the list!

Resetting start and end date while walking the calendar. This prevents that some events are missing if there is an all_day-Event in between some events.
Consider the following settings:
startdate: 01.12.2020 00:00:00
enddate: 31.12.2020 23:59:59
Events:
10.12.2020 18:00:00 EventA
22.12.2020 AllDay EventB
31.12.2020 17:00:00 EventC
While iterating through the calendar, the enddate-settings are reseted during the allday-event to 31.12.2020 00:00:00 and then EventC is missing in the list!

Could you formalise the behaviour you change in a test?

If I understand corectly this is solved here: https://github.com/jazzband/icalevents/pull/136


README typo

README states

This is an early-access version of our Blaze plugins for IntelliJ, Android Studio, and CLion.

Does it mean "Bazel"?

Thanks -- will be fixed in the next code drop.


Increment version for textanalytics releases

Increment version for textanalytics releases

Can one of the admins verify this patch?

We might need to close this PR in favor of https://github.com/Azure/azure-sdk-for-net/pull/13768 ... but leaving it open until I'm sure that is the right path

We might need to close this PR in favor of #13768 ... but leaving it open until I'm sure that is the right path

Yeah, closing


Improve the EventLogIterator interface

The current EventLogIterator interface isn't consistent with ListIterator. The following changes should be implemented :

Removing the has() method completely; and
Introducing previousSeqno, previousSite, previousFrom and previousUntil.

Fixed in #192.


Problem during run example after successfully making source in Linux

While installing Vina-GPU I have found following error (segmentation fault). make source was completed successfully. I did following changes in makefile
WORK_DIR=......./Vina-GPU-2.1-main/AutoDock-Vina-GPU-2.1
BOOST_LIB_PATH=......./boost_1_82_0
OPENCL_LIB_PATH=/usr/local/cuda-12.2
OPENCL_VERSION=-DOPENCL_3_0
GPU_PLATFORM=-DNVIDIA_PLATFORM
While running example I got following error:
Using virtual sreening mode
Output will be in the directory ./test_out
Reading input ... done.
Setting up the scoring function ... done.
Using heuristic search_depth
Analyzing the binding site ... done.
GPU Platform: NVIDIA CUDA
GPU Device: NVIDIA GeForce RTX 3080 Ti
Using random seed: -117560640
Build kernel 1 from source
OpenCL version: 3.0
Build kernel 2 from source
OpenCL version: 3.0
Segmentation fault (core dumped)
Your help is highly appreciated.

The issue resolved by following this thread:
https://github.com/DeltaGroupNJUPT/Vina-GPU-2.1/issues/7#issuecomment-1820152794

Thanks


Instruction on how to get this working with sikuli

It would be great if there's a brief instruction on how to get this working with Sikuli. From my understanding of Sikuli documentation (http://doc.sikuli.org/extensions/extensions_info.html) , we're supposed to put the jar file in Sikuli folder. I can't seem to get your project to compile to jar.

I am also curious about the answer of above-mentioned question, anybody can help me out?

I am interested as well, the sikuli.jar requirement file should be the old one....But i not sure

Hi Guy,
Anyone got ideas with this Sikuli-money working on Android real devices?
Any feedback will be appreciated.
Thanks in advance.
Sincerely,
Jon


Enable SHM as a default transport <1.10.x>

Build status:

Linux
Mac
Windows

Build status:

Linux
Mac
Windows

@MiguelCompany Threre are some valgrind errors in two SHM tests, but those two tests make things like killing processes, so I think is ok.

@MiguelCompany Threre are some valgrind errors in two SHM tests, but those two tests make things like killing processes, so I think is ok.

I have marked this as ready, but will not merge until ROS2 changes to 2.0.x or confirms this change is not harmful for them.

Closing, as we are dropping support for 1.10.x


    let samesies _ = "HUUUH!!"

    let samesies _ = "HUUUH!!"

Suggest reopening this one.

It is open ;P

Doh. Saw the closed above. Sorry.

Fixed in 3.15.2


Update test-and-release.yml - correct branch

Workflow incorrectly used branch 'main' - so noch tests have been performed.
Please merge and check that tests are executed correctly.

storno


NoClassDefFoundError: com/intellij/openapi/actionSystem/DataKeys

Installed the Plugin within PHPStorm 10.0.3 on a mac I get the following error:
NoClassDefFoundError: com/intellij/openapi/actionSystem/DataKeys
when clicking on 'Create Paste' in the context menu.

Hello @Plato2013, what version of the plugin did you install?

Hi,
I've installed it using the plugin browser within the IDE. According to that it is v<IP_ADDRESS>

@Plato2013, thank you! I'll check what's happening

hey @Plato2013 , i found out the problem, fixed and updated to v<IP_ADDRESS>, just check for updates in your IDE and it should tell you there is a new version, and tell me if it's worked for you!
If not appear, maybe need to way sometime, because i had some trouble updating the plugin in JetBrains repository, i think they are having issues and maybe can stop working for maintenance of something.

Just after i wrote to you i saw the really is down for maintanence haha, so after they come back you can update your plugin and it should work fine.
Waiting your feedback :D

@Plato2013, did you try the new version? It solved the problem?

Hello,
I've updated it and now everything seems to work. Thank you for the fast replies and fast fix!


Validate block header in sync_block

The light client is ready by #1. Now we need to enable light validation for every synced block.

Fixed by f03fa369bf74e4e33a23ae4e1e82f53d3a028773


chore(readme): fix path in CSS Preprocessor

current README says
@Component({
  selector: 'app-root',
  templateUrl: 'app.component.html',
  styleUrls: ['app.component.scss']
})

this code causes Module not found: Error: Can't resolve.
I updated README to use ./app.component.html and ./app.component.scss.

LGTM, thanks!

@hansl could you explain why Angular-CLI is now using component-relative URLS? Which change has introduced this requirement?


Running --auto-gen-config breaks .rubocop.yml containg URLs

When running rubocop --auto-gen-config, .rubocop_todo.yml is added to .rubocop.yml as an inherit_from.
Currently, when.rubocop.yml contains existing inherit_from entries with URLs,
the URLs are not removed correctly.

Given the following .rubocop.yml
inherit_from:
  - https://example.com/foo/bar

the modified file should contain
inherit_from:
  - .rubocop_todo.yml
  - https://example.com/foo/bar

Actual behavior
The actual output is as follows:
inherit_from:
  - .rubocop_todo.yml
  - https://example.com/foo/bar

://example.com/foo/bar

with a duplicated remnant of the URL.
Steps to reproduce the problem

Starting from a project with Rubocop, but without .rubocop_todo.yml,
Add the following to .rubocop.yml:

inherit_from:
  - https://gitlab.com/snippets/1867600/raw

Run rubocop --auto-gen-config
The result is

inherit_from:
  - .rubocop_todo.yml
  - https://gitlab.com/snippets/1867600/raw

://gitlab.com/snippets/1867600/raw

RuboCop version
$ rubocop -V
0.71.0 (using Parser <IP_ADDRESS>, running on ruby 2.6.2 x86_64-linux)

This is fixed by #7138


OperationalState: null CurrentPhase should be permitted on both empty and null PhaseList

Per latest revisions to the spec

@robszewczyk What XML changes are needed here?  What spec PR/change is this reflecting?  CurrentPhase and PhaseList are both nullable and have been all along....

Looking at the underlying spec change: no XML changes are needed. There are potentially changes that should be reflected in the implementation of the OperationalState cluster (e.g. examples/all-clusters-app/all-clusters-common/src/operational-state-delegate-impl.cpp), but looking at that implementation: CurrentPhase attribute already appears to be settable via SetPhase, and we don't appear to be doing much checking on the arguments to the Phase.


Unable to return answers from every pdf

Issue with current documentation:
The provided code combines multiple PDF files into one and then extracts a single answer from all of them using Vectordb. But, I'm interested in code that can extract answers separately from each individual PDF file.
import os

os.environ["OPENAI_API_KEY"] = ""

from langchain.vectorstores import Chroma
from langchain.text_splitter import RecursiveCharacterTextSplitter
from langchain.document_loaders.csv_loader import CSVLoader
from langchain.llms import OpenAI
from langchain.chains import RetrievalQA
from langchain.document_loaders import PyPDFLoader
from langchain.document_loaders import DirectoryLoader
import pickle
import faiss
from langchain.vectorstores import FAISS
import textwrap

# InstructorEmbedding
from InstructorEmbedding import INSTRUCTOR
from langchain.embeddings import HuggingFaceInstructEmbeddings

# OpenAI Embedding
from langchain.embeddings import OpenAIEmbeddings

"""### Load Multiple files from Directory"""

root_dir = "/content/data"

# loader = TextLoader('single_text_file.txt')
loader = DirectoryLoader(f'/content/documents', glob="./*.pdf", loader_cls=PyPDFLoader)
documents = loader.load()

"""### Divide and Conquer"""

text_splitter = RecursiveCharacterTextSplitter(
    chunk_size=1000,
    chunk_overlap=200)

texts = text_splitter.split_documents(documents)

"""### Get Embeddings for OUR Documents"""

# !pip install faiss-cpu

def store_embeddings(docs, embeddings, sotre_name, path):
    vectorStore = FAISS.from_documents(docs, embeddings)

    with open(f"{path}/faiss_{sotre_name}.pkl", "wb") as f:
        pickle.dump(vectorStore, f)

def load_embeddings(sotre_name, path):
    with open(f"{path}/faiss_{sotre_name}.pkl", "rb") as f:
        VectorStore = pickle.load(f)
    return VectorStore

"""### HF Instructor Embeddings"""

from langchain.embeddings import HuggingFaceInstructEmbeddings
# from langchain_community.embeddings import HuggingFaceInstructEmbeddings
from InstructorEmbedding import INSTRUCTOR

instructor_embeddings = HuggingFaceInstructEmbeddings(model_name="hkunlp/instructor-xl",
                                                      model_kwargs={"device": "cuda"})

Embedding_store_path = f"{root_dir}/Embedding_store"

db_instructEmbedd = FAISS.from_documents(texts, instructor_embeddings)

retriever = db_instructEmbedd.as_retriever(search_kwargs={"k": 5})

docs = retriever.get_relevant_documents("which method did Ventirozos use?")

# create the chain to answer questions
qa_chain_instrucEmbed = RetrievalQA.from_chain_type(llm=OpenAI(temperature=0.2),
                                                    chain_type="stuff",
                                                    retriever=retriever,
                                                    return_source_documents=True)

"""### OpenAI's Embeddings"""

from langchain.embeddings import OpenAIEmbeddings

embeddings = OpenAIEmbeddings()

db_openAIEmbedd = FAISS.from_documents(texts, embeddings)
retriever_openai = db_openAIEmbedd.as_retriever(search_kwargs={"k": 5})

# create the chain to answer questions
qa_chain_openai = RetrievalQA.from_chain_type(llm=OpenAI(temperature=0.2, ),
                                              chain_type="stuff",
                                              retriever=retriever_openai,
                                              return_source_documents=True)

def wrap_text_preserve_newlines(text, width=110):
    # Split the input text into lines based on newline characters
    lines = text.split('\n')

    # Wrap each line individually
    wrapped_lines = [textwrap.fill(line, width=width) for line in lines]

    # Join the wrapped lines back together using newline characters
    wrapped_text = '\n'.join(wrapped_lines)

    return wrapped_text

def process_llm_response(llm_response):
    print(wrap_text_preserve_newlines(llm_response['result']))
    print('\nSources:')

    if llm_response["source_documents"]:
        # Access the first source document
        first_source = llm_response["source_documents"][0]
        source_name = first_source.metadata['source']
        row_number = first_source.metadata.get('row', 'Not specified')

        # Print the first source's file name and row number
        print(f"{source_name}, Row: {row_number}")
    else:
        print("No sources available.")

query = 'which method did Ventirozos use??'

print('-------------------Instructor Embeddings------------------\n')
llm_response = qa_chain_instrucEmbed(query)
process_llm_response(llm_response)

query = 'which method did Ventirozos use??'

print('-------------------OpenAI Embeddings------------------\n')
llm_response = qa_chain_openai(query)
process_llm_response(llm_response)

Can you have a look into the above code and help me with this? I presume we need to save vector db's separately for every pdf, then iterate through those and return answer for every pdf file
Idea or request for content:
No response

🤖
Hey @nithinreddyyyyyy, great to see you back here! Hope you've been doing well since our last interaction. 😊
Based on your request, it seems like you want to extract answers from each individual PDF file separately. To achieve this, you can modify the existing code to create a separate vector database for each PDF file, and then iterate over these databases to extract the answers. Here's a simplified example of how you might modify the code:
# Assuming `pdf_files` is a list of your PDF files
for pdf_file in pdf_files:
    # Load the PDF file
    loader = PyPDFLoader(pdf_file)
    document = loader.load()

    # Split the document into chunks
    texts = text_splitter.split_document(document)

    # Create a vector database for the document
    vectorStore = FAISS.from_documents(texts, instructor_embeddings)

    # Create a retriever for the vector database
    retriever = vectorStore.as_retriever(search_kwargs={"k": 5})

    # Create a chain to answer questions
    qa_chain = RetrievalQA.from_chain_type(llm=OpenAI(temperature=0.2),
                                           chain_type="stuff",
                                           retriever=retriever,
                                           return_source_documents=True)

    # Use the chain to answer a question
    llm_response = qa_chain(query)
    process_llm_response(llm_response)

In this example, a separate vector database is created for each PDF file, and the RetrievalQA chain is used to extract answers from each database separately. The process_llm_response function is used to process and print the answer for each PDF file.
Please note that this is a simplified example and you'll need to replace the pdf_files and query variables with your actual list of PDF files and question. Also, this example assumes that you have already defined the text_splitter, instructor_embeddings, and process_llm_response variables as in your original code.
I hope this helps! If you have any further questions, feel free to ask.
Sources

libs/langchain/langchain/chains/qa_with_sources/map_reduce_prompt.py
libs/community/langchain_community/document_loaders/directory.py
libs/langchain/langchain/document_loaders/pdf.py

This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.
Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.
If you want to continue the conversation, start your reply with @dosu-bot.

Can you please return the complete updated code?


Deis no longer drains app logs via /deis/logs/drain?

Looking to drain application logs to Papertrail. Docs (http://docs.deis.io/en/latest/managing_deis/platform_logging/#application-log-drain) suggest a method using deisctl config logs set drain=..., which apparently manages the /deis/logs/drain key in etcd. However, looking through the source code, it appears as though Deis v0.12  and onwards no longer consult this etcd key.
Is there another a new way to ship application logs?

@kenaniah AFAIK this is still available as a feature. Are no logs being drained to your forwarded address, or is this just a general question?

No logs are being drained. Logs will drain when adding a service that performs journalctl -f | ncat --ssl ..., but the logger service is not consulting the drain key, even after stop / start.

Actually, it turns out this was an oversight in the documentation. I had to restart the deis-logger and deis-logspout services (unclear if restarting deis-logger first was necessary) after making the deisctl config set call.

logger doesn't require restart when the drain url changes.  logspout does require restart if the logger's IP changes-- which can happen if it is ever rescheduled to a different host for some reason.  This will be addressed if we ever get around to upgrading logspout (waiting for their upcoming stable release has been a blocker).  Also, we've periodically seen logspout seize up (deadlock), and to our knowledge, we've addressed those issues, but I'd not be surprised if this were still somehow possible.  If this happens to you again, checking logspout's logs (on each host) and logger's logs may be enlightening as to what's going on.  Using deis logs to look for recent app logs should also give you some indication of whether logs are reaching the logger.  If not, that is more indicative of a logspout problem.


Name of ListObject not recognized

When xlsx contains a ListObject the name of that ListObject is not known by IWorkbook.GetNameIndex (returns value < 0).  If I convert the ListObject to a simple range, the GetNameIndex returns a valid index.
Am I missing something in the API that works directly on a ListObject?  Is there a workaround to continuing to use a ListObject?

What do you exactly mean ListObject in a xlsx? I didn't fully get your point. Are you talking about VBA objects?

Sorry for the delay in updating you ...
I was mixing VBA and Excel terms.
If you create a table object in Excel (Insert->Table) and name that table it is not available to NPOI.  It is available in the VBA from both the workbook.names and worksheet.range collections.
I have attached a sample XLSX.
demoTableIssue.xlsx

here ListObject is a VBA object, isn't it? If so, NPOI have no access to any VBA variables in this case. In other words, NPOI doesn't include any VBA compiler or runtime to simluate the VBA program running.


Add support/parameter for "natural sort"

Expected behavior
The "lsd" command should have a nice parameter wich naturally sorts numbers within text.
Actual behavior
The "ls" command has a nice parameter, but "lsd" hasn't:
-v     natural sort of (version) numbers within text

I could help to implement this,
but first I would like to make sure how this work because I was confused about the description (version) numbers within text
what's the meaning of the (version)?
AFAIK, -v should sort by file name in natural order, like

numbers before letters
number order in the natural order, like 1 2 11 21

Hi @zwpaper , great, that you could help :-)
Normal "ls" has "-v" option which ends up in what you said in both points:
(but I don't know why a capital letter should be sorted before a lower case and I won't mind/care about this)
root@ubuntu-cx11-02:~/temp/1# command ls -lv #h #--time-style=+%Y-%m-%d_%H:%M:%S
total 0
-rw-r--r-- 1 root root 0 Aug 12 09:12 1
-rw-r--r-- 1 root root 0 Aug 12 09:12 2
-rw-r--r-- 1 root root 0 Aug 12 09:12 3
-rw-r--r-- 1 root root 0 Aug 12 09:12 4
-rw-r--r-- 1 root root 0 Aug 12 09:12 10
-rw-r--r-- 1 root root 0 Aug 12 09:12 11
-rw-r--r-- 1 root root 0 Aug 12 09:12 12
-rw-r--r-- 1 root root 0 Aug 12 09:12 20
-rw-r--r-- 1 root root 0 Aug 12 09:12 21
-rw-r--r-- 1 root root 0 Aug 12 09:12 A
-rw-r--r-- 1 root root 0 Aug 12 09:12 B
-rw-r--r-- 1 root root 0 Aug 12 09:12 C
-rw-r--r-- 1 root root 0 Aug 12 09:12 a
-rw-r--r-- 1 root root 0 Aug 12 09:12 b
-rw-r--r-- 1 root root 0 Aug 12 09:12 c

instead of this without "-v":
root@ubuntu-cx11-02:~/temp/1# command ls -l
total 0
-rw-r--r-- 1 root root 0 Aug 12 09:12 1
-rw-r--r-- 1 root root 0 Aug 12 09:12 10
-rw-r--r-- 1 root root 0 Aug 12 09:12 11
-rw-r--r-- 1 root root 0 Aug 12 09:12 12
-rw-r--r-- 1 root root 0 Aug 12 09:12 2
-rw-r--r-- 1 root root 0 Aug 12 09:12 20
-rw-r--r-- 1 root root 0 Aug 12 09:12 21
-rw-r--r-- 1 root root 0 Aug 12 09:12 3
-rw-r--r-- 1 root root 0 Aug 12 09:12 4
-rw-r--r-- 1 root root 0 Aug 12 09:12 a
-rw-r--r-- 1 root root 0 Aug 12 09:12 A
-rw-r--r-- 1 root root 0 Aug 12 09:12 b
-rw-r--r-- 1 root root 0 Aug 12 09:12 B
-rw-r--r-- 1 root root 0 Aug 12 09:12 c
-rw-r--r-- 1 root root 0 Aug 12 09:12 C


Fix re-frame.interop/now for nodejs

In a nodejs environmentjs/performance is not defined by default and would need perf_hooks to be required. See https://nodejs.org/api/all.html#perf_hooks_performance_timing_api
This is quick fix to make re-frame.interop/now not crash when it hasn't been required.
I'm not sure if there are any tests to be written as per the contributing guidelines for re-frame in a nodejs env?

Thanks! We don't have any tests for node currently, so we don't need to add any here. @jeaye I think you've hit this isssue recently?

Yes indeed, I hit this with React Native. Looks like a good fix for that as well. Thank you!

I've just deployed 0.10.3-beta with this fix.


k8s: update k8s libraries to 1.19.3

Also update k8s test versions to 1.18.10 and 1.17.13
Signed-off-by: André Martins<EMAIL_ADDRESS>

test-me-please

retest-4.19

test-missed-k8s

K8s all are failing on master, merging this PR https://jenkins.cilium.io/job/cilium-master-K8s-all/


Ensure that test servers are killed in event of failure due to exception

I've been trying to run the tests, but the SslServerRunner keeps throwing an exception (separate issue I'm still investigating).  However, when that happens the rake task dies but the server processes are still running in the background listening in on ports 8443 and 4567.  This ensures that, should that happen, those processes are still killed before the rake task exits.

@mogman1 I'm having the same issue. I also get something along the lines of: ERROR OpenSSL::SSL::SSLError: SSL_accept returned=1 errno=0 state=SSLv3 read client key exchange A: sslv3 alert bad certificate

@syntaxritual Glad to hear I'm not the only one, that's the exact error I'm running into but am still trying to figure out.

Does this fix it? Do you want me to merge?

Yeah, using this code made sure the background server processes died while I was investigating the SLL issue.  Without it, the exception that was being thrown caused the kill lines to be skipped, leaving those servers running when the script ended (I had to issue a kill command from the console).  You should be good to merge.
Also: It's good to see you're back!


Running scanner under the webview

Hi,
It would be cool to get plugin launch under the webview.
By this way it will be possible to custom scanning UI.
They achieve this with following plugin for barcode and qrcode scanning :
https://github.com/vash15/cordova-plugin-background-barcode-scanner
Obviously it will requires to expose most of method to unskew, rotate,  image filter to api.
But it would be a great improvement to UI.
Regards

This is a good enhancement to have. Will probably take a huge overhaul though. Not sure when we will be able to take this up. So keeping this open as an enhancement for now
Cheers,
Chris
Neutrinos


Exchange sort

This is a draft to show how Timely could capture the exchange pattern, sort it, and reduce the cache misses for pushers.
Currently, this results in a significant performance regression for a low number of peers, but I'll try to test it on a machine with more workers.

Not pursuing this at the moment.


Improve API for some Snapshot methods

Both methods make the Snapshot instance unuseable and so should take ownership of it to limit potential misuse from the users.

Anything else to be done in here?

Anything else to be done in here?

I am waiting to see if the ToGlibPtrMove traits will land soon-ish or not, we can update the PR before landing it then.

It's there now but the gir-related changes are still pending. @GuillaumeGomez what's the status on that?

Still need to do it.

I finally took the time to update it. I needed to update the gir submodules too to get the change so the first

Closing in favour of https://github.com/gtk-rs/gtk4-rs/pull/1097


Update fritzhome to 1.0.5 and remove limitation note on doc page

The current documentary for the fritz dect switch says the following:

This issue has been fixed in the lastest version of the fritzhome package as you can see here:

https://github.com/DerMitch/fritzbox-smarthome/issues/18
https://github.com/DerMitch/fritzbox-smarthome/commit/a47c99c7b2786fe2d2cf5a56767acda55b294fcb

Current version of Home Assistant use the old 1.0.4 version as shown here:
https://github.com/home-assistant/home-assistant/blob/1b22f2d8b888f124f5ffb1412ae59b7ef08a3d78/requirements_all.txt#L302
https://github.com/home-assistant/home-assistant/blob/678f284015a2c52f96a7687979cfd9f785e4527a/homeassistant/components/switch/fritzdect.py#L19

Probably fixed by #10688 since fritzhome will be replaced by pyfritzhome in the near future.

I can confirm that the new fritzbox (started as fritzhome) platform will fix this behavior described. This should be included in home-assistant after accepting  #10688.


fix(FOROME-903): change search params for dtree page

https://quantori.atlassian.net/browse/FOROME-903
PR into https://github.com/ForomePlatform/Anfisa-React-Client/pull/576

Too many conflicts. The new PR https://github.com/ForomePlatform/Anfisa-React-Client/pull/589


Switching the chats with search switcher makes LHN disappear and refreshes the page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1710266192686059
Action Performed:

Open app
Switch between the chats from the LHN
Click search and search for a contact and hit enter

Expected Result:
The chats should load in the LHN smoothly
Actual Result:
The whole LHN disappears and refreshes in a slow and jarring way
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/38435837/edcb3ade-7a4d-4620-99b8-150dd6bd1d3e

View all open jobs on GitHub

@dylanexpensify hi, it's still reproducible, can you recheck this, please?
https://github.com/Expensify/App/assets/50919443/dce3bc0a-5a5f-4f48-bb05-9f07d07039c2
Notice the LHN keeps refreshing when selecting a chat from the search page and the scroll position resets to the top.
https://github.com/Expensify/App/assets/50919443/21c7b474-de2f-46ce-9e53-28f064772654
Here is how it looks when it's fixed. The scroll position stays in place.
technically it should be more noticeable if you use HT account


Update slack invite link

The slack invite link was not working anymore, fixed here.

ok, done ✅

Ah Ok, makes sense, today I am discovering a lot of nf-core secres :scream:


Added externs for chrome.declarativeContent API and chrome.events

Event methods and types: https://developer.chrome.com/extensions/events
Added addRules, getRules, removeRules, Rule type and UrlFilter
type.
Added chrome.declarativeContent API:
https://developer.chrome.com/extensions/declarativeContent

@MatrixFrog did you have time to watch this? I'm already using this new externs to minify my Chrome extension

@IvanRF I believe I'm waiting for you to push an update. Let me know if I am mistaken.

@brad4d Oh, I was waiting a reply for the other two questions I made

@IvanRF I'm glad I asked.
I only see the one question about {!{ in typedefs.
Maybe you have comments that are somehow in a "draft" mode or something?
Where should I be looking?

Oh, that was weird, comments were in a "Pending" state, do you see them now?

Seen and responded.

@brad4d I have a doubt for https://developer.chrome.com/extensions/events#method-Event-getRules
The first parameter ruleIdentifiers is optional and the second one callback is not. The compiler does not like that and wants the optional parameters at the end, but that will break the function definition.

@IvanRF added a comment to show how to handle an optional argument that isn't at the end.

@IvanRF BTW the broken travis build is not related to your update. Please ignore it.

@brad4d let me know if there is something else to change in the pull request.
Related question: Two days ago I received an email from the Chrome Web Store team which confused me. As you mentioned before, you are able to have "some internal Google discussion" which could help since this project is involved.
I published an update to a Chrome extension in which the code was minified using Closure Compiler. The update entered a "pending review" state and mainly what the email said was:

...it currently violates the section of the Developer Program Policy relating to Malicious Products as its obfuscating a part of code. Per our policies, where possible, make as much of your code visible in the package as you can. If some of your app's logic is hidden and it appears to be suspicious, we may remove it.

Of course, I quickly uploaded the extension without minification and the revision was approved.
Now my question, when I decided to use Closure Compiler on the extension was because I saw that Google Publisher Toolbar minifies the code. Also, the file in which I added some new code here was available in this project: contrib/externs/chrome_extensions.js and the only purpose is to use it on a Chrome extension. So I am confused. Every question at StackOverflow says it is ok, but it seems it is not. What do you think?

/cc @MatrixFrog
Chrome uses a .json description of this extension API to generate bindings:
https://cs.chromium.org/chromium/src/chrome/common/extensions/api/declarative_content.json
Using this python script, we can generate externs from this .json fairly easily:
https://cs.chromium.org/chromium/src/tools/json_schema_compiler/compiler.py
The results of running
tools/json_schema_compiler/compiler.py -g externs \
chrome/common/extensions/api/declarative_content.json > declarative_content_externs.js

Are: https://gist.github.com/danbeam/15836fea2e2c767318b6cbb004fbe5e4
It might also be worthwhile to update the internal file with these contents.

@danbeam looking at https://developer.mozilla.org/en-US/docs/Web/API/ImageData the definition is the same as ImageData: https://github.com/google/closure-compiler/blob/ea509e4ba9601f273c606d824a7f37b8a600b7e4/externs/html5.js#L524 which is the type I used, no need to declare

@danbeam
I believe the automatically generated externs are incorrect.
They are defining as @typedef symbols that you intend should be called as a constructor with a literal object matching the @typedefed type.
Please see this comment and surrounding discussion for more explanation.
https://github.com/google/closure-compiler/pull/2527#discussion_r127330992

@brad4d any news regarding this PR?

@IvanRF I thought I was waiting for @danbeam to correct his autogeneration of externs, and then you to use that autogeneration to update this PR.
Assuming you intend to just submit a manually created update here, I've added some questions to the code changes.

@brad4d thanks for the reply, let me know if new changes are needed.

@IvanRF requests for changes added.
In general:

if you need to create an instance of something with new, you must define it as @constructor.
The @record form of declaring interface types is generally preferable to @typedef. It's more verbose, but it's also easier to document the individual properties and the compiler does a better job of type checking with @record.  e.g. I've recently been looking at a bug where properties defined with @typedef in externs are getting renamed when they really shouldn't. Also since you can extend @record types, it's easier to define several related types that way.

@IvanRF I thought I was waiting for @danbeam to correct his autogeneration of externs, and then you to use that autogeneration to update this PR.

https://bugs.chromium.org/p/chromium/issues/detail?id=772603

@brad4d I'm testing the new changes and I've found that the externs.zip file inside the latest release closure-compiler-v20170910.jar does not include chrome.js. Was that intentional or a mistake on making on the release?
The previous version 20170806 has it.

@brad4d In the last commit I defined SetIcon and RequestContentScript as @constructor. I maintained the "literal" structure and the @typedef since @record was never used in that file.
Nevertheless, let me know if you think I should make the 3 chrome.declarativeContent.*Literal a @record and define each property as chrome.declarativeContent.*Literal.prototype.*.

@IvanRF
I think this looks pretty good.
I've imported it and started a global presubmit to make sure it doesn't break any Google code.

@brad4d Excellent, thanks!

Internal testing looks good.
I've sent this to @MatrixFrog for internal review.

Internal review revealed that some refactoring is needed so we don't end up having to add the rules-related methods separately to every one of the event types.
I'll make that change separately, then this PR will need to build on top of it.

@brad4d OK, let me know when the refactoring is finished

@IvanRF
I've just submitted a refactoring change affecting chrome.js and chrome_extensions.js.
It should get pushed out to github tomorrow.
The point of the refactoring is to remove lots of duplicated code and avoid having to write lots of duplicates of the new rules-related methods in this pull request.
Sadly, it turned out that there were more special cases to be dealt with.
I believe I need to do another refactoring before we'll be ready to add the rules methods.
See the TODO comments in chrome_extensions.js after tomorrow's push to github for more details.

I've discovered that I should have used @interface instead of @record in my refactoring.
A change is on the way to do that.

I've just sent another change for internal review.
It adds the rule methods in a way that ensures they are inherited by all of the event types defined in chrome.js and chrome_extentions.js.
Once that is submitted and pushed to github, @IvanRF should sync and resolve conflicts.
Then I'll import them to finish this PR.

@IvanRF
My addition of the rule methods has been pushed to github.
Please rebase the branch for this PR.
Thanks.

@brad4d Is ChromeBaseEvent the new version of ChromeEvent? I moved and added the functions addRules, getRules and removeRules to ChromeBaseEvent.

@brad4d I merged the new changes.

I've imported the latest and am continuing the internal review.

@brad4d all changes done 👍

Updates imported for internal review.
I believe this will get submitted internally today.


Ross documentation

Documentation of native and native-dsn pipelines, good foundation for further documentation

Conflicting commit changes resolved.


Update codecov to check during PR

Description
Update codecov to check during PR
Related Issues
https://github.com/opensearch-project/neural-search/pull/975
Check List

~~ ] New functionality includes testing.~~
[ ] New functionality has been documented.
[ ] API changes companion pull request created.
[x] Commits are signed per the DCO using --signoff.
[ ] Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

This PR needs to be merged before taking effect.


Add Hungarian translation

Thanks for the pull request! I will soon release a new version with the added translation. 😃

The changes are part of the new version 2.4.0 released today.


Failed Transaction Result Code Summary

This PR adds a "result_codes" section to the "transaction_failed" error response.  In addition:

Update to latest go-stellar-base master
Adds a "codes" helper package for translating xdr enums into strings used in our response design
Renames 'account' to 'source_account' for consistency

r+

:+1:


chore: new request/template specific status interfaces, and a new package for setting conditions

This is mostly code-cleanup in prep for a larger change coming. We create new IRequestStatus and ITemplateStatus interfaces and move some specific methods into them. We've also moved all of the UpdateCondition() calls to the internal/controllers/internal/status package - so that the logic is all confined in one place for what types of strings and values are passed into the conditions.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

29 of 184 (15.76%)  changed or added relevant lines in 5 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-5.9%) to 38.272%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/controllers/pod_access_request_controller.go
1
2
50.0%

internal/controllers/exec_access_request_controller.go
0
2
0.0%

internal/controllers/internal/status/set_conditions.go
0
152
0.0%

Files with Coverage Reduction
New Missed Lines
%

internal/controllers/base_request_controller.go
1
98.39%

Totals

Change from base Build<PHONE_NUMBER>:
-5.9%

Covered Lines:
762

Relevant Lines:
1991

💛  - Coveralls

(Ignoring the test coverage numbers dropping... in this case it reflects no actual reduction in testing)

@LaikaN57 Please post-review... I am going to merge this to keep moving forward.


Composed component are out of context

hi @Yomguithereal , I've facing a similar problem, I'm trying use https://github.com/FormidableLabs/react-shuffle but the nested children doesnt receive the context, this issue seems will be solved in react 14 but I wish to know  if there is some trick for this, thanks!

Hello @cocodrino. This problem arise because React does not propagate context when you render this.props.children. If you can modify the part where this.props.children is used then you can use the solution described in #52. Else, I fear this might be difficult to overcome this without 0.14.

This should be fixed by<EMAIL_ADDRESS>


Stream overhaul

This is a bit of a (minor) redesign of how the read/write functions work in the case of streams, so that software doesn't need to know whether it's dealing with a stream or a disk file, and programming against this API becomes a bit less confusing.
Lightly tested by typing in the terminal.

In applications/sh/main.asm, why did you remove the call to yield_task? I assume that was a mistake, otherwise the shell never gives up control.

Because it's not necessary for the read to work anymore. One might argue that it's still a good idea to keep an explicit yield_task in long-running loops, though

Oh oops I missed the fact that you added a yield call to stream_read_loop.


Property visibility scope.

    /**
     * Transaction amount
     * @var float
     */
    private $amount;

    /**
     * @var string
     */
    private $otp;

    /**
     * @var string
     */
    private $username;

    /**
     * @var string
     */
    private $password;

    /**
     * @var
     */
    private $merchantNumber;

    /**
     * @var
     */
    private $clientNumber;

    /**
     * @var
     */
    private $referenceNumber = "";

    /**
     * @var string
     */
    private $url;

Using private on the properties makes it impossible to extend this class, I suggest using protected.

Here it is a class of end use and dedicated to a specific Orange Operator.  So I don't think another class inherits from this one.  However, we can think of a class of the type AbstractMobileMoney which it can have protected properties as well as protected methods which can also be abstract if we do not know in advance how to implement them.

Here it is a class of end use and dedicated to a specific Orange Operator. So I don't think another class inherits from this one. However, we can think of a class of the type AbstractMobileMoney which it can have protected properties as well as protected methods which can also be abstract if we do not know in advance how to implement them.

What if as a developer I would like to extend the class and not use it directly, Maybe I want to change how the XML template is constructed in private function requestApi() you've made this impossible just by using private, so my only option would be to develop a new package, what if I want to create another package that takes care of Orange Money, Coris Money and others, but because am a contributor here I choose to depend on this package to avoid writing a new Orange Money API code, this would be impossible with the current setup because I can not extend the classes.
The O in SOLID principle stands for open–closed principle and it states that "A class should be open for extension, but closed for modification".
private is not a very popular thing to use unless you have a good reason for it, I can only spot it in a few places in the whole of Laravel 8 and Symfony 5 Frameworks, I don't see the need or good reason for it in this package.

Here it is a class of end use and dedicated to a specific Orange Operator. So I don't think another class inherits from this one. However, we can think of a class of the type AbstractMobileMoney which it can have protected properties as well as protected methods which can also be abstract if we do not know in advance how to implement them.

What if as a developer I would like to extend the class and not use it directly, Maybe I want to change how the XML template is constructed in private function requestApi() you've made this impossible just by using private, so my only option would be to develop a new package, what if I want to create another package that takes care of Orange Money, Coris Money and others, but because am a contributor here I choose to depend on this package to avoid writing a new Orange Money API code, this would be impossible with the current setup because I can not extend the classes.
The O in SOLID principle stands for open–closed principle and it states that "A class should be open for extension, but closed for modification".
private is not a very popular thing to use unless you have a good reason for it, I can only spot it in a few places in the whole of Laravel 8 and Symfony 5 Frameworks, I don't see the need or good reason for it in this package.

requestApi is private simply because it is for internal use. The code found in this method can perfectly be moved into processPayment. This is a method that is not meant to be used outdoors.
However, as you pointed out, we are going to change the visibility of properties and methods for the extension.
The requestApi method always remains private and processPayment becomes protected thus giving the user the possibility to implement his own logic.

Ok


Rancher Server gets internal IP after some time instead of the assigned Public IP

Rancher versions:
rancher/server: 1.5.10
rancher/agent: 1.2.2
Infrastructure Stack versions:
healthcheck: 0.2.3
ipsec: 0.11.2
network-services: 0.6.6
scheduler: 0.7.5
kubernetes (if applicable): no, use cattle
Docker version: (docker version,docker info preferred)
Containers: 21
Running: 15
Paused: 0
Stopped: 6
Images: 78
Server Version: 1.12.6
Storage Driver: overlay
Backing Filesystem: extfs
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
Volume: local
Network: bridge null host overlay
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Security Options: seccomp selinux
Kernel Version: 4.9.24-coreos
Operating System: Container Linux by CoreOS 1353.8.0 (Ladybug)
OSType: linux
Architecture: x86_64
CPUs: 4
Total Memory: 7.801 GiB
Name: gabi
ID: IZBS:MVYL:BOO2:J4DF:DIVZ:TAZO:ASTZ:GO45:36QE:NDWT:W4ZZ:VIJQ
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
Insecure Registries:
<IP_ADDRESS>:5000
<IP_ADDRESS>/8
Operating system and kernel: (cat /etc/os-release, uname -r preferred)
4.9.24-coreos
Type/provider of hosts: (VirtualBox/Bare-metal/AWS/GCE/DO)
Private Server / runs on ESX-Server
Setup details: (single node rancher vs. HA rancher, internal DB vs. external DB)
Server 1: Rancher Server and Main Server with internal DB, single node
Server 2 and Server 3 added some days ago
Environment Template: (Cattle/Kubernetes/Swarm/Mesos)
Cattle
Steps to Reproduce:
If the Server 1 reboots, the public IP is correct (<IP_ADDRESS>) and all rancher-services start correctly.
IP-tables shows the correct ip:
hoshi tharoot # iptables -L -n -t nat | grep 8080
MASQUERADE  tcp  --  <IP_ADDRESS>           <IP_ADDRESS>           tcp dpt:8080
DNAT       tcp  --  <IP_ADDRESS>/0            <IP_ADDRESS>/0            tcp dpt:8080 to:<IP_ADDRESS>:8080
Server 1 can correspond with Server 2 and 3 and deploy the container on all host perfectly.
After some hours, Server 1 shows under "Infrastructure->Hosts" not the public  IP. It shows the docker IP <IP_ADDRESS> and IP-tables shows now the wrong IP:
hoshi tharoot # iptables -L -n -t nat | grep 8080
MASQUERADE  tcp  --  <IP_ADDRESS>           <IP_ADDRESS>           tcp dpt:8080
DNAT       tcp  --  <IP_ADDRESS>/0            <IP_ADDRESS>/0            tcp dpt:8080 to:<IP_ADDRESS>:8080
Results:
Everytime when the "Public IP" is <IP_ADDRESS>, the services "healthcheck" and "scheduler" stucks at "initializing".
Quick temporary troubleshooting
Restart the Rancher Server 1, the services came up and everything works until the next crash.
further information
To prevent this problem, i added some lines in the /etc/hosts, but i think, this wouldn't help.
<IP_ADDRESS>      localhost
<IP_ADDRESS>      localhost
Final
what can i do to fix this issue, or is this issue in rancher?

Please specify CATTLE_AGENT_IP when multihomed/NAT or when running rancher/agent on the same machine as rancher/server.
See documentation here: https://docs.rancher.com/rancher/v1.6/en/faqs/troubleshooting/#are-the-ips-of-the-hosts-correct-in-the-ui
This should solve your problem.

Thank you very much for the fast response. This was the ultimative solution.
With every day I like Rancher even more. The documentation is super described. :-)


Use CompositionLocal to switch typography

Issue

close #372

Overview (Required)

Default typography is set using CompositionLocal
Fixed to be able to switch typography in KaigiTheme. See the following.
　　https://github.com/DroidKaigi/conference-app-2022/pull/392/files#diff-75a59ce6214f4b920a53443f5cc4eed6f1fe5076632434ffbdc139b12dc5bdb5R85-R88

Links

Screenshot

Before
After

Sorry, I just mean that I want to use "ProvideTextStyle" for KaigiScaffold title. 🙇 🙇 🙇

Can you tell me what you want to do? 👀

Oh, I'm sorry... I close this pull request.


docs(installation): fix punctuation

Description:
Just to make the docs more consistent
Related issue (if exists):

Pull Request Test Coverage Report for Build 7657

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 96.806%

Totals

Change from base Build 7636:
0.0%

Covered Lines:
5244

Relevant Lines:
5417

💛  - Coveralls


Create initial privacy policy

This to be a stub page, linked to from the footer of the site.
The privacy policy will be brief and state that we collect no information other than that which is collected via the feedback survey.
We can use the gov.uk privacy notice for relevant sections
https://www.gov.uk/help/privacy-notice

We need to contact research ops about the privacy notice content

Update:

Following removal of Smart Survey link (replaced with feedback coming via email or Github Issue), this no longer dependent on research ops
New privacy policy only needs to cover what information is collected by the site
As the migration to ACP will introduce logging of certain information we need to understand impact of this on a privacy statement

Re-prioritising to Low, to pick up as part of Core Cloud migration activity. Deleting branch as stale


Remove unused pts reading.

As discussed offline with @SirVer , nobody is using the pts file reading code any more.

@nnmm FYI


Test against Python 3.6 and 3.7

While I was reviewing the test suite, added an update to make sure we are covering all versions.

Could you rebase this, and then we're good to go.


Dota2.schema.CMsgFindSourceTVGames is not a function

I'm attempting to use the requestSourceTVGames function as defined in helpers/sourceTV.js
It contains the following invocation:
var payload = new Dota2.schema.CMsgFindSourceTVGames(merge({
    "searchKey": '',
    "start": 0,
    "numGames": 6,
    "leagueid": 0,
    "heroid": 0,
    "teamGame": false,
    "customGameId": 0,
},filter_options));

However, the relevant CMsg is undefined on the Dota2 schema. I did a quick grep, and found that it does exist inside the steam npm module (steam-resources/protobufs/dota test/dota_gcmessages_client.proto). Tried copying & pasting the relevant proto from the node_modules into proto/dota_gcmesages_client.proto, but that then threw Error: .CMsgFindSourceTVGames#searchKey is not a field: undefined
Without much knowledge of the codebase or the steam GC in general, not really sure where to start trying to debug this, but I figured if nothing else you would probably want to know that the requestSourceTVGames function appears non-functional.

We've known this problem for a while, the CMsg hasn't been functional for a couple of weeks. I suggest you check out the dev branch, we've implemented the proto handler for the message which replaces this one. This issue can be closed.

Thanks for the info, appreciated


[pod-gateway] Fix issue where values.yaml defined 'configFile' wouldn't work in vpn addon

Description of the change
Because the default values.yaml file has configFileSecret set to openvpn by default, it is impossible to use the built in configFile with no secret. If you attempt to override configFileSecret to null the default value takes precedence, and the gateway will not start because of the lack of openvpn secret.

Benefits

Possible drawbacks

Applicable issues

fixes #

Additional information

Checklist

[x] Chart version bumped in Chart.yaml according to semver.
[x] Title of the PR starts with chart name (e.g. [home-assistant])
[x] Variables are documented in the README.md (this can be done with using our helm-docs wrapper ./hack/gen-helm-docs.sh stable <chart>)

In my local testing, when you specify the following values you should be able to run without the configFile:
addons:
  vpn:
    enabled: true
    type: openvpn
    openvpn:
    configFileSecret:

Although I do think it would be a bit cleaner if some of these keys are not set here but are left to the user's preference. Unfortunately I ran into a small bug in the common library when trying this, so that would need to get fixed before we can remove the openvpn and wireguard keys.

Thanks for the PR!
The values I picked as the defaults were heavily influenced by me using openvpn - so we can remove any non-default values that cannot be overwritten by the user.
Is there anything to remove beyond configFileSecret and potentially type ? Is there any issue with the null values @bjw-s or are they merged with the common defaults?

Is there anything to remove beyond configFileSecret and potentially type ? Is there any issue with the null values @bjw-s or are they merged with the common defaults?

By specifying them as null-values, the default values seem to get overwritten with null (I still can't really figure out why :X), potentially causing the chart to render incorrectly. That's why I proposed to remove the wireguard and openvpn keys.

@jmmaloney4 - please merge the suggestions when you have the chance so we can merge your PR. Thanks again for submitting 👍

@jmmaloney4 - would you be able to add the docs? If you need any help please let me know - I can, if necessary, add the doc to your PR so we can merge this fix.

@angelnu is this change sufficient?

It looks good @jmmaloney4 - only step left is to re-generate the README.md.
Can you please run task chart:helm-docs CHART_TYPE=stable CHART=pod-gateway in your PR? Then we are ready to merge :-)

@angelnu should be good to go.

Thanks @jmmaloney4 - now we need an owner to merge.

@all-contributors please add @jmmaloney4 for code


newsletter plugin run build error

Hello,
I've cloned and installed the newsletter plugin It works as expected with npm start. I cannot seem to npm run build due to the following error.
ERROR in ./dist/grapesjs-preset-newsletter.min.js from UglifyJs
Invalid assignment [./dist/grapesjs-preset-newsletter.min.js:86,164]
npm ERR! Linux 3.10.0-042stab132.1
npm ERR! argv "/usr/bin/node" "/usr/bin/npm" "run" "build"
npm ERR! node v6.14.1
npm ERR! npm  v3.10.10
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>build: cross-env WEBPACK_ENV=prod && npm run v:patch && webpack && npm run build:css
npm ERR! Exit status 2

Removed and reinstalled everything. Now able to run build. not sure what went wrong.


Mainly REST-assured fixes

Looks good, and addresses some of the issues found be out testers. Thanks!


redis可以设置密码吗?

redis可以设置密码吗?设置了密码如何进行连接

please follow the official document (http://redis.io/commands/auth)

issue#72 (https://github.com/wandoulabs/codis/issues/72)
!! since codis doesn't support any authorization mechanism, please disable the authorization layer in all codis-servers (patched redis)

thanks


ACCSEC-19360 Clear local data method

Jira Ticket

ACCSEC-19360

Description

Add a method to clear local data in TwilioVerify interface
Delete all factors in PushFactory
Clear storage when an error occurred in PushFactory

Commit message

feat: Provide method in TwilioVerify to clear local data

Testing

[x] Added unit tests
[x] Ran unit tests successfully
[x] Added documentation for public APIs and/or Wiki

          1 Warning

:warning:
The Pull Request title does not follow the convention [ACCSEC-0000] PR Title text

  Generated by :no_entry_sign: Danger


In the latest MUI version, I have to add @mui/system package

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
Using "@mui/material": "~5.10.3" I did not need the @mui/system package. After upgrading to "@mui/material": "~5.10.5" I have to install the @mui/system package or I get a lot of "module not found" errors. (I noticed the issue when running jest tests). Cannot find module '@mui/system' from ...
I am using yarn with pnp.
Expected behavior 🤔
Using "@mui/material": "~5.10.3" I do not need the @mui/system package.
Steps to reproduce 🕹
Steps:

Context 🔦
No response
Your environment 🌎

npx @mui/envinfo
  System:
    OS: macOS 12.5.1
  Binaries:
    Node: 17.9.0 - /usr/local/bin/node
    Yarn: 3.2.3 - /usr/local/bin/yarn
    npm: 8.5.5 - /usr/local/bin/npm
  Browsers:
    Chrome: 104.0.5112.79
    Edge: Not Found
    Firefox: 103.0.2
    Safari: 15.6.1

@lenzi-erickson Thanks for the feedback. Could you please share a minimal repository that I can take a look at and reproduce? This kind of issue is time-consuming if we are not using the same setup. Thanks in advanced.


Replace source js import with distribution js import in the sample index.html

It's a good change, but I think can be better changing the rules of webpack.dev.js, but we can improve it later.
Thanks!


Add tests for getLandRedirectionHashes and createLandRedirectionFile

Due to time limits, the tests for those functions could not be done.
It is important to test them for reliability.
Specially the getLandRedirectionHashes that has a complex logic for batching the requests

Already finished.


[Feature Request] :

Would like to request to bring back the Gogostream server since the StreamSD mostly has 480p and up, and Doodstream is 1080p.
The reason for this request is most of the time I used the app to download anime on the phone and the higher qualities are too big. So 360p was the go to always but now it's gone which was only available on the Gogostream server.

Adding that downloading from StreamSD returns Errors so the only server that can be downloaded from at the moment is Doodsteam.

Adding that downloading from StreamSD returns Errors so the only server that can be downloaded from at the moment is Doodsteam.

Adding that downloading from StreamSD returns Errors so the only server that can be downloaded from at the moment is Doodsteam.

Gogostream seems to be back so I'll close this.


systemd,agent: unload unit only when TriggerStop() runs successfully

In Agent.unloadUnit(), if systemdUnitManager.TriggerStop() returns any error, do not unload systemd units. Otherwise the unit could get into a state where the unit cannot be stopped via fleet, because the unit file was already removed.
Fixes https://github.com/coreos/fleet/issues/1216
/cc @patrickbcullen

BTW the travis error is again caused by an API change in go-systemd needed by etcd. It's going to be fixed in days from the etcd side.

I'll merge it soon, as it's clearly a potential bug.


Model is not available anymore

Is it possible to upload the model, again? The link is not accessible anymore.

Hi @ln2697, I just updated the model links. Does it work for you now?


Some (hopefully) uncontroversial client.font mappings

Font#method_27442 returns a set containing all the codepoints for which there are glyphs available in the Font. Alternatives: getAvailableGlyphs, getContainedGlyphs.
FontStorage#method_24290 just calls close on all fonts and then clears the list. Alternatives: clearFonts.
Not sure whether GlyphAtlasTexture#field_21691 should be textSeeThroughLayer (as in PR), which is consistent with RenderLayer#getTextSeeThrough, or seeThroughTextLayer.
GlyphRenderer takes both of those layers in constructor so I named them the same here

The rest are mostly just parameters where the name was derived from the field they were assigned to, or obvious codepoint ints.

Also, would it be possible to get this included in the 1.16.1 branch? Not sure if I want to hop onto the snapshots yet.

This is "ready to be merged", but as shartte correctly noticed, the getProvidedGlyphs method isn't obvious on a glance, so I thought I'd push some yarn comments on top. Is that okay?

Yes it is, please do :)

I skimmed through the contribution guide again but couldn't find a section specifically on javadoc; hope what I wrote does more good than harm.

Will be force pushing to resolve.

Should be functionally equal.


[Docs] Update outdated items from Edger8rGettingStarted.md

Found outdated references found by inspection:

Fix typo --untrusted-die (instead of --untrusted-dir) for the bash code snippet
Use oe_result_t instead of oe_return_t (since this type is not available anymore)
Remove public from the untrusted edl definition, otherwise the parser will fail
Add [user_check] to the pointers from the edl definition, otherwise the parser will fail
Use OE_OK instead of the OE_SUCCESS (since this is not available anymore)
Use oe_create_hello_enclave instead of oe_create_enclave to match the example described in the document

bors r+

@johnkord if you ask me, it looks like the behavior of the default compiler on Ubuntu 16.04 changed (like maybe it updated and so is emitting more warnings), hence the CI failures.

@andschwa That's what I thought too, but I've tried to repro this issue on a 16.04 system, and I simply can't when using the distro's latest gcc compiler! There's an open issue that covers this problem: #1659

bors r+

@andschwa That's what I thought too, but I've tried to repro this issue on a 16.04 system, and I simply can't when using the distro's latest gcc compiler! There's an open issue that covers this problem: #1659

Yes. It looks like an intermittent Docker failure again, we're trying to solve this.


Dialog Loading for Infinite

Hello the issue is that the Loading dialog box doesnot go away even internet is on and GPS is on its just keep on Loading

same problem

@VIRGO96 and @dute2 Sorry for the long delay, specially @VIRGO96  :)
Pull Request #15 should address that issue. Basically, the latest app was using reverse geolocation to get the weather for your current location and the steps were as follow:

Request GPS location from the device (this is what took so long)
Make a request to Google Maps API to request and address for the coordinates
Make a request to Yahoo Weather API to get weather data.

The current implementation uses the same flow with the exception that on the first step (GPS location) network location is used if available, network location is faster.
Hope that helps, let me know if I can help further

The Phantom


WIP - Added preliminary version of media tab for tests

This basic foundation is just to get an idea about the design of the endpoint and parameters needed

😱


disable submit expense button unless an attachment is included

This is blocked on fixing e2e test - need to find a way to upload an image through nightwatch tests.


New spanish community source MangaOni

Checklist:

[x] Updated source's version for individual source changes
[x] Updated all sources' versions for template changes
[x] Set appropriate nsfw value
[x] Did not change id even if a source's name or language were changed
[ ] Tested the modifications by running it on the simulator or a test device

make sure build.sh is executable (chmod +x build.sh)

build.sh still has the wrong perms so the workflow can't run

took a look at this and it looks like it needs significant changes to work, as the website has changed. feel free to update and reopen or make a new pr.
if you do update it, I suggest using QueryParameters from the aidoku-rs helpers crate.


Fix identical looking exported script variables in inspector on capitalization

Fixes #56846.
Before:

After:

Makes sense, but needs rebase.


pygame windows generate bad camera image

CARLA version: 0.9.14 from release download
Platform/OS: windows 11 with Nvidia RTX 4070ti(driver 528)
Problem you have experienced:
I had bad camera output from the Python examples provided by carla
I had hoped that the cause is I opened Nvidia's GSync option, so I tried to turn off windows-mode GSync and it's useless. I completed abandoned GSync but it still doesn't matter.

What you expected to happen: Hope this can be fixed.
Steps to reproduce: A trial to use windows 11, I think. Or it's a matter of RTX 40 card.

I'm experiencing the same issue with any RGBCamera output--both when displaying them in pygame and when exporting frames as image files. I'm using Carla 0.9.14 that I built on Windows 10 with a RTX 3090.

I have tested image output, it also doesn't work normally as you.  @myleskeller
I hoped to solve this problem by building carla, but in another issue: https://github.com/carla-simulator/carla/issues/6120 I just can't find the private repository so far(20230220).

I have successfully built carla 0.9.14. I can both run the simulator in Unreal Editor and isolatedly, but the bad image still happens.
I don't know how to do, this function is important for a simulator.

MAybe that is the stride problem, try to use widht and height resolution of multiple of 256 pixel. see #6085

Maybe that is the stride problem, try to use width and height resolution of multiple of 256 pixel. see #6085

That helps, thanks alot

For those discovering this and wondering exactly what is done,
any client side .py file that initializes a sensor of type RGBCamera should have image_size_x and image_size_y attributes used to set the camera image size.
For example, in visualize_multiple_sensors.py, they are initialized as follows:
camera_bp = self.world.get_blueprint_library().find('sensor.camera.rgb')
disp_size = self.display_man.get_display_size()
camera_bp.set_attribute('image_size_x', str(disp_size[0]))
camera_bp.set_attribute('image_size_y', str(disp_size[1]))

In my case, a debug print of disp_size returned [426, 360].
I simply hard-coded disp_size like:
scalar = 1
disp_size = [256,256]*scalar

that way if I need the increased resolution, I can just change the scalar.
There is probably a more sophisticated way to do this, as my implementation doesn't fill the previously allocated space in the pygame window, but I can at least see what's going on now.

I wrote a short blog post about this issue on the Carla simulator research blog - https://carlasimblog.wordpress.com/2023/09/16/the-64-division-curse/. And added a short code snippet to fix this.

From what I understood, the disp_size needs to be a power of 2 for both the height and the width, so you would have a normal image for disp_size = [256, 256] but not for [255, 255]


Fixes tests failing on Windows

Windows cannot just prepend file:// to the path returned from a File so going via toURI() seems more sensible...

LGTM


Fix comment for FIFFV_RESP_CH constant

Fixes #8853
I searched the sources, and the only code that really uses FIFFV_RESP_CH is BTi I/O, where it's quite clear that it's a response channel (not a respiration monitoring channel)

should it also fixed elsewhere?

Probably, yes:
https://github.com/mne-tools/mne-cpp/blob/c8e0124fd7630b5daff6477309a819d8b9dbfa90/libraries/fiff/c/fiff_types_mne-c.h#L234
https://github.com/mne-tools/fiff-constants/blob/5bd84d224de502bee66f70b7867b8f45b45264c1/DictionaryTypes.txt#L257
https://github.com/mne-tools/mne-matlab/blob/8f02bdeaf468c8df7a02adcd35656ca6f45f2d2f/matlab/fiff_define_constants.m#L167
Were the ones I've discovered so far

FT is also not perfectly consistent here:

"respiratory":

https://github.com/fieldtrip/fieldtrip/blob/ddbfd3187299628b7b94b67c95b15d5cb76e96f4/fileio/ft_chantype.m#L236-L237
https://github.com/fieldtrip/fieldtrip/blob/ddbfd3187299628b7b94b67c95b15d5cb76e96f4/fileio/private/mne2grad.m#L217-L218
https://github.com/fieldtrip/fieldtrip/blob/ddbfd3187299628b7b94b67c95b15d5cb76e96f4/realtime/src/acquisition/neuromag/include/fiff_types.h#L151

"event":

https://github.com/fieldtrip/fieldtrip/blob/ddbfd3187299628b7b94b67c95b15d5cb76e96f4/realtime/src/acquisition/neuromag/include/fiff_file.h#L584

cc @robertoostenveld

@larsoner suggested that it might be our BTi code that's incorrect, not the comment -> channel type 602 would indeed be respiratory then: https://github.com/mne-tools/mne-python/issues/8853#issuecomment-776762418

Thanks for pinging me. So the FieldTrip MATLAB code (which is most relevant to me) has "respiratory" which is considered to be correct. One of the fif c-code header files that is included in FT suggests in a comment that it is "events" or responses. I won't touch that header file, since it stems (probably) from @LauriParkkonen and I am unlikely to recompile that code anyway (and if I were to recompile, it would not change a thing).

it's more evidence now that RESP means actually respiration

Yes, RESP refers to respiratory monitoring and that channel is supposed to contain an analog signal from a monitoring belt around the chest.

Thanks for your feedback, this clarifies things!


Multi-ndoes DDP training hanging when initializing.

🐛 Bug
I'm trying to utilize all the computational resources to speed up. My code works fine on a single node, multi-GPUs mode (which means I did most part for DDP training right).
But when it comes to multi-nodes, I found my code always stops at DDP initializing. (stop at 2/4, I guess one node initializes correctly, but another one sucks. )
GPU available: True, used: True
TPU available: False, using: 0 TPU cores
IPU available: False, using: 0 IPUs
GPU available: True, used: True
TPU available: False, using: 0 TPU cores
IPU available: False, using: 0 IPUs
initializing ddp: GLOBAL_RANK: 1, MEMBER: 2/8
initializing ddp: GLOBAL_RANK: 1, MEMBER: 2/8
initializing ddp: GLOBAL_RANK: 2, MEMBER: 3/8
initializing ddp: GLOBAL_RANK: 2, MEMBER: 3/8
initializing ddp: GLOBAL_RANK: 3, MEMBER: 4/8
initializing ddp: GLOBAL_RANK: 3, MEMBER: 4/8
initializing ddp: GLOBAL_RANK: 0, MEMBER: 1/8
initializing ddp: GLOBAL_RANK: 0, MEMBER: 1/8
Traceback (most recent call last):
  File "/home/tw2112/codes/s2s/aux_with_neg_wiki/cool_test/test.py", line 74, in <module>
    trainer.fit(model)
  File "/ext3/miniconda3/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 552, in fit
    self._run(model)
  File "/ext3/miniconda3/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 863, in _run
    self.accelerator.setup_environment()
  File "/ext3/miniconda3/lib/python3.8/site-packages/pytorch_lightning/accelerators/gpu.py", line 30, in setup_environment
    super().setup_environment()
  File "/ext3/miniconda3/lib/python3.8/site-packages/pytorch_lightning/accelerators/accelerator.py", line 76, in setup_environment
    self.training_type_plugin.setup_environment()
  File "/ext3/miniconda3/lib/python3.8/site-packages/pytorch_lightning/plugins/training_type/ddp.py", line 168, in setup_environment
    self.setup_distributed()
  File "/ext3/miniconda3/lib/python3.8/site-packages/pytorch_lightning/plugins/training_type/ddp.py", line 253, in setup_distributed
    self.init_ddp_connection()
  File "/ext3/miniconda3/lib/python3.8/site-packages/pytorch_lightning/plugins/training_type/ddp.py", line 323, in init_ddp_connection
    torch.distributed.init_process_group(
  File "/ext3/miniconda3/lib/python3.8/site-packages/torch/distributed/distributed_c10d.py", line 525, in init_process_group
    _store_based_barrier(rank, store, timeout)
  File "/ext3/miniconda3/lib/python3.8/site-packages/torch/distributed/distributed_c10d.py", line 212, in _store_based_barrier
    raise RuntimeError(
RuntimeError: Timed out initializing process group in store based barrier on rank: 2, for key: store_based_barrier_key:1 (world_size=8, worker_count=3, timeout=0:30:00)

To Reproduce
I follow this #8707 and borrow the simple model from it, that problem still occurs:
test.py:
import logging
import os
import torch
from torch.nn import functional as F
from torch.utils.data import DataLoader
from torchvision.datasets import MNIST
import torchvision.transforms as transforms

import pytorch_lightning as ptl

def get_logger(name=__name__, level=logging.INFO):
    """Initializes python logger."""

    logger = logging.getLogger(name)
    logger.setLevel(level)

    # this ensures all logging levels get marked with the rank zero decorator
    # otherwise logs would get multiplied for each GPU process in multi-GPU setup
    for level in ("debug", "info", "warning", "error", "exception", "fatal", "critical"):
        setattr(logger, level, ptl.utilities.rank_zero_only(getattr(logger, level)))

    return logger

log = get_logger(__name__)

class CoolModel(ptl.LightningModule):

    def __init__(self):
        super(CoolModel, self).__init__()
        # not the best model...
        self.l1 = torch.nn.Linear(28 * 28, 10)

    def forward(self, x):
        return torch.relu(self.l1(x.view(x.size(0), -1)))

    def my_loss(self, y_hat, y):
        return F.cross_entropy(y_hat, y)

    def training_step(self, batch, batch_nb):
        x, y = batch
        y_hat = self.forward(x)
        return {'loss': self.my_loss(y_hat, y)}

    def validation_step(self, batch, batch_nb):
        x, y = batch
        y_hat = self.forward(x)
        return {'val_loss': self.my_loss(y_hat, y)}

    def validation_end(self, outputs):
        avg_loss = torch.stack([x['val_loss'] for x in outputs]).mean()
        return {'avg_val_loss': avg_loss}

    def configure_optimizers(self):
        return [torch.optim.Adam(self.parameters(), lr=0.02)]

    def train_dataloader(self):
        return DataLoader(MNIST(os.getcwd(), train=True, download=True, transform=transforms.ToTensor()), batch_size=32)

    def val_dataloader(self):
        return DataLoader(MNIST(os.getcwd(), train=True, download=True, transform=transforms.ToTensor()), batch_size=32)

    def test_dataloader(self):
        return DataLoader(MNIST(os.getcwd(), train=True, download=True, transform=transforms.ToTensor()), batch_size=32)

from pytorch_lightning import Trainer

model = CoolModel()

trainer = Trainer(max_epochs=1, gpus=4 num_nodes=2, accelerator='ddp')

trainer.fit(model)

Due to my HPC cluster, I have to use singularity to load conda environment instead of using module in other posts.
run.slurm
#!/bin/bash
#!/bin/bash
#SBATCH --output=./%j_%x.out
#SBATCH --error=./%j_%x.err
#SBATCH --ntasks=2
#SBATCH --ntasks-per-node=4
#SBATCH --export=ALL
#SBATCH --time=2-00:00:00
#SBATCH --gres=gpu:4
#SBATCH --mem=10G
#SBATCH --account=cds
#SBATCH -c 4

srun singularity exec --nv  --overlay $SCRATCH/overlay2/overlay-50G-10M.ext3:ro   /scratch/work/public/singularity/cuda11.1-cudnn8-devel-ubuntu18.04.sif /bin/bash -c "
cd
source /ext3/env.sh
conda activate
cd /home/tw2112/codes/s2s/aux_with_neg_wiki/cool_test
python test.py
"

Expected behavior
all process start
Environment

CUDA:
- GPU:
- NVIDIA Quadro RTX 8000
- NVIDIA Quadro RTX 8000
- NVIDIA Quadro RTX 8000
- NVIDIA Quadro RTX 8000
- available:         True
- version:           11.1
Packages:
- numpy:             1.21.2
- pyTorch_debug:     False
- pyTorch_version:   1.8.1
- pytorch-lightning: 1.4.9
- tqdm:              4.62.2
System:
- OS:                Linux
- architecture:
- 64bit
- ELF
- processor:         x86_64
- python:            3.8.5
- version:           #1 SMP Fri Oct 16 13:38:49 EDT 2020

this is the environment output of one node.

Hi, I have the same issue. Could you help me please?

@ElderWanng Hey, I have the same issue. Could you fix this issue? Any advice on how to fix it?

Hey, please check our docs for how to run on slurm.
You are not setting the number of nodes in slurm. It assumes 1 by default. The number of nodes and ntasks per node settins in slurm must match the num_nodes and gpus in the Trainer.

It appears to be another reason for the problem but I am not able to find what is it. I am executing a dummy code:
'''
This codes creates a simple one hidden layer neural network to be trained
with a dummy dataset. The network is trained with Trainer from Pytorch Lightning
'''

import os
import torch
import torch.nn as nn
import pytorch_lightning as pl

class Dataset(torch.utils.data.Dataset):
    def __init__(self):
        self.x = torch.arange(-1, 1, 0.02)
        self.y = 3 * self.x + torch.randn(self.x.size()) * 0.33

    def __getitem__(self, index):
        return self.x[index], self.y[index]

    def __len__(self):
        return self.x.size(0)

# Create a simple neural network
class Net(pl.LightningModule):
    def __init__(self):
        super().__init__()
        self.fc1 = nn.Linear(1, 10)
        self.fc2 = nn.Linear(10, 1)

    def forward(self, x):
        x = self.fc1(x)
        x = self.fc2(x)
        return x

    def training_step(self, batch, _):
        x, y = batch
        y_hat = self(x)
        loss = nn.functional.mse_loss(y_hat, y)
        self.log('train_loss', loss)
        return loss

    def configure_optimizers(self):
        return torch.optim.Adam(self.parameters(), lr=0.02)

# Create train and test dataloaders
train_loader = torch.utils.data.DataLoader(Dataset(), batch_size=64)

# Some prints that might be useful
print('SLURM_NTASKS =', os.environ['SLURM_NTASKS'])
print('SLURM_TASKS_PER_NODE =', os.environ['SLURM_TASKS_PER_NODE'])
print('SLURM_GPUS_PER_NODE =', os.environ['SLURM_GPUS_PER_NODE'])
print('SLURM_NNODES =', os.environ['SLURM_NNODES'])

# Create a model
model = Net()

# Create a trainer
trainer = pl.Trainer(max_epochs=10, gpus=2, num_nodes=4, strategy="ddp")

# Train the model
trainer.fit(model, train_loader)

And the code gets stuck:
Multiprocessing is handled by SLURM.
GPU available: True, used: True
TPU available: False, using: 0 TPU cores
IPU available: False, using: 0 IPUs
HPU available: False, using: 0 HPUs
Initializing distributed: GLOBAL_RANK: 0, MEMBER: 1/8

Just in case I was doing something wrong I printed the global variables indicated in the code above and the result was:
SLURM_NTASKS = 8
SLURM_TASKS_PER_NODE = 2(x4)
SLURM_GPUS_PER_NODE = volta:2
SLURM_NNODES = 4

As you can see num_nodes is equal to the number of nodes requested in SLURM and the SLURM_TASKS_PER_NODE is equal to the gpus requested in the trainer. If I remove the num_nodes variables from the Trainer call, the code works but not as I would expect. The code only creates two processes (so I understand it is only using one node instead of the 4 requested).
Originally posted by @Naxel100 in https://github.com/Lightning-AI/lightning/issues/6206#issuecomment-1218733418

Hi, do you find a solution? I am having the same problem on the LSF platform.

Nope, finally I run the code in just one node.

The same thing happens to me. Did you try an older version of lightning?

I met the same issue and set the num_nodes=world_size,  devices = ntasks-per-node didn't work.  By the way, it is weird to set devices = ntasks-per-node. The --ntasks-per-node in slurm determines how many processes you can use for each node, which is highly related to data load speed. Setting it to the same as the devices means we can only create one process for each GPU, namely one single process for data load. It will disastrously impair the training speed. In this way, the ddp training would not be an accelerator but a decelerator.

Hi, I met the same issue these days and found the solutions with help from @awaelchli . I would like to share my experience. Hope it can help you.
I try to reiterate the errors and solutions step-by-step.
Context: I tried to train a model with "distributed data parallel (DDP)" strategy on a remote SLURM platform. At the same time, I also want to load training data in parallel. And, I need to use singularity as a container ( for convenient code transferring between different machines)

System:

torch:1.13.0
cuda:11.6
python:3.9
pytorch-lightning:1.8.6

The SLURM configuration:

   #!/bin/bash
    #SBATCH --time=00:20:00
    #SBATCH --job-name=test_ddp
    **#SBATCH --ntasks-per-node=4**
    **#SBATCH --cpus-per-task=8**
    #SBATCH --gres=gpu:v100l:4
    #SBATCH --mem=0
    #SBATCH --nodes=1
    #SBATCH --output=./output/%x.out

Notes: the --ntasks-per-node has to be equal to devices, --nodes = num_nodes

How to execute with singularity:
srun --mpi=pmi2 singularity exec --nv -B /bind/path image.sif python test_ddp.py
OR
srun singularity exec --nv -B /bind/path image.sif python test_ddp.py

[> To run jobs across nodes with MPI requires:

Ensuring your MPI program is compiled using the OpenMPI installed inside your Singularity container.
Ideally the version of OpenMPI inside the container is version 3 or 4. Version 2 may or may not work. Version 1 will not work.
Ensure the MPI installation in the container can use the same process-management interface library as the MPI version on the cluster, e.g. PMI-2 or PMIx.
Ensuring your SLURM job script uses srun to run the MPI program, and have srun use a pmi library that is supported by the MPI implementation in the container. Do not use mpirun or mpiexec, e.g.,](https://docs.alliancecan.ca/wiki/Singularity#Running_MPI_programs_from_within_a_container)

Trainer setting:
Trainer(max_epochs=1, **num_nodes=1**, devices = 4, accelerator='gpu', strategy = 'ddp')
Notes: the --ntasks-per-node has to be equal to devices, --nodes = num_nodes

Dataloader setting:DataLoader(
            self.dataset,
            **num_workers=self.args.num_workers**,
            batch_size=self.args.configs.train.batch_size,
            shuffle=True,
            pin_memory=True,
            prefetch_factor = self.args_D.prefetch_factor,
        )

Notes: num_workers <=cpus-per-task
Bugs record

Get stuck at:
````
GPU available: True (cuda), used: True
TPU available: False, using: 0 TPU cores
IPU available: False, using: 0 IPUs
HPU available: False, using: 0 HPUs
/opt/conda/lib/python3.9/site-packages/pytorch_lightning/loops/utilities.py:94: PossibleUserWarning: max_epochs was not set. Setting it to 1000 epochs. To train without an epoch limit, set max_epochs=-1.
rank_zero_warn(
Initializing distributed: GLOBAL_RANK: 0, MEMBER: 1/4
```

Solution: 1) set  --ntasks-per-node = devices, --nodes = num_nodes_, 2) srun singularity exec train.py

Get stuck at dataloading

Solution: make num_workers <=cpus-per-task
Notes: The default value for  the cpus-per-task is 1,  for the num_workers it is 2,  if  cpus-per-task  is not explicitly set, it would easily get stuck.