feat: Redesign Identity dialog

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type

[ ] Bugfix
[x] Feature
[ ] Refactoring

Context

[x] Closes #4751

Did your issue had any of the "$" label on it?

[x] Fill up your DOT address: Payout

Community participation

[x] Are you at KodaDot Discord?

Screenshot 📸

[ ] My fix has changed something on UI;

Copilot Summary

🤖 Generated by Copilot at 8dcca7f
This pull request adds a new feature for users to upload an avatar image and select a social tab for their profile, and improves the UI and reusability of some components. It updates the IdentityForm component, renames and refactors the TransferTokenTabs component to PillTabs, and uses it in the Transfer component. It also creates a new NeoUpload component that extends the oruga upload component with a rounded option, and fixes the translation for the identity set message.

🤖 Generated by Copilot at 8dcca7f

We're sailing on the neo network, me hearties
We're uploading our avatars and profiles
We're using PillTabs for our tokens, me hearties
Heave ho, heave ho, on the count of three

Hey @hassnian just saw that you started coding this feature, I wanted to know before you wasted time about your solution on how to store Identity image?

please let me know , bcz I feel I'm might be missing something
there's a field called image

and assume that takes a IPFS url

please let me know , bcz I feel I'm missing something
there's a field called image

Alright! Looks good will it be on AssetHub Polkadot or Kusama? (or both)

and assume that takes a IPFS url

are we sure about that? maybe base64 image?
If I recall, we are limited at 32chars for each identity fields. did you see something like this?

please let me know , bcz I feel I'm missing something
there's a field called image

Alright! Looks good will it be on AssetHub Polkadot or Kusama? (or both)

from what I can see both have it

and assume that takes a IPFS url

are we sure about that? maybe base64 image? If I recall, we are limited at 32chars for each identity fields. did you see something like this?

yep i was checking some code and it seems its base64

32chars

yep

@roiLeo so as you mentioned this 32chars is an issue dont know how can we save the image,  ifps cid/hash is also long,
can't find any references to how others have done it , tried looking via the indexers image !== null and no results
any thoughts ?

@roiLeo so as you mentioned this 32chars is an issue dont know how can we save the image, ifps cid/hash is also long,
can't find any references to how others have done it , tried looking via the indexers image !== null and no results
any thoughts ?

Here is how it's done on Singular (rmrk)
I don't really know if anyone has managed to set an image on this image identity field.

@roiLeo so as you mentioned this 32chars is an issue dont know how can we save the image, ifps cid/hash is also long,
can't find any references to how others have done it , tried looking via the indexers image !== null and no results
any thoughts ?

Here is how it's done on Singular (rmrk) I don't really know if anyone has managed to set an image on this image identity field.

hmm I see , after spending more time with this I can't come up with a solution using a onchain and uploading images
using the hash and then getting the nft image it's straight forward , can we move head with this solution ?
user can select one nft that he owns, that becomes his avatar
I guess we can use  the "additional" field to store the image as it's already done on Singular
wdyt @roiLeo

using the hash and then getting the nft image it's straight forward , can we move head with this solution ?
user can select one nft that he owns, that becomes his avatar , type img , video
I guess we can use the "additional" field to store the image as it's already done on Singular
wdyt @roiLeo

If it's blocking for you we can hide image input for now and resolve it later.
Personally, I'd be more interested in having something unified with singular.
2nd solution: nothing can't stop us from having a self hosted backend where we could store user image.

@EthVlad pls visual check
so as discussed , no image upload atm, I like  what @roiLeo said

Personally, I'd be more interested in having something unified with singular.

we will need a ui/design for this , nft selector,
or we can

2nd solution: nothing can't stop us from having a self hosted backend where we could store user image.

personally I also like the first option , either way we need a follow up task
@roiLeo one question the field riot should that go under socials ? also is that referecing this
I'm asking because I need an icon if it's a social or should that go as a sperate field like the others , email , name etc

@roiLeo one question the field riot should that go under socials ? also is that referecing this , first time hearing about it
I'm asking because I need an icon if it's a social or should that go as a sperate field like the others , email , name etc

Yeah it's a social but I don't see it in new Figma design we can do without

@daiagi fixed all comments

Yeah it's a social but I don't see it in new Figma design we can do without

discord and twitter is it, I am thinking about adding maybe a telegram?

can't set identity on ahk,ahp

cant? And would it be possible in feature?

I think we can remove it from the profile sidebar for now if it's not possible aaaand when you switch the network when you are on the page, It will redirect to landing/switchednetwork

Feedback
There are a few little things here

button font size -> 16px

remove the shadow from the confirmation dialog button
if you want you can reuse the top part of the confirmation modals for buying.
like this:

I believe follow-up from @EthVlad will make these modals even more consistent with the rest of the app
nice job sir! 🚀

cant? And would it be possible in feature?

yes can't. it can't be done via polkdot portal
https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Fpolkadot-rpc.dwellir.com#/accounts
as for the future. idk

@daiagi fixed all , let's try again 🤞

oh ic https://github.com/kodadot/nft-gallery/pull/7294#discussion_r1336791113, yep

no x-mark here, have a look at other modals please
otherwise works for me, thanks

no x-mark here, have a look at other modals please
otherwise works for me, thanks

just fixed it ;D

dark/white mode ✔
Mobile looks good ✔
modal on desktop ✔
modal on mobile ✔
all my identity info got set on-chain:

https://kusama.subscan.io/account/FSMdmCLv5gFZ87YerB3M8ZSQ58BGHdSnreC4J6znWpqPQK9
0.333 KSM that i had deposited was kept there ✔

pay 70 usd

😍 Perfect, I’ve sent the payout
💵 $70 @ 4.08 USD/DOT ~ 17.157 $DOT
🧗 13QUj3pZyFNfYj4AM336hRdyLQbevj5H3sR4PKmLEXLdwZhh
🔗 0x5c1cf62504ca9018555c329ac6b15f60581b33375122e7cf578f918e5d9cc56a
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

let's resolve conflicts @hassnian so we can merge it

Hello, can you please resolve conflicts?

fixed merge conflicts

@roiLeo I see that you are changing v-model to :value on nuxt 3 also for modals, I've done the same here
https://github.com/kodadot/nft-gallery/pull/7294/commits/7e4e829b76764fbcffca592e1637162f2522f468
Is there any reason why we are not using v-model and changing the emit to update:modelValue ? so we have v-model working also
just , genuinely asking, if there is no specific reason I'd like to change  https://github.com/kodadot/nft-gallery/pull/7294/commits/7e4e829b76764fbcffca592e1637162f2522f468
so they work with v-model

@roiLeo I see that you are changing v-model to :value on nuxt 3 also for modals, I've done the same here 7e4e829
Is there any reason why we are not using v-model and changing the emit to update:modelValue ? so we have v-model working also
just , genuinely asking, if there is no specific reason I'd like to change 7e4e829 so they work with v-model

I think I got an answer https://github.com/kodadot/nft-gallery/pull/7422#pullrequestreview-1651669288

@roiLeo I see that you are changing v-model to :value on nuxt 3 also for modals, I've done the same here 7e4e829
Is there any reason why we are not using v-model and changing the emit to update:modelValue ? so we have v-model working also

v-model was throwing warning on these components, I changed that to :value and it was working.
if you can manage to make it work with v-model then let's go!

I think I got an answer #7422 (review)

yes could be related


Change generateFunc to satisfy catbox 3.x API.

The issue was introduce in #52. Somehow I did not catch this during testing.

Released in 0.16.1


Question: If the server is down, how to get a notification on the client?

Hello,
I created a client (WPF) and server (aspnetcore) sample to 'update' my old SignalR code. One requirement of my old code was to be able to know when the server is down (when the connection is closed).
I use the Microsoft.AspNetCore.SignalR.Client 1.0.0-preview1-24561 (.net 4.7).
The HubConnection.Closed event doesn't seem to work (or maybe I do not understand its purpose).
Is this the right way to achieve this?
Thanks,
Adrien.

Yes, the client should raise the Closed event when the connection is closed. If this does not work please provide more details so that we can reproduce and investigate.

Hello,
I tried again with the latest version (1.0.0-preview2-24979) and if I close the server before the client, I don't have the Closed event raised on the client.
this._connection = new HubConnection(new Uri(this._baseUrl));
this._connection.Connected += OnConnected;
this._connection.Closed += OnConnectionClosed;

The other Connected event is working properly.
What "more details" do you need? The code is very simple.
On the server I set up things like that:
app.UseSignalR(routes =>
{
        routes.MapHub<SystemManagerHub>("/mgmt");
});

public class SystemManagerHub : Hub
    { ... }

Please post a repro as a github repo and show how you close the server.

I use "CTRL-C" in VSCode.

It might be in the implementation of webSockets. I created an issue for this: https://github.com/dotnet/corefx/issues/19854

Please note that I have the issue in a WPF app (not UWP). When the SignalR server is closed the WPF client is still running (there is no exception thrown there).

@pellea - I was plannning to check other scenarios as well. Just hit the UWP case first. Stay tuned.

This has been fixed in cb9f44ddf6f1f5f4708016539ad66841c23c1be2


karmor: 0.13.16 -> 0.14

Description of changes
change log: https://github.com/kubearmor/kubearmor-client/releases/tag/v0.14
diff: https://github.com/kubearmor/kubearmor-client/compare/v0.13.16...v0.14

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 260184 run on x86_64-linux 1

1 package built:

karmor


The status of some sensors is not translated

DONT'T DELETE THIS.
Please answer all questions as good as possible.
Make sure you have read the documentation at https://github.com/danielperna84/custom_homematic#custom_homematic.
Make sure you are running the latest version of hahomematic or it's custom_component (and Home Assistant) before reporting an issue.
custom_component/hahomematic version (if applicable):
1.8.6
Home Assistant version (if applicable):
2022.6.7
CCU version:

Model (CCU2/3, Raspi3/4, NUC, ProxmoxVE, ...): VM
OS (Original, RaspberryMatic, debmatic/...): RaspberryMatic
Version:  <IP_ADDRESS>20521

Problem-relevant configuration:
Do you use tls? n
Do you use callback? n
Do you use username and password? y
Which interfaces do you use? BidCoS-RF
Describe the bug
A clear and concise description of what the bug is.
I'm using 6 pcs of HM-Sec-RHS. The state of 5 of them is translated to german, the state of one of them is not. I have no idea why.
I've tested with FF/Win, Chrome/Win and Android Companion App.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Screenshots (if applicable)

CCU firewall
integrations view
device view
enity view

Relevant HA log entries (full log)

Diagnostic Information (available on every device)
{
  "home_assistant": {
    "installation_type": "Home Assistant OS",
    "version": "2022.6.7",
    "dev": false,
    "hassio": true,
    "virtualenv": false,
    "python_version": "3.9.12",
    "docker": true,
    "arch": "x86_64",
    "timezone": "Europe/Berlin",
    "os_name": "Linux",
    "os_version": "5.15.45",
    "supervisor": "2022.05.3",
    "host_os": "Home Assistant OS 8.2",
    "docker_version": "20.10.14",
    "chassis": "vm",
    "run_as_root": true
  },
  "custom_components": {
    "dwd_weather": {
      "version": "1.2.22",
      "requirements": [
        "simple_dwd_weatherforecast==1.1.5",
        "markdownify==0.6.5"
      ]
    },
    "homematicip_local": {
      "version": "1.8.6",
      "requirements": [
        "hahomematic==1.8.6"
      ]
    },
    "xiaomi_cloud_map_extractor": {
      "version": "v2.2.0",
      "requirements": [
        "pillow",
        "pybase64",
        "python-miio",
        "requests",
        "pycryptodome"
      ]
    },
    "scheduler": {
      "version": "v0.0.0",
      "requirements": []
    },
    "hacs": {
      "version": "1.25.5",
      "requirements": [
        "aiogithubapi>=22.2.4"
      ]
    },
    "onkyo": {
      "version": "2021.10.5",
      "requirements": [
        "onkyo-eiscp==1.2.7"
      ]
    },
    "frontier_silicon": {
      "version": "2022.3.3",
      "requirements": [
        "afsapi==0.2.3rc2"
      ]
    },
    "smartthinq_sensors": {
      "version": "0.23.2",
      "requirements": [
        "pycountry>=20.7.3",
        "xmltodict>=0.12.0",
        "chardet>=4.0.0"
      ]
    },
    "presence_simulation": {
      "version": "1.18",
      "requirements": []
    },
    "browser_mod": {
      "version": "1.5.3",
      "requirements": []
    },
    "fontawesome": {
      "version": "2.1.5",
      "requirements": []
    },
    "emulated_hue": {
      "version": "2022.4.0",
      "requirements": [
        "aiohttp_cors==0.7.0"
      ]
    },
    "mass": {
      "version": "2022.6.6",
      "requirements": [
        "music-assistant==1.4.7"
      ]
    },
    "simpleicons": {
      "version": "v2.0.0",
      "requirements": [
        "simpleicons==6.16.0"
      ]
    }
  },
  "integration_manifest": {
    "domain": "homematicip_local",
    "name": "Homematic(IP) Local",
    "config_flow": true,
    "documentation": "https://github.com/danielperna84/custom_homematic",
    "issue_tracker": "https://github.com/danielperna84/hahomematic/issues",
    "requirements": [
      "hahomematic==1.8.6"
    ],
    "ssdp": [
      {
        "manufacturer": "EQ3",
        "manufacturerURL": "http://www.homematic.com"
      }
    ],
    "zeroconf": [],
    "homekit": {},
    "dependencies": [],
    "codeowners": [
      "@danielperna84",
      "@SukramJ"
    ],
    "iot_class": "local_push",
    "loggers": [
      "hahomematic"
    ],
    "version": "1.8.6",
    "is_built_in": false
  },
  "data": {
    "config": {
      "entry_id": "35822aacb390d7028935d6c727a3c230",
      "version": 1,
      "domain": "homematicip_local",
      "title": "ccu",
      "data": {
        "instance_name": "ccu",
        "host": "de838cd8-raspberrymatic",
        "username": "**REDACTED**",
        "password": "**REDACTED**",
        "tls": false,
        "verify_tls": false,
        "callback_host": null,
        "callback_port": null,
        "json_port": null,
        "interface": {
          "BidCos-RF": {
            "port": 2001
          },
          "HmIP-RF": {
            "port": 2010
          }
        }
      },
      "options": {},
      "pref_disable_new_entities": false,
      "pref_disable_polling": false,
      "source": "user",
      "unique_id": "<IP_ADDRESS>",
      "disabled_by": null
    },
    "platform_stats": {
      "binary_sensor": 57,
      "climate": 6,
      "light": 4,
      "sensor": 27,
      "switch": 14
    },
    "devices": [
      "HM-CC-TC",
      "HM-CC-VD",
      "HM-LC-Dim1PWM-CV",
      "HM-LC-Dim1T-FM",
      "HM-LC-Sw1-FM",
      "HM-LC-Sw1-Pl",
      "HM-LC-Sw2-FM",
      "HM-PB-4-WM",
      "HM-PB-6-WM55",
      "HM-PBI-4-FM",
      "HM-RC-12",
      "HM-SCI-3-FM",
      "HM-Sec-RHS",
      "HM-Sec-SCo",
      "HM-Sec-SD-2",
      "HM-Sec-SD-2-Team",
      "HM-Sen-MDIR-SM",
      "HM-Sen-MDIR-WM55"
    ]
  }
}

Expected behavior
A clear and concise description of what you expected to happen.
I'd expect to see "Geschlossen" instead of "closed".
Additional context
Add any other context about the problem here.

Good question.
These sensors should have the custom device_class homematicip_local__srh.
Please check this under development tools -> States.
Whats the state if it is tilted?

Attributes of sensor.az_fg_fenster_state:
interface_id: ccu-BidCos-RF
address: GEQ0129289:1
model: HM-Sec-RHS
function: Verschluss
parameter: STATE
entity_type: generic
device_class: homematicip_local__srh
icon: mdi:window-closed
friendly_name: Az Fenster
window_room: az

Attributes of sensor.wz_fg_tuer_state:
interface_id: ccu-BidCos-RF
address: IEQ0044928:1
model: HM-Sec-RHS
function: Verschluss
parameter: STATE
entity_type: generic
device_class: hmip_local__srh
icon: mdi:window-closed
friendly_name: Wz Tür
window_room: wz

Tilted windows:

Az Fenster has Firmware 1.9, all others have Firmware 2.0.

That did the trick! Thanks a lot!


Remove unsafe conversion for PCWSTR

As @michaelwoerister pointed out this conversion, while safe, makes it very easy to write incorrect code. I think we should avoid such code.
Here's an example of some code that uses safe Rust but creates a dangling pointer:
fn create_dangling_pcwstr_pointer() -> PCWSTR {
    let s = HSTRING::from("abc");
    PCWSTR::from(&s)
}

Yes, this does indeed look like a potential source of errors to me.
Overall, I don't know of a good way of dealing with PCWSTR and similar string types that are essentially raw pointers with no ownership or lifetime guarantees attached.

This has come up before (#2084). In this case, we caught it with App Verifier which does a great job of detecting such errors.
I'm just not sure simply removing the impl is sufficient since we still need a way to perform such a conversion.

This is also related to #907 and #1896 where we really need to track lifetime even in cases where ownership is ambiguous.

In this case, perhaps its preferable to be explicit and require something like this (from the build break)?
        let vertex_shader = unsafe {
            D3DCompileFromFile(
                PCWSTR(shaders_hlsl.as_ptr()),
                None,
                None,

In this case, perhaps its preferable to be explicit and require something like this (from the build break)?
        let vertex_shader = unsafe {
            D3DCompileFromFile(
                PCWSTR(shaders_hlsl.as_ptr()),
                None,
                None,

That does look better to me, yes.
An explicit to_pcwstr() method might also make sense. It could be safe, like e.g. Vec::as_ptr() is safe, but would serve as a place where documentation about safety/lifetime can be added -- but I hesitate to suggest adding ad-hoc convenience methods like this without an overall design strategy for strings and/or win32 raw-pointers.

but I hesitate to suggest adding ad-hoc convenience methods like this without an overall design strategy for strings and/or win32 raw-pointers

Right, once the overall ownership story has been sorted out, see also https://github.com/microsoft/windows-rs/issues/2126#issuecomment-1304686765, this should be a lot clearer. Until then, I'm happy to require PCWSTR(from.as_ptr()).


TNO-2141: Allow users to enter tags from text area in advanced search

Ignore GIF quality using ffmpeg and having driver issues...
Allow users to enter tags from text area in advanced search

fixes bug causing app to crash when [ is entered
can enter [tag] in text area to add valid tag, will automatically make uppercase if not already

Working on one more thing - leaving on draft.

@Fosol - it doesn't actually save it to the query it removes them before storing it to the search, its just an additional way for the user to add tags as per TNO-2141. I can scrap the changes if we want though


Rerun of workflows took significantly longer time.

Dear Farmvibes Team,
When I attempted to rerun the workflow in timelapse_visulization notebook, it took more than an hour to complete.
Earlier same entire workflow only takes less than 5 minutes to rerun.
Attached to this issue, you will find the following files for your reference:
log files for:

terravibes-worker
terravibes-orchestrator

You might also need these details:

file system used : Root filesystem is used and is formatted with the "ext4" filesystem type.
No of entries under the ~/.cache/farmvibes-ai is 205735.

log_files.zip

Hello, @click2cloud-sagarB. Thank you for raising this issue and sharing the logs. We have investigated the increase in timeouts since last release's migration to async.io. We have improved the stability of the cluster and haven't experienced similar issues internally. The fix will be available on the next release.

Thank you @rafaspadilha, I'm glad to hear that the stability of the cluster has been improved, and you haven't encountered similar issues internally. Looking forward to the next release with the fix.

Hi, @click2cloud-sagarB. Are you still experiencing this issue?

Hi @rafaspadilha. We are unable to estimate the time required for a complete rerun of workflows since rerun of complete workflow fails due to Cache Retrieval Errors in Workflows since the most recent commit (issue 121).

Thanks for letting us know. We are working on fixing #121 and will keep you updated.

Hi, @click2cloud-sagarB. We have just released a new version of FarmVibes fixing the caching issues reported on #121 . Please, could you verify if the problem was solved?

Closing this issue, as @click2cloud-sagarB reported offline that it was fixed after the release.


fix #1350349 cannot input chinese characters when adding text

fix #1350349 cannot input chinese characters when adding text
While we focus on the Canvas, the input method will not be able to changed, and imContext itself supports changing input method. So we need to grab focus for imContext, then make sure imContext can change input method.
While making imContext grabs focus, we also need to give right time to RedrawText, if RedrawText at a not proper time, the input method will chnage but the result of inputing Text will give a unacceptable performance.
So this commit will grab focus for imContext and RedrawText at right time.

I have changed the code, pls review again, thank you.

Hello,cameronwhite.
You can see me new commit, it seems well solved our worries. It seems work well in my computer.

Thanks! This works much better 👍
The only issue I've noticed is that the cursor line remains visible after pressing Esc to finish editing. I'm wondering if the redraw in OnKeyUp() can just be removed now that we're back to redrawing on key down? Removing it seems to fix the issue in my testing

Hi,  cameronwhite.
I have removed the the redraw in OnKeyUp(), it seems OK. Pls help to check it.


do not expose SHAREVDE datasets in Sinopia Search

Sinopia Search dropdown has a bunch of old SHAREVDE datasets. Do not show those anymore.

good idea to clean out authorityConfig but is there a way to check if any templates (in any environment) are using those in a lookup?

Thanks for checking. Don’t want to break any existing templates so I would leave.

From: Justin Coyne @.>
Sent: Tuesday, November 2, 2021 11:27:38 AM
To: LD4P/sinopia_editor @.>
Cc: Justin Littman @.>; Mention @.>
Subject: Re: [LD4P/sinopia_editor] do not expose SHAREVDE datasets in Sinopia Search (Issue #3275)
@justinlittmanhttps://github.com/justinlittman How about authorityConfig.json? Clean those out too?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/LD4P/sinopia_editor/issues/3275#issuecomment-957822496, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAEPUL4DULQJJZDNINOTHH3UKAGPVANCNFSM5G7XJD3Q.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


Refactoring hiredis reader parser outside of the other code

In attempt to make it easier to port the reader parser code that is used in hiredis-py (and other languages) to other OS like Windows, I've decided to factor out all this specific code outside of the other hiredis code into seperate files.
The effort shows this is feasible and makes porting to Windows much more easier:
https://github.com/tzickel/hiredis/tree/reader_refactor
(I've mainly split hiredis.c/.h into read.c/.h and hiredis.c/.h)
The question now is on which version of hiredis to concentrate the full porting efforts (if the official release has the reader parser code refactored outside, it will be easier to patch it on updates).
The hiredis-py official version links to an hiredis version from 2 years ago. The question is are there any plans to update the hiredis version there any time soon, if so, I would move to do the refactoring on the master branch, otherwise I can continue working on that branch).
BTW atleast in that 2 years ago version there is a few issues mainly involving void * pointer arithmetic, percision lost in the case of putting "long long" variables into "long", etc...

Works for me.
I've brought in https://github.com/tzickel/hiredis/commit/05060680859ea91c7f1e28365c214e0dd592160d (and cleaned up merge conflicts against newer code) into the next maint release.
Breaking out the reader functions doesn't change any existing behavior and it gives external users more flexibility for reuse.


⚠ Bofrost.lu has degraded performance

In 3686c8a, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1078 ms

Resolved: Bofrost.lu performance has improved in 58e49e0 after 13 minutes.


Given Instructions do Not Work

The instructions in this page do not work as given. Trying a POD in step 5 with the given YAML results in the following error.
Error from server (BadRequest): error when creating "pod.yaml": Pod in version "v1" cannot be handled as a Pod: json: cannot unmarshal object into Go struct field PodSpec.spec.containers of type []v1.Container

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: ec9ff712-aa4c-4e95-ba96-2405010d9f83
Version Independent ID: f553a5a4-a20f-8efd-3712-e64112c35676
Content: Provide an access identity to the Azure Key Vault Provider for Secrets Store CSI Driver for Azure Kubernetes Service (AKS) secrets - Azure Kubernetes Service
Content Source: articles/aks/csi-secrets-store-identity-access.md
Service: azure-kubernetes-service
GitHub Login: @Nickomang
Microsoft Alias: nickoman

@cliffjohns-progenity
Thanks for your feedback! We will investigate and update as appropriate.

@cliffjohns-progenity
I'm sorry to hear that you're encountering an error with the instructions provided in the document.The error message you received suggests that there is an issue with the YAML file for the pod.
To help you better, could you please provide the YAML file that you are using for the pod? It's possible that there is a syntax error or other issue with the file that is causing the error.
In the meantime, I would recommend double-checking the YAML file to ensure that it is properly formatted and that all required fields are included. You can refer to the Kubernetes documentation for more information on how to create a pod YAML file: https://kubernetes.io/docs/tasks/configure-pod-container/define-container-environment-variable/#create-a-pod.
Please let me know if you have any further questions or if there's anything else I can help you with.

It the YAML that is given in step 5 of the content source that is the subject of this ticket.  After further review, I noticed that "name" in the "containers" section of the YAML has a syntax error.  It should be preceded by a hyphen.  Can someone update the article?
********** incorrect **********
containers:
name: busybox

********** correct **********
containers:
- name: busybox

This is a sample pod definition for using SecretProviderClass and the user-assigned identity to access your key vault
kind: Pod
apiVersion: v1
metadata:
name: busybox-secrets-store-inline-user-msi
spec:
containers:
name: busybox
image: registry.k8s.io/e2e-test-images/busybox:1.29-4
command:
- "/bin/sleep"
- "10000"
volumeMounts:
- name: secrets-store01-inline
mountPath: "/mnt/secrets-store"
readOnly: true
volumes:
- name: secrets-store01-inline
csi:
driver: secrets-store.csi.k8s.io
readOnly: true
volumeAttributes:
secretProviderClass: "azure-kvname-user-msi"

@cliffjohns-progenity
Thanks for reporting this! We have created a PR for this issue and the changes should go live soon.


Reusable middleware setup for games

For https://github.com/PaimaStudios/paima-engine/pull/196 we created a fix for games that want a special router to define which security namespaces to use for their app.
However, the way things are setup currently required us to add special code for handling the router in the middleware build script of tower-defense (https://github.com/PaimaStudios/tower-defense-backend/pull/120)
It should not be required to have this code in Tower Defense because paima-mw-core was made exactly for this reason (see this file specifically: https://github.com/PaimaStudios/paima-engine/blob/a0987398bbd6ad67280de28b6825c4ef3b240d25/paima-mw-core/)
We should refactor Tower Defense (and any other template / game) to be able to re-use paima-mw-core

Solved in the 1.1.0 release


Add Detail View for Steps

Clicking on a step in the visualization canvas should display properties available for it. In the future, these properties will be editable.

As good as it's gonna get for now..


Dashboard template 'mdl-menu__container' style issue.

Once you click the down arrow next to<EMAIL_ADDRESS>inside the drawer, the links container that it over shadows while shown stops working after its hidden, "Home, Inbox" links on drawer are now unresponsive, if you bring mouse to the border on right side of drawer then it works.

Cheers, looks like that ones already reported, #1025 was also mentioned in #1290

Yup, @SeanBannister is right, duplicate of #1025. Thanks for reporting, though :)

Thanks @surma & @SeanBannister, keep up good work on MDL and documentation/Demo would be helpful.


Fix of dev scripts and new, Criteo specific, ones WIP

Can one of the admins verify this patch?

Sorry created by mistake


Partial error message

Why the line
responseMessage = responseMessage.substring(3);

on line 65? It chops the first three characters of the error output, which makes it incomplete.

Sorry for the delay. I do this because Mailchimp returns a message with numbers, so i had to strip out the first 3 characters. With the 1.0.5 version i fixed this issue.


metamask gas price

Proposed changes
metamask gas price
Types of changes
Please put an x in the boxes related to your change.

[x] Minor Issues and Typos
[ ] Major Content Contribution
[ ] Others

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to reach out. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[ ] I have read the CONTRIBUTING GUIDELINES
[ ] I have signed the CLA
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

Related issues

Please leave the issue numbers or links related to this PR here.

Further comments
If this is a relatively large content contribution, kick off the discussion by explaining why you would suggest the content contribution, etc...

Thank you! The document is saying gas fee is 750, but the image use 25 for the setting. Can I give you another image with 750 configuration?

Sure!


[FEATURE] Determine how to add env vars to heroku review apps

create-react-app allows environment variables included in a .env file prefixed with REACT_APP_ to be used within the app. Determine how to provide these environment variables to review apps.
Describe the solution you'd like
There is more information in the documentation: https://github.com/tonystarktech/create-react-app-buildpack#user-content-environment-variables
Consideration will need to be made on buildtime vs runtime env vars.
Describe alternatives you've considered
No alternatives considered at this point.
Additional context
This will be used to include environment variables such as mapbox access details, API URLs and API keys.

For this, we can use Heroku's Platform API as mentioned here:
$ curl -n -X PATCH https://api.heroku.com/apps/$APP_ID_OR_NAME/config-vars \
  -d '{
  "FOO": "bar",
  "BAZ": "qux"
}' \
  -H "Content-Type: application/json" \
  -H "Accept: application/vnd.heroku+json; version=3"

But the env var has to be set on Github as repo environment variables.

There seems to be a lot for create-react-app-buildpack.
Based on GH starts, we probably wanted to use this

https://elements.heroku.com/buildpacks/mars/create-react-app-buildpack
instead of
@JBurkinshaw


JSON Array handling for push_transactions action

Describe the bug

EOSIO HTTP chain api push_transactions action requires JSON Array for request body.
but filter.go assumes that vaild JSON is only object not array.
affected functions: validateTransactionSize, validateMaxSignatures, validateContract in filter.go

To Reproduce
Use JSON Array for request body below:
'[{"code":"currency","type":"transfer","recipients":["initb","initc"],"authorization":[{"account":"initb","permission":"active"}],"data":"000000000041934b000000008041934be803000000000000"}]

or
'[{"code":"currency","type":"transfer","recipients":["initb","initc"],"authorization":[{"account":"initb","permission":"active"}],"data":"000000000041934b000000008041934be803000000000000"}, {"code":"currency","type":"transfer","recipients":["initb","initc"],"authorization":[{"account":"initb","permission":"active"}],"data":"000000000041934b000000008041934be803000000000000"}]

Then, got error like this:
2018/06/02 17:56:05 <IP_ADDRESS>:42106 false PARSING_ERROR

Expected behavior

Like nodeos when request comes with JSON array, patroneos should map json array into individual transactions and validate them.

Version (please complete the following information):

OS: ubuntu 18.04 LTS
Patroneos Version : 48422fa05b47373ad68013f4d77d290e7fc31aae

References

https://developers.eos.io/eosio-nodeos/reference#push_transactions
https://github.com/EOSIO/eosjs-api/blob/master/src/api/v1/chain.json

Thanks for the detailed report, someone will look into this as soon as possible.

Howdy!
Just checking back in on this one to see where it is in the priority queue.
Thanks so much!

@jeffreyssmith2nd if this is a valid solution I can implement it and open a PR; apparently the ability for encoding/json to work on arrays has been broken since late 2017 https://stackoverflow.com/questions/22128282/easy-way-to-check-string-is-in-json-format-in-golang/36922225#36922225

That may be a solution, but parsing error is throw on line 142 so I think it probably is an issue with the unmarshaling of the json around line 140.

@jesseproudman and @redjade We've pushed a fix for this, it will be included in the next release.

@chris-allnutt Thanks so much!


Provide compatibility with IE11 for source maps.

Hello Dan-el,
IE11 can now use source maps (well, since last year). However it was not working with the file generated by SharpKit.
I have made some small changes to make it work, it is of course still compatible with Chrome and Firefox.
Basically I have included the source root at the beginning of every source file path.
It gives you something like that:
..."sourceRoot":"","sources":["SourceMaps.ashx/C:/Dev/Windows/Ja...
For what I have understood, IE looks at the value in the sourceroot property, but the fact that the file names starts with a drive name (i.e. C:/...) seems to confuse him.
I was actually trying to make the debugging works from within Visual Studio (it would have been great, don't you think?) but I couldn't achieve that.
If you remove completely the sourceroot content (just leaving the full path of the files), the browser cannot find anymore the source files but Visual studio does make the link when you start a debug session with IE. However, it does not allow to put a breakpoint in the cs files.
Maybe a bit more digging could do it, I'll try when I have time.
Regards,
Olivier

Very nice! Thanks!


incorrect changelog with repeating commits (due to missing tags?)

Potential fix is to create the missing tags in git:
https://github.com/conventional-changelog/standard-version/issues/509#issuecomment-675099097

@Morriz could not reproduce it while doing recent releases


Sponsorship

Is it possible to become sponsor of project and to place link of our product?
FancyGrid - JavaScript grid library for Enterprise
https://fancygrid.com

I'm going to assume that you aren't just pulling my leg ;-). The sponsorship options for DataTables are available here.

So this will be ok if we will purchase 99$ support support license?
I am wondering since we present competitive product to DataTables...
So I am not sure that you will accept our help.

I don't have any "moral" objection - I'm just somewhat surprised that you would want to sponsor the DataTables project! Most sponsors use DataTables in some way (unless you use it for your internal tools ;-) ).
In all seriousness, FancyGrid is a superb product and if you'd like to sponsor DataTables, it would be a great initial link between us.

Paid.
I am looking forward to see our logo between your supporters ;)

Its up on the supporters page now. Thanks!


Closed Stream

I am using Ruby 1.93p392 and the latest version of rails. When I save a picture from a form but manually like so:
@record.picture = params[:picture]
it saves fine. I see the image file in the dragonfly folder on my HD. However, after it is done, it throws an error: closed stream.

I've started getting this issue with latest version. I'm not using that gem though :(


Remove qe202 from the automation (SOC-10006)

QE202 got moved to the ECP so we should cleanup the automation code.

Should this(scripts/jenkins/cloud/ansible/host_vars/qe202.yml)  file be removed as well?


Take into account the ad cue points (server side only) in external text tracks

When an external subtitle track is added and you are using DAI, the external track does not take into account the ads that the video has, so this PR makes this internally take into account when generating the external track.

Note: for proper operation, you need to accept https://github.com/google/shaka-player/pull/3611 as well.

@joeyparrish can you review it?


Remove unused variables

Ok, this PR might go slightly too far. It removes unused variables. Some of them I assume were planning to be used, but their use hasn't been implemented yet. Others have maybe been forgotten about and will never be used.

Nope, these changes are fine. I was just focusing on higher priority stuff.
Some of the unused variables in TextField I hadn't gotten around to using after updating to the latest versions of NAS2D that didn't yet have clippers available. At some point I'll reimplement text fields that allow for scrolling back and forth.


Opening a matplotlib figure, causes kivy desktop app to shrink (size & font)

Software Versions

Python: 3.8.5
OS: win10
Kivy: 2.0.0rc3
Kivy installation method: pip

Describe the bug
When I call any of the matplotlib plotting routines, as the matplotlib figure is displayed, the Kivy desktop application shrinks in size (window size and font)
Expected behavior
The display of the matplotlib should not affect the size/font of the Kivy application.
To Reproduce
Please find the code below.
Code and Logs and screenshots
import kivy
from kivy.app import App
from kivy.uix.boxlayout import BoxLayout

import matplotlib.pyplot as plt

kivy.lang.Builder.load_string('''

<DataView>:

    orientation: 'vertical'
    spacing: 5
    padding: 5

    Label:
        text: 'HELLO WORLD'
''', filename='dataview.kv')

class DataView(BoxLayout):

    def __init__(self, **kwargs):
        super().__init__(**kwargs)

class TestApp(App):

    def build(self):
        DV = DataView()

        # Commenting/uncommenting this line causes the kivy application
        # font size / window size to change.
        fig, ax = plt.subplots(2, 2)

        return DV

if __name__ == '__main__':
    TestApp().run()

Additional context
Kivy debugging dump:
[INFO   ] [deps        ] Successfully imported "kivy_deps.gstreamer" 0.2.0
[INFO   ] [deps        ] Successfully imported "kivy_deps.glew" 0.2.0
[INFO   ] [deps        ] Successfully imported "kivy_deps.sdl2" 0.2.0
[INFO   ] [Kivy        ] v2.0.0rc3, git-20c14b2, 20200615
[INFO   ] [Kivy        ] Installed at "C:\Users\abed\anaconda3\lib\site-packages\kivy_init_.py"
[INFO   ] [Python      ] v3.8.5 | packaged by conda-forge | (default, Sep 16 2020, 17:19:16) [MSC v.1916 64 bit (AMD64)]
[INFO   ] [Python      ] Interpreter at "C:\Users\abed\anaconda3\python.exe"
[INFO   ] [Factory     ] 185 symbols loaded
[INFO   ] [Image       ] Providers: img_tex, img_dds, img_sdl2, img_pil (img_ffpyplayer, img_gif ignored)
[INFO   ] [Window      ] Provider: sdl2
[INFO   ] [GL          ] Using the "OpenGL" graphics system
[INFO   ] [GL          ] GLEW initialization succeeded
[INFO   ] [GL          ] Backend used
[INFO   ] [GL          ] OpenGL version <b'4.6.0 - Build <IP_ADDRESS>37'>
[INFO   ] [GL          ] OpenGL vendor <b'Intel'>
[INFO   ] [GL          ] OpenGL renderer <b'Intel(R) UHD Graphics 620'>
[INFO   ] [GL          ] OpenGL parsed version: 4, 6
[INFO   ] [GL          ] Shading version <b'4.60 - Build <IP_ADDRESS>37'>
[INFO   ] [GL          ] Texture max size <16384>
[INFO   ] [GL          ] Texture max units <32>
[INFO   ] [Window      ] auto add sdl2 input provider
[INFO   ] [Window      ] virtual keyboard not allowed, single mode, not docked
[INFO   ] [Text        ] Provider: sdl2
[INFO   ] [Base        ] Start application main loop
[INFO   ] [GL          ] NPOT texture support is available

Hello,
I have the same issue. I changed from garden.graph to matplotlib.
Since then the content of the main app is very small at startup.
Resizing the window solves the problem but for me it is not a suitable solution.
Got no errors or something similar.

Hi @MaxHausmann ,
yes, I still see the issue with Kivy v2.0.0rc4, python 3.8.6, and matplotlib version 3.3.3
In fact, I also noticed that the same effect happens when my application starts pandas profiling in the browser.
With matplotlib, I tried setting mpl.rcParams['figure.dpi'] to different DPI (from 60 to 300), and I continued to see the same effect.
Mainly that my main application window shrinks in size and font when a figure is displayed in a separate matplotlib window or in the browser.

I would suggest binding a function to the Window.size property, and putting a debugger in that function. I tried doing it, but it didn't hit here in linux, that might be windows specific.
import kivy
from kivy.app import App
from kivy.core.window import Window
from kivy.factory import Factory as F

kivy.lang.Builder.load_string('''
#:import plt matplotlib.pyplot
<DataView@BoxLayout>:
    orientation: 'vertical'
    spacing: 5
    padding: 5

    Label:
        text: 'HELLO WORLD'

    Button:
        text: 'hit me!'
        on_release: fig, ax = plt.subplots(2, 2)
''', filename='dataview.kv')

class TestApp(App):
    def build(self):
        Window.bind(size=self.debug)
        DV = F.DataView()

        # Commenting/uncommenting this line causes the kivy application
        # font size / window size to change.

        return DV

    def debug(self, *args):
        __import__('pdb').set_trace()

if __name__ == '__main__':
    TestApp().run()

and after pressing the button, the debugger should be triggered type u then enter, and repeat until arriving at code outside of kivy that triggers the window's resizing.

Thanks, @tshirtman, good idea.
I ran the above code, I get the normal screen/font size showing, then when I click the button, and as expected, the window/font size shrinks.
What is not expected, is that the debug method is never called, ( I also put a print inside). This implies that even though the window size is getting smaller, the actual window width and height (size) is not really changing - just the DPI I assume?
Thanks for any suggestion, I am happy to try more tests.

Just a quick update in case it can be useful to anyone.
Confirming a comment from @tshirtman (thank you), I installed the application on ubuntu 20.10, and all worked as expected. I don't see the behavior explained above.
I went back to windows 10, installed anaconda, then with conda I installed kivy 2.0:  the issue persists.
So it seems the problem is specific to Windows 10. Basically, anytime I open a matplotlib figure, my kivy app shrinks in size (without triggering any size change callback).
In both cases, I am running kivy 2.0, with python 3.8.6
Best wishes to all for the holidays - and a big thank you to the Kivy dev team - one year since I started using kivy and I like it very much.

If I were to guess, I'd guess that the matplotlib backend provider is calling into Windows to change the DPI awareness or something like that. You can see a somewhat related discussion https://github.com/kivy/kivy/issues/3705 about the effects of doing this.
I would try running matplotlib with different backends to see if it changes. Alternatively, change Kivy's density at startup (like in the example code there) and see if it looks ok after importing matplotlib.

Thanks, @matham for the pointer. I have not seen #3705 before. I will dig deeper and see what I can find/learn.

Thanks, @matham for the pointer. I have not seen #3705 before. I will dig deeper and see what I can find/learn.

I tried to replicate this problem but surprisingly I can't. I'm on Windows 10 (version 2004, build 19041.685), with kivy 2.0.0, matplotlib 3.3.3, and Python 3.7.1.
@abedhammoud, can you try to maximize the kivy window and re-try @tshirtman's suggestion to debug on the Window.size trigger? If the window is maximized, Window.size should change with the DPI change; otherwise it won't because the window shrinks as well. You'll get stuck in the debugger when you maximize the window, so just continue after that and open a matplotlib figure as before.

I tried to replicate this problem but surprisingly I can't. I'm on Windows 10 (version 2004, build 19041.685), with kivy 2.0.0, matplotlib 3.3.3, and Python 3.7.1.
@abedhammoud, can you try to maximize the kivy window and re-try @tshirtman's suggestion to debug on the Window.size trigger? If the window is maximized, Window.size should change with the DPI change; otherwise it won't because the window shrinks as well. You'll get stuck in the debugger when you maximize the window, so just continue after that and open a matplotlib figure as before.

@probablyfine is your windows display zoom setting set to 100%? i think the issue is only when it's to a different value.

@probablyfine is your windows display zoom setting set to 100%? i think the issue is only when it's to a different value.

Thank you both.
@probablyfine  I tried your recommendation on two win10 laptops and I still get the same effect. I am running Win10 Pro version 20H2, build 19042.685 with Kivy 2.0, matplotlib 3.3.3, and python  3.8.6 (and a zoom of 150%). Note that even with the window maximized, no Window.size event is fired when the window shrinks (after I click the button).
Following the comments of @tshirtman, I changed the zoom to 100%, and the shrinking stopped. I have not noticed that before, thanks @tshirtman.
thank you both for your help, really appreciated
Here is the log - I don't see anything special.
 I am running Win10 Pro version 20H2, build 19042.685 with Kivy 2.0, matplotlib 3.3.3, and python  3.8.6 (and a zoom of 150%). Note that even with the window maximized, no Window.size event is fired when the window shrinks (after I click the button).
Following the comments of @tshirtman, I changed the zoom to 100%, and the shrinking stopped. I have not noticed that before, thanks @tshirtman.
thank you both for your help, really appreciated
Here is the log - I don't see anything special.
[INFO   ] [Kivy        ] v2.0.0
[INFO   ] [Kivy        ] Installed at "C:\Users\abed\anaconda3\lib\site-packages\kivy\__init__.py"
[INFO   ] [Python      ] v3.8.6 | packaged by conda-forge | (default, Dec 26 2020, 04:30:06) [MSC v.1916 64 bit (AMD64)]
[INFO   ] [Python      ] Interpreter at "C:\Users\abed\anaconda3\python.exe"
[INFO   ] [Factory     ] 186 symbols loaded
[DEBUG  ] [Cache       ] register <kv.lang> with limit=None, timeout=None
[DEBUG  ] [Cache       ] register <kv.image> with limit=None, timeout=60
[DEBUG  ] [Cache       ] register <kv.atlas> with limit=None, timeout=None
[INFO   ] [Image       ] Providers: img_tex, img_dds, img_sdl2, img_pil (img_ffpyplayer ignored)
[DEBUG  ] [Cache       ] register <kv.texture> with limit=1000, timeout=60
[DEBUG  ] [Cache       ] register <kv.shader> with limit=1000, timeout=3600
[INFO   ] [Window      ] Provider: sdl2
[INFO   ] [GL          ] Using the "OpenGL" graphics system
[INFO   ] [GL          ] GLEW initialization succeeded
[DEBUG  ] [GL          ] available extensions: b'GL_3DFX_texture_compression_FXT1 GL_AMD_depth_clamp_separate GL_AMD_vertex_shader_layer GL_AMD_vertex_shader_viewport_index GL_ARB_ES2_compatibility GL_ARB_ES3_1_compatibility GL_ARB_ES3_compatibility GL_ARB_arrays_of_arrays GL_ARB_base_instance GL_ARB_bindless_texture GL_ARB_blend_func_extended GL_ARB_buffer_storage GL_ARB_cl_event GL_ARB_clear_buffer_object GL_ARB_clear_texture GL_ARB_clip_control GL_ARB_color_buffer_float GL_ARB_compatibility GL_ARB_compressed_texture_pixel_storage GL_ARB_compute_shader GL_ARB_conditional_render_inverted GL_ARB_conservative_depth GL_ARB_copy_buffer GL_ARB_copy_image GL_ARB_cull_distance GL_ARB_debug_output GL_ARB_depth_buffer_float GL_ARB_depth_clamp GL_ARB_depth_texture GL_ARB_derivative_control GL_ARB_direct_state_access GL_ARB_draw_buffers GL_ARB_draw_buffers_blend GL_ARB_draw_elements_base_vertex GL_ARB_draw_indirect GL_ARB_draw_instanced GL_ARB_enhanced_layouts GL_ARB_explicit_attrib_location GL_ARB_explicit_uniform_location GL_ARB_fragment_coord_conventions GL_ARB_fragment_layer_viewport GL_ARB_fragment_program GL_ARB_fragment_program_shadow GL_ARB_fragment_shader GL_ARB_fragment_shader_interlock GL_ARB_framebuffer_no_attachments GL_ARB_framebuffer_object GL_ARB_framebuffer_sRGB GL_ARB_geometry_shader4 GL_ARB_get_program_binary GL_ARB_get_texture_sub_image GL_ARB_gl_spirv GL_ARB_gpu_shader5 GL_ARB_gpu_shader_fp64 GL_ARB_half_float_pixel GL_ARB_half_float_vertex GL_ARB_indirect_parameters GL_ARB_instanced_arrays GL_ARB_internalformat_query GL_ARB_internalformat_query2 GL_ARB_invalidate_subdata GL_ARB_map_buffer_alignment GL_ARB_map_buffer_range GL_ARB_multi_bind GL_ARB_multi_draw_indirect GL_ARB_multisample GL_ARB_multitexture GL_ARB_occlusion_query GL_ARB_occlusion_query2 GL_ARB_pipeline_statistics_query GL_ARB_pixel_buffer_object GL_ARB_point_parameters GL_ARB_point_sprite GL_ARB_polygon_offset_clamp GL_ARB_post_depth_coverage GL_ARB_program_interface_query GL_ARB_provoking_vertex GL_ARB_query_buffer_object GL_ARB_robust_buffer_access_behavior GL_ARB_robustness GL_ARB_robustness_isolation GL_ARB_sample_shading GL_ARB_sampler_objects GL_ARB_seamless_cube_map GL_ARB_seamless_cubemap_per_texture GL_ARB_separate_shader_objects GL_ARB_shader_atomic_counter_ops GL_ARB_shader_atomic_counters GL_ARB_shader_bit_encoding GL_ARB_shader_draw_parameters GL_ARB_shader_group_vote GL_ARB_shader_image_load_store GL_ARB_shader_image_size GL_ARB_shader_objects GL_ARB_shader_precision GL_ARB_shader_stencil_export GL_ARB_shader_storage_buffer_object GL_ARB_shader_subroutine GL_ARB_shader_texture_image_samples GL_ARB_shading_language_100 GL_ARB_shading_language_420pack GL_ARB_shading_language_packing GL_ARB_shadow GL_ARB_spirv_extensions GL_ARB_stencil_texturing GL_ARB_sync GL_ARB_tessellation_shader GL_ARB_texture_barrier GL_ARB_texture_border_clamp GL_ARB_texture_buffer_object GL_ARB_texture_buffer_object_rgb32 GL_ARB_texture_buffer_range GL_ARB_texture_compression GL_ARB_texture_compression_bptc GL_ARB_texture_compression_rgtc GL_ARB_texture_cube_map GL_ARB_texture_cube_map_array GL_ARB_texture_env_add GL_ARB_texture_env_combine GL_ARB_texture_env_crossbar GL_ARB_texture_env_dot3 GL_ARB_texture_filter_anisotropic GL_ARB_texture_float GL_ARB_texture_gather GL_ARB_texture_mirror_clamp_to_edge GL_ARB_texture_mirrored_repeat GL_ARB_texture_multisample GL_ARB_texture_non_power_of_two GL_ARB_texture_query_levels GL_ARB_texture_query_lod GL_ARB_texture_rectangle GL_ARB_texture_rg GL_ARB_texture_rgb10_a2ui GL_ARB_texture_stencil8 GL_ARB_texture_storage GL_ARB_texture_storage_multisample GL_ARB_texture_swizzle GL_ARB_texture_view GL_ARB_timer_query GL_ARB_transform_feedback2 GL_ARB_transform_feedback3 GL_ARB_transform_feedback_instanced GL_ARB_transform_feedback_overflow_query GL_ARB_transpose_matrix GL_ARB_uniform_buffer_object GL_ARB_vertex_array_bgra GL_ARB_vertex_array_object GL_ARB_vertex_attrib_64bit GL_ARB_vertex_attrib_binding GL_ARB_vertex_buffer_object GL_ARB_vertex_program GL_ARB_vertex_shader GL_ARB_vertex_type_10f_11f_11f_rev GL_ARB_vertex_type_2_10_10_10_rev GL_ARB_viewport_array GL_ARB_window_pos GL_ATI_separate_stencil GL_EXT_abgr GL_EXT_bgra GL_EXT_blend_color GL_EXT_blend_equation_separate GL_EXT_blend_func_separate GL_EXT_blend_minmax GL_EXT_blend_subtract GL_EXT_clip_volume_hint GL_EXT_compiled_vertex_array GL_EXT_direct_state_access GL_EXT_draw_buffers2 GL_EXT_draw_range_elements GL_EXT_fog_coord GL_EXT_framebuffer_blit GL_EXT_framebuffer_multisample GL_EXT_framebuffer_object GL_EXT_geometry_shader4 GL_EXT_gpu_program_parameters GL_EXT_gpu_shader4 GL_EXT_multi_draw_arrays GL_EXT_packed_depth_stencil GL_EXT_packed_float GL_EXT_packed_pixels GL_EXT_polygon_offset_clamp GL_EXT_rescale_normal GL_EXT_secondary_color GL_EXT_separate_specular_color GL_EXT_shader_framebuffer_fetch GL_EXT_shader_integer_mix GL_EXT_shadow_funcs GL_EXT_stencil_two_side GL_EXT_stencil_wrap GL_EXT_texture3D GL_EXT_texture_array GL_EXT_texture_compression_s3tc GL_EXT_texture_edge_clamp GL_EXT_texture_env_add GL_EXT_texture_env_combine GL_EXT_texture_filter_anisotropic GL_EXT_texture_integer GL_EXT_texture_lod_bias GL_EXT_texture_rectangle GL_EXT_texture_sRGB GL_EXT_texture_sRGB_decode GL_EXT_texture_shared_exponent GL_EXT_texture_snorm GL_EXT_texture_storage GL_EXT_texture_swizzle GL_EXT_timer_query GL_EXT_transform_feedback GL_IBM_texture_mirrored_repeat GL_INTEL_conservative_rasterization GL_INTEL_fragment_shader_ordering GL_INTEL_framebuffer_CMAA GL_INTEL_map_texture GL_INTEL_multi_rate_fragment_shader GL_INTEL_performance_query GL_KHR_blend_equation_advanced GL_KHR_blend_equation_advanced_coherent GL_KHR_context_flush_control GL_KHR_debug GL_KHR_no_error GL_KHR_texture_compression_astc_hdr GL_KHR_texture_compression_astc_ldr GL_NV_blend_square GL_NV_conditional_render GL_NV_primitive_restart GL_NV_texgen_reflection GL_SGIS_generate_mipmap GL_SGIS_texture_edge_clamp GL_SGIS_texture_lod GL_SUN_multi_draw_arrays GL_WIN_swap_hint WGL_EXT_swap_control'
[DEBUG  ] [GL          ] glShaderBinary is not available
[INFO   ] [GL          ] Backend used <glew>
[INFO   ] [GL          ] OpenGL version <b'4.6.0 - Build <IP_ADDRESS>39'>
[INFO   ] [GL          ] OpenGL vendor <b'Intel'>
[INFO   ] [GL          ] OpenGL renderer <b'Intel(R) UHD Graphics 620'>
[INFO   ] [GL          ] OpenGL parsed version: 4, 6
[INFO   ] [GL          ] Shading version <b'4.60 - Build <IP_ADDRESS>39'>
[INFO   ] [GL          ] Texture max size <16384>
[INFO   ] [GL          ] Texture max units <32>
[DEBUG  ] [Shader      ] Fragment compiled successfully
[DEBUG  ] [Shader      ] Vertex compiled successfully
[DEBUG  ] [ImageSDL2   ] Load <C:\Users\abed\anaconda3\lib\site-packages\kivy\data\glsl\default.png>
[INFO   ] [Window      ] auto add sdl2 input provider
[INFO   ] [Window      ] virtual keyboard not allowed, single mode, not docked
[DEBUG  ] [App         ] Loading kv <C:\Users\abed\OneDrive\Documents\dev\GitHub\alant\labs\kivy\test.kv>
[DEBUG  ] [App         ] kv <C:\Users\abed\OneDrive\Documents\dev\GitHub\alant\labs\kivy\test.kv> not found
[INFO   ] [Text        ] Provider: sdl2
[DEBUG  ] [Resource    ] add <C:\WINDOWS\Fonts> in path list
[DEBUG  ] [Resource    ] add <C:\Users\abed\anaconda3\lib\site-packages\kivy\data\fonts> in path list
[DEBUG  ] [Base        ] Create provider from mouse, multitouch_on_demand
[DEBUG  ] [Base        ] Create provider from wm_touch
[DEBUG  ] [Base        ] Create provider from wm_pen
[INFO   ] [Base        ] Start application main loop
[INFO   ] [GL          ] NPOT texture support is available
[DEBUG  ] [Atlas       ] Load <C:\Users\abed\anaconda3\lib\site-packages\kivy\data\images\defaulttheme.atlas>
[DEBUG  ] [Atlas       ] Need to load 1 images
[DEBUG  ] [Atlas       ] Load <C:\Users\abed\anaconda3\lib\site-packages\kivy\data\images\defaulttheme-0.png>
[DEBUG  ] [ImageSDL2   ] Load <C:\Users\abed\anaconda3\lib\site-packages\kivy\data\images\defaulttheme-0.png>'''

@tshirtman I normally run at 150%, but I tried a few settings there and I still can't replicate the problem.
Oddly, when I bind to Window.size and then re-size the window, the callback fires repeatedly about once every second.. I'm not sure why that's happening but it makes it hard to test anything since I just get stuck in the debugger forever. Instead, I tried binding to on_resize. With that, the debugger triggered upon changing the UI scaling setting, only if the window was maximized. @abedhammoud did you get stuck in an infinite debug loop when testing this?
The only thing I really notice from your log is that you're using anaconda. I installed via pip for mine. I really don't have a good idea of if/why that would matter, but possibly worth a try with a pip install inside a virtual environment?

@tshirtman I normally run at 150%, but I tried a few settings there and I still can't replicate the problem.
Oddly, when I bind to Window.size and then re-size the window, the callback fires repeatedly about once every second.. I'm not sure why that's happening but it makes it hard to test anything since I just get stuck in the debugger forever. Instead, I tried binding to on_resize. With that, the debugger triggered upon changing the UI scaling setting, only if the window was maximized. @abedhammoud did you get stuck in an infinite debug loop when testing this?
The only thing I really notice from your log is that you're using anaconda. I installed via pip for mine. I really don't have a good idea of if/why that would matter, but possibly worth a try with a pip install inside a virtual environment?

Please indicate which backend matplotlib is using for each of you. Because that may well be responsible for these differences.

Please indicate which backend matplotlib is using for each of you. Because that may well be responsible for these differences.

I'm using 'TkAgg', as reported by matplotlib.get_backend()

I'm using 'TkAgg', as reported by matplotlib.get_backend()

Yeah, as I suspected, you can replicate by setting scaling to e.g. 150 and then do environ['MPLBACKEND'] = "Qt5Agg" before importing matplotlib. Just make sure to install pyqt5 first.
And it's because qt/matplotlib-qt changes the DPI awareness of the application and probably the window size.
That's why I would hesitate allowing kivy to change the DPI awareness of the Kivy app since it can leads to such unintended consequences. But, we could make it users configurable if we can figure out how.

Yeah, as I suspected, you can replicate by setting scaling to e.g. 150 and then do environ['MPLBACKEND'] = "Qt5Agg" before importing matplotlib. Just make sure to install pyqt5 first.
And it's because qt/matplotlib-qt changes the DPI awareness of the application and probably the window size.
That's why I would hesitate allowing kivy to change the DPI awareness of the Kivy app since it can leads to such unintended consequences. But, we could make it users configurable if we can figure out how.

Huh, that's interesting, I wonder if anaconda comes with that backend selected by default. @abedhammoud so it sounds like you likely can change the backend to prevent this behavior if you still want to use 150% scaling. Or if for some reason that doesn't work, you could try to install matplotlib via pip and the backend should default to TkAgg I think.

That's why I would hesitate allowing kivy to change the DPI awareness of the Kivy app since it can leads to such unintended consequences

Yeah I am starting to think this, too :/

Huh, that's interesting, I wonder if anaconda comes with that backend selected by default. @abedhammoud so it sounds like you likely can change the backend to prevent this behavior if you still want to use 150% scaling. Or if for some reason that doesn't work, you could try to install matplotlib via pip and the backend should default to TkAgg I think.

That's why I would hesitate allowing kivy to change the DPI awareness of the Kivy app since it can leads to such unintended consequences

Yeah I am starting to think this, too :/

Please take a look at https://github.com/kivy/kivy/pull/7299. That should fix the issue.

Please take a look at https://github.com/kivy/kivy/pull/7299. That should fix the issue.

Amazing, thank you. I will go through all the messages above,  but I quickly wanted to comments on the back-end issue.
@probablyfine, for me matplotlib.get_backend() returns Qt5Agg.
@matham when I try:
from ctypes import windll
windll.user32.SetProcessDpiAware(-4)
import kivy
'''

I get function not found:

```python
Traceback (most recent call last):

  File "<ipython-input-5-cad2ed372c18>", line 2, in <module>
    windll.user32.SetProcessDpiAware(-4)

  File "C:\Users\abed\anaconda3\lib\ctypes\__init__.py", line 386, in __getattr__
    func = self.__getitem__(name)

  File "C:\Users\abed\anaconda3\lib\ctypes\__init__.py", line 391, in __getitem__
    func = self._FuncPtr((name_or_ordinal, self))

AttributeError: function 'SetProcessDpiAware' not found

do I need to install the latest kivy from master before trying this fix?
As I use anaconda, it didn't install via pip as suggested by the installation instructions, I installed kivy using conda.
a little more about my environment (which is up to date, using conda), I have the following:
%conda list pywin32
# Name                    Version                   Build  Channel
pywin32                   228              py38h1e8a9f7_0    conda-forge
pywin32-ctypes            0.2.0           py38h32f6830_1002    conda-forge

Thank you again. I will go through the other message and see what I find.

Amazing, thank you. I will go through all the messages above,  but I quickly wanted to comments on the back-end issue.
@probablyfine, for me matplotlib.get_backend() returns Qt5Agg.
@matham when I try:
from ctypes import windll
windll.user32.SetProcessDpiAware(-4)
import kivy
'''

I get function not found:

```python
Traceback (most recent call last):

  File "<ipython-input-5-cad2ed372c18>", line 2, in <module>
    windll.user32.SetProcessDpiAware(-4)

  File "C:\Users\abed\anaconda3\lib\ctypes\__init__.py", line 386, in __getattr__
    func = self.__getitem__(name)

  File "C:\Users\abed\anaconda3\lib\ctypes\__init__.py", line 391, in __getitem__
    func = self._FuncPtr((name_or_ordinal, self))

AttributeError: function 'SetProcessDpiAware' not found

do I need to install the latest kivy from master before trying this fix?
As I use anaconda, it didn't install via pip as suggested by the installation instructions, I installed kivy using conda.
a little more about my environment (which is up to date, using conda), I have the following:
%conda list pywin32
# Name                    Version                   Build  Channel
pywin32                   228              py38h1e8a9f7_0    conda-forge
pywin32-ctypes            0.2.0           py38h32f6830_1002    conda-forge

Thank you again. I will go through the other message and see what I find.

Thank you again,
I added the following, and the problem solved - thank you!
import matplotlib
matplotlib.use('TkAgg', force=True)
'''

So it seems that the issue is specific to the Qt5Agg backend.

I truly appreciate your help - this has been bugging me for some time, and now I have the fix thanks to your pointers.
@tshirtman , @matham , @probablyfine  thank you and best wishes for the new year!

Thank you again,
I added the following, and the problem solved - thank you!
import matplotlib
matplotlib.use('TkAgg', force=True)
'''

So it seems that the issue is specific to the Qt5Agg backend.

I truly appreciate your help - this has been bugging me for some time, and now I have the fix thanks to your pointers.
@tshirtman , @matham , @probablyfine  thank you and best wishes for the new year!

Sorry, that's a typo on my end. It should be SetProcessDPIAware, with DPI capitalized.

Sorry, that's a typo on my end. It should be SetProcessDPIAware, with DPI capitalized.

Thanks, @matham. I tried some more, I will try to summarize so hopefully this could be of help to someone.
First, it seems that the default matplotlib backend on windows and (Linux ubuntu 20.10) anaconda installation is Qt5Agg.

If I use matplotlib with the default backend on windows, I have the shrinking app issue when I use matplotlib to plot a graph. On Linux, the problem doesn't exist.
If I do the following before importing kivy as you proposed (and without changing the backend):

from ctypes import windll
windll.user32.SetProcessDpiAware(-4)
import kivy

The application starts (but at a smaller size than step 1), however, the app doesn't shrink when I use matplotlib to plot a graph.  I will look if there is a way to ask kivy to start at a given dpi.

If I change the backend on windows to Tkagg before using matplotlib, then all worked well. This is the solution that I used, and my problem is resolved:

import matplotlib as mpl
if kivy.metrics.platform == 'win':
    mpl.use('TkAgg', force=True)

Thank you. I will close this issue, I appreciate your help @matham , @tshirtman , @probablyfine

Thanks, @matham. I tried some more, I will try to summarize so hopefully this could be of help to someone.
First, it seems that the default matplotlib backend on windows and (Linux ubuntu 20.10) anaconda installation is Qt5Agg.

If I use matplotlib with the default backend on windows, I have the shrinking app issue when I use matplotlib to plot a graph. On Linux, the problem doesn't exist.
If I do the following before importing kivy as you proposed (and without changing the backend):

from ctypes import windll
windll.user32.SetProcessDpiAware(-4)
import kivy

The application starts (but at a smaller size than step 1), however, the app doesn't shrink when I use matplotlib to plot a graph.  I will look if there is a way to ask kivy to start at a given dpi.

If I change the backend on windows to Tkagg before using matplotlib, then all worked well. This is the solution that I used, and my problem is resolved:

import matplotlib as mpl
if kivy.metrics.platform == 'win':
    mpl.use('TkAgg', force=True)

Thank you. I will close this issue, I appreciate your help @matham , @tshirtman , @probablyfine


Drawer cannot be closed with gesture after scrolling down on Firefox

If you open the drawer with the trigger being in overflowed part of the page (you have to scroll to see it) on Firefox, you cannot swipe it down to close it. As far as i've tested, the bug does not appear in Chrome or Safari.
Tested on
Firefox 117.0 (Desktop)
Firefox 116.3.0 (Mobile)
Vaul version 0.4.5 (latest at the time of writing)
Bug occurs on both firefox versions
Example
Open the codesandbox example below while using Firefox and try to swipe down the drawer after opening it
https://codesandbox.io/p/sandbox/misty-snowflake-gp8kfc
The codesandbox features drawer markup from the "With scaled background" readme example but the issue also occurs without the scaling background

This has been fixed in #81, I’ll publish a new version soon!


Announcing Cucumber-JVM v2.1.0

This should probably be linked to https://github.com/cucumber/website/pull/256

I think you have to add yourself to https://github.com/cucumber/website/blob/master/apps/dynamic/_config.yml for the blog to be generated correctly.

Fixed. It won't show up in the list because it is future dated.
https://cucumber-website-pr-258.herokuapp.com/blog/2017/10/30/announcing-cucumber-jvm-2-1-0


Digest Generation example using HGVS.

@reece I have a question regarding your HGVS VMC implementation found here.  I'm unable to replicate HGVS ID's you generate, and I wanted to confirm/correct the implementation.
Based on the HGVS expression "NC_000019.10:g.44908684C>T" I used the following reference fasta: NC_000019.10
Sequence_ID:
VMC:GS_IIB53T8CNeJJdUqzn9V_JnRtQadwWCbl

And created the following Location_ID:
Digest(<Location|VMC:GS_IIB53T8CNeJJdUqzn9V_JnRtQadwWCbl|44908683>)
VMC:GL_0KNCxpnWXoM4fIokZexmx_sEjPBsCsTQ

And created the following Allele_ID:
Digest(<Allele|VMC:GL_0KNCxpnWXoM4fIokZexmx_sEjPBsCsTQ|T>)
VMC:GA_2FZTmPgPLK2z_sr5HAj8qRZEDQ2TlhA

If you could review this and let me know where we differ, it would be appreciated.

@srynobio Sorry for not replying earlier. I will pull together a broader set of examples within the next week.

Hi @srynobio - So sorry for slacking and not communicating on this as promised. Mea culpa.
Here's what I get:
In [5]: vb = from_hgvs("NC_000019.10:g.44908684C>T")

In [6]: vb.for_json()
Out[6]:
{'alleles': {'VMC:GA_AnJl99FJB5tNPupduz8I4R8CCuwCpIY0': {'id': 'VMC:GA_AnJl99FJB5tNPupduz8I4R8CCuwCpIY0',
   'location_id': 'VMC:GL_L1IS6jOwSUsOpKihGRcqxHul1IwbV-1s',
   'state': 'T'}},
 'genotypes': {},
 'haplotypes': {},
 'identifiers': {'VMC:GS_IIB53T8CNeJJdUqzn9V_JnRtQadwWCbl': [{'accession': 'NC_000019.10',
    'namespace': 'NCBI'}]},
 'locations': {'VMC:GL_L1IS6jOwSUsOpKihGRcqxHul1IwbV-1s': {'id': 'VMC:GL_L1IS6jOwSUsOpKihGRcqxHul1IwbV-1s',
   'interval': {'end': 44908684, 'start': 44908683},
   'sequence_id': 'VMC:GS_IIB53T8CNeJJdUqzn9V_JnRtQadwWCbl'}},
 'meta': {'version': '0.1'}}

Comparing with yours, it looks to me that there's a problem with the location_id. Here's what I get:
In [19]: l = next(iter(vb.locations.values()))

In [20]: l
Out[20]: <Location id=VMC:GL_L1IS6jOwSUsOpKihGRcqxHul1IwbV-1s interval=<Interval attributes: end, start> sequence_id=VMC:GS_IIB53T8CNeJJdUqzn9V_JnRtQadwWCbl>

In [21]: from vmc.serialize import serialize

In [22]: serialize(l)
Out[22]: '<Location|VMC:GS_IIB53T8CNeJJdUqzn9V_JnRtQadwWCbl|<Interval|44908683|44908684>>'

Compare Out[22] with your serialization Digest(<Location|VMC:GS_IIB53T8CNeJJdUqzn9V_JnRtQadwWCbl|44908683>)
The interval components are different. Intervals should be serialized as like <Interval|*start*|*end*>, like so:
In [23]: import vmc

In [24]: iv = vmc.models.Interval(start=10, end=11)

In [25]: serialize(iv)
Out[25]: '<Interval|10|11>'

The rationale for this is that we will likely have other kinds of intervals later. For example, we should be able drop in CDS intronic coordinates with a (hypothetical) serialization like <CDS|10-3|22+5> or Exon-based numbering like <Exon|5|7>.
Make sense?

Thanks Shawn.
I'm pretty sure that that serialization has changed only in the pipe
separator in the last year. However, no matter... I'm glad it works for you.
Please also check out these language-independent tests:
https://github.com/ga4gh/vmc/blob/dev/tests/validation.yaml
There's a corresponding pytest that reads the yaml and runs the validation
tests:
https://github.com/ga4gh/vmc-python/blob/master/tests/test_validation_tests.py
This is the start of the validation tests -- there's more to do. Also, a
proper set of tests should probably include failures (e.g., end<start), but
I haven't worked that out yet.
-Reece
On Fri, Aug 31, 2018 at 9:24 AM Shawn Rynearson<EMAIL_ADDRESS>wrote:

@reece https://github.com/reece
Okay are values are concordance now. I think the major change was due to
the fact that the serialization string has changed recently.
From:
'<Location|VMC:GS_IIB53T8CNeJJdUqzn9V_JnRtQadwWCbl|44908683|44908684>>'
To:
'<Location|VMC:GS_IIB53T8CNeJJdUqzn9V_JnRtQadwWCbl|<Interval|44908683|44908684>>'
My results:
./vmccl --hgvs "NC_000019.10:g.44908684C>T" --fasta data/NC_000019.10.fasta
VMC:GA_AnJl99FJB5tNPupduz8I4R8CCuwCpIY0
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ga4gh/vmc/issues/24#issuecomment-417716763, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAGrjXUuIdU3Y9uhVmRi5fxHdMhiThL-ks5uWWMqgaJpZM4UsQ-w
.


Filter MacStadium bots from analytics

Since June 1, there has been a disproportionate spike in analytics events coming from Atlanta, GA. The events report themselves to be from Mac devices, which indicates that they are probably CI bots in the MacStadium datacenter there. We need to filter these out in the Flutter tool's bot detector.

cc @jwren - if we update the filter for the flutter tools we should allow a similar change for dart

@zanderso please CC me on the resolving PR.

I spent a couple hours investigating this last week, and didn't see an obvious way to detect bots in this case. Just a heads-up that we may have to punt on this one and filter after the fact based on e.g. new user with short session duration that never comes back.


Replace placeholder with actual spec

I can't find this feature documented elsewhere.  Please fill in this placeholder.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6ec6109e-cc53-d680-ff97-79f6c1330691
Version Independent ID: 01fb2712-1de7-b9da-f62a-fd2513bbe3b4
Content: Unconstrained type parameter in null coalescing operator - C# 8.0 specification proposals
Content Source: proposals/csharp-8.0/unconstrained-null-coalescing.md
Product: dotnet-csharp
Technology: csharp-spec
GitHub Login: @dotnet-bot
Microsoft Alias: wiwagn

We agree @ChainReactive
We'll be updating these shortly.

@ChainReactive @BillWagner I believe this feature is already documented, but not in this placeholder.
For example, in the feature proposal for ??=:

As part of this proposal, we will also loosen the type requirements on ?? to allow an expression whose type is an unconstrained type parameter to be used on the left-hand side.

AND

For the relaxation of the type requirements of ??, we update the spec where it currently states that, given a ?? b, where A is the type of a:

If A exists and is not a nullable type or a reference type, a compile-time error occurs.

We relax this requirement to:

If A exists and is a non-nullable value type, a compile-time error occurs.

This allows the null coalescing operator to work on unconstrained type parameters, as the unconstrained type parameter T exists, is not a nullable type, and is not a reference type.

That change is also reflected in the docs:

In particular, beginning with C# 8.0, you can use the null-coalescing operators with unconstrained type parameters:

@BillWagner is that the correct feature?

As noted above, this feature is covered in two other spec areas.
Closing as addressed.


typos: 1.15.2 -> 1.15.3

Diff: https://github.com/crate-ci/typos/compare/v1.15.2...v1.15.3
Changelog: https://github.com/crate-ci/typos/blob/v1.15.3/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 239045 run on x86_64-linux 1

1 package built:

typos


Fails in debug mode

Does not push through the chain when compiled debug on the sample device. This is mysterious. I suspect the WS2812 has some kind of undocumented "long timeout" after which the first value it receives is not pushed? But that seems weird at best. Idk.

Fixed in 0.2.0. I didn't understand how WS2812 timing worked — now I kind of do.


Clarify description of Bonfire - Drop it

Added Description
Added MDN link to solve using Array.prototype.slice method

I really like this change.  Just needs a comma.

:+1:

I see your :+1: and raise you a :+1: :+1: :smile:


How can I install and use a new scheme like 'dracula/vim'?

Mac OS 12.1
I see that there are already 21 themes built in, but I also want to add the "dracula".
Please help me, thanks.

I solved it.


Add Issue template for workflow releases

closes #74
Does what the title says! I think I got most of the things I would want to see in a release, but please let me know if there are additional checklist items that I should add!
I have also added a changelog file, with an outline of expected release notes for the upcoming release.

Added some additional instruction notes as requested, ready for rereview.

LGTM!
Logistical point: I'm planning to wait for this to go in so we can open the issue (and check some completed boxes for "free"!) before I run #69 for prod. Agree?

You should not need to run prod at all. That will be run automatically when we cut the release. But we should run staging again just to make sure things work with the tagged docker images, which were not present in the previous run (there should not be any changes, but still, good practice). I'd be happy with just running simulated rather than full for this case though.

But yes, I agree that this goes in before cutting the release! (And a PR to set the version number & finalize the changelog)


Unable to set blank password for basic authentication.

Our Basic auth takes an access_token in the username and then a blank password. Currently, it requires a password. Which means multiple endpoints can't be used from the documentation page.

Originally posted by @tjperry07 in https://github.com/mrin9/RapiDoc/discussions/488

I will look into this one. Expect a little delay as we are catching up on our issues after the summer break

No worries. Everyone needs break time. 🌴


Adding duplicated entries on HABTM array

Hi
Suppose I have this models:
class Post
  include Mongoid::Document

  has_and_belongs_to_many :categories
end

class Category
  include Mongoid::Document
  field :name

  has_and_belongs_to_many :posts
end

After my upgrade to the current commit on 2.2.0-stable branch (I had to upgrade to this version because of the fix of #1225), this test failed:
category = Category.create(:name => "MyCategory")
post = Post.new

post.categories = [category, category]
post.save!

post.categories.should == [category]

We got two elements on categories, both with the same id.
Is this expected ?

I'm still having the same issue with 2.3.3. I see that the fix has been reverted by https://github.com/mongoid/mongoid/commit/4df41091a7c92ab07e1c58640c74fd0968a80ee3
Is this intended?

I'm also running into significant duplication issues with 2.3.4 - assigning arrays of objects to relations (ie image.tags = [tag1, tag2, tag3]) is resulting in duplicates stored in the DB, with all the confusion that entails.

@JamesHarrison Could that be due to #1516?

@nickhoffman My current testing is showing that it is, I'm working on the fix now.

Hi,
I'm experiencing same problem with 2.4.3, but my example would look like a bit modified from above:
category = Category.create(:name => "MyCategory")
post = Post.new

# atomic set performed, no save call necessary
post.categories << category
post.categories << category

post.categories.should == [category] # evals to true
post.category_ids.size.should == 1 # evals to false, 2 ids in array

I'm sure that's not expected behavior. Should the issue be reopened?
Thanks

..just updated to 2.4.4 and same issue is reproduceable

I'll reopen for 2.5.

The problem here, along with the commit in question, 4df41091a7c92ab07e1c58640c74fd0968a80ee3, is that checking inclusion is expensive if there are a large number of documents in the relation. The intention is to change the enumerable target to being backed by a hash instead of arrays, but this big of a change will need to go to 3.0.


Input and output gain adjustments

The static input and output gain is pretty annoying. Simple input and output sliders near the top  of the UI would be good.

closed by f6878fe


WIP: Eliminate redundant integral image calculations in LRF RDO

Right now, 32 functionally (though not practically) identical integral images are computed for each LRF filter optimization test.  The differences between the images can be reconciled to allow a single computation to be shared across the entire test process.

Coverage decreased (-0.003%) to 71.187% when pulling 5056f565415df71071af002b08e79239cc2aa211 on xiphmont:lrf-iiopt into b074992e54ab4067b3eabecd45110d451da95c2d on xiph:master.

I was seeing differences in those two functions where integral_image is computed, 'rows_iter' that is passed to sgrproj_solve() and sgrproj_stripe_filter(), i.e
https://github.com/xiphmont/rav1e/blob/b074992e54ab4067b3eabecd45110d451da95c2d/src/lrf.rs#L636
and
https://github.com/xiphmont/rav1e/blob/b074992e54ab4067b3eabecd45110d451da95c2d/src/lrf.rs#L833
Then I though that might be the reason I was not able to not call setup_integral_image() for sgrproj_stripe_filter().
Btw, my PR (which was done before your max LRU landed) is here https://github.com/xiph/rav1e/pull/1600. It worked fine and gives ~5 % total encoding time reduction.

AWCY results:
lrf-iiopt-baseline@2019-09-25T22:41:14.816Z -> lrf-iiopt-test@2019-09-25T22:41:44.061Z
PSNR | PSNR Cb | PSNR Cr | PSNR HVS |   SSIM | MS SSIM | CIEDE 2000
-0.0006 | -0.0104 |  0.1664 |   0.0207 | 0.0170 |  0.0150 |    -0.0114
The small functional change is due to altering the boundary handling slightly in the RDO loop.  Previously each LRF filter was strictly bounded to its LRU with no addressing outside either the horizontal bounds or passed in vertical stripe.  Originally, this was to simplify corner cases in search processing.  With integral images it's longer necessary.  The filters are now allowed to peek outside the edges of the rectangle as they would in a normal filtering operation. This change allows easier unification of the II setup code.
As expected, the patches collectively get a roughly 5-8% overall encoding time speedup.


False error TS4094: ... exported class expression may not be private or protected.

TypeScript Version:  3.3.3333
Code
src/test.ts:
export function test () {
    return class {
        private privateMember () {
        }
    };
}

tsconfig.json:
{
    "compilerOptions": {
        "target": "es5",
        "module": "commonjs",
        "declaration": true
    },
    "include": [
        "src/**/*"
    ],
    "exclude": [
        "node_modules"
    ]
}

Expected behavior:
No compilation error.
Actual behavior:
Compiler prints error:
$ tsc
src/test.ts(1,17): error TS4094: Property 'privateMember' of exported class expression may not be private or protected.
Playground Link: not possible to provide.
Workaround
Declare the return type explicitly:
export function test (): new() => Object {
    return class {
        private privateMember () {
        }
    };
}

The error message didn't accidently write itself... exported anonymous classes can't have private or protected members if declaration emit is enabled, because there's no way to represent that in a .d.ts file.

It is possible to use private in declaration files. In my project, for example, I found a lot of them in node_modules folder:
tslint/lib/formatters/checkstyleFormatter.d.ts:
export declare class Formatter extends AbstractFormatter {
    static metadata: IFormatterMetadata;
    format(failures: RuleFailure[]): string;
    private escapeXml; <- HERE
}

I think this is an issue, too.

Perhaps we should extends d.ts to handle this case then. Ideally the declarations file and the ts source file would be 100% compatible.

It is currently not possible to generate declaration files when using a class mixin pattern, even if that pattern would otherwise compile and type-check just fine. It would be nice to have support for this 🙏

Shouldn't this issue be open?

In particular, it'd be nice to be able to do something like
function foo<T>(arg: T): SomeType<T> { ... }

type Bar = {num: number}

type FooBar = ReturnType<typeof foo<Bar>>

I get what you're saying, that foo<Bar> is already a type, so typeof doesn't make sense. But I think you get what's missing.
This is valid:
type FooBar = ReturnType<typeof foo>

But in that example, TypeScript sets the type of T to unknown, so the type of FooBar is SomeType<T>.
Basically, it just intuitively seems like there should be some way to pass a generic arg there, but we can't, and TypeScript automatically sticks unknown into it. Example on playground

If a function foo has a generic param, then the typeof operator could perhaps return a generic type, and we could write:
type FooBar = ReturnType<(typeof foo)<Bar>>

That would be a breaking change to TypeScript though.

Please see https://github.com/microsoft/TypeScript/issues/35822

I re-opened this at https://github.com/microsoft/TypeScript/issues/36060

Interesting fix: moving the mixin to its own file works:
type Constructor<T = {}> = new (...args: any[]) => T

export default <T extends Constructor<Interface>>(base: T) => class SomeClass extends base {
    protected something: boolean = false
}

While a named export throws the error:
type Constructor<T = {}> = new (...args: any[]) => T

export const mixin = <T extends Constructor>(base: T) => class SomeClass extends base {
    protected something: boolean = false
}

here is how you can fix it, instead of
function makeClass() {
    return class {
         private x = 0;
    }
}

do
type Constructor<T> = new () => T
interface MyInterface {
    y: number;
}
function makeClass(): Constructor<MyInterface> {
    return class {
         private x = 0;
         public y = 1;
    }
}

It is currently not possible to generate declaration files when using a class mixin pattern, even if that pattern would otherwise compile and type-check just fine. It would be nice to have support for this 🙏

@cdata not exactly! :) see the prior workaround the OP pointed to:

Declare the return type explicitly:

In the case of a mixin function (which is exactly the problem I had here too), that means you need to return the union (&) of the 2 constructor-types which you will mixin together. It is helpful to provide therefore an interface decl outside of the mixin function which implements by the class that the mixin function returns.
I can post some helper code and type utilities for this if there is interest.
I agree this isn't a bug per-se. The type-declaration just expects your mixin function to return types explicitely that it actually can express i.e export in a d.ts, and in this case that will mean explicitely declaring the resulting mixin interface outside of the mixin function so that it can be used as a return type of it.

Another solution can be to just use the ES2020 private fields if you ever encounter this problem. This will avoid you to define a return type, which can be annoying if your mixin is quite complex :
function makeClass() {
  return class {
       #x = 0;
       public y = 1;
  }
}

Same thing with "constant class".
export const testClass = class {
  private field = {}
}

Interestingly # private class fields indeed work fine.

Although use #to declare private member can avoid this declaration error, it will make the property not readable, plus it can not replace protected. I only want some method or property not overridable in some cases.

you can write like this
class C {
    private privateMember () {
    }
}
export function test ()  {
    return C;
}

export function test2 (): typeof C  {
    return class extends C {};
}

Although use #to declare private member can avoid this declaration error, it will make the property not readable, plus it can not replace protected. I only want some method or property not overridable in some cases.

it would be great if ESlint rule will be already aware. I had some error and quick fix was generation of private _data + get/set data methods. And it was throwing errors. Replacing with # helped to solve it.

Interesting fix:
Moving the mixin to its own file and doing a default export works:
type Constructor<T = {}> = new (...args: any[]) => T

export default <T extends Constructor>(base: T) => class SomeClass extends base {
    protected something: boolean = false
}

While a named export throws the error:
type Constructor<T = {}> = new (...args: any[]) => T

export const mixin = <T extends Constructor>(base: T) => class SomeClass extends base {
    protected something: boolean = false
}

isn't it a bug then? So it's doing exactly same, but with two files instead of one. I'm quite surprised to see that this issue is Closed while indeed it must not and should be fixed


Accessory is crashing when performing InvokeCommand with unsupported access.

Problem
When executing InvokeCommand on the accessory with Unsupported access, the accessory crashes.
Accessory SHA: aca4b94f9220f2dd23c44da5dbfcdf8f212f5e4d
Accessory_log.txt

On that SHA, I just tried:

Start all-clusters-app.
chip-tool pairing code 17<PHONE_NUMBER>65521327694
chip-tool accesscontrol write acl '[]' 17 0
chip-tool onoff toggle 17 1

and I get an UNSUPPORTED_ACCESS response, no crash...

This crash was fixed in #21590.
The issue here is a client that is sending a Timed Request and then on the same exchange an untimed invoke.  The server was detecting the mismatch, sending a status response (which closed the exchanged), then crashing in CommandHandler::DecrementHoldOff because it used the exchange pointer without null-checking or checking mSentStatusResponse.


Raven.sendException should support Throwable

ExceptionInterface.ExceptionInterface()  accepts Throwable, but but Raven.sendException() accepts only Exception as a parameter.
Any reason to not accept Throwable here? If there is none - could you please adjust this method?

I can't think of any reason this would need to be Exception rather than Throwable, so I'm +1 on making this change.


Add yargs to dependencies.

LGTM

@jjeffryes would mind resolving the merge conflict? Once that's done, feel free to merge this one.

This was covered by #364


The SSL TPS data is not normal

Environment

Telemetry Streaming Version:  f5-telemetry-1.19.0-3.noarch
BIG-IP Version: BIG-IP <IP_ADDRESS> Build 0.0.4 Point Release 6

Summary

I used ’rate(f5_totNativeConns{}[2m])‘  to get the number of SSL connections, but after looking at it for a while, I found that there were occasional abnormal values
Expected Behavior
I want to know if this is due to the calculation method or if this is the real data, or if the metrics I used are correct.
I hope to get the TPS data of SSL, but due to these abnormal data, I can't normally observe and alarm.

你看到这个问题的消费者是什么？

prometheus

Do you see this same data anomaly with the new OpenTelemetry consumer? https://clouddocs.f5.com/products/extensions/f5-telemetry-streaming/latest/setting-up-consumer.html#opent

I've only used Prometheus, but I've tried different versions of it.Including 1.15.0, 1.19.3, and 1.20.1.

Or if there is a way to mask abnormal noise

It looks like users can encounter bad statistics coming from tmsh. Below area a couple of knowledge articles on the subject:

https://support.f5.com/csp/article/K21811305
https://support.f5.com/csp/article/K15455

Do these help with your issue?


pkt/utils: simpler LazyLoad

Simplify LazyLoad by dropping unnecessary synchronization. Mirrors changes from core.

Nice catch on the discrepancy.
Why have this type in core and in relay?

None. Planning to update core to use this.

Nice catch on the discrepancy.
Why have this type in core and in relay?

None. Planning to update core to use this. Edit: or drop it? seems unused... 🤔

I dug around a bit, I agree with dropping it. Makes sense to me why we had it there before and why we don't need it anymore.


hover help is not available on attributes

VSCode Version: VSC Insiders
OS Version: Windows 10

Steps to Reproduce:

Open launch.json file
Hover over the attributes and observe the result

duplicate of #16136


Feature/integrate local hero

Hi everybody
Here is a first working version of local-hero integration. Sorry for the delay ... work, small kids and stuff.
Enough whining, here's the deal:
I've used some code from @pavax (ContactInformationGuesser) and put it into a maven module named common. Right, modules. Meaning, other integrations, like kml-parser, can be added in the integrations pom.xml as well. This has the following advantages:

share code
streamline dependencies
have a standardised build
IDEs will add them  correctly into the project structure

What works:

reading posts from local-hero cities like Bern, Winterthur, Zug, Zürich and Solothung (currently just below 500 posts)
parsing them into usable information, stripping html, converting unicode characters in html format into readable characters
parsing website addresses from the post. If nothing is found, the local-hero.ch post url will be used.
parsing email from the post
parsing phone number from the post
sending it all to the sync service
tests are green (of course 😄 ), as far as there are tests

What kind of works:

there is a location value. However, it is nearly impossible to parse one out of the post text, if there is one at all. It just uses the default value for the respective city, which in some cases is incorrect. Feature request: allow businesses to request to change their information.
same goes for some other fields

What does not work:

parsing business address
the local json-server, used to mock source data, is buggy when pagin requests. So far, it's abandoned

Sorry for the delay, I will review this PR tomorrow !

I made some cosmetic changes to the Dockerfiles in order to have some kind of standard for the integrations.
Both localhero and kml-parser are starting correctly but I'm getting errors at the sync-service level, probably related to the changes in the API. I will check with Patrick tomorrow.

I don't know why but I cannot get rid of the conflict on docker-compose.prod.yml file... I will close this PR and create a new one referencing this one.


update the ACDC  before move to exhausted status in ErrrorHandler

If ACDC update is failed job still move to exhaused status. This can cause the problem of missing document ACDC. (Not sure this happened but better to be fixed)

and what happens if we upload the same ACDC jobs twice? Well, we do have a merge function when pulling ACDC docs, it might not be a problem...


Fix appearing Error in console

Current behaviour:
If a mediafie is projected without being preloaded then the projector detail view throws several: Cannot read properties of undefined (reading 'split')
Wanted behaviour:
Even if mediafiles are not preloaded the projector-detail view shouldn't throw errors

It seems like the autoupdate service does not send the owner ids of media files when requested via the content object of a projection.