Warning: React.createElement: type should not be null, undefined, boolean, or number. It should be a string (for DOM elements) or a ReactClass (for composite components).

I have generated the API key and added the script to my html head
I have installed react-geosuggest using this:
npm install react-geosuggest --save
I imported the component:
const Geosuggest = require('react-geosuggest');
used it:
<Geosuggest />
but I get this error:
Warning: React.createElement: type should not be null, undefined, boolean, or number. It should be a string (for DOM elements) or a ReactClass (for composite components).

Did you resolve this? Had an issue with Babel that threw this error. The solution was to use ES6 import.

Yes, I solved it using this:
import Geosuggest from 'react-geosuggest';

I'm using es5 and had to do var Geosuggest = require('react-geosuggest').default; to prevent this error.


Could I get the reactive data when db update?

Could I get the reactive data when db update?
Please example for me.

If you want reactive data, use publication/subscription

Thanks for your reply, now I solved this.


added saas-boilerplate to the list of django templates

With r.e.f to Issue #71 , added https://github.com/apptension/saas-boilerplate to our list of django templates.

thanks!


Progress messaging

I have integrated the library in my client app.
The problem is that when I apply a filter, users do not get feedback on the filter progression.
It would be awesome to get progress indication. Something added to IGraphicsProcessor.
I think using an observer pattern similar to the event aggregator available in Caliburn.Micro for instance.
Basically, it uses an event aggregator (through an interface and dependency injection), which is a class handling messages bubbling up the class tree, to which other classes can subscribe to through the IHandle<T> interface.
The source code for these is available... around here I guess. I'm not sure how it's implemented, but you can probably inspire yourself from this.
It can also be implemented through more classic events and event handlers.
Please note that this code is hand-typed and I don't know if it even compiles :smile:
public interface IGraphicsProcessor {
    delegate void ProgressedEventHandler(object sender, ProgressedEventArgs e);
    event ProgressedEventHandler OnProgressed;
}

public class MyProcessor : IGraphicsProcessor {
    public Image ProcessImage(ImageFactory factory) {
        // TODO: do some work
        if (OnProgressed != null) { OnProgressed(this, new ProgressedEventArgs { percent = 10 }; }
        // TODO: do some more work
        if (OnProgressed != null) { OnProgressed(this, new ProgressedEventArgs { percent = 100 }; }
    }
}

public class MyApp {
    public MyApp() {
        MyProcessor p = new MyProcessor();
        p.OnProgressed += new ProgressedEventHandler(processor_OnChanged);
    }

    private static void processor_OnChanged(object sender, ProgressedEventArgs e) {
        MessageBox.Show("progress: " + e.percent);
    }
}

I am interested on working on this issue.
IGraphicsProcessor is an interface in the V2 branch. The V3 branch uses the IImageProcessor interface. It looks to me like the V2 filters are are single-threaded, so a callback progress indicator is simple to implement, but the V3 filters are multi-threaded (via ParallelImageProcessor and the Tasks library). So a callback progress indicator in V3 might be invoked from any task (thread), which would need to be handled by the client code.
Perhaps the Tasks library has some functionality to allow progress notification to be reported from each task to ParallelImageProcessor, which could then send progress notifications to the client on the calling thread?

Hi there,
I'd love to see what you could implement for either. A huge :+1: from me.
I agree that for V2 it should be a simple addition, for V3 (I think I'm going to rename that btw to Core.V1) I don't know. I thought about adding something to ParallelImageProcessor since that is the single point we can grab the sum of the processor count and provide accurate-ish feedback. Processors can be nested though so it makes it extremely tricky.

Hi,
I have now implemented the progress callback for the V3 branch: https://github.com/voidstar69/ImageProcessor
I decided to let the client code handle multi-threaded callbacks, rather than have ParallelImageProcessor try to serialise these into callbacks on the client thread.
The callback fires after each (source image) row is processed (potentially in any order, due to multi-threading). A typical filter that processes each row only once simply needs to call ParallelImageProcessor.OnRowProcessed. For now I have only added this call to the Brightness filter, but it needs to be added to every filter.
I have modified the FilterImage test to check that the callback triggers for rows roughly in order, with some variability allowed due to multi-threading. I am not certain that this check would be valid on all platforms, so a smarter test may be required (e.g. check that every row is processed, and only once each).
Let me know what you think of this code. I am happy to make any changes that you suggest.
Thanks

I like this! Any noticeable performance cost from adding the functionality?

Nothing conclusive. The existing stopwatch timing seems too variable for performance testing - a good performance test would probably execute a single filter many times to ensure code is JITed and cached, throw away the highest and lowest times, and average the rest.
Using the existing stopwatch timing, I only know how to view the trace output via debugging the code and looking in the Debug window. I did this (with my laptop in High Performance mode to avoid CPU down-scaling), and got the following results:
Old code, release mode, debugging, trace output.
1st run:
Brightness-50: 1396ms Brightness-50: 190ms Brightness-50: 415ms Brightness-50: 121ms
2nd run:
Brightness-50: 1406ms Brightness-50: 183ms Brightness-50: 413ms Brightness-50: 116ms
New code, release mode, debugging, trace output.
1st run:
Brightness-50: 1543ms Brightness-50: 149ms Brightness-50: 447ms Brightness-50: 111ms
2nd run:
Brightness-50: 1341ms Brightness-50: 164ms Brightness-50: 471ms Brightness-50: 107ms
I will change all the filters to support the progress indicator callback, then we will see if the overall execution time of the FilterImage test changes.

:smile: Yeah that doesn't yield much discernible difference. Interlocked.Add is supposed to do millions of operations a second so I doubt it will.
Looking forward to seeing that in place. I'll look into coding out a nice way to test performance of individual processors. and the encoders/decoders separately.

I changed all filters and samplers to provide progress updated, and submitted this as PR #310

@cosmo0 @voidstar69 What are your thoughts on adding similar functionality to the Framework version? I'm concerned that we cannot now change the IGraphicsProcessor interface without a major version.

@JimBobSquarePants I will have a look at the Framework version this weekend, to see how much work is involved in adding progress updates.
We can make the change backwards compatible (i.e. the progress callback is optional) - does this then require a major new version of ImageProcessing for Framework?

I'm concerned that we cannot now change the IGraphicsProcessor interface without a major version.

Large breaking changes in the API might require a new major version, but I don't think just introducing a new feature does.

If we can get by without changing the interface then minor version, any interface changes will require a major version. I've made that mistake before. It ain't pretty.

It is possible to add the OnProgress event to all classes that implement IGraphicsProcessor, without adding it to IGraphicsProcessor. Not the cleanest approach, but it would then not require a major version.
Then when you have a reason for another major version, the OnProgress event can be added to IGraphicsProcessor.
The downside is that any code that generically handles IGraphicsProcessor-derived objects, would not have access to the OnProgress event. However most client code probably uses the derived classes directly.

Looking more closely at this, I believe a progress callback is generally not possible for the Framework branch. The issue is that most processors make a single call to a method of System.Drawing.Graphics or System.Drawing.Image to perform most of the work, and these classes do not provide any progress callbacks. I tried using System.Drawing.Graphics.DrawImageAbort as a progress callback, but this seems to be called only once per call to System.Drawing.Graphics.DrawImage.
Only processors that perform pixel manipulation themselves could provide a progress callback. About a third of processors do this:

Alpha
Convolution (GaussianBlur, GaussianSharpen)
ConvolutionFilter (DetectEdges)
Gamma
Halftone
Hue
Pixelate
ReplaceColor

Overall I think there is not much point implementing a progress callback for the Framework branch.

@voidstar69. I concur, I was thinking about it today and drew exactly the same conclusion.  I vote for closing the issue.

@JimBobSquarePants I agree, this issue should be closed.
Hopefully the Core version will eventually become the single standard version of ImageProcessor for all platforms, and so all platforms will then have progress callbacks.

@cosmo0 Are you happy for this issue to be closed?

Sure !


Check if box is opened in another isolate

Is your feature request related to a problem? Please describe.
I am doing background tasks via workmanager package. During the background task a code is running in a different dart isolate than the main isolate. To prevent errors, I would like to check in the background task if the app is open. If it is then I skip the background task.
Describe the solution you'd like
Something like an additional argument like Hive.isBoxOpen('myBox', differentIsolate: true).
Describe alternatives you've considered
No Idea
Version

Platform: iOS, Android, Mac, Windows, Linux, Web
Flutter version: 1.22.4
Hive version: 1.4.4

HEYS @Tienisto love from 🇮🇳..
Can you write up, the smallest of code..
I am even not able to enjoy the pleasure of connecting boxes with Work Manager..
Or Any Background Service thing..
There are many in this, who are just quitting, you can send up the shot of your code, of how it will work. (Like idea of code)
Please send it..
Loves
And Thanks @Tienisto
Your Obedient


language-aware folding for heredoc in funcions problem

I got redirected to you guys.
I have realy annoying problem, cuz I cant fold functions if I have heredoc string, cuz folding based on tabulation.
https://github.com/Microsoft/vscode/issues/37494

I'd love this feature... +1.

I'm the author of a language that works on top of PHP, that also supports PHP syntax.   I used to use TextMate, but I decided to finally write an editor extension to properly color the code, so I figured I'd switch to VSCode and build the extension there to support the larger community.  I ran into this issue after only a few minutes.   This is a complete roadblock, and is forcing me to abandon VSCode.

@felixfbecker are we joke to you :angry: how is this not priority, but enhancement?

@felixfbecker are we joke to you 😠 how is this not priority, but enhancement?

@peon501, this kind of impatience is a regular destructor in open source. GitHub has made contributing really better, but overall there is also a lot of noise and some great arrogance happening here and there in these issues. I would wait with this feature for another year... Demotivating great contributions from people like @felixfbecker should be really avoided. Next time hopefully there will be a better more patient and more respectful response.
Thanks.

@peon501 Please keep in mind that everyone who contributes to this project is doing so during their free time. No one gets paid for it and there are a lot of more impactful issues still open.

Yea, I know, sorry I was a bit mad at that day.

Same problem 👌

Good day! Thanks for a great extension!
Is this feature in the roadmap?


skip not working when using vmap file

Hi  i have skip set at 5 seconds for an video in the adserver etc but its not working and setting any skip button after 5 secs, we are uisng a vmap file, that then has the tags within it,  the vast tags within seem to have the skip off set there but not being obeyed?

Hello @spormeon ,
Were you able to reproduce this behavior with IMA's sample ad tags? I tried reproducing using this skippable tag and the videoJS-IMA advanced sample and saw the skip button and the ad was able to be skipped as expected.
If not able to reproduce it with the sample tags, it may be an issue with the specific ad tag you are using.
Please let me know if there are any other steps to reproduce the issue.
Thank you,
Jackson
IMA SDK DevRel

this ios one of the vast tags thats inside the vmap,  it obviously changes on page load but this one doesn't show any skip button.  I have disablecontrols on by the way:
https://securepubads.g.doubleclick.net/gampad/ads?env=vp&gdfp_req=1&output=vast&unviewed_position_start=1&correlator=1597942974449&sz=640x480&url=https%3A%2F%2Fads.vsvl.co.uk%2Fpub000018%2Findex.outside1.html&iu=/1001824/Video-Corner-Units/Video-Corner-Test&description_url=https%3A%2F%2Ftwentyfournews.com&ad_type=video_text_image&pageUrl=https%3A%2F%2Fads.vsvl.co.uk%2Fpub000018%2Findex.outside1.html&cust_params=hb_uuid%3Dundefined%26hb_cache_id%3Dundefined


[Event Request] codeunit 80 "Sales-Post" - OnBeforeFillInvoicePostingBuffer

We would like to fill the "InvoicePostingBuffer" ourselves.
local procedure FillInvoicePostingBuffer(SalesHeader: Record "Sales Header"; SalesLine: Record "Sales Line"; SalesLineACY: Record "Sales Line"; var TempInvoicePostBuffer: Record "Invoice Post. Buffer" temporary; var InvoicePostBuffer: Record "Invoice Post. Buffer")
    var
        GenPostingSetup: Record "General Posting Setup";
        TotalVAT: Decimal;
        TotalVATACY: Decimal;
        TotalAmount: Decimal;
        TotalAmountACY: Decimal;
        AmtToDefer: Decimal;
        AmtToDeferACY: Decimal;
        TotalVATBase: Decimal;
        TotalVATBaseACY: Decimal;
        DeferralAccount: Code[20];
        SalesAccount: Code[20];
        InvDiscAccount: code[20];
        LineDiscAccount: code[20];
        IsHandled: Boolean;
    begin
>>> BEGIN NEW CODE
    IsHandled := false;
    OnBeforeFillInvoicePostingBuffer(SalesHeader, SalesLine, SalesLineACY, TempInvoicePostBuffer,  InvoicePostBuffer, IsHandled)
    if IsHandled then
        exit;
>> END NEW CODE
        GenPostingSetup.Get(SalesLine."Gen. Bus. Posting Group", SalesLine."Gen. Prod. Posting Group");

        InvoicePostBuffer.PrepareSales(SalesLine);
.
.
.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Issue 106 Refactor Application using Flask-RestPlus PurchaseProduct

Refactored purchase endpoint using restplus and changed frontend code and readme accordingly

Codecov Report

Merging #114 (60668dd) into master (4e540c6) will decrease coverage by 1.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
- Coverage   99.21%   98.07%   -1.14%
==========================================
  Files           2        2
  Lines         255      260       +5
==========================================
+ Hits          253      255       +2
- Misses          2        5       +3

Impacted Files
Coverage Δ

service/service.py
97.19% <100.00%> (-1.66%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e540c6...60668dd. Read the comment docs.

IBM Cloud toolchain: Delivery Pipeline deployed products to dev, including commit 680557f16912cdddd62339f07f949b15c91a6d09

IBM Cloud toolchain: Delivery Pipeline deployed products to prod, including commit 680557f16912cdddd62339f07f949b15c91a6d09


destructuring props doesn't work within <script setup>

Vue version
3.3.0-beta.2
Link to minimal reproduction
https://play.vuejs.org/#eNp9j01uwjAQha8y8gaoSNzCLkoieoMewJtABnAb/8ge00WUu3dcWhTRio2lN++Nv3mjePW+vCQUlajjIWhPEJGSh6Gzp0YJikq0ymrjXSAY4eCMT4Q9THAMzsCCdxfKHpyN2TZpIO0HjYEDDfR41BbfgvOxnpsV2GT2OdQuV7/bhPw0N8JyuYKmnf/4BBsO1/J6J1/FgtD4oSNkBVCfX9pxvH40TbVkmfO3jFiLa5HCdL58j85y7TFvqh+D21bwPckz7pa1EmciHyspk/Ufp5IvlDv2ZEiWtMGid2a3Lbflc7FH6sqN7HWkuVtiNMU+uM+IgblKrGcIycMLhiKg7TFgeIi8y/6DvUv8QWfypOwkpi+sPLDG
Steps to reproduce
See error message at bottom of page:
multiplier is not defined

Reproduction
<script setup lang="ts">
import { computed } from 'vue'
const { multiplier } = defineProps<{ multiplier: number }>()
const test = computed(() => multiplier * 2)
</script>

<template>
  <h1>{{ test }}</h1>
</template>

Transformation
import { computed } from 'vue'

export default _defineComponent({
  props: {
    multiplier: {}
  },
  setup(__props) {
    // Missing transformation to __props.multiplier
    const test = computed(() => multiplier * 2)

	return (_ctx,_cache) => {
	  return (_openBlock(), _createElementBlock("h1", null, _toDisplayString(test.value), 1 /* TEXT */))
	}
  }
})

What is expected?
I expect multiplier to be transformed to __props.multiplier.
What is actually happening?
It is not transformed, so the error is triggered.
System Info
No response
Any additional comments?
No response

There was some breaking changes introduced in alpha.10 6b13e04 in relation to previous alpha releases, with the addition of options.propsDestructure check.
Since props destructuring is experimental feature you need to explicitly enable it in @vitejs/plugin-vue or vue-loader. Here's an example of vite config:
export default defineConfig({
  plugins: [
    vue({
      script: {
        propsDestructure: true
      }
    })
  ]
})

Regarding online playground, looks like team forgot to enable this option https://github.com/vuejs/core/blob/main/packages/sfc-playground/vite.config.ts#L12

@sqal Thanks! ❤


question about formula (2)

hi, thank you for releasing this work code. I have a question about formula (2). For the points on the rays sampled in the camera space of frame I, when they are back-projected to frame j, they may not be in a straight line anymore, so why can pixel coordinates and corresponding color be obtained using the accumulation based on nerf？

In other words, can I think that omnimotion is actually using nerf density to replace the attention score in transformer

Hi, you are right that the points on a ray in frame i will no longer form a straight line in frame j. However, we are not doing accumulation in frame j, we are only doing accumulation in frame i where the ray is straight, so I believe the operation still makes sense. It might be a little confusing the fact that we are accumulating flows because flows are computed as the difference between locations in frame i and frame j, but remember that the accumulation is still done in frame i.
I'm not sure how strongly this is connected with attention in transformer, though.

@qianqianwang68 Hi, you're right. What puzzles me is the calculation of the predicted flow. Why can it be compounded to produce a single correspondence? Can you help me explain the rationale behind aggregation？

@qianqianwang68 Hi, you are right, what puzzles me is the flow prediction. Can i understand formula (2) in this way, in fact, if i replace all the j subscripts in formula (2) with i, then I calculate alpha compositing in frame I, and what I get is the coordinate x_i of a three-dimensional point on the surface in frame I, and then map it into frame j, The three-dimensional point coordinates x_j on the surface in frame j are obtained.

the points on a ray in frame i will no longer form a straight line in frame j. However, we are not doing accumulation in frame j, we are only doing accumulation in frame i where the ray is straight, so I believe the operation still makes sense. It might be a little confusing the fact that we are accumulating flows because flows are computed as the difference between locations in frame i and frame j, but remember that the accumulation is still done in frame i.

Maybe the key is that during the alpha-compositing, the (T_k * alpha_k) coefficient is pretty much zero everywhere and it has non-zero value only for single index (the first visible surface along the ray in the left image)? So in fact the alpha compositing step could be seen as: take the first sample with nonzero sigma_i and project that to get x_j?
Could you elaborate more, or give some example if my reasoning is not correct? It seems to me that the other option is "averaging multiple possibly quite different flows / x_j^k" and that does not make sense to me.

Hi @2019EPWL that's a great question! As you pointed out, there are actually two options that one can consider to get the mapping from a pixel in frame i to a 3D location in frame j. One is as in the paper, to first compute the mapping from i to j for all samples on the ray and then alpha-composite them. The other is to first compute the 3D location in frame i, and then map this single 3D location in frame i to frame j using the mapping network. We actually experimented with both and found that only with the former could we learn a meaningful mapping network. My intuition for this is simple: For the former, the mapping network receives gradients for all samples on the ray which is a denser signal and good for optimization, but for the latter the mapping network only receives gradients for a single point on the ray, which is much sparser and harder to train. In addition, at the beginning of training, since the density field hasn't converged, the alpha compositing doesn't yet produce meaningful 3D location, and the mapping network can then receive noisy signals which can hurt training.

@serycjon Your understanding is correct. If we simplify the problem and regard all alpha_k to be either 0 or 1, then the result of (T_k * alpha_k) will be 1 for the first sample on the ray with alpha=1 and 0 for all other samples. In reality, alpha_k is continuous between 0 and 1, but we observe that during optimization, alpha_k always tends to become closer to either 0 or 1 (i.e., either transparent or opaque), especially for the regions that overlap with others in the video. You can observe this by looking at the visualization for  weight_stats in the tensorboard. In addition to that, we also add a distortion loss at late optimization stage to further suppress floaters and encourage the field to be either opaque or transparent.
My intuition for this is similar to what you mentioned. If the field remains semi-transparent, the network will be "averaging multiple possibly quite different flows / x_j^k", which not only doesn't make sense intuitively but also makes it harder for the network to minimize the loss. Although the overall tendency of the density field is to become either fully opaque or transparent, we did also observe that sometimes the method can also take advantage of the softness of the blending process to fit to the noise and errors in the input flow data to further bring the loss down, which is undesirable.


Suggest imports from custom directories

Issue Description
I'm using auto-generated .arb and .dart files for localization in Flutter. It is generated under the directory .dart_tool/flutter_gen/
When using Quick Fix to find AppLocalizations.of(context) it doesn't suggest the import that should be like following:
import 'package:flutter_gen/gen_l10n/app_localizations.dart';
This import is needed for basically every file in the UI that displays text, so it would help a lot if it was possible to get suggested imports from custom directories outside lib/ as well.
What is the fix
Please make a way to customize the directory scope of the import suggestions or make it automatically somehow.
Other information
For now, I am handling this by making another file within the project with the following code:
AppLocalizations l10nOf(BuildContext context) => AppLocalizations.of(context);

What is the mechanism that adds flutter_gen to a package?
Is .dart_tool/package_config.json somehow updated?
Is there any signal in pubspec.yaml that will say that this package requires such package:flutter_gen generation?

As specified in Flutter internationalization, there are two things in pubspec.yaml:
dependencies:
  flutter_localizations:
    sdk: flutter    # this

flutter:
  generate: true    # and this


Update add-to-your-site.md to add Wyam

Added Wyam to list of generators to store static files in the input directory

Deploy preview for netlify-cms-www ready!
Built with commit 8afc55a4e41ae204a8e5c3d5b83baf514f13fbff
https://deploy-preview-1096--netlify-cms-www.netlify.com

Deploy preview for cms-demo ready!
Built with commit 8afc55a4e41ae204a8e5c3d5b83baf514f13fbff
https://deploy-preview-1096--cms-demo.netlify.com


[Bug]: Warhammers use Battleaxe icon

What happened? (Actual vs Expected Behavior)
Warhammers use battleaxe icon. This happens in version 3.0.0 too
What mods for icons where you using, if any?
No response
Steps to Reproduce
Put a warhammer in a container, it has the battleaxe icon displayed on the Quickloot menu
Version
2.0.0
What Skyrim version are you using?
1.6.640
Relevant log output (Expandable)
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Do battleaxes show a warhammer icon? The difference between the two is made using keywords, maybe something is messing with those?

I cannot reproduce it using Aura's Inventory Tweaks, both Warhammers and Battleaxes have the correct icons


iframe内のコンテンツの記録

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

LatteArtの制約であり仕様である．
操作の取得はできないが，スクリーンショットは取得できており，運用対処可能とみられる．
issue整理のため本件クローズとする．


chore: remove tap

Description
Since all tests are already implemented using node:test, tap is unnecessary for this project (following discussion in fastify/fastify#5555 regarding tap deprecation in fastify projects).
Checklist

[x] run npm run test and npm run benchmark
[x] tests and/or benchmarks are included
[ ] documentation is changed or added
[x] commit message and code follows the Developer's Certification of Origin
and the Code of conduct

tap was removed for reasons that do not impact this repo, it does handle code coverage by default. I am not against removing it but we need to set-up code coverage, e.g. with c8.


Fix Dockerfile for ART development

Dockerfile requested by the art team to have a build
Dockerfile.art use cachito for yarn dependencies
Taking that from the nmstate console plugin

/lgtm


Feature/artyom2001/dog-card

Administrative Info
[GitHub Issue #54 ]
Changes
What changes did you make?

Make dog card component
Add responsive styling for various mobile devices

Testing
How did you confirm your changes worked?

TODO

Confirmation of Change

[TODO Screenshot Title]

[TODO Screenshot Link]

According to the figma it seems like the card should be used for part 4 of the application process.
The dog card shouldn't be commented out in the landing page

It looks like the rightmost scrollbar is cutting into the border
The background shouldn't have a scrollbar unless it has enough content to warrant one I think


Copy of PR #685

Copy of #685 so I can fight with merge conflicts.

Merge conflicts are resolved, but there are python unit test failures.


Set up Kanban board

This is a group of two: @kiboma2021 and @emmiiorji taking part in the Recipe App project

Changes Required ♻
Hi @emmiiorji and @kiboma2021,
Nice job, you are almost there.

(Changes Required) Aspects to improve: ♻

[ ] Please add a proper description to the first kanban card because all cards suppose to have a description.

[Optional] suggestions:

Nothing to mention.

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear, and please remember to tag me in your question so I can receive the notification**
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


MSC2773: Room kinds

Rendered

Exciting to work on this happening! One point of early feedback: it is somewhat unclear still whether the room kind would be immutable or not, but I would very much argue that it should be, as explained on MSC 1840

One point of early feedback: it is somewhat unclear still whether the room kind would be immutable or not, but I would very much argue that it should be

@bwindels good news! I've made it mutable in the most complicated way possible.

I've put this up for review - please leave comments on the diff.

I'm not confident in this as an author - closing.


How do you use weechat and powerline?

I noticed in your wiki you highlight weechat and powerline usage, but give no examples and literally I can find none on the net.
Care to show an example?
Thanks

I'm trying to close this repo.  Consider using my Hacktop wiki instead.
I've been meaning to figure out how to get Powerline working myself.
My wiki generally describes the installation process.  The features are generally added when and if I need them myself.
In terms of highlighting, look around the Weechat user guide and search for "highlight"


Auto Crafting Tables Can Pushed Even When Movable Tile Entities Are Disabled

If auto crafting tables are enabled (using the "/carpet autoCraftingTable true" command) and movable tile entities are disabled (either through the default behavior, or by using the "/carpet movableBlockEntities false" command) the crafting table tile entities can still be moved by pistons.
When the crafting tables are moved under these circumstances, their inventories are thrown on to the ground.

This is fully intended, as the normal crafting table is also movable.


Updated Windows mounting example

- What I did
Corrected an example of mounting persistent storage on windows according to http://superuser.com/questions/1051520/docker-windows-container-how-to-mount-a-host-folder-as-data-volume-on-windows
The original syntax was not working...
- How I did it
By typing letters on my keyboard.
- How to verify it
Run the example command. I tested it on WS2016 TP5. Works fine.
- Description for the changelog
Updated example of mounting persistent storage on Windows
- A picture of a cute animal (not mandatory but encouraged)

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "master" git@github.com:petrsvihlik/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

thanks! I think the difference here might be what kind of daemon you're using; the example works if you're running Docker Toolbox (which uses a VirtualBox VM), but may not work against a native Windows Daemon.
We may need to make a distinction here between these setups; let me give this some thinking

Yeah, that was my case. I was using PS against the windows daemon... I probably should have used the Windows Containers documentation on MSDN. However, it's a bit confusing for newcomers. I would expect one syntax across all platforms. :)

ping @friism any suggestions how we should do this?

Ultimately I think we need a separate doc for Windows containers, cc @neilpeterson, or else stage-manage the steps in this doc very carefully. There are at least these cases:

OS X/Linux running against Linux Docker daemon
Windows running against Linux Docker daemon (and here there are sub-cases because you can get owned by cygwin-like shells trying to help you by re-writing paths)
Windows running against Windows daemon

Is there a good way to manage that sort of stuff in the current docs system? @neilpeterson, what are your thoughts?

As a stop gap or even potential long term solution, we do have a doc on MSDN which should detail proper syntax for Windows.
I have a backlog of changes propose into the Docker docs, I could include a reference to the Windows doc, if you would be open to that.
I assume that we will run into similar circumstances with other discrepancies, we may want to figure out some firm strategy around this.

@friism @thaJeztah ?

Actually the 'correct' syntax on native Windows shells is to use backslash not forward slashes....

ping @petrsvihlik

Like @jhowardmsft said, this should be a backslash.

ping @londoncalling can you correct the syntax and carry this pr or otherwise close it? thanks.

sorry, I was off for a couple of days. i've updated the example

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "master" git@github.com:petrsvihlik/docker.git somewhere
$ cd somewhere
$ git rebase -i HEAD~3
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

CI error is incorrect/unrelated.
@petrsvihlik , please sign the most recent commit and squash your commits.

@sfsmithcha LGTM after @petrsvihlik 's fixes to syntax. The docs error is bogus I believe. (I don't have merge permissions on docker/docker so you'll have to merge it.)

This needs to be squashed into 1 commit before it can be merged

LGTM, docs fail doesn't seem to be real. It's complaining about a link that works.

@crosbymichael @sfsmithcha sure, I just need a little bit of time to figure out how :) i tried git rebase -i as shown above and it takes quite a lot of time to run and it fails in the end. i want to dive into it to learn something new. give me a few days pls :)

I somehow f*cked up my branch...Created a new PR: https://github.com/docker/docker/pull/26294


Keyvault reference returning plain text in app.config

I have specified keyvault reference in the appsettings section of an app.config file of a .NET webjob as below:
<appSettings>
<add key="key1" value="@Microsoft.KeyVault(SecretUri=https://keyvaultsecreturi)"/>
</appSettings>
MSI created for App Service and granted get/set permission to Key Vault.  App service also restarted.  However rather than retrieving the secret value from keyvault, the literal plain text of 'value' is being returned instead.
Putting the same value in Application Settings as below works as expected and the actual value is retrieved from keyvault.
Name: key1
Value: @Microsoft.KeyVault(SecretUri=https://keyvaultsecreturi)
Should keyvault reference work for app.config?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7feaa3d0-7233-a3cb-cb9b-a9a55b1f0d7a
Version Independent ID: f41f9d51-52f8-1f45-1043-1344a3b74458
Content: Key Vault references - Azure App Service
Content Source: articles/app-service/app-service-key-vault-references.md
Service: app-service
GitHub Login: @mattchenderson
Microsoft Alias: mahender

Thanks for the feedback! We are currently investigating and will update you shortly.

@chrisorisawayi Thanks for asking question! The detailed conversation here might be helpful.

@chrisorisawayi We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.

@SnehaAgrawal-MSFT Just seeing this.  The referenced thread does not address the issue. In my case, the setup works if the keyvault references is in application settings on the app service, but does not work if the references are moved into the appsettings section of app.config file of the same app service.


Failed to decompile some vmat_c files

Describe the bug
some 'vmat_c' materials cannot be decompiled and exported via Source2Viewer or Decompiler.exe , the console throws an error and nothing else happens
Expected behavior
Decompile material without errors
Relevant log output or exception with stacktrace
[10:49:34.599] Extracting fabric_damaged.vmat_c to "fabric_damaged.vmat"
[10:49:34.601] Failed to extract 'fabric_damaged.vmat_c': Unexpected v64 value for variable 'AdditionalFiles': 3 (0x3)
[10:49:34.605] 1 files failed to extract, check console for more information.
[10:49:34.609] Export completed in 00:00:00.0074366.

What game does this happen in
CS2
Reference file in a Source 2 game
from ...\SteamLibrary\steamapps\common\Counter-Strike Global Offensive\game\csgo\pak01_dir.vpk
materials/de_overpass/nature/clay_ground_footprints_1.vmat_c
materials/de_train/hr_train_s2/plaster/hrts2_plaster_lath_01.vmat_c
materials/fabric/fabric_damaged.vmat_c

etc
What version of VRF are you using?
10.2.3850 4f2f81e04a752675cb4c31ee6572d4c53e0bb321 on Microsoft Windows NT 10.0.22631.0 (GPU: NVIDIA GeForce RTX 3080 Ti/PCIe/SSE2, Driver: 4.6.0 NVIDIA 566.03)

use dev build


Fix runtime error when attempting to view statistics with only one game

Steps:

Start a game
Pick a door
Don't switch doors
Attempt to view statistics

Observe the runtime error that occurs.

thank you!


Suggest case/when if an if/elsif/else can be easily translated

Is your feature request related to a problem? Please describe.
I only learned about the power of case statements quite recently, so there are lots of opportunities in my code that could be written more nicely with a cop that recognizes these patterns. I am sure there are others with the same situation.
Describe the solution you'd like
If there is an if/elsif/else construct with at least one elsif and all conditions can be translated appropriately, suggest using a case/when construct instead.
Additional context
E.g. something like this can be translated:
if a == 1
  # do something
elsif a == 2 || a == 3
   # do something
end

Or something like this:
if a.is_a?(Integer)
  handle_integer(a)
elsif a.is_a?(Float)
  handle_float(a)
end

Note that I might even implement this myself eventually, I'll just add the issue so it's tracked.

I like this idea. This is something that I look for myself in code reviews. I don't think it would be too difficult to implement

Be mindful about the difference between if a == 1 (can be switched to case) and if a == SomeClass (can't be), or if a == method_call (maybe)


Run CI against wheel binaries

Which issue(s) are closed by this pull request?
Closes #117
Changes proposed in this pull request:

Build wheel binaries using CI
Run all tests against wheels
(Source distributions are already tested via tox)

The wheel will in theory be compatible with python 2 and 3, but running the install will ultimately fail if you're using versions not marked as not supported in the setup.py.
In the near future we'll probably need to move some of the CI configuration from the tox config to the travis config anyways, so I'd not bother with those things now.


Feature/redis block query refactor

What is this pull request?
Refactor redis index to remove dependency from mutable storage and fix missing transfer receiver entries.
Details/Features

Move index_block method to separate class
Rewrite method in a functional way

Codecov Report

Merging #776 into develop will increase coverage by 0.59%.
The diff coverage is 31.46%.

@@             Coverage Diff             @@
##           develop     #776      +/-   ##
===========================================
+ Coverage    41.98%   42.58%   +0.59%
===========================================
  Files          311      315       +4
  Lines        13132    13046      -86
  Branches      7414     7281     -133
===========================================
+ Hits          5514     5556      +42
  Misses         727      727
+ Partials      6891     6763     -128

Impacted Files
Coverage Δ

irohad/ametsuchi/impl/redis_block_index.hpp
0% <0%> (ø)

test/module/irohad/ametsuchi/block_query_test.cpp
24.05% <0%> (-1.27%)
:arrow_down:

irohad/ametsuchi/impl/mutable_storage_impl.cpp
47.05% <0%> (+2.23%)
:arrow_up:

...ule/irohad/ametsuchi/block_query_transfer_test.cpp
16.66% <16.66%> (ø)

test/module/irohad/ametsuchi/ametsuchi_fixture.hpp
34.21% <25%> (-3.29%)
:arrow_down:

test/module/irohad/ametsuchi/ametsuchi_test.cpp
26.39% <31.65%> (+10.36%)
:arrow_up:

irohad/ametsuchi/impl/block_index.hpp
50% <50%> (ø)

irohad/ametsuchi/impl/redis_block_index.cpp
52.63% <52.63%> (ø)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25c9012...4ab8a85. Read the comment docs.

@Warchant @bakhtin please check this

Unused private function: 'RedisBlockIndex::indexAccountAssets'

https://github.com/hyperledger/iroha/blob/27c888fe94149e6b1dc761cf846b4d53a04cfc99/irohad/ametsuchi/impl/redis_block_index.cpp#L58-L59


knife bootstrap is not working always giving this error kindly helpful

ERROR: Train::Transports::SSHFailed: SSH session could not be established

@Bharatpg can you provide more details about:

Operating System
Installation Method
Details of files that you're attempting to run and a directory tree from there
Command that you're invoking

while launching new instance for node on aws or anywhere create pem Keyfile only first then try..


edits only from custom_components

I consolidated all edits from custom_components into these commits in my master branch.
Most everything is inside one 'squashed' commit inside this PR, but I did call out one change in a separate commit where hass was giving warnings regarding TOTAL_INCREASING sensor types that sometimes took on negative values. I got rid of the warning by returning the absolute value of the sensor in those cases, but that's likely a hack as I wasn't sure about the real underlying issue. That change is in sensor.py, line 121.

Other than the suggestion around negative value handling, this looks good. Thanks for helping out!

Of course, happy to help! Would you like for me to apply that change to the pull request?

Yes please, if you have time.

Have a little time to work on this, so I'm going to merge it and make the adjustments to sensor type myself.


Support rest params in package:js

A @varargs or @rest annotation would be useful in two use-cases:

To implement ES6 JS helpers with rest params in DDC (see https://github.com/dart-lang/dev_compiler/issues/310):
mixin(base, @js.varargs mixins) {...}

Would be compiled by DDC to:
function mixin(base, ...mixins) {...}

To call external (or internal) methods with rest params. The following call:
foo(a, b, js.varargs(others)) // or js.rest(others)

Would be compiled to ES6 code by DDC:
foo(a, b, ...others)

And to something like the following ES5 code by dart2js (some devil in the this binding details):
foo.apply(null, [a, b].concat(others))

Clearing out 1.15 milestone as the last full push to dev has happened. If any changes are required before 1.15 is shipped, please file a merge request

Closing. We expect to instead leverage possible future core dart language features for rest parameters.

@jacob314 What issue should we follow to get updates on those core Dart features and how they relate to rest parameters?

Here is a related language issue to follow. https://github.com/dart-lang/sdk/issues/16253


Add reset on L+R

Here's a preliminary commit to reset the screen and Uxn CPU upon pressing L+R together. I wasn't sure where to put it so I put it next to the X+Y input check. Please let me know if there's somewhere better it should go!
This will make it much easier to switch ROMs on the DS once we have a proper launcher program that can run at boot.rom :)

Is there a key combo that you'd prefer over L+R? X+Y is already in use for the debugger

https://github.com/asiekierka/uxnds/commit/e4841a3886f488cc76489a0f10c167829db07254


swift_build_support cmake.py: allow bootstrapping CMake on FreeBSD

A given FreeBSD version may not always have latest CMake installed if any at all. Let's bootstrap it the same way we do it on Linux.

@swift-ci smoke test and merge


10218: Added log statement for jvm options.

Added log statement for JVM options.

Codecov Report

Merging #10446 (0f5506c) into master (d9c4315) will decrease coverage by 50.30%.
The diff coverage is 28.57%.

@@              Coverage Diff              @@
##             master   #10446       +/-   ##
=============================================
- Coverage     64.21%   13.92%   -50.30%
+ Complexity     6089      237     -5852
=============================================
  Files          2007     2008        +1
  Lines        109281   109288        +7
  Branches      16692    16692
=============================================
- Hits          70177    15215    -54962
- Misses        33993    92837    +58844
+ Partials       5111     1236     -3875

Flag
Coverage Δ

unittests1
?

unittests2
13.92% <28.57%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...n/java/org/apache/pinot/common/utils/JvmUtils.java
0.00% <0.00%> (ø)

...ava/org/apache/pinot/minion/BaseMinionStarter.java
0.00% <0.00%> (ø)

...e/pinot/broker/broker/helix/BaseBrokerStarter.java
72.72% <100.00%> (+0.11%)
:arrow_up:

...apache/pinot/controller/BaseControllerStarter.java
79.04% <100.00%> (+0.06%)
:arrow_up:

... and 1356 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

@abhioncbr Could this be included in PinotAppConfigs instead, here? https://github.com/apache/pinot/blob/master/pinot-common/src/main/java/org/apache/pinot/common/utils/PinotAppConfigs.java#L64

Sure. Thanks for the review.

@swaminathanmanish can you please review the changes?

Thanks for taking this up. Actually we already have a nice swagger API that dumps all configs which is convenient to use. We don't need to look at the logs :). Do we really need these logs?
curl -X GET "http://localhost:9000/appconfigs" -H "accept: application/json"
jvmConfig": {
"args": [
"-javaagent:/Applications/IntelliJ IDEA CE.app/Contents/lib/idea_rt.jar=50367:/Applications/IntelliJ IDEA CE.app/Contents/bin",
"-Dfile.encoding=UTF-8"
],
"garbageCollectors": [
"G1 Young Generation",
"G1 Old Generation"
],
"envVariables": {
"__CFBundleIdentifier": "com.jetbrains.intellij.ce",
"PATH": "/opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin",
"SHELL": "/bin/zsh",
"MANPATH": "/opt/homebrew/share/man::",
"HOMEBREW_CELLAR": "/opt/homebrew/Cellar",
"OLDPWD": "/",
"USER": "manishswaminathan",
"HOMEBREW_PREFIX": "/opt/homebrew",
"COMMAND_MODE": "unix2003",
"TMPDIR": "/var/folders/xj/yl13brv573g9_v_vhxx7knx00000gn/T/",
"SSH_AUTH_SOCK": "/private/tmp/com.apple.launchd.lyuZIHVl7g/Listeners",
"XPC_FLAGS": "0x0",
"__CF_USER_TEXT_ENCODING": "0x1F5:0x0:0x0",
"LOGNAME": "manishswaminathan",
"LC_CTYPE": "en_US.UTF-8",
"HOMEBREW_REPOSITORY": "/opt/homebrew",
"JAVA_MAIN_CLASS_1666": "org.apache.pinot.tools.Quickstart",
"PWD": "/Users/manishswaminathan/projects/forked/pinot",
"XPC_SERVICE_NAME": "application.com.jetbrains.intellij.ce.975373.976077",
"INFOPATH": "/opt/homebrew/share/info:",
"HOME": "/Users/manishswaminathan"
},

@swaminathanmanish can you please review the changes?

Thanks for taking this up. Actually we already have a nice swagger API that dumps all configs which is convenient to use. We don't need to look at the logs :). Do we really need these logs?
curl -X GET "http://localhost:9000/appconfigs" -H "accept: application/json"
jvmConfig": { "args": [ "-javaagent:/Applications/IntelliJ IDEA CE.app/Contents/lib/idea_rt.jar=50367:/Applications/IntelliJ IDEA CE.app/Contents/bin", "-Dfile.encoding=UTF-8" ], "garbageCollectors": [ "G1 Young Generation", "G1 Old Generation" ], "envVariables": { "__CFBundleIdentifier": "com.jetbrains.intellij.ce", "PATH": "/opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin", "SHELL": "/bin/zsh", "MANPATH": "/opt/homebrew/share/man::", "HOMEBREW_CELLAR": "/opt/homebrew/Cellar", "OLDPWD": "/", "USER": "manishswaminathan", "HOMEBREW_PREFIX": "/opt/homebrew", "COMMAND_MODE": "unix2003", "TMPDIR": "/var/folders/xj/yl13brv573g9_v_vhxx7knx00000gn/T/", "SSH_AUTH_SOCK": "/private/tmp/com.apple.launchd.lyuZIHVl7g/Listeners", "XPC_FLAGS": "0x0", "__CF_USER_TEXT_ENCODING": "0x1F5:0x0:0x0", "LOGNAME": "manishswaminathan", "LC_CTYPE": "en_US.UTF-8", "HOMEBREW_REPOSITORY": "/opt/homebrew", "JAVA_MAIN_CLASS_1666": "org.apache.pinot.tools.Quickstart", "PWD": "/Users/manishswaminathan/projects/forked/pinot", "XPC_SERVICE_NAME": "application.com.jetbrains.intellij.ce.975373.976077", "INFOPATH": "/opt/homebrew/share/info:", "HOME": "/Users/manishswaminathan" },

I think, there is no harm in adding up the logs if it makes someone's life easy. Rest, I have no such strong preferences to add to logs.


uBit.serial.readUntil() with multiple chars (like \r\n) returns as soon as any of the chars is found

From the docs:
https://github.com/lancaster-university/codal-core/blob/350a794a6f43d8e91b4762f110bad675169dc908/source/driver-models/Serial.cpp#L687
 * Reads until one of the delimeters matches a character in the rxBuff
 *
 * @param delimeters a ManagedString containing a sequence of delimeter characters e.g. ManagedString("\r\n")
...
 * @return A ManagedString containing the characters up to a delimeter, or ...

From that I would understand that if we send the string "hello\r\nworld\r\n" then uBit.serial.readUntil("\r\n")  would return first "hello" and then "world".
However, it returns up to the first match from any of the delimeters, so as it matches \r OR \n, we end up getting four strings: "hello",  "" (empty), "world", "" (empty).
The last note from that docstring indicates:
 * @note delimeters are matched on a per byte basis.

Does that mean the current behaviour is the done by design? Doesn't feel as useful for the most common case of trying to match \r\n?

This is by design, we need to clarify the documentation a bit to ensure it is clear it returns on any character match.


Improve F# wrapper functions

[ ] Other function names are nouns while greater/less are adjectives
[ ] Rename interval functions, e.g. ``rightInclusive`` -> ``(-oo; ]``
[ ] Change matrix and vector functions to accept seqs instead of lists

What could be a replacement for them? To me those sound fine, but if there's a better idea...
Agree
If implementable...

isGreater, isLess?

And how are they nouns now? Also now they sound like active actions, instead of nodes. @Happypig375

I'm now thinking, that ``(-oo; ]`` syntax would be inconsistent with those which take two arguments, unless we have something like ``[ ; )`` for those taking two arguments.

Also, vector already accepts a sequence. Unlike matrix, though, but I think we don't need sequences for matrix (otherwise, provide a usecase where matrix should accept a sequence)

greater and less remain, vector already accepts a seq, and I don't know if it's a good idea to rename intervals. If you want, you can add a couple of shortcuts to them (not as main functions)


Link each Docker container to the IP of the attacker

Description of the feature
It could be great to add a feature that links each Docker container to the IP of the attacker.
The Docker container is stopped after session exit and if it's the same IP that reconnects after, honSSH starts the same Docker container.
It could be another way to recognize the attacker like saving his public key and compare if it is the same that connects. (the SSH client always sends his public key no matter what if it's a password auth or not.)
Actual behavior
When an attacker closes the SSH connection, the Docker container is instantly killed and it confuses the attacker if he reconnects after.
Scenario of the feature
The attacker connects to the honeypot, then place for example his DDoS IRC tool, then disconnect, the Docker container stops. Then after a few hours, the attacker reconnects to the honeypot, the Docker container (in which it was previously connected) starts and he finds his previous environment.

A container TTL would also be needed to cleanup at some time.

@unixfox There you go https://github.com/bang-uin/honssh/commits/feature/container_reuse
It's based on my "fs_watch" branch, because i made some changes that simplified "reuse".
It wouldn't be too hard to implement it in the master, but i was too lazy :)
TTL is not implemented yet.
Containers are tied to the attackers ip.
What do you think?

@bang-uin Wow, I really appreciate the time you put on honSSH ;)!
That's a great beginning, if we could integrate another way to recognize the attacker it could be great! Like a priority:

Test if the SSH client provided public key, use this method.
If not, use his IP to recognize him.

I don't know if there are another ways to trace the attacker.

I'm not an ssh protocol guru, but from reading the protocol spec getting the pubkey during the SSH_MSG_USERAUTH_REQUEST is not possible. The pubkey is only provided if that auth method is actually used. Meaning that honssh needs to first make a real pubkey auth and then abort it to do a password fallback. This behaviour would introduce a recognition vector.

Okay and why it could be suspicious? If I try to log into my a random ssh server and my public key is not valid, the SSH client switch to password auth.

Yeah, true :D
Hmm, so i need to find the code where the publickey auth is handled.
Maybe you or @tnich can point me at that.

I'm not sure, but i think that the pubkey auth is not working at all. Looks like there is some implementation missing. @tnich could you give a short statement?
Thanks

Hi Both, Sorry for the slow reply, it's been a busy week.
HonSSH does not work with public keys as it would be tricky to MITM it. It might potentially be possible but I've never seen anyone add their public key to a honeypot before so never looked into it.
@bang-uin I've had a quick look at your container reuse and fa watch stuff - they look great. Can you create a pull request when you are happy with them?
Cheers,

Hi, thanks for the reply.
container_reuse: I would suggest to stick with the IP for now. We can later add publickey if needed.
fs_watch: I'm basically happy with it. The only 2 things i would like to change in future is the twisted-inotify fix and the near zero out possibility. Also i would like to add 2 more things 'max_filesize' and 'revision'. revision would fix the near zero out problem. We'll see, but this will become a separate pull request.

Pull request added https://github.com/tnich/honssh/pull/100


make HTTP client exchangeable

The Guzzle client can be configured in many ways (e.g. with middlewares for debugging or logging). For this, however, the internal client must be exchangeable.
The exchange of the User Agent and URL variables to constants enables the client configuration also outside the connection class.

see #25


the plugin not support latest calico/node now?

I used latest calicoctl to build calico net with latest calico/node. However it seems libnetwork-plugin not support v3 protocol now?

Yeah libnetwork plugin hasn't been updated to work with Calico v3. PR's are welcome, or stick with v2.6


Logical Properties Guide: Sizing

User story
As a  web developer I want to understanding how sizing works with flow relative properties and values.
Acceptance criteria
Guide written and linked to property pages.

/en-US/docs/Web/CSS/CSS_Logical_Properties/Logical_Properties_for_Sizing

Nice work Rachel. I've given both of you guides an edit, and moved them to here to neaten up the URLs and use our title casing rules:

https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Logical_Properties/Sizing
https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Logical_Properties/Basic_concepts

I also updated the parent page so the links are correct.

I think you can close these now, if you are happy with my edits.


Segoe MDL2 Assets Font Download Is Not Latest Version

The provided font download link appears to be out of date. When I compare the available Glyphs in the downloaded font vs what is in C:\Windows\Fonts there are missing Glyphs.

Font Download (from this page) - https://aka.ms/SegoeFonts
Version: 1710

My use case:
I am an app developer and I am using the fonts to have a cross-platform look and feel. Using the provided font download has made it easy to include in my project for other non-windows platform. When attempting to use the SignOut font (F3B1) I was getting invalid Glyphs in the app. After further inspection the provided font stops at Glyph F1CC.
As a workaround I was able to grab the font from my C:\Windows\Fonts

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 60025def-004a-97b9-be6e-a2678e0b4461
Version Independent ID: 51e386c5-e9cf-f900-ba27-1479709f8186
Content: Segoe MDL2 icon guidelines - UWP applications
Content Source: windows-apps-src/design/style/segoe-ui-symbol-font.md
Product: uwp
Technology: design
GitHub Login: @hickeys
Microsoft Alias: hickeys

Just a note to let you know I'm working to get this feedback directed to the right people, but don't have anything to report just yet.

Duplicate of #2043

Where can I find V1.8?

Not updated.


Avoid warning for wf_tags: javascript

Tags need to be in lowercase, so wf_tags: javascript is never a typo.
This patch uses negative lookbehind (Node v9+) to avoid the false positive.
Although this is a small change, we should only merge it once everyone has updated to Node.js v9 or ideally Node.js v10.
Adding DO NOT MERGE label until @petele gives the go-ahead.

After seeing your IO presentation I believe you have the regex skills required :)

@petele to comment on the version of node we use.

Once #6769 is approved and merged, we can approve and merge this one.

:tada: This has been pushed live to https://developers.google.com/web/


feat(x/gov): remove ability for validators to add votes

Description
Closes: #7

Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...

[x] Included the correct type prefix in the PR title
[ ] Added ! to the type prefix if API, client, or state breaking change (i.e., requires minor or major version bump)
[x] Targeted the correct branch (see PR Targeting)
[x] Provided a link to the relevant issue or specification
[x] Followed the guidelines for building SDK modules
[x] Included the necessary unit and integration tests
[x] Added a changelog entry in .changelog (for details, see contributing guidelines)
[ ] Included comments for documenting Go code
[ ] Updated the relevant documentation or specification
[ ] Reviewed "Files changed" and left comments if necessary
[x] Confirmed all CI checks have passed

Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...

[ ] confirmed the correct type prefix in the PR title
[ ] confirmed ! in the type prefix if API or client breaking change
[ ] confirmed all author checklist items have been addressed
[ ] reviewed state machine logic
[ ] reviewed API design and naming
[ ] reviewed documentation is accurate
[ ] reviewed tests and test coverage

One question before merging, don't you think this should only apply to text proposals? I'm afraid we'll have trouble getting a quorum for param changes and upgrade proposals if validators can't vote with their delegation power.

Let's merge for now. I understand what you are saying though. Maybe worth tracking this with an issue!


Incorrect top naming leads to confusing exception

If you do not have top set correctly (ie there is no <top_name>.v for your given <top_name>), then you get this confusing exception:
Traceback (most recent call last):
  File "/home/jgoeders/bfasst/scripts/run_design.py", line 110, in <module>
    main()
  File "/home/jgoeders/bfasst/scripts/run_design.py", line 106, in main
    run_design(Path(args.design_path), args.flow, args.error_flow, flow_args=flow_args)
  File "/home/jgoeders/bfasst/scripts/run_design.py", line 24, in run_design
    design = Design(design_path, build_dir)
  File "/home/jgoeders/bfasst/bfasst/design.py", line 73, in __init__
    self.process_yaml()
  File "/home/jgoeders/bfasst/bfasst/design.py", line 130, in process_yaml
    self.top_file_path = self.find_top_file()
  File "/home/jgoeders/bfasst/bfasst/design.py", line 167, in find_top_file
    return next(valid_paths)
StopIteration

Are we looking to maintain run_design/run_experiment stuff? I've kind of been operating towards the end of removing them from the project. I'm happy to investigate this issue if you'd like, though

No, we aren't going to maintain the old run scripts.


Error: Module domain not declared as a dependency... ‒ JSPM, SystemJS, AWS SDK

Hiya, I've been trying to set up a JSPM project to use the AWS SDK. Here is a link to my code: https://github.com/skorlir/jspm-aws-sdk-issue.
With all my dependencies installed, when I jspm run app, I get the following error message from SystemJS:
Error: Module domain not declared as a dependency of<EMAIL_ADDRESS>
This appears as though it could be related to #45, but to be honest I am unsure.
When I build instead of running, like so:
jspm build app

SystemJS correctly resolves the dependency in jspm_packages. However, my build.js contains some, but not all, of the AWS SDK source code. When I run
node build.js

I get an error message about AWS.CognitoIdentity (which I am trying to instantiate) not being defined.
I have tried console.log('%j', AWS), and the output is clearly incomplete. (It's very long; I have placed it below.) For instance, AWS.S3 is not present, whereas it is when require-ing it directly in the node REPL.
I suspect that the build behavior is symptomatic of the error in jspm run, and not the other way around, but I am not sure so I have included information about both.
Additionally, I noticed that the AWS object is missing the bodies of each of AWS.Protocol.*, which are required something like this:
Protocol: {
  JSON: require('./models/json'),
  // etc
}

So I am wondering if the requires are not being processed correctly?

AWS object dump:
{util:{base64:{},buffer:{},string:{},ini:{},fn:{},date:{},crypto:{crc32Table:[0,1996959894,3993919788,2567524794,124634137,1886057615,3915621685,2657392035,249268274,2044508324,3772115230,2547177864,162941995,2125561021,3887607047,2428444049,498536548,1789927666,4089016648,2227061214,450548861,1843258603,4107580753,2211677639,325883990,1684777152,4251122042,2321926636,335633487,1661365465,4195302755,2366115317,997073096,1281953886,3579855332,2724688242,1006888145,1258607687,3524101629,2768942443,901097722,1119000684,3686517206,2898065728,853044451,1172266101,3705015759,2882616665,651767980,1373503546,3369554304,3218104598,565507253,1454621731,3485111705,3099436303,671266974,1594198024,3322730930,2970347812,795835527,1483230225,3244367275,3060149565,1994146192,31158534,2563907772,4023717930,1907459465,112637215,2680153253,3904427059,2013776290,251722036,2517215374,3775830040,2137656763,141376813,2439277719,3865271297,1802195444,476864866,2238001368,4066508878,1812370925,453092731,2181625025,4111451223,1706088902,314042704,2344532202,4240017532,1658658271,366619977,2362670323,4224994405,1303535960,984961486,2747007092,3569037538,1256170817,1037604311,2765210733,3554079995,1131014506,879679996,2909243462,3663771856,1141124467,855842277,2852801631,3708648649,1342533948,654459306,3188396048,3373015174,1466479909,544179635,3110523913,3462522015,1591671054,702138776,2966460450,3352799412,1504918807,783551873,3082640443,3233442989,3988292384,2596254646,62317068,1957810842,3939845945,2647816111,81470997,1943803523,3814918930,2489596804,225274430,2053790376,3826175755,2466906013,167816743,2097651377,4027552580,2265490386,503444072,1762050814,4150417245,2154129355,426522225,1852507879,4275313526,2312317920,282753626,1742555852,4189708143,2394877945,397917763,1622183637,3604390888,2714866558,953729732,1340076626,3518719985,2797360999,1068828381,1219638859,3624741850,2936675148,906185462,1090812512,3747672003,2825379669,829329135,1181335161,3412177804,3160834842,628085408,1382605366,3423369109,3138078467,570562233,1426400815,3317316542,2998733608,733239954,1555261956,3268935591,3050360625,752459403,1541320221,2607071920,3965973030,1969922972,40735498,2617837225,3943577151,1913087877,83908371,2512341634,3803740692,2075208622,213261112,2463272603,3855990285,2094854071,198958881,2262029012,4057260610,1759359992,534414190,2176718541,4139329115,1873836001,414664567,2282248934,4279200368,1711684554,285281116,2405801727,4167216745,1634467795,376229701,2685067896,3608007406,1308918612,956543938,2808555105,3495958263,1231636301,1047427035,2932959818,3654703836,1088359270,936918000,2847714899,3736837829,1202900863,817233897,3183342108,3401237130,1404277552,615818150,3134207493,3453421203,1423857449,601450431,3009837614,3294710456,1567103746,711928724,3020668471,3272380065,1510334235,755167117]},abort:{}},VERSION:2.4.0,Signers:{},Protocol:{Json:{},Query:{},Rest:{},RestJson:{},RestXml:{}},XML:{},JSON:{},Model:{},config:{credentials:null,credentialProvider:null,region:null,logger:null,apiVersions:{},apiVersion:null,httpOptions:{timeout:120000},maxRedirects:10,paramValidation:true,sslEnabled:true,s3ForcePathStyle:false,s3BucketEndpoint:false,s3DisableBodySigning:true,computeChecksums:true,convertResponseTypes:true,correctClockSkew:false,customUserAgent:null,dynamoDbCrc32:true,systemClockOffset:0,signatureVersion:null,signatureCache:true,retryDelayOptions:{base:100},useAccelerateEndpoint:false},EventListeners:{Core:{_events:{validate:[null,null,null],afterBuild:[null,null,null],restart:[null],sign:[null],validateResponse:[null],send:[null],httpHeaders:[null],httpData:[null],httpDone:[null],retry:[null,null,null,null,null,null],afterRetry:[null]}},CorePost:{_events:{extractData:[null],extractError:[null],httpError:[null]}},Logger:{_events:{complete:[null]}},Json:{_events:{build:[null],extractData:[null],extractError:[null]}},Rest:{_events:{build:[null],extractData:[null],extractError:[null]}},RestJson:{_events:{build:[null],extractData:[null],extractError:[null]}},RestXml:{_events:{build:[null],extractData:[null],extractError:[null]}},Query:{_events:{build:[null],extractData:[null],extractError:[null]}}},events:{_events:{}}}

Having toyed with JSPM overrides and pinned down a bit more details on the bug, I'm now fairly certain this has something to do with dynamic requires - such as
require(path.join(__dirname, /* etc */))
and
if (AWS.utils.isNode()) return require(moduleName).
Any advice for working around this?

In jspm 0.17, you can declare undeclared dependencies through metadata with for example:
jspm install<EMAIL_ADDRESS>-o meta[lib/util.js].deps[]=domain

In jspm 0.16 you'd need to use custom configuration here otherwise:
System.config({
  meta: {
<EMAIL_ADDRESS>{ deps: ['domain'] }
  }
});

Also if the above works for you, a PR for the overrde into the jspm registry is welcome.

@guybedford is there an override for loading JSON without trying to append a ".js" to the filename?

I'd advise using jspm 0.17 and you'll get this for free.
Otherwise you can manually use:
System.config({
  packages: {
<EMAIL_ADDRESS>{
      meta: {
        '*.json': { format: 'json' }
      }
    }
  }
});

jspm -v outputs 0.17.0-beta.22, but I am still getting the error. Adding the "*.json" field to "meta" works.
My apologies for all the errors, but now I am getting a new one.
err  (SystemJS)       throw new Error('Synchronous conditional normalization not supported sync normalizing ' + mapMatch + ' in ' + pkgName);

Error: Synchronous conditional normalization not supported sync normalizing ./stream.js in<EMAIL_ADDRESS>

Ahh, it's the custom meta that is overriding the existing meta. Better is to edit the<EMAIL_ADDRESS>file and add "meta": { "*.json": { "format": "json" } manually.
Is that a browser error or Node error? I'd need to see the full stack to tell where the issue is.

I can publish a version of the code for you to look at.
Basically:
jspm i<EMAIL_ADDRESS>-o meta[lib/util.js].deps[]=domain
Then add the JSON fix to the overrides list. Re-run jspm i to update the overrides.
Here's app/main.js:
import AWS from 'aws-sdk'

console.log("I did not crash horribly!")

I run jspm run app to get the error.

https://github.com/skorlir/jspm-aws-sdk-issue

This project uses a dynamic loader to do all its loading. So everything needed via that would need to be declared via metadata. This error is because as well as domain, you also have to add stream as a dependency there.
I'd advise just installing this project with npm as it's going to be tricky to make it jspm-compatible due to its use of dynamic linking (just as it would be tricky to build it for the browser).

I've actually gotten it working with a fairly simple override. Instead of using the source files, it uses the dist version of the sdk with "format": "global".
Here is the override:
<EMAIL_ADDRESS>{
  "main": "dist/aws-sdk",
  "format": "global",
  "exports": "AWS",
  "map": {
    "process": "@empty"
  }
}

I will look into opening a PR.


Update dockertoolbox to v1.9.1c

Thank you for the contribution. It was merged directly as 4dfdecdf14ec696f1883b0a65ff389e6664a52a9 to keep commit history cleaner. Your contribution is still credited to you.


Why method Input::json() not returns type ParameterBag?

Hi. Why method Input::json() in documentation does not describe the return types Symfony\Component\HttpFoundation\ParameterBag|mixed and instead returns only mixed type. Thanks.

Don't know. You can file an issue on laravel/framework.

Can I manually set (correct) the type which returns the method of the facade via config file?


[feat] Add changelog to our documentation

Brief Summary of The Change

We use sphinx-github-changelog to generate our changelog from github release note
Pull Request checklist
I confirm that the following checklist has been completed.

[x] Add/Change test cases for the changes.
[x] Add/Change the related documentation, should also change docs/source/config.rst when you change file default_config.yaml.
[x] (Optional) Add your change to UPDATING.md when it is an incompatible change.

Codecov Report

Merging #44 (e232709) into main (4460f3b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #44   +/-   ##
=======================================
  Coverage   90.71%   90.71%
=======================================
  Files          59       59
  Lines        2090     2090
=======================================
  Hits         1896     1896
  Misses        194      194

Flag
Coverage Δ

unittests
90.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


50.0.0 Broken?

This is taken from our CI builds.
21:30:11         nox > Creating virtualenv using python3 in .nox/runtests-parametrized-3-coverage-true-crypto-none-transport-tcp
21:30:16         nox > Command python -cimport sys; from distutils.sysconfig import get_python_lib; sys.stdout.write(get_python_lib()) failed with exit code 1:
21:30:16         Traceback (most recent call last):
21:30:16           File "<string>", line 1, in <module>
21:30:16           File "<frozen importlib._bootstrap>", line 969, in _find_and_load
21:30:16           File "<frozen importlib._bootstrap>", line 958, in _find_and_load_unlocked
21:30:16           File "<frozen importlib._bootstrap>", line 666, in _load_unlocked
21:30:16           File "<frozen importlib._bootstrap>", line 577, in module_from_spec
21:30:16           File "/tmp/kitchen/testing/.nox/runtests-parametrized-3-coverage-true-crypto-none-transport-tcp/lib/python3.5/site-packages/_distutils_hack/__init__.py", line 82, in create_module
21:30:16             return importlib.import_module('._distutils', 'setuptools')
21:30:16           File "/tmp/kitchen/testing/.nox/runtests-parametrized-3-coverage-true-crypto-none-transport-tcp/lib/python3.5/importlib/__init__.py", line 126, in import_module
21:30:16             return _bootstrap._gcd_import(name[level:], package, level)
21:30:16           File "<frozen importlib._bootstrap>", line 981, in _gcd_import
21:30:16           File "<frozen importlib._bootstrap>", line 931, in _sanity_check
21:30:16         SystemError: Parent module 'setuptools' not loaded, cannot perform relative import

I can confirm this. We have the same issue.
A simple way to reproduce:
python3 -m venv env
./env/bin/pip install "setuptools == 50.0.0"
./env/bin/python -c "import distutils"

I am in the process of blacklisting 50.0.0 in our dependencies using setuptools != 50.0.0 in our dependencies.

Similar issue here, broken requirements.txt:
setuptools
git+https://github.com/taspinar/twitterscraper.git#egg=twitterscraper

Disallowing v50.0.0 fixes the problem for me:
-setuptools
+setuptools!=50.0.0
 git+https://github.com/taspinar/twitterscraper.git#egg=twitterscraper

I'm unable to replicate the issue on Python 3.8 and Python 3.6 on macOS. I don't yet know what factors cause the failure.

(also Python 3.5)

Same issue is seen with django-autocomplete-light in the context of ModuleNotFoundError: No module named 'dal' in an Ubuntu 18.04 context using Python 3.6

I suspect this issue is the same as #2352. The error message is the same, so assuming so unless I hear otherwise.


Parser optimization

f7896b1 Added a end to end benchmark testsuite, the tested JS file is huge (12MB), glad
that Flow can handle it.
367403e
Refactoring to avoid expose too generic peek function, it is semantics preserving
165ed27
Take advantage of the specialisation in previous commit, since we know the
lookahead buffer is at most 2, we pre-allocate it, so there is no need to implement it using
a dynamic vector, also less code involved.

benchmarking
The improvement is impressive, it is around 10% improvement in the whole pipeline(including the IO time)

Edit:
858d41c rename .js to .data to avoid tool issues
f9669fb guard the correctness for a missing case, previously lex_env could lex more in theory, fix that issue
a04192579a get rid of several runtime assertions, should also be slightly faster
7e09bad get rid of lex_until in junk function

The windows build failure seems to be not relevant to my changes:
Failures
 - yarn - yarn not installed. The package was not found with the source(s) listed.
 Source(s): 'https://chocolatey.org/api/v2/'
 NOTE: When you specify explicit sources, it overrides default sources.
If the package version is a prerelease and you didn't specify `--pre`,
 the package may not be found.
Please see https://chocolatey.or

can you rename the test file to something other than .js? we have tools that search all .js files and don't want that to ever show up

This PR is good for review,  note modulo the perf enhancement, it should also make the code generally more readable, there are some other opportunities, but I will stop here before we figure out a more typical workload for benchmarking

b1d4106 simplify the logic of junk
c1d658e remove the indirection of la_results
The previous benchmark has lots of jitters, so I updated the benchmark that it is more scientific and reproducible:
Prior to this patch:
---- dune exec ./bench.exe
59.212305
59.155172
After this patch:
---- dune exec ./bench.exe
54.252545
54.472153
So the benefit of this PR is in two fold:

It delivers around 10% boost for parsing a large file, the change is quite small, notably only touching one small module: Parser_env.Lookahead.
It makes the lookahead code more readable, this is subjective, but would be happy to hear others' opinions

rebased

a5d1c29 swap the third party sedlexing runtime with a customzied version.
run twice the benchmark

42.909486
42.721931

This is a big jump from 54 -> 42

The last commit added a c file, it may need some support from the build system.
If you have some trouble building it, we can skip the last commit temporarily.
Benchmark running on my machine compared with previous runs:
bench$dune exec ./bench.exe
31.823548bench$dune exec ./bench.exe
31.156909bench$dune exec ./bench.exe

It is a drop from 42 -> 31
655a5d7  This commit reduces the whole allocation by 20%, but it does not translate to too much CPU gain, probably because the allocation is really fast.
cb3699c This commit rewrite the utf8 encoding/decoding logic, it would be nice to have a careful review.
Other commits should be self explained

Ack -- looks like the JavaScript build of the Flow parser isn't happy with the C stub for initializing an array. Is your sense that this optimization is critical and we should make it work with the JS-compiled version? Easier to back it out, if not.

@samwgoldman this optimisation should not have impact over JS.

Easier to back it out, if not.

How to do that? Do we have some setup for conditional compilation?

I meant back out altogether, for native and JS. Was asking about whether
that particular optimization was significant in native.
On Wed, Jul 21, 2021 at 10:34 PM Hongbo Zhang @.***>
wrote:

@samwgoldman https://github.com/samwgoldman this optimisation should
not have impact over JS.
Easier to back it out, if not.
How to do that? Do we have some setup for conditional compilation?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/facebook/flow/pull/8696#issuecomment-884666355, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAB6G6XEDL73ZDCZH52QCZTTY6UWRANCNFSM47NDKNAQ
.

@samwgoldman After a number of trials, finally make it working for the CI!
I also generalized the primitive a little bit so that it will be useful in other cases, e.g a large array of initilization of Nones. It has around 1-2% in my benchmark, these small things add up, so I tend to keep it.

Oh, can you remove the sourcemap comment from the last line of flow_parser_dot_js.data? that comment is 3.8MB, and definitely not representative of a common parsing workload

Oh, can you remove the sourcemap comment from the last line of flow_parser_dot_js.data? that comment is 3.8MB, and definitely not representative of a common parsing workload

I agree, can we leave it in a separate PR coming afterwards for future references, if we do it right now, it will leave all previous data points invalid, so we need do it again..

@bobzhang I'm having trouble importing due to a merge conflict. Would you mind rebasing onto a recent master and force pushing to get a clean history? I think that might help.

@samwgoldman rebased, do you want to clean up the history? I guess that would make you review a bit more difficult


make PiShrink work on/from SD

I have implemented some changes to make PiShrink work directly from the SD device (e.g. /dev/mmcblk0).
It support 3 modes from SD:

copy from SD to image file and shrink
shrink directly on SD
shrink directly on SD and copy to image file.
This last, one, using the new -i flag, is useful when one works with high capacity SD cards.

It looks like it needs some tweeting to get it working since using loop back devices aren't needed on block devices. I merged it into the dev branch and will do a bit of work on it.

Loop is clearly an overhead, but working as is for me. Thanks, and feel free to make it more streamlined.

@cskiraly and @Drewsif , can you include more instructions on how to

shrink directly on SD
shrink directly on SD and copy to image file.

In the README.md file?
Thanks!

Once I have more time to work on it there will be instructions on it in the readme

@Drewsif, thanks for the update.  Looking forward to seeing the updates on the readme.


Cannot quit VSCode

Type: Bug
Steps to reproduce:

open vscode from a terminal, using code . in a local folder
try to close window using CMD+W, or CMD+Q, or by clicking red button on window header, or Menu bar-> Close Window, or Menu bar -> Close Folder, or Menu bar -> Quit Visual Studio Code.
nothing happens
even after closing terminal where code was opened from

VS Code version: Code 1.81.1 (Universal) (6c3e3dba23e8fadc360aed75ce363ba185c49794, 2023-08-09T22:20:33.924Z)
OS version: Darwin arm64 22.5.0
Modes:

System Info

Item
Value

CPUs
Apple M1 (8 x 24)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
2, 3, 2

Memory (System)
16.00GB (0.03GB free)

Process Argv
--crash-reporter-id 119aebae-8248-479f-b12d-893ac5f1205e

Screen Reader
no

VM
0%

Extensions (42)

Extension
Author (truncated)
Version

systemd-unit-file
coo
1.0.6

vscode-eslint
dba
2.4.2

gitlens
eam
14.2.1

LogFileHighlighter
emi
2.16.0

prettier-vscode
esb
10.1.0

copilot
Git
1.105.350

copilot-chat
Git
0.6.0

vscode-github-actions
git
0.26.1

vscode-pull-request-github
Git
0.70.0

terraform
has
2.27.1

clarity-lsp
hir
1.7.2

latex-workshop
Jam
9.13.4

vscode-docker
ms-
1.26.0

vscode-dotnet-runtime
ms-
1.7.1

isort
ms-
2023.10.1

python
ms-
2023.14.0

vscode-pylance
ms-
2023.8.40

jupyter
ms-
2023.7.1002162226

jupyter-keymap
ms-
1.1.2

jupyter-renderers
ms-
1.0.17

vscode-jupyter-cell-tags
ms-
0.1.8

vscode-jupyter-slideshow
ms-
0.1.5

remote-containers
ms-
0.304.0

remote-ssh
ms-
0.102.0

remote-ssh-edit
ms-
0.86.0

cmake-tools
ms-
1.15.31

cpptools
ms-
1.17.4

cpptools-extension-pack
ms-
1.3.0

live-server
ms-
0.4.9

makefile-tools
ms-
0.7.0

remote-explorer
ms-
0.4.1

vsliveshare
ms-
1.0.5883

hardhat-solidity
Nom
0.7.3

postman-for-vscode
Pos
0.6.1

rust-analyzer
rus
0.3.1631

even-better-toml
tam
0.19.2

ayu
tea
1.0.5

cmake
twx
0.0.17

vscode-lldb
vad
1.9.2

vscode-todo-highlight
way
1.0.5

eno
Wsc
2.3.53

markdown-all-in-one
yzh
3.5.1

(3 theme extensions excluded)

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
vscorecescf:30445987
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30410667
vsclangdc:30486549
c4g48928:30535728
dsvsc012:30540252
pynewext54:30695312
azure-dev_surveyone:30548225
vscccc:30803845
282f8724:30602487
f6dab269:30613381
2i9eh265:30646982
showlangstatbar:30737416
03d35959:30757346
pythonfmttext:30731395
fixshowwlkth:30771522
showindicator:30805244
pythongtdpath:30769146
i26e3531:30792625
gsofa:30804715
pythonnosmt12:30797651
pythonidxpt:30805730
pythonnoceb:30805159
dsvsc013:30795093
dsvsc014:30804076
diffeditorv2:30812749

Maybe I should add that it only happens with this particular folder, as I have found. It has nothing special in it, two python scripts and two shell scripts. Nothing is running/being debugged, or anything like that.

Can you try to reproduce with our nightly insider builds? You can give our preview releases a try from: https://code.visualstudio.com/insiders/

Thanks, I could not reproduce it with nightly.
Strangely enough, I cannot reproduce it anymore with regular code . now either. Going to try more and report back

Ok, we can reopen then if you found steps to reproduce.


Create a label service to translate language abbreviations to full language descriptions

In DAMS, we need to translate abbreviated language codes (ie fr) that collections are available in to the full language description (ie French). This issue has some details.
This registry can be used to make the translation. This is also the registry the linked data platform uses.

@EricNebeker
This issue will be for some work @jrmerz is helping with. For the collections, you'll want to define something like:
"schema:inLanguage": [
    {@id: "https://www.iana.org/assignments/language-subtag-registry#fr"},
    {@id: "https://www.iana.org/assignments/language-subtag-registry#la"}
  ]

  // or

  "schema:inLanguage": {@id: "https://www.iana.org/assignments/language-subtag-registry#fr"}

If collections are imported this way, the label service will create a name attribute and assign it the full description.


Review documentation around compute REPL and actual usage

https://suborbital.github.io/docs/compute/quickstart/run-compute-locally#repl

you will be prompted to start a REPL:

In my experience I'm dropped into the REPL without asking, or if the docs are referring to the Press enter to launch the local Compute REPL, then... I don't know what other choices I have besides hard exiting with a CTRL-C

you will be prompted to start a REPL:

In my experience I'm dropped into the REPL without asking, or if the docs are referring to the Press enter to launch the local Compute REPL, then... I don't know what other choices I have besides hard exiting with a CTRL-C

So are you feeling like the statement should give more information, or is there something else you'd like to see here?

I think the documentation is inaccurate here. I'm not prompted to start a REPL, I am placed into one immediately. My hesitation is I don't know whether I have the correct words for what's happening or whether what I mean by the words is what other people mean by those words.

I think the documentation is inaccurate here. I'm not prompted to start a REPL, I am placed into one immediately. My hesitation is I don't know whether I have the correct words for what's happening or whether what I mean by the words is what other people mean by those words.

So @javorszky I think you're referring to the "Press enter to launch the local Compute REPL..." instruction at the bottom of the image above, and seeing that in the context of the doc's statement "When you first launch Compute, you will be prompted to start a REPL," right?
Would it sit better with you if that sentence in the docs instead said "When you first launch Compute you will be prompted to press enter, which will start a REPL?"

Prompt, to me at least, means I have a choice. I can choose not to. Here I don't really have a choice, I can either press enter, which will launch the REPL, press anything else which will do nothing (I think), or CTRL+C out of it.
The prompt to launch the REPL is unnecessary as it is without something else. I think the two possible solutions here are:

drop me into REPL automatically
offer to drop me into the REPL automatically when I press Enter, or exit out if I press Esc. CTRL+C implies something has gone wrong and I'm terminating a script halfway through what it was doing

Thinking about it it's an application issue rather than a documentation issue.
Also that dropping into the REPL happens on every launch of compute, not just the first, though I can't test (different issue).
I think documentation could sound like

When you run Compute, it will wait for your input to start a REPL where you can add / edit functions.

I think documentation could sound like

When you run Compute, it will wait for you to press enter to start a REPL where you can add / edit functions.

Works for me!


Create custom map

Should have a hand drawn style and clearly show the landmarks of #1

Probably not hand drawn. Instead I'll go for a clean simplistic style on top of a top-down view of the world. This should better complement the low poly 3D world than a hand drawn map.


PHP 5.3 / 5.4 compatibility

I've updated this great lib after some months and sadly I've discovered that the compatibility with PHP 5.3 has been dropped.
Is there a chance to get it back?

I don't think it's a great idea to support PHP 5.3. Basically the main reason is that is no longer being supported by PHP itself. It does NOT receive updates or even security patches. Therefore both PHP 5.3 and PHP 5.4 should NOT be used anymore...
For more info, check the timeline of all PHP versions. http://php.net/supported-versions.php

I agree. It is just because I'm using json-api on an older hosting platform that still runs PHP 5.3 and 5.4.
Anyway 5.4 is not technically ended right now, no plans for it too?

Sorry for reopening but correct me if I'm wrong. Does the support to at least 5.4 magically returns if you simple replace Relationship::class with get_class($relationship) in https://github.com/tobscure/json-api/blob/master/src/AbstractSerializer.php#L65 ?

:-1: for supporting unmaintained php versions due to security reasons.

If "supporting" means "give support", I'm with you.
But, in this case, we are talking about letting people use this library on a platform (5.4) that is still present in many hosting services. To be precise, according to w3techs, PHP 5.4 is used by the 30% of the market.
If I was the author of a library of that is suitable for a lot of needs, like json-api, I'd friendly keep the support to at least the "most recent discontinued" version, or I'll lose an important user base.

If "supporting" means "give support", I'm with you.

No, I mean forcefully preventing.

To be precise, according to w3techs, PHP 5.4 is used by the 30% of the market.

I don't know where they have their data from, but it looks like BS to me. If it's via the php version header, than anyone with a non-crappy setup will have disabled that header broadcasting the php version.

https://seld.be/notes/php-versions-stats-2015-edition is a more accurate reflection.

Well... just look at the intro of your article:

A quick note on methodology, because all these stats are imperfect as they just sample some subset of the PHP user base. I look in the packagist.org logs of the last 28 days for GET /packages.json which represents a composer update done by someone. Composer sends the PHP version it is running with in its User-Agent header, so I can use that to see which PHP versions people are using Composer with. Of course this data set is probably biased towards development machines and CI servers and as such it should also be taken with a grain of salt.

Seem waaay more inaccurate to me. Instead, w3techs website is even suggested by the PHP team itself: http://php.net/usage.php
Don't say "BS!" for things to which you disagree ;)

http://php.net/usage.php

This doesn't reflect the usage of the target audience. We're not targeting wordpress users using php 4, we're targeting people using composer on real applications.

We're not targeting wordpress users using php 4
No one said that.

Well, those version stats include those people.

Well, tbh, my real view is I don't care what version of php people are using, if it's not a maintained version, then they need to upgrade, end of story.

If it's just about the ::class constant, then I agree it doesn't hurt to make this small change. This is a library, not an application. Application creators / maintainers are responsible themselves to stay on supported PHP versions. If for some reason they can't make that switch, then we have no reason to put any obstacles in their way.

I agree with GrahamCampbell. If the creator of the language deprecates a version, it should not be used anymore. It may be prone to bugs and or security issues. The only outcome is being hacked or not able to maintain due to unexpected behaviour. Maybe not soon, but it has no other outcome I'm afraid.
Now the question you should ask is; "Should the whole community stick with an old, outdated, syntax just to please anyone who is unable to upgrade?". My personal answer is no, we should not.
If some one is using an old outdated version of PHP, his main concern should be how to upgrade instead of make new features. I can go on and on about the current state of the world and the many security issues we encounter daily. But I hope you get the point...

So before everything gets all emotional and people start fighting I would propose a solving solution. I think both parties have made their arguments clear. This is essentially a project of @tobscure, so lets ask his opinion. Also I looked to all people involved in the discussion and placed them into two groups as some kind of voting mechanism.

supports EOL PHP
does not support EOL PHP

@alessandrofrancesconi
@byCedric

@franzliedke
@GrahamCampbell

@jbrooksuk

@vinkla

If your name is listed, and don't want to be listed, drop me a pm.

So let's end this by making a decision.

:+1:

@byCedric :+1: GitHub should add votes to issues and pull requests.

It would be nice if we could disagree with each other without getting impolite.
As with everything in development, this decision is one of tradeoffs. Both sides have their merits, obviously. It is simply not true that there's only one true way to handle this.
In the end, it's @tobscure who calls the shots on this repository. Voting won't change that. ;)
And finally, to add something constructive: how about this? We could merge the proposed PR, but leave the PHP version requirement in composer.json intact. That way, PHP 5.4 compatibility is maintained (as there's no real reason to break it - we're currently just saving a few keystrokes), but we still encourage the use of supported PHP versions. If somebody "knows what they're doing" or has no choice but to use an unsupported PHP version (for whatever reason), they can explicitly use this library on PHP 5.4 by installing it with Composer's --ignore-platform-reqs.

I am happy this discussion is close to reach a conclusion.
My company is using PHP 5.4 because of some third parties libraries, including APC.
Of course we are going to move forward to the head of PHP by Sept 2016 using PHP 7, but this is a major upgrade meaning changing our Zend Framework 1.12, APC, etc.
Until now and then, I can not enjoy all the improvements you have made since approx August 2015.

We, as developers we should encourage version upgrade , not downgrade it.
-1 for downgrade.

As developers we should encourage version upgrade, not downgrade it.

No one is encouraging a downgrade. Will you go back to 5.4 after this fix?
We are talking about extended compatibility, it's way different.

@alessandrofrancesconi if someone support old versions people don't mind on upgrading it.

if someone support old versions people don't mind on upgrading it.
Not when the new version brings clear advantages (as for PHP) and the product can easily support both the old and the new release without affecting its functionalities (as for json-api).
I'm wondering why @tobscure didn't express his opinion yet... this discussion is getting hilarious :dancers:

Consider that RedHat comes with php 5.4 (guess why) and enterprise companies use it.
Anyway, you are right guys, but the point is that  you cannot use this API just because the use of a non-necessary feature of the language.

@alessandrofrancesconi now I understand your point. JSON API can easly support it without major modifications, right?

Yes @pedrommone, just look at the push request #78: it's just one line of code.

If you need to support PHP 5.3, why not maintain a patched private repository for your own project as shown in https://getcomposer.org/doc/05-repositories.md#using-private-repositories -- this way the rest of the world doesn't need to worry about it, and  this issue can die a quiet death :skull: :smile_cat: :skull:

Alright folks, sorry about the delay here. Thanks for the informative discussion.
To be honest, my personal preference would be to keep using ::class and not support PHP 5.4. But because I like to please, and because it's such a simple one-off change, I've decided to remove the use the use of ::class (2e1d78e311f6c5879e529ec2310aeec1efe0873d) and thus maintain compatibility with PHP 5.4. As per @franzliedke's suggestion though, the support is unofficial in that the version constraint in composer.json remains unchanged:

If somebody "knows what they're doing" or has no choice but to use an unsupported PHP version (for whatever reason), they can explicitly use this library on PHP 5.4 by installing it with Composer's --ignore-platform-reqs.

In only unofficially supporting it, I'm not making any guarantees about PHP 5.4 compatibility in the future. If too many more instances of potential ::class usage pop up, or other features from later PHP versions are going to be useful, then PHP 5.4 support may disappear.

Thank you!


Check IP in blacklists

Tool to check if the IP that will use is in a blacklist.
e.g. https://sblam.com/blacklist.txt

Done


CASSANDRA-18785: Add support for Sonar analysis

I think we need to do a tiny fix :-)
1 Unknown Licenses

*******************************

Unapproved licenses:

  /Users/mmuzaf/IdeaProjects/cassandra/.build/sonar-quality-profile.xml

The recent commits should fix the issue with:

running on Mac M1
the Scanner waits for analysis results from the server and reports quality gate status (passed/failed), fails the build if the quality gate fails
since the quality gate is defined on the new-code and we do not have any reference, I did some dirty hack to run the quality gate on all code by initially running empty analysis (on an empty sources dir), and then the real analysis. In this case all files are considered new

If you guys know a better way to run the quality gate on all files rather than only those considered new, please share...

https://app.circleci.com/pipelines/github/jacek-lewandowski/cassandra/1072/workflows/d4a3fc43-c1fa-4dae-9bd9-f5d85f42b79c ⚠ - rerunning one job
https://app.circleci.com/pipelines/github/jacek-lewandowski/cassandra/1072/workflows/b23a13d7-fd67-4dec-a1f5-5f27f606b07e


Fix allowUnfreePredicate example following the introduction of pname.

Motivation for this change
The introduction of pname (making name optional) apparently broke the example code provided in the documentation (tested with package skype which only defines a pname and no name). This change fixes it. Note that if specifying a pname became compulsory, we could further simplify the example.

Thanks for the suggestion @veprbl! Updated.

Tip: if the PR needs a "motivation for this change" section, so does the commit message. 😊