Implement Message Editing and Reactions

The latest release of riot-web here (v 1.3.0) has enabled message editing and reactions.
This is great, I've been using the config to enable them on my website and desktop client, and was looking forward to it being released across all platforms.
After updating my clients I came here to check and found no updates that added the two new features.
I was under the impression that one of the reasons labs are used is to hold back features that weren't ready for all platforms, so being slightly confused I checked riot-ios and yup, message editing and reactions added.
Coming back I found that I'd missed that the readme.md had been updated some time ago to point out most of the development is now on something called RiotX. And it seems this is the android client that got message editing and reactions.
So now I'm here to ask the you implement them into your default official client. I'm surprised it wasn't in tandem with the other clients, or even before RiotX especially given how much is missing from it. I can understand the desire to make something better, but until you have at least feature parity with the old app, please release new features on both or at the least on the official default android app and not just the new one that's missing basic features.

Been 4 weeks, any update? This is a pretty major feature missing.

We don't have the bandwidth to work on both Riot Legacy and RiotX on Android.  Instead, RiotX is progressing at top speed to replace Riot Legacy asap; in most respects it's already way better and should be usable day to day as a replacement, leaving legacy for fallback only when you need something specific that only legacy can do.
So, i'm afraid this isn't going to happen (unless someone off the core team felt the urge to go and contribute it, but even then we'd be unlikely to merge it as the last thing we need is to handle support & maintenance for yet more features on Riot legacy).

As mentioned before, I understand the desire to switch completely to working on your new app. But being frank, it's not ready for casual use. According to your play store page for it, it's missing the following:

Account creation
Room settings (list room members, etc.)
Calls
Widgets

Not on the page, but missing:

Sticker support

With support for account creation missing already, it's not ready for new users.
With Stickers missing, normal users in a chat have to use "Legacy" to see what it was.
RiotX is useable, it's nice and smooth, but it's not there yet, there's to much missing. And while you consider the "Legacy" app to be legacy, it's still the official app, and is only missing message editing as far as I know at the moment. While adding new features to it will mean RiotX will take a little longer, it does mean there is at least one feature complete client for your users to use. And I think that's pretty important.
Once RiotX has feature parity with your "Legacy" app, go ham, drop this client completely and shift to it. It's just right now, you seem to be trying to start the process when it's not ready for it.
Note: Legacy is in quotes simply because I don't view it as legacy yet. It doesn't have a replacement.


Add option to force users to confirm tour cancels (using native browser prompt)

Attempt to resolve: Issue https://github.com/shipshapecode/ember-shepherd/issues/56

@djsegal have you tried this out on your end and it works?

@djsegal I implemented this functionality myself, just now. Please try 2.1.5 and see if it works for you!

@rwwagner90 sadly, the way you implemented it doesn't work 😞

the cancel button is directly bound to an anonymous function that calls cancel (inside shepherd).
that's why I had to nest the entire cancel function inside itself

@djsegal it 100% works. I tested it myself. How does it not work for you?

@rwwagner90 you're using the exit button. im talking about the 'X' in the top right of the div

this is what is bound to cancel in an anonymous function inside the shepherd repo

Ah okay. Good catch. We probably need to wrap that x with this lib too

@djsegal really sorry about misunderstanding what you needed here. I should have merged this. I updated to use your solution and gave you credit in the CHANGELOG. I published version 2.2.0 with the fix. Please give it a try!


UI : Crowns & Grammar Skills

On the trees that do NOT have grammar skills, do not display Grammar Skills  in the Crowns pop-up / table. I.e. like it is done for Bonus Skills.

Fixed in 3f1bd5a.


[Feature] Venice Push Status System store needs to have a stronger guarantee since it is a critical piece in Push Job

Willingness to contribute
No. I cannot contribute a bug fix at this time.
Feature Request Proposal
Right now, Venice Push Status System Store creation seems to be a best effort in prod and some stores have it and some stores are not.
But polling DaVinci Push Status System Store is in the critical path of push job offline status polling and if push status system store is not there, the push job will never succeed.
One idea is to have a monitoring service in Controller to periodically check the healthiness of the push status system store for each Venice store and fix it automatically.
Motivation

What is the use case for this feature?

This is to improve write path availability.
Details
No response
What component(s) does this bug affect?

[X] Controller: This is the control-plane for Venice. Used to create/update/query stores and their metadata.
[ ] Router: This is the stateless query-routing layer for serving read requests.
[ ] Server: This is the component that persists all the store data.
[ ] VenicePushJob: This is the component that pushes derived data from Hadoop to Venice backend.
[ ] VenicePulsarSink: This is a Sink connector for Apache Pulsar that pushes data from Pulsar into Venice.
[ ] Thin Client: This is a stateless client users use to query Venice Router for reading store data.
[ ] Fast Client: This is a stateful client users use to query Venice Server for reading store data.
[X] Da Vinci Client: This is an embedded, stateful client that materializes store data locally.
[ ] Samza: This is the library users use to make nearline updates to store data.
[ ] Admin Tool: This is the stand-alone client used for ad-hoc operations on Venice.

In the controller on addVersion, check to make sure the push status system store for the store exists, and if it doesn't exist, try to create it, and if that fails, fail the addVersion call in the controller to abort the push.


Bug located in integration with Aedt

Before submitting the issue

[X] I have searched among the existing issues
[X] I am using a Python virtual environment

Description of the bug
I am trying to run a command in Aedt for ordering the coil terminals, as it is not implemented in PyAedt.
When working with Transient A-Phi formulation and windings+coil terminals, Ansys requires that the coil be ordered. In the GUI that is done by right clicking in the winding and selecting Order Coil Terminals

I want to automate that in Python, so I recorded in IronPython while I did it in the GUI. I ended up with the following code:
oModule = oDesign.GetModule("BoundarySetup")
oModule.OrderCoilTerminals(
	[
		"NAME:Primary_winding_parallel_0",
		"Primary_Parallel_0_Turn_0_copper_terminal",
		"Primary_Parallel_0_Turn_1_copper_terminal"
	])

If I try to run that exact command in Python, I tried:
project.get_module("BoundarySetup").OrderCoilTerminals(
[
    "NAME:Primary_winding_parallel_0",
    "Primary_Parallel_0_Turn_0_copper_terminal",
    "Primary_Parallel_0_Turn_1_copper_terminal"
])

But I get the following error:
Traceback (most recent call last):
  File "C:\Users\alfonso.martinez\AppData\Local\Programs\Python\Python311\Lib\site-packages\ansys\aedt\core\generic\grpc_plugin_dll_class.py", line 118, in __Invoke__
    ret = _retry_ntimes(
          ^^^^^^^^^^^^^^
  File "C:\Users\alfonso.martinez\AppData\Local\Programs\Python\Python311\Lib\site-packages\ansys\aedt\core\generic\general_methods.py", line 863, in _retry_ntimes
    raise AttributeError("Error in Executing Method {}.".format(function.__name__))
AttributeError: Error in Executing Method InvokeAedtObjMethod.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "C:\Users\alfonso.martinez\ansyas\ansyas_mas_loader.py", line 40, in <module>
    ansyas.create_magnetic(
  File "C:\Users\alfonso.martinez\ansyas\ansyas.py", line 344, in create_magnetic
    self.excitation_builder.add_excitation(
  File "C:\Users\alfonso.martinez\ansyas\excitation.py", line 106, in add_excitation
    self.project.get_module("BoundarySetup").OrderCoilTerminals(
  File "C:\Users\alfonso.martinez\AppData\Local\Programs\Python\Python311\Lib\site-packages\ansys\aedt\core\generic\grpc_plugin_dll_class.py", line 138, in DynamicFunc
    return self.__Invoke__(funcName, args)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\alfonso.martinez\AppData\Local\Programs\Python\Python311\Lib\site-packages\ansys\aedt\core\generic\grpc_plugin_dll_class.py", line 129, in __Invoke__
    raise GrpcApiError("Failed to execute gRPC AEDT command: {}".format(funcName))
ansys.aedt.core.generic.general_methods.GrpcApiError: Failed to execute gRPC AEDT command: OrderCoilTerminals

Steps To Reproduce
Written down in the description
Which Operating System are you using?
Windows
Which Python version are you using?
3.11
Installed packages
annotated-types==0.7.0
ansys-pythonnet==3.1.0rc3
attrs==24.2.0
cffi==1.17.1
clr-loader==0.2.6
defusedxml==0.7.1
fonttools==4.54.1
fpdf2==2.8.1
jsonschema==4.23.0
jsonschema-specifications==2024.10.1
numpy==1.26.4
OpenMagneticsVirtualBuilder==0.5.4
pandas==2.2.3
pillow==10.4.0
plumbum==1.9.0
psutil==6.0.0
pyaedt==0.10.0
pycparser==2.22
pydantic==2.9.2
pydantic_core==2.23.4
pyedb==0.30.0
PyMKF @ file:///C:/Users/alfonso.martinez/Downloads/pymkf-0.9.13-cp311-cp311-win_amd64.whl#sha256=7d8cd7c1257a4bd0ca162449886122f4d7d3d5dc2e62801f6bfa18b3fb022e99
python-dateutil==2.9.0.post0
pytomlpp==1.0.13
pytz==2024.2
pywin32==307
PyYAML==6.0.2
referencing==0.35.1
rpds-py==0.20.0
rpyc==6.0.1
Rtree==1.3.0
scikit-rf==1.3.0
scipy==1.14.1
six==1.16.0
toml==0.10.2
typing_extensions==4.12.2
tzdata==2024.2

Hi @AlfVII,
Thanks for opening this issue.
I tried on my side with a dummy file and it works.
Although this is not implemented in PyAEDT, you can access the "BoundarySetup" thanks to oboundary.
In my case it works like that:
self.aedtapp.oboundary.OrderCoilTerminals(["NAME:Winding_65LIKI","Coil_PTJ5R7", "Coil_ETDM14"])
Could you also try to get rid of any indentation inside OrderCoilTerminals?
Let me know,
Thanks,
Giulia

Hi Giulia,
I tried removing the indentation, but still fails.
I managed to reproduce it in a small project, attached in a zip.
ansyas.zip
I am running Ansys 2024 R1, and when I execute test.py, which load the existing project and tries to order the coil I get the same error as before

Hi Alfonso,
I tested your case with both 2024.1 and 2024.2 and I got a strange behavior.
If I open AEDT without touching the excitations and running the method as is:
project.oboundary.OrderCoilTerminals(["NAME:Primary_winding_parallel_0", "Primary_Parallel_0_Turn_0_copper_terminal", "Primary_Parallel_0_Turn_1_copper_terminal"])
I get the same error as you but if I manually change the order of the coils within AEDT and re-run the same line it works.
Still, If I change it back to the original order:

Primary_Parallel_0_Turn_0_copper_terminal
Primary_Parallel_0_Turn_1_copper_terminal
and run the same line it works.

Either is an issue with AEDT or the native API in both cases.
Let me investigate further and I'll let you know.
This will be useful anyway for the PyAEDT method implementation.
Kind regards,
Giulia


Update smart contract lesson to add additional info for execution

The tutorial is well written, however, it overlooks a few simple details.
All of the listed commands need to be run in different directories. This commit adds a note below each command to mention which directory the command needs to be run from.

@rohit-710 Good catch! Thank you for contributing and participating! Your input is much appreciated 🚀

Glad I could help, @0xAleksaOpacic 🙏


Parser crashes on empty file

If there is an empty sway file, the parser will crash. This should instead present an error message.
For example, we have the following directory structure:
my_project/
├── src/
|    └── main.sw
└── Forc.toml

And the my_project/src/main.sw is empty, we get the following error:

I can't seem to reproduce that exact error, instead I get
thread 'main' panicked at 'attempt to subtract with overflow', sway-parse/src/parser.rs:45:21
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@bitzoic which version of forc were you using there?


Parse and Render helper methods?

Might be nice to include Parse (or TryParse) and Render helper methods for the immutable DOM. The implementation would likely involved conversion to/from the mutable DOM so would probably be "slow".

Hmm maybe. But sometimes the absence of such functions can be instructive. In the same way there is no List.nth in F# lists (linked).
I guess that problem can also be solved with the function name though, parseAndConvert or something.

Agreed. I ran into a place while debugging when Render would have been helpful, but there's a cost there so figured it'd be worth thinking whether there's a right way to do it.


disable animations

is there any way to disable animations?
currently I can do it by setting globalAnimation: Animation.linear(duration: 0.0) but this causes the chart to first be displayed as blank then the chart to suddenly appear after a few ms rather than be displayed completed upfront.
adding .animation(nil) modifier to GroupedBarChart works but this has been deprecated in ios15 so is not a long term solution. using the withAnimation and .animation(nil, value: 0) doesn't work.
testing this with grouped bar chart

From what I can see, .animation(nil) has been deprecated but .animation(nil, value: 0) has not.
Also there is a beta version of animation(_:).

.animation(nil, value: 0) doesnt have the same affect as .animation(nil).
the beta https://developer.apple.com/documentation/swiftui/text/animation(_:) is now final in iOS15 - doesn’t has the same affect as .animation(nil)
both of the above start display as the initial frame and then jump to the final frame. The result is the same as setting your .globalanimation modifier in that it initially renders as blank and then the chart appears when rendering the view after a few ms.
this needs to be done within the your function - I think you’ll need to provide an option that doesn’t use the animation.

I also would like to have the ability to disable the animations. Maybe the best solution is to be able to pass in a custom animation. Then you also add the ability to customise.

Custom animations are coming. Until then a solution is to add:
.transaction { transaction in
    transaction.animation = nil
}

This should disable animations. For more see https://www.avanderlee.com/swiftui/disable-animations-transactions/

I have these charts in a scroll view - when they are on-screen there is a noticeable lag as they scroll past (and animation doesn't play until you stop scrolling) - I've turned off the animations as I didn't actually want them, using the .transaction { method shown here - but the lag continues. Not 100% sure if it's the animations - but I can't think what else it might be... Is there any indication when we might be able to completely turn off animations?

I have these charts in a scroll view - when they are on-screen there is a noticeable lag as they scroll past (and animation doesn't play until you stop scrolling) - I've turned off the animations as I didn't actually want them, using the .transaction { method shown here - but the lag continues. Not 100% sure if it's the animations - but I can't think what else it might be... Is there any indication when we might be able to completely turn off animations?

Put your data processing and fetch in a different thread - eg using Task.init() or something.

the transaction solution seems to have broken in iOS16 b1. not sure if this is a bug in the beta or whether they have intentionally broken it.


Failed to install VS Code extensions on windows (not compatible wiht VS Code '1.40.2')

cargo xtask install fails on windows, because
Unable to install extension 'matklad.ra-lsp' as it is not compatible with VS Code '1.40.2'.

The last error message is a little bit misleading, Node and npm are both installed (Node v12.14.0, npm 6.13.4).
The whole output:
PS C:\Users\ben\workspace\rust-analyzer> cargo xtask install
    Finished dev [unoptimized] target(s) in 0.14s
     Running `target\debug\xtask.exe install`

will run: cargo --version
cargo 1.40.0 (bc8e4c8be 2019-11-22)

will run: cargo install --path crates/ra_lsp_server --locked --force
  Installing ra_lsp_server v0.1.0 (C:\Users\ben\workspace\rust-analyzer\crates\ra_lsp_server)
    Updating crates.io index
    Finished release [optimized] target(s) in 1.65s
   Replacing C:\Users\ben\.cargo\bin\ra_lsp_server.exe
    Replaced package `ra_lsp_server v0.1.0 (C:\Users\ben\workspace\rust-analyzer\crates\ra_lsp_server)` with `ra_lsp_se                                                                                rver v0.1.0 (C:\Users\ben\workspace\rust-analyzer\crates\ra_lsp_server)` (executable `ra_lsp_server.exe`)

will run: cmd.exe /c npm --version
6.13.4

will run: cmd.exe /c npm install
audited 457 packages in 2.673s

6 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

will run: cmd.exe /c npm run package

><EMAIL_ADDRESS>package C:\Users\ben\workspace\rust-analyzer\editors\code
> vsce package

Executing prepublish script 'npm run vscode:prepublish'...

><EMAIL_ADDRESS>vscode:prepublish C:\Users\ben\workspace\rust-analyzer\editors\code
> npm run compile

><EMAIL_ADDRESS>compile C:\Users\ben\workspace\rust-analyzer\editors\code
> rollup -c && shx cp src/utils/terminateProcess.sh bundle/terminateProcess.sh

./src/extension.ts → ./bundle/extension.js...
(!) Circular dependencies
src\server.ts -> src\config.ts -> src\server.ts
src\utils\diagnostics\rust.ts -> src\utils\diagnostics\SuggestedFix.ts -> src\utils\diagnostics\rust.ts
1.40.2
f359dd69833dd8800b54d458f6d37ab7c78df520
x64
will run: cmd.exe /c code.cmd --install-extension ./ra-lsp-0.0.1.vsix --force
Installing extensions...
(node:10828) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
(node:10828) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
Unable to install extension 'matklad.ra-lsp' as it is not compatible with VS Code '1.40.2'.
Failed Installing Extensions: ./ra-lsp-0.0.1.vsix

will run: cmd.exe /c code.cmd --list-extensions
Error: install client

Caused by:
    Could not install the Visual Studio Code extension. Please make sure you have at least NodeJS 10.x installed and try again.
error: process didn't exit successfully: `target\debug\xtask.exe install` (exit code: 1)

The extension only works with the latest version of vscode.

A PR to add “and the latest version of vscode” to the note will be welcome!


Adjust debugWindow to the addition of wa_colormap.

After adding wa_colormap to getWindowAttributes in Graphics.X11.Xlib.Extras
in https://github.com/asjo/X11/commit/29c8035648d5b17c09730193ae6aa002c3fc8f5c
this change is needed in xmonad-contrib.

Let's switch over to a record pattern so we don't have to do this kind of update every time we support more WindowAttributes. That should mean we don't have to bump the X11 dependency as well, which is a nice bonus.

Sounds like a great idea - I'll delete this pull request in favour of that solution. Thanks!

Since X11 already accepted the patch, wouldn't it be good to accept the patch in xmonad-contrib, too? For consistency reasons and to make it compile flawlessly.

@ptrxyz I think @dmwit is suggesting a better solution than having to, for every field added to WindowAttributes, add to the code in xmonad-contrib, in lockstep. I'm still a the beginning of the learning curve, so "switch over to a record pattern" is out of my reach currently, that's why I closed this pull request.

I didn't realize you didn't plan on implementing that. Okay.
I've put together a patch for this, but my understanding is that xmonad and xmonad-contrib are currently in code freeze pending a release. I will push once we're unfrozen.

I was planning on trying at some point, but didn't have time, sorry.
Note that if you don't catch exceptions from getWindowAttributes in XMonad, then you should remove the throwIfZero from X11, otherwise the release will be very crashy.

Are xmoand/xmonad-contrib unfrozen already? :)

They weren't really frozen. Just I've been low-spoons of late and I'm not sure anyone else is active.
The debug* modules need a few fixes, some of which are waiting for me to clean up my local copies and submit.


[$1000] Chat - When we delete some messages from a thread, the rest of the undeleted messages disappear

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Login
Enter a chat
Write a message A and click the Send button
Click in Reply in thread
Write a message B and click the Send button
Click in Reply in thread
Write a message C and click the Send button
Click in Reply in thread
Write a message D and click the Send button
Click in Reply in thread
Write a message E and click the Send button
Now delete the message D and B and you will see the rest of the messages for a moment and then they disappear from the thread

Expected Result:
When we delete a message from a thread, the rest of the thread should not be deleted
Actual Result:
When we delete a message from a thread, the rest of the thread is deleted
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] Windows / Chrome
[x] MacOS / Safari

Version Number: 1.3.57-5
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/2450cbe2-aafe-4292-9b42-41fe22094b4e

https://github.com/Expensify/App/assets/78819774/669a166c-bae4-4c76-bbb6-84aa92ac01d7
Expensify/Expensify Issue URL:
Issue reported by:@eusalazar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692252890687509
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0162c908765ad3ae06
Upwork Job ID:<PHONE_NUMBER>676635648
Last Price Increase: 2023-09-21

This is a little bit confusing and I will need input from a C+ or Engineer on the expected behavior here.
https://recordit.co/F1uorCO0ij
I tried to reproduce it here and noticed that we deleted/removed more than just the deleted thread response, which looks like the bug report made. But I want to confirm this behavior is wrong or incorrect. Assigning external to get a hand with this step!

not overdue melvs

@situchan do you agree with the nature of this bug?

@situchan do you agree with the nature of this bug?

Agree

Now we treat deleted message as an invisible action though they have visible children. This is the root cause.
This issue requires both backend and frontend work.

Cool we can recruit help from an internal and external engineer if we need! Are you going provide a proposal @s-alves10 ?

Yes

Proposal
Please re-state the problem that we are trying to solve in this issue.
When we delete some messages from the thread, the rest of the undeleted messages disappear
The slack conversation here seems to be addressing the same problem discussed here.
What is the root cause of that problem?
The root cause of the problem is in the FE and BE.
FE Cause: When we delete the parent report action from the Thread, we pass originalReportID at this location here that represents the parent action’s Report. However, the optimisticParentReportData will update the parent action of parent action’s Report which is what causes this problem. This change was made as part of the PR for this issue here.
BE Cause: The BE is also setting childVisibleActionCount to 0 which is the problem. Detailed discussion is available in this slack conversation here
What changes do you think we should make in order to solve the problem?
There are two changes that need to be made:

Instead of passing the originalReportID here we must pass reportID as shown below:

    const optimisticParentReportData = ReportUtils.getOptimisticDataForParentReportAction(
        reportID,
        optimisticReport.lastVisibleActionCreated,
        CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE,
    );

BE also need to change. The change is mentioned here and here

What alternative solutions did you explore? (Optional)

Proposal
Please re-state the problem that we are trying to solve in this issue.

Send message A(report AA)
Reply in thread(report BB)
Send message B
Reply in thread(report CC)
Send message C
Delete the message B in report BB or report CC

In this case, message B in report BB has a visible child action(message C) and so should be shown as [Deleted Message]. So in report AA, message A should have 1 child action but doesn't show child action count
What is the root cause of that problem?
Please take a look at the below code snippet
https://github.com/Expensify/App/blob/1862aff7d5a4c677b3c7ea0424be1f6361dcc91a/src/libs/actions/Report.js#L1013-L1017
Suppose that we delete a message B in report CC. In this case, originalReportId is BB.
And the parentReportAction is message A here
https://github.com/Expensify/App/blob/1862aff7d5a4c677b3c7ea0424be1f6361dcc91a/src/libs/ReportUtils.js#L1878
We decrease the childVisibleActionCount by one below
https://github.com/Expensify/App/blob/1862aff7d5a4c677b3c7ea0424be1f6361dcc91a/src/libs/ReportUtils.js#L1849-L1851
As you can see, message B is still visible because it has a visible child action, but we decrease the childVisibleActionCount of the message A(parentReportAction).
This is the root cause
What changes do you think we should make in order to solve the problem?
In case a deleted message has visible child actions, we shouldn't decrease the childVisibleActionCount of the parentReportAction
Replace this code
https://github.com/Expensify/App/blob/1862aff7d5a4c677b3c7ea0424be1f6361dcc91a/src/libs/actions/Report.js#L1012-L1020
with
    // Update optimistic data for parent report action if the report is a child report and reportAction has no visible child actions
    const childVisibleActionCount = reportAction.childVisibleActionCount || 0;
    if (childVisibleActionCount === 0) {
        const optimisticParentReportData = ReportUtils.getOptimisticDataForParentReportAction(
            originalReportID,
            optimisticReport.lastVisibleActionCreated,
            CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE,
        );
        if (!_.isEmpty(optimisticParentReportData)) {
            optimisticData.push(optimisticParentReportData);
        }
    }

This logic should be implemented in the backend as well.
The video was recorded in offline mode

Result
https://github.com/Expensify/App/assets/126839717/59a6b239-cff1-46d1-991e-da9f6dbca2da

What alternative solutions did you explore? (Optional)

Proposal
Updated to include fix for #23365.
Note: This issue is also closely related to #19722 and #23450

reviewing updated proposal soon after some urgent DB issues

@situchan let us know when you get a moment to review. If no proposals are valid please state that, and I'll double the bounty accordingly.

@s-alves10 thanks for the proposal. Can you verify that the issue still happens after logout and re-login? To confirm if we should fix backend as well.

@situchan
Yes, this still happens after re-login

@situchan can you prioritize this please?

reviewing today

@situchan are either of the proposals above sufficient to move forward here?

@situchan have you reviewed the proposals yet?

Now we treat deleted message as an invisible action though they have visible children. This is the root cause. This issue requires both backend and frontend work.

I think this is bug to fix.
@s-alves10 do you have any link to this discussion if it's expected?

@situchan

Now we treat deleted message as an invisible action though they have visible children.

I'm sorry. I meant when decrease the visible child action count of parent report action.
You can see the below statement in my proposal. I wanted to say that
As you can see, message B is still visible because it has a visible child action, but we decrease the childVisibleActionCount of the message A(parentReportAction).

@situchan where are we with this one?
is the proposal above sufficient? Or should I pull in someone to get this one moving forward?

@situchan can you give an update here

Can we hold this until #28364 is merged? As we need to test LHN last messages as well.

On Hold until https://github.com/Expensify/App/pull/28364 is merged?

@situchan https://github.com/Expensify/App/pull/28364 has been merged to production

@rojiphil @s-alves10 is your proposal still valid based on latest codebase?

@situchan can you give a quick update on this one

@s-alves10's proposal looks good to me.
We should also update backend logic.
🎀 👀 🎀 C+ reviewed

Yup looks good, agree we should also make the internal changes here

@situchan
PR is ready for review https://github.com/Expensify/App/pull/30317

merged to staging yesterday

PAYMENTS FOR NOV 6

Reporter: @eusalazar [$250] (this was reported prior to price change)
Fix: @s-alves10 [$1000 + $500 Bonus]
PR Review: @situchan [$1000 + $500 Bonus]

assigned Oct 24 - merged PR Oct 26
@situchan can you complete the checklist?
Upwork is not letting me create a job posting right now. I'll keep checking and post the offer links here when I'm able.

@eusalazar offer sent. Once accepted I can process payment!
@s-alves10 offer sent. Once accepted I can process payment!
@situchan please complete checklist and I can send payment

[x] The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/22990
[x] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/22990/files#r1383813987
[x] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[x] Determine if we should create a regression test for this bug.
[x] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

I think this is unusual case and users will most likely not face this.
But in case regression test is still needed:
Regression Test Proposal

Navigate to any chat
Send message A and reply in thread
Send message B and reply in thread
Send message C
Disable network
Delete message B
Verify that the message A still has 1 reply in the chat at Step 2

@eusalazar and @situchan payment made and contract ended - Thank you! 🎉
@s-alves10 once offer is accepted I'll process payment!

@abekkala
Offer accepted. Thanks

@s-alves10 payment made and contract ended - Thank you! 🎉

Yup looks good, agree we should also make the internal changes here

@thienlnam @abekkala is this being handled somewhere?

Good question, I don't remember following up with a change here.
It looks like the last conversation about that happened here https://expensify.slack.com/archives/C049HHMV9SM/p1694502825117099, @chiragsalian do you happen to remember if we made a change here?

Oh, Chirag is on parental leave. Checking the BE code to see if we ended up excluding deleted parent actions from childVisibleActionCount

It doesn't look like we've added it for ADD_COMMENT reportActions. Created an internal issue to keep track of that change


Roll engine c41bbc63d955cc7056a162957ac4eeeca6647dc2..e77e4f0e051cb53754814ffe33df291a551bdba3 (5 commits)

https://github.com/flutter/engine/compare/c41bbc63d955...e77e4f0e051c
git log c41bbc63d955..e77e4f0e051c --no-merges --oneline
e77e4f0e0 [fuchsia] Update buildroot to support arm64 (flutter/engine#10240)
cf46f88e9 Roll src/third_party/skia 9dc0b9e2f86a..e9cb76221597 (12 commits) (flutter/engine#10259)
0d66b3251 [fuchsia] Start building dart_patched_sdk (flutter/engine#10246)
dfe68a0f2 Roll fuchsia/sdk/core/linux-amd64 from 7FSBCYS5vCVwpiozstnbIO6K7sCFQ87UYwo6NkeNrCIC to cYX6VeZcy3RWhV8mZIVF8MI5NvcUSgFRLRZMKpfWxTMC (flutter/engine#10258)
04c18c6f0 Roll fuchsia/sdk/core/mac-amd64 from rJ53P95WbHakJemuGkRE3VOdlvohKPI91VcydLL0n2MC to P-V-0DXgsN-0uCWtbyqNO-do3JScrAvZ3z1_Vj5xdagC (flutter/engine#10256)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (franciscojma@google.com), and stop
the roller if necessary.

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/5936141314818048

Commit queue failed; closing this roll.


fix: gridLines should be under axisLines

🤔 This is a ...

[ ] New feature
[ x ] Bug fix
[ ] Component style update
[ ] TypeScript definition update
[ ] Refactoring
[ ] Code style optimization
[ ] Test Case
[ ] Branch merge
[ ] Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language
Changelog

🇺🇸 English

🇨🇳 Chinese

☑ Self Check before Merge

[ ] All tests pass and/or benchmarks are included
[ ] Commit message follows commit guidelines
[ ] TypeScript definition is updated/provided or not needed
[ ] Changelog is provided or not needed

BTW: G 中出于性能考虑，所有在 new Group || Shape 的时候设置 zIndex 是不会有效的。如果要在 new 的时候排序，有两种方式：

声明的先后顺序
const group = new Group(); group.setZIndex(0);


Is it possible to override the source URL?

Thanks for this awesome tool!
Here is the case, Percollate doesn't provide good enough PDF for some webpage, so I save the webpage, and do some modification, and then setup a simple local web server by python3 -m http.server. Then use Percollate to generate PDF by percollate pdf --output my.pdf http://localhost:8000/my.html
It works great, except the source URL. In generated PDF, source URL is included, and it is Source -> http://localhost:8000/my.html
What I want is to override that URL by the REAL URL, not the localhost one.
I have read the README but couldn't find a clue. Is it possible to do that?
If it is not supported yet, I'd like to contribute. My thought is to add an argument for this purpose, like --url, or realurl. How do you think?

If the only problem is the Source is inaccurate, but the page is otherwise generated correctly, I'd say that at this point it would make sense to use the existing API for achieving this. In particular, two helpful options.
With the --css option, you can hide the source that Percollate generates:
--css ".article__url { display: none; }"

See the default HTML template for other classes you can use.
Now, to introduce the (correct) source back into the PDF, you can either:

include it as part of your page's content
use the --template option to provide your own HTML template, and put the source there.

In the future, while we flesh out the programmatic API for Percollate, it would be much easier to obtain custom things. In the meantime, adding too many options to the command-line interface may not be the best approach.
Hope this helps!

@danburzo Thanks for your reply.

include it as part of your page's content

I am using this approach now.

In the future, while we flesh out the programmatic API for Percollate, it would be much easier to obtain custom things.

I'm looking forward to it

In the meantime, adding too many options to the command-line interface may not be the best approach.

I agree.
Thanks again.


Materialized view creation fails using parameters

Driver version
redshift-connector==2.0.910
Redshift version
PostgreSQL 8.0.2 on i686-pc-linux-gnu, compiled by GCC gcc (GCC) 3.4.2 20041017 (Red Hat 3.4.2-6.fc3), Redshift 1.0.46987
Client Operating System
Arch Linux on WSL (Windows 10 - version: 22H2, build: 19045.2604)
Python version
3.9.13
Problem description
Using parameters when creating a Materialized View can cause the creation to fail. However, if no parameters are used, the creation will succeed even if the statements are the same.
Python Driver trace logs
Traceback (most recent call last):
  File "/home/ajisaka/temp/pyred/test.py", line 30, in <module>
    main()
  File "/home/ajisaka/temp/pyred/test.py", line 24, in main
    cur.execute(f'CREATE MATERIALIZED VIEW ng AS ({definition})', (100,))
  File "/home/ajisaka/temp/pyred/.venv/lib/python3.9/site-packages/redshift_connector/cursor.py", line 240, in execute
    self._c.execute(self, operation, args)
  File "/home/ajisaka/temp/pyred/.venv/lib/python3.9/site-packages/redshift_connector/core.py", line 1783, in execute
    self.handle_messages(cursor)
  File "/home/ajisaka/temp/pyred/.venv/lib/python3.9/site-packages/redshift_connector/core.py", line 1969, in handle_messages
    raise self.error
redshift_connector.error.ProgrammingError: {'S': 'ERROR', 'C': 'XX000', 'M': 'Materialized view could not be created.', 'F': '../src/mv/mv_ddl.cpp', 'L': '1795', 'R': 'DefineMatView'}

Reproduction code
import redshift_connector

from os import environ

def main() -> None:
    conn = redshift_connector.connect(
        database='dwh',
        host='localhost',
        port=5439,
        password=environ['PGPASSWORD'],
        user='admin'
    )

    with conn.cursor() as cur:
        cur.execute('DROP TABLE sample CASCADE')
        cur.execute('CREATE TABLE sample (name TEXT, age INTEGER)')
        definition = 'SELECT * FROM sample WHERE age = %s'

        # This line does not raise any errors
        cur.execute(f'CREATE MATERIALIZED VIEW ok AS ({definition})'.replace('%s', '100'))

        # BUT this line raises an error
        cur.execute(f'CREATE MATERIALIZED VIEW ng AS ({definition})', (100,))
        # redshift_connector.error.ProgrammingError: {'S': 'ERROR', 'C': 'XX000', 'M': 'Materialized view could not be created.', 'F': '../src/mv/mv_ddl.cpp', 'L': '1795', 'R': 'DefineMatView'}

    conn.commit()

if __name__ == '__main__':
    main()

This localhost:5439 is an SSH tunnel to the Redshift host on AWS.
But, using psycopg2 succeeds
import psycopg2

from os import environ

def main() -> None:
    conn = psycopg2.connect(
        database='dwh',
        host='localhost',
        port=5439,
        password=environ['PGPASSWORD'],
        user='admin'
    )

    with conn.cursor() as cur:
        cur.execute('DROP TABLE sample CASCADE')
        cur.execute('CREATE TABLE sample (name TEXT, age INTEGER)')
        definition = 'SELECT * FROM sample WHERE age = %s'

        cur.execute(f'CREATE MATERIALIZED VIEW ok AS ({definition})'.replace('%s', '100'))
        cur.execute(f'CREATE MATERIALIZED VIEW ng AS ({definition})', (100,))

    conn.commit()

if __name__ == '__main__':
    main()

Package versions
psycopg2==2.9.5
$ pip freeze
asn1crypto==1.5.1
beautifulsoup4==4.11.2
boto3==1.26.88
botocore==1.29.88
certifi==2022.12.7
charset-normalizer==3.1.0
idna==3.4
jmespath==1.0.1
lxml==4.9.2
packaging==23.0
psycopg2==2.9.5
python-dateutil==2.8.2
pytz==2022.7.1
redshift-connector==2.0.910
requests==2.28.2
s3transfer==0.6.0
scramp==1.4.4
six==1.16.0
soupsieve==2.4
urllib3==1.26.14

Hi @ajisaka ,
Thanks for opening this issue.  I'm not certain for the reason of this discrepancy, but have an inclination it has to do with limitations for bind parameters on Redshift server. If you're not familiar with "bind parameters", this doc provides a good overview. The difference in behavior you're seeing for the two statements is due to the underlying difference in how the statements are executed on Redshift server.
         # This line does not raise any errors
        cur.execute(f'CREATE MATERIALIZED VIEW ok AS ({definition})'.replace('%s', '100'))

This statement is sent to Redshift server as the string CREATE MATERIALIZED VIEW ok AS (SELECT * FROM sample WHERE age = 100). No bind parameters are sent.
        # BUT this line raises an error
        cur.execute(f'CREATE MATERIALIZED VIEW ng AS ({definition})', (100,))

This statement is sent to Redshift server as the string CREATE MATERIALIZED VIEW ok AS (SELECT * FROM sample WHERE age = %s). A bind parameter of the integer 100 is sent separately.
I'm inclined to think this issue has to do with limitations of bind parameter support as we see similar behavior with using bind parameters in subqueries for UNLOAD statements, #31.
As for why this works with psycopg2, but not redshift-connector, I believe there is some difference in how psyopg2 sends statements + bind parameters to Redshift server that redshift-connector -- possibly the bind parameters are re-joined with the statement before being sent to server.

@Brooke-white

If you're not familiar with "bind parameters"

I think I understand the point.

#31

Thank you. I understand the situation now.
I have decided to work around this problem by providing a function that properly quotes and embeds the value using literal_quote after all.
def embed_values(cur: Cursor, query: str, values: Any) -> str:
    def quote(v: Any) -> str:
        if type(v) == int:
            return str(v)
        if type(v) == str:
            cur.execute('SELECT QUOTE_LITERAL(%s)', v)
            return cur._cur.fetchone()[0]
        raise Exception(f'Not supported: {type(v)}')

    if type(values) == tuple:
        return query % tuple(map(quote, values))

    if type(values) == dict:
        quoted = {k: quote(v) for k, v in values.items()}
        return string.Template(query).substitute(**quoted)

    raise Exception(f'Not supported: values={type(values)}')


Raise exceptions on New Relic status check failure

The send_new_relic_messages_to_sqs script used in our cf.gov-alerts-poll-newrelic job doesn't check to make sure that the API call to New Relic succeeds before it tries to access its JSON. We've seen quite a few job failures with unhelpful error messages ("ValueError: No JSON object could be decoded") and it would be more helpful to actually see what happens when this request fails.
This change uses the built-in raise_for_status() method to first ensure that the response was successful.
Checklist

[X] PR has an informative and human-readable title
[X] Changes are limited to a single goal (no scope creep)
[X] Code can be automatically merged (no conflicts)
[X] Code follows the standards laid out in the CFPB development guidelines
[X] Passes all existing automated tests
[X] Any change in functionality is tested
[X] Reviewers requested with the Reviewers tool :arrow_right:

For future reference, the error we get back from New Relic is "429 Client Error: Too Many Requests for url: https://api.newrelic.com/v2/alerts_violations.json?only_open=true".
The documentation on NR API rate limiting is here. According to that, the API responses contain some useful headers like NewRelic-OverloadProtection-Reset that indicate how long until the limit is reset. It also suggests that we

Send your queries less often; in particular, query less frequently than once per minute (the refresh rate for agent data).

Currently we poll NR every minute. I'm going to open a PR to change this to every 3 minutes as a way to back off our usage without significantly delaying the alerts we might receive.


Client side crash due to earn_meter/cl_earn_meter.gnut #338

Happened in an aegis brawl.
Northstar version: 1.7.0
Logs:
nslog2022-06-01 01-54-22.txt

[CLIENT] Index "3" is beyond array size of 3
entity core = player.GetOffhandWeapons()[3]
Any specific details about what happened before the crash? did you do something? what titan were you playing?

No, I don't think I know what have triggerd the issue, nor do I remember preconditions :(

This should be fixed by #494


Caller does not have access

I am getting the following response error - it appears I have given correct role access to the API client in google
{
"error": {
"errors": [
{
"domain": "global",
"reason": "forbidden",
"message": "Caller does not have storage.objects.get access to object your-bucket/test.txt."
}

This sounds like a ACL / permissions issue.
If you google "Caller does not have storage.objects.get access to ", you'll find some similar issues.


stop installing tomcat native library

Rationale
Ubuntu 22.04's tomcat native library stops at v1.2.31, which conflicts with the embedded version 1.2.34, causing this error: SEVERE: An incompatible version [1.2.31] of the Apache Tomcat Native library is installed, while Tomcat requires version [1.2.34].
As the native library is not necessary (and against LabKey's recommendations anyway), it should not be installed in the image.
Related Pull Requests

Changes

Should this target the branch release24.3-Snapshot so that it will be a part of 24.3 release?

Should this target the branch release24.3-Snapshot so that it will be a part of 24.3 release?

Sounds like a good idea to me


Config.yml settings for resource names

New settings in config.yml to specify custom resource names for Key Vault, Storage Account and MariaDB:
azure_key_vault:
name: custom_kv_name
azure_storage_account:
name: custom_sa_name
database:
name: custom db name (when datatase is to be created)

Please document the new entries in the docs/deploy/index.md#define-the-environment

added documentation


Fine-tuning the fluorescence nuclei and cells model on extra annotated data

Hello,
I have been working with the fluorescence nuclei and cells model, and I would like to fine-tune it on some additional annotated data that I have.
I used the download_model function, which provided the instanseg.pt file. From my understanding, I can extract the weights from this file to create a .pth file to resume training. Is this the correct approach for fine-tuning the pretrained model, or is there a better way to go about this?
Additionally, the dataset I want to fine-tune on contains multi-channel membrane images with corresponding membrane masks, but no nuclear masks. Is it possible to fine-tune just the membrane segmentation portion of the model without needing nuclear annotations, or will the model require both membrane and nuclear channels/masks for effective training?
Thank you very much, and congratulations on the development of InstanSeg! The model performs great and is much faster compared to other segmentation models I’ve used.

Hello,
Unfortunately no, I'm nearly sure there's no way of going from the instanseg.pt file back to the model_weights.pth. and we haven't shared the raw model_weights.pth (although we will do fat some point). Sorry!
Interesting question for training, the truth is, I don't know. But if it were me I'd retrain the model from scratch with both the CPDMI dataset and your own annotations. Training should take around 24h or less on a standard GPU and we explain in the notebook how to download CPDMI. (If not, you run the risk that the model forgets what nuclei look like.) To do this you can specify:
python train.py -data segmentation_dataset.pth -source "[CPDMI_2023, YOUR_DATASET]" -target NC -ci True
By the way, if you make your annotations public then we might be able to do the training for you and make the model available (referencing your contribution).

Hi Thibaut,
Thank you very much for your reply! I will follow your advice and work on training a model on the CPDMI dataset along with my annotations.
Unfortunately, I do not have the permission/authority to release the annotated dataset that I have, but thank you for offering to do the training for and make the model available.

Hello,
Unfortunately no, I'm nearly sure there's no way of going from the instanseg.pt file back to the model_weights.pth. and we haven't shared the raw model_weights.pth (although we will do fat some point). Sorry!
Interesting question for training, the truth is, I don't know. But if it were me I'd retrain the model from scratch with both the CPDMI dataset and your own annotations. Training should take around 24h or less on a standard GPU and we explain in the notebook how to download CPDMI. (If not, you run the risk that the model forgets what nuclei look like.) To do this you can specify:
python train.py -data segmentation_dataset.pth -source "[CPDMI_2023, YOUR_DATASET]" -target NC -ci True
By the way, if you make your annotations public then we might be able to do the training for you and make the model available (referencing your contribution).

Hi Thibaut,
In the above reply, you recommended training a model from scratch on the CPDMI_2023 dataset as well as my own annotations. I appreciate your advice and have been working on training a model using this strategy.
I also would like to try and recreate the fluorescence_nuclei_and_cells pre-trained model that you have made available so I can fine-tune that on my annotations as well. Would you be able to share which specific datasets you used to train this model as well as the general approach you took for training (e.g., training on all datasets simultaneously or sequentially)? I understand if you aren't able to give me that information since you haven't released the model weights yet.
Thank you very much for your help!
Andrew

Hi Andrew,
The command for training the public model was:
python train.py -data segmentation_dataset.pth -source "[CPDMI_2023]" --num_epochs 500 --experiment_str fluorescence_nuclei_and_cells -target NC --channel_invariant True --requested_pixel_size 0.5 --augmentation_type heavy
F1 score peaked at epoch 134 so you could consider reducing the number of epochs.

Hi Thibaut,
I really appreciate your continued support with my implementation of InstanSeg.
I ran the command you provided to recreate the public model, and the F1 score peaked at approximately 0.43. I was just wondering if you would be able to confirm whether that F1 score is similar to the expected value, or if it indicates that I am doing something wrong with the training.
Thanks again!

This is f1_score_joint printed during training? yes this sounds correct.

Apologies, I noticed a bug when training on CPDMI on nuclei and cells simultaneously (model outputs would be nan on first epoch). Did you run into this issue?
This is now fixed.

Apologies, I noticed a bug when training on CPDMI on nuclei and cells simultaneously (model outputs would be nan on first epoch). Did you run into this issue?
This is now fixed.

Thank you for letting me know! I did not run into this issue, but I'll keep an eye out for it moving forward.


⚠ Samsung has degraded performance

In 5dca2a2, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2740 ms

Resolved: Samsung performance has improved in bb24ab9.


Check if item.data is a table

to prevent an error message if it's a number

I didn't investigate why item.data can be a number. It simply checks the type before use item.data.funcParensDisabled.

Thanks


Improved content for Tutorial 9 (QAMP fall'22)

Summary
Enhancing the documentation of Tutorial "09_saving_loading" as a mentee for QAMP 2022.
Mentor: @ElePT
Mentee: @SanyaNanda
Details and comments
Restructured the notebook (Overview, Introduction, Objective, Tutorial, accuracy table and what was learned)
Imports placed where required
Added more explanations and inline comments for better understanding of the code
Hyperlinks to API references wherever required

Suggestion for title:
Saving and Loading Qiskit Machine Learning Models for Continuous Training

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Closing this PR whilst working on updating tutorials. For more info - see here.


fix: unscope styles

:tada: This PR is included in version 1.1.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Laravel Livewire documentation extension

Description
Adds Laravel Livewire Documentation to Raycast

New extension

Screencast
Included within extension's readme
Checklist

[ Done ] I read the extension guidelines
[ Done ] I read the documentation about publishing

Hello @pernielsentikaer 🤙
Thank you so much!
I have already made two changes:

Added versions via json files which get pulled by selected preference

Replaced current icon with a new icon without transparent

Please, let me know if you propose further changes and/or addons!

Hey @pernielsentikaer
I think we are READY 🤩


how to mark messages as read ?

Java project, I want people to know that I've read the message,  what should i do?

See #46

thanks


Missing docs on login users with SAML

Preflight Checklist

[X] I could not find a solution in the existing issues, docs, nor discussions
[ ] I have joined the ZITADEL chat

Describe the docs your are missing or that are wrong
As developer I want to understand how SAML works, how to sign-in and logout users with SAML, so I can integrate my SAML application with ZITADEL
Additional Context

[ ] concepts: what is saml
[ ] concepts: what is oidc
[ ] SAML vs. OIDC; link to blog
[ ] move content from login/login-users to saml section
[ ] link to saml from hosted login page
[ ] link to Endpoints "apis/saml/endpoints"
[ ] Explain how to get metadata
[ ] Explain how to get certificates
[ ] Explain difference to identity brokering/SAML SSO (As identity provider: "guides/integrate/identity-providers/mocksaml")
[ ] SSO integration with SAML, SAML authentication
[ ] Maybe add example with SP: https://github.com/crewjam/saml#getting-started-as-a-service-provider

Please find the first draft here -
https://docs.google.com/document/d/1yJuAmY2-kxqYFXUVbxXpz0wtWi0D8ZPTIu07DC9tWpU/edit
@stebenz @mffap - please review this documentation. Thanks!


Port is set to null - NewService.Check

The port when a new instance of the NewService.Check is set to null when the healthCheckUrl is not set in the application.yml or in the bootstrap.yml.
In this case, the http method is set using the following code and the port is retrieved from the service. I think it should be retrieved from the properties.
/Users/jmirc/.m2/repository/org/springframework/cloud/spring-cloud-consul-discovery/1.0.0.M1/spring-cloud-consul-discovery-1.0.0.M1-sources.jar!/org/springframework/cloud/consul/discovery/ConsulLifecycle.java:77

check.setHttp(String.format("http://%s:%s%s", properties.getHostname(),
					service.getPort(), properties.getHealthCheckPath()));

You can check the consul log to see the problem
2015/06/02 20:39:35 [WARN] agent: http request failed 'http://localhost:null/health': Get http://localhost:null/health: dial tcp: unknown port tcp/null

If I check the healthCheckUrl property, everything works perfectly like
spring:
  cloud:
    consul:
      discovery:
        healthCheckUrl: http://localhost:8080

So M1 depends on a snapshot of s-c-commons.  AbstractDiscoveryLifecycle sets the port first so we can support when you want a random port and set server.port=0.  So we wait to get the port from the container.  Make sure you have the latest s-c-commons.  If not, you'll need to show how to reproduce it.

Ok. I see.
I am using the latest s-c-commons which is 1.0.1.RELEASE and this release doesn't contain the code you describe and the port is not set.  Did you release a new version?

@jmirc no, it would be in a snapshot.  Will need to do a release soon.  See https://github.com/spring-cloud/spring-cloud-consul/blob/master/pom.xml#L61

Tested and it works. I am closing this bug.


Autocomplete value not changed properly while typing using GBoard keyboard

TuSimple/naive-ui version (版本)
2.34.2
Vue version (Vue 版本)
3.2.45
Browser and its version (浏览器及其版本)
Chrome
System and its version (系统及其版本)
Android
Node version (Node 版本)
Reappearance link (重现链接)
https://www.naiveui.com/en-US/light/components/input
Reappearance steps (重现步骤)
Install GBoard keyboard on Android device, then start typing in the autocomplete input.
You will see that the v-model:value will not be triggered until you finish a whole word and press space.
Watch this video please: https://vimeo.com/776126572
Expected results (期望的结果)
The expected behavior is to trigger value change after each key type, not after whole word.
Actual results (实际的结果)
The value change event is triggered only after whole word.
Remarks (补充说明)
Thanks

We should add an ignoreComposition prop on input component.

Hello, any plans to fix this?

This issue does not have any recent activity. If you are still experiencing similar problems, open a new error, including a minimal copy of the problem


Engine Windows Android builds failing due to parsing error while running GN

Generating GN files in: out\android_profile
ERROR at dynamically parsed input that //build/config/win/visual_studio_version.gni:27:7 loaded :1:42: Invalid token.
Calculating hash of toolchain in vs_files\27370823e7. Please wait...
                                         ^
I have no idea what this is.
See //build/toolchain/win/BUILD.gn:19:1: whence it was imported.
import("//build/config/win/visual_studio_version.gni")
^----------------------------------------------------
See //BUILD.gn:5:1: which caused the file to be included.
group("default") {
^-----------------

Skia roll failure: https://github.com/flutter/engine/pull/42371
Postsubmit failure: https://ci.chromium.org/ui/p/flutter/builders/prod/Windows windows_android_aot_engine/3253/overview

I retried a few times but can't get this revert to build successfully: https://github.com/flutter/engine/pull/42370
I suspect there was an environment change on the bots that's tickling //build/vs_toolchain.py into behaving unexpectedly. This is blocking PRs and rollers so setting prio accordingly.
Possibly related?: https://flutter-review.googlesource.com/c/recipes/+/45055

cc @godofredoc

The problem is //build/vs_toolchain.py is trying to get the vs toolchain data from stdout but when vs_toolchain exists locally in prints an extra message that vs_toolchain does not understand.

Here is the revert to set the tool chain env variable to the cache folder: https://flutter-review.googlesource.com/c/recipes/+/45100

Also here is the fix: https://github.com/flutter/buildroot/pull/739

This is resolved, so closing this out.


Fix for #49, YARN-2516, #63, #68, #69 and tunables

Provides fixes for:

HDFS Topology Hooks (Issue #49)
Heap size tuning for the Mapred Job History Server
Subscribes for YARN and Mapred Daemons
HDFS blocksize as a tunable (it will not retroactive change blocksizes if changed, however)
Sets a minimum share to cause YARN Fair Scheduler pre-emption
Enables HBase snapshot support
Adds mapred user on namenode for mapreduce usage, via installing the hadoop-mapreduce package (Issue #68)
Modifies bcpc_jmxtrans to:

Use ps(1)'s lstart instead of start_time (Issue #69)
Use one service[restart jmxtrans on dependent service] to avoid restarting JMX Trans multiple times needlessly (Issue #63)

Looks good.

I removed the HBase snapshot commit.


[21.05] salt: 3003 -> 3003.3

Motivation for this change
3003.3 was published, fixing 2 CVEs: https://docs.saltproject.io/en/latest/topics/releases/3003.3.html
Backport of 4ad4ae68c427ef8458be34051b4e545eb752811c from #136619.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Please cherry-pick every original commit with -x instead of doing this abbreviation.

@mweinelt I cherry-picked it with -x now. The commit message is slightly different than on the original commit, because 21.05 only had 3003 while unstable had 3003.2.

You need to pick all individual commits that led to that version.
c0b46c6b596dd25f32733ff01156d3d769640ab5
da3e6504941a8162f08a9b1e99914d807deada71
4ad4ae68c427ef8458be34051b4e545eb752811c

Okay, here we go

Thanks!


LayoutManager: child views are not measured properly when they are not visible

Hey @thagikura I found a visual bug.
Steps to reproduce:

Make changes to a RecyclerView's data-set that are currently not visible.
Dispatch the updated dataset to the RV's adapter.
Scroll to items that were changed, but were not visible when the change was triggered

Screenshot

AntrixCorporation -> Antri, AskReddit -> Ask, bangalore -> banga, chemicalreactiongifs -> chemi
In my layout, I have an animation that changes the RV's height and this bug gets fixed as soon as the animation is run.

Thanks for filing this. What part did you to the items that were not visible?
Did you change the texts?
Anyway this looks like an issue.

No, I simply inserted a new item.

Ok I found the issue.
Non-visible part of the flex container is not computed currently.

Awesome!

Fixed by #269.
I'll release it in the next alpha version.


cli/v2 panic because of flag redefined after enable aliases

My urfave/cli version is
v2.27.5
Checklist

[Y] Are you running the latest v2 release? The list of releases is here.
[Y] Did you check the manual for your release? The v2 manual is here
[Y] Did you perform a search about this problem? Here's the GitHub guide about searching.

Dependency Management

My project is using go modules.

Describe the bug
After I add Aliases for a flag:
	XDCXDataDirFlag = &flags.DirectoryFlag{
		Name:     "XDCx.datadir",
		Aliases:  []string{"XDCx-datadir"},
		Usage:    "Data directory for the XDCX databases",
		Value:    flags.DirectoryString(filepath.Join(DataDirFlag.Value.String(), "XDCx")),
		Category: flags.XdcxCategory,
	}

some of my test cases failed with below messages:
    test_cmd.go:249: (stderr) XDC-test flag redefined: XDCx.datadir
    test_cmd.go:249: (stderr) panic: XDC-test flag redefined: XDCx.datadir

If I remove Aliases this line, then all test cases passed without error.
To reproduce
git clone https://github.com/gzliudan/XDPoSChain
git checkout cli-alias

# test with Aliases
make all && make test

# test without Aliases
git reset --hard 8aaa6919
make all && make test

Observed behavior
make test reported: flag redefined.
Expected behavior
should pass all test cases.
Want to fix this yourself?
no
Run go version and paste its output here
go version go1.21.13 linux/amd64

Run go env and paste its output here
GO111MODULE=''
GOARCH='amd64'
GOBIN=''
GOCACHE='/home/me/.cache/go-build'
GOENV='/home/me/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/home/me/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/home/me/go'
GOPRIVATE=''
GOPROXY='https://goproxy.cn,direct'
GOROOT='/home/me/govm/golang/go-1.21.13'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/home/me/govm/golang/go-1.21.13/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='go1.21.13'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='gcc'
CXX='g++'
CGO_ENABLED='1'
GOMOD='/home/me/XDPoSChain/go.mod'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build2475665159=/tmp/go-build -gno-record-gcc-switches'

@gzliudan I believe your intent here
https://github.com/gzliudan/XDPoSChain/blob/57e40f59d7fe24a9c1b2d80d9187d3b28d176cd7/cmd/utils/customflags.go#L78
was
	eachName(df.Name, func(name string) {
		set.Var(&df.Value, name, df.Usage)
	})

otherwise you are applying the same name multiple times ?

@gzliudan I believe your intent here
https://github.com/gzliudan/XDPoSChain/blob/57e40f59d7fe24a9c1b2d80d9187d3b28d176cd7/cmd/utils/customflags.go#L78
was
	eachName(df.Name, func(name string) {
		set.Var(&df.Value, name, df.Usage)
	})

otherwise you are applying the same name multiple times ?

The file cmd/utils/customflags.go has been removed in my branch:
https://github.com/gzliudan/XDPoSChain/tree/cli-alias

@gzliudan The same behavior is in your branch as well.
https://github.com/gzliudan/XDPoSChain/blob/cli-alias/internal/flags/flags.go#L83
I believe your intent is
	eachName(f, func(name string) {
		set.Var(&f.Value, name, f.Usage)
	})

Thank your very much. I fixed it by the commit: https://github.com/gzliudan/XDPoSChain/commit/24f53f78fd380878aa0c50924dd43046090f76f8.
But I don't think it's a good solution. Can we check the name is an alias ?

@gzliudan The same behavior is in your branch as well.
https://github.com/gzliudan/XDPoSChain/blob/cli-alias/internal/flags/flags.go#L83
I believe your intent is
	eachName(f, func(name string) {
		set.Var(&f.Value, name, f.Usage)
	})

That panic is what is triggerred by golang flag package so for now there is nothing we can do since you are setting the name directly by flagset

I find a better solution:
change:
func (f *DirectoryFlag) Apply(set *flag.FlagSet) error {
	eachName(f, func(name string) {
		set.Var(&f.Value, f.Name, f.Usage)
	})
	return nil
}

to
func (f *DirectoryFlag) Apply(set *flag.FlagSet) error {
	set.Var(&f.Value, strings.Trim(f.Name, " "), f.Usage)
	return nil
}

I don't think that will work when you have aliases. Have you tested this cli with the alias command ? It won't work

Sorry, I just noticed that the code you recommended before is the best solution.


LICENSE.txt may have some non-relevant content

LICENSE.txt includes both the Apache 2 license and the JSON License.  Is there actually any code in this project under the JSON License?

Thanks, that must have been a copy paste error and I have removed the reference to the JSON License.

Cool, thanks!


Accelerator quantization doc/website update

Motivation and Context

How Has This Been Tested

Types of changes

[x] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have completed my CLA (see CONTRIBUTING)
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Codecov Report

Merging #69 (45428b8) into master (26f831e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #69   +/-   ##
=======================================
  Coverage   94.69%   94.69%
=======================================
  Files         119      119
  Lines        7176     7176
=======================================
  Hits         6795     6795
  Misses        381      381

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26f831e...45428b8. Read the comment docs.


invalid literal for int() with base 10: 'movie'

Hello,
Thanks for you work, the tools is amazing however I have an issue with the MAL integration.
Whenever I'm trying to add collections to my Anime Library it keeps failing on this error.

Any idea on how I can enable some kind of verbose mode to help debugging it ?
Thanks !

there should be a log file created in your config folder can you post that?

what anime comes after Gekijouban Fate/Kaleid in you plex?

This one

ok i see the problem and another problem as well ill try to have a fix out in the next couple of days

No problem at all
Thanks !

the fix has been pushed to develop can you test also delete your config.cache before you run the develop branch

It is currently running and seems to be processing correctly.

I can confirm the fix works

awesome im gonna keep this open untill it moves to master


samples: moving beta samples from java-docs and refactored GA samples

beta.com exists as a domain; a better choice might be video.beta or beta.video for package names.
please fix the System.setOut(null) in tests.  That should never be done.

I see, I will make these changes.


feat: Make index queries reactive

Motivation / Background

This Pull Request ...
Details

Additional information

#6176  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @mykola-vrmchk and the rest of your teammates on  Graphite


Create formatter_juliaformatter.lua

Add a Julia Language formatter

$ARGS is not in the command string so any arguments will not work

I know
Its for if in the future, I see any use of ARGS
For now, its good as it is

If there isn't any other issue, I think its good enough to merge

you should put the ARGS in the string anyway, as people might want to set their own

Should be good enough


implement support for CO2 sensors sending data unencrypted

eg. TFA-Dostmann AIRCO2NTROL Coach CO2 Monitor
i just bought https://www.amazon.de/gp/product/B07R4XM9Z6/ and got the following output from monitor.py
50 03 BA 0D 0D 00 00 00  =>  EB 92 1C 3C 41 D1 E8 3D Checksum error
42 12 A3 F7 0D 00 00 00  =>  A8 B2 1A 7C 43 B1 E8 36 Checksum error
41 0A 22 6D 0D 00 00 00  =>  F8 92 1A 5C 42 B1 E8 49 Checksum error

After checking your nice code (thx!) it seem obvious that this sensors is sending data unencrypted :), this PR implements an automatic check if data is encrypted or not and outputs info on the first un-encrypted message.
Info: data not encrypted
>>> sending dataset CO2: 1002 TMP: 25.2 ..
>>> sending dataset CO2: 1023 TMP: 25.2 ..
>>> sending dataset CO2: 1048 TMP: 25.2 ..
CO2: 1084 TMP: 25.3

Thank you and sorry for the delay!


Additional loggers on debug level

KNTK - 262
Added logging of API requests and responses as suggested in:
https://github.com/kentik/terraform-provider-kentik-synthetics/pull/81#issuecomment-1042346692
Here https://pastebin.com/MB6YQqy0 is a part of debug output containing new loggers.

I'll wait for Daniel's approval before merging the code.


Support for decimal milliseconds

(ver 2.13.0)
The ISO standard allows for any number of decimal seconds before the 'Z' in a dateTime string. The .net platform seems to use 7 decimal places - while the moment.js library is only parsing out the first 3 decimal places.
I have monkey patched the formatter (toISOString()) to pull the full 7 digits from the creation object - but this is a terrible hack. Patching the parser would be much better - but is beyond my current understanding.
Perhaps there is another work-around?

Because Moment.js is a wrapper for the Date object in JavaScript, we are limited to three decimal places (milliseconds). This is because that is all that the date object supports, so there is truly no way to store more. You shouldn't have to monkey patch anything to get seven decimal places to display or parse though. Just be aware that only the first three will actually be used.
moment('2016-01-01T05:21:22.1234567Z').format('YYYY-MM-DDTHH:mm:ss.SSSSSSS')
"2015-12-31T23:21:22.1230000"

Note that the output is zero filled, but there are seven digits both ways.

Maggie,
Ah. I hadn't realised this was a limitation of Javascript.

I had found the option for formatting that you had mentioned - but

for me I really need those extra digits. Zeros are not good enough.
My 'monkey patch' looks at the creationData for the moment and

manually parses the milliseconds from the input string (if it is
available).
    //Monkey patch the moment library to use 7 decimal places for

seconds in it's standard ISO format - to match C#
moment.fn._oldToISOString = moment.fn.toISOString;
moment.fn.toISOString = function () {
try {
var originalDateSplit = moment(this).creationData
().input.split(".");
var milliseconds = originalDateSplit
[originalDateSplit.length - 1];
if (milliseconds.indexOf(this.milliseconds()) === 0) {
return moment(this).format('YYYY-MM-DD[T]HH:mm:ss.') +
milliseconds + "Z";
} else {
return moment(this)._oldToISOString();
}
} catch (error) {
return moment(this)._oldToISOString();
}
}
It is not pretty - and will only work for moments that were

originally parsed out of an ISO date string. It will also be inconsistent
with the milliseconds() function. A better idea would be to intercept the
parsing process and pull any decimal seconds into a separate property on
the moment object - then we can return that as needed.
However - I do appreciate that we are moving beyond the scope of the
moment.js library at this point - it would no longer be a wrapper for a
Javascript Date object.
Perhaps we could make this limitation a little clear in the moment.js

documentation? Right now the millisecond truncation is implied from the
example code, but not explicitly described - and there is no explanation as
to why it behaves in this way.
Thank you for your help Maggie - it is much appreciated.

Regards,
Ben Hathaway
Software Developer
DATUM - Geotechnical and Structural Monitoring
Datum House, The Pavilions, Bridge Hall Lane, Bury, Lancashire. UK. BL9
7NX.
( Switchboard +44 (0)161 797 5511 (ext 463)
B http://www.datummonitoring.com

<EMAIL_ADDRESS>
From:	Maggie Pint<EMAIL_ADDRESS>To:	moment/moment<EMAIL_ADDRESS>Cc:	benhathawaydatum<EMAIL_ADDRESS>Author
<EMAIL_ADDRESS>Date:	22/06/2016 13:23
Subject:	Re: [moment/moment] Support for decimal milliseconds (#3256)
Because Moment.js is a wrapper for the Date object in JavaScript, we are
limited to three decimal places (milliseconds). This is because that is all
that the date object supports, so there is truly no way to store more. You
shouldn't have to monkey patch anything to get seven decimal places to
display or parse though. Just be aware that only the first three will
actually be used.
moment('2016-01-01T05:21:22.1234567Z').format
('YYYY-MM-DDTHH:mm:ss.SSSSSSS')
"2015-12-31T23:21:22.1230000"
Note that the output is zero filled, but there are seven digits both ways.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
             Click here to report this email as spam.

I am looking for the same. After debugging through moment.js, I noticed it calls a zerofill function.
Since the resulting value is a string, I don't see why it zero fills it🤔🤔🤔
For example, I have this:
const value =<PHONE_NUMBER>963;
const formatString = 'MM/DD/YYYY HH:mm:ss.SSSSSS';
const val = moment.utc(value).format(formatString);
console.log(val);

It prints 07/30/2020 08:53:50.963000 instead of 07/30/2020 08:53:50.963939
Further, I noticed older version of moment.js did not do this zero fill, for example ver 2.5.
I will have to write a custom formatter now to retain correct info in the date unless a change is done on moment.js. Any chance we can make this change?


CallbackPath on Oauth Authentication cannot specify HTTPS or HTTP protocol

Hi, using Oauth for the authentication

          .AddOAuth(OpenIdConnectDefaults.AuthenticationScheme, x =>
            {
                x.SignInScheme = "Cookies";
                x.ClaimsIssuer = Configuration.GetSection("UAA").GetChildren().Where(y => y.Key == "ClaimsIssuer").First().Value;
                x.AuthorizationEndpoint = Configuration.GetSection("UAA").GetChildren().Where(y => y.Key == "AuthorizationEndpoint").First().Value;
                x.TokenEndpoint = Configuration.GetSection("UAA").GetChildren().Where(y => y.Key == "TokenEndpoint").First().Value;
                x.UserInformationEndpoint = Configuration.GetSection("UAA").GetChildren().Where(y => y.Key == "UserInformationEndpoint").First().Value;

                x.CallbackPath = new PathString("/signin-oidc"); /* provider specific DO NOT MODIFY */

You can't specify if the Callback Path runs on HTTPS instead of HTTP.
This lead to scenario where if your web server runs HTTP behind an SSL Accelerator or a Load Balancer that expose your app as HTTPS the call back page cannot be reached by the external Oauth login page simply because to the OAuth is provided the callback to the HTTP endpoint that doesn't really exist.
If you have NO control on the Load Balancer or the SSL Accelerator (like we DO NOT have within Cloud Foundry) it doesn't work.

Duplicate of https://github.com/aspnet/Security/issues/757


Add setupapi.dart

Fix missing setupapi.dart since https://github.com/timsneath/win32/pull/303
Signed-off-by: Sunbreak<EMAIL_ADDRESS>

I can't believe I missed this! Thank you so much, @Sunbreak !


Add facts

Hello
Could you add a custom fact wildfly_version, like mongodb module which add mongodb_version ?
Best regards,

Sure. That's a great idea.
If you're connected to CLI, ls command will return two important information:
product-name=WildFly Full
product-version=9.0.2.Final
There is also information regarding Java version that might be useful. Let me check how I will achieve this.

Great :-)
We are working on some enterprise level facts on our own, so we can query puppetdb to send the intel to itop cmdb. For wildfly I came up with something like
`find / -name  jboss-cli.sh` -c version | grep | ...

But that's ugly. That'ld be way better if wildfly module could come up with wildfly_version, then I'ld just have to Facter.value(:wildfly_version)
Here's a quick explanation (puppet doc is way too verbose somewhen)
https://www.puppetcookbook.com/posts/deploying-custom-facts-in-modules.html
And here are examples for .rb producing facts
https://docs.puppet.com/facter/3.6/fact_overview.html

Thanks. I've already developed a few custom facts, but I'm more concerned in how to check if Wildfly is running before querying for version, since it requires the server to be up (-c there is for connect).
Additionally, but alternatives presents some challenges:

jboss-cli.sh returns unstructured data and you'd need it in the path.
Management API requires authentication (username/password).

Another approach would be to use Puppet to manage an external structured fact containing all the information.

Just pushed a simple solution to master using external_facts (https://github.com/biemond/biemond-wildfly/blob/master/manifests/external_facts.pp):
[root@centos-66-x64 vagrant]# facter -p wildfly.version
9.0.2
[root@centos-66-x64 vagrant]# facter -p wildfly.java_home
/opt/jdk1.8.0_111/
[root@centos-66-x64 vagrant]# facter -p wildfly
{
  home => "/opt/wildfly",
  java_home => "/opt/jdk1.8.0_111/",
  version => "9.0.2"
}

I could build a custom facter that uses wildfly.home and wildfly.java_home to execute jboss-cli and retrieve runtime information, but not sure if it's necessary. What do you think?

Sorry for the delay
As far as I'm concerned, this is good enought. No need to got for the runtime, that's out of the scope for puppet imho.
Thanks !


Spring boot executable jar application does not see classes with ChagneLogs

When our application is packaged as executable spring boot jar ChangeLog classes inside this jar are not seen. It was working in version 3.0.0-BETA. It looks like changes in: https://github.com/cloudyrock/mongock/pull/76/commits/20fe854375a1141e069e98d8ecec457f26f0a1a6 in method fetchChangeLogs causes the problem
With prior versions this was working well and also when the application is not packaged as spring-boot than ChangeLogs are also seen with no problems.

Hello guys.
When we are back from vacations we'll go into details and see what exactly happened in order to try to bring this change back without issues.
Meanwhile new beta has been released with that change rolled back. Please, have a shoot and let us know if it fixes it.
<dependency>   <groupId>com.github.cloudyrock.mongock</groupId>   <artifactId>mongock-core</artifactId>   <version>3.0.3.BETA</version> </dependency>
Thanks

Yes, this version is working for me. Thanks for this quick fix.

yep, docker fixed too

great. Thanks guys


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-source-version-target/pull/68 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-archive-test-source-version-target.git

Docs Build status updates of commit f1e2740:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

versioningArchiveSourceFolder/TOC.yml
:white_check_mark:Succeeded
View (sql-server-2014 || azuresqldb-current || azuresqldb-mi-current || azure-sqldw-latest || >= aps-pdw-2016 || >= sql-server-2016 || >= sql-server-linux-2017 || sql-server-previousversions || sqlallproducts-allversions)

versioningArchiveSourceFolder/docfx.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Where to get the specific parameters of an object in a  frame?

Thank you for your work,
I am trying to get he specific parameter information of an object in a  frame, like pose, rotation, object_id.

I noticed that the objects in the scene can be edited with the code above, but we don't know what the specific xyz, yaw, and object_id of each object are.
Could you give me some hints? Thanks a lot.

Hi! @RZkiller
Thanks for your reply.
The last dimension of the pose is object_id and dim. The code above means adding 0.5 in the z-direction to the vehicle with an object ID of 1. The positive direction of the z-axis is relative to the world coordinate.

@xBeho1der Thank you for your reply. Refer to issue #105, I know the meaning of each dimension of pose/rotation and how to edit an object that already exists in the scene.
The question is that when I want to add a new car in the scene, I need to set specific pose, rotation information. But I notice that in a frame, the shape of pose/rotation of an object is (375, 1242, 3) and (375, 1242) respectively.

Does this mean if I want to add a new car, I need to provide the pose/rotation of the car with shape of (375, 1242, 3)/(375, 1242)?     P.S.  looks like pixel level parameter?
If not, how can i get or set the specific pose/rotation values of a certain car in the scene?


Advertisement Click Prediction

Issue Title : Advertisement Click Prediction

Info about the related issue (Aim of the project) :
Predict the clicks on the advertisement depending on different attributes and user inputs of the dataset.

[ ] SWOC Participant

[x] JWOC Participant

[x] Contributor

Name: SNEGA S

GitHub ID: snega16

(Mention these details are must)
Closes: #92
Describe the add-ons or changes you've made
Using the dataset, initially I have performed data visualization and exploratory data analysis. Then I applied feature enginnering mapping, Finally I used four algorithms to create model, compared all algorihtms and found best fitted model.
Type of change
What sort of change have you made:

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Describe how it has been tested
Describe how have you verified the changes made
Checklist:

[ ] My code follows the guidelines of this project.
[ ] I have performed a self-review of my own code.
[ ] I have commented my code, particularly wherever it was hard to understand.
[ ] I have made corresponding changes to the documentation.
[ ] My changes generate no new warnings.
[ ] I have added things that prove my fix is effective or that my feature works.
[ ] Any dependent changes have been merged and published in downstream modules.

@snega16 really nice presentation :star_struck:. One small thing you must add on, create a README.md file in the Dataset folder and provide a brief description about the dataset. This will be really good for others to understand the dataset.

@snega16 really nice presentation 🤩. One small thing you must add on, create a README.md file in the Dataset folder and provide a brief description about the dataset. This will be really good for others to understand the dataset.

Thankyou. Changes made!

Perfect project. Your PR is approved and merged! 🎉


Fix single convert

This should fix the convert to single file function. The argument was in an incorrect place
Previous pull request didn't work, sorry for spam!
(Thanks for this program!)

Thanks for the fix, it LGTM 😁


Review & validate all analytics metrics

consider whether we can implement some simple validation plan (e.g. in staging)
minimally, review metrics computation code for correctness
can we add any unit tests for additional confidence?

@ambrosejcarr Worth carving out time for this? I'm apt to close it and revist if/when analytics system undergoes larger changes.

let's close it for now and proactively validate future changes to analytics, as you suggest.


type guard with --strictNullChecks is respected, but then not in a callback scope: TS2345

TypeScript Version:
When using --strictNullChecks with any of these versions:

2.0
2.7.2
2.8.0-dev.20180222   (typescript@next)

Search Terms:

TS2345
type guard
strictNullChecks

Code
in a file tsc-bug.ts:
function asString(): string | undefined {
    return undefined
}

function g(a: string) {
    return
}

function f() {
    let a = asString()   // intellisense correctly shows a is of type string | undefined
    if (a) {    // more explicit guard also fails: if (typeof a === "string")
        let ar = [1,2,3]
        g(a)   // after the type guard "if (a)", intellisense correctly shows a is of type string
        ar.forEach((x) => {
            // tsc 2.7.2 outputs: error TS2345: Argument of type 'string | undefined' is not assignable to parameter of type 'string'.
            // also tsc 2.0 and 2.8.0-dev.20180222
            g(a)   // ERROR: intellisense incorrectly shows a is of type string | undefined
        })
    }
}

Expected behavior:
When using the compiler option: --strictNullChecks
Expect second call of g(a) to be treated the same as the first call.
Both are in the same scope.
Actual behavior:
Second call to g(a) somehow loses track of the type restriction imposed by the guard.
The compiler issues this error:

tsc-bug.ts(18,15): error TS2345: Argument of type 'string | undefined' is not assignable to parameter of type 'string'.

Playground Link:
NOTE: this link doesn't include the --strictNullChecks option, so be sure to set if from the Options button:
http://www.typescriptlang.org/play/#src=function asString()%3A string | undefined {
    return undefined
}

function g(a%3A string) {
    return
}

function f() {
    let a %3D asString()   %2F%2F intellisense correctly shows a is of type string | undefined
    if (a) {    %2F%2F more explicit guard also fails%3A if (typeof a %3D%3D%3D "string")
        let ar %3D [1%2C2%2C3]
        g(a)   %2F%2F after the type guard "if (a)"%2C intellisense correctly shows a is of type string
        ar.forEach((x) %3D> {
            %2F%2F tsc 2.7.2 outputs%3A error TS2345%3A Argument of type 'string | undefined' is not assignable to parameter of type 'string'.
            %2F%2F also tsc 2.0 and 2.8.0-dev.20180222
            g(a)   %2F%2F ERROR%3A intellisense incorrectly shows a is of type string | undefined
        })%0D%0A%20%20%20%20%7D%0D%0A%7D%0D%0A
Related Issues:

Duplicate of  #9998
a is a mutable variable, so we're pessimistic in a callback because it may have been changed by then. Since you don't seem to actually be mutating these variables, consider using const instead of let.

Sorry, I didn't find #9998 in my search.
After reading this discussion, the idea of pessimistic analysis is clear.
So I think that I should assume pessimistic analysis for now, even if there is no path for modifying a variable.
And your suggestion of const allowed me to get past the compiler error.


Add the badge to the README.md

Added the change in commit 9b31dd9adc63f46e6d6613f1fdf46ee4998262f1 and submitted the pull request here https://github.com/ThrashingCode/coder-swap/pull/11


Nightly MAPDL check failing

Before submitting the issue

[X] I have searched among the existing issues
[X] I am using a Python virtual environment
[X] I have a fully updated virtual environment (i.e. pip install --upgrade --upgrade-strategy eager ansys-mapdl-core)

Description of the bug
Traceback is in:
https://github.com/pyansys/pymapdl/actions/runs/3065424924/jobs/4949512730
Steps To Reproduce
NA
Which Operating System are you using?
No response
Which Python version are you using?
No response
PyMAPDL Report
NA
Installed packages
NA

Fixed in #1582 #1557 and #1445


Allow metrics to be exposed publicly

what

Added a host rule and patch matcher to possibly expose metrics publicly.

why

As Atlantis uses the /metrics path to expose certain metrics, we should make it possible to access it without IAP.

references

Closes #120

@kpocius, @Drieske, @mvanholsteijn, @mmourick, @kvanzuijlen, @cblkwell would any of you like to review this change please?

Never got around to doing this myself as we also would like it exposed, so thanks for sorting it out :)


Support date/time compute fields

Fixes: #20
This patch adds support for the following date/time types:

Date:  Contains date info only, represented as ISO 8601 date like '2022-10-02'
Time: Contains time info only, represented as ISO 8601 time like '23:00:00'
DateTime: Full date time info,  represented as UTC ISO 8601 like '2011-12-03T10:15:30'

Implementation note:

The JSTL evaluator maps the types Date, Time, DateTime to java.time.LocalDate, java.time.LocalTime, java.time.Instant respectively.
In Avro, the types Date, Time, DateTime are converted to logical times date, time-millis, timestamp-millis respectively

Next:

Add more unit test coverage
Add utility date functions like now() & dateadd

The approach LGTM
how does this patch play with the Cassandra Sink, the ElasticSearch Sink (or the other Sinks) ?

It works with with ES sink but not with Cassandra Sink (because the logical types that are supported are the CDC custom ones, not standard Avro). I created an issue to support that.
As far as this patch, it makes sense to stick only to the standard avro types.


Unspecified argument used in judgyprophet.fit()

The docstring of judgyprophet.fit() states that the dict array fed into 'trend_events' argument only needs three values per dict:
:param trend_events: A list of dictionaries. Each dict should have the following entries
            - 'index' the start index of the event (i.e. index = i assumes the start of the event
                is at location actuals[i]). The index should be of the same type as the actuals index.
            - 'm0' the estimated gradient increase following the event
            - 'gamma' (Optional) the damping to use for the trend. This is a float between 0 and 1.
                It's not recommended to be below 0.8 and must be 0 > gamma <= 1.
                If gamma is missing from the dict, or gamma = 1, a linear trend is used (i.e. no damping).

But it actually needs 4 to work - the missing one being 'name'. However, the only reason this is used is for logging purposes (lines 1059 and 1085). Perhaps remove this argument from the logging, or add it as a forth key in the dictionary in the docstring?

Note the same is also true for the "level_event" dicts (lines 988 & 1004)

Perhaps remove this argument from the logging, or add it as a forth key in the dictionary in the docstring?

The second of these would actually be better - it is helpful in the logging ('EFL255' etc are names of events):


Lupus import

@aarmey I think this pull request should work to merge what I have been working on (I ran into a few git issues [gitssues?] earlier in the week and had to copy/delete previous files from the confusingly named LupusImport branch.
Here's a quick overview of the 3 files that I'm including:
figureS1: initial visualization of expression value distributions used to understand normalization
figureS2: initial run of pf2, with factor plots [if you want to try running pf2 on the whole dataset this would probably be a good place to do it, I can leave a comment there too]
figureS3: investigation of cell type contribution to cell state by UMAP and with violin plots derived from projections matrix

@pascoesean it looks like it will require some more complicated shuffling between the CPU and GPU to scale to much larger datasets. I plan to implement this, but it will likely be a week or two, so I would proceed with my suggestion above about using all patients and downsampling those with a large number of cells. I'll keep you posted on the Pf2 algorithm changes.

@andrewram4287 it looks like the build is still failing due to an error in Fig. 9. Can you take a look?

@andrewram4287 this is my best attempt at a review request


KAFKA-15597: Allow Connect DropHeaders SMT remove headers on a wildcard/regexp-basis

In many use cases you might not only want to drop a few specific Kafka headers but a set of headers whose names can also dynamically change (e.g. when used with some end-to-end-encryption libraries). To prevent those headers to be further forwarded/processed downstream, I suggest to replace the set-based contains by a (compiled) regexp matching. This PR provides an example implementation for this feature.
Link to Jira: https://issues.apache.org/jira/browse/KAFKA-15597
Unit and integration testing for backwards-compatibility done, additional tests added.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Hi @Schm1tz1, thanks for the PR!
I think we should have a small KIP before accepting this change. Today you could set headers to header.* and it would only drop records with this exact header name and keep records with header-2 for example.

Hi @mimaison ,
sure, will do that. Fair point, I was also thinking whether it makes sense to add a second config for header pattern to allow both options.

Yes that's an option too

Here is a link to the KIP: https://cwiki.apache.org/confluence/x/oYtEE
I will also create a branch for the second option which is already initially implemented.


Auto analysis edge cause allocating all of the memory

There is an edge case that is causing very fast allocation of all of memory trying to analyze one function.  Closing the file does successfully abort the analysis and stop the allocations, but will cause the machine to run out of memory if left alone.
Test case:
mem_exhaust.zip

I was able to reproduce this (or at least something similar) by loading a super simple program compiled statically with glibc on Ubuntu 15.10

Fixed in dev. These cases are caused by unusually large functions (in this case, over 20,000 basic blocks). We now avoid running data flow on these functions. Disassembly and IL viewing are still fully available, but jump table resolution will not occur inside these giant functions. We will increase the function size limits for the full analysis as we improve analysis performance.


Convert tasks to use new incremental API

The tasks provided by Gradle should use InputChanges to query for changes.

It's not a hard "don't push the unpackUnionFileCollectionTo changes", but I feel we should revisit this.

@lacasseio PTAL! I added a separate property for the stable source property, so we don't need the UnionFileCollection dance anymore.

I separated the changes into #8815 (native tasks) and #8816 (tasks extending source tasks).