RouteNotFoundException

I have a simple test to calculate routes between random vertices. Approximately 10% of route calculations throws exception Itinero.Exceptions.RouteNotFoundException while OSM/OSRM routing returns valid route.
For example:
OSM data: slovenia-latest.osm.pbf
https://www.openstreetmap.org/directions?engine=osrm_car&route=46.50853,15.07739;46.24624,14.35322
https://www.openstreetmap.org/directions?engine=osrm_car&route=46.43107,14.07973;45.88519,14.43405
https://www.openstreetmap.org/directions?engine=osrm_car&route=45.57986,15.19478;46.12383,15.57374

Thanks again for test, will check this....
Just to make sure, you mean random 'vertices' not random locations right? And did you also load other profiles? Did you use a contracted version for the car profile?

Yes, I mean random vertices, so the problem is not in resolving locations but in route calculations. I used contract for the built-in car profile as well as a contract for my OSRM like car profile (same as a car, but with speed_profile / ["track"] = 30 commented out).

Perhaps related to #52

Can you share the core you use to test or at least the code you use to build the routerdb? And the lua profile?

I get these three routes using an uncontracted routerdb:

http://geojson.io/#id=gist:anonymous/aa9d53f9cfcf7661308bbd6c3db75cd0&map=10/46.2516/14.6791
http://geojson.io/#id=gist:anonymous/a561d9555389aa1415082ecf5894dfb4&map=12/46.3906/14.1765
http://geojson.io/#id=gist:anonymous/2b793c38a5da6eeb1a80ddb14c9ee3fc&map=12/45.6713/15.1889

So it doesn't seem to be a data-issue. Testing some more now, will keep you informed.

I get these three when using a contracted routerdb:

http://geojson.io/#id=gist:anonymous/a7efba694f92e82a179ba9d6b978b886&map=10/46.3306/14.8313
http://geojson.io/#id=gist:anonymous/ad82fd4c0227abcf99bc58996274a499&map=10/46.1603/14.2754
http://geojson.io/#id=gist:anonymous/420c616aa9ce33c9af6904a3e81c1d6b&map=10/45.8522/15.3795

This code was used:
            Itinero.Logging.Logger.LogAction = (o, level, message, parameters) =>
            {
                Console.WriteLine(string.Format("[{0}] {1} - {2}", o, level, message));
            };

            var routerDb = new RouterDb();

            using (var stream = File.OpenRead(@"path/to/slovenia-latest.osm.pbf"))
            {
                routerDb.LoadOsmData(stream, Itinero.Osm.Vehicles.Vehicle.Car);
            }
            routerDb.AddContracted(Itinero.Osm.Vehicles.Vehicle.Car.Fastest());

            var router = new Router(routerDb);
            var route = router.Calculate(Itinero.Osm.Vehicles.Vehicle.Car.Fastest(),
                new Coordinate(46.50853f, 15.07739f), new Coordinate(46.24624f, 14.35322f));
            route = router.Calculate(Itinero.Osm.Vehicles.Vehicle.Car.Fastest(),
                new Coordinate(46.43107f, 14.07973f), new Coordinate(45.88519f, 14.43405f));
            route = router.Calculate(Itinero.Osm.Vehicles.Vehicle.Car.Fastest(),
                new Coordinate(45.57986f, 15.19478f), new Coordinate(46.12383f, 15.57374f));

Yes Ben I think the case is the same. I have ti finish the test but I think
that the exception happens also with not contracted db even if with
contracted the exception happens much more.
-- Alessandro
Il 06 gen 2017 09:19, "Ben Abelshausen"<EMAIL_ADDRESS>ha
scritto:

Perhaps related to #52 https://github.com/itinero/routing/issues/52
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/itinero/routing/issues/56#issuecomment-270854220, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABtMQR-65qm0Wz3AwqVSlRF7kHciMnt1ks5rPfkMgaJpZM4LcI-w
.

Let me check something... plus, I will try to find shorter routes for easier examination.

I am still not sure but it looks like that problems were caused by my improper vehicle lua. No such errors if using only Itinero.Osm.Vehicles.Vehicle.


Collection page

Collection page should

List vertically images loaded from the backend
Each image should be contained within the viewport (if the image is vertical it shouldn't take more than the height of the window, if it's horizontal it should fit between the sidebar and the right margin of the window)

Closed by #8


Can "Upgrade" only to "WebSocket when running viewer

I have a clean install on the Ubuntu 22. When running viewer with ns-train nerfacto --vis viewer in the browser on localhost:7007 I see only_: Can "Upgrade" only to "WebSocket"._ message

Not sure at first thought, some questions to help get to the bottom of this:

What url are you navigating to? Is it the one provided in the terminal?
Is the error in the terminal or printed directly in the browser, or in the browser console?
Is training running, or is it frozen?

Hm. In the beginning, I enabled port forwarding and got this error on the remote machine. Then I used 'localhost:7007' URL locally and got this error.  The suggested URL 'https://viewer.nerf.studio/versions/22-10-07-0/?websocket_port=7007'  is working fine.

Just to clarify, it is working now? Can I close this issue?

If you want to use a remote machine, the setup should be the following:
Remote Machine (with GPU):

has nerfstudio installed
Where training takes place

Local Machine (for viewing):

has open port
ssh -L 7007:localhost:7007<EMAIL_ADDRESS>Navigate to url specified in the training job on the remote server.

Thanks

Hi @tancik, I'm getting the same problem as @snarb. Training gives me  the following url: https://viewer.nerf.studio/versions/22-10-13-0/?websocket_url=ws://localhost:7007 but I get the following page:

The page is blank and this does not connect to my training. I'm running this from a remote machine and I've done the tunnel earlier using the port 7007, but keeps saying Server Disconnected
Thanks in advance!

I was using Safari and did not work, same URL on google chrome works as expected, don't know why. Solved. Sorry to bother.

I finally solved, by using Google Chrome instead of Safari. Don't know why it does not work on Safari


New package: TensegrityEquilibria v0.1.1

Registering package: TensegrityEquilibria
Repository: https://github.com/matthiashimmelmann/TensegrityEquilibria.jl
Created by: @matthiashimmelmann
Version: v0.1.1
Commit: d69d4c42a7ea47c4e38ba7d60aabeb4cae1a7007
Reviewed by: @matthiashimmelmann
Reference: https://github.com/matthiashimmelmann/TensegrityEquilibria.jl/commit/d69d4c42a7ea47c4e38ba7d60aabeb4cae1a7007#commitcomment-49565579

[noblock] I don't understand, why this doesn't work. Locally, I can import the module. Can someone help me please? @JuliaRegistrator

@matthiashimmelmann the file src/tensegrityEquilibria.jl should be named src/TensegrityEquilibria.jl.  The entry point of the package must match the name of the package, and cases are relevant.
[noblock]

@giordano Thanks a lot for your help! Locally, I met the naming convention, but it appears that automatic lower-casing happened during upload. I'll have to look into my Git upload manager and find out why this occured.

Closing in favour of #34460.  However note that, as explained in the message by the bot above, if you don't change the version number, registering again would simply update the present pull request.


TaxBrain produces incorrect results because it allows invalid reforms

Consider the following reform:
// bad-reform.json contains a logically incorrect attempt to completely
// eliminate the income tax (leaving refundable credits unchanged)
{"policy": {
    "_II_rt1": {"2020": [0.0]},
    "_II_brk1": {"2020": [[9e99, 9e99, 9e99, 9e99, 9e99]]},
    "_CG_rt1": {"2020": [0.0]},
    "_CG_rt2": {"2020": [0.0]},
    "_CG_rt3": {"2020": [0.0]},
    "_CG_rt4": {"2020": [0.0]},
    "_AMT_rt1": {"2020": [0.0]},
    "_AMT_rt2": {"2020": [0.0]},
    "_AMT_CG_rt1": {"2020": [0.0]},
    "_AMT_CG_rt2": {"2020": [0.0]},
    "_AMT_CG_rt2": {"2020": [0.0]},
    "_AMT_CG_rt3": {"2020": [0.0]},
    "_AMT_CG_rt4": {"2020": [0.0]}
}}

When using Tax-Calculator (version at HEAD of master branch), the validation checking detects the logical inconsistency in the reform.
$ tc puf.csv 2020 --reform bad-reform.json
Traceback (most recent call last):
  File "/Users/mrh/anaconda/bin/tc", line 11, in <module>
    sys.exit(cli_tc_main())
  File "/Users/mrh/anaconda/lib/python2.7/site-packages/taxcalc/cli/tc.py", line 126, in cli_tc_main
    exact_calculations=args.exact)
  File "/Users/mrh/anaconda/lib/python2.7/site-packages/taxcalc/taxcalcio.py", line 200, in init
    pol.implement_reform(param_dict['policy'])
  File "/Users/mrh/anaconda/lib/python2.7/site-packages/taxcalc/policy.py", line 192, in implement_reform
    self._validate_parameter_values()
  File "/Users/mrh/anaconda/lib/python2.7/site-packages/taxcalc/policy.py", line 367, in _validate_parameter_values
    pvalue[idx], vvalue[idx]))
ValueError: 2020 _II_brk1 value 9e+99 > max value 40605.4
$

The error message ValueError: 2020 _II_brk1 value 9e+99 > max value 40605.4 gives a strong hint about what the problem is.
But if you hand enter this reform into the TaxBrain GUI input page, you would be given a vague warning about some unspecified parameters having questionable values and given an opportunity to click on the "Show Me the Results!" button a second time to simulate the reform.  And here would be the totally incorrect results you would get:

Notice that the top expanded income decile is simulated to pay over $1.3 trillion in income taxes, even though the user thought s/he was eliminating the income tax by setting the first bracket's rate to zero and making the top of that first bracket be (essentially) infinity.
The reason why we put these tax bracket validations in the current_law_policy.json file becomes apparent when looking at the code that computes tax liability:
    return (rate1 * min(income, brk1) +
            rate2 * min(brk2 - brk1, max(0., income - brk1)) +
            rate3 * min(brk3 - brk2, max(0., income - brk2)) +
            rate4 * min(brk4 - brk3, max(0., income - brk3)) +
            rate5 * min(brk5 - brk4, max(0., income - brk4)) +
            rate6 * min(brk6 - brk5, max(0., income - brk5)) +
            rate7 * min(brk7 - brk6, max(0., income - brk6)) +
            rate8 * max(0., income - brk7))

So, by letting users make this kind of mistake, TaxBrain is producing absurdly incorrect results.
At least this is what the user would think (because TaxBrain users are not being requested to understand the Python source code before using TaxBrain).  The user was clear: the first bracket is infinitely big and has a zero rate.  So, the user is going to think the TaxBrain results are absurd.
It seems like we need to make a fundamental philosophical decision about Tax-Calculator and TaxBrain.  Do we want to remove all validation testing or not?  Essentially, the current version of TaxBrain removes all validation testing (because the warning message is so vague, most users are not going to realize their mistake and go ahead and click the execute button a second time).  This philosophy of minimal or no validation checking (which has a long tradition in software development) is often described in computer programming discourse as the "give them enough rope to hang themselves" approach.
@MattHJensen @feenberg @Amy-Xu @andersonfrailey @hdoupe @talumbau @brittainhard

I advocate for providing a good warning and no error in both tax-calculator and TaxBrain.
I left a few related comments on the merged PR: https://github.com/open-source-economics/Tax-Calculator/pull/1502.
First I said:

I think it is better to show warnings rather than errors.

A common scenario where someone would want to bypass the validations is when they reduce the standard deduction while eliminating itemized deductions. The error from not having imputed itemized deductions to non-itemizers would be small in those situations, and I think the user should be able to decide whether to accept that error.

I then left a longer explanation:

I think the ideal approach would be for the user to see a warning and explanation before being allowed to continue with the reform if they choose. This is in line with our long standing goal of allowing our users, wherever possible, to make key modeling decisions for themselves.
I have come across several situations myself where I have chosen to bypass the warning, but I also think it is our responsibility to communicate the limitation to our users.
As @martinholmer points out, we don't currently attain the ideal because we don't offer an adequate explanation. I've received this feedback before from Kevin Hassett, but I failed to do anything about it at the time.
One option would be to stick with the warning system (albeit now in Tax-Calculator rather than TaxBrain) and simply make the explanation more informative.
Another option would be to move the warning to the documentation and code comments. My fear is that those would be very easy to overlook.
I think it is too limiting to strictly enforce the rules.

@martinholmer, is there something that I am missing that means we must have no validation or strict validation? What about improving the quality of the warning?
--
Relatedly, the user interface may be nicer if the warnings are displayed at the top of the output page rather than on the input page with a required resubmission.

@MattHJensen said in TaxBrain issue #620:

I think it is too limiting to strictly enforce the rules.

So, you think the situation described in #620 is OK?  What would the "warning" at the top of the results page say?  Something like "The results from this TaxBrain run are completely non-sensical, but we're showing them to you anyway"?  My point in #620 is that there is a fundamental difference between the current validations: some are logical requirements (like the one in #620) and others (related to to deductions) are data weaknesses that we haven't fixed since you asked for that data fix a year ago.

Is there something that I am missing that means we must have no validation or strict validation? What about improving the quality of the warning?

In my view, yes we should have "strict validation" (resulting in a fatal error and no simulation results) when the validation involves a logical requirement (like in #620).  If you want the deduction related data weaknesses to not be validated, I have no problem with that (as I already mentioned in Tax-Calculator 1502.  But why not solve these data weakness issues by adding itemized-deduction expenses for non-itemizers?  This is the most direct way to deal with this second class of validations.
You seem to favor "warnings", but I don't see how that works.  Can you explain exactly how Tax-Calculator would communicate a "warning" to TaxBrain?

In my view, yes we should have "strict validation" (resulting in a fatal error and no simulation results) when the validation involves a logical requirement (like in #620).

That makes sense to me, too, as does bifurcating our approach for handling logical requirements and data weaknesses.

You seem to favor "warnings" [for data weaknesses], but I don't see how that works. Can you explain exactly how Tax-Calculator would communicate a "warning" to TaxBrain?

The Python logging module was on my mind. I imagine we'd add a special log level for this purpose. There was a brief discussion of the benefits of the logging module in https://github.com/open-source-economics/Tax-Calculator/issues/160#issuecomment-235465717.
That said, I see your point about how solving the data weaknesses themselves would eliminate our (current) need for warnings. I asked @GoFroggyRun  to focus on the webapp earlier this summer, which has been very productive, but it disrupted his progress on the imputation of deductions for non itemizers (https://github.com/open-source-economics/taxdata/issues/32):
@GoFroggyRun, could you leave an update over at https://github.com/open-source-economics/taxdata/issues/32 on the state of the project and what you think the next steps should be when you pick it up again?
--
Given that a) we haven't yet built the capacity to provide informative warnings, and b) our current need for those warnings might go away, one approach might look something like this:

Remove validations for "data weaknesses," and move their discussion to documentation that could be linked to from the top of ospc.org/taxbrain.  (This would solve the initial problem I pointed out, of strict validations for data weaknesses being too limiting.)
Implement strict validation for logical errors on TaxBrain in a manner that relies on the new Tax-Calculator checking in https://github.com/open-source-economics/Tax-Calculator/pull/1502. (probably the initial purpose for this issue #630.)
Revisit the decision about providing warnings via the logging module or some other means after we know more about https://github.com/open-source-economics/taxdata/issues/32 or when there is some new need for it in the future.

@MattHJensen said about warnings and errors in #630:

Given that a) we haven't yet built the capacity to provide informative warnings, and b) our current need for those warnings might go away, one approach might look something like this:

Remove validations for "data weaknesses," and move their discussion to documentation that could be linked to from the top of ospc.org/taxbrain. (This would solve the initial problem I pointed out, of strict validations for data weaknesses being too limiting.)

Implement strict validation for logical errors on TaxBrain in a manner that relies on the new Tax-Calculator checking in open-source-economics/Tax-Calculator#1502. (probably the initial purpose for this issue #630.)

Revisit the decision about providing warnings via the logging module or some other means after we know more about open-source-economics/taxdata#32 or when there is some new need for it in the future.

I am in general agreement with this kind of approach to improving our handling of warnings and errors.  But I'd like to suggest a slight variation on this basic approach.
Assuming we agree to maintain a distinction between warnings (that do not stop Tax-Calculator execution) and errors (that do stop Tax-Calculator execution), then I think we should add warnings for parameter values being out of range for all policy parameters.  Among the benefits of this approach is that we can continue to include the "data weakness" warnings which are very useful to point out to users.
I can begin preparing a pull request as soon as we are in agreement on this basic approach:
valid range warnings will be collected for all parameters in a reform and Tax-Calculator execution will continue, while valid range errors will be collected for all parameters in a reform and Tax-Caculator execution will stop before trying to undertake tax calculations.
Does this (slightly modified) approach make sense?

That sounds great. Thanks @martinholmer.

@martinholmer said

I can begin preparing a pull request as soon as we are in agreement on this basic approach:
valid range warnings will be collected for all parameters in a reform and Tax-Calculator execution will continue, while valid range errors will be collected for all parameters in a reform and Tax-Caculator execution will stop before trying to undertake tax calculations.

@MattHJensen said

Revisit the decision about providing warnings via the logging module or some other means after we know more about open-source-economics/taxdata#32 or when there is some new need for it in the future.

What if we had some function in policy.py that did something along the lines of the pseudocode below?
def validation_msg(reform):
    msg = {'error': {}, 'warning': {}}
    for param in reform:
         if param raises error:
             msg['error'][param] = some error message
        if param raises warning:
             msg['warning'][param] = some warning message
    return msg

This function could be called in TaxBrain and an action could be taken depending on the contents of msg.

@hdoupe said in #630:

What if we had some function in policy.py that did something along the lines of the pseudocode below?
def validation_msg(reform):
    msg = {'error': {}, 'warning': {}}
    for param in reform:
         if param raises error:
             msg['error'][param] = some error message
        if param raises warning:
             msg['warning'][param] = some warning message
    return msg

This function could be called in TaxBrain and an action could be taken depending on the contents of msg.

Thanks for the creative thinking.  I'll think about this kind of approach.

Issue #630 has been resolved in TaxBrain 1.0.3 with the implementation of the GUI input processing strategy outlined in issue #619.


HINT outputs not Coherent

What happened + What you expected to happen
When running HINT, I expect the sum of lower level forecasts to be coherent with higher level forecasts. That is not happening.
Versions / Dependencies
1.7.0
Reproduction script
Google Colab Demonstration of error
Issue Severity
High: It blocks me from completing my task.

Thanks for reporting - a solution to the issue has been proposed in #964.
If the solution is merged, this issue will be closed.


FIX: typo

 Simple Typo
Reference an existing issue

N/A

@gmarkall can we transition this to ready to merge.

@esc Done!


list_nodes on GCE Projects Only Returns 500 Results

Summary
When running list_nodes against a GCE environment that has greater than 500 instances, only the top 500 results will be returned.
Detailed Information
Using libcloud 2.6.0, running list_nodes using the GCE Provider will only return the top 500 results. This is similar to issue #1203 where the list_nodes function is running self.connection.request rather than self.connection.request_aggregated_items.
I believe changing lines 19-23 of the list_nodes function to something like this will fix the issue:
if zone is None:
        response = self.connection.request_aggregated_items('instances')
    else:
        request = '/zones/%s/instances' % (zone.name)
        response = self.connection.request(request, method='GET').object

@erjohnso Maybe you have an input on this issue?
request_aggregated_items approach seems reasonable to me, I don't have any account with that many instances to test it, but I guess I could also decrease page size (maxResults) to test that change.
On a related note, I assume we also need to correctly handle pagination when user explicitly specifies a zone to use?


Fixed Style hash

Fixes a performance bug in the Style class.
Essentially the hash calculation was inconsistent. Things that were equal would sometimes have different hashes. I noticed this when adding lru_cache to Style.__add__. What should have been an easy win caused dramatically reduced performance, because it broken the mechanics of storing Styles in a dict.
The hashing is now in once place. It is also lazy, so the hash is stored the first time it is used.

Codecov Report

Merging #2346 (da790be) into master (14d47c9) will decrease coverage by 3.20%.
The diff coverage is 89.39%.

:exclamation: Current head da790be differs from pull request most recent head 516a00e. Consider uploading reports for the commit 516a00e to get more accurate results

@@            Coverage Diff             @@
##           master    #2346      +/-   ##
==========================================
- Coverage   98.88%   95.68%   -3.21%
==========================================
  Files          73       73
  Lines        7629     7712      +83
==========================================
- Hits         7544     7379     -165
- Misses         85      333     +248

Flag
Coverage Δ

unittests
95.68% <89.39%> (-3.21%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

rich/_export_format.py
100.00% <ø> (ø)

rich/_win32_console.py
3.01% <0.00%> (-88.48%)
:arrow_down:

rich/cells.py
100.00% <ø> (ø)

rich/live.py
97.90% <40.00%> (-2.10%)
:arrow_down:

rich/style.py
99.75% <95.00%> (-0.25%)
:arrow_down:

rich/console.py
96.69% <96.03%> (-2.10%)
:arrow_down:

rich/_inspect.py
100.00% <100.00%> (ø)

rich/_wrap.py
100.00% <100.00%> (ø)

rich/box.py
100.00% <100.00%> (ø)

rich/control.py
100.00% <100.00%> (ø)

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 761cc8d...516a00e. Read the comment docs.


Test required columns

Enhance the ability to test required columns
Every column that is specified in the scan YAML should exist.  If not the scan should fail with a message but still compute all the other measurments/tests
Eg
columns:
  id:
    type: VARCHAR(255)
  size:
  amount:

Will test if id is present and has type VARCHAR(255)
And it will test that columns size and amount are present no matter which data type.
This form of required column testing works with and without Soda Cloud configured.

related #290


Jaeger binaries were compiled with an older Go version which has security vulnerabilities

Describe the bug
Our company's internal security scan tool has found security vulnerabilities in the latest Jaeger binaries.  May I request Jaeger team to uplift the Go compiler version on your build machines to the latest when building the next Jaeger release?
Here is the vulnerabilities detected:
https://nvd.nist.gov/vuln/detail/CVE-2021-41772
To Reproduce
Steps to reproduce the behavior:

Use internal scanning tool to scan Go binaries

Expected behavior
No security vulnerabilities.
Screenshots
Version (please complete the following information):

OS: [Linux]
Jaeger version: [1.30.0]
Deployment: [Kubernetes]

What troubleshooting steps did you try?
Additional context

Jaeger 1.31. is going out soon https://github.com/jaegertracing/jaeger/blob/main/RELEASE.md#release-managers. We will make sure it is compiled against the newest golang version.

v1.31.0 release in progress using Go 1.17.6

$ docker run --rm --name jaeger jaegertracing/all-in-one-debug:1.31

$ docker exec -it e0561c06f0e9 sh
/go # go version
go version go1.17.6 linux/amd64


fix: MD005/list-indent

Replace mixed tab indenting
Trim trailing spaces
Remove blockquote spacing
Remove interior list indenting
Spacing around headers and code fences

I did a commit to make the content validation pass.


TypeError: function takes 1 positional arguments but 2 were given

seem to be getting this error when trying to 'set_ambient_pressure'
Traceback to line in code
self._buffer[4] = self._crc8(self._crc_buffer)
any feedback would be appreciated.

Thanks for raising this issue. On a quick look at the code, I'm not sure why this is occurring. Can you provide more detail so that I could reproduce the error?

Can I also ask if you might have edited the module code at all?
For example, I think if you removed the line
@staticmethod
from the function definition for _crc8() you would likely get this error.

here is how we are running:
import xbee
import time
from machine import I2C
from micropython import const
version = "v101"
repo = "https://github.com/peter-l5/MicroPython_SCD4X"
SCD4X_DEFAULT_ADDR = 0x62
_SCD4X_GETALTITUDE = const(0x2322)
_SCD4X_SETALTITUDE = const(0x2427)
_SCD4X_PERSISTSETTINGS = const(0x3615)
Instantiate an I2C peripheral.
i2c_bus = I2C(1, freq=100000)
class SCD4X:
def __init__(self, i2c_bus: I2C, address: int = SCD4X_DEFAULT_ADDR) -> None:
    self.address = address
    self.i2c_device = i2c_bus
    self._buffer = bytearray(18)
    self._cmd = bytearray(2)
    self._crc_buffer = bytearray(2)
    # cached readings
    self._temperature = None
    self._relative_humidity = None
    self._co2 = None
    self.set_altitude(self, 375)

@property
def get_altitude(self) -> int:
    self._send_command(_SCD4X_GETALTITUDE, cmd_delay=0.001)
    self._read_reply(self._buffer, 3)
    print("altitude is", self._buffer[0], self._buffer[1])
    return (self._buffer[0] << 8) | self._buffer[1]

@altitude_setter
def set_altitude(self, height: int) -> None:
    if height > 65535:
        raise AttributeError("Height must be less than or equal to 65535 meters")
    self._set_command_value(_SCD4X_SETALTITUDE, height)

def _check_buffer_crc(self, buf: bytearray) -> bool:
    for i in range(0, len(buf), 3):
        self._crc_buffer[0] = buf[i]
        self._crc_buffer[1] = buf[i + 1]
        if self._crc8(self._crc_buffer) != buf[i + 2]:
            raise RuntimeError("CRC check failed while reading data")
    return True

def _send_command(self, cmd: int, cmd_delay: float = 0) -> None:
    self._cmd[0] = (cmd >> 8) & 0xFF
    self._cmd[1] = cmd & 0xFF
    try:
        self.i2c_device.writeto(self.address, self._cmd)
    except OSError as err:
        raise RuntimeError("Could not communicate via I2C, some commands/settings unavailable while in working mode") from err
    time.sleep(cmd_delay)

def _read_reply(self, buff, num):
    self.i2c_device.readfrom_into(self.address, buff)
    self._check_buffer_crc(self._buffer[0:num])
    print(buff)

def _set_command_value(self, cmd, value, cmd_delay=0):
    self._buffer[0] = (cmd >> 8) & 0xFF
    self._buffer[1] = cmd & 0xFF
    self._crc_buffer[0] = self._buffer[2] = (value >> 8) & 0xFF
    self._crc_buffer[1] = self._buffer[3] = value & 0xFF
    self._buffer[4] = self._crc8(self._crc_buffer)
    self.i2c_device.i2c.write(self.address, self._buffer)
    time.sleep(cmd_delay)

@staticmethod
def _crc8(buffer: bytearray) -> int:
    crc = 0xFF
    for byte in buffer:
        crc ^= byte
        for _ in range(8):
            if crc & 0x80:
                crc = (crc << 1) ^ 0x31
            else:
                crc = crc << 1
    return crc & 0xFF  # return the bottom 8 bits

SCD4X(i2c_bus, SCD4X_DEFAULT_ADDR)

Thanks for the code. The way it has come through it is a little bit difficult to see if the class is being defined correctly by looking at this. However I notice that you are not following the usage example given in the code. Have you tried doing that? To do so you would need to upload the scd4x.py file to your xbee.

I'm going to close this issue now, but if you still experience the problem having followed the usage example, please raise again.

I am having a problem with this section of code:
def _set_command_value(self, cmd, value, cmd_delay=0):
    self._buffer[0] = (cmd >> 8) & 0xFF
    self._buffer[1] = cmd & 0xFF
    self._crc_buffer[0] = self._buffer[2] = (value >> 8) & 0xFF
    self._crc_buffer[1] = self._buffer[3] = value & 0xFF
    self._buffer[4] = self._crc8(self._crc_buffer)
    self.i2c_device.i2c.write(self.address, self._buffer) # error in this line 'AttributeError: 'I2C' object has no attribute 'i2c'

when I remove the second i2c tag in this line I get  - "TypeError: function takes 2 positional arguments but 3 were given" - When commenting out this line, rest of code runs fine.
time.sleep(cmd_delay)
Any Ideas of what has gone wrong?

Hi, thanks for raising this. There are errors in the line referred to.
Replacing the problematic line with the following may solve the problem, but haven't tested yet.
If @bocephasj you can try this, let me know if it helps!
    self.i2c_device.writeto(self.address, self._buffer[:5])

It ALL seems to be working now!
Thank you for your help in getting all of this working!


--off timeout: monitor turns back on after 4 seconds

Hi,
I try to lock with betterlockscreen -l --off 1 - regardless of the timeout I choose, the monitor turns back on after 3-4 seconds.
I first searched around and found some hints that gnome-screensaver or gnome-power-manager happen to disturb the xset dmps feature. But none of those are running on my PC.

I found out that there was xss-lock running in the background, and it listened to the dpms off event betterlockscreen -l --off 1 triggered.
So xss-lock turned the screen back on after betterlockscreen turned it off.
After deactivating xss-lock, the --off flag is working perfectly!
I am closing this issue for now.


Revert "[CI] Use JCenter"

Reverts elastic/apm-agent-java#1575
Into the sunset -> https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/
JCenter end of life in May 1st

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Build Cause: Pull request #1651 opened

Start Time: 2021-02-04T21:40:21.206+0000

Duration: 44 min 13 sec

Commit: a91fa2cc0ce21e00f9eb80baa5269b009003a92a

Test stats :test_tube:

Test
Results

Failed
0

Passed
1697

Skipped
12

Total
1709

:green_heart: Flaky test report
Tests succeeded.

Expand to view the summary

Test stats :test_tube:

Test
Results

Failed
0

Passed
1697

Skipped
12

Total
1709


Feature/show the book data of an individual user

#2454
I have made a page to show all the details of users, the books they read, wishlisted and borrowed.
I have performed a self-review of my own code.

@amisha296 please check the conflicts, also there are some changes with the composer.lock file please check that

@amisha296 please check the conflicts, also there are some changes with the composer.lock file please check that

Resolved the merge conflict, I am not getting any idea of composer.lock, I didn't make the changes in there!

@amisha296 Can you check the requested changes

@amisha296 Can you check the requested changes

@gautam071 where to make the changes?

@amisha296 Can you check the requested changes

@gautam071 What changes?


chore(reporting-version): added version reporting to events

Closes #19036
Problem
App Metrics isn't reporting the current version reporting of the app
Solution
Added the current version as a tag in app-metrics

wrong version
use GIT_SHA instead

src/shared/components/VersionInfo.tsx uses the GIT_SHA

@drdelambre & @ebb-tide 🤦


OJ-2720: test kid in JWT header

What changed
Added SSM helper file to use the issuer and keyId to assert on the /kid value
Added the /kid assertion for the JWT header to the integration test
Why did it change
/kid has been added to JWT header
Issue tracking

OJ-2720

Checklists
Environment variables or secrets

[x] No environment variables or secrets were added or changed

Other considerations

[ ] Update README with any new instructions or tasks

changes were added on this PR https://github.com/govuk-one-login/ipv-cri-address-api/pull/1041


glTF files don't import properly if Use FBX is enabled in Project Settings

Godot version
4.0 alpha 4
System information
Linux
Issue description
By default, the option Project Settings > filesystem/import/fbx/use_fbx is enabled. Add a .gltf or .glb file to the project. The editor will hang until it loses focus and is refocused, then the file will be imported ... however after importing the files can't be opened and the editor says it is corrupt.
Disabling the Use FBX option solves all that.
Steps to reproduce
Simply add a glTF file and attempt to open it. Then disable the Use FBX option and reimport it to see that it works now.
Minimal reproduction project
Will provide if necessary. A glTF is all that's needed.

Is the Use FBX project setting still needed in 4.0? We should probably remove it unless there's a good reason to keep it.
cc @RevoluPowered

Should be removed in master. https://github.com/godotengine/godot/pull/59691

That's pretty weird, I don't know why the FBX importer would impact glTF imports. But indeed, it's removed with #59691 so this is likely fixed.


fix(testing-mongoose): Fix issue with Jest and add additional descrip…

…tion to configure jest

Informations

Type
Breaking change

Fix
No

:tada: This PR is included in version 6.2.1 :tada:
The release is available on:

v6.2.1
GitHub release

Your semantic-release bot :package::rocket:


Replaced the deprecated package with kubevirt one in vendor directory

Replaced the deprecated package k8s.io/utils/pointer with kubevirt package kubevirt.io/kubevirt/pkg/pointer in the vendor directory.

What this PR does
Before this PR:

In the vendor we used k8s.io/utils/pointer package which is deprecated.

After this PR:

Now, it is replaced with kubevirt package kubevirt.io/kubevirt/pkg/pointer

Ref #12949
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer

Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note

None

Then, shall I close this PR?

/close


Add support for /sys/generate-root endpoint

It would be nice to have support for /sys/generate-root endpoint operations.

Thanks for the feature proposal. It makes sense to revisit our Vault initialization arrangement to improve the operational experience. Right now, we support basic operations that are tied to authentication and secret backend interaction.
Right now, VaultOperations allows you to interact with arbitrary Vault paths using read(…) and write(…) methods.
I'm setting this ticket to later. It requires further design and we want to learn from the upcoming release how Spring Vault is actually used.

We decided to drop the edge-case. Use either write methods or RestTemplate within a callback.


Update storage-service-encryption.md

Just making sure others are aware of the risks of using ADE with Linux.

@marcusmills : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@marcusmills - Thanks for your feedback! I recommend that you provide feedback on the Azure disk encryption docs directly. The disk encryption team is better qualified to assess your comment.
#please-close


Add AnnData to download section

The Downloadable files page must be updated to reflect the new download structure and options. Right now, we have the following sections:

Download folder structure for project downloads
Download folder structure for individual sample downloads
Gene expression data (this section describes the three files and mentions that they are stored in a SingleCellExperiment object)
QC report
Metadata
Multiplexed Sample libraries
Spatial transcriptomics libraries

I'm proposing that we have the following sections:

SingleCellExperiment downloads with the following subheaders:

Download folder structure for project downloads
Download folder structure for individual sample downloads

AnnData downloads with the following subheaders:

Download folder structure for project downloads
Download folder structure for individual sample downloads

Gene expression data

Keep the description about the three files and the contents (e.g., what type of data is stored in unfiltered vs. filtered vs. processed files)
Modify the language to note that data is available as either SingleCellExperiment or AnnData objects.

QC report - unchanged
Metadata - unchanged
Multiplexed Sample libraries - unchanged except to clearly state that multiplexed data is only available as SingleCellExperiment
Spatial transcriptomics libraries - unchanged

This will also involve creating updated images of the download structure for the AnnData files.
If anyone has any thoughts or other ideas regarding the organization, feel free to comment by EOD 9/26.
Tagging @jaclyn-taroni @dvenprasad and @jashapiro if you have any thoughts.

Looks good. I only want to add that the AnnData folder structure might require more illustrations than the SingleCellExperiment section because CITE-seq is handled differently.

LGTM!

Closed by #153


Add shortcut for opening current branch in Jira

@tresni I'd like to add a br shortcut/command to the jira plugin that will allow you to open the Jira ticket named after the git branch of the current directory. This works well for projects that name branches after ticket numbers and saves the user from having to type out the whole ticket reference.
I doubt it would clash with any existing workflows in use because it is such a short command and it doesn't fit the regex for Jira tickets.
Let me know what you think - I was already using an alias setup to achieve this but thought it might be useful to others.

lgtm


ValueError: invalid literal for int() with base 10: ''

MST/simulation/train_code# python3 train.py --template mst_s --outf ./exp/mst_s/ --method mst_s
training sences: 502
Traceback (most recent call last):
  File "train.py", line 25, in <module>
    train_set = LoadTraining(opt.data_path)
  File "/share/home/brcao/Repos/MST/simulation/train_code/utils.py", line 39, in LoadTraining
    scene_num = int(scene_list[i].split('.')[0][5:])
ValueError: invalid literal for int() with base 10: ''

MST/simulation/train_code/utils.py

 31 def LoadTraining(path):
 32     imgs = []
 33     scene_list = os.listdir(path)
 34     scene_list.sort()
 35     print('training sences:', len(scene_list))
 36     for i in range(len(scene_list)):
 37     # for i in range(5):
 38         scene_path = path + scene_list[i]
 39         print('\n utils.py - scene_path: ', scene_path)

 utils.py - scene_path:  ../../datasets//cave_1024_28/.DS_Store
Traceback (most recent call last):
  File "train.py", line 25, in <module>
    train_set = LoadTraining(opt.data_path)
  File "/share/home/brcao/Repos/MST/simulation/train_code/utils.py", line 40, in LoadTraining
    scene_num = int(scene_list[i].split('.')[0][5:])
ValueError: invalid literal for int() with base 10: ''

Solved by removing the .DS_Store file in the unzipped folder from Mac.


Testing version doesn't sync with archive after migration

After dh-shell-completions 0.0.3 migrated to testing for a while (migrated on 22 Sep, problem found on 18 Oct), manpages.debian.org still has its testing version at 0.0.2. Now that 0.0.4 was uploaded and manpages.d.o version are now in sync (testing 0.0.3, unstable 0.0.4), I suspect that only uploads trigger updates, not migrations.

Hey, thanks for your report.
You’re right that something seems off here, but your suspicion is not correct: debiman does not know about uploads or migrations, it always goes through the list of packages currently in the Debian archive.
However, I think there is a bug in cache invalidation that I have now tracked down based on this timeline:
This is what the Debian package tracker lists:

[2024-09-09] Accepted dh-shell-completions 0.0.2 (source) into unstable (Blair Noctis)
[2024-09-16] dh-shell-completions 0.0.2 MIGRATED to testing (Debian testing watch)
[2024-09-16] Accepted dh-shell-completions 0.0.3 (source) into unstable (Blair Noctis)
[2024-09-22] dh-shell-completions 0.0.3 MIGRATED to testing (Debian testing watch)
[2024-10-19] Accepted dh-shell-completions 0.0.4 (source) into unstable (Blair Noctis)

This is what the debiman logfiles say, annotated for clarity with the resulting state on disk:
TZ=Europe/Zurich journalctl --root=2024-09-19 --since 2024-09-15 -u debiman --grep dh_shell_completions | cat
# rendering both versions because 0.0.2 migrated to testing
Sep 16 05:03:05 ex622 run-debiman.bash[1701967]: 2024/09/16 05:03:05 render.go:296: /srv/man/www/unstable/dh-shell-completions/dh_shell_completions.1.en.html.gz invalidated by /srv/man/www/testing/dh-shell-completions/dh_shell_completions.1.en.gz
Sep 16 05:03:05 ex622 run-debiman.bash[1701967]: 2024/09/16 05:03:05 rendermanpage.go:322: rendering "/srv/man/www/unstable/dh-shell-completions/dh_shell_completions.1.en.html.gz"
Sep 16 05:03:05 ex622 run-debiman.bash[1701967]: 2024/09/16 05:03:05 rendermanpage.go:322: rendering "/srv/man/www/testing/dh-shell-completions/dh_shell_completions.1.en.html.gz"
# -rw-r--r-- 1 root root 2,0K 2024-09-09 00:38 testing/dh_shell_completions.1.en.gz
# -rw-r--r-- 1 root root 4,8K 2024-09-16 05:03 testing/dh_shell_completions.1.en.html.gz
# -rw-r--r-- 1 root root 4,8K 2024-09-16 05:03 unstable/dh_shell_completions.1.en.html.gz

# rendering both versions because 0.0.3 entered unstable
Sep 17 05:03:25 ex622 run-debiman.bash[1813534]: 2024/09/17 05:03:25 render.go:296: /srv/man/www/testing/dh-shell-completions/dh_shell_completions.1.en.html.gz invalidated by /srv/man/www/unstable/dh-shell-completions/dh_shell_completions.1.en.gz
Sep 17 05:03:25 ex622 run-debiman.bash[1813534]: 2024/09/17 05:03:25 rendermanpage.go:322: rendering "/srv/man/www/testing/dh-shell-completions/dh_shell_completions.1.en.html.gz"
Sep 17 05:03:25 ex622 run-debiman.bash[1813534]: 2024/09/17 05:03:25 rendermanpage.go:322: rendering "/srv/man/www/unstable/dh-shell-completions/dh_shell_completions.1.en.html.gz"
# -rw-r--r-- 1 root root 2,0K 2024-09-16 21:43 unstable/dh_shell_completions.1.en.gz
# -rw-r--r-- 1 root root 5,5K 2024-09-17 05:03 unstable/dh_shell_completions.1.en.html.gz
# -rw-r--r-- 1 root root 5,5K 2024-09-17 05:03 testing/dh_shell_completions.1.en.html.gz

# NOTE: The log for 2024-09-22 does not contain any mention of dh_shell_completions!
# most likely cause:
# 1. debiman extracts the manpage to testing/dh_shell_completions.1.en.gz with modtime 2024-09-16 21:43
# 2. because the mod time of the raw manpage (2024-09-16 21:43) is older than the HTML version (2024-09-17 05:03), debiman assumes the HTML version is up to date and does not need to be re-generated.

# rendering both versions because 0.0.4 entered unstable
Oct 19 23:03:32 ex622 run-debiman.bash[1822969]: 2024/10/19 23:03:32 render.go:296: /srv/man/www/testing/dh-shell-completions/dh_shell_completions.1.en.html.gz invalidated by /srv/man/www/unstable/dh-shell-completions/dh_shell_completions.1.en.gz
Oct 19 23:03:32 ex622 run-debiman.bash[1822969]: 2024/10/19 23:03:32 rendermanpage.go:322: rendering "/srv/man/www/testing/dh-shell-completions/dh_shell_completions.1.en.html.gz"
Oct 19 23:03:32 ex622 run-debiman.bash[1822969]: 2024/10/19 23:03:32 rendermanpage.go:322: rendering "/srv/man/www/unstable/dh-shell-completions/dh_shell_completions.1.en.html.gz"

This is the state on disk:
% ls -hltr /srv/man/www/unstable/dh-shell-completions/ && head /srv/man/www/unstable/dh-shell-completions/VERSION
total 20K
-rw-r--r-- 1 root root 2,0K 2024-10-19 16:38 dh_shell_completions.1.en.gz
-rw-r--r-- 1 root root    5 2024-10-19 23:02 VERSION
-rw-r--r-- 1 root root 3,5K 2024-10-19 23:03 index.html.gz
-rw-r--r-- 1 root root 5,5K 2024-10-19 23:03 dh_shell_completions.1.en.html.gz
0.0.4#

% ls -hltr /srv/man/www/testing/dh-shell-completions/ && head /srv/man/www/testing/dh-shell-completions/VERSION
total 20K
-rw-r--r-- 1 root root 2,0K 2024-09-16 21:43 dh_shell_completions.1.en.gz
-rw-r--r-- 1 root root    5 2024-09-22 05:00 VERSION
-rw-r--r-- 1 root root 3,5K 2024-09-22 05:03 index.html.gz
-rw-r--r-- 1 root root 4,8K 2024-10-19 23:03 dh_shell_completions.1.en.html.gz
0.0.3#

So the problem consists of multiple parts:

We override the modtime of the raw manpage when extracting to what’s stored in the archive (i.e. the modtime of the uploader):
https://github.com/Debian/debiman/blob/4afba3a1fef8fc4215d59c13926082ac1001a987/cmd/debiman/download.go#L409
Invalidating other versions of a manpage updates the HTML modtime, but re-uses the content (as an optimization).
This breaks the assumption we make here: If the HTML version is more recent than the raw manpage, it must also contain the contents of that raw manpage: https://github.com/Debian/debiman/blob/4afba3a1fef8fc4215d59c13926082ac1001a987/cmd/debiman/render.go#L250

So, what can we do to fix the issue?

If we just delete the Chtimes call, the modtime would match the extraction time, which will fix the issue, but break the “Source last updated” line in user-facing HTML versions.
Another way to fix the issue would be to stop relying on the mtime and instead inspect the HTML file to figure out which version is contained in the HTML. However, during my investigation I realized that we incorrectly store a reference to the version of the current package, even when incorrectly re-using older content: the footer says “dh_shell_completions.1.en.gz (from dh-shell-completions 0.0.3)”, even though the content is from 0.0.2. So we would first need to fix that.
We could disable the content re-use optimization entirely. I haven’t checked how much slower that would make a typical run.

I’m not sure yet which path I like most. Maybe option 2 deserves a shot, and if it turns out to be too hard for some reason, we can resort to option 3.
I can kick off a run with a forced full re-rendering to get the current manpage archive fixed (will take a few days to complete and propagate, though).

I can kick off a run with a forced full re-rendering to get the current manpage archive fixed (will take a few days to complete and propagate, though).

Looks like this was a bit quicker than expected: the corrected version now seems to be live.

Thanks for the detailed analysis. Some rough thoughts:

"Encode" package version info in HTML page creation time, and compare it with man page "last updated" time, leaving modification time free to change and represent modification of itself.
Link unstable/foo to foo/$ver where $ver is current version in unstable, so file creation/modification times are decoupled from package versions.
Split sections whose changes do not depend on actual content, e.g. "other versions", footer timestamps, etc. into partials, and <iframe> them into content pages.

Note there are two bug reports in Debian also on the topic of manpages.debian.org not getting updated:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=986030
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=994761

As a package example, git-buildpackage 0.9.36 had been in Debian unstable since Dec 22nd, but it did not update until today Dec 27th.


update interval

Default update interval runs every 5 seconds.  this should run way less frequently.

Agreed. I'll fix it in 0.2.2.


[ABW-2557] Clean up strings

Jira ticket: ABW-2557
Requires Clean up strings #227 and the wallet PR it spawns to be merged first.
Description

Removes unused strings
Removes strings that have duplicates
Only use assetDetails_behaviors_x for all behaviors
Removes depositGuarantees.json
Removes importProfile.json
Adds customizeNetworkFees.json (replacing transactionReview_customizeNetworkFeeSheet_x)
Moves transaction_status to transactionStatus

How to test
This should not change anything, so please check that the moved strings still work. The removed strings were not used to begin with, so there is nothing to check there - the project wouldn't build if they were in use.
PR submission checklist

[ ] I have tested account to account transfer flow and have confirmed that it works

Closed in favour of New Crowdin updates #876, which contains the changes made here.


Update User Guide

Codecov Report

Merging #257 (1c5cbf2) into master (f9833f0) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #257   +/-   ##
=========================================
  Coverage     72.06%   72.06%
  Complexity      766      766
=========================================
  Files           116      116
  Lines          2420     2420
  Branches        302      302
=========================================
  Hits           1744     1744
  Misses          530      530
  Partials        146      146

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9833f0...fa85204. Read the comment docs.


/PageMode /FullScreen not honored by latest released version

This issue is related to #8657 (I wonder whether it might be a regression).
Here you have an uncompressed PDF document, which contains the following object:
19 0 obj
<</Type/Catalog/Pages 11 0 R /Metadata 12 0 R /PageLabels << /Nums [ 0 << /S /D /St 0 >> ] >> /PageMode /FullScreen /Version /1.7>>
endobj

But pdf.js doesn’t display the document at fullscreen.
I’m on Fedora 25 (32bit), using Firefox Quantum 57.0. From this issue, I guess that pdf.js version is latest released version.

Please refer to https://github.com/mozilla/pdf.js/pull/8673/files#diff-529d1853ee1bba753a0fcb40ea778723R2309.
Closing as answered.

Here is the text for reference:
+ * Converts API PageMode values to the format used by `PDFSidebar`.
+ * NOTE: There's also a "FullScreen" parameter which is not possible to support,
+ *       since the Fullscreen API used in browsers requires that entering
+ *       fullscreen mode only occurs as a result of a user-initiated event.

I didn’t know that. I wonder how Flash presentations (http://www.free-culture.tk, to name one) can start at full screen.
In any case, how about showing a message to the user that the document is intended to be displayed at full screen?


plugin(jfrog-artifactory): initial migration of jfrog-artifactory plu…

…gin from janus-idp/backstage-plugins
The jfrog-artifactory plugin from the janus-idp/backstage-plugins repository was migrated to the community plugins, based on commit 0c7c7f4a. The migration was performed by following the manual migration steps outlined in the Community Plugins CONTRIBUTING guide.
Hey, I just made a Pull Request!

:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[x] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

just a reminder to add the new codeowner 😄

Is it worth having a sample app for developing/testing the plugin? We can do it in another PR if it's worthwhile and easier


WIP: CLI install style

It follows the CLI install PR https://github.com/fontist/fontist/pull/148
Task: install only selected style
It required to change precedence of font search. Previously, installation of a font was skipped if any of styles was found in a system. The PR aims to solve this problem.

@alexeymorozov are we ready to merge this? Thanks.

This feature is not ready yet, but now code allows to make this feature a lot easier if start fresh.
Let's close for now, and keep it in history?

Agree @alexeymorozov. Thanks!


Faster scanning of root paths

When Ludusavi has no roots paths added, initiating a scan scans some predefined paths I presume because Ludusavi returns 57 games, and in only 6 seconds on my system. As soon as I add just a single root path, e.g. C:/Program Files (x86)/Steam, a scan now takes 44 seconds and returns 62 games. Using the Find roots button and adding all the detected roots and performing a scan takes 66 seconds and returns 64 games.
For only five more games for one root path, and seven games more if adding all detect root paths, this seems like a large increase in scanning time. Are the any optimisations that could be done to speed this up any further than you may have already tried?
Some questions:

Should Ludusavi be returning any results at all when no root paths are added? Why and which paths are scanned?
Could Ludusavi return the results it finds when it has no root paths added first, even when root paths are in fact added? This would show the majority of the games in the first few seconds rather than it slowly populating over the 66 seconds? There's probably a reason why it's done this way (some kind of cross-referencing between paths found I'm guessing), but any speed increase to getting complete results on-screen would be nice, especially now that we can perform manual backups on a per-game basis.
Globs seems to slow down the scan noticeably, especially <some_path>\*\*. The reason is obvious to some people, but maybe some warning about deep globs might be nice to identify why scans are taking longer than usual, to help some users unshoot themselves in the foot would be good?

Ludusavi 0.11.0
Windows 11

Would you say this got slower from 0.10.0 to 0.11.0, or is it about the same as before?

For only five more games for one root path, and seven games more if adding all detect root paths, this seems like a large increase in scanning time.

Keep in mind that it's not only finding more games, but also finding more save files for each of those first 57 games. For example, on my system, a scan without roots finds 189 games in 1.5 seconds, one of which is 1001 Spikes with two save files in my home directory. Once I add my Steam root, the scan finds 288 games in 13 seconds, but also finds an additional 5 files for 1001 Spikes inside of the Steam folder.

Should Ludusavi be returning any results at all when no root paths are added? Why and which paths are scanned?

This covers generic/non-configurable paths, like:

Saves stored in the user's home directory: C:/Users/<name>/Documents/My Games/1001 Spikes/Saves
Saves stored in the registry: HKEY_CURRENT_USER/Software/Dejobaan Games/Ugly Baby

We can find these without asking the user for any configuration.

Are the any optimisations that could be done to speed this up any further than you may have already tried?

I'll have to experiment with this and see what I can find. I'll try to set up a profiler and see where it's spending the most time.

Globs seems to slow down the scan noticeably, especially <some_path>\*\*. The reason is obvious to some people, but maybe some warning about deep globs might be nice to identify why scans are taking longer than usual, to help some users unshoot themselves in the foot would be good?

Sure, I can see about adding a warning for cases like this.

Would you say this got slower from 0.10.0 to 0.11.0, or is it about the same as before?

Slower.
With my 6 detected root paths and 5 custom root paths (no globs), here are some results:

Version
1st run
2nd run
3rd run

0.10.0
76 seconds
75 seconds (after app restart)
-

0.11.0
101 seconds
114 seconds
100 seconds (after app restart)

I'll have to experiment with this and see what I can find. I'll try to set up a profiler and see where it's spending the most time.

This would be cool.

@redactedscribe I found and fixed a couple of performance regressions. Would you mind giving this preview build a try? On my system, the scan time dropped from 13 seconds to 9.5 seconds, which is about the same or slightly faster than v0.10.0.
ludusavi-v0.11.0-post.11+133ab3e-win64.zip

Version
1st run
2nd run

0.11.0
107 seconds
106 seconds

133ab3e
70 seconds
73 seconds

Since the last tests, 2-3 games have been installed on my system and the search time taken by 133ab3e do indeed appear to be slightly faster than 0.10.0. Good work.
It is however still a bit bothersome to me that an initial preview scan is necessary to see the list of games that are most likely to still be on the system. Couldn't we cache all the detected game paths and assume the paths to still be valid on startup by default? If so, the games list could be displayed on startup and a manual backup could be immediately triggered for example. Of course, if triggering a manual backup in this same-as-the-last-scan state, a re-scan of the specific game's paths should occur (since it's probably relatively quick anyway), and if new files are found, perhaps ask to review the list of what will be backed up, else offer the usual "Continue?" dialogue. If performing a global backup of all games on the other hand, warn that the scan may not be up-to-date and offer to backup anyway, or a re-scan and backup. I'm not exactly sure of the details of how Ludusavi works so I could well be assuming some things, but from a user's perspective, I think this would be a better user experience.
These long wait times for just seeing the games list is something I never liked about GameSave Manager and what I found to be refreshing about the Game Backup Monitor approach: the application can be used immediately. Could some kind of middle ground be struck by Ludusavi?

I'm open to doing something like that. How do you feel about this mock-up? On app startup, any known games start in an unscanned state, and you can click a specific game to scan it. The preview button still does a full scan.

https://user-images.githubusercontent.com/4934192/187007090-a72ccef4-10fe-4c88-a4dd-d0fc4f4fdb82.mp4

Since there's no real downside to implementing this, I can't imagine anyone disagreeing. This is definitely a step in the right direction in my opinion.
Some thoughts:
What if we've opened Ludisavi, clicked a game to rescan it, but now we happen to know the game's data has changed... How do we re-rescan it to see the latest detected files in the game's list of files? The only option in this circumstance is to press Preview and rescan all games (including the game of interest) or restart the app. I think this UX is calling for a dedicated way to rescan individual games:

A dedicated rescan button:

This would add an additional button which may be considered a lot per row.
The PCGW link button could become an optional button, able to be hidden via the Other options.

Or perhaps the manual backup buttons could double as a rescan buttons:

If a game is triggered for a manual backed up, regardless if the game is in an unscanned or recently rescanned state, automatically rescan and then show the backup dialogue.

This means if you don't click on the game's grey title, there should only be 1 rescan before backup.
If on the other hand you want to see the files, two rescans happen: one to see the list of files, the other before the manual backup to ensure latest files. Would some optimisation be suitable here, one that does not open a small window where new files could be omitted?

If the user wants to trigger a manual rescan, hold Shift to toggle the column of backup buttons into re-scan buttons.
If the user wants to quickly trigger multiple manual backups, hold Ctrl to bypass the backup dialogue (or rather, assume yes to it), making each backup just a single click.

Thanks for the feedback! I've been thinking about grouping the buttons into a ⋮ menu, which would make it easier to add a preview option without getting too cramped.
Using keyboard modifiers could be interesting. Maybe the ⋮ could turn into the icon for the shortcut action in question, along with a tooltip.

Using keyboard modifiers could be interesting. Maybe the ⋮ could turn into the icon for the shortcut action in question, along with a tooltip.

Right. So a quick way to access one of the items within the menu without opening it I presume. Sounds like a cool idea.
Is there a place I can try out the latest commit's build, or was the previous zip you linked specifically built so that I could test it?

Sure, every commit produces a build you can try, in the "actions" tab of the repository. Here's the latest one: https://github.com/mtkennerly/ludusavi/actions/runs/2941547576 . The builds are at the bottom:

I think having the menu plus keyboard shortcuts (which I still need to add) should be fine without additional icons, but if there's interest, I can re-add them.

Things I'd like to see improved:

Each time a white unscanned game title is clicked, the games list shifts up for a short moment whilst a given game is clicked. Most noticeable on games with a large amount of data to rescan.
The ⋮ button has no background (could be on hover) or outline to indicate its dimensions.

Just throwing another idea out: You may introduce a Rescan button to the ⋮ menu, but the file size of each game's data could also double as a rescan button (since it's currently only a label). So when clicking 12.34 MiB for example, rescan the game's paths. For smaller sizes like 123.45 KiB, clicking it and seeing no change in the number help to inform that nothing more was found, but again, that only helps with smaller file sizes.

Everything should be fixed up now. I haven't added tooltips yet since I wasn't quite happy with how they looked, but I may revisit that before the next release.
Tentative shortcuts:

preview: shift
backup/restore: ctrl (Mac: cmd)
backup/restore without confirmation: ctrl + alt (Mac: cmd + option)

https://user-images.githubusercontent.com/4934192/187353966-cee37e59-b6bc-439a-b75b-c8a460b5eba0.mp4

I like it. Some nice improvements coming in 0.12.0, thanks!

Oh, good point. I'll update that.


Code license

Hi! Could you please add some license to the repo so community could know how and if code can be reused?

✅


Set up CI using the test framework itself

It would be cool to have a CI pipeline which uses the testing framework to test its own code.

Implemented as part of 292ed93


 IF YOU DO NOT FOLLOW THE FORMAT OR MAKE A GENERIC TOKEN REQUEST YOUR ISSUE WILL BE DELETED WITHOUT COMMENT
YOUR JUSTLIST MUST FOLLOW THE JSON SPECIFICATION
https://github.com/justswaporg/justlists/blob/main/example.justlists.ts
Checklist

[x] I understand that this is not the place to request a token listing.
[x] I have tested that my JustList is compatible by pasting the URL into the add a list UI at justswap.org.
[x] I understand that filing an issue or adding liquidity does not guarantee addition to the justlists website.

Please provide the following information for your token.
JustList URL must be HTTPS.
JustList URL:
JustList Name:
Link to the official homepage of the JustList manager:

Bnsn


Admin Image Reupload with Name & Extension Verification #356

Summary
Added Re-upload functionality in the Image Table
#356
Back-end is done by @jayshahWebDev and @Sharathxct helped me to resolve some issues in the front-end integrate the front-end and backend
How to Test the Changes
Type yarn start in the terminal to start the development environment. Go the browser type the url: http://localhost:3000/admin. If there is any file present in the database then it show in the image table or you can upload a new image. At the last column of the image table you will find the reupload button. After clicking on it reupload modal, you can upload the updated image, you can see that the previous image is overridden with the new image(given that the name and extension of the image is same).
Screenshots or Recordings

Checklist

[x] I have added/updated tests that cover the changes.
[x] I have updated the documentation to reflect the changes.


Improved README.md

Hello,
A link(s) on the main AWS site points here. I was hoping this would explain how to install/use EKS-DISTRO, but the README.md is about building docs. It is unclear what the 'built' docs are even for (for example, would it show you an example of installing EKS-D?).
For those who are new to EKS-D, I think the README.md should start with information about EKS-D, not how to build some documentation.
Maybe there is a page that does all the 'basics', but I have yet to find it. I know I will though as soon as I hit "Submit new issue" :)

Accidentally deleted https://github.com/aws/eks-distro/pull/631

Thanks for the heads up!


[SR-657] Out of memory during compilation

Previous ID
SR-657

Radar
None

Original Reporter
fumoboy007 (JIRA User)

Type
Bug

Attachment: Download

Additional Detail from JIRA

Votes
0

Component/s
Compiler

Labels
Bug, Performance, TypeChecker

Assignee
@jopamer

Priority
Medium

md5: a288a3e121511e9c438f393247fec551

Issue Description:
Check out the attached file Joos1W.swift. Only 5000 lines. Out of memory.

Still takes an indefinite amount of time.
cc @xedin


chapter_recurrent-modern/index

Job d2l-zh/PR-787/2 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-787/

Just merge it after ci passes

Job d2l-zh/PR-787/3 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-787/


Flour conversion is off

1 cup of all purpose flour should be 120g, not 130g (source: https://www.kingarthurflour.com/learn/ingredient-weight-chart.html).  Modifying for different flour types would also be nice.

Fixed.


Where are the hooks among classes?

In your config file for train 65, I can see a class order like this:
`ZeroShotMaskRCNN" -> "BackgroundAwareRPNHead" -> "SharedFCSemanticBBoxHead" - > "SemanticFCNMaskHead"
They are classes located in mmdet/models, where are the hook functions that connect among those classes?

See this code, the mmcv runner hooks  all these components.

So they are processed in order right? and what if I just want to run ZeroShotTwoStageDetector only? how would I change?

In fact, ZeroShotTwoStageDetector is composed of Backbone, BackgroundAwareRPNHead, SharedFCSemanticBBoxHead and SemanticFCNMaskHead.  Just like mask rcnn is also composed of similar modules.

"In fact, ZeroShotTwoStageDetector is composed of Backbone, BackgroundAwareRPNHead, SharedFCSemanticBBoxHead and SemanticFCNMaskHead."
I checked the zero_shot_two_stage.py file and I didn't see where did you call these functions BackgroundAwareRPNHead, SharedFCSemanticBBoxHead.

"In fact, ZeroShotTwoStageDetector is composed of Backbone, BackgroundAwareRPNHead, SharedFCSemanticBBoxHead and SemanticFCNMaskHead."
I checked the zero_shot_two_stage.py file and I didn't see where did you call these functions BackgroundAwareRPNHead, SharedFCSemanticBBoxHead.

Please See:
In zero_shot_two_stage:

BackgroundAwareRPNHead:  Instantiate,Forward

SharedFCSemanticBBoxHead: Instantiate,Forward

SemanticFCNMaskHead: Instantiate,Forward

Oh we don't need to directly call BackgroundAwareRPNHead, SharedFCSemanticBBoxHead? How builder knows we wanted to call BackgroundAwareRPNHead and SharedFCSemanticBBoxHead from Registry?

Yes,  we don't need to directly call BackgroundAwareRPNHead, SharedFCSemanticBBoxHead. We pass the class name and the corresponding parameters from config file into  zero_shot_two_stage, the the builder uses the class name like BackgroundAwareRPNHead to build it, see the build code here.

You're awesome. I've got it. I was looking at the registry.py and was wondering that what is shared_head and how is it different from head

shared_head is a share head which is shared between bbox_head for detection and mask_head for instance segmentation.


1.19.3 minimal viable version

I have no idea what I am doing - but if you disable secure chat this works. Probably very much not release-ready.

Apparently this now works with secure chat enabled.

shippit

Good catch. I am afraid I am not familiar enough with secure chat or velocity to be able to fix this.

Ah I see what bug you mean. It happens when players do /kick or /ban. This bug was already present in 1.19.2.

Can confirm the existing bug became a lot worse.

Latest velocity version fixed it entirely for me.

Secure chat is still not fully working, temporarily converting all chats to system messages.


add pages corresponding to password reset option

Description
Added two new pages for the Forget Password feature

Page to request email
Confirmation page to notify user of the email

Also, added the corresponding routes inside the App.js
Type of change

[ ] New feature (non-breaking change which adds functionality)

Future Scope

Some contextual improvements to be made
Implement firebase to complete the password reset process

@AmoghCreator could you remove Enter the Email associated with your account  from the emailsent.jsx page

@Arnabdaz Sure, do you want me to replace it with something or just remove it ??

you can just remove it or you can replace it with a green tick mark svg or animation i guess

@Arnabdaz Please Review :-)

@Arnabdaz Please Review :-)

code looks fine but did you consider the cases when the email doesn't exist or reset password email sending is unsuccessful? or you plan to add those later while implementing the reset mechanism ?

@Arnabdaz Please Review :-)

code looks fine but did you consider the cases when the email is not registered or reset password email sending is unsuccessful? or you plan to add those later while implementing the reset mechanism ?

Yes, I plan to add them later, with the complete implementation.


Feedback: provide choice of render engine

from: https://positpbc.slack.com/archives/C06B0UZKT34/p1722397011679269
I have a jupyter notebook that I want to render as a quarto doc. I would like an option in the publisher when creating the deployment to choose if quarto or jupyter notebook is used to render.

From Jon:

I looked for an extant ticket already, but couldn't find one. So I've created https://github.com/rstudio/connect/issues/27842 for (possibly) changing this default in Connect. Like I mention in the issue, this is really an issue about Connect's default. IMHO the publisher shouldn't override the default, if we think the default is wrong we should change it on Connect.

We should make notebooks on Connect by default render, or use the default based on the frontmatter. Ideally this is not behavior we should change in the Publisher.
Since https://github.com/rstudio/connect/issues/27842 is up in Connect closing.

I think this suggestion makes sense. Connect can decide how to render based on the front matter.
How would the logic work? For example if there is no front matter do you default to rendering as a jupyter notebook? But if there is front matter you render based on that?

For example if there is no front matter do you default to rendering as a jupyter notebook?

Fantastic question. I mentioned we would talk about this again in our sync so I'll re-open and throw on our Triage board to get that discussion going.

Triage notes:

The request in this issue is to make .ipynb files deployable as Quarto docs (we removed this at one point)
We'll need to document the behavior of notebooks deployed in ``notebook mode (code cells are executed) vs. in Quarto mode (they aren't executed unless you set the execute flag in the Quarto YAML.
When we have commented configurations, we should add a note about this in the configuration file.

Verified that we now present the choice 👍


Fails when using a subclassed Store

I am using some shared methods across stores so inherit from a ParentStore class. In this case mobx-persist (or rather serializr) doesnt seem able to deduct the schema correctly.
Minimally adjusted test case from the readme:
import { observable } from 'mobx';
import { create, persist } from 'mobx-persist';

class ParentStore {
}

class SomeStore extends ParentStore {
	@persist('object') @observable         obj = { a: 1, b: 2 };
}

export const someStore = new SomeStore();

const hydrate = create({ jsonify: true });
hydrate('some', someStore, {
	obj: { a: 2, b: 1 } // initial state
}).then(() => console.log('some hydrated')); // post hydration

this gives mobx.module.js?eae6:3100 [mobx] Encountered an uncaught exception that was thrown by a reaction or observer component, in: 'Reaction[Reaction@2] Error: [serializr] Failed to find default schema for [object Object] which is thrown from serializr

@consense Thanks for your report, fixed in v0.4.1~

@pinqy520 amazing - thanks for looking into this so swiftly - works like a charm!

Has this fix been released?
I'm running into the same issue.


PKCS12 KeyStore dropping a Certificate with bc 1.64

Hi I am using a PKCS 12 keystore with bouncyCastle 1.64, but while using : setKeyEntry(String alias, Key key, char[] password,Certificate[] chain) a certificate is getting deleted/dropped from chain automatically.
This was working fine in bc 1.51, then after upgrade to 1.64, we started seeing this issue.
Is there any bug/known issue? Or did anything changed the functionality between 1.51-1.64 ?

You'd need to provide a sample. A lot changed between those two releases.

Unable to reproduce.


Future of brmp

Thank you for taking the initiate to create a much needed high-level interface for Bayesian Modeling. However, it seems the latest commit in this repo was 16 months ago.
Do you plan to continue developing this project?

@fritzo Any chance it will get interest again?


chore: Remove leftover of telemetry-trace-collector-internal noise fi…

…lter
Description
Changes proposed in this pull request (what was done and why):

Removed a leftover noise filter rule which is not needed anymore as the mentioned service got removed with the opencensus removal story

Changes refer to particular issues, PRs or documents:

Traceability

[ ] The PR is linked to a GitHub issue.
[ ] The PR has a milestone set.
[ ] The PR has a respective area and kind label.
[ ] The follow-up issues (if any) are linked in the Related Issues section.
[ ] If the change is user-facing, the documentation has been adjusted.
[ ] The feature is unit-tested.
[ ] The feature is e2e-tested.

@a-thaler tests have to be fixed


VSCode automatically removes content that has syntax error

In VSCode editor with a .zmodel file, past the following:
datasource db {
    provider = 'sqlite'
    url = 'dev.db'
}

model User {
    id Int @id @default(autoincrement())
    username String
    sent Chat[] @relation('sent')
    received Chat[] @relation('received')
}

plugg abc {

}

model Chat {
    id Int @id @default(autoincrement())
    subject String
    fromUser User @relation(name: 'sent', fields: [fromUserId], references: [id])
    fromUserId Int
    toUser User @relation(name: 'received', fields: [toUserId], references: [id])
    toUserId Int
}

When saved, the "plugg ABC { ... }" part disappears.

@jiashengguo do you think this can be related to auto-formatting?

Yes. It seems that langium has got a fix for it, but targeted for the next release 1.2.0:
#https://github.com/langium/langium/issues/912
The idea is simply not to format if there is any syntax error.  I think I can make the same fix from our side first.

fixed by #407


add an initial broadcast to all presets when pipeline created

This allow presets to do initial work after constructor() but before xxxOut(In).


Add ENV variable for custom chia arguments

For example, to be able to set --passphrase-file, without which chia will not start or start corrupting an existing blockchain db.

Hey there! Thanks for the submission. Would you please make one additional change of adding this new var to the list of ENV declarations in the Dockerfile? We like to have all the available variables that can be set here: https://github.com/Chia-Network/chia-docker/blob/main/Dockerfile#L25
Just looking for a new line with ENV chia_args=

Makes total sense, added!

BTW let me know if you'd like me to make some update to the readme file to document this variable.


Build cilium-operator, generate shell completions

This change is

Coverage increased (+0.007%) to 43.466% when pulling 694c820eb8b0f79a1012dddc196f9e9542ed45db on tonylambiris:tl/add-cilium-operator into fad721332786ddbae8aeb20f8cdbe5432065fa84 on cilium:master.

test-me-please

test-me-please


Action fails because docker contains doesn't contains mksquashfs

You are probably already aware of this, but the action currently fail because the https://hub.docker.com/r/appimagecrafters/appimage-builder docker image doesn't include mksquashfs
The image should probably be updated to include it

Any way to fix this inside the action itself for the time bieng?

I have been trying to figure this one out but haven't had any luck myself. I don't know how to get that program to available inside the docker image for a workaround

You can run
apt-get update && apt-get install -y --no-install-recommends squashfs-tools

as part of your script section as a workaround for the time being.

The issue was fixed in the image by commit cf1a153, but there's no release yet.


update to work with django 1.10

With help from @billyburly, this removes the deprecated options overrides with what's being used in django 1.10.  Tested with 2015 census data, and currently being used in my app.

I've added a new commit with support for the 2016 census data, while cleaning up the management commands to make it easier to support future updates.  Not sure if you can absorb that into this PR or if I should resubmit a new one.
This works with my app under Django 1.10, GeoDjango, Postgresql/postgis.
I'd love to be able to add this to the pip repos as well, let me know what I can do to help make this happen.
Thanks for the great django app!  It saved me lots of time.

Thanks @billyburly and @jlillest for all the work, and my sincerest apologies for the delay. Have reviewed here at DjangoCon sprints and am going to merge/make a couple changes and push to PyPI today.


Linux 64 bit, crash on excessive alt-tabbing

Duplicate issue: I haven't found any when searching for Linux related crashes
Godot version: 3.0.2, binary version
OS/device including version: Linux Mint 18.3
Issue description:
Godot crashes when I am switching the windows frequently in order to look up how the tutorial script is structured. The exception it shouldn't crash at all when alt-tabbing. Also it might be worth to note that the game will keep running when the editor crashed. The compiled version (3.0 Github) which is compiled in debug mode doesn't seem to cause this issue at all, I have alt-tabbed at least 30+ times and no crash while the regular Linux binary release has this issue.
regular release log: crashlog.txt
compiled debug log: log_debug.txt
Steps to reproduce:

Load up any project
Keep alt-tabbing a lot i.e switching the active windows
Godot crashes with a segmentation fault

Can't reproduce it on Mageia 6 x86_64 running Plasma 5.12 and with a Nvidia GTX 670M (driver 390.42).
I guess you're running Cinnamon? The crash happens in the nvidia 340 driver, so it might be specific to this driver version and/or to Cinnamon's window manager.

I guess you're running Cinnamon?
No I am using XFCE/xfwm4 + composit
The crash happens in the nvidia 340 driver, so it might be specific to this driver version
Sounds plausible, though it makes me wonder why it is happening for me with Godot and not other programs, I just tested this on Blender too see if it has the same bug or if its due to my driver and it did not crashed.

More users trying to reproduce this are welcome.

Tried a couple different setups:
Mint 18.3 XFCE / NVIDIA 390.77
Mint 19 XFCE / NVIDIA 340.106
Could not reproduce with 3.0.6

Can't reproduce using 3.0.2. I am on Manjaro (Linux <IP_ADDRESS>). NVIDIA Driver 340.107. Mate 1.20.3.
I did not see any strange CPU consumption, neither strange RAM consumption.
@JohnSmith25 : did you encounter this bug still with 3.0.3 or newer ?
Can you reproduce it easely ? I mean, opening the project and alt+tab 30 times and voilà, reproduced ?
Would be cool if for each stable release, the godot team save the symbols associated to it. I think it is possible, and making the dumptrace less obscure.

Can't reproduce any crash with the latest master on Xubuntu 18.04 LTS (XFCE 4.12)

Could not reproduce the error using the latest master at the time of writing.
Linux Mint 19 Cinnamon, OpenGL ES 3.0 Renderer: GeForce GT 635M/PCIe/SSE2 - Driver 390.77


Date format option, bug fixes, from and to date watchers

Added closeOnSelect option to close datepicker on date selection (click, tap). Hides "Set" button.
Added dateFormat option to show dates in user specified format in popup or modal
Years list are generated considering to and from dates. Fallback: 1900 - 2100, if dates not set.
Forced inputDate to have 0 hours, minutes, seconds and milliseconds. This fixes bug if I set inputDate: new Date(), then current date won't be preselected.
Added watchers for from and to dates. Now we can change them from controller, for example in callback. Useful for connected dates. For example: to date input can't be less than from and vice versa.
Fixed conflict in modal template.
Made CSS more specific to ionic-datepicker, so there won't be conflicts.

Thank you so much @renekorss

No problem. I just needed most of these things, so why not share. :) Thank you for merging.


Update present_on_multiple_rows_within and not_present_on_multiple_rows_within operators to work with entities

These operators currently return a 'DataFrame' object has no attribute 'tolist' error when used with a DDF/USDM entity.

The operators return the error when there's only a single group of values in the variable specified in within - this is true for both DDF/USDM entities and SDTM domains/datasets.  See #599

Issue has been superseded by #599


Suggest : add location

Hello
In Telegram alert all it says is something like « Business : # of stock »
But I got same business in different town. Is it possible to add the location like in the TGTG app ?
Something like « Business - Location : # »
thanks !

Hi,
Unfortunately I can't retrieve just the name of the town.
Only the full address is returned but this does not make the notifications unreadable.

Hi,
Unfortunately I can't retrieve just the name of the town.
Only the full address is returned but this does not make the notifications unreadable.

oh alright because as you can see in the original app I got a business called « Boulangerie Thirion » and there’s one in two different town. This variable can’t be called with the API?

oh alright because as you can see in the original app I got a business called « Boulangerie Thirion » and there’s one in two different town. This variable can’t be called with the API?

The api returns the parameters: city, address, postcode but only the address (which contains street, city, postcode) is returned with a value. The others are always empty.

The api returns the parameters: city, address, postcode but only the address (which contains street, city, postcode) is returned with a value. The others are always empty.


Configure swiftformat + modify license CI check

What changes are you making?

NOTE: This PR does not run swiftformat on the sample apps yet. It will happen in a follow up.

[x] Uses swiftformat to reformat code for better readability in code reviews. Swiftformat will run on build for sample apps.
[x] Adds a .swiftformat config file
[x] Renames copy_license script to ensure_license and updates workflow script

Formatting of the MobileBuyIntegration sample will happen in https://github.com/Shopify/checkout-sheet-kit-swift/pull/248


ionic resources does NOT update old icon

ionic resources does not work as documented.  I have followed docs to a T and the only way I can update the icon is by removing android platform and re-installing.

Greetings @sclearion!
My sensors indicate that you need to update your issue through our custom issue form. We are now requiring all issues to be submitted this way, to ensure that we have all of the information necessary to fix them as quickly as possible.
Click Here To Update Your Issue
I will have no choice but to close this issue if it is not resubmitted through the form. Please fill out the rest of the form, so that I may use my friendly robot powers to assist you.
Thank you!

I think this issue was not posted by me
On Wed, May 13, 2015 at 4:30 PM, Ionitron<EMAIL_ADDRESS>wrote:

Greetings @sclearion https://github.com/sclearion!
My sensors indicate that you need to update your issue through our custom
issue form http://ionicframework.com/submit-issue/#/?iid=3723. We are
now requiring all issues to be submitted this way, to ensure that we have
all of the information necessary to fix them as quickly as possible.
Click Here To Update Your Issue
http://ionicframework.com/submit-issue/#/?iid=3723
I will have no choice but to close this issue if it is not resubmitted
through the form. Please fill out the rest of the form, so that I may use
my friendly robot powers to assist you.
Thank you!
—
Reply to this email directly or view it on GitHub
https://github.com/driftyco/ionic/issues/3723#issuecomment-101806195.

--
Cesar Vega
Software Engineer
Where Great Brands Begin®
http://www.brandinstitute.com/images/logo.jpg
http://www.brandinstitute.com/images/logo.jpg

This issue was moved to driftyco/ionic-cli#420


Can not work with Arduino IDE 1.5

Because in the 1.5, the boards.txt is in
/Applications/Arduino.app/Contents/Resources/Java/hardware/arduino/avr
Will there be a simple way to specify the directory?

I found a hack-ish workaround involving symlinking here:
https://arduino.stackexchange.com/questions/37495/why-is-my-boards-txt-file-not-being-found/37496#37496


Skip building HotROD for all platforms for pull requests

To speed up CI for pull requests we avoid expensive multi-platform image building. For example, the all-on-one CI workflow .github/workflows/ci-all-in-one-build.yml uses BUILD_FLAGS=-l -D -p linux/amd64:

-l for local build only (no pushing to public registry)
'-D' to skip building debug image
'-p' to only build for the GH runner's platform

We should reproduce the same functionality for .github/workflows/ci-hotrod.yml and scripts/hotrod-integration-test.sh

Hi @yurishkuro, as per my understanding do we have to achieve the similar BUILD_FLAGS configuration while building the image for HotROD if running on a Pull request. And defining those flags action to the corresponding script file?
I can come up with a PR if you can guide me more about the issue and if I am thinking in a right direction?

yes, we can replicate similar setup and CLI flags from the other scripts


sync/async effects, WoM fix, hidden token fix

Hi,
this is my second attempt to make async/sync effects fully awaitable and distinguish which ones can be async. It also adds extra awaits, mostly insides of opposed test class. If you would approve this, i could move forward with few other features that i find interesting and using them in my games:

awaitable sockets - which allows me to request a test from player as gm and wait with rest of effect execution once the test was completed.
automatic response for opposed tests from minions. When i have plenty of minor opponents like goblins, ratmans or whatever, i dont like to click too much to 'roll opposed test with weapon or skill, apply damage or effects when failed'. Instead, i have small extension that allows me to mark specific tokens as 'auto-resolve' but it requires more awaitable effects and opposed tests.

in addition:

there is a fix for WoM overcast template (missing closing div).
fix channel until ready (again).
fix for hidden tokens in combat - now it syncs token status with combatant status and chat cards.

Instead of commenting on everything I'm just going to comment here saying I'm a bit leery about this. This seems to have just slapped await on... almost everything, and in many cases I don't see the reason.
I'm going to close this, but I don't want to come off as unreceptive to the changes. So open separate PRs for your fixes. Have a another PR for your effect changes, but lets keep it focused on effects, or whatever is relevant there.


Clean up / simplify code

No need to filter and regroup the results,
we can just use the whole input array,
since it has been filtered at the parent layer.

Reaction to https://github.com/oasisprotocol/explorer/pull/478#discussion_r1223326004


Wiring junctions in a way a msg is not transmitted

Current Behavior

Possible to wire odd arrangement where no msg gets through (DEMO 1)

Deleting a "good wire" then replacing it causes odd wiring and msg does not make it through the flow. (DEMO 2)

Expected Behavior
Prevent joining if not valid
Steps To Reproduce
Import (or replicate) the flows below.
Example flow
Demo 1...

[{"id":"83a067d8d7767cf5","type":"inject","z":"a8f2fd5e9bb60bcf","name":"","props":[{"p":"payload"},{"p":"topic","vt":"str"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","payload":"fred","payloadType":"str","x":1330,"y":380,"wires":[["9a0438fb36dbd9ea"]]},{"id":"a1dc381d92309c80","type":"debug","z":"a8f2fd5e9bb60bcf","name":"debug 1","active":true,"tosidebar":true,"console":false,"tostatus":true,"complete":"payload","targetType":"msg","statusVal":"\"fred \" & payload","statusType":"jsonata","x":1300,"y":440,"wires":[]},{"id":"7fbe3faf3bb4e7f8","type":"junction","z":"a8f2fd5e9bb60bcf","x":1160,"y":440,"wires":[["a1dc381d92309c80"]]},{"id":"d50f402dffed4939","type":"junction","z":"a8f2fd5e9bb60bcf","x":1460,"y":380,"wires":[["7fbe3faf3bb4e7f8","9a0438fb36dbd9ea"]]},{"id":"9a0438fb36dbd9ea","type":"junction","z":"a8f2fd5e9bb60bcf","x":1520,"y":500,"wires":[[]]}]

Demo 2

[{"id":"c002f56b02ae7c32","type":"debug","z":"a8f2fd5e9bb60bcf","name":"debug 2","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"false","statusVal":"","statusType":"auto","x":1347.999997317791,"y":159.99999886751175,"wires":[]},{"id":"a32c97b613303016","type":"inject","z":"a8f2fd5e9bb60bcf","name":"","props":[{"p":"payload"},{"p":"topic","vt":"str"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","payload":"","payloadType":"date","x":1340,"y":100,"wires":[["5b0dff4c80021945"]]},{"id":"d6b44c2c93c77454","type":"junction","z":"a8f2fd5e9bb60bcf","x":1480,"y":180,"wires":[["ad382084c106decc"]]},{"id":"5d4b29c28d9152d9","type":"junction","z":"a8f2fd5e9bb60bcf","x":1520,"y":160,"wires":[["d6b44c2c93c77454"]]},{"id":"ad382084c106decc","type":"junction","z":"a8f2fd5e9bb60bcf","x":1420,"y":260,"wires":[[]]},{"id":"bf134fcd2c0ea7ba","type":"junction","z":"a8f2fd5e9bb60bcf","x":1260,"y":260,"wires":[["f10bdcd36f35efd7","ad382084c106decc"]]},{"id":"f10bdcd36f35efd7","type":"junction","z":"a8f2fd5e9bb60bcf","x":1227.999997317791,"y":159.99999886751175,"wires":[["c002f56b02ae7c32"]]},{"id":"5b0dff4c80021945","type":"junction","z":"a8f2fd5e9bb60bcf","x":1480,"y":100,"wires":[["5d4b29c28d9152d9"]]}]

Environment

Node-RED version: 2.2.2 on dev branch
Node.js version: 16
npm version: NA
Platform/OS: Windows 11
Browser: Chrome 99.0.4844.74

We explored this on this week's livestream (which I haven't put on youtube yet... now reminded to do so)
When wiring from a junction, the key thing is you are creating the wire in the direction you want messages to flow.
On the live stream I showed a quick move around of the nodes above showed perfectly valid flows where you'd want the wires in the directions shown (once a couple more nodes were added).
I reached the conclusion this was working as intended and no amount of logic would be able to identify you wanted something different and reverse the wire.
Arrowheads (#3318 ) were looked at... but that then got very messy when you have lots of junctions. But as arrowheads were going to be an optional thing anyway, then I wouldn't lose sleep over it.
So I think the net conclusion is this is working as designed - we just need to make sure the docs make it clear that when you wire from a junction, you must be wiring in the direction of message flow.

Hi knolleary
it could be helpful to replace the last join line circle icon, with an arrow indicating the msg direction.
Instead of: o——o
Something like: o———>

Perhaps on :hover of a junction, it morphs into an arrow head?
i.e. as you drag a wire from / approach a junction to drop a wire, the junctions shape indicates direction of flow?

Otherwise, we can just close this issue since it is not actually a bug but merely an "understanding" thing?

I think I would find that distracting - wondering what it was about to do. But maybe a smaller arrow ?

@dceejay yes the arrow inside looks much better (my CSS animation was a quick and dirty copy/paste affair for demonstration purposes entirely)
If it's an accepted approach, I (someone) will do a much better job of it 😉

Added the label wont fix since it is functionally correct.
However if desired, we can explore the on hover animated arrow (inside the bullet to indicate flow direction)
Closing issue for now.


SIMEC Institute of Technology

Add SIMEC Institute of Technology

@asraful009 First stage of verification passed, official domain for SIMEC Institute of Technology is simecinstitute.edu.bd as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@asraful009 Pull request merged. Thank you.


Enable the flytekit to be pluggable

Alternative to https://github.com/flyteorg/flytekit/pull/1941

Why are the changes needed?

This PR makes pyflyte pluggable by external libraries to adjust the CLI commands and update the remote.
What changes were proposed in this pull request?

This PR adds a FlytekitPlugin to have the pluggable CLI API be in one place.  For this initial PR, it gives the minimum API surface for configuring the API.
Implementation-wise, the external plugins are loaded through entry points and have the group name: flytekit.configuration.plugin.
How was this patch tested?

Existing unit tests were updated to into account the changes.
The Plugin API is tested with it's own unit test.

@cosmicBboy The monodocs failure in the CI is unrelated to this PR, but looks real.

In https://github.com/flyteorg/flytekit/pull/2039/commits/9b90029b71232340e3378407abffb780596df9ca I have pytest patch the plugin variable. This way if another plugin gets loaded, the tests still run with the first-party FlytekitPlugin.

I updated the solution to https://github.com/flyteorg/flytekit/pull/2039, which I am happy with. This allows pytest to configure the loaded plugin on demand.


Add option to reverse qubit order when drawing circuits

What is the expected behavior?
Currently, qubits registers are displayed with their lower bits in the top; the flag would allow the order to be reversed.

I found a bug in latex_circuit_drawer when conditional gate is drawn with reversebits option.
How to reproduce the problem:
q1 = QuantumRegister(3, 'q1')
c1 = ClassicalRegister(3, 'c1')
qc = QuantumCircuit(q1, c1)
qc.x(q1[0]).c_if(c1, 2)
circuit_drawer(qc, style={"reversebits": True})

The results:
...
~/testbench/qiskit/tools/visualization/_circuit_visualization.py in _get_image_depth(self, aliases)
    611                         for i in range(pos_1, pos_2 + self.cregs[if_reg]):
    612                             if is_occupied[i] is False:
--> 613                                 is_occupied[i] = True
    614                             else:
    615                                 columns += 1

IndexError: list index out of range

Index of registers is not correctly handled in `latex_circuit_drawer' when bit order is reversed.

@nkanazawa1989 could you please file a new bug, please?


Update try-catch-transact-sql.md

Added a comment on line 317 to elaborate the reasoning of why a COMMIT maybe reasonable to do within a CATCH block. I myself was puzzled till I found help here - https://stackoverflow.com/questions/2836082/why-would-you-commit-a-transaction-within-a-catch-clause

@sunilmathew : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@sunilmathew Thanks for contributing to the article here! Let me look at your change and the link. I'll try to get back to you soon.

@rothja : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@sunilmathew Thanks for your suggestion here. I hope you don't mind that I changed and simplified the comment you added for clarity. Appreciate the feedback on something that could potentially be confusing. #sign-off