Ensure that correlation id is present in all steps of the flow

Synopsis:
As a person investigating errors
I want to have correlation Id on my logged messages
so that I can search uniformly across different steps in the flow independently of where the message was logged

AC1: Stamp correlation id on to event hub message properties
AC2: When entering a step in the flow, the step and correlation id is logged into application insight
AC3: When an exception occurs and is logged the correlation id is logged together with the exception message where possible

Issue moved to Energinet-DataHub/geh-timeseries #407 via ZenHub


Error when username contains dash

Given @foo-bar (which is a valid github username), this plugin will throw an error:
Error: Expected node, not `undefined`
    at nlcstToString (/Users/bkeepers/projects/guides/node_modules/nlcst-to-string/index.js:29:15)
    at /Users/bkeepers/projects/guides/node_modules/retext-syntax-mentions/index.js:26:9

😬
I just tested it and it worked for me. Could you provide more info on what fails and how I can reproduce it?

Sorry, I mis-diagnosed the issue. It turns out the error is caused by the username being at the very end of the input.
Here is an example that shows it:
var dictionary = require('dictionary-en-us');
var retext = require('retext');
var english = require('retext-english');
var spell = require('retext-spell');
var mentions = require('retext-syntax-mentions');
var report = require('vfile-reporter');

retext().use(english).use(mentions).use(spell, dictionary).process([
  'Misspelt? @wooorm'
].join('\n'), function (err, file) {
  console.log(report(err || file));
});

Note that this is identical to the example in the README, except:
-  'Misspelt? @wooorm.'
+  'Misspelt? @wooorm'
 ].join('\n'), function (err, file) {

Ah, great, weird that I hadn’t tested @s near the end of a sentence.
Thanks for the issue, and happy New Year! 🎆🎇


Fixed the wrong docker release tags in this adapters

Signed-off-by: Bishal das<EMAIL_ADDRESS>Description
Fixed the wrong docker release tags in this adapters
This PR fixes https://github.com/meshery/meshery/issues/6408
Signed commits

[x] Yes, I signed my commits.

Replica of https://github.com/meshery/meshery-traefik-mesh/pull/236


Wifi and other settings lost if device reset or powered off

Hi all,
Strange one. I've had my Yi Home 1080p (9FUS) for a few years now and it's been working fine every time I've used it. I started using it again a few weeks ago and all was fine until I plugged it in last night. The orange LED came on and I got the "Welcome to yi home. Waiting to connect" audio message. I set the wifi connection up again in the app and when I connected to the web page is showed the Yi Hack was still active, but some settings had changed. The problem is that if I try and change anything and reboot to activate, I end up back at the "Waiting to connect" step.
I've tried wiping and scanning the sdcard (h2testw) and no issues were reported. I've tried unhacking and rehacking and still have the same issue. It was working fine for a week or so on this firmware and there's been no network changes or settings changes prior to this issue.
Has anyone any ideas?

You should try to:

unhack the cam with the unbrick procedure (stronger than just unhack) using "hacked" option
reset the cam with the back button
reconfigure it from scratch
apply again the hack if you want

Trying this now but keep getting the following error when I try to build the unbricked file:
modprobe: FATAL: Module mtdram not found in directory /lib/modules/5.15.32-v7l+ umount: y20ga/mnt: not mounted. cp: cannot create regular file 'y20ga/home/app/init.sh': No such file or directory cp: cannot create regular file 'y20ga/home/app/script/update.sh': No such file or directory cp: cannot create regular file 'y20ga/home/app/script/wifidhcp.sh': No such file or directory cp: cannot create regular file 'y20ga/home/base/tools/extpkg.sh': No such file or directory ./create.jffs2: 3: ./mkfs.jffs2: Exec format error mkimage: Can't open y20ga/mtdblock3_hacked.bin: No such file or directory
Tried it on a raspberrypi 5.15.32 and Ubuntu under Windows and got the same issue. Any ideas?

I think that mtdram module is not available on this platforms.
You should try a standard linux distribution on x86 or amd64.
Or you should modify the script with another jffs2 extractor (jefferson for example).

I had exactly the same Problem with my y20ga camera.
After a reset (with female voice), I can connect the camera to the WiFi via the app using the qr code. But as soon as I restart or reset the camera, it reboots and gets stuck with a flashing blue light and doesn't connect to WiFi.
According to your recommendation I did also create the unbrick image with my initial backup "mtdblock3.bin" :
./build.sh hacked 23552+0 Datensätze ein 23552+0 Datensätze aus 12058624 Bytes (12 MB, 12 MiB) kopiert, 0,0684203 s, 176 MB/s Successfully mounted y20ga/mtdblock3.bin on y20ga/mnt Image Name:   xiaoyi-home Created:      Mon Sep  5 21:45:43 2022 Image Type:   ARM Linux Filesystem Image (uncompressed) Data Size:    12058624 Bytes = 11776.00 KiB = 11.50 MiB Load Address: 00000000 Entry Point:  00000000
Then extracted the generated "home_y20ga.gz" and copied the "home_y20ga" file to the root of the sdcard.
After a long reboot, the camera gets stuck with a flashing blue light. After a reset on the small back button (no voice) I can't get it to live again :-(

With the unbrick method you should be able to restore the cam (if the bootloader is ok).
Try again with the command:
./build.sh factory
In this manner the hash of the image is different and the cam will reload it.

After several attempts to hack or unhack the firmware, I also managed to brick the camera. Only the yellow light was on and the camera no longer booted (no clicking noise, no blue LED). So I opened the case and unbricked the camera with my usb to serial converter according to the wiki entry.
Now the camera is online again, the firmware has been hacked again, but the problem that the camera no longer automatically connects to the wifi persists. After every reboot I have to transmit my wifi credentials again via the app and the QR code of the camera.
@roleoroleo Do you have an idea what could be the reason for this?

For hours I tried various things to get to the bottom of the error. Unfortunately, the points mentioned here did not bring any improvement either... The camera simply did not want to remember the Wifi credentials. After each reboot, the qr code from the yi home app was repeatedly requested :-(
With some research in the various scripts of this repo I understood how and where the wifi access data is stored.
I took a closer look at the /dev/mtdblock6 memory and saw that the SSID and password (in plain text) were repeatedly stored "corruptly".
So I started from scratch and overwrote all MTDblock devices with my backup data:
dd if=/tmp/sd/backup/mtdblock0.bin of=/dev/mtdblock0
dd if=/tmp/sd/backup/mtdblock1.bin of=/dev/mtdblock1
dd if=/tmp/sd/backup/mtdblock2.bin of=/dev/mtdblock2
dd if=/tmp/sd/backup/mtdblock3.bin of=/dev/mtdblock3
dd if=/tmp/sd/backup/mtdblock4.bin of=/dev/mtdblock4
dd if=/tmp/sd/backup/mtdblock5.bin of=/dev/mtdblock5
dd if=/tmp/sd/backup/mtdblock6.bin of=/dev/mtdblock6
dd if=/tmp/sd/backup/mtdblock7.bin of=/dev/mtdblock7
reboot

After that the firmware was back to its original state. Then I reconnected to wifi via app and QR code. Imported the hack via SDCard and loaded my old config again via the web interface... lo and behold - everything works :D
How it came about... no idea! But I won't be touching the wifi data anytime soon ;-)
In any case, many thanks for all your support here and this great firmware hack!

Glad to hear that you have solved it.
Next time avoid overwriting mtdblock0, it is a risky operation.

Unfortunately, I got excited too soon!
After the camera was switched off for a longer time, it could not reconnect to WiFi today. Had to connect via QR code from the YiApp again. Then I set the access data via WebIF.
I tried to reproduce the steps of the cgi-script and looked at the content of mtdblock6.
Create /tmp/configure_wifi.cfg with content:
wifi_ssid=MYSSID
wifi_psk=MYSECRET

Run script: /home/yi-hack/script/configure_wifi.sh
...
CURRENT_SSID=$(dd bs=1 skip=28 count=64 if=/dev/mtdblock6 2>/dev/null)
CURRENT_KEY=$(dd bs=1 skip=92 count=64 if=/dev/mtdblock6 2>/dev/null)
CONNECTED_BIT=$(hexdump -s 24 -n 4 -v /dev/mtdblock6 | awk 'FNR <=1' | awk '{print $3$2}')

echo $SSID ${#SSID} - $CURRENT_SSID ${#CURRENT_SSID}
echo $KEY ${#KEY} - $CURRENT_KEY ${#CURRENT_KEY}
....

Output:
MYSSID 6 - PA'c'i 6
MYSECRET 8 - 0"!PepUi 8
I can try this multiple times. The output of CURRENT_SSID or CURRENT_KEY is every time different and looks distorted / crypted. Can someone reproduce this behavior?
Or is the block of my flash memory broken? :-(
PS: I will go with this workaround for now.

Hi @jojo141185 , I got the same issue. Even worse for me, I cannot find my firmware backup. I connected their support for a firmware, they refused to send me a copy because my devices are out of support.
Could you share your backup with me?

Have a look at the unbrick howto and this post for details and (ASK for) backups.


Revert "!sbt Use multiJvmPlugin from pekko."

This reverts commit 1f5b25de4fee337aa5995917fd1649f36cee5aa8.
Once https://github.com/apache/incubator-pekko/pull/549 get merged and the nightly build updated to the new snapshot.

@pjfanning @mdedetrich The nightly has the new commits https://github.com/apache/incubator-pekko-http/actions/runs/5804121454/job/15733226514 can we have this in now?


Fix lint errors from #2798

Summary
Fixes lint errors that didn't show up through the GHSA process (which can't run tests)
Change Type
Mark the type of change your PR introduces:

[ ] Bug fix (resolves an issue without affecting existing features)
[ ] Feature (adds new functionality without breaking changes)
[ ] Breaking change (may impact existing functionalities or require documentation updates)
[ ] Documentation (updates or additions to documentation)
[x] Refactoring or test improvements (no bug fixes or new functionality)

Testing
Ran unit tests
Review Checklist:

[x] Reviewed my own code for quality and clarity.
[x] Added comments to complex or tricky code sections.
[x] Updated any affected documentation.
[ ] Included tests that validate the fix or feature.
[x] Checked that related changes are merged.

It needs another make lint-fix

coverage: 53.23%. remained the same
when pulling a7f2cec876449a1deda41b28a20835132052385e on evankanderson:fix-lint
into 9cba1f30d48513556aa600c295a4a8cd84af922c on stacklok:main.

Preferring #3587


Feature Request

Hi,
over all - a fantastic useful tool/helper.
But it would be nice to have it as dragable window. And also to change the display mode to horizontal
Thanks a lot!
Mischugo

related to #114


Use zip package manager instead of checkin in devops resource kit;

Running command: "dotnet apimtemplate.dll extract --extractorConfig "/Users/xxxx/Documents/untitled folder/vscode-apim-demo.json""...
It was not possible to find any compatible framework version
The specified framework 'Microsoft.NETCore.App', version '2.1.0' was not found.
  - Check application dependencies and target a framework version installed at:
      /
  - Alternatively, install the framework version '2.1.0'.

Make the extract functionality independent of framework version.

Use a platform independent build for devops resourcekit and produce a github release (zips)
use the zip package management like below
Zip package management in vscode extension example,
Here is how csharp omnisharp extension for vscode manages .net dependencies(as zips). We can take a similar approach for managing devops resourcekit zips.
https://github.com/OmniSharp/omnisharp-vscode/blob/master/package.json
Look at the runtimedependencies section in the above file
Example to manage razor dependencies
{
 "id": "Razor",

 "description": "Razor Language Server (Windows / x86)",

 "url": "https://download.visualstudio.microsoft.com/download/pr/59f9e3a8-cd84-4b37-927e-256a518e62b9/e7d9c51b3a91dff4fbd941da04a6533b/razorlanguageserver-win-x86-5.0.0-alpha.1.19605.17.zip",

 "fallbackUrl": "https://razorvscodetest.blob.core.windows.net/languageserver/RazorLanguageServer-win-x86-5.0.0-alpha.1.19605.17.zip",

 "installPath": ".razor",

 "platforms": [

   "win32"

 ],

 "architectures": [

   "x86"

 ]

},
Here is the core logic for package management
https://github.com/OmniSharp/omnisharp-vscode/tree/master/src/packageManager
Logic that reads the runtimedependencies section
https://github.com/OmniSharp/omnisharp-vscode/blob/41c5a0582be1c83e7bc662d084d062efd6efd3f4/src/InstallRuntimeDependencies.ts
Here is where it is called as part of extension activate
https://github.com/OmniSharp/omnisharp-vscode/blob/70b37a67d8f1c3985b7aa110ba5f827b8eed7da8/src/main.ts#L174

@RupengLiu please triage.


Thumbnails in zip files

What feature or improvement do you think would benefit Files?
Thumbnails currently don't show when viewing compressed files. Could there be an option to enable this?
Requirements

Add option to display thumbnails for media in compressed files, for perf reasons since not everyone would want it.
When opening a compressed file, generate thumbnails for media if the option is set.

Files Version
<IP_ADDRESS>
Windows Version
22621.1992
Comments
No response

@shravan2x thank you for your feedback, thumbnails aren't available for compressed files by design. You can however extract the archives to view them.

@yaira2 Can you clarify why we want this behavior by design? It seems like it would be a useful feature.

@yaira2 Bump, could you clarify the above?

I'm not sure the reasoning behind this but it's consistent with the behavior in File Explorer as well.

It isn't possible when compressed as Files (Windows File Explorer too) would have to decompress the archive to get the correct data for that file and then generate the thumbnail. It wouldn't make sense to auto extract archive as you browsed through it.

I agree that it's consistent with the behavior in File Explorer. But File Explorer is an outdated tool. That's what makes Files.app so amazing - it feels like it's built for 2023!
Yeah, you'd have to decompress the archive to get the correct data for each file. But if done with virtualization in mind, you'd only have to decompress the images and videos that are visible in the current frame. On modern systems, this is usually an acceptably expensive operation, especially keeping in mind that user convenience would take priority.
I've also personally built a similar feature - the performance hit isn't much on a modern multi-core machine.

I'm looking for an modern file explorer to preview images in zips too.
It's disappointing that Files refuse doing it, but my workaround is use something like WinMount to mount the zip file and preview images inside with the old school file explorer or Files.app,


Missing LICENSE file

The repo does not specify a license. A license would make it easier for other people to contribute, and also makes clear how people can use the content and code examples.

https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/adding-a-license-to-a-repository
https://choosealicense.com/

The repo does not specify a license. A license would make it easier for other people to contribute, and also makes clear how people can use the content and code examples.

https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/adding-a-license-to-a-repository
https://choosealicense.com/

Thanks, done already:)


Delete after update

Describe the feature request
I propose adding an additional annotation, such as k8s-ttl-controller.twin.sh/updateTimestamp. The purpose of this annotation is straightforward: it serves as an alternative to metadata.creationTimestamp for cases where a user wants to control the object's deletion timing based on a redeployment, rather than delaying deletion after the initial creation.
The logic is straightforward: if the annotation exists, it is used as the starting point. If not, metadata.creationTimestamp is used by default.
Why do you personally want this feature to be implemented?
This feature would be helpful for my project. I'm happy to contribute to its implementation. I think it would be nice to discuss the details of this functionality beforehand.
How long have you been using this project?
No response
Additional information
No response

Something like k8s-ttl-controller.twin.sh/refreshed-at would be a great idea, I agree, and your suggested implementation (check annotation first then fallback to metadata.creationTimestamp makes sense!

Implemented by #97


Add support for -33 and -34 version numbers

Support added in latest commit, but testing needed

Working on the tests

Closed with the changes introduced in commit 7c3aae5


New version: YuzuEmu.Yuzu.Mainline version 1433

Pull request has been created with Komac v1.6.0 :rocket:
Microsoft Reviewers: Open in CodeFlow

/azp run


 It takes change on the part of both organizations and applicants to fix it.

For Organizations

recognize that your hiring process is the way that many people in the industry will see your company and consider it for the first time. Make sure you are living your values in your hiring process.
remember that people and hiring make or break a company. It is the difference between a team of people who share a common vision and add to a culture, and a bunch of people acting like cogs in the machine.
expect hiring to take time. Especially the time of hiring managers. It is unavoidable for a quality process. And it should take time. That's part of the investment. This is not to downplay the role of recruiters, but to say that the people involved in the vision for and outcomes of the work need to be connected deeply in this process to the people who will be doing the work with them.
Focus on "day 1" skills in a job description. A laundry list of buzzwords helps nobody and leads to gaming the system. Things beyond day one skills should be able to be taught. If you can't do that, address that first before hiring anybody if possible.
stop keyword scanning your job applications. It is resulting in a massive race toward the middle where people are just trying to get past automated systems, and it makes their resumes harder for humans to parse. Many current systems encourage this.
don't ghost people. There are like 100 ways to track that stuff and ensure it doesn't happen. Automated responses are better than no response.
aim to provide value even to people you don't hire. This is most cheaply accomplished by committing to providing feedback. It helps the candidate in their next steps and costs nothing but a small polish on the notes you probably already took. They have take the time to invest in you and have taken a chance. Don't let them walk away with nothing. (This is also a good way to get candidates to refer other people by word of mouth. People talk about this stuff, and they remember how your experience made them feel.)

 It's easy for a hiring manager to spot, and it probably doesn't feel good. You have enough to offer.
have a resume for "gamified" responses (where you're trying to get past keyword gateways) and one for situations that aren't that. The two are incompatible. When I read a resume that is clearly engineered for that, it's very hard to trust it and assess what the candidate might be good at. A wall of buzzwords works against you in those situations.
try to focus on accomplishments. A position that has 15 bullet points and one of them is "attended daily stand-ups" is going to work against you.

I added some other thoughts here that I can work in: https://news.ycombinator.com/item?id=39001583

I covered enough of this in the other posts that I don't think this one stands on its own anymore.


Upgrade Invisor Lite.app to v3.6

Merged as 6c04d04e06dfcc2b8cad5074834ace1a9b2fc4c0.

Thank you for the contribution. It was merged directly as 4b98424df0e10a4dd8ab74b9ad6b6c9ec9b7e802 to keep commit history cleaner. Your contribution is still credited to you.


Avoid running CI tests when it is not necessary

In kubevirt/kubevirt we have a pretty massive CI system.
Currently, the CI system executes many tests on each PR, even in cases when it is not necessary. For example, when changing:

Comments
Non-code files (e.g. .md files)
A commit message

Our CI often suffers from being overloaded, causing lanes to be flakie and hurts our overall project.
IMHO, we should find a way to avoid running CI, or at least reduce the number of lanes that are being run in unnecessary scenarios.

/cc @EdDev @dhiller @brianmcarey

/remove-lifecycle stale

/remove-lifecycle stale

/lifecycle frozen

There is a need to define some goals to this issue, otherwise it becomes hard to threat it.
Latest work done in this direction encountered resistance here.
To raise awareness and start a deeper discussion on this matter, perhaps a design proposal can be started, describing there all options with possible PoC and work plans.

Please see https://kubernetes.slack.com/archives/CDECRSC5U/p1689496532563759
I think we can save precious time meanwhile with MVP, personally i am not interested to dedicate time extending the plugins, it is not our core business logic, and prone for weird corner cases as the link says.

I think the concrete suggestion presented is good enough to be accepted.
The do not understand the resistance to it, especially when there is nothing else concrete to offer.
Having a design & discussion is always better, but I recognize it is not always easy and in a priority.

Looking at https://kubernetes.slack.com/archives/CDECRSC5U/p1689496532563759, seems that they recommended using run_if_changed and skip_if_only_changed combination to avoid running CI when only non-code files change. IIUC, @oshoval's current solution only addresses the non-code file changes scenario, so why not take their suggestion and implement in with prow settings? This is also what @dhiller suggested in his comment.
What I want to understand is how difficult would it be to implement it in the right way. Temporary workarounds (which are by definition a technical debt) are sometimes acceptable, but there's a need for a strong justification in order to use them, and to know when and how they can be removed in the future.
@dhiller @brianmcarey would you be able to look into this again and try to think about the necessary steps / sub-tasks in order to get this working the right way? Once we know exactly what needs to be done it would be easier to asses how difficult it would be. I'd say that a temporary workaround is acceptable only if we see that the steps forward are either not possible at the moment or would demand too much effort that no one can invest now. On the other hand, if this is not a huge effort to invest and can be done in a reasonable amount of time, I'd say that a temporary workaround won't be worth it.
After you're done, I can add a check-list of the things need to be done to this issue.
Also, if you find it complicated enough, we can start a design proposal, although I'm not sure that's necessary.

Looking at https://kubernetes.slack.com/archives/CDECRSC5U/p1689496532563759, seems that they recommended using run_if_changed and skip_if_only_changed combination to avoid running CI when only non-code files change. IIUC, @oshoval's current solution only addresses the non-code file changes scenario, so why not take their suggestion and implement in with prow settings? This is also what @dhiller suggested in his comment.

Because one would need to add it in each and every job, and for each change need to update them all.
It also depends on the current label that do exists etc (but we might covered this issue already on the linked PR).

What I want to understand is how difficult would it be to implement it in the right way. Temporary workarounds (which are by definition a technical debt) are sometimes acceptable, but there's a need for a strong justification in order to use them, and to know when and how they can be removed in the future.

Right but on the other hand a MVP that saves time meanwhile, when the good solution might take months (or even if it wont take months), is totally fine to have, and the right thing to do imho.

Looking at https://kubernetes.slack.com/archives/CDECRSC5U/p1689496532563759, seems that they recommended using run_if_changed and skip_if_only_changed combination to avoid running CI when only non-code files change. IIUC, @oshoval's current solution only addresses the non-code file changes scenario, so why not take their suggestion and implement in with prow settings? This is also what @dhiller suggested in his comment.

Because one would need to add it in each and every job, and for each change need to update them all. It also depends on the current label that do exists etc (but we might covered this issue already on the linked PR).

Perhaps there's a way to re-use the same rule for many jobs?

What I want to understand is how difficult would it be to implement it in the right way. Temporary workarounds (which are by definition a technical debt) are sometimes acceptable, but there's a need for a strong justification in order to use them, and to know when and how they can be removed in the future.

Right but on the other hand a MVP that saves time meanwhile, when the good solution might take months (or even if it wont take months), is totally fine to have, and the right thing to do imho. Moreover it is such small change that can be removed easily which worth to consider.

If this effort would really be that big, then it's very reasonable to consider a temporary workaround IMO.
As said before, I think that the first thing needs to be done is to asses which tasks need to be done and how much effort they demand.

Looking at https://kubernetes.slack.com/archives/CDECRSC5U/p1689496532563759, seems that they recommended using run_if_changed and skip_if_only_changed combination to avoid running CI when only non-code files change. IIUC, @oshoval's current solution only addresses the non-code file changes scenario, so why not take their suggestion and implement in with prow settings? This is also what @dhiller suggested in his comment.

Because one would need to add it in each and every job, and for each change need to update them all. It also depends on the current label that do exists etc (but we might covered this issue already on the linked PR).

Perhaps there's a way to re-use the same rule for many jobs?

maybe, anchor and preset remind this, not sure but by heart if there is already something suitable for it

What I want to understand is how difficult would it be to implement it in the right way. Temporary workarounds (which are by definition a technical debt) are sometimes acceptable, but there's a need for a strong justification in order to use them, and to know when and how they can be removed in the future.

Right but on the other hand a MVP that saves time meanwhile, when the good solution might take months (or even if it wont take months), is totally fine to have, and the right thing to do imho. Moreover it is such small change that can be removed easily which worth to consider.

If this effort would really be that big, then it's very reasonable to consider a temporary workaround IMO. As said before, I think that the first thing needs to be done is to asses which tasks need to be done and how much effort they demand.

Right, but i see it in other way, this issue is from January, and the design can take time,
either because people are busy or it is deep, and there are such cases where we put tech-debt as priority and forget about MVP, when it is not the right thing to do, and this is one of those cases imho.
If we encourage in some situations a MVP when the signal to noise worth it we can save hours.
But now all is said already from our both sides, this is my 2 cents.

Looking at https://kubernetes.slack.com/archives/CDECRSC5U/p1689496532563759, seems that they recommended using run_if_changed and skip_if_only_changed combination to avoid running CI when only non-code files change. IIUC, @oshoval's current solution only addresses the non-code file changes scenario, so why not take their suggestion and implement in with prow settings? This is also what @dhiller suggested in his comment.

Because it does not work for required jobs.
We are basically going no-where with this.
The members who invested in this have come out with this solution, no one else could find a better solution or did not have time to invest in this further.
Either way, if no one volunteers to work on it now, please focus on what is available now.
It is fine to nack a solution, but it needs to have a good reasoning.
The reasoning I saw until now are focus on finding something better, but as said before, no one found anything else and no one is actively working on it.

Since I see that indeed no one can come up with better solutions, I'm OK with getting this in.
However, please @oshoval create an issue to track the missing parts and to remind us to keep investigating this in the future.
@lyarwood @dhiller @brianmcarey - any objections?

There is this issue, we can just update the PR desc with the ref to the PR on the specific bullet
wdyt ?

i meant the issue (but i will update the PR)
can you please update the issue with ref to the PR for the specific bullet ? only you have edit permissions

i meant the issue (but i will update the PR) can you please update the issue with ref to the PR for the specific bullet ? only you have edit permissions

Sure. I will update the issue if there are no objections

Referring to this comment
@brianmcarey and me would like to investigate changing tide configuration so that we can leverage skip_if_only_changed which is exactly what we want.
But for this we do need to research and test, this will take a bit of time.
As stated in the above comment, I think the PR is not worth merging since it currently adds a burden to all PRs while saving only on an estimated 1/20 PRs.

Referring to this comment @brianmcarey and me would like to investigate changing tide configuration so that we can leverage skip_if_only_changed which is exactly what we want.
But for this we do need to research and test, this will take a bit of time.
As stated in the above comment, I think the PR is not worth merging since it currently adds a burden to all PRs while saving only on an estimated 1/20 PRs.

about the burden, i think i can remove the git fetch
https://github.com/kubevirt/kubevirt/pull/10019/files#r1266720195
if this what will make this PR be merged please let me know
ref https://github.com/kubevirt/kubevirt/pull/10019#issuecomment-1669382138

@iholder101 I believe we can close this issue since this was merged - https://github.com/kubevirt/kubevirt/pull/11147

/close


Docs: Link to old version

New website looks nice!
The script tag on https://iconify.design/docs/icon-components/svg-framework/#usage links to old version 2.0.0
Please fix, thanks!

Thanks a lot for noticing!
Fixed.


[T2A2][W15-A2] Wang Ce

Ready for review

Ready for review

Some comments added. Feel free to add more comment if you have any questions. Once you are done, you may close the PR after reading comments.


R53 soa fix

Fixes #1018 .
Also fixes a configuration merge bug now that access-key and secret-key are optional fields, this is non breaking since no one has x/x for their key/secret

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.slandry seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Liveries were "pushed back"

Hello @kolos26
I have a sort of bug report to make.
Liveries on the 787-9 (didn't check the 787-10, but it might be concerned as well) and some liveries on the A320neo (the regular Lufthansa being one) appeared to have been slightly pushed back, as there now is a white stripe appearing on the from of Vertical stabiliser. I don't know if you can fix this yourself, but please focus on the 787-9 as it concerns most liveries (I do think all liveries have been pushed back, but some which are based on white, like Air France are obviously not as affected)
Thanks in advance, as I know you are very committed and reactive.
Sincerely,
Charlie Delta

Thank you for searching bugs in the program! I have taken a look on those liveries, and those small grey stuff is the basically part of the deicing sytsem on the real plane, so we don't need to do anything with that just enjoying it. :)


uncovered code - possible bug

class Foo {
  a: string;
  constructor(a: string) {
    this.a = a;
  }
}

const ok = new Foo('a'); // ok

class Bar {
  async useFoo(f: Foo) {
    return this;
  }
}

const notOk = new Foo('a'); // expression on the right-hand-side is uncovered

Note that the above code compiles properly. My question is why the second occurrence of new Foo('a') is uncovered in flow (v0.89.0)? Seems like a bug?
Interestingly, the following changes all turn "uncovered" -> covered:
• remove async keyword in Bar
• remove the function params f: Foo in Bar
• replace return this with return in Bar
Can anyone shed light into what's going on here?

I've simplified the repro a little bit:
// @flow

class FakePromise<T> {}
declare function resolve<T>(object: FakePromise<T> | T): FakePromise<T>;

class Foo {
  constructor() {
  }
}

class Bar {
  useFoo(f: Foo): void {
  }
}

resolve(new Bar());

(new Foo(): number); // Should error

This should issue an error, but as far back as Flow v0.37 (the earliest in try) there is no error.

Still simpler:
// @flow

class Foo {
  constructor() {
  }
}

type Bar = {
  useFoo(f: Foo): void
};

({}: Bar | {});

(new Foo(): number);

Unsealed object?

No, it has to do with how unions are typechecked


errors while connecting to folio producer

When we want to publish a folio we get this error:
Notice: Undefined index: ticket in /home/ahusjxrt/htdocs/blog/wp-content/plugins/folio-author-plugin-for-wordpress/libs/folio-producer-api/app/DPSFolioProducer/Config.php on line 94 {"code":0,"message":"
general

Could not create a new folio
"}
When we want to clear the DPS Session, we get this error:
Notice: Undefined variable: _SESSION in /home/ahusjxrt/htdocs/blog/wp-content/plugins/folio-author-plugin-for-wordpress/classes/dpsfa-ajax.php on line 167 {"code":1}

Notice: Undefined variable: _SESSION in /home/ahusjxrt/htdocs/blog/wp-content/plugins/folio-author-plugin-for-wordpress/classes/dpsfa-ajax.php on line 167 {"code":1}
Fix for me with add in :: session_start(); or like this
<?php session_start();
/**
 *
 * Digital Publishing Suite Folio Authoring Plugin
 * Class : FOLIO
 *
 */
==================
Notice: Undefined index: ticket in /Applications/XAMPP/xamppfiles/htdocs/wpdps/wp-content/plugins/folio-author-plugin-for-wordpress/libs/folio-producer-api/app/DPSFolioProducer/Config.php on line 94 still wait for fix :)

Notice: Undefined variable: _SESSION in /home/ahusjxrt/htdocs/blog/wp-content/plugins/folio-author-plugin-for-wordpress/classes/dpsfa-ajax.php on line 167 {"code":1}
Fix for me with add in :: session_start(); or like this
<?php session_start();
/**
 *
 * Digital Publishing Suite Folio Authoring Plugin
 * Class : FOLIO
 *
 */
==================
Notice: Undefined index: ticket in /Applications/XAMPP/xamppfiles/htdocs/wpdps/wp-content/plugins/folio-author-plugin-for-wordpress/libs/folio-producer-api/app/DPSFolioProducer/Config.php on line 94 still wait for fix :)


Small closure as middle argument is pretty ugly

Here's a snippet formatted per version 0.3:
        if condition1 {
            if condition2 {
                let mut bar = left.extract(|_| Right,
                                           |foo| {
                                               if condition3 {
                                                   stmt;
                                               }
                                           },
                                           &mut x);
            }
        }

And now, as per version 0.5, it is formatted as:
        if condition1 {
            if condition2 {
                let mut bar = left.extract(|_| Right,
                                           |foo| {
                    if condition3 {
                        stmt;
                    }
                },
                                           &mut x);
            }
        }

which looks not so pretty to me.
Was there any specific reason in avoiding a line-break after an open parenthesis even if it occurred much to the right? Like this:
        if condition1 {
            if condition2 {
                let mut bar = left.extract(
                    |_| Right,
                    |foo| {
                        if condition3 {
                            stmt;
                        }
                    },
                    &mut x);
            }
        }

The line break after the opening paren is block formatting of the arguments - you can do this by setting fn_args_layout to Block. I prefer visual indenting and it is more common which is why it is currently the default (pretty subjective). I agree that the example here could do with some polishing.

In 0.8.3, the above code is formatted as follows:
fn foo() {
    if condition1 {
        if condition2 {
            let mut bar = left.extract(|_| Right,
                                       |foo| if condition3 {
                                           stmt;
                                       },
                                       &mut x);
        }
    }
}


Making ContextAwareMeter public

Trivial change to make ContextAwareMeter public.
@abti can you review?

LGTM

Coverage increased (+0.04%) to 48.889% when pulling e4eb3c4e2a238743a1f6d25f2ff3f4da0ccb8b48 on chavdar:metrics_access into 816c16e922c46084dcb3b64466866b22bbb27aaa on linkedin:master.


Output warnings and errors from webpack individually

Shows warnings even when resolving, to facilitate hints set to 'warning'
Fixes #876 : Set performance.hints to 'warning' or 'error' in next.config.js

Do you have a screenshot for this? Curious how it looks.

Sure.
Warning mode:

Error mode:


Slow restore

Output of restic version
restic 0.8.1
compiled with go1.9.2 on linux/amd64
How did you run restic exactly?
./restic -o b2.connections=100 restore --target /mnt/path SNAPSHOT_ID
What backend/server/service did you use to store the repository?
Backblaze B2
Expected behavior
Restore more than one file at a time.  Maybe take advantage of the -o b2.connections= option?
Actual behavior
Only one file is being restored at a time - resulting in terrible throughput (about 32KB a second of IO being measured).  This box has a gigabit internet link and I'm stuck restoring at nearly dialup speeds.  Large files aren't an issue.
root@nas1:~# ps aux | grep rest
root     27197 16.1  6.8<PHONE_NUMBER>44 pts/4   Sl+  07:52  57:38 ./restic -o b2.connections=100 restore --target /mnt/path SNAPSHOT_ID
ls -l /proc/27197/fd
total 0
lrwx------ 1 root root 64 Feb  6 13:33 0 -> /dev/pts/4
lrwx------ 1 root root 64 Feb  6 13:33 1 -> /dev/pts/4
lrwx------ 1 root root 64 Feb  6 13:33 2 -> /dev/pts/4
l-wx------ 1 root root 64 Feb  6 13:33 3 -> /mnt/path/archive/iMac 2014ish/user/Desktop/untitled folder 2/X-Plane 10 Demo/Resources/default scenery/1000 world terrain/terrain10/._red_grass_wrm_sdry_fl_md.ter
lrwx------ 1 root root 64 Feb  6 13:33 4 -> anon_inode:[eventpoll]
lrwx------ 1 root root 64 Feb  6 13:33 5 -> socket:[580367]

Steps to reproduce the behavior?
Attempt to do a restore from B2.
Do you have any idea what may have caused this?
Perhaps this is expected behavior - however if so that should be mentioned in the documentation.
Do you have an idea how to solve the issue?
Not familiar enough with Restic.
Did restic help you or made you happy in any way?
It's been great - except for the inability to restore in a reasonable amount of time given substantial bandwidth.

have the same issue with s3 backend. It does not use the connections:
root@c4293c39beed:/# netstat -an
Active Internet connections (servers and established)
Proto Recv-Q Send-Q Local Address           Foreign Address         State
tcp        0      0 <IP_ADDRESS>:53966        <IP_ADDRESS>:443      TIME_WAIT
tcp        0      0 <IP_ADDRESS>:60878        <IP_ADDRESS>:443        TIME_WAIT
tcp        0      0 <IP_ADDRESS>:54922        <IP_ADDRESS>:443       TIME_WAIT
tcp        0      0 <IP_ADDRESS>:56300        <IP_ADDRESS>:443        TIME_WAIT
tcp        0      0 <IP_ADDRESS>:42550        <IP_ADDRESS>:443        ESTABLISHED
tcp        0      0 <IP_ADDRESS>:53968        <IP_ADDRESS>:443      TIME_WAIT
tcp        0      0 <IP_ADDRESS>:54920        <IP_ADDRESS>:443       TIME_WAIT
tcp        0      0 <IP_ADDRESS>:43272        <IP_ADDRESS>:443        TIME_WAIT

You can run this over and over again, same amount of connections, all in wait state.

Looks like restic neither collates blob requests nor it caches downloaded blobs. So if restore needs 5 blobs from a pack, each blob will be downloaded separately. And if multiple restored files use a blob, the blob will be downloaded multiple times. This is likely a major contributor to overall restore time, especially for backups with many small files.
I suspect that in many/most cases it'll be more efficient to download and cache complete packs during restore. Which I believe implies restic will need to manage how much disk space is used by data pack cache, which in turn will require significant rework of restore implementation. @fd0 if you are interested, I can elaborate this idea. I can also work on the implementation if we agree on the design.

Oh, this is a very good point, thanks for elaborating @ifedorenko! I'd love to see a design proposal, and even an implementation. But before we can do that, I think we need to review and maybe merge #1371. If you have the time, could you maybe have a look at that?

I am traveling right now, but plan to propose proof-of-concept implementation of my idea when I get back in couple of weeks. At this point I do not believe #1371 will be useful for what I want to do, but I'll keep it in mind.
For the record, I did try #1371 when I looked at hubic support few month ago and it only provided marginal improvement over the current implementation and was way slower than straight multi-threaded copy of repository files followed by restore from local copy.

#1719 drastically reduces number of backend requests and runs multiple backend requests concurrently. I expect it to perform significantly better with any backend.
Having said that, I only tested it with local and onedrive, so I'd be curious to know how to behaves with other backends. ;-)

It this #1719 working on 0.8.3 version of restic?
regards!

Not quite sure I understand the question. #1719 has not been merged yet. It is based on master but you will have to build it yourself to try it.


Remove goerli

Goerli will be removed on 11th April. We should work towards removing tests etc depending on it.

Hi, can you throw more light on the context so i can consider working on it.

Hi @vibenedict , this one should be done in two parts - first is to make devnet to introduce itself as sepolia instead of goerli, and make sure all tests work (some files, like accounts file will have to be updated with sepolia prefunded accounts, goerli ones should be deleted). Second is to go through the code and remove/change all references to goerli (eg script init uses a contract deployed to goerli testnet, docs should be updated etc)

As part of this task, let's also update the default OZ_CLASS_HASH to a newer version that supports V3 transactions. This updated version should be deployed to both Mainnet and Sepolia. One option is 0x061dac032f228abef9c6626f995015233097ae253a7f72d68552db02f2971b8f from the OpenZepellin documentation.


Puppetise the data scrubber

Add a single-class Puppet module that installs the data scrubber and configures a cron job.
I've set the cron job to run at 20:00 daily but this is open to discussion.
It's configured to run on AWS staging and prod, nowhere else.
Note - this will need the package to have been built and published to Aptly before this code can apply cleanly.

:')
/var/lib/jenkins/workspace/govuk-puppet_data-scrubber-TFLG53RY6ERZ7TEPWGFT5PAH7U3SLEZ4MJTJKVKXS754BRS2ZSNA/lib/tasks/lint.rake:27:in `block in <top (required)>' Tasks: TOP => lint (See full trace by running task with --trace) modules/govuk_datascrubber/manifests/init.pp - ERROR: Non-ASCII character found in comment on line 13 modules/govuk_datascrubber/manifests/init.pp - ERROR: Non-ASCII character found in comment on line 17 modules/govuk_datascrubber/manifests/init.pp - ERROR: Non-ASCII character found in comment on line 24 modules/govuk_datascrubber/manifests/init.pp - ERROR: Non-ASCII character found in comment on line 26 modules/govuk_datascrubber/manifests/init.pp - ERROR: Non-ASCII character found in comment on line 29 modules/govuk_datascrubber/manifests/init.pp - ERROR: Non-ASCII character found in comment on line 31

Something's wonky with my vim config.. this isn't the first time I've seen this.


Print original exception in debug mode.

Sanic is collecting the information of original exceptions but does not print it on console. Because it is very useful to debug user code, it is better to be printed in debug mode.

So to be clear this is just for when error handlers error out correct?

Nevermind, gonna close this. I think I may have a better way of doing this, will link it to this PR.


Fix My http provider readme.md

Close this one, Its incorrenct
It causes the http instance in Local.ts to be the new class you created.
This can cause an error when doing something like this:
class MyHttp extends JwtHttp {
   ctor....{}

   request(...){
      ...
      return super.request(..).map(res=>res.json())

   }
}

This causes response.json() is undefinned in setToken.


GH-1106: Multiple values passed to WithProperty are overridden

Changed MSBuildExtension's WithProperty to forward multiple parameters as a comma separated list surrounded by quotes. Single parameter behavior is unchanged to before and does not have the added quotes.
This should fix https://github.com/cake-build/cake/issues/1106. Check the comments there for more details.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: Caopi sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Hey Pascal, sorry for the late reply as well. I've quickly accepted your suggestion of course, but I would prefer if someone else could take over the integration test part. Haven't worked with C# and Cake in a while nowadays and don't have a lot of time to commit to this right now, sorry!


Emission updates and new routes #trivial

Updates Emission. Follow-up to #2796 for new routes. Also includes Pulley change for LD-398. Merge on green.

This is already been queued for deploy.

merge on green


Create the reply to answer mechanism

child of #213
child of #258
On a thread, when you click on the reply button from an answer, it open the editor to reply to the selected answer. On save the reply is saved to the database and UI updated with the reply.
Mockups :

@sri is working on this 🙌

So the database side of this is actually a bit complex. Would suggest @sri reaches out if working on it. I've added a discussion view page which can work as a base for this (currently just rendering a single list of replies without nesting, but can be built on)

quick discussion had with sri on slack, hopefully good to move forward on this

@sri is working on this 🙌

Apologies to the real @sri , the Sri in our repo should be referred to as @vatsan28
(@mattia-io )

Oh 💩

I think this was implemented with the creation of the backend for post by tx4x, right ? @chrismclarke
Did you start working on it @vatsan28 ?

I created a placeholder to get started with so perhaps let us know if you have got stuck @vatsan28 , or if you have been unable to find time then what your current estimated timeline is

Closing for now, will repopen when needed.


Responsive issues

On my Mac, if I open the DevTools (docked on the right), the state options dropdowns are off the screen even on 1196px width.
To see it properly I need to scroll to the right.

resolved in resolved in 6ecbb75c8e6688887db4b184f2597eb44a940208


WIP speed up topomap tests

Because topomap calls are a major aspect of our tests, this is essentially trying to pass {"res": 8, "contours": 0, "sensors": False} to as many topomap calls as possible.
The bad companion to #4224

Funny: plot_ica_components so far ignored the sensors parameter.

Codecov Report

Merging #4225 into master will decrease coverage by 0.31%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4225      +/-   ##
==========================================
- Coverage   86.23%   85.91%   -0.32%
==========================================
  Files         357      357
  Lines       64558    64566       +8
  Branches     9831     9831
==========================================
- Hits        55673    55474     -199
- Misses       6182     6391     +209
+ Partials     2703     2701       -2

It seems this saves up to 1, 2 minutes of Travis time on master:

Test topomap plotting
25.7881s -> 16.0637s
Test plotting of TFR data
117.6091s -> 22.0626s
Test plotting of ICA properties
8.1129s -> 7.4440s
Test plotting of ICA solutions
4.7509s -> 4.4379s
Test plotting of ERP topography.
10.2711s -> 8.5802s

Reviews please? :)

LGTM. Merge if you're done @jona-sassenhagen

Thanks guys!

Was the squash ok ..?

We nowadays always do squash+merge via GitHub UI, if that's what you're asking


Minor fixes

GNU Awk 5.1.0 complains about the \% sequence because % is not a metacharacter.

Thanks! :shipit:


ERROR: (gcloud.app.deploy) Error Response: [4] Timed out waiting for the flex deployment to become network provisioned.

When I deployed my java application to appengine using command mvn gcloud:deploy I got error message which indicate that m deployment is failure. There is the message error I got.
[INFO] ERROR: (gcloud.app.deploy) Error Response: [4] Timed out waiting for the flex deployment to become network provisioned. [ERROR] Error: gcloud app command with exit code : 1 [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 27:33 min [INFO] Finished at: 2018-03-06T19:16:02+07:00 [INFO] Final Memory: 26M/238M [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal com.google.appengine:gcloud-maven-plugin:<IP_ADDRESS>.v20161104:deploy (default-cli) on project kofera-builder-adwords-worker: Error: gcloud app command exit code is: 1 -> [Help 1] [ERROR]  [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR]  [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

Was this ever resolved @zakariandys ?

@meltsufin ? Is this a timeout thing on the flex images?

No, it's more likely the timeout in the Cloud Build or the actual App Engine Flex infrastructure.

the problem is solved. Main issue on healthchecker, when deployment app engine flex return bad request.

@zakariandys How did you solve it? Was it just a matter of time?

@JCarlosR no, it was my mistake to configure the health checker

@zakariandys How did you configure health checker? Through liveness check or readiness check in app.yaml?


Phantom users to enroll

Start from a fresh install
Create three disciplines
Visit /disciplines/1

In "Enroll someone", there are three "null null".

Fixed in 46bf808ce6baa0c73e4137ec8de736eee7e712bd


More cpu usage / throttling after switching to from scratch

for a ruby example app that we converted we saw cpu and throttling jump pretty bad (it's not a big deal since it's still super small), but some guidance on why this might happen and how to avoid it would be great for onboarding apps where performance actually matters.

I tried to reproduce this using minimal Sinatra HTTP server but I couldn't find any significant difference.
https://gist.github.com/coord-e/cf89553d0f5f3078720db14432ac857a

@grosser Could you give me some more details about the situation so that I can reproduce this on my end? What kind of application are you running?

this is from a stats app that does lots of small things, so tried each individually by making it do 100 iterations in a loop

computation heavy (PodHealth): same
network heavy (PodNetworkError): same
aws api heavy (MissingAmiReporter): same
connecting to internal app (VaultReachability): same
... so maybe this is just some reporting foobar 🤷

idk where to go from here ... maybe someone who knows more about how container metrics are reported can chime in ...


Add HTML code in paginate-link

Please, add "innerHTML" in getSimpleLinks function
Thank you:)

I created a PR for this. See #92
But I used slots instead of props.


Sluggish Draw

While not much of a problem there is a downside to the super compact drawing methods here, namely sluggish draw. The memory allocated to the giant list of floats[] in the single datapoints object. While this is tight in memory for a lot of stuff, when it's sent to the GPU for drawing it sends the entire batch of memory. This causes devices to become slightly sluggish during heavy redraws with many layers. As to draw 25 different layers with different colors etc, it sends that same block of memory to the GPU 25 times. Even for the parts that aren't being drawn.
This could be corrected rather notably by having the stitch blocks actually make their own copy of the relevant memory, of exactly the correct size. Or even expanding it the segments that drawLines() really wants. And merge those together when they will be sent with the same Paint object.
If you think it's too much of an issue, it's rather easily corrected at the cost of some memory.
Further inserting particular elements within the array will require a pretty hefty arraycopy, especially if it's not setup for bulk processing. For example my routine to split segments that are too long only copies once, but doing the preprocessing, then iterating backwards moving everything into the correct positions in a single pass. The correctForMaxStitchLength() function in the EmbPattern will do repeated inserts over the entire list.

The speedup class would be something akin to:
public class EmbPatternQuickView {
    EmbPattern pattern;
    ArrayList<BlockDraw> drawers = new ArrayList<>();
    float minX = Float.POSITIVE_INFINITY;
    float minY = Float.POSITIVE_INFINITY;
    float maxX = Float.NEGATIVE_INFINITY;
    float maxY = Float.NEGATIVE_INFINITY;

    public EmbPatternQuickView(EmbPattern pattern) {
        this.pattern = pattern;
        BlockDraw draw = null;
        EmbThread lastThread = null;

        for (EmbObject sb : pattern.asStitchEmbObjects()) {
            EmbThread currentThread = sb.getThread();
            if (lastThread != currentThread) {
                draw = new BlockDraw();
                draw.paint.setColor(currentThread.getOpaqueColor());
                drawers.add(draw);
                lastThread = currentThread;
            }
            if (draw == null) continue;
            draw.addAsSegments(sb.getPoints());
        }
    }

    public void draw(Canvas canvas) {
        for (BlockDraw blockDraw : drawers) {
            canvas.drawLines(blockDraw.list.pointlist, 0, blockDraw.list.count, blockDraw.paint);
        }
    }

    public Bitmap squareThumbnail(int thumbDim) {
        float width = maxX - minX;
        float height = maxY - minY;

        if (width == 0) width = 10;
        if (height == 0) height = 10;
        float scaleX = thumbDim / (width);
        float scaleY = thumbDim / (height);
        float scale = Math.min(scaleY, scaleX);
        float cx = minX + (width / 2);
        float cy = minY + (height / 2);

        Bitmap thumb = Bitmap.createBitmap(thumbDim, thumbDim, Bitmap.Config.ARGB_4444);
        Canvas canvas = new Canvas(thumb);
        canvas.translate(thumb.getWidth() / 2, thumb.getHeight() / 2);
        canvas.scale(scale, scale);
        canvas.translate(-cx, -cy);
        draw(canvas);
        return thumb;
    }

    private class BlockDraw {
        public PointsDirect list = new PointsDirect();
        public Paint paint = new Paint();

        public void addAsSegments(Points points) {
            int count = list.count;
            if (points.size() < 2) return;
            int addingcount = (((points.size() * 2) - 4) * 2) + 4;
            list.ensureCapacity(count + addingcount);
            float x = points.getX(0);
            float y = points.getY(0);
            list.add(x,y);
            int k = 1;
            for (int s = points.size() - 1; k < s; k++) {
                x = points.getX(k);
                y = points.getY(k);
                if (points.getData(k) != EmbPattern.STITCH) {
                    Log.e("", "Fail " + points.getPoint(k));
                }
                list.add(x,y);
                list.add(x,y);
            }
            x = points.getX(k);
            y = points.getY(k);
            list.add(x,y);
            if (list.getMaxX() > maxX) maxX = list.getMaxX();
            if (list.getMinX() < minX) minX = list.getMinX();
            if (list.getMaxY() > maxY) maxY = list.getMaxY();
            if (list.getMinY() < minY) minY = list.getMinY();
        }

    }
}

Basically it stores everything as segments that can be sent to the GPU in a single command and only shifts this when the colors change and it needs to be sent to the GPU with a different paint object.

This is fixed by #86 which includes a specific method to speed this stuff up for display purposes. Slicing out the relevant bits of points into a format allowing for the fastest display. Rather than sending the entire float-list to memory for each call.


esp32 not build error in ota

Hi i go in /amazon-freertos/demos/espressif/esp32_devkitc_esp_wrover_kit/make/
and run make
the result are
/home/simon/Sync/hepia/AWS/amazon-freertos/lib/ota/portable/espressif/esp32_devkitc_esp_wrover_kit/aws_esp_ota_ops.c: In function 'aws_esp_ota_write':
/home/simon/Sync/hepia/AWS/amazon-freertos/lib/ota/portable/espressif/esp32_devkitc_esp_wrover_kit/aws_esp_ota_ops.c:162:5: error: expected ';' before 'return'
return ESP_ERR_INVALID_ARG;
^
/home/simon/Sync/hepia/AWS/amazon-freertos/lib/ota/portable/espressif/esp32_devkitc_esp_wrover_kit/aws_esp_ota_ops.c: In function 'rewrite_ota_seq':
/home/simon/Sync/hepia/AWS/amazon-freertos/lib/ota/portable/espressif/esp32_devkitc_esp_wrover_kit/aws_esp_ota_ops.c:220:42: error: 'ESP_OTA_IMG_NEW' undeclared (first use in this function)
s_ota_select[sec_id].ota_flags = ESP_OTA_IMG_NEW;
^
/home/simon/Sync/hepia/AWS/amazon-freertos/lib/ota/portable/espressif/esp32_devkitc_esp_wrover_kit/aws_esp_ota_ops.c:220:42: note: each undeclared identifier is reported only once for each function it appears in
/home/simon/Sync/hepia/AWS/amazon-freertos/lib/ota/portable/espressif/esp32_devkitc_esp_wrover_kit/aws_esp_ota_ops.c: In function '_esp_get_otadata_partition':
/home/simon/Sync/hepia/AWS/amazon-freertos/lib/ota/portable/espressif/esp32_devkitc_esp_wrover_kit/aws_esp_ota_ops.c:437:9: error: expected ';' before '}' token
}
^
/home/simon/Sync/hepia/AWS/amazon-freertos/lib/ota/portable/espressif/esp32_devkitc_esp_wrover_kit/aws_esp_ota_ops.c:438:7: error: expected '}' before 'else'
} else {
^
/home/simon/Sync/hepia/AWS/amazon-freertos/lib/ota/portable/espressif/esp32_devkitc_esp_wrover_kit/aws_esp_ota_ops.c: In function 'aws_esp_ota_get_boot_flags':
/home/simon/Sync/hepia/AWS/amazon-freertos/lib/ota/portable/espressif/esp32_devkitc_esp_wrover_kit/aws_esp_ota_ops.c:471:14: error: 'ESP_OTA_IMG_INVALID' undeclared (first use in this function)
*flags = ESP_OTA_IMG_INVALID;
^
/home/simon/Sync/hepia/AWS/amazon-freertos/lib/ota/portable/espressif/esp32_devkitc_esp_wrover_kit/aws_esp_ota_ops.c: In function 'aws_esp_ota_write':
/home/simon/Sync/hepia/AWS/amazon-freertos/lib/ota/portable/espressif/esp32_devkitc_esp_wrover_kit/aws_esp_ota_ops.c:163:1: error: control reaches end of non-void function [-Werror=return-type]
Can you fix it?

Hi,
Are you using the IDF that comes with the Amazon FreeRTOS download?   Build errors can occur if the Espressif IDF library is installed or if the IDF_PATH variable has been set.   Also, have any of the library files been modified?
I am not able to reproduce this build error in the OTA demo project on either Linux or Mac (I am building from 31da71acc on master and have only changed which demo is uncommented).
If you are still getting errors after confirming that the IDF_PATH is not set/the project is using the IDF in the Amazon FreeRTOS repository, please let me know about what operating system you are using and if you have made any modifications to the project.
Alexa

Realy thanks you  after remove IDF_PATH that compile
but is strange to have unused source file in your git.


Added 'trigger' method to key (could possibly be done also by calling key

Added 'trigger' method to key (could possibly be done also by calling key with only one argument).

Trigger method is what I am looking for right now. My use case is:
if I'm focused to CodeMirror's editor, it prevents all hotkeys and I need a method to call it by myself.


mld1/RouterState: Fix still alive thread

When using the sample of code :
import threading
from mld import InterfaceMLD

mld_if = InterfaceMLD(interface_name='enp2s0')

mld_if.enable()
print('%s %s' % (mld_if.interface_name, mld_if.is_enabled()))

try:
    while(True):
        input()
        print(threading.enumerate())
except KeyboardInterrupt:
    mld_if.remove()
    print('%s %s' % (mld_if.interface_name, mld_if.is_enabled()))

the program does not leave cleanly on KeyboardInterrupt and a second one is required  to kill the remaining thread causing the following error :
Exception ignored in: <module 'threading' from '/usr/lib/python3.7/threading.py'>
Traceback (most recent call last):
  File "/usr/lib/python3.7/threading.py", line 1281, in _shutdown
    t.join()
  File "/usr/lib/python3.7/threading.py", line 1032, in join
    self._wait_for_tstate_lock()
  File "/usr/lib/python3.7/threading.py", line 1048, in _wait_for_tstate_lock
    elif lock.acquire(block, timeout):
KeyboardInterrupt

Thank you for this fix @leoplo!
A similar fix needs to be implemented on my IGMP package (https://github.com/pedrofran12/igmp/blob/master/igmp/igmp2/RouterState.py).
If you want feel free to do a PR :)


Change sort command to take in arguments, trim arguments for add command

Sort will now take an argument for field and another for direction, ascending or descending

LGTM


Question regarding customisation and licensing

I have to start with the appreciation of this project. I absolutely find it useful, easier to understand and well architected. I have an application where I am using django-tenant-schemas. I also wanted to use django-q along with it.  Upon digging into the code base of django-q I found that I needed to make modifications in cluster, task to make it work as per my requirement. I have tried it and it works.
My concern is with any sort of licensing/infringement because what I have done is mostly write wrappers around the code or pick the same code make small modifications to it and get it working as per my needs.
I certainly hope it's all good even if I make my work available as python package as it might solve the need of people using django-tenant-schemas and wanting to use django-q to have a better control of their tasks and schedules.
I am also unsure if this is the best place to raise this issue but I don't have other option.

Hi Rajesh,
Happy to hear you find any of the code I wrote, all those years back,  useful. I wrote it under the MIT license which you can find here https://github.com/Koed00/django-q/blob/master/LICENSE .
So you can do with it what you want.
I would ask you however , if you think your modification can be optional through a setting and useful to other people, to submit the change to the code base.

Appreciate the quick response Ilan. I will explore on how to do it, if possible. But given that my requirement was very specific to my project I chose the easier path.
For now, I will keep my modifications separate and explore the possibility of doing it based on settings. Thank you very much.
Get Outlook for Androidhttps://aka.ms/ghei36

From: Ilan Steemers<EMAIL_ADDRESS>Sent: Monday, March 23, 2020 8:26:18 PM
To: Koed00/django-q<EMAIL_ADDRESS>Cc: Rajesh Yogeshwar<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [Koed00/django-q] Question regarding customisation and licensing (#425)
Hi Rajesh,
Happy to hear you find any of the code I wrote, all those years back, useful. I wrote it under the MIT license which you can find here https://github.com/Koed00/django-q/blob/master/LICENSE .
So you can do with it what you want.
I would ask you however , if you think your modification can be optional through a setting and useful to other people, to submit the change to the code base.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/Koed00/django-q/issues/425#issuecomment-602651230, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABXY6KSOEVH4DWIJ3NAVTELRI52BFANCNFSM4LR4THIQ.


When testing postal with an outlook client, we receive login prompt continiously

Hiya,
Postal seems to be correctly configured for us.
However, we still want to test it before relaying our emails through postal.
We are testing postal by relaying emails of one outlook client through postal.
When I am changing the outgoing server in outlook I keep receiving login prompts.
If I login with my own email credentials or with the admin credentials of postal, the login prompt keeps coming back.
Could you guys help me?
postal.txt

The username for the SMTP is not an email address, you will have to get the org\server reference from the UI but also note that Postal was not designed to work with a desktop email client so you may not have a great experience.

Well, we do not have a org\server reference from the ui. We only got our root user and an user whom logs in with an emailaddress.
(I understand that postal is not designed to work with desktop clients, but I want to test postal with a desktop client before using our mail server)
In addition, creating a mail server in the UI is very slow. If I wait for two hours, the server hasn't been created yet.

On the credentials page, there is a link to another page of details for how to connect.

There must have been a problem creating a mail server, it should be a fairly instant process. You will have to look at the log files in /opt/postal/logs

Thank you for your help. Our emails are now scanned through postal.
The issue with creating a new mailserver was that the permissions in mysql/mariadb were incorrect


[DOC-META] Create repository with different cluster security config examples

What do you want to do?
There are currently 2 zip files on the documentation website with examples for an LDAP authentication and authorization backend and one with a SAML authentication backend as well. See https://github.com/opensearch-project/documentation-website/tree/main/assets/examples
The example zips can be located on:

https://opensearch.org/docs/latest/security-plugin/configuration/ldap/
https://opensearch.org/docs/latest/security-plugin/configuration/saml/

Its been reported that the LDAP example is outdated and needs updating: https://github.com/opensearch-project/documentation-website/issues/905
There currently is no example for OpenID Connect and setup-related questions are commonly asked on the forum.
As a new maintainer for the security plugin, I have created different cluster configs for the different types of authentication backends to go through the same setup as new users of OpenSearch to understand the steps required to setup the backends and for debugging purposes.
See:

https://github.com/cwperks/osd-ldap-example (using OpenLDAP + PhpLDAPAdmin for UI on OpenLDAP)
https://github.com/cwperks/osd-saml-example (using SimpleSAMLPhp)
https://github.com/cwperks/osd-oidc-example (using keycloak)

Advantages:

Use git workflow to make updates to examples without having to unzip, re-zip and add the zip to a PR for the documentation-website
Use of git allows better version history of changes to the examples then the current zip files
Use github issues to track issues with the examples
Addition of an example for OpenID connect and possibly other cluster configs like multi-auth being introduced in 2.4.0

Disadvantages:

Another Repo to maintain in opensearch-project

@cwillum @davelago @dblock This is my first campaign issue filed. Any ideas on the suggestion above?

Sorry this has been neglected for so long. @davidlago , @scrawfor99 - do you think this is worth doing?

There is a sweet spot between how useful is to have examples and the cost of maintaining them. @cwperks do you have some data points around how F are these FAQs that would be answered by those examples?
I'm in support of creating an examples repo for security use cases, but being judicious with how many we put in there as we (someone) will have to keep them up to date.

I have started adding examples into the demos repo. Here's the ldap-example for a cluster running with OpenLDAP as an Identity provider. I think this is worth doing and as soon as more examples are added to the demos repo I think we can remove the zips on the documentation-website and instead maintain the demos repo.

Another example added: SAML demo (PR: https://github.com/opensearch-project/demos/pull/126)
In this example, an OpenSearch node, an OpenSearch Dashboards node, and a test SAML IdP server are spun up via docker with 1 default user shipped as part of the SAML auth realm. It is configurable, and ready to be tested.

Hi @cwperks, with the updated SAML example, do you want to test the existing sample, or should we remove it?

@AntonEliatra - Can you please respond to this comment so I can assign you to the issue? Thanks!

@hdhalter Please assign to me

@AntonEliatra , has everything in this issue been addressed? Thanks!

@hdhalter ldap, saml and oidc are available, I believe this was the requirement in this issue. In which case, yes, I believe this can be closed


Normalizing net_pkt hexdump

Ping @andrewboie are you ok with current version?

@andrewboie Ping, we need your approval in order to merge this one.


: Responsive Design and Content Overflow Issue #133

added Responsive Design and  solve Content Overflow Issue and make feature section responsive .
https://github.com/user-attachments/assets/904c2234-62e0-446a-92eb-df504031037d
Please assign this issue to me as I would like to work on fixing it. also add the label GSSoC 2024 Extd relaevant and lvl.

issue number is #133

@sanjay-kv and @MastanSayyad can you review this?

@Tejashri-Taral i have reduced the level.

@MastanSayyad sorry from my side.


Extension not working

I've recently encountered problem with Ekstraklasa extension. I've got this error message in output:
2024-06-28 17:16:30.762 [warning] TextEditor is closed/disposed
2024-06-28 17:16:37.700 [warning] TextEditor is closed/disposed
2024-06-28 17:17:33.811 [warning] TextEditor is closed/disposed
2024-06-28 17:17:34.914 [error] TypeError: Cannot read properties of null (reading 'map')
    at parseLastResults (/Users/alanguzek/.vscode/extensions/kraleppa.vscode-ekstraklasa-1.0.0/out/extension.js:104:24)
    at standingComponent (/Users/alanguzek/.vscode/extensions/kraleppa.vscode-ekstraklasa-1.0.0/out/extension.js:97:13)
    at /Users/alanguzek/.vscode/extensions/kraleppa.vscode-ekstraklasa-1.0.0/out/extension.js:75:40
    at Array.map (<anonymous>)
    at parseStandings (/Users/alanguzek/.vscode/extensions/kraleppa.vscode-ekstraklasa-1.0.0/out/extension.js:75:22)
    at getWebviewContent (/Users/alanguzek/.vscode/extensions/kraleppa.vscode-ekstraklasa-1.0.0/out/extension.js:68:13)
    at showView (/Users/alanguzek/.vscode/extensions/kraleppa.vscode-ekstraklasa-1.0.0/out/extension.js:41:26)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

and I have empty screen on my VSCode

Due to the ekstraklasa points reset at the end of the round, scraper adjustment was required - it was addressed within https://github.com/szarbartosz/ekstraklasa-scraper/commit/32729c084d7976899ee1151f7cd742bc1f0ef96b
Our favourite vs code extension works like a charm again! (It even contains the spoiler for the end of the next round - Puszcza Niepołomice on the 1st place 🌲 )

Thanks, @szarbartosz for a fix 🌲
Closing this issue as done


updated installation of manim on macOS

Thanks for contributing to manim!
Please ensure that your pull request works with the latest version of manim.
You should also include:

The motivation for making this change (or link the relevant issues)
How you tested the new behavior (e.g. a minimal working example, before/after
screenshots, gifs, commands, etc.) This is rather informal at the moment, but
the goal is to show us how you know the pull request works as intended.

I updated as you told.


I am not able to use options

Describe the problem details
I wanted to add options to my xmake project, but the command line interface seems to not exist.
I have implemented the option as follows:
option("build_tests")
    set_default(false)
    set_description("Wether to build the tests. Only necessery when developing")

But when I call xmake f --build_tests=y. I get error: Invalid option: --build_tests=y. When looking at the output from xmake --help it seems that there doesn't exist such an interface. Is this intentional?
xmake version: v2.5.2+202103011718

Here is a simple example project:
set_project("temp")

option("bye")
    set_default(false)
    add_defines("BYE")

target("temp")
    set_kind("binary")
    add_options("bye")
    add_files("main.cpp")

main.cpp:
#include <iostream>

int main(int args, char *argv[]) {
#ifdef BYE
  std::cout << "Bye world" << std::endl;
#else
  std::cout << "Hello World" << std::endl;
#endif

  return 0;
}

When building the project and executing without setting the option it outputs Hello World.
When calling xmake f --bye=y it outputs error: Invalid option: --bye=y.
And setting set_defaults(false) to true without setting the option in the command also outputs Hello World.

you need call set_showmenu(true)
https://xmake.io/#/manual/configuration_option?id=optionset_showmenu

Now it works thank you


Add failing tests to action output

This PR extends action-junit-report to also include failed test names and descriptions in addition to skipped, failed and passed tests count.
The output is then used to send the failing tests in a Slack message.
A few things to note:

The output is limited to 2500 chars, to avoid going over Slack's section text length limit (action fails and doesn't send the message if we go over the limit)
Since this solution is not generic and is build for a specific use-case, it isn't meant to be contributed back to the original repo. Building it in a more generic way would create a bigger complexity in our GH action flow.
Keeping this fork up to date with the original repo should not be too much effort, since we only added 3 lines of code to the original main.ts file. All other changes are added as completely new files.

Very nice! 💯
We probably have to update the content of the dist folder as well as it contains the transpiled code if I am not mistaken? 🤔

Yes, you are right. Done ✔
https://github.com/bitmovin-engineering/action-junit-report/pull/1/commits/7f7b43d1053d724598cd0b842be652c2bab670f0


Question about the 'cross-attn per batch' part

Hello, thanks for this great work.
When debugging the code, I noticed for bs in range(B): in the code, so I'm wondering if there is any special reason to loop within a batch? In other words, is there any operation that prevents parallelization?
Looking forward to your reply.

Also, I don't understand the  'i is in the range of d' in the paper. According to the code, there's a loop within a batch, but I don't see anything related to 'd'.


Error touchableGetInitialState is not a function

Love this package, unfortunately it just broke.
I got the this.touchableGetInitialState is not a function error on this config
{
"react": "16.0.0-alpha.12",
"expo": "^18.0.3",
"react-native": "^0.45.1",
"react-primitives": "^0.4.3",
}

exact error message
Possible Unhandled Promise Rejection (id: 0): TypeError: this.touchableGetInitialState is not a function. (In 'this.touchableGetInitialState()', 'this.touchableGetInitialState' is undefined)

Dup of https://github.com/lelandrichardson/react-primitives/issues/71


fix index out of range panic

Fixes an index out of range panic found by OSS-Fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=62567
uint64(r)/64 can be larger than the length of identifierTrailingBits which throws a panic.

Can we add a unit test case for this?

Done


fix: use the custom request class if available when handling exceptions

Pull Request Checklist

[x] New code has 100% test coverage
[ ] (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
[ ] (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR
[x] Pre-Commit Checks were ran and passed
[x] Tests were ran and passed

Description

the request_class on the Litestar app instance is used when handling exceptions

Close Issue(s)

Fixes #2399

@cofin do you know why that test failed? Is it related to the PR you're working on?

@cofin do you know why that test failed? Is it related to the PR you're working on?

This does look to be the same error I saw there.  However, I thought my code changes did that.  Maybe that's not the case if you are seeing it here.  It was on my list to investigate later today.

It was on my list to investigate later today.

Cool. We can merge this once that's resolved.

@cofin do you know why that test failed? Is it related to the PR you're working on?

I've noticed this occur sporadically for a while now: https://github.com/litestar-org/litestar/issues/2379

It was on my list to investigate later today.

Cool. We can merge this once that's resolved.

Merged, its a known flaky test and all tests passed on re-run.


DEVELOP-932 - fix bug in evaluating remove field; bump version

What problems does this PR solve?

fix bug in evaluating remove field
bump version

How has the changes been tested?

manual testing locally

Reasons for careful code review
If any of the boxes below are checked, extra careful code review should be inititated.

[ ] This PR contains code that could remove data

Looks good! 👍

Looks good! 👍


Baobab and Cerebral are friends!

Hi there,
Just wanted to let you know that I have released a Cerebral Package using React and Baobab. It runs with the current dev version. It will be nice to see how Facets are coming a long to test that also.
Also planned to use the official baobab-react project when it supports V2.
But you can actually play around with it now and it works just fine :-)
https://github.com/christianalfoni/cerebral-react-baobab
For people unfamiliar with Cerebral, it is a state controller with its own debugger. Check out www.christianalfoni.com/todomvc to try it out.

I am using Cerebral and Baobab and loving it! I'm on my own Cerebral fork for now, but will transition to yours Christian now that the rewrite is published :). Great work to both @christianalfoni and @Yomguithereal, thank you guys.

@charlieschwabacher Great news! I will try it out. Thank you to both of you as well.

@Yomguithereal Just a quick question. Version 2 of Baobab. Is is supposed to be able to do mutations and synchronously get those changes? In Cerebral now I am doing a commit() when a signal is done, the state changes does not seem to be available until I do that commit? Would be great if you could clarify that :-)

@christianalfoni I believe if you set the asynchronous option to false when instantiating the tree you'll get what you're looking for. However, I found that with signals/actions, it is most effective to also turn autoCommit to false, and sprinkle "commit" actions in my signals. The commit action just calls state.commit(). This way, we have the benefits of asynchronous Baobab (which makes it possible to store input data in the tree, for example), and also get to batch action changes together.
For example, say we have a route change signal like this:
sFactory.add('projectsRouted',
  RouterActions.setUrl,
  RouterActions.setCurrentPage,
  RouterActions.sidebarProjectsOn,
  commit
)

If you leave autocommit on, this signal would result in at least 3 tree update events (since asynchronous is false), which are sent out to components and trigger the re-render logic. By turning off autoCommit, and sprinkling commit actions in, we can dramatically reduce the number of updates Baobab sends out to components (or whatever is listening to the tree events), as a result of actions/signals.

Ignore the incorrect "Cerebral" syntax there, I'm still using my implementation, but the concepts are all the same.

Hm, hm, hm... I really do not want to expose the tree when using Cerebral, it should just work :-)
But I checked out a bit more. It seems that syncwrite is set to false still. When that is set to true I get the correct behaviour.
From V2 documentation:
"Syncwrite
The tree now write synchronously only but will continue firing its update events asynchronously for obvious performance reasons."
This does not seems to be turned on yet in V2. Actually I do not care about the "update" event from Baobab, because Cerebral triggers its own update when the signal is done running.
I do see that it would be good to batch up mutations and commit them, but I have a feeling it is premature optimization. It is better that all mutations instantly runs. More predictable. Which is why syncwrite will be set to true by default in V2.
I think... ;-)

Also, what is the asynchronous option set to in your case? I believe you need to have it set to false, to avoid cursor jumping when storing input state in the tree.

 Awesome work @christianalfoni and @Yomguithereal

Great news @christianalfoni. I'm finally coming back to life after some times in dire places without the Internet.
To answer your first question @christianalfoni: yes, writes are synchronous in the tree so you can read them as soon as you've written them (quite like the old syncwrite behavior). However, updates remain asynchronous by default and can still be controlled by the user if needed.

Awesome to have you back @Yomguithereal :-D Looking forward to getting that last stuff in place to officially release the Cerebral React/Baobab package!

So, as a summary, what can help you with?

It is actually just the issue I put up #324 . Everything else seems to be working great :-)

Problem with the serialize method?

Ah, no, did not see the issue yet :-) Let have a looksy and get back to you!
Though I was wondering... on this syncwrite. When I do changes I indeed am able to get the state back, but if I do a tree.get() the changes are not there. Is it because I directly try to get the state from where it was changed? I can test an explain better if this did not make any sense :-)

This seems strange indeed. Can you sketch a use case so I can assess the problem please?

Hm, just got some time to test this and now it seems to work without setting syncwrite. Dunno if there has been an update to the Baobab project or maybe I was just misunderstanding something. Anyways, forget about this for now :-)


when I use the method  to load web iamge,then the iamge  allways is placeholder.

The method is

(void)setImageWithURL:(NSURL *)url placeholderImage:(UIImage *)placeholder options:(SDWebImageOptions)options success:(SDWebImageSuccessBlock)success failure:(SDWebImageFailureBlock)failure;

With debug ,I find that  if the length  of imageData  when connection is finished , the image will not be changed , and allways be placeholder.
I solve it as follows; I want to know if has other method to solve this kind of situation. Thanks.
- (void)connectionDidFinishLoading:(NSURLConnection *)aConnection
{
    self.connection = nil;
    [[NSNotificationCenter defaultCenter] postNotificationName:SDWebImageDownloadStopNotification object:nil];
    if ([delegate respondsToSelector:@selector(imageDownloaderDidFinish:)])
    {
        [delegate performSelector:@selector(imageDownloaderDidFinish:) withObject:self];
    }

    if ([delegate respondsToSelector:@selector(imageDownloader:didFinishWithImage:)])
   {
        if (imageData.length == 0) {
            if ([delegate respondsToSelector:@selector(imageDownloader:didFailWithError:)])
            {
                [delegate performSelector:@selector(imageDownloader:didFailWithError:) withObject:self withObject:nil];
            }
           self.connection = nil;
            self.imageData = nil;
        }

        UIImage *image = SDScaledImageForPath(url.absoluteString, imageData);

        [[SDWebImageDecoder sharedImageDecoder] decodeImage:image withDelegate:self userInfo:nil];

    }

}

@starmier i cannot see this code in the library. What version are you using? Please try with the latest build

i will close this for now. please use the latest build and try again. if you still encounter issues please reopen


Browser backed storage of notebook contents

Following on from https://github.com/jupyterhub/binderhub/issues/1003#issuecomment-555726161
This issue is for discussions specific to the idea of creating a notebook extension that also stores the content of the notebook in "browser storage" and later offers the user a way to download the notebook 9if the binder has gone away) and even later offers the user the option to relaunch the binder with this notebook.
As a first version this is a "nice to have" so if we can get something that works "now" for 80% of users that is better than waiting longer to get it to work for 95%. This means cross domain issues are out for the moment as are storing files that aren't notebooks. Let's tackle those after we have some experience with the more basic thing.
I think this is something to be implemented as a notebook extension because it is JS. So JS skills will be required to work on this.
cc @manics

General ideas about "persistence" should go in #1003.

I think Kaggle kernels does this "store stuff in the browser" trick too. Need to double check.

Jupyter.notebook.toJSON() turns the current notebook into JSON without using the contents API (which makes a network request).
Unfortunately Jupyter.notebook.fromJSON() isn't the direct inverse. Need to rearrange some of the JSON field names and get. additional metadata.

Looks promising...

function getNotebookFromBrowser() {
    return {
        "content": Jupyter.notebook.toJSON(),
        "name": Jupyter.notebook.notebook_name,
        "path": Jupyter.notebook.notebook_path,
        "format": "json",
        "type": "notebook"
    };
}

function localstoreSaveNotebook() {
    var nb = getNotebookFromBrowser();
    localStorage.setItem(nb["path"], JSON.stringify(nb));
    console.log("local-storage saved: " + nb["path"])
}

function localstoreLoadNotebook(path) {
    var path = path || Jupyter.notebook.notebook_path;
    var nb = localStorage.getItem(path);
    if (nb) {
        Jupyter.notebook.fromJSON(JSON.parse(nb));
        console.log("local-storage loaded " + path)
    }
    else {
        console.log("local-storage not found: " + path)
    }
}

// Download (size limited) https://stackoverflow.com/a/18197341
function downloadNotebookFromBrowser() {
    var nb = getNotebookFromBrowser();
    var element = document.createElement("a");
    element.setAttribute("href", "data:text/plain;charset=utf-8," + encodeURIComponent(JSON.stringify(nb)));
    element.setAttribute("download", nb["name"]);
    element.style.display = "none";
    document.body.appendChild(element);
    element.click();
    document.body.removeChild(element);
}

Next step: convert to an extension

Give this a go! https://github.com/manics/jupyter-offlinenotebook
Only tested on firefox

Bam! How cool is this??? (also are there browsers that aren't firefox :p)

I tried out the extension in Firefox and Chrome. Works in both.

I've just merged https://github.com/manics/jupyter-offlinenotebook/pull/4 so it'll use BINDER_REPO_URL from https://github.com/jupyterhub/binderhub/pull/1010
If it's not set you won't see the buttons.

I was thinking that once #1010 has been merged and deployed: should we add the offlinenotebook extension to repo2docker by default and see if anyone notices/comments on it? I think getting it out there with some real users would be good to get feedback/bug reports/test on weird browsers.
After a while of it being used and worked on we can make an announcement to direct attention to it.

After reading through the notebook docs source code I figured out how to add dialogs on success/failure which I think was the main blocker for usability.
Also had a go at adding binder links, at the moment they're displayed as URLs:
Is there a way to enable it for a subset of repos (e.g. jupyter*/* GitHub repos only) instead of everything at once?

We don't have the ability to use a different version of repo2docker for different repos (yet). I think in practice enabling it for all will lead to a gradual rollout because most users don't rebuild a repo, they use one that was already built and hence won't show this extension.
If we wanted to make it a really small rollout I think we'd either have to build the infrastructure for switching repos to different versions of r2d or make the extension so that it rolls a random number and only turns itself on for a small fraction of builds.
Past experience suggests that most people don't notice when we do little things like this and only take note/use a feature after some marketing effort. -> I'd add it for all rebuilds and wait for feedback.

I think the latest version is in a pretty good state: https://github.com/manics/jupyter-offlinenotebook/tree/0.0.8:

Uses IndexedDB instead of localstorage (notebooks previously saved into localstorage won't be accessible)
Repo and Binder link buttons in the notebook toolbar
Works in Firefox and Chrome on Fedora Linux

Sounds like a good plan!
I was also wondering if we could use the repo2docker appendix to install this in a few repos (something like random.seed(repo_name); if random.random() < 0.1). Maybe that is too much effort compare to adding it to repo2docker directly.
For my education: what does IndexDB get you over local storage? Bigger files?

localstorage is limited to 5-10 MB total per origin. As soon as you embed resources in a notebook such as images you can easily hit it. IndexedDB provides a lot more space, up to 2GB in Firefox https://developer.mozilla.org/en-US/docs/Web/API/IndexedDB_API/Browser_storage_limits_and_eviction_criteria#Storage_limits

We have added https://github.com/manics/jupyter-offlinenotebook to repo2docker in https://github.com/jupyter/repo2docker/pull/845. Closing this for now.

@betatim I've invited you to be a collaborator on https://github.com/manics/jupyter-offlinenotebook/ so it's not dependent on one person.


feat(ng:class): value can be a map of class names to boolean expressions (described in #626)

:+1: I like it.

landed as 56bcc04c54ed24c19204f68de52b8c30c00e08f0
thanks!!


[Bug]: PointAnnotation onSelected should not be called on double tap

Mapbox Implementation
Maplibre
Mapbox Version
default
Platform
iOS
@rnmapbox/maps version
10.0.0-beta.56
Standalone component to reproduce
import { Camera, MapView, PointAnnotation } from '@rnmapbox/maps';
import React from 'react';
import { View } from 'react-native';

function BugReportExample() {
    const [color, setColor] = React.useState('#f00');
    return (
        <MapView style={{ flex: 1 }}>
            <Camera centerCoordinate={[-74.00597, 40.71427]} zoomLevel={14} />
            <PointAnnotation
                key={color}
                coordinate={[-74.00597, 40.71427]}
                onSelected={() => {
                    console.log('onSelected');
                    setColor((c) => (c === '#f00' ? '#0f0' : '#f00'));
                }}
            >
                <View
                    style={{
                        width: 50,
                        height: 50,
                        backgroundColor: color,
                    }}
                />
            </PointAnnotation>
        </MapView>
    );
}

export default BugReportExample;

Observed behavior and steps to reproduce
When double tapping on a PointAnnotation, onSelected is called. This only happens on iOS. I think this is a bug and onSelected should not be called, or there should be some way to detect if it was a single or double tap.
Expected behavior
onSelected should not called on double tap.
Notes / preliminary analysis
No response
Additional links and references
No response

Seems to be fixed with 10.10.0 update, could not repro with v10 on the current main
https://github.com/mapbox/mapbox-maps-ios/blob/main/CHANGELOG.md#changelog-for-mapbox-maps-sdk-v10-for-ios


Cannot find module 'graphql/tsutils/Maybe'

I updated grapql-binding to v2.3.1 and this error appears.
The changelog says, that there was an upgrade to graphql@14, but I can't figure out, what I've got to do to fix this error.
ERROR in node_modules/graphql-binding/dist/codegen/FlowGenerator.d.ts(3,19): error TS2307: Cannot find module 'graphql/tsutils/Maybe'.
The graphql-Dependency of my project is at v 14.0.2.
Thanks in advance
Carsten

Hey 👋,
Thank you for reporting this. Could you put together a short reproduction example? It can be either Github repo or Codesandbox, or anything that suits you better 🙂

Hey there! I'm seeing this too – tiny repro at https://github.com/jacobpgn/graphql-binding-176, the tsc build is what's blowing up.

:tada: This issue has been resolved in version 2.3.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

@jacobpgn thank you for reproduction; I was able to find the issue in no time! The problem emerged due to missing @types/graphql in your project.
I internalised Maybe type to prevent such issue from happening. Let me know if you still experience the bug! 🙂

@jacobpgn
Thanks for providing a repro-repo!
@maticzav
Thanks for fixing the bug this fast!


Added a user model

As well as test with factories, added a bcrypt lib for password hashing, and a nanobox (boxfile.yml) for consistent dev env.

Nice PR! Thanks for taking the time!
I don't know anything about Elixir, but hopefully @BrainMaestro will stop by later and give us some thoughts.

I'm fairly new to Elixir myself (a few months of personal projects) but when I saw this project, I thought why not help out with what I learned already.
My personal project is already set up with a JWT token and the what not, but I thought I put that in a different pull request after the user one get's accepted.

I removed the local dev env and restored the configs to be more like master so that this is a bit of a cleaner PR.

Okay, updated.

Thanks. This looks good

@mattdharmon, any chance we could split the ex_machina factory part into a separate PR? Sorry to ask, but I feel it would make this a lot clearer. Especially for people that are not so familiar with it.
Also, it was throwing an error Could not start application ex_machina: could not find application file: ex_machina.app

@BrainMaestro I can do that, but will take a bit. Did you do a deps.get because I have it working on my machine.

@mattdharmon that's fine, take your time.

Hmm, I pushed in new updates that also fixed the conflicts, but is seems to not have updated yet.

Hey @mattdharmon. Thanks for the PR. This looks great!
One last thing, could you move the users folder to the real_world one? So that it'll match the new structure for 1.3 and also be similar to blog

Sure thing, min.

Awesome. You are welcome to pick up something else.


[$250] Set syncCustomLists and syncCustomSegments to true in the NetSuite config when a user has one or more set in their configuration

Problem
One thing we forgot about in the NetSuite project when building the integration configuration in New Expensify is that we need to set two boolean style configs whenever we have a Custom Segment or Custom List that we're importing.

This create issues when importing and exporting those segments and/or lists
Solution

If we ever update the NetSuite configuration for a workspace to add a Custom Segment such that there is > 1 entry insyncOptions.customSegmentsthen we should setsyncOptions.syncCustomSegmentstotrue`
If we ever update the NetSuite configuration for a workspace to add a Custom List such that there is > 1 entry in syncOptions.customLists then we should set syncOptions.syncCustomLists to true
If the customSegments or customLists array is ever empty when saving a configuration (i.e. we remove the last Custom Segment or list) we should set syncCustomLists / syncCustomSegments to false

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021836280909533854916
Upwork Job ID:<PHONE_NUMBER>533854916
Last Price Increase: 2024-09-18

Issue OwnerCurrent Issue Owner: @rushatgabhane

@mananjadhav @shubham1206agra Putting this under your radar in case you wanted to knock it out real quick

It's used in the back-end to control what data gets imported and exported. But hmmmm... now that you mention it, we don't use it anywhere in the client itself... So I'll actually handle this internally in the API - thanks for the gut check! 🙇🏽


[WIP] Webextension

It will run on Mozilla Firefox.
https://wiki.mozilla.org/WebExtensions

It runs on Firefox Nightly or Firefox Developer Edition now. Stable release is scheduled on Firefox 38 will release 2016/8/3.
We can prepare for release on AMO.

It can run on least Firefox 47. Firefox 45 is able to install WebExtension but https://bugzilla.mozilla.org/show_bug.cgi?id=1210583 is solved on Firefox47.

If you use Firefox Beta v47.0b1, you can try it out: https://www.dropbox.com/s/y2f7zsqydz3f38o/gyazo-2.3.0.xpi?dl=0