DCR: Adapter/Bot initialization is confusing and boundary between middleware and bot is fuzzy

Feedback from hackathons shows that there is friction between the way the middleware pipeline is hooked up, how it is consumed from ASP.NET and how your bot logic hooks up to it.
Example of the issue

Initialization: there is both an adapter and a bot, you have to pass the adapter into the bot, but keep the adapter around so you can push an activity into the adapter which goes to the bot.  This really confusing and causes us to describe 2 concepts (bots and adapters) and the complex handshake between them
state Some adapters need to keep track of stuff for the entire turn, but since they are not middleware and technically don't know about the bot it creates weird tracking metaphors
BotLogic we call the middleware class Bot and have .OnReceive() as a piece of middleware, which pushes people into the direction of thinking of the entire thing as a bot.  This blurs the boundary between the bot's logic and stuff which is more environmental like setting up a runtime middleware.

Proposal
This proposal is implemented in pull request #145

Rename middleware class from Bot to BotAdapter
Renaming the class better describes it's functionality, which is to create act as abstraction between the bot and the runtime environment and to provide middleware hooks for running a bot in.  It also then creates a mental model where you don't push all sorts of bot logic stuff into the middleware.  While you can of course do whatever you want in middleware, the naming makes it a bit more clear that it's about the pipeline, not the bot itself.

Combine Adapter and Bot together using inheritance
Instead of having 2 concepts, merge them together into 1 base class called a BotAdapter.  (I am open to other names, and like BotHost)  To support a new environment you create a class which is derived from the base BotAdapter class which then implements appropriate methods to adapt to communication with the environment.  The base class gives you the standard pipeline implementation.
All BotAdapters would have at least 4 public methods

.Use() for registering middleware using fluent pattern
ProcessActivity(callback) which has appropriate parameters for environment but then calls the bot logic
CreateConversation() and ContinueConversation() which allows programs to do proactive scenarios
program to create a new conversation

Remove .OnReceive()
don't use .OnReceive() as middleware, but instead pass bot's logic as a simple (BotContext) callback

Sample
The net result in a ASP.NET Core project is that it looks like this:
Startup.cs
           // define BotAdapter as singleton
            services.AddSingleton<BotFrameworkAdapter>(serviceProvider =>
            {
                return new BotFrameworkAdapter(Configuration)
                    .Use(new BotStateManager(new MemoryStorage()));
            });

MessagesController.cs
    [Route("api/[controller]")]
    public class MessagesController : Controller
    {
        public BotFrameworkAdapter botAdapter = null;

        public MessagesController(BotFrameworkAdapter botAdapter)
        {
             this.botAdapter = botAdapter;
       }

       [HttpPost]
        public async Task<IActionResult> Post([FromBody]Activity activity)
        {
            try
            {
                await botAdapter.ProcessActivity(this.Request.Headers["Authorization"].FirstOrDefault(),
                    activity,
                     async (context) =>
                    {
                        if (context.Request.Type == ActivityTypes.Message)
                        {
                              context.Reply($"echo: {context.Request.AsMessageActivity().Text}");
                        }
                     });
                return this.Ok();
            }
            catch (UnauthorizedAccessException)
            {
                return this.Unauthorized();
            }
        }
}

Here's console adapter sample
    class Program
    {
        static void Main(string[] args)
        {
            MainAsync(args).GetAwaiter().GetResult();
        }

        static async Task MainAsync(string[] args)
        {
            Console.WriteLine("Welcome to the EchoBot.");
            var adapter = new ConsoleAdapter()
                    .Use(new BotStateManager(new MemoryStorage()));

            await adapter.ProcessActivity(async (context) =>
            {
                if (context.Request.Type == ActivityTypes.Message)
                {
                    context.Reply($"echo: {context.Request.AsMessageActivity().Text}");
                }
            });
        }
    }

NOTE: This DCR originally was coded using BotServer as base class.  That led to anems like BotFrameworkBotServer and didn't really capture what was going on.  Based on feedback from Ccastro I changed this to BotAdapter and everything fell into place.
Update2: Added console sample

I started playing around the new sdk over the past few days. And I found .OnReceive confusing. A natural idea is to register the bot as a singleton service, but it becomes embarrassing where to hook up OnReceive. If it's set as part of the service, then it becomes hard to pass request related info to the callback. If it's set in the controller, then it creates issue if multiple requests come in at the same time.
So I like the idea a lot to remove OnReceive - it will make things much simpler and more robust.
Thanks @tomlm .

I think it would be instructive to show two sets of samples - one for the BotFramework adapter and one for the Console adapter. I'm worried that the design might be too HTTP-centric.

I updated with console sample

I'll ask the dumb-question-from-the-guy-who-hasn't-coded-C#-in-eight-years: does it make sense that those two samples look so different?
What I want - and again this comes from a totally naïve place - is that the "setup bot middleware" code and "bot logic" code would look identical in those two samples, hiding the details of where activities are coming from and going to. I'd like to be able to switch from Console to BotFramework with only relevant code changes.
(This isn't a spurious desire - we have solid feedback that developers like writing and testing bots with Console, switching to BotFramework only when they need to test rich messages.)

They are identical.  Console apps don't use dependency injection or any of that stuff.
Here is the adapter initialized in asp.net using BotframeworkAdapter in startup.cs:
        return new BotFrameworkAdapter(Configuration)
                    .Use(new BotStateManager(new MemoryStorage()));

Here is the adapter initialized in program.cs
  var consoleAdapter = new ConsoleAdapter()
                    .Use(new BotStateManager(new MemoryStorage()));

Here is the consumption in asp.net core
  await botAdapter.ProcessActivity(this.Request.Headers["Authorization"].FirstOrDefault(),
                    activity,
                     async (context) =>
                    {
                        if (context.Request.Type == ActivityTypes.Message)
                        {
                              context.Reply($"echo: {context.Request.AsMessageActivity().Text}");
                        }
                     });

here is in the console app:
await consoleAdapter.ProcessActivity(async (context) =>
            {
                if (context.Request.Type == ActivityTypes.Message)
                {
                    context.Reply($"echo: {context.Request.AsMessageActivity().Text}");
                }
            });

The differences are because of the environment differences:

Http Server has to check the authorization of the caller and has the activity from an external HTTP POST, and so has 2 additional parameters
Console starts listening to console.Stdin, and calls callback on each activity.

I don't really know how to make them more similar...they differ by 2 parameters which only make sense when participating as part of HTTP protocol.
You could in theory use dependency injection, but it would be adding MORE code that nobody does when coding console apps.

I agree that renaming Bot to BotAdapter, combining Adapter and Bot together, and removing OnReceive() feel like good changes. The similarities between console and ASP.NET feel good as well.
But, beyond that, this doesn't feel like the ASP.NET Web API programming model.
In that model, services are passed to the controller through constructor injection, and the controller uses those services to create the response for each request.
In this case, the BotFrameworkAdapter is passed to the controller's constructor, and when the HTTPPost request comes in to api/messages, the response is created by passing a callback to botAdapter.ProcessActivity().
       [HttpPost]
        public async Task<IActionResult> Post([FromBody]Activity activity)
        {
            try
            {
                await botAdapter.ProcessActivity(this.Request.Headers["Authorization"].FirstOrDefault(),
                    activity,
                     async (context) =>
                    {
                        if (context.Request.Type == ActivityTypes.Message)
                        {
                              context.Reply($"echo: {context.Request.AsMessageActivity().Text}");
                        }
                     });
                return this.Ok();
            }
            catch (UnauthorizedAccessException)
            {
                return this.Unauthorized();
            }
        }

Of the code above, this code is the code that feels like responding to the request posted to api/messages is this:
                        if (context.Request.Type == ActivityTypes.Message)
                        {
                              context.Reply($"echo: {context.Request.AsMessageActivity().Text}");
                        }

In one of the samples, a BotController was introduced to provide a bridge between the controller and the adapter's concept of a BotContext that represents the request/response of that "turn".
        protected override Task OnReceiveActivity(IBotContext context)
        {
            if (context.Request.Type == ActivityTypes.Message)
            {
                context.Reply($"You said: '{ context.Request.AsMessageActivity().Text }'");

                return Task.CompletedTask;
            }
        }

I realize this code has OnReceiveActivity(), but my point is that this bridges the gap between how Web API Controllers work and the "service" that BotAdapter provides by providing a BotContext for the "turn" that allows the developer to create a response to the request.
That feels like the piece that's missing for me.

I think to satisfy what @cmayomsft is saying it's straightforward enough to simply not use a lambda. Most sufficiently intelligent bots won't be created in this way, so it's probably best to steer folks to using a method in this place instead of a lambda, and then it becomes a lot like what was seen in the BotController Chris alludes to, going from this:
[HttpPost]
public async Task<IActionResult> Post([FromBody]Activity activity)
{
	try
	{
		await botAdapter.ProcessActivity(this.Request.Headers["Authorization"].FirstOrDefault(),
			activity,
			 async (context) =>
			{
				if (context.Request.Type == ActivityTypes.Message)
				{
					  context.Reply($"echo: {context.Request.AsMessageActivity().Text}");
				}
			 });
		return this.Ok();
	}
	catch (UnauthorizedAccessException)
	{
		return this.Unauthorized();
	}
}

to this:
[HttpPost]
public async Task<IActionResult> Post([FromBody]Activity activity)
{
	try
	{
		await botAdapter.ProcessActivity(this.Request.Headers["Authorization"].FirstOrDefault(), activity, OnReceiveActivity);
		return this.Ok();
	}
	catch (UnauthorizedAccessException)
	{
		return this.Unauthorized();
	}
}

private Task OnReceiveActivity(IBotContext context)
{
	if (context.Request.Type == ActivityTypes.Message)
	{
		context.Reply($"You said: '{ context.Request.AsMessageActivity().Text }'");

		return Task.CompletedTask;
	}
}

overall I like the feel of what's going on, but the naming is leaving a bad taste.
It seems like BotFrameworkAdapter lends itself toward a lower-level abstraction than what it's being used as here so I think some more thought needs go to in to this. In particular because it's the fact that this particular bot is talking to the Microsoft Bot Framework's Connector Service that necessitates the header requirement (among other things) where other "heads" for bots do not (ie: ConsoleAdapter).
Whatever naming is decided upon, though, it should be consistent across the surfaces. eg: If we go with BotHost, then I'd like to see ConsoleHost, etc.

@brandonh-msft the two code fragments seem identical to me. The bot owner should have the freedom to decide whether they want to use a lambda, or a named function. It doesn't seem to be something which botframwork itself has to worry about.
Seems to me the key is that the callback HAS to be associated directly with one specific ProcessActivity call - it cannot and shall not be a callback property set in a non-transactional way. Otherwise you end up with security issues since you might have a call back belonging to a different user context responding to a different call.
Maybe a more natural way is to avoid the call back completely - just do necessary processing, return a context from the ProcessActivity, then let the user construct their reply with the context - they should handle returning of the reply (this.Ok(reply)) instead of just this.Ok().
I don't have enough understanding about the botframework code yet so apologies if I am just non-sensing here.

To be clear, think about this scenario with bot itself as singleton service:
user request1 -> new controller instance1
-> set callback property (callback1) on bot (singleton)
user request2 -> new controller instance2
-> set callback property (callback2) on bot (singleton), which overrides the previous one.
-> callback2 invoked to respond to user request1
-> callback2 invoked to respond to user request2
This is a security drawback which should be avoided by the framework itself.

The Adapter patterns we are showing here are platform agnostic, in that there is no dependency on a given Http framework like ASP.NET/Core
A BotController for ASP.NET/Core which looks like
public class MessagesController : BotController
{
      public MessagesController(BotFrameworkAdapter adapter) : base(adapter)
     {
     }

    public Task<HttpResponseMessage> OnActivity(IBotContext context)
    {
         ....
    }
}

is easy super easy enough to add, but it does introduce a ASP.NET layer that hides that it's the same framework across all languages.  We have in the past taken the tack of not adding layers which hide stuff (which I am rewriting the AlarmBot) so that it is transparent what is going on.
I could entertain the idea of

Microsoft.Bot.Builder-Core -> Core classes
Microsoft.Bot.Builder -> Http based classes which are server agnostic (work for HttpListener and Asp.Net and Asp.Net core)
Microsoft.Bot.Builder.AspNetCore -> Adds ASP.NET Core BotController class
Microsoft.Bot.Builder.AspNet -> Addds ASP.NET BotController class

I really like that proposal for nuget pkgs. Not only does it showcase the versatility of the framework simply by showing up, but the implementations will provide a tailored experience. There's also precedent to lean on.
Just need to put emphasis on the pkg descriptions to lead developers to success.

This has been checked in with https://github.com/Microsoft/botbuilder-dotnet/pull/145


[Feature Request]: Enable concurrency in GHW

Description
Running multiple instances of the same module validation workflow, may result in conflicts when trying, e.g., to deploy resources while the same resources are getting deleted by a previous run.
concurrency can be enabled at workflow (Ref: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#concurrency) or job level (Ref: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idconcurrency) to ensure that only a single workflow or job using the same concurrency group will run at a time.
In the default behavior, next runs are queued and started as soon as previous runs complete.
Alternatively, the cancel-in-progress setting can be used to cancel previous runs, triggering the most recent instead. This setting does not look useful in the CARML case, since canceling e.g. the deployment validation job, would not cancel the actual test deployment to Azure, resulting anyway in the same deployment conflicts described above.
This issue is about implementing a PoC to add concurrency to GH module validation workflows, proposing, e.g.,

On which level (workflow vs job) concurrency should be enabled
What would be the most convenient group to set up

Tested group: group: ${{ github.workflow }}
Ref: GH context https://docs.github.com/en/actions/learn-github-actions/contexts#github-context
github.workflow: The name of the workflow. If the workflow file doesn't specify a name, the value of this property is the full path of the workflow file in the repository.
Since workflow names are unique for each module, this ensures only a single workflow of the same module runs at the same time.

Workflow vs job level
Workflow level concurrency tests
The whole workflow is queued

The workflow starts as soon as the previous run finishes

Job level concurrency tests
Concurrency can also be set at job level.
In the CARML case that would be ideal, since concurrency is not strictly required for static validation or publishing, but only for deployment validation.
However, due to the matrix testing variants in different jobs, enabling concurrency at deployment validation level results instead in intended parallel tests to wait for each other

In addition, in case the same module workflow is re-triggered meanwhile, deployment validation jobs in the second run gets canceled


Terraform code

@jensheerin
Thank you so much for terraform code!
I have already tried to test this. However, I get the following error when creating the storage account.

The following error has already been noted in the Terraform Plan. It was only when I commented out line 33 that I was able to successfully create a terraform plan.

Thank you @florian-ried for testing and logging issue! It has been corrected.


Icon in header cell

I'm submitting a ...  (check one with "x")
[ ] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[x] support request => Please do not submit support request here

Current behavior
Hello, I have tried to put icon into column header cell, but I don't know how can I do it. Can anyone help me?
Expected behavior
There are no icon
Reproduction of the problem
What is the motivation / use case for changing the behavior?
Please tell us about your environment:
Windows 10

Table version:
6.3.0

Angular version:
2.4.10

Browser: [all ]

Language: [all | TypeScript X.X | ES6/7 | ES5 | ] Typescript 2.0.3

The easiest way to do it is to use html in your column's name.
For example using Font Awesome:
columns = [
 {
    // Prop represents the name of the property that holds this cell's value
    prop: 'description',
    // Name represents the label for the column header.
    name: 'Description<i class="fa fa-warning"></i>'
}
]

The alternative is by providing a headerTemplate for the column, but it is much more involved if this is the only reason you need to do it.

thank you very much for help Your help :)


Incorrect statement?

It states in the documentation "1 Non-admin users in your Azure AD tenant can register AD applications if the Azure AD tenant's Users can register applications option in User settings page is set to Yes. If the app registrations setting is set to No, the user performing this action must be a Global Administrator in Azure AD". However, from an Azure AD perspective, I was able to provision a Run As account by ensuring I have the following Directory Roles when "Users can register applications" was set to No: Application Developer Role and the Application Administrator role. The highlighted statement above indicates I must be a Global Administrator in Azure AD when "Users can register applications" is set to No, but this was not the case in my test environment.

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 56e2500f-e1f5-bc87-6e5c-f41b59265049
Version Independent ID: d212be48-7d05-847d-3045-cea82e6ba603
Content: Manage Azure Automation Run As accounts
Content Source: articles/automation/manage-runas-account.md
Service: automation
Sub-service: shared-capabilities
GitHub Login: @georgewallace
Microsoft Alias: gwallace

@samaea Great catch. I will correct the sub note.. As you can see from where the subnote is referenced the permissions are accurate to the permissions needed.  I will update the footnote to be inline with the references.. Once my PR is merged to correct this, it will automatically close this issue.


"Fărcașele" is listed in the drop-down menu

Description:
When user writes "Fărcașele" the location appears in the drop-down menu next to the comune and the county witch is a part according to the law
Precondition:
The website is up an running.

Step 1
Write in the search bar "Fărcașele"
Expected results
The location appears in the drop-down menu as "Comuna Fărcașele, OLT"


Leaderboard Get 404

Sign in works fine
Settings a stat works fine
Getting a stat works fine
However, doing a "GetLeaderboard" call, always returns zero rows.
and when i watch the http monitor, its getting a 404. I'm using the example scene for leaderboard, and ive checked everything twice or more and i just dont understand why im getting this error. Does it not work until the game is published or something? I've seen others with this exact same issue but no solution. Please Help. Thanks for your time anyone who has any information

February 2021 and the problem remains!!    Empty leaderboard (zero rows) and yes 404 when using fiddler to monitor the web requests
Are you slow Microsoft or what?


Installing dependencies fails

Hi!
When I try to install the dependencies (Win 10 Pro), I get this error:
Traceback (most recent call last):
File "", line 198, in _run_module_as_main
File "", line 88, in run_code
File "C:\Users\Me\AppData\Local\Programs\Python\Python311\Scripts\pip.exe_main.py", line 2, in
File "F:\Portable\tahoma\re.py", line 125, in
import sre_compile
File "C:\Users\Me\AppData\Local\Programs\Python\Python311\Lib\sre_compile.py", line 6, in
from re import _compiler as _
ImportError: cannot import name '_compiler' from partially initialized module 're' (most likely due to a circular import) (F:\Portable\tahoma\re.py)
Does this require Linux, maybe?

The error is the last line : ImportError: cannot import name '_compiler' from partially initialized module 're'
That's mean python can't import re, perhaps because it's already in the folder ("F:\Portable\tahoma\re.py")
Did you tried : python3 -m pip install regex ?
Did you also tried with the pip install of tahoma ? : https://pypi.org/project/tahoma/#description
Do you have the last version of Python3 ?
re is included in the portable version (re.py), did you tried to remove re.py from : "F:\Portable\tahoma\re.py" ?

Did you tried to reinstall python3 from the Windows Store ?
I suggest you to uninstall your version of Python and to install it from the Windows Store. It's working perfectly with me on Windows 11

Fully removing all existing Python 3 versions and then re-installing from the store worked, thanks a lot!


Enhancement - sort command

Coverage increased (+0.01%) to 89.775% when pulling 30fa523d66ff97d08102ac66c6d84d6cc4d32608 on hj2304:Enhancement into 04227bd39635f52111ea60c9c51d26d18f646f57 on CS2103AUG2017-F10-B2:master.


Minor fix

Proposed changes

Fix incorrect Korean sentence
Add a description in KLVM & EVM difference

Types of changes
Please put an x in the boxes related to your change.

[x] Minor Issues and Typos
[ ] Major Content Contribution
[ ] Others

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to reach out. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[ ] I have read the CONTRIBUTING GUIDELINES
[ ] I have signed the CLA
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

Reflected by merging automatic PR from Crowdin.


Custom label on a timeline entry

A way to add a label or tag to a timeline entry.
Now most of my timeline entries are "File Saved". I'd like a way to identify a particular point in my changes. E.g. if I'm about to embark on a refactoring but want a quick way to identify and restore my previous code.

You can rename entries:

You can create custom entries:


99th Chunk Age is BS

I suspect histogram buckets

This might not be BS, it might be an actual representation of the distribution. It would be consistent with a very high outlying maximum, for example.

I think it's BS, as with all my changes it hasn't wavered from 27mins. I
think it needs more investigation.
On Tuesday, 8 November 2016, Jonathan Lange<EMAIL_ADDRESS>wrote:

This might not be BS, it might be an actual representation of the
distribution. It would be consistent with a very high outlying maximum, for
example.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/weaveworks/cortex/issues/121#issuecomment-259110594,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAbGhbDtfm-0SQ6qCxCPIKW8Xihz87TXks5q8FmogaJpZM4Kr3b5
.

I think it needs more investigation.

Me too.

Also see https://github.com/weaveworks/monitoring/pull/41


Away mode

First, thank you for creating this. It's something I've been trying to find for months.
Is it possible to give a command to "enter away mode" and "cancel away mode"? That would be nice to be able to say when leaving/returning to the house.

@Salty224 thanks for the feedback! Alexa doesn't have any built-in commands for Away Mode at the moment (the skill is limited to what commands Alexa provides, I can only hook into the ones they provide).
I was thinking of leveraging the "Turn [device] on" and "Turn [device] off" commands to handle Away Mode stuff, but was worried about misleading users for the sake of shoehorning in another feature. Thoughts?

I think saying "turn [device] off" is a good way to enable away mode.  I never really "turn off" the thermostat, so it's not confusing, at least to me.
using alexa to set away mode would make it much easy to use on the way out the door.

Thank you for providing a complete novice the information needed to do this successfully. I was interested to see if a command for away mode code be achieved and I agree with Steve that the on/off command would be great and would really increase the benefit of this skill. I also don't think this is confusing at all.  Thank you again, your effort is greatly appreciated.


Add a feature flag to opt-in for long-running integration tests

This allows opting-in for longer-running tests by enabling "expensive_tests"
feature, instead of waiting for a few minutes after starting cargo test.
Amend the CI to run all the tests (including expensive ones) on every run.

bors r+


⚠ Turnos 24x7 has degraded performance

In ebe718c, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 957 ms

Resolved: Turnos 24x7 performance has improved in e94cbdf.


Create a Getting Started page in documentation

I'm completely new to the project, so having a Getting Started page or at least some more info in the README would be really useful.

In particular, I can't find any instructions for building or bootstrapping the source code, nor can I find instructions for downloading pre-built packages.
Another problem: The home page describes PhosphorJS as a JavaScript library, but all the source and all the examples appear to be in TypeScript. Which is fine (TypeScript seems pretty cool), but it would be nice to have some examples using plain JavaScript.

Getting started example would be great!

There are these examples but they are not directly linked to on the home page.

Ah yes, I remember seeing that.  It is still missing "getting started" type instructions (a la "hello world").  I could cobble something together using the bundle.js file, but that basically entails reverse engineering things.
It would also be nice to have a smaller bundle.
For now I'm happy with my fork of nwjs-menu-browser, though it is still missing keyboard navigation.  It is less than 1/10 the size of bundle.js.  Once PhosphorJS's DockPanel functionality is comparable or better than GoldenLayout (which supports dragging to a tab or popping out to new window) then I'd be interested in switching.

I totally agree. There are no instructions for getting started. I'm a good javascript programmer, but I don't know how to use build tools. Also, the size of bundle.js in different examples is different. Must have something to do with how the example is built?
Phosphor has been chosen by the Eclipse group for their new cloud/desktop IDE Theia. I think it may get more play than GL. But there is no way to get started.

There are these examples but they are not directly linked to on the home page.

They are old, and no longer apply to current version


fix(graphcache): infinite loop in dependent queries

Summary
When we have a data relationship between x queries we currently end up re-triggering them when we have a cache-miss, this because of how we collect dependencies and reexecute them. To circumvent this we keep track of the operation that creates these reexecutions and we keep track of the ones that were targeted by these reexecuting origins.
This means that A can trigger B but B can't re-trigger A if B is a cache-miss.

Superseded by https://github.com/FormidableLabs/urql/commit/eec46e03a77aa67475def4f7ad2bd0ee075e86ad

Testing a different approach to this in #2737


Backport 19062018 v1.0

Backports to: v1.0
https://github.com/cilium/cilium/pull/4359
https://github.com/cilium/cilium/pull/4482
https://github.com/cilium/cilium/pull/4494
https://github.com/cilium/cilium/pull/4524
https://github.com/cilium/cilium/pull/4534
https://github.com/cilium/cilium/pull/4543

This change is

test-me-please


Pass editor._updateTags to importJSON

Since importJSON is a static method on node classes, there isn't a good way to determine what is going on when importJSON is called - for instance are we deserializing the document initially or pasting in some lexical content from the clipboard.
It seems like editor._updateTags is a reasonable place to have this kind of information (as it already has paste when pasting) so by passing updateTags to importJSON, custom logic can be implemented if desired and should be extensible going forward by using additional updateTags when needed.

Maybe we should we pass editor instance instead as we do for create/export json

Maybe we should we pass editor instance instead as we do for create/export json

Agree - either this or I think it should be possible to use the existing util method, $hasUpdateTag, inside that node method:
https://github.com/facebook/lexical/blob/e07591e024c585492d9f6a3b83176ccadfb72913/packages/lexical/src/LexicalUtils.ts#L1254

That's even better, until we have a good reason to pass editor we can keep current api

@nemophrost please re-open or tag me or @fantactuka if $hasUpdateTags doesn’t work for you.

@acywatson $hasUpdateTags isn't exported in lexical/src/index.ts and my build tooling is choking on trying to import directly from lexical/LexicalUtils happy to create a new PR to add $hasUpdateTag to index file if needed or is there another way to correctly import that?

@nemophrost please re-open or tag me or @fantactuka if $hasUpdateTags doesn’t work for you.

@acywatson $hasUpdateTags isn't exported in lexical/src/index.ts and my build tooling is choking on trying to import directly from lexical/LexicalUtils happy to create a new PR to add $hasUpdateTag to index file if needed or is there another way to correctly import that?

Yea go ahead and make a PR if you don’t mind. Not sure why that isn’t exported.

@acywatson https://github.com/facebook/lexical/pull/4216


Can't install statsr

Hi there, I'm setting up my R enviroment but when trying to install "statsr" I get the "Error: Could not find build tools necessary to build Rcpp" message. Below is the command I'm using.
Previous to this, I have installed the following:
install.packages("devtools")
library(devtools)
install.packages("dplyr")
install.packages("ggplot2")
install.packages("shiny")
Anyone out there with the same problem. I'm running Mac.-
BR
MAX:-

install_github("StatsWithR/statsr")
Downloading GitHub repo StatsWithR/statsr@master
from URL https://api.github.com/repos/StatsWithR/statsr/zipball/master
Installing statsr
trying URL 'https://cran.rstudio.com/bin/macosx/mavericks/contrib/3.3/broom_0.4.2.tgz'
Content type 'unknown' length 1598847 bytes (1.5 MB)
==================================================
downloaded 1.5 MB

Installing broom
trying URL 'https://cran.rstudio.com/bin/macosx/mavericks/contrib/3.3/tidyr_0.6.1.tgz'
Content type 'unknown' length 549062 bytes (536 KB)
downloaded 536 KB
Installing tidyr
Downloading GitHub repo RcppCore/Rcpp@master
from URL https://api.github.com/repos/RcppCore/Rcpp/zipball/master
Error: Could not find build tools necessary to build Rcpp

My guess is that you are running on a windows system without Rtools installed, this is available here - https://cran.r-project.org/bin/windows/Rtools/. Once that is installed try restarting R or RStudio and attempt to reinstall the packages.


Frontend : Flex properties (Audio)

Description
Audio for flex property.
Domain
Frontend Dev HTML/CSS/JS
Type of Contribution
Audio
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

/assign


css worker cannot start

What happened?
After I configure it in accordance with the readme document, the error is reported through the instruction**. / sbin/start-worker.sh** startup is as follows . / sbin/start-workers.sh or start-all.sh is also reported as follows. I confirm that the permissions of the logs directory are fine.I want to know how to start worker

What did you expect to happen?
I want to know how to start worker
How can we reproduce it (as minimally and precisely as possible)?
I'm not sure. I configure it exactly according to the documentation.
Software version

$ <software> version
# paste output here

this happened to me I deleted all the css-defaults.conf save the master and it started to work but I am not sure what the issues is.

this happened to me I deleted all the css-defaults.conf save the master and it started to work but I am not sure what the issues is.

I only see the master-related configuration in the css-config.sh file. What is the configuration in your css-default.cong file? I annotated all the configuration items in the css-default file, leaving only the configuration of wokespace and zk.


Remove hidden from migrate org command

Fixes: https://github.com/github/gh-gei/issues/710

[ ] Did you write/update appropriate tests
[x] Release notes updated (if appropriate)
[ ] Appropriate logging output
[X] Issue linked
[x] Docs updated (or issue created) https://docs.github.com/en/early-access/enterprise-importer/migrating-organizations-with-github-enterprise-importer/migrating-organizations-from-githubcom-to-github-enterprise-cloud

there were 2 integration test failures here, the first one I took a look at and it looked liked it would have been solved by a CLI retry when talking to ADO (Issue created).
I reran the build job, but this time it failed with what looks like a backend error. We've been trying really hard not to ignore integration test failure and track down what happened and file an appropriate issue to fix when appropriate. We used to file an on-call issue to investigate, but got some feedback in retro that it would be better if we did the investigation rather than relying on on-call.
Can you please do that here. Looks like the migration failed with some kind of SSL error. It's almost certainly transient (because the other integration test jobs succeeded), but we should file a bug to fix whatever needs to be fixed to prevent it.

Updated release notes looks better. :shipit:


No Information

This is what I get when I use google chrome
[DEBUG] Configuration file loaded. [DEBUG] [checkExistingCookieJar] Found existing cookie file. [DEBUG] [parseActualInformation] Sending request to parse actual data. [DEBUG] [checkForEmptyData] Empty/fake data detected. [DEBUG] [renewAuthentication] Sending request to parse the login form. [DEBUG] [renewAuthentication] Received RequestVerificationToken: ''. [DEBUG] [renewAuthentication] Sending authentication request. [DEBUG] [checkForCaptchaRequest] No captcha request detected. [DEBUG] [renewAuthentication] Successfuly authenticated. [DEBUG] [parseActualInformation] Sending request to parse actual data.

Please retry using version 1.4.0:
https://github.com/gta5-map/Social-Club-example-parser/releases/tag/1.4.0


Update test documentation

Taking from serving test/README(s), this updates the documentation
to run the unit tests and e2e tests locally.
/cc @shashwathi @ImJasonH
Signed-off-by: Vincent Demeester<EMAIL_ADDRESS>

/ok-to-test

/test pull-knative-build-unit-tests

I have added an issue to fix the unit tests

I would prefer adding a flag to e2e-tests.sh for running only the YAML or the go tests rather than duplicating code.


Add project to factory url using url parameter

This PR creates factory URLs in this format:
<che-host>/f?url=<git projectUrl>

instead of this format:
<che-host>/#<git project url>

To test this PR:

Build and sideload the extension: https://github.com/redhat-developer/try-in-dev-spaces-browser-extension#building-and-running-locally
Confirm that the 'Dev Spaces' button in GitHub can create workspaces

Tested on both Safari and Chrome. In general I think that keeping the factory url parameter rather than the # is safer and we should keep it like that.

Thanks @l0rd @ibuziuk , merging


fix the mca override cma configs issues

Summary
Related issue(s)
Fixes https://issues.redhat.com/browse/ACM-14863

/hold


[BUG] System.ComponentModel.Win32Exception: An error occurred trying to start process 'C:\Users\ZTS\AppData\Local\Bloxstrap\Roblox\Player\RobloxPlayerBeta.exe' with working directory 'C:\Users\ZTS\AppData\Local\Bloxstrap\Roblox\Player'. The requested operation requires elevation.

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.
[X] I have thoroughly looked through the available Wiki articles and could not find a solution to my problem.
[X] I am using the latest version of Bloxstrap.
[X] I did not answer truthfully to all the above checkboxes.

What problem did you encounter?
2024-10-18T08:22:21Z [App::OnStartup] Starting Bloxstrap v2.8.0
2024-10-18T08:22:21Z [App::OnStartup] Compiled Wednesday, 16 October 2024 at 4:44:37 PM from commit 42ffec26cf2e080fe22210305a08fcb286aeb577 (tag/v2.8.0)
2024-10-18T08:22:21Z [App::OnStartup] Loaded from %UserProfile%\AppData\Local\Bloxstrap\Bloxstrap.exe
2024-10-18T08:22:21Z [App::OnStartup] Temp path is %UserProfile%\AppData\Local\Temp\Bloxstrap
2024-10-18T08:22:21Z [App::OnStartup] WindowsStartMenu path is %UserProfile%\AppData\Roaming\Microsoft\Windows\Start Menu\Programs
2024-10-18T08:22:21Z [LaunchSettings] Identifier 'player' is active with data
2024-10-18T08:22:21Z [Logger::Initialize] Initializing at %UserProfile%\AppData\Local\Bloxstrap\Logs\Bloxstrap_20241018T082221Z.log
2024-10-18T08:22:21Z [Logger::Initialize] Finished initializing!
2024-10-18T08:22:21Z [JsonManager::Load] Loading from %UserProfile%\AppData\Local\Bloxstrap\Settings.json...
2024-10-18T08:22:21Z [JsonManager::Load] Loaded successfully!
2024-10-18T08:22:21Z [JsonManager::Load] Loading from %UserProfile%\AppData\Local\Bloxstrap\State.json...
2024-10-18T08:22:21Z [JsonManager::Load] Loaded successfully!
2024-10-18T08:22:21Z [FastFlagManager::Load] Loading from %UserProfile%\AppData\Local\Bloxstrap\Modifications\ClientSettings\ClientAppSettings.json...
2024-10-18T08:22:21Z [FastFlagManager::Load] Loaded successfully!
2024-10-18T08:22:21Z [FastFlagManager::SetValue] Setting of 'FLogNetwork' to '7' is pending
2024-10-18T08:22:21Z [LaunchHandler::LaunchRoblox] Initializing bootstrapper
2024-10-18T08:22:21Z [LaunchHandler::LaunchRoblox] Initializing bootstrapper dialog
2024-10-18T08:22:21Z [Bootstrapper::Run] Running bootstrapper
2024-10-18T08:22:21Z [Bootstrapper::SetStatus] Connecting to Roblox...
2024-10-18T08:22:21Z [Deployment::TestConnectionhttps://setup.rbxcdn.com] Connecting...
2024-10-18T08:22:21Z [HttpClientLoggingHandler::ProcessRequest] GET https://setup.rbxcdn.com/versionStudio
2024-10-18T08:22:21Z [Deployment::InitializeConnectivity] Testing connectivity...
2024-10-18T08:22:22Z [HttpClientLoggingHandler::ProcessResponse] 200 OK https://setup.rbxcdn.com/versionStudio
2024-10-18T08:22:22Z [Deployment::InitializeConnectivity] Got https://setup.rbxcdn.com as the optimal base URL
2024-10-18T08:22:22Z [Bootstrapper::Run] Connectivity check finished
2024-10-18T08:22:22Z [Bootstrapper::CheckForUpdates] Checking for updates...
2024-10-18T08:22:22Z [HttpClientLoggingHandler::ProcessRequest] GET https://api.github.com/repos/bloxstraplabs/bloxstrap/releases/latest
2024-10-18T08:22:22Z [HttpClientLoggingHandler::ProcessResponse] 403 rate limit exceeded https://api.github.com/repos/bloxstraplabs/bloxstrap/releases/latest
2024-10-18T08:22:22Z [App::GetLatestRelease] System.Net.Http.HttpRequestException: Response status code does not indicate success: 403 (rate limit exceeded).
at System.Net.Http.HttpResponseMessage.EnsureSuccessStatusCode()
at Bloxstrap.Utility.Http.GetJson[T](String url)
at Bloxstrap.App.GetLatestRelease()
2024-10-18T08:22:22Z [Bootstrapper::GetLatestVersionInfo] Got channel as production
2024-10-18T08:22:22Z [Deployment::GetInfo] Getting deploy info for channel production
2024-10-18T08:22:22Z [HttpClientLoggingHandler::ProcessRequest] GET https://clientsettingscdn.roblox.com/v2/client-version/WindowsPlayer
2024-10-18T08:22:22Z [HttpClientLoggingHandler::ProcessResponse] 200 OK https://clientsettingscdn.roblox.com/v2/client-version/WindowsPlayer
2024-10-18T08:22:22Z [RegistryKeyEx::SetValueSafe] Writing '' to HKEY_CURRENT_USER\SOFTWARE\ROBLOX Corporation\Environments\RobloxPlayer\Channel\www.roblox.com
2024-10-18T08:22:22Z [HttpClientLoggingHandler::ProcessRequest] GET https://setup.rbxcdn.com/version-9dbf9780562444e1-rbxPkgManifest.txt
2024-10-18T08:22:22Z [HttpClientLoggingHandler::ProcessResponse] 200 OK https://setup.rbxcdn.com/version-9dbf9780562444e1-rbxPkgManifest.txt
2024-10-18T08:22:22Z [Bootstrapper::SetStatus] Applying Roblox modifications...
2024-10-18T08:22:22Z [Bootstrapper::ApplyModifications] Checking file mods...
2024-10-18T08:22:22Z [Bootstrapper::ApplyModifications] ClientSettings\ClientAppSettings.json already exists in the version folder, and is a match
2024-10-18T08:22:22Z [JsonManager::Save] Saving to %UserProfile%\AppData\Local\Bloxstrap\State.json...
2024-10-18T08:22:22Z [JsonManager::Save] Save complete!
2024-10-18T08:22:22Z [Bootstrapper::ApplyModifications] Finished checking file mods
2024-10-18T08:22:22Z [Bootstrapper::SetStatus] Starting {product}...
2024-10-18T08:22:22Z [LaunchHandler::LaunchRoblox] Bootstrapper task has finished
2024-10-18T08:22:22Z [LaunchHandler::LaunchRoblox] An exception occurred when running the bootstrapper
2024-10-18T08:22:22Z [App::FinalizeExceptionHandling] System.ComponentModel.Win32Exception (740): An error occurred trying to start process '%UserProfile%\AppData\Local\Bloxstrap\Roblox\Player\RobloxPlayerBeta.exe' with working directory '%UserProfile%\AppData\Local\Bloxstrap\Roblox\Player'. The requested operation requires elevation.
at System.Diagnostics.Process.StartWithCreateProcess(ProcessStartInfo startInfo)
at System.Diagnostics.Process.Start()
at System.Diagnostics.Process.Start(ProcessStartInfo startInfo)
at Bloxstrap.Bootstrapper.StartRoblox()
at Bloxstrap.Bootstrapper.Run()
at Bloxstrap.Bootstrapper.Run()
Bloxstrap Log
2024-10-18T08:22:21Z [App::OnStartup] Starting Bloxstrap v2.8.0
2024-10-18T08:22:21Z [App::OnStartup] Compiled Wednesday, 16 October 2024 at 4:44:37 PM from commit 42ffec26cf2e080fe22210305a08fcb286aeb577 (tag/v2.8.0)
2024-10-18T08:22:21Z [App::OnStartup] Loaded from %UserProfile%\AppData\Local\Bloxstrap\Bloxstrap.exe
2024-10-18T08:22:21Z [App::OnStartup] Temp path is %UserProfile%\AppData\Local\Temp\Bloxstrap
2024-10-18T08:22:21Z [App::OnStartup] WindowsStartMenu path is %UserProfile%\AppData\Roaming\Microsoft\Windows\Start Menu\Programs
2024-10-18T08:22:21Z [LaunchSettings] Identifier 'player' is active with data
2024-10-18T08:22:21Z [Logger::Initialize] Initializing at %UserProfile%\AppData\Local\Bloxstrap\Logs\Bloxstrap_20241018T082221Z.log
2024-10-18T08:22:21Z [Logger::Initialize] Finished initializing!
2024-10-18T08:22:21Z [JsonManager::Load] Loading from %UserProfile%\AppData\Local\Bloxstrap\Settings.json...
2024-10-18T08:22:21Z [JsonManager::Load] Loaded successfully!
2024-10-18T08:22:21Z [JsonManager::Load] Loading from %UserProfile%\AppData\Local\Bloxstrap\State.json...
2024-10-18T08:22:21Z [JsonManager::Load] Loaded successfully!
2024-10-18T08:22:21Z [FastFlagManager::Load] Loading from %UserProfile%\AppData\Local\Bloxstrap\Modifications\ClientSettings\ClientAppSettings.json...
2024-10-18T08:22:21Z [FastFlagManager::Load] Loaded successfully!
2024-10-18T08:22:21Z [FastFlagManager::SetValue] Setting of 'FLogNetwork' to '7' is pending
2024-10-18T08:22:21Z [LaunchHandler::LaunchRoblox] Initializing bootstrapper
2024-10-18T08:22:21Z [LaunchHandler::LaunchRoblox] Initializing bootstrapper dialog
2024-10-18T08:22:21Z [Bootstrapper::Run] Running bootstrapper
2024-10-18T08:22:21Z [Bootstrapper::SetStatus] Connecting to Roblox...
2024-10-18T08:22:21Z [Deployment::TestConnectionhttps://setup.rbxcdn.com] Connecting...
2024-10-18T08:22:21Z [HttpClientLoggingHandler::ProcessRequest] GET https://setup.rbxcdn.com/versionStudio
2024-10-18T08:22:21Z [Deployment::InitializeConnectivity] Testing connectivity...
2024-10-18T08:22:22Z [HttpClientLoggingHandler::ProcessResponse] 200 OK https://setup.rbxcdn.com/versionStudio
2024-10-18T08:22:22Z [Deployment::InitializeConnectivity] Got https://setup.rbxcdn.com as the optimal base URL
2024-10-18T08:22:22Z [Bootstrapper::Run] Connectivity check finished
2024-10-18T08:22:22Z [Bootstrapper::CheckForUpdates] Checking for updates...
2024-10-18T08:22:22Z [HttpClientLoggingHandler::ProcessRequest] GET https://api.github.com/repos/bloxstraplabs/bloxstrap/releases/latest
2024-10-18T08:22:22Z [HttpClientLoggingHandler::ProcessResponse] 403 rate limit exceeded https://api.github.com/repos/bloxstraplabs/bloxstrap/releases/latest
2024-10-18T08:22:22Z [App::GetLatestRelease] System.Net.Http.HttpRequestException: Response status code does not indicate success: 403 (rate limit exceeded).
at System.Net.Http.HttpResponseMessage.EnsureSuccessStatusCode()
at Bloxstrap.Utility.Http.GetJson[T](String url)
at Bloxstrap.App.GetLatestRelease()
2024-10-18T08:22:22Z [Bootstrapper::GetLatestVersionInfo] Got channel as production
2024-10-18T08:22:22Z [Deployment::GetInfo] Getting deploy info for channel production
2024-10-18T08:22:22Z [HttpClientLoggingHandler::ProcessRequest] GET https://clientsettingscdn.roblox.com/v2/client-version/WindowsPlayer
2024-10-18T08:22:22Z [HttpClientLoggingHandler::ProcessResponse] 200 OK https://clientsettingscdn.roblox.com/v2/client-version/WindowsPlayer
2024-10-18T08:22:22Z [RegistryKeyEx::SetValueSafe] Writing '' to HKEY_CURRENT_USER\SOFTWARE\ROBLOX Corporation\Environments\RobloxPlayer\Channel\www.roblox.com
2024-10-18T08:22:22Z [HttpClientLoggingHandler::ProcessRequest] GET https://setup.rbxcdn.com/version-9dbf9780562444e1-rbxPkgManifest.txt
2024-10-18T08:22:22Z [HttpClientLoggingHandler::ProcessResponse] 200 OK https://setup.rbxcdn.com/version-9dbf9780562444e1-rbxPkgManifest.txt
2024-10-18T08:22:22Z [Bootstrapper::SetStatus] Applying Roblox modifications...
2024-10-18T08:22:22Z [Bootstrapper::ApplyModifications] Checking file mods...
2024-10-18T08:22:22Z [Bootstrapper::ApplyModifications] ClientSettings\ClientAppSettings.json already exists in the version folder, and is a match
2024-10-18T08:22:22Z [JsonManager::Save] Saving to %UserProfile%\AppData\Local\Bloxstrap\State.json...
2024-10-18T08:22:22Z [JsonManager::Save] Save complete!
2024-10-18T08:22:22Z [Bootstrapper::ApplyModifications] Finished checking file mods
2024-10-18T08:22:22Z [Bootstrapper::SetStatus] Starting {product}...
2024-10-18T08:22:22Z [LaunchHandler::LaunchRoblox] Bootstrapper task has finished
2024-10-18T08:22:22Z [LaunchHandler::LaunchRoblox] An exception occurred when running the bootstrapper
2024-10-18T08:22:22Z [App::FinalizeExceptionHandling] System.ComponentModel.Win32Exception (740): An error occurred trying to start process '%UserProfile%\AppData\Local\Bloxstrap\Roblox\Player\RobloxPlayerBeta.exe' with working directory '%UserProfile%\AppData\Local\Bloxstrap\Roblox\Player'. The requested operation requires elevation.
at System.Diagnostics.Process.StartWithCreateProcess(ProcessStartInfo startInfo)
at System.Diagnostics.Process.Start()
at System.Diagnostics.Process.Start(ProcessStartInfo startInfo)
at Bloxstrap.Bootstrapper.StartRoblox()
at Bloxstrap.Bootstrapper.Run()
at Bloxstrap.Bootstrapper.Run()

i already try re-install roblox and bloxstrap but still not working

solved , thank you pizzaboxer
https://github.com/bloxstraplabs/bloxstrap/issues/3274#issuecomment-2420390038


Regex analysis not supported on docker

Regex analysis not supported on docker

@yubiuser , please have a look at my PR #39

Currently, PR https://github.com/yubiuser/pihole_adlist_tool/pull/40 mitigates the issue by disabling RegEx mode on docker even if users have been enabling RegEx analysis.


bad formating on js file - arrow-parens

Do you want to request a feature or report a bug?
report a bug
What is the current/expected behavior?

when prettier format the file it have issues with the arrow-parens.
should be success => {}. but prettier is changing it to (success) => {} and I'm getting an error from plugin:prettier/recommended , I guess.
the error message is [eslint prettier/prettier] [E] Replace `(success)` with `success` .
so the code is correct and prettier is formatting it in the wrong way.

What version of vim-prettier are you using - (output of :PrettierVersion) ?
1.0.0-beta
What version of prettier are you using - (output of  :PrettierCliVersion) ?
1.19.1^@
What is your prettier executable path - (output of  :PrettierCliPath) ?
/Users/username/Sites/project/src/www/frontend/node_modules/.bin/prettier
Did this work in previous versions of vim-prettier and/or prettier ?

I'm also getting this.

Prettier arrow function parentheses v1.9.* and below defaults to "avoid", but v2.0.0 default to "always"
vim-prettier defaults to "always" no matter the version.
You can update the default prettier config with:
let g:prettier#config#arrow_parens = 'avoid'


Failed to parse component during vuese gen

Describe the bug
Calling vuese gen produced an error and the component was not rendered.
To Reproduce
Steps to reproduce the behavior:

Install vuese
Call vuese gen at document root.

Expected behavior
No errors.
Environmental information:
Environment Info:
System:
OS: Linux 3.10 CentOS Linux 7 (Core)
CPU: (2) x64 Intel(R) Xeon(R) CPU E5-2640 v2 @ 2.00GHz
Binaries:
Node: 10.8.0 - /var/---/bin/node
npm: 6.11.3 - /var/---/bin/npm
Additional information

Add any other information about the problem here.
�  The error occurred when processing: /var/www/---/---/my-app/src/components/OPickList.vue
�  TypeError: Cannot read property 'filter' of undefined
at ObjectProperty (/var/www/---/node_modules/@vuese/parser/dist/index.js:653:61)
at NodePath._call (/var/www/---/node_modules/@babel/traverse/lib/path/context.js:53:20)
at NodePath.call (/var/www/---/node_modules/@babel/traverse/lib/path/context.js:40:17)
at NodePath.visit (/var/www/---/node_modules/@babel/traverse/lib/path/context.js:88:12)
at TraversalContext.visitQueue (/var/www/---/node_modules/@babel/traverse/lib/context.js:120:16)
at TraversalContext.visitMultiple (/var/www/---/node_modules/@babel/traverse/lib/context.js:87:17)
at TraversalContext.visit (/var/www/---/node_modules/@babel/traverse/lib/context.js:146:19)
at Function.traverse.node (/var/www/---/node_modules/@babel/traverse/lib/index.js:96:17)
at NodePath.visit (/var/www/---/node_modules/@babel/traverse/lib/path/context.js:95:18)
at TraversalContext.visitQueue (/var/www/---/node_modules/@babel/traverse/lib/context.js:120:16)

Might be related to: https://github.com/babel/babel/issues/9495

Note: Some components worked, some did not. Also, you might ask I'd rather not give you my code. I might slim the component down to find out where the error is later, but I just wanted to open the ticket for now.

I have discovered the following:
Defining the data function like this results in an error:
data: () => {
  return {}
}

Defining it like this does not result in an error:
data() {
  return {}
}

Awesome, thank you.


Math: Dot parsing depends on space being after it.

Description
This dot is parsed as text $step(phi.alt. )$
This one is parsed as a field access dot: $step(phi.alt.)$
Bug? encountered while trying to fix my formatter .
I think both should be parsed as field access and if you wan't text, you write phi.alt . instead.
I would be interested to fix it.
Reproduction URL
No response
Operating system
Linux
Typst version

[X] I am using the latest version of Typst

This is actually intended. In markup, Hello #world. should just access the world variable at the end of a sentence, instead of giving an error about a missing field. In math, it works the same.

Okay, so this is only half intended. The parenthesis thing is a bug. The first one is working as intended.

Fair enough, what should the second be then, a Text(".") followed by RighParen ?

Yep.

I'll take a stab at it!

I always get a really hard time contributing to the parser, it's so hard to pinpoint where something is happening! advices, anyone? (@Marmare314 ? 🙄)

The problem is in this line: https://github.com/typst/typst/blob/bcab77052422baaa29b57b62f14a19af8cc87225/crates/typst-syntax/src/parser.rs#L265
We check for MathIdent or Text, but "(" is also text, so we should check whether the actual text is_ident.


use in ethereumjs-block

Would it make sense to have this as a method on ethereumjs-block? it could exports toIPLD and fromIPLD

good question! it would mean pulling in more deps for eth-block. we should keep eth-block simple. I think they are fine separate for now.

ok sounds good. So when I pull a ethereum-block from the DAG service, will I get a etheruemjs-block or just the raw buffer?

So really what you want here is just to parse the block. So maybe we should make just a standalone block parser that js-ipld-eth-block and ethereumjs-block uses. B/c as it stands now js-ipld-eth-block use ethereumjs-block to do parsing. But ethereumks-block all has all the logic to do validation (which is quite alot).

No, we don't need the validation. Maybe we can move to something more minimal. Right now ethereumjs-block is pulling in ethereumjs-util which brings in all our crypto.
In the case of the tx, we need the crypto to pull out the from address from the signature, so its slightly more involved than just parsing.


Address information not found

Hey guys, I noticed that some early addresses are not shown when using insight API, for example:
Address: 124wRWVmAkRejjv6aPuF3B4qi5ww4uYKLy

insight.bitpay.com
blockchain.com

Any ideas?
Thanks in advance!

I wonder if this is still being maintained.


How to compare two separate eval runs in the Web UI

In the config, if I've defined two prompts, or two providers, I see the side-by-side results in the Web UI.
What about the situation if I or someone else have run an eval on a single prompt or provider, and want to combine our two results and see them in the promptfoo Web UI?  Can that be done?

Two thoughts on how to solve this:

Purely on the UI side, have a way to select existing evals to include in the view, or
Add a 'promptfoo eval merge` CLI command or similar that lets you select evals to combine together.  This will enable better first-class support for share, export, etc.

Purely on the UI side, have a way to select existing evals to include in the view, or

I like this UI solution for the use case of multiple collaborators running their own evals, then wanting to do comparisons among the eval runs.
Merging evals together might have its own use cases, but I think would be cumbersome for browsing.

"Compare evals" functionality landed in the UI under Table Settings


Configurable HTTP proxy

Is it/would it be possible to configure this gem to make HTTP calls via a proxy? Possibly via an extra configuration item:
Authy.http_proxy = 'http://myproxy:8080'

Then included in the call to IncludeClient in api.rb or something similar:
include_http_client(Authy.http_proxy, ...

This functionality is very important, especially for computers with Internet access via static or authenticated Proxy.

This project uses httpclient to make requests. You can provide a proxy to httpclient by setting the HTTP_PROXY environment variable.
I will also note that we currently recommend the use of Twilio Verify. The Verify API is an evolution of the Authy API and is where new features are built. The Verify API can be used with the twilio-ruby gem which also supports providing a proxy via a custom HTTP client.
I'm going to close this issue, but please let me know if you have any other questions.


Sort by OT/NT

If I wish to only search in the OT/NT. Even a certain book only, can this feature be added?

I don't see any reason why it couldn't be added. How would you imagine the UX? For the website, we could do an options modal with checkboxes, perhaps.
Given the way ranking currently works the filter could be put in place while scoring verses, or at least before we limit the number of results.

This is an app which I currently use here's how it deals with that issue. It's a proprietary software therefore I don't know how much we can "copy" from. We can simply get the inspiration from that design to keep it as clean as possible. I like the current clean and simple design we have.


Notify plugin if tile was selected/deslected

I'm trying to find a way to notify a plugin that it's tile has been selected or deselected in order to perform some logic. It doesn't seem to be built in functionality, is this something that could be done?

Closing this, I determined there is no way to do this using pGina as it is. I ended up rolling my own message and sending it to the plugin once a tile was selected and deselected.

Apologies for not getting back to you sooner - yes, you are correct - not built into pGina today, but adding a new message sent from the CP when selection/deselection happens would be the right approach.
Patches/pull requests welcome! :)

Np, I have some very specific changes to my current branch, but I'll go ahead and create a pr for this.


Callback with $ref is not working

Consider this input file:
openapi: 3.0.0
info:
  title: Callback with ref Example
  version: 1.0.0
paths:
  /register:
    post:
      summary: Subscribe to a webhook
      requestBody:
        required: true
        content:
          application/json:
            schema:
              type: object
              properties:
                callbackUrl: # Callback URL
                  type: string
                  format: uri
                  example: https://myserver.com/send/callback/here
              required:
                - callbackUrl
      responses:
        '200':
          description: subscription successfully created
          content:
            application/json:
              schema:
                type: object
                description: subscription information
                required:
                  - subscriptionId
                properties:
                  subscriptionId:
                    description: unique identifier
                    type: string
                    example: 2531329f-fb09-4ef7-887e-84e648214436
      callbacks:
        myEvent:
          $ref: '#/components/callbacks/callbackEvent'
components:
  callbacks:
    callbackEvent:
      '{$request.body#/callbackUrl}':
        post:
          requestBody: # Contents of the callback message
            required: true
            content:
              application/json:
                schema:
                  type: object
                  properties:
                    message:
                      type: string
                      example: Some event happened
                  required:
                    - message
          responses:
            '200':
              description: ok

Test code:
final String inputSpec = /* path */;

OpenAPIParser openApiParser = new OpenAPIParser();
ParseOptions options = new ParseOptions();
OpenAPI openAPI = openApiParser.readLocation(inputSpec, null, options).getOpenAPI();

String ref = openAPI.getPaths()
                       .get("/register")
                       .getPost()
                       .getCallbacks()
                       .get("myEvent")
                       .get$ref();
System.out.println(ref);

ref should contain: #/components/callbacks/callbackEvent
current result is null.
Tested with:
<dependency>
  <groupId>io.swagger.parser.v3</groupId>
  <artifactId>swagger-parser</artifactId>
  <version>2.0.5</version>
</dependency>

Hi @jmini,
Reason for this issue is https://github.com/swagger-api/swagger-core/issues/2638 which is fixed in swagger-core but not reflected in swagger-parser.
I have raised PR to fix this issue https://github.com/swagger-api/swagger-parser/pull/880
Thanks,
Mohammed

Fixed by #880


Updated README and one-liner

I added debugging to the cron job, because I always do. But if you think we shouldn't - go ahead and take it back out. And - I also removed the locale change, as Stu found it's not actually necessary.


Drop Ruby < 2.3 support

Better viewed as https://github.com/rspec/rspec-core/pull/2787/files?diff=split&w=1
Sibling PRs:

https://github.com/rspec/rspec-support/pull/436
https://github.com/rspec/rspec-mocks/pull/1349
https://github.com/rspec/rspec-expectations/pull/1231

TODO (not all):

[x] def self.ensure_example_groups_are_configured
[x] lib/rspec/core/test_unit_assertions_adapter.rb
[x] For some reason JRuby doesn't like our improved bundler setup
[x] echo "WARNING: Cucumber is skipped on JRuby on rspec-core due to" \
[-] (class << self; self; end) -> singleton_class
[x] move simplecov and test-unit to gemspec
[#] Mini[t|T]est - always Minitest
[x] extract changes from build scripts to rspec-dev and send as pr to 4-0-dev

I'll handle reverting jruby_version change here and other repos, and will remove MatchData tomorrow, or over the weekend. Thanks for the reviews!

Thanks for the reviews!

Thanks for the hard work!

Update:

reverted jruby_version removals
accepted Changelist "breaking changes" section proposed change

Updates:

reverted changes to gemspec
accepted proposed changes
added (a reduced version of) comment to Mini[t|T]est adapter

There's definitely something wrong with rubocop.
It should fail, but sometimes it does and sometimes not.
I'll figure it out later. Meanwhile reverted.

Restored the branch, rspec-support depends on it.


feat(hesai): software-based precise FoV limit & early publishing

PR Type

New Feature

Description
This PR introduces software-based FoV limits and early publishing for Hesai sensors.
Software-based FoV
Previously, configuring cloud_min_angle and cloud_max_angle would set the sensor's hardware filter to those values.
However, the hardware filter is using raw azimuths.
This lead to the scan having jagged edges (points missing in some channels, too many points in others).
For certain models, this affected areas of up to ~10deg on both edges of the FoV.
This PR improves upon this in the following way:

User sets cloud_min_angle and cloud_max_angle to the exact FoV they want the output pointcloud to have
Nebula retrieves sensor calibration file and computes appropriately over-sized* hardware-FoV
Nebula sends hardware-FoV to sensor (or validates it if setup_sensor == false)
The Nebula decoder cuts the scan at the exact edges defined via the parameters above

Early publishing
Previously, a scan was published once the packet after it was received. This was done because this made the scan completion check easier (could compare 2 azimuths according to some scan completion criterion).
For scans of 360deg, this is not a problem, as there is no time gap between the end of one scan and the beginning of the next.
However, for FoVs < 360deg, this approach increases latency unnecessarily: for an FoV of 180deg and 1 full rotation every 100ms, the additional latency of the finished pointcloud just "sitting there" is 50ms.
This PR improves upon this in the following way:

Swap the order of decoding and scan completion check: decode first, then check for completion
Check if the current packet completed the current scan, as opposed to whether the current packet is the first belonging to the next scan

Other
For testing this PR with AT128, I had to fix the LidarRange issue:

fixes #129

This was done by checking the sensor model before sending the LidarRange command.
Review Procedure
Check for the following FoVs

0 - 360 deg
90 - 270 deg
270 - 90 deg
if the pointcloud in Rviz has clean edges at those angles for a 360 deg sensor such as OT128.

Check AT128 in the same way but with FoVs inside [30; 150].
Remarks
These two improvements have been combined into one PR as they are closely related and would require extra work to function independently.
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.

[x] Assign PR to reviewer

Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.

[ ] Commits are properly organized and messages are according to the guideline
[x] (Optional) Unit tests have been written for new behavior
[ ] PR title describes the changes

Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.

[ ] All open points are addressed and tracked via issues or tickets

CI Checks

Build and test for PR: Required to pass before the merge.

:construction: Evaluation
:green_circle: 360deg rotational sensors

FoV Setting (min, max)
Resulting pointcloud

0, 360

90, 270

270, 90

29, 30

360, 0

:green_circle: AT128 (120deg rotational sensor)

FoV Setting (min, max)
Resulting pointcloud

0, 360

30, 150

60, 120

89, 90

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 32.00000% with 221 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@8a78e79). Learn more about missing BASE report.

Files
Patch %
Lines

nebula_ros/src/hesai/hesai_ros_wrapper.cpp
0.00%
106 Missing :warning:

.../nebula_hesai_hw_interfaces/hesai_hw_interface.cpp
0.00%
38 Missing :warning:

...esai/decoders/angle_corrector_correction_based.hpp
58.62%
5 Missing and 19 partials :warning:

...sai/decoders/angle_corrector_calibration_based.hpp
67.64%
5 Missing and 6 partials :warning:

nebula_tests/hesai/hesai_ros_decoder_test.cpp
50.00%
0 Missing and 8 partials :warning:

...es/src/hesai/hesai_ros_offline_extract_bag_pcd.cpp
0.00%
7 Missing :warning:

...amples/src/hesai/hesai_ros_offline_extract_pcd.cpp
0.00%
7 Missing :warning:

nebula_ros/src/hesai/decoder_wrapper.cpp
0.00%
7 Missing :warning:

.../nebula_decoders/nebula_decoders_common/angles.hpp
20.00%
0 Missing and 4 partials :warning:

...s/nebula_decoders_hesai/decoders/hesai_decoder.hpp
89.18%
0 Missing and 4 partials :warning:

... and 4 more

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #173   +/-   ##
==========================================
  Coverage           ?   15.63%
==========================================
  Files              ?       94
  Lines              ?     9059
  Branches           ?     1585
==========================================
  Hits               ?     1416
  Misses             ?     6522
  Partials           ?     1121

Flag
Coverage Δ

differential
15.63% <32.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@drwnz Thank you for the review!
I have addressed your comments and re-tested setting the cut_angle parameter to a value outside of the FoV.
Nebula now properly emits an error:
[INFO] [hesai_ros_wrapper_node]: OnParameterChange
[ERROR] [hesai_ros_wrapper_node]: Cannot cut scan outside of the FoV.
[WARN] [hesai_ros_wrapper_node]: OnParameterChange aborted: Could not set SensorConfiguration

The fix is in this commit: 2e42bd0


Outlook msg file renamed to doc (content is still intact and good)

VALIDATION:
Naive Name: UAT-CR1340 CRWEB_1965_Corectie-facturare-abonament-in-perioada-deco-1-1.msg
Naive Extension: msg
Naive Type: message/rfc822
Magic Type: application/cdfv2
Best Type: application/msword
FINAL:
Name: UAT-CR1340 CRWEB_1965_Corectie-facturare-abonament-in-perioada-deco-1-1.doc
Extension: doc
Type: application/msword
Code: 75
SYSTEM:
Kernel: Linux webtop.vra.ro 3.10.0-1127.8.2.el7.x86_64 #1 SMP Tue May 12 16:57:42 UTC 2020 x86_64
PHP: 7.3.17
Modules: Core; PDO; PDO_ODBC; Phar; Reflection; SPL; SimpleXML; Zend OPcache; apcu; bcmath; bz2; calendar; cgi-fcgi; ctype; curl; date; dba; dom; enchant; exif; fileinfo; filter; ftp; gd; gettext; gmp; hash; iconv; imap; intl; ionCube Loader; json; ldap; libxml; mbstring; memcached; mysqli; mysqlnd; odbc; openssl; pcntl; pcre; pdo_mysql; pdo_pgsql; pdo_sqlite; pgsql; posix; pspell; session; shmop; snmp; soap; sockets; sqlite3; standard; sysvmsg; sysvsem; sysvshm; tidy; tokenizer; wddx; xml; xmlreader; xmlrpc; xmlwriter; xsl; zip; zlib
WordPress: 5.4.1
Plugins: acf [5.8.11]; advanced-database-cleaner [3.0.0]; all-in-one-wp-migration [7.22]; all-in-one-wp-migration-file-extension [1.6]; application-passwords [0.1.1]; blob-mimes [1.1.2]; cm-tooltip-glossary [3.7.1]; flush-opcache [3.0.2]; formidable [4.04.04]; formidable-api [1.08]; formidable-logs [1.0b1]; formidable-pro [4.04.04]; frmdates [1.0.04]; frmmodal [2.0]; frmreg [2.02.02]; gutenberg [8.1.0]; import-users-from-csv [1.0.1]; members [3.0.8]; richard-rest-api [1.0]; richard-rest-api [1.0]; ultimate-addons-for-gutenberg [1.14.11]; user-switching [1.5.4]; wp-jquery-datatable-richard [2.0.1]; wp-mail-smtp [2.0.1]; wpo365-login [10.6]
Theme: chique [1.0.1]

Other msg files are correct
RE CR ESD-74 (CRWEB 2102) - Plata online neautentificat - aprobare transport in productiv.msg
Naive Extension:
msg
Naive Type:
message/rfc822
Magic Type:
application/vnd.ms-outlook
Best Type:
application/vnd.ms-outlook
FINAL
Name:
RE CR ESD-74 (CRWEB 2102) - Plata online neautentificat - aprobare transport in productiv.msg
Extension:
msg
Type:
message/rfc822
Code:
77
SYSTEM
Kernel:
Linux webtop.vra.ro 3.10.0-1127.8.2.el7.x86_64 #1 SMP Tue May 12 16:57:42 UTC 2020 x86_64
PHP:
7.3.17
Modules:
Core; PDO; PDO_ODBC; Phar; Reflection; SPL; SimpleXML; Zend OPcache; apcu; bcmath; bz2; calendar; cgi-fcgi; ctype; curl; date; dba; dom; enchant; exif; fileinfo; filter; ftp; gd; gettext; gmp; hash; iconv; imap; intl; ionCube Loader; json; ldap; libxml; mbstring; memcached; mysqli; mysqlnd; odbc; openssl; pcntl; pcre; pdo_mysql; pdo_pgsql; pdo_sqlite; pgsql; posix; pspell; session; shmop; snmp; soap; sockets; sqlite3; standard; sysvmsg; sysvsem; sysvshm; tidy; tokenizer; wddx; xml; xmlreader; xmlrpc; xmlwriter; xsl; zip; zlib
WordPress:
5.4.1
Plugins:
acf [5.8.11]; advanced-database-cleaner [3.0.0]; all-in-one-wp-migration [7.22]; all-in-one-wp-migration-file-extension [1.6]; application-passwords [0.1.1]; blob-mimes [1.1.2]; cm-tooltip-glossary [3.7.1]; flush-opcache [3.0.2]; formidable [4.04.04]; formidable-api [1.08]; formidable-logs [1.0b1]; formidable-pro [4.04.04]; frmdates [1.0.04]; frmmodal [2.0]; frmreg [2.02.02]; gutenberg [8.1.0]; import-users-from-csv [1.0.1]; members [3.0.8]; richard-rest-api [1.0]; richard-rest-api [1.0]; ultimate-addons-for-gutenberg [1.14.11]; user-switching [1.5.4]; wp-jquery-datatable-richard [2.0.1]; wp-mail-smtp [2.0.1]; wpo365-login [10.6]
Theme:
chique [1.0.1]

At this stage I suspect the Outlook version that exported the first file is old, the second file is exported with contemporary Outlook 365

At this stage I suspect the Outlook version that exported the first file is old, the second file is exported with contemporary Outlook 365

Not true, version difference is minor... Something inside the file content is different.

Hi @rvencu,
Thanks for reporting the issue!
The application/CDVF2[…] pseudo-type is something that gets assigned to all sorts of different Microsoft-generated documents when those documents contain encrypted data. I haven't personally encountered one from Outlook before, but it fits. Haha.
Is there any way you could send me a copy of that file for testing (or export a dummy message with the same settings and CDVF2 behavior)? You can shoot me a private download link at<EMAIL_ADDRESS>to keep it off the public issue page.
If the content is too sensitive or you don't have the access to do that, no worries. It's just easier when there's a known file to test workarounds against. :wink:

Thanks sent it from my business email few seconds ago.

Thank you @rvencu!
Indeed, this file's header bytes identify it as an application/CDFV2-corrupt file rather than an application/vnd.ms-outlook file.
Thankfully, the same workarounds used for other Microsoft Office file types work — at least in my test environment — for encrypted msg files too, so getting a fix out was relatively easy.
When you have a moment, please try updating your site's copy of Lord of the Files to 1.1.3 and then give the message upload another shot. (Just be sure the copy you upload has the original .msg extension or WordPress will likely keep it as a .doc.) Oh, and please let me know how it goes!
Thanks again for taking the time to do this back-and-forth. It's a pain. But if one person has this problem, hundreds probably do, and many of them probably have no idea where to even begin. :wink:

Thanks, after update / clearing server cache it went through
VALIDATION:
Naive Name: UAT-CR1340 CRWEB_1965_Corectie-facturare-abonament-in-perioada-deco-1-1.msg
Naive Extension: msg
Naive Type: application/vnd.ms-outlook
Magic Type: application/cdfv2
Best Type: application/vnd.ms-outlook
FINAL:
Name: UAT-CR1340 CRWEB_1965_Corectie-facturare-abonament-in-perioada-deco-1-1.msg
Extension: msg
Type: application/vnd.ms-outlook
Code: 77
SYSTEM:
Kernel: Linux webtop.vra.ro 3.10.0-1127.8.2.el7.x86_64 #1 SMP Tue May 12 16:57:42 UTC 2020 x86_64
PHP: 7.3.17
Modules: Core; PDO; PDO_ODBC; Phar; Reflection; SPL; SimpleXML; Zend OPcache; apcu; bcmath; bz2; calendar; cgi-fcgi; ctype; curl; date; dba; dom; enchant; exif; fileinfo; filter; ftp; gd; gettext; gmp; hash; iconv; imap; intl; ionCube Loader; json; ldap; libxml; mbstring; memcached; mysqli; mysqlnd; odbc; openssl; pcntl; pcre; pdo_mysql; pdo_pgsql; pdo_sqlite; pgsql; posix; pspell; session; shmop; snmp; soap; sockets; sqlite3; standard; sysvmsg; sysvsem; sysvshm; tidy; tokenizer; wddx; xml; xmlreader; xmlrpc; xmlwriter; xsl; zip; zlib
WordPress: 5.4.1
Plugins: acf [5.8.11]; advanced-database-cleaner [3.0.0]; all-in-one-wp-migration [7.22]; all-in-one-wp-migration-file-extension [1.6]; application-passwords [0.1.1]; blob-mimes [1.1.3]; cm-tooltip-glossary [3.7.1]; flush-opcache [3.0.2]; formidable [4.04.04]; formidable-api [1.08]; formidable-logs [1.0b1]; formidable-pro [4.04.04]; frmdates [1.0.04]; frmmodal [2.0]; frmreg [2.02.02]; gutenberg [8.1.0]; import-users-from-csv [1.0.1]; members [3.0.8]; richard-rest-api [1.0]; richard-rest-api [1.0]; ultimate-addons-for-gutenberg [1.14.11]; user-switching [1.5.4]; wp-jquery-datatable-richard [2.0.1]; wp-mail-smtp [2.0.1]; wpo365-login [10.6]
Theme: chique [1.0.1]

So, I also take this opportunity to praise your work. Glad to stumble upon it 👍
Thanks a lot.

Excellent! I'm glad to hear it is working for you!


Implement ASAP() smoother

From using Datadog, I've come to find their autosmooth()-function very handy when dealing with "spiky" data series.
Their implementation (blog post) is inspired by the ASAP smoother (Automatic Smoothing for Attention Prioritization; homepage, PDF paper).
While it is not perfect for every use-case, I have found it to work extremely well compared to hand-tuning some "average over X minutes" until a pattern actually emerges, yet it doesn't hide actual spikes.
Example from the ASAP homepage:

Just to follow up, this was the Grafana response:

This should be implemented in the database (TSDB) before aggregation, not client side by Grafana.

You can try something with the _over_time functions, but as I said this can't be done in PromQL generally.

I guess it would be possible to implement something similar in PromQL where you pass in a large-enough window to cover all use cases, and then the algorithm decides within that window which section to use for averaging, depending on the shape of the rest of the data under that window. But that would be inefficient to do that general shape computation again and again for each eval timestamp.

I recall playing with an implementation like that - copy/pasted from avg_over_time (if memory serves) and began porting their online JS implementation over, though I never really got it working.
Skimming the paper, there is a "Streaming ASAP" (section 4.5), which reads along the lines of what @juliusv suggests.

Please note that porting datadog's javascript proprietary code in golang is probably not be legal. It might be better to start from the PDF only, if that's allowed.

Please note that porting datadog's javascript proprietary code in golang is probably not be legal. It might be better to start from the PDF only, if that's allowed.

I poked at the code provided along with the paper at https://github.com/stanford-futuredata/ASAP, which is Apache 2.0.

By the way predict linear is also a function looking back in time that takes a duration as parameters, maybe some inspiration can be taken there

We are currentlly doing a bug scrub.
This is currently beyond the scope of Prometheus & PromQL, but we will discuss these types of use cases at the next dev summit. Depending on what's the result of that, we will implement or close this issue.

From my experience with using ASAP, I definitely think it would be a win for Prometheus.
As to implementation, I recall that the streaming variant isn't far from Promenetus' running average code (though it would probably need a bigger window to produce the desired output).

Noice!
Sent by mobile; please excuse my brevity.
On Fri, Jul 24, 2020, 21:05 Julien Pivotto<EMAIL_ADDRESS>wrote:

[image: ASAP]
https://user-images.githubusercontent.com/291750/88426339-4bc16780-cdf1-11ea-8568-4bcc9e16f706.png
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/prometheus/prometheus/issues/5094#issuecomment-663688043,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFYII2LT43L7HJGAEUOEQTR5HLN5ANCNFSM4GPX6HSQ
.

Do we plan to implement this?

This would not be a simple function but rather creating a brand new language.

Or a new option in the query_range API for post-processing with ASAP as one of the option (while also opening doors for other relevant ones to be implemented in future). I am just thinking out loud and this might not be a feasible option.

That is something that could in theory work, but that's still tending towards creating a brand new language.

I feel this could be done without a new language. It could be a list of post processors to be applied in sequence. The input to to API could be something like post_processors: [ "postprocessor1", "postprocessor2", ... ], and if the post processors need any arguments, then post_processors: [ "postprocessor1", "postprocessor2(10, 7)", ... ] (this does assume that the post processing is on the final data and not for a subquery).

That smells suspiciously like a new language.

my opinion is that asap smoother should run on ALL samples (not limited to stepped samples)


Ticket creation fails silently if the user is unable to create tickets due to expired password

The client.ticket.create!(options) method fails silently if the API user being used to create tickets has an expired password (ie if the user that talks to the API is an agent and the security settings for agents has a password expiry strategy).
When I investigated this, I saw that the API returns a status code 302 with body You are being redirected to /password. However the create! method doesn't raise any exception. The client really should catch this case.

This appears to be a general API issue as it should return an error status. I'll update when it is fixed server-side.

Unfortunately, an incident occurred during that time that affected token API requests for users without a  password set. Since it was not a valid JSON response, the client could not handle it properly. If a public postmortem is posted, I'll make sure to update here.

Steve, does that mean that in future, the client will raise an exception when the user's account needs a password change?

That specific error shouldn't happen again, password expiry has no affect on API token access. But actually maybe the client should consider 300s an invalid response. Let me look into it.

I merged #236 so this specific type of issue (invalid responses being swallowed) shouldn't happen again without raising an exception.

:+1: thanks


Implementation of AVL tree in C++

Description 📜

Domain of Contribution 📊

[x] C/CPP

i want to work on this

hey pls assign this issue to me

/assign

@Suvraneel please review

/assign

/assi

/assign

@sandeepkumar00110  Link this issue no. to your PR properly..


As Kraken Latte, I would like HMP to purchase all of the fish required for the Can We Keep It? quest in The Azure Span

Opened on behalf of Kraken Latte. Bug was reported in Discord.

Fixed in 461fd9d.


fix: kuttl migrate test potentially incorrect when a TestStep is present

Explanation
Fix kuttl migrate test potentially incorrect when a TestStep is present.

CI seems to be failing

Passing now, implementation was wrong 🙈


Create kubernetes integration test

The kubernetes configs have rotted.
This needs to be checked by an integration test.

Fixed by #1399


dephell project test not working for dephell

Maybe I'm missing something here, but I've started playing with the dephell source code so I can maybe start work on an issue.  Rather than using Poetry to create a venv and run pytest myself (as I was tempted to do), I figured I should use the dephell test functionality.  In the pyproject.toml, the pytest env shows the example command dephell project test --env pytest.  When I run this, 12 tests fail.  I haven't dug into the tests yet, but looks like they require a .git folder.
Is this expected behavior?  Seems strange that the test command doesn't work for testing dephell itself.

:thinking:
I used it before. Hm, that strange. Luckily, these tests marked as skip on ci. We can modify skip rule a little bit to skip them if there is no git folder :)

I have just run pytest in a chroot containing the minimal dependencies to do distro packaging; I get only three test failures, those being all the tests in test_git_git. The failures are due to:

not having the git program installed
not being able to find the .git directory in the extracted PyPI sources (of course).

At the moment, I can get it to work using pytest -k 'not test_git_git' to skip those three tests.

So the Git tests are 3 out of the 12 failing tests for me.  I'm attaching a file that shows the remaining failures.
failures.txt


Check null reference before invoking event handlers

Fixes null reference crashing
Description of the changes:

In the C++/CX codebase, event handler is safe to invoke without checking if it's null, however, in C#, we have do so to prevent from exceptions.
using ?.Invoke() on event handlers

How changes were validated:

Build passed
Unit Tests and UI Tests are not applicable so far.

Hi @hanzhang54,
Could you help review this PR by the end of tomorrow? Thanks!


Console, GroovyMain and Groovysh (via its Main) use context class loader

All: pass system properties to new CompilerConfiguration instances
Console: use default parameters to reduce constructor variants

(Clone of 93bebbe140846117cf16127360217dac1d13f5fc)
See also https://github.com/apache/groovy/pull/942

Merged. Thanks for your taking care of syncing branches.
BTW, you should have privilege to commit when you become a committer. You can cherry-pick the commit you want to sync ;-)


Radio Button value field loses selection after a second

Describe the Bug

When creating a radio button after selecting the value field to enter in something after about a second the field loses selection and you can no longer add anything to it without re-selecting it.
Steps to Reproduce

Create a new camunda form
drag the radio button onto the cancase
enter a value to the label field.
enter a value to the value feild
Notice that after a second it stops accepting input.

Expected Behavior

I should be able to enter data without the field losing focus
Environment

OS: Windows 10
Camunda Modeler Version: 4.11.1

https://user-images.githubusercontent.com/10612634/144260236-d73ed0d6-20f4-429f-8430-e610cb9bb985.mp4

Execution Platform: NA
Installed plug-ins: (lots)

Thanks for reporting. I can reproduce the issue.
We plan to look into form related improvements in the next quarter and I've added this one onto the list of potential candidates.

Thanks Nico!

This bug was introduced by https://github.com/bpmn-io/form-js/commit/e66585c24828f318bb2f6bd28fb6b1913423940f#diff-78090eb9f4e5b857920283996e0d8d9af3e7b83471930850f5f79aa817c5574a.

Closed via https://github.com/camunda/camunda-modeler/pull/2771


Webpack bug fix

R: @jeffposnick @addyosmani @gauntface
current webpack plugin implemation pointed towards the source code of other plugin and
also used the relative key from webpack config instead of absolute one.

Oops, my bad.
Will make fix this on weekend sometime

The unrelated change (which I believe was for another PR we just landed a minute ago) should be dropped from here, but otherwise LGTM. @prateekbh do you want to go ahead and update and we can land this so you're unblocked for preact-cli?


Print links in login

Issue: #4
Not sure if this PR will work, I didn't test it, more than locally running a bash script with the changes. If it works, it should show the links for the user like:

Notes:

Not tested
It prints out both HTTP and HTTPS links, but when the tunnel is created, only one is available, so maybe adding one more variable or condition in the script could determine which one to show, if not possible to check that, taking into account that this is used by developers, I think is fine to show both and the dev will figure out which one to use.

oh - good idea @mrsarm! I'll do some testing in a bit and see how it works.

closing in favor of #7


Apphost and targeting pack are showing identical XML!

Apphost and targeting pack are showing identical XML!
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 932f4ea5-7c43-7227-7bf0-35de3d7afb13
Version Independent ID: 4e78038b-455c-2cec-170b-2f077c7d4f23
Content: NETSDK1145: Targeting or apphost pack missing - .NET CLI
Content Source: docs/core/tools/sdk-errors/netsdk1145.md
Product: dotnet-fundamentals
Technology: dotnet-cli
GitHub Login: @wli3
Microsoft Alias: tdykstra

@wli3 Could you update the XML for targeting pack? It looks like a copy/paste error.

I don't see any KnownTargetingPack item type analogous to KnownAppHostPack. Rather, in Microsoft.NET.Sdk.FrameworkReferenceResolution.targets, the ProcessFrameworkReferences target runs the ProcessFrameworkReferences task to create TargetingPack items, the ResolveFrameworkReferences target runs the GetPackageDirectory task to generate ResolvedTargetingPack items from them, and the ResolveTargetingPackAssets target feeds those to the ResolveTargetingPackAssets task, which could raise the NETSDK1145 error. So if an app developer needs to override the version of a targeting pack, then they might need a custom target somewhere between those targets. On the other hand, the EnableTargetingPackDownload property defaults to true so perhaps it will just download the missing targeting pack and avoid the error entirely.


Gamifying Tasks: Earn "Points" for Completing Tasks

⚠ Please check that this feature request hasn't been suggested before.

[X] I searched previous Ideas in Discussions didn't find any similar feature requests.
[X] I searched previous Issues didn't find any similar feature requests.
[X] I am only requesting a single feature. Multiple changes should be split into individual requests, with links between them.
[X] I believe my requested feature will be generally applicable to other users, not just me: it is not uniquely tied to my personal workflow.

🔖 Feature description
You should add a feature to earn "points" for completing tasks.
Points can be tracked, daily, monthly, etc
Then you can find days when you were more productive / less productive.
Set a "points cap" - that means enough work has been done for the day. <-- (this is basically why I want it so I can tell myself enough has been done)
Points values can be set by the user
Higher Priority tasks earn more points
Maybe Low priority tasks can be negative?
The feature is not on by default, but can be turned on in the options
✔ Solution
A value is added to all tasks and maths and stuff
❓ Alternatives
I have not considered alternatives
📝 Additional Context
No response

Hi, thanks for the suggestion.
I can understand why you might like this, but it is outside of the scope of a volunteer-maintained project. We will only do so much free labour in our finite spare time!


Typeahead: customized Input, no "Output"

Hey guys,
I'm trying to implement a search-directive (angular2 rc2) with typeahead. Actual, the code looks like:
import ...
import { TYPEAHEAD_DIRECTIVES } from 'ng2-bootstrap/ng2-bootstrap';

@Component({
  selector: '[searchDirective]',
  directives: [ROUTER_DIRECTIVES, HighlightDirective, TYPEAHEAD_DIRECTIVES],
  pipes: [FindStringPipe],
  template:

    <input [(ngModel)]="inputString"
      [typeahead]="typeaheadInput"
      (typeaheadOnSelect)="typeaheadOnSelect($event)"
      [typeaheadOptionsLimit]=10
      [typeaheadMinLength]=3
      [typeaheadOptionField]="'serviceName'"
      (typeaheadNoResults)="changeTypeaheadNoResults($event)"
      class="form-control">

= 3" class="" style="">
         No Results Found

})
export class SearchDirective implements OnInit {
  inputString : Array<MyObject>;
  ...
}

export class MyObject {
  serviceName : string;
  timestamp: string;
  ...
}

typeaheadInput is an Array of objects containing (only) string-values, one of these is called "serviceName".
This will produce no output (typeaheadNoResults will be true to hole time) although it shouldn't (I've logged the input).
So my question would be: what do I have to implement/overwrite/..., that all attributes of an object (for all objects) will be checked?

@benedikth Unfortunately, this currently not possible.

seems to be one to one with #749


Add support for CLI

@ChetanXpro Can we add cli and refactor the code to be more modular

@ChetanXpro Can we add cli and refactor the code to be more modular

Thanks for the suggestion! Adding CLI and code refactoring are on the roadmap. I'll keep you posted on the progress.

@abakermi  Feel free to take on the CLI addition and code refactoring. If you have any questions or need assistance, don't hesitate to reach out. I appreciate your collaboration!

@ChetanXpro ok

Hey @abakermi , are you working on this ?


Table documentation error on detailed

As you can see, you forgot change the :hasDetails prop on the html example for 'detailed'

@wanxe Thanks!


Modify the customize() method to facilitate subclass override

Describe what this PR does / why we need it
Does this pull request fix one issue?
Modify the customize() method to facilitate subclass override

Describe how you did it
Describe how to verify it
Special notes for reviews

private static void customize() 在Spring托管的bean中看到static真的会觉得很突兀


534 clear selected project

Nope! Sorry!
On Wed, Sep 20, 2017 at 8:42 PM Neal Humphrey<EMAIL_ADDRESS>wrote:

@NealHumphrey commented on this pull request.
Just wondering about the change in router.js - was that intentional?
In docs/tool/js/core/router.js
https://github.com/codefordc/housing-insights/pull/572#discussion_r140126353
:

     }

 },
 pushViewChange: function(msg, data){

   if (data.el === 'project-view'){

   if (data.el === 'building-view'){

This change seems like a mistake?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/codefordc/housing-insights/pull/572#pullrequestreview-64154199,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AVBPxFyUhKuJS6mbpoYsQcqMxS6gC8doks5skbDtgaJpZM4PdRNu
.

--
Jamie Gordon-Lipkin

Meaning it was a mistake.
On Wed, Sep 20, 2017 at 9:32 PM Jamie Gordon-Lipkin <
<EMAIL_ADDRESS>wrote:

Nope! Sorry!
On Wed, Sep 20, 2017 at 8:42 PM Neal Humphrey<EMAIL_ADDRESS>wrote:

@NealHumphrey commented on this pull request.
Just wondering about the change in router.js - was that intentional?
In docs/tool/js/core/router.js
https://github.com/codefordc/housing-insights/pull/572#discussion_r140126353
:

     }

 },
 pushViewChange: function(msg, data){

   if (data.el === 'project-view'){

   if (data.el === 'building-view'){

This change seems like a mistake?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/codefordc/housing-insights/pull/572#pullrequestreview-64154199,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AVBPxFyUhKuJS6mbpoYsQcqMxS6gC8doks5skbDtgaJpZM4PdRNu
.

--
Jamie Gordon-Lipkin
--
Jamie Gordon-Lipkin


automatic minmax limits

Automatically set all limits not specified by a .ranges file to their respective minimum and maximum values in the sample.
Fixes #36
Checklist:

[x] I have performed a self-review of my own code
[x] My code is PEP8 compliant (flake8 anesthetic tests)
[x] My code contains compliant docstrings (pydocstyle --convention=numpy anesthetic)
[x] New and existing unit tests pass locally with my changes (python -m pytest)
[x] I have added tests that prove my fix is effective or that my feature works

This looks great. I've had a quick look and it seems like it works well. Could you iterate the version number in the README to 1.2.6 to signify a change, and I'll formalise this as a new release.

I noticed one thing:
In the current setup, it doesn't assign limits to logL or weight. Would we prefer to have limits set on them, too? That might be better for cases where a PC run is ended prematurely and logL will have a sharp cutoff which could get washed out by the KDE without limits.

I think it makes sense to automate this too. It would be harder to communicate in the case that you don't want a hard limit, but you could always do that manually at the python level if you had to. You should probably also do this for the nlive column as well.


Equation 11 differs from paper

Equation 11 is given in Abramoff et al. (2017) as

Qmax = BD10 ^ (c1 log(%clay) + c2)
... Qmax is the maximum sorption capacity (mg C kg-1 dry soil) that is converted to C density (g C m-2) by multiplying soil bulk density (BD = 1350 kg m-3), assuming a 1 m soil profile. The parameters c1 and c2 are the coefficients for computing Qmax from the clay content in percent, derived from Mayes et al. (2012).

When Qmax is computed, the code mentions this BD multiplication in a comment
 704 	Qmax = 10.0 ** (0.297 * log(clay * 100.0) + 2.355 + 0.50) !* 1.25  ! 1.35 is bulk density to convert Q from mg/kg to g/m2

but confusingly the multiplication itself is commented out (and appeared to use 1.25, not 1.35). Is this intended? @rabramoff or @email-clm can you clarify?

Hi Ben,
You can treat the c2 as 2.855. The comments of those values for doing
parameterization processes; for the manual calibration, different values
were tried but the final value was kept while others were commented out. mg
C kg-1 * 1350 kg m-3 / (1000 mg/g) = mg C kg-1 * 1.35 = gC m-2, thinking
about the unit conversion. During later calibration, 1.35 was changed to
1.25 and then was changed to 1 (totally commented out means it multiples 1).
by the way, seems it uses clay as fraction, and then multiple 100 to be
percentage in this fraction. I think I need to clean the code to ensure
consistency.
Best,
Xiaofeng
On Sat, Mar 9, 2019 at 4:50 AM Ben Bond-Lamberty<EMAIL_ADDRESS>wrote:

Equation 11 is given in Abramoff et al. (2017) as
Qmax = BD10 ^ (c1 log(%clay) + c2)
... Qmax is the maximum sorption capacity (mg C kg-1 dry soil) that is
converted to C density (g C m-2) by multiplying soil bulk density (BD =
1350 kg m-3), assuming a 1 m soil profile. The parameters c1 and c2 are the
coefficients for computing Qmax from the clay content in percent, derived
from Mayes et al. (2012).
When Qmax is computed, the code mentions this BD multiplication in a
comment
704 	Qmax = 10.0 ** (0.297 * log(clay * 100.0) + 2.355 + 0.50) !* 1.25  ! 1.35 is bulk density to convert Q from mg/kg to g/m2
but confusingly the multiplication itself is commented out (and appeared
to use 1.25, not 1.35). Is this intended? @rabramoff
https://github.com/rabramoff or @email-clm
https://github.com/email-clm can you clarify?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/PNNL-TES/millenial/issues/10, or mute the thread
https://github.com/notifications/unsubscribe-auth/AORC8zZ58yU1bbIrBHR5k4aHk_MP-qA1ks5vU64pgaJpZM4bmqfx
.

During later calibration, 1.35 was changed to 1.25 and then was changed to 1

Ah...so you're assuming a bulk density of 1.0? OK, that's the kind of thing that should be (in my opinion) explicit–I will note it in the R code and open an issue in your repo. Thanks!

Re-opening so we have a good list of where the model diverges from paper description.