Deprecate reimbursementAccountDraftValues

Details
Standardizes on reimbursementAccountDraft
cc @MariaHCD @marcochavezf
Fixed Issues
https://github.com/Expensify/App/pull/11556#pullrequestreview-1132852157
Tests

Create a Workspace + > New Workspace
Navigate to Workspace > Connect bank account > Connect online with Plaid
Select Chase
Go through the Plaid flow using user_good and pass_good as credentials
Select the savings account from the dropdown
Enter 011401533 and<PHONE_NUMBER>331111 for routing and account numbers
Tap Save and continue
Fill in random information in the Company Step
Tap Save and continue
Log out
Log back in and navigate to Workspace > Connect bank account > Continue with setup
Press < to go back to the Bank account step and verify that the account information is filled in the form inputs

[x] Verify that no errors appear in the JS console

PR Review Checklist

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

QA Steps

[ ] Verify that no errors appear in the JS console

Screenshots

Web
https://user-images.githubusercontent.com/22219519/194409280-640ed7e5-d72d-4739-a82d-655e4a6ddf19.mov
Mobile Web - Chrome
https://user-images.githubusercontent.com/22219519/194411195-7b9691c2-0c1c-410e-a8c1-5399259ecfff.mov
Mobile Web - Safari
https://user-images.githubusercontent.com/22219519/194411211-ac3c35b2-a711-4ceb-8070-bea088d79e2f.mov
Desktop
https://user-images.githubusercontent.com/22219519/194409725-522ea2ce-0424-46a8-84fb-8a0fedfdfb50.mov
iOS
https://user-images.githubusercontent.com/22219519/194411232-713c6976-e60f-43fe-8e07-1a4dc214274c.mov
Android
https://user-images.githubusercontent.com/22219519/194411247-0a21a9a0-2bc8-4223-82e4-bab3a06e9f7c.mov

Updated!

Updated!

Bumping for reviews!

MacOS / Chrome
(1) New Expensify (1).webm
MacOS / Desktop
https://user-images.githubusercontent.com/12268372/195837579-d016c273-a4aa-4413-b6f1-0ad64e340e09.mov
iOS / native
https://user-images.githubusercontent.com/12268372/195838345-946534d7-88ab-4ff2-84be-ae9b2550420d.mov
Android / native
https://user-images.githubusercontent.com/12268372/195838631-a116d212-2a67-4c5f-9f80-7307dd08b52c.mov
iOS / Safari
https://user-images.githubusercontent.com/12268372/195836790-4c7b85cb-abff-4421-bc4b-148d233bf4ad.mov
Android / Chrome
https://user-images.githubusercontent.com/12268372/195837262-f43b5c6b-9b95-4151-a6dc-30a16e600142.mp4

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] Any functional components have the displayName property
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

LGTM! Can we also test with any other form(s) that use shouldSaveDraft?

I tested this locally and it works

I'm assuming the Web QA is the same as the test steps? Currently, it's empty in the OP

Done! Thanks for catching this!

Tests already passed

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @marcochavezf in version: 1.2.18-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by @marcochavezf in version: 1.2.18-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @chiragsalian in version: 1.2.18-10 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Flatpak build

Please, consider supporting Flatpak and publishing App Outlet on Flathub.

Duplicated https://github.com/app-outlet/app-outlet/issues/32


flutter drive fails to open socket on localhost

Steps to Reproduce
flutter drive --release --driver test_driver/integration_test.dart --target integration_test/app_test.dart -d web-server --browser-name chrome --web-hostname <IP_ADDRESS> --web-port 7222 --dds-port 7333
...
INFO: Running "flutter pub get" in frontend-flutter...
INFO:    790ms
INFO: Launching integration_test/app_test.dart on Web Server in release mode...
SEVERE: Failed to bind web development server:
SocketException: Failed to create server socket (OS Error: Failed to start accept), address = localhost, port = 7222
Process finished with exit code -1

Expected results: flutter drive to not crash
Actual results: flutter drive crashed
I am using the minimal integration test setup for the web described here:  https://docs.flutter.dev/cookbook/testing/integration/introduction#6b-web

While I can pass <IP_ADDRESS> to flutter run with --web-hostname to sidestep problems with using localhost on my Windows 11 machine, there does not seem to be a way to do that with flutter drive.

[√] Flutter (Channel stable, 2.5.3, on Microsoft Windows [Version 10.0.22000.318], locale en-US)
• Flutter version 2.5.3 at C:\dev\flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 18116933e7 (5 weeks ago), 2021-10-15 10:46:35 -0700
• Engine revision d3ea636dc5
• Dart version 2.14.4
[√] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
• Android SDK at C:\Users\robbi\AppData\Local\Android\sdk
• Platform android-31, build-tools 31.0.0
• Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
• All Android licenses accepted.
[√] Chrome - develop for the web
• Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe
[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.11.5)
• Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
• Visual Studio Community 2019 version 16.11.31729.503
• Windows 10 SDK version 10.0.19041.0
[√] Android Studio (version 2020.3)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin can be installed from:
https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
[√] Connected device (3 available)
• Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.22000.318]
• Chrome (web)      • chrome  • web-javascript • Google Chrome 96.0.4664.45
• Edge (web)        • edge    • web-javascript • Microsoft Edge 95.0.1020.38
• No issues found!

Closing as a duplicate of https://github.com/flutter/flutter/issues/53338 , Meanwhile until the issue gets fixed you may try the solution mentioned in this comment

This is for flutter drive.  The solution mentioned in the comment does not work for flutter drive.

Please follow up on the linked issue for further updates.


[WIP] Rudimentary object serialization

This is to address #9.
This is WIP. It doesn't redraw annotations correctly, and it ignores the zIndex of layers.

@kotfic This is ready for some feedback. I based it on #60 so this is a better diff to look at.

Current coverage is 38.35% (diff: 100%)

Merging #48 into master will not change coverage

@@             master        #48   diff @@
==========================================
  Files             8          8
  Lines            73         73
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits             28         28
  Misses           45         45
  Partials          0          0

Powered by Codecov. Last update 9564236...5c35558

I have to look into the zIndex not working on user layers.

@kotfic Feel free to review, this PR is dependent on #64.


Update color dependency

Thanks for doing this; I realize I actually need to update the mappings altogether to remove the platform-mappings (since they are in nova-colors now) - I'll do this in https://github.com/trevordmiller/nova-vim/issues/25


getting smtp connection error when deployed

library is working fine when run locally but as I run it on server it always show smtp connection error  how to resolve this I changed the ports also
[ping-email - ERROR]: Error connecting to SMTP server: AggregateError

which port are you using ? port 25 is blocked by default on most providers and the library does not seems to be working on any other port


Fancy service restart

This fixes #1949. It works like this:
No config changes:
2022-07-27T11:32:46.376+0300    INFO    signal received {"name": "hangup"}
2022-07-27T11:32:46.378+0300    INFO    shutting down RPC server        {"endpoint": "[::]:10332"}
2022-07-27T11:32:46.379+0300    INFO    starting rpc-server     {"endpoint": ":10332"}
2022-07-27T11:32:46.379+0300    INFO    shutting down service   {"service": "Prometheus", "endpoint": ":2112"}
2022-07-27T11:32:46.380+0300    INFO    service hasn't started since it's disabled      {"service": "Pprof"}
2022-07-27T11:32:46.381+0300    INFO    service is running      {"service": "Prometheus", "endpoint": ":2112"}

Enabled/disabled services:
2022-07-27T11:33:18.936+0300    INFO    signal received {"name": "hangup"}
2022-07-27T11:33:18.938+0300    INFO    shutting down RPC server        {"endpoint": "[::]:10332"}
2022-07-27T11:33:18.940+0300    INFO    RPC server is not enabled
2022-07-27T11:33:18.940+0300    INFO    shutting down service   {"service": "Prometheus", "endpoint": ":2112"}
2022-07-27T11:33:18.940+0300    INFO    service is running      {"service": "Pprof", "endpoint": ":2113"}
2022-07-27T11:33:18.941+0300    INFO    service is running      {"service": "Prometheus", "endpoint": ":2112"}

2022-07-27T11:36:39.794+0300    INFO    signal received {"name": "user defined signal 1"}
2022-07-27T11:36:45.840+0300    INFO    starting oracle service
2022-07-27T11:36:45.840+0300    INFO    stopping state validation service
2022-07-27T11:36:50.678+0300    INFO    persisted to disk       {"blocks": 1, "keys": 261, "headerHeight": 1926393, "blockHeight": 1926393, "took": "95.264089ms"}
2022-07-27T11:36:51.232+0300    INFO    starting state validation service

2022-07-27T11:46:26.781+0300    INFO    signal received {"name": "user defined signal 2"}
2022-07-27T11:46:27.109+0300    INFO    starting consensus service
2022-07-27T11:46:27.109+0300    INFO    initializing dbft       {"height": 1926428, "view": 0, "index": -1, "role": "WatchOnly"}
2022-07-27T11:46:33.106+0300    INFO    received PrepareRequest {"validator": 0, "tx": 0}
2022-07-27T11:46:33.158+0300    INFO    received PrepareResponse        {"validator": 2}
2022-07-27T11:46:33.179+0300    INFO    received PrepareResponse        {"validator": 4}
2022-07-27T11:46:33.203+0300    INFO    received PrepareResponse        {"validator": 1}
2022-07-27T11:46:33.222+0300    INFO    received PrepareResponse        {"validator": 6}
2022-07-27T11:46:33.230+0300    INFO    received PrepareResponse        {"validator": 3}
2022-07-27T11:46:33.250+0300    INFO    received Commit {"validator": 4}
2022-07-27T11:46:33.334+0300    INFO    received Commit {"validator": 2}
2022-07-27T11:46:33.342+0300    INFO    received Commit {"validator": 3}
2022-07-27T11:46:33.363+0300    INFO    received Commit {"validator": 6}
2022-07-27T11:46:34.835+0300    INFO    received PrepareResponse        {"validator": 5}
2022-07-27T11:46:34.929+0300    INFO    received Commit {"validator": 5}
2022-07-27T11:46:34.929+0300    INFO    approving block {"height": 1926428, "hash": "56e51d1399f7e784b697e51623ee0f16e0b0c21c46da7d2a9d01025758f2e9ce", "tx_count": 0, "merkle": "0000000000000000000000000000000000000000000000000000000000000000", "prev": "4ce420b948da9de482d9bb12dd86b54387c53bad013bfc0739b3d54f6ffe0791"}
2022-07-27T11:46:34.932+0300    INFO    initializing dbft       {"height": 1926429, "view": 0, "index": -1, "role": "WatchOnly"}

2022-07-27T11:47:08.517+0300    INFO    signal received {"name": "user defined signal 2"}
2022-07-27T11:47:08.518+0300    INFO    stopping consensus service
2022-07-27T11:47:08.662+0300    INFO    persisted to disk       {"blocks": 1, "keys": 23, "headerHeight": 1926430, "blockHeight": 1926430, "took": "9.627537ms"}
2022-07-27T11:47:08.871+0300    INFO    starting consensus service
2022-07-27T11:47:08.871+0300    INFO    initializing dbft       {"height": 1926431, "view": 0, "index": -1, "role": "WatchOnly"}

OK, this can wait for 0.98.2, too many things touched and too many open questions.


Syntax for re-stubbing

Is there a way to have something like
allow(view).to receive(:current_user).and_return(member1)

in a before block and within 1 test, "re-stub" as
allow(view).to receive(:current_user).and_return(member2)

I'm not finding any documentation on resetting stubs or overwriting stubs so far.

This definitely works, but I called render prior to re-stubbing so I thought it wasn't.


07-design-report-in-power-bi-desktop-enhanced.md

English:
and then select Hide Page.
Current Translation:
然后选择“隐藏页面”。
Suggested Translation:
然后选择“隐藏页”。

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Run the bugfix tool and waiting for result. ICMS QUERY

Fixed.


Why not tasks/main.go

In godo.v2, the document says that only Gododir/main.go will be read.
personally I don't like a directory call itself dir and a file called somefile.
If you don't like "tasks", maybe just godo/main.go would be fine. or you can use some option to switch which files used for godo task.

There is no rhyme reason, it was an arbitrary choice. I could easily add tasks/main.go. There are currently 3 files that are searched for legacy reasons
https://github.com/go-godo/godo/blob/v2/cmd/godo/main.go#L50

Yes, I modify the line and build godo.v2 myself, and it works.
Thank you.


[Bug] - Healthcheck returns HTTP/1.1 400 Bad Request

Describe the bug
Installed binary from https://github.com/versity/versitygw/releases/download/v1.0.4/versitygw_1.0.4_linux_amd64.deb
lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 22.04.4 LTS
Release:	22.04
Codename:	jammy
With basic start options 'versitygw posix  --health /health', GET returns 400
curl -i http://<IP_ADDRESS>:7070/health
HTTP/1.1 400 Bad Request
Server: VERSITYGW
Date: Tue, 06 Aug 2024 13:14:18 GMT
Content-Type: text/plain; charset=utf-8
Content-Length: 243
Connection: close

InvalidArgumentAuthorization header is invalid -- one and only one ' ' (space) required.</Req
To Reproduce
Start binary with 'versitygw posix  --health /health'
Issue 'curl -i http://<IP_ADDRESS>:7070/health'
Expected behavior
curl -i http://<IP_ADDRESS>:7070/health
OK
Server Version
versitygw -v
Version  : 1.0.4
Build    : 733b6e7b2fd686a23d98ef82f3234a37a7cc2dbb
BuildTime: 2024-07-17T15:56:00Z
Additional context
<!-- Describe s3 client and version if applicable.

The --health is a global option, so needs to be specified before the 'posix', for example:
versitygw --health /health posix ...

Just tested this over here:
% ./versitygw --access test --secret test --health /health posix /tmp/gw

% curl -i http://<IP_ADDRESS>:7070/health
HTTP/1.1 200 OK
Server: VERSITYGW
Date: Tue, 06 Aug 2024 17:14:35 GMT
Content-Type: text/plain; charset=utf-8
Content-Length: 2
Connection: close

OK%

Thanks for the explanation, confirmed on my end as well.


Update schema job failed with Yugabyte CQL

The create and setup schema job successfully but I see the update job failed with this error:
CREATE TYPE serialized_event_batch ( encoding_type text, version int, data blob );    {"logging-call-at": "updatetask.go:154"}
ERROR    Unable to update CQL schema.    {"error": "error executing statement:Duplicate Type. Type 'temporal_hung.serialized_event_batch' already exists (master error 19)\nCREATE TYPE serialized_event_batch

It seems like missing IF NOT EXISTS in CQL script

Hi @sotatek-hungpham5 !
Thanks for reporting this issue.
Unfortunately the issue is not on the operator side because it uses "official" database migration tools.
Looks like it's not supported on temporal for now: https://github.com/temporalio/temporal/issues/3511


Test refactors (as in refactoring tests, not testing refactors)

Related to https://github.com/KittyCAD/modeling-app/pull/2105

@Irev-Dev needs rebase


Support base_dir option to artemis web

Is your feature request related to a problem? Please describe.
We can access artemis web(frontend) with host based routing (ex. https://artemis.example.com)
I'd be happy if I could access it with path based routing (ex. https://www.example.com/artemis)
I believe it's useful when using http reverse proxy.
Describe the solution you'd like
Add new parameter ARTEMIS_WEB_BASE_DIR. and need to implement something to frontend.
ARTEMIS_WEB_HOST=www.examle.com
ARTEMIS_WEB_BASE_DIR=/artemis

Solved by https://github.com/FORTH-ICS-INSPIRE/artemis-web/pull/127 and https://github.com/FORTH-ICS-INSPIRE/artemis/commit/0c2c9f12515eaa22920e92148b9994793a6eb2f3 in latest


CHANGELOG generator looks up incorrect PR links

Bug Report
Generating the CHANGELOG from the fragments can result in some lines pointing to incorrect PR links.
For the v0.18.0 release, the following fragment for PR #2987 :
https://github.com/operator-framework/operator-sdk/blob/d1dbfc8336c7d52228cf42e1f2e3d4ab5aff6709/changelog/fragments/2727-helm-support-annotations.yaml
results in the CHANGELOG line:

Adds the ability for Helm operators to properly watch and reconcile when cluster-scoped release resources are changed. (#2894)

See the following for all corrections:
https://github.com/operator-framework/operator-sdk/pull/3140

/assign @rashmigottipati

/assign


Consider adding Coverity scans

Coverity appears to be free for at least some open source projects. It may be a good addition to our tracker for added security scanning.
https://scan.coverity.com/

I'm closing this for now. We don't need these scans for our security stuff and they aren't all that useful from a development perspective.


Add telemetry for when a testing setting is enabled

Track when testing is enabled for any of the frameworks we support

Prescribed Solution

Add handler to settings changed

Check whether any testing frameworks have been enabled (based on args sent to the config changed handler)

Send telemetry (with information about the framework enabled)


The future of redux-logger 🚀

I’m excited to announce that our longtime sponsor, LogRocket, is taking over stewardship of redux-logger 🏄♂
As a production frontend logging and session replay company (and user of redux-logger!) their engineering team is excited to start fixing issues, reviewing PRs, and guiding the future development of the tool.

Thanks @evgenyrodionov for your hard work on this awesome library!
I'm an engineer at LogRocket, and we're very excited to help take redux-logger to the next level. Over the next few weeks, we're going to prune the outstanding issues, and merge some of the PRs that are still relevant.
Moving forward we'd love to hear feedback/suggestions from users here on anything you'd like to see fixed/improved/added over the next few months. Some things we're exploring are:

Improved performance and better user experience of the diff feature
Support tree shaking
Improved test coverage
Better support for React Native

Hi Kaelan, any progress since your announcement? If I am not mistaken, there has not been a single commit since 1 Nov 2018.

@eranimo - I'd also be interested in seeing some updates. :)

Curious about status :)

@eranimo Any updates on the v4 yet?

While I expect I can already guess the answer here.. Any updates on v4 now in 2021?

Mantained? I think that is better to LogRocket declare it dead or in maintenance mode. This is a obvious lead capture for them. Bad move LogRocket, bad move....

Companies are just made up of people... engineers like us all... I bet they really wanted to do good stuff here, but just never quite managed to fit it in.
Agree with you that LogRocket (@eranimo ?) should tell the community what's happening, but it's really harsh to say lead capture or be too harsh.
Life is really busy.
Be great to have an update for sure, the community will understand whatever that outcome is.


[package:flutter_webview_pro] Xcode build fails for flutter_webview_pro

Steps to Reproduce

$ flutter emulators --launch apple_ios_simulator
$ flutter create  flutter_webview_pro_test
$ cd flutter_webview_pro_test
$ flutter pub add flutter_webview_pro
$ flutter run

Expected results: the Xcode build succeeds and the app runs in the Apple iOS simulator.
Actual results: the Xcode build fails, resulting in an exception (see below).

$ flutter run
Launching lib/main.dart on iPhone 11 Pro Max in debug mode...
Running pod install...                                           2,724ms
Running Xcode build...
Xcode build done.                                           12.3s
Failed to build iOS app
Error output from Xcode build:
↳
    ** BUILD FAILED **

Xcode's output:
↳
    Writing result bundle at path:
    	/var/folders/92/6xfrt8vj6z58trf_7gbm8lk40000gn/T/flutter_tools.tFOzh6/flutter_ios_build_temp_dirJXt4fa/temporary_xcresult_bundle

    /Users/admpsktt/flutter/.pub-cache/hosted/pub.dartlang.org/webview_pro_wkwebview-2.7.1+2/ios/Classes/FlutterWebView.m:11:17: error: definition of 'FLTWebViewFactory' must be imported from module 'webview_flutter_wkwebview.FlutterWebView' before it is required
    @implementation FLTWebViewFactory {
                    ^
    In module 'webview_flutter_wkwebview' imported from /Users/admpsktt/flutter/.pub-cache/hosted/pub.dartlang.org/webview_pro_wkwebview-2.7.1+2/ios/Classes/FlutterWebView.m:8:
    /Users/admpsktt/flutter/.pub-cache/hosted/pub.dartlang.org/webview_pro_wkwebview-2.7.1+2/ios/Classes/FlutterWebView.h:35:12: note: definition here is not reachable
    @interface FLTWebViewFactory : NSObject <FlutterPlatformViewFactory>
               ^
    /Users/admpsktt/flutter/.pub-cache/hosted/pub.dartlang.org/webview_pro_wkwebview-2.7.1+2/ios/Classes/FlutterWebView.m:120:29: error: definition of 'FLTWKNavigationDelegate' must be imported from module 'webview_flutter_wkwebview.FLTWKNavigationDelegate' before it is
    required
        _navigationDelegate = [[FLTWKNavigationDelegate alloc] initWithChannel:_channel];
                                ^
    In module 'webview_flutter_wkwebview' imported from /Users/admpsktt/flutter/.pub-cache/hosted/pub.dartlang.org/webview_pro_wkwebview-2.7.1+2/ios/Classes/FlutterWebView.m:8:
    /Users/admpsktt/flutter/.pub-cache/hosted/pub.dartlang.org/webview_pro_wkwebview-2.7.1+2/ios/Classes/FLTWKNavigationDelegate.h:10:12: note: definition here is not reachable
    @interface FLTWKNavigationDelegate : NSObject <WKNavigationDelegate>
               ^
    /Users/admpsktt/flutter/.pub-cache/hosted/pub.dartlang.org/webview_pro_wkwebview-2.7.1+2/ios/Classes/FlutterWebView.m:153:6: error: definition of 'FLTWKProgressionDelegate' must be imported from module 'webview_flutter_wkwebview.FLTWKProgressionDelegate' before it is
    required
        [_progressionDelegate stopObservingProgress:_webView];
         ^
    In module 'webview_flutter_wkwebview' imported from /Users/admpsktt/flutter/.pub-cache/hosted/pub.dartlang.org/webview_pro_wkwebview-2.7.1+2/ios/Classes/FlutterWebView.m:8:
    /Users/admpsktt/flutter/.pub-cache/hosted/pub.dartlang.org/webview_pro_wkwebview-2.7.1+2/ios/Classes/FLTWKProgressionDelegate.h:11:12: note: definition here is not reachable
    @interface FLTWKProgressionDelegate : NSObject
               ^
    3 errors generated.
    note: Using new build system
    note: Planning
    note: Build preparation complete
    note: Building targets in dependency order

    Result bundle written to path:
    	/var/folders/92/6xfrt8vj6z58trf_7gbm8lk40000gn/T/flutter_tools.tFOzh6/flutter_ios_build_temp_dirJXt4fa/temporary_xcresult_bundle

Modules Issue (Xcode): Definition of 'FLTWebViewFactory' must be imported from module 'webview_flutter_wkwebview.FlutterWebView' before it is required
/Users/admpsktt/flutter/.pub-cache/hosted/pub.dartlang.org/webview_pro_wkwebview-2.7.1+2/ios/Classes/FlutterWebView.m:10:16

Modules Issue (Xcode): Definition of 'FLTWKNavigationDelegate' must be imported from module 'webview_flutter_wkwebview.FLTWKNavigationDelegate' before it is required
/Users/admpsktt/flutter/.pub-cache/hosted/pub.dartlang.org/webview_pro_wkwebview-2.7.1+2/ios/Classes/FlutterWebView.m:119:28

Modules Issue (Xcode): Definition of 'FLTWKProgressionDelegate' must be imported from module 'webview_flutter_wkwebview.FLTWKProgressionDelegate' before it is required
/Users/admpsktt/flutter/.pub-cache/hosted/pub.dartlang.org/webview_pro_wkwebview-2.7.1+2/ios/Classes/FlutterWebView.m:152:5

Could not build the application for the simulator.
Error launching application on iPhone 11 Pro Max.

$ flutter analyze
Analyzing flutter_webview_pro_test...
No issues found! (ran in 4.6s)

$ flutter doctor -v
[✓] Flutter (Channel stable, 3.0.5, on macOS 11.3.1 20E241 darwin-x64, locale en-GB)
    • Flutter version 3.0.5 at /Users/admpsktt/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision f1875d570e (5 days ago), 2022-07-13 11:24:16 -0700
    • Engine revision e85ea0e79c
    • Dart version 2.17.6
    • DevTools version 2.12.2

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0-rc1)
    • Android SDK at /Users/admpsktt/Library/Android/sdk
    • Platform android-32, build-tools 33.0.0-rc1
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)

[✓] VS Code (version 1.69.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.44.0

[✓] Connected device (3 available)
    • iPhone 11 Pro Max (mobile) • CB3CB245-F64B-4161-B2B1-BEBDE77A110F • ios            • com.apple.CoreSimulator.SimRuntime.iOS-15-2 (simulator)
    • macOS (desktop)            • macos                                • darwin-x64     • macOS 11.3.1 20E241 darwin-x64
    • Chrome (web)               • chrome                               • web-javascript • Google Chrome 103.0.5060.114

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Note that the same Flutter project runs fine when an Android device is targeted. This makes sense to me given that the error points specifically at the webview_pro_wkwebview package.

Issues with third-party packages need to be reported to their developers, rather than the Flutter project.


[chapter10] Move threshold_computation.ipynb to chapter-5

done: https://github.com/PacktPublishing/Machine-Learning-for-Imbalanced-Data/pull/30


Properly configure selinux for virt-laucher.

BUG REPORT:
/kind bug
What happened:
Currently the virt-handler selinux policy is set to be super-privileged. This is a future security issue and has to be fixed.
This workaround is introduced in #1214 as a temporary solution.
What you expected to happen:
Figure out the right selinux settings and apply it to the virt-launcher.

Fixed error in component name.

/remove-lifecycle rotten

Well, it's good enough atm. CLosing this for now
/close


BUG: when a second recipe is added by pressing the plus icon on the build trip page the whole objet is not added just the recipeId

Worked that out by esablishing different relationships


Fix background raw mouse input

Fixes the problem in https://github.com/Elringus/UnityRawInput/pull/21#issuecomment-1226683385 for #19
The fix is described in https://github.com/Elringus/UnityRawInput/issues/19#issuecomment-1227462101

That's it. Thank you!


polygon wallet connect

giving this error on chrome and not connecting over trustwallet dapp browser too.

Resources that failed to load
A few resources failed to load due to issues with your network, proxy server or the webpage.
SwitchyOmega is just the reporter of these issues, not the cause of them.
*.maticvigil.com

Tech-support issues like this are best handled in over our Discord or Telegram channels. If you follow this link, you will land in the best spot to report your issue and be helped.

fixed


Bug 2108054: Reset metrics only after all check succeed

blockUpgradeOrDegradeCluster is called twice during sync(), therefore it's not a good place to reset overall error metrics. Consider this scenario:
1st sync():

loginToVCenter() succeeds

-> the first blockUpgradeOrDegradeCluster() gets CheckActionPass

runClusterCheck() fails

-> the second blockUpgradeOrDegradeCluster() gets say CheckActionBlockDriverInstall and sets appropriate error metric

2nd sync():

loginToVCenter() succeeds

-> the first blockUpgradeOrDegradeCluster() gets CheckActionPass -> this resets error metric!

runClusterCheck() does not run any checks because it's too early after the previous check, therefore it does not set any    error metric

As result, the error metric is reset, but it should stay set until runClusterCheck() confirms the error has been fixed.
Therefore reset the metric when both loginToVCenter and runClusterCheck succeeds.
cc @openshift/storage

/lgtm

/retest

/retest


[Issue]: ~20% perf difference between MIGraphX and rocblas-bench

Problem Description
Given this program:
# test.py
p = migraphx.program()
m = p.get_main_module()
p_a = m.add_parameter("inputA",migraphx.shape(type="half_type", lens=[2,1024,1280]))
p_b = m.add_parameter("inputB",migraphx.shape(type="half_type", lens=[2,1280,10240]))
p_c = m.add_parameter("inputC",migraphx.shape(type="half_type", lens=[2,1024,10240]))
p_dot = m.add_instruction(migraphx.op("dot"), [p_a, p_b])
m.add_instruction(migraphx.op("add"), [p_dot, p_c])

I compile this with:
./bin/migraphx-driver compile --exhaustive-tune  test.py -o test.mxr

And I run with
ROCBLAS_LAYER=2 rocprof --stats  ./bin/migraphx-driver run test.mxr

And the timing I get is ~126us.

Both perf/run will also emit the rocblas-bench command to run the underlying gemm in rocBLAS:
./rocblas-bench -f gemm_strided_batched_ex --transposeA N --transposeB N -m 10240 -n 1024 -k 1280 --alpha 1 --a_type f16_r --lda 10240 --stride_a 13107200 --b_type f16_r --ldb 1280 --stride_b 1310720 --beta 1 --c_type f16_r --ldc 10240 --stride_c 10485760 --d_type f16_r --ldd 10240 --stride_d 10485760 --batch_count 2 --compute_type f32_r --algo 1 --solution_index 80268 --flags 0

But if I execute this, I get 145us (>20% difference). However, if I add the flag --initialization rand_int  to rocblas-bench I get 111us.
Operating System
Ubuntu 20.04.6 LTS
CPU
AMD EPYC 7A53 64-Core Processor
GPU
AMD Instinct MI300X
Other
No response
ROCm Version
ROCm 6.0.0
Steps to Reproduce
No response
(Optional for Linux users) Output of /opt/rocm/bin/rocminfo --support
No response
Additional Information
No response

Running the two following commands, the two results are fairly close (Mi300x & Intel(R) Xeon(R) Platinum 8480C) :
ROCBLAS_LAYER=2 rocprof --stats  ./bin/migraphx-driver run test.mxr   (AverageNs: 194 us)
ROCBLAS_LAYER=2 rocprof --stats  ./bin/migraphx-driver perf -n 1  test.mxr  (AverageNs: 188 us -- This is actually an average of 3 runs.)

It's a bit strange we see different timings from migraphx.  Did you set HIP_FORCE_DEV_KERNARG=1 ? Also, are you using rocm 6.1 (rocm-6.1.0-445)?

(Those earlier numbers were not with 6.1. Flag is set as: HIP_FORCE_DEV_KERNARG = 1)
I see that comparing run with perf is likely to result in some confusion. Reason is, perf -n 1 runs at least 3 times, and then give its results. And similar (and better averaged) results with perf, which by default will run 100+ times. Its first run is always the slowest, just to prep up..
While 'run' will just run once, and it naturally has all the delays involved with the prep up in its accounting.
A look at results.csv will show the individual run details of a perf command. And its first run shows virtually the same numbers as a 'run'.
Now, I have just gone on to rocm 6.0.3. From 6.0.2:
Current test sample results: perf -n 10 has its first run @ 187us, the AverageNs at 167us --
While run yielded 187us. Within 0.5 us of the first run of perf!

@giuseros your experiments used --exhausitive-tune flag .. correct ?
I think its missing in original issue description.

Running on rocm 6.0.3. rocBLAS version: <IP_ADDRESS>df9726-dirty

On the perf step above, this following output was captured, and run..

rocblas-bench --initialization rand_int -f gemm_strided_batched_ex --transposeA N --transposeB N -m 10240 -n 1024 -k 1280 --alpha 1 --a_type f16_r --lda 10240 --stride_a 13107200 --b_type f16_r --ldb 1280 --stride_b 1310720 --beta 1 --c_type f16_r --ldc 10240 --stride_c 10485760 --d_type f16_r --ldd 10240 --stride_d 10485760 --batch_count 2 --compute_type f32_r --algo 1 --solution_index 40501 --flags 0
Query device success: there are 1 devices
 Device ID 0 :  gfx942:sramecc+:xnack-
with 206.1 GB memory, max. SCLK 2100 MHz, max. MCLK 1300 MHz, compute capability 9.4
maxGridDimX<PHONE_NUMBER>, sharedMemPerBlock 65.5 KB, maxThreadsPerBlock 1024, warpSize 64

rocBLAS info: Time taken to complete rocBLAS library initialization is 1120 milliseconds.

rocBLAS info: maximum library size per device is 0.455082 GB.
transA,transB,M,N,K,alpha,lda,stride_a,beta,ldb,stride_b,ldc,stride_c,ldd,stride_d,batch_count,rocblas-Gflops,us
N,N,10240,1024,1280,1,10240,13107200,1,1280,1310720,10240,10485760,10240,10485760,2, 303317, 177

Results:
With rand_int initialization: 177us
Without rand_int initialization: 212 us
And with the perf command: 168 us.

Also, just to compare a FP32 equivalent model, with the changed random number (range) in migraphx:
rocblas_bench:
FP32. With rand_int initialization: 492us
FP32 Without rand_int initialization: 605 us
Migraphx:
FP32. With the perf command: 516 us.


fix: moving the preserve mtiem test logic to Go for portability

The original bash version of the preserve mtime test doesn't work for Mac / Windows. For better portability I changed this to a go_test.
Changes are visible to end-users: no
Test plan
I've run this locally on a Linux machine to verify the basic functionality and ensured the test still fails if the preserve_mtime attributes are commented out. CI will be needed to test this on Mac / Windows.

I think this feature is behaving unexpectedly with Bazel's caching but I'm not sure why. This sequence is not working as I expected:

Run bazel clean --expunge
Comment out preserve_mtime = True from one of the inputs to the test.
Run the test with bazel test :test_preserve_mtime and it fails as expected.
Add preserve_mtime = True back and run the test again. It now passes as expected.
Comment out preserve_mtime = True a 2nd time and run the test again. This time the test still passes with the cached test result.

For that last test run I would expect the test to not be cached since a command line argument changed for the copy directory action this test depends on.

@thesayyn observes that RBE doesn't support modification times at all. I don't think that's the cause of the red CI here though. Sahin do you have any ideas?
Also, our CI here will trigger macos if macos is in the branch name and windows if windows is in the branch name. I expect that if you re-open the PR from a branch using the naming convention you'll be able to check those tests.

@thesayyn observes that RBE doesn't support modification times at all. I don't think that's the cause of the red CI here though. Sahin do you have any ideas?

Yeah I'm realizing this as well and I don't think remote caching is also incompatible with this feature. If the artifacts are copied from a remote cache then that process is probably going to reset the modify times. I tried adding the no-remote tag to the test targets and now the Linux version of these tests appears to be working on CI.
For that unexpected sequence I posted earlier I'm guessing that both actions with preserve_mtime = True and preserve_mtime = False were hashing to the same cache value since the contents on disk was identical in both cases. I haven't dug that deep into how Bazel handles the various cache keys though so this is a guess. I added the external tag to the test only though and it now passes / fails as I expected.
These two caveats should definitely be added to the documentation.

I documented these failure modes and pushed a new PR to trigger the mac/windows CI #908


stdenv: separate assignment and export

Motivation for this change
The original code does dynamic variable evaluation, assignment and export all in one.
I thought it would be clearer to separate those 3 steps.
The function can be tested with the following script
exportAppend() {
    local ref="$1"
    local append="$2"
    eval "$ref=\"${!ref:-}$append\""
    export "$ref"
}

var1="something"
exportAppend "var1" " else"
echo $var1
exportAppend "var2" " else"
echo $var2

I'm happy to drop this PR if people disagree with the change. I thought I would propose it.
@andersk if you have an opinion I'm interested (positive or negative, happy to drop this PR).
@andychu
One thought I had was that append can't contain double quotes. I don't see why that would be the case, but perhaps I should document it.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

The incorrect quoting causes over-evaluation problems.
$ exportAppend x 'bar "baz quux"'
quux: command not found

Also, I don’t see any clarity advantage in replacing the normal syntax export x+=y with a custom function exportAppend x y? If this is for portability to osh, say that (but maybe export x+=y should just be added to osh).

(OSH author here)
Yeah I agree with the quoting issue, a possible solution is something like:
printf -v $2 %q "$1"

This is used in bash-completion:
https://github.com/scop/bash-completion/blob/master/bash_completion#L557
That function also has a lot of other "hairs" but I think it's due to needing to satisfy GNU readline input.  I think the %q should be sufficient for bash eval, since you might get a $'\n' string, but not 100% sure.
OSH currently supports
export foo${suffix}=bar

but not
export foo${suffix}+=bar

It's possible we should add the latter.  Though I agree that separating the steps is clearer code (if it can be done equivalently)

Yeah something like this seems to work, though whether it should be changed is still a question:
$  a="'single quotes'"' backslash \ "double quotes"'; echo "$a"; printf -v b %q "$a"; echo "$b"; eval "c=$b"; echo "$c"
'single quotes' backslash \ "double quotes"
\'single\ quotes\'\ backslash\ \\\ \"double\ quotes\"
'single quotes' backslash \ "double quotes"

I mean, paying sufficient attention to the evaluation order leads to a much simpler correct implementation without resorting to printf %q.
exportAppend() {
    local ref="$1"
    local append="$2"
    eval "$ref=\"\$$ref\$append\""
    export "$ref"
}

(But I still don’t buy the clarity advantage.)

Yeah you're right here. Happy to close this.


Move off JCenter/Bintray since they are being sunset

https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/

Yes, I agree that we need to find out a way to publish to Maven Central. My company is looking for a solution to do this and I will inform when it is ready. Thanks for your interest.


Doesn't seem to work well with sessions

When I use monorepo with sessions, the base dir seems to have been lost after reloading the session, making sessions and monorepo mutually exclusive...

Sorry for the long wait, I've been busy! I've added a fix for this in https://github.com/imNel/monorepo.nvim/commit/256a302900d6af6e032f1f2bf4f2407bd4569fe8. It's fairly simple and only works if your session is the base monorepo, but it's better than nothing.
Here is some code you can throw in your config if you don't want to update :)
vim.api.nvim_create_autocmd("SessionLoadPost", {
  callback = function()
    require("monorepo").change_monorepo(vim.fn.getcwd())
  end,
})

I will note though that you can probably get more granularity by using a some sort of pre hook when making a session. Pugins might expose this for you but if you're doing it manually you'll need to swap back to root before running :mksession.

Closing, feel free to reopen if you need anything else :)

Sorry for getting back so late lol, I abandoned the monorepo so I didn't look deeper. But I was wondering if there is already a function to switch back to root, so I can actually make a hook? Perhaps a switch function that takes the relative path(to switch to "/"), or just a variable exposing the root dir? I think I can just switch to no. 1, but I'm actually not sure if that will always be "/"


feat: #2425 - added "all products to be completed" item (in user page)

New files:

paged_to_be_completed_product_query.dart: Back-end paged query for all "to-be-completed" products.
tmp_to_be_completed_query_configuration.dart: Query Configuration for all to-be-completed products.

Deleted files:

contributor_product_query.dart
informer_product_query.dart
photographer_product_query.dart
to_be_completed_product_query.dart

Impacted files

app_en.arb: 1 label slightly modified, 1 added label.
app_fr.arb: 1 label slightly modified, 1 added label.
paged_user_product_query.dart: refactored around UserProductSearchQueryConfiguration.
product_list.dart: added a new list - all products to be completed (not just the user's).
product_list_page.dart: refactored.
product_query_page_helper.dart: refactored.
user_preferences_account.dart: added an item for "all to-be-completed"; refactored.

What

Added an "all products to be completed" item in user page.
In addition to the already existing "user products to be completed".
That works only if your app is in English, for reasons regarding the server redirections explained here - https://github.com/openfoodfacts/smooth-app/issues/2315#issuecomment-1170918565

Screenshot

Fixes bug(s)

Closes: #2425 #2315

Codecov Report

Merging #2441 (a76ed90) into develop (2ea0da3) will decrease coverage by 1.33%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           develop   #2441      +/-   ##
==========================================
- Coverage     8.86%   7.52%   -1.34%
==========================================
  Files          161     201      +40
  Lines         6623    9764    +3141
==========================================
+ Hits           587     735     +148
- Misses        6036    9029    +2993

Impacted Files
Coverage Δ

...kages/smooth_app/lib/widgets/attribute_button.dart
0.00% <0.00%> (-92.00%)
:arrow_down:

...s/smooth_app/lib/data_models/user_preferences.dart
8.73% <0.00%> (-23.57%)
:arrow_down:

packages/smooth_app/lib/themes/smooth_theme.dart
60.00% <0.00%> (-22.98%)
:arrow_down:

...p/lib/generic_lib/dialogs/smooth_alert_dialog.dart
15.29% <0.00%> (-18.92%)
:arrow_down:

...mooth_app/lib/data_models/product_preferences.dart
24.65% <0.00%> (-6.78%)
:arrow_down:

packages/smooth_app/lib/main.dart
14.40% <0.00%> (-3.49%)
:arrow_down:

.../smooth_app/lib/pages/onboarding/welcome_page.dart
0.00% <0.00%> (-3.13%)
:arrow_down:

.../smooth_app/lib/pages/onboarding/scan_example.dart
0.00% <0.00%> (-2.28%)
:arrow_down:

...p/lib/pages/onboarding/consent_analytics_page.dart
0.00% <0.00%> (-1.57%)
:arrow_down:

...smooth_app/lib/pages/product/new_product_page.dart
0.00% <0.00%> (-0.88%)
:arrow_down:

... and 201 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5aa231...a76ed90. Read the comment docs.

Thank you @M123-dev for the review!
I agree with you, that's probably not the best place to put it.
Anyone with a better idea will move it later.


Fix empty sourceRoot for Typescript source-maps

This PR addresses systemjs/systemjs#177 by fixing bad source file paths in output Typescript source-maps.  I'm not sure if this is the place to apply the fix, please provide feedback.
The issue is that the Typescript compiler is returning source maps with the paths stripped off, e.g. "source/api/point.ts" would have a sourcemap with no "sourceRoot" and "point.ts" as the file name.

Thanks for tracking this down! I think we should fix this by supporting source maps without a source root rather in the resolution at https://github.com/systemjs/builder/blob/master/lib/sourcemaps.js#L48 to make the implementation more flexible.

@guybedford Okay, I think I understand what you want.  I looked into it a bit and need clarification/direction.

Your link points to a piece of code inside a particular conditional for sourceMapContents.  I assume you meant this should belong in the Promise chain for processing source map files, and not specifically inside this conditional? If you did mean inside this conditional, please explain a bit about the sourceMapContents option.  It's tests/documentation don't make it very clear.

I'm having a hard time seeing how I can reconstruct the source map path inside of the sourcemaps promise chain.  It appears the compilers all return a promise with just two properties: {source: '...', sourceMap: '...'}. The reason I'm able to fix the path in the first place is because of the knowledge of the load.path value.  Should I update the compilers to pass this information along in a new property (loadPath?), or is there another way to get at the load object while processing source maps that I'm not seeing?

Thanks for the feedback.

I kind of blindly pointed to the only reference to sourceRoot, I think the point is that we need to better handle sourceRoot sanitization as part of the source maps generation process.

Every source map contains its original load.path in sourceMap.name in the source map itself as an absolute file path I believe.

I certainly don't expect you to fix all this, I'm just pointing where the issue is given this PR. Happy to create an issue to track sanitization of this area further.

Great we're on the same page there.

I think what you point out is exactly what this is fixing.  The typescript compiler (for whatever reason) spits out a sourcemap that does not contain the full path to the input file.  Here's what a sourcemap for pow-core/resources/audio.ts looks like coming back from the compiler:

{
	"version": 3,
	"file": "audio.js",
	"sourceRoot": "",
	"sources": ["audio.ts"],
	"names": ["AudioResource", "AudioResource.constructor", "AudioResource.supportedFormats", "AudioResource.fetch", "AudioResource.play", "AudioResource.pause", "AudioResource.volume", "AudioResource._loadAudioBuffer", "AudioResource._loadAudioElement"],
	"mappings": "..."
}

@justindujardin ah I see, this PR does sound like the better approach then to ensure the correct behaviour. Perhaps instead of setting sourceRoot, the file value can be made to be a full load.path?

I gave a shot at setting the file value to load.path and it appears that sourceRoot is significant in some non-obvious way. The path looks correct in the modified source map for the individual files, but when they're concatenated the path appears to be lost:
input = source/pow-core/resources/audio.ts
destination = lib/pow-core/pow-core.js.map
output sourceRoot = ../../source/pow-core/resources/audio.ts
output file = ../../source/audio.ts
I don't see any usages (other than the one you originally pointed out) of sourceRoot in the builder project, so I must assume some other source map processing code is taking it into account.

@justindujardin I think that output is correct actually - ../../source/audio.ts being the only way we can know how to trace back to the original source without any further information. This is done in https://github.com/systemjs/builder/blob/master/lib/sourcemaps.js#L87. What would you expect the output to be?
It may be worth having a sourceRoot option in the builder itself to alter this path, but by default it assumes the baseURL itself I believe.

@guybedford when do you think this change will be released?

@guybedford apologies--I forgot to follow up on this.
The path ../../source/audio.ts is not actually correct, so when it is resolved with the basePath in the builder, it points to a bad location.  The file exists in ../../pow-core/resources/audio.ts where pow-core/resources is stripped off without the proper sourceRoot on the source map. I'm sorry I don't fully understand exactly why this is happening, but I have no more time to dig into it.


Assertion failed: (I != ValueMap.end() && "Value not in slotcalculator!")

Assertion failed: (I != ValueMap.end() && "Value not in slotcalculator!"), function getValueID, file /tmp/llvm20151214-69554-hagc7s/llvm-3.6.2.src/lib/Bitcode/Writer/ValueEnumerator.cpp, line 409.

Seeing this with crystal 6c8be57 and crystal-pg cafe5a1, but everything runs fine seems more like a warning.

What happens when you compile with VERIFY=1?

I can't seem to reproduce it. Did you compile 6c8be573397981bcdd355df7cfab12da84cbb10b with Crystal 0.16.0 or 0.17.0?

Finally, how to get that assertion failed? I did ccrystal spec at crystal-pg, both at HEAD and the revision you mention.

Oh, with VERIFY=1 I also get the same error... Definitely a bug. I should have tried with that flag...

*Sigh*... I guess I'll release 0.17.2 soon :-)

You did reproduce it then?
Compiled with 0.17.0

Yes. This reproduces it:
class Foo
  BAR = 42

  @z : Int32

  def initialize
    @z = pointerof(BAR).value
  end

  def z
    @z
  end
end

Foo.new.z

Compiled with VERIFY=1 it gives an error.
Interestingly, this crashes 0.16.0: https://play.crystal-lang.org/#/r/yuc

@will I just pushed a fix to the release/0.17 branch. Could you check that it works well now?
I was able to compile fine but can't connect to the amazon instance anymore, but I don't know if it's shut down now.
I also compiled a few other projects with VERIFY=1 and they all compile fine. I'll probably release 0.17.2 tomorrow with this fix (I'll wait a bit in case you find other bugs 😄)

@asterite crystal/d8895a4 looks good, specs work with/without VERIFY=1 and the openssl is working.

@will \o/
I guess I'll start the release now then. I hope the homebrew team doesn't mind accepting another PR after such a small time.
Final question: what about 5e83d266b73b1e8912bb52f61fe1a71cd231ad60 ? It's the revision I'll tag as 0.17.2

5e83d26 is good

I'm closing this as it's fixed in 0.17.2


fix: fixed typo

Fixed a typo.
"warpper" to "wrapper"

Thanks.
Can we optimize commit message? refer to contributing doc.

Apologies, fixed.

Please refer to the message style guide here, and useless commit history needs to be removed.

I think I updated to the correct format, but, I have no idea on how to delete a commit (and me deleting the original repo definitely did not help - you live n learn). I made a new pull request here.


Remove nonexistent requires from sidekiq_init

Specs pass locally - currently won't run on circle due to a permissions issue.


Event template is not applied for all day events (ver. 3.3.0)

I have defined an event template:

Thanks for reporting @green-pigeon.
Please provide the  code that you use.

I figured out, now fixed in version 3.3.1.
Demo: https://codepen.io/antoniandre/pen/xxZbKrO?editors=1010

Thanks.
I confirm it is fixed.


Mcface doesn't work

http://alanaktion.net/mcface.php?user=derpolino : file not found

Fixed in aab83034238db70d698735ba7200e85469de7589.


Add azure app service plan module

Adding to the Azure offerings in terratest #89
Adding App Service Plan module #548
Adding .terraform-version for anyone using tfenv to manage their terraform versions.

Please see https://github.com/gruntwork-io/terratest/issues/89 for the status on Terratest with Azure. In particular, we're starting some work around it, and when that work is done, we'll be able to come back to this PR!

@rguthriemsft go for it. I have been swamped and unable to visit this stuff in a while. Hoping to get back into this stuff in a couple months.

@tsalright I think I have access to your fork, if not will ping you.  I might pull the branch into our fork so I can run CI will let you know if I hit issues.

@rguthriemsft sounds good.


implementing a 'model' class

maybe it would help with the statistics, fitting, etc routines to have a 'model' class. this class would be like a function, but the parmeters of the model would be an attribute. this way you can be really strict about the function signatures. this also means you wouldn't need to constantly specify params=... in these fit functions. you instead would only have to pass model=... and the fit function would figure out the rest

you may need to do something like have 'parameter' objects that inherit from np.array or something. then you could do checkType(params,parameter) along with making sure the signature only has one argument to enforce the function has a particular form.


Model weights on panoramic image training

Hi!
Congratulations on your work!
Will you release the model weights for the panoramic images/training code for it?
Besides, in the paper you mention that you also tried to train the model with 50k images and then fine tune it with the Matterport 3D dataset. Did you obtain those 50k real world images using the Matterport camera?
Thanks in advance!

For now, we do not have a plan for that. We obtained the images with our own camera.


Remove '-Wextra' as default user flags for the Linux clang targets

We have '--strict-warnings' for this kind of stuff...  also, user
flags are added last, so this overrides any warning supression
--strict-warnings may put in place (for good reasons).
Fixes #5609

Merged.  95ea8da1768bf457b021f07cde9a6330827dc8a1


Allow infinite integration span

Hello,
This pull request aims at answering #225, which itself originates from an Orekit need expressed in issue #1005.

This change seems OK to me.
Could you add two basic tests (one for the double version, one for the field version)?

Hi Luc, thank you for the review.
I have added tests for EmbeddedRungeKuttaIntegratorAbstractTest and EmbeddedRungeKuttaFieldIntegratorAbstractTest.
I could also add them for the remaining integrators if it is required.


beta.4

[x] Handle transform types to pass media queries
[x] improve TypeScript typings
[x] rename createStyles to createStyleSheet - to be dicussed
[x] improve docs with themes and variants
[x] double check other nested styles like shadowOffset

I have this ts issue with applying shadows with a dynamic function in beta 3 (not sure if it's fixed in b4)

theme

shadow: {
  $none: {},
  $xs: {
    shadowOffset: {
      width: 0,
      height: 1
    },
    shadowOpacity: 0.18,
    shadowRadius: 1.0,
    shadowColor: 'black',
    elevation: 1
  }
}

createStyles

const stylesheet = createStyles((theme) => ({
   shadow: (shadow: Shadow) => theme.shadow[shadow],
})

component

 <TouchableOpacity style={[styles.shadow(shadow)]}

ts error on styles.shadow(shadow)

No overload matches this call.
  Overload 1 of 2, '(props: TouchableOpacityProps | Readonly<TouchableOpacityProps>): TouchableOpacity', gave the following error.
    Type 'unknown' is not assignable to type 'Falsy | ViewStyle | RegisteredStyle<ViewStyle> | RecursiveArray<Falsy | ViewStyle | RegisteredStyle<ViewStyle>> | readonly (Falsy | ... 1 more ... | RegisteredStyle<...>)[]'.
  Overload 2 of 2, '(props: TouchableOpacityProps, context: any): TouchableOpacity', gave the following error.
    Type 'unknown' is not assignable to type 'Falsy | ViewStyle | RegisteredStyle<ViewStyle> | RecursiveArray<Falsy | ViewStyle | RegisteredStyle<ViewStyle>> | readonly (Falsy | ... 1 more ... | RegisteredStyle<...>)[]'.ts(2769)

@atanaskanchev - it should work in beta.4 - I improved types a lot

@jpudysz still an issue with b4

@atanaskanchev it's because $none is invalid (empty object):
You can quickly fix it by either removing $none or adding any style:

Nevertheless, if StyleSheet supports empty objects, then react-native-unistyles should too. I will add it to beta.5

Ah, thanks, makes sense! The error is gone if I remove the empty object. Thanks for the quick turnaround though! I've started to build an app with the library and so far I'm a happy camper (after jumping back and forth between nativewind, twrnc, tamagui and fast-styles :-)

Thank you, @atanaskanchev; that means a lot to me!
Spotting such things improves the lib a lot 🙏

Fixed in #18


Warlock 225 tier pieces are not counting toward the set bonus

Describe the bug
Only the 232 items are counting toward the set bonus for Warlocks
The 225 items dont become yellow or "active"
To Reproduce
Steps to reproduce the behavior:

Go to Warlock
Equip any combo of 225 and 232 tier items and see what it shows as equipped

Expected behavior
225 tier items should still count toward the set bonus
Sim Links and Screenshots
[If applicable, add links to your sim settings or screenshots to help explain your problem.]
(https://wowsims.github.io/wotlk/warlock/#eJzjUuBgEmAyYLJg9GCMYCxgamBknMDIuIGR6QAj4wVGxheMjE78HIwKTAaMDowBjAWMKxgZhRikjrE2MbIF5CRWphZxsAhwSG1l5OIXOLGFSeKNrBLb0UNM+3YwcXEKfL3DpMR8C8jkEXixm0nikawSM0iCXeAqkNclC9Sy8wWTxA+gFqDwZ6AMl8Dth0wSc4SUGBm4eAVeP2KSmCKjxAKUZACa9u8JE0Q/v8AboEw7RBvEwFNAbdNkuFgETj9mApL9+0Dkq70gcv8ukI59z5gk+uSU2G5BdDAAJRZsY1Li4mA0YLRgDGCNYF3EdJaJawYTwyjACoQMSNVRxcHBKMAkwVTAmCUGTAEsEsBUpAEKbiYpNqAMkN/FGGxkbGpgYGBkYAwkjE0NDYxMQQLGxoaGpoa6BriBrqkpmAZqQQePGAU4bj5lEpjbzixx+SmTwt9LTC8YWT4wcs9iZOiExq+lwy1GhllMDEqPmTjBAg1pDoIQKREHyVkzQeCkvSVE5IK9YhoYXLM32sykECzBqkXjdPKh0YEaxjScPEIVc0gBkDDb+97BEcL/YZ/AGIQ1Z1WLrHN/WNViz3V9cYEt13F7j4dVIBF7iOwHe5i6w181YvoPvbX/BqK+PrB/E7hDrvX1S3t084YqID1nAQCiKpvH)
For instance in this link you can see a combo of T7 ilvl gear showing the set bonus. 200 head and 213 shoulders
However, the hands and legs which are 225 down count toward the T8 set bonus but the 232 chest does
Desktop (please complete the following information):
Firefox Windows 11

It's just a visual bug.

This is a visual bug with wowhead tooltips, there's nothing we can do about it, see also #2431.


inbox: Merged PR 3330475: Synchronize the font between the WDDMCon Renderer and the SCREEN_INFORMATION

Synchronize the font between the WDDMCon Renderer and the SCREEN_INFORMATION when the OneCore Interactivity library starts up. #21717424
Retrieved from rs_onecore_dep_acioss ccca0315e7db34c09f5fcd9dfabae666ede1687b
Fixes #958.

This doesn't seem right. GitHub, why?


Patch 3.6.2 breaks build for non-English locales

Describe the bug
Using MSTest.Adapter and MSTest.TestFramework at version 3.6.2
Steps To Reproduce

Use a non-English locale (for example, French)
Create a new WinUI 3 project in Visual Studio
Add a test project to the solution
Update the test project's dependencies to the latest versions
Try to build and run the tests

Expected behavior
The project should build and execute the example test cases.
Actual behavior
The build fails with APPX1101; multiple DLLs are duplicated between MSTest.Adapter and MSTest.TestFramework.
Additional context
The key to the problem seems to be the system locale. All of the duplicated DLL files during my testing were under fr subdirectories, found inside for example the mstest.testadapter\3.6.2\build\_localization and mstest.testframework\3.6.2\lib\net8.0 directories. Those do not contain anything for English locales, hence why the issue doesn't seem to arise on a system with an English locale set.

Thanks for reporting, this is most likely related to this change that fixed copying the resource files, they were not copied properly before. https://github.com/microsoft/testfx/pull/3949
And caused by the filter in this change https://github.com/microsoft/testfx/pull/3874 not being strict enough. It should most likely not copy the Framework or ObjectModel dlls.

https://github.com/microsoft/testfx/pull/3874 is not on 3.6 at all, backporting and fixing.


Build and attach acme.js to release

Proposed changes
Adds a Github action that runs on Release creation that builds acme.js and attaches it to the release.
Checklist
Before creating a PR, run through this checklist and mark each as complete.

[x] I have read the CONTRIBUTING document
[x] If applicable, I have added tests that prove my fix is effective or that my feature works
[x] If applicable, I have checked that any relevant tests pass after adding my changes
[x] I have updated any relevant documentation (README.md and CHANGELOG.md)

You rock, @ryepup !


explicit (but same) lineSeparator in separate editors causes extra \r on copy/paste

This may be Windows-specific (or any platform that uses \r) but...
If there are 2 editor instances, and both have an identical, explicitly-set lineSeparator: "\n", copy-pasting from one to the other causes each line to have an extraneous \r char at the end of every pasted line. These should probably be stripped pre-paste to match the target editor's eol.
I tried to mitigate the situation for now by using the paste event, but it didn't have any effect. prolly cause it fires after the fact?
cm.on("paste", function(cm, e) {
   e.clipboardData.setData('text/plain', e.clipboardData.getData('text/plain').replace(/\r/gm, ''));
});

I'd prefer not to have to modify the contents post-paste or other hackery.
thanks!

Does this also happen if you paste in text from elsewhere (say, copied in your native text editor)?

yes, but only when the editor's eol is set to \r\n

I could reproduce the latter problem (pasting from native content) but not the issue with pasting between CodeMirror instances. Attached patch makes it so that pasted content always has its line endings adjusted to the current editor's convention, which seems the preferable behavior. Does it solve your issue?

appears to be resolved 👍


Unable to romanize with full katakana strings

I'm not sure if this is in the scope of cutlet, but it looks like any katakana-only sentences / phrases seem to not romanize:
% cutlet
アマガミ Sincerely Your S シンシアリーユアーズ
アマガミ Sincerely Your S シンシアリーユアーズ
ケメコデラックス
ケメコデラックス

Thanks for the report. All-katakana strings are in scope, and so this is a bug.
There are a couple of things going on in your example text here. The main problem is not actually that the words are just katakana, it's that words not in the dictionary are output as-is, even if they're in katakana or hiragana. I fixed that and will make a release soon. You can try it out with the latest commit.
Dealing with words not in the dictionary is easy if they're ascii or kana, but it gets harder if they're something else. What about kanji not in the dictionary, or ghost character with no readings like 彁? What about cyrillic or hangul? The old strategy was to output all unks as-is. The main branch currently does replaces unknown kanji with question marks but returns other characters as-is. I may change that, I need to think about it more.
Another thing that's happening here is that "Your" is blowing up into four tokens. This is a tokenizer dictionary issue that happens sometimes when you have lots of English words in a row. This can be fixed by tweaking dictionary settings, I'll take a look at it later.
Thanks again for the bug report, let me know if you have any questions.

I believe the just released v0.1.6 fixes this so I'll close this issue, but please feel free to reopen or comment if you have any other questions or problems.

Note that the issue with "Your" turning into four tokens should be resolved with the 1.0.7 release of unidic-lite or the latest release of unidic-py (unidic on pypi).


Very slow scrolling in egui combo boxes

When using a ComboBox, the scrolling speed is extremely slow - to a point where dragging the slider with the mouse is the only option. I have verified this with standalone  egui and this seems to only happen in the notan integration.
This is an example building upon the egui_basic example:
use notan::egui::{self, *};
use notan::prelude::*;

#[notan_main]
fn main() -> Result<(), String> {
    let win = WindowConfig::new()
        .vsync(true)
        .lazy_loop(true)
        .high_dpi(true);

    notan::init()
        .add_config(win)
        .add_config(EguiConfig)
        .draw(draw)
        .build()
}

fn draw(app: &mut App, gfx: &mut Graphics, plugins: &mut Plugins) {
    let mut output = plugins.egui(|ctx| {
        egui::SidePanel::left("side_panel").show(&ctx, |ui| {
            ui.heading("Egui Plugin Example");

            ui.separator();
            if ui.button("Quit").clicked() {
                app.exit();
            }

            let mut selected = 1;
            egui::ComboBox::from_id_source("Imageops")
            .show_ui(ui, |ui| {
                for i in 0..100 {
                    ui.selectable_value(&mut selected, i, format!(" item{i}"));
                }
            });

            ui.separator();
            ui.label("Welcome to a basic example of how to use Egui with notan.");

            ui.separator();
            ui.label("Check the source code to learn more about how it works");
        });
    });

    output.clear_color(Color::BLACK);

    if output.needs_repaint() {
        gfx.render(&output);
    }
}

It's probably something related to my implementation, I'll check it, thanks!

I've noticed this is not limited to ComboBox. I get the same issue with a ScrollArea too.

I'd also be interested in seeing this fixed. The problem seems to arise from how notan uses number of lines for scroll height, but egui expects pixels. I'll leave useful links that might help in solving this.
The issue can probably be fixed in one of these locations:
notan window scroll event handling: https://github.com/Nazariglez/notan/blob/d3230a5/crates/notan_winit/src/mouse.rs#L31
notan forwarding scroll to egui: https://github.com/Nazariglez/notan/blob/c7d240c/crates/notan_egui/src/plugin.rs#L188
And these might help decide on how to fix it:
How eframe handles scroll on native: https://github.com/emilk/egui/blob/7215fdf/crates/egui-winit/src/lib.rs#L551
How eframe handles scroll on wasm: https://github.com/emilk/egui/blob/7215fdf/crates/eframe/src/web/events.rs#L405

This is great, I am planning to take a deep look to the egui integration for next version, and this must be fixed for sure there. I hope to have something working on the breaking or develop branch in the next weeks.
Thank you all for the information, and thanks @Olaroll for debugging and looking the internals to give me some hints where to look.

This is already fixed on #256 although it will take a "while" before it's merged to develop. Also, develop is a breaking branch, so if this is important for you now and don't want to wait/address breaking changes in the next weeks, we can plan to release 0.9.5 whit this change. What do you think?
Thank you everybody for the work here.

Thank you so much, this is absolutely great!
I don't mind waiting, but if this is something you feel good about to release in 0.9.5 I would be happy - whatever is most convenient for you!

Just a comment: First of all, thanks for fixing this!
I noticed that zoom speed seems to have increased. I do get a +50/ -50 delta on mouse wheel scroll now as a notan event, and also touchpad scrolling seem faster. This is not an issue (I am dividing by 10 and min/maxing the amount) but maybe this is something that happened as side effect.


Fix the use of accuracy option in _correct()

The slider value stepping behavior seems to be incorrect when I use custom min/max/accuracy setting. Please see an example here. When I set min=-4, max=4, accuracy=0.04 I expect it to step on the values -4, -3.96, -3.92, ... -0.04, 0, 0.04, ... 3.96, 4. But instead, the current implementation steps: -4, -3.04, -2.04, -1.04, 0, 1.04, 2.04, 3.04, 4.
The keyboard callback appears to be configured as the former in Metro.events.keydown callback.
Anyway, my pull request should fix this (if what I have in my mind is what is intended).

please create PR to 4.3.3
https://github.com/olton/Metro-UI-CSS/blob/master/CONTRIBUTING.md#pull-request-guidelines

This fix is wrong


Add helm linting to the repository

This adds helm linting to the repository.  There are several lint failures
which will be fixed in a followup PR.  The main objective of this work is to
start transitioning from circleci to prow.  In order to do that, I need to
understand how prow is configured.

placing on hold for a week or two until new prow gets sorted out.  If new prow takes longer then a few weeks, we are going to transition the repo to prow so we have plenty of time to stabilize any flakey operation of the tests.

/test all

@sdake: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-lint.sh
50e94ef5769966e8dd75e1fe1fbd82556c0ceed1
link
/test istio-lint-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdake this is failing because we are using helm &version.Version{SemVer:"v2.7.2", GitCommit:"8478fb4fc723885b155c924d1c8c410b7a9444e6", GitTreeState:"clean"} on the builder image and it doesnt support -f in lint

@howardjohn going to abandon this PR as after learning about prow, this implementation isn't consistent with our plans in T&R.
If you wish to take it over feel free to clone it.


Update Timber to 4.1.2

Changelog https://github.com/JakeWharton/timber/blob/master/CHANGELOG.md#version-412-2016-03-30

Current coverage is 81.42%

Merging #148 into master will not affect coverage as of eac6f3e

@@            master    #148   diff @@
======================================
  Files           37      37
  Stmts          549     549
  Branches        47      47
  Methods          0       0
======================================
  Hit            447     447
  Partial         29      29
  Missed          73      73

Review entire Coverage Diff as of eac6f3e

Powered by Codecov. Updated on successful CI builds.

Should not affect us since we have 0 lint warnings / errors anyways :+1:

:+1:


workflow.parameters cannot be referenced in synchronization field

Summary
workflow.parameters cannot be used in synchronization (both mutex and semaphore) after upgrading from v2.11.7 to v2.12.4. I am using it in WorkflowTemplate if that matters.
Diagnostics
What Kubernetes provider are you using?
EKS v1.15.12-eks-31566f
What version of Argo Workflows are you running?
v2.12.4
apiVersion: argoproj.io/v1alpha1
kind: WorkflowTemplate
metadata:
  name: semaphore-ref
spec:
  entrypoint: whalesay
  arguments:
    parameters:
      - name: semaphoreConfigMapKeyRef
        value: ""
  synchronization:
    semaphore:
      configMapKeyRef:
        name: my-config
        key: "{{workflow.parameters.semaphoreConfigMapKeyRef}}"
  templates:
    - name: whalesay
      container:
        image: docker/whalesay:latest
        command: [cowsay]
        args: ["hello world"]

$ kubectl logs
Failed to acquire the synchronization lock. configmaps "{{workflow.parameters.semaphoreConfigMapKeyRef}}" not found

apiVersion: argoproj.io/v1alpha1
kind: WorkflowTemplate
metadata:
  name: mutex
spec:
  entrypoint: whalesay
  arguments:
    parameters:
      - name: repository
        value: ""
  synchronization:
    mutex:
      name: "{{workflow.parameters.repository}}"
  templates:
    - name: whalesay
      container:
        image: docker/whalesay:latest
        command: [cowsay]
        args: ["hello world"]

Paste the logs from the workflow controller:
$ kubectl logs
time="2021-01-17T11:10:04.994Z" level=info msg="argo/Mutex/{{workflow.parameters.repository}} acquired by argo/picnic-argo-gh-m2ppc " mutex="argo/Mutex/{{workflow.parameters.repository}}"

Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

@sarabala1979 ?

@sarabala1979 ?

I will take a look

I will take a look

Current design spec level synchronization doesn't support the parameter substitution.  But Template level synchronization will support the parameter substitution.
apiVersion: argoproj.io/v1alpha1
kind: WorkflowTemplate
metadata:
  name: mutex
spec:
  entrypoint: whalesay
  arguments:
    parameters:
      - name: repository
        value: ""
  templates:
    - name: whalesay
       synchronization:
          mutex:
             name: "{{workflow.parameters.repository}}"
      container:
        image: docker/whalesay:latest
        command: [cowsay]
        args: ["hello world"]

Current design spec level synchronization doesn't support the parameter substitution.  But Template level synchronization will support the parameter substitution.
apiVersion: argoproj.io/v1alpha1
kind: WorkflowTemplate
metadata:
  name: mutex
spec:
  entrypoint: whalesay
  arguments:
    parameters:
      - name: repository
        value: ""
  templates:
    - name: whalesay
       synchronization:
          mutex:
             name: "{{workflow.parameters.repository}}"
      container:
        image: docker/whalesay:latest
        command: [cowsay]
        args: ["hello world"]

Is there any plan to support it at the workflow level?

Is there any plan to support it at the workflow level?

Currently, we don't have a plan. Please create an enhancements Issue. Based on thumbs up. we will prioritize.

Currently, we don't have a plan. Please create an enhancements Issue. Based on thumbs up. we will prioritize.

Can we rename this issue and edit labels?

Can we rename this issue and edit labels?

@sarabala1979 do you want to own this? It is the 6th most popular issue now.

yes I will do it


Allow for mobile only campaigns

Some campaigns are only going to be displayed in the mobile app and not in the web app at all.
The easiest solution is to leave campaigns unpublished, and return unpublished campaigns with the on_mobile_app field checked via the api.
Things to check for unpublished campaigns

[ ] users can signup
[ ] users can reportback
[ ] kudos work

So I think there are going to be some inherent issues with doing some hacky code to make these work w/ the whole unpublished approach, and users being able to sign up for it. There's core drupal access stuff that I'm concerned is going to be a major hassle to hack around to make it work :\

@angaither @jonuy I'm adding steps below for how to think about approaching this and would appreciate feedback!

mobile app user signs into mobile app

authentication via Northstar API

mobile app user clicks to view mobile only campaign

request to Drupal API to obtain unpublished/on_mobile_app campaign data

mobile app user signs up for mobile only campaign

request to Northstar API to sign user up for campaign (?)

mobile app user submits reportback

request to Drupal API to post reportback as authenticated NS user (endpoint doesn't currently exist)

need to flesh out more, but some initial thoughts on process

@weerd sounds good, and I think we will be ok with unpublished content since the singup/reportback function isn't in drupal core and doesn't care about the status of the node.
The only other thing is step 4 can be to the northstar api

After some digging, I'm going to add a ?published=false parameter to the URL for the /campaigns endpoint, so we can filter by ?mobile_app=true&published=false and thus be able to select for the campaigns we want on mobile app only.

I'm just going to reiterate that I feel this solution will end up causing more problems than it solves. It'll make it work for the short run, but I feel we're going to run into problems later on, plus it might also be confusing to campaign creators to remember that mobile app campaigns are not published until the on_mobile_app is checked, and the publish checkmark needs to be left unchecked... seems counterintuitive. ¯_(ツ)_/¯

It doesn't sound like we actually need the ?published flag. Not all campaigns shown on the mobile app are exclusive to just the mobile app. I'd say a majority would actually be available on the web. So if ?mobile_app=true gets us both published and unpublished campaigns already, I think we've got our workaround solution in place as far as querying for campaigns.
We do still want to test if signups and reportbacks from the API to unpublished campaigns can work though. And based on what I remember from some SMS tests, I don't think they currently do. :\

From what I recall too, I do think there's code in the Signup/Reportback entity classes that doesn't allow activity on unpublished campaigns.
I agree with @weerd's concerns above. Could we add a boolean field like field_mobile_app_only instead of using "published/unpublished" ? I like this approach better than a different campaign_type value, since a campaign could be available on the web for some runs but perhaps mobile only on others.
Also - Would we ever want to house landing pages on the web for a mobile only campaign?

The reason @mshmsh5000 suggested we go this route is because we don't want the campaign to display on the site at all. We would have to do some trickery to hide it from solr and /campaigns

We have to do trickery on one side (activity against unpublished campaigns) or the other (hide some published campaigns from the web & Solr). My bet in the abstract was what @angaither described, but I will obv defer to reality here.
Just try submitting a signup and reportback against an unpublished campaign and see what happens. If it doesn't work for reasons that are difficult to address, then you'll need a search index hook to remove campaigns with a mobile-only flag, and to suppress them from a sitemap.xml, as well as perhaps some intervention for web requests that happen to find them.
Either way, we're engaging with Drupal plumbing.

@aaronschachter just to clarify, the idea w/ campaign_type would be adding a new type, something like Mobile Campaign so there's 3 options:

Campaign
SMS
Mobile Campaign

Selecting type of Mobile Campaign means it only shows up on mobile... if a campaign is available on both web and mobile, then you'd select a type of Campaign and rely on the on_mobile_app checkbox, so it applies to both.
Your point regarding landing pages for mobile campaigns to help drive to traffic to mobile app is intriguing...
The big caveat is some effort would be involved, and then there's Solr as @angaither mentioned, which would be a pain to update, but might need to be updated in the near future for global concerns anyhoo.
@angaither hiding from /campaigns shouldn't be a big deal cause I have an initial approach already in the Campaign API/Transformer stuff that's looking at the type.
I've chatted with @angaither about this, and with @jonuy this morning and seems like for now we can roll with how it is and no need for the ?published=false parameter as @jonuy mentioned. It'll do for now and looking into the concerns regarding signup/reportback when campaign is unpublished.
Still good to discuss and weigh the options :)

@mshmsh5000 yep yep! I'm doing some testing on trying to submit w/ unpublished campaigns and will let you all know what I find...

Doesn't look like you can sign up for an unpublished campaign. Is there a difference between active and published?

Yes -- active is a value in thefield_campaign_status, which is set to closed when a campaign has been closed.

Checked that and on the campaign the status is set to active but I'm getting the 403 code above.

So in *dosomething_campaign.module there's a function that checks for both whether a campaign is active and published which gets called when signing up a user for a campaign:
function dosomething_campaign_is_active($node) {
  // Node must be published, and campaign status != closed.
  return /*$node->status == 1 &&*/ !dosomething_campaign_is_closed($node);
}

By commenting out the check for $node->status == 1 we can side-step it....

@weerd  we could can update that check to say (warning: pseudo code)
 // If it's a mobile campaign, just check if the campaign is closed
 if ( $node->mobile_app_field == 1 && !dosomething_campaign_is_closed($node)) {
   return TRUE;
 }
 // otherwise make sure the node is published
 else if ($node->status == 1 && !dosomething_campaign_is_closed($node)) {
   return TRUE;
 }
 // the node is unpublished or closed, NO SOUP FOR YOU
 return FALSE;

If we go the route of publishing and excluding from search/sitemap
from what I can tell... we can't just disallow it in dosomething_search_apachesolr_query_alter with dosomething_search_filter_types because we don't have the node at that point.
it looks like there's a hook_apachesolr_exclude which has the node and we can check values to exclude the node from that point.
as far as exluding it from the sitemap, it looks like we need to to that on a node by node basis, which doesn't look so terrible since it's only a couple of nodes.
cc @blisteringherb

@angaither related to the pseudo code you suggested above, we could actually go a level above to the function that calls that functions which is the _campaign_resource_access_alt() which actually turns out to be a function that I've indicated is meant to be deprecated to begin with:
https://github.com/DoSomething/phoenix/blob/d70a566f4cca97aff4a2ce981128c630abb02ad9/lib/modules/dosomething/dosomething_api/resources/campaign_resource.inc#L201-L224


Does System.StageAttempt really increment when the job is retried?

I assume this is a typo:

Set to 1 the first time this stage is attempted, and increments every time the job is retried.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 11d3469c-83c2-c2f6-41d0-08f82c330bbc
Version Independent ID: a373c48d-6395-3002-d2d8-bbc1fea2e48e
Content: Predefined variables - Azure Pipelines
Content Source: docs/pipelines/build/variables.md
Product: devops
Technology: devops-cicd-build
GitHub Login: @juliakm
Microsoft Alias: jukullam

@dagood  Thank you for the feedback.
Yes, this is the documented behavior.  Are there instances where this is not incrementing?
For product-related issues, please move this to the Azure DevOps community to solicit additional feedback.
A similar post can be found here.

Hmm. I thought it would simply be a typo, where "the job" was meant to be "this stage".
I'm lost what this line means, then, so I can't say whether there's a behavior mismatch. 😕 If StageAttempt is intended to increment every time "the job" is retried, what is "the job"?

Perhaps, though System.PhaseAttempt is also seemingly tied to only the job rerunning.
Assigning this to the author for further review.

Yeah, PhaseAttempt appears to have a similar typo and is similarly incomprehensible to me if it's not a typo. 😛

Looks like this has been fixed. See https://developercommunity.visualstudio.com/content/problem/1093182/systemstageattempt-set-to-incorrect-value-on-serve.html.

That bug looks unrelated to me. The (presumed) doc bug is still in the docs.