No license is provided

Hi @MauriceConrad,
this is a brilliant component, looks to be working really well both on desktop & mobile.
I'm considering using in my project (with a free & commercial versions in the future); wouldn't you mind adding a license? (e.g. vue has MIT license).
Much appreciated!

added :)


Progress jumps in 2.3

Animation jumps if animation is not completed yet and we set new progress value.
Even incorrect value can be set, like in mentioned above example:
self.progressView.setProgress(1.0, animated: true)
//....and when I call during animation progress
self.progressView.setProgress(0.5, animated: false)
last call initiates remove of animation. And it calls animationDidStop delegate method asynchronously, even after proper progress is set. So after 0.5 is set, 1.0 will be set in animationDidStop in a moment
Version 2.2 without animation delegate works fine

i can confirm that

Look like this change broke that:
a7f53525b8250e8a416e055c2f29e9b622f4a8f1
The issue is that this bit of code was moved inside the else and not executed in the animated block:

   self.circularProgressLayer.progress = pinnedProgress;

Moving it out of the else again fixes the issue.

+1

hi guys! FYI hi tried to make that change but didn't work, but I manage to solve it, look the PR:
https://github.com/danielamitay/DACircularProgress/pull/67
hope it helps.
BTW, sometimes animations don't work at all, but I don't know exactly when and so why, because any of the progress views in the app work, so maybe is related somehow w/ the network layer... but I would say it started to happen when updated to >= 2.3


Bump Laravel Scout linked version in readme

Just a tiny update to the readme. Thanks for all of your work!

Hey @stevebauman, I wanted to avoid updating Laravel documentation links every new release, that why I tried to use master as a reference whenever possible. It's not necessarily, that someone who uses this package has scout 8.x installed, it might an earlier version, so pointing to a specific scout version also doesn't make a lot of sense to me. Please let me know what you think 🙂


[docs] fix links to docs in header (missing "/apps")

Update header to fix link to docs page(s)
Noticed this while working on https://github.com/svelteuidev/svelteui/pull/235
Before submitting the PR, please make sure you do the following

[x] Read the Contributing guide
[x] Prefix your PR title with [@svelteui/core], [@svelteui/actions], [@svelteui/motion], [@svelteui/core], [core], or [docs].
[x] This message body should clearly illustrate what problems it solves.

Tests

[x] Run the tests with npm test and lint the project with yarn lint or just run yarn repo:prepush and check to see if it's passing.

Nice catch 😄 thank you!

No problem, thanks for taking a look at the PR! :bow:


LSP:  Bad highlighting when using generic functions

I just wanted to create a table component that accepts different structs, but notice that the syntaxhighlighting got messed up after the generic declaration. here is a screenshot of the issue:

also the code:
type GenericInterface interface {
	Hello(name string) string
}

//Right Highlight
templ NoGenHello() {

		Hello, no generic

}
//Bad highlight
templ GenHello[T GenericInterface](obj T) {

		{ obj.Hello("Templ") }

}

Hi, thanks for the report.
The LSP doesn't actually handle the syntax highlights, that's left to the editor plugins at the moment. So to continue I'll need to know which editor you are using? Vscode or nvim?

I'm currently using vscode

Highlights fine in neovim.
In Templ:

In Go:

Though, in my VSCode, it looks fine, the same as a normal go generic func.
In Templ:

In Go:

Neovim, highlights the generic part in both Templ and Go which vscode doesn't, but I think that's just cause neovim has better highlighting than vscode in Go in general thanks to tree sitter.


Android build fails with React Native v0.61 due to version conflict

Describe the bug
The Android build fails with React Native v0.61.5 due to a version conflict with androidx.annotation:annotation.
To reproduce
✓ I have tested this issue on the latest Detox release and it still reproduces.
Steps to reproduce:

npx react-native init AwesomeProject --version 0.61.5
cd AwesomeProject
yarn add detox --dev
Add Detox to the Android project
Add Kotlin
Create the test class
Add the Android configuration to package.json
npx detox build --configuration android.emu.debug

The build then fails with:
Could not determine the dependencies of task ':app:preDebugAndroidTestBuild'.
> Could not resolve all task dependencies for configuration ':app:debugAndroidTestRuntimeClasspath'.
   > Could not resolve androidx.annotation:annotation:{strictly 1.0.0}.
     Required by:
         project :app
      > Cannot find a version of 'androidx.annotation:annotation' that satisfies the version constraints:
           …

This issue does not reproduce with the React Native demo project because it explicitly depends on androidx.appcompat:appcompat:1.1.0 whereas the default React Native template does not.
The same issue has been reported in https://github.com/wix/Detox/issues/1534, https://github.com/wix/Detox/issues/1537, https://github.com/wix/Detox/issues/1583, and https://github.com/wix/Detox/issues/1631.
Environment

Detox: v15.1.4
React Native: v0.61.5
Node.js: v12.15.0
OS: macOS

@sonicdoe did you try to read through the versions conflict troubleshooting guide? If not, please review it - I hope it'd help.

I don’t think the Kotlin version conflicts apply here. There are some workarounds such as https://github.com/wix/Detox/issues/1534#issuecomment-512270679, however, Detox should arguably work out of the box with the latest React Native version.
Would it be feasible to relax the androidx.annotation:annotation version constraint?

The point was to apply the same technique in the scope of the annotation dep. (rather than kotlin).
The resolutionStrategy is indeed another way of solving that, you can use either.

Would it be feasible to relax the androidx.annotation:annotation version constraint?
I will have to take a deeper look at that.

Rereading my comment from yesterday, I hope “Detox should arguably work out of the box” didn’t come across as disdainful. I know there are workarounds for this issue but not every new user might know about these and immediately running into an error with a fresh React Native project can be frustrating. I opened an issue instead of a pull request because I’m not sure about the right solution; it might be relaxing the version constraint or it might be updating the Android guide.

@sonicdoe I totally agree , but on the practical side we need to choose our battles. This is actually the kind of case that we would love to get help from the community.


Cosmetic filters are not supported by bromite

Hi, I just wanted to let you know. That bromite's filter engine doesn't support cosmetic filtering. You can verify by going to some of the cookie websites and notice the pop-ups still show.
Example: huawei.com still shows a cookie banner even when you use the bromite-extended filter which has this list's filter in it:
https://secure.fanboy.co.nz/fanboy-cookiemonster.txt which you use.
It would be better to remove them as they do not server any use

I think you are mostly right about this, but there might still be some benefits. The list for example contains wsj.com###cx-notification and when I open WSJ in Bromite, no cookie banner appears (compared to Chromium without adblock, where it does). However, it could be that this blocking comes from another list, not 100% sure.
When running the tool with only this list, the log is the following:
[0917/075725.252269:ERROR:rule_stream.cc(88)] (error:106) Unknown URL rule option:
bethesda.net#?#visor-alert[name="visor-alert"] > div[class=""] > div > div:last-child:-abp-has( > a[href$="/cookie-policy"])
                                                                                ^

[0917/075725.252891:ERROR:rule_stream.cc(88)] (error:23) Unknown URL rule option:
podleze-piekielko.pl#$#abort-on-property-read cookieman
                      ^

So the ruleset converter tool understands all except for two rules from the list. I'm not 100% sure how bromite applies the rules (e.g. it could be possible that they are added to the ruleset file, but then bromite doesn't understand some rules; however I didn't find the exact matching logic in the AdBlock patch so I can't really check that), but in general it seems like some rules from the list should work (except for cosmetic filters), which is why I would keep it.

BTW I have since created two user scripts that also block these kinds of popups, so I'll close this


Deprecate IPWhiteList middleware in favor of IPAllowList

What does this PR do?
This PR deprecates IPWhiteList middleware in favor of the IPAllowList middleware.
More

[x] Added/updated tests
[x] Added/updated documentation

Additional Notes
Co-authored-by: Kevin Pollet<EMAIL_ADDRESS>

This middleware could also allow setting a redirection URL in case the IP is not on the AllowList instead of 403 forbidden. If that were the case, it would be useful to redirect users to a maintenance page while still letting devops login and test the application.

@peter-englmaier Thanks for the feedback.
This PR only deprecates the old IPWhiteList middleware in favor of the IPAllowList middleware and doesn't add any new behavior/feature.
Could you open a dedicated issue for tracking this enhancement proposal? This way we might be able to gather more feedback from the community to see if there's a need for it and if so how it could be tackled.

Could you open a dedicated issue for tracking this enhancement proposal? This way we might be able to gather more feedback from the community to see if there's a need for it and if so how it could be tackled.

Sure, I can do that. I think it would be useful for many.


License under GPLv3

Having no license can cause issues (although I doubt we'd run into any of them staying unlicensed, might as well..?).
Doesn't necessarily have to be GPL but I thought it was the best default choice.

The reason I don't like MIT is because it requires every distribution of the software to include the same MIT license, so it just gets everywhere

Apparently the Unlicense has some weird legal issues so I will change it to dual MIT/Apache2.0


ivi-id-agent: Revert the weston header link

The WESTON_INCLUDE_DIRS contains a link to ${install_dir}/include/weston. So, header files should not include the weston directory in the path.
Signed-off-by: Tran Ba Khang(MS/EMC31-XC<EMAIL_ADDRESS>

@efriedrich , @HarshaMM. I created this to revert a change in commit: https://github.com/COVESA/wayland-ivi-extension/commit/a5bba8b5c629ecbe786dd21cbe30b7b4e63f0700.

@khangtb1 , @audoan99 please test the commit and replay to this conversation with Tested-by:

Tested-by: Au Doan Ngoc<EMAIL_ADDRESS>


[Impeller] Verify the camera plugin for external texture interop.

Impeller should support external texture interop. This has been verified with reduced test cases. But a manual pass must be done to verify known popular plugins.

I said I'd do this in the weekly sync.

Verified.


Apache11

Review in progress.

@dagiro @mamccrea - The review team will create a PR to pull the commits into the private repo for validation and staging. We'll then ask the author to review and verify before merging. When the changes are merged into the private repo, we'll close this PR. Thanks

@JasonWHowell - Acknowledged. I will update the assignment for these PRs. Note that a similar PR was merged this morning: https://github.com/MicrosoftDocs/azure-docs/pull/19349.


Uncaught TypeError: Cannot read property 'getURI' of undefined

[Enter steps to reproduce below:]

...
...

Atom Version: 1.7.4
System: Unknown Windows Version
Thrown From: sass-autocompile package, v0.12.6
Stack Trace
Uncaught TypeError: Cannot read property 'getURI' of undefined
At /C:/Users/Administrator/.atom/packages/sass-autocompile/lib/sass-autocompile.coffee:374

TypeError: Cannot read property 'getURI' of undefined
    at Object.module.exports.compileToFile (file:///C:/Users/Administrator/.atom/packages/sass-autocompile/lib/sass-autocompile.coffee:361:36)
    at atom-workspace.subscriptions.add.atom.commands.add.sass-autocompile:compile-to-file (file:///C:/Users/Administrator/.atom/packages/sass-autocompile/lib/sass-autocompile.coffee:318:18)
    at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (C:\Users\Administrator\AppData\Local\atom\app-1.7.4\resources\app.asar\src\command-registry.js:260:29)
    at CommandRegistry.handleCommandEvent (C:\Users\Administrator\AppData\Local\atom\app-1.7.4\resources\app.asar\src\command-registry.js:3:61)
    at CommandRegistry.module.exports.CommandRegistry.dispatch (C:\Users\Administrator\AppData\Local\atom\app-1.7.4\resources\app.asar\src\command-registry.js:160:19)
    at AtomEnvironment.module.exports.AtomEnvironment.dispatchApplicationMenuCommand (C:\Users\Administrator\AppData\Local\atom\app-1.7.4\resources\app.asar\src\atom-environment.js:1100:28)
    at EventEmitter.outerCallback (C:\Users\Administrator\AppData\Local\atom\app-1.7.4\resources\app.asar\src\application-delegate.js:314:25)
    at emitTwo (events.js:87:13)
    at EventEmitter.emit (events.js:172:7)

Commands
     -0:01.0 sass-autocompile:compile-to-file (atom-text-editor.editor.mini.is-focused)

Config
{
  "core": {
    "disabledPackages": [
      "atomatigit"
    ],
    "themes": [
      "atom-dark-ui",
      "one-dark-syntax"
    ]
  },
  "sass-autocompile": {}
}

Installed Packages
# User
atom-ternjs, v0.14.1
atomic-chrome, v0.3.0
autoclose-html, v0.23.0
browser-plus, v0.0.60
color-picker, v2.1.1
docblockr, v0.7.3
file-type-icons, v1.3.0
language-diff, v0.4.0
linter, v1.11.4
minimap, v4.24.2
pigments, v0.27.1
sass-autocompile, v0.12.6
sync-settings, v0.7.2

# Dev
No dev packages

Can you test 0.12.7?


error: unknown warning option '-Wshadow-local' when compiling.

Godot version:
Latest master
OS/device including version:
Windows 10 Enterprise, 1909
Issue description:
godot>scons
scons: Reading SConscript files ...
Automatically detected platform: windows
Configuring for Windows: target=debug, bits=default
Using MinGW
YASM is necessary for WebM SIMD optimizations.
WebM SIMD optimizations are disabled. Check if your CPU architecture, CPU bits or platform are supported!
Checking for C header file mntent.h... (cached) no
scons: done reading SConscript files.
scons: Building targets ...
[  1%] Compiling ==> platform\windows\godot_windows.cpp
=====
b"error: unknown warning option '-Wshadow-local' [-Werror,-Wunknown-warning-option]\r\n"
=====
scons: *** [platform\windows\godot_windows.windows.tools.64.o] Error 1
scons: building terminated because of errors

Steps to reproduce:
Run scons in Godot source folder.
Compiler:
LLVM-MinGW 9.0 and 10.0 from https://github.com/mstorsjo/llvm-mingw/releases.

Seems like your compiler is misidentified as GCC by methods.using_gcc(). Could you debug it further there in methods.py to find out why?

I just realised that scons never worked ever with llvm-mingw. scons use_llvm=true works fine like it used to.
Should I close this issue or is it supposed to detect it even without use_llvm=true?

I traced env["CC"] back to Windows's detect.py where it turned out that it differentiates between gcc and llvm by just presence of "use_llvm".
Hence, closing issue.

AFAIK currently, there's no standard and stable LLVM+MinGW toolchain, consistent detection probably won't be easy to do, use_llvm=true option was designed specifically for the https://github.com/mstorsjo/llvm-mingw toolchain, it's probably won't work with any other flavor of clang.


Relax Active Support constraint

The current constraint on ActiveSupport prevents using this gem with patch releases of ActiveSupport / Rails 7, e.g.
Bundler could not find compatible versions for gem "activesupport":
  In Gemfile:
    rails (= <IP_ADDRESS>) was resolved to <IP_ADDRESS>, which depends on
      activesupport (= <IP_ADDRESS>)

    rspec-buildkite-analytics was resolved to 0.6.1, which depends on
      activesupport (>= 5.2, <= 7.0)

This relaxes the constraint to permit them.

@dannyfallon Sorry for the delay, please use v0.8.0 👍🏼 Thank you!


Release 0.5.0

Changelog

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 60.917%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1660

Relevant Lines:
2725

💛  - Coveralls

No longer relying on develop


refactor: scalify more things

chore: migrate widget docs to valid scaladocs
refactor: use camel case in all public classes and members

Tonight arrived fast :) thanks, looks good!
I see no need to nitpick anything for now, if we find something looks off we'll do some followup PR 👍

apologies about the macOS-m1 build, it's only green when my laptop is awake.

Ahhhh I had no idea that's how it worked! Ha, I was wondering why it was stuck at times.

I see no need to nitpick anything for now, if we find something looks off we'll do some followup PR 👍

Works for me!


RunE2ETest function does not return terraform outputs

I have tried adding assertions as show in the readme sample but the output from the terraform_module_test_help.TerraformOutput  is returned empty.
Here is the function call I am trying
func TestExample(t *testing.T) {
	dir := filepath.Join("../", "examples")
	if _, err := os.Stat(dir); os.IsNotExist(err) {
		t.Fatalf("Directory %s does not exist", dir)
	}
	files, err := os.ReadDir(dir)
	if err != nil {

		log.Fatal(err)
	}
	for _, file := range files {
		if file.IsDir() {
			file.Info()
			t.Run(file.Name(), func(t *testing.T) {
				terraform_module_test_helper.RunE2ETest(t, "../", filepath.Join("examples", file.Name()), terraform.Options{},
					func(t *testing.T, output terraform_module_test_helper.TerraformOutput) {
						resourceGroupName, ok := output["name"].(string)
						fmt.Println("Name of the resource Group:" + resourceGroupName)
						fmt.Println(output["name"].(string))
						fmt.Println(output["resource"].(string))
						fmt.Println(output["resource_id"].(string))
						assert.True(t, ok)
						assert.Regexp(t, regexp.MustCompile("/subscriptions/.+/resourceGroups/"), resourceGroupName)
					})
			})
		}
	}
}

Just wanted to confirm if the outputs portion should be working or not.

Hi @kevball2 thanks for reporting this issue to us. This helper callback SHOULD return outputs as you expected, we have an unit test to verify this.
Would you please share your code repository with us so we can try to reproduce this issue? Thanks!

@lonegunmanb,  Here is the repo I have been testing with - https://github.com/kevball2/terraform-azurerm-avm-res-resource-resourcegroup/tree/feat-resourcegroup-add
I created unit test samples to show the issue, TestUnitExampleTest and TestUnitExampleTestFail
I am running the tests with the following commands:
go test -v -timeout=720m -run TestUnitExampleTest
go test -v -timeout=720m -run TestUnitExampleTestFail

The failing test passes a function with assertions but I get no output back from the run (at least when I tried to debug the test).
I see the same issue if I run the RunE2Etest function as well.

@lonegunmanb I sorted my issue, I didn't have the appropriate outputs.tf created for my tests. I did run into another issue (terratest related) trying to get the assertion checks to run against other clouds (AzureUSGovernment) the resources deploy but when I use a built in assertion exists := azure.ResourceGroupExists(t, resourceGroupName, subscriptionID) it fails to find the subscription (guessing I have to set tenantId and or cloud someplace.
There are constants on the Azure Go Package<EMAIL_ADDRESS>I am unsure how to set them though.

Interesting @kevball2, I never realized that terratest do have this azure sub module to query the resource's status. I've checked it's code, I guess we have three different approaches to get this authorizer work for you:

Auth with Azure CLI
Auth with Client Credentials
Auth with a file stored in env AZURE_AUTH_LOCATION which contains credentials like approach 2.

If you want to test with Azure USGovernment cloud, you might need to set env AZURE_ENVIRONMENT to AzureUSGovernmentCloud, see here and here
I would suggest you search or open an issue on TerraTest's repo, please let me know if you have any further question about this library. Thanks.

Thanks for the for all the help @lonegunmanb
I got a good test now to work from

import (
	"log"
	"os"
	"path/filepath"
	"testing"

	terraform_module_test_helper "github.com/Azure/terraform-module-test-helper"
	"github.com/gruntwork-io/terratest/modules/azure"
	"github.com/gruntwork-io/terratest/modules/terraform"
	"github.com/stretchr/testify/assert"
)

func UnitTestResourceGroupExists(t *testing.T) {
	dir := filepath.Join("../", "examples")
	if _, err := os.Stat(dir); os.IsNotExist(err) {
		t.Fatalf("Directory %s does not exist", dir)
	}
	files, err := os.ReadDir(dir)
	if err != nil {

		log.Fatal(err)
	}
	for _, file := range files {
		if file.IsDir() {
			file.Info()
			t.Run(file.Name(), func(t *testing.T) {
				terraform_module_test_helper.RunE2ETest(t, "../", filepath.Join("examples", file.Name()), terraform.Options{},
					func(t *testing.T, output terraform_module_test_helper.TerraformOutput) {
						resourceGroupName, ok := output["name"].(string)
						subscriptionID := os.Getenv("ARM_SUBSCRIPTION_ID")
						assert.True(t, ok)
						exists := azure.ResourceGroupExists(t, resourceGroupName, subscriptionID)
						assert.True(t, exists, "Resource group does not exist")
					})
			})
		}
	}
}

Only concern now is that the azure module uses an expired azure go package (github.com/Azure/go-autorest). The new go sdk doesn't have a direct replacement for some of the functionality they are using so I am little uneasy using the module.  Appreciate all the help getting this working!


Consider force pushing the branch to ensure work ends up at the remote

Hooks could prevent the code from being pushed. In the state of an emergency I'd want my code to be pushed, regardless.

or just disable hooks:
git-push(1):

--[no-]verify
Toggle the pre-push hook (see githooks(5)).
The default is --verify, giving the hook a chance to prevent the push. With --no-verify, the hook is bypassed completely.


feat: add browse functionality and UI enhancements

I'm experimenting a bit with a "Browse" functionality, to see how would it look like or work.
Would be curious in some feedback.

Updated requirements.txt to use feedparser==6.0.11 for Python 3.13
Added /browse route in sw.py for browsing entries
Created browse.html template for the browse page
Added browse navigation to index.html

Can you talk more about motivation for this and what purpose do you think this is accomlishing?

I guess it's more of a personal thing, instead of being withing smallweb concept.
I like reddit/hacker news style discovery of different topics, news and articles. Where I visually scan what is interesting to me and explore only those that catch my attention.
But now I understand more that smallweb is more about slower and more thoughtful approach to consumption, so I think this shouldn't be a part of smallweb 😁


support single point in fitBounds

Currently, there isn't support for a single point to the fitBounds function.
We get an assertion error if we were to do
const width = 800
const height= 800
const bounds = [[-74.0066517, 40.7083267]]
const viewport = new WebMercatorViewport({ width, height }).fitBounds(bounds)

My issue and use case is similar to that of mapbox-gl issue #3307.
Would it be possible to do something where we center around that point if a single point is passed in?

Same here.
Currently I am making a viewport manually, by setting the lat and lng equal to my single point, and height/width/zoom to sensible defaults.
WebMercatorViewport.getMapCenterByLngLatPosition requires a pixel location as well, and so isn't a great substitute.

The issue is caused by these lines:
const scaleX = targetSize[0] / size[0];
const scaleY = targetSize[1] / size[1];

size is [0, 0] for point bounds. Then scaleY / scaleY becomes Infinity and from there it all goes sideways.
A default scale parameter / value would fix this. I would prefer a parameter, since a point can be displayed at any scale, but applications might be different based on your use case.


chore: Migrate repo to an at_mono compatible structure

- What I did
WIP, I've opened this PR for visibility as well as to create a central communication point for this work.
c357f88 - Moved the following packages into the package/ directory:

at_persistence_root_server
at_persistence_spec
at_secondary_server
at_persistence_secondary_server
at_root_server
at_server_spec

Moved the observable secondary documentation to docs/.
Moved cicd* folders, acme_certs.py, add_dependency_overrides.py, and secondary Dockerfiles to tools/.
Typical command format for new dockerfile build techniques (This command assumes you are at the root of the repo):
docker build packages -f tools/build_secondary/<Dockerfile-of-choice>

- How I did it
- How to verify it
- Description for the changelog
chore: Migrate repo to an at_mono compatible structure

The workflows have yet to have the working directory paths updated, hence all the checks failing.

@XavierChanth there are some conflicts that need to be resolved due to yesterday's refresh of the server certs


Fix markdown syntaxes

Use shell script syntax for commands
Use dollar sign for commands

Wonder how those js ones snuck in there. Thanks!

Too fast, thanks! :cat2:


fiex(sql): fixed sql.Scanner/driver.Valuer support in BitBool/shardid.ID

Fixes

fixed sql.Scanner/driver.Valuer support in BitBool/shardid.ID

Codecov Report
Attention: Patch coverage is 86.11111% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 67.85%. Comparing base (e740b30) to head (c7fe31a).

Files
Patch %
Lines

shardid/id.go
76.47%
2 Missing and 2 partials :warning:

bitbool.go
83.33%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
+ Coverage   66.81%   67.85%   +1.03%
==========================================
  Files          29       30       +1
  Lines        1100     1120      +20
==========================================
+ Hits          735      760      +25
+ Misses        284      276       -8
- Partials       81       84       +3

Flag
Coverage Δ

Unit-Tests
67.85% <86.11%> (+1.03%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add chat message to reduce support traffic

Could you add a chat message when the client gets minimized because of your plugin? That reduces support traffic like https://discord.com/channels/301497432909414422/419891709883973642/1282709945984352267
The message should:

Clearly mention that the client was minimized by the click to minimize plugin
Probably have a config option that's enabled by default but can be disabled
Have a cooldown. E.g. you can get the nanoTime when you previously sent the message and compare it to the nanoTime when trying to minimize again. If the difference is > cooldown -> send chat message.
If your plugin also works on the login screen, you'll have to set a flag to send a message in the GameTick event and consume the flag then, but the plugin probs doesn't work on the login screen.

PR created here to address this issue:
https://github.com/runelite/plugin-hub/pull/6573

Thanks! I'll close the issue as a chatmessage has been added, but I've left some tips here https://discord.com/channels/301497432909414422/334801290645209099/1282768078094077995 after I quickly scanned your code


What's can make this production ready ?

Please, Can anyone answer this question??!!!

This project moved over to a new place: https://github.com/thomasdarimont/embedded-spring-boot-keycloak-server


indenting error

If you use the string 'function', it is indented as if you used the keyword function:
For example:
local a = type(x) == 'function' and x or nil
indents one tab after return

Seems like a difficult thing to fix in regex only. (not that I am a regex expert)
Im guessing it would be best if atom had a feature that could recognize strings and then leave indenting out of them.


Graphql endpoint output and API KEY on lambda function not being passed properly

Note: If your issue/bug is regarding the AWS Amplify Console service, please log it in the
Amplify Console GitHub Issue Tracker

Describe the bug
I created a function and gave it permission to the API but when I do console.log(process.env) I'm getting these values which weren't what I was expecting, I was expecting them to hold the actual values such as HTTPS link to graphql endpoint and the actual API Key as indicated here on this tutorial https://docs.amplify.aws/lib/graphqlapi/graphql-from-nodejs/q/platform/js#mutation

I created my function like amplify add function and then said y when asked do you want to access other resources in this function and then I put in API and selected the table/model I want to update in this function (it only needs one table).
I have the following code in a lambda layer being used by that function:
// libs/graphqlClient.js

const { GraphQLClient, gql } = require('graphql-request');

const graphqlClient = new GraphQLClient(
  process.env.API_LEADSMANAGEMENTSYS_GRAPHQLAPIENDPOINTOUTPUT,
  {
    headers: {
      'x-api-key': process.env.API_LEADSMANAGEMENTSYS_GRAPHQLAPIKEYOUTPUT
    }
  }
);

module.exports.graphqlClient = graphqlClient;
module.exports.gql = gql;

but when I try to do
const { graphqlClient, gql } = require('/opt/libs/graphqlClient');

async function handler (event) {
  console.log(JSON.stringify(event, null, 2));

  const query = gql`
    {
      listUsers {
        items {
          id
          firstName
          middleName
          lastName
        }
      }
    }
  `;
}

It will throw an error complaining about the URL because the process.env.API_LEADSMANAGEMENTSYS_GRAPHQLAPIKEYOUTPUT is not a valid URL.
Amplify CLI Version
always "latest" as specified in the CI/CD, my local amplify is 4.27.2
To Reproduce
Just follow what was said above
Expected behavior
process.env.API_LEADSMANAGEMENTSYS_GRAPHQLAPIKEYOUTPUT should contain the actual URL of the graphql endpoint as indicated on the example on the docs.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: N/A
Node Version: N/A

Additional context
N/A

@yuth Why is this pending response and not-reproducible?

I could not reproduce this. I was wondering if you could share the Cloudformation snippet of the lambda function

I actually encountered this while doing my online course with aws-amplify and react-js
https://www.udemy.com/course/build-it-with-me-lead-management-system-web-app

Can confirm, created a function via CLI, when asked if I want to have access to API, I selected yes. The dependsOn block is an empty array. I had created a function few month ago in similar project and it worked The dependsOn block looked like this:
"dependsOn": [
        {
          "category": "api",
          "resourceName": "xxxxxxGraphQlAPI",
          "attributes": [
            "GraphQLAPIIdOutput",
            "GraphQLAPIEndpointOutput"
          ]
        }
      ]

Amplify version is 4.29.2.

I experienced the same. I had to change the default auth on my api to api key. You can still choose to configure Cognito User pools as a second method. Doing this and recreating the function made amplify pass the API key to the process.env object.

On previous versions of amplify, the default doesn't need to be the API KEY though, and I think API KEY should really be secondary method...

I just tried and I can not reproduce the issue with the latest CLI version.
In the amplify function add workflow, I selected to access the api, and all the env variables
are properly set in the Lambda function.
API_GRAPHQLAPIENDPOINTOUTPUT
APIGRAPHQLAPIIDOUTPUT
API_GRAPHQLAPIKEYOUTPUT
By the way, for the Lambda Layer, opt folder is meant to contain static contents, https://docs.amplify.aws/cli/function/layers#add-shared-code--assets

I just ran into this.
Repro - I created a Storage with Lambda Trigger.
I decided I'd add DynamoDB Table.  I ran into similar policy names created.  I manually prefixed them for S3 and DynamoDB so both policies could exist.
I found out editing dynamo doesn't event stream back to the UI, so I pivoted to GraphQL.
I got thru a painful 3 hour tour of getting axios, graphQL querying setup and finally not crashing the Lambda.
And the process.env.API_ASSETAPI_GRAPHQLAPIENDPOINTOUTPUT is defaulted to apiassetAPIGraphQLAPIEndpointOutput.
I don't know where the argument comes from but I know its in the aws-exports.js ok.

I just ran into this.
Repro - I created a Storage with Lambda Trigger.
I decided I'd add DynamoDB Table.  I ran into similar policy names created.  I manually prefixed them for S3 and DynamoDB so both policies could exist.
I found out editing dynamo doesn't event stream back to the UI, so I pivoted to GraphQL.
I got thru a painful 3 hour tour of getting axios, graphQL querying setup and finally not crashing the Lambda.
And the process.env.API_ASSETAPI_GRAPHQLAPIENDPOINTOUTPUT is defaulted to apiassetAPIGraphQLAPIEndpointOutput.
I don't know where the argument comes from but I know its in the aws-exports.js ok.


Duplicate link in backend dev roadmap of JS tutorials of resource 5 and resource 7

name: Bug report
about: Create a report to help us improve.
title: Bug report
labels: bug
assignees: ''

Describe the Bug
Repetation of link to  the same resource , resource 5 and resource 7 of JS tutorials of backend development roadmap points to the same resource

both the resource links to the net ninga nodejs tutorial
Steps to Reproduce
Steps to reproduce the behavior:

Expected Behavior

either the resource 7 must be removed or any other resource link can be attached
Actual Behavior

Screenshots

Additional Details

sorry this issues is already created


WIP: Kind annotations on type definitions

@zardyh Help!

I ended up pushing something like this in the implicit parameters branch - so this PR is stale now. Sorry :/


Felis schema implementation

Exploring how to use felis for documenting and building the database schema; see #85

Note that using felis requires us to use python 3.11 or 3.12

Latest commit fails because there are checks that the database is inserted. This is working within each single function, but somehow is being lost in another test function. My suspicion is something to do with the (automatic) rollbacks when checking constraints is not working properly (it should only rollback the single transaction, not all records, but it could be the session handling that is problematic).

I have many questions about how to use ivoa:ucd.  I added more but got errors and had to remove them.


Fix play kube command

Before, play kube wasn't properly setting the command. Fix this
Also, begin a dedicated test suite for play kube to catch regressions like this in the future
Begins to fix https://github.com/containers/libpod/issues/3286
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1729369
Signed-off-by: Peter Hunt<EMAIL_ADDRESS>

/approve

happy green tests @rhatdan @vrothberg @TomSweeneyRedHat @QiWang19 @mheon PTAL

LGTM on my side. Like seeing integration tests.

/lgtm

@haircommander This fix was broken again in Podman v1.5.0.

How so? Can you file an issue?
On Wed, Aug 14, 2019, 02:02 Chen Zhiwei<EMAIL_ADDRESS>wrote:

@haircommander https://github.com/haircommander This fix was broken
again in Podman v1.5.0.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/containers/libpod/pull/3588?email_source=notifications&email_token=AB3AOCDBI2VSHQUAN5TIIF3QEONXRA5CNFSM4IESQBOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4HY4YY#issuecomment-521113187,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB3AOCECK7S3ZYCJG7RWVGTQEONXRANCNFSM4IESQBOA
.


Regression on electron

Description of the Issue and Steps to Reproduce:
Version 2.17.1 works fine in Electron, but version 2.18.0 shows error:
Uncaught SyntaxError: Unexpected token this at moment.js:361

After downgrade moment.js to 2.17.1, the error disappeared.
Environment:
Electron 1.6.2

See https://github.com/moment/moment/pull/3853. We released 2.18.1 that fixes this.


Create a social media post for the website launch Nov 1

the plan:

use loom.com to record a demo of the website
use the recording to create a reel/video post using canva
prepare a script for the person recording the demo

do the same for votte


Node/Topic specific authentication

An authentication with username and password with rights to specific nodes/ topic patterns. A configuration would look like this (copied and edited from readme.md):
`{
// Either specify the users 'inline' as such:
"users": {
"martin": "somePassword"
},
// Or, put that object in a file, and reference it like:
// "users": "users.json",

"rights": {
    "": { // Anonymous/guest
        "subscribe": {
              "node1": true, // allow this operation (in this case subscribe) to the entire node
              "node2": "topPattern" // allow this operation to topics matching the pattern
         },
        "publish": {
             "node1": "topicPattern", //using a topic pattern as a filter
             "node2" false
        }
    },
    "martin": {
        "subscribe": true, //still supports the current true/false values for all nodes
        "publish": {
        }
    }
}

}`
How it would look, for example, in the FLL tools use case:
{     // Either specify the users 'inline' as such:     "users": {         "admin": "adminPassword",         "referee": "refereePassword",         "scoreKeeper": "skPassword"     },     "rights": {         "": false,         "admin": true,         "referee": {                 "subscribe": {                         "score": true,                         "clock": false,                         "schedule": true                 },                 "publish": {                         "score": "score:enter",                         "clock": false,                         "schedule": false                 }         },         "scoreKeeper": {                 "subscribe": {                         "score": true,                         "clock": true,                         "schedule": true                 },                 "publish": {                         "score": "score:[update|publish]",                         "clock": true,                         "schedule": true                 }         }     } }

Thanks, @idanstark42! As discussed, will look at it when I return from holiday.
idanstark42<EMAIL_ADDRESS>schreef op 20 juni 2017 22:39:56 CEST:

An authentication with username and password with rights to specific
nodes/ topic patterns. A configuration would look like this (copied and
edited from readme.md):
`{
// Either specify the users 'inline' as such:
"users": {
"martin": "somePassword"
},
// Or, put that object in a file, and reference it like:
// "users": "users.json",
"rights": {
"": { // Anonymous/guest
"subscribe": {
"node1": true, // allow this operation (in this case subscribe) to the
entire node
"node2": "topPattern" // allow this operation to topics matching the
pattern
},
"publish": {
"node1": "topicPattern", //using a topic pattern as a filter
"node2" false
}
},
"martin": {
"subscribe": true, //still supports the current true/false values for
all nodes
"publish": {
}
}
}
}`
How it would look, for example, in the FLL tools use case:
{    // Either specify the users 'inline' as such:    "users": {        "admin": "adminPassword",        "referee": "refereePassword",        "scoreKeeper": "skPassword"    },    "rights": {        "": false,        "admin": true,        "referee": {                "subscribe": {                        "score": true,                        "clock": false,                        "schedule": true                },                "publish": {                        "score": "score:enter",                        "clock": false,                        "schedule": false                }        },        "scoreKeeper": {                "subscribe": {                        "score": true,                        "clock": true,                        "schedule": true                },                "publish": {                        "score": "score:[update|publish]",                        "clock": true,                        "schedule": true                }        }    } }
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/poelstra/mhub/issues/12

This has been implemented in 0.9.0. See https://github.com/poelstra/mhub#access-control for more information.


removed redundant assignments and improved formatting

There was an unnecessary assignment statements in TranslatorProcessor.cs. I've also moved moved some else blocks to begin on a separate line in order to keep the formatting consistent with the rest of the code.

Hi @deniskyashif  : Thanks for the pull request.
Before accepting your pull request, we would need the CLA form accepted. You can find more information in CONTRIBUTING.md.
The full CLA is available here.
When you get a chance, please review the CLA and complete the CLA Acceptance Form. If you have any questions, please just let me know.

Sure, I've just submitted the acceptance form.

Thanks @deniskyashif, nice formatting changes, merged.


NTR psilocybin biosynthetic process and associated reactions

Hello,
To annotate fungal secondary metabolites biosynthesis pathways, @marcfeuermann requested the following terms:
+[Term]
+id: GO:0140380
+name: psilocybin biosynthetic process
+namespace: biological_process
+def: "The chemical reactions and pathways resulting in the formation of psilocybin, a psychotropic tryptamine-derived natural product."  L-tryptophan
+intersection_of: has_primary_output CHEBI:8614 ! psilocybin
+intersection_of: starts_with GO:0036469 ! L-tryptophan decarboxylase activity
+created_by: pg
+creation_date: 2019-11-20T10:03:05Z
+
+[Term]
+id: GO:0140381
+name: 4-hydroxytryptamine 4-phosphate methyltransferase activity
+namespace: molecular_function
+def: "Catalysis of the reaction: 2 S-adenosyl-L-methionine (SAM) + 4-hydroxytryptamine 4-phosphate (norbaeocystin) <=> 2 S-adenosyl-L-homocysteine + psilocybin." [PMID:28763571]
+synonym: "norbaeocystin methyltransferase" EXACT []
+synonym: "psilocybin synthase" EXACT []
+xref: EC <IP_ADDRESS>5
+xref: RHEA:55568
+is_a: GO:0008168 ! methyltransferase activity
+created_by: pg
+creation_date: 2019-11-20T10:16:28Z
+
+[Term]
+id: GO:0140382
+name: tryptamine 4-monooxygenase activity
+namespace: molecular_function
+def: "Catalysis of the reaction: tryptamine + reduced acceptor + O(2) <=> 4-hydroxytryptamine + acceptor + H(2)O." [PMID:28763571]
+xref: EC <IP_ADDRESS>
+xref: RHEA:15865
+is_a: GO:0004497 ! monooxygenase activity
+created_by: pg
+creation_date: 2019-11-20T10:26:21Z
+
+[Term]
+id: GO:0140383
+name: 4-hydroxytryptamine kinase activity
+namespace: molecular_function
+def: "Catalysis of the reaction: 4-hydroxytryptamine + ATP = 4-hydoxytryptamine 4-phosphate + ADP + H(+)." [PMID:28763571]
+xref: EC:<IP_ADDRESS>
+xref: RHEA:55564
+is_a: GO:0016301 ! kinase activity
+created_by: pg
+creation_date: 2019-11-20T10:30:05Z
Also :

changed EC:<IP_ADDRESS> -> EC:<IP_ADDRESS>

@ukemi @deustp01 Can you please check the logical definition ? We added all reactions and intermediates. Let me know if this is how to do it.
Thanks, Pascale

I don't know the pathway that well, but this looks ok to me. It is often not necessary to specify the intermediates unless they are required for further classification.

Should I add primary input and primary output for the MF ?
Thanks, Pascale

NO. Those are restircted to metabolism terms. No need to put any participants for MFs, those will all be populated with ChEBI identifiers from Rhea at some point in time.

Nothing from here, because I don't know anything about this biochemistry.

OK thanks !


Libs/Core/ctkWorkflow.cpp: 2 * bad assert ?

Libs/Core/ctkWorkflow.cpp:132:67: warning: enum constant in boolean context [-Wint-in-bool-context]
Source code is
Q_ASSERT(directionality == ctkWorkflow::Forward || ctkWorkflow::Backward);
Suggest new code
Q_ASSERT(directionality == ctkWorkflow::Forward || directionality == ctkWorkflow::Backward);

Libs/Core/ctkWorkflow.cpp:164:67: warning: enum constant in boolean context [-Wint-in-bool-context]
Duplicate.

Thanks for the report :+1:
Would it be possible  to submit a Pull Request ?

Doubtful. I just find the bugs, I don't fix them.
If you want to fix it, go ahead.


fix(#2071): use testid property in react components

This PR makes the following changes:

Adds testid property to the below web components:

app-header-menu
block
calendar
circular-progress
date-picker
details
file-upload-card
file-upload-input
footer-meta-section
footer-nav-section
footer
grid
hero-banner
microsite-header
modal
notification
page-block
pagination
side-menu-group
side-menu-heading
side-menu
spacer
table
tabs

Updates all React components to use the testid web component property instead of data-testid.

Outstanding questions

I've added a testid property to the web components that are missing one. Is this the best approach? Or should I just keep the data-testid on the react components for these ones?
This PR touches a ton of files. 😬 Should I move the web component changes into a separate PR?

Checklist

[x] I have updated the relevant unit tests
[x] My local unit tests pass
[x] I've manually tested all components

Manual testing
When I render a react accordion...

[x] I see a testid property on the web component
[x] I see data-testid in the shadow dom

Okay! I've reverted my changes on radio.tsx and dropdown-item.tsx. Then I resolved the merge conflicts on my branch. Anything else?

@vanessatran-ddi I've removed the two imports and ran my local unit tests.

Anything else?

I've resolved the latest merge conflicts. My local tests pass.

:tada: This PR is included in version 1.17.0-alpha.108 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 5.0.0-alpha.7 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 3.0.0-alpha.6 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[Feature] config-data.yaml uses different formats for cluster names

Feature description
connectedhome/src/app/common/templates/config-data.yaml has a few top-level tags.
The format of cluster names used by CommandHandlerInterfaceOnlyClusters, DefineBitmaps, WeakEnums seems to be the cluster name with no spaces, converted to CamelCase.
The format used by ClustersWithInitFunctions, ClustersWithAttributeChangedFunctions, ClustersWithShutdownFunctions, and ClustersWithPreAttributeChangeFunctions is the cluster name with spaces and no case conversion: as defined in the cluster XML file.
Current status is quite confusing, and formats should converge
Originally filed as https://github.com/project-chip/zap/issues/1134 @bzbarsky-apple
Platform
all
Platform Version(s)
No response
Anything else?
No response

DefineBitmaps and WeakEnums are not cluster names.
Looks like I was somewhat wrong in the ZAP issue; ClustersWith*Functions is handled on the ZAP side.  But ClustersWithAttributeChangedFunctions is handled on the Matter side, and we can easily change it to match the others.


Added contribution-friendly readme and */= in proc... highlighting

I would like to help out with the syntax highlighting since I did some for myself (Nimrod-Sublime-Syntax
). If this is ok I will port other changes.
Here I simply made the '*' recognized as a keyword when used in procs, templates,,, I also made the '=' recognized. This is to be consistent with their appearance in other scopes. I also added some details to the README because I had to figure those things out for myself.

Hi, please make sure you compile the YAML and update the tmLanguage file before submitting a PR, thanks :+1:

Thanks for noticing that. The pull request has been updated.


Allow Jest to preprocess non-root node_modules

Update: @modernserf is working on a PR to this issue. Please don't submit other PRs.
Currently, create-react-app allows you to structure your app like this:
node_modules/
└─ react/
src/
├─ __tests__/
├─ index.js
└─ node_modules/
   └─ @myapp/
      ├─ foo/
      └─ bar/

So you can import 3rd party modules with import "react" or local modules with import "@myapp/foo". Webpack will preprocess the files in src/node_modules, es6 features (including imports) are converted with babel. I imagine this behavior is intentional, because typical babel-loader configurations ignore all node_modules directories.
However, although Webpack will preprocess these files through Babel, Jest will not; if your tests imports one of these local modules, Jest will choke on the un-transpiled import statements.
I think all one needs to do to enable this is add preprocessorIgnorePatterns: ["<rootDir>/node_modules"] to the Jest config -- this will continue to not preprocess regular node_modules, but will preprocess internal node_modules, so it should have no impact on existing apps.
Update: @modernserf is working on a PR to this issue. Please don't submit other PRs.

Webpack will preprocess the files in src/node_modules, es6 features (including imports) are converted with babel. I imagine this behavior is intentional, because typical babel-loader configurations ignore all node_modules directories.

This is not intentional, no. We include instead of excluding so that npm link still works. I didn’t however realize somebody would create another node_modules inside src.
Can you please explain your reasoning for doing it like this? Are you trying to avoid relative paths by doing so?

Avoiding relative paths is the immediate goal; the long-term goal is to allow apps to be structured more like monorepos.

This is interesting. I’m not sure this is the approach we would take but we need to provide support for something like this.

This will be a part of #741.

It still would be good if Jest had the option to not ignore non-root node_modules instead of having to use a workaround.

Oh, to clarify, I’m happy to review a PR that adds preprocessorIgnorePatterns: ["<rootDir>/node_modules"] to our Jest configuration.

The trouble is, testPathIgnorePatterns seems to add to the defaults list instead of replacing the value?
For example, even with the following config, tests insides /src/node_modules aren't called:
"jest": {
	"testPathDirs": ["<rootDir>/src"],
	"testPathIgnorePatterns": ["<rootDir>/node_modules"]
}

But that's an issue with Jest itself, not CRA.

Please file it in Jest repo, and we'll discuss it there.

I've changed my mind. Let's just make src/node_modules work well and document it. People can always use symlinks to make it prettier.

Update: @modernserf is working on a PR to this issue. Please don't submit other PRs.
...
@modernserf commented on Nov 21, 2016

Is this being solved in Jest or CRA?

I think these are loose threads here:
https://github.com/facebookincubator/create-react-app/pull/1081#issuecomment-264351297
https://github.com/facebookincubator/create-react-app/pull/1081#issuecomment-277133762
https://github.com/facebook/jest/pull/2318#issuecomment-272087686
https://github.com/facebook/jest/pull/2796

To be perfectly clear: I do not know how to make this work without breaking Facebook's specific use cases. Even getting Jest to work as it is currently documented -- that is, with testPathIgnorePatterns not automatically including node_modules -- appears to break something in haste.

@modernserf It really comes down to the general concept of Jest wanting to "just work" by default. The default behavior is going to be to ignore node_modules/ folders.
I could submit a PR to Jest to completely change that assumption and get testPathIgnorePatterns to work out of the box as expected but that changes the responsibility of the developer using Jest to having to specify node_modules/ in every project they create to keep it fast.
If we built another system on top of it, like say a whitelist configuration then what we have is a double negative, "ignore this ignore" so to speak, and it becomes complicated. That's why in my facebook/jest#2796 PR I made the case that having the developer make the conscious decision to abandon the default jest behavior and then rely on their own ignore list was probably better.
If the testPathIgnorePatterns is configured correctly then the performance of haste/jest will still be optimal because the _ignore predicate for the haste map will not look at / process anything from the root node modules and jest will still be fast.
Currently jest does support something we can use for create-react-app:
{
  "jest": {
    "haste": {
      "providesModuleNodeModules": [
        "@my-module",
        "@my-utils"
      ]
    }
  }
}

This works by setting up a whitelist for node_modules/(@my-module|@my-utils) that allows slices of node_modules/ to be ignored but this won't work in CRA because we need the pre-processing to run on the modules when running jest, simply allowing tests in these folders to run won't work.
I think the underlying problem is that Jest's project-level assumptions are kicking this whole concept in the teeth, and because that assumption & jest's mantra are so well entrenched I don't see this changing any time soon.
I imagine @cpojer will have issues with any PR that changes big assumptions about how jest views your project without large discussions and maybe even a major version bump.
@gaearon CRA is has some pre-processing set up when running jest I think to allow jest to test ES6 import/export files. What are our limitations in the react-scripts side for having that process based on jest configuration?

Do I understand correctly that facebook/jest#2796 is where we’re stuck right now, and we need to get feedback on it?

@gaearon
Basically the way I understand Jest is that they aim for safe defaults that should work mostly out of the box. Jest seems to assume that all node_modules/ are delivered dependencies and blacklists them by default.
To get testPathIgnorePatterns to work as documented out of the box we have 2 approaches:

Abandon the assumption that node_modules/ is automatically bad entirely so the testPathIgnorePatterns is working like a blacklist model
Add the inverse of the testPathIgnorePatterns to the whitelist that lets certain groups through the block.

I didn't feel comfortable doing Option 1 because that is a huge breaking change that Jest authors would probably throw out in a heartbeat.
This is why I opted for the retainAllFiles option to let the user (or react-scripts) decide to turn off the safe defaults because it was going to set up custom defaults with testPathIgnorePatterns.
It feels dirty and I haven't gotten any feedback from the jest team on that PR. (It's also out of date, i need to rebase it on the new master) but without architectural decisions from the Jest team I think we're stuck.

Well @gaearon we're back to square one on this one, understandably the jest team wasn't comfortable making the neccesary large changes to support this, additionally it seems they're not comfortable exposing jest-haste-map configuration to the package.json configuration to allow the user to configure the behavior of jest's processing surface.
This kind of puts a decent sized snag in local node_modules packages and probably means #1065 is dead in the water.

From my understanding Jest 19+ fixed this with testMatch.

@Timer are you referring to https://github.com/facebook/jest/pull/3538 ? I'd have to test but in my initial investigations into this it was a matter of how jest's haste map builds up the list of test file candidates by actively ignoring node_modules folders referenced here: https://github.com/facebook/jest/blob/master/packages/jest-haste-map/src/index.js#L701-L711
It basically would match the file, then actively ignore it because it resides inside a node_modules folder. Haste Map has the ability to disable this, but that configuration isn't exposed by jest itself (not passed from jest -> jest haste map).
The testMatch cannot ever match these tests because the virtual file system built with jest-haste-map will have excluded it before that check is made.

Not completely opposed to it, we can make it work, but all the PRs were outdated and didn't do all the things that were necessary. We are a bit resource constrained with Jest atm but it should be possible to make this change properly, if somebody is thorough enough.

@cpojer I think what's not clear is the direction the Jest team would like to take on this. As I outlined in my PR, it has to do with changing assumptions of the jest-haste-map or exposing existing functionality to the jest user so they can configure the behavior as they need.

it should be possible to make this change properly

That's incredibly ambiguous, what is "proper" in the Jest team's eyes? Obviously a less hacky solution that passing retailAllFiles is ideal, but as I noted in my PR (which was outdated? I updated it less than a month ago and it sat with no comments since its inception) without changing assumptions or the configuration / process by-which jest-haste-map operates it cannot move forward.
I recall another PR on this issue that did something similar to that, but was rejected because the changes broke internal Facebook dependencies that the author had no way of taking into account.
I'm not saying that the retainAllFiles solution is the way I'd like to solve this, but it's the only way I can see of solving this without the Jest Team acknowledging the assumption and communicating what's open to change and what's not, how can a contributor go about designing a solution.
You say you're resource constrained, we get that. That's why we're here, willing to submit PRs (I've counted at least 3 so far) and help move this forward. Hell I've already moved on in my own project and accepted that this probably wont see the light of day, at least not for a LOOOOONG time (it's already gone through 3-4 major jest versions and a couple CRA versions without any traction or discussion being completely ignored).
But tell me this, why would we spend hours of time coming up with a solution, when there's a decent chance it's just going to be shot down, with no discussion, over changes to the project that aren't compatible to your unspoken goals, or your undisclosed dependencies.
This is why I proposed the retainAllFiles solution, it's there already, its unobtrusive, all the defaults stay the same as they always were, the changes wont break internal Facebook dependencies, and it would allow the already heavily discussed solution to the local-modules problem in CRA to be addressed and properly documented until the time that the Jest team has time to weigh in.
Is it the best? No
Is it prone to performance problems if not applied correctly? Possibly
You say you're open to making this change if someone is thorough enough, in what regards? In magically navigating all the unspoken issues the Jest team will have with changing the jest-haste-map's behavior regarding node_modules they're not willing / don't have time to have a discussion on? Or was this an issue of not having a "Complete" enough PR?

@Reanmachine hey! That's a bit strong. Please keep in mind that right at this moment, there is no official Jest team at Facebook (this is changing currently, yay!). It's just me spending all my free time coding and being burned out on it, a bit. Because I rewrote large parts of Jest recently, I went through the PR list to close older pull requests that haven't had activity in a while and had merge conflicts.
The problem with retainAllFiles is that it actually means that Jest will go and read and parse every single JS file in node_modules as well as retaining metadata about them. For project with large dependency trees like CRA, this might add seconds to the startup time.
For most people, this kind of slowdown is probably not acceptable and will make people want to not use Jest. This issue has also not moved much in the last three months, telling me that it doesn't seem like something that many people are running into.
To sum up the current state: the solution with retainAllFiles that we came up with clearly falls short as it makes Jest do much more work than necessary for all projects. If we'd like to seriously fix this, the solution probably has to go quite a bit deeper. Since I'm not really able to spend any time on this, the ideal solution would come from an open source contribution and it would not alter the performance characteristics of jest-haste-map significantly.
I'm wondering if the solution could be to use module directories and a separate folder name that clearly make a distinction between first-party and third-party code. Most tools (webpack, Jest) support a configuration for that.

@cpojer Sorry if I came off strong, it's just really frustrating to try and help when the other end is often-times a black box. It's good to hear jest is getting a more serious commitment from FB in the future.
I suppose where the big disconnect lies is between the testing layer & the indexing layer. Correct me if I'm wrong but the purpose of the jest-haste-map is to represent the file system that jest works inside in a performant way. The disconnect in the configuration (and documentation) is that there's a lot of 1st-class configuration options around determining what things to use/ignore/etc. (Eg. testPathIgnorePatterns is set up to default to ["node_modules"]).
The problem is that the assumptions that jest-haste-map makes when it scans the filesystem is that node modules folders are never included in the first place, so that ignore pattern is mostly un-used because there'll never be a test in the virtual file system inside that folder to begin with.
All of the config options in jest seem to be centered around safe/smart defaults. You look at coveragePathIgnorePatterns, testPathIgnorePatterns, transformIgnorePatterns they all default to /node_modules/ and can be combined with <rootDir> in the configuration system for some explicit behavior.
I think the ideal way for the user would be that if testPathIgnorePatterns behaved as documented, but right now the assumption that jest-haste-map makes about ALL node_modules paths is what runs counter to this.
Right now we can configure the whitelist that overrides this behavior with jest.haste.providesModuleNodeModules but this is done on a module-by-module basis, and it's about configuring jest-haste-map not jest. This isn't very discoverable for the user, and isn't going to be realistic/performant for jest to scan & load module names that don't match it's blacklists into this whitelist.
I think that the goal would be to allow a jest user to go "hey, I only have external modules in frontend/node_modules and backend/node_modules so I'd like jest to treat only these folders as dangerous. (Without having to understand jest-haste-map's virtual filesystem and the difference between it and their testPathIgnorePatterns
We could accomplish this by using something similar to moduleDirectories, the problem with moduleDirectories itself is that it doesn't follow the conventions other configuration does, and wouldn't allow us to say ["<rootDir>/frontend/node_modules", "<rootDir>/backend/node_modules"] (etc...) to allow /frontend/**src**/node_modules to be treated like what it is --- a module folder for node, but not managed by npm necessarily.
What lies after this is making sure that jest can configure jest-haste-map's _ignore() method sufficiently to allow it to index the correct folders. This is where my frustration comes (and the strong nature of my last post).
This is all stuff I'm willing to tackle but I'm left with a dillema:
How do I go about modifying jest-haste-map to support that behavior without breaking the internal Facebook things that rely on jest-haste-map that I've seen other PRs closed over. Since they're not OSS projects I cannot make patches to them or test that the changes made do not impact them.
I'd like to hear your comments on all of the @cpojer, I'm willing to make the OSS contribution but I'd rather not waste the time if undisclosed non-oss projects on FB will kibosh any attempt to improve this situation.

If you'd like to change jest-haste-map to be extended this way and the default will not generate larger amounts of unnecessary files to be kept track of by Jest, I think we can make this work. I dislike exposing new configuration options for something like this but if that's the only way to go and there are many people that would benefit from this, I'm not opposed to shipping it.
This isn't so much an FB concern as it is a concern with the memory usage (and disk cache) as well as performance of jest-haste-map. It's a critical piece of infra for Jest and react-native-packager, so altering its performance characteristics by default isn't good.

I’m pushing this back to 0.11 as we’re cutting 0.10 very soon, and there’s no solution yet.

This is not going to be resolved soon, I guess.
Is there any workaround available?

Ah.. never mind, I found an acceptable workaround: Add NODE_PATH=src/alias and then create alias directory with bunch of symlinks in it.

@trungdq88 the easiest workaround is to make this folder structure:

src/modules
src/modules/my-module-1
src/modules/my-module-2
src/node_modules -> ../modules (symlink)

By leveraging the node_modules directory, all tooling is compatible.

Given the desire is to continue to ignore node_modules unless it is a node_modules folder contained directly beneath src, I have gotten this to work by modifying createJestConfig.js in react-scripts-js by adding these patterns:
testPathIgnorePatterns: [
      '^(?!.*([/\\\\]src[/\\\\]node_modules[/\\\\])).*([/\\\\]node_modules[/\\\\])'
],
transformIgnorePatterns: [
      '^(?!.*([/\\\\]src[/\\\\]node_modules[/\\\\])).*([/\\\\]node_modules[/\\\\])'
],

The goal is to continue to filter out /node_modules/ unless it is contained within a part of the path that exactly matches /src/node_modules/ or \src\node_modules\
Now I am able to maintain absolute referenceable imports that are directly contained within the src/node_modules folder or are simply symlinked into the src/node_modules folder.
Regex patterns use negative lookahead rather than negative lookback ((?<!([/\\]src))[/\\]node_modules[/\\]) because javascript does not support negative lookback.
This seems like a straightforward solution that works for this specific project structure without requiring any changes to Jest or the need to expose any further configuration within CRA. Is there a particular scenario in which this approach will break. From my usage so far it appears to work well with CRA and with VSCode.

@mlesk did you verify that this works? When I was working on this, it didn't matter what you put in testPathIgnorePatterns; jest always ignored node_modules.

Ok, jumped the gun a bit after coming back to this a few times I got excited when it finally worked,
There are two scenarios:

Symlink addressable folders into the /src/node_modules/ directory. With this approach the suggested changes work since in that case Jest does not need to actually find them in the src/node_modules directory.

Placing addressable folder directly into src/node_modules directory. With this approach the suggested changes do not work unless you also add this to the jest config:

"haste": {
      "providesModuleNodeModules": [
        ".*"
      ]
    },

With the hast configuration jest picks up the files in src/node_modules. However, I suspect this is may not be an acceptable general solution since it causes Haste to spit out some duplicate file name warnings before the tests run. Once the warnings fly by the tests do all run.


DNS setup error

When running sudo node start.js under Ubuntu, after installing everything, I get an error: There was an issue setting up DNS: bind EADDRINUSE <IP_ADDRESS>:53
How would I fix this? I'm not exactly a linux noob but I'm not sure how to fix this myself.

netstat -anp | grep ":53"

That doesn't really help. I've already tried that, and whenever I try and kill dnsmasq it starts itself up again.

Same error for me. :(

I fix using --host argument with my ip

https://askubuntu.com/a/233223a
Try this?

Try using sudo node start.js --disable-curses --logfile debux.txt --host <IP_ADDRESS>  and then, set on internet connection the internal IP of your PC. This worked for me!

@P4ndaJ is right. --host option will change listening ip. #24

Hmm. The Switch won't let me use <IP_ADDRESS> as the DNS... Halp mii

First thing: address is <IP_ADDRESS> .
Second thing, you must add the internal IP of your PC, for example: 192.168.1.x

Nope. After putting "<IP_ADDRESS>" (or .0) into the primary DNS, the Switch says "The information you entered is incorrect."

On the switch, <IP_ADDRESS> is going to resolve to itself which does not work. The switch needs to point to the DNS server that pegaswitch starts.
<IP_ADDRESS> is usually the most common IP for resolving localhost, but the rest of <IP_ADDRESS>/8 is not really used by default in my experience (it's defined as a loopback address range)
--host in PegaSwitch will change what IP address the DNS server listens on. You will most likely want to use <IP_ADDRESS> if you're unsure of networking (this address will listen to all traffic coming in). From there, you want your switch to point to the IP address of the machine running PegaSwitch.

That doesn't help.
My current situation is:
Running start.js with no additionall settings gives me an error saying <IP_ADDRESS>:53 is in use.
Running it with --host <IP_ADDRESS> allows me to access the pegaswitch program, but I can't get my Switch to connect no matter what.
I'm on firmware 3.0.0 on my Switch, running Ubuntu 16.04 on the computer. Same WiFi network, no idea why it isn't working.

Can you post a screenshot of your switch internet settings please?

Not really.
IP Address Settings: Automatic DNS Settings: Manual         Primary DNS: <IP_ADDRESS>         Secondary DNS: <IP_ADDRESS> Proxy Settings: Off
Anything else you need?

just use your device ip. (do not use localhost)
if you use the internal network, ip should be 10.x.x.x,172.x.x.x or 192.x.x.x
if you want to access outside of the internal network, you should port forward in the router configuration.

I tried my IP from whatismyip.com and my IP from ifconfig, and various IPs in the pegaswitch launch command, but I still can't get it to work.

use result of ifconfig, not external ip.

Doesn't work. On Ubuntu, what could be stopping pegaswitch from listening on <IP_ADDRESS>:53? If I could find out everything would probably work fine.

I did not understand it! To change from <IP_ADDRESS>:53 to <IP_ADDRESS>
for example, just use the command --host!

You don't want to change your bind address (what --host changes) to <IP_ADDRESS>. That will make the Switch unable to connect to the PegaSwitch DNS server. Unless your network configuration is especially strange and you know what you're doing, you probably don't need to touch --host.
You need to stop whatever has already bound port 53 on <IP_ADDRESS>. For some reason, a lot of people on Ubuntu seem to be running dnsmasq, which binds port 53. Here's a stack exchange thread on how to disable it: https://askubuntu.com/questions/233222/how-can-i-disable-the-dns-that-network-manager-uses

@Jhynjhiru first you need find your ip address. like ifconfig $(ip route| grep default | awk '{print $5}') | grep inet | head -n 1 | awk '{print $2}'
then use node server.js --host {ip addr}
do not add <IP_ADDRESS>:53, do not use <IP_ADDRESS>. just use your computer ip address.
web service like whereismyip just return your external ip, and probably cannot help you.

Hm. Everything works fine now, and I didn't change anything, except restarting... Thanks for the help guys
.

I have problems showing the ip-dns that I should put on the switch. When I launch pegaswitch with sudo node start.js on the screen only frames but no information comes out. What is happening? any ideas? I followed all the steps and I have pegaswitch and libtransistor. use bash in windows 10


loadDefinedPath tests in all formats, including errors

Right now there is just a single prototype test.

Done in 2add835


The "updated on" does not change when a new run has been created for a Test

Describe the bug
Run the test over mutiple cycles on different dates and the test "Update On" field shows the date of when the test was first created.
Expected behavior
The field shoud be updated to reflect the latest run for a test?
Screenshots

Desktop (please complete the following information):

OS: [Windows 10]
Browser [chrome]

AB#1692617

@johnAgilisys The 'Updated on' field indicates the date on which any changes to the test configuration have been made. If the same test set up was run multiple times, it is not being considered as an update to the test configuration.
For example, if you have added a pass/fail criterion, increased the number of test engines in an existing test, such changes are considered as updates to the test.
If you are interested in knowing when the latest test run happened, you can look at the test run name, which includes the timestamp of the test run.

@Nagarjuna-Vipparthi  Thanks for the respone. Agree I am able to find the latest run from the name but that would mean drilling into each test to see the last run date and status. would have been useful to have that on the summary page of the tests

@johnAgilisys thank you for the suggestion. We will add it to our backlog and explore ways of improving the interface for listing the test details.

thats great.. thanks.

@johnAgilisys This enhancement has been added. Closing this issue for now. Please reopen if you have any issue.


fix(css): css emit condition

Description
fix the error css emit condition 🙈

Additional context

What is the purpose of this pull request?

[x] Bug fix
[ ] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[ ] Read the Contributing Guidelines.
[ ] Read the Pull Request Guidelines and follow the Commit Convention.
[ ] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[ ] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[ ] Ideally, include relevant tests that fail without this PR but pass with it.

@poyoho would you add a test for this fix?


Add MCXN947 sai module support

Add sai instances on MCXN947.
Update sai driver.
Port i2s_speed case on FRDM-mCXN947 and test passed locally.
support sai clock for syscon.

Thanks to @hakehuang for helping debug i2s_speed to find the i2s driver problem and fix it.

need add i2s in boards/nxp/frdm_mcxn947_mcxn947_cpu0.yaml, supports list

There are some changes to the I2S driver that are beyond the clocking updates needed. Can these be split into a separate commit describing what they are needed for?

Hi @mcuxted ,
With your latest update, the i2s_speed test no longer builds for this board.  Can you please address the build issues?

Hi @mcuxted , With your latest update, the i2s_speed test no longer builds for this board. Can you please address the build issues?

Hi @DerekSnell , I have tested it locally and found that it should be unrelated to this patch. It can be reproduced when testing other cases in the main branch.
This is my test command with other case
west build -p -b frdm_mcxn947/mcxn947/cpu0 tests/drivers/can/timing

board testing pass.
2024-11-08 00:18:01,219 - twister - DEBUG - DEVICE: *** Booting Zephyr OS build v4.0.0-rc2-117-g9028dccb375c ***
2024-11-08 00:18:01,223 - twister - DEBUG - DEVICE: Running TESTSUITE drivers_i2s_speed
2024-11-08 00:18:01,228 - twister - DEBUG - DEVICE: ===================================================================
2024-11-08 00:18:01,231 - twister - DEBUG - DEVICE: START - test_i2s_transfer_long
2024-11-08 00:18:01,263 - twister - DEBUG - DEVICE: 20 TX blocks sent
2024-11-08 00:18:01,265 - twister - DEBUG - DEVICE: 20 RX blocks received
2024-11-08 00:18:01,269 - twister - DEBUG - DEVICE: PASS - test_i2s_transfer_long in 0.034 seconds
2024-11-08 00:18:01,274 - twister - DEBUG - DEVICE: ===================================================================
2024-11-08 00:18:01,277 - twister - DEBUG - DEVICE: START - test_i2s_transfer_short
2024-11-08 00:18:01,278 - twister - DEBUG - DEVICE: 0->OK
2024-11-08 00:18:01,278 - twister - DEBUG - DEVICE: 1->OK
2024-11-08 00:18:01,279 - twister - DEBUG - DEVICE: 2->OK
2024-11-08 00:18:01,284 - twister - DEBUG - DEVICE: 1<-OK
2024-11-08 00:18:01,285 - twister - DEBUG - DEVICE: 2<-OK
2024-11-08 00:18:01,285 - twister - DEBUG - DEVICE: 3<-OK
2024-11-08 00:18:01,289 - twister - DEBUG - DEVICE: PASS - test_i2s_transfer_short in 0.009 seconds
2024-11-08 00:18:01,295 - twister - DEBUG - DEVICE: ===================================================================
2024-11-08 00:18:01,299 - twister - DEBUG - DEVICE: TESTSUITE drivers_i2s_speed succeeded
2024-11-08 00:18:01,303 - twister - DEBUG - DEVICE: Running TESTSUITE drivers_i2s_speed_both_rxtx
2024-11-08 00:18:01,309 - twister - DEBUG - DEVICE: ===================================================================
2024-11-08 00:18:01,312 - twister - DEBUG - DEVICE: START - test_i2s_dir_both_transfer_long
2024-11-08 00:18:01,316 - twister - DEBUG - DEVICE: I2S_DIR_BOTH value is not supported.
2024-11-08 00:18:01,318 - twister - DEBUG - -- west flash: using runner jlink
-- runners.jlink: reset after flashing requested
-- runners.jlink: JLink version: 7.94a
-- runners.jlink: Flashing file: /home/ubuntu/nxp/frdm_mcxn947/temp/frdm_mcxn947_mcxn947_cpu0_twister_test_only/twister-out/frdm_mcxn947_mcxn947_cpu0/tests/drivers/i2s/i2s_speed/drivers.i2s.speed/zephyr/zephyr.bin

2024-11-08 00:18:01,321 - twister - DEBUG - DEVICE: SKIP - test_i2s_dir_both_transfer_long in 0.004 seconds
2024-11-08 00:18:01,327 - twister - DEBUG - DEVICE: ===================================================================
2024-11-08 00:18:01,331 - twister - DEBUG - DEVICE: START - test_i2s_dir_both_transfer_short
2024-11-08 00:18:01,334 - twister - DEBUG - DEVICE: I2S_DIR_BOTH value is not supported.
2024-11-08 00:18:01,339 - twister - DEBUG - DEVICE: SKIP - test_i2s_dir_both_transfer_short in 0.004 seconds
2024-11-08 00:18:01,345 - twister - DEBUG - DEVICE: ===================================================================
2024-11-08 00:18:01,349 - twister - DEBUG - DEVICE: TESTSUITE drivers_i2s_speed_both_rxtx succeeded
2024-11-08 00:18:01,353 - twister - DEBUG - DEVICE: ------ TESTSUITE SUMMARY START ------
2024-11-08 00:18:01,362 - twister - DEBUG - DEVICE: SUITE PASS - 100.00% [drivers_i2s_speed]: pass = 2, fail = 0, skip = 0, total = 2 duration = 0.043 seconds
2024-11-08 00:18:01,369 - twister - DEBUG - DEVICE: - PASS - [drivers_i2s_speed.test_i2s_transfer_long] duration = 0.034 seconds
2024-11-08 00:18:01,376 - twister - DEBUG - DEVICE: - PASS - [drivers_i2s_speed.test_i2s_transfer_short] duration = 0.009 seconds
2024-11-08 00:18:01,387 - twister - DEBUG - DEVICE: SUITE SKIP -   0.00% [drivers_i2s_speed_both_rxtx]: pass = 0, fail = 0, skip = 2, total = 2 duration = 0.008 seconds
2024-11-08 00:18:01,395 - twister - DEBUG - DEVICE: - SKIP - [drivers_i2s_speed_both_rxtx.test_i2s_dir_both_transfer_long] duration = 0.004 seconds
2024-11-08 00:18:01,404 - twister - DEBUG - DEVICE: - SKIP - [drivers_i2s_speed_both_rxtx.test_i2s_dir_both_transfer_short] duration = 0.004 seconds
2024-11-08 00:18:01,407 - twister - DEBUG - DEVICE: ------ TESTSUITE SUMMARY END ------
2024-11-08 00:18:01,413 - twister - DEBUG - DEVICE: ===================================================================
2024-11-08 00:18:01,417 - twister - DEBUG - DEVICE: RunID: 644752dc90e1bd6276df670431208ab6
2024-11-08 00:18:01,419 - twister - DEBUG - DEVICE: PROJECT EXECUTION SUCCESSFUL

Thanks @DerekSnell @hakehuang with so much suooprt and patience for this patch.

Thanks for this PR!

@hakehuang @DerekSnell
Thank you so much for working on this.   I have an immediate need for I2S on this platform and was happy to see this is almost there.

@DerekSnell   What is left too be able to merge this PR?

@mcuxted needs rebase to resolve merge conflict


CREST Alliances resource is not working properly

The AllianceCollection resource uses a anonymous json object as a wrapper for each alliance, which requires special handling.

Fixed https://github.com/ezet/evelib/releases/tag/EveCrest_v3.2.1


Import nginx-upload-module guide from wiki

Details of the instructions depend on the exact gem verion.

Coverage remained the same at 99.067% when pulling 32cdd0532c3346cd7b21794b2cf1445f6642e7ba on tf:nginx-upload-guide into 65ee2152bd0bfc58e91e1856e3d5f4646424c49a on codevise:master.

Coverage remained the same at 99.067% when pulling 32cdd0532c3346cd7b21794b2cf1445f6642e7ba on tf:nginx-upload-guide into 65ee2152bd0bfc58e91e1856e3d5f4646424c49a on codevise:master.


REF_CODE_REFACTOR: Maximum and Minimum

Refactoring the reference code for Maximum and Minimum operators.
BUG=refactoring existing code.

@advaitjain

Closing this PR for now, in favor of mututally agreed upon higher priority PRs.


BUG: linalg: fix int overflow in Cholesky (potrf)

Closes https://github.com/scipy/scipy/issues/17436
scipy.linalg.cholesky explicitly zeros out the "other" triangle of the output matrix. For the matrix size 47_000, flat indexing into the underlying buffer overflows int32 since (47_000)**2 > INT_MAX

Come to think of it, do we really need the test for this running all the time even on the slow CI? Let's run it here and then remove it I'd say. What do you think?

I did notice a potential flaw in the ability of our build system to auto-rebuild relevant parts of the build system when a pyr.src file changes on its own.

Notice that too. Annoying. depfiles for f2py modules, anyone? :-)

Hang in there, I'm slowly catching up ;)

Noticed that too. Annoying. depfiles for f2py modules, anyone? :-)

That'll be too much of a lift. gh-20342 is the pragmatic fix, just tracking the dependencies by hand. include statements in .pyf.src files should be rare, so this is good enough I'd say.


Add @NonNull to struct builder's copy constructor

The builder's copy constructor receives a struct value that can't be
null. Add @NonNull when Android annotations are enabled.
See #244

Codecov Report

Merging #250 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master    #250      +/-   ##
===========================================
- Coverage     76.57%   76.5%   -0.07%
  Complexity      378     378
===========================================
  Files            29      29
  Lines          1656    1656
  Branches        148     148
===========================================
- Hits           1268    1267       -1
  Misses          292     292
- Partials         96      97       +1

Impacted Files
Coverage Δ
Complexity Δ

...com/microsoft/thrifty/service/AsyncClientBase.java
62.35% <0%> (-1.18%)
7% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9919657...727c636. Read the comment docs.

Looks good to me - thanks!


fix(radar_tracks_msg_converter): fix twist coordinate conversion

Description
Fix twist coordinate conversion in radar_track_msg_converter.
Twist coordinate conversion fail for other than the front radar, so this PR fixes it.

Before

Left direction is front.
radar_tracks_msg_converter of rear center radar estimate moving in the opposite direction to the car following ego vehicle.

After

Left direction is front.
radar_tracks_msg_converter of rear center radar can estimate twist correctly.

Related links
Tests performed
Test by rosbag.
Notes for reviewers
Interface changes
None
Effects on system behavior
This PR change the behavior for the sensor system that has multi radars.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[ ] I've confirmed the contribution guidelines.
[ ] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Tested with a rosbag


Font size at the top filename title bar

Is there a possibility to change the font size at the top filename title bar?
I see different title font size when portrait and landscape mode.

how do you get the filename?


[PROG] Quick Sort

Program Description
Program to implement Quick Sort.
Additional
Update the documentation (DOC.md in sorting folder) to include Quick Sort.
Checklist

[x] This issue has not been mentioned in existing issues.

Sure

I have submitted the pull request for this issue.


Release/fix broken config

Try out this version of Leather — download extension builds.

Contains Fara's fix of config file

I didn't think we were releasing the UI refactor yet? 🤔

See related bug: https://github.com/leather-wallet/extension/issues/4575


[Bug]: The bit type pg database failed to roll back after being cleaned up after being archived to ob

ODC version
ODC432
OB version

pg9
oceanbase422

What happened?
The byte type pg database failed to roll back after being cleaned up after being archived to ob

What did you expect to happen?
。
How can we reproduce it (as minimally and precisely as possible)?
CREATE TABLE test_5 (
	col1 int4 NOT NULL,
	col2 numeric(10, 2) NULL,
	col3 numeric(10, 2) NULL,
	col4 bit(8) NULL,
	col5 int2 NULL,
	 PRIMARY KEY (col1)
);

INSERT INTO public.test_5 (col1,col2,col3,col4,col5) VALUES
	 (2,NULL,NULL,'10101010',NULL);

Anything else we need to know?
No response

fixed


Unable to place item frames in admin claim, Pixelmon entity IDs not found, NullPointerException on getFlagOverride

Hello, I'm making this issue, because of me not being able to place item frames (paintings are unplaceable as well) correctly. GPDebug returns entity-spawn minecraft:player minecraft:itemframe false even though it's set to true with override.
GP itself can't also find Pixelmon entity IDs on my server, I tried to set entity-spawn to true and false with various Pixelmon (I used pixelmon:budew as my entity ID, it worked fine with pixelmon:trader and other NPCs), but GP didn't return anything (autocomplete also didn't return any Pixelmon names), as if those entities didn't exist even though in GPDebug they were shown that way (pixelmon:houndoom for example, which also didn't return anything when trying to run flags with it).
Below I included my fml-server-latest.log, the first GP related error starts at line 6516, which is a NullPointerException on getFlagOverride if it's of any help.
fml-server-latest.log

Item frames can be placed fine with a fresh server. Setup a TEST server and reproduce it on there.
GP will NEVER autocomplete pixelmon entity ID's as they are NOT registered by pixelmon. GP literally does a hack to make it work with flags by using the entity name.
I'll be pushing a fix for the debug NPE shortly.


Add ability to load Element's edit form inline

For allowing a user to edit that element and save the changes without having to navigate through multiple page loads. Uses form schema for this puspose, and relies on correlating changes in silverstripe/admin and
silverstripe/framework in order to render the one bundled Element - Content (which requires info from the PHP side in order to render TinyMCE).
Resolves #327
Depends on https://github.com/silverstripe/silverstripe-admin/pull/628
Which in turn depends on https://github.com/silverstripe/silverstripe-framework/pull/8359

D: I don't understand why the behat tests fail :/

Needs a good rebase

@NightJar I've rebased this PR and fixed the conflicts.
I notice that the combination of these three PRs breaks the ability to add new blocks. Console error trace:
[captured JavaScript error] Uncaught TypeError: this.onmatch is not a function in http://localhost:8080/resources/vendor/silverstripe/admin/client/dist/js/bundle.js?m=1536155448:1:160084
STACKTRACE:
TypeError: this.onmatch is not a function
    at init.onadd (http://localhost:8080/resources/vendor/silverstripe/admin/client/dist/js/bundle.js?m=1536155448:1:160084)
    at s (http://localhost:8080/resources/vendor/silverstripe/admin/client/dist/js/vendor.js?m=1536155448:1:2029085)
    at Array.<anonymous> (http://localhost:8080/resources/vendor/silverstripe/admin/client/dist/js/vendor.js?m=1536155448:1:2041278)
    at HTMLDocument.<anonymous> (http://localhost:8080/resources/vendor/silverstripe/admin/client/dist/js/vendor.js?m=1536155448:1:2041867)
    at HTMLDocument.dispatch (eval at e.exports (http://localhost:8080/resources/vendor/silverstripe/admin/client/dist/js/vendor.js?m=1536155448:1:1941437), <anonymous>:3332:9)
    at HTMLDocument.eventHandle (eval at e.exports (http://localhost:8080/resources/vendor/silverstripe/admin/client/dist/js/vendor.js?m=1536155448:1:1941437), <anonymous>:2941:28)
    at Object.trigger (eval at e.exports (http://localhost:8080/resources/vendor/silverstripe/admin/client/dist/js/vendor.js?m=1536155448:1:1941437), <anonymous>:3210:12)
    at init.triggerHandler (eval at e.exports (http://localhost:8080/resources/vendor/silverstripe/admin/client/dist/js/vendor.js?m=1536155448:1:1941437), <anonymous>:3874:24)
    at Text.r (http://localhost:8080/resources/vendor/silverstripe/admin/client/dist/js/vendor.js?m=1536155448:1:2031442)
    at init.domManip (eval at e.exports (http://localhost:8080/resources/vendor/silverstripe/admin/client/dist/js/vendor.js?m=1536155448:1:1941437), <anonymous>:6049:15)

Evident in the behat tests which are currently breaking when trying to add a new block

Ok I've made a bunch of follow up commits and rebased the PR - I'll leave the rest to you. There's a comment on https://github.com/silverstripe/silverstripe-admin/pull/628 about the onmatch change breaking the ability to add new elements, which is in turn breaking the behat tests

I've re-run the builds, Behat is failing

Nice work everyone!


Luci-base; correct system error translation

Luci-base; Fixed Chinese translation error

The commit title needs to be in English and you need to sign-off the commit properly with your own name-


Metal , do not display   Feature set macOS GPUFamily2 v1

Thanks osy86 share, found the latest version 1.4.1，
Graphics card properties, Metal , do not display   Feature set macOS GPUFamily2 v1，
version 1.3

version 1.4.1

1.4.1 version only shows support

What was it before?

that what was before

that line is missing, but I will check if that have any impact, latest Geekbench version free actually testing metal.

Interesting, I think this is due to the new pid spoof that changes the number of CU.

im changed in old way like here - https://github.com/osy86/HaC-Mini/issues/30
and still system showing me  Feature set macOS GPUFamily2 v1

GPU acceleration doesn't work over Intel or AMD with Safari etc.
V2.0 Clean install (its weird if dosnt work with WG)

@piotrasd have you tried resetting NVRAM?

@piotrasd Did the geekbench score change? Is this a real issue?

I've confirmed this is a non-issue.
In System Profiler, the code to display "Supported, feature set macOS GPUFamily2 v1" is done by matching the metal device to the GPU.
The code to do this is by calling MTLCopyAllDevices() and then comparing the name property with the Chipset Model. When we use WG to spoof the Chipset Model to say "Vega M", it does not change the string in AMDMTLBronzeDriver which says AMD Radeon Polaris. That means it fails to match the Metal device with the GPU device.
A "fix" for this would be to patch the string inside AMDMTLBronzeDriver to match. Might do this in Polaris22Fixup in the future. Alternatively, disable the model name spoofing.
However, there is no performance difference because this is just a string display issue.


Reduce memory when upload large file to S3

I'm trying to upload large file(10GB) to S3 with multipart according this article. And receive OutOfMemoryError exception. How can I clear ByteBuffer for already uploaded parts or something else reduce memory usage?
I think can change something in this function https://github.com/eugenp/tutorials/blob/35d56f7756e4b2ad679207554fddb9adb183f4fe/aws-modules/aws-reactive/src/main/java/com/baeldung/aws/reactive/s3/UploadResource.java#L238 Somehow delete ByteBuffer from memory after upload is done.
AsyncRequestBody.fromPublisher(Mono.just(buffer))); use a lot of memory too.
Requests are being created too fast. How can I limit their number and launch new ones only when the future is over?

Hi, @Argunl.
Dealing with very large files is a complex edge case. Therefore, out of the scope of this article.
You can try limiting your client's request rate: https://www.baeldung.com/spring-webclient-limit-requests-per-second
Or, you can switch to a non-reactive file upload solution: https://www.baeldung.com/java-read-lines-large-file
Hope it helps.


Imagecache init from path bug report.

Hello,
Thanks for this library, I love your prefetcher (That I use as a multiple downloader) and the way that the code is divided ; It so easy to use just some parts of the framework. 👍
A little bug (or not)
when initialising a custom ImageCache, if the path given start with "file://" it doesn't work.
Can be annoying if we work with URL :
 let fileManager = NSFileManager.defaultManager()
 let directoryURL = fileManager.URLsForDirectory(.DocumentDirectory, inDomains: .UserDomainMask)[0]
let cache =  ImageCache(name: "custom", path: url.absoluteString) // not working

It doesn't work because NSURL absoluteString method give a string with scheme like this one ""file:///Users/lastMove/Library/Developer/CoreSimulator/Devices/6F2A9EAE-FEAC-4699-A2E4-E4CC2BA5B32C/data/Containers/Data/Application/E348EA47-08C1-468C-B22E-F75E6DB85159/Documents/images_firstAid/com.onevcat.Kingfisher.ImageCache.images_firstAid"
Some possibility to improve the behavoir :

add a convenience init(name:String, url:NSURL)
or just remove the stringByReplacingOccurrencesOfString("file://", withString: "")

You should use url.path, not url.absoulteString.


fix ConsRepAgentModel example

test was copied from ConsMedModel

On this shortly.
On Thu, Feb 25, 2021 at 11:29 AM Sebastian Benthall <
<EMAIL_ADDRESS>wrote:

Assigned #964 https://github.com/econ-ark/HARK/issues/964 to @mnwhite
https://github.com/mnwhite.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/econ-ark/HARK/issues/964#event-4377523626, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ADKRAFM33RAUC6HWVPYT7ALTAZ3HFANCNFSM4YGZ7ACA
.


blog: add March 2023 transparency report

source: https://reddit.com/r/Monero/comments/11fslu9/
closes #2408

duplicate of #2176