parking_lot_core 0.8.1 wasm link issue

Starting with parking_lot_core 0.8.1, when compiling to wasm there is now a depdendency on "env".
This means one can no longer use parking_lot from within a wasm runtime, such as wasmtime.
When compiling for the web, one can address this problem with parking_lot = { version = "0.11", features = ["wasm-bindgen"] }, but this does not work for non-web wasm runtimes.
Reproduce
Cargo.toml:
[package]
name = "parking_lot_test"
version = "0.1.0"

[dependencies]
parking_lot = "0.11"
parking_lot_core = "=0.8.1"

main.rs:
fn main() {
    let m = parking_lot::Mutex::new(());
    let _lock = m.lock();
}

Using wasm2wat:
§ cargo build --target "wasm32-unknown-unknown"
§ wasm2wat target/wasm32-unknown-unknown/debug/parking_lot_test.wasm | rg import
> (import "env" "now" (func $now (type 7)))

(with parking_lot_core = "=0.8.0" there is no import "env")

https://github.com/Amanieu/parking_lot/compare/0.8.0...0.8.1?w=1#diff-f8a0a8b9353ddc2e1efd135d75ec0668f64e2674c15e9b1cda089cbd69f60372 shows no difference in the parking implementation between v0.8.0 and v0.8.1 that could explain this. Does this still happen with LTO enabled?

I tested it now with --release and [profile.release] lto = true – same problem.

I suspect this is related to parking_lot_core:s use of https://github.com/sebcrozet/instant

The parking_lot algorithm itself need to know the current time for fair locks but the single-threaded wasm option shouldn't need this as there are no other threads against which it needs to be fair.

Interesting!
Is there a way to tell parking_lot that it is compiling for a single-threaded target, so that it does not require the instant crate at all? If not, should there be?

It should compile for a single-threaded target by default. Multi-threading requires the bulk memory wasm proposal and atomic instructions. Both of which are not supported for the WASM MVP that is targeted by default. In addition it requires all parts of the program to be compiled with multi-threading support I believe, but libstd isn't by default.

I suspect that the only reason parking_lot 0.8.0 worked and 0.8.1 doesn't is because some subtle failure of rustc to elide unused code (using instant).

For my use-case ("pure wasm" = no instant) we would need cfg-blocks around all uses of the instant crate, as well as around functions that uses time, such as wait_until, try_lock_until etc.
For example:
#[cfg(feature = "instant")]
unsafe fn park_until(&self, timeout: Instant) -> bool { ... }

This would be a very intrusive change to the parking_lot code base, disabling all uses of times (Instant and Duration).
(Using #[cfg(not(target_arch = "wasm32"))] would not be a good idea, because when compiling wasm to the web instant works fine with features = ["wasm-bindgen"]).

Another alternative is that I create a new wrapper crate around parking_lot which exposes only what I need (Mutex and RwLock) and that has a feature-flag for single-threaded, no-instant compile-targets that just uses a bool to check if a Mutex is already locked (just to panic on reentrant double-lock).

Why do you need locking primitives in a single threaded environment?

Why do you need locking primitives in a single threaded environment?

Great question!
Say you have a library that may or may not be used from a multithreaded context, so the library uses parking_lot::Mutex in a few places. There is also an app that wants to use that library. The app happens to be compiled to a singlethreaded wasm32 target. Should this be possible?
The answer is: it used to be possible, but with parking_lot_core 0.8.1 it no longer is.
So who's responsibility is it to fix this?
The app can do a work-around by addingparking_lot_core = "=0.8.1" to it's Cargo.toml, but that work-around will only work for so long. As soon as the library upgrades to a future `parking_lot_core = 0.9.0" then the app can no use the latest version of that library.
The library could add feature flags around all uses of parking_lot, but there are a lot of libraries using parking_lot, and the app developer will have trouble changing all the libraries.
The third place to fix this is in parking_lot itself, but saying "parking_lot supports pure wasm32 contexts". I think this is the route that is the best.

In summary:
Either we say "parking_lot should work for pure wasm32 targets" and work towards that, OR we say "if you use parking_lot in your library, then your library cannot be used by apps that want to compile to pure wasm32 targets".

That makes sense. I got the imoression that your code needed it directly and your code was targeting single threaded wasm only :)

Isn't it related to this?
https://github.com/rust-lang/rust/issues/72758#issuecomment-636184695
(import "env" "now" (func $now (type 7)))
it also feels like coming from this line
https://github.com/Amanieu/parking_lot/compare/0.8.0...0.8.1#diff-c6e37a4985a3b050dda1f692981c6de9f3d039f86312603801f9901167e843a8R57
if let Some(left) = timeout.checked_duration_since(Instant::now()) {

Isn't it related to this?
https://github.com/rust-lang/rust/issues/72758#issuecomment-636184695
(import "env" "now" (func $now (type 7)))
it also feels like coming from this line
https://github.com/Amanieu/parking_lot/compare/0.8.0...0.8.1#diff-c6e37a4985a3b050dda1f692981c6de9f3d039f86312603801f9901167e843a8R57
if let Some(left) = timeout.checked_duration_since(Instant::now()) {

That one is only used when wasm atomics are enabled, which aren't by default.

That one is only used when wasm atomics are enabled, which aren't by default.

Sorry, I misread some of the comments, it feels like the source and the solution have already been found.

Sorry, I misread some of the comments, it feels like the source and the solution have already been found.

Would indeed be great to clarify if non-web wasm32-unknown-unknown is intended to not be supported anymore with parking_lot, or if it is and then fix this by not depending on instant and disable the parts of the API that require it timing access.

wasm32-unknown-unknown is a bit of weird target: it really should have been a #[no_std] target but instead comes with a mostly non-functional std. parking_lot does require a working std for various features such as Instant (for timed locks/waits), thread-local storage, blocking in the OS, etc.
I'm happy to accept any PRs to support wasm32-unknown-unknown (e.g. by simply disabling all time-related functionality) but in the end this target will have to be supported by users and not by myself (since I don't use WASM personally and am not familiar with all the ways it can be embedded).

Yeah wasm32-unknown-unknown is indeed an odd target, would have preferred it to be a lean no-std target (which is how we use it) and have the web bindings using a separate wasm32-web (or similar target), and WASI for std-target for running primarily outside of browser.
For now we haven't run into that many dependencies that we use in wasm32-unknown-unknown that also uses parking_lot, mainly a few of our own that uses parking_lot instead of std as faster primitives for native compilation and for wasm intending to have it just be no-ops in most cases as it is a singlethreaded no-std environment. But so far we've been able to just remove the parking_lot dependencies, that could get harder going forward though but works for now.

This recently popped up again, as https://lib.rs/crates/string_cache just got an update, adding parking_lot as a dependency. string_cache in turn is a dependency of https://lib.rs/crates/scraper .

My temporary workaround is to add the following to my Cargo.toml file.
[target.'cfg(target_arch = "wasm32")'.dependencies]
parking_lot_core = "=0.8.0"

@Amanieu 🙌


Added more file types and mappings validation

I think you also need an undefined check for the partOfSpeech and languagefile error check and it might be better to only show the mappings error once someone has selected a file, input type, and output type.

I think you also need an undefined check for the partOfSpeech and languagefile error check and it might be better to only show the mappings error once someone has selected a file, input type, and output type.

Should be resolved now.


CDR De/Serialization

Hello,
Is the current built in CDR using equivalent to openDDS XCDR1 or XCDR2 ?

I do not know. The current built-in CDR serializer is according to Common Data Representation spec from OMG, in this document , Section 15.3. It may interoperate or may not.
So far, we have not implemented the XTypes specification.
Please do some experiments and tell us about your findings, so we know if we are missing something.

AFAICT XCDR1/2 are defined in: https://www.omg.org/spec/DDS-XTypes and are extensions over CDR, however it looks like some of the extensions might be part of RTPS already - so you may already have some/most of it.
Would you be interested in separating out the serde lib in RustDDS to a standalone library? I have interest in trying to use it with CycloneDDS (where bindings are encouraged to encode messages themselves)

If you mean the CDR serialization/deserialization parts, then yes, why not.
It is not in our current roadmap, and therefore not a priority item, but if you would like to do it, then please go ahead. Then you could use it independent of RustDDS if you like.
However, I would like to be the owner of that package/repo, as CDR serialization is an integral part of RustDDS.

Great, I don't have any particular roadmap for it either, but it's very useful to know that you would be fine with that happening. I wouldn't even mind it remaining in this repo as a second crate (using cargo workspace), but a second repo might make it easier to have more owners/contributors if that lib was used as a building block for other DDS-related crates.


issue with using "nlikes=x"

Before submitting an issue, make sure you have:

[x] Updated to the latest version
[x] Read the README and docs
[x] Searched the bugtracker for similar issues including closed ones

Purpose of your issue?

[x] Bug report (encountered problems/errors)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

Hello, I think that something is wrong with the latest version of this bot, when I set it to like for example 3 photos of each user by adding "nlikes=3" it will filter this user 3 times,
screenshot: http://i63.tinypic.com/qzeiva.png
As you can see on screenshot user is filtered 3 times (1 filtering for every like).
In my old version of this bot everything works fine

Solution: build your own filter_medias an get the items from media["media_or_ad"].
Example:
feed = []
for media in bot.api.last_json["feed_items"]:
media = media["media_or_ad"]
if 'pk' in media and not media['has_liked']:
feed.append(media['pk'])


diff api should support an iterable interface

indexedSequenceDiff, orderedSequenceDiff, listDiff, setDiff, mapDiff, etc. should support an interface that allows for caller to not have to wait for entire diff calculation to finish, for us not to have to calculate entire diff calculation when called, but to continue finding next diffs when next() is called
this will hopefully allow us to remove the loadLimit param on indexedSequenceDiff too.

this is done \o/


[BUGFIX] Tweak phpdocumentor dependency to avoid install conflicts

What

Change phpdocumentor/phpdocumentor require-dev dependency from ~2 to ^2.7.

Why

Resolves a dependency conflict when installing in dev mode (issue #420).

LGTM

I'm still having the issue, it breaks on phpdocumentor 2.9.0, here's my steps to reproduce the issue.
Latest commit 9225c967a5395e4643b5124806191c038fb1224b
git clone https://github.com/justinrainbow/json-schema.git
git checkout origin/6.0.0-dev
composer install

to solve the issue, change phpdocumentor/phpdocumentor require-dev dependency from ^2.7 to ^2.9

@chocopowwwa That's really weird - this problem is definitely solved on Travis (see here).
Which PHP version are you using?
Can you please confirm the commit hash of origin/6.0.0-dev that you are using to test?

Hi,

PHP 7.1.5 (cli) (built: May  9 2017 16:55:02) ( NTS )
Copyright (c) 1997-2017 The PHP Group
Zend Engine v3.1.0, Copyright (c) 1998-2017 Zend Technologies
with Xdebug v2.5.3, Copyright (c) 2002-2017, by Derick Rethans

Composer version 1.4.2 2017-05-17 08:17:52

Hi, here's my details:
( Sorry i put the wrong commit hash up there )
Commit Hash:

git rev-parse HEAD
2d404b8035f8dc349ebbf6b9281d173473a7c871

PHP 7.1.5 (cli) (built: May  9 2017 16:55:02) ( NTS )
Copyright (c) 1997-2017 The PHP Group
Zend Engine v3.1.0, Copyright (c) 1998-2017 Zend Technologies
with Xdebug v2.5.3, Copyright (c) 2002-2017, by Derick Rethans

Composer version 1.4.2 2017-05-17 08:17:52

$ composer install
  Problem 1
    - Conclusion: don't install phpdocumentor/phpdocumentor v2.9.0
    - phpdocumentor/phpdocumentor v2.7.0 requires phpdocumentor/fileset ~1.0 -> satisfiable by phpdocumentor/fileset[1.0.0].
    - phpdocumentor/phpdocumentor v2.7.1 requires phpdocumentor/fileset ~1.0 -> satisfiable by phpdocumentor/fileset[1.0.0].
    - phpdocumentor/phpdocumentor v2.8.0 requires phpdocumentor/fileset ~1.0 -> satisfiable by phpdocumentor/fileset[1.0.0].
    - phpdocumentor/phpdocumentor v2.8.1 requires phpdocumentor/fileset ~1.0 -> satisfiable by phpdocumentor/fileset[1.0.0].
    - phpdocumentor/phpdocumentor v2.8.2 requires phpdocumentor/fileset ~1.0 -> satisfiable by phpdocumentor/fileset[1.0.0].
    - phpdocumentor/phpdocumentor v2.8.3 requires phpdocumentor/fileset ~1.0 -> satisfiable by phpdocumentor/fileset[1.0.0].
    - phpdocumentor/phpdocumentor v2.8.4 requires phpdocumentor/fileset ~1.0 -> satisfiable by phpdocumentor/fileset[1.0.0].
    - phpdocumentor/phpdocumentor v2.8.5 requires phpdocumentor/fileset ~1.0 -> satisfiable by phpdocumentor/fileset[1.0.0].
    - Conclusion: don't install phpdocumentor/fileset 1.0.0|install phpdocumentor/phpdocumentor v2.9.0
    - Installation request for phpdocumentor/phpdocumentor ^2.7 -> satisfiable by phpdocumentor/phpdocumentor[v2.7.0, v2.7.1, v2.8.0, v2.8.1, v2.8.2, v2.8.3, v2.8.4, v2.8.5, v2.9.0].

ahh okay, turns out i'm using different phpunit version
mine is 5.7.19
tested using PHPUnit 4.8.35 works fine, my bad.

That would do it ;-). PHPUnit 5 isn't compatible with PHP 5.3 unfortunately, so this library is stuck with PHPUnit 4.8.

Just to clarify, before I assume this is resolved - am I correct in my understanding that you had manually changed the PHPUnit dependency version in composer.json#/require-dev, and the install failure occured only after you had made that change (i.e. doing a normal install with no modifications worked)?

nope, i run phpunit 5 from my composer global
./vendor/bin/phpunit should do the work
the install error caused by phpdocumentor/phpdocumentor : ^2.7 dependency
after i edit manually phpdocumentor/phpdocumentor to ^2.9 the installation works, and also it pass the test

OK - so the install problem is still there on your system, when using phpdocumentor/phpdocumentor : ^2.7?
Are you forcing any other package versions?

@erayd
i tested:
-> ^2.7 : error
-> ^2.8 : error
-> ^2.9 : no error
are you able reproduce the issue?

@chocopowwwa I have not managed to reproduce this since I fixed it the first time around, either locally on my dev system or on Travis. I'll have another crack at this tomorrow.
In the meantime, any detail you can provide regarding your environment would be extremely helpful - in particular, anything that deviates from defaults.
As a temporary workaround, you can simply remove phpdocumentor completely. This will prevent you from building the API documentation, but nothing else, and the API docs are a complete mess at the moment anyway - sorting the documentation is one of the many things on my to-do list.

@chocopowwwa I'm still not able to reproduce this. Could you please run the script below exactly as it appears here, and paste the full output:
php --version
composer --version
cd /tmp
git clone https://github.com/justinrainbow/json-schema.git
cd json-schema
git checkout 6.0.0-dev
grep phpdocumentor composer.json
composer install
rm -rf vendor composer.lock
git checkout 5.x.x
grep phpdocumentor composer.json
composer install

https://gist.github.com/chocopowwwa/8b3fe8cf246039cefdf0fbf91c805003
i'm sorry @erayd its all fine, on 6.0.0-dev but it breaks on origin/6.0.0-dev, that's kinda weird


CUDA kernel sync problem

When running test_kernel.py of the cuda branch, the maximum difference between simulated result and kernel result is significant (~0.5). The old cuda branch doesn't have this problem.
When tracking down the problem, I found that when iterating over batch we only sync threads after updating blockvec. My conjecture is that it's because when one thread is calculating res using the blockvec vector while another thread already enters the next iteration updating blockvec again. One simple solution may be to add another __syncthreads at the beginning or end of each iteration.

Fixed it. maybe


AttributeError: module 'tvm' has no attribute 'module'

I met this mistake while loading transfered models
Traceback (most recent call last):
    File "run.py", line 13, in <module>
        loaded_lib = tvm.module.load(test_lib)
AttributeError: module 'tvm' has no attribute 'module'

What happened? If not avaliable, how would I load models using tvm?
Listed below are codes.
import numpy as np
import tvm
import tvm.relay as relay
from tvm.contrib import graph_runtime

import cv2 as cv

test_json = 'resnet18_simple.json'
test_lib = 'resnet18_simple.so'
test_param = 'resnet18_simple.params'

loaded_json = open(test_json).read()
loaded_lib = tvm.module.load(test_lib)
loaded_params = bytearray(open(test_param, "rb").read())

Please use https://discuss.tvm.apache.org/ for related questions, you should use tvm.runtime.load_module

Please use https://discuss.tvm.apache.org/ for related questions, you should use tvm.runtime.load_module

Thanks a lot !


Model collapsed

用小点训练集结果还看得下去，用大一点的连图像都没有了。我准备试试WGAN的loss,看行不行。

@yangzhikai There are 19,000 data sets in my data set. At the beginning of training, there are no images until 4100 iteration.  When iteration reaches 6000iteration, there are clear results with faces.  I'm too quick to comment on models.

Well done. I think you can check some tricks about how to train a GAN (for example). I'm not familiar with training a GAN and do not have more time doing research on it, so maybe I don't have the ability to answer your training questions now. Thanks.


@unocss/preset-icons broken?

UnoCSS version
0.58.4
Describe the bug
I am using @unocss/nuxt. If presetIcons() is in my uno.config.ts, the build of __uno.css will fail. Directly accessing it will produce following log:
[8:22:48 PM]  ERROR  Internal server error: Error: Cannot find module @iconify-json/simple-icons-x imported from file://[Project Root], file://[Parent of Project Root], file://[Project Root]/_index.js, file://[Parent of Project Root]/node_modules
      at resolvePath (file://[Project Root]/node_modules/mlly/dist/index.mjs:2121:10)
      at task (file://[Project Root]/node_modules/@iconify/utils/lib/loader/fs.mjs:44:31)
      at async loadNodeIcon (file://[Project Root]/node_modules/@iconify/utils/lib/loader/node-loader.mjs:31:19)
      at async [Project Root]/node_modules/@unocss/preset-icons/dist/shared/preset-icons.5PH3fREn.cjs:811:22
      at async rules.layer.layer ([Project Root]/node_modules/@unocss/preset-icons/dist/shared/preset-icons.5PH3fREn.cjs:767:21)
      at async UnoGenerator.parseUtil (file://[Project Root]/node_modules/@unocss/core/dist/index.mjs:948:22)
      at async UnoGenerator.parseToken (file://[Project Root]/node_modules/@unocss/core/dist/index.mjs:682:120)
      at async file://[Project Root]/node_modules/@unocss/core/dist/index.mjs:717:23
      at async Promise.all (index 2798)
      at async UnoGenerator.generate (file://[Project Root]/node_modules/@unocss/core/dist/index.mjs:738:5)
      at async generateCSS (file://[Project Root]/node_modules/@unocss/vite/dist/index.mjs:613:16)
      at async Context.load (file://[Project Root]/node_modules/@unocss/vite/dist/index.mjs:730:31)
      at async file://[Project Root]/node_modules/vite-plugin-inspect/dist/index.mjs:406:17
      at async file://[Project Root]/node_modules/vite-plugin-inspect/dist/index.mjs:406:17
      at async Object.load (file://[Project Root]/node_modules/@nuxt/vite-builder/node_modules/vite/dist/node/chunks/dep-9A4-l-43.js:64034:32)
      at async loadAndTransform (file://[Project Root]/node_modules/@nuxt/vite-builder/node_modules/vite/dist/node/chunks/dep-9A4-l-43.js:49665:24)
      at async warmup (file://[Project Root]/node_modules/@nuxt/vite-builder/dist/shared/vite-builder.RU3bcDTV.mjs:881:7)
      at async Promise.all (index 1)
      at async warmup (file://[Project Root]/node_modules/@nuxt/vite-builder/dist/shared/vite-builder.RU3bcDTV.mjs:891:7)
      at async Promise.all (index 10)
      at async warmup (file://[Project Root]/node_modules/@nuxt/vite-builder/dist/shared/vite-builder.RU3bcDTV.mjs:891:7)
      at async Promise.all (index 6)
      at async warmup (file://[Project Root]/node_modules/@nuxt/vite-builder/dist/shared/vite-builder.RU3bcDTV.mjs:891:7)
      at async Promise.all (index 0)
      at async warmupViteServer (file://[Project Root]/node_modules/@nuxt/vite-builder/dist/shared/vite-builder.RU3bcDTV.mjs:896:3)

The reproduction StackBlitz show a similar error, with a different icon instead of simple-icons-x.
NOTICE: Downgrading just @unocss/preset-icons to 0.58.3 solve this problem too.
Reproduction
https://stackblitz.com/~/edit/unocss-unocss-7ukrn3
System Info
macOS 14.3, Arc browser 1.28.0 (45831), Nuxt, Bun as package manager
Validations

[X] Read the Contributing Guidelines.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Will #3539 be correlated?

no, I guess it is about last iconify utils package version https://github.com/iconify/iconify/pull/280#issuecomment-1925607036, try fixing the version to 2.1.20  in you package.json file: "@iconify/utils": "2.1.20" (in your dev dependencies, maybe you'll need to use resolutions or another package entries dependending on you package manager, for example "pnpm.overrides")
Can you check @iconify/utils version in your application?
Here your reproduction working: https://stackblitz.com/c/edit/unocss-unocss-v79njm?file=package.json
Now the json file is loaded by mlly  instead from local-pkg, maybe you also need to include some option in tsconfig.json.

it seems @cyberalien has found the problem, he's going to release a next version to do some tests later will be fixed and released.

should be fixed in new @iconify/utils release, update the dependency or use  ^2.1.22: https://stackblitz.com/c/edit/unocss-unocss-v79njm?file=package.json

Should be fixed now. Try<EMAIL_ADDRESS>One of resolvePath calls in recently updated code was missing error handling, so it threw error.

The problem persisted in my case. I've add "@iconify/utils": "^2.1.22", to my devDependencies and I saw below:
bun update v1.0.25 (a8ff7be6)

 +<EMAIL_ADDRESS>
warn: nuxt-app's postinstall script took 1.6s

 2 packages installed [3.82s]

I think this is because @unocss/preset-icons have it's own node_modules. Should a dependency bump version for @unocss/preset-icons released too? Or should some measures be done by me locally?

Can you create a reproduction?

try "resolutions": { "@iconify/utils": "2.1.22" } (remove dev dependency, we need to update unocss)

Yes, I removed (actually rename) node_modules dir inside @unocss/preset-icons and it worked.

phew. so update worked. i'll change it to latest tag

try "resolutions": { "@iconify/utils": "2.1.22" } (remove dev dependency, we need to update unocss)

This trick worked too, @unocss/preset-icons now don't have its own node_modules. Is there a less hacky approach for "not having its own node_modules"?

We cannot solve it, you/we need to use package manager "override" stuff to do this (override should work with npm and resolutions should work with yarn and pnpm, when using pnpm you can also use pnpm.overrides): we can move unocss dependencies to dev dependencies, but then everyone will need to install all unocss dev dependencies on each project, no make sense

I found that I can actually remove @iconify/utils and the resolution works. I'll call it a day.


Rework Interrupt enum for MSP430

This also removes the bare-metal dependency from PACs created for
MSP430, as requested in
https://github.com/rust-embedded/svd2rust/pull/455#issuecomment-665214017
Signed-off-by: Daniel Egger<EMAIL_ADDRESS>

r? @burrbull
(rust_highfive has picked a reviewer for you, use r? to override)

CC @cr1901

@therealprof Unable to test right now... it looks fine to me. Since msp430 crate at present relies on bare_metal to import CriticalSection and Mutex, I think I'll need to bump the patch version and require that anyone generating a PAC use at least a (to-be-published) v0.2.3 version of msp430 crate.
However, this doesn't affect the public API and it's an impl detail that msp430 still depends on bare_metal, so no rush.

Since the generated PACs don't depend on bare-metal anymore you are free to use any version you'd like in your application or other dependencies without conflict.

r? @adamgreig

@adamgreig Are we good to go now?


Unstable require context

Hi,
I am migrating a rather large project and I have a strange issue with the require.context. It would take me a while to try and simplify the repro so just asking beforehand in case someone can help me explain the behavior.
Imagine the following file structure
folder 1
--- module 1.1
--- module 1.2
folder 2
--- module 2
folder 3
--- module 3
app.js
In app.js I need to dynamically load all modules from folder 1 and folder 2, so I write:
var req = require.context("folder1/", true);
req.keys().forEach(function(key){ req(key); });

req = require.context("folder2/", true);
req.keys().forEach(function(key){ req(key); });

So far so good, I get 2 dynamic modules for both folders and all files are loaded.
Now, somewhere in the bottom of app.js I write
var module3 = require("folder3/module3");

And now suddenly instead of folder2 I get a webpackMissingModule() and it complains at runtime that module folder2/ could not be found.
The interesting thing is that module3 is in no way related to folder1 or folder2. It's just a module without any dependencies...
Am I doing something what webpack is not designed for? Or does it seem like a bug with dependency management?

Can you check with webpack 2?


Can not show when using Get.context with Getx package

#96

I noticed this fix didn't re-add the line for adding the overlay to the overlayManager, which is used when checking things like the position of a stacked notification. I made a PR that adds this back in.
Do you think this could merge into dev instead of the v2.2.1 branch?

Youre right, didnt notice that.

@TOMSLAUS thanks for the updates it's a good fix, just update the target branch to dev and not v2.2.1 because we should publish this fix on the next version

@koukibadr  Thank you, i opened another pull request for dev branch.
https://github.com/koukibadr/Elegant-Notification/pull/139


Support custom encoder/decoder

Now it looks hardcoded to JSON:
https://github.com/asdine/storm/blob/master/save.go#L62

I believe the custom encoder/decoder should be stored in the storm.DB struct, that way the API remains simple and not be passed to Save or Find
A function type must be defined, something like this maybe:
EncoderFunc func(v interface{}) ([]byte, error)
DecoderFunc func(data []byte, v interface{}) error

That way we can have:
db.SetEncoder(json.Marshal)
db.SetDecoder(json.Unmarshal)

As the decoder/encoder must be symmetric (or at least in any case I can think of -- it would lead to confusing bugs if you set the encoder, but forget the decoder or the other way around), it would make sense to:
Add a interface with a Decode and Encode function and implement the JSON case as the default one. This fits better with the other encoding packages out there (like gob).
The hardest part is to find a decent name for the interface ... EncodeAndDecoder ...?

As I need this to try this ORM on my app, I can create a PR for this.

Sure!
For the name of the interface, we can mimic the go standard library: Reader + Writer = ReadWriter.
So what about EncodeDecoder ?

EncodeDecoder

That works.

Tip: Just tested Storm with https://github.com/Sereal/Sereal/tree/master/Go -- with proper object refs support including circular references, works like a charm and is way powerful.

Do you think that's something that we should propose by default?

that we should propose by default?

Hmm... It is a little bit exotic, I just found a curious issue (see https://github.com/Sereal/Sereal/issues/130), but it is in some sense backed by booking.com so it is pretty serious. And it solves some really hard problems.
Go's JSON encoder goes into a stack overflow panic if you send a object circular ref into it. I created a bug in Go about it (I don't expect them to handle it in JSON, but a little bit friendlier). "Who would ever want to serialize object graphs with circular refs?" was a question from one in the Go team. Pretty common, if you ask me.
I would probably consider gob as a good default for Storm, but as the interfaces a are simple to implement I would suggest adding Sereal into package /storm/codec/sereal, or something so people only needs to "go get" it if they really want it.


Adds Api module to handle HTTP parsing using servant

First, this PR is just to discuss the approach, so it's totally incomplete but I wanted to have a green light before spending any more time.
The idea is to isolate the Api design from it's implementation (as we've been discussing), with servant the whole Api shape gets nicely encapsulated in a Api type.
We can extend servant and add any combinators we like to extract info from the HTTP request. There is an example in which I extract the whole queryString to a list here:
instance HasServer api => HasServer (QueryString :> api) where

More examples of how to extend servant are found here: http://haskell-servant.github.io/extending.html
Servant also solves the content type problem in a very elegant way, for we can provide different instances for our result data type and define in this instance how to serve it.
This can be seen here where I've defined an instance for PlainText:
instance MimeRender PlainText ResultSet where
    mimeRender _ = cs . show

More can be read here:
http://haskell-servant.github.io/tutorial/server.html#using-content-types-with-your-data-types
Overall it seems a very thin layer, would not add a lot of overhead (although it's relies heavily on several GHC extensions) and would encapsulate a big chunk of our custom code that deals with HTTP.

Sorry I haven't responded sooner about this. I'm grateful you're exploring this. How about we finish the current refactor which is pretty intense, get version 0.3 released, and then think about applying Servant?

Sounds good, I'll close this for now and reopen once we have a more stable codebase ;)

I would love to see this issue re-opened ... Particularly now that servant-swagger and swagger2 have been announced (https://www.reddit.com/r/haskell/comments/44gemu/announcing_servantswagger_and_swagger2/).
I would be quite interested in a swagger compatibility layer (alike Dreamfactory)

@PierreR I'm not sure if this approach is interesting. Once I started coding I realized that for a dynamically generated API such as the one we have in PostgREST the servant types don't make the code much simpler. For we can't define the endpoints at compile time.

@diogob To be honest as a mere user of Postgrest I don't care much about it using Servant or not. But I would love to have a swagger compatibility layer. Maybe I should fill in a new issue for this ?

There already quite a few issues about this, but the initial target is RAML, take a look at #8  #144 #449


dart: initializer expression must be compile time constant

when we use string interpolation in ts in our const constructor we need to convert it to string concats for dart const constructors to work properly.
for example
@CONST
class Foo {
  baz: string;
  constructor(bar: string) {
    this.baz = 'Qux ${bar}';
  }
}

should output in dart
for example
class Foo {
  final String baz;
  const Foo(String bar) : baz = 'Qux ' + bar + '';
}

please see
https://github.com/angular/angular/pull/2131#issuecomment-106915423
converting OpaqueToken to a const constructor I ran into a dart problem.
Internal error: 'package:angular2/src/di/opaque_token.dart': error: line 10 pos 36: initializer expression must be compile time constant.
    const OpaqueToken(String desc) : _desc = '''Token(${ desc})''';

I'm still having Dart const problems :/ here's my typescript OpaqueToken
import {CONST} from 'angular2/src/facade/lang';
/**
 *
 *
 * @exportedAs angular2/di
 */
@CONST()
export class OpaqueToken {
  _desc: string;

  constructor(desc: string) { this._desc = `Token(${desc})`; }

  toString(): string { return this._desc; }
}

dart output
library angular2.src.di.opaque_token;

/**
 *
 *
 * @exportedAs angular2/di
 */
class OpaqueToken {
  final String _desc;
  const OpaqueToken(String desc) : _desc = '''Token(${ desc})''';
  String toString() {
    return this._desc;
  }
}

might be related

dart/issues#19558
dart/issues#392

the fix was editing dart output to
library angular2.src.di.opaque_token;

/**
 *
 *
 * @exportedAs angular2/di
 */
class OpaqueToken {
  final String _desc;
  const OpaqueToken(String desc) : _desc = 'Token(' + desc + ')';
  String toString() {
    return this._desc;
  }
}

we could provide this workaround in ts2dart (I think this is where the changes should go call.ts#L143)

ts2dart is intentionally a pretty dumb converter. Dumb is better as it leads to fewer unwelcome surprises. I think in this case the answer is simply to not do that, in particular as there is a simple workaround available with string concatenation in your TypeScript code to being with.
So the fix is either to teach Dart to recognize string interpolation literals as compile time constants, or to just use string concatenation in your TS code.


Add reimbursement method options on meal summary

Move 'name on check' field to below payment option field and say 'only if chose check' or so.
Originally created by Tom Smyth at 2015-11-18 01:50, migrated from redmine-#3654

Description updated (diff)

By Tom Smyth at 2015-11-18 06:51

Status changed from New to Closed

By Tom Smyth at 2016-03-19 22:58


Cleanup docker deps

This cleans up the vendor tree, and migrates all of the remaining imports from github.com/docker/docker to internal packages.

The final dependency on github.com/docker/docker/pkg/archive has been removed.


Styles: Add StyleFrameProvider for iFrame rendering

This update adds a new component to the @wp-g2/styles package, <StyleFrameProvider />.
<StyleFrameProvider /> is to handle component rendering in iFrames. It does this by identifying the correct document.head DOM node to synchronize styles rendered by the custom Emotion instance.
In other words... components should render perfectly whether they live in an iFrame (any iFrame) or not, without having to do anything (other than using <StyleFrameProvider />.
Example:
<Frame>
  <StyleFrameProvider>
    <Button>Let It Go</Button>
  </StyleFrameProvider>
</Frame>

A special thanks to @aristath for popping in the Zoom call and pairing (🍐)! It was really helpful (and fun)
Demo Preview:
https://g2-git-style-frame-provider.itsjonq.vercel.app/iframe.html?id=examples-wip-contextrendering--default&viewMode=story

Interesting!... it doesn't seem to work on production builds 🤔 .
It works for dev builds though.
Will need to continue poking!

Fixed production (isSpeedy) rendering!


Support text column insertion

What problem does this PR solve?
Issue link: https://github.com/KipData/KipSQL/issues/72
What is changed and how it works?
Code changes

[x] Has Rust code change
[ ] Has CI related scripts change

Check List
Tests

[ ] Unit test
[ ] Integration test
[x] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Note for reviewer

I think LogicType::Text should not correspond to Utf8 in DataValue, because the actual group representation of Text is not a String, but a combination of prefix + File

If the text function needs to be implemented using multiple PRs, then I think you can create a separate branch to submit (after this PR)

If the text function needs to be implemented using multiple PRs, then I think you can create a separate branch to submit (after this PR)

https://github.com/KipData/KipSQL/tree/feat/text


Inconsistent readonly object

Hi there,
The readme indicates there are two kinds of usage of on_replica.
ActiveRecord::Base.on_replica do
  Account.find_by_big_expensive_query
end

Account.on_replica.find_by_big_expensive_query

I think they should both return readonly objects, but it turned out only the latter one is readonly.
ActiveRecord::Base.on_replica do
  Account.find_by_big_expensive_query.readonly?
end
=> false

Account.find_by_big_expensive_query.readonly?
=> true

Did I miss something here?
Environment:

active_record_shards: git master
rails: 4.2

the second case fetches the objects from reader, but there is no real reason that it cannot be modified ... so we never added that restriction/feature ... also don't feel like every user wants that, since reading from read-only and then writing seems like a reasonable usecase


Possible to hide Windows command window (cmd) when building?

First off, your package has been working quite well. Thanks for creating it.
I'm usually a Linux person, but I have a need to create a Windows-based LaTeX report-building application using Python/GTK and Jinja2.
What I want to do is let the user pick some build options via GUI, call into your latex package to do the compile, and then present the completed PDF to the user.
At the moment, when the call is made to build_pdf(), a separate process is created to start the latexmk (using MikTeX) build, which flashes a Windows command window (cmd).
Is there any way to hide the command window during this build process?
As I'm not familar Windows coding, I'm not even sure if this is controllable from your package, or if it's a larger issue at an architectural level.
Thanks
RIch

I ended up resolving this at a meta-level, that is, via the use of a monkey-patch made to calls into subprocess.Popen(). See my post to SO for details here: https://stackoverflow.com/questions/42143939/python-subprocess-calls-into-matplotlib-on-windows

Sorry, can't help here. I'm surprised that subprocess opens up a cmd Window. I have never used subcommand on Windows myself.


Update the used module numpydb to diskcache for stamp storage

There is an implementation for a numpy array storage, that uses pickle.
This is critical so we don't keep in memory stamps of every star.
The current implementation though, requires the creation of files, which for many reasons can persist later as garbage in the local directory (see #11).
Using diskcache library could avoid such issue, and clean the base code of additional modules.

A comment on numpyDB: the code is public in two places

https://github.com/hplgit/scitools
https://github.com/esheldon/numpydb

Maybe it makes sense to make scitools a dependency, it is in PyPI and we could avoid mantaining numpyDB.

Yes, judging by the last commit (https://github.com/esheldon/numpydb/commit/5ccce22913e4b745d21c4d68fb239c365e926bee) and lack of versions in esheldon's repo, I would go with scitools copy.

+1
El mar., 13 oct. 2020 a las 12:11, Martin Beroiz<EMAIL_ADDRESS>escribió:

Yes, judging by the last commit (esheldon/numpydb@5ccce22
https://github.com/esheldon/numpydb/commit/5ccce22913e4b745d21c4d68fb239c365e926bee)
and lack of versions in esheldon's repo, I would go with scitools copy.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/toros-astro/ProperImage/issues/42#issuecomment-707808319,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACJAAWQRWEO3DMESAVBRWDSKRU2PANCNFSM4QMQBFKA
.

--
Juan B Cabral

Mey be we can check what library is more used
El mar., 13 oct. 2020 a las 12:46, Juan BC<EMAIL_ADDRESS>escribió:

+1
El mar., 13 oct. 2020 a las 12:11, Martin Beroiz (<
<EMAIL_ADDRESS>escribió:

Yes, judging by the last commit (esheldon/numpydb@5ccce22
https://github.com/esheldon/numpydb/commit/5ccce22913e4b745d21c4d68fb239c365e926bee)
and lack of versions in esheldon's repo, I would go with scitools copy.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/toros-astro/ProperImage/issues/42#issuecomment-707808319,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACJAAWQRWEO3DMESAVBRWDSKRU2PANCNFSM4QMQBFKA
.

--
Juan B Cabral

--
Juan B Cabral

Scitools is a big library and last commit is from 2016. I don't know if it supports Python > 2.6
esheldon's repo is only about NupyDB, latest commit is from 2019 and there is some extra functionality which I don't use.
However he mentions some seg fault in his latest commit.


CPU instance updated

Hey @SanchitJain123  please test it on ur local and confirm the same before merging !!

@SanchitJain123 the test works will merge the changes

ok


Error after initial connection was established, not handled

Is your feature request related to a problem? Please describe.
snippet of you code -
mongoose.connect(process.env.CONNECTION_URL, { useNewUrlParser: true, useUnifiedTopology: true })
    .then(() => app.listen(PORT, () => console.log(`Server is running on Port ${PORT}`)))
    .catch((error) => console.log(error.message))

read this pls, the error handling part -
https://mongoosejs.com/docs/connections.html#:~:text=If initial connection fails%2C Mongoose,after initial connection was established.
you have handle two errors -
if promise is rejected -> using the above code i have proposed
error after initial connection is made -> using the event handlers
Describe the solution you'd like
To handle errors after initial connection was established, you should listen for error events on the connection.

I am a participant of GSSOC21, so please let me know if this is a valid proposal

@abhay27chauhan Go Ahead!


Upload completed jobs and minor cleanup

These changes emerge from testing the lava-gitlab-runner against the gitlab-runner-mock. There are some minor renames for clarity, since some of the existing naming was quite confusing. The main addition is a simple API to upload a job that has already completed to the mock. In the case of the lava-gitlab-runner, it sources its LAVA test files from the artifacts of a prior job, so it's important to be able to upload such jobs.

@eds-collabora what's the reason for this being a draft?

This PR is draft because it depends on

@eds-collabora what's the reason for this being a draft?

I think I forgot to undraft it after I finally got a working set of changes. My mistake.


Vuex panel does not update on store.register/unregisterModule()

Version
4.1.4
Browser and OS info
Mac OSX 10.12.6 / Chrome 65.0.3325.181
Steps to reproduce
// register module
app.$store.registerModule('test', {
  namespaced: true,
  state: {
    value: 1
  },
  mutations: {
    value: (state, value) => state.value = value
  }
})

// wait, and check devtools vuex panel

// commit  mutation and see dev panel update
app.$store.commit('test/value', 100)

What is expected?
Maybe there's some reason for this, but I would expect the vuex panel to update with the new store module as the module is registered / unregistered
What is actually happening?
The vuex panel only updates when a mutation (to any module or value) is committed

Not sure if it's the same bug, but the registerModule does show the module in the console, but it's not removed when unregisterModule is called.
I have to reload the console (twice F12) to see the updated store

this is still a problem, when registering modules they don't appear in the console until you reload the frame

Duplicate of #282


docker: Error response from daemon: Unknown runtime specified nvidia.

Hello,
I am trying to run NVIDIA's l4t containers. I can pull an image and run it with
docker run --gpus all --rm -it nvcr.io/nvidia/l4t-base:r32.5.0 bash
But if I add --runtime nvidia to docker options it result in this error :
docker: Error response from daemon: Unknown runtime specified nvidia.
I am running on a Jetson Xavier NX devkit on dunfell branch and I added these layers to my local.conf :
CORE_IMAGE_EXTRA_INSTALL_append = " nvidia-docker cuda-libraries cuda-samples tensorrt cudnn libvisionworks" CORE_IMAGE_EXTRA_INSTALL_append = " nvidia-container-runtime cudnn-container-csv tensorrt-container-csv libvisionworks-container-csv" DISTRO_FEATURES_append = " ldconfig virtualization"
First thought is that I missed something while local.conf configuration but I can't find anything related in READMEs, closed/open issues or the wiki

Which dunfell branch?  The dunfell (with no version suffix) branch doesn't support Xavier NX, so it must be one of the others.  I ask because the L4T version of your built OS has to match the L4T version of the container you're trying to run.  So is it dunfell-l4t-r32.5.0 ?
Any other layers in your build besides the ones mentioned on the wiki page?
The additions you made look OK (although the -container-csv packages should get pulled in automatically without explicitly listing them). Is the docker daemon starting OK?  Can you provide its log output?

I'm on dunfell-l4t-32.4.3, therefore I just pulled nvcr.io/nvidia/l4t-tensorflow:r32.4.3-tf2.2-py3 accordingly.
I also have
PREFERRED_VERSION_python3-docker = "4.3.1"
CORE_IMAGE_EXTRA_INSTALL_append = " python3-docker"
docker log output in /var/log/message.log:
2021-04-09T09:05:57.655114+00:00 (none) root: dockerd has started.
2021-04-09T09:05:59.964011+00:00 (none) connmand[2689]: docker0 {create} index 7 type 1 <ETHER>
2021-04-09T09:05:59.964032+00:00 (none) connmand[2689]: docker0 {update} flags 4098 <DOWN>
2021-04-09T09:05:59.964045+00:00 (none) connmand[2689]: docker0 {newlink} index 7 address 02:42:3B:99:8A:65 mtu 1500
2021-04-09T09:05:59.964055+00:00 (none) connmand[2689]: docker0 {newlink} index 7 operstate 2 <DOWN>
2021-04-09T09:05:59.964361+00:00 (none) connmand[2689]: docker0 {add} address <IP_ADDRESS>/16 label docker0 family 2
2021-04-09T09:06:00.014695+00:00 (none) connmand[2689]: docker0 {update} flags 4163 <UP,RUNNING>
2021-04-09T09:06:00.014721+00:00 (none) connmand[2689]: docker0 {newlink} index 7 address 02:42:3B:99:8A:65 mtu 1500
2021-04-09T09:06:00.014733+00:00 (none) connmand[2689]: docker0 {newlink} index 7 operstate 0 <UNKNOWN>
2021-04-09T09:06:00.015240+00:00 (none) connmand[2689]: docker0 {add} route <IP_ADDRESS> gw <IP_ADDRESS> scope 253 <LINK>
2021-04-09T09:06:00.017476+00:00 (none) kernel: [   21.481832] IPv6: ADDRCONF(NETDEV_UP): docker0: link is not ready
2021-04-09T09:06:00.901990+00:00 (none) connmand[2689]: docker0 {update} flags 4099 <UP>
2021-04-09T09:06:00.902021+00:00 (none) connmand[2689]: docker0 {newlink} index 7 address 02:42:3B:99:8A:65 mtu 1500
2021-04-09T09:06:00.902033+00:00 (none) connmand[2689]: docker0 {newlink} index 7 operstate 2 <DOWN>

All that looks OK.  You mentioned the l4t-base container in your OP, though, and now you're talking about the tensorflow container. Did you get the base container to work? Are you getting the same error as before?
I usually test with the base container and the DeepStream container, using the demo-image-full image built out of our demo distro, to verify that the container support is working. If I get a chance in the next couple of days, I'll try the tensorflow container.

The following seemed to work for me on the following parameters
Board: NVIDIA Jetson Nano (Developer Kit)
Branch : dunfell-l4t-r32.4.3
Commit Hash : d5348114b0a9acd42a473aa4542a19f27f3a2a2c
Yocto Setup : . ./setup-env --machine jetson-nano-qspi-sd
NVIDIA Deepstream SDK Installed as part of the binaries under /nvidia/downloads
Command Run : docker run --gpus all -it --runtime nvidia nvcr.io/nvidia/l4t-base"r32.5.0
Results on the Jetson Nano

Thanks @arpit6232  for sharing this

Is it a layer that is installing the nvidia runtime ? I guess it's nvidia-container-runtime but I can't debug why it isn't on my system

Is it a layer that is installing the nvidia runtime ? I guess it's nvidia-container-runtime but I can't debug why it isn't on my system

It should get pulled in automatically if you install nvidia-docker in your image.

I also got a warning during build from tegra-bootfiles_32.4.3.bb
update-boot-partition.sh: file could not be found

No idea where that's coming from.  There's no reference to any update-boot-partition.sh script in any of our recipes.  Are you including other layers in your build setup?

Are you including other layers in your build setup?

Yes I'm building a system that was doing other things at first and now I try to integrate meta-tegra
I can see that for normal usage, nvidia-container-runtime adds /etc/docker/daemon.json with this inside :
{
    "runtimes": {
        "nvidia": {
            "path": "/usr/bin/nvidia-container-runtime",
            "runtimeArgs": []
        }
    }
}

I don't have this file on my system so I created it but it is deleted when I reboot, I might look into that

I don't have this file on my system

It should be added by nvida-docker I believe, see this line, so it seems something is going wrong there.

Yes I'm building a system that was doing other things at first and now I try to integrate meta-tegra

[...]

I don't have this file on my system so I created it but it is deleted when I reboot, I might look into that

Double-check the .manifest file for the image you built (which should end up in$BUILDDIR/tmp/deploy/images/${MACHINE}, with the image) to ensure that nvidia-docker, nvidia-container-runtime and anything else you tried to add to your image actually got included. If they aren't there, then perhaps something in your layers isn't using CORE_IMAGE_EXTRA_INSTALL, or is overwriting the additions you've made.

Double-check the .manifest file for the image you built to ensure that nvidia-docker, nvidia-container-runtime and anything else you tried to add to your image actually got included

> cat sdtv-image-iot-dev-jetson-xavier-nx-devkit.manifest | grep nvidia
libnvidia-container-tools aarch64 0.9.0-r1
libnvidia-egl-wayland1 aarch64 1.1.5-r0
nvidia-container-runtime aarch64 3.1.0-r0
nvidia-container-toolkit aarch64 1.0.5-r0
nvidia-docker aarch64 2.2.2-r0

That's weird, I have it.
If I manually create a daemon.json in /etc/docker with the "runtimes" as above and reload dockerd it works and docker info shows nvidia runtime. But it gets deleted when I reboot my device. Problem might come from somewhere else, I will investigate upon that


fix(package): bin path not resolving correctly

Ok, fingers crossed! 🤞😅

doing the release magic now locally now...


Add Intan conversion pipeline

Ecephys pipeline: Intan .rhs files (1 minute long per file, in total around 4 hours see #1 for further info)

[x] Add interface that concatenates recordings over time (each 1 minute long)

[x] Confirm whether they're turning on/off the system or it's just continuously splitting the data after 1 minute

[x] Collect manual curated spikes data

[ ] Add spike sorting using PhySortingInterface

[ ] Add custom interface for position

Update:
This PR was created for the ongoing data collection project, which has been pushed back to prioritise the TDT conversion (#4 and other).
With the remaining hours we are going to complete the TDT conversion, which has been approved by the lab during the mid-way meeting.


Added Dynamic Colors to the App

Old UI in Light Mode

New UI in Light Mode:

Old UI in Dark Mdoe:

New UI in Dark Mode:

The title in the app bar in dark mode is a bit to hard to read. Can you change this text to black?

I like it. Can you change the status bar to white/black as well?

Can you test this on an Android 5 emulator?

Can you test this on an Android 5 emulator?

Sure. Here u go.

Its same as the default theme of the app without Dynamic colours.

Hey @mueller-ma could u plz review the changes.

I reviewed some other apps. Usually the status bar color is the same as the app bar color.
Can you implement that?

I reviewed some other apps. Usually the status bar color is the same as the app bar color.
Can you implement that?

As of now the app bar is transperant. So do u want me to make the status bar transperant too, which means it will have the same color as the app themes....ie light or dark ?

which means it will have the same color as the app themes....ie light or dark ?

Correct. But some older Android versions don't support a light status bar. For this case you need to override the status bar color by adding a folder values-vXX where XX is the first version that supports light status bars.

which means it will have the same color as the app themes....ie light or dark ?

Correct. But some older Android versions don't support a light status bar. For this case you need to override the status bar color by adding a folder values-vXX where XX is the first version that supports light status bars.

Will surely look into it. Plz give me some time.

which means it will have the same color as the app themes....ie light or dark ?

Correct. But some older Android versions don't support a light status bar. For this case you need to override the status bar color by adding a folder values-vXX where XX is the first version that supports light status bars.

hey @mueller-ma , Can u please explain in detail again what is required. What color status bar is required ?

I changed the status bar color: https://github.com/mueller-ma/TabletopTools/pull/168/commits/0e5ef9a502772a980593835ebb0de8549c12d7bc
It's white/black depending on the app bar color. And on older devices it's always the primary color, because Android v21 doesn't support light status bars.


Revise Color

In addition to adding type annotation and improving the documentation, I want to propose the following revision of the Color class:

Convert traditional properties to @property decorators.
Add a __new__ method featuring:

the ability to pass either a tuple of int or float values (like the current version) as well as individual color values.
internal normalisation of values.

Add a __repr__ method clarifying the values for the different components.

The last point is probably best implemented by inheriting from BaseObject and utilising _reprContents.

All these are good. Go for it!

Done!

Indeed! Thanks @benkiel. The tests pass if I allow for all None values in reprContents, so I think that's the specific issue.
Simply inheriting the __repr__ from tuple, like the current class does, is not specific enough in my view. I would want the method to clearly show the values in relation to their respective components.
I'll update the code with an independent __repr__ in the same style as the other base classes.


Workarounds refers to table without providing its definition

In our SQL Workarounds page we provide a couple of queries which are all supposed to run on a table called events. However, we do not provide the definition of that table. Of course in the previous pages of the documentation the query is available as following;
CREATE TABLE events(event_id bigint,
                    event_type text,
                    event_public boolean,
                    repo_id bigint,
                    payload jsonb,
                    repo jsonb,
                    user_id bigint,
                    org jsonb,
                    created_at timestamp);

But I thought it would be better to add this query to the somewhere on top of this page so that if a user came directly to that page from google, etc. it will be easier to follow the documentation for him.

This section has gotten a lot simpler and now refers to a github_events table. We simply say:

Suppose we have a table called github_events, distributed by the column user_id. Then the following window function will not work:

Think we should still copy the definition of this table into this page? Or is it good enough to note the distribution column and leave it up to the reader's imagination?

I think it is good enough to leave it like this.


Fix quotes in partition display name based on Date, DateTime or UUID type.

Affected system.parts and system.parts_columns tables.
 I'm thinking of introducing similar changes. The original reason for quoting was to enable using values of the partition column in ALTER queries as-is. The downsides are: ugly quotes; and difficulties with casting values of the partition column to the original partition key type. Without the quotes it will be possible to cast with the usual CAST operator.

Because it's the wrong place to fix this problem. Problem with incorrect quotes is in the clickhouse-client side, the server returns correct string '2018-02-15'. Client uses serializeTextEscaped method and show that string as \'2018-02-15\'

Because it's the wrong place to fix this problem.

Well the problem exists not only on the client side. Suppose you want to query the parts according to some complicated predicate on the partition key. With proper serialization you could do CAST(partition AS <partition-key-type>) and use the partition column in any way you like. With current format this is not so straightforward.
@alexey-milovidov What do you think?

Problem with incorrect quotes is in the clickhouse-client side
Check that: https://github.com/yandex/ClickHouse/issues/1729

the server returns correct string '2018-02-15'
Here the server sends the string quotes at the begining and the end. Normally strings should not have quotes around. I don't see the reason why should it be quoted here. Or there is some?

We can use serializeText in system.parts, system.parts_columns instead of serializeTextQuoted.
We should never use serializeText to write to filesystem, zookeeper, etc. As I see, it doesn't happen.
The patch looks fine!

Check that: #1729

The reason for escaping in Pretty format is to don't break tables formatting with newlines and tabs.
We can implement more smart formatting, like this:
┌─x──────┬─y──┐
│ hello, ╲ a, ╲
│ world  │ b, ╲
│        │ c  │
│ xxx    │ yy │
└────────┴────┘

It looks like a bit overkill... bit I like the idea.

With this patch has problems with partition based on tuple(date...string):
Parts before OPTIMIZE:						Parts before OPTIMIZE:
(\'2000-01-01\', 1)	20000101-1_1_1_0		      |	(2000-01-01, 1)	20000101-1_1_1_0
(\'2000-01-01\', 1)	20000101-1_5_5_0		      |	(2000-01-01, 1)	20000101-1_5_5_0
(\'2000-01-01\', 2)	20000101-2_2_2_0		      |	(2000-01-01, 2)	20000101-2_2_2_0
(\'2000-01-02\', 1)	20000102-1_3_3_0		      |	(2000-01-02, 1)	20000102-1_3_3_0
(\'2000-01-02\', 1)	20000102-1_4_4_0		      |	(2000-01-02, 1)	20000102-1_4_4_0
Parts after OPTIMIZE:						Parts after OPTIMIZE:
(\'2000-01-01\', 1)	20000101-1_1_5_1		      |	(2000-01-01, 1)	20000101-1_1_5_1
(\'2000-01-01\', 2)	20000101-2_2_2_0		      |	(2000-01-01, 2)	20000101-2_2_2_0
(\'2000-01-02\', 1)	20000102-1_3_4_1		      |	(2000-01-02, 1)	20000102-1_3_4_1

I'll try to fix it

Yes, if the partition key is a tuple, we need to mimic the behavior of DataTypeTuple::serializeText() or just use it directly. And it uses serializeTextQuoted() for serializing the tuple elements.
Also I think it is better to use serializeTextEscaped in the exception message to avoid messing with the client terminal.


Treemap: Labels displayed in treemap not visible because of colour of blocks.

Version
4.2.1
Steps to reproduce

Execute treemap.
Check the labels in treemap block. Labels not visible because of the color of the block.

What is expected?

Labels text should visible. labels should display in color depends on treemap block color.

What is actually happening?

Labels not visible because of block color.

By default, the color of the label text is white.

If treemap block color also white or near to white, label text not visible.

For example, if we change text colour to lighter colour it will cause problem when shade is with white base and on contrast it will be a problem if colour is shade is dark and text too..

@Ovilia
any updates on this?

Not sure if I understood. How about setting a different label or block color?

@Ovilia ,
I have created one ppt for this issue. Please find the attachment
treemapBolckColorIssue.pptx
.


supabase db diff doesn't output storage buckets information.

Is your feature request related to a problem? Please describe.
The goal of course is to do supabase local development with all its features and then simply get all my database schemas and storage buckets so that i can migrate them to my remote supabase project. maybe there is a way to do this and i am just dumb but the solution i figured out was to use supabase db diff to get the database schema and go to the remote database -> sql editor and paste it all there and run it.
i don't know exactly how it's properly done. maybe you can help.

We have a storage bucket section in local dev guide https://supabase.com/docs/guides/cli/local-development#sync-storage-buckets
Let me know if this is sufficient for your use case.

To sync from local to remote, you can run supabase db diff --schema storage.

thank you sir!


Adding Azure AD Admin in US Government Cloud does not work

Hello, I have provisioned a new Managed Instance in the US Government cloud.  The PowerShell script correctly assigns the MI Service Principal to the "Directory Readers" AAD Role.  I am then able to add an account as a MI AAD Admin, which returns a successful message and displays the assigned AAD user with a green status in the portal.  However, I am unable to log in to the server with the AAD account.
Also, the portal constantly displays the message:
The portal is having issues getting an authentication token. The experience rendered may be degraded.
Additional information from the call to get a token:
Extension: sqlazureextension
Resource: graph
Details: code: 400, statusText: error, message: ajaxExtended call failed, stack:
I have raised a ticket, but there is not much progress on that ticket.  Please advise.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2d4a33b0-87d0-f60c-1b52-aeafa889e657
Version Independent ID: c281bdb7-c98c-6853-5077-41b3dd44d3a2
Content: Configure Azure Active Directory authentication - Azure SQL Database
Content Source: articles/sql-database/sql-database-aad-authentication-configure.md
Service: sql-database
Sub-service: security
GitHub Login: @GithubMirek
Microsoft Alias: mireks

@sladeedmonds We are checking this and we will get back to you.

@sladeedmonds Please share the ticket number while we check further regarding the issue.

@sladeedmonds Please share the ticket number as this has happened to other users and reasons were different. Please share your ticket number to work on it further with the team.

I sent it yesterday, here it is again:
119110724009901
Slade Edmonds
SMI

From: NavtejSaini-MSFT<EMAIL_ADDRESS>Sent: Tuesday, November 19, 2019 10:56:33 AM
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: Slade Edmonds<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-docs] Adding Azure AD Admin in US Government Cloud does not work (#42974)
@sladeedmondshttps://github.com/sladeedmonds Please share the ticket number as this has happened to other users and reasons were different. Please share your ticket number to work on it further with the team.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/azure-docs/issues/42974?email_source=notifications&email_token=AG33Q2QC67NGAFGDSC7NX7LQUQEDDA5CNFSM4JOFMJIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEOVZ4Q#issuecomment-555572466, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AG33Q2XDE7Q6B7E6IYKCCVTQUQEDDANCNFSM4JOFMJIA.

@sladeedmonds Thank you!! We are checking this.

Thanks so much. I appreciate it
Slade Edmonds
SMI

From: NavtejSaini-MSFT<EMAIL_ADDRESS>Sent: Tuesday, November 19, 2019 11:40:43 AM
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: Slade Edmonds<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-docs] Adding Azure AD Admin in US Government Cloud does not work (#42974)
@sladeedmondshttps://github.com/sladeedmonds Thank you!! We are checking this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/azure-docs/issues/42974?email_source=notifications&email_token=AG33Q2RUQK6ELYTSNWYS523QUQJIXA5CNFSM4JOFMJIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEO3NEY#issuecomment-555595411, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AG33Q2WWPSOQZYI2SA2RVHLQUQJIXANCNFSM4JOFMJIA.

@sladeedmonds You may have already received the resolution from Support team but reiterating it here:
This is a known “limitation” in Gov clouds for AAD portal.
We do not support granting read access to MI through Portal (uses Graph API). Customer needs to use PowerShell for that purpose.
Please follow the following page with instructions how to configure AAD auth on MI:
https://docs.microsoft.com/en-us/azure/sql-database/sql-database-aad-authentication-configure#provision-an-azure-active-directory-administrator-for-your-managed-instance
Hope this helps. We are closing this thread for now.

As noted in the original issue raised here in this thread, and as noted in the ticket that you requested I send you the # for, we have run the PowerShell script and it correctly adds the Service Principal for the Managed Instance in to the Directory Readers role in our tenant.  We are also able to add the AAD admin to the Managed Instance after running the script.  However, we can't log in to the Managed Instance with the AAD credential after running the PowerShell script.  Please re-open the issue.

@sladeedmonds Your ticket number<PHONE_NUMBER>09901 is still open. I would advise you to raise your concern when the support personnel gets back to you. He is working with product team for MI for getting this checked. This will be the best way forward getting the fastest resolution.

I was finally able to determine the resolution.  When logging in to a Managed Instance in the Azure Gov cloud, if you are using MFA on the AAD account, you have to manually select the Azure US Government cloud environment in Tools/Settings within SMSS.  This may seem obvious; however, note that when logging in to Single Instance in Gov, pointing SMSS to the Gov cloud isn't necessary.  If you do not have MFA enabled on the Azure AD admin account, it isn't necessary to change SMSS to the Government cloud environment. It is only an issue when using a MFA-enabled AAD account.  When I reported the resolution back to MSFT support, they acknowledged it was a "known issue" specifically with Managed Instance.


x/build: corellium iOS and Android builders are missing

From https://farmer.golang.org#pools:

host-android-arm64-corellium-android: 0/0 (3 missing)
host-darwin-arm64-corellium-ios: 0/0 (3 missing)

Their results have stopped showing up on https://build.golang.org since around Jul 17.
/cc @znly per builder owners. Are you able to take a look at this? Thanks.
/cc @cagedmantis @toothrot @andybons

These builders were added in #31722. Perhaps @znly isn't the best GitHub account to ping about this, because it's an organization.
/cc @eliasnaur @bradfitz @steeve Do you know who would be a good person to ping to look into this issue? Thank you.

All the builders were turned off at Corellium. Perhaps someone on the Go team would like access to the Corellium dashboard for when it happens in the future? I'm not actively checking the build.golang.org dashboard.

Let me know if you need to add people to the org.

Thank you for looking at this issue. I see that some of the builders are back, although it seems to be 3 out of 6 in total so far:
host-android-arm64-corellium-android: 1/1 (2 missing)
host-darwin-arm64-corellium-ios: 0/2 (1 missing)

I think it's helpful to have more clarity about the builder owner. We do keep an eye on the build dashboard regularly, so it's okay if you don't do it. As long as we're able to reach the builder owner when we spot an issue, then us not having access is okay. If this happens more often, we can can revisit this.
Please let me know if you think we should change the current builder owner entry (this line) to something that's better for the future.

Thank you for looking at this issue. I see that some of the builders are back, although it seems to be 3 out of 6 in total so far:
host-android-arm64-corellium-android: 1/1 (2 missing)
host-darwin-arm64-corellium-ios: 0/2 (1 missing)

FWIW, there are only two Android corellium hosts and two iOS corellium hosts.

I think it's helpful to have more clarity about the builder owner. We do keep an eye on the build dashboard regularly, so it's okay if you don't do it. As long as we're able to reach the builder owner when we spot an issue, then us not having access is okay. If this happens more often, we can can revisit this.
Please let us know if you think we should change the current builder owner entry (this line) to something that's better for the future.

I'd love someone on the Go team could do the resetting, which means someone should have access to the Corellium dashboard. I'm also ok doing the infrequent manual restarts.
Ideally, there should be external monitoring of Corellium and automatic restarts. Corellium is not really built for continuous integration. There's an ongoing lawsuit where Apple is trying to shut Corellium down, so motivation is low :)

FWIW, there are only two Android corellium hosts and two iOS corellium hosts.

I see. That means we can update ExpectNum accordingly.

I'd love someone on the Go team could do the resetting, which means someone should have access to the Corellium dashboard. I'm also ok doing the infrequent manual restarts.
Ideally, there should be external monitoring of Corellium and automatic restarts. Corellium is not really built for continuous integration. There's an ongoing lawsuit where Apple is trying to shut Corellium down, so motivation is low :)

Thanks for explaining.
Would you be able to send a CL adding a README https://github.com/golang/build/tree/master/env/corellium with a description of how to do the resets?
I'll close this issue since the builders are back. Thanks again.

Would you be able to send a CL adding a README https://github.com/golang/build/tree/master/env/corellium with a description of how to do the resets?

Sure: https://go-review.googlesource.com/c/build/+/249358


Error on first run

Running cobweb, I get this:
/Library/Ruby/Gems/2.0.0/gems/cobweb-1.1.0/bin/cobweb:13:in `block in <top (required)>': undefined method `banner' for main:Object (NoMethodError)
	from /Library/Ruby/Gems/2.0.0/gems/slop-4.2.1/lib/slop/options.rb:33:in `initialize'
	from /Library/Ruby/Gems/2.0.0/gems/slop-4.2.1/lib/slop.rb:23:in `new'
	from /Library/Ruby/Gems/2.0.0/gems/slop-4.2.1/lib/slop.rb:23:in `parse'
	from /Library/Ruby/Gems/2.0.0/gems/cobweb-1.1.0/bin/cobweb:12:in `<top (required)>'
	from /usr/local/bin/cobweb:23:in `load'
	from /usr/local/bin/cobweb:23:in `<main>'

I don't know what to do.

Looks like your running slop v4, try running with slop v3 ~>3.4.6, they had breaking changes going from 3 > 4.

Ok thanks!


Try to handle changes to type definitions

Fixes #26 (partially, because we can't detect all schema changes).

IRC

Re IRC: a silent failure is when something bad happens but the problem is ignored. It's not the case here, the ValueError is only masked if it can be remedied, if not we re-raise it.

I'm partway through a commit to update the documentation.

And I still haven't satisfied myself on the ways that our parse override could fail.

I'm dusting off my postgres.py dev env. I've got env's rebuilt for Python 2 and 3. Hitting an import error though ...

Imports clean up in #45.

I've got docs again locally.

I'm unraveling what the parse method is about to understand exactly what we're doing with it. I want to understand it and in particular how our implementation of it can fail, so that I can document it properly.
In the CompositeCaster constructor, parse is used as the adapter function, aka, typecaster, for new_type. It's this typecaster that is then passed to register_type underneath register_composite.

register_type ends up adding the type adapter to a dictionary that is ... somehow referenced when hydrating result sets.

>>> psycopg2._ext.string_types.keys()
[3904, 1028, 3905, 1005, 16, 17, 1042, 1043, 20, 21, 3909, 23, 25, 26, 3802, 1182, 1183, 1184, 1185, 1186, 1187, 1700, 3911, 114, 1082, 1083, 700, 701, 704, 705, 3906, 3907, 3908, 1270, 3910, 199, 3912, 3913, 1231, 3926, 3927, 1114, 1115, 3807, 1000, 1001, 1002, 1003, 18, 1006, 1007, 1009, 1266, 19, 1013, 1014, 1015, 1016, 1017, 1021, 1022]
>>> psycopg2._ext.binary_types.keys()
[]
>>>

I'm trying to find where the adapter function parse is called.

Looks like curs_get_cast dereferences the string_types dict (I'm not sure where binary_types gets looked at) and returns back to psyco_curs_cast, which is where the caster is actually called.

psyco_curs_cast ends up at Cursor.cast, but I'm not seeing where that's actually called outside of CompositeCaster.parse! Unless what we're getting is the result of curs_get_cast in pqpath? Looks likely, that's where DB-API 2.0's fetch seems to be implemented. Actually, fetch* is implemented in cursor_type.c, and pq_fetch is called under there. Okay!

So here's the call chain:

one/all (us)
fetch* (psycopg2)
pq_fetch
curs_get_cast
parse

Yeah, binary casts appear to be broken:
FIXME: what the hell am I trying to do here? This just can't work..

:-)

https://github.com/psycopg/psycopg2/pull/297 :dancer:

Relevant libpq docs:
http://www.postgresql.org/docs/9.3/static/libpq-exec.html#LIBPQ-EXEC-SELECT-INFO

Hmmm ... a little more complicated. Long story short, parse is called inside typecast_casthttps://github.com/psycopg/psycopg2/blob/5efe7131ff86ba5adf08ead91393f4910e863f1e/psycopg/typecast.c#L683.

Alright. I'm back into parse, understanding how it works.

We have a list of tokens and a list of types. We also have a list of field names.

Here are the basic ways in which a type can change underneath us:

a field can be removed
a field can be added
a field can change type

An arbitrary number of fields can be simultaneously changed in one of these four ways.

Changes to the type definition affect both reads and writes.

@Changaco Can you remind me why we need to support this? Why don't we just always restart the web app when the schema changes? Convenience?

What if we have an object with an update method and we pass data to it that gets stored in the wrong field because of schema change between when the object was created and when we updated it? Is that possible?

More tomorrow ...

I mean, now that I revisit this, it strikes me as really weird to try to expect that the Python layer can seamlessly deal with an underlying schema change.

It's not weird to expect postgres.py to keep working when the schema changes, because it's not even supposed to know what the schema is.

I've added a commit to simplify our parse method: it occurred to me that we don't need to duplicate the code of psycopg's parse method like it was suggested in https://github.com/gratipay/postgres.py/issues/26#issuecomment-26342261.

It's not weird to expect postgres.py to keep working when the schema changes, because it's not even supposed to know what the schema is.

Postgres.py itself isn't supposed to know what the schema is, but:

Model is intended to be subclassed, and the subclass probably knows what the schema is, especially if it implements update methods.
Instances of Model subclasses will have their attributes consumed by other code, which will expect a certain schema.

Any schema update is expected to result in other code changes, in the Model subclass as well as in consumers of subclass instances. If there is no code change, then what was the point of making the schema change? If there is a code change, then of course we need to restart the app.
I hate to say it, but I think we should close this PR. :-(

... though a documentation update could be in order. I can open a new PR for that.

Firstly, this PR is useful. It will reduce the downtime of the apps that uses postgres.py, because it will no longer be necessary to take them down every time a backwards-compatible change to the DB schema is made, like dropping a column that is no longer used, or adding a new column with a default.
Secondly, what this PR (partially) fixes is a bug, it don't think it needs any other justification: bugs should be fixed whenever possible.

Secondly, what this PR (partially) fixes is a bug

Is #26 a bug? The fact that we can only partially fix it seems to be due to the fundamental constraints of a networked database, suggesting that, while it's certainly a constraint, it's not a bug. Can you explain why you see #26 strictly as a bug?
Very early on (I just spent some time looking for a relevant commit, but didn't find one) I worked around something like #26 on Gittip (at the time) with a three-step deploy process:

deploy code that supports both the old and new schemas
deploy the new schema
deploy code that drops support for the old schema

I believe, given Python and Postgres, that's the only possible way to avoid downtime when we want to make a non-backwards-compatible schema change to the database.

It will reduce the downtime of the apps that use postgres.py, because it will no longer be necessary to take them down every time a backwards-compatible change to the DB schema is made

I can see the value in that. I still need to satisfy myself that supporting this use case doesn't introduce too powerful a footgun.
For the record, I'm being more conservative with this PR than I would for one on Gratipay or Aspen, because postgres.py has already achieved the status of a thoroughly-documented software product in a way that Gratipay and Aspen haven't yet. I want to change postgres.py deliberately and carefully.

Is #26 a bug? The fact that we can only partially fix it seems to be due to the fundamental constraints of a networked database, suggesting that, while it's certainly a constraint, it's not a bug. Can you explain why you see #26 strictly as a bug?

#26 is a caching bug, psycopg caches type definitions but it doesn't refresh them when they've become stale. Does it seem normal to you for a caching system to fail instead of refetching the data from upstream?
The fact that we can't fully fix this is not a "fundamental constraint of a networked database", it's just that postgresql wasn't designed to be used the way postgres.py uses it. It might be possible to modify postgresql to make the problem disappear entirely, but even if it is I don't want to wait for it.

I believe, given Python and Postgres, that's the only possible way to avoid downtime when we want to make a non-backwards-compatible schema change to the database.

You can't avoid downtime without this PR unless the changes only add or drop tables but don't modify any.

Alright, @Changaco, I'm merging this without further review, because a) I'm sure you'll want this for Liberapay, and b) I'm sure you'll quickly fix any bugs we're not seeing with it right now. :-)

Thanks, better late than never. :-)

FTR I hit a corner case that this PR couldn't fix while deploying Liberapay schema changes today. It was a type change of columns from bool to int.


Frame delay, input lag, frame lag

I captured bt OBS and slow down 25x to see separate frames.
You can see difference versus my old canvas code(right) rewritten to egui(left). As for me, there is 1~2 frames lag.
https://user-images.githubusercontent.com/707007/184391715-83ce39a4-9221-402b-aa32-f669eb2e48db.mp4
https://user-images.githubusercontent.com/707007/184388016-60cbc0fb-c8e4-4307-89da-b67c8fc4225c.mp4
commands i used:
ffmpeg -i 2.avi -bsf:v setts="TS*30" -c copy 2_30x.avi
ffmpeg -i output_25x.mp4 -vcodec libx264 -crf 28 output_25x_transcoded.mp4

There is one thing I find: event loop prioritize re-render event than input event. It look better, but I still lack of way to reproduce properly. may be later :)

Thanks for looking in to this, but I lack a few details: is this on web or native? What platform?

Web and "default" native. And "may be" bevy integration looks faster.
Its actually still too "subjective". perhaps I need proper test, with fps displaying e.g. Can we capture mouse events by unfocused window ? to lets say display few windows in row.
Sorry if its minor task. I just noticed something and may be someone want to dive deeper in future.

There is one thing I find: event loop prioritize re-render event than input event. It look better, but I still lack of way to reproduce properly. may be later :)

i have ever create proxy to send empty event to observe re-render event，and my window draw two pictures quickly in turn，when i move main windows quickly， i can see picture showing lag sometimes and re-render event lost，so i think re-render has no high priority and egui is not suitable for video showing？
but i observe 58 fps using egui-miniquad，maybe miniquad use different event loop？


SHA1 Certificates

Hi,
I'm just curious about the following statement:
"When generating the certificate thumbprint, be sure to generate a SHA1 thumbprint. SHA1 is what's used when configuring the Client and Cluster certificate thumbprints."
Given that SHA1 is considered insecure, should we not be creating SHA2 certificates? Does SF support SHA2?
Best,
Stephen

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a5258d97-54db-f748-46bc-50d3162a9bfa
Version Independent ID: bd553e49-d868-c5e5-4b8a-0e1ed6e3ff5c
Content: Secure an Azure Service Fabric cluster
Content Source: articles/service-fabric/service-fabric-cluster-security.md
Service: service-fabric
GitHub Login: @aljo-microsoft
Microsoft Alias: aljo

@MicahMcKittrick-MSFT
@aljo-microsoft
@dragav
Hi, I'm just looking to confirm that my statement above is accurate?

@Mahons SHA-256 as a certificate signature algorithm is definitely supported, irrespective of how the certificate is declared (by thumbprint or subject common name). When declaring a certificate by thumbprint, the hash is expected to be SHA-1. Hope this clarifies (and we may need to tweak our docs).

Thanks @dragav. That's cleared up my confusion.


Multiple --cache_dir s for multi-directory compilations

Building a make system (before Fake) when I process a test subdirectory I get appropriate 241 and 247 errors due to having a single --cache_dir to work with.
I checked multiple --cache_dir specs and also treating it like an include, neither work.
This should be a low priority upgrade.

This is a bit worse than I thought. I had to change my rules to $(VALIDATE) || touch $@ when calling libraries in opam. Which we really don't due except via dune looking at fstar and it does not care about it. Even though I have the checked files out there with the right times on them.

Alright this is a project limiting bug. I can't just touch the checked files as they contain data and copying them down to a single cache directory is rather difficult. I can't even get my files that are calling into an opam library to write it's checked file.
If it's not too hard, I could work this one.

As per Nik and Guido mtng today I propose that the minimal
configuration version of this is something like:
Each --include'd directory is searched for a single .cache dir.
In the fstar opam package we have .cache for .checked files and
.hints for .hint file. If we split them then they would best
be named .checked and .hints as the simplest form,
a single directory .cache.
For each ---include dir, files found in should use the .cache (or others)
directory for it or the --cache_dir. This is because to compile
within the system you use many includes. A typical Forge include
set is 6 includes and a system 15 includes. If an include directory
does not exist, a warning could be issued but it should not be a fatal
to allow different source directory structures. The language server
is currently allowing non-existant include directories without warning.
Writing is to the --cache_dir only, cached files and hints for any file
can be found in it.


Permission error while running admin commands

I have done the validator setup under the link : https://ripple.com/build/rippled-setup/#installing-rippled
When i run the admin command wallet_propose i get the below error:
{
"result" : {
"error" : "noPermission",
"error_code" : 6,
"error_message" : "You don't have permission for this command.",
"request" : {
"command" : "wallet_propose",
"passphrase" : "masterpassphrase"
},
"status" : "error"
}
}
In  the rippled.cfg file I have added my system IP for admin under [port_rpc_admin_local]
Please let me know what's the fix for this.

Is this still an issue?


feat: sign, attest and verify outputs from salsa repo

Should use cosign in goreleaser to add pub and sig for users to verify output binary

this is done.


Clarification

An example user is on the Contoso network, but is trying to access the Fabrikam instance of a shared SaaS application like Outlook online. If Contoso is a non-permitted tenant for that instance, the user sees the following page:

Shouldn't it be Fabrikam instead of Contoso in the second sentence?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 89ea5c2d-4602-25b8-3cdd-60cfb5c31895
Version Independent ID: 35d4af7e-72e4-7c40-9dd6-b8490ee73f0d
Content: Manage access to cloud apps by restricting tenants - Azure
Content Source: articles/active-directory/manage-apps/tenant-restrictions.md
Service: active-directory
GitHub Login: @barbkess
Microsoft Alias: barbkess

@dimachernov thanks for the feedback! Could you clarify why you think it should be Fabrikam? In this case Contoso represents one tenant (Tenant A) and Fabrikam represents a second tenant (Tenant B). The sentence is describing a Contoso tenant user who is trying to access a Fabrikam tenant application that has restrictions set for Contoso-tenant users.

Let me know if that clarifies.

My understanding after reading this article is that you set restrictions on what tenants users can access on reverse proxy within corporate network. In this example, the user is on the Contoso network. I am assuming it is a Contoso user and also that the Contoso tenant is configured as allowed on the reverse proxy.  This user tries to access the Fabrikam instance of Outlook (Fabrikam is not configured on the Contoso reverse proxy) and sees the page saying that you can access it.

In "If Contoso is a non-permitted tenant for that instance," the instance here is referring to the Fabrikam instance.
CC: @barbkess

Hope this helps clarify! If you have further questions feel free to tag me in the comments and I will happily continue the discussion.


JSException: Cannot read properties of null (reading 'innerHTML')

When RadzenHtmlControl is used in a way that a user clicks a button which in response programmatically sets the focus into that HtmlControl and then the user quickly triggers an action (e.g. button) which removes that HtmlControl and displays a different content a race condition causing the following JSException sporadically occurs:
blazor.server.js:1  [2023-12-01T17:02:06.169Z] Error: Microsoft.JSInterop.JSException: Cannot read properties of null (reading 'innerHTML')
TypeError: Cannot read properties of null (reading 'innerHTML')
    at Object.queryCommands (https://localhost:44395/_content/Radzen.Blazor/Radzen.Blazor.js:1402:17)
    at https://localhost:44395/_framework/blazor.server.js:1:3506
    at new Promise (<anonymous>)
    at Ft.beginInvokeJSFromDotNet (https://localhost:44395/_framework/blazor.server.js:1:3480)
    at Ft._invokeClientMethod (https://localhost:44395/_framework/blazor.server.js:1:75072)
    at Ft._processIncomingData (https://localhost:44395/_framework/blazor.server.js:1:72696)
    at Ft.connection.onreceive (https://localhost:44395/_framework/blazor.server.js:1:67009)
    at i.onmessage (https://localhost:44395/_framework/blazor.server.js:1:51322)
   at Microsoft.JSInterop.JSRuntime.InvokeAsync[TValue](Int64 targetInstanceId, String identifier, Object[] args)
   at Radzen.Blazor.RadzenHtmlEditor.UpdateCommandState()
   at Radzen.Blazor.RadzenHtmlEditor.OnFocus()
   at Microsoft.AspNetCore.Components.ComponentBase.CallStateHasChangedOnAsyncCompletion(Task task)
   at Microsoft.AspNetCore.Components.RenderTree.Renderer.GetErrorHandledTask(Task taskToHandle, ComponentState owningComponentState)

I can reliably reproduce this exception in my UI environment but unfortunately I am not able to create a simple example to reproduce it here.
This is kind of a similar exception which has already been resolved in #728 . However this exception is not covered by that solution.
The exception occurs in the following function because 'ref' is null.

To resolve this issue the input parameter 'ref' needs to be check for null. (like in #728)
E.g. when I provide this check into the code, the exception disappears:
 html: ref != null ? ref.innerHTML : null,
Pease could you provide a fix? (If you agree with the proposed code change I can provide the pull-request.)

If you believe you have found a fix feel free to submit a pull request.


Test SonarCloud 2

Delete all files and re-add them, so SonarCloud runs on a large diff.
This PR is intended for testing only, do not merge.

/azp run Steeltoe.All


typo

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] Any dependent changes have been merged and published in downstream modules
[ ] Any variable changes have been validated to be backwards compatible

@ldom Thanks for this.  Can you move this to 6.0.x branch for corrections.  We try not to update the -post branches.  This will be release with the next version of 6.0.x and 6.1.x.

@ldom Thanks for this.  Can you move this to 6.0.x branch for corrections.  We try not to update the -post branches.  This will be release with the next version of 6.0.x and 6.1.x.

No pb, done.

No pb, done.


Fix no info on no values

Added optional field in job config 'onlyInfoIfData'

If true, only adds the info metrics of resources with data.
Fixes #171

Great to see you here again <3
Lets make this default that data is shown and solve it as bug. I would prefer to not make it configurable.


Readd update_updated_at function (still used by old tables)

The _CDB_update_updated_at() function was no longer added to tables since #107, but it is attached with a trigger to old tables, causing a pg_dump and further pg_restore of a database of this kind to fail as the current version (0.10.0) does not have this function.

Could you take a look @rochoa or @rafatower? :bow: :smile:

OK from my side :+1:
I relaunched the push travis build as it failed due an inconsistent test.

:+1:


User should be able to see data source configuration after installation

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/1614
Originally created by @bencodezen on 2020-01-27 19:04:26

As we saw in a demo call, currently once a data source is installed, we can't get back into the configuration unless we delete the pipeline (which is not what we want). Proposing a MVP fix to simply re-expose the configuration when a user wants to check something.
Estimated LOE: 30 minutes

View 10 previous comments from the original issue on GitLab


Step - Beat setting below 1/8 = not working. 1/8 and above settings are working.

This is with the Step assigned to the Delay CF parameter.
Length setting does not help.
Am I doing something out of functional range? Or is this a bug?

I wonder if the smoothing on params is too slow. I can try speeding it up. Do you see same issue if mod source is lfo?

Removed the Step control from the Delay's CE parameter, and  used LFO 1 on it = did not display the issue.
Tested with the LFO in Sync & free modes = no issue. Of course Step does not offer a Sync / free mode mode choice, in that it appears to be in permanent Sync mode by default.

Can you share a preset?

Good thought... yet now I can't replicate the issue!
Perhaps it cleared when I deleted the step assignment and tested the LFO?
Have several presets with the Step assigned to the Delay CF and they now all work at any Beat selection.  :|


merge Live to main

Docs Build status updates of commit b116b09:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: CannotMergeCommit] Cannot merge commit b116b09f8981f1c2e80a5c93f552cd3d2f8b1dfe in branch live of repository https://github.com/xamarin/apple-api-docs into branch main (commit 8bb9ae1078e1fefdef9ddc16a6391301c485861b). Please follow this documentation: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ to use git.exe to resolve you content conflicts locally and then push to remote.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


update storage-limits doc with Azure disk part

update storage-limits doc with Azure disk part
@gnufied You may combine my change with https://github.com/kubernetes/website/pull/10211, thanks.
/assign @gnufied
/hold

/lgtm
/approve


Change k6 dependency to v0.45.1

A transitive dependency was removed. v0.45.0 was patched to address the issue. See grafana/k6#3252.

Thank you for the PR @mstoykov and really sorry for the response time, real work doesn't let me enough free time.
I will close the PR since the last PR from @fernandoescolar already solves this problem.


fix: update button states to secondary

Some tertiary buttons were missed out when closing https://github.com/appsmithorg/appsmith/issues/18052, not sure why. This PR updates them.
Depends on https://github.com/appsmithorg/design-system/pull/294

Issues found:

The Save/Edit Datasource button does not look like any button.

Tertiary button is being used for Snippets

/ok-to-test sha=637668d676b44872d8ae5f76f76daec4c76e0821

It looks like the Save/Edit datasource button has not been using the design-system button for a while.
Snippet button has been updated.

Snippets is now utilising the secondary button.

/ok-to-test sha=071178ea8a3a0be1e46ea4efce659df353580e2d

/ok-to-test sha=a72c033bbe017ab9e3e122bf5fe1ac7e94e6a1bb

/ok-to-test sha=a72c033bbe017ab9e3e122bf5fe1ac7e94e6a1bb

/ok-to-test sha=a72c033