Using 'craft one' and then 'craft one to inventory' crafts 2 items

When using the mouse button to preload the crafting grid with 'craft one', and then using the (not set by default) mouse button (in my case, right click) to 'craft one to inventory', two items are produced (instead of one).
Possible solution
When using 'craft to inventory', the content of the existing crafting grid should be cleared.

Is this an issue? The way "craft one" works is by incrementing, and "craft one to inventory" is just "craft one, but then take the result". I think it's a bit of an intuitive interaction but I'm not sure special casing it is the right idea.

Ok, I see the rationale and I think its use. I'll come whining again if I can't get used to it.


Enable trimming

Not currently planned as many Tyne libraries make use of reflection. Coralling this is possible, but it takes time and isn't currently needed. May be done later.


Project maintenance sprint 15

Pull Request Test Coverage Report for Build 304

2 of 2 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 93.819%

Totals

Change from base Build 299:
0.0%

Covered Lines:
1776

Relevant Lines:
1893

💛  - Coveralls


WinError 10040 when communicating with network-connected PLC

When trying to read a symbol from a PLC connected to the local network, I get the following error:
OSError: [WinError 10040] A message sent on a datagram socket was larger than the internal message buffer or some other network limit, or the buffer used to receive a datagram into was smaller than the datagram itself

I am able to read symbols just fine when the PLC is connected directly to my PC with an ethernet cable. I am on a corporate network, so this might have something to do with it?
I tried increasing the PLC response length in adsGetNetIdForPLC() (in pyads_ex.py, line 395) from 395 bytes to 500 bytes. Now it works and it seems that the received packet is 432 bytes.
Windows 10
Python 3.11.2
pyads 3.4.0
TwinCAT 3.1.4024.44

hello, could you please paste a small reproducible sample bit of code for this? I suspect this is an issue with your network if it works directly. But I can look into it.

Thank, Chris. Here is a bit of code that produces the error:
import pyads

conn = pyads.Connection(ams_net_port=10000, ip_address="<IP_ADDRESS>")

with conn:
    state = conn.read_state()
    print(state)

Hi @kristianklein
have you change the default port ? normally it's 851 (instead of 10000)
Regards,

@kryskool, port 10000 is for the system service. My TwinCAT 3 C++ task defaults to port 350, but the issue exists on both ports.

did this get resolved?


[SPARK-44971][PYTHON] StreamingQueryProgress event fromJson bug fix

What changes were proposed in this pull request?

The fromJson method for StreamingQueryProgress excepts the field batchDuration is in the dict.
That method is used internally for converting a json representation of StreamingQueryProgress into python object, commonly created in the Scala side json method of the same object.
But the batchDuration field is not there before https://github.com/apache/spark/pull/42077, which is only merged to 4.0. Therefore we add a catch there to prevent this method from failing.
Why are the changes needed?

Necessary bug fix
Does this PR introduce any user-facing change?

No
How was this patch tested?

Added unit test
Was this patch authored or co-authored using generative AI tooling?

No

Thank you, @WweiL . SPARK-44971 seems to be filed as a new feature (maybe by default value). You can switch to Bug issue type.

Hi @HyukjinKwon can we merge this : )

Merged to master and branch-3.5.

@HyukjinKwon Can we just merge this to 3.5

ah nvm I set the merge target to 3.5, should be fine

Yup, merged to 3.5.


Slider min and max  value

Hi, I'm have a problem with Slider. Why min and max  values , not possible change from code? I have two sliders on the view, and them min a max values is interrelated.

I will added it on next version. And you're welcome to make pull request to dev branch.

It's great! Thank you for the lib!

Is this feature implemented??

I am interested too. When this feature will be available ?

This feature is added to 1.1.1-SNAPSHOT version. You can change the min and max value via  setValueRange(int min, int max, boolean animation) method.

When the version 1.1.1 will be released ?


Capture region of the screen doesn't work.

I am using ubuntu. all options wokr for me except "capture region of the screen".

Please test the last version, it should be fixed.


Enhancement: Scroll wheel for offset change instead of arrow keys

it'd be a lot quicker.

Wouldn't it be less precise?

if you need to change your offset to that high an amount then something is clearly wrong with your hardware


Channel Point Highlight Redemption.

Currently when someone redeems a highlighted message it shows as a normal message, when streaming this can be a turn off for using chatterino since people's highlights don't show up.
https://i.imgur.com/cPGCK5j.png
https://i.imgur.com/hzPrRhb.png

Your wording is terrible, is this what you meant?:
When someone highlights you in a message and it happens that the message is a redeemed message, this message won't show up in /mentions or trigger the mentions pings etc?

No, the new channel points feature on twitch. When someone redeems "Highlight my message" it shows up as a highlighted message in normal twitch chat, but in chattering it shows as a completely normal message. The problem is that people spend points to highlight their messages, but the streamer can't even see they highlighted it if using chatterino.

#1455

fixed in next version


terraform validate is failing against modules/genomics_cromwell/

Describe the bug
terraform validate and plan is failing against modules/genomics_cromwell/
To Reproduce
Steps to reproduce the behavior:

Navigate to modules/genomics_cromwell/
Run terraform validate
See error

% terraform validate
╷
│ Error: Unsupported argument
│
│   on .terraform/modules/cloud-nat/main.tf line 42, in resource "google_compute_router" "router":
│   42:     keepalive_interval = var.router_keepalive_interval
│
│ An argument named "keepalive_interval" is not expected here.

Expected behavior
The terraform validation should pass for the terraform module deployment to be successful.
Desktop (please complete the following information):

OS: [MacOS]

Additional context
When I updated the version in the module "cloud-nat" in network.tf the terraform validation was successful.
module "cloud-nat" {
  source        = "terraform-google-modules/cloud-nat/google"
  version    = "~> 1.2"        <<--------------------------- ADDED VERSION
  name          = "${var.network_name}-nat"
  project_id    = local.project.project_id
  region        = local.region
  network       = module.vpc_cromwell.0.network_name
  router        = "${var.network_name}-nat-router"
  create_router = true
}

This bug is fixed via #61


Add tree visualization in Rqt

Adding a class which produces DOT code from the current BT for visualization in RQT, as discussed in #12 .
In order to test this branch you have to clone these dependencies within you catkin workspace:
git clone https://github.com/jbohren/xdot.git
git clone https://github.com/jbohren/rqt_dot.git

Then open RQT > Plugins > Visualization > DOT and use the topic /bt_dotcode. If you run a BT you have to see something similar to this:

And also you can visualize it left to right if you prefer.

The code is fully documented in order to review it easier.

Hi, Looks cool from the picture. I will test it and merge it. I will probably keep both visualizations options, in case someone doesn't want to have an additional ROS node running in the system.
Thanks
MC

Hi,
This is very cool.
I found a small issue when there are duplicates of a node (see below). But I found I way to fix them.

I will merge the branch and fix the issue.
Thank you.
Michele

This is strange because if you have multiple nodes (nodes with the same name) it should visualize them as separate nodes. In this line I check if we have the same name and I create a separate DOT object. This is the default behavior and is  given as an option on the constructor.
If you have identified the bug and you can fix it please do. Otherwise, you can push a separate branch in which your example tree exist, in order to help you with the debugging.
Cheers,
Iason

I think the problems raises here
If there are more than 2 nodes with the same name, from the "second" alias, all the names will be the same as alias += "x".
The quick fix I made is to concatenate a number (to_string) rather than "x". The number gets incremented whenever we have a new alias.

Great! This sounds a more neat solution.


[nextjs-api-dev-proxy] - allow on specific env

We should add a config opt-in to proxy for specific environment.
https://github.com/infinum/react-nuts-and-bolts/blob/1adf9ff38a520060f48c1eb9ae0fd63fc971d5ca/packages/nextjs-api-dev-proxy/src/nextjs-api-dev-proxy.ts#L38
API proposal:
export default createProxy(process.env.API_URL, {
	shouldDisableProxy: () => {
	   return process.env. NEXT_PUBLIC_NEXT_APP_ENV === 'production';
	}
});

const isDisabled = options.shouldDisableProxy ? options.shouldDisableProxy() : process.env.NODE_ENV !== 'development';
if (isDisabled) {
  return res.status(404).json({ message: 'Not found' });
};

todo:

[ ] rethink shouldDisableProxy option naming
[ ] should shouldDisableProxy be of type boolean | () => boolean
[ ] should default shouldDisableProxy value be process.env.NODE_ENV !== 'development', this will simplify isDisabled expression.

rethink shouldDisableProxy option naming

I think simple disabled will do the trick. We can add more info using JSDoc.

should shouldDisableProxy be of type boolean | () => boolean

I'm okay with that being either a boolean or a function that returns a boolean. What do you think about allowing async values as well?
boolean | () => boolean | Promise<boolean> | () => Promise<boolean>

should default shouldDisableProxy value be process.env.NODE_ENV !== 'development', this will simplify isDisabled expression.

I would still keep the current behaviour to avoid breaking changes.

What do you think about allowing async values as well?
We can add support for async fn later if we find a need for it.


feat: New Features and Improvements

New Features and Improvements 🛠

TypeScript module declarations added.
Rounded eye and SVG Logo support added.
RTL Support added. Before that, the QR code was reversed in the incorrect format and it was not detected when the language is changed to the Arabic language.
All Errors are fixed. Sometimes android was crashing due to the package dependencies.

Hope to contribute more to improve it and see these changes in the package.
Thank you from now on 🚀

How can I install this update PR changes in my pc

In lib/QRCode.js
import styled from "../../styled-components";
styled-components file is not exist
https://drive.google.com/file/d/1_wQm9FnkXvR3BQVBQgnX43ksk6N5WwnI/view?usp=sharing


Fixes NullPointerException when calling isOnline()

New issue appeared in last commit. isOnline() throws NullPointerException when player is not online.


HBTokenizer

class HBTokenizer(Tokenizer):
def _tokenize(self, text):
if not self._cased:
text = unicodedata.normalize('NFD', text)
text = ''.join([ch for ch in text if unicodedata.category(ch) != 'Mn'])
text = text.lower()
spaced = ''
for ch in text:
if ord(ch) == 0 or ord(ch) == 0xfffd or self._is_control(ch):
continue
else:
spaced += ch
tokens = []
for word in spaced.strip().split():
tokens += self._word_piece_tokenize(word)
tokens.append('[unused1]')
return tokens
请问为什么要加一个'[unused1]'呢

This is an interesting attempt. Since we utilize WordPiece for tokenization, the intuitive idea is to model the boundary of subwords. We compare the performance between w/ and w/o the special token '[unused1]', and find the former one is quite close (sometimes slightly better) to the latter one.


chore(deps): upgrade compiler dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-compiler-dependencies-k8s-29-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 4319

Questions ?
Please refer to the Backport tool documentation


Retry strategy for unsent commands

After disconnected from Redis and and reconnected again, unsent commands will be sent immediately. It would be nice to set a strategy when to resend unsent commands.
Usecase:

Multiple microservices are connected through Redis pub/sub
Redis is down for some reason for a few minutes
Redis is back up
All microservices reconnect
Microservice A sends unsent messages immeditaly after connected
Microservice B had a delay connecting to Redis and does not receive the messages

Solution:
After reconnect, wait a certain amount of time until sending unsent commands.

That seems to me like something that should be handled in application logic, not in ioredis.
Further, if you need reliable communication between two microservices then redis pub/sub is not your best option. If B is slow to restore its connection, how does A know how long it needs to wait before republishing the event?
What you probably need is reliable queue, eg with the rpoplpush command, or a purpose built broker like kafka or rabbitmq.

Further, if you need reliable communication between two microservices then redis pub/sub is not your best option. If B is slow to restore its connection, how does A know how long it needs to wait before republishing the event?

Having a simple strategy, like retryStrategy, at least we could give it a little timeout. Or do some more complex logic like check a DB.


MacOS support issue?

I maybe wrong here, but when I ran my app using macos desktop and tested it by someone callnig me in Messenger, but my audio recording did not pause... It worked in mobile android and ios tho.

audio_session wraps around the AVAudioSession API for iOS and the AudioManager API for Android. It doesn't do anything for other platforms, although if you are building a multiplatform app, audio_session will still allow you to link to audio_session for other platforms just so that it can compile, although it does nothing for those platforms.

audio_session wraps around the AVAudioSession API for iOS and the AudioManager API for Android. It doesn't do anything for other platforms, although if you are building a multiplatform app, audio_session will still allow you to link to audio_session for other platforms just so that it can compile, although it does nothing for those platforms.

so you mean it doesnt work with desktop apps?: windows & macos

It doesn't do anything on those platforms.

It doesn't do anything on those platforms.

I see, but here in pub.dev I can see that it supported it?

That means that it will compile with all of those platforms as I already explained. But you need to actually read the README page to see what the package actually does. As I have stated, the package will compile for all platforms, but it only does something for Android and iOS.


Allow creating arbitrary pages using markdown

Description
Currently, the only way (other than making a custom extension) to create a page with markdown is to put it in your _posts directory and create a post.
This is not ideal, because those pages require dates and will show up in the rss feed.

This is possible via the page extension


chore(getting started): add note about the requirement of angular/http

related https://github.com/angular/material2/issues/1574

I think this is captured now by #1579 adding http to the peer deps.


nixos/containers: add storage.conf

Motivation for this change
Same as #125206 but with defaults and a manual podman test run.
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[X] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Added a release notes entry if the change is major or breaking
[ ] Fits CONTRIBUTING.md.

@ofborg test podman

cc @NixOS/podman
@ofborg test podman-dnsname podman-tls-ghostunnel


h1,h2...h6 not returned

When I extracted articles from any page, I have noticed it don't return any heading "tag" like h1,h2...h6 value in cleaned_text.
Is that normal for everyone or I have missed anything?

This is a feature that would be indeed nice. I don't think it's part the current version of the project.


Port Kitura Request/Response tests (as many as possible) to Kitura-NIO

Kitura tests provide a better coverage, especially in catching regressions, than Kitura-net tests themselves. Some tests from Kitura could be replicated on Kitura-net.

Found two uncovered scenarios:

redirection
query parameters

Added two tests: https://github.com/IBM-Swift/Kitura-NIO/pull/165


Infinite counters

Hi,
With making some tests with only 2 Github accounts (1 for opening the PR, 1 for reviewing it), and playing with approve/request changes in the same PR, I faced these counts in workflows :

My use case is to run conditional steps depending on the current PR status (approved/changes_requested). Unfortunately, these calculated counts are not relevant nor exploitable 😢
Is it possible to increment/decrement these counts to have the real current PR status ?

Hello @julienherrero
Sorry for my late answer.
Thank you very much for your contribution.
Rgs


Make the Target symbol for fetching location

Improve UX with location

By default, the website shows the weather of our location, which is fine.
After surfing the website, when we want to check the weather of our location once again, We have to either search it, pinpoint it or reload the website. It is not the appropriate and convenient way.
In these situations, the symbol shown below comes handy. It is present in almost every website dealing with the location; we should include it.

Aye aye sir!


Update React in examples

I've faced an issue with webpack externals defintion.
To address the issue I've slightly changed how externals are merged in example's webpack.config.js.
If you agree with the approach I can go on with others examples.

Coverage remained the same at 97.439% when pulling 336d19528b0accb364e654308d8a3b1cac52db5b on ascariandrea:react16 into 974768e94d883440fc07ebdfc32a55bc46707980 on Travix-International:master.

I didn't run into any issues with it before, but here is the documentation on webpack externals function: https://webpack.js.org/configuration/externals/#function
It does make sense to me that we change the way externals are merged based on this PR. Thanks @ascariandrea!

Coverage remained the same at 97.439% when pulling 55a801206c2c2e79c33f26d06f7a9f9e1d23c3ae on ascariandrea:react16 into 974768e94d883440fc07ebdfc32a55bc46707980 on Travix-International:master.

Coverage remained the same at 97.439% when pulling f1210b80ee18a76f72c32ec41d72ea7d9cd22ae0 on ascariandrea:react16 into 974768e94d883440fc07ebdfc32a55bc46707980 on Travix-International:master.

Coverage remained the same at 97.439% when pulling b96ef731d582a3a11505677fbafe5ebe8a800b82 on ascariandrea:react16 into 974768e94d883440fc07ebdfc32a55bc46707980 on Travix-International:master.

Coverage remained the same at 97.441% when pulling 5d46183705132a3d4e01f336dff035af8d85b159 on ascariandrea:react16 into 4c7a034065e702e730078f13b2230ff25c15de3a on Travix-International:master.

Coverage remained the same at 97.441% when pulling 0a846adeeed376e0ece5bab56e37ead36fceee12 on ascariandrea:react16 into 4c7a034065e702e730078f13b2230ff25c15de3a on Travix-International:master.

I rewrote the branch history to clean it up and leaving only relevant commits.
I wasn't able to fix the kitchensink example: it requires a refactor for changes related to frint-store and rxjs imports.
I followed the migration guide but without success.
I will commit my changes in a sec, so you could help understand where the error could be.

I think this is one of the files that needed migration: https://github.com/Travix-International/frint/blob/master/examples/kitchensink/app-color/epics/color.js#L1-L11
so basically, all the methods (filter, map) need to be imported manually, and then applied using bind operator (::):
import { filter } from 'rxjs/operator/filter';
import { delay } from 'rxjs/operator/delay';
import { map } from 'rxjs/operator/map';

export default function colorEpic$(action$) {
  return action$
    ::filter(action => action.type === CHANGE_COLOR_ASYNC)
    ::delay(1000)
    ::map(action => changeColor(action.color));
}

That's what I tried to do, without success.
The return action$ then is undefined even after have changed the methods also in Root.js.

@alexmiranda, @nunorfpt, @viacheslaff: can you please help debug this issue?
(I will be back on Tuesday next week)

@ascariandrea: I tried upgrading kitchensink separately to reproduce the issue: https://github.com/Travix-International/frint/compare/examples-fix?expand=1
while doing it, I realized frint-config could do with a bit more changes, created a new PR here: https://github.com/Travix-International/frint/pull/347
Once that PR is merged and released, would be easier to test again.

The kitchensink example is fixed here: https://github.com/Travix-International/frint/compare/examples-fix?expand=1
The libraryTarget: "umd" is very important in Webpack config.
Can merge this PR once all the examples are fixed according to the diff.

Now all examples work fine, except for a minor issue in kitchensink:
the counter indicator in AppColor doesn't get updated on incrementCounter.
I tried to resolve, but I didn't find a solution cause my rxjs knowledge is so limited :/

Coverage remained the same at 97.441% when pulling b9cde1eb2b828a0e582992ed8f9cdb739a91845b on ascariandrea:react16 into b1f9dd882b61003e9b1cf7e572cb0ce32da25365 on Travix-International:master.

excuse my lack of command line skills, but you can find usage of all direct imports from rxjs, by running this command :)
$ find ./examples -iname "*.js" | grep -v -e ".spec.js" -e "/node_modules/" | xargs cat | grep "'rxjs'" | grep -v -e "window"

once the direct imports in examples are converted, should work fine.

There were 2 wrong imports, now it works like a charm @fahad19 !

@ascariandrea: well done! I will merge soon after build passes.
many thanks for taking care of this! 💖

It was a pleasure for me :)

Coverage remained the same at 97.441% when pulling 50cdbe6b74b7ffb1e6ff6b46d37b2a9a1b6ec434 on ascariandrea:react16 into b1f9dd882b61003e9b1cf7e572cb0ce32da25365 on Travix-International:master.


RangeError for large numerical ids with mongoose 6.1.4 when using lean

Sorry for creating another PR, but I've found this issue in my application using the newest version of the lib.
I'm suspecting this is a problem for mongoose 6.x.x, but only tested with 6.1.4.
The previous snippet works fine with mongoose 5.x.x. Therefore, the issue cannot be reproduced in tests without using mongoose 6.x.x.
Mongoose 5.x.x behaviour:
ObjectId.isValid(40549748900222) - true
new ObjectId(40549748900222) - works fine, no exceptions

Mongoose 6.x.x behaviour:
ObjectId.isValid(40549748900222) - true
new ObjectId(40549748900222) - throws RangeError: The value of "value" is out of range. It must be >= 0 and <=<PHONE_NUMBER>. Received 40_549_748_900_222

mongoose.isValidObjectId, however, appears to be stricter and consistently returns false for all numbers using both 5.x.x. and 6.x.x. See https://mongoosejs.com/docs/api.html#mongoose_Mongoose-isValidObjectId for more details.

Is this backwards compatible with mongoose 5?

I have test it, and working fine, thanks for the PR


Merge remote-tracking branch 'upstream/stable' into merge_stable

FYI: I just run this script - https://github.com/wilzbach/git-tools/blob/master/merge_stable


Returns wrong token id data

Hi, i configured the login example (idtoken.php) from the examples, when i login with 2 different accounts (different browsers too) almost at same time, it returns the token data of the first login user.
If i refresh the page, the user with the wrong data becomes correct.
Need help.

Thanks for creating this issue. To help me reproduce the problem you are seeing please include the example code you are using and a details list of steps to perform to consistently observe this behavior.

We're experiencing the same issue and - after hours of debugging - we've no clue on the root cause. We're still debugging and will share any information as soon as we find it.

Pracucci my workaroud was removing the redirect part. I think is related to the $Session.

Have either of you been able to verify that $_SESSION variables are leaking to other clients? What environment and versions are you running?

Seems like this issue is more or less resolved. Thanks for opening it. Please feel free add a comment and we can reopen.


Fix commonjs handling.

Just for reference for #8, this is the implementation I am currently using. Fixes #7.

@joeldenning I ask for forgiveness. Please do not consider this PR for merging. I just meant it to be another reference implementation of #8. For comparison only.

no problem, let's move discussion for this feature to #8


Incorrect Document Type Returned by RedisDocumentRepository Query

When using RedisDocumentRepository queries in my Spring Boot application with Redis OM, the repository is returning incorrect document types.
For example if I have two document classes: DocumentA and DocumentAB and using RedisDocumentRepository to query these
documents as following :
`@Document("DocumentA")
public class DocumentA {
@Indexed
private Integer fieldX;

@Indexed
private Integer fieldY;

}`
`@Document("DocumentA_B")
public class DocumentAB {
@Indexed
private Integer fieldX;

@Indexed
private Integer fieldZ;

}`
`@Repository
public interface MyRepository extends RedisDocumentRepository<DocumentA, String> {
List<DocumentA> findByFieldX(Integer value);

}`
When I use findByFieldXit returns documents of both types, even though I expect only DocumentA.
i.e.  findByFieldX returns list of DocumentA which contain data of both DocumentA and DocumentAB mapped to DocumentA ( with only fieldX)
Redis OM version: 0.8.7
Spring Boot version: 3.1.3
Redis server version:
redis_version:7.2.3
redis_git_sha1:00000000
redis_build_id:3d14d12dce76b09b
redis_mode:standalone
os:Linux 3.10.0-1160.15.2.el7.x86_64 x86_64

Can you post a small full-blown spring app to reproduce? Thanks

Can you post a small full-blown spring app to reproduce? Thanks

Attached.
test-redis-om-bug.zip

I see where the confusion lies... you have two entities Person and PersonAddress both of the are marked as @Documents. Which will create two different collections, search only works at a single collection label. That is queries/aggregations can't span different collections.
So the assumption is that any nested fields become part of the same document, so when you do:
PersonAddress address1 = new PersonAddress(1, "Address 1", "Somewhere Location1");
redisOmBugPersonRepository.save(new Person(1, "Person 1 Name", 20, address1));

That will create a single document with that just happens to have a PersonAddress document JSON at the node address and queries and aggregations on PersonAddress will only look at the embedded  doc
When you do:
PersonAddress address1 = new PersonAddress(1, "Address 1", "Somewhere Location1");
redisOmBugAddressRepository.save(address1);

That also creates a standalone PersonAddress document in its own collection.
To have two separate collections and associated them, providing a light-level of search capabilities between the two, there is an annotation to connect two collections via a field @Reference - here's an example of the use of @Reference in conjunction with @Indexed:
https://github.com/redis/redis-om-spring/blob/main/redis-om-spring/src/test/java/com/redis/om/spring/annotations/document/fixtures/City.java
@Document("city")
public class City {
  @Id
  @NonNull
  private String id;

  @Reference
  @Indexed
  @NonNull
  private State state;
}

So in the case above, there are two collections city and state the state field in the JSON for city will have a reference , that is the value of the id field for a state standalone JSON object. In terms of searching you are limited by searching for City objects given a State object (under the covers the search is done by the id field)
https://github.com/redis/redis-om-spring/blob/main/redis-om-spring/src/test/java/com/redis/om/spring/annotations/document/ReferenceTest.java
In the future I might find ways to do more complex cross-collection queries using transactions/watches but that has a lot of complications with distribution/slots.

Thanks @bsbodden , but Am I missing something here because I'm already using @Reference
and as I can see in the cache, Person collection have reference for the address.

And this is what I'm getting when calling getData
[     {         "id": "01HNJD4KQRKRR6JBZHRFV0YFW4",         "surId": 1,         "name": "Address 1",         "age": null,         "address": null     },     {         "id": "01HNJD4KYTNKJQNJPKHN9RN770",         "surId": 2,         "name": "Address 2",         "age": null,         "address": null     },     {         "id": "01HNJD4KZJJ0MM51EYDF4CKX6C",         "surId": 1,         "name": "Person 1 Name",         "age": 20,         "address": {             "id": "01HNJD4KQRKRR6JBZHRFV0YFW4",             "surId": 1,             "name": "Address 1",             "location": "Somewhere Location1"         }     },     {         "id": "01HNJD4M3ZDTR8K60YECRACMC0",         "surId": 1,         "name": "Person 2 Name",         "age": 30,         "address": {             "id": "01HNJD4KYTNKJQNJPKHN9RN770",             "surId": 2,             "name": "Address 2",             "location": "Somewhere Location2"         }     } ]

@bsbodden I think it has something to do with the documents name person and person_address.
because if I change the  @Document("person_address") to @Document("address") it works fine. so its like its doing wildcard when retrieving the data.

@justTimTim do you have some cycles to look at this potential bug? Thanks!

@justTimTim do you have some cycles to look at this potential bug? Thanks!

This is not a bug, this is a feature)
The problem is not in the library, but in the very understanding of the word "prefix". Your two entities start with the same word, and if you search for something using a shorter prefix, radish will return all possible matches. For example, if in the current case you add another entity with the prefix “p”, then it will return both addresses and persons, since they will be collapsed by the prefix “p”.
@Salman83  Just make your prefix more unique and a bit like "PersonEntity"

Perhaps the problem is that in the "@document" annotation the value should work as an alias for the index, and not add a prefix

@justTimTim do you have some cycles to look at this potential bug? Thanks!

This is not a bug, this is a feature) The problem is not in the library, but in the very understanding of the word "prefix". Your two entities start with the same word, and if you search for something using a shorter prefix, radish will return all possible matches. For example, if in the current case you add another entity with the prefix “p”, then it will return both addresses and persons, since they will be collapsed by the prefix “p”. @Salman83 Just make your prefix more unique and a bit like "PersonEntity"

Thanks,  In my opinion its not a feature in our scenario . I'm not directly searching for something here. The normal behavior or assumption is that when you specify a name for a collection its unique. who would guess that if you name document Person and another one PersonAddress  the data will be mixed on retrieval (using RedisDocumentRepository).
if it was me I would make the default behavior is searching and getting data for the exact collection name and maybe add some flag to override this behavior if needed.

@Salman83 @justTimTim is right... In Redis Search indices are scoped to a prefix for the keys that they index. The prefix in OM by default is the name of the class, or the value passed to the annotations (@Document or @RedisHash). So it's a limitation in the naming of the collections based on the underlying FT.CREATE command. So, picking a different name for the child collection is the thing to do here.

@Salman83 Thinking a bit more about this... Our auto-prefix generation relies on the : character when creating the index using FT.CREATE. So class A and class B get prefixes as A: and B: so in theory DocumentA_B and DocumentA as prefixes should contain : as a terminator. So just adding DocumentA_B: and DocumentA:  should fix your issues. You JSON or HASHES keys would look like DocumentA:12345 and DocumentA_B:54321 and there should be no collision/pollution of the indices

We can also just enforce it and add : to any user-defined prefixes

@Salman83 BTW, I just added code to enforce the : if not present in the prefix. Please test with 0.8.9 which will be release the week of March 4th


IndexError: tuple index out of range

Hi,
I installed read2tree using Bioconda. I tried running the first command for multiple species mode but I get the following error immediately:
Traceback (most recent call last):
  File "/home/ppat818/anaconda3/envs/env-read2tree/bin/read2tree", line 16, in <module>
    main(sys.argv[1:], exe_name=exe_name(), desc=desc)
  File "/home/ppat818/anaconda3/envs/env-read2tree/lib/python3.10/site-packages/read2tree/main.py", line 287, in main
    oma_output = OMAOutputParser(args)
  File "/home/ppat818/anaconda3/envs/env-read2tree/lib/python3.10/site-packages/read2tree/parser/OMAOutputParser.py", line 22, in __init__
    self.oma_output_path = self._check_oma_output_path()
  File "/home/ppat818/anaconda3/envs/env-read2tree/lib/python3.10/site-packages/read2tree/parser/OMAOutputParser.py", line 59, in _check_oma_output_path
    elif standalone_path.parts[-1] == OMA_MARKER_GENE_EXPORT:
IndexError: tuple index out of range

An mplog.log file is created but it is empty. I have updated Conda and am using the latest versions of all dependencies.
I appreciate any help :)

Hello,
I would suggest first running read2tree on the test dataset provided on github, and tell us whether you get the tree.
Could you please tell us the command line you are using to run read2tree?
Please also describe the input files and how you get the gene markers.
Best,
Sina

Closing this issue. In case the problem persists, feel free to reopen it


can not export to pdf

I try to use npx slidev export to export pdf, but it always fails on:
 ▲ rendering █████░░░░░░░░░░░░░░░░░░░░░░░░░ 1/6page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:12445/1?print", waiting until "networkidle"
============================================================
Note: use DEBUG=pw:api environment variable to capture Playwright logs.
Error
    at Object.captureStackTrace (/Users/cwh/Mission/coding/slidev/node_modules/playwrigh)
    at Connection.sendMessageToServer (/Users/cwh/Mission/coding/slidev/node_modules/pla)
    at Proxy.<anonymous> (/Users/cwh/Mission/coding/slidev/node_modules/playwright-chrom)
    at /Users/cwh/Mission/coding/slidev/node_modules/playwright-chromium/lib/client/fram5
    at Frame._wrapApiCall (/Users/cwh/Mission/coding/slidev/node_modules/playwright-chro)
    at Frame.goto (/Users/cwh/Mission/coding/slidev/node_modules/playwright-chromium/lib)
    at /Users/cwh/Mission/coding/slidev/node_modules/playwright-chromium/lib/client/page0
    at Page._attributeToPage (/Users/cwh/Mission/coding/slidev/node_modules/playwright-c)
    at Page.goto (/Users/cwh/Mission/coding/slidev/node_modules/playwright-chromium/lib/)
    at go (/Users/cwh/Mission/coding/slidev/node_modules/@slidev/cli/dist/export-WGBEP3O)
    at exportSlides (/Users/cwh/Mission/coding/slidev/node_modules/@slidev/cli/dist/expo)
    at async Object.handler (/Users/cwh/Mission/coding/slidev/node_modules/@slidev/cli/d{
  name: 'TimeoutError'

Can't reproduce, what's the content of your slides, does it do with any web requests?

I have the same error with the default install :
• yarn create slidev (don't run install dependencies & start)
• yarn install
• yarn export
cf : https://fr.sli.dev/guide/#creation-de-votre-premiere-presentation

May be caused by unreachable internet connetion, when rendering with some plugins.
I turn on a global proxy and the progressbar moves.

@ahangchen  remoteAssets: false solved the issue for me ... If you don't have any remote assets this should be fine.
How did you turn on a global proxy?

Is it possible to increase the timeout a bit?

$ slidev export --timeout 3000

You can also try to disable the remote assets downloading
---
remoteAssets: false
---

I already have the remoteAssets: false :) ... But sometimes it runs into the timeout .. so no idea why

Same problem with macOS 10.15.7, node 16.2.0, npm 7.14.0, and the latest slidevjs 0.15.0.
I have set remoteAssets false in front matter and timeout 9999999 in the cli, but still ran into timeout. It seems the command only accepts timeout 30000ms as maximum.
When I tried to run slidev build, it also ran into timeout error when trying to render after finishing building with vite.

Might due to the Twitter scripts (was 'sync' loading). Changed to async in v0.16.0, can you guys try the new version out and see if it's a fix for you? Thanks

Hi @antfu : I tried v0.16.0 out, however, the issue is not yet fixed.
=========================== logs ===========================
navigating to "http://localhost:12445/1?print", waiting until "networkidle"
============================================================
Note: use DEBUG=pw:api environment variable to capture Playwright logs.
Error
    at Object.captureStackTrace (/Users/madlogos/Documents/Projects/slidev_demo/node_modules/playwright-chromium/lib/utils/)
    at Connection.sendMessageToServer (/Users/madlogos/Documents/Projects/slidev_demo/node_modules/playwright-chromium/lib/)
    at Proxy.<anonymous> (/Users/madlogos/Documents/Projects/slidev_demo/node_modules/playwright-chromium/lib/client/channe)
    at /Users/madlogos/Documents/Projects/slidev_demo/node_modules/playwright-chromium/lib/client/frame.js:102:65
    at Frame._wrapApiCall (/Users/madlogos/Documents/Projects/slidev_demo/node_modules/playwright-chromium/lib/client/chann)
    at Frame.goto (/Users/madlogos/Documents/Projects/slidev_demo/node_modules/playwright-chromium/lib/client/frame.js:100:)
    at /Users/madlogos/Documents/Projects/slidev_demo/node_modules/playwright-chromium/lib/client/page.js:303:60
    at Page._attributeToPage (/Users/madlogos/Documents/Projects/slidev_demo/node_modules/playwright-chromium/lib/client/pa)
    at Page.goto (/Users/madlogos/Documents/Projects/slidev_demo/node_modules/playwright-chromium/lib/client/page.js:303:21)
    at go (/Users/madlogos/Documents/Projects/slidev_demo/node_modules/@slidev/cli/dist/export-R4KG3V6E.js:78:16)
    at exportSlides (/Users/madlogos/Documents/Projects/slidev_demo/node_modules/@slidev/cli/dist/export-R4KG3V6E.js:90:13)
    at async build (/Users/madlogos/Documents/Projects/slidev_demo/node_modules/@slidev/cli/dist/build-2V4QQ7IC.js:79:5)
    at async Object.handler (/Users/madlogos/Documents/Projects/slidev_demo/node_modules/@slidev/cli/dist/cli.js:133:3) {
  name: 'TimeoutError'
}

@madlogos Can you share your project?

How did you turn on a global proxy?
I have the same timeout issue, when running the build ... export to PDF works fine
@antfu Is it possible to increase the timeout a bit?

It's slow to access some foreign resources in some coutries, so a network proxy for low latency is required to meet the timeout limitation.

How did you turn on a global proxy?

I have the same timeout issue, when running the build ... export to PDF works fine

@antfu Is it possible to increase the timeout a bit?

It's slow to access some foreign resources in some coutries, so a network proxy for low latency is required to meet the timeout limitation.

Have u tried to set a higher timeout?

@madlogos Can you share your project?

I used exactly the built-in demo.
When I applied global proxy to override GFW, the build action succeeded. So it's quite clear that the blocked internet component (twitter widget.js or even something on raw.githubusercontent.com) stopped the script. Maybe consider increasing the exception tolerance to let it go?
Plus, twitter widget.js is injected into index.html by default. Maybe change it to optional (not included at all unless a Tweet widget is used)?

twitter widget.js is injected into index.html by default.

Only when you use <Tweet/> in your slides, which in this case, it's used in the starter template.

Maybe consider increasing the exception tolerance to let it go?

I don't know. I don't think it makes sense to export the slides with some images / content failed to load. But maybe we could improve the error log to show the pending resources that causes the failing.

twitter widget.js is injected into index.html by default.

Only when you use <Tweet/> in your slides, which in this case, it's used in the starter template.

So how can I remove twitter widgets.js from the slides? I removed all the  widgets from the demo slides.md, but still had https://platform.twitter.com/widgets.js in the page rendered.

twitter widget.js is injected into index.html by default.

Only when you use <Tweet/> in your slides, which in this case, it's used in the starter template.

So how can I remove twitter wjs from the slides? I removed all the  widgets from the demo slides.md, but still had https://platform.twitter.com/widgets.js in the page rendered.

navigating to "http://localhost:12445/1?print", waiting until "networkidle"
the project is not working on port 12445 after i run export,so it is impossible to export pdf

The demo deck has more in the way of remote assets than just twitter. The unsplash backgrounds, sli.dev logo images used in the animation, etc. When you view these in the browser (dev or build mode), you use your browser's normal proxy. When you try to export to PDF, it uses the headless playwright/chrome package, which doesn't. Looks to me like the export launch command (https://github.com/slidevjs/slidev/blob/main/packages/slidev/node/export.ts#L76) should be modified to take a proxy in as an option (https://playwright.dev/docs/api/class-browser/#browser-new-context) . But, not sure how sli.devs would prefer to do it... front matter option? slidev cli option?

Probably cli options if we want to have proxy

I also run into this issue and after I turned off my proxy, it still fails...

I just turn the monaco editor config to false, and everything works :)

Probably cli options if we want to have proxy config

I met the same issue as mentioned by @mariomurrent-softwaresolutions .
I found it is kindly due to no proxy when running slidev export.
So please add proxy config for slidev. Or let slidev can make use of environment various http_proxy.

let slidev can make use of environment various http_proxy.

PR welcome :)

this error occurs when playwright goto the page
https://github.com/slidevjs/slidev/blob/209dd412b151afc8b051bb57963a0198b334f980/packages/slidev/node/export.ts#L97-L99
in my case, fixed by add timeout option instead of use page.waitForTimeout
await page.goto(url, {
  timeout: timeout,
  waitUntil: 'networkidle',
})

playwright docs says

Note that page.waitForTimeout() should only be used for debugging.

@yanyongyu now you can set the timeout value for page.goto with the --timeout CLI option https://sli.dev/guide/install.html#command-line-interface-cli

LGTM

I've experienced the same, maybe can try to put the .md file and public resources under the (children) directory where the node.exe is installed.

Can reproduce on Ubuntu 22, it's totally random though. Using a short timeout is better, as retrying fixes the issue most often. So it seems that if it should fail, it will fail, and if it should not, it quickly export. Feels like a connection fails and then the export is doomed to fail whatever the timeout does.

So I have also hit this issue with a variety of presentations. I can't tell whether they are because of the high number of slides or whether it's because they use other things such as the Tweet component. Or maybe it's having local images? Either way my trouble comes about trying to load the deck in the browser AT ALL. In other words, this also happens in Chrome when I run yarn dev. I don't know if that means anything in terms of my ability to troubleshoot or reproduce the issue at all.
I also got this error when running yarn export:
  ◆ rendering...page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:12445/print?print", waiting until "networkidle"
============================================================
    at go (/Users/USER/Documents/software-checklist/node_modules/@slidev/cli/dist/export-YW4ZBY3A.js:142:16)
    at genPagePdf (/Users/USER/Documents/software-checklist/node_modules/@slidev/cli/dist/export-YW4ZBY3A.js:162:11)
    at exportSlides (/Users/USER/Documents/software-checklist/node_modules/@slidev/cli/dist/export-YW4ZBY3A.js:226:)
    at async Object.handler (/Users/USER/Documents/software-checklist/node_modules/@slidev/cli/dist/cli.js:326:14) {
  name: 'TimeoutError'
}
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Anything I can do to help debug this or test anything out?
Thanks,
+Jonathan

@yonkeltron there is a default timeout in playwright when it waits for the "networkidle" event. If you have a lot of slides it can sometimes exceed this time. In that case you can try to increase that timeout by using the --timeout CLI option: https://sli.dev/guide/install.html#slidev-export-entry

Yes that timeout issue is definitely present when trying to export or build but it also happens when I first load the presentation in the browser. When opening the presentation in Chrome, the devtools say that the initial GET for http://localhost:3030 takes exactly a minute.  Therefore, setting the --timeout option to 65000 does the trick. However every time I need to restart the server with yarn dev it is a 60-second wait for the presentation to show up in the browser tab which opens.
Anything else I can do to provide more info?

Disabling monaco for production and setting --timeout 60000 works for me!

Disabling monaco for production and setting --timeout 60000 works for me!

is also useful for me 🧓


FEAT-#6942: Enable range-partitioning impl for 'groupby().rolling()' by default

What do these changes do?
You can find perf measurements and motivation in the issue: #6942

[x] first commit message and PR title follow format outlined here

NOTE:  If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

[ ] passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
[ ] passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
[ ] signed commit with git commit -s
[ ] Resolves #6942
[ ] tests are passing
[ ] module layout described at docs/development/architecture.rst is up-to-date

Is it ready for review?

Is it ready for review?

yes, it is


[Bug] VFN can't state sync from other VFNs if it receives 3 inbound connections

🐛 Bug
VFNs connect to 3 other VFNs in order to state-sync if it loses its connection to its own validator. However it will only state sync on an outbound connection. If the VFN happens to receive 3 inbound connections from other VFNs it won't make additional outbound connections. In this case if it loses connectivity to its own validator it won't state sync.
Detected on big testnet when val0 validator was stopped to test restore. The val0 vfn stopped syncing.
Expected Behavior
VFN should be able to state sync regardless of connection directions.
System information
Please complete the following information:

3f7de435

This appears to be a duplicate of https://github.com/diem/partners/issues/874

So, a solution to this would be to make each VFN start at a different spot.  If I order all VFN peer Ids, and then choose the next 3 (wrapping), I won't have a conflict > 4.  We could just make it simply connect to less if the number of known nodes is less than or equal to the number expected to be connected to.

To clarify for the reader: the issue here is that there's a potential race condition in the way that networking and state sync interact. if a VFN has no validator to sync from and fallsback to syncing with the VFNs, it will only sync from the VFNs that it connected to (i.e., outbound). However, it's possible that a VFN will never open an outbound connection with other VFNs if they already connected to it (i.e., inbound connections for all VFNs already exist). The reason for this outbound/inbound separation is that right now networking doesn't expose information to the application layers (e.g., state sync and mempool) about whether or not a FN is a VFN or a random PFN. To avoid syncing from PFNs, VFNs therefore use outbound as a primitive means to ensure they're only syncing from other VFNs and not PFNs on the network. (As I understand it today, VFNs won't connect to PFNs outbound, only other VFNs).

@gregnazario, handling it at the networking layer is one way to deal with this. My feeling though is that it would be better if the application layers handled these things correctly. For example:

In state sync, we shouldn't really care about if a connection is outbound or inbound. Rather, state sync only cares about the type of a node that it is talking to (e.g., validator, vfn, or a pfn), so that it can prioritize which ones to talk to. If the networking code was able to tell state sync the role of the node, we wouldn't need any directional information.
Likewise, in mempool, I believe it has similar wonkiness (e.g., checking directions to ensure that it doesn't send transactions backwards or in cycles), but I'd need to confirm exactly what it's doing.

Either way, I think the application layers should be fixed to avoid relying on this information and rather be given the higher level information it really cares about.


Forge 1.18.2 crash on startup

latest.log

actually seems to happen with like every mod so probably my problem


Add license (BSD-3)

Do you need help with this issue? I can add the License if you're accepting PRs


Where is output from training?

I've ran the following training script. There doesn't seem to be an obvious errors from the logs, so I think it ran successfully - just having trouble finding the output to use for evaluation now:
Script:
#!/bin/bash
#SBATCH --job-name=train-pytorch
#SBATCH --mail-type=END,FAIL
#SBATCH<EMAIL_ADDRESS>#SBATCH --ntasks=1
#SBATCH --time=12:00:00
#SBATCH --mem=8000
#SBATCH --gres=gpu:p100:2
#SBATCH --cpus-per-task=6
#SBATCH --output=%x_%j.log
#SBATCH --error=%x_%j.err

source tensorflow/bin/activate

python main.py train \
  --style /scratch/moldach/PyTorch-Style-Transfer/experiments/images/matts-styles/birmingham.jpg \
  --dataset datasets/train2014 \
  --weights imagenet-vgg-verydeep-19.mat

I get the following logs:
.err
021-03-29 21:55:54.026157: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library libcudart.so.10.1
2021-03-29 22:03:24.188858: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library libcuda.so.1
2021-03-29 22:03:24.939154: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1716] Found device 0 with properties:
pciBusID: 0000:03:00.0 name: Tesla P100-PCIE-12GB computeCapability: 6.0
coreClock: 1.3285GHz coreCount: 56 deviceMemorySize: 11.91GiB deviceMemoryBandwidth: 511.41GiB/s
2021-03-29 22:03:24.947032: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1716] Found device 1 with properties:
pciBusID: 0000:04:00.0 name: Tesla P100-PCIE-12GB computeCapability: 6.0
coreClock: 1.3285GHz coreCount: 56 deviceMemorySize: 11.91GiB deviceMemoryBandwidth: 511.41GiB/s
2021-03-29 22:03:24.963393: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library libcudart.so.10.1
2021-03-29 22:03:25.011845: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library libcublas.so.10
2021-03-29 22:03:25.036597: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library libcufft.so.10
2021-03-29 22:03:25.051713: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library libcurand.so.10
2021-03-29 22:03:25.071691: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library libcusolver.so.10
2021-03-29 22:03:25.076390: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library libcusparse.so.10
2021-03-29 22:03:25.147072: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library libcudnn.so.7
2021-03-29 22:03:25.206992: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1858] Adding visible gpu devices: 0, 1
2021-03-29 22:03:25.438640: I tensorflow/core/platform/cpu_feature_guard.cc:142] This TensorFlow binary is optimized with oneAPI Deep Neural Network Library (oneDNN)to use the following CPU instructions in performance-critical operations:  AVX2 FMA
To enable them in other operations, rebuild TensorFlow with the appropriate compiler flags.
2021-03-29 22:03:28.342003: I tensorflow/core/platform/profile_utils/cpu_utils.cc:104] CPU Frequency:<PHONE_NUMBER> Hz
2021-03-29 22:03:28.588715: I tensorflow/compiler/xla/service/service.cc:168] XLA service 0x59faef0 initialized for platform Host (this does not guarantee that XLA will be used). Devices:
2021-03-29 22:03:28.588828: I tensorflow/compiler/xla/service/service.cc:176]   StreamExecutor device (0): Host, Default Version
2021-03-29 22:03:29.246878: I tensorflow/compiler/xla/service/service.cc:168] XLA service 0x5a880d0 initialized for platform CUDA (this does not guarantee that XLA will be used). Devices:
2021-03-29 22:03:29.246987: I tensorflow/compiler/xla/service/service.cc:176]   StreamExecutor device (0): Tesla P100-PCIE-12GB, Compute Capability 6.0
2021-03-29 22:03:29.247029: I tensorflow/compiler/xla/service/service.cc:176]   StreamExecutor device (1): Tesla P100-PCIE-12GB, Compute Capability 6.0
2021-03-29 22:03:29.382411: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1716] Found device 0 with properties:
pciBusID: 0000:03:00.0 name: Tesla P100-PCIE-12GB computeCapability: 6.0
coreClock: 1.3285GHz coreCount: 56 deviceMemorySize: 11.91GiB deviceMemoryBandwidth: 511.41GiB/s
2021-03-29 22:03:29.384001: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1716] Found device 1 with properties:
pciBusID: 0000:04:00.0 name: Tesla P100-PCIE-12GB computeCapability: 6.0
coreClock: 1.3285GHz coreCount: 56 deviceMemorySize: 11.91GiB deviceMemoryBandwidth: 511.41GiB/s
2021-03-29 22:03:29.384077: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library libcudart.so.10.1
2021-03-29 22:03:29.384136: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library libcublas.so.10
2021-03-29 22:03:29.384225: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library libcufft.so.10
2021-03-29 22:03:29.384278: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library libcurand.so.10
2021-03-29 22:03:29.384323: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library libcusolver.so.10
2021-03-29 22:03:29.384367: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library libcusparse.so.10
2021-03-29 22:03:29.384412: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library libcudnn.so.7
2021-03-29 22:03:29.390742: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1858] Adding visible gpu devices: 0, 1
2021-03-29 22:03:29.390834: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library libcudart.so.10.1
2021-03-29 22:03:33.204879: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1257] Device interconnect StreamExecutor with strength 1 edge matrix:
2021-03-29 22:03:33.204990: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1263]      0 1
2021-03-29 22:03:33.205025: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1276] 0:   N Y
2021-03-29 22:03:33.205043: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1276] 1:   Y N
2021-03-29 22:03:33.361079: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1402] Created TensorFlow device (/job:localhost/replica:0/task:0/device:GPU:0 with 11121 MB memory) -> physical GPU (device: 0, name: Tesla P100-PCIE-12GB, pci bus id: 0000:03:00.0, compute capability: 6.0)
2021-03-29 22:03:33.424735: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1402] Created TensorFlow device (/job:localhost/replica:0/task:0/device:GPU:1 with 11121 MB memory) -> physical GPU (device: 1, name: Tesla P100-PCIE-12GB, pci bus id: 0000:04:00.0, compute capability: 6.0)
2021-03-29 22:03:47.740068: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library libcudnn.so.7
2021-03-29 22:03:48.882829: W tensorflow/stream_executor/gpu/asm_compiler.cc:81] Running ptxas --version returned 256
2021-03-29 22:03:49.009004: W tensorflow/stream_executor/gpu/redzone_allocator.cc:314] Internal: ptxas exited with non-zero error code 256, output:
Relying on driver to perform ptx compilation.
Modify $PATH to customize ptxas location.
This message will be only logged once.
2021-03-29 22:03:50.058719: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library libcublas.so.10
2021-03-29 22:17:30.953810: I tensorflow/core/kernels/data/shuffle_dataset_op.cc:172] Filling up shuffle buffer (this may take a while): 158 of 1024
2021-03-29 22:17:41.277361: I tensorflow/core/kernels/data/shuffle_dataset_op.cc:172] Filling up shuffle buffer (this may take a while): 333 of 1024
2021-03-29 22:17:51.193145: I tensorflow/core/kernels/data/shuffle_dataset_op.cc:172] Filling up shuffle buffer (this may take a while): 528 of 1024
2021-03-29 22:18:01.484417: I tensorflow/core/kernels/data/shuffle_dataset_op.cc:172] Filling up shuffle buffer (this may take a while): 661 of 1024
2021-03-29 22:18:11.074078: I tensorflow/core/kernels/data/shuffle_dataset_op.cc:172] Filling up shuffle buffer (this may take a while): 859 of 1024
2021-03-29 22:18:20.985531: I tensorflow/core/kernels/data/shuffle_dataset_op.cc:221] Shuffle buffer filled.
2021-03-29 23:59:09.658659: I tensorflow/core/kernels/data/shuffle_dataset_op.cc:172] Filling up shuffle buffer (this may take a while): 251 of 1024
2021-03-29 23:59:19.551394: I tensorflow/core/kernels/data/shuffle_dataset_op.cc:172] Filling up shuffle buffer (this may take a while): 563 of 1024
2021-03-29 23:59:29.764089: I tensorflow/core/kernels/data/shuffle_dataset_op.cc:172] Filling up shuffle buffer (this may take a while): 806 of 1024
2021-03-29 23:59:39.467575: I tensorflow/core/kernels/data/shuffle_dataset_op.cc:172] Filling up shuffle buffer (this may take a while): 1011 of 1024
2021-03-29 23:59:40.309649: I tensorflow/core/kernels/data/shuffle_dataset_op.cc:221] Shuffle buffer filled.

.log
Epoch 0
=====================================
            Weights saved!
=====================================

=====================================
            Weights saved!
=====================================

=====================================
            Weights saved!
=====================================

=====================================
            Weights saved!
=====================================

=====================================
            Weights saved!
=====================================

=====================================
            Weights saved!
=====================================

=====================================
            Weights saved!
=====================================

=====================================
            Weights saved!
=====================================

=====================================
            Weights saved!
=====================================

=====================================
            Weights saved!
=====================================

=====================================
            Weights saved!
=====================================

=====================================
            Weights saved!
=====================================

=====================================
            Weights saved!
=====================================

Epoch 1
=====================================
            Weights saved!
=====================================

=====================================
            Weights saved!
=====================================

=====================================
            Weights saved!
=====================================

=====================================
            Weights saved!
=====================================

=====================================
            Weights saved!
=====================================

=====================================
            Weights saved!
=====================================

=====================================
            Weights saved!
=====================================

=====================================
            Weights saved!
=====================================

=====================================
            Weights saved!
=====================================

=====================================
            Weights saved!
=====================================

=====================================
            Weights saved!
=====================================

=====================================
            Weights saved!
=====================================

Total time: 12052.2
=====================================
             All saved!
=====================================

Hi @moldach , you can use the following command to transfer a content image
python main.py evaluate --content ./path/to/content/image.jpg   \
                        --weights ./path/to/weights \
                        --result ./path/to/save/results/image.jpg

From the above example, you provided it's not clear how I'm transferring my style to a content image.
I can see the --content param where I can provide either a .mp4/.jpg but it's not clear where
In the README it says:
Models for evaluation are located here https://drive.google.com/drive/folders/1-ywa__KcK4uEEYOzgfeRCpCzP3RJKBwL
Example usage:
python main.py evaluate    \
  --weights ./path/to/weights \
  --content ./path/to/content/image.jpg(video.mp4) \
  --result ./path/to/save/results/image.jpg

It's not clear to me if you are using weights & models interchangeably?
What am I supposed to put in the --weights param?
Just to be 100% clear I do not want to use your models (e.g. wave - I would like to train a new model based on an image of my choice.
That's why I thought you need to Use main.py to train a new style transfer network?
python main.py train    \
  --style ./path/to/style/image.jpg \
  --dataset ./path/to/dataset \
  --weights ./path/to/weights \
  --batch 2

Is the --weights here actually the model output? And I should not be providing the pre-trained checkpoint imagenet-vgg-verydeep-19.mat?
Your help is much appreciated :)

Once you have trained the model based on your style image, you will get a new model named imagenet-vgg-verydeep-19.mat for your case.
If you want to stylize the content image, you just need to put the path of that model in the --weights parameter.

I have the same question, i want to train a custom model and i dont see any output.
In you available models for download i see the checkpoints, etc but when i train not. You say you will get a new mat file...
python3 ./FastStyle/main.py train --style ./source/art.jpg --dataset ./dataset/train2014 --weights ./weights/ --batch 2
but i get no mat output or checkpoints or any error, just msg on screen and one at the end that says All saved!
what im doing wrong¿
Thanks

I think i found the issue, i read somewhere in the docs that path is also used as name for checkpoints!!! so if you add a path it can not be used for a name.... so i dont understand how can you add a path and a name.
Anyway just saying --weights points or whatever will create the checkpoints correctly

python main.py train
--style /scratch/moldach/PyTorch-Style-Transfer/experiments/images/matts-styles/birmingham.jpg
--dataset datasets/train2014
--weights imagenet-vgg-verydeep-19.mat

But that imagenet-vgg-verydeep-19.mat should not be in there or anywhere in this project , weights should be a empty folder where will be saved the train progres so can be used later , i don't see nowhere matlab is needed on this project so that .mat file is useless ...

I think i found the issue, i read somewhere in the docs that path is also used as name for checkpoints!!! so if you add a path it can not be used for a name.... so i dont understand how can you add a path and a name.
Anyway just saying --weights points or whatever will create the checkpoints correctly

--weights in training is used to save checkpoints , in evaluate to read them , so in training should be a empty folder in evaluate should have the "pretrained models" content in it .
If you don't want to save in something like --weights ./weights/1 should be --weights ./weights without slash .


Fixed secret key visible in modify ak/sk modal

What type of PR is this?
/kind bug fix
What this PR does / why we need it:
This PR fixes the issue of secret key visible when modifying the Ak/Sk of a cloud backend from home page.
Which issue(s) this PR fixes:
Fixes #405
Test Report Added?:
/kind TESTED

Test Report:

Special notes for your reviewer:

Thanks for the PR


Add AudioRenderCapacity functionality

Fixes #218

Hey, this looks really nice, I will have a closer look tomorrow morning!

I'm just a bit concerned with the singleton thing, but except that issue, that's a really nice and interesting work!

Interesting point about the singleton. I may have misunderstood the spec.
The AudioContext.renderCapacity value is indeed an attribute, not a function, so it would not make sense to return different instances per call.
This does make me wonder what happens if you call start multiple times, does it just take the latest value of the update interval? I will check that out in the browser implementations

Looks all good to me!


Prod build error on loading @angular/core.js

Upon building the production version gulp build.prod an error is caused in the build.bundles.app task which stops the build.
[14:01:36] Starting 'build.bundles.app'...
Unhandled rejection Error on fetch for @angular/core.js at file:///C:/Dev/angula
<EMAIL_ADDRESS>Loading dist/tmp/main.js
Error: ENOENT: no such file or directory, open 'C:\Dev\angular2-seed\nod
<EMAIL_ADDRESS>at Error (native)

Try running: npm run build.prod

Also you may need to:
rm -rf node_modules typings
git pull
npm install
npm run build.prod

Thanks Nathan, however the same error results.
I'm using Node v6.1.0, NPM v3.8.8 on Windows 7.

This may be a specific version issue with Windows. @d3viant0ne Do you happen to have a Windows setup to help test this out?

I also encountered the same problem
Unhandled rejection Error on fetch for @angular/core.js at<EMAIL_ADDRESS>        Loading dist/tmp/main.js
        Error: ENOENT: no such file or directory, open<EMAIL_ADDRESS>    at Error (native)

I am also facing the same issue with the prod build.
The error i get is as below:
Unhandled rejection Error on fetch for @angular/core.js at<EMAIL_ADDRESS>        Loading dist/tmp/main.js
        Error: ENOENT: no such file or directory, open<EMAIL_ADDRESS>    at Error (native)

report

Also receiving the prob build error. Receiving the same error as mentioned by @kambojankit and @Shyam-Chen.

I will fix this tomorrow. Most likely wrong system builder config.

Thanks mgechev. In my case: Windows 10, Node v6.0.0, npm 3.8.6

@mgechev I was able to test the fix out with VirtualBox... You were right, system builder config just needed packages. Went ahead and cleared everyone here.

facing same issue


RMarkdown integration

Hi,
Very useful tool, thanks. Just a short question. Is it possible to edit R chunks from Rmarkdown / Swave files as markdown code blocks?. The syntax is slightly different, for example:
```{r, echo=FALSE}
Some R code
```
When I type <Leader>e  over the chunk above I've got just the current line written in the tmp file, instead of the entire chunk. Besides, the tmp file is parsed as markdown file, instead of R file.
Thanks in advance.
Diego.

@diegodiazd now it should work 😄

Thanks @gabrielelana :). R blocks from Rmarkdown/Sweave work perfectly. Just a little detail although. In regular markdown blocks, the syntax is not loaded in the tmp file. For instance:
```python
print "hello world"
```
is opened as a regular markdown, not as a python file.

@diegodiazd Thanks!  It's a regression, I don't have automatic tests for this feature (too complex), fixed with 21fbfe1bb1a182f88146f76a426b17a976be96b2

Thanks @gabrielelana ;)


Corrected the grammar and altered the font size of the div

Why are you not following contribution guidelines?? Your pr may be discarded!

Why are you not following contribution guidelines?? Your pr may be discarded!

I am sorry for the mishap. I will create a new PR without package.json and package.lock.json .Also I have removed my api keys from the project. Please tell if anything else is required.


BREAKING-CHANGE(web-twig): Remove isUnderlined Link deprecation

Description
Additional context
Some changes were also needed in the Breadcrumbs component, which was using the Link component.
Issue reference
Remove isUnderlined prop from Link

coverage: 79.5% (+0.7%) from 78.782%
when pulling d40d064ec4c955e1389861cbffc1d238063fabc4 on BC/ds-1509-remove-underline-on-link
into 852b0e666e5248322e6fcd9bbc84759e24d38aca on integration/BC-v3-design-tokens.


Migrations going wrong

EdgeDB Version 1.0-alpha.5+g83a2a4fac.d20200826
OS Version: Docker image a1594eed87be

Steps to Reproduce:

Walk through tutorial

Then make this create, populate, commit this migration:
START MIGRATION TO { module default { type Movie { property month -> int64; } } };

query via graphql
{ Movie { month } }

get result with data belonging to another field from tutorial

{
  "data": {
    "Movie": [
      {
        "month": 2017
      },
      {
        "month": null
      }
    ]
  }
}

Recreate, populate, commit migration from tutorial

START MIGRATION TO {
    module default {
         type Movie {
             required property title -> str;
             # the year of release
             property year -> int64;
             required link director -> Person;
             multi link actors -> Person;
        }
         type Person {
            required property first_name -> str;
           required property last_name -> str;
         }
     }
 };

get error

Error: ERROR: InternalServerError: unhandled error while calling interpret_backend_error()
  Hint: This is most likely a bug in EdgeDB. Please consider opening an issue ticket at https://github.com/edgedb/edgedb/issues/new?template=bug_report.md
  Server traceback:
      RuntimeError: unhandled error while calling interpret_backend_error()

I think the result in 4 is already weird.

At least the weirdness is explained, after looking at the populated migration. There is an explicit "ALTER PROPERTY" there. Very smart!

Looks like you've added required property to the object that already has some data. So while error message is definitely inadequate here, it would be error anyway.

So, do I understand this correct?
You cannot migrate to an object with more properties?
Or is it just that you need to use that "DDL" and not this "SDL" language to execute such migrations?

So, do I understand this correct?
You cannot migrate to an object with more properties?

You can easily migrate your type to a type with more "optional" properties. Adding a required property is tricky, because there's existing data you your DB that would lack that required property after the migration is applied.  E.g. consider
type User {
  required name: string;
}

# and you have this data in your DB:

   - User {name: 'Alice'}

If you migrate to
type User {
  required name: string;
  required email: string;
}

then the Alice object in the db would be in an invalid state, so we prohibit that.
@tailhook

Looks like you've added required property to the object that already has some data. So while error message is definitely inadequate here, it would be error anyway.

Right, this has to be fixed. cc @elprans @msullivan
We also should add a clear strategy on how to add required properties/links.  Perhaps recommend adding a default :=  to them, or explain that the migration should be performed in two stages both in the docs and in the tutorial:

Add the property as optional.
Write EdgeQL that would populate the property for all objects.
Migrate the property to be required.

We also should add a clear strategy on how to add required properties/links.

I think the original idea was that you can type the expression to populate the data once when creating migration. But it was implemented neither in server nor in CLI I think.

Also while not mentioned here, I've got that internal server error when I were applying the migration. Until we have proper expression support we should disable (or at least warn) users of such changes at the create-migration stage.

I'll be curious to hear @elprans thoughts here

Adding a new required property to an existing object type would require the user to provide an expression with which to populate the property for the existing objects, not dissimilar to the change of type where the new type is not automatically castable.  This isn't implemented yet, but is on an immediate todo list.

would require the user to provide an expression with which to populate the property for the existing objects

This sounds great! What information could the expression use? Every piece of date in the migrated object or less or even more?

What information could the expression use? Every piece of date in the migrated object or less or even more?

Equivalent to default expressions, i.e. an arbitrary query with access to the parent object.

When using POPULATE MIGRATION, we now produce a proper error MissingRequiredError: missing value for required link 'director' of object type 'default::Movie'
When using the interactive migration flow, we will prompt for a fill expression to populate the field.

So I think we are good?

And the first weird bit, where year turns into month, can also be prevented with the interactive prompting stuff, so I think that's good now too.


Only validate BagIt fields for active profile

Resolves FCREPO-2365

@ruebot: the spec says: "A metadata element MUST consist of a label, a colon, and a value, each separated by optional whitespace."
So I think it's legal — but it would certainly be easy enough to remove the space before the colons if that looks better.

@escowles All good points, I'm not sure what to say about the map accessors. I could claim I was confused by the Jackson get(), but I think I just didn't look. So good catches on them all.
I also added 2 tests to test for not having an entire file section (ie. aptrust-info.txt) in your config. First that it is okay if the section is not required and then that it throws an Exception if the section has required fields.

👍


Fix:(SqlLab) correct setting name from DISPLAY_MAX_ROWS to DISPLAY_MAX_ROW

SUMMARY
The warning message when results are truncated references the wrong config setting: DISPLAY_MAX_ROWS (plural)
TESTING INSTRUCTIONS

Run a query that returns more than the default row limit.
The warning should display the correct config setting: DISPLAY_MAX_ROW

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

Thanks @jgillick for the fix.


BE: Fix HTTP 500 on protobuf Any type

issue link:
Fixes #650

[ ] Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make?

Fixed serialization of Protobuf messages containing Any type fields
Added TypeRegistry support in ProtobufFileSerde to properly handle Any type resolution
Added test cases to verify handling of Any type messages

Is there anything you'd like reviewers to focus on?

Implementation of TypeRegistry in the serializer method
Integration test to check this case

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

[ ] No need to
[x] Manually (please, describe, if necessary) - bug was reproduced on self made project using steps from issue 650, checked error stack trace to see what is wrong
[ ] Unit checks
[x] Integration checks
[ ] Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
[x] My changes generate no new warnings (e.g. Sonar is happy)
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged

Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)

hey team one more thing to notice! ProtobufFileSerdeTest and MessagesServiceTest tests don't work on Windows environment. error is: ' ProtoFile not found for import 'language/language.proto''
Why? Because in ProtoSchemaLoader you call
  Map<String, ProtoFile> filesByLocations = new HashMap<>();
  filesByLocations.putAll(knownTypes);
  filesByLocations.putAll(loadFilesWithLocations());

and the problem is in 'loadFilesWithLocations' and in
private Loader createFilesLoader(Map<String, ProtoFile> files) {
  return new Loader() {
    @Override
    public @NotNull ProtoFile load(@NotNull String path) {
      return Preconditions.checkNotNull(files.get(path), "ProtoFile not found for import '%s'", path);
    }

methods because in Windows paths use backslashes () but proto imports use forward slashes (/), so better would be create a ticket to normalize paths on both OS and be able to run project. I will create it and provide you a fix for it with a few additional test cases. Feel free to ask me questions

@DimaVilda yeah aware of it, been discussed here: #261. If you can fix them without altering production code, I'd be happy to accept such changes.

hey team one more thing to notice! ProtobufFileSerdeTest and MessagesServiceTest tests don't work on Windows environment. error is: ' ProtoFile not found for import 'language/language.proto''
Why? Because in ProtoSchemaLoader you call
  Map<String, ProtoFile> filesByLocations = new HashMap<>();
  filesByLocations.putAll(knownTypes);
  filesByLocations.putAll(loadFilesWithLocations());

and the problem is in 'loadFilesWithLocations' and in
private Loader createFilesLoader(Map<String, ProtoFile> files) {
  return new Loader() {
    @Override
    public @NotNull ProtoFile load(@NotNull String path) {
      return Preconditions.checkNotNull(files.get(path), "ProtoFile not found for import '%s'", path);
    }

methods because in Windows paths use backslashes () but proto imports use forward slashes (/), so better would be create a ticket to normalize paths on both OS and be able to run project. I will create it and provide you a fix for it with a few additional test cases. Feel free to ask me questions

@DimaVilda yeah aware of it, been discussed here: #261. If you can fix them without altering production code, I'd be happy to accept such changes.

@Haarolean , wdym without altering production code? There is incorrect backslashes processing in loadFilesWithLocations() so how can we fix it without touching it ? Or did I misunderstand your commet ?


22498 - lint issue with previous fix for lsblk.go

Describe the bug
error in lint and unit test from PR #1095
make lint gets the following error:
INFO [runner] linters took 24.048004155s with stages: goanalysis_metalinter: 24.039978211s
pkg/base/linuxutils/lsblk/lsblk.go:163:68: unnecessary leading newline (whitespace)

make test error:
=== RUN   TestLSBLK_SearchDrivePath_Success
--- FAIL: TestLSBLK_SearchDrivePath_Success (0.00s)
panic:
assert: mock: I don't know what to return because the method call was unexpected.
        Either do Mock.On("RunCmd").Return(...) first, or remove the RunCmd() call.
        This method was unexpected:
                RunCmd(string)
                0: "lsblk  --paths --json --bytes --fs --output NAME,TYPE,SIZE,ROTA,SERIAL,WWN,VENDOR,MODEL,REV,MOUNTPOINT,FSTYPE,PARTUUID"
        at: [executors.go:181 lsblk.go:133 lsblk.go:166 lsblk_test.go:92] [recovered]
        panic:
assert: mock: I don't know what to return because the method call was unexpected.
        Either do Mock.On("RunCmd").Return(...) first, or remove the RunCmd() call.
        This method was unexpected:
                RunCmd(string)
                0: "lsblk  --paths --json --bytes --fs --output NAME,TYPE,SIZE,ROTA,SERIAL,WWN,VENDOR,MODEL,REV,MOUNTPOINT,FSTYPE,PARTUUID"
        at: [executors.go:181 lsblk.go:133 lsblk.go:166 lsblk_test.go:92]

Environment (please complete the following information):

Hardware: [e.g. Dell PowerEdge]
OS: [e.g. Ubuntu, run printf "$(uname -srm)\n$(cat /etc/os-release)\n"]
Version: [e.g. 1.0.0]
Lint eError

To Reproduce
make lint

Expected behavior
It should build
Screenshots
look up
Additional context
Add any other context about the problem here.

PR #1098 merged


apiVersion is outdated in examples/application/job/cronjob.yaml

In the following example:  https://kubernetes.io/docs/concepts/workloads/controllers/cron-jobs/#example
The apiVersion is: batch/v1, which is not recognized by current Minikube system.  Instead the following is accepted: apiVersion: batch/v1beta1.
Regards, Fabiola

/kind bug
/language en

/retitle apiVersion is outdated in examples/application/job/cronjob.yaml

@Elevic The documentation version needs to be the same as the Kubernetes version.
You can run minikube start --kubernetes-version=latest or refer to the here https://v1-20.docs.kubernetes.io/docs/concepts/workloads/controllers/cron-jobs/

Hi @Elevic
JFI batch/v1beta1 CronJob is deprecated in v1.21+, unavailable in v1.25+
From v1.21  use batch/v1 for CronJob

/remove-kind bug
The current documentation is correct.
I will make a different suggestion in a separate issue.

Because

The current documentation is correct.

and @sftim opened a separate issue,
this issue seems good to be closed.
/close


implement write overload (upstream)

currenly we have no way of managing write response from middlewares

fixed by 9ec020d5bd3acec0940a1262033a3e59645d5455


Monitor widget shows jenkins server is down (like a warning sign) But my jenkins server is up only

I configured the Monitor widget .......And it marks Hygiea server, Localhost, Sonarqube server etc all in healthy status according to their health but it always  marks jenkins as down like a warning sign though jenkins server is up and running

@mitunmbj The monitor widgets have been verified with http endpoints but never tried on https.

@rvema But my endpoint is http://52.xx.xx.45:8080 what to bro?

@mitunmbj Do you have access to the API instance logs and do you see any relevant stacktrace?

@rvema i cant understand bro

@rvema can u say step by step

i have see my jenkins by default(i don't know if there are some config about this),the main url http://localhost:8080, redirect and in postman its return a 403 code.Is there any method let me monitor the jenkins server health, i doesn't find anything health check url in jenkins .

closing this issue as it was resolved


Remove support for nested modules

Update the parser and examples, and get rid of all the code necessary to handle this :sparkles:

I have just found that REPL is using nested modules, as it wraps everything into module __REPL {...}. We have to fix that first before removing nested modules

This is issue is temporarily blocked by #550.

Since #550 is closed, this issue is unblocked.


Slider button triggers multiple haptic feedback in companion app

Describe the bug
Sliding your finger right or left in a button slider (light entity), triggers multiple haptic feedback (vibration) in HA companion app (Android)
Expected behavior
No haptic feedback at all. Like when you click in the middle of the bar, instead of slide, to choose the brightness.
Smartphone (please complete the following information):

Device: Pixel 6a
OS: Android 14
Browser: Home Assistant Companion App
Version: 2024.1.5-full

Additional context
Just to rule out Companion App fault, I also tested with another slider (mushroom) and that does not happen.

I tought it was cool, but I guess that that feedback can be different on other smartphones. I will change that.

I considered asking if it was done on purpose 🤣. I think it might be cool in some smartphones. Personally is a bit annoying in mine, but IMHO I'd let the user choose by making it optional.
BTW: thank you for Bubble Card. It's really great!!

This is fixed in the v2 beta!
Here is the link to the full changelog:
https://github.com/Clooos/Bubble-Card/releases/tag/v2.0.0-beta.1

Your issue is different of that one, but I'm planning to change the sliders behavior, what I have in mind will make them so more convenient to use.


Async Cleanup

Setting attributed on parent objects is kinda confusing, so I think this makes the control flow a little cleaner and more robust generally.

Hi, this seems like a good idea to me. I think it could go into just a single commit - could you maybe squash them together with a single comment and re-push? It might also pass the style checker that way (not sure why it got upset). Thanks!


Improve docs

Remove note as the only text in descriptions. Example:
 /** A read-only structure representing a decoded query parameter.

        @note Both @ref params::reference and @ref params::const_reference are
        read only.

    */
    using const_reference = reference;

Remove unused javadocs. Example:
    /** <!-- @name Members -->
        <!-- @{ -->
     */

Remove unnecessary refs. Example:
 /** Assignment from initializer list

        Assigns @ref params from a list of @ref params::value_type.

        Each instance of @ref params::value_type is a view of a query <key, value> pair.

        @return Reference to this instance of @ref params

        @param init Initializer list with query parameters

     */

Describe that we do not support ranges of self-referencing strings. Example:
template<class FwdIt>
    void
    assign(FwdIt first, FwdIt last);

This text needs work:
        Each instance of @ref params::value_type is a view of a query <key, value> pair.

And this
       @return Reference to this instance of @ref params

you can just say
@return `*this`

Simplify briefs. Example:
from
    /** Assignment from initializer list

to
/** Assignment

Because the docs show the signature

Remove angle brackets from javadocs. Example:
 Each instance of @ref params::value_type is a view of a query <key, value> pair.

it can confuse the toolchain

        Assign @ref params from a range of @ref params::value_type.

        Each instance of @ref params::value_type is a view of a query <key, value> pair.

could just say "The query parameters are replaced with the specified range." But you also need to note that it offers the strong exception safety guarantee

You don't need to document template parameters which are deduced
        @tparam FwdIt Forward Iterator Type

documenting of BOOST_XXX_NO_LIB
To use Boost.URL as header-only; that is, to eliminate the requirement to link a program to a static or dynamic Boost.JSON library, place the following line in **exactly one** new or existing source file in your project.

#include <boost/json/src.hpp>

[Note]	Note
The "header-only" configuration needs BOOST_URL_NO_LIB defined when building with MSVC. This macro will instruct Boost to deactivate auto-linking on MSVC.

#define BOOST_URL_NO_LIB
#include <boost/url.hpp>

Memory for allocated strings uses the allocator specified at construction of the container.

should read
Memory for allocated strings uses the allocator specified *upon* construction of the container.

The description needs to say what kind of iterator it is, what the value type looks like, https://master.url.cpp.al/url/ref/boost__urls__params/iterator.html


Texture images are in the same folder but they are not being pulled up

Hi, sorry for the late reply. Is this still an issue? If yes, can you provide the failing model/texture? Is there any useful log output?


Query values need to be escaped

Currently when querying with an apostrophe, for example, the query fails because the apostrophe is not escaped.

Work in progress => 446ea36e8536ee9419150c04f952846a2b46185a


Fix:  Added Docker image installation option

I wasted half an hour writing my own Dockerfile before finding out the work was already done XD
Adding this note will hopefully help others avoid the same fate. Thanks for pre-building the image!

Also, does the Docker image seems outdated. Users aren't able to quickly verify their installation as per the readme using validate_install.py, which doesn't exist in the image.
Maybe have the image clone the latest version of the repo upon startup?

Thanks for the suggestion! I will merge this PR and our team will update the installation process soon.


Royal Oppression text does not render

This is an odd problem, and so far it only applies to "Royal Oppression". For some reason GDI+ measures all 182 characters of the card text, but thinks it fits on three lines and returns the incorrect height:

It's definitely a weird glitch in GDI+ to overcome. Hopefully this is the only card that will run into this problem

"Snipe Hunter" also has the same problem

Fixed as part of https://github.com/zukisoft/ronin/commit/a523f6e10bdde0430398e2613c2574d6233f4347


HTML-escape label values in hover details and legend.

@stuartnelson3

looks good, but let's take 5min to write some unit tests together tomorrow when you get in

@stuartnelson3 Some extra ones, you mean? (I'm actually still waiting on Travis to tell me whether the new ones work, since somehow the webdriver stuff hangs on me locally)

unit tests, not feature specs

Ah, ok. Yes, and it's also only testing the legend string so far, not the hover detail yet. Not sure how feasible the latter is though.

@stuartnelson3 Woot, thanks for the extra unit test. Good to merge?

:dango:


API: Group negative overall exp

As overallExperience defaults to -1, when we create a new group, it will sum everyone's overallExperience and eventually return a negative number.

why does it default to -1 in the first place? you can fix this to put "Unknown" when the frontend gets a number lower than zero.

Snapshots' exp/rank values are -1 by default (for unknown), so if there's a team of 100 and they all have -1 overallExp, the total exp becomes -100, this should be a quick fix, probs 1 line.
Math.max(0, overallExp)

#86

Fixed.


The ValidatorAttribute and the AttributedValidatorFactory

Would please kindly expand on the following statement with an example, like how to use built in service to wire the custom validators in Asp.net Core using fluentValidation 8. The documentation shows clearly how to create the PersonValidator but does not show how to wire it up with built in service in dotne core:
"The ValidatorAttribute and the AttributedValidatorFactory were typically used in MVC/WebApi projects to wire models to their validators. This is no longer recommended when usign AspNetCore as the built-in Service Provider is a better alternative. " An example is needed for that statement

System Details

FluentValidation version:
Web Framework version (eg ASP.NET Core 2.1, MVC 5, WebApi 2. Delete if not applicable):

Issue Description

AspNetCore uses the service provider to handle dependency injection. You should register your validators with the service provider and they will be automatically wired up. You can either register them explicitly, or you can auto register all validators. Details on how to do this are provided on the aspnet core page in the documentation.  Please take a look here https://fluentvalidation.net/aspnet


Cop Idea: Only xstr in description

If only xstr is passed to describe, context or it, the typo of " or ' is suspect in many cases.
Also, if only xstr is, it may not be a good description of describe or context or it. What do you think?
# bad
describe `time` do
end

# bad
context `time` do
end

# bad
it `time` do
end

Is this an issue from the real code? Why would anyone want to use that?

Is this an issue from the real code? Why would anyone want to use that?

Yes, it is. Strictly speaking I saw the it case I encountered.

If those are typos, surely let’s add a cop to fix those

I guess someone who uses JavaScript template literals a lot wrote it by mistake. I've encountered this misuse too, but since this project was a Rails app, where Kernel#` is not used very often, I decided to enforce the %x literal.
Style/CommandLiteral:
  EnforcedStyle: percent_x


Fix gcc comma at end of enumerator list warning.

Add dummy "LAST" items to each enum to mask the gcc "comma at end of enumerator list" warning and allow building with -Werror.

Trailing comma is permitted since C99

@viccpp . Very true. The FreeRTOS coreHTTP library that depends on http-parser targets C90 compilers.


quantization subclass typo

Hi,
I'm testing the inner code of quantization. For this line:
https://github.com/pytorch/ao/blob/main/torchao/quantization/subclass.py#L234
Is this a typo?
I don't see any refernce of qscales.

@YihengBrianWu indeed this looks like a typo.
would you be interested in opening a PR with the fix? If not tagging @jainapurva to put up a fix for this

@YihengBrianWu indeed this looks like a typo.
would you be interested in opening a PR with the fix? If not tagging @jainapurva to put up a fix for this

I'm glad to do this!
I open a PR: https://github.com/pytorch/ao/pull/860


option to run jenkins as an ldap created user

Hi
I was attempting to get this recipe to run with a ldap created user/group called "jenkins". This user and group already exist on the system so the user and group resources in https://github.com/opscode-cookbooks/jenkins/blob/master/recipes/_master_war.rb#L28 aren't actually necessary. The documentation for these resources say that if the user/group exists, it'll instead attempt to update it. This did not work for me.
An error would occur:
    groupmod jenkins returned 10, expected 0
    ---- Begin output of groupmod jenkins ----
    STDOUT: STDERR: groupmod: group 'jenkins' does not exist in /etc/group
    ---- End output of groupmod jenkins ----

I ended up getting around this by disabling ldap and allowing the recipe to create a local group. Once the local group was created, the recipe worked just fine, even after I reenabled ldap.
Is there a better workaround? Should this part (adding user to group) be configurable so you can turn it off in case you are using ldap to manage your groups?

On most Linux based systems, using "luseradd", "lusermod", "lgroupadd", and "lgroupmod" in the upstream user configuration tools would allow local accounts and groups to be managed, and updated locally, even if they exist in LDAP already. But that takes a rewrite of Chef's basic upstream "user" and "group" to make them available.
If you're willing, you can work around it the hard way by locally auditing for correct groups and users, and running those commands in your own recipes or resources. But it's extra work, as well.

i've created a PR, but am working my way through the checklist for actually contributing


API methods to check processing status

Sending file to ambar is an asynchronous task, so you have to poll API with the file id to check if processing is finished and to retrieve parsed text. But I find the endpoint response is "404 file not found" both for in processing files and failed ones.
Can you add a persistent status endpoint with similar information I can see in rabbit log?

@jenkin thank you for your feedback! We'll add this to our internal roadmap

Thank you very much, for now I'll use a cache to keep track of processing files and set a time interval to check failed ones.


Publish to the Microsoft Edge Web Store

Let's publish this extension to the official Microsoft Edge Webstore!

First manual publish has been completed and reviewed by Microsoft:
https://microsoftedge.microsoft.com/addons/detail/sonatype-platform-browser/eimppjecdnhdmdiohjnkbjgdeaecabmg