Certificates provided inline to Envoy linger even when replaced

Our current setup runs a control plane which has all of our certificates, and these are provided to our fleet of proxies via SDS
We just noticed an odd behavior where a tls_certificate secret was updated just yesterday, but the old certificate is still shown in the admin /certs endpoint... and this also seems to affect the metric server.days_until_first_cert_expiring
The equivalent commands I ran on the envoy node were as follows
# http GET http://localhost:9901/certs | jq '.certificates[].cert_chain[] | {days: .days_until_expiration, name: .subject_alt_names[0].dns}' | grep '<redacted common name>' --context 2
{
  "days": "28",
  "name": "<redacted common name>"
}
{
--
{
  "days": "794",
  "name": "<redacted common name>"
}

The two redacted names are identical.
Is this known/intended? I'm guessing there is no way to purge these old certificates and that I should just re-deploy the fleet.

This seems like a bug or some type of confusion. @lizan @lambdai @kyessenov any thoughts? Wondering if this is the same hashing issue that was fixed?

Yeah, this could be because of hashing. @lizan does SDS force a reload of the cert when SDS payload is identical but version is bumped?

@kyessenov No it doesn't: https://github.com/envoyproxy/envoy/issues/7676. but I don't think that is the issue mentioned here specifically.
@cetanu I guess you still have connections alive on the old certificate so it is not being purged, which is expected behavior. Is that the case?

@cetanu I guess you still have connections alive on the old certificate so it is not being purged, which is expected behavior. Is that the case?

I had not even considered this but that makes sense; unfortunately the machines have already been redeployed.
If this is the expected behavior then I think we can probably close this, but it might be something worth noting in this page under the linked header: https://www.envoyproxy.io/docs/envoy/v1.11.2/configuration/secret#examples-two-sds-server

I think we can make this better to mark the one no longer used for new connection as draining_secrets or just hide from /certs

My understanding is that filter chain manager maintains a ref count to the server ssl context, through ServerSslSocketFactory , no matter if there is connection/transportsocket is alive or not

We do observe as well that certs used by currently established connections are part of the /certs output.
What is actually worse is that it affects days_until_first_cert_expiring metric.
In setups with short-living TLS certificates and long-living connections it means that envoy is happy to report that all certs have been expired even if SDS-based cert reloading does work as expected.

I was bitten by this over the Christmas break. We have an Envoy setup with SDS and some monitoring that watches days_until_first_cert_expiring to alert us if it accidentally gets too low. Our certs actually did get automatically rotated, but the Envoy instances held onto the old certs too long, kept the days_until_first_cert_expiring metric dropping, and triggering our alert.
(Normally our CD system regularly restarts everything, including Envoy, so we didn't notice until the break when the CD was paused.)

I'm seeing this bug too, now that I've started using SDS with Istio. I use short-lived, frequently rotated certificates and worry this will result in a memory leak in Envoy.

@lizan is there a way to identify whether the context is being used by an existing connection or not in the current code? If it is not, is it some thing that can be added?
We are also hit by this with SDS and our cert expiry alerts are firing for lingering certs.

Looked at the code and it looks like we can pass the old context if available when secret is updated here https://github.com/envoyproxy/envoy/blob/master/source/extensions/transport_sockets/tls/ssl_socket.cc#L356 to createSslClientContext and can remove from the list of contexts similar to how we remove expired contexts https://github.com/envoyproxy/envoy/blob/cdd3a837056dc6935c0d8e0fb693d4de89b998e9/source/extensions/transport_sockets/tls/context_manager_impl.cc#L23. The same thing can be done for server contexts.
Does it work? Or Am I not reading the code correctly? Or any better ideas?

@ramaraochavali that's right, we use shared_ptr to track whether the SslContext is used, which is count number of active connections in.


No storage metrics for vault with raft integrated storage

Additional environment details (Operating System, Cloud provider, etc):
I'm doing my tests on GKE but I do not think it's relevant.
Steps to reproduce the issue:

Run a vault with raft storage and enable prometheus metrics format.
Query /v1/sys/metrics?format=prometheus on your vault instance.
Check the name of the storage metrics : vault_raft_storage_get, vault_raft_storage_put
Check the metrics outputted by the agent: nothing regarding raft storage.

Describe the results you received:
No data point.
Describe the results you expected:
Have some data point for vault.raft.(put/get/delete/list) metrics.
Additional information you deem important (e.g. issue happens only occasionally):
My guess is that:

Metrics for that storage backend are called raft-storage-get in vault source code. Note: etrics are prefixed with vault-.
Prometheus forbid dashes in metrics name so the metrics lib vault uses convert them to underscore source. Metrics are now named vault_raft_storage_get for instance.
Vault integration in datadog try to get vault_raft_put metrics source

I'm writing the patch to make datadog use the right metrics name in this case.

Issue is still reproducible.
I did not have time recently to improve on the PR, but I should have time to finalize it in the next weeks.

Will be closing this ticket since changes are implemented in https://github.com/DataDog/integrations-core/pull/6622.

A version of the check with the fix is being released in https://github.com/DataDog/integrations-core/pull/7777


Create an extendible plugin framework #315 #316

Addresses #315 and #316

Coverage decreased (-0.3%) to 89.619% when pulling c7f44d143efdd73d08de39969506401b275ddc30 on plugin-framework into 92605764f8eec3972c9ec4583579ad8d39bdd8c0 on master.


1.2 backports 18-09-12

Backported PRs:

#5319 (had some minor conflicts, @eloycoto please review)
#5503
#5513

I only backported commit 2c0385365cd930aba91590d3f8b36b010d3cfbeb, but not 724334bb037c93f3716602c3cdde149350b59af8 because 724334bb037c93f3716602c3cdde149350b59af8 fixed an issue in master that was not present in v1.2.

#5515 - required fixing merge conflicts, but I was the author of the PR so I am confident in it working correctly.

Not backported PRs:

#5445

Tons of merge conflicts. I do not think this needs to be backported because it fixes functionality that wasn't even added in the v1.2 branch. Replied on that PR with requested justification for need to backport.

Signed-off by: Ian Vernon<EMAIL_ADDRESS>

This change is

test-missed-k8s

Build failed due to a rogue import:
18:55:12 test/helpers/node.go:24:2: imported and not used: "time"

Fixing...

test-me-please

test-docs-please

test-missed-k8s

Hit gofmt issues... will fix up and try again.

test-me-please

test-me-please

I'm inclined to request a simplification of the backport for #5538 , we shouldn't be refactoring the CtEntry in the backport.

@joestringer sure, not a problem. I'm all for smallest-possible deltas in backports :)

@joestringer followed your recommendations.

test-me-please

Forgot to update bpf.sha, fixed and re-running tests.

test-me-please


Submit Hadoop job with luigi as the current user and not as YARN

I am running a hadoop job within the framework of luigi under the HADOOP_USER_NAME of hadoop (let's say).
However, luigi launches the task under the user name of YARN, which does not have write privilege on certain folders.
Currently I change the owner of the folder to YARN, but that is certainly not Kosher.
Any idea how I can regulate the user name on luigi?

I'm not exactly sure how this work, but it shouldn't be very hard to fix it. If you figure out how to do it, and send a pull request, I'm happy to merge it!


Feature cable car

It would be a nice feature if a cable car could be displayed on the map.
https://wiki.openstreetmap.org/wiki/Tag:aerialway%3Dcable_car

example location: https://streets.gl/#51.50361,0.01432,89.99,0.00,4153.86


When in Minimized mode you can't access settings.

Either i'm missing something or how do i exit this.

It happens by design if you have minimal mode as well as the hide channels settings enabled. When that happens you should use the keyboard shortcut ctrl+,


Merging ADJs in Validators

Merge the ADJ pool into val pool for the next evolutionary state of the network ecosystem.

The process is currently happening in rbx5.0.0


[staging-next] gnugrep: Fix build on Musl

Description of changes

https://hydra.nixos.org/build/221679820
https://github.com/NixOS/nixpkgs/pull/228714#issuecomment-1567337706

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

This should work but is a draft because I currently don't have the build capacity to test this.
I might have more capacity near the end of this week. PTAL

Fixed. I have successfully built pkgsStatic.gnugrep with this

@ofborg build pkgsStatic.gnugrep

(ofBorg got the rebuild labels wrong; most likely confused by the force-push)


[Feature]: Jest should support package browser field

🚀 Feature Proposal
I am using Jest for unit testing and I have a library which provides node and browser sources. Which sources are using is defined by the package browser field. I found that Jest use browserify resolve to load node modules. But this resolver doesn't support the browser field. I opened a feature request by browserify:
https://github.com/browserify/resolve/issues/254
But they say this feature is implemented in browser-resolve which wraps resolve and will not implemented in resolve.
Motivation
I think it would be handsome to support both resolver via parameter or something else, because some people are using frameworks like nx above jest and its not possible to change the resolver.
Example
No response
Pitch

Yes I know, thats what I am doing. But I think it is not useful. Why can jest not do something like if environment jsdom use the browser-resolve otherwise use resolve or something like else?


[spaceship] add testers to other group

Motivation and Context
Reopening of #18349 because auto closed and things go weird
Description
Reopening of #18349 because auto closed and things go weird

@joshdholtz  I see that all the tests have passed.

@googlebot I consent.


Fixed a bug when empty structureboard could be accessed via space shortcut

LGTM

Coverage decreased (-0.07%) to 82.392% when pulling 0231413b50c1dd48546b81a19e4708c24893ada5 on vxsx:bugfix/space-switching into 62b638f8157700196ef98dc6faa6462a9c3314c5 on divio:develop.


[Tormenta20 - Jogo do Ano] CSS Fix - removing display:none from element in CSS.

Submission Checklist
Required

[ x] The pull request title clearly contains the name of the sheet I am editing.
[x ] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[x ] The pull request makes changes to files in only one sub-folder.
[x ] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

Changes / Description
removing display:none from element in CSS.

Character Sheet Info Roll20 Internal Use only.


feat(styles): move component styles to style library

With the new CSS architecture we move baked-in component styles to the style library. This makes component styles optional and supports pre-processing and potential variations. This ticket we've covered a fair amount of components, but a follow ticket is needed to take care of the rest.
Closes #1907

The issue reported above are not related and will be fixed by #2014


Failing to build css_parser

Copied from #4:
@kolloch it does appear to have solved the problem for the test repo, but for my own project, https://github.com/nuxeh/url-bot-rs, there's still the following error, this time for cssparser:
Building src/lib.rs (cssparser)
Running rustc --crate-name cssparser src/lib.rs --crate-type lib -C opt-level=3 -C codegen-units=4 --edition 2015 -C metadata=15b8375349 -C extra-filename=-15b8375349 --out-dir target/lib --emit=dep-info,link -L dependency=target/deps --extern cssparser_macros=/nix/store/8yl9hhivlcpr1q485d9h9kywwlxiia91-rust_cssparser-macros-0.3.5/lib/libcssparser_macros-57e42b786a.so --extern dtoa_short=/nix/store/4v891ffdrzxa2yv547mn3dcdc7iqvak0-rust_dtoa-short-0.3.2/lib/libdtoa_short-77d68b4a44.rlib --extern itoa=/nix/store/adhj88qqyin8zf9bd10xqv1dsizv3bhr-rust_itoa-0.4.3/lib/libitoa-a6f76c7f27.rlib --extern matches=/nix/store/j3laann65lzck6lyg9bpjk7gjw9ihk2k-rust_matches-0.1.8/lib/libmatches-47ddbc585f.rlib --extern phf=/nix/store/qcvaa9ya6vgcrpmmyiq042a8jpb4niid-rust_phf-0.7.24/lib/libphf-95b8a51ebb.rlib --extern procedural_masquerade=/nix/store/rwzpk2qq99bkvr83hckj8akf6xq84dfy-rust_procedural-masquerade-0.1.6/lib/libprocedural_masquerade-e6f18a276f.rlib --extern smallvec=/nix/store/nh1i2602n3nphcrxmznrjbnvmpn747iq-rust_smallvec-0.6.9/lib/libsmallvec-99bacd0cdd.rlib --cap-lints allow -L /build/cssparser-0.24.1.tar.gz/target/build/cssparser.out --cfg rustc_has_pr45225 --color always
error: extern location for cssparser_macros does not exist: /nix/store/8yl9hhivlcpr1q485d9h9kywwlxiia91-rust_cssparser-macros-0.3.5/lib/libcssparser_macros-57e42b786a.so
error[E0463]: can't find crate for cssparser_macros
--> src/lib.rs:73:14
|
73 | #[macro_use] extern crate cssparser_macros;
|              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ can't find crate
error: aborting due to 2 previous errors
For more information about this error, try rustc --explain E0463.
builder for '/nix/store/dj2mwhaqg6yma100xscp0rx0s43h7zi8-rust_cssparser-0.24.1.drv' failed with exit code 1
cannot build derivation '/nix/store/378wm523mf1mscvbqc7vjhvy8n3hmdj8-rust_url-bot-rs-0.2.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/378wm523mf1mscvbqc7vjhvy8n3hmdj8-rust_url-bot-rs-0.2.0.drv' failed
So as far as i can tell, not out of the woods yet.
Thanks for looking at this, i'll certainly report anything else i find :)
Hmm, cssparser-macros seems to be a sub-crate within cssparser, I wonder if that has anything to do with this.
I can't imagine that that's uncommon, but it looks slightly suspicious for a normal Cargo project to me, just lib.rs and Cargo.toml.
https://github.com/servo/rust-cssparser/tree/master/macros

It was similar to the other bug but for "libPath" in proc-macro crates.
Keep them coming ;)

As you wish, my good sir! (#6)


Add section about pip and reshimming after module with binaries is installed

Thank you and sorry for the delay.


Don't remove file after releasing lock

Deleting file makes lock unreliable. File should exist in first place. Here is test that proves it.
http://s000.tinyupload.com/index.php?file_id=01315450548811350116
To run it you just need to install docker and execute ./run.sh as user from docker group.

Thank you. This PR fixes also a problem with a test case :)


fix: BOM validation fails when Components or Services are nested

This PR will address the root issue raised in #275.
Fixes:

#275

This PR will also address the following dependency updates:

#271
#270
#269
#256

@madpah no issue with the implementation.
but i thing a tree iterator algorithm on the Set of Component - let's call it ComponentRepository
would be a better fit. it is similar to the thing you've built.


fix(ContainerAuthenticator): add sa-token as default CR token filename

This commit adds support for a second default CR token filename. If the user doesn't specify a CR token filename, the authenticator will first try '/var/run/secrets/tokens/vault-token', and then '/var/run/secrets/tokens/sa-token' in that order.

:tada: This PR is included in version 9.18.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Private vals don't get named by reflection nor @chiselName

The most egregious example is in Queue which uses private vals. Now perhaps we should just make them public, but the issue still stands.
Long ago, Chisel reflective naming worked on private val (https://github.com/freechipsproject/chisel3/pull/407), it seems this is no longer true.
It's also of note that @chiselName doesn't name private vals.
I feel like both of these are bugs that should be fixed.
Type of issue: bug report

Impact:  API addition (no impact on existing code)

Development Phase: request

There was a workaround for some other issue that was relying on this behavior.... let me find which one it is

(Having not tested it and just looking through issues/PRs...) How does the Chisel naming plugin handle this? Does that close this issue?

Just checked, the plugin does indeed handle this!
Fixed by https://github.com/freechipsproject/chisel3/pull/1448


After deleting a scene, its loaded in the content editor

This should not be...
I guess it would make sense to flow to the content editor when the scene is updated

Fixed in #100


uC and vC values when no data for any of them

Faced this issue when I was validating the JGrid implementation. Currently,  if we do not have data for either uC or vC, we return a value for the other one. However, when there is no data for any of them, then data loader should return nan for both of them (which is the case in the java implementation).

I think this was resolved some time again. @ayat-khairy @hjabbot can you confirm?


Datastore access is slow

Access to datastore is slow, and even more slower when run on cloud functions.
Code example:
const Datastore = require('@google-cloud/datastore');

const ds = exports.ds = Datastore({
  projectId: 'my-test',
  keyFilename: './my-test-key.json'
});

console.time('query');
var query = ds.createQuery(['Cat']);
ds.runQuery(query, (error, entities, nextQuery) => {
  console.timeEnd('query');

  console.log(entities.length);
  console.log(entities);
});

Output:
query: 1156.979ms
8
[ { time: 2017-05-05T08:51:51.822Z,
    age: 123,
    name: 'miu',
    color: 'black' },
  { age: 123,
    name: 'miu',
    color: 'black',
    time: 2017-05-05T08:53:26.497Z },
... // 8 same objects

I ran many times, it's always 1.0 - 1.8 sec
Same code in ruby run in 0.7 seconds

Btw, how to use HTTP REST API for Datastore? I can't find how to insert or update data? Is there some example curl commands?

My experience testing locally using this same script:

679.928ms
577.103ms
1505.129ms
500.902ms
520.056ms
1796.278ms

I believe what this would tell us is that the code in this library is capable of running in the range of 500-2000ms for this type of command, but the API response time and network conditions will decide where in that range it falls.
Because of this, I don't think there is anything our library can do. If you feel the performance of Datastore, the service, is lacking, you can open an issue on the official tracker here and have a conversation with members of the Datastore team.

Btw, how to use HTTP REST API for Datastore? I can't find how to insert or update data? Is there some example curl commands?

If you want to use this API directly, you can see the documentation on the expected request and response objects here: https://cloud.google.com/datastore/docs/reference/rest/.

Thank you
What is expected response time during perfect network condition?
I tried to access 1 record by Kind + ID via HTTP and it takes 700-2000 ms, is it normal?
I think it should be less then 30 ms, so people will consider to use it

Questions like those are better on the repo I linked above. We are just the client library that wraps the API. Consider that measuring the first request isn't always the best gauge of performance. There is the authentication step, where an access token is minted, which has to be run before the first API request. This step isn't repeated for future requests, which will show a better response time.

Right, I didn't know that it makes multiple requests at first time.
Is there a way to save credentials to make first request faster?
I updated code:
const async = require('async');
const Datastore = require('@google-cloud/datastore');

const ds = exports.ds = Datastore({
  projectId: 'my-test',
  keyFilename: './my-test-key.json'
});

async.timesSeries(20, (n, next) => {
  console.time('query-' + n);
  var query = ds.createQuery(['Cat']);
  ds.runQuery(query, (error, entities, nextQuery) => {
    console.timeEnd('query-' + n);
    if (error) console.log(error);
    next(error, entities);
  });
}, function(err, cats) {
  console.log(cats.length);
});

Output:
query-0: 1823.483ms
query-1: 175.248ms
query-2: 339.068ms
query-3: 214.101ms
query-4: 687.255ms
query-5: 160.445ms
query-6: 456.044ms
query-7: 172.072ms
query-8: 563.079ms
query-9: 168.259ms
query-10: 411.999ms
query-11: 168.520ms
query-12: 564.410ms
query-13: 171.733ms
query-14: 850.954ms
query-15: 167.130ms
query-16: 861.601ms
query-17: 194.063ms
query-18: 849.674ms
query-19: 171.333ms
20

Is there a way to save credentials to make first request faster?

Not at this time. The access token management is done automatically, to handle auto-refreshing when it expires.

Same here. RT is very slow (too slow for our usecase to be usable sadly)


Add gazette to rasa yaml reader/writer

Since Rasa 2.X they switched from markdown to yaml format for NLU data. Seems like Botfront forgot to add Gazette support to Rasa yaml writer/reader which is added in this PR.

Jira: https://jira.dvv.fi/browse/AAIC-171


Licensing

I don't see the project running under a special license here on Github, but I've seen that the segments are under copyright. On NPM it is under GNU license, with the restriciton to modify the code:
Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. So I guess I can use this in a commercial project? Than I would also contribute to the project in JS.
Maybe a good idea to add that.

v3.x is licensed under the MIT license. You are free to use it in a commercial project. I am also definitely open to contributions. :]


Updated SpecialFolder paths

Corrected MyPictures path
Removed MyComputer as it seems not being mapped

Also, the following SpecialFolder values aren't mentioned, despite they are being mapped:

Fonts -> INTERNAL_STORAGE/.fonts
Templates -> INTERNAL_STORAGE/Templates
CommonApplicationData -> /usr/share
CommonTemplates -> /usr/share

Shouldn't we put these on the list as well?

Thanks for the PR @PieEatingNinjas -- let me check with the engineering team regarding those additional properties.

Merged the initial changes (thanks!). For the additional ones you've suggested, I don't think we have any samples that cover these. If you wanted to create another PR, we can consider it.

Great! Will put the other changes in a new PR tomorrow so you can consider it.


test: extract test app

I created new rails engine with a dummy app and copied that into our
test folder in the same place, test/dummy. I suspect that using the
incantantations in the generated test/dummy and test/test_helper.rb will
help get us to Rails 7.1 test parity.
rails plugin new TestApp --mountable

All Submissions:

[x] I've checked to ensure there aren't other open Pull Requests for the same update/change.
[ ] I've submitted a ticket for my issue if one did not already exist.
[x] My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)

except for Rails 7.1, which is already failing

[ ] I've used Github auto-closing keywords in the commit message or the description.
[ ] I've added/updated tests for this change.

New Feature Submissions:

[ ] I've submitted an issue that describes this feature, and received the go ahead from the maintainers.
[ ] My submission includes new tests.
[ ] My submission maintains compliance with JSON:API.

Bug fixes and Changes to Core Features:

[ ] I've included an explanation of what the changes do and why I'd like you to include them.
[ ] I've provided test(s) that fails without the change.

Test Plan:
Reviewer Checklist:

[ ] Maintains compliance with JSON:API
[ ] Adequate test coverage exists to prevent regressions

was trying to solve the problem which https://github.com/cerebris/jsonapi-resources/pull/1420 solves, so closing since this is interesting, but not needed


introduce extension support

We should discuss this once more before merging it into main. Closing it for now.


MMM-CalendarExt2 dosn`t work with MMM-pages

Hello
I have a the following issue.  I use the MMM-pages Modul and when i set the MMM-CalendarExt2 Modul to permant show then it works. But when i say the MMM-CalendarExt2 is on page 2 as example then i cant see the Calendar, i see just a black page.  i tried with other modules on the same page and this is working with no problems.
Any help out there?
Skorpionbird

MMM-CalendarExt2 needs the time to measure area dimension to draw calendars. So if CalendarExt2 is not drawn at start, it would not know the position and size where should be displayed. Anyway, It will be drawn in updateInterval or rotateInterval finally. Set the values shorter.
Or, you can put this module the first page at start, then hide it. Once it measure the dimension, it can be displayed in other pages also.

Anyway, I've updated for you. Now it could be visible after second page.

Thank you so much. It works now perfect.


Animated Gradient Card added

Describe Changes
Related Issue (Optional)

Hey @Rishika-S-V the customer CSS isn't something I'm keen on, any other solutions?
Also, do you have any examples of when a card like this would be used? Hard to see it's potential.


Stop using Advertising Id in track and match requests

Depends on #38
Fetching and using the Advertising Id implicitly on track and match requests may lead the client app to break some privacy rules. It is also problematic on devices that don't use Google services or in devices with have stricter privacy settings. To avoid dealing with such issues we decided to shift the responsibility of using Google's Advertising Id to the client app.
So, this PR changes the track method to accept an UserId and stops fetching the Advertising Id on init and using it on track and match requests.

Looks good. Waiting on the approval from @silva95gustavo.

Good job @dimamo5!


modules.md - spelling correction

Update spelling error in the Path to Module section.

@wsmelton : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@wsmelton - thank you for your contribution.
#sign-off


Inference with peft and base model are the same

I trained a small pythia-160m model using a small variant of the example int8 training script in trl/blob/main/examples/sentiment/scripts/gpt-neox-20b_peft/clm_finetune_peft_imdb.py.
When doing inference on this LoRa model in a separate script, the results from both the adapter and base model remain the same.  I've tried calling both get_base_model and disable_adapter which both seem like they should do the right thing after scanning the code.
A sample demonstration script:
import torch
import os

from dataclasses import dataclass, field
from datasets import load_dataset
from peft import PeftModel, PeftConfig
from torch.utils.data import DataLoader
from tqdm import tqdm
from transformers import (
    HfArgumentParser,
    AutoModelForCausalLM,
    AutoTokenizer,
)

@dataclass
class ModelArguments:
    final_model: str = (
        field(
            default="peft_done",
        ),
    )

parser = HfArgumentParser(ModelArguments)

# Fun fact, even if you have only one argument class to parse, you still need
# to decompose a tuple.
(model_args,) = parser.parse_args_into_dataclasses()

peft_model_id = model_args.final_model
config = PeftConfig.from_pretrained(peft_model_id)
tokenizer = AutoTokenizer.from_pretrained(config.base_model_name_or_path)

model = AutoModelForCausalLM.from_pretrained(
    config.base_model_name_or_path,
    return_dict=True,
    load_in_8bit=True,
    device_map="auto",
)

def generate(model, prompt):
    inputs = tokenizer(prompt, return_tensors="pt").to("cuda")
    if inputs["input_ids"].shape[1] >= (2048 - 128):
        return "Too Long"

    with torch.no_grad():
        outputs = model.generate(**inputs, max_new_tokens=50)
        input_ids = inputs["input_ids"]
        generated_tokens = outputs[:, input_ids.shape[1] :]
        return tokenizer.batch_decode(generated_tokens, skip_special_tokens=True)[0]

print(generate(model, "I really enjoyed the "))
model = PeftModel.from_pretrained(model, peft_model_id)
print(generate(model, "I really enjoyed the "))
print(generate(model.get_base_model(), "I really enjoyed the "))

This results in the following output:
the book. I have been reading it for a while now, and I am
very excited to read it again.

I am very happy with the book. I am very excited to read it again.
I am very happy with
Setting `pad_token_id` to `eos_token_id`:0 for open-end generation.
icing on the cake. I was so impressed with the way the icing was applied. I was so impressed with the way the icing was applied. I was so impressed with the way the icing was applied. I was so impressed with the
Setting `pad_token_id` to `eos_token_id`:0 for open-end generation.
icing on the cake. I was so impressed with the way the icing was applied. I was so impressed with the way the icing was applied. I was so impressed with the way the icing was applied. I was so impressed with the

From what I can tell, the inference from the base model before the adapter is loaded works is unique, but inference on both the adapter and base model after PeftModel.from_pretrained is exactly the same.
How does one disable an adapter or get inference results from a base model while an adapter is active?

Same issue!
idk what is wrong.


core: Switch functional types to using coffee

I’m not really sure why this change is needed. For things like CheckedConsumer where you’ve defined it yourself, okay (though I think that name is clearer than Consumer1E), but changing from the built in Supplier to Function0 is just pointless if you ask me - unless there is a clear defined benefit to using a library type, why aren’t we preferring the standard JDK types which most, if not all, are a lot more familiar with?

So the original impetus for this change was that the throwing variants of functional types felt generic enough that they should be in a separate library, rather than the ad-hoc collection configurate had -- and it turned out kashike had something similar he was willing to break out, so coffee (all ~15kb of it) was born.
I was originally skeptical of duplicating JDK function types, kashike eventually convinced me that the consistent naming scheme (<type><input count><E (for exception-throwing) or none>) and extra helper functions (for currying, memoizing, etc) would be useful enough, and only really possible by having a full functional type system.
This change is mostly user-invisible as well -- you can write lambdas as you normally would, and type inference will resolve to the new type, so the changes to most codebases are quite small.

Sorry, why do we need yet another functional library, when there’s one already well established at providing a near full functional programming suite of things, including these  types https://www.vavr.io/vavr-docs/#_functions

consistent naming scheme

People are already used to the JDK names - they make sense to them. In that, using such a library like this isn't consistent with the standard library which is what people currently use and (somewhat?) understand. I will admit my own preference is for verbosity for user facing APIs - in that CheckedSupplier (for example) is more likely to be understood at a glance than Function0E because people know what a supplier is. E doesn't really convey that at a glance. Additionally, given Function1 will likely extend Function, why should we be forcing people to use Function1 instead of Function if, for some reason, they store the lambda or otherwise concrete class? Same for Suppler and Function0?

and extra helper functions (for currying, memoizing, etc) would be useful enough

I'm not convinced about that in the context of what Configurate is doing - where would these be used? I'd be keeping the standard JDK types where possible, such that it is possible to use these types if the user wishes to. All you're doing is swapping out one type for another that does the same thing with additional default methods, meaning that if I create a class that would implement Consumer<> whatever, I now need to change that.

Sorry, why do we need yet another functional library, when there’s one already well established at providing a near full functional programming suite of things, including these types https://www.vavr.io/vavr-docs/#_functions

The real question here is does Configurate really need to depend on a library for this full stop? I'm just failing to see the benefit that any of this will bring (I'm not talking about FP here - if vavr was used in impl, sure, but all I'm really seeing here is signature changes away from the JDK types and the removal of three or so interfaces to use a library to supply interfaces.

At this point, I think a 5.0.0 is infeasible given the magnitude of potential changes and existing adoption of the library, so there is no path forward for this PR.


move to '-V ' with swupd update

-m parameter is deprecated and it's good to get rid of it:
  -m, --manifest=V        NOTE: this flag has been superseded. Please use -V instead

Affects: Dockerfile

@mythi Where was this option used in our scripts? I could find on in comments part in Dockerfile, Is this the one you are referring to?

@avalluri I noticed the same after I reported this issue. This is pretty minor. -m is only mentioned in the comments but the update script already uses --version

Thanks, I will fix the comments part then.


Add integration tests

It would be good if we add integration test in api repo (maybe with kube builder). So we can at least check

whether the crd format is correct
whether the field validation is expected.

/kind feature

this has been done
/close


broken links in inline remarks

Some relative URLs in links inside remarks are broken and contain an invalid src/ prefix.
On page .../target/remarks/web/src/src_day_08_mod.rs.html:

load of type i32 not eliminated in favor of load because ...

This link leads to (the non-existing) .../target/remarks/web/src/src/src_day_08_mod.rs.html#L18 instead of correct .../target/remarks/web/src/src_day_08_mod.rs.html#L18

Hi! Do you perhaps have an open-source repo where I could try it? Also, could you please send me your rustc version? Thanks!

I pushed the relevant code reproducing the issue here https://github.com/ottojo/cargo-remark-example, i am using rustc 1.73.0-nightly (1b198b3a1 2023-08-13).
I had a quick look at the code yesterday, and it seems the paths are all correctly extracted (relative to the crate directory), but path_to_relative_url adds the src prefix every time, when it should only do this for the index page?

Ooh, the links inside the actual source files have to be relative to the src directory, not the root directory. This is especially annoying, because the links are contained inside rich string messages that have been prerendered both for the remark list and for the actual inline remarks on source file pages to save memory. I'm thinking of rewriting the static website as a dynamic website with a Rust backend server to resolve these annoyances.
Anyway, does this branch solve the problem on your side? :)
$ cargo install --git https://github.com/Kobzol/cargo-remark --branch fix-relative-links

Yes, #3 fixes this issue for me, thank you very much!
Serving the pages via HTTP instead of opening a file://... url in the browser would probably also allow to just have /src/... links, since those would then be relative to the hostname, i guess?
Anyways, really nice work with this tool, I wanted to try it immediately after reading your blog post, also having watched the cppcon talk some time ago... I absolutely agree with your conclusion of the limited usefullness of the remarks right now and the outlook on rust-specific optimization remarks. I look forward to some day having optimization remarks in rust of the same quality as compiler errors have improved over the usual c++ experience :smile:

Thanks for confirming that it fixes the issue. I have released version 0.1.1 with the fix.


To Do list after we get the arXiv paper link

[x] Update README
[x] Update dco
[x] Update website
[x] Update decisionforce.github.io/ link and figure
[ ] The CN version of website is not synced with EN version

@zqh0253 CN versioni of website is not synced with EN version


Publishing on NPM

How do you feel about publishing this project on NPM? It be great for personal development when trying to install safeframe rather than having to download via Git / Tarballs etc.
Thanks

Yeah we could, although there's nothing in this repro that does anything server-side, so it would just be for packaging purposes.
I have a bunch of backlogged items that I want to get in as well, so I think I'd at least wait till I can get around to getting those checked in.

Sounds good cheers @seansd


add POST endpoint

@wade-richards I'll merge this for you once it's no longer in Draft. If you're still working on it, no problem.

@wade-richards I'll merge this for you once it's no longer in Draft. If you're still working on it, no problem.

The change to the API itself hasn't released yet, so I assume we want to keep the documentation change back until the API has changed.  It'll probably be blocked until January, since I'm about to start my winter vacation, and I don't think it's good to commit changes hours before a 3 week vacation.

The change is merged into the code, and should go live the next release of Concur Travel and Expense.  The docs can be updated now.


Handle linux capability if available

Which issue(s) this PR fixes:
Fixes #3053
What this PR does / why we need it:
Currently, Fluentd core does not handle/refer Linux capability.
This class should handle/refer Linux capability.
Note that this class implementation is only working for Linux with
libcap-ng binding (capng_c) installed platform.
In other platform, this class only returns stubbed results.
in_tail should handle Linux capabilities.
In in_tail, File.readable? does not handles Linux capabilities.
So, we should handle them by libcap-ng binding wrapped class
which is Fluent::Capability.
On in_tail, the following capabilities should be handled:

CAP_DAC_READ_SEARCH(:dac_read_search on capng_c)
CAP_DAC_OVERRIDE(:dac_override on capng_c)

Docs Changes:
Needed. I'll write and register Linux capability documentation for Fluentd later.
https://github.com/fluent/fluentd-docs-gitbook/pull/248
Release Note:
Same as title.
Additional Context:
This PR should be reviewed with some Linux box. (macOS and Windows box is not installable capng_c that is Linux capability bindings for Ruby)

I'd confirmed that capability on Fluentd is working:
https://travis-ci.org/github/fluent/fluentd/jobs/742347990

I'd sent a separated PR to add Linux capability handling command.

Let's :shipit:


mini 3 show as Unknown

need some help to to add device type as unknown.
i try adding to define device list but still dont work.
i have more than one device on network other is RM2 which works fine

Never mind I got it.  Just need a way to auto run once on boot.


Added options 'landscape' and 'format'

This PR adds the following PdfOptions:
format: paper format as string. https://www.puppeteersharp.com/api/PuppeteerSharp.PdfOptions.html#PuppeteerSharp_PdfOptions_Format
Format takes priority over width and height values. Defaults to A4 as before. These are default behaviors for PuppeteerSharp PdfOptions.
landscape: paper orientation.
https://www.puppeteersharp.com/api/PuppeteerSharp.PdfOptions.html#PuppeteerSharp_PdfOptions_Landscape
Defaults to false.

bump

@savpek millon tämä saatais julkaistua?


[INLONG-1505] fix dependencies error when build release-0.10.0

Title Name: [INLONG-XYZ][component] Title of the pull request
where XYZ should be replaced by the actual issue number.
Fixes #1505
Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications
Describe the modifications you've done.
Verifying this change

[ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

+1


Resolve: version swap retain offset and IDT

Changelog Description
Swapped version should retain the offset and IDT.
Additional info
Ayon-core port of https://github.com/ynput/OpenPype/pull/6128 and
closes https://github.com/ynput/OpenPype/issues/6125 issue
Testing notes:

Load latest version of the clip that has Handles start > 0
Set any colorspace to media clip (this will need to have enabled colormanagement on Resolve project)
Use manage to swap for earlier version
Notice that colormanagement configuration is the same as the previous clip

Note that earlier version doesn't match the timeline trim of the latest version, and IDT of the version resets to default

Task linked: OP-7981 Bug: Resolve Inventory offsets clips when swapping versions.

Look into Resolve's console.

This will need resolving before we can test this; https://github.com/ynput/ayon-core/issues/160

This will need resolving before we can test this; #160

this issue had been resolved from today, please try it again.


Back button does not route to correct page when using shared components

Bug Report
Ionic version:

[x] 4.0.0-rc.0
Current behavior:
I use a shared header component across several pages which displays a profile picture, name, and followers. When I click on the profile picture, I am sent to the artist page as expected, but when I click the back button I am routed to the tab root page instead of the previous page.
Expected behavior:

When clicking the back button, you should be routed back to the previous page instead of the tab navigation root page.
Steps to reproduce:

Here's a short video showing how clicking on the artist header routes to the proper artist page but when clicking back, it routes to the root of each tab navigation stack. Note: I made sure to leave in the URL of the browser at the top so you can see how routes are changing on each click:
https://streamable.com/5ind2
On the Home Tab -> Select Artist -> Select Release -> Click on Artist Header -> Click Back -> routes to Home Page instead of Release Page
Related code:
In order to route to the artist page from the artist header component I use the following code:
release.page.html (where I use my component)
    <div *ngIf="artistHeader">
      <app-artist-header [artist]="artistHeader" [user]="userHeader"></app-artist-header>
    </div>

artist-header.component.html (the html of the header component)
  <ion-avatar (click)="goToArtist(artist.artistUID)">
    <img [src]="artist.artistImageURL">
  </ion-avatar>

artist-header.component.ts
  goToArtist(uid: string) {
    this.navCtrl.navigateForward(`tabs/${this.route.parent.snapshot.routeConfig.path}/${uid})`)
  }

Where navCtrl is the NavController and route is the ActivatedRoute. I figured this was the best way to determine which tab we are on when routing a shared component. Please advise if there is a better way. But regardless, I thought that navigateForward explicitly told the router to move forward and that the back button should go to the most previous route.
When using the shared component, I import the SharedModule in to that page module. My shared.module.ts looks like the following in order to properly declare and export components:
@NgModule({
  imports: [
    CommonModule,
    IonicModule,
    FormsModule,
    ReactiveFormsModule
  ],
  declarations: [ArtistHeaderComponent],
  exports: [ArtistHeaderComponent]
})

It's also my understanding if I were to put the (click) event on the actual component HTML like <app-artist-header (click)="goToArtist()"> in the release.page.html then it should work properly, however, I cant make the entire component clickable (just the profile picture) because I have a follow button on the right hand side of the component.
Ionic info:
Ionic:

   ionic (Ionic CLI)             : 4.5.0 (/usr/local/lib/node_modules/ionic)
   Ionic Framework               : @ionic/angular 4.0.0-rc.0
   @angular-devkit/build-angular : 0.12.0-beta.2
   @angular-devkit/schematics    : 7.1.4
   @angular/cli                  : 7.2.0-beta.2
   @ionic/angular-toolkit        : 1.2.0

Cordova:

   cordova (Cordova CLI) : 8.0.0
   Cordova Platforms     : ios 4.5.5
   Cordova Plugins       : cordova-plugin-ionic-keyboard 2.1.3, cordova-plugin-ionic-webview 2.3.1, (and 7 other plugins)

System:

   ios-deploy : 1.9.2
   NodeJS     : v10.13.0 (/usr/local/bin/node)
   npm        : 6.4.1
   OS         : macOS Mojave
   Xcode      : Xcode 10.1 Build version 10B61

Let me know what else you need to help debug! Thanks :)

Thanks for the issue! But what's your problem? If you tap back you come back to the tabs page, which is correct

Hey @paulstelzer ! My issue is that logically, when I hit the back button, I should go back a single page, and not back to the root of the navigation stack.
Here's the desired workflow, I've highlighted the difference:
Home Page -> Click Artist Page -> Routed to Artist Page -> Click release from Artist -> Routed to Release Page -> Click Artist profile picture -> Routed to Artist Page -> Click back button -> Routed to Release Page.
Here's what happens:
Home Page -> Click Artist Page -> Routed to Artist Page -> Click release from Artist -> Routed to Release Page -> Click Artist profile picture -> Routed to Artist Page -> Click back button -> Routed to Home Page.
It seems like the routing forgets my history and just resets back to the home page? Does that make sense? If I click the back button at any other stage of the process it correctly jumps back a single page. For example, if I go:
Home Page -> Click Artist Page -> Routed to Artist Page -> Click release from Artist -> Routed to Release Page -> Click back button -> Routed to Artist Page (see how it goes back a single page?)
Does that help?

Please create a repo here on Github, so I can clone it and test it myself

Here's a repo based on my one from #16897
https://github.com/btsiders/ionic-sub-page/tree/bug-balls
It does the same thing whether you are using

I will also wait for the issue owner for his repo

Hi @paulstelzer here is a very basic repo you can clone: https://github.com/uncvrd/shared-components-ionic.git
I added two pages and a shared component. You can replicate the problem by doing the following:

Press button to route to artist page
(page transitions to artist page)
Press button to route to release page
(page transitions to release page)
Click the profile picture (this is the shared component)
(this will route you forward to an artist page again
Click the back button
This routes you to the home page

What should happen:
4. Click back button
(this routes back to the release page as that was the most recent page I was on)


Zenfolio moving to HTTPS-only

Hello,
Over the past 18 months, Zenfolio has been working to strengthen and improve its infrastructure to provide a more reliable and secure platform for all of our photographers, photographers’ clients, partners, and developers.  While performing these improvements, we are transitioning the Zenfolio API to an HTTPS-only environment.  Due to recent infrastructure changes, unencrypted HTTP calls may not work as expected, as the typical reason an API call may fail is that HTTP is being redirected to HTTPS.  Please note that any issues that may arise from an unencrypted HTTP call may be resolved by updating to HTTPS-only API calls.   We apologize for any inconvenience this may cause and we look forward to continuing a partnership with you.
For best performance, please review your code to ensure only HTTPS calls are being made to the Zenolio API.
Thanks,
Chris Gauthier
Sr. Manager, Data Center and IT Operations
Zenfolio, Inc.

I tried forcing a secure connection for all requests but that didn't seem to change anything. I'm still getting 403
 $f = new phpZenfolio("AppName={$appname}");
 $f->setSecureOnly();

any help would be greatly appreciated.

@p0las :  I just looked at the plugin source and it appears the constructor creates https connections by default.  I'm not sure you need to use the setSecureOnly() method.  Please know that I am not a developer and that my findings may not be 100% accurate-YMMV.  If you are able to capture the headers using a cURL command with some output (please be sure to sanitize it before posting publicly!), that would help, especially if you have a RayID header.  :)

@p0las Your issue is definitely not due to HTTP vs HTTPS as as @chris-zenfolio has pointed out, the code defaults to HTTPS. It also wouldn't produce a 403 error.
Your 403 indicates a permissions issue. Either you're not authenticating or you don't have the correct access. The latter is quite a common issue with partner accounts which haven't been granted all the necessary access for private albums.
In short, check that you are authenticating correctly and that you have the correct access rights for the account/albums.

@lildude You're welcome to close out this issue if you are already making all the calls using https by default.  I would recommend adjusting the constructor to not allow unencrypted http links, if possible.  Thank you for the awesome plugin!  If you run into issues, please email our support team.  They can get you in direct contact with myself or whomever is the best resource for your need.

@chris-zenfolio my problem is that recently all my websites that rely on pulling data from zenfolio broke. At the same time the lightroom plugin that connects to zenfolio broke too. As far as I know this was caused by zenfolio moving to https but I cannot be sure.
The latest LR plugin seems to be fixed and I was looking for a way to fix phpZenfolio too. So far I have no idea why it is not working. Since the LR plugin works I know that my API access is ok.
@lildude unfortunately I don't know how to check that. I know PHP but I know nothing about cURL to debug the connection.

@lildude I just looked at my (very old) code and it appears that I'm using phpZenfolio 1.3
I will update to the latest 2.0.1 and hopefully, this will do the trick. 2.0 seems very different to 1.3 on a quick glance.

I have updated to 2.0.1 (installed composer and used it to get phpZenfolio and dependency)
changed the code to:
  $f = new phpZenfolio\Client($appname);
<EMAIL_ADDRESS>password);

I'm getting:
Client error: POST https://api.zenfolio.com/api/1.8/zfapi.asmx resulted in a 403 Forbidden response: error code: 1010 (Error Code: 403)
I don't think there is much I can change here. my credentials are good (the same ones I log into zenfolio web page), the API is enabled for my user etc.

so after a bit more tests I found the problem. For some reason my app name is no longer compatible with zenfolio API. after changing it I got a successful connection.
All good now.
you can close the ticket. cheers.

Here is the latest example of 301 redirects:
$ curl -I -X GET "http://api.zenfolio.com"
HTTP/1.1 301 Moved Permanently
Date: Thu, 20 May 2021 18:58:48 GMT
Content-Length: 0
Connection: keep-alive
Cache-Control: no-cache, no-store, must-revalidate
Pragma: no-cache
Expires: -1
Location: http://www.zenfolio.com/
CF-Cache-Status: DYNAMIC
cf-request-id: 0a2cbe12e70000fd9957a74000000001
Set-Cookie:
__cf_bm=fc2a407b9f452d2e2e2c50bf79d362608b7c713d-1621537128-1800-Ad/HWgoQKMOyfVADM2JpQOfn+QnQbFRfALzAjgdBD35FxF6znxfWUFfauR1z2SUsjc2CVl5GHsAGyMLRcEF9/mY=;
path=/; expires=Thu, 20-May-21 19:28:48 GMT; domain=.zenfolio.com;
HttpOnly; SameSite=None
X-Content-Type-Options: nosniff
Server: cloudflare
CF-RAY: 6527cc64ad83fd99-PDX
Chris Gauthier
Senior Manager, Data Center and IT Operations
Zenfolio, Inc.
@.***
“To invent an airplane is nothing. To build one is something. To fly is
everything.”
      – Ferdinand Ferber,  c. 1898

On Thu, May 20, 2021 at 4:21 AM p0las @.***> wrote:

so after a bit more tests I found the problem. For some reason my app name
is no longer compatible with zenfolio API. after changing it I got a
successful connection.
All good now.
you can close the ticket. cheers.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lildude/phpZenfolio/issues/28#issuecomment-844998113,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOGRTBXMRFHSR7CCDK7JXALTOTWCXANCNFSM45C7BDQQ
.


Details Regarding  ST OPTICS Clustering

Sir, I have come across your python code for ST_OPTICS and ST_DBSCAN. The codes were extremely useful and informative on the technical side but I have some doubts regarding the output dimension and labeling details. I have an input Geotiff file of 3 dimensions (space and time), Do i expect to get a 3 dimensional output or 2D?. How the labeling is done?, what differentiates the labels from each other?, is there any way to identify. Where shall i get more information about the spatio-temporal OPTICS and DBSCAN or visualise how the data is processed?. Also how to get optimum values for parameters like eps, max_eps, min points etc. I am  relatively new to the topic so please Ignore any mistakes in the questions. Hope that you respond positively.

I hope the following answers help you :)

Do i expect to get a 3 dimensional output or 2D?
You will get a 1D output of numeric labels describing the respective cluster of the mover. We group the moving objects into one group, for instance, group 0 or group 1.
How the labeling is done?
The labeling is done based on the respective clustering algorithm, including the temporal aspect meaning esp_2.
what differentiates the labels from each other?
Each label represents one group of movers or one cluster. Except for -1, which is usually considered as noise or movers that do not belong to any cluster.
Where shall i get more information about the spatio-temporal OPTICS and DBSCAN or visualize how the data is processed?
How do you want to visualize the respective data?
Also how to get optimum values for parameters like eps, max_eps, min points etc.
You have to tune the parameters based on the application domain and your underlying data. You have to cluster and visualize the data to see and identify suitable parameters for eps_1 and eps_2 based on the movement density and the temporal granularity of change.

Cheers,
Eren

Thank you sir for your response.
I actually wanted to analyse precipitation data (geotiff format) to find the clusters. I have 365 days tiff files of the same region, stacked together to form a 3 d dataset with shape (365,601,501), where 601 and 501 are pixel sizes. Inorder to apply fit function I had to change the shape to (365, 601*501).
I suppose to view my clustered output with map projection, for better analysis of the spatial trend of the precipitation. Is it possible to do so?. Do i need to make any changes to the labels (need reshaping) for achieving that?.
Also, I need to know how different clusters are identified, what makes them different from one another, the way to print the spatial characteristic of the cluster?. I have applied k distant method to find eps value, can I use it for eps1 and eps2?
With regards
Anandhu

Thank you sir for your response.
I actually wanted to analyse precipitation data (geotiff format) to find
the clusters. I have 365 days tiff files of the same region, stacked
together to form a 3 d dataset with shape (365,601,501), where 601 and 501
are pixel sizes. Inorder to apply fit function I had to change the shape to
(365, 601*501).
I suppose to view my clustered output with map projection, for better
analysis of the spatial trend of the precipitation. Is it possible to do
so?. Do i need to make any changes to the labels (need reshaping) for
achieving that?.
Also, I need to know how different clusters are identified, what makes them
different from one another, the way to print the spatial characteristic of
the cluster?. I have applied k distant method to find eps value, can I use
it for eps1 and eps2?
With regards
Anandhu
On Thu, 4 May 2023 at 14:56, Eren Cakmak @.***> wrote:

I hope the following answers help you :)

Do i expect to get a 3 dimensional output or 2D?
You will get a 1D output of numeric labels describing the respective
cluster of the mover. We group the moving objects into one group, for
instance, group 0 or group 1.
How the labeling is done?
The labeling is done based on the respective clustering algorithm,
including the temporal aspect meaning esp_2.
what differentiates the labels from each other?
Each label represents one group of movers or one cluster. Except for
-1, which is usually considered as noise or movers that do not belong to
any cluster.
Where shall i get more information about the spatio-temporal
OPTICS and DBSCAN or visualize how the data is processed?
How do you want to visualize the respective data?
Also how to get optimum values for parameters like eps, max_eps,
min points etc.
You have to tune the parameters based on the application domain and
your underlying data. You have to cluster and visualize the data to see and
identify suitable parameters for eps_1 and eps_2 based on the movement
density and the temporal granularity of change.

Cheers,
Eren
—
Reply to this email directly, view it on GitHub
https://github.com/eren-ck/st_optics/issues/1#issuecomment-1534388726,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A7NDZPL2P3RH67RJ37HGCQTXENY3DANCNFSM6AAAAAAXS4GEDU
.
You are receiving this because you authored the thread.Message ID:
@.***>


无法加载Gif图，缺少代码

没有下面对象
using (GifBitmapDecoder gifDecoder = AnimatedGif.Load("C:\samplegif.gif"))
{
// Do stuff
}

My original intention was to add the ability to load animated files but never implemented it because you can easily read these files using the System.Drawing.Imaging namespace. I went ahead and added a quick implementation to the AnimatedGif class and usage to the demo project.

warrengalyen thank you for giving me great help


List/Manage Application Instances

https://github.com/epinio/epinio/issues/1118

@jimmykarily I've added a basic list showing application instances and their details. They have a single action (exec/shell). Is there any other current functionality or information we can show for instances?

No that's it for now. It looks great!

The port forwarding feature can target a specific instance too:
epinio app port-forward sample 8000:8000  -i sample-5445f9f5d9-wnn7m

@jimmykarily Given the browser environment i'm not sure how that action could be tied in, or is there additional info to show?

True, let's skip. We could show a tip on how to forward ports but that would need us to maintain "documentation" in the front end. Let's not.


Installation with straight fails due to inheritenv

I have a basic installation using the use-package version of straight:
(use-package format-all
  :demand
  :straight (format-all :host github
                      :repo "lassik/emacs-format-all-the-code")
  :hook
  (
   (ess-r-mode . format-all-mode)
   (python-mode . format-all-mode)
   )
)

However, I get an error related to the recipe of inheritenv:
helm-M-x-execute-command: Could not find package inheritenv. Updating recipe repositories: (org-elpa melpa gnu-elpa-mirror el-get emacsmirror-mirror) with ‘straight-pull-recipe-repositories’ may fix this

If I try to install inheritenv directly with straight-use-package, I get:
helm-M-x-execute-command: Recipe for inheritenv is malformed

Any idea on how I could solve that problem?

I don't think anything is wrong with format-all here; it works for me. Try updating straight.el and your recipe repositories to the latest version, and if it's still broken, file an issue against straight.el.

Thank you both @lassik and @raxod502.
The issue was with the Melpa version I was using on my configuration file for straight.
By updating the commit hash on the melpa repository all was fine.


Visual C++ support: Define API visibility

When compiling libgdiplus with Visual C++, all functions would be marked as internal because they lack the __declspec( dllexport ) attribute.
To work around this, the WINGDIPAPI is defined symbol (the same symbol which is used in the public GDI+ API, see MSDN), which is left empty when consuming the public API and when on non-msvc compilers, and set to __declspec( dllexport ) when compiling with msvc.

@akoeplinger This is part of a larger effort on my side to get Mono's libgdiplus up and running on Windows. It's main purpose is to make debugging the native code bit easier (using Visual Studio on Windows), but as a side effect, it also brings System.Drawing on Windows platforms which ship without GDI+ (Nano Server).
The wider work is here: https://github.com/CoreCompat/libgdiplus/tree/features/msvc. This PR Is the largest individual change needed to make it work; if this is something you want to ingest I'll also create PRs for the other, smaller changes required.

LGTM. The commit message mentions GDIP_EXTERNAL instead of WINGDIPAPI, please fix that.
I don't have anything against getting the msvc fixes into the repo :)

In general please make sure the commit message mentions the PR description, it's easier to do code archaeology in the future if it's part of the git history :)

Sure, makes sense, fixed it.


Don't use prototype

It would be better to use
var matches = require('z')

var myReverse = list => {
  return matches(list,  // first param for `matches` is an Array, String, etc.
    ()           => [],
    (head, tail) => myReverse(tail).concat(head)
  )
}

myReverse([1, 2, 3, 4, 5]) //[5, 4, 3, 2, 1])

or
var matches = require('z')

var myReverse = list => {
  return matches(list)(  // `matches` returns a function to use patterns
    ()           => [],
    (head, tail) => myReverse(tail).concat(head)
  )
}

myReverse([1, 2, 3, 4, 5]) //[5, 4, 3, 2, 1])

instead of
require('z')

var myReverse = list => {
  return list.matches (  // uses prototype
    ()           => [],
    (head, tail) =>
  )
}

myReverse([1, 2, 3, 4, 5]) //[5, 4, 3, 2, 1])

@donaldpipowitch , why do you think it's better?
The current syntax was based on Scala match.

@leonardiwagner Changing prototype is dangerous.
Another way to solve this could be :: function bind syntax, but this is experimental.
var matches = require('z')

var myReverse = list => {
  return list::matches (  // function bind syntax
    ()           => [],
    (head, tail) =>
  )
}

myReverse([1, 2, 3, 4, 5]) //[5, 4, 3, 2, 1])

@donaldpipowitch It's a bit controversial :smile: , I understand why libraries like underscore and lodash don't want to change prototype, since they aim a great mass of projects (even legacy ones) where changing the prototype of existing objects will be really bad.
I suppose that a lot of people prefer to write and read list.map(f) instead _.map(list, f)  , and since z is aimed for a smaller group, I'd like to take some risk for something pleasurable to use
Or at least, we can make a way to turn this optional, do you agree on something?

I suppose that a lot of people prefer to write and read list.map(f) instead _.map(list, f)

Definitely. That's why I'm really looking forward to ::.
It's your library, you can decide. :) But I wouldn't change prototype even if this library is aimed for a smaller group. Say you make some demos now, it would be sad if they break in some years because a native matches  method will be implemented.

Hey @donaldpipowitch , just for the records, even thought I still believe in my personal opinion, the community feedback was same of yours, and since I want to make this not * mine * project, I did your suggested change, the 2nd layout:
matches(1)(
  (x = 2)      => console.log(`number 2 is the best!!!`),
  (x = Number) => console.log(`number ${x} is not that good`),
  (x = Date)   => console.log(`blaa.. strings are awful!`)
)

This will be changed at 1.0.0 version which I plan to release soon, I'm already updating the docs on master, thanks for your collaboration!

Cool, thank you for the update.


Peculiar issue with detecting/parsing certain files to add in a Hub

I'm not sure if it's only my systems or a global issue (although I did test multiple systems and various files) but if the extension of any video file is capitalized, then Video Hub failed to parse/detect the file to add, for example "00.mp4" will work, but "00.MP4" will not be added to the Hub.
Also a suggestion along those lines, when adding alot of files, it gets really tedious to weed out the ones which have not been added due to improper parsing or a badly encoded file so it would be great if a report was generated which says which files were not able to be added. Could be done by a simple crosscheck between added files and a walkdir enumerating all files at the source.

Great catch! Thank you!!!
The supported filenames acceptableFiles https://github.com/whyboris/Video-Hub-App/blob/main/node/main-filenames.ts
used to be compared extensions .toLowerCase https://github.com/whyboris/Video-Hub-App/blob/main/node/archive.ts#L157
But is no longer: https://github.com/whyboris/Video-Hub-App/blob/main/node/main-extract-async.ts#L185
This is likely a 1-line fix 😁
Please let me know if you'd like to open a PR for a fix or let someone else handle it 🤝

🤷♂ it was a 1-line fix so I just did it 😎 #554 with https://github.com/whyboris/Video-Hub-App/pull/554/commits/cf3db5d892ac0a5616685a70aa26cdcfd07e0010


react/static-property-placement missed cases

On latest version 7.14.2, I typically leave Component.propTypes = {}; and Component.defaultProps = {}; in my new components from stub file, in case I'm going to expand them letter to have props. The react/static-property-placement is triggering with rules 'react/static-property-placement': ['error', 'static public field'], on two of my components, App and BaseComponent. It gives the errors:
36:1  error  'propTypes' should be declared as a static class property     react/static-property-placement
40:1  error  'defaultProps' should be declared as a static class property  react/static-property-placement
Not sure why it wants me to make these into static class properties instead of:
App.propTypes = {
};
App.defaultProps = {
};
I have another component which does not trigger it:
DrawerContentComponent.propTypes = {
};
DrawerContentComponent.defaultProps = {
};
Exactly the same layout and everything :/ Is it because other components inherit from BaseComponent? Nothing inherits from App, but maybe it's just special?
EDIT: After carefully reading the doc page again, I see I have chosen the wrong type, I should be using property assignment. However it doesn't explain why the rest of my components which are all using MyComponent.defaultProps outside of the class body don't trigger the same rule, leading to my confusion.
EDIT 2: It appears that any components which extend from a custom component (in my case BaseComponent) will /not/ trigger the error on 'static public field' when doing a property assignment outside class body, while components extending from Component will. I guess component detecting doesn't pick up on subclasses of Component, which renders this rule fairly useless for me since 99% inherit :/

React class components should never inherit from anything but React.Component - there shouldn't be a "base component" at all.

If you're saying /never/ to something that is technically supported by the
docs....... Any ES6 class....... Doesn't really matter what I have to say.
On Tue, Jul 16, 2019, 12:51 AM Jordan Harband<EMAIL_ADDRESS>wrote:

React class components should never inherit from anything but
React.Component - there shouldn't be a "base component" at all.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/yannickcr/eslint-plugin-react/issues/2348?email_source=notifications&email_token=AE3C6UZFKZQ4HYXFYR4DC3DP7VOWNA5CNFSM4ID3O5I2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ7YXOQ#issuecomment-511675322,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AE3C6U5VFIBCK5TN6ETPUELP7VOWNANCNFSM4ID3O5IQ
.

There are plenty of legitimate reasons that BaseComponent is a thing. There might be better ways for that functionality to trickle down, but I mean... It's kind of the Hallmark of functionality between shared components...

Not in React - it's highly unidiomatic to have inheritance trees. Composition is better than inheritance - this is the official recommendation of the React team.
That said, this linting plugin can be told to treat a class as if it were a React component, even though it's not inheriting directly from React.Component or React.PureComponent: https://github.com/yannickcr/eslint-plugin-react/issues/717#issuecomment-257731857

Closing after workaround.


Support blobfuse custom storage endpoint

I am trying to use this with Azure in China, but I cannot modify the storage endpoint as described here in Blobfuse. Do you consider adding the support of custom storage endpint?

I submitted a PR in blobfuse repo: https://github.com/Azure/azure-storage-fuse/pull/281
It's better add env support for custom storage endpoint

cc @seguler

fixed by https://github.com/Azure/kubernetes-volume-drivers/pull/42 on mcr.microsoft.com/k8s/flexvolume/blobfuse-flexvolume:1.0.11


No Bulgarian translations

material-react-table version
1.14.0
react & react-dom versions
v18
Describe the bug and the steps to reproduce it
I have added a translations file as a pr.
Minimal, Reproducible Example - (Optional, but Recommended)
try translating to Bulgarian
Screenshots or Videos (Optional)
No response
Do you intend to try to help solve this bug with your own PR?
Yes, I am also opening a PR that solves the problem along side this issue
Terms

[X] I understand that if my bug cannot be reliably reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.

https://github.com/KevinVandy/material-react-table/pull/614

@KevinVandy


Automatically use torch.jit.script for all operations

This should help with #482, and torch script compatibility was already a requirement anyway.
The diff is a bit larger than I'd like because when using
@torch.jit.script
def foo():
    ...

all functions called inside foo must already be defined.
As a small side change, I renamed _classes to _backend which feels more descriptive.
Contributor (creator of pull-request) checklist

[x] Tests updated (for new features and bugfixes)?
[ ] ~Documentation updated (for new features)?~
[x] Issue referenced (for PRs that solve an issue)?

Reviewer checklist

[ ] CHANGELOG updated with public API or any other important changes?

📚 Documentation preview 📚: https://metatensor--504.org.readthedocs.build/en/504/

Is there a way to use the non-scripted classes? (E.g. for better error messages?)
EDIT: E.g. "re-run with METATENSOR_OPERATIONS_TORCHSCRIPT=0 for a better error message

Maybe this can be put into CONTRIBUTING.rst into the Running tests? Otherwise looks good. PR seems very simple, just creates a lot of line noise because of change of order of the functions which is needed for torch script

Is there a way to use the non-scripted classes? (E.g. for better error messages?)

I think we can use the normal PyTorch mechanism for this: https://pytorch.org/docs/stable/jit.html#disable-jit-for-debugging
I'll add a line to Contributing.rst


Add autocorrect support for RSpec/VariableDefinition

Added an autocorrect support for RSpec/VariableDefinition.

Before submitting the PR make sure the following are checked:

[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Updated documentation.
[x] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
[x] The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

Thank you!


curses.h can break cpr/error.h

Including curses.h before cpr/cpr.h will cause the build to fail in errro.h
/<redacted>/src/cpr/include/cpr/error.h:13:5: error: expected identifier before ‘(’ token
     OK = 0,
     ^~

Fedora release 29 (Twenty Nine)
g++ (GCC) 8.3.1 20190223 (Red Hat 8.3.1-2)
Copyright (C) 2018 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

The problem is that curses.h uses a macro to define the symbol OK which does not play well with C++ enums since it ignores scoping and namespaces. If you aren't using the enum member in your actual source, you can fix your build by reordering or with compiler pragmas.
For GCC:
#include <curses.h>
#pragma push_macro("OK")
#include <cpr/cpr.h>
#pragma pop_macro("OK")

Just know that if you do decide to use that enum member in your code you'll get a pretty nondescript error that's hard to debug. You could try undefining the macro all together and making an adapter header which defines a C++ enum with the values of the OK macro and the related macro constants.

Feel free to reopen this issue, if the answer from @ssnover95 did not resolve your problem.


Fixed path extension to work on a path that is created with just a bucket and no key

This addresses https://github.com/lendup/fs2-blobstore/issues/36

I aimed to keep the changes as small as possible to start. It would make sense to make Path.key an Option[String] and formalise the idea that it might be absent, but that would potentially break existing uses.

That would make sense. I modeled Path from S3's (bucket, key) approach but it has proven to be cumbersome to handle.
Another approach would be to model Path as Seq["NonEmptyString"] and each Store impl can decide how to concatenate and handle edge cases, I think this way we could make the change without breaking backward compatibility.

How would you like to proceed with this? We can merge this PR and address the immediate issue, and look at other approaches, or I can make some more changes, though it might be a few days before I can get back to it.

@DougC I'm working with Matt to merge both open PRs and publish. We can work on improvements as a separate effort.

@rolandomanrique ok, thanks.


feat: Add pins as string in portArrangement

Closes - #191

@imrishabh18 before doing anything with the implementation, can we build a really extensive test for this? Instead of just testing one example, can we put together a test with a bunch of hard examples?

Yeah, I think that would be better. I will write one test file with possible edge cases I can think of and will share


fix: Login Error

Related Issue

fixes: #353
Description

Changed deleteSessions() to deleteSession("current") to delete only active user session, if any, before login.
Enclosed deleteSession() in a separate try-catch block to bypass generate_unauthorized_scope error, which means no active sessions were found (and hence can be ignored).
Set login cookies expire time to be same as appwrite session expire time, which can be set in the appwrite console under auth>security

Screenshots
Flow 1: Normal Login
https://github.com/Sanchitbajaj02/palettegram/assets/80148777/5617a956-6dfe-4eb6-bc91-7d6d4dd1e3e0

Flow 2: Session active in Appwrite, but not on browser (accidental cookie clear by user)
https://github.com/Sanchitbajaj02/palettegram/assets/80148777/4ec7f760-d0e6-41ea-af98-7bbbaa1b5c22

Flow 3: Logged in user
https://github.com/Sanchitbajaj02/palettegram/assets/80148777/be64f6ac-a705-46b9-a9d7-9c39207358ae

Summary by CodeRabbit

New Features

Enhanced login functionality to include session expiration time, improving user experience with better session management.

Bug Fixes

Improved error handling for unauthorized scope errors during login attempts.

Improvements

Cookies now include expiration parameters, providing more accurate session control and security.

@Sanchitbajaj02 please verify.


Installation instructions

I can not for the life of me get this project working. Can you please update something with installation instructions that work.  The examples in the docs are clearly outdated. I have attempted to copy the simple example but can't get the first migrations to work. Your examples don't seem to define PLATA_SHOP_PRODUCT anywhere like in docs and without that you get this error:
  File ".venv\lib\site-packages\django\forms\models.py", line 1232, in <listcomp>
    f.remote_field.model._meta.proxy
AttributeError: 'str' object has no attribute '_meta'

With this var defined and pointing to my simple product, after creating migrations for shop and the other submodules (also not mentioned in the docs), I try and run the migration and I get circular dep errors.

It is an old project with no releases after 2016. Maybe you can try with python 2.7 and and an old version of django.

The examples all define PLATA_SHOP_PRODUCT I think, see https://github.com/matthiask/plata/blob/2a15058b7f5fb234f0420bfed0210f1002fb3328/examples/simple/settings.py#L141 ?
The testsuite does it as well: https://github.com/matthiask/plata/blob/2a15058b7f5fb234f0420bfed0210f1002fb3328/tests/testapp/settings.py#L78
Tests are running (and passing) with Django 4.1 and 4.2; I haven't made a release in years, that's true. I have been looking into updating Plata though so that I can use it in an upcoming project and there's really no reason why I haven't published a release except for the fact that I haven't had to do it for any project yet. If you can confirm that installing from main works I'll happily publish a release though.

Hi guys.
@matthiask I just installed using the main branch, setup according to the oneprice example.
I made migrations for the product model and migrated. What I noticed is that no Plata migrations are run when I migrate - only Django defaults and the product model migrations are run.
I continued and created a superuser and ran the project.
When I log in admin, Django raises - >;
"OperationalError: no such table: shop_order"
Everything is as per the oneprice example.
Running on :

Python 3.10.12
Django 4.2.7

I got excited to soon, upon remembering that no Plata migrations were ran, I thought I'd check out if the Plata models in the admin work or not - as expected, no migration tables means they don't work.

Looking at the package apps (contact, shop etc), I see that they don't have any migrations modules in them, only the shipping app has them and unfortunately I am not using it.
@matthiask is there a specific reason behind the missing migrations?
I ran make migrations on all the Plata apps just to see if all is going to go well (I know that's not the way to go but I was just trying to push it further and see what happens) and they ran.
When migrating, I now get a "CircularDepencyError: shop.0001_initial, example.0001_initial'

@matthiask is there a specific reason behind the missing migrations?

No there's no reason, just (very) slow maintenance. You could try recreating the migrations, and if it works, I'd definitely appreciate a pull request!


Failed to resolve fuel-reactor 1.13.0 1.14.0 15.0

Bug Report
gradle -> jcenter erros...

@jganser Could you be more specific about the error, please? An error message, error code or stack-trace may help.
The available versions of fuel-reactor is available at https://jcenter.bintray.com/com/github/kittinunf/fuel/fuel-reactor/.

or a newer version like 1.15.1
I think we can close this unless there is more info?


Adding a scroll back to top button

What feature?
I propose adding a "Back to Top" button in the footer section of the website. This button will allow users to easily navigate back to the top or header section of the webpage with a single click, enhancing user experience and accessibility.
Add screenshots

the button will be added there
Record

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I agree to follow this project's Code of Conduct
[X] I want to work on this issue

Thanks for raising this, I have assigned the same issue to someone else, please check another issues


Entering the name of the FormFlow parameter as part of the value does not work

Hi,
Let us assume you have a FormFlow Dialog with a string parameter called 'Title'
If, when prompted for the value of Title, you enter anything that has the word Title in it (for example 'A Godd Read, A Working Title' then it is not accepted by the Dialog and the user is prompted to enter the parameter again.

This is a bug and we will have a fix in the next release--thanks for bringing it to our attention.  In the meantime you can always force the entry by putting your response in quotes, i.e. "A working title" will not interpret the response as a navigation to the title field which is what is happening.


reset_beginning is unexpectedly destructive

The documentation on reset_beginning is misleading.  reset_beginning deletes the consumer group zk entry no matter what which can lead to unpredictable behavior with multiple consumers in a group.

fixed by PR: https://github.com/logstash-plugins/logstash-input-kafka/pull/24


chore(merge-back): 1.116.0

See CHANGELOG

AWS CodeBuild CI Report

CodeBuild project: codebuildgithubautobuildPro-fkVQbXRiQi6A
Commit ID: 8401f40128af6d1b44005939ea6e52ab7e6d255a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Fix build version exposed by proxy

Proxy exposes build_version gauge like all other components.

Updates bootstrap to allow that metric
Updates golden files.

emits metrics like this istio_build{component="proxy",tag="1.4-dev"}

@mandarjog: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio
4a3a4226aa3cc68c5457e992fad94f0a75638961
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mandarjog: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio
4a3a4226aa3cc68c5457e992fad94f0a75638961
link
/test lint_istio

integ-new-install-k8s-tests_istio
4a3a4226aa3cc68c5457e992fad94f0a75638961
link
/test integ-new-install-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Lint is failing

@mandarjog: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio
e40fb5711580797b35d0f05f54420205390e9e07
link
/test integ-new-install-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


feat: Add v6.22.02 recipe

* Add introduction to README
* Add v6.22.02 recipe and build script
* Add pre-commit hooks

For posterity, it was only by a stroke of luck that Googling on undefined reference to dlsym'` lead me to https://github.com/openai/go-vncdriver/issues/16#issuecomment-272423954 which made me think to check what was happening with CPython. This was not obvious to me at all from the build errors.


Volume server lacks API to query index of EC volumes

Volume Server API functions which query volume index ( ReadAllNeedles, ReadNeedleMeta, VolumeTailSender, ...) do not work with EC volumes.
There is basically no way to query the index of a volume after it is converted to EC, except to convert a volume back to .dat, although EC volumes do have queriable index files.

they are implemented when needed. Currently no need for these.

It is needed for incremental backup be able to continue if source volume converted to EC before it finished backing it up.

please send PRs.


Fixing bug in VSO nuget script

@jasonsandlin,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

:shipit:


rename list->devices, start->run

rename flutter start to flutter run (fix https://github.com/flutter/flutter/issues/1655). keep start as an alias
rename flutter list to devices (w/ list as an alias)
hide the daemon command

LGTM


Floating numbers added to player experience bar

Try to avoid reformatting the entire file. It makes it hard to see the actual changes, since the diff shows the entire file was changed.

Sorry about that, i noticed after commit. But Visual Studio showed me only
changed lines before commit not whole file.
2017-05-29 11:32 GMT+03:00 twostars<EMAIL_ADDRESS>
Try to avoid reformatting the entire file. It makes it hard to see the
actual changes, since the diff shows the entire file was changed.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/srmeier/KnightOnline/pull/61#issuecomment-304605007,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AH7foFnoX1ZYMzG8yl0bsDCbL_Yr5DHBks5r-oKbgaJpZM4Nod6T
.


Link email to account

Hi, how can I link my gmail to my admin login?

The current implementation was meant to whitelist custom domains (and you probably wouldn't want to whitelist anyone with a gmail.com email), see https://github.com/8thwall/google-auth-yourls/blob/master/plugin.php#L84
I can look at updating this to handle either approved domains, or specific email addresses.  In the meantime, you could modify the atomarch_check_domain() function and validate against $user_info['email']


eslint shows only first error

How to configure gulp-eslint in such a way, that it will show all errors at once?
Now I have to make gulp-eslint after each error fix, because it shows only first detected error.
1.1.0.

Wow, I solved the problem) Just removed that line:
.pipe(eslint.failOnError());

Maybe it should not be in examples)

Which example did you find it in? It's not in the "fix" example, and the first example in README.md uses failAfterError. The only full example of its use is in the "fail-immediately" task in which the example reports and fails as soon as possible. For an example of how to report all errors (at once) before failing, look at the "fail-at-end" task in that same example file.

I'll close this since the issue is resolved; though, I can still clarify any confusion regarding the API.

Example was in "usage" section for 1.0.0 version.
Now the problem is solved, thanks.


possible use of uninitialized variable in np2srv_sr_check_exec_permission()

Hi,
While investigating another issue (which you already solved upstream ;) ), I've seen a potential issue in np2srv_sr_check_exec_permission():
int
np2srv_sr_check_exec_permission(sr_session_ctx_t *srs, const char *xpath, struct nc_server_reply **ereply)
{
    int rc = SR_ERR_DISCONNECT;
    struct nc_server_error *e;
    bool permitted;

    pthread_rwlock_rdlock(&sr_lock);

    if (!np2srv.disconnected) {
        rc = sr_check_exec_permission(srs, xpath, &permitted);
    }

Here, if rc != 0, *permitted is not set.
Also, rc can also be != SR_ERR_DISCONNECT.
    if (rc == SR_ERR_DISCONNECT) {
        // (...) not our case
        return np2srv_sr_check_exec_permission(srs, xpath, ereply);
    }

    // XXX the variable here may be unset. Maybe we should also check if rc == 0 ?
    if (!permitted) {
        rc = SR_ERR_UNAUTHORIZED;
    }
    if (rc != SR_ERR_OK) {
        if (ereply) {
            *ereply = op_build_err_sr(*ereply, srs, rc);
        } else {
            ERR("%s failed (sysrepo: %s).", __func__, sr_strerror(rc));
        }
    }

I don't think there is a big impact, I suppose it can just lead to loose the error value.

Hi,
it is a bit confusing but should work properly. If (!np2srv.disconnected) is true, then both rc and permitted are set and everything is fine. If (!np2srv.disconnected) is false, then rc does not change meaning it is SR_ERR_DISCONNECT and then the code will never get to the line where permitted is actually read.
Regards,
Michal

But what happens if !np2srv.disconnected) is true, and sr_check_exec_permission() returns an error (for instance NOMEM)?
To me, it looks that permission is tested but not initialized.

Okay, that is true but I am not sure whether that is netopeer2 or sysrepo problem. Anyway, should be fine now.
Regards,
Michal


Fix color output on Windows

Output on Windows showed the ANSI escape sequences. This uses the colorable writers to display the colored output.
Tested in PowerShell, PowerShell Core, and WSL.

@googlebot I signed it!

I have an alternative proposal, let's create a cmdutil.SetOutputStreams() method and just call os.Stderr = color.Error (+out) in func init() of both programs.

I say this because I don't want us to accidentally forget passing the streams around. There might be other streams that reference os.Std{err,out} (such as default log pkg log.Printf).

I just ran into that problem after installing fzf.
I tried quickly just to set os.Stdout = color.Output, but I can't assign an io.Writer to an os.File. I will have to look more into this, and also do more testing with fzf.

Ah! Then let's go with your solution for now.

Ah! Then let's go with your solution for now.


task - update installation and support in README

I have added only the link for now. Please let me know if need to provide more details for this section.


Unclear behavior if anchor offset is NULL in GPOS Lookup Type 3.1

In chapter "GPOS — Glyph Positioning Table" under "Cursive Attachment Positioning Format1: Cursive attachment" there is written:
To position glyphs using the CursivePosFormat1 subtable, a text-processing client aligns the ExitAnchor point of a glyph with the EntryAnchor point of the following glyph. If no corresponding anchor point exists, either the EntryAnchor or ExitAnchor offset may be NULL.
In case any of the anchor offsets is NULL, it is unclear what is the expected behavior should be. I think there are two options:

No positioning will be applied
Coordinates of the anchor are zero.

I have actually encountered such a case and it seems to me that omitting positioning of any of the anchor offsets is NULL is the correct behavior.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 3f748ff4-44a6-6395-e0ce-d249b8c9541b
Version Independent ID: b80d0359-5657-632b-29e8-142c06902001
Content: GPOS — Glyph Positioning Table (OpenType 1.9) - Typography
Content Source: typographydocs/opentype/spec/gpos.md
Product: typography
GitHub Login: @PeterCon
Microsoft Alias: alib

If either entryAnchorOffset or exitAnchorOffset is NULL, then no positioning is applied. This could be clarified.

See the OT 1.9.1 alpha for draft revisions addressing this issue.

This is fixed in OT 1.9.1. See the OT 1.9.1 beta for draft revisions addressing this issue. Closing.


interceptor intercepts angular-ui templates

Hi, thanks for sharing this great project! The only issue I had was when using SpringDataRestInterceptor, it was intercepting everything, including my angular-ui-router templates, and blowing up while trying to process them, since they're just strings.
I noticed it was blowing up here:
https://github.com/guylabs/angular-spring-data-rest/blob/master/src/angular-spring-data-rest-provider.js#L218-L221
The most unobtrusive fix that I can think of is to check that response.data is of type object before calling process(), if it's not, let it pass through unchanged.
This change cleared up the issues I was having with the angular-ui-router templates. Thanks!

Hi Tony,
thanks a lot for the pull request! :) Yes that is true it intercepts everything but I think this is a good addition. And nice that you wrote a test for it.
You then need to use the head of the repository in bower such that you have these changes through bower, as I won't release a new version in the near future.
Thanks and regards,
Guy


Suggestion/discussion: Recenter the view vertically

When browsing posts, inevitably I end up scrolling down repeatedly and thus the selected post is always at the bottom. I find this a bit awkward unless I just shrink the window considerably. In vim I'd recenter the window/cursor with zz. Here there isn't much I can do, and the result is that I'm looking always at the bottom of the window, while having the whole rest of the window filled with posts that I've already glanced at.
This isn't a request, just an observation to see if anyone else considers this something that could be improved. A keybind to recenter would be onw approach, another would be to keep the focus always in the middle of the screen so with a glance you can see past and upcoming posts.
Any other ideas?

This is something that has been mentioned by others as wellt: https://github.com/michael-lazar/rtv/issues/505 https://github.com/michael-lazar/rtv/issues/387

Apologies, I should've searched better, feel free to close this

No worries, I just try to link to old issues for searchability. Clearly this feature is something that people are asking for and I appreciate your input.

I came here to request this as well. If I had to choose I would take zz, zt and zb over scrolloff