Make PyFunction.name() public

Summary
Consider the following code:
def my_callback(arg1, arg2):
    print("hello world")

def my_setup_call(my_rust_class):
    my_rust_class.call_every(my_callback, 30)

call_every_second would take a PyFunction. We may want to tear down the interpreter and wait 30 seconds before we call that callback, fire up a new interpreter, get the function out of the module, and call it with arguments. Unfortunately, PyFunction.name() is private. It should be accessible so that we can find the symbol again in another environment.

For python types, most of python-accessible fields are private.
Are you sure your callback always is a PyFunction type but never other types of callable like a class(PyType) or  builtin function(PyNativeFunction)?
If there is a chance, calling let name = func_obj.get_attr("__name__", vm) might be better idea.

Using .get_attr("__name__") ended up being an acceptable api. Thanks for the response!


[bp/1.30] build(deps): bump distroless/base-nossl-debian12 from 4cc93c5 to `e…

…130c09` in /ci (#36322)

cc @asedeno


Fix speedup after losing activity focus

Fix for issue #6
When the game loses focus (user presses home or switch app button for example), mLag seems to carry on increasing in the background. Resuming the game then causes it to update too frequently, speeding the game up, because of false lag.
The State.setGamePaused(true); addition in GameActivity pauses the game if you pull the notification drawer down.

Looks good, thanks for fixing issue https://github.com/m45t3r/retrobreaker/issues/6.


Register new user: read primary node

We detected an issue in the register user endpoint where we perform a write (primary) / read (secondary) action thus creating inconsistencies.
Fix: We should read on the primary node

@Ramzay  Write + Read just after should be avoided in the backend.
Reading on the primary only will lead to performance issues.

Hey @LucasBrazi06 !
Yes it should be avoided, but on this particular endpoint, we do a write followed immediately by a read which causes inconsistencies since the data was not replicated on all secondary nodes :)
And consistency of the data is really important here ! So the goal is to have some endpoints read the primary when consistency is important, and leave other endpoints read on the secondary.

Hey @LucasBrazi06 !
Yes it should be avoided, but on this particular endpoint, we do a write followed immediately by a read which causes inconsistencies since the data was not replicated on all secondary nodes :)
And consistency of the data is really important here ! So the goal is to have some endpoints read the primary when consistency is important, and leave other endpoints read on the secondary.

Thanks for the explanation 🙂.
Could you point me the code?

Of course @LucasBrazi06

We had some cases where the read returned nothing => meaning user not created => full flow with email notification

It means that you have identical user registration at the same time or with little delay.
This use case should never happen otherwise you will have to change all the endpoints 🙂.
Let me know if you can provide more info on the use case triggering this issue.


"panic: index out of range" on attempted join

Repro is with GA Zed tagged v1.15.0 and the test data at s3://zed-issues/5097/all.zng.gz, as it's too large to attach to a GitHub Issue.
Save this program.zed:
from all
| _path=="notice"
| cut resp:=id.resp_h
| sort
| uniq
| inner join (
  from all
) on resp=id.resp_h foo:=uid

Now start a local zed serve, then load the test data and run the query as shown below. (For some reason I've not been able to repro the problem with zq or  querying the lake directly at a filesystem location).
$ zed -version
Version: v1.15.0

$ zed create -use all
pool created: all 2ebe3H1zVKSKpKklFtzaWnh5xUn
Switched to branch "main" on pool "all"

$ zed load all.zng.gz
(1/1) 51.69MB/51.69MB 15.85MB/s 100.00%
2ebe3r5ROZyKNgKiPzLLeSgUlg4 committed

$ zed query -I program.zed

$ echo $?
0

At this point we find the zed serve has crashed with this panic dump:
panic: runtime error: index out of range [3] with length 3

goroutine 206 [running]:
github.com/brimdata/zed/runtime/sam/expr.(*DotExpr).Eval(0xc00f492880, {0x2a742e0, 0x397bba0}, {{0x2a7c9b8?, 0xc00f141d70?}, 0xc001b388dd?, 0x4bbe8f18?})
	/Users/phil/work/zed/runtime/sam/expr/dot.go:50 +0x24c
github.com/brimdata/zed/runtime/sam/expr.(*DotExpr).Eval(0xc00f4928c0, {0x2a742e0, 0x397bba0}, {{0x2a7c9b8?, 0xc00f141d70?}, 0xc001b388dd?, 0x3978728?})
	/Users/phil/work/zed/runtime/sam/expr/dot.go:42 +0x58
github.com/brimdata/zed/runtime/sam/expr.(*missingAsNull).Eval(0x2a7c918?, {0x2a742e0?, 0x397bba0?}, {{0x2a7c9b8, 0xc00f141d70}, 0xc001b388dd, 0x1a})
	/Users/phil/work/zed/runtime/sam/expr/sort.go:134 +0x3d
github.com/brimdata/zed/runtime/sam/expr.(*Comparator).Compare(0xc00f7c62a0, {{0x2a7c9b8?, 0xc00f77c9f0?}, 0xc004aa794a?, 0x0?}, {{0x2a7c9b8?, 0xc00f141d70?}, 0xc001b388dd?, 0x165b622?})
	/Users/phil/work/zed/runtime/sam/expr/sort.go:149 +0x1ee
github.com/brimdata/zed/runtime/sam/op/spill.(*MergeSort).Less(0xc00f3501e0, 0x1, 0x0)
	/Users/phil/work/zed/runtime/sam/op/spill/merge.go:142 +0x7d
container/heap.down({0x2a8f4e0, 0xc00f3501e0}, 0x0, 0x2)
	/usr/local/opt/go@1.21/libexec/src/container/heap/heap.go:111 +0xef
container/heap.Fix({0x2a8f4e0, 0xc00f3501e0}, 0x2a7c9b8?)
	/usr/local/opt/go@1.21/libexec/src/container/heap/heap.go:84 +0x3d
github.com/brimdata/zed/runtime/sam/op/spill.(*MergeSort).Read(0xc00f3501e0)
	/Users/phil/work/zed/runtime/sam/op/spill/merge.go:127 +0x59
github.com/brimdata/zed/zbuf.(*puller).Pull(0xc01535bef8, 0x50)
	/Users/phil/work/zed/zbuf/batch.go:85 +0x4e
github.com/brimdata/zed/runtime/sam/op/sort.(*Op).sendSpills(0xc0001753b0, 0x2a8aae8?)
	/Users/phil/work/zed/runtime/sam/op/sort/sort.go:162 +0x5a
github.com/brimdata/zed/runtime/sam/op/sort.(*Op).run(0xc0001753b0)
	/Users/phil/work/zed/runtime/sam/op/sort/sort.go:107 +0x2ee
created by github.com/brimdata/zed/runtime/sam/op/sort.(*Op).Pull.func1 in goroutine 205
	/Users/phil/work/zed/runtime/sam/op/sort/sort.go:48 +0x66

In addition to the panic, I'm somewhat concerned that the zed query simply produced no output and had an exit code of 0 implying success. I respect that there may be catastrophic failures like kill -9 in which the zed serve process would not be given a chance to say anything meaningful as it dies, but in this case since it was able to produce the panic dump at the console, is there some way it could have also returned enough info back to the client to imply something went wrong?
FYI, this bug does not seem new. I went through several releases all the way back to Zed v1.10.0 and these repro steps produced a panic in each one.

In a group discussion @nwt mentioned that the problem of the successful exit code is a known problem that shows up in a couple operators (join and sort were the two mentioned, I think) where a goroutine is used and the plumbing is not present to gracefully handle a panic. He explained that it's not a hard thing to fix, but it's kind of messy, which is why it's not been taken up yet. If the primary symptom of this issue is addressed separately, when we close this issue I can open an issue as a reminder to address the more general problem with handling the panics.

Verified in Zed commit 1ffe14f.
I happened to be working with a community user that mentioned a join crash they'd seen recently but were having difficulty reproducing. That led me to check for open bugs and, upon spotting this one, I did a binary search and confirmed it actually got fixed by the changes in #5239. Repeating the repro steps, we see the query now completes successfully without panic.
$ zed -version
Version: v1.17.0-48-g1ffe14f6

$ zed create -use all
pool created: all 2ltfe74xwOimYPbbuZqPWCe1ifr
Switched to branch "main" on pool "all"

$ zed load all.zng.gz
(1/1) 51.69MB/51.69MB 16.35MB/s 100.00%
2ltfej0g9ljMypTk5e8BNtiEowD committed

$ zed query -I program.zed
{resp:<IP_ADDRESS>,foo:"CvNzR22iDIjXuSwJyl"}
{resp:<IP_ADDRESS>,foo:"CvNzR22iDIjXuSwJyl"}
...
{resp:null(ip),foo:null(string)}
{resp:null(ip),foo:null(string)}

I've opened separate issue #5270 to track the secondary issue described above in https://github.com/brimdata/zed/issues/5097#issuecomment-2037867789.
Thanks @mattnibs!

Now that Arena has been backed out (#5278) I've been re-verifying issues that were fixed in the Arena era to make sure that prior issues haven't resurfaced, and it looks like this one has. Using the same repro steps shown above, here's this one happening once again now at current tip of main Zed commit 4a1ebf5. (For some reason, I'm now finding I often need to run the query twice to get a reliable crash, though in the one captured below I hit it on the first try.)
$ zed -version
Version: v1.17.0-64-g4a1ebf5b

$ zed create -use all
pool created: all 2mAZymARK4LOszZN5XIDCByaXIg
Switched to branch "main" on pool "all"

$ zed load all.zng.gz
(1/1) 51.69MB/51.69MB 17.27MB/s 100.00%
2mAZzUIE9GKtPhYzKY0VyPepUth committed

$ zed query -I program.zed

$ echo $?
0

The dump that appears when zed serve exits:
panic: runtime error: index out of range [3] with length 3

goroutine 202 [running]:
github.com/brimdata/zed/runtime/sam/expr.(*DotExpr).Eval(0xc00c692f00, {0x2b30ae0, 0x3a85260}, {{0x2b38e30?, 0xc019f7d710?}, 0xc000c9c8dd?, 0x4b8503e8?})
	/Users/phil/work/zed/runtime/sam/expr/dot.go:50 +0x24c
github.com/brimdata/zed/runtime/sam/expr.(*DotExpr).Eval(0xc00c692f40, {0x2b30ae0, 0x3a85260}, {{0x2b38e30?, 0xc019f7d710?}, 0xc000c9c8dd?, 0xc00c582258?})
	/Users/phil/work/zed/runtime/sam/expr/dot.go:42 +0x58
github.com/brimdata/zed/runtime/sam/expr.(*missingAsNull).Eval(0x2b38d90?, {0x2b30ae0?, 0x3a85260?}, {{0x2b38e30, 0xc019f7d710}, 0xc000c9c8dd, 0x1a})
	/Users/phil/work/zed/runtime/sam/expr/sort.go:143 +0x3d
github.com/brimdata/zed/runtime/sam/expr.(*Comparator).Compare(0xc00e132000, {{0x2b38e30?, 0xc00a4c00f0?}, 0xc00495f94a?, 0x0?}, {{0x2b38e30?, 0xc019f7d710?}, 0xc000c9c8dd?, 0x1660242?})
	/Users/phil/work/zed/runtime/sam/expr/sort.go:155 +0x1b6
github.com/brimdata/zed/runtime/sam/op/spill.(*MergeSort).Less(0xc01bee8050, 0x1, 0x0)
	/Users/phil/work/zed/runtime/sam/op/spill/merge.go:142 +0x7d
container/heap.down({0x2b4cde0, 0xc01bee8050}, 0x0, 0x2)
	/usr/local/opt/go@1.21/libexec/src/container/heap/heap.go:111 +0xef
container/heap.Fix({0x2b4cde0, 0xc01bee8050}, 0x2b38e30?)
	/usr/local/opt/go@1.21/libexec/src/container/heap/heap.go:84 +0x3d
github.com/brimdata/zed/runtime/sam/op/spill.(*MergeSort).Read(0xc01bee8050)
	/Users/phil/work/zed/runtime/sam/op/spill/merge.go:127 +0x59
github.com/brimdata/zed/zbuf.(*puller).Pull(0xc00de81ef8, 0x38?)
	/Users/phil/work/zed/zbuf/batch.go:88 +0x75
github.com/brimdata/zed/runtime/sam/op/sort.(*Op).sendSpills(0xc00c690d80, 0x2b48308?)
	/Users/phil/work/zed/runtime/sam/op/sort/sort.go:164 +0x5a
github.com/brimdata/zed/runtime/sam/op/sort.(*Op).run(0xc00c690d80)
	/Users/phil/work/zed/runtime/sam/op/sort/sort.go:109 +0x2ee
created by github.com/brimdata/zed/runtime/sam/op/sort.(*Op).Pull.func1 in goroutine 201
	/Users/phil/work/zed/runtime/sam/op/sort/sort.go:50 +0x66


Add cargo-spellcheck config

See this example PR in intaglio:

https://github.com/artichoke/intaglio/pull/142

I tried to do this but cargo-spellcheck panics on focaccia's sources. Tracking with upstream here:

https://github.com/drahnr/hunspell-rs/issues/2


Prevent pages from being navigated away from if file uploads are in progress

Currently, a contribution wizard doesn't prevent the user from saving an item it there are still uploads in progress. Ideally, we should be either preventing the item from saving until the file uploads have finished, or at least give them a warning.

Actually, this already happens. I just had autotest mode enabled


atomic examples/template

A feature of application-networks is that they are comprised of atomic functional units.
This example is not atomic since it couples IMAP attachment-read, transformation and file-write.
Close-coupling this valuable template with DataWeave doesn’t add anything to the example - in fact it distracts. There are plenty enough DW examples out there. I recommend stripping the DataWeave from this and adding a note possibly in the flow that transformations and further processing are possible. Logging the payload is enough to demonstrate functionality

Hi Paul, the example is about getting CSV attachments from emails and converting them to XML. Our recommended way of transforming CSV format to XML is by using DataWeave transformers. Not sure why should we split this simple task into different microservices, when the example is not related to the Application Network concept and it doesn't mention API-led approach.

I'm conveying to you what customers tell me - they like to have canonical
examples  that do exactly one thing, not conflate two things (not all
emails contain CSV, and not all emails require data to be turned into CSV
On Mon, Jun 6, 2016 at 10:06 AM, Pablo Mantellini<EMAIL_ADDRESS>wrote:

Hi Paul, the example is about getting CSV attachments from emails and
converting them to XML. Our recommended way of transforming CSV format to
XML is by using DataWeave transformers. Not sure why should we split this
simple task into different microservices, when the example is not related
to the Application Network concept and it doesn't mention API-led approach.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mulesoft/anypoint-examples/issues/41#issuecomment-223987243,
or mute the thread
https://github.com/notifications/unsubscribe/AFu-1gOeFqIkvQobGSAz0wYaWx9zAbpPks5qJDdjgaJpZM4IuZH0
.

--
Paul Anderson PhD
Principal Architect
mobile:<PHONE_NUMBER>
MuleSoft http://www.mulesoft.com/

Hi Paul, I understand the point and the feedback is always welcomed. The goal for these examples is to show some interesting use cases, and having only an email inbound with no transformations after it, does not differ much from just getting the component from the palette. In this case we are showing how to use the attachments after you got them from the email. We will take the feedback in consideration anyway and discuss with the team. Thanks!


Publish docker images to ghcr with release

It would be very convenient to have docker images for go-ftw. ghcr requires no set up or credential sharing and is a great option for OSS projects so recommend trying it out

Looks like this: https://github.com/anuraaga/go-ftw/pkgs/container/go-ftw

Seems reasonable. Can we fix EOL at EOF?

Shall we also update the readme with this option?

Seems reasonable. Can we fix EOL at EOF?

Sure fixed

Shall we also update the readme with this option?

Probably good to do this after a release (knowing that it's easy to forget though 😅 )

@anuraaga Do you mind using conventional commits syntax in PRs?

@fzipi Sure updated


Server source

Do you have a plan for server side? I am looking for server solution for Unity game so i wonder what is the language of our server?
Thank so much!

Yeah, I'm currently working on the multiplayer. I'm using Unity's built-in multiplayer system called UNet. I recommend you to watch this tutorial on the YouTube because it covers a lot of features of UNet.
My first choice was to use socket.io for both server and client side, but that would be too hard to implement, so I decided to use UNet because it's much easier to learn and build multiplayer games.

Great! I am looking for your update! Thank so much!


Scaling the image doesn't work sometimes

It happened in some other cases as well, but I was able to reproduce it when setting the aspect ratio, adjusting the crop frame, and then change the ratio back to the original one. After that it won't let me "zoom-out" anymore.

@mschonvogel Thanks for the reporting. I followed your steps and didn't reproduce the issue. Would you mind uploading the picture you were using for this test. So I can use the same picture to test it again. Thanks!

Sure, those are the simulator default photos (Uploaded as a zip because otherwise, GitHub compresses the images):
Archive.zip

@mschonvogel I released Mantis 1.2.1. Hope it solved this issue. Also, I remove the default implementations of handleFixedRatioSetted() and handleFixedRatioUnSetted() for CropToolbarProtocol. When you select a fixed ratio, handleFixedRatioSetted() will be triggered, then you can make some UI change to show a user that the current ratio is fixed. When the user tap the button for setting ratio again, handleFixedRatioUnSetted() will be triggered, then the user can adjust the ratio freely.

Also, I remove the default implementations of handleFixedRatioSetted() and handleFixedRatioUnSetted() for CropToolbarProtocol. When you select a fixed ratio, handleFixedRatioSetted() will be triggered, then you can make some UI changes to show a user that the current ratio is fixed. When the user tap the button for setting ratio again, handleFixedRatioUnSetted() will be triggered, then the user can adjust the ratio freely.

That works quite well!
However, now sometimes, I can't zoom in at all anymore:

Also, the gutter is moving once the image crop view is released:

@mschonvogel Thanks for the feedbacks! I release Mantis 1.2.2 which fixed the issues you mentioned.

Thanks, seems to work! @guoyingtao
But now I can't zoom fully out sometimes:

@mschonvogel Thanks for the feedback! I tried to fix this issue but caused other problems. I need some time to figure out a right way to fix it.

@guoyingtao almost 😀 I'm still able to reproduce this issue with v1.2.3:

I will keep working on it later. 😂

@mschonvogel I released Mantis 1.3.0. Hope it solved the zoom issue.

Updated to 1.3.0 but there's still a zoom issue:

@mschonvogel I did find this issue and fixed it before I released 1.3.0.
Can you help to check if you can find self.scrollView.updateMinZoomScale() in counterclockwiseRotate90() in CropView.swift?

Yes, I also did a hard clean before running the app @guoyingtao

I did the similar test and it seems OK
https://www.youtube.com/watch?v=WrOHDB7WymI&feature=youtu.be
Can you check if the Example project work for this issue?

I was also able to reproduce it in the latest example project

@mschonvogel Can you give me more details about your test device or simulator type information? Thank you!  I couldn't reproduce this issue on my phone and my simulators.
Can you also try to delete the App and reinstall it?

@mschonvogel I released Mantis 1.3.1. Can you try it to see if it solves this issue? Thanks!

Yes, fixed it! Thanks again! 🙂


Can you clarify which license this is under?

Cheers!

Good point. It's MIT-licensed. I've added a License.md file, and also a License-CLDR.md file, which is the  license for the CLDR data that this is based on.


Fallback handler could not load library. invalid ELF header.

I have a few native libraries I load into my Unity project, and it seems to me that the Unity install provided through your Docker instance is defaulting Unity to a 32 bit version?... Not sure if this is correct, but an objdump of my native libraries shows them as
file format elf64-x86-64

Am I correct in assuming that I should just build out 32 bit versions? If so, easy support for 64 bit systems should be default, or at least very easy to switch to.

@gblikas have you made any progress on this one?

Closing this until there are actual steps to reproduce this.
For all we know this is a platform mismatch, which requires the libraries to be built on the same platform as where unity is ran.


I have no idea how to install this plugin

Can you please provide instructions in the readme on how to install this plugin with :TSInstall ?

:TSInstall is for installing parsers ...
Install this like any other plugin, then do this in lua or wrap it in
lua << EOF
<config_here>
>> EOF

Won't hurt to mention this in the README.


charts version upgrade of stable/prometheus

change stable/prometheus to version 8.9.0

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: jstrachan
If they are not already assigned, you can assign the PR to them by writing /assign @jstrachan in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @busynight. Thanks for your PR.
I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Woops did not know it would make a PR. Apologies


Syntax highlighting flaws

Hi,
Solidity syntax highlighting seems a bit flawed on VSCode. Using cmd+shift+P>Developer: Inspect Editor Tokens and Scopes, you can verify that:

some ) characters are not recognized as punctuation.terminator.statement (some are)
some , characters are not recognized as punctuation.separator (some are)
in >=, the = character is not recognized as part of the keyword.operator.logic. (It is recognized as  keyword.operator.assignment instead).

The following image illustrates this using my custom theme:

If you give me some quick directives, I may be able to help fixing this (my experience with ANTLR V4 lexer and parser systems might come useful). I'd be happy to!

Those are great catches, thanks!
The syntax highlighting in vscode is handled by its own built-in system based on textmate grammars. You can find the file here:
https://github.com/NomicFoundation/hardhat-vscode/blob/98a39356645596e4725a37ef7cd52708e399e4aa/client/syntaxes/solidity.json#L3


Ignore missing deps file in neil new

Closes #241
Change Summary

when neil new output doesn't contain a deps file to update, do nothing (instead of throwing)
update CI task to have valid task names
update "latest version" test to expect clojure 1.12.0
add tests for assoc-project-meta!

Change Detail(s) by file

bb.edn - the ci task appears to call outdated(?) task names, so these are changed to run all the tasks describe in the Actions workflows
neil - updated just based on the run of gen-script - includes some changes that appear not have not been generated from prior commits
new.clj - only call assoc-project-meta! if the deps file exists in the directory created by neil new
dep_add_test.clj - newer version of clojure expected in test

Notes

might want to add the other test namespaces to test_runner, or maybe switch to using cognitect test runner... I didn't want to increase the scope of this change too much

[x] This PR corresponds to an issue with a clear problem statement.

[x] I have updated the CHANGELOG.md file with a description of the addressed issue.

[x] I have considered whether I should add more tests covering the code I've changed.

Good for merge now it seems?

Yep - I've got everything in that I'm aiming for.


added docker file

close #37
2 open things:

What is you mail? I'll write you down as maintainer
Do you have docker hub account? Should be simple to setup automated build

My email is here: https://github.com/Grunny/zap-cli/blob/master/setup.py#L30
And I've setup a Docker Hub account now, as "grunny".

Just as PoC, pushed it to Docker Hub here: https://hub.docker.com/r/grunny/zap-cli/
Let me know if that works as expected. :)

Cool, I've pushed the changes with your as maintainer. I'll check the image soon, but it looks good on docker hub! I've noticed you set tag per version, this is great!

I've fixed an issue, there was no entry point. Now I added it and I can do:

Thanks! Updated on Docker Hub. It worked for me with the following since I have ZAP running on the host rather than in another container:
$ docker run -it --net="host" --rm grunny/zap-cli:0.9.0 --port 1234 --zap-url http://<IP_ADDRESS> status
[INFO]            ZAP is running

For talking to ZAP running in another container, I assume you can just docker network create my-zap-net and use that network for both containers.

Yep, or use docker-compose


#70 issue resolved

Fixes Issue🛠

Closes #70
Description👨💻
Selecting the text and images or right-clicking anyway on the game screen is so annoying and creates disturbances to the user.

Type of change📄

[] Bug fix (No right-click menu appears)
[] Bug fix (No text can be selected)

How this has been tested✅
You cannot select any text or other components on this site and can't get the right-click menu anywhere.
You can check out this link.

Checklist✅

[] My code follows the style guidelines of this project
[] I am an Open Source Contributor

Screenshots/GIF📷
Before:::

You should not push to the main branch of anybody's repository directly. You have to create your own new branch and then push the changes to it. Go through this link properly. @suman-tewary


Don't show progress items with 0's

Currently the guide progress view shows the progress of each student as a semaphore. However 0s don't add any information. We should remove them.

@faloi

Removing them doesn't look so well, but disabling them seems better:


feat: added maintenance windows

Fixes https://github.com/aws/karpenter/issues/1302
Description
This adds Maintenance Windows as designed in https://github.com/aws/karpenter-core/pull/207/files
How was this change tested?

make presubmit
make apply and test some Maintenance Windows

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

141 of 258 (54.65%)  changed or added relevant lines in 17 files are covered.
11 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-3.02%) to 78.053%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/test/maintenancewindow.go
19
20
95.0%

pkg/apis/v1alpha5/maintenance_window_defaults.go
0
2
0.0%

pkg/apis/v1alpha5/maintenance_window_validation.go
0
3
0.0%

pkg/controllers/deprovisioning/controller.go
5
9
55.56%

pkg/scheduling/requirements.go
0
7
0.0%

pkg/controllers/deprovisioning/validation.go
13
22
59.09%

pkg/controllers/deprovisioning/emptynodeconsolidation.go
14
24
58.33%

pkg/apis/v1alpha5/maintenance_window_status.go
0
11
0.0%

pkg/controllers/deprovisioning/helpers.go
41
52
78.85%

pkg/apis/v1alpha5/zz_generated.deepcopy.go
33
92
35.87%

Files with Coverage Reduction
New Missed Lines
%

pkg/operator/controller/typed.go
2
93.55%

pkg/scheduling/requirements.go
2
93.57%

pkg/controllers/node/controller.go
7
73.53%

Totals

Change from base Build<PHONE_NUMBER>:
-3.02%

Covered Lines:
3745

Relevant Lines:
4798

💛  - Coveralls

Closing since we are planning to implement deprovisioning controls through another mechanism.


I'm going to move the conversation over there, thanks!


feat: Show spinner animation when adding plugins

Closes #7803
added yaspin spinner animation for 'add plugin' service

@raiatul14 Would you still be interested in getting this across?

@raiatul14 Would you still be interested in getting this across?

@edgarrmondragon sure. If you feel something is missing then please let me know. Thanks!

@raiatul14 Would you still be interested in getting this across?

@edgarrmondragon sure. If you feel something is missing then please let me know. Thanks!

I think the current implementation is missing what's probably the most important long-running command, i.e. meltano install. Do you think it's worth wrapping meltano.cli.utils:install_plugins with the yaspin context so it's applicable in other places?


chore: Fix link in the README

Small README change.

OK, thanks! I have signed the CLA and renamed the commit.


master_to_vip_slave

Hi, taichi
I'm new to UVM.I want to know that how could I use this repo building a"master to VIP slave" environment to test my AXI master.

Yes, I read the sample before, but I still don't known how to replace the sample's vip master with my dut master.


chore: replace all lint with special lint

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b2ca7eb) 10.75% compared to head (9e803d3) 10.75%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #10   +/-   ##
=======================================
  Coverage   10.75%   10.75%
=======================================
  Files           3        3
  Lines         911      911
=======================================
  Hits           98       98
  Misses        813      813

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Views Issue

Other than management accounts. Client can also view roles management views like he can add, update or delete packages.

It's resolved. After downloading user has to remove Change web\views.py Categories function from this to:
def categories(request):
    if request.user is not None:
        person = Person.objects.get(id=2)

    else:
        person = Person.objects.get(user_id=request.user.id)
    context = {
        'categories': Tag.objects.all(),
        'person': person
    }
    return context

to this:
def categories(request):
    context = {
        'categories': Tag.objects.all()
    }
    return context

and then create Two accounts initially. First for management. Second for non-management.


Bug: Table deletion with keyboard works buggy

Lexical version: the latest (v0.12.6)
Steps To Reproduce
when the last cell is empty:

go to the playground
enter table and make make the last cell empty
select table by keyboard(shift + arrow keys) and delete
now table and tablerow remains
when you type something, it inserts text on tablerow directly.
-> this triggers some bug. i.e. pressing ENTER breaks the editor as #5516

https://github.com/facebook/lexical/assets/40269597/566fdb02-396e-4e6e-9532-497ec7cf8d40
even when the last cell is not empty

enter table
select table by keyboard with next sibling as anchor
delete
now table remains
when you type something, it inserts text on table directly.
-> this triggers some bug. i.e. pressing ENTER breaks the editor as #5516

https://github.com/facebook/lexical/assets/40269597/730f5387-f348-4c2b-919b-6565bc094500

Link to code example:

The current behavior

delete remains table and tablerow

The expected behavior

it cleans table and its children then inserts a new paragraph as we delete it by selecting with mouse

https://github.com/facebook/lexical/assets/40269597/57cfcd8a-b104-4f94-ad8b-d1eeb2aa3330

This might be resolved completely after introducing scheme #3833

#3833

https://github.com/facebook/lexical/assets/7893468/b4bbf493-fe06-452e-91bc-0cfc87a33e7d
I started looking at this yesterday and I'm unsure on the right place to fix this in. Since deletion behaviour is different depending on the selection direction, as captured in the video, if it's top to bottom, it's leaves a 'table' and 'tablerow', if it's bottom to top, it leaves only 'table'. This issue is only when the selection for deletion ends (or starts) exactly on the last table cell. If the table is inbetween two paragraphs, deletion works correctly.
@zurfyx can you point me in the right direction for fixing this. I started looking into modifying the deleteCellHandler, but unsure if this needs a different deletion approach.


Proxmox Cloud-init deploy, failing at "Copy vip manifest to first master" task.

The issue is when running ansible-playbook site.yml The playbook runs up until the "copy vip manifest to first master" task, at which point it fails.
Expected Behavior
Playbook should run all the way through, setup an HA cluster running with 3 control nodes and 7 worker nodes.
Current Behavior
Ansible playbook will run just fine until the task "copy vip manifest to first master", then stop, showing a failure for all 3 master nodes, with all 7 worker nodes going through the playbook just fine.
Steps to Reproduce

Fork the repo
Changed inventory to match my local lan IPs for VMs
Changed variables in all.yml to match local environment (including IPs since I'm on a 10.0.0./24 network)
Adjusted ansible.cfg to inventory location, added private ssh-key.
Removed raspberry-pi role from playbook

Context (variables)

Operating system:
Hypervisor: Proxmox VE 8
Ansible Controller OS: Ubuntu 22.04
Node OS: Ubuntu 22.04 based off jammy cloud init image.
Hardware:
Intel i9 13900
RAM 128 GB DDR5 5200MHz
MSI Pro Series Z790 Motherboard
4 NVMe RAID-10 Array (4 x 1TB)
2 HDD MIRROR Array (2 x 6TB)
Variables Used
all.yml
k3s_version: "v1.25.12+k3s1"
ansible_user: ansible
systemd_dir: "/etc/systemd/system"

flannel_iface: "eth0"

apiserver_endpoint: "<IP_ADDRESS>"

k3s_token: "NA"

extra_server_args:

  {{ extra_args }}
  {{ '--node-taint node-role.kubernetes.io/master=true:NoSchedule' if k3s_master_taint else '' }}
  --tls-san {{ apiserver_endpoint }}
  --disable servicelb
  --disable traefik

extra_agent_args:

  --flannel-iface={{ flannel_iface }}
  --node-ip={{ k3s_node_ip }}

kube_vip_tag_version: "v0.5.12"

metal_lb_speaker_tag_version: "v0.13.9"
metal_lb_controller_tag_version: "v0.13.9"

metal_lb_ip_range: "<IP_ADDRESS>-<IP_ADDRESS>"

Hosts
host.ini
[k3s_cluster:children]
master
node

[master]
node01 ansible_host=<IP_ADDRESS>
node02 ansible_host=<IP_ADDRESS>
node03 ansible_host=<IP_ADDRESS>

[node]
node04 ansible_host=<IP_ADDRESS>
node05 ansible_host=<IP_ADDRESS>
node06 ansible_host=<IP_ADDRESS>
node07 ansible_host=<IP_ADDRESS>
node08 ansible_host=<IP_ADDRESS>
node09 ansible_host=<IP_ADDRESS>
node10 ansible_host=<IP_ADDRESS>

Possible Solution

[x] I've checked the General Troubleshooting Guide

k3s_ansible_vip_manifest_playbook_error.txt

I actually resolved this by just remaking the nodes from cloud-init and changing from node01, node02 etc naming scheme to control-node01... and worker-node01... Not sure why that made a difference, but it did! I suspect there's likely something else I did right this time that I just thought I'd done correctly previously.


chore(api): overlay class audits #6372

This PR does the following:

Adds a new utility method for parsing string|string[]|{key/value} to ngClass-like object
Adds a new utility method for parsing a ngClass-like object to string array
Updates overlay implementation to accept ngClass-like object
Adds panelClass to date picker
Deprecates extraClasses to panelClass in snackbar
Deprecates class input to panelClass and accepts ngClass-like object in menu
Updates dialog implementation to ngClass like object

I really didn't like the fact I had to add this to the CDK. I originally had it as a utility inside material but the overlay lives in the CDK and needed it there too. @jelbourn - do you have any thoughts on better place for this?
This is still very WIP.

Closing in favor of #8056


Fix #118: Updates button css to turn to pointer

Thanks for helping out, we have incorporated your changes into another pull request.


There is a new Secretless release that includes verify-full support for MySQL and PG

AC:

[ ] The CHANGELOG in the version bump PR has been reviiewed by the Product Owner
[ ] The manual tests have been run for the code on master in the version bump PR
[ ] There is a new Secretless tag for the set of changes on master
[ ] There is a github prerelease for the tag that includes a copy/paste of the change log and includes attached artifacts produced in the tag pipeline by goreleaser
[ ] The changeset has been reviewed with the Quality Architect to determine if any performance tests (short- or long-term) are required for this set of changes
[ ] Any open docs issues for the changes included in the release have been made and are ready to be published
[ ] If the docs are published and the performance tests aren't needed or are complete and passing, then the github release is moved from a prerelease to a full release, and a new stable image is produced as a copy of the new tag and pushed to DockerHub

This is available in https://github.com/cyberark/secretless-broker/releases/tag/v1.7.0


Ability to display preparse field on index page

It would be great if we could add a column to the element index to display the value of the preparse field. Is it possible? :)

Oh damn, duplicate of #33


value is not a controlled input ?

currently I would like to have a maximum value for my input. As currently we don't support max and min, the work around is to prevent the value to be changed in setState if value > maximumValue.
But, the displayed value is still changed Although the value in state is not changed.

#78 some created that PR.. i'm waiting a merge  :/


precision problem

I saved a tensor in torch.
When I load it in torch, everything is fine.
but When I load it with lutorpy, I lose some precision.
For example the original tensor contains this number: -1.9356058835983
but when I load the tensor in python I get this: -1.9325
I don't know why!
Here is my code:
`import lutorpy as lua
import numpy as np
inputs=torch.load('inp.t7')
print inputs[1][1][1]
`

Hi, I think you are not losing any precision, it's just a printing format:
t = torch.DoubleTensor(1)
t[0] = -1.9356058835983
print t
print(t[0])

output:
-1.9356
[torch.DoubleTensor of size 1]

-1.9356058836


Updated triggers.md with timestamp in milliseconds

I've updated this doc to reflect correct trigger timestamp from commented description ("fire in 3 hours") as it has to be in milliseconds not in seconds (10800).

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Had me worried so I double checked

Closing as it is false premise - that the math is wrong and the example is wrong.
Math appears correct, example appears correct and does not appear to need any change.

@mikehardy isn't it still wrong from your screenshot? in docs it states 10800 rather than 10800000?

@mikehardy isn't it still wrong going by your screenshot? in docs it states 10800 rather than 10800000?

Well that's what I was referring to :)

@vzhovnitsky reopened as I think that makes sense... but maybe just put + 10800000 rather than the calculation? Also, could you please sign the cla?

Am I missing something? I must be missing something.
In docs it says milliseconds: https://notifee.app/react-native/reference/timestamptrigger#timestamp
I just did the math and the result I got for the math being done is the quantity of milliseconds in 3 hours
I don't understand?

@vzhovnitsky reopened as I think that makes sense... but maybe just put + 10800000 rather than the calculation? Also, could you please sign the cla?

I've signed the CLA.
Well, I've wrote 1000 (second) * 60 (minute)* 60 (hour)* 3 (hours), because It's just clearer to read in example.

Am I missing something? I must be missing something. In docs it says milliseconds: https://notifee.app/react-native/reference/timestamptrigger#timestamp I just did the math and the result I got for the math being done is the quantity of milliseconds in 3 hours I don't understand?

The example states 10800 which is 0.003 hours, I was simply proposing to change it to 1000 * 60 * 60 * 3 = 10800000 = 3 hours :)

Also +1 for another duckduckgo user haha


Add testing utilities to documents

This PR adds several utility functions that are missing to the document.
This PR fixes #2880

@delta2323 ping? (I can takeover if you don't have time!)

@kmaehashi Sorry for late reply, Could you take over the PR?


fix: Order History. Sold by: "Ships from" is displayed for "Pickup" fulfillment (PX-4257)

The type of this PR is: Bugfix
This PR resolves PX-4257
Description
"Pick up ..." - are displayed when "Pick up" fulfillment chosen
"Ships from..." - are displayed when "Shipping" fulfillment chosen
PR Checklist (tick all before merging)

[x] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[x] I have tested my changes on iOS and Android.
[x] I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
[x] I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added an app state migration, or my changes do not require one. (What are migrations?)
[x] I have added a CHANGELOG.yml entry or my changes do not require one.

🛳🛳🛳


Video Upload not working

Simple video upload  using latest release 1.1.6 and sample code from Youtube API V3 is not working and giving 500 internal server error.
Fatal error: Class 'Google_Service' not found in google-api-php-client/src/Google/Service/YouTube.php on line 32'
Code:
https://developers.google.com/youtube/v3/code_samples/php#upload_a_video
Details:
http://stackoverflow.com/questions/34954443/how-to-upload-video-to-youtube-using-google-api-php-client-library-and-youtube-a

You need to include the src/Google/autoload.php file in your application.


[Access Request] report 7391 "Whse. Get Bin Content" - CalcQtyUOM

Could you please change the access scope of the following procedure to protected?
//+Change
//-local procedure CalcQtyUOM(QtyBase: Decimal; QtyPerUOM: Decimal): Decimal
protected procedure CalcQtyUOM(QtyBase: Decimal; QtyPerUOM: Decimal): Decimal
//-Change
begin
  ...
end;

Original Issue for Reference: https://github.com/microsoft/ALAppExtensions/issues/20049

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 11018.


Display filename and path on edit view

@johno I have gone ahead and implemented this feature ... I'm going to implement a couple of other features before I a submit a PR with all of them ... but here's what it looks like!


Version Packages

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
<EMAIL_ADDRESS>Patch Changes

⚠ Fix wait for the first non-stale result when using await executeQuery, by @JoviDeCroock (See #2410)

@JoviDeCroock when new release is expected?
Waiting for fix https://github.com/FormidableLabs/urql/issues/2409 ;) Is there some alpha channel?


web/ui/react-app: update dependencies

Fix 2 lodash security issues:

https://snyk.io/vuln/SNYK-JS-LODASH-1018905 fixed by https://github.com/lodash/lodash/commit/c4847ebe7d14540bb28a8b932a9ce1b9ecbfee1a
https://snyk.io/vuln/SNYK-JS-LODASH-1040724 fixed by https://github.com/lodash/lodash/commit/3469357cff396a26c363f8c1b5a91dde28ba4b1c

From a quick look, I couldn't find usage of lodash in the UI code, it's probably only used at build time (not a JS expert though).

cc @juliusv

Thanks! :+1: Yeah, as far as I can see, this shouldn't directly affect us.


add avg_loss calc to run_benchmarks.py

This small modification adds average loss calculation.

PPL is exponantial of loss, so no need to plot both of them. (Agreed with Alx on discord)
Closing.


Enable the use of south migrations

social_auth.fields.JSONField needs an introspection rule passed. We can use blank rules because it directly descends from a builtin field and does not add any properties to the parent model.

How would I add this snippet if I don't have access to the social_auth files since I installed using pip on Heroku?

@fahdoo, try the last HEAD

It worked, sort of. The South migration went well, but now I'm getting this error:
Error importing request processor module social_auth.context_processors: "cannot import name BACKENDS"

Any idea whats causing this?
Also I used this line to get the latest code (I'm new at this so correct me if I'm wrong):
pip install -e git+https://github.com/omab/django-social-auth.git#egg=django-social-auth

I've fixed a syntax error, my bad.

Thansk for the quick response!

Works?

Yes, that fixed it


Why only views?

Hi,
I like your gem and it works just fine for views, but ONLY for views. The reason it only works for views is that you concat the SQL from the files you have to create in db/views onto CREATE VIEW ....
Instead of doing this and having a gem specifically suited for views, you could transform the gem to allow running any sql after your migrations. This way you can use CREATE FUNCTION .... as well, or 'CREATE RECURSIVE VIEW...', etc.
It seems like you have all the code required for this already there, so it would be a small step to add other things like functions to the gem; db/functions/....
Kind regards :)

Hello!
Thank's for your review!
I must confess your idea is great, I'll change the code to allow the use of this gem for others structures like function etc...
Regards,
Yacine.

Hi,
Thanks for your quick response :). Great that you will look into creating other structures with your gem too.
We have been playing around in the meanwhile with looking at seeds for creating a function. The (only) problem with this is the order in which you want to create functions, views, tables, etc. Seeds have to be run after a migration, when you have and INDEX that requires a certain FUNCTION to exist you will have to make sure that the function is created before the index. Seeds run after the migration, so in our case we cannot seed the FUNCTION so it looks like it must be done in a rake task before schema loads, etc.
Just FYI ;)

On 06 Jul 2015, at 13:55, Yacine Petitprez<EMAIL_ADDRESS>wrote:
Hello!
Thank's for your review!
I must confess your idea is great, I'll change the code to allow the use of this gem for others structures like function etc...
Regards,
Yacine.
—
Reply to this email directly or view it on GitHub https://github.com/anykeyh/rails_db_views/issues/2#issuecomment-118832390.

I understand your need:

You make index with value transformed by function at first, so you would be able to destroy/create functions before doing the migration (and creating then your new indexes).

But I didn't understand the seeds part, can you explain me more?
I'm planning to review the configuration code, with a DSL like structure able to append/prepend the change, able to use every type of structures etc...
Thanks!

Just to avoid confusion I’ll try to explain again:
When you create an index that uses a custom function the function will have to exist before you create the index. You cannot create an index using a function that doesn’t exist. So:
— Pseudo code
CREATE INDEX some_index ON customers (my_function(id, e-mail));

This will not work if we do not create my_function first. Which is logical. This means that we will have to create functions BEFORE the migration. And because the database has to exist, we will have to create the functions AFTER the db rake tasks create the database.
Now for the seeds. This gem does not allow us to create functions (yet). So we decided to put the sql for creating the functions and views in seeds. Using the seed bank gem we can create a file called views.seeds.rb under db/seeds. In this we put a dependency on the functions.seed.rb so that we create functions before the views. These seeds will need to be ran manually on production, but they run automatically when you do rake db:reset on development.
First problem
So far so good. BUT!: We cannot create an index using the functions we specified in functions.seeds.rb. This is because when running things like rake db:reset the migrations (or schema:load) run first and then the seeds run. An INDEX is part of the schema.rb, so that loads first. If we were to create an index that uses a function it would end up being loaded before the seeds run. Therefore, it wouldn’t work, as Postgres (or another db) would throw an error saying that the function my_function doesn’t exist.
To summarise for this gem: When creating FUNCTIONS make sure to do so before the migration because things like INDEX and VIEW may depend on them. Doing this in seeds will work fine for VIEW, but will not work for FUNCTION if the function is used in an INDEX.
Hack: Note that an ‘hack’ would be to create the index in the seeds as well, but that would be not very consistent and it would get unclear where which pieces of the database are defined.
Second problem
Now tests come into play and the seed setup doesn’t really work anymore. Here the same issue comes into play regarding the order in which things are created. We do not want to run all our seeds on the test database. Also, running the seeds, in our case using the seed bank gem, would require us to invoke a rake task that runs these before the test suite is run. After some issues regarding the invoking of these rake tasks, etc we decided to put the code that creates our views and functions in the views.seeds.rb and functions.seeds.rb files into plain ruby files: views.rb and functions.rb and load these into the seeds files and load them before the test suite runs like so:
In rails_helper.rb:
   config.before(:suite) do
      DatabaseCleaner.clean_with(:truncation)
      load ‘./db/seeds/functions.rb’
      load ‘./db/seeds/views.rb’
   end

This way the views and functions are always created before the test suite runs.
Note a side-effect of always running the create commands is that we have to keep in mind that the FUNCTION or the VIEW we are trying to create could already exist. So we use the CREATE OR REPLACE VIEW and CREATE OR REPLACE FUNCTION command instead of ‘just’ using CREATE in both cases.

Ok I understand well now the problem!
I'm think about managing the configurations for something like this:
(Pseudo-ruby)
# in config/application.rb for example
# Register your own SQL fragment manager
config.rails_sql_view.register :functions do
  apply_on_files 'db/functions/*.sql'

  # do before the migration process
  execute before: "db:migrate" do |filename, sql_fragment|
    "DROP FUNCTION IF EXISTS #{filename};"
  end

  # Here it will trigger also before database reset
  execute before: "db:migrate", after: "db:create" do |filename, sql_fragment|
    "CREATE FUNCTION #{filename} AS #{sql_fragment};"
  end

  #You can set a "after" trigger:
  after do |filename, sql_fragment|
    #Do nothing in your case
  end
end

It will keep the current system working well for views and allow you to use this gem for your function need.
I just need to check if db:create is used inside db:reset.
The order between functions and view etc... will be the same than the order of the call to the config.rails_sql_view.register method.

Yes that looks good.
The only thing I am wondering is whether you would want to append the CREATE ... to the sql_fragment. Why not allow a developer to write the complete create statement himself?
One thing I had to do with the views when using the gem was rewrite my create statement. I wanted to do:
CREATE RECURSIVE VIEW.... but I had to rewrite it to: WITH RECURSIVE ...
What is the added value of wrapping the SQL in the CREATE ...?

Never mind 'REPLACE'. DROP IF EXISTS is much nicer. I just got some errors with CREATE OR REPLACE. Apparently 'REPLACE' tries some mapping of columns, etc.
Fact remains that it would be nice to not have to write the inner fragment, but being allowed to write the whole thing. This way you can also include some generic 'before_migration' and 'after_migration' directories in db/ for more generic scripts that need to run... well before and after migrations ;).

After playing with this for 15 minutes and being amazed at how well this fits in the rails ecosystem and why I've never come across this pattern before, I ended up with this exact question. And started playing around with a db/functions folder before checking the issues on the repo.
Did you ever get to update the gem?

Hello!
I would really love to fix the gem, but I'm quite busy on others projects theses days.
According to the fact some people think this is very useful, I'll put it in priority of my asana's free time  tasks ;-)
Otherwise, feel free to contribute, I would merge your change with pleasure.

Hey! I get some time to fix it. Now it's working with functions, and the code has been refactorized.


ARROW-11408: [Rust] Add window support to datafusion readme

Codecov Report

Merging #9343 (f7ad81c) into master (ab5fc97) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #9343      +/-   ##
==========================================
- Coverage   81.89%   81.88%   -0.01%
==========================================
  Files         215      215
  Lines       52988    52988
==========================================
- Hits        43392    43391       -1
- Misses       9596     9597       +1

Impacted Files
Coverage Δ

rust/parquet/src/encodings/encoding.rs
95.24% <0.00%> (-0.20%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff1d185...f7ad81c. Read the comment docs.

Codecov Report

Merging #9343 (f7ad81c) into master (ab5fc97) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #9343      +/-   ##
==========================================
- Coverage   81.89%   81.88%   -0.01%
==========================================
  Files         215      215
  Lines       52988    52988
==========================================
- Hits        43392    43391       -1
- Misses       9596     9597       +1

Impacted Files
Coverage Δ

rust/parquet/src/encodings/encoding.rs
95.24% <0.00%> (-0.20%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff1d185...f7ad81c. Read the comment docs.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.88%. Comparing base (ab5fc97) to head (f7ad81c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9343      +/-   ##
==========================================
- Coverage   81.89%   81.88%   -0.01%
==========================================
  Files         215      215
  Lines       52988    52988
==========================================
- Hits        43392    43391       -1
- Misses       9596     9597       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


make inline.sh more portable

some implementations of the 'od' utility, in hex mode, will not print a leading 0 if the byte is less than 0x10. this causes the existing sed script in inline.sh to create a file which does not compile.
this patch fixes this issue in a manner that should also be portable to sed implementations which do
not support gnu extensions.
i have tested it with the following:

gnu sed and od
netbsd sed and od
suckless sed and od

ninja built successfully in each case.

pushed the wrong file, ignore


Include template docker as part of customization entry

https://github.com/UCSB-PSTAT/devcontainer-template

Completed!


Add additional functions

I needed a bounds_for_viewport() function to help me get the bounding box that matches a particular screen map viewport, e.g. 640 x 480 with some center and zoom level.

(Ack! I swear I commented here weeks ago. I guess I forgot to hit the comment button?)
@malthe I appreciate the PR and hate to say no to contributions, but I don't want screen resolution to be a concern of mercantile.


Changing sort order of assignments incorrectly changes course information

Describe the bug
When the sort order of some assignments is updated, the course information box changes to display inaccurate information even though no change is needed.
To Reproduce
Go to the assignment list. Change the sort order (or “change” it to the same value). Note that the number of assignments in the separate groups changes while the total remains constant.
Expected behavior
Number of assignments is unchanged.
Screenshots

“2 + 2 = 5”
Environment
irrelevant

Rhanks for reporting. Will be fixed in the next release.


x86_64 SMP problem

I modified the script file:
#!/bin/bash
SERIAL_PORTS="-serial file:./../build/serial.txt -serial file:./../build/memlog.txt"
if [ ! -z "$NO_SERIAL_PORTS" ]; then
SERIAL_PORTS=""
fi
AIO="native"
if [ ! "$(uname -s)" == "Linux" ]; then
AIO="threads"
fi
qemu-system-x86_64 -smp 4  -m 512
-drive file=./../build/hdd.img,if=ide,media=disk,cache=writeback,aio=$AIO,index=0,format=raw
-drive file=./../build/pedigree.iso,if=ide,media=cdrom,cache=writeback,aio=$AIO,index=2,format=raw
-boot d -vga std $SERIAL_PORTS -rtc base=utc $*
However, the system enters the exception handler...

Thanks for the report, I'm looking into this.
The GPF on startup is fixed locally (race condition), but there's a nagging bug that leads to running code at 0x0 - but only if -smp is >1. Working on resolving that now.

Thanks for reply.  : )

Please give the https://github.com/jmolloy/pedigree/tree/fix-multiprocessor branch a go, does it work for you?
I'm still working on some concurrency problems, but that should be much more functional than the code from a few days ago.

The fix-multiprocessor branch has now been merged back into develop. I'll close this for now, please feel free to re-open if there's any further issues that arise with the SMP support on x86_64. Thanks!


Looking for starters in ordered, unordered and task list inside editor

Markwon version: 4.3.1

When I specify "*" or "1." or "- [ ] " in the editor the syntax is detected. Now when I tap the "Return/Enter" key I would like to continue the list with presenting the syntax automatically in the next line, until a "double return/enter" is pressed. As the text watcher is handled inside markwon, Is there any example plugins for similar case?

Can someone point me to something to get me started on this?

Hello @shivakumars !
In order to achieve that you will have to create own TextWatcher. Unfortunately it must be separate from other markdown logic and operate independently. It will have to wrap MarkdownEditor text-watcher also... Well, there are a lot of things to consider, but you can start with:
public class MarkdownNewLine {

    @NonNull
    public TextWatcher wrap(@NonNull TextWatcher textWatcher) {
        return new NewLineTextWatcher(textWatcher);
    }

    private static class NewLineTextWatcher implements TextWatcher {

        private final TextWatcher wrapped;

        private boolean selfChange;

        // this content is pending to be inserted at the beginning
        private String pendingNewLineContent;
        private int pendingNewLineIndex;

        // mark current edited line for removal (range start/end)
        private int clearLineStart;
        private int clearLineEnd;

        NewLineTextWatcher(@NonNull TextWatcher wrapped) {
            this.wrapped = wrapped;
        }

        @Override
        public void beforeTextChanged(CharSequence s, int start, int count, int after) {
            // no op
        }

        @Override
        public void onTextChanged(CharSequence s, int start, int before, int count) {
            // ignore callback if we are changing text
            if (selfChange) {
                return;
            }

            // just one new character added
            if (before == 0
                    && count == 1
                    && '\n' == s.charAt(start)) {
                int begin = -1;
                for (int i = start - 1; i >= 0; i--) {
                    if ('\n' == s.charAt(i)) {
                        begin = i + 1;
                        break;
                    }
                }

                // start at the very beginning
                if (begin < 0) {
                    begin = 0;
                }

                // match begging of the new line:
                // - if it matches required markdown (bullet, ordered, task-list, quote, etc)
                //   set mark `pending`
                // - if it matches, but there is no content (pending was inserted, but no content
                //   added, mark this line for deletion

                // match content between `begin / start`

                if (/*matches*/) {
                    if (/*has-content*/) {
                        pendingNewLineContent = /*content, for example `*`, `-`, `- [ ]`, etc*/;
                        pendingNewLineIndex = start + 1;
                        clearLineStart = clearLineEnd = 0;
                    } else {
                        pendingNewLineContent = null;
                        clearLineStart = begin;
                        clearLineEnd = start;
                    }
                } else {
                    // reset these values
                    pendingNewLineContent = null;
                    clearLineStart = clearLineEnd = 0;
                }
            }
        }

        @Override
        public void afterTextChanged(Editable s) {
            if (selfChange) {
                return;
            }

            if (pendingNewLineContent != null || clearLineStart < clearLineEnd) {
                selfChange = true;
                try {
                    if (pendingNewLineContent != null) {
                        s.insert(pendingNewLineIndex, pendingNewLineContent);
                        pendingNewLineContent = null;
                    } else {
                        s.replace(clearLineStart, clearLineEnd, "");
                        clearLineStart = clearLineEnd = 0;
                    }
                } finally {
                    selfChange = false;
                }
            }

            // NB, we assume MarkdownEditor text watcher that only listens for this event,
            // other text-watchers must be interested in other events also
            wrapped.afterTextChanged(s);
        }
    }
}

And we haven't touched even markdown yet! So, I think this should get you started. You can post to this thread if you find something else or would like to share your final solution


[ENHANCEMENT] Remove the helm-install/delete related PODs when an old HelmChart JOB is deleted.

Is your enhancement related to a problem? Please describe.

When enable/disable addon frequently, with the enhancement of PR https://github.com/harvester/harvester/pull/4127, the background helm jobs are removed, but the related PODs are left there. Original design of helm-contoller, did not expect the HelmChart will be removed, it preferred to keep those PODs left for debug.
https://github.com/k3s-io/helm-controller/blob/master/pkg/controllers/chart/chart.go#L55
chart.go
deletePolicy         = metav1.DeletePropagationForeground
Describe the solution you'd like

When Harvester addon starts an new operation (enable/disable/update) , it will try to delete last time operation's left JOB. As an further enhancement, it could also try to delete the related PODs as well ( Set the policy as ...Background and k8s will do it).
Harvester Addon ----> HelmController HelmChart -----> HelmController helm-install/helm-delete JOB ----> helm-install/helm-delete POD ....
Describe alternatives you've considered

Write in documents, reminder users to delete those PODs manually.
Additional context

cc @chrisho Lets track in this issue.

This enhancement needs more investigation, and consider how to contribute to upstream helm-controller, with PR4127 related workarounds together.

Close issue, replaced by PR https://github.com/k3s-io/helm-controller/pull/232.


Warning with Laravel mix (scss)

With a fresh Laravel install and a fresh Tailwind install.
I have a simple app.scss with only two lines:
@tailwind preflight;
@tailwind utilities;

And a webpack.mix.js with a few lines:
let mix = require('laravel-mix');
let tailwindcss = require('tailwindcss');

mix.js('resources/assets/js/app.js', 'public/js')
  .sass('resources/assets/sass/app.scss', 'public/css')
  .options({
    postCss: [
      tailwindcss('./tailwind.js'),
    ]
  });

My tailwind.js is the default one.
When I run npm run build, it "works" (I have a CSS built and I can use it) but I displays a warning (I don't have this warning without tailwind)
WARNING in ./node_modules/css-loader?{"url":true,"sourceMap":false,"importLoaders":1}!./node_modules/postcss-loader/lib?{"sourceMap":true,"ident":"postcss","plugins":[{"version":"6.0.13","plugins":[null,null,null,null,null,null,null,null,null],"postcssPlugin":"tailwind","postcssVersion":"6.0.13"},null]}!./node_modules/resolve-url-loader?{"sourceMap":true,"root":"/XXXXXX/node_modules"}!./node_modules/sass-loader/lib/loader.js?{"precision":8,"outputStyle":"expanded","sourceMap":true}!./resources/assets/sass/app.scss
(Emitted value instead of an instance of Error)   resolve-url-loader cannot operate: CSS error
  /XXXXXX/resources/assets/sass/app.scss:3:316: missing '{'
  at error (/XXXXXX/node_modules/css/lib/parse/index.js:62:15)
 @ ./resources/assets/sass/app.scss 4:14-266
 @ multi ./resources/assets/js/app.js ./resources/assets/sass/app.scss

Don't know why. Any clue?

Hey @rap2hpoutre! See this issue for details about the source of this problem and the available workarounds:
https://github.com/tailwindcss/tailwindcss/issues/48#issuecomment-341423237

@rap2hpoutre Enable sourcemaps mix.sourceMaps()

@adamwathan Thanks! I disabled processCssUrls (still I did not understand what it does, so it must not be important!)


Update Parse server on ubuntu

How can I update latest version of Parse Server however I am using parse Example server on Ubuntu where is my installed server version is 2.2.12 and at this time the new release parse server version is 2.2.15, I know how to update Parse server but did not know how to update it using parse example server.
Please help

@sashakhail
-git clone https://github.com/ParsePlatform/parse-server-example.git <NEW_DIRECTORY_NAME>

npm install
copy your index.js, cloud code, push certificates etc from the old directory
keep your original directory as backup (trust me)

so every time a new directory? @acegreen

@Sadmansamee every time you clone a new instance yes. In terms of backup, I like to leave 2 backups, and my current version. So I'm always left with 3. For example
2.1.15, 2.1.16, 2.1.17
When 2.1.18 comes, I would install it first as a new instance and eventually delete 2.1.15... And so on.


error: command 'cmake' failed with exit status 1 when running tox

 -- Running cmake for pyarrow
  cmake -DPYTHON_EXECUTABLE=/Users/robinlinacre/Documents/data_linking/splink_graph/.nox/tests-pandas-1-0-1-pyspark-3-0-1/bin/python  -DPYARROW_BOOST_USE_SHARED=on -DCMAKE_BUILD_TYPE=release /private/var/folders/y2/25dftcwj5kv9lqs7fzsyxf6h0000gp/T/pip-install-_0xduqi2/pyarrow
  error: command 'cmake' failed with exit status 1
  ----------------------------------------
  ERROR: Failed building wheel for pyarrow
Failed to build pyarrow
ERROR: Could not build wheels for pyarrow which use PEP 517 and cannot be installed directly
WARNING: You are using pip version 20.2.4; however, version 21.1.3 is available.
You should consider upgrading via the '/Users/robinlinacre/Documents/data_linking/splink_graph/.nox/tests-pandas-1-0-1-pyspark-3-0-1/bin/python -m pip install --upgrade pip' command.
nox > Session tests(pandas='1.0.1', pyspark='3.0.1') failed.
nox > Ran multiple sessions:
nox > * tests(pandas='0.25.3', pyspark='2.4.5'): failed
nox > * tests(pandas='1.0.1', pyspark='2.4.5'): failed
nox > * tests(pandas='0.25.3', pyspark='3.0.1'): failed
nox > * tests(pandas='1.0.1', pyspark='3.0.1'): failed

after looking at this issue
https://github.com/streamlit/streamlit/issues/2774
ill try adding the following line to toxfile to perhaps solve it?🤞
session.run("python", "-m", "pip", "install", "--upgrade", "pip")

It could be that this is the reason if this error happens in python 3.8:
https://issues.apache.org/jira/browse/ARROW-7076

Also here it seems SPARK-29536 bug says that

Pyspark 2.4.x doesnt work with python 3.8
only pyspark 3.x works with python 3.8

Now its passing on the 3.0.1 parts and failing on the 3.4.5.
However the failure is due to SPARK-29536  Spark 2.4.x doesnt work with 3.8. So the issue is now closed


Not work

OS: Android 5.0/Windows Phone 10
Browser: WebView/Edge

I don't have access to such a phone.
You will either need to provide detailed information on why it does not work on this device/browser and/or perhaps you could debug and provide a fix for the library?

Not enough information has been provided to fix any issues presented here.


pull request for e2e test at 01/13/2017 11:15:10

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Exceptions in BaseKernel.complete implementations are ignored

When an implementation of BaseKernel.complete throws an exception, it seems to be ignored. Although BaseKernel.handleCompleteRequest calls replyError when an exception happens, that doesn't appear to do anything - the error is not reported in the Jupyter web interface or on the console.
I don't know if this is an issue in the basekernel (i. e. the error not being passed on correctly) or in Jupyter (i. e. the error being received but not shown/logged). Maybe the basekernel should log the caught exception just to be sure.

Sorry for the late reply on this. From what I can tell the base kernel is properly following the protocol in this scenario. completion_request says
# status should be 'ok' unless an exception was raised during the request,
# in which case it should be 'error', along with the usual error message content
# in other messages.
'status' : 'ok'

I believe it is the front-end not properly doing something with the exception as the notebook (web page) does receive the error so the jupyter_client is sending it but then the notebook does nothing with it. I was reading the notebook code and it the only place it was used (to populate the tool tip) returned early if the reply didn't contain the found field set to true. The same behavior is present in jupyter lab and it looks like nteract as well.
The problem seems to be upstream. I would like to try and keep the semantics of the kernel handlers as close to the semantics of the message they wrap and as such the error reply is an acceptable (and non-erroneous) way to handle the reply. We wouldn't log errors in eval and the semantics of complete errors are supposed to be the same so they shouldn't be treated differently. Of course you are free to implement it how you wish but the keep with the protocol I don't want to do anything special (no matter how minor) with the error.


0.16.2: HTML docs fail to make, "TypeError: an integer is required (got type str)"

pip3 install --upgrade pandas # installed 0.16.2
Download 0.16.2 source, unzip, use pip3 to install Sphinx (1.3.1, and dependencies such as sphinx-rtd-theme (0.1.8))
run make.py html in doc folder

C:\Python34\pandas-0.16.2\doc>c:\Python34\python.exe make.py html
Traceback (most recent call last):
  File "C:\Python34\Scripts\sphinx-build-script.py", line 9, in <module>
    load_entry_point('Sphinx==1.3.1', 'console_scripts', 'sphinx-build')()
  File "C:\Python34\lib\site-packages\sphinx\__init__.py", line 51, in main
    sys.exit(build_main(argv))
  File "C:\Python34\lib\site-packages\sphinx\__init__.py", line 61, in build_main
    from sphinx import cmdline
  File "C:\Python34\lib\site-packages\sphinx\cmdline.py", line 23, in <module>
    from sphinx.application import Sphinx
  File "C:\Python34\lib\site-packages\sphinx\application.py", line 37, in <module>
    from sphinx.builders import BUILTIN_BUILDERS
  File "C:\Python34\lib\site-packages\sphinx\builders\__init__.py", line 23, in <module>
    from sphinx.util import i18n, path_stabilize
  File "C:\Python34\lib\site-packages\sphinx\util\i18n.py", line 15, in <module>
    from babel.messages.pofile import read_po
  File "C:\Python34\lib\site-packages\babel\messages\__init__.py", line 12, in <module>
    from babel.messages.catalog import *
  File "C:\Python34\lib\site-packages\babel\messages\catalog.py", line 23, in <module>
    from babel.dates import format_datetime
  File "C:\Python34\lib\site-packages\babel\dates.py", line 28, in <module>
    from babel.util import UTC, LOCALTZ
  File "C:\Python34\lib\site-packages\babel\util.py", line 278, in <module>
    from babel import localtime
  File "C:\Python34\lib\site-packages\babel\localtime\__init__.py", line 21, in <module>
    from babel.localtime._win32 import _get_localzone
  File "C:\Python34\lib\site-packages\babel\localtime\_win32.py", line 18, in <module>
    tz_names = get_global('windows_zone_mapping')
  File "C:\Python34\lib\site-packages\babel\core.py", line 58, in get_global
    _global_data = pickle.load(fileobj)
TypeError: an integer is required (got type str)
Building HTML failed.

The error message seems to deal with babel and i18n, which is for translated docs. Since pandas does not use this, this seems more an issue with your sphinx installation.
Can you try with a small test project to see if this builds correctly? (see sphinx quickstart)
BTW, sphinx-rtd-theme is no dependency for the pandas docs

sphinx-rtd-theme was installed automatically together with  sphinx (pip3 install sphinx).
I uninstalled Babel, and installed sphinx again:
C:\Windows\system32>c:\Python34\Scripts\pip.exe install sphinx
Downloading/unpacking sphinx
  Downloading Sphinx-1.3.1.tar.gz (3.5MB): 3.5MB downloaded
  Running setup.py egg_info for package sphinx

    warning: no files found matching 'TODO'
    no previously-included directories found matching 'doc\_build'
Requirement already satisfied (use --upgrade to upgrade): six>=1.4 in c:\python34\lib\site-packages (from sphinx)
Requirement already satisfied (use --upgrade to upgrade): Jinja2>=2.3 in c:\python34\lib\site-packages (from sphinx)
Requirement already satisfied (use --upgrade to upgrade): Pygments>=2.0 in c:\python34\lib\site-packages (from sphinx)
Requirement already satisfied (use --upgrade to upgrade): docutils>=0.11 in c:\python34\lib\site-packages (from sphinx)
Requirement already satisfied (use --upgrade to upgrade): snowballstemmer>=1.1 in c:\python34\lib\site-packages (from sphinx)
Downloading/unpacking babel>=1.3 (from sphinx)
  Downloading Babel-2.0.tar.gz (3.4MB):  21%  749kB

Then I was back to those Babel errors. Since this isn't a pandas problem, feel free to close this issue.


[Feat]: Filling up the empty space

What feature?
I have an idea of filling up the empty space for highlighting community updates, featured projects, upcoming events, and valuable resources for developers as newsletters or shoutouts to exceptional developers
Add screenshots
Add screenshots

Please assign me under GSSOC'24 @shyamtawli
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Nice Idea @Idiotmonk22 But from where we will fetch this details or you are thinking to add it manaully?

Yeah letting the user to add any achievements or valuable updates and adding that in the empty space. Or else I can add a calendar where the user can update about upcoming events. Please let me know if you're not satisfied with any of the above I still have ideas

Okay, no problem