Standard view shortcuts no longer working when primary bar is hidden

Type: Bug
In previous versions of VS code the shift + CMD + E would always open the Explorer tab. With this version it no longer works if the Activity Bar is hidden.
Looks like the system shortcut has either added or changed the when condition to  "when": "viewContainer.workbench.view.explorer.enabled" .
If i do show the bar this shortcut works again. I've just removed the condition but curious as to why it was added to begin with? May not be a bug
Opened this as "Standard View shortcuts" because it seems this has also been added for View: Show Extensions, View: Show Run and Debug, & View: Show Explorer
VS Code version: Code 1.84.0 (Universal) (d037ac076cee195194f93ce6fe2bdfe2969cc82d, 2023-11-01T11:30:19.406Z)
OS version: Darwin arm64 22.6.0
Modes:

System Info

Item
Value

CPUs
Apple M1 Pro (10 x 24)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
2, 2, 3

Memory (System)
32.00GB (0.21GB free)

Screen Reader
no

VM
0%

Extensions (8)

Extension
Author (truncated)
Version

circleci
Cir
1.23.0

vscode-simpler-icons
dav
1.6.5

go
gol
0.39.1

terraform
has
2.28.2

vetur
oct
0.37.3

vscode-commons
red
0.0.6

vscode-xml
red
0.26.1

vscode-yaml
red
1.14.0

(1 theme extensions excluded)

2023-11-01 16:07:27.071 [info] [KeybindingService]: | Resolving shift+meta+[KeyE]
2023-11-01 16:07:27.071 [info] [KeybindingService]: \ From 1 keybinding entries, no when clauses matched the context.

Turned on the shortcut debugging and put the when clause back in place and that is indeed the issue. Searching the code base for the when clause doesn't yield any results except in issues so I'm unsure of where / why this changed or even if it has with this version

Same issue on 1.84
Mac OS 14.1
Removing the when condition fixed it for me as well:

Delete everything => press enter

This issue is also affecting extensions (Command + Shift + X)
But not some others, like source control (Command + Shift + G)

Confirmed this on my PC. It doesn't work when the icon buttons (activity bar) are hidden.
In my case (Ubuntu), CTRL + SHIFT + E stopped working. It used to show the Explorer.
I can show the search bar with CTRL + SHIFT + F but cannot go back to the Explorer with CTRL + SHIFT + E.
Removing this line from ~/.config/Code/User/settings.json worked:
"workbench.activityBar.location": "hidden"

This shows the buttons again, and makes the shortcut CTRL + SHIFT + E work again.

Thoes two shortcuts default condition confused me, I always work without activityBar, instead I use shortcuts to reach anywhere.

Exactly same issue, shortcuts should work no matter what you have inside workbench.activityBar.location setting.

I experience same issue. Can not use keyboard sshortcuts to open and focus on explorer. I use JAWS screen reader and Windows. The line mentioned by @ChrisVilches
"workbench.activityBar.location": "hidden"

fixed my issue. On Windows, easyest way is to open command palette (ctrl-shift-p), search for Preferences: Open User Settings (JSON) and press enter. In the JSON file search the mentioned line, delete it and press CTRL+s, CTRL+f4. Keyboard shorcuts works again.
Thanks for this idea:)

my Activity Bar was hidden before, today I found that the 'Show Explorer' shortcut keys didn’t work.

try to change the Activity Bar to 'side' or 'top' and then change it back to 'hidden', worked for me.

To add more clarity on this issue which I didn't see mentioned here:

In the control panel, after you select View: Hide Activity Bar, there is no option to show it again. There should be a setting for View: Show Activity Bar.

If the Activity Bar is hidden and you select View: Focus Activity Bar the UI space for the Activity Bar will be revealed, but the Activity Bar content/icons will still be hidden. This setting should either show the Activity Bar again in full or the setting should not be shown when the Actiivity Bar is hidden.

@jacobcassidy Your issue is completely different from this issue. Please follow up with this https://github.com/microsoft/vscode/issues/197297 for your issue.

Verified that this has been fixed in the latest insiders. Closing this issue.


PR: Improve performance when painting indent guides

Now we only paint those guides present in the visible region or that cross it. With that I was able to avoid the sluggishness observed when scrolling and typing in the editor for large files, specially on Windows.
A simple way to reproduce that slugishness is to open one of our largest files (mainwindow.py or codeeditor.py), activate "Show indent guides" in the Source menu and:

Scroll by holding down the up/down arrow keys in the file (you'll see the current highlighted line stays at a specific place instead of moving with the cursor).
Delete text by holding down the Backspace key (you'll see text is not removed smoothly but in chunks).

@CAM-Gerlach, sorry that it took us so long to fix this. It was not that hard after I understood how indent guides are painted (but I also had the experience of PR #13281 behind me).
Fixes #8864.

Thanks for your thorough testing @CAM-Gerlach! I'm really that this PR solved that long standing issue.


Implement Global / Local handles for editor

global = relative to grid, absolute x y z
local = relative to object
I can design some UI for it, but even a keyboard shortcut would get us started

@kkananen one thing that would be super handy, not sure if you already implemented this or not, but when handles are set to global, if rotations are also aligned globally ie so i can rotate 2 objects to 32.5 degrees and know they will be aligned the same


DO NOT MERGE. Testing bot...

Recently upgraded to FF 7.0.1. Testing if upstream is broken now...

@pdfjsbot test

@pdfjsbot makeref

@pdfjsbot makeref

@pdfjsbot makeref


Get rid of structs

As of #320
Structs and Mutable Structs
Mutable Structs:

[ ] amss (#159)
[x] odu (agent-based model)
[ ] opt_tax_recur
[x] uncertainty_traps
[x] lake_model (almost done)

Structs:

[x] lu_tricks (#559)
[ ] amss (#159)
[x] hist_dep_policies
[x] jv
[x] lqramsey (used for dispatch)
[x] odu
[ ] opt_tax_recur
[x] lake_model (above)

Closing as the remaining structs are either used for dispatch (e.g., continuous vs discrete economies with the same fundamental objects), or are mutable and so under #237

Did we say that the mutable structs should remain mutable?  In general we should avoid mutability if at all possible.

One of these makes sense (it's for an agent-based model, where the structs represent the agents.) The other two are in very complicated/code-dense lectures (amss and opt_tax_recur). I think it was decided it's best to leave those two as-is.


Set Initial Value

How to set selected initial value?

Just pass the value to :value or v-model.

Is it same for Asynchronous (single) select?

@monaye Yes. The :options list doesn’t have to include the preselected value. However the preselected value should have the same structure as the future options list.


Pagespeed broken content-type in response header

The charset was missing with pagespeed enabled.
; charset=utf-8 was eat by pagespeed, as a result, the web page was decoded wrong.
It seems pagespeed just ignore the charset in nginx.conf file.
My HTML
<!DOCTYPE html>
<html>
<head>
    <meta charset="utf-8">
    <title></title>
</head>
<body>
.....

</body>
</html>

My Nginx:
charset utf-8;

pagespeed on;
pagespeed RewriteLevel PassThrough;
pagespeed EnableFilters outline_css,outline_javascript,move_css_to_head,collapse_whitespace;
.....

With pagespeed
HTTP/1.1 200 OK
Server: nginx
Content-Type: text/html
Transfer-Encoding: chunked
Connection: keep-alive
Vary: Accept-Encoding
Vary: User-Agent
X-Content-Type-Options: nosniff
Date: Thu, 26 Oct 2017 04:39:18 GMT
X-Page-Speed: <IP_ADDRESS>-0
Cache-Control: max-age=0, no-cache
Content-Encoding: gzip

Without pagespeed
HTTP/1.1 200 OK
Server: nginx
Date: Thu, 26 Oct 2017 04:44:10 GMT
Content-Type: text/html; charset=utf-8
Last-Modified: Thu, 26 Oct 2017 04:38:13 GMT
Transfer-Encoding: chunked
Connection: keep-alive
Vary: Accept-Encoding
ETag: W/"59f166b5-9c0b"
Vary: User-Agent
X-Content-Type-Options: nosniff
Content-Encoding: gzip

After I add convert_meta_tags filter and add "" to html, response header worked fun.
But what if other mime file? Still confused with pagespeed ignoring charset=utf-8 block.


use own phpunit instead of phpunit provided by Travis CI

fixes errors with PHPUnit 6 on Travis CI.
see https://travis-ci.org/broadway/broadway-demo/jobs/213361455

Thanks :-)


Update tiernft testnet

from issue: https://github.com/Developer-DAO/academy-turbo/issues/227#issue-2228661276
Changes needed
Mumbai is being retired. TierNFT lesson and Connect to Front-end lessons need upgraded:
https://polygon.technology/blog/polygon-pos-is-cooking-the-napoli-upgrade-means-better-ux-the-mumbai-testnet-takes-a-bow

[x] remove reference to "scripts/ where simple automation scripts go"
[x] change to rm contracts/*.sol
rm test/*.js
by removing  rm scripts/*.js as it doesn't come with the build anymore
[x] learner must create scripts/deploy.js dir and file
[x] change hardhat.config.js with new RPC details: https://polygon.technology/blog/polygon-pos-and-polygon-zkevm-new-testnets-for-polygon-protocols for Amoy Testnet
[x] update "Adding the testnet network paragraph with new details 👆🏼
..
[ ] This one is not a deal breaker, but it would be nice to know how do I do grab the path to this? Typically it would be: [Introduction to web3 Wallets](../../../pages/fundamentals/wallets.mdx) but it returns a 404 page error
..
[x] asset update screenshot from Mumbai to Amoy
[x] check if URL for test token faucet is correct - add alternatives or additional URL possibilites
[x] asset update screenshot re: faucet if necessary
[x] under Personal Security paragraph, format the current paragraph from text to a bulleted list for Zerion steps
..
[x] change deploy command to npx hardhat run scripts/deploy.js --network amoy
[x] asset update screenshot for deploy terminal output
[x] change mint command to npx hardhat run scripts/mint.js --network amoy
[x] asset update screenshot for mint terminal output
[x] asset update OpenSea (if possible) with link to new NFTs
[x] create lesson summary
[x] update titles of other lessons when they're referenced, e.g. in intro and outro
[ ] 30 April - need to update new assets @elPiablo !!

@Markkos89 could you do a quick review of this?


Where is the code, or docs for for OpenIdConnectMessage?

I'd like to document that as I have with #1776 . Actually I want to add examples.

Over here https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet

Thanks!


Can we exclude migrations tables?

I'm trying Seaography for the first time.
On the first run it creates this file which makes me think that it is also considering the migrations tables.
#[derive(Debug, seaography::macros::QueryRoot)]
#[seaography(entity = "crate::entities::player")]
#[seaography(entity = "crate::entities::seaql_migrations")]
#[seaography(entity = "crate::entities::sqlx_migrations")]
pub struct QueryRoot;

How can they be excluded?

Can we exclude them by default?

Currently the only solution is to remove those lines
We can add a CLI parameter that accepts a list of table names that we want to be ignored in generation

_sqlx_migrations (note the _) is the table name.

Here here you go https://github.com/SeaQL/seaography/pull/79


Errors with plurals in queries

q('''ESTIMATE CORRELATIONS FROM PAIRWISE COLUMNS OF %g''')
q('''ESTIMATE CORRELATION PVALUES FROM PAIRWISE COLUMNS OF %g''')

will post the errors soon

Write CORRELATION and CORRELATION PVALUE -- the idea is that you're doing a singular thing, once for each row of input.

Sure, my point being that users might commit the same mistakes and I don't see why they should be punished for it.

I think that the singular correlation and correlation pvlaue is the correct choice, just like dependence probability versus dependence probabilities etc. Consider SQL, you say 'SELECT ABS(x)for all rows in columnx, versus the plural ABSOLUTE VALUES(x). It might help to observe that the rows of the table COLUMNS OF %g` contain two column names.


Flex merge feeds

Checklist

[x] Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
[x] Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
[x] The description lists all applicable issues this PR seeks to resolve
[x] The description lists any configuration setting(s) that differ from the default settings
[x] All tests and CI builds passing

Description
Flex updates to support flex feed merging in datatools.

This PR has been reopened in the forked repository

Are we sure this PR is good to go? Since stop areas has been re-renamed

@miles-grant-ibigroup The thinking is to get this merged albeit with the wrong naming. Once this aspect of the flex spec is set-in-stone, then update across the board.


Adds Directional Switches

About the PR
Adds directional switches that can only be accessed from one side of a wall. This makes them more versatile for mapping and player interactions.
Media

[x] I have added screenshots/videos to this PR showcasing its changes in-game, or this PR does not require an in-game showcase

Changelog
:cl: Velcroboy

add: Added directional switches

is this the most sane way to do this

is this the most sane way to do this

What is your concern?

nah i think this is fine good job


Release 0.3.1

What's the purpose of this release?

Fixes https://github.com/spyder-ide/loghub/issues/78

I'm doing the release right now, so I'm closing this issue.


Docs contain a broken link

At https://docs.wasmtime.dev/lang-rust.html#creating-the-webassembly-to-execute, "Writing WebAssembly chapter" returns 404 not found.

It appears that the file wasm.md was deleted in the commit 0ee6641.


Open discussion: Legends appearing automatically

Hey everyone :)
I (with the support of @piensaenpixel and @urbanphes) would like to reopen a discussion about legends appearing automatically on Builder. From an UX standpoint, it's quite annoying and I strongly believe we shouldn't make them appear on its own.
Thoughts? @xavijam @saleiva

I agree with @arianaescobar. It's a bit strange that the legends showed when I don't configure it.


Add visibility field for repo context

Is your feature request related to a problem? Please describe.
We have gitStream enabled on the Github organization level. It runs for all repos of our org.
Some automations such as the one requiring a Jira ticket should be run for private repos only, and should be skipped for public ones.
Describe the solution you'd like
Add a new field to repo indicating the visibility of the repo (private or public).
Describe alternatives you've considered
We considered setting an env var per repo but this solution is not very scalable.

Hi @korya, We've added the repo.visibility context variable. The value can be one of private, internal, or public.

This is great. Thanks!


Security issue

Dont share your api tocken !!!
I can check your bot
Change it and sent message from it now !
Change your token and hide it from this source

You're right, I'm going to read from ENV now, thanks for noting.


#0: Update BERT end-to-end times

Passing GS perf pipelines: https://github.com/tenstorrent/tt-metal/actions/runs/9181075238


docs: Fix cmdref checker logic, avoid leaving tree changes behind

Coverage decreased (-0.03%) to 46.948% when pulling 55eed67a8b7b3f9aebfbcedac3a2d37023fe2758 on pr/errordeveloper/fix-10742 into 418500bad872814fd9582ba6eb30b9819e4ee3b6 on master.

Just looking back at this and wondering actually - why does default target need to run checks? Does it run unit tests also?
To me it would be more natural if default target just built binaries/images (whatever artefacts we we think it has to be build; personally, I would actually exclude docs from it) and make check would be an explicit step, as well as make test. I think we are mixing too many things into one.

I'd be happy to make a tweak to bring previous functionality back, then propose build system review, if that's what we might prefer to do...

Just looking back at this and wondering actually - why does default target need to run checks? Does it run unit tests also?

To me it would be more natural if default target just built binaries/images (whatever artefacts we we think it has to be build; personally, I would actually exclude docs from it) and make check would be an explicit step, as well as make test. I think we are mixing too many things into one.

This is good feedback, and worth revisiting the decisions made at points in the past to make sure we're actually achieving the goals that we set out originally when we set things up this way.
The reasoning originally was mainly focused on a minimal set of checks that developers can be guaranteed(*) to run prior to PR submission that do not significantly increase the build time. Putting in the default make target makes them fairly hard to avoid unless you're explicitly working around this default behaviour. At that point as a developer you know you're avoiding some checks so you know you should run the generic make before submission.
Re: unit-tests, personally I would tend to run unit tests that are related to the area I'm working, but practically never the full suite because I don't expect my changes to make a difference to other tests. (Plus I assume full unit-test suite takes too long). If I then submit and the CI yells on a specific test that I didn't think of, then I can go back to my local env and reproduce those specific issues locally and iterate.
One tendency I found in the past when the extra checks were not part of the regular make is that people would not run them, then send through CI, then CI would break early because of the simple checks that they could have done locally. Having it part of the default flow actually tightens that feedback loop (admittedly by relying on people's laziness/lack of process to run checks before submission).
One model to think about this (the model I have in mind) is:

Plain build (make -C build) takes 10s of seconds
Basic checks (add govet, etc) take 1s of seconds
Docs (make -C Documentation/) takes maybe 10s of seconds?
Unit-tests (make unit-tests) takes 10s of minutes
Full integration tests takes hours

We can debate whether these defaults today are reasonable, and for that matter whether they achieve the target goals, but if we do change this then it'll be important to communicate those changes clearly and widely.

One model to think about this (the model I have in mind) is:

Plain build (make -C build) takes 10s of seconds
Basic checks (add govet, etc) take 1s of seconds
Docs (make -C Documentation/) takes maybe 10s of seconds?
BPF ALL_PERMUTATIONS extra build targets take 10s of seconds
Unit-tests (make unit-tests) takes 10s of minutes
Full integration tests takes hours

Do we need the "BPF ALL_PERMUTATIONS extra build targets take 10s of seconds" to be enabled by default?

Do we need the "BPF ALL_PERMUTATIONS extra build targets take 10s of seconds" to be enabled by default?

Probably not, following my logic. So long as it's part of CI somewhere I don't mind.


e2e: verify nrt data after each test

Following https://github.com/openshift-kni/numaresources-operator/pull/598, https://github.com/openshift-kni/numaresources-operator/pull/608 stabilize the e2e tests even more by verifying after each test that the NRT data is settled to the initial. This will help in troubleshooting failures related to to unclean NRT data and in a meaninful cooldown.
PS: we assume that the cluster is clean before running the suite, as in it doesn't have workloads apart from the system and setup workloads that are needed for executing serial. Also, we assume no sudden interrupts, resources consumptions/releases during the run, which was also the case before this update.

WIP:
need to add checks by end of each the test

After some more thinking I think we can pivot a bit.
in test/e2e/serial/config/fixture.go we have the Suite fixture (which is the context per-suite implemented in E2EConfig - naming is indeed inconsistent here). This is meant to be called once per suite run, using SetupFixture and TeardownFixture in turn called by ginkgo's Setup and Teardown. We should hook here.
When the suite starts, we do grab a snapshot of nrtList (check NewFixtureWithOptions).
Note, for extra confusion, we DO reuse the test-level fixture code to create the e2e-test-infra pseudo fixture which has the same lifecycle of the suite, outspanning the test-group-fixtures.
But the takeaway is that (we need a cleanup and rename and) E2EConfig holds a nrtList grabbed right at the startup when the cluster is assumed idle and stable, so we can use THAT nrtList in Cooldown to wait for the cluster to get back to that state. For that we can probably just reuse internal/wait/ForNodeResourceTopologiesEqualTo

Following offline conversation, the points highlighted by Francesco were taken into consideration and the PR now verifies that the NRTs data after each test is matching to the initial data that was recorded by the suite's setup.
Thanks @ffromani for the valuable review and insights!

please rebase on top of https://github.com/openshift-kni/numaresources-operator/pull/614

/hold
commits are not aligned to the changes, need to fix that.

/hold cancel
Thanks @ffromani for the beneficial review and comments!

/lgtm

/cherry-pick release-4.13


escape % in s3 path

I find out a error while S3 path includes %.
text = (msg % args)

above source code shows TypeError: not enough arguments for format string
I would suggest s4cmd could use advance string format to avoid this problem.
Thanks.

No, that is is a bug in a call site when we call message(str) instead of message('%s', str). Kind of old school. This is no longer an issue in new versions. I can get/put/list files with % symbols.
Can you test with newer versions? Thanks.


Error in Version 0.91.4

Log Details (ERROR)
Mon Apr 29 2019 18:00:04 GMT+0200 (Mitteleuropäische Sommerzeit)
An error occured accessing AlexaAPI: An exception of type JSONDecodeError occurred. Arguments:
('Expecting value: line 8 column 1 (char 7)',)
and obviously a follow up:
Log Details (ERROR)
Mon Apr 29 2019 18:00:04 GMT+0200 (Mitteleuropäische Sommerzeit)
error from callback <bound method WebsocketEchoClient.on_message of <WebsocketEchoClient(Thread-4, started daemon<PHONE_NUMBER>)>>: 'NoneType' object is not iterable

Can be closed. The error was initiated from a configuration request, captcha.
Last but not least the question: why? I haven't changed anything.
Anyway - the error itself can be closed. The errormessage could be improved.


LLMMathChain to allow ChatOpenAI as an llm

Cannot initialize match chain with ChatOpenAI LLM

llm_math = LLMMathChain(llm=ChatOpenAI(temperature=0))

ValidationError                           Traceback (most recent call last)
Cell In[33], line 1
----> 1 llm_math = LLMMathChain(llm=ChatOpenAI(temperature=0))
File ~/anaconda3/envs/gpt_index/lib/python3.8/site-packages/pydantic/main.py:341, in pydantic.main.BaseModel.init()
ValidationError: 1 validation error for LLMMathChain
llm
Can't instantiate abstract class BaseLLM with abstract methods _agenerate, _generate, _llm_type (type=type_error)

Works ok with OpenAI LLM

llm_math = LLMMathChain(llm=OpenAI(temperature=0))

I met the same problem.
the warning message said:
You are trying to use a chat model. This way of initializing it is no longer supported. Instead, please use: from langchain.chat_models import ChatOpenAI
But I cannot use ChatOpenAI instance as the llm args for LLMPredictor if I follow the warning's instructions.
from langchain import OpenAI
from langchain.chat_models import ChatOpenAI
from langchain.llms import OpenAIChat
# will report wanrings
llm_math = LLMPredictor(llm=OpenAI(temperature=0))
# will also report warnings
llm_math = LLMPredictor(llm=OpenAIChat(temperature=0))
# will validation error
llm_math = LLMPredictor(llm=ChatOpenAI(temperature=0))

same error with SQLDatabaseChain + ChatOpenAI
    db = SQLDatabase.from_uri("sqlite://...")
    llm = ChatOpenAI(temperature=0)
    db_chain = SQLDatabaseChain(llm=llm, database=db, verbose=True)

same error with SQLDatabaseChain + ChatOpenAI
    db = SQLDatabase.from_uri("sqlite://...")
    llm = ChatOpenAI(temperature=0)
    db_chain = SQLDatabaseChain(llm=llm, database=db, verbose=True)

Actually it was fixed for SQLDatabaseChain last week in this commit: b1c4480d7cdf0b86d204641fc126188929a46439 .
However, it still requires a BaseLLM in LLMMathChain as reported by cnndabbler .

@cnndabbler Are you currently working on this? Otherwise, I would take on this issue.
Apart from changing the typing of LLMMathChain.llm to allow for a BaseChatModel, I would also suggest changing the default prompt.
Currently, it lets the language model choose whether to use python code or not, which works with text-davinci-003, but leads to an invalid answer with gpt-3.5-turbo (something like "Sorry, as a Language Model I cannot...."), when running the example from the docs. I would modify it to ask the model only for python code. I cannot imagine any problem that a language model can confidently solve by itself that it cannot solve via python code.

Cannot initialize match chain with ChatOpenAI LLM

llm_math = LLMMathChain(llm=ChatOpenAI(temperature=0))
ValidationError Traceback (most recent call last) Cell In[33], line 1 ----> 1 llm_math = LLMMathChain(llm=ChatOpenAI(temperature=0))
File ~/anaconda3/envs/gpt_index/lib/python3.8/site-packages/pydantic/main.py:341, in pydantic.main.BaseModel.init()
ValidationError: 1 validation error for LLMMathChain llm Can't instantiate abstract class BaseLLM with abstract methods _agenerate, _generate, _llm_type (type=type_error)

Works ok with OpenAI LLM

llm_math = LLMMathChain(llm=OpenAI(temperature=0))

I am facing this issue with both SQLDatabaseChain + ChatOpenAI and SQLDatabaseChain + ChatOpenAI. What is the way around this?

from langchain import LLMMathChain
llm_math = LLMMathChain(llm=ChatOpenAI(temperature=0))
now generates no error :). Thank you for fixing this !

i think i fixed it with https://github.com/hwchase17/langchain/pull/3808


feat: process yml, json eslint config

Closes #688
This PR handles when target project has existing .eslintrc.yml, .eslintrc.yaml, or .eslintrc.json. Previously we only handle .eslintrc.js.

Can we make sure to cover .eslintrc which is also used. It should be the same as .eslintrc.json from what I've seen

@chadhietala @lynchbomb .eslintrc added


Update chksum dependency

First of all - thank you for choosing my tiny library! It was very nice surprice when I noticed, that my crate has dependent crate from you! I really appreciate that!
I worked on big changes in chksum library. Now it should be faster and more effective (I switched from enum variants to generics and traits).
I hope that you will like new API.
Tested on my local machine with cargo test.

 Good work and keep learning - Rust is an amazing language and it took me a while to understand the core concepts.


e722: Missing comma in Dictionary

Hi, when trying complete an object of aa Class I have written I get the following error:
Error detected while processing function javacomplete#Complete..<SNR>210_CompleteAfterDot..<SNR>210_DoGetClassInfo..<SNR>210_FetchClassInfo:
line    7:
E722: Missing comma in Dictionary: t have to care about

The class which triggers the error is this one:
https://github.com/SteveCharleston/RiG/blob/master/app/src/main/java/rigAPI/RigDBAccess.java
My vimrc can be found here:
https://github.com/SteveCharleston/dotfiles/blob/master/.vimrc

you need add the classes dir into g:JavaComplete_LibsPath,
and add your src dir into g:JavaComplete_SourcesPath

I added it with
let g:JavaComplete_SourcesPath="/home/steven/git/RiG/app/src"
but had no success. I've also tried different other variations like
let g:JavaComplete_SourcesPath="/home/steven/git/RiG/app/src/main/java/rigAPI"
or
let g:JavaComplete_SourcesPath="/home/steven/git/RiG/app/src/main/java/rigAPI:/home/steven/git/RiG/app/src/main/java/de/charlestons_inn/rig"
to directly supply the dirs with the containing java source files but had no success.

However, it seems to be related to the parsing of javadocs. If I change all the words like "don't" or "isn't" in "dont" and "isnt" the error disappears.

the same Error i have got !
https://github.com/artur-shaik/vim-javacomplete2/issues/50

Sorry, couldn't find out. What exactly object you are trying to complete? In what line number?

https://github.com/wsdjeg/wsdjeg.github.io/blob/master/java/invoicingsystem/WEB-INF/src/com/wsdjeg/impl/TestDAOImpl.java
the error appears at line 8,after "t."

"===============> javaComplete2 相关设置 映射autocmd FileType java set omnifunc=javacomplete#Completeautocmd FileType jsp set omnifunc=javacomplete#Completenmap  :call javacomplete#AddImport()imap  :call javacomplete#AddImport()let g:JavaComplete_UseFQN = 1"++++++> app1 补全配置"let g:JavaComplete_LibsPath = '/home/wsdjeg/wsdjeg.github.io/java/app1/WEB-INF/classes:/home/wsdjeg/wsdjeg.github.io/lib/'"let g:JavaComplete_SourcesPath = '/home/wsdjeg/wsdjeg.github.io/java/app1/'"++++++> Invoicing_System 补全配置let g:JavaComplete_LibsPath = '/home/wsdjeg/wsdjeg.github.io/java/invoicingsystem/WEB-INF/classes:/home/wsdjeg/wsdjeg.github.io/lib/'let g:JavaComplete_SourcesPath = '/home/wsdjeg/wsdjeg.github.io/java/invoicingsystem/'

@wsdjeg, it's looks like you have little bit another issue, I'm working on it.
@SteveCharleston can you answer?

it causes by javadoc!
when i delete
        /**
	 * TestJCimpl's testJC
	 */

in
https://github.com/wsdjeg/wsdjeg.github.io/blob/master/java/invoicingsystem/WEB-INF/src/com/wsdjeg/impl/TestJCimpl.java
then the error Disappears!

Yeah, it's looks like javaparser lib, works bad with comments.

hope to be solve
https://github.com/artur-shaik/vim-javacomplete2/issues/47
https://github.com/artur-shaik/vim-javacomplete2/issues/45

Try with last commit, please.

did you remove the javadoc message from the complete manu?
last commit  i will get the manu like:
test()  m  / **  message */ void test();
then only:
test()  m   void test();

Yes, I removed it, because it could be too much long. For javadoc, I think, we need to show it in another buffer, like YCM do it.

yeah,  usually it is too long and,i can not see the return type in the menu

@SteveCharleston any updates?


docs(storage): add proto more comments

docs(storage): add proto more comments
chore(storage): auto-generated protos

before
+--------------------------+------------------+----------------+
|           RULE           | TOTAL VIOLATIONS | VIOLATED FILES |
+--------------------------+------------------+----------------+
| core::0192::has-comments |              272 |              9 |
+--------------------------+------------------+----------------+

after
+--------------------------+------------------+----------------+
|           RULE           | TOTAL VIOLATIONS | VIOLATED FILES |
+--------------------------+------------------+----------------+
| core::0192::has-comments |              149 |              9 |
+--------------------------+------------------+----------------+

related to #195


Feature/improve packaging

TODOs:

[ ] set author_name
[ ] set author_email

Updates the following:

version is now taken always from git
prune the docs requirements
remove tqdm from hard requirements
populate setup.cfg
temporarily disables flake8 D10{1,2,3}
updates CONTRIBUTING.md to include how to build docs

@marcocuturi there were still some TODO's left which I didn't know how to fill - could you please update the information here?
https://github.com/ott-jax/ott/blob/main/setup.cfg#L5-L6


Constant noise assumption in sampling script

If I read this correctly, it looks like we are assuming constant noise on gamma throughout the field in the likelihood term:
https://github.com/CosmoStat/jax-lensing/blob/13a4b8d13deb6d4be1ce62cf7b35974fb3e733be/scripts/sample_maps.py#L213
But we know we have some variations, and that not accounting for it can throw off a model like DeepMass. If I read this part of the code correctly:
https://github.com/CosmoStat/jax-lensing/blob/13a4b8d13deb6d4be1ce62cf7b35974fb3e733be/scripts/train_deepmass.py#L101
DeepMass uses the non-constant noise variance, but not our DSM sampling? That would be inconsistent and we should fix that.
@b-remy can you let me know if I missed something?

Right, with the last PR, the likelihood will be always using the diagonal covariance matrix. Thanks for spotting this @EiffL


TypeScript Support

I wanted to use the plugin on my project but couldn't find @types/react-router-transition. Is there a workaround or any plans to add support for TypeScript? Thanks in advance.

Here is a workaround I've found to suppress typescript until we have a @types file.
declare function require(moduleName: string): any;
const AnimatedRoute = require('react-router-transition').AnimatedRoute;

You could even do:
import * as ReactRouterTransition from 'react-router-transition';
And then use it as object: ReactRouterTransition .AnimatedSwitch for example

This works too declare module "react-router-transition";

I think this covers it:
declare module "react-router-transition"
{
	import {RouteProps} from "react-router";

	interface AnimatedSwitchProps
	{
		atEnter: React.CSSProperties;
		atLeave: React.CSSProperties;
		atActive: React.CSSProperties;
		didLeave?: (style: React.CSSProperties) => void;
		className?: HTMLDivElement;
		wrapperComponent?: keyof HTMLElementTagNameMap;
		mapStyles?: (styles: React.CSSProperties) => React.CSSProperties;
		runOnMount?: boolean;
		children: React.ReactNode;
	}

	interface AnimatedRouteProps extends RouteProps
	{}

	export const AnimatedSwitch: React.ComponentClass<AnimatedSwitchProps>;
	export const AnimatedRoute: React.ComponentClass<AnimatedRouteProps>;
	export const RouteTransition: React.ComponentClass<AnimatedSwitchProps>;
}

Added a PR: https://github.com/maisano/react-router-transition/pull/115

There aren't any plans to rebuild this library in TypeScript. That said, if someone wants to PR the types to DefinitelyTyped, I think that should help with this. I don't use TypeScript with React personally, so I'm not much help here–sorry y'all!

I think this covers it:
declare module "react-router-transition"
{
	import {RouteProps} from "react-router";

	interface AnimatedSwitchProps
	{
		atEnter: React.CSSProperties;
		atLeave: React.CSSProperties;
		atActive: React.CSSProperties;
		didLeave?: (style: React.CSSProperties) => void;
		className?: HTMLDivElement;
		wrapperComponent?: keyof HTMLElementTagNameMap;
		mapStyles?: (styles: React.CSSProperties) => React.CSSProperties;
		runOnMount?: boolean;
		children: React.ReactNode;
	}

	interface AnimatedRouteProps extends RouteProps
	{}

	export const AnimatedSwitch: React.ComponentClass<AnimatedSwitchProps>;
	export const AnimatedRoute: React.ComponentClass<AnimatedRouteProps>;
	export const RouteTransition: React.ComponentClass<AnimatedSwitchProps>;
}

For anyone who is not as familiar with this, make a @types directory in your src directory and put the above code in a react-router-transition.d.ts file and that will get you going.


About accuracy

the final accuracy obtained from the uploaded model？
My accuracy about block+flow is far from 90%

Same here, I couldn't reach to the accuracy mentioned on the README...


Fix Tournament alert when tournament start

Expected behavior
Don't alert on tournament start,
Observed/Actual behavior
Fix Tournament alert when tournament start
How to Recreate (if known)
No response
Stack trace
Don't have
Plugin list

Frost version
6.9
Agreements

[X] I have searched for and ensured there isn't already an open issue regarding this.

Other
No response

Change this to spectate when game start (random spectate)

Added and done


Tabs inside steps doesn't working properly

Hello, I'm trying to put tabs into a step but second tab doesn't work properly

Steps To Reproduce
Use this simple code snipped to reproduce the issue
{{% steps %}}

### Step one

{{< tabs items="JSON,YAML,TOML" >}}

  {{< tab >}}**JSON**: JavaScript Object Notation (JSON){{< /tab >}}
  {{< tab >}}**YAML**: YAML is a human-readable data serialization language.{{< /tab >}}

{{< /tabs >}}

{{% /steps %}}

Expected Behavior
Second and further tabs show properly
Actual Behavior
Second and further tabs not show content and label properly
Screenshots

Environment

Hugo Version: v0.132.2
Browser/OS: FireFox/Windows 10
Theme Version: main branch e83c11f

Additional Context

This will be fixed by #440
Please be aware that the Step shortcode is intended only for Markdown. So it's not recommended to put other shortcodes as content.


Edge Drag Arrow

The edge drag arrow is not aligned right in some cases.

Reference to similar issue: https://github.com/wbkd/react-flow/issues/704


add GET API requests

I'm currently working on the GET API request first before moving to POST API requests (#3).

[x] getMap 2f1ed8c15f43bac91ed79815cd023d9c3f19c704
[ ] getEmailGuestlist

getMap - GET request has been added. Here's the sample code for now. 👊😎👌
The code still needs to be clean as I add this so I can continue working on it later.
const GATHER = require('gather.js'); // add gather package
const access = require('./config.json'); // load your apikey
const gather = new GATHER(access.key);

// vars
const spaceID = 'space-code\\space-name';
const mapID = 'my-office-name';

gather.getMap(spaceID, mapID)
    .then(data => console.log(data))
    .catch(err => console.log(err));

getEmailGuestList - GET request has been added. Here's the sample usage of the code.
gather.getEmailGuestList(spaceID)
    .then(data => console.log(data))
    .catch(err => console.log(err));

The base code still needs refactoring. I'll improve it over time.

Add the build for this and I'm done with the checklist. Closing this now.


Properties\AssemblyInfo.cs went missing

In commit 7ae9c88fc91d0c7e4444e78dc19ce93061783bf9

It is also removed from the CSProj. Is there any reason you need it?

ClangSharp.csproj on master still has:

Line 43 when browsed through github,
I kept building via the original projs after you introduced the build.bat because I find it's easier to control the target platform that way. But I understand that's Windows only.

Thanks @codespare. Fixed in https://github.com/mjsabby/ClangSharp/commit/42fb52a22cc7ba7820ab02bb95edaba9e7320661


[json] schema less JSON intellisense could be smarter

{
	"foo": "bar",
	"test": {
		"a": 123,
		"b": 123
	},
	"test2": {
		"a": 123,

	}
}

I would expect to complete test2 with "b": 123

It's easy to generate JSON Schema off of a JSON structure. I've written a little module for this:
https://github.com/mohsen1/json-to-json-schema


[Feature] Add support for Kotlin Multiplatform Client

Problem description
Jetpack Compose Multiplatform came quite appealing recently, The open api generator works fine, but what if there would be a fern one?
Why would it be useful?
More platforms are always better.

while we plan to expand to additional platforms in the future, this is not a focus for us right now


Update UserGuide

Update UG to include instructions about batchadd and batchexport such that users get a better understanding of what is required in csv files import and exporting, fixes #183

LGTM


Weakened tokens

This adds code to add weakened token scopes to the submissions with command line flags;

Btw, @marcmengel - is this documented anywhere besides the issue?  If not, we should probably put something up in the Getting Started wiki.

I put a note in the Differences between jobsub and jobsub_lite page, but I'll copy the section into the Getting Started page as well.

I tacked it on the bottom under "If you have problems"...


Use num for Dart instead of int or double

num is very good to use when parsing json when its not always obvious that a number will be an integer or a double. Often times when using Quicktype for Dart you will get errors of mismatched ints and doubles when your sample just happened to not have either or. This severely decreases the usefulness of Quicktype if you have to go back and manually adjust your samples.

You're welcome to add an option for this if it's important for Dart, but we consider quicktype's ability to distinguish int and double types a feature.
I also think "severely decreases the usefulness of Quicktype" is an exaggeration.


FIX: fix seed issue in ICA tutorial

and another fix, seed of the evil.

cc @agramfort @Eric89GXL @jaeilepp

Coverage decreased (-8.8%) to 81.997% when pulling d70a3a74186a0d058b3cf87a5a5c34a090e32d30 on dengemann:fix_ica_tuto into 5064139dc838ebe02f366b73dcee357eb77f8421 on mne-tools:master.

Coverage decreased (-0.1%) to 90.715% when pulling d70a3a74186a0d058b3cf87a5a5c34a090e32d30 on dengemann:fix_ica_tuto into 5064139dc838ebe02f366b73dcee357eb77f8421 on mne-tools:master.

addressed comments.

Coverage decreased (-0.1%) to 90.697% when pulling 35ce4d01faef73064b82a535461091962937e62b on dengemann:fix_ica_tuto into 5064139dc838ebe02f366b73dcee357eb77f8421 on mne-tools:master.

fix pep8 to make travis happy and merge

merged by rebase after pep8 fix
thx @dengemann


SlimJar repository

I can't find the new slimjar repository. Where can I download it?

Currently the slimjar repository if down since Oracle seems to have disabled the vps at random. I suggest temporarily installing it to your local maven repository and using it that way

Currently the slimjar repository if down since Oracle seems to have disabled the vps at random. I suggest temporarily installing it to your local maven repository and using it that way

Hey, is it still down? I can't find it anywhere


Infinite CMake recursion when compiling OpenEXR from source.

Bug Description
I'm compiling OpenEXR 2.4 from source, relying on vcpkg to install the zlib and boost dependencies.  Due to some CMake scripts incompatibilities between both projects, CMake enters an infinite recursion loop with the message:
-- Configure ILMBASE Version: 2.4.1 Lib API: 24.0.0
CMake Error at C:/vcpkg/scripts/buildsystems/vcpkg.cmake:237 (string):
  Maximum recursion depth of 1000 exceeded
Call Stack (most recent call first):
  C:/vcpkg/scripts/buildsystems/vcpkg.cmake:286 (_find_package)
  C:/vcpkg/scripts/buildsystems/vcpkg.cmake:286 (_find_package)

[...]

  C:/vcpkg/scripts/buildsystems/vcpkg.cmake:286 (_find_package)
  C:/vcpkg/scripts/buildsystems/vcpkg.cmake:286 (_find_package)
  CMakeLists.txt:33 (_find_package)
  IlmBase/config/IlmBaseSetup.cmake:136 (find_package)
  IlmBase/CMakeLists.txt:35 (include)
-- Configuring incomplete, errors occurred!

Environment

OS: Windows 10 x64
Compiler: Visual Studio version 16.4.29709.97
vcpkg version: version 2020.01.17-nohash-external
vcpkg git commit:  f272b0c9846d24c2b77a5fb60e1061d397384acb
OpenEXR git commit: 1cbf6b9a4497f71586ac11dc60ed21cf0cc529bd

To Reproduce
Steps to reproduce the behavior:

From the OpenEXR base directory:

mkdir build
cd .\build
cmake -DCMAKE_TOOLCHAIN_FILE=C:\vcpkg\scripts\buildsystems\vcpkg.cmake -DVCPKG_TARGET_TRIPLET=x64-windows-static ..

Additional context
From my limited CMake understanding, I suspect the macro redefining find_package in vcpkg might be conflicting with the find_package redefinition in the OpenEXR project, with CMake getting confused on _find_package() calls..
From: https://crascit.com/2018/09/14/do-not-redefine-cmake-commands/

The prepending of one underscore to “save” the previous command only applies to the current name, it is not applied recursively to all previous overrides. This has the potential to lead to infinite recursion, as the following contrived example demonstrates

I might be completely of the mark here, so I'll leave the CMake debugging to the experts.. 😎
As an important side-note, I first opened a bug report on the OpenEXR github page, where one of the contributors suggested to open a bug report in parallel here.  The underlying idea was to hopefully cooperate on a solution that could, more generally, lead to better compatibility between both projects, and avoid downstream patches to get OpenEXR to compile with vcpkg.
The original bug report can be found here: https://github.com/AcademySoftwareFoundation/openexr/issues/648

I don't see how we could solve this without drastically changing the usage of vcpkg, the path with least resistance would be to modify OpenEXR locally.
macro(openexr_find_package)
    if (NOT "${ARGV0}" IN_LIST as_subproject)
        find_package(${ARGV}) # Calls VCPKG override
   endif()
endmacro()

And replace each instance of find_package in their CMake scripts with openexr_find_package.

I don't see how we could solve this without drastically changing the usage of vcpkg, the path with least resistance would be to modify OpenEXR locally.

Probably not the safest of ideas to redefine CMake commands, no matter where..

And replace each instance of find_package in their CMake scripts with openexr_find_package.

The OpenEXR guys seemed to be interested in solving that upstream.  Perhaps that can be discussed with them?


SubscribeForMore: Documentation Error?

Under the subscribe section there is a note:

⚠ If you want to update a query with the result of the subscription, use subscribeForMore. The methods below are suitable for a 'notify' use case.

However, I can't find any information on subscribeForMore in this repo or apollo-client.
Should this instead be subscribeToMore?

Thanks! This is a typo.


8 bit Adam

Hi 👋
Trying to understand how to use 8 Bit Adam from bitsandbytes but no luck so far.
Anyone has an idea?
Thanks
Fra

You can set the optimizer to adamw_bnb_8bit in the training arguments. I've found that this runs slower on my machine, but YMMV.

hi @tloen, thanks didn't know it was supported like that - it should be slower but you should save memory. I was also trying to compile / not compile the model with torch2.0 seeing not really a change. Also tried to use xformers, no luck - mmm maybe is io bound, I will try to investigate


Why not find "Load" event for ReoGridControl

Why not find "Load" event for ReoGridControl, if not exist, how to add "Load" event?

Because ReoGrid loads worksheet synchronously, the event is the end of calling load method. What's the case you need a load event?

Because some initialization methods place into load event method is the best. Similar to WinForm.OnLoad() method.
Ex. 1)My ReoGrid has 3 worksheets ws0,ws1,ws2.
2)ws0 has 1 thing ws0.CellDataChanged += grid1_CellChange;
3)ws1 has 1 thing ws1.CellMouseUp += grid2_MouseClick;
4)ws2 has 1 thing ws2[1, 1] = new ListViewDropdownCell();


Feature/htlc eth besu

Added functionality to used HTLCs for Eth.
Interface defined in JSON, created for #512
Status WIP:

Using the core besu (instead of using web3)
Finishing test coverage using TAP

Rebase required @AzaharaC


Preupload file(question)

HI,
Is there a way upload file, to get FileId or Url, and then use in different chats with one bot?
something like this:
FileToSend fileToSend = new FileToSend(...);
await client.UploadFileAsync(fileToSend));
FileToSend fts = new FileToSend(fileToSend.FileId);
await client.SendDocumentAsync(chatId, fts, caption);

Afaik there is no method for that in the telegram api. Gonna check in a minute.

Nope, that's impossible. You have to send it to a channel or other chat for that. Sorry.


[zh-cn] resync /concepts/security/controlling-access.md

Resync with the en version: /docs/concepts/security/controlling-access.
Preview: https://deploy-preview-35169--kubernetes-io-main-staging.netlify.app/zh-cn/docs/concepts/security/controlling-access/

/lgtm
/approve


content ideas?

what should the "about" page of the Open Data Initiative say? would love to have ideas on this thread...

i'll start... here's my brain dump so far:

[ ] a timeline?
[ ] who's been involved
[ ] why we're doing this


Fix location of APSS

The APSS target should be under the motherboard, not system target.

@Erich-Hauptli , could you merge this, please? This is preventing us from getting an updated Targets.pm in hostboot.


Look into CL and default CL

If a single sg8 node is set, is the default CL = ONE?

What's the context?
For graphql default is LOCAL_QUORUM https://github.com/stargate/stargate/blob/f0c674b7d0d21301f027904ec33d0aeadd53f3a3/graphqlapi/src/main/java/io/stargate/graphql/schema/CassandraFetcher.java#L21, rest uses LOCAL_QUORUM always, and cql defaults to ONE.


Roll engine to 04f3c6557c02879191a558320ed8ec81f8b2b619

LGTM for the roll. Looking at Appveyor, it appears we hit the 1h time limit on Windows.


Support extracting Account from VM result

We can not extract an Account from the VM result.  This is because the virtual machine operates on a MerkleStore for it's merkle data.  The Account object uses both SimpleSmt and TieredSmt to encode its AccountStorage and AccountVault respectively.  We need to implement extraction of SimpleSmt and TieredSmt from the VM result (MerkleStore + advice map?) to overcome this.  We have implemented an AccountStub type which can be considered a "weakly typed" version of an Account where the Merkle data is all combined in a single MerkleStore:
#[derive(Debug, Clone, PartialEq)]
pub struct AccountStub {
    id: AccountId,
    vault_root: Digest,
    storage_root: Digest,
    code_root: Digest,
    nonce: Felt,
    store: MerkleStore,
}

I'm not sure we need to extract a full account object from the VM. If we are able to extract something like AccountDelta, we can then apply this delta to the account to update its state. For example, we could have the following methods on the account struct:
impl Account {
    pub fn update(&mut self, delta: AccountDelta) -> Result<(), AccountError> {
        todo!()
    }

    pub fn clone_update(&self, delta: AccountDelta) -> Result<Self, AccountError> {
        todo!()
    }
}

Using AccountDelta for updates is also useful as we may be able to apply directly to the database without having to load a full account object into memory (this could be used on the store side).

That sounds good to me. However, I think it's preferable to stay consistent with our interface for apply diffs across types.  We introduced the ApplyDiff trait in this PR - I think this preferable to implement this on the Account object rather then introducing the update and clone_update(..) methods.

closed by #167


Appman: "restart FD" prompt

It might not be obvious to some users that a plugin is not available right away after installing it / that FD has to be restarted. Typically, there's a prompt that informs the user about this and offers to restart right away.

@Meychi That icon is barely noticable - I only saw it because I was actively looking for it.
Also, how can that icon be visible while File->Restart is disabled?

I just put something there, i'm trying to find a better one. The icon can be visible but restart action should be disabled for multi instance mode as restart doesn't work with instances properly.

Improvements done in 30e951c4b3260bc07d30321a8768d3f3d4ebe06e


this.options.head.noscript.push is not a function

HI,
Does anyone know about this? It is a bug or I've done something wrong?
It is happening when I try to build the app.
at ModuleContainer.gtmModule (node_modules/@nuxtjs/gtm/lib/module.js:93:32)
at ModuleContainer.addModule (node_modules/@nuxt/core/dist/core.js:235:34)
at node_modules/@nuxt/utils/dist/utils.js:1846:43
at async ModuleContainer.ready (node_modules/@nuxt/core/dist/core.js:55:5)
at async Nuxt._init (node_modules/@nuxt/core/dist/core.js:715:5)
Thank you!

I'm having the same kind of issue:
ERROR  Cannot read property 'find' of undefined
at server.js:11864:43
at promisify (.nuxt/utils.js:259:0)
at server.js:16750:60
at Array.map ()
at beforeRender (.nuxt/server.js:94:0)
at module.exports.webpack_exports.default (.nuxt/server.js:289:0)
at processTicksAndRejections (internal/process/task_queues.js:97:5)
The culprit code:
  ctx.beforeNuxtRender(() => {
    if (!inits.length && !events.length) {
      return;
    }
    // Here script is undefined
    const gtmScript = ctx.app.head.script.find(s => s.hid == 'gtm-script');
    gtmScript.innerHTML = `window['${_layer}']=${JSON.stringify(events)};${gtmScript.innerHTML}`;

    if (inits.length) {
      gtmScript.innerHTML += `;${JSON.stringify(inits)}.forEach(function(i){window._gtm_inject(i)})`;
    }

    const gtmIframe = ctx.app.head.noscript.find(s => s.hid == 'gtm-noscript');

    const renderIframe = id => `<iframe src="https://www.googletagmanager.com/ns.html?id=${id}&" height="0" width="0" style="display:none;visibility:hidden" title="gtm"></iframe>`;

    if (inits.length) {
      gtmIframe.innerHTML += inits.map(renderIframe);
    }
  });

I'm initializing GTM manually:
// plugins/gtm.js

export default function({ app, $config, $gtm, store }) {
  if (app.$featureToggle.toggles.gtm) {
    store.subscribe((mutation, state) => {
      if (mutation.type === 'MARKETPLACE_FETCHED') {
        const gtmIds = [
          ...state.marketplace.google_tag_id,
          $config.gtmMainId,
        ]
        gtmIds.forEach(gtmId => {
          $gtm.init(gtmId)
        })
      }
    })
  }
}

@superbiche Are you using a function for head inside nuxt.config?

@pi0 this is my head section:
  head: {
    ...commonConfig.head,
    title: 'Unic Stay - Book Fast Funnel',
  },

commonConfig.head comes from there:
module.exports = {
  mode: 'universal',
  /*
   ** Headers of the page
   */
  head: {
    title: process.env.npm_package_name || '',
    meta: [
      {charset: 'utf-8'},
      {
        name: 'viewport',
        content: 'width=device-width, initial-scale=1',
      },
      {
        hid: 'description',
        name: 'description',
        content: process.env.npm_package_description || '',
      },
    ],
    bodyAttrs: {
      class: ['Site'],
    },
  },
// ...
}

I've temporarily used a no SSR plugin approach as a workaround, which kinda works but I'm not sure it has no side effect.
Thanks for your help

Sorry for a late response. I've managed to find what was causing this error. It is the presence of noscript into the head. If it is removed, the build will not throw the error.

@pi0 I guess this should be reopened. Having no <noscript> in the <head> seems like a workaround to me.


destini app

@malavikasreekumar i see you ( ͡° ͜ʖ ͡°) xD

Looks Good,
Thanks For Contribution,
Leave a star and share with friends


Error during initialization Angular2.RC4

i adding the tag-input into my application. On init i getting an error:
Can't bind to '@fade' since it isn't a known native property.
Im running on Angular2 RC4.
My HTML is simple (copied from example page)
<tag-input [ngModel]="['@item']"
      [onlyFromAutocomplete]="true"
      [autocompleteItems]="['item1', 'item2']"
      [autocomplete]="true">
 </tag-input>

My Component:
@Component({
    selector: 'test-tag',
    templateUrl: 'tags.html',
    directives: [TagInput],
    providers: [NG_FORM_PROVIDER]
})

Error:
Can't bind to '@fade' since it isn't a known native property ("

    <!-- MENU -->
    <div class='ng2-dropdown-menu' [ERROR ->][@fade]="state.toString()">
        <ng-content></ng-content>
    </div>
"): Ng2DropdownMenu@6:35

Hi @moohkooh!
The latest version of this component is only compatible with Angular RC.5. If you want to use it with the RC.4 you may want to downgrade it to the version 0.2.2/0.2.1.
I obviously recommend to upgrade to Angular 2 to RC.5 :)

make sense 👍  Today i upgrade to RC.5. I needed to add a fromGroupName as attribute, but on autocomplete i getting an exception and the tags are on the middle of the control (is there maybe a problem with bootstrap?)

Autocomplete error msg:

platform-browser.umd.js:937 TypeError: Cannot read property 'state' of undefined
    at Ng2DropdownMenu.handleKeypress (ng2-dropdown-menu.ts:106)
    at eval (platform-browser.umd.js:1836)
    at eval (platform-browser.umd.js:1913)
    at ZoneDelegate.invoke (zone.js?1472024685631:332)
    at Object.onInvoke (core.umd.js:9245)
    at ZoneDelegate.invoke (zone.js?1472024685631:331)
    at Zone.runGuarded (zone.js?1472024685631:239)
    at NgZoneImpl.runInnerGuarded (core.umd.js:9278)
    at NgZone.runGuarded (core.umd.js:9510)
    at HTMLBodyElement.outsideHandler (platform-browser.umd.js:1913)

Screenshot: https://i.imgsafe.org/d51b04e6e1.png

@moohkooh that's interesting. Sorry, I did not understand if you did update or you are going to do it? :)
Can you paste here your package.json dependencies? I'll be able to understand a little more.
Thanks!

 Can you post some of your code(template and controller)?

Hi @moohkooh, I just published the version 0.2.4. It should fix this, let me know otherwise :)


Versioned Dev Builds for CI ✅

This PR is a prerequisite for https://github.com/ipfs-shipyard/ipfs-companion/issues/385 and ensures we have good times during QA/testing.
It adds a script that modifies manifest during the build, so that produced artifact is clearly marked as Dev Build and includes git revision it was built from:
build
└── ipfs_companion_dev_build_bd3da68_-<IP_ADDRESS>23.zip

Change is also present in Browser UI (addon listing):

And at Jenkins:

While I was at it I switched Docker image tags to git revision as well.
https://github.com/ipfs-shipyard/ipfs-companion/pull/397/commits/2eaa5d237b2968b821c14b53710b89859add9335  fixed Jenkins failure caused by abnormal branch names :ok_hand:

@VictorBjelkholm mind doing a sanity check from CI perspective? :)


namespace-private

When building a large library many classes need to define fields and methods that are meant only for use by other classes within the library, not the client. There is no simple way to express this in TypeScript. One can duplicate the entire public API in a set of mirror interfaces classes, but that creates a lot of duplicated code & doc maintenance, and sometime you really want to expose class names to the client. There appears to be a common convention of using the @internal JSDoc tag in this situation but it is not enforced by the compiler nor recognized by JSDoc.
The solution in Java is package-private access. The analogous mechanism in TS would be namespace-private access.

but it is not enforced by the compiler nor recognized by JSDoc.

The compiler flag you're looking for is --stripInternal, but it's not fully supported.
Is it fair to say this is a duplicate of #321?

Ah thanks. Perhaps more closely a duplicate of #5228
A fully supported --stripInternal would solve the problem. An 'internal' declaration modifier is a cleaner way to provide that without the noisy @internal JSDoc flag.


Use camelCase for Relations

I have some classes in CamelCase and with the current situation, the name of the relation becomes camelcase.
I think camelCase is more appropriate.

Have added a test, @WendellAdriel.

@WendellAdriel changed line endings to LF.


reduce the number of query overpass to avoid rejection of the overpass server

What do you think of the last update @vinber?

I haven't rejection of the overpass server :+1: , but more "temps d'attente dépassé" :(

This is weird... Does it happen from several places or just at home/work?
I don't have timeouts on my side.

i will try in other place this afternoon :)

For the record, the timeout is now 2 mn and the 1.6.0 version of leaflet-overpass-layer reduce significantly the number of simultaneous requests :)

I think it's ok now I close the issue. Feel free to reopen it if you see erros again ;)


feat: add static builds presets (1.x)

closes #938
supersedes #943

I'm performing a trial release in my fork before reviewing this pull request: https://github.com/qrkourier/ziti-tunnel-sdk-c/actions

@scareything Windows build error during the trial release in my fork: https://github.com/qrkourier/ziti-tunnel-sdk-c/actions/runs/10510568961/job/29119517808
[1/9] Creating directories for 'wintun-populate'
[1/9] Performing download step (download, verify and extract) for 'wintun-populate'
FAILED: wintun-populate-prefix/src/wintun-populate-stamp/wintun-populate-download D:/a/ziti-tunnel-sdk-c/ziti-tunnel-sdk-c/build/_deps/wintun-subbuild/wintun-populate-prefix/src/wintun-populate-stamp/wintun-populate-download
cmd.exe /C "cd /D D:\a\ziti-tunnel-sdk-c\ziti-tunnel-sdk-c\build\_deps && D:\a\_temp\507572093\cmake-3.27.7-windows-x86_64\bin\cmake.exe -P D:/a/ziti-tunnel-sdk-c/ziti-tunnel-sdk-c/build/_deps/wintun-subbuild/wintun-populate-prefix/src/wintun-populate-stamp/download-wintun-populate.cmake && D:\a\_temp\507572093\cmake-3.27.7-windows-x86_64\bin\cmake.exe -P D:/a/ziti-tunnel-sdk-c/ziti-tunnel-sdk-c/build/_deps/wintun-subbuild/wintun-populate-prefix/src/wintun-populate-stamp/verify-wintun-populate.cmake && D:\a\_temp\507572093\cmake-3.27.7-windows-x86_64\bin\cmake.exe -P D:/a/ziti-tunnel-sdk-c/ziti-tunnel-sdk-c/build/_deps/wintun-subbuild/wintun-populate-prefix/src/wintun-populate-stamp/extract-wintun-populate.cmake && D:\a\_temp\507572093\cmake-3.27.7-windows-x86_64\bin\cmake.exe -E touch D:/a/ziti-tunnel-sdk-c/ziti-tunnel-sdk-c/build/_deps/wintun-subbuild/wintun-populate-prefix/src/wintun-populate-stamp/wintun-populate-download"
ninja: build stopped: subcommand failed.

CMake Error at D:/a/_temp/507572093/cmake-3.27.7-windows-x86_64/share/cmake-3.27/Modules/FetchContent.cmake:1662 (message):
Error:   Build step for wintun failed: 1
Call Stack (most recent call first):
  D:/a/_temp/507572093/cmake-3.27.7-windows-x86_64/share/cmake-3.27/Modules/FetchContent.cmake:1802:EVAL:2 (__FetchContent_directPopulate)
  D:/a/_temp/50[757](https://github.com/qrkourier/ziti-tunnel-sdk-c/actions/runs/10510568961/job/29119517808#step:4:777)2093/cmake-3.27.7-windows-x86_64/share/cmake-3.27/Modules/FetchContent.cmake:1802 (cmake_language)
  programs/ziti-edge-tunnel/wintun.cmake:10 (FetchContent_Populate)
  programs/ziti-edge-tunnel/CMakeLists.txt:11 (include)

-- Configuring incomplete, errors occurred!

⏱ elapsed: 836.353 seconds
Error: "'D:\a\_temp\507572093\cmake-3.27.7-windows-x86_64\bin\cmake.exe' failed with error code: '1'.
    at CMakeRunner.<anonymous> (D:\a\_actions\lukka\run-cmake\v10.6\dist\index.js:5405:23)
    at Generator.next (<anonymous>)
    at fulfilled (D:\a\_actions\lukka\run-cmake\v10.6\dist\index.js:5220:58)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
Error: run-cmake action execution failed: 'Error: "'D:\a\_temp\507572093\cmake-3.27.7-windows-x86_64\bin\cmake.exe' failed with error code: '1'.'

That is awesome, guys!
Can't wait for a new release!

Thanks for contributing, @nenkoru! The first release that includes static binaries is 1.1.3.


Fix sub-resource storing the wrong index in cache

Fixes #49622
The subindex within Resource wasn't synchronized with the path stored in cache when saving a packed scene. It could cause sub-resources to be swapped when loading the same packed scene in the same session.
Now the subindex in Resource reflects the sub-resource path in cache, making saving and loading sub-resources consistent.
Credits to @latorril for finding the issue and investigating the cause.

Thanks!


Support encoded plan in plan meta

What problem does this PR solve?

Issue Number: close https://github.com/pingcap/tidb/issues/35964
What is changed and how it works?

Store encoded plan
Decode plan during query

/merge


chore: move some lemmas to Algebra.GroupWithZero.Center

From #13034.
Co-authored-by: Yaël Dillies<EMAIL_ADDRESS>

bors merge


Allow {{}} parameters in resource requests and limits

Summary
This is a popular request, and even thought there is a work-around, it keeps coming up. The workaround "podSpecPatch" is, well, it's a workaround. Not ideal.
We use the corev1.Container type for this. We could copy and modify this type to remove the validation constraints.

#2585
#3058

Message from the maintainers:
Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.

Too hard.

🙏

@alexec is this permanently off the table? This would be very very use for our use case. Can you supply additional details about what would need to happen to make this work and what the current roadblocks are?


CRD: fix allocation logic of identities with the same set of labels

Please read per commit, the overall idea is that in CRD mode we don't map which node has a particular identity and without this mapping it becomes tricky knowing which identity a particular node should hold or release the reference of.

test-me-please

Coverage decreased (-0.01%) to 46.819% when pulling 5f39d71b9e5b68dfefe0f9bb541015292eff3bfd on pr/fix-crd-bug into 9fbd82092def7ced2d520408435f61d6f6408848 on master.

test-me-please

test-me-please

test-me-please


Error displayed in PowerApp

The following error is displayed when opening the PowerApp.
VisitorManagementUserGallery.Run failed: { "error": { "code": 502, "source": "uk-001.azure-apim.net", "clientRequestId": "e64626ec-9304-404e-a754-d6770423f788", "message": "BadGateway", "innerError": { "error": { "code": "NoResponse", "message": "The server did not received a response from an upstream server. Request tracking id '08586054101973395960802446607CU15'." } } } }
When checking the Flow run:
Unable to process template language expressions for action 'Add_to_time' at line '1' and column '2316': 'In function 'addtotime', the value provided for date time string '31/07/2020' was not valid. The datetime string must match ISO 8601 format.'.
The Visitor List SharePoint list is being updated, but any visitors (confirmed or otherwise) are not visible within the admin applicaiton.

Same error over here. App is not working ok.

The following error is displayed when opening the PowerApp.
VisitorManagementUserGallery.Run failed: { "error": { "code": 502, "source": "india-001.azure-apim.net", "clientRequestId": "622953a1-fb45-4839-9267-5ee2989d811f", "message": "BadGateway", "innerError": { "error": { "code": "NoResponse", "message": "The server did not received a response from an upstream server. Request tracking id '0858604385204718045000562783CU13'." } } } }
when checking flow
Action 'Parse_JSON' failed under (ParseJSON)
"message": "Invalid type. Expected String but got Null.",

Exact same issue today with the date parsing when deploying for a client today. Disappointing that I raised this three months ago and the owners haven't fixed or given a solution to the issue. SharePoint list is updating correctly when new requests are added, but the two gallery flows (user and security) fail multiple times whenever someone opens the app.
@cristianoag Thanks for replying, but that's not the cause of the issue. All SharePoint activities within the various flows were checked both in my original case and today's.

I noticed this issue as well. It seems it has something to do with the regional settings on your device or browser. I'm yet to figure it out but i simply switched computers to "bypass" the error.

Simplest fix is to change the two gallery flows, so rather than pulling the date from the app (in the incorrect format due to regional differences) we can get it from an expression. This allows the two flows to run correctly, and both apps work perfectly fine following the change.


Add PowerPoint tutorial and other miscellaneous updates

New PowerPoint tutorial.
Update TOC to add links to PowerPoint tutorial in 2 locations, and to add a link for Excel add-in tutorial to the How-to guides > Excel add-ins section of the TOC.
Edit steps of the Excel tutorial to add note that redirects folks to the Introduction (start) page of the tutorial if they landed there via direct link.
Edit title and H1 of Excel tutorial (non-include) .md files to be more descriptive (for SEO).
Edit Use document themes in your PowerPoint add-ins article to fix multiple code formatting issues.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/breadcrumb/toc.yml
:white_check_mark:Succeeded

docs/images/powerpoint-tutorial-get-slide-metadata.png
:white_check_mark:Succeeded

docs/images/powerpoint-tutorial-go-to-first-slide.png
:white_check_mark:Succeeded

docs/images/powerpoint-tutorial-go-to-last-slide.png
:white_check_mark:Succeeded

docs/images/powerpoint-tutorial-go-to-next-slide.png
:white_check_mark:Succeeded

docs/images/powerpoint-tutorial-go-to-previous-slide.png
:white_check_mark:Succeeded

docs/images/powerpoint-tutorial-insert-image-button.png
:white_check_mark:Succeeded

docs/images/powerpoint-tutorial-insert-image-slide-design.png
:white_check_mark:Succeeded

docs/images/powerpoint-tutorial-insert-text.png
:white_check_mark:Succeeded

docs/images/powerpoint-tutorial-new-task-pane-ui.png
:white_check_mark:Succeeded

docs/images/powerpoint-tutorial-show-taskpane-button.png
:white_check_mark:Succeeded

docs/images/powerpoint-tutorial-solution-explorer-controllers.png
:white_check_mark:Succeeded

docs/images/powerpoint-tutorial-solution-explorer.png
:white_check_mark:Succeeded

docs/images/powerpoint-tutorial-start.png
:white_check_mark:Succeeded

docs/images/powerpoint-tutorial-stop.png
:white_check_mark:Succeeded

docs/includes/excel-tutorial-create-chart.md
:white_check_mark:Succeeded

docs/includes/excel-tutorial-create-table.md
:white_check_mark:Succeeded

docs/includes/excel-tutorial-filter-and-sort-table.md
:white_check_mark:Succeeded

docs/includes/excel-tutorial-freeze-header.md
:white_check_mark:Succeeded

docs/includes/excel-tutorial-open-dialog.md
:white_check_mark:Succeeded

docs/includes/excel-tutorial-protect-worksheet.md
:white_check_mark:Succeeded

docs/includes/excel-tutorial-setup.md
:white_check_mark:Succeeded

docs/includes/powerpoint-tutorial-customize-ui.md
:white_check_mark:Succeeded

docs/includes/powerpoint-tutorial-get-slide-metadata.md
:white_check_mark:Succeeded

docs/includes/powerpoint-tutorial-insert-image.md
:white_check_mark:Succeeded

docs/includes/powerpoint-tutorial-insert-text.md
:white_check_mark:Succeeded

docs/includes/powerpoint-tutorial-navigate-slides.md
:white_check_mark:Succeeded

docs/includes/powerpoint-tutorial-setup.md
:white_check_mark:Succeeded

docs/powerpoint/use-document-themes-in-your-powerpoint-add-ins.md
:white_check_mark:Succeeded

docs/toc.yml
:white_check_mark:Succeeded

docs/tutorials/excel-tutorial-create-chart.md
:white_check_mark:Succeeded

docs/tutorials/excel-tutorial-create-table.md
:white_check_mark:Succeeded

docs/tutorials/excel-tutorial-filter-and-sort-table.md
:white_check_mark:Succeeded

docs/tutorials/excel-tutorial-freeze-header.md
:white_check_mark:Succeeded

docs/tutorials/excel-tutorial-open-dialog.md
:white_check_mark:Succeeded

docs/tutorials/excel-tutorial-protect-worksheet.md
:white_check_mark:Succeeded

docs/tutorials/excel-tutorial-setup.md
:white_check_mark:Succeeded

docs/tutorials/powerpoint-tutorial-customize-ui.md
:white_check_mark:Succeeded

docs/tutorials/powerpoint-tutorial-get-slide-metadata.md
:white_check_mark:Succeeded

docs/tutorials/powerpoint-tutorial-insert-image.md
:white_check_mark:Succeeded

docs/tutorials/powerpoint-tutorial-insert-text.md
:white_check_mark:Succeeded

docs/tutorials/powerpoint-tutorial-navigate-slides.md
:white_check_mark:Succeeded

docs/tutorials/powerpoint-tutorial-setup.md
:white_check_mark:Succeeded

docs/tutorials/powerpoint-tutorial.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


API Integration

Get game infos
Use the api to add a game (give a list of games from our search)
Tags
Use steam / epic / etc api to get playtime of any game


Feature Request: RFID auth notification/state

Hi,
as this adapter is working quite well, I wanted to do some more advanced automation with it.
I own a P30 with RFID auth feature and would like to know if there is a way to see a successfull auth in one of the adapters variables. The P30 gives a positiv "beep" and a blue led in that case, but I couldn´t see any changes in the states.
What i want to do:

Auth with RFID at the P30
Detect this event with io broker
Send a signal to my car to unlock the charging port
Plug the charger into the vehicle

It seems that the states in the P30 are only updated if a vehicle is already plugged and also the sessions are not started by the RFID auth.
From the UDP Programmers Guide by Keba, I thought that "Enable sys" (enableSys) would provide this auth state.

I did some more tests and checked the adapter in debug logging.
Within the log I could see that "report 2" also includes the variables "authON" and "authReq", and the authReq is indeed changing if I present the RFID tag to the P30. I have to apologize, seems that I used an older version of the UDP programers guide, the new one includes the RFID variables with descriptions.
So my only request for a change would be the comment of the variable:
Currently it says: State of Authorization via RFID
Alternative: Authorization via RFID required
The manual defines:
False: Authorization via RFID card is not required. OR The authorization via RFID card was already
performed.
True: Authorization via RFID card is required.
With  State of Authorization via RFID = True I would assume that the authorization is given.
Thank you very much for the very fast reply and in general for the work on the adapter.

Thanks for your reply. I will change the comment as requested as soon as I'm back at home.

Please check new version on git. I'm not shure whether description is updated by update of adapter or if state has to be deleted before update to take place. I'd suggest in a first step to just update and check if text is updated.


Ingest any Two cQube 2 data sources

@ananya-jain1  Request to take a look

@TLSravani - request you to add relevant description to this issue so that we could resolve the same.

Invalid


ENH: Improve DICOM import speed

Testing DICOM import speed on Windows with Qt4, it turned out that excessive logging and progress updates slowed down the import by almost an order of magnitude.
Speed comparison example:
Baseline (without any changes):
"DICOM indexer has successfully processed 801 files [72.72s]"
After changing ctkDICOMIndexer to update progress report at every 10% increase (not at every processed file):
"DICOM indexer has successfully processed 801 files [37.53s]"
After cutting down on debug logs:
"DICOM indexer has successfully processed 801 files [11.46s]"

:+1:
Thanks for the fix, make complete sense.

Awesome!  👍

Great speed improvement, thanks Andras!


9.8 Critical CVE-2021-24112 Impacting Dependency

Describe the bug
Critical Severity bug from CVE-2021-24112 consumed from System.Drawing.Common following this implementation path:
<EMAIL_ADDRESS>›<EMAIL_ADDRESS>›<EMAIL_ADDRESS>›<EMAIL_ADDRESS>It appears this has been resolved in<EMAIL_ADDRESS>but there's only a release here to 5.0.2. Is there a resolution that could be applied to create a 5.0.3 version or do we need to jump straight to 5.1.0 and risk breaking changes?

Version numbers of this package and System.Drawing.Common are not related in any way. I think 5.0.2 will be the last 5.0.x release, so move to 5.1.1.

I can't speak for the SqlClient team and I haven't actually looked into this, but if there's indeed a security issue with 5.0.2, I  think this should at least be considered given that 5.0 is still in support.

there is a plan to backport that change to supported version 5.0.3, but time tbd. Greater versions such as 5.1 does not have that dependency.

@gravity-tthrockmorton M.D.SqlClient will be out of support in 8 days, and the next supported version does not have this issue. You can upgrade to a newer version to avoid that vulnerability.

@roji How do you want to handle this on Entity Framework Core as that is where the dependency resides?

Just add an explicit reference to the newer package

Closing since 5.0 is approaching out of support. This needs to be resolved within the package dependencies and is being pushed there.


Run buildifier over all relevant files.

Hey,
There's a lot of code changes here that are not yours.
I know it's not your fault, but wondering how we can prevent these (and accidental merge errors).
@vmax Git expert - any ideas? :)

@nlewycky would be best it you do git reset --hard master on your branch, re-run the buildifier and do git push --force

@nlewycky would be best it you do git reset --hard master on your branch, re-run the buildifier and do git push --force

Done. Please take a look!

Doh, thanks! Excluded third_party/maven as generated.


Updated README to correctly state default '--pool-size'

I might be wrong, but just in case I'm not, I think the actual default value of --pool-size is 4, and not the 8 stated in the README:
https://github.com/wal-e/wal-e/blob/8d1eefba556d9e9f160ada2dc0b39a062b4e70b6/wal_e/cmd.py#L246-L248

Bump


adding 147 Chrome dinosaur game

This is ready for review.  I removed several contributions that weren't loading.
Contribution 8 has a large repo of resources but no image or demo that I could find.
Please let me know if anything needs to be changed.

Thank you!!


feat: Added pool_maxsize in RequestsHttpConnection

Description
Provides custom connection pool size for RequestHttpConnection transport class
Issues Resolved
Closes proposal/issue #203

Would it make sense to provide an http_adapter_options structure that wraps all the other options available in HTTPAdapter?

@Neckbuster the implementation looks fine to me.  Also, can you add a unit test to ensure this works against our tests?

Totally missed the updates to this, apologies. Let's add some documentation to https://github.com/opensearch-project/opensearch-py/blob/main/GETTING_STARTED.md for it before merging?

Thanks @dblock Have updated documentation info, please have a look.

@harshavamsi @VachaShah 2nd pls? Let's merge this?


Consider checking in template generated code

Mixer2 adapter model defines templates in form of protos.
Mixer-Bazel codegen processes the templates to produce other protos and go code.
It is very convenient for an adapter developer to have the generated template artifacts in a repository to browse without needing to run codegen.
This could be checked into mixer or a separate templates repo.

@douglas-reid @kyessenov

@mandarjog can the solution to this issue be: Adapter developer build the mixer and then runs ./bin/bazel_to_go.py ? After this the generated code will all show up in the right directory as symlinks
Thoughts ?

@mandarjog friendly ping for my comment above.


add age plugin

.age
where birthday -> day-month-year
returns age
e.g. 20 years 5 months 1 day

So it would be
.age <<day>> <<month>> <<year>>
.age 5 19 94
> You are 24yrs 10mo. and 6 days old.

This can be closed.


Structure support in IntelliJ IDEA

I'm not sure where this request should go, but it would be really great to be able to see the tests in the IntelliJ IDEA structure tab, or a similar tab that the plugin could provide.
Ideally this would be similar to the test results structure, but listing the test cases within the class.

Ref: raniejade/spek-idea-plugin#9


Bubble Sort in C++

Description 📜

Domain of Contribution 📊

[] Android Dev (Flutter, Java, Kotlin)
[] Backend Dev (Java, .NET, Python)
[x] C/CPP
[] Competitive Programming
[] Cyber Security
[] DSA
[] Database
[] Datascience with Python
[] Datascience with R
[] Frontend Dev HTML/CSS/JS
[] Frontend Dev React/Angular/Vue
[] Golang
[] Interview Prep
[] Java_Domain
[] JavaScript
[] MERN
[] Machine Learning
[] Open Source
[] Python_Domain
[] Rust
[] Statistics
[] UI/UX

/assign

/assign

Hey! I want to work on this issue.


SNAPSHOT-2.0

Should JacobiTheta() be protected and not directly used?

https://github.com/Hipparchus-Math/hipparchus/blob/6694bb1c45fe714785677f2859931ce2fcbc96f6/hipparchus-core/src/main/java/org/hipparchus/special/elliptic/JacobiTheta.java#L55

It's a bug! It should be public.
I'll fix it in a few minutes.

Fixed in master brach.
Thanks for the report!

Same for FieldJacobiTheta?

Yes, I forgot it.
Note also that in the same package, the elliptic integrals (both Legendre and Carlson) are not complete yet
and there are known bugs I am working on. I hope to finalize this package this week.

We could provide these helper methods, sure. Please open a new issue for that so we don't forget about them.
Concerning caching, I prefer to let the user handle it. Depending on the problem to solve, the parameter m is either fixed or changes at each call. If it changes, caching would either consume a lot of memory or some strategy last least recently used eviction would be needed, and it would not be worth doing.

I'm thinking of a very simple cache by comparing m with the last value used in JacobiEllipticBuilder?


SVGs with multiple paths all get the "fill" color

As stated above, when using the color prop, if you have an SVG that contains multiple paths, each path gets the fill color. This results in the SVG being rendered as a solid square.
<svg version="1.1" viewBox="0 0 24 24" class="svg-icon svg-fill" data-v-4f1ab3a5="">
    <path fill="red" stroke="none" pid="0" d="M7.41 15.41L12 10.83l4.59 4.58L18 14l-6-6-6 6z">.
    </path>
    <path fill="red" stroke="none" pid="1" d="M0 0h24v24H0z" _fill="none"></path>
</svg>

This is because I anticipate that most icons will be a single color. If there is a single color icon with multiple paths, I only need one color for the color property.


Fix separate make and install execution error issue.

The install command has not been executed, it looks like it was caused by the separation of make and install.
Related: #8473.

@Christsnatcher @spindensity @oracleoftroy @timautry
Could you test it?
Thanks.

I've tested it. It works perfectly.
Thanks.

To be honest, I'm a bit surprised it worked, but it worked for me as well.
I don't know what vcpkg's policy is for making sure vcpkg still works if installed in paths with spaces, but I suspect the change on line 55 of vcpkg_build_make.cmake to remove the quotes around "${_VCPKG_PROJECT_SUBPATH}make" would break this use case. But if those quotes are contributing to this error in the first place, then I vote that they go.

@oracleoftroy Well, I think this is due to the simultaneous use of cmake_parse_arguments and execute_process. I don't know what cmake does in the command for the arguments behind the command.

Hmm, I see. I wish I understood cmake and vcpkg internals better. I got stuck at this part. It just surprised me that a few quotes added and removed was all it took. :)

I unfortunately still get the same error as before.

Thank you @JackBoosY, working fine here either.

@JackBoosY
The difference in cmake is:
 "i am not a list but a single element"
 i am a list
 "i;am;a;list"

@Neumann-A: The removal of these particular quotes apparently isn't necessary, I just tried and x264 building worked flawlessly with the quotes in place.

@JackBoosY I took a look at the quotes on line 55 this morning and I can confirm what @Christsnatcher says. I added quotes around just the make executable, changing line 55 to:
set(MAKE ${BASH} --noprofile --norc -c "${_VCPKG_PROJECT_SUBPATH}make")
I had no issue installing x264 with this change.

@JackBoosY: Got this error in WSL with this PR merged into my libpq PR:
CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:136 (message):
    Command failed: "make -j" 9
    Working Directory: /mnt/d/vcpkg_test/libpq_port/buildtrees/libpq/x64-linux-dbg
    See logs for more information:

Solved it with COMMAND "${MAKE};${MAKE_OPTS}" but this will brake your windows path. The problem is you are building the command wrongly. You want to build the bash and make command separatly. You then need to call excute_build_process with a list of commands in relation to the bash command and have the make command be passed as a single string to the bash command.

@Neumann-A I don't understand the difference between command and parameter splitting between windows and linux, but it is successful with your workaround.
Good work!

Thank you @JackBoosY  - does the job on both VS2017 and VS2019 latest builds. I appreciate the hard work you put in on this. Have a wonderful week.

Working perfectly now, a huge "Thank you" to everyone involved in fixing this issue!


Update makefile

What this PR does / why we need it:
This PR updates Makefile:

Adds a new release_tars target
Allows for more customization when building images (specify target platform, base image etc)
A bunch of small updates, such as the clean target now also removes _artifacts

All of this is mostly work towards reducing the amount of Bazel in our build/test infra, see #4030 (there have also been recent team discussions on this).
The release_tars target runs the Bazel rule that is used in cmrel- swapping that for a make target would allow us to gradually start building parts of release artificats by other means.
Special notes for your reviewer:
Release note:

NONE

/kind cleanup

/retest

/test pull-cert-manager-bazel

Trying the new upgrade test
/test pull-cert-manager-upgrade-v1-21


AppVeyor doesn't run eslint

What is the current behavior?
AppVeyor build doesn't run eslint, which is misleading in cases where eslint causes failures. Currently, if a build fails because of eslint (exactly what's happening right now),  AppVeyor will be reporting builds as success.
What is the expected behavior?
AppVeyor build should run eslint.

It's probably intentional that eslint only runs on Travis since it's supposed to be platform agnostic and that would just be duplicating work on AppVeyor. Are you experiencing a Windows specific eslint issue that isn't on the broken Travis build currently?

Not sure if it is Windows specific, but it is indeed occurring on Windows.

Ah, I remember seeing your issue on Reactiflux. If I were you, I'd rename this issue to reflect your unique eslint error on Windows rather than AppVeyor (though enabling eslint on AppVeyor could help detect this sort of issue in the future when the eslint build is fixed). Also you're using Jest's master branch, right? What if you checkout the latest stable release instead (or at least the last build that's passing on CI) before running eslint?

Also you're using Jest's master branch, right?

Yep, freshly cloned branch from master.

What if you checkout the latest stable release instead (or at least the last build that's passing on CI) before running eslint?

I could, however, I am trying to help on an already-pending PR, and (correct me if I am wrong here) that requires master branch to work.

GitHub PRs technically don't need to be based off master though maintainers may prefer or require it. I would try it at least as a troubleshooting step, if it works when basing off an earlier branch you might be able to track down which change broke this on Windows. Alternately you can use something like Windows Subsystem Linux for windows 10, a remote Linux dev machine, or a local VM with hyper v.

This is on purpose, to speed up AppVeyor builds as much as possible. ESLint is platform agnostic, and we happily assume that it gives the same results under both Windows and Unix systems. If something is failing for you on Windows, and not on Linux, it's a ESLint bug.

cc @cpojer please decide whether we need to run eslint on windows or not (I prefer not)

yeah, I'm fine without it.


wrap component for HMR only if it went through devComponent

I noticed that solid web site has two issues with the new (0.3) solid-refresh:
First, the AppData gets wrapped, although it's not a component at all.
Second, this code in ScrollShadow expects the result of Sentinel component to be a DOM node, and fails later with TypeError: Failed to execute 'appendChild' on 'Node': parameter 1 is not of type 'Node' because the result is actually a memo created in createProxy() in the solid-refresh code.
This is the fix for the first one -  I propose to add a special property ($HMRCOMP symbol key) to all components in the devComponent code in solid.js, so that only the functions that went through devComponent() will be wrapped in a memo.
There's corresponding PR in the solid repo that assigns $HMRCOMP key in devComponent() in signal.ts.

First, the AppData gets wrapped, although it's not a component at all.
This is true. 0.3 changed the heuristic from export-default to Pascal-cased components. The recommended fix was to rename these functions or just skip the file through /* @refresh skip */

Second, this code in ScrollShadow expects the result of Sentinel component to be a DOM node, and fails later with TypeError: Failed to execute 'appendChild' on 'Node': parameter 1 is not of type 'Node' because the result is actually a memo created in createProxy() in the solid-refresh code.

This was unexpected, of course I can't blame the users here, however ref and children(element) was the recommended and safer workarounds.

For the second one, I can't think of anything better than adding custom $NoHMR attribute, allowing users to opt-out from HMR if the user code is doing something directly with the component result.

I and Ryan had a discussion to add @refresh local-skip before however we decided that we can't find any benefit for the local pragmas.

so that only the functions that went through devComponent() will be wrapped in a memo.
This might be problematic as solid-refresh requires these  components to be wrapped in memo for the hot component replacement to occur. I'm not sure if you've tested your PR to prove this idea.

I'll probably raise the 1st and 2nd issues to solid-site instead. cc @davedbase

0.3 changed the heuristic from export-default to Pascal-cased components. The recommended fix was to rename these functions or just skip the file through /* @refresh skip */

Experience shows that the heuristic is over-optimistic. And the way it breaks user code is not friendly - for AppData, the error is
App.tsx:38 Uncaught TypeError: undefined is not iterable (cannot read property Symbol(Symbol.iterator))

on this line in App.tsx, where data comes from useData() router hook
  const [t, { locale }] = data.i18n;

How can a developer know that this is caused by over-eager HMR code wrapping the AppData, and the proper fix is to rename AppData?

This might be problematic as solid-refresh requires these components to be wrapped in memo for the hot component replacement to occur. Do take note that if a user decided to save their changes, it won't reflect to the hot reload as the component is never replaced. I'm not sure if you've tested your PR to prove this idea.

I just checked again - the wrapper in the createProxy() (where $HMRCOMP is checked) is the innermost one, it's called after the $HMRCOMP is assigned in the devComponent(), if that's what you are asking. In my limited testing, HMR seems to work with this change.

Also - about local vs per-file pragmas - the pragmas allow the component author to opt out from HMR. I think it would be good idea to have a way for the component user to be able to opt out for particular instance of the component too, like
  let sentinelFirstEl = (
    <Sentinel $NoHMR child="first" direction={direction} rtl={props.rtl} />
  ) as HTMLElement;

How can a developer know that this is caused by HMR code wrapping the AppData, and the proper fix is to rename AppData?

The heuristic is mentioned in the README

In my limited testing, HMR seems to work with this change.

Have you tried all the bundlers mentioned in the README?

It's interesting and clever to use a runtime mechanism to bridge the gap. No matter what we do with compiler heuristic we will over wrap slightly and people will be caught off guard. Even with the best instruction. We need to make sure we aren't missing anything. Easy to do. But I like this sort of thinking.

Updated the PR to remove the local opt-out part

One more update - fix style, also, for non-component case, add support for NotAComponent.bind(something)

There's an edge case that this might not work, but is fixable.
function NotAComp(props) {
  console.log(props);
}

function Comp(props) {
 typeof NotAComp(props) === 'function';
}

We should probably remove the HMR symbol before it gets passed to the component function.

Sorry not following. I changed this not to be the HMR symbol but to be the dev component symbol in Solid because I assumed it could have other value. So removing it makes it more special purpose.
Is this case if it is used as a Component in some places but not others?

I mean, if we're running a Component function, surely the HMR property is present, however passing the props as is to a function that was wrapped in hot but isn't really a function, the HMR property check might cause a false-positive.

the HMR property check might cause a false-positive.

I'm not sure I understand  - do you mean false-positive in the user code or in the solid-refresh code?
The property is added to the components functions themselves, not to their props, and it's added at runtime when the component function is called by the rendering code - so it's added to the Comp and not added to NotAComp - so that code example should not be affected I think

I mean since Comp is run as a component, the props should pass the HMR check, but then if we pass that same props object to a non-component function (NotAComp) that was wrapped by HMR, shouldn't the HMR check inside the proxy for NotAComp have a false-positive that the argument it received has HMR property and so it will run like a component?

I mean since Comp is run as a component, the props should pass the HMR check, but then if we pass that same props

props object does not have HMR property any more - I removed that part from the pull request, nothing touches props in the latest version of the PR code. It did that in the first version of the PR, but I force-pushed a couple of times, could you please have a look at the latest version of the changes here - https://github.com/solidjs/solid-refresh/pull/10/files
The property is added on the component function itself - the code in solid  adds it like
Object.assign(NotAComp, { [$DEVCOMP]: true });

It's a property with a computed name which is a unique symbol.
To get a false positive the user code should do something like
NotAComp[$DEVCOMP]

but the user code must import that $DEVCOMP symbol from solid, there's no other way to access that property - it will not be in the array returned by Object.keys(NotAComp) for example. And if the user code imports that symbol, one can be pretty certain it's done on purpose, not a false positive :smiley:
quote from https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Symbol

Symbols are often used to add unique property keys to an object that won’t collide with keys any other code might add to the object, and which are hidden from any mechanisms other code will typically use to access the object.

Ahh right, I missed the change. Seems good to me


Support mapping template to return text/html resopnse from API Gateway

We may not need to remove the Empty model in fluct deploy command because it will be used to return text/html response.

We also need to set integration response like this:

because output passthrough will render double-quoted response  like "test".

Done 09c8d0d05f24e54e88f25ec86db041da068960c8