AVIF compression not working - module not found

When trying to convert .jpg to .avif, invalid path is being generated:
thread sent an error! undefined:undefined: Cannot find module 'C:\C:\Users\gio\AppData\Roaming\nvm\v16.20.2\node_modules<EMAIL_ADDRESS>as you may have noticed, the path starts with "C:\C:"
this bug comes from @squoosh/cli, issue #1207 and issue #1119; possible solutions are suggested there; this error doesn't occur in<EMAIL_ADDRESS>but it exists in 0.7.2+ versions
To Reproduce
squoosh-cli --avif '{"$quality":40}' ~/Downloads/_images/raw_auto/.jpg
(instead of /Downloads/_images/raw_auto/.jpg set path to any folder with .jpg images inside)
Version:
OS: Windows 11
node: v16.20.2
npm: v9.8.1

Apologies for the delay in replying, it's been a crazy month and I need to set up a Windows env to test this.
I'll try have a look this week.

There is some deeper problem on Windows. Simply fixing paths to not contain 'C:\C:' does not fix the issue. Instead, the process now hangs after jpg processing starts. Rarely, an error is spat out indicating that cqLevel cannot be search for using in, so it appears some loop is making bad assumptions somewhere.
I'm not giving on this issue just yet, but I do have pressing deadlines to attend to. I'll resume investigation at a later stage.

@ScoobyDid Avif now works on both Windows and Linux.
The change was not as simple as changing file paths; there were multiple problems with avif, including incorrect parameter assignments and skipped defaults, so I'll leave the task open for a bit in case you experience problems. Let me know if it works for you.
The changes made were not to  squoosh-cli directly, but rather to a dependency, so the squoosh-cli version number remains the same. Specifically, you may need to purge libsquoosh to see the new changes.

@aggregate1166877
Awesome! I have reinstalled @frostoven/squoosh-cli and tested avif, webp & jpg compression and all works perfectly.
I have been using<EMAIL_ADDRESS>as a temp workaround, but now switched back to @frostoven/squoosh-cli.
Great work, thanks for supporting this package!


ModuleNotFoundError: No module named 'DCNv3'

Hello, thank you very much for your excellent work.I will provide the translation for your request. "DCNv3" refers to an external dependency library or an internal script within the code. When you are trying to run a test script and encounter the error.

meanwhile, i have done the step you publish in readme.md
cd intern4j/ops_dcnv3
rm -f build/
bash make.sh

I would like to ask, how did your problem be solved, is it solved, I also encountered the same problem, unable to download the module, DCNV3


Local api for api devices based on Fastapi

This PR aims at initiating a skeleton of an internal api for devices on sites using Fastapi framework

initiate a basic fastapi project structure
start the building blocks of the routes metrics and inference

Although incomplete, thanks to the self-documentation, there are snippets of documentation

What is not included (yet) :
[] comprehensive doc
[] some unit tests
[] CI
[] Security aspects
[] licence headers
There is still a lot of work to be done, but perhaps this will help to start the discussions about this api
Feedbacks are welcome

I have moved everything in a dedicated folder called server, added license headers and dummy tests for the routes !

Once again, this PR provides the structure of the local server, content of routes will come with others PRs !
@frgfm I would be happy to have your feedback :)

Thanks for the PR! I left some comments!

I will quickly implement some fixs related to your comments

@frgfm this is eventually quite empty web server that is eager to be completed :)
I think this okay now and we can go on with the next PRs to add core features !

@frgfm when you find the time to look at it ;)


[YUNIKORN-1676] E2E: Spark test times out

What is this PR for?
Increse the timeout, and decrese the executor count from 3 to 2, 2 is enough and will decrese the timeout problems.
Also the simple preempt also has similar problems, i inlcuded it in this PR.
What type of PR is it?

[x] - Bug Fix
[x] - Improvement
[ ] - Feature
[ ] - Documentation
[ ] - Hot Fix
[ ] - Refactoring

Todos

[ ] - Task

What is the Jira issue?

Open an issue on Jira https://issues.apache.org/jira/browse/YUNIKORN/
Put link here, and add [YUNIKORN-Jira number] in PR title, eg. [YUNIKORN-2] Gang scheduling interface parameters

How should this be tested?
Screenshots (if appropriate)
Questions:

[ ] - The licenses files need update.
[ ] - There is breaking changes for older versions.
[ ] - It needs documentation.

Thank you @craigcondit for review,
I also think increse timeout is not a good idea, but it seems hard for us to find the root flaky case.

@craigcondit
Change spark jobs kill to a stable way to delete pod one by one in latest PR.


Investigate NCBI FTP upload issue

This is in relation to the “FTP NCBI file upload failed” emails received on gwas-dev.

@ljwh2 @jdhayhurst - I had a look at the logs and then in the code and there's unfortunately not much to dig into. It seems that we just can't upload files to ftp-private.ncbi.nlm.nih.gov - but I can't tell you why because the code does not log the reason. It goes through 7 attempts and then abandons it altogether. We would probably have to get in touch with the US folks to understand why is this failing.

@JalMacArthur can you help with this? I don't know where this data is going

I agree that we will need to get in touch with NCBI to find out why this is failing.

@JalMacArthur what happens to the data when it gets to NCBI, is this going to PheGenI?

Yes, but it may go into other resources too.

I have forwarded relevant emails to gwas-dev

@sprintell need to find out why failure emails are still arriving


Meet problems when test the performance of  stage2 models

I want to test the performance of the videochat2_mistral on the dataset after viusl-language alignment in stage 2, so I set checkpoint_math to None, but the inference result contains repeated garbled characters.
The initialization code for the model is following demo_mistral.ipynb:
# load stage2 model
cfg.model.vision_encoder.num_frames = 4
model = VideoChat2_it_mistral(config=cfg.model)

# add lora to run stage3 model
peft_config = LoraConfig(
    task_type=TaskType.CAUSAL_LM, inference_mode=False,
    r=16, lora_alpha=32, lora_dropout=0.,
    target_modules=[
        "q_proj", "k_proj", "v_proj", "o_proj",
         "gate_proj", "up_proj", "down_proj", "lm_head"
    ]
)
model.mistral_model = get_peft_model(model.mistral_model, peft_config)

# But there is no state_dict loading，the code is annotated
# state_dict = torch.load("your_model_path/videochat2/videochat2_mistral_7b_stage3.pth", "cpu")
# if 'model' in state_dict.keys():
#     msg = model.load_state_dict(state_dict['model'], strict=False)
# else:
#     msg = model.load_state_dict(state_dict, strict=False)
# print(msg)

But the result generated by inference contains repeated garbled characters as follows:

I found that there is no lora on the stage2 image, so I comment the code for adding lora：
# load stage2 model
cfg.model.vision_encoder.num_frames = 4
model = VideoChat2_it_mistral(config=cfg.model)

# add lora to run stage3 model
# peft_config = LoraConfig(
#   task_type=TaskType.CAUSAL_LM, inference_mode=False,
#    r=16, lora_alpha=32, lora_dropout=0.,
#    target_modules=[
#        "q_proj", "k_proj", "v_proj", "o_proj",
#         "gate_proj", "up_proj", "down_proj", "lm_head"
#    ]
#)
# model.mistral_model = get_peft_model(model.mistral_model, peft_config)

# But there is no state_dict loading，the code is annotated
# state_dict = torch.load("your_model_path/videochat2/videochat2_mistral_7b_stage3.pth", "cpu")
# if 'model' in state_dict.keys():
#     msg = model.load_state_dict(state_dict['model'], strict=False)
# else:
#     msg = model.load_state_dict(state_dict, strict=False)
# print(msg)

But an error occurs when inferecing:

I don't know what went wrong here, I hope to get help. Thank you very much！

I successfully disabled Lora, but the inference answer still contains garbled text

Hi, as you asked in the WeChat group, the stage 2 model is recommended for captioning rather than QA tasks. After removing the lora module, it can generate video-to-text normally, but the conversational ability may decline as expected. If you have any questions, feel free to open this issue or continue asking in the WeChat group. Below is the WeChat for GV Assistant.

Hello @Qnancy , I encounter the exactly same issue like you - I try to evaluate Stage 2 model by letting it generate() answer, but the output text is meaningless words.
Were you able to solve that later on? Or is there anything I should know?
Thank you!

Hello @Qnancy , I encounter the exactly same issue like you - I try to evaluate Stage 2 model by letting it generate() answer, but the output text is meaningless words.
Were you able to solve that later on? Or is there anything I should know?
Thank you!

Yes, that's because the model after stage 2 hasn't undergone instruction fine-tuning yet, so its ability to follow instructions is weak. It can only perform simple captioning (often accompanied by repetitive outputs).


Barrage Ability (Sentinels, Archer)

Mechanically the ability is fine.

New Icon, currently shares an icon for a very similar but single target arrow based ability
New Name, currently shares the name of a vanilla Wc3 ability but does something different

Ideally it would also be better if they did not stack but that is more personal preference for me.

Let's call this one a bug, you've identified that it doesn't meet the ability guidelines!


Getting ReadTimeoutError while trying the quickstart sample on the ReadMe

Getting ReadTimeoutError while trying the following code,
from ragrank import evaluate
from ragrank.dataset import from_dict
from ragrank.metric import response_relevancy

# Define your dataset
data = from_dict({
    "question": "What is the capital of France?",
    "context": ["France is famous for its iconic landmarks such as the Eiffel Tower and its rich culinary tradition."],
    "response": "The capital of France is Paris.",
})

# Evaluate the response relevance metric
result = evaluate(data, metrics=[response_relevancy])

# Display the evaluation results
result.to_dataframe()

output is like shown below
Evaluating : 100%|█████████████████████████████████████████████████| 1/1   remain: 00:00s,  1.42it/s
---------------------------------------------------------------------------
TimeoutError                              Traceback (most recent call last)
[/usr/local/lib/python3.10/dist-packages/urllib3/connectionpool.py](https://localhost:8080/#) in _make_request(self, conn, method, url, body, headers, retries, timeout, chunked, response_conn, preload_content, decode_content, enforce_content_length)
    535         try:
--> 536             response = conn.getresponse()
    537         except (BaseSSLError, OSError) as e:

26 frames
TimeoutError: The read operation timed out

The above exception was the direct cause of the following exception:

ReadTimeoutError                          Traceback (most recent call last)
ReadTimeoutError: HTTPSConnectionPool(host='ragrank-trace.onrender.com', port=443): Read timed out. (read timeout=10.0)

During handling of the above exception, another exception occurred:

ReadTimeout                               Traceback (most recent call last)
[/usr/local/lib/python3.10/dist-packages/requests/adapters.py](https://localhost:8080/#) in send(self, request, stream, timeout, verify, cert, proxies)
    711                 raise SSLError(e, request=request)
    712             elif isinstance(e, ReadTimeoutError):
--> 713                 raise ReadTimeout(e, request=request)
    714             elif isinstance(e, _InvalidHeader):
    715                 raise InvalidHeader(e, request=request)

ReadTimeout: HTTPSConnectionPool(host='ragrank-trace.onrender.com', port=443): Read timed out. (read timeout=10.0)

I used a google colab for running the code.

The ReadTimeoutError often indicates network issues or server-side delays
If you're running this on Google Colab and experiencing timeout issues, consider running the code on your local machine instead, if possible. Sometimes the cloud environment may have issues with network requests
from ragrank import evaluate
from ragrank.dataset import from_dict
from ragrank.metric import response_relevancy
from requests.exceptions import ReadTimeout
Define your dataset
data = from_dict({
"question": "What is the capital of France?",
"context": ["France is famous for its iconic landmarks such as the Eiffel Tower and its rich culinary tradition."],
"response": "The capital of France is Paris.",
})
try:
# Evaluate the response relevance metric
result = evaluate(data, metrics=[response_relevancy])
# Display the evaluation results
df = result.to_dataframe()
print(df)
except ReadTimeout as e:
print(f"Request timed out: {e}")


walrus operator

Describe the feature you are requesting
:=
Reasons for requesting this feature
:=
Describe alternatives you've considered
:(
Additional context
:=

https://github.com/microsoft/PTVS/issues/5573


Feature Request: Bindable AutomationId Property for Each Digit in PINView for UI Testing

I am currently using your PINView.Maui library for my project, and it's been very helpful—thank you for your work on it!
For UI automation testing, I need a way to assign unique identifiers to each digit in the PIN view. Could you please add a bindable AutomationId property for each individual digit? This would greatly assist in creating reliable UI tests by allowing us to target each digit field independently.
Thank you for considering this request, and I look forward to any updates

Hi @alpayclsr1
Those boxes are just UI representation of digits but those are not actual inputs. This control actually have 1 single Entry control behind the scene which holds all digits as a single string in one textbox.
May be I can provide AutomationId for that single Entry control if that works for you ?

Hi @MGohil  Yes, if you can provide the AutomationId for that single Entry control, it would be incredibly helpful. Thank you so much! I’d greatly appreciate it if you could add it in the next version.

@alpayclsr1 : I have added AutomationId property in V 1.0.3
This control uses Hidden Entry behind the scene to hold PIN input value. To work with Automation, you have to set AutomationId of this PINView control, and it will internally set the AutomationId of this hidden Entry.
Example: If you set AutomationId of PINView control as 'ConfirmPIN' then AutomationId of hidden Entry will be 'ConfirmPIN_PINView_Entry'. You can get the hidden Entry's AutomationId using HiddenEntryAutomationId property.


[DOCS] Handling multiple azure_subscription_id, azure_client_id and azure_client_secret with Azure Brokerpack

Documentation Requested
I would like to know if it's possible to use multiple azure_subscription_id, azure_client_id and azure_client_secret with the Azure Brokerpack.
Currently, we have our main azure_subscription_id, azure_client_id and azure_client_secret configured in the tile.
We would like to send some services to a different azure_subsciption, so I would like to know if it's possible to set different default settings on a plan basis or create different Azure services that would create the service on a different subscription then the default configured one in the tile?
We are changing our deployment model and creating different servers for each orgs, so we need to be able to handle multiple subscriptions or else we hit Azure limits on the amount of resource-groups and/or Azure servers within a subscription.
If we can have a discussion or documentation/recommendation on how to handle this case it would be appreciated.

I was able to test successfully but have a follow up question.
When we set a default setting in a plan, is that value taken as a default setting or overrides the user provided setting at the cf CLI?
Reason I asked is because when I specify a server in the plan, I can't seem to override that value with using the parameters in the cf CLI. Is that only for the server parameter or all parameters?
If it overrides it, it means I would be able to lock user provided parameters by setting those options in the plan? (Which is something we're looking to do for some parameters).

I was able to test successfully but have a follow up question.
When we set a default setting in a plan, is that value taken as a default setting or overrides the user provided setting at the cf CLI?
Reason I asked is because when I specify a server in the plan, I can't seem to override that value with using the parameters in the cf CLI. Is that only for the server parameter or all parameters?
If it overrides it, it means I would be able to lock user provided parameters by setting those options in the plan? (Which is something we're looking to do for some parameters).

@erniebilling Would it be possible to answer my previous quesiton? I'll then be able to close this issue.
Thanks!

@erniebilling Would it be possible to answer my previous quesiton? I'll then be able to close this issue.
Thanks!

@drebake sorry for my tardiness on this. Any plan provided value will override any use provided value. So if a value is set in the plan, a user may not override with -c {...}
Does that help?

@drebake sorry for my tardiness on this. Any plan provided value will override any use provided value. So if a value is set in the plan, a user may not override with -c {...}
Does that help?

Yes, exactly the confirmation I was looking for.
Thanks

Yes, exactly the confirmation I was looking for.
Thanks


Fixed the gaussian and sinc pulses to have the correct fwhm

As discussed in https://github.com/laserfun/laserfun/issues/65, the gaussian and sinc pulses did not correctly treat the fwhm_ps parameter. This fixes this bug.

We may want to have a unit test for the pulse duration.


leap: The test cases/descriptions  should get improved

Related PR #453
The discussion on that PR led to the conclusion that the test cases

are not well chosen
should get a better description as to why the test case is useful/necessary

I promised to work on them, will start now.

Thanks @guntbert :heart:


WLAN Manager integration and minor fixes

Needed some configrable wifi manager, added offset parameter to better define, where 12 o'clock is (using it now also as linear clock), integrated solutions of https://github.com/leonvandenbeukel/Round-LED-Clock/issues/12 and tryed to improve ESP8266 first pixel flickering bahaviour

Hello, I have a problem, once all the connections have been made, the 60 LEDs all light up in sequence, first blue, then green, after that nothing happens, all the LEDs stay green.
how can i solve? then how do I change the time and how do I connect the wifi. thank you all

If LEDs are all green the ESP should have connected to your wifi configured in the WiFiManager-Portal (see below: "Yellow LEDs").
My implementation of WifiManager is a little bit "blue eyed". Sometimes I have to repower the ESP cause it somehow can not connect to the final wifi even configuration was correctly entered in the portal. But this was mostly an issue with my router which did not accept the device (when router was set to only accept known devices).
If all LEDs are yellow ESP is in config mode. This means the ESP opens an access point you can connect to and configure your target wifi-connection. The SSID of the temporary AP is in form of "RC[ESP-ChipId]" default pass "roundclock". You can change this in the autoconnect() call
More about you can read in the WiFiManager documentation
Time is pulled from a NTP-Server. You can specify the ntp-server-url incode on this line

on my setup only 1 led white and system crashes.


How to cluster deploy?

i will deploy several instance, how to cluster and load balance?

@hanyou , all our components are supporting clusterization: Apache Wicket and OrientDB. But we haven't tested fully this deployment type. If your needs under 500 concurrent users: average hardware wtih singly Orienteer can handel that. But if you are especially interested in clustering - lets colloborate closely on this topic.


[DRAFT] [Silabs] Update to WiseConnect 3.3.2

Change
Updated wifi_sdk submodule from WiseConnect v3.3.1 to v3.3.2.
Testing
This WiseConnect update contains documentation changes only. To be extra safe, validated that lighting-app and lock-app compile and run successfully (QR code shows up) on BRD4338A (which uses WiseConnect codebase).

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

docker update isn't needed to merge v3.3.2 wifi sdk?


Fix phrasing

Improved phrasing of how to move subscriptions to your routing.js file.

thanks @Unavi


Support automatic DNS lookup for kafka bootstrap servers

What type of enhancement is this?
User experience
What does the enhancement do?
Amazon MSK users can only obtain bootstrap server addresses in the form of b-1.niebayesmskcluste.vekjkv.c2.kafka.ap-southeast-1.amazonaws.com:9094. However, greptimedb requires addresses in the form of <IP_ADDRESS>:9094. Therefore, we need to support automatic DNS lookup to obtain available bootstrap server addresses.
Implementation challenges
No response

Currently, users are required to provide their own broker_endpoints for Kafka wal, or the default endpoint <IP_ADDRESS>:9092 would be used. See the provisioned example configuration files, for e.g. https://github.com/GreptimeTeam/greptimedb/blob/6628c41c3663bb22b41fee3dd10f0edd0769802d/config/metasrv.example.toml#L57-L58
However, users may not able to obtain broker endpoints in the form of <IP_ADDRESS>:9092, but in the form of b-1.niebayesmskcluste.vekjkv.c2.kafka.ap-southeast-1.amazonaws.com:9094 which requires DNS lookup.
We want to eliminate the need for users to manually perform DNS lookup and instead perform automatic DNS lookup within greptimedb.
There might have two methods to accomplish this task (Any other solutions are welcome):

Check broker endpoints whenever we use them. If they're not in the form of <IP_ADDRESS>:9092, perform a DNS lookup.
Modify the deserialization logic for broker_endpoints to perform an automatic DNS lookup when necessary. You may find the serde crate useful.

The definitions of wal configs reside in this file.

I would like to offer some help. I've found a simple crate dns-lookup and would like to implement it in the second way.

@J0HN50N133 Cool. Go ahead and welcome to ping @niebayes or me as a reviewer when you prepare a patch :D


Fix errors caught by lints

Fixed loosing errors
Fixed naked returns in big functions
Removed erroneous golint from //nolint annotations

Codecov Report
Base: 32.57% // Head: 32.63% // Increases project coverage by +0.06% :tada:

Coverage data is based on head (49aefb2) compared to base (07e7a47).
Patch coverage: 38.77% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #708      +/-   ##
==========================================
+ Coverage   32.57%   32.63%   +0.06%
==========================================
  Files         128      128
  Lines       14226    14226
==========================================
+ Hits         4634     4643       +9
+ Misses       9164     9157       -7
+ Partials      428      426       -2

Impacted Files
Coverage Δ

api/server/v1/cache.go
0.00% <0.00%> (ø)

server/metrics/datadog.go
42.25% <ø> (ø)

server/services/v1/database/sessions.go
5.57% <0.00%> (ø)

server/transaction/manager.go
2.51% <0.00%> (ø)

server/metadata/tenant.go
28.61% <21.42%> (-0.23%)
:arrow_down:

server/services/v1/database/query_runner.go
4.58% <33.33%> (ø)

api/server/v1/marshaler.go
11.21% <45.00%> (+1.27%)
:arrow_up:

query/filter/key_builder.go
89.69% <100.00%> (ø)

schema/inference.go
85.35% <100.00%> (ø)

schema/schema.go
53.99% <100.00%> (ø)

... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[test] Use dd instead of head -c.

head -c, to print the specified number of bytes, is a GNU extension.
Using dd for the same task should be somewhat more portable.

I wonder if it really is more portable ...

@swift-ci please test Windows platform

(I've briefly thought about whether py versions of the tools tests expect might be a good idea, but that's another kettle of fish...)

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - d06745777d466dd0c9b2e4a0a3bafa54bc089f4c

Okay, Mac OS X dd doesn't support status. Reworking...

Updated to use |& to make up for the lack of status=none on OS X. The grep will still behave as intended even if the dd status message gets input anyway; we shouldn't try to do anything more precise than that since the lit shell runner may not support it.

So, |& is indeed wrong, and forcing LIT_USE_INTERNAL_SHELL is a good way to confirm that when running the tests. I had avoided using 2>/dev/null thinking that would not be compatible, but this is actually what ought to work perfectly, since lit will translate this to a temporary file.
I've done so here. Sorry for the confusion!

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - d06745777d466dd0c9b2e4a0a3bafa54bc089f4c

Build failed
Swift Test OS X Platform
Git Sha - d06745777d466dd0c9b2e4a0a3bafa54bc089f4c

@swift-ci please test Windows platform


Insufficient parenthesizing

This issue is very very close to #131, and it is very serious problem in my production (it turns out, contrary to what I said in #131, that we do depend on unparser on such code).
The test case is very similar, but different: return true ? 1 : 2 is pretty-printed as
return if true
  1
else
  2
end

which is again wrong, since in that case return if true is a postfix condition.
$ unparser -e 'return true ? 1 : 2' --verbose
warning: parser/current is loading parser/ruby27, which recognizes
warning: 2.7.2-compliant syntax, but you are running 2.7.1.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.
(string):3:1: error: unexpected token kELSE
(string):3: else
(string):3: ^~~~
(string)
Original-Source:
return true ? 1 : 2
Generated-Source:
return if true
  1
else
  2
end
Original-Node:
(return
  (if
    (true)
    (int 1)
    (int 2)))
Generated-Node:
#<Parser::SyntaxError: unexpected token kELSE>
/opt/local/lib/ruby2.7/gems/2.7.0/gems/parser-<IP_ADDRESS>/lib/parser/diagnostic/engine.rb:72:in `process'
/opt/local/lib/ruby2.7/gems/2.7.0/gems/parser-<IP_ADDRESS>/lib/parser/base.rb:285:in `on_error'
(eval):3:in `_racc_do_parse_c'
(eval):3:in `do_parse'
/opt/local/lib/ruby2.7/gems/2.7.0/gems/parser-<IP_ADDRESS>/lib/parser/base.rb:189:in `parse'
/opt/local/lib/ruby2.7/gems/2.7.0/gems/unparser-0.5.3/lib/unparser.rb:98:in `block in parse_either'
/opt/local/lib/ruby2.7/gems/2.7.0/gems/mprelude-0.1.0/lib/mprelude.rb:85:in `wrap_error'
/opt/local/lib/ruby2.7/gems/2.7.0/gems/unparser-0.5.3/lib/unparser.rb:97:in `parse_either'
/opt/local/lib/ruby2.7/gems/2.7.0/gems/mprelude-0.1.0/lib/mprelude.rb:168:in `bind'
/opt/local/lib/ruby2.7/gems/2.7.0/gems/unparser-0.5.3/lib/unparser/validation.rb:63:in `from_string'
/opt/local/lib/ruby2.7/gems/2.7.0/gems/unparser-0.5.3/lib/unparser/cli.rb:40:in `validation'
/opt/local/lib/ruby2.7/gems/2.7.0/gems/unparser-0.5.3/lib/unparser/cli.rb:143:in `public_send'
/opt/local/lib/ruby2.7/gems/2.7.0/gems/unparser-0.5.3/lib/unparser/cli.rb:143:in `process_target'
/opt/local/lib/ruby2.7/gems/2.7.0/gems/unparser-0.5.3/lib/unparser/cli.rb:133:in `block in exit_status'
/opt/local/lib/ruby2.7/gems/2.7.0/gems/unparser-0.5.3/lib/unparser/cli.rb:132:in `each'
/opt/local/lib/ruby2.7/gems/2.7.0/gems/unparser-0.5.3/lib/unparser/cli.rb:132:in `exit_status'
/opt/local/lib/ruby2.7/gems/2.7.0/gems/unparser-0.5.3/lib/unparser/cli.rb:64:in `run'
/opt/local/lib/ruby2.7/gems/2.7.0/gems/unparser-0.5.3/bin/unparser:10:in `<top (required)>'
/opt/local/bin/unparser:23:in `load'
/opt/local/bin/unparser:23:in `<main>'
Error: (string)

Cheers!

@akimd Valid issue, given you ran it through the unparser self check that fails. Also interesting neither rubyspec nor parsers test suite hit this construct.
This means I need an even wider ruby corpus to test against. Can you recommend a public one? Or can you contact me in private (if you happen to have a large code base you may be able to share for this propose).
Its likely that unparser actually has to learn to emit these ifs ifs as ternary, because only they can produce that exact AST, given its an argument to return. Adding parenthesis may produce a begin node which would invalidate the "exact" AST guarantee.
Unparsers internal changes for 2.7 support (they where more a re-write) make it more easy to direct the code emitting to specific forms.
I cannot guarantee I can get to this issue very soon, while mutant is primarily funding this OSS project, it does not feed me well enough at this point, I've to priorize my consulting work.
There are some possible workarounds I'm happy to discuss (also contact me in private) on this issue, it depends on the actual use case.

Hi!
Thanks for the fast answer.

This means I need an even wider ruby corpus to test against. Can you recommend a public one?

I'm afraid I am not well versed enough for this.  In my case we run source to source transformation on the AST and pretty-print it at the end.

Or can you contact me in private (if you happen to have a large code base you may be able to share for this propose).

I'm sorry I have nothing to offer here :(  And I do understand your concern.  What I can do is submit such test cases when we encounter them.  Might not protect from lurking issues, but should protect from regressions.

Its likely that unparser actually has to learn to emit these ifs ifs as ternary, because only they can produce that exact AST, given its an argument to return. Adding parenthesis may produce a begin node which would invalidate the "exact" AST guarantee.

Bummer...  That's a dirty catch 22.  Never though about that constraint.

I cannot guarantee I can get to this issue very soon, while mutant is primarily funding this OSS project, it does not feed me well enough at this point, I've to priorize my consulting work.

Ok.  We have reverted to older versions of parser/unparser that did not exhibit this issue.

There are some possible workarounds I'm happy to discuss (also contact me in private) on this issue, it depends on the actual use case.

I can see that forcing the parens would help (return (1 ? 2 : 3)).  I'll see our team if this is applicable to us.
Cheers!

We run source to source transformation on the AST and pretty-print it at the end.

2 things here:

Its not really pretty printing, its unparsing. Unparsers output is "far from pretty" but could be made so (I've no reason to spend time on that metric ATM). Better not call it pretty printing if it can create so ugly source ;)
Its important to realize that unparser "only" has the guarantee: It produces source that if parsed via parser produces the SAME ast if parsed again.

The latter has an important consequence: If you transform AST, make sure that you know what parser would produce.
Example:
ruby-parse -e 'foo while foo = bar'
(while
  (lvasgn :foo
    (send nil :bar))
  (send nil :foo))

the foo body of the while is a send.
ruby-parse -e 'foo = 1; foo while foo = bar'
(begin
  (lvasgn :foo
    (int 1))
  (while
    (lvasgn :foo
      (send nil :bar))
    (lvar :foo)))

The foo of the while body is an lvar read!
This is because the local variable scope is different. If you are doing AST transforms, make sure the AST you generate really expresses the semantics you desire and captures the effects like the lvar scope changes.
Also its important to keep in mind there is a wide range of AST you may generate, that parser would never return from parsing. Unparser will, in the current versions: NOT prevent you from unparsing tehse into (potentially) valid source.
In the next version of unparser, I plan a new API that would unparse than parse again, to make sure it filters out these cases where artificially constructed AST is passed that "cannot" be generated by parser.
For some private tooling that does source transform (smelling like the ones you indirectly describe) I use such APIs already to prevent this case.

Its not really pretty printing, its unparsing. Unparsers output is "far from pretty" but could be made so (I've no reason to spend time on that metric ATM). Better not call it pretty printing if it can create so ugly source ;)

I see very well what you mean here.  Indeed, unparser does not have any support of boxing, or managing with etc., so it is rather a crude pretty-printer.  Yet, it indents.  That's were I usually cut the line.  The intended reader is clearly a human, if it were solely for the sake of the machine, it could be much more terse.

Its important to realize that unparser "only" has the guarantee: It produces source that if parsed via parser produces the SAME ast if parsed again.

Yup, I'm also well aware of this.  And I do understand that shaking the AST does not guarantee in anyway that it is still valid.
But we pay attention to that.  Besides, our transformations are mostly related to sanity-checks, there's nothing really deep, AFAIK.

the foo body of the while is a send.
[...]
The foo of the while body is an lvar read!

Yup, already found about that, thanks :)
Cheers!

So yes, (return (if ...)) can only be returned from parser on a return with a ternary expression. Unparser has to learn about this and emit the if as ternary.
bundle exec unparser -e 'return(true ? 1 : 2)' --verbose
mutant-dev@mbj ~/devel/unparser (fix/return-parens) $ bundle exec unparser -e 'return(true ? 1 : 2)' --verbose
(string)
Original-Source:
return(true ? 1 : 2)
Generated-Source:
return (if true
  1
else
  2
end)
Original-Node:
(return
  (begin
    (if
      (true)
      (int 1)
      (int 2))))
Generated-Node:
(return
  (begin
    (if
      (true)
      (int 1)
      (int 2))))
Success: (string)

This is a different AST, hence unparer cannot emit parens to unparse return true ? 1 : 2.

Also affected:

next
break

Also note this one:
bundle exec unparser -e 'return 1, true ? 1 : 2' --verbose
(string)
Original-Source:
return 1, true ? 1 : 2
Generated-Source:
return 1, if true
  1
else
  2
end
Original-Node:
(return
  (int 1)
  (if
    (true)
    (int 1)
    (int 2)))
Generated-Node:
(return
  (int 1)
  (if
    (true)
    (int 1)
    (int 2)))
Success: (string)

So "only" if its a single argument it needs to be ternary. Love you Ruby.

@akimd I fixed this one. And released at 0.5.4. Please consider my GH sponsor button.

You have been fast, thanks a lot @mbj!
We will try it today, and report our mileage.
Many thanks for your time.

You have been fast, thanks a lot @mbj!

Only possible due the huge amount of time invested on refactorings before. Making a better test suite, CI setup, internal code structure etc.

We will try it today, and report our mileage.

Ping. I want to get mentally pas this one ;)

I have just been confirmed that with the bug fix, our problem was solved.  Thanks!

I have just been confirmed that with the bug fix, our problem was solved.  Thanks!

Thanks, I love closing open mental loops. Cheers.

Thanks, I love closing open mental loops. Cheers.


Component TreeView works with HashSet instead of the more generic ICollection

Feature request type
Enhance component
Component name
TreeView
Is your feature request related to a problem?
I need to work with an orderly list of items in the tree view, instead of a set of items in a collection without any order. This would be possible if the component would operate on ICollection<T> instead of HashSet<T> as in version 6.0.7. Most, if not all, collections in .NET implements ICollection<T>, leaving me with the option of the collection behavior for my own purposes.
Describe the solution you'd like
Change the collection type from HashSet<T> to ICollection<T>.
Have you seen this feature anywhere else?
No response
Describe alternatives you've considered
No response
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I believe this is actually a bug, a lot of issues are related with this, most problematic being:

When removing items, the selected item behaves in weird ways, the item on the place of the one that was deleted stays selected.
Also when removing the last element from a parent, the instance of it is still present "somewhere" as every place on the page that references that element still sees it as part of the tree view. - had huuuge issues with this, and days of debugging only to arrive at the conclusion that the tree view internal workings are to be blamed.
Not to mention the hassle of integrating it with your existing lists. I think it should be prioritised. There's no other component to which I had so many problems as the TreeView.
@JonBunator do you know about these issues? Should I describe them in more detail and provide links to reproduce them?

Yes, please reproduce them. That would be great. We already did something similar with MudTable https://github.com/MudBlazor/MudBlazor/pull/2734
So, it makes sense to also do it with TreeViews

It would be great to have the same fix here too.
I tried to create a conclusive example here: https://try.mudblazor.com/snippet/ckcmuoGTIPKKKGAJ
I also wrote the steps to reproduce the issues there.

Thanks!
I'm following this thread with interest :-)

I forgot to mention another related issue. Basically, let's say I have the following:

Item A
Item B

When reordering elements in the treeview, like moving Item A down one position, the selected element is still the first one, which now is "Item B".
The Selected item should still be Item A, no mater if it was moved.
This is most likely related to all the other issues, including the ones reproduced in the link above. (Basically the selected item is kept by position not by the element itself)
I think solving this issue, will solve each of these bugs.


App triggers high perf graphics card on 2016 15" Macbook Pros

I can confirm the bug.
I have a 15" mid-2014 Macbook Pro Retina (2.8GHz i7-4980HQ, 16GB RAM, Iris Pro 5200 + Nvidia GeForce GT 750m) running OS X 10.12.3 Beta (16D17a) (Darwin 16.4.0)
According to Activity Monitor and gfxCardStatus, this app places my computer in high-performance graphics mode, forcing the GT 750m to turn on.  It's not an issue when my laptop is plugged in, but it would be nice to be able to take advantage of the more energy-efficient Iris Pro while leaving this app in the background.  Would it be possible for this app to be able to be run on the Iris Pro instead of the GT?
I know there is a bug in iMessage which causes the high-performance graphics to be turned on and get stuck that showed up in one of the past few macOS builds, but I don't think this is related to that since it occurs at app launch.  Relaunching iMessage resolved the issue.  Neither relaunching FB Messenger nor restarting the computer resolve this.

I can also confirm this on a Mid 2014 rMBP.

PR #344 fixes this issue (maintainer doesn't seem to be present to merge PRs, but you can clone and build yourself)

Fixed by #344 authored by @greg

Could someone explain how can i get the issue fixed? I just switched to mac and dont understand/know how to clone and build this into an .dmg file that i can install.
Thanks in advance!

You have to build it yourself since there's no prebuilt release yet.  Clone it somewhere on your computer, then run xcodebuild and copy ./build/Release/Messenger.app to wherever you want it.
Building against master worked for me to fix this issue.

re previous comment, note that you'll need to install Xcode in order to do this. If you don't like command line, you can also open the xcodeproj file in Xcode and build from there (then you can find the app under the Products folder in the left pane -- right click > show in Finder)
I think this issue can be closed now (since it's resolved)?

Sorry about that.  I'm used to Linux and BSD where everything is make, make install.
I'd agree that it can be closed.

Can confirm that recompiling does fix the discrete graphics switching. However, I believe a new minor release should be pushed in order to close this issue, since the main download page and Homebrew Cask both point to 0.1.10

Same issue on 2016" macbooks (touchbar) with discrete graphics

Version 0.1.11 just published which contains the fix for this issue.


did you open the file in text mode?

Traceback (most recent call last):
File "read_launch_plists.py", line 107, in
main()
File "read_launch_plists.py", line 93, in main
comments = {rows[0]:rows[1] for rows in reader}
File "read_launch_plists.py", line 93, in
comments = {rows[0]:rows[1] for rows in reader}
_csv.Error: iterator should return strings, not bytes (did you open the file in text mode?)

Changed
 with open(csvfile, 'rb') as f: to  with open(csvfile, 'r') as f:

New Issue:
Traceback (most recent call last):   File "read_launch_plists.py", line 107, in <module>     main()   File "read_launch_plists.py", line 98, in main     p = LoadPlist(filename)   File "read_launch_plists.py", line 31, in LoadPlist     data = plistlib.readPlistFromString(out_data) AttributeError: module 'plistlib' has no attribute 'readPlistFromString'

It's working for me. Please reopen with the version of Python you're using, if you still see this.
$ /usr/bin/python -V
Python 2.7.10

Python 2.7.10

How to deal with this issue in Python 3.9.0 ?


Support per-block bundling for static memory pools.

This patch ensures that static memory pools get aggregated on a per-block basis.
This also fixes issue https://github.com/onnx/onnx-mlir/issues/323

When you have a branch
if () A else B

and you add a block for handling allocs in A, do you have to change the control flow jumping from the test to A-alloc instead of A?
Also, the test that the German folks were looking into
block A: %1 = alloc()
if ? goto B
bloc B: %2 = alloc; free %1, return %2
block C %3 = merge (%1 on else (skip block B) path, %2 on then (through block B) path)
free %3.

That is a case where the allocs are escaping their blocks...
Can you just confirm that you can safely "not handle" such cases. Thanks

Such cases are outside the scope of the bundling algorithm for now. Moreover we rely on MLIR for inserting the deallocs so if there is an error due to wrongly introduced dealloc that means the support in MLIR is not sufficient (yet). There is work by the community to improve this aspect of MLIR.


app: jitter while climbing uphill against  tough slopes

There is jitter in master while climbing uphill against tough slopes
https://user-images.githubusercontent.com/35926530/145102735-ce0fa4fb-2011-4ed9-a6df-7132e29fab96.mp4

Should be fixed with the new character controller in https://github.com/webaverse/app/pull/1856


Ruby 2.2 Ready in 3.1.0-stable

Rails 3-2-stable was updated to be Ruby 2.2 compatible, with a release pending a security issue:

[There] will be not any new release of 3-2-stable branch. But if we have a security issue that needed to be fixed on 3.2, we will release from that branch.

This PR ensures Mongoid 3.1.0-stable is also Ruby 2.2 compatible when that happens.

Tests pass in Ruby 2.2.1 using Ruby 2.2-ready ActiveModel 3-2-stable branch.

While I was in there, I fixed up .travis.yml to allow for further maintenance on the 3.1.0-stable.
Hope this is okay in this PR. I can separate it out if you guys prefer. Thanks!

Can you squash the commits in one? thanks

squashed in https://github.com/mongoid/mongoid/pull/4001


[3458] Rename Course#accrediting_provider_code

NB: This must be deployed with https://github.com/DFE-Digital/publish-teacher-training/pull/1167 in an out-of-hours deploy as there may be a few seconds of incompatibility between publish and the api during the deploy.
Context
Accredited bodies are named inconsistently throughout the apps.
Changes proposed in this pull request
Rename Course#accrediting_provider_code -> Course#accredited_body_code
Guidance to review
This will be one of a series of renaming PRs with this one specifically focussed on the Course#accredited_body_code rename. Other things will be renamed in subsequent PRs.
Checklist

[ ] Make sure all information from the Trello card is in here
[ ] Attach to Trello card
[ ] Rebased master
[ ] Cleaned commit history
[ ] Tested by running locally

 Sort out accredited body and provider type (code bases)


fix(core): filter invalid dependencies

An assertion error occurs if graph.modules[].dependencies[] has an error data like following:
error: Uncaught (in promise) AssertionError: Expected actual: "undefined" to not be null or undefined.
    at collectFromDependency (file:///work/deno/molt/core/update.ts:260:13)
    at file:///work/deno/molt/core/update.ts:214:16
    ...

{
  "specifier": "@std/collections/filter-keys",
  "code": {
    "error": "JavaScript resolve threw.",
    "span": {
      "start": {"line": 60, "character": 42},
      "end": {"line": 60, "character": 72}
    }
  },
  "isDynamic": true
}

I don't know if it's okay to simply filter. Now it works for me.

Looks like a case of #146 ?
Filtering them out doesn't make those imports updatable but maybe better than throwing.
Can we show warnings on them? Do you think it too annoying?

Let me fix CI first...

I believe I can fix #148 in this week so we might just wait for it instead.

Looks like a case of #146?

That's right. Sorry I missed it.

Filtering them out doesn't make those imports updatable but maybe better than throwing.
Can we show warnings on them? Do you think it too annoying?

Production code should not generate assertion errors or should be caught properly. This is because the cause of the error is unknown to the user. Of course, it is acceptable to include assert() for developers.
It should be one of the following:

Show user-friendly error and abort.
Show warning and continue.
Skip the error part and continue.

Sorry pushed invalid code, so force pushed...

Production code should not generate assertion errors or should be caught properly. This is because the cause of the error is unknown to the user. Of course, it is acceptable to include assert() for developers.

Absolutely right. That's why the behavior is labeled as a bug.
Appreciate your additional work, which looks good as a tentative fix.
I will probably re-write an equivalent logic in core/graph.ts when I fix #146, but let me merge your change as an emergent patch if you don't mind your PR would be reverted eventually.

@Milly Can I squash your commits and rewrite the message on merging?


Fog?

What is the output link of /viaversion dump?
1.5.2
Are you using any additional software like BungeeCord? If so, what software and version? (Please list your plugins as well)
Bungee, nothing that would affect the plugin
How does this error happen? login? Using an item?
Just fog
Is there an error in the console? Use pastebin.com. Is there a kick message?
no

I have no idea what you mean, consider filling out the issue so that we can get the best understanding of what you mean.


res.download() produces blank file

I am attempting to generate a CSV file and download it into my React application. Whenever I hit this endpoint the browser always downloads a blank file but when I open it with open filename.csv , it has the data as expected. I don't know if this is on the React end or on the express end but I figured I would start here.
My thoughts are that it has to do with me using os.tmpdir() but it runs as if it succeeds so no helpful debug. I logged the csvStream.on("data") event and it was writing to the file properly. It seems that res.download() does not like the directory it is reading from. Can this be confirmed? Would a directory like /var/folders/j_/43f_ppvn1y5_w7h24ng8yq440000gn/T/node-lab.csv cause res.download() to produce a blank file?
node: 14.3.0
express: ^4.17.1
react: ^16.13.1
react-dom: ^16.13.1

router.ts
router.get("/gen-csv", async (_req: Request, res: Response) => {
  const mockColumns = getMockColumns();
  const headerRow = mockColumns.map((col) => col.fullName);
  const filepath = path.resolve(os.tmpdir(), "node-lab.csv")
  console.log("filepath: ", filepath)
  const fileWriteStream = fs.createWriteStream(filepath)
  const csvStream = format({headers: headerRow})
  csvStream.pipe(fileWriteStream)

  const rows = ["fullName", "jobTitle", "jobArea", "jobType"]
  rows.forEach((row: string) => {
    const templateRow = mockColumns.reduce((acc: any, col: MockColumn) => {
      return {...acc, [col.fullName]: col[row]}
    }, {})
    csvStream.write(templateRow)
  })

  // close csvStream
  // ...

  res.download(filepath, "node-lab.csv", (err: Error) => {
    if (err) {
      console.error(err)
    } else {
      console.log("Generated CSV!!")
    }
  })
})

server.ts
import express from "express"
import cors from "cors"
import http from "http"
import morgan from "morgan"
import bodyParser from "body-parser"
import {createTerminus} from "@godaddy/terminus"
import router from "./router"

const PORT = process.env.PORT || 4000
const app = express()

app.use(cors())
app.use(morgan("dev"))
app.use(bodyParser.json())
app.use(router);

// godaddy/terminus stuff ...

server.listen(PORT, () => {
  console.log("Server listening on port http:localhost:4000")
})

App.js
import React from "react"

function App() {
  const [loading, setLoading] = React.useState(false)

  const handleGenerateCSV = async (e) => {
    e.preventDefault()
    const res = await fetch("http://localhost:4000/gen-csv")
    const blob = await res.blob()
    const url = window.URL.createObjectURL(new Blob([blob]))
    const link = document.createElement("a")
    link.href = url
    link.setAttribute("download", "node-lab.csv")
    document.body.appendChild(link)
    link.click()
    link.parentNode.removeChild(link)
    setLoading(false)
  }

  const isLoading = () => {
    if (loading) return
Loading...

    else return null;
  }

  return (
    <>

React Lab

      <button onClick={(e) => {
        setLoading(true)
        handleGenerateCSV(e)
      }}>Generate CSV</button>
      {isLoading()}
    </>
  )
}

export default App

When I log the blob this is the result:
Blob {
  size: 0,
  type: "text/csv"
}

ok, so firstly thank you for providing some code. That is always useful. What I believe your question is

is using a temp folder an issue?
does res.download work?

So my first advice is to create a local csv, hard code the res.download to use it and see if that works.

Here is a working and complete example of res.download
I do not believe this is an issue with express.
If you isolate the expressJS part and give a full and complete but minimal working demonstration of the issue it would be possible to debug.

Moved to: Stack Overflow

Hi, Were you able to find a solution for this ? I am also facing the same error.

Same issue, is there a solution available??, if i use JSON.stringify while blob creation it works but still the CSV generated is not correct


Enable CLI partial options to be renamed

I'd like the -p flag to optionally accept a two-part argument, where one part is the path to the partial file and where the other part is a name for the partial. Renaming partials is currently possible only when using the library programmatically. This functionality would allow the CLI to mirror the following programmatic usage:
const template = `

    {{#competitionList}}
      {{> select }}
    {{/competitionList}}

    {{#seasonList}}
      {{> select }}
    {{/seasonList}}

`

const selectPartial = `
  <select class="mmgr-select">
    {{#.}}
      <option class="mmgr-select__item" value="{{value}}">{{text}}</option>
    {{/.}}
  </select>
`

const output = Mustache.render(template, data, { select: selectPartial })

I would be willing to submit a patch if the maintainers would like to incorporate this functionality.

Hi Nolan!
That indeed sounds reasonable 👍 Let me know if you need some help / thoughts opening a PR with related changes.


[GitHub] Saved searches/advanced search

Extension
https://www.raycast.com/raycast/github
Description
I would like to get a list of all open issues in all of my own repositories.
Who will benefit from this feature?
People with lots of repositories that is rarely checked on.
Anything else?
Currently I'm getting the results with advanced search. Should be possible to to the same with the GitHub API?
https://github.com/search?q=user%3Asebdanielsson+-label%3Adashboard+state%3Aopen&type=issues&ref=advsearch
Or you could just enter this into the search field:
user:sebdanielsson -label:dashboard state:open
Where "user" is the owner of all repositories to be searched, "-label" will exclude issues with the tag chosen tag, "state" will let you choose if you only want issues that is open, closed or both.

I'm not sure I got your feature request. Did you mean you want to have a way to access your favorite search from the Search Issues command?

Yes. Support for all advanced searches would be the most flexible but my use case but for me it would primarily be to get a list of all open issues on my own repositories.

That only shows issues that's either assigned to me or mentioning me. I guess it could work if I added a bot to all of my repos that automatically assign me to every issue on creation but that seems like much work for this one feature.

What if you were able to create a quick link from the Search Issues command which would allow you to open it with the search text pre-filled?

Yeah that would be perfect!😃

Would you like to work on it? I can provide some guidance on how to contribute to this extension so that you can open a pull request. You can contact me here or in the Slack community if you need further help.

I'm a pretty novice developer but I would happily give it a try!😃


feat(frontend/settings): theme tool

Summary of PR
Adds a button in overlay settings to link to theme tool and also changes the description.
Before

After

Time spent on PR
30 minutes
Linked issues
Fix #506
Reviewers
@Harjot1Singh

There is a very clear 2-column pattern of key & values. To have two buttons designed like this is confusing to the pattern. Please use one button per row/line.

Additionally, the theme tool could just be in the Learn More button, no? Keep it simple and use the existing paradigms in place for advanced learning/usage.

Should we revert this back and make the change?

I’d suggest PR’ing the change (since dev isn’t a release, reverting doesn’t serve a point if we’re going to recommit).
The Learn More button provides a lot of information that a user may not ever know about, and that the theme tool has no link to. So, it would make sense to still keep both buttons.


Fix simple typo in README.md

Fix simple typo in README.md

@Raamyy Please rebase the branch with master.


CI and Testing

So after determining that the build bot is a wee too complex for our needs I have been looking at using something recommended by some folks on the Cantara project using a process with githooks. I have it working with my own accounts and running tests but some issues:

Only works with my local machine and my local account
Not automated (could probably be with a timer but not with a webhook cus we don't have a web server)

I am trying to think up some way of doing this with email notifications but that seems janky. For now when someone makes a PR they are probably going to have to ask me to run the performance tests manually.

moved to #126


OIDC hybrid flow will not work without Implicit grant configured in SP

When we are not using the implicit grant, without that grant type enabled in the SP configuration, OIDC hybrid flow with the response type "code id_token" breaks.
And by going through analysis, found out that the error occurs due to implicit grant type been added into the set of grant types inside isAuthorizedClient() method of class AbstractResponseTypeHandler which is given below.

Inside the isImplicitResponseType() method of class OAuth2Util,it is checking whether the Response type contains the string "id_token" or "token". If at least one of them is there, it returns true and then the isAuthorizedClient() method above adds the implicit grant type into the grant types.

Should improve the code to validate whether the implicit grant is enabled, only if the response types are "id_token token", "id_token", "token" , rathar than doing the above contains check to identify implicit grant.

https://github.com/wso2-extensions/identity-inbound-auth-oauth/pull/1191


Output Attachment id, profile name and version

In order for us to integrate the SCC DA with our DevSecOps Solution stack for the DevSecOps ALM member we need the attachment id to be outputted so we can connect them to the related SCC tool integration. We also need the profile name and version.

PR is merged hence closing the issue.


Vscode keeps crashing

VSCode Version: 1.28.2
OS Version:  Windows 10 pro v.1709

Steps to Reproduce:

Open multiple files (at least 5) by dragging them in the window

Does this issue occur when all extensions are disabled?: Yes

@ClaudioPerroni is the window already crashing when you reorder tabs within or only when you drop into Code? Are you logged in as different user compared to who runs Code?

@ClaudioPerroni is the window already crashing when you reorder tabs within or only when you drop into Code? Are you logged in as different user compared to who runs Code?

They get loaded up (i can see them in the tabs), however when i try to edit them vscode suddenly crashes.  I'm the only user logged in.

@ClaudioPerroni are there other ways to reproduce? E.g. can you open multiple files from "File > open" and try then?

@ClaudioPerroni are there other ways to reproduce? E.g. can you open multiple files from "File > open" and try then?

With file>open works fine, it's just dragging that gives me problems

Can you try to reproduce with our nightly insider builds? You can give our preview releases a try from: https://code.visualstudio.com/insiders/


Plex ping appears to be broken or regressed. Not working as documented.

Environment
Docker
Version
0.13.4
Describe the problem
The ping status for the Plex application widget shows a Red symbol or X symbol when I configure the internal URL following the documentation. It suggest a 401 error however that status is not accurate. The Media Server widget is working fine for both Plex and Jellyfin. I've tried various combinations of internal URLs including those that bypass my internal reverse proxy and internal DNS view. I normally use the remote access URL as I have dual DNS views. Internal traffic never exits my network.
If I update the Plex Internal URL to include /web/index.html the ping status becomes green but the Media Server widget as documented stops working.
This maybe related to #739 and/or #127.
Already reviewed https://homarr.dev/docs/widgets/media-server#common-issues
{
"id": "2a7dd0e5-f242-482c-b953-a38295b3af2f",
"name": "Plex Medserv1",
"url": "http://plex-server.example.com:32400",
"appearance": {
"iconUrl": "https://cdn.jsdelivr.net/gh/walkxcode/dashboard-icons/png/plex.png",
"appNameStatus": "normal",
"appNameFontSize": 16,
"positionAppName": "column",
"lineClampAppName": 1
},
"network": {
"enabledStatusChecker": true,
"statusCodes": [
"200",
"301",
"302",
"304",
"307",
"308"
]
},
"behaviour": {
"isOpeningNewTab": true,
"externalUrl": "https://mprx.example.com",
"tooltipDescription": "Plex"
},
...
"integration": {
"type": "plex",
"properties": [
{
"field": "apiKey",
"type": "private",
"value": "-api-key-"
}
Logs
Listening on port 7575 url: http://xx.xx.xx:7575
ℹ Requested frontend content of configuration 'default'
[DEPRECATED] Use createWithEqualityFn instead of create or use useStoreWithEqualityFn instead of useStore. They can be imported from 'zustand/traditional'. https://github.com/pmndrs/zustand/discussions/1937
ℹ Saving updated configuration of 'default' config.
ℹ Requested frontend content of configuration 'default'
ℹ Saving updated configuration of 'default' config.
Error: 'sharp' is required to be installed in standalone mode for the image optimization to function correctly. Read more at: https://nextjs.org/docs/messages/sharp-missing-in-production
Error: 'sharp' is required to be installed in standalone mode for the image optimization to function correctly. Read more at: https://nextjs.org/docs/messages/sharp-missing-in-production
ℹ Saving updated configuration of 'default' config.
Context

Please tick the boxes

[X] I confirm that I attached the proper logs
[X] I've read the docs
[X] I've checked for duplicate issues
[X] I've tried to debug myself

The ping function does not use the integration and is separate from the widgets.
401 means it's unauthorized, because we are not using the login fields. It's normal, just add 401 in the list of accepted http status code in the network tab.
We really need to add those codes by default, you're not the first one to think this was a problem.

Thanks, for the quick response. That works for me.


Remove highcharts

What's new in this PR?
Remove highcharts package and use cases (graphs and pie charts)
How to Review
Related PRs
Next steps
Screenshots
General View
(remove solar projects graph)

(remove financial breakdown piechart)

Subscriber View
(remove my solar projects graph)

Design Status
CC: @dfangshuo

Hi team pls review, so we can start our HACKOWEEN with this repo.


Make username configurable

At least for the WebFinger ID
Fixes #141 #28 #71
Screenshot:

This feels like unnecessary complexity? Can't these users just use the Blog user, which is already configurable, instead?

@mattwiebe the renaming itself is pretty straight forward, but the collision detection is a bit complex. I think I will postpone it for now.


Lazy Loading feature suggestion in EF Core 1.0.0

Hi,
Though Lazy Loading is not available in EF Core 1.0.0, but I think it would be handy if it's available. It would allow me to implement a Generic Repository Pattern
public interface IRepository<TEntity>
    {
        Task Insert(TEntity entity);
        Task Delete(TEntity entity);
        Task<TEntity> Get(int id);
        Task<List<TEntity>> GetAll();
    }

    public abstract class Repository<TEntity> : IRepository<TEntity> where TEntity : class, IEntity
    {
        public async virtual Task Delete(TEntity entity)
        {
            using (var context = new MyDbContext())
            {
                context.Entry(entity).State = EntityState.Deleted;
                await context.SaveChangesAsync();
            }
        }

        public async virtual Task<TEntity> Get(int id)
        {
            using (var context = new MyDbContext())
            {
                var entity = await context.Set<TEntity>().Where(x => x.Id == id).FirstOrDefaultAsync();
                return entity;
            }
        }

        public async virtual Task<List<TEntity>> GetAll()
        {
            using (var context = new MyDbContext())
            {
                var entities = await context.Set<TEntity>().ToListAsync();
                return entities;
            }
        }

        public async virtual Task Insert(TEntity entity)
        {
            using (var context = new MyDbContext())
            {
                context.Set<TEntity>().Add(entity);
                await context.SaveChangesAsync();
            }
        }
    }

And my POCO classes with virtual keywords :
public class Section : Entity
    {
        public string SectionName { get; set; }
        public virtual ICollection<Student> Students { get; set; }
    }

    public class Student : Entity
    {
        public string Name { get; set; }
        public virtual Section Section { get; set; }
    }

    public interface IEntity
    {
        int Id { get; set; }
    }

    public class Entity : IEntity
    {
        [Key]
        [DatabaseGenerated(DatabaseGeneratedOption.Identity)]
        public int Id { get; set; }
    }

And finally, I could write my repositories without having to write those common functions. Navigation properties will be fetched in Lazy Manner (for virtual keyword)
public interface ISectionRepository : IRepository<Section>
    {

    }

    public class SectionRepository : Repository<Section>, ISectionRepository
    {

    }

    public interface IStudentRepository
    {

    }

    public class StudentRepository : Repository<Student>, IStudentRepository
    {

    }

Since, Lazy Loading is not available, I had to write those common functions in each repository with Include() or ThenInclude().
This is just a discussion. You can have a look at it.

This repo is not good place for such issues. Better address direct to EF team. As far as i know lazy load is in backlog for now.
See _https://github.com/aspnet/EntityFramework/issues/3797_,

@laskoviymishka thanks for notifying it. I shall submit it there and closing this one


mix: update dependencies to include fast_xml 1.1.20 with FreeBSD fixes

This PR rolls in my upstreamed patches to fast_xml in 1.1.20 which correctly compiles on FreeBSD. I couldn't find a way to produce a smaller change in dependencies; maybe you have a better approach:
mix deps.unlock --all
mix deps.update fast_xml

mix insists on bumping All The Things.

Coverage increased (+0.3%) to 74.503% when pulling 05f12077d9fafeb250d48984c946b9997a823cf0 on iwantmyname:fix/bump_fast_xml into 0ecef1e1d6e11f0a47a688b29e8c13c39aa6018f on scrogson:master.

Coverage remained the same at 74.172% when pulling 05f12077d9fafeb250d48984c946b9997a823cf0 on iwantmyname:fix/bump_fast_xml into 0ecef1e1d6e11f0a47a688b29e8c13c39aa6018f on scrogson:master.


Ignore invalid partition fields

Iceberg may add new transforms to the partition spec. When a transform is not recognized, Iceberg should ignore the field so that the format is forward-compatible with new transforms.
Iceberg should also ignore fields with multiple source columns, in case transforms on multiple columns are added.

This issue was moved to the ASF repo: https://github.com/apache/incubator-iceberg/issues/32


The paper is missing from the evaluation record in https://paperswithcode.com/sota/image-generation-on-imagenet-256x256-5

Issue still there...


XML should be counted as a language used in the repo

In a repository, under the language section, XML is not considered.
Problem Description
XML-layout files play a significant role in Android projects. When layout is created in Java or Kotlin, it's counted, and when in XML, it is not considered. Maybe one could open a pull request with Android View XML (that way we could count those XML files only) as a new language to initiate discussion.
URL of the affected repository: Scanner
Expected language: XML
Detected language: Nothing

This is expected as XML is and has always been considered data by Linguist.

Maybe one could open a pull request with Android View XML (that way we could count those XML files only) as a new language to initiate discussion.

I don't think we need to do this as I believe these files are really just plain old XML.  If you really want them to count in your language stats, you can force this by using the linguist-detectable override.


Evolve all not working

Expected Behavior
"evolve_all": true

should evolve all pokemons on startup
Actual Behavior
doesnt evolve anything :/
Steps to Reproduce
use "evolve_all": true in config
Other Information
OS: win10
Git Commit: (run 'git log -n 1 --pretty=format:"%H"' and paste it here)

Same problem here. Seems like the value "evolve_all" isn't even red by the program.
OS: ubuntu

please test with latest dev branch, also paste in git commit if issue persist

commit 149a357347276e3910d023732d4fb492397438db

"evolve_all": "Pidgey,Weedle,Caterpie,Rattata"

nothing happen...

for me the all function worked


Integration with main website

WIP

@rschroll I'll re-route this PR to your branch, since you already merged this in today.
Even though what we're trying to accomplish is simple enough, I think the complexity quickly gets out of hand: look at one flag, write another, that kind of stuff.
Especially when developing against the dev server - without tests.
We should probably refactor everything and put some tests on it.


Merge for the first version

Some codes for migrating KV cache.
[TODO:] initialize the kv cache in sp workers.

hello, i want to know is this feature worked ? thanks


Add "WHY" information to README

I'm looking at the flannel README file and although I have not experimented with flannnel in order to expose it's capabilities the header of the README describes flannel as performing the one function that kubernetes needs with an absence of WHY? So here are some questions and things that come to mind.

the example shows a webapp connecting to a backend. Where is the webapp client? How are messages routed from the public?
the comment "each pod" and "unique subnet" suggests that flannel handles multiple private subnets. An example or at least a stronger hint please? (multi-network experimental??) I'm not sure how this can be experimental with a proper tectonic release (that's a separate issue)

(maybe some of the above are already documented on different pages)here
Finally, it seems that Apcera does something like this but then adds security. How could that be added to flannel?
... or just close this.

@zbwright / @joshix Do you think this issue can be closed?

may be partially addressed.
1st item: not addressed. there was no additional info added to answer Where is the webapp client? How are messages routed from the public?
2nd item: addressed? references to multi network subnets have been removed. (experimental client-server doc is still available from the CoreOS site, but is slated for removal. https://coreos.com/flannel/docs/latest/client-server.html)


Lexer optimizations

Further optimizations to the lexer.

@hungneox I actually changed the Token back to using protected fields to make it immutable.

I think we're good to merge. With PHP 7.1 we're approx. 1.5x slower than the competition and with PHP 7.2 are very close to the competition. We've also discussed this a lot with the other contributors and we don't think that parsing the most important thing. That said we don't really want to give up too much of the code quality in order to increase the performance. All the changes done in this branch were mainly also done to make the code easier to maintain.


Three failing tests

after applying workaround as per https://github.com/opensha/opensha-core/issues/10 the tests now run with failures
on: commit bf9ee39e25661e8b7e78a86e055cabc89a2e6ae9
when I run: ./gradlew test
I see:
> Task :compileTestJava
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

> Task :test

org.opensha.sha.imr.attenRelImpl.test.AttenRelTestsSuite > org.opensha.sha.imr.attenRelImpl.test.MultiIMR_ParamTest.testInitialConsist FAILED
    org.opensha.commons.exceptions.ConstraintException at MultiIMR_ParamTest.java:84

org.opensha.sha.imr.attenRelImpl.test.AttenRelTestsSuite > org.opensha.sha.imr.attenRelImpl.test.MultiIMR_ParamTest.testChangeProp FAILED
    org.opensha.commons.exceptions.ConstraintException at MultiIMR_ParamTest.java:92

org.opensha.sha.imr.attenRelImpl.test.AttenRelTestsSuite > org.opensha.sha.imr.attenRelImpl.test.MultiIMR_ParamTest.testSetIMTs FAILED
    org.opensha.commons.exceptions.ConstraintException at MultiIMR_ParamTest.java:66

2959 tests completed, 3 failed

> Task :test FAILED

FAILURE: Build failed with an exception.

Test was failing due to the non-ergodic GMPE, which is kind of a special case and would never be mixed in a multi-IMR average anyway, so I modified the test to exclude it in 833414b.


Expose raw schema as static property

In early versions, it was possible to use the raw schema using the .schema accessor, I believe that will be great if we return this feature so it's a good way to use zod-class classes with some other libraries that expect to use a z.AnySchema
The codes below exemplifies how it can be useful
import { z } from "zod";
import { Z } from "zod-class";

// zod-class class definition
class User extends Z.class({
  id: z.string().uuid(),
  email: z.string().email(),
  name: z.string()
}) {}

// now lets say that you are using a library that expect you to pass a zod schema as argument

class UserDTO extends createZodDto(User) {} // 👈 type error cause `User` isn't a `z.AnySchema`

// what could be done (but a little verbose) is to wrap the class into a `z.object` and use the `.shape` property
class UserDTO extends createZodDto(z.object(User.shape)) {} // 👈 ok but verbose

Another possible way (still verbose) is to separate the schema definition from the class, but it will inflict one of the reasons why this library exists
import { z } from "zod";
import { Z } from "zod-class";

const UserSchema = z.object({
  id: z.string().uuid(),
  email: z.string().email(),
  name: z.string()
});

class User extends Z.class(UserSchema) {}

class UserDTO extends createZodDto(UserSchema) {}

So I think if we went back to expose an static .schema property theses workarounds wouldn't need to exists
import { z } from "zod";
import { Z } from "zod-class";

class User extends Z.class({
  id: z.string().uuid(),
  email: z.string().email(),
  name: z.string()
}) {}

class UserDTO extends createZodDto(User.schema) {}

Do you have a link to createZodDto?
I would very much like a ZClass to be compatible with Zod's schema. I believe the ideal experience is:
class UserDTO extends createZodDto(User) {} // 👈 type error cause `User` isn't a `z.AnySchema`

The problem with createZodDto(User.schema) is if the DTO calls schema.parse, it won't return an instance of User, you'll get an object literal with the shape of User.schema (not the same thing).
I believe the reason typeof User is not a sub-type of z.AnySchema  is because I had to patch the parse, extend, etc. methods:
https://github.com/sam-goodwin/zod-class/blob/f1d40fe949d9ea88ccc1f740fbf2901f0accdfcf/src/index.ts#L33-L49
It may be possible to declare a wrapper around createZodDto that just casts away the error. I suspect any code expecting a Zod Schema would be compatible with a ZClass.

Oh, and I forgot. The schema property was renamed to shape:
https://github.com/sam-goodwin/zod-class/blob/f1d40fe949d9ea88ccc1f740fbf2901f0accdfcf/src/index.ts#L30-L32
You can try:
createDto(User.shape)

But remember, User.shape.parse will not return an instance of the User class.

Do you have a link to createZodDto?

It was just an example but strongly based on nestjs-zod

The problem with createZodDto(User.schema) is if the DTO calls schema.parse, it won't return an instance of User, you'll get an object literal with the shape of User.schema (not the same thing).

Yeah, and that's exactly what is takes. If we want to be compatible with other libraries that just accept a native zod schema then we should expose somehow the schema that was passed when defining the class

Oh, and I forgot. The schema property was renamed to shape:

Actually the .shape property it's a object containing the sub schema for each property in the root object schema

Ah, you're right! shape is not a Zod Schema.
It just occured to me that there is at least a nice workaround here.
I can add the schema to ZodClass and type it like this:
schema: z.ZodType<this>;

That way it will return an instance of User.

That way it will return an instance of User.

I think that a better approach would be just return the original ZodObject that was passed in .class function
schema: z.ZodObject<Shape> // 👈 `Shape` is a `ZodClass` generic

Hmm, what's the benefit to that?
This approach works and maintains all of the type-safety:

This approach works and maintains all of the type-safety:

Oh I misunderstood you, you're right, this approach will fit perfectly

Actually, there are some cases that should be covered that are very similar with #13, when using the .schema() method the ZodObject methods (like .pick, .omit) should also be exposed

Actually, there are some cases that should be covered that are very similar with #13, when using the .schema() method the ZodObject methods (like .pick, .omit) should also be exposed

Totally, i'll add those methods in my next PR.
Currently sitting on a plane and port 22 doesn't work! ha
samgoodwin@Sams-MacBook-Pro zod-class % git push
kex_exchange_identification: read: Connection reset by peer
Connection reset by <IP_ADDRESS> port 22
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Totally, i'll add those methods in my next PR.

Nailed it, thank you

Currently sitting on a plane and port 22 doesn't work! ha

Haha, have a good flight Sam


Remove composer self-update

Travis does this automatically, so no reason to do it twice

Thanks!


CascadeMergeToChildBeforeParent object retrieval from database change…

CascadeMergeToChildBeforeParent object retrieval from database changed
from exact id value to value returned from .getRouteID method.

Applied upstream, thanks. I used the HHH-11927 for Jira issue for this PR.
@gbadner you might want to backport it to 5.1 as intended by the @ChesterSVK.


dream_log.txt is not updated and metadata is not written inside PNG files if CTRL+C is pressed

I set -n to 100 and then pressed CTRL+C and interrupted message appeared.
Then I opened dream_log.txt to view seeds for newly generated images but there was no info about them.
What is worse - newly generated images did not have EXIF metadata so there was no way to know their Seed values to recreate them later with different parameters.

I too was unable to locate any of the prompting info in the meta data using Gimp.

This code will modify text2image function to write Seed string inside image files immediately

Traceback (most recent call last):
File "scripts/dream.py", line 332, in
main()
File "scripts/dream.py", line 78, in main
main_loop(t2i,cmd_parser,log)
File "scripts/dream.py", line 133, in main_loop
results = t2i.txt2img(**vars(opt))
File "c:\sd\stable-diffusion\ldm\simplet2i.py", line 223, in txt2img
info = PngImagePlugin.PngInfo()
NameError: name 'PngImagePlugin' is not defined
Perhaps you have an IDE that's pulling in imports automatically or some such?
In any case, I can wait for you guys do get this coded, since, really, we will want more than just the seed anyway.  The idea is that the meta-data will include everything we'll need to recreate the image.  (prompt, steps, height, width... seed etc. ) (This is a "nice-to-have").
Thanks,
KS

Ok, I can fix that by changing where the try: block is. Will be in version 1.06

Metadata is now rewritten to the log and PNG files when a series of generations is interrupted by ^C.
Some image programs can display the prompt metadata and others can't. Try Imagemagick on Linux, or use the "identify -verbose " command line. I have also provided a script called images2prompt.py that will retrieve the prompt metadata from a series of files from the command line.

There is still a problem with writing metadata to PNG files only at the end of bulk generation (or after CTRL+C) - it's an unexpected crash of the script or when PC turns off suddenly (electricity off). Imagine you were running script for 10,000 images and 23 hours later electricity went off and all images that were generated will not have metadata (most importantly seed).
That's why I propose to write at least "seed" information to the images during initial save.


Create subarray.cpp

Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[ ] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #XXXXX

please remove the spam label I dont know all about it I made contribution by mistake I am completely new to this.
please i request you

You added a random file to the repo, this is the definition of spam PR. The spam label here stays

I am very new to open source contribution . I dont know all about there . Basically I am in learnig phase how to contribute to open source

You added a random file to the repo, this is the definition of spam PR. The spam label here stays

You have created two pull requests which do not follow our contributor guidelines.
We appreciate that you are trying to learn how to contribute to open source, but our process is clearly and thoroughly documented.
When you create pull requests like this one, which are meaningless, low-effort, and bring no actual value to the project, all you are achieving is creating extraneous noise for our maintainer team - many of whom generously donate their time as volunteers to help our mission.
By definition, that's spam. The spam label was accurately applied to your pull requests, and will not be removed.


Increase margins between form groups for new typography scale

What
Update the bottom between form groups.
Should be merged into https://github.com/alphagov/govuk-frontend/pull/2421 and not main.
Why
During testing of the govuk-frontend components against the new typography scale, we noticed that on small screens, form groups now looked quite tight next to each other due to the new larger font size on smaller screens.
Who needs to work on this
Developers
Who needs to review this
Developers, designers

During review of this work, we discovered that a govuk-responsive-margin of 6 is being used by a number of components and elements:

Accordion
Button
Button group
Character count
Details
Inset text
Pagination
Summary list
Table
Tabs
Task list
Textarea
Warning Text
Our own code windows in the review app

This is our unspoken standard bottom margin and helps to define vertical visual rhythm through govuk-frontend pages. It would be risky to only change one of these without changing the others but this could be quite significant. I'll be seeking input from our designers on how best to proceed.

Moving this into blocked just for now until there are more designers on hand on Monday.

Following a chat amongst the team we're now not going to do this. The risk to the disruption of the responsive scale is greater than the perceived impact of things looking squashed.


Update nbHits count with filtered documents

Closes #764
close #1039
After discussing with @MarinPostma on Slack, this is my first attempt at implementing this for the basic flow that will go through bucket_sort_with_distinct.
A few thoughts here:

For getting the count of filtered documents alone, I originally thought of using filter_map.values().filter(|&&v| !v).count(). In a few cases, this was the same as what I have now implemented. But I realised I couldn't do something similar for distinct. So for being consistent, I have implemented both in a similar fashion.
I also needed the contains_key check to ensure we're not counting the same document ID twice.

@MarinPostma also mentioned that this will be an approximation since the sort is lazy. In the test example that I've updated, the actual filtered count will be just 19 (for male records), but due to the limit in play, it returns 32 (filtering out 11 records overall).
Please let me know if this is the kind of fix we are looking for, and I can implement it in the placeholder search also.

Hey @balajisivaraman, sorry I need time to look into this, I'll review this PR asap

@MarinPostma, No worries! Thanks.

Hi Guys, anything i can contribute to this issue to get it merged? Thanks

@MarinPostma, Thanks for the comments. Is it okay if I get to this in the next couple of days and close it out by the weekend?

Yes take your time! ThankS for your help 🙂

we should test the behavior of #1039 to know if this PR fix it.

@MarinPostma, Done. Thanks for the help on this one, I had trouble figuring some things out. I tested the placeholder search test with the fix removed, and it failed correctly. So I think we look okay here.

bors try

bors r+

Thanks so much for merging this, and the support on this one from @MarinPostma.

Thank you! And sorry for taking so long :)

Testing the new v0.17.0 release as we speak (great work), but it seems the patch does not work if there is a limit
For exemple, with 3 documents in my index "events" (2 of them with a date in the past):
limit: 25 and date >= ${Date.now} gives you nbHits: 1 (correct)
but,
limit: 1 and date >= ${Date.now} gives you nbHits: 3 (incorrect)

hello @theo-lubert, this is perfectly normal since we lazily filter elements, since you only ask for one, and it is not filtered out, the other are still counted in the count.

Thanks @MarinPostma , so as I understand it, this is not a good fit for (filtered) pagination then. Any plans on that ? I don't find any feature related to that in the roadmap, should I create a new issue ?

Hello @Vincent56, the product team is currently working on the expected behavior we want for nbHits. We'll keep you informed 🙂
It might help us if you would like to share with us your usecase of nbHits

My filters;
{     "q":"",     "limit":10,     "offset":0,     "filters": "city="AND confirm!=DELETE AND authorId=T8jFa4" }
{     "q":"",     "limit":10,     "offset":0,     "filters": "city="AND confirm!=DELETE" }
nbHits = +76, but hit 15


create_db.py DLL load failed: The specified module could not be found.

Hi, i'm unable to run create_db.py
Running on windows 10
Python 3.6.2
requirements installed successfully.
Traceback (most recent call last):
  File "create_db.py", line 9, in <module>
    from monocle.db import Base, _engine
  File "C:\SCANNER\Monocle\monocle\db.py", line 12, in <module>
    from . import bounds, spawns, db_proc, sanitized as conf
  File "C:\SCANNER\Monocle\monocle\bounds.py", line 4, in <module>
    from .utils import get_distance
  File "C:\SCANNER\Monocle\monocle\utils.py", line 18, in <module>
    from pogeo import get_distance
ImportError: DLL load failed: The specified module could not be found.```

My Environmental Variables:
![image](https://cloud.githubusercontent.com/assets/26359726/26524766/01e6bc08-4304-11e7-9569-a444c76aa789.png)

Solved by installing WinPython.

Traceback (most recent call last):
File "create_db.py", line 9, in
from monocle.db import Base, _engine
File "C:\SCANNER\Monocle\monocle\db.py", line 12, in
from . import bounds, spawns, db_proc, sanitized as conf
File "C:\SCANNER\Monocle\monocle\bounds.py", line 4, in
from .utils import get_distance
File "C:\SCANNER\Monocle\monocle\utils.py", line 18, in
from pogeo import get_distance
ImportError: DLL load failed: The specified module could not be found.
Please, I have the same problem and I already installed Winpython but I still have the same error

What db type are you configured for? mySQL? sqlite?
You are calling create_db.py from the instance directory via .\scripts\create_db.py correct? And not trying to do it from the scripts directory itself?

@wellington1092 Execute everything through WinPython Command Prompt
pip3 install -U -r requirements.txt
pip3 install mysqlclient
create_db.py

C:\Users\Suporte-06\Documents\Monocle-develop (2)\Monocle-develop>python scripts/create_db.py
Traceback (most recent call last):
File "scripts/create_db.py", line 9, in
from monocle.db import Base, _engine
File "C:\Users\Suporte-06\Documents\Monocle-develop (2)\Monocle-develop\monocle\db.py", line 12, in
from . import bounds, spawns, db_proc, sanitized as conf
File "C:\Users\Suporte-06\Documents\Monocle-develop (2)\Monocle-develop\monocle\spawns.py", line 9, in
from .shared import get_logger
File "C:\Users\Suporte-06\Documents\Monocle-develop (2)\Monocle-develop\monocle\shared.py", line 14, in
ACCOUNTS = load_accounts()
File "C:\Users\Suporte-06\Documents\Monocle-develop (2)\Monocle-develop\monocle\utils.py", line 290, in load_accounts
accounts = load_accounts_csv()
File "C:\Users\Suporte-06\Documents\Monocle-develop (2)\Monocle-develop\monocle\utils.py", line 313, in load_accounts_csv
accounts[row['username']] = dict(row)
KeyError: 'username'

username,password,provider,model,iOS,id <<<<<<<<<
ash_ketchum,pik4chu,ptc,"iPhone9,1",10.2.1,2fcfb8c40e244be284aa42313c1d8dee
misty,t0g3p1,ptc,,,
brock,0n1x,google,,,
jessie,w0bbuff3t,,,,

leave 1st line there @wellington1092


Accept SBOM files for Dependency Analysis

CycloneDX Software Bill of Materials (SBOM) containing the aggregate of all direct and transitive dependencies of a project. CycloneDX is a lightweight software bill of materials (SBOM) standard designed for use in application security contexts and supply chain component analysis.
As a backend consumer I want to get a dependency analysis report using an SBOM json file. This will help having a common entry point regardless of the package manager

As a backend consumer I want to get a dependency analysis report using an SBOM json file. This will help having a common entry point regardless of the package manager

I just want to point out that we haven't settled on the format for the other supported package managers yet. Assuming we can get them all to do SBOM, than this point would make more sense.

I would also want to emphasize that the SBOMs, on the contrary from Dependency Trees, are project-scope manifests. Excluding specific packages from their content, might not be applicable out-of-the-box using existing tools. For instance, the cyclonedx-maven-plugin, used for creating an SBOM for Maven projects, has no option to exclude specific packages. Excluding specific packages is mandatory for inline-ignoring support.
For Maven projects, switching to SBOM means we will have to either manually cherry-pick the ignored dependencies out of the SBOM on the client side before sending it to the backend. Or propagate the ignored list to the backend as part of the initial request, and have the backend manually exclude them from the requests propagated to the various providers. The latter is the approach taken with the previous backend.
Both of these approaches should work. But our current approach uses Apache's own Dependency-Plugin list goal, to create a Dependency Tree in the form of a Dot Graph. Which has an out-of-the-box option to exclude dependencies from the tree using a command line flag.
So unless we use SBOM for all other supported package managers. Or unless we something else to gain from switching to SBOM. I would be inclined to stick to Dot Graphs for Maven projects.
That doesn't mean we need to drop the SBOM support suggested in #38. But I think it should be made clear that we haven't settled on SBOM just yet.


GameSpace: Enable oplus game_switch_enable node if exists

Increases touch sampling in oplus devices

is there way to allow overriding /proc/touchpanel/game_switch_enable via xml?

is there way to allow overriding /proc/touchpanel/game_switch_enable via xml?

Are you asking about to change the path of node through strings.xml?

is there way to allow overriding /proc/touchpanel/game_switch_enable via xml?

Are you asking about to change the path of node through strings.xml?

kind of
think the idea is to have a overlay for it if possible

is there way to allow overriding /proc/touchpanel/game_switch_enable via xml?

Are you asking about to change the path of node through strings.xml?

kind of think the idea is to have a overlay for it if possible

Hmm ok


Caching getting multiple values

Describe the problem
Currently, you cannot mget in Database Backend does not use cache at all. is there are reason for this?
In my case, I have a view that needs multiple values, and I need to utilize the cache.

Isn't this a duplicate of https://github.com/jazzband/django-constance/issues/344 ?

It is a duplicate. I'm closing this.


Implement Desktop Heartbeat Controller LogHeartbeat

Description
Defined heartbeat desktop controller.
Implements LogHeartbeat.
Adds tests to verify successful logging of heartbeats.

Testing
Added unit tests.
Using the heartbeat desktop storage class directly to verify successsful logging. Using a mock date provider in order to test cases related to same date or older date.

Type of Change
Place an x the applicable box:

[ ] Bug fix. Add the issue # below if applicable.
[x] New feature. A non-breaking change which adds functionality.
[ ] Other, such as a build process or documentation change.

Notes

Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
Read the contribution guidelines CONTRIBUTING.md.
Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

Merged from main


Broken unit test for MWSS transformer

Tests weren't being executed. Now they are, this is failing:
 class PackingTests(unittest.TestCase):

     def test_requires_batch_nr(self):
         self.assertRaises(
             TypeError,
             MWSSTransformer,
             {},
             seq_nr=0
         )
         rv = CSFormatter.pck_lines(data, **ids._asdict())
         self.assertEqual([
             "FV          ",
             "0005:49900001225C:200911",
             "0040<PHONE_NUMBER>2",
             "0140<PHONE_NUMBER>4",
             "0151<PHONE_NUMBER>2",
         ], rv)

Complains that data and ids are not defined.
Have commented out for now but needs to be addressed.

 Unit tests failing in sdx-transform-cs


Extend scatter() to work with a list of sizes.

To address #20.

Will merge since this has been open for some time and there aren't any outstanding comments. If anything should be addressed, we can tackle it in a separate issue.


Added 404 page

Solved Issue #1352
I have added a 404 - Not Found page on the client side.

Great work thank you!
@all-contributors please add @ShrutiKatpara for code


Does not found Android ArcGIS offline edit and sync feature but I have found for iOS (https://github.com/Esri/arcgis-runtime-samples-ios/tree/master/arcgis-ios-sdk-samples/Edit data/Offline edit and sync) . I am using ArcGIS 100.1.0. How to solve this issue?

Does not found Android ArcGIS offline edit and sync feature but I have found for iOS (https://github.com/Esri/arcgis-runtime-samples-ios/tree/master/arcgis-ios-sdk-samples/Edit data/Offline edit and sync) . I am using ArcGIS 100.1.0. How to solve this issue?

@satyaki1988 Android does not have this sample as of yet.  We are looking to implement.


chore(main): release 0.0.5

:robot: I have created a release beep boop
0.0.5 (2024-06-29)
Miscellaneous Chores

Prepare 0.0.5 release (760161e)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v0.0.5
:sunflower:


General submodule update

refs #0

Job VTB Documentation on b02dee7 wanted to post the following:
View the site here
This comment will be updated on new commits.


[Refactor] Refactor main.py to do source code sed in container

just like the title says

Implemented eventually by https://github.com/mttaggart/OffensiveNotion/commit/b7b3879166cadc06b27c550e912cb75a304fc453, also reverts source back to original within the container in case someone wants to run the script again


⚠ Secret Website 2 has degraded performance

In 8cb6260, Secret Website 2 ($SECRET_WEBSITE_2) experienced degraded performance:

HTTP code: 200
Response time: 3902 ms

Resolved: Secret Website 2 performance has improved in 5696285.


click 'X' to close a preview

This is a PR to re-open the conversation about #1455.
Things to consider for this feature:

Expand .left when all of the .right windows have been closed.

a. This will allow the user to close the panels on the right side and expand the logs on the left. This is great for users with smaller screens that want to expand the logs that may be wrapping.

Add a way to re-open the panels on the .right instead of just close.

a. Maybe a collapse/expand instead?
b. As of now, the workaround is to click to another container and back again. The closed panel will reappear.

Save the open/closed state for the panels.

a. Once we have a way to reopen a panel (above), save the open/closed state such that moving away from the container and back, will not show the panel again.
Signed-off-by: Matthew Boston<EMAIL_ADDRESS>

It would be nice if this could be made into a slide in/out menu perhaps, to allow the ability to close and re-open it.
If you look at xcode, they have a nice interface to designate the panels that get shown.
WDYT?

@FrenchBen I think that's a great idea. It's what I was thinking about in 2 and 3 above. I haven't had a lot of time lately to finish this, but I'll be back on it this week.

No problem - Time is always the enemy. Thank you for the help!

ping @bostonaholic

@FrenchBen Sorry for the delay. I'm still trying to figure out how I want the slide in/out to work and seeing if it's best to write it from scratch or if there's a react/vanilla.js library that would help.
Do you have any suggestions for how you would want this to look and how it behaves?

tbh I've never really been bothered by the preview.
There are however a couple of different modes possible, since the preview pane may also include the port links.
Perhaps instead of a slide left/right, it should be an accordion style? (up/down)
Something like: http://react-component.github.io/collapse/examples/simple.html
WDYT?

The reason the left/right is the way to go, is to allow the logs on the left to expand. Sometimes on a smaller screen, my logs will wrap, making it difficult to read.

@bostonaholic what about adapting the drawer component?
http://react-component.github.io/drawer/examples/simple.html

Cool. Something like that could work.


Duplicate execution

Bug description
Duplicate execution on windows
To Reproduce
Execute code
Expected behavior
Single execution
Screenshots

Environment:

IDE & Version:  PHPStorm 2020.2.1
PHP Version: 7.4.10
Laravel Tinker plugin version : 1.2.0
Interpreter Type: Local
Laravel Version: 8.0.0
Tinker version: 2.4.2

@Davidnadejdin Hey! Code is not executed twice, but displayed twice. I just had this problem myself.
Fixing this today!

Version 1.2.1 is submitted and in review - fixing this issue :smile:


Console Access url in the administration section in incorrect

Describe the issue:

Console Access url in the administration section in incorrect. It is directed to the carbon path instead of the carbon path

How to reproduce:

1.Login to the console
2.Go to organizational settings =>adminstrators
Expected behavior:

Environment information (Please complete the following information; remove  any unnecessary fields) :

Product Version: [wso2is-7.0.0-m4-SNAPSHOT-src.zip]
OS: [e.g., Windows, Linux, Mac]
Database: [e.g., MySQL, H2]
Userstore: [e.g., LDAP, JDBC]

Optional Fields
Related issues:

Suggested labels:

Verified the fix in the latest pack.