Why HA host label.hastate show 'Ineligible'

ISSUE TYPE

Other

COMPONENT NAME
UI

CLOUDSTACK VERSION

4.15.0

CONFIGURATION

OS / ENVIRONMENT

SUMMARY

STEPS TO REPRODUCE

I want to use Host HA, So I configure the tag `ha.tag=ha` and tagged the host Client1 with 'ha'. Then I restarted the cloudstack-management server.
But after I logged back in, I saw the client1 Host  label.hastate = 'Ineligible' .
and the Host HA is not working properly
I am so confused that there is something wrong with my configuration, please help me

EXPECTED RESULTS

1. client1 Host Ha enable and label.hastate is displayed correctly
2.  Host HA can working correctly

ACTUAL RESULTS

@staySober did you configure a HAProvider? If so can you find any exceptions in the logs of the agent and/or the management server?

@DaanHoogland yes, I configured the label.haprovider = kvmhaprovider .  I will to check the logs

@staySober I think it's already fixed in 4.15.1, can you check using nightly builds: https://download.cloudstack.org/testing/nightly/latest/ and close this.

Example: http://qa.cloudstack.cloud:8080/client/#/host/3a4a15a8-1d67-4913-9afe-d0240d643195 from latest UI build

<IP_ADDRESS>Ovm3 SystemVm template not found. Ovm3 hypervisor is not used, so not failing upgrade 2021-05-28 15:23:50,893 DEBUG [c.c.u.d.Upgrade41500to41510] (main:null) (logid:) Updating Hyperv System Vms 2021-05-28 15:23:50,896 ERROR [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Unable to upgrade the database com.cloud.utils.exception.CloudRuntimeException: <IP_ADDRESS>Hyperv SystemVm template not found. Cannot upgrade system Vms         at com.cloud.upgrade.dao.Upgrade41500to41510.updateSystemVmTemplates(Upgrade41500to41510.java:210)         at com.cloud.upgrade.DatabaseUpgradeChecker.updateSystemVmTemplates(DatabaseUpgradeChecker.java:254)         at com.cloud.upgrade.DatabaseUpgradeChecker.upgrade(DatabaseUpgradeChecker.java:273)         at com.cloud.upgrade.DatabaseUpgradeChecker.check(DatabaseUpgradeChecker.java:377)         at org.apache.cloudstack.spring.lifecycle.CloudStackExtendedLifeCycle.checkIntegrity(CloudStackExtendedLifeCycle.java:64)         at org.apache.cloudstack.spring.lifecycle.CloudStackExtendedLifeCycle.start(CloudStackExtendedLifeCycle.java:54)         at org.springframework.context.support.DefaultLifecycleProcessor.doStart(DefaultLifecycleProcessor.java:178)         at org.springframework.context.support.DefaultLifecycleProcessor.access$200(DefaultLifecycleProcessor.java:54)         at org.springframework.context.support.DefaultLifecycleProcessor$LifecycleGroup.start(DefaultLifecycleProcessor.java:356)         at java.base/java.lang.Iterable.forEach(Iterable.java:75)         at org.springframework.context.support.DefaultLifecycleProcessor.startBeans(DefaultLifecycleProcessor.java:155)         at org.springframework.context.support.DefaultLifecycleProcessor.onRefresh(DefaultLifecycleProcessor.java:123)         at org.springframework.context.support.AbstractApplicationContext.finishRefresh(AbstractApplicationContext.java:940)         at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:591)         at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.loadContext(DefaultModuleDefinitionSet.java:144)         at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet$2.with(DefaultModuleDefinitionSet.java:121)         at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule(DefaultModuleDefinitionSet.java:244)         at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule(DefaultModuleDefinitionSet.java:249)         at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule(DefaultModuleDefinitionSet.java:232)         at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.loadContexts(DefaultModuleDefinitionSet.java:116)         at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.load(DefaultModuleDefinitionSet.java:78)         at org.apache.cloudstack.spring.module.factory.ModuleBasedContextFactory.loadModules(ModuleBasedContextFactory.java:37)         at org.apache.cloudstack.spring.module.factory.CloudStackSpringContext.init(CloudStackSpringContext.java:70)         at org.apache.cloudstack.spring.module.factory.CloudStackSpringContext.<init>(CloudStackSpringContext.java:57)         at org.apache.cloudstack.spring.module.factory.CloudStackSpringContext.<init>(CloudStackSpringContext.java:61)         at org.apache.cloudstack.spring.module.web.CloudStackContextLoaderListener.contextInitialized(CloudStackContextLoaderListener.java:51)         at org.eclipse.jetty.server.handler.ContextHandler.callContextInitialized(ContextHandler.java:1068)         at org.eclipse.jetty.servlet.ServletContextHandler.callContextInitialized(ServletContextHandler.java:572)         at org.eclipse.jetty.server.handler.ContextHandler.contextInitialized(ContextHandler.java:997)         at org.eclipse.jetty.servlet.ServletHandler.initialize(ServletHandler.java:746)         at org.eclipse.jetty.servlet.ServletContextHandler.startContext(ServletContextHandler.java:379)         at org.eclipse.jetty.webapp.WebAppContext.startWebapp(WebAppContext.java:1457)         at org.eclipse.jetty.webapp.WebAppContext.startContext(WebAppContext.java:1422)         at org.eclipse.jetty.server.handler.ContextHandler.doStart(ContextHandler.java:911)         at org.eclipse.jetty.servlet.ServletContextHandler.doStart(ServletContextHandler.java:288)         at org.eclipse.jetty.webapp.WebAppContext.doStart(WebAppContext.java:524)         at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:73)         at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169)
why I upgrade to 4.15.1 get this error, I never used Hyperv  in my cloudstack, and I try to upload Hyperv  system Vms template but the error still exist

@staySober does the upgrade fail because of this? I don't think this ERROR is FATAL.
Also, is this related to the earlier issue or is this a new one, please?

@DaanHoogland is this not related to the earlier issue. I follow the suggestion of @rhtyd , Try to upgrade from cloudstack4.15 to cloudstack4.15.1 to fix HA state error.But When I finished installing cloudstack4.15.1, I starting cloudstack4.15 management server I get this error. And the server is 503

ok, than the upgrade went wrong, You should not have to have the systemvm template for a hypervisor type you don't use. We'll need to investigate. But let's take care not to mix up issues.
The message you get does mean that the upgrade procedure considered hyperv to be in use in your system. it iterates through the list of hypervisors and encounters one that is of type Hyperv.

@DaanHoogland
Okay I'm sorry I'm not very good at expressing myself.
Thanks help me

@staySober, let's try to isolate the issue. I think you better restore your DB from before the upgrade and than make sure there is no hypervisor in the system that is of type Hyperv. Best check the DB as well (Hyperv is enum value 4)

@DaanHoogland
sure, I check the DB.

There doesn't seem to be an instance of HyperV in my VM instance
What I am doing now is reinitializing the database for 4.15.1. Then I restored the database from 4.15 to the management node from 4.15.1. Now, service running. But some info was wrong. I think this due to I restored the database from 4.15 backup.
management.servers display my version 4.15.0, But I already upgrade to 4.15.1.Of course it's not a big deal, right.
I think there are some errors in the two versions of the code after I upgraded. It is not the database data problem.

@staySober It is not the vm_instance tabel but the field hypervisor_type in the table host to look for the the value of Hyperv.
If you restored the DB fully the table version should no longer contain a record with version.version = '<IP_ADDRESS>` and the management server will start the upgrade anew.
If there is no host entry of hypervisor_type 'Hyperv' the upgrade should not be looking for the systemvm record for it.
You may be right about the software but I still think it is a DB problem. If it is software that would probably lead to many more people complaining about the same issue as work on <IP_ADDRESS> is underway for many months now.

Thank you for your help. I will check this problem according to your tips. If it can be solved successfully, I will close the issue.

I rollback cloudstack to 4.15.0 and restore db, but the error was also exist. I don't know what happened.

And finally I figured out why the error exsit. Because I have a empty cluster  hypervisor_type is hyperv.  But no have any instance. I think is the point to make the mistake.
Thanks a lot everyone

@rhtyd @DaanHoogland
hi friends，I update cloudstack-management server to 4.15.1. and config ha tag,  the host label.hastate also show Ineligible. what's wrong with me? why Host HA function doesn't work

Hi @staySober - can you share your env details (which distro is that?) and have you tried clearing your cache? (try the UI in incognito mode or do Ctrl+Shift+R)

Sure,  CentOS Linux release 7.9.2009 (Core), cloudstack 4.15.1-SNAPSHOT. cluster hypervisor is KVM.
and I try to cleaned cache but it was seem no changed


REQUEST: Generate (or provide assistance on how to) extras that match g:tokyonight_day_brightness

I'd like to have extras files that match the day theme with g:tokyonight_day_brightness = 0.2, but I'm not clear on how I'd do that. It may be obvious, but I'm VERY new to lua, so I'm probably missing something.

You need to add config.dayBrightness = 0.2 to this line
And the in a terminal, run lua lua/tokyonight/extra/init.lua
This will regenerate all the extras using a brightness setting of 0.2


PullReq: Testing

Change-Id: Ief837c84f5d43aa14634d99983494e57ad839bab

Code Review comments can be found at https://gerrithub.io/q/

New changes were pushed at https://gerrithub.io/q/Ief837c84f5d43aa14634d99983494e57ad839bab

New changes were pushed at https://gerrithub.io/q/Ief837c84f5d43aa14634d99983494e57ad839bab

New changes were pushed at https://gerrithub.io/q/Ief837c84f5d43aa14634d99983494e57ad839bab


[BUG] Validation message do not show when field uses hidden inputs.

Bug report
What I did
Added a date_picker or datetime_picker field to a crud panel with a  'required' validation rule. The form was submitted with no date present (create/edit).
What I expected to happen
A red outline would be applied to the date field and the .invalid-feedback message would be visible.

What happened
The error feedback is not visible on the form control.

What I've already tried to fix it
In form_content.blade.php:134, It looks like the .is-invalid class is applied to the hidden input instead of the date input.
The .invalid-feedback div is also outside of the input group.
Backpack, Laravel, PHP, DB version
When I run php artisan backpack:version the output is:
PHP VERSION:
PHP 7.2.27-6+ubuntu18.04.1+deb.sury.org+1 (cli) (built: Feb  5 2020 16:52:29) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.2.0, Copyright (c) 1998-2018 Zend Technologies
with Zend OPcache v7.2.27-6+ubuntu18.04.1+deb.sury.org+1, Copyright (c) 1999-2018, by Zend Technologies
LARAVEL VERSION:
v7.11.0@f4563bd2e0875c59a1f7967abdbe5cef7f240117
BACKPACK VERSION:
4.1.3@02988a0d14b09e55949781d729060df910f0d94b

@rmarshall9n thank you very much for your submition.
I'v just tested and confirmed it's happening.
We will have to take a deeper look how we can solve this issue.
If in the meanwhile you found a solution for it please let us know :)
Wish you the best,
Pedro

Fixed by #2910


Feature Request: Allow 'branding' the Nudge window

As this tool is most likely to be used in enterprise and education organisation it would be useful if it could be 'branded' to display a logo for that organisation.
I know from experience that otherwise - and even with branding still to some extent, users may initially be worried it is a hack rather than a genuine system.
Whilst different people may have different views about the amount of branding they would prefer, I would be happy at least as a starting point if the Apple logo could be (easily) replaced by a custom logo. It would seem the obvious way to do this would be to add an additional key to the mobileconfig/json allowing a file path to a logo file to be specified. If the key is configured and the file exists then Nudge would use this instead of the default Apple logo.

This is already an existing feature, see iconLightPath and iconDarkPath from the the Jamf schema.

Hi, check the  Userinterface customization https://github.com/macadmins/nudge/wiki/userInterface

Please read the wiki :)


Consider regions that lead to very small back paddings as unsuitable

If the resulting back padding is too small to be stored as a hole, we treat the hole as unsuitable for the allocation. This way, we avoid unrecoverable leaks of that back padding, which can add up over time and fragment the heap.
Fixes #66

Published as v0.10.4.


Getting Started Tutorial

It may be best to amend the documentation that @fscottfoti started writing last year.

We will start with Fletcher's website material (in the docs folder) and use the same github pages solution
Will focus on a model user and will use the included example
Will not require the user to modify stuff in activitysim
A second "developer" tutorial will be a deeper dive into modifications for new modules, etc.

In 3/25/2016 meeting notes, @bstabler indicated he would begin writing the example section for ActivitySim. This is the ticket for that action item.

The current documentation tree is:
index

gettingstarted
core
skim
cdap
mnl
util

I'm working on extending it as follows:
index

gettingstarted

installation
installation
installation
installation

core
skim
cdap
mnl
util

In order to make the example as comprehensive as possible, I merged in the trip mode choice running on the tours table for eatout purpose only branch, and then added it to simulation.py.  I also turned on the cdap model and reduced the household sample size to 1000 in order to run cdap with less than 16GB of RAM (#74).

The draft documentation updates are now live for review - https://udst.github.io/activitysim.

I made some significant updates to the wiki as well - https://github.com/UDST/activitysim/wiki

I like the level of effort to go through these items thoroughly. SANDAG will be putting someone on the the Getting Started tutorial the week of April 25.

On the Progress Report Phase 2 page in the wiki, @bstabler downgraded the progress in a lot of areas. @wusun2, please review to ensure you agree. Thanks.


remove default arguments

This PR removes dangerous default arguments.
Do not use a mutable like list or dictionary as a default value to an argument. Python’s default arguments are evaluated once when the function is defined. Using a mutable default argument and mutating it will mutate that object for all future calls to the function as well.

Our usage of default arguments [] and {} is intentional and guarded by the mypy read-only types Sequence and Mapping. See #15349.


Connector should use deepEqual

I have been hunting a bug that turns out to have been caused by the fact that Connector shallowly compares the current slice to the next. The diffs buried deep in a slice doesn't trigger updates in the connected components because of this. For example:
Before:
{
   MapReducer: {
      layers: []
   }
}

After:
{
   MapReducer: {
      layers: [{id: 1, name: 'my-layer'}]
   }
}

...no updates.
I know I can do @connect(state => state.MapReducer) but I also want the component to receive the state from other reducers. Any tips for me?

Unless you're mutating inside your reducer (which you shouldn't do), your MapReducer object will be different every time, and <Connector> will work correctly. What's your MapReducer code like?

Unless you're mutating inside your reducer (which you shouldn't do), your MapReducer object will be different every time,

Hm... this may be the case. Here is what I'm doing:
    case AT.MAP_TOGGLE_LAYERS:
      state.layers = state.layers
        .map( e => {
          if (e.enabled === undefined) { return e; }
          if(isSuperset(action.hidden)(e)){
            e.enabled = false;
          }
          // FIXME: why isn't this working?
          e.enabled = isSuperset(action.shown)(e);
          return e
      });
      return state;

For example
function (state, action) {
  state.xxx = yyy;
}

is wrong,
// ES6
function (state, action) {
  return Object.assign({}, state, { xxx: yyy });
}

// ES7 spread syntax
function (state, action) {
  return { ...state, xxx: yyy );
}

is correct.

Yup, that fixes it. I made a rookie mistake. :tired_face:

No problem!


Variables with a Generic type bound by an extension type don't get null promotion

void main() {
  A().a(C());
  B().b(E(C()));
}

class C {
  void c() {}
}

extension type E(C c) {
  void e() {}
}

class A<T extends C> {
  void a(T? t) {
    if (t == null) return;
    t.c(); // OK
  }
}

class B<T extends E> {
  void b(T? t) {
    if (t == null) return;
    t.e(); // e cannot be unconditionally invoked.
  }
}

The CFE produces no diagnostic and the code can run. The analyzer warns that the variable can be null when the bound is an extension type, but correctly promotes to non-null when the bound is a class type.

The problem is that E is a potentially nullable type (extension types do not have Object as a superinterface unless they are specified to have it). This will suffice:
extension type E(C c) implements Object {
  void e() {}
}

This issue could then be considered to be a duplicate

I think resolving that issue would resolve this one too. I do think we should separately track the fact that CFE and Analyzer don't agree about this code currently. It sounds like the current bug according to the spec is in the CFE not the Analyzer, but we may change the spec to agree with the CFE?

.. sounds like the current bug according to the spec is in the CFE not the Analyzer, but we may change the spec to agree with the CFE?

The specification does not specify that it is allowed to invoke an extension method whose on type is nullable on a potentially nullable receiver, and this means that we need to adjust the specification in any case. This behavior has been implemented for several years, and it would just be a matter of removing this unwanted and unimplemented error from the specification, such that it is aligned with the implementations.
extension on int? {
  void foo() => print('Fooing!');
}

void main() {
  int? iq;
  iq.foo(); // OK!
}

Similarly, we just need to say in the specification that it is not an error to invoke an extension type member m on a receiver whose type is said extension type, even in the case where it is potentially nullable.
extension type E(int i) {
  void foo() => print('Fooing!');
}

void main() {
  E(1).foo(); // OK.
}

Again, this is already the implemented behavior. However, the difference comes up when we consider related types, in particular when the receiver type is a type variable whose bound is such an extension type:
extension type E(int i) {
  void foo() => print('Fooing!');
}

void f<X extends E>(X x, X? xq) {
  x.foo(); // Analyzer: Error.
  if (xq == null) return;
  xq.foo(); // Analyzer: Error.
}

void main() {
  E(1).foo(); // OK.
  f(E(2), E(3));
}

In this case it is the implemented behavior of the CFE, but it is not the implemented behavior of the analyzer.
So I'd recommend that we discuss the changes to the specification in dart-lang/language#3549 (hopefully we can agree on allowing all of the above examples), and then adjust implementations in those (small) ways that are needed.
So perhaps this issue should be blocked on dart-lang/language#3549?


Correcting error in client initialisation.

Found a bug in the SDK whereby Client initialisation is adding a default assignment logger rather the the one passed as in the config param. As the logger field is not exported this initial assignment cannot be updated.

@njflynn thank you for submitting this fix! Sorry for the oversight in our testing - I have augmented the suite in my PR here and will merge it shortly (https://github.com/Eppo-exp/golang-sdk/pull/30)


[BUG] NPE crash

during development of our new lib / bot we have been having issues with lava player NPE causing a stack and for LavaLink to exit which causes all connections to the player to close etc
the issue seams to be when a shard restarts and reconnects to discord (and to lava) which will eventually timeout lavalink's connection to discord due to no resume support which is fine.
the expected behaviour would be on a socket close to have the error be handled so other connections dont also get destroyed (i dont think a lavalink instance per shard is desired), im most likely hitting this issue more than anyone else due to the rate we are restarting shards and bots.
NPE below:
java.lang.NullPointerException: null
    at lavalink.server.io.SocketServer.close(SocketServer.java:130)
    at lavalink.server.io.SocketServer.onClose(SocketServer.java:122)
    at org.java_websocket.server.WebSocketServer.onWebsocketClose(WebSocketServer.java:595)
    at org.java_websocket.WebSocketImpl.closeConnection(WebSocketImpl.java:504)
    at org.java_websocket.WebSocketImpl.closeConnection(WebSocketImpl.java:515)
    at org.java_websocket.WebSocketImpl.eot(WebSocketImpl.java:563)
    at org.java_websocket.SocketChannelIOHelper.read(SocketChannelIOHelper.java:42)
    at org.java_websocket.server.WebSocketServer.run(WebSocketServer.java:406)
    at java.lang.Thread.run(Thread.java:834)

if there is anything else i can provide please let me know

Just to clarify, how many Lavalink connections do you have?

this issue can be done with just 1

This is the line in question: https://github.com/Frederikam/Lavalink/blob/master/LavalinkServer/src/main/java/lavalink/server/io/SocketServer.java#L130
Assuming you are on the same version, it seems that getRemoteSocketAddress() returns null, which is odd. You could try using https://github.com/Frederikam/Lavalink/pull/147 which replaces the old WS server.
https://ci.fredboat.com/repository/download/Lavalink_Build/5192:id/Lavalink.jar?guest=1
Also be sure to migrate your config https://github.com/Frederikam/Lavalink/commit/68be2ecbe23a29991b7fc321aed185b4bafc193b

i will try it and get back to you

is it possible to contact you on discord? having some unrelated issues with this build
Rose (RC) Jackson#0207

Glad I could help


bugfix: fix panic for AttachVolume unittests

Signed-off-by: Eric Li<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did
bugfix: fix panic for AttachVolume unittests
Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #1923 into master will increase coverage by 0.32%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1923      +/-   ##
==========================================
+ Coverage    62.3%   62.62%   +0.32%
==========================================
  Files         200      200
  Lines       15567    15573       +6
==========================================
+ Hits         9699     9753      +54
+ Misses       4609     4569      -40
+ Partials     1259     1251       -8

Flag
Coverage Δ

#criv1alpha1test
33.12% <0%> (-0.17%)
:arrow_down:

#criv1alpha2test
33.66% <0%> (-0.04%)
:arrow_down:

#integrationtest
37.97% <0%> (+0.02%)
:arrow_up:

#unittest
20.48% <ø> (ø)
:arrow_up:

Impacted Files
Coverage Δ

storage/volume/types/volume_util.go
15.82% <0%> (-0.63%)
:arrow_down:

cri/v1alpha2/cri.go
65.96% <0%> (-0.18%)
:arrow_down:

daemon/mgr/container.go
54% <0%> (+0.15%)
:arrow_up:

daemon/logger/jsonfile/utils.go
73.17% <0%> (+1.62%)
:arrow_up:

daemon/mgr/system.go
75% <0%> (+1.72%)
:arrow_up:

daemon/mgr/container_utils.go
58% <0%> (+1.73%)
:arrow_up:

ctrd/image.go
81.18% <0%> (+1.98%)
:arrow_up:

daemon/mgr/image_utils.go
85.45% <0%> (+3.63%)
:arrow_up:

daemon/containerio/options.go
80.95% <0%> (+4.76%)
:arrow_up:

pkg/meta/store.go
59.52% <0%> (+4.76%)
:arrow_up:

... and 4 more

Could you give more details about where panic? show some test logs? @shaloulcy

LGTM


Update gettext catalog for euwe

Requested today by translators.

I vote we up  "maxparams" : 10, // {int} Max number of formal params allowed per function to 12 to fix this build and #211 and #218
As jshint goes away next version, no point in fighting the linters here
@chriskacerguis @mzazrivec @himdel

@AllenBW If.jshintrc was removed here : https://github.com/ManageIQ/manageiq-ui-self_service/pull/127/commits/0cb745a9a6997feaa9471ae769eede24eb978902, how come the "maxparams" : 10 failure is still showing up?

@AparnaKarve that wasn't flagged as a go for euwe, code here (and in all the other failing euwe prs outstanding) still use jscs
https://github.com/mzazrivec/manageiq-ui-self_service/tree/0bcc44dbc897035f5d6c4a6f2e76ab733f011c3e

Agreed, no point in fighting it, I'd actually just set to 0.

Uh, not 0, false :-)

@AllenBW For some reason I assumed this commit : 0cb745a was backported to euwe as well since the backporting is usually like-for-like.
Any particular reason why we are excluding that commit for euwe and keeping it for upstream only?

@AparnaKarve i am the not right person to ask why it was excluded :P @chriskacerguis ?

Looks like it got lost in the euwe/conflicts that happened with @ZitaNemeckova commit.  Can we just re-add what we need?

@mzazrivec could you address that jshint issue, not sure what happened.

@chriskacerguis Did we ever plan on removing .jshintrc ? Or was it unintentionally removed in 0cb745a? (I'm still not clear on that)

If it was an unintentional delete, then we'll need an upstream PR to put .jshintrc back in, with the "maxparams" : 10" rule relaxed. The upstream PR should then be backported to euwe. Once we have taken these steps,  the "maxparams" related failures here in this PR would be resolved.

If it was meant to be deleted, then we'll need a euwe-specific PR to delete .jshintrc

Either of the above 2 actions should sync-up things between upstream and euwe-backporting.

@AparnaKarve hmm something odd is going on, all jshint and jscs has been intentionally removed from sui master here: https://github.com/ManageIQ/manageiq-ui-self_service/commit/67475e886cbd7cd470932c051ed536b53d8be6b4
if we aren't backporting eslint commits, it should definitely be restored

@AparnaKarve no, it should not have been removed.
@AllenBW no worries, can we just add the files back real quick?

It was not removed, that's why we're hitting the failure here. 0cb745a had a rebase artifact removing it, but that change never got to #205 (correctly) so .jshintrc is in euwe and apparently supposed to be (since https://github.com/ManageIQ/manageiq-ui-self_service/pull/184 is euwe/no).
And yes, to make the tests pass here, we'll need to fix jshintrc in darga. That limit of 10 params is simply untenable and needs to be removed - it was never designed to work with angular's DI anyway.
@mzazrivec Could you please change that offending line (maxparams) in .jshintrc to false?
(BTW, @chriskacerguis this is a perfectly good example of what I'm afraid of in #204 - a perfectly good change blocked by an unrelated style check failure (granted, complicated by the fact that the old style checks are run as part of the specs but still))

@chessbyte it's green now :)

@himdel I guess I'm not following your comment.  (1) because that is talking about Code Climate, and this was a Travis failure (going to assume you mean build failures in general), but (2) I far as I see the system worked.  We got a build failure, we investigated, and we resolved in a rather quick process.  AND once we identified the issue, I was more than happy to do a merge with it red, but I wanted to make sure that others in different timezones had the opportunity to comment.  Seems to me that the system worked fine.  If you don't like the way that the system is working (which is totally cool/good to question it...maybe can you log an issue with your proposal (I don't feel that #204 is the place for that, but feel free to discuss in there) and we can discuss with the team at large)?

@chriskacerguis well, OK, if that's what you take from that, I'm happy with how things are :) I was just really afraid of having a policy of "jshint fails, can't merge" and wanted to make that clear :).


Rewrite internals (road to v1 ✨)

Road to v1 ✨
Things done:

[x] Improve memoization for style calculation
[x] Resolve media and util styles correctly

Allow usage of utils in other utils
Allow having media styles in utils, variants, and compound variants

[x] Add tests for internal helper functions
[x] Add more rendering based tests for various cases

Todo:

[ ] Add even more tests 😄
[ ] Test on simulator / real device / web browser
[ ] Make the example app be more like a real-world app with proper examples of the different features

This rewrite should address these issues/PRs:

https://github.com/Temzasse/stitches-native/issues/39
https://github.com/Temzasse/stitches-native/issues/41
https://github.com/Temzasse/stitches-native/pull/42

Since @tkow you've been so active in this project lately I would love to hear your thoughts about this rewrite 😊 Have I missed something important or is there something that we should add to the lib before we publish the v1.0.0 version?

@Temzasse
Thanks for many fixes. These are more concise to understand intention of codes than mine.
I agree with you to improve tests, too. I think the road map is enough to fix lack of features by my modifications.
BTW, though I think v1.0.0 doesn't need it, how do you think about rewriting this library using Typescript? I feel it easier to modify than js codes.
I recently like to create typescript library with swc or esbuild which accelerates  jest running and the build output can be commonjs and es format.
If you feel like it, I may help introducing it after v1.0.0.

@tkow good point about rewriting the internals in TypeScript 👍 I agree that it would improve the development experience if we used TS instead of JS.
I initially tried to write the library purely with TS but it turned out to be very difficult 😅 I think there is a reason why the original Stitches lib kept the typings separate from the library internals since the types are so complex. I still don't fully understand all the TS black magic that is happening in the type defs that I ported over 😆
If we can keep using the separate type defs while converting the internals to TS I think that would be great. However I'm not sure if that will cause problems when we build and package the library for npm 🤔

@Temzasse
Thank you for advices.
In my experience maybe I can reuse ambient files with no modifications and, write source files using typescripts.
I challenge to replace js to ts when I have time!

Though it's not rerated to this roadmap, why don't you deploy this package  from Github Actions.
I made it before with using changesets in this repository. The changesets workflow is available and relatively simple to configure (But, this action have a pitfall to commit .npmrc including npm token (it has risk to leak your npm token) if you don't avoid it by .gitignore or committing your own .npmrc file).
Even if you don't familiar with changesets, you can get started by only a few things  you should know .

Write a change log created by npx changesets command and commit the file your working branch.
If the change log pushed branches which triggers changesets/actions above, the action generate automatically branch and PR from it to publish npm.
If the changesets's file is merged by the generated PR, the action publishes npm follows configurations when the PR closes without errors.

If you're interested CI deploy management. Please feel free to ask me about it.

@tkow
The current release flow has been working pretty well for me so I haven't had the need for automating things 🙂
I'm using np for publishing the package to npm. It automatically creates Github releases with commit messages as the changelog. Also when I'm publishing the package I need to enter a 2fa code in the terminal - does the Github Actions publishing workflow handle that?


[Feature] Add String Function 'replace'

What type of PR is this：

[ ] BugFix
[X] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #16473
Problem Summary(Required) ：

Before this PR, replace is an alias to regexp_replace, but the former expects different results when the pattern contains some characters that have special meanings in regexp.
 mysql> select Haystack, Needle, Rpl, regexp_replace(Haystack, Needle, Rpl) from tbl;
 +-------------------------+------------------+---------------------+---------------------------------------+
 | Haystack                | Needle           | Rpl                 | regexp_replace(Haystack, Needle, Rpl) |
 +-------------------------+------------------+---------------------+---------------------------------------+
 | I like database systems | database         | database management | I like database management systems    |
 | NULL                    | null             | null                | NULL                                  |
 | Moves like Jagger       | Moves like       | Mick                | Mick Jagger                           |
 | PM is awesome           | handsome         | 404                 | PM is awesome                         |
 |                         |                  | Not an empty str    | Not an empty str                      |
 | Do you like sql?        | Do you like sql? | Yes, of course!     | Yes, of course!?                      |
 +-------------------------+-----------------------+---------------------+----------------------------------+

 mysql> select Haystack, Needle, Rpl, replace(Haystack, Needle, Rpl) from tbl;
 +-------------------------+------------------+---------------------+------------------------------------+
 | Haystack                | Needle           | Rpl                 | replace(Haystack, Needle, Rpl)     |
 +-------------------------+------------------+---------------------+------------------------------------+
 | I like database systems | database         | database management | I like database management systems |
 | NULL                    | null             | null                | NULL                               |
 | Moves like Jagger       | Moves like       | Mick                | Mick Jagger                        |
 | PM is awesome           | handsome         | 404                 | PM is awesome                      |
 |                         |                  | Not an empty str    |                                    |
 | Do you like sql?        | Do you like sql? | Yes, of course!     | Yes, of course!                    |
 +-------------------------+------------------+---------------------+------------------------------------+

Checklist:

[X] I have added test cases for my bug fix or my new feature
[X] This pr will affect users' behaviors
[X] This pr needs user documentation (for new or modified features or behaviors)

[X] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[X] I have checked the version labels which the pr will be auto backported to target branch

[X] 3.0
[ ] 2.5
[ ] 2.4
[ ] 2.3

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

@Mergifyio backport branch-3.0

run starrocks_admit_test

run starrocks_admit_test

https://github.com/Mergifyio backport branch-2.5


feat: add endpoint for v1 auth set password

Adds an endpoint for this method here, which is needed for the InfluxCLI influx v1 auth command

I think the change to ref/oss.yml is not correct, since it is put as api/v2 currently


Arrow positioning

Hi guys thanks again for this component it's really useful. I found two little bugs on the arrow position when the tooltip go outside the screen:

when position = bottom / top & arrow right

when position = bottom / top & arrow = center the position is not really center:

I propose a fix here: https://github.com/romainberger/react-portal-tooltip/pull/61

Fixed as of v2.1.1


Update index.md.njk

The word 'Select' should not be used in error messages (probably elsewhere) as it is a key word used in voice recognition software as a result it prevents the voice recognition software performing as required.
e.g speak the command 'Click "Select an option"'
will hear the word "Select" and will search the page for the 'an option' element

Hi @AlanSleeman, thanks for raising this.
Is there an issue that you've seen occur with specific voice recognition software? And is this something you've observed users encounter, or in your own testing?
Error messages aren't interactive elements themselves, so I'm not sure why a user would want to click on them – but they are when listed as links in the error summary.
Thanks.


fix: sort betterScripts in same order of scripts

betterScripts should sort just like scripts

@fisker I have the same kind of change that I've pushed to your PR here: https://github.com/keithamus/sort-package-json/pull/90

close in favor of #90


Display all video thumbnails in one frame in viewerType.scrollable

If the TrimViewer type is set to ViewerType.scrollable the video thumbnail doesn't display on a single frame  if maxVideoLength is provided. Only the provided maxVideoLength portion is shown in the thumbnail.
Platform: Android
Version: video_trimmer 2.0.0

Yeah, that's expected behavior. maxVideoLength specifies the maximum length the trimmed video can have. If you don't want to limit the length of the trimmed video, use ViewerType.fixed. Let me know if I didn't interpret your question properly.

I tried using ViewerType.fixed but the trimmer doesn't move over the thumbnails.

Okay, got it. So, it's basically related to your previous issue (#178). Probably something like a scrollable trimmer without a max length limit should work then I guess?

I just want it to have a max length and then move. With all the thumbnail in one frame. Whatsapp have same functionality.

@sbis04  Any update based on my request?. It's important

@sbis04 please any progress for this issue ?


Update deprecation notice to 3.4/3.5

Deprecation of Python 3.4 and 3.5 for Botocore
As announced in today's blog post, Botocore will be deprecating support for Python 3.4 and 3.5 on 02/01/2021. Users are encouraged to migrate to Python 3.6 or later. This PR will update the README to alert users about the news.
Most users will not need to take action about botocore directly, and can follow steps directly for AWS CLI v1 or Boto3. For customers building directly on top of botocore, you may want to pin to a specific version prior to the deprecation date.
Full details can be found at: https://aws.amazon.com/blogs/developer/announcing-the-end-of-support-for-python-3-4-and-3-5-in-the-aws-sdk-for-python-and-aws-cli-v1/

Codecov Report

Merging #2199 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2199   +/-   ##
========================================
  Coverage    98.19%   98.19%
========================================
  Files           58       58
  Lines        10852    10852
========================================
  Hits         10656    10656
  Misses         196      196

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13aa52a...080e679. Read the comment docs.


(GH-739) Improving image quality and fixing issues with "ico" files

This fixes #739

@batzen thanks for doing this!  I will take a proper look at this later, and get it merged in.  I added a couple of commits into your branch to fix the build error that was happening on AppVeyor.

@batzen thank you for taking the time to dig into this, and for submitting this PR, really appreciate it!


Support for fake modules?

I am writing a VSCode extension that imports the vscode module for interfaces and other things. However, this module does not exist and is provided on the fly by the editor, so there is an error when trying to build the extension. Does this plugin support scenarios like this?
Here is the project: https://github.com/arnohovhannisyan/vscode-syncify.
I tried adding the vscode module to both externals and peerDependencies but it didn't work.

I think it will not work.
Problem is that Parcel first goes to the file system for the location resolution. So if the module does not exist this will throw an error.
What this plugin does is after the resolver did its job. Maybe there is another way to do this (reliably), but I haven't found one earlier. If you come up with any idea some input would be appreciated!

Actually, I think it is possible and I will try to come up with an implementation!
Thinking about it right now!

Landed in develop and the preview (for 0.4.0).
From the documentation:

By default, the modules must be present in the local installation. Otherwise Parcel will complain. This is not always possible / the case.
In this scenario you'll need a virtual module. You can get support for this via Parcel's standard alias.
Consider the following snippet (from package.json):
{
  "externals": [
    "react",
    "foo"
  ],
  "alias": {
    "foo": "./src/foo-virtual.js"
  }
}

Here, we will identify that foo is an external alias and still externalize the call (in the given example to use require('foo')). You could leave the virtual module empty.
Important: If you have multiple virtual modules you should give them all unique paths. Otherwise, this plugin cannot distinguish between them.

Hope that helps :beers!

Testing the preview via:
npm i<EMAIL_ADDRESS>


Support for Motion sensor

Support for Motion sensors if possible.
If not, why?  :)

Duplicated sorry


Can't just evaluate one goal

when I run “python openunmix/evaluate.py --root /local/musdb18 --targets vocals  --model my_model --residual acc”
appear：
Traceback (most recent call last):
File "openunmix/evaluate.py", line 260, in
results.add_track(scores)
File "/home/bianyuren/anaconda3/envs/umx-gpu-pytorch_1_8/lib/python3.8/site-packages/museval/aggregate.py", line 183, in add_track
self.df = self.df.append(track.df, ignore_index=True)
File "/home/bianyuren/anaconda3/envs/umx-gpu-pytorch_1_8/lib/python3.8/site-packages/museval/aggregate.py", line 113, in df
return json2df(simplejson.loads(self.json), self.track_name)
File "/home/bianyuren/anaconda3/envs/umx-gpu-pytorch_1_8/lib/python3.8/site-packages/museval/aggregate.py", line 413, in json2df
df = pd.melt(
File "/home/bianyuren/anaconda3/envs/umx-gpu-pytorch_1_8/lib/python3.8/site-packages/pandas/core/reshape/melt.py", line 64, in melt
raise KeyError(
KeyError: "The following 'id_vars' are not present in the DataFrame: ['name', 'time']"

@BYR-HZ will have to look into this to reproduce. Do you have some more information or advice how to quickly reproduce this?

I've only trained one Vocals model and wanted to be able to evaluate it。When I follow your instructions  run“python openunmix/evaluate.py --root /local/musdb18 --targets vocals --model my_model --residual acc”。
Error occurred：
raise KeyError(KeyError: "The following 'id_vars' are not present in the DataFrame: ['name', 'time']"
Because there is no correct data format to pass into museval。
When I change line 337 of the model.py
estimates_dict["residual"] = estimates[:, -1, ...]-->estimates_dict["accompaniment"] = estimates[:, -1, ...]
The problem is solved.


Adding a method to VectorDense for element-wise operations

Is there a way to apply an operation to every element of a vector without extracting the underlying slice and manually iterating over it? Something like:
func (v *VectorDense) Apply(func (float64) float64)

that enables me to write code like:
var v VectorDense
// ... (populate with values)

// elementwise apply the sigmoid function
v.Apply(func(x float64) {
  return 1.0 / (1.0 - math.Exp(-x))
})

I could be convinced otherwise, I'm not sure this is really that beneficial. It's generally more go-like to just write the loop. It's more legible, and often more performant.
for i := 0; i < v.Len(); i++ {
    v.SetVec(i, f(v.At(i,0))
}

doesn't seem that burdensome to me.

Thanks, I was thinking the same, but I often do about these kinds of helpers so having another voice makes me feel better.


GET https://<IP_ADDRESS>:8000/static/js/bookmarklet.js?r=3481385548527016 net::ERR_CERT_AUTHORITY_INVALID

Hi, I encountered this error when I tried to bookmark the images on a website running under HTTPS using Chrome.
My assumption is that the error is caused by using an SSL certificate that a CA does not issue.
I then switched to Firefox and on my first try to bookmark images I got an error that stated that
the script was not loading but further investigation showed me that what prevented the file from loading was the following error MOZILLA_PKIX_ERROR_SELF_SIGNED_CERT, it seems like it's the same cert problem with the  Chrome browser.
All the following test was done under https://mysite.com:8000.
chrome version: 112.0.5615.137 (64 bits)
firefox version: 112.0.2 (64 bits)

The way I solve this issue is I replaced the hostname mysite.com with the loopback address <IP_ADDRESS> like https://127.0.01:8000 and the error is gone both in Chrome and Firefox
Note: After that, you can switch back to https://mysite.com and everything will continue working fine.


[UxSite] Scroll indicator horizontal scroll incorrect when you have horizontal and vertical scrolling

When you have a scroll bar for both horizontal and vertical scrolling like on https://ux.symfony.com/notify for block src/Controller/NotifierController.php the horizontal scroll balk is shown on the bottom of the block, so you first need to scroll all the way down before your can scroll horizontally.
Can only confirm that this is the case on desktop.

I'm not sure what controls that - but I'll ping someone smarter than me to look into it :)


Specifying headers for OPTIONS method (CORS)

Any hints on how to translate  something like this to Swagger-Blocks?
      200:
        description: Returns the CORS response headers
        headers:
          Access-Control-Allow-Origin:
            type: string
          Access-Control-Allow-Credentials:
            type: boolean
          Access-Control-Allow-Headers:
            type: array
            collectionFormat: csv
          Access-Control-Allow-Methods:
            type: array
            collectionFormat: csv
          Access-Control-Max-Age:
            type: integer

I think this will work
        response 200 do
          key :description, 'Success'
          header 'Access-Control-Allow-Methods' do
            key :type, :array
            key :collectionFormat, :csv
            items do
               key :type, :string
           end
          end
          header :another do
            key :type, :string
          end


Add Arch Linux package install instructions

Includes (relatively) minor touch ups.
Fixes #294.

alternatively install pacaur and install rust nightly/git

There are AUR packages for this as well.

Does it make sense to just tell arch users to use the AUR package?

I didn't realize, the code change IS using the AUR, just manually building from AUR rather than using a helper. I had seen makepkg and assumed it was a PKGBUILD in the alacritty tree. Probably fine as is; maybe a link and sentence about it being on the AUR would be helpful.

Does the AUR package have to be updated regularly or does it track this git project automatically?
I'm obviously not familiar with Arch. Thanks for entertaining my questions :)

It's pretty straight forward, here's a quick run down. This is latest PKGBUILD. It's the only thing needed to build the Arch package: https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=alacritty-git
There's no direct reference to a specific git version (other than the pkgver being 361 which is a nod to the number of commits on master). But the way the pkgver function works there... it will actually build from master and set the package version to the Cargo.toml verion with the commit count appended.
So, if you were to install it right now, you'd get the current latest commit. It wouldn't be triggered for an auto-update until the owner manually bumps the pkgver or you decide to force re-install.

@colemickens thanks for the explanation--that's actually pretty straight forward. It seems that the changes suggested here are probably good to go.

It tracks it automatically
On Jan 19, 2017 12:19 AM, "Joe Wilm"<EMAIL_ADDRESS>wrote:

Does the AUR package have to be updated regularly or does it track this
git project automatically?
I'm obviously not familiar with Arch. Thanks for entertaining my questions
:)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/jwilm/alacritty/pull/314#issuecomment-273684617, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFD6iKC1OGSs1r6Uosv5hjIApV2Re3R8ks5rTvJjgaJpZM4LjvMu
.

I think it is sufficient to link to the AUR package, rather than stepping the user through the process of downloading and building with makepkg. An Arch Linux user will likely know how to install from the AUR (if they want to). If they do not know, they should definitely refer to the wiki


App terminates when trying to Chromecast.connectToDevice(id)

Hi,
Just been trying to set this up and get it working, but I've taken your example class and whenever it get's to the point of connecting to device Chromecast.connectToDevice(id) the app just terminates with the following message:
Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'GCKCastContext has not been created yet with +[setSharedInstanceWithOptions:]'
Any thoughts?

hi, are you using master, or the last release?

Hi, I installed using the instructions in the readme.md, the package.json says:
"react-native": "0.44.0",
"react-native-google-cast": "^1.3.0"

ok, will take a look

I had the same issue with iOS and activly downgraded the sdk to v2 (like in https://github.com/charliesbox/react-native-google-cast/blob/master/example/ios/Podfile.lock but 2.10.x )
@charliesbox Maybe this is possible im Android, too?

@DracoBlue for sure, there's a line in the gradle file where the version was restricted :)
Looks like new version for iOS - Android was really a major change.
Thank you for finding this workaround.

I'm testing a new version here -> https://github.com/charliesbox/react-native-google-cast/pull/42
So far, so good, using Cast SDK 3.3
Could you help me testing it?

Yep! Will try the #42 tomorrow!

I changed the pod definition to pod 'google-cast-sdk', '3.3.0' and it works very well!


Insufficient Memory: bad_alloc

Hello,
when I was trying to train the model with VGG16 base model, I got an error of bac_alloc related to the insufficient memory allocation on my DSVM with 4GB memory.
Basically, this is not a programming error. But I think pointing out the minimum requirements on the resource, like memory, will ease lots of pain for the people whose training aborted after running for a long time due to this problem.
Finally, here are some experiment results collected from the Linux DSVM:

VGG16 + e2e: above 4GB but below 8GB
VGG16 + 4-stage: around 17GB

Best wishes!

Good find, I'll add that hint to readme


[BUG] i/o timeout error

Checks

[✅] I confirm that I have searched existing issues and couldn't find a similar bug.
[✅] I have read the documentation carefully and it couldn't resolved my problem.

Describe the bug
Error: Get "https://openaipublic.blob.core.windows.net/encodings/cl100k_base.tiktoken": dial tcp: lookup openaipublic.blob.core.windows.net on <IP_ADDRESS>:53: read udp <IP_ADDRESS>:50455-><IP_ADDRESS>:53: i/o timeout
Details: file(/home/runner/work/SydneyQt/SydneyQt/app.go), line(90).
To Reproduce
Steps to reproduce the behavior:

Open SydneyQt with an SSH proxy in use
See error

Expected behavior
SydneyQt finishes starting up and is ready for use.
Desktop (please complete the following information):

OS and Version: Linux 6.1.0-15-amd64 SMP PREEMPT_DYNAMIC Debian 6.1.66-1 (2023-12-09) x86_64
SydneyQt Version: v2.3.0

Additional context
SydneyQt was working correctly yesterday.

Might be an issue with my internet, closing for now.


[WIP][SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy

What changes were proposed in this pull request?
1.Add version information to the configuration of Deploy.
2.Update the docs of Deploy.
Note: This PR need after https://github.com/apache/spark/pull/27592
Why are the changes needed?
Supplemental configuration version information.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Exists UT

@HyukjinKwon

Test build #118791 has started for PR 27668 at commit 2eec92e.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23543/
Test PASSed.

Test build #118791 has finished for PR 27668 at commit 2eec92e.

This patch fails to generate documentation.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118791/
Test FAILed.

retest this please

Test build #118795 has started for PR 27668 at commit 2eec92e.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23546/
Test PASSed.

Test build #118795 has finished for PR 27668 at commit 2eec92e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118795/
Test PASSed.

Test build #118806 has started for PR 27668 at commit 4e7ff54.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23556/
Test PASSed.

Test build #118806 has finished for PR 27668 at commit 4e7ff54.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118806/
Test FAILed.

Test build #118810 has started for PR 27668 at commit ee3cdd2.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23560/
Test PASSed.

@HyukjinKwon spark.deploy.recoveryMode.factory appears in branch-1.3, but the version number in the pom.xml file corresponding to the commit is 1.2.0-SNAPSHOT. Is the since version of this configuration 1.2.0 or 1.3.0?

Test build #118811 has started for PR 27668 at commit bd6416b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23561/
Test PASSed.

Test build #118810 has finished for PR 27668 at commit ee3cdd2.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118810/
Test FAILed.

Test build #118811 has finished for PR 27668 at commit bd6416b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118811/
Test PASSed.

Test build #118843 has started for PR 27668 at commit 5891872.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23591/
Test PASSed.

@HyukjinKwon I have removed the comments and add GitHub comments for each item.

Test build #118843 has finished for PR 27668 at commit 5891872.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118843/
Test PASSed.

Merged to master.

@HyukjinKwon Thanks for your help! @srowen Thanks for your review.


tools/dockerfile: Cache Java downloads to reduce flakiness

Pre-running the build will save artifacts in ~/.gradle which can be
reused for the real build. This reduces our reliance on build-time
downloads which hopefully reduces flakiness rate.
This increases the container size by ~300 MB.
Fixes #18892

I realize now that this will impact the interop images that are published for historical testing. I don't want those to have this baggage. I think I will swap to running gradle twice gradlew || gradlew sort of fashion. "Poor man's retry."
Since I've gotten practice using Google Cloud Build, and am reasonably happy with it, I could make a Build that would create a cache on GCS. That would be possible in the medium-term. We would use it for our Kokoro builds as well.


feature/tsuji1/constraints

Improvements to constraint solvers to support ALE3D implicit hydro

Extension of Penalty/Elimination solvers to use GMRES
Extension of Penalty solver to handle variable penalty parameters
Adding a function to set the preconditioner pointer for Penalty/Elimination/SchurConstrained solvers
Adding more functions to choose Hypre parameters
Fixing a memory error with SuperLU

Hi @ptsuji,
When this is ready, can you mark it with the ready-for-review label?
See https://github.com/mfem/mfem/blob/master/CONTRIBUTING.md#quick-summary for more details.
Tzanio

Hi @tzanio,
Is there an automated build/test script for MFEM on LC machines? I see that it is failing the automated macOS, Windows, and ubuntu builds, but I don't know how to reproduce those. I have a MacOS laptop so I can try to run the same script there. When we build MFEM through ALE3D and specify our own TPLs, it builds fine on TOSS3 with Intel oneAPI and gcc, BlueOS with clang, and our Windows build with Visual Studio/Intel 2022 (the added project files in the "Win32" directory).
-Paul

@tzanio, since it passed all the checks, I've added the ready-for-review label. Thanks for fixing the style and documentation stuff. Please add/change reviewers as you see fit.

Thanks @ptsuji, I started looking at it and didn't get a chance to continue, but it looks good now.
We will start the review.

This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch.

@jamiebramwell, @mlstowell and @v-dobrev -- can you please review when you get a chance?

Hi @tzanio, is there anything I need to do for this pull request? Or are we waiting on @jamiebramwell, @mlstowell, and @v-dobrev for review?

My apologies @ptsuji , this slipped through the cracks.
I'll follow-up with the reviewers and they will let you know if they recommend any changes.

[ ] Please update CHANGELOG
[ ] Maybe mention the Win32 files in INSTALL?

Thanks for taking the time to work on this @ptsuji!
I left a few small comments, but everything looks great to me overall.
I do have one request though -- is it possible to move the Win32 directory from the top-level to say a subdirectory of config?

@ptsuji, can you also address the TODO items in https://github.com/mfem/mfem/pull/3117#issuecomment-1240012023?

@tzanio I updated the CHANGELOG and INSTALL files, sorry for the delay. Please let me know if those comments look good.

Thanks @ptsuji!
I made some editorial adjustments (do not to mention ALE3D explicitly) and I think we are good to go now.
Appreciate your help and patience with this! 🙏

Merged in next for testing...

Hi @ptsuji,
My apologies for this, but after discussing this at the weekly code review meeting we decided that the config/Win32 directory is too specific for ale3d, and it probably shouldn't be in mfem.
Is it possible to remove that and maintain it externally, or will that be a significant burden for you?
If the answer is "yes", I am happy to make the adjustments myself in this PR.
Tzanio

@tzanio that sounds good. If we're the only code using it, it should be removed; we'll maintain it separately in our version of MFEM.

If we're the only code using it, it should be removed; we'll maintain it separately in our version of MFEM.

Thank you @ptsuji
Can you take a look at https://github.com/mfem/mfem/pull/3117/commits/9d86d75a301fbac7f83dc277c348db9336867c6a and confirm that works for you?

@tzanio looks good to me, thanks!

thank you!


Resize windows to fit the workspace automatically

Is there currently a way to make Yabai automatically rearrange the workspace by resizing the windows trying its best to avoid overlaps? I am aware of the issue of some windows having minimum size, the question is not about it.
Let's say I have a few windows, one of them defines some sort of minimum size, and cannot be resized down to fit. However, the rest of the windows do not have a minimal size constraint (e.g. a Terminal window), so I would want them to shrink instead to accomodate a bigger non resizeable window without overlaps.

This is not possible. Dealing with min and max size constraints properly is tricky, because there is no API that returns this information.


Add commits list as a repo tab

Description
It would be great if the commits page of a repo can be added as one of the repo tabs (alongside Issues, Pull Requests, etc.).
Commits are one of the core entities that we interact with when working with Git, but right now the page that lists them has to be accessed by going to the home page of a repo and clicking on an easy-to-miss link at the top right of the files list.
Example URLs
https://github.com/refined-github/refined-github
https://github.com/refined-github/refined-github/issues
https://github.com/refined-github/refined-github/issues/1
etc.

https://github.com/refined-github/refined-github/blob/main/source/features/more-dropdown-links.tsx


Flannel container should mount /etc/ssl/certs instead

Recent version of flannel (0.5.3) switched to using a different etcd client library which checks whether TLS certs I assume. In my case, I have TLS configured everywhere, including etcd. I am using TLS certs signed with my own CA.
The CA cert is added via write_files to /etc/ssl/certs and update-ca-certificates is used to generate new ca-certificates.crt file.
Looking at flannel.service file, it seems to mount /usr/share/ca-certificates which does not contain my custom CA cert.
Shouldn't flannel mount /etc/ssl/certs instead?

In CoreOS, flanneld.service pulls in /usr/share/ca-certificates for "well-known" certs (in practice it is needed to talk to AWS metadata service). Your custom ones should go into /etc/ssl/etcd on the host which also gets mapped into /etc/ssl/etcd in the container. So you should then use config-config's coreos.flannel.etcd_certfile and set it to /etc/ssl/etcd/mycert.crt. Same goes for etcd_cafile and etcd_keyfile. Let me know if it doesn't work.
Also, the host location is configurable. Using flanneld.service drop-in, you can override it using Environmnet="ETCD_SSL_DIR=/etc/ssl/certs". Just remember that the path inside the container is still going to be /etc/ssl/etcd so your paths in cloud-config will still need to use /etc/ssl/etcd.

@eyakubovich thanks. That actually works. It is just a little annoying that I have to put CA cert in two different places on the host: /etc/ssl/certs and /etc/ssl/etcd.
I am going to close this one now.

@vaijab Did you try the ETCD_SSL_DIR to override the path?

@eyakubovich I just added CA cert to /etc/ssl/etcd and set coreos.flannel.etcd_certfile - that works well.
AFAIK go's TLS implementation looks in /etc/ssl/certs for CA certs by default, so it would make sense for flannel to just assume that custom CA certs live in /etc/ssl/certs, that's why I suggested flannel to mount /etc/ssl/certs as well.

@vaijab You're definitely right but there's a technical issue doing it this way. Because CoreOS is shipped completely in /usr, /etc/ssl/certs has individual symlinks to certs in /usr/share/ca-certificates. The directory itself is not a symlink so you can place custom certs there.
But because flannel runs in a container, we actually can't mount host's /etc/ssl/certs into the container. It will result in broken links. Instead, we mount /usr/share/ca-certificates into container's /etc/ssl/certs and have to create a separate volume for the custom ones.
One workaround would have been to also mount /usr/share/ca-certificates into the container at the same path to keep the links working. Yet that also seems hacky.


Add pnpm audit step before lanching the test suite

Description
This Feature will add a check related to high and critical vulnerabilities before launching the test suite.

:tada: This issue has been resolved in version 4.5.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


No metrics visible in Grafana

Thanks for sharing this. I've been trying to implement collectsphere for our vsphere setup but so far I can't get the metrics to show up in grafana. I was trying to use your demo grafana, but it seems to be down. It would have been a great way to see how the queries need to be structured.
We're not using graphite but influxdb, so the path is slightly different:
collectsphere -> collectd -> network plugin -> influxdb -> grafana.
Using run-test.py as per wiki and running collectd in debug mode show that data is actually gathered by collectpshere/collectd. Another test with https://github.com/llambiel/collectd-vcenter did produce results in grafana but it seems older and less up-to-date/capable than collectsphere and I had to hack around in the code to get the ssl connection working (untrusted cert). I'd love to use collectsphere, but so far I'm at a loss and would appreciate any feedback or tips to get it working.

Hi there,
Sorry but our wiki is not up-to-date. Please use the ReadMe instead. The demo server is offline. We will update the wiki later.
I've committed a patch so that the data will be collected correctly now

I've pulled latest master, here's the current config:
TypesDB "./vmware-types.db"

<LoadPlugin "python">
    Globals true
</LoadPlugin>

<Plugin "python">
    ModulePath "/usr/lib/collectd/python"
    Import "collectsphere"
    <Module "collectsphere">
        Name "Test-YQG-VM"
        Host "<IP_ADDRESS>"
        Port "443"
        Verbose true
        VerifyCertificate false
        UseFriendlyName true
        Username "#########"
        Password "#########"
        Host_Counters "cpu.usage,mem.usage,disk.usage"
        VM_Counters "cpu.usage,mem.usage"
    </Module>
</Plugin>

collectd ist starting up and seems to be collecting:
dispatch<PHONE_NUMBER>.0   Test.mc_2_yqg_test_io.all      41
dispatch<PHONE_NUMBER>.0   Test.mc_2_yqg_test_io.all      48
dispatch<PHONE_NUMBER>.0   Test.mc_2_yqg_test_io.all      46
dispatch<PHONE_NUMBER>.0   Test.mc_2_yqg_test_io.all      44
dispatch<PHONE_NUMBER>.0   Test.mc_2_yqg_test_io.all      48
dispatch<PHONE_NUMBER>.0   Test.mc_2_yqg_test_io.all      45
dispatch<PHONE_NUMBER>.0   Test.mc_2_yqg_test_io.all      45
dispatch<PHONE_NUMBER>.0   Test.mc_2_yqg_test_io.all      45
dispatch<PHONE_NUMBER>.0   Test.mc_2_yqg_test_io.all      47

However, I can find neither new series to select nor VM/ESXI hosts when querying for hosts in grafana.
How is it be supposed to work anyways? Are collectsphere metrics storerd in new series or would they join collectd's already existing series, like cpu, mem and only add the hosts there?

This had me confused earlier as well. Here's how it goes:
Collectsphere generates one measurement at the remote side (where you have the collectd interface of influxdb configured to) which in my case is called
> show measurements;
name: measurements
name
----
collectsphere_value

I have not configured that, data just came in that way, then you have the data organized in three tags one tag is called host but unfortunately it does not represent collected hosts but hosts that you have collected from. The tag storing the hostnames of Hypervisors and VM's is called type_instance.
If you can, try and browse the data on influx first, the grafana interface still confuses me, but
this worked out quite well and now I'm able to plot graphs within grafana as well.

Hmm, I'm seeing the exact same list in influx as I do in grafanas list:
> show measurements;
name: measurements
name
----
Vcenter_value
aggregation_value
cpu_value
disk_io_time
disk_read
disk_value
disk_weighted_io_time
disk_write
interface_rx
interface_tx
ipmi_value
load_longterm
load_midterm
load_shortterm
memory_value
netlink_rx
netlink_tx
netlink_value
nginx_value
ping_value
rabbitmq_value

The vcenter_value was created by my test with collectd_vcenter which is more or less exactly the mechanic @jakape described where I could get the metrics. All other values are collectds internal metrics collectors. As this is the same collectd instance that was used to test collectd_vcenter I feel confident that it's not a collectd->influxdb issue. Obvisouly the metrics aren't getting stored in influxdb, hence nothing to see in Grafana.
Could this possibly be due to the usage of the network (output) plugin? I'm not using the graphite output plugin (which requires to put influx into some compat moden which often produced quirky results).

Well if you can't see any propagated values you should see tons of error messages in the influx-db log. Did you provided the collectd backend of influxdb with the vmware-types.db from this repository?
On a side note: I am also not using the graphite backend for communication with grafana and can see the values within there.

Yes, I've put vmware-types.db into "/usr/lib/collectd/python", where collectsphere.py lives. I don't see any errors/warnings in influxdbs logs. Perhaps I need to start tcpdumping traffic to influx to make sure that those messages are actually shipped to influxdb or not, in order to encircle it further?

 a


Support for GitLab tickets/merge requests

Analogous to the github ticket/PR integration, we could also support the GitLab Issues API.

API:
https://xxx.com/api/v4
To get the issue itself:
/projects/:id/issues/:number
While projectId equals to the repo encoded.
Eg ioki/summaraizer is ioki%2Fsummaraizer
https://docs.gitlab.com/ee/api/issues.html#single-issue
To get comments (notes in gitlab):
`/projects/:id/issues/:number/notes`

https://docs.gitlab.com/ee/api/notes.html#list-project-issue-notes (they are paginated, only 20 notes per request)
It seems that comments requires an token.
This can be done via the header PRIVATE-TOKEN: [TOKEN]

Fixed via #25


Slide box assigning to read only property not fixed

Please reopen #3589
See: https://github.com/driftyco/ionic/commit/08956b29b0ccf93203681a83f6ae6c5c9c28375f

Greetings @realityfilter!
My sensors indicate that you need to update your issue through our custom issue form. We are now requiring all issues to be submitted this way, to ensure that we have all of the information necessary to fix them as quickly as possible.
Click Here To Update Your Issue
I will have no choice but to close this issue if it is not resubmitted through the form. Please fill out the rest of the form, so that I may use my friendly robot powers to assist you.
Thank you!

thanks


front: remove data source config

Data source config (embedder, model, chunker) is now 100% a core concern so we can remove it from front.
This will enable us to iterate on the shape of that config from core only.

Legacy as users were setting chunk size and picking model not so long ago


No templates

[Enter feedback here]
On this page is a link https://aka.ms/EdgeEnterprise that supposedly has the "Microsoft Edge policy templates" but I have not been to find them. Either they are not there or too well hidden. :-(

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8e4fa0af-82d8-c1ca-02b3-fc55eb620ff3
Version Independent ID: bd546e78-3406-0fdd-2aea-d0bd72be9f38
Content: Configure Microsoft Edge for Windows
Content Source: edgeenterprise/configure-microsoft-edge.md
Product: microsoft-edge
GitHub Login: @kelleyvice-msft
Microsoft Alias: brianalt

@bbloksma T
oday i downloaded the latest edge chromium-based administrative templates and added in windows 10  20H2.
https://www.microsoft.com/en-us/edge/business/download  use chrome browser in windows or in android.

@bbloksma Hi!  Hope you were able to find the policy files but if not here is a screenshot specifically where on the page they can be found.  Thanks!


Add maintainer for RPM

Signed-off-by: Gábor Lipták<EMAIL_ADDRESS>What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #357

@seankelly001 please review


Updated to Google Play Services 7.8, Ti SDK 4.1.0

I've taken the liberty to update the android version of the module to use Google Play Services 7.8 and Ti SDK 4.1.0.
I gave it a new version number for android: 3.2.0.
This was important to me, because we use ti.dfp for serving ads via Doubleclick for Publishers.  We need MRAID 2 compatibility, which requires Google Play Services 7.8.  If multiple modules in a project use Google Play Services, they all have to be on the same version.
It is possible to hack around this by manually copying the desired version of the google-play-services.jar file into the modules that use other versions (and in fact I have to do that for ti.map and ti.cloudpush).  My hope is that if we can get some of the most popular modules that use Google Play Services onto the same version of Google Play Services, it might make development of android apps a little easier.

Please merge.


Date based rates

Thanks for sharing this package!
I looked through the code, but couldn't find an answer... Is there a way to set booking rates based on other things than quantity of a specific unit?
I.e. to have a different rate for a weekend / midweek etc.?

Absolutely, you can set date based rates of course, but that's called availability prices. Through the bookqble resource itself, you can optionally either flat rate, or custom rates per day and even hours 😉 Let me know if you can't figure it out 👌

That's nice(!), but I'm not sure yet it entirely covers my use case.
Say you have a room (resource) which has an availability of 24/7. It has a weekend price (+20% per day), a midweek price (+0% per day), and a high-season price (+30% per day).
If I book from Wednesday to next Thursday in the high-season, what should be charged? Can this package handle this use case (with a little configuration obviously :) )?
Perhaps a better solution for me would be to use the bookable package to book and calculate a basic fee, and then discount / top up in the actual order model.
Suggestions would be welcome!

Well, as far as I understand your use case, this package totally supports it. The point here is that this package doesn't do the calculation for you, it has nothing to do with doing the math or the payment, so it's intentionally left to the developer implementation. So shortly, you can set your rates as you wish, as per your explanation, and in your ordering process, make sure to take into consideration these rates & availability prices.
Please feel free to open this issue, or a new one if you've further questions :)


hot water zone compatibility bug fix

Proposed Changes
Please see my comments in the HA PR https://github.com/home-assistant/core/pull/121503#issuecomment-2323477115
Due to missing hot water zone attributes(dazzleMode enabled  and open_window_detection enabled  timeout_in_seconds), integration setup flow was failing. I made these local changes to fix the issue. Feel free to let me know if you have a better idea.
Related Issues

(Github link to related issues or pull requests)

Still related


Use the latest Lato release

This uses the latest Lato release directly from the Lato Fonts website. It will also make the .org site use the exact same version of the font as the theme (after https://github.com/rtfd/sphinx_rtd_theme/pull/639)

http://www.latofonts.com/2015/08/06/lato-font-family-updated-version-2-015/

Any changes required to bower.json?

We aren't using the Lato from bower unfortunately. The version in bower only includes the TTF file. It might still be loaded on some old versions of docs, but it won't be used on anything new.


angular ui-grid v3.0.0-RC.18 remaining columns to resize after column width is resized manually

After resizing a coulmn to be smaller I want the remaining columns to adjust their width to take up the entire space of the grid. There should never be any white space. How do I achieve this behavior?
The behavior I want is on this demo from ui-grid:
http://ui-grid.info/docs/#/api/ui.grid.resizeColumns.directive:uiGridColumnResizer
Currently when I resize a column all columns maintain their size an the right side of the grid has white space.

That would need to be an enhancement to the resizing feature, and not one that everyone would want so it would need to be toggle-able. If you're interested in attempt a pull request or maybe discussing it in the gitter channel that would be a good next step.

This is a problem experienced with autoResizing as well.


Update test_nirspec.py

After importing a PRD with the recent NRS SIAF changes, test_nirspec.py fails two transform tests:
======================================================= short test summary info ======================================================== FAILED test_nirspec.py::test_nirspec_aperture_transforms - assert 0.27277224621730056 < 0.2 FAILED test_nirspec.py::test_nirspec_slit_transformations - assert 0.27277224621730056 < 0.1 ==================================================== 2 failed, 30 passed in 25.56s =====================================================
@charlesrp provided the following explanation:

The real problem is with the test function.  Because of the micro-shutter array, in imaging mode only about 1/2 of each of the NIRSpec detectors can actually see the sky.
So the transforms are really only constrained and used on those parts of the detectors. Unfortunately the test function was set up to use points over the whole regions of the detectors including parts that never see the sky in imaging mode.
Pre-launch, the discrepancy in the extrapolated region wasn’t too bad, but since the on-sky solution has more structure, the extrapolation goes bad more quickly.

The best solution would be to fix the test function so it only tests points in the valid region.

Tracy has code that includes the needed fix and also adds some tests for other transforms that were not previously tested.

So we should discuss how to get this improved test code merged into PySiaf. If that can’t be done in the short term, a waiver might be appropriate.

So we have two options on how to proceed and be able to do valid releases of pysiaf:

Increase pixel_threshold temporarily to allow the tests to pass, similarly as to what has been done for FGS as part of #186
If @tracy-beck has the new code ready to go we add it to this release.

1 is obviously not great, but will allow us to get the new release out for NIRCam and MIRI. 2 has a lot more risks, in that Tracy is probably extremely busy, may need more time to test her changes, and will probably want some help creating the PR.
Even if we do decide to do option 1, we need option 2 before the end of commissioning.

I created a branch to test option 1 above on my personal fork. The two tests that were failing now pass, but two different ones now fail:
======================================================= short test summary info ======================================================== FAILED test_miri.py::test_against_test_data - AssertionError: FAILED test_nirspec.py::test_against_test_data - AssertionError: Failed for NRS1_FULL_OSS ==================================================== 2 failed, 30 passed in 29.73s =====================================================
So it's not quite the quick fix we were hoping for, as far as getting a new release out.

Tried the quick and dirty fix again and it works. I may just have been more careful in other steps this time:
========================================================= test session starts ==========================================================
platform darwin -- Python 3.9.12, pytest-7.1.1, pluggy-1.0.0 -- /Users/dlong/miniconda3/envs/pysiaf/bin/python
cachedir: .pytest_cache
rootdir: /Users/dlong/pysiaf, configfile: setup.cfg
collected 32 items
test_aperture.py::test_idl_to_tel PASSED                                                                                [  3%]
test_aperture.py::test_hst_fgs_idl_to_tel PASSED                                                                                [  6%]
test_aperture.py::test_jwst_aperture_transforms PASSED                                                                           [  9%]
test_aperture.py::test_jwst_aperture_vertices PASSED                                                                             [ 12%]
test_aperture.py::test_raw_transformations PASSED                                                                                [ 15%]
test_aperture.py::test_jwst_sky_transformations PASSED                                                                           [ 18%]
test_hst.py::test_hst_aperture_init PASSED                                                                                [ 21%]
test_hst.py::test_hst_siaf PASSED                                                                                [ 25%]
test_hst.py::test_hst_amudotrep PASSED                                                                                [ 28%]
test_iando.py::test_write_jwst_siaf_xml PASSED                                                                                [ 31%]
test_iando.py::test_write_jwst_siaf_xlsx PASSED                                                                                [ 34%]
test_match_v2v3.py::test_match_v2v3 PASSED                                                                                [ 37%]
test_miri.py::test_against_test_data PASSED                                                                                [ 40%]
test_nirspec.py::test_against_test_data PASSED                                                                                [ 43%]
test_nirspec.py::test_nirspec_aperture_transforms PASSED                                                                         [ 46%]
test_nirspec.py::test_nirspec_slit_transformations PASSED                                                                        [ 50%]
test_nirspec.py::test_sci_det_consistency PASSED                                                                                [ 53%]
test_plotting.py::test_aperture_plotting PASSED                                                                                [ 56%]
test_polynomial.py::test_poly PASSED                                                                                [ 59%]
test_polynomial.py::test_RotateCoeffs PASSED                                                                                [ 62%]
test_polynomial.py::test_two_step PASSED                                                                                [ 65%]
test_polynomial.py::test_invert PASSED                                                                                [ 68%]
test_polynomial.py::test_ShiftCoeffs PASSED                                                                                [ 71%]
test_projection.py::test_tangent_plane_projection_roundtrip PASSED                                                               [ 75%]
test_projection.py::test_project_to_tangent_plane PASSED                                                                         [ 78%]
test_projection.py::test_deproject_from_tangent_plane PASSED                                                                     [ 81%]
test_rotations.py::test_attitude PASSED                                                                                [ 84%]
test_rotations.py::test_attitude_matrix PASSED                                                                                [ 87%]
test_rotations.py::test_sky_to_tel PASSED                                                                                [ 90%]
test_rotations.py::test_axial_rotation PASSED                                                                                [ 93%]
test_rotations.py::test_unit_vector_from_cartesian PASSED                                                                        [ 96%]
test_tools.py::test_jwst_fgs_to_fgs_matrix PASSED                                                                                [100%]
========================================================= 32 passed in 30.31s ==========================================================


notes scrollbars visible all the time

this is how it looks on windows 11 after 62d887af06697051a849de55e9ef8f35075c01dc

I was hoping that using overflow-auto would make those not show up unless they were necessary. Ugh. How annoying. Scrollbars are the worst.

I guess we had some overflow-scroll in there. Had to add overflow-x-hidden in there as well because the presence of the scrollbar on the y axis makes it necessary I guess. Ugh.

you can add tailwind-scrollbar to make scroll bars look better with scrollbar-thin scrollbar-thumb-scrollbar like you do on kcdshop

I'm not 100% certain changing the styling of the scrollbar is a great idea. I wouldn't want it to be the default in the Epic Stack. I'm just annoyed that it appears at all. I wish everyone just did what mobile/macOS does and hid the scrollbar. 🤷♂


Question about setting pad token

Hi, may I know how to set the pad token?
In the previous version of code, it was set as [32006]. I checked that in LLaMA token files, 32006 isnot used yet. Can I use any num not used before?

The original [PAD] is not working, it will raise an error when converting None to torch.int.

Hi, sorry for the confusion. I have refactored the preprocessing code - you can see the latest version of preprocess_data_supervised.py and preprocess_data_unsupervised.py where the special tokens will be added into the tokenizer.


Added support for dot net core app

Hi, I want this awesome library to be used in .NET Core App, AWS Lambda on .NET Core. I've added simple .xproj and project.json to cover this request.
Will you please check this?
I've made dummy NuGet Package for test it works on AWS Lambda. Plase see for a reference and I will remove it when you have merged.
https://www.nuget.org/packages/Chatwork.Service.Test/
Best,

I've removed Test package from NuGet.
https://www.nuget.org/packages/Chatwork.Service.Test/

I’ll release after I add some additional modification as v0.5.0, which is  corresponding to only .NET Standard

releaed https://www.nuget.org/packages/Chatwork.Api/0.5.0


MQTT error [-12]: No more messages can be buffered

Hi All,
I write a easy script  trying to publish a 1MB txt file to the specific topic that connected with broker.
But I met the error following.
[ WARN] [1696218984.040646955]: Publishing ROS message type information to MQTT topic 'mqtt_client/ros_msg_type/pingpong/ros' failed: MQTT error [-12]: No more messages can be buffered
[ WARN] [1696218984.041366993]: Publishing ROS message type information to MQTT topic 'pingpong/ros' failed: MQTT error [-12]: No more messages can be buffered

How to increase the buffer size?

Before increasing the buffer size, I would recommend to find out why the buffer is not sufficient. Possibly, you are publishing more data than your system can handle, and increasing the buffer size will only lead to a delay of the same warning, but it will not solve it, because the buffer will be full just a little later.
At what frequency are you publishing the 1 MB data? Maybe you can try to decrease this frequency. If you don't necessarily need to publish 1 MB, but a smaller amount of data would also suffice, you could also try this.


Changes to loris image server for Prismic

On 21st of October Prismic will be turning on its new image optimisation service.
We will need to point our loris server to a new url in order for the site to continue serving images correctly.
https://user-guides.prismic.io/en/articles/3309829-image-optimization-imgix-integration

@pollecuttn Has this one been done?

@jennpb Essentially yes, we didn't end up changing loris, but instead made changes to use Prismic's new imgix service - which went live on Monday 28th


Corrupting data written to remote storage in case sample_age_limit is hit

What did you do?
We've started experiencing data corruption since we have started using remote_write.queue_config.sample_age_limit. We want to drop old samples after our Disaster recovery tests, in order to make sure we see fresh data as soon as possible (and we do not care much about samples scraped during the test itself). After these tests (which is basically the only time when sample_age_limit applies as we try to make sure we do not hit it during normal operation) we have seen unexpected counter resets as well as new, unexpected timeseries.
What did you expect to see?
Hitting sample_age_limit should only drop old data.
What did you see instead? Under which circumstances?
Our production setup is Prometheus with remote write directed towards Mimir cluster. In case when remote write endpoint is not accessible for more than sample_age_limit, we have seen corruptions in data ingested to remote storage. In both cases, just 2-3 samples just after remote write endpoint resumes its operation, and Prometheus drops old data and starts ingesting again.
So far we have notices two cases:

unexpected samples gets appended to an existing timeseries. Timestamp does not align with our scrape_interval, and value also does not align the timeseries. It probably happens to any metric type, but we have noticed this only with counters as the "fake" values are interpreted as a counter reset, causing huge spikes in our graphs.
new timeseries is created, with just a few samples just after the remote_write resume to ingest data to remote storage just like in the previous case. We have noticed it for cases which are clearly nonsense. It seems that existing series get mixed, like in this case when we tested it with Prometheus holding only its own exposed metrics and node_exporter - go_gc_duration_seconds_count{cluster="local-test", instance="localhost:9100", job="node-exporter", name="systemd-networkd.service", state="activating", type="notify-reload"}

The above we have been able to reproduce in setup with localy running Prometheus binary with configured remote_write towards our staging Mimir cluster. The outage have been simulated by iptables -I OUTPUT -d __IP__ -j DROP.
We have also tried to reproduce it in setup with two Prometheis with one serving as a remote_write receiver (see the attached docker-compose). In this scenario, we haven't seen any corrupted data in the receiving Prometheus, but we are getting log complaining about corrupted data:
System information
Linux 6.5.0-27-generic x86_64
Prometheus version
prometheus, version 2.50.1 (branch: HEAD, revision: 8c9b0285360a0b6288d76214a75ce3025bce4050)
  build user:       root@6213bb3ee580
  build date:       20240226-11:36:26
  go version:       go1.21.7
  platform:         linux/amd64
  tags:             netgo,builtinassets,stringlabels

Prometheus configuration file
global:
        scrape_interval: 30s
        scrape_timeout: 10s
        scrape_protocols:
        - OpenMetricsText1.0.0
        - OpenMetricsText0.0.1
        - PrometheusText0.0.4
        evaluation_interval: 30s
        external_labels:
          __replica__: prometheus-local-test-0
          cluster: local-test
      scrape_configs:
      - job_name: prometheus-scif-monitoring
        honor_timestamps: false
        track_timestamps_staleness: false
        scrape_interval: 30s
        scrape_timeout: 10s
        scrape_protocols:
        - OpenMetricsText1.0.0
        - OpenMetricsText0.0.1
        - PrometheusText0.0.4
        metrics_path: /metrics
        scheme: http
        enable_compression: false
        follow_redirects: false
        enable_http2: false
        static_configs:
        - targets:
          - localhost:9090
      - job_name: node-exporter
        honor_timestamps: false
        track_timestamps_staleness: false
        scrape_interval: 5s
        scrape_timeout: 1s
        scrape_protocols:
        - OpenMetricsText1.0.0
        - OpenMetricsText0.0.1
        - PrometheusText0.0.4
        scheme: http
        enable_compression: false
        follow_redirects: false
        enable_http2: false
        metrics_path: /metrics
        static_configs:
        - targets:
          - node-exporter:9100
      remote_write:
      - url: http://receive-prometheus:9090/api/v1/write
        remote_timeout: 12s
        follow_redirects: true
        enable_http2: true
        queue_config:
          capacity: 100
          max_shards: 3
          min_shards: 12
          batch_send_deadline: 5s
          min_backoff: 30ms
          max_backoff: 5s
          sample_age_limit: 1m
        metadata_config:
          send: true
          send_interval: 1m
          max_samples_per_send: 100

Alertmanager version
No response
Alertmanager configuration file
No response
Logs
prometheus          | ts=2024-04-23T10:06:18.038Z caller=dedupe.go:112 component=remote level=warn remote_name=dabaca url=http://receive-prometheus:9090/api/v1/write msg="Failed to send batch, retrying" err="Post \"http://receive-prometheus:9090/api/v1/write\": context deadline exceeded"
prometheus          | ts=2024-04-23T10:07:26.043Z caller=dedupe.go:112 component=remote level=warn remote_name=dabaca url=http://receive-prometheus:9090/api/v1/write msg="Failed to send batch, retrying" err="Post \"http://receive-prometheus:9090/api/v1/write\": context deadline exceeded"
prometheus          | ts=2024-04-23T10:08:34.050Z caller=dedupe.go:112 component=remote level=warn remote_name=dabaca url=http://receive-prometheus:9090/api/v1/write msg="Failed to send batch, retrying" err="Post \"http://receive-prometheus:9090/api/v1/write\": context deadline exceeded"
prometheus          | ts=2024-04-23T10:09:11.336Z caller=dedupe.go:112 component=remote level=info remote_name=dabaca url=http://receive-prometheus:9090/api/v1/write msg="Remote storage resharding" from=12 to=3
receive-prometheus  | ts=2024-04-23T10:09:11.998Z caller=write_handler.go:77 level=error component=web msg="Error appending remote write" err="label name \"job\" is not unique: invalid sample"
receive-prometheus  | ts=2024-04-23T10:09:11.998Z caller=write_handler.go:77 level=error component=web msg="Error appending remote write" err="label name \"job\" is not unique: invalid sample"
prometheus          | ts=2024-04-23T10:09:12.029Z caller=dedupe.go:112 component=remote level=warn remote_name=dabaca url=http://receive-prometheus:9090/api/v1/write msg="Failed to send batch, retrying" err="server returned HTTP status 500 Internal Server Error: label name \"job\" is not unique: invalid sample"
receive-prometheus  | ts=2024-04-23T10:09:12.035Z caller=write_handler.go:134 level=error component=web msg="Out of order sample from remote write" err="duplicate sample for timestamp" series="{__name__=\"go_gc_duration_seconds\", __replica__=\"prometheus-local-test-0\", cluster=\"local-test\", instance=\"node-exporter:9100\", job=\"node-exporter\"}" timestamp=1713866946725
receive-prometheus  | ts=2024-04-23T10:09:12.035Z caller=write_handler.go:77 level=error component=web msg="Error appending remote write" err="label name \"job\" is not unique: invalid sample"
prometheus          | ts=2024-04-23T10:09:12.035Z caller=dedupe.go:112 component=remote level=error remote_name=dabaca url=http://receive-prometheus:9090/api/v1/write msg="non-recoverable error" count=2000 exemplarCount=0 err="server returned HTTP status 400 Bad Request: duplicate sample for timestamp"

@marctc haven't you experienced similar issues? You might have the context as author of this feature 🙏

Attempt to fix this https://github.com/prometheus/prometheus/pull/14078

Here is a PR which reproduces the bug https://github.com/prometheus/prometheus/pull/14157

@cstyan Last version was cutted just a few days ago. Do you think we can expect a fix/patch version to be released with the fix, or it won't be released until next minor (2.54.0)?


canary builds failing in master

Every time we upload the canary binaries to Azure, it's failing with the following:
+ az storage blob upload-batch --source _dist/ --destination draft --pattern *.tar.gz*
ERROR:
HTTPSConnectionPool

Perhaps we just need to bump the az CLI version in deis/jenkins-node?

dropped an issue at azure-cli to see if they know any good debugging tips: https://github.com/Azure/azure-cli/issues/4223

Yep, that looks like the same issue. Hopefully deis/jenkins-node#21 fixed it for draft too.

Just waiting on a job I kicked off on master to see if it's been fixed by that ticket. Thank you for indirectly fixing this, @mboersma! 😀

Yep, this fixed the issue.


Fix merge issues #12

@shivbijlani,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@kpanwar is added to the review. #Closed

@rohit is added to the review. #Closed

@rohitnarula7176 is added to the review. #Closed

ping @rohitnarula7176


We may limit the background map for the location where we have data for, in this case  Rwanda only?

2 comments related to this aspect

the current prototype provides maps for the 3 countries, by selecting the relevant country (in related maps) the aim is to zoom to that country
in cases you may want to zoom out to a wider extent to investigate cross border phenomena?