Last module tech improvements for v4

@Progi1984 Thanks ! Now we have to go through QA validation 😄

Good work @Progi1984! Just a couple things need fixing.
Also, in the future, please try and write meaningful commit messages:

@eternoendless Hi, Could you review this PR, please ?

@PierreRambaud I just come to push your modifications.

@eternoendless I just pushed your asked modifications.


hydra: 2024-10-24 -> 2024-11-25

Moves from an autotools build system to meson.
https://github.com/NixOS/hydra/commit/182a48c9fbcd6e6063bd6166c314174a8e79294c
(Still running the build/tests on my machine, if anything happens I'll update here and otherwise it's probably good). Build is already good but tests are currently running.
A test failed... Not sure what's up with that.
Continuation and adaptation of: https://github.com/NixOS/nixpkgs/pull/356391
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I've updated my original PR: https://github.com/NixOS/nixpkgs/pull/356391.

Ill test that one out


Show current file feature

Git package had a very convenient feature: "show current file". It's just like GitSavvy's "log current file", but instead of taking you to full commit diff, it just opens current file at chosen revision. It helps you see how a particular file looked in the past, and manually bring back some code. I don't see an equivalent in GitSavvy, would be awesome to have it. That's pretty much the only thing I'm missing from Git.

It shouldn't be difficult to implement as described.  I've also considered a view where you can walk back in time for a particular file.
For example, you open the palette, type something like git: show file at..., select a revision, and the view pops up.  This sounds like basically what you've described.  However, at that point, you could then hit maybe Super+Left, and the view would change to display the revision immediately before the visible one.
Thoughts @maxim?

@divmain This walking sounds super convenient (which is what I love about GitSavvy, you just keep taking things a step or two further). Imho, it's such a clean addition that it doesn't even have to be done in 1st iteration of this feature, can be added later, but yes, definitely would instause it.

I would give default key combo a bit more thought however. Super+Left and some other similar bindings are often taken, but say my Ctrl+Alt+Left is available.

Hmm, I think Ctrl+Alt+Left may effect the screen orientation in Windows 7 and later.  How about:

Ctrl+Shift+Left - walk back in time (Windows)
Ctrl+Shift+Right - walk forward in time (Windows)
Super+Shift+Left - walk back in time (Linux/OS X)
Super+Shift+Right - walk forward in time (Linux/OS X)

Problem is, you still want to select/copy/navigate the text in that file, and Super+Left/Right is used to jump to beginning/end of line. Holding shift does the same + selection. So the advantage of Ctrl+Alt is that at least it's doesn't seem to be bound to any standard editor functions, and these keys would still be configurable.

We need more modifier keys!  Maybe left/right keys aren't the right thing to use here, even though they're the most obvious.

Yeah, it's hard to pick the keys. Also it's complicated by the the fact that even though the file is non-editable, you still wouldn't want to restrict navigation in it, including for people like myself who use Vintage/Vintageous (vim simulation).

I second this, especially with the walking (next/prev) feature.
How about this for keyboard shortcuts? Ctrl+super+alt as modifiers, and dot and comma as next/prev (or vice versa, whichever makes the most sense).
These keybindings would then be similar to the inline diff view where dot and comma is used to walk through the hunks.

:+1: for the feature, :+1: for using dot/comma to mimic inline diff

Seems like an awesome idea! +1

I love dot/comma idea, but it's best to avoid all 3 modifiers, very inconvenient. Ideal for me would be Ctrl+Super+, (no alt)

It helps you see how a particular file looked in the past, and manually bring back some code.

What exactly would that workflow look like?

pop open file at revision 1234
page forward/backwards thru history
copy stuff
close tab
now we're back to the editable file
paste

Or something else?

@yyyc514 exactly. Also if you're refactoring something, and in the process lost something, this is a great UI to quickly refer to what the logic should've been from before refactor, so you can reproduce it differently in the refactored version.

What's the best way to do this and preserve history across renames?  git log --follow can follow the history for a file but git show hash:file doesn't work if the file name does not match the exact name of the file as of the hash you passed in.

That's a good question. I believe the old sublime Git package (which has this feature) doesn't follow files across renames. Would be cool if we could find a way to do it.

Another small detail that could be useful - when walking back-and-forth across revisions, perhaps we should try to preserve the scroll position. The code won't be where it was, and if the scroll is beyond the limit of last revision - we'd resort to just scrolling to the bottom, but imo it's better than not doing it.

That would be a neat trick but probably pretty hard to do without a lot of extra logic (stuff that's already built into things like git blame, etc).

A git blame walker could be a lot more powerful than a git log walker, but you'd be limited to jumping to commits that had some remnants existing in the current revision of the file.

@maxim, preserving scroll/cursor position should definitely be do-able and will be included.
@yyyc514, I've had the same thought about blame.  Once this history-walker feature lands, a keyboard shortcut could be added to the blame view to take you to the revision at that time.
In my ideal world, I would see an inline-diff highlighted file as I walked back in time, showing the parts of the file that changed between the revision I'm viewing and its parent.  But considering the complexity, I think that is over-reaching for a v1, and I'll probably spin that off into another issue to revisit some day.

preserving scroll/cursor position is 100% do-able and will be included.

Neat, but how do you get that information without git blame?  A line could move 1000 lines between commits... I know git blame (the version meant to be parsed) has all that info but didn't think you would get that granular with just commits - without rebuilding all that line counting code yourself.

In my ideal world, I would see an inline-diff highlighted file as I walked back in time, showing the parts of the file that changed between the revision I'm viewing and its parent.

That would be interesting.  What I typically want to do is walk a single line back thru it's history inside git blame... so I'm seeing the files as they stood and who did what.  I can more about what the file looks like at a single revision than the diff... and if I want the diff it's only a keystroke away.  I'll make an issue for what I have in mind.

From #276:

I think it would be useful for chain like this:
show commit > open file > show log of this file
Open file works from DIFF view by 'o' shortkey but doesn't work from COMMIT view.

This sub-feature should be included as part of this effort.  For a walk through history, we'll need an show_file_at_commit command.  To "open file" as suggested by @dlnsk, we'll need this functionality - the file doesn't necessarily still exist at HEAD.

Note to self:
git log --reverse --ancestry-path COMMIT_BEING_VIEWED...HEAD

And another one feature request:
Will be cool if some shortcut (maybe Ctrl+R) on DIFF/COMMIT open popup with list of files changed in it with the ability to go to this part of diff.

the git: log current file and git: graph current file feature on "master" branch provide a partial solution to this issue.

Was the idea of walking through the history and seeing the (w)diff's for a given file or the repo ever done? I can't figure out how to do it.


[KED-1487] kedro-viz does not open the given host (simple fix)

Description
I was browsing through the implementation of the viz server and noticed that the host variable from the cli does not get passed to webbrowser on line 347.
kedro_viz/server.py#L347

Hi @WaylonWalker thank you for reporting! We will log this and fix it later :)

Thanks Waylon, this is now fixed! It was actually intended behaviour, but you're right that it wasn't easy to tell from the code. Hoping now it's a bit clearer!


Support VS 2017

Maybe we can get this pull request merged: #11

+1.  Please add this.

@sneal ^ can someone please merge @taliesins ' changes?

+1

hey yo, that'd be cool

/
Hi there!
Thanks for taking the time to submit an issue.
We would happily accept a pull request to resolve this issue. Please don't hesitate to ask if you need help or guidance on submitting!
If you need help or wish to discuss the issue, please join the Chef Community Slack and look for the #sous-chefs channel.
Thanks,
Sous-Chefs


Name Scope Automatic Handling According to the Model Architectures blocks

System information

TensorFlow version (you are using):
Are you willing to contribute it (Yes/No):
Yes
Describe the feature and the current behavior/state.
Tensorflow must be able to give name scopes more logically according to the architecture being built and automatically. Also, must be able to update the names automatically according to the
Architecture without the dev having to explicity name the things (this should be optional).

Today it only automatically adds numbers sequentially to name/var scope when it is identical
to any other in the collections and you dont add '/' to it
Will this change the current api? How?
Add a Name/Var Scope handler.
This class/template must be used to implement logic of names according to the architecture block connection. E.G. if a block is just the same from the other in the sequence them it must be named as if is a deep part of the same architecture blocks. If it is a ramification of the block given in a sequence but the same arch them he must be named with another tag.
When duplicating some block to architectonic use, E.G. if you need to frame your data or feature, them each frame must have an coeherent name space block, like the today ordimatlicly done for repeated name space block, but this must be automaticly done for identical built blocks of the model, without the need to explicity code it.
Names must be given as unique ID according to te input-output architecture connection, if it has the same IO from previous Block in the sequence, then each Input-ArchBlock-Output that is IDentical must have the same name with the appropriated tag for deepness in the sequence of blocks.
Somethings still to be cleared, like if you have a sequence of CNN of deepness, say 100, then many of them will have same IO arch type (name), but they must not be enclosed in a name scope according to IO, since it obviously has the same IO pattern.
Who will benefit with this feature?
Much more self contained and manageable architectonic blocks, idenpendent of its Variable parameters configuration. This will rapid increase how we search for relevant new Neural Networks architecture, since it is a management tools as much as a vizualization tool and a graph construction tool.
Any Other info.
Obs: These Features could be something for the future in Autograph module, if it still dosnt do it

The tracker isnt tagging as feature request as it should.

First proposal of simple op blocks tracking through ultrametric space ( only some sketches, lemme know if you cant figure anything of this).
https://github.com/Uiuran/Biological-Images-Datasets/blob/master/drawing/feature.jpg

Following the proposal, i would implement an auto-tracking of names and updating to new names with a 3-adic ultrametric space in which each triple ramification inside an name consists of: Ops,Inner-Names Dict and Dependency Edges.
Inner-Names Dict points to new 3-adic trees with the same property
In the leaves will always be an Op or None (that is, no Dependency or No Op or No Inner name of any short for this triple).
This can be implemented through linked tables and with Ids being an hashable consisting of an Distance or Ordering Number and a Leave Number.

Small update here, in my actual code iam doing
graph0 = tf.Graph()
with graph0.as_default():
  with tf.variable_scope('ok'):
    v = tf.Variable(-1.0,name='var')
    a = tf.abs(v)

tf.reset_default_graph()
graph = tf.Graph()
with graph.as_default():
  tf.graph_util.import_graph_def(graph0.as_graph_def(),name='IGWT')
  for op in graph.get_operations():
    print(op.name)

For var space redefinition. That is, indeed iam cleaning working space and restarting the graph as a new block, however this would take too much time for immense graphs, in this feature the better way i think is to implement a new function in VarScope Class to directly change the scopes of the graph variables.

@Uiuran Thanks for the suggestion! I think this could be an interesting idea; it would be worth elaborating on the terminology a bit. More examples are always better. Also, have you looked at the name scoping done for instance by Keras?
I recommend reading the docs on the TF RFC process and c=preparing one according to that process: https://github.com/tensorflow/community/blob/master/governance/TF-RFCs.md

Iam looking in that direction too, thank you for the hint, update you asap.
On Wed, Jul 31, 2019 at 10:30 AM Dan Moldovan<EMAIL_ADDRESS>wrote:

@Uiuran https://github.com/Uiuran Thanks for the suggestion! I think
this could be an interesting idea; it would be worth elaborating on the
terminology a bit. More examples are always better. Also, have you looked
at the name scoping done for instance by Keras?
I recommend reading the docs on the TF RFC process and c=preparing one
according to that process:
https://github.com/tensorflow/community/blob/master/governance/TF-RFCs.md
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/issues/30991?email_source=notifications&email_token=AAOOCX6EYT7LTDMDAYVTDGLQCGHZFA5CNFSM4IGQVW62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3HHIZY#issuecomment-516846695,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOOCX7N26WUJUOLAN2JYBTQCGHZFANCNFSM4IGQVW6Q
.

Update:
In my view we fundamentally must look in the following directions
1- Name editable Variable, in the API. For backward compatibility seems that we would need a ner Variable Version.
2- Module that use the collections with ('__varscope',), rename it properly according to the three mentioned above (today it only gives value 1 for the outer-most variable scopes and value 0 for all inner names that was defined by the user). Then one use this lookup engine to change ('__variable_store',) names.

plus: would not be better to standardize the names to variable or var in these keys  ('__var_store',)?

Hi,
Thank you for opening this issue. Since this issue has been open for a long time, the code/debug information for this issue may not be relevant with the current state of the code base.
The Tensorflow team is constantly improving the framework by fixing bugs and adding new features. We suggest you try the latest TensorFlow version with the latest compatible hardware configuration which could potentially resolve the issue. If you are still facing the issue, please create a new GitHub issue with your latest findings, with all the debugging information which could help us investigate.
Please follow the release notes to stay up to date with the latest developments which are happening in the Tensorflow space.


Implement checking for whether a parameter is potentially used in a command

This issue has been resolved by the method: Command#isModification.


Allow to exclude import statements when using vim.lsp.buf.references()

Describe the feature
It would be nice if there was an option to exclude all the import statements when referencing a symbol. Sometimes it might get quite noisy.
https://user-images.githubusercontent.com/65810468/190855458-a563b0fc-086a-4930-8e7c-c17b2e0b2f1f.mov
Potential ways to implement
I think having shortcuts for finding references both with and without import statements would be useful, so I guess having it as a parameter to a function rather than a more static setting like excludedPackages would be a better choice.
I'd be happy to try to do it myself, but I'd need some guidance on how to approach it.

I was told on discord that it might be a good idea to move this issue to metals itself as it's not a vim specific problem. If that's the case(meaning it should be addressed in metals), then I'll go ahead and do so.


Add instructions to make minikube's docker env available during 'make docker_build'

Minikube uses a separate docker daemon from the normal system docker
daemon, so you need to tell your shell how to access the minikube docker
daemon. Otherwise when the Task runs it fails immediately because it
tries to pull from Dockerhub.
This also removes a redundant "to" in the following sentence.

You have to sign the CLA

Also definitely join our slack, can help in case of any problems

Thanks for the approval, and the warm welcome! I'm working on getting approval from my company to sign the CLA.

@kumare3 I just signed the CLA, please let me know if there's anything else you need from me on this.


iOS 8.4 - Safari, Text Field don't have the correct visual effect

I'm testing the effects on mobile devices for a hybrid application and I could see that in iOS 8.4 the effect of the Text Field is rather different than the one in Chrome.

Needs confirmation and further triage from someone with access to an 8.4 device/emulator to assess with.
While we are waiting on that, any way you could provide a description of what exactly is out of alignment? Thanks.

@Garbee I record a video.
https://www.youtube.com/watch?v=F4SEZ7NKrDc&feature=youtu.be

I'm not noticing anything off in the video. Looks right to me.

The animation on iOS suffers some performance issues. Sometimes there are rendering lags which may skip part of the animation, making it look inconsistent with repetition.
Both Polymer and Angular implementations of material design have similar known issues on iOS.

Might be an upstream WebKit bug then.

Well, a lot of IE6-IE9 problems are technically 'upstream bugs', but they never got fixed. Apple smelling like the new Microsoft recently, the library might need some hacks around this.

@jimbojetlag I never said we shouldn't address it somehow if that is the case. I simply stated if multiple implementations have the same problem then it may not be a direct issue with MDL. Further assessment needs to be done before any judgement is made on whos fault it is and how to address the fix if any.

Our textfields are due to have a performance overhaul, anyways. We are aware that there are issues.
Thanks for the video, @jimbojetlag. I am waiting for my iPhone test device and I’ll start to try to replicate.


Working with markdown pages (.md)

If anyone is wondering how to translate pages as .md files, here is a solution (example with a privacy policy page) :

Create where you want the .md files, located in their respective language folders. E.g. :

(you can use any folder structure as long as the files have the same name and are located in their language folder.)
Create an astro page that will be the entry point (e.g. privacy-policy.astro)
In this page, make use of the Astro.glob function to retreive the .md page content :

---
import i18next, { t, changeLanguage } from "i18next";
import { localizePath } from "astro-i18next";
changeLanguage("fr");
const pages = await Astro.glob("../i18n/**/privacy-policy.md");
let Content;
for (const page of pages) {
    if (page.file.includes(`/${i18next.language}/`))
        Content = page.Content;
}
---

Now you can make use of the <Content /> into your .astro file

<Layout title={t("menu.policy")} pageUrl={localizePath("/mentions-legales")}>
	<Content />
</Layout>

I don't get it, you didn't put the translations in the public folder?

What are the json files in the i18n folder? Are they not translations?

Yes they are. My personal preference is to put files used as sources at build time in /src rather than in /public.


Get game schedule for season

Currently, there are a couple of methods to get the current day's schedule and by date. There are a few additional endpoints that the NHL API exposes for getting schedules. In particular I'm looking to use the endpoint that gets the schedule for a particular season in order to know what games to download for that season.

Hey @andersme ,
Sure I can build that out for you for 1.7.0
I will get that into the pull request coming up in the coming days!
Thanks again

https://github.com/Afischbacher/Nhl.Api/pull/24/files

Released v1.70! So I will close this issue :) 👍


Missing adversarial loss

Hey, I think I found a bug in your adversarial loss of both models (RecycleGAN and ReCycleGAN). The adversarial loss for D is calculated on G_y(x_t-i), P_y(G_y(x_t-i)) and P_y(y_t-i), but the loss for G/P is only calculated on G_y(x_t-i) and P_y(G_y(x_t-i)). I.e. P does not learn from P_y(y_t-i), since the GAN loss for pred_A2 and pred_B2 is missing in backward_G().
If this is in fact a bug, I can quickly fix it and make a pull request if you want. I already fixed it in my own implementation, but I have not compared it to the original version yet.

You are correct.  I used the reconstruction loss only for training P_y and P_x since we have "ground-truth" from temporal ordering. I added an adversarial loss when using P_y and P_x while going in the spatiotemporal cycle (doing the translation). This was done to provide more constraints because we are effectively using the P_y and P_x on a different distribution than they were trained on (we are using P_x and P_y on generated x and y samples respectively but they were trained on real x and y samples).
It is true that having additional GAN loss for training P_y and P_x could be useful in training a better predictor. We can make this as a separate model and that would also help in studying the use of additional adversarial loss on performance for prediction modules.

Okay, I'll add an option --adversarial_loss_p, which you can set to use the additional adversarial loss for training the prediction module, and make a pull request then.

Hi @aayushbansal @fa9r , thank you for your work! Did you compare the model with adversarial_loss_p to the original model? Which one is better? Thanks!


Null move pruning

Codecov Report
Base: 93.98% // Head: 93.98% // No change to project coverage :thumbsup:

Coverage data is based on head (9b6e163) compared to base (384abc1).
Patch coverage: 100.00% of modified lines in pull request are covered.

:exclamation: Current head 9b6e163 differs from pull request most recent head 91f2dfb. Consider uploading reports for the commit 91f2dfb to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #140   +/-   ##
=======================================
  Coverage   93.98%   93.98%
=======================================
  Files          69       69
  Lines        8259     8259
=======================================
  Hits         7762     7762
  Misses        497      497

Impacted Files
Coverage Δ

search/src/alpha_beta.rs
99.60% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Add prompt that created the image to the image metadata

Sorry about that :-(
Is your feature request related to a problem? Please describe.
Not related to any problem.
Describe the solution you'd like
I was thinking that when I produce a lot of images it would be useful to have the prompt and parameters I used embedded in the image metadata itself so that I can always recreate it as long as I have the image. I know the log file has this information as well but I think to have it with the image would mean it would never get lost.
Describe alternatives you've considered
I thought about using the log file but what if I move the image somewhere else or the log file is deleted.
Additional context
No additional context apart from this repo is amazing!!

Please actually fill out the template above.
Where it says A clear and concise description of what the problem is. Ex. I'm always frustrated when [...],  you are supposed to replace that with useful information. Same for the other items.

Please actually fill out the template above.
Where it says A clear and concise description of what the problem is. Ex. I'm always frustrated when [...], you are supposed to replace that with useful information. Same for the other items.

Sorry about that. I have updated the original text. Thanks again.

The prompt and parameters are already embedded in the image metadata. There's a script which can retrieve them at scripts\ images2prompt.py. This is documented in the readme.

Ahh ok sorry to waste your time. I will be more careful next time. Thanks again.


Use linear mipmap sampling in ToneMapper

Fixes: https://github.com/godotengine/godot/issues/60658
When reorganizing the Tonemapper we accidentally used nearest mipmap sampling for the mipmap sampler, it should be linear as it is in EffectsRD: https://github.com/godotengine/godot/blob/8dfa12cae729258155fbad51ed41f1bb3ad1006a/servers/rendering/renderer_rd/effects_rd.cpp#L2997-L3002
I also renamed default_shader and default_mipmap_shader to default_sampler and default_mipmap_sampler as these are sampler objects and not shaders at all.

Thanks!


It looks like typeaheadjs.css is missing a lot of stuff

See https://github.com/bassjobsen/typeahead.js-bootstrap-css/commit/358993f0e3801b57e2b8257321ee7cf04f6dd1aa, where a bunch of important looking stuff was removed.

+1 Where is the compiled stuff? now I need to make my own version of bootstrap and compile it for this to work

+1 this latest change completely broke this project.

:+1:


How it is implemented in CodeIgniter 3.0?

Someone could provide an example to implement this useful library in CodeIgniter 3.0?

@

Please use StackOverflow for questions like this.


Rename "IDOM" to "ReactPy"

Current Situation
This issue exists to track our rename efforts
Proposed Actions
No response

I'm thinking we 1.0 release IDOM (without the warning) then create an idom branch for posterity. We then execute the rename on main and move the repo. We then release ReactPy (once we're ready) after which we release a 1.0.1 version of IDOM with the warning using the idom branch.

LGMT

We good to release idom 1.0 now you think?

Yep, I'll push a Django-IDOM release as well.


Sanic/Flask client consolidation

As noted in #1205 and #1219, a Sanic client was added; it shares a lot of similarities with the existing Flask client, and I had considered refactoring the two to try to lift out some of the common functionality. I didn't want to do this without talking it down a bit first, as I had some concerns:

Is this even work worth doing? There's common functionality, and I think there's likely some base elements that could be lifted out easily, but do we want the two clients to share a common base? Are there downsides?
Where would this work live? Something like "SanicFlaskBase" is kind of cumbersome and wordy, but I can't think of anything else that's descriptive.
Do other clients also share functionality like this? I'm sure there are similarities, but I'm not yet well versed enough in Raven generally to pick up on 'em.

I'm happy to chunk this out into separate issues if that makes more sense.
(attn: @mitsuhiko)

@ashwoods that's awesome. Lemme know if I can help out at all. Happy to do the needful.

This is implemented in https://github.com/getsentry/sentry-python: Most common functionality is in the base client. There's not a lot of potential for code sharing left.


Add payload creation to the RPC interface

This PR adds support for payload creation via the RPC interface.  The calls are similar to the send transactions, without the requirement for an address or any of the balance checks.
This allows an integrator building transactions via the raw transactions interface to generate the payload via Omni Core.
The internal CreatePayload_function calls are used and the parameters are largely taken from the equivalent calls to send each type of transaction.
Note: this is to compliment calls such as omni_createraw_opreturn where a payload needs to be supplied.

Also, I left in some sanity checks (eg whether a property being used exists etc) - I'm of split minds on whether we should make the payload creation API completely free of state based checks.

Oh, and sorry - completely missed the requirement for this in the PR description...
In a nutshell we need to provide payloads when using the raw transactions interface.  The initial requirement was raised by Tomas & Adam for OmniWallet, where they would like to delegate payload generation to Omni Core as they're using the raw transactions interface.  Additionally this is also useful for the new OmniChest transaction builder - I'm doing payloads in my own library right now but it seems wasteful to duplicate and keep a separate library updated when Omni Core already has payload generation capabilities (they just weren't exposed over RPC until now).
Regarding 0.12, I figure that's not quite there yet and this is something we'd like to run in production ASAP hence the basing on 0.0.10 where we can feel pretty comfortable with the build.
Thanks
Z

Wow, this is awesome!
Will test it throughout the day.

Also, I left in some sanity checks (eg whether a property being used exists etc) - I'm of split minds on whether we should make the payload creation API completely free of state based checks.

I'd prefer having no checks here, given that the raw transaction API is pretty low level and "for advanced users".


Setting Version of Python Function

Expected behavior
Upon getting a deployed function's info using the pulsar-admin tool, the version of the function is not outputted. I'm expecting the version to be outputted.
Actual behavior
No version is outputted of the deployed function. I'm wondering where the version info is pulled from when deploying a pulsar function written in Python and when deployed using the .py file.
Where do I set the version of the pulsar function so that when its deployed, the version number is set in Pulsar for that function?
System configuration
Pulsar version: 2.7.0

I think PIP 50 already give a solution to this issue. Once package management is released, user can define and manage function version by package.
You can also check the pre-released version's document here: http://pulsar.apache.org/docs/en/next/admin-api-packages/


Add a global 20 seconds timeout to middleware requests

https://github.com/ohcnetwork/care/blob/4f6296ac76ceedc0a8c07a83689a3c7fcfe9f2a0/care/utils/assetintegration/base.py#L35-L61
add a settings variable to set timeout for middleware requests
use 20 seconds as defaults

@sainak I'll like to work on this issue

completed in https://github.com/ohcnetwork/care/pull/2434


Test set download

Hey!
The link to download the DocGenome-TestSet-DocQA does not work. I get 404 error on HF. Could you please fix the issue?
Many thanks in advance! 😊

@esborisova Hi, DocGenome-TestSet-DocQA is now available at here

@BOBrown Thanks a lot!
Now when I had a look at the test set, I am wondering where to find annotations for 3K Table-LaTeX pairs as stated in the paper. I only see annotations for the QA task. Am I missing something?


Testnet: Update genesis and bump currently active tag

On 2022-06-13, testnet will be reset with a new genesis and the currently active tag bumped to 4.1.1-1 (and image tag to 4.1.1-1_0).

Image build (currently running): https://github.com/bisgardo/concordium-docker/runs/6858294915?check_suite_focus=true


Picture orientation problem

hello ～I have a question
Data picture, do I need to keep the human body facing up? For example, head down, legs up
thanks

Good question.
According to the experimental results, I think it is yes.
The results on persons heading up and feet down look good on the validation set. While, my trained blazepose cannot obtain a good result for those persons with strange poses.
Thus, it is a good idea if all the persons are in a similar direction (not exactly the same).


Update docs for v0.16.6

I'm not sure that we actually want to update the package docs for anything besides @pulumi/pulumi. Thoughs @lukehoban @ellismg ?

I think you are correct about just updating @pulumi/pulumi docs.
I am 87% sure that the trailing newline in latest-version is not going to cause problems but we have never done it before, so do you mind removing it until we can actually test how the bash script handles it?
LGTM otherwise.


Toggle to control set in BuildInitialPlacement

Need control over this to reset placements in m3em

Coverage increased (+0.009%) to 90.819% when pulling 7740e3866c200b006856b595cddce574137cc30e on prateek/placement-set-toggle into 41253a12011658b9a20f91bdd245b79e8c0f5800 on master.

spoke to @cw9, we're going to instead add the ability to delete existing placements


buildroot: Add kernel patch and config changes for liteeth driver

Signed-off-by: David Shah<EMAIL_ADDRESS>

Please see https://github.com/enjoy-digital/linux-on-litex-vexriscv/pull/18


Document what happens when tags are deleted and recreated

Ultimately... does it matter?
Deleting a tag

Make a commit on Fairyland, which is a Dockstore.yml mediated collection of "workflows"
Make a release on GitHub called "semantic versioning is fake"
Import into Terra and select semantic-versioning-is-fake to ensure it is new default, see figure A
Make another commit on Fairyland
Delete the GitHub release, but do not undo any commit history

Observations

Dockstore's URL for the deleted tag now redirects to main
Terra throws an error when selecting the workflow, see figs B and C. Contrary to what the error message says, you might be able to select main from the dropdown menu, but let's not do that right now, let's keep the "default" to the nonexisting tag.

All of this is more or less what you would expect and, in my eyes, acceptable behavior.
Figure A

Figure B

Figure C

Recreating a tag

Make a new commit on Fairyland
Create a release with the same tag as the one you deleted (figure D)
Go back into Terra
😬

Observations

The above Dockstore URL for the deleted commit, which previously redirected to main once the tag was deleted, is now valid again
The workflow on Terra is now valid again, but potentially totally different from what it was at time of import (fig E)

Figure D

Figure E

┆Issue is synchronized with this Jira Story
┆friendlyId: DOCK-2062
┆sprint: Backlog
┆taskType: Story

Agreed, not really an issue when snapshots https://docs.dockstore.org/en/stable/advanced-topics/snapshot-and-doi.html are not in play. That said, that experience needs also to be better, see also #4559 or #3211


WKWebview runs fine in iOS 10, freezes in iOS 9

Here is my access-origin and allow-navigation tag
<access origin="*" /> <allow-navigation href="*" />
What else do I need to do to make WKWebview work?
my ionic info:
`

Cordova CLI: 6.3.1
Gulp version:  CLI version 3.9.1
Gulp local:   Local version 3.9.1
Ionic Framework Version: 1.2.4-nightly-1917
Ionic CLI Version: 2.1.1
Ionic App Lib Version: 2.1.1
ios-deploy version: 1.9.2
ios-sim version: Not installed
OS: Mac OS X El Capitan
Node Version: v9.6.1
Xcode version: Xcode 9.3 Build version 9Q127n

`
cordova plugins list:
`

cordova-media-with-compression 2.1.1 "Media With Compression: Alpha Software Edition"
cordova-plugin-app-version 0.1.9 "AppVersion"
cordova-plugin-camera 2.3.1 "Camera"
cordova-plugin-compat 1.2.0 "Compat"
cordova-plugin-console 1.0.7 "Console"
cordova-plugin-device 1.1.6 "Device"
cordova-plugin-disable-ios11-statusbar 1.0.0 "cordova-plugin-disable-ios11-statusbar"
cordova-plugin-file 4.3.3 "File"
cordova-plugin-file-opener2 2.0.19 "File Opener2"
cordova-plugin-file-transfer 1.6.3 "File Transfer"
cordova-plugin-inappbrowser 1.7.1 "InAppBrowser"
cordova-plugin-ionic-webview 2.1.0 "cordova-plugin-ionic-webview"
cordova-plugin-jcore 1.1.10 "JCore"
cordova-plugin-migrate-localstorage 0.0.2 "Migrate WebView Data"
cordova-plugin-network-information 1.3.1 "Network Information"
cordova-plugin-screen-orientation 2.0.2 "Screen Orientation"
cordova-plugin-splashscreen 4.0.3 "Splashscreen"
cordova-plugin-statusbar 2.2.3 "StatusBar"
cordova-plugin-whitelist 1.3.2 "Whitelist"
cordova-plugin-x-toast 2.6.0 "Toast"
ionic-plugin-keyboard 2.2.1 "Keyboard"
jpush-phonegap-plugin 3.2.11 "JPush"

`
I noticed an error "DOM Exception 18: An attempt was made to break through the security policy of the user agent."

Please help!

Hi,
The version 2+ of this plugin require IOS10+, if you want to run for IOS9 you need to downgrade to version  1.


question: not binary but score

hi,  the paper mention that the Stanford Sentiment Treebank is a binary single-sentence classification task, but I want to output the score of every sentence，not 0 or 1, like  0.11、0.18、0.89..and so on (range from 0 to 1), Does bert have the option to implement such a requirement?
Thanks very much!!!

Would the probability of 1 suffice?
If yes, then you can set do_predict=True to get the "score" (probability of 1) and class (0 or 1)


counter culture on has_many relationship not updating on destroy

Hi there, love this gem, but I'm running into an issue with my has_many relationship that I can't quite figure out. Any help is really appreciated. I have the following:
Idea.rb
has_many :idea_tags, dependent: :destroy
has_many :tags, through: :idea_tags

Tag.rb
has_many :idea_tags, dependent:  :destroy
has_many :ideas, through: :idea_tags

IdeaTag.rb
belongs_to :idea
belongs_to :tag
counter_culture :tag, column_name: "ideas_count"

I find the above works great when adding a tag to an idea. It will update the counter on the Tag model, so @tag.ideas_count increases as it should. However, I find if i remove the tag from the idea, it doesn't decrement the count.
Am I doing something wrong? Should this work as expected? Should the count decrease?

If it's worth noting, that when I run IdeaTag.counter_culture_fix_counts it updates it correctly. I was hoping it could update automatically when a tag is removed from Idea.

Yes, the count should decrease. There's a test for this so I'm confident this works in principle.
Are you deleting these without callbacks? counter_culture can only keep counts up-to-date if callbacks are run, so you have to call .destroy

Thanks Magnus, I think I see what you mean. I was simply doing this to create/update the tags for an Idea:
params[:idea].permit(:title, :summary, :creator, :priority, tag_ids: [])
What you're saying is, I shouldn't do it this way, but instead I have to call a destroy on the IdeaTag model? Appreciate the response!

Hm—that's weird, I don't immediately know why this doesn't work. Perhaps assigning tag_ids directly destroys the IdeaTags without callbacks? I understand why you'd expect this to work, but at the end of the day if Rails decides to do this without callbacks, there's really nothing counter_culture can do to maintain counts. Why don't you try manually managing the IdeaTags here—that could be a good workaround for you.

Hi Magnus, You are right in that the after_destory callback was not being triggered. And definitely, it was a Rails issue not counter_culture, so I appreciate you taking the time to respond - you helped point me in the right direction and find a solution.
I thought I'd update in case anyone else has this issue. Reading through a ton of rails stuff, it seems you have to add the dependent: :destroy to the through association to trigger the callbacks properly. Here is a good summary of the issue: https://github.com/rails/rails/issues/29078. It appears to have been fixed way back in 3.1: https://github.com/rails/rails/issues/1962.
So changing to this helped me ensure that the after_destroy callback was triggered:
has_many :idea_paths   has_many :paths, through: :idea_paths, dependent: :destroy
Thanks for your help!


Implement DATE_DIFF by week

Hi @goccy!
Just fixed in ee6659d2ac7db0bc9613e7924f88ed9c82384df7
Thanks!

LGTM, Thank you !!


update needed for Inkscape version 1.0

Hello,
Thank you for providing this extension for Inkscape users!
This is just to let you know that most 3rd party Inkscape extensions, like this one, probably will not work with the upcoming new Inkscape version, the long-awaited version 1.0.
Here is the info you need to update this extension, so that it will work with 1.0 and future versions.
https://wiki.inkscape.org/wiki/index.php?title=Updating_your_Extension_for_1.0
If you have further questions, you can contact Inkscape developers via mailing lists, forum, or the chatroom.
If you have already updated it, please disregard this message.
All best,
brynn

Thank you for the heads-up, I'm going to look into it.

I've tested with the 1.0 beta AppImage and it worked without problem. I also read the checklist, and didn't find anything that should be problematic.

I've also tried it on Inkscape 1.0 and this extension still worked. I'm using Ubuntu 20.04 btw


Replace java.text.Collater with ICU4C in JSON Collator for Java.

Ideally this ICU4C static library could be used from SQLCipher too.

Close it as the collator is not in this project.

https://github.com/couchbaselabs/couchbase-lite-java-sqlcipher/issues/6


a problem after latest update

Hi Folks ,
I've noticed this in the container log after latest update :
starting: python /src/worker/lean_and_mean.py
Traceback (most recent call last):
File "/src/worker/lean_and_mean.py", line 81, in
asyncio.run(main())
File "/usr/local/lib/python3.9/asyncio/runners.py", line 44, in run
return loop.run_until_complete(main)
File "/usr/local/lib/python3.9/asyncio/base_events.py", line 642, in run_until_complete
return future.result()
File "/src/worker/lean_and_mean.py", line 75, in main
server = await asyncio.start_server(handle, args.host, args.port)
File "/usr/local/lib/python3.9/asyncio/streams.py", line 94, in start_server
return await loop.create_server(factory, host, port, **kwds)
File "/usr/local/lib/python3.9/asyncio/base_events.py", line 1494, in create_server
raise OSError(err.errno, 'error while attempting '
OSError: [Errno 98] error while attempting to bind on address ('<IP_ADDRESS>', 3080): address already in use
I2021-03-24 00:02:53,156 [nwgg_c_2] not in stock
I2021-03-24 00:02:58,837 [nwgg_c_3] not in stock

Sorry guys , False alarm ... reinstalled the code and everything looks good


Fix DLL bundling by using %?RESOURCES

@*INC is not available in latest rakudo versions. This made GTK::Simple impossible to build/install/use on Windows. These changes utilize %?RESOURCES to enable GTK::Simple on Windows to work again.

:+1:


fix: make updates to WP agent DA input variable

Description
Issue: https://github.com/terraform-ibm-modules/terraform-ibm-scc-da/pull/120

Release required?

[ ] No release
[ ] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

/run pipeline

:tada: This PR is included in version 1.10.4 :tada:
The release is available on:

GitHub release
v1.10.4

Your semantic-release bot :package::rocket:


A simple way to graph the FSM

Hi,
I've added a function capable of producing a global FSM graph (as .png). It's dependent on pydot/graphviz, but degrades gracefully if pydot is not present. It might be useful when testing. Further changes can be made (e.g. export the .dot file instead).
Cheers,

Patch request seems to dirty. The management script is not releated to desired functionallity
Django have better support for custom commands, than management function gidden in source file
You have no support for '*' sources and no suppport for None targets

Anyway, thanks for idea and your work. I've created cleaner solution for drawing graphs 67591a6ae2b6859e086bfcb89723853bc44d637f


Need a solid guide on how to add File Types to capture!

Could use a complete list of MIME file types Aria2-Integration extension can recognize as well as the correct syntax to use when editing the list! Wasn't able to add .exe file extension to the 'Include File Type' list. So, need some sort of a guide!

It would be nice to move away from mime types and use extensions, like the Chrome version from Alex Hua
Aria2 For Chrome


Suggestion: Optional Fast Resource Gathering

I won't explain, just leave an example - maybe it will be interesting for someone =3
https://www.youtube.com/watch?v=Wt25i9JNq20&feature=youtu.be
Spawnable:
tS_fnc_collectResources = {
private _box = _this;
private _balloons = [];
private _class = "Land_Balloon_01_air_F";
_box setVectorUp (surfaceNormal (getPos _box));

{
	private _b = _class createVehicle [0,0,0];
	_b attachTo [_box, _x];
	_balloons pushBack _b;
} forEach [
	[0,0,1]
	, [0,0.35,0.7]
	, [0,-0.35,0.7]
	, [0.35,0,0.7]
	, [-0.35,0,0.7]
	, [0,0,1.5]
	, [0,0.5,1.2]
	, [0,-0.5,1.2]
	, [0.5,0,1.2]
	, [-0.5,0,1.2]
];

_box setVelocity [0,0,1];
private _i = 0;

while { getPosATL _box select 2 < 100 } do {
	_box setVelocity [0,0,5 + 0.01*_i];
	sleep 0.25;
};
{ detach _x; deleteVehicle _x; } forEach _balloons;

private _storages = [];
private _dist = 1500;

// Find nearest storage
while { _storages isEqualTo [] } do {
	_storages = nearestObjects [_box ,KP_liberation_storage_buildings,_dist];
	_dist = _dist + 2000;
	sleep 0.1;
};

[_box, _storages select 0,true] call F_crateToStorage;

};

😆
But... no ^^


attention trick implementation

Hey guys!
Inspired by the attention LSTM,
Each time I have 3 input vectors, say x_1, x_2 and x_3.
I wish to first make a linear combination layer_I = a_1_x1+a2_x2+a3*x3
Then I merge this layer with some other sequencial layers.
I wish to learn the a_1 a_2 and a_3
How to do it in keras????
THANKS !!!!!!!!!!!!
with love

Typically the attention is done with a single MLP that maps vectors to scores, then uses those scores in a softmax to get a probability distribution over the vectors.  Finally, you hadamard the probability distribution and initial vectors, sum over the sequence dimension (dimension 1).
here's some code I wrote to do this.
https://gist.github.com/braingineer/27c6f26755794f6544d83dec2dd27bbb
Though, you should definitely read up on attention further.  Bahdanau et al have a great paper on it.

Have a look at this:
https://github.com/philipperemy/keras-simple-attention-mechanism
It's a very simple Hello world attention mechanism but might address your needs!

@braingineer Thanks for your code. Do you have a toy example on how to use it?

@briangineer does your code include bahdanu's attention


Fix Psycopg2 warning

Using this module, I get a warning on startup:
lib/python3.6/site-packages/psycopg2/__init__.py:144: UserWarning: The psycopg2 wheel package will be renamed from release 2.8; in order to keep installing from binary please use "pip install psycopg2-binary" instead. For details see: <http://initd.org/psycopg/docs/install.html#binary-install-from-pypi>.
  """)

This warning can be easily fixed by changing the dependency to psycopg2-binary instead of psycopg2.
Another issue is using pipenv graph, I see the following dependencies which looks different from what I see in the Pipenv file for this project:
django-heroku==0.2.0
  - dj-database-url [required: Any, installed: 0.4.2]
  - django [required: Any, installed: 2.0.2]
    - pytz [required: Any, installed: 2018.3]
  - psycopg2 [required: Any, installed: 2.7.4]
  - whitenoise [required: Any, installed: 3.3.1]

In the Pipenv file, I don't see psycopg2 but I do see gunicorn which is not present above.

What is the status of this issue?

What is the status of this issue?

I seriously start to doubt about Heroku willingness to maintain Django compatibility with Heroku platform, when such an easy fix is still pending, 4 months after...

@ddahan Just created #19 to try to get an answer :)

As suggested in #18, this package should not be using psycopg2-binary and the warning is overzealous in this case. It's unclear what other action is desired here for people to consider this "maintained". psycopg2-binary should only be used when users need to get up and running quickly. django-heroku is meant for production systems, and thus we should keep using psycopg2. If things have changed, or I'm misunderstanding something here, please do let me know.

I agree with @sigmavirus24 on this completely.  What matters for django-heroku package is that this can be deployed on Heroku, and as long as Heroku can build psycopg2 from source (which I believe it can) then this package should stick with the normal source distribution as recommended by psycopg2 itself.

I assume psycopg2-binary provides psycopg2 so if you need to use it for local development can always do that manually.


Broken links due to punctuation

Hi! Thank you for this amazing webapp, it's an indispensable tool for me.
I'm seeing some TOC items receive broken links. Consider this source markdown:
# Hi, @dohliam!

Here's how GitHub renders it. Note the id:

Hi, @dohliam!

Here's how this header should be targeted from a TOC:
* [Hi, @dohliam!](#hi-dohliam)

Here's how tocdown renders it, producing a broken link:
* [Hi, @dohliam!](#hi,-@dohliam!)

Uhm, that's not how GitHub actually renders it, but the anchor in my example is identical to GitHub's.

Whoops, I didn't notice you had already submitted a PR for this, and it looks like a better fix! I'll see if I can merge it

Hmm... after some testing I realized that this fixes most problems, but breaks Unicode links (e.g. for non-ASCII characters). Here is an example of how non-ASCII links render in Github-flavoured markdown (you might have to hover over the anchor link icon to see the non-escaped version of the link).
I was originally going to go with the regex used by marked, which seems simple enough: /[^\w:]/, but this also breaks with non-ASCII.
It looks like there may not be an elegant way of doing this without testing to see which punctuation specifically is removed by Github (or other flavours of markdown). I'm also not sure how Unicode punctuation (curly quotes and em-dashes etc.) are handled. I'll add some of these (as well as your example above) to the test file and we can go from there.
If there were a range of characters that captured approximately !"#$%&'()*+,-./:;<=>?@[\]^_{|}~` that would be ideal, but unfortunately I don't think it will be that easy!

I've added some punctuation tests in the file test.md, and at least some of the results are a bit surprising. For example, in this link, the underscore is not removed as I would have expected. So a marked.js style [^\W] is going to break links as well.
I'm happy to check out an updated PR if you have any ideas!


WIP: enable marketplaceV3 any-evm deploy

/release-pr

/release-pr

/release-pr

/release-pr

/release-pr

/release-pr

/release-pr

couple of errors due to the large throaway deployers on some chains:

polygonZK: unable to apply transaction even for the highest gas limit 30000000: not enough keccak counters to continue the execution

Linea: err: tx data is too large (in bytes) (supplied gas 25010499)

/release-pr


mutating reactor state within reducer method using inout keyword

By mutating the state within the reducer, we're able to remove some boilerplate. For example, in order to update our state, we would have to create a copy of our previous state and mutate the copy and return it. Instead, now we can just mutate state directly without the boilerplate and achieve our same results

I don't agree with you. Core concept of the Unidirectional architectures especially Flux and Redux is mutating states using pure functions. Your PR doing the opposite.

I don't agree with you. Core concept of the Unidirectional architectures especially Flux and Redux is mutating states using pure functions. Your PR doing the opposite.

The reduce method is never called directly and the state is only mutated in one place. Mutation only occurs internally within the reactor.

I don't agree with you. Core concept of the Unidirectional architectures especially Flux and Redux is mutating states using pure functions. Your PR doing the opposite.

The reduce method is never called directly and the state is only mutated in one place. Mutation only occurs internally within the reactor.

Yeah I understand, but I think it's out of the main idea behind the Flux architecture. Flux AS IS leads you to use pure function. As a developer, I want to know, that this is pure.


feat: enhance EnrollmentService.fetchEnrollmentRequests() to filter enrollment requests

- What I did

introduce new param 'enrollmentStatusFilter' in EnrollListRequestParam class
use the above param in EnrollmentService.fetchEnrollmentRequests() to build the command that lists only enrollment requests that match the filter.

- How I did it

EnrollListRequestParam.enrollmentStatusFilter will be used by users to pass the desired enrollment statuses they wish to list.
EnrollmentService.fetchEnrollmentRequests() will use this filter to construct a relevant command which will be passed to the server.

- How to verify it

unit test added, that verifies that appropriate command is generated using the EnrollVerbBuilder and the parsing of response from the server.
Yet to evaluate if a functional test is needed to validate the change

- Description for the changelog

feat: enhance EnrollmentService.fetchEnrollmentRequests() to filter enrollment requests

Making this a draft PR until changes in https://github.com/atsign-foundation/at_libraries/pull/530 and https://github.com/atsign-foundation/at_libraries/pull/536 have been consumed by AtServer and that version of AtServer has been promoted to Prod. This measure is being taken to prevent any backwards compatibility issues.


access: may-forge-author

I'd like my Gerrit account (filippo@) to be added to the may-forge-author group.
I mostly need it for:

uploading code mostly authored by others and provided to me to be submitted under the terms of the CLA, or under a source-only notice license like BSD-1 (for example, I am trying to upload Thomas Pornin's crypto/rsa backend without claiming credit in the Author line)
fixing commit messages of other people's CLs before submitting them
mailing cherry-picks

I'm well aware of the CLA requirements and implications of mailing other people's code :)

CC @golang/release

Friendly ping :) I am blocked on this also to upload a revision of https://go.dev/cl/326012 (which then I'd ask the original author to +1).

Hi Filippo,
The permission is granted. Thanks.
See also #55841 . We are also considering give may-forge-author permission to approves, and update the git-codereview tool to prevent misuse. Thanks.


[Feature Request]Support for tool_calls

Is your feature request related to a problem? Please describe.
Promptflow is only supporting deprecated function calls: https://github.com/openai/openai-python/blob/0cbce3f6777fd8f137ed7445e9bc2f2aa5c9f5b4/src/openai/resources/chat/completions.py#L322C1-L322C53
Describe the solution you'd like
Add support for tool_call and using functions in that context
Here is a link to the code that adds the deprecated function info to the chat completion API call parameters:
https://github.com/microsoft/promptflow/blob/dfbdee0ccecdee3381930e114a5aa84c9586c3e1/src/promptflow-tools/promptflow/tools/aoai.py#L137
Also, this sample requires updating to handle the tool_calls:
https://github.com/microsoft/promptflow/blob/dfbdee0ccecdee3381930e114a5aa84c9586c3e1/examples/flows/chat/use_functions_with_chat_models/run_function.py#L29
Describe alternatives you've considered
Additional context

Hi @M-Hietala "tools"/"tool_choice" support are under testing, and hopefully may ship in a few weeks. We will let you know when it is available to have a try!


Create a README explaining how to start synbiohub3

This should be based on the README from synbiohub-docker

Done


Join path - Party bar should not be displayed

Expected behavior
When the user is in the join path the party bar should not be displayed. They cannot attach their BBOK order to a party.
Actual behavior
In the join path the party bar is displayed on all pages and needs to be removed.

Steps to reproduce behavior
Click on join, and start down the join path. View pages.

@suehamre I'm not familiar with "the join path". Can you point me towards how you get to that page that you are on in your screenshot plz?

@wbyrnetx , Click on join in the header:

Click on the join now link:

You will then need to login or sign up to navigate through:
You can use this login if you want just to get past this page: Email<EMAIL_ADDRESS>Password = Password123

@wbyrnetx , I would expect the party bar to be removed starting on this login/sign up and through the join path.

Got it, thank you for the clarification. Jen is on it TST-142

7-31 SH - On hold - cannot complete test all the way through join path until styling is fixed, because I cannot select a consultant to continue. If i just check the terms and conditions and click continue I am brought out of the join path to the cart.

Also see TST-136 which was created to address the styling issue on the Join path - where party bar should not be displayed.

@suehamre I think this is ready for QA.

8/10 SH - Fixed.


New emit pipeline and API/CLI refactor

API was refactored (closes #393):

BREAKING CHANGE: LuaTranspiler was removed
Added a new function transpile, that runs program.emit with custom transformers and collects emitted results
Added emitTranspiledFiles function, that writes results to disk. Later it would be replaced by Compilation class (#432).
All public transformation APIs now return ts.Diagnostic[] instead of throwing/logging/exiting (#412 still isn't completely resolved, since for now it just catches TranspileError thrown from transformer).
All public APIs now are exported from package index file
Added 3 new high-level API functions - transpileFiles, transpileProject, and transpileVirtualProject
BREAKING CHANGE: Changed signature of transpileString to receive only a string and options. Old features may be done with transpileVirtualProject.
BREAKING CHANGE: CompilerOptions aren't case-insensitive anymore. It should be normalized before using from the API.
BREAKING CHANGE: CLI-related functions aren't exported anymore.

CLI was refactored:

Internal structure now is more similar to tsc
Diagnostics are formatted like in tsc now, with a support of pretty reporter
Since transformation pipeline now returns diagnostics, transpilation errors are reported just like any other diagnostics. Resolves #368.
Watch mode now supports reloading of config file
Running CLI without a project or files now searches for tsconfig.json (like tsc)
Option names in CLI are case-insensitive now
Root-level options are deprecated
BREAKING CHANGE: Boolean options as strings ("true" and "false") are no longer allowed
BREAKING CHANGE: Unknown options in tstl config object are considered as errors now

Added support for some emit-related flags:

declaration
declarationMap
emitDeclarationOnly
noEmit
noEmitOnError (it's not default anymore)

Ah, so that's where it was used.
I don't really like exposing ast as a part of TranspiledFile interface, as it's an implementation detail, but I guess it's okay if there are use cases.
transpile doesn't use any node-specific API so it should work fine.
emitTranspiledFiles probably would would work, but it won't after module resolution would be implemented. Though it's not relevant for single-file use case anyway.


[Bug]: No submission indication of Rating in Rate us page

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
When i submit a rating there is no indication .
I mean this
https://github.com/user-attachments/assets/bdaad86f-3304-4d3b-ae9a-ceba3b2aaeab
Expected behavior
I want to fix it and make it like this

Not this crappy but better than above
Also making emoji pop out more when user click on it
Also please add the tag gssoc-ext and hacktoberfest in it
Add ScreenShots

On which device are you experiencing this bug?
Windows
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I'm a SSOC'24 contributor
[X] I have starred the repository

@Rounit-1st u are assigned


Fixes #174838

Sync css with from markdown.css
Escape string when using callback as marked assumes it's already escaped

cc @mjbvz


Added missing FlexibleInstances

Needs FlexibleInstances to compile with a newer ghc.

Thank you and sorry for the delay!


Add Github Icon to Navigation Bar

Is your feature request related to a problem? Please describe.
Currently, our website's navigation bar does not include an icon for linking to our Github repository. This can make it difficult for users to find and access our Github page, which contains important project information and source code. Adding a Github icon to the navigation bar would improve user experience and make it easier for users to navigate to our Github repository.
Describe the solution you'd like
I would like to request that we add a Github icon to our website's navigation bar. The icon should be clickable and link to our Github repository. Ideally, the icon should be placed in a prominent location in the navigation bar so that users can easily locate it.
Describe alternatives you've considered
One alternative solution would be to include a text link to our Github repository in the navigation bar instead of an icon. However, this would not be as visually appealing as an icon and may be less noticeable to users.
Additional context
Our Github repository contains important project information and source code, and we would like to make it as easy as possible for users to access this information. Adding a Github icon to the navigation bar is a simple and effective way to improve the user experience and increase visibility of our repository.

 Add Github icon to navigation bar

Hello, can I work on this issue?

Yeas you can... reference the figma design @keven321  https://www.figma.com/file/II0muRKX2Emc6M0ocw7u9Y/Quizard?node-id=14%3A799&t=LfiwjQyPV7mARsYF-1

I was able to add the GitHub icon to the navigation bar but I'm having trouble trying to commit the changes I made I'm getting this error message and I don't know what it means and how to fix it. Sorry, I'm new to this and this is my first time contributing to an open-source project. Here is a screenshot of what I'm getting:

run yarn format .

Thank you it works I made the pull request.


How about change badge style like feross/standard ?

According to a background, this project is inspired by feross/standard. If I use standard code style and readme. Badges will be like this below:

I would like to style standard readme badge below:

What do you think ?

I like this a lot! It also is clearer.
Let's implement this in a few days; give time for other people to weigh in on it.

@RichardLitt
I can help it and I will create a PR.

Oh, no! Feel free to make a PR. I'll just wait a couple of days to merge it. I try to move a bit slowly on this, so that people have time to comment if they want. :)

Here is a list using old style design on GitHub. https://github.com/search?utf8=✓&q=https%3A%2F%2Fimg.shields.io%2Fbadge%2Fstandard--readme-OK-green.svg%3Fstyle%3Dflat-square&type=Code&ref=searchresults

@RichardLitt still wait ?

Alright! Merged.
Now, we need to PR all of the existing badges, if possible. I wonder if there is a tool to do string substitution PRs across multiple repositories. Know of any?

How about to create a bot like https://github.com/ReadmeCritic.  I am looking into how it works.

:bulb: Idea

Create GitHub user to observe and create PR.
Create list including repos written in standard style.
Start batch. If there is a problem, GitHub user will create a PR.
If new README is created. user should create PR to include its link into the list.

@RichardLitt not sure but we do not want to send a lot of PR ...

For now, let's just assume they are backwards compatible. I'll be making PRs to most of the repos that use it later this year; I can PR the rest of the repos that don't have it afterwards.


Multi-part form keys - not currently trimmed, issues with whitespace after string

Expected Behavior
String key in multipart form post sent to endpoint
Actual Behavior
There was an errant whitespace character after the string typed, causing the endpoint to not recognize the key.
Reproduction Steps

type 'key ' in the key field
send to endpoint where you want 'key' as the key
note that it will not be recognized

Is there an existing issue for this?

[X] I have searched the issue tracker for this problem.

Additional Information
I had an errant space character after the key for a test I was doing. Took me way too long to figure out that it was causing the error, the key was sent with the space character after the typed string.
It seems to me that sometimes, us developers work fast, and it would make a lot of sense for the keys to be trimmed of whitespace characters (after and before key) before sending.
Insomnia Version
2022.4.2
What operating system are you using?
macOS
Operating System Version
macOS Monterey
Installation method
download from website
Last Known Working Insomnia version
No response

Hi @Forrestt-LFX thanks for reporting this!
This will need a bit of discussion, there might be folks that need, say, for testing purposes, that the keys and values are not trimmed on multipart/form fields, as well as headers and query parameters.
Seems as of now in Insomnia we're not doing any trimming on any of these (multipart/form fields, as well as headers and query parameters).

Tagging @Kong/team-insomnia for someone else to join in on this conversation.
@Forrestt-LFX in the meantime feel free to report any other issues you come across!

@filfreire
Thanks for considering this.
Either way, love the software.
Cheers


net/http/pprof breaks with Martini

It appears that Martini prevents net/http/pprof from working. This can be reproduced by creating a non-Martini app and an equivalent Martini app and examining the "/debug/pprof/" endpoints.
To reproduce:
If you create the following non-Martini application:
// Non-Martini version
package main

import (
	"fmt"
	"net/http"
	_ "net/http/pprof"
)

func handler(w http.ResponseWriter, r *http.Request) {
	fmt.Fprintf(w, "Hi there, I love %s!", r.URL.Path[1:])
}

func main() {
	http.HandleFunc("/", handler)
	http.ListenAndServe(":8080", nil)
}

When running this and then navigating to http://localhost:8080/debug/pprof/ you'll see the following:

If you create the equivalent Martini based application:
// Martini Version
package main

import (
	"fmt"
	"github.com/go-martini/martini"
	"net/http"
	_ "net/http/pprof"
)

func handler(w http.ResponseWriter, r *http.Request) {
	fmt.Fprintf(w, "Hi there, I love %s!", r.URL.Path[1:])
}

func main() {
	m := martini.New()
	r := martini.NewRouter()
	r.Get("/", handler)
	m.Action(r.Handle)
	http.ListenAndServe(":8080", m)
}

And navigate to the same endpoint, you get a 404.

@tarrsalah  The code link you given is no longer working. I really need this to figure out what is happening with my set up as I can not get it working. I am using martini classic and m.Run()
Also, I was wondering if the results are similar of manual profiling... I really need to know which function is killing the web service. My web service takes too long time.

@rcshubhadeep  It's been so long since I have read or written any martini related code , so honestly I have no idea what's going on in the martini community, sorry!

Hi,
Sorry, I think it was a mis communication from my side what I waned to mean is that the link gives me 404 error. So it will be really great to see the code once if possible. Rest I can check myself.
Please let me know

Oh yeah,
I deleted the code while ago, I believe that it is totally obsolete, take a look at this  code, may help you.

The code is deleted, I took at look at that link of code and it doesnt run, anyone have the original code snippet? Otherwise this is still an issue for me.


Create source control events that extensions can listen for and react on

Issue Type: Feature Request
I would love to add some functionality to an existing extension I built, but to do so, I need to know when the user changes branches. If there was a set of events, tied to source control actions, that VS Code broadcasted and an extension could subscribe to, this would make my idea possible.
VS Code version: Code 1.22.2 (3aeede733d9a3098f7b4bdc1f66b63b0f48c1ef9, 2018-04-12T16:32:53.389Z)
OS version: Darwin x64 17.5.0

/duplicate #31103


Organization settings error handling fixes #2253

@Kartones CR this, please.

Frontend tests were OK :+1: (details)

ohh so nice! +1

Frontend tests were OK :+1: (details)


[Feature Request] Enchantment Library Level Config

It might be useful for some modpack authors to be able to configure the maximum output level of the Enchantment Library.
Theres is no reason to upgrade the library if you have no enchantments above level 16.

The enchantment library max storage level is bound by the physical limitations of the storage medium (16-bit shorts vs 32-bit integers).  The 32-bit version is mostly fluff, it doesn't serve a real purpose in a sensible modpack, nor do I want to incentivize it being something people feel obligated to create.


fix(storage): missing validation for s3 bucket names

We are blindly forwarding every CN to S3 as a bucket name. This is the main defect that ultimately leads to https://github.com/immobiliare/inca/issues/128.
I have been considering whether it is wrong to encode, decode, and search for certificates names on S3 without relying on a database. And certainly, the naming requirements for S3 buckets and zones diverge.
This MR adds validation for s3 bucket names.
Additionally, we are now special casing wildcards in CNs.
Best practice would suggest having Apex in the Common Name and Apex plus the wildcard in the Subject Alternative Name. Nonetheless, it is certainly advisable to support this use case.
To handle it, I introduced wildcard stripping: wildcards are flattened along with the zone itself. Closes #128

makes sense to me
@JellyBellyDev can we merge this?

makes sense to me @JellyBellyDev can we merge this?

Sure!
You are the maintainers! ;)


Fixes for verification

Hi @TADraeseke , I caught an unfinished branch for the changes needed on some of the samples for verification. I'm not sure if you caught these on your own, but could you double check I've done the offline data section correctly if not? Thanks

@TADraeseke I've made both of those changes now! For the error, I just added a single line at the start of the updateRoute() function
    // do not calculate a route if there is only one stop
    if (stops.size <= 1) return

@TADraeseke I hope I've managed that correctly!


fix hardcoded http reference that breaks https websites

https websites get an error notification that website is serving insecure images from gravatar.com
This removes it and makes it dynamic

I'll make a new release with it, thanks !

My first ever pull request and contribution to someone else's code.

:+1:


GET requests with JSONEncoding.default always fail

Repro:
        Alamofire.request("https://google.ca", method: HTTPMethod.get, parameters: [:], encoding: JSONEncoding.default, headers: [:]).responseString() { response in
            debugPrint(response)
        }

This fails and prints the following:
[Request]: GET https://google.ca
[Response]: nil
[Data]: 0 bytes
[Result]: FAILURE: Error Domain=NSPOSIXErrorDomain Code=100 "Protocol error" UserInfo={NSErrorPeerAddressKey=<CFData 0x60800009cc50 [0x109bdae40]>{length = 16, capacity = 16, bytes = 0x100201bbacd906030000000000000000}, _kCFStreamErrorCodeKey=100, _kCFStreamErrorDomainKey=1}
[Timeline]: Timeline: { "Request Start Time": 515972090.853, "Initial Response Time": 515972090.995, "Request Completed Time": 515972090.995, "Serialization Completed Time": 515972090.996, "Latency": 0.142 secs, "Request Duration": 0.142 secs, "Serialization Duration": 0.001 secs, "Total Duration": 0.143 secs }

This occurs in our code because we have been encapsulating requests via our own class and funnelling them all through one call to Alamofire.request. Although this might not be an optimal design, I did find it unexpected that specifying JSON encoding would break it.

I realized that sending [:] for parameters with JSON encoding means that Alamofire is probably sending {}. I tried sending nil for parameters instead and this does work for GET requests even when you specify json encoding. I don't think it makes sense to have a special case for GET requests, so closing this myself.


GraphQL integration

Hi guys. Is it possible to have this architecture tailored with GraphQL?
Thanks

Thank you for your interest in this project. This repository has been archived and is no longer actively maintained or supported. We appreciate your understanding. Feel free to explore the codebase and adapt it to your own needs if it serves as a useful reference. If you have any further questions or concerns, please refer to the README for more information.


Zipin add lc to keep service name

Fixes #585
Signed-off-by: Pavol Loffay<EMAIL_ADDRESS>

Coverage remained the same at 100.0% when pulling 3314709d0257f8120a13ee188f4652a279cb51e6 on pavolloffay:zipkin-lc-service-name into f16baef5fbd9e593f4ad5cda277a67e4b55af46d on jaegertracing:master.


update location,, i saw 404 error on the footer

if i click edit this page on github

@NetOperatorWibby thanks for collaboration sir, lets check on lbry.io repo based you commented earlier day ago


Process IP problem/inconsistency

Requirement - what kind of business use case are you trying to solve?
View the process IP address in a human-readable format
Current setup

ES Datastore
NodeJS client 3.9.2dev0
Java client 0.24.0

Problem - what in Jaeger blocks you from solving the requirement?
As of now, the IP from NodeJS is displayed in Query as -1408172028
Here's the value in ES directly:
            "process": {
            "serviceName": "something-service",
            "tags": [
              {
                "key": "jaeger.version",
                "type": "string",
                "value": "Node-3.9.2dev0"
              },
              {
                "key": "jaeger.hostname",
                "type": "string",
                "value": "7fdc5f65b378"
              },
              {
                "key": "ip",
                "type": "float64",
                "value": "-1408172028"
              }
            ]

Proposal - what do you suggest to solve the problem or improve the existing situation?
Option 1:
NodeJS could report the IP as a String like the Java client.
The value in ES would be:

              {
                "key": "ip",
                "type": "string",
                "value": "<IP_ADDRESS>"
              }

Option 2:
Modify the Java client to report the IP in the same format as NodeJS and convert the value to a human-readable format in Query

Here's a few links to save you some time:
NodeJS code
https://github.com/jaegertracing/jaeger-client-node/blob/7df66acbcbf669ee9b0a4308531712af04ec9fc1/src/tracer.js#L64
+
https://github.com/jaegertracing/jaeger-client-node/blob/7df66acbcbf669ee9b0a4308531712af04ec9fc1/src/util.js#L97-L111
Java code
https://github.com/jaegertracing/jaeger-client-java/blob/2fa8f3ed17e88114f6cd7114747ed298933dabd8/jaeger-core/src/main/java/io/jaegertracing/Tracer.java#L110-L128

I just realized what the issue is - JS reports the tag type as float64, and the tag adjuster was only looking for int64
https://github.com/jaegertracing/jaeger/blob/5eb292298bd4b0a24d36e6290968374f78ed22cc/model/adjuster/ip_tag.go#L33-L43

so fixing this would be a better approach, it will convert the tag value on ingestion, rather than changing the clients.

Hi, As a beginner, I would like to work on this issue.
@yurishkuro, It would be really great if you can help me out.

@chandresh-pancholi it's really wonderful that you'd like to help us! For this issue, there's a PR open already: #865. As of now, we do have another 62 issues for you to help with:
https://github.com/search?q=org%3Ajaegertracing+is%3Aissue+is%3Aopen+label%3A"help+wanted"&type=Issues


Rendered view and clipboard view doesn't match for overlapping elements.

Rendered view:

Clipboard:

Needs to some strategy to handle overlapping elements.
If we just consider the copied ASCII diagram, there are two options:

Let the new element hide the below element
Use some special characters like + to actually merge the overlapping areas

Now while rendering on the canvas, we need to accurately reflect whichever option is chosen from above.. this gets interesting with dragging the element and updating the ui. We don't draw full ASCII scene for UI right now, we draw ASCII for each element and the place them on the ui.
Does it make sense to draw full ASCII and place single element on canvas?  We can try that by adding modifiying the drawscene implementation.


Add support for Opple light

Description:
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#6328
Example entry for configuration.yaml (if applicable):
light:
  - platform: tplink
    name: LIGHT_NAME
    host: IP_ADDRESS

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[x] New dependencies have been added to the REQUIREMENTS variable (example).
[x] New dependencies are only imported inside functions that use them (example).
[x] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[x] New files were added to .coveragerc.

The config section in the PR description is not accurate.


Install fails when AG is deployed

When you have an AG installed the install fails as ISTIO creation doesn't seem to like having ports included in the endpoints. You receive the following error
Error from server: error when applying patch:
{"metadata":{"annotations":{"kubectl.kubernetes.io/last-applied-configuration":"{"apiVersion":"networking.istio.io/v1alpha3","kind":"ServiceEntry","metadata":{"annotations":{},"name":"dynatrace-oneagent-hostnames","namespace":"default"},"spec":{"hosts":["pgr59512.live.dynatrace.com","activegate.us-central1-a.c.acl-gsi.internal:9999","<IP_ADDRESS>:9999","sg-eu-west-1-18-202-8-23-prod23-ireland.live.ruxit.com","sg-eu-west-1-52-31-108-81-prod23-ireland.live.ruxit.com","sg-eu-west-1-34-241-182-103-prod23-ireland.live.ruxit.com","sg-eu-west-1-34-241-58-226-prod23-ireland.live.ruxit.com","sg-eu-west-1-52-214-86-21-prod23-ireland.live.ruxit.com"],"location":"MESH_EXTERNAL","ports":[{"name":"HTTPS","number":443,"protocol":"HTTPS"}],"resolution":"DNS"}}\n"}},"spec":{"hosts":["pgr59512.live.dynatrace.com","activegate.us-central1-a.c.acl-gsi.internal:9999","<IP_ADDRESS>:9999","sg-eu-west-1-18-202-8-23-prod23-ireland.live.ruxit.com","sg-eu-west-1-52-31-108-81-prod23-ireland.live.ruxit.com","sg-eu-west-1-34-241-182-103-prod23-ireland.live.ruxit.com","sg-eu-west-1-34-241-58-226-prod23-ireland.live.ruxit.com","sg-eu-west-1-52-214-86-21-prod23-ireland.live.ruxit.com"]}}
to:
&{0xc420105080 0xc420180af0 default dynatrace-oneagent-hostnames ../manifests/gen/service_entries_oneagent.yml 0xc420d0c000 176401 false}
for: "../manifests/gen/service_entries_oneagent.yml": admission webhook "pilot.validation.istio.io" denied the request: configuration is invalid: 4 errors occurred:

domain name "us-central1-a.c.acl-gsi.internal:9999" invalid (label "internal:9999" invalid)
domain name "128.0.37:9999" invalid (label "37:9999" invalid)
hosts must be FQDN if no endpoints are provided for discovery mode DNS
hosts must be FQDN if no endpoints are provided for discovery mode DNS
Error from server: error when applying patch:

Starting with Istio 1.1 all calls to external systems are allowed by default (https://istio.io/docs/tasks/traffic-management/egress/#envoy-passthrough-to-external-services). I think we should allow all calls to external systems in the version we're using, so we don't have to make a lot of changes during an upgrade to version 1.1+ of Istio. We need to point that out in the documentation so that people are aware of that and take care of t configuring the ServiceEntries on their own if the chose to not allow all external calls out of the service mesh by default.
ToDo

[ ] allow all calls to external systems by default
[ ] update documentation accordingly

Did this error occur with version 0.1 or 0.2? In 0.2 we already configure Istio to allow all outgoing traffic by default

No feedback for over a month, closing. Please reopen if the issue still exists.

Peter pointed out that this issue still exists.
In other words, the createServiceEntry.sh script fails because the AG has no fully qualified domain name, which is expected by Istio.
Do we need to create service entries even though we allow all outgoing traffic?

@bacherfl please advise.

[ ] test on an empty DT tenant missing


Replaces involved_addresses with JSONB queries inside message table

Feature description
Currently when parsing a message we put all the involved accounts addresses inside the involved_addresses column. This later allows to query the transactions inside which a specific account is involved. Although this works, there is a better way to allow such searches: search directly inside the raw JSON value of a message.
Implementation proposal
To do this, we could try:

using GIN indexes to index the raw message value;
using JSON operators.

Another alternative is to read the message value as a TEXT and then using the LIKE operator:
SELECT * FROM message WHERE (SELECT CAST(message AS TEXT) LIKE "%address%")

Hey @RiccardoM I tested your suggested implementation (here) but it looks that it is a bit slower than the current approach we are using. Currently the execution time for query A is  1011.704 ms and reading from value column for the same query takes around  6896.864 ms. Is there any chain that you feel is too slow to fetch the transactions?

@MonikaCat This was an idea I had in order to be able to remove the MessagesParser from Juno. If we are able to use this method instead of the involved_addresses, then we can remove the messages parsers all together. What happens if instead of a GIN INDEX we simply use an INDEX instead? Would this work and make the query run faster?

@RiccardoM I am not sure if we can use just INDEX coz it seems that the value size is too big to index it and I am running into this error when trying to create it index row requires 19192 bytes, maximum size is 8191.


Demag GUI selection of temperature bounds

When I open Demag GUI, I can initially only select bounds by clicking on the steps in the lower left corner.  After I've clicked on a step, the drop-down Bounds in the upper left appear and I can edit using those.  It seems like the Bounds drop-down should work from the start, or we should remove that way of interacting with the parameters.
I can dig into this, but it will probably be easier for one of you who have been working on Demag GUI more...

Before the dropdown boxes work, one has to click the add fit button or create a fit by clicking on the steps. Once add fit is clicked then the fit can be modified using the drop-down windows. I think it makes sense to keep the functionality this way.

Just so you all know, I just invited my grad student Hanna Asefaw to be a contributor to PmagPy.  Welcome to the party, Hanna.
lisa

On Oct 6, 2016, at 5:49 PM, Nick Swanson-Hysell<EMAIL_ADDRESS>wrote:
Before the dropdown boxes work, one has to click the add fit button or create a fit by clicking on the steps. Once add fit is clicked then the fit can be modified using the drop-down windows. I think it makes sense to keep the functionality this way.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/PmagPy/PmagPy/issues/76#issuecomment-252127471, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKrDW18BVx6cmUwWeDxcCHr_AnVpY5yks5qxZb9gaJpZM4KQVpY.

Excellent! Welcome Hanna.

Speaking of contributors, I just noticed that @ltauxe your status as a member of the PmagPy organization is set to private which I assume is not intentional:

You can click on yourself in the People list on the PmagPy organization main page and then click on "Private" to change it to "Public":

Oh thanks
Sent from my iPhone

On Oct 6, 2016, at 11:21 PM, Nick Swanson-Hysell<EMAIL_ADDRESS>wrote:
Speaking of contributors, I just noticed that @ltauxe your status as a member of the PmagPy organization is set to private which I assume is not intentional:
You can click on yourself in the People list on the PmagPy organization main page and then click on "Private" to change it to "Public":
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

After a too long absence, I’m about to start testing the 3.0 version of Pmag GUI on a new dataset. but i have some questions:

is this pmag_gui3   separate from Pmag GUI 2.5?
Can I replace thellier_gui with thellier_gui3.0?
is demag_gui now compatible with both 2.5 and 3.0 like thellier_gui3.0?

lisa

Pmag GUI 3 is still separate (pmag_gui3.py) but after a little testing could probably be renamed.  It must be run with the -DM 3 switch, though.  I didn’t want to rely on detecting a 2.5 vs 3.0 file, because Pmag GUI includes a conversion tool and I wanted to be able to force the use of 3.0 even with 2.5 files present.  There is a new pip release so you can use that or the regular git version to check it out.

2 & 3.  I think so!

On Oct 7, 2016, at 10:06 AM, Lisa Tauxe<EMAIL_ADDRESS>wrote:
After a too long absence, I’m about to start testing the 3.0 version of Pmag GUI on a new dataset. but i have some questions:

is this pmag_gui3 separate from Pmag GUI 2.5?
Can I replace thellier_gui with thellier_gui3.0?
is demag_gui now compatible with both 2.5 and 3.0 like thellier_gui3.0?

lisa
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/PmagPy/PmagPy/issues/76#issuecomment-252307383, or mute the thread https://github.com/notifications/unsubscribe-auth/ABwGIglDGcgPi8HhSG56QMFOMWB7h1Bqks5qxnwrgaJpZM4KQVpY.

Thanks, @Swanson-Hysell.  Sounds good!


Seperate JWT Token generation

Expected Behavior
It would be nice when the JWT Token generation from OAuth2ClientCredentialsAuthenticationProvider and OAuth2AuthorizationCodeAuthenticationProvider is moved to a sperate class so I can reuse it e.g. for an custom AuthenticationProvider
Current Behavior
Currently the JWT Token generation for the Access Token is inside the authenticate method of the both classes. To use it in a custom Authenticationprovider I have to copy the logic and everything around e.g. the JwtUtil and the resolve of the JwtEncoder from OAuth2ConfigurerUtils.getJwtEncoder(builder)
Context
I'm adding a custom Grant Type by adding a converter to the tokenEndpoint which provides an custom AutenticationToken which will be resolved by the custom AuthenticationProvider.

Thanks for the report @GrmpfNarf.
Hiding the Jwt token generation in the AuthenticationProvider's was intentional. However, the plan is to introduce an interface, e.g. OAuth2TokenIssuer, which can support any type of token. We'll soon be introducing opaque token support which will trigger some re-factoring.
Rest assured, the Jwt token generation will be extracted into a re-useable component, we're just not there yet.
I'll assign this to 0.2.1 but it may get pushed to a later release.

The same happens to me, I had to copy-paste JwtUtil besides it seems that JoseHeader needs to be public because JwtUtil returns JoseHeader.Builder if you call JwtUtils.headers() that is needed to call then JwtEncodingContext.with(headersBuilder, claimsBuilder).  But I see that conflicting class JoseHeader in Spring Security 5.6 is not public! So to make any custom Provider we JoseHeader to be public or maybe the future refactoring will not require it?

Hi @jgrandja.
May I take this up if it is not already assigned to anyone ?

@erised Let me get back to you next week. I'm playing catch up this week :)

@erised gh-493 and gh-571 are available. Do any of these interest you?

Hi @jgrandja. Sure. I can work on gh-493.

@erised Can you comment in gh-493, e.g. "I would like to take this one" so I can assign it to you.


Donation Not Still Work

i test my credit card on randomuser.me and its' say's "Bad Request (we can't procced your pâyment)" i Think It's Connection or error in my pc but i test in new connection and pc it's give the same error "we can't procced your pâyment"
i contact my bank and they said there is no error in credit card
i saw it's powred by stipe i contact stripe to see if may credit card are available to use in stripe and they say "yes you can"

Sorry about that, donations should be working now at least. It may have been a webserver issue on our end at the time.


resolves #51: decrypt.sh CI bug

For some strange reason, dependabot PRs are not getting a secret key to decrypt the config files.
This PR will make CIs inherit secrets from previous runs

Turns out Dependabot has it's own secrets too... Adding the secret there fixes #51


[VS Code] Joining collaboration session: Could not connect to the server. Check that you are connected to the internet.

Error:
Joining collaboration session: Could not connect to the server. Check that you are connected to the internet.
Steps to Reproduce:
1.
2.

Version Data

extensionName
VSLS

extensionVersion
1.0.694

protocolVersion
2.2

applicationName
VSCode

applicationVersion
1.37.0

platformName
MacOS

platformVersion
18.2.0

Closing due to inactivity. Please re-open if this you're still encountering the issue and can share more details. Thanks!


InputHandler doesn’t work with non-blocking streams

If using a MemoryStream as Input, the InputHandler threaf will return immedeatly when there’s nothing to read from the stream. https://github.com/OmniSharp/csharp-language-server-protocol/blob/master/src/JsonRpc/InputHandler.cs#L78
When reading from e.g. STDIN, the read method will block until there’s something to read, therefore it works there :smile:

Have a look at the tests for the LSP client - I use NamedPipeStreams for this reason :)
PS. Anonymous pipes don't support async!

It's a pity Stream never declared an Is locking or CanBlock property :-/

we can probably safely change this to just wait around and try again later to see if there is anything on the stream to read.

@tintoy yes, read loop will become a little more complex. But for now, I can work around this by implementing my own blocking memory stream.
On a side note.:  Hell, MemoryStream even throws if one tries to set ReadTimeout...

@mholo65 - was going to maybe suggest System.IO.Pipelines being a way to abstract read loop from stream type? Perhaps I could look into that for the client (since that's used by fewer people) and if it works we could use it for the server implementation as well?

I think this has been achieved at this point, @mholo65 please re-open if you don't think so.


Relative Image Links Are Broken In READMEs

Gitea version (or commit ref): Both v1.14.3 (Self-Hosted) And v1.15.0+dev-516-ge8c6cead0 (https://try.gitea.io)
Database:

[ ] PostgreSQL
[ ] MySQL
[ ] MSSQL
[X] SQLite

Can you reproduce the bug at https://try.gitea.io:

[X] Yes: https://try.gitea.io/TheBrokenRail/image-test

Log gist: https://gist.github.com/TheBrokenRail/02f26f44cd4ed89aed8f519891a63ed6

Description
Images specified with relative links in markdown files don't load.
Screenshots

This should be linking to
https://try.gitea.io/TheBrokenRail/image-test/media/branch/master/images/base-1024.png
But is linking to:
https://try.gitea.io/TheBrokenRail/images/base-1024.png

I'm not sure how this has broken it's probably something to do with the changes to html.go or render ctx

Basically I bet the prefix URL is incorrect

This is really weird because this is working for me...


Cannot use PHP code to construct an URL in the sidebar menu items

Question
Answer

Issue or Enhancement
Enhancement/Question

Laravel Version
Laravel 7

Project Version
AdminLTE 3.2

Current Behavior
I cannot use the route command or any PHP code to construct a menu item URL for the sidebar in config/adminlte.php.
Steps to Reproduce

To work with Auth in config is not possible. You have to work with the menu builder on runtime to set menu entries like this.


Sending more data than I can fit in ram

I have a Arduino Mega project that can generate about 96 KB of data that I want to send as a file with this library. This is more than the 8 KB of ram that the Mega has so I can't send it all in one large chunk. Is there some way to send multiple smaller chunks of data that will fit in ram and if not does the xmodem protocol even support this? Would I have to transfer multiple files stitch them back together on the other end?

Hi @polarbub if you can generate the data on device then I would consider using the Lookup send function.
You will need to create and set a block lookup handler that will be responsible for gathering the next block of data that will be sent in the next xmodem packet. So if you could do something along the lines of generating a block of data, pause while it gets sent out, and continue like this until all the data has been generated then it would still all be part of the same file transfer and show up together in a single file.
Xmodem does not have a limit on the size of files it can send it's just that by default there is no way to uniquely identify each file block (default Xmodem only has 256 unique block labels) nor how big the fully transferred file will be. It also can't resume an interrupted transfer for the same reason.


css-class in custom components does not render when inside of a  as the component root element

css-class in custom components does not render when inside of a <div> as the component root element.
Reproduction Steps:

Create a custom component and add a <div> as a root element
Add a couple of mjml <Table> parts inside of the div with their own css-class attributes
Does not render the css-class for some reason.

Expected behavior:
I expect that no matter where you specify a mjml component like <Table> that it would render the css class, but it's not. For some reason it's ignoring that attribute when in a custom component and a normal div as the element root.
Screenshots and GIFs

MJML version:

Email clients the bug is seen on:
N/A This is when I try and run my Nightwatch tests over the html output.

Hi @etiennemarais
Well the answer lies into the decorator. Table, Text, Image, every mj-component that live in a Column has a special treatment for css-class as you can see here https://github.com/mjmlio/mjml/blob/master/packages/mjml-core/src/decorators/MJMLElement.js#L263-L276
Here you should use a regular table, as Mj-Table isn't going to do anything for you

Great, Thanks for clearing that up :)