(0) Not found: Key output_bias not found in checkpoint (Restoring a self pre-trained model)

I did a pre-training process for the model and I got a checkpoint, graph.phtxt and series of model.ckpt checkpoint files, so everything was fine for the pre-training proccess.
(I pre-trained the origin model with chinese_L-12_H-768_A-12 on Google Colab using GPU)
And the next step, I am now trying to fine tune the self-pre-trained model but I am encountering some error messages (the main part of the error messages shown in bold below):

I0615 11:22:45.978288<PHONE_NUMBER>73248 error_handling.py:96] training_loop marked as finished
W0615 11:22:45.978406<PHONE_NUMBER>73248 error_handling.py:130] Reraising captured error
Traceback (most recent call last):
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/client/session.py", line 1356, in _do_call
return fn(*args)
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/client/session.py", line 1341, in _run_fn
options, feed_dict, fetch_list, target_list, run_metadata)
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/client/session.py", line 1429, in _call_tf_sessionrun
run_metadata)
tensorflow.python.framework.errors_impl.NotFoundError: 2 root error(s) found.
(0) Not found: Key output_bias not found in checkpoint
[[{{node save/RestoreV2}}]]
[[save/RestoreV2/_301]]
(1) Not found: Key output_bias not found in checkpoint
[[{{node save/RestoreV2}}]]
0 successful operations.
0 derived errors ignored.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/training/saver.py", line 1286, in restore
{self.saver_def.filename_tensor_name: save_path})
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/client/session.py", line 950, in run
run_metadata_ptr)
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/client/session.py", line 1173, in _run
feed_dict_tensor, options, run_metadata)
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/client/session.py", line 1350, in _do_run
run_metadata)
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/client/session.py", line 1370, in _do_call
raise type(e)(node_def, op, message)
tensorflow.python.framework.errors_impl.NotFoundError: 2 root error(s) found.
(0) Not found: Key output_bias not found in checkpoint
[[node save/RestoreV2 (defined at run_classifier.py:953) ]]
[[save/RestoreV2/_301]]
(1) Not found: Key output_bias not found in checkpoint
[[node save/RestoreV2 (defined at run_classifier.py:953) ]]
0 successful operations.
0 derived errors ignored.
Original stack trace for 'save/RestoreV2':
File "run_classifier.py", line 1054, in
tf.app.run()
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/platform/app.py", line 40, in run
_run(main=main, argv=argv, flags_parser=_parse_flags_tolerate_undef)
File "/usr/local/lib/python3.6/dist-packages/absl/app.py", line 300, in run
_run_main(main, args)
File "/usr/local/lib/python3.6/dist-packages/absl/app.py", line 251, in _run_main
sys.exit(main(argv))
File "run_classifier.py", line 953, in main
estimator.train(input_fn=train_input_fn, max_steps=num_train_steps)
File "/usr/local/lib/python3.6/dist-packages/tensorflow_estimator/python/estimator/tpu/tpu_estimator.py", line 2871, in train
saving_listeners=saving_listeners)
File "/usr/local/lib/python3.6/dist-packages/tensorflow_estimator/python/estimator/estimator.py", line 367, in train
loss = self._train_model(input_fn, hooks, saving_listeners)
File "/usr/local/lib/python3.6/dist-packages/tensorflow_estimator/python/estimator/estimator.py", line 1158, in _train_model
return self._train_model_default(input_fn, hooks, saving_listeners)
File "/usr/local/lib/python3.6/dist-packages/tensorflow_estimator/python/estimator/estimator.py", line 1192, in _train_model_default
saving_listeners)
File "/usr/local/lib/python3.6/dist-packages/tensorflow_estimator/python/estimator/estimator.py", line 1480, in _train_with_estimator_spec
log_step_count_steps=log_step_count_steps) as mon_sess:
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/training/monitored_session.py", line 584, in MonitoredTrainingSession
stop_grace_period_secs=stop_grace_period_secs)
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/training/monitored_session.py", line 1007, in init
stop_grace_period_secs=stop_grace_period_secs)
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/training/monitored_session.py", line 725, in init
self._sess = _RecoverableSession(self._coordinated_creator)
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/training/monitored_session.py", line 1200, in init
_WrappedSession.init(self, self._create_session())
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/training/monitored_session.py", line 1205, in _create_session
return self._sess_creator.create_session()
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/training/monitored_session.py", line 871, in create_session
self.tf_sess = self._session_creator.create_session()
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/training/monitored_session.py", line 638, in create_session
self._scaffold.finalize()
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/training/monitored_session.py", line 237, in finalize
self._saver.build()
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/training/saver.py", line 837, in build
self._build(self._filename, build_save=True, build_restore=True)
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/training/saver.py", line 875, in _build
build_restore=build_restore)
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/training/saver.py", line 502, in _build_internal
restore_sequentially, reshape)
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/training/saver.py", line 381, in _AddShardedRestoreOps
name="restore_shard"))
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/training/saver.py", line 328, in _AddRestoreOps
restore_sequentially)
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/training/saver.py", line 575, in bulk_restore
return io_ops.restore_v2(filename_tensor, names, slices, dtypes)
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/ops/gen_io_ops.py", line 1696, in restore_v2
name=name)
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/framework/op_def_library.py", line 788, in _apply_op_helper
op_def=op_def)
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/util/deprecation.py", line 507, in new_func
return func(*args, **kwargs)
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/framework/ops.py", line 3616, in create_op
op_def=op_def)
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/framework/ops.py", line 2005, in init
self._traceback = tf_stack.extract_stack()
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/training/saver.py", line 1296, in restore
names_to_keys = object_graph_key_mapping(save_path)
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/training/saver.py", line 1614, in object_graph_key_mapping
object_graph_string = reader.get_tensor(trackable.OBJECT_GRAPH_PROTO_KEY)
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/pywrap_tensorflow_internal.py", line 678, in get_tensor
return CheckpointReader_GetTensor(self, compat.as_bytes(tensor_str))
tensorflow.python.framework.errors_impl.NotFoundError: Key _CHECKPOINTABLE_OBJECT_GRAPH not found in checkpoint
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "run_classifier.py", line 1054, in
tf.app.run()
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/platform/app.py", line 40, in run
_run(main=main, argv=argv, flags_parser=_parse_flags_tolerate_undef)
File "/usr/local/lib/python3.6/dist-packages/absl/app.py", line 300, in run
_run_main(main, args)
File "/usr/local/lib/python3.6/dist-packages/absl/app.py", line 251, in _run_main
sys.exit(main(argv))
File "run_classifier.py", line 953, in main
estimator.train(input_fn=train_input_fn, max_steps=num_train_steps)
File "/usr/local/lib/python3.6/dist-packages/tensorflow_estimator/python/estimator/tpu/tpu_estimator.py", line 2876, in train
rendezvous.raise_errors()
File "/usr/local/lib/python3.6/dist-packages/tensorflow_estimator/python/estimator/tpu/error_handling.py", line 131, in raise_errors
six.reraise(typ, value, traceback)
File "/usr/local/lib/python3.6/dist-packages/six.py", line 693, in reraise
raise value
File "/usr/local/lib/python3.6/dist-packages/tensorflow_estimator/python/estimator/tpu/tpu_estimator.py", line 2871, in train
saving_listeners=saving_listeners)
File "/usr/local/lib/python3.6/dist-packages/tensorflow_estimator/python/estimator/estimator.py", line 367, in train
loss = self._train_model(input_fn, hooks, saving_listeners)
File "/usr/local/lib/python3.6/dist-packages/tensorflow_estimator/python/estimator/estimator.py", line 1158, in _train_model
return self._train_model_default(input_fn, hooks, saving_listeners)
File "/usr/local/lib/python3.6/dist-packages/tensorflow_estimator/python/estimator/estimator.py", line 1192, in _train_model_default
saving_listeners)
File "/usr/local/lib/python3.6/dist-packages/tensorflow_estimator/python/estimator/estimator.py", line 1480, in _train_with_estimator_spec
log_step_count_steps=log_step_count_steps) as mon_sess:
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/training/monitored_session.py", line 584, in MonitoredTrainingSession
stop_grace_period_secs=stop_grace_period_secs)
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/training/monitored_session.py", line 1007, in init
stop_grace_period_secs=stop_grace_period_secs)
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/training/monitored_session.py", line 725, in init
self._sess = _RecoverableSession(self._coordinated_creator)
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/training/monitored_session.py", line 1200, in init
_WrappedSession.init(self, self._create_session())
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/training/monitored_session.py", line 1205, in _create_session
return self._sess_creator.create_session()
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/training/monitored_session.py", line 871, in create_session
self.tf_sess = self._session_creator.create_session()
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/training/monitored_session.py", line 647, in create_session
init_fn=self._scaffold.init_fn)
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/training/session_manager.py", line 290, in prepare_session
config=config)
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/training/session_manager.py", line 220, in _restore_checkpoint
saver.restore(sess, ckpt.model_checkpoint_path)
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/training/saver.py", line 1302, in restore
err, "a Variable name or other graph key that is missing")
tensorflow.python.framework.errors_impl.NotFoundError: Restoring from checkpoint failed. This is most likely due to a Variable name or other graph key that is missing from the checkpoint. Please ensure that you have not altered the graph expected based on the checkpoint. Original error:
2 root error(s) found.
(0) Not found: Key output_bias not found in checkpoint
[[node save/RestoreV2 (defined at run_classifier.py:953) ]]
[[save/RestoreV2/_301]]
(1) Not found: Key output_bias not found in checkpoint
[[node save/RestoreV2 (defined at run_classifier.py:953) ]]
0 successful operations.
0 derived errors ignored.
Original stack trace for 'save/RestoreV2':
File "run_classifier.py", line 1054, in
tf.app.run()
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/platform/app.py", line 40, in run
_run(main=main, argv=argv, flags_parser=_parse_flags_tolerate_undef)
File "/usr/local/lib/python3.6/dist-packages/absl/app.py", line 300, in run
_run_main(main, args)
File "/usr/local/lib/python3.6/dist-packages/absl/app.py", line 251, in _run_main
sys.exit(main(argv))
File "run_classifier.py", line 953, in main
estimator.train(input_fn=train_input_fn, max_steps=num_train_steps)
File "/usr/local/lib/python3.6/dist-packages/tensorflow_estimator/python/estimator/tpu/tpu_estimator.py", line 2871, in train
saving_listeners=saving_listeners)
File "/usr/local/lib/python3.6/dist-packages/tensorflow_estimator/python/estimator/estimator.py", line 367, in train
loss = self._train_model(input_fn, hooks, saving_listeners)
File "/usr/local/lib/python3.6/dist-packages/tensorflow_estimator/python/estimator/estimator.py", line 1158, in _train_model
return self._train_model_default(input_fn, hooks, saving_listeners)
File "/usr/local/lib/python3.6/dist-packages/tensorflow_estimator/python/estimator/estimator.py", line 1192, in _train_model_default
saving_listeners)
File "/usr/local/lib/python3.6/dist-packages/tensorflow_estimator/python/estimator/estimator.py", line 1480, in _train_with_estimator_spec
log_step_count_steps=log_step_count_steps) as mon_sess:
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/training/monitored_session.py", line 584, in MonitoredTrainingSession
stop_grace_period_secs=stop_grace_period_secs)
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/training/monitored_session.py", line 1007, in init
stop_grace_period_secs=stop_grace_period_secs)
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/training/monitored_session.py", line 725, in init
self._sess = _RecoverableSession(self._coordinated_creator)
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/training/monitored_session.py", line 1200, in init
_WrappedSession.init(self, self._create_session())
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/training/monitored_session.py", line 1205, in _create_session
return self._sess_creator.create_session()
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/training/monitored_session.py", line 871, in create_session
self.tf_sess = self._session_creator.create_session()
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/training/monitored_session.py", line 638, in create_session
self._scaffold.finalize()
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/training/monitored_session.py", line 237, in finalize
self._saver.build()
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/training/saver.py", line 837, in build
self._build(self._filename, build_save=True, build_restore=True)
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/training/saver.py", line 875, in _build
build_restore=build_restore)
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/training/saver.py", line 502, in _build_internal
restore_sequentially, reshape)
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/training/saver.py", line 381, in _AddShardedRestoreOps
name="restore_shard"))
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/training/saver.py", line 328, in _AddRestoreOps
restore_sequentially)
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/training/saver.py", line 575, in bulk_restore
return io_ops.restore_v2(filename_tensor, names, slices, dtypes)
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/ops/gen_io_ops.py", line 1696, in restore_v2
name=name)
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/framework/op_def_library.py", line 788, in _apply_op_helper
op_def=op_def)
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/util/deprecation.py", line 507, in new_func
return func(*args, **kwargs)
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/framework/ops.py", line 3616, in create_op
op_def=op_def)
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/framework/ops.py", line 2005, in init
self._traceback = tf_stack.extract_stack()
I have tried to add a code below, But it doesn't work.
import tensorflow as tf
tf.reset_default_graph()
Have anyone met this situation? I have no idea how to fix it.
I will be grateful for any help you can provide.

@biuleung, where you able to solve this issue?

I have the same issue. Did anyone resolve it?

In my case I reduced the batch size and it worked perfectly fine.

@pushpankar I tried by reducing the batch size but it didnt work out. Do you have any other suggestions?

Try to keep the output directory empty and keep seq len 128. See if that works or not

I have the same issue, was not able to resolve yet.
seq_len = 128 wouldn't help much in this case.


SPARK-1137: Make ZK PersistenceEngine not crash for wrong serialVersionUID

Previously, ZooKeeperPersistenceEngine would crash the whole Master process if
there was stored data from a prior Spark version. Now, we just delete these files.

Test build #41 has started for PR 4 at commit 414d267.

Test build #41 has finished for PR 4 at commit 414d267.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #42 has started for PR 4 at commit 414d267.


feat:a dded noob level changes to a PR

Clickup
app.clickup.com
Code Coverage
Please add code coverage here
UI Preview
Please add screenshots for UI changes

Summary by CodeRabbit

Refactor

Improved the control flow in the deep link redirection logic for enhanced readability and maintainability.

@coderabbitai review


[BUGFIX] Add style before first <link // solves #28

👍 for this PR to be merged, but may I suggest another change for it @misterboe ?
how about:
var firstHeadChild = document.head.firstElementChild;
document.head.insertBefore(style, firstHeadChild);

rather than simply:
document.getElementsByTagName("link")[0]

This would make sure the error doesn't happen when there are no links on header.
Just to shed some light on this issue, the error @misterboe is trying to fix is when bioEp tries to insert the exit intent styles in head DOM element, before the first occurence of a style. The problem arises when this first occurence of style is not inside head, but, rather, inside body.
The error message is this:
Uncaught DOMException: Failed to execute 'insertBefore' on 'Node': The node before which the new node is to be inserted is not a child of this node

Hope this helps.


[Bug]: In a multi panel app it doesn't create resources inside the panel namespace.

What happened?
In a multipanel app when running php artisan module:make:filament-resource asks about the panel. But it doesn't generate the resources inside the folder belonging to the panel.
How to reproduce the bug
Create a multipanel app i.e. org, team. Run php artisan module:make:filament-resource. It will ask about the panel and select org.
Package Version
4.0.6
PHP Version
8.2.0
Laravel Version
11.15.0
Which operating systems does with happen with?
Windows
Notes
No response

Hi @rezwanul7,
I have tried to reproduce your issue above but I couldn't. I have created a bare minimum setup by following the package's documentation and it works perfectly. I followed these steps:

Created a new Laravel Project

Ran composer to install coolsam/modules, which by default installs all the other dependencies including filament and nwidart/laravel-modules.

Configured Filament (filament:install) and created two Panels: Org and Team

Opened the Org Panel and added the ModulesPlugin there (My highest suspicion is that you may have skipped this). Here is how my Org panel looks like:

Configured nwidart/modules as per the documentation, including adding the folllowing to composer.json:

Created a new Module called Procurement: php artisan module:make Procurement

Added a new model called Supplier to the Procurement module with a factory, seeder and migration: php artisan module:make-model Supplier -mfs Procurement

Installed the Filament Modules Plugin under the Procurement Module: php artisan module:filament:install. Here are my steps:

Finally generated a Suppliers Resource under the Procurement module, after running php artisan migrate. Here are my steps:

After going through the above steps, here is my working app:

Feel free share your reproduction repo in case you are still experiencing challenges. Closing this for now.

What happened?
In a multipanel app when running php artisan module:make:filament-resource asks about the panel. But it doesn't generate the resources inside the folder belonging to the panel.
How to reproduce the bug
Create a multipanel app i.e. org, team. Run php artisan module:make:filament-resource. It will ask about the panel and select org.
Package Version
4.0.6
PHP Version
8.2.0
Laravel Version
11.15.0
Which operating systems does with happen with?
Windows
Notes
No response

Just to clarify, the whole idea of using this package is to gain autonomy from the main app/ directory, so resources are not generated in the panel folder, they are rather generated inside the Module of your choice. Here is a sample directory structure for a Procurement module registered under the Org panel:


[Extension] RJSF - remove description and add tooltip to fields

Signed-off-by: Bariq<EMAIL_ADDRESS>Description
Notes for Reviewers
Meshery Extension:

Remove description fields in the field input
Add help tooltip for description

Final implementation

Signed commits

[ ] Yes, I signed my commits.

Codecov Report

Merging #4171 (61fda34) into master (12e4d79) will decrease coverage by 7.73%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4171      +/-   ##
==========================================
- Coverage   26.91%   19.18%   -7.74%
==========================================
  Files          59       59
  Lines        5031     5031
==========================================
- Hits         1354      965     -389
- Misses       3262     3771     +509
+ Partials      415      295     -120

Flag
Coverage Δ

e2etests
?

gointegrationtests
?

unittests
19.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

mesheryctl/internal/cli/root/system/status.go
0.00% <0.00%> (-62.83%)
:arrow_down:

mesheryctl/internal/cli/root/system/start.go
0.99% <0.00%> (-53.98%)
:arrow_down:

mesheryctl/internal/cli/root/system/stop.go
0.85% <0.00%> (-36.76%)
:arrow_down:

mesheryctl/internal/cli/root/system/update.go
1.05% <0.00%> (-34.74%)
:arrow_down:

mesheryctl/internal/cli/root/system/restart.go
1.78% <0.00%> (-32.15%)
:arrow_down:

mesheryctl/internal/cli/root/system/check.go
1.39% <0.00%> (-22.38%)
:arrow_down:

mesheryctl/internal/cli/root/system/logs.go
0.00% <0.00%> (-21.60%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 986937b...61fda34. Read the comment docs.

Can we reduce the icon size @bariqhibat  ?

@bariqhibat @sudo-NithishKarthik conflict - https://github.com/meshery/meshery/pull/4171/conflicts

Due to unforeseen issues, I reverted back to the old design but hide the description for aesthetics.
The issues are:

Custom fields input component isn't able to update the states of the form from inside the component easily. Hence, there might need a refactoring on how to manage RJSF form states

Latest commit

What a clean UI this makes.


css for images being the correct size

#10 results in really big figures. I'm assuming this fix would happen w/ the templates and css.
image showing the issue forthcoming

This came along with #33


Maya XGen might out of order if the WORKDIR get changed in each task

After Launcher launchs Maya, Maya's project-path get set to AVALON_WORKDIR.
core/avalon/maya/pipeline.py
In most cases, this is okay.
But there are some features or plugins ( for instance, XGen ) rely on Maya's project-path very much. In that case, things might go wrong.

Some info about why XGen needs project-path stay consistence :

Like textures get store in sourceimages, Maya XGen Legacy  out source lots of maps in every work step, and almost every change made in Maya XGen, will save into those maps, instead of maya file itself.
And the way XGen load those maps, is through relative path :
project-path/xgen/collections/lots_of_subDir
More info at Manage XGen files and directories

Problem
Something like Maya XGen Legacy needs project-path to stay consistence so it can work properly.
If we need Maya be launched by Launcher, is there any workaround exists for the project-path consistency ?
Or can we skip set project to AVALON_WORKDIR ?

Some info about why XGen needs project-path stay consistence :

Nice use of <details>! ;)

Something like Maya XGen Legacy needs project-path to stay consistence so it can work properly.
If we need Maya be launched by Launcher, is there any workaround exists for the project-path consistency ? Or can we skip set project to AVALON_WORKDIR ?

Just so I understand, how do you mean consistency? What path are you looking for it to set, in place of AVALON_WORKDIR?

Do you mean that there needs to already exist a xgen/ directory in the Maya project dir?

If so, then you can append to the directories it creates via the default_dirs of the Project Execution API.
For example, if you are using avalon-setup, then you can modify this. Paths can include subdirectories too, like xgen/subdir.

Sorry, I wasn't thinking this right, turns out that all I need to do was using xgen api to export all the .ptx maps and xgen description files associated with scene by Pyblish, import them by Loader, and modified the attribute which contents the project-path string in .xgen file, during import and export.
In the past, how we work with XGen, was storing all maps for all characters in one xgen-root as Maya's default like
proj/maya/xgen/collections/{char_hair}/{hair_description}/{map_types}/{maps}

And now with Avalon, it's just simply changes to something like this
proj/work/{character}/maya/xgen/collections/{char_hair}/{hair_description}/{map_types}/{maps}

Why I freaked out :

Without any tool's help, xgen's creation is very fragile, although we did save many versions of maya work file, but the xgen's real change was saved in to those maps, and those maps did not easily save to different version like renaming files, so from time to time, artist often finds out that thier xgen hair was explode or turn to crap, and hard to restore.
After some research, we do have a tool to help us get xgen maps versioned, but we still dealing them in one worksapce.
So I was freaked out by the change of the maya workspace number from one in one project to multiple workspaces in one project, and worried about the xgen path might broken since there is more than one workspace.
But turns out that was just a shadow of pain.
Hope I explained clear about why I got wrong, but if not, no need to bother. 😄
Because,

There is no problem now, at least for XGen, since I can import / export, and modified the root path in the .xgen file with xgen api.
With multiple workspace, this might be more safer than ever !

Do you mean that there needs to already exist a xgen/ directory in the Maya project dir?

Nah, what I meant was nuts, I was thinking if we can launch Maya with one static working project-path ( one workspace all the way ).
I was trapped in the old way. 😢
After I read this : Rythm & Hues pipeline
I finally understand the reason why each asset should having their own workspace, and I should stay in this way.

Since the true reason ( self-discovery, I think ) I bring up this issue was because lacking the knowledge of asset separation folder structure ( asset oriented ? ), can I change the issue title to something like :
Why create different workspaces for each task on each asset ?
Thanks @mottosso !

For unnecessary off topic avoiding and better understanding about the original issue, I did some rephrase and simplify with my comments.


'responsive-margin' addon needs a version bump on NPM

Hi @jxnblk,
Creating an issue here because the 'basscss-addons' repo is archived.
I noticed you merged this PR to fix negative margins for the 'responsive-margin': https://github.com/basscss/addons/pull/33
However there is no version bump on NPM, so the package doesn't update when running npm update.
Is there something I'm doing wrong here to get this update?
Thanks, Cam

I think the issue here is that version bumps have not been published to NPM. If clone the 'basscss-addons' repo and look at package.json I can see that the latest version is actually 1.1.0, whereas the latest version according to NPM is 1.0.0.
Cloning the 'basscss-addons' repo manually also pulls the latest code for 'responsive-margins' including the 'Fix negative margins' PR I mentioned above.


[Removal]: Why no one handles the delete request

Hotspot Name
Large Azure Pangolin
Hotspot b58 Address
11h4zDCDauxFXPeFjCVixJ4UhGZm8ApbxZuLcABUmt6zDGTDCzh
Discord Handle
zack_z#5814
Hotspot Manufacturer
bobcat
Removal Reason
Now that I have deployed correctly, no one has dealt with removing it from the blacklist
Modifications
No
Extra forwarders
No
Extra antennas
Yes
Additional Information

No one has processed the delete request for too long!
Dear Sir or Madam,
My name is Zack ,First of all, I apologize for my English if there are any mistakes.  I'm sorry it was a fake location before, I've recognized the mistake, now I've deployed it correctly, please give it another chance.
The following are the location related pictures I provided, I can provide more according to your needs, please let me know, thank you.
This is the 5.8dbm antenna outside the window

This is a picture of the antenna taken from inside the window

This is the hotspot for the bobcat

I updated its location to the correct place

this is gps info

location on hotspotty

I apologize for the inconvenience and thank you in advance.Please let me know if you need more proof, thanks a lot!

12 Removal Issues for the same hotspot?
So you cheated the network....and now you want to get removed from denylist lol, did you sent back all HNT that you stollen from other users too?


[TRIVIAL] Make rippled C++14-ready.

This makes rippled portable to -std=c++14 on clang/libc++, but it does not actually flip the switch in SConstruct.  The configuration should be tested out on each platform of interest.  I suspect we may want to move to gcc-5.x prior to moving to -std=c++14.
@vinniefalco @nbougalis

Obviously correct, this is trivial

The commit is split between beast and rippled so the message should be neutral:
"C++14 support" for example. I'll amend

Thanks Vinnie.  Actually the commit doesn't touch any rippled files.  It's pure beast.


Fix build process

Fixes this bug:
Neo4jError: Connection acquisition timed out in 60000 ms. Poos status: Active conn count = 100, Idle conn count = 0.


Incorrect RAND_set_rand_method documentation.

The documentation for RAND_set_rand_method()  says it doesn't return anything, But the function actually returns an int (Header, Source), the usual OpenSSL convention of 1 for success, 0 for error.

Feel free to submit a pull request correcting this.......

This issue was fixed by @agnosticdev in #9351.


[BUG] Sensitive data exposed in the browser console

Description
There are some pages where sensitive data like API key, appID and all sorts of other keys are consoled and are visible inside the browser console which may lead to unwanted breaches.
I would like to work on this issue under GSSoC '23.
@Gaurav-Verma07  Could you please assign it to me?
Screenshots

Additional information
I think the keys are from firebase.

Hey @Gaurav-Verma07 what should i name the new branch that i've created in my forked repo?


[AJ-719] Update publish-docker.yml

https://github.com/DataBiosphere/terra-workspace-data-service/pull/164 attempted to only grab the first jira id in a commit message if there was only one.  For some reason I thought it was working when apparently it was not.  Hopefully this time is correct.

tested it on my end and it worked as expected!


Xcode 16 Degraded Performance Since 9/25

Description
Xcode 16 seems to have had degraded performance on MacOS 14 since 9/25. We updated our pipelines to Xcode 16 on 9/23, and saw consistent successful test runs (unit and UI tests) on both 9/23 and 9/24.
Starting on 9/25, however, we have identified three separate degradations with Xcode 16.

UI tests fail consistently. The same UI tests that were working on 9/24 now fail every time since 9/25.
Unit and UI tests take ~50% longer to run. Before 9/25, our tests suite took about 20 minutes to run. Now it takes 30+ minutes.
Xcodebuild fails to find a simulator on this command due to an inability to find the iPhone 15 18.0 simulator:

xcodebuild -showBuildSettings -scheme ******** -project ********* -configuration Debug -destination platform\=iOS\ Simulator,name\=iPhone\ 15,OS\=18.0

On 9/23 and 9/24, this command succeeded and found the iPhone 15 18.0 simulator.
Due to the correlation of these three issues on the same date, I am fairly confident that a runner upgrade resulted in degraded performance for Xcode 16.
Platforms affected

[ ] Azure DevOps
[X] GitHub Actions - Standard Runners
[ ] GitHub Actions - Larger Runners

Runner images affected

[ ] Ubuntu 20.04
[ ] Ubuntu 22.04
[ ] Ubuntu 24.04
[ ] macOS 12
[ ] macOS 13
[ ] macOS 13 Arm64
[ ] macOS 14
[X] macOS 14 Arm64
[ ] macOS 15
[ ] macOS 15 Arm64
[ ] Windows Server 2019
[ ] Windows Server 2022

Image version and build link
Version of the successful runner: macos-14-arm64 20240918.8
Version of the failing runner: macos-14-arm64 20240922.1
Both runners indicate that they are version 2.319.1.
Is it regression?
Yes. Last successful runner was version 20240918.8
Expected behavior

UI tests succeed as they did on 9/24
Unit and UI tests take the same amount of time they did on 9/24
Fastlane scan succeeds

Actual behavior

UI tests fail consistently. The same UI tests that were working on 9/24 now fail every time since 9/25.
Unit and UI tests take ~50% longer to run. Before 9/25, our tests suite took about 20 minutes to run. Now it takes 30+ minutes.
Fastlane scan fails due to inability to find a simulator. On 9/24, this command:

Repro steps
Steps to reproduce the behavior:

Attempt to run a unit or UI test suite on MacOS 14 Xcode 16
Notice that it fails

Hey @Nathan-Molby!
Thank you for bring it to our attention. I'll check on it ASAP. A small note: Would you mind to try it on macos-15 runner which is available now? We'll deprecate Xcode 16 on macOS-14 anyway soon.

Not sure if fully related, but we are also seeing similar degraded performance on macos-14 since the last week, using Xcode 15.2, where builds of the same commit now have twice the duration using xcodebuild using a Hosted Azure Pipelines runner (Agent version 3.244.1).
Example of showBuildSettings command that times out, which has never happened before.
INFO [2024-10-01 15:04:18.73]: $ xcodebuild -showBuildSettings -workspace [...].xcworkspace -scheme [...] -configuration [...] 2>&1
WARN [2024-10-01 15:04:21.75]: Command timed out after 3 seconds on try 1 of 4, trying again with a 6 second timeout...
WARN [2024-10-01 15:04:27.78]: Command timed out after 6 seconds on try 2 of 4, trying again with a 12 second timeout...
WARN [2024-10-01 15:04:40.06]: Command timed out after 12 seconds on try 3 of 4, trying again with a 24 second timeout...
WARN [2024-10-01 15:05:04.18]: Command timed out after 24 seconds on try 4 of 4

And an example of real (test) builds:

Before (image version 20240902.6 , Agent 3.243.1, not sure if related)
After (image version 20240923.101, Agent 3.244.1)

Let me know if this should have its own issue.

We also see severely degraded performance on Xcode 15 and 16 alike, on macOS Large Runners. Notably, as in the original post, UI tests have become practically unusable.
It's similar to https://github.com/actions/runner-images/issues/10098 which I reported just a few months ago. It is extremely frustrating that you rely on your users to report these issues (it's been days!), and refuse any acknowledgment/status update (see the linked issue). This must be visible somewhere in your dashboards. We definitely see it on ours, and we literally pay for it.

@erik-bershel MacOS 15 seems to resolve these issues for us. Unit and UI tests are running much faster than MacOS 14. We'll update our pipelines accordingly

Hey @Nathan-Molby!
I am glad it helped. 🎉
Trying to find a root cause. The only notable thing that was applied to the 20240922.1 image was Xcode platforms related change which was expected to affect only visionOS builds here: https://github.com/actions/runner-images/pull/10652. In general we have no control over simulator runtimes set since they came from Apple every time we build an image. Also I noticed that our tests are targeted on iPhone 16 simulator for iOS 18.0.

Also it would be very helpful if any of the participants could provide any project example to test on. Without an available project I can only check if the simulator is available and can be configured.
cc: @Nathan-Molby @Svantulden @shagedorn

Seeing the same on Azure Pipelines since 9/25


User log in

Two users can't sign-in to view their WebApp. I sent both of them the password reset link, but want to see if there are other technical issues beyond a password reset. I could send you their names and emails directly. Thank you.

@fourthletter I believe we have deployed code that fixes the main issue of people not being able to use the password reset form.
All users should now be able to use the password reset form themselves (they must first have clicked the activation link to activate their accounts).
If they say they can't find it (there is a link to it on the login form) it's usually easier to do it for them, as you have done, then try to direct them.


Flux Boundary condition support

Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to FESTIM?

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Code refactoring
[ ] Documentation Update (if none of the other choices apply)
[ ] New tests

Checklist

[ ] Black formatted
[ ] Unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@jhdark any update on this?

Yeah, for this PR, we kind of need the MMS testing to go through first to ensure the formulation of the fluxes is created correctly.

Yeah, for this PR, we kind of need the MMS testing to go through first to ensure the formulation of the fluxes is created correctly.

Ok, I'm working on the side to see how we can automate the MMS tests (the derivation part). Related to #663

@jhdark this is an example of MMS with fluxes

Branch too far behind


Trouble installing serialport on Debian/Beaglebone

SerialPort version: 1.7.4
NodeJS Version: v0.12.6
Operating System and Hardware: Debian / Beaglebone
Are you using Electron/Atom/NwJS?: No
NPM : 2.11.2
Python: 2.7.9
Also running NVM which manages another NodeJS version 6.4.0
Summary of Problem
Getting a build error from gyp:
serialport.target.mk:88: recipe for target 'Release/obj.target/serialport/src/serialport.o' failed
make: *** [Release/obj.target/serialport/src/serialport.o] Error 1
make: Leaving directory '/home/debian/node_modules/serialport/build'
gyp ERR! build error
gyp ERR! stack Error: make failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:276:23)
gyp ERR! stack     at emitTwo (events.js:106:13)
gyp ERR! stack     at ChildProcess.emit (events.js:191:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:204:12)
gyp ERR! System Linux 4.4.9-ti-r25
gyp ERR! command "/usr/local/bin/node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "build" "--fallback-to-build" "--module=/home/debian/node_modules/serialport/build/serialport/v1.7.4/Release/node-v48-linux-arm/serialport.node" "--module_name=serialport" "--module_path=/home/debian/node_modules/serialport/build/serialport/v1.7.4/Release/node-v48-linux-arm"
gyp ERR! cwd /home/debian/node_modules/serialport
gyp ERR! node -v v6.4.0
gyp ERR! node-gyp -v v3.3.1
gyp ERR! not ok
node-pre-gyp ERR! build error
node-pre-gyp ERR! stack Error: Failed to execute '/usr/local/bin/node /usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js build --fallback-to-build --module=/home/debian/node_modules/serialport/build/serialport/v1.7.4/Release/node-v48-linux-arm/serialport.node --module_name=serialport --module_path=/home/debian/node_modules/serialport/build/serialport/v1.7.4/Release/node-v48-linux-arm' (1)
node-pre-gyp ERR! stack     at ChildProcess. (/home/debian/node_modules/serialport/node_modules/node-pre-gyp/lib/util/compile.js:83:29)
node-pre-gyp ERR! stack     at emitTwo (events.js:106:13)
node-pre-gyp ERR! stack     at ChildProcess.emit (events.js:191:7)
node-pre-gyp ERR! stack     at maybeClose (internal/child_process.js:852:16)
node-pre-gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:215:5)
node-pre-gyp ERR! System Linux 4.4.9-ti-r25
node-pre-gyp ERR! command "/usr/local/bin/node" "/home/debian/node_modules/serialport/node_modules/.bin/node-pre-gyp" "install" "--fallback-to-build"
node-pre-gyp ERR! cwd /home/debian/node_modules/serialport
node-pre-gyp ERR! node -v v6.4.0
node-pre-gyp ERR! node-pre-gyp -v v0.6.7
node-pre-gyp ERR! not ok
Failed to execute '/usr/local/bin/node /usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js build --fallback-to-build --module=/home/debian/node_modules/serialport/build/serialport/v1.7.4/Release/node-v48-linux-arm/serialport.node --module_name=serialport --module_path=/home/debian/node_modules/serialport/build/serialport/v1.7.4/Release/node-v48-linux-arm' (1)
npm WARN enoent ENOENT: no such file or directory, open '/home/debian/package.json'
npm WARN debian No description
npm WARN debian No repository field.
npm WARN debian No README data
npm WARN debian No license field.
npm ERR! Linux 4.4.9-ti-r25
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "install" "--unsafe-perm"<EMAIL_ADDRESS>npm ERR! node v6.4.0
npm ERR! npm  v3.10.3
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>install: node-pre-gyp install --fallback-to-build
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node-pre-gyp install --fallback-to-build'.
Expected Behavior
I have serialport running on an rPi using SerialPort version: 1.7.4 and NodeJS Version: v0.12.6. I got a beaglebone shipped with Node 6.4.0 and it was failing trying to install serialport. So I tried NVM to install the version I have working on the rPi, v0.12.6. If I run node -v on the beaglebone, it tells me I'm running v0.12.6. However, when I run
sudo npm install --unsafe-perm<EMAIL_ADDRESS>I'm getting a build error. I'm not sure if the build process thinks I'm using Node 6.4.0. There is a line in the error:
gyp ERR! node -v v6.4.0
I've attached the log file.
Actual Behavior
Steps and Code to Reproduce the Issue
npm-debug.log.zip

There is this bit too in the failure output:
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node-pre-gyp install --fallback-to-build'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the serialport package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-pre-gyp install --fallback-to-build
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs serialport
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls serialport
npm ERR! There is likely additional logging output above.

It looks like I was able to fix this. I'm using xbee-rx which has a dependency for the<EMAIL_ADDRESS>version. I basically performed the steps from nathanielknopf from issue https://github.com/EmergingTechnologyAdvisors/node-serialport/issues/842.

installed node-pre-gyp with npm

changed the owner of ~/node_modules/ to the user rather than root
used git to clone the module from https://github.com/EmergingTechnologyAdvisors/node-serialport.git
npm install inside the node-serialport folder
moved the folder inside node_modules

In my case I just downloaded a 1.7.x version from
https://github.com/EmergingTechnologyAdvisors/node-serialport/releases?after=v2.0.1, compiled it and removed all other serialport directories before copying in the new compiled version.

I tried all of the options mentioned and I still keep getting: g++: internal compiler error: Segmentation fault (program cc1plus)
On Raspberry Pi B

gcc version 4.9.2 (Raspbian 4.9.2-10)

Ill try to downgrade the gcc if there is any change? I to have no idea how to get more useful information about what is wrong.

The BeagleBone appears to be configured incorrectly here. The account used for the logon appears to use Node.js v0.12.6 and the root account appears to use Node.js v6.4.0.

What is the output of the following commands?
node -v
sudo node -v


Bump version and update dependencies

Signed-off-by: Alex Co<EMAIL_ADDRESS>
Summary

Ticket:
What's Changed

Changed

Bump version to 1.0.2-hotfix1.
Update dependencies.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: onimsha
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: jk-gan, onimsha
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


apt-get update error

`apt-get update
...
...
已下载 28.5 MB，耗时 51秒 (556 kB/s)
(appstreamcli:702): GLib-CRITICAL **: 08:15:18.930: g_strchug: assertion 'string != NULL' failed
(appstreamcli:702): GLib-CRITICAL **: 08:15:18.931: g_strchomp: assertion 'string != NULL' failed
(appstreamcli:702): GLib-CRITICAL **: 08:15:18.986: g_strchug: assertion 'string != NULL' failed
(appstreamcli:702): GLib-CRITICAL **: 08:15:18.987: g_strchomp: assertion 'string != NULL' failed
(appstreamcli:702): GLib-CRITICAL **: 08:15:19.030: g_strchug: assertion 'string != NULL' failed
(appstreamcli:702): GLib-CRITICAL **: 08:15:19.031: g_strchomp: assertion 'string != NULL' failed
(appstreamcli:702): GLib-CRITICAL **: 08:15:19.127: g_strchug: assertion 'string != NULL' failed
(appstreamcli:702): GLib-CRITICAL **: 08:15:19.127: g_strchomp: assertion 'string != NULL' failed
** (appstreamcli:702): CRITICAL **: 08:15:23.160: Error while moving old database out of the way.
AppStream cache update failed.
正在读取软件包列表... 完成
W: https: aptMethod::Configuration: could not load seccomp policy: 无效的参数
W: store: aptMethod::Configuration: could not load seccomp policy: 无效的参数`

Provide Windows version and which Distribution are you running?

Windows: 1709  16299.371
Distributor ID: Ubuntu
Description:    Ubuntu Bionic Beaver (development branch)
Release:        18.04
Codename:       bionic

no wsl is only containers, there's no issues about appstream and seccomp. i suggest to remove appstream, since it's bionic you don't have worry about seccomp policy


feat(java): java package

Adds a Java package

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

LGTM, we'll need to update the documentation to include Java and .Net changes


server side external io api logic broken

currently impossible to override io.TransportAttach because ->context->rdp->transport is available only after freerdp_peer_context_new call, but inside of freerdp_peer_context_new transport_attach is called before any chance to override it, it is possible to create own implementation of freerdp_peer_context_new, but it will also add requirement for implementation of lot freerdp internals which is undesired and should be avoided if possible.

also looks like some  in some other places io descriptor used directly in server side (peer) code

looks like another task for me (.
ok, i am on it.

https://github.com/FreeRDP/FreeRDP/pull/6668 - started work here


root with empty password security vulnerability. How to change the default password?

It seems to me that the database root user with an empty password is a pretty big security vulnerability,
since many Linux distributions come with all ports open. Not only that but also other programs on the same machine can access the database easily if the password isn't changed (how to change the password programmatically btw?).
Thus I'd like to generate a random password by default for the root user instead of an empty password which then can be got programmatically like so:
Connection conn = DriverManager.getConnection(configBuilder.getURL(dbName), "root", configBuilder.getPassword("root"));

Otherwise being able to change the password for the root user programmatically via for example db.setRootPassword("pass") would be also great.

@Osiris-Team or anyone else reading along here: Pull Requests proposing to address this are most welcome!
If you would like me to make this fix for you, then please (README quote) support on OpenCollective, via GitHub Sponsoring or through a Tidelift subscription** to ensure active maintenance of this project used by hundreds, since 2011! 🫶


i18n(zh-cn): Update 0-introduction/1.mdx

Description (required)
Update 0-introduction/1.mdx

Related issues & labels (optional)

https://github.com/withastro/docs/pull/8239
Closes #
Suggested label:

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

zh-cn
tutorial/0-introduction/1.mdx
Localization changed, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


get_ecs() not operating as the relevant datum dict object key is "name", not "description"

Dear beautiful developers of Woltka,
Please note that using kegg_query.py returns empty mapping file for "ko-to-ec.txt".
This might be because the data's datum dict object containing the fetched KEGG info contains the E.C. value (parsed with function get_ecs()) under key "name", and not under "description" as is currently the case.
Example of datum for K0001:
{'name': 'alcohol dehydrogenase [EC:<IP_ADDRESS>]', 'pathway': ['map00010  Glycolysis / Gluconeogenesis', 'map00071  Fatty acid degradation', 'map00350  Tyrosine metabolism', 'map00620  Pyruvate metabolism', 'map00625  Chloroalkane and chloroalkene degradation', 'map00626  Naphthalene degradation', 'map00830  Retinol metabolism', 'map00980  Metabolism of xenobiotics by cytochrome P450', 'map00982  Drug metabolism - cytochrome P450', 'map01100  Metabolic pathways', 'map01110  Biosynthesis of secondary metabolites', 'map01120  Microbial metabolism in diverse environments', 'map01220  Degradation of aromatic compounds'], 'dblinks': ['RN: R00623 R00754 R02124 R04805 R04880 R05233 R05234 R06917 R06927 R07105 R08281 R08306 R08310', 'COG: COG0604 COG1028 COG1062 COG1063 COG1064 COG1454', 'GO: 0004022 0004023 0004024 0004025']}

no "description" key...

get_ecs() would do just fine using "name" key:
def get_ecs(definition):                              # proposal: def get_ecs(name):
    """Extract EC numbers from a KO definition.
    Parameters
    ----------
    definition : str                                  # proposal: name : str
        KO definition.                                # proposal: KO name including E.C. number.
    Returns
    -------
    list of str
        Extracted EC numbers.
    Examples
    --------
    K00930  acetylglutamate kinase [EC:<IP_ADDRESS>]
    K02618  oxepin-CoA hydrolase [EC:<IP_ADDRESS> <IP_ADDRESS>]
    K09866  aquaporin-4
    """
    if definition.endswith(']'):                      # proposal: if name.endswith(']'):
        idx = definition.find(' [EC:')                # proposal: idx = name.find(' [EC:')
        if idx > 0:
            return definition[idx + 5:-1].split()     # proposal: return name[idx + 5:-1].split()

Hi @FranckLejzerowicz thanks for analyzing and reporting this! Looks that there is update in KEGG format. I just edited the code according to your finding (here). It works now!

Thanks for operating this change so quickly, dear @qiyunzhu
This update might be the reason for another trouble that might necessitate action on your end:
the fetched ko-to-pathway.txt file provide maps from KO IDs, but only to map IDs, This is a problem for subsequent pathway-to-*.txt maps, that may rely on ko IDs, e.g.:
# [1] no mapping from "KO" to "ko" pathway IDs ...
$ grep -c "ko" ko-to-pathway.txt
0

# [2] ... as this map is for "KO"-to-"map" pathway IDs only
$ grep -c "map" ko-to-pathway.txt
3653

# [3] these "map" IDs then can be used to map pathways to "class" and "module"
$ grep -m 1 "map00010" pathway-to-* | cut -f 1,2,3
pathway-to-class.txt:map00010	Metabolism	Carbohydrate metabolism
pathway-to-module.txt:map00010	M00001	M00002

# [4] however, mapping files from pathways to "compound" (and back to "ko") only rely on "ko" inputs (which are not possibly obtained as per [1])
$ grep -m 1 "ko00010" pathway-to-* | cut -f 1,2,3
pathway-to-class.txt:ko00010	Metabolism	Carbohydrate metabolism
pathway-to-compound.txt:ko00010	C00022	C00024
pathway-to-ko.txt:ko00010	K00001	K00002
pathway-to-module.txt:ko00010	M00001	M00002

Note that the associated pathway_name.txt file is fine, as it seems to contains both map and ko entries, e.g.:
$ grep "00010" pathway_name.txt
ko00010	Glycolysis / Gluconeogenesis
map00010	Glycolysis / Gluconeogenesis

I tried to investigate to find out how to fix this but I am unsuccessful. Thanks for your help, for whomever willing to use pathway-to-compound.txt and pathway-to-ko.txt (i.e., probably not partocularly urgent).


swiftformat doesn't refer to .swiftformat config at root of my project

Hi, I've tried to apply swiftformat with .swiftformat config file at root of my iOS project, however it seems not to use the config. (e.g. intent level 4 is applied as default instead of 2 in my config file). Do you have any way to resolve config file path for the formatter?

Fixed in the above commit and tested that it works on my computer. Let me know if the fix doesn't work for you.

Thank you for your quick response! It works fine for me, too.


general code improvement

Ok this is a general improvement PR. A few things in this one.

Finally untangled the MempoolMap. The way it was done was really hard to understand. Now instead of keeping a hashmap of mempools in the runtime when that's not being used at all, it's just a vec. Only the builders need to borrow the vec as a hashmap temporarily.

Fixed the order of the EAL cleanup and make ports and mempools drop before the main runtime.

No longer exposing the Mempool struct outside the crate even for testing. Instead used a testils wrapper to hide the underlying DPDK structs. They expose too much internal functionalities and better to not be leaked.

yeah the lib needs more coverage. but too much of the code depend on ffi and not sure how best to test them. not the ideal way of doing things but we will need to revisit and beef that up for sure.


[Feature] 能否在个人首页上把Starred的项目列出来

Description
就是把标星的项目列出,我不清楚能否实现,加油!

Hi, @a15355447898a, did you mean show all projects you starred on you profile page, like this?

If so, I'm afraid that we won't adopt this idea since it is not so relevant to Hypercrx's purpose :)

You can refer to Refined GitHub, which is an amazing extension that improve your GitHub experience.

thanks


[joy-ui][Checkbox] fix text-align problem in RTL for  Checkbox.tsx

using the normal property : text-align: left for checkbox in RTL direction will cause the following problem : https://i.imgur.com/fWf6KQm.gif
solution: use a logical property instead
text-align : left ❌
text-align : start ✔
note: the same problem happens to radio buttons

[x] I have followed (at least) the PR section of the contributing guide.

This should not be the case. Follow this guide please: https://mui.com/material-ui/guides/right-to-left/

Oh, i only add rtl with document.dir = "rtl" ,  so do I have to follow all the steps? I thought I could pick one of those steps to get it working.

Oh, i only add rtl with document.dir = "rtl" , so do I have to follow all the steps? I thought I could pick one of those steps to get it working.

Yes, you must follow all the steps when using a Material UI component, with the exception of step 4, where you should instead follow the guidelines of the underlying styling engine you are using (Emotion or styled-components). Could we close this PR?


minor changes for IEEE SDN-NFV demo

-updated network graph in the web dashboard (sticky nodes)
-extra options to deploy dummygatekeeper (custom placement, bidirectional links)

Jenkins retest


Issues with window/frame sizes

This is a continuation of issue #207 on GLVisualize.jl, but I want to focus on its manifestation in MakiE so as to use the newest interfaces. To provide a step-by-step of what I've done so far:
julia> using MakiE

julia> scene = Scene()

This creates the following blank scene:

Using the scene.data dictionary, we can see the current parameters for the window and the frame:
julia> scene.data[:window_size]
2-element MakiE.ArrayNode{Int64,1,Base.#identity,GeometryTypes.Vec{2,Int64}}:
 840
 525

julia> scene.data[:window_area]
<Node: GeometryTypes.SimpleRectangle{Int64}(0, 0, 840, 525)>

julia> scene.data[:framebuffer_size]
2-element MakiE.ArrayNode{Int64,1,Base.#identity,GeometryTypes.Vec{2,Int64}}:
 1680
 1050

If I change the window size at all, the window seems to adjust to the correct size:

Not the most exciting visualization, but running the same Julia commands:
julia> scene.data[:window_size]
2-element MakiE.ArrayNode{Int64,1,Base.#identity,GeometryTypes.Vec{2,Int64}}:
 846
 530

julia> scene.data[:window_area]
<Node: GeometryTypes.SimpleRectangle{Int64}(0, 0, 1692, 1060)>

julia> scene.data[:framebuffer_size]
2-element MakiE.ArrayNode{Int64,1,Base.#identity,GeometryTypes.Vec{2,Int64}}:
 1692
 1060

The main observation here is that in the first case, window_area matches the value of window_size, but after resizing the frame, window_area matches framebuffer_size. I've tried to hunt down the logic for initializing and later updating window_area, since it seems to be the parameter linked to this behavior, but admittedly I'm kind of running in circles. Hopefully this is enough evidence to point to a culprit, and if there's more I can provide I'd be happy to do so.

Oh, another data point that might be useful. If we specific a resolution, for instance
julia> scene = Scene(resolution = (500,500))

The initial settings for the data entries above is:
julia> scene.data[:window_size]
2-element MakiE.ArrayNode{Int64,1,Base.#identity,GeometryTypes.Vec{2,Int64}}:
 500
 500

julia> scene.data[:window_area]
<Node: GeometryTypes.SimpleRectangle{Int64}(0, 0, 500, 500)>

julia> scene.data[:framebuffer_size]
2-element MakiE.ArrayNode{Int64,1,Base.#identity,GeometryTypes.Vec{2,Int64}}:
 1000
 1000

It would seem then that the frame is twice the dimensions it should be, if I'm understanding correctly. I've also seen a lot of adjustments in the code for macOS, which I'm using. Could it be something going wrong with that adjustment process, perhaps even something that's been changed recently in macOS?

yes! macos is special in this regard, and i was thinking i fixed it... i suspect there is a bug somewhere in the macos adjustment code.

I will happily be the guinea pig if you need a macOS system to test things on.

Great! Can you try the same with https://github.com/JuliaGL/GLWindow.jl/pull/51 ? I hope that fixes it.

I just tried after checking out the sd/makie branch of GLWindow and the behavior is the same. Are there particular tests I can run on my end that could help?

Thanks! I've added some debug statements to the sd/makie branch, if you could try them out :)

My new output:
julia> scene = Scene()
GLFW.GetFramebufferSize(window) = (1680, 1050)
fb_size = [1680, 1050]
Scene scene:
Dict{Symbol,Any} with 27 entries:
  :screen                => name: GLWindow…
  :mouse_button_released => <Node: 0>
  :mouse_buttons_pressed => <Node: Set{Int64}()>
  :time                  => <Node: 1.51035e9>
  :scroll                => <Node: [0.0, 0.0]>
  :buttons_pressed       => <Node: Set{Int64}()>
  :window_size           => <Node: [840, 525]>
  :window_area           => <Node: GeometryTypes.SimpleRectangle{Int64}(0, 0, 8…
  :theme                 => Scene: scene
  :cursor_position       => <Node: [0.0, 0.0]>
  :mouseinside           => <Node: true>
  :mouse_button_down     => <Node: 0>
  :mouseposition         => <Node: [0.0, 1050.0]>
  :arrow_navigation      => <Node: :nothing>
  :key_pressed           => <Node: false>
  :mouse2id              => <Node: [-1, -1]>
  :framebuffer_size      => <Node: [1680, 1050]>
  :button_down           => <Node: 0>
  :unicode_input         => <Node: Char[]>
  ⋮                      => ⋮

julia> scene.data[:window_size]
2-element MakiE.ArrayNode{Int64,1,Base.#identity,GeometryTypes.Vec{2,Int64}}:
 840
 525

julia> scene.data[:window_area]
<Node: GeometryTypes.SimpleRectangle{Int64}(0, 0, 840, 525)>

julia> scene.data[:framebuffer_size]
2-element MakiE.ArrayNode{Int64,1,Base.#identity,GeometryTypes.Vec{2,Int64}}:
 1680
 1050

Should I be seeing other debug messages?

Ah I think I know what it is. Please tell me that the newest commit at sd/makie fixes it! :P
https://github.com/JuliaGL/GLWindow.jl/commit/0fcefb3ce486563c1e3c200d4f5cf768b6fddee0

Looks the same, unfortunately. Again, I don't know if this helps to narrow things down, but I noticed that mouseposition is at (0.0, 1050.0), so at the full frame height. Is there some shared logic, or is mouseposition just reading the frame height after whatever code is causing the issue?

Ok, I think I've narrowed it down to a single operation! In GLWindow in screen.jl, the instance of push! with the dispatch of:
function Base.resize!(x::Screen, w::Integer, h::Integer)

seems to be causing the issue, as when I eliminate this line, I get a properly sized window. Specifically, within this function, the line:
push!(x.area, SimpleRectangle(area.x, area.y, w, h))

seems to trigger some re-evaluation of the window that causes the issue. Oddly, resizing with the GUI still works properly, so I'm guessing that operation uses another dispatch. I'll try to look into some of the callbacks, but hopefully this helps to get closer to a root cause.

Ah, is it the resize! in MakiE?

Thanks for the detective work, I will have a look... But I think it makes sense, that this messes things up...

On my Debian machine the initial window size corresponds to the size of the white (displayed area), changing the windowsize does not affect the size of the painted/white area.
On my OS X machine I have the same problem as OP, especially changing the windowsize does change (and fixes) the the size of the painted/white area.

Sorry, it's always annoying for me to work on osx issues, so I swiftly forgot about it altogether :D
Does https://github.com/JuliaGL/GLWindow.jl/pull/53 fix it?
Btw, I also found another bug in Makie which I just fixed, that if you don't close the window, resize won't work anymore. Haven't pushed it yet, since It's a bit intermingled with other, not yet working changes ...

I tried that branch, but I had to revert all the other graphics packages back to master to be able to do so, because it needs empty_shader_cache! from GLAbstraction. I didn't see a change, but is there some part of the fix that should be in the MakiE branches of this packages?

The list of packages has changed:
Pkg.clone("https://github.com/SimonDanisch/Makie.jl.git")
Pkg.checkout("GLAbstraction")
Pkg.checkout("GLVisualize")

# For UV examples, e.g. earth texture on sphere, or textured cat
Pkg.checkout("MeshIO")

# For image loading
Pkg.add("ImageMagick")

# For precompilation
Pkg.clone("https://github.com/SimonDanisch/PackageCompiler.jl.git")
Pkg.build("PackageCompiler")
Pkg.checkout("GLWindow")
```

Unfortunately not. Makie started to print a lot of "auto" though. ;-)

oh yeah, thought printing auto would change it :-P

I just submitted a pull request to the sd/osx branch with that I think is the solution. It looks like the final push! in the resize! function was still using the unscaled width and height, so I replaced that with the scaled values and everything seems to work properly. @mschauer, as a fellow macOS user, would you mind checking if that fix works for you too? https://github.com/JuliaGL/GLWindow.jl/pull/54

so you checked out the GLwindow thing, and no behaviour change!? i'm multiplying the resize resolution by a value, so it'd be weird if nothing at all happens. .

nevermind :-D thanks @crashburnrepeat!!
https://github.com/JuliaGL/GLWindow.jl/pull/54#issuecomment-346, so my change was well intended, but i had a typo^^

Works!

Awesome, I will be so happy to close this out/see it closed out once everything is merged!

A minor thing: If I create the window with scene = Scene(resolution = (400, 400)) now I get
julia> scene[:window_area]
<Node: GeometryTypes.SimpleRectangle{Int64}(0, 0, 800, 800)>

@mschauer, is this a breaking change for you? Overall though, I think it would help to go through the terminology in this package and straighten it out if needed. So far I've noticed window, frame, scene, screen, and I think I saw billboard mentioned on another issue. Perhaps these are all distinct, but I'm not sure I understand what that distinction is. I mention this all because I'm not sure what window is meant to represent conceptually, and if window_size and window_area should be different or not. Between these and framebuffer_size, it does seem like one is superfluous.
@SimonDanisch, is there anything holding up getting the osx branch and my changes to it merged into master?

No problem caused by that at all, I just reported it because it surprised me.


Try docker-compose 2.6.0 in a test run

The Problem/Issue/Bug:
docker-compose 2.6.0 was released
How this PR Solves The Problem:
Try it out in test run

It's good that this passes. I'm not sure we need to update at this point.


Include unit tests and add CBOR type helpers

Two commits here (which shouldn't be squashed into one):
The first enables unit tests, converting UtilTest into the first test that may be run outside of an Android device.
The second commit adds type coercion helpers for string and integer DataItems

I have a pretty big revision to this PR incoming. Heads up -- just ignore it in the present state :)


forCustomChain is not a function

Hi,
I'm following this example https://github.com/ethereumjs/ethereumjs-tx/blob/9a6324f64f4da1cb550a3eec4eaef95da4ab441b/examples/custom-chain-tx.ts to try to get a tx for a private network.
My code is:
const Tx = require('ethereumjs-tx').Transaction; const Common = require('ethereumjs-common') const customCommon = Common.forCustomChain(   'mainnet',   {     name: 'my-network',     networkId: 8995,     chainId: 8995,   },   'petersburg', )
If I try a console.log(Common) forCustomChain seems to be a function but when trying to execute the js file it shows an error forCustomChain is not a function...
Any help is appreciated
Guillermo

Okey I solved it by using Common.default.forCustomChain...maybe you have to change it in the example ;)


Refactor ASM Main UI component.

The main UI component is getting large.  Consider breaking it apart by creating one component for  "asm emulation" state
Styling need:
We will add a component for the customer emulation state.  This will add a tag that will replace a styled div.  We need to make sure the style is properly "migrated" to the new tag.

PR: #5223

To test: Make sure there is no regression in the Asm UI in the state where a customer emulation is in process.
You should see the customer name and email + the "End Session" button.

Tested on dev10. Looks good.


fix: disable text selection on all plot elements by default

Closes: https://github.com/zakodium/react-plot/issues/273

What about the Text Annotation ? https://zakodium.github.io/react-plot/?path=/story/api-annotations--annotation-text. I think it should also be non selectable.

You need to test with the preview link, not the live site.

Text annotations are not selectable here: https://deploy-preview-274--react-plot.netlify.app/?path=/story/api-annotations--annotation-text


YE #8 to send Wednesday 12/30

Final copy lives here:
https://docs.google.com/document/d/1lPMCaO83_QqL5vJG9w2ClkqC6943OHtiTbRX0dx3jnM/edit?pli=1
Segmented outreach to: 1) donors (giving last 36 months) and 2) non-donors (no giving history last 36 months). Omit civi group "Do Not Email YE 2015" from both segments.
Please send tests to Rebecca, Ryan, Tim, and Trilogy for advance review.

This is now queued.


Text field of showDatePicker() only allows numbers to be entered on some devices

Steps to Reproduce

Open a showDatePicker() (all default settings apart from colour changes):

Press the pencil icon to obtain the text entry option:

Expected results:
The input keyboard should have an option to add forward slashes to the text field across all devices.
Actual results:
The above screenshots show a Nexus 5X Emulator device (running Android 10) working as intended. However, on some devices, such as the Samsung Note 10+ (also running Android 10), the input keyboard displayed only gives the option of entering numbers:

Open a showDatePicker():

Press the pencil icon to obtain the text entry option:

Due to this restricted number input on some devices, only entering numbers into the text field returns an Invalid format. error in the UI.

Logs

[√] Flutter (Channel beta, 1.22.1, on Microsoft Windows [Version 10.0.19041.508], locale en-GB)
    • Flutter version 1.22.1 at C:\Flutter\flutter
    • Framework revision f30b7f4db9 (6 days ago), 2020-10-08 10:06:30 -0700
    • Engine revision 75bef9f6c8
    • Dart version 2.10.1

[√] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at C:\Users\User\AppData\Local\Android\sdk
    • Platform android-29, build-tools 29.0.3
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[!] Android Studio
    • Android Studio at C:\Program Files\Android\Android Studio
    X Flutter plugin not installed; this adds Flutter specific functionality.
    X Dart plugin not installed; this adds Dart specific functionality.
    • android-studio-dir = C:\Program Files\Android\Android Studio
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[√] VS Code (version 1.50.0)
    • VS Code at C:\Users\User\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.13.1

[√] Connected device (3 available)
    • Web Server (web) • web-server • web-javascript • Flutter Tools
    • Chrome (web)     • chrome     • web-javascript • Google Chrome 85.0.4183.121
    • Edge (web)       • edge       • web-javascript • Microsoft Edge 86.0.622.38

! Doctor found issues in 1 category.

I should add that due to the restricted number input on some devices, only entering numbers into the text field returns an Invalid format. error in the UI.

Closing this as duplicate of 62401

Thanks, didn't see that issue in my search prior to posting.


Fix Required Receipt Translations

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/43939
PROPOSAL: https://github.com/Expensify/App/issues/43939#issuecomment-2176845081
Tests

[X] Verify that no errors appear in the JS console

Precondition : As a admin set up expense violation as " Receipt required amount" to "0" in OldDot control policy

Invite an employee to the above policy
As a employee submit a report without receipt
As an admin open the report submitted
Validate that the correct translation is shown ("receipt required").

Offline tests

Same as tests
QA Steps

Same as tests
PR Author Checklist

[X] I linked the correct issue in the ### Fixed Issues section above
[X] I wrote clear testing steps that cover the changes made in this PR

[X] I added steps for local testing in the Tests section
[X] I added steps for the expected offline behavior in the Offline steps section
[X] I added steps for Staging and/or Production testing in the QA steps section
[X] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[X] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[X] I included screenshots or videos for tests on all platforms
[X] I ran the tests on all platforms & verified they passed on:

[X] Android: Native
[X] Android: mWeb Chrome
[X] iOS: Native
[X] iOS: mWeb Safari
[X] MacOS: Chrome / Safari
[X] MacOS: Desktop

[X] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[X] I followed proper code patterns (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[X] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[X] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I followed the guidelines as stated in the Review Guidelines
[X] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] I verified that if a function's arguments changed that all usages have also been updated correctly
[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[X] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[X] I verified that all the inputs inside a form are aligned with each other.
[X] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

I also modified the spanish translations to match the table here https://github.com/Expensify/App/pull/33969#discussion_r1493071149
Output:

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@abzokhattab Do you have any idea why the expected behavior here not mention category name on the Spanish translation while we mention it on English translation

Asking here https://github.com/Expensify/App/pull/33969#discussion_r1653162728

@abzokhattab We need to remove the category name from translations based on this https://github.com/Expensify/App/pull/33969#discussion_r1653273027. We exactly need to remove it from English translation, Spanish translation already don't have category name.

@puneetlath
FYI, we do two changes here

fix https://github.com/Expensify/App/issues/43939
remove the category name from the English translation to be the same as in Spanish translation based on here https://github.com/Expensify/App/pull/33969#discussion_r1653273027.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/cead22 in version: 9.0.4-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Cherry-picked to staging by https://github.com/tgolen in version: 9.0.4-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Continuing Charges on defenses

Force Field (57 PD/56 ED/15 MD/15 POW), Hardened (+1/4), Reduced Endurance (0 END; +1/2) (378 Active Points); 1 Recoverable Continuing Charge lasting 1 Minute (Recoverable, Continuing, -1/2)
REF: Malnachar Lars Orc Servant

This works for Active Effects.  But Force Field is not implemented as an Active Effect.  Perhaps all defenses should be AE, so we can track these types of things.


concat" mode can only merge layers with matching output shapes

Hi Thibault,
Congrats on reimplementing DenseNets in Keras!
I am trying to run your code locally (run_cifar10 in densenet) using Theano and I am getting an error:
Using Theano backend.
Traceback (most recent call last):
File "/home/piotr/workspace/DeepLearningImplementations/DenseNet/run_cifar10.py", line 43, in
weight_decay=weight_decay)
File "/home/piotr/workspace/DeepLearningImplementations/DenseNet/densenet.py", line 99, in DenseNet
weight_decay=weight_decay)
File "/home/piotr/workspace/DeepLearningImplementations/DenseNet/densenet.py", line 58, in denseblock
x = merge(list_feat, mode='concat', concat_axis=1)
File "/usr/local/lib/python2.7/dist-packages/Keras-1.1.0-py2.7.egg/keras/engine/topology.py", line 1528, in merge
name=name)
File "/usr/local/lib/python2.7/dist-packages/Keras-1.1.0-py2.7.egg/keras/engine/topology.py", line 1186, in init
node_indices, tensor_indices)
File "/usr/local/lib/python2.7/dist-packages/Keras-1.1.0-py2.7.egg/keras/engine/topology.py", line 1253, in _arguments_validation
'Layer shapes: %s' % (input_shapes))
Exception: "concat" mode can only merge layers with matching output shapes except for the concat axis. Layer shapes: [(None, 3, 32, 16), (None, 3, 32, 12)]
Any idea why it is crashing?
Many Thanks!

@tdeboissiere  Just wanted to say that the same error persists when using tensorflow backend

Hi, tdeboissiere, thank you very much for your contributions!
I have the same issue as SnowRipple (using Tensorflow backend), any ideas how to fix it?
Thank you very much!

The only way I was able to reproduce your issue was by modifying the keras.json file in the ~/.keras folder.
With:
{ "image_dim_ordering": "th", "epsilon": 1e-07, "floatx": "float32", "backend": "theano" }
it compiles without any issue
With:
{ "image_dim_ordering": "tf", "epsilon": 1e-07, "floatx": "float32", "backend": "theano" }
I get the same error as you.
I'm going to modify the code to avoid the hassle of figuring which config to choose.

Just tried it out. Model builds without problems! Thank you very much!
This is the one gripe I have with Keras - it is not fully independent of the backend...
Thank you very much for your time.
Veit

Cool !
Closing


https://docs.google.com/spreadsheets/d/e/2PACX-1vQ5ncF4fUVaWp-PlXXvRC…

…eAKw1Em-36g9q6P7Wob-A-_XbhhKSc7F7UVB_gh7bHfMFjZixPiZNOXBr0/pubhtml

Sorry, I think this must have been a mistake!


drivers : ethernet : snps dwcxgmac: added Synopsys dwcxgmac ethernet driver

Integrate support for the Synopsys XGMAC Ethernet controller, present in the Intel Agilex5 SoC FPGA. The DWC-XGMAC driver manages and uses a zero-copy strategy. the MAC and the DWC-XGMAC MDIO driver manage the attached PHY in the respective XGMAC's MDIO interface.
Developed within the Intel Simics® Simulator target, the driver accommodates the Marvell 88E1518 PHY simulated by Intel Simics® Simulator.
Presently, the Ethernet driver enables both transmit and receive functionalities, utilizing the hardware's scatter-gather DMA. However, certain features such as timestamping, VLAN, TSN support, and other minor aspects remain unimplemented despite being supported by the hardware.
Supports :

Tx and Rx, multiple Tx and Rx DMA channels, multiple Tx and Rx queues
Check Sum Offloading on Tx and Rx for IPv4, IPv6, TCP, UDP, and ICMP packets
10M/100M/1G speeds, Autonegotiation, Link speed configuration, Promiscuous mode, Full/Half duplex configuration
It supports clause 22 of IEEE 802.3 for ethernet PHY devices management.

Added Agilex5 SOCDK board support for echo client and echo server socket applications.
Signed-off-by: Santosh Male<EMAIL_ADDRESS>

how common is this and the eth_dwmac driver?

how common is this and the eth_dwmac driver?

Although dwmac and dwxgmac are from Synopsys, their feature set, registers, and DMA descriptors format are different.

Some initial comments. I have to say that this was slightly hard to review because of long lines and fully packed code.

I regret any inconvenience caused :-( .  Kindly provide your feedback where applicable, and I will make the required adjustments based on your review remarks.

hard to follow, huge commit at once is rarely a good idea.
Just a semantic detail: when you allocater buffer to a net_pkt, talk about buffer (or buf) not frag. Or in receive for instance (I know, net_buf use 'frags' instead of 'next' but that's another issue.) It's ok to use frag when sending.

Apologies for any inconvenience or confusion. I've substituted "buff" with "frag" on the receiving side.

Apologies for the delay in addressing the comments. Initially, this driver was tested on a simulator platform (Intel Simics® Simulator.) closely resembling the actual XGMAC hardware. Currently, I'm in the process of testing the driver on a real hardware development kit. During this phase, I've come across few issues that I'm actively debugging and resolving.

Apologies for the delay in addressing the comments. Initially, this driver was tested on a simulator platform (Intel Simics® Simulator.) closely resembling the actual XGMAC hardware. Currently, I'm in the process of testing the driver on a real hardware development kit.

Should reviewers revisit this PR now or wait for you to follow up after testing? Note it also needs to be rebased and merge conflicts resolved.

Apologies for the delay in addressing the comments. Initially, this driver was tested on a simulator platform (Intel Simics® Simulator.) closely resembling the actual XGMAC hardware. Currently, I'm in the process of testing the driver on a real hardware development kit.

Should reviewers revisit this PR now or wait for you to follow up after testing? Note it also needs to be rebased and merge conflicts resolved.

This Driver is now tested on Agilex 5 premium devkit https://www.intel.com/content/www/us/en/content-details/815177/agilex-5-fpga-e-series-065b-premium-development-kit-product-brief.html
For all the reviewers Please continue the review.  Thanks everyone for the support.

Hi @rlubos , I have no idea why this error is happening here. Please help me to fix this error.
BabbleSim Tests / bsim-test (pull_request) Failing after 5m error "OSError: Error reading file './twister-out/twister.xml': failed to load external entity "./twister-out/twister.xml"

Hi @rlubos , I have no idea why this below error is happening here. Please help me to fix this error. BabbleSim Tests / bsim-test (pull_request) Failing after 5m error "OSError: Error reading file './twister-out/twister.xml': failed to load external entity "./twister-out/twister.xml"

It looks like some environmental issue, I don't see how your PR could affect that job. It seems to be working fine in other PRs, so it's likely not broken. I'd simply try a rebase.

Hi @rlubos , I have no idea why this below error is happening here. Please help me to fix this error. BabbleSim Tests / bsim-test (pull_request) Failing after 5m error "OSError: Error reading file './twister-out/twister.xml': failed to load external entity "./twister-out/twister.xml"

It looks like some environmental issue, I don't see how your PR could affect that job. It seems to be working fine in other PRs, so it's likely not broken. I'd simply try a rebase.

Okay, I did sync this branch to the latest changes in the main. Now all checks are passing

Hi @rlubos @nashif @decsny @tbursztyka @jukkar and all other reviewers please review this PR and approve.

ping

LGTM, @Smale-12048867 please fix the merge conflict

Hi @Jukka. I am very Thank full :-) to you for valuable time to review and approve my driver.  I have resolved the merge conflicts please reapprove the PR.

Hi @rlubos @nashif @decsny @tbursztyka and all other reviewers please review this PR and approve.

Hi @rlubos @nashif @decsny @tbursztyka and all other reviewers please review this PR and approve.
@jukkar I have resolved the merge conflicts. please reapprove this PR.

Could someone please merge this PR?

Hi @nashif @rlubos @jukkar Please merge this PR

@Smale-12048867 the assignee needs to approve this PR before it can be merged

Hi @pdgendt I have updated the changes requested.
Hi @nashif @jukkar @rlubos please reapprove the PR.
Thank you :-)

@jukkar @nashif Could you please reapprove the PR? Previous approvals were dismissed with a recent force push update.


Add API to allow publishing of arbitrarily long messages

Having to modify the library to publish big messages is annoying, and having to keep a complete copy of the message in memory before it's sent also chews through a fair bit of memory.
We could add a new publish API, based on the UDP API in the core Arduino one, which has start and end functions, with any number of writes in between.
This might help mitigate issues #103 and #405 (I did think of commenting on those but they don't quite seem to match this)

I've got a working implementation, which I'll submit a pull request for shortly (I'd have sent it straight off, but realised I should create an example sketch to show it in use too).