[PDI-15982] Incomplete/Missing logs when Main Job with sub jobs are s…

…cheduled

add buffer for LogChannelFileWriter
do not remove channels from LoggingRegistry that are write logs to files

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f core/build.xml clean-all resolve jacoco && ant -f core/build.xml checkstyle publish-local
ant -Dtestreports.dir=bin/reports/unit-test -f engine/build.xml clean-all resolve jacoco && ant -f engine/build.xml checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  core/src/org/pentaho/di/core/logging/LogChannel.java
  core/src/org/pentaho/di/core/logging/LogChannelFileWriterBuffer.java
  core/src/org/pentaho/di/core/logging/LoggingRegistry.java
  core/test-src/org/pentaho/di/core/logging/LogChannelFileWriterBufferTest.java
  core/test-src/org/pentaho/di/core/logging/LoggingRegistryTest.java
  engine/src/org/pentaho/di/core/logging/LogChannelFileWriter.java
  engine/src/org/pentaho/di/www/CarteSingleton.java
  engine/test-src/org/pentaho/di/core/logging/LogChannelFileWriterTest.java

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.core.logging.KettleLogLayout

Branch Change:  + 7.69%
Complexity Change:  + 4.76%
Instruction Change:  + 5.97%
Line Change:  + 4.17%

org.pentaho.di.core.logging.LogChannel

Branch Change:  + .85%
Complexity Change: -.56%:small_red_triangle_down:
Instruction Change:  + .54%
Line Change:  + .48%

org.pentaho.di.core.logging.LogChannelFileWriterBuffer

Branch New Coverage: 100.00%
Complexity New Coverage: 100.00%
Instruction New Coverage: 88.10%
Line New Coverage: 100.00%
Method New Coverage: 100.00%

org.pentaho.di.core.logging.LoggingRegistry

Branch Change:  + 4.21%
Complexity Change:  + 5.12%
Instruction Change:  + 7.21%
Line Change:  + 4.97%
Method Change:  + 5.61%

org.pentaho.di.core.auth.core.impl.DefaultAuthenticationConsumerFactory

Branch Change: -7.14%:small_red_triangle_down:
Complexity Change: -7.69%:small_red_triangle_down:

org.pentaho.di.core.logging.LogChannelFileWriter

Complexity Change:  + 21.43%
Instruction Change:  + 40.00%
Line Change:  + 41.86%
Method Change:  + 21.43%

org.pentaho.di.job.entries.evalfilesmetrics.JobEntryEvalFilesMetrics

Branch Change: -.39%:small_red_triangle_down:
Complexity Change: -.51%:small_red_triangle_down:
Instruction Change: -.08%:small_red_triangle_down:

org.pentaho.di.job.entries.sql.JobEntrySQL

Instruction Change: -3.28%:small_red_triangle_down:
Line Change: -3.87%:small_red_triangle_down:

org.pentaho.di.job.entries.waitforsql.JobEntryWaitForSQL

Branch Change: -.66%:small_red_triangle_down:
Complexity Change: -.93%:small_red_triangle_down:
Instruction Change: -.13%:small_red_triangle_down:

org.pentaho.di.trans.step.StepMeta

Branch Change:  + .68%
Complexity Change:  + .58%
Instruction Change:  + .19%
Line Change:  + .26%

org.pentaho.di.trans.steps.calculator.CalculatorMetaFunction

Branch Change:  + 8.70%
Complexity Change:  + 3.08%
Instruction Change:  + .75%
Line Change:  + .89%

org.pentaho.di.trans.steps.combinationlookup.CombinationLookupMeta

Instruction Change:  + .04%

org.pentaho.di.trans.steps.csvinput.CsvInputMeta

Instruction Change:  + .05%

org.pentaho.di.trans.steps.groupby.GroupByMeta

Branch Change: -1.04%:small_red_triangle_down:
Complexity Change: -1.05%:small_red_triangle_down:

org.pentaho.di.trans.steps.singlethreader.SingleThreaderMeta

Instruction Change: -.10%:small_red_triangle_down:

org.pentaho.di.trans.steps.synchronizeaftermerge.SynchronizeAfterMergeMeta

Instruction Change:  + .04%

org.pentaho.di.trans.steps.systemdata.SystemDataMeta

Branch Change:  + 2.04%
Complexity Change:  + 2.04%
Instruction Change:  + .32%
Line Change:  + .81%

org.pentaho.di.trans.steps.textfileinput.TextFileInputMeta

Branch Change:  + .53%

@mchen-len-son @mbatchelor @e-cuellar please review.


Configure user avatar

I would love for plasma-manager to have an option for setting the user avatar. It's not the highest priority, but it's just a nice addition.
After a small bit of research & testing (credit to this post https://superuser.com/a/1772789), the user avatar is stored at /var/lib/AccountsService/icons/<username> as a 256x256 PNG file (with no file extension).
I'm not sure how this would be implemented in a reproducible fashion, unless a hash for the PNG file could be used to check against (similar to how nixpkgs works). Furthermore, i don't have any experience with the plasma-manager code-base, but i would be happy to give implementation a go if i am pointed in the correct direction.

Here's an example of how you can add a custom option like user.user.[userName].icon directly to your NixOS configuration:
GitLab Example - User Icon
This demonstrates how to extend the NixOS module system to include custom options. In this case, it shows how to define a icon setting within the user configuration. You can use this approach to add similar features to your repository, making it easier to manage custom options directly in your NixOS setup.


Add tag extensions

These extensions allow you to do conditional tag values and tag value replacing (replace tag in tag JSONs).
Note: I haven't tested these yet.

What would a tag using this look like?

{
  "replace": false,
  "values": ["vanilla values here"],
  "libcd": {
    "replace": { "optional replace block": "with a condition" },
    "entries": [{
      "when": [{ "libcd:mod_loaded": "lil-tater" }],
      "values": ["lil tater values here"]
    }]
  }
}

libcd.replace only clears existing entries from other datapacks (like vanilla), leaves the vanilla entries in the same json intact
libcd.replace can also be an array where all conditions must be true
Each entry (libcd.entries) has its own values and a list of conditions (all must be true so that the values are added)

That'd be neat.

@Juuxel Is there anything needed for these other than testing, currently?

There shouldn't be anything other than testing left now.

Alright! I'll give it a try soon.

This is looking good! Thank you so much!


Add pthread unconditionally for linux builds

I am in the process of adding address sanitizer sanitizer jobs to ROS2 CI buildfarm: https://github.com/ros2/ci/pull/245 and I am trying to get the sanitization working with the cmake flags "-fsanitize=address". However it turns out that address sanitizer itself provides a "fake" pthread that tricks the pthread detection logic into thinking no link libraries are necessary (More info on https://wiki.gentoo.org/wiki/AddressSanitizer/Problems#pthread_linking_issues)
Do you think we can add pthread as a compulsory build flag for linux? Something similar has been done in the osrf_testing_tools_cpp package and googletest to fix the sanitizer issue

Opened a PR to add pthread as a link library based on a new option "SANITIZER_ENABLED". Here's  the PR for the same: https://github.com/eProsima/Fast-RTPS/pull/431. Kindly take a look.


[python] Update tiledbsoma dependency to tiledbsoma==1.4.0

@pablo-gar, AFAIK, you fixed this in #709.  Can this issue be closed?

Yes!


[Authorization] AuthorizationService should use provider's canLookupAsync method

Motivation
The AuthenticationService essentially implements the canLookupAsync method instead of relying on the provider's canLookupAsync method.
Before this change, the AuthenticationService was essentially calling provider.canConsume and provider.canProduce in order to determine if the role had sufficient permission to lookup. While the logic should be sufficient, it wasn't the correct implementation because the provider has a canLookup method that ought to be used.
Modifications

Modified AuthenticationService method canLookupAsync to first check if the role is a super user and then call the configured provider's canLookupAsync method. Note that this implementation follows the same paradigm as canProduceAsync and canConsumeAsync in the AuthenticationService.
Clean up the PulsarAuthorizationProvider implementation of canLookupAsync to improve readability.

Verifying this change
This change is already covered by existing tests, such as the AuthorizationTest.
Does this pull request potentially affect one of the following parts:
This test could result in a change of behavior for users that have implemented their own AuthorizationProvider. The PulsarAuthorizationProvider is not affected because its logic was equivalent before and after this change.
Documentation
For contributor
For this PR, do we need to update docs?
It's possible we'll want to update docs or to include a note about this fix for users who are upgrading. The main change in behavior is for users with a custom AuthorizationProvider.
For committer
For this PR, do we need to update docs?

If yes,

if you update docs in this PR, label this PR with the doc label.

if you plan to update docs later, label this PR with the doc-required label.

if you need help on updating docs, create a follow-up issue with the doc-required label.

If no, label this PR with the no-need-doc label and explain why.

@michaeljmarshall if it is a major change or affects how to use this feature, maybe you add a note about the previous usage and current changes here?

@Anonymitaet - I don't classify this as a major change. It is a correction in behavior. I think it only needs to be documented in the release notes. @eolivelli - do you have any insight here?

it's not a major change or api change so, it won't require documentation.


In the list of excluded endpoints, add also the endpoints that depend on updated endpoints

FinRegisty results are not shown for excluded endpoints, which includes endpoints with changed definitions. Also, endpoints that depend on an endpoint changed endpoint need to be excluded.

Make this comparison between FinnGen R9 endpoint definitions and the version of endpoint definitions that are used to generate FinRegistry results.
Note, that the non-core endpoints of FinnGen (R9) and omitted endpoints of FinRegistry (R8) are not the same. For example, “Atrial fibrillation and flutter”, I9_AF, is not omitted from FinRegistry analyses but based on FinnGen R9 changes it’s a non-core endpoint.


Update B-Harvest.toml for testnet-15

Description
All previous genesis validators should name their PRs "Update {validator_alias}.toml for tesntet-15" and provide links to previous PRs merged.
#67
#118
#507
#631
#1069
#2299
If this is an UPDATE for a previous genesis validator
Checks are made against your net_address. If this has changed since the previous testnet, make sure you provide links of previous prs merged from your previous git username.
Thanks in advance!
Checklist before merging

[O] Only one toml is added in this PR
[O] The file being added is indeed a .toml file
[O] The toml being added is to the correct folder, and only to the correct folder
[O] The eth_hot_key and eth_cold_key are present
[O] The email, discord, elements telegram, and twitter fields are present and valid

Successfully validated transactions.toml file for commit hash eaef521


pass cost

After merging #414 I would use set_x/y as a standard way to pass custom cost matrices (as opposed to obsp). Hence, I would also change the default for the generic GWProblem and FGWProblem to pointclouds.


Integrate LLVM at llvm/llvm-project@08163cd9d82690e808c28515523b5fd0923d7b38

Can you update the title to Integrate LLVM at llvm/llvm-project@xxxxxxx?

Can you update the title to Integrate LLVM at llvm/llvm-project@xxxxxxx?

done!


Issue #3, changes in the operator + of the iterator class

This patch includes the following two changes:

Override operator+(difference_type, const ordered_iterator&) which is required in a random access iterator.
Remove operator+(const ordered_iterator& lhs, const ordered_iterator& rhs), which is not a standard operator in iterators.

Thank you for the correction!
I added some tests (forgot to test this part) and merged the changes.

No problem


add support for updating the auth token on upload

Description
add support for updating the auth token on upload
Spec
See Ticket: EDPUB-1239

Validation
PR paired with:https://github.com/eosdis-nasa/earthdata-pub-forms/pull/37

Make sure all merge request checks have passed (CI/CD).
Pull related branches locally.
Create a submission.
Using inspect element check the bearer token of any api call and take a not of part of the token.
Try to upload a file using the dashboard.(this should fail)
Confirm the bearer token used to upload is different than the one noted earlier.
Try to upload a file in the forms.(this should fail)
Confirm the bearer token used to upload is different than both tokens user earlier.

Change Log
add support for updating the auth token on upload

[Add _____](link to commitid)
[Fix _____](link to commitid)

Does the refresh call complete for you locally? For me it hangs in both the dashboard and forms so I never see the new token


Error downloading video (command failed with exit code 1)

Describe your bug
Error downloading https://www.youtube.com/watch?v=-xJ0g1w0f4I
error.js:60 Uncaught (in promise) Error: Command failed with exit code 1: C:\Program Files\WebDL\resources\app\.webpack\renderer\main_window/native_modules/ffmpeg.exe -loglevel 8 -hide_banner -i pipe:4 -i pipe:5 -map 0:a -map 1:v -c:v copy -y C:\Users\Timber\Desktop\Family Guy - I did see Fargo.mkv
    at t.exports (error.js:60)
    at index.js:118
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:95)
t.exports @ error.js:60
(anonymous) @ index.js:118
processTicksAndRejections @ internal/process/task_queues.js:95

Issue is solved in latest commit f7441845919ab51f0b6f2f2f41b1a638c8c19042, videos whose id started with a - were interpreted as options by the downloader


Special cases: web scrapped data

example:
dataset:
  name: &name foodbankny_foodbanks
  version: "{{ version }}"
  source:
    module: foodbankny_foodbanks
    options:
      - "AUTODETECT_TYPE=NO"
      - "EMPTY_STRING_AS_NULL=YES"
    geometry:
      SRS: EPSG:4326
      type: POINT
...

we will use importlib to dynamically import module_source
import importlib
module_name = 'foodbankny_foodbanks'
module = importlib.import_module(module_name, package=None)

This module will have 1 function interface called run which will export data out via stdout.
and gdal will ingest this data using vsistdin
https://gdal.org/user/virtual_file_systems.html#vsistdin-standard-input-streaming
if this is difficult to implement, we can just use tempfiles, we will write to tempfile, then gdal will pick up from a tempfile

it might be useful to have a master class that's called Special so that each class can be a subclass, which inherits useful functionalities like writing to a tempfile
class foodbankny_foodbanks(Special):

# Sample usage:
foodbankny_foodbanks.run() # executes data scrapping
foodbankny_foodbanks.url() # outputs temporary location, this is a method inherited from Special
foodbankny_foodbanks.version() # Outputs version, we can either inherit this from Special (default) or compute the version

it might be useful to have a master class that's called Special so that each class can be a subclass, which inherits useful functionalities like writing to a tempfile
class foodbankny_foodbanks(Special):

# Sample usage:
foodbankny_foodbanks.run() # executes data scrapping
foodbankny_foodbanks.url() # outputs temporary location, this is a method inherited from Special
foodbankny_foodbanks.version() # Outputs version, we can either inherit this from Special (default) or compute the version

Will this class also include cases where we have to parse excel files and convert to csv?

Will this class also include cases where we have to parse excel files and convert to csv?

yeah, basically this class will have a run function that gets the data one way or another, then get passed into gdal

yeah, basically this class will have a run function that gets the data one way or another, then get passed into gdal

implemented


Opt-In Telemetry, Security Patching and Environment Dumps

Is your feature request related to a problem? Please describe.
Allowing users to opt-in to telemetric submission will help the core team figure out how tauri is being used in devland. Making the approach public will help devland know how their users are getting on with Tauri apps.
Describe the solution you'd like
I think there is a good start here:
https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby-telemetry/src/index.js
Combined with antivuln, it would be an excellent way for us to provide an additional service layer for those who want us to manage their security. Before you laugh and say I would never do that, just stop and think for a moment about how much work it is to stay on top of dependencies in today's development environment.
Additional context
I think in combination with #57 and our internal discussions about providing some kind of tauri interface like:
$ tauri audit

Which would dump everything known about the system - then I think we'd have a nice robust turn-key system that provides elegant solutions to helping developers stay safe in the semi-hostile environment of thousands of node modules and hundreds of crates and a variety of runtimes.

Some of this can happen with the testing.  Adding logging and telemetry via our core library is also possible though it would be easier after we rewrite some of the core functions to be more composable. The more composable the functions are, the easier it would be to chain these kinds of services through them.  I could probably do a few mock ups after I finish with the refactor and testing stuff that I am working on.

Currently looking at rust telemetry libraries such as this: https://github.com/open-telemetry/opentelemetry-rust

https://research.swtch.com/telemetry-intro

After reading that HN thread I kinda feel people are missing the point of these telemetry features in software, its not about collecting usage and "engagement data" which IMO is the kind of data that's hart to interpret and even when interpreted right often largely useless outside of "line go up" presentations.
But the second kind of data, more targeted around a specific feature is incredibly useful, like how many people are using allowlist: { all: true } across apps or how many people still use deprecated functions. Telemetry like this is what helps browsers be such reliable platforms. So IMO this all boils to what data one collects and how it's communicated (as always in life).


LangChain4JAIServicePortableExtension#processInjectionPoint should treat programmatic lookup differently

Following code is IMO wrong in how it treats programmatic lookup.
One valid type of injection point in CDI is Instance<X>. In this case, the aforementioned code should detect that and based on desired behavior either skip it or perform its logic on the inner X type.
Note that with an Instance<X>, you cannot be sure the user will actually attempt to resolve the X at runtime; instead, they might perform Instance#select() and resolve a subtype instead or not use it at all.

Similar to how I've done it here? https://github.com/sinditech/sindi-langchain4j/blob/main/sindi-langchain4j-jakartaee-portable-extension/src/main/java/za/co/sindi/langchain4j/spi/cdi/extension/LangChain4JAiServiceExtension.java

I've made the change on my branch and created the PR. https://github.com/smallrye/smallrye-llm/pull/28

This issue is based on my conversation with @ehsavoie where the code I linked would sometimes identify the required type as Instance which is wrong. I thought just changing the single method would fix that.
That being said, on closer inspection I can see I was looking into his fork which is slightly behind and the case I am describing was throwing an error where it now only logs. But the same problem should still exist there.

If this issue does not exist in the repo, shall we close this here @manovotn ?

@Emily-Jiang Sorry I am not very familiar with this code base (or rather, not at all :)) but while my initial assumption was wrong, the code still looks a but weird.
For instance this part:
if (Instance.class.equals(Reflections.getRawType(event.getInjectionPoint().getType()))) {
   processInjectionPoint(event);
}

The event.getInjectionPoint().getEvent() should never return Instance. According to the javadoc of InjectionPoint:

If the injection point is a dynamically selected reference obtained then the metadata obtain reflects the injection point of
the {@link Instance}, with the required type and any additional required qualifiers defined by {@linkplain Instance
Instance.select()}.

@Emily-Jiang Sorry I am not very familiar with this code base (or rather, not at all :)) but while my initial assumption was wrong, the code still looks a but weird. For instance this part:
if (Instance.class.equals(Reflections.getRawType(event.getInjectionPoint().getType()))) {
   processInjectionPoint(event);
}

The event.getInjectionPoint().getEvent() should never return Instance. According to the javadoc of InjectionPoint:

If the injection point is a dynamically selected reference obtained then the metadata obtain reflects the injection point of
the {@link Instance}, with the required type and any additional required qualifiers defined by {@linkplain Instance
Instance.select()}.

Fair point @manovotn ! The processInjectionPoint(event) would never be executed.

This PR should resolve this.

@Emily-Jiang Sorry I am not very familiar with this code base (or rather, not at all :)) but while my initial assumption was wrong, the code still looks a but weird. For instance this part:
if (Instance.class.equals(Reflections.getRawType(event.getInjectionPoint().getType()))) {
   processInjectionPoint(event);
}

The event.getInjectionPoint().getEvent() should never return Instance. According to the javadoc of InjectionPoint:

If the injection point is a dynamically selected reference obtained then the metadata obtain reflects the injection point of
the {@link Instance}, with the required type and any additional required qualifiers defined by {@linkplain Instance
Instance.select()}.

Fair point @manovotn ! The processInjectionPoint(event) would never be executed.

@manovotn unfortunately the Instance if-statement is true, but we need to process it based on its parameterized type. I've updated the CDI Extension and simplified the whole process entirely.

@manovotn unfortunately the Instance if-statement is true, but we need to process it based on its parameterized type. I've updated the CDI Extension and simplified the whole process entirely.

Ok, I stand corrected...and confused :)
I wrote a quick test for this in Weld (code) and you are right - it indeed returns Instance<X> as a type so your code against current spec/Weld version is correct.
Now, I am not sure if this is intended behavior or a bug - it is in fact more practical this way as it allows you to observe dynamic resolution injection points explicitly but the specification doesn't seem to have much ground for it apart from saying that:

getInjectionPoint() returns the InjectionPoint object that will be used by the container to perform injection.

FTR, I have created a specification clarification issue which you can find under https://github.com/jakartaee/cdi/issues/826

Closing this as we've discovered that this is a non-issue and code has been merged to the main branch.


Adding msi and rbac template

Adding bicep template to create user MSI and associate RBAC role to MSI

Codecov Report

Merging #1260 (0bd55b2) into main (137c908) will increase coverage by 0.45%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1260      +/-   ##
==========================================
+ Coverage   94.49%   94.94%   +0.45%
==========================================
  Files         336      334       -2
  Lines       16835    16831       -4
  Branches       14        0      -14
==========================================
+ Hits        15908    15981      +73
+ Misses        927      850      -77

Flag
Coverage Δ

dotnet
94.94% <ø> (-0.10%)
:arrow_down:

typescript
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...cep.Core.UnitTests/FileSystem/FileResolverTests.cs
79.31% <0.00%> (-20.69%)
:arrow_down:

.../Bicep.Core.UnitTests/Assertions/BaselineHelper.cs
63.63% <0.00%> (-15.91%)
:arrow_down:

src/Bicep.Core/FileSystem/PathHelper.cs
96.15% <0.00%> (-3.85%)
:arrow_down:

src/Bicep.Core/Emit/ExpressionConverter.cs
97.10% <0.00%> (ø)

src/Bicep.Core.UnitTests/Utils/CompilerFlags.cs
33.33% <0.00%> (ø)

src/Bicep.Core/Diagnostics/DiagnosticBuilder.cs
100.00% <0.00%> (ø)

src/Bicep.Core/Emit/ResourceDependencyVisitor.cs
94.44% <0.00%> (ø)

...Bicep.Core.UnitTests/FileSystem/PathHelperTests.cs
100.00% <0.00%> (ø)

...Bicep.Core/Syntax/ParenthesizedExpressionSyntax.cs
100.00% <0.00%> (ø)

src/vscode-bicep/src/utils/logger.ts

... and 9 more

Codecov Report

Merging #1260 (0bd55b2) into main (137c908) will increase coverage by 0.45%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1260      +/-   ##
==========================================
+ Coverage   94.49%   94.94%   +0.45%
==========================================
  Files         336      334       -2
  Lines       16835    16831       -4
  Branches       14        0      -14
==========================================
+ Hits        15908    15981      +73
+ Misses        927      850      -77

Flag
Coverage Δ

dotnet
94.94% <ø> (-0.10%)
:arrow_down:

typescript
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...cep.Core.UnitTests/FileSystem/FileResolverTests.cs
79.31% <0.00%> (-20.69%)
:arrow_down:

.../Bicep.Core.UnitTests/Assertions/BaselineHelper.cs
63.63% <0.00%> (-15.91%)
:arrow_down:

src/Bicep.Core/FileSystem/PathHelper.cs
96.15% <0.00%> (-3.85%)
:arrow_down:

src/Bicep.Core/Emit/ExpressionConverter.cs
97.10% <0.00%> (ø)

src/Bicep.Core.UnitTests/Utils/CompilerFlags.cs
33.33% <0.00%> (ø)

src/Bicep.Core/Diagnostics/DiagnosticBuilder.cs
100.00% <0.00%> (ø)

src/Bicep.Core/Emit/ResourceDependencyVisitor.cs
94.44% <0.00%> (ø)

...Bicep.Core.UnitTests/FileSystem/PathHelperTests.cs
100.00% <0.00%> (ø)

...Bicep.Core/Syntax/ParenthesizedExpressionSyntax.cs
100.00% <0.00%> (ø)

src/vscode-bicep/src/utils/logger.ts

... and 9 more

@alex-frankel , Thanks for the suggestions. I have updated the templates.

@alex-frankel , Thanks for the suggestions. I have updated the templates.


feat: add job refresh

https://github.com/odpf/optimus/issues/180
Acceptance criteria:

Should able to refresh:

selected jobs, or
all jobs in selected namespaces, or
all jobs in a project

After doing refresh, ALL jobs in the requested project will be deployed
Dependency should be correctly persisted
If dependency resolution is failed for a job, it should not failed the whole refresh process
Users should know which jobs failed on refresh or deploy
Metrics on every process in refresh should be pushed

https://github.com/odpf/proton/pull/106

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

268 of 329 (81.46%)  changed or added relevant lines in 10 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.5%) to 73.225%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

service/project_service.go
1
8
12.5%

api/handler/v1beta1/job.go
28
36
77.78%

job/service.go
138
149
92.62%

job/dependency_resolver.go
91
108
84.26%

api/handler/v1beta1/observer.go
0
18
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.5%

Covered Lines:
5426

Relevant Lines:
7410

💛  - Coveralls

Hi @sbchaos, thank you for your feedback.
I have made the changes to resolve them. Please help to retake a look.


Fixed dark mode background-color and resource btn color

In dark mode background is not changing and resource button color is white

After fixing

Thank you for contributing, did you open this PR under hacktoberfest?


Switch to descriptor wallets

Is your feature request related to a problem? Please describe.
The vault client uses Bitcoin legacy wallets by default. Legacy wallets are harder to backup and recover due to them not having explicit derivation paths. Since Bitcoin core 23, descriptor wallets are now the default.
For a more detailed overview, see here: https://achow101.com/2020/10/0.21-wallets and https://bitcoinmagazine.com/technical/bitcoin-core-23-0-released-whats-new
Describe the solution you'd like
Instead of using legacy wallets, the vault client should use descriptor wallets.

This might not be feasible due to the On-chain Key Derivation (OKD) scheme we use, but worth investigating!

Yep, I think we need to check how this would work with OKD and if it's compatible/possible.
Descriptor wallets would making setting vaults up as multi-sigs a lot easier as well though.

Importing addresses is not too difficult - you just add a new descriptor. The basic steps are:

Given the private key (for example, cPGN28WXdwXtr2cpMmVVBnBAdWBCrEfiy67WatyKfWYhx3cX4k1X),
Call getdescriptorinfo("wpkh(cPGN28WXdwXtr2cpMmVVBnBAdWBCrEfiy67WatyKfWYhx3cX4k1X)"). This gives the checksum, e.g. 7uwp0v72.
Call importdescriptors '[{"desc": "wpkh(cPGN28WXdwXtr2cpMmVVBnBAdWBCrEfiy67WatyKfWYhx3cX4k1X)#7uwp0v72", "timestamp": 0, "watchonly": false}]'
address is now added
the address is a non-ranged one

Descriptor does not always correlate to an address 1:1. You can use the listdescriptors rpc to observe the descriptors. When you do a getnewaddress, no new descriptors are (typically) added. Descriptors can have a range of addresses they derive. When you do getnewaddress only the next and next_index counters of that descriptor increase (as well as the range possibly).
(related to the above) when descriptor wallet is generating new address to use as derivation key, it's not creating a new one, but rather deriving a new one. To use the OKD scheme, we need the actual derived private key. This can be done in the following way (example for address tb1qf6rs4jyvhpjlzattndxghw0zw0h5r33reglhtf).

getaddressinfo tb1qf6rs4jyvhpjlzattndxghw0zw0h5r33reglhtf. This gives the derivation path (here: m/84'/1'/0'/0/0)

"desc": "wpkh([102b271e/84'/1'/0'/0/0]037cd790de197410fb0f420923dece21fb032ae25ab70273d12d5624ccadbe0b1c)#p6c2ufsd",

then do listdescriptorinfo true to get the address corresponding to that. This will give tprv (on testnet) or xprv (on mainnet)
run this code to get the private key:let key = bitcoincore_rpc::bitcoin::bip32::ExtendedPrivKey::from_str("tprv8ZgxMBicQKsPekhHsyavZSvfLdhUThVV5WhmAtpSvqrpptbitFrKaPcuJc5KkcdCsH641zwcPtixhCzyxffJ6qVSD8RovFdwhUp9yvVXF7s").unwrap();
let secp = bitcoincore_rpc::bitcoin::key::Secp256k1::new();
let derivation_path = bitcoincore_rpc::bitcoin::bip32::DerivationPath::from_str("m/84'/1'/0'/0/0").unwrap();
warn!("wif: {}", key.derive_priv(&secp, &derivation_path).unwrap().to_priv().to_wif());

getdescriptorinfo "wpkh(<wif>)"

"descriptor": "wpkh(037cd790de197410fb0f420923dece21fb032ae25ab70273d12d5624ccadbe0b1c)#2kuqptdh"

Verify that is works: deriveaddresses "wpkh(037cd790de197410fb0f420923dece21fb032ae25ab70273d12d5624ccadbe0b1c)#2kuqptdh"

"tb1qf6rs4jyvhpjlzattndxghw0zw0h5r33reglhtf"

Summarizing my understanding:

Descriptor wallets work with the OKD scheme.
Using descriptor wallets introduces iteration over all descriptors to find the matching descriptor/UTXO.
Having a -master wallet would make life easier.

Questions:

For finding the descriptor/UTXO, does it add a lot of complexity when e.g., a vault needs to restart?
Is there anything blocking us from switching to descriptor wallets?

I find it quite worthwhile to make the switch as we will make it easier for vaults to backup/restore wallets, make it possible to use hardware wallets eventually and help with multisig vaults.

For finding the descriptor/UTXO, does it add a lot of complexity when e.g., a vault needs to restart?

Well we need to do the the iteration over all descriptors that's mentioned. This iteration needs to be done once per vault start-up if we just keep it in memory.

Is there anything blocking us from switching to descriptor wallets?

No hard blockers that I'm aware of, but the bitcoin rpc library is missing some rpcs. The maintenance is not very active at all so we'll probably have to implement this ourselves on a fork.

we will make it easier for vaults to backup/restore wallets

I'm not trying to argue against this point, but why is this the case? With legacy wallets you can just copy the wallet file and that's it, right?

There's a blog post I've read somewhere that describes a bit the issues with legacy wallet recovery. IIRC, legacy wallet are not compatible with wallets other than core and core will also stop supporting them in late 2024. So while you can back them up, at some point you can only use them with outdated software. There were also some other issues where reconstructing addresses was complex but not sure if that isn't an issue if you restore just all files.


host: Add handling for instance creation failure

I expect this to cause failures elsewhere 🧐
The original issue relates to a failure when creating an instance where the card uses restartableTask but maybe addressing that should be in a separate PR.

Closing for issue change


Fix __meta_consul_tag to be __meta_consul_tags

It seems that __meta_consul_tag should be __meta_consul_tags.

__meta_consul_tags: the list of tags of the target joined by the tag separator

https://prometheus.io/docs/prometheus/latest/configuration/configuration/

I also reported this error on Errata of your book.

Thanks for the PR and errata, I actually manage this in a different private repo and copy over.

I understand, I'll close PRs:+1:


UserJS patches manager

To extend AutoPatchWork functionality on a specific site (like modify next page links, fix content before appending etc) users can create UserJS "patches". It'll be useful if patch manager implemented as Preferences page or the same way as SITEINFO manager instead of manually placing them in UserJS folder.

Implemented (in most simple way) in 590cee0 as jsPatch field of entries in SITEINFO manager and custom pattern editor.


Remove Old Releases in What's New screen?

Would you prefer for old releases to be removed from Noto? For example, anything below version 2.0.0 would get removed.
The advantage is to shrink the amount of strings that needs to be translated by new translators. Since, most users won't notice or care about them. If someone needs to check them, they're available on GitHub.
What do you think?

I think this would be interesting if removed. Thinking from the point of view of an ordinary user, I would rarely pay any attention to this information.


Style placeholders for list view

Before

After

Still room for improvement in templates/EbookGrid.php, but this is better for list view.

Thanks!


Update copyright headers to include license info

The copyright is included, but the license isn't mentioned explicitly


cubehelix established

Following #78 i tried to build a cubehelix function (works with e.g. Winston.colormap). Could use some more documentation and while closely looking at it: there is a possiblility to integrate with the colormap("name",N) call.

Is there anything i need to improve here? Any comment would be nice.

LGTM.  I don't usually do much with the color package, but this seems to belong here, and the original author is clearly interested in broad scale implementation.  If no one objects, I'll merge this tomorrow.

(or gets to it first)

Also, there is no copyright information on the original Fortran source, so distributing derived works is technically illegal under US copyright law.  (The default in copyright law is no permission to redistribute.)  A lot of scientists don't understand this, and think that if they just post their code on the web then it is free for anyone to use without restriction.
Probably, this was not the original author's intention, so the best thing to do would be to email him and get permission to use/distribute/modify/translate his code under the terms of the MIT/expat license.

News: My original email was delivered (David Green found it in the spam folder). He replied: "I believe the paper I published on this, which includes the fortran
implementation, is in the public domain. I'll check with the journal."
So let's wait for his next email.

It's almost certainly not in the public domain (== not copyrighted), because everything is copyrighted by default (at least in the US) and publishers rarely relinquish this.   One key question is whether he signed a copyright assignment form when he published the paper—he could have relinquished his rights to the code.  (Authors often do this without fully understanding what they are doing, in my experience.)
Can you just request that he attach an explicit MIT/expat license statement to his code, if it is his intention that the code be freely usable/redistributable/modifiable without restriction?  Please make sure he understands that the default under US (and other international) copyright laws is no permission, so an explicit license statement is needed to ensure that the code is free of legal encumbrance for all time.  And it is much better to use a standard, time-tested license statement than it is to write your own informal language (e.g. "this code is public domain") whose legal meaning is often (unintentionally) unclear or (worse) has unintended consequences.

And please cc me (stevenj at math dot mit dot edu) on your email to him.

@stevengj, @kmsquire
We're now somehow waiting 4 weeks for a answer about this copyright issue Steven brought up. Would it make some sense to ask for a volunteer who is not aware of neigther my code nor the cited f77 to write a 4 liner that fills the palette?

@lobingera, yes, it seems time for a clean-room implementation based on the description in the paper only.   Maybe ask for volunteers on julia-users?  As you say, the implementation should be trivial.

News: David Green's website now has a license attached to the code which afaiu put's the code into public domain.

Will be moved to https://github.com/JuliaGraphics/Colors.jl


PostgreSQL Interactive Q13 compile error on DuckDB

The implementation has two problems:

[x] on dev, it runs into an infinite loop (resolved by cherry-picking https://github.com/ldbc/ldbc_snb_implementations/pull/128/commits/24f8befb065933422840680b6a7d6fa84480c20f to master)
[x] using DuckDB, it fails to compile, see: https://github.com/cwida/duckdb/issues/1088

This will work with the upcoming DuckDB.


how to fix lpthread error with indigo version?

I am working on Ubuntu14.04 with ros indigo installed. I encountered an error:
CMake Error at /home/bob/carto_ros/install_isolated/share/cartographer_ros/cmake/cartographer_rosConfig.cmake:141 (message):
  Project 'cartographer_rviz' tried to find library '-lpthread'.  The library
  is neither a target nor built/installed properly.  Did you compile project
  'cartographer_ros'? Did you find_package() it before the subdirectory

when I was compiling cartographer_ros. I have found the solution here: https://github.com/googlecartographer/cartographer_ros/issues/1163#issue-400305513 and  #975 ,but it was fixed in catkin-kinetic, how could I get it fixed in indigo?

Sorry, I got it fixed just changed the file locally and it works fine. Thanks.


Replace package-private scope with public

@dstepanov Try the https://github.com/eclipse-ee4j/cdi-tck/pull/277 PR to see if that works for Micronaut.


Reading smaill file

int done = hdfsRead(fs,fin,read,2);

When the t_size I pass to the function is less than 3, it will automatically fill other two random characters in my buffer no matter how much size I create for the buffer.

However, if the t_size I passed to the function is greater than 3, it will fill the buffer with regular chars in the file.

I will check on this issue.

I added a test case but cannot reproduce this issue. See my last commit 7bd2c8505a724b892c2df76a37490923719aabad
Would you please describe the step to reproduce or add a test case to reproduce?


net7 support

Is your feature request related to a problem? Please describe.
DotNet v7 is scheduled to be released in November.
Even though net7 solutions can use net6 libraries it makes sense to publish both.
This should make sure we get the full net7 performance improvements and it'll ensure future proofing.
Describe the solution you'd like
Add the version to the build pipelines and csproj output on top of netcore2.1 and net6.
Describe alternatives you've considered
-
Additional context
It's not necessary to profile net6 after this feature to prevent build times ramping up.
However, keep it if GitHub allows the amount of runtime.

Decided to move this feature out of the milestone since it requires VS preview on top of the runtime.
Setting the due date to the 14th of november, expecting net7 to be released around the 8th.

Maybe also add this:
https://www.youtube.com/watch?v=Y2YOaqSAJAQ


Pusher error: Authentication signature invalid

Reverb Version
1.4
Laravel Version
10.10
PHP Version
8.3.9
Description
Hi,
I am getting this Pusher error: Authentication signature invalid when I am trying to broadcast an event from my controller to a public channel.
This works on my local environment, but not on my prod/dev server.
I traced down to the Controller.php under /vendor/laravel/reverb/src/Protocols/Pusher/Http/Controllers/Controller.php
protected function verifySignature(RequestInterface $request): void
    {
        Log::debug('verifySignature :', [$request]);
        $params = Arr::except($this->query, [
            'auth_signature', 'body_md5', 'appId', 'appKey', 'channelName',
        ]);

        if ($this->body !== '') {
            $params['body_md5'] = md5($this->body);
        }

        ksort($params);

        $signature = implode("\n", [
            $request->getMethod(),
            $request->getUri()->getPath(),
            $this->formatQueryParametersForVerification($params),
        ]);

        $signature = hash_hmac('sha256', $signature, $this->application->secret());
        $authSignature = $this->query['auth_signature'] ?? '';
        Log::debug('signature :', [$signature]);
        Log::debug('authSignature :', [$authSignature]);
        if ($signature !== $authSignature) {

            //Tokka TODO
            throw new HttpException(401, 'Authentication signature invalid.');
        }
    }

I found that in my local environment, signature and authSignature can be successfully matched.
While on my server environment, signature has a value, but authSignature is empty, hence the error occurred.
Am I missing any settings?
Steps To Reproduce
I found that in my local environment, signature and authSignature can be successfully matched.
While on my server environment, signature has a value, but authSignature is empty, hence the error occurred.

Further digging down the stream, I found that the auth_signature is being generated in /vendor/pusher/pusher-php-server/src/Pusher.php before going into the verify() function.
public static function build_auth_query_params(
        string $auth_key,
        string $auth_secret,
        string $request_method,
        string $request_path,
        array $query_params = [],
        string $auth_version = '1.0',
        string $auth_timestamp = null
    ): array {
        $params = [];
        $params['auth_key'] = $auth_key;
        $params['auth_timestamp'] = (is_null($auth_timestamp) ? time() : $auth_timestamp);
        $params['auth_version'] = $auth_version;

        $params = array_merge($params, $query_params);
        ksort($params);

        $string_to_sign = "$request_method\n" . $request_path . "\n" . self::array_implode('=', '&', $params);
        Log::debug('Pusher string_to_sign :', [$string_to_sign]);
        Log::debug('Pusher auth_secret :', [$auth_secret]);
        $auth_signature = hash_hmac('sha256', $string_to_sign, $auth_secret, false);
        Log::debug('Pusher auth_signature :', [$auth_signature]);
        $params['auth_signature'] = $auth_signature;

        return $params;
}

auth_signature is being generated successfully. However it is not being passed to the verify() function afterwards.

After further digging, I found that i am missing the query $args in my server block!!
location ~ /app/(?.*) { # variable reverbkey
proxy_pass http://<IP_ADDRESS>:9123/app/$reverbkey;
proxy_http_version 1.1;
proxy_set_header Host $http_host;
proxy_set_header Scheme $scheme;
proxy_set_header SERVER_PORT $server_port;
proxy_set_header REMOTE_ADDR $remote_addr;
proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
proxy_set_header Upgrade $http_upgrade;
proxy_set_header Connection "Upgrade";
}
# The Laravel Backend would broadcast to this
location ~ ^/apps/(?[^/]+)/events$ { # variable reverbid
proxy_pass http://<IP_ADDRESS>:9123/apps/$reverbid/events?$args;
proxy_set_header Host $host;
proxy_set_header X-Real-IP $remote_addr;
proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
proxy_set_header X-Forwarded-Proto $scheme;
}


Measuring tape updates

I'd like to make the following changes to MeasuringTapeNode to support Wave Interference:

Add a baseDragEnded option, so I can get a callback to test being dropped in the toolbox
Add an interactive option, so I can easily create an icon (much easier than MeasuringTapeNode.createIcon, which looks like a mess).

I implemented the proposed changes and am leveraging them in Wave Interference.  @ariel-phet can you please recommend someone to review these common code changes?

This looks like it's meant for scenery-phet? I'm going to unsubscribe from notifications (let me know if I'm the one doing the review though).

Sorry, was meant for scenery-phet.

@samreid can you move this issue to the correct place, and reassign to me.

Moved to scenery-phet (see link above), closing.


How to read hyperlinks from XLSX using RubyXL

I was pretty much surprised to find out that's there's no simple way to read hyperlinks from a XLSX file parsed by RubyXL (or is there?)
Obviously, one would expect expect something like
workbook[0][2][3].href

but further exploration showed that the only method that I could find to reveal hyperlinks,
workbook[0].hyperlinks

returned an empty array. I continued my investigation and figured that some of the hyperlinks from my document can be found in XML returned by
workbook.worksheet_rels

and the output is like this:
{
    "sheet1.xml.rels" =>
        "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"yes\"?>
         <Relationships xmlns=\"http://schemas.openxmlformats.org/package/2006/relationships\">
         <Relationship Id=\"rId3\" Type=\"http://schemas.openxmlformats.org/officeDocument/2006/relationships/hyperlink\" Target=\"http://www.domain.com/action1/action2\" TargetMode=\"External\"/>
         ...
}

It does contain some of the links from my document, but unfortunately, not all of them.
Can you guys please give some guidance on how to find the hyperlinks?
Thank you.
PS Here's the file that I used for testing, it was created by Excel for Mac 2011 v. 14.0.0
Also,
--- > RUBY_VERSION
= "2.0.0"
--- > RUBY_PLATFORM
= "x86_64-darwin13.0.0"

with the latest version of the gem.

@weshatheleopard  My usecase / workflow requires inspecting specific cell for a hyperlink.  Given a cell what is the most elegant way to obtain the contained hyperlink?

@karthik-panchap : can you give me a minimal sample spreadsheet which has what you want to obtain from it?

@weshatheleopard  Sure, here is a quick example.
sample.xlsx
Workflow requires getting link from specific cells in the workbook ex: for the apple workbook[0][1][2].

@karthik-panchap:
require 'rubyXL'
doc = RubyXL::Parser.parse('sample.xlsx')
sheet = doc[0]

sheet.sheet_data.rows.each { |row|
  next if row.nil?
  row.cells.each { |cell|
    next if cell.nil?
    hl = sheet.hyperlinks.find{ |hl| hl.ref == cell.r }
    next if hl.nil?
    ext_link = sheet.relationship_container.find_by_rid(hl.r_id)
    next if ext_link.nil?

    puts "Cell at #{cell.r.to_s} -- links to #{ext_link.target}"
  }
}


Support for multiple images in a single tweet.

Awesome, Omar! Thanks for this!
I added another issue to the list to upload the first 4 media items in case there are more specified.


Allow minor version change for perl package

Checklist before submitting

[x] Did you read the contributor guide?
[ ] Did you update any affected documentation?
[ ] Did you write any tests to validate this change?

Description
Fixes # (issue).
Review process to land

All tests and other checks must succeed.
At least one maintainer must review and approve.
If any  maintainer requests changes, they must be addressed.

This PR is required for s390x because on s390x, only 5.26.2 is available and 5.26.0 version of perl package is not available.


test: add tests for get_enriched_time_series_points_df

Description
Adds test for _get_enriched_time_series_points_df
References

#32

I can't find the testing of this logic:
    # Only use latest registered points
    window = Window.partitionBy("GsrnNumber", "time").orderBy(
        col("RegistrationDateTime").desc(), col("storedTime").desc()
    )
    # If we end up with more than one point for the same Meteringpoint and "time".
    # We only need the latest point, this is essential to handle updates of points.
    timeseries_df = timeseries_df.withColumn(
        "row_number", row_number().over(window)
    ).where(col("row_number") == 1)

I will get that tested asap

All comments have been addressed and the PR is ready for round two


  See darkside.proto for details.
Requirements:

[x] Loads blocks from Url parameter using the Go http client library (note, no longer will use curl)
[x] Copies these blocks to the staging area

This is done, ready to review and attempted use by Kevin and Pacu. In branch for PR https://github.com/zcash/lightwalletd/pull/250, not yet master.


Only display refund dowload link if user has perm

The button to download the file containing transactions to be
refunded - and the account details of the refundees - will now
only display if the user is actually able to access those
details on the API.

@SteveMarshall the final piece of the puzzle


Add synclient trackpad settings for lenovo13 'sentry'

Updating the synclient settings as advised in #214
This is for the lenovo thinkpad 13.  I see there is a list of other machines there that need the fix as well but most of them don't have enough info for me to know which settings to put them under.

Thanks.  Could you please sign the CLA?

Done.

Thanks!


fix(RN): remove container for React-Native

The container added in a previous patch in the  was not working because strings can't be used in React-Native for createElement. It introduced a bug that some users found
In order to fix it and not add a dependency to RN, it fallbacks to using the previous behaviour when not in DOM.

In order to fix it and not add a dependency to RN, it fallbacks to using the previous behaviour when not in DOM.

What about we do not add any dependency and assume people willing to build instantsearch with react native do have react-native installed? This is what we are doing for react-dom, nowhere we have "react-dom" as a dep (not in peer, not in deps).
So that we could keep the same behavior. Would that work?
Ultimately we may have three packages:
react-intantsearch-dom
react-instantsearch-native
react-instantsearch
Just like what facebook does. So we can add any peer/dep we want that makes sense given the use case.

Cannot even right a proper test for react-native as this:
/* eslint-env jest */

import 'react-native';
import React from 'react';
// import {InstantSearch} from './native.js';

// Note: test renderer must be required after react-native.
import renderer from 'react-test-renderer';
const algoliaClient = {search() { console.log('test'); }};

it('renders correctly', () => {
  const Root = 'View';
  const App = () => <Root/>;

  const tree = renderer.create(
    <App />
  ).toJSON();
  expect(tree).toMatchSnapshot();
});

Just works, might be Jest being too optimistic

I didn't know we didn't have a hard dependency on react-dom 🤔 since it works, like you said, then it's nice because it will be consistent across all platforms👌 making the changes tomorrow 🤓

The change are:

we passe directly View as a root for the react-native InstantSearch
add react-native example folder + simplification of our infinitsearch example


Sorry, something went wrong activating IntelliCode support for Java. Please check the "Language Support for Java" and "VS IntelliCode" output windows for details.

Version: 1.47.3 (user setup)
Commit: 91899dcef7b8110878ea59626991a18c8a6a1b3e
Date: 2020-07-23T13:12:49.994Z
Electron: 7.3.2
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18363
Steps to Reproduce / Scenario:
1.Sorry, something went wrong activating IntelliCode support for Java. Please check the "Language Support for Java" and "VS IntelliCode" output windows for details.
2.Java 11 or more recent is required to run. Please download and install a recent JDK

The latest release of VS Code Java requires Java 11 to run.
please follow https://github.com/redhat-developer/vscode-java/issues/1543#issuecomment-663382692

Per @Eskibear 's comment above, closing this item.

VS Code Java的最新版本要求Java 11才能运行。
请关注redhat-developer / vscode-java＃1543（评论）

Thanks♪(･ω･)ﾉ，我使用的是java8，我想屏蔽这个错误信息

https://github.com/redhat-developer/vscode-java/issues/1543#issuecomment-669895753
it's work for me

Shifting to java 11 it worked for me. If you have settings.json then
"java.home": "/usr/lib/jvm/java-11-openjdk-amd64


Uncaught TypeError: this.onerror is not a function

Hi.
When "Playback on other Websites has been disabled by the video owner" I get Uncaught TypeError: this.onerror is not a function. It will be good to catch this error before the user clicks play.

i have the same issue

Same here.

I also get this, but I don't know if this used to be a method or not. It would be nice to see this go away, though.


ONNX quantization

One can quantize ONNX models (dynamic or static). Is this somehow part of the options?

Quantization in torch + ONNX conversion vs ONNX conversion + quantization is also an interesting angle.

It isn't currentlty, but we're working on it! ONNX is going to be the focus of a next update. E.g. we have a dev branch where we're fixing ONNX GPU implementation, it seems to have a package dependency issue that's causing a bug.
We've set up the library to be quite easily extendible: using the name of the option, we have a match-case statement that selects the forward call of the conversion option. As long as the conversion method returns a callable that can be accessed from the match-case statement, all good, nothing else to do to support a method! It becomes really easy to add more options since you only have to add the code to do your conversion, e.g. JIT trace, and then return that forward call. Nothing else to edit!
If you ever want to have a crack at it, we'd be 1) really happy and appreciative, 2) be available to help out!

Thanks for the swift reply. I might have a look at it in January.


Easy open/close shutter

Easy open/close shutter for PJLink control projectors.

'Mute' and has been in the PJ Link module since it was released.


Added UI + Save System

Simple UI implementation for key-binding system and saving changes on cookies.

The backend for this script will be PR on https://github.com/hackclub/sprig-engine so I am keeping this on draft till the PR on that is live / approved

@DevIos01 please resolve conflicts here


Add scopes support to Traverse / transformer

The intent is to replace VisitMut in transformer with the new oxc_traverse::Traverse. #3182 is a starting point for that.
However, transformers require scope information, which is not yet implemented.
VisitMut provides only fairly minimal information - just ScopeFlags indicating:

What kind of environment visitor is in (top level / function / method / class static block / etc).
Whether strict mode or not.

This would be fairly easy to replicate in Traverse.
However, I assume transformers actually need more info than this, probably more like the info available from semantic. Opening this issue to discuss:

What scope info transformers need.
How to implement it.

What scope info transformers need.

All we need are the scope flags.
During traversing, we keep a stack of scopes, and manage binding information while entering / leaving scopes.

How to implement it.

The coolest approach is to treat scope as an individual AST node, something like
struct Scope<T> {
  inner: T
}

pub struct TryStatement<'a> {
    pub block: Box<'a, Scope<BlockStatement<'a>>>,
    pub handler: Option<Box<'a, Scope<CatchClause<'a>>>>,
    pub finalizer: Option<Box<'a, Scope<BlockStatement<'a>>>>,
}

But actually I've got no idea on how to implement it until I get my hands dirty on the new traverse API.

I need to store things associated with a scope, but I think I can work with what you proposed to get things started.

Actually you don't need ScopeFlags to answer the question "am I in a function?".
Something like this would do the same:
let in_function = ctx.find_ancestor(
  |ancestor| match ancestor {
    _ if ancestor.is_function() => FinderRet::Found(()),
    _ if ancestor.is_arrow_function_expression() => FinderRet::Found(()),
    Ancestor::ObjectPropertyValue(prop) => match *prop.method() {
      true => FinderRet::Found(()),
      false => FinderRet::Continue,
    }
    _ if ancestor.is_method_definition() => FinderRet::Found(()),
    _ => FinderRet::Continue,
  }
).is_some();

ScopeFlags is worth implementing to make this cheaper if it's a question we need to ask a lot in visitors. Is assume it is, right?

Related to #2859.

#3314 gave Traverse full scopes support.


fix(config):Correct ENV Variable lookup typo for SshConfig

A typo prevented tmp to be set separately from ssh config path

Thank you!


[Discussion] How to avoid cheating?

We want to encourage people to collaborate, think about problems alone or around a table, but avoid them to copy-paste solutions found elsewhere.
Solution 1 - Reduce cash prize
Solo cheating is driven by high cash prizes. Drastically reducing the incentives would drive cheating down.
My opinion: no more solo cash prize + "group" (tbd) cashprize + symbolic city prize
Solution 2 - Open source participants' solutions
This expensive solution would contribute to two things:

cross-validate solutions for top performers and validate rankings
share and log code for all the participants

Splitted in #71 and #78


update arch pic and highlights description in readme

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 72.386%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
4569

Relevant Lines:
6312

💛  - Coveralls


Checkpoint

This PR adds some simple functionality for a cleaner working directory:

Adds the save_path argument to specify where model weight checkpoints are saved.
Adds the save_iter argument to specify how many training iterations should pass between checkpoint saves.

Thanks for the great paper/code! :smiley:

Thanks!


Why does the model occupy less GPU memory after quantization, but the inference speed is slower?

Using the vector-wise symmetric quantization method.

I don't know what quantization method you are using. Maybe only the weights are quantized and the computation is still conducted with FP16. Another possible reason is that the hardware you are using doesn't support INT8 acceleration.


Use rtm aspnetcore packages

This gives us a first look at the aspnetcore experience in practice for 2.1-rtm source-build.

Here's the initial error I get in smoke-test with these changes (instead of the earlier "can't find the shared framework" kind of errors):
    running run
Using launch settings from /work/testing-smoke/C#_web/Properties/launchSettings.json...
crit: Microsoft.AspNetCore.Server.Kestrel[0]
      Unable to start Kestrel.
System.InvalidOperationException: Unable to configure HTTPS endpoint. No server certificate was specified, and the default developer certificate could not be found.
To generate a developer certificate run 'dotnet dev-certs https'. To trust the certificate (Windows and macOS only) run 'dotnet dev-certs https --trust'.
For more information on configuring HTTPS see https://go.microsoft.com/fwlink/?linkid=848054.
   at Microsoft.AspNetCore.Hosting.ListenOptionsHttpsExtensions.UseHttps(ListenOptions listenOptions, Action`1 configureOptions)
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.AddressesStrategy.BindAsync(AddressBindContext context)
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.BindAsync(IServerAddressesFeature addresses, KestrelServerOptions serverOptions, ILogger logger, Func`2 createBinding)
   at Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServer.StartAsync[TContext](IHttpApplication`1 application, CancellationToken cancellationToken)

Unhandled Exception: System.InvalidOperationException: Unable to configure HTTPS endpoint. No server certificate was specified, and the default developer certificate could not be found.
To generate a developer certificate run 'dotnet dev-certs https'. To trust the certificate (Windows and macOS only) run 'dotnet dev-certs https --trust'.
For more information on configuring HTTPS see https://go.microsoft.com/fwlink/?linkid=848054.
   at Microsoft.AspNetCore.Hosting.ListenOptionsHttpsExtensions.UseHttps(ListenOptions listenOptions, Action`1 configureOptions)
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.AddressesStrategy.BindAsync(AddressBindContext context)
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.BindAsync(IServerAddressesFeature addresses, KestrelServerOptions serverOptions, ILogger logger, Func`2 createBinding)
   at Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServer.StartAsync[TContext](IHttpApplication`1 application, CancellationToken cancellationToken)
   at Microsoft.AspNetCore.Hosting.Internal.WebHost.StartAsync(CancellationToken cancellationToken)
   at Microsoft.AspNetCore.Hosting.WebHostExtensions.RunAsync(IWebHost host, CancellationToken token, String shutdownMessage)
   at Microsoft.AspNetCore.Hosting.WebHostExtensions.RunAsync(IWebHost host, CancellationToken token)
   at Microsoft.AspNetCore.Hosting.WebHostExtensions.Run(IWebHost host)
   at C__web.Program.Main(String[] args) in /work/testing-smoke/C#_web/Program.cs:line 17

I followed the sequence that I think we're expecting people to naturally follow from there, and it works:
#> cd testing-smoke/
#> builtCli/dotnet dev-certs https

Cannot find command 'dotnet dev-certs', please run the following command to install

dotnet tool install --global dotnet-dev-certs

#> builtCli/dotnet tool install --global dotnet-dev-certs

error NU1103: Unable to find a stable package dotnet-dev-certs with version
error NU1103:   - Found 33 version(s) in dotnet.myget.org/feed/dotnet-core [ Nearest version: 2.1.0-preview1-28181 ]
error NU1103:   - Found 2 version(s) in nuget.org [ Nearest version: 0.0.1-alpha ]
error NU1103:   - Found 0 version(s) in source-built-packages
error NU1103:   - Found 0 version(s) in /work/testing-smoke/builtCli/sdk/NuGetFallbackFolder
The tool package could not be restored.
Tool 'dotnet-dev-certs' failed to install. This failure may have been caused by:

* You are attempting to install a preview release and did not use the --version option to specify the version.
* A package by this name was found, but it was not a .NET Core tool.
* The required NuGet feed cannot be accessed, perhaps because of an Internet connection problem.
* You mistyped the name of the tool.

#> builtCli/dotnet tool install --global dotnet-dev-certs --version 2.1.0-preview1-28181

Format version is missing. This tool may not be supported in this SDK version. Please contact the author of the tool.
Tools directory '/work/.rhelhome/.dotnet/tools' is not currently on the PATH environment variable.
If you are using bash, you can add it to your profile by running the following command:

cat << \EOF >> ~/.bash_profile
# Add .NET Core SDK tools
export PATH="$PATH:/work/.rhelhome/.dotnet/tools"
EOF

You can add it to the current session by running the following command:

export PATH="$PATH:/work/.rhelhome/.dotnet/tools"

You can invoke the tool using the following command: dotnet-dev-certs
Tool 'dotnet-dev-certs' (version '2.1.0-preview1-28181') was successfully installed.

#> export PATH="$PATH:/work/.rhelhome/.dotnet/tools"
#> dotnet-dev-certs https

A fatal error occurred, the required library libhostfxr.so could not be found.
If this is a self-contained application, that library should exist in [/work/.rhelhome/.dotnet/tools/.store/dotnet-dev-certs/2.1.0-preview1-28181/dotnet-dev-certs/2.1.0-preview1-28181/tools/any/any/].
If this is a framework-dependent application, install the runtime in the default location [/usr/share/dotnet] or use the DOTNET_ROOT environment variable to specify the runtime location.

#> export PATH="$PATH:/work/testing-smoke/builtCli"
#> export DOTNET_ROOT="/work/testing-smoke/builtCli"
#> dotnet-dev-certs https

The HTTPS developer certificate was generated successfully.

#> cd C#_web/
#> dotnet run

Using launch settings from /work/testing-smoke/C#_web/Properties/launchSettings.json...
Hosting environment: Development
Content root path: /work/testing-smoke/C#_web
Now listening on: https://localhost:5001
Now listening on: http://localhost:5000
Application started. Press Ctrl+C to shut down.

@dleeapho @natemcmaster Does that look like the expected flow to you?
/cc @dseefeld @crummel

Interesting, I didn't notice 2.1.0-preview1-28181 was preview1 rather than rtm. (I just pasted what it told me the dotnet-core feed had.) I also missed that Format version is missing. was a warning and skipped forward.
I'll try again with the line you sent. For my specific scenario, I already have the dotnet-core feed in the smoke-test nuget.config, but I can see why --add-source would be needed generally until rtm is pushed to the nuget gallery.

The 2.1.0-rtm-* dotnet-dev-certs version (it gets 2.1.0-rtm-30698) doesn't work for me. Seems to be more strict about the shared framework it runs on? (Or some mechanism I don't understand made the preview1 one work?)
#> dotnet-dev-certs https
It was not possible to find any compatible framework version
The specified framework 'Microsoft.NETCore.App', version '2.1.0-rtm-26502-02' was not found.
...
  - The following versions are installed:
      2.1.0-rtm-26426-03 at [/work/testing-smoke/builtCli/shared/Microsoft.NETCore.App]

Full log: https://gist.github.com/dagood/baff9009643eebf9df6562987a17da08


setGame, every so often the Bot removes it's "Playing" tag

When using
if (message.author.id === '190775609532612608') { if (!argresult) argresult = null; if (message.content.startsWith(prefix + 'setgame')) { this.client.user.setGame(argresult) } } else { message.channel.sendMessage(${message.author}, You do not have Administrative permission to use that command) }
Code in Discord-Commando. The bot enables it's "Playing " tag correctly. After a few minutes it deletes that tag for no reason.

This is the repository for the Commando bot, not the framework itself.
Please ask your discord.js-commando related questions on the Offical Discord.js server in the #support-commando channel.


Add check for M1 Pro/Max Macbook Pro HDMI

As with the Mac mini, the new Macbook Pro (M1 Pro/Max, 14" and 16") models of 2021 seems to have DDC communication blocked on their HDMI port.
This PR add a check for these models. (And an easy way to add newer models if needed)

LGTM!


Some fixes to run on Danny's laptop

changed version checking for astropy to use distutils
changed from using unix free to psutil to get available ram

Appropriate changes have been made. Pull request no longer active.


Upgrading From 0.1.1 to 0.1.3 stops Background Play

I am unable to play the music in background. Once the app is hidden by pressing home button the music stops with fade effect.
Reverting back to 0.1.1 fixes it.

yes, because now, the call to UIApplication.sharedApplication().beginReceivingRemoteControlEvents() has been removed from inside Jukebox. Since you handle the remote events by overriding remoteControlReceivedWithEvent(event:), it makes more sense to also call beginReceivingRemoteControlEvents(), checkout the Readme and the Example project for more info

I am keeping jukebox variable in singleton and then Access remote events from my custom Navigation Controller.
I have the UIApplication.sharedApplication().beginReceivingRemoteControlEvents() in viewDidLoad() and have overriden emoteControlReceivedWithEvent(event: UIEvent?) but it still happens.
Thanks alot


colour-science pip package is detected as colour

This code shows how colour-science==0.3.14 is detected as colour==0.1.5.
pip install colour-science==0.3.14
echo import colour > bug.py
echo "print(colour.__version__)" >> bug.py
python bug.py
pipreqs --print

I think part of this may be related to that fact that I installed colour-science using pip install . from the colour repository, and pip shows both versions side by side. However, even when uninstalling colour, colour-science does not seem known.


[HOPS-920] BPOfferService.blockReport should call blockReportCompleted in a finnaly

BPOfferService.blockReport should call blockReportCompleted in a finnaly
Make sure there is no duplicate PR for this issue

Please check if the PR fulfills these requirements

[] Tests for the changes have been added and passed (for bug fixes / features)
[x] HOPS JIRA issue has been opened for this PR
[x] All commits have been squashed down to a single commit
[x] The commit message has the following format: [HOPS-XXX] message

Post a link to the associated JIRA issue
https://hopshadoop.atlassian.net/browse/HOPS-920?filter=-1

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
bug fix

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
no

Other information:

Can one of the admins verify this patch?

Jenkins test this please.

Can you fix the indentation of your try block.


[ray.so] Selected text not being recognized

Extension
https://www.raycast.com/garrett/ray-so
Description
When trying to use the Generate Image command with text selected, an error is thrown saying "please make sure text is selected". Tried restarting my Macbook Air 2 running Ventura 13.2.1 and restarting Raycast v.1.49.3 and still encountering the same issue. I've also tried it in multiple applications including Chrome, Discord, and Visual Studio Code, all running into the same issue.
Steps To Reproduce

Select text
Execute the Generate Image command

Current Behaviour
Selected text is not being recognized.
Expected Behaviour
Selected text should be recognized and not result in the error.

Issue was that I had to turn on accessibility in Privacy and Safety settings for Ray.so. Should make this clear in the docs or specify in the error.


Fix: Fix logspace bug.

Thanks for your contribution and we appreciate it a lot. :rocket::rocket:
1. Motivation
fix int_case when step=1 bug.
fix base=0 bug.
2. Modification
kernels/logspace/logspace_block.mlu

failed_logspace.tar.gz


Fixing swiftlint violations.

Platforms Impacted

[x] iOS
[ ] macOS

Description of changes
Removing empty spaces that caused the following violation:
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
Verification
No violations reported by swiftlint.

Before
After

Screenshot or description before this change
Screenshot or description with this change

Pull request checklist
This PR has considered:

[ ] Light and Dark appearances
[ ] VoiceOver and Keyboard Accessibility
[ ] Internationalization and Right to Left layouts
[ ] Different resolutions (1x, 2x, 3x)
[ ] Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)

Microsoft Reviewers: Open in CodeFlow

thanks for fixing it. we need automation to flag this for us.

thanks for fixing it. we need automation to flag this for us.

Yes! It's already in my personal backlog here!

oops, sorry!


[SPARK-31764][CORE] JsonProtocol doesn't write RDDInfo#isBarrier

What changes were proposed in this pull request?

This PR changes JsonProtocol to write RDDInfos#isBarrier.
Why are the changes needed?

JsonProtocol reads RDDInfos#isBarrier but not write it so it's a bug.
Does this PR introduce any user-facing change?

No.
How was this patch tested?

I added a testcase.

Test build #122855 has started for PR 28583 at commit 5851842.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27500/
Test PASSed.

Test seems to be aborted.

retest this please.

Test build #122919 has started for PR 28583 at commit 5851842.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27562/
Test PASSed.

Test build #122919 has finished for PR 28583 at commit 5851842.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122919/
Test FAILed.

Test build #122927 has started for PR 28583 at commit 53ebb55.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27570/
Test PASSed.

Test build #122927 has finished for PR 28583 at commit 53ebb55.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122927/
Test PASSed.

cc. @jiangxb1987
This is newly added in Spark 3.0.0, which is ideal to be addressed in 3.0.0 if possible.

retest this please

Test build #123139 has started for PR 28583 at commit 53ebb55.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27771/
Test PASSed.

Test build #123139 has finished for PR 28583 at commit 53ebb55.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123139/
Test PASSed.

retest this please

Test build #123200 has started for PR 28583 at commit 53ebb55.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27826/
Test PASSed.

Test build #123200 has finished for PR 28583 at commit 53ebb55.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123200/
Test PASSed.

Thanks, merged to master!


MAINT: update supported versions of Python and NumPy to follow NEP29

This PR does the work to follow NEP29 for the next release (1.11) which probably is going to be scheduled around June.

Drop support for Python 3.8, hence NumPy >=1.22.4.
Change the dev job to Python 12-dev instead of 11-dev. And bump all jobs 1 version up.
Update ubuntu image from 20 to 22 (Focal to Jammy).

Not sure about a few things and could have forgot to update some lines, please check carefully.

probably after #17950

Correct!
What is the link with your PR?

#17950 . There's a lot of overlap with the ci configs.

Not sure how to fix the failures otherwise (besides the linter)

The Mypy error is a known bug and we would need to update mypy to work on Python 3.10. https://github.com/python/mypy/issues/13627

Locally I could bump mypy, there was just a very minor things to adjust. We could remove the mypy requirements file too. Not done yet in case we want to keep it for some reason.

@rgommers CI is mostly happy now, only 2 things remain.

scipy.scipy (Main Windows Python311-64bit-full-ilp64) fails with:

scipy\_lib\_ccallback_c.c(198): fatal error C1083: Cannot open include file: 'longintrepr.h': No such file or directory

Not sure, some suggest to update Cython? Might be due to these lines PyLong_AsVoidPtr(long(context_obj))

macOS tests (setup.py) / macOS Test Matrix (3.9, --upgrade numpy) (pull_request) fails with:

I don't know.

I just think we should follow the NEP. 1.21 is supposed to be dropped around our release time in June.

Perhaps we can compromise. To get back on track with NEP 29 without a huge jump in one release:

Release SciPy 1.11.0 on or after June 23, 2023, and make NumPy 1.21 the minimum supported version for that release.
Release SciPy 1.12.0 on or after January 1, 2024, and make NumPy 1.23 the minimum supported version for that release.

The Mypy error is a known bug and we would need to update mypy to work on Python 3.10. At least 0.981. python/mypy#13627
Not sure why we are pinning to 0.931. Also mypy 1.0 is out with great speed bump.

The exact version doesn't matter, a bump is usually fine. We do need to pin to an exact version because new Mypy versions very often have both regressions and changes in behavior. And even plain improvements result in errors, because #type: ignore commands for things that are supported in a newer version result in a complaint about an unnecessary skip IIRC.

scipy.scipy (Main Windows Python311-64bit-full-ilp64) fails with:

I suggest separating the problems here a bit. Just do not bump the version from 3.10 to 3.11 and open an issue for this one to fix in a separate PR.

2 remaining issues. I don't get what is missing.
For Azure I have no clue. For the macOS job, maybe linked to the pyproject.toml deps definition?? It seems to install but then fails in pip.

gh-17950 is now merged, so this may need a tweak/rebase.

@rgommers I did the rebase.
Seems like the macOS test is now ok (some timeout I think we just got a slow node seeing the runtime).
For the Azure one, still the same issue though.

I've just replicated the issue with the azure pipelines job in a i386/ubuntu:focal docker container on my own computer.
I can get it to work with more recent build tools:
apt-get install -y build-essential gfortran

I don't know about why gcc-8 is used here, can we transfer to a more recent set of build tools? I think gcc-9 is the default on focal.
Furthermore, it may be cleaner to transfer this job to Github Actions. The current script has a whole bunch of && \ to squeeze the job into a single multiline string. I personally find the azure-pipelines.yml way of scripting quite complicated to follow.
We should be able to do something like this in GHA:
jobs:
  Linux_Python_38_32bit_full:
    runs-on: ubuntu-latest
    container:
      image: "i386/ubuntu:focal"
    steps:
      - run: |
        # do the test run

Thanks for the help @andyfaff. I updated Cython and GCC. Let's see how it goes. If that passes, we will be left with the macOS job.

@rgommers all is running. Now the CI failure is with 2 tests in spectral
FAILED ../../signal/tests/test_spectral.py::TestPeriodogram::test_nd_axis_m1
FAILED ../../signal/tests/test_spectral.py::TestPeriodogram::test_nd_axis_0

_______________________ TestPeriodogram.test_nd_axis_m1 ________________________
[gw0] linux -- Python 3.9.5 /usr/bin/python3.9
/usr/local/lib/python3.9/dist-packages/scipy-1.11.0.dev0+unknown.unknown-py3.9-linux-i686.egg/scipy/signal/tests/test_spectral.py:105: in test_nd_axis_m1
    assert_array_almost_equal_nulp(p0[np.newaxis,:], p[1,:], 60)
E   AssertionError: X and Y are not equal to 60 ULP (max is 4.10548e+18)
...
________________________ TestPeriodogram.test_nd_axis_0 ________________________
[gw0] linux -- Python 3.9.5 /usr/bin/python3.9
/usr/local/lib/python3.9/dist-packages/scipy-1.11.0.dev0+unknown.unknown-py3.9-linux-i686.egg/scipy/signal/tests/test_spectral.py:115: in test_nd_axis_0
    assert_array_almost_equal_nulp(p0, p[:,1,0])
E   AssertionError: X and Y are not equal to 1 ULP (max is 4.10548e+18)
...

What should we do? xfail on 32bits?

It looks like the test needs tweak. The _nulp assert seems to be failing on comparing 0 and 3.0...e-34. So changing it to use a different test function with atol=1e-33 is probably fine. Not 100% sure though without spending more time - for signal processing functions such small absolute numbers are sometimes relevant.
So how about skipping (not xfailing) the test here, and then opening a follow-up PR changing to assert_allclose? That way we can get this merged, and get some help from the signal experts on a much smaller PR.

@rgommers CI is green.

Mistake rebased push the wrong thing, hopefully I did not break anything 😒

Azure did not like the rebase, but seems all good otherwise.

Anything else to do here?

Thanks all 😃


Support SAM2

Would be awesome to support sam2!
https://ai.meta.com/sam2/
There's an implementation of the original sam:
https://github.com/elixir-image/image/blob/main/livebook/segment_anything.livemd
https://elixirforum.com/t/running-facebooks-segmentation-model-using-ortex/63422/13
It also ortex.

Hi! Thank You for reaching out! Right now there is no memory bank export in onnx for the SAM2 model (it is said to be exported 'soon'), so the functionality would be the same as in SAM (video tracking would not work). We are not plannig on doing the export on our own at this time, but this might change in the future

It looks like someone has now done it?
Is that all that's needed?
https://github.com/axinc-ai/segment-anything-2


Update license with Copyright line

Solves #245
Added the copyright line. Now it has the year (inclusive of 2018) along with the Org name

Hey can someone please review this?

This repo will be getting archived soon,closing.
Thanks for the PR.


4.0.3

Network Protocol Change, Version Bump, New Checkpoint

Validated changes and no issue in code changes

Removed version bump for compatibility and added additional checkpoints. Once checks pass I will create a public 4.0.3 release.


Integration with Angular-cli

How Will I integrate this angular2-data-Table with angular-cli ? Can you please show me a roadmap ?

This is not ready for use yet, I'll update you when its ready :)

GodSpeed :D :D

@amcdnl Could you please mention this in the README? Thanks for your work!

It is ready for use now, I haven't used Angular-CLI can you guys provide feedback?

Can you retry, this should be fixed now.

AngularCLI is changing quite a bit, I'm gonna hold on too much hacking on it until its stabilized. See: https://twitter.com/ladyleet/status/755961596396998656

Adding an index.d.ts shouldn't be too much of an issue it seems? It's the default way of providing an entry point to a package. Even without considering angular-cli it would be nice.

Merged his change, I'll release update shortly if you guys wanna retest

Any updates here?

Did you release it to npm?

Yes :)

Is there way to use this modul in angular-cli ? Your npm release is 2 weeks ago.

I'm not sure I follow, can u give an example?

I have problem with importing module, ng build shows error 'Cannot find module 'angular2-data-table'. I have latest version 0.1.15 from npm.

I think the problem is that there is no npm release which includes this pull request, because this code has been merged a week ago and the last npm release is from two weeks ago.

With 0.1.16 I am getting the following errors:
Right in the editor, when importing, I get:
Exported external package typings file 'c:/Users/user/project/node_modules/angular2-data-table/release/angular2-data-table.d.ts' is not a module. Please contact the package author to update the package definition.

Then when building with webpack I get:
ERROR in [default] C:\Users\user\project\node_modules\angular2-data-table\release\angular2-data-table.d.ts:1:0
Cannot find type definition file for 'core-js'.

ERROR in [default] C:\Users\user\project\node_modules\angular2-data-table\release\angular2-data-table.d.ts:161:18
Cannot find name 'IntersectionObserver'.

ERROR in [default] C:\Users\user\project\node_modules\angular2-data-table\release\angular2-data-table.d.ts:420:4
Import or export declaration in an ambient module declaration cannot reference module through relative module name.

I am using angular-cli: 1.0.0-beta.11-webpack.2.

I make it work with 1.0.0-beta.11-webpack.2. Not sure there is any better solution, but it's work for my project.

'core-js' it needs to change tsconfig.ts of angular2-data-table to use es6 and dom libs instead of core-js. it's same as tsconfig.ts that created from angular-cli.

    "lib": ["es6", "dom"],
    "types": [
      "node"
    ]

IntersectionObserver is in the custom-typings.d.ts. I'm not sure why it definition is not include in release/angular2-data-table.d.ts file. I should change some tsconfig, but I not found it. So I just move this interface to ts file.

Maybe we should add some better docs, packaging of this stuff is pretty edge right now so its a learning curve for all of us

The @work-k cheat works to me! Thanks!

@amcdnl I could write the how to configure using angular-cli if you wish it. Should I create an new file .md in the documentation directory?

Ya, that would be awesome!

I am getting loads of new errors when building with webpack through angular-cli. Every import from release/angular2-data-table.d.ts is failing.

@adrm can u try on 0.2.4? I think ( * fingers crossed * ) that fixed it :),.,,,plz let me know

using 0.2.4 I get the following error after importing Angular2DataTableModule...
ERROR in [default] /Users/jared/code/project/node_modules/angular2-data-table/release/models/TableOptions.d.ts:1:0
Cannot find type definition file for 'core-js'.

@szechyjs Interesting, others have reported this issue. We are using TS 2.0 internally with the core-js types set in the tsconfig - https://github.com/swimlane/angular2-data-table/blob/master/tsconfig.json#L24. Try setting that and see what happens.
@DanielRosenwasser any thoughts on best solution for these guys?

One issue is that the 'types' field in your package.json won't work for 1.8 users. You can use the typings field in the mean time. I'll see how possible it would be to update 1.8 to understand 'types'.
Also, if you're on TS 2.0 and depending on @types/core-js, something that should generally work for pre-2.0 users is to add the core-js declaration file via Typings. So your library consumers would write:
typings install --global dt~core-js

Same way they've always used Typings. Hope that helps!

@DanielRosenwasser Whats the best way to include that as part of the project for users? Include typings as part of the project?

@types is the best way to include the appropriate.d.ts files. That's actually part of the reason that we did it for 2.0.
I'm not aware of how others can transitively make their dependencies available when using typings though. It's a pretty manual process at this point unfortunately.

But definitely don't include the files you installed from typings in your repo - that will only cause a bunch of other problems (due to versioning and conflicts if you have duplicates).

I've been trying to get this running using angular-cli for a few days, thanks for the new docs and work btw. Any help would be great!
Following the angular-cli install instructions, I've made these changes to get the import to work in my component:
/** Map relative paths to URLs. */
const map: any = {
// 'angular2-data-table': 'vendor/angular2-data-table/release', // original line
   'angular2-data-table': 'vendor/angular2-data-table',
};

/** User packages configuration. */
const packages: any = {
// 'vendor/angular2-data-table/release': { // original line
   'vendor/angular2-data-table': {
      defaultExtension: 'js',
      main: 'angular2-data-table.js'
  }
};

The angular-cli-build.js was edited per the angular-cli install doc.: https://github.com/swimlane/angular2-data-table/blob/master/docs/introduction/installing.md#integration-with-angular-cli
This makes the @import this: from 'angular2-data-table/release/angular2-data-table'; opposed to the more normal and expected: from 'angular2-data-table';
and then things go sideways with unset requires..
http://localhost:4200/vendor/angular2-data-table/release/components/datatable.scss.js as "./datatable.scss" from http://localhost:4200/vendor/angular2-data-table/release/components/DataTable.js ; Zone:  ; Task: Promise.then ; Value: Error: Error: XHR error (404 Not Found) loading http://localhost:4200/vendor/angular2-data-table/release/components/datatable.scss.js(…)

Using 0.2.5
ERROR in [default] /node_modules/angular2-data-table/release/models/TableOptions.d.ts:1:0
Cannot find type definition file for 'core-js'.
node_modules\angular2-data-table\tsconfig.js looks like this:
"lib":["es6","dom"],
"types": [
"node"
]
node_modules\typescript\package.json
...
"raw"<EMAIL_ADDRESS>...

Can one of you guys encountering this issue extract your code to github repo that illustrates the issue?

I want to help but kinda new to this, can you please be more exact in your needs ? I supose you want everything but the node_modules folder ?

Make a demo project that illustrates the issue please.

https://github.com/dave1374/angular2-data-table-.0.2.5-issue
removed the node_modules folder.
Hope it helps.

Removing ///  from
node_modules\angular2-data-table\release\models\TableOptions.d.ts
allows me to build successfully.

I just upgraded angular-cli + ng2-inline-editor + angular2-data-table and everything is working properly if you remove the line commented by @dave1374. Thanks!

0.3.3 shouldn't have that comment at all.

@amcdnl I just downloaded from npm (angular2-data-table-0.3.3).


Add JSON container for text db column

Codecov Report

Merging #17 (7abf42a) into master (bbd477b) will decrease coverage by 1.67%.
The diff coverage is 0.00%.

:exclamation: Current head 7abf42a differs from pull request most recent head b8c0988. Consider uploading reports for the commit b8c0988 to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
- Coverage   72.76%   71.10%   -1.67%
==========================================
  Files           5        5
  Lines         470      481      +11
==========================================
  Hits          342      342
- Misses        113      124      +11
  Partials       15       15

Flag
Coverage Δ

unittests
71.10% <0.00%> (-1.67%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

storage_go1.18.go
9.37% <0.00%> (-1.95%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Hostnames not resolving breaks some features of the cluster

Hi,
In a typical OpenStack cluster, and as far as I know, the hostname of the VMs will not resolve in DNS. This is causing issues for certain commands (notably "kubectl exec" and "kubectl logs") which expect the hostnames of the kuebernetes-worker units to be resolve on the kubernetes-master units.
The workaround we're using is to add the IP and hostnames to /etc/hosts on the kubernetes-master units. This workaround, even though dirty, could make its way into the kubernetes-master charm : since it's already related to the kubernetes-worker application, it shouldn't be too hard to gather all the IPs / hostnames and stash them in /etc/hosts.
I don't have another solution to propose, but perhaps you do ?
Thanks

Hostname hacks are messy, as they can wind up leaving stale entries behind, get out of sync after reboots and other variations of this. We piloted a similar approach in the big data charms a long time ago and it did create a lot of problems.
I'm not entirely opposed to finding a working solution for the OpenStack users out there, but ideally, FQDN should be a thing every cloud supports. I realize that's a big ask. There was also talk of having juju support this natively, however, I haven't looked at that in quite some time and I'm not even positive it landed outside of the LXD scope.
I think we need to revisit this line item and hash this out for a roadmap discussion or find a suitable way to provide cluster-level hostname DNS out of band of the cloud provider (perhaps with our own dnsmasq workaround provided by a charm running on the masters providing another set of DNS, but we have to be cognizant of the fact there's a limit to how many dns servers a host can have and I imagine that many cloud providers are already filling this list up before we can go stuffing our noses in the resolver)

@axinojolais
To confirm your environment are you running in any containers and what is the Juju version you are using.
-thanks,
Antonio

@arosales this is running on KVM instances, no container involved. And this is deployed with juju 2 (currently 2.0.2)

related to https://github.com/juju-solutions/bundle-canonical-kubernetes/issues/171
closing in favor of the original bug which documents this pretty extensively.


Training loss and validation loss are too low

Thanks for the implementation and the tutorial.
I have a general question regarding the training and the validation loss.
I created a model which is inspired by your work here to do prediction on knowledge base triples.
My model uses hinge loss and cosine similarity between positive and negative training instance:
loss = max(0, margin - sim(pos_triple) + sim(neg_triple))
When I train the model,  I getting too small values for the training and the validation losses from the first epoch and after few epoch the validation loss is becoming zero.
Did you experienced similar behavior in your experiments? Could anybody  provide an explanation?
Best,

I believe this is normal. The validation loss going to zero does not mean your model is perfect, since the positive and negative examples might not be the most challenging ones that the model will face. In fact, in the actual paper they trained for significantly more epochs after the validation loss was sometimes zero. An interesting challenge might be to figure out how to make sure the examples presented are the most challenging ones.

Thanks for the answer!


Please add a confirmation message on the "delete offline files" button.

I accidentally fat fingered the "delete offline files" button and lost about a month of progress. I wouldn't be surprised if others also have done this or will do it in the future even though not many play offline from what I can see. So please just add a confirmation message upon tapping that button.

Delete offline files is referring to the game files, not your save files. Your saves should be perfectly fine as long as you go redownload the game.

I tried that a few times and thought it wouldn't work since the download was taking a lot longer than before but I just now tried it again and it downloaded after like 40 minutes and my save is still fine. So, thanks for the help. Though I still feel like there should be a confirmation message for hopefully obvious reasons.

Yeah that's fair, it probably should have a confirmation anyways.

For me I can't download it at all, it pops up with a "Index 1 out of range [0..1)" error

(after deleting offline files accidentally)