Webpack loader broken on Node 20

Bug description
This works on Node 18- but not on 20
cross-env NODE_OPTIONS="--loader tsx" webpack

Reproduction
npm init -y
npm install tsx webpack webpack-cli
echo 'export default {}' > webpack.config.ts
NODE_OPTIONS="--loader tsx" npx webpack

Node 20
(node:84039) ExperimentalWarning: Custom ESM Loaders is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
[webpack-cli] Unable load './webpack.config.ts'
[webpack-cli] Unable to use specified module loaders for ".ts".
[webpack-cli] Cannot find module 'ts-node/register' from '.'
[webpack-cli] Cannot find module 'sucrase/register/ts' from '.'
[webpack-cli] Cannot find module '@babel/register' from '.'
[webpack-cli] Cannot find module 'esbuild-register/dist/node' from '.'
[webpack-cli] Cannot find module '@swc/register' from '.'
[webpack-cli] Please install one of them

Node 18
 NODE_OPTIONS="--loader tsx" webpack
(node:84137) ExperimentalWarning: Custom ESM Loaders is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
(node:84137) ExperimentalWarning: Custom ESM Loaders is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
(node:84137) ExperimentalWarning: Custom ESM Loaders is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
(node:84137) ExperimentalWarning: Custom ESM Loaders is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
assets by status 99 bytes [cached] 1 asset

WARNING in configuration
The 'mode' option has not been set, webpack will fallback to 'production' for this value.
Set 'mode' option to 'development' or 'production' to enable defaults for each environment.
You can also set it to 'none' to disable any default behavior. Learn more: https://webpack.js.org/configuration/mode/

ETC..
ETC..
ETC..

Environment
System:
    OS: macOS 13.4.1
    CPU: Intel i9
    Memory: 138.69 MB / 16.00 GB
    Shell: 3.6.1 - /usr/local/bin/fish
  Binaries:
    Node: 20.1.0 - /usr/local/bin/node
    Yarn: 1.22.11 - /usr/local/bin/yarn
    npm: 9.6.4 - /usr/local/bin/npm
  npmPackages:
    tsx: ^3.12.7 => 3.12.7

Can you work on a fix?

[ ] I’m interested in opening a pull request to address this issue.

Note that this appears to be a common Node 20 issue:

https://github.com/TypeStrong/ts-node/issues/1997

I also reported it on webpack’s repo:

https://github.com/webpack/webpack-cli/issues/3889

Note that this appears to be a common Node 20 issue:

https://github.com/TypeStrong/ts-node/issues/1997

Thanks for your issue.
But I'm actually unable to reproduce the same error you're getting. Can you provide a repository link so I can easily reproduce it? I think I'm either missing files or getting the wrong dependency versions.
> node -v
v18.18.2

> NODE_OPTIONS="--loader tsx" npx webpack
(node:46393) ExperimentalWarning: Custom ESM Loaders is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
(node:46393) ExperimentalWarning: Custom ESM Loaders is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
(node:46409) ExperimentalWarning: Custom ESM Loaders is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
(node:46409) ExperimentalWarning: Custom ESM Loaders is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
(node:46409) ExperimentalWarning: Custom ESM Loaders is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
(node:46409) ExperimentalWarning: Custom ESM Loaders is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
assets by status 99 bytes [cached] 1 asset

WARNING in configuration
The 'mode' option has not been set, webpack will fallback to 'production' for this value.
Set 'mode' option to 'development' or 'production' to enable defaults for each environment.
You can also set it to 'none' to disable any default behavior. Learn more: https://webpack.js.org/configuration/mode/

ERROR in main
Module not found: Error: Can't resolve './src' in '/Users/pn/Desktop/test-tsx-279'
resolve './src' in '/Users/pn/Desktop/test-tsx-279'
  using description file: /Users/pn/Desktop/test-tsx-279/package.json (relative path: .)
    Field 'browser' doesn't contain a valid alias configuration
    using description file: /Users/pn/Desktop/test-tsx-279/package.json (relative path: ./src)
      no extension
        Field 'browser' doesn't contain a valid alias configuration
        /Users/pn/Desktop/test-tsx-279/src doesn't exist
      .js
        Field 'browser' doesn't contain a valid alias configuration
        /Users/pn/Desktop/test-tsx-279/src.js doesn't exist
      .json
        Field 'browser' doesn't contain a valid alias configuration
        /Users/pn/Desktop/test-tsx-279/src.json doesn't exist
      .wasm
        Field 'browser' doesn't contain a valid alias configuration
        /Users/pn/Desktop/test-tsx-279/src.wasm doesn't exist
      as directory
        /Users/pn/Desktop/test-tsx-279/src doesn't exist

ERROR in main.js
main.js from Terser plugin
__name is not defined
ReferenceError: __name is not defined
    at terserMinify (eval at transform (/Users/pn/Desktop/test-tsx-279/node_modules/terser-webpack-plugin/dist/minify.js:2:448), <anonymous>:4:361)
    at minify (/Users/pn/Desktop/test-tsx-279/node_modules/terser-webpack-plugin/dist/minify.js:22:10)
    at Object.transform (/Users/pn/Desktop/test-tsx-279/node_modules/terser-webpack-plugin/dist/minify.js:43:10)
    at execFunction (/Users/pn/Desktop/test-tsx-279/node_modules/jest-worker/build/workers/threadChild.js:148:17)
    at execHelper (/Users/pn/Desktop/test-tsx-279/node_modules/jest-worker/build/workers/threadChild.js:127:5)
    at execMethod (/Users/pn/Desktop/test-tsx-279/node_modules/jest-worker/build/workers/threadChild.js:131:5)
    at MessagePort.messageListener (/Users/pn/Desktop/test-tsx-279/node_modules/jest-worker/build/workers/threadChild.js:49:7)
    at [nodejs.internal.kHybridDispatch] (node:internal/event_target:757:20)
    at exports.emitMessage (node:internal/per_context/messageport:23:28)

webpack 5.89.0 compiled with 2 errors and 1 warning in 210 ms

Your logs say node 18, but the issue appears on node 20.

I tried both. Same error with Node.js 20:
$ node -v
v20.9.0

$ NODE_OPTIONS="--import tsx" npx webpack
assets by status 99 bytes [cached] 1 asset

WARNING in configuration
The 'mode' option has not been set, webpack will fallback to 'production' for this value.
Set 'mode' option to 'development' or 'production' to enable defaults for each environment.
You can also set it to 'none' to disable any default behavior. Learn more: https://webpack.js.org/configuration/mode/

ERROR in main
Module not found: Error: Can't resolve './src' in '/Users/pn/Desktop/test-tsx-279'
resolve './src' in '/Users/pn/Desktop/test-tsx-279'
  using description file: /Users/pn/Desktop/test-tsx-279/package.json (relative path: .)
    Field 'browser' doesn't contain a valid alias configuration
    using description file: /Users/pn/Desktop/test-tsx-279/package.json (relative path: ./src)
      no extension
        Field 'browser' doesn't contain a valid alias configuration
        /Users/pn/Desktop/test-tsx-279/src doesn't exist
      .js
        Field 'browser' doesn't contain a valid alias configuration
        /Users/pn/Desktop/test-tsx-279/src.js doesn't exist
      .json
        Field 'browser' doesn't contain a valid alias configuration
        /Users/pn/Desktop/test-tsx-279/src.json doesn't exist
      .wasm
        Field 'browser' doesn't contain a valid alias configuration
        /Users/pn/Desktop/test-tsx-279/src.wasm doesn't exist
      as directory
        /Users/pn/Desktop/test-tsx-279/src doesn't exist

ERROR in main.js
main.js from Terser plugin
__name is not defined
ReferenceError: __name is not defined
    at terserMinify (eval at transform (/Users/pn/Desktop/test-tsx-279/node_modules/terser-webpack-plugin/dist/minify.js:2:448), <anonymous>:4:361)
    at minify (/Users/pn/Desktop/test-tsx-279/node_modules/terser-webpack-plugin/dist/minify.js:22:10)
    at Object.transform (/Users/pn/Desktop/test-tsx-279/node_modules/terser-webpack-plugin/dist/minify.js:43:10)
    at execFunction (/Users/pn/Desktop/test-tsx-279/node_modules/jest-worker/build/workers/threadChild.js:148:17)
    at execHelper (/Users/pn/Desktop/test-tsx-279/node_modules/jest-worker/build/workers/threadChild.js:127:5)
    at execMethod (/Users/pn/Desktop/test-tsx-279/node_modules/jest-worker/build/workers/threadChild.js:131:5)
    at MessagePort.messageListener (/Users/pn/Desktop/test-tsx-279/node_modules/jest-worker/build/workers/threadChild.js:49:7)
    at [nodejs.internal.kHybridDispatch] (node:internal/event_target:807:20)
    at exports.emitMessage (node:internal/per_context/messageport:23:28)

webpack 5.89.0 compiled with 2 errors and 1 warning in 81 ms

I get the error you're reporting without tsx though:
$ node -v
v20.9.0

$ npx webpack
[webpack-cli] Unable load '/Users/pn/Desktop/test-tsx-279/webpack.config.ts'
[webpack-cli] Unable to use specified module loaders for ".ts".
[webpack-cli] Cannot find module 'ts-node/register' from '/Users/pn/Desktop/test-tsx-279'
[webpack-cli] Cannot find module 'sucrase/register/ts' from '/Users/pn/Desktop/test-tsx-279'
[webpack-cli] Cannot find module '@babel/register' from '/Users/pn/Desktop/test-tsx-279'
[webpack-cli] Cannot find module 'esbuild-register/dist/node' from '/Users/pn/Desktop/test-tsx-279'
[webpack-cli] Cannot find module '@swc/register' from '/Users/pn/Desktop/test-tsx-279'
[webpack-cli] Please install one of them

I'm closing this as it doesn't seem to be a tsx issue.
Please provide a minimal reproduction when opening an issue next time so we save each other time.

Please provide a minimal reproduction when opening an issue next time so we save each other time.

Uh, I didn't? There's a section called "reproduction" and it shows the exact issue I'm talking about.

I get the error you're reporting without tsx though:

Yeah, that's why I used tsx, to fix the error. Did you read the entire report? I thought it was pretty specific and it's obvious that it's a regression between Node 18 and 20.

The solution here comes from a message that a later Webpack or Node version added:
node:internal/process/esm_loader:48
      internalBinding('errors').triggerUncaughtException(
                                ^
Error: tsx must be loaded with --import instead of --loader
The --loader flag was deprecated in Node v20.6.0

This appears to work:
NODE_OPTIONS="--import tsx" npx webpack


[wip] standardize waits

This is based from #226 and as such depends on that being merged first (at which point I'll rebase).
For that reason I'm going to open this mainly for CI and then close it.
This attempts to remove the usage of Timeout.timeout as discussed in #226 and to standardize our use of waiting to use Capybara when possible.  (The Capybara team has put a lot of effort into that aspect of Capybara and we should leverage it whenever possible.)  As such I added a new waiter method wait_with_capybara on the utility Waiter class.  This method optionally takes an Error that will be raised if Capybara fails in the block passed to it.  (I did consider putting this on Capybara itself but this is probably the safer approach.)
Also, I wrote this on a flight to Korea where I'll be on vacation for the next few weeks - so just FYI I might be pretty quiet for a bit, sorry!  (mostly @ Luke)

OK, CI checks out.  I'll close this until 226 is picked up.


[Snyk] Security upgrade react-scripts from 3.4.0 to 5.0.0

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

templates/community/ipfs-music-player/package.json

Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Breaking Change
Exploit Maturity

696/1000  Why? Proof of Concept exploit, Has a fix available, CVSS 7.5
Regular Expression Denial of Service (ReDoS) SNYK-JS-ANSIREGEX-1583908
Yes
Proof of Concept

586/1000  Why? Proof of Concept exploit, Has a fix available, CVSS 5.3
Regular Expression Denial of Service (ReDoS) SNYK-JS-BROWSERSLIST-1090194
Yes
Proof of Concept

479/1000  Why? Has a fix available, CVSS 5.3
Regular Expression Denial of Service (ReDoS) SNYK-JS-CSSWHAT-1298035
Yes
No Known Exploit

586/1000  Why? Proof of Concept exploit, Has a fix available, CVSS 5.3
Regular Expression Denial of Service (ReDoS) SNYK-JS-GLOBPARENT-1016905
Yes
Proof of Concept

696/1000  Why? Proof of Concept exploit, Has a fix available, CVSS 7.5
Prototype Pollution SNYK-JS-IMMER-1019369
Yes
Proof of Concept

601/1000  Why? Proof of Concept exploit, Has a fix available, CVSS 5.6
Prototype Pollution SNYK-JS-IMMER-1540542
Yes
Proof of Concept

429/1000  Why? Has a fix available, CVSS 4.3
Reverse Tabnabbing SNYK-JS-ISTANBULREPORTS-2328088
Yes
No Known Exploit

586/1000  Why? Proof of Concept exploit, Has a fix available, CVSS 5.3
Open Redirect SNYK-JS-NODEFORGE-2330875
Yes
Proof of Concept

529/1000  Why? Has a fix available, CVSS 6.3
Prototype Pollution SNYK-JS-NODEFORGE-2331908
Yes
No Known Exploit

494/1000  Why? Has a fix available, CVSS 5.6
Improper Verification of Cryptographic Signature SNYK-JS-NODEFORGE-2430337
Yes
No Known Exploit

579/1000  Why? Has a fix available, CVSS 7.3
Improper Verification of Cryptographic Signature SNYK-JS-NODEFORGE-2430339
Yes
No Known Exploit

494/1000  Why? Has a fix available, CVSS 5.6
Improper Verification of Cryptographic Signature SNYK-JS-NODEFORGE-2430341
Yes
No Known Exploit

696/1000  Why? Proof of Concept exploit, Has a fix available, CVSS 7.5
Regular Expression Denial of Service (ReDoS) SNYK-JS-NTHCHECK-1586032
Yes
Proof of Concept

686/1000  Why? Proof of Concept exploit, Has a fix available, CVSS 7.3
Prototype Pollution SNYK-JS-OBJECTPATH-1017036
No
Proof of Concept

494/1000  Why? Has a fix available, CVSS 5.6
Prototype Pollution SNYK-JS-OBJECTPATH-1569453
No
No Known Exploit

590/1000  Why? Has a fix available, CVSS 7.3
Prototype Pollution SNYK-JS-OBJECTPATH-1585658
No
No Known Exploit

586/1000  Why? Proof of Concept exploit, Has a fix available, CVSS 5.3
Regular Expression Denial of Service (ReDoS) SNYK-JS-POSTCSS-1090595
Yes
Proof of Concept

586/1000  Why? Proof of Concept exploit, Has a fix available, CVSS 5.3
Regular Expression Denial of Service (ReDoS) SNYK-JS-POSTCSS-1255640
Yes
Proof of Concept

601/1000  Why? Proof of Concept exploit, Has a fix available, CVSS 5.6
Command Injection SNYK-JS-REACTDEVUTILS-1083268
Yes
Proof of Concept

706/1000  Why? Proof of Concept exploit, Has a fix available, CVSS 7.7
Arbitrary Code Injection SNYK-JS-SERIALIZEJAVASCRIPT-570062
No
Proof of Concept

619/1000  Why? Has a fix available, CVSS 8.1
Remote Code Execution (RCE) SNYK-JS-SHELLQUOTE-1766506
Yes
No Known Exploit

586/1000  Why? Proof of Concept exploit, Has a fix available, CVSS 5.3
Denial of Service (DoS) SNYK-JS-SOCKJS-575261
No
Proof of Concept

601/1000  Why? Proof of Concept exploit, Has a fix available, CVSS 5.6
Prototype Pollution SNYK-JS-YARGSPARSER-560381
No
Proof of Concept

(*) Note that the real score may have changed since the PR was raised.

Commit messages

Package name: react-scripts
    The new version differs by 250 commits.

221e511 Publish
6a3315b Update CONTRIBUTING.md
5614c87 Add support for Tailwind (#11717)
657739f chore(test): make all tests install with `npm ci` (#11723)
20edab4 fix(webpackDevServer): disable overlay for warnings (#11413)
69321b0 Remove cached lockfile (#11706)
3afbbc0 Update all dependencies (#11624)
f5467d5 feat(eslint-config-react-app): support ESLint 8.x (#11375)
e8319da [WIP] Fix integration test teardown / cleanup and missing yarn installation (#11686)
c7627ce Update webpack and dev server (#11646)
f85b064 The default port used by `serve` has changed (#11619)
544befe Update package.json (#11597)
9d0369b Fix ESLint Babel preset resolution (#11547)
d7b23c8 test(create-react-app): assert for exit code (#10973)
1465357 Prepare 5.0.0 alpha release
3880ba6 Remove dependency pinning (#11474)
8b9fbee Update CODEOWNERS
cacf590 Bump template dependency version (#11415)
5cedfe4 Bump browserslist from 4.14.2 to 4.16.5 (#11476)
50ea5ad allow CORS on webpack-dev-server (#11325)
63bba07 Upgrade jest and related packages from 26.6.0 to 27.1.0 (#11338)
960b21e Bump immer from 8.0.4 to 9.0.6 (#11364)
134cd3c Resolve dependency issues in v5 alpha (#11294)
b45ae3c Update CONTRIBUTING.md

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Prototype Pollution
🦉 Open Redirect
🦉 Prototype Pollution
🦉 More lessons are available in Snyk Learn

0x96056f683dddb4425855aafc9280bba5ce4615be903e0794df19402a85311d29


Enable tab bar item to response to href or action

use case: tap tab bar item to open camera
{
  "image": "https://raw.githubusercontent.com/Jasonette/Twitter-UI-example/master/images/home.png",
  "text": "Create Payment",
  "style": {
    "height": "21"
  },
  "url": "https://raw.githubusercontent.com/Jasonette/Twitter-UI-example/master/moments.json",
  "href": {
    "view": "PaymentViewController"
  },
  "action": {
    "type": "$util.alert",
    "options": {
      "title": "Good job!",
      "description": "You know how to press a button!"
    }
  }
}

Currently the body.footer.tab items can have url attribute, which assumes that the tab will open a new Jason view.
What @steve21124 is suggesting is it would be much more powerful if we support href or action attributes as well for each tab bar item, so for example,

Support href: tapping an item opens a modal view

{
  "tabs": {
    "items": [{
      "text": "home",
      "url": "..."
    }, {
      "text": "payment",
      "href": {
        "url": "https://....",
        "transition": "modal"
      }
    }]
  }
}

Support action: tapping one of the tab may open a camera

{
  "tabs": {
    "items": [{
      "text": "home",
      "url": "..."
    }, {
      "text": "camera",
      "action": {
        "type": "$media.camera",
        "success": {
         ...
        }
      }
    }]
  }
}

I think href is at least reasonable. And supporting action may be powerful but haven't had time to think much about what it would mean. There can be some scenarios where it's weird or too powerful that it's better not to support actions.
Anyone feel free to pitch in ideas, thanks!

I think href is at least reasonable. And supporting action may be powerful but haven't had time to think much about what it would mean. There can be some scenarios where it's weird or too powerful that it's better not to support actions.

It will be really important to think through if there are any deal-breaker reasons why an action wouldn't work... but there are a lot of apps (especially in ecommerce 😄 ) where a footer tab activates the camera to take a picture of a product, or selfie in a social media app.

I'm experimenting with supporting both action and href for tabs.
This feature is currently available on the super_tab branch. The syntax is as you would guess: Simply use href or action attributes in place of url.
The resulting markup may look something like this:
{
  ...
  "footer": {
    "tabs": {
      "items": [{
        "text": "home",
        "url": "https://...."
      }, {
        "text": "camera",
        "action": {
          "type": "$media.camera"
        }
      }, {
        "text": "modal",
        "href": {
          "url": "https://...",
          "transition": "modal",
          "options": {
            "message": "This will be passed as $params.message to the modal view"
          }
        }
      }]
    }
  }
}

Currently it's only on the iOS super_tab branch but I plan to implement this for Android as well. Please try and provide feedback. Would appreciate it!

OK now Android support as well: https://github.com/Jasonette/JASONETTE-Android/tree/super_tab


Fix BeaconBlockBodyCapella types

Fix containers to adhere to spec:
bls_to_execution_changes: List[SignedBLSToExecutionChange, MAX_BLS_TO_EXECUTION_CHANGES]

although you still have to argue with assemble by the looks of it :)


Caching for SourceMaps

@guybedford @asapach
I'm busy writing a dev server for SystemJS development. Whenever a file changes (or a page is refreshed), I bundle the source to send to the client. Since this is a dev server, we want source maps.
Here are timings with/without cache for source maps and no source maps.
no source maps | no cache
total build: 99 535ms
no source maps | with cache
total build: 5 083ms
source maps | no cache
total build: 110 303ms
concatenate SourceMaps: 6 265ms
source maps | with cache
total build: 11 973ms
concatenate SourceMaps: 6 322ms
It would seem, from these numbers, that the only real performance difference between sourcemaps and not, is this function. Specifically this routine.
It's clear that contatenateSourceMaps doesn't leverage the internal cache. I've had a look, but I'm unsure of what needs to happen to get it to.
Im happy to submit a PR, but I'm really not sure what actually should be checked or cached. @guybedford, don't know if you could point me in the right direction or get it to use the cache, that would be awesome! Would save a lot of time in development for my tool and for jspm bundle --watch.
🎉

@alexisvincent this would certainly be amazing and a big perf improvement. I previously suggested an approach for this in https://github.com/systemjs/builder/issues/209, based on minifying each load record individually and then storing the minified code along with the load record. There are a few details to work out around how reliable the compiled cache is based on the minification options and build options it is dependent on so the hard part is ensuring we express that relationship properly in the cache metadata.

Awesome, the approach I took with caching bundle assets was normalizedName#stringifiedOptions, stringifiedOptions is an ok first approximation but JSON.stringify({a: 1, b: 1}) !== JSON.stringify({b: 1, a:1}) But an object hash would make a better cache key. How much work would it take to introduce #209 into the codebase?

@alexisvincent there is a compile cache created here - https://github.com/systemjs/builder/blob/master/lib/compile.js#L121. This cache actually already takes into account the hashing of options in https://github.com/systemjs/builder/blob/master/lib/compile.js#L26.
I think what we'd need to do is:

Add a minifiedOutput (which is an object with a source and sourceMap key) to the compile cache.
Compute the minifiedOutput per module that is compiled after running the compilation, instead of doing minification as a single process at the end, so that the final step is only concatenation of minifiedOutput if minification is enabled or just concatenation of compiled output.
Add a minifyHash to the compile cache, which is basically a hash of the minification options (and source maps options), using the cached minifiedOutput if the compileHash cache is matched and the minifyHash is matched.

So the nice thing is that it is all work in the lib/compile.js file, the complexity is just getting on top of the existing logic in there.


Update rake to 12.0.0

Clean up of PR #144 (auto-closed after force push)

sorry, did not know i can reopen the old one


filesystem.js: Fix fsStats() linux block devices

The current implementation of fsStats is not working correctly.

@sergeysedoy97 thank you, can you provide output of
(current code)
lsblk 2>/dev/null | grep /

and
(suggestion)
lsblk 2>/dev/null -r | grep /

where you have incorrect outputs of fsStats()?
Thank you in advance.

@sergeysedoy97 thank you, can you provide output of
(current code)
lsblk 2>/dev/null | grep /

and
(suggestion)
lsblk 2>/dev/null -r | grep /

where you have incorrect outputs of fsStats()?
Thank you in advance.

|-sda1   8:1    0  200M  0 part /boot/efi
|-sda2   8:2    0   20G  0 part /
`-sda5   8:5    0 11.8G  0 part /data
~$ lsblk 2>/dev/null -r | grep /
sda1 8:1 0 200M 0 part /boot/efi
sda2 8:2 0 20G 0 part /
sda5 8:5 0 11.8G 0 part /data`

@sergeysedoy97 thank you so much ... I see an extra character at the beginning of the line. Just curious, which version of util-linux you are using?
lsblk --version

@sergeysedoy97 thank you so much ... I see an extra character at the beginning of the line. Just curious, which version of util-linux you are using?
lsblk --version

~$ lsblk --version
lsblk from util-linux 2.32.1

@sergeysedoy97 thank you, will provide the fix soon. Need to test one more thing here locally.

@sergeysedoy97 fixed along with another issue I just discovered. Version 5.2.7 just published. Thank you!


Warnings with HA 2024.10.0 beta

Logger: homeassistant.helpers.frame
Source: helpers/frame.py:188
First occurred: 10:51:18 (2 occurrences)
Last logged: 10:51:35

Detected that custom integration 'xiaomi_miot' validates schema outside the event loop, which will stop working in HA Core 2025.10 at custom_components/xiaomi_miot/core/miio2miot.py, line 89: tpl = cv.template(tpl), please report it to the author of the 'xiaomi_miot' custom integration
Detected that custom integration 'xiaomi_miot' validates schema outside the event loop, which will stop working in HA Core 2025.10 at custom_components/xiaomi_miot/core/miio2miot.py, line 138: tpl = cv.template(tpl), please report it to the author of the 'xiaomi_miot' custom integration

Try master branch.


at home state?

in the nest app I see if I'm at home or not. is this also possible to get this value from the adapter?
and is it also possible to use the nest protect smoke detectors as a movement sensor?

Hello
I installed the plugin
And what should I do next to see the thermostat iobroker?


Stores token in secure cookie and adds parsing middleware, logout path

Description
Stores token information on the client as a secure cookie, and adds middleware that parses the cookie and passes info to the http handlers in the context object
Verification Steps

[x] login.gov token is stored on client, eg can JWT_COOKIE in dev tools -> application -> storage -> cookies
[ ] ADR for token storage
[ ] for now, application works when user is not signed in

References

Pivotal story for this change

In my env, http://localhost:3000/auth/login-gov is giving me a blank page with no errors for the server or client:


Using ArcGIS to Manage Military Bases and Facilities - post PPT & video for Ops Server release

@jfrygeo check email reminder for details of what goes where.

Videos and links are here:
"\disldb\OpsServerStaging\2015_Q4\Resources\Videos\2015 UC Demo Theater Managing Bases and Facilities"
Powerpoint is here: \disldb\OpsServerStaging\2015_Q4\Resources\2015UCPresentations\2015UC_ManagingBasesAndFacilitiesDemoTheater.pptx @BobBooth

@jfrygeo - Thanks! Closing.


LINQ queries in v3.32 still using Newtonsoft

Describe the bug
If you have an entity class which looks like this...
public class Draw
{
    [JsonProperty(PropertyName = "createdOnFoo")]
    public DateTimeOffset CreatedOn { get; set; }
}

And you've defined a custom serializer, the LINQ query, when translated to SQL will look something like...
SELECT TOP 1 VALUE root FROM root WHERE root["createdOnFoo"] > "2023-02-07T15:04:14.6839662+00:00"
And if you get rid of the [JsonProperty] attribute, it will be
SELECT TOP 1 VALUE root FROM root WHERE root["CreatedOn"] > "2023-02-07T15:04:14.6839662+00:00"
even if your custom serializer specifies camel casing.
To Reproduce
See above.
Expected behavior
The translation from LINQ to SQL is not using the custom serializer to determine property names.
Actual behavior
The translation from LINQ to SQL should use the custom serializer to determine property names.
Environment summary
SDK Version:
OS Version Windows

Duplicate of #2685. Keeping the older issue open and closing this one.


Support API-only Rails apps

This is another take on #87, but without the propshaft dependency that caused a lot of problems for people using Sprockets.

Using:

gem 'mission_control-jobs', github: 'rails/mission_control-jobs', branch: 'api-mode'

Gives me this error:

=> Booting Puma
=> Rails 8.0.0 application starting in development
=> Run bin/rails server --help for more startup options
Exiting
/Users/gaspard/.asdf/installs/ruby/3.3.5/lib/ruby/gems/3.3.0/gems/railties-8.0.0/lib/rails/railtie/configuration.rb:109:in method_missing': undefined method assets' for an instance of Rails::Application::Configuration (NoMethodError)
Did you mean?  asset_host
from /Users/gaspard/.asdf/installs/ruby/3.3.5/lib/ruby/gems/3.3.0/bundler/gems/mission_control-jobs-9d6a8b3a7902/lib/mission_control/jobs/engine.rb:90:in block in <class:Engine>'         from /Users/gaspard/.asdf/installs/ruby/3.3.5/lib/ruby/gems/3.3.0/gems/railties-8.0.0/lib/rails/initializable.rb:32:in instance_exec'
from /Users/gaspard/.asdf/installs/ruby/3.3.5/lib/ruby/gems/3.3.0/gems/railties-8.0.0/lib/rails/initializable.rb:32:in run'         from /Users/gaspard/.asdf/installs/ruby/3.3.5/lib/ruby/gems/3.3.0/gems/railties-8.0.0/lib/rails/initializable.rb:61:in block in run_initializers'
from /Users/gaspard/.asdf/installs/ruby/3.3.5/lib/ruby/3.3.0/tsort.rb:231:in block in tsort_each'         from /Users/gaspard/.asdf/installs/ruby/3.3.5/lib/ruby/3.3.0/tsort.rb:353:in block (2 levels) in each_strongly_connected_component'
from /Users/gaspard/.asdf/installs/ruby/3.3.5/lib/ruby/3.3.0/tsort.rb:434:in each_strongly_connected_component_from'         from /Users/gaspard/.asdf/installs/ruby/3.3.5/lib/ruby/3.3.0/tsort.rb:352:in block in each_strongly_connected_component'
from /Users/gaspard/.asdf/installs/ruby/3.3.5/lib/ruby/3.3.0/tsort.rb:350:in each'         from /Users/gaspard/.asdf/installs/ruby/3.3.5/lib/ruby/3.3.0/tsort.rb:350:in call'
from /Users/gaspard/.asdf/installs/ruby/3.3.5/lib/ruby/3.3.0/tsort.rb:350:in each_strongly_connected_component'         from /Users/gaspard/.asdf/installs/ruby/3.3.5/lib/ruby/3.3.0/tsort.rb:229:in tsort_each'
from /Users/gaspard/.asdf/installs/ruby/3.3.5/lib/ruby/3.3.0/tsort.rb:208:in tsort_each'         from /Users/gaspard/.asdf/installs/ruby/3.3.5/lib/ruby/gems/3.3.0/gems/railties-8.0.0/lib/rails/initializable.rb:60:in run_initializers'
from /Users/gaspard/.asdf/installs/ruby/3.3.5/lib/ruby/gems/3.3.0/gems/railties-8.0.0/lib/rails/application.rb:440:in initialize!'         from /Users/gaspard/Documents/test/vipfishing_gateway/config/environment.rb:5:in '
from config.ru:3:in require_relative'         from config.ru:3:in block (2 levels) in '
from /Users/gaspard/.asdf/installs/ruby/3.3.5/lib/ruby/gems/3.3.0/gems/rack-3.1.8/lib/rack/builder.rb:108:in eval'         from /Users/gaspard/.asdf/installs/ruby/3.3.5/lib/ruby/gems/3.3.0/gems/rack-3.1.8/lib/rack/builder.rb:108:in new_from_string'
from /Users/gaspard/.asdf/installs/ruby/3.3.5/lib/ruby/gems/3.3.0/gems/rack-3.1.8/lib/rack/builder.rb:97:in load_file'         from /Users/gaspard/.asdf/installs/ruby/3.3.5/lib/ruby/gems/3.3.0/gems/rack-3.1.8/lib/rack/builder.rb:67:in parse_file'
from /Users/gaspard/.asdf/installs/ruby/3.3.5/lib/ruby/gems/3.3.0/gems/rackup-2.2.1/lib/rackup/server.rb:354:in build_app_and_options_from_config'         from /Users/gaspard/.asdf/installs/ruby/3.3.5/lib/ruby/gems/3.3.0/gems/rackup-2.2.1/lib/rackup/server.rb:263:in app'
from /Users/gaspard/.asdf/installs/ruby/3.3.5/lib/ruby/gems/3.3.0/gems/rackup-2.2.1/lib/rackup/server.rb:424:in wrapped_app'         from /Users/gaspard/.asdf/installs/ruby/3.3.5/lib/ruby/gems/3.3.0/gems/railties-8.0.0/lib/rails/commands/server/server_command.rb:76:in log_to_stdout'
from /Users/gaspard/.asdf/installs/ruby/3.3.5/lib/ruby/gems/3.3.0/gems/railties-8.0.0/lib/rails/commands/server/server_command.rb:36:in start'         from /Users/gaspard/.asdf/installs/ruby/3.3.5/lib/ruby/gems/3.3.0/gems/railties-8.0.0/lib/rails/commands/server/server_command.rb:145:in block in perform'
from internal:kernel:90:in tap'         from /Users/gaspard/.asdf/installs/ruby/3.3.5/lib/ruby/gems/3.3.0/gems/railties-8.0.0/lib/rails/commands/server/server_command.rb:136:in perform'
from /Users/gaspard/.asdf/installs/ruby/3.3.5/lib/ruby/gems/3.3.0/gems/thor-1.3.2/lib/thor/command.rb:28:in run'         from /Users/gaspard/.asdf/installs/ruby/3.3.5/lib/ruby/gems/3.3.0/gems/thor-1.3.2/lib/thor/invocation.rb:127:in invoke_command'
from /Users/gaspard/.asdf/installs/ruby/3.3.5/lib/ruby/gems/3.3.0/gems/railties-8.0.0/lib/rails/command/base.rb:178:in invoke_command'         from /Users/gaspard/.asdf/installs/ruby/3.3.5/lib/ruby/gems/3.3.0/gems/thor-1.3.2/lib/thor.rb:538:in dispatch'
from /Users/gaspard/.asdf/installs/ruby/3.3.5/lib/ruby/gems/3.3.0/gems/railties-8.0.0/lib/rails/command/base.rb:73:in perform'         from /Users/gaspard/.asdf/installs/ruby/3.3.5/lib/ruby/gems/3.3.0/gems/railties-8.0.0/lib/rails/command.rb:65:in block in invoke'
from /Users/gaspard/.asdf/installs/ruby/3.3.5/lib/ruby/gems/3.3.0/gems/railties-8.0.0/lib/rails/command.rb:143:in with_argv'         from /Users/gaspard/.asdf/installs/ruby/3.3.5/lib/ruby/gems/3.3.0/gems/railties-8.0.0/lib/rails/command.rb:63:in invoke'
from /Users/gaspard/.asdf/installs/ruby/3.3.5/lib/ruby/gems/3.3.0/gems/railties-8.0.0/lib/rails/commands.rb:18:in <main>'         from /Users/gaspard/.asdf/installs/ruby/3.3.5/lib/ruby/3.3.0/bundled_gems.rb:75:in require'
from /Users/gaspard/.asdf/installs/ruby/3.3.5/lib/ruby/3.3.0/bundled_gems.rb:75:in block (2 levels) in replace_require'         from /Users/gaspard/.asdf/installs/ruby/3.3.5/lib/ruby/gems/3.3.0/gems/bootsnap-1.18.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in require'
from bin/rails:4:in `'
➜  vipfishing_gateway git:(main)

Hey @HLFH, you'd need to add propshaft to your Gemfile as well, as instructed in the README change in this PR.

@rosa Ok all good, awesome! Great thank you @rosa.
# Active Job dashboard
gem "mission_control-jobs", github: "rails/mission_control-jobs", branch: "api-mode"
# Deliver assets for Rails: dependency of mission_control-jobs
gem "propshaft"

This PR can be merged.


Max concurrency for slash commands

I will use discord.py slash commands (does not support max concurrency)


Jupyter: Some lists and pd.DataFrames not opening in Data Viewer

Environment data

VS Code version: 1.53.2 (user setup)
Jupyter Extension version: v2021.2.576440691
Python Extension version (available under the Extensions sidebar): v2021.2.582707922
OS (Windows | Mac | Linux distro) and version: Windows_NT x64 10.0.19042
Python and/or Anaconda version: Python 3.7.8 64-bit
Type of virtual environment used: conda
Jupyter server running: Local

Expected behaviour
Opening all lists and pd.DataFrames in Data Viewer should display their contents.
Actual behaviour
Some lists and DataFrames are not displayed in  Data Viewer.
Steps to reproduce:

Make a list of files (paths to files)

import pathlib

# make a long path
path = pathlib.Path.cwd()
new_path = path / "some_analysis_folder_with_data" / "some_output_folder"
pathlib.Path(new_path).mkdir(parents=True, exist_ok=True)

# make long files in the folder
file_name_stem = "some_file_name_foooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo"
file_suffix = ".gz"

for i in range(1,8):
    new_file = new_path / f"{file_name_stem}_{i}{file_suffix}"
    pathlib.Path(new_file).touch()

new_files = [file for file in new_path.iterdir()]
# type(new_files[0]) # pathlib.WindowsPath
new_files # this list doesn't open in Data Viewer

Make a list of "fake" files, i.e., strings, not pathlib.WindowsPath objects

# make a new list (fake_files_list) similar to new_files, but with strings, not pathlib.WindowsPath objects
## make sure the elements in fake_files_list are as long as those in new_files

fake_folder_name = str(new_file.parent)
letters_for_fake_file = string.ascii_lowercase[:len(new_files)]
new_file_stem_len = len(str(new_file.stem[:-2]))

fake_files_list = []

for i in range(len(new_files)):
    fake_files_list.append(f"{fake_folder_name}\\{letters_for_fake_file[i]*new_file_stem_len}_{i}{file_suffix}")

for i in range(len(new_files)):
    assert len(fake_files_list[i]) == len(str(new_files[i])), f"ERROR: Lenghts are different for element {i}"

fake_files_list

fake_files_list opens in Data Viewer, but new_files doesn't. I have a similar issue with some DataFrames. The size of the Dataframe does not seem to matter.

Logs

Output for Jupyter in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Jupyter)

> ~\Anaconda3\envs\mobs_abm\python.exe -c "import pandas;print(pandas.__version__)"
Error 2021-02-19 22:09:28: Failure during variable extraction:
---------------------------------------------------------------------------
OverflowError                             Traceback (most recent call last)
<ipython-input-3-8fc409734a9b> in <module>()
----> 1 print(_VSCODE_getDataFrameRows(new_files, 0, 7))

<ipython-input-3-93cda1340104> in _VSCODE_getDataFrameRows(df, start, end)
    136     except:
    137         pass
--> 138     return _VSCODE_pd_json.to_json(None, rows, orient="table", date_format="iso")
    139
    140

C:\Users\Christine\Anaconda3\envs\mobs_abm\lib\site-packages\pandas\io\json\_json.py in to_json(path_or_buf, obj, orient, date_format, double_precision, force_ascii, date_unit, default_handler, lines, compression, index, indent)
     82         default_handler=default_handler,
     83         index=index,
---> 84         indent=indent,
     85     ).write()
     86

C:\Users\Christine\Anaconda3\envs\mobs_abm\lib\site-packages\pandas\io\json\_json.py in write(self)
    142             self.date_format == "iso",
    143             self.default_handler,
--> 144             self.indent,
    145         )
    146

C:\Users\Christine\Anaconda3\envs\mobs_abm\lib\site-packages\pandas\io\json\_json.py in _write(self, obj, orient, double_precision, ensure_ascii, date_unit, iso_dates, default_handler, indent)
    339             iso_dates,
    340             default_handler,
--> 341             indent,
    342         )
    343

C:\Users\Christine\Anaconda3\envs\mobs_abm\lib\site-packages\pandas\io\json\_json.py in _write(self, obj, orient, double_precision, ensure_ascii, date_unit, iso_dates, default_handler, indent)
    242             iso_dates,
    243             default_handler,
--> 244             indent,
    245         )
    246

C:\Users\Christine\Anaconda3\envs\mobs_abm\lib\site-packages\pandas\io\json\_json.py in _write(self, obj, orient, double_precision, ensure_ascii, date_unit, iso_dates, default_handler, indent)
    164             iso_dates=iso_dates,
    165             default_handler=default_handler,
--> 166             indent=indent,
    167         )
    168

OverflowError: Maximum recursion level reached
Error 2021-02-19 22:09:28: [Error: Failure during variable extraction:
---------------------------------------------------------------------------
OverflowError                             Traceback (most recent call last)
<ipython-input-3-8fc409734a9b> in <module>()
----> 1 print(_VSCODE_getDataFrameRows(new_files, 0, 7))

<ipython-input-3-93cda1340104> in _VSCODE_getDataFrameRows(df, start, end)
    136     except:
    137         pass
--> 138     return _VSCODE_pd_json.to_json(None, rows, orient="table", date_format="iso")
    139
    140

C:\Users\Christine\Anaconda3\envs\mobs_abm\lib\site-packages\pandas\io\json\_json.py in to_json(path_or_buf, obj, orient, date_format, double_precision, force_ascii, date_unit, default_handler, lines, compression, index, indent)
     82         default_handler=default_handler,
     83         index=index,
---> 84         indent=indent,
     85     ).write()
     86

C:\Users\Christine\Anaconda3\envs\mobs_abm\lib\site-packages\pandas\io\json\_json.py in write(self)
    142             self.date_format == "iso",
    143             self.default_handler,
--> 144             self.indent,
    145         )
    146

C:\Users\Christine\Anaconda3\envs\mobs_abm\lib\site-packages\pandas\io\json\_json.py in _write(self, obj, orient, double_precision, ensure_ascii, date_unit, iso_dates, default_handler, indent)
    339             iso_dates,
    340             default_handler,
--> 341             indent,
    342         )
    343

C:\Users\Christine\Anaconda3\envs\mobs_abm\lib\site-packages\pandas\io\json\_json.py in _write(self, obj, orient, double_precision, ensure_ascii, date_unit, iso_dates, default_handler, indent)
    242             iso_dates,
    243             default_handler,
--> 244             indent,
    245         )
    246

C:\Users\Christine\Anaconda3\envs\mobs_abm\lib\site-packages\pandas\io\json\_json.py in _write(self, obj, orient, double_precision, ensure_ascii, date_unit, iso_dates, default_handler, indent)
    164             iso_dates=iso_dates,
    165             default_handler=default_handler,
--> 166             indent=indent,
    167         )
    168

OverflowError: Maximum recursion level reached
	at k.extractJupyterResultText (c:\Users\Christine\.vscode\extensions\ms-toolsai.jupyter-2021.2.576440691\out\client\extension.js:49:572275)
	at k.deserializeJupyterResult (c:\Users\Christine\.vscode\extensions\ms-toolsai.jupyter-2021.2.576440691\out\client\extension.js:49:572394)
	at k.getDataFrameRows (c:\Users\Christine\.vscode\extensions\ms-toolsai.jupyter-2021.2.576440691\out\client\extension.js:49:570203)
	at async r.getRows (c:\Users\Christine\.vscode\extensions\ms-toolsai.jupyter-2021.2.576440691\out\client\extension.js:49:210853)
	at async c:\Users\Christine\.vscode\extensions\ms-toolsai.jupyter-2021.2.576440691\out\client\extension.js:49:206244
	at async C.wrapRequest (c:\Users\Christine\.vscode\extensions\ms-toolsai.jupyter-2021.2.576440691\out\client\extension.js:49:206473)]

Log from Extension Host.
[2021-02-19 22:02:01.803] [exthost] [warning] [Decorations] CAPPING events from decorations provider vscode.git 4157
[2021-02-19 22:06:00.763] [exthost] [info] ExtensionService#_doActivateExtension vscode.typescript-language-features {"startup":false,"extensionId":{"value":"vscode.typescript-language-features","_lower":"vscode.typescript-language-features"},"activationEvent":"onLanguage:jsonc"}
[2021-02-19 22:06:00.764] [exthost] [info] ExtensionService#loadCommonJSModule file:///c:/Users/Christine/AppData/Local/Programs/Microsoft VS Code/resources/app/extensions/typescript-language-features/dist/extension
[2021-02-19 22:06:06.486] [exthost] [warning] [Decorations] CAPPING events from decorations provider vscode.git 4157

Thanks for reporting it @maciejkos, and thanks for your detailed repro steps. I can also get it using regular python.
I'll bring this up in our next meeting.

@joyceerhl , please check to see if this is a regression.

Not a regression, same behavior exists in the December release. Root cause is new_files is an array of Python objects, and we don't support viewing arrays of objects right now. @maciejkos would you expect to see the string representation of the path objects in the data viewer when viewing new_files?

Thanks for looking into it @joyceerhl, @DavidKutu, and @greazer!
@joyceerhl I like how PyCharm is doing it.
At the very least, I would like to see a string representation like below, perhaps with a nicer presentation and formatting.

What I would really like is the ability to explore the objects in more detail like here.

I have a question. I mentioned in my report that I had experienced the same issue a few times with some pd.dataframes. Unfortunately, I don't remember which ones. Would you venture a guess as to what dataframes could be affected? I haven't created any dataframes with pathlib.WindowsPath objects :)

@greazer Do we still need the "more info needed label"?

Sorry for the delayed response. We've had other reports of dataframes failing to load, e.g. https://github.com/microsoft/vscode-jupyter/issues/4367. If you have an example that would really help us.

I found the same behavior when I tried to view the transposed DataFrame (the regular dataframe has no issues).
This was working fine until the recent update of VS Code.
Version: 1.54.2 (user setup)
Commit: fd6f3bce6709b121a895d042d343d71f317d74e7
Date: 2021-03-11T00:56:19.848Z
Electron: 11.3.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19042

Hope this helps. Version below is perfectly working with variable viewer. So something between  1.53.2 and 1.54.2 has changed which is breaking the Data viewer.
Version: 1.53.2 (user setup)
Commit: 622cb03f7e070a9670c94bae1a45d78d7181fbd4
Date: 2021-02-11T11:48:04.245Z
Electron: 11.2.1
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19042

Hi @mbijjur can you share a code sample and the version of the Jupyter extension that you have? Or is it the same version with either build of VS Code?

Hi @mbijjur can you share a code sample and the version of the Jupyter extension that you have? Or is it the same version with either build of VS Code?

It is the same Jupyter version

@mbijjur thank you, this is a regression in the Jupyter extension (nothing to do with VS Code core), I know why this is happening. Will submit a fix. Sorry for the trouble.

Update: we fixed the problem with transposed DataFrames in the April release. The original problem with objects not being displayed would be resolved by https://github.com/microsoft/vscode-jupyter/issues/1138 so closing as a duplicate of that. Please feel free to upvote that issue instead.


fixed Windows failed build

@rultor merge

@rultor merge

@graur OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@graur Done! FYI, the full log is here (took me 6min)


Propagate updates to API docs to expressjs/express-api-docs

This issue is to ensure we don't forget to copy any changes made to API docs since 18 Feb 2016 to https://github.com/expressjs/express-api-docs.  Currently, this is just a few small PRs.

With the announcement of the plan to move this repo to expressjs org, this problem goes away, so I'm closing.   Once the move happens, we should probably just delete https://github.com/expressjs/express-api-docs (assuming the TC concurs).


Add geostrophic convergence test (Williamson Test 2)

This merge adds the geostrophic convergence test case from Williamson et al. 1992.  The test case starts out in geostrophic balance and ideally remains in steady state.
The test case has similarities to cosine_bell so efforts have been made to share code, primarily the forward step, between the two.

Checklist

[x] User's Guide has been updated
[x] Developer's Guide has been updated
[x] API documentation in the Developer's Guide (api.md) has any new or modified class, method and/or functions listed
[x] Documentation has been built locally and changes look as expected
[x] Testing comment in the PR documents testing used to verify the changes
[x] New tests have been added to a test suite

This is based off of #119 and will be rebased after that gets merged.

Thanks to @lconlon for starting out this test case with me in the Polaris Hackathon in May!

Testing
I have run all 4 geostrophic test cases on Chrysalis with Intel and OpenMPI.  They ran successfully and produced the expected plots.
The order of convergence for water-column thickness for the QU grids is really terrible -- 0.4.  So that's discoraging for MPAS-Ocean but not an indication of a problem with the tests.  The Icos meshes do much better -- about 1.6.
QU:

Icos:

Here are some plots of water-column thickness, u, v and normal velocity (for the icos 240km mesh):

Here are diff plots of water-column thickness for the QU and Icos meshes with increasing resolution.
QU

Icos

I need to update this to use #126, so it will likely make sense to wait on reviewing this until after that PR has gone in.

@cbegeman, just an update that this is coming along and now uses the shared analysis, but I need to test it.

@xylar Just an FYI that I'll be posting a PR soon with some additional clean-up of the convergence analysis step. We might want to get this reviewed and merged first so that you don't have to do another rebase.

@cbegeman, thanks for catching those mistakes, which are now fixed.  Let me know if there are other changes you would like me to make.

@cbegeman, I'd prefer to wait until @sbrus89 has time to look at this.  That may very well mean that I will rebase onto #131 once that's done.  That's fine, since either I will have to rebase this or you will have to rebase that and I don't mind the extra work.

@xylar, I will get to this on Monday. Thanks for your patience.

@xylar - I'm testing a local merge and am seeing this from polaris list:
Traceback (most recent call last):
  File "/lcrc/group/acme/sbrus/mambaforge/envs/dev_polaris_0.2.0/bin/polaris", line 33, in <module>
    sys.exit(load_entry_point('polaris', 'console_scripts', 'polaris')())
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/lcrc/group/acme/sbrus/mambaforge/envs/dev_polaris_0.2.0/bin/polaris", line 25, in importlib_load_entry_point
    return next(matches).load()
           ^^^^^^^^^^^^^^^^^^^^
  File "/lcrc/group/acme/sbrus/mambaforge/envs/dev_polaris_0.2.0/lib/python3.11/importlib/metadata/__init__.py", line 202, in load
    module = import_module(match.group('module'))
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/lcrc/group/acme/sbrus/mambaforge/envs/dev_polaris_0.2.0/lib/python3.11/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1204, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1176, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1147, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 690, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 940, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/gpfs/fs1/home/sbrus/polaris_worktrees/williamson/polaris/__main__.py", line 8, in <module>
    from polaris import cache, list, setup, suite
  File "/gpfs/fs1/home/sbrus/polaris_worktrees/williamson/polaris/list.py", line 6, in <module>
    from polaris.components import get_components
  File "/gpfs/fs1/home/sbrus/polaris_worktrees/williamson/polaris/components.py", line 5, in <module>
    from polaris.ocean import Ocean
  File "/gpfs/fs1/home/sbrus/polaris_worktrees/williamson/polaris/ocean/__init__.py", line 4, in <module>
    from polaris.ocean.tasks.geostrophic import add_geostrophic_tasks
  File "/gpfs/fs1/home/sbrus/polaris_worktrees/williamson/polaris/ocean/tasks/geostrophic/__init__.py", line 6, in <module>
    from polaris.ocean.tasks.geostrophic.analysis import Analysis
  File "/gpfs/fs1/home/sbrus/polaris_worktrees/williamson/polaris/ocean/tasks/geostrophic/analysis.py", line 3, in <module>
    from polaris.ocean.convergence.spherical import SphericalConvergenceAnalysis
ImportError: cannot import name 'SphericalConvergenceAnalysis' from 'polaris.ocean.convergence.spherical' (/gpfs/fs1/home/sbrus/polaris_worktrees/williamson/polaris/ocean/convergence/spherical/__init__.py)

@xylar Maybe it's worth rebasing onto https://github.com/E3SM-Project/polaris/pull/131 in the process of addressing @sbrus89's issue? Sorry for the hassle.

@sbrus89, I'm not able to reproduce that issue locally.  Could you try recreating your polaris conda environment to see if that helps?

@sbrus89, sorry for the confusion on my part yesterday.  I was too tired I guess and I missed that this was with a test merge.  I have rebased and fixed thing up.  Retesting now but I think you can give it another try when you have time.

@xylar, no problem. Yes I was testing with a local merge with main. I'll give it another go today. Thanks for rebasing!

I successfully tested the convergence suite with the geostrophic tests added:
Task Runtimes:
0:01:01 PASS ocean/planar/inertial_gravity_wave
0:00:55 FAIL ocean/planar/manufactured_solution
0:05:27 PASS ocean/spherical/icos/cosine_bell
0:09:15 PASS ocean/spherical/qu/cosine_bell
0:01:35 PASS ocean/spherical/icos/geostrophic
0:03:02 PASS ocean/spherical/qu/geostrophic
Total runtime: 0:21:16

I was having some performance problems with the geostrphic/with_viz tests that seem random but also persistent.  I don't know if it's a Chrysalis problem, an issue wiht ESMF or something else.  But I also hope we can replace this viz soon with something better so I'm not inclined to investigate too much.

@xylar, I'm seeing this error:
ocean/spherical/icos/geostrophic
Traceback (most recent call last):
  File "/global/cfs/cdirs/e3sm/sbrus/mambaforge/envs/dev_polaris_0.2.0/bin/polaris", line 33, in <module>
    sys.exit(load_entry_point('polaris', 'console_scripts', 'polaris')())
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/global/cfs/cdirs/e3sm/sbrus/polaris_worktrees/williamson/polaris/__main__.py", line 62, in main
    commands[args.command]()
  File "/global/cfs/cdirs/e3sm/sbrus/polaris_worktrees/williamson/polaris/run/serial.py", line 196, in main
    run_tasks(suite_name='task', quiet=args.quiet, is_task=True,
  File "/global/cfs/cdirs/e3sm/sbrus/polaris_worktrees/williamson/polaris/run/serial.py", line 103, in run_tasks
    result_str, success, task_time = _log_and_run_task(
                                     ^^^^^^^^^^^^^^^^^^
  File "/global/cfs/cdirs/e3sm/sbrus/polaris_worktrees/williamson/polaris/run/serial.py", line 316, in _log_and_run_task
    task.steps_to_run = _update_steps_to_run(
                        ^^^^^^^^^^^^^^^^^^^^^
  File "/global/cfs/cdirs/e3sm/sbrus/polaris_worktrees/williamson/polaris/run/serial.py", line 222, in _update_steps_to_run
    step_str = config.get(task_name, 'steps_to_run').replace(',', ' ')
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/global/cfs/cdirs/e3sm/sbrus/mambaforge/envs/dev_polaris_0.2.0/lib/python3.11/site-packages/mpas_tools/config.py", line 115, in get
    return self.combined.get(section, option)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/global/cfs/cdirs/e3sm/sbrus/mambaforge/envs/dev_polaris_0.2.0/lib/python3.11/configparser.py", line 797, in get
    d = self._unify_values(section, vars)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/global/cfs/cdirs/e3sm/sbrus/mambaforge/envs/dev_polaris_0.2.0/lib/python3.11/configparser.py", line 1168, in _unify_values
    raise NoSectionError(section) from None
configparser.NoSectionError: No section: 'icos_geostrophic'

I looked in the geostrophic.cfg file and only see a icos_geostrophic_with_viz section. I have a feeling this is because I set up the cases in this order: ocean/spherical/icos/geostrophic, ocean/spherical/icos/geostrophic/with_viz before running ocean/spherical/icos/geostrophic. Is this expected behavior?

@xylar - I did the following:
polaris setup -t ocean/spherical/icos/geostrophic -w $WORKROOT/wiliamson
polaris setup -t ocean/spherical/icos/geostrophic/with_viz -w $WORKROOT/wiliamson
polaris setup -t ocean/spherical/qu/geostrophic -w $WORKROOT/wiliamson
polaris setup -t ocean/spherical/qu/geostrophic/with_viz -w w $WORKROOT/wiliamson

and then
cd $WORKROOT/wiliamson/ocean/spherical/icos/geostrophic
sbatch job_script.sh

@sbrus89, great, thanks!  I'm looking into this now.
Just as a tip to make your workflow more efficient, you may want to do:
polaris list

and then:
polaris setup -n 17 18 19 20 -w $WORKROOT/wiliamson

This will set up a custom suite with all 4 tasks.  But it doesn't seem to expose the problem you showed so I'm glad you did things the "more tedious" way.

@sbrus89, I understand now what is going wrong and I don't have a good idea what to do about it yet.  It isn't anything to do with this PR, it was caused by #125.  When you separately set up 2 tasks that share the same config file, the first task will create a section, option and value with its steps_to_run.  Then, the second task will overwrite the config file, including its section, option and value with its steps_to_run.  If you were to set them up together, both sections, options and values would be populated as excepted:
[icos_geostrophic]

# A list of steps to include when running the icos_geostrophic task
# source: /gpfs/fs1/home/ac.xylar/e3sm_work/polaris/add-geostrophic-tests/polaris/setup.py
steps_to_run = icos_base_mesh_60km icos_init_60km icos_forward_60km icos_base_mesh_120km icos_init_120km icos_forward_120km icos_base_mesh_240km icos_init_240km icos_forward_240km icos_base_mesh_480km icos_init_480km icos_forward_480km analysis

[icos_geostrophic_with_viz]

# A list of steps to include when running the icos_geostrophic_with_viz task
# source: /gpfs/fs1/home/ac.xylar/e3sm_work/polaris/add-geostrophic-tests/polaris/setup.py
steps_to_run = icos_base_mesh_60km icos_init_60km icos_forward_60km icos_map_cell_60km icos_map_edge_60km icos_viz_60km icos_base_mesh_120km icos_init_120km icos_forward_120km icos_map_cell_120km icos_map_edge_120km icos_viz_120km icos_base_mesh_240km icos_init_240km icos_forward_240km icos_map_cell_240km icos_map_edge_240km icos_viz_240km icos_base_mesh_480km icos_init_480km icos_forward_480km icos_map_cell_480km icos_map_edge_480km icos_viz_480km analysis

Presumably, the solution will be to include steps_to_run from all tasks when writing out a shared config file.  Since this is unrelated to geostrophic, I'll address it in a separate PR.

@sbrus89, would you like to review #134 and for me to merge that and rebase? Or can you review this without that fix?

@xylar, I figured it wasn't related to this PR. I'll just review it without the fix. I'll try it by creating a custom suite as you suggested.
Just a thought, it would be nice to be able to create custom suites with the test case names as opposed to numbers since those change as new tests are added.

@sbrus89, that's a good idea and easy to implement.  I'll make a PR shortly.

@sbrus89, hmm, that looks like a bug where a relative path didn't get turned into an absolute path as it should have before it got stored in the pickle file.  I have never seen that before, so I would need to know exactly what your polaris setup or polaris suite command was that led to this.  Maybe it was a simple as not supplying -p, which I basically always do?

Sounds like it could be from not supplying -p I don't typically do this unless I want an ocean_model outside the repo.

@sbrus89, I'm not able to reproduce this with main even without the -p flag.  I doubt I introduced this issue in this PR.  Could you give me the exact polaris setup or polaris suite command?

Oh, I take that back!  I see it only in some tests and not others:
0:00:08 PASS ocean/planar/baroclinic_channel/10km/threads
0:00:03 PASS ocean/planar/baroclinic_channel/10km/decomp
0:00:00 FAIL ocean/planar/baroclinic_channel/10km/restart
0:00:01 FAIL ocean/planar/inertial_gravity_wave
0:00:02 PASS ocean/single_column/cvmix
0:00:02 PASS ocean/single_column/ideal_age

Again, not related to this PR but an important bug to fix.

@sbrus89, I see what changed and why.  It's complicated to explain (to do with fancy config parsing and automatically converting to absolute paths) but probably easy to fix.  Thanks for bringing this to my attention.  Can you proceed with using the -p flag for now?

@xylar - yes, will do. Sorry for the headache on this!

Thanks so much, @sbrus89!  And I really do appreciate you finding those issues, whether they are related or not.

@cbegeman, thank you very much for getting this test case started with excellent documentation and for thorough review!  @lconlon, thank you for helping me get this test case started during the hackathon!


Update Mac installation instructions

Following https://www.terraform.io/docs/configuration/providers.html#third-party-plugins it seems necessary to hint at the provider version in the binary name.

Good catch, thanks!


[FLINK-3682] [cep] Assign processing timestamp in CEP operators

This PR fixes the problem that the CEP operators did not assign the wall clock time
as the timestamp to incoming in StreamRecords if the TimeCharacteristic was set to
ProcessingTime. Processing element with a Long.MIN_VALUE timestamp can lead to underflows
in the NFA if a positive window length is subtracted from the timestamp. For this
underflow a sanity check has been added to notify the user with an exception about it.

Good catch! +1 to merge to master and release-1.0

Thanks for the review @uce

Once Travis gives green light I'll merge it.

Till's local Travis passed (https://travis-ci.org/tillrohrmann/flink/builds/119528848) with one unrelated failing build. I'm going to merge this.


On-screen controls not functional on iOS

It appears the on-screen controls (and reset button) are not working on iOS.

Fixed 74224cdde85c72eef48e3ab5a3dd20d4aabb9151


Bluetooth: CCP: Introduce new CCP API

The CCP API for the Call Control Profile works on top of the
TBS API, and will eventually replace parts of the TBS API.
Signed-off-by: Emil Gydesen<EMAIL_ADDRESS>

Renamed to Call Control Profile Call Control Server as per https://github.com/zephyrproject-rtos/zephyr/pull/77120#discussion_r1734543869 and short discussion in the weekly LE Audio meeting


Swagger loses authorization token when toggling between apis

If you have multiple apis setup in the swagger server, it will removes the authorization token.

Please raise tooling-related issues on the relevant repository. This repository is only for the OpenAPI specification itself. Thanks.


Terminus is now Tabby

See: https://github.com/Eugeny/tabby/discussions/4087
This probably requires renames, changes etc.

@Lockszmith Thanks for your feedback, will take it into account for the next release.

@Lockszmith-GH Done: https://portapps.io/app/tabby-portable/


chore: Import action and action collection in bulk during file import

Description
When we import an application from file for Git, file import, templates and other features, we import the list of actions one by one. This leads to transaction timeout and other performance issues when the application has a large number of actions and action collections. This PR imports the actions and action collections in bulk so that number of database queries are significantly reduced.
PR fixes following issue(s)
Fixes #24419
Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Chore (housekeeping or task changes that don't impact user perception)

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

[ ] Manual
[ ] Jest
[ ] Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

/ok-to-test sha=e71fab1e1b9ebdda50fb4df7b4a45e797074c83a

/build-deploy-preview

/ok-to-test sha=d6437fa6551bca79649fa3d0a5e0e15bcc6f329a

@nayan-rafiq - Merge latest release & trigger new oktotest. Cancelling the re-run since its past 12 hours from initial attempt.

@nayan The above mentioned issue is happening on release as well, not a blocker for this PR, filing seperate issue.

@nayan While creating new branch I am getting following error:

/ok-to-test sha=1fc53f2

/ok-to-test sha=c56fdb7

/build-deploy-preview skip-tests=true recreate=true

/ok-to-test sha=2f0914e


Added info for Shippable.com

Shippable is a CI product and a cheaper alternative to something like Travis CI. The main benefit on the free tier is that you can use it with either public or private repos (with some limitations in terms of build minutes/month for private repos).

Thanks for the contribution 👍
I will probably remove the "cons" part are there is none in the guideline template for now :)
Also I will move the build limit to the free tier description as there are part of it


Warn users if they choose content settings that result in empty site

We can get the number of posts from the store and if empty show a warning somehow.


Don't make SSL_CN mandatory

In case the client didn't present a certificate, then there's no CN TLV that
could be populated by the proxy.
haproxy also omits this field in this case. The TLV is only appended if
ssl_sock_get_remote_common_name returns a positive integer 1. The
function returns 0 in case the CN isn't found 2.

Coverage remained the same at 93.487% when pulling cd4b0cab46d2d0f2b2f32e2cb66886dcbdfc91d8 on emersion:lax-parse-ssl-tlv into 84376ea4b0735a872f3d2600feac787ef96cff80 on pires:master.


token-cli: don't error when missing default config

fixes a regression introduced in #3166. prior to that, the config argument would default to the value of solana_cli_config::CONFIG_FILE, and loading the config would fall back to a default if it failed. changing the to an error protected against a missing file provided by --config, but also errored in the default case if they lacked the default file
this change distinguishes the three cases, erroring if the user provided a bad --config option, but falling back to defaults if they didnt

of course it fails right before your new test... you can rebase on top of #3425, if you want to take your chances

#3425 landed, so if you don't mind rebasing once more, we can be sure that this is good to go

taking the cowards way out and deleting the test i attempted to add, it turns out spl-token address (and, in fact, every non-help command) attempts to load the signer keypair from its expected path and fails if its not there, and i cant tell it to use a different path in a test with a non-default config because thats... what the config does. and i dont want to write a key out to the default location and pollute a shared resource, if later tests end up depending on something else being there
there should be more comprehensive integration tests for the binary (pre this patch it crashed unconditionally on my machine) but thats a different thing imo

I think #3293 will at least address the config issue.  Definitely happy to come up with a better testing strategy!


Feature duration

I'm adding the duration prop for UButton and other components using UButton to add a duration for the style on hover

What is the purpose of adding a duration when no transition is defined? Wouldn't a new transition key in the app.config be enough?

When I design my buttons for various applications, I like to put a delay on the colors when the buttons are hovered. With tailwindcss, you don't need to set the 'transition' key but rather 'duration-{x}' to apply this duration.

Sorry, but this goes against the logic of the library. I we added a prop each time we wanted to add a Tailwind class it would never end.
Props only apply for component logic, this kind of stuff have to go in the app.config.ts.


SimpleTable的Column能否增加支持跳转，包括url和router

Bug Report or Feature Request (mark with an x)

[ ] Bug report -> please search issues before submitting
[x] Feature request
[ ] Documentation issue or request

Reproduction link

Steps to reproduce

What is expected?

表格列表中点击某一行中某一列的内容进行跳转是很常见需求，能否增加该功能？
What is actually happening?

Environment

ng-alain version: X.Y.Z
Angular version: X.Y.Z
Browser:
- [ ] Chrome (desktop) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] IE version XX

建议使用 button 实现查看功能。


Credentials

How can i implement my own class inheriting Credentials?
Always gets UnsupportedCredentialsError with login/register methods
I tried to inherit from UsernamePassword - that worked, but i had to make some changes in this class.
is there any good way implementing own Credentials?

Yeah, you can implement your own credentials -- it's just that the pre-implemented Realms don't support custom credentials. You'll need to write a Realm that supports you credentials using these instructions:
https://github.com/stormpath/Turnstile#realm


[DOCFIX] Update docs/cn/Configuring-Alluxio-with-OSS.md

Update docs/cn/Configuring-Alluxio-with-OSS.md

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/18510/
Test PASSed.


remove conversion wehbook part from self-signed-ca.sh

What this PR does / why we need it:
make deploy-dev  can set self-signed-ca.sh and it still has the conversion webhook related script.
It is removed :https://github.com/kserve/kserve/pull/3700/files
So this PR commented out the part. I didn't remove the part to use it as a reference for the future conversion.
And, added some informational value into existing log.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Type of changes
Please delete options that are not relevant.

[X ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

[ ] Test A

[ ] Test B

Logs

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Checklist:

[ ] Have you added unit/e2e tests that prove your fix is effective or that this feature works?
[ ] Has code been commented, particularly in hard-to-understand areas?
[ ] Have you made corresponding changes to the documentation?

Release note:

Re-running failed tests

/rerun-all - rerun all failed workflows.
/rerun-workflow <workflow name> - rerun a specific failed workflow. Only one workflow name can be specified. Multiple /rerun-workflow commands are allowed per comment.

/assign @terrytangyuan

/lgtm

/rerun-all


HPX-1.6.0 fails to build on Windows 10

Expected Behavior
Successful build using Visual Studio 2019
Actual Behavior
Build failed with the following errors:
Error	C2182	'abstract declarator': illegal use of type 'void'	1d_stencil_channel (Examples\1D Stencil\1d_stencil_channel\1d_stencil_channel)	C:\Users\phili\Documents\cpp\hpx-1.6.0\libs\core\functional\include\hpx\functional\traits\is_invocable.hpp
Note: error points to line 81 of is_invocable.hpp
Steps to Reproduce the Problem
Follow all steps in the HPX manual regarding:
How to build HPX under Windows 10 x64 with Visual Studio 2015
Specifications

HPX Version: 1.6.0
Platform (compiler, OS): Visual Studio 2019, Windows 10.
Setting compiler to use C++14 as well as C++17 makes no difference.

Could you give us the arguments you used when invoking cmake, please?

FWIW, I can build that example just fine using VS 2019 Preview (Version 16.10.0 Preview 1.0)

The version of VS I used was 16.9.3
Here is the build log file:
INSTALL.log
Here is the CMakeCache.txt
CMakeCache.txt

Here is the list of errors displayed on the Error List pane during the build:
BuildErrorList.txt

@philipyi thank you for the additional information. I'm still not able to reproduce your issue. Would you be able to retry using the current master branch, please?

@hkaiser - I just built the latest from the git repository with no problems.

@hkaiser - I just built the latest from the git repository with no problems.

Thanks for investing the time to investigate that! Would it be ok if I closed this issue now? Or would you have to rely on the release and have it fixed retrospectively?

@hkaiser , No I don't need it to be fixed retrospectively, thank you. I think you can close the issue.


removing block of code that resets 'weights' array

resolves #6185

I am not sure if simply deleting the problem will fix it. Software depending on this will break down now ... I would rather see an explanation why it was implemented this way then try to change the behaviour.

Maybe, yes. But I ran the tests and they passed, and I went through the entire source of cascadedetect.cpp and there was no processing being done once it was being established after the function call, that the user does not want grouping of rectangles, or that there were no rectangles to group.
But yes, if there are other files in other modules that are depending on cascadedetect's code and utilising the weights array in a post-processing step for some reason, while also depending on it being set to an array of 1's even when there is no grouping, then the code should crash.
I'll look further into it.

I agree that if the code is actually doing nothing valid for any other part of cascadedetect.cpp, that then the overwriting should be gone.
An idea, is there a possible case where removing this would lead to an uninitialized weight vector? This might be the reason for adding this and then we just need to reposition it or make the if condition different.

BTW,
Original commit with these changes is here, but actual reason of this addition is very unclear.
Moreover this "for" code block has not been used during tests at this moment
And documentation doesn't cover these cases.

Then I can agree that we could remove this. Maybe we should mark it as watchable or something like that, so that, keeping in mind that if errors around these weights pop up, that this fix could be the reason.

This PR will be recreated because of CI issues


Remove the disableCreateObjectURL option from web/app_options.js

Prior to PR #11601, the disableCreateObjectURL option was present on getDocument in the API, since it was (potentially) used when decoding JPEG images natively in the browser. Hence setting this option, which was done automatically using compatibility-code, were in some browsers necessary in order for e.g. JPEG images to be correctly rendered.
The downside of the disableCreateObjectURL option is that memory usage increases significantly, since we're forced to build and use data: URIs (rather than blob: URLs).
However, at this point in time the disableCreateObjectURL option is only necessary for some (non-essential) functionality in the default viewer; in particular:

The openfile functionality, used only when manually opening a new file in the default viewer.
The download functionality, used when downloading either the PDF document itself or its attached files (if such exists).
The print functionality, in the generic PDFPrintService implementation.

Hence neither the general PDF.js library, nor the basic functionality of the default viewer, depends on the disableCreateObjectURL option any more; which is why I'm thus proposing that we remove the option since using it is a performance footgun.
Please note: To not outright break currently "supported" browsers, which lack proper URL.createObjectURL support, this patch purposely keeps the compatibility-code to explicitly disable URL.createObjectURL usage only for browsers which are known to not work correctly.[1]
While it's certainly possible that there's additional, likely older, browsers with broken URL.createObjectURL support, the last time that these types of problems were reported was over three years ago.[2]
Hence in the very unlikely event that additional problems occur, as a result of these changes, we can either add a new case in the compatibility-code or simply declare the affected browser as unsupported.

[1] Which are IE11 (see issue #3977), and Google Chrome on iOS (see PR #8081).
[2] Given that URL.createObjectURL is used by default, you'd really expect more reports if these problems were widespread.

/botio-linux preview

I agree with the points that you mentioned. Thanks!


"Connected succesfully." typo

please replace "succesfully"  throughout your code base with "successfully"

Fixed in 2.16.2.


Added Accounts and Audit Scripts

Some Issues/questions I had;

When Banning an account and deleting the account_session, player will not timeout until they zone
I believe the node-cache ttl is in seconds and unsure how it's set, I'll look into docs more
Still learning TS so a seconds look may be needed on how I'm setting some of these types.

When Banning an account and deleting the account_session, player will not timeout until they zone

Yeah, this is fine for now. good callout!

I believe the node-cache ttl is in seconds and unsure how it's set, I'll look into docs more

ttl is in miliseconds (seconds * 1000)

Still learning TS so a seconds look may be needed on how I'm setting some of these types.

Types look great!


fix parse component before template

Pull Request Test Coverage Report for Build 280

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.005%) to 94.424%

Totals

Change from base Build 277:
-0.005%

Covered Lines:
1033

Relevant Lines:
1094

💛  - Coveralls


bike shed update fails on macOS with "cannot import name viewkeys"

I cloned Bikeshed at b43bcf8d18510de03d8b56c5e878eea93e955427
sudo pip install  --editable seemed to work OK:
7$ $ sudo pip install --editable ./bikeshed/
Password:
The directory '/Users/smfr/Library/Caches/pip/http' or its parent directory is not owned by the current user and the cache has been disabled. Please check the permissions and owner of that directory. If executing pip with sudo, you may want sudo's -H flag.
The directory '/Users/smfr/Library/Caches/pip' or its parent directory is not owned by the current user and caching wheels has been disabled. check the permissions and owner of that directory. If executing pip with sudo, you may want sudo's -H flag.
Obtaining file:///Volumes/Data/Development/w3c/bikeshed
Collecting pygments (from Bikeshed==0.0.0)
Downloading Pygments-2.2.0-py2.py3-none-any.whl (841kB)
100% |████████████████████████████████| 849kB 1.4MB/s
Collecting lxml (from Bikeshed==0.0.0)
Downloading lxml-4.1.1-cp27-cp27m-macosx_10_6_intel.macosx_10_9_intel.macosx_10_9_x86_64.macosx_10_10_intel.macosx_10_10_x86_64.whl (8.7MB)
100% |████████████████████████████████| 8.7MB 159kB/s
Requirement already satisfied: html5lib in /Users/smfr/Library/Python/2.7/lib/python/site-packages (from Bikeshed==0.0.0)
Collecting cssselect (from Bikeshed==0.0.0)
Downloading cssselect-1.0.1-py2.py3-none-any.whl
Requirement already satisfied: webencodings in /Users/smfr/Library/Python/2.7/lib/python/site-packages (from html5lib->Bikeshed==0.0.0)
Requirement already satisfied: setuptools>=18.5 in /System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python (from html5lib->Bikeshed==0.0.0)
Requirement already satisfied: six in /System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python (from html5lib->Bikeshed==0.0.0)
Installing collected packages: pygments, lxml, cssselect, Bikeshed
Running setup.py develop for Bikeshed
Successfully installed Bikeshed cssselect-1.0.1 lxml-4.1.1 pygments-2.2.0
but bikeshed update fails:
9$ $ bikeshed update
Traceback (most recent call last):
File "/usr/local/bin/bikeshed", line 9, in
load_entry_point('Bikeshed==0.0.0', 'console_scripts', 'bikeshed')()
File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/pkg_resources/init.py", line 565, in load_entry_point
return get_distribution(dist).load_entry_point(group, name)
File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/pkg_resources/init.py", line 2697, in load_entry_point
return ep.load()
File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/pkg_resources/init.py", line 2370, in load
return self.resolve()
File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/pkg_resources/init.py", line 2376, in resolve
module = import(self.module_name, fromlist=['name'], level=0)
File "/Volumes/Data/Development/w3c/bikeshed/bikeshed/init.py", line 4, in
from .cli import main
File "/Volumes/Data/Development/w3c/bikeshed/bikeshed/cli.py", line 9, in
from . import metadata
File "/Volumes/Data/Development/w3c/bikeshed/bikeshed/metadata.py", line 16, in
from . import markdown
File "/Volumes/Data/Development/w3c/bikeshed/bikeshed/markdown.py", line 5, in
from .htmlhelpers import escapeAttr
File "/Volumes/Data/Development/w3c/bikeshed/bikeshed/htmlhelpers.py", line 4, in
import html5lib
File "/Users/smfr/Library/Python/2.7/lib/python/site-packages/html5lib/init.py", line 16, in
from .html5parser import HTMLParser, parse, parseFragment
File "/Users/smfr/Library/Python/2.7/lib/python/site-packages/html5lib/html5parser.py", line 2, in
from six import with_metaclass, viewkeys, PY3
ImportError: cannot import name viewkeys

OS version is macOS High Sierra (build number 17A364).

six.py is version = "1.10.0"
Maybe https://stackoverflow.com/questions/39658404/python-cannot-import-name-viewkeys

Fixed with sudo pip install html5lib==1.0b8

Closing as this was a bug in a dependancy that got fixed a long time ago.


OSOE-485: Update GitHub Actions workflows of all OSOCE projects from the OSS template

OSOE-485

This does not contain any changes. Is this really needed?


[0.75] Broken border with specific border radius on TextInput

Description
When applying specific borderRadius on , for example bottomRight, the actual affected corner will be the one next counter clockwise (top right instead of bottom right; top left instead of top right, etc...)
This is a regression from 0.74 and it is fixed in 0.76 so there is already a fix somewhere, it would just need to be found and backported to 0.75.
This happens on both architectures.
Steps to reproduce
Run the android app for the reproducer
React Native Version
0.75.4
Affected Platforms
Runtime - Android
Output of npx react-native info
System:
  OS: macOS 14.5
  CPU: (10) arm64 Apple M2 Pro
  Memory: 92.78 MB / 16.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 20.12.2
    path: /usr/local/bin/node
  Yarn:
    version: 3.6.4
    path: /opt/homebrew/bin/yarn
  npm:
    version: 10.5.0
    path: /usr/local/bin/npm
  Watchman:
    version: 2<IP_ADDRESS>
    path: /opt/homebrew/bin/watchman
Managers:
  CocoaPods:
    version: 1.15.2
    path: /Users/thibault/.rbenv/shims/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 23.5
      - iOS 17.5
      - macOS 14.5
      - tvOS 17.5
      - visionOS 1.2
      - watchOS 10.5
  Android SDK: Not Found
IDEs:
  Android Studio: 2024.1 AI-241.15989.150.2411.11948838
  Xcode:
    version: 15.4/15F31d
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 17.0.11
    path: /usr/bin/javac
  Ruby:
    version: 3.1.2
    path: /Users/thibault/.rbenv/shims/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react: Not Found
  react-native: Not Found
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: false
iOS:
  hermesEnabled: true
  newArchEnabled: true

### Stacktrace or Logs

```text
Irrelevant

Reproducer
https://github.com/Titozzz/textinputborderradius
Screenshots and Videos
No response

I'm on old arch and haven't noticed any issue with iOS. Also in our app we do not apply borders to Text directly so we haven't noticed the bug but I would not be surprised that it's broken too

Tested on 0.76.0-rc.6 + New Arch, it's both okay 🙂

Text present on iOS
Radius at expected position on Android

We rebuilt a lot of the infrastructure for Android backgrounds and clipping in 0.76, but the whole set of changes would unfortunately be hard to back port.

This is a regression from 0.74 and it is fixed in 0.76 so there is already a fix somewhere, it would just need to be found and backported to 0.75.

Closing as per @NickGerleman comment

@cortinico , can we release a patch version for 0.75.x considering this is a critical bug? We have a production app and upgrading to RN76 is not possible at the moment.

@cortinico , can we release a patch version for 0.75.x considering this is a critical bug? We have a production app and upgrading to RN76 is not possible at the moment.

As @NickGerleman already pointed out, this is not easy to backport. You'll have to upgrade to 0.76 to have this fixed

There might end up being a simple fix here, depending on the issue. All the changes from 0.76 cannot be back ported though. I did a quick scan of changes in ReactEditText and uimanager to see if I could spot relevant change, and didn’t see it though.
I would recommend bisecting nightly builds, to find where the regression started. A revert of that commit could maybe be picked depending on the root cause.


Hopper stops pulling items

New at using Tom's Storage, in setting up a distribution network with 16 storage crates each attached with a hopper, after the initial pull If I add more of the same items they are not pulled. Any ideas why not?

yeah also seeing this behaviou, it seems that it gets stuck trying to extract one item and doesnt try the next item in the inventory


Children of game object with attach to controller remain inactive when the game object is deactivate and then reactivate

Overview
Children of game object with AttachToController remain inactive when the game object is deactivated and then reactivated (with SetChildrenInactiveWhenDetached=true)
Expected Behavior
The children must be activated when the parent is reactivated
Actual Behavior
The children remain inactive
Steps to reproduce
Place AttachToController on a game object with children (SetChildrenInactiveWhenDetached is true)
Deactivate the game object
Reactivate the game object
Unity Editor Version
2017.2.1f1
Mixed Reality Toolkit Release Version
Master, Dev, Stabilization

I think that inside OnEnable it should be:
protected virtual void OnEnable()
{
if (!IsAttached) SetChildrenActive(false);

Closing issues older than 180 days. If this is still an issue, please reactivate with recent information.


fix: [CI-14984]: fixed mergeRunStep issue

Removed the pushed flag:
The pushed flag was unnecessary and potentially confusing
The logic now handles all cases without needing to track whether something was pushed
Simplified the loop logic:
Removed the conditional check if i != len(*steps)-1
Made the merge/no-merge decision more straightforward
Fixed the last step handling:
Always append the final cursor state after the loop
This ensures we don't lose any steps regardless of whether the last step was merged or not (which was the main issue).
Also added a function which checks that if image is non-default then it will not merge.

Please add UTs and include a link to pipeline which shows the steps after conversion.

Please add UTs and include a link to pipeline which shows the steps after conversion.

Added UTs and passed alpine as a defaultImage variable.

Closing this PR due to wrong rebasing and merge conflicts. Please refer this PR -  https://github.com/drone/go-convert/pull/247


add see also for sub command

[FIX] add see also for sub command
[FIX] add comment for public function

Coverage decreased (-0.2%) to 85.647% when pulling 63452ae356b7c05d830daa60f6aa3b767ef703fe on yingzhuo:master into 881340b8aeb6688cf44348d6e8e11c7dfe2b0192 on subchen:master.


Upgrade arrow to v16

What changes were proposed in this pull request?

The current version of arrow (v12) is more than a year old. This PR simply upgrades to the most recent (v16)
Why are the changes needed?

Arrow should be backwards compatible, so there's no reason to not use the latest stable version which comes with plenty of bug fixes
Does this PR introduce any user-facing change?

No
How was this patch tested?

Using make test

Mind filing a JIRA and link it to the PR title though https://issues.apache.org/jira/projects/SPARK/issues

Do you mind rebasing your PR to the most recent code? Thanks!

Do you mind rebasing your PR to the most recent code? Thanks!

fun fact - in the meantime v17 was released 😂

Merging to master.


use buildkit during build

Signed-off-by: Anurag<EMAIL_ADDRESS>
This PR is aimed to use Docker buildkit during build.
This will reduce the time by 1 minute approx.
This will not impact the image size.

Codecov Report

Merging #949 (768af12) into main (c6fac32) will decrease coverage by 1.67%.
The diff coverage is 14.28%.

@@            Coverage Diff             @@
##             main     #949      +/-   ##
==========================================
- Coverage   39.19%   37.51%   -1.68%
==========================================
  Files          31       31
  Lines        9838     9843       +5
==========================================
- Hits         3856     3693     -163
- Misses       5475     5657     +182
+ Partials      507      493      -14

Impacted Files
Coverage Δ

KubeArmor/monitor/systemMonitor.go
49.50% <14.28%> (-0.63%)
:arrow_down:

KubeArmor/core/crioHandler.go
0.00% <0.00%> (-60.52%)
:arrow_down:

KubeArmor/monitor/logUpdate.go
66.85% <0.00%> (-2.79%)
:arrow_down:

KubeArmor/core/kubeArmor.go
48.23% <0.00%> (-1.77%)
:arrow_down:

KubeArmor/core/kubeUpdate.go
38.19% <0.00%> (-0.23%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

The checks are passing on the forked repo, but not on the upstream repo. Requesting to run ci-test-ginkgo / containerd once again.


fix: frame order 🤦

Resolves #32

Thanks for the quick turnaround @jperl! This fixes the issue for me.


Refactor present-method mechanic

This does two things:

Implement the changes in our WgpuCanvasContext to match with the new API in https://github.com/pygfx/rendercanvas/pull/21

This means that wgpu keeps working with rendercanvas (after the above change)

Backport the changes in our gui backends.

This means that wgpu.gui keeps working, so we can move to rendercanvas gradually.

I changed the scope of this PR. Before rendercanvas, the context-canvas interaction was an implementation detail. In https://github.com/pygfx/rendercanvas/pull/21 I propose an improved and documented version. This PR implements that.


Incorrect displaying .row inside .col-auto

Bootstrap 4.
OS: Windows 10 (x64)
Browser: Edge
All elements would be in single line without whitespaces and wrap
All are ok in Chrome, Opera, Firefox
Error in Edge (Microsoft Edge 41.16299.248.0, Microsoft EdgeHTML 16.16299)
https://codepen.io/andrii-trush/pen/yKpYVp

This also occurs in MACOS Safari, and Chrome.

Doesn't happen with latest Safari, Chrome, or Firefox on Mojave. https://codepen.io/anon/pen/GPjpbb
Will revisit later this week on my Windows PC.


[improve][websocket] Add ping support

Motivation
When the WebSocket connection is idle timeout, the server disconnects the client. We need to keep alive between the client and the server.
There are two options:

Increasing the idle timeout, but be very unfriendly to users who are not sensitive to time
Sending the ping frame to the client

Some client(browser) doesn't support sending the ping frame to the server, which causes idle timeout, so we only add enable ping feature on the server.
Note: The Jetty automatically processes ping/pong frames from the client by default.
Modifications

Implement sending the ping frame to the client
Add webSocketPingDurationSeconds config to enable the ping feature

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository:

Ping @poorbarcode

Codecov Report

Merging #19203 (27b92cd) into master (246c270) will decrease coverage by 5.74%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #19203      +/-   ##
============================================
- Coverage     43.01%   37.27%   -5.75%
+ Complexity    10167     1990    -8177
============================================
  Files           747      209     -538
  Lines         72255    14442   -57813
  Branches       7786     1578    -6208
============================================
- Hits          31080     5383   -25697
+ Misses        37577     8477   -29100
+ Partials       3598      582    -3016

Flag
Coverage Δ

unittests
37.27% <ø> (-5.75%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...g/apache/pulsar/client/impl/ConnectionHandler.java
50.00% <0.00%> (-5.32%)
:arrow_down:

.../org/apache/pulsar/client/impl/ConnectionPool.java
37.43% <0.00%> (-1.03%)
:arrow_down:

.../timeout/TransactionTimeoutTrackerFactoryImpl.java

...lsar/broker/loadbalance/BrokerFilterException.java

...tion/buffer/impl/InMemTransactionBufferReader.java

...r/broker/service/schema/SchemaRegistryService.java

...keeper/mledger/impl/cache/PendingReadsManager.java

...org/apache/bookkeeper/mledger/util/RangeCache.java

...n/java/org/apache/pulsar/broker/service/Topic.java

...rg/apache/pulsar/metadata/impl/batching/OpGet.java

... and 530 more

/pulsarbot rerun-failure-checks

/pulsarbot rerun-failure-checks

/pulsarbot rerun-failure-checks

/pulsarbot rerun-failure-checks

Remove release/2.9.5, using #19245 instead.


Obsidian requires Electron 25 now EOL

The package Obsidian requires Electron 25. However, Electron 25 is now EOL. I've opened the following issue upstream to request an update to the version of Electron: https://forum.obsidian.md/t/electron-25-is-now-eol-please-upgrade-to-a-newer-version/72878

Overriding works for me:
  (final: prev: {
    obsidian-overlay = prev.obsidian.override {
      electron = prev.electron_26;
    };
  })

conversely, electron 26 does not work here (using insider builds 1.5.1 and 1.5.2)

In case this is useful to anyone else, this is the workaround I’m using:
obsidian = throwIf (versionOlder "1.4.16" obsidian.version) "Obsidian no longer requires EOL Electron" (
  obsidian.override {
    electron = electron_25.overrideAttrs (_: {
      preFixup = "patchelf --add-needed ${libglvnd}/lib/libEGL.so.1 $out/bin/electron"; # NixOS/nixpkgs#272912
      meta.knownVulnerabilities = [ ]; # NixOS/nixpkgs#273611
    });
  }
);

throwIf (versionOlder "1.4.16" obsidian.version)

Doesn't that mean that 1.4.15 would throw to tell you to remove the snippet, while 1.4.17 would just be built with the old defect electron?
PS: My workaround was nixpkgs.config.allowInsecurePackages or how its called.

I'm adding this to my configuration.nix for now:
{
  nixpkgs.config.permittedInsecurePackages =
    lib.optional (pkgs.obsidian.version == "1.4.16") "electron-25.9.0";
}

Whenever a new version of obsidian lands, the exception won't hold anymore, automatically. If it needs to be extended I'll know.

Hi, may I ask a little offtopic? I'm facing this issue too, but it took me some time to figure out that was Obsidian the package causing this error. That's because I upgrade all my packages with:
NIXPKGS_ALLOW_UNFREE=1 nix profile upgrade --impure '.*'

But when I do this, there's no clue (no log) about which is the package causing the error.
So, is there any way to get a little more detailed output or log? Thanks!

@gerardbosch there is --show-trace which often gives you some hint, but this is unfortunately a thing where nix currently could do a lot better.

@gerardbosch
>> nix-store --query --referrers /nix/store/dncl8q8cqrmglcakzxic7h5rkrk3b5zh-electron-25.9.0.drv
/nix/store/1fly55mqavx1m1ff2znn1zzjsfs84b1x-obsidian-1.4.16.drv

In case this is useful to anyone else, this is the workaround I’m using:
obsidian = throwIf (versionOlder "1.4.16" obsidian.version) "Obsidian no longer requires EOL Electron" (
  obsidian.override {
    electron = electron_25.overrideAttrs (_: {
      preFixup = "patchelf --add-needed ${libglvnd}/lib/libEGL.so.1 $out/bin/electron"; # NixOS/nixpkgs#272912
      meta.knownVulnerabilities = [ ]; # NixOS/nixpkgs#273611
    });
  }
);

Thanks for this patch, this at least fixes the error log containing many Could not dlopen native EGL: libEGL.so.1s when running obsidian from the terminal.
Obsidian now however seems to quit when I try to open my vault, so I still have to use 1.4.15...

#277002 has been committed. It updates obsidian to 1.5.3.
Updating to a newer electron (v27 or v28) version is still problematic.

Stumbled across this issue trying to add obsidian to my home-manager config using Nix flakes. Thanks for bumping Obsidian to 1.5.3 with https://github.com/NixOS/nixpkgs/pull/277002.
The following snippet added to the flake let me proceed using it:
  nixpkgs = {
    config = {
      allowUnfree = true;
      permittedInsecurePackages = [ "obsidian-1.5.3" "electron-25.9.0" ];
    };
  };

Is there a better way specifying this explicit combination of Obsidian and Electron instead of allowing them separately?
Right now getting the root cause fixed is somewhat postponed by the Obsidian people: https://forum.obsidian.md/t/electron-25-is-now-eol-please-upgrade-to-a-newer-version/72878/4

In case this is useful to anyone else, this is the workaround I’m using:
obsidian = throwIf (versionOlder "1.4.16" obsidian.version) "Obsidian no longer requires EOL Electron" (
  obsidian.override {
    electron = electron_25.overrideAttrs (_: {
      preFixup = "patchelf --add-needed ${libglvnd}/lib/libEGL.so.1 $out/bin/electron"; # NixOS/nixpkgs#272912
      meta.knownVulnerabilities = [ ]; # NixOS/nixpkgs#273611
    });
  }
);

How do I use this in my nix config?

Obsidian has now been updated to use Electron 28, so once a PR to update to 1.5.8 lands, that should resolve this issue.

#290892 merged. This can be closed now I think?