something wrong with router.beforeEach when slide back

Version
3.0.1
Reproduction link
https://jsfiddle.net/50wL7mdz/778919/
Steps to reproduce
router.beforeEach((to, from , next) => {
    setTimeout(() => {
        next();
    }, 2000);
});

slide back to old page by gesture
What is expected?
is this a  known issue？how to avoid
What is actually happening?
when i slide back to old page by gesture,  the current page will flash in view port. that means you can see [old page => current page => old page].

it's hard to be observed on the pc or mac, use iphone.

The repro doesn't work and the reproduction steps are not clear.
If you are talking about safari displaying the previous page, it's how it works and there is nothing we can do to remove it. Maybe in the future they exposé some kind of api for it


Rendering large NIfTI files

Rendering large NIfTI files is being done with better performance on Papaya Viewer. Is there anything one can do to maximize performance for large files with Niivue?
The aim is to only open the slice view, no need for volume rendering as it is computationally expensive.
For example, one can load ~1GB file in Papya Viewer, but not in Niivue even when the 3D view is disabled in multiplanar mode with the new option introduced in #1024 .
I can provide an example file if necessary.

@hsellik, could you please provide an example image that does not perform well? You can send a download link to taylor.hanayik at virdx.com

@hsellik Since Papaya uses WebGL1 it is constrained to 2D textures. In contrast, WebGL2 allows 3D textures. For volumetric data, 3D textures provide huge efficiency benefits for 2D slices (e.g. sagittal, coronal, axial, oblique slices can all natively sample a single texture) as well as 3D rendering. However, 3D textures are inherently limited to 2Gb by the API (and potentially less on some devices). NiiVue uses 32-bits per voxel (RGBA). It is worth remembering that MRI data is SNR constrained, and for most modalities scales with field strength. Therefore, the 2Gb limit is not a reasonable limit for our this application. NiiVue focuses on the neuroimaging niche, and provides a highly optimized solution for this domain. We focus our resources on this domain and stay in our lane. I do think for applications where extremely high resolution data is used you should look at tile-based solutions like neuroglancer.

My usage indeed is out of the niche.
Using it more for metrology purposes, where the NIfTI file is not very large. The medical niche tools keep popping up for this purpose and NiiVue does have good dev experience and documentation.
I'll try downsampling / looking at other web based tools. Neuroglancer seems interesting.
Thank you for the clarification!


lego 4.12.0 pdns txt record bug

see https://github.com/go-acme/lego/pull/1929
maybe need upgrade lego to 4.12.1

Yep. I'll do it soon, I'm a bit unwell.

OK, the snap is updated, pypi package is published, and the Docker images will be available once the build finishes, hopefully within the hour.


Support 1904-based date values

Date cells are currently evaluated assuming 1900-based date values.  Older sheets created by Excel for Mac and newer sheets created by exporting from Numbers use 1904 based dates.  Evidently there's a flag at the workbook level that can distinguish these, but it is currently ignored.  Compare the calculations in getDateCellValue between com.monitorjbl.xlsx.impl.StreamingCell and org.apache.poi.xssf.usermodel.XSSFCell streaming value.
If fixing this is too much effort, I'd be happy to contribute a fix myself, but would love any insights you might have to offer on how to start such work.
Reference: https://support.microsoft.com/en-us/help/214330/differences-between-the-1900-and-the-1904-date-system-in-excel

Fixed by #74


2 videos in 1 page[BUG]

When there's only one video, it works perfectly fine. However, when I place two videos on the same screen, in separate widgets, it gives an error.

I met the same issue: when I put two youtube videos on one screen, the first one will be fine, but  most of the time, the second one won't play, showing an error like the following screenshot:

Same issue.


[workspace - test] cargo test should output a summary after running all tests in a workspace

Describe the problem you are trying to solve
In a "standard" crate, if you run cargo test, and everything is good, you can look at the last line of the output. In a crate that uses workspace, the output is much more messy, since each sub-crate will report their status, and you can't see immediately if everything went fine.
Describe the solution you'd like
In addition to the current output, if the current crate uses workspace, a global summary should be added at the end of the logs. Something like:
   Summary (in green)

test result: ok. 54 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

This would be very nice. I have a largish project at work with a lot of crates. The output from
'cargo test --workspace'
is 268 lines long. I just realized I've had a bug on a working branch, detected by tests for several days, without realizing. The failing tests simply scrolled past too fast for me to be able to read see it.

Gonna go ahead and bump this! I've had similar problems to avl, not to mention that the output is quite noisy.
I took a quick look at the source, and this looks like a hard feature to implement. Since it looked like each sub-crate was compiled and run individually. This lead me to the conclusion that the easiest way might be to do a cargo-plugin that parses the output from cargo test.
I'm in a fixing mood and might just go ahead and write this thing - unless someone else sees an easier or better way?

From https://github.com/rust-lang/cargo/issues/11945#issuecomment-1516150656:

Feel like this is also blocked on libtest's JSON output. Cargo needs a reliable way to collect such data. See https://github.com/rust-lang/cargo/issues/11875#issuecomment-1479603968 for more. In the meantime, personally I'd recommend nextest, which has a handful of goodies for testing user experience.

This reads like its a duplicate of #4324, closing in favor of that.  If there is a reason we need a unique issue for this, let us know!


A short example of real-time event streaming using Spring Webflux by<EMAIL_ADDRESS>

A quick and practical example of the Spring Webflux support on the server side, and on the client side, a simple Reactive Web client.
The endpoint produces one event (i.e. current time stamp) per second infinitely and the client side simply consumes and logs the events as they arrive.

This PR is only for demo purpose hence closing it.


Shut down redis-server properly on exit from ./go serve

redis-server instances launched automatically via ./go serve would previously not flush their databases to disk before exit, resulting in updates disappearing between short-lived runs.

Coverage remained the same at 98.088% when pulling 52a48c51e7b75d1e0391874f635620800f6bc924 on redis-shutdown into 5b4a585b4a9bee8dba7f0e1cc8f8b1d4911272f1 on master.


Update or replace drf-jwt

We use the package drf-jwt in edx/completion, edx/course-discovery, edx/credentials, edx/demographics, edx/ecommerce, edx/edx-analytics-dashboard, edx/edx-analytics-data-api, edx/edx-drf-extensions, edx/edx-enterprise, edx/edx-enterprise-data, edx/edx-notes-api, edx/edx-organizations, edx/edx-platform, edx/edx-proctoring, edx/edx-rbac, edx/edx-val, edx/edx-when, edx/enterprise-catalog, edx/license-manager, edx/portal-designer, edx/registrar, edx/video-encode-manager. It hasn't yet added support for Django3.2. Please follow the guidance in https://openedx.atlassian.net/wiki/spaces/AC/pages/3036972032/Handling+Outdated+Dependencies to resolve the problem this poses for the Open edX Django 3.2 upgrade.

I have created an issue, asking for a support from a maintainer in  drf-jwt — https://github.com/Styria-Digital/django-rest-framework-jwt/issues/101
I'll keep you posted on it.

@GlugovGrGlib Thank you so much for picking this up, I appreciate! Please update us here on your progress.

@natabene Sorry for the delayed response, this ticket can be moved to review state and closed. The maintainer of the drf-jwt library has confirmed that there's no upper bound for Django dependency, and no code changes/release required.
We can continue using version 1.19.1, that was released May 18th 2021, in all edX repositories.
The only change since the released version that tox configuration was added, it allows testing the library against django3.2 env. I ran the tests against Python 3.8.12 and Django 3.2.8, all tests are passed, the total coverage is 95%.

@GlugovGrGlib Thank you so much for all you effort on this. Marking as done.


User-reported unhelpful error message

Program: https://code.world/#P2NRyiX0G4NWXo8OL1Nrw1w
Comment:
idk
Message:
program.hs:8:1: error:
    parse error (possibly incorrect indentation or mismatched brackets)

Missing close-parenthesis after the 6.  Without resolving names and types, it's hard to do better.


compiler.py is broken on mac

after installing devito on mac using pip
pip install --user git+https://github.com/opesci/devito.git

I ran the first notebook from cfd examples 01_convection.ipynb, which works fine untill the cell which creates and applies the operator object.
# Create an operator that updates the forward stencil point
op = Operator(Eq(u.forward, stencil, subdomain=grid.interior))

# Apply the operator for a number of timesteps
op(time=nt, dt=dt)

running this part of the code generates the following error:
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-13-cbb05a4243bf> in <module>
     12
     13 # Apply the operator for a number of timesteps
---> 14 op(time=nt, dt=dt)
     15

~/Library/Python/3.7/lib/python/site-packages/devito/operator.py in __call__(self, **kwargs)
    571
    572     def __call__(self, **kwargs):
--> 573         self.apply(**kwargs)
    574
    575     # Pickling support

~/Library/Python/3.7/lib/python/site-packages/devito/operator.py in apply(self, **kwargs)
    507         arg_values = [args[p.name] for p in self.parameters]
    508         try:
--> 509             self.cfunction(*arg_values)
    510         except ctypes.ArgumentError as e:
    511             if e.args[0].startswith("argument "):

~/Library/Python/3.7/lib/python/site-packages/devito/operator.py in cfunction(self)
    426         """The JIT-compiled C function as a ctypes.FuncPtr object."""
    427         if self._lib is None:
--> 428             self._compile()
    429             self._lib = load(self._soname)
    430             self._lib.name = self._soname

~/Library/Python/3.7/lib/python/site-packages/devito/operator.py in _compile(self)
    420         """
    421         if self._lib is None:
--> 422             jit_compile(self._soname, str(self.ccode), self._compiler)
    423
    424     @property

~/Library/Python/3.7/lib/python/site-packages/devito/compiler.py in jit_compile(soname, code, compiler)
    445                                                   cache_dir=cache_dir,
    446                                                   debug=configuration['debug-compiler'],
--> 447                                                   sleep_delay=sleep_delay)
    448         toc = time()
    449

TypeError: compile_from_string() got an unexpected keyword argument 'sleep_delay'

removing sleep_delay=sleep_delay from the argument list of compile_from_string solves the problem.

Your dependencies are out of date, in particular codepy. Please run
pip install -U requirements.txt you probably updated devito but not its requirements

@gdadunashvili I'm closing this issue as @mloubout 's reply looks satisfactory to me, but feel free to reopen if the issue persists .

The @mloubout 's reply indeed resolved the issue. Thanks a lot!

Your dependencies are out of date, in particular codepy. Please run
pip install -U requirements.txt you probably updated devito but not its requirements


pull request for e2e test at 12/17/2016 18:56:18

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


maxFileSize Bug

When I set maxFileSize, then I choose the large picture, which size is  large then i set
It will show the [fileTooLargeMessage] what i set
But I choose small size picture again, and it will nothing happend.......

I wasn't able to recreate this: I chose a file that was too large and it rejected it as expected, then I chose an image of the correct size and it uploaded it just fine.


Dashless Home UI like J2K

Describe your suggested feature
There should be a togglable option to make the home UI similar to J2Ks home UI. Meaning when you scroll down the title bar and the nav bar disappears. And the swipe to change categories like J2K. And also the option to group updates and history into a single tab. This single UI design is probably the sole I can't switch to any other forks and jay has gone radio silent. The browse tab UI could also use some finesse.
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an official extension, I should be opening an issue in the extensions repository.
[X] I have updated the app to version 1.10.5.
[X] I will fill out all of the requested information in this form.

J2K is still using old UI framework which will require effort to re-implement his UI. Anyway, I planed to do it sometime in future.

J2K is still using old UI framework which will require effort to re-implement his UI. Anyway, I planed to do it sometime in future.

it will be good.
one hand move is good.
especially in source pages.
filters should be below etc?


x/vuln: incorrect version is suggested as a fixed version for a vulnerability with multiple packages

What version of Go are you using (go version)?

$ go version
go version go1.19 darwin/amd64

$ go version -m ~/go/bin/govulncheck
/Users/hakim/go/bin/govulncheck: go1.19
        path    golang.org/x/vuln/cmd/govulncheck
        mod     golang.org/x/vuln       v0.0.0-20220902211423-27dd78d2ca39      h1:501+NfNjDh4IT4HOzdeezTOFD7njtY49aXJN1oY3E1s=
        dep     golang.org/x/exp        v0.0.0-20220722155223-a9213eeb770e      h1:+WEEuIdZHnUeJJmEUjyYC2gfUMj69yZXw17EnHg/otA=
        dep     golang.org/x/mod        v0.6.0-dev.0.20220419223038-86c51ed26bb4        h1:6zppjxzCulZykYSLyVDYbneBfbaBIQPYMevg0bEwv2s=
        dep     golang.org/x/sys        v0.0.0-20220722155257-8c9f86f7a55f      h1:v4INt8xihDGvnrfjMDVXGxw9wrfxYyCjk0KbXjhR55s=
        dep     golang.org/x/tools      v0.1.13-0.20220803210227-8b9a1fbdf5c3   h1:aE4T3aJwdCNz+s35ScSQYUzeGu7BOLDHZ1bBHVurqqY=
        build   -compiler=gc
        build   CGO_ENABLED=1
        build   CGO_CFLAGS=
        build   CGO_CPPFLAGS=
        build   CGO_CXXFLAGS=
        build   CGO_LDFLAGS=
        build   GOARCH=amd64
        build   GOOS=darwin
        build   GOAMD64=v1

Does this issue reproduce at the latest version of golang.org/x/vuln?
yes
What did you do?
$ git clone https://github.com/hashicorp/vault
$ git checkout v1.7.0
$ govulncheck ./...

See the reports on GO-2021-0061 (affecting vulnerability) and GO-2022-0493 (in the 'informational' section).
What did you expect to see?
GO-2021-0061: This project imports 'github.com/go-yaml/yaml'. According to https://pkg.go.dev/vuln/GO-2021-0061 there is no known fix for this module. I expect govulncheck to tell this, or suggest users migrate to<EMAIL_ADDRESS>GO-2022-0493: This project imports affected golang.org/x/sys/unix (v0.0.0-20210124154548-22da62e12c0c). I expect govulncheck to recommend v0.0.0-20220412211240-33da011f77ad (as listed in https://pkg.go.dev/vuln/GO-2022-0493) or a reasonable version.
What did you see instead?
govulncheck suggests<EMAIL_ADDRESS>and<EMAIL_ADDRESS>which aren't valid.
Vulnerability #1: GO-2021-0061
  Due to unbounded alias chasing, a maliciously crafted YAML file
  can cause the system to consume significant system resources. If
  parsing user input, this may be used as a denial of service
  vector.

  Call stacks in your code:
      builtin/credential/okta/path_config.go:326:40: github.com/hashicorp/vault/builtin/credential/okta.ConfigEntry.OktaClient calls github.com/okta/okta-sdk-golang/v2/okta.NewClient, which eventually calls github.com/go-yaml/yaml.Unmarshal

  Found in<EMAIL_ADDRESS>  Fixed in<EMAIL_ADDRESS>  More info: https://pkg.go.dev/vuln/GO-2021-0061

...
Vulnerability #2: GO-2022-0493
  When called with a non-zero flags parameter, the Faccessat function
  can incorrectly report that a file is accessible.

  Found in<EMAIL_ADDRESS>  Fixed in<EMAIL_ADDRESS>  More info: https://pkg.go.dev/vuln/GO-2022-0493

FYI GO-2022-0493 case is fixed (pure bug) at the latest version of govulncheck.
GO-2021-0061 case still exist.


[Feature Request] swappable advertisement board

hey, thanks for this amazing plugin!
usually when i play the game i use other peoples houses because of my low const, and therefore have set my default interaction with the advertisement boards to "visit last".
this is where my suggestion comes in, on log-on your visit last is set to nothing, gives an error message like "you havent visited bla bla bla" so i was wondering if we could get it where holding down a hotkey switches the interaction to "view advertisements" (or whatever it actually is)?
the problem is a mild inconvenience but  with this plugin it could become a QOL

This sounds like it would be possible now.


[Feature] <FOTOPEDIA is not exists, Closed>

Problem

Description

Dear Creative commons, in the section of OERs, there is mentioned " Fotopedia " . According to web search and Wikipedia the fotopedia platform has been closed. It is requested that please omit the information about fotopedia. Thank you.
Alternatives

Additional context

Implementation

[ ] I would be interested in implementing this feature.

Is this still open? Can I work on it?


Create .gitignore

Could anyone suggest additional common files or patterns that should be added to .gitignore for a typical web project (e.g., IDE-specific files, system files, logs, etc.)?

Add:
.DS_Store
*.tmp
npm-debug.log
.env
.env.local
.env.production
.env.development


Report the CPU, RAM, Disk, and Network I/O of the influxdb3 process during load generation

When running the load generator it should have an optional parameter to collect system metrics for the influxdb3 process running on the box. This assumes in this case that the load generator is running on the same system as the influxdb3 process.
Ideally we'd collect CPU, RAM, Disk, and Network metrics every second during the test run and write that data out to csv files. Since each of these have different schemas, it probably makes sense to have each one output its own csv file. In addition to the reported metric, include test_time_ms and wall_time in the results.
CPU and RAM are the most important here, we can start with those if it's easier.

@pauldix - Here are is what we could grab using the sysinfo crate from the running influxdb3 process:

cpu_usage: total CPU usage, may be greater than 100 for multi-core
normalized_cpu_usage: may calculate this as cpu_usage / num_cpus
disk_written_bytes/disk_read_bytes: these can be grabbed incrementally, or in total from when the process started
memory_bytes
virtual_memory_bytes

I aim to start with these. Beyond that, i.e., for network stats, we will need to look for alternatives. I have not yet found a crate that can fill that gap.

That's a great start. RAM and CPU are the most important for our purposes with disk third and network a very distant fourth. I'd say skip network for now and we can come back to it if we find it's something we need.


[Feature] Allow structure exporting in non Terra worlds

Pre-Request Checklist

[x] I have checked that I am on the latest version of Terra.
[x]  I have searched github for similar features requests, including closed ones, and found none.
[x] I believe this is within the scope of Terra.
[x] This feature request is for all of Terra, and isn't something that should be implemented by a pack or addon.

Feature Description

What Problem Does This Solve?
Currently, exporting structures is limited to Terra worlds, lifting this restriction would allow for easier and faster exporting of structures from commonly used grids (which are usually in super flat / void worlds. While the grids can be copied and pasted into a new Terra world, this just saves an extra step.
A Solution You'd Like
Not checking the world type on /te structure export
Alternative Solutions

A config option.
Including this within the debug option.

structure exporting to terrascript is no longer supported, sponge schematics should be used for static structures.


'When' clauses are ignored for shortcuts that toggle panels or sidebar

VSCode Version: Code - Insiders 1.17.0-insider (f7962f0682a76516df51de4856f8ccc5d8ad578a, 2017-09-20T05:24:33.599Z)
OS Version: Windows_NT x64 6.1.7601
Extensions: none

Key bindings for commands that toggle sidebar or panel visibility ignore 'when' clause contexts, making it impossible to limit them to certain contexts.
Use case: some shortcut schemes (e.g. Intellij IDEA) have a shortcut to hide current active sidebar or panel, and a VScode extension that provides such keybindings wants to recreate this functionality through a shortcut that toggles panels and the sidebar only when they are active, essentially turning a toggle into a closer. But since 'when' clause contexts for these actions always evaluate to true, the shortcuts become globally active and act as toggles. And while the last three shortcuts from that snippet are replaceable with a global shortcut for workbench.action.closePanel, there is no corresponding action to close (not toggle) the sidebar.
Steps to reproduce:

Pick an unused shortcut, e.g. ctrl+l, and a context that would be inactive during the next steps, e.g. parameterHintsVisible.
Add any one of the following settings to keybindings.json:

{ "key": "ctrl+l",                "command": "workbench.action.toggleSidebarVisibility",
                                     "when": "parameterHintsVisible" }

{ "key": "ctrl+l",                "command": "workbench.action.togglePanel",
                                     "when": "parameterHintsVisible" }

{ "key": "ctrl+l",                "command": "workbench.actions.view.problems",
                                     "when": "parameterHintsVisible" }

{ "key": "ctrl+l",                "command": "workbench.debug.action.toggleRepl",
                                     "when": "parameterHintsVisible" }

{ "key": "ctrl+l",                "command": "workbench.action.terminal.toggleTerminal",
                                     "when": "parameterHintsVisible" }

Set focus to the current text editor.
Press ctrl+l.

Expected result: nothing should happen, the 'when' clause evaluates to false so the shortcut should be disabled.
Actual result: the shortcut works, the relevant panel/sidebar visibility is toggled.

@sandy081 What is this issue: bug? as-designed? feature-request? Is there any milestone?

@monk-time The parameterHintsVisible-clause is set within an editor and its value represents if the signature/parameter help widget is visible or not. That usually happens when typing code, e.g function invocations. So, my question is why you depend on that clause?

I am not the issue author, but previous title was more precise: it doesn't limited to parameterHintsVisible context --- these commands ignore ALL when contexts (at least the ones that I tried).
This works:
{
    "key": "ctrl+shift+9",
    "command": "editor.action.insertSnippet",
    "when": "explorerViewletVisible"
}

This doesn't:
{
    "key": "ctrl+shift+8",
    "command": "workbench.actions.view.problems",
    "when": "explorerViewletVisible"
}

@jrieken The poster above is right, and I admit I could've made it clearer: when I was testing this, all clauses that I've tried were ignored. As I wrote in Step 1, parameterHintsVisible is just an example of a clause that is most likely to be false, it could be any other clause.
I'll change the title back if you don't mind.

Is this issue related https://github.com/Microsoft/vscode/issues/26318?

when I was testing this, all clauses that I've tried were ignored

You most likely tested with when-clauses that are only set inside an editor. There can be multiple editors at the same time (side by side, nested, diff etc.) and therefore multiple (nested) containers for context keys exist. The parameterHintsVisible-clause is set multiple times (once per editor) but not "globally" because they only make sense in the scope of an editor. What should the global-value of a editor-local clause be if its true for one and false for another editor? The rule of thumb is that clauses starting with editor are available inside editors only. However we aren't very good with that rule and clauses like parameterHintsVisible and others exist... This list list clauses and the scope in which they are available: https://code.visualstudio.com/docs/getstarted/keybindings#_when-clause-contexts

@jrieken, I don't have time to understand this undocumented local/global scope distinction, but this issue is about 'when' clauses that don't work as documented. Since it doesn't seem like you have tried to reproduce what I've described in the OP, I took the fresh Insiders build and put a simple action into keybindings.json:
[
    { "key": "ctrl+l",                "command": "editor.action.toggleMinimap",
                                         "when": "inDebugMode" }
]

I create a new file, set the cursor to the main and only editor, debug mode is obviously not active, I hit ctrl+l, and the minimap gets toggled. This means that the clause was completely ignored.
If you are talking about some other issue, please stop changing this one into something that is not related to it and open another issue. Sorry, but I am getting really frustrated here.

Can you find even 1 when context for which workbench.action.terminal.toggleTerminal won't ignore it? I tried:
[findWidgetVisible, inQuickOpen, explorerViewletVisible, terminalFocus, searchViewletVisible, config.editor.minimap.enabled, replaceActive, globalMessageVisible, parameterHintsVisible, renameInputVisible, openEditorsFocus, explorerViewletFocus, inDebugMode]
and some negations.

nothing should happen, the 'when' clause evaluates to false so the shortcut should be disabled.

@monk-time I am sorry, I mis read that and though about the opposite.
I believe the problem is that those command appear in the global menu (with their assigned shortcut) and that therefore they are bypassing our context key checks... It's actually not us handling the keybinding at that point... Needs some thinking

Yep, command is being called by global menu, not the keybindings service.... @bpasero Is this something new?

@jrieken I verified that this issue exists back until 1.15, so I do not think this is a regression. However it looks like on all platforms, if you press the keybinding of an existing menu item, we go through the menu (first I thought this would only happen on macOS, but seems to happen on Linux and Windows as well).
Unfortunately I see no way of finding out if a command was triggered by explicit click in the menu vs. using the keybinding. If someone has ideas, let me know.

Unfortunately I see no way of finding out if a command was triggered by explicit click in the menu vs. using the keybinding. If someone has ideas, let me know.

Well, we dispatch it from the main onto the active window. We just don't treat it has key key event but call executeCommand directly

@jrieken yeah that could work, if you can advise what to do where we receive the command in vscode:runAction we could wire it in.
I guess what we need to have is the actual keybinding that was added to the menu though, otherwise we could probably not know which when clause to evaluate. We get the keybindings from the renderer in resolveKeybindings

You could try lookupKeybinding but I believe that returns undefined for both cases: a command has no keybinding or the context doesn't match...

If this is to be left how it is, I would at least recommend a warning/error is displayed when a "when" scope is used on an unsupported action.

This should work with @sbatten work once it landed.

@bpasero is the custom title bar the final fix for this though? I don't see a custom title bar even feeling that great on Linux.

@Tyriar what @sbatten is doing will make it also better for the native menu: all entries will be built via commands and update properly.

@bpasero so the keybindings will update when contexts change?

@Tyriar no, menu items can show up as disabled or removed if the context does not match anymore. this allows to contribute an entry to the main menu that is only enabled/visible under certain conditions (something that we did not have before).

This is working now.

Blocked by dynamic menus still not being enabled on macOS and Linux.

As discussed this will be unblocked debt week in october

resolved with #59936 and #59855

Still works:
	{
		"key": "ctrl+l",
		"command": "workbench.action.toggleSidebarVisibility",
		"when": "false"
	}

VS Code version: Code - Insiders 1.29.0-insider (d7ac6e838f51a03f7d417b4758f5fb075878d615, 2018-11-01T06:11:43.390Z)
OS version: Darwin x64 17.7.0

@sbatten As we are all aware from multiple discussions on this topic, contexts are different depending on where the focus sits. I can implement a new method in IKeybindingService to look up keybindings based on context, but then won't you have 100% the same problem as the one described in #55453 , which cannot be solved due to performance concerns -- specifically https://github.com/Microsoft/vscode/issues/55453#issuecomment-414757635

@alexandrudima this iteration, I have made some improvements that greatly reduce the amount of updates the menu based on context. My current view is that the global application menu reflects the global context so enablement/disablement/keybindings must be based on context keys in the global scope. Thoughts?

@sbatten

My current view is that the global application menu reflects the global context so enablement/disablement/keybindings must be based on context keys in the global scope. Thoughts?

That is also incorrect, but in a different, more subtle way, and arguably would make things a lot worse. Before jumping to implement something worse, let's look at the problem.
Take, for example, the Selection menu:

Now let's look at a default keybinding from there:
{ "key": "shift+alt+up",          "command": "editor.action.copyLinesUpAction",
                                     "when": "editorTextFocus && !editorReadonly" },

editorTextFocus is undefined in the global context, so the when clause would not hold. So, the action would get no keybinding rendered next to it.

Also, I think this bug affects only the native menu, because in the native menu case the menu itself (Electron via C++ code) listens to those keybindings and executes the menu item directly, outside of our logic. For custom menus, this is no longer a problem.

I think there are two possible correct fixes:

evaluate focused context
enhance Electron to provide information if a native menu item is invoked because the user clicked on it, or used arrow keys + enter, or invoked the keyboard shortcut. If we were to differentiate between these cases, then we could interpret ourselves the keyboard shortcut.

enhance Electron to provide information if a native menu item is invoked because the user clicked on it, or used arrow keys + enter, or invoked the keyboard shortcut.

We might be able to know that. I have tested mac and clicking vs keyboard shortcuts can be differentiated by the event - it's only partial but when pressing cmd+z the metaKey modifier is set, when clicking all are false.

@alexandrudima

My current view is that the global application menu reflects the global context so enablement/disablement/keybindings must be based on context keys in the global scope.

This was more of a statement of how I think things should be not necessarily how they are, but I agree this should be fleshed out. With this view actually in place, it limits the menu updates to relevant updates only for enablement/disablement/keybindings thanks to the support in @jrieken's menu model.
For keybindings, we could fix this issue by trying to update the menu on every focus change, but that seems excessive. We also would still run into this issue with enablement/disablement, however. Keybindings get resolved for the menu each time it is updated. Enablement/Disablement does not. The context is set once when the menus are created in the model.

lookup keybindings based on focused context and constantly update the menus.

This makes me ask the question why the context service doesn't support evaluating against the current context based on focus if that's what matters instead of being required to track focus around. If I could set a flag on the context service to do this before handing it to the menu model and the keybinding service could use that when evaluating keybinds, it could work.
Yes, I am coupling two issues but they are both related to resolving commands against a focused context.


Implement text2rest for querying data from Waldur API

We need to redefine this issue, because as of 3e79fad177aa1ed73bd528eca4303c62a2691b12 we have a very basic text2rest implementation for one request, but I wouldn't say that this constitutes as solving this issue.

A simple implementation is done in 3e79fad177aa1ed73bd528eca4303c62a2691b12
Opened a new issue for improving this solution #23

Associated functional requirement: 1


bugsnag-source-maps upload-react-native is timing out

This started failing recently for us.   Is this a service issue or did something change?   Using the latest 2.1.0 version.
$ /Users/nicholashodapp/Documents/Projects/iOS/Narwhal/node_modules/.bin/bugsnag-source-maps upload-react-native --api-key ***redacted*** --code-bundle-id com.remitly.remitly --platform ios --source-map ./build/ios/index.ios.bundle.map --bundle ./build/ios/index.ios.bundle
ℹ Preparing upload of React Native source map (release / ios)                       13:39:25
› Reading source map "./build/ios/index.ios.bundle.map"                             13:39:25
› Reading bundle file "./build/ios/index.ios.bundle"                                13:39:26
ℹ Applying transformations to source map                                            13:39:26
› Ensuring sourcesContent field is populated                                        13:39:26
› Stripping project root from sources                                               13:39:26
› Initiating upload to "https://upload.bugsnag.com/react-native-source-map"         13:39:26

 ERROR  The request timed out.                                                      13:44:32

 Connection timed out

  at ClientRequest.<anonymous> (node_modules/@bugsnag/source-maps/dist/Request.js:190:21)
  at Object.onceWrapper (events.js:421:28)
  at ClientRequest.emit (events.js:315:20)
  at TLSSocket.emitRequestTimeout (_http_client.js:709:9)
  at Object.onceWrapper (events.js:421:28)
  at TLSSocket.emit (events.js:327:22)
  at TLSSocket.Socket._onTimeout (net.js:482:8)
  at listOnTimeout (internal/timers.js:549:17)
  at processTimers (internal/timers.js:492:7)

error Command failed with exit code 1.

@TomSwift
No known service issues at this time. Could you contact<EMAIL_ADDRESS>with details of which Bugsnag organization account and project this is for and UTC timestamps of when you've seen failures so we can investigate on our side. Thanks!

FWIW Also experiencing random timeouts.

Just wanted to follow up to say we have now released a new version (v2.3.0) of our bugsnag-source-maps tool which will increase the default timeout to 10 mins along within adding an idle-timeout config option to give configurability around setting your own timeouts. We have added some documentation on that here. This should hopefully help with the timeout issues you are experiencing.


Compile issue.

I can't use SnapKit at Xcode 8.2.1
I added project as by using CocoaPod.
I am  getting following issue.
“Use Legacy Swift Language Version” (SWIFT_VERSION) is required to be configured correctly for targets which use Swift. Use the [Edit > Convert > To Current Swift Syntax…] menu to choose a Swift version or use the Build Settings editor to configure the build setting directly.
pod 'SnapKit', '~> 3.1.2'
Please help me.
Thanks.

Closing because issue does not follow issue template.


CloudFormation - Number of resources limit reached on the Central Network Account for NetworkVpcStack

We tried to add a VPC into the Central Network account (with all subnets, nacl, ipam pool, etc) that leads to an error from number of resources in the CloudFormation Stack.
2024-07-23 20:50:35.613 | error | accelerator | Number of resources in stack 'AWSAccelerator-NetworkVpcStack-XXXXXXXXX-ca-central-1': 546 is greater than allowed maximum of 500:
We read that this is a "hard" limit that can't be bypass.
What are the possibilities ? We saw that nested stack is a way to prevent this but how while it's the LZA that generate those stacks?
LZA version : 1.62

Hi JimToupet
This issue should be logged with the LZA repo, and ideally with AWS Support (AWS Console -> Support -> Control Tower -> Landing Zone Accelerator). However, I will also raise awareness with the team internally.

This may be the same issue: https://github.com/awslabs/landing-zone-accelerator-on-aws/issues/320


Linter

Rules for a linter to evaluate given the input of fern.yml

lowercase lettering on "imports" "ids" "types" "services" "errors"

ids is a list, e.g. - UserId

each object in types is either an enum or properties
(are there any other use cases?)

int should be integer

? should be optional<type>

using fern check as the YAML validator. closing this issue which represents an idea not pursued.


[TPC-H] Query 11 and 13 memory issue

This looks like another instance of the problem in #1376. We end up with a groupby-aggregate that leaves us with ~30M groups in a single partition.
Edit (Patrick): Query 13 has exactly the same issue

This is a bit harder to detect though, this is actually something where the cardinality is needed to make a more informed decision

This one turns out to be a bit trickier. There's an instance of a groupby with many unique values, as well as a join with a single value of the (partitioned) nations dataset (#1380). However, neither trivial fix (split_out=True or broadcast=True solves the memory issue completely. I suspect that imbalanced partition sizes are also to blame (https://github.com/coiled/benchmarks/issues/1367#issuecomment-1936080012).

The broadcast flag wasn't properly preserved when pushing filters down, this is probably why that looked weird for @hendrikmakait
Pr to fix is here: https://github.com/dask-contrib/dask-expr/pull/871
Have to rerun after that one is in

@phofl: This looks much better now, thanks! https://cloud.coiled.io/clusters/383307/information?tab=Metrics


Minor adjustments for the tests and codestyle

During the #1062 a couple of minor problems was found:

GetVirtualTransactionSize must have a sigOpCost as an argument. Right now this test passes just by coincidence.
In p2p_fingerprint.py we need to take unspent coins before the substituted subchain.
Clang formatting

Signed-off-by: Dmitry Saveliev<EMAIL_ADDRESS>

GetVirtualTransactionSize must have a sigOpCost as an argument. Right now this test passes just by coincidence.
I think it's not coincidental that the test passes, since the scripts used in the test have a sigop cost of 0 anyway. It doesn't hurt to add the parameter, but Bitcoin doesn't have it, so maybe we should keep everything as it is?

Although this PR is quite small, I think we should separate the fix to the p2p_fingerprint test from the style changes.

I think it's not coincidental that the test passes, since the scripts used in the test have a sigop cost of 0 anyway. It doesn't hurt to add the parameter, but Bitcoin doesn't have it, so maybe we should keep everything as it is?

Not quite, TestMemPoolEntryHelper is initialized with sigOpCost = 4:
https://github.com/dtr-org/unit-e/blob/c85d170adbe575b94000d0be3b5b9fb5f238740f/src/test/test_unite.h#L122
which goes further to CTxMemPoolEntry
https://github.com/dtr-org/unit-e/blob/c85d170adbe575b94000d0be3b5b9fb5f238740f/src/test/test_unite.cpp#L169
which finally affects indexed_transaction_set
https://github.com/dtr-org/unit-e/blob/c85d170adbe575b94000d0be3b5b9fb5f238740f/src/txmempool.cpp#L100
and finally affects the TX order.
So, here we have a green test just because nWeight is bigger here:
https://github.com/dtr-org/unit-e/blob/365cf0d4b5d580f5a202b519ab316ac1ea28cf0a/src/policy/policy.cpp#L263


date picker minimum instalation?

@eternicode , please
what need minimum require on : http://cdnjs.com/libraries/bootstrap-datepicker
to runing date picker?

What do you mean?
This is an example for a minimum setup: http://jsfiddle.net/zcvq0yhh/


[SYSTEMML-1143] Fix m2e errors in Eclipse for scala-maven-plugin

Add scala-maven-plugin goals to lifecycle-mapping to avoid m2e Eclipse errors.

Thanks @deroneriksson!
LGTM

Thanks for reviewing @gweidner!


[Bug] 使用encode取data中不存在的字段时出现意料之外的结果

Version
5.4.3
Link to Minimal Reproduction
https://echarts.apache.org/examples/zh/editor.html?c=area-stack&lang=ts&code=PYBwLglsB2AEC8sDeAoWsA2BTA5l6AJgFzIC-ANGrDgE4THKZYBmYJA5AMwCk75sdHAAs2sdgBZe_AEbAwYYAFsOPPrADGMMAEMI0ADLbpWDCTA0ArllgUqADwCCdiAGcSAbSSwwATxBYOdW0wXGAaHzVZC0JtcIBxbRASZm0MF2tSAF1KdB8nVw8vX38OADdUq3YbbKp0uiw3WHcqdFR0dthobUUAsQBRRV0MPhb24t72DD0sEY70fE0CXq87DmhgNR8yipmbUdsOtrmuno4AVWgoOAcCF1m58Y4p6BmcuYXgJZIVtY3-LbE5QwVgATFVSPsqDV0ARgtp0qIjugXMALDR1L1mnNGOsOABGNRAqwkAAcADoAGwk_hErB4kh4mxvQ6dYAcME0nYMgAMZJBAFZOcC6QymaNWqyVISubBOGTxABOIVWemwRkHOZeXFicTS4UkXmcCnKkVqvYdTJUCGkADcQA
Steps to Reproduce

option = {
  legend: {},
  grid: { left: '3%', right: '4%', bottom: '3%', containLabel: true },
  xAxis: [{ type: 'category', boundaryGap: false }],
  yAxis: [{ type: 'value' }],
  series: [
    {
      name: 'Email',
      type: 'line',
      encode: { x: 'no', y: 'value' }
    },
    {
      name: 'Union Ads',
      type: 'line',
      encode: { x: 'no', y: 'value2' }
    }
  ],
  dataset: {
    source: [
      { no: '1', value: 8.68, value1: 1 },
      { no: '2', value: 10.25, value1: 1 },
      { no: '3', value: 3.49, value1: 1 },
      { no: '4', value: 0.36, value1: 1 }
    ]
  }
};

Current Behavior
使用encode取data在不存在的字段时出现意料之外的结果
Unexpected results occur when using encode to fetch data for fields that do not exist
Expected Behavior
对应series不展示值
The value of the corresponding series is not displayed
Environment
- OS:
- Browser:
- Framework:

Any additional comments?
No response

If the encode attribute is incorrect it falls back to default and takes the first "free" column of the dataset. In your case this is the 'value' column since 'no' is taken for x. See this example.

Expected Behavior:  The value of the corresponding series is not displayed

So you are expecting the series with the wrong column name to not show up?
ECharts concept is different though. Instead of ignoring the series, it tries to find a suitable replacement.
When an encode column name is not found, the next non-assigned column is taken. In the example above, since column 'no' is assigned to x and 'value2' does not exist, then the next column 'value' is assigned to y.
Or another experiment - remove encode for both series. They will still display correctly because columns are auto-assigned in order.

In reality, the data I obtained contains many fields, but only some of them need to be displayed, and their x-axis fields are the same, and the y-axis fields may not exist, so there will be unexpected situations.
Can you provide a property that changes the default behavior?

What stops you from just checking if the fields exist beforehand?

This is a problem with the data source, and I can't help it. 🤣


Publishing commands to topics using aliases doesn’t appear to work

I’m using an alias file to give proper names to my devices. While echonetlite2mqtt appears to publish to the get topics using aliases fine, it doesn’t appear to be observing the set topics for commands using aliases.
If I publish a command to the original device id, echonetlite2mqtt appears to see the command and respond properly.

@aftertommy
Thank you for your report.
I reproduced the problem.
This is a bug of ECHONETLite2MQTT.
I will fix this soon.

@aftertommy
I fixed this issue in v2.0.2.
Please upgrade and check the fix.

I just gave it a shot. It appears to be working! Thank you!


scss files disconnected

I noticed that I was only getting CSS from my top-level component, which was included in the index.scss. However, any components that were child components were not included in the built version.
I solved this by adding imports (e.g. index.scss imports topLevel.scss, which imports subComponent.scss, which imports subSubComponent.scss).
Is this not how it should be generated when you add a new subcomponent?

Currently it is done manually so it is up to the creator to add the scss files, either by as you are mentioning by importing them in the parent scss file or by adding them to the components.scss file.
We usually add them to the components.scss file manually instead of the parent file, and I will make a change in an upcoming version so that is the default behavior when creating subcomponents.


npm global install path sucks

@mnfmnfm, clarify?

<sarcasm>
you mean this isn't self-explanatory?
</sarcasm>
Many students, on many OS's, have had the experience that npm i -g puts something in a global install location that is not on their PATH, so they can't actually run the installed program. Especially if we move live-server installation to prework, we should ensure that we give links to StackOverflow etc. on how to change the npm global install path to something on the PATH.

Ah, gotcha.
On Fri, Aug 17, 2018 at 2:38 PM Michelle Ferreirae<EMAIL_ADDRESS>wrote:

you mean this isn't self-explanatory?

Many students, on many OS's, have had the experience that npm i -g puts
something in a global install location that is not on their PATH, so they
can't actually run the installed program. Especially if we move
live-server installation to prework, we should ensure that we give links
to StackOverflow etc. on how to change the npm global install path to
something on the PATH.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/codefellows/code-201-prework/issues/60#issuecomment-413994806,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHhliVjb7WUQi-t_JDMYQJoeypjEebQyks5uRzfEgaJpZM4V9C6B
.

I have an older doc in the prework stuff that walks through adding stuff to the PATH on Windows. You might be able to scrap some of that. Here's the link https://github.com/codefellows/code-201-prework/blob/master/prework/old.windows/4_install_tree.md

Has been updated for WSL, and have seen this less on Macs in the last month. Closing.


Amend ordering of dashboard panels so that NEET and labour market pages are at the top

Feedback from YFF:
On the dashboard would make sense to flip it round with NEET and vacancies at the top rather than inflation, given our focus and likely readers.
Amend how the dashboard panels are ordered on https://data.youthfuturesfoundation.org/dashboards/ so that links to the NEET and labour market dashboards appear first.

Ordering set by explicitly setting the priority data key - set in index.njk for labour market and neet pages. Default, set in src/dashboard/_data.yml is 0. Higher numbers make pages sort higher. Secondary sort is on title.
This code in src/pages/dashboards.njk implements the sort.
{% for page in search.pages("dashboard", "priority=desc title=asc") | data %}
  {{ comp.superlink({ page: page }) | safe }}
{% endfor %}


sweep: allow force sweeping of negatively yielding inputs

This PR adds force sweep functionality to the sweeper. Force sweep signals that an input needs to be swept even if its yield is negative. This is useful in CPFP scenarios where the parent tx output is only small. This will be common in the upcoming new anchor outputs commitment format.
The force flag is exposed on the BumpFee rpc call and through lncli. In many cases it will be required to have a wallet utxo available to bring the tx output above the dust limit. PR #3814 extended the sweeper with the capability to attach wallet utxos if needed.

@joostjager Will this PR solve the use case where channel was closed with small local balance?
Right now I have ~2000 sat that can't be swept due to fee rate.
in https://github.com/lightningnetwork/lnd/pull/3814 there is an attempt to use additional input but I don't have any in my wallet.

With an input of that size, the idea is to modify the sweep fee rate to a lower value using the bumpfee rpc, so that it becomes economical to sweep. Without a wallet utxo, it still needs to produce a tx that has an output above the dust limit.
Note that the sweeper uses fee rate buckets to batch inputs together. The first bucket is 1-10 sat/byte. The actual sweep fee rate is the average of all inputs in a bucket. If your input is the only input in the 1-10 bucket and you've lowered the input fee rate preference to 1 sat/b, it should be swept at that rate.
This PR is not adding anything to that. It mainly allows negatively yielding inputs to be swept using the force flag, but for that you also need a wallet utxo.

Note to self: @cfromknecht suggested to require regular inputs to not just be positively yielding, but yield at least 2/3 (for example) of their value

Checked what is needed for that minimum yield requirement. The sweeper change is small, but there are quite a few changes in the test (setup) required. Leaving that change for a separate pr.

Comments processed, ready for another pass


Encapsulate logic to detect the end of PDUs received via sockets

Classes SimplisticSocketHandler on the server and MsgBoardClientHandlerImpl on the client are supposed to be independent of the wire format. They use helper objects for parsing the received PDUs. However, both classes implement some limited TLV parsing in order to detect when a full PDU is received. Ideally, these classes should work without changes if the wire format is changed, for example to JSON instead of TLVs.
Refactor the code to detect PDU boundaries. Implement a helper that can be used on both the server and the client. Keep the interface independent of the current TLV encoding. While TLVs provide the length of the PDU in the header, other formats might not. The helper should work equally well with blocking IO and asynchronous NIO.

General idea: For each incoming PDU, instantiate a stateful helper object. It gets access to the data received so far, and updates when more data comes in. It can tell:

Whether the PDU is complete, or some data is missing yet.
Where the PDU ends, once it is complete. The beginning of the next PDU might have been received already.
Optional: how much more data is expected. Useful to verify or adjust buffer sizes.
Whether the data is totally screwed up and the connection should be dropped.

There should be a factory interface to instantiate the helper. The factory is stateless and passed to the code that receives data. The helper itself is stateful, so that it can keep track of partially processed PDUs. In the case of TLVs, it can compute the length of the PDU once, as soon as the first four bytes are available.
Tracking data about partially received and processed PDUs isn't that important for TLVs. Computing the length from the two bytes in the header requires no significant effort. For the API design, however, it is important to keep the receiving classes and the interface of the helper independent of the wire format.
Imagine that the wire format is JSON. There is no header with a length. The logic must process JSON data and keep track of how many braces, brackets, double quotes, and escape sequences still need to be closed before the PDU is complete. You wouldn't want to process the JSON data from the start again every time a few more characters have been received. Therefore, the API must allow for stateful helpers.
In the JSON case, it would actually be helpful to fully parse the received data along the way, and then use it without parsing it again. Maybe an API for only detecting the end of a PDU, without parsing it, is not such a good idea after all? Implement a stream parser for PDUs instead?

YAGNI


fix(engineimage): update status Incompatible during upgrade.

Which issue(s) this PR fixes:

Issue longhorn/longhorn#7539, longhorn/longhorn#7683
What this PR does / why we need it:
EngineImage.Status.Incompatible will be updated properly.
Special notes for your reviewer:
Additional documentation or context

@mergify backport v1.6.x


fix(ci): update pre-release version tag

Hello,
We had an overflow issue. NuGet doesn't like version 0.0.2239725856. This PR updates it to have either 0.0.1-beta0.0.2239725856 if no tag exists or {lastTag}-beta0.0.2239725856 if a tag is found.
Related to #123

Hello, here is an alternative way to deal with this. What do you think?
https://github.com/d-edge/extLauncher/pull/27
Only for PR pipelines, the idea is to get the latest tag or otherwise a default 1.0.0.
Then to add the metadata -snapshot.{run_id}.
I think snapshot is a better wording because it's a in progress dev. Beta sounds like the dev is almost finished and waiting for feedbacks.
git fetch --prune --unshallow --tags --quiet
LAST_VERSION=$(git describe --tags --abbrev=0 `git rev-list --tags --max-count=1` | cut -c2-)
if [ -z $LAST_VERSION ]; then LAST_VERSION="0.0.1"; fi
VERSION="$LAST_VERSION-snapshot.$GITHUB_RUN_ID"

I prefer Amin's version for the use of snapshot, plus I find it more legible
Just my 0.02€

Suffix wording

I think snapshot is a better wording because it's a in progress dev. Beta sounds like the dev is almost finished and waiting for feedbacks.

While Beta is a common suffix. I agree to use another one for the reason your mention. Snapshot feels odd to me. When I look online I find it mostly in the Maven ecosystem (e.g. Maven - Snapshots).
What would you think about using prerelease, alpha or build?
They all can be found in the NuGet documentation. For example alpha:

And I especially like build:

docs.microsoft.com
Pre-release numbers with dot notation

Then to add the metadata -snapshot.{run_id}.

NuGet supports semver 1.0:

docs.microsoft.com
dot separated metadata are not valid in semver 1.0. it is a feature of semver 2.0

A pre-release version number MAY be denoted by appending an arbitrary string immediately following the patch version and a dash. The string MUST be comprised of only alphanumerics plus dash [0-9A-Za-z-]. Pre-release versions satisfy but have a lower precedence than the associated normal version. Precedence SHOULD be determined by lexicographic ASCII sort order. For instance: 1.0.0-alpha1 < 1.0.0-beta1 < 1.0.0-beta2 < 1.0.0-rc1 < 1.0.0.

semver.org/spec/v1.0.0.html
My original solution followed the suffix logic of both semver1 and NuGet:
2.2.44-beta1

That said this is not entirely true. If we scroll a bit more in the Microsoft documentation, we can read that semver2 is supported in the later versions of NuGet:

docs.microsoft.com
So we are good to use -{suffix}.{run_id}. Note that by removing the dot we support older versions of NuGet.
Getting LAST_VERSION
LAST_VERSION=$(git describe --tags --abbrev=0 `git rev-list --tags --max-count=1` | cut -c2-)

I think that this line will throw an error if no tag are found:
fatal: No names found, cannot describe anything.

We can avoid it or hide it at least. In my original solution, I do git tag -l | wc -l to avoid it (i.e. acf27a3947da9a0fedc989468ad916561e360ac7). To hide it, you can redirect the output to null.

I believe we don't need to support old nuget versions as it's only part of the cicd and nuget.org.
+1 for build.{id}.

Little question. What is //v in ${version//v}?

Little question. What is //v in ${version//v}?

It is shell string manipulation.

One last thing we should discuss is the build_id. Right now the build_id is the run_id. An alternative discussed with @ytyukhnin is to go the CalVer road for the build_id.

GITHUB_RUN_ID
CalVer

is auto-incrementing
✔
✔

is easy to do
✔
✔1

work outside of GitHub
❌
✔

is meaningful
❌
✔

is customizable
❌
✔

1 one-liner: printf '%(%Y%m%d%H%M%S)T' -1
What do you think?

In general when there is no git tag, AFAIK run id is the only info helping to find quickly which pipeline (and so commit) is the trigger.

Strange, the patch part is missing in the last tag. v0.10 should be v0.10.0.

Do we really need it? I removed the line editing 0.10 to be 0.10.0.

For me, the run id was good enough, I don't feel that we really need to change it to calendar. I believe we discussed it IRL, but calver brings not much value to the table for me as long as products like nuget lists the date of items with their version number, and as such, the calver (for me) brings no real added value

@torendil Yes we talked about it a bit IRL. I bring it back to document it ;)

We are going to merge this one. Next step would be to distribute the fix across all project. Next step is to share the pipeline as a whole.


Make metadata_url optional in the saml interface

As it might not be defined

shouldn't the field in the pydantic model be updated to Optional[...]?

Sorry, I somehow forgot to add a file


Improve XCBuild output handling

In some situations, XCBuild's only output will be raw text to stdout, we need to handle this case properly because otherwise it will seem like a silent error in SwiftPM. In addition, in the case the only content is on stderr, we need to emit that before throwing.
rdar://82742081

This fixes the case where our integration tests where failing to look like this:
❯ sb --build-system xcode --target Foo
error: Could not find target named 'Foo'

@swift-ci please smoke test

I think we should also change JSONMessageStreamingParser at some point, it currently works a bit weirdly with raw output. If it happens to be intermixed with JSON messages, it can be parsed, but if there's only raw output we won't end up forwarding it. I don't see a good way to change that while keeping its current API and refactoring it seems to be a bit out of scope for a small fix like this. Also it's valuable to have a small fix that we can include in 5.5.x


Metadata in header?

Currently the encryption metadata (authtag etc) is encoded into the message value. That's fine and works perfectly well, but

it obscures that the value is encoded, and
if you had the situation where there was a forward (client-side) proxy which was doing topic encryption and a reverse (broker-side) proxy also doing topic encryption, it means the record would get encrypted again, for (presumably) no additional benefit.

An alternative would be to use a record header with a well-known name (e.g. strimzi.io/topic-encryption). This would result in a slightly larger message overall (due to the name), but could allow that reverse proxy to recognise that the record was previously encrypted, and so avoid encrypting it again.
When intercepting Fetch response the reverse proxy would need to recognise that although this was an encrypted record, it wasn't its' encrypted record. To do that we'd need to use some unique id for logically identifying these proxies, and this would also need to be a part of the encryption metadata.
So over all, this would result in some extra bloat, and we might decide we don't want to do this, but I thought it was at least worth a discussion.

I'd be +1 on using headers.
Re the overhead, it's true, OTOH, would it matter too much in practice? We probably could find a shorter one (e.g. having "topic" in there doesn't make awefully lots of sense IMO, as we encrypt messages/records; at the very least, it's redundant). Plus, it could be configurable (with a sensible default ofc.), too.


history-substring-search not working?

I can't tell if this is a bug for the framework, or the module, but it seems I cannot get history-substring-search to work. It's in my .zimrc:
zmodules=(directory environment git history input utility custom
          syntax-highlighting history-substring-search spectrum prompt
          completion)

but pressing up/down (or also esc+j/k since I'm in vi mode) seems to do nothing out of the ordinary? I feel like I'm missing something? I have no idea how to debug this.

well, turning off vi mode seems to fix it. I'm not sure how to activate it in vi-mode. I'll close cause it's probably my own fault

Using k/j will not work, as those keys are not currently bound to anything other than the default up/down. Not sure why that would change the normal arrow keys functionality, though. Check how the keys are bound with the init.zsh file of the history-substring-search module.
I plan to bind those eventually by detecting vi/emacs mode, but it's not available at the moment.

I haven't really altered much from a pretty straightforwards zsh installation with zimrc, ie I havent added any keybindings myself. I haven't ben using zsh very long so my knowledge of how vi mode works isn't great, I just figured I'd turn it on since I'm a vi user. I know a lot of base vi installations (not talking about zsh) disable the use of the arrow keys, so maybe zsh vi mode is imitating that?

If your ${EDITOR} variable contains *vi* then it will enable vi mode by default. I will have a real fix for this issue next week.

FWIW, I have no $EDITOR set

You should set it to vim or nvim then. ;)

I would but.....I've lived without it for so long and I'm pretty sure the only thing that I need it for is git, which seems to assume vim anyways.
Hadn't heard of neovim yet though, very interesting!

I was wondering why my history-substring-search stopped working. I recently set my default editor in /etc/profile to vim and when I went back after reading this to comment it out, the history-substring-search started to work after reboot again.


Create Get-PnPAzureADUser.ps1

Copy from Get-PnPAADUser.ps1

Docs Build status updates of commit 3b961d0:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-pnp/Get-PnPAzureADUser.ps1
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit c942d90:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-pnp/Get-PnPAzureADUser.ps1
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 64b5d4a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-pnp/Get-PnPAzureADUser.ps1
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@get-itips

Docs Build status updates of commit 1848dcf:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-pnp/Get-PnPAzureADUser.ps1
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Hello @YuriySamorodov
how are you?
Even though the PnP documentation articles are on this repository, I need to kindly redirect you to open PnP cmdlets issues/pull requests here, in that repository, where a member of the PnP community will be able to correct the article/review your PR with your feedback.
The documentation for PnP cmdlets is then synced from that repo into this one.
Thank you!


Rename main branch (originally named 'master')

Related:

https://github.com/napari/cookiecutter-napari-plugin/issues/19
https://github.com/napari/cookiecutter-napari-plugin/issues/18

Can we maybe just do this for the result of the cookie cutter? And not for this actual repo?  All our other stuff is still called master and it'd be nice to keep them similar until we change them all. (But I definitely think it makes sense for the plugin output)

Can we maybe just do this for the result of the cookie cutter? And not for this actual repo? All our other stuff is still called master and it'd be nice to keep them similar until we change them all. (But I definitely think it makes sense for the plugin output)

Sure we could, we'd just need to change a few lines in https://github.com/napari/cookiecutter-napari-plugin/issues/19
Might start getting a bit confusing keeping track of what is called what where, but it's certainly easy to do.

Sure we could, we'd just need to change a few lines in #19

thanks

Might start getting a bit confusing keeping track of what is called what where, but it's certainly easy to do.

Yeah, we're gonna have that problem eventually, but currently https://github.com/napari/napari, https://github.com/napari/magicgui, https://github.com/napari/tutorials, and https://github.com/napari/napari-plugin-engine all use master.  So while I know that users of this cookiecutter are gonna get main on most of the contributors to this repo are still using master for most of our things.  It'd be nice to make that switch across repos close together.

Just for reference, skimage moved to main today. I expect we'll follow closely behind with napari.


greedy argument parsing introduced by obviously evil ;) commit: 6669f0a

6669f0a introduces shorthand parsing for multiple values. However, this causes subcommands to be parsed as flag-values, thus making it impossible to properly call the program.
For example, calls like this ...
groupsmigration1 --scope foobar archive insert group -u simple README.md

... now fail as -u is not a valid argument. This is as --scope <url>... has eaten all arguments until the first -flag, then -u is interpreted as top-level flag which it is not. Usually archive and insert are subcommands, and group as well as -u are required flags of insert.
I have made a quick-fix (notes) which might not be ready for a PR, and I am unsure whether I am fit to fix this properly. Clearly we would want to add a few tests to assure this truly works and to protect from regression.

I would either set the number of values for --scope if you know how many, I'll also look at evaluating subcommands earlier so as to stop parsing --scope if a subcommand is reached. Currently it only stops if it reaches the max, or exact, number of expected values for --scope, or it reaches another argument starting with -. I can roll this up into #111 too

Unfortunately I don't - --scope is setup exactly how it needs to be, limiting it would be arbitrary. This issue stems from the simplification which allows me to also specify tiny multi-flags like -r foo=bar snoo=baz only once, which is appreciated too.
But if I'd have to choose, I would choose correct parsing over this convenience.
On the other hand, a proper implementation seems possible, it's just that values for + multi-value flags must not be subcommand names anymore.
If there really is no way, I would probably just make --scope single-value, which is what it had to be in the old-ages of docopt, which had the same problem. Interestingly, argparse in python has the same issue too, and I explicitly hacked my own copy to get rid of that limitation back in the days.

No worries, it should be fixed with #111 Once it's merged I'll update crates.io

The newest version should solve the issue for you, and it was a valid bug.
To expand on the issue though; the only thing I can't currently do (and realistically it's probably impossible to do) is tell when a [unlimited] multiple value stops and a positional starts. Because positionals have no specifier (unless you count -- which works, but it also marks all following arguments after that as positional as well). The answer is to either rearrange the arguments (so the positional comes before the multiple values), or use --.

Thank you ! I have rolled-back my change locally and could verify it works fine.
Regarding the stated problem with positionals (and grammars like prog <x> <y> -m <v>... ) which are difficult to parse unless in the right order: I think we just have no technology advanced enough just yet.
Well, actually, it is there, just not for this field: regular expressions. The engine behind that is able to act non-greedily, while maximizing matches for respective terms.
I know no implementation using regex though - maybe because for the most part, arg-parsers could get away with relatively trivial (compared to a regex system) and manual implementations.
Now that I am implementing a simple json lexer to allow me to write a filter to get rid of null values in json streams, I am also thinking that this kind of pattern matching would be totally suited to any kind of token-based system. However, a non-text based regular expression engine is also nowhere to be found. Such a thing would certainly be overkill for what I want to do, but I am lazy and would prefer to write a simple substitution regex which works on my json tokens.
Anyway, thanks again for all the fixes - I believe I am totally happy now, with the CLI at least :).


[Darwin] Call ResetSharedConnection and not StartSharedConnection in …

…src/platform/Darwin/DnssdHostNameRegistrar.cpp in order to properly unregister / register interfaces addresses
Issue Being Resolved

Fix #22689
As mentioned in #22689 I have written the code for "resetting" interfaces registration but I have written Start instead of Reset while cleaning up the code...

Change overview

Use the right method call...

Fast-tracking platform-specific change with platform owner review.


Can't enable auto-merge for this pull request

I am using "dependabot/fetch-metadata" v1.2.1 but I am often receiving an error message that it cannot automatically merge PRs:
Enable auto-merge for Dependabot PRs
Run gh pr merge --auto --squash "$PR_URL"
Message: Can't enable auto-merge for this pull request., Locations: [{Line:[1](https://github.com/southpolecarbon/alaska/runs/5287794531#step:3:1) Column:[7](https://github.com/southpolecarbon/alaska/runs/5287794531#step:3:7)2}]
Error: Process completed with exit code 1.

Am I missing something in my workflow to make it work?
name: Dependabot auto-merge
on: pull_request_target

permissions:
  pull-requests: write
  contents: write

jobs:
  dependabot:
    runs-on: ubuntu-latest
    if: ${{ github.actor == 'dependabot[bot]' }}
    steps:
      - name: Dependabot metadata
        id: metadata
        uses<EMAIL_ADDRESS>        with:
          github-token: ${{ secrets.GITHUB_TOKEN }}
      - name: Enable auto-merge for Dependabot PRs
        run: gh pr merge --auto --squash "$PR_URL"
        env:
          PR_URL: ${{ github.event.pull_request.html_url }}
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

@bennycode - your action isn't actually using fetch-metadata (it's ignoring the output) - so it's equivalent to:
name: Dependabot auto-merge
on: pull_request_target

permissions:
  pull-requests: write
  contents: write

jobs:
  dependabot:
    runs-on: ubuntu-latest
    if: ${{ github.actor == 'dependabot[bot]' }}
    steps:
      - name: Enable auto-merge for Dependabot PRs
        run: gh pr merge --auto --squash "$PR_URL"
        env:
          PR_URL: ${{ github.event.pull_request.html_url }}
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

The error you're getting is being thrown by the github cli.  I see you already posted about this https://github.com/cli/cli/discussions/3660 - if you got an answer on how we can update our example workflow to address this issue, please let me know.

@bennycode Did you resolve this issue? I am facing the same. In my repo, I have branch protection enabled with:

Require approvals
Require status checks to pass before merging
Restrict who can push to matching branches

My latest attempt (https://github.com/ampproject/amp-wp/pull/6975) is to wait to run gh pr merge --auto until after all of the checks have passed but before I run gh pr review --approve. Not sure yet if it works.

@bennycode Does using a personal access token solve the issue?

I added a personal access token but I am still seeing this error:

gh pr merge --auto --squash "$PR_URL"
shell: /usr/bin/bash -e {0}
env:
PR_URL: ***
GITHUB_TOKEN: ***
Message: Can't enable auto-merge for this pull request., Locations: [{Line:1 Column:72}]
Error: Process completed with exit code 1.

I got it working in my personal public repository (implementation, proof that it works) but it doesn't work in my org's private repository (that uses the same YML config and has a personal access token configured in GitHub Secrets). 😢

Phew! I just found the issue. I ran into the "Can't enable auto-merge for this pull request" problem because auto-merge wasn't activated in my repo. After activating the "Allow auto-merge" feature in my repository settings it worked:

This made the GitHub Actions bot do the following:

Here is my final config:
name: Dependabot auto-merge

on: [pull_request_target]

permissions:
  pull-requests: write
  contents: write

jobs:
  dependabot:
    runs-on: ubuntu-latest
    if: ${{ github.event.pull_request.user.login == 'dependabot[bot]' }}
    steps:
      - name: Enable auto-merge on PR
        run: gh pr merge --auto --squash "$PR_URL"
        env:
          PR_URL: ${{ github.event.pull_request.html_url }}
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
      - name: Approve PR
        run: gh pr review --approve "$PR_URL"
        env:
          PR_URL: ${{github.event.pull_request.html_url}}
          GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}

It actually works without "dependabot/fetch-metadata". I thought I needed "dependabot/fetch-metadata" because it was listed here. I also didn't knew that the secrets.GITHUB_TOKEN is something very special and not just a secret that you setup yourself in the "Action secrets" section of your repository settings.
Thanks to everyone who has helped!!
@brrygrdn: Can the "Can't enable auto-merge for this pull request" error message be improved in GitHub's cli to give a hint that auto-merge must be enabled on repository-level?


Update tstromberg from 'pull' to 'triage'

Signed-off-by: Thomas Stromberg<EMAIL_ADDRESS>
Summary

This is to allow tstromberg@ to modify issue labels within https://github.com/sigstore/public-good-instance
Release Note

Documentation

Since this needs TSC approval, /cc @bobcallaway @dlorenc @trevrosen


what's the default option for retweets? How to identify original/retweet?

Since I want to also include the retweets in my search, but i forgot to set up 'retweets=True' in the configuration, I'm wondering if i didn't set anything for retweet-related options in the configuration, the tweets that i get include or exclude the retweets?
I found all the 'retweet' column is False in my file. Does that mean the default is that only original tweets are scraped?
Or it's because my search range is 2018-01-01 to 2020-01-01 ( search tweets containing certain keyword), and the retweets are too old so it cannot be returned? (I saw issues posted before saying that only recent retweets can be returned).
I tried 'Native_retweets'=True to scrape only retweets again in that range, however, no tweets are returned.
I also saw  #630, and noticed that there's new style and old style retweets. So i want to know if the tweets that i scraped without setting any retweets options returns actually with old style retweets (which can be filtered by searching for 'RT @'  ), but exclude the new style retweets (which is impossible to get because they are too old)?
In summary, I want to know how to identify retweets/original in my scrapped file.
Thank you in advance!

Native retweets and commented retweets are a whole different story.
The "native retweets"-option can only collect native retweets for the last week or so. The only other option to collect native retweets (as far as i know!) is slow profile-scraping with "profile_full" set on True. However, the "scraping the profile"-function was broken last time I checked.
The search-method only collects commented retweets. They are stored in the "quote_url" column. So with pandas in python you could do this:
df.loc[df['quote_url'].notna(), 'retweet'] = True
This will set the 'retweet'-value on True everywhere you have a quoted twitter status. For further analysis like cross reference you can parse the twitter urls and extract the quoted twitter-usernames and statuses.
df.loc[:,'rt_account'] = df['quote_url'].apply(lambda x: x.split('/')[3]) df.loc[:,'rt_status'] = df['quote_url'].apply(lambda x: x.split('/')[5]).astype('int64')
Hope this helps

Native retweets and commented retweets are a whole different story.
The "native retweets"-option can only collect native retweets for the last week or so. The only other option to collect native retweets (as far as i know!) is slow profile-scraping with "profile_full" set on True. However, the "scraping the profile"-method was broken last time I checked.
The search-method only collects commented retweets. They are stored in the "quote_url" column. So with pandas in python you could do this:
df.loc[df['quote_url'].notna(), 'retweet'] = True
This will set the 'retweet'-value on True everywhere you have a quoted twitter status. For further analysis like cross reference you can parse the twitter urls and extract the quoted twitter-usernames and statuses.
df.loc[:,'rt_account'] = df['quote_url'].apply(lambda x: x.split('/')[3]) df.loc[:,'rt_status'] = df['quote_url'].apply(lambda x: x.split('/')[5]).astype('int64')
Hope this helps

Thanks! it helps a lot


convert net order to host order for double type

[ ] Did you create an Apache Jira ticket?  (not required for trivial changes)
[ ] Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?  (not required for trivial changes)
[ ] Did you squash your changes to a single commit?
[ ] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"

This broke all the lua tests.  My take is that the fix is unnecessary, as the cross-language tests were working before this fix (and they test doubles), and now they are broken.

@jeking3 before the fix. lua version can't send double to java or c# correctly 'cause the order issue. not sure other tests

Our cross language tests send doubles from lua client to java server and back:
java-lua                binary            framed-ip                success
java-lua                binary            buffered-ip              success
On the client lua side here is the code:
https://github.com/apache/thrift/blob/master/test/lua/test_basic_client.lua#L147
On the server java side here is the code:
https://github.com/apache/thrift/blob/master/lib/java/test/org/apache/thrift/server/ServerTestBase.java#L89
The reverse where Java is the client:
https://github.com/apache/thrift/blob/master/lib/java/test/org/apache/thrift/test/TestClient.java#L282
and lua is the server:
https://github.com/apache/thrift/blob/master/test/lua/test_basic_server.lua#L57
HOWEVER we do not seem to be running any tests where lua is the server.  That's a bug, but I still feel the round trip from lua client through java server disproves what you said.
Is there something deficient in these tests we're missing?  We are proving that doubles successfully round-trip with these tests.  Are we testing enough values and enough boundaries to prove or disprove what you are saying?

Closing based on comments.


btcpay valid, but order match stays pending

In this tx, the buyer (bc1qsteve) matches an existing DEX sell order for 73.771 XCP.
https://xchain.io/tx/2725230
Buyer then issues a btcpay (using FreeWallet) and sends BTC to the seller:
(https://xchain.io/tx/4cdfe60f261a506bac5bacb8d3ef6e1a38a115c45b5021203193506c752a89e4)
However the order stays pending and no XCP is delivered!
Update: It seems that even though the btcpay tx is valid, the amount being sent is incorrect: only 0.00671060 BTC is sent, rather than the required 0.01181074 BTC.
Not sure if this is a FreeWallet or Counterparty issue but it's the first time I hear of such an issue with btcpay.

@niftyboss1 thanks for the report! what version of Counterparty freewallet uses ?

will check closer but with v10 events seems OK:

http://v10.0.0-rc.1.preview.xcp.dev.s3-website-us-east-1.amazonaws.com/block/839087

@ouziel-slama right now Freewallet is using v10 (api.counterparty.io)

fwiw hashes from v9 and v10.1.0 are matchine after the concerned block:

and https://www.xcp.dev/block/839091
this means that if there is a problem it is not specific to v10..

ok here is what I can say for now:

there is indeed a bug with a BTCPay which is valid but which does not trigger any credit or update of the order-match. This bug is present in v9 and v10.1.0
this bug is not present in v10.0.0-rc.1! (see screenshot of my previous comment)

This means that this bug probably comes from this PR: https://github.com/CounterpartyXCP/counterparty-core/pull/1633 but I still can't understand how.
In any case I don't know if we want to resolve this bug for v10.1.0 because that would diverge from version v9..

@ouziel-slama I don't follow... is there a consensus break between v9.61.x and v10.0.y?

Thanks for the ongoing investigation!
In the meantime I was able to identify and contact the seller, who kindly agreed to send the BTC back (~$430!) to the buyer.
Still wondering if this could be due to a FreeWallet-specific bug (constructing the btcpay tx with an incorrect amount)?

@ouziel-slama I don't follow... is there a consensus break between v9.61.x and v10.0.y?

yes, there was one with v10.0.0-rc.1 but it's ok with 10.1.0 (was fixed with https://github.com/CounterpartyXCP/counterparty-core/pull/1633).

ah okay I didn't realize it was the same issue!


Provide a means to know the freshness state of a set of paths from build.rs

build.rs helpers such as cc-rs and nasm-rs get executed every time and that may slow down rebuilding quite a lot depending on the amount of assembly code a project has.
We already have a mean to tell cargo about foreign files, would be great to query back their state so if they are fresh isn't needed to build them again.

If I'm understanding this correctly, the request problem is that a cargo detects that a build script needs to be re-run for some reason but the build script fills multiple roles and only part of it needs to be re-evaluated, so how do we do that?
For myself, I feel like providing a way to move away from monolithic build scripts would be a big help.  This would also help with #5720 and #12552

The perfect solution would be to have a mean to have a mean to give cargo additional custom Units, then build.rs can be used just to declare them and cargo then can put them in the graph and process them accordingly.


Crash loop on startup after installing Office plugin

Dbeaver CE on Win10x64, installed with Chocolatey. I've had v5.2.3 installed for about a month, zero issues with it (awesome program!) until I installed Extension Office today. Install went through all it's steps without any apparent problem.
At end when prompted to Restart I said yes. The splash screen shows, then disappears, then shows again, then disappears, then shows... forever. I had to use pskill dbeaver from Sys Internals to stop it (in Task Manager it's a whack-a-beaver game to nab and press delete on the process before it disappears).
I upgraded to v<IP_ADDRESS>812092025 using choco upgrade dbeaver. After this dbeaver launched normally, and asked if I wished to also import and uprade the Office extension. I said yes and checked the box to fetch latest. At end I said no to automatic restart and closed dbeaver manually.
On next launch the crash looping resumed. While looping the .log and dbeaver-debug.log files under %USERPROFILE%\.dbeaver4 are not updated.
I renamed .dbeaver4 to something else, and then .dbeaver-drivers: No difference in either case.

((Note: issue template says to read contributing first, but that document is empty))

It is a known Eclipse bugs:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=192623
https://bugs.eclipse.org/bugs/show_bug.cgi?id=232191
https://bugs.eclipse.org/bugs/show_bug.cgi?id=238800
I saw such issue a couple of times (VERY annoying). But is uneasy to reproduce this.
Looks like this happens only after some extension install in admin (root) mode.

Tried to reproduce this in different run modes, different extensions install, etc. No luck.
If you will see such error again (and it will reproduce every time you start DBeaver) - could you archive whole DBeaver install directory + org.jkiss.dbeaver.product_XXX directory and send me on<EMAIL_ADDRESS>Generally these folders doesn't contain any secured/personal data, only DBeaver binaries.

I reproduced this bug. I sent you an email with a MEGA link to the archives.
Renaming %USERPROFILE%.eclipse\org.jkiss.dbeaver.product_5.3.0_1535670467_win32_win32_x86_64 worked: DBeaver will start, ask me to copy office plugin from previous installation. Cancelling that leads to a working workspace.

Reinstalling the office plugin after removing the folder triggers the issue again, so my archives should provide you useful information.
I also added the "org.jkiss.dbeaver.product_5.2.5_XXX" folder because I suppose that when I remove 5.3.0 folder it copies info from the 5.2.5 folder.
Do you have a workaround to be able to install the office plugin again without breaking? I can live without it, but I must admit it's useful.

In my case removing org.jkiss.dbeaver.product* plus removing org.eclipse.platform* folders from .eclipse resolved the issue. You can even remove whole .eclipse folder - it do not contain anything important except caches and installed extensions.
I think some mess happens in configuration after multiple DBeaver version upgrades which also include base Eclipse platform version upgrade.

I would not recommend removing .eclipse folder as other eclipse-based programs (including eclipse itself) might be using it. Will try removing org.eclipse.platform.

I removed .eclipse (I don't use any other Eclipse products) and reinstalled the office plugin: crash looping. I'll send archive too, but that might have to wait until tomorrow as i expect to be away from the computer for rest of day.

@maphew thanks for checking this. So this seems to be unrelated to .eclipse folder contents.
Then, probably something is wrong with DBeaver installation folder or workspace (less likely).

To validate that workspace is not related you could rename .dbeaver4 folder (or start dbeaver.exe with -data path-to-empty-workspace parameter).
If so then something is definitely wrong with installation folder. If DBeaver is in Program Files/DBeaver then this folder is write protected and generally shouldn't contain anything but the files copied there during installation. But in fact the folder will be modified if you will run DBeaver as administrator (this may happen if you run DBeaver right from the installer for example).
By default folder configuration contains only two sub-folders:

org.eclipse.equinox.simpleconfigurator
org.eclipse.update
an file config.ini

The rest is created during runtime and can be deleted. So, you could try this. Evil should be somewhere over there.

I sent you my installation directory as well, so you should be able to check your hypotesys.
Your reasoning is sound, as I did install dbeaver in program files, I did launch it from the installer and most importantly the issue arose only after i closed it and launched it from a standard launcher!

I had those folders in my Program Files/DBeaver/configuration/ directory:

Removing them did not solve the issue.
Reinstalling DBeaver, paying attention to NOT select the option to launch it at the end of the installation did solve it. So avoiding to launch DBeaver from the installer is a workaround, and you should be able to reproduce it using the installation directory I shared with you.

Thank you for testing this.
I think we should remove "Launch DBeaver" option from installer. Because it launches DBeaver with admin permissions and thus makes a configuration mess.

i also did suffer from this affliction! every time i did install a plugin the restart loop occured. I did reinstall dbeaver but just for my user ( not for everyone on the computer ) and now it's working well.

I've also ran into this problem, which forces the needed to restart Windows.  As gagsa69 says there is a work around of reinstalling dbeaver as 'my user' but this isn't ideal

@serge-rider ... I'm seeing same behavior as @gagsa69 .  I have v6.0x installed under my user profile, and installing Office extension works fine.  I have v6.1x installed for all users and installing Office extension puts me in launch loop that can only be cleared by rebooting.  v6.0x is still launching fine...every time I try to launch v6.1x I get launch loop.
Guess I'll try re-installing latest version under my profile.

The startup loop happened to me too and I solved it by deleting the plugin folder as Rich28 said. Thank you Rich28.

Thanks Rich28, works for me too.

@serge-rider I am experiencing the same issue as well with the plugin for git.
Don't know much of what may be the issue but I noticed the below weird behaviour in .eclipse folder.
After updating DBeaver to the latest version all other org.jkiss.dbeaver.product_* folders since the first version I had installed this plugin was modified.
Dont know if that is helpful just posting it here

Similar environment Windows 10x64, installation from executable file in Program Files. I also did suffer from this affliction! every time i did install a plugin the restart loop occured. I did reinstall dbeaver but just for my user ( not for everyone on the computer ) and now it's working well. I did install some plugins with this type of installation without any problem.

Thanks! after install just for my user in my work laptop (i'm not have admin account on Windows) the restart loop does not happen anymore!

Update from 7.0.3 to 7.0.4. Installation in Program Files (Win 10 x64).
Startup ok.
Update plugins (Office & Devstyles).
After that stuck in startup loop.
I had to reboot my computer 3 times (I don't know why but it worked).

Another data point: I got the startup loop after installing the Office plugin, and resolved the problem by resetting permissions on the folder %USERPROFILE%.eclipse\org.jkiss.dbeaver.product_7.2.4_1535670467_win32_win32_x86_64 - that is, opening the properties for that folder, clicking the Advanced... button on the Security tab, selecting the checkbox "Replace all child object permission entries with inheritable permission entries from this object" and clicking through OK and the warning. Note that "org.jkiss.dbeaver.product_7.2.4_1535670467_win32_win32_x86_64" should be replaced with the name corresponding to the version you have installed.

Same problem here. After installation Git repository browser, a half hour rebooting and it is finished..

Same problem. After each DBeaver upgrade, I install Office plugin. Then DBeaver start to loop on splash screen.
I install DBeaver for "anyone" on Windows 10.
I found this workaround.

upgrade Dbeaver
Start Dbeaver and install Office plugin, without automatic restart. Close Dbeaver.
Start DBeaver "as administrator" and install Office plugin, without automatic restart. Close Dbeaver.
Start DBeaver "as administrator". Close Dbeaver.
Start DBeaver normally

@mk1tools' workaround's still rocking.
I've been having issues with the Darkest Dark theme from DevStyle and the workaround solved the issue.
I'm taking note of it for next time.
Thanks!


[10.x] Refactoring SerializeModels dropping getPropertyValue method

As SerializeModels is a trait, access to the $this object reflects the class that uses the trait, and this will cause possible errors if a method with the same name as getPropertyValue is defined in the class that uses the trait, the job class, but returning a different format than expected to the __serialize.

Going to leave this alone for now.


add bucket to mod.conf

otherwise it crashes on init

Hey there, thanks for contributing, is this no longer an issue?
---- On Mon, 03 Feb 2020 01:13:17 -0600 Thomas Rudin<EMAIL_ADDRESS>wrote ----
Closed https://github.com/TekhnaeRaav/minetest_quicksand/pull/3.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, https://github.com/TekhnaeRaav/minetest_quicksand/pull/3?email_source=notifications&email_token=AHGEIANHUB7JEQZFZ2MHP2TRA67Y3A5CNFSM4JXQDC3KYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOWLPZOMY#event-3000997683, or https://github.com/notifications/unsubscribe-auth/AHGEIAIROPKE7JJWEKTNPQTRA67Y3ANCNFSM4JXQDC3A.

Hey there, thanks for contributing, is this no longer an issue?

Uhm, i assumed you abandoned the project... :man_shrugging:

That's all right, sorry for the late reply. I'm not further developing my mods anymore but I'm totally open to improvements. I'll get to merging this soon if it's any help. I'm glad if anyone can use it.
---- On Tue, 04 Feb 2020 15:29:46 -0600 Thomas Rudin<EMAIL_ADDRESS>wrote ----
Hey there, thanks for contributing, is this no longer an issue?
Uhm, i assumed you abandoned the project... 🤷♂
—
You are receiving this because you commented.
Reply to this email directly, https://github.com/TekhnaeRaav/minetest_quicksand/pull/3?email_source=notifications&email_token=AHGEIAJHCWW3XLEPSUJUG2DRBHM4VA5CNFSM4JXQDC3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKZIFNQ#issuecomment-582124214, or https://github.com/notifications/unsubscribe-auth/AHGEIANRMZVSGBZGEPBILZLRBHM4VANCNFSM4JXQDC3A.

There you go, thanks for the update!
---- On Tue, 04 Feb 2020 16:22:35 -0600 Ryan Haws<EMAIL_ADDRESS>wrote ----
That's all right, sorry for the late reply. I'm not further developing my mods anymore but I'm totally open to improvements. I'll get to merging this soon if it's any help. I'm glad if anyone can use it.
---- On Tue, 04 Feb 2020 15:29:46 -0600 Thomas Rudin<EMAIL_ADDRESS>wrote ----
Hey there, thanks for contributing, is this no longer an issue?
Uhm, i assumed you abandoned the project... 🤷♂
—
You are receiving this because you commented.
Reply to this email directly, https://github.com/TekhnaeRaav/minetest_quicksand/pull/3?email_source=notifications&email_token=AHGEIAJHCWW3XLEPSUJUG2DRBHM4VA5CNFSM4JXQDC3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKZIFNQ#issuecomment-582124214, or https://github.com/notifications/unsubscribe-auth/AHGEIANRMZVSGBZGEPBILZLRBHM4VANCNFSM4JXQDC3A.


Add configuration method chaining

Fixes #37. All configuration methods now return the AnalyticsProvider so the methods can be chained together.
Tests are passing 100% with chained configuration methods.
This change will break any usage related to checking the original configuration values for 'true' or in the case of the regex setter, for 'true' or 'false'. I am highly skeptical anyone would ever do that because it would be quite a waste of effort for exactly zero benefit.

yeah! much cleaner thanks :)


Release 1.0.0 to melpa stable

This is a great package, and seems stable enough (we've been using it for several months without issue :)
All that would be required is to push a v1.0.0 tag.

Thanks for the info! I didn't know how to do that.
Will do it today! :)