Quat.LookAt() description

I'm using Quat.LookAt() it to control the rotation of a piece of text somewhere in the scene, so that it always faces the head position. It seems I need LookAt(text_pos, Input.Head.position - text_pos, Vec3.UnitY) for this (after quite a bit of trial and error to get it right).
What makes it confusing is that apparently the description for the 3-argument version (listed first in the docs) is based on the 2-argument version, so things like "the direction of the two vectors provided to the function" are ambiguous (there's 3 vectors). And also the "Up is always (0,1,0)" statement is incorrect.
Also, the meaning of the from argument could be interpreted as either the "resting direction" or the object position. I now understand it is a position, and not the "resting direction". Apparently, the latter is always Vec3.Forward?

I dunno what I was thinking when I wrote that, I don't believe that was a terribly good explanation! I've revised the docs for Quat.LookAt, and provided a bit of sample, hopefully it's a bit clearer now?

Thanks for the quick update, this indeed seems a lot clearer. It actually didn't occur to me that the second argument is also a position (though it was a direction vector).
One question I still have is whether the returned rotation is guaranteed to be purely around the up direction? A simple test with orienting text seems to show rotation in another axis in extreme cases.

I might just be misunderstanding, but using the term "normal" even in single quotes is slightly tempting to misinterpret in some planar sense. I might suggest something like "regular", "common", or "standard".

It actually didn't occur to me that the second argument is also a position (though it was a direction vector).

Yeah, I was incorrectly using the word direction there, and it was pretttty confusing! If you do have a direction already though, Quat.LookDir is much nicer! :)

One question I still have is whether the returned rotation is guaranteed to be purely around the up direction? A simple test with orienting text seems to show rotation in another axis in extreme cases.

The up direction in the context of the LookAt function is primarily about Z axis roll, rather than specifying the exact direction for the top! If you think about two points, from and at, it's just a line that could represent any number of possible rotations when considering Z axis roll. X and Y rotations are locked in nicely enough, but Z is free without specifying an 'up' direction.

but using the term "normal" even in single quotes is slightly tempting to misinterpret in some planar sense

That's an excellent point, it's quite the overloaded word!

Just made some additional changes to the doc, look any better?


fix kernel arbitrary write zero vulnerability

In HookNtQueryInformationProcess, Titanhide does not validate if ProcessInformation is a user space address. Any process for which TitanHide hides debugging can pass a writable kernel address, e.g. the address to nt!KeServiceDescriptorTable, and cause system BSOD. This is a small fix to the vulnerability.

Is the probing executed in the same order as the normal function? In the past VMProtect was detecting the wrong probe order…

I think it should be the same order:

In original function, it checks weather the whole ProcessInformation buffer resides in user space first, then checks ReturnLength.


fix OverflowError in the BLOCKHASH opcode

What was wrong?
While Trying to passing the remaining legacy tests, I found a bug in the blockhash opcode.  U256 was overflowing while subtracting evm.env.number - block_number.
How was it fixed?
converted U256 to int before subtracting.
Cute Animal Picture

Pic credits: imgur

Codecov Report

Merging #363 (bacc10e) into master (82b1ba3) will increase coverage by 0.24%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #363      +/-   ##
==========================================
+ Coverage   95.92%   96.17%   +0.24%
==========================================
  Files          45       45
  Lines        2430     2430
==========================================
+ Hits         2331     2337       +6
+ Misses         99       93       -6

Flag
Coverage Δ

unittests
96.17% <100.00%> (+0.24%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/ethereum/frontier/vm/instructions/block.py
96.29% <100.00%> (+22.22%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82b1ba3...bacc10e. Read the comment docs.


Fix bug in witness stack getters

In #2646 we introduced a bug in the taproot witness stack getter functions, of which we have three:

tapscript
taproot_control_block
taproot_annex

Each returns Some if a possible bytes slice is found (with no other guarantees).
Use taproot_annex combined with getters from primitives to implement the other two getters. This simplifies the code and fixes the bug.
Add an additional getter to primitives Witness::third_from_last.
Fix: #3598

This is an alternative to #3599 - I didn't see yours @casey until I pushed this up. I think using taproot_annex is kinda clean, but if others don't like it I'll ack yours.

If this one gets considered we should grab the tests from @casey's

I grabbed the unit test from #3599, put it separately so that the patches can be re-orderd to verify the bug, and threw a Co-developed-by tag on it for @casey.

To be 100% explicit this replaces #3599, hope I didn't tread on your toes @casey.

To be 100% explicit this replaces #3599, hope I didn't tread on your toes @casey.

Not at all! I'm happy if this gets fixed, I don't care who does it :)

Hey @apoelstra would it be possible to add a few lines to you merge scripts that check for any label relating to porting and post a message "port this PR now @tcharding"

@tcharding I can certainly write a script that looks for backport labels and posts a comment on everything that shows up ... but I'm not sure how that would be better than you just searching by label?
IOW I don't understand what you're asking for.

Oh, I want some way that as soon as a PR merges that I remember to backport it. My current workflow on merged PRs is just to check the bottom of the thread of discussion to see if anything was said that I need to know then hit the 'e' key to mark done, this means I'll miss that a PR needs backporting. So what I'm asking is a message on the PR, then I"m confident I'll remember without having to periodically check all PRs and check if we backported them.

I was thinking of adding a comment "backported in PR #xyz" also on all the already done ones so future devs can see it.

Ok, nice. I have already queued this to merge, and am about to head to bed, so I probably won't automate it here (unless it fails and I have to rerun it tomorrow). But I don't think that'll be too hard at all.

No rush bro, anytime you get to it is fine.

Port this PR now @tcharding
(not automated)

Backported in #3626


enable merkle skip verification for admins in prod

pin to first live site commit @835903
should have no effect on dev

Sounds like "prod mode on some server other than prod" is totally unsupported, so ignore that one :)
LGTM, your call on the smaller changes.


Vm doesn't run the job

Describe the bug
A clear and concise description of what the bug is.
Github actions to Azure Vm runners. The workflow triggers the job and VM get started but after that the workflow keep waiting to connect to the runners.

Using module 'main' branch as source
Github actions
Azure Vms
Azure location (centralindia)

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.

GHA job should trigger the job and connect to Azure runners and then VMs should stop after job is finished

Additional context
Add any other context about the problem here.
App logs, if someone can provide hint, please

"code":"GeneralError"}
"[EventQueue] Process Message: "}
"[EventQueue] Message failed to process:"}

2023-11-30T15:06:14.395222692Z Hosting environment: Production
2023-11-30T15:06:14.395278592Z Content root path: /app
2023-11-30T15:06:14.395284492Z Now listening on: http://[::]:8081
2023-11-30T15:07:11.863525034Z Updated CA certificates
2023-11-30T15:07:12.676686662Z {"EventId":0,"LogLevel":"Information","Category":"Program","Message":"Entering app startup."}
2023-11-30T15:07:13.785885531Z Hosting environment: Production
2023-11-30T15:07:13.785921932Z Content root path: /app
2023-11-30T15:07:13.785927832Z Now listening on: http://[::]:8081
/home/LogFiles/2023_12_01_lw1ldlwk00012A_default_docker.log  (https://web-app-github-webhook-runner-controller-abc.scm.azurewebsites.net/api/vfs/LogFiles/2023_12_01_lw1ldlwk00012A_default_docker.log)

2023-12-01T17:30:34.773959970Z {"level":50,"time":1701451834773,"pid":1,"hostname":"f370100dab0b","error":{"name":"ServiceBusError","retryable":true,"info":null,"code":"GeneralError"},"errorSource":"receive","entityPath":"sbq-github-webhook-events","fullyQualifiedNamespace":"sb-github-runner-queues-abcsite.servicebus.windows.net","identifier":"sbq-github-webhook-events-b5720704-e4a7-b742-ac13-c9304f15ecca"}
2023-12-01T17:30:34.870151158Z {"level":30,"time":1701451834869,"pid":1,"hostname":"f370100dab0b","error":{"name":"ServiceBusError","retryable":true,"info":null,"code":"GeneralError"},"errorSource":"receive","entityPath":"sbq-github-state","fullyQualifiedNamespace":"sb-github-runner-queues-abcsite.servicebus.windows.net","identifier":"sbq-github-state-635fcb32-3f62-2641-b5bf-944e67778658"}
/home/LogFiles/2023_12_01_lw1ldlwk00012A_docker.log  (https://web-app-github-webhook-runner-controller-abc.scm.azurewebsites.net/api/vfs/LogFiles/2023_12_01_lw1ldlwk00012A_docker.log)
2023-12-01T12:09:58.906Z INFO  -
/home/LogFiles/2023_12_01_lw1ldlwk00012A_msi_docker.log  (https://web-app-github-webhook-runner-controller-abc.scm.azurewebsites.net/api/vfs/LogFiles/2023_12_01_lw1ldlwk00012A_msi_docker.log)

/home/LogFiles/2023_12_02_lw1ldlwk00012A_default_docker.log  (https://web-app-github-webhook-runner-controller-abc.scm.azurewebsites.net/api/vfs/LogFiles/2023_12_02_lw1ldlwk00012A_default_docker.log)

2023-12-02T17:35:34.942833220Z {"level":30,"time":1701538534942,"pid":1,"hostname":"f370100dab0b","error":{"name":"ServiceBusError","retryable":true,"info":null,"code":"GeneralError"},"errorSource":"receive","entityPath":"sbq-github-state","fullyQualifiedNamespace":"sb-github-runner-queues-abcsite.servicebus.windows.net","identifier":"sbq-github-state-635fcb32-3f62-2641-b5bf-944e67778658"}
2023-12-02T17:40:34.878887094Z {"level":50,"time":1701538834878,"pid":1,"hostname":"f370100dab0b","error":{"name":"ServiceBusError","retryable":true,"info":null,"code":"GeneralError"},"errorSource":"receive","entityPath":"sbq-github-webhook-events","fullyQualifiedNamespace":"sb-github-runner-queues-abcsite.servicebus.windows.net","identifier":"sbq-github-webhook-events-b5720704-e4a7-b742-ac13-c9304f15ecca"}
/home/LogFiles/2023_12_02_lw1ldlwk00012A_docker.log  (https://web-app-github-webhook-runner-controller-abc.scm.azurewebsites.net/api/vfs/LogFiles/2023_12_02_lw1ldlwk00012A_docker.log)
2023-12-02T12:09:58.921Z INFO  -
/home/LogFiles/2023_12_02_lw1ldlwk00012A_msi_docker.log  (https://web-app-github-webhook-runner-controller-abc.scm.azurewebsites.net/api/vfs/LogFiles/2023_12_02_lw1ldlwk00012A_msi_docker.log)

/home/LogFiles/2023_12_03_lw1ldlwk00012A_default_docker.log  (https://web-app-github-webhook-runner-controller-abc.scm.azurewebsites.net/api/vfs/LogFiles/2023_12_03_lw1ldlwk00012A_default_docker.log)
2023-12-03T08:13:46.330350994Z {"level":30,"time":1701591226330,"pid":1,"hostname":"f370100dab0b","msg":"[EventQueue] Process Message: "}
2023-12-03T08:13:54.007839339Z {"level":40,"time":1701591234007,"pid":1,"hostname":"f370100dab0b","msg":"[EventQueue] Message failed to process:"}
2023-12-03T08:13:59.549801805Z {"level":40,"time":1701591239549,"pid":1,"hostname":"f370100dab0b","msg":"[EventQueue] Message failed to process:"}
2023-12-03T17:40:35.000116820Z {"level":50,"time":1701625234999,"pid":1,"hostname":"f370100dab0b","error":{"name":"ServiceBusError","retryable":true,"info":null,"code":"GeneralError"},"errorSource":"receive","entityPath":"sbq-github-webhook-events","fullyQualifiedNamespace":"sb-github-runner-queues-abcsite.servicebus.windows.net","identifier":"sbq-github-webhook-events-b5720704-e4a7-b742-ac13-c9304f15ecca"}
2023-12-03T17:45:34.938593831Z {"level":30,"time":1701625534938,"pid":1,"hostname":"f370100dab0b","error":{"name":"ServiceBusError","retryable":true,"info":null,"code":"GeneralError"},"errorSource":"receive","entityPath":"sbq-github-state","fullyQualifiedNamespace":"sb-github-runner-queues-abcsite.servicebus.windows.net","identifier":"sbq-github-state-635fcb32-3f62-2641-b5bf-944e67778658"}
/home/LogFiles/2023_12_03_lw1ldlwk00012A_docker.log  (https://web-app-github-webhook-runner-controller-abc.scm.azurewebsites.net/api/vfs/LogFiles/2023_12_03_lw1ldlwk00012A_docker.log)
2023-12-03T12:09:58.932Z INFO  -
/home/LogFiles/2023_12_03_lw1ldlwk00012A_msi_docker.log  (https://web-app-github-webhook-runner-controller-abc.scm.azurewebsites.net/api/vfs/LogFiles/2023_12_03_lw1ldlwk00012A_msi_docker.log)

/home/LogFiles/2023_12_04_lw1ldlwk00012A_default_docker.log  (https://web-app-github-webhook-runner-controller-abc.scm.azurewebsites.net/api/vfs/LogFiles/2023_12_04_lw1ldlwk00012A_default_docker.log)
2023-12-04T06:30:09.314978670Z {"level":30,"time":1701671409314,"pid":1,"hostname":"f370100dab0b","msg":"Queued Event Received"}
2023-12-04T06:30:09.834035012Z {"level":30,"time":1701671409833,"pid":1,"hostname":"f370100dab0b","msg":"[EventQueue] Process Message: "}
2023-12-04T09:55:03.479791415Z {"level":30,"time":1701683703479,"pid":1,"hostname":"f370100dab0b","msg":"Queued Event Received"}
2023-12-04T09:55:03.860829881Z {"level":30,"time":1701683703860,"pid":1,"hostname":"f370100dab0b","msg":"[EventQueue] Process Message: "}
2023-12-04T10:13:27.063117596Z {"level":40,"time":1701684807062,"pid":1,"hostname":"f370100dab0b","msg":"[EventQueue] Message failed to process:"}
2023-12-04T10:16:19.168906261Z {"level":40,"time":1701684979168,"pid":1,"hostname":"f370100dab0b","msg":"[EventQueue] Message failed to process:"}
/home/LogFiles/2023_12_04_lw1ldlwk00012A_docker.log  (https://web-app-github-webhook-runner-controller-abc.scm.azurewebsites.net/api/vfs/LogFiles/2023_12_04_lw1ldlwk00012A_docker.log)
2023-12-04T12:09:58.911Z INFO  -
/home/LogFiles/2023_12_04_lw1ldlwk00012A_msi_docker.log  (https://web-app-github-webhook-runner-controller-abc.scm.azurewebsites.net/api/vfs/LogFiles/2023_12_04_lw1ldlwk00012A_msi_docker.log)

Ending Log Tail of existing logs ---Starting Live Log Stream ---

Hello, @aditya-enthu !
I see that you have errors Discarding invalid request. Can you tell me what i'm doing wrong ?
Because i check everything and no errors.
Did i miss something ?
Thank you

@AlexanderBurdenko thank you for checking this issue.
What tag version is being used at your side, I am using master and have deployed the terraform configs and it error out with above error. It doesn't start the VMs but no jobs are triggered after that.
Any ideas what I am missing or suggestion on what to check to trace the issue?

@aditya-enthu hello
I'm sorry but i meant that i had the error 403 Discarding invalid request.
I'm using latest branch + latest image of all
Maybe i did something wrong, because i receive all time 403 error with 403 Discarding invalid request

@AlexanderBurdenko Sorry, I have back logged this issue with some other priority task. For me the runner create but no jobs are triggered. I have not tried again anything after that.

@aditya-enthu Okay, understood. Thank you.
If i face this problem and resolve it, i let you know

@AlexanderBurdenko did you manage to run runner and execute the jobs?


renamed Collections interface to Records

The word "collection" no longer exists in the code base. Not even once.
Added a few more useful exports.

@csuwildcat, this is now in. Be sure to not have the word "collection" in spec also!


Added confirmation dialog for submitting assessment

Checklist

[X] I run yarn run webpack:build:main: the project builds without errors.
[X] I run yarn lint: the project builds without code style warnings.
[X]  I tested the changes and all related features on the test server https://artemistest.ase.in.tum.de.

Motivation and Context

This should resolve the issue #355.
Description

I added a window submit, if user didn't assess all UML elements. If he then decides to close it, not assessed elements are highlighted.
Steps for Testing

Log in to ArTEMiS
Navigate to Course Administration
Select Tutor Course Dashboard
Select Exercise Dashboard for any modelling exercise
Select Open Assessment
Click Submit with no or part of the elements assessed to see confirmation dialog

Screenshots

Adding @SiggZ here: What do you think?
One small change request: Can you include a sentence in the popup like "you have not assessed all model elements"


Plan cables onto interfaces that already have a 'connected' cable installed

As ...
Ozzie - Operator
I want ...
This might be a bit harder of a request, but it is something we run into in our operation. So though I might share it here. Maybe someone can come up with a smart way to resolve the issue (or a better workaround...)
We sometimes plan new cables that will replace existing cables. These might have a overlapping termination on one side. It would be nice to be able to connect (status:) 'planned' cables onto interfaces that have a (status:) 'connected' cable currently installed already.
Current workaround:
Right now, we create a temp interface on the device, with almost the same name as the actual interface. Create a planned cable for it, and when it's physically installed, we delete both the old and planned cable, along with the temp interface and then recreate the new (planned) cable as connected on the actual interface (cause you cant change the termination point of the (planned) cable, and we don't want to remove the old interface and rename the temp interface, cause you would lose its history...).
So that ...
You can create a cable, with status 'planned' that is able to connect to interfaces that currently have a 'connected' cable installed.
I know this is done when...
Just like you hit the 'installed' button for a cable that was 'planned', it would be nice to do the same for 'planned' cables on a interface that have a 'connected' cable in them. So you would hit a button called 'replaced' for example, when you update the interface.
Optional - Feature groups this request pertains to.

[ ] Automation
[ ] Circuits
[X] DCIM
[ ] IPAM
[ ] Misc (including Data Sources)
[ ] Organization
[ ] Plugins (and other Extensibility)
[ ] Security (Secrets, etc)
[ ] Image Management
[X] UI/UX
[ ] Documentation
[ ] Other (not directly a platform feature)

Database Changes
No response
External Dependencies
No response

While not ready for production just yet, this is the type of workflow that https://github.com/nautobot/nautobot-plugin-version-control is intended to solve.

Hi @BoudewijnSwen, thanks for this submission as well. It sounds like this is directly related to #4483, where you're proposing instead of deleting the planned cables, you could just update the termination endpoints instead?
Sounds almost like what you're asking for is some kind of cable swap feature?

He @jathanism, well, changing the termination of a cable is one thing. But in that would still require me to create a temporary non-real placeholder interface, to connect the cable to before the cable swap. Which is not ideal. It would be better to be able to connect multiple cables to a single interface, but only allow one of them to be active.
So as an example:
Current situation
So let's say we have 3 devices:
Dev-A
Dev-B
Dev-C
We have a 'connected' cable named X from Dev-A eth0 to Dev-B eth0 (physically and in Nautobot).
The Plan/Change
Now we would like to start planning for a change, where we want the traffic from Dev-A eth0 to go over Dev-C instead of B.
Current way to do this

(Nautobot) We would create a temporary placeholder interface on Dev-A called 'eth0-temp', create a 'planned' cable named Y from Dev-A eth0-temp to Dev-C eth0.
(Physical) We ask our datacenter guy to physically prep the cable (and plug it into Dev-C eth0).
(Physical) We execute the change. So we physically unplug cable X from Dev-A eth0 and connect cable Y to it.
(Nautobot) We delete both cable X and Y. We create a new cable named Y and connect it to Dev-A eth0 and Dev-C eth0. We delete the temporary interface Dev-A eth0-temp.

It would be nice to
Create 'planned' cable Y and connect it to the Dev-A eth0, even though it already has 'connected' cable X already installed on it. And when you execute the change, you press a button to swap the 'planned' cable with the current 'connected' cable.
A bit like how you can press the 'installed' button for a 'planned' cable in the current Nautobot version. It should effectively change the 'planned' cable to 'connected' and the 'connected' cable to 'decommissioning' or something.
Hope this makes it a little more clear.


In SvelteFlow, setting viewport on initialization gets overridden on pan

Describe the Bug
In a SvelteFlow initialization, setting a Writable viewport works to set the initial state of the flow viewport.
However, on panning the flow area, the viewport gets reset to {x: 0, y: 0, zoom: 1}
Expected Behavior:
viewport updated from initial setting, and not reset
Your Example Website or App
No response
Steps to Reproduce the Bug or Issue

create the initial viewport:
let flowViewport = writable({x: 200, y: 200, zoom: 0.5})

set the viewport in
viewport={flowViewport}

on flow load, click on canvas to drag flow.

will see viewport reset to {x: 0, y: 0, zoom: 1}

Expected behavior
viewport updated from initial setting, and not reset
Screenshots or Videos
No response
Platform

OS: Windows
Browser: Chrome
Version: Version 125.0.6422.141 (Official Build) (64-bit)

Additional context
No response

fixed in 0.1.4


CSS

CSS
User story
As a boot camp student
I want the prework notes to be structured on a webpage
So that I can easily find and read the information
Acceptance Criteria
GIVEN a Prework Study Guide website
WHEN I view the study guide
THEN I see a dark blue header and footer, and four boxes with a shadow

This is solved and PR complete


Add a wiki: V Rising Wiki

An anonymous user has submitted a new wiki via our submission form.
Link to origin wiki: https://vrising.fandom.com/
Link to destination (independent) wiki: https://vrisingwiki.net/

It appears the site is experiencing issues with account creation based on this post from Reddit from 4 days ago. It appears the Fandom Wiki is also currently more up-to-date with the latest content release, which the destination wiki does not appear to have yet.


Clicking Table/Figure/Citation references in text leads to 404

Description
There are references to tables, figures or other cited papers within paragraphs. When I click on them, it takes me to a 404 page.
Potetial cause of the issue:
The reference links have an addition "/" at the end before refering to the identifier of the div. For example, the link points towards the following URL:
https://arxiv.org/html/2401.11338v2/#S3.F3
while it should have instead pointed towards the following URL:
https://arxiv.org/html/2401.11338v2#S3.F3
(Optional:) Please add any files, screenshots, or other information here.
No response
(Required) What is this issue most closely related to? Select one.
Choose One
Internal issue ID
faef2bce-0b4e-41aa-b289-c26c03d6eca2
Paper URL
https://arxiv.org/html/2401.11338v2
Browser
Chrome/<IP_ADDRESS>
Device Type
Desktop

Thanks for your report. We have fixed this issue in new conversions and will recreate the HTML for existing papers when the next version of LaTeXML is released. I rebuilt the HTML for this paper with the updated converter, and it now appears to work. Thank you for bringing this to our attention - we rely on feedback reports to help prioritize improvements to the html conversions. I will close this issue report -- if the issue persists, please let me know.


[DRAFT] Multiple question support & cost optimisation of smart contract

I've got this working in an implementation I will raise as a pull request separately on top of the latest contract. This was an amazing help thanks adam!


Fix create api

Please make sure these boxes are checked before submitting your PR, thank you!

[x] Make sure you follow DiDi's contributing guide.
[x] Make sure you are merging your commits to dev branch.
[x] Add some descriptions and refer relative issues for you PR.

Codecov Report

Merging #172 into dev will decrease coverage by 0.24%.
The diff coverage is 94.73%.

@@            Coverage Diff             @@
##              dev     #172      +/-   ##
==========================================
- Coverage   90.97%   90.72%   -0.25%
==========================================
  Files         108      108
  Lines        2348     2361      +13
  Branches      346      346
==========================================
+ Hits         2136     2142       +6
- Misses        109      115       +6
- Partials      103      104       +1

Impacted Files
Coverage Δ

src/components/input/input.vue
100% <ø> (ø)
:arrow_up:

src/common/helpers/instantiate-component.js
100% <100%> (ø)
:arrow_up:

src/common/helpers/create-api-component.js
90.62% <94.11%> (-8.2%)
:arrow_down:

src/components/time-picker/time-picker.vue
76.82% <0%> (+0.66%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 538d85d...218d248. Read the comment docs.


Locale request: he-IL

Which locale do you wish to add?
First check if your locale has already been requested. If so, go and add an emoji to that request to show your support.
For new requests, write the locale identifier in the subject after the colon.
Example: "Locale request: nb-NO".
We use BCP-47 with region subtags, see "IETF language tag".
Maintainer
Sanity will bootstrap and keep the locale updated using AI. We would like human contributors to help maintain the locales by improving them and/or reviewing pull requests from the AI and from other contributors as they come in. Check the box below if you want to be added as a maintainer of this locale. As a maintainer you will be automatically added as reviewer to future PRs that improve it.
If you are not the author of this issue, but would still like to be added as a maintainer, please add a comment to the thread.

[x] I want to be added as maintainer

Thank you for your request @orwashams ! Unfortunately we can not currently support any right-to-left languages. I am adding this locale to the list we want to support in the event we are able to support it!


Function Decorator API

Hi, I have an idea for an alternate API which I think might be cleaner and less error-prone.
Here's a quick mockup:
class Binder:
	def __init__(self, params: list, value) -> None:
		self.params = params
		self.value = value

	def __str__(self):
		self.params.append(self.value)
		return "?"

def bound(fn):
	def wrapper(*args, **kwargs):
		params = []
		res = fn(
			*[Binder(params, arg) for arg in args],
			**{k: Binder(params, v) for k, v in kwargs.items()}
		)
		return res, params
	return wrapper

@bound
def make_me_a_query(foo: str, bar: int):
	return f"SELECT * FROM table WHERE field1 = {foo} AND field2 = {bar} OR field3 < {bar}"

print(make_me_a_query("abc", bar=123))
# ('SELECT * FROM table WHERE field1 = ? AND field2 = ? OR field3 < ?', ['abc', 123, 123])

The idea is to use a function decorator that replaces the args with magic "Binder" class instances, which record their values into the params list when the fstring tries to convert them into a string (which means the order is correct, etc.)
I haven't got my head around sqlbind's more advanced features yet, but I'll have a think about how they could be adapted to this sort of API.
To elaborate on "less error-prone" part, I believe it makes it harder to, for example forget the q/ prefix on a parameter and end up with sql injection.

You are so right about injection. The other thing it could easily pass tests. It bothers me a lot. I think about simple linter to check no parameters go into strings without some sort of binding. May be it could be an extension for bandit. Your idea is also viable approach. I need some time to toy with it and try to apply to existing code.

Closing for now. A general solution requires https://peps.python.org/pep-0675/ to be widely adopted by type checkers. Or writing a typing plugin.


[3.0] KSECURITY-2349 Update jetty to 9.4.54.v20240208 for CVE-2024-22201 fix (#1064)

Update jetty to version 9.4.54.v20240208 to fix CVE-2024-22201
Cherry-pick commit from trunk to 3.0
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Verified that failed test passes locally, proceed to merge


instagram reels seem to be unable to embed on discord

example link https://www.ddinstagram.com/reel/Cu9TMR1gijj/
edit: oops duplicate issue
how do i delete issues on github...

Should be fixed now

Should be fixed now

its just stuck at first frame and won't play. but its some progress, atleast now it gets preview and embeds it properly


Disable the test IRGen/fnptr.swift

The flag is not supported by current clang.

@swift-ci smoke test and merge


Add settings screen

updated styling for user settings:
settings main menu: https://zpl.io/br1NBEO
name: https://zpl.io/2Z0JEzd
email: https://zpl.io/2ykmAyp
bio: https://zpl.io/VYYBvRd
email notifications: https://zpl.io/2GEQ0P9
newsletter: https://zpl.io/V09y40l

update:
added a "Plan" section to the settings main menu ^
clicking the 'current plan' cell can take you to the browser with whatever URL we decide to put there.
also added some explainer text below the plan section to give the user an idea of how many private blocks they've used so far


SignUp page and Layout is very barebones

The UI needs to be improved.

Layout and Sign Up page have been improved in terms of looks.

All set


Java Error opening Windows exe

Getting this error
class java.util.NoSuchElementException: head of empty list
Anytime I try to open the exe to install the patch. Tried with ci_build-124 and ci_build-120. Also reinstalled and updated java before attempting again.

Found the other post about the issue and fix after posting this. My apologies.


Fix Readable.js on certain pages (like HN)

So I suppose it'd be sufficient to document this behavior as a known constraint on some sites, when using text mode with Readable.js?

We should get rid of Readable.js in favour of html2text


So what the hell is gather/take

Inspired by https://github.com/perl6/doc/issues/2135 which says:

Note: Please feel free to reword the title. I'm just frustrated with how little our docs say about such an important feature of perl 6.

This is another case when an amazing feature is not explained enough.
Docs: https://docs.perl6.org/syntax/gather take
It says:

gather/take can generate values lazily, depending on context. If you want to force lazy evaluation use the lazy subroutine or method. Binding to a scalar or sigilless container will also force laziness.

(let's ignore questionable “force laziness” stuff for now)
In some way it is right, but to me this is not enough. Surely it can generate values lazily, but how? What does it mean exactly? What should I write in order to get lazy behavior?
See my mumblings here: http://colabti.org/irclogger/irclogger_log/perl6?date=2018-10-17#l34
If I get it right (please correct me if I'm wrong), then if you have code like this:
say ‘before’;
take 42;
say ‘after’;
…

Then say ‘after’ will not be executed unless you pull another value from the Seq. So your code just magically stops executing before returning from take. This means that you can write any kind of code, like infinite recursion and the like, and it won't run more than you ask it to. That's freaking awesome.

not only that what i like about that feature you can have normal loop but in it you not take every iteration a value or sometimes two and so press irregular ebehaviour into seemingly regular frame

So your code just magically stops executing before returning from take

I believe the technical term is "continuation"

Moreover, you are not limited to the type of the value of the original list when forming the results,
consider.
my @a = gather for %results {
   if <some condion> {
      take <do somehing with $_ that is not the same type>
   }
}

I'll look through some of my code and see if I can give a more concrete example.

But that would be the same as:
%results.values.map: { <complex function> if <some condition>}


add --msbot to import version

fixes #362

Pull Request Test Coverage Report for Build 1028

0 of 6 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.1%) to 69.342%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

packages/LUIS/bin/luis.js
0
6
0.0%

Totals

Change from base Build 1023:
-0.1%

Covered Lines:
3511

Relevant Lines:
4843

💛  - Coveralls


Broken https://moveit.ai?

The link in the "about" section of this repo has a link to "https://moveit.ai/"; however, I get a consistent 404 from Github Pages.

Thank you for filing this issue - it was a bit more complicated getting the https certificate moved around, but it is complete now.


Fix generated default/index.js file

After running donejs add generator in a new folder, running npm test did not work; the tests would just timeout.
The cause of this issue was a callback being passed to prompt instead of using the promise that it returns.
With this change, the tests successfully complete in a new project.
Tests before:

Tests after:

Coverage remained the same at 97.26% when pulling d6df14aff24a34f22d3fe9af5febc2891a17f4f7 on fix-generated-test-code into 4ff022e645893cc90953d6e3c59362086d42bddd on master.

This is the root issue: https://github.com/donejs/generator-donejs/blob/0c9d6e0ccf73b6f816d203d83665253676e97647/generator/index.js#L106-L107
This will always install latest. We should use semver ranges.  I wonder where we can put those?

I’m guessing we can tack on the version, something like<EMAIL_ADDRESS>

I meant where do we put this information, I don't want to put it directly in the file. I think for now I'll create a module called "packages" that looks like:
module.exports = {
  devDependencies: {
    "yeoman-foo": "^1.0.0"
    ...
  }
};

Closing in favor of the issue: https://github.com/donejs/generator-donejs/issues/130


fix(docker): Handle push correct

:tada: This PR is included in version 1.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


vimPlugins.vim-easyclip: init at 2019-02-18

Motivation for this change
Things done

[ ]  Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)

Built on platform(s)

[x]  NixOS
[ ]   macOS
[ ]   other Linux distributions

[ ]  Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)

[ ]  Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"

[ ]  Tested execution of all binary files (usually in ./result/bin/)

[ ]  Determined the impact on package closure size (by running nix path-info -S before and after)

[ ]  Ensured that relevant documentation is up to date

[ ]  Fits CONTRIBUTING.md.

@Aptrug Do you need help with anything?

It seems to me that I didn't follow this guide https://nixos.wiki/wiki/Vim#Adding_new_plugins, so I closed this PR. I'll open a new one soon.


Create a UI to parse the report

Reffy could potentially run fully within a browser longer term (see #30). In the meantime, we should try to make the report per specification more readable. There is not much we can do to improve the Markdown report generated by the study tool, but we can a bit of JS magic to the HTML version of that report e.g. to:

collapse specifications by default and highlight main errors (see PR #53 for a first stab)
provide filtering and sorting options

First version of the UI exists. I don't expect that to be the final version, but let's create more specific issues as needed.


crosswalk-16: [Android] Close some leaking resources.

Close a few InputStream and Cursor instances that were currently
dangling.
(cherry picked from commit 080e5ae90c43b3a221e4b506fc090c85621e59a4)

ping @lincsoon @XiaosongWei

LGTM


gfni: add ARM, PPC and WASM implementations of gf2p8mul intrinsics

Improvements to all *gf2p8mul* intrinsics:-

Add ARM, PPC and WASM implementations.
ARM implementations now use carry-less multiplications
and vqtbl1q_u8 or vtbl2_u8 based LUT reduction.
Ensure fallback to 128-bit GFNI if GFNI-SSE is available.
Improve most fallbacks.
Add new fallbacks.

For the moment I have only improved the *gf2p8mul* intrinsics.
I still have to clean up my *gf2p8affine* intrinsics.
I have only implemented *gf2p8mul* based on carry-less multiplication for ARM.
I shall look at other architectures later.


release 2024.07.0

What is your issue?
We have accumulated a good number of bug fixes on main. Can someone volunteer to manage the next release sometime soon please?
It would be good to get #9136 in.

I'm guessing that means we officially expose DataTree in a later release?

Maybe @scottyhq and @JessicaS11 wanna do this at SciPy?

Yes don"t wait for DataTree on this one (hopefully we'll just release again in a few days)

Is https://github.com/pydata/xarray/pull/9136#issuecomment-2231553450 a release blocker?
cc @kmuehlbauer

is there anything else that would block the release? Otherwise I'll do that today.

The release is on PyPI, but reopening so we can track the conda-forge package


MM-27228  Cypress/E2E: Automate backlogs - BOT Accounts - Part 05

Summary
automated tests MM-T1851 through MM-T1860

Ticket Link
https://mattermost.atlassian.net/browse/MM-27228

Related Pull Requests

Has server changes (please link here)
Has redux changes (please link here)
Has mobile changes (please link here)

Screenshots

@saturninoabril superb review. thanks. I'll address the comments and see why it's failing


HS algo verification should use constant time comparison

https://github.com/kjur/jsjws/blob/master/jws-3.0.js#L505
to prevent timing attacks.

@kjur looks like this is still present in jsrsasign?
https://github.com/kjur/jsrsasign/blob/master/src/jws-3.3.js#L484

Hi, how can I fix this?

Hi @kjur - what about something like this?
// from https://github.com/goinstant/buffer-equal-constant-time/blob/master/index.js
var const_time_equal = function (s1, s2)
{
    "use strict";
    if (s1.length !== s2.length)
    {
        return false;
    }
    var i, c = 0;
    for (i = 0; i < s1.length; i += 1)
    {
        /*jslint bitwise: true */
        c |= s1.charCodeAt(i) ^ s2.charCodeAt(i); // XOR
        /*jslint bitwise: false */
    }
    return c === 0;
};

Closed in favour of https://github.com/kjur/jsrsasign/issues/309


When will the vllm PR be merged to the main branch?

Thank you for your impressive work on this project. I'm eager to try this model, but I've noticed that the vllm deployment pull request has conflicts with the main branch, and building vllm from scratch is challenging for my development environment.
Is there an active effort to resolve these conflicts and merge the PR into the main branch? If possible, could you provide an estimated timeline for this merge? I greatly appreciate your work and look forward to using this implementation. Thank you for your time.

I'm eager like you to wait for trying this model ! But this pr has been pending for a period time @zwd003 could you give us a favor?

Thank you for your impressive work on this project. I'm eager to try this model, but I've noticed that the vllm deployment pull request has conflicts with the main branch, and building vllm from scratch is challenging for my development environment.感谢您在这个项目上所做的令人印象深刻的工作。我很想尝试这个模型，但我注意到 vllm 部署拉取请求与主分支有冲突，并且从头开始构建 vllm 对于我的开发环境来说是一个挑战。
Is there an active effort to resolve these conflicts and merge the PR into the main branch? If possible, could you provide an estimated timeline for this merge? I greatly appreciate your work and look forward to using this implementation. Thank you for your time.是否正在积极努力解决这些冲突并将 PR 合并到主分支中？如果可能的话，您能否提供此次合并的预计时间表？我非常感谢您的工作并期待使用此实现。感谢您的时间。

+1

same here.

It's merged, but doesn't work

vllm v0.5.1 support deepseek v2

Are you using the 236b model or the lite one?


Named Johnny Silverhand's Holographic Arm

edited item "110294555922" and gave it a name

Hi, thanks for the PR, however:

Your JSON is not valid, you are missing a , at the end of your change
The ID does not match the item name.
The Names.json is autogenerated.

Hi, thanks for the PR, however:

Your JSON is not valid, you are missing a , at the end of your change
The ID does not match the item name.
The Names.json is autogenerated.


[DNM][RFC]log: make name param explicit

Rather than having some implied name for the logging name, explicitly
pass it in the macros LOG_MODULE_REGISTER & LOG_MODULE_DECLARE.
Signed-off-by: Kumar Gala<EMAIL_ADDRESS>

Before we starting using the logging subsystem everywhere, wanted to see about this change (needs some updates to the docs if the change is agreeable).

Codecov Report

Merging #9368 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9368   +/-   ##
=======================================
  Coverage   52.51%   52.51%
=======================================
  Files         201      201
  Lines       25352    25352
  Branches     5299     5299
=======================================
  Hits        13313    13313
  Misses       9944     9944
  Partials     2095     2095

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8b5890...92aa679. Read the comment docs.

cc: @pizi-nordic @jarz-nordic
It's my last day before 3 weeks vacation. Piotr or Jakub can follow in my stead.

I updated the docs, figure we can address the addition of some new API to fetch the name as a separate PR.  Wanted to have this go in before all the other changes to convert a bunch of subsystems to use logging.


[FEATURE] DX: EmbeddingStoreContentRetriever: easy way to set maximum number of tokens to retreive

Aside from maxResults setting, EmbeddingStoreContentRetriever should have a setting to define how many tokens to retreive (e.g.  maxTokens). In this case, Tokenizer should also be provided by the user.
Consider adding this setting on DefaultRetrievalAugmentor level.

duplicate of https://github.com/langchain4j/langchain4j/issues/1953


Invalid Dockerrun.aws.json version

Getting
INFO  [26070] - [Application update/AppDeployStage0/AppDeployPreHook/03build.sh] : Activity execution failed, because: Invalid Dockerrun.aws.json version, abort deployment (ElasticBeanstalk::ExternalInvocationError)
caused by: Invalid Dockerrun.aws.json version, abort deployment (Executor::NonZeroExitStatus)

In the eb-activity.log. Enclosing version number in double-quotes does not help. Could it have something to do with my environment? I left mostly everything default.

Seems like you answered you own question at https://forums.aws.amazon.com/thread.jspa?threadID=221802. We are currently working on adding support for the multicontainer platform in eu-central-1.


Add sms to sms failover snippet

Description
Adds a code snippet that failsover from sms to sms, but on a second phone number.

@tbedford What are the limitations of this? Does it rely on Delivery Receipts being accurate?


Request: Start using version numbers for updates on Curse

This is a minor issue, but just seeing a list of "IdTip.zip" on curseforge is confusing. I understand keeping it simple up to now since you'd be at version eleventy-billion already, but now that things are stable it would be helpful to see the exact versions in the file listings going forward.
Thanks again for taking over IdTip btw.

They will be now that the release automation spits them out with the version. Makes it easier for me to download and upload anyways 😅


in-correct output for nano-second precision

source code:
import arrow

dt = arrow.get("2016-12-31 12:34:56.123456")
print(dt)
print(dt.format("YYYY-MM-DD HH:mm:ss.SSSSSSSSSSSS"))

output:
2016-12-31T12:34:56.123456+00:00
2016-12-31 12:34:56.123456123456

If user specifies the output precision more than 6 'S', the output string should be zero's, or an Exception could be raised

Confirmed. It's likely linked to #341

Duplicate of #324


Citizens Problem.

Hi ! Im having problems with Citizens!
Myconfig:
allow-command-questing: false
allow-command-quests-with-npcs: true
But it seems like I cant right click the NPC's ..
Any solutions?
No console Error .. Its just I cant rightclick the npc .. it says " Sorry you cant use that here "
(Im using sub character to test my quests .. It doesnt work to them, they got proper quests permissions) am I missing something, player with * of all commands can use ur quest.. but if I removed * ..  cant use quests
also sometimes when I edit my config and /questsadmin reload
The config doesnt save
Im using Spigot 1.7.10
My perms for the meantime
- quests.quest
- quests.quit
- quests.take
- quests.quests
- hsp.command.spawn
- essentials.spawn
- fe.member
- essentials.afk
- essentials.build
- essentials.delhome
- essentials.home
- essentials.ignore
- essentials.kit
- essentials.kits
- essentials.mail
- essentials.mail.send
- essentials.compass
- essentials.motd
- essentials.msg
- essentials.pay
- essentials.realname
- essentials.reply
- essentials.rules
- essentials.suicide
- essentials.sethome
- essentials.signs.break.disposal
- essentials.signs.create.disposal
- essentials.signs.use.balance
- essentials.signs.use.buy
- essentials.signs.use.disposal
- essentials.signs.use.heal
- essentials.signs.use.free
- essentials.signs.use.kit
- essentials.signs.use.repair
- essentials.signs.use.sell
- essentials.signs.use.warp
- essentials.protect.exemptbreak
- essentials.protect.exemptusage
- essentials.protect.exemptplacement
- essentials.tpa
- essentials.tpaccept
- essentials.tpahere
- essentials.whisper
- essentials.list
- essentials.msg
- essentials.near
- modifyworld.*

Your having an issue with worldguard it sounds.
Or some other region protection plugin
If the npc is in a protected area of worldguard you will need to set flags on the protection region to allow USE and allow INTERACT flags.
This will allow users to use chests and other things, but not break.
If your using another plugin I'm unsure of how to allow usage.

USE is allowed
I dont see anything wrong in the worldguard and region .. everything seems to be fine ..
idk what causing this ..

"Sorry, but you can't _____ here" is a WorldGuard response. Make sure to check your global region as well. For further support, contact the author(s) of WorldGuard or create a support ticket on their bug tracker: http://youtrack.sk89q.com/issues/WORLDGUARD
Tl;dr: Closing as this is not an issue with Quests.

Hey! I found out something
When I use Build deny .. Players can interact with the npc that's why the "Sorry, but you can't _____ here" is not working ..
but
when I use Build allow .. they can interact ..
What seems to be the problem?
Looks like the citizens only fired when you allowed build ..
region is global ..

Do you also have the Use flag set to allow?
I have a region where use and and interact are set to allow and they can use npcs just fine.
By what you said its an issue with worldguard behaving correctly.
So its not really a 'problem' its just a settings issue.


New docker images for OpenColorIO and OpenVDB

These 2 images should be able to provide for OpenColorIO ( aswfstaging/aswf-ocio-build:2019 ) and OpenVDB ( aswfstaging/aswf-openvdb-build ).
I've basically merged together @danrbailey and @michdolan work into something I hope will work!
Signed-off-by: Aloys Baillet<EMAIL_ADDRESS>

@tykeal : the Azure failure is caused by the need to provide a valid docker hub connection service... I've got it setup on my own azure project... would be great to get this working on ASWF's azure project as well!

Looks like we have some docker images published now, so I'll give this a go today, thanks!

Looks like we have some docker images published now, so I'll give this a go today, thanks!

Think we're very close! Everything is working if I disable building against glfw. However, our CMake can't seem to track down the cmake module for glfw3 which might be an issue with how this is installed or an issue with picking this up through pkg-config. I'm investigating...

Thanks for the update @michdolan that's great news!
@danrbailey I've updated glfw to 3.0.4 and the build will be going on for an hour or so... When this is done you can try again: https://dev.azure.com/aloysbaillet/ASWF/_build/results?buildId=140&view=results

Approving this PR, the GLFW issues are now able to be addressed on our end. Otherwise, everything seems good, thanks a lot for all your work on this @aloysbaillet! :)

Great, first merge then! Thanks @danrbailey and @michdolan for the great and timely feedback!
I would still need @tykeal to add a connection service to dockerhub so merges to master on this repo actually push to the real aswf dockerhub org... I'll do this in a separate PR though.
The good news is is that I also have OpenEXR building and testing on this docker container!


Failure to process a subscription should not unwind the whole stack

Processing a subscription might fail due to not enough buffers or due to an IO error. In both cases, we have a good way to recover actually, which is that the subscription is dropped (and the peer would anyway re-initiate the subscription after a while).
The problem is, current a failure to process a subscription unwinds the whole call-stack and the Matter processing ultimately panics with an error.
This if fix simply catches the errors from processing a concrete subscription, logs it, and then forgets the subscription.

@kedars Note that the PR CI fails because https://github.com/project-chip/rs-matter/pull/215 is not merged yet.


Android 12 Support

Hello, it seems that the library doesn't work properly on Android 12, it fails to find the DFU target and starts the update process, but it is working well on older Android versions. I tried adding new Bluetooth permissions for Android 12, but still the same.

Looks like the linker settings causes the issue, when I set to Don't Link, it works again.


Setting default headers

Close #212

ping @seanmonstar

Woops, sorry, been really busy.
This looks stellar! Someday perhaps I'll fix up the tests to not need to match the headers in exact order, but oh well.


selectFile method not replacing placeholders with values

Regressing on multi-line queries, I think. Not entirely sure the cause, investigating. Need a more robust unit on this.


Ender Chests Vulnerable

Still allowed to access and transport items directly from creative into ender chests even with the containers permission set to false or not given at all.

Thank you for the report! Fixed in 1.0.1.


SecurityCenter.securityContacts.list returns old payload

Package Name: @azure/arm-security
Package Version: 5.0.0
Operating system: MacOS
[X] nodejs

version: v16.15.0

[ ] browser

name/version:

[X] typescript

version: v10.7.0

Is the bug related to documentation in

[ ] README.md
[ ] source code documentation
[ ] SDK API docs on https://docs.microsoft.com

Describe the bug
The result of the SecurityCenter.securityContacts.list is missing the fields alertNotifications. This is present on the 2020-01-01-preview API, however the @azure/arm-security seems to use the 2017 API version for this api action.
To Reproduce
Steps to reproduce the behavior:

Run:

az account get-access-token --query "{subscription:subscription,accessToken:accessToken}" --out tsv | xargs -L1 bash -c 'curl -X GET -H "Authorization: Bearer $1" -H "Content-Type: application/json" https://management.azure.com/subscriptions/$0/providers/Microsoft.Security/securityContacts?api-version=2020-01-01-preview' | jq '.|.[] | select(.name=="default")'

Observe result
Run the following snippet of JS/TS:

const subscriptionId = '...';

import { SecurityCenter } from '@azure/arm-security';
const { DefaultAzureCredential } = require('@azure/identity');

(async () => {
  const sc = new SecurityCenter(new DefaultAzureCredential(), subscriptionId);
  const result = await sc.securityContacts.list();
  for await (let page of result.byPage()) {
    for (const resource of page) {
      console.log(page);
    }
  }
})();

Observe the result, and the discrepancy between the two
Expected behavior
Either the latest API response, or a way to configure the client to allow you to get the latest API result (for instance like this)

Screenshots

after dig into it. there're multiple reasons for this issue.

As the SDK is generated from api version 2017-08-01-preview which is configured from  https://github.com/Azure/azure-rest-api-specs/tree/main/specification/security/resource-manager#tag-package-composite-v3

And some of the properties we see when using Azure CLI of api version 2020-01-01-preview has not been added in api version 2017-08-01-preview yet. for example notificationsByRole
Both in api version 2017-08-01-preview and api version 2020-01-01-preview, there's a x-ms-client-flatten https://github.com/Azure/azure-rest-api-specs/blob/main/specification/security/resource-manager/Microsoft.Security/preview/2017-08-01-preview/securityContacts.json#L267 set here, which tells the client side to put all the properties under properties to be the direct property of top level, for example alertNotifications should be a property of properties but now it's a property of root directly. that's why we don't see properties in the SDK response.
There's a response structure change compared between api version 2017-08-01-preview and 2020-01-01-preview which cause even if we generate the SDK from 2020-01-01-preview now, we still can't get the result of securityContacts.list() to resolve this issue.
here's the raw response structure of 2017-08-01-preview version

{
  "value": [
    {
      "etag": "",
      "id": "",
      "location": "West Europe",
      "name": "default",
      "properties": {
       ....
      },
      "type": "Microsoft.Security/securityContacts"
    }
  ]
}

here's the raw response structure of 2020-01-01-preview version
[
  {
    "etag": "",
    "id": "",
    "location": "West Europe",
    "name": "default",
    "properties": {
       .....
    },
    "type": "Microsoft.Security/securityContacts"
  }
]

which contradict with their swagger definition of SecurityContactList response type here https://github.com/Azure/azure-rest-api-specs/blob/main/specification/security/resource-manager/Microsoft.Security/preview/2020-01-01-preview/securityContacts.json#L200-L217
we will need to ask service team to fix that in service returned response.

@josefree  Hi Could you help take a look at this issue? their swagger readme includes some older api versions even if they have newer api version? Also, they have a swagger correctness issue in their newer api version as I mentioned above. Thanks

@xboxeer Can you help take a look at this issue ? Thanks

Hi @edmundcong ,
This issue is fixed in the new SDK<EMAIL_ADDRESS>


How to redirect to a given middleware?

Hi,
@weierophinney this is the issue I was talking about on Twitter, but maybe it is better here.
I want to create a middleware that is used with Elastic Beanstalk SQS worker. Elastic Beanstalk is an AWS service that allows to deploy applications easily, and they also have an environment type called "worker".
This type of environment fetches messages from a SQS queue, and then does a POST request to a URL of our choice in our application, with the message info.
What I'd like to do is creating a small abstraction layer around this, so that I can push messages in my application:
$queue->push('my-job-name', ['user_id' => 2, 'other-info' => 'bar']);

Once read by the worker, it can be configured to do a POST to "/worker" URL for instance.
My idea is that I'd like to use a mapping between the name of the job, to a given middleware. Therefore, I'd like to be able to create a "WorkerMiddleware" (that will be configured on the path I've configured Elastic Beanstalk), and that this middleware would read the "job name" (in my example "my-job-name"), and match it to a middleware, and then automatically dispatch to this middleware.
I have thought of two solutions:
Inject the container
The first idea is to inject the container inside this middleware, so I can retrieve the dependant middleware and call it (or add it to the pipe ?).
Pre-routing
The other idea I had is to add a pre-routing middleware that will dynamically change the request path, so that when the "routes" are fetched, it will actually dispatch to the proper middleware.
Is there any other solution for this problem? (yes, I'm basically looking for something similar to the ->forward() controller helper we had in ZF1 :o)

The first is definitely the easiest; essentially, you're just creating an alternate routing middleware that uses the POST data for routing instead of using path-based routing. As far as I'm concerned, that's likely the simplest and best solution.
The second option is also viable, and quite reasonable to do as pre-routing middleware.
Honestly, take your pick; they're both reasonable solutions.

Perfect, I'll go with the first one then.


Error Property 'id' is missing

I am trying to use it the following way but getting the error
import * as autocolors from 'chartjs-plugin-autocolors';
Chart.register(DoughnutController, ArcElement, autocolors)
      const chart = new Chart(this.chartWrapper.nativeElement, {
        type: 'doughnut',
        data: {
          labels: data.map(row => row.year),
          datasets: [{
            label: 'Acquisation per year',
            data: data.map(row => row.count),
          }]
        },
        plugins: [autocolors], // throws an error
      })

But the plugin field throws an error
Property 'id' is missing in type 'typeof import("/path/to/project/node_modules/chartjs-plugin-autocolors/types/index.esm")' but required in type 'Plugin<"doughnut", AnyObject>'.

I can confirm that the issue still persists as of April 12, 2024. However, on<EMAIL_ADDRESS>I was able to overcome the problem as follows:
import * as autocolors from 'chartjs-plugin-autocolors';

const autocoloredPlugin = {
  ...autocolors,
  id: 'autocolors', // Adding the required 'id' property
};

// ...

const chart = new Chart(ctx, {
  // ...
  plugins: [
    autocoloredPlugin
  ]
});

Although this solution is most likely a bad practice, it saves the day. Still, this issue should be resolved in the upstream.

This should be fixed on v0.3.0 (exporting the pluigin as default)


COPS-6533 Fix issue in which PUT /v2/groups ignored the enforceRole setting

Also, remove the default values for Group and RootGroup production model constructors so that this type of issue does not reoccur.
JIRA Issues: MARATHON-8770

This PR builds on top of https://github.com/mesosphere/marathon/pull/7224

benchmarks won't compile

Sigh, I spent way too much time trying to get Builders working in benchmark repo. SBT supports dependencies for benchmark main to depend on marathon test, but IntelliJ does not support it and gives all kinds of false negatives: https://youtrack.jetbrains.com/issue/SCL-8396
I tried extracting test-utils and having marathon test depend on test-utils, and test-utils depend on marathon main, but this resulted in a cyclic dependency error :/
So, I just went with symlinking in the end. Kind of a hack, but it works. Could copy-and-paste also :/


Make it easier for new users to find out what is broken

From @bboreham on October 10, 2016 9:52
E.g. if the underlying problem is a firewall or duplicate uuids, they have to go through some gyrations to find out.
Maybe we can fire an event which is picked up at the front end?
Maybe kubeadm should run a command which is a combination of kubectl apply weave-kube and listening for events?
@lukemarsden @errordeveloper any ideas?
#5 is somewhat related.
Copied from original issue: weaveworks/weave-kube#34

We had some discussion of how to implement this:

firing a Kubernetes event considered useful
Weave Cloud could display these events; even better if this is through another mechanism independent of Kubernetes, since not all users have Kubernetes
bundling the Kubernetes API code into weaver is undesirable (it adds ~34MB); we should put the code that actually sends the event to k8s into a separate binary
weaver could maintain a FIFO queue of events; some separate binar(ies) could poll that queue and ship to Weave Cloud and/or Kubernetes
maintaining the queue in-memory is not such a great design for events that lead to a crash
weave-npc also has events that should be surfaced to the user, although it already has the k8s API compiled in

@bboreham 👍 👍


Trace all HTTP codes other than 200 as errors

This allows to raise logging level but still see 500, 404 errors etc

Looks good but you forgot to check format!


[dv,testlist] Enable irq_timer, allow WFI in Umode

This commit sets two different riscv-dv knob to make sure we hit
some holes in our coverpoints.
Activating enable_timer_irq for everytime we enable other
interrupts makes sure that we respond to it just like we respond
to other interrupts.
Setting tw=0 makes it so that we would allow WFI in user mode. We
were already randomizing it but for some certain tests, we actually
want to be in a sleep state, which wouldn't happen if tw=1 in user
mode.
Signed-off-by: Canberk Topal<EMAIL_ADDRESS>

Have any of you had a chance to look at this one? It's really just a couple of riscv-dv knobs getting enabled and improves our coverage of cp_interrupt_taken


Create a column key

Overview
We need to create a key that we can use to quickly view the relationship between the variables in the:

Phone recruitment script
FM Pro
Our R code
The MDAC call logs.

Basically, for each question in the phone screening, what is the corresponding name of the variable (or variables) in each of the datasets we interact with (listed above).
I was envisioning an Excel file where each row is a phone screening item and there is a column for each dataset. However, feel free to play around with this if you think there is a better way.
If you have any questions, please just post them in the comments below. That way, we won't have to search for our discussions about this task.

Hi Dr. Cannell, I do not have access to follow-up interview, would you mind sharing that?

Hi Dr. Cannell, I was wondering if you could kindly clarify something for me regarding the "phone screening" you mentioned. I noticed that it is linked to the follow-up interview instruments, however, as all questions are asked through the phone, I couldn't find any related questions in the MDAC call logs file. Or would you want me to merge the data by their id? Thank you very much.

Hi @mbcann01,
Thank you for fixing it. However, the follow-up interviews are conducted at home, and the phone recruitment script only includes questions asked over the phone, there are no similar questions between them. Therefore, I'm wondering if you would like me to merge the datasets by ID or if you only need the variable names?

Hi @mbcann01,
Thank you, that makes a lot of sense!

Hi @mbcann01
The path for the column key is [detect_clean_mdac_call_logs]/[codebook]/phone screening variables.xlsx.
And regard to the code, I didn't upload it. Which file do you want me to put it to?
Thank you,
Yixiao


isAsyncSupported returns true but async code fails

I haven't seen any examples of using AsyncContext with Spark.  I decided to put together a simple route to test it but it isn't working despite request.raw().isAsyncSupported() returning true.
Example:
        get("/test", (request, response) -> {
            HttpServletRequest httpServletRequest = request.raw();
            boolean isAsyncSupported = httpServletRequest.isAsyncSupported();
            System.out.println("Is async supported? " + (isAsyncSupported ? "Yes" : "No"));
            AsyncContext asyncContext = httpServletRequest.startAsync();

            asyncContext.start(() -> {
                response.type("text/plain");
                response.body("Async worked!");
                asyncContext.complete();
            });

            return "";
        });

When hitting this test URL I see this in the console:
Is async supported? Yes
[qtp902091968-26] WARN org.eclipse.jetty.util.thread.QueuedThreadPool -
java.lang.NullPointerException
    at org.eclipse.jetty.server.AsyncContextState$2.run(AsyncContextState.java:168)
    at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:654)
    at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:572)
    at java.lang.Thread.run(Thread.java:745)
[qtp902091968-26] WARN org.eclipse.jetty.util.thread.QueuedThreadPool - Unexpected thread death: org.eclipse.jetty.util.thread.QueuedThreadPool$3@252330a9 in qtp902091968{STARTED,8<=8<=200,i=2,q=0}

And my curl client hangs.  If I replace return ""; with return "SOME STRING";, hit the URL, see the exceptions in the console, and then kill the application curl will show me the "SOME STRING" text because the connection closes but reports this in my Terminal:
curl: (18) transfer closed with outstanding read data remaining

Is there a way to use asyncContext with Spark?  If so, can you link to an example?  If not, should I submit a PR for making isAsyncSupported return false?  I haven't gotten that deep in the code so I don't know if that's easy but I'd be willing to try to make it consistent.

Vote up for async connection handling in Spark :+1:

Me too :+1:

I'd love to help to get this going but the project feels a bit lifeless.  Is it dying or are the developers just busy working on other parts?  If it's the latter then maybe I'll revisit this and see if I can help.

Definitely not dying @timmattison, but we currently only have one maintainer (Per) who is working full-time, and (somewhat selfishly) has a family too. Unfortunately he hasn't got a ton of time for Spark at the moment, but this will hopefully change next year.

Understood. Glad to hear it is still alive!
—
Sent from Mailbox
On Sun, Nov 22, 2015 at 7:37 AM, David<EMAIL_ADDRESS>wrote:

Definitely not dying @timmattison, but we currently only have one maintainer (Per) who is working full-time, and (somewhat selfishly) has a family too. Unfortunately he hasn't got a ton of time for Spark at the moment, but this will hopefully change next year.
Reply to this email directly or view it on GitHub:
https://github.com/perwendel/spark/issues/362#issuecomment-158756284

This is duplicated by two other issues with more comments.


[5.2] Fix redundant MAC rehashing

The BaseEncrypter is not comparing a freshly computed MAC based on the payload to the one supplied, but instead is comparing MACs of these two values (so basically MACs of MACs). As far as I can tell this is unnecessary and also wastes 16 bytes of randomness each time something is decrypted (as well as processing power).
I removed said redundant code.

Ping @ircmaxell. ;)

Would rather hold off on this until we can get more feedback.


Cannot call a refined function that has a call-by-name parameter

def byName(b: => Int): Int = b
val namedFunction: ((=> Int) => Int) { def apply(i: => Int): Int } = byName _
namedFunction(i = 1)

ERROR: x.apply__F0__ is not a function

https://scalafiddle.io/sf/PPdQ8T8/0
Fails on both Scala 2.11 and Scala 2.12

Maybe related to https://github.com/scala/bug/issues/10334

Note that refinement types are also used for creating dependent functions in http://dotty.epfl.ch/blog/2017/12/01/fifth-dotty-milestone-release.html

That happens because the Scala.js compiler reverse-engineers anonymous function classes generated by scalac into a JS function wrapped inside scala.scalajs.runtime.AnonFunctionN. Since AnonFunctionN are completely generic, they won't actually expose an apply method taking a Function0 as parameters (only one taking an Object).
I had not thought about directly assigning function literals to type refinements when designing that.
AFAICT, those two things cannot be reconciliated. If we want to fix this issue, we will have to completely remove that optimization, which means an increase in code size for all anonymous functions in all Scala.js codebases.
@gzm0 Opinion?

If you use an explicit function type, then scalac does not generate a reflective call. It regularly calls the method apply__O__O defined in Function1, so that works because AnonFunction1 implements exactly that method.
I am not sure why scalac generates a reflective call for the original snippet. But because it does that, it then clashes with the fact that we use AnonFunctionNs instead of full-blown anonymous classes.

This would trigger the problem anyways, no?
def byName(f: () => Int): Int = f()
val namedFunction: AnyRef { def apply(i: () => Int): Int } = byName _
namedFunction(i = () => 1)

Yes, indeed. :(

That is quite scary.
What we would have to do to detect when we can apply that optimization is: if there is any reachable methods in AnonFoo that is not also reachable in AnonFunctionN, then we cannot optimize new AnonFoo in that way. If however all methods of AnonFoo are present (i.e., reachable) in AnonFunctionN (and AnonFoo extends s.r.AbstractionFunctionN without additional interface), then we can "safely" (see below) do the replacement. That definitely requires an additional knowledge query, but it's not too bad.
To actually do the replacement, we would have to intercept a non-stack-allocated
new AnonFoo.init___T1__...__TM(e1, ..., em)

by
new AnonFunctionN(lambda<x1 = e1, ..., xm = em>(arg1, ..., argn) = {
  new AnonFoo.init__T1__...__TM(x1, ..., xm).apply__O__...__O(arg1, ..., argn)
})

and ensure that, within that lambda, the new AnonFoo is stack-allocated (this would always succeed in this case, AFAICT).
That would solve the issue with the reflective calls that go berserk.
However, if we do this, then the optimizer starts doing something it has never done so far: it changes some defined, observable semantics. Indeed, f.getClass() will return something different when f has been optimized in that way, versus when it hasn't. (and we can't detect whether getClass() will be called, because in practice getClass() is always reachable and for all classes in the world). It also changes the semantics of f.isInstanceOf[AnonFunctionN] (although we could disallow all optimizations into AnonFunctionN if areInstanceTestsUsed is used for AnonFunctionN, but it would introduce performance cliffs in the entire codebase).

I wonder if adding a @specialized annotation to type parameters of AnonFunctionN enables reflective call to function literals.

It seems that @specialized enables reflective calls for primitive parameters
@inline
final class MyAnonFunction1[@specialized -T1, +R](f: js.Function1[T1, R])
extends scala.runtime.AbstractFunction1[T1, R] {
  override def apply(arg1: T1): R = f(arg1)
}

def byName(b: Int): Int = b
val namedFunction: { def apply(i: Int): Int } = new MyAnonFunction1(byName _)
namedFunction(1)

https://scalafiddle.io/sf/tYjhpyc/0
But not for functions:
@inline
final class MyAnonFunction1[@specialized -T1, +R](f: js.Function1[T1, R])
extends scala.runtime.AbstractFunction1[T1, R] {
  override def apply(arg1: T1): R = f(arg1)
}

def byName(b: () => Int): Int = b()
val namedFunction: { def apply(i: () => Int): Int } = new MyAnonFunction1(byName _)
namedFunction(() => 1)

https://scalafiddle.io/sf/FhEiZCA/0

@specialized only specializes primitives, so that makes sense. And then again, only if all specialized type params are instantiated to primitives. Plus, we cannot specialize all the way to Function22, since that would generate 10^22 classes.
So specialization is definitely not useful here.

I've been thinking on and off about this issue for a while, and I seem to always end up with the same conclusion:

The original issue, i.e., when the structural type is FunctionN[...] { def apply(...)... }, should be fixed upstream, in scalac. There is no reason to use a reflective call. The compiler knows that it can use the apply(Object,Object,...)Object bridge with the correct semantics, and more efficiently.
The issue when assigning to a larger structural type, e.g., Any { def apply(...)... } should be a won't fix, and documented as such. We already do not support reflective calls to JS types, it's not such a stretch to say that reflective calls to anonymous functions are not supported either.

Note that the Dotty issue is completely irrelevant here, since this issue is dictated by the scalac plugin of Scala.js, and Dotty would have it own, independent dotc plugin. Moreover, it would also fall into case 1. from above, as there should be no reason to fallback to a reflective call.
Opinions?

I think this is indeed the best we can do, yes. I'm very sad about the lack of type safety for reflective calls (as in the compiler not failing), but IIRC, we have looked into this and it would be very hard to support (warning when an unsupported type gets widened to a structural type).


Remove unneeded settings import

As all the settings are !default, the expected way to override settings is to define them before doing the import.
Importing the settings generally works, because we just end up redefining them before they get used. However, it does break some things – specifically, where settings rely on each other (such as the legacy mode settings, or $govuk-assets-path which is relied on by $govuk-images-path and $govuk-fonts-path).
This doesn't work correctly because e.g. $govuk-images-path gets defined before $govuk-assets-path gets overridden, which means it uses the old assets path.
This caught out a user who was using this as a template, and was overriding $govuk-assets-path but not seeing the expected changes represented in $govuk-images-path.

@nickcolley just wanted to check if you're happy with this change, as I think you added this line originally?


Dynamic Configuration of Port used by CodeSearcher.WebAPI

Currently CodeSearcher.WebAPI uses fix port 5000, when an instance of the web api is already running or another process uses this port the WPF App is failing.

WebAPI should be configurable e.g. via command line parameter to define the port to be used
WPF app should detect free port and configure WebAPI to use this port

I'll have a look at this over the weekend if nobody beats me to it

@hughesjs happy to see your PR :)

@koepalex - Are you set on having the port settable from command line parameter? The usual way to do this would be from an environment variable and/or the appsettings.json file so that it can be injected from a CI/CD pipeline


readme fake api

closes #331

PR-Codex overview
This PR introduces a Fake API for mocking eo-kafka, allowing manipulation of an in-memory XML document instead of a real Kafka broker.
Detailed summary:

Added FkBroker class for creating an in-memory XML document
Added FkProducer class for creating a fake producer
Added FkConsumer class for creating a fake consumer
Added example code demonstrating the usage of the Fake API
Added documentation explaining the usage of the Fake API
Added support for closing fake producers and consumers

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@h1alexbel thank you for your Pull Request. I'll assign someone to review it soon.
If this PR solves a todo from the code, please don't forget to remove it.

@h1alexbel please review this Pull Request. Deadline (when it should be merged or closed) is 2023-07-01T14:19:05.755256.
You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough.
Estimation here is 30 minutes, that's how much you will be paid. You will be paid even if this PR gets rejected.

@rultor merge

@rultor merge

@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@h1alexbel Done! FYI, the full log is here (took me 2min)


test(e2e,playwright): your-internet-presence section on settings page

Checklist:

[X] I have read and followed the contribution guidelines.
[X] I have read and followed the how to open a pull request guide.
[X] My pull request targets the main branch of freeCodeCamp.
[X] I have tested these changes either locally on my machine, or GitPod.

#51705: Implements e2e tests for "Your Internet Presence" section on Settings page

camperbot cant code


Many shields missing

Many shields are missing from the tool. Went there looking for fingerprint but noticed quite a few are not there.

That's strange. It might be hidden by your selections.
What options do you have selected in the checkboxes on the left? For Fingerprint to show up "Greatshield" should be checked, as well as any affinity other than "Unique".
Also, if "Effective only" is checked, anything with unmet stat requirements won't be included. Entering 48 strength or unchecking this option is necessary for Fingerprint to appear.


Feature/oxford ros

Status
Development
Description
oxford_ros is a ROS node to publish Oxford datasets (http://robotcar-dataset.robots.ox.ac.uk/) to ROS just like rosbag player. Currently it supports camera center, GPS/INS poses, 3D LiDAR and front 2D LiDAR.
Usage
See README

I went through the code quickly and looks good. I can not test because I can not download the data before they activate my account.
Is there a way (command) to download all .tar files in one dataset (e.g. http://robotcar-dataset.robots.ox.ac.uk/datasets/2014-05-19-13-20-57/) at once?

At this time there is no script to automate downloading, because the web
page requires authentication.
2017-08-25 15:54 GMT+09:00 Dejan Pangercic<EMAIL_ADDRESS>
I went through the code quickly and looks good. I can not test because I
can not download the data before they activate my account.
Is there a way (command) to download all .tar files in one dataset (e.g.
http://robotcar-dataset.robots.ox.ac.uk/datasets/2014-05-19-13-20-57/) at
once?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/CPFL/Autoware/pull/757#issuecomment-324838674, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AJjhHxeBgu_ngjuznBQoUEi5GG-AUvDcks5sbm-YgaJpZM4OqpQW
.

I also wrote the oxford gps drivers these days.  I can test the your version and feedback to you.

I wrote oxford gps driver code. I don't know your package need it or not. If need, please tell me.

@sujiwo Is this PR still valid?


feature(new-ui): Add new Remote Search Selector

Checklist

[x] the contributor license agreement is signed
[x] commit message follows commit guidelines
[x] tests are included
[x] screenshots are included showing significant UI changes

Description of change

This adds a new 'selector' for the New Search UI to navigate to the remote legacy remote search pages. The New UI side of things all works, however it has unveiled a few bugs with the legacy UI remote searching (primarily excessive persisting of state). Those issues are well outside the scope of this work, however will definitely need to be fixed to release 2020.2 and so will be in a PR soon.
Video: https://streamable.com/on6ljx

#1306

Interesting BaseEntityAPITest failure. Same as happened for @mrblippy in #2536
Seems to be a new thing since the Hibernate merge. :confused:

Okay, a fix has been made to develop for the failing build. So I've re-run the GHA builds.


Update horizontal-pod-autoscale.md，resolve 404 page

这个地方，中文的文档还未翻译，打开是404，建议先跳转到英文的文档。https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.19/#horizontalpodautoscaler-v1-autoscaling

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.
It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address.  Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at<EMAIL_ADDRESS>

I finish sign CLA .

Yes . remove the zh is a good way .

Link fix valid. Page still in sync.
/lgtm
/approve


Update snapshot link in README

Have the link pointing to the latest available snapshot.
In order for this to work, I had to remove the size and what's the latest block from the table, so we won't have to manually update this information everytime.
I also included a way to know how big the snapshot is via script, so this information will always be up-to-date by the time someone runs the command

I guess we could also update our docs with those links: https://github.com/NethermindEth/juno/blob/main/docs/docs/snapshots.md

Good idea -> https://github.com/NethermindEth/juno/pull/2013


godog not recognizing the implemented step definition

Hi,
I am working in a golang project where in I am writing the gherkin steps and writing step definition
generated by  using godog.
My package structure is:
project 's outermost directory contains:
---features(This directory in turn contains below two things)
---features(this is the directorywhich contain .feature files)
-- implemented_step-definition.go file
---Makefile( this is at the same level as outermost features directory)
The issue is that when I run godog with cucumber option under my project 's outermost directory, it recognizes the feature files under the features directory  and generates the boiler plate code but it does not run the already implemented step definitions.
Please help me on this .How to make godog run the implemented step definitions from my project's
outermost directory
Thanks,
Ruchira

Hi,
godog acts like go test command. your step definitions should be in _test.go files in order to prevent compiling them in production code.
All step definitions needs to be registered in godog.Suite all functions AnuthingContext(s *godog.Suite) are invoked for registering steps. Note, that the context function should be exported - start with capital.
godog should be run in root package where your step definitions are in _test.go files. In order to see what step definitions godog finds, you can run godog -d that will list all detected step defs.
You can have a look at examples directory in godog or godog package itself. in order to see how a project and steps are setup. If you still struggle to find the cause, then you can simply create a minimal project with your layout which does not work, so I could help you.
Regards,
Gedi

What isnt clear in the original issue is that in our configuration  features and step definitions exist in multiple child folders.   Everything works fine if we run godog from somefunc, and somefunc2 where the steps exist but obviously we are running only one set of tests at a time and not all.
project-root
|----features
|       |----somefunc
|       |       |----features
|       |       |       |---- f1.feature
|       |       |       |----f2.feature
|       |       |---step_defs_test.go
|       |----somefunc2
|       |       |----features
|       |       |       |---- g1.feature
|       |       |       |----g2.feature
|       |       |---step_defs_test2.go

If we run godog from project-root ALL feature files appear to be located just fine, however,  the step defs are dont found and executed.
Your 3rd paragraph in the response seems to say what we see.  It seems that even though feature files can be split up and spread out across the folder structure, the step defs cannot.  Godog is looking for one context in the current folder?
So to run all tests across the multiple step defs and contexts then we need to run godog multiple times -- once from the location of each step def file?

when you run go test it compiles _test.go files only from current package directory. because it operates within a package only. (a package is your world). same as godog.
All imported packages by the package you are testing, are compiled without _test.go files.
I've made godog to be close to go test command and follow the same rules. and your godog test files should be per package only.
The idiomatic structure should be:
project-root
|----features
|       |----somefunc
|       |       |----features
|       |       |       |---- f1.feature
|       |       |       |----f2.feature
|       |----somefunc2
|       |       |----features
|       |       |       |---- g1.feature
|       |       |       |----g2.feature
|----step_defs_test.go
|----step_defs2_test.go
|----main.go

Otherwise project-root/features/somefunc/features package is bogus since it does not contain go source. If you are coming from cucumber ruby then this is a little bit different, but that is the way it is. If you want to split steps into separate contexts - split them in separate files, but at the same package level.

I see.  Actually I think I missed the fact that go test works similarly.   I was thinking go test traversed the tree.
We have decided to collapse this structure as a result.  Thank you for you responses.

go test can traverse if you tell it to, but it will compile and run tests for each package separately, godog simply does not provide such option yet, as it is not necessary in most of the cases, because most of users holds on to feature set in core project package including all step definitions in test.go files.
and that is an idiomatic way in my opinion, because these are not unit tests and usually you test the public application interface, which is exposed to user (weather it is UI, API or CLI) and that is usually a core project directory or cmd/name dir where users put all their features and step definitions. This is the encouraged way to do project layout.
If you put your tests in project root directory including go unit tests, then you get the benefit to use TestMain function in order to get combined go code coverage. This way is also encouraged and it still allows to run godog command separately if different command options are needed. You can also customize TestMain function with cli options when you run tests, like for example controlling verbosity go test -v.
From the first look godog may seem to lack features, but these are easily composed if you think the go way of doing things.

I appreciate your insights on this.  We have adjusted our perspective accordingly.  Thank you!

Hey hi, i am having the similar issue.
i have written the same code which is mentioned in TestMain, but when i run "go test" it was not able to find the implemented steps.
any help..!!

hi @linuxramu it just may mean two things

either you haven't hooked the step with context into test suite
or the step regexp does not match the step

running godog -d should show the step definitions. If you see there your step, then you can eliminate 1. Now what relates to 2, create a small test and try to match regexp you use in step to the actual step test you are testing.

thanks for reply, when i ran godog -d, i could see my steps so i am eliminating 1.
I couldnt get your 2, can you please give some examples.
Also let me give you more info that

When running my one feature with godog, it runs pefect

My folder structure looks like
  tests
         features
                 tasks.feature
  tasks_test.go

So when I run godog tasks.feature from below location, it runs and gives me result correctly
c:> mainfolder> tests> godog features/tasks.feature
Since my code is growing and i am having more features, now I need to write a driver test or a main test which runs the features as tagged or needed, so thats when this issue is...
I have followed to write MainTest as mentioned here : https://github.com/DATA-DOG/godog#running-godog-with-go-test
but no luck :(

with 2. I mean that the regular expression you use is incorrect and it does not match the step. so I'm suggesting to test your regullar expression used for the step definition.
godog itself uses godog to test himself. look at this repository how it uses features and how they are structured in the project. the directory you run godog from, must contain all the go files needed for your tests.


Add Alluxio Fuse support for ARM.

Is your feature request related to a problem? Please describe.
I'm always frustrated when Alluxio Fuse does not support ARM.
Urgency
Urgent.

@LuQQiu Would you like to take a look? Thanks♪(･ω･)ﾉ

@LuQQiu

@JySongWithZhangCe What's the error information? we can work together to see what's the barriers

@JySongWithZhangCe What's the error information? we can work together to see what's the barriers
Sure. And whether it is possible to add arm packages at the same time, currently there are only x86 and mac packages.

@LuQQiu The error information is：
#9 214.6 Making all in lib
#9 214.6 make[1]: Entering directory `/libfuse/lib'
#9 214.7   CC       fuse_loop_mt.lo
#9 214.7   CC       fuse_loop.lo
#9 214.7   CC       fuse.lo
#9 214.7   CC       fuse_kern_chan.lo
#9 214.7   CC       fuse_mt.lo
#9 214.7   CC       fuse_lowlevel.lo
#9 214.7   CC       fuse_session.lo
#9 214.7   CC       fuse_opt.lo
#9 215.6 In file included from fuse_loop_mt.c:11:0:
#9 215.6 ../include/fuse_kernel.h:93:15: error: conflicting types for 'int64_t'
#9 215.6  #define __s64 int64_t
#9 215.6                ^
#9 215.6 In file included from /usr/lib/gcc/aarch64-redhat-linux/4.8.5/include/stdint.h:9:0,
#9 215.6                  from ../include/fuse_common.h:19,
#9 215.6                  from ../include/fuse_lowlevel.h:26,
#9 215.6                  from fuse_loop_mt.c:9:
#9 215.6 /usr/include/stdint.h:40:19: note: previous declaration of 'int64_t' was here
#9 215.6  typedef long int  int64_t;
#9 215.6                    ^
#9 215.6 In file included from fuse_loop_mt.c:11:0:
#9 215.6 ../include/fuse_kernel.h:92:15: error: conflicting types for 'uint64_t'
#9 215.6  #define __u64 uint64_t
#9 215.6                ^
#9 215.6 In file included from /usr/lib/gcc/aarch64-redhat-linux/4.8.5/include/stdint.h:9:0,
#9 215.6                  from ../include/fuse_common.h:19,
#9 215.6                  from ../include/fuse_lowlevel.h:26,
#9 215.6                  from fuse_loop_mt.c:9:
#9 215.6 /usr/include/stdint.h:55:27: note: previous declaration of 'uint64_t' was here
#9 215.6  typedef unsigned long int uint64_t;
#9 215.6                            ^
#9 215.7 In file included from fuse.c:20:0:
#9 215.7 ../include/fuse_kernel.h:93:15: error: conflicting types for 'int64_t'
#9 215.7  #define __s64 int64_t
#9 215.7                ^
#9 215.7 In file included from /usr/lib/gcc/aarch64-redhat-linux/4.8.5/include/stdint.h:9:0,
#9 215.7                  from ../include/fuse_common.h:19,
#9 215.7                  from ../include/fuse.h:26,
#9 215.7                  from fuse_i.h:9,
#9 215.7                  from fuse.c:14:
#9 215.7 /usr/include/stdint.h:40:19: note: previous declaration of 'int64_t' was here
#9 215.7  typedef long int  int64_t;
#9 215.7                    ^
#9 215.7 In file included from fuse.c:20:0:
#9 215.7 ../include/fuse_kernel.h:92:15: error: conflicting types for 'uint64_t'
#9 215.7  #define __u64 uint64_t
#9 215.7                ^
#9 215.7 In file included from /usr/lib/gcc/aarch64-redhat-linux/4.8.5/include/stdint.h:9:0,
#9 215.7                  from ../include/fuse_common.h:19,
#9 215.7                  from ../include/fuse.h:26,
#9 215.7                  from fuse_i.h:9,
#9 215.7                  from fuse.c:14:
#9 215.7 /usr/include/stdint.h:55:27: note: previous declaration of 'uint64_t' was here
#9 215.7  typedef unsigned long int uint64_t;
#9 215.7                            ^
#9 215.7 make[1]: *** [fuse_loop_mt.lo] Error 1
#9 215.7 make[1]: *** Waiting for unfinished jobs....
#9 215.8 fuse.c:2275:5: error: conflicting types for 'fuse_fs_bmap'
#9 215.8  int fuse_fs_bmap(struct fuse_fs *fs, const char *path, size_t blocksize,
#9 215.8      ^
#9 215.8 In file included from fuse_i.h:9:0,
#9 215.8                  from fuse.c:14:
#9 215.8 ../include/fuse.h:882:5: note: previous declaration of 'fuse_fs_bmap' was here
#9 215.8  int fuse_fs_bmap(struct fuse_fs *fs, const char *path, size_t blocksize,
#9 215.8      ^
#9 215.8 fuse.c: In function 'fuse_fs_bmap':
#9 215.8 fuse.c:2285:3: warning: passing argument 3 of 'fs->op.bmap' from incompatible pointer type [enabled by default]
#9 215.8    return fs->op.bmap(path, blocksize, idx);
#9 215.8    ^
#9 215.8 fuse.c:2285:3: note: expected 'uint64_t *' but argument is of type 'uint64_t *'
#9 215.9 fuse.c: At top level:
#9 215.9 fuse.c:4184:2: warning: initialization from incompatible pointer type [enabled by default]
#9 215.9   .bmap = fuse_lib_bmap,
#9 215.9   ^
#9 215.9 fuse.c:4184:2: warning: (near initialization for 'fuse_path_ops.bmap') [enabled by default]
#9 216.1 make[1]: *** [fuse.lo] Error 1
#9 225.8 make[1]: Leaving directory `/libfuse/lib'
#9 225.8 make: *** [all-recursive] Error 1
------
error: failed to solve: rpc error: code = Unknown desc = executor failed running [/bin/sh -c yum install -y ca-certificates pkgconfig wget udev git &&     yum install -y gcc gcc-c++ make cmake gettext-devel libtool autoconf &&     git clone https://github.com/Alluxio/libfuse.git &&     cd libfuse &&     git checkout fuse_2_9_5_customize_multi_threads &&     bash makeconf.sh &&     ./configure &&     make -j8 &&     make install &&     cd .. &&     rm -rf libfuse &&     yum remove -y gcc gcc-c++ make cmake gettext-devel libtool autoconf wget git &&     yum install -y fuse3 fuse3-devel fuse3-lib &&     yum clean all]: exit code: 2


Add toolkit support for new longrunning operation implementation in Java

Codecov Report

Merging #1369 into master will decrease coverage by 0.1%.
The diff coverage is 54.54%.

@@             Coverage Diff              @@
##             master    #1369      +/-   ##
============================================
- Coverage     86.59%   86.49%   -0.11%
+ Complexity     3906     3905       -1
============================================
  Files           382      383       +1
  Lines         15637    15668      +31
  Branches       1727     1729       +2
============================================
+ Hits          13541    13552      +11
- Misses         1634     1650      +16
- Partials        462      466       +4

Impacted Files
Coverage Δ
Complexity Δ

...gle/api/codegen/viewmodel/ApiCallSettingsView.java
83.33% <ø> (-2.39%)
2 <0> (-2)

...pi/codegen/transformer/ApiCallableTransformer.java
98.2% <100%> (-0.08%)
22 <0> (-1)

.../transformer/java/JavaGapicSurfaceTransformer.java
98.13% <100%> (ø)
43 <0> (ø)
:arrow_down:

...e/api/codegen/viewmodel/LongRunningConfigView.java
100% <100%> (ø)
2 <2> (?)

...pi/codegen/transformer/LongRunningTransformer.java
87.17% <100%> (+6.41%)
3 <1> (+1)
:arrow_up:

...m/google/api/codegen/config/LongRunningConfig.java
22.22% <16.66%> (-11.12%)
2 <0> (-1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a167b2...2209a34. Read the comment docs.


Support for SI units?

I would like to add another another format with the letter 'k' (similar to 'a') to indicate something should be formatted with si prefixes.
Example:
numeral(0.0000032434).format('0.0 k');
// 3.2 μ

numeral(0.0000032434).format('0.[00] k');
// 3.24 μ

I want to get some feedback to see if this makes sense to implement. If it does, I'll submit a pull request.
Thanks in advance.

+1

Sounds like it can't hurt :smile:
why the k?

It's just the si prefix for kilo -- we could use si or something else if you prefer. What do you think?

ok.
the code as to be a single character

That sounds great (but the fact it's from 2015 doesn't make me hopeful :cry:)
I was looking into expressing units such as "Gbps" (gigabits per second) and "Mpps" (megapackets per second). The bytes formatting in the code handles units like MB/MiB, but seems hardcoded to express bytes, rather than any other types of units, as far as I could tell.
Perhaps another way to frame this bug is to generalize that support, and provide two types of unit prefixes, SI and IEC/IEEE?


Set user preference for keyboard or mouse to play

JQuery and JQuery UI CDN links included to use dialog function of JQuery UI for choosing controls.
Fixes #8

This looks great. Good job fixing the jQuery issue.
I would still test this feature a little to see if there are any bugs :)
Thanks @thegauravtiwari

Thanks for helping, @jajodiaraghav sir :)


unistd: add bindings to functions tcgetpgrp, tcsetpgrp

Looks like Travis failed to download a dependency...

Hi Nils,
Thanks for the patch.  I reran the failing Travis check successfully, so probably just a transitory network glitch.  Merged and pushed!
Cheers,
Gary


Fix corner FABs visibility bug

Description
Fixes #1322 FABs visibility problem
Setting anchor params height and weight to zero, solved buttons become visible for a moment before being hidden.
Checking isShown on actionListeners solved hidden buttons performing actions issue
Tests performed
Manual testing on API 19 betaDebug and prodDebug
Screenshots showing what changed
Bofore:

After:

Waiting for your review @misaochan , @maskaravivek