OpacityLayer causes sharp increases in memory usage in trivial apps

Reproduction code (only depends on dart:ui and a large image):
https://gist.github.com/ds84182/2621bab595f769474be9971fbfab89b4
Copied from the documentation comment on main():

Raw, dart:ui-only example of an issue with opacity layers & the rasterizer cache.
Works best on Desktop, controls need to be changed for Android & iOS.
Web untested.
Controls:
Left Click - Add Opacity Layer
Right Click - Remove Opacity Layer
Expected Behavior:
Adding opacity layers does not increase the total memory usage.
Actual Behavior:
Each opacity layer causes the RasterCache to allocate a new 4,000 by 2,000 texture.
One would expect that nested opacity layers would collapse into a single (equivalent) layer, and one would expect that a picture layer displaying a simple image could merge with the opacity layer, resulting in a call to drawImage with a Paint applying the equivalent opacity.
Why does this matter?
There are many scenarios where a developer can place one (or more) opacity layers around a simple image. For example, the built-in FadeInImage widget, which uses FadeTransition, which eventually produces an opacity layer in RenderAnimatedOpacity.
Apps fade in images a lot. An image-heavy application (e.g. our application) can vary in memory usage wildly, regardless of the Flutter-level ImageCache.
Additionally, an app with an infinite scrolling list of images being faded in will hit memory limits on fast flings. Not because of image loading, but because the raster cache is unbounded when used in conjunction with  OpacityLayer. This is also why video memory usage can seemingly fluctuate, or fail to match the exact number of images loaded.
What can be done?
OpacityLayer currently delegates out to the RasterCache, drawing the child layer with the specified paint.
https://github.com/flutter/engine/blob/ecfe5aec50e5a8d97e4818addbcef47f7300d2d1/flow/layers/opacity_layer.cc#L63
This can be changed to allow layers to:

Trivially combine paints (OpacityLayer -> OpacityLayer situation)
Circumvent the need for the raster cache by combining paints together, if compatible (OpacityLayer -> simple PictureLayer situation)

Perhaps an ImageLayer can be introduced, to make this situation easier to optimize, since Skia Pictures are opaque (can't get list of Ops out).

cc @dnfield
also goodnight, it's 1:30am.

I wonder if @flar or @chinmaygarde have a good idea for this.
I think this is probably WAI right now. Opacity layers are expensive, and caching them is generally the right thing to do. Using lots of large opacity layers is not going to be great for performance - it requires having additional render targets and is computationally expensive.
It sounds like we might want some kind of cap on the raster cache so that it doesn't just keep gobbling up memory.
The problem with "combining paints" is that it won't always be correct. There are trivial situations where it will work, but as soon as you need to blend multiple opacities it will sometimes be incorrect. Flutter SVG tried to optimize things this way and had to stop because it only worked for simple cases and detecting when those cases are valid is actually pretty expensive and difficult.
If you or anyone has an idea for a foolproof heuristic that would actually work and isn't more expensive than just doing what we currently do, it'd be super cool. I think the hard part is the case where it has to get invalidated because you encounter a new opacity layer getting blended in, and making sure you still have access to the original opacity values for each layer you combined that you now have to un-combine to get the correct alpha blend.

There is currently no way to inspect the contents of a PictureLayer. The associated Picture/SkPicture objects are opaque and the best we can tell is the "number of operations", but we can't tell what those ops are. We'd have to annotate the objects heavily on our end to be able to detect something that could be collapsed.
With regard to collapsing Opacity+Opacity, that might be easier, but how often does this happen?

@flar:
Not sure if Opacity+Opacity is frequent enough to have a specific optimization, maybe it should be documented as a potential performance pitfall instead.
For Opacity+Picture, as a way to sidestep being unable to inspect the contents of a PictureLayer, would it be possible to add an ImageLayer just for drawing trivial images? Then when drawing through the RasterCache, the incoming opacity paint can be combined directly with the image's paint (which is known to be trivial), optimizing it down to a single call to drawImage.
@dnfield:
A cap on the raster cache would be a good first step, as long as we can get some logging information when it happens. I'm going to also look through at all the places where we use FadeTransition or AnimatedOpacity to see if we can simplify some of our commonly used UI widgets.

The problem with an "ImageRenderLayer" is that at the time an image is expressed to the scene, we have no idea if it will be in isolation or if it will be a part of a hundred image thumbnails being shown. If there are a lot of images to show, then collecting them into a Picture is the fastest way to render them all. If it is a one-off, then having an explicit rendering layer will be similar in price.
If we can switch to a new Picture format that is inspectable then we could have the best of both worlds.

Posting my findings from Thursday:
Removing usages of FadeTransition from our app, instead using custom Decorations & CustomPainters to implement our fade-in animations, reduced our peak cold-start memory usage by 100 MB. However, this required a ton of manual intervention, as well as looking at raster cache and offscreen layer usage.
Additionally, I think this change can apply to other layers that are trivially applicable to images and other trivial-to-paint operations. For example ClipRectLayer, which can apply directly to images and canvas ops like drawPaint/drawRect, etc. Of course, OpacityLayer should be highest priority since it's the biggest footgun in this area.


[Event Change Request] - PurchPost.Codeunit.al - OnPostItemChargeLineOnBeforePostItemCharge

We like to request the following event change:
Object: PurchPost.Codeunit.al
ToDo: add GenJnlLineDocNo
Where is the event placed:
if FindTempItemChargeAssgntPurch(PurchaseLineBackup."Line No.") then
repeat
OnPostItemChargeLineOnBeforePostItemCharge(TempItemChargeAssgntPurch, PurchHeader, PurchaseLineBackup, GenJnlLineDocNo);
case TempItemChargeAssgntPurch."Applies-to Doc. Type" of
TempItemChargeAssgntPurch."Applies-to Doc. Type"::Receipt:
begin
PostItemChargePerRcpt(PurchHeader, PurchaseLineBackup);
TempItemChargeAssgntPurch.Mark(true);
end;
Event Code:
[IntegrationEvent(false, false)]
local procedure OnPostItemChargeLineOnBeforePostItemCharge(var TempItemChargeAssgntPurch: record "Item Charge Assignment (Purch)" temporary; PurchHeader: Record "Purchase Header"; PurchLine: Record "Purchase Line"; var GenJnlLineDocNo: Code[20])
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Ignore the check from BCH of license text

I've selected for refactoring 15 lines of code which are duplicated in 3 file(s) (1, 2, 3).  Addressing this will make our codebase more maintainable and improve Better Code Hub's Write Code Once guideline rating! 👍
Here's the gist of this guideline:

Definition 📖
Do not copy code.
Why❓
When code is copied, bugs need to be fixed in multiple places. This is both inefficient and a source of regression bugs.
How 🔧
Avoid duplication by never copy/pasting blocks of code and reduce duplication by extracting shared code, either to a new unit or introduce a superclass if the language permits.

You can find more info about this guideline in Building Maintainable Software. 📖

ℹ To know how many other refactoring candidates need addressing to get a guideline compliant, select some by clicking on the 🔲  next to them. The risk profile below the candidates signals (✅) when it's enough! 🏁

Good luck and happy coding! :shipit: :sparkles: :100:
Issue generated by PR: https://github.com/litmuschaos/chaos-operator/pull/93

Currently this is not supported by BCH

Closing this as an external dependency/issue.


Problem on service start, Odroid XU-4

A little desperate to get this up and running its for a school project. What am i missing, I feel like this is a configuration issue. Please please please, and thank you. I am more than happy to provide any logs or other info, I am just running a little behind schedule.
systemctl enable rancherd-server.service
systemctl start rancherd-server.service
journalctl -eu rancherd-server -f

Jul 21 06:47:47 rancher_server rancherd[16043]: time="2021-07-21T06:47:47Z" level=error msg="Failed to check local etcd status for learner management: context deadline exceeded"
Jul 21 06:47:47 rancher_server rancherd[16043]: {"level":"warn","ts":"2021-07-21T06:47:47.629Z","caller":"clientv3/retry_interceptor.go:62","msg":"retrying of unary invoker failed","target":"passthrough:///https://<IP_ADDRESS>:2379","attempt":0,"error":"rpc error: code = DeadlineExceeded desc = latest balancer error: connection error: desc = \"transport: Error while dialing dial tcp <IP_ADDRESS>:2379: connect: connection refused\""}

Jul 21 06:47:47 rancher_server rancherd[16043]: time="2021-07-21T06:47:47Z" level=info msg="Failed to test data store connection: context deadline exceeded"
Jul 21 06:47:48 rancher_server rancherd[16043]: time="2021-07-21T06:47:48Z" level=info msg="Waiting for cloudcontroller rbac role to be created"
Jul 21 06:47:51 rancher_server rancherd[16043]: time="2021-07-21T06:47:51Z" level=warning msg="Unable to watch for tunnel endpoints: Get \"https://<IP_ADDRESS>:6443/api/v1/namespaces/default/endpoints?fieldSelector=metadata.name%3Dkubernetes&resourceVersion=0&watch=true\": dial tcp <IP_ADDRESS>:6443: connect: connection refused"

Jul 21 06:47:52 rancher_server rancherd[16043]: time="2021-07-21T06:47:52Z" level=info msg="Waiting for etcd server to become available"
Jul 21 06:47:53 rancher_server rancherd[16043]: time="2021-07-21T06:47:53Z" level=info msg="Waiting for cloudcontroller rbac role to be created"

Jul 21 06:48:11 rancher_server rancherd[16043]: time="2021-07-21T06:48:11Z" level=info msg="Waiting for kubelet to be ready on node rancher_server: Get \"https://<IP_ADDRESS>:6443/api/v1/nodes/rancher_server\": dial tcp <IP_ADDRESS>:6443: connect: connection refused"

@socket23 there is no systemd in k3OS so I fail to see how this is a k3OS issue. Does this belong in rancher/rancher maybe?


Export TODOs

I would like to be able to export TODOs. Like copying to a clipboard or exporting to a certain format (markdown, html). Is this something you're considering doing?

I like the idea.  How would you feel about having a configurable lodash template?  I could apply a deep clone of the repository in the context and provide a default template as an example.

:+1:

Oh, I didn't respond, sorry. Yes, some sort of templating system would be great. A few options out of the  box might be helpful as well.

For me, in a perfect world, I could export items as github issues. I may just be dreaming though :) Also, if I could pull GH issues, this app would make my day.

@lordnynex I'm working on a plugin for that now.  Stay tuned!

+1
it would be very interesting to export todos in a customizable format :

for filing
for communication with stakeholders

This has been implemented in 2.4.1.  alt+x creates imdone-export.json.  Make sure you add it to .imdoneignore .

@lordnynex you can create github issues from your TODO comments with imdone.io


Add UI feature to bulk delete checked files and metadatasets

The submit view should have the following three buttons in each of the metadata and files tables:

Select All
Select None
Delete Selected

The corresponding back end implementation is tracked here #279


The candidate code snippets for retrieval

Hi,
I'm little confused about the candidate code snippets for retrieval. In the paper, it is said that "(2) Lexical Retrieval uses Jaccard Similarity and Edit Similarity to assess the relevance between the cropped code from the in-file context and the candidate code snippets.". So what are the candidate code snippets exactly?
By looking into the test dataset, I found that for each completion case stored in dict format, there is a key called 'context' with at most 9 code snippets. Is this the retrieval source?

Do u mean the retrieval part or the completion part?
I think you are using the easy subset (5~9 candidates) of repobench-r. For the retrieval, we use acc@k to evaluate, which means the task is to rank the contexts (for easy it is at most 9), one of which is the gold context (will be use for next line prediction).
The candidate code snippets are the code list (context).

Thanks a lot for your reply! I'm actually looking into the retrieval part.

Sounds great. Then you are right, the context key, which should correspond to a list, should be the retrieval source. And there should be a gold_snippet_idx (iirc, or maybe gold_snippet_index), that is the one should be retrieved.

Get, thanks a lot for your explanation!


Update aya dependency to get PerfEventArray fix

This PR temporarily pins our aya dependency to the commit for aya pr 996 that automatically sizes PerfEventArrays

Hi folks, let's discuss this at the community meeting as this commit broke our packit builds.
@dave-tucker @anfredette


Temperature Controller

Add functionality to the Temperature Controller with all the proper endpoints. Adjust temperature model as necessary.

Adding endpoints to temperature controller, will call this branch temperature-controller since temp-controller ended up being weight


Error building code using Carthage

Hello Team,
I'm getting below error while using carthage to build google maps SDK.
Skipped building google-maps-ios-utils due to the error:
Dependency "google-maps-ios-utils" has no shared framework schemes for any of the platforms: iOS
Could you please let me know why I'm getting this error?
And how do I build the framework in my project.
Thanks and Regards,
Abhishek.

Carthage is not officially supported by this library yet as Carthage only supports dynamic frameworks (see: https://github.com/Carthage/Carthage#supporting-carthage-for-your-framework). Related to #99.

Dope! @arriolac

@kikettas lmk if you run into any issues with it. There's also a silent additional feature in there... including this library via Carthage will also pull in the Maps SDK for iOS binaries (see the Cartfile). If we can get enough community excitement around this, perhaps this is something we can officially support. I filed #297 for this—feel free to use the necessary emojis 👍 👎 🎉 🚀  😃


pythonPackages: add a bunch

Things done

[X] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] Linux

[X] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

The first error seems to be a bug in travis build script.
The second is a test fail on OSX which I don't ever touch.

Did you check whether tests were run? If you get something like 0 tests found it is not yet good.
Did you check with all interpreter versions?

Frederik Rietdijk<EMAIL_ADDRESS>writes:

Did you check whether tests were run?If you get something like 0 tests found it is not yet good.

Even if it has no tests in the source?
Fixed python3 tests for plyvel, others (and python2 plyvel) seem to have
no tests whatsoever.

Did you check with all interpreter versions?

Only the default python2 and python3.

@oxij if no tests are provided the tests shoudl be disabled. Furthermore, when tests are disabled, include a comment explaining why.

@oxij if no tests are provided the tests shoudl be disabled. Furthermore, when tests are disabled, include a comment explaining why.

Done.
I suggest enforcing this property in the package builder somewhere: "code is law".

Pytest 2.9 and up exit with code 1 when tests aren't found. Unfortunately the other test runners do not.

What's holding this up?


Make the WebApp responsive

Add necessary CSS code to make the Web-App responsive for smaller screens

Lemme get a free green square. 🏃🏾♂

I'll assign this to you

Can I work on its responsiveness and toggle mode?

Can I work on its responsiveness and toggle mode?

@Radon333 sorry but can you assign @khadijagardezi instead to fix this? I'm kind of choked up for now. Sorry about that.

Can I work on its responsiveness and toggle mode?

assigned

@khadijagardezi what's the progress?

Can I try to work on this, Please

@Naufal2511 assigned

Thank You for this opportunity, I will reach out to you within next month with my progress

naufal25111 is working on this if he's not able to you can do it

hello I would love to work on this


update dnscrypt servers: dns.d0wn.biz

we'll take care about updates for dns.d0wn.biz
python script to generate d0wn's dns from 'https://dns.d0wn.biz/dns.txt'
available here:
https://github.com/ovpn-to/dns.d0wn.biz-dnscrypt-resolver.csv

Merged, but can you try to keep the entries sorted?


Weird behavior when using balance inventories

Description
Balancing items between entities with ctrl + right drag does not always balance all the entities inventory, some could be left with none and you end up with those items in the player inventory. I'm uploading a video showing the issue and how to reproduce it. Thank you.
Reproduction
https://www.youtube.com/watch?v=EALnmhMqiZQ

Hi, same happens to me!


move openssl calls to common/libssl.c, check for defines

+1 :)

I haven't tested the change actually but looks good. Thank you for cleaning up my code!

I'm OK with this except for log messages. Merge?

I'm going to make changes to ssl_calls. Not to cause conflicts, let me merge.


docs: Update swagger version to 3.1.0

If your build fails  due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:

[x] I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
[x] I am not introducing a new dependency (add notes below if you are)
[ ] I have added unit tests for the new feature or bug fix (if not, why?)
[ ] I have fully tested (add details below) this the new feature or bug fix (if not, why?)
[ ] I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (52e219e) 34.18% compared to head (ae9a3bb) 34.18%.

:exclamation: Current head ae9a3bb differs from pull request most recent head cc34efc. Consider uploading reports for the commit cc34efc to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #409   +/-   ##
=======================================
  Coverage   34.18%   34.18%
=======================================
  Files          19       19
  Lines        1799     1799
=======================================
  Hits          615      615
  Misses       1118     1118
  Partials       66       66

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

closing for this better PR #410


Is there any docs for CPU-MEM cost model? I wonder the advantages & disadvantanges.

See here. https://kubernetes.io/docs/concepts/extend-kubernetes/poseidon-firmament-alternate-scheduler/

One more question:
Is there any plan to achieve data locality cost model, like Quincy?

Not at this time. We are currently working on the complex Gang Scheduling, including proportions, fairness etc. You are welcome to work on it, if you would like.

OK, thanks!

See here. https://kubernetes.io/docs/concepts/extend-kubernetes/poseidon-firmament-alternate-scheduler/

The link is broken now.

@anvithks

See here. https://kubernetes.io/docs/concepts/extend-kubernetes/poseidon-firmament-alternate-scheduler/

The link is broken now.

@deepak-vij The docs are based on Kubernetes version.
The documentation is available in the K8S v15 docs.
Here you go
https://v1-15.docs.kubernetes.io/docs/concepts/extend-kubernetes/poseidon-firmament-alternate-scheduler/

@anvithks , all the links on the Poseidon blog are broken now for some reason. Someone pointed it out. Can we fix it. thanks.

@anvithks, see the following link to the blog.
https://kubernetes.io/blog/2019/02/06/poseidon-firmament-scheduler-flow-network-graph-based-scheduler/

@anvithks, see the following link to the blog.
https://kubernetes.io/blog/2019/02/06/poseidon-firmament-scheduler-flow-network-graph-based-scheduler/

I will see if I can update these when I have some free time.
The links just need to be updated to the v1. 15 docs linked above.

@anvithks, thanks. Let me know when done so that I can let the community member know who wants to look at the docs. Thanks.

@anvithks, thanks. Let me know when done so that I can let the community member know who wants to look at the docs. Thanks.

The docs are available here now.
No need to wait.

@chauncey-77, you can see the docs as @anvithks mentioned.
@chauncey-77, I will also publish the Google Doc for the CPU/Mem design on github.

It's very kind of you, thanks again!

@chauncey-77, you can see the docs as @anvithks mentioned.
@chauncey-77, I will also publish the Google Doc for the CPU/Mem design on github.

Hi, has the Coogle Doc for the CPU/Mem design been published on github?  If it has, please share the link, thanks!

Sorry, I have been quite busy and ongoing holidays stuff. I am still trying to dig out information we put together at the time. Have not been able to find it yet. I will publish something when ready. In the meanwhile, code is quite self explanatory w.r.t. multi-dimensional CPU/Mem based cost model.

Sorry, I have been quite busy and ongoing holidays stuff. I am still trying to dig out information we put together at the time. Have not been able to find it yet. I will publish something when ready. In the meanwhile, code is quite self explanatory w.r.t. multi-dimensional CPU/Mem based cost model.

Yes I am reading the function in cpu_cost_model.h/cc, and I have figured out most of them. But at the same time I also have many questions. For example, I still can't understand the construction process of flow graph, i.e., how to generate the flow graph according to the CPU/Mem scheduling strategy. The cpu_cost_model involves some types of graph nodes, such as EquivClass, task, UnSceduledAgg, resource and sink, but I don’t figure out how these nodes form the flow graph. When comparing this graph construction function and those mentioned in the Firmament paper, I think they are different. So is there an example to understand the flow graph construction process like the Firmament paper do?

Yes, graph construction is different as we are dealing with complex multi-dimensional cost model. Firmament paper does not get into that. Give me some time, I will provide details.

Yes, graph construction is different as we are dealing with complex multi-dimensional cost model. Firmament paper does not get into that. Give me some time, I will provide details.

Oh this is awesome, I am very much looking forward to it.


Synchronize Polish localization for ver 1.22, part 5

Synchronize Polish localization with upstream up to 08d92f9. Part 5.

/lgtm
/approve


Ideas for future enhancements

Currently the nf-quilt plugin can publish a single package for a workflow run, with the option to select files by name.
Here is a list of feature enhancements that we are considering:

allow multiple quilt packages to be published, with a config block for each package
add fromQuilt channel factory to download a quilt package and emit files to a channel
add publishQuilt operator to publish received files to a quilt package, allows user to select files with pipeline logic instead of config (also supports publishing multiple packages) (similar to publish operator idea)

All of these ideas are feasible to implement, but I think we should try to figure out what users would prefer before we move forward with any of them. In particular I'd like to understand how users feel about the "config" approach vs "pipeline logic" approach.

Note: we are addressing these issues with a revamped nf-quilt plug-in currently under internal review at Quilt:
https://github.com/quiltdata/nf-quilt/pull/3
We will propose it as a PR back here once it is ready.


Ensure enumeration of ControlPlaneMachineSetMachineType type alias

I noticed that the kubebuilder validation for the enum was missing and that the comment was out of date

This project is not part of the no-ff feature process, so I'm manually applying the required labels
/label px-approved
/label docs-approved
/label qe-approved


fix: removed user name is returned if there is no login

This also should fix the prettier config for windows user.
Please let me know if you think there are any problems.

I should have run the test locally :-)
Is this maybe a corner case of the github server?


Drawing text with a non-opaque color can sometimes reveal internal glyph overlaps

Recently we fixed some bugs in the engine where applying an opacity widget to text might cause internal glyph overlaps to reveal themselves (see https://github.com/flutter/flutter/issues/122266 for example). Rather than applying such opacity as a saveLayer, the engine had been applying it by changing the color used to render the text to a less-opaque version.
While it reduced the number of developer surprises to not equate "alpha saveLayer" with "translucent coloring" in that case, a developer might choose to use a translucent color themselves and they'd see the same overlaps. Such behavior might surprise them as the same result does not occur when they apply a translucent color to a path rendering that has overlaps in it.
We should probably treat any given text operation as an atomic rendering and protect it from overlap similar to how paths are protected from overlap effects during rendering (not similar by way of implementation, but similar by way of expected output).

This seems like working as intended right? The implications of doing this the other way would be severely less performant text rendering.
Not sure how much of a problem this is in the real world. Doing this performantly by default with the option to switch to a save layer based solution seems like the way to go.

This seems like working as intended right? The implications of doing this the other way would be severely less performant text rendering.

I don't agree that this is working as intended. It may be working as our implementation team wants to put in the effort, but what does the developer expect from these operations?
Drawing a block of text.
Drawing a complex path, perhaps even a path representing a block of text.
Would the typical developer think of those as operations that have different behaviors? And yet, one of those will fade perfectly as you reduce the alpha of the color and the other will start showing overdraw.
The implications of doing this the other way around should take into account being able to detect glyph overlap in the text rendering code - or to do it in a way that naturally avoids the overdraw. The rendering code has access (or is closer to having access) to the tools to figure this out, but it is difficult if not impossible for the developer to do.

Not sure how much of a problem this is in the real world. Doing this performantly by default with the option to switch to a save layer based solution seems like the way to go.

One could say the same about paths. How often do they overlap? And yet we protect them from overlap overdraw because that is less surprising to the developer.

Hi, we face this issue with Arabic, which is unacceptable behavior as our app targets the Gulf states. Native iOS and Android platforms don't have this issue.


changelogger - CLI Tool for creating consistent and committable changelog entries

Maybe the changelogger (https://github.com/churchtools/changelogger) can be included in ddev?

Thanks for the suggestion. What would you do with it if it were included? Where would you include it, in the web container?
Anyway, please say more about how you'd like to use it and how it would affect your workflow.

Didn't get a response from you @fschmittlein so I'm going to close this for now, and happy to continue the conversation and/or reopen this issue, but it's really important for you to explain why you would want this change.


Updating to reddit search 1.3.0 api...

Description

Added new detail view
Added new Dropdown control in search to handle the sorting

Screencast

Checklist

✅ I read the extension guidelines
✅ I read the documentation about publishing
✅ I ran npm run build and tested this distribution build in Raycast
✅ I checked that files in the assets folder are used by the extension itself
✅ I checked that assets used by the README are placed in the media folder

Great catches. 👍


chore: prepare for release 3.0.2

Summary

prepare for release 3.0.2

Test plan
Issues

Coverage remained the same at 98.142% when pulling 445572ae34a8da863cb581f114bb44e224809200 on prepare3.0.2 into b6d3119a0e12ede0f0ccb34cf1cd4d424a985513 on master.


Support for Summarization models

Hi,
I would like to ask if this tool works with Seq2Seq models fine-tuned for summarization like BART or T5. Or if you plan to add this in the future. Thanks!

me too

Me too plz! I already open an issue on Captum too. Thanks!

I'm looking into this at the moment, it's kind of a tricky one to reason around because Seq2Seq models process one token at a time so the explanations would need to be calculated for each generated token with each new addition to the sequence accounted for, I'll give it a look and see if it can be done.


Rename the user jason in Bookinfo example

Following https://github.com/istio/istio.github.io/pull/1035/files/ce336d1d49f9c815932736dc3069eeec47f9ad12..9fd83e411e78fd7d2da44cfa032fc622545f94a5#r172068387,

Maybe use a name other than jason, since it gets confusing relative to json IMO.

I would consider to use tester, or JohnDoe.

shall we replace it with "freddy" ?

Its too late to change now.. its out in th web..


Air Quality

🛠 Issue (Number) 1801
Description

Correcting  responsiveness
Type of change
Fixing Bug
Checklist:
The responsiveness of the header at mobile view is fixed

@TusharKesarwani please review this

You should link your issue as #1801


feat: expose paho tls_insecure_set(bool)

Resolves #227
Adds the tls_insecure kwarg to Client __init__(). If set, the value is forwarded directly to the Paho tls_insecure_set() function.

Hi Bob, thank you for opening this pull request. :)
LGTM! A good showcase of a nice and self-contained first PR. It does decrease our test coverage but I'll allow it. I'll merge this PR as is.
Thank you for your contribution to asyncio-mqtt. :+1:


Non-recoverable error caused caused by pasting in UI

Problem Description
Shift left clicked a machine to copy, then right clicked a machine to electric engines
The mod Factory Planner (2.0.16) caused a non-recoverable error.
Please report this error to the mod author.
Error while running event factoryplanner::on_gui_click (ID 1)
factoryplanner/backend/data/ModuleSet.lua:178: bad argument #1 of 2 to 'pairs' (table expected, got nil)
stack traceback:
[C]: in function 'pairs'
factoryplanner/backend/data/ModuleSet.lua:178: in function 'get_effects'
factoryplanner/backend/data/Machine.lua:80: in function 'summarize_effects'
factoryplanner/backend/data/Machine.lua:110: in function 'update_recipe_effects'
factoryplanner/backend/calculation/solver.lua:120: in function 'generate_floor_data'
factoryplanner/backend/calculation/solver.lua:273: in function 'generate_factory_data'
factoryplanner/backend/calculation/solver.lua:229: in function 'update'
factoryplanner/util/clipboard.lua:57: in function 'paste'
factoryplanner/ui/main/production_handler.lua:113: in function 'handler'
factoryplanner/ui/event_handler.lua:169: in function <factoryplanner/ui/event_handler.lua:121>
Reproduction
Start new game, used matrix, started a calculator for starter 4 sciences, 5 logi/con bots per min, 2 ports per min.
Copy and paste Machines set Assemblere 2, 1 Speed Module2; 1 Prod Module 2, shift copy that, paste onto machine for electric motors, crash.

This seems to come from having modules in machines they arent supposed to be in as a result of copy/paste


Add DecimalObject value object library

has been battle tested the last year inside larger e-commerce applications.
PHP 8 ready

Thanks!


Add mage2tv/magento-cache-clean to Magento2 images

✔ Acceptance Criteria

The image comes with magento-cache-clean already installed in its own directory (not global installed nor installed on the project level)
cache-clean exists in $PATH and automatically runs cache-clean.js, passing any flags passed to it.

Information about cache-clean on Docker: https://github.com/mage2tv/magento-cache-clean/blob/master/doc/docker-and-vm.md


Parallelize part of verify deps

It goes from 13s to 5s for the whole program execution on the crev repository.
time cargo crev verify deps
real	0m13,009s
user	0m13,105s
sys	0m0,752s

time ../target/release/cargo-crev crev verify deps
real	0m5,069s
user	0m13,192s
sys	0m0,739s

Most of the gain comes from executing in parallel the geiger counts.
This PR brings also a big refactoring to separate the verification process from its display (one of the goals being to then improve the display)

Why does it still have conflicts? :(

Why does it still have conflicts? :(

I don't know. I'll reset my repo from yours once it's merged.

No more conflicts


Improve username behavior

Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[x] Tests pass
[x] Appropriate changes to README are included in PR

@googlebot I signed it!

@googlebot I signed it!

@googlebot I fixed it.

@googlebot I fixed it.

@googlebot I fixed it.

done


Add support for rendering to a mipLevel of RenderTarget on WebGL 2

see the API / WebGPU implementation here: https://github.com/playcanvas/engine/pull/7051
it might need these to be utilized:
    gl.texParameteri(gl.TEXTURE_2D, gl.TEXTURE_BASE_LEVEL, 0);
    gl.texParameteri(gl.TEXTURE_2D, gl.TEXTURE_MAX_LEVEL, 2);
    gl.texParameteri(gl.TEXTURE_2D, gl.TEXTURE_MAX_LOD, 2);

related issue: https://github.com/KhronosGroup/WebGL/issues/3614
I tried to implement it but without success, the PIX capture shows that we render to level 1 as set up, but when sampling the texture to display it on the screen, only level 0 was somehow exposed. The above parameters didn't seem to make any difference.
Note: we create top level using texImage2D, and then create full chain using generateMipmap - it's possible we need to create the whole chain using texImage2D or texStorage2D.

Also note that the WebGPU implementation only handles rendering to Mipmap. The ultimate goal is to be able to write a custom mipmapper (specifically to generate mip versions of a depth texture). For this we need two parts:

rendering to a mipLevel
a way to sample from a single specified level (or a range). This is to avoid an issue of reading and writing uses the same texture warning - we need to exclude this on a per level.

For WebGPU, we need to create a custom view with some levels. For WebGL we need to use this texParameteri calls from the description.
Note that we could avoid writing a public API for this, as that could be tricky, and implement this under the hood only. WebgpuMipmapRenderer effectively does it already.


Improved support for overlapping path nodes

The visual glitchyness might be desirable for decoration.
Having to deal with a unlimited overlap for path nodes will get annoying, especially when it's mostly unused..

An idea for the API might be to create path node set class with a very similar api to normal path nodes, to reduce friction as much as possible.

The order in which paths are saved/loaded in the file might effect the jank, so perhaps that one would have to be made consistent.


Media File can't contains word src

Based on this line, word src, make https://github.com/enterspeedhq/enterspeed-source-umbraco-cms/blob/639da4d41d7d8abd5729a6e200aedf290994ffdc/src/Enterspeed.Source.UmbracoCms.V9/Extensions/MediaExtensions.cs#L15 that any object containting this word will be parsed and potentially throw exception if it is not crop image object :)
Example name: code-src02.svg :)

This has been fixed. Closing.
@bielu


better handling of connectionTimeout especially on commit

as connectionTimeout seams to be a problem sometimes ...

log a speaking exception to inform user
try to recommit nonces, if first commit fails (with maybe doubled connection timeout?!)

How is it possible to change the timeout value - I just get the message
Nonce was committed to pool, but not confirmed ...
caused by connectionTimeout, currently '6 sec.' try increasing it!

try e.g. 'connectionTimeout=18000' in jminer.properties
https://github.com/de-luxe/burstcoin-jminer/wiki/configure-jminer.properties#connectiontimeout-default12000

Using burstcoin-jminer-0.4.4-SNAPSHOT>java -jar -d64 -XX:+UseG1GC burstcoin-jminer-0.4.4-SNAPSHOT.jar from the wallet pressing start miner
the file jminer.properties is updated with connectionTimeout=6000 even though I have changed it to 18000

you still have timeout exceptions with connectionTimeout of 18sec. ?
pool server must be under heavy load ... the miner itself can not really do something against that ... witch pool are you using? did you try to use another pool?

I am using burst.ninja and getting this message
2016-04-09 01:19:10.449  WARN 3672 --- [  networkPool-1] b.j.c.n.task.NetworkSubmitPoolNonceTask  : Nonce was committed to pool, but not confirmed ... caused by connectionTimeout, currently '18 sec.' try increasing it!
But I have 2 issues as the value in the property-file is changed by the software to 6000 if I start the miner from the wallet, ´so currently I hvae to start ifrom a prompt to be able to change it to 18000

guess you are talking about the windows client from daWallet (it is a 3rd party software and not the official wallet) ... if his software overwrites manual changes in jminer.properties, i can not do anything against that ... same for burst.ninja server ... the miner can only inform you, if pool response was not received .... not do anything to fix that ... sry.

issue ... continue using prompt to start miner
issue ...  increase timeout even more or switch to another pool or go with that errors from time to time.

Hi
Thanks for taking the time to answer.
if daWallet is 3 part, where can I find the official wallet for BURST ?
Looking at the current development progress it looks to me like the
BURST is a dying currency
I have switched to the solo miner atnd will see how that works,
currently the mining reward for 2 days have been about 40 cents for 3
days with 2 TB
Best regards
Thorvald
Den 09-04-2016 kl. 02:04 skrev luxe:

guess you are talking about the windows client from daWallet (it is a
3rd party software and not the official wallet) ... if his software
overwrites manual changes in jminer.properties, i can not do anything
against that ... same for burst.ninja server ... the miner can only
inform you, if pool response was not received .... not do anything to
fix that ... sry.

issue ... continue using prompt to start miner
issue ... increase timeout even more or switch to another pool or
go with that errors from time to time.

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/de-luxe/burstcoin-jminer/issues/7#issuecomment-207655470

--
Thorvald Aagaard
krydservej 33
4040 Jyllinge
http://www.aalborgdata.dk
http://www.netbridge.dk
http://www.thorvald.dk
Mobil : 22 99 55 25

The org. Wallet is a client/server application, where GUI is only running in Browser.
You can find it on bitcointalk announcement https://bitcointalk.org/index.php?topic=731923.0
daWallet made a windows client, including org. wallet and additional software from burst community members, with the goal, to make it more easy to start with burst. There is nothing bad about that.
But while making things more easy, some details may get lost/obfuscated.
A new burst wallet version is currently under development, burst will surely not die.
With 2TB you could try to use cpu miner, too. e.g. https://bitcointalk.org/index.php?topic=1323657.msg14452867#msg14452867

Now I have been solomining for 20 hours and received nothing, is that
expected, or am I just unlucky ?
Den 09-04-2016 kl. 22:08 skrev luxe:

The org. Wallet is a client/server application, where GUI is only
running in Browser.
You can find it on bitcointalk announcement
https://bitcointalk.org/index.php?topic=731923.0
daWallet made a windows client, including org. wallet and additional
software from burst community members, with the goal, to make it more
easy to start with burst. There is nothing bad about that.
But while making things more easy, some details may get lost/obfuscated.
A new burst wallet version is currently under development, burst will
surely not die.
With 2TB you could try to use cpu miner, too. e.g.
https://bitcointalk.org/index.php?topic=1323657.msg14452867#msg14452867
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/de-luxe/burstcoin-jminer/issues/7#issuecomment-207846582

--
Thorvald Aagaard
krydservej 33
4040 Jyllinge
http://www.aalborgdata.dk
http://www.netbridge.dk
http://www.thorvald.dk
Mobil : 22 99 55 25

Sry, just received 90 BURST for the solo mining - That equals 10 $ for
forging 2 TB in one year. Is that expected ?
2016-04-10 12:44 GMT+02:00 Thorvald Aagaard<EMAIL_ADDRESS>
Now I have been solomining for 20 hours and received nothing, is that
expected, or am I just unlucky ?
Den 09-04-2016 kl. 22:08 skrev luxe:
The org. Wallet is a client/server application, where GUI is only running
in Browser.
You can find it on bitcointalk announcement
https://bitcointalk.org/index.php?topic=731923.0
daWallet made a windows client, including org. wallet and additional
software from burst community members, with the goal, to make it more easy
to start with burst. There is nothing bad about that.
But while making things more easy, some details may get lost/obfuscated.
A new burst wallet version is currently under development, burst will
surely not die.
With 2TB you could try to use cpu miner, too. e.g.
https://bitcointalk.org/index.php?topic=1323657.msg14452867#msg14452867
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/de-luxe/burstcoin-jminer/issues/7#issuecomment-207846582
--
Thorvald Aagaard
krydservej 33
4040 Jyllingehttp://www.aalborgdata.dkhttp://www.netbridge.dkhttp://www.thorvald.dk
Mobil : 22 99 55 25

--
Thorvald Aagaard
krydservej 33
4040 Jyllinge
http://www.netbridge.dk
http://www.thorvald.dk
Mobil : 22 99 55 25

You can use reward calculators to get the expected http://forum.burst-team.us:4567/topic/32/burst-mining-reward-calculators-online/2
You surely did not receive 90 burst from solo mining ... on solo you find a hole block or you get nothing.

There is a new pool you could try to solve your connectionTimeout issues ...
URL: pool.burst-team.us:8124
Reward Assignment address: BURST-32TT-TSAC-HTKW-CC26C


primitives: use alloy Header struct

Should close https://github.com/paradigmxyz/reth/issues/10687
Blocked by:

https://github.com/alloy-rs/alloy/pull/1235
https://github.com/alloy-rs/alloy/pull/1236
https://github.com/alloy-rs/alloy/pull/1237
https://github.com/alloy-rs/alloy/pull/1238

I think that we should revise the types in alloy to transform all u128 to u64 to limit the conversions and be fully aligned between alloy and reth. Maybe we could do that in a follow up PR in alloy if there are no limitations about this on alloy side?

the casts are indeed excessive and we should change them in alloy, because only u64 are useful here
wdyt @klkvr

@mattsse Yeah related https://github.com/alloy-rs/alloy/issues/1241 cc @greged93

the casts are indeed excessive and we should change them in alloy, because only u64 are useful here

agreed, we should definitely unify all of this, there's no point in u128 as revm uses u64 anyway, wondering if there's a spec for gas value type?

the casts are indeed excessive and we should change them in alloy, because only u64 are useful here

agreed, we should definitely unify all of this, there's no point in u128 as revm uses u64 anyway, wondering if there's a spec for gas value type?

@klkvr If you validate https://github.com/alloy-rs/alloy/issues/1241 (please can you comment there to be sure this is accepted), me or @greged93 can start working on this :)

@klkvr @mattsse In my opinion:

We have way too many conversions here (it's not avoidable in the current state). In my opinion we should first merge this PR to get through this big part and then directly after follow up on https://github.com/alloy-rs/alloy/issues/1241 to have a clear consensus on the types u64 vs u128.
Then we should also do a follow up to remove SealedHeader from the repo and use the alloy type Sealed<Header> in order to remove the unnecessary lines of code to convert a Sealed<Header> to SealedHeader each time (but if we do it in this PR it will be way too long).

need help fixing merge conflicts @tcoratger ? all for removing redundancy, think it will be brilliant

need help fixing merge conflicts @tcoratger ? all for removing redundancy, think it will be brilliant

@emhane No worries, I think I can handle it. Can you provide just an overview review to confirm that everything (the approach, the conversion handling...) is good so that directly after solving conflicts we can merge and avoid further conflicts?

@emhane @mattsse Should be good now, can we merge asap? so that we don't have to handle additional conflicts because a lot of files are involved so that this is very easy to generate new conflicts :)


Control doesnt work

A W S D Jump doesnt work, only the mouse and the camera(im using the example body)

Just add the missing buttons
Edit -> Project settings -> Input manager
https://docs.unity3d.com/Manual/class-InputManager.html

thanks
On Thu, 5 Aug 2021 at 02:19 Artanisky @.***> wrote:

Just add the missing buttons
Edit -> Project settings -> Input manager
https://docs.unity3d.com/Manual/class-InputManager.html
[image: image]
https://user-images.githubusercontent.com/32029918/128295032-6e371418-28db-4258-9bab-e4f173e1821a.png
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Olezen/UnitySourceMovement/issues/18#issuecomment-893172569,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVBWP7LXYLU2TW7ZFIW4MHLT3INNPANCNFSM5BL5Y7UA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.


Update AGP to 8.3.0

Updates to AGP 8.3.0.
This required a couple of changes due to AGP 8.3.0 being a bit stricter with how dependencies are resolved.
f46e506:
Previously, the Roborazzi ScreenshotHelper utilities were in :core:testing. However, this module is brought in for adding utilities to both unit tests and instrumentation tests.
This change was needed due to the following:

ScreenshotHelper calls into Robolectric utilities
Therefore, :core:testing had a dependency on Robolectric, which meant that Robolectric was being added into instrumentation tests
This brought in a jre guava was being brought into instrumentation tests, which shouldn't be there

0610407:
kotlinx-coroutines-guava depends on jre guava, which meant that :sync:work depended on jre guava in the instrumentation tests. Bumping this to a later android guava avoids a jre guava in instrumentation tests again. I had to add this as a main implementation, otherwise the error from AGP 8.3.0 returned.
1d91231:
A follow-up from investigating more - :sync:work doesn't use the kotlinx-coroutines-guava dependency in tests anyway, so it is cleanest to just remove it.

@alexvanyo AGP 8.3 is stable now.

It will throw this error:
> Task :core:designsystem:checkDemoDebugAndroidTestDuplicateClasses FAILED
ASM Instrumentation process wasn't able to resolve some classes, this means that
the instrumented classes might contain corrupt stack frames. Make sure the
dependencies that contain these classes are on the runtime or the provided
classpath. Otherwise, the jvm might fail to load the corrupt classes at runtime
when running in a jvm environment like unit tests.

Classes that weren't resolved:
> androidx.compose.animation.tooling.ComposeAnimatedProperty
> com.google.common.util.concurrent.ListenableFuture
> androidx.window.extensions.embedding.SplitPlaceholderRule
> androidx.window.extensions.embedding.ActivityRule
> androidx.window.extensions.embedding.SplitPairRule

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':core:designsystem:checkDemoDebugAndroidTestDuplicateClasses'.
> A failure occurred while executing com.android.build.gradle.internal.tasks.CheckDuplicatesRunnable
   > Duplicate class com.google.common.util.concurrent.ListenableFuture found in modules guava-31.1-jre (com.google.guava:guava:31.1-jre) and listenablefuture-1.0 (com.google.guava:listenablefuture:1.0)

     Go to the documentation to learn how to Fix dependency resolution errors.

Thanks for the reminder @lihenggui , updating PR with 8.3.0 to see what failures CI reports.

Thanks for doing this @alexvanyo. Do you have any more info you can share on "AGP 8.3.0 being a bit stricter with how dependencies are resolved"? I'm guessing that it's stricter about detecting duplicate classes (e.g. ListenableFuture), but are there other changes?

The behavior change for library modules is reverting to 8.2 behavior in 8.4.0-alpha12, and this revert will also be cherry-picked to 8.3.x.


bubble sort code in Sorting/Bubble Sort/Python

Assign me

Assigned to @ankit6868
@jaspriya12 please note that priority is given on a first-come, first-serve basis if you are not new to the repo.
Feel free to find or create more issues that suit you!

check pr @deepansha-singh


Enclose namesrvAddr in example of mqadmin tool by quotation marks

The help info of mqadmin (clusterList for example) like this:

$bash mqadmin help clusterList
OpenJDK 64-Bit Server VM warning: ignoring option PermSize=128m; support was removed in 8.0
OpenJDK 64-Bit Server VM warning: ignoring option MaxPermSize=128m; support was removed in 8.0
usage: mqadmin clusterList [-c ] [-h] [-i ] [-m] [-n ]
-c,--clusterName    which cluster
-h,--help                Print help
-i,--interval       specify intervals numbers, it is in seconds
-m,--moreStats           Print more stats
-n,--namesrvAddr    Name server address list, eg: <IP_ADDRESS>:9876;<IP_ADDRESS>:9876

I found that the example of namesrvAddr field is missing quotation marks, so a beginner may encounter such error message:

$bash mqadmin clusterList <IP_ADDRESS>:9876;<IP_ADDRESS>:9876
bash: <IP_ADDRESS>:9876: command not found

In my option, namesrvAddr should be enclosed by '', in the help info of mqadmin and documents. That would be more friendly to new beginners.

Can you assign this to me?
I have created two PRs on rocketmq repository and rocketmq-site repository


TRestClient is a component already registered starting Delphi Seattle

Hello,
TRestClient is now registered on all Delphi version starting from Seattle.
Do you plan to rename your component ?

Thank you for the report @stephanewierzbicki
I don't think we have any other options, we'll have to rename the component.
Do you know what is the unit name where Delphi TRestClient is declared on Seatlle? it has some namespace?

Hello, my friend, follows a version I made to use with delphi 10.2, I just changed the TRestClient to TRestClientt, and I also changed some parameters, but if you want you can use 100% functional I'm using in projects in production.
delphi_rest_client_api.zip


Support for tagged measurements

Add support for tagged measurements.
Tagged measurements consist of tags, which are a set of name=value tag pairs that describe the particular data stream. Tags are equivalent to source in the previous data model.
Metrics
Introduces the following tagged metrics:

Metric
Tags
Example

rails.request.total
controller, action, format
controller=articles,action=show,format=json

rails.request.status
status
status=200

rails.request.method
method
method=POST

rails.view.render
view, identifier
view=template,identifier=welcome:index.html.erb

rails.job.*
adapter, job
adapter=Sidekiq,job=HardWorker

rails.mail.*
mailer
mailer=UserMailer

Note: time and p95 metrics omitted from table for brevity. They will have the same tags as their non-timed and non-percentiles counterparts.
The remaining metrics will also be tagged, however the top-level tag dimensions will only be the user provided defaults.
Configuration
In addition to the configuration options introduced in librato-rack, you can also set top-level tags via configuration file:
Configuration File
# config/librato.yml
staging:
  user<EMAIL_ADDRESS>  token: "foobar"
  tags:
    service: "metrics-web"
    environment: "staging"
    node: 808

Requires https://github.com/librato/librato-rack/pull/54
README and code documentation will be updated in a separate PR.

@nextmat thanks for catching ActionMailer subscription break, fixed and added a receive test in cb49d328cf357c9873ccc628f15608a2c1e63137. also addressed feedback, PTAL.

LGTM 🤘


AL crashes when i try to make Navigation Page

While I creating Navigation page my AL crashes. May be this is not because of this page type, but the problem exists.

@dkatson does this bug always reproduce or was it a one time thing which stopped happening after you reloaded vscode?
I tried various combinations similar to what you have in the screenshot and I cannot reproduce the bug.
Could you try and provide us with some steps or whole source file which causes this issue?


Failure to cast back to &str from &[u8]

#235 adds the test src/test/cbmc/Strings/copy_empty_string_by_intrinsic_fixme.rs, which has this chunk:
        let dest_slice : &[u8] = from_raw_parts(dest, l);
        let dest_as_str : &str= str::from_utf8(dest_slice).unwrap();
        assert!(dest_as_str.len() == l);

With failures verification with:
[...copy_empty_string_by_intrinsic.assertion.2] line 1035 unreachable code: FAILURE
[...copy_empty_string_by_intrinsic.assertion.1] line 1037 a panicking function std::result::unwrap_failed is invoked: FAILURE
[...copy_string.assertion.2] line 28 assertion failed: dest_as_str.len() == l: FAILURE

You might want to use https://doc.rust-lang.org/std/str/fn.from_utf8_unchecked.html
https://doc.rust-lang.org/std/str/fn.from_utf8.html - the conversion we are using is expected to fail if the bytes are not valid unicode.

@jaisnan Please check if this one is still reproducible.

This is still reproducible and is due to a missing std function. See this comment for how we plan on addressing this issue: https://github.com/model-checking/kani/issues/576#issuecomment-1095295801.


Fixed small bugs in input generation scripts, updated configs

@RigbeGW I think you know this PR best. Could you do a review as we get notifications about open PRs and aim to not have long dragging PRs


feat: add unlock_account to the provider

What I did
Implemented support for unlocking account in ganache

fixes: APE-487
How I did it
How to verify it
Checklist

[ ] Passes all linting checks (pre-commit and CI jobs)
[ ] New test cases have been added and are passing
[ ] Documentation has been updated
[ ] PR title follows Conventional Commit standard (will be automatically included in the changelog)

Nice. I love how the plugin system basically allows implementing this feature through 3 separate RPC calls
Needs some QA that this feature works similarly enough to Hardhat/Anvil so that it can be used interchangably

Added a test regarding this.

https://github.com/ApeWorX/ape-ganache/pull/19 ci issues will be fixed after merging this one as i solved the problem in this one. can we merge this? @fubuloubu @unparalleled-js


Set up for OAuth2RestTemplate not documented

Out of the box, the X-B3-TraceId and X-B3-SpanId headers are not set on requests made with the OAuth2RestTemplate.  The workaround for this is to add the TraceRestTemplateInterceptor to the list of OAuth2RestTemplate interceptors.  Until out-of-the-box support for OAuth2RestTemplate is provided, the Spring Cloud Sleuth documentation should note that the TraceRestTemplateInterceptor must be added to the OAuth2RestTemplate.

That's actually interesting that this is not working out of the box. We already add interceptors to all RestTemplates - https://github.com/spring-cloud/spring-cloud-sleuth/blob/master/spring-cloud-sleuth-core/src/main/java/org/springframework/cloud/sleuth/instrument/web/client/TraceWebClientAutoConfiguration.java#L61-L81

Do you think you could push a sample to Github of how you set up a project with the @OAuth2RestTemplate in such a way that things don't work? That way it will be easier for me to analyze what's wrong

Hi Marcin,
Sorry for the delayed response -- was out of the office.  Let me see what I can get together.
Thanks!

Closing due to inactivity

@marcingrzejszczak
Want to reopen this ticket, because I've faced with this issue too.
I've solved with next code:
    @Bean
    public UserInfoRestTemplateCustomizer userInfoRestTemplateCustomizer(
            TraceRestTemplateInterceptor traceRestTemplateInterceptor) {
        return restTemplate -> {
            List<ClientHttpRequestInterceptor> interceptors = new ArrayList<>(
                    restTemplate.getInterceptors());
            interceptors.add(traceRestTemplateInterceptor);
            restTemplate.setInterceptors(interceptors);
        };
    }

So you're saying that for some reason the TraceRestTemplateInterceptor doesn't get injected into the OAuth2RestTemplate ? That's super strange. @rwinch, @dsyer  - are OAuth2RestTemplate's interceptors somehow separated from the "traditional" RestTemplate interceptors? In other words, do I have to do sth special for my custom RestTemplate interceptor to get registered in my OAuth2RestTemplate

@marcingrzejszczak,
TraceRestTemplateInterceptor  works good with OAuth2RestTemplate using my solution.
So now my requests for instance client->user-service [solution added here]->auth-service to security.oauth2.resource.user-info-uri has the same X-B3-TraceId, without config only client and user-service has the same X-B3-TraceId, but auth-service different.

Yeah using your solution it works fine, but the idea was that that TraceRestTemplateInterceptor gets injected automatically - https://github.com/spring-cloud/spring-cloud-sleuth/blob/master/spring-cloud-sleuth-core/src/main/java/org/springframework/cloud/sleuth/instrument/web/client/TraceWebClientAutoConfiguration.java#L63-L83 . In theory all rest templates should have it injected. For some reason it seems that the OAuth2RestTemplate is not in that collection. BTW @Triggerself could you put a breakpoint here - https://github.com/spring-cloud/spring-cloud-sleuth/blob/master/spring-cloud-sleuth-core/src/main/java/org/springframework/cloud/sleuth/instrument/web/client/TraceWebClientAutoConfiguration.java#L78 and see if your OAuth2RestTemplate is there?

@marcingrzejszczak,
I see only my RestTemplate, which was configured this way:
    @Bean
    public RestTemplate restTemplate(RestTemplateBuilder builder) {
        return builder.build();
    }

There is no OAuth2RestTemplate there.
P.S
OAuth2RestTemplate class extends RestTemplate and implements OAuth2RestOperations

That's what I suspected... Meh. @rwinch @dsyer any ideas? Maybe that OAuth2RestTemplate is created later than this interceptor injection gets executed?

@Triggerself Have you created the OAuth2RestTemplate as a bean?

@marcingrzejszczak,
No, it's created in backgroud here:
ResourceServerTokenServicesConfiguration:RemoteTokenServicesConfiguration:UserInfoTokenServicesConfiguration[constructor with contructor autowired UserInfoRestTemplateFactory] by calling restTemplateFactory.getUserInfoRestTemplate()

That's why it's not working out of the box. @dsyer suggested that, in Sleuth, we could

just provide a customizer (That's the supported extension point in Spring Boot).
UserInfoRestTemplateCustomizer works for this precise instance (that isn't a bean)

So, at the end the issue will be solved by providing UserInfoRestTemplateCustomizer as I suggested?

Not necessarilly UserInfoRestTemplateCustomizer but some customizer. I don't know yet how to do it exactly, but that's good that you've provided a workaround for this

As far as I researched UserInfoRestTemplateCustomizer using for customizing OAuth2RestTemplate, because list of UserInfoRestTemplateCustomizer is used in DefaultUserInfoRestTemplateFactory:getUserInfoRestTemplate().
	@Override
	public OAuth2RestTemplate getUserInfoRestTemplate() {
		if (this.oauth2RestTemplate == null) {
			this.oauth2RestTemplate = createOAuth2RestTemplate(
					this.details == null ? DEFAULT_RESOURCE_DETAILS : this.details);
			this.oauth2RestTemplate.getInterceptors()
					.add(new AcceptJsonRequestInterceptor());
			AuthorizationCodeAccessTokenProvider accessTokenProvider = new AuthorizationCodeAccessTokenProvider();
			accessTokenProvider.setTokenRequestEnhancer(new AcceptJsonRequestEnhancer());
			this.oauth2RestTemplate.setAccessTokenProvider(accessTokenProvider);
			if (!CollectionUtils.isEmpty(this.customizers)) {
				AnnotationAwareOrderComparator.sort(this.customizers);
				for (UserInfoRestTemplateCustomizer customizer : this.customizers) {
					customizer.customize(this.oauth2RestTemplate);
				}
			}
		}
		return this.oauth2RestTemplate;
	}


Cairo Native Stress Binary

related to #282
Implement cairo-native-stress binary, which loops n times over the following sequence:

Generate an unique contract. Preferably in memory.
Test the contract with AOT, this implies:

Compile it
Cache it
Run it

The output of this binary should answer the following questions:

how many contracts until a segmentation fault?
how much memory a cached program occupies?

Later on, we should test optimized versions of the cache, like:

cache with eviction
cache with write to disk

I'd love to have more details on this @JulianGCalderon

Hi @zarah-s, i'm sorry. This issue had already been worked on by #683 and #686 , we forgot to close it when we merged those.


Thanks and a couple of suggestions

Thanks for this and your other awesome journal templates. I did not think we would have so many Quarto template options available for political science journals this quickly. Very exciting!
I just wanted suggest a couple of things for the documentation. First, I was pleasantly surprised to find that the template plays nicely with ggplot and popular table packages that tend to be more html oriented like kableExtra and gt. I think it might be worth including examples of how to incorporate these into your apsr.qmd file since the whole idea behind Quarto is that you can easily integrate your R code and visualizations with your text.
#| label: ggplot_figure
#| fig-cap: My ggplot Scatterplot
#| echo: false
#| message: false

library(ggplot2)

ggplot(mpg, aes(displ, hwy, colour = class)) +
  geom_point()

#| label: my_gt_table
#| tbl-cap: "My gt Table"
#| echo: false
#| message: false

library(gt)

head(mtcars) |> gt()

Also, I found the readme to be slightly confusing wrt the classoption parameter. It seems like the arguments for classoption are twocolumn, singlespace, doublespace and onehalfspace but the bullet points make it look like blind/nonblind and citation style might also be subsumed under classoption.
Thanks again!

Thank you. Some additions:

The example document now explicitly demos using ggplot2.
The example document now shows using kableExtra
I've updated the readme to be a bit more verbose re classoptions.

Let me know if you think this fixes your concerns.

Looks really good. Thanks for making those updates. I wonder if you might want to set echo to false for the Figure 3 ggplot code chunk since it is running off the page, but I guess it does show the user how you can mix code with text? Probably a matter of taste.

Fair point, it's a little bit of a mix between showing and telling for templates like this. Added a default echo: false for the document, since the template is probably sufficient to show what to do.


does work in compiling steams

Hey, first off nice package, it was just what I was looking for!
But it looks like it only works on "static" files and not with content coming from other pipes like a jade compiler:
return gulp.src('src/index.jade')
    .pipe(jade({pretty: true}))
    .pipe(prefix(prefixUrl, null, '{{'))

Gives the error Error: ENOENT, open '/path/to/project/src/index.html'

I've created PR that fix this. https://github.com/007design/gulp-prefix/pull/8


add x86_64 inline asm to direct_threading and optimized_direct_threading

cargo criterion results on Intel 7600k @ 4.8Ghz:
direct threading time: [14.375 ms 14.376 ms 14.378 ms]
optimized direct threading time: [10.148 ms 10.155 ms 10.163 ms]
resubmitted with signed commit

@tipo159 Not sure if you've seen this, but I'd love any feedback, if possible. Thanks!

Thank you for your pull request.


Escape & Enter triggering twice on the PS/2 keyboard

Self reporting another issue: When you press the escape key on the PS/2 keyboard quickly, it seems to double trigger the escape.
This also happens with the enter key, but only while BBC BASIC is in the middle of writing characters.
My guess the problem is something to do with the keyboard interrupt handler, and how it handles the release flag.

Found the issue. The LCD routine was taking so long that the release scan code from the keyboard would pass.
Turns out you can have interrupts while characters are printing. Updated OSRDCH to remedy this.


Problem with cocoapods 0.36 use_framework!

After update cocoapods to version 0.36 and use Framework. I found that AFOauth2Manager cannot import AFNetworking library to use in code. Xcode show error in AFOauth2Manager code where import AFNetworking code.

Same here with 0.37.

Same here, AFOAuth2Manager and use_framework! don't work together, I spent hours trying different config / header search paths / framework search paths without success.

yep this is making it difficult to use in swift

I fixed this by changing the following imports

#import "AFURLRequestSerialization.h"
#import "AFHTTPRequestOperationManager.h"

to

#import <AFNetworking/AFURLRequestSerialization.h>
#import <AFNetworking/AFHTTPRequestOperationManager.h>

This pull request fixes the problem https://github.com/AFNetworking/AFOAuth2Manager/pull/100/

Thank you very much @juanuribeo13 .

:+1:

:+1:

+1

I've merged in the change

Hi, I've faced this issue when using latest available release (2.2.0). Could you please release version with this fix?


[FEATURE] Support workflow grouping

The frontend plugin's mental model for a "workflow" is evolving into several individual "launches" (in other words, just separately created/provisioned workflows) all falling under the same end goal of creating a single, final, application. This allows for a simpler rapid prototyping experience, and lets users view and/or test out older launches to compare performance, review previous configurations, previously created resources, etc. This backend plugin is currently building towards a one-and-done model of building a workflow without taking into account any hierarchy or context that could group workflows together under a single "application" or "final workflow" umbrella.
In its simplest form, this just means having an extra id or tag associated to a workflow that allows them to be grouped together. It is most complex form, this means introducing a new data model that would contain x number of workflows. The frontend plugin could technically handle all of this as well by adding and managing metadata tags when creating and reading workflows. But, this could lead to some potential performance bottlenecks, tricky frontend-only edge cases, and leaves out backend-only users who may want simple mechanisms for grouping workflows together. Or perhaps this wouldn't be very useful from a backend-only perspective since it would less likely involve rapid prototyping user behavior.
Curious to hear everyone's thoughts.

I wonder if "Launches" can be a separate object rather than a variant of a provisioned workflow.
Here's what I am thinking in terms of mental model:
A workflow is a working file for users can create and edit. OpenSearch keeps track of the revisions of workflow as users are editing the workflow, so that users can recall and potentially restore to certain point.
A launch involves tracking status of a infrastructure provisioning, which has reference of resources and which workflow (and which workflow revision) the user trigger it from.
So, users can see all of launches in the cluster. Users can also go into a workflow and see a list of launches triggered from that particular workflow.

@dbwiddis  / @owaiskazi19  / @joshpalis / @amitgalitz any thoughts on the above?

Additional use cases may involve iterating over a workflow by swapping out a model, for example, but still using created resources from a previous run, e.g., a knn index. This would mean having shared resources across launches.

When I have experimented with setting up cloud-based workflows, I've always enjoyed the ability to create a "resource group" or equivalent that lets me easily isolate those experiments and enable a "delete all" (or at lease browse-all) functionality when cleaning things up at the end.   I definitely think there's a ton of value for "tags" on the backend to filter resources created.  Some applications:

workflow-id as tag allows for quick undo of a failed run
user-provided tag allows user to delete all from a series of experiments, or at least find the changes

I think grouping the different variations of a workflow makes sense, perhaps we can think of these variations as "Versions" of a workflow. Considering the different use cases:
Use Case 1: I want to perform A/B test between the different variations of a semantic search workflow.

I can deploy a version of the workflow, so that the resources are independent from other versions of workflow.
I can deploy or un-deploy a particular version, so that I can manage the resources of the cluster.
I can use the Test / Prototype tool to compare versions of the same or different workflow.

Use Case 2: I want to make small updates to a workflow without having to deploy a new set of resources.

I can make updates to an existing version of the workflow, the backend will handle updating the necessary changes, but it won't create a brand new set of resources.
If I want to compare the changes, I will need to save as and deploy the changes as a new version.

This may also aligns with the existing model versioning concept in OpenSearch's Model Registry. Love to hear everyone's thoughts on this.

Introducing a workflow grouping mechanism can be the simplest approach and most natural way to handle "versioning" and persisting of standalone resources / standalone template version / standalone state / etc. In other words, rather than making a single workflow more fine-grained such that we persist task IDs and add more logic and mapping changes to the state index / global context index, and have different optional or default query params in different CRUD APIs, we can take the opposite approach of having a hierarchical "workflow group" which simply persists a set of workflows and prevent any backend or mapping changes regarding a single workflow.
We can have different mechanisms of default workflow groups and other user-friendly interfaces similar to ML commons model groups, such that users who don't want/need to care about the grouping concept can ignore it altogether.

Closing in favor of #526


cli.Command: Argument order is changed depending on the flag set

Hello!
I'm not sure if this is the expected behavior, however the following code:
package main

import (
	"fmt"
	"os"

	"github.com/codegangsta/cli"
)

func main() {
	app := cli.NewApp()

	app.Commands = []cli.Command{
		cli.Command{
			Name:  "update",
			Usage: "update a report",
			Flags: []cli.Flag{
				cli.StringFlag{
					Name:  "filename",
					Usage: "filename",
				},
			},
			Action: func(c *cli.Context) {
				fmt.Println(c.Args())
			},
		},
	}

	app.Run(os.Args)
}

Runs differently depending on the position of the arguments passed:
$ ./main update Arg1 Arg2 Arg3 --filename test.json
[Arg1 Arg2 Arg3]

$ ./main update Arg1 --filename test.json Arg2 Arg3
[Arg2 Arg3 Arg1]

Expected behavior for me would be that when running the second command, the following should output:
$ ./main update Arg1 --filename test.json Arg2 Arg3
[Arg1 Arg2 Arg3]

It seems that the fact that the flag is in the middle is breaking the Args() order.
Thanks

@brenol definitely a bug, thank you for the report!

This appears to be due to the argument reordering that is done to try to trick the stdlib flag parser to handling commands that have arguments specified before flags (the stdlib flag library stops flag parsing as soon as it encounters the first argument). At first blush, I think supporting this behavior would require much more complicated preprocessing of flags, but I'm open to reviewing a PR addressing this. I'm almost more inclined to remove the re-ordering feature as it appears to only work in very specific circumstances (if you specify all of your arguments before you specify flags).
https://github.com/codegangsta/cli/blob/master/command.go#L104-L116

I think this supersedes #103 too -- my opinion is to remove the reordering.

Removing the ordering seems like a fine answer. I looked at this for a while today, and there's really no way to fix it without, like you said @jszwedko, a whole bunch of complicated flag preprocessing.

Fixed by #398 (requires use of the v2 branch however as the change was not backwards compatible). Let me know what you think!


internet searches are unreliable for finding our stuff

A recent mailing list thread alerted us to the problem that searching "perl 6 stderr" will not lead to our docs page at all. for that specific topic there's a result for the tablets which is helpful, but it's buried deep beneath unhelpful stuff, including the RFC about barewords from ~2004. The search engine used was duckduckgo in this example.
We might want to come up with a systematic approach for figuring out what features/topics will lead users to our docs page (or any similarly appropriate resource) and what sends the user off on a wild goose chase.

On 20.02.2017 02:56, timo wrote:

A recent mailing list thread alerted us to the problem that searching
"perl 6 stderr" will not lead to our docs page at all.

The first hit on Google is https://docs.perl6.org/routine/stderr .
Is that not the right page?

The search engine used was duckduckgo in this example.

The first hit there is the same as with Google.

We might want to come up with a systematic approach for figuring out
what features/topics will lead users to our docs page (or any similarly
appropriate resource) and what sends the user off on a wild goose chase.

Let me put up a warning sign here: One might think that SEO is an
answer, and for commercial endeavors that can command lots of manpower
this can even work.
My personal systematic approach would be "make the pages of interest
easy to find from a landing page for humans, and search engines will
follow". After all, search engines are programmed to pick up the lead of
human interest (as well as they can, of course).
I think there are various systematic things one can do.
One would be to keep track of questions, cluster them (by keywords), and
see which topics come up more often. Those that are more common are
likely to be less easy to find, so work on these. (I.e. don't do a FAQ
list, do a list of topics.)
I don't know how to keep the RTFM questions out of that list though.
Maybe don't keep them out but rate questions on a newbie-to-expert scale.
Make sure that authoritative material is easily discernible as such.
There's a big amount of historic material. For much of that, no current
authoritative material is available.
Listen if somebody complains that a given piece of information was hard
to find.
Whenever you help somebody figure out something, ask yourself where an
uninformed person would have found it.
Maybe set up a project: "Learn from the newbies". Describe the question
and the answers found, and let uninformed people tell you where they
would have looked for the answers.
FWIW :-)

I try to link to the docs whenever I blog or post on reddit. If you post on stackoverflow please do the same.

OK I see. So somebody wrote “perl 6” into a search engine and got many unrelated historical stuff. I just tried it through Tor and there many good results actually. IMO this problem will be resolved once we figure something out with the name, and then we'll be getting the freshest results (unless we go with something that is already overused like psix). As an example, you can search for 6lang now and you'll see some actual perl 6-related results plus some weak unrelated stuff (even though nobody is using it yet!). Soo… maybe we can close this for now?

Checked again, in duckduckgo one of the results on the first page is https://www.perl.org/. Yes, internet searches are indeed unreliable for finding our stuff. Closing this issue according to my previous comment.


Translate Button on Individual Messages Doesn't Show Clickable Mouse On Hover

The translate button should make the mouse a "click finger" on hover. Otherwise, users might not know it's clickable.
Alternatively, the icon change colors on hover, that might work just as well.

Hello, I would like to try to working on this issue. Could you assign it to me please? Thank you

Hi Filip,
Go ahead and fork this repo and see if you can fix the issue.
Just to let you know, this repository is not really updated anymore, since all of our resources are going into a fork of this repository, but we can definately do a PR into our more updated fork as well.
(And if you aren't already, you should try joining our discord server linked in the main readme)

It might be nice to rework this so it's a button so it's easier for UI tests to find the element.


'stop' feature in chainable methods

Hello,
I've just implemented your package and it works really well ! Thank you for that !
In my use case, it will be a good feature to add a stop() method like used in jQuery to stop and reset the fx queue. Very helpful in an async ecosystem based on events.
What do you think about this feature ?

jQuery definitely is more robust in terms of async control than this library, but if you have a conditional you can simply create your own stop function and use that to evaluate whether to advance the queue or not.  If you want to explicitly clear the queue for some reason you can set the _callbacks and _deferreds properties to empty arrays in your own stop function.  The core code is small and internally documented to help with issues like this.  In the interests of keeping this lightweight I'd rather hold off on hard-coding a stop function in the core unless/until it becomes a necessity (e.g. show me a use case scenario) and/or there is a lot of demand.


support stream shard count updates

Adds generated code and e2e tests for updating a Stream resource's shard count. Calls the separate UpdateShardCount Kinesis API.
Signed-off-by: Jay Pipes<EMAIL_ADDRESS>By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/ok-to-test

/ok-to-test
/retest

/retest


wasm: field reflection is not working

In https://github.com/dotnet/corert/blob/82299d456f24bcfc2393901cd55861824d07ac58/src/ILCompiler.WebAssembly/src/Compiler/WebAssemblyMetadataBlockingPolicy.cs#L24 field metadata is turned off and I'd like to turn it on so that this sort of code
FieldInfo[] fields = typeof(ClassForMetaTests).GetFields();`

is possible.  I'd like to first ask a question.  My understanding is that the compiler will only emit code for fields that it sees while compiling and that unseen code can be added via the rd.xml file.  In order to avoid that, which has not been tried so far in the wasm compiler and hence might have other problems, can I just add some code that uses the fields I'm interested in, and then unblock fields in the WebAssemblyMetadataBlockingPolicy and I should be good to start debugging?
Thanks

Thanks, seems to just work (GetFields at least).  Or rather it works for those types where it finds metadata which for some reason doesn't seem to include types in the test project even if I use them in code .  Need to investigate that some more as it does create the TypeMetadataNode and FieldMetadataNodes.

Some investigation.  Unsuprisingly the success of failure to find metadata in not based on the location of the class, some classes in the test assembly are fine.  Current thinking is that those classes that work have in ConstructedEETypeNode,  ISymbolDefinitionNode.Offset == 0.  wasm treats those with an Offset != 0 differently and writes out another "__REALBASE" symbol for them so we end up with something like
@__EEType_HelloWasm_Program_ClassForMetaTests___SYMBOL = internal constant i32* bitcast (i8* getelementptr (i8, i8* bitcast ([12 x i32*]* @__EEType_HelloWasm_Program_ClassForMetaTests___REALBASE to i8*), i32 12) to i32*
@__EEType_HelloWasm_Program_ClassForMetaTests___REALBASE = global [12 x i32*] [i32* bitcast (i8* getelementptr (i8, i8* null, i32 -12) to i32*), i32* bitcast (i8* getelementptr (i8, i8* null, i32 4) to i32*), i32* bitcast (i8* getelementptr (i8, i8* null, i32 1) to i32*),

Where in this case the SYMBOL symbol is 12 bytes into the REALBASE which I think is skipping some GC related fields.
When writing out the TypeMetadataMapNode I can see that for the class I'm intereted in , ClassForMetaTests the vertex has an offset of 111 and a Type.Hashcode of<PHONE_NUMBER>.  At runtime the code executes through NamedTypeRuntimeTypeHandleToMetadataHashtable.CreateValueFromKey and in here the GetKeyHashCode(key) for the passed RuntimeTypeHandle is<PHONE_NUMBER> which is match and as it looks through the entries it finds one and it has an index of 111 so that looks good, but the next thing to investigate I believe, is why
https://github.com/dotnet/corert/blob/36d23ac096e76f7454b1b44b5f2fcb894ad3bdda/src/System.Private.TypeLoader/src/Internal/Runtime/TypeLoader/TypeLoaderEnvironment.NamedTypeLookup.cs#L89-L90
is evaluating as false.

This is looking similar to https://github.com/dotnet/corert/issues/5842#issuecomment-431679942, The ExternalReferencesTable is only partially populated.  I dumped it out using the same code as before and the 111 entry is 0:
element at index 110 ptr 1036664 rel offset 1314396 and indirection is  2351060
element at index 111 ptr 1036668 rel offset 0 and indirection is  1036668
element at index 112 ptr 1036672 rel offset 1312480 and indirection is  2349152

Good progress with the investigation!
This kind of looks like there will be a problem in the object writer somewhere. You're correct that EEType nodes are special: if there's any GC information, it gets prepended right before the EEType (EETypes have GC information if they have any reference type instance fields). The symbol that represents the type is defined somewhere in the middle of the ObjectNode in that case.
I would probably step through this place, setting a breakpoint when realSymbolName contains a substring of the interesting type name. This is where symbol references are emitted. I assume we're going to emit this as a reference to the __REALBASE symbol + the offset.
https://github.com/dotnet/corert/blob/04fb46f43a573612f566c6ac3a53c07e5dbd151d/src/ILCompiler.WebAssembly/src/CodeGen/WebAssemblyObjectWriter.cs#L576-L590
Looking through the code, it's possible we're not actually emitting a definition of the _REALBASE symbol. I think it should happen here, but I'm not all that familiar with that code:
https://github.com/dotnet/corert/blob/04fb46f43a573612f566c6ac3a53c07e5dbd151d/src/ILCompiler.WebAssembly/src/CodeGen/WebAssemblyObjectWriter.cs#L425-L452

Thanks, that's pretty much the problem and answer.  However to help decide where the best place to fix this is, I have a question about EETypeNode and ConstructedEETypeNode.  For the interesting class with a reference type field I'm seeing both an EETypeNode and a ConstructedEETypeNode being created and at the emission of this node its picking the EETypeNode version which has no offset and I'm wondering if the fix here is to never create the EETypeNode (and fix up from there)?
I did try just hacking in the correct offset and that fixes reflection on this type.

Ok, maybe thats a daft idea as there's no provision for that in
https://github.com/dotnet/corert/blob/cd10d5e737d6658de12606e550d74708169db948/src/ILCompiler.Compiler/src/Compiler/DependencyAnalysis/NodeFactory.cs#L447
Instead I see this which looks like it might be relevant:
https://github.com/dotnet/corert/blob/cd10d5e737d6658de12606e550d74708169db948/src/ILCompiler.Compiler/src/Compiler/DependencyAnalysis/TypeMetadataMapNode.cs#L61-L62

Must be a daft question as there's not really a provision for that in the NodeFactory.CreateNecessaryTypeNode.  Anyway I have a fix which I'll submit once I get a few more tests in.

Yeah, we have both in the graph. If both EETypeNode and ConstructedEETypeNode end up in the graph for the same type, the places that reference EETypeNode are supposed to be upgraded to refer to the ConstructedEETypeNode (the difference between those two is that EETypeNode doesn't contain the vtable and lets us avoid generating a bunch of dependencies that might not be needed). Constructed EEType is needed for places that e.g. allocate an instance of the type. Unconstructed are okay for places that e.g. use the type in a cast.
The way EETypeNode/ConstructedEETypeNode emission works is that the object writer is supposed to call into ShouldSkipEmittingObjectNode and ignore the EETypeNode if it says true. Both EETypeNode and ConstructedEETypeNode define symbols with the same name, so this ends up being okay and references to EETypeNode get upgraded to the constructed one.

Thanks, the fix I have is quite small (https://github.com/yowl/corert/tree/field-reflection) but I wonder if should be even smaller.  Looking at
https://github.com/dotnet/corert/blob/2cff5615bfa2be6215a3a4473f77a415e1185a87/src/ILCompiler.Compiler/src/Compiler/DependencyAnalysis/TypeMetadataMapNode.cs#L61-L62
It seems to suggest that at this point the symbol that should be returned is the ConstructedEETypeNode (where it exists), however for wasm this goes through SingleFileCompilationModuleGroup which is fixed to return false:
https://github.com/dotnet/corert/blob/2cff5615bfa2be6215a3a4473f77a415e1185a87/src/ILCompiler.Compiler/src/Compiler/SingleFileCompilationModuleGroup.cs#L72-L74
And hence the EETypeNode goes in and a promotion is required later.  Would it be more correct for wasm to extend SingleFileCompilationModuleGroup and implement this method with the same logic as EETypeNode.ShouldSkipEmittingObjectNode (although not sure if that's possible at that point - how to get the Marked)?  On the surface that seems like it would remove the conditional logic in the writer.  I'll submit the PR and if you think this would be a better approach this can continue there.

The comment about upgrading refers to what will happen in the generated object file. It doesn't refer to the type of node NecessaryTypeSymbol returns.
The fix you came up with is good. The ShouldPromote logic is designed to deal with other issues specific to compilation modes where we don't compile everything into a single file. WASM should use the vanilla SingleFileCompilationModuleGroup at this point.


test server before reload

if server isn't up yet, reload will fail => causing blank page

This issue is solved by using the -w flag now apart of reload :)


Upgrade bzip2 to 0.4

Codecov Report

Merging #98 into master will not change coverage.
The diff coverage is 77.77%.

@@           Coverage Diff           @@
##           master      #98   +/-   ##
=======================================
  Coverage   79.87%   79.87%
=======================================
  Files          62       62
  Lines        2147     2147
=======================================
  Hits         1715     1715
  Misses        432      432

Impacted Files
Coverage Δ

src/lib.rs
67.74% <75.00%> (ø)

tests/utils/mod.rs
96.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b132a17...d3f145b. Read the comment docs.

Thanks!
bors r+


fix: yarn failures during dev-build

Description of changes
Inspired by https://github.com/aws-amplify/amplify-cli/commit/4d058e35c4a97785ffcda768bfcb9fff2ad46f11 --
In the aws-amplify/codegen-ui repo, we run integration tests that call yarn setup-dev. It's been failing at this step (see example log), and this is an attempt to mitigate.

Issue #, if available

Description of how you validated changes
Successfully ran yarn setup-dev
Checklist

[x] PR description included

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #12389 (e7dd683) into dev (984c0f8) will decrease coverage by 2.17%.
The diff coverage is 58.68%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##              dev   #12389      +/-   ##
==========================================
- Coverage   49.45%   47.29%   -2.17%
==========================================
  Files         692      839     +147
  Lines       33424    38256    +4832
  Branches     6840     7797     +957
==========================================
+ Hits        16529    18092    +1563
- Misses      15370    18525    +3155
- Partials     1525     1639     +114

Impacted Files
Coverage Δ

...mplify-appsync-simulator/src/resolvers/function.ts
15.38% <ø> (ø)

...s/amplify-appsync-simulator/src/type-definition.ts
100.00% <ø> (ø)

...sync-simulator/src/velocity/util/dynamodb-utils.ts
6.55% <0.00%> (ø)

...y-appsync-simulator/src/velocity/util/map-utils.ts
10.00% <ø> (ø)

...tor/src/velocity/util/transform/dynamodb-filter.ts
4.93% <0.00%> (ø)

...appsync-simulator/src/velocity/value-mapper/map.ts
86.88% <ø> (ø)

...ackages/amplify-category-auth/src/commands/auth.ts
0.00% <0.00%> (ø)

...ges/amplify-category-auth/src/commands/auth/add.ts
0.00% <ø> (ø)

...es/amplify-category-auth/src/commands/auth/help.ts
0.00% <0.00%> (ø)

.../amplify-category-auth/src/commands/auth/import.ts
0.00% <0.00%> (ø)

... and 94 more

... and 479 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hein-j Can you please try calling this is your GH action yarn --network-concurrency 1 --cache-folder ~/.cache/yarn see
https://github.com/aws-amplify/amplify-cli/blob/9eab404a232a4ecc5cb14c8b063e7d217bea3492/.circleci/config.base.yml#L138
before calling yarn dev-build.
Adding this here will impact local builds on our workstations which are doing fine. The cache corruption issue seems to be isolated to docker containers.

Yes, will try now.

Think this PR does the job - https://github.com/aws-amplify/amplify-codegen-ui/pull/981. Closing


Fix text in file grid info modal

Edit text in file grid information modal to correct information for non-contributors, and clarify for users how to expand folders to download as zip.
[OSF-3878]

CR1 done. Looks good.

CR2 pass complete. No changes requested.


Am I going down the wrong road with my return values?

I have the methods returning just the JSON part of the response as a dictionary, and dealing with the HTTP errors themselves. But now I’m wondering if I should instead just be returning the entire requests.Response, so that the client code can deal with any HTTP errors on its own. What do you think?

After discussion with Chris, I have decided this is the right path to take. I’m going to be opinionated about this.


Center tag on android not working as expected

<center> example </center>
This tag not working as expected on android it should be center which is between tags but its doing nothing.
Devices: all mobile android devices.
btw version v1.0.0 yarn or npm doesn't upgrade to 3.10.0

⚠ You did not follow the contributing guidelines!
As stated in these:

You need to fill out the issue template. This step is mandatory! Not doing so will result in your issue getting closed. Don't take this personally if this happens, and feel free to open a new issue once you've gathered all the information required by the template.
Although we might still help you without all these informations, it would be unfair to let some people post issues without filling everything.


Add Asteroid+ by @ChoiysApple

[x] Project URL:
[x] Update contents.json instead of README
[x] One project per pull request
[x] Screenshot included
[x] Avoid iOS or open-source in description as it is assumed
[x] Use this commit title format if applicable: Add app-name by @github-username
[x] Use approved format for your entry

Thx!


Enhanced geometric parser, Geometry and use of Model::Index

Parse primitive shapes shuch as cylinders, spheres, boxes
Split Index into JointIndex, GeomIndex, FrameIndex for clarity
collision_results is now a vector of CollisionResult
Fixed call to wrong functions ( due to change in API)
Update doc

For information, this PR won't compile until hpp-fcl package is not updated.


Set development status to production/stable

Add my e-mail address

I think by now we can safely say that this project is production-ready, considering how long we've been using it in typeshed and that there are no "rough edges", except those that are unavoidable.


Dark Mode Color Scheme and ico

Please describe the problem
Why do you want to add this feature?
I wanna change the color scheme for dark mode, the current greyish color is a bit odd. and also change the tab icon for the website to something better rather than the default.
Describe the solution you'd like
A clear and concise description of what you want to happen.
I wanna darken the color to pretty much all black so that the icons are more visible and the overall aesthetic looks good.
And using one of your own icons as a tab icon in the browser.
Screenshot
Please attach any relevant screenshot(s).

@AshutoshDash1999 can you please check this issue once?

Atharva-3000

Thank you, @Atharva-3000, for your response. You are welcome to continue with your code contribution. Please ensure that you follow the code standards and include a screenshot when submitting your pull request.

Atharva-3000

Thank you, @Atharva-3000, for your response. You are welcome to continue with your code contribution. Please ensure that you follow the code standards and include a screenshot when submitting your pull request.

Thanks ♥ , working on it

Closing this due to inactivity.


Fix for #43 when .2 was not parsing is a Real Literal.

Fix for #43 when .2 was not parsing is a Real Literal.
Added additional Unit Tests for the new parsing.
Not sure what went wrong is the spacings.

Thanks very much for your pull request!
Can I just ask you do leave the tabs instead of changing it to spaces? Otherwise we have hundreds of these kind of changes. I usually prefer tabs because are more configurable for each developer, but I know that this is a subjective argument 😄
I think that there are some configuration on git that can handle these scenarios...

Seems like I fixed the spacing diffs.
And it turns out that my fix was failing on the new unit tests for .2f and .2m formats.

Thanks @JustinRChou !
I will integrate these changes in the next release.

Thanks, merged in version <IP_ADDRESS>


[wasm] Samsung Internet 7 beta note is not needed anymore

Since https://github.com/Fyrd/caniuse/commit/b602c73c0a7d651520edc727add6ed2c1fd061d4#diff-fd2aa9257c26edb4eb860eb561dcb9f9

Thanks!