Model should throw IndexNotInListException if index for filtered list is out of bounds

EditCommand and DeleteCommand checks whether the index is valid and belongs to a Person in the Model's filtered list.
That should not be the job of the Commands, as they should not be aware of the list in the first place. The index validation check should be done in Model instead (the owner of the list), and if the check fails, there should be an IndexNotInListException*** for the Command to catch and handle with an appropriate message.
Let's:

Move the logic of checking the validity of the index from EditCommand#execute() and DeleteCommand#execute() to Model.updatePerson(...) and Model.deletePerson(...) respectively
Change Model.deletePerson(ReadOnlyPerson) to Model.deletePerson(Index).

***IndexNotInListException will be a checked exception, unlike IndexOutOfBoundsException which is a runtime exception.

Checked exceptions start to become problematic when we end up with code like:
try {
    model.deletePerson(indexWeKnowIsValidBecauseWeValidatedItAsPartOfAnotherOperationEarlier);
} catch (IndexNotInListException) {
    throw new AssertionError("should not happen");
}

all over the place.

Checked exceptions start to become problematic when we end up with code like:
try {
model.deletePerson(indexWeKnowIsValidBecauseWeValidatedItAsPartOfAnotherOperationEarlier);
} catch (IndexNotInListException) {
throw new AssertionError("should not happen");
}
all over the place.

Agree, perhaps that is a good reason to just use IndexOutOfBoundsException.

@yamgent

perhaps that is a good reason to just use IndexOutOfBoundsException.

Then it becomes using exceptions for flow control :-P
I think the current situation of leaving bounds checking to the callers is okay. Java programmers should be used to it anyway, since the Java collections library also requires that.
I agree that this:

Change Model.deletePerson(ReadOnlyPerson) to Model.deletePerson(Index).

is worth doing though.


labelStyle : how change font size ??

any updates ?

Which specific input are you using @rasanu and which font size would you like to change(text input or label)?


[ CI/Build ] LM Eval Harness Based CI Testing

SUMMARY:

Adds lm-eval harness based testing, using GSM-8k
Scripts to create baseline scores offline
Scripts to run lm-eval integration tests
Configs for large and small models

USAGE:
pip install git+https://github.com/EleutherAI/lm-evaluation-harness.git@262f879a06aa5de869e5dd951d0ff2cf2f9ba380
pip install openai==1.3.9
bash .buildkite/lm-eval-harness/run-lm-eval-vllm.sh -c .buildkite/lm-eval-harness/configs/small-models.txt

FOLLOW UP:

Same flow via LLM

FIX #5800
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE

 PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

[Bugfix] for bug fixes.
[CI/Build] for build or continuous integration improvements.
[Doc] for documentation fixes and improvements.
[Model] for adding a new model or improving an existing model. Model name should appear in the title.
[Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
[Kernel] for changes affecting CUDA kernels or other compute kernels.
[Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
[Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
[Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:

We adhere to Google Python style guide and Google C++ style guide.
Pass all linter checks. Please use format.sh to format your code.
The code need to be well-documented to ensure future contributors can easily understand the code.
Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.
What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

 After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
 After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
 After the review, the reviewer will put an  action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
 Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You
 Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

@simon-mo ready for review
I was unable to remove the second layer of indirection.
The reason for this is that, when TP>1, we cannot launch vllm more than once within the same process. This same issue hampers our existing distributed tests.
Alternatively, I could remove the run-tests.sh file and instead have that logic in the buildkite test-pipeline.yaml.

LGTM once the A100 test passes. Also we should also confirm how long it takes to run (ideally quickly since we only have one box atm)

I limited it to 250 samples. Once the models are loaded its <1 min

Running A100 tests... please check the results before merging.


Issue 1309

GitHub Issue: Islandora/documentation#1309
For testing https://github.com/Islandora/islandora/pull/761
What does this Pull Request do?
Pulls in code for https://github.com/Islandora/islandora/pull/761 so it can be tested.
What's new?
Islandora depending on drupal/transliterate_filenames
How should this be tested?

Try to upload a file with a comma or a square bracket in it.
Feel the pain and heartbreak because your file gets rejected
Pull in this PR
vagrant up
Try to upload a file with a comma or a square bracket in it.
Let your heart fill with joy because your filename got sanitized on the way in, and are now acceptable.

Interested parties
@Islandora-Devops/committers

See this comment: https://github.com/Islandora/islandora/pull/761#issuecomment-585902381

@seth-shaw-unlv Ok, I've added the module to the appropriate variables in the webserver role.  https://github.com/Islandora/islandora/pull/761 now just adds the module to the "suggests" block.  So we "suggest" you use that module, and if you install with our installer... you get it :)

I can probably spin this one up in a few minutes.

Lets make an issue for that if we don't already have one.


Abstract Queue causes fatal error when data is not unserializable

It appears that some of the logic in AbstractQueue.php is very sensitive to the data that can enter in from what ought to be considered a relatively untrusted source (the queue). A good example of this is if a queue can be published to by something other than SlmQueue(SQS in this case).
I'll be submitting a PR for the fix to this; however, the error is related to an invalid operand type. The fix is to do an array_merge along with some standard type checking prior to doing anything with the data['metadata'] key.

This can be reproduced in SlmQueueSQS by having a queue subscribed to events in AWS like an CloudWatch alert; however the logic errors are in SlmQueue. This will cause an unexpected 500 Fatal with an invalid operand type.


Add setting to transform content

Can be complex or simple
Rules based transformations
e.g. regex match, text output
e.g. match: .*, transform: http://foo.com?q=$0
$1, $2, ... capture groups
Will still be treated as URL if result is URL formatted

Scan item should store original data as well as transformed data, e.g.
{
  "raw": "123",
  "content": "http://foo.com?q=123",
  "date": ...
}


[EventRequest] Report 99001025 “Refresh Production Order” on procedure "Production Order - OnAfterGetRecord"

Please add a new publisher event OnBeforeCalcRoutingCalcComponent in Report 99001025 on function "Production Order - OnAfterGetRecord" and call it as shown in the image below

Please add the corresponding Integration Event In the bottom of the report
LOCAL [IntegrationEvent] OnBeforeCalcRoutingCalcComponent(ProdOrder : Record "Production Order";VAR ProdOrderLine : Record "Prod. Order Line";VAR CalcComponents : Boolean;VAR CalcRoutings : Boolean, VAR SkipLine)

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Data Science with Python : Audio Processing for Deep Learning/Machine Learning

Description
Deep learning with audio is an emerging field of deep learning so the first step is pre-processing of audio.
@prathimacode-hub I want to work on this isuue.
Domain
Datascience with Python
Type of Contribution
Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

Issue assigned to @das-ankur  for documentation. But you haven't provided up with the details needed for assigning the issue. @das-ankur

Issue assigned to @das-ankur for documentation. But you haven't provided up with the details needed for assigning the issue.

I am prepraing a document of different techniques how we can load audio data and do some basic preprocessing before using it in a model. It will be prepraed by  tomorrow.

Hello @prathimacode-hub can you please tell me where I should upload  the data file?

I said about details that needs to be given here while selecting issue @das-ankur

Kindly revert with details else this issue will be closed. Data file in DS Datasets. @das-ankur


pycapnp build failed (Cython==0.22)

Hi, I want to install pycapnp to then install nupic, and I've been stuck with one error for a while now:
/private/var/folders/cq/hfzg1bwx4gqbxn2pd0r0553r0000gr/T/pip-build-6GgSd3/pycapnp/build/include/kj/common.h:54:8: warning: "Your compiler supports C++11 but your C++ standard library does not.  If your "               "system has libc++ installed (as should be the case on e.g. Mac OSX), try adding "               "-stdlib=libc++ to your CXXFLAGS." [-W#warnings]
#warning "Your compiler supports C++11 but your C++ standard library does not.  If your "
^
/private/var/folders/cq/hfzg1bwx4gqbxn2pd0r0553r0000gr/T/pip-build-6GgSd3/pycapnp/build/include/kj/common.h:78:10: fatal error: 'initializer_list' file not found
#include <initializer_list>
^
2 warnings and 1 error generated.
error: command 'gcc' failed with exit status 1
I run on Mac OS 10.10 and I have the latest Xcode and clang version. I did install a homebrew version of gcc 4.9.2 and it worked, but unfortunately nupic doesn't compile with gcc 4.9. However I noticed that the requirements are Cython==0.21.2 and I have 0.22 distributed with anaconda 2.2.0. Could it be the reason for the issue ?
Many thanks.

Can you try running:
export CXXFLAGS="-stdlib=libc++"
export CFLAGS="-stdlib=libc++"

In the shell before installing pycapnp?

It didn't worked, but thanks to recommandations on the nupic thread I tried:
export MACOSX_DEPLOYMENT_TARGET=10.10
and everything was successfully installed !!
Thanks.

Great, glad you got it sorted out.

its work      export MACOSX_DEPLOYMENT_TARGET=10.10


install issues

Issues with jupyter notebooks
We have received several issues related to Jupyter notebooks.
If your issue is specific to running brainrender in a notebook, please check if any of the previously addressed issues is helpful, look at the documentation on using notebooks and try running the notebooks workflow example before opening a new issue.
If you are not sure if your issue is specific to jupyter notebooks, try running your code in a python script (i.e. with a .py file) and see if you get the same error, or any error at all. If you don't then the problem is restricted to notebooks.
Describe the bug
A clear and concise description of what the bug is.
To Reproduce
First tell us which version of brainrender and vedo you're using and something about your system (e.g. OS etc).
Then tell us the steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
I was once using the brainrender well, but I recently formatted my laptop and got a new computer.
So I was trying to install python through anaconda, and install brainrender, but I am stuck with installing your package.
Any ide what's going on?
I've tried several version of anaconda, but non of them work..
Screenshots
If applicable, add screenshots to help explain your problem.

Hi,
I'm not sure what the cause of this could be, I haven't seen it before.
Could you give me more details about what you're doing (e.g. python version you're using, brainrender version you're trying to install etc..)

I tried to install 3.8, 3.7, 3.6 via anaconda3, non of them worked.
Once I installed anaconda, I made an virtual env,
conda create -n br python=3.x
conda activate br
then type
pip install brainrender
yea, it is very weird, I actually did the same thing early this year, formatted my laptop and install anaconda and brainrender, it had no problem at all, it was totally fine, so I am confused what I am doing wrong.
Thanks,

I see. Yeah that's weird indeed. it seems that the problem is with installing morphio so perhaps it would be best to ask morphio's developers for help?

hey @jaehongpark-neuro  any luck with this?


feat: support delete and update hint

What this PR does:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Codecov Report
Patch coverage: 70.00% and no project coverage change.

Comparison is base (8a31095) 36.16% compared to head (21b4e58) 36.16%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #683   +/-   ##
=======================================
  Coverage   36.16%   36.16%
=======================================
  Files         214      214
  Lines       22994    22994
=======================================
  Hits         8315     8315
  Misses      13756    13756
  Partials      923      923

Impacted Files
Coverage Δ

pkg/runtime/ast/select.go
23.14% <ø> (ø)

pkg/runtime/ast/update.go
36.20% <40.00%> (ø)

pkg/runtime/ast/ast.go
68.98% <100.00%> (ø)

pkg/runtime/ast/delete.go
65.95% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Collation error on restore

While restoring from 10.8.4-MariaDB-log (managed by digital ocean) to  10.7.1-MariaDB-1:10.7.1+maria~focal
Got the following error
ERROR 1253 (42000) at line 2494: COLLATION 'utf8mb4_unicode_ci' is not valid for CHARACTER SET 'utf8mb3'

To view the version of DB server
show variables where Variable_name in ('version','version_comment');

Similar issue #5

Managed DB has different default collation, current in-house VM based mysql using utf8mb4_unicode_ci as default collation..


"Disable blacklist" parameter

I have a configuration with one master and it should be never blacklisted.

sure, why not?!
thanks @Tonkonozhenko

included in release candidate. https://github.com/taskrabbit/makara/releases/tag/v0.3.7.rc

@bleonard :+1:


[draft] Add the ability to allow the current site

temporary message: I wanted to do something like this. And I encountered the problem of running the project locally, how can I check the changes locally? I could only run the packages individually, for example in packages/content-script using the npm run start command, and see my changes. Then I saw that this project uses localstorage for local development, if I understand correctly?
My goals:

set the value and location of allowSingleHost to the allow function as you can see in my changes.
then I need to handle these params in the logic of the service worker. Could you help me please?:)

Hi @TangoPJ, thanks a lot for your PR ❤ Unfortunately, I don't have much time to review it in the upcoming days. But, out of curiosity, what do you think about placing the checkbox in the extension settings? So you can set it up once.

@sneas  Hello :) Thanks for your answer. It's a good idea with the checkbox placement, I'll look into the project further and fix my PR

I'm thinking of an independent "Options" screen, which can be accessed by right-clicking the extension icon and selecting "Options". There is no such a screen now.
Placing the checkbox on this form

can be a bit tricky from the UX perspective. But also can work out. I don't know how to label such a checkbox, though 🤔

I'm thinking of an independent "Options" screen, which can be accessed by right-clicking the extension icon and selecting "Options". There is no such a screen now.
Placing the checkbox on this form

can be a bit tricky from the UX perspective. But also can work out. I don't know how to label such a checkbox, though 🤔

I

I'm thinking of an independent "Options" screen, which can be accessed by right-clicking the extension icon and selecting "Options". There is no such a screen now.
Placing the checkbox on this form

can be a bit tricky from the UX perspective. But also can work out. I don't know how to label such a checkbox, though 🤔

I also thought about placing a checkbox on this form, but came to the conclusion that the user might get confused if we don't provide a clear label 🙂

Hi @TangoPJ, I have started the options page and added some functionality. The page is not saving the option yet.
The checkbox value has to be saved on options, and we'll use it to block/unblock pages.
I couldn't figure out a way to develop the options page independently of the extension. getIsUnblockAllWithSingleClick in App.tsx has to be mocked somehow, otherwise npm run dev on options package will not properly work.

Hello @sneas. I pulled the latest changes from the branch and ran the project, got the same problem, it's interesting, if you don't mind, can I look into it tomorrow evening? :)

Feel free to check it out whenever you like, mate.
I have pushed some changes allowing to develop options independently. It should help.
I think I will get back this PR in a week or later. There are too many things on my plate.

@sneas Hi :) I added some logic to handle the value of the checkbox and set it in chrome.storage. I'm currently researching how I can unblock the current website

Thanks a lot for your commit, bro. I have also pushed something. I made an api.ts file for the options package.
The idea is to let developers (you and me) run the options page in the development mode with npm run options. This way we can debug and develop options page more easily without reloading the extension every time we want to see some changes. One of the benefits of this approach is you don't have to struggle with variable names :)

@sneas Hello 🙂. Could you help me with my question: how can I handle the unblocking time that saving to the chrome.storage as a unblock_until key? For example a user clicks to first website Allow for 1 minute, then the user clicks to a second website Allow for 15 minutes, thereby overwriting the time in chrome.storage?🙂

Hi @TangoPJ 👋
We'll have to store both: time and host.
Thus, extension-messages/src/index.ts will look like this:
type UnblockOptions = {
  minutes: number;
  url: LocationUrl; // instead of host, let's pass LocationUrl object. Which is a subset of windows.location
}

export const [unblock, onUnblockRequest] = createScopedMessage<UnblockOptions, void>(
  'unblock'
);

export const [shouldBeBlocked, onShouldBeBlockedRequest] = createScopedMessage<
  LocationUrl,
  boolean
>('shouldBeBlocked');

Thanks a lot mate! We are almost there 💪
I'll do my best to give it a look next week (can't promise, though).

@sneas Hello:) I had a lot of work and couldn't focus on PR, sorry. I'm going to finish my PR one of these days 👌🏽

@sneas Hello:) Sorry for getting lost, there's been a lot of work, but this pull request needs to be completed. I've checked the project a few times, but I'm struggling with ideas on how to implement filtering for one specific website. Any suggestions? When you have some free time, could you please drop me a hint?

@sneas May your vacation be filled with joy, leaving you energized and refreshed :)

@TangoPJ , thanks, bro :)

Bro, I still can't get back to it. Thank you for your patience!

@sneas Ok:) I'll research it again before you arrive


Autoheight not firing on thumbnail gallery

The new auto-height feature works well in individual sliders but when used in the thumbnail example it doesn't fire on the slider being controlled when just the thumbnail slider is advanced.
Example
Any suggestions on how to make it fire on the controlled slider?
Great plugin, thanks for it.

Fixed


Show Chia icon in Dock

When launching the Chia blockchain GUI, no icon is displayed in the dock:

The PR herewith is an attempt at fixing this. Please note however that I have not succeeded at doing so yet, and am looking forward to any suggestion from @paninaro, @seeden or any other developer familiar with this part of the codebase.

The original issue was fixed by
https://github.com/Chia-Network/chia-blockchain-gui/pull/604
Closing.


Tracing module is not linked from the website

Issue description
The website does not include a link to the tracing module.

I've added it to the Cloud section. Not sure if that it is the best section for it.


Incorrect bindings in DB::update when using a collection as a value

Laravel Version
11.26.0
PHP Version
8.3.12
Database Driver & Version
MySQL
Description
When using a collection as a column value in DB::update, the wrong bindings are applied.
Before Laravel 11, the collection would be turned into a string (which still is the case if you use an array) but now all the values of the collection is spread and added to the bindings array.
The change seems to have come from this pull request with the added Arr::flatten: https://github.com/laravel/framework/pull/50030
Example:

DB::table('foo')->update(['bar' => collect(['a', 'b'])]);
gives the error SQLSTATE[HY093]: Invalid parameter number (Connection: mysql, SQL: update `foo` set `bar` = a)
Expected is that the collection should become a (json)string '["a","b"]' and be saved in the database.

With an array it still works (and this is how it was in version < 11 with collections)

DB::table('foo')->update(['bar' => ['a', 'b']]);
correctly updates with: update `foo` set `bar` = ["a","b"]

Steps To Reproduce

Use Laravel 11.x
Create (example) table:

use Illuminate\Database\Migrations\Migration;
use Illuminate\Database\Schema\Blueprint;
use Illuminate\Support\Facades\Schema;

return new class extends Migration {
    public function up(): void
    {
        Schema::create('foo', function (Blueprint $table) {
            $table->id();
            $table->string('bar');
        });
    }

    public function down(): void
    {
        Schema::dropIfExists('foo');
    }
};

php artisan tinker
DB::table('foo')->update(['bar' => collect(['a', 'b'])]);

https://github.com/laravel/framework/pull/53253
Unable to verify this issue. Tests running fine here.

Thanks for fixing this!


fork/exec /root/.draft/plugins/draft-pack-repo/bin/pack-repo: no such file or directory

Hi All,
I am trying to run draft in a container, so as a part of the process, I downloaded the latest binary (draft-v0.14.1-linux-amd64.tar.gz) , copied the binary file to /usr/local/bin and when I tried to run "draft init", I am getting this error:
fork/exec /root/.draft/plugins/draft-pack-repo/bin/pack-repo: no such file or directory
Base image: alpine.
Can someone help me with this? Am I missing anything?

Hi, @disha94 !
The first thing that comes to mind about this issue is that the base Alpine image doesn't come with a git installation, which Draft requires in order to install plugins and download the default packs.

Hi @radu-matei , I know but I am already adding git installation part while bringing up the image:
"apk add --no-cache git"

For any future reference, until we fix the installation in an Alpine Linux container, here's what you need to add in your container in order to make it work:

CA certificates and OpenSSL to make wget work: apk update && apk add ca-certificates && update-ca-certificates && apk add openssl
curl: apk add curl
bash: apk add bash
git: apk add git

Now you're ready to draft init - let me know if this works for you, as I just tested in an Alpine container.


Decode returned code VP8_STATUS_UNSUPPORTED_FEATURE for .webp animations

I have this task of sending multiple pictures across the network, where the receiver end is Java, So I decided to serialize thoses images into a webp "animation" where each image is a frame. The webp is generated in python using PIL, and it's possible to decode and extract the frames on both python and Ezgif.com.
However when trying decode the same file, I get the following error
java.io.IOException: Decode returned code VP8_STATUS_UNSUPPORTED_FEATURE
at com.luciad.imageio.webp.WebP.decode(WebP.java:61)
at com.luciad.imageio.webp.WebPReader.read(WebPReader.java:158)
at java.desktop/javax.imageio.ImageReader.read(ImageReader.java:938)
at TestFrameGrab.testReadWebpLuciad(TestFrameGrab.java:29)

The test code:
    File inputWebp=new File("input.webp");
    File outputJpeg=new File("output.jpg");

    ImageReader reader = ImageIO.getImageReadersByMIMEType("image/webp").next();
    WebPReadParam readParam = new WebPReadParam();
    readParam.setBypassFiltering(true);

    reader.setInput(new FileImageInputStream(inputWebp));
    BufferedImage image = reader.read(0,readParam);
    ImageIO.write(image,"jpeg",outputJpeg);

The Python code to generate the file:
with open("input.webp","wb") as io:
    img.save(io, format='WebP', save_all=True, append_images=all_imgs, quality=80, lossless=True, allow_mixed=True)

I'm a bit clueless about what could have went wrong, any help or suggestions will be appreciated

This project just wrap java code and dll files. You may go to source repo luciad/webp-imageio , and create issue about supporting new feature of animation webp.


xcodebuild: error: Unable to find a device matching the provided destination specifier: { platform:macos, arch:arm64 }

We're trying to start Swift 6 compatibility testing and there seems to be a change in how the -destination flag works in xcodebuild with Xcode 16.0b1.
Here's what's failing:
git clone https://github.com/SwiftPackageIndex/SemanticVersion.git && cd SemanticVersion
git checkout 0.4.0
mkdir .stats
env DEVELOPER_DIR=/Applications/Xcode-16.0.0-Beta.app xcrun xcodebuild -IDEClonedSourcePackagesDirPathOverride=$PWD/.dependencies -skipMacroValidation -skipPackagePluginValidation -derivedDataPath $PWD/.derivedData build -scheme SemanticVersion -destination platform=macos,arch=arm64 OTHER_SWIFT_FLAGS="-stats-output-dir .stats" -strict-concurrency=complete

xcodebuild: error: Unable to find a device matching the provided destination specifier:
		{ platform:macos, arch:arm64 }

	The requested device could not be found because no available devices matched the request.

	Available destinations for the "SemanticVersion" scheme:
		{ platform:macOS, arch:arm64e, id:00006022-001C21123EA8201E, name:My Mac }
		{ platform:macOS, arch:arm64, id:00006022-001C21123EA8201E, name:My Mac }
		{ platform:macOS, arch:x86_64, id:00006022-001C21123EA8201E, name:My Mac }
		{ platform:macOS, arch:arm64e, variant:Mac Catalyst, id:00006022-001C21123EA8201E, name:My Mac }
		{ platform:macOS, arch:arm64, variant:Mac Catalyst, id:00006022-001C21123EA8201E, name:My Mac }
		{ platform:macOS, arch:x86_64, variant:Mac Catalyst, id:00006022-001C21123EA8201E, name:My Mac }
		{ platform:macOS, arch:arm64, variant:DriverKit, id:00006022-001C21123EA8201E, name:My Mac }
		{ platform:DriverKit, name:Any DriverKit Host }
		{ platform:macOS, name:Any Mac }
		{ platform:macOS, variant:Mac Catalyst, name:Any Mac }

This used to work in all previous Xcode versions, for example Xcode 15.4:
git clone https://github.com/SwiftPackageIndex/SemanticVersion.git && cd SemanticVersion
git checkout 0.4.0
mkdir .stats
env DEVELOPER_DIR=/Applications/Xcode-15.4.0.app xcrun xcodebuild -IDEClonedSourcePackagesDirPathOverride=$PWD/.dependencies -skipMacroValidation -skipPackagePluginValidation -derivedDataPath $PWD/.derivedData build -scheme SemanticVersion -destination platform=macos,arch=arm64 OTHER_SWIFT_FLAGS="-stats-output-dir .stats" -strict-concurrency=complete

Variants I've tried:

❌ -destination platform=macos,arch=arm64
❌ -destination platform=macos,arch=arm64e

Crisis averted, looks like the string is simply case-sensitive now:

✅ -destination platform=macOS,arch=arm64

I wonder now if all the other platforms will also fail unless I update their strings 🤔

The good news is that Xcode <16 accepts macOS and iOS just fine so we should be safe updating them.

Confirmed, we do need to update all identifier to work with Xcode 16:
xcodebuild: error: Unable to find a destination matching the provided destination specifier:
		{ generic:1, platform:ios }


Wrong typings path

Framework7 version: 6.0.7
Platform and Target: Doesn't matter

Describe the bug
When you want to import ES Modules in a typescript based project you get a missing type definition error.
To Reproduce
Steps to reproduce the behavior:

start a new Create React App project with TypeScript

npx create-react-app my-app --template typescript

import a component from framwork7/components

import Tabs from "framework7/components/tabs";

See error
Could not find a declaration file for module 'framework7/components/tabs'.

Expected behavior
The typings value in package.json of a component should look like this:
  "typings": "../../types/components/component_name/component_name.d.ts"

Actual Behavior
The current typings value is:
  "typings": "../../types/components/component_name.d.ts"

which is missing the component_name directory.

Fixed by #3821


Deleting multiple nodes and connections crashes

FlowView::deleteSelectedNodes() crashes when multiple nodes and multiple connections are currently selected.
eg: In the calculator example, do a big graph with many adds, then try to delete the middle portion of the graph. boom.
The issue is that "_scene->selectedItems()" will return multiple elements, among them nodes and connections... If we first delete the nodes (eg: _scene->removeNode()) then the call to removeNode will also remove attached connections.
Then when we do a next iteration, the call to qgraphiucsitem_cast<> will crash because the item (a connection) will have already been deleted.
The fix is simple: delete all connections first, then delete the nodes (eg: change the order of the loops).
The correct implementation should be this:
void
FlowView::
deleteSelectedNodes()
{
// Delete connections first because _scene->removeNode() will delete connections that are in the selectedItems() list
for (QGraphicsItem * item : _scene->selectedItems())
{
if (auto c = qgraphicsitem_cast<ConnectionGraphicsObject*>(item))
{
_scene->deleteConnection(c->connection());
}
}
// Now delete the disconnected nodes and clean up any remaining connections attached to those nodes.
for (QGraphicsItem * item : _scene->selectedItems())
{
    if (auto n = qgraphicsitem_cast<NodeGraphicsObject*>(item))
    {
        _scene->removeNode(n->node());
    }
}

}

@spiriapbergeron I cannot replicate the issue, could you add a scene like you described?

Ugh. It's been quite a while. I have a heavily modified version here locally, so it's not easy to "send a scene" since I have also changed the persistence scheme on my end.
But, let me try to be clearer in my explanation:

Using the calculator example, create a "big graph", where you add together about 12 nodes.

A \                       E
B ---- (A+B)   ------- E+(A+B)
C ---- (C+D)  ------- F+(C+D)     ------ (E+(A+B)) + (F+(C+D)) -----> result node.
D /                      F /
Do a rectangle selection over the following nodes, AND their connections.
The add node for (A+B)
The add node for (C+D)
The data node E
The data node F
The add node for E+(A+B)
The data node for F+(C+D)
The add node for the result.
Then hit delete.
Or, in other words, only leave as unselected the following nodes (but select all connections)
Data node A,B,C,D, Result.
Hit Delete.
You should crash.

I just tried and it works properly again

You mean you can reproduce and you fixed it, or you can't reproduce?

Sorry, I mean I can't reproduce it. Are you sure it not depends from your locally modified version?


Update OrgChart Now SSO article

The updates above reflect the OrgChart Now SSO framework as of the 5.2.1 version, released in November of 2021.

@gitkmeunier, Let me review the changes and will create a separate PR for these changes in our private Repo.
#please-close


[Separate Reporter Part 1] Copy proof functions from reporter to dal

Description
This is the Part 1 of multipart PR that separates reporter from node. The PR will be merged to its parent branch feat/separate-reporter, which in turn will get merged to master after all parts are merged. This PR:

copies proof related functions from reporter to dal
includes error checking in gopax implementation to pass lint

Related issue #1777
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist before requesting a review

[x] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.

Deployment

[ ] Should publish npm package
[ ] Should publish Docker image

@Intizar-T
It's a bit late to leave a comment,
I found out that functions are starting with capital letters, if the functions aren't referenced outside the package please change the first capital letters into small letters.

@Intizar-T It's a bit late to leave a comment,
I found out that functions are starting with capital letters, if the functions aren't referenced outside the package please change the first capital letters into small letters.

@nick-bisonai good point, will make a small followup PR


Updating btn-link color

Summary
Updating btn-link color to be $color-blue-400.

Checklist

[ ] *Added unit tests
[x] *Added a code reviewer
[x] Added changes to /projects/swimlane/ngx-ui/CHANGELOG.md under HEAD (Unreleased)
[ ] Updated the demo page
[x] Included screenshots of visual changes

*required

I'm worred about this one.  There are severl place we using icons inside a .btn-link.  They'll all turn blue!

I'm worred about this one. There are severl place we using icons inside a .btn-link. They'll all turn blue!

Yes good call Jayson, I believe this is the intent on this one, @mcwenger @marjan-georgiev can you guys confirm? With this  change the link button will be blue everywhere

Might want to add an additional style (btn-icon?) but that would require updating each usage.


Add support for global typefaces

I've to set my typeface for every dialog that I show. It will be nice to have support for global typefaces in addition to the existing colour ones!

Unfortunately, there's no good way to do this. I actually tried, but when an app enables Proguard, it appears string attributes (e.g. the name of a font file) get obfuscated and the string isn't readable.

Maybe there's another reason why it happens, but I'm looking into it more.

https://github.com/afollestad/material-dialogs/releases/tag/v<IP_ADDRESS>

Great update. Thank you!

disableDefaultFonts() was removed in commit cffd86e. It would be nice if a minor version update of this library don't break compilation. In the future please mark such methods as deprecated, maybe doing nothing anymore, and give users of this library the chance to remove usages gracefully. Deprecated methods could then be removed in the next version after this one. Thank you!

Also it would be nice if the README mentions how to set the font via theming. It only states

There's a global theming attribute available to automatically apply fonts to every Material Dialog in your app, also.

By looking at the diff I found out that the attribute names are md_medium_font and md_regular_font.

It shouldn't be expected that changes like that will be made when the
library isn't at version 1.0. Leaving it would be completely useless, since
the Roboto fonts were unbundled and that method wouldn't do anything
anymore.
There's a global theming attributes section that lists all of the attribute
names.
On Thu, Apr 30, 2015, 5:32 AM Sven Jacobs<EMAIL_ADDRESS>wrote:

Also it would be nice if the README mentions how to set the font via
theming. It only states
There's a global theming attribute available to automatically apply fonts
to every Material Dialog in your app, also.
By looking at the diff I found out that the attribute names are
md_medium_font and md_regular_font.
—
Reply to this email directly or view it on GitHub
https://github.com/afollestad/material-dialogs/issues/474#issuecomment-97732689
.

Leaving it would be completely useless, since the Roboto fonts were unbundled and that method wouldn't do anything anymore.

That's right. It wouldn't do anything anymore. But it would be marked @deprecated and users could remove usages to it before it gets removed in the next version.


JSX element type 'MdiSvg' does not have any construct or call signatures.

With the latest vue-tsc (0.37.2) and typescript 4.7.3 suddenly when doing a npm run build under Vue3 + Vite the following error appears:
JSX element type 'MdiSvg' does not have any construct or call signatures.
Before the upgrade the build never had this error.
Thanks for helping!
mario

OK, seems a more general problem solved in https://github.com/johnsoncodehk/volar/issues/1414#issuecomment-1148867233


Some Clarification

System Info / 系統信息
OS - WSL2 (Ubuntu 22.04)
32GB RAM
Rtx 3090 24GB
Rtx 3060 12GB
Cuda - 12.1
Pytorch - 2.2.2+cu121
Transformers - 4.31.0
Python 3.10.14
Who can help? / 谁可以帮助到您？
Hello
Few clarifications please:

Do SAT models give better results compared to Hugging Face models?

Why do the models on this demo page provide better responses compared to running HF Models in 8bit and 4bit locally? Is it because the demopage models are not quantized? or is it because HF model is less efficient than SAT model? I am making assumptions, please clarify.

Also, when attempting to run SAT models locally, I encountered a "Killed" error with 4-bit quantization and a "CUDA out of memory error" without quantization. Is there a way to load SAT models in 8-bit or 4-bit on a single RTX 3090 GPU?

And by the way your demo on huggingface is not working. I open the demo, submit a prompt and then it displays error - “Timeout! Please wait a few minutes and retry”. Therefore I am unable to compare difference between HF and SAT version in terms of quality.

Information / 问题信息

[X] The official example scripts / 官方的示例脚本
[ ] My own modified scripts / 我自己修改的脚本和任务

Reproduction / 复现过程
 python cli_demo_sat.py --from_pretrained models/cogvlm-chat-v1.1 --version chat --bf16  --stream_chat --quant 4
When i run the above code, I get this error : -
[2024-04-06 20:18:44,522] [INFO] [real_accelerator.py:191:get_accelerator] Setting ds_accelerator to cuda (auto detect)
WARNING[XFORMERS]: xFormers can't load C++/CUDA extensions. xFormers was built for:
    PyTorch 2.0.1+cu118 with CUDA 1108 (you have 2.2.2+cu121)
    Python  3.10.12 (you have 3.10.14)
  Please reinstall xformers (see https://github.com/facebookresearch/xformers#installing-xformers)
  Memory-efficient attention, SwiGLU, sparse and more won't be available.
  Set XFORMERS_MORE_DETAILS=1 for more details
[2024-04-06 20:18:47,398] [INFO] building CogVLMModel model ...
[2024-04-06 20:18:47,402] [INFO] [RANK 0] > initializing model parallel with size 1
[2024-04-06 20:18:47,403] [INFO] [RANK 0] You didn't pass in LOCAL_WORLD_SIZE environment variable. We use the guessed LOCAL_WORLD_SIZE=1. If this is wrong, please pass the LOCAL_WORLD_SIZE manually.
[2024-04-06 20:18:47,403] [INFO] [RANK 0] You are using model-only mode.
For torch.distributed users or loading model parallel models, set environment variables RANK, WORLD_SIZE and LOCAL_RANK.
[2024-04-06 20:18:55,409] [INFO] [RANK 0]  > number of parameters on model parallel rank 0:<PHONE_NUMBER>6
[2024-04-06 20:19:00,248] [INFO] [RANK 0] global rank 0 is loading checkpoint models/cogvlm-chat-v1.1/1/mp_rank_00_model_states.pt
Killed

Expected behavior / 期待表现
Summary: The SAT model didn't work on my computer, so I tried the HF model. But the HF model didn't give good results, so now I'm trying to get the SAT model to work. Also, to make sure that I have properly run the HF model on my computer, i checked the demo on huggingface to compare my results, but the demo is also not working.
Goal: I am trying to produce same results that I get on this demo , but on my local machine.

so you want to use hf demo you can clone hf cogagent-chat on your local and run hf_demo in this repos


Package webhook fix

Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/draft

This PR is a draft for https://github.com/aws/eks-anywhere-packages/pull/547

another pr fixed this


docs: add demo

Hey @brettz9,
I finally made time to take your #28 as inspiration and spin up a demo based on your idea, with tooling I'm more familiar with.
This also changes a few other things:

src/ => lib/
uses pnpm workspace so that demo/ can easily depend on lib/
adds a GitHub workflow to deploy to Pages

Would be happy to get a review from you this time around!

Thanks for the review!
Those are interesting points, I have to admit I have not properly considered browser non-bundler imports. In looking at what other libs used, I stumlbed over tsup, which I might want to investigate for that.
The husky changes also sound good.
I'll look at both in another context, as I think the demo can live without either. Especially the browser-compatibility issues I will want to solve before we declare zodex 1.0 (which I think is imminent).


[ 8° ] - Release/v2.1.0 dpp helm template: Refactor dpp helm template

Why we create this PR?
Added some checks to the dpp helm template:

added readOnlyRootFilesystem to the container security context
Updated helm template to provide security context values from the helm vaules file

What is new?
Added

added readOnlyRootFilesystem to the container security context

Updated

Updated helm template to provide security context values from helm vaules file

I runned the IP checks and there is no problem :) free to merge


[ENHANCEMENT] - 📚 Enhancement Request - Improve Project Documentation 📝

This issue is raised to enhance the documentation for our project. Improving the documentation is crucial for better project understanding, onboarding, and user experience. This enhancement includes adding screenshots, describing features, and making the documentation more comprehensive and user-friendly. 🚀

Screenshots: Include screenshots or visual representations wherever applicable to provide a visual context for the documentation. Screenshots can help users understand the project's interface, settings, and usage. 🖼
Feature Descriptions: Clearly describe each feature of the project, including its purpose, functionality, and how to use it. This will help users make the most of the project's capabilities. 📋
Usage Examples: Provide step-by-step usage examples or use cases that demonstrate how to perform common tasks within the project. This helps users apply the project effectively. 📝
FAQ Section: Add a Frequently Asked Questions (FAQ) section to address common queries and troubleshooting tips. This can reduce user support requests. 🤔
Installation Instructions: If applicable, improve the installation instructions by providing detailed setup steps for different environments (e.g., development, production). 🛠
API Documentation: If the project includes an API, document the API endpoints, request/response formats, and authentication methods. 🌐
Table of Contents: Organize the documentation with a clear and navigable table of contents, making it easy for users to find relevant information quickly. 📑
Search Functionality: If the documentation is web-based, consider adding a search feature to allow users to quickly locate specific topics. 🔍
Feedback Mechanism: Encourage users to provide feedback or report documentation issues to further improve the documentation. 📢

Expected Benefits:

Enhanced documentation will improve user onboarding and reduce the learning curve for new users. 📈
Users will have a better understanding of the project's features and capabilities. 🧐
The documentation will serve as a valuable resource for both developers and end-users. 📖

Proposed Steps:

Review the existing documentation to identify areas that need improvement. 🔍
Collect and prepare screenshots and visuals to be integrated into the documentation. 📸
Collaborate with project team members to gather detailed feature descriptions and usage examples. 👥
Create or update documentation pages as per the proposed enhancements. 📝
Test the documentation with new users to gather feedback and make further improvements. 🧐
Ensure that the documentation is kept up-to-date with the project's development. 🔄

Additional Information:

Improving project documentation is an ongoing process that benefits both the project team and the user community. 🌟
Collaboration among project members, including developers, technical writers, and designers, is essential to achieve comprehensive documentation. 🤝
Feedback from users is highly valuable and should be encouraged to maintain documentation quality. 🗣

Note: Please link this issue to relevant project milestones or epics for tracking and prioritization. 🎯
Let's work together to enhance our project's documentation and provide users with a better experience. 📖🌟

Did most of these issues mainly on README and on INSTALL.md


blacklist nouveau kernel module

Commit creates a /etc/modprobe.d/blacklist-nouveau.conf file that contains the modules required to disable the open source nouveau module.
nouveau module is useful to provide Open source support for nvidia GPUs and hardware acceleration for 3d rendering on desktops. On server side, users typically require the proprietary nvidia module which supports CUDA workloads for utilizing GPUs for compute capabilities. Nvidia documentation provides this as a pre-requisite, along with the thread from Ubuntu community. Swapping the kernel module from  nouveau to nvidia during runtime didn't seem possible as the BOSH resurrector replaced the VM based on my testing on Azure, when I forced removed the nouveau module on a running VM Instance.
I've tested AWS and Azure stemcell builds and I was able to use the stemcell image to build a PKS cluster with nvidia GPU attached workers and Tensorflow based workload using GPUs from Kubernetes.
This PR should address issue #90 .

Hey, just looking to check my understanding of a modprobe.d/*.conf file.
My understanding is the most holistic way of blacklisting a module was to insert a blacklist <module name>, as this overrides what the kernel will run when trying to load it.
Does the combination of alias <module> off and blacklist <module> achieve the same effect?

Hi @aashah ,
I imagine alias <module> off bits can be removed since on a stemcell it's very unlikely (impossible?) for the modules to be aliased. I can make the change to remove the alias lines.

Sure..what about the question around install <module> /bin/true?

I was generally following the; https://docs.nvidia.com/cuda/cuda-installation-guide-linux/index.html#runfile-nouveau-ubuntu documentation.
I can the commit to just include
install nouveau /bin/true
install lbm-nouveau /bin/true
options nouveau modeset=0

as an append to $chroot/etc/modprobe.d/blacklist.conf to keep the change more consistent.


Add unifip to repo

@natandiasm I have to close this request without merging, because you requested to add a non-existent domain to this repository: Host si.fiponline.edu.edu.br not found: 3(NXDOMAIN) Please ensure that you are familiar with this repository rules located at the bottom of this page and submit a new request with the correct information. Thank you for your understanding!


Move to Quilt

Seems like that hacky fix for books doesn't work outside dev env:
Caused by: org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException: Critical injection failure: @Inject annotation on checkPageLength could not find any targets matching 'm_npozgazf' in net.minecraft.class_473. Using refmap parachute-1.19.1-refmap.json [PREINJECT Applicator Phase -> parachute.mixins.json:MixinBookEditScreen from mod parachute -> Prepare Injections ->  -> handler$cbf000$checkPageLength(Ljava/lang/String;Lorg/spongepowered/asm/mixin/injection/callback/CallbackInfoReturnable;)V -> Parse]
Removing the mixin makes build work fine. Fixing soon.


[Rancher2] Restricted Admin - permissions are changed

Request Summary:

We need to update the documentation because the scope of permission for a restricted admin will be changed in the Rancher v2.5.6 release.
Here is a quote from https://rancher.com/docs/rancher/v2.x/en/admin-settings/rbac/global-permissions/#list-of-restricted-admin-permissions
The restricted-admin permissions are as follows:
1. Has full admin access to all downstream clusters managed by Rancher.
2. Has very limited access to the local Kubernetes cluster. Can access Rancher custom resource definitions, but has no access to any Kubernetes native types.
3. Can add other users and assign them to clusters outside of the local cluster.
4. Can create other restricted admins.
5. Cannot grant any permissions in the local cluster they don't currently have. (This is how Kubernetes normally operates)

2 and 5 will not apply anymore because the access to the local cluster is removed.
I don't have a full list of changes yet. I will keep this issue updated.

Feature has been reverted from 2.5.6, so do not merge.  Will be due in 2.5.7.

Sheilagh said Prachi has a matrix about how we expect restricted admin to work, and that should go in the docs.

Closed via #3370


CSS Suggestions from @BobMoree

Concerning the CSS, I just came across a bug:
.media, .media .body {
overflow: hidden;
}
Because of this default bootstrap styling, you cannot access the edit post drop-down fully.
At least that's what happened when I was in the admin on the ticket detail page.
Just make it: overflow:visible; (this does mess with the lay-out a little, but saves the UX)
There's also something wrong with the nav-collapse for the header nav. I get a
horizontal scroll bar, but I'm not sure exactly yet about the cleanest way to fix this.
I want to use flexbox for the pipeline and the main lay-out (getting the wrappers to stay
in the preferred position, i.e. the footer fixed at the body). This would require something like
the following. The following does seem to have some unintended consequences, which I will
look into.
body {
display: flex;
flex-flow: row wrap;
height: 100vh;
align-items: flex-start;
}
upper-wrapper, #body-wrapper, #footer-wrapper {
width: 100%;

}
footer-wrapper {
align-self: flex-end;

}

#629


Problem: Initialize Terraform pg backend with env variables

Issue
I'm trying to setup a Terraform task with a PG backend.
As recommended I use the libpg environment variable. This works flawless when executing Terraform locally.
I put the pg env variables (PGHOST, PGUSER....) into a Semaphore environment object which is assigned to the task. But this won't work. After executing the task it still tries to connect to localhost instead:
11:37:44 AM
11:37:44 AM
Initializing the backend...
11:37:44 AM
╷
11:37:44 AM
│ Error: dial tcp <IP_ADDRESS>:5432: connect: connection refused
11:37:44 AM
│
11:37:44 AM
│
11:37:44 AM
╵

Impact
Other
Installation method
Docker
Database
Postgres
Browser
Chrome
Semaphore Version
2.10.22
Ansible Version
No response
Logs & errors
No response
Manual installation - system information
No response
Configuration

Additional information
No response

Seems that environment_variables are not applied when doing terraform init (https://github.com/semaphoreui/semaphore/blob/a5ea39e229b2d703990f317fa919b2e05cc96793/db_lib/TerraformApp.go#L87). Could this be the reason?

Hello, I checked and at least the secret environment variable type works if you put TF_ENV_ prefix to your variable name so I would think the normal environment variables would too. You will need to create the secrets again it seems, at least when I tested it they didn't update.

Hi @ollikurki ,
I recreated the env variables and prefixed them with TF_ENV_.

This doesn't work:

In my understanding env variables are not passed to the init command as well:
https://github.com/semaphoreui/semaphore/blob/a5ea39e229b2d703990f317fa919b2e05cc96793/db_lib/TerraformApp.go#L87

I believe I see a similar issue with Terraform AWS S3 backend.  I get the same error when it tries to initialize the backend.  I have set up the environment with ENV and Secret ENV values.  I have prefixed with TF_VAR_ and nothing works.  If I log into the container and go where the repository was cloned and manually set the ENV variables, thenterraform init works.  So I know setting ENV should allow everything to work.

Ahh yeah, I typo'd the prefix it should be TF_VAR_ and for me it works on the Secrets section if I create "Secret Environment Variable" type secrets:

It works for Terraform variables.
But in case of Postgres backend we don't use Terraform variables but host environment variables (PGHOST, PGUSER....). These variables need to be accessable in the init command.
It's not possible to use Terraform variables to define backend credentials.

Ohh, sorry I wasn't of much help then. I just fixated on the variable point because I had the same problem with the Environment Variables not working when trying to use terraform for my hypervisor and didn't clearly read the whole issue.

Same issue here with Terraform http backend initialisation during init phase.

Same issue here when using the AWS S3 backend:

The backend doesn't use TF VARS but actual environment variables.


Build fails on ubuntu 17.10

Looks like there are a few bash-ism in the scripts, mostly of the form: node-sass --output-style compressed $(< .build/node-sass-args) > .build/opensphere.min.css which doesn't work if the shell isn't bash (any recent Ubuntu: https://wiki.ubuntu.com/DashAsBinSh).
Any easy replacement is something like: node-sass --output-style compressed `cat .build/node-sass-args` > .build/opensphere.min.css
Working on a PR now.

Other shells should be following that syntax. Including Ubuntu's default dash. See this very detailed answer on Stack Overflow.
That being said, I'm working our Travis build on Trusty right now, so just hold tight.

Should be good to go.

Builds fine on 17.10. Have filed tickets for tests that are still failing.


FIX bpf_map_delete_elem unexpected error log

What type of PR is this?

What this PR does / why we need it:
We areusing bpf_map_delete_elem  which returns longs type. We see very weired phenomenon though it is -2 when no key exists, but it is not equal to int -2.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

/lgtm
/approve


Use a more direct and less error-prone return value

[x] have read the CONTRIBUTING.md file
[ ] raised a GitHub issue or discussed it on the projects chat beforehand
[ ] added unit tests
[ ] added integration tests
[ ] updated documentation if needed
[ ] updated CHANGELOG.md

Since err != nil has been judged before, nil is returned directly here, which is more obvious, readable and less error-prone.

There are probably a lot more of these, it either needs to be fully consistent or should not matter. I dont agree that the impact is that grand, happy for you to take a pass over the whole codebase, but a single change like this doesnt make too much sense imo.


Add alumni and student coach questiontag (testdata & frontend)

This pull request will add the question and answers for alumni and possible student-coaches to the testdata (ddd). There is also some cleanup added in the QuestionAnswerGenerator.

The css for the alumni icon was terrible to change so it's a bit crooked and partly inline, feel free to improve it.
Furthermore feedback (location/style/other) for the alumni icon and student coach indicators would be appreciated since i'm far from an UI expert.


Add tag model

Closes #124
Changes:

Tighten restrictions in Name class to match restrictions agreed
Modify Tag class to use the Name class
Add exceptions for tag operations
Update AddressBook to store a list of tags (to support tag operations in the future)
Update Model Manager (to support tag operations)
Update test cases for Name and Tags

To Do:

[ ] Refactor AddressBook, Model, ModelManager

Codecov Report

Merging #140 (5c9ac53) into master (58f36f9) will decrease coverage by 3.58%.
The diff coverage is 32.11%.

@@             Coverage Diff              @@
##             master     #140      +/-   ##
============================================
- Coverage     72.15%   68.57%   -3.59%
- Complexity      399      411      +12
============================================
  Files            70       75       +5
  Lines          1232     1330      +98
  Branches        125      137      +12
============================================
+ Hits            889      912      +23
- Misses          311      375      +64
- Partials         32       43      +11

Impacted Files
Coverage Δ

...dress/model/tag/NameContainsKeywordsPredicate.java
0.00% <0.00%> (ø)

...ss/model/tag/exceptions/DuplicateTagException.java
0.00% <0.00%> (ø)

...ess/model/tag/exceptions/TagNotFoundException.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/ui/PersonCard.java
0.00% <0.00%> (ø)

...rc/main/java/seedu/address/model/ModelManager.java
76.19% <11.76%> (-23.81%)
:arrow_down:

...in/java/seedu/address/model/tag/UniqueTagList.java
23.25% <23.25%> (ø)

src/main/java/seedu/address/model/AddressBook.java
70.00% <42.10%> (-21.67%)
:arrow_down:

src/main/java/seedu/address/model/tag/Tag.java
72.72% <80.00%> (-7.28%)
:arrow_down:

src/main/java/seedu/address/model/tag/Name.java
81.81% <81.81%> (ø)

src/main/java/seedu/address/model/Model.java
100.00% <100.00%> (ø)

... and 4 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Set Checkboxes to default false when no default set

Summary
For boolean fields, when no default is set in Salesforce, default field to null
Please describe the problem you are trying to solve.
Salesforce does not allow pushing Null to checkbox fields.  Since this is meant to support migrations, we want to make sure data in fields can be sent by default to any writable field.
Proposed Solution
Add a default to checkbox fields to set them false if no default is provided in the describe.

@acrosman that can be easily done by javascript. Assign me the issue so that I can resolve it and make a PR.


Add support for running commands on key press

Based on option command in key binding section in config, e.g.
  - { key: N,        mods: Control|Shift,    command: alacritty          }
  # or
  - {
      key: N,
      mods: Control|Shift,
      command: {
        program: "alacritty",
        args: ["-e", "vttest"],
  }}

specified command will be run in the background on key press. Alacritty doesn't wait for its result nor block IO.
Fixes #334.

I have removed pretty much all deser logic and replaced it with derives. The thing is there was implemented something similiar (just not generic) to https://serde.rs/string-or-struct.html, but serde doesn't provide this out of the box. I've managed to achieve the same using serde's untagged enum representation. Is it okay?

Thanks for the fixes and sorry for the delay on getting back to it. Looks good to me!


Add support for RIFE v4.0 model

There is a major update to the RIFE model! It is apparently much faster and has less artifacts (though I believe v1.8 is still the best for anime...)
https://github.com/hzwer/Practical-RIFE
v4.0 - 2021.12.6 | Google Drive | 百度网盘，密码:mocg

Just a note: This is the same as #30 which I didn't see before filing this issue.

rife v4 model added


fix addrundata

Add a line to stop removing tags from metadata in the addrundata tool

Pull Request Functional Test Report for #2674 / 64eab02c895ee392372131969c6e1670cac46702
No tests identified for validation.
Help

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 52.21%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
1654

Relevant Lines:
3168

💛  - Coveralls


How to open database with immutable flag?

Hi,
this is more question than bug report.
I need to read firefox's bookmark database. But when FF is started the database is locked.
➜  hbo9xv4w.default sqlite3 places.sqlite
SQLite version 3.37.0 2021-11-27 14:13:22
Enter ".help" for usage hints.
sqlite> .tables
Error: database is locked
sqlite>

When I open  database with immutable flag, I can read items from database:
➜  hbo9xv4w.default sqlite3 'file:places.sqlite?immutable=1'
SQLite version 3.37.0 2021-11-27 14:13:22
Enter ".help" for usage hints.
sqlite> .tables
moz_anno_attributes
moz_annos
moz_bookmarks
...

Is it possible to open database using sqlite.lua library in immutable manner?
Thank you.

hmmm I believe is either append ?immutable=1 or a support for sqlite3_open_v2 is needed for this to work. could you try the first solution and how did you install sqlite.lua? using luarocks?

I use sqlite.lua in neovim text editor using packer plugin manager. Plugin is basically cloned into plugins directory.
I tried append ?immutable=1 to database file path provided to sqlite.new(path):open() function without luck.
Perhaps the sqlite3_open_v2 support is needed as you wrote.
Can I somehow help here?

I just did some reasearch and it seems to me that it's mostly likely something that needs to be appended to the uri, see Recognized Query Parameters and URI filename examples section.
I'm starting to believe that maybe open_v2 won't be needed and perhaps some internal url processing strips the query params.

Can I somehow help here?
Can you navigate to sqlite/defs, and run the following throw evaluating the file

  local uri = 'file:places.sqlite?immutable=1'
  local opts = {}
  local conn = M.get_new_db_ptr()
  local code = clib.sqlite3_open(uri, conn)

  if code ~= M.flags.ok then
    error(("sqlite.lua: couldn't connect to sql database, ERR:"):format(code))
  end

  for k, v in pairs(opts) do
    if not M.valid_pargma[k] then
      error("sqlite.lua: " .. k .. " is not a valid pragma")
    end
    if type(k) == "boolean" then
      k = "ON"
    end
    M.exec_stmt(conn[0], ("pragma %s = %s"):format(k, v))
  end

  vim.inspect(conn[0])

btw defs.lua is where ffi interface are. so if changes needs to made it will be made here.

I tried to evaluate code you posted above. But I changed the uri to contain absolute path to sqlite db like:
local uri = 'file:/home/janko/.mozilla/firefox/hbo9xv4w.default/places.sqlite?immutable=1'

Evaluation ended up on
defs.lua:690: sqlite.lua: couldn't connect to sql database, ERR:

Okay @Conni2461, informed me that perhaps open_uri need to be passed for this to work. Can you change the value of code to clib.sqlite3_open_v2(uri, conn, M.flags.open_uri, nil).
Also, to see errors change the body of code ~= M.flags.ok to

M.get_err_msg = function(code)
  for msg, ecode in pairs(M.flags) do
    if code == ecode then
      return msg
    end
  end
end

  if code ~= M.flags.ok then
    error(("sqlite.lua: couldn't connect to sql database, ERR: %s"):format(M.get_err_msg(code)))
  end

@JanValiska can u checkout #132 and pass as second argument {open_mode = "ro"}? https://github.com/dhruvmanila/telescope-bookmarks.nvim/blob/main/lua/telescope/_extensions/bookmarks/firefox.lua#L72. I believe it should work

Chcecked out #132 and added second agrument to new function on L32 of firefox.lua. I got this error:
E5108: Error executing lua ...nvim/site/pack/packer/opt/sqlite.lua/lua/sqlite/defs.lua:699: missing declaration for symbol 'sqlite3_eval'
stack traceback:
        [C]: in function '__index'
        ...nvim/site/pack/packer/opt/sqlite.lua/lua/sqlite/defs.lua:699: in function '__index'

That's odd. why the heck it's calling eval. are you still calling eval somewhere?

oh wait the uri needs to be edited and have ?immutable=1 as well. I'm testing telescope-bookmarks right now

I've changed db connection to:
  local db = sqlite.new(utils.join_path("file:"..profile_dir, "places.sqlite?immutable=1"),{open_mode = "ro"}):open()

and it works.
Also as you found I forgot to remove old eval functon from collect_bookmarks function :/

try
  local uri = "file:" .. utils.join_path(profile_dir, "places.sqlite") .. "?immutable=1"
  local db = sqlite.new(uri, { open_mode = "ro" }):open()

  local db = sqlite.new(utils.join_path("file:"..profile_dir, "places.sqlite?immutable=1"),{open_mode = "ro"}):open()

Nice, as soon as I merge open_v2 pr, another pr could be open in telescope-bookmarks to somehow have the above changes. For now, just have fun  with telescope-bookmarks

Awesome! Thank you! :)

This should be closed by #132 merge automatically, np you are welcome.


Timeout question

Hello @Yvand,
I have a question regarding timeout on AzureCP/EntraCP.
Since we moved to AzureCP, we have a regular issue on one of our custom application on SharePoint 2016.
After investigation, the root cause if because the timeout as reached on AzureCP. As timeout occurs, AzureCP doesn't return any results and claims, and then, the application trigger an exception which cause some trouble behind.
As this application only request claims for users that are still exists on Entra ID, Graph must necessarily return something.
So we have decided to grow up the timeout to 60s. This is much better, but we still have this timeout and issue some time to time.
From what I saw from the logs, AzureCP send the request to Graph and wait the answer until the timeout occurs.
By default on AzureCP, the timeout was 4s. I just saw that default on EntraCP is set to 15s. Is it too short?
I'm a bit surprising that timeout occurs sometimes, specifically at 60s. Did you encounter any timeout issue before?
What is your suggestion about this? Do we need to grow up this timeout again? or enable the retry mode?
I have some scripts that request Graph (several tens of thousands of requests) to provision and User Profile Service and answer time is really quite good. It's up sometimes (rarely) to 900ms, but most of them are below 300ms. So I'm not sure where to starts my investigation and having your point of view should be great.
Thanks!

Hello @julmsy, reading this, I immediately think about a certificate validation issue, due to servers not having direct access to internet, and the proxy in Windows is not fully configured.
Do you repro this issue on servers which have direct access to internet?
After lots of investigation on this topic with customers facing recurring timeout issues (that we knew were CRL validation timeouts), I finally found a way to fully configure the proxy, and it is documented in https://entracp.yvand.net/docs/how-to/configure-the-proxy/
All the steps in this article matter.
As a side note, running the tests in the project triggers exactly 3122 requests to graph.microsoft.com. None of them takes more than 1 sec (actually, considerably less).
I run those tests frequently, on various configs / versions of Windows Server, and this timeout never happens.
But the servers always have direct access to internet.


Is there a way to add a class to an html tag?

I'd like to use scroll-smooth class, https://tailwindcss.com/docs/scroll-behavior#adding-smooth-scrolling.
The MDN description of this class says that it can be used with any tag. However, as far as I have confirmed with chrome, it does not seem to work unless it is given to html tag.
I imagine this is why the html tag is used as an example in the explanation of tailwindcss.

@pojiro
No, the current spec does not allow this.
Please rewrite the title and body of this issue as a feature request.

Thank you for your explanation!!


feat: Add Seller's Dashboard layout KPH-9

Designed seller's dashboard layout and products page in grid view.

Mobile view of the navigation bar

Products screen in list view

I like it. I have some reservations concerning the mobile view.  See slack: https://karpah.slack.com/archives/C04UHQ89M7A/p1678787482579539


Documentation for cluster health API

Needs review both for technical correctness (Clifton?) and user-friendliness.

not sure if you want to commit api-docs.json

@graetzer Yes, apparently if the doc build requires regenerating the Swagger output (api-docs.json), then it needs to be committed (it is required as a book build prerequisite). There is some effort going forward to separate this out into a different commit, but from what I understand we don't have this set up yet.

Hi @kvahed , just wondering if you are okay with this PR, and I will merge it
Thanks!


undefined is not a function (evaluating 'global.nativeCaptureHeap(path)')

hi , I want to use "capture heap" function to dump heap , but throw TypeError: undefined is not a function (evaluating 'global.nativeCaptureHeap(path)') when I click capture heap in dev menu，I find jni JSCMemory.cpp in ReactCommon/cxxreact implement nativeCaptureHeap function ,but looks like not link in project

Closing this issue because it has been inactive for a while. If you think it should still be opened let us know why.


fix: permissionless node args

Follow up of #17

I think this should have been fixed in https://github.com/0xPolygon/kurtosis-cdk/pull/24

I think this should have been fixed in #24

I don't think the problem has been solved, as we are still using an alias. The same problem will occur if new services are added after the node without permission.


Add SVG support to built-in image preview

Adding the option of viewing a changed SVG as an "rich" image diff instead of the source diff.

This is probably an extension candidate because imho we do not support SVG display in the core.

It's supported on Github, that's my logic for requesting it anyway 😄

You are welcome to submit a PR to add SVG support to the image preview. Otherwise I would recommend checking out the marketplace for some really nicely done SVG extensions.

Ah, well I already have jock's SVG preview extension. I want to see a visual preview of SVG diffs in the working tree for VSC's Git integration. There is only code previews atm.

I'm starting preliminary work on this because it seems too niche for engineer time 😄 I think your experimental Markdown Preview gives a good UX for this feature. Will ask questions here if I get confused

My first step would be enriching the built in image preview to support SVGs if you want to explore that.

Yeah good shout, I've already mapped nonexistent commands for SVG in extensions/image-preview

@lramos15 some SVGs might be missing key view attributes (viewBox, height and width).
Should I make getWebviewContents produce a sanitised SVG container and add fallback view data?
This would mean pulling in the<EMAIL_ADDRESS>NPM package, of course

I think it's fine to come up with some defaults if one isn't provided, but I would avoid adding any additional npm packages as we want to limit the possible dependencies. You could of course show a failed to load message similar to what we do with images now if they cannot be loaded.

If the file is missing a viewBox, the preview might not show the bounding box (which is a broken experience imho). The default for  with an SVG source is 300x by 150y. However, SVGs without a viewBox are canvas drawings and sketches that usually go >1000px.
I suppose I could prevent centering of SVGs without a viewBox - bind them to the top left and let them take the entire webview box. That's not broken entirely but is inconsistent with other previews.

How do other previews go about doing it? They must create a viewbox of some sort? Sorry I'm not well versed in SVG viewing.

Normally, the browser can use the SVG attributes to assign an intrinsic size. Without that data, the  renders exactly like a  (starting from the top left)

@thunder-coding did you mean to 👍🏾 instead of 👎🏾

@mjbvz Assigning you as you're better equipped to provide guidance here since you wrote the image preview.

Normally, the browser can use the SVG attributes to assign an intrinsic size. Without that data, the <img> renders exactly like a  (starting from the top left)

From my understanding that's all the image preview is doing. It just slaps an image tag inside the iframe. I assume including a default reasonable size if one wasn't included would be the way to go.

https://user-images.githubusercontent.com/82655227/123811672-5af74200-d8eb-11eb-8eaf-d0fbd67cc963.mp4
This is the display behaviour I'm going for in the custom editor. I actually based this behaviour on the viewing behaviour of SVGs without a viewBox attribute in Chrome 91.

I'm sorry to say this @mjbvz, but because the VSC repo doesn't use Github Discussions, this issue is likely to never get any real tangible feedback. I can crosspost this on Reddit and see what that does, but it's not likely

As the bot noted, this issue is a candidate for the backlog ( https://github.com/microsoft/vscode/issues/124901#issuecomment-851833135 ) so we are waiting for organic feedback to gauge how many people are interested before considering this

I've demoed the reflow mode , what do you think?
https://user-images.githubusercontent.com/82655227/124367100-5cf33500-dc4c-11eb-9543-205d43474897.mp4

@mjbvz is there a way I can elevate this to the default SCM diff editor for *.svg?

@mjbvz Are staff that firm about the 20 likes? If so may I post this as an extension and credit this repository for SVGPreviewManager?

Now that the new version's out, I hope this can get released soon.
I can publish this as an extension otherwise, seeing as Matt has some marketplace extensions with a similar scope.
What would you prefer @mjbvz @lramos15 @misolori?

Alright extension it is, thanks for your patience and explanation

The bot misbehaved and didn't close this after 2 months and it's now been 4 and still hasn't reached the threshold.
I use https://marketplace.visualstudio.com/items?itemName=cssho.vscode-svgviewer personally which works great for me and definitely text is the right default for SVGs as the preview cannot be edited (plus VS Code is primarily a text editor).

Unfortunately the other SVG preview extensions didn't meet my needs, though I liked lishu's. I'm looking into publishing the PR I made as my own repo then baking in feature parity with lishu's svg-2 preview.

Right, I've extracted #127388 into a separate SVG extension. Development will continue over the next few months until it combines the feature set of all extensions at the Marketplace.
https://marketplace.visualstudio.com/items?itemName=sndst00m.vscode-native-svg-preview


[Bug]: Wrong Path Generated in .adminjs/.entry.js file

Contact Details
No response
What happened?

Wrong Path for Login Component is generated.
How could I fix this issue?
Bug prevalence
Everytime I run the code.
AdminJS dependencies version
"adminjs": "^7.2.1",
What browsers do you see the problem on?
Chrome
Relevant log output
No response
Relevant code that's giving you issues
No response

Can you share how you add your Login component to ComponentLoader?


Debug fails to show debug toolbar and toggle status bar color

Testing #153344
I just pressed F5 and this happened:

No idea how to repro.

I know there is something suspicious about this code because every once in awhile I'll stop debugging and get stuck in a state where the debug toolbar is shown but has no sessions in it. I haven't seen this issue though.
Did you get a timeout message, or could you tell whether debugging was otherwise in a good state?

No message, as far as I remember it. Yeah I'm pretty sure debugging was in a good state, and it was really a UI thing.


Fix for "Add to Home Screen" feature on iOS 13

iOS 13 requires not only the "apple-mobile-web-app-capable" meta tag but also either one of the entries "display": "standalone" or "display": "fullscreen" in the manifest file. Otherwise the "Add to Home Screen" function only creates a link to TileBoard which opens the interface in Safari. With the manifest "display" entry it behaves more like a "progressive web app", hiding the browser UI and address bar.
https://developer.mozilla.org/en-US/docs/Web/Manifest/display

Thanks for this PR @danielfernau - fixed this issue for me :)
Do you find that it does not refresh the content after closing/reopening the "App" ?

Happy to hear that @jeremywillans :)
Yes, I experienced this issue a few times as well. What in most (but not all) cases works for me is to close it, swipe it out of the multitasking view and then re-open it. Not sure what's causing this, though... Probably has something to do with the way Safari handles site caches, tabs and (re)loading the web app in general.


[Visual C++] Provide alternative to array designators.

Even if they are supported in GCC and Clang, C99 array designators are
not part of the current C++ standard (they will be in C++20), so they
are not supported in Visual C++.
This commit provides an alternative for Visual C++ (which should work in
other compilers) which doesn't use array designators.
I think Clang 10 will start printing a warning about this incorrect
usage.
Introduced in #28052 and started breaking Windows CI in https://ci-external.swift.org/job/oss-swift-windows-x86_64/1899 (it was broken before, but this error starts in that one).

@swift-ci please test Windows platform

@swift-ci please smoke test

@swift-ci Please test Windows platform

I will let the Windows PR testing finish with this code. I want to check that my local results are valid in the CI machine. I can remove the non-standard implementation and re-submit later with a comment about why the strange construct.
Also, if some C++ wizard knows a cleaner way to initialize a constexpr array, I would not mind learning about it.

The Windows CI went beyond the failure point just fine. Re-submitted with the non-standard implementation removed.
@swift-ci please smoke test

It seem like Clang doesn't like this line:
/Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test/branch-master/swift/lib/AST/DiagnosticEngine.cpp:140:37: error: array initializer must be an initializer list
18:19:13 static constexpr const char *const *educationalNotes[LocalDiagID::NumDiags] = EducationalNotes<LocalDiagID::NumDiags>().value;
18:19:13                                     ^
18:19:13 1 error generated.

Trying to work around that issue I'm also running into issues with "pointer to subject of temporary is not constexpr". I'm going to prepare a revert of my patch just in case.

clang accepts
static constexpr EducationalNotes<LocalDiagID::NumDiags> _EducationalNotes = EducationalNotes<LocalDiagID::NumDiags>();
static constexpr auto educationalNotes = _EducationalNotes.value;

I'm not sure if MSVC will like that use of auto though...

Gonna send that in a moment. I don't have the Windows machine at hand anymore, so I will trust that the CI will tell us if it works.

@swift-ci please smoke test

(I will go to bed, so anyone, feel free to merge if everything is green)
@swift-ci please test Windows platform

https://ci-external.swift.org/view/Pull Request/job/swift-PR-windows/163/ is the CI job, but it haven't been linked to this PR for some reason.

I should have copy/pasted the solution provided, not try to type it from memory. Sigh.
@swift-ci please smoke test

@swift-ci please test Windows platform

Merging this one. Seems to work OK in the three platforms.


TEAMNADO-7822 adding rpms signature scan to tekton pipeline

adding rpms signature scan to pull request and push yamls
No testing needed.

/retest

/retest

/retest


Get mnemonic

Somehow, the mnemonic pop-up window disappeared before I could take it down. Doesn't seem like there is an option to get mnemonic. That's definitely a must if you have the PW.

Fixed it! https://github.com/nopara73/HiddenWallet/commit/c2ff21b5403c655033c6c990221d646978c56ed2

To clarify it doesn't disappear for me, until I click "ok", but I changed it to a different way to do it, so it must work now. Are you using OSX by any chance? I did not test in OSX yet.


[stable/mongodb-replicaset] feature: Add support for secret annotations when auth is enabled

Is this a new chart
No
What this PR does / why we need it:
To use mongodb-replicaset chart with auth.enabled is set and not adding the username/password credentials to values.yaml, kubernetes secret is created outside the chart and being referenced by using auth.existingAdminSecret and auth.existingKeySecret .
Started experimenting with vault-bank for injecting secrets from HashiCorp vault to kubernetes pods/secrets and this feature will be really useful.
For users who do use vault-bank or any other dynamic secret injector, adding secret annotations when auth is enabled will eliminate creating secret out of the helm chart.
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/assign @steven-sheehy

e2e tests infrastructure is currently broken.

I think it failed because the e2e script was updated in the master branch, rebasing from master resolved it.

Much thanks to you 🥇


⚠ Samsung has degraded performance

In 2fe310d, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2687 ms

Resolved: Samsung performance has improved in 20d5730.


bump and pin isort, apply all automatic fixes

Fixes the build.
Changes proposed in this pull request:

apply all of the isort changes that resulted from the latest version
pin to the latest version (4.3.15) so this doesn't happen again, unless we bump the version on purpose

:+1:


Issue with layout when using same page across multiple routes

Environment

Operating System: Linux
Node Version:     v22.8.0
Nuxt Version:     3.13.2
CLI Version:      3.14.0
Nitro Version:    2.9.7
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      -
Runtime Modules:  -
Build Modules:    -

Reproduction

Create a page and link it with multiple routes
attach a layout to it via definePageMeta
Now build and see only the first route got the layout.

Describe the bug
When I try to attach multiple routes to the same page and use a layout with definePageMeta, the layout seems to load only for the first route. The other routes still function correctly but do not apply the layout. This issue occurs only when we use the same page across different routes.
For example, if we have a page named LayoutPage with two routes: /admin/hello and /admin/hi, and apply the layout admin-master-layout to both routes, only /admin/hello displays with the layout, while /admin/hi does not. Could someone clarify if this is the expected behavior, or if it's a potential bug? If so, are there any workarounds available?"
Additional context
No response
Logs
No response

me too facing the same issue with nuxt3.

Basically with scanPageMeta we scan and set the layout in the route meta. If you add a second copy of an already scanned route we don't rescan it as we want to allow you to change the scanned meta. So you need to add the layout on the second page you've added manually.
This will no longer be necessary after https://github.com/nuxt/nuxt/pull/28861 is merged.
For now you could set experimental.scanPageMeta to false.

Duplicate of https://github.com/nuxt/nuxt/issues/27814.

Sorry the issue still there i have tried both removing and using the value "after-resolve" for the property "scanPageMeta" in nuxt.config but still i can see the layout only work for only one page assigned to a route but i need multiple pages work for a same route without any layout issue.Any help is highly appreciated.


upgrade phpstan 1.x

Thanks for the PR - wasn't expecting to see this much logic refactoring, but it looks good for the most part, certainly clears up some of the existing logic in places.  I added some comments if you could please address those.

Codecov Report

Merging #446 (662aec9) into master (dc3c041) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #446      +/-   ##
============================================
- Coverage     98.18%   98.16%   -0.02%
+ Complexity     1586     1585       -1
============================================
  Files           144      144
  Lines          4023     3985      -38
============================================
- Hits           3950     3912      -38
  Misses           73       73

Impacted Files
Coverage Δ

src/AnnotationReader.php
94.92% <ø> (ø)

src/Containers/BasicAutoWiringContainer.php
95.65% <ø> (ø)

src/Mappers/GlobTypeMapperCache.php
97.72% <ø> (ø)

src/Mappers/StaticTypeMapper.php
100.00% <ø> (ø)

src/Middlewares/SecurityFieldMiddleware.php
100.00% <ø> (ø)

src/QueryFieldDescriptor.php
97.82% <ø> (ø)

src/Types/MutableInputObjectType.php
100.00% <ø> (ø)

src/Types/MutableTrait.php
91.66% <ø> (ø)

src/Utils/Namespaces/NS.php
100.00% <ø> (ø)

src/Annotations/MagicField.php
100.00% <100.00%> (ø)

... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc3c041...662aec9. Read the comment docs.

@janatjak One last question before we merge this.  Do we have test coverage on the SchemaFactory testing the scenario where only factories are provided and only mappers provided?

@janatjak One last question before we merge this. Do we have test coverage on the SchemaFactory testing the scenario where only factories are provided and only mappers provided?

Done

Thanks again for working through this.


structures with multiple fragments

It appears that we overlooked the fact that structures can consist of multiple fragments. When this occurs, both atoms and unsaturations are included within the mfInfo.parts property as an array that contains the corresponding information for each fragment.
Given that atoms are stored as text data, I created a workaround by converting an array of atoms (e.g., [{atoms1},{atoms2}]) into a string. However, the issue with unsaturations, which are stored as integers, presents a more significant challenge. Currently, the highest value of all fragments is being used (as of 20.03.23), but this is not a permanent solution.
We need to find a more comprehensive solution that addresses the unsaturation problem.

I think if fragment>1 we should just ignore unsaturation and atoms.

Finally we will add the sum. A new version of mass-tools will be released to calculate the sum in case there are any parts: https://github.com/cheminfo/mass-tools/commit/b96a6d605af0d01bf9bac54de341c27f6c19a8c3


[GSoC 2018] All Search Improvements

Here is the all code related to search upgrade. its rebased upon master and squashed the migration.
Things need to do

[x] remove old code #4635
[ ] Docs of settings

This need to be merged after #4635 get merged.

@ericholscher Fixed as per you reviewed! I think it can be merged now!


New Macro doesnt appear in the compendium.

As title.
New macro isn't in the compendium, its just an empty compendium.

Thank you for the feedback. I thought I did it correctly. Still figuring stuff out. I will (hopefully) get it to appear in the next update.
Until then you can find it as a .ja file in the module folder.
Sorry for the inconvenience.

Yep, I did see it in the module and am using it successfully (great macro btw), just thought id let you know about the compendium 😉

I guess the problem was that I set the macro to be for 5e only. I now set it to be available for any system. Is your world pathfinder/not 5e? Does it work with the newest update? If so I will close this issue. Hope it helps. :)


reporter: Implement a reporter for the Gitlab license model

See individual commits for the details.

General nit: "GitLab" is written in camel-case, with upper-case "L", see https://about.gitlab.com/company/.

General nit: "GitLab" is written in camel-case, with upper-case "L", see https://about.gitlab.com/company/.

Would you apply that also to class, function, variable names or only to everything else?

General nit: "GitLab" is written in camel-case, with upper-case "L", see https://about.gitlab.com/company/.

@sschuberth Would you apply that also to class, function, variable names or only to everything else?

To everything, incl. class, function, variable names.

To everything, incl. class, function, variable names.

Done.

@sschuberth  @tsteenbe I believe I've addressed all and its ready for another round.


Update layout of homepage

The homepage should be geared towards people who want a general overview of the project. Then separate tab(s) should be for Users & Contributors (links from this page(s) would contain info on Development Practices, Data Contract, the Note callout on the current 'update-docs' branch index, etc.).
One possibility for the homepage tabs could be:

one tab for each aeon_repo
one tab called "Users & Contributors"

Home

short description of the project
link to "Getting started" (target audience: everyone)
link to "User guide"
link to "Contributor's guide"

Getting started (goal: decide if the Aeon platform is for you)

Overview of the project - what, why, who of Aeon
Aeon fundamentals

Hardware components (e.g., mechatronics)
Software components (e.g., data acquisition, architecture, analysis)

User guide

Tutorials (learning-oriented, to acquire basic competence, practical steps)
How-to guides (task/problem-oriented, assumes competency, practical steps; e.g., how to install feeder, how to analyse position data)

Contributor's guide

General development guidelines, workflows
Language-specific guidelines (e.g., style guidelines for developing in C#, Python...)
Tutorials (learning-oriented, to acquire basic competence, practical steps; e.g., setting up dev environment, running tests, building docs)
How-to guides (task/problem-oriented, assumes competency, practical steps; e.g., how to contribute docs, how to add a new Device)

Reference (information-oriented, theoretical knowledge)

API reference
Glossary

About

design considerations (explanation - understanding-oriented, theoretical knowledge)
goals
code of conduct
project maintainers


Consider adding an AuthorizationPolicyTagHelper

It would be nice to have a tag helper to SuppressOutput for elements when an authorization policy is not satisfied.
Consider this markup:

You Can Access Foo

With this tag helper:
[HtmlTargetElement(Attributes = "asp-policy")]
public class AuthorizationPolicyTagHelper : TagHelper
{
    IAuthorizationService _authorizationService;
    IHttpContextAccessor _httpContextAccessor;

    public AuthorizationPolicyTagHelper(IHttpContextAccessor httpContextAccessor, IAuthorizationService authorizationService)
    {
        _httpContextAccessor = httpContextAccessor;
        _authorizationService = authorizationService;
    }

    [HtmlAttributeName("asp-policy")]
    public string Policy { get; set; }

    public override async Task ProcessAsync(TagHelperContext context, TagHelperOutput output)
    {
        if (false == await _authorizationService.AuthorizeAsync(_httpContextAccessor.HttpContext.User, Policy))
        {
            output.SuppressOutput();
        }
    }
}

Thus the element is hidden if the user is not allowed. This would be quite nice to have this built-in for RC2/RTM.
The code's all yours // CLA signed :)
// @HaoK @blowdart

I love this. :heart:

+1

How about 'resource' and 'requirement' scenarios?

Personally, I'd make 2 diff tag helpers -- one for simple policy, and another for resource-based.

I like it! :+1:

Well, there you go -- count 'em: 3 +1s -- that's it, they have to do it now. :)

We're largely done taking features for this release, so putting this on the backlog. Cool feature!

I have created an Authorize tag helper that supports roles, policies and authentication schemes. It works exactly like the Authorize attribute and Authorization filter.
Only authenticated users

Welcome !!

            If you're logged in, you can see this section

Only users who are members of a role

Admin Section

            Only admin users can see this section. Top secret admin things go here.

Only users meeting the requirements for a Policy

Seniors Only

            Only users age 65 or older can see this section. Early bird dinner coupons go here. The app has a policy named Seniors which requires a claim of type Age with a value greater than or equal to 65.

Policy and role combined

Admin Seniors Only

        Only users who have both the Admin role AND are age 65 or older can see this section.

Would the team be willing to consider including this in the next release of  ASP.NET Core? If so, I would be happy to submit a pull requests once I have added some unit test.
My implementation is here:
https://github.com/dpaquette/TagHelperSamples/blob/master/TagHelperSamples/src/TagHelperSamples.Authorization/AuthorizeTagHelper.cs
and I wrote a blog post detailing the usage here:
https://www.davepaquette.com/archive/2017/11/05/authorize-tag-helper.aspx

Looks like the tag helper @dpaquette has shared here solves the problem and it's really nice.
Closing this as there is already a good solution available.


Missing License Information

I was looking for the license of this project (and was not able to find it).
Will it also be Apache 2.0 similar to the swc project? It would be great to have some license information for deciding whether or not a project can build on this.
Thanks for your great work and the contribution to the open source community :+1:

There is a license field already: https://github.com/kwonoj/swc-coverage-instrument/blob/main/package.json#L52=
only actual license doc is missing. Will update quickly.

Awesome. Thank you :)

closed via https://github.com/kwonoj/swc-coverage-instrument/pull/165


Explicitly show the TEST_TRACK_API_URL domain

The document only shows the .dev domain which works only for pow.cx user. For other users, we need to use localhost:PORT_NUMBER instead.
Change from http://[myapp]:[your new app<EMAIL_ADDRESS>to http://[myapp]:[your new app password]@[your-app-domain]/ or adding a note would be great.

I opened it in a wrong repo. This should be on Rails client.


Create 0000-01-02-racheljurs.md

created a branch, created a file, made a commit, and opened a pull request

Files merged


Set name of device in plugin config

Hi, is it possible to set device name in config? I can do it in HomeKit obviously but the problem is that after HB restart it reverts back to original device name every time. Thx in advance

Added in 1.5.2


Update setup.py file to work for clang

(change user email)

thank you @serenavinciguerra89 ! Now we jut need to finish the patch. I can do this by checking out your branch and committing it in principle, but I want to show how you do it.

You need to change some other files and the documentation.
The new version will be v0.7.2 right?
So we need to change that number in:

setup.py
xpsi/init.py
docs/source/conf.py

Then to change the documentation, you can edit history.rst to state
the change.
You can update the pull request by pushing to your fork again.
Then if I can't remember anything else to change, I merge it and
I'll build the documentation again and push it to the server.
Did you mention other things that you want to change in the manual/documentation
that you can do simultaneously.


Custom Platforms/Widgets as platforms

Enhancement idea - it would be awesome to be able to create a custom platform page that acts as a link to an android app.  I would love to use Daijisho as my total device launcher, and it would be great to be able to make 'platforms' for Xbox, Xbox Gamepass, and other cloud gaming apps.
I know that you can access apps on the 'Apps' tab, but it would be nice to have the option of making widgets in the Platform tab too.

+1, I use my handheld more for Gamepass, Chiaki, Moonlight than I do for retro gaming. This option would be excellent!


#SC-1465: Audit scripts to produce additional monitoring metrics

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 5
- Added 34

Complexity increasing per file
==============================
- platform-modules/batch-models/src/main/scala/org/ekstep/analytics/model/MetricsAuditModel.scala  3
- platform-modules/batch-models/src/main/scala/org/ekstep/analytics/job/JobFactory.scala  1
- platform-modules/batch-models/src/main/scala/org/ekstep/analytics/util/SecorMetricUtil.scala  4

See the complete overview on Codacy