v4 - Is it possible to wrap private routes?

Since the new v4 is very declarative, I am trying to declare some of my routes inside a PrivateContent wrapper. The code below show how I am doing that:

I will hide the imports for brevity.

PrivateContent.js
class PrivateContent extends React.Component {
  componentWillMount() {
    console.log('Private content!');
  }

  render() {
    return (

        {this.props.children}

    );
  }
}

export default PrivateContent;

Routes.js
const Root = () => (

    <Match
      exactly
      pattern="/login"
      component={LoginPage}
    />

    <Match
      pattern="/forgot"
      component={ForgotPage}
    />

    <Match
      pattern="/password-reset"
      component={PasswordResetPage}
    />

    <PrivateContent>
      <Match
        exactly
        pattern="/"
        component={AppContainer}
      />
    </PrivateContent>

);

export default Root;

My expectation was to access / and see in the console Private content! message. And when I access /login not to see the message.
However the message is shown even if I access the /login or /forgot routes.
How can I get this to work as expected? Does react-router v4 behavior this way? Am I doing something wrong?

Looks like you need the new Switch component. It's in v4 but not yet part of an official release - check out https://github.com/ReactTraining/react-router/blob/v4/packages/react-router-website/api/Switch.md for some insights into how it will work.

Hmm, interesting. I think inverting should work, since the PrivateContent will aways performe the same check for authenticated user. Thank you for the information. :)


Firefly Stuck After Entering Pin

Issue description
Firefly is stuck after entering pin. Left it and it reverts back to the profile screen without any error message.
Wallet version
Firefly 1.0.0
System specification
Windows 19042.928
Is it a repeatable issue?
Y
Steps To reproduce the issue
Explain how the maintainer can reproduce the issue.
1.Open Firefly
2. Select profile
3. Enter pin
Expected behaviour
Open the wallet UI.
Actual behaviour
Stuck on-screen after pin.

Errors
No errors or messages are provided

Yep. Same over here been trying for 2 days now and no result.

Same thing for a day now.  If you bypass the loading screen by going to settings it states no wallets found and all funds show zero.

I have managed to get a workaround by just creating a new profile but I cannot delete the original profile.

Here the same, re-installing will not help either.

Thanks


PP-1969 Map internal CAPTURE_READY to external submitted

WHAT

Changing the capture process to be async made possible for a get payment after a user is returned to the service to have a non terminal state as submitted. Changing CAPTURE_READY to external success fix this issue since now charges are handled in the background and the client get the response straight away before capture happens.

There were errors, for info, please see...

There were errors, for info, please see...

This is not passing e2e tests because of this https://build.ci.pymnt.uk/job/run-end-to-end-tests/805/cucumber-html-reports/report-feature_uk-gov-pay-acceptance-tests-expire_payments-feature.html .

The problem with this is a payment can go from SUCCESS to EXPIRED, but I guess that is a smaller problem than the problem that this solves.

rebuild

There were errors, for info, please see...

rebuild

There were errors, for info, please see...

rebuild

There were no errors, go have a cup of coffee...


UseDeepClone for a single level

I am trying out Mapperly and am very impressed. Well done.
I did however find a problem, I do get a stackoverflow error when using the UseDeepClone feature.
What I have done is that I created a MinimalApi using EF Core 6 and the Northwind database, as my test system.
To test complex object mapping, I tried to map Orders to a OrdersDTO.
I get a StackOverflow error when I am using the 'UseDeepClone' feature to map the Orders and their Orderlines, but is ok if I do not use 'UseDeepClone'.
System.Text.Json had the same problem and introduced 'IgnoreCycles' as the fix. Is it possible to do something like IgnoreCycles or specify the DeepClone level of 1?
If not, below is a workaround that meant I could map the Orders to a OrdersDTO, successfully.
Workaround:
The workaround for anyone else facing this issue is not to use the 'UseDeepClone' feature, just use [Mapper].
Then use System.Text.Json to clone the Mapped object to a DeepCloned object with IgnoreCycles turned on. This means that the object gets deep cloned without the stackoverflow issue (but at the cost of performance).
Here is the code for the deep clone using IgnoreCycles:
internal static class Extensions
{
    internal static JsonSerializerOptions jsonOpts = new() { ReferenceHandler = ReferenceHandler.IgnoreCycles };

    internal static T DeepClone<T>(this T? source) where T : class, new()
    {
        return CloneInner(source) ?? new T();
    }

    private static T? CloneInner<T>(this T? source) where T : class
    {
        if (source is null) return null;

        var jsonUtf8Bytes = JsonSerializer.SerializeToUtf8Bytes(source, jsonOpts);
        Utf8JsonReader reader = new(jsonUtf8Bytes);
        using var jsonDoc = JsonDocument.ParseValue(ref reader);
        return JsonSerializer.Deserialize<T>(jsonDoc.RootElement.Clone().GetRawText(), jsonOpts);
    }
}

Mappings:
    public static CarDto MapToDto(this Car src) => src.ToDto().DeepClone();
    public static Car MapFromDto(this CarDto srcDto) => srcDto.FromDto().DeepClone();

    private static partial CarDto ToDto(this Car src); // this is the source generator
    private static partial Car FromDto(this CarDto srcDto); // this is the source generator

Example of usage:
    CarDto dto = car.MapToDto();
    Car newcar = dto.MapFromDto();

Thank you for this feature request, this would definitely be a cool feature for Mapperly. We will look into this, however this seems to need a few changes (currently we don't carry any context around...) and therefore may take a while to be implemented.

That is great, I can use my workaround for now, when you have a solution, I will be happy to try it out.

Closing in favor of https://github.com/riok/mapperly/issues/172


MTK models

Hello,
I was wondering if the library works with other MediaTek chipsets like the MTK3336 ?
Thank you,
Fouad

I don't have a MTK3336 to test with but I think it'll work.

hello again :)
I ended up buying the Adafruit ultimate GPS with the MT3339 chipset.
But i'm having a problem actually getting the AGPS to work. Even when I send EPO, position and time to the chipset, I can't get a fix with the built in antenna and indoors.
When I use an external antenna and put it outside I get a fix almost instantly even without sending the EPO,position,time data.
Do you have any idea why this would happen ?
Thank you very much

Hi there,
To answer your question regarding why it didn't work indoors without an antenna:
EPO data/AGPS is not a magic bullet. It still requires that you have a good signal from at least 3 satellites for 2D location  and 4 satellites for 3D location. The fact that you didn't use an external antenna indoors means that the signal received (if any) is not strong enough to determine a location.
Why your GPS unit found a fix almost immediately:
EPO data persists between power cycles, so if you sent the EPO data to test the unit indoors before outdoors, it makes sense that the GPS picked up a location almost immediately. If you didn't upload EPO data beforehand, then this just further strengthens my argument above. Using an external antenna increases the gain of your unit, which allows it to better pick up weaker signals, thus providing more information to the MTK3339.
Answer to your power loss question:
According to the manual and adafruit's product page: The unit will factory reset upon power loss. This does not include EPO data, which is stored on non-volatile memory.

The other factor to consider is time.  The EPO data is completely useless if the unit doesn't have the correct time.  Outside, it can get the time well before it gets a fix.  In fact, it has to have the time BEFORE it can get a fix.  It sounds like inside it's not even getting the time so a fix will be impossible.  BTW, not only does the battery preserve settings, it also keeps the internal RTC working so even if you disconnect power, the unit will have accurate time immediately on main power up.
Use the gpsstatus tool while indoors to see if the unit has good time and what kind of signal you're seeing.

Thank you very much for this information !! :) the gpsstatus tool was really helpful in comparing TTFF between different conditions.
I love the work you've done on this library.
Have a good day,
Fouad


cipheycore error

⚠IMPORTANT⚠ if you do not fill this out, we will automatically delete your issue. We will not help anyone that cannot fill out this template.

[* ] Have you read our Wiki page "Common Issues & Their Solutions"?
Yes.

Describe the bug
A clear and concise description of what the bug is.
ERROR: Could not find a version that satisfies the requirement cipheycore<0.4.0,>=0.3.1 (from ciphey) (from versions: 0.0.1)
ERROR: No matching distribution found for cipheycore<0.4.0,>=0.3.1 (from ciphey)

I solved this problem by installing 64 bit Python.
If you have a Windows operating system, of course

For Linux, this might be because of outdated PIP tool, upgrade pip3 first, then install ciphey
python3 -m pip install pip --upgrade
python3 -m pip install ciphey --upgrade

I'm closing this issue because you didn't fill out the full issue template so we don't know what system you're on and what versions. This error is usually caused by not using 64 bit Python and/or not using Python 3.7 or 3.8.

I'm closing this issue because you didn't fill out the full issue template so we don't know what system you're on and what versions. This error is usually caused by not using 64 bit Python and/or not using Python 3.7 or 3.8.


Select: add the ability to set a prefix

Like this one: https://yadi.sk/i/HL6bAea2s8QbD

I propose to make more flexible, e.g. using property pattern = "Day: %value" or decorator = function(value) { return 'Day: ' + value; }.

To be fair, I don't like both variants, as they solve only particular issue, but don't introduce any API points for further extends. For example, select from bem-components allows to customise it in a way below:

or even this way

Currently, I suggest to introduce a protected method Select#getButtonText() and to override it on the project level in custom modified component. E.g.
class SelectWithLabel extends Select {
    /** @verride **/
    getButtonText() {
        return `${this.props.label}: ${super.getButtonText()}`;
    }
}

/cc @pasaran @doochik

Probably it's better to have an array of selected items, not just joined text.

Ok, how about this solution:
https://gist.github.com/VodkaBears/8461cf247a096440cb7fd0a3c18cb9ba.

Currently, I suggest to introduce protected method Select#getButtonText() and to override it on the project level in the modified component. E.g.

Anyway, the package has an unstable version, so it is ok if the public API will change in 0.x, but undocumentated methods may change at any time.

Updated.

Currently, I suggest to introduce protected method Select#getButtonText() and to override it on the project level in the modified component. E.g.
Anyway, the package has an unstable version, so it is ok if the public API will change in 0.x minor versions, but undocumentated methods may change at any time.

Decided to make a protected method which will be the part of the API.

up

Looks ok.
But I would use renderSomething for jsx-methods (returning React.Element).
I think getButtonText is more appropriate. But it's not that important, renderButtonText ok too.

Nice!

I Lloyd publish a new release latter today


Small typo correction

can you base the PR against dev? I tried to rebase but got a permission error when pushing to your branch.


fix: fix DeepReadonly and DeepMutable definitions not being recursive

Reverts an error in the last refactor

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.271%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1210

Relevant Lines:
1293

💛  - Coveralls


Namespace attribute

Hello guys, I'm not sure if it's a bug or not but the attribute [Namespace(string)] seems to do nothing.
Here is my code :
    [External]
    [Namespace("photonui")]
    [Name("Base")]
    public class Base
    {
        public extern void Destroy();

        public extern void RegisterCallback(string id, string wEvent, Action callback, object thisArg);

        public extern void RemoveCallback(string id);
    }

I am expecting the ouput to be : photonui.Base but it's actually Base.
What is the goal of the Namespace attribute ?

Hi @MangelMaxime,
That is right, a Namespace attribute is for the class' namespace, but a Name attribute overrides it, because it specifies a full name including a namespace (if exists).
So, you can either use
[External]
[Name("photonui.Base")]
public class Base

or
[External]
[Namespace("photonui")]
public class Base

I've revised the Name and Namespace sections in the Attribute Reference knowledge base article, mentioning that the Name attributes takes precedence over the Namespace one.

@DaniilVeriga thanks for the answer.
And thanks for letting me know about the Attribute Reference page :)


Allow working with Python 3.5

When the wfastcgi.py file is in a folder with spaces (default for Python 3.5), enable and disable don't properly quote the filename, so it gets passed to python.exe unquoted (and only "C:\Program" counts as the filename.

Resolves (probably) issues 1107


ODBC or JDBC support??

I LOVE this!!! So how ungrateful would I be to request ODBC and/or JDBC support?
I use dbeaver because it handles just about anything ODBC/JDBC, but boy, would I love to store my sippets in notebooks in my node projects in vscode, and just run them whenever.

I offer to assist in whatever way I can:

I'm a newbe javascript developer, but can follow broad outlines

(especially with good examples)

my dbeaver configurations and classes, if that helps

relates to #1

relates to #1

Adding a driver for ODBC sources is not the same as Oracle. I do not believe this is related. Closing the Oracle request should not close this one. Separate issue entirely.

I'm jammed up for the next few weeks, but when things loosen up, will take a look at https://github.com/cmoog/vscode-sql-notebook/blob/a0fea8ce8808c86c683cc5b3dd634cc0af242897/src/driver.ts, and see if there is anything i could do!
(I miss Chicago!!! I lived in Wrigleyville from 90-96 before moving to SF)

Looks like something like:

node-jdbc: The most feature rich.  Currently looking for maintainers or sponsors.
node-jdbc-connection: Not much features.
node-jdbc-driver: More up to date but looks like the API is not very "generic".

might be used here.

More alternatives:

naxmefy/jdbc: Has some problems on Windows (because node-java)
node-jdbc-tibero: A fork from node-jdbc-driver

And for the ODB support, looks like this might be the way to go:

node-odbc


Problem with dynamic scaling

Hello, I would like to report a bug.

Swiper Version: 4.3.5
Platform/Target and Browser Versions: Everywhere
https://codepen.io/jannnovak/pen/eLNqYx

What you did
I have a situation where I have to for some reason dynamically scale some parts of page. Parts also include one or more swiper components, which is causing me some troubles. The problem is if transform: scale(x), where x != 1, is applied on those parts I can no longer scroll to the end of swiper. I have created a simple fiddle where problem is simulated. To see a problem resize a browser and try to scroll to the 10th slide. I did try with update function but does not help. Is there a way I could fix?
Expected Behavior
To be able to scroll to the end of swiper.
Actual Behavior
Can't scroll to end, scroll is resisting!

Issue because getting slide size with getBoundingClientRect returns size considering transform, so it doesn't work in this case. I pushed some fix so the roundLengths option need to be set to use other calc and transform won't be considered


UI Improvements (task #3151)

Current coverage is 48.12% (diff: 100%)

Merging #20 into master will not change coverage

@@             master        #20   diff @@
==========================================
  Files             3          3
  Lines           133        133
  Methods          13         13
  Messages          0          0
  Branches          0          0
==========================================
  Hits             64         64
  Misses           69         69
  Partials          0          0

Powered by Codecov. Last update 08eeb26...5108ac5


[feature] Implement a "real" logging system

Currently print() calls  are used for "logging". This issue shall cover two parts:

replace all those print() calls with calls to adafruit_logging
implement a handler for sending log events to a syslog-server (via UDP as implemented by the circuitpython-usyslog library)

The configuration shall be part of settings.toml with the default log-level being set in the SYSTEM table/section:
[SYSTEM]
LOG_LEVEL = "info"

An adopted log-level for a component shall be set using a corresponding setting with its table/section, like so:
[PRINTER:test]
DRIVER="SERIAL"
LOG_LEVEL="debug"

Whereas the log-level shall be adaptable per component, the log-server setting shall only be settable "globally" - in the SYSTEM table/section:
[SYSTEM]
LOG_LEVEL = "info"
LOG_SERVER = "<IP_ADDRESS>"

And, of course if no LOG_SERVER is set than if just all comes back down to print() calls (but from within the adafruit_logging library and thus potentially being further adaptable in the future).

And as another idea: Implement a logging handler that sends log events to a configured printer, like so (assuming a configured printer name "TM-T20II"):
[SYSTEM]
LOG_LEVEL = "info"
LOG_PRINTER = "TM-T20II"


Migrate to dl.k8s.io from kubernetes release bucket

What this PR does / why we need it:
Migrate to dl.k8s.io from Kubernetes release bucket.
Which issue(s) this PR fixes:

Fixes #331
What type of PR is this?

/kind deprecation
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:

[ACTION REQUIRED] Migrate from the Kubernetes release bucket (`https://storage.googleapis.com/kubernetes-release/release`) to `dl.k8s.io` for downloading binaries. **If IP-based or URL-based filtering is in place**, you need to allow the appropriate IP addresses and domains as described in [the official `dl.k8s.io` announcement](https://kubernetes.io/blog/2023/06/09/dl-adopt-cdn/)

Documentation:

NONE

/approve


Button needs animation

It would be nice for the button to have an animation when clicked. We could add plus signs coming out of the button when clicked and slowly fading out.

Hey, I would like to try and add animations when the button is clicked

@dylcarinc Don't forget to close the issue when the pull request is merged!


positive regulation of actin nucleation/ not slimming

https://www.pombase.org/gene/SPAC15A10.16
positive regulation of actin nucleation
is not slimming to
actin cytoskeleton organization | GO:0030036 | 127
even though it has this ancestry:
https://www.ebi.ac.uk/QuickGO/GTerm?id=GO:0051127

I think it might be the same flip-flopping issue: https://github.com/geneontology/go-ontology/issues/17171
I checked previous Chado databases and in some SPAC15A10.16 is in GO:0030036 and in some it isn't.  It was fine on 2020-08-29 but gone the next day.

This is OK now


Remember window position/size

Remember where/how the user last positioned/sized the window (assuming resolutions/external monitors stay the same).
Exception can be made for those that close fullscreen to not re-open in fullscreen if not easy to implement. There should be an option that auto-fullscreens for them per #18

Closing without resolution. This issue either affects too few users or there are too many issues with higher impact to be working on. It is possible to re-open or re-visit this issue at a later time. If you feel this issue is important, please give a thumbs-up reaction to the first post. You may track this issue from the pinned meta-tracker at the top of the issues home page.


Feature/deserde

Codecov Report

Merging #413 (1895a0b) into trunk (6381560) will increase coverage by 10.04%.
The diff coverage is 73.39%.

@@             Coverage Diff             @@
##            trunk     #413       +/-   ##
===========================================
+ Coverage   63.41%   73.46%   +10.04%
===========================================
  Files          10       40       +30
  Lines         850     2615     +1765
===========================================
+ Hits          539     1921     +1382
- Misses        311      694      +383

Impacted Files
Coverage Δ

derive/src/derive_enum.rs
0.00% <0.00%> (ø)

derive/src/derive_struct.rs
0.00% <0.00%> (ø)

derive/src/generate/generate_fn.rs
0.00% <0.00%> (ø)

derive/src/generate/generator.rs
0.00% <0.00%> (ø)

derive/src/generate/impl_for.rs
0.00% <0.00%> (ø)

derive/src/generate/stream_builder.rs
0.00% <0.00%> (ø)

src/error.rs
0.00% <0.00%> (-6.46%)
:arrow_down:

derive/src/lib.rs
7.40% <7.40%> (ø)

derive/src/error.rs
12.50% <12.50%> (ø)

src/de/mod.rs
50.00% <50.00%> (-28.32%)
:arrow_down:

... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6381560...1895a0b. Read the comment docs.


Accessibility Testing

We need to be able to test a11y. There are two parts to it:

Test that a11y support in the framework doesn't break.
Enable app developers to test the a11y capabilities of their app.

Hopefully, we'll be able to leverage the same mechanism for both.

We most likely also want two levels of accessibility testing:

widget-based tests to assert that a widget or a set of widgets produce the correct semantics tree (we already have SemanticsTester in the framework, which needs to be cleaned up, improved and made accessible for external devs).
integration tests that ensure that the app behaves well when controlled via TalkBack (Android) and VoiceOver (iOS).

I split this bug up into:

https://github.com/flutter/flutter/issues/12286
https://github.com/flutter/flutter/issues/12287


Move Solr Module into own repository

Since YAWIK Module can now be installed using composer, we should move the Solr Module into an own YawikSolr Repository.
There is currenty only the YawikCompanyRegistration module which can be installed via
composer create-project cross-solution/yawik
cd yawik
composer require cross-solution/yawik-company-registration

This works, because of the type: yawik-module in the composer.json. Composer will check the dependencies and install the module into module/YawikCompanyRegistration

done in https://github.com/cross-solution/YAWIK/commit/7de5c3d82a261ce70568a27054494bdce79f8b1c


isvalid error with PythonCall.Utils.StaticString

When converting to PyArray some numpy arrays with string elements, I end up with strings of type PythonCall.Utils.StaticString{UInt32, 44}.
It seems that this type is not well supported though, and I get the following errors when indexing and computing the length:
julia> s = PythonCall.Utils.StaticString{UInt32, 44}("ababababb")
"ababababb"

julia> s[1]
ERROR: MethodError: no method matching isvalid(::PythonCall.Utils.StaticString{UInt32, 44}, ::Int64)
Closest candidates are:
  isvalid(::AbstractString, ::Integer) at strings/basic.jl:143
  isvalid(::SubstitutionString, ::Integer) at regex.jl:566
  isvalid(::Type{T}, ::Integer) where T<:AbstractChar at strings/unicode.jl:58
  ...
Stacktrace:
 [1] isvalid
   @ ./strings/basic.jl:143 [inlined]
 [2] getindex(s::PythonCall.Utils.StaticString{UInt32, 44}, i::Int64)
   @ Base ./strings/basic.jl:186
 [3] top-level scope
   @ REPL[5]:1

julia> length(s)
ERROR: MethodError: no method matching isvalid(::PythonCall.Utils.StaticString{UInt32, 44}, ::Int64)
Closest candidates are:
  isvalid(::AbstractString, ::Integer) at strings/basic.jl:143
  isvalid(::SubstitutionString, ::Integer) at regex.jl:566
  isvalid(::Type{T}, ::Integer) where T<:AbstractChar at strings/unicode.jl:58
  ...
Stacktrace:
 [1] isvalid
   @ ./strings/basic.jl:143 [inlined]
 [2] length
   @ ./strings/basic.jl:396 [inlined]
 [3] length(s::PythonCall.Utils.StaticString{UInt32, 44})
   @ Base ./strings/basic.jl:387
 [4] top-level scope
   @ REPL[6]:1

julia> s isa AbstractString # in principle the type should implement the whole interface
true

Yeah, PythonCall.Utils.StaticString is pretty minimal in what it supports - you can convert them to String but not much else.
Supporting indexing is harder because it requires understanding UTF-8 and UTF-32 - AFAIK Julia doesn't provide much support for implementing your own string types in terms of handling the encoding (even UTF-8) except for the transcode function, which I use to convert to String.
If you are getting these from a PyArray, I have just pushed a change to the main branch so that you can do PyArray{String}(x) on a Python array of strings, which converts the elements to String when you access them. Of course this is slower than accessing them as PythonCall.Util.StaticString but if you need indexing then it's an option.

I see you have implemented indexing in the last commits, thanks, the examples in the OP now work:
julia> s = PythonCall.Utils.StaticString{UInt32, 44}("ababababb")
"ababababb"

julia> s[1]
'a': ASCII/Unicode U+0061 (category Ll: Letter, lowercase)

julia> length(s)
9

julia> s[1:2]
"ab"

julia> s[1:2] |> typeof
SubString{PythonCall.Utils.StaticString{UInt32, 44}}

Can we get a new release?

I decided it wasn't so hard! Sure I'll make a release this week.

Hi, sorry to bother but it would be great to have a new release!

Sure - done.


feat(memoRead): Added read function to compliment memoPush()

:tada: This PR is included in version 1.9.0 :tada:
The release is available on npm package (@latest dist-tag)
Your semantic-release bot :package::rocket:


B12.1 Continuation of User Persona and User Story Development

See sub-tasks for B12.1 plans

📆 October status: on schedule

user persona definition and data user stories completed.


add anonyviet bypass

Fix:
Takes an URL such as: https://anonyviet.com/tieptucdentrangmoi/?url=https%3A%2F%2Fsignup.microsoft.com%2Fsignup%3Fsku%3DEducation and returns and opens https://signup.microsoft.com/signup?sku=Education.
Closes #1104

[x] I made sure there are no unnecessary changes in the code;
[ ] Tested on Chromium (Includes Opera, Brave, Vivaldi, Edge, etc);
[ ] Tested on Firefox.

moved to #1113


Fix incorrect amount of patients

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #596
Description
Change maximum patient list from 20 to real amount of patient, which is sourced from count() and also add the same filter as count(). So, the amount of patient displayed on the top TextView is the same as the patient list, depending how many patient match the filter.
Alternative(s) considered
N.A
Type
Choose one: Bug fix
Screenshots (if applicable)

Checklist

[x] I have read and acknowledged the Code of conduct
[x] I have read How to Contribute
[x] I have read the Developer's guide
[x] I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA
[x] I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach
[x] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project
[x] I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally
[x] I have built and run the reference app(s) to verify my change fixes the issue and/or does not break the reference app(s)

@FikriMilano , is this PR ready for review?

@Tarun-Bhardwaj , yes this PR is ready for review

@stevenckngaa could you please review this again? thanks

Codecov Report

Merging #653 (7381e0c) into master (fefbdd6) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 7381e0c differs from pull request most recent head e7a0439. Consider uploading reports for the commit e7a0439 to get more accurate results

@@            Coverage Diff            @@
##             master     #653   +/-   ##
=========================================
  Coverage     53.25%   53.25%
  Complexity      194      194
=========================================
  Files            47       47
  Lines           969      969
  Branches        134      134
=========================================
  Hits            516      516
  Misses          371      371
  Partials         82       82

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fefbdd6...e7a0439. Read the comment docs.

@stevenckngaa
Is something holding this pr to get merged?

@stevenckngaa
Is something holding this pr to get merged?

Sorry, I was out of office. I approved this change 21 days ago. Feel free to submit.

@stevenckngaa
Is something holding this pr to get merged?

Sorry, I was out of office. I approved this change 21 days ago. Feel free to submit.

@FikriMilano , when do you plan to merge these changes?

@stevenckngaa
Is something holding this pr to get merged?

Sorry, I was out of office. I approved this change 21 days ago. Feel free to submit.

@FikriMilano , when do you plan to merge these changes?

@Tarun-Bhardwaj , I don't have write access so I can't merge PRs.
@stevenckngaa could you please help help me with this?

@stevenckngaa
Is something holding this pr to get merged?

Sorry, I was out of office. I approved this change 21 days ago. Feel free to submit.

@FikriMilano , when do you plan to merge these changes?

@Tarun-Bhardwaj , I don't have write access so I can't merge PRs.
@stevenckngaa could you please help me with this?

Done. Thank you.


IOB gets cut off in portrait view on 4" screen

Using iPhone SE
Portrait view:

Landscape view:

I've noticed it happening with pretty much every time the IOB has two decimal places that isn't something like x.1x or x.x1

Still doing it with the IOB.. I realized I put the wrong screen size when I created the issue, I'm not sure if that makes a difference.. but I added the phone model above just for clarity 👍

Sorry to ask, but there might be some confusion about whether this change was  included in that release tag of Loop last night. It wasn't; it will be included in a future release.
Alternatively, you could have built Loop against LoopKit's Dev branch using Carthage? If so I apologize and I'll try again to fix this before closing the ticket.

On Jul 20, 2016, at 11:26 PM, sarahspins<EMAIL_ADDRESS>wrote:
Still doing it with the IOB.. I realized I put the wrong screen size when I created the issue, I'm not sure if that makes a difference.. but I added the phone model above just for clarity 👍
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.


is Deedle dead?

no commits in a really long time? are people actually using this?

There were a few StackOverflow questions about it recently, so some people are using it, but if there are people interested in taking the project further and become active contributors, we would love to have them on-board.

Can we make a clone in https://github.com/fsprojects and develop it from there?  e.g. so a V2 or V3 would become possible?
It feels that if BlueMountain aren't contributing a maintainer, it shouldn't really remain here....

@mattdot The project has just been moved to fslab and travis build is fixed. We are trying to revive it. Any contribution and feedbacks are welcome.

This is such great news!


40 delete start dates on draft requirements

40-delete-start-dates-on-draft-requirements
Single migration to delete dos2 draft brief start dates that will no
longer be in the correct format.
Context: Change of date format means draft requirement dates will not
longer be in the right format to be published.
Delete start dates on all draft requirements so buyers can re-enter
dates before they are published.
Acceptance criteria
Given that I have entered a latest start date in my draft requirement,
when I try to publish my requirement, then I need to re-enter the latest
start date.
https://trello.com/c/BA5KSAvm/40-delete-start-dates-on-draft-requirements

👍


Latest version stuck in "Waiting for Zotero translators"

Report ID:
V8V8CG2V-euc
Expected behavior:
Booting up Zotero and loading/initializing BBT
Actual behavior:
Stuck in "Waiting for Zotero translators" step.

Can you check whether the Zutilo option Copy item fields (you'll have to enable it in the Zutilo preferences) shows up for you in the right-click menu? Does it show up if you uninstall BBT and restart?

Same problem here, thanks @jrennstich for reporting.
Copy item fiels does not show up with BBT but does show up when BBT is disabled.

This looks to be a dup for #1620 and that just went away when plugins were enabled/disabled, so I'm not yet sure whether BBT actually causes this (or how BBT could). A build will drop here shortly that will push out the BBT init to the last phase of Zotero startup, but that also means there's a longer window where Zotero will seem operational but BBT isn't yet.

:robot: this is your friendly neighborhood build bot announcing test build <IP_ADDRESS>02 ("man I hate the Z init procedure")
Install in Zotero by downloading test build <IP_ADDRESS>02, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

@daeh, @tea4or2wo, @jrennstich can you try 7002?

Same issue here, with the latest build.
Zotero ID : 395876455
BBT ID : YR7J9FZ3-euc

I can't access Zotero IDs. Can you try disabling sync and starting again?

:robot: this is your friendly neighborhood build bot announcing test build <IP_ADDRESS>03 ("lock tracing")
Install in Zotero by downloading test build <IP_ADDRESS>03, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

I had the same issue but was able to resolve the issue by removing the extension from Zotero and then reinstalling BBT 5.2.56 and restarting Zotero. Copy item fields does show for me in the right-click context menu when enabled in Zutilo.

I'm not really happy with that as it stands though. 7003 adds more tracing to the startup sequence, I'd appreciate a new log that replicates the problem. It's must be a race condition of sorts.

If "copy item fields" shows, the crucial lock (promise, technically) gets resolved, so then bbt will start too.

I'll definitely submit a log if the issue returns, but so far it has not.

I really do hate transient errors. I'm going to bake the lock tracing into the next release because this won't be the last time I see this if 4 people in quick succession report this.

Does removing zutilo allow BBT to start? I see that zutilo doesn't wait for the all-clear promise from zotero for the majority of its functionality.

That enabling/disabling works can also be because it changes the load order of plugins. If something disturbs the startup and therefore the all-clear promise is never resolved, that would explain what we're seeing here, If BBT starts first.

Thanks for looking so actively into this! Alas, no change here from my side. I have disabled all extension (including the plug-ins for LibreOffice/Word), now I am stuck with the message "Waiting for Zotero database ..."
Report ID: YF88WXB8-euc

Hello!
7003 solved it for me! Thank you very much for your very quick support!
Report ID : 6RRWLGA9-euc

Thanks for looking so actively into this! Alas, no change here from my side. I have disabled all extension (including the plug-ins for LibreOffice/Word), now I am stuck with the message "Waiting for Zotero database ..."

Did you restart after disabling? Without a restart, most plugins would still be running.

Report ID: YF88WXB8-euc

That shows a lot of activity that seem to relate to sync, and yet again the promise not resolving.

I can also confirm the solution provided by @stuartsoorholtz — thanks for that! — here's the report after deinstallation of BBT, reinstall of BBT <IP_ADDRESS>03:

Report ID: 858TJZH5-euc

But that also shows the same kind of activity with BBT starting normally. So no further clues yet.
Does anyone still have a failing startup? If so, does removing Zutilo and restarting solve it?

Did you restart after disabling? Without a restart, most plugins would still be running.
If you mean restarting the app: y. If you mean restarting the MPB: n.

Does anyone still have a failing startup? If so, does removing Zutilo and restarting solve it?
I don't get the error after I have reinstalled BBT w 7003. Should I still give this a try and send the report?

7003 solved it for me too! Thanks a lot for great support.

@jrennstich I meant restart (cmd-q and restart if on Mac) of zotero only.
No, if BBT currently starts as normal, no log needed. I wish I could replicate this problem. I'm pretty sure that if Zutilo would wait on the same promise the problem would be solved - I had the exact same problem with odf/rtf scan and there an added wait for the all-clear promise solved the matter.

@tea4or2wo 7003 only added logging, didn't solve anything as such.

If it happens again: try uninstalling Zutilo and restarting Zotero. If that allows BBT to restart, here is a Zutilo 3.5.0 that waits for the all-clear promise before starting up. If that works, I can submit a pull request to Zutilo.

After temporarily resolving the issue (per my previous comment), I was able to replicate the issue.
I then disabled Zutilo, restarted Zotero with logging enabled, and the issue persisted. I then submitted BBT report with ID: UQVSC5YY-euc

I have now also fully uninstalled Zutilo, restarted Zotero with logging enabled, and the issue still persists. Here is the BBT report for this scenario: XRFFWM88-euc

I realized my previous two comments were regarding the 5.2.56 release and not <IP_ADDRESS>03 with the updated logging. I subsequently uninstalled BBT, restarted Zotero, installed BBT <IP_ADDRESS>03, then restarted Zotero with logging enabled. Upon startup of Zotero, the issue is not present. Also note that Zutilo was not installed during this test. I restarted Zotero again (for good measure) and the issue was still not present.
I proceeded to reinstall Zutilo 3.5.0, restarted Zotero, and the issue was not present. Once again, I restarted Zotero and the issue was still not present. I submitted a BBT report for good measure with ID: 5SQE2QA7-euc

That may mean the late-start I added in 7003 actually does make a difference. I've scheduled a release with that just now on the off chance it does something.

:robot: this is your friendly neighborhood build bot announcing test build <IP_ADDRESS>09 ("Merge branch 'master' into gh-1622")
Install in Zotero by downloading test build <IP_ADDRESS>09, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

7009 is only useful if the problem reappears. It still has more logging than the 5.2.57 release.

Still doesn't mean the problem is solved necessarily because installing and re-installing could alter the load order of plugins. But if it works, it works.

In other news: https://forums.zotero.org/discussion/comment/339663/#Comment_339663

Issue is back for me J2DJX2VC-euc.

And with:

Zutilo uninstalled?
Zutilo replaced with the version from https://github.com/retorquere/Zutilo/releases/tag/v3.5.0 (which has the promise wait in it)

Hold on: can you instead disable the hidden preference automaticScraperUpdates?

@daeh please don't change anything about your setup (in contrast with what I said before, please do not uninstall Zutilo) except this setting. I can't replicate the problem unfortunately but your log explains why BBT doesn't start. With that setting at false, that path won't be taken in Zotero, and the promise should clear. If this is indeed the problem then a) you should be able to toggle the problem on and off (with restarts of Zotero of course) at will, and b) I have something definite I can bring to the Zotero devs.
Maddening these non-reproducible problems.

disabling automaticScraperUpdates did seem to allow BBT to load (no other changes, Zutilo still enabled, etc.) LRRLS75K-euc

Progress at last. I reckon turning it back on would have the problem come back. I'll have to trawl through the Zotero sources to see why this could be. You could do me a major favor if you could check if turning it on indeed brings the problem back, then disable BBT but keep Zutilo enabled and see if after a restart Copy item fields is available.

This also explains why it happens sporadically BTW. Still spelunking the Zotero code.

Unfortunately it doesn't seem quite that binary. Initialization seemed to go fine after I put automaticScraperUpdates back on: XVHKMH3M-euc. Seems kind of like how disabling and reenabling all the add-on provided a temporary fix.

I first noticed the message "Waiting for Zotero translators" would not go away yesterday.
I wasn't bothered by the message popup, but soon realised that Zotero's browser add-on was no longer working properly, which got my attention.
I tried the following (in this order):

At first, before I found this issue, I followed the tip in #1313 to reset the translators and restart Zotero. That made the startup message freeze at "Waiting for Zotero database" instead, but otherwise didn't fix the problem.
I then discovered this issue, and decided to upgrade BBT to test build 7009 and restart Zotero (in between these steps, BBT had upgraded itself to v5.2.57). But from the looks of things, nothing has changed. Still can't add papers to Zotero from the web browser, and the "Better BibtTeX: Initializing" message never goes away after restart.

Bibtex report ID: 6Q4ET4LN-euc
Meta: I was going to ask how to change automaticScraperUpdates when I saw @retorquere's explanation in #1623, so I did that just now:

I went into Zotero's hidden preferences, toggled automaticScraperUpdates from true to false, and restarted Zotero. And now Zotero started as usual! This appears to have fixed the problem.

Luckily I did the restart with logging enabled, and so I have sent in a second Bibtex debug report: AW7YYDK5-euc
(the only difference between this one and the one above should be automaticScraperUpdates). I hope there's some difference between them that helps you pinpoint this issue.
If I may, I would like to say that it's been amazing following everyone's efforts on this issue in "real-time". Thank you all :-)

Super thanks -- it looks like we've successfully narrowed down the place it happens. I still have no idea why it happens though. I've asked for help on the Zotero dev forums but that usually takes a while to get a response.

:robot: this is your friendly neighborhood build bot announcing test build <IP_ADDRESS>10 ("wait on uiReadyPromise instead")
Install in Zotero by downloading test build <IP_ADDRESS>10, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

7011 allows picking an earlier phase in the Zotero startup that does (so far) consistently resolve  by setting the hidden pref patientStart to false, and then automaticScraperUpdates can go back on.
If anyone can replicate a situation with 7011 with patientStart off, automaticScraperUpdates on, and with Zutilo not showing Copy item details (meaning Zotero's `schemaUpdatePromise, the culprit promise, did not resolve), I'd very much like to hear about that.

:robot: this is your friendly neighborhood build bot announcing test build <IP_ADDRESS>11 ("actually release the early start code")
Install in Zotero by downloading test build <IP_ADDRESS>11, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

FYI -- any build that drops in an issue has run through (and passed) the full test suite that I run for a formal release. I'm not asking risky installs, the debug builds are very conservative and usually are simply rebadged as a formal release.

Restarted Zotero after installing 7011. Here's the report first the hidden settings unchanged (BBT never progressed beyond waiting for database), then changed hidden settings as instructed

If anyone can replicate a situation with 7011 with patientStart off, automaticScraperUpdates on, and with Zutilo not showing Copy item details

Now it hangs at "Loading journal abbreviator"
Report ID: 5XI797U6-euc
I did not change anything about Zutilo. Here's the report with Zutilo disabled. Same result (hangs at "Loading journal abbreviator")
Report ID: 55B46HHV-euc

Just chiming in here for another data point. I had the same issue. I reinstalled Zotero, but that did not help. Then I toggled automaticScraperUpdates from true to false in Hidden preferences, and restarted Zotero. This fixed the problem. Then I turned them back on, and the problem is still fixed.
One note: turning this setting off allowed zotero to install new Better BibTex translators. Could this perhaps be why it hung? They were trying to get installed and couldn't? And then once they were everything worked fine? So perhaps the issue only occurs when new translators are available for install. Could be unrelated, but just a thought.

Just chiming in here for another data point. I had the same issue. I reinstalled Zotero, but that did not help. Then I toggled automaticScraperUpdates from true to false in Hidden preferences, and restarted Zotero. This fixed the problem. Then I turned them back on, and the problem is still fixed.
One note: turning this setting off allowed zotero to install new Better BibTex translators. Could this perhaps be why it hung? They were trying to get installed and couldn't? And then once they were everything worked fine? So perhaps the issue only occurs when new translators are available for install. Could be unrelated, but just a thought.

Thanks, I can confirm this also worked for me.

:robot: this is your friendly neighborhood build bot announcing test build <IP_ADDRESS>13 ("back to late start")
Install in Zotero by downloading test build <IP_ADDRESS>13, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

 Could this perhaps be why it hung?

No, Zotero for some reason never gets to the point where it gives the all-clear to start, and when that option is off, th epath through the Zotero code that's right before the all-clear (where it gets stuck) doesn't get called, so I get the all clear, and BBT starts. BBT is just dutifully waiting for the all-clear before doing anything at all, including installing translators.
7013 goes back to the behavior where turning off automaticScraperUpdates would allow BBT to proceed. I need to dive back into that piece of Zotero code.

7014 adds more logging to narrow down the place where it happens.

:robot: this is your friendly neighborhood build bot announcing test build <IP_ADDRESS>14 ("more lock tracing")
Install in Zotero by downloading test build <IP_ADDRESS>14, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

If one of you experiences the problem again, I'd appreciate it if you could shut down zotero (that cmd-q your the Mac crowd) and get me a copy of your full profile (not the storage dir). Whatever trips this, I can't replicate it.

 Maybe I can replicate it with the db only, and your full profile has your sync password, and I do not want that.

Hello,
I have the issue in the 5.2.57 version. Which DB do you want?
report ID : 2NWXKMU4-euc

Zotero.sqlite

The weird thing is that if zotero does actually start up correctly, the problem should be gone. It's never finishing because for some reason the fetch of new zotero styles and translators never returns, but if it actually does when bbt is not installed, the next bbt-less start should fix it even if BBT is then reenabled, because styles and translators don't change every few minutes.
The problem is that it's hard to tell whether zotero actually clears this point because zotero itself doesn't wait on this promise as far as I can tell. Everything will look good in Zotero itself even if it fails this part.
Super duper frustrating.

Installed 7014. Restarted Zotero (Cmd-Q). Zotero boots up, with no infoboxes from BBT (in the bottom right corner). I had switched automaticScraperUpdates back to true. I am not able to open the "Send BBT debug" menu. Also, BBT only shows the selection dialog, but none of the other options it usually does

So I cannot post a Report ID :(
Turned automaticScraperUpdates back on. No change. Exact same behavior. What next? Do you need my (rather large) db?

Installed 7013 instead. Works as it should. automaticScraperUpdates is false.
Report ID: T2VWEQ63-euc
Here's automaticScraperUpdates set to true. No change in behavior.
Report ID: RR2MEFL7-euc
Dialog box back to normal. Only, I have noticed a change in the size even before the latest troubles. There much open space on the right-hand side. Has occurred since last week or two, not sure anymore.

Yes please, a copy of the db would be helpful. Can you look in the zotero debug log if it shows errors? They'll be at the top.

What's the Google dropbox link you have again for posting files?

https://forms.gle/NF1XW12Nx7ZA1KP49

(3)(+0000000): Using data directory /Users/jrennstich/Zotero
(3)(+0000004): IPC: Initializing pipe at /Users/jrennstich/Zotero/pipes/1597862360089
(3)(+0000003): Asynchronously opening database 'zotero'
(3)(+0000000): /Users/jrennstich/Zotero/zotero.sqlite
(3)(+0000000): Proxy not required for https://zoteroproxycheck.s3.amazonaws.com/test
(3)(+0000001): HTTP GET resource://zotero/schema/global/schema.json
(3)(+0000002): HTTP GET resource://zotero/schema/global/schema.json succeeded with 200
(3)(+0000001): Database is up to date with global schema version 11 -- skipping update
(3)(+0000000): HTTP GET resource://zotero/schema/userdata.sql
(3)(+0000000): HTTP GET resource://zotero/schema/userdata.sql succeeded with 200
(3)(+0000001): HTTP GET resource://zotero/schema/system.sql
(3)(+0000001): HTTP GET resource://zotero/schema/system.sql succeeded with 200
(3)(+0000000): Updating custom tables
(3)(+0000002): HTTP GET resource://zotero/schema/userdata.sql
(3)(+0000002): HTTP GET resource://zotero/schema/userdata.sql succeeded with 200
(3)(+0000001): HTTP GET resource://zotero/schema/triggers.sql
(3)(+0000000): HTTP GET resource://zotero/schema/triggers.sql succeeded with 200
(3)(+0000000): Updating custom tables
(3)(+0000002): {better-bibtex} +null Startup progress: Zotero locks after 515: Zotero.uiReadyPromise: pending , Zotero.Schema.schemaUpdatePromise: pending
(3)(+0000001): Running unlock callbacks
(3)(+0000000): HTTP server listening on  <IP_ADDRESS>:23119
(3)(+0000002): Registering auto-sync idle observer
(3)(+0000000): Registering URIContentListener
(3)(+0000001): Getting contents of /Users/jrennstich/Zotero/locate/engines.json
(3)(+0000001): PluginInstaller: fetching addon info
(3)(+0000001): PluginInstaller: addon info fetched
(3)(+0000001): PluginInstaller: fetching addon info
(3)(+0000000): PluginInstaller: addon info fetched
(3)(+0000000): {better-bibtex} +554 Startup progress: Zotero locks after 1069: Zotero.uiReadyPromise: pending , Zotero.Schema.schemaUpdatePromise: pending
(1)(+0000001): Unknown item type 'nsfReviewer'
(1)(+0000000): Unknown item type 'nsfReviewer'
(3)(+0000262): Loading collection relations
(3)(+0000000): Loaded collection relations in 1 ms
(3)(+0000000): Loading item relations
(3)(+0000597): Loaded item relations in 597 ms
(3)(+0000001): {better-bibtex} +893 Startup progress: Zotero locks after 1962: Zotero.uiReadyPromise: pending , Zotero.Schema.schemaUpdatePromise: pending
(3)(+0000002): {better-bibtex} +1876 Startup progress: Zotero locks after 3838: Zotero.uiReadyPromise: pending , Zotero.Schema.schemaUpdatePromise: pending
(3)(+0000077): Getting contents of /Users/jrennstich/Library/Application Support/Zotero/Profiles/oxt32dqe.default/retractions.json
(3)(+0000001): Loading synced settings for library 1
(3)(+0000001): Loading all collections in My Library
(3)(+0000001): Loading primaryData for collections in My Library
(3)(+0000003): Loaded primaryData in My Library in 3 ms
(3)(+0000001): Loading childCollections for collections in My Library
(3)(+0000002): Loaded childCollections in My Library in 2 ms
...

[JavaScript Error: "Style with ID http://www.zotero.org/styles/apa already loaded from apa.csl" {file: "chrome://zotero/content/xpcom/style.js" line: 178}]
Zotero.Styles</_readStylesFromDirectory<@chrome://zotero/content/xpcom/style.js:178:15
tryCatcher@resource://zotero/loader.jsm -> resource://zotero/bluebird/util.js:16:16
module.exports/PromiseSpawn.prototype._promiseFulfilled@resource://zotero/loader.jsm -> resource://zotero/bluebird/generators.js:97:18
module.exports/Promise.prototype._settlePromise@resource://zotero/loader.jsm -> resource://zotero/bluebird/promise.js:574:17
module.exports/Promise.prototype._settlePromise0@resource://zotero/loader.jsm -> resource://zotero/bluebird/promise.js:614:5
module.exports/Promise.prototype._settlePromises@resource://zotero/loader.jsm -> resource://zotero/bluebird/promise.js:693:13
Async.prototype._drainQueue@resource://zotero/loader.jsm -> resource://zotero/bluebird/async.js:133:13
Async.prototype._drainQueues@resource://zotero/loader.jsm -> resource://zotero/bluebird/async.js:143:5
Async/this.drainQueues@resource://zotero/loader.jsm -> resource://zotero/bluebird/async.js:17:9
Warning: NetUtil.newChannel(uri) deprecated, please provide argument 'aWhatToLoad'

Dialog box back to normal. Only, I have noticed a change in the size even before the latest troubles. There much open space on the right-hand side. Has occurred since last week or two, not sure anymore.

That's because XUL is finicky and poorly documented. But it doesn't cause any of this.

(debug logs only help when the problem occurs BTW)

It's uploading. 2.3G take a while...

[JavaScript Error: "Style with ID http://www.zotero.org/styles/apa already loaded from apa.csl" {file: "chrome://zotero/content/xpcom/style.js" line: 178}]

Alas, that's just an informative message, it doesn't actually interrupt anything.

It's uploading. 2.3G take a while...

Posted.

Can I also get your better-bibtex.sqlite (as always, cmd-q Zotero before copying)

Can you guys install https://transfer.sh/nFBSy/schema-log.xpi ? It does nothing expect putting up a notification that tells you when the promise of interest resolves. If at some point you have this problem and it appears to go away when BBT is disabled, this will let you know if the problem actually still occurs.

Can I also get your better-bibtex.sqlite (as always, cmd-q Zotero before copying)

Sent

Installed the log-extension:
[Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIAppShellService.hiddenDOMWindow]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://zotero/content/xpcom/zotero.js :: this.init< :: line 234"  data: no]
this.init<@chrome://zotero/content/xpcom/zotero.js:234:15
From previous event:
ZoteroService@file:///Applications/Zotero.app/Contents/Resources/components/zotero-service.js:352:7
startup@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///Users/jrennstich/Library/Application%20Support/Zotero/Profiles/oxt32dqe.default/extensions/schema-logger@iris-advies.com.xpi!/bootstrap.js:13:12
callBootstrapMethod@resource://gre/modules/addons/XPIProvider.jsm:4446:20
startup@resource://gre/modules/addons/XPIProvider.jsm:2253:13
callProvider@resource://gre/modules/AddonManager.jsm:253:12
_startProvider@resource://gre/modules/AddonManager.jsm:728:5
startup@resource://gre/modules/AddonManager.jsm:892:9
startup@resource://gre/modules/AddonManager.jsm:2981:5
observe@jar:file:///Applications/Zotero.app/Contents/Resources/omni.ja!/components/addonManager.js:63:9

Can't boot Zotero anymore. What do I do?

I have no idea why this happens -- it starts without issue for me. I'm on it to find out how to remove it!

I have no idea why this happens -- it starts without issue for me. I'm on it to find out how to remove it!

I deleted the extension from the Profiles folder in my Application Support folder. Zotero runs again.

I was just going to say that. Thanks!

OK I now have that reproducible too. Forget schema-log for now, I'm pitching that back to the zotero devs.

I think I have it reproducible with your DB.

Well... good news and bad news I guess. With your DB I can indeed reproduce the problem. And while the resolving up the all-clear takes very long with your DB (12+ seconds), with BBT it doesn't seem to clear at all. On it. But I really yet don't know WTF is going on. I can trace the execution to the point it still works (in the Zotero code that is), and then the line after it just looks like it never reaches that point.

Seems like a vanishing spell to me. But then again, I've been listening to a lot of Harry Potter lately. Jim Dale. Highly recommended.

Just arrived here when searching for a solution. I am running Zotero 5.0.89 and BBT 5.2.57, all under macOS. Setting automaticScraperUpdates to false does not fix this for me.

I'll need a log from 7014, because if that doesn't work as a workaround, there's a different cause.

:robot: this is your friendly neighborhood build bot announcing test build <IP_ADDRESS>16 ("workaround for #1622")
Install in Zotero by downloading test build <IP_ADDRESS>16, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

7016 has a gross hack that allows Zotero to start up with @jrennstich 's database. If this works for you guys then that will tide me over to create a proper fix, but that is going to be a lot of work.
I still have absolutely no idea why this happens all of a sudden, but it seems like waiting to start all of BBT until the all-clear promise resolves, not just the stuff that touches the database, makes it go away. This will mean that BBT will actually only show up after some 5-13 seconds after Zotero appears to be (but isn't actually) fully functionial, because that's how long it takes Zotero to give the all-clear.

7016 works for me at a first try!

With automaticScraperUpdates on?

Worked like a charm for me. Wanted to send a Report. Alas, the menu Help > Send Better BibTeX... is unresponsive.

Doesn't work here with automaticScraperUpdates set to true, working however if set to false.

If it doesn't work, but your can send a log, please do. When I get back home I'll look into why the debug log doesn't work.

A bit erratic, seems to be working now with automaticScraperUpdates turned on, see SR2MQR53-euc.

I don't know what "erratic" means, precisely, in this context.

Logs for when it does work are not necessary.

@jrennstich I can't replicate that propblem. Can you look in the error log whether it shows an error?

:robot: this is your friendly neighborhood build bot announcing test build <IP_ADDRESS>17 ("conditional ready check")
Install in Zotero by downloading test build <IP_ADDRESS>17, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

Going by the DB from @jrennstich (the only way I've been able to replicate the problem) the bug appeared between 5.2.53 and 5.2.54. I'd appreciate it if you could download 5.2.53 and see if that just works for you. If it does, I'm going to put out a new release that's just 5.2.53, and then inspect all the changes. Fortunately this looks to be a fairly small set of changes.

:robot: this is your friendly neighborhood build bot announcing test build <IP_ADDRESS>18 ("revert sentence-caser?!?!")
Install in Zotero by downloading test build <IP_ADDRESS>18, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

7018 reverts the changes between 53 and 54, and it starts for me with @jrennstich's databse without problems. Would appreciate feedback whether it fixes it for all of you.

I reverted automaticScraperUpdates to true, then I installed BBT release 7018.
Upon restart, Zotero proceeded through all the startup messages normally. Zotero looks and behaves OK now.
Here's the BBT log: 4FPR6MYJ-euc

So that's one confirmed fix on 7018 by @chepec? If it works, I don't need a log.
I still have no clue why the 53-54 changes would interrupt zotero startup (as far as I can tell, they do nothing that touches startup) but I'll take it.

Been traveling. Can confirm that 7018 works like a charm.

@jrennstich I can't replicate that propblem. Can you look in the error log whether it shows an error?

Now it works on my end again. But you don't need a log, right?

Debug Log:
(3)(+0000000): Using data directory /Users/jrennstich/Zotero
(3)(+0000003): IPC: Initializing pipe at /Users/jrennstich/Zotero/pipes/1597968293516
(3)(+0000002): Asynchronously opening database 'zotero'
(3)(+0000000): /Users/jrennstich/Zotero/zotero.sqlite
(3)(+0000000): Proxy not required for https://zoteroproxycheck.s3.amazonaws.com/test
(3)(+0000001): HTTP GET resource://zotero/schema/global/schema.json
(3)(+0000002): HTTP GET resource://zotero/schema/global/schema.json succeeded with 200
(3)(+0000000): Database is up to date with global schema version 11 -- skipping update
(3)(+0000001): HTTP GET resource://zotero/schema/userdata.sql
(3)(+0000000): HTTP GET resource://zotero/schema/userdata.sql succeeded with 200
(3)(+0000001): HTTP GET resource://zotero/schema/system.sql
(3)(+0000001): HTTP GET resource://zotero/schema/system.sql succeeded with 200
(3)(+0000000): Updating custom tables
(3)(+0000003): HTTP GET resource://zotero/schema/userdata.sql
(3)(+0000000): HTTP GET resource://zotero/schema/userdata.sql succeeded with 200
(3)(+0000001): HTTP GET resource://zotero/schema/triggers.sql
(3)(+0000000): HTTP GET resource://zotero/schema/triggers.sql succeeded with 200
(3)(+0000001): Updating custom tables
(3)(+0000001): {better-bibtex} +null Startup progress: Zotero locks after 524: Zotero.uiReadyPromise: pending , Zotero.Schema.schemaUpdatePromise: pending
(3)(+0000000): Running unlock callbacks
(3)(+0000000): HTTP server listening on  <IP_ADDRESS>:23119
(3)(+0000001): Registering auto-sync idle observer
(3)(+0000000): Registering URIContentListener
(3)(+0000000): Getting contents of /Users/jrennstich/Zotero/locate/engines.json
(3)(+0000002): PluginInstaller: fetching addon info
(3)(+0000001): PluginInstaller: addon info fetched
(3)(+0000000): PluginInstaller: fetching addon info
(3)(+0000001): PluginInstaller: addon info fetched
(3)(+0000000): {better-bibtex} +543 Startup progress: Zotero locks after 1067: Zotero.uiReadyPromise: pending , Zotero.Schema.schemaUpdatePromise: pending
(1)(+0000002): Unknown item type 'nsfReviewer'
(1)(+0000000): Unknown item type 'nsfReviewer'
(3)(+0000261): Loading collection relations
(3)(+0000001): Loaded collection relations in 1 ms
(3)(+0000000): Loading item relations
(3)(+0000595): Loaded item relations in 594 ms
(3)(+0000001): {better-bibtex} +892 Startup progress: Zotero locks after 1959: Zotero.uiReadyPromise: pending , Zotero.Schema.schemaUpdatePromise: pending
(3)(+0000001): {better-bibtex} +1849 Startup progress: Zotero locks after 3808: Zotero.uiReadyPromise: pending , Zotero.Schema.schemaUpdatePromise: pending
(3)(+0000084): Getting contents of /Users/jrennstich/Library/Application Support/Zotero/Profiles/oxt32dqe.default/retractions.json
(3)(+0000003): Loading synced settings for library 1
(3)(+0000004): Loading all collections in My Library
(3)(+0000001): Loading primaryData for collections in My Library
(3)(+0000009): Loaded primaryData in My Library in 10 ms
(3)(+0000000): Loading childCollections for collections in My Library
(3)(+0000003): Loaded childCollections in My Library in 5 ms
...

My production setup is running BBT 5.2.53 without any problems. So reverting back to it might be safe.
(By chance, I missed updating to BBT 5.2.54 or higher. The setup was on manual update.)

@qqobb 7018 undoes the changes introduced by 54, so if 7018 works for you, I'd rather release that.

7018 works fine for me, with automaticScraperUpdates set to true.

[JavaScript Error: "Style with ID http://www.zotero.org/styles/apa already loaded from apa.csl" {file: "chrome://zotero/content/xpcom/style.js" line: 178}]

That's always in the log AFAICT, not related to BBT.

I went from BBT 5.2.53 to <IP_ADDRESS>18, which works well. The setting automaticScraperUpdates was at its default value true before and after installing 7018.


Upgrade Content::merge from a single 'other' argument to a std::vector of 'others'.

@ianna This might impact your work on PR #361, but the fact that only two arrays can be merged at a time is now a bottleneck (see https://github.com/scikit-hep/uproot4/pull/96#issuecomment-690622622).
Specifically, this interface:
https://github.com/scikit-hep/awkward-1.0/blob/911ba0b56429ed9ec19c42993c6a5c95a3447ff8/include/awkward/Content.h#L654-L657
is going to become:
 virtual const ContentPtr
   merge(const ContentPtrVec& others) const = 0;

(where ContentPtrVec is std::vector<std::shared_ptr<Content>>). I'll be updating this method and everything that calls it, which includes this Python:
https://github.com/scikit-hep/awkward-1.0/blob/911ba0b56429ed9ec19c42993c6a5c95a3447ff8/src/awkward1/operations/structure.py#L747-L754
If you're accessing merge by calling UnionArray::simplify_uniontype, then the direct interface changes may be hidden from you. On the other hand, you might be arranging loops to set things up in a pairwise way; with this fix, they could be made more efficient by loading all at once. If you're okay with that refactoring, then you could put off addressing this until the end, as a (huge) performance improvement.
The Content::mergeable interface, however,
https://github.com/scikit-hep/awkward-1.0/blob/911ba0b56429ed9ec19c42993c6a5c95a3447ff8/include/awkward/Content.h#L642-L652
will not be changing. This only checks for type-compatibility and doesn't stand to benefit in performance from taking a list as an argument.

@jpivarski - thanks for heads-up! It makes total sense.

One last thing to do: the Python ak.concatenate function should call mergemany, not merge.


[backport 1.x] Backport for healthchecks PR #329

Description
This PR introduces the missing healthcheck probes mentioned in #328 for 1.x versions. Refers to ticket #328 and PR #329.
Issues Resolved
#328
Check List

[ ] Commits are signed per the DCO using --signoff

For any changes to files within Helm chart directories:

[ ] Helm chart version bumped
[ ] Helm chart CHANGELOG.md updated to reflect change

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peterzhuamazon This is the backport PR for #329 😄 wasn't quite sure on how a backport PR should look like, I hope this is the correct way ^^ feel free to comment any kind of feedback!

@peterzhuamazon This is the backport PR for #329 😄 wasn't quite sure on how a backport PR should look like, I hope this is the correct way ^^ feel free to comment any kind of feedback!

Hi @lieberlois due to changelog we are not able to auto backport at this point.
Thus we just expect contributors to copy the changes from the main branch PR into the 1.x branch.
This looks great, adding @TheAlgo @prudhvigodithi for a final check before approval.
Thanks.


fix(option): correct IsPresent IsAbsent docstrings

The original docstrings for IsPresent and IsAbsent seemed wrong, or at the very least confusing. Let me know if I'm completely off base here!

argh
thanks for the fix :-(


Left Nav Compression and Expansion

When expanding the left nav and clicking on a menu item, the nav is compressed again. It's a little disorienting especially for new users.
What if we:

by default expand the nav since most new users won't know what the icons mean
leave the nav in the state that the user expects so that if it is expanded, it stays expanded when a link is clicked on and vice versa when it is collapsed (which it does now) until the user decides if it should be expanded or compressed.

@kayaelle Agree, good idea!


Object.entries(Record<K, string>) should get [string, string] but get [string, unknow]

Bug Report

🔎 Search Terms

🕗 Version & Regression Information

This is a crash
This changed between versions ______ and _______
This is the behavior in every version I tried, and I reviewed the FAQ for entries about _________
I was unable to test this on prior versions because _______

⏯ Playground Link

https://www.typescriptlang.org/play?ssl=12&ssc=2&pln=1&pc=1#code/CYUwxgNghgTiAEAzArgOzAFwJYHtX1RxgFsoIsAvEACgAcAueAZwxi1QHMBKRltzgLAAoYSAAetIhiRpMufAAsoqYBBAAFKGADWUDiABC7JgB4A0vHEYQKps1bsOAPmoAjY4wBK4IsHMAae35nLmEAb2EASDgMZBh8AHlXACtwDAA6GwcQJjdjUKFIyPS4YGQwGmooQIBtbUD3VABdLngAXicoyIjCosISMkoaRoL4MfGJsag6pvb4Rq7okFj4+CgugF9AsI21u28wXwCgxycCjaA
💻 Code
entries<T>(o: { [s: string]: T } | ArrayLike<T>): [string, T][];

declare function normalize(p: string): string

export function handlePackageBins<K extends string>(bins: Record<K, string>)
{
	return Object.entries(bins)
		.reduce((a, [k, bin]) =>
		{
			normalize(bin)
            a[k] = bin
			return a
		}, {} as Record<K, string>)
}

🙁 Actual behavior

🙂 Expected behavior

string

See #43266.


Migration to WebOptimizer and AngularJs $templateCache

@JudahGabriel ,
I was succesful with migrating to WebOptimizer. It is in beta but it seem that that where the next ASP.NET core is moving forward.

Doesn't look like this merges without conflicts. Can you resolve this? I had made some changes several days ago to finish the bundling client-side.

@JudahGabriel, I merged both of our changes. I was afraid that we will be moving files around. So my changes included moving away the TypeScript code from wwwroot into App folder and implementing Dynamic Caching and bursting of it via WebOptimizer. I will let you decide what direction you want to take from here.
Baruhot.


Ubergraph data review

Comments/issues on data review.

The kgx files look fine, but the current plater is missing stuff?  Take this edge for example:
UberGraph_1_norm_edges.json:{"id": "d367f35a2f1a91844474fd76b43f1fde", "subject": "GO:0007015", "predicate": "biolink:has_participant", "object": "GO:0005884", "relation": "RO:0000057", "source_database": "UberGraph properties-nonredundant"}
UberGraph_1_norm_edges.json:{"id": "d367f35a2f1a91844474fd76b43f1fde", "subject": "GO:0007015", "predicate": "biolink:affects", "object": "GO:0005884", "relation": "RO:0002592", "source_database": "UberGraph properties-nonredundant"}
I don't think that they are in the currently posted automat, and I don't know why not.

this appears to be related to the predicate 'biolink:has_participant' and not the subject/object ids. looking into it.

These edges are in the current graph


kubectl describe pod should print lastState

Include the LastTerminationState in the describe output
fixes: #10861
Signed-off-by: Sam Abed<EMAIL_ADDRESS>

I've run hack/run-gendocs.sh but still getting
ERROR!
Some docs are out of sync between CLI and markdown.
To regenerate docs, run:
hack/run-gendocs.sh

ok to test

@k8s-bot ok to test

@k8s-bot test this please

@k8s-bot ok to test

@k8s-bot test this please

@saad-ali @dchen1107 does this address the issue you raised in #11496 and #10861

updated to print the LastTerminationState only when LastTerminationState.Terminated is not nil
State and Last Terminations State are aligned for me

Thanks @samsabed
Just a nit on the spacing in docs/user-guide/compute-resources.md

@saad-ali thought you meant the command ! Thanks for the pointer and the review.
fixed the docs but left the tip about using get pod -o template to get the details, probably a good tip anyway.

Great, thanks @samsabed
LGTM

@k8s-bot test this please

@k8s-bot test this please

LGTM.


(re)sent tcp syn loop wireguard

I am trying to set up udp2raw with wireguard. I have it run as PreUp command on my client.
This is the log:
[2024-11-08 23:21:25][INFO]argc=10 udp2raw_mp -c -l <IP_ADDRESS>:51821 -r REDACTED:4440 -k labas --raw-mode faketcp
[2024-11-08 23:21:25][INFO]parsing address: <IP_ADDRESS>:51821
[2024-11-08 23:21:25][INFO]its an ipv4 adress
[2024-11-08 23:21:25][INFO]ip_address is {<IP_ADDRESS>}, port is {51821}
[2024-11-08 23:21:25][INFO]parsing address: REDACTED:4440
[2024-11-08 23:21:25][INFO]its an ipv4 adress
[2024-11-08 23:21:25][INFO]ip_address is {REDACTED}, port is {4440}
[2024-11-08 23:21:25][INFO]important variables: log_level=4:INFO raw_mode=faketcp cipher_mode=aes128cbc auth_mode=md5 key=labas local_addr=<IP_ADDRESS>:51821 remote_addr=REDACTED:4440 socket_buf_size=1048576
[2024-11-08 23:21:25][WARN]you can run udp2raw with non-root account for better security. check README.md in repo for more info.
[2024-11-08 23:21:25][INFO]remote_ip=[REDACTED], make sure this is a vaild IP address
[2024-11-08 23:21:25][INFO]const_id:363a2a34
[2024-11-08 23:21:25][INFO]--dev have not been set, trying to detect automatically, avaliable deives:
[2024-11-08 23:21:25][INFO]avaliable deives(device name: ip address ; description):
en0: [fe80::870:8c5c:d440:3aec] [<IP_ADDRESS>] [fd6a:be0:1e2a:14d:c09:99d4:5dce:cc71]; (no description avaliable)
awdl0: [fe80::ca2:5ff:fece:1873]; (no description avaliable)
llw0: [fe80::ca2:5ff:fece:1873]; (no description avaliable)
utun0: [fe80::77f8:6635:d763:80bb]; (no description avaliable)
utun1: [fe80::608b:cbd1:ab33:6fab]; (no description avaliable)
utun2: [fe80::82d1:163d:7cfc:2f47]; (no description avaliable)
utun3: [fe80::ce81:b1c:bd2c:69e]; (no description avaliable)
utun4: [fe80::4cd5:d6a1:86c1:fdeb]; (no description avaliable)
utun5: [fe80::b7a:1fd6:a797:9bcc]; (no description avaliable)
utun6: [no ip found]; (no description avaliable)
lo0: [<IP_ADDRESS>] [::1] [fe80::1]; (no description avaliable)
anpi2: [no ip found]; (no description avaliable)
anpi1: [no ip found]; (no description avaliable)
anpi0: [no ip found]; (no description avaliable)
en4: [no ip found]; (no description avaliable)
en5: [no ip found]; (no description avaliable)
en6: [no ip found]; (no description avaliable)
en1: [no ip found]; (no description avaliable)
en2: [no ip found]; (no description avaliable)
en3: [no ip found]; (no description avaliable)
bridge0: [no ip found]; (no description avaliable)
gif0: [no ip found]; (no description avaliable)
stf0: [no ip found]; (no description avaliable)
ap1: [no ip found]; (no description avaliable)
[2024-11-08 23:21:25][INFO]using device:[en0], ip: [<IP_ADDRESS>]
[2024-11-08 23:21:25][INFO]source_addr is now <IP_ADDRESS>
[2024-11-08 23:21:25][INFO]using port 20459
[2024-11-08 23:21:25][INFO]filter expression is [ip and tcp and src REDACTED and src port 4440 and dst port 20459]
[2024-11-08 23:21:25][INFO]breakloop() succeed after 4 attempt(s)
[2024-11-08 23:21:25][INFO]state changed from client_idle to client_tcp_handshake
[2024-11-08 23:21:25][INFO](re)sent tcp syn
[2024-11-08 23:21:26][INFO]state changed from client_tcp_handshake to client_handshake1
[2024-11-08 23:21:26][INFO](re)sent handshake1
[2024-11-08 23:21:28][INFO](re)sent handshake1
[2024-11-08 23:21:29][INFO](re)sent handshake1
[2024-11-08 23:21:30][INFO](re)sent handshake1
[2024-11-08 23:21:31][INFO](re)sent handshake1
[2024-11-08 23:21:32][INFO]state back to client_idle from client_handshake1

THIS IS WHEN THE WIREGUARD CONNECTION STARTS

[2024-11-08 23:21:32][INFO]source_addr is now <IP_ADDRESS>
[2024-11-08 23:21:32][INFO]using port 20946
[2024-11-08 23:21:32][INFO]filter expression is [ip and tcp and src REDACTED and src port 4440 and dst port 20946]
[2024-11-08 23:21:32][INFO]breakloop() succeed after 2 attempt(s)
[2024-11-08 23:21:32][INFO]state changed from client_idle to client_tcp_handshake
[2024-11-08 23:21:32][INFO](re)sent tcp syn
[2024-11-08 23:21:33][INFO](re)sent tcp syn
[2024-11-08 23:21:34][INFO](re)sent tcp syn
[2024-11-08 23:21:36][INFO](re)sent tcp syn
[2024-11-08 23:21:37][INFO](re)sent tcp syn
[2024-11-08 23:21:37][INFO]state back to client_idle from client_tcp_handshake
[2024-11-08 23:21:38][INFO]source_addr is now <IP_ADDRESS>
[2024-11-08 23:21:38][INFO]using port 17037
[2024-11-08 23:21:38][INFO]filter expression is [ip and tcp and src REDACTED and src port 4440 and dst port 17037]
[2024-11-08 23:21:38][INFO]breakloop() succeed after 3 attempt(s)
[2024-11-08 23:21:38][INFO]state changed from client_idle to client_tcp_handshake
[2024-11-08 23:21:38][INFO](re)sent tcp syn
[2024-11-08 23:21:39][INFO](re)sent tcp syn
[2024-11-08 23:21:40][INFO](re)sent tcp syn
[2024-11-08 23:21:41][INFO](re)sent tcp syn
[2024-11-08 23:21:42][INFO](re)sent tcp syn

If I instead run udp2raw manually without staring wireguard, it connects succesfully and says client_ready, but as soon as I then start wireguard it says source_addr is now <IP_ADDRESS> and starts the tcp syn loop.
Client
sudo udp2raw_mp -c -l <IP_ADDRESS>:51821 -r REDACTED:4440 -k "labas" --raw-mode faketcp > /var/log/VersmiuTCP.log 2>&1 &
Server
udp2raw -s -l <IP_ADDRESS>:4440 -r <IP_ADDRESS>:51820 -k "labas" --raw-mode faketcp -a > udp2raw.log  2>&1 &
My server is inside a proxmox vm, which might have something to do with NAT or Bridge network setup. But the client connects without starting wireguard so that makes me think that the vm is not the issue.
Wireguard config client
[Interface]
PrivateKey =
Address = <IP_ADDRESS>/24
DNS = <IP_ADDRESS>
MTU = 1280
PreUp = sudo udp2raw_mp -c -l <IP_ADDRESS>:51821 -r REDACTED:4440 -k "labas" --raw-mode faketcp > /var/log/VersmiuTCP.log 2>&1 &
PostDown = sudo killall udp2raw_mp

[Peer]
PublicKey =
PresharedKey =
AllowedIPs = <IP_ADDRESS>/0, ::/0
PersistentKeepalive = 0
Endpoint = <IP_ADDRESS>:51821

You need to do one of the steps here:
https://github.com/wangyu-/udp2raw/wiki/Known-issues-and-solutions
ip route add ${udp2raw_server_ip} via ${default_network_gateway}

So on Linux, that fixes the issue. But my main client is a MacOS machine, so I used the -g option and followed the instructions to add the rules:
pfctl -sr shows:
No ALTQ support in kernel
ALTQ related functions disabled
block drop inet proto tcp from REDACTED port = 4440 to any

and I also added sudo route -nv add -net REDACTED <IP_ADDRESS> which from what I understand is the equivalent of the ip route commant above.
Now the client MacOS shows client_ready in the logs, so all should work, but still no websites load and ping requests timeout.


Http headers

@yarax Would it be possible to ignore HTTP headers when generating the GraphQL schema since they can be added via the network request.

If I understood your concern correctly, is it acceptable for your case just remove headers from swagger parameters?

@yarax that is an option, but ideally, I would want to keep the swagger schema the same as production. Can you tell me what method I need to change in order to skip header arguments?
Also I notice that the swagger method descriptions are not added to the GraphQL Scheme, I'll see if I can resolve this issue.

I think ignoring original swagger parameters is not a good idea, but cutting out odd characters is probably reasonable. And mapping would increase interface complexity.
So I added cutting and also description from swagger endpoints, please check this for your purposes.

@yarax thanks, changes look good 👍 , but I got a few more suggestions could we also add summary field from swagger and use the operationId for the graphql method name.

operationId as a type name is a good idea
https://github.com/yarax/swagger-to-graphql/issues/11
About summary I'm not sure where it should be in GraphQL: field has only description field

operationId is done as a type name if exists in 1.0.4
Thanks for the issue!


Configure EnvoyFilter on istio ingress-gateway

Describe the feature request
The docs (https://istio.io/docs/reference/config/istio.networking.v1alpha3/#EnvoyFilter) are not clear if the envoy filter can be configured for istio ingress gateway, which are also envoy instances. The configuration seems to be applied on side car proxies only by the docs provided. I would like to avoid the extra hop if possible to have istio ingress gateway call the filter, instead of routing request to sidecar and then calling the filter. Is there a way to configure this?
Describe alternatives you've considered
I am able to configure EnvoyFilter using the doc provided, but only at the sidecar.

Why do you think so? No doc saying that.

Yes, the Doc doesn't say that. However, the filter doesn't get invoked unless I remove the app label.
If I change, listenerType: SIDECAR_INBOUND to listenerType: GATEWAY the filter does not get invoked unless I remove the workloadLabels that I had for SIDECAR_INBOUND listenerType filter.
  workloadLabels:
    app: httpbin-tls


[SPARK-26264][CORE]It is better to add @transient to field 'locs' for class ResultTask.

What changes were proposed in this pull request?
The field 'locs' is only used in driver side  for class ResultTask, so it is not needed to serialize  when sending the ResultTask  to executor.
Although it's not very big, it's very frequent, so we can add transient for it  like ShuffleMapTask.
How was this patch tested?
Existed unit tests

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5714/
Test PASSed.

Test build #99660 has started for PR 23216 at commit b3ede8b.

retest this please

Test build #99674 has started for PR 23216 at commit b3ede8b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5726/
Test PASSed.

Test build #99674 has finished for PR 23216 at commit b3ede8b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99674/
Test PASSed.

Are you sure it's even a field in the class? it looks like it's only used to define this:
  @transient private[this] val preferredLocs: Seq[TaskLocation] = {
    if (locs == null) Nil else locs.toSet.toSeq
  }

I'd expect Scala would not generate a field. Indeed the thing it is used to make is transient.

Are you sure it's even a field in the class? it looks like it's only used to define this:
  @transient private[this] val preferredLocs: Seq[TaskLocation] = {
    if (locs == null) Nil else locs.toSet.toSeq
  }

I'd expect Scala would not generate a field. Indeed the thing it is used to make is transient.

Yeah, it would not generate a field, thanks @srowen
By the way, is it better to remove transient for ShuffleMapTask?

I think just leave it. The @transient in ShuffleMapTasks's locs is just superfluous here, not sure it's worth changing.

Ok, I will close this PR, thank you very much


[Embeddingapi] Add tests for new exposed APIs

Test APIs:
setLoadsImagesAutomatically/getLoadsImagesAutomatically
set/getBlockNetworkImage
set/getMediaPlaybackRequiresUserGesture
set/getSupportMultipleWindows
Impacted tests(approved): new 10, update 0, delete 0
Unit test platform: Crosswalk for Android 22.52.561.0
Unit test result summary: pass 10, fail 0, block 0
BUG=https://crosswalk-project.org/jira/browse/CTS-1841

@Honry

LGTM


Need TCP server

Type: Feature Request
The function is required to create a local TCP server to listen to the local network port.
If possible, the client and server with UDP function are also needed, which will be very helpful. A simple embedded communication test tool will be directly available in VS Code.
Thanks.

Hi @sgmklp, following up on your request! For now, we don't have the bandwidth, so we've placed it on the backlog.
Also, we typically sort our backlog by the amount of up-votes, so we encourage you to up-vote the issue and we will track the up-votes!

On Windows computers, there are many socket debugging assistants, but on Mac or Linux, the nc command is usually used for debugging. If vscode can integrate the socket server function, I think it's great.


Introduce a timeout for the Parsing/Analysis stage

Problem Statement
In an environment where users can run arbitrary queries, or where applications can be induced to run queries of increased complexity, it is desirable for administrators to be able to limit how many resources can go into individual requests to avoid that a few requests, accidentally or with malicious intent, prevent other request from performing adequately.
CrateDB already has a statement_timeout but it does not currently apply to optimization time.
Relates with https://github.com/crate/crate/issues/15997 and https://github.com/crate/crate/issues/16066
Possible Solutions

make the existing statement_timeout also apply to optimization time?
introduce a separate "compilation" timeout as in other systems

Considered Alternatives
No response

If time were difficult to check maybe this could take the form of some other limit? (number of iterations or something like that)

A naive approach that we can backport would be to just add a count of how much time is spent on each step (parser, analyzer, planner) and check for every one of them if the timeout has expired before moving to the next, and finally the execute. Of course, in this case, we don't interrupt the statement, so we don't protect against lots of resources being used during those phases.
We need to pass the ScheduledExecutorService from the thread pool, to all those components, so that we can call schedule() with the timeout set, to have the same behavior as we currently have only for the execution phase.

We still need to count for the time spent in previous steps and subtract from the value we get from the setting.
We need to inject the scheduler into all those components, which requires some work, and also adjust our test layer accordingly.
Parser, analysis, planning (and optimizing) we all become async, unless you have some other idea to implement the interruption.

As discussed, we will go with the proper solution (2), as with the 1st one we don't address the issue of interrupting the statement and prevent it from continuing to consume resources.

Using just a separate thread and using the scheduler, won't solve the issue of being able to interrupt the execution at any point, as there needs to be a repeated check which evaluates the time passed against the timeout setting.
So, we just need to add checks for the time passed after Parser, after Analysis, and in a couple of places where we have iterations (check probably on every X iterations): EqualityExtractor (the iteration over the cartesian product) and plan Optimizer.
(Perhaps check if there is another similar code path that could potentially consume too much time).


Add a toggle button enable/disable the automatic Karma runner

Would it be possible to add a toggle button to the Visual Studio toolbars, which turns the automatic test runner on and off?  Our project has quite large and team members are often working on other parts of the system, other than the JS.  I know we can set the Disabled property to false in the Adapter file, but I think it would be much more convenient if there was a way of turning the tests on and off directly in the IDE.

@zacharybussey Thank you for your suggestion. I am not sure how to do this, and I find that my time is becoming limited. When I get some time again I will certainly look into how to achieve this.
You are of course welcome to send a pull request. :smile:


Add is_active column in table Action Area outcomes

Description:
An attempt was made to delete an action area outcome, but it was observed that there was no logical deletion, so a column needs to be created so as not to have to delete the record from the database.
Add Screenshot
Tasks:

[x] Migration
[x] Frontend
[x] Hibernate Modification
[x] Control list

Additional comments:

Manuel carried out the tests and went into production


Adding free course for Ruby

Add a free course about Ruby for beginners.
Complete Ruby Tutorial for Beginners
@avinash201199 Could you please assign it to me? So I can work on it.

#146


rustup-init segfault when using --no-modify-path

This is something I noticed while building the official rustup package for Arch Linux. The build script looks like this:
build() {
    cd "$srcdir/$pkgname.rs-${pkgver}"
    # cargo update
    cargo build --release --features no-self-update --bin rustup-init

    mkdir -p "$srcdir/tmp/.cargo"
    env -u CARGO_HOME "HOME=$srcdir/tmp" target/release/rustup-init -y --no-modify-path
}

It segfault at the last line with
/startdir/PKGBUILD: line 17:   764 Segmentation fault      (core dumped) env -u CARGO_HOME "HOME=$srcdir/tmp" target/release/rustup-init -y --no-modify-path

When I take away the --no-modify-path it doesn't segfault anymore.
This is only appears to happen on x86_64 and works fine on i686.

Thanks for the report!

I haven't been able to reproduce this on my Ubuntu system with the rustc 1.14.0-nightly (cae6ab1c4 2016-11-05) toolchain.

Maybe provide a dump of env output inside the PKGBUILD? I do some Gentoo packaging and know that build recipes (ebuilds in Gentoo land) usually run in quite bizarre environments set up by the package manager. Pretty much the entirety of rustup CLI is test-covered so it's unlikely to be reproduced with ordinary use (and environments).

LANG=C
SUDO_GID=0
OLDPWD=/build/rustup/src
COMMAND_MODE=legacy
USERNAME=builduser
SUDO_COMMAND=/usr/bin/makepkg -s --noconfirm -L --holdver -i
CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong
USER=builduser
CXXFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong
TEXTDOMAINDIR=/usr/share/locale
PWD=/build/rustup/src/rustup.rs-1.0.0
HOME=/build
TEXTDOMAIN=pacman-scripts
SUDO_USER=root
SUDO_UID=0
MAIL=/var/mail/builduser
CHOST=x86_64-pc-linux-gnu
SHELL=/bin/bash
TERM=xterm-256color
SHLVL=1
CPPFLAGS=-D_FORTIFY_SOURCE=2
LOGNAME=builduser
LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro
PATH=/usr/local/sbin:/usr/local/bin:/usr/bin:/usr/bin/site_perl:/usr/bin/vendor_perl:/usr/bin/core_perl
MAKEFLAGS=-j13
_=/usr/bin/env

Hmm... this is becoming interesting. Have you tried to extract a backtrace with RUST_BACKTRACE=1? Sorry I forgot to also request this information, as I previously was concerned with the envvars.

Build fine on Arch (x86_64) with rustc 1.13.0.


VLAZ: Watch mahaveerdistributors.com

VLAZ requests the watch of the watch_keyword mahaveerdistributors\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

mahaveerdistributors\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by cigien in Charcoal HQ


Major: Function type with Date argument accepts a function with number argument

Flow verisons
Seems to happen on any version I've tried so far:

0.37
0.40
0.42
0.50
0.57.1
0.61

Code (Try flow link)
type DateCallback = (value: Date) => Promise<any>

function foo(value: number): Promise<any> {
  return Promise.resolve()
}

(foo: DateCallback);

Expected
7: (foo: DateCallback);
     ^ function. This type is incompatible with
7: (foo: DateCallback);
          ^ function type
This parameter is incompatible:
1: type DateCallback = (value: Date) => Promise<any>
                               ^ Date. This type is incompatible with
3: function foo(value: number): Promise<any> {
                       ^ number

Actual
No errors!

Reduced case:
declare var x: Date;
(x: number); // no error

whoa!

It must have to do with making Flow support comparisons between numbers and Dates

This a major was a major "WAT" moment for me? Is this intentional. Ideally this should throw an error, but it doesn't.
const time: number = new Date();

@jedwards1211 looks like you are correct. Removing instances of Date from the numeric test at https://github.com/facebook/flow/blob/master/src/typing/flow_js.ml#L7312-L7313 fixes this particular issue, but makes it impossible to perform numeric operations on Dates

One solution might be to remove the numeric attribute of Date and force users to do Number(myDate) > Number(theirDate).

Agreed. Date and number share some common arithmetic operations but they're definitely not the same type.

I think it's possible to fix this issue without breaking support for number + Date and so forth.

Funny you should mention number + Date! Turns out + stringifies Date, and all the other numeric operators numberifies Date.

Meanwhile flow happily accepts const a: number = new Date() + 12;


Make HTML template functions support context

Background
Golang template is not friendly for large projects, and Golang template team is quite slow, related:

https://github.com/golang/go/issues/54450

Without upstream support, we can also have our solution to make HTML template functions support context.
It helps a lot, the above Golang template issue #54450 explains a lot:

It makes {{Locale.Tr}} could be used in any template, without passing unclear (dict "root" . ) anymore.
More and more functions need context, like avatar, etc, we do not need to do (dict "Context" $.Context) anymore.
Many request-related functions could be shared by parent&children templates, like "user setting" / "system setting"

See the test TestScopedTemplateSetFuncMap, one template set, two Execute calls with different CtxFunc.
The Solution
Instead of waiting for upstream, this PR re-uses the escaped HTML template trees, use AddParseTree to add related templates/trees to a new template instance, then the new template instance can have its own FuncMap , the function calls in the template trees will always use the new template's FuncMap.
template.New / template.AddParseTree / adding-FuncMap are all quite fast, so the performance is not affected.
The details:

Make a new html/template/Template for all templates
Add template code to the all template
Freeze the all template, reset its exec func map, it shouldn't execute any template.
When a router wants to render a template by its name

Find the name in all
Find all its related sub templates
Escape all related templates (just like what the html template package does)
Add the escaped parse-trees of related templates into a new (scoped) text/template/Template
Add context-related func map into the new (scoped) text template
Execute the new (scoped) text template
To improve performance, the escaped templates are cached to template sets

FAQ
There is a unsafe call, is this PR unsafe?
This PR is safe. Golang has strict language definition, it's safe to do so: https://pkg.go.dev/unsafe#Pointer (1) Conversion of a *T1 to Pointer to *T2
What if Golang template supports such feature in the future?
The public structs/interfaces/functions introduced by this PR is quite simple, the code of HTMLRender is not changed too much. It's very easy to switch to the official mechanism if there would be one.
Does this PR change the template execution behavior?
No, see the tests (welcome to design more tests if it's necessary)

.


Add a place to view information about Authentication Script templates

Description:
In the WSO2 IS Management Console, authentication script templates has an option to view information related to the corresponding template. But in the new Developer Portal, that feature is missing.

Fixed


add Lagom

test run: https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/2419/consoleFull (404 til Jenkins finishes concealing his hardwon stash of gold dust in the pinky finger of his left glove)

green, but it's also very little code:
     1339 lagom

added a few more subprojects. test run: https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/2433/consoleFull (404 while Jenkins tries to remember which of the La Croix flavors in the tall skinny cans he actually likes)

fyi @TimMoore @jroper

hmm, wonder how deep this rabbit hole is:
[lagom] Processing subproject: persistence-cassandra-core
[lagom] [error] **** Missing dependency: the library com.typesafe.akka#akka-persistence-cassandra is not provided (in space "scala") by any project in this configuration file.

akka-persistence-cassandra built on the first try. that's what I like, a nice short rabbit hole with a big fat rabbit in it

[lagom] [info] - must resume from stored offset *** FAILED *** (8 seconds, 470 milliseconds)
[lagom] [info]   The code passed to eventually never returned normally. Attempted 28 times over 8.264081945 seconds. Last failure message: 4 was not equal to 5. (AbstractReadSideSpec.scala:101)
[lagom] [info]   org.scalatest.exceptions.TestFailedDueToTimeoutException:

might need a longer timeout

[lagom] Processing subproject: persistence-cassandra-scaladsl
...
[lagom] [info] *** 1 TEST FAILED ***
[lagom] [error] Failed: Total 20, Failed 4, Errors 0, Passed 16
[lagom] [error] Failed tests:
[lagom] [error] 	com.lightbend.lagom.scaladsl.persistence.cassandra.CassandraClusteredPersistentEntitySpec
[lagom] [error] 	com.lightbend.lagom.scaladsl.persistence.cassandra.CassandraReadSideSpec

I think I found a hack that will let us skip running the tests in that subproject only:
set executeTests in `persistence-cassandra-scaladsl` in Test := Tests.Output(TestResult.Passed, Map(), Iterable())

new test run: https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/2441/consoleFull

The tests don't have an external dependency... they start up anything they need. It might just be that the build agent is resource constrained and things are taking a bit longer than the tests wait.
We can adjust timeouts as needed.

green! squashed, merged.
but with:
+      "set executeTests in `server-scaladsl` in Test := Tests.Output(TestResult.Passed, Map(), Iterable())"
 +      "set executeTests in `testkit-scaladsl` in Test := Tests.Output(TestResult.Passed, Map(), Iterable())"
 +      "set executeTests in `persistence-cassandra-scaladsl` in Test := Tests.Output(TestResult.Passed, Map(), Iterable())"

I don't feel that I have time to investigate the test failures; what we have here is a good base.

new cloc-counted line count:
     7814 lagom