YARN-11067. Resource overcommitment due to incorrect resource normali…

…sation logical order

Description of PR
How was this patch tested?
For code changes:

[ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 53s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 33s

trunk passed

+1 :green_heart:
compile
1m  7s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
0m 58s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 49s

trunk passed

+1 :green_heart:
mvnsite
1m  3s

trunk passed

+1 :green_heart:
javadoc
0m 53s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 45s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 53s

trunk passed

+1 :green_heart:
shadedclient
20m 56s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 53s

the patch passed

+1 :green_heart:
compile
0m 58s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
0m 58s

the patch passed

+1 :green_heart:
compile
0m 49s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 49s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 38s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 3 new + 23 unchanged - 0 fixed = 26 total (was 23)

+1 :green_heart:
mvnsite
0m 55s

the patch passed

+1 :green_heart:
javadoc
0m 40s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 39s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 54s

the patch passed

+1 :green_heart:
shadedclient
20m 42s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
96m 37s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
asflicense
0m 34s

The patch does not generate ASF License warnings.

186m 32s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3919/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3919

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux abc3bc5d998b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ad139ca9f91bff438ff236c2906ffdb8b8212d0d

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3919/1/testReport/

Max. process+thread count
960 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3919/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 15s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  3s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
36m 41s

trunk passed

+1 :green_heart:
compile
1m 12s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
1m  6s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 50s

trunk passed

+1 :green_heart:
mvnsite
1m  9s

trunk passed

+1 :green_heart:
javadoc
0m 56s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 51s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 59s

trunk passed

+1 :green_heart:
shadedclient
27m  3s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  4s

the patch passed

+1 :green_heart:
compile
1m  8s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
1m  8s

the patch passed

+1 :green_heart:
compile
0m 56s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 56s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 41s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 3 new + 23 unchanged - 0 fixed = 26 total (was 23)

+1 :green_heart:
mvnsite
1m  4s

the patch passed

+1 :green_heart:
javadoc
0m 44s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 40s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 12s

the patch passed

+1 :green_heart:
shadedclient
25m  6s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
104m  3s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
asflicense
0m 30s

The patch does not generate ASF License warnings.

210m 13s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3919/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3919

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 3eda6284748b 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ad139ca9f91bff438ff236c2906ffdb8b8212d0d

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3919/2/testReport/

Max. process+thread count
869 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3919/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 51s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
34m 45s

trunk passed

+1 :green_heart:
compile
1m  5s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
0m 55s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 45s

trunk passed

+1 :green_heart:
mvnsite
1m  2s

trunk passed

+1 :green_heart:
javadoc
0m 49s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 43s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 56s

trunk passed

+1 :green_heart:
shadedclient
23m 58s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
24m 15s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 53s

the patch passed

+1 :green_heart:
compile
0m 59s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
0m 59s

the patch passed

+1 :green_heart:
compile
0m 50s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 50s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 39s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 3 new + 23 unchanged - 0 fixed = 26 total (was 23)

+1 :green_heart:
mvnsite
0m 53s

the patch passed

+1 :green_heart:
javadoc
0m 40s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 38s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m  0s

the patch passed

+1 :green_heart:
shadedclient
24m 24s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
143m 14s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
hadoop-yarn-server-resourcemanager in the patch passed.

-1 :x:
asflicense
0m 29s
/results-asflicense.txt
The patch generated 1 ASF License warnings.

241m 38s

Reason
Tests

Failed junit tests
hadoop.yarn.server.resourcemanager.TestApplicationACLs

hadoop.yarn.server.resourcemanager.security.TestAMRMTokens

hadoop.yarn.server.resourcemanager.security.TestClientToAMTokens

hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerQueueACLs

hadoop.yarn.server.resourcemanager.scheduler.capacity.TestApplicationPriorityACLs

hadoop.yarn.server.resourcemanager.TestClientRMService

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3919/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3919

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 886a552e7e31 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / af09af649a0daa2203b20c78618a88d5dd0d1834

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3919/3/testReport/

Max. process+thread count
881 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3919/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 53s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
36m  7s

trunk passed

+1 :green_heart:
compile
1m  8s

trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
0m 57s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 45s

trunk passed

+1 :green_heart:
mvnsite
1m  2s

trunk passed

+1 :green_heart:
javadoc
0m 52s

trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
0m 43s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 58s

trunk passed

+1 :green_heart:
shadedclient
24m 56s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
25m 13s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 53s

the patch passed

+1 :green_heart:
compile
1m  2s

the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
1m  3s

the patch passed

+1 :green_heart:
compile
0m 51s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 51s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 38s

the patch passed

+1 :green_heart:
mvnsite
0m 56s

the patch passed

+1 :green_heart:
javadoc
0m 41s

the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
0m 38s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 25s

the patch passed

+1 :green_heart:
shadedclient
25m 53s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
105m 44s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
asflicense
0m 31s

The patch does not generate ASF License warnings.

208m  5s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3919/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3919

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 7e040d12a67c 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 8d193ca4f566b6c878203bd07eb3b8dcb92c0469

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3919/4/testReport/

Max. process+thread count
929 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3919/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Thanks @9uapaw for working on this,
Quite a nice finding.
Latest patch LGTM, committed to trunk.
Thanks @brumi1024 for your review.


[FEATURE] Please Document How You Expect Enums to Be in the swagger.json file

Is your feature request related to a problem? Please describe.
The documentation says that you support enum mappings, but it doesn't say in what format in the file. In the samples, I can't find anything but string values, no mappings that map ints to string values in the enums.
Describe the solution you'd like
Please provide explicit guidance on how you want enums presented in the swagger.json file.
As an example I have the following that works in many places but not here:
"ContactTypes": {
        "enum": [
          1,
          2,
          3
        ],
        "type": "integer",
        "description": "Contact Types",
        "format": "int32",
        "x-ms-enum": {
          "name": "ContactTypes",
          "modelAsString": true,
          "values": [
            {
              "value": 0,
              "name": "value__",
              "description": "value__"
            },
            {
              "value": 1,
              "name": "Person",
              "description": "Person"
            },
            {
              "value": 2,
              "name": "Organization",
              "description": "Organization"
            },
            {
              "value": 3,
              "name": "Government",
              "description": "Government"
            }
          ]
        }
      },

The OpenApi 1-3 schema doesn't support the mapping. V3.1 supports oneof, but it isn't clear if this supports one of.
I assume x-ms-enum isn't supported (Auto Rest) per above?
Does it support oneof instead?
Swagger specification link
https://swagger.io/docs/specification/data-models/oneof-anyof-allof-not/
https://swagger.io/docs/specification/data-models/enums/
https://github.com/stankovski/AutoRest/blob/master/Documentation/swagger-extensions.md#x-ms-enum

PS: if it doesn't support ms-x-enum it would be nice if it did, as this is pretty common out there in the wild and would solve the entire problem.

Hi @jhancock4d , indeed we do not support 'ms-x-enum'. Could you share swagger file with such enums to implement and test fix?

@Vovanella95 here's a link to one: https://api.cadlearning.com/help/v1/swagger.json
Note that OpenApi 3.1 also supports enums with "oneOf" that is perported to do the same. I'd suggest supporting both x-ms-enum and whatever the OpenApi 3.1 standard is for this.

I would focus on OpenApi 3.1 instead of custom tags as everything custom needs additional time to support.

I would focus on OpenApi 3.1 instead of custom tags as everything custom needs additional time to support.

x-ms-enum is not really a custom tag. It's the defacto standard and used by Microsoft, Google and Amazon to name just 3 large ones.
It just happened to be created by Microsoft while the company that runs Swagger wagged an ideological war about this for several years before finally giving in and accepting that yes, enums are key/value pairs and not just some hard coded text from the language that swagger originated from that didn't have numerical values. (like Dart before it finally was added properly)

Hi @JohnGalt1717  @jhancock4d  I have implemented your feature. Looks like swagger you attached generated well. I am closing the issue.

Thanks so much!!!


Clicking on DatePicker's ClearIcon does not reset the value

Which package has an issue?
@yamada-ui/react
Package Version
1.3.12
Description
When using react-hook-form, the value is not reset even if you click ClearIcon of DatePicker.
Link to Reproduction
No response
Steps to Reproduce

Set register to DatePicker.
Click on DatePicker's ClearIcon.
See ClearIcon.

Browser
Chrome
Operating System

[X] macOS
[ ] Windows
[ ] Linux

Do you know how to fix the issue?
None
Are you willing to participate in fixing this issue and create a pull request with the fix?
None
Additional Information
No response

I don't know if it's a specification or a bug of react-hook-form, but it's probably caused by the value becoming undefined. You can avoid this problem by making it null.
<Controller
  name="datePicker"
  control={control}
  rules={{ required: { value: true, message: "This is required." } }}
  render={({ field }) => {
    return (
      <DatePicker
        placeholder="YYYY/MM/DD"
        {...field}
        onChange={(value) => {
          field.onChange(value ?? null)
        }}
      />
    )
  }}
/>


Update my models

Pull Request Test Coverage Report for Build 180

0 of 0   changed or added relevant lines in 0 files are covered.
28 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.4%) to 77.277%

Files with Coverage Reduction
New Missed Lines
%

home/travis/build/asheuh/flaskie/flaskie/api/v2/models.py
28
54.88%

Totals

Change from base Build 177:
0.4%

Covered Lines:
925

Relevant Lines:
1197

💛  - Coveralls


ExpandoObject JSON.stringify broken

Simple repro:
var a = { cat: 'meow', dog: 'woof' };
var b = new ExpandoObject(a);
var c = JSON.stringify(b);

This returns '{}'.
The problem is the implementation of ExpandoObject.toJSON:
toJSON(data?: any) {
    data = typeof data === 'object' ? data : {};
    return data;
}

I don't think it's using the sole argument correctly (toJSON behavior section). In fact I don't think it needs to touch it at all. If it's implemented like this instead, it works as expected:
toJSON(data?: any) {
    return this;
}

I think we should treat ExpandoObject as Dictionary<string, object> and not generate it as type... what do you think?

I'm not sure how Dictionary<string, object> is treated right now. But I think in general that a controller with a method that accepts ExpandoObject, dynamic, or Dictionary<string, object> should all just generate TypeScript code that takes an any and serializes it using the default toJSON.

Yes


[NIFI-11258] update nifi-registry frontend deps

To Test
Build and start nifi-registry.
Summary
NIFI-11258
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking

[ ] Apache NiFi Jira issue created

Pull Request Tracking

[ ] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
[ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

[ ] Pull Request based on current revision of the main branch
[ ] Pull Request refers to a feature branch with one commit containing changes

Verification
Please indicate the verification steps performed prior to pull request creation.
Build

[ ] Build completed using mvn clean install -P contrib-check

[ ] JDK 11
[ ] JDK 17

Licensing

[ ] New dependencies are compatible with the Apache License 2.0 according to the License Policy
[ ] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

[ ] Documentation formatting appears as expected in rendered files

Reviewing now...


Reactive forms using FormBuilder.array() loses focus of input control

Bug, feature request, or proposal:
Bug in ReactiveForms
What is the expected behavior?
After entering a value the focus should remain in the input control. The input control is created using FormBuilder.array().
What is the current behavior?
After entering a value the input control loses the focus.
What are the steps to reproduce?
Providing a github repository link below. Please refer the readme.md for more details.
https://github.com/patilmangeshv/ngFormsIssue.git
What is the use-case or motivation for changing an existing behavior?
It seems a bug unless I am missing something in my code.
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular version 9.1.9
OS: MacOS 10.15.4
Typescript: 3.8.3
Is there anything else we should know?
Please readme.md file for more details

You're posting in the wrong repository - this repository is for Angular components including Angular Material and the CDK. I suggest that you should either:

Post a bug report on the Angular repository
Or ask a question on StackOverflow

Closing since the project doesn't appear to be using any of the components from this repository.


Create an application in Go to serve kube stats over a json endpoint

Shields.io was updated so that it can generate badges from JSON. https://shields.io/badges/dynamic-json-badge
It would be great to have node count, pod count and CPU/memory utilization on my README and the only way I can think to make this happen would be to create a simple Go app that can pull this info from my cluster and serve the stats over a public JSON endpoint. If there's a way to do this without building a custom app that would be awesome.

This was done here https://github.com/kashalls/kromgo/


Improvements

allow build on all branches
CS fixes

Could you please leave .css files as they are?
Tests results -> 👍
thx

done


How to import Fonawesome Pro in to RNVI?

In my project, use FontAwesome Pro, how to import another libraries font in to RNVI?
Thanks

Hi, please check the readme on how to generate custom fonts 👍


Feature request: Gradient picker widget

Is your feature request related to a problem? Please describe.
Many graphical applications would benefit from user-editable gradients (Game level editors, animation tools, data visualization tools etc.) There is no easy way to create and edit gradients with egui controls.
Describe the solution you'd like

It would be nice if a gradient picker similar to the color picker that is already present. Additionally a data structure for representing gradients should be added (maybe it needs to be coordinated with the styling subsystem, so egui widgets can be styled with those gradients?)
Describe alternatives you've considered

One thing to ponder about is whether the gradient data structure and editor should include the "shape" of the gradient (linear, radial, circular, diamond etc.) or just represent a mapping between [0, 1] -> Color32. Including the shape might make no sense for some applications (i.e. color mapping for a plot, where the color depends on some value and not the position).
Personally I believe there should be one data structure for just the mapping, and later a structure wrapping it could be added, which contains the type of gradient, if needed.
Additional context

I have collected some samples of gradient editors from different software and toolkits:
Figma

A bar with the color stops and a preview of the gradient is visible above a standard color picker. The color stops can be clicked to focus them and edit their colors, as well as dragged around to change their position the gradient. Clicking the empty space between them adds another stop. To delete a stop one must press delete or backspace while one of the stops is focused. When a color has some transparency the stop gizmo splits in half, and one half shows the solid color, while another is multiplied with the alpha.
Overall, pretty solid gradient picker.
Blender

In blender the gradient preview is shown between two sets of additional controls, and above a color preview. To change the color one must click the color preview, and then a color picker appears. Adding and removing color stops can only be done via the +/- buttons on the top (no keyboard shortcuts for them). The + button always adds the gradient stop halfway between the currently selected stop, and the previous one.  The markers on the gradient strip can only be dragged around, clicking inbetween them does nothing. Additionally the number and fractional position of the stop are displayed textually as separate edit boxes.
Additionally there is an utility menu for automatically distributing the stops, and select boxes for the color mode and interpolation type:

I think this one is somewhat clunky, but it does contain some advanced graphical features.
imgui_gradient

https://github.com/CoolLibs/imgui_gradient
A sort of blend between the two above, stops can be added by clicking but it also includes the textual representation and pop up color editor.
PS. If you think it is an OK feature to add to egui, I might be able to create a PR with one.

Like imgui_gradient, I think this makes more sense as a 3rd-party crate (egui_gradient). Build it and link to it from https://github.com/emilk/egui/issues/1942 !


License missing

Hello, first of all thanks for providing the template. I read your disclaimer and also noticed that there is no license attached to this repository. Did you think about which one might be a good fit? Otherwise, technically reuse of the materials is never possible. If you like I can look into what might be a good license for this repository.

Hi @kequach ! Thanks for raising this issue and sorry for the slow reply. I'm happy to see that people are interested in the template :)
RE the license issue: That's a very good point and has been on my internal to do list for a while. I'm all for licensing stuff under fairly permissive licenses (I like MIT for code). The thing is that I'm completely uncertain about the various legal dimensions here since the tex-code implements a protected university style. I suppose that we'd need to get in touch with the house style people, hear what they have to say and get some sort of internal approval for licensing this one way or the other.
At the moment, I have too much on my stack to take care of this properly. But if you're interested in contributing and researching the related issues, that'd be fantastic!

Thanks for your reply! I will take a look and you will hear back, hopefully in the form a pull request :)

Hi @kequach ! Any updates on this? I'm doing some work on the class and this would be a great time to add a license..

Hi @jkorb, apologies for not answering. I'll talk to Jonathan and will get back to you as soon as possible.

Hi @jkorb, I added a pull request with the license that was chosen. This was discussed together with the relevant parties at UU. If I can help out with anything else, please feel free to reach out anytime and again apologies for the delay.

Fantastic, thanks so much! I'll check it out asap. And absolutely no need to apologize: we're all doing this on a voluntary basis, and your help is greatly appreciated :)


Invalid reuse of previous clause variable in succeeding CREATE clause

Describe the bug
The succeeding CREATE clause is letting the reuse of variable of the previous CREATE.
How are you accessing AGE (Command line, driver, etc.)?
psql
What is the command that caused the error?
SELECT * FROM cypher('graph', $$ CREATE(n) CREATE(n)  RETURN n $$) AS (result agtype);

creates one vertex
                             result
----------------------------------------------------------------
 {"id":<PHONE_NUMBER>10657, "label": "", "properties": {}}::vertex
(1 row)

Environment (please complete the following information):
AGE master - PG16
Expected behavior
The second CREATE clause should give a duplicate variable error. Neo4j errors out as:
Variable `n` already declared (line 1, column 18 (offset: 17))
"CREATE(n) CREATE(n)  RETURN n"
                  ^

@Zainab-Saad Good catch!

@Zainab-Saad If you are planning on creating a PR to fix this, please note it here :)

This can be a project. The other executors may have similar issues. #1446 is a related one.


Add a contributor template

Help others improve their pull request skills with a contributor template. This will include useful things to mention in your Pull Request such as:

New additions
Changes

Hey @wrussell1999! We ( @PrateekSane , @PayasSingh and I) will be working on this. Thank you!

#41 closes this issue


There are Missing parentheses!

https://github.com/Manisso/fsociety/blob/5a4388171a7149687bc902075f11ad3e573b0889/fsociety.py#L1138

Thanks, I'll fix it.

All fixed!

All fixed!

Bro, there are literally many missing parantheses, I updated your repository, and here's another issue:
https://github.com/Manisso/fsociety/blob/e67677fa851b7efaada8c240a223f72322761e12/fsociety.py#L1154
I dont know how many other areas have a similar issue. Did you have this for Python2 initially??

I was thinking that we update the code for running it in python3 but, at the moment Python 2 is (/should) be the code exec to run Python (sudo python2 fsociety.py)

I was thinking that we update the code for running it in python3 but, at the moment Python 2 is (/should) be the code exec to run Python (sudo python2 fsociety.py)

Yeah I get that... although I am not the one who is executing the fsociety.py file, I'll make the required change in the install scripts to run the file properly though. All the best upgrading the code... I guess it will be tedious though.

Yeah, updateing over 1000 lines of code for 1 version of code is hard but, can be done. I'll talk to some people in the fsociety team about updateing it. For now, I'm going to close the issue.


Missing images in Instagram bridge: URL signature expired

Some of the images in my Instagram feed fails to load. When I check the missing image URL, I get a 403 error from the Instagram CDN, with this message: URL signature expired. Here is an example image URL that RSS Bridge uses for this post.
Searching online I came across a couple of useful links:

https://stackoverflow.com/a/48582513/995958
https://github.com/stevenschobert/instafeed.js/issues/549

Looks like Instagram generates tokens for image URLs that are invalidated after some time, I can't tell exactly how much time. Unfortunately I don't see an immediate solution to this, I hope the discussion will make something pop up.
The only idea I have is to use an image URL that points to RSS-Bridge itself, with a params to identify the Instagram post, so it can always retrieve the imagine dynamically, with an always updated signature/token. But I don't know if this is compatible with the current RSS-Bridge architecture.

Depending on your feed reader, maybe you can enable image caching for your feed?

The only idea I have is to use an image URL that points to RSS-Bridge itself, with a params to identify the Instagram post, so it can always retrieve the imagine dynamically, with an always updated signature/token.

That might work, but such a solution is too specific to be added as feature to RSS-Bridge in my opinion. That being said, RSS-Bridge could cache images and replace URIs in feeds to use cached versions.  Of course, this option needs to be optional and disabled by default. Maybe even customizable to specific bridges.

Check my reply here

Thanks @siddhartharora02, I'll do some tests and try to work on a PR.


Set title as the first question needed for creating a brief

Previously, our assumption had been that titles were of lesser importance/value than actually picking a location or role (arguably, it gets the buyer thinking of the important thing about their brief sooner), but now we don't know if that's a real thing.
@ralph-hawkins isn't here and the prototype starts with selecting a title, so let's do that.

:+1:


[3.x] Add Dusk to require-dev

Because Twill 3 is refering to Laravel\Dusk\Browser I believe Dusk should be added to composer.json. Otherwise any packages doing static analysis on a Twill based code will have to add Dusk to their own composer.json.
Error thrown in /Users/antonioribeiro/code/area17/twill-google-recaptcha/vendor/area17/twill/src/DuskServiceProvider.php on line 17 while loading bootstrap file /Users/antonioribeiro/code/area17/twill-google-recaptcha/vendor/nunomaduro/larastan/bootstrap.php: Class "Laravel\Dusk\Browser" not found

Hey @antonioribeiro,
Might be wrong but require-dev is never installed as part of the install process of packages.
Are you running composer install in twill vendor's folder?

Hey @haringsrob, if you are developing a package and you need to do a composer install inside the package folder (vendor/area17/twill-firewall for instance) to have all dependencies plus PHPUnit and PHPStan available for running package tests, Twill will be installed, because it's a dependency of the package, so when I run
vendor/bin/phpstan analyse -v

I get
Error thrown in
/Users/antonioribeiro/code/client/project/vendor/area17/twill-firewall/vendor/area17/twill/src/DuskServiceProvider.php
on line 17 while loading bootstrap file
/Users/antonioribeiro/code/client/project/vendor/area17/twill-firewall/vendor/nunomaduro/larastan/bootstrap.php:
Class "Laravel\Dusk\Browser" not found

Another solution would be to add Dusk to the package, but Dusk is not really a dependency of the package, and it's only a dependency for Twill 3.x, on Twill 2.x it works fine.

Hi @antonioribeiro, I ran into the same issue recently. I added Dusk as a dev dependency of my package as you said. I agree that the package doesn't really care if Twill is using Dusk in its own test suite. Could this be handled on Twill's side, by only registering DuskServiceProvider if class Laravel\Dusk\Browser exists?


Changed max concurrent imports and use .limits.xxx instead

Fixes #5117.
Reviewer for frontend: @viddo

Your turn @Kartones :)

:+1: although why prefix the names with get when the convention seems to be that we don't do that?

@juanignaciosl CR of the BE code please

LGTM :+1:

Much appreciated

@xavijam Please take a look at the mentined diff because removal of those lines weren't supposed to be there has broken the frontend tests :/
http://ci.cartodb.com/job/CartoDB-PR-testing/756/consoleText


Add new endpoint Unical

Hello, thank you for the work done on this subject. It's really great!
I have just had a Schuster brand stove installed.
And after some research around the management card I arrived here.
I was able to sniff a little what the application https://play.google.com/store/apps/details?id=com.micronovasrl.ninaunical&hl=fr
go out to the Internet and I have determined that the endpoint is https://unical.agua-iot.com/ and Brand code is 289982
Could you add it ?
Thanks to you


Update recipe to use the latest version.

I'm copying the relevant sections from the anaconda build source, which already builds the latest version. Hopefully the CI will all work.

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

Failed to even lint the recipe, probably because of a conda-smithy bug :cry:. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

This recipe is not expected to build until https://github.com/conda-forge/gstreamer-feedstock/pull/11 is merged because it requires it due to the pinning.

This was "folded" in gstreamer. Closing this.


Revise exception handling in the chain follower to be more resilient

The main idea is simply restart the block restoration, so we get to resync from a known state, as if the
wallet was restarted. If this doesn't work, nothing will.
Issue Number

#1468
Overview

d6615e9013e213ce7c74034d058c109337c66238
:round_pushpin: revise exception handling in the chain follower to be more resilient
The main idea is simply restart the block restoration, so we get to resync from a known state, as if the wallet was restarted. If this doesn't work, nothing will.

c6bae5acf19877542e8d3e3f0be673fe33411292
:round_pushpin: distinguish handlers between wallet workers and node tip workers
We let wallet workers die so that they can restart and re-set a new intersection. This is not needed for the node tip worker which can simply keep on retrying (this worker only look for intersection with the genesis point anyway).

5d71c302d103d990ae1a116fca47dd5c8c3cc0d4
:round_pushpin: remove now network layer test now obsolete
The follow loop doesn't automatically retry on exception anymore but leave that decision to the caller. So, there's no need to test that it doesn't retry too often anymore.

Comments

Here's what changes in this PR:

If we encounter an exception, instead of restarting the chain follower where it was at (which was a faulty state anyway...), we exit it with a special exit value, then it's up to caller to decide what to do.

On fatal exception or interruption, we let the worker exits and die, as before.

On exception however, we'll now restart the entire restore loop; which starts by fetching the latest checkpoints and therefore, can re-init a cursor with the node's network layer and, continue the following where it stopped. This is pretty much equivalent to restarting the server, but on a per-wallet basis.

Here are a few scenarios I tested manually with this, turning the node's off and on:

Only node's tip worker
[cardano-wallet.network:Warning:11] [2020-03-26 10:04:12.26 UTC] Connection lost with the node.
[cardano-wallet.network:Notice:11] [2020-03-26 10:04:12.52 UTC] Couldn't connect to node (x2). Retrying in a bit...
[cardano-wallet.network:Warning:11] [2020-03-26 10:04:12.77 UTC] Couldn't connect to node (x3). Retrying in a bit...
[cardano-wallet.network:Warning:11] [2020-03-26 10:04:13.27 UTC] Couldn't connect to node (x4). Retrying in a bit...
[cardano-wallet.network:Warning:11] [2020-03-26 10:04:14.02 UTC] Couldn't connect to node (x5). Retrying in a bit...
[cardano-wallet.network:Warning:11] [2020-03-26 10:04:15.27 UTC] Couldn't connect to node (x6). Retrying in a bit...
[cardano-wallet.network:Info:11] [2020-03-26 10:04:15.27 UTC] Mux ConnectionId {localAddress = LocalAddress {getFilePath = ""}, remoteAddress = LocalAddress {getFilePath = "state-node-mainnet/node.socket"}} Send MsgProposeVersions (fromList [(NodeToClientV_1,TInt 764824073)])
[cardano-wallet.network:Info:11] [2020-03-26 10:04:15.27 UTC] Mux ConnectionId {localAddress = LocalAddress {getFilePath = ""}, remoteAddress = LocalAddress {getFilePath = "state-node-mainnet/node.socket"}} Recv MsgAcceptVersion NodeToClientV_1 (TInt 764824073)

With a wallet, interruption shorter than message timeout
[cardano-wallet.wallet-engine:Info:40] [2020-03-26 10:05:09.52 UTC] adc78398: Applying blocks [0.14999 ... 0.15998]
[cardano-wallet.wallet-engine:Info:40] [2020-03-26 10:05:09.53 UTC] adc78398: Creating checkpoint at c287feed-[0.15998#15999]
[cardano-wallet.wallet-engine:Info:40] [2020-03-26 10:05:09.53 UTC] adc78398: MyWallet, created at 2020-03-26 10:05:07 UTC, delegating to ∅
[cardano-wallet.wallet-engine:Info:40] [2020-03-26 10:05:09.53 UTC] adc78398: syncProgress: still restoring (0.40%)
[cardano-wallet.wallet-engine:Info:40] [2020-03-26 10:05:09.53 UTC] adc78398: discovered 0 new transaction(s)
[cardano-wallet.wallet-engine:Info:40] [2020-03-26 10:05:09.53 UTC] adc78398: local tip: c287feed-[0.15998#15999]
[cardano-wallet.network:Warning:11] [2020-03-26 10:05:10.55 UTC] Connection lost with the node.
[cardano-wallet.wallet-engine:Error:40] [2020-03-26 10:05:10.55 UTC] adc78398: Recoverable error following the chain: ExceptionInLinkedThread ThreadId 41 (MuxError {errorType = MuxBearerClosed, errorMsg = "<socket: 16> closed when reading data, waiting on next header True", errorStack = []})
[cardano-wallet.network:Info:40] [2020-03-26 10:05:10.55 UTC] Looking for an intersection with the node's local chain with: 89d9b5a5-[0.0#0], c287feed-[0.15998#15999]
[cardano-wallet.network:Info:144] [2020-03-26 10:05:13.56 UTC] Mux ConnectionId {localAddress = LocalAddress {getFilePath = ""}, remoteAddress = LocalAddress {getFilePath = "state-node-mainnet/node.socket"}} Send MsgProposeVersions (fromList [(NodeToClientV_1,TInt 764824073)])
[cardano-wallet.network:Info:144] [2020-03-26 10:05:13.56 UTC] Mux ConnectionId {localAddress = LocalAddress {getFilePath = ""}, remoteAddress = LocalAddress {getFilePath = "state-node-mainnet/node.socket"}} Recv MsgAcceptVersion NodeToClientV_1 (TInt 764824073)
[cardano-wallet.network:Info:40] [2020-03-26 10:05:13.60 UTC] Intersection found: c287feed
[cardano-wallet.wallet-engine:Info:40] [2020-03-26 10:05:13.70 UTC] adc78398: Applying blocks [0.15999 ... 0.16998]
[cardano-wallet.wallet-engine:Info:40] [2020-03-26 10:05:13.71 UTC] adc78398: Creating checkpoint at abb4798e-[0.16998#16999]
[cardano-wallet.wallet-engine:Info:40] [2020-03-26 10:05:13.71 UTC] adc78398: MyWallet, created at 2020-03-26 10:05:07 UTC, delegating to ∅
[cardano-wallet.wallet-engine:Info:40] [2020-03-26 10:05:13.71 UTC] adc78398: syncProgress: still restoring (0.43%)
[cardano-wallet.wallet-engine:Info:40] [2020-03-26 10:05:13.71 UTC] adc78398: discovered 0 new transaction(s)
[cardano-wallet.wallet-engine:Info:40] [2020-03-26 10:05:13.71 UTC] adc78398: local tip: abb4798e-[0.16998#16999]

With a wallet, interruption longer than message timeout
[cardano-wallet.wallet-engine:Info:32] [2020-03-26 10:06:48.25 UTC] adc78398: Applying blocks [0.13999 ... 0.14998]
[cardano-wallet.wallet-engine:Info:32] [2020-03-26 10:06:48.26 UTC] adc78398: Creating checkpoint at 97576228-[0.14998#14999]
[cardano-wallet.wallet-engine:Info:32] [2020-03-26 10:06:48.26 UTC] adc78398: MyWallet, created at 2020-03-26 10:06:46 UTC, delegating to ∅
[cardano-wallet.wallet-engine:Info:32] [2020-03-26 10:06:48.26 UTC] adc78398: syncProgress: still restoring (0.38%)
[cardano-wallet.wallet-engine:Info:32] [2020-03-26 10:06:48.26 UTC] adc78398: discovered 0 new transaction(s)
[cardano-wallet.wallet-engine:Info:32] [2020-03-26 10:06:48.26 UTC] adc78398: local tip: 97576228-[0.14998#14999]
[cardano-wallet.network:Warning:33] [2020-03-26 10:06:49.28 UTC] Connection lost with the node.
[cardano-wallet.wallet-engine:Error:32] [2020-03-26 10:06:49.28 UTC] adc78398: Recoverable error following the chain: ExceptionInLinkedThread ThreadId 33 (MuxError {errorType = MuxBearerClosed, errorMsg = "<socket: 17> closed when reading data, waiting on next header True", errorStack = []})
[cardano-wallet.network:Info:32] [2020-03-26 10:06:49.28 UTC] Looking for an intersection with the node's local chain with: 89d9b5a5-[0.0#0], 97576228-[0.14998#14999]
[cardano-wallet.network:Notice:131] [2020-03-26 10:06:49.54 UTC] Couldn't connect to node (x2). Retrying in a bit...
[cardano-wallet.network:Warning:11] [2020-03-26 10:06:49.78 UTC] Couldn't connect to node (x3). Retrying in a bit...
[cardano-wallet.network:Warning:11] [2020-03-26 10:06:50.29 UTC] Couldn't connect to node (x4). Retrying in a bit...
[cardano-wallet.network:Warning:11] [2020-03-26 10:06:51.04 UTC] Couldn't connect to node (x5). Retrying in a bit...
[cardano-wallet.network:Warning:11] [2020-03-26 10:06:52.29 UTC] Couldn't connect to node (x6). Retrying in a bit...
[cardano-wallet.network:Warning:131] [2020-03-26 10:06:54.29 UTC] Couldn't connect to node (x7). Retrying in a bit...
[cardano-wallet.network:Warning:131] [2020-03-26 10:06:56.29 UTC] Couldn't connect to node (x8). Retrying in a bit...
[cardano-wallet.network:Warning:11] [2020-03-26 10:06:58.29 UTC] Couldn't connect to node (x9). Retrying in a bit...
[cardano-wallet.network:Warning:32] [2020-03-26 10:06:59.29 UTC] Couldn't find an intersection in a timely manner. Retrying...
[cardano-wallet.network:Warning:131] [2020-03-26 10:07:00.30 UTC] Couldn't connect to node (x10). Retrying in a bit...
[cardano-wallet.network:Warning:131] [2020-03-26 10:07:02.30 UTC] Couldn't connect to node (x11). Retrying in a bit...
[cardano-wallet.network:Warning:11] [2020-03-26 10:07:04.30 UTC] Couldn't connect to node (x12). Retrying in a bit...
[cardano-wallet.network:Info:11] [2020-03-26 10:07:04.30 UTC] Mux ConnectionId {localAddress = LocalAddress {getFilePath = ""}, remoteAddress = LocalAddress {getFilePath = "state-node-mainnet/node.socket"}} Send MsgProposeVersions (fromList [(NodeToClientV_1,TInt 764824073)])
[cardano-wallet.network:Info:11] [2020-03-26 10:07:04.30 UTC] Mux ConnectionId {localAddress = LocalAddress {getFilePath = ""}, remoteAddress = LocalAddress {getFilePath = "state-node-mainnet/node.socket"}} Recv MsgAcceptVersion NodeToClientV_1 (TInt 764824073)
[cardano-wallet.network:Info:32] [2020-03-26 10:07:04.36 UTC] Intersection found: 97576228
[cardano-wallet.wallet-engine:Info:32] [2020-03-26 10:07:04.48 UTC] adc78398: Applying blocks [0.14999 ... 0.15998]
[cardano-wallet.wallet-engine:Info:32] [2020-03-26 10:07:04.49 UTC] adc78398: Creating checkpoint at c287feed-[0.15998#15999]
[cardano-wallet.wallet-engine:Info:32] [2020-03-26 10:07:04.49 UTC] adc78398: MyWallet, created at 2020-03-26 10:06:46 UTC, delegating to ∅
[cardano-wallet.wallet-engine:Info:32] [2020-03-26 10:07:04.49 UTC] adc78398: syncProgress: still restoring (0.40%)
[cardano-wallet.wallet-engine:Info:32] [2020-03-26 10:07:04.49 UTC] adc78398: discovered 0 new transaction(s)
[cardano-wallet.wallet-engine:Info:32] [2020-03-26 10:07:04.49 UTC] adc78398: local tip: c287feed-[0.15998#15999]

bors try

bors r+


Add one minute Debt

I have a suggest about add one minute Debt, because a lot of rules are a one minute fix.

We might need to perform a general swipe of all rules to see if they are also 1 min debt. I often laughed at myself why autoCorrectible detekt violations would take >2hours of my time to fix.

We might need to perform a general swipe of all rules to see if they are also 1 min debt. I often laughed at myself why autoCorrectible detekt violations would take >2hours of my time to fix.

You right. Maybe we need to add flag to Debt, like a canBeFixByAutoCorrect ?

You right. Maybe we need to add flag to Debt, like a canBeFixByAutoCorrect ?

Sadly none of our detekt native rules are autoCorrectible. Only those imported from ktlint are.
We have #2560 to track the progress on implementing an autoCorrectible rule, so let's not divert this PR too much.

Sadly none of our detekt native rules are autoCorrectible. Only those imported from ktlint are.
We have #2560 to track the progress on implementing an autoCorrectible rule, so let's not divert this PR too much.

I think that there is not issue that can be fixed in 1 minute:

Check the report
Create branch
Fix issue
Create PR

The problem is that you can fix 60 issues in 5 minutes. Because you need nerly the same time to fix one unused import that to fix 60. I don't think that any of the standard rules should use 1 minute.

I think that there is not issue that can be fixed in 1 minute:

Check the report
Create branch
Fix issue
Create PR

The problem is that you can fix 60 issues in 5 minutes. Because you need nerly the same time to fix one unused import that to fix 60. I don't think that any of the standard rules should use 1 minute.

I usually fix a detekt issues in feature branch

I usually fix a detekt issues in feature branch

I usually fix a detekt issues in feature branch

I usually fix a detekt issues in feature branch

Would it work for you if you could change the time in the yaml configuration?

Would it work for you if you could change the time in the yaml configuration?

Good point. Do detekt has with feature, or we need to implement this?

Good point. Do detekt has with feature, or we need to implement this?

That feature is not implemented. But before implementing it, could you open an issue explaining your use case and why you need this feature?
This feature would add complexity to the project and I'm not sure how much value it could bring. This way other people can say it's point of view.

That feature is not implemented. But before implementing it, could you open an issue explaining your use case and why you need this feature?
This feature would add complexity to the project and I'm not sure how much value it could bring. This way other people can say it's point of view.

I think that there is not issue that can be fixed in 1 minute:

Check the report
Create branch
Fix issue
Create PR

The problem is that you can fix 60 issues in 5 minutes. Because you need nerly the same time to fix one unused import that to fix 60. I don't think that any of the standard rules should use 1 minute.

This statement makes sense. I would still like to point out that using the sum of debt of each individual finding is confusing. When we publish a PR, we fix multiple violations altogether, where each finding would take maybe 1 minute. The overhead time of creating a review may take up to 5 minutes. A more reasonable approach is to calculate the overhead (5 minutes) + the time to fix individual finding (1 minute / each), so that the total debt time is not way off the actual time spent on fixing those issues.

I think that there is not issue that can be fixed in 1 minute:

Check the report
Create branch
Fix issue
Create PR

The problem is that you can fix 60 issues in 5 minutes. Because you need nerly the same time to fix one unused import that to fix 60. I don't think that any of the standard rules should use 1 minute.

This statement makes sense. I would still like to point out that using the sum of debt of each individual finding is confusing. When we publish a PR, we fix multiple violations altogether, where each finding would take maybe 1 minute. The overhead time of creating a review may take up to 5 minutes. A more reasonable approach is to calculate the overhead (5 minutes) + the time to fix individual finding (1 minute / each), so that the total debt time is not way off the actual time spent on fixing those issues.

We need to take some decission here. I think that this conversation is interesting and we could rethink this feature a bit. I personally use it as a metric to see how my project is going so a more realistic value would be great.
What do you think about closing this and moving it to a conversation/issue? So we can find a formula that everyone (or most of us) agree with and then implement it. We can create another issue to track the feature to cusomize the time for issue if you consider it worth it.

We need to take some decission here. I think that this conversation is interesting and we could rethink this feature a bit. I personally use it as a metric to see how my project is going so a more realistic value would be great.
What do you think about closing this and moving it to a conversation/issue? So we can find a formula that everyone (or most of us) agree with and then implement it. We can create another issue to track the feature to cusomize the time for issue if you consider it worth it.

Closing this. If a custom rule write wants it's rules to have 1 minute debt there's nothing in our API stopping them.
If someone have some ideas about how to improve the calculations related with the debt time that detekt provides, please open a discussion so we can talk about it. I do think that we need to improve that but, right now, I have no idea how.


VS code is not letting me close files or application

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:
OS Version:

Steps to Reproduce:

https://github.com/microsoft/vscode/issues/170334


Command: open_dir

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/1197079-command-open_dir?utm_campaign=plugin&utm_content=tracker%2F282001&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F282001&utm_medium=issues&utm_source=github).

As implementing this command depends on sidebar IMO we should remove it from v0.1

Sidebar is very important, but I agree that it's not v0.1

Migrated to limetext/lime-backend#17.


More things

https://github.com/Goooler/jmh-gradle-plugin/actions/runs/4183987196/jobs/7249052279
* What went wrong:
Could not determine the dependencies of task ':compileGroovy'.
> Failed to calculate the value of task ':compileJava' property 'javaCompiler'.
   > No matching toolchains found for requested specification: {languageVersion=8, vendor=any, implementation=vendor-specific}.
      > No locally installed toolchains match (see https://docs.gradle.org/8.0/userguide/toolchains.html#sec:auto_detection) and toolchain download repositories have not been configured (see https://docs.gradle.org/8.0/userguide/toolchains.html#sub:download_repositories).

Will use Zulu vendor in next PR.

Toolchain is not workable on Gradle 7.0
successfully executes benchmark which uses feature previews (Gradle 7.0)

org.gradle.testkit.runner.UnexpectedBuildFailure: Unexpected build execution failure in /var/folders/rv/5_x4931102b6vkrwzmdt6jww0000gn/T/spock_successfully_execut_0_temporaryFolder4008796733525132852 with arguments [--stacktrace, --configuration-cache, jmh]

Output:
Configuration cache is an incubating feature.
Calculating task graph as no configuration cache is available for tasks: jmh

FAILURE: Build failed with an exception.

* What went wrong:
Could not determine the dependencies of task ':jmh'.
> Could not resolve all dependencies for configuration ':jmhRuntimeClasspath'.
   > Failed to calculate the value of task ':compileJava' property 'javaCompiler'.
      > No compatible toolchains found for request filter: {languageVersion=15, vendor=AZUL, implementation=vendor-specific} (auto-detect true, auto-download true)


[Issue-2447] Update chainlist

Related issue(s)
#2447
Is your feature request related to a problem(s)? Please describe.

Update new logic for earning

Describe the solution you'd like

Temporarily blocking ARCH token transfer.
Check VARCH balances, cDOT-7/14 balances.
Check parallel provider (Dwellir).

Describe alternatives you've considered

No

Additional context

No

🚀 Deployed on https://pr-2448--sw-web-runner.netlify.app


[T4A6][T14-B1] Tan Min Rong Samson

Ready for review.

@samsontmr
Some comments added. Please ack & close the PR after reading comments.

Acknowledged


Feat/1206047356262531 rename pallet

Rename the pallet name.
Please review it after https://github.com/peaqnetwork/peaq-network-node/pull/162

To see the specific tasks where the Asana app for GitHub is being used, see below:

https://app.asana.com/0/0/1206047356262531

Discard the https://github.com/peaqnetwork/peaq-network-node/pull/162 and merge it into the dev branch


extension testing with default settings

I want to launch extension tests with the default, empty settings, instead of using my own user settings.
We have the following launch.json setting, not much different from what's in the testing-extension doc except a couple of additional flags.
		{
			"name": "Launch Extension Tests",
			"type": "extensionHost",
			"request": "launch",
			"runtimeExecutable": "${execPath}",
			"args": [
				"--disable-extensions",
				"--extensionDevelopmentPath=${workspaceFolder}",
				"--extensionTestsPath=${workspaceFolder}/out/test/integration/index",
				"--user-data-dir", "/tmp/empty",
				"--timeout",
				"999999"
			],
			"stopOnEntry": false,
			"sourceMaps": true,
			"outFiles": [
				"${workspaceFolder}/out/test/**/*.js"
			],
			"preLaunchTask": "npm: watch"
		},

I hoped this --user-data-dir flag could help us starting with empty user settings.
I think it worked a couple of months ago but today I found it doesn't work as I remembered.
Maybe it's a recent regression, or it never worked and I was confused.
I checked the extension development host launched with this launch button, and verified it's still accessing my user profile and settings.
Interestingly, if I pass /dev/null to --user-data-dir (as used in chrome projects to create a clean testing environment), the extension development host is stuck in a blank window.
Back to my original question: Is there a way to launch extension tests in a clean environment?

VS Code version: Code - Insiders 1.46.0-insider<PHONE_NUMBER>496504e0677ffcf2a46d47ad9130f5, 2020-05-15T09:06:06.454Z)
OS version: Darwin x64 18.7.0

Does this issue occur when all extensions are disabled?: Yes

/duplicate #44734

We found https://github.com/microsoft/vscode/issues/7243#issuecomment-264620751 and supplying "--user-data-dir= "/tmp/empty" instead of "--user-data-dir", "/tmp/empty" (note: =) made it work as intended.


Latest update breaks due to proxy requirement.

Issue Type: Bug
Attempting to build my dev container behind a proxy failed with the latest update to 1.64.
This appears to be agnostic to the container used to build and is a widespread issue across the team.
1.63 worked appropriately.
I've attached the output log.
Process \\.\pipe\vscode-remote-containers-486230f95e3035407c1dcb9437ffb49cad7b9219-sock singleContainer Debug c:\Users\xj4s\AppData\Roaming\Code\logs\20220204T090011\exthost4\ms-vscode-remote.remote-containers<PHONE_NUMBER>516
[39117 ms] Start: Run in container: test -d /root/.vscode-server
[39120 ms]
[39120 ms]
[39120 ms] Start: Run in container: test -f /var/vscode-server/.patchEtcEnvironmentMarker
[39122 ms]
[39122 ms]
[39123 ms] Start: Run in container: test -f /var/vscode-server/.patchEtcProfileMarker
[39125 ms]
[39125 ms]
[39125 ms] Start: Run in container: test ! -f '/root/.vscode-server/data/Machine/.writeMachineSettingsMarker' && set -o noclobber && mkdir -p '/root/.vscode-server/data/Machine' && { > '/root/.vscode-server/data/Machine/.writeMachineSettingsMarker' ; } 2> /dev/null
[39128 ms]
[39128 ms]
[39128 ms] Exit code 1
[39129 ms] Start: Run in container: cat /root/.vscode-server/data/Machine/settings.json
[39132 ms] {
 "python.defaultInterpreterPath": "/usr/local/bin/python",
 "python.linting.enabled": true,
 "python.linting.pylintEnabled": true,
 "python.formatting.blackPath": "/projects/rmenv/black-check",
 "python.linting.banditPath": "/projects/rmenv/bandit/bin/bandit",
 "python.linting.flake8Path": "/projects/rmenv/flake8/bin/flake8",
 "python.linting.mypyPath": "/projects/rmenv/mypy/bin/mypy"
}
[39133 ms]
[39133 ms] Start: Run in container: test -d /root/.vscode-server/bin/5554b12acf27056905806867f251c859323ff7e9
[39135 ms]
[39135 ms]
[39135 ms] Exit code 1
[39135 ms] Start: Run in container: test -d /vscode/vscode-server/bin/linux-x64/5554b12acf27056905806867f251c859323ff7e9
[39138 ms]
[39138 ms]
[39138 ms] Exit code 1
[39138 ms] Installing VS Code Server for commit 5554b12acf27056905806867f251c859323ff7e9
[39141 ms] Start: Downloading VS Code Server
[39141 ms] 5554b12acf27056905806867f251c859323ff7e9 linux-x64 stable
[39341 ms] Error: read ECONNRESET
 at TLSWrap.onStreamRead (internal/stream_base_commons.js:209:20)
[39341 ms] Exit code ECONNRESET

VS Code version: Code 1.64.0 (5554b12acf27056905806867f251c859323ff7e9, 2022-02-03T04:22:20.678Z)
OS version: Windows_NT x64 10.0.19042
Restricted Mode: No
Connection to 'dev-container+7b22686f737450617468223a22633a5c5c55736572735c5c786a34735c5c446f63756d656e74735c5c726574656e74696f6e2d6d6f64656c696e672d656e7669726f6e6d656e74222c2273657474696e6773223a7b22636f6e74657874223a226465736b746f702d6c696e7578227d7d' could not be established

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-9850H CPU @ 2.60GHz (12 x 2592)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
31.81GB (1.05GB free)

Process Argv
--crash-reporter-id 99a7683f-cc03-4ee1-96ef-8d18a759dc41

Screen Reader
no

VM
0%

Connection to 'dev-container+7b22686f737450617468223a22633a5c5c55736572735c5c786a34735c5c446f63756d656e74735c5c726574656e74696f6e2d6d6f64656c696e672d656e7669726f6e6d656e74222c2273657474696e6773223a7b22636f6e74657874223a226465736b746f702d6c696e7578227d7d' could not be established
Extensions (33)

Extension
Author (truncated)
Version

terraform
4op
0.2.2

sas-syntax
77q
1.0.8

better-comments
aar
2.1.0

git-temporal-vscode
bee
1.0.0

vscode-coverage-highlighter
bra
1.0.3

better-toml
bun
0.3.2

gitlens
eam
11.7.0

gitlab-workflow
Git
3.40.2

vscode-test-explorer
hbe
2.21.1

r
Iku
2.3.6

mysql-syntax
jak
1.3.1

vscode-python-test-adapter
lit
0.7.0

vscode-docker
ms-
1.19.0

data-workspace-vscode
ms-
0.1.1

mssql
ms-
1.12.0

sql-database-projects-vscode
ms-
0.14.1

anaconda-extension-pack
ms-
1.0.1

python
ms-
2022.0.1786462952

vscode-pylance
ms-
2022.2.0

jupyter
ms-
2022.1.1001775990

jupyter-keymap
ms-
1.0.0

jupyter-renderers
ms-
1.0.6

remote-containers
ms-
0.217.1

remote-ssh
ms-
0.70.0

remote-ssh-edit
ms-
0.70.0

powershell
ms-
2021.12.0

test-adapter-converter
ms-
0.1.5

vsliveshare
ms-
1.0.5330

vscode-data-preview
Ran
2.3.0

vscode-commons
red
0.0.6

vscode-yaml
red
1.4.0

pdf
tom
1.2.0

vscodeintellicode
Vis
1.2.16

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyl392:30425749
pythontb:30283811
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
pythondataviewer:30285071
vscod805cf:30301675
pythonvspyt200:30340761
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
vsc1dst:30433059
pythonvs932:30410667
wslgetstartedc:30426334
vs360cf:30404996
vsrem710cf:30416617

I can confirm that the proxy setting is not used in the 1.64 version, had to downgrade to 1.63 and disable updates.

Just had a filesave fail where Prettier had crashed. Restarted VSCode and could see a new version being installed via Windows Terminal. Now Code won't load at all - 90% of my client projects are in Docker.

Any chance we can release this ASAP? @aeschli
This breaks VS Code for a multitude of developers working behind corporate proxies

Yes, a fix will be in 1.64.2 coming out in a few days: https://github.com/microsoft/vscode/pull/142441

Those affected using Remote-Containers could give the latest pre-release of Remote-Containers (0.219.0) a try. That falls back to downloading the server via Electron which is not affected by this bug. (Coincidental timing with this issue.)
Switch to the pre-release version if you haven't:

Also fixed by @aeschli in today's Insiders build (just verified): https://code.visualstudio.com/insiders/

I confirm it works. Thanks @chrmarti and @aeschli

The backport to 1.64 is #142441

Verified in the 1.64.2 candidate build (f80445ac).


add support for upsert with partial columns

At present, upsert support only works when all non-null columns are present in the data.
E.g. if I have a table with id=primary key, col1 = non-null, col2 = null, col3 = column_to_replace
If i try to do an upsert with df = pd.DataFrame(id=[1], col3=["replace_value"])
The internally generated update stmt will look smth like this:
INSERT INTO TABLE
(id, col3) values
(1, 'replace_value')
ON CONFLICT (id) DO UPDATE SET col3 = excluded.col3

However, this would result in an error SINCE: col1 is non-null, but because col1 does not exist within (id, col3), internally postgres interprets this as a missing value, and thus tries to write:
(1, null, null, 'replace_value'), which triggers an error since col1 cannot be null
The solution is to alter the query so that we are doing this:
INSERT INTO TABLE
(id, col3, col1) values
(1, 'replace_value', DEFAULT_COL1_VALUE)
ON CONFLICT (id) DO UPDATE SET col3 = excluded.col3, col1 = TABLE.col1

This way, the default DEFAULT_COL1_VALUE will not trigger the non-null constraint, and since we are writing col1 = TABLE.col1, we aren't actually re-writing the value! If there is no default for  col1, then we can create a default based on it's TYPE.
Note: this is a hacky solution. It will work. The benefit is that it decreaes read/write size for replace queries. Not sure of downsdies? Perhaps hidden risks? E.g. compatibility with other DBs, choice of default value, etx..

Inspired by this: https://stackoverflow.com/questions/60641000/postgresql-on-conflict-update-only-if-new-value-has-been-provided


Recreated navbar and footer

Recreated the navbar , footer, made them responsive and did all the necessary changes in all the pages like dashboard and about page

@srivastavaritik
now you can merge it ...
Thank you

What happened?
@srivastavaritik
Why you revert the PR #34

@AKD-01
@srivastavaritik
What is the issue? Why my PR #33  is reverted back?


I am not able to install sharp library in aws ec2 arm64

I am following documentation https://sharp.pixelplumbing.com/install and not able to install sharp library in aws ec2 arm64. I  have tried multiple commands like npm install --unsafe-perm --platform=linux --arch=arm64  sharp but getting same error every time:
sharp: Installation error: Use with glibc 2.26 requires manual installation of libvips >= 8.11.3
npm ERR! code ELIFECYCLE npm ERR! errno 1 npm ERR<EMAIL_ADDRESS>install: (node install/libvips && node install/dll-copy && prebuild-install) || (node install/can-compile && node-gyp rebuild && node install/dll-copy) npm ERR! Exit status 1 npm ERR!  npm ERR! Failed at the<EMAIL_ADDRESS>install script. npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
Instance: Linux aarch64 GNU/Linux

Please see #2837 and https://github.com/lovell/sharp/issues/2875#issuecomment-940227974

Tracking at https://github.com/lovell/sharp/issues/2938


Are interrupt executors currently broken on STM32H7?

I started a new project from the current Embassy version (pulled yesterday) and have since been having quite a bit of trouble with the interrupt executors.
When porting some code, I noticed that my interrupt executors were no longer working correctly.
I made a minimalistic example for my use case and tested it for a bit.
It seems that the example works fine on my old embassy version, but adjusted for the syntax change (probably because of the embedded-hal v1.0 release?) doesn't work for the current version anymore.
The code compiles and flashes fine, but has no or sometimes undeterministic output.
Unfortunately, I'm not able to specify what the exact version my old copy is, but I was previously working with the following dependencies:
[dependencies]
embassy-stm32 = { version = "0.1.0", path = "../../embassy-stm32", features = ["defmt", "stm32h743bi", "time-driver-any", "exti", "memory-x", "unstable-pac", "chrono"] }
embassy-sync = { version = "0.5.0", path = "../../embassy-sync", features = ["defmt"] }
embassy-executor = { version = "0.4.0", path = "../../embassy-executor", features = ["nightly", "arch-cortex-m", "executor-thread", "executor-interrupt", "defmt", "integrated-timers"] }
embassy-time = { version = "0.2", path = "../../embassy-time", features = ["defmt", "defmt-timestamp-uptime", "tick-hz-32_768"] }
embassy-net = { version = "0.2.0", path = "../../embassy-net", features = ["defmt", "tcp", "dhcpv4", "medium-ethernet", "proto-ipv6", "dns"] }
embassy-usb = { version = "0.1.0", path = "../../embassy-usb", features = ["defmt"] }

I am now working with:
[dependencies]
embassy-stm32 = { version = "0.1.0", path = "../../embassy-stm32", features = ["defmt", "stm32h743bi", "time-driver-any", "exti", "memory-x", "unstable-pac", "chrono"] }
embassy-sync = { version = "0.5.0", path = "../../embassy-sync", features = ["defmt"] }
embassy-executor = { version = "0.5.0", path = "../../embassy-executor", features = ["nightly", "task-arena-size-32768", "arch-cortex-m", "executor-interrupt", "executor-thread", "defmt", "integrated-timers"] }
embassy-time = { version = "0.3.0", path = "../../embassy-time", features = ["defmt", "defmt-timestamp-uptime", "tick-hz-32_768"] }
embassy-net = { version = "0.4.0", path = "../../embassy-net", features = ["defmt", "tcp", "dhcpv4", "medium-ethernet", "proto-ipv6", "dns"] }
embassy-usb = { version = "0.1.0", path = "../../embassy-usb", features = ["defmt"] }

Here's the test example I am using:
![no_std]
#![no_main]
#![feature(type_alias_impl_trait)]

use cortex_m_rt::entry;
use defmt::*;
use embassy_executor::{Executor, InterruptExecutor};
use embassy_stm32::exti::ExtiInput;
use embassy_stm32::gpio::{AnyPin, Level, Input, Output, Pull, Speed};
use embassy_stm32::interrupt;
use embassy_stm32::interrupt::{InterruptExt, Priority};
use embassy_sync::blocking_mutex::raw::CriticalSectionRawMutex;
use embassy_sync::mutex::Mutex;
use embassy_time::Timer;
use static_cell::StaticCell;
use {defmt_rtt as _, panic_probe as _};

// Here mutexes are used for performance difference measurement
// Mutex does not serve any purpose in this example
// A ThreadModeRawMutex is used as this is an interrupt executor
type LedType = Mutex<CriticalSectionRawMutex, Option<Output<'static>>>;

// Initialize static variables
static LED_RED: LedType = Mutex::new(None);
static EXECUTOR_HIGH: InterruptExecutor = InterruptExecutor::new();
static EXECUTOR_LOW: StaticCell<Executor> = StaticCell::new();

// Enable interrupt executor
#[interrupt]
unsafe fn UART4() {
    EXECUTOR_HIGH.on_interrupt()
}

#[entry]
fn main() -> ! {
    // Acquire peripherals
    let p = embassy_stm32::init(Default::default());

    let led_green = Output::new(AnyPin::from(p.PB0), Level::Low, Speed::Low);
    let led_red = Output::new(AnyPin::from(p.PB14), Level::Low, Speed::Low);

    // Map exti on button
    let button = ExtiInput::new(p.PC13, p.EXTI1, Pull::Down);

    // The try_lock method is used because the lock method is an async method and main entry isn't async
    {
        *(LED_RED.try_lock().unwrap()) = Some(led_external);
    }

    // Spawn interrupt executor for HIGH priority task
    interrupt::UART4.set_priority(Priority::P6);
    let spawner = EXECUTOR_HIGH.start(interrupt::UART4);
    unwrap!(spawner.spawn(interruption(&LED_RED, button)));

    // Spawn normal executor
    let executor = EXECUTOR_LOW.init(Executor::new());
    executor.run(|spawner| {
        unwrap!(spawner.spawn(blinky(led_green)));
    });
}

#[embassy_executor::task]
async fn blinky(mut led_green: Output<'static>) {
    loop {
        led_green.toggle();
        Timer::after_millis(200).await;
    }
}

// Deferred interrupt task with mutex
#[embassy_executor::task]
async fn interruption(led_red: &'static LedType, mut button: ExtiInput<'static>) {
    loop {
        button.wait_for_rising_edge().await;

        // future returns MutexGuard
        let mut led_red_unlocked = led_red.lock().await;

        if let Some(pin_ref) = led_red_unlocked.as_mut() {
            pin_ref.toggle();
        }
    }
}

Is anyone able to tell me what I am doing wrong, if I somehow messed up some embassy dependency (though I didn't adjust much), or if this is indeed broken currently?

I am also trying to simply enable an interrupt routine to fire. Am I doing something wrong or is it broken?
`
#[embassy_executor::main]
async fn main(spawner: Spawner) {
let mut config = Config::default();
{
use embassy_stm32::rcc::*;
config.rcc.hse = Some(Hse {
freq: Hertz(8_000_000),
mode: HseMode::Oscillator,
});
config.rcc.pll_src = PllSource::HSE;
config.rcc.pll = Some(Pll {
prediv: PllPreDiv::DIV4,
mul: PllMul::MUL168,
divp: Some(PllPDiv::DIV2), // 8mhz / 4 * 180 / 2 = 180Mhz.
divq: Some(PllQDiv::DIV4),
divr: None,
});
config.rcc.ahb_pre = AHBPrescaler::DIV1;
config.rcc.apb1_pre = APBPrescaler::DIV4;
config.rcc.apb2_pre = APBPrescaler::DIV2;
config.rcc.sys = Sysclk::PLL1_P;
}
let p = embassy_stm32::init(config);
let mut timer = p.TIM6;
timer.set_frequency(Hertz(1));
timer.set_autoreload_preload(true);
timer.enable_update_interrupt(true);
timer.reset();
timer.start();

}
#[interrupt]
fn TIM6_DAC() {
println!("timer fired");
}
`


Adding leef to output_format validation

Pull request checklist
Please check if your PR fulfills the following requirements:

[X] New and existing tests pass locally with the changes.
[X] Code follows the style guidelines of this project (PEP8, clean code).
[X] Linter has passed locally and any fixes were made for failures.
[X] A self-review of the code has been done.

Pull request type
Please check the type of change your PR introduces:

[X] Bugfix

What is the ticket or issue number?

Ticket Number: N/A

Issue Number: #43

Pull Request Description
Included not condition for allow leef as a valid output_format
Does this introduce a breaking change?

[X] No

How Has This Been Tested?
Used leef as output_type in our configuration file, this change was necessary to pass the validation check

This will be fixed with our next release. Thanks for the PR


Various potential merges to cherry pick.

Exposed Occlusion details on the PlayEventAttached blueprint callable function.

Forgive me - I'm getting used to how Github does pull requests.
I've accidentally committed multiple changes here. The 2 I'm primary interested in committing are d5dd167 for changing access specifiers for ActorComponent interface, and potentially 54f48c9 if occlusion details for PlayEventAttached is desired.

The final 2 commits here allow for the editor viewport camera to act as the listener position during simulation (with only the active viewport setting the transform in the case that multiple viewports are open).

Hi,
Thank you for the suggestions, we really appreciate all the ideas! I will pass them on to our development team to look into further!


Multi-camera support for Windows

Hello,
API of InitParameters -- int camera_linux_id
"Currently not available for Windows"
For my application it would be really useful to use 2 or more ZED cameras under Windows. Most VR and AR devices are Windows-only, which means I need a Ubuntu machine to record my videos and a Windows machine for the display, which introduces delay. I implore you to give us an update - is there still hope or did you abandon this feature completely?
Your mixed reality usefulness may be enhanced with more cameras.

Hi,
We didn't abandon this feature.
However, it requires quite a lot of work. Basically, we need to change the way we communicate with the camera on Windows, which isn't as easy as on Linux. Unfortunately, it is not our current priority.
I can keep you informed if it's scheduled for a ZED SDK release, but it might be in several months.

Hi adujardin,
thank your for your reply! Please keep me posted when it is scheduled!

@philomathikus Yes actually!
The multi-camera support for Windows will be included in the new version of the ZED SDK (2.4.0) alongside a new firmware (v1523) for the camera.
You could expect a beta soon.

hi @adujardin, thanks for the quick reply!
We are trying to use the Zed Camera for a MR application in a UWP build but we are getting the following error only when we try to run the app after installation:
Exception thrown: 'System.DllNotFoundException' in Assembly-CSharp.dll'ZedTest.exe' (CoreCLR: CoreCLR_UWP_Domain): Loaded 'C:\Zed UWP\ZedTest\bin\x64\Release\AppX\System.Diagnostics.StackTrace.dll'. Cannot find or open the PDB file.DllNotFoundException: Unable to load DLL 'sl_unitywrapper': The specified module could not be found. (Exception from HRESULT: 0x8007007E)at sl.ZEDCamera.dllz_register_callback_debuger(DebugCallback callback)at sl.ZEDCamera.GetInstance()at ZEDManager.Awake()at ZEDManager.$Invoke7(Int64 instance, Int64* args)at UnityEngine.Internal.$MethodUtility.InvokeMethod(Int64 instance, Int64* args, IntPtr method)(Filename:  Line: 0)
so everything works fine in editor.

@adujardin Great news!!

Hi,
@philomathikus :
The ZED unity wrapper (sl_unitywrapper.dll)  links with sl_zed64.dll, sl_input64,.dll sl_core64.dll and sl_mr_core64.dll. Make sure that those dlls are in the system path or in the same folder as sl_unitywrapper.dll.
When you  build an app on Unity, sl_unitywrapper.dll and sl_mr_core64.dll are copied in the <*>_data folder.

Hi,
If you want to try the multi-camera on Windows, you can download an RC version of the ZED SDK 2.4.0 available at http://download.stereolabs.com/zedsdk/2.4/RC
Please keep in mind that it's still an RC version and therefore may contain bugs. Feel free to contact us if you find something at<EMAIL_ADDRESS>


Argentina has dates in 2018 + Oct 2019

First few dates in the epidemiology.csv are
2018-11-21,AR,0,0,,0,0,0,,0
2018-11-21,AR_B,0,0,,0,0,0,,0
2018-11-21,AR_B_490,0,0,,0,0,0,,0
2019-10-25,AR,0,0,,0,0,0,,0
2019-10-25,AR_B,0,0,,0,0,0,,0
2019-10-25,AR_B_412,0,0,,0,0,0,,0
2019-12-19,AR,0,0,,0,0,0,,0
2019-12-19,AR_C,0,0,,0,0,0,,0

Is this still an issue? I was looking for any dates prior to 2020 and I could not find any.

Still in epidemiology.csv downloaded from https://storage.googleapis.com/covid19-open-data/v2/epidemiology.csv


feat: add cdk-erigon sequencer

Description
Integrate cdk-erigon as a sequencer within the Kurtosis CDK package. It is now possible to switch between zkevm-node and cdk-erigon sequencers.
I began the implementation but encountered some bugs because cdk-erigon was not ready... @cffls completed the remaining work (thanks a lot 🙏)!
Follow-up work:

Add some documentation.
Refactor the sequencer types.
Refactor the cdk-erigon lib.

References (if applicable)

https://polygon.atlassian.net/browse/DVT-1404

Would be great if we can have this as an option, so we can test both in parallel and compare, at least during some period of time.

@vcastellm Updated the branch with latest commits. The sequencer could be configured with sequencer_type parameter.

This rule is super annoying lol... I'll rebase the PR or create a new one..

This rule is super annoying lol... I'll rebase the PR or create a new one..

That's my bad.. I forgot to setup commit signing on this host. Let me see if I can resign the commits and force push it.

Closing this PR as #155


Add channel arg to enable/disable http proxy

Add channel arg to enable/disable http proxy.
Feature request from #11751
Currently, the recommended approach to disable proxy is to set the no_proxy environment variable. This environment variable is not suitable to be used with IP ranges, so this channel arg will allow disabling the use of http_proxy in grpc.
Given that we are adding an argument to disable http proxy, it might also make sense in the future to provide an argument that explicitly provides the http proxy to use. Currently, we just use the 'http_proxy' environment variable.

****************************************************************

libgrpc.so

     VM SIZE                                                         FILE SIZE
 ++++++++++++++ GROWING                                           ++++++++++++++
  +0.0%    +128 [None]                                            +1.32Ki  +0.0%
  +5.6%     +96 src/core/ext/filters/client_channel/http_proxy.cc     +96  +5.6%
      +3.6%     +59 proxy_mapper_map_name                                 +59  +3.6%
      [NEW]     +33 http_proxy_enabled                                    +33  [NEW]
      +9.5%      +4 [Unmapped]                                             +4  +9.5%

  +0.0%    +224 TOTAL                                             +1.41Ki  +0.0%

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

@AspirinSJL can you do the primary reviewing please?

LGTM.
But could you explain a bit more about how this channel arg is better than the old environment variable way? Like, how the arg is suitable to be used with IP ranges?

Updated the PR comment.
This arg does not have a value of any name/domain/address. It just disables proxy use for this channel. (Since, a channel would have a single name, it won't make much sense to accept a list of names to blacklist for proxy usage.)

Known Issues : #15610
Thanks for reviewing!


JSON Echo Grain

A test case for grains that use JSON JObject parameters for input / output.

Replaced by https://github.com/dotnet/orleans/pull/1426


removed unused profiles and sync

Automation for azure-sdk-for-ruby

Automation for azure-sdk-for-python

Automation for azure-sdk-for-go

Automation for azure-sdk-for-java

Automation for azure-sdk-for-js

Can one of the admins verify this patch?

@Yungezz
WHY WAS THIS MERGED?!

Please don't mess with the multiapi branch. -- we're using this for development.

@fearthecowboy sorry, my bad. I thought it was swagger review PR. Will exclude the multiapi branch from review.


how to use the  Method Dump() for the custom class

I am new in using CommandLine Parser.
From "getting started page" I have tried to run a program.
But Dump is not working for my class.

Thanks in advance.

You can use  Nuget package ObjectDumper.NET
Dump is used  for demonstration , but you can modify code  to  process/show the values of options.

Can I get any Video tutorial link.

There  is no Video tutorial available.
I hope that wiki with getting start can help.
It include Real life demos that you can practice usage of the library.

I find it quite confusing too.
It's in the examples and it works on dotnetfiddle, but when you try it locally it doesn't work.

@WimLeflere
I have dropped Dump (built-in method in dotnetfiddle.net) and  modified code to use Console.WriteLine

Seems like the issue maybe should be reopened as the still are some places where Dumb is used both in the wiki and on dotnetfiddle.net examples:

wiki - How To
wiki - Mutually Exclusive Options - 'Try This' links to dotnetfiddle.net

https://dotnetfiddle.net/GeXOFY
https://dotnetfiddle.net/uUIfCb

See also issue #837


Should we build a multiarch image even if only single arch specified?

Noticed today, when building an image with an apko yaml like the following:
contents:
...
archs:
- x86_64

This produces an image with a manifest like the following (OCI manifest vs index):
{
  "schemaVersion": 2,
  "mediaType": "application/vnd.oci.image.manifest.v1+json",
  "config": {
    "mediaType": "application/vnd.oci.image.config.v1+json",
    "size": 638,
    "digest": "sha256:c7c03659476d9ee86732d2208bd9f63b180605a669ee2e29ec20114de99991cf"
  },
  "layers": [
    {
      "mediaType": "application/vnd.oci.image.layer.v1.tar+gzip",
      "size": 22637079,
      "digest": "sha256:ce8bd478163413656b09bad0e3d8cd583a02c4c9be6b7cef3a09d1d83ef9cb5a"
    }
  ]
}

Perhaps this changed recently, but thought that the image is always produced multiarch?
cc @imjasonh @kaniini

We did used to @imjasonh back when apko build didn't support building for more than one arch, but apko publish did. We rationalized it a while back.
To answer your question @jdolitsky , we could go either way. I think I still prefer the multi-arch, because then we are consistent. apko build always will produce the same structure, and always will have the same format output as apko publish.
Is there a scenario where this breaks something?

no i dont think so, I vote multiarch always


[th/dnsmasq-fix] dns: ensure libvirt's dnsmasq does not forward to the local dnsmasq

We now run a local dnsmasq instance, which can resolve DNS names of the cluster.
Note that libvirt's network also runs a dnsmasq instance, which by default reads /etc/resolv.conf to get upstream nameservers.
If you previously already deployed a cluster, then /etc/resolv.conf contains "nameserver <IP_ADDRESS>". If libvirt's dnsmasq takes that as upstream, queries to the network may end up in a loop and we see
  dnsmasq[430088]: Maximum number of concurrent DNS queries reached (max: 150)

Instead, use the original "/etc/resolv.conf.cda-orig" file, which contains the original upstream DNS servers.
https://libvirt.org/formatnetwork.html#network-namespaces
Fixes: 784959b95564 ('clusterDeployer: configure dnsmasq instance for cluster DNS')

lgtm


Small code readability suggestion

(Chapter 7, Linear algebra)
It's a really nitpicky and arbitrary suggestion since it only comes down to style. But, I personally think that it might improve readability (just a tiny bit) if the order of the type parameters of the Vector type were flipped.
Current code:
newtype Vector s g = V (g -> s) deriving ...

Suggested change:
newtype Vector g s = V (g -> s) deriving ...

This would put them in the same order as the underlying (g -> s) type and as a bonus be a bit similar to how vector types are commonly named in other languages/libraries. Vector2, Vector3, etc...

Hi Eli,
I might be wrong, of course, but I'm not sure that current choice is
just a matter of style.
If the first argument to |Vector| is |s|, then we can argue that, if |s|
is a field, then |Vector s| is a (finite) functor and a (finite) monad:

class FinFunc f where
func    ::  (Finite g, Finite g') => (g -> g') -> f g -> f g'

class FinMon f where
embed   ::  Finite g => g -> f g
bind    ::  Finite g => f g -> (g -> f g') -> f g'

instance Field s => FinFunc (Vector s) where
func   =  funcFinFunc

instance Field s => FinMon  (Vector s) where
embed  =  embedFinM
bind   =  bindFinM

funcFinFunc :: (Field s, Finite g, Finite g') => (g -> g') -> Vector s g -> Vector s g'
funcFinFunc = mulMV . invImage

embedFinM :: (Eq g, Ring s) => g -> Vector s g
embedFinM = e

bindFinM :: (Field s, Finite g) => Vector s g -> (g -> Vector s g') -> Vector s g'
bindFinM v m  = mulMV (transpose m) v

invImage :: (Field s, Eq g') => (g -> g') -> g' -> Vector s g
invImage f = \ g' -> V (is g' . f)

Thus, we can interpret linear transformations as monadic operations.
The problem with swapping arguments is that linear transformations are
not generic transformations between vector spaces but transformations
between vector spaces on the same field. Their type is
Vector s g -> Vector s g'
The functor here is |Vector s| and the correspondent |map| takes indeed
as argument polymorphic functions |a -> b|, apart from the finiteness
constraint.
If we swap the arguments of |Vector|, we cannot any longer express the
functoriality of |Vector g| in terms of linear transformations.
Anyway, just my two cents, I'm not an expert on either linear algebra or
type theory.
But I think that you have raised an interesting question that we should
try to fully understand!
Ciao,
Nicola
Eli Adelhult @.***> wrote:

(Chapter 7, Linear algebra)
It's a really nitpicky and arbitrary suggestion since it only comes
down to style. But, I personally think that it might improve
readability (just a tiny bit) if the order of the type parameters of
the Vector type were flipped.
Current code:
newtype Vector s g = V (g -> s) deriving ...
Suggested change:
newtype Vector g s = V (g -> s) deriving ...
This would put them in the same order as the underlying (g -> s) type
and as a bonus be a bit similar to how vector types are commonly named
in other languages/libraries. Vector2, Vector3, etc...
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.Message ID: @.**>

I see, seems like a super reasonable explanation, thank you for clarifying @nicolabotta!
I’ve never implemented a monad/functor instance by myself, so I’ve not really considered the importance of the order of the parameters in the type constructor when doing things like m a before. But this really helped me understand, so thanks!


Update CLI guide content

Replacing #927

@yknl is this ready to be merged?

Yes, not sure why the vercel deployment failed though.

@aulneau could you take a look. it shows this as an error:
TypeError: Cannot set property 'customBlocks' of undefined


ArrayList \ Repeat

repeat :: a -> Int -> [a]
Repeat the given item n times

Renaming this to replicate

Changing type signature to Int -> a -> [a]


Gradient Animation

In composition can I animate the Color values of two GradientStops inside a LinearGradientBrush that is used as the background of a Grid?

Unfortunately, Composition can only animate properties of Composition visuals. GradientStops inside a LinearGradientBrush are not supported.

@lukeja as a workaround you could use Win2d to pull that off. Or maybe use colored lights / shadows / hue rotation effects to achieve a similar effect.

You can also accomplish this using a Storyboard with EnableDependentAnimation="True". The animation will run on the UI thread, but it's easy to set up and will have similar performance to something you could put together with Win2D.
XAML
<Rectangle Width="300" Height="200">
    <Rectangle.Resources>
        <Storyboard x:Name="AnimateGradientStoryboard">
            <ColorAnimation
            To="CadetBlue"
            Duration="0:0:2"
            EnableDependentAnimation="True"
            Storyboard.TargetName="GradientStop1"
            Storyboard.TargetProperty="Color" />
        </Storyboard>
    </Rectangle.Resources>
    <Rectangle.Fill>
        <LinearGradientBrush>
            <GradientStop x:Name="GradientStop1" Color="CornflowerBlue" />
            <GradientStop Offset="1" Color="OrangeRed" />
        </LinearGradientBrush>
    </Rectangle.Fill>
</Rectangle>

C#
AnimateGradientStoryboard.Begin();

Closing now. Please let us know if these solutions do not work for you.

Yes we can make our custom library for controls like if this were Monogame world and forget XAML. I do not understand why the solution is always workarounds using Win2D, Surfaces and HtmlView.
So what's the purpose of Composition then. Why Win2D is so open an Composition so locked, will be in the future all solved or what is the roadmap.
I think questions like shown are pretty basic and telling answers like EnableDependentAnimation is a bit inconsiderate to our effort to make things right.
Hope you understand our position, I am just serious no rude, we know it takes a great effort to make your work, but it is a really hidden work,


feat: Make getPlayheadTimeAsDate and getPresentationStartTimeAsDate available for VOD

Closes https://github.com/shaka-project/shaka-player/issues/2959

Test stream: https://storage.googleapis.com/livestream-demo-output/ccl-webvtt-test/manifest-ts.m3u8


Establish Quality Bar for DPG/RLC libraries for all languages

Issue
We would like to clarify the point at which architects can approve a DPG/RLC client library for GA.
Current Status
We currently agree that:

[x] Python will approve MVP libraries for GA.  @lmazuel, @iscai-msft, could you confirm in the comments below?
[x] JS/TS will approve MVP libraries for GA. @joheredi, @xirzec, could you confirm in the comments below?
[ ] Java will approve MVP libraries for GA.  @srnagar, @JonathanGiles, could you confirm in the comments below?
[ ] .NET architects will determine in the introductory arch board meeting how many convenience APIs are needed for the library to GA.  They will review the library API once the requested convenience APIs have been implemented, and if the architects don't believe customers can be successful with the library, they will push out the GA date to accommodate adding further convenience. @KrzysztofCwalina, @tg-msft, could you confirm in the comments below?

Exit Criteria
We will close this issue once we have sign-off on the approval criteria for each language.

I believe we are at a point where we would be comfortable GA'ing a RLC for a service that has had at least one successful beta release. I think the only issue we wanted to mitigate in the generator was around how we handle paths that contain a version number. I'll let @joheredi have the final word though. :)

I think the only issue we wanted to mitigate in the generator was around how we handle paths that contain a version number.

@xirzec, do you know if you were planning to mitigate this in the generator (before GA of the RLC generator), or as a manual step for any library that encountered it, so it's not needed for your generator GA?

/ cc @qiaozha to get the updates of this.

Yeah, the paths thing is not a GA blocker for the generator. It would be a GA blocker for a library with a version in the paths, the fix for those to unblock GA is to convert the path-based API version to change the swagger to represent it as a parametrized host.
As Jeff mentioned, we are comfortable GA'ing RLC codegen

Sounds good, @joheredi! Can you also confirm that your plan is to GA generated libraries without any conveniences? (I think RLC doesn't have a convenience layer, so this may be an entirely moot point, just wanting to confirm.)

The main conveniences we've been seeing value in are optional helper methods exported by the package. On a case-by-case basis we may include additional such helpers in an RLC

Thanks, @xirzec?  For the purposes of this issue, would you block GA of a library based on the need for these helpers?

I don't think we would block release on helpers, new helpers would be additive and for convenience. An out of the box RLC should be able to perform all service operations

We are confident to GA Python DPG codegen as MVP (cc @johanste )

For most libraries, Java DPG MVP codegen should suffice, but similar to .NET, we'd like to review that in the introductory arch board meeting and determine if there are no additional convenience APIs needed.
For e.g. if the champion scenario requires a different type of credential or the user needs to make multiple REST API calls to perform one logical operation, we should consider adding convenience APIs to support these scenarios for GA.

In an offline discussion with @KrzysztofCwalina, @lmazuel, @tg-msft, @Petermarcu, @mikekistler, @markweitzel and myself, we agreed that this is too nuanced to close prior to DPG v1.0 GA, but that we will not block DPG v1.0 on this decision.  As such, I am removing the blocking-release and DPG/RLC v1.0 labels, and reassigning to @markweitzel, who will work with all of us to find a solution here.