feat: avoid lock around CLN RPC client in cln-extension

Ports fixes introduced by #1577 to ln-gateway, over to gateway-cln-extension

Codecov Report
Base: 65.42% // Head: 65.46% // Increases project coverage by +0.03% :tada:

Coverage data is based on head (98d7677) compared to base (53e274f).
Patch coverage: 0.00% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1676      +/-   ##
==========================================
+ Coverage   65.42%   65.46%   +0.03%
==========================================
  Files         129      129
  Lines       23429    23435       +6
==========================================
+ Hits        15328    15341      +13
+ Misses       8101     8094       -7

Impacted Files
Coverage Δ

gateway/ln-gateway/src/bin/cln_extension.rs
0.35% <0.00%> (-0.01%)
:arrow_down:

crypto/tbs/src/serde_impl/mod.rs
75.00% <0.00%> (-4.17%)
:arrow_down:

gateway/ln-gateway/src/rpc/rpc_server.rs
54.83% <0.00%> (-1.62%)
:arrow_down:

modules/fedimint-ln/src/lib.rs
73.62% <0.00%> (+0.13%)
:arrow_up:

fedimint-server/src/consensus/mod.rs
83.63% <0.00%> (+0.16%)
:arrow_up:

crypto/tbs/src/poly.rs
24.43% <0.00%> (+0.20%)
:arrow_up:

fedimint-server/src/lib.rs
77.29% <0.00%> (+0.27%)
:arrow_up:

fedimint-server/src/net/peers.rs
90.71% <0.00%> (+0.29%)
:arrow_up:

fedimint-core/src/api.rs
81.41% <0.00%> (+0.60%)
:arrow_up:

fedimint-core/src/core.rs
92.59% <0.00%> (+1.15%)
:arrow_up:

... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Exception in debug mode (ios-no-type-b branch)

Hi @CodeMinion,
When printing from IOS, the library throws an exception (after successfully printing) at line 1730 in the file printer_info.dart.

This exception occurs when calling the Printer.printText() function.
I think these are the logs that are related to it (but i could be mistaken).
[connection] nw_endpoint_handler_set_adaptive_write_handler [C2 <IP_ADDRESS>:443 ready channel-flow (satisfied (Path is satisfied), viable, interface: en0, ipv4, dns)] unregister notification for write_timeout failed
[connection] nw_endpoint_handler_set_keepalive_handler [C2 <IP_ADDRESS>:443 ready channel-flow (satisfied (Path is satisfied), viable, interface: en0, ipv4, dns)] unregister notification for keepalive failed
[] nw_protocol_instance_access_flow_state [C1.1.1:2] Failed to find flow 107b0bae8
[] nw_protocol_instance_access_flow_state [C1.1.1:2] Failed to find flow 107a09918
[connection] nw_endpoint_handler_set_adaptive_read_handler [C1.1.1 <IP_ADDRESS>:443 ready channel-flow (satisfied (Path is satisfied), viable, interface: en0, ipv4, dns)] unregister notification for read_timeout failed
[connection] nw_endpoint_handler_set_adaptive_write_handler [C1.1.1 <IP_ADDRESS>:443 ready channel-flow (satisfied (Path is satisfied), viable, interface: en0, ipv4, dns)] unregister notification for write_timeout failed
[connection] nw_endpoint_handler_set_keepalive_handler [C1.1.1 <IP_ADDRESS>:443 ready channel-flow (satisfied (Path is satisfied), viable, interface: en0, ipv4, dns)] unregister notification for keepalive failed
[] nw_protocol_instance_access_flow_state [C1.1.1:2] Failed to find flow 107b0bae8
flutter: Device print: {modelName: Brother QL-820NWB, serNo: XXXXXXXXX, ipAddress: <IP_ADDRESS>, macAddress:XX:XX:XX:XX:XX:XX, nodeName: XXXXXXXXXXXXXXX, location: }
flutter: Print Result: true
flutter: Connected to printer? true
[connection] nw_endpoint_handler_set_adaptive_read_handler [C3 <IP_ADDRESS>:9100 ready socket-flow (satisfied (Path is satisfied), viable, interface: en0, ipv4, dns)] unregister notification for read_timeout failed
[connection] nw_endpoint_handler_set_adaptive_write_handler [C3 <IP_ADDRESS>:9100 ready socket-flow (satisfied (Path is satisfied), viable, interface: en0, ipv4, dns)] unregister notification for write_timeout failed
flutter: Print Result: {labelType: -1, maxOfBatteryResidualQuantityLevel: -1, labelId: -1, isACConnected: {id: -1, name: Unknown}, batteryResidualQuantityLevel: -1, isBatteryMounted: {id: -1}, batteryLevel: -1, errorCode: {name: ERROR_NONE, id: -1}}

This is the code i use to call your library:
const LabelIndex_DK44205_62mm = 15;

Future<void> printLabelAPI(NetPrinter device) async {
  // If the device is the empty device return;
  if (device.ipAddress.isEmpty) {
    return;
  }

  final printer = Printer();
  var _printerInfo = setupPrinter(device);
  await printer.setPrinterInfo(_printerInfo);

  // Android trick method
  // _printerInfo.labelNameIndex = await getLabelNameIndex(printer);
  // await printer.setPrinterInfo(_printerInfo);
  await connectPrinterAndPrint(printer);
}

Future<void> connectPrinterAndPrint(Printer printer) async {
  // This is used for testing the printer.
  TextStyle style =
      TextStyle(color: Colors.black, fontSize: 30, fontWeight: FontWeight.bold);
  ParagraphBuilder paragraphBuilder = ParagraphBuilder(ParagraphStyle(
    fontSize: style.fontSize,
    fontFamily: style.fontFamily,
    fontStyle: style.fontStyle,
    fontWeight: style.fontWeight,
    textAlign: TextAlign.center,
    maxLines: 10,
  ))
    ..pushStyle(style.getTextStyle())
    ..addText("Test 123 Test 123");

  var paragraph = paragraphBuilder.build()
    ..layout(ParagraphConstraints(width: 300));

  bool success = await printer.startCommunication();
  print("Connected to printer? $success");

  var res = await printer.printText(paragraph);
  print("Result: ${res}");

  success = await printer.endCommunication();
}

PrinterInfo setupPrinter(NetPrinter device) {
  var _printInfo = PrinterInfo();

  _printInfo.port = Port.NET;
  _printInfo.ipAddress = device.ipAddress;

  print("Device print: $device");

  _printInfo.macAddress = device.macAddress;
  // Constant for now.
  _printInfo.printerModel = Model.QL_820NWB;
  _printInfo.printMode = PrintMode.FIT_TO_PAGE;
  _printInfo.isAutoCut = true;

  // Important to set this to 0 if using android trick.
  // Otherwise will not work.
  _printInfo.labelNameIndex = LabelIndex_DK44205_62mm;

  return _printInfo;
}

///
/// Currently only available for Android
/// For getting the label automaticaly.
///
Future<int> getLabelNameIndex(Printer printer) async {
  await printer.startCommunication();
  await printer.endCommunication();
  LabelInfo labelInfo = await printer.getLabelInfo();
  return labelInfo.labelNameIndex;
}

General Info:
using ios-no-type-b branch
Flutter v2.5.0
IOS: v14.7.1
Xcode: v12.5.1 (12E507)
Printer: QL-820NWB

via network
No battery attached
using label DK-44205 (continuous 62mm)

Hi @BentEngbers ,
Thank for the heads up and the detailed report! I'll take a look and have a fix out this weekend along with that other update.
Thanks again!

Hi @BentEngbers ,
Thanks again for the report. This has now been resolved on the on the latest commit of the branch as well as the official version.
Because you are using the branch make sure to use "Pub upgrade" to get the latest version of the branch.
I'll leave this issue open for your to confirm it's working fine.
Thanks again and don't hesitate to reach out if you run into any other issues.

Thanks for the quick fix! The issue has been resolved!


timeout vs failAfter

what's the difference between timeout and failAfter? Sorry I seem not to comprehend those two.
and what's the role of retryLimit with them?

@yamii -

timeout - how long rabbot will wait per connection attempt (milliseconds)
failAfter - how long rabbot will try across all connection attempts
retryLimit - how many consecutive failed attempts rabbot will try to make

Example

timeout: 2000 ms
failAfter: 30 s
retryLimit: 5

If the rabbit server was down, rabbot would try 5 times in a row, waiting 2 seconds each time before timing out. It would not matter that failAfter was set to 30 seconds because retryLimit will be reached first. This will cause rabbot to emit the unreachable event and stop attempting to connect. At this point, your service should call process.exit() with a non-zero number.


How to control the training order between disp_net and pose_net

Surprise to see the Implementation of UnDeepVO, I also do the implementation work recently. But I wonder how the training order between disp_net and pose_net? Because we use the depth_net to reconstruct the real depth ,then use the depth to estimate the pose between the adjacent frame. So I wonder maybe train the depth_net for several epoch(such 30 epoch),then training the pose_net for next epoch. I wonder in the early training, the depth net is not so dependable. Could you give me some advice for how to consider this?

@royal-feng Although I have not finished the implementation, it seems to me that Li et. al trains both the depth map net and pose net simultaneously.

By using these constraints to construct the loss function and minimizing them all together, the UnDeepVO learns to estimate scaled 6-DoF poses and depth maps in an end-to- end unsupervised manner.

pg. 2 , section II, last sentence.

As you mentioned, you could try to train the depth map net first until you have a decent level of convergence and then use it to compute the losses while training the pose net (since both temporal loss functions rely on depth). I am trying to replicate the paper directly as best possible, so I will try to train both nets simultaneously, perhaps using auxiliary lambda layers or custom loss functions.

Closed.


[DAO Settings] Image and logo is not updated immediately after approving corresponding proposal

Steps:

Go to DAO
Create proposal to change cover and logo
Navigate to proposal detailed screen
Approve the proposal

AR: Cover and logo changed, however they're not updated across the app immediately.
ER: After approving proposal UI should be updated with new cover and logo across the app

NOTE: It might appear that this is a common issue of AstrDAO UI: After confirmation of any action in NEAR wallet, when user redirected back to the app UI is not updated.

Verified on dev. Fixed


sat -dump_vcd, $end fix for $timescale.

Hi I tried to convert -dump_vcd generated VCD file with Modelsim's vcd2wlf.
To make it work, it needs $end for $timescale. I propose following fix to file sat.cc.
fprintf(f, "$timescale 1ns\n"); // arbitrary time scale since actual clock period is unknown/unimportant
—> fprintf(f, "$end\n");
fprintf(f, "$scope module %s $end\n", module->name.c_str());

Removed the timescale altogether (in commit 665eec3). Why set it to an arbitrary value if we can also just not set it at all.


Functions Sync Issue while upgrading to v5 and App services

Good afternoon, I also have the same problem and I have followed the steps as indicated and the same thing happens. Could you help me too, thank you (Error building configuration in an external startup class.)
image
Microsoft.Azure.WebJobs.Script: Error building configuration in an external startup class. Microsoft.Azure.WebJobs.Script: One or more loaded extensions do not meet the minimum requirements. For more information see https://aka.ms/func-min-extension-versions. ExtensionStartupType ServiceBusWebJobsStartup from assembly 'Microsoft.Azure.WebJobs.ServiceBus, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35' does not meet the required minimum version of <IP_ADDRESS>. Update your NuGet package reference for Microsoft.Azure.WebJobs.Extensions.ServiceBus to 4.2.1 or later. .
Tried to Sync the function apps, below is the error message.
Using Msbuild from 'C:\Program Files (x86)\MSBuild-16.4\MSBuild\Current\Bin'.
C:\home\site\repository\Source\CompanyCommunicator\Microsoft.Teams.Apps.CompanyCommunicator.csproj : error : Version 3.1.426 of the .NET Core SDK requires at least version 16.7.0 of MSBuild. The current available version of MSBuild is <IP_ADDRESS>107. Change the .NET Core SDK specified in global.json to an older version that requires the MSBuild version currently available.

Hi @bbarona
Thanks for reaching out to us.
Could you Please confirm us with the following.

Go to Azure Portal --> Go to Resource Group (where the CC deployment has been done) --> Select function App (App Service) --> Go to Deployment Center -> Share the Screenshot of this -> In the same tab Click on logs [send a screenshot of this].

And please share the screenshots of all three Function Apps and Deployment Center

Hi @bbarona
Could you please update us on the status of the issue?

Ofcourse,
App Service > Centro de implementación > Configuración

App Service > Centro de implementación > Registros

3 Function Apps

Function Apps > MTCCOM-data-function > Centro de implementación > Configuración

Function Apps > MTCCOM-function > Centro de implementación > Configuración

Function Apps > MTCCOM-prep-function > Centro de implementación > Configuración

Hi @bbarona
From the screenshot provided we see you are trying upgrade CC could you please follow migration guide

In a few minutes, I will conduct the session with the client to gather evidence of the process carried out

Evicencias de implementacion actualizacion company.pdf
The update process has been successfully completed. The parameters and settings have been verified again. Additionally, the synchronization of the functions in the App Services was successfully performed. However, upon executing the synchronization, we encountered the attached error.

Hi @bbarona
I would suggest please disconnect the repo From Deployment center of App service then wait for 20-30 mins All logs will get cleared. Once there is nothing in the logs Please select External Git -> Enter Repo Name and Branch name as 'main'. Click save and Sync it one more time.
Refer Troubleshooting guide Point #5

Hi @peddivyshnavi
we have already followed the process you recommended several times. This issue is becoming critical for my client. Could we possibly discuss this in a session? Please reach out to me at<EMAIL_ADDRESS>so we can schedule a meeting. Thank you.

Started discussing internally

We were trying to reproduce this issue from our end to troubleshoot so that we can fix this issue we will update with resolution you as soon as possible

Hi @bbarona
We tried reproducing issue with all possibilities from our end but we were unable to reproduce could you please go for redeployment of Company Communicator

@bbarona
Could you please update us on the status of the issue?

Good morning @peddivyshnavi , on Monday, September 23, we will implement the solution from scratch.

Thanks, @bbarona. Please inform us if you encounter any further issues.

Thanks, @bbarona. Could You Please create a new issue if you face any issues while deploying CC.


SUBMARINE-664. Update Submarine website according to Apache website guidelines

What is this PR for?
Add links that we are missing
The ASF has a set of guidelines for project websites. There's an automated tool that generates a report.
https://whimsy.apache.org/site/project/submarine
What type of PR is it?
[Documentation]
Todos
No
What is the Jira issue?

https://issues.apache.org/jira/browse/SUBMARINE-664
How should this be tested?

Screenshots (if appropriate)
Build the website locally
Questions:

Do the license files need updating? No
Are there breaking changes for older versions? No
Does this need new documentation? No

@cxorm Thanks for your review.


Error about maxInt in 'Web'

Error about maxInt in 'Web'
Error: The integer literal 0x7FFFFFFFFFFFFFFF can't be represented exactly in JavaScript.
Try changing the literal to something that can be represented in JavaScript.
In JavaScript 0x8000000000000000 is the nearest value that can be represented exactly.
  static const int maxInt = 0x7FFFFFFFFFFFFFFF;

Looks like resolved


Error when closure on nested expression

This code gives an error when trying to format with rustfmt:
fn main() {
    for _ in 0..100 {
        let prototype_id = PrototypeIdData::from_reader::<_, B>(&mut self.file_cursor).chain_err(|| {
                           format!("could not read prototype ID at offset {:#010x}",
                                   current_offset)
                       })?;
    }
}

The biggest problem is that even if I fix it by putting the .error_chain call in the next line, it moves it back to the position above and gives the error.
Rustfmt failed at /home/razican/workspace/super/dalvik/src/read.rs:203: line exceeded maximum length (maximum: 100, found: 105) (sorry)

This is fixed via #1438.
The problem is that rustfmt incorrectly takes .chain_err as ? at the end of the expression and hence thinks that it will fit into a single line.
However, since the actual width of each expression is 10 and 1 respectively, the line exceeds maximum length.

Closed by https://github.com/rust-lang-nursery/rustfmt/pull/1438


Sharing pose data via multimaster between three robots

I want to run AMCL package on three different robots(each robot has laptop with ros running on it) and share the pose data via multimaster_fkie. When we sync the three laptops, the bandwidth decreases significantly. Is there any solution for this ?

Hi,
you can add filter to exclude some topics from synchronization. E.g. /tf topic is a candidate. Add follow parameter to master_sync node:
 <rosparam param="ignore_topics">[/tf]</rosparam>
For more filter options see master_sync.launch

Great, thank you for your response! It worked :)


Add Classname to xUnit Result

Added scorecard classname to xunit results

I merged this because the sanity test is a url link fixed by another PR


Could not run the application on Ubuntu 14.04.3 LTS.

Did you run it on 64-bit or 32-bit Ubuntu, and which executable did you use?


[XR] add the option to fallback to WebXR events

This will ignore the advanced processing babylon does and will only use selectstart and selectend events, disregarding the type of target ray mode the controller has.

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Snapshot stored with reference name:
refs/pull/14808/merge
Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14808/merge/index.html
To test a playground add it to the URL, for example:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14808/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/14808/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/14808/merge
https://gui.babylonjs.com/?snapshot=refs/pull/14808/merge
https://nme.babylonjs.com/?snapshot=refs/pull/14808/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/14808/merge#BCU1XR#0

WebGL2 visualization test reporter:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14808/merge/testResults/webgl2playwright/index.html

Visualization tests for WebGPU (Experimental)
Important - these might fail sporadically. This is an optional test.
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14808/merge/testResults/webgpuplaywright/index.html

moved to draft to be sure this solves the issue with vision OS


[GHSA-gcqq-w6gr-h9j9] Directory traversal vulnerability in RubyZip

Updates

Affected products
Description

Comments
This gem now leaves input validation to the user as of the v1.2.2 modification.
Therefore, it is again vulnerable starting from v1.2.2.

@wonda-tea-coffee
Thanks for the link! Apologies for the confusion, but since you also closed the issue you linked to, I want to verify that I understand the situation. Does the closed issue you link mean that you no longer believe this is an issue, or are you saying that you believe the maintainers will not fix it? The original vulnerability issue indicates a fix commit, that has been tagged up through version 2.3.2. If that is not a sufficient fix, that should be communicated to the maintainers.

@ronwoch
I was aware that the maintainer was not going to fix the input value validation as the responsibility for input value validation is left to the user as per the comment below.
https://github.com/rubyzip/rubyzip/blob/v2.3.2/lib/zip/entry.rb#L174-L175
However, I will check with the maintainer to see if my interpretation is correct. Thank you very much.

@wonda-tea-coffee
Thanks for clarifying, and for reaching out to the maintainer. Please do update us with how it turns out, so we can proceed accordingly.


Fix/214- toast error

Describe the bug
After the feedback from the pilot users several issues regarding the toast messages not been seen correctly because of the font and background and some of the validations not be covered, it need to fix as soon as possible. Also, the google log in button should nt be shon please take it out as it is not going to be implement it.
Check also the validations that are commented in the document that need to be fixed
Expected behavior
The toast messages should be clear, easy to read and see thing not happening at the moment
Additional context
Please have a look to the document with the info regarding the pilot users for fixing it

Story Points: 5
See the discussion in Frontend S3 v2
Powered by Parabol


What is the difference with install nixpkgs.xxx and nixpkgs.haskellPackages.xxx

Hi! I am stumped with installing a few haskell packages
arost ~/Projects > nix-env -f "<nixpkgs>" -iA haskellPackages.hlint haskellPackages.cabal2nix
installing 'hlint-3.1.1'
installing 'cabal2nix-2.15.3'
building '/nix/store/l3zqxfn3l5pd8d9ffyc2x78018v9yvcb-user-environment.drv'...
error: packages '/nix/store/bgp49zlcahfx7ss1h64yfhyp52yzq8zj-hlint-3.1.1/lib/links/libgmpxx.4.dylib' and '/nix/store/8w66h699jzjwnmc88sl111fzf0rp1rda-cabal2nix-2.15.3/lib/links/libgmpxx.4.dylib' have the same priority 5; use 'nix-env --set-flag priority NUMBER INSTALLED_PKGNAME' to change the priority of one of the conflicting packages (0 being the highest priority)
builder for '/nix/store/l3zqxfn3l5pd8d9ffyc2x78018v9yvcb-user-environment.drv' failed with exit code 1
error: build of '/nix/store/l3zqxfn3l5pd8d9ffyc2x78018v9yvcb-user-environment.drv' failed
arost ~/Projects > nix-env -f "<nixpkgs>" -iA hlint cabal2nix
installing 'hlint-3.1.1'
installing 'cabal2nix-2.15.3'
building '/nix/store/bd0mpv69nz2yrj4ig29s736lm3rcanb1-user-environment.drv'...
created 164 symlinks in user environment

What is the difference between two install commands?

The clue is in pkgs/top-level/all-packages.nix:
hlint = haskell.lib.justStaticExecutables haskellPackages.hlint;

The haskellPackages.xxxx also have some (intermediate) build results, which are removed by haskell.lib.justStaticExecutables.

So the right way to install haskellPackages is use the one in nixpkgs? I am confused because "haskell.section.md" suggests to use the attribute path haskellPackages...

This looks to me like another bug introduced by https://github.com/NixOS/nixpkgs/pull/78738 (and partly fixed in #87881).
@Infinisil has described an approach that should fix this, https://github.com/NixOS/nixpkgs/pull/84985#pullrequestreview-405946347, although it hasn't been implemented yet.
Ping @peti and @roberth as well.

Here's the relevant bit from Infinisil:

I think a proper fix for this would be to only link libraries to $out/lib/links that have non-colliding names, while leaving the others in the dynamic-library-dirs of each individual package.

Making enableSeparateBinOutput the default would be great but is only a partial solution to these build errors (and it's a lot of work!). I don't think we need to explore that here, or justStaticExecutables for that matter.

Thanks for your responses. Now I understand more. I'll close the ticket.


js-soroban-client: Add support for Auth + single invoke host function

What ?
Add support for Auth + single invoke host function
Epic
https://github.com/stellar/soroban-tools/issues/657

Closed by #103.


Making the component body reactive

I'm only just exploring the framework, so bear with me here.
So in a component, outside of JSX expressions, you can't directly access reactive state, or it will no longer be reactive.
// Wrong!
function UserName(props) {
  const user = props.user;
  const fullName = `${user.firstName} ${user.lastName}`;
  return
{fullName}
;
}

// Right!
  const user = () => props.user;
  const fullName = () => `${user().firstName} ${user().lastName}`;

But in a component with a lot of intermediate calculations, that's a lot of noisy const foo = () => and foo() all over the place. I really find myself wishing that the entire component body was reactive, instead of just the JSX expression. You can already "fake it" today like this:

function UserName(props) {
  return () => {
    // Look ma, no thunks!
    const user = props.user;
    const fullName = `${user.firstName} ${user.lastName}`;
    return
{fullName}
;
  };
}

We used to use mobx-react at $dayjob and their @observer similarly encompasses the entire function body.

What if the babel plugin, instead of wrapping each JSX expression, wrapped the entire component body? This would make the cleaner-looking // Wrong! example above behave as expected. Having briefly thought about it, I don't think it would hurt performance, since you wouldn't be doing more wrapping or more work, you're just moving more statements inside the wrapper that already exists today. Perhaps it could even slightly improve performance since you'd have less intermediate thunks in typical userland code (so less allocation and indirection). And depending on how it interacts with esnext downleveling, maybe it could even let destructured props remain reactive.
Would there be any downsides to this that I haven't considered?

Yeah unfortunately this is something that I do not believe is avoidable. Forgive me if the answer seems like a bit of dump but this is something that has been very much on my mind since I first started this 5 years ago. I wanted everything to be easy. There is a reason why you haven't seen a React compiler approach with JSX. People say it's impossible. I don't think that's true but there is definitely reasons we haven't seen it and I solved the problem in a very different way.
There is a huge performance consideration here when you don't use a Virtual DOM for anything non-trivial. In your example what you wrote roughly compiles like this:
function UserName(props) {
  return () => {
    // Look ma, no thunks!
    const user = props.user;
    const fullName = `${user.firstName} ${user.lastName}`;
    return
{fullName}
;
  };
}
// becomes
function UserName(props) {
  return () => {
    // Look ma, no thunks!
    const user = props.user;
    const fullName = `${user.firstName} ${user.lastName}`;

    // create a new div element every time I execute
    const div = document.createElement("div")
    div.textContent = fullName;
    return div;
  };
}

If you assume that function that you return is a createEffect that replaces the previous value with the current you are pretty much there. So in this scenario you are creating a new div every time and replacing it rather than just updating the text. If your returned template has child components or anything else it does you'd pretty much be re-recreating the whole tree downwards from that point.v So the only reason wrapping everything like the example works with control flow is it either does its own memorization in the component or it guards against unnecessary changes. But wrapping full components would recreate everything on any change.
In fact is more or less how React works. Even with React.memo (or MobX) skipping parts of the tree it still all runs top-down. But since it renders a cheap virtual DOM and diffs it this cost is mitigated. Without a Virtual DOM you don't have this luxury. Sure you could do similar memorization but it still this top-down diffing process. You need to know what was at the position on the previous render.
Now there are ways around this if you make the Components a thing. Ie from a compilation standpoint for that scope you split initialization and update paths. This is what Svelte does. But requires you calling components out from a compiler standpoint. Most commonly this is done with single-file components. Notice how they always split the code from the template in those. It has a second purpose of isolating the view part of the codes to handle it under a different context. Something as fluid as JSX could be problematic and is largely why Svelte says it won't support JSX etc. Vue does the same split too. Now you could handle this with something like Vue's config objects and setup functions but that has it's own fun (see things like toRefs).
I hope that makes sense. Shoot over any more questions you have. People often have this thought at first which means I might not be doing the best to explain it. There also are big performance gain potential in removing heavier components from the equation. Part of the reason Solid regularly outperforms Svelte in benchmarks. But I understand performance isn't everything. But it was the unique direction I wanted to explore but like anything it isn't without tradeoffs.

Thanks for the brain dump. You're right about my code—in the devtools I can see the div being recreated each change. So I guess those thunks (including the one the compiler inserts around JSX) are the "units of reactivity" and should actually be kept as granular as possible to minimize DOM operations.
Clearly you've put a lot more thought into this than I have!

Thanks for bringing this up. It's a pretty common thought. Destructuring not working is really annoying from a convenience standpoint. Nothing is without tradeoffs. At least this is mostly syntaxual.


[SPARK-8072] [SQL] Better AnalysisException for writing DataFrame with identically named columns

Instead of adding rule to CheckAnalysis.scala, add the rule as a check in DataFrameWriter.scala.
Tests also included in DataFrameSuite.scala.

cc @rxin @marmbrus

NAVER - http://www.naver.com/
<EMAIL_ADDRESS>님께 보내신 메일 <[spark] [SPARK-8072] [SQL] Better AnalysisException for writing DataFrame with identically named columns (#7013)> 이 다음과 같은 이유로 전송 실패했습니다.

받는 사람이 회원님의 메일을 수신차단 하였습니다.

Can one of the admins verify this patch?

NAVER - http://www.naver.com/
<EMAIL_ADDRESS>님께 보내신 메일 <Re: [spark] [SPARK-8072] [SQL] Better AnalysisException for writing DataFrame with identically named columns (#7013)> 이 다음과 같은 이유로 전송 실패했습니다.

받는 사람이 회원님의 메일을 수신차단 하였습니다.

ok to test

Merged build triggered.

Merged build started.

LGTM

Test build #35826 has started for   PR 7013 at commit 7c3d928.

Test build #35826 has finished for   PR 7013 at commit 7c3d928.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

After talking more off-line with @rxin I think we want to make this check specific to parquet.  For other data sources (like CSV) its actually not a problem to have duplicate column names.

cc @rxin  @marmbrus
Can you review this?

Merged build triggered.

Merged build started.

Test build #36131 has started for   PR 7013 at commit 98b4399.

Test build #36131 has finished for   PR 7013 at commit 98b4399.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #36136 has started for   PR 7013 at commit 3cc4d2c.

Test build #36136 has finished for   PR 7013 at commit 3cc4d2c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

@animeshbaranawal Do any other data sources also have this problem? I'm thinking of Orc and JSON, will JSON overwrite duplicated column silently?

Yes. I tried with JSON and it overwrites the data. Michael Armbrust also said that he want the rule for parquet only.

Let me clarify:  I want the error on a per datasource basis, contingent upon whether it makes sense given the limitations of the format.

@marmbrus Didn't get you? Am I missing something?

We should also do it for JSON.

And we should throw the error inside of parquet if possible.  That way we don't have tons of special case code inside of the generic data source handler.

Ideally, this would serve as an example so that other data source implementors could throw errors when people try to write out invalid data (i.e. consider a datasource that only allows alpha numeric characters in its column names).

Got it ! What about jdbc ?

Merged build triggered.

Merged build started.

Test build #36257 has started for   PR 7013 at commit a8a964f.

Test build #36257 has finished for   PR 7013 at commit a8a964f.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #36263 has started for   PR 7013 at commit fd45e1b.

Test build #36263 has finished for   PR 7013 at commit fd45e1b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Build triggered.

Build started.

Test build #36345 has started for   PR 7013 at commit f70dd0e.

Test build #36345 has finished for   PR 7013 at commit f70dd0e.

This patch passes all tests.
This patch does not merge cleanly.
This patch adds no public classes.

Build finished. Test PASSed.

Why is it not merging cleanly?

[marmbrus@Michaels-MacBook-Pro-2 spark ((14e4bf8...))]$ git checkout pr/7013
Previous HEAD position was 14e4bf8... Use CanBroadcast in broadcast outer join planning
Branch pr/7013 set up to track remote branch pr/7013 from origin.
Switched to a new branch 'pr/7013'

[marmbrus@Michaels-MacBook-Pro-2 spark (pr/7013)]$ git merge origin/master
Auto-merging sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveUDFSuite.scala
Removing sql/hive/src/test/resources/golden/Date comparison test 2-0-dc1b267f1d79d49e6675afe4fd2a34a5
Removing sql/hive/src/test/resources/golden/Date cast-0-a7cd69b80c77a771a2c955db666be53d
Auto-merging sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUDFs.scala
Auto-merging sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
CONFLICT (content): Merge conflict in sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
Auto-merging sql/core/src/main/scala/org/apache/spark/sql/parquet/newParquet.scala
Auto-merging sql/core/src/main/scala/org/apache/spark/sql/execution/pythonUDFs.scala
Auto-merging sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
Removing sql/catalyst/src/main/java/org/apache/spark/sql/BaseRow.java
Removing sql/catalyst/src/main/java/org/apache/spark/sql/BaseMutableRow.java
Automatic merge failed; fix conflicts and then commit the result.

Someone else has added tests to DataFrameSuite.

Fixed the conflict manually.  Merged to master.  Thanks!

@animeshbaranawal I think you want to add the email address you used in your commit to your github profile, so the commit will show up properly as yours.

added !


World Alias' Prefix

My world alias' prefix is not working anymore. Ever since I updated to 1.1-R1 (now 1.1-R3) the world alias' prefix stopped working. That's pretty much the only thing that's not working on this plugin. I waited this long to report because it's a minor issue and thought it would be fixed with a new Multiverse-Core update but after updating to your 2.3 version, it still hasn't fixed the problem.
Details:

CraftBukkit 1.1-R3
PEX 1.17 + ChatManager
Only Mutiverse-Core 2.3 installed
Multiverse-Core/config.yml - prefixchat: 'true'
No errors on startup/shutdown or in the Multiverse-Core/debug.log
/mv list & /mv who - Shows the alias' name and color of my worlds

This is one of the few times that I can say i've tried to fix but to no avail. For good reason, ChatManager completly overrides Multiverse's world prefixes.
I've been asked by a lot of people to do this, so I wrote a pull request for ChatManager https://github.com/t3hk0d3/ChatManager/pull/2 on August 28th 2011. It was rejected by the author telling me "I'm going to rewrite this entire component soon."
I'm sorry, but I've done my part here. I am no longer willing to write any pull requests for a developer who can't accept one that added a soft depend on multiverse to achive what a bunch of users want.
There is light at the end of the tunnel. @krinsdeath has written a beautiful chat plugin ChatSuite that will do all this and more. Here is a sample config. CS has always supported MV Aliases and always will. Because @krinsdeath is a fantastic developer who appreciates, accepts and makes pull requests.

Thanks for the suggestion. Nice to know a developer that will go out of his way to get functions like this working. I'm curious, why did the "soft depend" stop working when I updated to 1.1-R1? It was working before, no problems.

That's pretty much it. I didnt update anything else. To be honest the only reason I got multiverse was because bSpace (space world) plugin wont work without a world manager. I had it running for about a day before I set the alias' which I got to work without any problems with chat manager. I set them in-game if that makes any difference. I'll contine to test this though because I find it quite odd that it wasn't working with chat manger to begin with.


Let the user choose which REP/ETH to claim from reporting

https://github.com/AugurProject/augur-app/issues/199

can we close this as it's addressed in the new claim modal - to claim all or individual markets
@Chwy5


Turning a tile into 1-side collision gives unexpected result (2.1.4b)

Godot version: 2.1.4 beta
Issue description:
The one side tiles do not work as expected, for example [0,1] can allow to step on the lower part of the collision shape.

Steps to reproduce:
Turn into one side (like [0,1]) an existing tile of a tileset and try to land in the middle of it.
Changing to different depth values does not alter anything on this behaviour.
Link to minimal example project:
Platformer demo can be used for this.

CC @RandomShaper

Just checked a bit more, seems that the player script is the problem, the ray shape to be more precise.

Will check ASAP. Please keep reporting your findings.

The simple Kinematic character demo works fine.
Tested casting some rays and looks like rays ignore the 1 side settings of rectangle shape colliders, but the issue does not affect the collision polygons (that may be why one side platforms on the platformer demo works fine).

Will you check if that's then an issue with RayCast by setting up a little
test with RigidBodies, for instance?
If it showed the same behavior, we'd know this is not related to the new
TileMap OWC functionality and a new issue about RayCasts could be opened.
El 27 jun. 2017 1:19 a. m., "eon-s"<EMAIL_ADDRESS>escribió:

The simple Kinematic character demo works fine.
Tested casting some rays and looks like rays ignore the 1 side settings of
rectangle shape colliders, but the issue does not affect the collision
polygons (that may be why one side platforms on the platformer demo works
fine).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/9406#issuecomment-311208401,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALQCtu-OsjN6-D3lH3AsaYfgu3-DFb_wks5sIDx7gaJpZM4OF8VP
.

@RandomShaper normal rigidbodies and kinematics controlled by move are ok so it looks like is not the TileMap, and maybe is an old issue with rays.
I'll close this and will do more tests tomorrow.

@eon-s, thank you for your updates on this! You're being really helpful.


sql\queries\users.sql:1:1: relation "users" does not exist

Version
1.26.0
What happened?
I encountered this error when I ran the command “sqlc generate”, this is the structure of the sql and yaml files.

Relevant log output
PS C:\Users\%USERNAME%\Documents\project_1> sqlc generate
# package
sql\queries\users.sql:1:1: relation "users" does not exist

Database schema
-- +goose up

CREATE TABLE users (
     id UUID PRIMARY KEY,
     created_at TIMESTAMP NOT NULL,
     updated_at TIMESTAMP NOT NULL,
     name TEXT NOT NULL
);

-- +goose down

DROP TABLE USERS;

SQL queries
-- name: CreateUser :one
INSERT INTO users (id, created_at, updated_at, name)
VALUES ($1, $2, $3, $4)
RETURNING *;

Configuration
version: "2"
sql:
  - schema: "sql/schema"
    queries: "sql/queries"
    engine: "postgresql"
    gen:
      go:
        out: "internal/database"

Playground URL
No response
What operating system are you using?
Windows
What database engines are you using?
PostgreSQL
What type of code are you generating?
Go

Did you try replacing -- +goose up with -- +goose Up (and the same for Down).
That's what the official DDL examples show.

the only thing, I didn't tried, it works, thank you.


Cli 8.3.0 ES5 build browser errors

🐞 Bug report
Command (mark with an x)

- [ ] new
- [X] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Is this a regression?

 Yes, the previous version in which this bug was not present was: ....
In version 8.2.2 I have no issues
Description
After updating to cli 8.3.0 I suddenly noticed a load of different errors for browsers using the es5 versions such as
Uncaught (in promise): TypeError: Object prototype may only be an Object or null.
Object prototype may only be an Object or null.
Uncaught (in promise): TypeError: Unable to get property 'enumerable' of undefined or null reference
These errors seem to be occuring when loading lazy modules via the router, and the module will not load, but not all modules have an issue.
🔬 Minimal Reproduction

So far I've not been able to find the cause, the project it's happening on is pretty big so could take an age to narrow it down, all I know so far is everything works without issue when using 8.2.2.
🌍 Your Environment

Angular CLI: 8.3.0
Node: 10.16.0
OS: darwin x64
Angular: 8.2.3
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... platform-server, router, service-worker

Package                                    Version
--------------------------------------------------------------------
@angular-devkit/architect                  0.802.2
@angular-devkit/build-angular              0.802.2
@angular-devkit/build-optimizer            0.802.2
@angular-devkit/build-webpack              0.802.2
@angular-devkit/core                       8.3.0
@angular-devkit/schematics                 8.3.0
@angular/cdk                               8.1.3
@angular/cli                               8.3.0
@angular/flex-layout                       8.0.0-beta.26
@angular/material                          8.1.3
@angular/material-moment-adapter           8.1.3
@angular/pwa                               0.801.3
@ngtools/webpack                           8.2.2
@nguniversal/common                        8.1.1
@nguniversal/express-engine                8.1.1
@nguniversal/module-map-ngfactory-loader   8.1.1
@schematics/angular                        8.1.3
@schematics/update                         0.803.0
rxjs                                       6.5.2
typescript                                 3.5.3
webpack                                    4.38.0

Anything else relevant?

Not sure if it will help but these are the build files for es5 polyfills from both versions
8.2.2
https://gist.github.com/dottodot/cf94e5ad7aeb5fa9bb46a8784bc9778b
8.30
https://gist.github.com/dottodot/350cae78efc360cab09e2a2d65e5685d

This appears to be a bug but we will need to look at a reproduction to find and fix the problem. Can you setup a minimal reproduction please?
You can read here why this is needed. A good way to make a minimal reproduction is to create a new app via ng new repro-app and adding the minimum possible code to show the problem. Then you can push this repository to github and link it here.

@clydin I am try to put together a reproduction, but it's not proving to be easy. I have found that if I turn off optimization on the build  I don't get the errors, so look like something is getting messed up during that process.

@clydin I've updated the gists of the polyfills generated by each so that they are not optimized and there are no similarities between the 2 so there seems to have been a major change to how the polyfills are created.
8.2.2
https://gist.github.com/dottodot/cf94e5ad7aeb5fa9bb46a8784bc9778b
8.30
https://gist.github.com/dottodot/350cae78efc360cab09e2a2d65e5685d

I have the same problem from 8.3.0. I don't know if this is relevant, but with v8.2, ng build --prod had this output:
$ ng build --prod

chunk {0} runtime-es2015.763595a658e3d915739d.js (runtime) 2.22 kB [entry] [rendered]
chunk {1} main-es2015.e3c08efc69d7e6b64c3f.js (main) 342 kB [initial] [rendered]
chunk {2} polyfills-es2015.5cb1e996b2a376ba4548.js (polyfills) 36.4 kB [initial] [rendered]
chunk {3} styles.260db7471b6b212d15fd.css (styles) 170 kB [initial] [rendered]
chunk {4} 4-es2015.048f9a64090cab8e98f7.js () 65.6 kB  [rendered]
chunk {5} 5-es2015.f075b92034ea071d2587.js () 10.4 kB  [rendered]
chunk {scripts} scripts.8101eab34ab8ceec5c05.js (scripts) 2.38 kB [entry] [rendered]
Date: 2019-08-23T09:31:16.652Z - Hash: 33fb6c4dbc6be9e03248 - Time: 41757ms

chunk {0} runtime-es5.e9dbe24425ac2594dc02.js (runtime) 2.22 kB [entry] [rendered]
chunk {1} main-es5.185af62d087b4cf3e617.js (main) 385 kB [initial] [rendered]
chunk {2} polyfills-es5.082c2604bbe32d09561f.js (polyfills) 118 kB [initial] [rendered]
chunk {3} 3-es5.9a0287347fc12637f12f.js () 78.5 kB  [rendered]
chunk {4} 4-es5.50989bbe4d9b595a26d6.js () 10.5 kB  [rendered]
chunk {scripts} scripts.8101eab34ab8ceec5c05.js (scripts) 2.38 kB [entry] [rendered]
Date: 2019-08-23T09:31:53.474Z - Hash: bb637c1926545f66aff8 - Time: 36719ms

Now, it's just :
$ ng build --prod

chunk {0} runtime-es2015.5347e435a5d46e675e0c.js (runtime) 4.24 kB [entry] [rendered]
chunk {1} main-es2015.b5f190e2953aaddb7646.js (main) 548 kB [initial] [rendered]
chunk {2} polyfills-es2015.616846cf0280d444086b.js (polyfills) 64.3 kB [initial] [rendered]
chunk {3} polyfills-es5-es2015.1fbf71c2275b42103e11.js (polyfills-es5) 211 kB [initial] [rendered]
chunk {4} styles.260db7471b6b212d15fd.css (styles) 170 kB [initial] [rendered]
chunk {5} 5-es2015.c58944658cbd734e2e82.js () 87.5 kB  [rendered]
chunk {6} 6-es2015.3394c5ab5d2af60ed413.js () 11.4 kB  [rendered]
chunk {scripts} scripts.8101eab34ab8ceec5c05.js (scripts) 2.8 kB [entry] [rendered]
Date: 2019-08-23T04:29:11.236Z - Hash: 06bcc42a7e96f19e7357 - Time: 59384ms
Generating ES5 bundles for differential loading...
ES5 bundle generation complete.

Our team is unfortunately also experiencing this problem with the CLI in version  8.3.0. Forced to downgrade today 😢

* When serving with optimizations I get the error: `Uncaught (in promise): TypeError: Unable to get property 'enumerable' of undefined or null reference. TypeError: Unable to get property 'enumerable' of undefined or null reference`.

Exactly same error for me in IE11.

@dottodot and @mpalourdio the changes that you are seeing in the polyfills and console respectively are expected, this is because in 8.3 we no longer generate the ES5 bundles using a separate Webpack build. But rather we use babel to downlevel the ES2015 code to ES5.
As @clydin mentioned, it would be useful and helpful for us to track down the problem is someone puts together a minimal reproduction.

Are any of these projects public?  Without a way to reproduce the problem, it is quite difficult to troubleshoot or provide a solution.
The configuration options for the project from both angular.json and the tsconfig may be helpful if generating a reproduction is proving difficult. Also, any information about the failing lazy routes and answers to the following questions would be helpful as well.
Are the applications using the string form or the dynamic import form for loadChildren?
Is Ivy enabled for the application (ivyEnabled in a tsconfig)?
Is there any JavaScript being used as an asset (angular.json assets option)?
Does the application work with optimization enabled but buildOptimizer disabled?
What version of zone.js is being used in the application?
What version of core.js (if any) is present?  (8.0+ uses core.js 3 internally.  It's highly recommended to use 3 as well if adding any custom polyfills)
Also, please ensure that the browserslist file for the application includes IE11.  The browserslist file represents the browser requirements for the application and should include all browsers that the application is required to support.

@clydin I have started the process of trying to reproduce the issue 👨🏻🦳

@clydin  My failing projects are both private, I need time to make a reproducible public one. For the moment, here are few answsers

see angular.json, tsconfig, package.json, browserlist here
Lazy routes with dynamic imports for me
Ivy not enabled
Yes, some js used as assets (see angular.json in my gist)
Does the application work with optimization enabled but buildOptimizer disabled? I did not test this point
zonejs ~0.9.1
no specific core.js in package.json

@clydin I'm using dynamic imports for my lazy modules, one thing I've noticed is I'm only getting the error when I click on a link in the app (via routerLink). If I access the route directly the modules loads without any errors.
I updated to the latest version of core-js but that has not made any difference.
buildOptimizer disabled makes no difference either.
ivy is not enabled
no js assets in angular.json
This is my browserlist
> 0.5%
iOS >=8
last 4 versions
Firefox ESR
not dead
IE 9-11

    "zone.js": "~0.9.1"

I have same error.

Just an FYI - Setting the NG_BUILD_DIFFERENTIAL_FULL environment variable to 1 got rid of the error for me.

Yes, it's helped.

Hi all, I have tried to replicate the above  reported issue but I was unable to do so.
Steps
ng new lazy-loading-dl --routing
cd lazy-loading-dl
ng g m foo --module app.module --route foo

Added the below in app.component.html
<a [routerLink]="['/foo']" >
  link to foo
</a>

ng build --prod
http-server dist/lazy-loading-dl

Opened the page in IE11 and clicked on link to foo.
Result
The lazy loaded module loaded without any error.
We really need a reproduction to track down and solve the issue.

@alan-agius4 I have a hard time trying to reproduce this in a minimal project too. But the problem exists Can you just try adding a guard that returns an observable on your 'foo' route ?
One of my project has import 'core-js/es7/array'; in polyfill.ts So I can use `myArray.includes('a-value').

Ok, so I have tried with bith the guard and the polyfill, with no luck as this runs okish in IE11

@mpalourdio, by any chance do you have a full stacktrace of the error that you are getting?

@alan-agius4 I only have the error in console. But if you point me on what to do, I can quickly deploy the project with ng-cli 8.3.0 and copy/paste the stack trace

   "ERROR"
   {
      [functions]: ,
      __proto__: {
         [functions]: ,
         __proto__: { },
         message: "",
         name: "TypeError",
         Symbol()_6.2ef34fg5dw7: undefined,
         Symbol(INITIAL_VALUE)_h.2ef34fg5dw7: undefined,
         Symbol(rxSubscriber)_g.2ef34fg5dw7: undefined,
         Symbol(rxSubscriber)_i.2ef34fg5dw7: undefined
      },
      description: "Impossible d’obtenir la propriété  « enumerable » d’une référence null ou non définie",
      message: "Impossible d’obtenir la propriété  « enumerable » d’une référence null ou non définie",
      name: "TypeError",
      number: -2146823281,
      stack: "TypeError: Impossible d’obtenir la propriété  « enumerable » d’une référence null ou non définie
   at e (https:/xxxx/5-es5.c58944658cbd734e2e82.js:1:275)
   at bo (https://xxxx/main-es5.b5f190e2953aaddb7646.js:1:76428)
   at po (https://xxxx/main-es5.b5f190e2953aaddb7646.js:1:75164)
   at xu (https:/xxxx/main-es5.b5f190e2953aaddb7646.js:1:112335)
   at Mu (https://xxxx/main-es5.b5f190e2953aaddb7646.js:1:120147)
   at Nu (https://xxxx/main-es5.b5f190e2953aaddb7646.js:1:119347)
   at xu (https://xxxx/main-es5.b5f190e2953aaddb7646.js:1:112568)
   at wu (https:/xxxx/main-es5.b5f190e2953aaddb7646.js:1:111018)
   at t ",
      Symbol()_6.2ef34fg5dw7: undefined,
      Symbol(INITIAL_VALUE)_h.2ef34fg5dw7: undefined,
      Symbol(rxSubscriber)_g.2ef34fg5dw7: undefined,
      Symbol(rxSubscriber)_i.2ef34fg5dw7: undefined
   }

ERROR TypeError: Impossible d’obtenir la propriété  « enumerable » d’une référence null ou non définie
   "ERROR"
   {
      [functions]: ,
      __proto__: { },
      description: "Impossible d’obtenir la propriété  « enumerable » d’une référence null ou non définie",
      message: "Impossible d’obtenir la propriété  « enumerable » d’une référence null ou non définie",
      name: "TypeError",
      number: -2146823281,
      stack: "TypeError: Impossible d’obtenir la propriété  « enumerable » d’une référence null ou non définie
   at e (https://xxxx/5-es5.c58944658cbd734e2e82.js:1:275)
   at bo (https:/xxxx/main-es5.b5f190e2953aaddb7646.js:1:76428)
   at po (https://ixxxxx/main-es5.b5f190e2953aaddb7646.js:1:75164)
   at xu (https:/xxxx/main-es5.b5f190e2953aaddb7646.js:1:112335)
   at Mu (https:/xxxx/main-es5.b5f190e2953aaddb7646.js:1:120147)
   at Nu (https://xxxx/main-es5.b5f190e2953aaddb7646.js:1:119347)
   at xu (https:/xxxx/main-es5.b5f190e2953aaddb7646.js:1:112568)
   at wu (https://xxxx/main-es5.b5f190e2953aaddb7646.js:1:111018)
   at t ",
      Symbol()_6.2ef34fg5dw7: undefined,
      Symbol(INITIAL_VALUE)_h.2ef34fg5dw7: undefined,
      Symbol(rxSubscriber)_g.2ef34fg5dw7: undefined,
      Symbol(rxSubscriber)_i.2ef34fg5dw7: undefined
   }

@mpalourdio, I tried various things and I am still unable to reproduce the error. Would it be possible to privately share your application with the team?

@alan-agius4 Do you need to make the code run ? As it's tightly coupled with a java backend and some node_modules published internally on a 'nexus'.

Yeah, it would need to "run" to see the error in the browser.  If you share the dist folder alone will I be able to produce see the mentioned error?

Let me give this a try with the dist folder.

@mpalourdio can we take this convo on gitter in https://gitter.im/angular/angular-cli so that we don't spam the tread here?

@alan-agius4 I'm sorry but my company's firewall does not allow me to access to gitter :/. Good news is that I have a dist folder that runs standalone and that bugs in IE11 ! Do you want me to mail you the zip file<EMAIL_ADDRESS>?

@mpalourdio yes please :)

I had 'regeneratorRuntime' is undefined
with ie11 and
    "@angular-devkit/build-angular": "~0.803.0",
    "@angular/cli": "^8.3.0",

only working solutions was to downgrade to
    "@angular-devkit/build-angular": "~0.802.2",
    "@angular/cli": "^8.2.2",

browserlist did not help nor adding all polyfills by hand to polyfill.ts

@alan-agius4 Sorry for spamming here, please delete one notified, but gmail antivirus rejected my mail. I have invited you in a private repo : https://github.com/mpalourdio/ngcli830-dist

@mpalourdio, can you also provide the unminified version of the code please? Thanks

@alan-agius4 added in a zip on the repo

I updated using ng update and boom got this warning
WARNING in budgets, maximum exceeded for initial. Budget 2 MB was exceeded by 82.5 kB.
Generating ES5 bundles for differential loading...
ES5 bundle generation complete.
bundle.js is now 1.5mb with 8.2.2 it wasn't that big in size.

thanks @mpalourdio

We had 'regeneratorRuntime' is undefined first, then I added https://www.npmjs.com/package/regenerator-runtime and got a different error ("no platform exists!" error message coming from the polyfills file). Then I downgraded back to CLI 8.2. asap.

on CLI 8.3.1, We had 'regeneratorRuntime' is undefined issue in IE 11.....

Setting the NG_BUILD_DIFFERENTIAL_FULL environment variable to 1 also got rid of the error for me.

This is probably caused by #15246 as when I searched for what caused our issue, I found https://babeljs.io/docs/en/babel-polyfill where the regeneratorRuntime was mentioned.
I did an upgrade on our projects again to provide more info.
We use nrwl/nx and monorepo-style development, we have shared libs and 2 apps.
Our larger app

It works well in Chrome and we got error in IE 11 only.
The initial error is:

SCRIPT5009: 'regeneratorRuntime' is undefined
vendor-es5.[hash].js (1,2700948)

After adding import "regenerator-runtime/runtime"; to our polyfills, we got this error:

No platform exists!

Our smaller app

It works well in Chrome and we got error in IE 11 only.
The error message is:

SCRIPT5007: Invalid operand to 'in': Object expected
main-es5.[hash].js (1,109)

The generated code is:

So 2 apps, same (nx) project, similar setup, different error messages in IE 11.

@alan-agius4 I updated the process-bundle.js file in our node_modules with your updates from the PR to test, and I got the same errors described in my previous comment. Do you want me to create a new issue for those as the PR will close this issue?

@merobal, the issue you are experiencing is not related to this one. With regards to the regenerator-runtime there is a PR for that https://github.com/angular/angular-cli/pull/15470
So make sure that you delete the cache prior to rebuilding after changing the code in build-angular using:
rm -rf node_modules/.cache

Can you check if you get the 2nd error?

@alan-agius4 Thanks for pointing out that PR.
About the second issue: thanks for suggesting to remove the cache, I can confirm that our smaller app works good now.
I re-tested our larger app with adding the missing polyfill manually (and having the build fix), and that works now too.

Thanks @merobal for checking

A huge thanks goes to @mpalourdio for providing a reproduction that was crucial to pinpoint the issue.

Hey, happy to help and happy to see that issue has been resolved ! You all do an AWESOME job here!


update cocotb top rtl to work with cheetah soc

Why did you remove the gf180mcu includes?

Why did you remove the gf180mcu includes?

I haven't remove anything. I just changed the way of including to rely only on the include list. these changes are at caravel-sim-infrastructure repo


word_lstm_dims is not used in NERCRF

https://github.com/NervanaSystems/nlp-architect/blob/master/nlp_architect/models/ner_crf.py#L45
Seems that the argument word_lstm_dims is never used in the model. Is the model missing this argument or this is a useless argument?

@hkvision , please ignore, I'm going to push an updated CRF layer shortly.

Updated in v0.4


Goto definition for some functions are taking to the wrong definitions.

VSCode Version: Code 1.13.1 (379d2efb5539b09112c793d3d9a413017d736f89, 2017-06-14T18:13:05.928Z)
OS Version: Darwin x64 16.6.0
Extensions: the listing length exceeds browsers' URL characters limit

Steps to Reproduce:

This was observed when using fabric in python.

In a python file, add

from fabric.contrib.project import rsync_project
from fabric.api import sudo

Hover the mouse over rsync_project or sudo or command+click on it to take to the definition. It goes to the definition for host_prompting_wrapper in a different file instead of the definition for sudo or rsync_project. This is not observed for all functions. This is observed for a very limited set of functions.

Please file this agains the pyhton extension here https://github.com/DonJayamanne/pythonVSCode


Update ca1052-static-holder-types-should-be-sealed.md

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot


Support inspecting Symbols

Closes #296

Coverage remained the same at 100.0% when pulling eb3e2a388f2cae5d4696fe914e70a05e584e4055 on rpearce:inspect-symbol into b3801a03e5efc9f3534e1cce2dffa075eced3424 on evilsoft:master.

This looks pretty awesome.
What do you think about exposing isSymbol to the outside world as new predicate function?
If so it will have to be added to the predicate folder, and brought in from the core implementation. Then it would need to be exposed to the main crocks index through predicates index and onto the index inside of src/?

@evilsoft I think that's a fair thing to expose

This is GTG. Merging and please by all means, have a squirrel:


Create WinGet package for March 2024 GDK Update 9

Create WinGet package for March 2024 GDK Update 9
Tested locally with winget validate and winget install

@microsoft/xbox-developer-experience-toolbox for review


Update links to examples on github pages

Coverage decreased (-1.09%) to 98.905% when pulling 41fad535f09da332f906a32a0bcf2cafb16d8c19 on Trimnosh:example_links into fd8a00547fd01c672b6251659ebdd03135b69f2b on wirecard:master.


Implementation ideas

I am dropping here some ideas that could be interesting to add to streama .
1st - Allow only 1 login per user
(this means that as soon as server detects an user logged in then it will not enable any more users with those credentials)
2nd - Automatic load the subtitle in case there is only one on the movie/tv show) configuration .
(This means that if there is no subtitles configured then server will run normally , but if a subtitle exists on movie/tv-show configuration in server , then load the first one automatically)
3rd - create a drop down tab with everything in server (not on menu) .
(On top menu where we see , "User / TV-Shows / Movies / My List" , create an aditional field with everything in server , from movies , tv-shows , other videos . This way it will be more practical for users on android tvs and adroid boxes to browse the content.)
I will add more ideas as soon as i see them to be fitted to server .

I have the 2nd one implemented on my server, if you are interested I could make a PR

that would be nice , on github you can do the pull requests as much as you want , then the maintainer can add it or not .
Create the pull request explaining your changes in the code .
Here it is the thing , Streama is used mainly for private home media servers , so people from each country will have their subtitles country code on their movies , because of this i believe that Antonia could merge it .
However , it could be more interesting if an option box in admin server configuration could have that checkmark and user then decide if wants it enabled or not .

I'll PR it tomorrow, consider it done!
The checkbox on the admin menu is exactly what I was thinking on to toggle it on/off, same as the "guess subtitle label" option.
I already made some PRs for streama before :P


Dangling symlinks are not currently detected

Describe the bug
Currently, we do not detect if you create a dangling symlink in a derivation.
An example where this is a problem and a fix is needed: #107781
We should have a sanity check either in our fixupPhase or alternatively through the introduction of a new internalCheckPhase where we can detect stuff like this and error out.
The easiest is to simply run something like find $out -xtype l and error out on output.
To Reproduce
Steps to reproduce the behavior:

nix-shell -p kinfocenter
notice the error when you try to run kinfocenter

Expected behavior
nix-build should have errored out with a dangling symlink detected. aborting! error.

Cc: @Ericson2314

I have a similar result in a different place:
$ ls /nix/store/68nknmy289lhldmf4yrrbb3r77d5ba9d-systemd-247.3/lib/environment.d/99-environment.conf -l
lrwxrwxrwx 1 root root 30 Dec 31  1969 /nix/store/68nknmy289lhldmf4yrrbb3r77d5ba9d-systemd-247.3/lib/environment.d/99-environment.conf -> ../../../../../etc/environment

I have no idea what that package is about, I stumbled across this in a different context, but that symlink is pointing... out of the filesystem, it seems like.


Update node-fetch and r2

:tada: This PR is included in version 2.1.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add -U flag for forcing output of utf-8 interpretation of zeek strings

This commit adds the -U flag for printing zeek string in a "forced"
UTF-8 format.  It is applicable to formats zeek, text, and table.
This is the very same non-standard formatting of mixed-binary strings
that zeek does.  There is no way to disambiguate between random binary data
and a deliberate utf-8 string so it's left to the "presenation layer" to decide
how to format the data.  This would be remedied if a zeek string were a UTF-8
string and zeek had a bytes type to represent non-string data.
For now, we have -U.

@philrz -U applies only to the zeek formats (text, table, zeek).  I wanted to leave ZNG and zjson as is, strict.    Otherwise, we could apply it to ndjson if you think that makes sense.

@mccanne: I'm fine with how it's working now, and I agree with your proposal of keeping ZNG and zjson as they are. I mostly just figured I'd enumerate the full set of observed black box behaviors in case it helped any of the reviewers.

I think zeek.EscapeUTF8 deserves a test in pkg/zeek/escape_test.go, annoying as that is.

done


Help prevent overflow of version attribute by using FIFO queue freelist

Currently the freelist is LIFO as it simplified the logic on deletion for speed. I need to investigate the performance impact of using FIFO instead to prevent the same slot being used over and over again.
This could then also be coupled with some system that guarantees at least n free elements, which would ensure that an overflow takes at least n times longer to occur.

This is implemented (as much as possible) for HopSlotMap in the upcoming version.

This is implemented (as much as possible) for HopSlotMap in the upcoming version.

For now I don't think I'll implement this for SlotMap/DenseSlotMap, it would involve more code, an extra branch, touching two slots instead of just one every deletion, and worse cache locality.

For now I don't think I'll implement this for SlotMap/DenseSlotMap, it would involve more code, an extra branch, touching two slots instead of just one every deletion, and worse cache locality.


[ZEPPELIN-4160] Fixed Move this note to trash icon always show

What is this PR for?
when the note moved to trash, the note should show 'Remove this note permanently', it does not work correctly after clicked again, more ~Trash folder will be created
What type of PR is it?
[Bug Fix]
Todos

[ ] - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-4160

How should this be tested?

CI pass

Screenshots (if appropriate)
Questions:

Does the licenses files need update? NO
Is there breaking changes for older versions? NO
Does this needs documentation? NO

@zjffdu , Please help me review code. Thanks!

can you explain the change from [0] to [1]?

@felixcheung , This is because of the problem caused by this ZEPPELIN-2619.

ok. do you think we should add more tests for ZEPPELIN-2619?

@felixcheung , More busy, I suggest to find out the problem and solve it. :-)

Will merge if no more comments


[FR] Add std::function_ref equivalent functionality

A 'proxy_ref': so that we don't pass around proxy const & (thereby incurring a double indirection).

If I understand correctly, proxy already provides the capability. You can simply instantiate a proxy<F> with any raw pointer type P (although proxy<F> still has nontrivial move ctor and dtor, it behaves like a raw pointer).
If proxy<F> is intended not to take any ownership for all P, it is allowed to fine tune performance like std::function_ref does. Lifetime semantics is associated with the definition of a facade (F::constraints). If you are using PRO_DEF_FACADE to define a facade, the constraints can be specified on the 3rd parameter, e.g.,
PRO_DEF_MEMBER_DISPATCH(Draw, void(std::ostream& out));
PRO_DEF_FACADE(DrawableRef, Draw, pro::trivial_ptr_constraints);

proxy<DrawableRef> will have trivial copy ctor and move ctor, but it can no longer hold any smart pointers (e.g., std::unique_ptr std::shared_ptr or pro::details::sbo_ptr).

That's not the same: a function_ref-like thingy does not need an SBO (or heap allocation) for any kind of target object - as it references it directly (as opposed to owning it) - it can/should be able to bind to a temprary (function argument).
A reference to a trivial proxy<> has two indirections: reference to the proxy and then a reference to the vtable (and possibly an additional one to the target if it did not fit into the SBO storage).
trivial_ptr_constraints will make proxy the size of two pointers, like function_ref but will require a heap allocation and a nontrivial destructor for larger-than-a-pointer targets or not support those at all.

trivial_ptr_constraints will make proxy the size of two pointers, like function_ref but will require a heap allocation and a nontrivial destructor for larger-than-a-pointer targets or not support those at all.

In the design of proxy, if trivial_ptr_constraints is specified in a facade definition F, proxy<F> is a trivial type. It is covered in our unit tests.

The dereferencing of small vtable is triaged as a QoI issue (filed !69).


APPS-1015 Refactor REST API of the service

http://<IP_ADDRESS>:8080/ui/#pitr/launches/all/3868
all tests passed (I updated test project)


WIP: added v1alpha1 API for PodPreset under settings

This PR adds v1alpha1 PodPreset API under settings group.
Sending this for an early review since this is my first contribution to Service Catalog repo.
Note for Reviewers:
I am working on the tests. This API will be guarded by a flag and will be disabled by default.

Looks like a good start. I cannot comment on the changes needed for TPRs.

I suggest that we do not make TPR support for this API group a precondition for merging this PR

I will split the PR into two commits. One capturing the human edits and another one capturing generated files, so that it is easy to review.

@MHBauer @pmorie PR has two separate commits one for manual and other for generated files. This should help in the review. Also added generated files for client which was not part of the original commit. PTAL whenever you get a chance.
About TPR, I have added the plumbing, but will not be testing TPR support for this API group.

Having PodPresets in this server seems to blow up TPR support completely. If service-catalog plans to rely on PodPresets, and PodPresets rely on etcd, etcd access must always be available.
Not sure what to think about this. Even if it wasn't in our API Server and was instead in a separate second API Server, it would still need to be installed with etcd support, which in the TPR case, it could not get.

@MHBauer Re: TPR/Etcd, I would propose to go ahead with Etcd only support for now because it is going to be feature guarded anyways. And then add CRD support later when we decide to implement CRD support for all the resources for service catalog. Once it is backed by CRD support, we can enable PodPreset by default. What do you think ?

Fine with me. Want to make sure the people who have expectations of CRD support understand that it isn't going to exist to start.
As far as tests, on the integration level it should be easy enough to no-op the TPR/CRD test as they are separated as subtests.

@MHBauer @pmorie added integration tests for the PodPreset APIs. This is very close to final changes (need to remove TPR support). PTAL.

Removed TPR support as suggested by @pmorie .

@MHBauer @pmorie Guarded the PodPreset APIs using feature gates. The PR have addressed all of your previous comments. PTAL.

@droot
What happens when I try to run this using TPR storage?  Does it fail?  Does it tell me that I need etcd for the settings API group?

@pmorie

What happens when I try to run this using TPR storage? Does it fail? Does it tell me that I need etcd for the settings API group?

Currently, the behavior is unknown. I have a TODO to handle this gracefully, will address it in this PR. Thanks for the comments.

Closing as this is what https://github.com/kubernetes-incubator/service-catalog/pull/1694 was based off.


WIP: Modified the stc_simulation code to allow overlapping labels

After coding the SourceSimulator object with @makkostya  (see issue #6119 ), we noticed that the simulate_stc code does not allow labels to overlap. Therefore, as discussed with @makkostya, @agramfort, @sdeslauriers  and @ikojcic, the code in this PR allows overlapped labels via an extra argument that is by default set to false. I have refactored the code a little, to achieve our purpose in the simplest way possible. However, since I am running Windows (temporarily I hope), I can't do the make tests. I will try to fix that soon. In the meantime, please feel free to review the code, anticipate bugs and propose optimization!

I feel like I should add a test too, or it can be done when the SourceSimulator class is ready.

Agreed, tests for both allow_overlaps conditions would help. Here is a stub to get you started if you want:
with pytest.raises(RuntimeError, match='must be non-overlapping'):
    simulate_stc(<overlapping_inputs>, allow_overlap=False)
# smoke test
simulate_stc(<overlapping_inputs>, allow_overlap=True)

I would also slightly prefer allow_overlaps to be allow_overlap because I'd assume most people would read it as "allow overlap between labels"

@ngayraud let me know when CIs are happy (or at least Travis or Azure, since they run full unit tests) and I'll look again

@larsoner I get an error which i feel is related to docstyle(?) but I'm not sure yet how to correct it cause I still can't make "make" work on my pc :/

@larsoner good to go!

Oh and also please add to whats_new.rst to document this enhancement

Thanks @ngayraud !

:)
Le mer. 24 avr. 2019 à 17:45, Eric Larson<EMAIL_ADDRESS>a
écrit :

Thanks @ngayraud https://github.com/ngayraud !
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mne-tools/mne-python/pull/6201#issuecomment-486298334,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEJ4H43PDZM7FEI34RJKYXTPSB6AXANCNFSM4HH3LVIQ
.


Get the Github user Login based on the PR instead of searching an email.

Searching by email implies that the author must make sure his primary email on github is the same as the one in his local .git/config file which is inconvenient.

Commit search is implemented in go-github.


Make stackrox chart modular

What is this PR About?
This PR moves the stackrox chart to use operatorhub sub-chart for operator deployment.
How do we test this?
helm template ;)
cc: @redhat-cop/day-in-the-life

@springdo @ckavili @eformat  FYI ;)

H @jfilipcz .. not sure about this - as it introduces a dependency on the operatorhub chart which does not add much other than a layer of abstraction to apply the Subcription. Does it really make sense for a single app Chart to do this ? i get it when we have many operators .. but not one.

Hey @eformat, on technical level, it doesn't really matter how we do that, I've decided to go with the sub-chart to keep the approach consistent with other charts in this repo

Hey @eformat, on technical level, it doesn't really matter how we do that, I've decided to go with the sub-chart to keep the approach consistent with other charts in this repo

that is the point though. charts in this repo with a single Subscription - are not tied to a dependency on the operatorhub chart.
this PR changes that. personally i'd prefer we left the usage of operatorhub chart to higher level automation (e.g as we do in enablement-framework) rather than forcing this dep.

LGTM ! thanks @jfilipcz


CIS Scan - Improve UX of Run Scan Modal

What kind of request is this (question/bug/enhancement/feature request):
enhancement/design
Other details that may be helpful:
We are going to add a section beneath the profile selector of the run scan modal. This section is responsible for informing the user of which tests will not be run and why.
There will be two subsections Not Applicable and Skipped tests. Skipped tests will only be shown for permissive profiles since hardened tests shouldn't skip anything.

Here are screenshots of what we intend to create.

Verified on latest master-head commit id: `` , ui tag: latest2

The UI after Run Scan is clicked is

Logged issues:

https://github.com/rancher/rancher/issues/26065

I've closed #26056 in the latest 2.4 master-head build commit: 148b3e000
From @sowmyav27 I also think #26066 will make easier to differentiate between Rancher Skips and user Skips.
Besides that I think we're good to close.


Fix bug with recursive bundles depending on items from original modules.

Fixes a bug found while investigating #995 . More generally this fixes many problems in the bundling of cyclic dependencies

As described here the problem is more complex than I usually thought if one wants to minimize the amount of bundled items. So this PR implements a conservative approach (that is much more simple than what we did before): when there is a cycle at the module level, it bundles together in a new module everything the content of all the modules in the cycle. https://github.com/hacspec/hax/issues/1005 will track whether this is practical enough and if we should find an algorithm to minimize bundles.

Looks like tests snapshot are not up to date? :thinking:

Looks like tests snapshot are not up to date? 🤔

Yes, noticed that too. I am looking into it.


Test feature request

User story

As a {}
I want / need {}
So that {}

Acceptance criteria

Criterion 1
Criterion 2
...

Definition of done (DoD)

Added only after week 5
The same for all features
Here goes the project specific part

DoD general criteria

Feature has been fully implemented
Feature has been merged into the mainline
All acceptance criteria were met
Product owner approved features
All tests are passing
Developers agreed to release

closed as it is not a real feature request


Add nightly playground

Description
This change adds the initial draft of nightly playgrounds with below specifics:

distribution version, distribution urls are grabbed on the go whereas all other important parameters are hardcoded in the code
Adds tests
Adds GHA workflow to run tests

Issues Resolved
#129
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

So from the looks of it, this is basically import cluster cdk, and deploy a stack of OpenSearch / Dashboards with provided url?
Just wondering why cant we use the existing cluster cdk directly?
Thanks.

The reason we went with this approach is to reduce the context variables and source code what is required for this use case. Such as security should always be enabled. Also, for future stacks, we can extend / depend on this base stacks. Another reason was to stick to 1 version of opensearch-cluster-cdk. The project is pretty new and has active changes coming in more often which we need not be bothered unless required.


⚠ Bofrost.be has degraded performance

In 0f1a5d7, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1632 ms

Resolved: Bofrost.be performance has improved in 2afa95b after 9 minutes.


basic spring mvc and spring mvc starter integration

This exposes a GraphQL endpoint on /graphql wich accepts GraphQL Post requests and calls the provided GraphQL bean.

@andimarek Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@andimarek Thank you for signing the Contributor License Agreement!


[Incremental] Recreate https://github.com/apple/swift-driver/pull/180 w/ small changes

Essentially recreate https://github.com/apple/swift-driver/pull/180 to provide a hook for incremental compilation to schedule the 2nd wave of compile jobs.

@swift-ci please test

Thank you for checking this! Really appreciate your care and effort.
I have been working to understand the llbuild architecture and the various strata: CoreBindings, LLbuild, etc. I was wondering about the thought process you went through.  For instance, is there some way to make incremental compilation work just with the right inputs and outputs, and the hook in llbuild that says an input has changed?
The link job could have as an input the driver graph step that verifies no more compilations are needed. That step would take an input which is the swiftdeps files of the 1st wave of compile jobs. The link job would have all the .o files as its input. If the driver dep graph step finds the need for additional compilations, it would tell llbuild that the .o inputs for the link job are invalid and llbuild would then schedule the needed compilations.
Is this crazy talk? Or is it a more conceptually economical way than the design in this PR?
(I might hold off on landing this, until I figure out that the graph-strategy is worse.)

@DougGregor

To be honest, I'm really not familiar enough with llbuild to know if that would work or not, but it sounds promising! #180 was just the solution that seemed simplest at the time to get incremental builds up and running in the command line driver, but I didn't put a lot of thought into making it work with libSwiftDriver clients and eventually moved on to working on other things.

Hey, thanks a lot! It's very helpful to know what those who came here before me were thinking.￼￼

Isn't the problem you want to solve independent of llbuild. Some unknown user of the swift-driver could use his private job scheduler.

You want to be informed when a Job finishes
You want to schedule more Jobs depending on information that you extracted from the finished job.


Adding Riney

This pull request was created using the https://discordbots.co.uk/edit menu.

Do you have a long description?

I assume he doesn't or doesn't care at all...


Forbidden forcess success a task instance in a running workflow instance

Purpose of the pull request
A simple way to avoid https://github.com/apache/dolphinscheduler/issues/15849
Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

(or)
If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Codecov Report
Attention: Patch coverage is 55.00000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 39.56%.  Consider uploading reports for the commit 452299d to get more accurate results

Files
Patch %
Lines

...uler/api/service/impl/TaskInstanceServiceImpl.java
60.00%
5 Missing and 1 partial :warning:

...heduler/api/controller/TaskInstanceController.java
0.00%
2 Missing :warning:

...nscheduler/service/process/ProcessServiceImpl.java
0.00%
1 Missing :warning:

Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15855      +/-   ##
============================================
- Coverage     39.59%   39.56%   -0.03%
+ Complexity     5010     5009       -1
============================================
  Files          1347     1347
  Lines         45646    45629      -17
  Branches       4892     4890       -2
============================================
- Hits          18073    18053      -20
- Misses        25648    25651       +3
  Partials       1925     1925

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


calling get_assets failed if there's no trade at all

Describe the bug

start new backtest, not trigger any trade(buy/sell)
call client.get_assets(start, date)
exception raised as:

can't extend empty axis 0 using modes other than 'constant' or 'empty': (499, "can't extend empty axis 0 using modes other than 'constant' or 'empty'")

Expected behavior
No exception and return principle as assets
Version
backtest version: 0.4.4

will be deployed on site as 0.4.5 released


bcm2837-lpa unable to extract on Windows

I realize this is generated code, so if this issue should be in the SVD2Rust repo I will move it there.
The bcm2837-lpa crate includes an aux module that causes the crate to be uncompileable on Windows. This is because aux is one of the few names that files aren't allowed to be named on Windows.

djmcgill/form#12 is the upstream issue, but there hasn't been much progress on it recently.
I'm following riscv-rust/k210-pac@b044481 and not using form to format the source files as a temporary fix.

Fixed in 3c5b4c5 and release v0.2.1.


withRouter decorator prevents component from re-render inside custom render function

Having this component
export const Counter = ({ value, onClick }) => {
  return <button onClick={onClick}>current value: {value}</button>;
};

and this story with custom render function
import { useState } from 'react';
import { withRouter } from 'storybook-addon-react-router-v6';

import { Counter } from './Counter';

export const Default = {
  render: () => {
    const [value, setValue] = useState(0);

    return <Counter value={value} onClick={() => setValue(value + 1)} />;
  },
};

export default {
  component: Counter,
  decorators: [withRouter],
};

The component will not be re-rendered on button clicks if withRouter decorator is used. Removing decorator fixes the issue.
Reproduction - https://stackblitz.com/edit/storybook-addon-react-router-usestate-issue?file=src%2FCounter.stories.jsx
Libraries
    "@storybook/addon-essentials": "^7.0.27",
    "@storybook/addon-interactions": "^7.0.27",
    "@storybook/addon-links": "^7.0.27",
    "@storybook/blocks": "^7.0.27",
    "@storybook/react": "^7.0.27",
    "@storybook/react-vite": "^7.0.27",
    "@storybook/testing-library": "^0.0.14-next.2",
    "storybook": "^7.0.27",
    "storybook-addon-react-router-v6": "^1.0.2",
    "react": "^18.2.0",
    "react-dom": "^18.2.0"

I'm aware of this behaviour. I'm working on a v2 that will fix that issue.
For now, as a workaround, you can declare your component outside the story object:
function DefaultComponent() {
  const [value, setValue] = useState(0);
  return <Counter value={value} onClick={() => setValue(value + 1)} />;
}

export const Default = {
  render: () => <DefaultComponent />
}

@artaommahe I have published a RC for the v2, can you give it a try ?
https://github.com/JesusTheHun/storybook-addon-react-router-v6/releases/tag/v2.0.0-rc.0

@JesusTheHun it works!


Add mrca, branch_length and kc_distance functions with tests

✅ mrca
✅ branch_length
✅ kc_distance

Looks like you need to rebase - as a rule of thumb, you never merge especially when git suggests you do!

Looks like you're not having much fun with the rebasing @Billyzhang1229 - how about Ben or I take you through it?

Looks like you're not having much fun with the rebasing @Billyzhang1229 - how about Ben or I take you through it?

True, I'll probably try a few more times today, I need more practice on it and reach out to you or Ben if I can't solve it by tomorrow.🙃

As another git tip, it is best to work on a topic branch rather than your main as you'll often have more than one branch in progress, it also prevents you updating your main from the upstream repo.

As another git tip, it is best to work on a topic branch rather than your main as you'll often have more than one branch in progress, it also prevents you updating your main from the upstream repo.

I see, it is my first time to fork an upstream repository and work on it, normally I would just branch in my repository and merge it to main after finishing up.

This has conflicts now @Billyzhang1229 - we can go through how to do this tomorrow.

Closed in favour of #15 which has a named branch.


refactor: respect ruff recommendation on init imports

ruff suggest to use dummy renaming in  __init__ imports to avoid raising F401 error. the other solution is to add them to __all__ but that's not an option as we use * for generated.

I like using a flake8 rule better:
per-file-ignores =
    __init__.py: F401

What do you think @maartenbreddels?

I find from .Html import Html as Html a bit of a boilerplatey fix, for flake8 I prefer what mario suggests. Does ruff have the same option to ignore this rule for specific files?

of course there is ! any better 😄 ?

What should the title be now that this isn't the ruff recommendation anymore?

I changed the name to something a bit more generic. Th PR does 2 things :

make sure ruff doesn't delete import statements from init
specifically ignore F401 in init because that's a design descision in ipyvuetify

Great! I think "errors" should be "lint errors"

Thanks!


WIP, ENH: Button to change the background color

This PR adds a color picker in the tool bar. It's still work in progress.
https://user-images.githubusercontent.com/18143289/110133645-d416da80-7dcc-11eb-8de6-9cc781d2cd75.mp4
ToDo:

[ ] Update matplotlib canvas too
[ ] Add notebook support
[ ] test/coverage

It's an item of #7162

You might be interested @hoechenberger since you suggested the idea :)

Awesome, I'd totally forgotten I'm slightly creative sometimes! 😅 will play with it ASAP!!!!

@GuillaumeFavelier It's great!
But it's actually much more than I'd actually meant to propose 😅
See, my idea was to have a button which would essentially toggle between a "light" and a "dark" background – with the idea that, at some time in the future, the button press could switch the entire GUI theme between light and dark.
The color picker is a great idea, but I think it's over-engineered for my use cases, and won't play as nicely with the idea to add a GUI theme switching functionality. See what I mean..?
What do others think?

Whoops, I misunderstood then. I can close if it's not needed :+1:

The light/dark theme is on the todo list, I'll link your comment to have the details :)

Sorry about this 😕

@hoechenberger if you want to get a start on the light/dark theme, I would look into:

Look up how light/dark theme of the OS can be detected by Qt (probably some standard, platform-independent command nowadays?)
Look how to switch Qt between two themes (probably via stylesheets?)

This is probably a common issue nowadays so some googling + quick changes might get us most of the way there. I don't think we need to get it working on all OSes and both Qt/notebook at once, even if it just works on macOS+Qt it's a good start.
FWIW I don't think we will want to change the background color of the render window based on the theme, just the controls. Otherwise the screenshots/images people produce will differ across machines, which is not good.


[draft ]Text based MV rewrite using ast - expand original Ast

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Final patch: #3014


Support ForEach queries

This isn't required for simple N+1 relationships, we would use this for optimised commands.
For example, a function definition could support batch api calls if exposed with array parameter annotation.
/**
 * Answers the question: `Are these users active?`
 * @pure
 * @param ids user-ids to query
 * @batch user_is_active ids id
 */
function users_are_active(ids: Array<string>): boolean {
    ...
}

Exposes users_are_active as normal, and user_is_active  as if it had id parameter instead of ids and uses Variables capability to wire up relationships.
N+1 Engine Feature: https://hasurahq.atlassian.net/browse/V3API-194

One problem right now is that arguments are just Values, so we would need a way to specify them via variables. But the idea seems good in general to me.


Need more runtime hooks during a training step

Describe the feature
In the PyTorch fashion, we usually train a model like
for x, y in dataloader:
    ... # do something before forward
    out = model(x)
    loss = criterion(out, y)
    ... # do something between forward and backward
    optimizer.zero_grad()
    loss.backward()
    optimizer.step()
    ... # do something after backward

In the trainer of Colossal-AI, it is only allowed to add hooks before and after a training step, while users cannot customize the behaviors between fetching an input batch and forward pass, or between forward and backward pass.
Also, since the OpHook is applied to modules recursively, it is not appropriate for this issue either. We may need to add at least two more hooks as mentioned above.

Data fetching, forward pass and back prop are implemented in the schedule. Thus, I don't think they are trainer hooks. Is there any use case for such hooks?

Data fetching, forward pass and back prop are implemented in the schedule. Thus, I don't think they are trainer hooks. Is there any use case for such hooks?

Correct, and that is why I didnt call them trainer hooks.
There are some cases that this can be helpful, like splitting the batch in tensor parallelisms, applying mixup, etc.
And the main issue is, such customization is allowed by PyTorch but currently not allowed by Colossal-AI.

I do agree that this is not supported by Colossal-AI. I found these use cases are indeed not related to schedule if we are adding hooks to schedule.Splitting the batch can be done at the dataset/dataloader or the first layer of model and applying mixup should be done at the dataset/dataloader.

I do agree that this is not supported by Colossal-AI. I found these use cases are indeed not related to schedule if we are adding hooks to schedule.Splitting the batch can be done at the dataset/dataloader or the first layer of model and applying mixup should be done at the dataset/dataloader.

I am also not sure how to implement such hooks. Just open the issue to collect ideas.

I think if we can abstract this part, it will provide some flexibility and extensibility to the schedule class. For example, there is a batch_data_process_func parameter to allow some customization (e.g. apply mixup if a user really wants to).

We have updated a lot. This issue was closed due to inactivity. Thanks.


Fix ShouldRestart for on-failure handle

Currently if you restart docker daemon, all the containers with restart
policy on-failure regardless of its RestartCount will be started, this
will make daemon cost more extra time for restart.
This commit will stop these containers to do unnecessary start on
daemon's restart.
How to reproduce:

start a container with restart policy on-failure:3
$docker run -tid --restart on-failure:3 busybox sh -c "sleep 1; exit 127"
wait it to fail and restart 3 times, make sure it stops and docker ps can't see it.
Restart docker daemon.
(DO THIS QUICKLY) docker ps shows that the stopped container is started, and fails, and restart 3 times again.

This is unnecessary because it already failed 3 times last time daemon is running, and starting this container will apparently lower the restart speed of daemon.

Edit: make some small refactor
Merge Container.ShouldRestart() and containerMonitor.shouldRestart(), so
they can share same logic. Besides that, some duplicated fields of
containerMonitor are removed.
Signed-off-by: Zhang Wei<EMAIL_ADDRESS>

Should we have a test for this?
change LGTM, although the code is becoming a bit complex to read, possibly splitting it up at some point would be good for readability

This test case will need to restart docker daemon, I'm not familiar with that part, could someone give me some instructions?
And I wonder it will become a flaky test, because it need to capture the container's restarting/running state.

ping @vdemeester wdyt, is it worth a test, or are we okay without?

@thaJeztah I figure out how to make the test case now, I think it'll work :smile:
/cc @vdemeester @cpuguy83 @calavera

@cpuguy83 I made an implementation for having container/monitor.go use Container.ShouldRestart(), it's a little complicated now and I'm worrying it may bring race conditions.
But in general it should make sense, let's see whether Janky is happy with this change.

Double checked this change, I believe that it should be right, Janky's test result also supported me.
/cc @vdemeester @calavera

WindowsTP4 timed out after 2 hours :cry: restarting

@thaJeztah Looks like 2 hours is definitely insufficient for Windows now :crystal_ball:

@WeiZhang555 yeah, I brought it up yesterday, but we think https://github.com/docker/docker/pull/21017 will be a better solution than raising the timeout limit. Perhaps I should discuss it again, even if just temporarily raising the limit :cry:

ping @WeiZhang555 sorry, needs a rebase now :cry:

@thaJeztah Rebased, thank you for your reminder!
/cc @cpuguy83

LGTM, thanks!

ping @vdemeester PR was updated, ptal

@thaJeztah Thank you :stuck_out_tongue_winking_eye:

LGTM 🐼

@WeiZhang555 oh boy, looks like it needs a rebase now. Can you rebase, then I think we can merge (I see two LGTM's)

@thaJeztah Yeah, the merge of containerd conflicts a lot with this, I will make some changes of code to adapt new code.
Will post more updates soon. :smile:

Yes, I feared that would be the case; sorry for that :blush:

@thaJeztah Never mind, this change is still necessary as I can see, just need some time to do more investigate, and also another code review :cry:

@cpuguy83 because of the change brought by containerd, it's hard to merge ShouldRestart() now. So I removed the refactor and only keeps the bug fix.
I can try to do the refactor after I get more familiar with new code if you don't mind.
Also ping @vdemeester @thaJeztah for another code review. :smile:

Re-LGTM if it's :green_book:

ping @cpuguy83 ptal, what's the status here?
@WeiZhang555 looks like it needs a rebase :cry:

I think we're just waiting on the changes mentioned above.

Yes, sorry for my delay. I'll be on travel these days and can't get reach of my computer.I'll post more updates once I come back in 3 or 4 days.

@WeiZhang555 no worries; we were just going through some old PR's, thanks in advance!

I'm back again, the code is updated based on previous comment, please help take a look. @cpuguy83

1 minor question, otherwise LGTM

ping @cpuguy83

LGTM but sadly needs a rebase again :(

Rebased. Waiting Janky turn to green :smile:

LGTM :+1:

Thanks @WeiZhang555!

:laugh:

Added "changelog" label; May be a nice optimization to mention in the change logs


Settings: Use in app

This will need to be broken into multiple issues or have a list of settings below.

This has already been implemented


Story tab gold difference text overlaps

Gold difference amount and percentage overlaps total gold shown. Is usually noticed on higher resolution monitors (1440p). Can be emulated by Ctrl+- to zoom out in browser if on 1080p.

@mdiller ?

Huh that's weird. I'll take a look when I have time