Exposing survey rule functionality

DESCRIPTION (include screenshots, and mobile screenshots for participant UX)
Now that Hearthive has surveys with rules going into prod, we should make rule visibility generally available.

TO TEST:  (simple manual steps for confirming core behavior -- used for pre-release checks)

log into admin tool as<EMAIL_ADDRESS>open a survey, and go to configuration menu
confirm rule editor appears

I noticed it says age >= 0... Is that expected? If not, I can take a look and see if I can figure out why that's not working.

btw, I noticed that github PR checks weren't working for a bit this afternoon, so the Require Jira Ticket and unit test jobs never ran on this PR

That's interesting about it getting switched to zero -- it's 18 in production.  I wonder if I accidentally changed it locally, or if something misfired in the export


az aks update --enable-managed-identity isn't supported while it is now GA

az feedback auto-generates most of the information requested below, as of CLI version 2.0.62

Describe the bug
https://docs.microsoft.com/en-us/azure/aks/use-managed-identity#update-an-existing-service-principal-based-aks-cluster-to-managed-identities tells us to use : az aks update --enable-managed-identity
To Reproduce
❯ az aks update --update-managed-identity -g sky-aks-rg -n sly-k8s
UnrecognizedArgumentError: unrecognized arguments: --enable-managed-identity
Expected behavior
For the command to work
Environment summary
OSX
✖ az version
{
"azure-cli": "2.15.0",
"azure-cli-core": "2.15.0",
"azure-cli-telemetry": "1.0.6",
"extensions": {
"aks-preview": "0.4.65"
}
}
Additional context

@norshtein

aks

Could you remove your aks-preview extension and re-install it? The command should be included in the latest aks-preview extension.
By the way, updating from using service principal to use managed identity is still a Preview feature, you need to register feature flag "Microsoft.ContainerService/MigrateToMSIClusterPreview" to use the feature.

@miwithro should we update our doc and call out the required feature flag? Right now it looks like SP to MI migrate is GA.

Correct, the DOC says it is now GA as well as the AKS release note. There is no mentioned of AKS-preview nor that a feature flag is needed.
@palma21 should the release note be updated to reflect the status of the feature?

Added the Preview note and the Feature Flag steps to the document.   Should be live tomorrow.

Thanks @djsly for your feedback and pointing out. It is really appreciated.
Let's close this one. Feel free to keep commenting.
#please-close

FYI, maybe we need to make this release note clearer as well: https://github.com/Azure/AKS/releases/tag/2020-11-09
It doesn't say GA but it doesn't say preview either

Migration from Service Principal-based clusters to Managed Identity Managed clusters is now supported. See how here.

@norshtein I ran the upgrade yesterday and along with having to enable Microsoft.ContainerService/MigrateToMSIClusterPreview, it also required Microsoft.ContainerService/AutoUpgradePreview.
is that expected? I couldn't find any mentions of that feature anywhere in the docs

@feliperoveran no, that's not expected behavior. We are investigating what happened.

@norshtein thank you!
by the way, I was able to get it working without enabling AutoUpgradePreview with aks-preview version 0.4.67

Yes, the auto-upgrade feature support is added in aks-preview 0.4.68, so 0.4.67 will not hit this error.


/MTd /fsanitize=address /LD: OSError: [WinError 1114] A dynamic link library (DLL) initialization routine failed

This issue has been moved from a ticket on Developer Community.

[severity:I'm unable to use this version]
I use Visual Studio Build Tools 2019

x64 developer command prompt

cl /MTd /fsanitize=address /LD main.c
where main.c is empty file (or not, this is minimal case)
main.dll is created

however when in python

import ctypes
ctypes. CDLL("main.dll")

i get:

Traceback (most recent call last):
File "", line 1, in
File "C:\python3\lib\ctypes_init_.py", line 374, in init
self._handle = _dlopen(self._name, mode)
OSError: [WinError 1114] A dynamic link library (DLL) initialization routine failed

This normally works with Visual Studio Professional 2022 17.9.2 (same workflow, same flags, etc)
When i omit /MTd, it works as expected but thats what i do not need

Forgot to mention build tools version:
happened in both 16.11.39 and 16.11.34 for me

Original Solutions
(no solutions)

Thanks for the detailed repro steps. I was able to reproduce this.
You're hitting a limitation of the version of the address sanitizer (ASAN) that shipped in VS 2019. When using /MT or /MTd, the ASAN implementation is statically linked into your DLL and expects the hosting EXE to supply certain ASAN functionality that would only be available if the EXE (python.exe) was also built with ASAN enabled.
You can read more about this at https://devblogs.microsoft.com/cppblog/msvc-address-sanitizer-one-dll-for-all-runtime-configurations/#motivation-and-effects. It appears that starting in Visual Studio 2022 version 17.7 Preview 3, when you build with /MT or /MTd, you end up using the ASAN DLL rather than a static lib, which solves this issue.
Also the discussion on this Developer Community issue provides some more details. I found it interesting: https://developercommunity.visualstudio.com/t/C-Address-Sanitizer:-statically-linked/1403680


Loosen ray version range

What this PR does / why we need it:
Hi 👋 ray is completing python 3.11 support in v2.6 with some bug fixes already on master and one open issue regarding wheel infra: https://github.com/ray-project/ray/issues/31362#issuecomment-1583812031
This PR opens the version range to ray>=2.4,<3.0 in expectation of full python 3.11 support upcoming in 2.5.2/2.6. And it opens up the upper bound of pandas as the community switches to pandas 2.0 (which only includes some esoteric breaking changes).
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
xref #2933
Type of changes
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevent result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

[ ] Test A

[ ] Test B

Logs

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Checklist:

[ ] Have you added unit/e2e tests that prove your fix is effective or that this feature works?
[ ] Has code been commented, particularly in hard-to-understand areas?
[ ] Have you made corresponding changes to the documentation?

Release note:

@ddelange the tests failed on python 3.11
https://github.com/kserve/kserve/actions/runs/5279769959/jobs/9550937877?pr=2993

hmm looks like a regression https://github.com/ray-project/ray/issues/36319

PR @ ray is up https://github.com/ray-project/ray/pull/36954

@yuzisun ci is passing here with ray 2.4 in the lockfile. my PR mentioned above will go into the next release

@yuzisun ray 2.6 was released with the bugfixes and all cp311 wheels

/lgtm
/approve

This PR is shown as merged in 0.11 release branch, but the dependence on ray ~2.4.0 still remains in the 0.11 toml file.  All the other changes from this PR seem to have gone through.  There is a critical vulnerability in grpcio versions for ray < 2.6 that is blocking us from pushing kserve 0.11 to prod, is there a reason why the change to ray ^2.4.0 was reverted?

This PR is shown as merged in 0.11 release branch, but the dependence on ray ~2.4.0 still remains in the 0.11 toml file. All the other changes from this PR seem to have gone through. There is a critical vulnerability in grpcio versions for ray < 2.6 that is blocking us from pushing kserve 0.11 to prod, is there a reason why the change to ray ^2.4.0 was reverted?

2.6 failed on the python 3.11 tests and we had to rollback

Do the 3.11 tests pass with 2.6.1 release?  We are manually patching kserve toml to allow ray 2.6.1 atm to get around CVE-2023-1428 and CVE-2023-32732, just looking for a target kserve release when > 2.6 will be officially supported.

Do the 3.11 tests pass with 2.6.1 release? We are manually patching kserve toml to allow ray 2.6.1 atm to get around CVE-2023-1428 and CVE-2023-32732, just looking for a target kserve release when > 2.6 will be officially supported.

Both 2.6.1 and 2.6.2 caused failures with Python 3.11 in the test_dataplane.py. We are waiting for 2.6.4 or 2.7.0
See #3075


Vite uses Ant to report some errors

Describe the bug
就是引用ant 后， 在使用时报告相关错误如下：

不知道为什么 会引用 ant 的package.json, 开始我以为是需要使用rollup的json插件来解决问题，但是尝试后无效。

main.ts

chrome console

Reproduction
链接地址
System Info

vite 2.0.0 beta.4
vue 3.0.5
ant-design-vue 2.0.0-rc.7

Logs (Optional if provided reproduction)

Run vite or vite build with the --debug flag.
Provide the error log here.

I've fixed the issue with package.json, but there are a few other problems:

You are not optimizing And Design Vue, so it's loaded as native ESM. However, it imports non-ESM dependencies (e.g. component-classes or raf, these actually are CommonJS packages), so it won't run natively in the browser. Ant Design Vue should refactor to avoid these CommonJS dependencies.

Even when pre-optimizing ADV, it relies on some outdated dependencies like component-classes which uses dynamic require calls to non-existent dependencies... these only work in simulated cjs runtimes and do not play well with Rollup's CommonJS handling, and should be avoided.

Basically Ant Design Vue needs to remove the dependency on these problematic packages to be Vite comaptible.

I've fixed the issue with package.json, but there are a few other problems:

You are not optimizing And Design Vue, so it's loaded as native ESM. However, it imports non-ESM dependencies (e.g. component-classes or raf, these actually are CommonJS packages), so it won't run natively in the browser. Ant Design Vue should refactor to avoid these CommonJS dependencies.

Even when pre-optimizing ADV, it relies on some outdated dependencies like component-classes which uses dynamic require calls to non-existent dependencies... these only work in simulated cjs runtimes and do not play well with Rollup's CommonJS handling, and should be avoided.

Basically Ant Design Vue needs to remove the dependency on these problematic packages to be Vite comaptible.

是的，是我的疏忽，经过对几个ui框架的对比发现 ant 的 dependencies 存在一定问题

是的，是我的疏忽，经过对几个ui框架的对比发现 ant 的 dependencies 存在一定问题

是的，这是我的疏忽，没有详细对比

是的，这是我的疏忽，没有详细对比

Uncaught SyntaxError: The requested module '/node_modules/raf/index.js?v=3.4.1' does not provide an export named 'default'

Uncaught SyntaxError: The requested module '/node_modules/raf/index.js?v=3.4.1' does not provide an export named 'default'

raf 使用了 CommonJS 导出，在浏览器引入是有问题的，但是 vite 没有报错

raf 使用了 CommonJS 导出，在浏览器引入是有问题的，但是 vite 没有报错

这个问题是在 vite2 出现的，vite1 没有问题

这个问题是在 vite2 出现的，vite1 没有问题


ASU-1489 | Use installment type for filtering in SAP and invoices endpoints

Changed installment filtering to be based on installment type instead of installment index in SAP and invoices API endpoints, because the former is the more robust way, and will allow sorting the installments in the UI.

Codecov Report

Merging #214 (81bb12b) into develop (a958f78) will increase coverage by 0.04%.
The diff coverage is 76.92%.

@@             Coverage Diff             @@
##           develop     #214      +/-   ##
===========================================
+ Coverage    93.18%   93.23%   +0.04%
===========================================
  Files          113      113
  Lines         3756     3754       -2
  Branches       326      325       -1
===========================================
  Hits          3500     3500
+ Misses         186      179       -7
- Partials        70       75       +5

Impacted Files
Coverage Δ

invoicing/api/views.py
96.00% <76.92%> (+2.49%)
:arrow_up:

invoicing/sap/utils.py
40.35% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a958f78...81bb12b. Read the comment docs.


EmulationStation Crash Retrobat 6.4

System: Windows 10 Pro with Retrobat 6.4
CPU: Intel Core i5 2400
Hard Disc: WD 4TB NTFS
Memory: 16GB
Grafic Card: Nvidia Gforce GT 1030 LP 2GB DDR5
Problem:
When I move through the menu, Retrobat suddenly closes randomly, it happens randomly with any system. The error that appears in the es_log.txt file is the following:
2024-08-29 16:54:09	ERROR	Error - Failed to load image from memory!
2024-08-29 16:54:09	ERROR	Could not initialize texture from memory, invalid data!  (file path: D:/RetroBat/emulationstation/.emulationstation/themes/es-Hypermax_Plus_v9/frogger/char.png, data ptr: 71,004,192, reported size: 1,262,596)
I have checked the PNG file and it is correct. The error is random, sometimes it is a PNG, other times it is an MP4, or an OGG, or an MP3, and I have always checked the files and they are correct.

you may wish to file your issue with RetroBat directly:
https://github.com/RetroBat-Official/retrobat-setup
and close the issue here.
the RetroBat developers are very responsive!

They don't know what it could mean, since it is something from ES.

it doesn’t hurt to try - you haven’t gotten a response here for 2 weeks.
RetroBat shares the same codebase with Batocera Linux - an enhanced fork of emulation station:
https://github.com/RetroBat-Official/emulationstation

it doesn’t hurt to try - you haven’t gotten a response here for 2 weeks.
RetroBat shares the same codebase with Batocera Linux - an enhanced fork of emulation station:
https://github.com/RetroBat-Official/emulationstation

I already made the query in Retrobat before doing it here, and the solution was to change the topic, although there are other people who have the same thing happen to me and it is not because of the topic. Asking here is in case you could give us some tips to follow to see if we can locate the error. It never hurts to have another point of view.

ah - thanks for clarifying that.  Did you try to change the theme?  Do you get the same error across multiple themes?

ah - thanks for clarifying that. Did you try to change the theme? Do you get the same error across multiple themes?

Sorry for my late response, but I'm very busy with work.
Regarding your questions, I have tried other topics and have obtained the same error. As soon as I can, I will try again and send you the complete log file so you can see the error. Thank you very much for your help, and sorry for my delay.

@udance4ever Sorry for my delay, I am attaching the file with the error. By the way, I now have version 6.4.0 of Retrobat, but I have the same error. I attach the es_log file obtained when it fails.
es_log.txt

es_log.txt
I attach another log file that I have obtained using another theme, and emulationstation continues to close.

Here I show you the errors that appear in the Windows event viewer.

I finally found out what all my mistakes were due to. And it was due to Retrobat's VRAM option, in which I had 256MB set. But when I went up thinking that my mistake would be solved, the opposite happened, that is, it got worse. So now I have a value of 100mb and everything works correctly, it no longer gives me the error.
I thought that the higher that value was the better, but it turned out to be worse.


Change SpreadProperty to RestElement in AST

Playground
SpreadProperty has been remove in ESTree since long time ago, https://github.com/estree/estree/pull/148/files.
Should use RestElement to align with other tools.

I believe it should be SpreadElement in this case? Rather than RestElement

Ah, yes. Apologize.


setParams not working with nested TabNavigator and Redux

My application navigator is configured as follow:
StackNavigator
  Login (Component)
  Hub (TabNavigator)
    Home (Component)
    ...

The HomeContainer has a componentWillReceiveProps function:
componentWillReceiveProps(nextProps: Props) {
  if (nextProps.user !== this.props.user) {
    this.props.navigation.setParams({ user: nextProps.user });
    this.refresh();
  }
}

The following doesn't work:

Navigate to LoginContainer from HomeContainer.
The user log in and the store user property is updated.
HomeContainer has not been unmounted, so componentWillReceiveProps is called.
Go back to HomeContainer, setParams has been called but nothing happened.

When setParams is called, it dispatches the SET_PARAMS action and the StackRouter getStateForAction tries to handle it. But it can't delegate it to the TabRouter because the currentRoute is Login, not Hub:
// currentRoute.routeName == "Login"
const childRouter = childRouters[currentRoute.routeName];

It can't handle it itself because the route is not found:
// action.key == "Home" and state.routes includes ["Login", "Hub"], not "Home"
const lastRoute = state.routes.find((route: *) => route.key === action.key);

Is that a bug or do I need to find a workaround ?
Thank you.

related to https://github.com/react-community/react-navigation/issues/296

Hi! In an effort to get the hundreds of issues on this repo under control I'm closing issues tagged as questions. Please don't take this personally - it's simply something we need to do to get the issues to a manageable point. If you still have a question I encourage you to re-read the docs, ask on StackOverflow, or ask on the #react-navigation Reactiflux channel. Thank you!


Add filtering to LinearApolloDisplay

JBrowse has track filtering, and one way of accessing it is through the track menu. The UI for adding filters looks like this:

Apollo needs something similar, although because the Apollo track configuration is dynamically generated, we can perhaps do something different from jexl.
Types of filters users have requested:

Filter by feature type, but ontology-aware (e.g. show all genes and is_a related terms, such as protein_coding_gene and pseudogene)
Filter by specific feature type (e.g. only genes and not pseudogenes)
Filter by a custom feature attribute

This will be accessible by a track menu item, the same idea as the menu items added in #461. The onClick for that menu item will queue a dialog (similar to the menu items in packages/jbrowse-plugin-apollo/src/ApolloInternetAccount/addMenuItems.ts). For now the dialog can be a strict feature type filter, with a drop-down to choose a feature type like the drop-down in packages/jbrowse-plugin-apollo/src/components/AddChildFeature.tsx.


Re: Error

Hi
Thanks for sharing your scripts for processing MP2RAGE. I tried to run the Matlab scripts, it is giving error like and it has same error in running remove background. Please let me know how to fix that. I am using spm12 and R2019b Is this related to MATLAB version? Thanks
Ned
7-Nov-2020 11:11:12 - Running 'Interactive remove background'
[mp2rage_run_remove_background]: Final output = /Users/Desktop/Fmri/uni/clean_s201007152011DST131221107524366082-0006-00001-000001-01.nii,1
17-Nov-2020 11:11:16 - Failed  'Interactive remove background'
Error using nifti/subsasgn>assigndat (line 384)
Unknown filename extension (.nii,1).
In file<EMAIL_ADDRESS>(v7370), function "assigndat" at line 384.
In file<EMAIL_ADDRESS>(v7370), function "fun" at line 76.
In file<EMAIL_ADDRESS>(v7370), function "subsasgn" at line 20.
In file "/Users/khan/Documents/MATLAB/spm12/spm_create_vol.m" (v7455), function "create_vol" at line 107.
In file "/Users/khan/Documents/MATLAB/spm12/spm_create_vol.m" (v7455), function "spm_create_vol" at line 17.
In file "/Users/khan/Documents/MATLAB/spm12/spm_write_vol.m" (v5731), function "spm_write_vol" at line 83.
In file "/Users/khan/Documents/MATLAB/spm12/toolbox/mp2rage-master/mp2rage_run_remove_background.m" (???), function "mp2rage_run_remove_background" at line 100.
In file "/Users/Documents/MATLAB/spm12/toolbox/mp2rage-master/mp2rage_cfg_matlabbatch.m" (???), function "prog_rmbg" at line 326.
The following modules did not run:
Failed: Interactive remove background

Hi Ned,
Thanks for the log !
The problem should be solved with 752c66fbefce6e8ce32bf492d7b94b8b2a80fad9.
Please try again after updating the code. Let me know if it works.
Best,
Benoît

Thank you very much for fixing it quickly. It works now.

Nice !


CI workflow triggered but not shown in checks for PRs marked as ready for review

This concerns my newly implemented feature to skip the ci.yml workflow for draft PRs.
When you turn such a PR into a ready-for-review one, the expectation was that this very event should trigger the workflow and a build-site job should run.
This is indeed what's happening, however, that build-site run is only showing up in the "Checks" tab, but the status checks section in the Conversations tab does not get updated so there is no direct visual cue for the PR author or the reviewers to see that a test was run and what it's result was.
Not sure whether this is an unavoidable github UI issue, or whether this can be addressed somehow in the workflow definition, or in the required status checks section of the settings.

Here's an example PR that started out as a draft PR: #4067
Only two checks are reported in the PR merge section, but 4 on the Checks tab.
https://github.com/galaxyproject/training-material/actions/runs/4813188522 is the actions run that was triggered through the ready_for_review event.

#4071 addresses the redundant ci run caused by the review_requested event, but is not expected to solve this issue.


feat: enable to read config file

enable CLI to read config file
Usage:
node ./index.js | tee -a ./pino_log/http.log | jq -c 'del(.req.headers) | del(.http.response.headers) | del(.redact)' | pino-elasticsearch -r config.json

I am not sure how to add unit test for cli.js
Try to using const { spawn } = require('child_process');
but fail to mock lib module

Why would you need to mock lib?

don't worry about the tests, there are none for the CLI

Waiting for @delvedor (who works for Elastic)


Initialization of opaque fields with unknown size

Context and Problem Statement
Currently the only way to initialize opaque fields in the spec is to either use a static aggregate or a function.  While the static aggregate works well when the size is known sometimes it's required to zero-initialize an opaque field whose size is not known statically. In this case the only way to initialize this field is by using a function.
Use Cases
Zero-initialization of fields with a dynamic size that are modified later (e.g. a signature or hash).
Considered Options
O1
Using others to match whatever size the opaque field has with a static value.
Opaque_Field := [others => 0];

+  Close to Ada syntax
+ Allows custom values for all bytes
− Only allows a single value for all bytes
O2
Using a range assignment:
Opaque_Field := [1 .. Opaque_Field_Length => 0];

+ Close to Ada syntax
+ More flexible in terms of different initial values for different ranges
− Always requires the length to be known via a variable
O3
Using an reset aspect:
Opaque_Field'Reset (Opaque_Field_Length, 0);

+ Consistent to other Reset aspects such as for messages and sequences
− Less flexible as it only allows a single value to be set
− Always requires the length to be known via a variable
Decision Outcome
O1

@jklmnn Would you allow multiple ranges in O2? If so, could please you add an example for that? In that case, a drawback would also be additional checks necessary to ensure non-overlap.

I updated the comment.


Adding configuration option

Please test the change that I have made and let me know if there is an issue.


Handle if access token is expired

If the access token is expired when creating a sync connection, we should automatically fetch a new one just like for normal Auth requests.
If the access token expired the server will respond with http status code 401 and a specific json error code:
json.error_code == 'InvalidSession'

See https://mongodb.slack.com/archives/CQLDYRJ3V/p1588371058121300

Moved to https://github.com/realm/realm-core/issues/4193


Probably need to buffer the data loads

Large inventories may break things. Can probably copy the intersphinx approach to it.

Obsoleted


An asp-route should convert kebab case to camelcase

Describe the bug
An action parameter by default is camelCased, but HTML attributes use kebab-case. When I use asp-route-my-variable, it does not bind it to myVariable parameter.
To Reproduce
Controller action:
public IActionResult MyAction(string myVariable) {
  return Content(myVariable);
}

MyAction.cshtml:
Link

Expected behavior
It should set the parameter correctly.

That's by design, that is not how the asp-route-* tag helper works. What you put after asp-route- is interpreted as the route parameter, that should match what you define on the route within {} and gets bound to the variable on the method.
You can use {my-variable} in your route parameter definition and [FromRoute(Name = "my-variable")] to make it bind to myVariable.


Review: Integration Tests » Fake Embeddings » ConsistentFakeEmbeddings.embed_query

https://github.com/crate-workbench/langchain/blob/8b278a8a7551f8baea085a331587525ca499bc6f/libs/langchain/tests/integration_tests/cache/fake_embeddings.py#L53-L60
This spot has been resolved differently. We will need to check if that will be fine. Otherwise, we will need to use the previous code on behalf of a separate FakeEmbeddings fixture.

https://github.com/langchain-ai/langchain/pull/13654#issuecomment-1839809360
https://github.com/langchain-ai/langchain/pull/14256

Originally posted by @amotl in https://github.com/crate-workbench/langchain/pull/1#discussion_r1458033675
/cc @kneth

If the patch still needs those adjustments outlined at https://github.com/crate-workbench/langchain/pull/1#pullrequestreview-1830642519, and I guess it will, they will need to be vendorized before submitting this patch to upstream LangChain.

Just reviewing the code base vs. the patch, and where the adjustment is located at libs/langchain/tests/integration_tests/cache/fake_embeddings.py in langchain-core, and not finding any references to it from our code on a quick search, I think indeed it is a relic of the past, and is probably not needed any longer.
Instead, test_cratedb.py imports ConsistentFakeEmbeddings from tests.integration_tests.vectorstores.fake_embeddings in langchain-community.
from tests.integration_tests.vectorstores.fake_embeddings import (
    ConsistentFakeEmbeddings,
    FakeEmbeddings,
)

That code looks like this:
https://github.com/crate-workbench/langchain/blob/6d524e9566bbb4d2592175ebf87faec9469eb8f1/libs/community/tests/integration_tests/vectorstores/fake_embeddings.py#L33-L56

Hm. Checking where our change is coming from, it is 9dfc828266ba9.
Indeed, in current LangChain, there are two folders that include a fake_embeddings.py file, in turn including a ConsistentFakeEmbeddings. At least, their implementation is the same in upstream LangChain.

langchain-core: https://github.com/langchain-ai/langchain/blob/6d524e9566bbb4d2592175ebf87faec9469eb8f1/libs/langchain/tests/integration_tests/cache/fake_embeddings.py

langchain-community: https://github.com/langchain-ai/langchain/blob/6d524e9566bbb4d2592175ebf87faec9469eb8f1/libs/community/tests/integration_tests/cache/fake_embeddings.py

We can see that some integration tests use vanilla FakeEmbeddings, and others are providing their custom ones. In this spirit, I think it will be good enough to provide our custom ones.

https://github.com/langchain-ai/langchain/blob/6d524e9566bbb4d2592175ebf87faec9469eb8f1/libs/community/tests/integration_tests/vectorstores/test_clickhouse.py#L6

https://github.com/langchain-ai/langchain/blob/6d524e9566bbb4d2592175ebf87faec9469eb8f1/libs/community/tests/integration_tests/vectorstores/test_duckdb.py#L8

https://github.com/langchain-ai/langchain/blob/6d524e9566bbb4d2592175ebf87faec9469eb8f1/libs/community/tests/integration_tests/vectorstores/test_astradb.py#L28-L81

https://github.com/langchain-ai/langchain/blob/6d524e9566bbb4d2592175ebf87faec9469eb8f1/libs/partners/chroma/tests/integration_tests/fake_embeddings.py#L33-L56

I haven't been able to spot any regressions in running the test cases after removing the code in question with 41f646270bcd. Integration tests in both langchain-core and langchain-community still succeed.


x/build: MacStadium macOS builders at reduced capacity

After some mandatory maintenance, a portion of the MacStadium builders did not come back after their host was rebooted, and as a result their capacity is reduced right now. This is the tracking issue to get them all online again.
Status is visible at https://farmer.golang.org/status/macs.
CC @golang/release.

A hardware failure occurred while maintenance was being performed. The MacStadium amd64 macOS builders will not be available until the hardware is replaced and reconfigured.

This is resolved now, and https://farmer.golang.org/status/macs reports "ok". Closing.
(Thanks Carlos who did most of the work here.)


Update iOS Safari browser versions for Symbol

Based on https://kangax.github.io/compat-table/es6/ iOS 10 has full support for Symbol and iOS 9 only needs the well-known Symbols e.g. Symbol.iterator - not Symbol itself.
This is the error I'm seeing on https://qa.polyfill.io/v2/.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Jon Bretman seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@jonbretman Thanks for the PR! Checking the compatibility charts, ios 9 might need the symbol polyfill because the native version doesn't ignore symbol primitives when calling JSON.stringify. Before we could accept your work into the project, we ask that you read and sign our contributor license agreement.

@JakeChampion - signed. I saw the JSON.stringify thing but I didn't see anything in the polyfill that explicitly supports that, or is it to toString implementation that handles this? If so are there tests covering this?

@jonbretman No tests covering this, the toString implementation is there to cater for that part of the specification

@JakeChampion ok I've updated Symbol to be < 10.

@jonbretman It looks like you made the commits with an email address which isn't linked to your github account, would you be able to link those two together?

@JakeChampion done.

Thanks for the PR!
Did you know we offer one month's free premium access to all FT content (normally $50) to anyone who has a pull request merged in this repository? If you want to claim it, there's one Google form to fill out :-)

@JakeChampion ah yes I forgot about that. Done, thanks 😄


Insert empty expression if last node in statement block is an expresison

This allows us to control whether the statement block should "return" a value or not.

Codecov Report

Merging #259 (1fefd06) into main (df2d246) will increase coverage by 0.32%.
The diff coverage is 100.00%.

:exclamation: Current head 1fefd06 differs from pull request most recent head 1491ac4. Consider uploading reports for the commit 1491ac4 to get more accurate results

@@            Coverage Diff             @@
##             main     #259      +/-   ##
==========================================
+ Coverage   92.52%   92.84%   +0.32%
==========================================
  Files          37       37
  Lines        5044     5062      +18
==========================================
+ Hits         4667     4700      +33
+ Misses        377      362      -15

Impacted Files
Coverage Δ

crates/crochet_tree_sitter_parser/src/lib.rs
95.94% <100.00%> (+2.29%)
:arrow_up:

crates/crochet_types/src/type.rs
80.95% <0.00%> (-1.91%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Link documented package code in notebooks to Docs

Hiya,
Thanks for this awesome utility! I've really enjoyed it using it in my projects :)
I was wondering if it's possible to automagically link imports (or function calls/objects) from the documented library in notebook code cells to the standard sphinx API documentation. I think it would be really nice for users reading documentation notebooks so they can flip back and forth between the notebook and the documentation.
I see this is possible by using raw cells in reST format. Is there any easy way to force nbsphinx to do this conversion or do I have to change this within the notebooks?

Solved with https://github.com/felix-hilden/sphinx-codeautolink


How do I open/close tabs?

ctrl+n no longer opens a new tab and ctrl+w no longer closes the current tab.
How can I either pass-through these shortcuts to sublime to get original behavior, or achieve the same with vim key bindings?
Update: ctrl+f4 closes tab.

:q and :e and :vspl also don't work for this either.

I do detect when a new buffer unexpectedly appears on the vim side so it might be easy to map that to opening a tab. My answer personally is that ActualVim is very nice on mac where the hotkeys don't overlap.
Another option is for me to expose Sublime commands generically to vim and recommend mapping ^N to new tab while in command mode (which won't conflict with the insert mode autocomplete). I think this is the best option.

Most other editors I use vim extensions with (Visual Studio, VS Code) that are not using neovim offer a way to disable certain vim key bindings - in order to pass the key combination down to the editor instead and let it do it's default thing. I think this is the better solution, but I'm not sure how neovim supports this scenario.

Okay, here's how I'd do that:
ActualVim user settings allow easily changing view settings based on the Vim mode.
Sublime keymaps can be disabled based on view settings.
So: I can add a context to each keymap (i.e. ctrl-c) like not av_host_ctrl_c, then you can toggle these hotkeys for every Vim mode, or for specific Vim modes by putting av_host_ctrl_c=true in your config.

That sounds like a good solution to me; to be able to skip neovim for certain key combinations (ctrl+c, ctrl+shift+n etc) for one or more vim modes (normal, insert, visual).

Fixed in 0.9.12, which adds this setting and on non-osx hosts disables ^N and ^W passthrough.


Added storage monitoring Jenkins job

This addresses Storage Monitoring Jenkins job

Implemented storage monitoring job for linux, aix, and mac
Updated the readme to reflect the new Jenkins job

@AdamBrousseau are you happy with the PR now?


Added norwegian layout

Thank you for the contribution @prakriti89 !
The Norwegian layout is now live as of version 1.15.78.
https://github.com/simple-keyboard/simple-keyboard-layouts#-supported-layouts
https://hodgef.com/simple-keyboard/demos/?d=norwegian
Regards,
Francisco Hodge


non-associative intersections ( (A&B)&C is different from A&(B&C) )

I would expect type intersections to be associative, like set intersections, but sometimes they are not. This came up in real code, using type aliases rather than parentheses.
The gist of it is is that
type Props = A & B & C;  // or (A & B) & C;

typechecks, while
type BC = B & C;
type Props = A & BC;  // or A & (B & C);

does not.
I was able to isolate the problematic code enough to reproduce in the sandbox, with v0.77.
I expect the example can be minimized a little further (particularly the part extracted from flow-typed), but I wanted to double check that this really is a bug before spending more time on it. Here is the same example from the sandbox for your convenience:
/* @flow */
import React, { Component } from 'react';
import type { ComponentType, ElementConfig } from 'react';

type Dispatch<A> = any;
type Store = Object;
// START CUT From flow-typed react-redux-v5.x.x.js

  declare type MapStateToProps<S: Object, SP: Object, RSP: Object> = (state: S, props: SP) => RSP;

  declare type MapDispatchToProps<A, OP: Object, RDP: Object> = (dispatch: Dispatch<A>, ownProps: OP) => RDP;
  declare type OmitDispatch<Component> = $Diff<Component, {dispatch: Dispatch<*>}>;

declare export function connect<
    Com: ComponentType<*>,
    S: Object,
    DP: Object,
    RSP: Object,
    CP: $Diff<OmitDispatch<ElementConfig<Com>>, RSP>
    >(
    mapStateToProps: MapStateToProps<S, DP, RSP>,
    mapDispatchToProps?: null
  ): (component: Com) => ComponentType<CP & DP>;

// END   CUT From flow-typed react-redux-v5.x.x.js

type Foo = { boo: boolean };

type A = { a: Foo };
type B = { b: string };
type C = { c: string };

// Both of these typecheck:
//type Props = A & B & C;
//type Props = (A & B) & C;

// But these do not:
type Props = A & (B & C);
//type BC = B & C; type Props = A & BC;

export const Container = connect(
  (a: A): A => a
)(
  (props: Props) => null
)

I believe this is a more concise example of the issue:
// @flow

type A = {| foo: number | string |};
type B = {| foo: number | string |};
type C = {| foo: number | string |};

const d: $Diff<A, B> = {...null};
const e: $Diff<A & B, B> = {...null};
const f: $Diff<A & B, A & B> = {...null};
const g: $Diff<A & B, A & C> = {...null}; // should not error.

try flow


New Rule: shorter object syntax in arrow function (ES6)

No idea what the name for this is, but can have both rules.
// bad
  [1, 2, 3].map((x) => {
    return { number: x };
  });

// good
  [1, 2, 3].map((x) => ({ number: x });

an example from http://tc39wiki.calculist.org/es6/arrow-functions/
// Parenthesize the body to return an object literal expression
let key_maker = val => ({key: val});

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/15536329-new-rule-shorter-object-syntax-in-arrow-function-es6?utm_campaign=plugin&utm_content=tracker%2F281640&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F281640&utm_medium=issues&utm_source=github).

Do you only want to disallow the return statement when returning an object or in all single expression arrow functions? I.e something like
// bad
x => {return 42;}

// good
x => 42

Name suggestion for the second case: disallowReturnInSingleExpressionArrowFunctions Does this win the price of the longest rule name so far? ;-)

(require|disallow)ImplicitReturn or the same with InArrowFunction for
specificity (if necessary)?
On May 17, 2015 6:25 PM, "Alexander Zeilmann"<EMAIL_ADDRESS>wrote:

Do you only want to disallow the return statement when returning an object
or in all single expression arrow functions? I.e something like
// bad
x => {return 42;}
// good
x => 42
Name suggestion for the second case:
disallowReturnInSingleExpressionArrowFunctions Does this win the price of
the longest rule name so far? ;-)
—
Reply to this email directly or view it on GitHub
https://github.com/jscs-dev/node-jscs/issues/1385#issuecomment-102864918
.

Related to #1340 - requireShorthandArrowFunctions
// good
evens.map(v => v + 1);
// bad
evens.map(v => { return v + 1; });

This is specifically for returning a single object.
Actually maybe we should just merge it into a single rule.

Whatever you end up with, I'd want to be able to configure rules so that I could:

allow implicit return of non-object-literals
disallow implicit return of paren-wrapped object literals
disallow implicit return of blocks with labelled statements

and, potentially, disallow implicit return entirely, or, allow implicit return entirely. (in case that helps make "picking a rule name" harder :-) )

Could some of those options could become their own rules? Or only apply within arrow functions?
Maybe we should have a disallowLabelStatments rule.. - (had to look at up haha).

We absolutely should. Those should only be used intentionally imo, and that's what linters should catch :-)

We released 3.0 recently! We also wrote a post about how 3.0 will be our last major release (since we are deprecating the project) and that we are merging with ESLint!
Thus we won't be working on any new features moving forward which includes new rules/options. We will continue to fix bugs and work on CST/better autofixing for current rules in the upcoming months both to help JSCS users and to gain experience that we can hopefully use in ESLint. But otherwise we both teams will be working on getting ESLint feature parity with JSCS and just a nice transition for our users.
I'm putting an orphaned label to note this issue isn't planned to be worked on, but might be a good contribution as a custom rule (not in JSCS core itself).
I would encourage anyone who wants the rule to try writing it themselves: I would either write a custom rule or submit an issue to ESLint and if accepted a PR. Otherwise a custom rule that won't be in core repo itself.
JSCS rules are also very similar to ESLint rules: here are some resources to get started:

Project-specific Lint Rules with ESLint
Creating Custom Rules for ESLint
Maintaining JavaScript Code Quality with ESLint


Fix typo in co-author example

This commit fixes a typo in the co-author example in the creating-a-commit-with-multiple-authors.md documentation. The original line was:
Co-authored-by: AUTHOR-NAME<EMAIL_ADDRESS>The corrected line is:
Co-authored-by: ANOTHER-NAME<EMAIL_ADDRESS>This change ensures that both examples follow the same format and maintain consistency to avoid confusion.

Why:
This commit fixes a typo in the co-author example of creating-a-commit-with-multiple-authors.md documentation. The change ensures that both examples follow the same format and maintain consistency to avoid confusion.
Closes:

What's being changed (if available, include any code snippets, screenshots, or gifs):
The original line was: Co-authored-by: AUTHOR-NAME<EMAIL_ADDRESS>The modified line is: Co-authored-by: ANOTHER-NAME<EMAIL_ADDRESS>
Check off the following:

[x] I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
[x] For content changes, I have completed the self-review checklist.

@subeom7 Thanks so much for opening a PR! I'll get this triaged for review :zap:


Add Ukrainian Language Translate

What kind of changes does this PR include?

Changes to Starlight code

Description

Adds Ukrainian language support

Btw, as I’m guessing it could take some time to review all these translations, I cherry-picked your original commit to https://github.com/withastro/starlight/pull/891, so we can release it and people can start using it 🎉

Hey @Frikadellios — are you still interested in working on this? I’ve applied all the quick fixes I suggested, but there are still a few changes and something is breaking the builds.

Hey again @Frikadellios — thanks again for this PR. I will close it for now as it is starting to get out of date. If anyone is interested in reviving it, please do feel free — would love to make these translations available if we can!


Make EditorSpinSlider wait for idle_frame to update text on key_up/down

Fixes #54287. This ensures that the text is up to date with any setters that may modify the value.

Thanks!

Cherry-picked for 3.5.


Time range image is wrong, it shows the ResultCode instead of the TimeGenerated

Time range image is wrong, it shows the ResultCode instead of the TimeGenerated.
( ResultCode is duplicated )

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9a7fbec9-98e3-15e5-8a64-c8af022d9283
Version Independent ID: fde9de60-b8ca-3c20-443e-adc4d0177bca
Content: Log Analytics tutorial - Azure Monitor
Content Source: articles/azure-monitor/logs/log-analytics-tutorial.md
Service: azure-monitor
Sub-service: logs
GitHub Login: @guywi-ms
Microsoft Alias: guywild

@oliviomoura Thanks for your feedback.
Assigning to content author @guywi-ms  for review.

@oliviomoura Thanks for your feedback! We've submitted a documentation change based on your suggestion, and the updated article should be live by tomorrow. Please let us know if there's anything more we can do for you. To follow up on this issue, leave us a comment with an @mention.
#please-close


Install as a 64 Bit Service

Hi, we have been using Topshelf 3.3.1 and recently due to increased activity noticed OutOfMemory Exceptions taking place. This has led to some bugs being caught but also we noticed that TopShelf runs as a 32 bit service. From the documentation I can't see how we force it to install as a 64 bit service, is this supported?

That's entirely based on how you create your console application. If your console application is a 64-bit process, it will run the service as a 64-bit process. Topshelf is just an assembly that supports AnyCPU.
Check your build configurations and make sure you're building a 64-bit exe from Visual Studio.

I verified that our services are indeed built and running as 64-bit, so it's likely your project settings.

Yes thanks for the clarification, I resolved this a few hours ago with a build target.
Thanks again, working as expected.
Just a comment but it would be nice to hint at it in the documentation, it's probably clear to most :) but it was the first place I checked.
Thanks again.


Add django-debug-toolbar fixes #185

Yeah sure.
Basically if DEBUG is on and the user is a super user (in the database) it will show this toolbar. So just for local and non-prod. The toolbar displays a lot of useful information for debugging purposes. It won't even be loaded at all in production. I'm also looking at some additional extensions to help aid more in debugging.


If no API key configured, let users provide one

A pattern I like for this is storing the user's API key in localstorage in their browser and sending it each time it's needed - but avoiding storing it on the server or in any log files anywhere, so I don't need to worry that a breach of my application could leak other people's API keys.
I built a simple tool that does that here: https://tools.simonwillison.net/haiku - code here: https://github.com/simonw/tools/blob/baebe5777294e4ecb5a482aca4919be214132024/haiku.html#L139
function getApiKey() {
  let apiKey = localStorage.getItem("ANTHROPIC_API_KEY");
  if (!apiKey) {
    apiKey = prompt("Please enter your Anthropic API key:");
    if (apiKey) {
      localStorage.setItem("ANTHROPIC_API_KEY", apiKey);
    }
  }
  return apiKey;
}

Using localstorage could be a simple way to support persisting user's previous image uploads and form generations as well - then there's no need to store anything server-side.

Lovely idea - thanks @simonw :-)


Drop pointer for cluster name fields

What changed?

Why?

How did you test it?

Potential risks

Coverage increased (+0.005%) to 61.677% when pulling 6446e0f1ac753c3f359462c96b1094a6a4e5eac7 on vytautas-karpavicius:drop-ptr-cluster-name into b32559a1a5f29859fc930458afca00a9a7d7e946 on uber:master.

Coverage increased (+0.005%) to 61.677% when pulling 6446e0f1ac753c3f359462c96b1094a6a4e5eac7 on vytautas-karpavicius:drop-ptr-cluster-name into b32559a1a5f29859fc930458afca00a9a7d7e946 on uber:master.


How to enable debug

We are wanting to use this software to extend our monitoring to our ECS services, but havent been able to get it to work.  We would love a way to enable the debug logging, so we can try to see whats going on.
A few notes, Im running it locally, so it does not have any network access to these actual services, I assume thats fine.  We do use govcloud, which maybe is an issue?
services:
  ecs:
    image: apptality/aws-ecs-cloudmap-prometheus-discovery:latest
    ports:
      - "9001:9001"
    environment:
      DiscoveryOptions__EcsClusters: "ecs-dev;"
      AWS_REGION: "us-gov-west-1"
      AWS_ACCESS_KEY_ID: "xxxxxx"
      AWS_SECRET_ACCESS_KEY: "xxxxxx"
      DiscoveryOptions__EcsTaskTags: "*"
      DiscoveryOptions__EcsServiceTags: "*"
      ASPNETCORE_URLS: "http://*:9001"
    healthcheck:
      test: curl --fail http://localhost:9001/health || exit 1
      interval: 40s
      timeout: 30s
      retries: 3
      start_period: 5s
    networks:
      - ecs
networks:
  ecs:
    name: ecs

❯ docker compose up                                                                                │
[+] Running 1/1                                                                                │~ [🐳 desktop-linux]took 3s
 ✔ Container justin-ecs-1  Recreated                                                                              0.2s │❯ curl http://localhost:9001/prometheus-targets
Attaching to ecs-1                                                                                │[]%
ecs-1  | 2024-10-17 19:06:35.400 +00:00 [INF] Started 'ECS Prometheus Discovery' application                           │
ecs-1  | 2024-10-17 19:06:41.375 +00:00 [INF] Found credentials using the AWS SDK's default credential search          │~ [🐳 desktop-linux]took 2s
ecs-1  | 2024-10-17 19:06:41.386 +00:00 [INF] Found credentials using the AWS SDK's default credential search          │❯ curl http://localhost:9001/prometheus-targets
ecs-1  | 2024-10-17 19:06:44.604 +00:00 [INF] HTTP GET /prometheus-targets responded 200 in 3238.5394 ms

curl http://localhost:9001/prometheus-targets
[]%

So its def. doing something, but the cluster listed has like 20+ services in it, so I would hope to see something.
Thanks.

I was able to get debug logs but in order to do so I had to get to shell of the container as root so that I could edit appsettings.json. The environment variables are not making into that file.
I changed "EcsClusters": "", to "EcsClusters": "ecs-dev", and changed the log levels to Debug. Then I restarted ./CloudMapEcsPrometheusDiscovery.
When I curl /prometheus-targets, I can see in the debug logs that it is discovering the ECS tasks as expected.
But the response is empty.
Is there additional configuration to be done?
In the logs it will list the full descriptions of everything it finds and then say:
2024-10-17 20:36:31.050 +00:00 [DBG] CloudMap namespaces fetched and cached
2024-10-17 20:36:31.054 +00:00 [INF] Setting HTTP status code 200.
2024-10-17 20:36:31.057 +00:00 [INF] Writing value of type 'PrometheusResponse' as Json.
2024-10-17 20:36:31.058 +00:00 [INF] Executed endpoint 'HTTP: GET /prometheus-targets'

The response from curl is [].

@jseiser @d141
In order to put everything into debug mode you have to set the following environment variable:
Serilog__MinimumLevel__Default to "Debug".
Also, you might want/need to override some additional libraries defined under "Serilog" configure section.
This might seem counter-intuitive, but configuration is very idiomatic to .NET ecosystem. You can read more on logging and supported levels here. Long story short - to avoid 'debug' noise you can enable particular level of debugging per each library used in the application (technically, library namespace).

Let me know if the above suggestions worked, or whether you need additional help with it.

@jseiser by looking at your configuration and considering it takes 3238.5394ms to respond - it looks like it's doing something. Just want to confirm - do your services or tasks definitions have at the very least METRICS_PORT tag set? These are crucial for determining discovery scrape targets. If not - please look at documentation for MetricsPathPortTagPrefix parameter.

Following up on the above.
I was able to get debug logs but in order to do so I had to get to shell of the container as root so that I could edit appsettings.json. The environment variables are not making into that file.
I changed "EcsClusters": "", to "EcsClusters": "ecs-dev", and changed the log levels to Debug. Then I restarted ./CloudMapEcsPrometheusDiscovery.
When I curl /prometheus-targets, I can see in the debug logs that it is discovering the ECS tasks as expected.
But the response is empty.
Is there additional configuration to be done?
In the logs it will list the full descriptions of everything it finds and then say:
2024-10-17 20:36:31.050 +00:00 [DBG] CloudMap namespaces fetched and cached
2024-10-17 20:36:31.054 +00:00 [INF] Setting HTTP status code 200.
2024-10-17 20:36:31.057 +00:00 [INF] Writing value of type 'PrometheusResponse' as Json.
2024-10-17 20:36:31.058 +00:00 [INF] Executed endpoint 'HTTP: GET /prometheus-targets'

The response from curl is [].

I recently used it and it was a great solution for my ECS monitoring needs.
Regarding the reason why the returned data is [], I found that it is because there is no METRIX-related tag on the service or task.
Only services with tags will be returned in the results


image: fix keyboard events handling logic

Please make sure these boxes are checked before submitting your PR, thank you!

[x] Make sure you follow Element's contributing guide (中文 | English | Español | Français).
[x] Make sure you are merging your commits to dev branch.
[x] Add some descriptions and refer relative issues for you PR.

close #18393

main.vue line 221, manipulating document.body.style directly is not good, and events may propagate to a parent which are not body element, and still cause scrolling, so I use e.stopPropagation() on key events to stop scrolling instead of #16997.

image-viewer.vue line 295:

mounted() {
  this.deviceSupportInstall();
  this.$refs['el-image-viewer__wrapper'].focus();
}

the mounted function only called once, cause reopen the image-viewer, all keyboard events and mouse scale events are not allowed. so add an prop 'visible' to solve this case.

@luckyCao

@luckyCao This resolves https://github.com/ElemeFE/element/issues/18234

#19075

@Mookiepiece this pr can't prevent body scroll

@luckyCao oh sorry, I should use preventDeafult instead

whatever, welcome back~❤

already fixed by others. 2.13.1


Create Sudoku

To Do:

[ ] Logic for game difficulties
[ ] Pick difficulty mode before seeing puzzle?
[ ] Hide number in list once all have been found
[ ] Track remaining numbers left
[ ] Score calculation?
[ ] Timer
[ ] Hints / hint logic per difficulty?


Optimizing RAM Usage: lgb.Dataset Creation from CSV by columns

Is there a way to generate an lgb.Dataset by reading a file column-wise? I don't think so, but I'm not sure why this functionality doesn't exist. Dataset creation is a bottleneck that prevents us from utilizing all the RAM. Once the bins for each variable are created, especially if there are few like in my case (around 25 numeric values per variable), the dataset size is drastically reduced. However, to achieve this, we need to load the data into RAM, typically from a disk file, and this intermediate step consumes several times the RAM required by the lgb.Dataset. In practice, if we have X RAM, we can only use X/2 or even less. Would it not be possible to read a CSV where each row contains the data for one column, perform binning, and sequentially free up the RAM? Is there any other alternative to fully utilize all the RAM?

Hey @jaguerrerod, thanks for using LightGBM. You can create single column datasets one at a time and add them to your full dataset. Here's an example:
import lightgbm as lgb
from sklearn.datasets import make_regression

X, y = make_regression(n_features=5)
# create dataset with single column and target
ds = lgb.Dataset(X[:, [0]], y, feature_name=['x0']).construct()
# add the rest of the columns, these can be read from a file one at a time
for j in range(1, X.shape[1]):
    ds.add_features_from(lgb.Dataset(X[:, [j]], feature_name=[f'x{j+1}']).construct())
print(ds.num_feature())
# 5

Please let us know if you have further doubts.

Great, Thank you!
Do it works in R? If not, Could I construct the dataset in python, save it and load from R?

I think the R package doesn't have that feature (I looked for calls to LGBM_DatasetAddFeaturesFrom in R's Dataset and didn't find any), but you should be able to save it from Python and load it in R.

It would be great to have this in the R interface, but at least using Python to generate the dataset incrementally is a workaround. Thank you.

would be great to have this in the R interface

Would you like to contribute that? We'd welcome the help.

Unfortunately, I lack knowledge of C++ for this task. I could offer a reward if someone is willing to do the work for me, but I am unaware of where to post such a request. If anyone interested contacts me, we can discuss it further, and of course, it would be for incorporation into the master and sharing it with the community.

No problem, thanks anyway for considering it.


Fixes for 2023.12 tests

Functions to prioritize:

unstack (new in NumPy)
clip (has a lot of corner cases)

I've got one question: Inspection functions shouldn't be in the main namespace but only in the __array_namespace_info__ namespace, as described in the standard (https://data-apis.org/array-api/latest/API_specification/inspection.html#inspection-apis), right?

Yes, that's right.

We still need a lot more test updates for 2023, but I'm going to merge this to make it easier for people to use.


ci(cypress): Add billing address for bank redirects

Type of Change

[ ] Bugfix
[ ] New feature
[x] Enhancement
[ ] Refactoring
[ ] Dependency updates
[ ] Documentation
[x] CI/CD

Description
Added billing address for bank redirects and bank transfers in connector.js
Additional Changes

[ ] This PR modifies the API contract
[ ] This PR modifies the database schema
[ ] This PR modifies application configuration/environment variables

Motivation and Context
Cypress tests were failing bank redirects and bank transfers
How did you test it?
Ran Cypress

Stripe

Adyen

Checklist

[ ] I formatted the code cargo +nightly fmt --all
[ ] I addressed lints thrown by cargo clippy
[x] I reviewed the submitted code
[ ] I added unit tests for my changes where possible

also, apply the corresponding changes to bank transfers and bank debits (if fails)


Generated code does not compile: "cannot convert nil to"

I generated the Go client, and after a success generation my project doesn't compile. The reason is "cannot convert nil to ..."
    "PlatformGatewaysResponse" : {
      "type" : "object",
      "properties" : {
        "gateways" : {
          "type" : "object",
          "additionalProperties" : {
            "type" : "array",
            "uniqueItems" : true,
            "items" : {
              "$ref" : "#/definitions/CloudGatewayJson"
            }
          }
        }
      }
    },

    "CloudGatewayJson" : {
      "type" : "object",
      "properties" : {
        "name" : {
          "type" : "string"
        },
        "id" : {
          "type" : "string"
        },
        "properties" : {
          "type" : "object",
          "additionalProperties" : {
            "type" : "object"
          }
        }
      }
    },

The full source JSON is found here.
The compile errors is the following:
platform_gateways_response.go:70:24: cannot convert nil to type CloudGatewayJSON

And the generated code is:
func (m *PlatformGatewaysResponse) validateGateways(formats strfmt.Registry) error {
	...
	for k := range m.Gateways {
		...
		for i := 0; i < len(m.Gateways[k]); i++ {
			...
			if m.Gateways[k][i] != nil { // cannot convert nil to

				if err := m.Gateways[k][i].Validate(formats); err != nil {
					if ve, ok := err.(*errors.Validation); ok {
						return ve.ValidateName("gateways" + "." + k + "." + strconv.Itoa(i))
					}
					return err

Environment
swagger version: 0.12.0
go version: go version go1.9 darwin/amd64
OS: macOS Sierra and High Sierra

@mhmxs  : Has JSON swagger spec that you shared in above issue has changed from the time you shared it?
Everything seems to be passing now
taggarwal@taggarwal-m01  ~/go/src/github.com/test-swagger  ls
total 0
drwxr-xr-x   23 taggarwal  vmware   782 Oct 10 14:04 ..
drwxr-xr-x    6 taggarwal  vmware   204 Oct 10 14:08 .idea
drwx------  200 taggarwal  vmware  6800 Oct 10 14:10 models
drwxr-xr-x    5 taggarwal  vmware   170 Oct 10 14:10 .
drwx------   26 taggarwal  vmware   884 Oct 10 14:10 client
 taggarwal@taggarwal-m01  ~/go/src/github.com/test-swagger  go test ./...
?   	github.com/test-swagger/client	[no test files]
?   	github.com/test-swagger/client/accountpreferences	[no test files]
?   	github.com/test-swagger/client/blueprints	[no test files]
?   	github.com/test-swagger/client/cluster	[no test files]
?   	github.com/test-swagger/client/clustertemplates	[no test files]
?   	github.com/test-swagger/client/connectors	[no test files]
?   	github.com/test-swagger/client/constraints	[no test files]
?   	github.com/test-swagger/client/credentials	[no test files]
?   	github.com/test-swagger/client/events	[no test files]
?   	github.com/test-swagger/client/flexsubscriptions	[no test files]
?   	github.com/test-swagger/client/ldap	[no test files]
?   	github.com/test-swagger/client/networks	[no test files]
?   	github.com/test-swagger/client/rdsconfigs	[no test files]
?   	github.com/test-swagger/client/recipes	[no test files]
?   	github.com/test-swagger/client/securitygroups	[no test files]
?   	github.com/test-swagger/client/settings	[no test files]
?   	github.com/test-swagger/client/smartsensesubscriptions	[no test files]
?   	github.com/test-swagger/client/stacks	[no test files]
?   	github.com/test-swagger/client/subscriptions	[no test files]
?   	github.com/test-swagger/client/templates	[no test files]
?   	github.com/test-swagger/client/topologies	[no test files]
?   	github.com/test-swagger/client/usages	[no test files]
?   	github.com/test-swagger/client/users	[no test files]
?   	github.com/test-swagger/client/util	[no test files]
?   	github.com/test-swagger/models	[no test files]
 taggarwal@taggarwal-m01  ~/go/src/github.com/test-swagger 

Hi @EleanorRigby ,
Thank you for the super fast reply, and glad to read it is already solved. We are waiting for the next official release like messiah :).

I'll bump the release version next week


[SPARK-7705][Yarn] Cleanup of .sparkStaging directory fails if application is killed

As I have tested, if we cancel or kill the app then the final status may be undefined, killed or succeeded, so clean up staging directory when appMaster exit at any final application status.

Merged build triggered.

Merged build started.

@vanzin any reason not to clean this up on a failure? is it supposed to stick around for retries or for debugging?

Test build #33514 has started for   PR 6409 at commit 95595c3.

Correct,  you can't clean it up as the yarn RM can attempt to retry your application (configurable number of times).

Can you please describe what happens in more detail in this case?   What does the RM ui show the application status as?

Test build #33514 has finished for   PR 6409 at commit 95595c3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33514/
Test PASSed.

Merged build finished. Test PASSed.

As Tom says, this change might break application retries. I think it's time to write a test so that people don't break that part of the code.
The test should set up max tries to two, force the first attempt to fail, and make sure the second succeeds (and that two attempts were run).
For this particular change, perhaps the right choice would be to relax the condition so that it also includes "KILLED" aside from "SUCCEEDED".

@tgravescs I have tested below:
max retried is defaule, use yarn -kill to kill application when application start running, run SparkPi with parameter 20000.
yarn-cluster:
YARN UI          AppMaster Log(add code to print the final status on ApplicationMaster.scala line 127)
KILLED            FAILED
yarn-client:
YARN UI          AppMaster Log
KILLED            UNDEFINED
@vanzin yes, this may break application retries, we need to consider more, and I will try.
@srowen @tgravescs @vanzin thank you.

Ok, so now I remember on this.  I intentionally didn't handle this case as its really hard to be able to cleanup in this case but still not cleanup when you want retries.  Note that MapReduce on yarn and others on yarn have this same issue.
The reason is because the way yarn kills you.  It first sends a sigterm, then waits 250ms (or configurable time) it sends sigkill.  The Application Master doesn't know why it was killed.  You could attempt to contact the RM to get the application status in the shutdown hook, but if you are using default timeout its very unlikely you will have time.  Really yarn needs a cleanup task that runs after the application master is killed but that isn't supported at this point.

Really yarn needs a cleanup task that runs after the application master is killed but that isn't supported at this point.

Yeah, that's too bad; in Spark we could have a best effort by adding some code to the launcher, to check if any clean up is needed after the app finishes. Not guaranteed since the launcher can go away, but still...

@tgravescs yes, if yarn do it is better,  but now it didn't, so as @vanzin said may be we can do it when launcher, thank you!

Merged build triggered.

Merged build started.

Test build #33795 has started for   PR 6409 at commit aed9f18.

Test build #33795 has finished for   PR 6409 at commit aed9f18.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Merged build triggered.

Merged build started.

Merged build triggered.

Merged build started.

Test build #33871 has started for   PR 6409 at commit b76a102.

Merged build finished. Test FAILed.

Test build #33871 timed out     for PR 6409 at commit b76a102     after a configured wait of 150m.

Merged build finished. Test FAILed.

Jenkins, retest this please.

Merged build triggered.

Merged build started.

Test build #33886 has started for   PR 6409 at commit b76a102.

Test build #33886 has finished for   PR 6409 at commit b76a102.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Merged build triggered.

Merged build started.

Test build #33950 has started for   PR 6409 at commit 0dd7c2d.

Test build #33950 has finished for   PR 6409 at commit 0dd7c2d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Merged build triggered.

Merged build started.

Test build #33973 has started for   PR 6409 at commit 923d44d.

Merged build triggered.

Merged build started.

Test build #33974 has started for   PR 6409 at commit 3a5a0a5.

Test build #33973 has finished for   PR 6409 at commit 923d44d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test build #33974 has finished for   PR 6409 at commit 3a5a0a5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Ok, last patch LGTM. I wonder if it's worth it to add KILLED to the condition here: https://github.com/apache/spark/blob/master/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala#L122
Even if YARN kills the app after a little while, there's a little bit of time for it to try to do a cleanup (in case the launcher is not around anymore).

Looks pretty good to me.

@vanzin I have tested again, and below is the result of final status when we use yarn to kill the application:
\      | YARN  UI | Driver Log | AppMaster Log
----------- |----------|------------|--------------

yarn-client
KILLED
KILLED
FAILED

yarn-cluster
KILLED

UNDEFINED

@Sephiroth-Lin does it hurt to cleanup on KILLED in ApplicationMaster though? we're trying to make more effort to clean up in this case.

@srowen @vanzin  This PR can cleanup correctly. I just mean without this PR even if we add KILLED status on ApplicationMaster to check, then it can not cleanup when then application is killed.


The CLI should always tell you the DOI of the resource it just created

When standing up a garden from scratch you need to make a pipeline, make a garden, and then link them together. Right now after creating a garden, the CLI doesn't tell you its ID. So to link the pipeline to the garden, you first need to go read through your data.json. Not fun.
Take care of this and any other cases like this.
Assumptions:

Per #140, gardens will get a DOI upon creation.
When you create a garden (or do any operation on a garden) there will be some text from the CLI telling you the DOI of the garden that just got created.

Acceptance Criteria
Given I am using the CLI when I create a garden, then the CLI prints out the DOI so I can use that in other commands.

If done before #140, it's acceptable to print out the UUID for the resource that was just created if it doesn't have a DOI by default.


remove "/app" from url, setup unit tests

@dbaq FYI, please run "grunt" and it will run the unit tests as well. Feel free to include unit tests for the modules you add/modify, I'll do the same whenever possible


nodePackages.bash-language-server: remove attribute

Description of changes
bash-language-server has been packaged outside of nodePackages in #317954, but not correctly removed from nodePackages.
Closes #319871

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@doronbehar i just saw the old bash-language-server had shellcheck in its path, we probably should keep it that way

I can confirm that this now builds for me with:
$ nix-shell -p nodePackages.bash-language-server -I nixpkgs='https://github.com/NyCodeGHG/nixpkgs/archive/1933c5e9e475eef4cab3e05e2368043a29980a9c.zip'

Thank you for the quick fix :)

Result of nixpkgs-review pr 319882 run on x86_64-linux 1

1 package built:

bash-language-server

Result of nixpkgs-review pr 319882 run on aarch64-linux 1

1 package built:

bash-language-server

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/error-alias-bash-language-server-is-still-in-node-packages-nix/47027/2

Sorry for the breakage and thanks for the quick fix :pray: . I thought that only node-packages.json needs to be edited and the automatic updater will take care of the rest.


Extend Fortran unit test to expose error in rank calculation

This is an extension of the unit test for the Fortran interface that exposes the faulty rank calculation which is supposed to be fixed by #17.
The Fortran unit test now crashes with the message:
ERROR: field 'testfield_i0' has rank 1 but field with rank 0 was passed

Sorry for the messy commit history due to some merge and rebase trouble.

Hi there, this is jenkins continuous integration...
Do you want me to verify this patch?

Cool, thank! Then that is a nice chance to try if jenkins testing works with pfunit. I will try to set it up.

Unfortunately, the test doesn't fail formally but just crashes due to the faulty rank check within Serialbox.

No worries, it is still a good test for the jenkins setup. I will have it by tomorrow, then we can merge your PRs.

launch jenkins

@jenkins-apn yes

launch jenkins

test this please

@jenkins-apn test this please

test this please

@havogt You have to be nicer with Jenkins :-)

it is the official command ;)

but still doesn't work.

@jenkins-apn ok to test

launch jenkins

@jenkins-apn test this please

finally...

I merged this PR already together with #17. Thanks again @chovyy!


bug: ion-slides swiper instance does not get re-initialized with angular ivy

Bug Report
Ionic version:

[x] 5.0.0-rc.2
Current behavior:
With angular ivy enabled (9.0.0-rc.12) ion-slides (specifically the swiper instance) does not get re-initialized after destroyed once and is therefore unusable afterwards.
Expected behavior:
Swiper instance gets re-initialized, ion-slides keep working.
Steps to reproduce:

clone sample app
npm i
ionic serve
open console
click on "Go to slides page"
click "Go to next slide" (working!)
click back button
click on "Go to slides page" again
"Go to next slide", "Go to previous slide" is broken
check console, unfold logged Swiper object -> destroyed: true

Related code:
A sample application via GitHub
Other information:
Removing the following line fixes the problem, but I don't think that its a solution to the problem.
https://github.com/ionic-team/ionic/blob/ae4e28969f1d7b3e41f16f4f70c6befdaca6118f/core/src/components/slides/slides.tsx#L153
Related: ngx-swiper-wrapper#226
As ionic is shipping the swiper directly embedded into the framework maybe it needs to be compiled with ngcc once.
Ionic info:
Ionic:

   Ionic CLI                     : 5.4.15 (/usr/local/lib/node_modules/ionic)
   Ionic Framework               : @ionic/angular 5.0.0-rc.2
   @angular-devkit/build-angular : 0.900.0-rc.12
   @angular-devkit/schematics    : 9.0.0-rc.12
   @angular/cli                  : 9.0.0-rc.12
   @ionic/angular-toolkit        : 2.1.2

Cordova:

   Cordova CLI       : 9.0.0<EMAIL_ADDRESS>   Cordova Platforms : ios 5.1.1
   Cordova Plugins   : cordova-plugin-ionic-keyboard 2.2.0, cordova-plugin-ionic-webview 4.1.3, (and 4 other plugins)

Utility:

   cordova-res : not installed
   native-run  : not installed

System:

   ios-deploy : 1.9.2
   ios-sim    : 8.0.2
   NodeJS     : v12.4.0 (/usr/local/bin/node)
   npm        : 6.11.3
   OS         : macOS Catalina
   Xcode      : Xcode 11.3.1 Build version 11C504

Thanks for the issue. I've been digging into this issue, and this behavior appears to be a bug in Angular 9. We are reaching out to the Angular team and will post an update here when we have it.
In the meantime, we recommend sticking with Angular 8.

Looks like there was a breaking change in Angular 9 that we missed 😄. I will mark this as a bug and provide an update here when I have more to share.

Can you try the following dev build and let me know if it resolves the issue? npm i<EMAIL_ADDRESS>

Hi @liamdebeasi !
ion-slides looks good now, the original issue has been resolved, but there are many new problems with other elements. For example ion-tab-bar is missing, ion-menu isn't working, ion-modal animation looks corrupted. I've tested on iOS.

Yeah I don't think my PR was the right solution. Going to try another approach.

Got same issue after upgrade to ionic5.0.0.
I've two sliders layout in two pages. However the first is fine, and the second, can't work by calling API, such as slideNext, etc.
Waiting for the fix....

so, what is the temp walkaround for this issue now?

Use Angular 8, or if you've already upgraded to Angular 9, disable Ivy.
https://angular.io/guide/ivy

@tetkosimi thanks

so, what is the temp walkaround for this issue now?

Use Angular 8, or if you've already upgraded to Angular 9, disable Ivy.
https://angular.io/guide/ivy

I am still experiencing this issue using 5.0.1 :)

Here is a workaround for this issue. Simply postpone the slider initialization with ngIf and the angular lifecycle.
my-component.html
<ion-slides *ngIf="didInit">

</ion-slides>

my-component.ts
@Component({
    templateUrl: 'my-component.html'
})
export class MyComponent implements AfterViewInit {
    public didInit: boolean = false;

    ngAfterViewInit() {
        this.didInit = true;
    }
}

Hi everyone,
We are still investigating how to properly fix this. I will post more here when I have another update. In the meantime feel free to use any of the workarounds provided in this thread.
Thanks!

We are facing the problem. Is there any new information on this issue?

I can also confirm this problem :) . Hopefully there will be a fix soon 🙏

Same problem. But I am so happy to see this problem here. :)

I think this is related also:
Versions:
Ionic: 5.0.5
Angular: 9.0.6
Capacitor: 1.5.1
Cap Android: 1.5.1
Cap iOS: 1.5.1
On Hybrid (iOS and Android) the slider instance is not callable, so it is not possible to call any method exposed from IonSlides
here some code:
Typescript
import { Component, OnInit, ViewChild, AfterViewInit } from '@angular/core';
import { uniqueId } from 'src/app/utils/utilities/ids';
import { Router } from '@angular/router';
import { Store, Select } from '@ngxs/store';
import { ToggleShowWizard } from '../../store/actions/common.action';
import { take } from 'rxjs/operators';
import { IonSlides } from '@ionic/angular';
import { Observable } from 'rxjs';
import { CommonStateInterfaceModel } from '../../store/states/common.state';

interface Slide {
  image: string;
  title: string;
  id: string;
  description?: string;
  button?: {
    label: string;
    cta: (bho?: any) => void;
    icon?: string;
  };
}

@Component({
  selector: 'app-wizard',
  templateUrl: './wizard.page.html',
  styleUrls: ['./wizard.page.scss']
})
export class WizardPage implements OnInit, AfterViewInit {
  public slides: Slide[];
  public index: number = 0;
  public wizard: IonSlides;
  public wizardOptions: any;
  @Select(state => state.common) common$: Observable<CommonStateInterfaceModel>;

  constructor(private router: Router, private store: Store) {
    const t = this;
    this.wizardOptions = {
      on: {
        beforeInit: function() {
          console.log(this.el);
          t.wizard = this.el;
        }
      }
    };
  }

  public async ngOnInit(): Promise<void> {
    const value = await this.common$.pipe(take(1)).toPromise();
    if (!value?.showWizard) {
      this.router.navigate(['/routines'], { replaceUrl: true });
    }
  }

  private async nextSlide(): Promise<void> {
    await this.wizard?.slideTo((await this.wizard?.getActiveIndex()) + 1);
  }

  public ngAfterViewInit(): void {
    this.slides = [
      {
        id: uniqueId('slide_0'),
        image: '../../../assets/images/wizard_welcome.svg',
        title: 'WIZARD.SLIDES.SLIDE_0.TITLE',
        button: {
          label: 'WIZARD.SLIDES.SLIDE_0.BUTTON',
          icon: 'play-outline',
          cta: () => {
            this.nextSlide();
          }
        }
      },
      {
        id: uniqueId('slide_1'),
        image: '../../../assets/images/wizard_routines.svg',
        title: 'WIZARD.SLIDES.SLIDE_1.TITLE',
        description: 'WIZARD.SLIDES.SLIDE_1.DESCRIPTION',
        button: {
          label: 'WIZARD.SLIDES.SLIDE_1.BUTTON',
          icon: 'arrow-forward-outline',
          cta: () => {
            this.nextSlide();
          }
        }
      },
      {
        id: uniqueId('slide_2'),
        image: '../../../assets/images/wizard_add_routine.svg',
        title: 'WIZARD.SLIDES.SLIDE_2.TITLE',
        description: 'WIZARD.SLIDES.SLIDE_2.DESCRIPTION',
        button: {
          label: 'WIZARD.SLIDES.SLIDE_2.BUTTON',
          icon: 'arrow-forward-outline',
          cta: () => {
            this.nextSlide();
          }
        }
      },
      {
        id: uniqueId('slide_3'),
        image: '../../../assets/images/wizard_timers.svg',
        title: 'WIZARD.SLIDES.SLIDE_3.TITLE',
        description: 'WIZARD.SLIDES.SLIDE_3.DESCRIPTION',
        button: {
          label: 'WIZARD.SLIDES.SLIDE_3.BUTTON',
          icon: 'arrow-forward-outline',
          cta: () => {
            this.nextSlide();
          }
        }
      },
      {
        id: uniqueId('slide_4'),
        image: '../../../assets/images/wizard_add_timer.svg',
        title: 'WIZARD.SLIDES.SLIDE_4.TITLE',
        description: 'WIZARD.SLIDES.SLIDE_4.DESCRIPTION',
        button: {
          label: 'WIZARD.SLIDES.SLIDE_4.BUTTON',
          icon: 'arrow-forward-outline',
          cta: () => {
            this.nextSlide();
          }
        }
      },
      {
        id: uniqueId('slide_5'),
        image: '../../../assets/images/wizard_timer_play.svg',
        title: 'WIZARD.SLIDES.SLIDE_5.TITLE',
        description: 'WIZARD.SLIDES.SLIDE_5.DESCRIPTION',
        button: {
          label: 'WIZARD.SLIDES.SLIDE_5.BUTTON',
          cta: () => {
            this.store
              .dispatch(new ToggleShowWizard(false))
              .pipe(take(1))
              .subscribe(() => {
                this.router.navigate(['/routines'], { replaceUrl: true });
              });
          }
        }
      }
    ];
  }
}

HTML:
<ion-content [fullscreen]="true">
  <ion-slides *ngIf="slides?.length > 0" [options]="wizardOptions" id="wizard">
    <ng-container *ngFor="let slide of slides; index as i">
      <ion-slide *ngIf="slide?.id">

{{slide.title | translate}}

{{slide.description | translate}}

        <ion-button (click)="slides[i].button.cta()" *ngIf="slide.button" fill="clear">
          {{slide.button.label | translate}}
          <ion-icon *ngIf="slide.button.icon" slot="end" [name]="slide.button.icon"></ion-icon>
        </ion-button>
      </ion-slide>
    </ng-container>
  </ion-slides>
</ion-content>

Whenever i call slideTo(...) it doesn't give me anything, this is happening only on iOS/Android on production build (ng build --prod), on dev is working on both, this is probably due to IVY compilation.
Unfurtunately it doesn't give me any error in console (neither on iOS/Android console)

after I had spent too much time tracking down this issue, I assembled a working proof,
I came here to submit the bug with my proof and voila I find this bug report for the exact same bug :)
any updates @liamdebeasi ?

Hello everyone. I can confirm the same behaviour on the latest ionic and angular versions.

Here is a workaround for this issue. Simply postpone the slider initialization with ngIf and the angular lifecycle.
my-component.html
<ion-slides *ngIf="didInit">

</ion-slides>

my-component.ts
@Component({
    templateUrl: 'my-component.html'
})
export class MyComponent implements AfterViewInit {
    public didInit: boolean = false;

    ngAfterViewInit() {
        this.didInit = true;
    }
}

had to a timer with 500 ms and then it worked!

Here is a workaround for this issue. Simply postpone the slider initialization with ngIf and the angular lifecycle.
my-component.html
<ion-slides *ngIf="didInit">

</ion-slides>

my-component.ts
@Component({
    templateUrl: 'my-component.html'
})
export class MyComponent implements AfterViewInit {
    public didInit: boolean = false;

    ngAfterViewInit() {
        this.didInit = true;
    }
}

I had to a timer and then it worked.
Thanks!

Hi @hanibhat as you can see from my code i already implement a solution like this one, i initialize the slides variable in the ngAfterViewInit function, and the ion-slides render only if slides.length > 0, so it doesn't work in my case sorry about that.

@Flowrome I had no idea how to fix it until I read your work around. Thanks a lot!

Can everyone try the following dev build and let me know if it resolves the issue? I tested in the repo provided in https://github.com/ionic-team/ionic/issues/20356#issue-558204094, and everything seems to work.
npm i<EMAIL_ADDRESS>Thanks!

@liamdebeasi did you find out why the slider is initialized (or connected) multiple times?

@liamdebeasi nice work I think this fixed the bug, but I noticed the following:
using this options:
  public options = {     on: {       beforeInit() {         console.log('beforeInit');       },       beforeDestroy(){         console.log('beforeDestroy');       }     }   }
if ivy is enabled the beforeInit event is called twice, if ivy is disabled it is called once only as it should be.

Can everyone try the following dev build and let me know if it resolves the issue? I tested in the repo provided in #20356 (comment), and everything seems to work.
npm i<EMAIL_ADDRESS>Thanks!

i'll try this evening if everything works when we can expect the prod release? i'd like to not have dev branches on production environment 😁

@liamdebeasi did you find out why the slider is initialized (or connected) multiple times?

To summarize, Angular Ivy creates new pages as siblings of their router outlets, but Ionic Framework requires them to be children of the router outlets.
What Angular Ivy wants:
<ion-router-outlet></ion-router-outlet>
<my-page-with-slides></my-page-with-slides>

What Ionic Framework wants:
<ion-router-outlet>
  <my-page-with-slides></my-page-with-slides>
</ion-router-outlet>

To work around this, we call ionRouterOutlet.appendChild(myPageWithSlides) which is going to "move" the page from being a sibling to being a child of the router outlet.
When Web Components are attached to the DOM, the connectedCallback method is called, and when Web Components are removed from the DOM, the disconnectedCallback method is called. So moving a component is going to cause connectedCallback to be called, followed by disconnectedCallback, followed by another connectedCallback.
The problem with ion-slides is that the disconnectedCallback method was asynchronous, meaning it was possible for the Swiper instance to be destroyed after the second connectedCallback, resulting in ion-slides being left in a destroyed state.

i'll try this evening if everything works when we can expect the prod release? i'd like to not have dev branches on production environment

We do not typically comment on exact timing of releases, but we are in a regular release cycle with new releases every few weeks.

@liamdebeasi did you find out why the slider is initialized (or connected) multiple times?

To summarize, Angular Ivy creates new pages as siblings of their router outlets, but Ionic Framework requires them to be children of the router outlets.
What Angular Ivy wants:
<ion-router-outlet></ion-router-outlet>
<my-page-with-slides></my-page-with-slides>

What Ionic Framework wants:
<ion-router-outlet>
  <my-page-with-slides></my-page-with-slides>
</ion-router-outlet>

To work around this, we call ionRouterOutlet.appendChild(myPageWithSlides) which is going to "move" the page from being a sibling to being a child of the router outlet.
When Web Components are attached to the DOM, the connectedCallback method is called, and when Web Components are removed from the DOM, the disconnectedCallback method is called. So moving a component is going to cause connectedCallback to be called, followed by disconnectedCallback, followed by another connectedCallback.
The problem with ion-slides is that the disconnectedCallback method was asynchronous, meaning it was possible for the Swiper instance to be destroyed after the second connectedCallback, resulting in ion-slides being left in a destroyed state.

i'll try this evening if everything works when we can expect the prod release? i'd like to not have dev branches on production environment

We do not typically comment on exact timing of releases, but we are in a regular release cycle with new releases every few weeks.

still good enough for me if it solve my use case, thank you 😁

@abuassar Can you try this dev build and let me know if it fixes the duplicate events?
npm i<EMAIL_ADDRESS>

@liamdebeasi very nice, no more dublicated init yay!

Can everyone try the following dev build and let me know if it resolves the issue? I tested in the repo provided in #20356 (comment), and everything seems to work.
npm i<EMAIL_ADDRESS>Thanks!

Hi @liamdebeasi i've installed the package that you've gave us, it's working fine for my case too, also on production build.
I don't see many breaking changes for my Ionic usage, so i'll publish an update with this version waiting for the next production one.
Thank you for your work

I was desperate trying to figure out what was going on with an  implementation.
I need to navigate to a slide index after clicking on an ion-segment.
Sometimes, (90% of the time) the implementation does not work.
The slideTo method did not resolve and nothing happens. I tested the version (npm i<EMAIL_ADDRESS>and the problem seems to have been solved.

@liamdebeasi The dev-build fixes the issue for me too, thank you!

Thanks for the issue. This has been resolved via https://github.com/ionic-team/ionic/pull/20899 and will be available in an upcoming release of Ionic Framework.

To work around this, we call ionRouterOutlet.appendChild(myPageWithSlides) which is going to "move" the page from being a sibling to being a child of the router outlet.

@liamdebeasi will this be a performance issue? Because swiper than is always initialized twice in angular.

No, the PR I added prevents this performance issue from happening.

@liamdebeasi  thanks it works now for me, but when i add the dir="rtl" the direction does not work

Any update on when this will be released?  This is holding our app from moving forward as we're not comfortable finalizing and wrapping up testing with a dev build.  Please advise.

@hannata Please open a new issue.
@AmandaAdams We hope to have this update out soon.

Waiting on this, because of this slider we disabled ivy renderer for entire project.

Hi everyone,
This issue is resolved. For any additional bugs please open a new issue. Thanks!


Optimize standard SVG logo

Current standard logo embeds a whole font! Let's optimize it. Export is done from Figma then optimized through SVGOMG

Nice


e2e tests for ArgoCD & Flux

ArgoCD and Flux are first class citizens of the project.
Context: with 0.5.0 we had a couple of issues that could've been caught earlier when we would have had e2e tests.
AC:

create a dedicated gitops testsuite with a small set of tests

the testsuite should be focused around the integration with $GITOPS tool
we should be able to deploy ESO via helm
we should be able to use ExternalSecrets. fake provider is fine for this use-case.
ensure/document behavior and implications around creationPolicy=Merge and deletionPolicy

deploy ArgoCD and run the test suite
deploy flux v2 and run the test suite

I am keen to do one of those, as ways to get more involved with Argo / Flux and gitops (warning alert I would be slow :smile:)
Should we test flux v1 as well? I think it is the majority of our flux issues.

I'd focus on flux v2 and argocd; flux v1 is deprecated already. I started taking a look on that already, but sure go ahead!
I imagine that as a result we would have two e2e suites:

the provider suite (the "current" one)
a gitops integration suite

We need two suites because we install ESO globally here.
And we would want to install ESO through $GITOPS tool instead using the manifests from the local file tree. This will likely be the tricky part.

After a second thought, I think my time will be somewhat more limited now from the work side. I don't think I'll have the time to take this issue, specially because I would still need to learn some basics around flux and argo... sorry for that :sweat_smile:


Divide the test helpers into two files

@hassox looks like we must separate them! It will solve: https://github.com/hassox/warden/issues/128
And also, this guy needs warden like me: https://github.com/hassox/warden/issues/117
Thought?

Looks good. Can you please add a bump in the version and a section to the readme for it?

@hassox Done!


Item page: human-readable license text

Type
:sparkles: Feature
Building on #1078 we need to map licence codes (CC-BY etc) to plain language copy.
Acceptance criteria

[x] User can view narrative statement about what licence means in practical terms:

under which circumstances the material can be used

examples of permitted use

[x] User can read a general statement about copyright of work

[ ] User testing demonstrates that people understand their rights and obligations

[ ] Overall reduction in calls to Enquiries teams.

User story
As any picture researcher, I want to see clear unambiguous information about copyright and usage so that I don't get confused or sued (WI Personas research, 2014)

For external user testing for V images only, this can be fudged on the front end with a CC licence.

Examples:

Europeana: minimal info plus CC marks http://www.europeana.eu/portal/en/record/9200397/BibliographicResource_3000126285533.html?q=sheep
MoMA: prose licensing info : https://www.moma.org/collection/works/50608

CC guidance: https://creativecommons.org/licenses/

Send draft options to Chris M from Legal for review today.

This needs to be put into a new drawer below description
Drawer: Using this image
Heading: Licence information

Licence code
Blurb
Link

PDM
You can use this work for any purpose without restriction under copyright law.
Public Domain Mark (PDM) terms and conditions https://creativecommons.org/publicdomain/mark/1.0/

CC0
You can use this work for any purpose without restriction under copyright law.
Creative Commons Zero (CC0) terms and conditions https://creativecommons.org/publicdomain/zero/1.0/

CC BY
You can use this work for any purpose, including commercial uses, without restriction under copyright law. You should also provide attribution to the original work, source and licence.
Creative Commons Attribution (CC BY 4.0) terms and conditions https://creativecommons.org/licenses/by/4.0/

CC BY-NC
You can use this work for any purpose, as long as it is not primarily intended for or directed to commercial advantage or monetary compensation. You should also provide attribution to the original work, source and licence.
Creative Commons Attribution Non-Commercial (CC BY-NC 4.0)terms and conditions https://creativecommons.org/licenses/by-nc/4.0/

Copyright not cleared
Copyright for this work has not been cleared. You are responsible for identifying the rights owner to seek permission to use this work.

Heading: Attribution
Image credit: {{Wellcome Collection}} {{Licence code/CC-BY}}.
{{Title | Link}} by {{Creator}}. Source: {{Wellcome Collection}}.{{Licence code | Link}}
Astronomy: a diagram of the sun, and various effects of sunlight. Coloured engraving.
(https://wellcomecollection.org/works/ezyb33ve). Source: Wellcome Collection. CC BY (url).
A man holding a tube of Bubisan brilliantine for the hair (https://wellcomecollection.org/works/ezyb33ve) by Leonhard F. W. Fries. Source: Wellcome Collection. CC BY.

@Heesoomoon @pollecuttn @davidpmccormick @gestchild Ready to go with this one. I left everything in Heesoo's hands.

What we have currently:
{digitalLocation.license.humanReadableText}
Credit: {work.title}. {digitalLocation.credit || iiifManifest.credit}. digitalLocation.license.label


[Help] Cookie issues

Hi, I'm trying to use this on a page requiring login, but I'm having issues.
I'm trying to use the Cookie: something, but it will not save. That leads me to believe I'm doing it wrong.
Is it possible for you to explain it a bit better, and/or show me an example of a proper cookie string?
Thanks for a great tool! :)

but it will not save

Can you tell me exactly what " but it will not save" means? do you get an error? if so what is the error exactly?

A bit poorly explained.

I'm used to using curl with the -b flag, and a file formated like this:
# Netscape HTTP Cookie File
# https://curl.haxx.se/rfc/cookie_spec.html
# This is a generated file! Do not edit.

domain.com	FALSE	/	FALSE<PHONE_NUMBER>	domain_cc_essential	approved
domain.com	FALSE	/	FALSE<PHONE_NUMBER>	domain_cc_functional	approved
domain.com	FALSE	/	FALSE<PHONE_NUMBER>	domain_cc_performance	approved
domain.com	FALSE	/	FALSE<PHONE_NUMBER>	domain_cc_targeting	approved
.domain.com	TRUE	/	FALSE<PHONE_NUMBER>	_gcl_au	1.1.121e.123123
.domain.com	TRUE	/	TRUE<PHONE_NUMBER>	_scid	cf1sklsa2-ksdks-2131-ddsa-dl31312212
.domain.com	TRUE	/	FALSE<PHONE_NUMBER>	rl_page_init_referrer	RudderEncrypt%3AU2FsdGVkX1%2BRldsdas4NCbeodsqp9Q2xDbyHssDenk%3D
.domain.com	TRUE	/	FALSE<PHONE_NUMBER>	rl_page_init_referring_domain	RudderEncrypt%3Adsaass

ok cool! thanks for the report! I see there is actually a bug, i'll check it out

Perfect! But do you have any input on converting the "Netscape HTTP Cookie File" to a single Cookie: line?
Or a way to use that as is?

Hi, i just realised that this is not a bug, you should never have two of the same value "keys" in your header requests

https://developer.mozilla.org/en-US/docs/Web/HTTP/Cookies read this

@NoLooseEnds so a bug was fixed with adding your cookies https://github.com/dgtlmoon/changedetection.io/issues/172 , hope it helps!

And I made https://github.com/dgtlmoon/changedetection.io/issues/176 for you


Update all instances of Patient modification in commands

The current method of creating a new immutable Patient after every command relating to it involves using the Patient constructor with a long list of attributes. A cleaner method to create a new immutable Patient can be used for ease of future implementations and code clarity.

I was thinking we could have 'setters' for each field in the Patient class (those that can't be edited using the edit patient feature), but instead of modifying patient attributes, they could behave similar to TaskList#edit()  (which returns a new TaskList) and return a new Patient.
So maybe we could have something like this in the Patient class:
public Patient setConditions(ConditionList conditions) {
    return new Patient(getName(), getPhone(), getEmail(), getAddress(), conditions,
            getTasks(), getTags());
}


Where can I get sax sounds for the haxophone?

The haxophone uses Fluidsynth to generate sounds.  Fluidsynth uses sampled sound files in soundfont format.  Any soundfont samples will work.
I use the samples linked in this thread:  https://musescore.org/en/node/101951
I have not checked them into the repository because I don't know if the license allows redistribution.

Anyone using other soundfont files, please add to this thread.