fumpt

Description
go install mvdan.cc/gofumpt@latest
gofumpt -w -l .
^ really makes the code look great!

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[x] Targeted PR against correct branch (see CONTRIBUTING.md)
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards.
[ ] Wrote unit and integration tests
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
[ ] Added relevant godoc comments.
[x] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
[x] Re-reviewed Files changed in the Github PR explorer
[ ] Review Codecov Report in the comment section below once CI passes

Codecov Report

Merging #1335 (083f31d) into main (79ddb9d) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1335      +/-   ##
==========================================
- Coverage   80.37%   80.34%   -0.03%
==========================================
  Files         166      166
  Lines       12099    12081      -18
==========================================
- Hits         9724     9707      -17
+ Misses       1919     1918       -1
  Partials      456      456

Impacted Files
Coverage Δ

...7-interchain-accounts/controller/keeper/account.go
72.72% <ø> (ø)

...interchain-accounts/controller/keeper/handshake.go
86.44% <ø> (-0.23%)
:arrow_down:

...27-interchain-accounts/controller/keeper/keeper.go
94.73% <ø> (-0.05%)
:arrow_down:

.../27-interchain-accounts/controller/types/params.go
47.82% <ø> (ø)

.../apps/27-interchain-accounts/host/keeper/events.go
0.00% <ø> (ø)

...ps/27-interchain-accounts/host/keeper/handshake.go
84.61% <ø> (-0.30%)
:arrow_down:

.../apps/27-interchain-accounts/host/keeper/keeper.go
83.33% <ø> (-0.17%)
:arrow_down:

...dules/apps/27-interchain-accounts/types/account.go
78.26% <ø> (-0.62%)
:arrow_down:

modules/apps/27-interchain-accounts/types/codec.go
79.54% <ø> (ø)

modules/apps/29-fee/keeper/escrow.go
93.16% <ø> (ø)

... and 22 more


Add login page

Adds the login page.
Testing:

Try logging in with invalid username / pwd. Error message should appear
Try logging in with correct username / pwd. Login should succeed and should redirect to the home page of the most recently accessed episode.
Try going to the /login page while already logged in. It should redirect you to the home page of the most recently accessed episode.

Note: testing is blocked on https://github.com/battlecode/galaxy/pull/667.

test-ready now?


Error 429 closed (#22839)

Why would you close that report? Of course we don't know how or why the issue happens, otherwise it would be solved, but there are many users with the same issue.
We know that --sleep-interval is ignored when youtube-dl is looking for a video list.
Whatever youtube-dl does when it reports 'Downloading video info webpage', it does it way too fast if I had to guess.
This issue will keep being reported over and over, it's counterintuitive to close them as you will just get more of the same questions over and over again. It's much better to have all the discussion in one report.

I'll keep it closed until reproducible environment is provided.


Migration Cinder Intree to CSI failed

Is this a BUG REPORT or FEATURE REQUEST?:
/kind bug
What happened:
I created a Kubernetes cluster with one node and the Openstack CCM/Kubelet Intree plugin configured. Then I created a deployment using a Cinder PVC referring to a storageclass with provider "kubernetes.io/cinder". A PV has been created and the deployment pod started.
I wanted to migrate my cluster to the Cinder CSI plugin. So I deployed all required components, I activated the features gates CSIMigration and CSIMigrationOpenStack as explained here and I restarted the node where the pod ran.
But the pod never started because of the error:
Mounting command: systemd-run
Mounting arguments: --description=Kubernetes transient mount for /var/lib/kubelet/pods/c241110b-11fe-434a-b9ee-3c643ba0781e/volumes/kubernetes.io~cinder/pvc-9b5e4613-0243-11ea-a523-2e2af65a0289 --scope -- mount -o bind /var/lib/kubelet/plugins/kubernetes.io/cinder/mounts/11e8c62a-dfb9-43bf-b449-629eb4a01ee9 /var/lib/kubelet/pods/c241110b-11fe-434a-b9ee-3c643ba0781e/volumes/kub
ernetes.io~cinder/pvc-9b5e4613-0243-11ea-a523-2e2af65a0289
Output: Running scope as unit: run-re62fbd59d2d240d49589c8d0433aa285.scope
mount: /var/lib/kubelet/pods/c241110b-11fe-434a-b9ee-3c643ba0781e/volumes/kubernetes.io~cinder/pvc-9b5e4613-0243-11ea-a523-2e2af65a0289: special device /var/lib/kubelet/plugins/kubernetes.io/cinder/mounts/11e8c62a-dfb9-43bf-b449-629eb4a01ee9 does not exist.
  Warning  FailedMount  14m  kubelet, test-local  MountVolume.SetUp failed for volume "pvc-9b5e4613-0243-11ea-a523-2e2af65a0289" : mount failed: exit status 32

After some investigation, it seems that controller manager didn't create VolumeAttachment for volume. As csi-attacher watch VolumeAttachment resources, it does nothing, so the volume is never attached to the node.
What you expected to happen:
The volume to be attached to the node and the pod to start
How to reproduce it (as minimally and precisely as possible):
Create a Kubernetes cluster in version 1.15 with one node and the following customizations:

Boot the openstack-cloud-controller-manager
On controller-manager set the parameters --cloud-config=path-to-cloud-config and --cloud-provider=external and --external-cloud-volume-plugin=openstack
On kubelet set the parameters  --cloud-provider=openstack --cloud-config=path-to-cloud-config
Deploy a storage class with the provider "kubernetes.io/cinder"

Create a deployment with a PVC using the storage class previously created.
To replace intree plugin by csi:

Boot the csi using the official templates
On controller-manager remove the parameters --cloud-config=path-to-cloud-config and --cloud-provider=external and --external-cloud-volume-plugin=openstack
On controller-manager add the featuregates CSIMigration=true,CSIMigrationOpenStack=true
On kubelet set the parameter  --cloud-provider=external and remove the parameter --cloud-config=path-to-cloud-config
Deploy a storage class with the provider "cinder.csi.openstack.org"

Restart the node. You'll see the pod of the deployment previously created stuck in "ContainerCreating" status.
Anything else we need to know?:
After migration if I create a new deployment with a PVC binded to the new storageclass using the provider "cinder.csi.openstack.org", the pv is provisionned, a volumeAttachment is created and the pod start, so I think it does not come from csi configuration.
Environment:

Kubernetes: 1.15.5 (Tested in 1.16.2 too)
Cloud controller manager: latest
CSI: 1.1.0

Does anyone achieved to migrate used volumes from Intree Cinder plugin to CSI ?
Thanks,
Thomas

@thcdrt Could you please give it a try with enabling those feature-gates on the kube-apiserver as well?

Hello @chrisgl thanks for your answer, I tried and unfortunately it changed nothing.
But looking in the kube-controller-manager I found a clue:
E1108 21:49:33.045390       1 operation_generator.go:186] VolumesAreAttached.NewAttacher failed for getting plugin "kubernetes.io/cinder" with: OpenStack cloud provider was not initialized properly : stat /etc/kubernetes/cloud-config: no such file or directory

Why kube-controller-manager need Openstack secrets since it's csi-attacher to attach volume now ? Did I miss a configuration somewhere ?
Thomas

Browsing openstack cloud provider issues, I just read this comment that says that the feature-gate must be enabled on kube-controller-manager, apiserver AND kubelet, I'll give it a try and keep you uptodate :)

I made some tries today with the CSiMigration feature-gates enabled on Kubelet and the migration seems to work ! Kubelet has created the missing volumeattachment.
I'm having some issues with PV deletion now:
Warning  VolumeFailedDelete  19m   persistentvolume-controller  OpenStack cloud provider was not initialized properly : stat /etc/kubernetes/cloud-config: no such file or directory
It looks like only controller-manager can delete this PV, is it the desired behaviour ?

Thanks @thcdrt !
No that is not the desired behaviour. I am wondering why the kube-controller-manager tries to access /etc/kubernetes/cloud-config even if you removed the flag o_O Does that also happen with kubernetes 1.16?
Anyways, I will try to reproduce this.

@thcdrt why you are using this  --external-cloud-volume-plugin=openstack?? It signifies you are using intree volume plugin.

@chrisgl I only tried in 1.15 for now, I'll try it in 1.16 and give you feedback.
@adisky I'm not using "--external-cloud-volume-plugin=openstack" when using csi, only when using intree.

@thcdrt mentioned by you above
To replace intree plugin by csi: Boot the csi using the official templates On controller-manager remove the parameters --cloud-config=path-to-cloud-config and --cloud-provider=external and --external-cloud-volume-plugin=openstack
`

@thcdrt are you sure the volume is created by CSI, which you are trying to delete?

@adisky "remove the parameters". That means that I deleted the 3 parameters from the configuration.

@adisky ofcourse not, the volume has been created by intree plugin, but I activated the migration, so what it the benefit of the migration if I must keep the intree plugin working for PV deletion ?

@thcdrt missed the remove part only saw the flags, so what you are trying to do

deploy intree plugin
create volume with intree plugin
enable migration, deploy CSI
delete volume
could you check CSI logs??

@adisky yes exactly. What logs do you want ? From what component ?

@thcdrt cinder plugin container logs, for node and controller plugin both

@adisky

Nodeplugin, in cinder-csi-plugin container:
I1113 11:39:43.013007       1 driver.go:57] Driver: cinder.csi.openstack.org version: 1.1.0 I1113 11:39:43.013066       1 driver.go:90] Enabling controller service capability: LIST_VOLUMES I1113 11:39:43.013071       1 driver.go:90] Enabling controller service capability: CREATE_DELETE_VOLUME I1113 11:39:43.013075       1 driver.go:90] Enabling controller service capability: PUBLISH_UNPUBLISH_VOLUME I1113 11:39:43.013083       1 driver.go:90] Enabling controller service capability: CREATE_DELETE_SNAPSHOT I1113 11:39:43.013087       1 driver.go:90] Enabling controller service capability: LIST_SNAPSHOTS I1113 11:39:43.013090       1 driver.go:90] Enabling controller service capability: EXPAND_VOLUME I1113 11:39:43.013094       1 driver.go:102] Enabling volume access mode: SINGLE_NODE_WRITER I1113 11:39:43.013098       1 driver.go:112] Enabling node service capability: STAGE_UNSTAGE_VOLUME I1113 11:39:43.013134       1 driver.go:112] Enabling node service capability: EXPAND_VOLUME I1113 11:39:43.013535       1 openstack.go:81] Block storage opts: {0} I1113 11:39:43.310557       1 server.go:108] Listening for connections on address: &net.UnixAddr{Name:"/csi/csi.sock", Net:"unix"}

Controller-plugin:
cinder-csi-plugin:
I1113 11:40:39.642353       1 driver.go:57] Driver: cinder.csi.openstack.org version: 1.1.0 I1113 11:40:39.642451       1 driver.go:90] Enabling controller service capability: LIST_VOLUMES I1113 11:40:39.642462       1 driver.go:90] Enabling controller service capability: CREATE_DELETE_VOLUME I1113 11:40:39.642471       1 driver.go:90] Enabling controller service capability: PUBLISH_UNPUBLISH_VOLUME I1113 11:40:39.642479       1 driver.go:90] Enabling controller service capability: CREATE_DELETE_SNAPSHOT I1113 11:40:39.642499       1 driver.go:90] Enabling controller service capability: LIST_SNAPSHOTS I1113 11:40:39.642508       1 driver.go:90] Enabling controller service capability: EXPAND_VOLUME I1113 11:40:39.642518       1 driver.go:102] Enabling volume access mode: SINGLE_NODE_WRITER I1113 11:40:39.642527       1 driver.go:112] Enabling node service capability: STAGE_UNSTAGE_VOLUME I1113 11:40:39.642538       1 driver.go:112] Enabling node service capability: EXPAND_VOLUME I1113 11:40:39.643158       1 openstack.go:81] Block storage opts: {0} I1113 11:40:40.169740       1 server.go:108] Listening for connections on address: &net.UnixAddr{Name:"/csi/csi.sock", Net:"unix"} I1113 11:40:40.432210       1 openstack.go:81] Block storage opts: {0} I1113 11:40:40.508380       1 openstack.go:81] Block storage opts: {0} I1113 11:40:40.724340       1 openstack.go:81] Block storage opts: {0} I1113 11:40:40.933942       1 openstack.go:81] Block storage opts: {0}

What component in csi should delete volume in Openstack ? csi-provisionner ?

@chrigl same in 1.16.

Hey @thcdrt , I think I was able to reproduce it, and getting stuck with an pre CSIMigration created PVC/PV that ended up in failed with
Events:
  Type     Reason              Age    From                         Message
  ----     ------              ----   ----                         -------
  Warning  VolumeFailedDelete  7m18s  persistentvolume-controller  OpenStack cloud provider was not initialized properly : stat /etc/kubernetes/cloud-config: no such file or directory

... while for new Volumes everything works fine.
Can you confirm that?
I think the message comes out of the kube-controller-manager. However. In my setup, the PV is provisined-by kubernetes.io/cinder.
apiVersion: v1
kind: PersistentVolume
metadata:
  annotations:
    kubernetes.io/createdby: cinder-dynamic-provisioner
    pv.kubernetes.io/bound-by-controller: "yes"
    pv.kubernetes.io/provisioned-by: kubernetes.io/cinder

When I annotate the PV so that it is provisioned-by csi, I am able to delete it.
kubectl annotate --overwrite pv pvc-597e68ea-ddba-4cb4-b1b2-fe02d45e6fd5 pv.kubernetes.io/provisioned-by=cinder.csi.openstack.org

Can you confirm that?

@chrigl thank you for taking time to reproduce it.
I confirm that I don't have any problem with volumes created by CSI. Only with volumes provisioned by "kubernetes.io/cinder".
This is the same bug than I have.

@thcdrt I had some time to dive into this. Even with the steps below, one can migrate to CSI, but the deletion of volumes will fail. Currently (including v1.17.0-beta.1) a delete request with the annotation pv.kubernetes.io/provisioned-by: kubernetes.io/XYZ is not handed over to the CSI plugin, but wants to hand it to the original provisioner... with the shortcoming, that we disabled it by removing cloud-config and cloud-provider (for good reasons). When one annotates the PV with the "new" provisioner deletion works (because the migration code kube-controller-manager is not invovled).
Note: when you delete the PV, and it ends up in failed, and you then annotate the PV and delete it again... the PV goes away, but the Volume in Cinder keeps around.
I write this here, but still need to document!
To enable CSIMigration on an old cluster is a multi-step procedure, and requires draining nodes before enabling migration. See https://github.com/kubernetes/community/blob/master/contributors/design-proposals/storage/csi-migration.md#upgradedowngrade-migrateunmigrate-scenarios
To sum that up... Assuming we have a cluster using the in-tree cloud-controller for everything, and want to migrate to the external one, as well as enabling CSIMigration.

Deploy the cloud-controller-openstack and cinder-csi
Change the feature-gates of kube-apiserver and kube-controller-manager to enable CSIMigration, CSIMigrationOpenStack and ExpandCSIVolumes. keep settings for cloud-provider and cloud-config
Drain a node and and enable featureGates on kubelet e.g. in /var/lib/kubelet/config.yaml.
If using kubeadm, remember to edit ConfigMaps kubeadm-config and kubelet-config-1.16 for those featureGates
Verify the node is "migrated":

kubectl get csinode small-k8s-2 -oyaml
apiVersion: storage.k8s.io/v1beta1
kind: CSINode
metadata:
  annotations:
    storage.alpha.kubernetes.io/migrated-plugins: kubernetes.io/cinder
...

Uncordon the node and continue with the next one
When all nodes are done, remove cloud-provider and cloud-config from kube-controller-manager

Your mentioned deletion, still does not work, until the PVs are annotated to use cinder.csi.openstack.org.
kubectl annotate --overwrite pv pvc-7cd30795-942c-4dda-804b-1fa6253c38b4 pv.kubernetes.io/provisioned-by=cinder.csi.openstack.org

Hello @chrisgl, thank your very much for your investigation and your sum up !
This would be great to document this sum-up in the cloud-provider-openstack, I think it can help future users who want to migrate too.
I'll add the annotation to the intree volumes at the end of the migration process.
Thomas

Just for the record: https://github.com/kubernetes/kubernetes/issues/79043


Remove --use-feature=2020-resolver command line option for obsolete pip 2020 solver

Description

Pip introduced a more robust but different dependency resolver back when were were all working from home (sneaky! :grin: ), see communication release and that was breaking some stuffs back then, now it's the default resolver and the call to use the older resolver is deprecated and will introduce an error if used :+1: :beer:
Just like in https://github.com/ESMValGroup/ESMValCore/pull/1357
Tests all ok bar one related to pymon-journal that @zklaus has already flagged

Before you get started

Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

[x] 🛠 This pull request has a descriptive title
[x] 🛠 Tests run successfully
[x] 🛠 All checks below this pull request were successful

cheers @zklaus - I did that for Core already, we merged it last week. TBH no idea why it's only for one lonely test :grin:


Assertion failure in mrb_write_barrier

The following input demonstrates an assertion failure:
GC.start
ObjectSpace.each_object{ GC.generational_mode = nil }
a

Assertion failed: (((gc)->generational) || gc->state != MRB_GC_STATE_ROOT), function mrb_write_barrier, file /Users/clayton/git/mruby/src/gc.c, line 1304.
This issue was reported by Dinko Galetic & Denis Kasak (https://hackerone.com/dgaletic).

It turns out it's (almost) impossible to keep consistency in GC after changing generational mode during iteration. I will make it impossible by raising an exception.


Remove naing component from category widget form schema model

:trollface: ing me.

cc @piensaenpixel.

@jvillarf failing on premise tests :S, should I be worried?

Hey,
it had an issue downloading PhantomJS package... Honestly, i don't know why. You might launch the tests again, if you consider this is necessary.
Javi.

@jvillarf I think that's a known issue, it happens from time to time (rarely, but still) on the travis CI test runs too

Oh, ok @viddo . Thanks for the heads up :)


Update screenshots from VSTS age

https://docs.microsoft.com/en-us/azure/devops/artifacts/symbols/_img/vsdebugger1.jpg?view=azure-devops
new message

https://docs.microsoft.com/en-us/azure/devops/artifacts/symbols/_img/connectsymbolserver.png?view=azure-devops
new UI

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1d921846-31fc-69eb-edef-6c41c050f592
Version Independent ID: 83678a41-bf22-2318-4867-710ab7a14494
Content: Debug with symbols in Visual Studio
Content Source: docs/artifacts/symbols/debug-with-symbols-visual-studio.md
Product: devops
GitHub Login: @elbatk
Microsoft Alias: elbatk

and url here also require an update https://docs.microsoft.com/en-us/azure/devops/artifacts/symbols/_img/vsdebugger2.png?view=azure-devops

Thanks @SychevIgor. I've created a work item to address this!

It's been more than a year this hasn't been updated, the documentation has become ridiculous.

@SychevIgor Apologies for the delay and thank you for your feedback.


When building the wheel the file atomic_ops.spirv does compile but is not included in the archive

Provided a build environment for numba_dpex, when running
python ./setup.py bdist_wheel
the archive does not include the file atomic_ops.spir, when installing the binary later there will not be support for atomic operations. But one can see that the file atomic_ops.spir, despite not being included in the archive, was effectively created.
The source of the issue might come from the MANIFEST.in or metadata in setup,py, those can be tricky to get right.

The workaround I've found is to run python setup.py develop before running python setup.py bdist_wheel, it ensures that spirv compile steps are triggered early enough to ensure that the packaging steps will index the binaries that are created during compilation and add it to the tarball.

@fcharras More of an FYI at this point. I am working on overhauling the atomics support in numba-dpex (https://github.com/IntelPython/numba-dpex/issues/783). The file you point to was added back when there was no native atomic instruction support in the hardware and the file atomic_ops.spir provided an emulation layer (copied from what the DPC++ copier used to do) for atomics ops.
Since then dpex does support generating native atomic instructions. The emulator is still the default and generating native atomics is an opt-in feature at the moment by setting NUMBA_DPEX_ACTIVATE_ATOMICS_FP_NATIVE to a non zero value.
In my current work, I am evaluating if emulation is still needed and if we can make generation of native atomics instructions the default.


Update SBG e2e workflow to work across venues

Retrieve all dependent parameters from SSM or Airflow environment so that the DAG can run across all venues. Includes adding tests for the MCP test and prod venues.

This should involve replacing the SSM key for the primary data bucket:
UNITY_OUTPUT_DATA_BUCKET = "/unity/ds/data/bucket/primary-data-bucket"
with a new expression that includes the venue and deployment - for which the values are retrieved from the AIRFLOW env variables.
This task include updating the nightly test so they can work for unity-venue-dev, unity-venue-test and unity-venue-prod.

Chatted with Galen and decided to go with this format, for now:
UNITY_OUTPUT_DATA_BUCKET = "/unity/ds/data/bucket/{deployment_name}/{venue}-{counter}/primary-data-bucket"
As an example, "/unity/ds/data/bucket/luca/test-1/primary-data-bucket"
Does that make sense based on previous conversations y'all have had?

Sure, let's do that ...


When EmbeddedEventStore enables optimizeEventConsumption (default) it will cause a memory leak of Node sometimes

Basic information

Axon Framework version:4.4.5
JDK version:  8u311
Complete executable reproducer if available (e.g. GitHub Repo):

Steps to reproduce
use the JdbcEventStorageEngine and tracking mode to consumer events from eventbus.and startup 2 application.
firstly,the eventstore has some event ,and then the trackingprocessor will process those events.
when consume to the end,it will start a  EventProducer to fetch events instead of the privateStream.
secondly,insert a lot of events to the event store,about 10000,which can't be done immediately.
thirdly,release the trackingtoken which hold it,so another one will take it.
it happens occasionally in production environment.i repeat it once,but when i call heapdump i has bean recycle by full gc.
the production environment is arm64 by the way.
Expected behaviour
the application can be stable running.
Actual behaviour
the oldest node(not the EmbeddedEventStore hold,but exist in G1 Old Gen) is no gc root ,but can't be recycle,and the survivor space memory usage is keep growing until it cause oom.
mat images

First off, thanks for filing this concern with us, @yitizi.
Secondly, perhaps an obvious pointer, but Axon Framework 4.4.5 is an old version (November 2020) of Axon Framework, as we are currently at release 4.9.1.
Although we make exceptions from time to time, we aim to provide critical bug fixes about three minor releases back.
Hence, it would be very helpful if you could show the same predicament under a more recent release of Axon Framework.
Not just for us but also for you and your team receiving or coming to a fix, of course.
Another point that interests me, is your specific mention of the optimizeEventConsumption property being set to true in your environment.
Does that mean you have shown the issue not to happen when optimizeEventConsumption is set to false?
Now let me comment a little to your explanation:

firstly,the eventstore has some event ,and then the trackingprocessor will process those events.
when consume to the end,it will start a EventProducer to fetch events instead of the privateStream.

The EmbeddedEventStore, when optimizeEventConsumption is enabled (which is the default), will aim to use a common EventConsumer among different StreamingEventProcessor instances as a means to optimize.
If a given StreamingEventProcessor falls outside the cache window of (by default) 10_000 events, the StreamingEventProcessor will receive a custom EventConsumer as its message source.

secondly,insert a lot of events to the event store,about 10000,which can't be done immediately.

This number you're inserting is pretty identical to the default cache window of the EmbeddedEventStore.
Have you, perchance, made any other configuration changes to the EmbeddedEventStore next to specifically setting the optimizeEventConsumption to true?
As stated earlier, when making this shift, your environment will consciously shift from a common EventConsumer for all tailing StreamingEventProcessors to unique EventConsumer instances per StreamingEventProcessor.
This raises another question: how many StreamingEventProcessors (as you're using version 4.4.5, only the TrackingEventProcessor applies) does your application run?

thirdly,release the trackingtoken which hold it,so another one will take it.

How are you exactly telling application X to release "a" TrackingToken so that the other instance picks it up?

Concluding: let's get to the bottom of this, @yitizi :muscle:

First off, thanks for filing this concern with us, @yitizi.

Thanks for the reply. You suggested that I update the Axon Framework to the newest version, but the application is already published in production, so the update cannot be done quickly. I also noticed that the EventProducer code hasn't changed between versions 4.4.5 and 4.9.1.

Secondly, perhaps an obvious pointer, but Axon Framework 4.4.5 is an old version (November 2020) of Axon Framework, as we are currently at release 4.9.1. Although we make exceptions from time to time, we aim to provide critical bug fixes about three minor releases back.
Hence, it would be very helpful if you could show the same predicament under a more recent release of Axon Framework. Not just for us but also for you and your team receiving or coming to a fix, of course.
Another point that interests me, is your specific mention of the optimizeEventConsumption property being set to true in your environment. Does that mean you have shown the issue not to happen when optimizeEventConsumption is set to false?

Yes, only when optimizeEventConsumption is set to true, will the EventProducer initiate, and the linked list-like usage will be activated. When the EventProducer opens an event stream with JdbcEventStorageEngine, it fetches to the end, regardless of the existence of trailing consumers. Therefore, when I insert numerous events, they get cached in memory, and the trimCache method resets the oldest. However, these cached nodes still need to wait for the JVM garbage collection to be triggered.

Now let me comment a little to your explanation:

firstly,the eventstore has some event ,and then the trackingprocessor will process those events.
when consume to the end,it will start a EventProducer to fetch events instead of the privateStream.

The EmbeddedEventStore, when optimizeEventConsumption is enabled (which is the default), will aim to use a common EventConsumer among different StreamingEventProcessor instances as a means to optimize. If a given StreamingEventProcessor falls outside the cache window of (by default) 10_000 events, the StreamingEventProcessor will receive a custom EventConsumer as its message source.

I have no doubt about the capability to switch from a standard EventConsumer to a custom EventConsumer. It's a fantastic feature that can significantly decrease the usage of database connections.

secondly,insert a lot of events to the event store,about 10000,which can't be done immediately.

This number you're inserting is pretty identical to the default cache window of the EmbeddedEventStore. Have you, perchance, made any other configuration changes to the EmbeddedEventStore next to specifically setting the optimizeEventConsumption to true? As stated earlier, when making this shift, your environment will consciously shift from a common EventConsumer for all tailing StreamingEventProcessors to unique EventConsumer instances per StreamingEventProcessor.
This raises another question: how many StreamingEventProcessors (as you're using version 4.4.5, only the TrackingEventProcessor applies) does your application run?

about two.

thirdly,release the trackingtoken which hold it,so another one will take it.

How are you exactly telling application X to release "a" TrackingToken so that the other instance picks it up?

in debug environment is calling the org.axonframework.eventhandling.TrackingEventProcessor#releaseSegment(int) method. in production sometime just occur an error.but i search for the application i mention before,it seems to is just trigger the cleaner ,but just can't be done?im sure it  is just two tracking.it has those log.

Concluding: let's get to the bottom of this, @yitizi 💪

Through the EventProducer's fetching method and the caching of nodes using a linked list approach, it puts pressure on the garbage collector (GC). Eventually, this prevents the garbage collector from functioning properly.
@smcvb

Thanks for the reply. You suggested that I update the Axon Framework to the newest version, but the application is already published in production, so the update cannot be done quickly. I also noticed that the EventProducer code hasn't changed between versions 4.4.5 and 4.9.1.

Although I am aware that we have practically made no changes to the EmbeddedEventStore the last several release, the chances of a patch release on AF 4.4, 4.5, and 4.6 is very slim.
So, although your input here is appreciated, if you want to use a fix once present, you will simply be inclined to upgrade to a more recent version of Axon Framework.
Note that this choice is not something we've made lightly.
It is purely in place to minimize the maintenance effort for the Axon Framework team.
Given the team size, we are unfortunately required to make this request of you. My apologies for that.

With that said, I will reflect on your others comments.

Yes, only when optimizeEventConsumption is set to true, will the EventProducer initiate, and the linked list-like usage will be activated.
When the EventProducer opens an event stream with JdbcEventStorageEngine, it fetches to the end, regardless of the existence of trailing consumers.
Therefore, when I insert numerous events, they get cached in memory, and the trimCache method resets the oldest.
However, these cached nodes still need to wait for the JVM garbage collection to be triggered.

Thanks for the investigation here, @yitizi  :-)
Do you perhaps also have an idea how to adjust trimCache to release resources quicker?
To be frank, I am at this stage not entirely certain how to improve things there...hence the request.

about two.
(I would prefer to quote a helpful text, but in this case there's only an image I can work with.)

It seems like your environment only has two Streaming Event Processors in place.

It's a fantastic feature that can significantly decrease the usage of database connections.

Although true, if you just have two Streaming Event Processors with a single token each, the TrackingEventProcessor will only open a single event stream per instance to begin with.
As such, the optimization is very limited, and apparently causes more harm in your environment than benefit.
Granted, if you would increase the number of segments for your TrackingEventProcessor, you would have an event stream (so database connection) per segment.
This is in turn extremely easily covered with the PooledStreamingEventProcessor, which in most cases has better performance characteristics any how.
However, the PooledStreamingEventProcessor was introduced in 4.5; again meriting an upgrade of your environment to a more recent release of Axon Framework.

in debug environment is calling the org.axonframework.eventhandling.TrackingEventProcessor#releaseSegment(int) method. in production sometime just occur an error.but i search for the application i mention before,it seems to is just trigger the cleaner ,but just can't be done?im sure it > is just two tracking.it has those log.

Furthermore, they're both sagas, which I base on the processor name.
Giving how most users implement Sagas, it is to be expected one or both of your Streaming Event Processors is lacking behind compared to the other.
The log messages provided by Axon Framework are set to WARN on purpose, as this typically shouldn't happen given bursts of events.
And if you do, it would require (1) switching to disable the optimizeEventConsumption or (2) changing the cachedEvents value to a number you would expect to be feasible.

Through the EventProducer's fetching method and the caching of nodes using a linked list approach, it puts pressure on the garbage collector (GC). Eventually, this prevents the garbage collector from functioning properly.

If you would point the issue to be the linked list, that would mean references to Nodes are kept (to long).
However, if that would be the case, I would expect this issue you have occurred to happen for a lot more people, which I haven't noticed to be the case either :thinking:
Just an idea, but perhaps it helps if you enforce your EmbeddedEventStore to clean out EventConsumers that fall behind quicker.
To achieve that, you can adjust the cleanupDelayMillis value, which defaults to 10_000.
Would you mind running a test with that value set to, e.g., 1_000? Just to see whether the issue remains by the way!
By the way, I have spent quite some time in the EmbeddedEventStore to look for a spot where the Node instances that are stored may keep the Node#next field.
As in your original comment, it is the Node#next field that hits the 4Gb mark.
The most reasonable culprits of this, would be the Node oldest value of the overall EmbeddedEventStore, and the Node lastNode of an EventConsumer.
The latter should be covered by the Cleaner task`. The former sounds the most reasonable culprit, but to be frank, I would expect this predicament to occur for virtually every users of Axon Framework if that's the case :thinking:

So, let me conclude this comment:

Upgrading to a recent version of Axon Framework helps you to receive bug fixes at all.
Having just two Sagas does not necessarily merit the use of the optimizeEventConsumption property. Perhaps this will change in the future, but as you're still on 4.4.5, I anticipate there's not to much active development happening on this project.
Having just one segment per Tracking Event Processor does not necessarily merit the use of the optimizeEventConsumption property.
If you could validate in your debug environment whether lowering the cleanupDelayMillis value resolves the predicament, that would be valuable information.

Thanks again for opening this issue, @yitizi! :-)

Thanks for your advice. We are in the process of updating Axon to version 4.7.6 to see if it resolves the issue. The problem has occurred, and we are working to identify the cause. Given that the code appears to have undergone minimal changes, we suspect it might recur. Additionally, this problem is not 100% reproducible.

Closing this issue due to inactivity.
But, be sure to reach out if it occurs again, @yitizi!
In that case, we will reopen the issue to deal with it further.


Add web for Naomi and Denny

Didn't want to merge this directly @Mariatta  in case the build issue is still around

The build should be resolved now, so we can merge. Thanks.


Not getting RGB or composite images?

Hi, I have tryng to run this code for rendering Shapenet datasets for quite sometime. I have tried many things but somehow I get only these 4 type of images.

Can you please tell how do I obtain fully colored images , really need this for a project desperately, like these maybe

thank you

Did you try opening the file in blender directly? Were there any errors? By running without the --background flag, the blender instance stays open for you to investigate:
blender --background --python render_blender.py -- --output_folder /tmp path_to_model.obj

Unfortunately this is almost impossible for me to debug without the mesh definition.

thank you so much for replying, so here it is
In just tried that, I do see these lines during execution
Rotation 216.0, 3.7699111843077517
Fra:1 Mem:47.44M (0.00M, Peak 48.37M) | Time:00:00.02 | Preparing Scene data
Fra:1 Mem:50.76M (0.00M, Peak 50.82M) | Time:00:00.03 | Preparing Scene data
Fra:1 Mem:50.76M (0.00M, Peak 50.82M) | Time:00:00.03 | Creating Shadowbuffers
Fra:1 Mem:50.76M (0.00M, Peak 50.82M) | Time:00:00.03 | Raytree.. preparing
Fra:1 Mem:53.80M (0.00M, Peak 53.80M) | Time:00:00.03 | Raytree.. building
Fra:1 Mem:53.65M (0.00M, Peak 58.41M) | Time:00:00.08 | Raytree finished
Fra:1 Mem:53.65M (0.00M, Peak 58.41M) | Time:00:00.08 | Creating Environment maps
Fra:1 Mem:53.65M (0.00M, Peak 58.41M) | Time:00:00.08 | Caching Point Densities
Fra:1 Mem:53.65M (0.00M, Peak 58.41M) | Time:00:00.08 | Sce: Scene Ve:24273 Fa:22152 La:2
Fra:1 Mem:53.65M (0.00M, Peak 58.41M) | Time:00:00.08 | Loading voxel datasets
Fra:1 Mem:53.65M (0.00M, Peak 58.41M) | Time:00:00.08 | Sce: Scene Ve:24273 Fa:22152 La:2
Fra:1 Mem:53.65M (0.00M, Peak 58.41M) | Time:00:00.08 | Sce: Scene Ve:24273 Fa:22152 La:2
Fra:1 Mem:53.65M (0.00M, Peak 58.41M) | Time:00:00.08 | Volume preprocessing
Fra:1 Mem:53.65M (0.00M, Peak 58.41M) | Time:00:00.08 | Sce: Scene Ve:24273 Fa:22152 La:2
Fra:1 Mem:53.65M (0.00M, Peak 58.41M) | Time:00:00.08 | Sce: Scene Ve:24273 Fa:22152 La:2
Fra:1 Mem:56.23M (0.00M, Peak 58.41M) | Time:00:00.09 | Scene, Part 2-100
Fra:1 Mem:56.28M (0.00M, Peak 58.41M) | Time:00:00.10 | Scene, Part 3-100
Fra:1 Mem:56.32M (0.00M, Peak 58.41M) | Time:00:00.10 | Scene, Part 1-100
Fra:1 Mem:56.32M (0.00M, Peak 58.41M) | Time:00:00.10 | Scene, Part 5-100
Fra:1 Mem:56.16M (0.00M, Peak 58.41M) | Time:00:00.10 | Scene, Part 4-100
Fra:1 Mem:55.45M (0.00M, Peak 58.41M) | Time:00:00.11 | Scene, Part 6-100
Fra:1 Mem:55.55M (0.00M, Peak 58.41M) | Time:00:00.11 | Scene, Part 8-100
Fra:1 Mem:55.77M (0.00M, Peak 58.41M) | Time:00:00.11 | Scene, Part 7-100
Fra:1 Mem:55.70M (0.00M, Peak 58.41M) | Time:00:00.11 | Scene, Part 9-100
Fra:1 Mem:55.70M (0.00M, Peak 58.41M) | Time:00:00.12 | Scene, Part 11-100
Fra:1 Mem:55.73M (0.00M, Peak 58.41M) | Time:00:00.12 | Scene, Part 12-100
Fra:1 Mem:55.80M (0.00M, Peak 58.41M) | Time:00:00.12 | Scene, Part 14-100
Fra:1 Mem:55.61M (0.00M, Peak 58.41M) | Time:00:00.12 | Scene, Part 10-100
Fra:1 Mem:55.61M (0.00M, Peak 58.41M) | Time:00:00.12 | Scene, Part 13-100
Fra:1 Mem:55.77M (0.00M, Peak 58.41M) | Time:00:00.12 | Scene, Part 15-100
Fra:1 Mem:55.07M (0.00M, Peak 58.41M) | Time:00:00.13 | Scene, Part 18-100
Fra:1 Mem:54.86M (0.00M, Peak 58.41M) | Time:00:00.13 | Scene, Part 17-100
Fra:1 Mem:55.68M (0.00M, Peak 58.41M) | Time:00:00.13 | Scene, Part 19-100
Fra:1 Mem:55.61M (0.00M, Peak 58.41M) | Time:00:00.13 | Scene, Part 16-100
Fra:1 Mem:55.73M (0.00M, Peak 58.41M) | Time:00:00.13 | Scene, Part 20-100
Fra:1 Mem:55.32M (0.00M, Peak 58.41M) | Time:00:00.13 | Scene, Part 22-100
Fra:1 Mem:55.50M (0.00M, Peak 58.41M) | Time:00:00.13 | Scene, Part 24-100
Fra:1 Mem:55.52M (0.00M, Peak 58.41M) | Time:00:00.13 | Scene, Part 25-100
Fra:1 Mem:55.61M (0.00M, Peak 58.41M) | Time:00:00.13 | Scene, Part 23-100
Fra:1 Mem:55.29M (0.00M, Peak 58.41M) | Time:00:00.14 | Scene, Part 28-100
Fra:1 Mem:55.32M (0.00M, Peak 58.41M) | Time:00:00.14 | Scene, Part 21-100
Fra:1 Mem:55.45M (0.00M, Peak 58.41M) | Time:00:00.14 | Scene, Part 27-100
Fra:1 Mem:55.39M (0.00M, Peak 58.41M) | Time:00:00.14 | Scene, Part 29-100
Fra:1 Mem:55.18M (0.00M, Peak 58.41M) | Time:00:00.14 | Scene, Part 26-100
Fra:1 Mem:55.48M (0.00M, Peak 58.41M) | Time:00:00.14 | Scene, Part 30-100
Fra:1 Mem:55.71M (0.00M, Peak 58.41M) | Time:00:00.14 | Scene, Part 31-100
Fra:1 Mem:55.27M (0.00M, Peak 58.41M) | Time:00:00.14 | Scene, Part 32-100
Fra:1 Mem:55.48M (0.00M, Peak 58.41M) | Time:00:00.14 | Scene, Part 34-100
Fra:1 Mem:55.16M (0.00M, Peak 58.41M) | Time:00:00.14 | Scene, Part 36-100
Fra:1 Mem:55.32M (0.00M, Peak 58.41M) | Time:00:00.14 | Scene, Part 37-100
Fra:1 Mem:55.39M (0.00M, Peak 58.41M) | Time:00:00.14 | Scene, Part 35-100
Fra:1 Mem:55.48M (0.00M, Peak 58.41M) | Time:00:00.14 | Scene, Part 38-100
Fra:1 Mem:55.32M (0.00M, Peak 58.41M) | Time:00:00.14 | Scene, Part 40-100
Fra:1 Mem:55.32M (0.00M, Peak 58.41M) | Time:00:00.14 | Scene, Part 41-100
Fra:1 Mem:55.27M (0.00M, Peak 58.41M) | Time:00:00.14 | Scene, Part 33-100
Fra:1 Mem:55.54M (0.00M, Peak 58.41M) | Time:00:00.14 | Scene, Part 42-100
Fra:1 Mem:55.11M (0.00M, Peak 58.41M) | Time:00:00.15 | Scene, Part 44-100
Fra:1 Mem:55.23M (0.00M, Peak 58.41M) | Time:00:00.15 | Scene, Part 45-100
Fra:1 Mem:55.32M (0.00M, Peak 58.41M) | Time:00:00.15 | Scene, Part 39-100
Fra:1 Mem:55.48M (0.00M, Peak 58.41M) | Time:00:00.15 | Scene, Part 46-100
Fra:1 Mem:55.61M (0.00M, Peak 58.41M) | Time:00:00.15 | Scene, Part 43-100
Fra:1 Mem:55.32M (0.00M, Peak 58.41M) | Time:00:00.15 | Scene, Part 48-100
Fra:1 Mem:55.48M (0.00M, Peak 58.41M) | Time:00:00.15 | Scene, Part 47-100
Fra:1 Mem:55.48M (0.00M, Peak 58.41M) | Time:00:00.15 | Scene, Part 49-100
Fra:1 Mem:55.55M (0.00M, Peak 58.41M) | Time:00:00.15 | Scene, Part 50-100
Fra:1 Mem:54.90M (0.00M, Peak 58.41M) | Time:00:00.15 | Scene, Part 53-100
Fra:1 Mem:55.61M (0.00M, Peak 58.41M) | Time:00:00.15 | Scene, Part 51-100
Fra:1 Mem:55.59M (0.00M, Peak 58.41M) | Time:00:00.15 | Scene, Part 52-100
Fra:1 Mem:55.55M (0.00M, Peak 58.41M) | Time:00:00.15 | Scene, Part 54-100
Fra:1 Mem:55.27M (0.00M, Peak 58.41M) | Time:00:00.15 | Scene, Part 57-100
Fra:1 Mem:55.13M (0.00M, Peak 58.41M) | Time:00:00.15 | Scene, Part 56-100
Fra:1 Mem:55.48M (0.00M, Peak 58.41M) | Time:00:00.15 | Scene, Part 55-100
Fra:1 Mem:55.71M (0.00M, Peak 58.41M) | Time:00:00.15 | Scene, Part 58-100
Fra:1 Mem:55.39M (0.00M, Peak 58.41M) | Time:00:00.15 | Scene, Part 59-100
Fra:1 Mem:55.18M (0.00M, Peak 58.41M) | Time:00:00.15 | Scene, Part 60-100
Fra:1 Mem:55.48M (0.00M, Peak 58.41M) | Time:00:00.15 | Scene, Part 61-100
Fra:1 Mem:55.57M (0.00M, Peak 58.41M) | Time:00:00.15 | Scene, Part 62-100
Fra:1 Mem:54.66M (0.00M, Peak 58.41M) | Time:00:00.15 | Scene, Part 66-100
Fra:1 Mem:54.63M (0.00M, Peak 58.41M) | Time:00:00.15 | Scene, Part 63-100
Fra:1 Mem:55.17M (0.00M, Peak 58.41M) | Time:00:00.15 | Scene, Part 65-100
Fra:1 Mem:54.87M (0.00M, Peak 58.41M) | Time:00:00.15 | Scene, Part 64-100
Fra:1 Mem:54.89M (0.00M, Peak 58.41M) | Time:00:00.15 | Scene, Part 69-100
Fra:1 Mem:55.02M (0.00M, Peak 58.41M) | Time:00:00.15 | Scene, Part 67-100
Fra:1 Mem:55.04M (0.00M, Peak 58.41M) | Time:00:00.15 | Scene, Part 68-100
Fra:1 Mem:54.75M (0.00M, Peak 58.41M) | Time:00:00.15 | Scene, Part 72-100
Fra:1 Mem:55.18M (0.00M, Peak 58.41M) | Time:00:00.15 | Scene, Part 71-100
Fra:1 Mem:55.36M (0.00M, Peak 58.41M) | Time:00:00.15 | Scene, Part 73-100
Fra:1 Mem:55.43M (0.00M, Peak 58.41M) | Time:00:00.15 | Scene, Part 70-100
Fra:1 Mem:55.67M (0.00M, Peak 58.41M) | Time:00:00.15 | Scene, Part 74-100
Fra:1 Mem:55.39M (0.00M, Peak 58.41M) | Time:00:00.15 | Scene, Part 78-100
Fra:1 Mem:55.14M (0.00M, Peak 58.41M) | Time:00:00.15 | Scene, Part 76-100
Fra:1 Mem:55.36M (0.00M, Peak 58.41M) | Time:00:00.15 | Scene, Part 79-100
Fra:1 Mem:55.48M (0.00M, Peak 58.41M) | Time:00:00.15 | Scene, Part 77-100
Fra:1 Mem:55.35M (0.00M, Peak 58.41M) | Time:00:00.15 | Scene, Part 80-100
Fra:1 Mem:55.47M (0.00M, Peak 58.41M) | Time:00:00.15 | Scene, Part 82-100
Fra:1 Mem:55.04M (0.00M, Peak 58.41M) | Time:00:00.15 | Scene, Part 83-100
Fra:1 Mem:55.32M (0.00M, Peak 58.41M) | Time:00:00.15 | Scene, Part 81-100
Fra:1 Mem:55.29M (0.00M, Peak 58.41M) | Time:00:00.15 | Scene, Part 84-100
Fra:1 Mem:55.27M (0.00M, Peak 58.41M) | Time:00:00.15 | Scene, Part 86-100
Fra:1 Mem:55.14M (0.00M, Peak 58.41M) | Time:00:00.15 | Scene, Part 87-100
Fra:1 Mem:55.04M (0.00M, Peak 58.41M) | Time:00:00.16 | Scene, Part 88-100
Fra:1 Mem:55.30M (0.00M, Peak 58.41M) | Time:00:00.16 | Scene, Part 89-100
Fra:1 Mem:55.26M (0.00M, Peak 58.41M) | Time:00:00.16 | Scene, Part 75-100
Fra:1 Mem:55.20M (0.00M, Peak 58.41M) | Time:00:00.16 | Scene, Part 91-100
Fra:1 Mem:55.30M (0.00M, Peak 58.41M) | Time:00:00.16 | Scene, Part 92-100
Fra:1 Mem:55.46M (0.00M, Peak 58.41M) | Time:00:00.16 | Scene, Part 90-100
Fra:1 Mem:55.58M (0.00M, Peak 58.41M) | Time:00:00.16 | Scene, Part 93-100
Fra:1 Mem:55.25M (0.00M, Peak 58.41M) | Time:00:00.16 | Scene, Part 95-100
Fra:1 Mem:55.50M (0.00M, Peak 58.41M) | Time:00:00.16 | Scene, Part 96-100
Fra:1 Mem:55.04M (0.00M, Peak 58.41M) | Time:00:00.16 | Scene, Part 98-100
Fra:1 Mem:55.01M (0.00M, Peak 58.41M) | Time:00:00.16 | Scene, Part 85-100
Fra:1 Mem:54.59M (0.00M, Peak 58.41M) | Time:00:00.16 | Scene, Part 97-100
Fra:1 Mem:54.01M (0.00M, Peak 58.41M) | Time:00:00.16 | Scene, Part 100-100
Fra:1 Mem:53.97M (0.00M, Peak 58.41M) | Time:00:00.16 | Scene, Part 99-100
Fra:1 Mem:53.88M (0.00M, Peak 58.41M) | Time:00:00.16 | Scene, Part 94-100
Fra:1 Mem:31.80M (0.00M, Peak 58.41M) | Time:00:00.16 | Compositing
Fra:1 Mem:31.80M (0.00M, Peak 58.41M) | Time:00:00.16 | Compositing | Determining resolution
Fra:1 Mem:31.80M (0.00M, Peak 58.41M) | Time:00:00.16 | Compositing | Initializing execution
Fra:1 Mem:44.16M (0.00M, Peak 58.41M) | Time:00:00.16 | Compositing | Tile 1-9
Fra:1 Mem:44.16M (0.00M, Peak 58.41M) | Time:00:00.16 | Compositing | Tile 2-9
Fra:1 Mem:44.16M (0.00M, Peak 58.41M) | Time:00:00.16 | Compositing | Tile 3-9
Fra:1 Mem:44.16M (0.00M, Peak 58.41M) | Time:00:00.16 | Compositing | Tile 4-9
Fra:1 Mem:44.16M (0.00M, Peak 58.41M) | Time:00:00.16 | Compositing | Tile 5-9
Fra:1 Mem:44.16M (0.00M, Peak 58.41M) | Time:00:00.16 | Compositing | Tile 6-9
Fra:1 Mem:44.16M (0.00M, Peak 58.41M) | Time:00:00.16 | Compositing | Tile 7-9
Fra:1 Mem:44.16M (0.00M, Peak 58.41M) | Time:00:00.16 | Compositing | Tile 8-9
Fra:1 Mem:44.16M (0.00M, Peak 58.41M) | Time:00:00.16 | Compositing | Tile 9-9
Fra:1 Mem:44.16M (0.00M, Peak 58.41M) | Time:00:00.16 | Compositing | Tile 1-9
Fra:1 Mem:44.16M (0.00M, Peak 58.41M) | Time:00:00.16 | Compositing | Tile 2-9
Fra:1 Mem:44.16M (0.00M, Peak 58.41M) | Time:00:00.16 | Compositing | Tile 3-9
Fra:1 Mem:44.16M (0.00M, Peak 58.41M) | Time:00:00.17 | Compositing | Tile 4-9
Fra:1 Mem:44.16M (0.00M, Peak 58.41M) | Time:00:00.17 | Compositing | Tile 5-9
Fra:1 Mem:44.16M (0.00M, Peak 58.41M) | Time:00:00.17 | Compositing | Tile 6-9
Fra:1 Mem:44.16M (0.00M, Peak 58.41M) | Time:00:00.17 | Compositing | Tile 7-9
Fra:1 Mem:44.16M (0.00M, Peak 58.41M) | Time:00:00.17 | Compositing | Tile 8-9
Fra:1 Mem:44.16M (0.00M, Peak 58.41M) | Time:00:00.17 | Compositing | Tile 9-9
Fra:1 Mem:44.16M (0.00M, Peak 58.41M) | Time:00:00.17 | Compositing | Tile 1-9
Fra:1 Mem:44.16M (0.00M, Peak 58.41M) | Time:00:00.17 | Compositing | Tile 2-9
Fra:1 Mem:44.16M (0.00M, Peak 58.41M) | Time:00:00.17 | Compositing | Tile 3-9
Fra:1 Mem:44.16M (0.00M, Peak 58.41M) | Time:00:00.17 | Compositing | Tile 4-9
Fra:1 Mem:44.16M (0.00M, Peak 58.41M) | Time:00:00.17 | Compositing | Tile 5-9
Fra:1 Mem:44.16M (0.00M, Peak 58.41M) | Time:00:00.17 | Compositing | Tile 6-9
Fra:1 Mem:44.16M (0.00M, Peak 58.41M) | Time:00:00.17 | Compositing | Tile 7-9
Fra:1 Mem:44.16M (0.00M, Peak 58.41M) | Time:00:00.17 | Compositing | Tile 8-9
Fra:1 Mem:44.16M (0.00M, Peak 58.41M) | Time:00:00.17 | Compositing | Tile 9-9
Fra:1 Mem:44.16M (0.00M, Peak 58.41M) | Time:00:00.17 | Compositing | Deinitializing execution
Saved: ./Model11_colored/data11_difficultcar/data11_difficultcar_r_216_depth.png0001.png
Saved: ./Model11_colored/data11_difficultcar/data11_difficultcar_r_216_normal.png0001.png
Saved: ./Model11_colored/data11_difficultcar/data11_difficultcar_r_216_albedo.png0001.png
Fra:1 Mem:31.80M (0.00M, Peak 58.41M) | Time:00:00.28 | Sce: Scene Ve:24273 Fa:22152 La:2
Saved: ./Model11_colored/data11_difficultcar/data11_difficultcar_r_216.png
Time: 00:00.33 (Saving: 00:00.04)
Does this help? also , can u tell , which file are u rendering from? is it Model.obj or Model_normalized.obj, its just that in the ShapeNET dataset, I just find files with this name model_normalized.obj .
thank you again :) really appreciate it

The output you pasted doesn't indicate anything's wrong. Maybe this thread is of help: https://blender.stackexchange.com/questions/24020/importing-obj-with-mtl-and-image-not-working-properly

Hi,
So I figured my problem :+1:  :-) Basically I wasnt using the .mtl file at all whereas this code does require it. The first page which says using a single .obj file and rendering images is kind of misleading if maybe you can modify that and write using xyz.mtl and xyz.obj files to render images.
Otherwise I think this is the best ShapeNET rendering code I have encountered so far and the easiest to use.
A few more suggestions,maybe you can mention how to download blender via terminal and that the code doesnt require a GPU and the new version 2 of ShapeNET dataset has changed the file names to

Thanks a lot ! :1st_place_medal:

Glad it worked out!
Can you give the exact invocation you used? I'll adapt the documentation then.

Sure, here this is what I was using
blender --background --python render_blender.py -- --output_folder ./Output0 ./dcdee01d7fe6e1a76ad064d1c5fdd7c/models/model_normalized.obj
< P.S: however, make sure there is a 'model_normalized.mtl' file in the same models folder >


vscode 1.3.x Why icons are transparent...?

Please, read the readme faqs and try what it's said. It will also good to have more info about your system, extension version... it looks like you haven't executed "icons update" command.

@robertohuertasm , unfortunately, I've tried, but it is still not working.

I'll suggest you to reinstall VSCode.

@robertohuertasm, unfortunately, still not working.

Which OS?

OS X 11.12 beta 2 (16A239j),  VSCode 1.3.1

@fenbox are you also using OS X 11?

@robertohuertasm OS X 10.11.5

@fenbox it seems that you're having trouble downloading the icons.zip file... Are you behind a proxy?

@fenbox it seems that you're having trouble downloading the icons.zip file... Are you behind a proxy?

@frogcjn can you open the developer tools and see if you have something in your console?

@robertohuertasm Yes, I can't download the zip file directly. Use proxy and run Icons Update works for me.

@frogcjn can you confirm that? In case you want to get information about how to proceed if you're behind a proxy see #21

[Extension Host] null
threadService.ts:214 [Extension Host] null


enableCEC not working

When I set enableCEC to true (without quotes / double quotes) I'm getting an error:
(I already installed the cec-tools via sudo apt-get install cec-tools)
Error: spawn cec-client ENOENT
at Process.ChildProcess._handle.onexit (internal/child_process.js:190:19)
at onErrorNT (internal/child_process.js:362:16)
at _combinedTickCallback (internal/process/next_tick.js:139:11)
at process._tickCallback (internal/process/next_tick.js:181:9)
at Function.Module.runMain (module.js:696:11)
at startup (bootstrap_node.js:204:16)
at bootstrap_node.js:625:3
/homebridge/node_modules/node-cec/lib/node-cec.js:64
return this.client.kill('SIGINT');
^
TypeError: Cannot read property 'kill' of undefined
at process.NodeCec.NodeCec.stop (/homebridge/node_modules/node-cec/lib/node-cec.js:64:26)
at emitOne (events.js:116:13)
at process.emit (events.js:211:7)
at process.emit (/usr/local/lib/node_modules/homebridge-config-ui-x/node_modules/source-map-support/source-map-support.js:461:21)
at process.exit (internal/process.js:146:15)
at printErrorAndExit (/usr/local/lib/node_modules/homebridge-config-ui-x/node_modules/source-map-support/source-map-support.js:445:11)
at process.emit (/usr/local/lib/node_modules/homebridge-config-ui-x/node_modules/source-map-support/source-map-support.js:457:16)
at process._fatalException (bootstrap_node.js:391:26)
Can you help out?
I'm using the homebridge in a docker RPi environment.
My Samsung TV is a UE48JU7000

It looks like the cec-utils are not installed within the docker container which result in the error. I've installed homebridge without the docker container and now the cec-client works.


Aurelia-Typescript-Webpack-Asp.net5

Would it be possible to have template that uses the above?
At the moment I am trying to cobble together the Aurelia-Typescript-We pack template and the Aurelia-Typescript-Asp.net5 templates but don't really know what I'm doing here.
Will persevere but if anybody that actually understands this stuff can wip up a template that would be great.
Thanks

We are working on a solution via our cli which will enable multiple build systems and integration into visual studio. There are multiple issues tracking various aspects of this.


Small improvements

Hi! u/Follpvosten from Reddit here.
I've made a couple smaller incremental changes; each commit has a longer message that describes why I applied that specific change.
If you have any questions, critique or improvements I could apply, just let me know!

Ok I just realized that the first commit message is wrong; it's not an array, it's a slice.

6 commits insane work
I'll merge these cause ur smart & i'm bad at Rust

It's just a number, these are very small commits :) have fun on your Rust journey, you've only started!


CI: add cake task to create the localdb database with basic test data req…

Initial script to create a test database to help run unit tests in the solution.
To test you can run the following command .\build.ps1 -Target CreateDatabase
This is also not on the default build, I'm going to manually trigger a build which will run the BuildWithDatabase task and review the logs from VSTS.

#2234


Confirm: allowed to call ElementQueries.init multiple times?

Each time when new dom-elements are added dynamically I need to call ElementQueries.init.
Is this supported? I.e.: no duplicate listeners on already existing elements, etc?
Intuitively (naively?), from a performance standpoint it might make sense to just provide a collection of the newly added dom-elements to ElementQueries as a pruning filter to speed up performance. Is this supported, useful to add or not needed?

Yes you can call .init as often as you want. It only adds new not yet known elements to the tracked elements. I like the idea of limiting the init call to some known elements. The thing is, the tracker doesn't work that way. It doesn't start with an element but with the css. Limiting css rules based on elements is not yet possible since css rules need to be parsed anyway and once executed the current filter, by jumping over the elements it already knows, has the same performance impact. One thing that could improve performance is Element.querySelectorall (https://developer.mozilla.org/en/docs/Web/API/Element/querySelectorAll) which executes css rules that contain a element query statement ([max-width~=...], ...) in the context of the given element that you definitely know has some changed sub elements.
Possible API: ElementQueries.init(myComponent), and init is passing the myComponent from findElementQueriesElements to getQuery(myComponent) which returns then not a global document. querySelectorAll but a myComponent.querySelectorAll which should increase performance due to the fact that it does only need to check css rules again a sub set of DOM elements instead of all. Do you want to provide a Pull-Request? :)

This could also be the base for the integration in libraries like Angular or React (#81) where each Component could trigger a ElementQueries.init(myComponent when it detects that its DOM has been re-rendered. I'm only not yet sure if such events exist in those libraries.

Cheers.

since css rules need to be parsed anyway and once executed the current filter, by jumping over the elements it already knows, has the same performance impact.

Does this mean parsing css is done on every call to ElementQueries.init? Feels like a caching opportunity here.

Not parsing (meaning reading all css files), but executing the cached css rules to get from querySelectAll all elements that apply.

Limiting the scope of querySelectorAll as described above could reduce cpu usage

@marcj Angular 1.x directives' provide function that are called when DOM is ready to be manipulated (see https://docs.angularjs.org/api/ng/service/$compile#post-linking-function), I tried it and it works perfectly so far.. using your lib really changed the way I think about my layout when I build my components :) thx for that.

Possible API: ElementQueries.init(myComponent), and init is passing the myComponent from findElementQueriesElements to getQuery(myComponent) which returns then not a global document. querySelectorAll but a myComponent.querySelectorAll which should increase performance due to the fact that it does only need to check css rules again a sub set of DOM elements instead of all. Do you want to provide a Pull-Request? :)

I'll look into this and the code and if I am confident, I'll comment again and work on the feature.

I have currently performance issues when calling ElementQueries.init() every time the HTML is changed (takes up to 100ms).
As the CSS is only loaded once - the rules don't need to be read again - wouldn't it be possible to expose findElementQueriesElements() to ElementQueries so that only this function needs to be called after HTML is changed? (takes only about 20ms)

Yeah, sure. Feel free to send a pull request. The new public method ElementQueries.findElementQueriesElement(container = null) should get an optional container to limit to search to a subtree in the DOM.

Any updates on this? :)

I also would like to see support added for this. I have a library that loads on sites I don't control. I'm concerned someone may load my script (which uses ElementQueries) and also have either their own copy of ElementQueries or -- for some odd reason -- have elements defined with the attributes ElementQueries looks for (max-width, etc). To prevent my copy of ElementQueries from affecting elements I don't control, I need to somehow restrict its functionality to specific elements/components.
I'll try to throw up a PR when I have some time to carve out for this.


Window Opacity and Click-Through Ability

Description of the new feature / enhancement
To be able to set a percentage for the transparency of certain windows and to be able to make them click-through.
Scenario when this would be used?
Trying to write from a picture where text can't be read through text extractor for its formatting, handwriting, etc.
Watching a video on the player while trying to do something else.
Supporting information
https://www.mobzystems.com/tools/seethroughwindows/
https://github.com/mobzystems/SeeThroughWindows

/dup https://github.com/microsoft/PowerToys/issues/1084


Feature request: Checks that unless is not used with multiple conditions.

I was worried about the poor readability of code using unless with multiple conditions.
unless foo && bar
  something
end

Looking at the code like the above, I first think about De Morgan's law, rewrite it and proceed with implementation. This is a very painful task.
In order to prevent this problem, I created a cop called Lint/UnlessMultipleCondtions.
https://github.com/wata727/rubocop/commit/da4ed994d5fd263c4e08d4df98ea6cd716244ca3
However, when this Cop is executed to RuboCop, the result is as follows:
...

lib/rubocop/config_loader.rb:128:23: W: Lint/UnlessMultipleConditions: Avoid using unless with multiple conditions.
        return unless hash['AllCops'] && hash['AllCops'][version]
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

1101 files inspected, 140 offenses detected
RuboCop failed!

I don't mind fixing these problems, but I doubt if this fix will be accepted by the community.
Please tell me your opinion :)

I've been hoping to see this cop for a long time. It's a shame it wasn't merged.
Have you had any chance to revisit this issue and, perhaps, think about better impementation?
While I agree that not all composite conditions are bad, especially in the multiline approach, I'd love to have an option to warn about conditions that look return xxx unless a && b || c
There's rarely a good reason to use such complex examples, to be honest.
I've found that I write this code for two reasons:
Compaction. If I have multiple guards, I can turn them into one
return unless user
return unless order.shipped?

# turns into

return unless user && order.shipped?

I still believe that this code is harder to reason about than the alternative. While the compaction may be good, it's still not as good as the composite if
return if user.nil? || !order.shipped?

or even better – some kind of predicate that encapsulates the logic
return unless applicable?

Avoiding explicit #nil? checks. While it will definitely trick reek into not firing NilCheck violation, it's still not a decent reason to make the code more complicated
While I believe that this cop should not be auto correctable, it should probably exist in some way

I've been hoping to see this cop for a long time. It's a shame it wasn't merged.

Agreed!

cat.pet unless cat.lion? || cat.tiger?

cat.pet unless cat.large? && cat.fangs?

These examples both seem perfectly readable.

Just to offer my own $0.02: I've been working with Ruby professionally for ~8 years, through being a Homebrew maintainer for ~12 years and programming professionally (not just using Ruby) for ~14 years and: I find all cases of unless ... || or unless ... && (including the above) hard to mentally parse and, particularly, to accurately and consistent reverse the logic (by turning it into an if).
That's not to say it should be a default cop or whether it should be a style/lint/whatever cop but: I think there is a valid need for a cop like this and it can improve readability (particularly for those coming from languages without an unless operator).

I've been hoping to see this cop for a long time. It's a shame it wasn't merged.

Agreed!

cat.pet unless cat.lion? || cat.tiger?

cat.pet unless cat.large? && cat.fangs?

These examples both seem perfectly readable.

Just to offer my own $0.02: I've been working with Ruby professionally for ~8 years, through being a Homebrew maintainer for ~12 years and programming professionally (not just using Ruby) for ~14 years and: I find all cases of unless ... || or unless ... && (including the above) hard to mentally parse and, particularly, to accurately and consistent reverse the logic (by turning it into an if).
That's not to say it should be a default cop or whether it should be a style/lint/whatever cop but: I think there is a valid need for a cop like this and it can improve readability (particularly for those coming from languages without an unless operator).

It seems there's good reason to think this cop would be useful to people, and the issue was only automatically closed by GitHub when the first PR was closed by it's author, so let's re-open this one. 🙂

It seems there's good reason to think this cop would be useful to people, and the issue was only automatically closed by GitHub when the first PR was closed by it's author, so let's re-open this one. 🙂

While I agree that not all composite conditions are bad, especially in the multiline approach, I'd love to have an option to warn about conditions that look return xxx unless a && b || c

This is a good idea. The starting point could be to warn against using opposing boolean operators in unless.
# ok
return xxx unless a && b && c
return xxx unless a || b || c

# not ok
return xxx unless a && b || c ...
return xxx unless a || b && c ...

What should it do if the condition is within (), which would improve readability significantly?
return xxx unless a && (b || c)

While I agree that not all composite conditions are bad, especially in the multiline approach, I'd love to have an option to warn about conditions that look return xxx unless a && b || c

This is a good idea. The starting point could be to warn against using opposing boolean operators in unless.
# ok
return xxx unless a && b && c
return xxx unless a || b || c

# not ok
return xxx unless a && b || c ...
return xxx unless a || b && c ...

What should it do if the condition is within (), which would improve readability significantly?
return xxx unless a && (b || c)

I created https://github.com/rubocop-hq/rubocop/pull/9386 to check for mixed use of && and || in unless. I think this is a more lenient approach as compared to using unless with multiple conditions. Currently there are 6 offenses in Rubocop.

I created https://github.com/rubocop-hq/rubocop/pull/9386 to check for mixed use of && and || in unless. I think this is a more lenient approach as compared to using unless with multiple conditions. Currently there are 6 offenses in Rubocop.

Hi,
I just updated rubocop to 1.11.0 and started getting
C: Style/UnlessLogicalOperators: Do not use mixed logical operators in an unless.

on a line that reads
unless values[:client][:insurance_company] == 999

I couldn't find any documentation for this cop, which is understandable if it's very new. I tend to set EnabledByDefault to true and then manually disable cops I don't like. If I didn't set this, the cop would probably be disabled.
I don't think there's a logical operator in this condition (equality operator is a boolean operator, but not a logical one AFAIK) and they definitely aren't mixed, so either there's a bug or I got the message completely wrong.

Could I get some info about this? If it is a bug, can I provide some more context? If not, what change am I supposed to make to fix this?
P.S.: Thanks for this awesome gem, I use it everywhere and it definitely makes my codebases better.

Could I get some info about this? If it is a bug, can I provide some more context? If not, what change am I supposed to make to fix this?

It's a bug, so it'd be best to file a ticket about it.
The docs are here - https://docs.rubocop.org/rubocop/1.11/cops_style.html#styleunlesslogicaloperators

Wow, that was fast.

It's a bug, so it'd be best to file a ticket about it.

ok, will do.

The docs are here - https://docs.rubocop.org/rubocop/1.11/cops_style.html#styleunlesslogicaloperators

hmm, that's strange, I looked like 3 mins before posting (without the version in the url) and couldn't find i there. now i just refreshed, used the same search string and immediately found it. thanks.

It's a bug, so it'd be best to file a ticket about it.

ok, will do.

here


Add option to log container into stdout

This PR adds an option to StrimziKafkaContainer, and StrimziKafkaCluster to print the log of the containers to do stdout.
An example of the log can be found [1].
[1] - https://gist.githubusercontent.com/see-quick/8d88a97b533f8910ec2af135071b6ab7/raw/57e6cc73e8a875de75e0655677fac30bba5b67f8/gistfile1.txt

Also, would some environment variable or system property be better for a switch like that? If you aim this for troubleshooting, then you likely do not want to modify the tests to troubleshooth but for example just set an environment variable maybe?

Wouldn't be better to log it to file instead of to console? Guess it can pollute the log quite quickly in case user will have more than few containers.

Also, would some environment variable or system property be better for a switch like that? If you aim this for troubleshooting, then you likely do not want to modify the tests to troubleshooth but for example just set an environment variable maybe?

Wouldn't be better to log it to file instead of to console? Guess it can pollute the log quite quickly in case user will have more than few containers.

So in that case I think it would be best to call getLogs() (if something bad happens) and append it to the logs files inside /target/strimzi-test-container/<date> as we have for instance LogCollector.

Also, would some environment variable or system property be better for a switch like that? If you aim this for troubleshooting, then you likely do not want to modify the tests to troubleshooth but for example just set an environment variable maybe?

Yeah, this is a good point. I think it would be better to use ENV or system property here. The main reason it to just enhance current troubleshooting in CI.

Any opinions on this @scholzj @Frawless? I can start with just:

Add ENV to enable console output for the container.

That would be the easiest way possible.

Any opinions on this @scholzj @Frawless? I can start with just:

Add ENV to enable console output for the container.

That would be the easiest way possible.

Yes, sounds reasonable to me.
I am thinking about option to force logging without env for certain situations/tests and I don't have strong opinion. I can imagine situations that might be useful, but user can also achieve ti with ENV option that will of course turn on logging for everything.

Maybe you should update the PR description and add something to the README.md file?

Yeah, thanks for it. I have updated it.


Client.Timeout Error

Hi, I'm getting these errors in the last 9 hours or so - is this on NVIDIA's end? Thanks in advance!
2020/09/29 09:21:37 Error getting session token from NVIDIA retrying...
2020/09/29 09:21:48 Get "https://store.nvidia.com/store/nvidia/SessionToken?format=json&=1601364098": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
2020/09/29 09:21:48 Error getting session token from NVIDIA retrying...
2020/09/29 09:22:00 Get "https://store.nvidia.com/store/nvidia/SessionToken?format=json&=1601364110": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
2020/09/29 09:22:00 Error getting session token from NVIDIA retrying...
2020/09/29 09:22:11 Get "https://store.nvidia.com/store/nvidia/SessionToken?format=json&=1601364121": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
2020/09/29 09:22:11 Error getting session token from NVIDIA retrying...
2020/09/29 09:22:21 Get "https://store.nvidia.com/store/nvidia/SessionToken?format=json&=1601364131": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
2020/09/29 09:22:21 Error getting session token from NVIDIA retrying...

See discord server for updates regarding this but yes it's on NVIDIAs end.


Error: git push -u origin main vs master

Bug Report
Current behavior
Using the command line, step five creates an error:

Type git push -u origin main to push the files you have locally to the remote on GitHub. (You may be asked to log in.)

The result is:
error: src refspec main does not match any
error: failed to push some refs to 'https://github.com/hermionexyz/github-upload.git'

Possible solution
This works instead:
git push -u origin master

Additional context
I guessed this solution after seeing this StackExchange answer using master instead of main. The answer says master was deprecated in 10-2020, so I'm guessing this tutorial hasn't been updated.

Hello @hermionexyz 👋🏻 Thank you for opening this issue!
We have updated this course to use main instead of master as the default branch for the instructions. This is part of a broader motion. The default branch name for new repositories created on GitHub is now main.
The behavior you encountered would be expected if a user setting has an alternative default branch name. This can be updated in your user account settings.
To read more, see this /renaming repository with a lot more context and information. 😊


BoundingBox Nullcheck removal

Fixes: #5028 .

Thanks for doing this!

Build is currently broken for other reasons, will get this in once we fix up the build.

/azp run mrtk_pr


An action when you click on the notification.

Hello,
Sorry for my English,
On a previous plugin, there was a "onNotificationOpen" function. Is there an equivalent on this pluggin? If yes, how ?
Thank you.

https://github.com/dpa99c/cordova-plugin-firebasex#breaking-api-changes


New format of terraform seems to not work with tfjson

I get unknown plan file version: 2
Also looks like tfjson is completely unmaintained. This seems to be the problem with terrorform: They constantly change the formats every version so scanning tools rapidly become out of date.

Hi @munntjlx
So this fork addresses that issue: https://github.com/philips/tfjson (the original by Palantir unfortunately does not last I checked).
Apologies, should have made it clearer in the documentation. It links to the fork but doesn't mention it's a fork is needed. LMK if that resolves your issue.

Alas, that version wouldn’t build on the mac. I did try to follow the directions but the binary didn’t work.
Sincerely,
Thomas J. Munn
Consulting Security Engineer
LexisNexis
On 7/2/19, 16:29, "mikesiegel" <notifications<EMAIL_ADDRESS>wrote:
*** External email: use caution ***
Hi @munntjlxhttps://github.com/munntjlx
So this fork addresses that issue: https://github.com/philips/tfjsonhttps://github.com/philips/tfjson (the original by Palantir unfortunately does not last I checked).
Apologies, should have made it clearer in the documentation. It links to the fork but doesn't mention it's a fork is needed. LMK if that resolves your issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/wayfair/terrafirma/issues/1?email_source=notifications&email_token=ALVIUB3RBWWZ4UIKWSVRA6LP5O2XHA5CNFSM4H46XW6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZCOLFI#issuecomment-507831701, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALVIUB62YQDIMCFKWY5QCFDP5O2XHANCNFSM4H46XW6A.

Ok, I'm actually on vacation at the moment but when I get back I'll see if
I can build it on a Mac. What version of golang are you using?
On Tue, Jul 2, 2019 at 4:42 PM Thomas Munn<EMAIL_ADDRESS>wrote:

Alas, that version wouldn’t build on the mac. I did try to follow the
directions but the binary didn’t work.
Sincerely,
Thomas J. Munn
Consulting Security Engineer
LexisNexis
On 7/2/19, 16:29, "mikesiegel"<EMAIL_ADDRESS><EMAIL_ADDRESS>wrote:
*** External email: use caution ***
Hi @munntjlxhttps://github.com/munntjlx
So this fork addresses that issue: https://github.com/philips/tfjson<
https://github.com/philips/tfjson> (the original by Palantir
unfortunately does not last I checked).
Apologies, should have made it clearer in the documentation. It links to
the fork but doesn't mention it's a fork is needed. LMK if that resolves
your issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<
https://github.com/wayfair/terrafirma/issues/1?email_source=notifications&email_token=ALVIUB3RBWWZ4UIKWSVRA6LP5O2XHA5CNFSM4H46XW6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZCOLFI#issuecomment-507831701>,
or mute the thread<
https://github.com/notifications/unsubscribe-auth/ALVIUB62YQDIMCFKWY5QCFDP5O2XHANCNFSM4H46XW6A>.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/wayfair/terrafirma/issues/1?email_source=notifications&email_token=ABPFB6KVP7QQA7XNOAQHOSLP5O4SJA5CNFSM4H46XW6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZCPTKQ#issuecomment-507836842,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPFB6PQI43HP3CD6I3XNTLP5O4SJANCNFSM4H46XW6A
.

--
Mike Siegel

I did get the 'proper' version working after some wrangling (it seems that I was too impatient, go dep takes 1000 years to run on the mac). Once I do that I then get a new error (with terraform 0.12.3): (after doing terraform plan -o blah.tf):
terraform.ReadPlan is no longer in use; use planfile.Open instead

I am going on vacation too, so don’t work too hard! The tfplan version 2 seems to be some kind of crazy zip file thing.
Sincerely,
Thomas J. Munn
Consulting Security Engineer
LexisNexis
On 7/2/19, 17:00, "mikesiegel" <notifications<EMAIL_ADDRESS>wrote:
*** External email: use caution ***
Ok, I'm actually on vacation at the moment but when I get back I'll see if
I can build it on a Mac. What version of golang are you using?
On Tue, Jul 2, 2019 at 4:42 PM Thomas Munn<EMAIL_ADDRESS>wrote:

Alas, that version wouldn’t build on the mac. I did try to follow the
directions but the binary didn’t work.
Sincerely,
Thomas J. Munn
Consulting Security Engineer
LexisNexis
On 7/2/19, 16:29, "mikesiegel"<EMAIL_ADDRESS><EMAIL_ADDRESS>wrote:
*** External email: use caution ***
Hi @munntjlx<https://github.com/munntjlxhttps://github.com/munntjlx>
So this fork addresses that issue: https://github.com/philips/tfjsonhttps://github.com/philips/tfjson<
https://github.com/philips/tfjsonhttps://github.com/philips/tfjson> (the original by Palantir
unfortunately does not last I checked).
Apologies, should have made it clearer in the documentation. It links to
the fork but doesn't mention it's a fork is needed. LMK if that resolves
your issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<
https://github.com/wayfair/terrafirma/issues/1?email_source=notifications&email_token=ALVIUB3RBWWZ4UIKWSVRA6LP5O2XHA5CNFSM4H46XW6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZCOLFI#issuecomment-507831701https://github.com/wayfair/terrafirma/issues/1?email_source=notifications&email_token=ALVIUB3RBWWZ4UIKWSVRA6LP5O2XHA5CNFSM4H46XW6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZCOLFI#issuecomment-507831701>,
or mute the thread<
https://github.com/notifications/unsubscribe-auth/ALVIUB62YQDIMCFKWY5QCFDP5O2XHANCNFSM4H46XW6Ahttps://github.com/notifications/unsubscribe-auth/ALVIUB62YQDIMCFKWY5QCFDP5O2XHANCNFSM4H46XW6A>.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<https://github.com/wayfair/terrafirma/issues/1?email_source=notifications&email_token=ABPFB6KVP7QQA7XNOAQHOSLP5O4SJA5CNFSM4H46XW6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZCPTKQ#issuecomment-507836842https://github.com/wayfair/terrafirma/issues/1?email_source=notifications&email_token=ABPFB6KVP7QQA7XNOAQHOSLP5O4SJA5CNFSM4H46XW6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZCPTKQ#issuecomment-507836842>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABPFB6PQI43HP3CD6I3XNTLP5O4SJANCNFSM4H46XW6Ahttps://github.com/notifications/unsubscribe-auth/ABPFB6PQI43HP3CD6I3XNTLP5O4SJANCNFSM4H46XW6A>
.

--
Mike Siegel
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/wayfair/terrafirma/issues/1?email_source=notifications&email_token=ALVIUBZI3VZTXGTT7XPM4UDP5O6XJA5CNFSM4H46XW6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZCRBCQ#issuecomment-507842698, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALVIUB4X367RVWAE6H2I4HLP5O6XJANCNFSM4H46XW6A.

go version was go version go1.12.6 darwin/amd64

my go binary seems different than the one from palantir, however.

bc531c59a9e0c144275a9ff85fc8a1d9e450158f4974c8b350afa92b859095d8  tfjson
sha256

I found this link which explains why it doesnt work anymore. I found this link for a better parser written in node. Might this work better than the unmaintained go?

Finally found out something interesting: version 0.12 has built in support for json output from tfplan files:
terraform show -json test.tfplan | jq

So we no longer need the JSON parse step but I suspect that the format might not be what you are expecting:

  "format_version": "0.1",
  "terraform_version": "0.12.3",
  "planned_values": {
    "root_module": {
      "resources": [
        {
          "address": "aws_instance.kaeptn-eichhorn",
          "mode": "managed",
          "type": "aws_instance",
          "name": "kaeptn-eichhorn",
          "provider_name": "aws",
          "schema_version": 1,
          "values": {
            "ami": "ami-13b8337c",
            "credit_specification": [],
            "disable_api_termination": null,
            "ebs_optimized": null,
            "get_password_data": false,
            "iam_instance_profile": null,
            "instance_initiated_shutdown_behavior": null,
            "instance_type": "t2.micro",
            "monitoring": null,
            "source_dest_check": true,
            "tags": null,
            "timeouts": null,
            "user_data": null,
            "user_data_base64": null
          }
        }
      ]
    }
  },
  "resource_changes": [
    {
      "address": "aws_instance.kaeptn-eichhorn",
      "mode": "managed",
      "type": "aws_instance",
      "name": "kaeptn-eichhorn",
      "provider_name": "aws",
      "change": {
        "actions": [
          "create"
        ],
        "before": null,
        "after": {
          "ami": "ami-13b8337c",
          "credit_specification": [],
          "disable_api_termination": null,
          "ebs_optimized": null,
          "get_password_data": false,
          "iam_instance_profile": null,
          "instance_initiated_shutdown_behavior": null,
          "instance_type": "t2.micro",
          "monitoring": null,
          "source_dest_check": true,
          "tags": null,
          "timeouts": null,
          "user_data": null,
          "user_data_base64": null
        },
        "after_unknown": {
          "arn": true,
          "associate_public_ip_address": true,
          "availability_zone": true,
          "cpu_core_count": true,
          "cpu_threads_per_core": true,
          "credit_specification": [],
          "ebs_block_device": true,
          "ephemeral_block_device": true,
          "host_id": true,
          "id": true,
          "instance_state": true,
          "ipv6_address_count": true,
          "ipv6_addresses": true,
          "key_name": true,
          "network_interface": true,
          "network_interface_id": true,
          "password_data": true,
          "placement_group": true,
          "primary_network_interface_id": true,
          "private_dns": true,
          "private_ip": true,
          "public_dns": true,
          "public_ip": true,
          "root_block_device": true,
          "security_groups": true,
          "subnet_id": true,
          "tenancy": true,
          "volume_tags": true,
          "vpc_security_group_ids": true
        }
      }
    }
  ],
  "configuration": {
    "provider_config": {
      "aws": {
        "name": "aws",
        "expressions": {
          "region": {
            "constant_value": "eu-central-1"
          }
        }
      }
    },
    "root_module": {
      "resources": [
        {
          "address": "aws_instance.kaeptn-eichhorn",
          "mode": "managed",
          "type": "aws_instance",
          "name": "kaeptn-eichhorn",
          "provider_config_key": "aws",
          "expressions": {
            "ami": {
              "constant_value": "ami-13b8337c"
            },
            "instance_type": {
              "constant_value": "t2.micro"
            }
          },
          "schema_version": 1
        }
      ]
    }
  }
}

Hoping this helps someone

I was able to use the json output feature from terraform to get similar json template and after minor modification in terraform.rego policy file it looks like working. still need to test it.
instead of tfplan terraform show -json tfplan.output | jq ".planned_values.root_module.resources | map ({(.type|tostring) : .}) | add" > tfplan.json
Sample Code :
https://github.com/rahulkiit/opaterraform


README.md tidying

Some tidying:

There were a bunch of double spaces in all the paragraphs.
Anchor links have been fixed (no HTML for you!).
SE Linux is spelled SELinux.
Emphasizing 'Note:' is a good practice.
Dory Google query looked odd, simple ?q= is enough
Some double line-space removed me thinks too.

lgtm.  Thanks for the cleanup!


Specific ExclusivityViolationError

I'd love to see a specific error for exclusivity violation errors. Something like:
export class ExclusivityViolationError extends ConstraintViolationError {
  objectFQN: string;
  property: string;
}

This would allow consumers to use these dynamic parts of the error message programmatically without having to regex parse the error message.

I'm aware of the overall constraint message refactor #6796 now.
This could still apply for all constraint errors.
I guess there's two options:

Have the drivers regex parse the message.
Do some kind of protocol work so that those strings are sent in dedicated slots.


Adding scraping methods to a class

As of now, tweet_basic_scraping.py contains independent functions hardcoded username and dates. We should add these methods to a common class definition which will take username, dates etc as arguments for __init__.
We should also add a scrape method that does all the scraping and adding to csv without having to call all the functions separately.

@ajaysub110 As discussed earlier, can I take up this issue?

Sure, please do


Database tables not created

Question
I am trying to run the project with PostGreSQL as store. When the application runs, it throws errors related to DataProtectionKeys  tables not being present. Do we need to run the migration manually?

My Bad. I figured it out from the documentation. Thanks for the great work.

Hey, i'am facing same problem. How do you figure it out please?


time and date based logging system

After creating your pull request, tick these boxes if they are applicable to you.

[ ] I have tested my changes against the review branch (the latest developmental version), and this pull request is targeting that branch as a base
[ ] I have tested my changes on Python 3.8 or higher
[ ] I have ensured my code is formatted using Black

Description
I didn't like that the logs wrote over themselves so I made it so log files had dates and times in the file name and when the bot runs it deletes logs older than a week
Related issues (if applicable)

https://docs.python.org/3/howto/logging-cookbook.html#using-file-rotation
In addition to what AleanaA has said, using a rotating file handler would be preferable.

I will retract my pull request then I'm not very experienced with python and this was the best I could do with my current skill level sorry I tried to help but I'm just not good enough to improve this

I guess my goal with this was to share my code even tho its not that great

would it be a problem if I made a feature request for this in issues?

if I made a feature request for this. I believe that you would have a better implementation than what I did

I figured I should ask if its ok to make an issue feature request regarding this I believe that the logging system could be better and I attempted to fix it but I just lack the skill to do it fully so I thought making a issue feature request would be reasonable I just wanted to run that idea by you guys to see if that would be ok

You can open a fr, however I'll be honest the likelihood of me getting to this one any time soon is low. I was rather hoping you'd implement the requested changes

I thought what I did was clever but its more that I just don't know what I'm doing I'm sorry for wasting you time

It's never a waste of time. You're taking the time to learn, when I first started using MusicBot I didn't even know how to do anything in Python. There's still lots of things I don't know. If you are unfamiliar with the requested changes, take some time to read up and improve.

the only reason I have been able to do stuff with your bot is because its laid out in a way that I can understand I am not familiar with python but I can edit things within your bot to suit specialized use cases I have made the mistake before of being a hostile fork but I do not wish to repeat that my fork only exist now to stay up to date with the dev branch

I apologize if I came off as hostile, that was not my intention I was trying to be positive and encourage learning.

its ok I should leave development to people who know what they're doing

Please do not become discouraged from our request for change. I highly encourage PR's and people to contribute. Our request are mostly due to the fact that we may not always have time to get around to stuff. Overall this is a great start! It just needs some adaptation for a wider audience. For example if someone was using this with a slow system they might get two different times from one instance.


Roll Plugins from fa95cde07812 to 72cbcacfefc2 (8 revisions)

https://github.com/flutter/plugins/compare/fa95cde07812...72cbcacfefc2
2021-02-19<EMAIL_ADDRESS>[package_info] Bump version for NNBD stable (flutter/plugins#3571)
2021-02-19<EMAIL_ADDRESS>[flutter_plugin_android_lifecycle] Bump version for NNBD stable (flutter/plugins#3569)
2021-02-19<EMAIL_ADDRESS>[path_provider] Bump platform interface package to stable NNBD (flutter/plugins#3568)
2021-02-19<EMAIL_ADDRESS>[in_app_purchase]  Migrate to NNBD (flutter/plugins#3555)
2021-02-19<EMAIL_ADDRESS>[url_launcher] Bump platform interface package to stable NNBD (flutter/plugins#3570)
2021-02-19<EMAIL_ADDRESS>[google_maps_flutter] Migrate to NNBD (flutter/plugins#3548)
2021-02-19<EMAIL_ADDRESS>[image_picker_for_web] Add doc comments to point out that some arguments aren't supported on the web (flutter/plugins#3566)
2021-02-19<EMAIL_ADDRESS>[path_provider] Migrate examples to null-safety (flutter/plugins#3559)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-plugins-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Please, auto-roller, pick the latest changes :)

Commit queue failed; closing this roll.


write tests for console / debugging / inspection

urgently!

🚀

We should codify what "soon", "urgently", and so on mean 😆

Closing for now, since this has lost it's context with the passage of time (feel free to open a new issue for specific test coverage issues that are still present)


General - Cannot Export Model from Profile line

Cannot Import or Export Model in Profile line (No data exported and also cannot import)
After Mark a model like this. After export there is no data coming out.

can we have script to generate module/field into database


Support MSC3916 (without MSC3911)

MSC3911 adds complexity that shouldn't block this feature.
See https://github.com/matrix-org/matrix-spec-proposals/pull/3916
See https://github.com/turt2live/matrix-media-repo/pull/465
Closes https://github.com/turt2live/matrix-media-repo/issues/103
Closes https://github.com/turt2live/matrix-media-repo/issues/266
Closes https://github.com/turt2live/matrix-media-repo/issues/118
TODO:

[x] MSC3916 - Split endpoints into Client-Server and Federation APIs
[x] MSC3916 - X-Matrix authentication on Federation APIs
[x] MSC3916 - Access token authentication on Client-Server APIs
[x] MSC3916 - multipart/mixed Content-Type on new /download and /thumbnail endpoints
[x] MSC3916 - Use new endpoints to download media
[x] MSC3916 - Tests

I'm giving up trying to fix the tests here: https://github.com/t2bot/matrix-media-repo/issues/589


ConstantTimeEq proc macro derive

Motivation
Fixes #280
Using Subtle crate
Implemented ConstantTimeEq using proc macro derive
Implemented ConstantTimeGreater and ConstantTimeLesser
Future Work
Move proc macro into subtle crate

closing due to shifting focus


--[post|storyitem]-metadata-txt Output split into multiple lines

Hi!
When creating metadata txt files I want to have the output splitted in multiple lines. So logically speaking I'd have to use a linebreak to achieve this. Using \n either in parentheses or without does not lead to the desired result but rather gets interpreted as text.
Ex.:
--post-metadata-txt={caption} \n {likes}
--post-metadata-txt="{caption}" \n "{likes}"
--post-metadata-txt="{caption} \n {likes}"
How could I achieve this?
Thank you already. :)

If you're using bash (not Windows, not sh), try --post-metadata-txt=$'{caption} \n {likes}'.
(I didn't test it.)


Problems installing filebeat on Windows

Hey,
I'm trying to install the module on Windows, we use foreman for all the classes on the puppet. I've downloaded the github code to our system. But when I try to run puppet agent -t this error appears: Error: Failed to apply catalog: Parameter provider failed on Exec [unzip filebeat-6.2.4-windows-x86_64]: Invalid exec provider 'powershell' (file: /modules/filebeat/manifest/install/windows. pp, line: 40)
I've  also installed the module powershell https://forge.puppet.com/puppetlabs/powershell.
I don't know what I should do next, can you help me?
Thanks,
Berta

Everything should work once you have the powershell module installed, so I'm not really sure what might be happening.
Can you confirm that the provider is sync-ing to the client as expected?

When I run the puppet agent -t this shows:

Also if I try to install the powershell module again it displays that is already installed.

Do you need more information?
The OS is Windows Server 2016 64-bits
The puppet agent is version 5.x
Thank you!
Berta

It looks like you're installing the powershell module in yourproduction environment but running the agent in your devbertafacter environment.

Thanks!! It was for environment.
I will close the issue then!


Keyboard buttons not working on HTML forms

I noticed that the -, =, and 0 keys will not work in forms on my device. They work in the address bar, but never in a form.

Thanks Nick for reporting, that seems to be broken indeed. Odd that it works on the address bar but not in forms.
Unfortunately, I don't have any time at the moment to dedicate to this project, but I am hoping to come back to it eventually. Always happy to look at pull requests though, so if anyone else wants to look into it, https://github.com/alex0809/netsurf-base-reMarkable/blob/master/frontends/framebuffer/fbtk/osk.c is probably a good starting point.


resetValue does not reset validation

Currently resetValue does not reset the validation.
It is expected that resetting will put the UI back in the state before any modification and validation failure reporting happened.

Done.


PR: Add ciocheck and circle ci linux integration

Fixes #53

Description
This add ciocheck as a tool for checking format/autoformating and running tests
More info at ciocheck
Also add circle ci integration for running linux tests, will then change travis to make mac tests.
@SylvainCorlay any comments?

Is circle ci faster than travis for linux?

circle ci faster

Yes, definitely, its the fastest ci

why not doing osx two on circle ci? To parallelize?

Cause its better to distribute the load, as conda-forge does... Mac costs on circleci


SystemCtl-Win: Remove non-existent file from project

Signed-off-by: Alin Gabriel Serdean<EMAIL_ADDRESS>

why are you removing a header file from the project?

@yakman2020, as the name of the PR probably says, this file is non-existent in any of the source code. :)

merged


[eslint-plugin-azure-sdk] Replaced redundant custom rule ts-no-namespaces with typescript-eslint/no-namespace

This fixes #8717 I deleted the files implementing the ts-no-namespaces rule and enabled the typescript-eslint/no-namespace rule in the base config file. Also, updated files which reference ts-no-namespaces. Here is specifically what I did:

Removed the source file, test file, and documentation file for the ts-no-namespaces rule:

common/tools/eslint-plugin-azure-sdk/src/rules/ts-no-namespaces.ts
common/tools/eslint-plugin-azure-sdk/tests/rules/ts-no-namespaces.ts
common/tools/eslint-plugin-azure-sdk/docs/rules/ts-no-namespaces.md

Removed the reference to the rule in common/tools/eslint-plugin-azure-sdk/README.md
Removed references to the rule in index.ts files

common/tools/eslint-plugin-azure-sdk/src/configs/index.ts
common/tools/eslint-plugin-azure-sdk/src/rules/index.ts

Enabled the typescript-eslint/no-namespace rule in the base config file: common/tools/eslint-plugin-azure-sdk/src/configs/azure-sdk-base.ts
Updated various files that were disabling the previous ts-no-namespaces rule to instead disable the typescript-eslint/no-namespace rule.

Let me know if I've missed anything in the removal of this rule as I am new to this code base!

/azp run js - identity - ci

Nice. Can we turn on allowDeclarations in the rule's options? A lot of the places in the code where we disable this rule are not places where we're creating namespaces, but places where we're declaring types for modules or declaring global type definitions.

I will log an issue for this

#18774


[batching] pixel_{un}shuffle

Reference: https://github.com/pytorch/functorch/issues/240

Failure looks unrelated
Traceback (most recent call last):
  File "/home/circleci/project/env/lib/python3.8/site-packages/torch/testing/_internal/common_device_type.py", line 376, in instantiated_test
    result = test(self, **param_kwargs)
  File "/home/circleci/project/env/lib/python3.8/site-packages/torch/testing/_internal/common_device_type.py", line 777, in dep_fn
    return fn(slf, *args, **kwargs)
  File "/home/circleci/project/env/lib/python3.8/site-packages/torch/testing/_internal/common_device_type.py", line 777, in dep_fn
    return fn(slf, *args, **kwargs)
  File "/home/circleci/project/env/lib/python3.8/site-packages/torch/testing/_internal/common_device_type.py", line 742, in test_wrapper
    return test(*args, **kwargs)
  File "test/test_pythonkey.py", line 249, in test_make_fx_exhaustive
    self.assertEqual(new_out, old_out)
  File "/home/circleci/project/env/lib/python3.8/site-packages/torch/testing/_internal/common_utils.py", line 1985, in assertEqual
    super().assertTrue(result, msg=self._get_assert_msg(msg, debug_msg=debug_msg))
AssertionError: False is not true : Tensors failed to compare as equal!With rtol=1.3e-06 and atol=1e-05, found 3 element(s) (out of 81) whose difference(s) exceeded the margin of error (including 0 nan comparisons). The greatest difference was 2.5272369384765625e-05 (5.405212879180908 vs. 5.405187606811523), which occurred at index (0, 0, 0, 1).

LGTM!


Fixed filtering by the exact value type

#694

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

-1 of 11 (90.91%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.2%) to 92.883%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/filter.ts
4
5
80.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
416

Relevant Lines:
437

💛  - Coveralls