autoimport stopped working when using workspaces

Environment data

Language Server version: 2023.3.30
OS and version: MacOS 13.2.1
Python version (& distribution if applicable, e.g. Anaconda): 3.11

I tried with different pythons, and 3.9 has the same issue.
I've identified the auto-import stopped working in the 2023.3.24 release but worked in the 2023.3.23.
I experienced the same behaviour with the v2023.3.31 pre-release as well.
Code Snippet

Repro Steps

Start in an empty folder
Make two folders, client/ and server/ (the name doesn't seem to be relevant)
Add a sever.py to the server/ folder to the
Auto-import should work as expected when pressing Ctrl+Space
Add the server/ folder to the workspace
Auto-import offers import but doesn't import anything (via Ctrl+Space)
Removing server/ from the workspace makes it work again (in a single root workspace)

Expected behavior

Regardless of the workspaces, Auto-import should add the import to the file.

Actual behavior

The Auto-import doesn't add import the file if the workspace has multiple root folders.

Logs
pylance-autoimport-bug.log

@rchiodo, this behavior changed after https://github.com/microsoft/pyrx/pull/3276.

I repro this in the older version too. At least 2023.3.23. It's worse though.

Yeah repros for me in 2023.3.20 as well.
I don't know that this was ever working?

There's some weird behavior around if we reindex everything or not.

This looks to be potentially caused by changes in how VS code behaves (or maybe because of our dynamic vs static workspace folder configuration).
The root cause of the problem is that the subfolder workspace we generate doesn't have the server.py file marked as open.

I can also confirm this behavior. This slows me down a lot as I have to manually go through all unimported symbols again and import them via Quick Fix.

This issue has been fixed in prerelease version 2023.3.41, which we've just released. You can find the changelog here: CHANGELOG.md

Thank you for the quick resolution!


Measurement Tools prints NaN

For certain images, the Length gets displayed as pixels instead of mm and Angles gets displayed as NaN.
I could see the difference in files that
Length properly measured image has the dicom tag - PixelSpacing(0028,0030)
NaN cases has dicom tag - ImagerPixelSpacing(0018,1164)
How can this be handled in cornerstone ? Do we already have a solution ?

My approach is registering a metadata provider  and setting  rowPixelSpacing and columnPixelSpacing from ImagerPixelSpacing if it is present.

@algates90 projection radiographs require manual calibration to correctly do length measurements.  You can force cornerstone to incorrectly use ImagerPixelSpacing as @diego0020 suggests, but your measurements will be wrong.

Just curious, would creating a "calibration tool" that sets these values
based on a known length in the image suffice? Or is it more complicated
than that?
Ie. What values need to be known/calibrated to create accurate measurements?
On Oct 15, 2017 8:32 AM, "Chris Hafey"<EMAIL_ADDRESS>wrote:

@algates90 https://github.com/algates90 projection radiographs require
manual calibration to correctly do length measurements. You can force
cornerstone to incorrectly use ImagerPixelSpacing as @diego0020
https://github.com/diego0020 suggests, but your measurements will be
wrong.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/chafey/cornerstoneWADOImageLoader/issues/131#issuecomment-336708564,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFh21DDAj9UE-0ucLdk6CRWxnoRwOeJXks5ssftSgaJpZM4PSyi5
.

@dannyrb the correct way to solve this is for the xray tech to place a physical object of a known size (e.g. 10mm diameter circle)  at the correct depth during the xray and then provide a tool to calculate the row/column pixel spacing for the image by measuring that object.  This should be done in cornerstoneTools, not here in the loader.  Manual calibrations should be handled separately from the metadata provider, appropriate infrastructure put in place to manage them in cornerstoneTools and updates to the tools themselves.  Not a huge task, but not trivial

Thanks for the response @chafey! I've created a related issue in chafey/cornerstoneTools @algates90. Feel free to carry on the conversation there. I'm marking this issue as closed in this repository.


Weird behavior

{
"text": "cost of",
"normal": "cost of",
"implicit": "",
"reason": "phrasal(lexicon_pass)",
"pos": {
"Verb": true,
"Infinitive": true
},
"tag": "Infinitive",
"conjugations": {
"past": "cost of of of of",
"infinitive": "cost of of of of",
"gerund": "costing of of of of",
"actor": "coster of of of of",
"present": "costs of of of of",
"future": "will cost of of of of",
"perfect": "have cost of of of of",
"pluperfect": "had cost of of of of",
"future_perfect": "will have cost of of of of"
}
}

ahh! will take a look.
thanks paul.

Seems to be doing it here as well:
{
"text": "wrote about",
"normal": "wrote about",
"implicit": "",
"reason": "phrasal(lexicon_pass)",
"pos": {
"Verb": true,
"PastTense": true
},
"tag": "PastTense",
"conjugations": {
"gerund": "writing about about about about about about",
"past": "wrote about about about about about about",
"infinitive": "write about about about about about about",
"actor": "writer about about about about about about",
"present": "writes about about about about about about",
"future": "will write about about about about about about",
"perfect": "have wrote about about about about about about",
"pluperfect": "had wrote about about about about about about",
"future_perfect": "will have wrote about about about about about about"
}
},

ah, got it.
will update in 3.0.3
thanks man.


[Input Password]: eye icon doesn't show

When you load first time a value of a input type password, the eye icon doesn't show. Following below its a selected input:

The "eye icon" is not included in the default HTML input tag, and it has not been implemented in this library either. You can submit a feature request if you would like this to be implemented.

+1 to This. Maybe as a variant, instead of default

I tried playing around it, I need some feedback and guidance on what should be next step @shadcn
https://github.com/shadcn/ui/assets/58180803/47aafe8c-092f-4d17-9230-abc2efff2a08

@multiwebinc have a look at this, what should be the next step here
Should I implement in all the components?
https://github.com/shadcn/ui/assets/58180803/2274665e-9a29-489e-be13-a5f4b5d62716

@tuminzee I would try to integrate that into https://github.com/shadcn/ui/blob/main/apps/www/components/ui/input.tsx and submit a PR. You could add the optional parameter showPasswordToggle and if the type is text, the password would be revealed by default, and if it's password, it would be hidden by default. Clicking on the icon would toggle the type between text and password.

@multiwebinc I have the code ready let me know how I can contribute

@tuminzee If it's not too much code, I would try to integrate that into https://github.com/shadcn/ui/blob/main/apps/www/components/ui/input.tsx and submit a PR. You could add the optional parameter showPasswordToggle and if the type is text, the password would be revealed by default, and if it's password, it would be hidden by default. Clicking on the icon would toggle the type between text and password.

I have done exactly that
but I am tacking it down using
passing the type=password

@multiwebinc I have the code ready let me know how I can contribute

Just edit the file and submit a pull request.

perfect @multiwebinc I will create a pr by tonight
thanks for the support, have a good day 🕺🏼

sorry for the delay @multiwebinc I made this PR which only add the feature in the example pages, let me know where else should I add this.
it should also be added to the main components ui, but I will wait for the feedback for this one
thank you for being patience

https://github.com/shadcn-ui/ui/pull/504#issuecomment-1883379209

This issue has been automatically closed because it received no activity for a while. If you think it was closed by accident, please leave a comment. Thank you.

I also have this requirement, I use useState and Button in the development process to successfully realize the password eye icon but I put Input, Form, Sonner generate form after sending a request failure or validation failure after the eye icon can not be used, every time you click the eye icon will trigger the Form validation please ask how to solve it?

I also have this requirement, I use useState and Button in the development process to successfully realize the password eye icon but I put Input, Form, Sonner generate form after sending a request failure or validation failure after the eye icon can not be used, every time you click the eye icon will trigger the Form validation please ask how to solve it?


Issue: UUID dict key breaks tracing

Issue you'd like to raise.
I'm trying to use the traceable decorator on a method that returns a dict with UUID-valued keys. This seems to break tracing (sometimes the output for this step is just never logged to LangSmith and sometimes nothing that comes after it is logged either). No exception is raised. When I replace the UUID with a string, the same call works without any issues.
# works
@traceable(name="name")
def func(self, input: list[UUID]) -> dict[str, str]:

# does not work
@traceable(name="name")
def func(self, input: list[UUID]) -> dict[UUID, str]:

Suggestion:
Support arbitrary serializable keys

@fekstr what version are you on?
This works for me with no problem...
https://smith.langchain.com/public/20b3d9f7-492a-47d7-87f8-b5e3b2409eea/r
import uuid
from langsmith import traceable

@traceable
def foo(inputs: list[uuid.UUID]) -> dict[uuid.UUID, str]:
    return {uuid.uuid4() : inputs}

foo([uuid.uuid4() for _ in range(5)])

@hinthornw you're right, it indeed works on the latest version. Was on an earlier version. Thanks!


Add missing Polish translations

Details of Changes
Add details of changes here.

Added missing translations

Thank you!


Documentation site

We should create a docs/ folder that has documentation pages written in markdown. We could then use something like https://www.mkdocs.org/ to publish the site via GH Pages (via separate repo where generated files are pushed).

Fixed in #1230


Implement Accordion Block Plugin

What
This PR implements an Accordion block. It's an alternative to #6.

This approach actually is composed using four blocks:

Accordion

Accordion Item

Accordion Trigger
Accordion Content

Without getting too much into the weeds, this was done because it was the simplest way I could figure out how to allow user styling of the trigger and content separately, while maintaining the accessibility and semantic needs of an accordion pattern.
Highlights

Allows you to configure which items are open by default, and the expand / collapse behavior
Comes with a few block styles for the icons
Informed by design mockups by @jarekmorawski
Uses the Interactivity API
Meets WC3 accessibility guidelines

Demo & Download
https://cool-tools.mystagingwebsite.com/2024/07/12/accordion/
Video Walkthrough
https://video.wordpress.com/embed/AfzRE5Om

@jarekmorawski @Nyiriland would you be able to give this a review when you have a chance? 🙏

Instead of introducing style options, what if we add a "None" option for the icon?

Yeah, that's another possibility. There's no consensus on how such binary styles (icon vs. no icon) should be handled on the block side so we have some freedom.

Should the accordion be closed, unless you select the block, or have "open by default" checked?

Agreed!

My concern is that it might feel over-engineered for amateur users compared to the details block, but maybe that's needed for a more comprehensive block system:

That's my concern too but I had a chat with Jeff and it seems there's no other solution that wouldn't break a11y and diverge from HTML semantics. In the original design, the structure was much simpler.

Perhaps it's worth a second look? I can ask Woo block engineers to share their thoughts.

From testing, you can add the border to Accordion Item, but not padding. If you add padding to the bottom of the Accordion Content, it does this:

It could be a bug. I don't think we should reveal the content when the accordion is not open.
@Nyiriland, I was able to recreate that layout using a combination of Accordion Trigger padding and block spacing added to both Accordion Item and Accordion (the parent block). It's a bit convoluted, but well, designing complex nested layouts in Figma isn't a walk in the park either. 😉

Icons: are there default icons in the WordPress UI library that we can utilize instead of adding new ones?

We can, but they may confuse users who may be familiar with blocks that already use those icons. We use custom icons all the time at Woo and it doesn't seem to be an issue. If we were to go with the default icons, I'd suggest:

Accordions: list
Accordion: details
Trigger: queryPaginationNext
Content: termDescription

Thank you @jarekmorawski @Nyiriland, great feedback!

I wonder if we should call the block Accordion Group or Accordions, then? And Accordion Item to just Accordion?

The way I understand the UX pattern and its naming, is that a single Accordion contains several sections of content that can be expanded and collapsed. The visual metaphor is of an instrument that expands in one place and contracts in another. So technically, there should be multiple sections (or "items") to make it an accordion, otherwise there the distinction between an Accordion and Details would be even more blurry. Does that make sense? Sorry if it's a bit esoteric.

As for the inner blocks, I'd rename Accordion Trigger to Trigger and Accordion Container to just Content and change the icons to some that are visually related and share a common metaphor (the arrow).

👍 I agree, sounds good.

Do the "accordion trigger" and "accordion content" need to be separate item in the block list view?

Perhaps it's worth a second look? I can ask Woo block engineers to share their thoughts.

I'm open to ideas. I hit a wall in this PR https://github.com/a8cteam51/special-projects-blocks-monorepo/pull/6 which tries to do that but fell short of the requirements, particularly the ability to easily style the trigger, separately from the content, using the existing block supports and maintaining semantics.
Another thing to keep in mind with the design of the block's editing experience — there needs to be a way to associate a trigger with its corresponding content. This is what the Item does — it just associates a trigger with content and disallows either from being moved or removed, and any other block types from being inserted, since doing so would break the functionality and UX pattern.
This approach also allows the user to insert as many Items into the Accordion as needed. I couldn't think of another way to keep the trigger and content in the right order. (AFAIK there is not a simple way in the block editor API to say, "only allow inserting a content block after a trigger"

From testing, you can add the border to Accordion Item, but not padding. If you add padding to the bottom of the Accordion Content, it does this:

It could be a bug. I don't think we should reveal the content when the accordion is not open.

Yeah, that's a bug. It's related to using a CSS-only approach to animating the show / hide behavior. With this approach, no hacky JS height calculations are needed, and it's responsive, which is great. But the result is that bug happens when padding is added to the Content container block. To get around it, I would need to disallow setting top and bottom padding on the Content block. This way, to add vertical padding to the Content, the user would have to wrap the blocks inside Content in a group block.  It's convoluted, but I think a worthwhile tradeoff. What do you think?

Icons: are there default icons in the WordPress UI library that we can utilize instead of adding new ones?

I think we should supply custom icons, the core ones should be left specific to their respective blocks and settings.
I'll get started on the rest of the feedback and let you know when it's ready for another test.

We can, but they may confuse users who may be familiar with blocks that already use those icons.

Sorry, I was referring to the icons for the trigger, not the block itself. The Twentig plugin extends the Details block to create accordion options, and I was noticing that the trigger icons look a lot like the WP icon set. If they're using the same ones, we probably can, too. (We chose not to extend the Details block because the markup was not built in an accessible way.)

But if not, the icons @jarekmorawski used in his mockups suffice.

@jarekmorawski for some reason when I try to export the Content block icon from Figma and load it into the block, I'm getting this:

The other block icons look alright, do you know of a way that might export the icon correctly?

Yeah, that's a bug. It's related to using a CSS-only approach to animating the show / hide behavior. With this approach, no hacky JS height calculations are needed, and it's responsive, which is great. But the result is that bug happens when padding is added to the Content container block.

I wouldn't even call it a bug, it's how padding works. 😆 I'm more concerned this is how people might expect to apply padding/spacing to block content, so we should account for that.

To get around it, I would need to disallow setting top and bottom padding on the Content block. This way, to add vertical padding to the Content, the user would have to wrap the blocks inside Content in a group block. It's convoluted, but I think a worthwhile tradeoff. What do you think?

I agree that a CSS-only solution is cool, but I don't love having to wrap content in a group block just to be able to add spacing around it; I don't think it's an intuitive solution for beginner users that just want to be able to throw in content and expect it to look "ok". In my opinion, that includes having enough spacing between the accordion content and the block below it.
Idea: is it possible to add a simple div around the Content that shows/hides it? That way, we can apply padding/spacing to the Content, but it wouldn't be visible in the closed state.

Oh one more thing: for this option I'd default the block to allowing multiple items open. It's better for UX in my opinion, and Nielson Norman agrees:

This problem can further escalate when an accordion automatically closes when another is opened, restricting users’ ability to combine information from multiple accordions at the same time. If you expect users to need information from several accordions at once, it is better to display all the content at once (even if it results in a longer page).

Here's the SVG file! Let me know if it works.

Hmm that link is not allowing me to download it.

Hmm that link is not allowing me to download it.

@jarekmorawski Can you "copy as svg" from Figma and paste in a code block (or point me to the icon in Figma)? There might be some issues with masking, I can help sort it out if needed.

Sure thing. FWIW, you can right-click on that SVG and download it like any other image. Here's the code:
<svg width="24" height="24" viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg"> <path fill-rule="evenodd" clip-rule="evenodd" d="M8.10417 6.00024H6.5C5.39543 6.00024 4.5 6.89567 4.5 8.00024V10.3336H6V8.00024C6 7.7241 6.22386 7.50024 6.5 7.50024H8.10417V6.00024ZM4.5 13.6669V16.0002C4.5 17.1048 5.39543 18.0002 6.5 18.0002H8.10417V16.5002H6.5C6.22386 16.5002 6 16.2764 6 16.0002V13.6669H4.5ZM10.3958 6.00024V7.50024H13.6042V6.00024H10.3958ZM15.8958 6.00024V7.50024H17.5C17.7761 7.50024 18 7.7241 18 8.00024V10.3336H19.5V8.00024C19.5 6.89567 18.6046 6.00024 17.5 6.00024H15.8958ZM19.5 13.6669H18V16.0002C18 16.2764 17.7761 16.5002 17.5 16.5002H15.8958V18.0002H17.5C18.6046 18.0002 19.5 17.1048 19.5 16.0002V13.6669ZM13.6042 18.0002V16.5002H10.3958V18.0002H13.6042Z" fill="#1E1E1E"/> </svg>

Assuming the block had to stay with this structure structure, what do you think about this naming?

Wow, looking awesome!!! Love all the options for the trigger 🤡

Changing styles: difficult to change on multiple accordions; you either have to copy styles, or duplicate one you've already styled
Let's look into if it's possible to register blocks in "global styles" to make this ^ easier
Can we add ability a border to the accordion group? Specifically, if you have a bottom border on all your accordions, you should be able to add a border to the top of the group: this will allow you to re-order the child elements, while still ensuring there's always a top border.
I know this may be a theme-level style change, but changing the focus style on the trigger to focus-visible would make that irritating blue border disappear when you click it.
Could we have an option to turn off the open/close animation transition on the group? (But keep it on by default)
I think the "Autoclose" label needs some rewording so it's more clear what it does (or at least change to "Auto-close"... I'll think on this)

I'm thinking about any "default styles" we might want to include (@jarekmorawski may have input here). To me, this is pretty much the default I'd want to go for:

To achieve this:

Zero block spacing on accordion group
1px border-top on accordion group
1px border-bottom on accordions
spacing 2 on top & bottom of accordion trigger
spacing 2 on bottom of content

Changing styles: difficult to change on multiple accordions; you either have to copy styles, or duplicate one you've already styled

Global Styles is one option, multi-select is another. In the editor, you can select a few blocks of the same type to see and modify their settings. I'm not sure if that requires an extra API or something, but it's worth looking into.

To me, this is pretty much the default I'd want to go for:

100% agree. It'd be great to have a default style like this. In the future, we can add a few more as block styles.
On top of that, I have a few extra comments:
I don't think the empty option is working in the icon picker. It took me a second to understand what it was. We can either replace it with None (text button) or add a toggle Display icon that will display the picker when enabled.

It'd be nice if the newly added accordion block would replicate the recently used styles. Otherwise, we force the user to style it from scratch or resort to duplicating existing accordions.

I think the "Autoclose" label needs some rewording so it's more clear what it does (or at least change to "Auto-close"... I'll think on this)

I'd rename it to Close automatically and add a help text: Automatically close this accordion when visitors open another one.
H3 feels too big for a default style. Can we try H5?

If we are to add a toggle to disable animations, I'd put it Advanced so it doesn't get in most people's way.

Good points on everything, @jarekmorawski.

We can either replace it with None (text button) or add a toggle Display icon that will display the picker when enabled.

I also didn't notice that there was a "none" option for the icon, hah. I'd vote for None as text, or remove the option altogether. (For a11y, there should be an indicator to imply additional functionality somewhere.)

H3 feels too big for a default style. Can we try H5?

I tested this out with 2024, and h5 feels too small (I'm stress testing over on this page, btw). h4 works better (although I am also still a fan of h3, too). @jeff is there any guidance around semantic hierarchy of DOM elements for block defaults? Like, I'd almost want to make it an h2, then size the text smaller, but that's probably a bad idea, haha. h4 probably is the way to go.
Another note...

Gap on trigger: I previously hadn't tested with long text in the trigger, but we should add a gap (like .75em) between the icon and tigger text:

Another Q for @jffng... following up on the chat we had yesterday, I see there are focus styles applied at the block level, specifically to this class:

I previously thought these were inherited, but if they're not, can we remove it from the :focus and just keep on focus:visible, or does that need to stay to match button focus states? (I threw in a button on that test page and it actually doesn't match those, either.)

Can we add ability a border to the accordion group?

👍

I'd vote for None as text

👍

Automatically close this accordion when visitors open another one.

I find it a little confusing what accordion is being referred to by "this" and "another one" — is it the accordion group or accordion item? Technically this is a setting of the group, but it affects the behavior of accordions inside the group. Also something to consider is when this setting is enabled and multiple accordion items are open by default, clicking any open section actually closes all of them.
What do you think about Clicking one accordion section automatically closes all other open sections.?

is there any guidance around semantic hierarchy of DOM elements for block defaults?

I think it depends what's on the page already and where the accordion appears (i.e. is there a h2 placed right before it that acts to describe / label the accordion?). Then h3 would be the correct level.
Also different themes and style variations are going to change the size of an h3/4/5. With that in mind, do you still think h4 or h5 is best for the default, or can we keep it h3?

can we remove it from the :focus and just keep on focus:visible

👍
FYI I'm going to continue working on this over here, can we pick up the discussion / feedback there? 🙏
https://github.com/WordPress/gutenberg/pull/64119/


Why do you send the profile inside the token?

Hello,
In the file, socketio-jwt/example/server.js:25 you have the following two lines:
 // We are sending the profile inside the token
  var token = jwt.sign(profile, jwt_secret, { expiresInMinutes: 60*5 });

What is the purpose of sending the entire profile if it can't be decoded on the client?
Thanks!

it can be decoded on the client, check jwt-decode:
https://github.com/auth0/jwt-decode
JWTs are base64 encodded, and digital signed.
The reason I might want to send the profile some times inside the token, is because I need the profile on every request to set permissions and stuff., and I don't want to go to fetch it from the db.

Awesome, thank you so much!


[Dependency Scanner] Prefix Clang dependency scanner search path arguments with -Xcc

And remove whitespace between the -I or -F and the actual filesystem path string.
Experimentally, this seems to be required for these paths to actually be picked up by the underlying scanner.

@nkcsgexi, it seems that ClangImporter::addSearchPath does not get called on this path?

@swift-ci please smoke test

hmm, interesting, Thank you for catching this!

@swift-ci please smoke test

@swift-ci please smoke test OS X platform

@swift-ci please smoke test


Deploy to TestPyPi on merges to main

See:
https://github.com/tpvasconcelos/ridgeplot/blob/bf50ed4505dbd81784174412b57554ef1e159dd5/.github/workflows/release.yaml#L35-L40

Solved in #200
See: https://test.pypi.org/project/ridgeplot/#history


Add a simple even for tracking navigation from the menu

This allows us to track which of the buttons from the top menu were clicked. It will need updating / careful merging with #1382 to ensure neither change is lost

and so it begins: the tracking of absolutely useless information

Conversions vs page views is pretty important.


`GLIBC_2.18' not found error (Centos7 with GLIBC 2.17)

Web Browser:
Local OS:
Remote OS:
Remote Architecture:
code-server --version: 3.4.0

Hi although on the release it says that this bug was fixed, that's not the case. On standard and updated Centos7 (coming with glibc 2.17 only), code-server 3.4.0 wrongly says it needs 2.18.
/home/usercode-server/code-server/bin/../lib/node: /lib64/libc.so.6: version `GLIBC_2.18' not found (required by /home/user/code-server/code-server/bin/../lib/libstdc++.so.6)
Perfectly working version 3.3.0 (that sadly cannot be updated automatically as it's broken so I'm performing a new installation).
How to solve it?

Ah my bad.
You can just delete the dynamic libraries in lib/*.so* and then it should work for now.
Will fix in 3.4.1.

Ah my bad.
You can just delete the dynamic libraries in lib/*.so* and then it should work for now.
Will fix in 3.4.1.

Hi thanks for the hint, that worked and code-server started.
Not sure if it depends on that or something else, but Terminal sadly doesn't work anymore...it's stuck on starting/launching and it remains so forever. Did something change in terms of terminal settings from 3.3.0? I have some personal settings when launching bash for my environment, and I see that when 3.4.0 starts it mentions a default configuration file created in a hidden folder, but this is not mentioned in 3.3.0.
Any suggestion how to fix it? It works perfectly when I launch code-server 3.3.0

Hmm. And there are no logs on why the Terminal won't start?
You're using the bundled version of node to start it right?
Also, you might find the npm package a more stable installation method as it rebuilds all native components against your system to avoid these sorts of issues.

When it starts it says again there are problems with glibc
Error: /lib64/libstdc++.so.6: version `GLIBCXX_3.4.20' not found (required by /root/code-server/code-server/lib/vscode/node_modules/spdlog/build/Release/spdlog.node)
IPC Library: File Watcher (nsfw)] Error: /lib64/libstdc++.so.6: version `GLIBCXX_3.4.20' not found (required by /root/code-server/code-server/lib/vscode/node_modules/vscode-nsfw/build/Release/nsfw.node)
Will look into npm...I was using the standalone installation.

Hmm. And there are no logs on why the Terminal won't start?
You're using the bundled version of node to start it right?
Also, you might find the npm package a more stable installation method as it rebuilds all native components against your system to avoid these sorts of issues.

Hi I actually tried the NPM but is very messy business on a production server with loads of packages installed already and other systems working.
Just trying to install the needed dependencies with yum creates all sort of conflicts, so it's not a viable solution.
Not sure why all was working well in 3.3.0 and now on the same server I had these problems (it seems there's something related to glibc for sure).

I'm having the same problem in Cloud9. Though I'm a lama and hardly know what I'm doing.
/home/ec2-user/.local/lib/code-server-3.4.0/bin/../lib/node: /lib64/libc.so.6: version GLIBC_2.18' not found (required by /home/ec2-user/.local/lib/code-server-3.4.0/bin/../lib/libstdc++.so.6)`

I had a similar problem upgrading to 3.4.0 on Ubuntu. But following the advice said above fixed it for me:
You can just delete the dynamic libraries in lib/.so and then it should work for now.

The problem is that, like others reported, even deleting those libraries the release at least on some systems is faulted. There other errors elsewhere related to glibc as I reported before, even if code-server seems to work normally.
@nhooyr I did some more tests, is not only terminal not working (like others noted), also extensions are installed but cannot be activated (no error message, they simply fail...it goes into 'Activating extensions' and then fails). They are all installed.
I wonder what happened with a perfectly working release 3.3.0 just a few weeks ago, and then all together broken updater, new install system, problems with glibc, terminal and extensions not working. Ah and also a change in the configuration file that is read, so my configuration in 3.3.0 was not working in 3.4.0 as password was moved in a new configuration file.
It feels like there was a substantial base change that broke what was working? Is it worth maybe a new update but starting from the better working base (it seems to me) of the 3.3.0?

On my side, I can open terminal. But many commands run in it are broken, with for instance:
root@greenou  ~/rankup  apt apt: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version GLIBCXX_3.4.21' not found (required by /usr/lib/x86_64-linux-gnu/libapt-private.so.0.0)
apt: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version GLIBCXX_3.4.21' not found (required by /usr/lib/x86_64-linux-gnu/libapt-pkg.so.5.0)
(and I deleted the content of ./lib/.so but doesn't change anything).

On my side, I can open terminal. But many commands run in it are broken, with for instance:
root@greenou  ~/rankup  apt apt: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version GLIBCXX_3.4.21' not found (required by /usr/lib/x86_64-linux-gnu/libapt-private.so.0.0)
apt: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version GLIBCXX_3.4.21' not found (required by /usr/lib/x86_64-linux-gnu/libapt-pkg.so.5.0)
(and I deleted the content of ./lib/.so but doesn't change anything).

Same experience here, I was looking back at the changelog for the new releases and it seems @nhooyr went back to an older version of VSC for the new releases after 3.3.0...my feeling is that maybe that plus those changes with install script and other structural things broke something?
I'm also happily back to 3.3.0 as it works perfectly, hopefully we can get soon a more sorted update that continues where 3.3.0 finished not breaking what was working with that one as I see many had problems with the updates since then.
@nhooyr I noticed another bug: using the script, on a genuine Intel server it wants to install the AMD version somehow. I didn't let it unstall the rpm as I prefer to install it manually myself.
Honestly I think an install script for this product is possibly not needed: all the needed steps to configure nginx and all the rest means that to configure the whole thing requires anyway equal if not better skills than just installing it.

Once again≤ so sorry about this!

Same experience here, I was looking back at the changelog for the new releases and it seems @nhooyr went back to an older version of VSC for the new releases after 3.3.0...my feeling is that maybe that plus those changes with install script and other structural things broke something?

 See #1761
They were also bundled from Debian 8 which requires a more recent glibc than CentOS 7.
This is going to be fixed today with 3.4.1 which goes back to compiling everything on CentOS 7. See #1766

@nhooyr I noticed another bug: using the install script, on a genuine Intel server it wants to install the AMD version somehow. I didn't let it install the rpm as I prefer to install it manually myself.

There is no intel vs amd version. amd64 refers to the architecture which is shared by Intel and AMD.

Honestly I think an install script for this product is possibly not needed: all the needed steps to configure nginx and all the rest means that to configure the whole thing requires anyway equal if not better skills than just installing it.

It's less about skill and more about convenience, you can quickly setup any Unix machine with code-server without really thinking too much.

Thank you very much, it all makes perfect sense, no an easy task for sure to maintain this!
Will check when new version is out and hopefully will get it working and will report back :-)

New release is out!
https://github.com/cdr/code-server/releases/tag/v3.4.1

No worries, thanks for the fast fix!

Just installed, all went smooth and everything seems to work again, stellar work @nhooyr !


Arabic support  + scale/dpi  alongside with  JSpdf ?

I can't find any version that supports Arabic + scale/dpi alongside with JSpdf  , always getting right arabic text but scale is not working , or rubbish arabic text with scale working fine , can you help please ?

Hello, how did you solve this?


RateMyProfessors now seems to use a graphql API

Seems like the extension currently is trying to use an old, now-deprecated REST API
this seems to be a sample of a new endpoint that might be a replacement for the one currently in use:
curl 'https://www.ratemyprofessors.com/graphql' -X POST -H 'User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/114.0' -H 'Accept: */*' -H 'Accept-Language: en-US,en;q=0.5' -H 'Accept-Encoding: gzip, deflate, br' -H 'Referer: https://www.ratemyprofessors.com/professor/568275' -H 'Content-Type: application/json' -H 'Authorization: Basic dGVzdDp0ZXN0' -H 'Origin: https://www.ratemyprofessors.com' -H 'DNT: 1' -H 'Connection: keep-alive' -H 'Cookie: ccpa-notice-viewed-02=true; cid=-VEdhkoW5x-20230620; userSchoolId=U2Nob29sLTgwNw==; userSchoolLegacyId=807; userSchoolName=Rochester%20Institute%20of%20Technology' -H 'Sec-Fetch-Dest: empty' -H 'Sec-Fetch-Mode: cors' -H 'Sec-Fetch-Site: same-origin' -H 'Sec-GPC: 1' -H 'Pragma: no-cache' -H 'Cache-Control: no-cache' --data-raw '{"query":"query NewSearchTeachersQuery(\n  $query: TeacherSearchQuery!\n) {\n  newSearch {\n    teachers(query: $query) {\n      didFallback\n      edges {\n        cursor\n        node {\n          id\n          legacyId\n          firstName\n          lastName\n          school {\n            name\n            id\n          }\n          department\n        }\n      }\n    }\n  }\n}\n","variables":{"query":{"text":"aaron deever","schoolID":"U2Nob29sLTgwNw=="}}}'

their schema

as obtained by putting the results of this query https://stackoverflow.com/a/46543255 into here : http://nathanrandal.com/graphql-visualizer/

Currently working on this in my fork on the graphql branch
Seems like the generated html is pretty tightly integrated with the responses from the API so its gonna be tricky/time consuming to swap the API out without breaking a ton of things
Having some instructions for how this was built and run might also help, currently running into an issue where importScript is not found

Wow thanks so much!

Currently working on this in my fork on the graphql branch
Seems like the generated html is pretty tightly integrated with the responses from the API so its gonna be tricky/time consuming to swap the API out without breaking a ton of things
Having some instructions for how this was built and run might also help, currently running into an issue where importScript is not foundn

weather update: it now kind of works
i pretty much just started over and bypassed a lot of the recursive name-trying logic cuz it looked complicated - so maybe thats why some of the names arent showing up

hover tooltips are uuh a lil broken tho

I suspect something in the tooltip library got updated and broke things.
Might try either downgrading tippy, messing with it until it works, or moving all the dom manipulation code into a html template to better see what the structure of that tooltip looks like

just a small CSS import/linking issue - of course


How do you debug your JavaScript?

For me the Pre trigger is not working. But to widen up the question how does one debug this? can I do a console.log? Where can I view this? Some advise here would be very useful

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 14913a18-671a-c55f-d082-e750bec7baab
Version Independent ID: 9cc08ba2-a79f-3ee2-9beb-8919f77d10d3
Content: How to write stored procedures, triggers, and user-defined functions in Azure Cosmos DB
Content Source: articles/cosmos-db/how-to-write-stored-procedures-triggers-udfs.md
Service: cosmos-db
GitHub Login: @markjbrown
Microsoft Alias: mjbrown

@LanderVe We are checking this and will get back to you.

@NavtejSaini-MSFT can you assign to @aliuy ?
Thanks.

Thanks for the input @markjbrown. @LanderVe We are assigning this to @aliuy for more clarity on this.

@LanderVe Currently you can just use "console.log()". his command will concentrate a string for debugging when EnableScriptLogging is set to true as shown in the following example:
var response = await client.ExecuteStoredProcedureAsync(
document.SelfLink,
new RequestOptions { EnableScriptLogging = true } );
Console.WriteLine(response.ScriptLog);
I will add this info to the doc.

Updated the doc in the above PR. We will now close this issue if there aren't further questions.
#please-close


Problems scaffolding the movie model

When I try to scaffold the movie model I end up with the following error.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 6719f08e-3bd7-dc1a-71df-f2ef9fbca9d8
Version Independent ID: 7096fdb3-612e-9e00-bd0b-8ea4886a09ce
Content: Part 2, add a model
Content Source: aspnetcore/tutorials/razor-pages/model.md
Product: aspnet-core
Technology: aspnetcore-tutorials
GitHub Login: @wadepickett
Microsoft Alias: wpickett

@catfishsushi, thanks for the heads up.  Looking at the error I am guessing you may have an older global tools or bit of a version miss match with the packages.
You might try the following commands at the commandline:
dotnet list YourProjectNameHere.csproj package --verbosity d
Try uninstalling and install the global tools and get the latest:
dotnet tool uninstall dotnet-aspnet-codegenerator --global
dotnet tool install --global  dotnet-aspnet-codegenerator

I will close this issue for now, but if you decide it needs to be re-opened for a change in the topic,please feel free to do so.


Change ScanResult#isConnectable from nullable boolean to non-nullable enum

https://github.com/Polidea/FlutterBleLib/pull/586#discussion_r610065825
Connectivity with 3 states:
Connectivity.noInfo (or notAvailable?), Connectivity.notConnectable, Connectivity.Connectable

Right now it's Bool? isConnectable so ternarily [null, false, true]
it's nullable because it's only available on iOS host OS, on android it is still connectable so null very importantly does not mean false at all!
Therefore I'd also recommend using a less misleading representation being the
enum Connectivity [ .notAvailable| .unsupported, . notConnectable, .connectable]
correspondingly mapping to the Bool? values above.


Cannot remove Wiki Tab from Teams and some parts of Teams will be applied more than once (when applying twice).

Hi,
I have the following errors since about 15.10.2020, before that everything worked fine (no changes to PnPPowerShell version and PnPTenantTemplate Schema):

When I apply a PnPTenantTemplate and I want to remove a Wiki Tab in Teams, the provisioning do not remove the Wiki tab and stops at that point (additional steps to Teams, for example add channels/tabs won't be run). I get no error message, it just stops.

Applying a sample PnPTenantTemplate

Result:
Wiki won't be removed and additional tabs and Message won't be created/posted:

Result without removing Wiki Tab in PnPTenantTemplate Schema:

When I apply a PnPTenantTemplate more than once (two times), some parts of teams will be run twice. It doesn't just apply the Delta. Before just the Delta was applied. For example: If I add a tab to a channel, the tab will be added twice.

Applying a sample PnPTenantTemplate twice:

Result:

I tested the two above mentioned errors in different Tenants, same behaviour for all tenants.
SharePointPnPPowershellOnline Version: 3.25.2009.1
PnPTenantTemplate Schema (Teams):

Thank you

This issue should have been fixed. Please, upgrade to PnP Framework and PnP PowerShell for PowerShell Core and try again. In case of any further issue, please create issue items in the corresponding repositories and not in this one, which is about the provisioning schema. Thanks.


Support {:system, ENV_NAME, default} tuples

I think this will remove duplication in config.exs/prod.exs by letting set environment variables and safely fallback to defaults on development environment.

@AndrewDryga we have no plans in adding more features related to this part of the codebase. The tuple is already a hack related to releases and we plan to work towards removing it rather than adding more. :)

What is your current plans on fixing this? Maybe I would know about new best practice :)

No solid plans for now besides eventually including releases in Elixir. Maybe @bitwalker has something in mind in distillery right now.

Other than the {:system, "VAR"} tuple, you can use REPLACE_OS_VARS=true in conjunction with some_setting: "$VAR_NAME" in your prod.exs when running releases built with distillery, and $VAR_NAME will be replaced with the value of that variable in the environment.  The behaviour of REPLACE_OS_VARS=true could be automated when the presence of System.get_env/1 calls are found in config.exs as well, but that is currently not the case, and I don't think it solves the problem of runtime configuration well enough.
Configuration has some fairly strict rules when it comes to releases, and regardless to what degree releases are introduced into Elixir proper, there are some limits imposed by both the Erlang runtime and release handling in OTP itself. It's something I'm trying to solve, but I don't have any clear ideas on the best path yet.

Actually I already use REPLACE_OS_VARS. It's me, that guy that asks many questions about environment variables in distillery repo :).

I just think that it's ugly to mix different declarations in a single config file, we have {:system, ..} tuples and "${ENV_NAME}" strings that gets replaced only for ECTO.


No static analyzer support for clangd

For example add clang-analyzer-unix.MismatchedDeallocator check to Diagnostics ClangTidy section, no effects with clangd, but it works with clang-tidy checks.
Seems only -Wmismatched-new-delete diagnostics works.
Finally I found comment in source:
// Force the linker to link in Clang-tidy modules.
// clangd doesn't support the static analyzer.
#if CLANGD_TIDY_CHECKS
#define CLANG_TIDY_DISABLE_STATIC_ANALYZER_CHECKS
#include "../clang-tidy/ClangTidyForceLinker.h"
#endif

Why clangd doesn't support static analyzer?
System information
Output of clangd --version:
13.0.0/12.0.1
Editor/LSP plugin:
VS Code/clangd(v0.1.13)
Operating system:
Windows/ArchLinux

Guess you'll have to leave the static analyzer to the CI.

One could also consider writing a dedicated clang static analyzer plugin for vscode, which runs the static analysis on demand (not in a long-running process) and visualizes its diagnostics in the Problems view.

Addedum:
To my understanding, https://github.com/Ericsson/codechecker is a tool that will run scan-build automatically after the file has been saved. It also have a vscode extension.
Not sure about the limitations.

One could also consider writing a dedicated clang static analyzer plugin

I'd love to have some real UI Integration with visualized/navigable chains as shown in the screenshots: https://clang-analyzer.llvm.org/
I guess one could write an extension that reads the compile_commands.json and executes the commands with --analyze and then somehow shows the results in the UI.
Maybe just the html version, or by generating SARIF and using https://marketplace.visualstudio.com/items?itemName=MS-SarifVSCode.sarif-viewer.


[LBA] Checkbox to turn on/off path lines in map

Added checkbox to disable path lines in map:

Right now, it does not look nice.

Thanks to @int2001, the checkbox is much better.


Updating all gke cis  to avoid gh-actions annotation warnings

Related to https://github.com/epinio/epinio/issues/1797
Doing the same as in https://github.com/epinio/epinio/pull/1823 but for GKE-CI,GKE-CI-UPGRADE and GKE-CI-LETSENCRYPT
Task:
Bumping  .github/workflows/gke.yml, .github/workflows/gke-upgrade.yml and .github/workflows/gke-letsencrypt.yml  to remove annotation warnings related to deprecation of save-state and set-output commands among others
Done:

Updating Cache Tools to use actions/cache@v3 instead of fixed version
Updating Configure AWS credentials for Route53  to version node16 to avoid deprecation warning. Explanation here
Changing ::set-output to new echo "{name}={value}" >> $GITHUB_OUTPUT. Explained here

Codecov Report
Base: 60.09% // Head: 49.41% // Decreases project coverage by -10.68% :warning:

Coverage data is based on head (a06bad7) compared to base (e554439).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1825       +/-   ##
===========================================
- Coverage   60.09%   49.41%   -10.69%
===========================================
  Files         178      178
  Lines       14035    14035
===========================================
- Hits         8435     6936     -1499
- Misses       4527     6178     +1651
+ Partials     1073      921      -152

Flag
Coverage Δ

acceptance-api
46.57% <ø> (+0.29%)
:arrow_up:

acceptance-apps
36.45% <ø> (+0.02%)
:arrow_up:

acceptance-cli
?

unittests
8.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

internal/dex/code_verifier.go
0.00% <0.00%> (-100.00%)
:arrow_down:

internal/dex/dex.go
0.00% <0.00%> (-80.00%)
:arrow_down:

internal/cli/admincmd/settings.go
0.00% <0.00%> (-69.12%)
:arrow_down:

internal/api/v1/env/show.go
0.00% <0.00%> (-67.57%)
:arrow_down:

internal/cli/usercmd/env.go
0.00% <0.00%> (-66.02%)
:arrow_down:

helpers/bytes/bytes.go
41.66% <0.00%> (-58.34%)
:arrow_down:

internal/cli/settings.go
12.96% <0.00%> (-57.41%)
:arrow_down:

internal/api/v1/env/index.go
0.00% <0.00%> (-57.15%)
:arrow_down:

internal/api/v1/env/unset.go
0.00% <0.00%> (-55.89%)
:arrow_down:

pkg/api/core/v1/models/sort.go
50.00% <0.00%> (-50.00%)
:arrow_down:

... and 53 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

thank you @andreas-kupries


Tiny little Grammar changes

Just a bit of grammar fixes, nice project btw :D

Thanks @3kh0 for the PR!


Update index.d.ts

Hello,
I believe there's a slight omission in the type signature of the sign function.
The implementation of function sign takes a string for the messagePrefix argument and passes it to the magicHash function as the messagePrefix argument (which is typed as a string), but this information isn't reflected in the current .d.ts file. Currently, the types indicate that the user must pass a SignatureOptions type to sign as messagePrefix, a change made sometime between 2.0.0 and 2.1.3.
Note that if this was really the case, the change in  API from accepting a string to only accepting a SignatureOptions would likely have been called a breaking change. But, the same code used to work with version 2.0.0 still works with version 2.1.3, except for the types!
Since the code goes out of its way to support backwards compatibility, I believe the types should match.
Note that I have not yet bumped the version number.
Best,
Eric

I have made modifications.
The change that you made was incorrect, as someone who passes a string can also pass the SignatureOptions as well after the string. This pattern is defined by using overloading.

Looks good. Thank you!


Can't see backup files or Operating system error (Access is denied.)

Followed instructions both thru T-SQL and via UI (right click Restore Database...) on SMSS v18 preview 4 and one older version.  In all cases using SAS keys I can connect but not see the databases in the SMSS UI and via T-SQL I get Cannot open backup device. Operating system error (Access is denied.)  Our SQL-MI was deployed on 11/27/2018.  Our team suspects an issue with the SMSS client.  Testing the corresponding URL for the SAS key works and I'm able to download the file.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 759e5bd8-e4f0-24aa-ab48-c2820fccd39a
Version Independent ID: b42082b1-8c3e-82d0-d6ea-ecd57be1cdba
Content: Restore a backup to Azure SQL Database Managed Instance
Content Source: articles/sql-database/sql-database-managed-instance-get-started-restore.md
Service: sql-database
GitHub Login: @srdan-bozovic-msft
Microsoft Alias: srbozovi

@Knight21024 Thanks for the question! We are investigating and will update you shortly.

@Knight21024 Do you have other issues with using SSMS client while connected with the Azure SQL Managed Instance? This is either a route issue (either forward or reverse route table is missing) assuming you are attempting to run SSMS from on-premise or from another VNet, or this is a bug with SSMS. The route issue tends to be login issue, and you can authenticate without issue.

@Knight21024 We will now proceed to close this thread. If there are further questions regarding this matter, please comment and we will gladly continue the discussion but, this specific issue is better served through support. There are no documentation related action items.

Recently i created brand new mis and peering azure vnet and mis vnet. i can connect msi from azure vm and create the a/c as well. And then create the storage/container and upload the backup. I only allow to access my storage from azure vm vnet that i installed ssms. i can see my backup file if i use the ps. but i can't restore the db that i upload to storage. i changed storage access to public. still can't restore the db.


Expose Headers, Request and Response to window

These three constructor should expose to global (window and worker).
Especially Headers.
Because headers in fetch option accepts native object and Header object.

FF has it exposed now too. Merging so we can start writing tests against the constructors.


Improve test suite for faceting

I've written out some Gherkin.  There are some other rules in  Faceting Principles that I'm yet to include (the one about label vs id), but I think these are the critical ones I want to cover right now.
I have so far made this applicable to any API, so the ruleset (and possibly the actual Scala features file) could be reused elsewhere.
 Feature: Faceting - aggregations and filters
   Background:
     Given a dataset with aggregable values

   Rule: Aggregations are only returned when requested
     Aggregations are returned in the aggregations collection,
     they can be slow and expensive, and shouldn't happen if the client doesn't want them
       Scenario: a request with no aggregations
         When records are requested
         Then no aggregations are returned
       Scenario: a request with one aggregation
         When records are requested with an aggregation
         Then that aggregation will be returned
       Scenario: a request with multiple aggregations
         When records are requested with two aggregations
         Then both aggregations will be returned

   Rule: Queries constrain the document collection over which aggregations operate
       Scenario: a request with a query and aggregations
         When a query is made with two aggregations
         Then only documents that match the query are counted in the aggregations

   Rule: Filters apply to all aggregated fields apart from their own
       Scenario: filtering one one field, and aggregating on another
         filters constrain the document collection for other aggregations
         When records are requested
         And the request is filtered on one field
         And asks for aggregation on another field
         Then only documents that match the filter are counted in the aggregation
       Scenario: filtering and aggregating on the same field
         filters do not constrain the document collection when aggregating on that same field
         When records are requested
         And the request has a filter
         And asks for aggregation on the same field
         Then documents that do not match that filter are also counted in the aggregation
       Scenario: applying multiple filters to the same field
         When records are requested
         And the request has two filters on the same field
         And asks for an aggregation on the same field
         Then documents that do not match either filter are also counted in the aggregation
       Scenario: multiple filters and aggregations
         filters apply to all aggregations but their own
         When records are requested
         And the request has filters on two different fields
         And asks for an aggregation on the same fields
         And asks for an aggregation on yet another field
         Then only documents that match the filters on other fields are counted in the aggregation on each field

   Rule: Buckets with zero counts are only returned if they have an associated filter
       Scenario: requesting empty buckets
         When records are requested
         And the request has a filter on field A that excludes all resources with values in field B
         And asks for an aggregation on field B
         Then no aggregations are returned for field B
       Scenario: requesting redundant filters
         Combinations of filters and queries may result in some filters being redundant
           i.e. that there are zero matches for it.
            Any filter values with corresponding aggregations should be present in
           the aggregation, regardless of bucket count being zero
         When records are requested
         And the request has a filter on field A that excludes all resources with values in field B
         And has a filter on field B
         And asks for an aggregation on field B
         Then the bucket corresponding to the field B filter is returned

   Rule: Queries and filters operate together
       Scenario: an aggregation with queries and filters
         When a query is made
         And the request is filtered on one field
         And asks for aggregation on another field
         Then only documents that match the filter and the query are counted in the aggregations

   Rule: Erroneous requests are rejected
       Scenario: an unknown aggregation
         When records are requested
         And the request asks for an aggregation on a non-aggregable field
         Then a 400 error is returned
       Scenario: an unknown filter
         currently, unexpected querystring parameters are ignored, should it be like this instead?
         When records are requested
         And the request asks for a filter on a non-filterable field
         Then a 400 error is returned```


MB-8839 Next button link from shipment review page to agreement page

Description
The "Next" button on the Customer shipment review page directs the user to the agreement page, but currently links to /moves/:moveId/agreement. This PR fixes the link so that :moveId is replaced with the actual uuid of the move (e.g. /moves/cef88530-60a0-41df-88a3-7c0a7fe1860c/agreement).
Setup
Add any steps or code to run in this section to help others prepare to run your code:
make server_run
make client_run

Create a user and progress through the flow to adding an HHG shipment. Add the shipment as normal, click through to the review page, and then click "Next" to proceed to the agreement page.
Code Review Verification Steps

[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change

Warnings

:warning:

Files located in legacy directories (src/shared or src/scenes) have
been edited. Are you sure you don’t want to also relocate them to the new file structure?
View the frontend file org ADR for more information

Messages

:book:
:link: MB-8839

  Generated by :no_entry_sign: dangerJS against e61fd6b04a304e6c1fe6d4585d874b4be82f3b53


Compilation vs code Mise a jour include path

Issue Type: Bug
{
"resource": "/c:/Program Files/vscode/BIGTREETECH-SKR-V1.3-master/BIGTREETECH-SKR-V1.3-master/BTT SKR V1.4/Firmware/Marlin-2.0.x-SKR-V1.4-Turbo/Marlin/Configuration.h",
"owner": "C/C++",
"code": "1696",
"severity": 8,
"message": "Erreurs #include détectées. Mettez à jour includePath. Les tildes sont désactivés pour cette unité de traduction (C:\Program Files\vscode\BIGTREETECH-SKR-V1.3-master\BIGTREETECH-SKR-V1.3-master\BTT SKR V1.4\Firmware\Marlin-2.0.x-SKR-V1.4-Turbo\Marlin\src\Marlin.cpp).",
"source": "C/C++",
"startLineNumber": 2,
"startColumn": 1,
"endLineNumber": 2,
"endColumn": 30
}
Extension version: 1.0.1891
VS Code version: Code 1.43.2 (0ba0ca52957102ca3527cf479571617f0de6ed50, 2020-03-24T07:38:38.248Z)
OS version: Windows_NT x64 10.0.18363

System Info

Item
Value

CPUs
Intel(R) Core(TM) i3-4130 CPU @ 3.40GHz (4 x 3392)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: unavailable_offprotected_video_decode: unavailable_offrasterization: unavailable_offskia_renderer: disabled_off_okvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
3.94GB (0.55GB free)

Process Argv

Screen Reader
no

VM
0%

Thanks for reporting this issue, @yvonma. What were you doing with Live Share at the time when you saw this error message? Weer you trying to debug? Were you the host or the guest? Also, uploading your logs to this issue could help us investigate. You can get your logs by opening the command palette (ctrl + shift + p) and typing the Live Share: Export Logs command.

Closing due to age. Please re-activate if you're still running into the issue! Logs would help us address the problem too!


Steps are debuggable

Fixes #37

ci atm is very unreliable and sometimes works and sometimes doesn't not sure what to do about that.

Also we dont really understand why the fix works but if it works that should still be better than anything we had before right? :D

Pull Request Test Coverage Report for Build 248

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.9%) to 61.212%

Totals

Change from base Build 246:
1.9%

Covered Lines:
808

Relevant Lines:
1320

💛  - Coveralls

The test actually checks wether parsing works or not, previously the method would not even parse things but just throw an exception when called because it was sending a message to a Parser which the parser isn't implementing at all.

I found out that the inconsistent CI results are because of our still rather new ReadMeFactory. I am currently trying to fix it but I am not sure if the current version is deterministicly running. Merge anyways?


usePointStyle doesn't seem to work for mixed charts

Expected Behavior
I want there to be a rect in the legend for the bar dataset of a mixed chart and am using usePointStyle to accomplish this.
Current Behavior
When turning usePointStyle to false, all legend items are squares, which is expected.
When turning usePointStyle to true, the two line datasets use the point style they are assigned but the bar dataset ignores their's and defaults to the circle instead of the assigned 'rect'.
Possible Solution
usePointStyle should also effect bar datasets along with line datasets for when mixed charts are used.
Steps to Reproduce
Here is an example on Code Pen:
https://codepen.io/ChuckMickieC/pen/ZEBZVjW
Environment

Chart.js version: ^2.9.4
Browser name and version: Firefox Developer Edition 75.0b11 (64-bit)

Any information on this would be helpful and I would prefer not building out a customized legend as I would think this would be built into ChartJS. I do understand that the pointStyle obviously is in reference to point data but then how else do you customize a bar's legend symbol in a mixed chart? In this way, it would almost benefit it to always make bar charts a 'rect' but that seems too sweeping of a change in case other uses are needed from it.
Thank you in advanced!

Fixed in V3: https://codepen.io/leelenaleee/pen/oNYOmJO


[main] Use target/midstream branch instead of upstream tag to infer tag

This caused https://github.com/openshift-knative/eventing/pull/280

/assign @Cali0707 @creydr


[Suggestion] Use state bags

Seems like you are using events, using StateBags could be interesting in this use case, see : https://docs.fivem.net/docs/scripting-manual/networking/state-bags/
GlobalState could be used to sync on the entire server, or statebag on the specific vehicle

Yeah, State Bags are definately the smarter way to go about this. As it's just a PoC, I'm fine with they are atm.


refactor(ast): inline AstKind::as_* methods

One would hope compiler will inline these trivial methods anyway, but mark them #[inline] to make sure.

Very little difference on benchmarks (I believe the +2% on one semantic benchmark is spurious - those benchmarks have a lot of variance). But I think a good idea regardless, especially for external consumers who don't enable LTO.


feat(): add support for angular@6

Description
Now that angular is in RC mode. We will add support for angular/material/rxjs 6.
This means a breaking change since covalent wont work with any version lower than 6.. so we will have to start the 2.0.0 beta process and take advantage of this to include new things and change some things for the better.
This doesnt mean 1.0.0 is dead yet, we will still support it and apply bugfixes to it until 2.0.0 is stable. But all new features will go directly to 2.0.0.
What's included?

Upgrade angular, material and rxjs to 6.0.0
Apply breaking changes from them
Update typescript to 2.7.2
Update @ngx-translate/core and other dependencies that needed angular 6 support.
Update @angular/cli to 1.7.3

Test Steps

[ ] yarn install
[ ] npm run serve
[ ] See that everything still works the same

General Tests for Every PR

[ ] npm run serve:prod still works.
[ ] npm run tslint passes.
[ ] npm run stylelint passes.
[ ] npm test passes and code coverage is not lower.
[ ] npm run build:lib still works.

closes https://github.com/Teradata/covalent/issues/1133

Related https://github.com/mgechev/rxjs-tslint


possible vm being killed after pause

hyperstart message is sent out and then vm is paused, the expected reply message will timeout and causing vm being killed

@gao-feng does this bug still exist?

I guess so,  this is a rare case

I think it is fixed by #512 @gao-feng


Inconsistent refresh buttons

What would you like to be added:
The position of the refresh button can be unified to reduce confusion.
Why is this needed:
In the job list, the refresh button is on the upper left, but in a specific job page, the refresh button is on the upper right.
Without this feature, how does the current module work:
I often encounter this situation: I only found the refresh button in the upper right corner when the mouse was moved to the upper left corner and vice versa.
Components that may involve changes:
UI

This feature request could be resolved by moving refresh button to right in job list page. @yangou1988 What do you think?


unable to launch the box

Hi jbarone ,
i am getting the following error message after initiating vagrant up in the directory
C:\xxelab-master>vagrant box list
There are no installed boxes! Use vagrant box add to add some.
C:\xxelab-master>vagrant up
Bringing machine 'default' up with 'virtualbox' provider...
==> default: Box 'ubuntu/trusty64' could not be found. Attempting to find and install...
default: Box Provider: virtualbox
default: Box Version: >= 0
==> default: Loading metadata for box 'ubuntu/trusty64'
default: URL: https://atlas.hashicorp.com/ubuntu/trusty64
==> default: Adding box 'ubuntu/trusty64' (v20160602.0.0) for provider: virtualbox
default: Downloading: https://atlas.hashicorp.com/ubuntu/boxes/trusty64/versions/20160602.0.0/providers/virtualbox.box
default: Progress: 100% (Rate: 147k/s, Estimated time remaining: --:--:--)
==> default: Successfully added box 'ubuntu/trusty64' (v20160602.0.0) for 'virtualbox'!
==> default: Importing base box 'ubuntu/trusty64'...
==> default: Matching MAC address for NAT networking...
==> default: Checking if box 'ubuntu/trusty64' is up to date...
==> default: Setting the name of the VM: xxelab-master_default_1466008070435_68752
==> default: Clearing any previously set forwarded ports...
==> default: Destroying VM and associated drives...
==> default: Running cleanup tasks for 'shell' provisioner...
C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/util/io.rb:32:in encode': "\x96" from ASCII-8BIT to UTF-8 (Encoding::U ConversionError)         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/util/io.rb:32:in read_until_block'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/util/subprocess.rb:162:in block in execute'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/util/subprocess.rb:160:in each'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/util/subprocess.rb:160:in execute'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/util/subprocess.rb:22:in execute'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/plugins/providers/virtualbox/driver/base.rb:404:in block in raw'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/util/busy.rb:19:in busy'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/plugins/providers/virtualbox/driver/base.rb:403:in raw'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/plugins/providers/virtualbox/driver/base.rb:342:in block in execute'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/util/retryable.rb:17:in retryable'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/plugins/providers/virtualbox/driver/base.rb:337:in execute'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/plugins/providers/virtualbox/driver/version_5_0.rb:251:in read_forwar s'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/plugins/providers/virtualbox/driver/version_5_0.rb:458:in block in re
ports'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/plugins/providers/virtualbox/driver/version_5_0.rb:451:in each'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/plugins/providers/virtualbox/driver/version_5_0.rb:451:in read_used_p
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/plugins/providers/virtualbox/action/prepare_forwarded_port_collision_p
:12:in call'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in call'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/builtin/env_set.rb:19:in call'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in call'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/builtin/provision.rb:80:in call'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in call'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/plugins/providers/virtualbox/action/clear_forwarded_ports.rb:15:in ca         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in call'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/plugins/providers/virtualbox/action/set_name.rb:50:in call'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in call'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/plugins/providers/virtualbox/action/clean_machine_folder.rb:17:in cal         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in call'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/plugins/providers/virtualbox/action/check_accessible.rb:18:in call'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in call'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:95:in block in finalize_action'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in call'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in call'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/builder.rb:116:in call'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/runner.rb:66:in block in run'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/util/busy.rb:19:in busy'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/runner.rb:66:in run'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/builtin/call.rb:53:in call'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in call'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:95:in block in finalize_action'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in call'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in call'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/builder.rb:116:in call'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/runner.rb:66:in block in run'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/util/busy.rb:19:in busy'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/runner.rb:66:in run'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/builtin/call.rb:53:in call'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in call'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:95:in block in finalize_action'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in call'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in call'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/builder.rb:116:in call'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/runner.rb:66:in block in run'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/util/busy.rb:19:in busy'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/runner.rb:66:in run'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/builtin/call.rb:53:in call'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in call'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/builtin/box_check_outdated.rb:68:in call'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in call'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/builtin/config_validate.rb:25:in call'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in call'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/plugins/providers/virtualbox/action/check_virtualbox.rb:17:in call'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in call'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:95:in block in finalize_action'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in call'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in call'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/plugins/providers/virtualbox/action/match_mac_address.rb:16:in call'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in call'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/plugins/providers/virtualbox/action/import.rb:32:in call'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in call'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/plugins/providers/virtualbox/action/customize.rb:40:in call'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in call'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/plugins/providers/virtualbox/action/check_accessible.rb:18:in call'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in call'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:95:in block in finalize_action'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in call'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in call'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/builder.rb:116:in call'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/runner.rb:66:in block in run'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/util/busy.rb:19:in busy'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/runner.rb:66:in run'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/builtin/call.rb:53:in call'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in call'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/builtin/config_validate.rb:25:in call'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in call'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:95:in block in finalize_action'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in call'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in call'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/builtin/handle_box.rb:56:in call'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in call'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:95:in block in finalize_action'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in call'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in call'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/builder.rb:116:in call'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/runner.rb:66:in block in run'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/util/busy.rb:19:in busy'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/runner.rb:66:in run'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/builtin/call.rb:53:in call'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in call'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/plugins/providers/virtualbox/action/check_virtualbox.rb:17:in call'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in call'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/builder.rb:116:in call'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/runner.rb:66:in block in run'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/util/busy.rb:19:in busy'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/runner.rb:66:in run'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/machine.rb:214:in action_raw'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/machine.rb:191:in block in action'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/environment.rb:516:in lock'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/machine.rb:178:in call'         from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/machine.rb:178:in action'
from C:/HashiCorp/Vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/batch_action.rb:82:in `block (2 levels) in run'
C:\xxelab-master>
can you please suggest where it fails

Hmm, can't say that I've run into that before. Let me fire up windows and I'll test and see what's going on.

Hi thank you for rapid response , i manage to import the box .. here is the solution
you have to go to  C:\HashiCorp\Vagrant\embedded\gems\gems\vagrant-1.7.4\bin
And edit the vagrant (file) and put after this : #!/usr/bin/env ruby
this 2 lines
Encoding.default_external = Encoding.find('Windows-1250')
Encoding.default_internal = Encoding.find('Windows-1250')

currently am experiencing another issue .. after i imported the box successfully with two Network adapters .. still unable to connect to <IP_ADDRESS> trusting apache service should work fine but unable to trouble shoot since i can't log in to the box . may i know the credentials so
and what would be the issue here

you can just login with vagrant ssh the username and password is vagrant

@jbarone  have you blogpost about the box any where >?

i still have an issue , the hostonly interface not booting ..
tried sudo dhclient eth1 but no response .


Fix chinese lang not empty wait millis

修复typo
修复中文描述

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Richard Zhang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Is there a way to release lock acquired by LockingQueue?

In following scenario:

A message comes into the /queue
It is being received by using .get() method on the queue object, msg = queue.get()
A process is starting based on the data in the msg, but it fails
The failure is detected, the cleanup proces starts and finishes properly

Is there a way to release the lock on the message so that it wont have to be deleted using queue.consume(), and would be available for another /queue listener for processing and consumption (or even the same process again, starting from scratch)?
From my observations it seems the lock remains there indefinitely, until the process is connected to the queue.

Just dropping a friendly reminder here to say the above pull request fixes this issue and includes a unit test.

:+1:  seems ok to me!

I'd like to include this fix @bsanders, the PR was well done, I think after a rebase it should apply cleanly. Tests run more consistently as well which should help with merging. Thanks again for looking into this!

Thanks @bbangert, but you just accepted a separate PR's that covered the code portion, and someone else merged in a unit test, so feature-wise this issue is covered.
However, I did find a bug in the code you pulled in that wasn't in mine.  There's a missing set of parens on a function call, see PR #449.

Oops, sorry about that! I take it this issue can be considered closed then with your fix and the other PR that was merged?

I close this issue since #302 added the feature. Thanks.


PostgreSQL foreign key not created on self-reference

GORM Playground Link
https://github.com/go-gorm/playground/pull/340
Description
I am making an application that manages a file system. However, I noticed that AutoMigrate does not create a foreign key in postgres for self-references. Am I doing something wrong or is this a bug?

Turns out this is a duplicate of https://github.com/go-gorm/gorm/issues/4372
Closing...


The model is missing from https://paperswithcode.com/sota/image-classification-on-imagenet-1

Still there yet...


MERGE semantic should ignore duplicate records (bug from a COPY FROM CSV statement)

hi
let's say I have a CSV file containing some operational data with these headers:
Region	Country
NA		US
APAC	CHINA
EMEA 	UK
, im trying to work out the query to copy nodes and relations from a single CSV.  An equivalent neo4j query runs like this:
LOAD CSV WITH HEADERS FROM file AS row
MERGE (r:Region {region: row.Region})
MERGE (c:Country {country: row.Country})
MERGE (c)-[:IN_REGION]->(r)
as I already have region, country, and in_region rel tables available, I'd expect the above query to run in Kuzu as well.

Hi @hs41-18
We use a slightly different syntax when loading from a CSV file, that is, Kùzu directly parse a row into multiple columns. Below is a sequence of statements for loading. I assume the delimiter is , in your CSV file.
CREATE NODE TABLE Region (region STRING, PRIMARY KEY(region));
CREATE NODE TABLE Country (country STRING, PRIMARY KEY(country));
CREATE REL TABLE IN_REGION(FROM Country TO Region);

LOAD FROM <file> (header=true)
MERGE (r:Region {region: Region})
MERGE (c:Country {country: Country})
MERGE (c)-[:IN_REGION]->(r) ;

If you have large CSV files, I would suggest first format it into node files and relationship files whose bulk loading performance should be order of magnitude faster than MERGE. An example is shown below
COPY (LOAD FROM <file> (header=true) RETURN DISTINCT Region) TO "region.csv";
COPY (LOAD FROM <file> (header=true) RETURN DISTINCT Country) TO "country.csv";
COPY (LOAD FROM <file> (header=true) RETURN Country, Region) TO "in_region.csv";

COPY Region FROM "region.csv";
Copy Country FROM "country.csv";
Copy IN_REGION FROM "in_region.csv";

thanks for the reply @andyfengHKU. I want to achieve the first approach because my source file will contain ~50 columns, where I need to declare at least around 24 combinations of the columns, which is not easy challenge due to the size of the file.
LOAD FROM  (header=true)
MERGE (r:Region {region: Region})
MERGE (c:Country {country: Country})
MERGE (c)-[:IN_REGION]->(r) ;
This approach seems to be working, apart from the natural duplication I got because of repetitive regions with different countries. What is the best way of using Distinct with this syntax?

Hi @hs41-18, seems we have a bug here because MERGE semantic should ignore duplicate records. I'll open an issue for this.
Meanwhile the workaround that comes into my mind is
// For node tables
LOAD FROM (header=true)
WITH DISTINCT Region
CREATE (r:Region {region: Region})
...

// For rel table
LOAD FROM (header=true)
MATCH (r:Region {region: Region})
MATCH (c:Country {country: Country})
CREATE (c)-[:IN_REGION]->(r) ;

thank you @andyfengHKU  this is helpful, and happy to uncover a bug to fix. appreciate if you ping this thread once it is done

Forgot to mention but this should be fixed in #3216


Feature/#344 integration tests

IP Lab issue created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/12941


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-main" workflow

SonarQube Quality Gate Result

Result: :white_check_mark: OK
Triggered by @zxkane on pull_request

Metric
Status
Value
Error Threshold

Reliability rating
:white_check_mark: OK
1
> 1

Security rating
:white_check_mark: OK
1
> 1

Sqale rating
:white_check_mark: OK
1
> 1

Coverage
:white_check_mark: OK
91.10
< 80

Duplicated lines density
:white_check_mark: OK
0
> 30

Blocker violations
:white_check_mark: OK
0
> 0

Bugs
:white_check_mark: OK
0
> 0

Code smells
:white_check_mark: OK
0
> 40

Critical violations
:white_check_mark: OK
0
> 0

Major violations
:white_check_mark: OK
0
> 0

Vulnerabilities
:white_check_mark: OK
0
> 0

View on SonarQube
updated: 8/19/2024, 00:15:56 (UTC+0)

SonarQube Code Analytics
Quality Gate passed

Additional information
The following metrics might not affect the Quality Gate status but improving them will improve your project code quality.
Issues
 0 Bugs
 0 Vulnerabilities
 0 Code Smells
Coverage and Duplications
No data Coverage
No data Duplication

SonarQube Quality Gate Result

Result: :white_check_mark: OK
Triggered by @zxkane on pull_request

Metric
Status
Value
Error Threshold

Reliability rating
:white_check_mark: OK
1
> 1

Security rating
:white_check_mark: OK
1
> 1

Sqale rating
:white_check_mark: OK
1
> 1

Coverage
:white_check_mark: OK
91.10
< 80

Duplicated lines density
:white_check_mark: OK
0
> 30

Blocker violations
:white_check_mark: OK
0
> 0

Bugs
:white_check_mark: OK
0
> 0

Code smells
:white_check_mark: OK
0
> 40

Critical violations
:white_check_mark: OK
0
> 0

Major violations
:white_check_mark: OK
0
> 0

Vulnerabilities
:white_check_mark: OK
0
> 0

View on SonarQube
updated: 8/19/2024, 00:17:49 (UTC+0)


Implement more expression operators

The RexCallPlugin currently can only handle the most common expressions (binary operations, or and and). There are many more of them that could and should be implemented.
Similar to the aggregate functions in #9: One should also check, how many of them are actually in the calcite language standard and if choosing a different SQL dialect makes more sense.

First (maybe unfinished) set of operations, taken from SqlFunctions.java

[x] -
[x] *
[x] /
[x] +
[x] <
[x] <=
[x] =
[x] <>
[x] >
[x] >=
[ ] ABS
[ ] ACOS
[ ] ASIN
[ ] ATAN
[ ] ATAN2
[ ] BIT_AND
[ ] BIT_OR
[ ] BIT_XOR
[ ] CBRT
[ ] CEIL
[ ] COS
[ ] COSH
[ ] COT
[ ] DEGREES
[ ] EXP
[ ] FLOOR
[ ] LOG10
[ ] MOD
[ ] POWER
[ ] RADIANS
[ ] ROUND
[ ] SIGN
[ ] SIN
[ ] SINH
[ ] TAN
[ ] TANH
[ ] TRUNCATE


Fix jest config issue with react native projects

Fixes issue where the jest configuration wasn't being copied over properly due to the underlying file structure change in the react-native cli.

Changes proposed in this Pull Request:

Fix jest config issue with react native projects

Screenshots / Screen Recording (if applicable)

To Test:

clone project and run yarn build && yarn link
generate a new react native project with blui new
test all 3 templates for react native and ensure that the projects run and the jest.config.js file looks like this:

module.exports = {
    preset: 'react-native',
    transformIgnorePatterns: ['node_modules/(@react-native-community|react-navigation|@react-navigation/.*)'],
    setupFiles: ['./jestSetupFile.js', './node_modules/react-native-gesture-handler/jestSetup.js'],
    moduleNameMapper: {
        '\\.svg': '<rootDir>/__mocks__/svgMock.js',
        '.+\\.(css|styl|less|sass|scss|png|jpg|ttf|woff|woff2)$': 'jest-transform-stub',
        '\\.(css|less)$': 'identity-obj-proxy',
    },
};

Any specific feedback you are looking for?

I can install all 3 RN template projects and jest config file is good in each.  (no glue-gun issues)
I'm not certain if I'm still having some issues on my new Mac or not but I can run the blank template on android & iOS. Routing template doesn't run on either...
Auth template doesn't run on either...

I can install all 3 RN template projects and jest config file is good in each. (no glue-gun issues)
I'm not certain if I'm still having some issues on my new Mac or not but I can run the blank template on android & iOS. Routing template doesn't run on either... Auth template doesn't run on either...

This info is the same still not able to run 2 of the templates. Note that the Awesome Project from RN docs runs on both devices as well


distros: add ubuntu 16.04 back

Seems that OBS now fixed issues with ubuntu,
add it back.
Fixes: #607

/AzurePiepelines help

/AzurePipelines run

/test


add ruff to tox

Evaluating ruff, a new linter, for the repo. Starting by adding it to tox and having it run on the tests - weekly pipelines (alongside the other "vnext" checks which run against our libraries and fail with only warnings) so we have time to look at the linting errors per library and decide if we want to enable it.

We should pin ruff as a direct dependency within the ruff tox env. Currently it's just unspecified. Looks great otherwise!

I was thinking since we're still evaluating this linter for the repo, it would be fine to install the latest version. Since ruff is still under development to cover all the pylint rules, etc., they release almost every other week. If we later decide to make this a required CI check, then I agree that we need to pin the version. If that doesn't work, let me know.


Use the correct proto for benchmark_service

Fixes #15542

Please merge on green tests so we get a performance test run soon and can check the results.


Bundled Modules should be installed in \Name\Version\ folders in PSCore

Steps to reproduce
Install v<IP_ADDRESS> for Windows10
Open C:\Program Files\PowerShell\<IP_ADDRESS>\Modules and check the folder for the bundled module like PSReadLine
Expected behavior
There should be a folder relating to the version of the Module installed and the module files should be in that location i.e. C:\Program Files\PowerShell\<IP_ADDRESS>\Modules\PSReadLine\1.2\
Actual behavior
Module files are stored in the module name folder with no version folder i.e. C:\Program Files\PowerShell\<IP_ADDRESS>\Modules\PSReadLine\
Environment data
Name                           Value
----                           -----
PSEdition                      Core
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
PSVersion                      6.0.0-alpha
SerializationVersion           <IP_ADDRESS>
PSRemotingProtocolVersion      2.3
WSManStackVersion              3.0
GitCommitId                    v6.0.0-alpha.10-dirty
BuildVersion                   <IP_ADDRESS>
CLRVersion

This appears to affect all modules

This seems to still affect the modules below that are built along with PowerShell from what I can tell in the <IP_ADDRESS> release
CimCmdlets
Microsoft.PowerShell.Archive
Microsoft.PowerShell.Diagnostics
Microsoft.PowerShell.Host
Microsoft.PowerShell.LocalAccounts
Microsoft.PowerShell.Management
Microsoft.PowerShell.Security
Microsoft.PowerShell.Utility
Microsoft.WSMan.Management
Pester
PSDesiredStateConfiguration
PSDiagnostics
PSReadLine

Still relevant, but not critical for 6.0.0.

@joeyaiello - although not critical it is IMO detrimental for being able to ship any of these in packaged versions as separate packages

I believe it requires an enhancement in Import-Module to load last version, required version or explicit version too, doesn't  it?

@iSazonov import-module already understands module versioning, this should only require putting the module files under a version folder

Sorry for the inaccuracy. I mean, can the cmdlet do this for directory structure like "\PowerShell<PowerShell version>\Modules<Module name><Module version>" ?

Should be $PSHome/Modules//<ModuleVersion/

@iSazonov: yes, we look in any folder in PSModulePath for module folders, and in those module folders we look for version folders. In the absence of a version folder, we load the module from there.
For context, this is in the PSModulePath in 6.0.0-beta.1:
$env:psmodulepath
C:\Users\jaiello.REDMOND\Documents\PowerShell\Modules;C:\Program Files\PowerShell\Modules;c:\program files\powershell\6.0.0-beta.1\Modules

@kilasuit could you elaborate? I don't fully understand the scenario you're describing.

@joeyaiello - It just shows a level of inconsistency & it could easily cause confusion to those not that overly familiar. It also allows in future for the potential for all modules bundled with the engine to be unbundled as per #1979
Also as versioned modules support was brought in v5 it really doesn't make sense for there to be this inconsistency in a v6 product especially as you are moving to a more decoupled nature the further that the development goes on and on.

Until the module is decoupled from PSCore itself, there's no value to have it in a versioned folder since it's not updatable outside of updating PSCore itself.  The ones that have versioned folders are those obtained from PSGallery.

Currently we removed all external modules from the repo and as @SteveL-MSFT said all standard modules is installed without version folder to support servicing by WU.
So I close the Issue.


fix #61: Handle combined events the right way

Codecov Report

Merging #62 into master will decrease coverage by 0.97%.
The diff coverage is 60%.

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
- Coverage   97.46%   96.48%   -0.98%
==========================================
  Files           5        5
  Lines         197      199       +2
==========================================
  Hits          192      192
- Misses          5        7       +2

Impacted Files
Coverage Δ

test/unit/NotifierBuilderTests.cpp
96.23% <60%> (-1.05%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a75a9ae...1b500bb. Read the comment docs.