[FEAT] useDaoContext hook

Is your feature request related to a problem? Please describe.
When users navigate into pages that offer information and transactions in the context of a Kali DAO, they usually need to know the chain id and address of the DAO in order to fetch the correct underlying data and respectively submit contract write transactions correctly. This information is also used to make sure that the user is connected to the chain where the DAO is hosted before submitting a contract write transaction.
The hook can also offer a method to create a URL pre-populated with the DAO context parameters to be used in links to pages with a specific DAO context.
Describe the solution you'd like
Provide a react hook that extracts chain ID and address from router router correctly. Each app may provide its own configuration settings how the hook should map router params to values.
Describe alternatives you've considered
Currently each app handles its own way of parameterizing DAO context for pages, extract the context and create links. It makes it error prone and repetitive, especially when apps want to cross-link to each other's pages. For example when a SporosDAO app page (DAO projects) wants to link to a Kali DAO page (DAO registration page).

Would it be possible to also add other basic DAO related info, e.g., name(), symbol(), decimals(), in addition to chain ID and address, for UI purposes?
Usage of proposed data is not universal on all pages, so I'm not sure if it makes sense to create a separate hook or consolidate into this one.

Would it be possible to also add other basic DAO related info, e.g., name(), symbol(), decimals(), in addition to chain ID and address, for UI purposes?

Yes, these are pretty common and won't cost any additional round-trips to pull.

Usage of proposed data is not universal on all pages, so I'm not sure if it makes sense to create a separate hook or consolidate into this one.

Proposals can get complicated. Maybe keep this one clean and simple for basic DAO info. Need to think how to introduce proposal context in a hook. It think it ties to keeping subgraph updated, so that json structures are pulled quickly for any proposal by ID and have all the data the UI would expect. Currently the subgraph does not correctly pull ProjectManagement data and is only deployed on Goerli. We should probably open a separate issue to discuss how to manage extension type proposals. I talked to another developer today who is building a Kali extension for Gnosis. Hopefully one of many to come.


Refactored python code so that it conforms to PEP8

Used 'autopep8' to refactor the complete python code so that it conforms to PEP8.
Fixes #35.

@srgothi92, should I add this validation to GitHub Actions via a new pull request from a new branch or commit to this pull request and squash both the commits?

@srgothi92, should I add this validation to GitHub Actions via a new pull request from a new branch or commit to this pull request and squash both the commits?

We can have a separate PR that updates our GitHub actions to validate formatting and we can merge that before this PR. Once that is merged we should be able to see CI failing for other commit and this commit should be able to make CI happy. This way we can also validate our GitHub actions works.

@Rohan-cod can you fix git conflicts for this commit.

@Rohan-cod can you fix git conflicts for this commit.

Sure sir, I will resolve the conflicts.

@srgothi92, I am trying to squash the merge commit into the first commit, but am unable to do so. I searched on the internet and asked on StackOverflow too. If possible, can you please squash and merge using the 'squash and merge' option as shown in the image below

I apologize for the inconvenience caused.

@srgothi92, I am trying to squash the merge commit into the first commit, but am unable to do so. I searched on the internet and asked on StackOverflow too. If possible, can you please squash and merge using the 'squash and merge' option as shown in the image below

I prefer to avoid using this option particularly because the commit message of squashed commit does not describe the actual purpose of commit as would be expected by the author.

Sir, the commit message after squash using the 'squash and merge option' on GitHub according to this link will be the pull request title. And, the pull request title for this pull request is exactly the same as the first commit's message.

Actually, the problem is caused by the second commit in this PR. I asked about this on StackOverflow and received the following response

Is there anything that is blocking you from squash this locally ? If it is difficult and you need help, I can pull and submit a squashed commit on your fork.

It would be great if you can help Sir. Usually, I do the following:-

git rebase -i HEAD~n, n being the number of commits
Then I place squash in front of the commits that I want to squash.

But, in this case, the second commit is not showing up in the rebase.

Can you please close this PR.


SelectionArea supported gestures should have feature parity with TextSelectionGestureDetector

SelectionArea should have the same supported gestures as TextSelectionGestureDetector. This is a pre-requisite for migrating TextField from TextSelectionGestureDetector to SelectionArea. Some of these gestures are also needed for re-implementing SelectableText with SelectionArea https://github.com/flutter/flutter/issues/104547.
Platform Common:

TextSelectionGestureDetector
SelectionArea
isEditable/isNonEditable

Double tap to select a word

Both

Double tap + drag to select word-by-word

Both

Double click to select a word
https://github.com/flutter/flutter/pull/124817 ✅
Both

Double click + drag to select word-by-word
https://github.com/flutter/flutter/pull/124817 ✅
Both

Triple tap to select a paragraph

Both

Triple tap + drag to select paragraph-by-paragraph

Both

Triple tap to select all in a single-line input field

isEditable

Triple click to select a paragraph

Both

Triple click + drag to select paragraph-by-paragraph

Both

Triple click to select all in a single-line input field

isEditable

Long press to select word-by-word
https://github.com/flutter/flutter/pull/132518 ✅
Both

Shift + click to extend selection to clicked position

Both

Platform Mobile:

TextSelectionGestureDetector
SelectionArea
isEditable/isNonEditable

On single tap up moves the cursor to the tapped position

isEditable

Platform Desktop:

TextSelectionGestureDetector
SelectionArea
isEditable/isNonEditable

On tap down moves the cursor to the tapped position

isEditable

Platform Android:

TextSelectionGestureDetector
SelectionArea
isEditable/isNonEditable

Drag to move cursor

isEditable

Platform iOS:

TextSelectionGestureDetector
SelectionArea
isEditable/isNonEditable

Select word edge on tap up

isEditable

Drag that begins on cursor moves the cursor

isEditable

Long press to move cursor

isEditable

Long press to select word-by-word when input field is not focused

isEditable

Single tap on previous selection should toggle toolbar

Both

Platform Linux:

TextSelectionGestureDetector
SelectionArea
isEditable/isNonEditable

Triple tap to select a line

Both

Triple tap + drag to select line-by-line

Both

Given that there are so many unimplemented gestures on SelectionArea, is work better spent allowing it to share this code with EditableText instead of reimplementing these?  Or is it not so simple?

Talked offline with @justinmc and agreed to keep a look out for opportunities where we can re-use logic from EditableText.

With iOS, Is it possible to long press to select a word and combine it with tap to select all?


Questions

How can we disable Hangfire?  - We've use hangfire in the past and it hasn't worked well for us, I would like to disable it, usually there is a setting in the appsettings.  Ideally should be its own project not tied to the UI so you can scale up/out with it.
Auth options (google/ms) - Is there no config options to disable these?  Dont I need to set a ClientId/Secret for microsoft/AAD?  Where?  Again should be tied to appsettings options if not enabled dont show the options.
Tenants - Not sure what this is doing, can you login to a different tenant?  Database per tenant?  When you login what tenant are you in, what tenant are the "products" associated with, pick lists are system level or tenant?  There seems to be a disconnect between the demo/tenants or its not implemented.
Logs - This appears empty, I do see a log file though
Quick look thru the code there seems to be a bunch of random //ToDo: impementing xxxx   (These seem implemented, so why are they todos?)
In ProductsPaginationQuery.cs there is a comment of //the currently logged in user on a .ToString that shows the filters applied.
The same file has unused localizer.
Date filters - you seem to be converting to string and the back to datetime for some reason.
DateTime today = DateTime.Now.Date;
DateTime start = today;  // this is already 00:00:00 for the date
DateTime end = today.AddDays(1).AddTicks(-1);  // 23:59:59.9999999 for the date
DateTime last30day = today.AddDays(-30);  // this is already 00:00:00 for the date 30 days ago

Not sure if VS has the same inspections as Rider but rider is showing a bunch of warning that could easily be cleaned up.  Rider also offers free licenses for open source projects.

How can we disable Hangfire?
Yes, you can,
comment out below code
 <PackageReference Include="Hangfire.AspNetCore" Version="1.8.4" />
 <PackageReference Include="Hangfire.InMemory" Version="0.5.1" />
.AddHangfireService()
app.UseHangfireDashboard("/jobs", new DashboardOptions         {             Authorization = new[] { new HangfireDashboardAuthorizationFilter() },             AsyncAuthorization = new[] { new HangfireDashboardAsyncAuthorizationFilter() }         });
Auth options (google/ms) - Is there no config options to disable these?
Sorry, there's no option to disable Google or MS auth. You can only remove the buttons and the related code
Tenants - Not sure what this is doing, can you login to a different tenant? Database per tenant?
Tenants here don't support multiple databases. It's just a parameter for user logins and used to query data, not real multi-tenancy.
Logs - This appears empty, I do see a log file though
logs can only be written to MS SQL or PostgreSQL databases, not SQLiteDB.

Those '//ToDo: implement xxxx' comments were automatically generated by a code template tool. While they might seem implemented, the code still needs to be refactored based on specific requirements. I'm open to suggestions on how to better alert developers that these parts need to be modified according to actual needs.
the end, Thanks for pointing out the warnings in Rider. When I have time, I'll do some refactoring and optimization of the code to address these issues.

The todos are fine for code generation files.  But your example base installed files shouldn’t have them I wouldn’t think.
An option to create a mostly blank install could be useful with just like auth and admin/role.  Also using appsettings to toggle options would be great.  Adding some readmes about what multi tenant and the other features might help others too.  Any plans to add multi db support?

Thanks for the suggestions, @bakes82 . I agree with your ideas about the todos and installation files. A blank install with basic features and using appsettings to toggle options are great ideas. Regarding multi-database support, it's on my list to consider. Would you be interested in contributing a PR for these improvements? I'd love more community involvement.

I made a console app generator here:  It uses the same templates you had, I just refactored it to use Type.  But this way as a console app, people can add their own templates, or can be enhanced more easily like if you wanted to generate files from database first, plus its not dependent on VS.
https://github.com/bakes82/CleanArchitectureWithBlazorServer/tree/main/src/CodeGenerator
There needs to be more documentation, also the code generator doesnt create all the files needed.  Things missing context, permissions, some code has hard defined fields that might not exist EX: Name if you look at the AdvancedSpecification.cs.txt (Id assume this should also generate clauses for every field on the object but it doesnt its just hard coded)
I think if you can make a branch with just the "base" no example models, and then if you can write up the steps to make a new entity and then write templates (or reference an example) for each step it would be a great starting point because right now the lacking documentation is a bit confusing

Thanks for sharing the console app generator. However, I believe it's not suitable for other projects due to many dependencies. It might not be necessary to use this template for new projects, especially with the current lack of documentation and other issues.


No need for adding mousemove handler twice

Adding mousemove handler in eventualMovements function (line 72) is enough to all work properly.

Removing in a future commit.


override keyword doesn't check symbol-key class members

🔎 Search Terms
override symbol
override symbol member
override in:title
🕗 Version & Regression Information

This is the behavior in every version I tried

⏯ Playground Link
https://www.typescriptlang.org/play?#code/MYewdgzgLgBAZiEMC8MDKBPAtgIxAGwAoBKAbgFgAoYfAQwghgEEYBvKgXyqpvsYCEYAUwAeUIWAAmjFu0owFMEADchAJzUBLSUJgBtBCAC6JNjC6UOMIA
💻 Code
const foo = Symbol();
class A {
}

class B extends A {
    override [foo]() { }
}

🙁 Actual behavior
It compiles.
🙂 Expected behavior
There should be an error: This member cannot have an 'override' modifier because it is not declared in the base class 'A'.
Additional information about the issue
No response

Class inheritance in TypeScript does not allow derived classes to be broader than base classes. As per the Handbook:
TypeScript enforces that a derived class is always a subtype of its base class.
This means that members of the class that extends the base class that you override are covariant (as derived class is always a subclass of its base or, put simply, is more specific). Consider the following - the override works because "A" is a subtype of a broader union "A" | "B":
class A {
static b : Array<{ c: "A" | "B" }> = []
}
class B extends A {
static b : Array<{ c: "A" }> = [] // OK
}

Please don't post AI-generated replies that just explain normal everyday behavior and have nothing to do with the actual defect being reported.

I did post stackoverflow answer.  lol


Is it possible to run turbo model on M1?

    #if os(macOS)
    if deviceName.hasPrefix("arm64") {
        if Process.processor.contains("Apple M1") {
            // Disable turbo variants for M1

From the code, I know turbo model is disabled on M1.
Is it possible to run turbo model on M1?  why can't we run the turbo model ?

The models are JIT compiled on the first load (Core ML and WhisperKit call this phase "Specialization"). Compilation time and peak memory are prohibitively high for turbo+M1 combinations. If you do try the combination, it would be great if you documented your experience here for others.


Calculating distance for each road ID returned in debug format

Hi, as far as I understand, right now, in debug response format, Barefoot returns matched geometry along with a set of road IDs the car was travelling on (if I'm wrong, please correct me). I would like to know which points from returned geometry belongs to each road ID to calculate distances or percentage values of each road ID in every returned segment. Is there a way to modify Barefoot's response format to include such data?
Thanks in advance for your help!

The debug format contains for each position sample the matched road id. Hence, it does not necessary include the full sequence of road ids that the car was traveling on. To output the complete sequence of road ids with its geometry you could modify the toDebugJSON method in src/main/java/com/bmwcarit/barefoot/matcher/MatcherKState.java to something similar to this (not tested):
JSONArray jsonpath = new JSONArray();
if (this.sequence() != null) {
    for (int i = 0; i < this.sequence().size(); ++i) {
        MatcherCandidate candidate = this.sequence().get(i);
        JSONObject jsoncandidate = new JSONObject();
        jsoncandidate.put("time", this.samples().get(i).time() / 1000);
        jsoncandidate.put("road", candidate.point().edge().id());
        jsoncandidate.put("frac", candidate.point().fraction());
        if (candidate.transition() != null) {
            JSONArray jsonroads = new JSONArray();
            for (int j = 0; j < candidate.transition().route().size(); ++j) {
                JSONObject tuple = new JSONObject();
                tuple.put("id", candidate.transition().route().get(j).id());
                tuple.put(
                        "geom",
                        GeometryEngine.geometryToWkt(candidate.transition().route().get(j)
                                .geometry(), WktExportFlags.wktExportLineString));
                jsonroads.put(tuple);
            }
            jsoncandidate.put("roads", jsonroads);
        } else {
            jsoncandidate.put("geom", GeometryEngine.geometryToWkt(candidate.point()
                    .geometry(), WktExportFlags.wktExportPoint));
        }
        jsonpath.put(jsoncandidate);
    }
}
return jsonpath;

That's what I've been looking for! Thank you very much!

I have one last question here. Like you said, this solution isn't perfect as it gives lots of geometry duplicates. I'm handling it manually client-side right now. Last thing is that it returns too many points before route start point and after route end point. Is there any way to get rid of it?

Can you please check if there are actually multiple samples at the last location, i.e. samples with different timestamps but nearly same GPS coordinates? If so, try increasing matcherMinDistance to something like 5 (meters). If not, I would need the input and result data to check what's the problem.

I checked, you were right, there was multiple samples at the end of the route. I changed matcherMinDistance to 5, restarted Barefoot and even manually filtered out duplicate samples client-side, but the problem still exists and apears just as showed in the picture above. I'm wondering if it's caused by modifications I made to debug json response function. Can it be possible?

The map matching seems to rank the opposite side of the route to be more likely and, hence, takes the route to the end to road, makes a u-turn and goes back. Without a look into the data and the respective map, it's difficult to make give a hint. Also, I doubt that it's because of the output formatting.

I understand this, thank you very much for detailed explaination. I'll handle route ends just like you said.
My problem now is those geometry duplicates.. Until now I was just removing them, so if the two segments contained same road id I was putting its geometry to first segment. But the problem is, that, for my calculations to work I need matched segments to be exacltly matched with position samples. Do you think there is a way to achieve such output from Barefoot?

I'm not sure what you mean: If you want the exact matched position of each sample with the respective road geometry, you can add the geometry of the road and also the exact position on the road like this:
JSONArray jsonpath = new JSONArray();
if (this.sequence() != null) {
    for (int i = 0; i < this.sequence().size(); ++i) {
        MatcherCandidate candidate = this.sequence().get(i);
        JSONObject jsoncandidate = new JSONObject();
        jsoncandidate.put("time", this.samples().get(i).time() / 1000);
        jsoncandidate.put("road", candidate.point().edge().id());
        jsoncandidate.put("frac", candidate.point().fraction());
        jsoncandidate.put("geom", GeometryEngine.geometryToWkt(candidate.point().edge()
                                .geometry(), WktExportFlags.wktExportLineString));
        jsoncandidate.put("point", GeometryEngine.geometryToWkt(candidate.point()
                                .geometry(), WktExportFlags.wktExportPoint));
        jsonpath.put(jsoncandidate);
    }
}
return jsonpath;

The timestamp should be sufficient to map it to your sample data. Of course, this doesn't give a continuous geometry of the path if there is no position sample matched to some road that, however, belongs to the path.
Basically, all information is available. :)

It's not what I mean :) Right now, Barefoot returns something like:
[{
    "time":<PHONE_NUMBER>,
    "road": 124928716,
    "roads": [{
        "id": 105285935,
        "geom": "LINESTRING (19.463415 52.4350311, 19.4631816 52.4341445, 19.4631088 52.4338273, 19.4631016 52.4336454, 19.4631774 52.4335531)"
    }, {
        "id": 87873017,
        "geom": "LINESTRING (19.4631774 52.4335531, 19.463128 52.4334915, 19.4630595 52.4333102, 19.4629965 52.4330413)"
    }, {
        "id": 7458686,
        "geom": "LINESTRING (19.4629965 52.4330413, 19.4629416 52.4328331)"
    }, {
        "id": 7458688,
        "geom": "LINESTRING (19.4629416 52.4328331, 19.4629172 52.4327538)"
    }, {
        "id": 124928716,
        "geom": "LINESTRING (19.4629172 52.4327538, 19.4626956 52.4319333)"
    }],
    "frac": 0.3911227064395014
}, {
    "time":<PHONE_NUMBER>,
    "road": 115904455,
    "roads": [{
        "id": 124928716,
        "geom": "LINESTRING (19.4629172 52.4327538, 19.4626956 52.4319333)"
    }, {
        "id": 115904455,
        "geom": "LINESTRING (19.4626956 52.4319333, 19.4631246 52.4318226, 19.4636378 52.4317542, 19.4640542 52.4317082)"
    }],
    "frac": 0.044380183209406954
}]

...
As far as I understand it is the list of route segments between each pair of measured positions. But because of geometry duplicates I can't say which points in duplicated geometry belongs to which segment, which is crucial in my further computations. I need matched segments to start and end as close to the sample positions as possible. Do you know what I mean now? It's really hard to explain.

The reading of your sample is as follows:
Sample with timestamp<PHONE_NUMBER> is matched on road 124928716, whereas sample with timestamp<PHONE_NUMBER> is matched on road 115904455. On the way from the first to the second, your object has taken the path consisting of road sequence 124928716,115904455. The respective geometries of the roads are included. The only thing that I understand that's missing in your output is the exact position on the road which is outputted if you add this line:
jsoncandidate.put("point",GeometryEngine.geometryToWkt(candidate.point().geometry(), WktExportFlags.wktExportPoint));

(Side note: The fraction frac determines exatly that point.)
(The path to the first sample with timestamp<PHONE_NUMBER>is accordingly the road sequence<PHONE_NUMBER>,87873017,7458686,7458688,124928716.)
Basically, there are no random duplicates. - They only occur because each path from one sample to the next includes start and end road.


Color-Codes

Can you write me the html-codes of all colors you suported? thank you very much

Do you mean the primary colours used in the themes?

Yes, thank you very much. :-)


GitHub context fix

script names fixed

Why:
Closes #10017

What's being changed:

Check off the following:

[ ] I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
[ ] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[ ] This pull request impacts the contribution experience

[ ] I have added the 'writer impact' label
[ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@alvinseville7cf
Thanks so much for opening a PR! I'll get this triaged for review :zap:

I don't understand what I have to do now. Nothing? :)

@emilyseville7cf Yep!! Those workflows are waiting for an approval, so everything should run once the changes are reviewed and approved 👍 🐬 Thanks a bunch for your patience 💖

@emilyseville7cf It looks like I don't have permission to resolve the merge conflict. I think if you enable the checkbox to allow maintainer edits, then I will be able to resolve this. (https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork ) Alternatively, could you resolve the merge conflict?

@emilyseville7cf The PR has some unresolved conflicts which is blocking the merge process 💛  Could you please try resolving the conflict by merging into your working branch from main? Once the conflicts are resolved, I will be able to merge this PR ✨
Thanks so much for your time in contributing to the GitHub docs 💖

Could you please try resolving the conflict by merging into your working branch from main?

Yeah, I can. I will to it as soon as possible.

@ramyaparimi, everything is ready.

@emilyseville7cfg
Can you enable the checkbox to allow maintainer edits? Then I'll be able to hit the update button and get this merged in. Thank you! https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork
Thanks so much for your patience 💖

@ramyaparimi, this checkbox (Allow edits and access to secrets by maintainers) is already enabled.


decrease thread prioroity for backup

I wasn't sure what to do, I tought maybe set it to MIN, it would be very slow, but it seems to be ok.

priority != speed, and in most cases, with (semi-continuous) background stuff like scans and backups, you want them to be using minimal resources, so MIN is the right choice.

it's ideal to keep PRs focused on one thing. E.g., api-version is unnecessary to be set to 1.15, this would break the plugin since older versions that use this value would fail to load the plugin due to not recognizing the api version.

This is a huge PR if you're just changing the thread priority.
A few questions & suggestions:

Why did you need to bump the plugin version?
Why did you need to bump the Bukkit API version?

One of the things you added is the inclusion of the org.json library. Can you justify why this was needed when the current org.json.simple library was fine?
Lastly, you've encased a huge chunk of code in a try-catch. Ideally you'd encase individual pieces of code in checked try-catch statements so you can handle exceptions accordingly. e.g.
// The "catch everything" way
try {
    someMethodThatThrows();
    someMethodThatDoesNotThrow();
    // and so on...
} catch (Exception ex) {
    // Some generic "something went wrong" error handling
}

// The more precise way
try {
    someMethodThatThrows();
} catch (IOException ex) {
    // Handle this specific situation, return if you don't want to continue
}

// This doesn't need to be caught
someMethodThatDoesNotThrow();

Constructive criticism, don't take it as an insult :)

As a follow up it would be an even better idea to have the thread priority to be set in the plugin's config so the server administrator can choose. That's merely an idea and doesn't affect this PR.

I started with only the priority stuff, then I admit I did some digression. :-)


Fix #477, add a way to set the intensity of the skybox

When there is no indirect light it wasn't possible to control the
skybox's intensity. Now the skybox has its own intensity that
is used in that case.

Thanks for fixing this!

What about rotation?


Why public events are not published?

I'm trying to use public channels and I can't find a way to broadcast the messages. I see that messages for public channels are not being published (code).
I have to use private or presence channels? The .NET client library has a complicated authentication mechanism for this channels, I'm trying to avoid it.

You mean client-events https://pusher.com/docs/client_api_guide/client_events#trigger-events ?
Client events are just for private/presence channels. From the docs:

Client events can only be triggered on private and presence channels because they require authentication

A normal event is triggered through the /events REST API. I suggest you to read this https://pusher.com/docs/server_api_guide/interact_rest_api . After a quick search through pusher organisation I think you should use this: https://github.com/pusher/pusher-http-dotnet

Thanks for clarifying.
The problem with this library is that it does not use websocket, so, I'll have to use two different libraries, one for sending messages and one for receiving. I wish I could avoid it.

I see.. but that's how Pusher works. You can use client-events as they are generated through the websocket connection but they require private/presence channels.
More info: https://pusher.com/docs

Yeah, of course.
Thank you

Haha. I'm sorry if it felt like I was complaining :)
no problem! :+1:
It's important to have authentication here as it would be fairly easy to spam your system using a public channel.


Implement station usage verification (GTFS rule)

Is your feature request related to a problem? Please describe.
A stop and station should be used at least once. This is a GTFS rule implemented in Google Python validator and featured in Google Type Error as TYPE_STATION_UNUSED.
Describe the solution you'd like
Actual Google GTFS validator behaviour : verifies a stop from database. Verifies if stop is used, station associated, and if stop is too far from parent station
Describe alternatives you've considered
Additional context
Line 87 and 109 in Error support priorities https://docs.google.com/spreadsheets/d/1vqe6wq7ctqk1EhYkgtZ0_TbcQ91vccfs2daSjn20BLE/edit#gid=0

This is similar to the unused_shape and unused_trip validation rules.
Although this is not explicitly mentioned in the spec or best practices, this could be added to this validator if the community sees value in having this check.

This request was made in 2020.
In 2021 a change was made to warn if any stops do not appear in stop_times:
https://github.com/MobilityData/gtfs-validator/pull/960
That seems to be the most important part.
There seem to be two other parts to this request:

Verifying that each station is used by at least one stop/platform.
Verifying that stops/platforms are not too far from their stations.

I don't see either of those in the set of rules.
Are those two desired?

Verifying that each station is used by at least one stop/platform.
Verifying that stops/platforms are not too far from their stations.

[…] Are those two desired?

Yes! 🙋

I recommend having INFO for this notice since having stations used isn't an official requirement or recommendation from the spec or Best Practices.
Opened issue #1348 to follow up about the severity of three other issues that might also need to be downgraded (or to have the spec amended).

I made PR #1355 to check that a station is used by some stop.
The last part of this issue is checking distance between a stop and its parent_station.
I don't see any guidelines in the best practices document.
There are some large train stations that have platforms pretty far from one another.
Here are some possible approaches:

Use a simple threshold. If we accept INFO messages for large train stations, this could be 100 or 200 meters. If we don't want many INFO messages for large train stations, then maybe 500 meters.
Use a threshold based on the number of stops. For a two-stop station like a bus stop with stops on opposite sides of a street, use a small threshold like 100 meters (used for shapes and stops). For a many-stop station be more lenient.
Use some more complicated logic, like whether the stops in a station form a reasonable cluster (are there outliers?) and whether the station location is central in that cluster.

Anyone have opinions?

Hello @bradyhunsaker, thank you for working on this and sorry for the late answer on this issue.

The last part of this issue is checking the distance between a stop and its parent_station.

I believe this is part of issue #154, and there is a proposition for what thresholds to use.
Your work on #1355 would close this issue. 🚀

@isabelle-dr Did https://gtfs-validator.mobilitydata.org/rules.html#platform_without_parent_station close out this issue?

No, the two checks mentioned in this comment are still relevant.
They are part of the Python validator but not this one, and they are both out of spec.
I would recommend adding them as INFO.
Here is the logic for these new rules:
Verifying that each station is used by at least one stop/platform.
For each stop_id that has location_type set to 1 (a station):
   If the stop_id is not referenced in any of the stops.parent_station:
         Generate an unused_station notice.

This is along the lines of he unused_shape and unused_trip.
Verifying that stops/platforms are not too far from their stations.
For each stop_id that has location_type set to 1 (a station):
    For each stop_id that has this particular station defined in parent_station:
        Calculate the distance between this stop_id and the station.
              If the distance is bigger than [threshold], generate a stop_far_from_station notice

I just noticed we now have [unused_parent_station](https://gtfs-validator.mobilitydata.org/rules.html#unused_parent_station-rule, so this first one is solved.


Use alluxio scheme and master ip to access alluxio failed

Alluxio Version:
2.0.0
Describe the bug
i configured alluxio.master.hostname=BJLFRZ-10k-214-99.hadoop.jd.local in the alluxio.properties, and i access alluxio use alluxio://ip:port/, but i failed. But, it succeed if i use the configured host.
To Reproduce
$ alluxio fs ls  alluxio://<IP_ADDRESS>:19998/
The URI authority <IP_ADDRESS>:19998 does not match the configured value of host_172_1_0_99:19998.

Expected behavior
i think use both ip and hostname should access alluxio successfully.
Urgency
HIGHEST
Additional context
NO

@maobaolong why is the hostname being set differently between alluxio.properties vs in the URI? If you're setting the host in properties, you can use a URI like alluxio:/// instead, is that an option for you?

@maobaolong Closing this due to inactivity, please reopen if you still have this issue.


Add space after emoji

Details

We add a space after emoji at message composer. In this PR we are introducing the same feature for edit field.
Fixed Issues

$ https://github.com/Expensify/App/issues/11818
PROPOSAL: https://github.com/Expensify/App/issues/11818#issuecomment-1278034294
Tests

Open any chat > Send message > Edit
Click on emoji button and select an emoji
Verify space gets added after the emoji

[x] Verify that no errors appear in the JS console

QA Steps

Open any chat > Send message > Edit
Click on emoji button and select an emoji
Verify space gets added after the emoji

[x] Verify that no errors appear in the JS console

PR Review Checklist

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots

Web

https://user-images.githubusercontent.com/101883770/198346870-1387e772-30cf-4572-9808-a76f99c0794f.mov
Mobile Web - Chrome

https://user-images.githubusercontent.com/101883770/198347694-0c9cefb0-b77e-4f54-b3ac-91b7bc9d70a6.mov
Mobile Web - Safari

https://user-images.githubusercontent.com/101883770/198343131-932b1543-fe2a-4b80-8b80-a1fdaf488c57.mov
Desktop

https://user-images.githubusercontent.com/101883770/198346497-fb795bf7-2c6b-4371-b020-ea45eb673173.mov
iOS
https://user-images.githubusercontent.com/101883770/198343738-3ed8c3f1-644b-4833-9828-8d3e3a3efdc5.mov
Android

https://user-images.githubusercontent.com/101883770/198344244-0bacb4f3-1ec2-4c16-8e64-c3159086fdd6.mov

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to production by @Julesssss in version: 1.2.22-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


[5.7] Removed UnauthorizedException

https://github.com/laravel/framework/pull/23674 with fixed spacing.

Original message for reference:
This PR removes the UnauthorizedException, which is no longer used in the framework. I've raised this issue here: https://github.com/laravel/ideas/issues/1047, and it was accepted as a candidate for PR by Taylor.
To summarize:
UnauthorizedException was only used in failedAuthorization method in Illuminate/Validation/ValidatesWhenResolvedTrait.php. This trait is used only in Illuminate/Foundation/Http/FormRequest.php, which overrides the failedAuthorization method throwing AuthorizationException instead. UnauthorizedException was therefore never thrown by the framework itself, so I don't think we really need it.

which is no longer used in the framework.

Isn't that a bit misrepresentative when your PR clearly shows that the exception was used before you changed it?
Anyhow, what's the upgrade path for every application and package that was throwing this exception? Would it make sense to deprecate the exception class for one release according to https://github.com/laravel/ideas/issues/383?

By 'no longer used in the framework' I meant that the only place where the UnauthorizedException is thrown in Laravel framework (not independent packages, or apps) is not reachable.
Taylor replaced virtually all references to this exception with AuthorizationException in https://github.com/laravel/framework/commit/1f804b9b518902f1fb736f86a8847b589f824a0f

for consistency with ValidationException.

The only place where he left it was failedAuthorization method in the Illuminate/Validation/ValidatesWhenResolvedTrait. However, since https://github.com/laravel/framework/commit/7e3341043343415480b564b19c53547d8ddb8f76 this method is overwritten in Illuminate/Foundation/Http/FormRequest, which is the only place using that trait.
My only objective in removing this was cleaning up the framework the from old code - not to make Laravel 'heavier' than necessary. If you think it should stay there, no hard feelings :)

One problem with changing it to this exception is that the validation component does not require the illuminate/auth component in its composer.json file, so it would not have access to this exception when being used in a stand-alone package. That may be a rare situation, but something to consider here.
We would either have to throw a more generic Exception and let anyone who is using this manually define their own exception or leave it as-is.


Update type-snob extension

Description

Moved the characters list to its own file (characters.ts)
Added more characters (fractions, daggers, and other marks).
Added HTML entities for each character, with a keyboard shortcut for copying it.
Added a "Paste in Active App" keyboard shortcut.
Added example usage for most of the characters.
Added prettier icons for smart quotes.

Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Sorry, I'm not sure why it's showing conflicts for all of the files 😬
On a separate meta note, I used Raycast AI to automate the addition of example and html properties 🎉

I made a mess of this in Git. Closing in favor of a cleaner PR.


RFE Add 'move issue'

Feature Description
I would like to propose a 'move issue' function that can move an issue, from repo into another repo.
Screenshots
No response

Note: this should be a duplicate if you can find the original

Note2: on move create a redirect ... so kinda add issue type redirect and let rest stay as is. create new issue in new repo and Copy issue. second change direct referenced content (comments...)

#453
duplicate


Flashing PiSCSI SD images with Raspberry Pi Imager v1.8.1 breaks piscsi-web

Something changed with the Raspberry Pi Imager between v1.7.4 & v1.8.1 that seems to affect network startup & the 1st run of the piscsi-web service (which runs piscsi/python/web/start.sh).  The initial pip install fails leaving the bjoern package broken.  Looking at the beginning of the piscsi-web log seems to indicate pip can't access the Internet right away:
-- Journal begins at Mon 2023-11-13 12:08:03 GMT, ends at Thu 2023-11-16 01:20:51 GMT. --
Nov 13 12:08:23 piscsi systemd[1]: Started PiSCSI-Web service.
Nov 13 12:08:26 piscsi PISCSIWEB[485]: Creating python venv for web server
Nov 13 12:08:40 piscsi PISCSIWEB[485]: Activating venv
Nov 13 12:08:40 piscsi PISCSIWEB[485]: Installing requirements.txt
Nov 13 12:08:47 piscsi PISCSIWEB[581]: Looking in indexes: https://pypi.org/simple, https://www.piwheels.org/simple
Nov 13 12:08:47 piscsi PISCSIWEB[581]: WARNING: Retrying (Retry(total=4, connect=None, read=None, redirect=None, status=None)) after connection>
Nov 13 12:08:47 piscsi PISCSIWEB[581]: WARNING: Retrying (Retry(total=3, connect=None, read=None, redirect=None, status=None)) after connection>
Nov 13 12:08:48 piscsi PISCSIWEB[581]: WARNING: Retrying (Retry(total=2, connect=None, read=None, redirect=None, status=None)) after connection>
Nov 13 12:08:50 piscsi PISCSIWEB[581]: WARNING: Retrying (Retry(total=1, connect=None, read=None, redirect=None, status=None)) after connection>
Nov 13 12:08:54 piscsi PISCSIWEB[581]: WARNING: Retrying (Retry(total=0, connect=None, read=None, redirect=None, status=None)) after connection>
Nov 13 12:08:55 piscsi PISCSIWEB[581]: WARNING: Retrying (Retry(total=4, connect=None, read=None, redirect=None, status=None)) after connection>
Nov 13 12:08:55 piscsi PISCSIWEB[581]: WARNING: Retrying (Retry(total=3, connect=None, read=None, redirect=None, status=None)) after connection>
Nov 13 12:08:56 piscsi PISCSIWEB[581]: WARNING: Retrying (Retry(total=2, connect=None, read=None, redirect=None, status=None)) after connection>
Nov 13 12:08:58 piscsi PISCSIWEB[581]: WARNING: Retrying (Retry(total=1, connect=None, read=None, redirect=None, status=None)) after connection>
Nov 13 12:09:02 piscsi PISCSIWEB[581]: WARNING: Retrying (Retry(total=0, connect=None, read=None, redirect=None, status=None)) after connection>
Nov 13 12:09:02 piscsi PISCSIWEB[581]: ERROR: Could not find a version that satisfies the requirement wheel
Nov 13 12:09:02 piscsi PISCSIWEB[581]: ERROR: No matching distribution found for wheel
Nov 13 12:09:02 piscsi systemd[1]: piscsi-web.service: Main process exited, code=exited, status=1/FAILURE
Nov 13 12:09:02 piscsi systemd[1]: piscsi-web.service: Failed with result 'exit-code'.
Nov 13 12:09:02 piscsi systemd[1]: piscsi-web.service: Consumed 19.883s CPU time.
Nov 13 12:09:03 piscsi systemd[1]: piscsi-web.service: Scheduled restart job, restart counter is at 1.
Nov 13 12:09:03 piscsi systemd[1]: Stopped PiSCSI-Web service.

This page talks about how to properly wait for networking to actually be available as a prerequisite in Systemd init scripts:
https://www.freedesktop.org/wiki/Software/systemd/NetworkTarget/
Steps to fix appear to be:

Enable the proper systemd-networkd-wait-online.service is enabled
systemd-networkd-wait-online.service

Add a Wants line to the piscsi-web.service init so it looks like this:
[Unit]
Description=PiSCSI-Web service
After=network-online.target piscsi.service
Wants=network-online.target piscsi.service

[Service]
Type=simple
Restart=always
ExecStart=/home/pi/piscsi/python/web/start.sh
SyslogIdentifier=PISCSIWEB

[Install]
WantedBy=multi-user.target

Another option is to make start.sh wait for pypi.org to be available before running the pip install.  Something like this would work:
until ping -c1 -q pypi.org >/dev/null; do sleep 2; done;

This will just do a DNS query rather than try to communicate with the remote site:
until getent hosts pypi.org >/dev/null; do sleep 2; done;

Maybe something like:
for i in `seq 1 30`; do
        sleep 3
        getent hosts pypi.org >/dev/null 2&>1 && break;
done
if [ $? -ne 0 ]; then
  echo "dns resolution failure - pypi.org"
  ERROR=1
fi

This tries to resolve it 30 times with 3 second gaps between attempts, then exits with the above error.
Needs to go before line 33 (currently) where ERROR is checked.
Note: The sleep needs to occur before getent, else you'll be checking the exit value of the sleep command.

Note: Exiting if there is no internet might not be the best idea though, as this stops people being able to use the web interface on a local network that has no internet connection. Maybe putting something similar in a function and calling it when net is absolutely needed and spitting out a msg when it can't resolve the name instead.

A longer term way to fix this is proposed in #1153 , which aims to set up a proper pip local cache to avoid going to the net where possible.


Direct Execution RestHandler

Ask the handler for direct execution instead of just looking at the RequestLane. This became necessary because in some cases the IOContext executed long running tasks and the server became unresponsive.

http://jenkins01.arangodb.biz:8080/job/arangodb-matrix-pr/7335/

http://jenkins01.arangodb.biz:8080/job/arangodb-matrix-pr/7336/

http://jenkins01.arangodb.biz:8080/job/arangodb-matrix-pr/7351/

This looks good, but has too many crashes in the latest Jenkins run. Will not merge now, need to investigate more.

http://jenkins01.arangodb.biz:8080/job/arangodb-matrix-pr/7364/

http://jenkins01.arangodb.biz:8080/job/arangodb-matrix-pr/7365/

http://jenkins01.arangodb.biz:8080/job/arangodb-matrix-pr/7389/

@maierlars there is an assertion in macOS catch run (http://jenkins01.arangodb.biz:8080/job/arangodb-matrix-pr-mac-onlycatch/5308/EDITION=community,limit=mac/):
[----------] 5 tests from MaintenanceFeatureTestThreaded
[ RUN      ] MaintenanceFeatureTestThreaded.populate_action_queue_and_validate
[       OK ] MaintenanceFeatureTestThreaded.populate_action_queue_and_validate (1000 ms)
[ RUN      ] MaintenanceFeatureTestThreaded.action_that_generates_a_preaction
[       OK ] MaintenanceFeatureTestThreaded.action_that_generates_a_preaction (1006 ms)
[ RUN      ] MaintenanceFeatureTestThreaded.action_that_generates_a_postaction
2019-11-25T17:36:45Z [19650] FATAL could not broadcast the condition: Invalid argument

Please, fix it.

http://jenkins01.arangodb.biz:8080/job/arangodb-matrix-pr/7409/

http://jenkins01.arangodb.biz:8080/job/arangodb-matrix-pr/7417/

Tests blue!


CHECK_TRUE and CHECK_FALSE inconsistency while checking against an explicit bool operator.

I've recently run into strange behavior when testing an std::unique_ptr variable by the CHECK_FALSE macro and then by the CHECK_TRUE. The std::unique_ptr class has an explicit bool operator that helps to check whether it holds a nullptr or not.
Here's an example:
auto const aNull = std::unique_ptr<int>(nullptr);
CHECK_FALSE(aNull); // works fine due to the negation(!) operator applied at the UtestShell::getCurrent()->assertTrue(!(condition)...
auto const notNull = std::make_unique<int>(1);
CHECK_TRUE(notNull); // can't use the explicit bool operator thus it does not work as the CHECK_FALSE version.
A contextual conversion is required to call the explicit bool operator, so the static_cast(notNull) or !!notNull fixes compilation, but it does not solve the problem of the inconsistency.
My preference is to add an explicit cast at the UtestShell::getCurrent()->assertTrue(static_cast(condition)... to the both macros.

Have you fixed this already?

Not sure

Ok. fixed now.


Log to console if client succeeded to connect & start streaming or not

Coverage remained the same at 100.0% when pulling ade42d8d5e8658c1df11b39701114fdb7f0b2a15 on ellenaua:speech-report-connection-error into cd1ea90c1656eb6f53b0f6dfad37d017fc3947b0 on GoogleCloudPlatform:master.


Allow Documents to be created within subfolders via the CMS

This feature is currently blocked by a bug with the GraphQL Client and breadcrumbs:
https://github.com/tinacms/tinacms/issues/2708
Summary
As a Tina User, I want to be able to create documents nested within subfolders under my collection's path (for example, posts is my Blog Post collection, but I would like to have my recipe posts stored in posts/recipes/new-favorite-recipe.mdx) so that I have better control over how my content is organized.
Expected Results

Within the CMS, on the Create Document page, modify the filename (relativePath) field to allow for / characters.

Modify the regex to allow for / characters and update the invalid message to include / character.
For Example, include more examples: My_Document, subfolder/My_Document, and My_Document.en

Within the CMS, on the Document List page, include the subfolder(s) as part of the filename.

Will need left-side overflow ellipsis so that filename is always the most visible part.

Within the CMS, on the Document List page, ensure all routing accounts for the subfolders + filename (currently does not).
Will also want to make sure subfolder(s) + filename works with RouteMapper (it should, but just test and confirm).

Notes
Initially, I purposefully restricted the filename to match the allowed pattern for relativePath, but lately, we've been relaxing those criteria and allowing the user more control over the filename (i.e. allow for . so that localization can be included).  I feel this is another step in that direction, but the CMS was not built for handling subfolder routes.
This is a feature request from Discord users.

This will also provide the fix for https://github.com/tinacms/tinacms/issues/2708.


Add a sample for creating IgGrid which consumes an WebApi

It would be nice to have a sample demostrating how to bind the grid to WebApi.
http://www.infragistics.com/community/forums/t/107512.aspx

It can be done following the Angular 2 documentation for the server communication - https://angular.io/docs/ts/latest/guide/server-communication.html

This sample demonstrates how to configure IgGrid Component to talk to remote server. It is based on the HTTP Client demo with Observables. It is using in-memory web API simulator, to avoid the hassle in creating web API server. There is also an ability to create new products and send them to the backend.
The grid is created when bound to an empty data source and then using a service to populate the data.


Weird rendering after response comes in for terminal inline chat

Here's what it looked like before:

And after I esced out of inline chat:

That is weird. I can't reproduce here. If you can make it happen again, can you inspect the DOM to see if some element is obscuring the terminal? I notice that the gs are cut off:

The positioning of the .xterm element would also be handy:

I couldn't find any element that was obscuring the terminal. Let me know if you want to take a look!


[feature suggestion] Ability to configure keys on returned object

The current implementation of importAll.sync and importAll returns an object where the matched file paths are the keys and the value is set to all of the exports from the module.
I would like a way to specify the names of the keys on the object. For example a function could be used to modify the original key name like this.
const utils = importAll.sync("../utils/*", ({ path }) =>  path.replace('../utils/', '').replace('.js', ''));

import * as _utilsAJs from '../utils/a.js'
import * as _utilsBJs from '../utils/b.js'
import * as _utilsCJs from '../utils/c.js'
import * as _utilsDJs from '../utils/d.js'

// Notice the keys are filenames without the paths and extensions
const a = {
  'a': _filesAJs,
  'b': _filesBJs,
  'c': _filesCJs,
  'd': _filesDJs,
}

Additionally, other metadata could be passed to the function that defines the key names (like current file name, index of the matched file, etc)

I worry this would make the tool more complex than is necessary. Is there any reason you couldn't just do that transformation at runtime?

I could do it in runtime. I just figured it could be done at build time to save a couple of bytes and processor cycles from the production build.

I'm afraid the bytes and cycles saved wouldn't be worth the added complexity.
If you're really worried about it, them use preval.macro instead.

Thanks for bringing up the idea!


Enum values are not updated when changed

Describe the bug
When defining and using an enum in Entity like this one :
@Entity({ tableName: 'foo' })
export class Foo {
  @PrimaryKey()
  public id: number;

  @Enum({ items: () => FooTypes })
  public type: FooTypes;
}

If i update (add a value, change a value, or even delete one) in my enum that is like this :
export enum FooTypes {
  A = 'A',
  B = 'B',
  C = 'C'
}

Nothing is taken into account. Whether i use schema:update, schema:fresh or even create a migration with migration:create, my changes are not detected.
The only thing that worked, was change the column type, like make it a VARCHAR and reverted it back to the initial Enum it was, and it sucessfully updated.
To Reproduce
I created a repository so that you can better understand the issue, unfortunately i would like to keep a mysql database since it may come from here as well. So you would need to input a real database in the repro unfortunately.
Expected behavior
Enum values should be updated in the database properly
Versions

Dependency
Version

node
16.13.0

typescript
4.8.4

mikro-orm
5.6.2

mikro-orm/mysql
5.6.2

nest-js
9.2.1

Not reproducible on my end, tried with mysql driver, and it correcly detects the change. Here is a passing test case, lets reopen with a failing one.
import { Entity, Enum, PrimaryKey } from '@mikro-orm/core';
import { MikroORM } from '@mikro-orm/mysql';

enum FooTypes {
  A = 'A',
  B = 'B',
  C = 'C',
}

enum FooTypes2 {
  A = 'A',
  B = 'B',
}

@Entity({ tableName: 'foo' })
class Foo {

  @PrimaryKey()
  id!: number;

  @Enum({ items: () => FooTypes })
  type!: FooTypes;

}

@Entity({ tableName: 'foo' })
class Foo2 {

  @PrimaryKey()
  id!: number;

  @Enum({ items: () => FooTypes2 })
  type!: FooTypes2;

}

test('enum diffing with case sensitive column names (GH issue #2938)', async () => {
  const orm = await MikroORM.init({
    entities: [Foo],
    dbName: `mikro_orm_test_enum1`,
    port: 3308,
  });
  // create schema with Foo and FooTypes
  await orm.schema.refreshDatabase();

  // mimic change on the Foo entity to use FooTypes2
  await orm.discoverEntity(Foo2);
  orm.getMetadata().reset('Foo');
  const diff1 = await orm.schema.getUpdateSchemaSQL({ wrap: false });
  expect(diff1).toMatch("alter table `foo` modify `type` enum('A', 'B') not null;");
  await orm.schema.execute(diff1);

  await orm.close(true);
});

Note that I used mysql as well as tried this in the realworld example app (so a nestjs project), same outcome, no issues on my end. I guess you are oversimplifying?

Maybe i explained badly, but what i mean by changing the enum is changing it's values. Like changing the file foo.enum.ts from
enum FooTypes {
  A = 'A',
  B = 'B',
  C = 'C',
}

to
enum FooTypes {
  A = 'A',
  B = 'B'
}

And i expect the database to receive this change. I say that because in your above example you are creating 2 entities, with 2 different enums.

Okay so @B4nan i tried to play around a bit, and it seems that it successfully understand the enum modification if you create a new enum containing the changes. So doing this for example
export enum OldFooTypes {
  A = 'A',
  B = 'B'
}

export enum NewFooTypes {
  A = 'A',
  B = 'B',
  C = 'C'
}

Works, maybe because it somehow detect that the type changed.
But if you use the same enum file, and just change it's values, i think you will have the same issue.

Should i create another tickets with the latest infos i got ? (i mean, my latest comment)

Maybe i explained badly, but what i mean by changing the enum is changing it's values. Like changing the file foo-types.enum.ts from

I did understand fully, and I did test it exactly that way in the realworld example project - it works just fine there.

So, i'll include full pictures of what i did just to be sure. Because i also did the same things on the same project as you, realworld example project (that i forked), and i have the same issue.
Here is what i did in my fork :

2 npm script to update my database schema, and to generate a migration file
an enum on User that is named UserTypes

My first enum values were as in the last commit, like this :
export enum UserTypes {
  A = 'A',
  B = 'B',
  C = 'C',
}

I then execute my script to update the schema, and so far everything works. As you can see in the following screen my enum is there, and can be changed / used..etc

But if i change the same file, that is, the same enum, but i only change it's values, so that means instead of having the previous enum, i have now the following :
export enum UserTypes {
  A = 'A',
  B = 'B'
}

Now doing schema:update update nothing as you can see

Ok, the problem is indeed in the enum being defined in an external file, weird but I got it reproduced and that's what matters :]

Yes I also use that in my own project, and since when you tested in a single file you had no problem it seems to come from here. I see that TsMorphMetadataProvider has a useCache() method, is there a way do disable metadata cache ? To let you time to investigate more into this

https://mikro-orm.io/docs/metadata-cache

The problem here is that the cache is not invalidated automatically - as that is driven by the hash of contents of your entity definition file, and that is not changed when you define the enum outside of it.
This is one of the cases where manual clear is required, you can do that by calling npx mikro-orm cache:clear or simply by wiping the temp folder via rm -rf temp. I will close this as wontfix, I don't think that we can do much about it (not without rather complex hashing of the whole graph of files based on imports, which could end up being quite expensive).

Actually, I might have a way to do this, let me give it a quick try.

I don't have an easy way to unit test this, but it should help.

@B4nan I updated to the last version, and it works perfectly !
Maybe change this ticket status to "Clossed issue" ? Since you tagged it as "Not planned" few days ago, but it got pushed into master, so it may be confusing.


Select Entities plugin selects visual not model

Environment

OS Version: Ubuntu Bionic
Source or binary build?
source build,

ign-gui6 branch, commit 443bfac97f6d214bbcc01dc2af7a573e4bba7ea6
ign-gazebo6 branch, commit 3a1adb3152f873348ad5fd4e014e11268e281842

Description

Expected behavior: clicking on a model in the scene selects the model
Actual behavior: The visual is selected instead

Steps to reproduce

Launch diff_drive.sdf world
Left click on one of the vehicles in the 3d scene and see that only individual visuals are selected

I think the fix is just to get the top level visual like it was done in GzScene3d:
https://github.com/ignitionrobotics/ign-gazebo/blob/ign-gazebo5/src/gui/plugins/scene3d/Scene3D.cc#L1633
Output
Gif shows the current behavior from selecting different parts of the vehicle.

Fixed in #1150


RFP - bs1770gain

It is a loudness scanner. It helps normalizing the loudness of audio and video files to the same level.
http://bs1770gain.sourceforge.net

Status: Review
https://chocolatey.org/packages/bs1770gain

Status: Published
https://chocolatey.org/packages/bs1770gain
Can be closed.


Doesn't work in IE

My main use case for using this tool is to find the names and codes of different keys in IE11, which most of the time are different than in other browsers, but it seems like this tool is not designed to work in IE at all.
Was previously supported and not anymore or what's the reason for not supporting IE?

As an alternative you can use https://crisbnp.github.io/keycode-generator/

Hi, what do you mean by "Doesn't work"? What is the current behaviour? What is the expected behaviour? Share some examples, images to explain the issue better. Thanks!

Hi, what do you mean by "Doesn't work"? What is the current behaviour? What is the expected behaviour? Share some examples, images to explain the issue better. Thanks!

Well, seems like the styles are not loaded properly and when pressing a key nothing happens. Here's a demo where I press several keys and the app doesn't do anything.

And the console looks like this:

Closing this as we are not adding fix for IE11 anymore, as Microsoft will stop support for Internet Explorer 11, Legacy Edge by 2021.
For more info: https://techcommunity.microsoft.com/t5/microsoft-365-blog/microsoft-365-apps-say-farewell-to-internet-explorer-11-and/ba-p/1591666


Update README.md to improve word choice

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)

Hey @CodeMaster7000
Thank you for opening this pull request.
This is a standard message notifying you that we've reviewed your pull request and have decided not to merge it. We would welcome future pull requests from you.
Thank you and happy coding.


refactor: reduce noisy log level

What was wrong?
This log is actually very noisy when it's being run. Turning down the log level to reduce log bloat, created issue to track investigation of the cause log noisiness (#1221)
How was it fixed?

reduced log level

To-Do

[ ] Clean up commit history and use conventional commits.

I don't think we should reduce this logs level. It is noisy because we have a problem no? so it is doing its job.
If we fix the problem it will stop being noisy so I think solving the root problem is the solution in this case

I agree that this indicates something wrong with some client on the network that we don't want to ignore. Have you checked the client string in the ENR? I'm unable to reproduce locally.

Looking back into this, I'm still seeing a fairly significant number of duplicate offers. However, they all appear to be from fluffy clients, judging by the client info in the enr. Given that fluffy doesn't yet support any kind of offer queue to prevent duplicate offers, I think it's reasonable to reduce the log level to debug since it's not necessarily indicative of an error. Though, I'm surprised that @mrferris wasn't able to reproduce this locally? Given the amount that I'm seeing it, this should be a fairly common experience.


Add "-l" for "--disable-rune-loss", fix and improve readme and er-patcher

Hi, thanks for this MR. I like the idea of using -l for the rune loss option but other than that I do have some issues with the MR:

The changes are mostly cosmetic and don't really solve any issue.
I get that streamlining the mish-mash of "disable" and "remove" is a cosmetic improvement but IMO that doesn't justify the introduction of breaking changes.
Currently, the options are sorted by inclusion in --all, why should this be changed?

The "fix" part was referring to the typos; I wanted to put a title as short as possible. Also, even if they are mostly cosmetic, I think that it could save some time to people in practice, not to mention that they lower the file sizes.
What exactly became broken after the changes? I could try to fix it.
I sorted them by alphabetical order, but the order of inclusion was changed too, so it should not cause issues.


Remove huge padding at top of clock

Such a large padding makes it unusable for me

Cool, thanks for your contribution.


Quake 2 missing version server tag

Was querying a Quake 2 server (address: <IP_ADDRESS>:27950) and it threw PacketBad bacuse the version tags were missing from the reported server variables.
Not sure if this is related to only Quake 2 the protocol or the game, I assume the protocol.

Fixed in commit ada60f2376d6877d40e37a70eea4248cbec3b1f1.


App Group: add an org unit to an application group

Add an org unit to an app group
use a widget similar to add app
entry should end-up in app_group_ou_entry table
existing component for selecting the org unit should be used for the interactive selection logic
Testing steps
Add / Remove the Organization Unit to a group and verify that correct applications are shown after refreshing the app-group screen for the affected application group.

Relates to #4228


Continuous Integration step using travis

Why did you closed this PR instead of merge it? that is root cause of the problem you have in the current opened PR.

Please follow these steps:

Restore this branch
Re-open this PR and if all checks passes, merge it.


Prefer &T to *const T for Win32 input parameters

A relatively small change to code gen has a big impact on usability. Basically, Win32 pointer parameters are turned into references. Of those, optional parameters are wrapped in Option. I have avoided applying this to void pointers for the time being as they are a little trickier to deal with. The effect in usability is very compelling. For example:
CreateEventA goes from this:
let handle = CreateEventA(core::ptr::null_mut(), true, false, None)?;

To this:
let handle = CreateEventA(None, true, false, None)?;

Direct2D's EndDraw method goes from this:
target.EndDraw(std::ptr::null_mut(), std::ptr::null_mut())?;

To this:
target.EndDraw(None, None)?;

Non-optional pointer parameter are now immutable references, which doesn't really affect calling patterns but makes it a lot less confusing when reading the docs.
Mutable pointers are now mutable references, wrapped in Option as needed.
Unfortunately, it also highlighted a few more metadata bugs:
https://github.com/microsoft/win32metadata/issues/1005
https://github.com/microsoft/win32metadata/issues/1006
Overall, a very nice improvement for working with Win32 API calls.
Fixes #1441
Fixes #816

Yep, I looked for issues and didn't come across any (other than void* which I excluded) but we can return to pointers if we run into issues, while keeping the Option improvement.

This pr changed IWTSVirtualChannelManager.CreateListener to take a &u8 instead of a *const u8. I was able to get a *const u8 by simply calling as_ptr() on a null terminated string, but obviously that does no longer work. Would it be possible to document cases like this, or should they be excluded as well?

It may be a regression - can you open a new issue if you believe that may be the case? Otherwise I may lose track of it.

Created #1988


Add tmp dir to the .npmignore.

https://github.com/ember-cli/ember-cli/issues/4199

like: https://github.com/ember-cli/ember-cli/commit/6ac18227ea571988fa9d9950e9a1051fdd990c7c

published in 0.1.2


Question service

Improve question-related UI and add sample questions to seed database when empty
Create Workspace component with question description, generated using Markdown

lgtm!


Allow tap interception to be configurable

Allow tap interception to be configurable so that we can allow horizontal scrolling in the drag view

Closing this, since you can now disable touch via setTouchEnabled.


Handling new users information

There are currently 20-22 issues related to new users on the issue tracker. May be we should provide suggest adding PR to update this page https://babeljs.io/users/ instead of opening issues?

We can also add a label for such issues :)

I have a half-baked script that can automate a good portion of the work I do to add each logo. I resize/optimize each image and review their usage permissions carefully.

@thejameskyle May be we can add that script in this repo which can help the users to add their logo?

I'll try to finish it more

Probably best not to let people specify what position they appear in though.

@sebmck We can mention that new logos will be added in the end and PR's can always be monitored.

We tell people to open a PR now so gonna close


[client-api-schema] Finalize JSON RPC API

Feature Description
Right now the client-api-schema package contains the parameter, response, error, and request types for the JSON RPC interface used to communicate with the channel wallet. As it stands, this rpc interface isn't completed or consistent between the wallet implementations. There are a few items to come to consensus on, see: #2504 #2505 #2506 #2507 #2508 #2509
Rationale
Once the JSON RPC interface is defined, we are able to build out mocks to make progress on the server-wallet and our nonrouting-node implementation simultaneously.
Additional Context
A finalized JSON RPC spec will be created here

I'd be curious to see how far these mocks can be built out with the existing APIs we have, and which of these issues are in fact blocking

I mean we're going to start building out against what is there and the methods we have a strong idea are finalized regardless. But the further along we get the more may change with these lower level changes, so definitely very high priority to get this finalized


Enable full convolution with the Theano backend

Theano supports convolution with border_mode = 'full'. This patch adds this to the list of supported border modes in Keras.
TensorFlow does not support full convolution (according to the documentation). In that case this will raise an exception saying Border mode not supported: full, similar to the current behaviour.

That's reasonable.


Center content in Masonry

How does one go about centering the content inside Masonry?

Assign me this issue


Use provenance url instead domain for sources

In place page, we will still show the domain but the link links to the full url.
In timeline tool, it shows the full url:

there could be multiple sources per chart in the timeline tool, so would be good to display only the domain there as well.
this pr would be a case where the mixer + website change should be in the same pr, so that they can be synced? but i'll approve the mixer pr, so that the mixer submodule in this repo can be brought up to date with the non-backwards compatible change.

there could be multiple sources per chart in the timeline tool, so would be good to display only the domain there as well.
this pr would be a case where the mixer + website change should be in the same pr, so that they can be synced? but i'll approve the mixer pr, so that the mixer submodule in this repo can be brought up to date with the non-backwards compatible change.

nice catch!

there could be multiple sources per chart in the timeline tool, so would be good to display only the domain there as well.
this pr would be a case where the mixer + website change should be in the same pr, so that they can be synced? but i'll approve the mixer pr, so that the mixer submodule in this repo can be brought up to date with the non-backwards compatible change.

changed to use domain and updated mixer submodule in this PR too.


cd: report error on bad dir instead of hanging

TODO: we munge NotFound errors in the dispatch() function in a
way that causes us to report that the "cd" command was not
found, rather than the invalid directory.  Fix for that will
come soon.
TBR @rpaquay

lgtm
Fixes #156


Fix the broken MacOS build

With the latest Github actions update and the build containers using python 3.12, the "This environment is externally managed" error crops up if we use pip3 to install dependencies directly.
https://stackoverflow.com/questions/75608323/how-do-i-solve-error-externally-managed-environment-every-time-i-use-pip-3
The error continues even when we use Virtual Environment.

b9b21ad395148885e05b99649434c42ac63cfae3


Request: resizable window

Hello! Great tool, automagically found my install and everything.
One issue: giant unsizable window in 2023? I can't move it to my secondary monitors (which are vertical) and it's huge and bright blazing white besides, any chance of standard window controls being added? Thanks!

This is just a fork of  the original project, only things I changed was stuff tying it to WotR. However, asked bubbles about why sizing was disabled, and he said he can't remember.
I'm unlikely to do any actual feature changes, more doing maintenance, sorry


upgrade open liberty maven plugin

Signed-off-by: Emily Jiang<EMAIL_ADDRESS>

@Karm @rdebusscher please review


Enable keystone groups searching in LDAP

When using LDAP as a keystone identity backend it is useful to allow
keystone to look up groups in LDAP so that LDAP groups can be given
automatic project assignments, negating any need for an administrator to
give assignments to individual LDAP users. This patch adds the necessary
settings to the keystone proposal to allow keystone to be aware of
groups in LDAP. It changes the user_id_attribute to 'uid' because that
is the attribute LDAP itself uses to determine group membership, but
this change means that the old 'hybrid' method will use 'uid' rather
than 'suseid' as the keystone user ID. We also add a smoke check to make
sure that keystone can find groups and understands group membership as
defined in LDAP.

cc @bmwiedemann

This seems to break some Cloud 6 runs: see https://ci.suse.de/job/openstack-mkcloud/58166/console
{"error":"Failed to validate proposal: key 'group_members_are_ids:' is undefined.\n"}

addressed in #1829


Shulkerbox drops inventory when you hit it with pickaxe.

When you have a shulkerbox with items in it, place it on the ground, and use pickaxe on it, the shulker drops it's inventory after being hit with the pickaxe.

that doesn't sound good, I´ll look into excluding inventories that should retain their content

what version do you need it for?
should be able to fix 1 version today, the others I'll do tomorrow and do and publish to MR

Sorry, forgot to mention version, I'm running Fabric 1.20.2.

in a couple minutes an "Artifacts" button appears at the bottom here, click that, then grab the fixed jar from inside that zip, have fun
will close this issues when it's all backported and released

oh wow, it's called Magnet-Command-24 (24 as in build number)
you can grab it with this link directly (still have to get the jar out of the zip)

Thanks for the quick response and update, it works just fine now.


Encodable and Decodable should be named Encode and Decode

The trait names in Rust are verbs, not adjectives. But before we rename it I would like to see if there's a benefit of keeping some kind of compatibility layer once we implement push-based decoding or custom IO traits.

@Kixunil Any updates on this ? Let me know if I can volunteer a patch to do it if community feels that it is needed.

Please wait with it.

I don't have a problem with Encodable and Decodable.

FWIW I agree with this issue.

Me too, but let's not rename stuff until we're breaking the trait anyway. In fact we may wind up needing two copies of these traits temporarily, depending how our crate smashing goes, and that could be an opportunity for the "new" ones to be renamed.


DeserialiseFailure on resubmitting Conway Tx with invalid plutus script

I'm getting following DeserialiseFailure when trying to resubmit a Tx with invalid Plutus script in Conway era:

cardano-cli: DecoderFailure (LocalTxSubmission (GenTx (HardForkBlock (': * ByronBlock (': * (ShelleyBlock (TPraos StandardCrypto) (ShelleyEra StandardCrypto)) (': * (ShelleyBlock (TPraos StandardCrypto) (AllegraEra StandardCrypto)) (': * (ShelleyBlock (TPraos StandardCrypto) (MaryEra StandardCrypto)) (': * (ShelleyBlock (TPraos StandardCrypto) (AlonzoEra StandardCrypto)) (': * (ShelleyBlock (Praos StandardCrypto) (BabbageEra StandardCrypto)) (': * (ShelleyBlock (Praos StandardCrypto) (ConwayEra StandardCrypto)) ('[] *)))))))))) (HardForkApplyTxErr (': * ByronBlock (': * (ShelleyBlock (TPraos StandardCrypto) (ShelleyEra StandardCrypto)) (': * (ShelleyBlock (TPraos StandardCrypto) (AllegraEra StandardCrypto)) (': * (ShelleyBlock (TPraos StandardCrypto) (MaryEra StandardCrypto)) (': * (ShelleyBlock (TPraos StandardCrypto) (AlonzoEra StandardCrypto)) (': * (ShelleyBlock (Praos StandardCrypto) (BabbageEra StandardCrypto)) (': * (ShelleyBlock (Praos StandardCrypto) (ConwayEra StandardCrypto)) ('[] *)))))))))) ServerAgency TokBusy) (DeserialiseFailure 68 "expected word")

I'm testing this with cardano-node / cardano-cli 8.9.0 release.
UPDATE: It is somehow related to return collateral. If collateral utxos have the precise collateral amount, then no return collateral txout is needed. In such case, resubmitting the tx leads to the expected BadInputsUTxO, instead of the unexpected DecoderFailure.
Steps to reproduce:

build

cardano-cli conway transaction build --tx-in "745f04573e7429be1404f9b936d208b81159f3fc4b30037b9d630187eec18756#0" --tx-in-script-file cardano_node_tests/tests/data/plutus/v1/always-fails.plutus --tx-in-datum-file cardano_node_tests/tests/data/plutus/typed-42.datum --tx-in-redeemer-file cardano_node_tests/tests/data/plutus/typed-42.redeemer --tx-in-collateral "745f04573e7429be1404f9b936d208b81159f3fc4b30037b9d630187eec18756#1" --tx-in "745f04573e7429be1404f9b936d208b81159f3fc4b30037b9d630187eec18756#2" --tx-out "addr_test1vr7l4ff9r60dyxr22thw5pdvr5ucxnhw7zdnuswuz52h0gqy8q9yn+2000000" --script-invalid --change-address addr_test1vrlfyrycpk7pzyaqrkcp2624g70nhy0kld49r0wqcwpurwgcmxy52 --out-file test_script_invalid_ci0_hmg_step2_tx.body --testnet-magic 42

sign

cardano-cli conway transaction sign --tx-body-file test_script_invalid_ci0_hmg_step2_tx.body --testnet-magic 42 --signing-key-file test_script_invalid_ci0_glp_payment_addr_0.skey --signing-key-file test_script_invalid_ci0_glp_payment_addr_1.skey --out-file test_script_invalid_ci0_hmg_step2_tx.signed

submit

cardano-cli conway transaction submit --testnet-magic 42 --tx-file test_script_invalid_ci0_hmg_step2_tx.signed --cardano-mode

resubmit to see if the tx made it to mempool. Expected behavior is to get BadInputsUTxO, but this time we get the DecoderFailure.

Files used in the test:
deserialize_failure.tar.gz

This is a dup of https://github.com/IntersectMBO/cardano-cli/issues/645

I tried to reproduce the decoder failure with the files you provided, but it seems to decode the transaction body just fine. Could this be a decoder failure from another component?

Yeah, I think it makes sense to report it to consensus and see if they can track it to ledger or if its something on their side.

Nice catch. This is a bug in deserialization of a predicate failure, not of a transaction.


feat: Support PMML & GraphDef & Caffe2 extract

What this PR does / why we need it:
Add your description
Which issue(s) this PR is related to (optional, link to 3rd issue(s)):
Fixes #
Reference to #

Special notes for your reviewer:
/cc @gaocegege

Release note:

NONE

/lgtm


Need a better selection list

Is your feature request related to a problem? Please describe.
It is very convenient to distribute the same files to different devices, but there are too many steps in the case of distributing different files to different devices.
For example, I need to send files 1, 2 and 3 to device A and 4, 5 and 6 to device B. Now the steps to go through are to drag and drop 123 into the list, select device A, then go to the edit list, click delete all, then drag and drop 456 into the list and click on device B.
Describe the solution you'd like
Make the selection bar easier to edit. For example, on the desktop side let user  click the right mouse button to delete the files in the selection. On the mobile side, tap twice to delete files.
Or give a checkbox near selection to decide if you want to keep the selection after sending all files.
Just check the box when you want to transfer files to multiple devices.
Describe alternatives you've considered
No response
Additional context
No response

Added send modes in v1.8.0


Can't access some branches in MiniAOD

I'm trying to read some branch
patMETs_slimmedMETs__PAT.obj.m_state.p4Polar_.Pt()
in MiniAOD, but uproot doesn't recognize it as a branch. If I do
event['patMETs_slimmedMETs__PAT.'].show()
it shows that the branch is not interpreted properly.
name                 | typename                 | interpretation
---------------------+--------------------------+-------------------------------
patMETs_slimmedMETs_ | edm::Wrapper<vector<pat: | AsGroup(<TBranchElement 'patMEpatMETs_slimmedME... | bool                     | AsDtype('bool')
patMETs_slimmedME... | unknown                  | <UnknownInterpretation 'non...
There are multiple other branches with the same problem, but I'm not sure what's causing it.

Have you tried to read the file with uproot4? The new version is highly recommended and can easily be installed e.g.  via pip install -U uproot.

Actually I'm using uproot4. Should move the issue.


Bug Report: timer is always on top during break time

Describe the bug
Timer is always on top of other windows, during break time. Even though, I disabled it.
To Reproduce
Steps to reproduce the behavior:

Toggle "always on top" to disable it;
Start break time;
Try to use computer, during break time;
It's barely possible. Timer window is always on top.

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: Fedora 32 Workstation
App Version: PRODUCTIVITY-TIMER-v3.0.0-linux.rpm

When Fullscreen Break is enabled by default.
The app will be set Always on top to true when break started.
It will make sense because if it will not be on top, users who want to discipline their selves will likely to continue to work even though it is time to take a break.
Even if you disabled Always on top featured but didn't disable Fullscreen Break it will forcefully be on top of other apps.
But after the break finished, the app will follow again the users settings.
It you did not like it, just disabled Fullscreen Break.


Added a condition for move_block_down_press on TetrisControl

Quick fix for bug: when paused, block could be moved down

black


Add a “octoprint” appearance option to widgets

The app can pull theme colors from octoprint.  It would be handy to push those colors to the widgets to improve identifying printers

Would be awesome. Also the current temperature, print Status, a quickprint-feature and maybe homing or leveling, depending on the size of the widget.


Corrected GetMullvadCountry param

Updated getMullvadCountry param to use MullvadCountryChoices constant instead of MullvadCityChoices
Should fix issue I'm currently running into testing the new mullvad image when launching with VPNSP to mullvad (and COUNTRY either set or not)

Found other issues while testing, going to submit another PR in a bit.

Thanks! Feel also free to just send me a list of bugs or Slack me (link is on the readme page at the top using a Slack badge) if you don't have the time to fiddle with the code.


Invocation name returns undefined when saying "Open [Skill Name]" in VSCode Alexa Skill Kit

Describe the bug

The skill works fine when tested in the console, but when I use the Alexa Skill Kit in VSCode and say something like "Open [Skill Name]," it only returns "undefined." I have downloaded the correct skill through "Download and edit skill" in Skills Management. Why is this happening?
To Reproduce

Go to the "Skills Management" section in the Alexa Skill Toolkit.
Click on "Download and edit skill" to download the correct skill.
Go to the "Test skill" section in the Alexa Skill Toolkit.
Type "Open [Skill Name]."

Extension Logs
[error - 2024-09-11 09:12:09.577Z] Simulation in progress.

Expected behavior
I expect the invocation name to be recognized and the skill to open as expected, without returning "undefined."

Desktop (please complete the following information):

OS:14.3.1
Visual Studio Code Version: 1.93.0
Alexa Skill Toolkit Version: v2.16.0

Additional context
Whether accessing the local Lambda using VSCode's debug or accessing the remote Lambda, it always returns "undefined" in the same way.

Resolved. Increasing the AWS Lambda memory fixed the issue.


Add Graph Settings

Taking over @sanderl's PR.
Description of the changes:

Add Graph Settings
Add GraphSettingsViewModel to simplify the UI part of the control and manage all the logic
Support error states (when minimum is higher than maximum)
Disable keyboard when the flyout is opened
Only load GraphSettings after the user clicks on the button to improve launch performance

How changes were validated:

Manually

Rebased!


Run cnn_face_detector on multiple GPUs

Sorry in advance if I have missed something, I am attempting to identify faces( And then recognise them ) using cnn_face_detector on multiple GPUs at a time using python bindings. I have not been able to find much about using multiple GPUs for classification. I am thinking that I should add some way to run cuda's set_device() function from python, separate my images up into batches for each GPU and use threading to run a cnn_face_detector for each GPU. Would this be the best way to do this?

Yes, you need to call set_device(), or cudaSetDevice() which is the same thing.  I just added a python interface for this in dlib.cuda.  So get the latest code and you can do it from python now.

Thanks!

No problem :)


Fix the segfault by initialising the Ptr (Ptr C'wasm_trap_t) with nullPtr

I award you not one, but two stars for this effort (because we deal with ptr_ptr).


Doc enbpi

Description
theoretical_description_regression.rst is enhanced with a theoretical description of EnbPI, that was missing
Fixes #(issue)
Type of change
Please remove options that are irrelevant.

documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Test A
[ ] Test B

Checklist

[x] I have read the contributing guidelines
[x] I have updated the HISTORY.rst and AUTHORS.rst files
[x] Linting passes successfully : make lint
[x] Typing passes successfully : make type-check
[x] Unit tests pass successfully : make tests
[x] Coverage is 100% : make coverage
[x] Documentation builds successfully : make doc

Codecov Report

Merging #180 (e217d9c) into master (e9dc954) will decrease coverage by 0.25%.
The diff coverage is n/a.

:exclamation: Current head e217d9c differs from pull request most recent head fce46df. Consider uploading reports for the commit fce46df to get more accurate results

@@             Coverage Diff             @@
##            master     #180      +/-   ##
===========================================
- Coverage   100.00%   99.74%   -0.26%
===========================================
  Files           22       22
  Lines         1989     1989
  Branches       218      157      -61
===========================================
- Hits          1989     1984       -5
- Misses           0        4       +4
- Partials         0        1       +1

Impacted Files
Coverage Δ

mapie/_compatibility.py
72.22% <0.00%> (-27.78%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9dc954...fce46df. Read the comment docs.


Bearer Authentication with request(options, callback)

Here is my code:
options = {
   'url': 'http://localhost:5000/data/v1/business',
   'json': true,
   'method': 'GET',
   'auth': { sendImmediately: true, bearer: '537ffbd1fcde5d13e6c084b0' } };

request(options, function(err, res) {
    ...
});

This is giving me
 Uncaught Error: auth() received invalid user or password

The documentation doesn't explicitly specify that you can pass a bearer token in with an options object, but if this isn't how you do it, then how?

Can someone show an example because this works for me:
// jwt token
const payload = {
        iss:  process.env.ZOOM_API_KEY,
        exp: ((new Date()).getTime() + 5000)
    };
let token = jwt.sign(payload, process.env.ZOOM_API_SECRET);

headers = { Authorization: "Bearer " + token };
let emitRequest = request.get(url);
emitRequest.headers = headers;
...

But this does not work
// jwt token
const payload = {
        iss:  process.env.ZOOM_API_KEY,
        exp: ((new Date()).getTime() + 5000)
    };
let token = jwt.sign(payload, process.env.ZOOM_API_SECRET);
// token = "Bearer " + token; // also is not working
let emitRequest = request.get(url);
emitRequest.auth(null, null, true, token);
...

I am facing the same problem. please specify what to upgrade.


Consider getting necessary changes into upstream arduino-playtune

I'm trying to recall why we needed to copy and hack the entire library to get it working on Arduboy?  The timers?  It seems (by default) on our chip playtune would want to use 2, 1, and 0.  We've hacked it to use 3 and 1 (which also conflicts with tone of course).
What is the reason this was necessary?  USB, SPI, something else?
I wonder if we can't either push a fix upstream or at least push some configurability upstream so we could just use the official library and at the same time tell it we only want to use timers 3 and 1.

Does anyone want to work on this or find out if they are even interested?

This could be moved to the new repository - closing for now.


Version 1.3.0 not available

Version 1.3.0 is not available neither from jcenter nor from plugins.gradle.org.
Maybe, if it has not been released yet, it would be better to add a few lines to the README.

The most recent version I see is 1.2.0.

This has been fixed now. When plugins.gradle.org switched to their own repositories, my plugins weren't automatically recognized.
1.3.0 and 1.3.1 should now be properly published.