✨[feature Request]: enhance the logo

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
I would like to propose an enhancement to the project's logo. The current logo could be updated to better reflect the project's identity and values, potentially incorporating modern design trends. This could include adjusting the color palette, typography, and overall composition to create a more visually appealing and recognizable logo.
Use Case
This feature would enhance my use of the project by providing a fresh and professional look that aligns with current branding standards. A modernized logo can create a stronger first impression for new users and help in branding efforts across various platforms, such as social media, documentation, and marketing materials.
Benefits
Implementing this feature would bring several advantages to the project and community:
Increased Recognition: A more professional logo can improve brand recognition and make the project stand out in a crowded space.
User Engagement: An attractive logo can attract more users and contributors, fostering a larger community.
Enhanced Professionalism: A modern logo reflects the project’s commitment to quality and innovation, enhancing its reputation.
Add ScreenShots

Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24EXTD contributor
[X] I have starred the repository

@Khushi-51 go ahead.


Attend/Decline for Event or just Join/Leave as for Group?

Currently vocab has Join/Leave for both Group and Event. Which can work together with Invite. It might make sense to define separate Attend/Decline.

Maybe gets used a lot but I've never really understood what it means. Surely one's intention should be to go or not to go. Maybe Maybe means I'd like to go but not sure if circumstances will allow it... ?

@dahacouk i just added maybe it to #5 :smile:

:-) Maybe it should actually be a probability of my attendance. Like 75% or 100% or 0%... ?

I like defining Attend/Decline separately from Join/Leave, as @elf-pavlik suggested.  Has a somewhat different meaning and is more like the language people would use.


Incompatible with VS 2017 Enterprise version

Hi there!
currentl when i tried to run the kinect2Sample code on the latest version of visual studio 2017, i am facing this incompatible issue.
I am currently running on windows 10.
Is there a fix to this incompatibility?
I have tried open as adminstrator, have also tried modifying the projectypeguids and other solutions online and they have yet to work.
Really looking forward to following your tutorial! :D

Hi, these labs were built for Windows 8.1 as stated on the tutorial page
The Hands On Labs to complete a sample application for Windows 8.1 and the Kinect 2 for Windows
For Windows 10 you should look at the latest Kinect documentation for UWP apps.

Is there kinect documentation for WPF as I'm currently working on a project to integrate gestures on a WPF project

https://developer.microsoft.com/en-us/windows/kinect
everything you need including the SDK and WPF samples.

Have already looked into that, but find it hard to implement discrete gesture.
Thanks for the quick responds!


Lighting devices throwing unsupported operand TypeError

Lighting devices in rev e0312c4 are throwing TypeError: unsupported operand type(s) for -: 'str' and 'int' during what I presume is instantiation.  In util.py:remap_value(), force-casting value to a float with float(value) resolves the issue.  I have not attempted to trace back why value is being passed to remap_value() as a string yet.

postfix_smartlife-36f301675e032815d116fe9ff06ad6b8-New Billy Office Strip-769436b8c0f681c48408b520dda924f4.json.txt
prefix_smartlife-36f301675e032815d116fe9ff06ad6b8-New Billy Office Strip-769436b8c0f681c48408b520dda924f4.json.txt
And since I took the time to rebreak it, here's the full stack trace:
Logger: homeassistant.loader
Source: loader.py:838
First occurred: 10:33:19 PM (15 occurrences)
Last logged: 10:33:19 PM
Unexpected exception importing platform custom_components.smartlife.number
Unexpected exception importing platform custom_components.smartlife.vacuum
Unexpected exception importing platform custom_components.smartlife.siren
Unexpected exception importing platform custom_components.smartlife.light
Unexpected exception importing platform custom_components.smartlife.switch

Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/loader.py", line 838, in get_platform
    cache[full_name] = self._import_platform(platform_name)
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/loader.py", line 855, in _import_platform
    return importlib.import_module(f"{self.pkg_path}.{platform_name}")
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1204, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1176, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1147, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 690, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 940, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/config/custom_components/smartlife/binary_sensor.py", line 20, in <module>
    from .base import SmartLifeEntity
  File "/config/custom_components/smartlife/base.py", line 17, in <module>
    from .util import remap_value
  File "/config/custom_components/smartlife/util.py", line 16
    return (value - from_min) / (from_max - from_min)) * (to_max - to_min) + to_min
                                                     ^
SyntaxError: unmatched ')'

https://github.com/tuya/tuya-smart-life/blob/main/custom_components/smartlife/util.py
return ((value - from_min) / (from_max - from_min)) * (to_max - to_min) + to_min
Checked the code and found no problem. Pull down the master branch and restart it

Fixed. Please download the smartlife plugin code again and integrate it again

Yep, that looks like it got it.
Thanks!


https://github.com/cloudcommunity/Free-Certifications/blob/main/.github%2FFUNDING.yml

Dolla bills ya?


How can I run webpack in my Camunda modeler?

hello @laurenzhinterholzer22, can you please describe what you want to achieve and whats the problem/error?

I am trying to run your project and you describe in your Camunda Modeler Plugin README.md to "Run webpack to build dist/client.js on the fly, when saving changes" (Step 4) but I don't know how to do that. Btw I am using MacOS

If you want to use the plugin within your Camunda Modeler, just perform step 1 to 5 - this will be enough.
If you want to do plugin development (make adjustments, enhancements or play around with the code), you need to a NodeJS 14.x installation, which includes npm. In your terminal, change into the camunda-modeler-plugin directory, install the required dependencies via npm install and run the webpack build via npm run dev. If you now change something in the code, webpack will automatically build the project for you. So that you just need to reload the Camunda Modeler (like described). This allows fast roundtrips for rapid development.
I will some more details to the README to make it more clear!

When I run nom run dev I get this error:
laurenzhinterholzer@MacBook-Pro-von-Laurenz bpmn-driven-testing-plugin % npm run dev

<EMAIL_ADDRESS>dev
dist/client.js

dist/client.js: line 1: syntax error near unexpected token function' dist/client.js: line 1: /******/ (function(modules) { // webpackBootstrap'

I have another problem:
Because I didn't manage to  automatically store the bpmns in the project I tried to copy the XML Code which was generated through selection of the test case in the plugin in Camunda. Copied the code into a .bpmn file and stored it in the project (maven-plugin/src/main/ressources). But when I run: "BPMN-driven-testing:generator I get a build failure:
[INFO] Found BPMN file: orderprocess.bpmn
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  2.980 s
[INFO] Finished at: 2021-11-25T17:48:34+01:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.camunda.community:bpmn-driven-testing-maven-plugin:0.3.0:generator (default-cli) on project bpmn-driven-testing-maven-plugin: Unexpected error occurred: SAXException while parsing input stream: Fatal Error: URI=null Line=1: Präfix "bpmn" für Element "bpmn:process" ist nicht gebunden. -> [Help 1]

Regarding your first problem: Do you want to use the plugin or do some plugin development? Did the error occur in your terminal or in the Camunda Modeler console/log output? Have you executed npm install before?
Regarding your second problem: It seems that your BPMN XML is not complete.
We can do a Google meet session if you want:
https://meet.google.com/src-zfjg-jnz


Set allow_open_expired = true by default in vsaio

This will facilitate test swift-integrity delete --dry-run to correctly detect unreaped/expired objects correctly by default.

That’ll be great if you can squash your two commits into one, since the second commit is just a change of the first commit

That’ll be great if you can squash your two commits into one, since the second commit is just a change of the first commit

Done.

LGTM


Is there a way or workaround to reach a perfect frequency, like 12 FPS?

All our animations are set up at 83 ms per frame in Aseprite. I would love for that to convert to 12 FPS. Is there a way or workaround to reach a frame length closer to 83.3333 ms?

Oh, I see. At the moment, the import to SpriteFrames always round the result up. It's like that because if I remember correctly when I first implemented this plugin the speed should be set as an int. I see now that float works just fine so maybe I can remove the rounding altogether.
In the meantime, if you want to test how this would look like in your local you can change the _calculate_fps method in /addons/AsepriteWizard/creators/sprite_frames/sprite_frames_creator.gd . Just remove the ceil call on line 164 and you should get a number closer to 12.
An alternative without changing the plugin is using a Sprite/AnimationPlayer instead, because those would use the value as-is without calculating the FPS and losing precision. However, I understand that's not a 1-1 swap as you will be dealing with one extra node.
I'll put some extra thought to confirm removing the rounding won't break anything else. I think it makes sense to release it as an option. Thanks.

Ah! I see what you mean. Thanks, I will try to change it locally for now and see what that does :)


Close our PS-4 POA&M by better documenting offboarding

Changes proposed in this pull request:
What needs timestamps
What to say in exit interview
security considerations
Yes, satisfy personnel termination requirements

I'll need @eddietejeda  or @RonWilliams  to approve since I'm putting more of this on them. Look OK?

@RonWilliams @eddietejeda  ping - is this PR okay by you?
@ccostino @bengerman13 I thought some of what we we're doing looked outdated. Turned out I had a PR in the wings.

Looks good.


Error Message "identical keys " after cloning

Hello,
I clicked "+Online",
entered the URL to our gitlab https://gitlab.isecnet.local/FA/m4s-main.git
entered the name of a package in the z namespace
left everything else as default (Branch = refs/heads/master   Folder logic = PREFIX)
After clicking OK i get the error messsage in the lower corner of the screen "identical keys", Message 00/0001,
Do you have an idea?
Thanks
Frank

Could you make a screenshot from Advanced > Database util page please?
It seems there is a missing db entry for an existing repo during runtime. But it shouldn't reappear if you restart abapGit, because then it loads the repos by the db entries again. Exists the problem after a restart of abapGit?

Restarting helped


Update JFOAAS to 1.0.0 equivalent of FOAAS.

FOAAS' update to 0.1.8 adds 6 new resources.

BTW: It's a nice library, I'm using it for the android app :D

Thank you for the kind words! I plan to update this eventually™. I will add code as needed to make all the extensions work.


Unable to disable shuttle selection in Map

Issue Description
You are unable to deselect a shuttle overlay on the map once one has been selected.
Steps to Reproduce / Code Snippets

Go to Map
Click Shuttle button
Make any selection
Try to disable a shuttle

Expected Results
There should be a way to turn off the shuttle overlay, either by reselecting the previously selected option or by selecting a "None" option.

@vvp002 Thank you for your work on this issue outlined here: https://github.com/vvp002/campus-mobile/commit/8d86df658dcf8e89961d8b0522cdd8cb62768fb5
@Gulci We would like to continue moving forward on this issue as a secondary priority item. Sending your way to work towards the completion of this task when time allows.

84db81a5 resolves this issue, and the user can now toggle a route by tapping on it again.

This issue is being closed due to platform migration and may be revisited at a later date.


Add more visibility metrics for Flow Aggregator

This commit adds antrea_agent_flow_collector_reconnection_count
Prometheus metrics to expose visibility of connection status
between Flow Exporter and flow collector. It also adds a
periodical log for checking Flow Aggregator's ingest rate,
throughput and connection status.
Signed-off-by: zyiou<EMAIL_ADDRESS>

Codecov Report

Merging #2668 (02f898d) into main (cf22420) will decrease coverage by 19.64%.
The diff coverage is 0.00%.

:exclamation: Current head 02f898d differs from pull request most recent head b2e934e. Consider uploading reports for the commit b2e934e to get more accurate results

@@             Coverage Diff             @@
##             main    #2668       +/-   ##
===========================================
- Coverage   60.72%   41.07%   -19.65%
===========================================
  Files         283      158      -125
  Lines       22839    19246     -3593
===========================================
- Hits        13868     7906     -5962
- Misses       7498    10591     +3093
+ Partials     1473      749      -724

Flag
Coverage Δ

kind-e2e-tests
?

unit-tests
41.07% <0.00%> (-0.03%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/agent/flowexporter/exporter/exporter.go
58.29% <0.00%> (-23.11%)
:arrow_down:

pkg/ovs/openflow/default.go
0.00% <0.00%> (-100.00%)
:arrow_down:

pkg/util/runtime/runtime.go
0.00% <0.00%> (-100.00%)
:arrow_down:

pkg/agent/cniserver/pod_configuration_linux.go
0.00% <0.00%> (-100.00%)
:arrow_down:

pkg/ovs/openflow/logs.go
9.52% <0.00%> (-90.48%)
:arrow_down:

pkg/apis/controlplane/register.go
0.00% <0.00%> (-90.00%)
:arrow_down:

pkg/agent/nodeportlocal/k8s/annotations.go
0.00% <0.00%> (-83.88%)
:arrow_down:

pkg/agent/agent_linux.go
0.00% <0.00%> (-80.00%)
:arrow_down:

pkg/agent/client.go
0.00% <0.00%> (-77.42%)
:arrow_down:

pkg/ovs/ovsconfig/ovs_client_linux.go
0.00% <0.00%> (-76.93%)
:arrow_down:

... and 232 more

I would prefer that we separate the addition of the new metric and the go-ipfix library upgrade in separate PRs

Created another PR for bumping go-ipfix version https://github.com/antrea-io/antrea/pull/2807. Thanks!

/test-all


Example of custom file loader config lack of documentation

Any help in how to implement log analysis for syslog?

Yes those steps have not been mentioned in the documentation. If you want your own custom file to get run for Log Summarization use Custom_YourFileName will bring that file in Log File filter for Log Summarization. For Anomaly Detection and Log Clustering I am also not sure and trying with trial and error to sort out the errors/exceptions.

@Prateek12333 Any updates or any resources found to learn more about Anomaly Detection and Log Clustering with custom logs.

@aadhineniganesh No updates and no learning resources found on Anomaly Detection and Log Clustering for now. Those algorithms are working because they have hardcoded values that are mentioned in examples for both algorithms. If we try our own custom file there is no sort of solution which we can implement for those algorithms . If anything comes up will let you know and bring up the solution here. But as per my RND work we can bring out custom file/logs for both the algorithms.

@aadhineniganesh No updates and no learning resources found on Anomaly Detection and Log Clustering for now. Those algorithms are working because they have hardcoded values(code that they have shared in GitHub link) in examples for both algorithms. If we try our own custom file there is no sort of solution which we can implement for those algorithms . If anything comes up will let you know and bring up the solution here. But as per my RND work we cannot bring out custom file/logs for both the algorithms.


[web]wasm crash issue

I tried to use the example in the project and compiled it with flutter build web --wasm, and then according to the flutter wasm documentation, used dhttpd '--headers=Cross-Origin-Embedder-Policy=credentialless;Cross-Origin-Opener-Policy=same-origin' to run the web. Then, any operation that calls up the camera will cause the page to freeze (crash).
My flutter version:
Flutter 3.22.3 • channel stable • https://github.com/flutter/flutter.git
Framework • revision b0850beeb2 (4 days ago) • 2024-07-16 21:43:41 -0700
Engine • revision 235db911ba
Tools • Dart 3.4.4 • DevTools 2.34.3

chrome version: 126.0.6478.183
mobile_scanner version: ^5.1.1
Maybe it’s related to skwasm.

Maybe it’s related to skwasm

I am aware that there are issues with the WASM version.
Do you have a stack trace for the crash? We also had issues with the positioning of the camera preview on web, when running on WASM.

stack trace

Sorry, I don't have a stack trace. But I found out that if you don't pull up the camera, the page will not crash. However, once the camera is called up (guessing the rendering interface), the page will crash and print in the console

And the camera will be turned on (Android phone camera prompt).
Through the Performance Monitor in Chrome's DevTools, you can see that the CPU usage is always at 100%.

I deployed the example to https://test.nazo.run, and perhaps the problem can be reproduced on all devices.

It seems there is an open report for a similar bug in SkWasm at https://github.com/flutter/flutter/issues/150119
Does this reproduce if you switch to the master channel?

It seems there is an open report for a similar bug in SkWasm at flutter/flutter#150119
Does this reproduce if you switch to the master channel?

I tried switching to the master channel.
The page still freezes. But there is no output in my console.

Sorry, I take back my previous answer.
Because I tried to use flutter clean, then flutter pub get and then flutter build web --wasm, which miraculously solved the crash. It seems that the problem lies with flutter?
version:
Flutter 3.24.0-1.0.pre.214 • channel master • https://github.com/flutter/flutter.git
Framework • revision c63733310f (2 days ago) • 2024-07-20 19:26:30 -0400
Engine • revision 207f088f73
Tools • Dart 3.6.0 (build 3.6.0-55.0.dev) • DevTools 2.37.1

The remaining problem is the problem of misalignment.


Too many requests error

Bug description
I've been trying to use aicommits for weeks but always get a 429 error
➜  test git:(main) ✗ aicommits
┌   aicommits
│
◇  Detected 1 staged file:
     abc
│
◒  The AI is analyzing your changes
│
└  ✖ OpenAI API Error: 429 - Too Many Requests

I've tried to use several api keys but nothing worked.
aicommits version
v1.3.0
Environment
System:
    OS: macOS 12.6
    CPU: (10) arm64 Apple M1 Max
    Memory: 448.98 MB / 64.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.17.1 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 9.4.0 - /opt/homebrew/bin/npm

Can you contribute a fix?

[ ] I’m interested in opening a pull request for this issue.

Your account is being rate limited:
https://help.openai.com/en/articles/6843909-rate-limits-and-429-too-many-requests-errors

Sorry, I don't know why. 🤷♂ All I can do is Google the error code for you.
You'll have to open a ticket with OpenAI to find our why you're getting that error.


Add support for Python 3.10.

I also added the missing classifiers for Python 3.9, as well as Python 3.10.

Merged, thanks!


Library wasn't working for me so I fixed some things

Also that may be not your fault and problem lies in https://github.com/PrismarineJS/mineflayer/issues/2030, but still there are some changes that you may find helpful

Did you test this

Did you test this

Yep, seems to work. Used that code for testing:
const mineflayer = require("mineflayer")
const autoeat = require("./index")
const bot = mineflayer.createBot({
    host: process.argv[2],
    port: process.argv[3],
    username: process.argv[4]
})
bot.loadPlugin(autoeat)
bot.once("spawn", () => {
    bot.autoEat.options.startAt = 20
    bot.autoEat.options.checkOnItemPickup = true
    bot.autoEat.options.ignoreInventoryCheck = true
})
bot.on("autoeat_started", (item) => {
    console.log(`Started eating ${item.displayName}`)
})
bot.on("autoeat_stopped", (err) => {
    console.log(`Stopped eating with error ${err}`)
})
bot.on("health", () => {
    console.log(`HP: ${bot.health} ST: ${bot.food}`);
    if (bot.food === 20) bot.autoEat.disable()
    else bot.autoEat.enable()
})

LGTM!


Over resource limits on Streamlit Cloud

Hey there :wave: Just wanted to let you know that your app on Streamlit Cloud deployed from this repo has gone over its resource limits. Access to the app is temporarily limited. Visit the app to see more details and possible solutions.

already fixed, thanks.


regex with alternation ("|") in patten causes crashes

Regex rules that contain a pipe character for doing regex alternation cause a crash. For example, I have the following rule to handle certain Zoom URLs:
rule = type:regex|.*zoom.us/(join|my|j).*
The problem appears to originate from https://github.com/aloneguid/bt/blob/master/bt/app/match_rule.cpp#L21 where the rule is split on "|" indiscriminately. The machine I'm on isn't set up for development, otherwise I would try to put a fix together. As a workaround, I've created multiple rules so this isn't urgent.

Oh thanks, it's 2023 and i still forge to escape strings. Back to the drawing board.

This seems to be fixed, scheduling for next release. If you'd like to test it early please download "bin" artifact from https://github.com/aloneguid/bt/actions/runs/7714781148

this is now released in 3.7.0


Rip out react from all non-dev flows

Removes react from all non-dev flows, and replaces it with (depending on context):

logger.log()
logger.table()
spinner() from @cloudflare/cli/interactive
select()

Tests

[ ] TODO (before merge)
[ ] Tests included
[x] Tests not necessary because: internal refactor—the existing tests passing should give confidence that nothing has broken

E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)

[ ] I don't know
[x] Required
[ ] Not required because:

Public documentation

[ ] TODO (before merge)
[ ] Cloudflare docs PR(s):
[x] Documentation not necessary because: internal refactor

Great stuff! Very close to removing react from all flows 🚀

PR on the way!

🎉


Add react event

I are trying to use GenericMessageReactionEvent and MessageReactionAddEvent but that give me a error and say to remove @Override note anyone can help?

The github issue tracker is reserved for feature requests and bug reports. Your issue is neither and should be sorted out inside of our discord server. Go to discord.gg/0hMr4ce0tIl3SLv5 to receive the needed help.


Produce tar.gz file for osx and linux package store

Resolves #48
Required for https://github.com/aspnet/aspnet-docker/issues/215

gah this is going to conflict with #67

@natemcmaster @JunTaoLuo Do we need to sit down and talk about how the folder structure look like across different archives and installers?

I trust @JunTaoLuo knows these details. I'm not familiar with folder structure expectations. This change is simply about converting a .zip to a .tar.gz so Docker install is possible.

I don't see why the folder structure would need to be different on different archives? Why do we have this concern? Also, this PR needs to be rebased but looks correct


Automated cherry pick of #3083: Fix NetworkPolicy resources dump for Agent's supportbundle

Cherry pick of #3083 on release-1.2.
#3083: Fix NetworkPolicy resources dump for Agent's supportbundle
For details on the cherry pick process, see the cherry pick requests page.

Codecov Report

Merging #3103 (d0d149f) into release-1.2 (12ae735) will increase coverage by 13.30%.
The diff coverage is 64.28%.

@@               Coverage Diff                @@
##           release-1.2    #3103       +/-   ##
================================================
+ Coverage        42.78%   56.08%   +13.30%
================================================
  Files              146      285      +139
  Lines            18312    22383     +4071
================================================
+ Hits              7834    12554     +4720
+ Misses            9779     8483     -1296
- Partials           699     1346      +647

Flag
Coverage Δ

kind-e2e-tests
38.80% <64.28%> (?)

unit-tests
42.74% <ø> (-0.04%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/apis/controlplane/v1beta2/marshal.go
0.00% <0.00%> (ø)

pkg/support/dump.go
63.85% <69.23%> (ø)

pkg/apiserver/certificate/certificate.go
69.86% <0.00%> (-6.85%)
:arrow_down:

pkg/apiserver/storage/ram/store.go
78.94% <0.00%> (ø)

pkg/apiserver/handlers/webhook/mutation_labels.go
24.71% <0.00%> (ø)

pkg/controller/metrics/prometheus.go
4.34% <0.00%> (ø)

.../listers/security/v1alpha1/clusternetworkpolicy.go
0.00% <0.00%> (ø)

pkg/apis/controlplane/v1beta2/helper.go
25.00% <0.00%> (ø)

.../typed/controlplane/v1beta1/controlplane_client.go
45.45% <0.00%> (ø)

...legacyclient/informers/externalversions/factory.go
56.00% <0.00%> (ø)

... and 221 more

/test-all


Explicitly use v3 bootstrap

For https://github.com/istio/istio/issues/19885

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
34af56113391ea6ee677a6d10386e1a659213c94
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
34af56113391ea6ee677a6d10386e1a659213c94
link
/test unit-tests_istio

integ-mixer-k8s-tests_istio
34af56113391ea6ee677a6d10386e1a659213c94
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
889047bfa51405e6a804c66d86b491abe7a42f3b
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
889047bfa51405e6a804c66d86b491abe7a42f3b
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-mixer-k8s-tests_istio

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
889047bfa51405e6a804c66d86b491abe7a42f3b
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest
On Thu, Jul 9, 2020 at 11:25 PM Istio Automation<EMAIL_ADDRESS>wrote:

@howardjohn https://github.com/howardjohn: The following test failed,
say /retest to rerun all failed tests:
Test name Commit Details Rerun command
integ-mixer-k8s-tests_istio 889047b
https://github.com/istio/istio/commit/889047bfa51405e6a804c66d86b491abe7a42f3b
link
https://prow.istio.io/view/gcs/istio-prow/pr-logs/pull/istio_istio/25327/integ-mixer-k8s-tests_istio/14154 /test
integ-mixer-k8s-tests_istio
Instructions for interacting with me using PR comments are available here
https://git.k8s.io/community/contributors/guide/pull-requests.md. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
https://github.com/kubernetes/test-infra/issues/new?title=Prow issue:
repository. I understand the commands that are listed here
https://go.k8s.io/bot-commands.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/25327#issuecomment-656506788, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXJMBQNWRYAUAY6Z3F3R22X5JANCNFSM4OUXGSDA
.

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
889047bfa51405e6a804c66d86b491abe7a42f3b
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Broken by mixer bootsrtap.. may just wait until 1.8


get build working with 1.5.1 as far back as 0.10.36

ok fixed it so it will now work in 0.8

judging by the shear number of errors in 0.6 I'm guessing this is how far back we've been supporting in node

yes, 0.6 is dead to readable-stream

@feross how far off browserify testability are we? any idea how we can confirm the current version works well enough with browserify?

the current version browserifies to 165k/42k zipped and after these changes its 166/42

ok just pushed up what may be a horrible hack but may be useful, basically we treat streams like Voldemort and avoid saying its name replacing require('stream'); with require('st' + 'ream'); I'd want to get @substack's opinion on this but the idea is that if stream has been required somewhere then the require should work and streams get imported but if they are not required anywhere else then the import fails.  Since the only reason we import streams is for use when people compare against streams (which they'd have to require) this change should be unobservable but shrinks the size

Which
Full
Uglified
Gzipped
Uglified and Gzipped

before
172213
94271
43520
21839

after
115985
67996
30023
16022

change
-32.65%
-27.87%
-31.01%
-26.64%

some other odds and ends include we have to replace Stream as superclass with event emitter, the actual requires need to be inside of try/catch blocks (which i put inside iife's just in case for performance reasons), plus I caught a bug that I missed earlier which is that in the browser you can't use if (!(chunk instanceof Buffer)) you need to use Buffer.isBuffer(chunk)

@iojs/streams comments?

@rvagg Last I looked into making the tests work in the browser was a while ago. I might be able to take another look soon.
@calvinmetcalf Good call on the Buffer.isBuffer vs. instanceof Buffer change. This is definitely required to test for buffers in the browser. Once Uint8Arrays become subclassable in ES6, we can make Buffer a proper subclass of Uint8Array and make instanceof Buffer start to work correctly while preserving performance in the browser! Tracking issue: https://github.com/feross/buffer/issues/40

@calvinmetcalf Also, thanks for thinking of bundle size! This is an issue near and dear to my heart. I've been traveling around NZ with 16KB/s mobile Wi-Fi speed and now viscerally appreciate the importance of small page weight.

ping @rvagg @isaacs or @TooTallNate (who have access to readable-streams on npm)  the if (!(chunk instanceof Buffer)) bug actually came up in nolanlawson/pouchdb-replication-stream#29 as streams from separate browserify bundles don't work together

@calvinmetcalf what's the action item here? does @iojs/streams believe that we're ready to cut a 3.0.0 release for npm using the current code? Should it be at a specific point? Maybe to coincide with<EMAIL_ADDRESS>

we are way overdue on cutting 3.0.0 as it corresponds to io.js 1.1 and 1.2
I'd love to get a :+1: from @chrisdickinson first but in general Id like to get this out sooner rather then latter.

though looks like 1.8.1 made some changes to process.nextTick which streams is going to include but aren't in browserify (yet defunctzombie/node-process#43) so we'd probably want to base 3.0.0 off of iojs 1.7.1

yeah this isn't going to work out of the box against older versions of browserify but does work with browserify 10 which has the updated process.nextTick shim

I've been holding off on this, waiting for a broader consensus from @iojs/streams that this is actually ready to cut as 3.0.0, I'm hesitant because it's a big deal

cutting a beta/prerelease and then retagging the current as latest might be a good step

published as io-stream in order for people to be able to test it https://www.npmjs.com/package/io-stream

io-stream is now updated with the streams from 2.0.2 so if people want to test it, it's there, I can setup a new pull to merge the changes in if that makes sense

closing in favor of #135


Absence of 'tanh()' operation in the computation of attention vector

Tanh() operation is missed in the computation of attention vector (https://github.com/tensorflow/tensorflow/blob/r1.7/tensorflow/contrib/seq2seq/python/ops/attention_wrapper.py), which is mentioned useful in the definition of Attetntion vector(https://www.tensorflow.org/tutorials/seq2seq).

This is fixed on the master branch with 0586c572.
The new attention_layer argument allows the use of an arbitrary layer to produce the attention vector. For example, to replicate the equation (3) from Background on the Attention Mechanism:
cell = tf.contrib.seq2seq.AttentionWrapper(
    cell,
    attention_mechanism,
    initial_cell_state=initial_cell_state,
    attention_layer=tf.layers.Dense(512, activation=tf.tanh, use_bias=False))

Thank you for your post. We noticed you have not filled out the following field in the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Thanks.
Have I written custom code
OS Platform and Distribution
TensorFlow installed from
TensorFlow version
Bazel version
CUDA/cuDNN version
GPU model and memory
Exact command to reproduce


SARAALERT-1262: Support Vaccines in the API

This adds a SaraAlertImmunization profile which gives the rules for reading/writing of Vaccines via the API.
Corresponding implementation: https://github.com/SaraAlert/SaraAlert/pull/797.

@holmesie and @tstrass, no big rush since we don't need this merged and deployed until we release 1.28.0, but just re-tagging you for awareness. I think we should get at least one second pair of eyes on this.


Out of bounds increment on iterator

I am currently using the single header file of CTRE at commit d71fca4c622a12c2cf85a2361e8fe7ff50a11976
Following simple code causes an iterator to be incremented past the end iterator of the string_view I am using:
#include "ctre.hpp"

constexpr static auto pattern = ctll::fixed_string{R"(\{\})"};

#include <iostream>

int main()
{
    const auto* text = "Stray '{}' in program";
    std::string_view sv = text;
    for (auto& iter : ctre::range<pattern>(sv))
    {
        std::cout << iter.view() << std::endl;
    }
}

This causes a runtime exception when using the Debug STL of MSVC or the debug containers of libstdc++ with following code:
#include "ctre.hpp"

constexpr static auto pattern = ctll::fixed_string{R"(\{\})"};

#include <iostream>
#include <string>
#include <debug/string>

int main()
{
    const auto* text = "Stray '{}' in program";
    __gnu_debug::string s = text;
    for (auto& iter : ctre::range<pattern>(s))
    {
        std::cout << iter.view() << std::endl;
    }
}

Using each code samples above I chased it back to this line of code:
https://github.com/hanickadot/compile-time-regular-expressions/blob/d71fca4c622a12c2cf85a2361e8fe7ff50a11976/single-header/ctre.hpp#L3175-L3183
As you can see it increments although end might be equal to current. Hope this helps!
Thank you for your great work

Thank you very much for very nice bug report, I was able to fix issue, unfortunately I wasn't able to came with a test to trigger compilation failure (as most of my tests are constexpr). Fixed in 509b646b3b16b4ed48b9420acd0e2c06204b2d0f.
Please confirm it's working for you.

Yes that worked thank you very much!


Add ext2exp to the instruction set

Currently the VM supports these native operations on quadratic extensions:

ext2add
ext2sub
ext2mul
ext2div
ext2neg
ext2inv

Exponentiation can be computed with the above, but it would be nice to have native support.

I would actually prefer to avoid this. I'm assuming this request is motivated by the AirScript MASM backend. If so, there we should probably just have a sub-routing which translates all exponentiations to multiplications (Could even be an "optimization" pass on the IR). This shouldn't be too difficult to do as we usually deal with fairly low exponents (e.g., 7 is the highest one we have in Miden VM constraints).


exposeAll: public API?

exposeAll is currently undocumented. Is it supposed to be part of the public API?

And if it's supposed to be public, is it supposed to expose "entry" files?

It should probably be documented.

@substack Ok, thanks. I will leave this issue open until it's documented (at least minimally). I'll probably do it eventually unless someone else volunteers.


Moving stuff back into 1.3

Signed-off-by: keithhc2<EMAIL_ADDRESS>By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@lizsnyder @alicejw-aws It seems that I merged the Data Prepper docs into the wrong version/branch with my previous PR, so this branch adds the Data Prepper 1.4 docs back into the "latest" version of the docs site.


Update offline.zh.md

What type of PR is this?

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

/lgtm


Allow vhosts to serve both http and https.

I needed this for testing a site that handled both http and https.

+1 for this kind of feature

+1 : this seems like it is a must have unless there is another way to avoid having 100% of your traffic be routed through HTTPS.

PR #298 seems to have a more complete solution.

#298 has been merged, this PR can be closed.


How can i obtain the attentional weights of feature interaction in Autoㅑnt?

Describe the question(问题描述)
A clear and concise description of what the question is.
I solved the problem about AFM's weight thanks to your docs.
but i don't know the same problem about AutoInt
this is my codes
[1] model = AutoInt(linear_feature_columns,dnn_feature_columns)
[2] model.compile("adam", 'binary_crossentropy',metrics=['binary_crossentropy'])
[3] model.fit(train_model_input,train[target].values)
I got the following error in the [1]
TypeError: int() argument must be a string, a bytes-like object or a number, not 'list'
linear_feature_columns and dnn_feature_columns work well in afm code.
i wonder about getting weights using AutoInt
'''
afmlayer = model.layers[-3]
afm_weight_model = Model(model.input,outputs=Lambda(lambda x:afmlayer.normalized_att_score)(model.input))
attentional_weights = afm_weight_model.predict(test_model_input,batch_size=4096)
fixlen_names = get_fixlen_feature_names( dnn_feature_columns)
varlen_names = get_varlen_feature_names(dnn_feature_columns)
feature_interactions = list(itertools.combinations(fixlen_names+varlen_names ,2))
'''
and the following codes works well in AutoInt right??

hi @heemokyim ,the error in the[1] is because the parameter list of AutoInt does not accept linear_feature_columns,you can see the full parameter list of AutoInt here
Https://deepctr-doc.readthedocs.io/en/latest/deepctr.models.autoint.html
And I'm  afraid that the the codes of getting the attentional weights of feature interactions in AFM may not  work well in AutoInt


[API] (ALL) Return an error when fetching API key

The function fetchAPIKey also needs to return an err along with a string because there can be errors when the syscall cannot open the file due to some permission issue.
The rewritten function would be:
// fetchAPIKey returns the API key from the cred/civo file store
func fetchAPIKey() (err, string) {

	file, err := os.ReadFile(util.GetPathCIVO(0))
	if err != nil {
		return err, ""
	}
	if len(file) == 0 {
		return errors.New("Len of file is zero"), ""
	}

	return nil, strings.Split(string(file), " ")[1]
}

I would like to work on this good first issue
@dipankardas011 could you tell me here we should return an error message with errors.New() in
err!=nil section along with "" as it is??

You can use fmt.errorf
As the entire repo uses this only

You can use fmt.errorf As the entire repo uses this only

ooh you mean fmt.errorf() instead of errors.New() in err!=nil section??

@dipankardas011 assign me this !

yes

@bishal7679 just wait till the current #59 gets merged as it is blocking this issue

@bishal7679 just wait till the current #59 gets merged as it is blocking this issue

okay!

@bishal7679 do check #6

@lavakush07 you can raise up PR for this

Hey!! Can I take this one up if no one is working on it right now?

I think @lavakush07 is working on this

Stale


[CI:DOCS]more apiv2 development

misc population of methods, etc
Signed-off-by: baude<EMAIL_ADDRESS>

rebased and fixed up


how does olm find a newer operator version, then trigger a automatic upgrade?

Type of question
implement a specific feature
Question
What did you do?
how does olm find a newer operator version from registry server, then trigger a automatic upgrade?
I can't find the source codes about the logic.

checking if subscriptions need update : https://github.com/operator-framework/operator-lifecycle-manager/blob/master/pkg/controller/operators/catalog/operator.go#L908

Regularly pull the operator registry server content, discover new versions, and then start automatic updates

Namespace sync for resolving subscriptions


Fix t2 push default slimPath so app start finds it

When doing a slim build, the resulting script should be laid down as index.js so that when /app/start does its exec node . there is an index.js in place.  This is the simplest solution to attempt to resolve #458

Thanks for the patch! I've landed it already, which I realize I shouldn't have done yet, because I hadn't confirmed that you've signed the CLA! If you could do that for me, I'd appreciate it: http://dojofoundation.org/about/claForm

CLA done.

:clap: Thanks @jonathana!

@HipsterBrown @rwaldron Is there any reason for keeping the slimPath at all? What purpose does it server? Won't any other value than index.js make it undeployable. I think that we should drop this option.

+1

@LinusU in the latest version /app/start is templated and has the value written in.  See #461.

That's nice, but my questions are still valid. Why is it even needed in the first place?

It might not be, I can explore after I'm done with binary modules


[$2000] iOS app - Attachment - User can't see PDF preview before uploading

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open the New Expensify Beta app
Sign into a valid user account (High Traffic or Low)
Navigate to any conversation
Tap on the "Plus" signal
Tap on "Add Attachment"
Tap on "Choose Document" and select any PDF document

Expected Result:
The user expects to be able to see the preview of the PDF before uploading
Actual Result:
The user is not able to see the preview of his/her PDF. The document loads as a grey page and can only be seen within the chat history after being sent.
Workaround:
Unknow
Platform:

Where is this issue occurring?

iOS

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/156287922-c4d722cb-cc66-4545-9641-862724a6ea09.mp4
Bug5475042_PDF_that_can_t_be_seen.pdf
Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:
View all open jobs on GitHub

Triggered auto assignment to @TomatoToaster (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Triggered auto assignment to @Christinadobrzyn (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

looks like it might be related to this GH - https://github.com/Expensify/App/issues/7365 - that is closed.

Created Upwork Job
Internal posting - https://www.upwork.com/ab/applicants/1499594733421305856/job-details
External posting - https://www.upwork.com/jobs/~0109a0f58059e7df27

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)

Triggered auto assignment to @roryabraham (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Price increase $500!

Hi, I just reproduced this bug and found the root cause.
It is to do with the file name. I tried uploading a PDF with a space in its name, and it didn't show me a preview. (case in point, first video).
This is because of the sourceURL that is given to PDFViewer (https://github.com/Expensify/App/blob/c26e41573c6b6ea91abef85afc173ba6ecc4cd2c/src/components/PDFView/index.native.js#L34-L37): file:///.../sample%20file.pdf
And there is an error loading the file with that URL. We will need to find a way to replace that %20 into a space, like this: /sample file.pdf.
This can be as easy as replacing props.sourceURL using: props.sourceURL.replace("%20", " ") for iOS.
The second video shows my solution works.
https://user-images.githubusercontent.com/19339044/157864011-5066df6f-0477-4d01-b194-52d866c29f32.mp4
https://user-images.githubusercontent.com/19339044/157864384-1544d25d-bc8e-4992-8531-4b5468f699be.mov

Nice catch @barun1997. Could you please use decodeURIComponent for this purpose?
I like @barun1997's proposal. Let's go with it.
cc: @roryabraham
:ribbon: :eyes: :ribbon:  C+ reviewed

@parasharrajat yup will do!

Hi guys, should I start working on this?

Did you get a chance to look at the Contribution.md guidelines? Maybe that helps. In short, you will be assigned to this issue before you can start. Also hired on Upwork.

Thanks for the investigation @barun1997, your proposal looks good to me 👍

📣 @barun1997 You have been assigned to this job by @roryabraham!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖

Hired @barun1997 in Upwork for the fix and @parasharrajat as the C+

Opened a PR for this!

I suggest a different approach. The actual does not require any important code changes in the upstream repo. It would be a difficult task to manage a fork. We can apply the solution using a wrapper as we are doing on the PR. So we wait as suggested and then merge the PR. Leaving a comment on the wrapper that it needs to be removed, once upstream has the fix.

Okay, I'm fine with that too 👍

Great. Thanks.

@roryabraham @parasharrajat are we going ahead with the PR itself? If yes, please feel free to review it, and let me know!

Last I heard, @parasharrajat had concluded that this is a bug in react-native-pdf. Is that correct?
Judging by the number of open issues in that repo, and that they are only pushing a few commits per month, I don't think it makes sense to wait for the maintainer to fix the issue. So the next step would be to debug on iOS and see if we can fix the bug in react-native-pdf, then point this repo at a fork.

Looking at the code, it seems that on Android it parses the file path but not on ios which is the whole issue. I may be wrong about it(due to native code). But I think this is the case.

I'm not very familiar with Apple's Objective-C APIs either, but it looks to me like @parasharrajat is correct. On iOS, it's constructing an NSURL object with the fileURLWithPath constructor. However, according to these resources you need to escape spaces from a string URL before creating an NSURL object:

https://stackoverflow.com/questions/1441106/nsdata-nsurl-url-with-space-having-problem
https://developer.apple.com/forums/thread/22954

And there are a few solutions floating in there, but the one that seems most relevant for Objective-C is stringByAddingPercentEncodingWithAllowedCharacters:
- NSURL *fileURL = [NSURL fileURLWithPath:_path];
+ NSURL *fileURL = [NSURL fileURLWithPath: [_path stringByAddingPercentEncodingWithAllowedCharacters:[NSCharacterSet URLQueryAllowedCharacterSet]]];

Not sure about the syntax there without testing, but you get the idea.

I'm going to be ooo until April 26th so I'm going to assign a new CM to this issue. Thanks!

Thanks, @roryabraham. Looking into it! cc @parasharrajat

That solution didn’t solve it - so I am looking for an alternative solution.

any updates on this?

Is this still being worked on? We haven't had an update in over two weeks.

@roryabraham or @parasharrajat do you have any thoughts about how we should handle this?

This bug isn't urgent, so imo we should hold out for a fix in the upstream rather than using a workaround in E/App. @barun1997 if you don't feel up to the task because you're not acquainted with native code, then we can unassign you and pay you out for the JS-level fix you provided so far and open this back up to other contributors.
@barun1997 did manage to identify the cause of the issue too, so I feel good with that plan 👍

I agree with the option to reopen this to others for fixing the native issue.

so to clarify, are we paying this out, and closing it, then opening a new issue?

@parasharrajat ok, that's all set

@roryabraham Thank you! Sorry I couldn’t find time to fix it with native code. Appreciate the positive feedback!

unassigning myself since i'll be OOO for a week

@grvsood You mentioned that preview will be shown in our app. But lib says that it opens the document natively. How will the preview be shown in-app.
You said that you have tested it so would you mind sharing the screenshots.

Check the attached video, the app is not switched in iOS. and I am able to preview the  file that contains a space in the name.
I know the app crashed, but as I said, I just tested that I am able to preview a attachment selected. I need to configure new changes to ensure backward compatibility.
https://user-images.githubusercontent.com/26037206/170505116-701c26f5-af16-4270-9392-bd7ddcc42174.mov

My question was You mentioned that preview will be shown in our app. But lib says that it opens the document natively. How will the preview be shown in-app? Am I missing something?

Got your concern. Will look into this.

Proposals
I have submitted a PR in react-native-pdf library to fix this i.e. to decode the path string for iOS as it does for Android already. Refer: here
Alternatively, for any reason if we fail to merge above PR, on our end we can also fix this by:

either using decodeURIComponent(props.sourceURL.replace(/\+/g, ' '));  to decode the file paths in PDFViewer component before calling react-native-pdf  for iOS
or we look to change the type of uri we are passing to react-native-pdf . For example: to read the file as base64 string and pass that to the react-native-pdf. All supported URI formats are defined here here

Since as of now, react-native-document-picker provides inbuilt support for windows only to get file content as base64, last option will require more tweaks in our app to handle it for iOS and Android. Hence first two options seems better.

Thanks @grvsood. You have already submitted the upstream PR so let's wait for some review on that.

Does it make sense to to create a fork in E/App that we can show that the PR works to hopefully get it merged in react-native-pdf?

What do you think @roryabraham?

Let's give the maintainer of react-native-pdf a bit more time. Next week if there's still no movement in the upstream PR we can create an Expensify fork per the process we're refining in this doc.
Sound good?

@roryabraham how are we looking this week?

@kadiealexander No update on the PR.

Thanks Rajat! That's frustrating. Should we get started on this?

Next week if there's still no movement in the upstream PR we can create an Expensify fork per the process we're refining in this doc.

Let's wait for Rory, he will update us on the next step.

Okay, thanks for your patience everyone. We're still discussing the next steps for this internally.

Okay, so I just tested https://github.com/wonday/react-native-pdf/pull/655 using https://github.com/ds300/patch-package, and although I was able to confirm with logs that the updated code is being executed, it doesn't seem to resolve the issue. @grvsood can you please test the pull request in this app using patch-package or your own fork of react-native-pdf and see if it's working for you?

@grvsood any updates here? :)

@grvsood I'm sorry, but I'm not sure I understand your question.
I tested your fix using https://github.com/ds300/patch-package instead of using a fork, so I didn't upgrade to the latest version. I just made the few changes in node_modules and created a patch. But maybe updating to the latest code is necessary?
Those require cycles look like the might be red herrings to me, because the cycle is entirely in the node_modules/rn-fetch-blob directory and doesn't actually deal with any of our code, as far as I can tell.

ERROR  Invariant Violation: Module AppRegistry is not a registered callable module (calling runApplication). A frequent cause of the error is that the application entry file path is incorrect. This can also happen when the JS bundle is corrupt or there is an early initialization error when loading React Native

I don't know for sure, but this error makes me think that there's some issue with the way you're trying to build from the fork. It's possible there are some steps where we would need to build the fork from source. Is there any documentation of this in the react-native-pdf repo?

Ok, so @grvsood's PR is merged upstream. But before we hire them, it is important to see if that solves our problem.
The next step would be @grvsood to create a proposal here indicating that your fix solves the issue in our app.
It may include:

Forking the repo and upgrading the version of the repo in a branch and sharing that with us for testing.

Or suggesting the changes that you will do in your PR to solve the issue on our repo.

When the above details are provided, I will review the proposal and do the needful.

Working on fixing the rendering issue.

Sorry, you may have misunderstood my comment. Please share the proposal here first so that we can hire you. After you are hired, then you are allowed to send a PR. If you meant the same then please ignore this comment.

Discussing here.

@grvsood I was able to upgrade the app to latest<EMAIL_ADDRESS>I didn't face any issue.

Changed version of react-native-pdf: ^6.5.0
Removed rn-fetch-blob.
Installed react-native-blob-util:^0.13.7
Replace all the imports of rn-fetch-blob with react-native-blob-util.

Am I missing something? BTW, your changes are still not deployed to npm on react-native-pdf. We may have to request the maintainer to release a minor version.

Ok, I tested the code changes and it does not fix the issue.
Open for proposals...

Price doubled, and the old post expired:
https://www.upwork.com/jobs/~01227280ef0f6f8c45
https://www.upwork.com/ab/applicants/1547473595666264064/job-details

Proposal

in IOS, there is an issue in react-native-pdf for files which has space
this is because of sourceURL
https://github.com/Expensify/App/blob/ce899227ca6d3823e2865a5e194b429f1263db30/src/components/PDFView/index.native.js#L35-L42
We can use  decodeURIComponent
source={{uri: decodeURIComponent(props.sourceURL)}}
when react-native-pdf comes with a solution we can update the package in future
You can check the video which shows solution is working
https://user-images.githubusercontent.com/54790231/178946730-a4f118d3-a28f-4ef2-be9c-e714e6f76c8a.mp4

@MananGadhiyaSureshbhai please take a look at previous discussion to understand what kind of proposals we are expecting.

Not overdue, seeking proposals!

 _path = (__bridge_transfer NSString *)CFURLCreateStringByReplacingPercentEscapes(NULL, (CFStringRef)_path, CFSTR(""));
we can add the above line in RCTPdfView.m . it works for me
https://github.com/wonday/react-native-pdf/blob/cc0bee98606edeb401ed2e238132d12f252f3e5c/ios/RCTPdf/RCTPdfView.m#L120
https://user-images.githubusercontent.com/54790231/180731514-84e3b6b7-142c-418a-abc7-dedf68ba3a83.mp4

Proposal
As the problem is well understood. We can fix it on the javascript layer in react-native-pdf.
https://github.com/wonday/react-native-pdf/blob/cc0bee98606edeb401ed2e238132d12f252f3e5c/index.js#L163
-                let uri = source.uri || '';
+                let uri = decodeURIComponent(source.uri) || '';

Result:
https://user-images.githubusercontent.com/77761491/180747702-106978a1-f876-4df9-a5c1-6e3e34e63a6d.mov

Maybe, we can apply this change only for ios and for file protocol. Because, other platform does not have any issue.

@kbecciv @parasharrajat I am not able to reproduce this issue on latest codebase of main branch
https://user-images.githubusercontent.com/108141252/180825469-5afb3409-3b2a-492c-bfef-aee07de9c7b6.mov
If anyone still faces this issue, it would be good to share test details:
pdf file, iPhone model, iOS version

Nvm, I found the case. I renamed file name to have space and now able to reproduce :)

https://github.com/Expensify/App/blob/0a3a42581649d27a5e8d5f37bebddc57b89999da/src/components/PDFView/index.native.js#L37
It works fine after updating this code to
            source={{uri: decodeURI(props.sourceURL)}}

@parasharrajat please try again with this approach and if issue still exists, please share your tested pdf and filename

https://github.com/Expensify/App/blob/712ca243a4c0b4101fb8e3c9da5aeac7132e153c/src/pages/ReimbursementAccount/ReimbursementAccountForm.js#L15
Add this line:
import withKeyboardState from '../../components/withKeyboardState';

https://github.com/Expensify/App/blob/712ca243a4c0b4101fb8e3c9da5aeac7132e153c/src/pages/ReimbursementAccount/ReimbursementAccountForm.js#L74
Add this line:
    withKeyboardState,

https://github.com/Expensify/App/blob/712ca243a4c0b4101fb8e3c9da5aeac7132e153c/src/pages/ReimbursementAccount/ReimbursementAccountForm.js#L49
Add this line:
contentInset={{bottom: this.props.isShown ? 48 : 0}}

And this fix is not only for this issue bot throughout the app which show native keyboard for input:
https://github.com/Expensify/App/blob/712ca243a4c0b4101fb8e3c9da5aeac7132e153c/src/components/ScreenWrapper.js#L136
                            <KeyboardAvoidingView style={[styles.w100, styles.h100]} behavior={this.props.keyboardAvoidingViewBehavior} enabled={Platform.OS === 'ios'}>

Before fix
iOS:
https://user-images.githubusercontent.com/108141252/180840335-f5706288-6c10-4f6e-b2f9-1844165a19f7.mp4
Android:
https://user-images.githubusercontent.com/108141252/180840383-1aa01639-7d6e-4abc-a360-a8b75b61ab9d.mp4
After fix
iOS:
https://user-images.githubusercontent.com/108141252/180840479-57ea7ff7-1ee2-41f1-b358-4d072eadaa90.mp4
Android:
https://user-images.githubusercontent.com/108141252/180840558-e51c48b9-d8a0-48ef-a0d6-2ef94243a8dd.mp4

@MananGadhiyaSureshbhai How did you test it? I am getting error while using the latest code on react-native-pdf.

@parasharrajat we need to add this code and use patch-package for it

You mean that you applied the changes to the currently installed version on react-native-pdf in our app.

@parasharrajat  yes we need to change react-native-pdf which was currently installed

Thanks for the confirmation. We want to make these changes upstream. By upstream, the fix should be merged in the package repo. Which we will install in our app.
Though, your solution looks promising. Please feel free to submit the PR on the upstream repo and we can see if it is accepted.

do you want me to raise PR in react-native-pdf?

To be considered a solution for this issue.

You PR should be merged upstream.
It Should solve the issue in pur app after upgrading the package.
If 1,2 is a pass, you will have to share a proposal here of the migration plan to the new lib which should not break anything in our app.
Once the plan is approved, you will be hired and then you will have to submit a PR in our app to successfully upgrade the version without breaking anything.

1-3 is must to be considered an accepted solution for this issue.

PR created : https://github.com/wonday/react-native-pdf/pull/672

We've had a lot of activity in this issue over the last few days. It looks like we're waiting to see if https://github.com/wonday/react-native-pdf/pull/672 is accepted in the upstream, so it could be a little while. @parasharrajat Did we test this upstream fix in NewDot at all to know if it solves our problem?

Yup, I did and it is working.

@parasharrajat  pr(https://github.com/wonday/react-native-pdf/pull/672) merged and new version of react-native-pdf realsed

You know what you need to do next https://github.com/Expensify/App/issues/7962#issuecomment-1195657161.

@react-native/normalize-color

Why is this needed?
Did you check the app on Android and iOS?

with the latest version of react-native-pdf getting error regarding @react-native/normalize-color
I think it is because deprecated-react-native-prop-types lib which is included  in the new version

@react-native/normalize-color

Why is this needed?
Did you check the app on Android and iOS?

After upgrading the package
Android  :
https://user-images.githubusercontent.com/54790231/182129042-65b4abcd-1405-44ea-a4b5-8f1bd27da827.mov
IOS :
https://user-images.githubusercontent.com/54790231/182129089-da0053ea-d03c-41c7-8a2e-40785cc9b448.mp4

@react-native/normalize-color

Shouldn't this be installed with deprecated-react-native-prop-types?

@parasharrajat I just removed @react-native/normalize-color and reinstall all packages. this time I am not getting any error so there is no need for @react-native/normalize-color .

Perfect.

@parasharrajat  @roryabraham changes already implemented in this PR

is there anything that I have to do?

We can add the necessary QA steps to https://github.com/Expensify/App/pull/9841

Added QA steps in there and asked Applause to post the results in here. cc @Expensify/applauseleads

@roryabraham Hey! Can you point us to the QA steps that are mentioned above?
We checked #9841, do you need us to retests https://github.com/Expensify/App/issues/7962 once that PR is deployed?

Hi, yes, your understanding is correct. Once https://github.com/Expensify/App/pull/9841 is deployed, retest this issue.

Retest looks Pass
https://utest-dl.s3.amazonaws.com/testRunStepMinAttachmentsResult/23601335/IMG_9B54389DF338-1.jpeg?AWSAccessKeyId=AKIAJ2UIWMJ2OMC3UCQQ&Expires=1692375078&Signature=17Wm%2F7F5wwDGDGbs0oVBXE9r7Tg%3D
https://utest-dl.s3.amazonaws.com/testRunStepMinAttachmentsResult/23601335/IMG_2880.PNG?AWSAccessKeyId=AKIAJ2UIWMJ2OMC3UCQQ&Expires=1692375078&Signature=qdzTXep7%2FEjJszEs8U9QP9FFs1E%3D

PR looks resolved

Issue not reproducible during KI retests. (First week)

Applied on upwork @kadiealexander

Thanks @gadhiyamanan! Payment will be made after the PR is deployed to production and the regression period is finished.

ok. i think PR is deployed to production and right now regression period is going on, correct me if I am wrong.
cc: @roryabraham @kadiealexander

@gadhiyamanan, could you please link me to the PR? There are quite a few in the hundreds of messages in this issue so I'd like to make sure it's the right one.

PR https://github.com/Expensify/App/pull/9841
cc: @roryabraham @kadiealexander

Thank you! The PR is not yet deployed to staging or production because QA is still happening as per this comment:

@kadiealexander  the PR is mentioned in Deploy Checklist

@kadiealexander I think PR deployed as per list

Issue not reproducible during KI retests. (Second week)

https://www.upwork.com/ab/applicants/1499594733421305856/job-details
https://www.upwork.com/jobs/~0109a0f58059e7df27
@gadhiyamanan @parasharrajat please accept the contract I just sent and I'll get this paid out for you both :)

@kadiealexander accepted.

@kadiealexander ping for upwork

Payment was made yesterday, is there an issue?

@kadiealexander i think you send me only offer, can you check ?

Strange, for me it is showing that the contracts were ended by you both. I'll reissue a new contract now and once you've accepted I'll issue payment. Sorry for the confusion here!

@parasharrajat - all paid, thank you!
@gadhiyamanan  - please accept the contract at your earliest convenience :)

@kadiealexander accepted

@kadiealexander ping por upwork

Thanks @gadhiyamanan, I think everyone is paid and all contracts are ended. Please let me know if there's anything outstanding!

Thank You :)


Autocomplete[1]: Operator Transform To Output Schema

Implement transformToOutputSchema for all operators
Add Constant String as Error Message
Remove Magic String from Predicate

I just made a minor change about which exception to throw for Predicate constructors. Avinash and I have approved this PR. Good job 👍


Update usage details

closes #22 and #23
Details

What I did - Update readme file
How to test - n/a
Does this change require an update to the documentation? - n/a

Include answers to these questions and any other relevant details

@TylersDesk and @davekenison ... let me know if the copy can be better!


Can't install

I get the following error when running composer install
concrete5/concrete5 dev-master requires concrete5/flysystem 0.4.* -> no matching package found.

I can confirm that. I'm getting "concrete5/concrete5 <IP_ADDRESS> requires concrete5/flysystem 0.4.* -> no matching package found", too.


Which features do you cover ?

Hello,
To be curious, which feature do you cover with your api version ?
Do you cover :

the web vault
The import tool
the collection/team
folders relationship

I've tried to understand your code, but i'm not familiar with Go.
One more question :

Do you check each parameters sent to avoid SQL injection ?
How do you manager user session ? Cookie ?

Implemented

web vault
import tool (Only ciphers)
Folders

Not Implemented

collection/team

User sessions is handled the same way as the core server (JWT)

Thanks

One more question :
Do you check each parameter to avoid sql injection attacks ?

No guaranties, but I've tested on the "unauthorized" endpoints and could not exploit it.


Removed warning in install you instance images

@v-samarth : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Docs Build status updates of commit f1296e2:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-community-training/infrastructure-management/install-your-platform-instance/configure-login-social-work-school-account.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Optional fields for get and query

This PR aims to clear up communication around what data users get back when using .get and .query
Specifically this issue: https://docs.trychroma.com/troubleshooting#using-get-or-query-embeddings-say-none
This PR updates get and query to only send back the fields you request. To add extra communication, we pass back a new field called included_fields that tells you what was included. This is added because we have defaults that a user may not be familiar with.

If we like this direction: I will continue on and add tests for it and make sure it operates well with the JS client.
NOTE: I expect tests to fail right now!

Offline discussion with @atroyn - this is not the approach we want so closing this out.


db: correct broken tooth's spawn time

Tested to be 8 hours (tamed yesterday) instead of the default 5.

Which server was this tested on?

Turtle


podman: 5.2.3 -> 5.3.0

Updating podman to 5.3.0 mainly due to https://github.com/containers/podman/issues/23712 which fixes compatibility with some Docker API.
Additionally, one of the patches must be updated due to https://github.com/containers/podman/commit/9febd2c27ad6708f1b49326ab00758e499a66617.
This is my first PR in nixpkgs, please bear with me.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

--------- Report for 'x86_64-linux' ---------
7 packages built:
ansible-navigator ansible-navigator.dist apx apx-gui out-of-tree podman podman.man
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 356754

x86_64-linux

:white_check_mark: 7 packages built:

ansible-navigator
ansible-navigator.dist
apx
apx-gui
out-of-tree
podman
podman.man

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 356754

x86_64-linux

:white_check_mark: 7 packages built:

ansible-navigator
ansible-navigator.dist
apx
apx-gui
out-of-tree
podman
podman.man

aarch64-linux

:white_check_mark: 7 packages built:

ansible-navigator
ansible-navigator.dist
apx
apx-gui
out-of-tree
podman
podman.man

x86_64-darwin

:fast_forward: 1 package marked as broken and skipped:

apx

:white_check_mark: 5 packages built:

ansible-navigator
ansible-navigator.dist
out-of-tree
podman
podman.man

aarch64-darwin

:fast_forward: 1 package marked as broken and skipped:

apx

:white_check_mark: 5 packages built:

ansible-navigator
ansible-navigator.dist
out-of-tree
podman
podman.man


Exit code based on coverage percentage

Coverage tools for some other languages allow exiting with a non-0 exit code in case a certain type of coverage is below a specified minimum. For example:

python has: coverage report --fail-under=100 (statement coverage)

nodejs has: nyc report --statements 100 (statement coverage, also has other types of coverage)

The motivation for these flags is that they typically have some good way to exclude non-interesting code and then they can require good coverage for the rest of the code.
It seems to me that cargo-llvm-cov has no such feature and probably it would not be too complex to add one. Would a patch implementing this be accepted, after the usual review?
I think the closest in cargo-llvm-cov terms would be line coverage, perhaps something like:
cargo llvm-cov --fail-under-lines 100
could be a syntax to request non-0 exit code when line coverage is not 100%?
Thanks.

Sounds good to me! I would accept a PR to support this.

I looked into this briefly, just to realize that the current summary is not produced by
cargo-llvm-cov itself, but by the underlying llvm-cov report, which doesn't seem to have an option
to fail under a certain coverage. I naively assumed that llvm-cov already deals with percentages and
this issue is a matter of reflecting that percentage in the exit status code. :-)
One way to do this could be to add a parser for the JSON output of llvm-cov, but
https://clang.llvm.org/docs/SourceBasedCodeCoverage.html doesn't really document the format, so this
might involve a bit of llvm-cov source code reading (at least the format is not trivial to my eyes).
An other way could be to export to lcov, then lcov --summary t.lcov --fail-under-lines 100 can
provide this feature. And then perhaps document this in cargo-llvm-cov or just claim this is not in
scope for the project after all.
Third option is to first add something like this to llvm-cov and once that's accepted, then
cargo-llvm-cov could just pass this option. This may be the most painful, given how much time it may
take till the patch is accepted + it reaches the rust-provided llvm-cov.
Do you have a preference between 1), 2) and 3)?

We have a tool for testing that parses JSON output, so using that is probably the easiest way to go.
https://github.com/taiki-e/cargo-llvm-cov/blob/0798e99594fba80abb2f27d9ef2ae2910679b77d/tests/auxiliary/json.rs#L109-L122

Once the above PR is in, the actual percentage check can be added. I have a first cut of that at https://github.com/vmiklos/cargo-llvm-cov/commits/fail-under-lines2. I imagine it's easier to review these as two separate PRs, but in case that's not the case, then let me know.


Support for modular translations

This is a work-in-progress PR for the sake of discussion.

Thank you for this PR, I refactored it and published it on the new v 1.16 version.
It works well to sync JSON files from different paths.


Capture Mousewheel scroll on drag to adjust Elevation

Possibly capture mouse wheel on drag which would increment/decrement the Elevation of the token so the overall distanced covered included the height change + horizontal distance.
Alternative would be to capture chosen key presses to increment/decrement elevation during drag?

I developed a module, Elevation Ruler, that adds the ability of the default Foundry measurement ruler to increment or decrement elevation. I am still testing, but it has basic functionality. I went with hotkeys (default '[' and ']') for the elevation change. In theory, one could use the scroll wheel, but for some setups (such as trackpads) it tends to interfere with expected use of the scroll wheel function. Anyway, let me know what you think!
I will look into what it would take to integrate with Drag Ruler and Terrain Ruler. Because these modules modify the underlying measurement function, a bit of work would be necessary.

Having keybinds for destination elevation would be very useful for anything 3D (flying diving). System speedproviders (like PF2E) could then implement their own movement costs for (upwards) movement.


SPIRVProducerPass refactor - phase1.1

cache current Module

Related to issue google#545

@alan-baker here it is..

Can we turn off compile error on unused variable for windows or turn it on everywhere?

I'll look into the option changes.


DepthwiseConvolution supported

Does this engine support DepthwiseConvolution layer?

Dear kanyon17, does this closed thread answer your questions ?
Depthwise Conv thread

Yes, Thx


partial support for parsing pg 9.4

A future PR will add support for parsing new bulk insert xlogrecords

:fu:


Screen width switch bug

When trying the demo page it works fine on mobile until you switch between views. You have to refresh the page in order to being able to swipe again. This also happens when resizing the screen in responsive mode using your regular browser.

@marthesselink hi, that is because i store the window.innerWidth as a viewport variable so that when a screen is zoomed on mobile or touch device swiping left or right does not jump to next or previous image in the zoomed mode. And when it zooms out to its default width the swipe to next or previous starts working. When the view has is changed from vertical to horizontal the new window.innerWidth does not equals with the viewport anymore thus resulting in no swipe to next/previous. if i remove this functionality zooming will either not be possible or very buggy and when you slide a zoomed image to view other parts of the image,, it instead will jump to next/previous images. An alternative could be to switch on the next previous buttons when the new window.innerWidth is not equal to viewport. Since I myself is in the process of learning JS, I will try to provide a working solution for this problem as i learn more. Thanks a lot for your input.
You can read the code regarding touch at the following link from line 295
https://github.com/ahmednooor/halkaBox.js/blob/master/src/halkaBox.js

halkaBox.zip
@marthesselink  please see the attached zip and use the JS file inside and check if it resolves the issue.
Thanks.

@marthesselink  Please check the new url below and let me know if the bug has been fixed. thanks.
https://ahmednooor.github.io/halkaBox.js/testing/

It's working great right now. Nice fix!

@marthesselink  thanks a lot. and thank you for your input :)


[QUESTION] 1.3.1-release page display disorder after compilation

*1.3.1-release page display disorder after compilation *
Describe the question
Using 1.3.1-release to compile, 1. The graphic scale of the front page is disordered; 2. Each time the component is pushed in the canvas in the workflow definition, the prompt text of the component name does not disappear and always exists.
Which version of DolphinScheduler:
-[1.3.1-release]

[QUESTION] 1.3.1-release 编译之后页面显示错乱问题
Describe the question
使用1.3.1-release编译，1.首页图形比例展示错乱 2.工作流定义中画布里每次推动组件，组件名提示文字不消失，一直存在。
Which version of DolphinScheduler:
-[1.3.1-release]

@break60

What browser do you use, it is recommended to use Google
Does the console report an error?

What browser do you use, it is recommended to use Google
Does the console report an error?

When using Safari, there will be a problem with the date being displayed abnormally. And then Google Chrome will be normal.

What you answered is inconsistent with the issue you mentioned, what happened to your page mess, and your dag display problem

What you answered is inconsistent with the issue you mentioned, what happened to your page mess, and your dag display problem

This problem was encountered by Author , and I did not meet the problem in Issue.
If it's a browser problem, the date of this version is not normal in safari.

What browser do you use, it is recommended to use Google
Does the console report an error?

1.I'm using the Google browser
2.he console did not report an error

What you answered is inconsistent with the issue you mentioned, what happened to your page mess, and your dag display problem

This problem was encountered by Author , and I did not meet the problem in Issue.
If it's a browser problem, the date of this version is not normal in safari.

Only Google compatibility is currently considered

What browser do you use, it is recommended to use Google
Does the console report an error?

@break60
1.I'm using the Google browser
2.The console did not report an error

Let me take a look at your screenshot, you seem to have made a second transformation of it yourself

What you answered is inconsistent with the issue you mentioned, what happened to your page mess, and your dag display problem

This problem was encountered by Author , and I did not meet the problem in Issue.
If it's a browser problem, the date of this version is not normal in safari.

Only Google compatibility is currently considered

I got the answer. This is my solution now also. thanks!

What browser do you use, it is recommended to use Google
Does the console report an error?

@break60
1.I'm using the Google browser
2.The console did not report an error

Let me take a look at your screenshot, you seem to have made a second transformation of it yourself

Just a new plug-in, I don't think it will affect the home page

I also don’t know what code you changed, you can restore it and take a look, or pull a new dev code to try

Pull on a new branch, same problem，
1.3.1-release

Pull on a new branch, same problem，
1.3.1-release

Hi,
There is http response code 304 in your http request in screenshot. Can you try to clear you Chrome cache and refresh this page ？

Pull on a new branch, same problem，
1.3.1-release

Hi,
There is http response code 304 in your http request in screenshot. Can you try to clear you Chrome cache and refresh this page ？

This is not a caching problem for him. It must be no problem at the beginning, and then he corrected the problem himself


support specifying page-size on dashboard startup

closes: #54

What

Add a cli param to specify the page size of the experiment table so it's more flexible based on user perference

How to Test

Try different page sizes

rubicon ui --help
Usage: rubicon ui [OPTIONS]

  Launch the Rubicon Dashboard.

Options:
  --root-dir TEXT           The absolute path to the top level folder holding
                            the Rubicon project(s).  [required]

  -ps, --page-size INTEGER  The number of rows that will be displayed on a
                            page within the experiment table.

  -h, --host TEXT           The host to serve the dashboard on.
  -p, --port TEXT           The port to serve the dashboard on.
  -d, --debug BOOLEAN       Whether or not to run in debug mode.
  --help                    Show this message and exit.

looks great! only thing is entering less than 1 for page size has some interesting results. we should just check to make sure the value of page-size is greater than 0

@ryanSoley good call, updated 💯


SSL Error when using Django extenions' runserver_plus

Python Version
3.10.8
Django Version
4.1.3
Package Version
No response
Browser
Chromium: Version 107.0.5304.87 (Official Build) Arch Linux (64-bit)
Description
Hi Adam,
Thanks for this awesome and helpful tool.
A problem come when I use it with the runserver_plus:
python manage.py runserver_plus localhost:8000 --cert-file certs/localhost.crt --key-file certs/localhost.key --nostatic --settings=config.settings.dev

It shows:
<IP_ADDRESS> - - [03/Nov/2022 13:18:13] "GET /static/debug_toolbar/js/utils.js HTTP/1.1" 304 -
Error on request:
Traceback (most recent call last):
  File "/home/me/.local/share/virtualenvs/django-starter-xnFyc4Yx/lib/python3.10/site-packages/werkzeug/serving.py", line 335, in run_wsgi
    execute(self.server.app)
  File "/home/me/.local/share/virtualenvs/django-starter-xnFyc4Yx/lib/python3.10/site-packages/werkzeug/serving.py", line 325, in execute
    write(data)
  File "/home/me/.local/share/virtualenvs/django-starter-xnFyc4Yx/lib/python3.10/site-packages/werkzeug/serving.py", line 298, in write
    self.wfile.write(b"\r\n")
  File "/usr/lib/python3.10/socketserver.py", line 826, in write
    self._sock.sendall(b)
  File "/usr/lib/python3.10/ssl.py", line 1237, in sendall
    v = self.send(byte_view[count:])
  File "/usr/lib/python3.10/ssl.py", line 1206, in send
    return self._sslobj.write(data)
ssl.SSLEOFError: EOF occurred in violation of protocol (_ssl.c:2396)

When I remove the django_browser_reload from the INSTALLED_APPS, the problem disappear.

Django version: 4.1.3
Python version: 3.10.8 (main, Oct 13 2022, 21:13:48) [GCC 12.2.0] [x86_64-Linux-5.15.76-1-MANJARO]

This bug must be in the SSL implementation in werkzeug, or the way djagno-extensions uses it. It’s probably just triggered by django-browser-reload’s use of a streaming HTTP response, which is a little rare but perfectly allowed.
(I recommmend against using django-extensions, it's unfortunately not very well maintained.)


alt-browser fallback to "browser" for browserification of dependencies?

this is a question. If A depends on B, and their package.json's look like:
A:
    {
      ...
      "chromeapp": {
        "dgram": "chrome-dgram"
      },
      "dependencies": {
        "B": "^1.0.0"
      }
      ...
    }

B:
    {
      ...
      "browser": {
        "url": "./browser-url.js"
      }
      ...
    }

when you issue:
    browserify --browser chromeapp A/main.js

should browserify fall back to the "browser" field when it browserifies B and needs to resolve "url" but doesn't find a "chromeapp" field? It seems like in most cases this would be desirable. What do you think?

Good question. What is the current behavior? No fallback? Silent failure? Loud failure?

the current behavior is that it'll look for "chromeapp" in the nested dependency (where only "browser" exists), not find it, and resolve to whatever file/module gets used in the regular node.js environment. So basically it ends up handing you non-browserified deps

fixed in v1.9.0
Thanks!

cool, thx for merging


Add --with-systemd-timeoutstartsec configure option

cupsd can be killed by systemd if the daemon takes too much time when
starting - f.e. when loading many queues and/or not enough memory for
loading the daemon quicker.
TimeoutStartSec directive for systemd services defines the time after
which the daemon is killed - if set to 'infinity', a service is not
killed.

Note:
I'm planning to do 2.4.0 release once this PR and #294 are reviewed...


practicePullRequest

Practicing creation of a new branch + pushing files to branch + creating a PR and merging.

practiceMerge


fix #765, improve the graph type inference so we don't need to set templ...

...ate argument type explicitly.

+1.


[IOTDB-3736] Remove DELETED status for TsFileResource

See IOTDB-3736.

Coverage decreased (-0.002%) to 45.395% when pulling 0ff70b4b9a99acf77d05c5b09d795f6143ea3b9f on IOTDB-3736 into 8fea934fd72d4f88726e3cd990faaef0648c8ca6 on master.


[Bug]: Issue templates are broken

What happened?
I cannot leave a suggestion because the link leads to https://github.com/coolsam/signature-pad/discussions/new?category=ideas
How to reproduce the bug
click on issues --> new issue --> request a feature
Package Version
1.2.0
PHP Version
82.20
Laravel Version
10.32.1
Which operating systems does with happen with?
macOS, Windows, Linux
Notes
No response

Yeah, was gonna ask if it's possible to publish the view in order to modify it but it seems like discussions are disabled even tho they're in the templates


Steaming API - updating filters/follows

Have been using the Stream API to follow a number of users - no problems at all yet, so thanks guys! Also integrated very nicely with the REST API which allows me to back-populate data.
My question is around how to update a follow subscription. This is for the case where a new id is added to the database and so I need to add an additional follow to the stream subscription.
I guess it may be possible to just POST again to the twitter endpoint - but not 100% sure how I'd do that with the API (and whether it would work ok).
I'm working in a rails environment - and running the subscriber on a dedicated resque queue - so I could create a new stream client and then terminate the old one - but seems a bit ugly - plus might miss some data during the switch over.
Any thoughts or advice?

Hi @stve and @sferik ! This would be really useful to me as well. I'm working in an application where I need to track a set of keywords and send each of them through a separate queue. I ended up implementing it with threads, but just killing them when I no longer need them doesn't look like a clean solution.
AFAIK this was easier with tweeetstream as it used EventMachine and you could easily "talk" with the connection. Since now this is implemented in a blocking manner it will be difficult to close the connection from outside.
Is there anything I'm missing? Can I do something to help?

Oh, I just saw the discussion on: https://github.com/sferik/twitter/pull/631#issuecomment-78160920. Amazing work.

@stve what is currently the best way to close an existing stream and reconnect with a different set of filters?


Does it support nested traps?

I didn't see it in the demo and from looking at the code it looks like there is a single var called trap to track the current trap (https://github.com/davidtheclark/focus-trap/blob/master/index.js)
If not, I can probably add that feature.
Very nicely done.

Can you describe more what you envision? I'm not immediately understanding what behavior you'd like to change.

I have a main view and I'd like to trap focus on that to prevent tab from tabbing into the page header that I can't add tabindex to all of the a tags of.  From that main view I have several dialogs that may have a trap on them.
I try to avoid modal dialogs launched from other modal dialogs, but a frequent need is to display a confirmation dialog / message box on clicking save from a modal.  In that scenario it would be preferable to trap focus in the confirmation while it's displayed.  And it would be preferable to not close the dialog until confirmation is received, so that when the user clicks cancel from the confirmation, the dialog is still there with all of their inputs.

On Mar 6, 2016, at 7:25 PM, David Clark<EMAIL_ADDRESS>wrote:
Can you describe more what you envision? I'm not immediately understanding what behavior you'd like to change.
—
Reply to this email directly or view it on GitHub.

Have you tried this out, and it doesn't work? I'm asking because it might. The code for focus-trap that you looked at means that only one focus trap can be active at a time, but you can still create several on a page, and I don't know why they couldn't be nested within each other. That said, if you do try or have tried and it's not working, I agree that this should be possible and we'll have to fix it.

This should work as of v3, because it works for focus-trap v2. Let me know if it doesn't.


Upgrading Laravel 5.5 to 5.6 gives error on PackageManifest.php

Laravel Version: 5.6.*
PHP Version: 7.4

Description:
Upgrading steps by steps until Laravel version-8. Gives the error in PackageManifest.php.
I wonder how GitHub file of Laravel https://github.com/laravel/framework/blob/5.6/src/Illuminate/Foundation/PackageManifest.php
is different than composer installed file "laravel/framework": "5.6.*" on local machine.
Steps To Reproduce:
Tried solution for updating as found on Stackoverflow:
changing files as shown, https://github.com/laravel/framework/commit/65a555105f7812e87888245c8123cad027bf88df
leads to
\vendor\laravel\framework\src\Illuminate\Container\Container.php:826
822|
823|             // If the class is null, it means the dependency is a string or some other
824|             // primitive type which we can not resolve since it is not a class and
825|             // we will just bomb out with an error since we have no-where to go.

826|             $results[] = is_null($dependency->getClass())
827|                             ? $this->resolvePrimitive($dependency)
828|                             : $this->resolveClass($dependency);
829|         }

1   ReflectionParameter::getClass()
C:\xampp\htdocs\root\betengine\vendor\laravel\framework\src\Illuminate\Container\Container.php:826
2   Illuminate\Container\Container::resolveDependencies()
C:\xampp\htdocs\root\betengine\vendor\laravel\framework\src\Illuminate\Container\Container.php:795
Also Tried:
Composer dump-autoload
downgrading composer versions
It won't work.
Any help is appreciated.

Laravel version 5.6 is not supported anymore.
As such,o I think it is better seek for help on the support channels:
https://laravel.com/docs/9.x/contributions#support-questions
Out of my head, the only thing I can suggest is to check if you are using composer v2 or v1. Probably it doesn't work with v2.
$ composer self-update --1

But I guess you already tried that.
Another tip, as you seem to want to upgrade to a more recent version afterwards is to look at Laravel Shift service. It is a paid service, from a third party, that automates most upgrading changes needed.
Good Luck!

@rodrigopedra
Thankyou for your response.


Delay after clicking Save button and actual save needs some kind of loading indicator

Steps

Go to staging.osf.io
Go to one of your account settings
Change any field in your Profile Information
Click the Save button
Notice the delay between clicking Save and the green "Settings updated" text appearing

Expected behavior
I expected that while there's a delay between clicking Save and actually saving, I would get some indication that my changes were being processed, such as the Save button's text changing into a lighter color "Saving" button until the "Settings updated" message appeared below.
For example, the Add button in the New wiki page modal changes to "Creating New Wiki page" before the page is successfully created.

In project settings, the link to connect/import an account changes to a grayed out "Loading..." message before the account is successfully imported.

Actual behavior

Since there's a delay before the "Settings updated" message appears, the user may think the changes were successful and try to leave the page before they are actually processed.

@nanchen47 can I get on this?

Done!

Closed


New style icon for Alert

This is how a Alert for permissions looks currently:

need to update style icon 🔐 with a new one
Environment

Host OS: Mac Linux Windows
Platform: Docker or Kubernetes
Meshery Server Version: stable-v
Meshery Client Version: stable-v

Contributor Guides and Resources

🛠 Meshery Build & Release Strategy
📚 Instructions for contributing to documentation

Meshery documentation site and source

🎨 Wireframes and designs for Layer5 site in Figma (open invite)
🙋🏾🙋🏼 Questions: Layer5 Discussion Forum and Layer5 Community Slack

Does this work? @iArchitSharma

looks good to me, can you push it

Push it? As in raise a PR?