Proposed updates to ProjectScaffold

Proposed updates to ProjectScaffold
I have some changes in my personal fork I can submit to the master branch here. I'll propose a thumbs up/down vote on each.
I have no experience with dotnet templates, and so no opinion about whether this project is suitable to convert, or if any of my changes are compatible.

Dotnet SDK projects.
I multi-target the main library project to net45;net47;netstandard2.0.
And I have added a console project I multi-target to net47;netcoreapp2.0
Test project is targeted to net47

Drop NUnit and make the test project Expecto tests.
Includes some simple/random FsCheck generators, (maybe not the best examples in the world.)
(Ideally making NUnit or Expecto an option in the initialization would be nice, but that's more work than I am interested in doing.)

Additional console app using Argu lib.
I also stubbed-out the common way I parse commands using Argu. In truth I threw together this generalized parsing in a hurry from some existing projects, so I don't guarantee all the parsing works perfectly out of the box, but it is close.

All solution files accessible from within solution IDE.
Why open the solution in VS IDE and not have access to files like .gitignore, appveyor.yml, build.cmd, etc?

Latest FSharp.Formatting prerelease.
If you haven't noticed, the release version of FSharp.Formatting has lots of problems.

My personalized prelude file in the library project.
https://github.com/jackfoxy/ProjectScaffold/blob/master/src/FSharp.ProjectTemplate/Prelude.fs

Dotnet SDK projects
thumbs up/down

Drop NUnit and make the test project Expecto tests
thumbs up/down

Additional console app using Argu lib
thumbs up/down

All solution files accessible from within solution IDE
thumbs up/down

Latest FSharp.Formatting prerelease
thumbs up/down

My personalized prelude file in the library project
thumbs up/down

If we went with SDK template road some of those decisions may be done by users, with parameters. In particular it would make sense for those ideas (from above list) - additional console app, type of test framework, custom prelude

If someone wants to do the work to turn this project into a SDK template, I would accept the PR.

I'm curious to hear the reason(s) for down-voting making all files available from within the solution?

Here's what seems to be trending favorably. I'll try to get this in on the weekend, if the trends hold.
Dotnet SDK projects
Drop NUnit and make the test project Expecto tests
Additional console app using Argu lib
All solution files accessible from within solution IDE
Latest FSharp.Formatting prerelease

I have pushed a beta branch https://github.com/fsprojects/ProjectScaffold/tree/betanetstandard for community testing with the following changes:
Dotnet SDK projects
Drop NUnit and make the test project Expecto tests
Additional console app using Argu lib
All solution files accessible from within solution IDE
Latest FSharp.Formatting prerelease
I also made a couple of changes to paket.dependencies:

eliminate separate paket groups
I have found groups problematic in the past. The scaffold project is simple enough that it does not require groups, IMO. If anyone wants to submit a PR putting groups back in, I would accept it.

paket framework autodetect
I believe this is the best default option for most projects.

I will merge early in the workweek, pending feedback.

@jackfoxy I guess we should update fake as well to 5

@matthid yes, that and dotnet cli template are good next steps
I will open an issue for fake 5

PR merged https://github.com/fsprojects/ProjectScaffold/pull/326


Macro examples in documentation do not compile

I wish I could be more helpful than reporting that the macro examples in the documentation do not compile (neither in the nearley playground nor with nearleyc 2.11.0 in the Terminal), but I'm only just trying to learn about macros in nearley.
For some reason the compiler is saying Error: Unknown macro: ____, even though it is clearly defined in the grammar.
Errors
In the playground

With nearleyc 2.11.0

Hey @fauxneticien — thanks for the report! At some point, I must have absentmindedly rewritten those examples and forgotten to check if they still compile.
The issue is that macros must be defined before usage. This lets you shadow them if needed, and enforces some sanity when you have multiple @imported grammars (I learned this the hard way!). So, moving the main -> lines in the examples to the bottom of the file lets them compile just fine.
$ cat - | pbcopy
# Matches "'Hello?' 'Hello?' 'Hello?'"
matchThree[X] -> $X " " $X " " $X
inQuotes[X] -> "'" $X "'"

main -> matchThree[inQuotes["Hello?"]]

$ nearley-test -q -i "'Hello?' 'Hello?' 'Hello?'" <(nearleyc <(pbpaste))
[ [ [ [ [ '\'', [ 'Hello?' ], '\'' ] ],
      ' ',
      [ [ '\'', [ 'Hello?' ], '\'' ] ],
      ' ',
      [ [ '\'', [ 'Hello?' ], '\'' ] ] ] ] ]

I fixed this in the docs via d29b5a1. Sorry about that. Maybe we need tests for our docs, now! Meanwhile, please let me know if you have any other issues.
P.S. I just realized how clever your username was. :-)


How to set user props?

Summary
Hi, how do we set/update user properties using this lib?
It seems like it only has logEvent(), flush() and getOptions() methods - is it possible to update user props at all using this library?
If not, could you point in the right direction on how to accomplish it from server side?

Hi @arthabus ,
Apologies. You can still identify users by sending $identify events (and there's a pull request we plan on attending to post-thanksgiving to make it easier to interface with it) - if you send events that follow the event format in our docs
For example:
nodeClient.logEvent({
  event_type: '$identify',
  user_id: 'YOUR_USER_ID',
  device_id: 'YOUR_DEVICE_ID',
  user_properties: {
    $set: { source: 'email' }
  }
})

perfect, thanks @kelvin-lu!

Request to add this to the docs!

Request to add this to the docs!

great callout! we'll try to get this out soon

great callout! we'll try to get this out soon


Get all the entities that have been autodeleted missing name of subcription (and topic)

In the documentation is an example of how to get all entities that have been autodeleted by the service bus. The problem that I have is: how can I get the name/id of the entity that was deleted. Because the value _ResourceId contains always the id of the namespace.
So the column _ResourceId has everywhere a value like this:
/subscriptions/<subscription-id>/resourcegroups/<resource-group>/providers/microsoft.servicebus/namespaces/<namespace>
With this information I don't know which entity it was, from the EventName_s column I can only conclude that it was e.g. a subscription which was auto deleted, but which subscription I can not found out.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: de229227-d333-0ebc-87a4-a64a13ff909a
Version Independent ID: 2ab4f0dc-318f-32f3-0afa-a314b0744ddf
Content: Monitoring Azure Service Bus - Azure Service Bus
Content Source: articles/service-bus-messaging/monitor-service-bus.md
Service: service-bus-messaging
GitHub Login: @spelluru
Microsoft Alias: spelluru

Thanks for the question! We will review and get back to you shortly.

You are correct that the specific name of the topic/subscription/queue that was auto deleted is currently not captured in the logs. If you need more direct information and control of this process, your best option would be to utilize something like a Logic App or Function to monitor how long items have been inactive and deactivate them when needed. That entity can then capture data about what it deleted.

@SamaraSoucy-MSFT Thank you for that clarification. I do not want to control deletion process myself with an additional application. I just want to find out, in case of issues with some applications using the servicebus, what and when something was autodeleted. From your response I conclude that the logs might include in the future the information about the deleted entity?

I do want to acknowledge that the common answer of doing custom logging isn't as viable in this particular case- the whole point of the feature is that it is handled entirely within Service Bus. Unfortunately that the best option I currently have for you if you need the name of the deleted item. I have reached out to the product team to see if they are planning any updates that I can share with you.

@dldldlepl since there are no doc updates required I do need to close the issue for now- I am still working on getting an update from the product team on whether or not there are any planned schema updates. I will update you with anything I can share, and you can still @ me on this thread if you have any additional follow up.


Add an unconditonnal end-of-ClientHello callback

Suggested enhancement
Add a new callback that's called unconditionally at the end of the ClientHello, once all the extensions have been parsed (or equivalently, just before we start preparing the ServerHello).
Justification
Mbed TLS needs this because sometimes the server needs to adjust its behaviour based on multiple extensions, so per-extension callback (such as the existing SNI callback) are not enough. An example is servers who want to support the ACME "tls-alpn-01" challenge, where certificate selection needs to happen based not only on SNI but also ALPN extension, as reported in #5331.
Also, it is conceivable that the server might want to take some action if an extension is absent, and for that a callback that's called unconditionally obviously works better.
Finally, it appears there's a similar callback in OpenSSL since 1.0.2 and people are using it.

#5454 "server certificate selection callback" submitted as a Draft for discussion.

Renaming to  "add certificate selection callback" - after discussion with the team, we agreed that new callbacks should not be named after a particular point in the handshake, but after the action they're meant to allow. Handshake flows might change between versions and it's our job to shield users from those low-level details and just run the callback at the right time for the associated action.


Reloading may crash

I've had several instances where reloading Brackets will crash it with a "Brackets stopped working" message from Windows. Just hitting F5 inside of Brackets occasionally makes it crash like that.
After the crash, the Brackets chrome remains behind, unclosable. Only option is to kill it (again!) manually by pulling up the task manager, finding brackets, killing it, and finally restarting it.
Brackets 1.4, Windows 7 x64. Extensions or not makes no difference.

This has been fixed in #11505 (you can try the master branch if you want to test it out)

Closing as fixed.


Automatically add Monitors to dashboard based on tags

⚠ Please verify that this feature request has NOT been suggested before.

[X] I checked and didn't find similar feature request

🏷 Feature Request Type
UI Feature
🔖 Feature description
Have a lot of services monitored, it would be helpfull to have new monitors added to the dashbaord automatically based on tags.
✔ Solution
Given I Have tag "Websites"
AND I create a new Monitor with Tag "Websites"
I want to see this automatically on the Status page under the Website Section
❓ Alternatives
No response
📝 Additional Context
No response

Hi there,
I'm also very interested in this feature. And maybe add the ability to automatically add monitors based on tag color.

I second this request :)
Even if I would prefer to have a configpage where I can chose wich tags should be status pages

Great idea - links to #1609 too.


Modify amplitude and kinematics modules so that they can handle the new recipe file structure

Follow-up to #74
Required for #73
The expertsystem v0.1.2a0 produces a slightly different amplitude model recipe file that the hard-coded intensity-recipe.yaml file.

I believe this refers to the problem, that a predefined recipe structure is assumed in the kinematics code as well right?


Add a bold warning that the TF provider does not work with Artifactory OSS

It seems in Artifactory OSS the REST API is unavalable. Consequently, this TF provider is useless and the README.md should contain a bold warning that is does not work with Artifactory OSS.
If you attempt to use this TF provider with jfrog/artifactory-jcr:
Error: PUT http://<IP_ADDRESS>:8082/artifactory/api/repositories/dockerhub: 400 [{Status:400 Message:This REST API is available only in Artifactory Pro (see: jfrog.com/artifactory/features). If you are already running Artifactory Pro please make sure your server is activated with a valid license key.
}]

Sure, That's doable - you can also feel free to offer a PR for this.


Some issue about setting text color for MathView

hello~I want to let the color of my MathView's text become white,according to stackoverflow(The link is : https://stackoverflow.com/questions/41485618/how-can-i-change-the-color-of-text-of-a-mathview-which-is-basically-a-webview)  ,I try:
MathView formula = findViewById(R.id.scan_result);
formula.config(
"MathJax.Hub.Config({\n"+
"  { TeX: { extensions: ["color.js"] } }\n"+
"});"
);
Then:
formula.setText("\(\color{white}{ax^2 + 7}\)");
it can show text as white.
but if i use some lateX which need symbol "$"  like this:
formula.setText("\(\color{white}{$$ax^2 + 7$$}\)");
it dose not work.
Thanks if someone can help me.

See pull request #69


Management Point now requires NT\NETWORK SERVICE to have SQL rights if the Management Point and DB server are collocated

With our new User Service component of the Management Point, we connect to SQL using the NT\NETWORK SERVICE account when the MP and DB servers are collocated. Otherwise, we use the system account of the Management Point. As NT\NETWORK SERVICE is not listed with SQL permission requirements up until now, we should consider adding this as a check prior to deploying a Management Point.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9070eb9b-0e5f-a877-e02e-2d1cea2a2b38
Version Independent ID: df251762-f2d6-9f06-4fa9-ec5cea2cca0a
Content: Site prerequisites - Configuration Manager
Content Source: sccm/core/plan-design/configs/site-and-site-system-prerequisites.md
Product: configuration-manager
Technology: configmgr-other
GitHub Login: @mestew
Microsoft Alias: mstewart

Hi @jrosser1221, thanks for the input. I checked with engineering on this:
Hman manages sql role memberships automatically on role install/uninstall:

If MP is co-located, Network Service is added to user service sql role
If MP is not co-located, machine account is added to user service sql role
It’s not something admin needs to do unless there is an issue (which does happen on occasion). Feels like it’s more of a support doc. We're actually looking into the level of technical troubleshooting content we want to start adding to our content, so I'll keep this open until we finalize that plan.

Thanks again for the feedback. We recently moved this content to a new GitHub repository, so this issue is no longer tracked with the original article. As part of that process, we reviewed our backlog of feedback, and made some tough decisions on items that we don't think we'll realistically ever address. If you're passionate about this specific feedback, please refile it on the current article, now under docs.microsoft.com/mem/configmgr.


Cannot find ActiveRecord Class in Rails 6

I have phobos configured with in the rails initializers/phobos.rb to start an executor from the config/phobos.yml like the the following:
Phobos.configure('config/phobos.yml')
executor = Phobos::Executor.new
executor.start

I get a  :exception_class=>"NameError", :exception_message=>"uninitialized constant TransactionsConsumer::Address" error when trying to load the Address model from ActiveRecord. There should be no TransactionsConsumer::Address but it should find the Address class in app/models/address.rb.
My Consumer in app/consumers/transactions_consumer.rb:
class TransactionsConsumer
  include Phobos::Handler

  def self.start(kafka_client)
    # setup handler
    puts "Starting Transaction Consumer"
  end

  def consume(payload, metadata)
    puts metadata
    puts payload
    data = JSON.parse(payload)
    if Address.exists?(address: data["fromAddress"])
      AccountBalanceUpdateJob.perform_in(1, data["fromAddress"])
    end
  end
end

I assume I'm not configuring Phobos correctly in some way to autoload or see the Rails Classes. How do I get Phobos configured to work with Rails models/objects?

Hey - so this seems to indicate that you don't have Rails autoloading working. :) You need to use the phobos_boot.rb file (which should be in your root directory) to load Rails. It should be as simple as replacing the contents of that file with
require_relative 'config/environment'

This issue was my own silly mistake. I renamed Address class to Account and thought it was the way Phobos was loading the whole project. Thank you for looking at it!

Thanks for following up!


WFLY-9507 Session X is missing cache entry for attribute Y

Jira
https://issues.jboss.org/browse/WFLY-9507
@pferraro maybe we should cut our losses with org.infinispan.AdvancedCache#getAll. Also, I have a hunch this might explain some other intermittent failures in EJB client that were missing entries on topology change as this is used in org.jboss.as.ejb3.remote.AssociationImpl.ClusterTopologyRegistrar#registerClusterTopologyListener. So I suggest to get QE to test this (incl. perf) and have this commit available for EAP 7.1.x backport and in WildFly master until we have a fix in Infinispan (created ISPN-8459) and needs to be revalidated with 9.x upgrade.

@pferraro btw QE has verified that with the fix the test scenario (failover-http-granular-jvmkill-dist-sync) is now passing 100% as opposed to losing most of the sessions on failover with the current codebase.

FYI - this PR will likely be made obsolete by https://github.com/wildfly/wildfly/pull/10665

@pferraro I have removed the changes from the CacheRegistry as the problem as confirmed by QE does not seem to manifest on replicated caches. So I think this should be merged in the meantime until we have Infinispan 9.x upgrade and revert once verified that this is fixed in 9.


types for proofs

just so we can have platforms and other structure for my profile shared
@keybase/react-hackers

:mag_right: The commits 875abc5cb571...7a98554447fc introduced some visual changes on linux:

Added: My_Profile_Confirm_Or_Pending-Confirm_Twitter

Added: My_Profile_Confirm_Or_Pending-Confirm_Github

👍


Make Netty Handler as Akka actor

There is a big flaw in this dss server system.
Netty handler have the blocking codes with concurrent hash map.
like io.github.ztkmkoo.dss.core.network.rest.handler.DssRestHandler, i have to handle the Netty ChannelHandlerContext with the concurrent container to handling receive also send action.
Please resolve it.
It would be a big upgrade.

I try to implement NioServerSocketChannel, ServerBootstrap, DefaultChannelPipeline, but i met the problem here.
at io.netty.channel.AbstractChannel.register0(), i need to override the pipeline.invokeHandlerAddedIfNeeded() method,
but if i make the handlers as akka actor, then send the read message action to the actors, then the channel will be unsafed(both netty eventloop and akka system thread can edit it.)
I wonder if my old design better?
my old design:
netty socket open => read & read complete => block & copy message & send it to service actor => handling the message & send back to netty handler => block => write (send response) socket message.

In netty, there are boos group (thread pool) that handling socket transport and worker group handling the transported message.
I try to make the worker group work as actor.

These days. i try to implement netty core classes like ChannelPipeline, SingleThreadEventLoop, MultithreadEventLoopGroup, AbstractSet, Selector, ServerBootstrap, ServerSocketChannel..
i succeed to register, bind and active the socket channel. and also succeed to accept the socket connection. But!!!!! it cannot read from it... omg...  feel so stressed...

after implement the doBeginRead. it worked finally..
actually, there are left so many method to override..

It must be test error.
I will fix it next commit..

I found cannot merge netty and akka system together without redisign channel and event loop or akka actor
Ok, i will open new issue to handling it


[Feature Request] Add zoom to Choropleth Map report

Hello,
I would like to be able to zoom on the Choropleth Map report like map report allow it.
Because it is not easy to see countries with a small surface.
Regards,
Cobra

Hi @Cobra5197, we offer the zoom feature on the Area Map. I know there is some redundancy between the Choropleth and the Area Map, we'll try to cover it soon. Feel free to reopen this issue if needed.


Add argumentless overload for get_sql_name()

Convenience function that comes handy with template metaprogramming: no need to create an object of the type whose SQL name we desire to use.
Also works with non-default constructible objects.

That looks reasonable to me, thanks!


deploy: same app-name though different envs

I follow the strategy of the advanced README having a production and test environment on the same server.
Starting
pm2 deploy test
works fine, and results in
API             │ 13 │ fork │ 11278 │ online │         0 │ 0s     │  1.340 MB   │  enabled
but when I then call
pm2 deploy production
it deletes the 'test' API and starts the production API as 'API'. That is, as they have the same name, pm2 thinks they are the same, but they run with different NODE_ENV and thus with different port numbers on the same server.
Solution: prefix or postfix the 'name' with 'env'.

Any PR is warmly welcome

@Unitech I'll do this if this would be merged fast.

I think this is a problem with pm2 itself.
cd /path/to/a && pm2 start ecosystem.json
cd /path/to/b && pm2 start ecosystem.json

This will basically kill /path/to/a/ecosystem.json and start /path/to/b/ecosystem.json

Is this issue solved or not? I met the same problem as well

@chenweiyj pretty sure it's still an issue that needs solving since I'm having the same problem. I think that the idea of a deployment section should be done away with and everything should be merged into apps. That way you can set the app name and all of the configuration options in the same place.

@watzon you can simply create another ecosystem.test.js with a different name in it. updating the name management now will not be retro-compatible so we can eventually ship it after a major release.
i think that create multiple ecosystem files can be a simple trick to avoid the problem.

@phra weird, I tried that and when I tried to use anything that wasn't ecosystem.config.js it threw a fit and said that "ecosystem.dev.js" wasn't an environment in package.json.

@watzon with pm2 deploy or pm2 start?
with pm2 deploy ecosystem.dev.json dev setup && pm2 deploy ecosystem.dev.json dev it should work fine.

@phra pm2 deploy was the one not working for me. I'll try again in a bit though and see if I can get it to work.

@phra ok, so without some of the private info, this is what ecosustem.prod.js looks like:
module.exports = {
    apps : [
      {
        name      : 'watzon.me',
        script    : 'server.js',
        env: {
          ENV_SILENT: true,
          SESSION_DRIVER: 'cookie',
          DB_CONNECTION: 'pg',
          DB_HOST: '<IP_ADDRESS>',
          DB_PORT: 5432,
          DB_USER: '',
          DB_PASSWORD: '',
          NODE_ENV: 'production',
          HOST: '<IP_ADDRESS>',
          PORT: 3753,
          APP_KEY: '',
          CACHE_VIEWS: false,
          DB_DATABASE: 'watzon-co-dev'
        }
      },
    ],
    deploy : {
      production : {
        user : 'root',
        host : '<IP_ADDRESS>',
        ref  : 'origin/master',
        repo : '',
        path : '/var/www/watzon.me',
        'post-deploy' : 'npm install && node ./scripts/post-deploy.js --env production'
      }
    }
  };

I am attempting to deploy it with pm2 deploy ecosystem.prod.js production, but that gives me the error ecosystem.prod.js environment is not defined in ecosystem.config.js file.
Am I just missing something blaringly obvious?

@watzon *.config.js - is mandatory file name for pm2 js config file. Change it to ecosystem.prod.config.js

@slavaGanzin nice catch!

See here too:
https://github.com/Unitech/pm2/issues/1927#issuecomment-394834582


Forum MathNet not working.

Seems, for a second day I can't come on a forum:
http://discuss.mathdotnet.com/
Do you plan to restore him?

Yes, unfortunately I have some hardware/driver problems on my server since a few days. The forum will definitively come back.

The server seems to be stable again (since the last 2 days).


Check impact of smallvec

Run benchmarks replacing Vec by the one in the smallvec crate, and see if it's worth it to add a dependency.

SmallVec has a static initial size (stack allocated), and if the vec grows beyond that the contents are moved to the heap.
Benchmarks show good performance gains of ~30% for small expressions, but loses up to ~12% in performance for larger expressions (when more heap reallocations are happening).
We have some options:

keep what we have and don't benefit from the 30% gains from smallvec, but also don't lose 10% in large expressions.
use smallvec and accept losses in performance for larger expressions;
create a function for small expressions using a static array that just returns an error if the expression is too large;

I should check tinyvec as well (which does not use unsafe).

Somehow with tinyvec and an initial allocation of 16 tokens, most cases, even the small ones, regressed in performance.


Form e2e testing

Getting caught up on the form end to end test. Will keep this in draft until the remaining form pages are in and also until I refactor some things such as the cy.wait() I am using throughout since the page changes would break without it. Likely there is a better way to go about it.
Set environment variable ENABLE_MOCK_AUTH=true to test this.

@matthieu-foucault I rebased and updated this end to end test. It currently goes through the entire form along with most of the fields aside from some such as I haven't brought any file upload testing into this yet.
No rush obviously but I would appreciate you taking a look some time this week and maybe some suggestions about how to refrain from relying on cy.wait() in between route changes. It looks like it passed this time but I imagine it will fail in CI sometimes depending on how fast github is at the moment.


callable type hint in php 5.4

apply callable type hint, refs https://github.com/zendframework/zf2/pull/7119

These changes are semver-incompatible, as the signature of the methods change.
I wouldn't mind, to be honest, but any inheritance in the affected classes would be broken in this case.
(Shameless plug: we need more final)

the @param type already indicate it must be callable, I don't change the @param callable|string|null as it optional. /cc @weierophinney if it is acceptable ?

@samsonasik the problem is that following code will cause a PHP Strict standards:  Declaration of Bar::baz() should be compatible with Foo::baz(callable $baz):
<?php

class Foo
{
    public function baz(callable $baz)
    {
    }
}

class Bar extends Foo
{
    public function baz($baz)
    {
    }
}

ok ;)

Closing as per review. Sorry @samsonasik, but I hope you understand what incompatibility is being introduced here.

it's ok :+1:


Provide API for making HTTP requests (wrap internal.download)

Looking around javascript sources in Arango and Foxx apps, I see a lot of functions under require("internal") but I can't find any docs for it. Afaics, only require("internal").print has been mentioned in doc.

@pluma haven't you added the request module recently? I think it serves exactly this purpose.
If what I guessed is true, can you provide some pointers on its documentation and close this issue?

2.5 will bring the org/arangodb/request module, which provides a similar API to the request module for Node.js.
The module is documented in the 2.5 docs (in the JavaScript modules chapter).

Hey, what about multipart/form-data POST requests?
I tried it, but the Content-Length is wrongly calculated and appended. What I'm trying to do, is upload an image to the CDN. If I manually add the length header, it gets duplicated and the request ends up in a loop...

The request module currently does not provide built-in support for multipart/form-data.
Could you try sending your POST request to the apropriate endpoint on http://httpbin.org/ and describe the issue you are seeing?

Hmm, it seems ok, the multipart data is returned... but I get 500 from our CDN.
Here is the code snippet:
var endpoint = "http://httpbin.org/post";
var opts = {
    method: "POST",
    headers: {
        "Host": this.getHostAndPort(endpoint),
        "Content-Type" : "multipart/form-data; boundary=4be60ee5d163"
    }
};
var body = '--4be60ee5d163\r\n'+
    'Content-Disposition: form-data; name="upload"; filename="test.png"\r\n'+
    'Content-Type: image/png\r\n\r\n'+
    file+"\r\n"+
    '--4be60ee5d163--\r\n';
var resp = download(endpoint, body, opts);
console.log(resp);

I tried with both application/octet-stream and image/png, no luck.
file variable is something like:
data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAA20AAAGLCA...

OK, so the problem is that the upstream CDN accepts only application/octet-stream as upload. I managed to have the image base64 encoded in Foxx, but I don't know if (how) I can craft a POST request with boundaries and Buffer object containing binary data. Any idea?

Do you mean multipart boundaries? You can just base64 encode the buffer (buf.toString('base64')) and then wrap it in a multipart message following the spec.
I assume you've seen the request docs? You can just specify your own content-type header and pass the encoded message as body.

Yes, something like that, but the other way around: from base64 TO binary buffer. I will try and post here there results. Thank you!

Hi,
i have just tried it locally:
var request = require("request");
var fs = require("fs");
var opts = {
  "method" : "POST",
  "headers" : {
    "Content-Type" : "application/octet-stream"
  }
};
var file = fs.readBuffer("path/to/image.png");
var endpoint = "http://httpbin.org/post";
var resp = request.post(endpoint, opts);

On httpbin it seams to work, i do not know about your internal API

Nope, it does not work..
What I tried:
var input = 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgA....A==';
var fileinbase64 = input.replace(/^data:image\/(png|jpg);base64,/, "");
var buffer = new Buffer(fileinbase64, 'base64');
var endpoint = "http://httpbin.org/post";
var bodyString = '--4be60ee5d163\r\n'+
    'Content-Disposition: form-data; name="upload"; filename="test.png"\r\n'+
    'Content-Type: application/octet-stream\r\n\r\n'+
    buffer+"\r\n"+
    '--4be60ee5d163--\r\n';
var opts = {
    url: endpoint,
    method: "POST",
    headers: {
        "Content-Type" : "multipart/form-data; boundary=4be60ee5d163"
    },
    body: bodyString
};
var resp = request(opts);
console.log(resp);

If I concatenate buffer (Buffer object in binary) to bodyString then I always get Content-Length: 0 in headers.
I think what I want is provided by the NodeJS request module:
https://github.com/request/request#multipartform-data-multipart-form-uploads

I tried it using these:
fs=require("fs")
var buffer=fs.read("Installation/Windows/Icons/arangodb.ico");
and monitored whats on the line using ngrep: (wireshark may also work for you)
ngrep -Wbyline host httpbin.org |less
Here are the relevant parts of the conversation on the wire:
POST /post HTTP/1.1.
Host: httpbin.org.
Connection: Keep-Alive.
User-Agent: ArangoDB.
Accept-Encoding: deflate.
content-type: multipart/form-data; boundary=4be60ee5d163.
Content-Length: 295100.
.
--4be60ee5d163.
Content-Disposition: form-data; name="upload"; filename="test.png".
Content-Type: application/octet-stream.
.....
--4be60ee5d163--.
#################
T <IP_ADDRESS>:80 -> <IP_ADDRESS>:46550 [A]
HTTP/1.1 200 OK.
Server: nginx.
Date: Fri, 20 Mar 2015 14:53:22 GMT.
Content-Type: application/json.
Content-Length: 1048907.
Connection: keep-alive.
Access-Control-Allow-Origin: *.
Access-Control-Allow-Credentials: true.
.
{
"args": {},
"data": "",
"files": {
"upload": "..."
},
"form": {},
"headers": {
"Accept-Encoding": "deflate",
"Content-Length": "295100",
"Content-Type": "multipart/form-data; boundary=4be60ee5d163",
"Host": "httpbin.org",
"User-Agent": "ArangoDB"
},
"json": null,
"origin": "<IP_ADDRESS>",
"url": "http://httpbin.org/post"
}
where upload in the reply and the post data were binary.

So, I made it work. For the record, here is the solution:
var input = 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgA....A==';
var fileinbase64 = input.replace(/^data:image\/(png|jpg);base64,/, "");
var buffer = new Buffer(fileinbase64, 'base64');
var endpoint = "http://httpbin.org/post";
var bodyStart = '--4be60ee5d163\r\n'+
    'Content-Disposition: form-data; name="upload"; filename="test.png"\r\n'+
    'Content-Type: application/octet-stream\r\n\r\n';
var bodyEnd = '\r\n--4be60ee5d163--\r\n';

 multipartBody = Buffer.concat([
    new Buffer(bodyStart),
    buffer,
    new Buffer(bodyEnd)]
);

var opts = {
    url: endpoint,
    method: "POST",
    headers: {
        "Content-Type" : "multipart/form-data; boundary=4be60ee5d163"
    },
    body: multipartBody
};
var resp = request(opts);
console.log(resp);

Anyway, I think what would be nice to have is already provided by the NodeJS request module:
https://github.com/request/request#multipartform-data-multipart-form-uploads

@razvanphp request uses an npm module to handle the multipart body generation. Sadly there doesn't seem to be any module that can build multipart bodies synchronously using buffers, so we'll probably have to implement this ourselves.
It's definitely an issue we're aware of and planning to address (either via npm or with a built-in function). Sorry about the inconvenience.


Line #1 <IP_ADDRESS>

https://hosts.ubuntu101.co.za/badips.txt
Line 1 >
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>

:smile:

@spirillen In our central repository, everything is whitelisted by our whitelisting tool. So we do not distribute them.

Also @spirillen, They are not present into {clean,whitelisted}.list.

Hi @funilrys it was mostly a humorist note to https://github.com/mitchellkrogza/Ultimate.Hosts.Blacklist/issues/508#issuecomment-476374554 and https://github.com/mitchellkrogza/Ultimate.Hosts.Blacklist/issues/509#event-2227824277 :laughing:

Hi @spirillen it was because of the migration from https://pypi.org/project/ultimate-hosts-blacklist-the-whitelist/ to https://pypi.org/project/ultimate-hosts-blacklist-whitelist/. Explation about the differences can be found at https://github.com/Ultimate-Hosts-Blacklist/dev-center/issues/24#issuecomment-476409402
Cheers,
Nissar


Delegating to No confidence still shows DRep delegation for a while, Automated Voting options 'accordion' is closed, should be open.

Context & versions
staging.sanchonet
Steps to reproduce

Delegate to a Drep
Delegate to No Confidence

Actual behavior vs expected behaviour

Delegation starts and
The interface still shows (while delegation is in progress) that you are delegated to a Drep. This should disappear as soon as the user presses the delegate button
When a user is delegated to Abstain or No confidence, the 'combo' box that contains these options should be open. This also should apply when the delegation is in progress.

Expected behavior
As above, also see loom video.
Loom video
https://www.loom.com/share/c652a0543a534c4dafcf2396cc918500?sid=4981ff20-9f4b-4dd3-a837-26b6766347cb

Two visual aspect mentioned in loop:

Automated Voting option card should stay unfolded after delegation
If  You have delegate do a DRep and change to No or Abstain this card should be updated earlier - please refer to loom for details

@m-i-k-e In that case could you please clarify a bit states of this badges (when they should be displayed and why)
Based on the issue and figma design.

The interface still shows (while delegation is in progress) that you are delegated to a Drep.
OK NOW :This should disappear as soon as the user presses the delegate button
TODO: When a user is delegated to Abstain or No confidence, the 'combo' box that contains these options should be open.
This also should apply when the delegation is in progress.

Fully fixed with this PR: https://github.com/IntersectMBO/govtool/pull/1013

OK NOW:

Delegation card disappears when Abstain, No confidance chosen
Abstain - No confidance is unfolded when a delegation is in progress or activated

Jam recording

This works fine now: https://www.loom.com/share/fabf24eeeac74a479bd3a404fede8069?sid=8329fe5c-840e-4dbd-bce0-24162494ced3


[brig] Windows binary has no .exe extension

The Windows binary from the download section has no .exe suffix, without the .exe suffix windows don't know how to handel the binary.
Please provide the precompiled binary with a .exe suffix

sorry wrong project ^^


Test Issue created at Tue, 25 May 2021 10:45:35 GMT

Test issue body  Tue, 25 May 2021 10:45:35 GMT

Comment on issue at Tue, 25 May 2021 10:45:38 GMT


Getting Metric not enabled on DCP metric

Hello,
I installed the help chart for the DCGM metrics in kubernetes, and I wanted to use the DCP metrics since we have MIG running on several A100s in our cluster.
However, we received the following error:
time="2023-02-21T17:32:09Z" level=warning msg="Skipping line 5 ('DCGM_FI_PROF_GR_ENGINE_ACTIVE'): metric not enabled" time="2023-02-21T17:32:09Z" level=warning msg="Skipping line 6 ('DCGM_FI_PROF_PIPE_TENSOR_ACTIVE'): metric not enabled"
from the dcgm pod log.
Any help in solving this would be greatly appreciated!  My "default-counters.csv" file that I use is shown below:
# FormatTEST
# If line starts with a '#' it is considered a comment
# DCGM FIELD, Prometheus metric type, help message

# Clocks
#DCGM_FI_DEV_SM_CLOCK,  gauge, SM clock frequency (in MHz).
#DCGM_FI_DEV_MEM_CLOCK, gauge, Memory clock frequency (in MHz).

# Temperature
#DCGM_FI_DEV_MEMORY_TEMP, gauge, Memory temperature (in C).
#DCGM_FI_DEV_GPU_TEMP,    gauge, GPU temperature (in C).

# Power
#DCGM_FI_DEV_POWER_USAGE,              gauge, Power draw (in W).
#DCGM_FI_DEV_TOTAL_ENERGY_CONSUMPTION, counter, Total energy consumption since boot (in mJ).

# PCIE
#DCGM_FI_DEV_PCIE_TX_THROUGHPUT,  counter, Total number of bytes transmitted through PCIe TX (in KB) via NVML.
#DCGM_FI_DEV_PCIE_RX_THROUGHPUT,  counter, Total number of bytes received through PCIe RX (in KB) via NVML.
#DCGM_FI_DEV_PCIE_REPLAY_COUNTER, counter, Total number of PCIe retries.

# Utilization (the sample period varies depending on the product)
#DCGM_FI_DEV_GPU_UTIL,      gauge, GPU utilization (in %).
#DCGM_FI_DEV_MEM_COPY_UTIL, gauge, Memory utilization (in %).
#DCGM_FI_DEV_ENC_UTIL,      gauge, Encoder utilization (in %).
#DCGM_FI_DEV_DEC_UTIL ,     gauge, Decoder utilization (in %).

# Errors and violations
# DCGM_FI_DEV_XID_ERRORS,            gauge,   Value of the last XID error encountered.
# DCGM_FI_DEV_POWER_VIOLATION,       counter, Throttling duration due to power constraints (in us).
# DCGM_FI_DEV_THERMAL_VIOLATION,     counter, Throttling duration due to thermal constraints (in us).
# DCGM_FI_DEV_SYNC_BOOST_VIOLATION,  counter, Throttling duration due to sync-boost constraints (in us).
# DCGM_FI_DEV_BOARD_LIMIT_VIOLATION, counter, Throttling duration due to board limit constraints (in us).
# DCGM_FI_DEV_LOW_UTIL_VIOLATION,    counter, Throttling duration due to low utilization (in us).
# DCGM_FI_DEV_RELIABILITY_VIOLATION, counter, Throttling duration due to reliability constraints (in us).

# Memory usage
DCGM_FI_DEV_FB_FREE, gauge, Framebuffer memory free (in MiB).
DCGM_FI_DEV_FB_USED, gauge, Framebuffer memory used (in MiB).

# ECC
# DCGM_FI_DEV_ECC_SBE_VOL_TOTAL, counter, Total number of single-bit volatile ECC errors.
# DCGM_FI_DEV_ECC_DBE_VOL_TOTAL, counter, Total number of double-bit volatile ECC errors.
# DCGM_FI_DEV_ECC_SBE_AGG_TOTAL, counter, Total number of single-bit persistent ECC errors.
# DCGM_FI_DEV_ECC_DBE_AGG_TOTAL, counter, Total number of double-bit persistent ECC errors.

# Retired pages
# DCGM_FI_DEV_RETIRED_SBE,     counter, Total number of retired pages due to single-bit errors.
# DCGM_FI_DEV_RETIRED_DBE,     counter, Total number of retired pages due to double-bit errors.
# DCGM_FI_DEV_RETIRED_PENDING, counter, Total number of pages pending retirement.

# NVLink
# DCGM_FI_DEV_NVLINK_CRC_FLIT_ERROR_COUNT_TOTAL, counter, Total number of NVLink flow-control CRC errors.
# DCGM_FI_DEV_NVLINK_CRC_DATA_ERROR_COUNT_TOTAL, counter, Total number of NVLink data CRC errors.
# DCGM_FI_DEV_NVLINK_REPLAY_ERROR_COUNT_TOTAL,   counter, Total number of NVLink retries.
# DCGM_FI_DEV_NVLINK_RECOVERY_ERROR_COUNT_TOTAL, counter, Total number of NVLink recovery errors.
# DCGM_FI_DEV_NVLINK_BANDWIDTH_TOTAL,            counter, Total number of NVLink bandwidth counters for all lanes

# VGPU License status
#DCGM_FI_DEV_VGPU_LICENSE_STATUS, gauge, vGPU License status

# Remapped rows
#DCGM_FI_DEV_UNCORRECTABLE_REMAPPED_ROWS, counter, Number of remapped rows for uncorrectable errors
#DCGM_FI_DEV_CORRECTABLE_REMAPPED_ROWS,   counter, Number of remapped rows for correctable errors
#DCGM_FI_DEV_ROW_REMAP_FAILURE,           gauge,   Whether remapping of rows has failed

# Static configuration information. These appear as labels on the other metrics
DCGM_FI_DRIVER_VERSION,        label, Driver Version
# DCGM_FI_NVML_VERSION,          label, NVML Version
# DCGM_FI_DEV_BRAND,             label, Device Brand
# DCGM_FI_DEV_SERIAL,            label, Device Serial Number
# DCGM_FI_DEV_OEM_INFOROM_VER,   label, OEM inforom version
# DCGM_FI_DEV_ECC_INFOROM_VER,   label, ECC inforom version
# DCGM_FI_DEV_POWER_INFOROM_VER, label, Power management object inforom version
# DCGM_FI_DEV_INFOROM_IMAGE_VER, label, Inforom image version
# DCGM_FI_DEV_VBIOS_VERSION,     label, VBIOS version of the device

DCGM_FI_PROF_GR_ENGINE_ACTIVE,   gauge, Ratio of time the graphics engine is active (in %).
DCGM_FI_PROF_PIPE_TENSOR_ACTIVE, gauge, Ratio of cycles the tensor (HMMA) pipe is active (in %).

@avickars,
Could you provide more details about your environment?

Is the dcgm-exporter run in a container?
What are the command-line arguments?
Is it possible to run a standalone nv-hostengine with debug logs and configure the dcgm-exporter to connect to it?


Parse char field - Decode with 'errors'

Thanks for dbfread! It is useful and helps me a lot!
However, I found a problem when I use dbfread.
When I try to decode a string, it often occurs that the encoding set can not parse some singular characters, and then it raises exception.
We can use the 'errors' filed to solve this problem.

a = 'XXX'
a.decode(encoding='YYY', errors='replace')

So I add this filed to dbfread to solve this problem. Use it like:

DBF('XXX.dbf', encoding='YYY', char_decode_errors='replace')

Thank you! This is very useful. I've merged your changes.

I had to update the code a bit so the option was used everywhere but it should be good to go now.

I'm glad it's helpful.


refactor addBarmanEndpointCAToJob function

Right now the function:
https://github.com/cloudnative-pg/cloudnative-pg/blob/1a322fa7a703c232b401b4fa7e50db676c3a1d9f/pkg/specs/jobs.go#L135
Is extremely hard to maintain given to the approach used. Adding new providers would be extremely error prone
We should refactor and make it more maintainable.

While reviewing this PR I discovered #453.


Write a C++ program to find sum of n natural numbers by recursion

Description
Write a C++ program to find sum of n natural numbers by recursion
Input  : 5
Output : 15

How to contribute

Save the solution in program/FindSumOfNNaturalNumbersByRecursion.cpp file
Add FindSumOfNNaturalNumbersByRecursion.cpp file in find-sum-of-n-natural-numbers-by-recursion folder

!assign


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_19_0kk6o6v/clone/recipe/meta.yaml:20: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_19_0kk6o6v/clone/recipe/meta.yaml:44: missing_pip_check: For pypi packages, pip check should be present in the test commands
INFO: /tmp/abs_19_0kk6o6v/clone/recipe/meta.yaml:52: invalid_url: https://docs.microsoft.com/python/api/overview/azure/authorization : URL domain redirect docs.microsoft.com ->  learn.microsoft.com
WARNING: /tmp/abs_19_0kk6o6v/clone/recipe/meta.yaml:53: missing_description: The recipe is missing a description
Errors were found

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_903czgowxw/clone/recipe/meta.yaml:20: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_903czgowxw/clone/recipe/meta.yaml:44: missing_pip_check: For pypi packages, pip check should be present in the test commands
INFO: /tmp/abs_903czgowxw/clone/recipe/meta.yaml:52: invalid_url: https://docs.microsoft.com/python/api/overview/azure/authorization : URL domain redirect docs.microsoft.com ->  learn.microsoft.com
WARNING: /tmp/abs_903czgowxw/clone/recipe/meta.yaml:53: missing_description: The recipe is missing a description
Errors were found


Triage finschia-sdk#997

The subject of the triage:

Finschia/finschia-sdk#997

I think this PR need to migrate to the finschia/cosmos-sdk. It is a type fix.


Create appscale-datastore package

https://ocd.appscale.com:8080/job/Daily Build/2191/
With updated migration job: https://ocd.appscale.com:8080/job/Migration/658/

Is this branch blocking something else?
It has conflicts that need to be resolved.

It's not urgent. I'm going to wait for https://github.com/AppScale/appscale/pull/2222 before pushing a merge commit since it was brought up during the demo.

https://ocd.appscale.com:8080/job/Daily Build/2284/
https://ocd.appscale.com:8080/job/Migration/727/

lgtm


Updated service-fabric-application-upgrade-tutorial.md

Performed an update on the article to reflect UI of Azure Service Fabric SDK 2.0.135.
Update code references to match the latest version of the Visual Objects sample project found on GitHub.

Hi @slapointe, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.
TTYL, AZPRBOT;

@TysonN: please merge.


pull request for e2e test at 01/07/2017 21:45:09

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Marketing page for /fiscal-sponsorship

A lot of organizations are already experiencing the pain of fiscal sponsorship.
We have developed a great software to stream line that process. But we aren't communicating about it!
So we would love to create a marketing page to present Open Collective as a platform for managing fiscal sponsorship.
The target audience of that page are non profit organizations that are interested in fiscal sponsorship.
Many have likely already experienced the pain of keeping track of expenses and budgets for all the different projects that they are fiscally sponsoring.
The call to action is to contact us (and set up a call)
One illustration that I like is showing this

to highlight the fact that there is one common legal entity that takes care of all the overhead for everyone (and the open collective platform that enables all collectives to have their own independent budget)
Copy:
https://docs.google.com/document/d/1rmqcoe3Z_KNxAheV3DnNlW5ctNKEFJZq62A4hRuxBac/edit?usp=sharing

Hi everyone, update:
I decided to scrap the illustration I was working on cuz it wasn't working so I tried a header based on the graphic that Xavier Damman suggested in the issue's description. I didn't go further to implement all the graphics so you can:
a) Comment on the information architecture.
b) Help me figure out the best way to choose how to illustrate this page with so many features listed.

FIGMA link: https://www.figma.com/file/eqgZAUzzaTGcW2T2oilV20/04.-Platform-Become-a-fiscal-host?node-id=0%3A1

what's the status of this? It seems like we dropped it

Picking up:
Latest update on the heading area. Front-end contractor is working on implementing the update.

@piamancini, @xdamman, @alannallama we need the copy-write to describe the role of the fiscal host in the hero section (main header block).

@cuiki I'm keen to work with you on this. What's the easiest way for me to edit the existing text or give you changes?

@cuiki @znarf I have updated the text and committed the changes.
I also suggest these small changes (which I haven't made because I didn't want to break anything):

Link the case studies to the relevant case study articles: Women Who Code, Operation Code, and Brussels Together.
At the bottom, instead of 'contact us' how about 'find out more' which links to the fiscal hosting docs.

Is this live now?

@znarf @cuiki where has this got to? I would really like it to go live now.

It looks like it is live already: https://opencollective.com/become-a-fiscal-host

Oh cool! It looks good!
Can the small changes I suggested here be made?

A user has pointed out that the contact link at the bottom is broken as well.
@Betree or @znarf can you please make the small changes described in this thread? I want to start using this page publicly but these fixes need to go in first.

@alannallama On it

Closing!


Move tesla adapter to config

Delete tesla adapter config from client.ex for the opportunity to config from config files.

Hi @prtngn!
The idea of making the HTTP library pluggable leveraging the Tesla abstraction is not bad.
It gives the possibility to stick to the same HTTP library you decided to use, not only at app level but also down to your deps (as much as they all are open to this kind of configurability).
But there are some considerations we should pay attention to:

If the HTTP adapter library is pluggable (choosing among the tesla availble adapters) then the responsibility of it will be on the client. For example the client should explicitly install on its side the deps (ie for the gun adapter: gun, castore, idna ...) along side with the telegram dep. It should also correctly configure the adapter opts (timeouts, certs_verification etc).
Should telegram library give you out of the box a default one, that you can eventually override?
About the "adapter configuration" aspect we should think if it's OK to use the global config approach from the app vs lib perspective (in general it's not)

I think you understand it needs a bit of investigation before jumping to a conclusion.
I'll think about it. Feel free to discuss here if you want.
Thank you

So, you right ) I only learning elixir ) I faced a problem with self-signed certificate+proxy and that's why I need to config Tesla adapter.


Migrate kaldi mfcc

This PR migrates the kaldi mfcc test (#597 ) from test/test_compliance_kaldi.py to test/kaldi_compatibility_impl.py

Hi @bhargavkathivarapu
Can you apply this patch?
This should resolve RuntimeError: Expected object of scalar type Double but got scalar type Float for argument #3 'mat2' in call to _th_addmm_out
and the remaining failure will be AssertionError.
diff --git a/torchaudio/compliance/kaldi.py b/torchaudio/compliance/kaldi.py
index 8115c3a..bdf5f40 100644
--- a/torchaudio/compliance/kaldi.py
+++ b/torchaudio/compliance/kaldi.py
@@ -696,6 +696,8 @@ def mfcc(
     """
     assert num_ceps <= num_mel_bins, 'num_ceps cannot be larger than num_mel_bins: %d vs %d' % (num_ceps, num_mel_bins)

+    device, dtype = waveform.device, waveform.dtype
+
     # The mel_energies should not be squared (use_power=True), not have mean subtracted
     # (subtract_mean=False), and use log (use_log_fbank=True).
     # size (m, num_mel_bins + use_energy)
@@ -717,7 +719,7 @@ def mfcc(
         feature = feature[:, mel_offset:(num_mel_bins + mel_offset)]

     # size (num_mel_bins, num_ceps)
-    dct_matrix = _get_dct_matrix(num_ceps, num_mel_bins)
+    dct_matrix = _get_dct_matrix(num_ceps, num_mel_bins).to(dtype=dtype, device=device)

     # size (m, num_ceps)
     feature = feature.matmul(dct_matrix)
@@ -725,7 +727,7 @@ def mfcc(
     if cepstral_lifter != 0.0:
         # size (1, num_ceps)
         lifter_coeffs = _get_lifter_coeffs(num_ceps, cepstral_lifter).unsqueeze(0)
-        feature *= lifter_coeffs
+        feature *= lifter_coeffs.to(device=device, dtype=dtype)

     # if use_energy then replace the last column for htk_compat == true else first column
     if use_energy:

@mthrok , Applied the kaldi mfcc patch . Removed all assertion failing tests

Hi @bhargavkathivarapu
Looks great! Thanks!

@bhargavkathivarapu
Follow up: test_mfcc_000, test_mfcc_070, test_mfcc_071 are failing on GPU.
https://app.circleci.com/pipelines/github/pytorch/audio/2031/workflows/2fb51661-2656-4d4a-a3d6-b104398254d6/jobs/51900
If you have time, can you remove them too?

Will remove these in next PR for kaldi migration


Recommend using AadIssuerValidator

For https://docs.microsoft.com/en-us/azure/architecture/multitenant-identity/claims#issuer-validation, you might be interested in the new Microsoft.IdentityModel.Validators NuGet package, which provides an issuer validator for AAD and AAD B2C single and multi-tenant apps for the public cloud and sovereign clouds:
See https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/blob/3eb940655dcf9f685fc3979bfd63185cb8a8bf55/src/Microsoft.IdentityModel.Validators/AadIssuerValidator/AadIssuerValidator.cs#L175-L178
AadIssuerValidator aadIssuerValidator = AadIssuerValidator.GetAadIssuerValidator(authority, httpClient);
TokenValidationParameters.IssuerValidator = aadIssuerValidator.Validate;

Microsoft.Identity.Web is using it, btw
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a5d00031-82e8-a8ee-0a66-e9b84231e837
Version Independent ID: 9a9da08f-83e2-c493-61af-c4b5316c6f8e
Content: Claim-based identities in multitenant apps - Azure Architecture Center
Content Source: docs/multitenant-identity/claims.md
Service: architecture-center
Sub-service: azure-guide
GitHub Login: @EdPrice-MSFT
Microsoft Alias: pnp

Thanks for reporting - this issue is under review. This is a Microsoft Internal DevOps Bug ID # 518417

We have this captured as an article to improve. Thank you for your feedback!


Attempt at resolving compilation error in nbio

Sooo I'm new to Odin and I thought I could give this a chance to learn about the language.

Thank you!


function not defined

Could you provide the code of 'load_model_and_prune' and 'load_model' in test.py?

Same request.

Could you provide the code of 'load_model_and_prune' and 'load_model' in test.py?

Hi Draymond, I found that the function "build_model" shown in test_prune.py is actually your expected function "load_model_and_prune". So you can just change the function name to "build_model" in line 193. Also, load_model(model_path) could be replaced by model.load_state_dict(torch.load(model_path)). Hope this help you :)


Implement garbage collection

Fixes #15

(cmd/update.go is now too big, will refactor in another PR)


Treat relative paths as relative to parent project's remote

Closes #520.

Thanks for getting this merged! I realised it probably should have been an integration test instead of a unit-test but picked the easiest thing to copy/paste 😅


2D Distance Calculator

Fixes Issue🛠
Closes #401
Description👨💻
The calculators below can be used to find the distance between two points on a 2D plane .
Type of change📄

[] Bug fix (non-breaking change which fixes an issue)
[] New feature (non-breaking change which adds functionality)

How this has been tested✅
This has been tested on Local MAchine and works perfect
Checklist✅

[] My code follows the style guidelines of this project
[] I have performed a self-review of my own code
[] I have commented my code, particularly in hard-to-understand areas
[] I have added demonstration in the form of GIF/video file
[] I am an Open Source Contributor

Screenshots/GIF📷

Merged!! Congrats on getting your PR merged to this repo under JWOC 🎉🎉 @surendar-05


Lifetime inference issues with #[serde(borrow)]

While creating a deserializer to handle multiple "tag" fields, I created the following intermediary struct to buffer the data to. In this particular case I used serde::private::de::Content, following adjacently tagged enums as a working example.
#[derive(Deserialize)]
#[serde(deny_unknown_fields)]
pub struct GatewayPayload<'a> {
    #[serde(rename = "op")]
    pub opcode: u64,
    #[serde(borrow)]
    #[serde(rename = "d")]
    pub data: Content<'a>,
    #[serde(rename = "s")]
    pub sequence: Option<u64>,
    #[serde(rename = "t")]
    pub event_type: Option<String>,
}

The derived version of the struct causes rustc to become confused about the lifetimes and throws the following.
error[E0495]: cannot infer an appropriate lifetime for lifetime parameter `'de` due to conflicting requirements

However, expanding the deserialize implementation out does not seem to produce the same result as above. Instead the compiler has been appeased and produces a functional build.
impl<'de: 'a, 'a> Deserialize<'de> for GatewayPayload<'a> {
    fn deserialize<D>(deserializer: D) -> Result<Self, D::Error>
    where
        D: Deserializer<'de>,
    {
        #[derive(Deserialize)]
        #[serde(field_identifier)]
        enum Field {
            #[serde(rename = "op")]
            OpCode,
            #[serde(rename = "d")]
            Data,
            #[serde(rename = "s")]
            Sequence,
            #[serde(rename = "t")]
            Type,
        }

        struct GatewayPayloadVisitor<'de: 'a, 'a> {
            marker: PhantomData<GatewayPayload<'a>>,
            lifetime: PhantomData<&'de ()>,
        }

        impl<'de: 'a, 'a> Visitor<'de> for GatewayPayloadVisitor<'de, 'a> {
            type Value = GatewayPayload<'a>;

            fn expecting(&self, formatter: &mut fmt::Formatter<'_>) -> fmt::Result {
                formatter.write_str("struct GatewayPayload")
            }

            fn visit_map<V>(self, mut map: V) -> Result<Self::Value, V::Error>
            where
                V: MapAccess<'de>,
            {
                let mut opcode = None;
                let mut data = None;
                let mut sequence = None;
                let mut event_type = None;
                while let Some(key) = map.next_key()? {
                    match key {
                        Field::OpCode => {
                            if opcode.is_some() {
                                return Err(de::Error::duplicate_field("op"));
                            }
                            opcode = Some(map.next_value()?);
                        }
                        Field::Data => {
                            if data.is_some() {
                                return Err(de::Error::duplicate_field("d"));
                            }
                            data = Some(map.next_value()?);
                        }
                        Field::Sequence => {
                            if sequence.is_some() {
                                return Err(de::Error::duplicate_field("s"));
                            }
                            sequence = Some(map.next_value()?);
                        }
                        Field::Type => {
                            if event_type.is_some() {
                                return Err(de::Error::duplicate_field("t"));
                            }
                            event_type = Some(map.next_value()?);
                        }
                    }
                }
                let opcode = opcode.ok_or_else(|| de::Error::missing_field("op"))?;
                let data = data.ok_or_else(|| de::Error::missing_field("d"))?;
                let sequence = sequence.ok_or_else(|| de::Error::missing_field("s"))?;
                let event_type = event_type.ok_or_else(|| de::Error::missing_field("t"))?;

                Ok(GatewayPayload {
                    opcode,
                    data,
                    sequence,
                    event_type,
                })
            }
        }

        const FIELDS: &[&str] = &["op", "d", "s", "t"];
        deserializer.deserialize_struct(
            "GatewayPayload",
            FIELDS,
            GatewayPayloadVisitor {
                marker: PhantomData::<GatewayPayload<'a>>,
                lifetime: PhantomData,
            },
        )
    }
}

After coming to this result, I used cargo expand on each version to get a better idea of what is happening. While reviewing the expanded output of both versions, I was not able to spot a discernible difference.

This is a good demo of the "Do not do this. Sooner or later you will be sad" note under https://serde.rs/lifetimes.html#the-deserializede-lifetime. :) The Deserialize impl for Content is declared as impl<'de> Deserialize<'de> for Content<'de>. This wouldn't happen if it were declared as impl<'de: 'a, 'a> Deserialize<'de> for Content<'a>.
But as indicated by the serde::private type path, you shouldn't be using this type in the first place. It will change and break your code.

While understanding the consequences of my actions and how it can make me sad. This was part of an internal deep-dive into Serde's derive inner workings to better understand how to deal with the more troublesome serialization structures. In code intended for production I use serde-value.
The main objective of the ticket was to highlight a potential discrepancy in the derive implementation of the code. Where the expanded code looks similar in a side-by-side, but produces a different compiler result. I will attempt to come up with another example that does not use private APIs to demonstrate the issue.


Add NeRF positional embedding to neuralop.layers.embeddings

Changes:

Adds Embedding base class with out_channels abstractmethod
Fixes in_channels param in all embedding classes for clarity, exposes out_channels
Adds NeRF embedding to sinusoidal embedding
Refactors both transformer and nerf sine embeddings into SinusoidalEmbedding master class with embedding_type={'nerf', 'transformer'} option
Tests sinusoidal embeddings for correctness, adds all embeddings to API doc

Thanks @dhpitt for the changes and @Rlin232 @Xinyi-Li-4869 for the reviews!
Looks good to me, let's just keep transformers as the default before merging.

Fixed embedding_type='transformer' to be default. Merging once tests pass.


[cxx-interop] Fix exporing cdecl Swift functions to Obj-C++

We export cdecl function declarations twice: for Objective-C and for C++. When the code is compiled in Objective-C++ both of the declarations are visible to the compiler. The generated header did not compile, because only one of the declarations were noexcept. There are multiple possible ways to fix this issue, one of them would make only C++ declarations visible in Objective-C++ mode. However, for this particular problem I decided to also make the Objective-C functions SWIFT_NOEXCEPT. This approach resolves the inconsistency that broke the code when compiled in Objective-C++ mode. Moreover, Swift guarantees that those cdecl declarations cannot raise errors, so in case we only generate the C declarations and consume them from C++ or Objective-C++, those are the correct declarations.
rdar://129550313

@swift-ci please smoke test


feat: make all schemas work in all provider types

closes #16

@ruheni take over this 🙏

Tested, LGTM


onForegroundEvent mock needs to return a function

In jest-mock.js onForegroundEvent is currently defined as
  onForegroundEvent: jest.fn(),

However onForegroundEvent is supposed to return an unregistration function. This means that mocked code will raise an error:
    TypeError: unsubscribeNotifee is not a function

Assuming code like:
useEffect(() => {
  const unsubscribeNotifee = notifee.onForegroundEvent(...);
  return unsubscribeNotifee;
}, []);

I believe a better mock would be:
  onForegroundEvent: jest.fn(() => jest.fn()),

This might apply to other mocks expecting to return an unregistration function.

Thank you! i was able to replicate and have updated the mock.


Provide a builder like api for binary benchmarks in addition to the macro api

This issue came up in #2
Binary benchmarks can be currently setup with the main macro. The macro api is short and concise but macros are a little bit uncomfortable to work with, so a builder like api could provide a more convenient but also more verbose method to setup binary benchmarks.

Hi @epage. Have you tried the new version 0.5.0 of iai-callgrind with #2 merged? Are you still interested in using iai-callgrind and having a builder like api?

I am still interested in having a solution for this need and consider a criterion-like API a hard requirement.  It doesn't have to be a 1:1 and doesn't have to all exist from the beginning but putting everything in a single macro and trying to express the relevant needs is not a sustainable solution for adoption in my mind.

Ok, great! So, I haven't lost you on the way. Sorry, that it took some time but I found this change was too big to do it in a single step. I hope you find what you were looking for.
I finished the builder like api (so far) and it provides the same functionality (and more) of the macro api. You'll see the new builder api has some similarities to the criterion api. Everything's documented in the README and in the library documentation. If you're missing something, feel free to comment or open an issue.


add support for custom sqlalchemy dialects in create table statements

Currently, creating table statements is limited to SQLAlchemy's built-in dialects. This patch substitutes loading  dialects via sqlalchemy.dialects.registry for __importing__ from sqlalchemy.dialects.name. This allows for loading dialects added via setuptools entry_points. For example pip install pyhive, which I tested with, provides SQLAlchemy dialects for Hive and Presto.

@onyxfish Looks reasonable to me, but I don't have a deep understanding of what's going on.


Only define -testArgumentError when nullability is unavailable.

Having imported UICKeyChainStore via Carthage into my project. I am getting the follow unpleasant warnings:
/Users/daniel/Documents/Code/trainline/Carthage/Checkouts/UICKeyChainStore/Lib/UICKeyChainStoreTests/UICKeyChainStoreTests.m:1471:12: warning: null passed to a callee that requires a non-null argument [-Wnonnull]
    [store setString:@"kishikawakatsumi" forKey:nil error:&error];

My pull request deals with this by only defining the -testArgumentError only when nullability is unavailable. Also enabled the CLANG_WARN_NULLABLE_TO_NONNULL_CONVERSION warning.

I only got one warning when I was integrating this into my project. Which I fixed. But I enable the wrong warning flag so now there are many more warnings of misuse of nullability.
Also my pull request has been automatically rejected because the test coverage has decreased (expected as I've effectively removed one test for Xcode 7).
I'll do some more work on this to either enable to correct warning flag to reproduce my initial issue or fix the misuse of nullability.

Thanks for PR!!


Migrate Jetty Proxy to Airlift

Description
Second part of Airlift migration #41. Depends on #317.
This PR migrate Jetty Proxy (ie. ProxyHandler and ProxyServletImpl) to Airlift.
Motivation

Fix #242. Merge requestRouter, applicationConnectors and adminConnectors ports into one single port managed by Airlift. The TLS issues caused by routing between these ports will be gone.
Better control of the proxy request and response logic. The old implementation used Jetty ProxyServlet and overwrote different methods, making it difficult to add new features. By handling the request and response manually, we have full control of the request/response flow. This makes implementing query retries or query result caching much easier.
All configurations related to networking and TLS are done by Airlift config, which aligns with Trino. For example, the following config enable TLS for gateway:

httpConfig:
    http-server.http.enabled: false
    http-server.https.enabled: true
    http-server.https.port: 9080
    http-server.https.keystore.path: cert.jks
    http-server.https.keystore.key: changeme
    node.environment: test

TODO

[x] Update docs on how to config & run
[x] Document the incompatible changes and provide a migration guide.

Release notes
( ) Release notes are required, with the following suggested text:
* Replace Jetty Proxy with Airlift
* (TODO) Document the incompatible changes

I merged #317 now. Once you rebase here you might be able to address my comment about the config here. I think we should end up with the same config as in Trino ideally. So
jvm.config
config.properties
node.properties (maybe not even necessary)
log.properties
If we leave the http config in this PR in the YAML file for now I am good with that but maybe we can already have all of them under one config node or so

jvm.config

This is read by launcher.py. We can't set JVM config the config file unless we write our own version of launcher.py which supports YAML.

node.properties (maybe not even necessary)

Similar to above, launcher.py read this file and prepare the directories and symlinks. We can set log.output-file in httpConfig without using node.properties.

log.properties

Airlift expects this as a file LoggingConfiguration.java. We can allow setting log level in YAML, read the YAML, write them to a properties file and sent the file path to Airlift. I'm not sure if we want to do this.

config.properties

Everything that can be set in config.properties for Airlift can be set in httpConfig.

jvm.config

This is read by launcher.py. We can't set JVM config the config file unless we write our own version of launcher.py which supports YAML.

Yeah.. we can do that later .. ideally NOT with a python requirement.

node.properties (maybe not even necessary)

Similar to above, launcher.py read this file and prepare the directories and symlinks. We can set log.output-file in httpConfig without using node.properties.

log.properties

Agreed

Airlift expects this as a file LoggingConfiguration.java. We can allow setting log level in YAML, read the YAML, write them to a properties file and sent the file path to Airlift. I'm not sure if we want to do this.

Probably not in this PR. We will work with the airlift team to figure out how to proceed in terms of supporting yaml or toml or whatever to do next.

config.properties

Everything that can be set in config.properties for Airlift can be set in httpConfig.

Given the scope is way larger than just configuring HTTP I would hope we can come up with a better name.. just config or globalConfig or I dont know..

How about serverConfig?

How about serverConfig?

Thats good with me. @vishalya @willmostly @Chaho12 ?

How about serverConfig?

sounds good as it replaces requestRouter & server configs in yaml.
Btw why is historySize and requestBufferSize removed? does gateway now read all data from history?

For historySize, AFAIK we never use this value. No code is using this value since the initial git commit.
The equivalent for requestBufferSize is http-client.request-buffer-size in Airlift. Let me update the doc for that.

Update the docs for requestBufferSize
Rename httpConfig to serverConfig
PTAL

For historySize, AFAIK we never use this value. No code is using this value since the initial git commit.

Yeah code does not use historySize at all but i think the intent was to limit number of history in one api call (api requests all history at once so if too many history is called at once, ui lags)
i don't think this is needed anymore in current ui.  Pagination is added.

Could you maybe review @wendigo since you know a lot about this stuff already?

We decided in team sync today that we will merge early next week to give @vishalya and others a chance to look.

@mosabua sure, I'd prefer to merge it now and improve it right away but I'm fine with delaying that

@mosabua sure, I'd prefer to merge it now and improve it right away but I'm fine with delaying that

Monday ;-)

@mosabua ages :P

The changes look good. I was able to run it locally with the instructions provided on the PR.
So I am with merging this PR.

Also .. @vishalya .. please also approve the PR.

Here you go @wendigo and @oneonestar .. it hit earlier than Monday after all ;-)

Hi guys, the current version of https://github.com/trinodb/trino-gateway/blob/4553893a4b921e1dc4cec5442f2e7fd3e0558d02/gateway-ha/src/main/java/io/trino/gateway/proxyserver/RouteToBackendResource.java#L56 does not handle proxy for DELETE method, so that client can not cancel query on Trino backend, it causes queries submitted from airflow will be failed


"Goranu, Fețeni, Lespezi, Săliștea" are villages in "RÂMNICU VÂLCEA" municipality, "VALCEA" county

Description
When an user search a location, this appear in the drop-down menu
according to the law
Precondition
The website ( https://peviitor-ro.github.io/ui.orase/ ) is up an running.
Empty the search bar after every step

Steps 1
Write "Goranu"
Expected result
In the drop down menu you find "Sat Goranu, VALCEA(RÂMNICU VÂLCEA)"
Test Data
Goranu

Steps 2
Write "Fețeni"
Expected result
In the drop down menu you find "Sat Fețeni, VALCEA (RÂMNICU VÂLCEA)"
Test Data
Fețeni

Steps 3
Write "Lespezi"
Expected result
In the drop down menu you find "Sat Lespezi, VALCEA (RÂMNICU VÂLCEA)"
Test Data
Lespezi

Steps 4
Write "Săliștea"
Expected result
In the drop down menu you find "Sat Săliștea, VALCEA (RÂMNICU VÂLCEA)"
Test Data
Săliștea


ATAN-523 Code snippets for Adjust reattribution

Automatic Reattribution for Adjust through Universal links and URI schemes.

Result of Integration 2
Duration: 22 minutes and 28 seconds
Result: Build failed 1 test out of 227

👍


Is this still actively maintained?

Going through some of the issues and looking at the last commit it seems that work has stopped on this plugin.
True/false? :)

I agree, it would be nice to know what the status of the project is. Is it waiting for Leaflet-1.0 or what?

I'm working on getting leaflet master support working again.
We don't have a lot of time to work on this unfortunately, as usual PRs are nice but even then it takes a bit of time to go through them.

:+1:

This has moved to https://github.com/Leaflet/Leaflet.draw/issues/473


Custom properties reordering doesn't seems to be working as expected

Custom properties reordering doesn't seems to be working as expected
Backend: 1015.0.218
UI: 1015.0.79
Screenshot

Hi Rahul,
could you please add more details on the steps to reproduce/expected behavior ?

The sorting was introduced in Cockpit only in 10.16, in 10.15 it wasn't possible.

verified that this feature is working in 10.16.

Can we please close this issue @rahultsag  ?


False hints in snakes antidote game

Description

Citing the rules of the game

Rules: You have 4 ingredients for each antidote, you only have 10 attempts
Once you synthesize the antidote, you will be presented with 4 markers
Tick: This means you have a CORRECT ingredient in the CORRECT position
Circle: This means you have a CORRECT ingredient in the WRONG position
Cross: This means you have a WRONG ingredient in the WRONG position

Info: The game automatically ends after 5 minutes inactivity.
You should only use each ingredient once.

This is a screenshot of my first three guesses.

Description of each guess:

Random guess. It turns out that I got all the correct ingredients, and even the correct position for the last two ingredients. If I switch positions of the first two ingredients I should won the game
Switched the first two ingredients, but it appears that the last ingredient is the only one correct and in the correct position
Testing the fifth available ingredient, that shouldn't be part of the antidote, but it seems it is. Moreover, my last ingredient that was the only one correct and in the correct position is now not even a correct ingredient

Something doesn't add up
Steps to Reproduce

Play the game normally in sir-lancebot-playground channel
Expected Behaviour

Winning the game
Actual Behaviour

Wrong guess
Known Impacted Platforms

[x] Web
[x] Desktop
[x] Android App
[x] iOS App

Possible Solutions

I believe the error is sorting the guess_result list because the position info is thrown away
https://github.com/python-discord/sir-lancebot/blob/05ba3de5c99b30a8eba393da1460fae255373457/bot/exts/evergreen/snakes/_snakes_cog.py#L531-L539
Would you like to implement a fix?
Note: For high-priority or critical bugs, fixes may be implemented by staff.

[ ] I'd like to implement the bug fix
[x] Anyone can implement the bug fix

I believe this is intended behaviour. The tick means you have a correct ingredient in it's correct position, but the position of the tick doesn't indicate anything, so you don't know which ingredient you have in the correct position. This makes the game more interesting, as the strategy for it is less simple.
You can see that the position of the result emojis (white circle, tick, cross) is sorted in the code (guess_result.sort()) in order to not give the position away, hence you get the results you did.
That said, the current help embed doesn't make this very clear, so a line could be added to clarify this behaviour


pip install factory_boy error on python3.3

I'm on FreeBSD 9.1-RELEASE-p7 with python3.3 running on a virtualenv
pip install factory_boy return UnicodeDecode Error
(.env)# pip install factory_boy
Downloading/unpacking factory-boy
  Downloading factory_boy-2.2.1.tar.gz (71kB): 71kB downloaded
  Running setup.py egg_info for package factory-boy
    Traceback (most recent call last):
      File "<string>", line 16, in <module>
      File "/home/cdp/.env/lib/python3.3/encodings/ascii.py", line 26, in decode
        return codecs.ascii_decode(input, self.errors)[0]
    UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 1018: ordinal not in range(128)
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):

  File "<string>", line 16, in <module>

  File "/home/cdp/.env/lib/python3.3/encodings/ascii.py", line 26, in decode

    return codecs.ascii_decode(input, self.errors)[0]

UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 1018: ordinal not in range(128)

----------------------------------------
Cleaning up...
Command python setup.py egg_info failed with error code 1 in /home/cdp/.env/build/factory-boy
Storing complete log in /root/.pip/pip.log

Am I doing anything wrong ?

I used the following command on a Debian GNU/Linux 7.8 (wheezy)
# rebuild locale
dpkg-reconfigure locales
# set default (need to logout, log back)
update-locale LC_ALL=fr_FR.utf8
# for current session
export LC_ALL=fr_FR.UTF-8


fractions showing up as integers

Describe the bug
values in flow view are rounded up integers after enabling fractions.
To Reproduce
Steps to reproduce the behavior:

select copper cable in the production tab
click on flow
click on the cog
enable fractions for items
click confirm

Expected behavior
in the case of the copper cables, it should show 1/2 on both copper- plate and ore production

Thanks for the report, I can repro and I'm looking into it.


After the update, it seems like the iJulia kernel is broken?

Running my github repo on MyBinder (http://mybinder.org/repo/nhdaly/jupyter-binder), I've noticed that the Julia ipynb file doesn't work:
Opening julia_rnn.ipynb, I see this error over and over:

Dead kernel
The kernel has died, and the automatic restart has failed. It is possible the kernel cannot be restarted. If you are not able to restart the kernel, you will still be able to save the notebook, but running code will no longer work until the notebook is reopened.

However, it works just fine when I build the exact same Dockerfile on my machine and run the notebook from the container.

It could be a problem with my specific setup, but I just wanted to let you know.


Tour displacement when editing code

What happens to a tour step when code gets refactored? The durability of the tours beyond the short-term, could use some thinking. This has been an issue brought up in user research by customers.

Closing this as a duplicate of #53, so that we can track all decay improvements in one place 👍


iOS - Workspace - App crashes when making changes to Track distance units in offline

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Launch the app
Log in with any account
Create a workspace while offline
Choose Reimburse expenses
In the Track distance section, I change the unit from miles to km

Expected Result:
In app, units of measure must be selectable
Actual Result:
App crashes after changing miles to km offline
Workaround:
Unknown
Platform:

Where is this issue occurring?

iOS
Android

Version Number: 1.1.99 -2
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/189362228-d372d1da-0775-4836-acaa-798bd74bb26e.mp4
Bug5724572_logs_0909.log
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
View all open jobs on GitHub

@jasperhuangg Cold be related to your issue?

@0xaim thanks so much. We appreciate your investigation, but unfortunately, this is not something we compensate for. We recommend waiting to jump into issues until the Help Wanted label has been added. You can read more in our contributing guidelines here: https://github.com/Expensify/App/blob/main/contributingGuides/CONTRIBUTING.md
Thanks!


Added env variables for playbook and gh token

@asa1997
LGTM

@panickervinod @jobyko Updated the help file with the details of create command.


Update HAV to SNX and nUSD to sUSD

update rebrand www.synthetix.io

Hi Guys we've released to MAINNET. just wonderinv how long this might take to get through?
https://blog.havven.io/havven-is-transforming-into-synthetix-2fdf727b8892
https://blog.havven.io/launch-synths-are-now-live-on-mainnet-913d079462a9


[WIP] MHC created CR isn't deleted by the remediator

Why we need this PR
When a CR is created by MHC it's not deleted by the remediator (SNR) in case the remediator supports multiple templates.
The reason is that when MHC creates the CR it creates a generated name for the CR which does not match the machine name.
When the same apply for node base remediation the additional (node name and template name) info is stored in annotations on the CR, but for machine based remediation the remediator doesn't access those annotations.
Changes made

When creating an MHC remediation CR using the machine name and not generated name.
Multiple support annotation "NodeName" will now hold the correct node name (instead of the machine name) or empty value in case there is an issue getting the node name.

Which issue(s) this PR fixes
ECOPROJECT-2077
Test plan
Added a regression test

/test ?

/test 4.16-openshift-e2e

/test 4.16-openshift-e2e

/test 4.16-openshift-e2e

/test 4.16-openshift-e2e

/test 4.16-openshift-e2e


adds missing aop dependency required for logging

The org.springframework.boot:spring-boot-starter-data-jpa will transitively pull org.springframework.boot:spring-boot-starter-aop. This generator is designed to always use a RDBMS so if not JPA, even if we use JDBC or JOOQ etc aop starter will be added automatically. So no need to add aop starter explicitly.
What do you say?

Agreed, I have tried to use generator to use AWS application. Hence I have added it. As per your statement it is not necessary.


Update pirates to 4.0.4 to fix no entry problem

Related to issue #75

Cannot find module '/Users/Ritchie/Developer/@fastcms/fastcms/node_modules/.pnpm/<EMAIL_ADDRESS>Please verify that the package.json has a valid "main" entry

Ping @laozhu

Sorry, I forgot this issue, will deal with this pr tonight 😄

Codecov Report

Merging #12136 (2492320) into main (6d101e9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #12136   +/-   ##
=======================================
  Coverage   67.71%   67.71%
=======================================
  Files         328      328
  Lines       16991    16991
  Branches     4817     4817
=======================================
  Hits        11506    11506
  Misses       5452     5452
  Partials       33       33

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d101e9...2492320. Read the comment docs.


T13.1: Create GET endpoint that allows filtering ratings between “most helpful” and “most recent”

Closed with PR #75


[jtag_riscv_agent] Added driver and register adapter

Signed-off-by: Nigel Scales<EMAIL_ADDRESS>

Builds with VCS and Xcelium.
Not tested yet.

I've tested it with  lc_ctrl.
I've cross merged this branch into lc_ctrl_jtag_csr and after demoting the register model warnings about field accesses csr_rw passes using JTAG.
To try add --run-opts +jtag_csr=1 to the command.
Currently this will replace the register adapter for default_map.

@weicaiyang
I've redone it without the queue because I want to be able to terminate the process easily if we get a reset.
You're right it wasn't needed.

I left quite a few comments. Please amend existing commits directly rather than creating new commits. You can follow these steps:
git checkout jtag_riscv_driver # If not already in this branch
git rebase -i master

# This will open a text editor with the 3 commits
# Replace 'pick' with 'edit' to edit that particular commit.
# git-rebase will rebase each commit one-by-one starting
# from the top and perform the action. If commit is marked
# as edit, then it will stop the rebase to let you amend the
# the commit. Address the review comments for that particular
# commit. Once done:
git add -u # Add the updated files. DO NOT EDIT anything other than review comments.
git commit --amend # Amend this commit.
git rebase --continue

# git-rebase will continue and stop at the next commit marked
# for editing. Address the comments for this commit and
# follow the steps above to move on to the next.

I left quite a few comments. Please amend existing commits directly rather than creating new commits. You can follow these steps:
git checkout jtag_riscv_driver # If not already in this branch
git rebase -i master

# This will open a text editor with the 3 commits
# Replace 'pick' with 'edit' to edit that particular commit.
# git-rebase will rebase each commit one-by-one starting
# from the top and perform the action. If commit is marked
# as edit, then it will stop the rebase to let you amend the
# the commit. Address the review comments for that particular
# commit. Once done:
git add -u # Add the updated files. DO NOT EDIT anything other than review comments.
git commit --amend # Amend this commit.
git rebase --continue

# git-rebase will continue and stop at the next commit marked
# for editing. Address the comments for this commit and
# follow the steps above to move on to the next.

To make this simpler - please squash the 3 commit into a single commit. All these updates belong to a single commit, as the PR title suggests.

@sriyerg
What I've done before is squash the commits on the final PR merge.
All scripted by GitHub.
Expecting git newbies to do rebasing is a bit of a stretch.
The chances of it going wrong are very high.

@NigelScales: You're right that it would be unwise to trust beginning contributors not to mess up git rebasing. Which is why we don't merge things before we've taken a look at the changes. We do allow PRs with multiple commits: this is sometimes exactly what you want to appear in the eventual log. This means we wouldn't want an "auto-squash" feature like you're describing.

@rswarbrick
I'm not too bad at git but I've never used rebase.
I've managed to get by with merge.

@sriyerg it now appears this branch is now unmergeable.
I think this is due to re-writing history.
From now on I'm going to avoid that and rely on a final squash merge when you merge the PR.

@sriyerg it appears this branch is now unmergeable. I think this is due to re-writing history. From now on I'm going to avoid that and rely on the final squash merge when you merge the PR.

I've done a
git reset --hard
git push -f
To get back to a mergeable state.

@sriyerg
I can't merge this I don't have write permissions.

@sriyerg I can't merge this I don't have write permissions.

@NigelScales yes, only the people in this list can approval and merge the PR.
there are still a few unaddressed comments. Can you click the file changed tab and take a look? Looks like those comments can be addressed very quickly. Once those are done, I can merge the PR.

Hi Guys,
I'm happy with the code as is - it works and I have no more time to spare on it..
Can we get this merged please it's needed for the next PR.


Use secure repository url

Should be obvious

@jbonofre - This can be closed, already fixed in 'b65797245b'