[9.x] Handle custom formatted date and datetime attributes casts distinctly

Closes https://github.com/laravel/framework/issues/46737

Tests fail - likely indicating this is a breaking change.

Tests fail - likely indicating this is a breaking change.

Yes, looking into this more.

The expected output:
Array &0 (
    0 => '2019-10-01'
    1 => '2019-10-01 10:15:20'
    2 => '2019-10-01'
    3 => '2019-10-01 10:15'
)

versus the actual output (from the changes in this MR):
Array &0 (
    0 => '2019-10-01 00:00:00'
    1 => '2019-10-01 10:15:20'
    2 => '2019-10-01 00:00:00'
    3 => '2019-10-01 10:15:00'
)

To me, that seems pretty harmless and easy enough to fix (just modify the test case so that it's always including the timestamp, whether or not they will be cut off by the DB engine)
If we want to change the code to fix the issue identifier AND not include extraneous time for a date field, then it's a bigger lift.
There's a lot going on here... if I have a custom format within my model... shouldn't I be able to set the date as a string of that format?
class User extends Model
{
    protected $casts = [
        'custom_date' => 'date:m-d-Y',
    ];
}

$user = new User(['custom_date' => '12-30-2023']);
$user->save(); // throws an exception for the date format being wrong

The problem would be that making a change like this would either have to enforce all dates are of the format specified within the cast OR some kind of indication that you want to be able to receive them in that format.
Option one would definitely be a breaking change, and option two seems kind of like bad developer experience.

@taylorotwell I'm not really sure there's an easy path to fix this.
Right now, the HasAttributes@setAttribute() will never work if you have the date in a format other than Y-m-d (or a variant like Y-m) unless you explicitly pass the date in the format you want it stored in.
class SomeModel extends Model
{
    protected $casts = [
        'date_field' => 'date:m-d-Y',
    ];
}

SomeModel::create(['date_field' => '12-30-2000']); // blows up because the attribute is stored as-is "12-30-2000"
SomeModel::create(['date_field' => '2000-12-30']); // works fine, though it doesn't match the cast

I would say this is clearly not the intended behavior, but even the test cases that this PR broke were inserting the dates in a format that didn't match with the cast. (TestModel1::create(['date_field' => '2019-10-01'] works but TestModel1::create(['date_field' => '2019-10']), which matches the model's date_field cast, fails)
We would could potentially do some juggling like:
public function setAttribute($key, $value)
{
    //...
    elseif (! is_null($value) && $this->isDateAttribute($key)) {
        if (! $this->isStandardDateFormat($value)) {
            $dateFormat = explode(':', $this->getCasts()[$key], 2)[1];
            try {
                $value = Date::createFromFormat($dateFormat, $value);
            } catch (InvalidFormatException $exception) {
                $value = new Date($value);
            }
        }
        $value = $this->fromDateTime($value);
    }
    //...
}

But I'm not entirely sure it's worth it, nor do I think it would be a solution that would hit the mark (and adds overhead to this frequently used functionality).
Either that or we force the user to always insert the date in the format of the cast... but I'm sure that's a major breaking change.
It's probably worth adding in the docs something about this behavior unless there's a better plan for how to fix it.

Just my two cents here, but from the documentation it seems like:

the attribute on the model instance is a Carbon instance
when read as a string it would format using the format in $casts
when set on the model instance it should be either a Carbon/Datetime instance or a string in the format defined in $casts
when reading the attribute to use in the SQL query it should format according to the column type format (or the format set in the model's $dateFormat).

In other words, the $casts property seems to only involve how attributes are formatted on the model instance and/or array/JSON representation, and not influence how it is written in the database query. I mean, choosing the format to use in the database table is already done in the migration. Or am I interpreting this wrong?

@cosmastech Taylor doesn't sees draft PRs. Please mark as ready if you want to get feedback.

The docs do seem to indicate the format is only to control how the dates are serialized when converting the model to arrays or JSON:

The docs do seem to indicate the format is only to control how the dates are serialized when converting the model to arrays or JSON:

For now I don't think we'll take any action here.

That is true, but it should not interfere with how it is stored in the database, according to this part of the docs. But that is the case in the bug report scenario.


Tests are producing false positives

some tests are even passing when the expects are changed. Following example will pass
it('Guest to view blogs', () => {
   acl.allow('guest', 'blogs', 'view', (err) => {
      expect(!err);
      expect(err);
   });
});

It seems that expect is used incorrectly in the tests.
Correct code should look like this:
it('Guest to view blogs', () => {
   acl.allow('guest', 'blogs', 'view', (err) => {
      expect(err).toBeNull();
  });
});

Hello @matthiaseigner,
Do you to propose a pull request ?

Yes, i'm currently working on it.

You rock ! 👍
I'm waiting for it to include it into the next release #33.

After changing all expects all the tests succeeded for the stores ['Memory', 'Redis', 'MongoDB'] but 3 tests failed for 'MySQL'.
The three tests are:

Can jsmith edit blogs
Can<EMAIL_ADDRESS>edit blogs
Can userId=1 edit blogs?

The tests expect the user to have the permission edit for the resource blogs.
All three users have just one role ['member'] which actually has no permissions to edit blogs.
The only permissions in the db for blogs are
allows_blogs | {"guest":["view"],"foo":["edit","view"],"bar":["view","delete"],"admin":["*"],"fumanchu":["get"]}

Am i missing something or are these tests wrong?

In first, thank you for your work it's really nice / useful.
I think the problem is the MySQL store. I'll create a new issue to investigate this point but without checking the code, it's a MySQL store bug for me.

Hello @matthiaseigner,
I'm closing this issue, all test are now more strict. There are no more false positives.


Update jackson-module-scala to 2.11.3

Updates com.fasterxml.jackson.module:jackson-module-scala from 2.11.2 to 2.11.3.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.fasterxml.jackson.module", artifactId = "jackson-module-scala" } ]

labels: library-update, semver-patch

Codecov Report

Merging #801 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #801   +/-   ##
=======================================
  Coverage   82.80%   82.80%
=======================================
  Files          73       73
  Lines        5404     5404
  Branches      146      146
=======================================
  Hits         4475     4475
  Misses        929      929

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af241ed...32812f2. Read the comment docs.


Provide a breakdown of the example processing code for new users

This could potentially be done in a Jupiter notebook

Added explanatory comments to processingExample.py
This example file is also shown in the docs:
https://magsonify.readthedocs.io/en/latest/src/exampleCode.html


Shouldn't Ellipse's width & height be radius * 2f to match the original circle?

Hello! I happened to notice that when I use ellipse constructed with a circle, the real area of the shape became smaller.
I changed constructor Ellipse(Circle) and Ellipse.set(Circle). Shouldn't Ellipse's width & height be radius * 2f to match the original circle?

Yup!

This should probably go into CHANGES as it will probably break someones code.


Responsed with "Post not found"

Maybe need to handle the deleted post.

Handled by https://github.com/leVirve/dcard-spider/commit/261ba31288eae4db777f1ac3c5944fa369665bc8#diff-cdb40338628d1ff631126b2714768dbfR38
closed.


See samtools 1.3 release:

The obsolete samtools sort in.bam out.prefix usage has been removed. If you are still using ‑f, ‑o, or out.prefix, convert to use -T PREFIX and/or -o FILE instead.

Could be nice to document this version constraint or would you be accepting a patch to update the script?

Hi,
Thanks for the heads up. We'll do both - document for now, and if any patches come our way we're happy to accept! :)


update homepage routing and redirects

#5362  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jnsdls and the rest of your teammates on  Graphite


fix 190 is the max the index takes with a utf8mb4 table

on mysql

I think this scheme of using composite natural primary keys is fundamentally flawed if MySQL enforces a limit on the length of the index.
Sure, you can say, "but keys/locales shouldn't be that long", but that's not really the point.
Is there a disadvantage to using a surrogate key? Actually, what is the point of having locale+key be the primary key to begin with? Is this because Gorm requires some kind of primary key? Or are you using it as a substitute for a unique index?

i think the main point is that the gorm struct tax syntax currently does not allow to define field and index independently - something that would translate to
CREATE TABLE `translations` (
    `key` varchar(255),
    `locale` varchar(255),
    `value` varchar(255) ,
    PRIMARY KEY (
        `key`(100),
        `locale`(100)
    )
);

or a unique version of that.

i think the main point is that the gorm struct tag syntax currently does not allow to define field and index independently

Is that going to be hard to fix? @jinzhu?

@bodhi no, gorm doesn't require that. the reason we are using multiple primary key is this could avoid duplicated translations, that has occurred for our Qor2 projects already.
So I want to using the unique index to fix that. (haven't thought about the limitation of index before ;( )
Do you have any better solution to do that? or just remove the unique index? that should works well.

i think the main point is that the gorm struct tag syntax currently does not allow to define field and index independently - something that would translate to

@fvbock gorm does support that, will it resolve the problem if we do that?

just remove the unique index? that should works well.

Assuming you mean validating the uniqueness in the application instead? That will open up race conditions that will allow duplicate keys. The way to prevent it is to have a unique index in the database.

we are using multiple primary key is this could avoid duplicated translations

Right. But there is no reason for this to be a primary index, it just needs to be unique.
That said, its is kind-of moot anyway, as:

By default, an index key for a single-column index can be up to 767 bytes. The same length limit applies to any index key prefix. See Section 13.1.13, “CREATE INDEX Syntax”. For example, you might hit this limit with a column prefix index of more than 255 characters on a TEXT or VARCHAR column, assuming a UTF-8 character set and the maximum of 3 bytes for each character. When the innodb_large_prefix configuration option is enabled, this length limit is raised to 3072 bytes, for InnoDB tables that use the DYNAMIC and COMPRESSED row formats.

So you can't do both of these on MySQL :

Support arbitrary-length keys
Ensure uniqueness of keys per locale

(Also, seems that the max length on Postgres is 8191).


[FLINK-19311][coordination] Add ResourceRequirement(s)

ResourceRequirement(s) describe the resource requirements for a single job, and will be used for on both the JM and RM side for resource management as well as RPC messages.
Front-loading this change because it is used by multiple processes and essentially locked in code-wise.

Chime in with a minor comment:

The Serial Version UID for new classes should start at 1.
Suggested by the code style guidelines.
https://flink.apache.org/contributing/code-style-and-quality-java.html#java-serialization

@xintongsong Do you know by chance how to setup IntelliJ to use 1 as the default UID?

@zentol I don't find a way, either.


fix(esl-carousel): fix incomplete centered carousel rendering

Change looks safe enough, agreed for quick beta release

:tada: This issue has been resolved in version 5.0.0-beta.30 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Widget stop working when dragging a node outside of the layer

STR

Create a points layer
Add a category widget to a column.
Add a sample analysis to the layer.
Add a Spatial Cluster analysis to the layer.
Add a Centroid analysis categorized by cluster_no.
Go to the layer list and drag the top node outside.
Click on autostyle on the widget you added at the beginning.
It fails. It says that the column selected previously doesn't exist. Looks like it is pointing to the wrong node.

If you add the widget back again, pointing to the original node it works.

@xavijam, can we prioritize this to the next sprint?

Ok, let me check mine and I'll include it in the priority list

I've checking the definition that we send to the maps api and it looks correct. In fact, if you unselect the autostyling and move the map, widget is updated correctly and works great (even filtering for any of those items).

I can't say 100% sure where the problem is, but I'll take a look with @rochoa or @dgaubert as soon as possible.

Following the STR described by @saleiva the Map instantiation fails because the auto-style is being sent for the clusters layer, and not for the one with the original data, that's the one we linked the widget to.

Working properly thanks to this PR 💃  \o/.
https://github.com/CartoDB/cartodb/pull/10114


[WIP] Add bStats as a metrics service, implements #658

Info
As explained in #658 bStats is basically the replacement for mcstats.org.
This pr implements the metric service for all 3 platforms and also adds a custom chart to track protocol versions of connected players.
You will have to sign up @ bstats.org, add the plugin and configure the custom graph (its a 'Advanced Pie' named 'protocol_versions'), see here and here
What data will be send?
From bStats.org:
By default, bStats sends the following data:
- Your server's randomly generated UUID
- The amount of players on your server
- The online mode of your server
- The bukkit version of your server
- The java version of your system (e.g. Java 8)
- The name of your OS (e.g. Windows)
- The version of your OS
- The architecture of your OS (e.g. amd64)
- The system cores of your OS (e.g. 8)
- bStats-supported plugins
- Plugin version of bStats-supported plugins

this PR will additional send the protocol version of all connected players.
All data collection can be disabled by the server admin by opting out in the bStats config: plugins/bStats/config.yml
Status
This PR is currently completely untested as I cannot build via (see gitter).
Once that is fixed, I need to test all platforms with multiple versions.
I am also unsure if the relocation works like that. Needs testing once I can build.

oh yeah, ill rebase and test stuff later today.

My opinion about it:
It's currently not possible to disable it. Not everyone likes to have it enabled.
I never really like to have built-in metrics, but that's me.
It's up to @MylesIsCool to implement it or not :)

as I mentioned, you can disable it globally for the whole server, but I don't mind adding an option in the config to disable it.

@MiniDigger Ah sorry, I missed that (:

We've taken the decision to decline this PR, see the related issue for further explanation, #658.


I want to show some message as progress scroll moves.The message should be on progress scroll only.

Hey, thank you for testing and contributing to wavesurfer.js!
Please make sure you can check all of these points below before opening an issue:
(You don't have to post this section)

[x] I have checked the FAQ and it doesn't solve my problem.
[ ] I have checked the documentation and it doesn't solve my problem
[x] I have searched for already open issues which desribe my problem.
[ ] The issue I'm having is related to and caused by wavesurfer.js, not by other software (which maybe packages and uses wavesurfer incorrectly) – In that case you should open the issue on the respective project pages.

Please make sure you provide the following information (if applicable):
Wavesurfer.js version(s):
Browser and operating system version(s):
Code needed to reproduce the issue:
(Please reduce your code as much as possible and only post the minimum code needed to reproduce the issue. A Code pen is an excellent way to share such code)
Use behaviour needed to reproduce the issue:

Please open tickets with a full description.


Need example of dynamic data

How would I get real weather data into the Weather Example?
For example, I would like to show today's date and current temp.  This will most likely be retrieved by a HTTP call before rendering the card.
{
 "type": "TextBlock",
 "text": "**Monday April 1**",
 "size": "large"
},
{
 "type": "TextBlock",
 "text": "63 / 42",
 "size": "medium",
 "separation": "none"
}

Hi @iwaldman,
There is a blog post here: https://blog.botframework.com/2017/06/07/Adaptive-Card-Dotnet/ describing how to use a 3rd party weather service to show the forecast in a bot using Adaptive Cards.
Here is the corresponding .net project: https://github.com/EricDahlvang/AdaptiveCards-WeatherBot
Here is a node project that does the same: https://github.com/nwhitmont/botframework-luis-adaptive-cards-weather-example
Here's another node sample with some dynamic cards: https://github.com/Microsoft/BotBuilder-Samples/blob/master/Node/cards-AdaptiveCards/app.js
I hope this helps.

Ok, that is what I was thinking.  I will pursue that route.  Thank you.


Make SPA has its own ContentCatalog

In smartedit integration phase 1, I created a new site "electronics-spa" and catalogs (electronics-spaContentCatalog:Staged and electronics-spaContentCatalog:Online)
Before we start smart edit integration phase 2, it is better that SPA has its own cms data. So, we need synchronize the electronics-ContentCatalog into electronics-spaContentCatalog.
spaacceleratorsampledataaddon will only update the electronics-spaContentCatalog. So, in smart edit, we can see 2 sites. Users edit cms items in one site will not affect the other site.
Now, only one site used by both SPA and electronic storefront.

SPA will have its own Cms data; but ProductCatalog still be shared.

Impex to create sync job:
### sync electronicContentCatalog:staged to spaContentCatalog:staged
$syncJob=sync $contentCatalog:Staged->$spaContentCatalog:Staged
$sourceContentCV=sourceVersion(catalog(id[default=$contentCatalog]),version[default='Staged'])[unique=true,default='$contentCatalog:Staged']
$targetContentCV=targetVersion(catalog(id[default=$spaContentCatalog]),version[default='Staged'])[unique=true,default='$spaContentCatalog:Staged']

INSERT_UPDATE CatalogVersionSyncJob;code[unique=true];$sourceContentCV;$targetContentCV;syncPrincipals(uid)[mode=append];syncPrincipalsOnly[default=false];removeMissingItems;createNewItems;rootTypes(code)[mode=append]
;$syncJob;;;cmsmanagergroup,electronics-cmsmanagergroup;;true;true;CMSItem,CMSRelation,Media,MediaContainer

### sync spaContentCatalog:staged to spaContentCatalog:online
$spaSourceContentCV=sourceVersion(catalog(id[default=$spaContentCatalog]),version[default='Staged'])[unique=true,default='$spaContentCatalog:Staged']
$spaTargetContentCV=targetVersion(catalog(id[default=$spaContentCatalog]),version[default='Online'])[unique=true,default='$spaContentCatalog:Online']
INSERT_UPDATE CatalogVersionSyncJob;code[unique=true];$spaSourceContentCV;$spaTargetContentCV;
;sync spaContentCatalog:Staged->Online;;;;

Not sure how much you know about multi-country CMS? That module allows to support a hierarchy of content catalogs. We could evaluate this as an alternative, as duplicating 99% of the CMS data isn't great. Moreover, we need to do something similar as soon as we move into multiple sites.
We have a number of improvements in mind when it comes to the site structure (pages, tempates, slots). If we go down this route, I'd like to be involved.

I know how multi-country CMS work :). Actually, I follow the same way. The new catalog I created is a sub catalog of electronic-ContentCatalog. But, it is empty. In smart edit, if you select one multi-country site (e.g. Electronic Site US), in Pages, there is nothing.

You must add both content catalogs to the cms site; the sub catalog structure was added later, but I believe both content catalogs must be connected anyway. The idea would be that only changes would add up in the spartacus specific content catalog. We could have alternative page(template)s, overridable slotes, custom components, etc.

PR is here: https://stash.hybris.com/projects/C3PO/repos/spacceleratorsamplesaddon/pull-requests/8/overview

install spacceleratorsamplesaddon
initialize the system
in projects/core/src/occ/config/default-occ-config.ts, change to baseSite: 'electronics-spa'


[Bug]: I can't get the generated walletConnect uri

Current Behavior
When I open the modal I see in the console generated walletConnect uri but I can't get it because I want to use it another way
Expected Behavior
I want to somehow get the generated walletConnect uri and use it.
Steps To Reproduce

click connect
choose walletConnect
see the URI in the console but don't know how to get it

What package is effected by this issue?
@web3-onboard/react
Is this a build or a runtime issue?
Runtime
Package Version
"@web3-onboard/react": "^2.6.2",     "@web3-onboard/walletconnect": "^2.2.2",
Node Version
16.14.0
What browsers are you seeing the problem on?
Chrome
Relevant log output
wc:0d67c4bd-e4b5-4871-aea5-1dcbcb35ebc6@1?bridge=https%3A%2F%2Fu.bridge.walletconnect.org&key=508301c45cba6d6d76dff9b5d02d2b026a6f564961e108d707977fc1051aa97b

Anything else?
No response
Sanity Check

[X] If this is a build issue, I have included my build config. If this is a runtime issue, I have included reproduction steps and/or a Minimal, Reproducible Example.

Hi @YordanMarchev - there is a Copy To Clipboard option at the bottom - is this what you are looking for?
Also important to note WalletConnect V1 is being sunset at the end of this month and will no longer be supported by the WC team.
We have worked with there team to create an alpha(2.3.0-alpha.2) release of the wallet connect package that can be easily configured to support WC V2 - please see<EMAIL_ADDRESS>Official release will come out within the next 2 weeks after WalletConnect v1 deprecation

Hi @Adamj1232
This is not my case
My case is that when the user is open the app from the phone I want to redirect him with a deep link without scanning the qr-code
But I need somehow to get the URI in the code and add it to the redirect url

So my question is:
Can I somehow get the generated URI in the code and redirect the user without seeing the QR code?

@YordanMarchev I will check with the WC team for a V2 implementation.
This can be done in WalletConnect V1 but that is being sunset in 2 weeks so wouldnt be much help.

@Adamj1232 yea, it's will be better to have it in version 2

@Adamj1232 Do you have some new information?

Can you describe the use case for passing the wallet URI out of web3-onboard to better understand the feature request?

Hey @Adamj1232, we have a mobile wallet that we want to connect to a dApp that we're developing. The dApp will be accessed through a mobile phone, using an in-app browser from the mobile wallet. To connect the wallet to the dApp, the user needs to click on the "Connect wallet" button and choose wallet-connect. We aim to get the URI and make a deep link between the mobile wallet and the dApp without displaying the QR code.

Hey @kraikov thank you for your patience!
I have chatted with the team and we have a plan for a path forward. We will add a walletconnect module init option that will accept a function to handle/pass the walletconnect uri - this is the most dynamic and flexible path and can maintain our current patterns and avoid further eventEmitters - does this sound good to you?

So the function will be called by you guys and the function will receive the uri? That would be ideal <3

@kraikov yep you got it! Will have a PR to share shortly


Document single BeforeClose event for Window

See related issue: cuba-platform/cuba#1138

@knstvk please take a look at API description


SchemaID is a valid property and isn't defined in the list of properties but is used in an example.

Furthermore, in previous versions of SQL owner_name(object_property(@id, 'OwnerID')) reliably returned the schema.  Now you would need to use schema_name(object_property(@id, 'SchemaID)).

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ce794da2-d198-5e15-22f4-39d65cbd933b
Version Independent ID: c5c04b03-3250-498a-7d56-64660a79ea60
Content: OBJECTPROPERTY (Transact-SQL) - SQL Server
Content Source: docs/t-sql/functions/objectproperty-transact-sql.md
Product: sql
Technology: t-sql
GitHub Login: @MikeRayMSFT
Microsoft Alias: mikeray

@estimpson Hi Eric, thank you for your feedback.
@MikeRayMSFT Hi Mike, please process this Issue 2478.

Thanks for submitting this @estimpson - I'm going to add Schema ID right now. I'm going to need to clarify the ownerID functionality before I update that.

Excellent.  Looks great


Automated Package Upgrade

:tada: This PR is included in version 13.0.51 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Hide page menu (top CollectionView) when there's only single page

Is there anyway to hide the page menu (on the top) when there's only one page?
something like UIPageControl
hidesForSinglePage = true
seems PageView sets height constraint on page menu (the CollectionView) and i couldn't find a way to override that heightAnchor except subclassing PagingView and override the entire setupConstraints()

Hi @Maxlufs! There isn't any build in way of doing it, so you would have to create a PagingView subclass like you mentioned 🙂

Hi @Maxlufs ! I have done similar with my project, you'll have to set height of menu item to 0 when there's only one.
like this
pagingViewController.menuItemSize = .sizeToFit(minWidth: 120, height: self.items.count == 1 ? 0 : 40)
(@rechsteiner I think there's a built in way to do it like above code, I don't know if its a proper way or not)

@Pratik948 Thanks! menuItemSize works on initialization, but once it's set, I have failed to find other ways to update it. For example: re-setting menuItemSize wouldn't work in viewWillAppear()
What i'm looking for is basically hidesForSinglePage, a sample use case is dependent on if a user is logged in. If they are, show more tabs, if they are logged out, show one.

@rechsteiner would be really nice to have that feature if it's not to much of a change 😆

@Maxlufs I don't think this will be added as a built-in option to Parchment. It's not that it requires a lot of change, but Parchment would get quite bloated if we added configuration options for every specific use-case. The goal with Parchment is to keep it as generic as possible and rather provide the customisation hooks you need to create your own behaviour.
That said, I'll look into making the menu height update if you change menuItemSize after the first render.

Fixed it so that the menu height constraint is now updating when setting menuItemSize after the initial render: #449. This should allow you to hide the menu for single items 🙂 I don't really see the need for a custom property for that.
You have to target the master branch for now. Will release a new version soon

The new version is now released (v2.2.0) 🙂


make: "/root/aprx/Makefile" line 54: Missing dependency operator

Hey all! Trying to build aprx and getting this error.
make: "/root/aprx/Makefile" line 54: Missing dependency operator
make: Unknown modifier '%'
make: Unknown modifier '%'
make: "/root/aprx/Makefile" line 57: Need an operator
make: Unknown modifier '%'
make: Unknown modifier '%'
make: "/root/aprx/Makefile" line 60: Need an operator
make: Fatal errors encountered -- cannot continue
make: stopped in /root/aprx```

I'm on FreeBSD 12.1-RELEASE

thanks for reading!

show us the problem when compiling with make V=s

Like this?
make: "/root/aprx/Makefile" line 54: Missing dependency operator
make: Unknown modifier '%'
make: Unknown modifier '%'
make: "/root/aprx/Makefile" line 57: Need an operator
make: Unknown modifier '%'
make: Unknown modifier '%'
make: "/root/aprx/Makefile" line 60: Need an operator
make: Fatal errors encountered -- cannot continue
make: stopped in /root/aprx```

I'm running it on my Ubuntu machine and it shows no error. I don't have free BSD. This is my line 54: prepare: $(target/stamp-compile)
No % to be seen, nut I am not an expert.
Can you compile Openwrt without aprx  and without problems ?

Just to be sure..... THis is my Makefile
`# Makefile for OpenWrt

Copyright (C) 2007 OpenWrt.org

This is free software, licensed under the GNU General Public License v2.
See /LICENSE for more information.

TOPDIR:=${CURDIR}
LC_ALL:=C
LANG:=C
TZ:=UTC
export TOPDIR LC_ALL LANG TZ
empty:=
space:= $(empty) $(empty)
$(if $(findstring $(space),$(TOPDIR)),$(error ERROR: The path to the OpenWrt directory must not include any spaces))
world:
export PATH:=$(TOPDIR)/staging_dir/host/bin:$(PATH)
ifneq ($(OPENWRT_BUILD),1)
_SINGLE=export MAKEFLAGS=$(space);
override OPENWRT_BUILD=1
export OPENWRT_BUILD
GREP_OPTIONS=
export GREP_OPTIONS
CDPATH=
export CDPATH
include $(TOPDIR)/include/debug.mk
include $(TOPDIR)/include/depends.mk
include $(TOPDIR)/include/toplevel.mk
else
include rules.mk
include $(INCLUDE_DIR)/depends.mk
include $(INCLUDE_DIR)/subdir.mk
include target/Makefile
include package/Makefile
include tools/Makefile
include toolchain/Makefile
$(toolchain/stamp-compile): $(tools/stamp-compile)
$(target/stamp-compile): $(toolchain/stamp-compile) $(tools/stamp-compile) $(BUILD_DIR)/.prepared
$(package/stamp-compile): $(target/stamp-compile) $(package/stamp-cleanup)
$(package/stamp-install): $(package/stamp-compile)
$(target/stamp-install): $(package/stamp-compile) $(package/stamp-install)
check: $(tools/stamp-check) $(toolchain/stamp-check) $(package/stamp-check)
printdb:
@true
prepare: $(target/stamp-compile)
clean: FORCE
rm -rf $(BUILD_DIR) $(STAGING_DIR) $(BIN_DIR) $(OUTPUT_DIR)/packages/$(ARCH_PACKAGES) $(BUILD_LOG_DIR) $(TOPDIR)/staging_dir/packages
dirclean: clean
rm -rf $(STAGING_DIR_HOST) $(STAGING_DIR_HOSTPKG) $(TOOLCHAIN_DIR) $(BUILD_DIR_BASE)/host $(BUILD_DIR_BASE)/hostpkg $(BUILD_DIR_TOOLCHAIN)
rm -rf $(TMP_DIR)
ifndef DUMP_TARGET_DB
$(BUILD_DIR)/.prepared: Makefile
@mkdir -p $$(dirname $@)
@touch $@
tmp/.prereq_packages: .config
unset ERROR;
for package in $(sort $(prereq-y) $(prereq-m)); do
$(_SINGLE)$(NO_TRACE_MAKE) -s -r -C package/$$package prereq || ERROR=1;
done;
if [ -n "$$ERROR" ]; then
echo "Package prerequisite check failed.";
false;
fi
touch $@
endif
check prerequisites before starting to build
prereq: $(target/stamp-prereq) tmp/.prereq_packages
@if [ ! -f "$(INCLUDE_DIR)/site/$(ARCH)" ]; then
echo 'ERROR: Missing site config for architecture "$(ARCH)" !';
echo '       The missing file will cause configure scripts to fail during compilation.';
echo '       Please provide a "$(INCLUDE_DIR)/site/$(ARCH)" file and restart the build.';
exit 1;
fi
checksum: FORCE
$(call sha256sums,$(BIN_DIR),$(CONFIG_BUILDBOT))
diffconfig: FORCE
mkdir -p $(BIN_DIR)
$(SCRIPT_DIR)/diffconfig.sh > $(BIN_DIR)/config.seed
prepare: .config $(tools/stamp-compile) $(toolchain/stamp-compile)
$(_SINGLE)$(SUBMAKE) -r diffconfig
world: prepare $(target/stamp-compile) $(package/stamp-compile) $(package/stamp-install) $(target/stamp-install) FORCE
$(_SINGLE)$(SUBMAKE) -r package/index
$(_SINGLE)$(SUBMAKE) -r checksum
.PHONY: clean dirclean prereq prepare world package/symlinks package/symlinks-install package/symlinks-clean
endif
`

@videobuff Heres mine,  Im not a huge expert either. The build process should be the same for unix as well as linux?

Not sure how id compile openwrt on its own.

I suspect you're using make when you should be using gmake instead (devel/gmake)

I think you're right, im actually installing gmake right now, I noticed on the top of the makefile it said it used gnu bits and bops, lets see if gmake works.

Yep, that was the issue. Installed gmake pkg install gmake and used gmake in place of make and it worked fine.


webview: api to get host browser window

Fixes #4481

We can provide a new API to get the WebContents of webview, and then a new API to get the host WebContents from it. Users can then use BrowserWindow.fromWebContents to get the window.
This is more complicated than a single getOwnerBrowserWindow API, but more general.

Have added a method on webview to retrieve its webcontents and added a property to WebContents to retrieve its embedder if available.

:+1:


How can I get the profit of a binary option?

Hi, I would like to get something like:
api.getProfit("EURUSD") -> return: 71%
Can I use getMarketData?

Hi, any update?

You have 2 ways. At "api_option_init_all_result" JSON response you have msg['binary']['actives'][#]['option']['profit']['comission']
So, you get profit from it. Profit = (100-comission).
But sometimes the value change. So, they have JSON ''active_comission_change"
So, you can't just ask to iqoption, but you can get these values when they are available.

Hi, good night. Where can I find “active_comission_change”? And how to get this JSON to know the real profit value?

They send to you automatically. You just need to filter on ws/client.py.
The name is activeCommissionChange, not active_comission_change. My bad.

okay, thanks. Is is possible to take the profit of 1+ min, instead of 5+ min?

@lucianopinheiro
Could you give me the exact code you used to get the profit?
I've been trying to understand what you have said, but I can't find anyway to implement it
Any help would be greatly appreciated
thank you in advance
Also, how do you distinguish which Option you want to get the profit from?
Up until now I've been placing orders in order to get the profit value, which means I'm losing money which isn't very good!

@LeonardoRk
Have you figured it out yet?
Please if you have, can you respond to my request for the code.
Thank you in advance

My code probably don't work on files. Anyhow, they changed something again. I am a little far from code, and look like they have a new message instead of (or beside) api_option_init_all_result, called front. So, I can give you some pieces of code
At begginning:
At iqoptionapi/client.py
	def on_message(self, message):
		[...]
		elif message["name"] == "api_option_init_all_result": # ok 2018-04
			self.api_option_init_all_result(message["msg"])

At  iqoptionapi/messages/api_option_init_all.py
	if msg["isSuccessful"]:
		turbo = msg["result"]["turbo"]
		turbo_actives_all = turbo["actives"]

		for taa in turbo_actives_all:
			act = turbo['actives'][taa]
			active = Active(int(taa), act['name'].replace('front.', ''))
			active.gain = 100 - act['option']['profit']['commission']

===========
When it change.
At iqoptionapi/client.py
		elif message["name"] == "activeCommissionChange":
			self.api.active_commission_change(message["msg"])

At iqoptionapi/active_commission_change.py
def ActiveCommissionChange(active, msg):
	"""Change commissions from actives.
	Commition is the value IqOption get if you win.
	gain = 100 - commission"""
	if msg["option_type"] == 3:
		active.gain = 100 - msg["commission"] # turbo!

@lucianopinheiro
Thanks for the reply.
I managed to get the commission and stumbled onto a new issue. The program doesn't give you any indication as to when your stock is sold.
I managed to make $2 last night using automatic trading, but my program had no way of telling me when I made a gain or a lose so it was basically blind betting :D
Any ideas for what I can do to fix that? I would like to be a billionaire as soon as possible please

Could you give me the exact code you used to get the profit?
I've been trying to understand what you have said, but I can't find anyway to implement it
Any help would be greatly appreciated
thank you in advance
Also, how do you distinguish which Option you want to get the profit from?
Up until now I've been placing orders in order to get the profit value, which means I'm losing money which isn't very good!

Hi, I have this function in the modified file 'iqoption-api/api.py'
async def process_options_message(self,message):
binaries = message["msg"]["result"]["binary"]
print('ativos:')
for item in binaries["actives"]:
nomeDesformat = binaries['actives'][item]['name']
nomeMercado = nomeDesformat.replace("front.", "")
habilitado = binaries["actives"][item]["enabled"]
comissao = binaries["actives"][item]['option']['profit']['commission']
profit = 100 - comissao
if(habilitado):
self._mercadoProfit[nomeMercado] = profit
habilitado = None
    for boption in binaries["actives"].values():
        x  = BinaryOption(boption, self)
        self._options["binary"][x.name] = x
        self._id_to_option_name["binary"][x.id] = x.name

These lines
comissao = binaries["actives"][item]['option']['profit']['commission']
profit = 100 - comissao
inside the function above get the commission then the profit of the active itens.

I managed to make $2 last night using automatic trading, but my program had no way of telling me when I made a gain or a lose so it was basically blind betting :D

You have to study the response listInfoData. But it is a bit tricky, because you use it on 2 different ocasions. My code (on client.py) now:
		elif message["name"] == "listInfoData":	# operation result
			if int(message["msg"][0]["now"]) >= int(message["msg"][0]["expired"]):
				self.api.async_queue.put_listinfodata(message["msg"])
				if self.api.openorders > 0:
					self.api.openorders -= 1
			if message["msg"][0]["win"] != 'equal':
				if message["msg"][0]["win"] == 'win':
					value = message["msg"][0]["win_amount"] - message["msg"][0]["sum"]
				else:
					value = - message["msg"][0]["sum"]

What are the 2 different ocasions? kkkk

My code probably don't work on files. Anyhow, they changed something again. I am a little far from code, and look like they have a new message instead of (or beside) api_option_init_all_result, called front. So, I can give you some pieces of code
At begginning:
At iqoptionapi/client.py
	def on_message(self, message):
		[...]
		elif message["name"] == "api_option_init_all_result": # ok 2018-04
			self.api_option_init_all_result(message["msg"])

At iqoptionapi/messages/api_option_init_all.py
	if msg["isSuccessful"]:
		turbo = msg["result"]["turbo"]
		turbo_actives_all = turbo["actives"]

		for taa in turbo_actives_all:
			act = turbo['actives'][taa]
			active = Active(int(taa), act['name'].replace('front.', ''))
			active.gain = 100 - act['option']['profit']['commission']

===========
When it change.
At iqoptionapi/client.py
		elif message["name"] == "activeCommissionChange":
			self.api.active_commission_change(message["msg"])

At iqoptionapi/active_commission_change.py
def ActiveCommissionChange(active, msg):
	"""Change commissions from actives.
	Commition is the value IqOption get if you win.
	gain = 100 - commission"""
	if msg["option_type"] == 3:
		active.gain = 100 - msg["commission"] # turbo!

Where is the client.py file? I cannot find it. I was looking for 'activeCommissionChange' at 'incoming_message' function, but this name never arrived to me.

Where is the client.py file? I cannot find it. I was looking for 'activeCommissionChange' at 'incoming_message' function, but this name never arrived to me.

Sorry. It was another project. :)
The equivalent is the function that receives the JSON message on api.py:
on_socket_message(self,socket,message):
By the way, here I got no activeCommissionChange too. They changed something. Now, when I receive a new message, my system warns me, but today no message was received. I will look up to the new JSON message. On this system, you just need to enable this print (or better, change it to log) to watch new responses.
        else:
             print(message)
            pass

What are the 2 different ocasions? kkkk

When you receive the result for your option (win, loose, empty) and when you create your bet. But looks like they were replaced. Now we have 4 messages option-*: option-opened, option-rejected, option-closed, option-archived. But I have not studied them yet.

Where is the client.py file? I cannot find it. I was looking for 'activeCommissionChange' at 'incoming_message' function, but this name never arrived to me.

Sorry. It was another project. :)
The equivalent is the function that receives the JSON message on api.py:
on_socket_message(self,socket,message):
By the way, here I got no activeCommissionChange too. They changed something. Now, when I receive a new message, my system warns me, but today no message was received. I will look up to the new JSON message. On this system, you just need to enable this print (or better, change it to log) to watch new responses.
        else:
             print(message)
            pass

I could not find the function 'on_socket_message', i found 'processing_incoming_message' then i redirected all the raw_message to a log file. The only commission thing a found was in 'api_option_init_all_result' and only on login then never more. On google-chrome debug the message name is 'commission-changed' but this message never comes through the iqoption socket api.
Thank you for the answer (=

I found the solution to this problem quite some time ago but neglected to share it. let me make up for that by sharing it now and perhaps you can further help me by improving my code because it is a little noob, since I know almost nothing about python
Stock = iqoption.options["binary"]["EURUSD"]  if((Stock.is_enabled)):             profit=100-int(str(Stock.option).split(':')[2].split(' ')[1].replace(",",""))

Goof afternoon. What message do i need to subscribe in order to receive the 'commission-changed' message name? I receive many name messages, but not 'commission-changed'.


ws.onerror is not implemented (ws.on('error') is, though)

In<EMAIL_ADDRESS>I couldn't get any WebSocket client event listener to fire. According to the spec, there should be the EventListener properties onerror, onmessage, onclose and onopen, so it should work like this:
import WebSocket from "uws";
const client = new WebSocket("ws://localhost:1234");
client.onerror = e => console.log(e);

Note that at localhost:1234, there's no server running, so onerror should be called almost immediately and log an error event. Browsers and ws do this, uws does not.

I also observed that when calling close() on a WebSocket server instance and passing it a callback function, the callback never gets executed.

The onerror has not been implemented yet, while the on('error') has. So that should be fixed with time. Close has no callback, it will call the on('close') callback instead. You could probably "hack-solve" it by simply calling on('close', cb) when passing a cb to close.
But yes, the JS code is a bit unfinished / non-strictly ws compatible.

Two events handlers for this. May be it's not necessary to add a footprint in UWS for a hack that can be added into the user space by the rare persons who need it.

Well uws does not add the memory overhead of two handlers, it implements onerror and on('error') using the same memory. So this would not add any memory overhead. PR is welcomed.

@alexhultman I was going to PR this, but in looking at the source, wanted to kind of cleanup the events logic. Would something like that be welcome?
i.e.
        this._wrapListener('message', f ? message => f({data: message}) : null);
    }

    set onclose (f) {
        this._wrapListener('close', f ? (code, message) => f({code: code, reason: message}) : null);
    }

    set onerror (f) {
        this._wrapListener('error', f ? err => f(err) : null);
    }

    _wrapListener (event, f) {
        if (!f) return this._setListener(event, noop);
        this._listeners[event] = f;
    }

Sure. Rule is: do whatever you want as long as it doesn't add any memory or perf overhead (of hot path).

Scratch that. This change adds massive overhead

@alexhultman would you care to clarify? Are you referring to storing the listeners in an Object instead of directly on the instances themselves?

Yes any addition of JS data types results in significant penalties not only in memory usage

easily addressed with a minor tweak:
    _wrapListener (event, f) {
        let p = `internalOn${event}`;
        if (!f) return this[p] = noop;
        this[p] = f;
    }

I'm not a fan of adding dynamic lookup from string just to save a few lines of code. This function basically adds a dynamic indirection of string-to-function (even if this will never matter in real usage). It is a principle to not add overhead in exchange for neater code.

Fair enough, I disagree as setting listeners is not a hot code path, but it's not my project :)

I agree, it is not at all a hot path but my gut feeling is to stay as far away from anything dynamic as possible.

This sugar can be a mixin out of uws, like:
mixin.js
function onmessage(f) {
  if (f) {
    f = (message) => f({data: message});
  }

  this.on('message', f);
}

// onerror, onclose, ...
// ...
module.exports = function mixin(client) {
  onmessage = onmessage.bind(client);
  // onerror = onerror.bind(client);
  // ...

  Object.defineProperty(client, "onmessage", {
    get: onmessage,
    set: onmessage,
    writable : true,
    enumerable : true,
    configurable : false
  });
};

app.js
import WebSocket from "uws";
import browserLikeMixin from './mixin';

const client = browserLikeMixin(new WebSocket("ws://localhost:1234"));
client.onmessage = (e) => console.log(e.data);


Problem: logo doesn't link back to home

Resolved by https://github.com/Granola-Team/mina-block-explorer/pull/161


Parse error occurs when application/x-www-form-urlencoded

Before submitting the PR, please make sure you do the following

[ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[x] This message body should clearly illustrate what problems it solves.
[x] Ideally, include a test that fails without this PR but passes with it.

Tests

[x] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[ ] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

If the content-type is invalid encodeURI when application/x-www-form-urlencoded, the page fails to load due to an Uncaught URIError: URL malformed error.
Developers need to decodeUrlComponent themselves. I think.
test
Postman
Method: Post
Header
Content-Type: application/x-www-form-urlencoded
Body: raw
test=%2Furl%3Ftest%D111
result:
URIError: URI malformed
at decodeURIComponent ()
at file:///Users/dongheebae/Desktop/svelte-kit/my-app/node_modules/@sveltejs/kit/dist/ssr.js:1420:36
at Array.forEach ()
at get_urlencoded (file:///Users/dongheebae/Desktop/svelte-kit/my-app/node_modules/@sveltejs/kit/dist/ssr.js:1418:4)
at parse_body (file:///Users/dongheebae/Desktop/svelte-kit/my-app/node_modules/@sveltejs/kit/dist/ssr.js:1396:12)
at respond (file:///Users/dongheebae/Desktop/svelte-kit/my-app/node_modules/@sveltejs/kit/dist/ssr.js:1518:11)
at Immediate. (file:///Users/dongheebae/Desktop/svelte-kit/my-app/node_modules/@sveltejs/kit/dist/chunks/index.js:3336:29)
at processTicksAndRejections (internal/process/task_queues.js:93:5)

What other implications does this have? I guess this was added for a reason, so other things might break if it's omitted.

What other implications does this have? I guess this was added for a reason, so other things might break if it's omitted.

I think so.
When x-www-form-urlencoded, hook.ts can handle exceptions.
If you load a page at POST, there is a bug that does not open the page.
I actually tested it, but there was no problem.
In the same case as me, when externally sending data to the body in x-www-form-urlencoded, the codeUrl, the codeUrlComponent fails to open the page.
I think Sveltekit is being too kind.

What other implications does this have? I guess this was added for a reason, so other things might break if it's omitted.

How about this if I say it's a problem?
text .replace(/+/g, ' ') .split('&') .forEach((str) => { const [key, value] = str.split('='); let decodeKey = key; let decodeValue = value; try { decodeKey = decodeURIComponent(key); decodeValue = decodeURIComponent(value); } catch(err) { decodeKey = key; decodeValue = value; } append(decodeKey, decodeValue); });

Why not just do this:
/** @param {string} text */
function get_urlencoded(text) {
	const { data, append } = read_only_form_data();
	const params = new URLSearchParams(text);
	params.forEach((value, key) => append(value, key));

	return data;
}

It works exactly the same as the previous version, is faster (https://jsbench.me/xdkr18bycg/1), and doesn't break in your test case.

Why not just do this:

/** @param {string} text */

function get_urlencoded(text) {

	const { data, append } = read_only_form_data();

	const params = new URLSearchParams(text);

	params.forEach((value, key) => append(key, value));

	return data;

}

It works exactly the same as the previous version, is faster (https://jsbench.me/xdkr18bycg/1), and doesn't break in your test case.

Thank you for sharing the code with me. I'll send you a pr with that code. 👍

What should I do to approve this review? I'm waiting to use that function. Everyone, give me an answer.

Maybe you should add a test for it

PR을 제출하기 전에 다음 사항을 확인하십시오.

[ ] PR이 미리 논의된 문제를 언급하는 경우 정말 유용합니다. 많은 경우에 기능이 없는 이유가 있습니다. 큰 변경 사항의 경우 RFC를 생성하십시오: https://github.com/sveltejs/rfcs
[x]  이 메시지 본문은 어떤 문제를 해결하는지 명확하게 보여야 합니다.
[x]  이상적으로는 이 PR 없이는 실패하지만 함께 통과하는 테스트를 포함합니다.

테스트

[x] 함께 검사를 실행 pnpm test과 함께 프로젝트를 보풀 pnpm lint및pnpm check

변경 세트

[ ] PR이 하나 이상의 패키지 변경 로그에 기록해야 하는 변경을 pnpx changeset수행하는 경우 프롬프트를 실행 하고 따라 변경 집합을 생성합니다.

application/x-www-form-urlencoded 시 content-type이 잘못된 encodeURI인 경우 Uncaught URIError: URL malformed 오류로 인해 페이지가 로드되지 않습니다.
개발자는 자체적으로 UrlComponent를 디코딩해야 합니다. 나는 생각한다.
test
Postman
메서드: Post
Header
Content-Type: application/x-www-form-urlencoded
본문: raw
test=%2Furl%3Ftest%D111
결과 :
URIError의 : URI에서 조작
decodeURIComponent ()에서
36<EMAIL_ADDRESS>: 1,420 파일에
Array.forEach에서 ()
get_urlencoded(file:///Users/dongheebae/Desktop/svelte-kit/my-app/node_modules/@sveltejs/kit/dist/ssr.js:1418:4)
parse_body(file:///Users /dongheebae/Desktop/svelte-kit/my-app/node_modules/@sveltejs/kit/dist/ssr.js:1396:12)
응답 시(file:///Users/dongheebae/Desktop/svelte-kit/my- app/node_modules/@sveltejs/kit/dist/ssr.js:1518:11)
즉시. (file:///Users/dongheebae/Desktop/svelte-kit/my-app/node_modules/@sveltejs/kit/dist/chunks/index.js:3336:29)
processTicksAndRejections(internal/process/task_queues.js: 93:5)

Why not just do this:
/** @param {string} text */
function get_urlencoded(text) {
	const { data, append } = read_only_form_data();
	const params = new URLSearchParams(text);
	params.forEach((value, key) => append(key, value));

	return data;
}

It works exactly the same as the previous version, is faster (https://jsbench.me/xdkr18bycg/1), and doesn't break in your test case.

Why not just do this:
/** @param {string} text */
function get_urlencoded(text) {
	const { data, append } = read_only_form_data();
	const params = new URLSearchParams(text);
	params.forEach((value, key) => append(key, value));

	return data;
}

It works exactly the same as the previous version, is faster (https://jsbench.me/xdkr18bycg/1), and doesn't break in your test case.

It is slower as a result of trying that logic. I think I left out the forEach sentence at the end.

This whole thing doesn't make sense, not just the pr itself but the original code too:
text
     .replace(/\+/g, ' ')

There is no need to make this replacement since decodeURIComponent already does that.
Delegating the decoding to the developer doesn't fix the issue, and by default other frameworks decode the data before giving it to the developer, why should this case be different?
This issue doesn't even happen because its the framework's fault. It happens because someone made a mistake that resulted in incorrectly encoded urls. In that case, debug the code and find the root cause.
If the root cause is not on your code, report the bug to the developer of that code.

This whole thing doesn't make sense, not just the pr itself but the original code too:
text
     .replace(/\+/g, ' ')

There is no need to make this replacement since decodeURIComponent already does that.
Delegating the decoding to the developer doesn't fix the issue, and by default other frameworks decode the data before giving it to the developer, why should this case be different?
This issue doesn't even happen because its the framework's fault. It happens because someone made a mistake that resulted in incorrectly encoded urls. In that case, debug the code and find the root cause.
If the root cause is not on your code, report the bug to the developer of that code.

This whole thing doesn't make sense, not just the pr itself but the original code too:
text
     .replace(/\+/g, ' ')

There is no need to make this replacement since decodeURIComponent already does that.
Delegating the decoding to the developer doesn't fix the issue, and by default other frameworks decode the data before giving it to the developer, why should this case be different?
This issue doesn't even happen because its the framework's fault. It happens because someone made a mistake that resulted in incorrectly encoded urls. In that case, debug the code and find the root cause.
If the root cause is not on your code, report the bug to the developer of that code.

Okay, pass the encrypted value from the external framework to the website by post. The content-type passes to application/x-www-form-urlencoded, where the body value receives data as an encrypted value in their framework. So the website won't open and URIError: URL malformed error. Error.
Then I'll close this PR first.


negative polarities

Added negative polarities for "bad-ish" things, sorta loosely defined, feel free to tweak.
@bgyori -- this info can resolve the "pos/neg" affected stuff that we're now producing (i.e., from https://github.com/clulab/eidos/pull/740)
FYI @bnmin @MihaiSurdeanu

I guess may need to happen in the compositional one too.... ? thoughts?

Yeah... This sounds like a general enough contribution.
On Sat, Apr 25, 2020 at 10:12 AM Becky Sharp<EMAIL_ADDRESS>wrote:

I guess may need to happen in the compositional one too.... ? thoughts?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/WorldModelers/Ontologies/pull/68#issuecomment-619411560,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAI75TVVAZV4JQHW2AEW7STROMKWBANCNFSM4MQ2QTKQ
.

@BeckySharp , sorry for only getting to this now. Hadn't had the bandwidth to get to this on Monday, and was out yesterday.
I agree with all the negatives. Only the "waste" concept could be either positive or negative, depending on whether it is just "waste" or "waste removal". I'm going to merge this in anyways.


Ratelimit for quotas.

Changes proposed in this PR

Support for per-user per-pool quotas, specified via the /quota API and stored persistently.

Why are we making these changes?
Launch capacity can sometimes be a bottleneck resource in Cook. This lets us quota it among users so that it is shared mroe fairly. It also catches misbehaving Cook clients.

Will merge when green


Refactor CreateChoreoTaskBehavior

This module does not really conform with the style of behaviors as it is tailor made for dragging and dropping a choreo from the side bar. This leads to a bit of dublicated code and a constant exception making for copied choreos. Ideally this would not be necessary.

At that point we could also put some investigation into the $init functionality which is perhaps not necessary as dependencies can be derived from the constructor directly.


Vulnerability roundup 114: wasm3-0.5.0: 1 advisory [5.5]

search, files

[ ] CVE-2022-28966 CVSSv3=5.5 (nixos-21.11, nixos-unstable)

CVE details
CVE-2022-28966
Wasm3 0.5.0 has a heap-based buffer overflow in NewCodePage in m3_code.c (called indirectly from Compile_BranchTable in m3_compile.c).

Scanned versions: nixos-21.11: 3c5ae9be1f1; nixos-unstable: f419dc5763c.
Cc @malbarbo

See also: #155355, #138701

Marked vulnerable in 25dbfa36fd9c32fee1d15386cc358dfc3885bfd9.


Create extension for ISO/IEC ICS codes

Data available in: https://github.com/metanorma/iso-ics-codes

Development continues in https://github.com/paneron/extension-ics-codes.

Development continues in https://github.com/paneron/extension-ics-codes.


Upgrade Erlang R24 to <IP_ADDRESS>

Description of changes
This PR upgrades R24.nix to Erlang <IP_ADDRESS> (current edge of 24.x).
We are currently experimenting on adoption of nixpkgs for our development environment building. And Erlang 24 was one of our core dependencies.
As we observing the state of Erlang releases in nixpkgs-unstable channel, R25 was updated recently but R24 (which is the current default for Erlang in nixpkgs) was stale for a while.
Of course, we do not intend to pressure on mainteners, rather, we have found that we can create necessary PRs by ourselves and test-built them, so here it is!
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Comments
I'm opening this PR as draft since I'm planning to run build on another environment (especially on aarch64-darwin).
I have already run nixpkgs-review wip before commiting and got the following result:
$ nix-env --option system x86_64-linux -f /home/ymtszw/.cache/nixpkgs-review/rev-4b90397139936f93c0347848cb7db8a5e3f3d4d4-dirty/nixpkgs -qaP --xml --out-path --show-trace --meta
28 packages updated:
cl ejabberd elixir elixir elixir elixir elixir elixir-ls elvis-erlang erlang (24.2 → <IP_ADDRESS>) erlang_nox (24.2 → <IP_ADDRESS>) erlang-ls erlang_javac (24.2 → <IP_ADDRESS>) erlang_odbc_javac (24.2 → <IP_ADDRESS>) erlang_odbc (24.2 → <IP_ADDRESS>) erlfmt mercury mix2nix notmuch-bower plausible pleroma pleroma rabbitmq-server rebar rebar3 sonic-pi tsung wings

$ nix --experimental-features nix-command build --no-link --keep-going --option build-use-sandbox relaxed -f /home/ymtszw/.cache/nixpkgs-review/rev-4b90397139936f93c0347848cb7db8a5e3f3d4d4-dirty/build.nix
1 package marked as broken and skipped:
pleroma-otp

27 packages built:
cl ejabberd elixir elixir_1_10 elixir_1_11 elixir_1_12 elixir_1_9 elixir_ls elvis-erlang erlang erlang-ls erlang_javac erlang_nox erlang_odbc erlang_odbc_javac erlfmt mercury mix2nix notmuch-bower plausible pleroma rabbitmq-server rebar rebar3 sonic-pi tsung wings

Also, will check basic functionality of binary files as described above.

Another advice I want to hear is, should we provide other 24.x versions in-between?
In the current branch, I have bumped R24 from 24.2 to <IP_ADDRESS> directly.
In our experience Erlang 24 was mostly free of serious bugs between patches and builds, but some may find breaking change when advancing to <IP_ADDRESS>

@cw789 Hi Chris! And thank you for the encouraging reply!
Then I will continue test-building this PR and will open it up for review 🚀

Test-built on M1 mac and mostly looking similar to x86_64-linux, with fewer packages.

Result of `nixpkgs-review rev HEAD` on M1 mac:

22 packages built:
elixir elixir_1_10 elixir_1_11 elixir_1_12 elixir_1_9 elixir_ls elvis-erlang erlang erlang-ls erlang_javac erlang_nox erlang_odbc erlang_odbc_javac erlfmt mercury mix2nix plausible pleroma rabbitmq-server rebar rebar3 tsung

1 package marked as broken and skipped:
pleroma-otp

erlang and elixir related binaries in ./results are manual-tested and basic functionalities are looking fine. Opening up fore review.

Are there any more blockers pending to merge this? Seeing as Erlang/OTP 25.0.4 is already out already?

was updated in 56f026b029bfa3255489aac09e0c67e83ebb827f/#193566


mouse_capture_service.js has a  problem

lines 13 ：var $element = document;
var $element =  $(document);

Wow that's been there for a while! Thanks for spotting it.
Fixed in 033afa2.


Can I integrate an existing VPC/InternetGateway with the 'Document Understanding Solution' implementation rather than the stack creating these resources ?

How can I integrate an existing VPC/InternetGateway with the 'Document Understanding Solution' implementation rather than the stack creating these resources ?

@traian16, thank you for the feedback, we have incorporated your feedback in to our backlog. We plan to support VPCs in future releases.


Fuzzy search support

Thanks for your plugin!
Can I ask you if a fuzzy search support is planned?
The Lineage plugin for example has the ability to search with that by a button:

https://github.com/ycnmhd/obsidian-lineage

It isn't currently planned, but I like this suggestion.


DTS: generated output for each flash-controller

Problem to be solved
Currently flash-controller is generated only for zephyr,flash chosen node.
This causes problem when need to use DTS data form more than one flash controller at one.
For instance when we want to use flash-simulator driver (on qemu_x86), then need to chose its DT node. This imposes that its values are presented as DT_FLASH_* defines. As the result target has fake ROM size etc.
solution proposal
Generate substitute of flowing DT macros;
DT_FLASH_BASE_ADDRESS
DT_FLASH_ERASE_BLOCK_SIZE
DT_FLASH_WRITE_BLOCK_SIZE
DT_FLASH_SIZE
DT_FLASH_DEV_NAME

for each flash-controller node. Macros for chosen flash flash-controller might be duplicated.
Looks like generation of above values based on scripts hacks, not on yaml bindings - which makes it more difficult.
Context
Situation we have are source of issue signaled https://github.com/zephyrproject-rtos/zephyr/issues/15831 https://github.com/zephyrproject-rtos/zephyr/issues/15831#issuecomment-498771321

cc @anangl , @carlescufi , @galak , @ulfalizer , @b0661  Need someone to deal with this issue.

Are you looking for SOC_NV_FLASH defines to get generated for both flash nodes in qemu_x86.dts?

I see that there are SOC_NV_FLASH_xxx defines. But they are useless for this case as can't predict whether flash-simulator will have index 0 or 1 (SOC_NV_FLASH_0_xxx or SOC_NV_FLASH_1_xxx belongs to flash-sim).
What I want to have is unique defines for runing flash-simulator without chosen flash_sim0 node:
chosen {
		zephyr,flash = &flash_sim0;
	};

It sounds as if the flash simulator should have a different compatible then.

^^ Can you propose solution?

^^ Can you propose solution?

I'm still not clear on what the issue is, or what defines you need.

DT_FLASH_SIM_BASE_ADDRESS
DT_FLASH_SIM_ERASE_BLOCK_SIZE
DT_FLASH_SIM_WRITE_BLOCK_SIZE
DT_FLASH_SIM_SIZE
DT_FLASH_SIM_DEV_NAME

You have:
#define DT_SOC_NV_FLASH_0_BASE_ADDRESS                  0x0
#define DT_SOC_NV_FLASH_0_ERASE_BLOCK_SIZE              1024
#define DT_SOC_NV_FLASH_0_SIZE                          1048576
#define DT_SOC_NV_FLASH_0_WRITE_BLOCK_SIZE              4

For modified qemu_x86.dts
	chosen {
		zephyr,sram = &sram0;
		/*zephyr,flash = &flash_sim0;*/
		zephyr,flash = &flash0;
		zephyr,console = &uart0;
		zephyr,shell-uart = &uart0;
		zephyr,bt-uart = &uart1;
		zephyr,uart-pipe = &uart1;
		zephyr,bt-mon-uart = &uart1;
		zephyr,code-partition = &slot0_partition;
	};

	soc {
		eth0: eth@febc0000 {
			compatible = "intel,e1000";
			reg = <0xfebc0000 0x100>;
			label = "eth0";
			interrupts = <11 IRQ_TYPE_EDGE_RISING 3>;
			interrupt-parent = <&intc>;

			status = "okay";
		};
	};

	sim_flash {
		compatible = "zephyr,sim-flash";
		label = "FLASH_SIMULATOR";

		#address-cells = <1>;
		#size-cells = <1>;

		flash_sim0: flash_sim@0 {
			compatible = "soc-nv-flash";
			reg = <0x00000000 DT_SIZE_K(1024)>;

			erase-block-size = <1024>;
			write-block-size = <4>;
		};
	};

I've got in DTS product:
/* sim_flash */
#define DT_ZEPHYR_SIM_FLASH_0			1
#define DT_ZEPHYR_SIM_FLASH_SIM_FLASH_LABEL	"FLASH_SIMULATOR"
#define DT_INST_0_ZEPHYR_SIM_FLASH_LABEL	DT_ZEPHYR_SIM_FLASH_SIM_FLASH_LABEL
#define DT_ZEPHYR_SIM_FLASH_0_LABEL __DEPRECATED_MACRO DT_ZEPHYR_SIM_FLASH_SIM_FLASH_LABEL

/* flash_sim@0 */
#define DT_SOC_NV_FLASH_0				1
#define DT_SOC_NV_FLASH_0_BASE_ADDRESS			0x0
#define DT_SOC_NV_FLASH_0_ERASE_BLOCK_SIZE		1024
#define DT_SOC_NV_FLASH_0_SIZE				1048576
#define DT_SOC_NV_FLASH_0_WRITE_BLOCK_SIZE		4
#define DT_INST_0_SOC_NV_FLASH_BASE_ADDRESS		DT_SOC_NV_FLASH_0_BASE_ADDRESS
#define DT_INST_0_SOC_NV_FLASH_ERASE_BLOCK_SIZE		DT_SOC_NV_FLASH_0_ERASE_BLOCK_SIZE
#define DT_INST_0_SOC_NV_FLASH_SIZE			DT_SOC_NV_FLASH_0_SIZE
#define DT_INST_0_SOC_NV_FLASH_WRITE_BLOCK_SIZE		DT_SOC_NV_FLASH_0_WRITE_BLOCK_SIZE

@galak I have quite a wide range of areas on my head, so excuse basic question:
Should i just use DT_SOC_NV_FLASH_0_xxx macros. for obtain values i want? Is index 0 guaranted?
Looks like you points this before - but I didn't catch.

The DT_SOC_NV_FLASH_0_XXX are not index based, but based on node name/address the flash is at.

Understand: this mean that this might works - will experiment with this.
Strange thing- now even if i removed sim_flash node completly form dts, and remove flash simulator from the compilation, build failure in a strange way:
[62/71] Linking C executable zephyr/zephyr_prebuilt.elf
Memory region         Used Size  Region Size  %age Used
             ROM:       19736 B         4 MB      0.47%
             RAM:          8 KB         4 MB      0.20%
        IDT_LIST:         416 B         2 KB     20.31%
        MMU_LIST:         104 B         1 KB     10.16%
[68/71] Generating mmu_tables.bin
FAILED: zephyr/arch/arch/x86/mmu_tables.bin
cd /home/anpu/codedev/zephyrproject/build/hellow/zephyr/arch/arch/x86 && /usr/bin/python3 /home/anpu/codedev/zephyrproject/zephyr/arch/x86/gen_mmu_x86.py -k /home/anpu/codedev/zephyrproject/build/hellow/zephyr/zephyr_prebuilt.elf -o mmu_tables.bin -u user_mmu_tables.bin
Memory region 1 (4000:401000) overlaps memory region 0 (400000:800000)
ninja: build stopped: subcommand failed.
ERROR: command exited with status 1: /home/anpu/cmake/cmake-3.13.1-Linux-x86_64/bin/cmake --build /home/anpu/codedev/zephyrproject/build/hellow
run as "west -v build -d build/hellow --board qemu_x86 zephyr/samples/hello_world/" for a stack trace

Adding bug tag as this is blocking https://github.com/zephyrproject-rtos/zephyr/issues/15831

Memory region 1 (4000:401000) overlaps memory region 0 (400000:800000)

Grep for MMU_BOOT_REGION in the code, instances of these are used to construct the page table. Somewhere, these are overlapping. make VERBOSE=1 may have more clues.

^^ ROM (Flash) region overlaps RAM region.

hopefully fix in a way by #17349

@nvlsianpu #17349 is now merged, so can you revisit this one?

@nvlsianpu #17349 is now merged, so can you revisit this one?

Is this still an open issue?

^^ yes, this was covered in PR mentioned above.


4000ms timeout after every request

We have implemented AzureCP for the second time already, after not being successful the first time. Still we’re facing the same issues we had before, which is that AzureCP runs into a 4000ms timeout after every request we send, which in turn gives no results back in the people picker mask. The problem is that my team does not administrate Azure AD and has no direct access to the Azure Portal, so we cannot check any issues there (we were suspecting an issue with the dynamic groups that Accenture uses). But we have implemented all installation, configuration and troubleshooting steps from your guide on azurecp.yvand.net and in the process we mitigated many issues. Still we can’t get it running.
It would really mean a lot to me if you could spare a minute to maybe at least point us in a direction for troubleshooting. If any evidence or logs etc. are needed, I can provide those.
Merci beaucoup!

@peretimo in such case, the section to "Inspect the actual traffic between AzureCP and Azure AD" should really help you see what is going wrong. Have you tested it?
What do logs say?


Modflared not activating when trying to access servers

Description
When using modflared with ATM9 in game version 1.20.1 modflared isn't attempting to run cloudflared at all. (no logs are seen)
Versions

Minecraft: 1.20.1
Modflared: modflared-1.2.0+release.61
Modpack: ATM9 0.3.0
Modloader: Forage - 47.2.20

Steps to Reproduce

Start game
Navigate to multiplayer
Fails to connect to server
No logs are generated
Exit game
Add forced_tunnels.json with domain
Start game and navigate to multiplayer
Fails to connect to server
No logs are generated

Expected Behavior
I expect to see attempts to connect to the cloudflared tunnel in the server logs
Additional Context
I was able to connect to a different modded server running on the same machine with a different domain, but it required setting forced_tunnels.json so I at least we know it's not a different configuration problem. The versions for context:

Minecraft: 1.18.2
Modflared: modflared-1.2.0+release.62
Modloader: Forage - 40.2.21

@BryceGraves You say no logs are generated. No client logs either? When launching the modpack does it show in the client logs the mod was loaded? That should be the first thing to verify. Just saying it doesn't work and no logs isn't very descriptive.
I spun up ATM 9 and was able to verify it working. You'll see something like this in your log when you load the server list as well if it has been setup correctly on the domain side.
[pool-7-thread-1/INFO] [cloudflared-windows-amd64.exe access tcp --hostname atm9.domain.net --url <IP_ADDRESS>:33782]


Replace use of reflect.MethodByName with real interface to allow Go dead-code elimination

Hi,
In current versions of the Go compiler, any use of reflect.MethodByName halts the entire dead-code elimination pass:
https://go.dev/src/cmd/link/internal/ld/deadcode.go#L293
This is causing many Go binaries with go-sqlite3 to be much larger than they need to be.
reflect.MethodByName is used in go-sqlite3 for custom aggregation functions and calling Step() and Call() on them:
https://github.com/mattn/go-sqlite3/blob/master/sqlite3.go#L453
From a quick reading of this, it seems like it might be possible to

cast to an interface { Step(); Call(); } and avoid the use of reflect.MethodByName; or
pass in step/call callbacks, similar to how the constructor is handled; or
support a build tag like noreflect or noaggregator to disable this functionality entirely if it's unused

cast to an interface { Step(); Call(); } and avoid the use of reflect.MethodByName; or

This will not work because the signature of Step (specifically the argument types) is variable.

Two options: Is there a finite number of possibilities for argument-types in the step function? Then one could define multiple interfaces and use a type-select to call the right one.
Otherwise could the Method with the reflect-call be moved into its own method/package, which could be eliminated by the dead-code analysis, if the whole package with this call is not needed ?

Is there a finite number of possibilities for argument-types in the step function?

No, the Step function may contain an arbitrary number of parameters.
In addition, currently RegisterAggregator will allow (as in not return an error) Step methods where one of the arguments is a typedef of a supported type. For example:
type Foo string
func (*myAggregator) Step(f Foo){ ... }

However, if you actually try to use such an aggregator in a query, it will panic. Either we have to start disallowing such typedefs within RegisterAggregator (which could be considered a breaking change), or the code needs to be fixed to handle them properly, in which case even the parameter types will be arbitrary.

Otherwise could the Method with the reflect-call be moved into its own method/package

This would also be a breaking change.
Unfortunately, other than being able to remove the method in question via a build tag, I can't think of any way to address this without incurring some sort of breaking change.

Go1.22 will solve this for the use of a constant string to MethodByName I've verified this on some codebases at Uber.
https://go-review.googlesource.com/c/go/+/522436/5/src/cmd/compile/internal/walk/expr.go

Closing because I don't think there is anything this library can do, and (allegedly) this is resolved in Go 1.22.


Icon tooltip stays in top-left corner of desktop

Often times when I hover over the Synctrayzor icon in the Windows System Tray, the balloon message stating what program it is that I'm hovering over will pop up in the upper left-hand corner of the screen and stick there, regardless if I move my mouse, open Synctrayzor, or interact with the tray icon in any way, shape or form.
The only way I found to fix this is to exit out of Synctrayzor completely and re-open the program.
Has anyone else run into this?
OS: Windows 10 Home x64, v1703
Synctrayzor: v1.1.16

SHA256: E5E7C4446B60F066507CDB6231918983BB24FA2F49C3B201BCB864B3219A501C

Syncthing: v0.14.37-rc.3

SHA256: 08D544CCEF3F9CE4C6456882DC409754414497D49FE17AFA6835851850C9F0C4

I'm afraid I've never seen it. I'll leave this open in case anyone else has come across it.

I've run across this on all Windows 10 x64 machines running Version 1703, whether it's on Home or Pro.

Weird, I struggle to imagine how this is anything which I can affect, since that tooltip is provided solely by Windows.

Maybe we can either change the libraries or set a fast refresh cycle for the libraries? (Basically have the tray icon itself shut down for a brief half-second every "x" amount of time)

No, this is the only notify icon library for WPF. There's no such thing as a refresh cycle for a notify icon.
On 8 October 2017 09:00:54 BST, jebeld17<EMAIL_ADDRESS>wrote:

Maybe we can either change the libraries or set a fast refresh cycle
for the libraries?
Reply to this email directly or view it on GitHub:
https://github.com/canton7/SyncTrayzor/issues/398#issuecomment-334990151

Worth a shot to ask, at least :(

Confirmed on my Windows 10 1709 16299.248 / Synctrayzor: v1.1.18 / Syncthing: v0.14.44
I can sometimes get it to repeat if I futz with the tray icon or hover over the tray icon while locking the desktop.

Confirmed here too. I only just started noticing this today. On my home PC and Notebook it happens to both, the Notebook being only a day old and a fairly-clean Windows 10 home install, as well as the portable version on my USB that I used just now on public Uni PC's.

I've found that if I hover the mouse over a different icon in the task tray, the stuck SyncTrayzor message disappears once the other icon's message is activated. Not a fix, but at least it gets rid of the message.

I can confirm that this is an issue with the hardcodet wpf library, as it have been observed with other applications using this library.
It was not updated since 2016, and the developer seems not to have been very active since then.
Very strange this is the only option available. :(

I also have this issue intermittently. New to github, don't know what else to say??

Maybe we should invest in a fork of hardcodet wpf? Can't hurt to help out a few other projects if any of us get free time to contribute. :)

There's half a dozen pull requests that haven't been addressed. I'm not sure what the protocol is for taking over an open source project after the author has dropped off the earth is.

I've found that if I hover the mouse over a different icon in the task tray, the stuck SyncTrayzor message disappears once the other icon's message is activated. Not a fix, but at least it gets rid of the message.

Thank you! I was struggling with this issue, and absent an actual fix (which seems unlikely due to the 3rd party library), this workaround is extremely helpful!

Just an observation that wpf.notifyicon is now on github: https://github.com/hardcodet/wpf-notifyicon

👍
On Thu, Dec 31, 2020, 5:58 AM Antony Male<EMAIL_ADDRESS>wrote:

Just an observation that wpf.notifyicon is now on github:
https://github.com/hardcodet/wpf-notifyicon
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/canton7/SyncTrayzor/issues/398#issuecomment-752924225,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACINM463422ZCIZCSDZU273SXRKL7ANCNFSM4DYGNJTQ
.

I'm having the same issue, is this fixed ?

Unless you can find an indication that an update to the wpf.notifyicon library has fixed it, nope!

FYI: Just observed same behaviour from NordVPN Tray app on my Surface Pro 5

Easiest way to get rid of it for me is to right click the Syncthing tray icon and select "Restart Syncthing".

I had the same issue with NordVPN and it has nothing to do with the SyncTrayzor.
If you run this on a system with a dedicated GPU consider the following actions:

Add the App and service executables to the "High Performance" mode of the  Windows Settings>Display>Graphics Settings>Graphics Performance Preference
Properties the App and service executables must have the
a. Properties>Compatibility>Disable Fullscreen Optimizations
b. Change High DPI settings [v] Program DPI
c. Override High DPI scaling behavior [v]
d. Scaling performed by application
Stop and start the service and the problem must have disappeared.

I agree that that might be a good solution for the time being

Has anyone tried using https://github.com/hardcodet/wpf-notifyicon latest code and test this issue? There' s no related issue open on the new repo. If still occurs, we should open one issue there.

The sample apps in the repository of wpf-notifyicon don't seem to reproduce this issue.

However, I noticed the library seems to draw tooltips in its own way, without using the Windows native tooltip UI. I think that is causing problems and is a complexity that SyncTrazor does not need.
Native's tooltip UI looks more modern in Windows 11.

I think it would be nice to find a way to use Native's tooltip UI.
(Technical info: To show native tooltip, add NIF_SHOWTIP flag to Shell_NotifyIcon calling. Document)

Same issue on Windows 11 22H2 2621.1555

Same issue here as well on Windows 11 22H2 22621.1848 on multiple systems

Can confirm this is reproducible, and still annoying 😒,
OS Name Microsoft Windows 11 Pro
Version 10.0.22621 Build 22621

has anyone figured this out? its pretty annoying

Many apps I use have this issue, its super annoying.
I will just stop using them, when I don't 100% need them.

I would greatly appreciate it if this could be addressed. I encounter this balloon message daily.

There is this PR on the wpf-notifyicon repo which might solve the issue: https://github.com/hardcodet/wpf-notifyicon/pull/96

I got rid of it by changing compatibility settings of "C:\Program Files\SyncTrayzor\SyncTrayzor.exe": set DPI scaling to "System". Now the icon is a bit blurry but that is a far minor problem.

I've come to the following. Create a second Desktop and open SyncTrayzor as a window on it. The annoying icon will disappear and SyncTrayzor won't bother you on the first main Desktop. I do this every time I lauch my computer.


1.7.0 rc rebase 1

Modulus Pull Request
Description
First rebase after 1.7.0 release
Checklist

[x] I am familiar with the Contributing Guidelines.
[x] New or existing tests cover these changes.
[x] The documentation is up to date with these changes.
[x] The CHANGELOG.md is up to date with these changes.
[ ] An issue is linked to this pull request.

Dependencies

/blossom-ci


build: Update glslang and SPIRV-Headers for the next sdk

CI Vulkan-ExtensionLayer build queued with queue ID 2977.

CI Vulkan-ExtensionLayer build # 481 running.


Upgrade Travis build infrastructure

from legacy to container-based infrastructure
http://docs.travis-ci.com/user/migrating-from-legacy/

Thanks for the pull request, @stvstnfrd! I've created OSPR-854 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.
Feel free to add as much of the following information to the ticket:

supporting documentation
edx-code email threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Hey @stvstnfrd,
Since you’re changing the travis configuration, you should probably add pip cache in order to speed up the CI builds (http://docs.travis-ci.com/user/caching/#pip-cache).

Thanks for the heads-up @tusbar .
Have you profiled this? The attached link mentions
"If you have not overridden the default install step".
Per the link there [1], it looks as if we may have "overridden the
default install step" [2]. So, I'd be curious to determine whether we'd
gain anything given our current configuration..
Any insight?
[1] http://docs.travis-ci.com/user/customizing-the-build/#Customizing-the-Installation-Step
[2] https://github.com/edx/xblock-sdk/blob/5047c7a3d409a469e2c2bf2f2a46f05a04e32df0/.travis.yml#L10

@stvstnfrd you’re right, the install step is overridden, it runs make pip that just runs pip install ….
When you’re not overriding the install step, pip dependencies are not cached in the default location (travis actually overrides that) – but when you’re running pip install yourself, it uses the default cache location – which on linux is ~/.cache/pip.
So you can achieve caching by adding
cache:
  directories:
    - $HOME/.cache/pip

I'm :+1: on this change. @tusbar please feel free to merge when this meets your standards :)

@tusbar Caching was added as recommended.

:+1:


Select some UTXOs During Send Flow

Task Description
During Send flow, there will be an advanced option where the user can "Select UTXOs". Then for send only those should be considered.
ETA
Estimated time
Dependencies
Any dependencies for the task

We have implemented this.


Create ccds.is-cool.dev

Requirements

[x] You have completed your website.
[x] The website is reachable.
[x] The CNAME record doesn't contain https:// or /.
[x] There is sufficient information at the owner field.
[x] Your website is not hosting on the following due to SSL issues: Vercel, Netlify

Description
It will be used for personal portfolio to showcase thing about myself.
Link to Website
http://<IP_ADDRESS>

CLA Assistant Lite bot: Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request

I have read the CLA Document and I hereby sign the CLA


IP detection problematic for behind-the-firewall hosts

Rancher always detects the wrong hosts IP for hosts that reside behind a firewall connecting to a Rancher server in the public Internet.
Not sure if there's a generic fix for all machine drivers.
But at least for a Custom host case, we should make it more obvious that users need to specify a host IP when they have a host behind a firewall connecting to Rancher server on the Internet.

Move out of 1.6 release.
Talked with Sheng L:
We need to find a way to deal with hosts behind the NAT, which Rancher server will only detect the public IP of it. So if there are multiples hosts behind the same NAT, they will be identified by the same IP then our overlay network and port mapping won't work.
Sheng thinks about using private IP instead of public IP for those hosts, but there can be other implications.


SSL configuration is Running - Stuck in SSL Configuration

App Id: d302bkns913825
Region: us-east-2
Step: SSL configuration
Status: Running
Issue/question
I have configured a custom domain for the an amplify hosted app, but the process is stuck on the SSL verification of domain ownership and doesn't move forward for more than 8 hours. The DNS Management is done by Route 53 and the process should not stall here.

Refer to our documentation to troubleshoot domain setup.
https://docs.aws.amazon.com/amplify/latest/userguide/custom-domain-troubleshoot-guide.html
https://docs.aws.amazon.com/amplify/latest/userguide/custom-domain-troubleshoot-guide.html#i-get-a-cnamealreadyexistsexception-error
Let us know if you're still facing issues.

Refer to our documentation to troubleshoot domain setup.
https://docs.aws.amazon.com/amplify/latest/userguide/custom-domain-troubleshoot-guide.html
https://docs.aws.amazon.com/amplify/latest/userguide/custom-domain-troubleshoot-guide.html#i-get-a-cnamealreadyexistsexception-error
Let us know if you're still facing issues.

We are going to close out this issue, but please feel free to re-open if you still need help.


Update master to use boot 2.2

This was addressed with this commit - https://github.com/spring-cloud/spring-cloud-stream/commit/c6385f220cf50615013bf90be16df1af18af9b9a by upgrading to s-c-build 2.2


Add video quads

Video quads are currently only supported by the canvas renderer.  If the video is not ready, a preview color can be shown, but not a preview image (to show a preview image, create an image quad at the same coordinates as the video quad).

Added color quads to the canvas renderer.  This made things easier to test.
Improved some of the caching logic in quads to reduce reloading images and videos in some circumstances.
Added a utility method to invalidate one or all of the quad's caches.  This removes using a private method in the quad example.
Added code to defer rendering if something is busy.  This prevents flashing when seeking on a playing video.
Fixed an issue with the canvas transform on images and videos.
Update quadFeature documentation.  Also update some renderer documentation.
Improve testing infrastructure.  Don't test video in PhantomJS.  Allow console.log messages to appear in tutorial test output.
Added a video to the quads example.
Add two video quad tutorials; one stand-alone quad and one quad positioned on a map.
Added tests.

This PR is broken into separate commits to try to make it easier to review.


Fatal erore on 5s ios11.4.1

Hi,i have iphone 5S ios11.4.1; last beta(27) still give fatal error on step 27- line1620
Error num2
Fail ro extract boot startup
What i must do?

@mafi73 post a screenshot and also post diagnostics file.

@Cryptiiiic

diagnostics.zip

@mafi73 you need to rootfs restore since you updated to iOS 12 instead of restoring. Your iOS 8 jailbreak files are still there lol... Just turn on the rootfs restore switch.

@cryptiiic thank you so much
But my storage like apps and cameraroll will be destroyed whit rootfs??

@mafi73 no, your user data like apps, photos is still there and unaffected.

@mafi73 "root". This is the system fs. Contains no user data at all.

@Cryptiiiic @coenkcore
its done
iam jailberak my iphone sucssesfully thank U so much...

@mafi73 yw.

@Cryptiiiic hi agane
after every restart , my jailbreak gone.. and i must jailbreak my iphone agane;; is this normal?

@mafi73 It is normal.
After restart you must rejailbreak your device again.

@coenkcore tnx
and other thing: honestly iam jailbreaked my idevuice for 1 resion: that is my "oters" storage on my iphone is almost 15GIGABAYE
thats a lot
iam searching for any twik that can manage this storage on my device
iam trying normal metod like cleaning telegram & instagram cach and remove imessage,voice memos &...
stiil oters are 15gig
becuse i have jailbroket my iphon 2year ago on ios 8.4 and thas file are still ther i tink
and plus i use i cleare pro twik,.,,,its workless only clean 300mb
please help me


Primitive to Intrinsic in 0.3 Migration guide

Docs Build status updates of commit 04db6c9:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/relnotes/0.3-migration.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit eae05d5:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/relnotes/0.3-migration.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 9460956:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/relnotes/0.3-migration.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 92360c1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/relnotes/0.3-migration.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

As I mentioned, this migration guide is for 0.3 so the namespace changes and other syntax changes do not apply. This should not be merged.


Rare non npc items

I guess it's kinda outside of scope, but the plugin doesn't trigger a discord message when you get an eternal glory.

I don't know if we can catch this event. I'll look into it, but testing this will be practically impossible since it's a 1/25k chance in the wildy :)
I guess gzz btw? :)

Hmm it's an edge case that is currently nog being concidered.
One way of doing it is how pets are currently done and check for the text The power of the fountain is transferred into an amulet of eternal glory. It will now have unlimited charges.


Update README.md

Since it was not specific, so it oponed the question if the pogress variable would keep being a store.
It might be useful to know which other elements in Svelte Motion have similar behaviour to a store, as I understand some of these elements use store internally so making use of them in a variable makes that variable a store(?).

thanks — i think we can solve this more easily, closing in favour of #540


REST documentation should be autogenerated

Story
We should use something like swagger to autogen the data types and API calls

Try to clean up the issue list.
Please reopen this when you start to work on it.


Nic/feat/add helm release support

adds helm to charts for k8s deployment
adapts env vars
updates readme

@mransdorf please not these comments here


Remove unecessary param in test

Current coverage is 35.55%

Merging #395 into master will decrease coverage by -4.27% as of f516914

@@            master    #395   diff @@
======================================
  Files           72      69     -3
  Stmts         3465    3310   -155
  Branches       819     791    -28
  Methods          0       0
======================================
- Hit           1380    1177   -203
+ Partial        130     111    -19
- Missed        1955    2022    +67

Review entire Coverage Diff as of f516914

Powered by Codecov. Updated on successful CI builds.

:+1:


Should it be && or **?

https://github.com/notwaldorf/flash-cards/blob/ae64f9abef06123323e024a73a486a8db62b3046/src/localStorage.js#L6

Deeeefinitely &&. That’s a typo!


BUG: Handle content that requires extra info in AggregatedData

PR that fixes a bug in AggregatedData where data that requires extra info would fail in the pydantic validation.
Closes #597
Ideally I wanted to remove the Initialization of ExportData to extract metadata, and instead use more direct method calls to populate the necessary fields. I was not able to do that fully at this moment since the objectdata_provider takes an ExportData instance as argument.
This AggregatedData class would need some attention in the future. e.g. adding pydantic models for aggregated data, and adding more tests as all of our tests are only targeting the datatype surface.

I think the added test should cover the reported problem, @rwiker can perhaps confirm that?

I think the added test should cover the reported problem, @rwiker can perhaps confirm that?

Yes it shoul!  I got the same validation issue as reported by Raymond if I run this test with the main branch.


File and folders reorganized and fixed broken links

This fixes #37

@4bh7n4v Thanks for the pr
I will review it and let you know shortly

@4bh7n4v
Thanks for the pr. I will be merging it


SQS Queue URL is pointing to AWS

I'm trying to mock SQS using moto_server
Currently if you create SQS Queue, you get QueueUrl like this:
{
    "QueueUrl": "http://sqs.us-east-1.amazonaws.com/123456789012/<queue_name>"
}

An implementation of SQS client when it has only QueueName is as following:

url = client.getQueueUrl(QueueName=queue_name)
client.sendMessage(QueueUrl=url, MessageBody=body)

Problem is that client (SDK) with endpoint of moto_server sends getQueueUrl to mocked SQS but sendMessage request goes to non-mocked AWS (goes to sqs.us-east-1.amazonaws.com)
Would it make sense to have different URL returned by getQueueURL? Maybe the same one as request host?

I think that makes sense. Would be happy to accept a PR doing that.


[RI-437] Backport pike-rc fixes

This backports a couple of fixes into pike which may help resolve RI-437.
Commit: 199c2f7
Remove functions source in deploy.sh
Sourcing the functions script in deploy.sh may result in failure on a
deployment where the base OS has been installed using a minimal image.
The functions script will be sourced by the install script so any and
all dependencies will be taken care of in the order in which they're
used.
Commit: 085d24b
add default option to the variable DEPLOY_AIO
Issue: RI-437

recheck_xenial_no_artifacts_swift_deploy


Test against multiple .net versions

Without testing, we don't actually know whether or not TestableHttpClient works for .NET Core 2.1, .NET 5.0 or .NET Framwork 4.8.
Add test projects for these specific frameworks, without recompiling the libraries itself:

[ ] .NET Core 2.1 (high prio)
[ ] .NET Core 5.0 (when released)
[ ] .NET Framework (probably only test 4.8)

Besides actually testing against those frameworks, also document which are supported.

In preparation of .NET 5 support, I tested tried to implement this using a matrix, but that is rather difficult to do. A better approach seems to be installing multiple SDK versions and use the <TargetFrameworks> tag in the test projects to target multiple versions. Side effect is that you need to have multiple SDK version installed (also locally), but there might be a workaround for that as well by selecting the version you want to build on the command line (either with --framework or --runtime, I didn't test this yet).
Anyways, officially supporting .NET Framework this way might be a bit more challenging, and I probably won't do that unless people are actually asking for it.

In order to support .NET 5, a couple of changes need to be made in the source code to fix several tests. But since the concept works for .NET Core 2.1 and .NET Core 3.1, we will close this issue and open a new one for .NET 5.
Support for .NET Framework is more involved and will not be done at this moment.