bug: constructor can never align with a literal

I'm just trying to wrap my head around how to use Task so the following code might not even make sense, but the compiler told me to log an issues so here we are :)
app "helloWorld"
    packages { pf: "https://github.com/roc-lang/basic-cli/releases/download/0.7.0/bkGby8jb0tmZYsy2hg1E_B2QrCgcSTxdUlHtETwm5m4.tar.br" }
    imports [
      pf.Stdout,
      pf.Env,
      pf.Task.{ Task },
      pf.Path.{ Path },
    ]
    provides [main] to pf

main =
  Task.await Env.cwd \result ->
    when result is
      InternalPath.InternalPath ->
        Stdout.line "current directory: \(result |> Path.display)"
      CwdUnavailable ->
        Stdout.line "could not lookup current directory"

running that with roc dev or roc run explodes like this:
An internal compiler expectation was broken.
This is definitely a compiler bug.
Please file an issue here: https://github.com/roc-lang/roc/issues/new/choose
thread '<unnamed>' panicked at 'After type checking, a constructor can never align with a literal: that should be a type error!', crates/compiler/exhaustive/src/lib.rs:637:29
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Roc version
❯ roc --version
roc nightly pre-release, built from commit a187d141bd8 on Mon Dec  4 09:19:54 UTC 2023

Bonus points if someone can write the correct version of that main function. I'm just guessing wild at this point.

I can't fix the compiler bug, but I can fix your roc code ;)
I'd do something like this:
main : Task {} I32
main =
    Task.await Env.cwd \path ->
        Stdout.line "current directory: \(Path.display path)"
    |> Task.mapErr \_ -> -1

...or a bit more verbosely, to specifically handle the cwd error:
main : Task {} I32
main =
  # wrap Env.cwd so it fails with I32
  errWrappedCwd = Task.onErr Env.cwd \_ ->
    _ <- Task.await (Stdout.line "something went wrong...")
    _ <- Task.await (Stdout.line "failed getting current working directory")
    Task.err -1

  # await and print
  path <- Task.await errWrappedCwd
  Stdout.line "current directory: \(Path.display path)"

Thank you  @AsbjornOlling!  I see where my thinking failed me now. The callback to Task.await is called with the path (Path) and not something I should pattern match on to get the path out.
This was very helpful! :)

For record keeping: this is possibly related to #6180

There are plans to change a ton of stuff about how Tasks are handled. In particular, effectful functions will return a result (like you tried to do in the original incorrect code) instead of having separate success and error types. So even if this bug isn't fixed when all that code is rewritten, this reproduction won't be useful anymore. And also this might be covered by that other issue. So I'm closing this issue.


[BUG] Vector.cov does not return correct covariance

Describe the bug
Vector.cov reports an incorrect value as covariance of two samples. The same is true for Vector.covPopulation.
To Reproduce
Vector.covPopulation (vector [5.;12.;18.;23.;45.;]) (vector [2.;8.;18.;20.;28.;])

Expected result: 116.88
Actual result: 66.64

Fix
The loop exit happens too early (by one increment).

closed by 8b7b7305e87850bcd4cd9894549923663e31fbed


Forward Nomad script

Changes

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Current dependencies on/for this PR:

main

PR #318

PR #319   👈

PR #320

This stack of pull requests is managed by Graphite.


Enhancement: Pagination for SQLAlchemy

What's the feature you'd like to ask for.
Pagination for SQLALchemy
Frameworks such as Flask and FastAPI have extensions that add pagination support.
Would it be possible to add something like this to starlite? This can either be in the base library or as an extension, whichever is easier to maintain.
Additional context
Here is how this can be done in other frameworks.
In case of flask, one way to do this is using flask_sqlalchemy.SQLAlchemy.paginate which returns a flask_sqlalchemy.pagination.Pagination object.
As shown in this StackOverflow answer here is how this can be used.
@app.route('/myview/<int:page>',methods=['GET'])
def view(page=1):
    per_page = 10
    posts = Posts.query.order_by(Posts.time.desc()).paginate(page,per_page,error_out=False)
    return render_template('view.html',posts=posts)

This extension for FastAPI lets you configure it as a response model with OpenAPI schema support.
from fastapi import FastAPI
from pydantic import BaseModel

from fastapi_pagination import Page, add_pagination, paginate

app = FastAPI()

class User(BaseModel):
    name: str
    surname: str

users = [
    User(name='Yurii', surname='Karabas'),
    # ...
]

@app.get('/users', response_model=Page[User])
async def get_users():
    return paginate(users)

add_pagination(app)

Pagination API in starlite does not have to conform with the above mentioned examples, they are listed to show how other frameworks do it. Any design that suits starlite the most would be the preferred outcome. Thanks for the all the work you guys do in this project.

As discussed in slack:

We will create a general pagination helper, which can receive an iterator or async iterator and paginate it. This should not be SQLA specific but rather simply work with iterators.
Pagination must include an OpenAPI component to this. As such it must be declared as part of the function signature - probably as a return typing.
We should follow a standard pagination scheme, not reinvent the wheel.

We will create a general pagination helper, which can receive an iterator or async iterator and paginate it. This should not be SQLA specific but rather simply work with iterators.

I think it should be a class, not an iterator. In a paginated endpoint, you usually don't want to go through all the previous pages, but be able to retrieve a specific page. This can then be used by the generic pagination helper to get the current/next/previous pages.


Support for 4.x version

Hi,
Please let us know if you have any plans to provide support for zabbix_server (Zabbix) 4.0.0rc3 version. Current import does not work for me :(
Thanks

104910:20210717:013358.792 Starting Zabbix Agent [<IP_ADDRESS>]. Zabbix 4.0.32 (revision 48e1f06abf).
104910:20210717:013358.792 **** Enabled features ****
104910:20210717:013358.792 IPv6 support:          YES
104910:20210717:013358.792 TLS support:           YES
104910:20210717:013358.792 **************************
104910:20210717:013358.792 using configuration file: /etc/zabbix/zabbix_agentd.conf
104910:20210717:013358.793 cannot load module "libzbxsockets.so": /usr/lib64/zabbix/modules/libzbxsockets.so: undefined symbol: __zbx_zbx_error

Caused by changes in Zabbix. "DEV" tickets are not mentioned in Changelog and Release Notes, but judging by commit date it should have landed in 4.0.6rc1.
If you can afford it, downgrade your Zabbix agent to 4.0.5.


Get carousel position

How can I get the current position of the carousel ?

index solve the problem :D


Erroneous phishfort address

Hi - I believe app.strongblock.com is incorrectly on your phishfortlist. Can you confirm?
Thanks

Thanks
Sendt fra Yahoo Mail på Android
Den tor. 3. feb.. 2022 kl. 14.50 skrev @.***>:
Hi - I believe app.strongblock.com is incorrectly on your phishfortlist. Can you confirm?
Thanks
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.***>


Correcting typo in ListItem docs

Corrects issue: #8299

@apearson Thanks :)

Beat me to it :) Thanks!


npm package is outdated

I was building a prototype against this, and only just realized that it was last updated 6 months ago:
https://www.npmjs.com/package/mithril
It's got some odd bugs in IE9 that aren't in the latest code, as demonstrated here (http://jsfiddle.net/qjxho57z/2/) Notice when you type in the text area in IE9, the output beneath the text area is one character behind.
So, I think an npm update would be nice!

Agree, would be great to bring the npm package up to date. Thanks!

npm's still on v0.2.0 which is technically still the most recent release: https://github.com/lhorie/mithril.js/releases/tag/v0.2.0
I agree that it'd be nice to see a new release cut w/ the 187 commits to next since v0.2.0 came out. Apparently @lhorie has some big plans to rewrite large parts of mithril in a back-compat breaking way? I've seen it mentioned a few times in random issues but nothing real concrete direct from the source.
A roadmap of future plans would be lovely ¯\_(ツ)_/¯

Have you seen #802 ?

@lhorie I think now's a good time to cut a patch release, before much work is done on #802. (Most of the non-breaking additions have already been done already).

npm is now pointing to 0.2.2-rc.1


Different extensions getting added in GUI and CLI .

Hi,
When i enable the VM Diagnostics for Windows VM  via GUI Microsoft.Insights.VMDiagnosticsSetting Extension got created.
When i enable the VM Diagonstics for VM Windows VM via CLI using az vm diagnostics set , IaaSDiagnostics Extension got created.
Like to know what is difference between these two extensions.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7a9ab822-6524-9dd7-3bf4-1889e10d1266
Version Independent ID: ec780873-d291-dda8-6b1d-c410e2d87b98
Content: az vm diagnostics
Content Source: latest/docs-ref-autogen/vm/diagnostics.yml
Service: virtual-machines
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

add @qwordy to have a look


Non-comparison Sorts

Description
Non-Comparison Sorting Algorithms sort numbers without comparing them.
I would like to implement

Counting Sort
Radix Sort
Bucket Sort

I am GSSoC 2022 Contributor.
@miraj0507 Can you assign me this issue?
Domain
Algorithm
Type of Contribution
Addition
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of LearnCPP.

You can only contribute one sorting algorithm at a time in one issue not many and it will be good for you to because once your PR is created you'll be able to create new issue for next sorting algorithm , having different prs will give you more points
Edit your Desc. and come up with only one which is not present in repo and is not raised as an issue of other contributors.
I would recommend you to go through this tutorial video of the project here, thanks.

I will implement Counting Sort first
Radix and Bucket Sort will be implemented in next issues after merging PR for counting sort

So kindly update the title as soon as possible, as Counting sort, I will be assigning you the issue.

/assign


Messages Cluster XML

This is continuation of PR https://github.com/project-chip/connectedhomeip/pull/30254/
It's all about defining Messages cluster XML and creating boilerplate code using ZAP.

@andy31415

Please validate the XML for the spec. Looking at the generated .matter (so that it is human readable) it generally looks wrong. I added some comments, however not sure how much is because "revision 1 vs 3" or because missing bits in XML.
I expect we want latest revision.

I've run the suggested code and updated the XML accordingly.
`./scripts/py_matter_idl/matter_idl/data_model_xml_parser.py
-o out/spec.matter
--compare-output out/sdk.matter
--compare src/controller/data_model/controller-clusters.matter
data_model/clusters/Messages.xml
diff out/{spec,sdk}.matter`
Note that spec still has events, but auto generated Messages.xml does not. However I kept the events in messages-cluster.xml.

I've created for ZAP project isFabricScoped issue:
https://github.com/project-chip/zap/issues/1255

@lazarkov Why is this a new PR instead of continuing with the existing PR that had existing review comments?


Bump minor version to 0.2.9

@JuliaRegistrator register

Comments on pull requests will not trigger Registrator, as it is disabled. Please try commenting on a commit or issue.


setBackgroundColor , setForegroundColor removed

Previously, there was a setBackgroundColor: and  setForegroundColor methods and this was removed. Our app uses this method and we preferred setting a custom color.
Was there a technical limitation or something else that caused this method to be removed? If not, is it possible to deprecate the method if that's no longer the preferred way?
Thanks for this amazing library. Several of my apps depend on it.

Within the scope of #384 We decided to simplify 'SVProgressHUD'. From the feedback we got, many people always use the default configuration with no custom colours. Therefore, I decided to make a "clean" cut and not deprecate the methods. Explanation of this is, that at the moment I am the only maintainer and want to keep the cognitive load as small as possible. Please see the current commits as a kind of 'SVProgressHUD' 2.0.
A quick fix four your problem might be to change 'foregroundColorForStyle:' and 'backgroundColorForStyle:' in 'SVProgressHUD.m'.

Styling support doesn't have to replace setBackgroundColor: and setForegroundColor:. It can override these settings and vice versa. I used the library with configured 50% alpha of the bg. Now I can't do this w/o any special deals. MaskTypeBlack does almost the same but user interactions is not allowed. It's very important for a library to be configurable as wide as it possible.
Btw, not sure, that UIAlertController is a good example. It's on how to say.. another styling level. It has system style and coloring. But the SVProgressHUD is closer to your app and your app's design.
Thanks.

You are rigth somehow, however we want to see 'SVProgressHUD' like if it was an iOS-System-Component. However, feel free to submit a PR (by keeping it as simple as possible).

I disagree with the comparaison to UIAlertView but reading the PR, I got the reasons why it cannot be changed. I didn't really look at the code thoroughly, but having some customization would be nice.
On another note, I think you guys should follow stricter versionning as the jump from 1.1.2 to 1.1.3 deletes a lot of method and could make the pod unusable. Since it is suggested to use the head, it might cause some problems. Just a suggestion.

Sorry, my bad, 1.1.3 is still compatible. I'm guessing it will be for a 2.0 which makes sense. My fault as I was using the head.

First: 1.1.3 is still compatible, As mentioned a few hours ago the current changes are targeting 2.0. We do not suggest to use the head, we just mention that if you want to use the latest features use ':head'. And I stand by the words written: I am very careful what I push to the master. The current changes are used in two of my apps since Q1, 2015 and are very stable.
Second: I understand all of your concerns and will rethink the simplification. Give me a few hours please.

Yea, I stand corrected for the versioning, my bad :)
As for the changes, is there a discussion somewhere people can participate in for this?

What about right here?

I'll check a bit more your PR and will think about it too.

How about implementing UIAppearance for these properties? Seems like a very 'iOS-System-Component' thing to do.
http://petersteinberger.com/blog/2013/uiappearance-for-custom-views/

Cool idea. However, I am thinking about an approach where we might add a "third" 'enum' in 'SVProgressHUDStyle' like 'SVProgressHUDStyleCustom'. If this enum is set we could use the 'backgroundColor' and 'foregroundColor'.
The UIAppearance is very fancy. If we want to use this approach, we should apply it to every UI-property like 'ringThickness', 'font', 'cornerRadius' etc.

I added the rest of the UIAppearance properties to pull request #469, including corner radius. I also added the SVProgressHUDCustom to the style enum. I think that approach works well.

I wanted to merge this feature, however as I was doing so, I recognised that UI_APPEARANCE_SELECTOR is not available in iOS6, which is still supported by this component.

iOS 6 has support for UIAppearance. I pulled in the latest changes into my PR, added animation type as a UIAppearance property, and enabled UIAppearance for iOS 6.


Rule with id 'RuleId(value=standard:string-template-indent)' requires rule with id 'RuleId(value=standard:indent)' to be loaded

After updating ktlint from 0.50.0 → to 0.51.0-FINAL, the following starts to fail while running Ktlint via maven-antrun-plugin:
[INFO]    [ktlint] Exception in thread "main" java.util.concurrent.ExecutionException: java.lang.IllegalStateException: Skipping rule(s) which are depending on a rule which is not loaded. Please check if you need to add additional rule sets before creating an issue.
[INFO]    [ktlint]   - Rule with id 'RuleId(value=standard:string-template-indent)' requires rule with id 'RuleId(value=standard:indent)' to be loaded
[INFO]    [ktlint] 	at java.base/java.util.concurrent.FutureTask.report(FutureTask.java:122)
[INFO]    [ktlint] 	at java.base/java.util.concurrent.FutureTask.get(FutureTask.java:191)
[INFO]    [ktlint] 	at com.pinterest.ktlint.cli.internal.KtlintCommandLine.parallel(KtlintCommandLine.kt:688)
[INFO]    [ktlint] 	at com.pinterest.ktlint.cli.internal.KtlintCommandLine.parallel$default(KtlintCommandLine.kt:651)
[INFO]    [ktlint] 	at com.pinterest.ktlint.cli.internal.KtlintCommandLine.lintFiles(KtlintCommandLine.kt:423)
[INFO]    [ktlint] 	at com.pinterest.ktlint.cli.internal.KtlintCommandLine.run(KtlintCommandLine.kt:303)
[INFO]    [ktlint] 	at com.pinterest.ktlint.Main.main(Main.kt:35)
[INFO]    [ktlint] Caused by: java.lang.IllegalStateException: Skipping rule(s) which are depending on a rule which is not loaded. Please check if you need to add additional rule sets before creating an issue.
[INFO]    [ktlint]   - Rule with id 'RuleId(value=standard:string-template-indent)' requires rule with id 'RuleId(value=standard:indent)' to be loaded
[INFO]    [ktlint] 	at com.pinterest.ktlint.rule.engine.internal.rulefilter.RunAfterRuleFilter.filter(RunAfterRuleFilter.kt:77)
[INFO]    [ktlint] 	at com.pinterest.ktlint.rule.engine.internal.rulefilter.RuleFilterKt.applyRuleFilters(RuleFilter.kt:15)
[INFO]    [ktlint] 	at com.pinterest.ktlint.rule.engine.internal.RuleExecutionContext$Companion.createRuleExecutionContext$ktlint_rule_engine(RuleExecutionContext.kt:192)
[INFO]    [ktlint] 	at com.pinterest.ktlint.rule.engine.api.KtLintRuleEngine.lint(KtLintRuleEngine.kt:94)
[INFO]    [ktlint] 	at com.pinterest.ktlint.cli.internal.KtlintCommandLine.lint(KtlintCommandLine.kt:548)
[INFO]    [ktlint] 	at com.pinterest.ktlint.cli.internal.KtlintCommandLine.process(KtlintCommandLine.kt:473)
[INFO]    [ktlint] 	at com.pinterest.ktlint.cli.internal.KtlintCommandLine.access$process(KtlintCommandLine.kt:59)
[INFO]    [ktlint] 	at com.pinterest.ktlint.cli.internal.KtlintCommandLine$lintFiles$3.invoke$lambda$0(KtlintCommandLine.kt:411)
[INFO]    [ktlint] 	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
[INFO]    [ktlint] 	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
[INFO]    [ktlint] 	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
[INFO]    [ktlint] 	at java.base/java.lang.Thread.run(Thread.java:833)
[INFO] ------------------------------------------------------------------------

Notably, there is no string-template-indent in our .editorconfig, just these rule related to indentation are present:
[{*.kt,*.kts}]
indent_size = 4
tab_width = 4
ij_kotlin_imports_layout = *,java.**,javax.**,kotlin.**,^

# although shown as incorrect in IDEA, these rule-per-rule disables are actually working.
# see https://pinterest.github.io/ktlint/rules/configuration-ktlint/#disabled-rules
ktlint_ignore_back_ticked_identifier = false
ktlint_standard_indent = disabled

# allow multiple annotations on one line (like @Valid @RequestBody value)
ktlint_standard_annotation = disabled

If I add the explicit disable of this rule:
# disable the failing rule after updating to 0.51.0-FINAL
# see https://pinterest.github.io/ktlint/0.49.1/rules/experimental/
# see https://pinterest.github.io/ktlint/1.0.1/rules/standard/#string-template-indent
ktlint_string_template_indent = disabled

It is a different failure but with the same reason:
[INFO] --- maven-antrun-plugin:3.1.0:run (ktlint) @ rcs ---
[INFO] Executing tasks
[INFO]    [ktlint] Exception in thread "main" java.util.concurrent.ExecutionException: java.lang.IllegalStateException: Skipping rule(s) which are depending on a rule which is not loaded. Please check if you need to add additional rule sets before creating an issue.
[INFO]    [ktlint]   - Rule with id 'RuleId(value=standard:string-template-indent)' requires rule with id 'RuleId(value=standard:indent)' to be loaded
[INFO]    [ktlint]      at java.base/java.util.concurrent.FutureTask.report(FutureTask.java:122)
[INFO]    [ktlint]      at java.base/java.util.concurrent.FutureTask.get(FutureTask.java:191)
[INFO]    [ktlint]      at com.pinterest.ktlint.cli.internal.KtlintCommandLine.parallel(KtlintCommandLine.kt:688)
[INFO]    [ktlint]      at com.pinterest.ktlint.cli.internal.KtlintCommandLine.parallel$default(KtlintCommandLine.kt:651)
[INFO]    [ktlint]      at com.pinterest.ktlint.cli.internal.KtlintCommandLine.lintFiles(KtlintCommandLine.kt:423)
[INFO]    [ktlint]      at com.pinterest.ktlint.cli.internal.KtlintCommandLine.run(KtlintCommandLine.kt:303)
[INFO]    [ktlint]      at com.pinterest.ktlint.Main.main(Main.kt:35)
[INFO]    [ktlint] Caused by: java.lang.IllegalStateException: Skipping rule(s) which are depending on a rule which is not loaded. Please check if you need to add additional rule sets before creating an issue.
[INFO]    [ktlint]   - Rule with id 'RuleId(value=standard:string-template-indent)' requires rule with id 'RuleId(value=standard:indent)' to be loaded
[INFO]    [ktlint]      at com.pinterest.ktlint.rule.engine.internal.rulefilter.RunAfterRuleFilter.filter(RunAfterRuleFilter.kt:77)
[INFO]    [ktlint]      at com.pinterest.ktlint.rule.engine.internal.rulefilter.RuleFilterKt.applyRuleFilters(RuleFilter.kt:15)
[INFO]    [ktlint]      at com.pinterest.ktlint.rule.engine.internal.RuleExecutionContext$Companion.createRuleExecutionContext$ktlint_rule_engine(RuleExecutionContext.kt:192)
[INFO]    [ktlint]      at com.pinterest.ktlint.rule.engine.api.KtLintRuleEngine.lint(KtLintRuleEngine.kt:94)
[INFO]    [ktlint]      at com.pinterest.ktlint.cli.internal.KtlintCommandLine.lint(KtlintCommandLine.kt:548)
[INFO]    [ktlint]      at com.pinterest.ktlint.cli.internal.KtlintCommandLine.process(KtlintCommandLine.kt:473)
[INFO]    [ktlint]      at com.pinterest.ktlint.cli.internal.KtlintCommandLine.access$process(KtlintCommandLine.kt:59)
[INFO]    [ktlint]      at com.pinterest.ktlint.cli.internal.KtlintCommandLine$lintFiles$3.invoke$lambda$0(KtlintCommandLine.kt:411)
[INFO]    [ktlint]      at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
[INFO]    [ktlint]      at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
[INFO]    [ktlint]      at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
[INFO]    [ktlint]      at java.base/java.lang.Thread.run(Thread.java:1589)

Expected Behavior
Ktlint should work as with version 0.50.0.

This disable seems to work, thanks to https://pinterest.github.io/ktlint/1.0.1/rules/configuration-ktlint/#disabled-rules that provides the error.
# disable the failing rule after updating to 0.51.0-FINAL
# it depends on standard:indent which is disable above
# see https://pinterest.github.io/ktlint/1.0.1/rules/standard/#string-template-indent
# see https://pinterest.github.io/ktlint/1.0.1/rules/configuration-ktlint/#disabled-rules
# ktlint_standard_string_template_indent = disabled
ktlint_standard_string-template-indent = disabled

Although now thousands of the newly introduced rules are failing 🤦 , the current issue is fixed, so I am closing the ticket.

This disable seems to work, thanks to https://pinterest.github.io/ktlint/1.0.1/rules/configuration-ktlint/#disabled-rules that provides the error.
# disable the failing rule after updating to 0.51.0-FINAL
# it depends on standard:indent which is disable above
# see https://pinterest.github.io/ktlint/1.0.1/rules/standard/#string-template-indent
# see https://pinterest.github.io/ktlint/1.0.1/rules/configuration-ktlint/#disabled-rules
# ktlint_standard_string_template_indent = disabled
ktlint_standard_string-template-indent = disabled

Although now thousands of the newly introduced rules are failing 🤦 , the current issue is fixed, so I am closing the ticket.


feat(docs): add available integrations @ferdiunal/refine-shadcn

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://refine.dev/docs/guides-concepts/contributing/#commit-convention

Bugs / Features

[ ] Related issue(s) linked
[x] Tests for the changes have been added
[ ] Docs have been added / updated
[ ] Changesets have been added https://refine.dev/docs/guides-concepts/contributing/#creating-a-changeset

What is the current behavior?
What is the new behavior?
Notes for reviewers

Hey @ferdiunal @refinedev/core @refinedev/marketing ,
Thank you so much for the amazing and remarkable contribution @ferdiunal ! I think it's really important to categorize the Refine Packages correctly when listing them. How about adding them to the 'Community Packages' category?

Hey @ferdiunal @refinedev/core @refinedev/marketing , Thank you so much for the amazing and remarkable contribution @ferdiunal ! I think it's really important to categorize the Refine Packages correctly when listing them. How about adding them to the 'Community Packages' category?

@omeraplak I moved to community packages. Thank you for your support.


Add serialize support for repo and user

What did you implement:
I'm using tera and hubcaps for a new project. When trying to pass a Vec<Repo> to tera, I got an error that Repo didn't implement Serialize.
Since Deserialize is already derived for that that type, I'd thought I'd add Serialize as well to fix the error. As far as I can see this shouldn't have any negative side-effects.
How did you verify your change:
Using my fork in the new project for now and serializing works as expected.

Any chance we can merge this?

Sorry for the delay. In the past my hesitation was to avoid deriving types not needed to avoid bloat but I'm starting to come around

Thanks for merging @softprops.

This would be useful to me as well! Any chance this will be released on crates.io soon?


Feature request: Real-time link of this code with disk-utilities

One of the advantages of reading (suitably readable) MFM disks with an old PC FDC is that you know, immediately, if a read of a block is good because the expected format is detected in HW, and various checksums/CRC are validated.
GW could do this, if the controlling software was linked to your libdisk library.
Support could be further enhanced with file-level aware utilities, or for alternate GW things (like 9track or HDD access) in the future.
I'd love to see support for streaming the captured data to another analysis process, that could inform the code in this repo to attempt specific block/track/etc retries -- or even a pause so the operator can clean the media/heads for retry attempts.

One note, something like the Python 3.8 multiprocessing.shared_memory support might make this more performant.


[Help needed] After login, user does not persist. What I'm doing wrong?

I'm using "nuxt-auth-sanctum": "^0.4.2", with Laravel 11.08 and Sanctum 4.02. I have two docker containers, one for Nuxt 8.3.1 and one for Laravel.
I'm able to log in user with:
await login(credentials)

Then I'm redirected to index page which is behind auth middleware:
middleware: ['sanctum:auth']

I'm able to see logged in user in index page:
const { user } = useSanctumAuth<User>()
console.log(user)

Also I can see matching requests in Laravel Telescope. I can see authenticated user in Laravel.
But, after I hit refresh, when I'm on my index page, I'm redirected back to login page. Which means that user is not authenticated.
Reading src/runtime/middleware/sanctum.auth.ts there are:
if (isAuthenticated.value === true) {
        return;
}

So, somehow user is not authenticated ?!?!?
Returning back to index page, I'm redirected to login. In Docker logs I see:
[nuxt-auth-sanctum:ssr]  ERROR  Unable to load user identity from API [GET] "http://localhost:8004/api/user": <no response> fetch failed

Digging deeper, I found that this comes from src/runtime/plugin.ts:
try {
            logger.debug('Fetching user identity on plugin initialization');
            user.value = await client(options.endpoints.user);
        } catch (error) {
            handleIdentityLoadError(error as Error, logger);
        }

But there is nothing in Teleport. So it seams that this does not hit Laravel at all.
I found similar problem here: #57 but It does not help. But when I turn SSR off it works.
What I'm doing wrong?
My nuxt.config.ts:
const sanctumConfig = {
  baseUrl: 'http://localhost:8004',
  origin: 'http://localhost:3004',
  mode: 'cookie',
  endpoints: {
    login: '/api/login',
    logout: '/api/logout',
    user: '/api/user',
  },
  redirect: {
    onAuthOnly: '/auth/login',
    onGuestOnly: '/',
    onLogout: '/auth/login',
    onLogin: '/',
    keepRequestedRoute: true,
  },
  logLevel: 5,
}

export default defineNuxtConfig({
  // ssr: false,
  devtools: { enabled: true },
  modules: [
    '@nuxt/test-utils/module',
    'nuxt-auth-sanctum',
  ],
  sanctum: sanctumConfig,
}

Hey @rafailml, I assume you have SSR mode enabled according to what you posted in the description. So, once you hit refresh, Nuxt tries to send a request to your Laravel application, which is not available from the Docker container at localhost:3004, but it is available under the container name (usually laravel.test when you use Sail).
In your case, you should use actual domain instead of localhost referring, I also posted more details about here

Ok, here is my docker-compose.yaml for Laravel side:
name: site_api

services:
    site_app:
        build:
            context: .
            dockerfile: docker/Dockerfile
            target: dev
        entrypoint: php artisan octane:frankenphp --max-requests=1 --port=8000
        ports:
            - 8004:8000
        volumes:
            - .:/app
        networks:
            - dockernet
networks:
    dockernet:

Here is my Nuxt docker-compose.yaml:
name: site_front

services:
  site_node:
    container_name: site_front
    ports:
      - '3004:3000'
    build:
      context: .
      target: dev
      dockerfile: docker/Dockerfile
    environment:
      HOST: <IP_ADDRESS>
    stdin_open: true
    tty: true
    volumes:
      - ./:/app
      - node_modules:/app/node_modules
    networks:
      - dockernet
volumes:
  node_modules:
networks:
  dockernet:

Now my nuxt.config.ts looks like:
const sanctumConfig = {
  baseUrl: 'http://site_app', // Laravel base URL
  origin: 'http://localhost:3004', // Nuxt base URL
  mode: 'cookie',
  endpoints: {
    login: '/api/login',
    logout: '/api/logout',
    user: '/api/user',
  },
  redirect: {
    onAuthOnly: '/auth/login',
    onGuestOnly: '/',
    onLogout: '/auth/login',
    onLogin: '/',
    keepRequestedRoute: true,
  },
  logLevel: 5,
}

In my /etc/hosts file I have:
<IP_ADDRESS>       site_api-site_app
::1             site_api-site_app
<IP_ADDRESS>       site_app
::1             site_app

but I'm getting same result:
[nuxt-auth-sanctum:ssr]  ERROR  Unable to load user identity from API [GET] "http://site_app/api/user": <no response> fetch failed

setting
baseUrl: 'http://site_app:8004',

gives the same result. Also:
baseUrl: 'http://site_api-site_app',
or
baseUrl: 'http://site_api-site_app:8004',

Hey @rafailml, the error message you got means that there is no server running on this address or it is not available in the docker network

Unable to load user identity from API [GET] "http://site_app/api/user":  fetch failed

Can you check that both containers are visible to each other? For example, you can ping them from the inner bash/sh

Yes, I can ping both:
node@b8acbfe782bb:/app$ ping site_app
PING site_app(localhost (::1)) 56 data bytes
64 bytes from localhost (::1): icmp_seq=1 ttl=64 time=0.087 ms
64 bytes from localhost (::1): icmp_seq=2 ttl=64 time=0.096 ms

also
laravel@683c7625fabd:/app$ ping site_node
PING site_node(localhost (::1)) 56 data bytes
64 bytes from localhost (::1): icmp_seq=1 ttl=64 time=0.361 ms
64 bytes from localhost (::1): icmp_seq=2 ttl=64 time=0.188 ms
64 bytes from localhost (::1): icmp_seq=3 ttl=64 time=0.265 ms

but still getting that error

Hey @rafailml, I see, that's weird. Looks like the Nuxt docker image still cannot access the other container during SSR requests, you can try to write some basic useFetch('http://site_app') request to debug this on SSR side, for example during page load or any middleware.
I believe that the problem is not related to the module itself, but feel free to create a minimal repro with your docker setup, then I will be able to help.

Hey @manchenkoff, you are right, the problem was not related to nuxt-auth-sanctum, but to my docker configuration.
What I changed to work? I put both containers in same network. More information here. There is no need to edit /etc/hosts in this case. Then changed:
baseUrl: 'http://site_app:8000'

8000 is my internal port! Not 8004 which is external.
And now it works.
Thanks for your time and sorry for the question that is not related to this wonderful module.
I'm closing this ticket.

Fixed


[Question] Sequential features support guide

Hello to the FuxiCTR team, first of all amazing work with making and keeping this library up-to-date!
I have a question regarding the sequential features support and potentially adding our own sequential feature embeddings. Namely I am aware that the demo/sample6_DNN_with_sequence_features.py exist, however the dataset_config.yaml does not contain preprocessing from csv, instead we take the data directly from tiny_seq. Nowhere do we explicitly specify the sequential features for click_sequence outside of the model_config.yaml which is connected directly to DIN model.
My question related to this: Is there a general example on how we can specify sequential features for any model directly, using the dataset_config.yaml to preprocess from a csv file? How should the feature column in the csv dataset look like in this case?
Regarding the part of adding our own sequential feature embeddings, I have found that fit_sequence_col in fuxictr.preprocess.feature_preprocessor.py sets a default feature_encoder to the feature_map for sequential features - specifically layers.MaskedAveragePooling() located at fuxictr.pytorch.layers.pooling.py. Looking at the code for various embeddings, we have
class MaskedAveragePooling(nn.Module):
 # rest of the code ...
   def forward(self, embedding_matrix, mask=None)
      # with mask
class MaskedSumPooling(nn.Module):
# rest of the code ....
   def forward(self, embedding_matrix)
       # no mask
class KMaxPooling(nn.Module):
# rest of the code ...
   def forward(self, X)
      # with input X

There are two questions related to these pooling layers:

Are embedding_matrix and matrix X one and the same in the above pooling classes, as they are being used in FeatureEmbeddingDict.forward in the same way? If so what is the shape of this embedding_matrix?
How could we make our own Embedders for sequential data, for example an LSTMEncoder instead of the pooling ops such as the code below

 class LSTMEncoder(nn.Module):
    def __init__(self, input_size, hidden_size, num_layers=1, bidirectional=False):
        super(LSTMEncoder, self).__init__()
        self.lstm = nn.LSTM(input_size, hidden_size, num_layers, batch_first=True, bidirectional=bidirectional)

    def forward(self, x):
        outputs, _ = self.lstm(x)
        return outputs

Obviously the above code snippet wouldn't work, but how could one make it work as a sequential embedder? (we might also need a pooling layer following the LSTM layer as well, but I am using this as an example)
The last question is regarding shared embeddings between the sequential and categorical data. For example click_sequence and adgroup_id - is my understanding correct that the values in the click sequence are the same categories as ones in adgroup_id in this example and that is why we can share embeddings? Or how do shared embeddings work and when can we used them?
I apologize for the many questions, but I do appreciate your help in this matter!

Hi! It is a good question. Due to the limit of time, the api doc is not clear enough.
For how to use sequence features, please refer to our SeqCTR benchmark here: https://openbenchmark.github.io/BARS/CTR/leaderboard/amazonelectronics_x1.html
We have benchmarked sequential models on four datasets with sequence features. Take DIN as an example, you can check the README on how to configure and reproduce the experiment. https://github.com/reczoo/BARS/tree/main/ranking/ctr/DIN/DIN_amazonelectronics_x1
Generally, to implement your own pooling, I suggest to follow the DIN model implmentation. When you configure feature_encoder: null, you will obtain the sequence feature in the forward method.
self.lstm = LSTM()
self.pooling = layers.MaskedAveragePooling()

def forward(self, inputs):
    X = self.get_inputs(inputs)
    feature_emb_dict = self.embedding_layer(X)
    seq_feature_embs = feature_emb_dict["SEQ_FEATURE_NAME"] # (NONE, seq_len, emb_size)
    lstm_h = self.lstm(seq_feature_embs )
    pool_out = self.pooling(lstm_h)

For share_embedding, if different features share the same vocabulary, for example, seq_id and target_id or seq_category and target_category, you could choose to share a same embedding table. It serves as a hyper-parameter for model tuning. You could find the detailed example in the above DIN_amazonelectronics_x1.
Note that feature_specs: xxx can be set to update the key-value pairs in feature_cols.

Thank you for the answer! It is much clearer - I was thinking of using sequential features for click prediction which is slightly different than the Amazon Electronics x1 Dataset task. Would you still recommend I use the targets for the specific sequence to train the 'sequence embedding part' of the network separately (like in DIN for amazonelectronics) or should I only use the embedding and backprop through the entire network for the BCE loss, and let the model learn implicit embeddings for sequential features that way?
So to confirm about the feature_encoder: null, because the load method loads first the model then the dataset, we would overwrite the feature_encoder: null with the ones in the dataset config - feature_encoder: layers.MaskedAveragePooling()
which then in fuxictr/preprocess/feature_preprocessor.py would be assigned in the
if feature_spec.get("feature_encoder", None):
      self.feature_encoders[feature] = self.get_feature_encoder(feature_spec["feature_encoder"])

where self.feature_encoders[feature] is being called in FeatureEmbeddingDict.forward method. Is this understanding correct?
In this case why do we still need to specify them in model_config.yaml, wouldn't the dataset_config.yaml specification for the feature_encoder suffice?

I think your first question is an open problem. I guess you can try both and compare them.

If you set feature_encoder: null, the sequence will not be pooled. If the key feature_encoder is absent, the default layers.MaskedAveragePooling() will be used.


ext-dev/optimization

I see some inaccuracies and unnecessary lines in the codebase.

Please resolve conflicts whenever you raise a PR. Also, could you please elaborate, I only see more lines that you have added. You have exe in you commit too. Is the exe functioning as expected


Data Product Preview may fail from 21 Sept 2022 due to IAM role trust policy behaviour change

Recently AWS Identity and Access Management (IAM) is changing an aspect of how role trust policy evaluation behaves when a role assumes itself. Previously, roles implicitly trusted themselves from a role trust policy perspective if they had identity-based permissions to assume themselves. After this change, role assumption always requires self-referential role trust policy grants.
Though most of the AWS customers will not be impacted by this change at all, and only a tiny percentage (approximately 0.0001%) of all roles are involved, unfortunately automated-data-analytics-on-aws (a.k.a Ada) solution does have some code which relies on this implicit trust behaviour and therefore is impacted. Details of this change is in the link below:
https://aws.amazon.com/blogs/security/announcing-an-update-to-iam-role-trust-policy-behavior/
With this impact, after 21 Sept 2022, when user create data product, user might see Preview feature in the Data Product creation process will fail with an error message similar to the screenshot below. A temporarily workaround to by pass this issue is to skip the Preview stage by using the "Skip" button at the bottom and continue to finish creating the data product. None of other features of Ada solution is impacted.

We have identified the code that is impacted by this change and working on a long term fix at the moment. This Issue is create to clarify the situation to anyone who has seen the same error recently. We will keep this issue updated with the latest progress.
Thank you.

This issue has been addressed in Release v1.0.2. As it affects the existing deployment as well, so if you have issues with previous deployment, please upgrade to Release v1.0.2.


healthcare medication schemas

Please link to the issue #…

Moved this to
https://github.com/adobe/xdm/pull/1563


Failed to authenticate repository. Contact staff for more information.

Hello,
I'm trying to add badge codecov to one of my private repositories. All is good, but when travis try to send report to codecov, I get :
Failed to authenticate repository. Contact staff for more information.
Here is my trace
0.71s$ codecov ==> Configuration:      Endpoint: https://codecov.io { service: 'travis',   commit: 'a0dc2435cbe81ed934e95c7267da9a878db5ea32',   build: '31.1',   branch: 'master',   job: '56748258',   pr: 'false',   slug: 'wadinj/Plumetonpote-API',   root: '/home/travis/build/wadinj/Plumetonpote-API',   package: 'node-v1.0.1' } ==> Building file structure ==> Generating gcov reports (skip via --disable=gcov)     $ find /home/travis/build/wadinj/Plumetonpote-API -type f -name '*.gcno'  -exec gcov  {} + ==> Scanning for reports     + /home/travis/build/wadinj/Plumetonpote-API/coverage/lcov.info     + /home/travis/build/wadinj/Plumetonpote-API/coverage/coverage.json ==> Uploading reports     HTTP 400
Thank a lot,
Jonathan

Hello,
No one have idea about this kind of error ?
Thank you,
Jonathan

I'm getting the same error.
See:

https://github.com/boxuk/commit-message-checker/pull/25
https://travis-ci.com/boxuk/commit-message-checker/jobs/58182626#L382


thyroid eye disease

Preferred term label: thyroid eye disease
Synonyms: TED; Graves’ eye disease; Graves’ ophthalmopathy; Graves’ orbitopathy; thyroid-associated ophthalmopathy
Definition: progressive inflammation and damage to tissues around the eyes, especially extraocular muscle, connective, and fatty tissue occurring in patients with hyperthyroidism or a history of hyperthyroidism due to Graves’ disease (PMID:20181974)
Parent term: disorder of visual system AND autoimmune disease
Children terms (if applicable) Should any existing terms that should be moved underneath this new proposed term? N/A
Your nano-attribution (ORCID): 0000-0001-7151-1615
Note: There is an entry for "Euthyroid Graves orbitopathy" but the more common presentation is with hyperthyroidism.

This is equivalent to:
endocrine exophthalmos
I'll add these as synonyms.


freeze_graph successful from command line but fails from Python file

Please make sure that this is a bug. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 16.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: N/A
TensorFlow installed from (source or binary): Binary
TensorFlow version (use command below): tf-nightly-gpu v1.12.0-10390-ge9a2281040 1.14.1-dev20190319
Python version: 3.5.2
Bazel version (if compiling from source): N/A
GCC/Compiler version (if compiling from source): N/A
CUDA/cuDNN version: CUDA 10.0, cuDNN 7.5.0 for CUDA 10.0
GPU model and memory: GeForce GTX 1070 8GB

You can collect some of this information using our environment capture script
You can also obtain the TensorFlow version with
python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
Describe the current behavior
I have a GraphDef and checkpoint I am trying to freeze.  I am able to do so from the command line, but not from a Python file.
Describe the expected behavior
I expect the behavior from the Python file to match the CLI behavior. I am referencing the args on freeze_graph.py and failing to find an issue with my usage.
Code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate the problem.
This is my CLI command that works:
python3 -m tensorflow.python.tools.freeze_graph
    --input_graph=mygraph.pb
    --input_checkpoint=mygraph.ckpt
    --input_binary=true
    --output_graph=frozen_graph.pb
    --output_node_names=mygraph/convolutional10/BiasAdd,mygraph/convolutional13/BiasAdd

And this is my attempted Python file.
from tensorflow.python.tools import freeze_graph

freeze_graph.freeze_graph(
    'mygraph.pb', # input_graph_def
    None, # input_saver_def
    'mygraph.ckpt', # input_checkpoint
    'mygraph/convolutional10/BiasAdd,mygraph/convolutional13/BiasAdd', # output_node_names
    None, # restore_op_name
    None, # filename_tensor_name
    'frozen_graph.pb', # output_graph
    False, # clear_devices
    "", # initializer_nodes
    "" # variable_names_whitelist
    )

If I don't include the variable_names_whitelist arg at the end, then I get this error: TypeError: freeze_graph() missing 1 required positional argument: 'initializer_nodes'. If I do include it, then I get past that weird error and encounter this one instead: tensorflow.python.framework.errors_impl.NotFoundError: mygraph/convolutional10/BiasAdd,mygraph/convolutional13; No such file or directory. Not sure what to make of either of these errors. Why is it using the output_node_names to find a file? Also, why is it truncating the string? mygraph/convolutional10/BiasAdd,mygraph/convolutional13 ≠ mygraph/convolutional10/BiasAdd,mygraph/convolutional13/BiasAdd
Any ideas? Thanks.
Other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.
See above.

Nupur, are you able to take a look at this? Thanks for your help!

Automatically closing due to lack of recent activity. Please update the issue when new information becomes available, and we will reopen the issue. Additionally, given that freeze_graph.py is going to be deprecated with 2.0, I am closing this issue. Thanks!


Add zero grad for npi_unique

Description
Fix for #18074
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[ ] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[ ] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[ ] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[x] add FGradient registeration

Comments
The script in the issue could pass after this change.

@mxnet-bot run ci [unix-gpu]

Hi @haojin2 @sxjscience , could you please help to backport this PR to v1.7.x? thanks!


Fix suite setup issue for Hardware sensor tests

Fix suite setup issue for Hardware sensor tests

Whats the failure here ?


Replace base58-universal dependency with uint8arrays (& add changelog checker)

Summary
This PR replaces usage of base58-universal with uint8arrays

Explain the motivation for making this change. What existing problem does the pull request solve?

We depend on a branch in the base58-universal github repository, instead of on the npm package. This means it has to be built by anyone using webnative (if they use webnative as an npm package). This process can be flaky (#260).
Instead, we can depend on uint8arrays, which is a dependency of many of our dependencies. E.g. js-ipfs-core depends on it.
It makes sense to go with ecosystem momentum here.
Test plan (required)

Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.

The tests run :white_check_mark: . Only DID parsing/generation are affected by this change, and they're fairly well covered by our tests. The behavior is the same as before.
After Merge

Release!

Please excuse that I'm mixing PR concerns here. I'm testing out the changelog checker github action. It seems to work fine :)
If you want to disable the checker, you can opt-out by putting the no changelog label on a PR.
This action only runs for PRs that merge into main.

I don't think we need a changelog item for this PR, as it's purely internals that we're changing.


Check notifications not popping

Can you provide more info about which notifications are "Check notifications"? Or do you mean that all notifications are not being displayed and you need to check it?

I think the problem was general with all notifications not popping up. I’m
forwarding this to Liri the developer, that can correct me if I’m wrong.
On Sun, 5 Jun 2022 at 12:07 AssafHizki @.***> wrote:

Can you provide more info about which notifications are "Check
notifications"? Or do you mean that all notifications are not being
displayed and you need to check it?
—
Reply to this email directly, view it on GitHub
https://github.com/EMMAapp/EMMA/issues/75#issuecomment-1146769390, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AKAWWOIS32DAEBWH2JG5RZDVNRU4VANCNFSM4QO72ANQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Test and repair stay_inside_goal_area and stay_outside_goal_area in Shitty_Field.py

./ai/GameDomainObjects/Shitty_Field.py:89:        # TODO Not tested: stayInsideGoalArea
./ai/GameDomainObjects/Shitty_Field.py:118:        # TODO Not tested: stayOutsideGoalArea

The problem: The current methods for staying inside and outisde the goal area are not tested, they need to be tested and repaired until they are working.

Shitty_field is getting delete


modify definition of the excitation energy for yn_fix_func=y

Can one of the admins verify this patch?

add to whitelist


Does it support multiple GoDot pages like android does

Godot version
3.4
System information
android
Issue description
Now you see that closing the Godot page will execute System.exit(0), which will kill the program. Can we open multiple Godot pages like Android? Each time we close the current page and execute the finish() method, the program will be killed and we cannot go back to the previous page. Even if we hook the program and do not execute system.exit (0), but open the Godot page again, the page cannot be rendered. Black screen.
Steps to reproduce
Start the GoDot page on the Android native page, execute Finish () to close the GoDot page, return to the native page, and open the GoDot page again
Minimal reproduction project
No response

@hongyan0319 Please upload a minimal reproduction project to make this easier to troubleshoot.


Support linting Elastic Beanstalk .config files

Elastic Beanstalk application versions can contain customisation of the base EB stack using .config files.
For example, here's an example file which adds a target tracking scaling policy to the environment's auto scaling group:
Resources:
  ScalingPolicyRequests:
    Type: AWS::AutoScaling::ScalingPolicy
    Properties:
      AutoScalingGroupName:
        Ref: AWSEBAutoScalingGroup
      PolicyType: TargetTrackingScaling
      TargetTrackingConfiguration:
        PredefinedMetricSpecification:
          PredefinedMetricType: ALBRequestCountPerTarget
          ResourceLabel:
            Fn::Sub: ${AWSEBV2LoadBalancer.LoadBalancerFullName}/${AWSEBV2LoadBalancerTargetGroup.TargetGroupFullName}
        TargetValue: 1500

When an application version with this file in it is deployed, Elastic Beanstalk merges this resource snippet with the base template file and updates the stack.
There are a few issues with linting these files right now:

There can be references to resources in the base template which cfn-lint can't find. All base template resources start with AWSEB
There can be top-level keys which aren't part of the template definition: option_settings, packages, groups, users, sources, files, commands, services, container_commands

I'd like to propose that cfn-lint add support for linting this file type. It would do this by only checking the Resources key, and ignoring references too resources starting with AWSEB.
Support could be automatic detection based on file name (*.config, which is required by EB) or adding a new parameter --file-type cfn|eb (defaulting to cfn of course).
If you'd be happy to accept these changes, I'm happy to have a crack in the new year :)

There can be references to resources in the base template which cfn-lint can't find

Can workaround with resource-level ignores:
  ScalingPolicyRequests:
    Type: AWS::AutoScaling::ScalingPolicy
    Metadata:
      cfn-lint:
        config:
          ignore_checks:
          - E1010 # GetAtt
          - E1012 # Ref
          - E1019 # Sub
          - E3005 # DependsOn

There can be top-level keys which aren't part of the template definition

ignoring E1001 should mitigate this:
https://github.com/aws-cloudformation/cfn-python-lint/blob/b6080aa3bd1b7fbe153125c49925beb5186dfab0/src/cfnlint/rules/templates/Base.py#L28

I think we're unlikely to formally pick this up ourselves, but hopefully that helps point in the direction of rules that'd be affected


Pull request for Module 7 assignment

I have copied my Module 5 files to the Module 7 folder and uploaded those to this directory, but I haven't structured the folders, or done the new parts of the assignment yet.

:+1:


Master to Develop

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@af281d0). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop      #68   +/-   ##
==========================================
  Coverage           ?   10.52%
  Complexity         ?        6
==========================================
  Files              ?        3
  Lines              ?      114
  Branches           ?        9
==========================================
  Hits               ?       12
  Misses             ?      102
  Partials           ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af281d0...9dfd879. Read the comment docs.

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@af281d0). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop      #68   +/-   ##
==========================================
  Coverage           ?   10.52%
  Complexity         ?        6
==========================================
  Files              ?        3
  Lines              ?      114
  Branches           ?        9
==========================================
  Hits               ?       12
  Misses             ?      102
  Partials           ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af281d0...9dfd879. Read the comment docs.


Every bundle needs a .dockerignore file that excludes the .terraform directory

When working with TF locally a .terraform directory gets created. If this is copied into the Porter bundle then porter bundle will not build as looks for az cli config.
Each bundle needs a .dockerignore such as https://github.com/marrobi/AzureTRE/blob/710b2155db221bf143a57e972d2cea26db663425/templates/workspace_services/guacamole/.dockerignore . At present the file exists in some, but not others.

/assign

@Sonali-Rajput thank you!


Remove NTS

At many places the term NTS is used. NTS is the Nation wide system for traffic management at the STA in Sweden and we're aiming for a more neutral way (not country specific) of describing functionality.

I think we can include this in 3.3?

I think we can include this in 3.3?

If we remove the term NTS, should we also remove "External NTS alarm code id" (xNid)? That might be a breaking change. Should we make breaking changes in 3.3? Or should we remove NTS in most places, but keep xNid to prevent backwards incompatibilities?


fix: decision metadata enabled fix.

Summary

IsFeatureEnabled was sending impression before finalizing all checks of feature enabled. Just made it after finalization.

Test plan

Need to add unit test.

Pull Request Test Coverage Report for Build 1597

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.75%

Totals

Change from base Build 1595:
0.0%

Covered Lines:
4133

Relevant Lines:
4605

💛  - Coveralls


Spanner: Unskip encrypted backup related tests

And also have proper normal backup related tests that create a backup each time, etc.
This issue is blocked on #1299 .

@shivgautam hope it's ok that I assigned this to you. I don't have enough context on where things are with the tests in C#.


Rename all remaining fedimint-leptos-test refenreces to webimint

TODO: rename to webimint

Originally posted by @elsirion in https://github.com/elsirion/webimint-rs/pull/48#discussion_r1398953151

Resolved (by #40 etc.)


Fix dependencies for react

Need to fix dependencies for react :

Set react and react-dom as devDependencies instead of dependencies
Set react and react-dom as peerDependencies
Add react v16 compatibility

I believe that this is already in the master branch, the only thing left to do, is to make a release, which is already noted in #37.

bump

bump


change methodz property to methodology

Per conversation with @ucsdlib/domm and @lsitu -- We are leaving the label as 'methods' but changing the property name to avoid the keyword conflict with using methods as a property in Ruby.
Changes proposed in this pull request:

methodz -> methodology

@ucsdlib/developers - please review

👍

:+1:


initial commit of Test-DbaMaxDop

Ready for QA! :metal:

Set of tests for this PR
SQL Server 2000

[ ] Don't run on version 2000 and throw an message

SQL Server 2005 - 2014

[ ] Run on instance with max dop configured as recommended - See if the message on 'Notes' column is according with the scenario
[ ] Run on instance with max dop lower than the recommended - See if the message on 'Notes' column is according with the scenario
[ ] Run on instance with max dop higher than the recommended - See if the message on 'Notes' column is according with the scenario
[ ] Run on instance with max dop equals 1 - See if the message on 'Notes' column is according with the scenario
[ ] Run on instance with max dop equals 0 - See if the message on 'Notes' column is according with the scenario

SQL Server 2016

[ ] Run on instance where all databases have MaxDop scoped configuration equal 0 - See if the message on 'Notes' column is according with the scenario
[ ] Run on instance where at least one database have MaxDop scoped configuration equal 1 - See if the message on 'Notes' column is according with the scenario
[ ] Run on instance where at least one database have MaxDop scoped configuration higher than 1 - See if the message on 'Notes' column is according with the scenario

For now I think it is that :smile:

@ClaudioESSilva can you resubmit this PR without the .psd1? @Splaxi are you available to test this command this week?

QA checklist:

[ ] Working/useful help content, including link to command on dbatools web site
[ ] All examples work as advertised
[ ] Does not contain template content
[ ] Does not contain excessive/unnecessary amounts of comments
[ ] Works remotely
[ ] Works locally
[ ] Works on lower versions or throws error specifying version not supported
[ ] Works with named instances
[ ] Works with clustered instances
[ ] Handles offline/read only databases
[ ] Supports multiple servers (at the command line or piped from Get-SqlRegisteredServerName)
[ ] No un-handled errors which stop the command working with multiple servers

Will remove. But I only can tonight.

@ctrlbold psd1 removed :smile:


ImageCache per-thread file cache to deal with thread contention

It's a wash for small thread counts, but for highly threaded renders,
I'm seeing 1-2% speedups across real world scenes.

The code looks good, curious to see the benchmark results.

For the curious, we saw about 6% average speedup in overall rendering time, across a suite of 28 production scenes, in a highly threaded situation (a machine with 52 cores + hyperthread).

LGTM!


fix: incorrect fn naming for counter app

The code for the basic counter app has incorrectly named the decrement counter function as increment_counter and the increment counter function as decrement_counter. This PR resolves the naming issues.

Thanks!


Sync milestone to release

IMPORTANT: Please do not create a Pull Request without creating an issue first.
Problem:
Sync issue's milestone to release and configure request retries.
Solution:
Sync issue's milestone to release and configure request retries.
Related Issue:
harvester/harvester#2896
Test plan:
Change milestone(add, update, clean) by creating an issue, or on an already created issue.

@bk201 I added it into co-author https://github.com/harvester/bot/commit/a302624d070aca7f6c8d473865913a40515a174d, you could close this RP.

Thanks @chrisho


task(groups): Change calling to only include joined participants

What this PR does 📖

Makes it so calls only show joined participants

Which issue(s) this PR fixes 🔨

Resolve #1473### Additional comments 🎤

irrc in the past we wanted to exclude the current user from it. maybe im wrong though?

@Flemmli97 Works well! Just had one suggestion but I guess it depends on what others think as well maybe @XileHorizon can give his opinion. Should we show users own profile within the call ui? Like when I place call and no one else has joined yet instead of showing "Nobody is here" the user would see just their profile avatar. We could also just add at a later more appropriate time in a different ticket if that works!
Screen.Recording.2023-11-10.at.2.14.12.PM.mov

In my designs, I have the user icon in the bottom left corner.


cameras_qcom2: more readable camera_process_frame

Too many ternary, use one "if else" to make it more readable.

for all the different packet names, adeeb says we should use the capnp dynamic api to handle this more cleanly
for the send conditions, maybe we should just add env_send_xxx to each camera_state?


fix(US Kia): Correct temperature settings to match the kia UVO app and the vehicle

In the US Kia Telluride (and I assume other US Kia vehicles) as well as the US Kia UVO app, you are only allowed to set the climate temperature to LOW -> 62-82 <- HIGH. I made changes to the services.yaml file to account for this: 1) Changed the default temperature from 21 to 72, 2) The min to 60, 3) And the max to 85. I also added logic in the vehicle.py file to translate anything < 62 to 'LOW', and anything > 82 to 'HIGH'. Tested it in my system, and all works well.

This will break celsius users which is the majority of the users of the integration.   Services.yaml can't have much logic so thinking that needs to be left pretty open but the default call that you are editing could check the unit or region potentially.

I see, totally get it. How about this solution? I added just a small note to the services.yaml file letting users know that if they have a US Kia, anything <62 will translate to "LOW" and anything >82 will translate to "HIGH", as it is in the vehicle itself and the UVO app. No other changes to the services.yaml file. I then added an if statement to the Vehicle.py file to test for the users region, and if it's US to apply the logic, otherwise things will be as they were previously.
I probably should have mentioned before by the way, but the reason I'm trying to change this is because in the US Kia integration, if you try to set the climate to a number lower than 62 or higher than 85, it causes an error that leads to the engine and the rear defroster coming on, but the AC does not, which is why adding the logic check to the Vehicle.py file is actually a needed fix to prevent this error.

Looks good.  Items like this will also be easier in the 2.0 version in the works.   I tagged you in the last backport.


Github Infinite login loop and not authorized to connect repository

Description
I am testing integration of Github with Dbeaver for my SQL project. I am facing an issue with github continuously.

Created a private repo on github
Tried to clone on Dbeaver - IT FAILED
Then I cloned repo using terminal
Later imported local git folder to Dbeaver
Added a new db connection
Added a test script
When pushing the code, it asks for git credentials

When entering the correct credentials it again asks me for credentials

DBeaver Version
DBeaver Enterprise 21.3.0
Operating System
Windows 11 Pro
Database and driver
No response
Steps to reproduce
No response
Additional context
No response

Hello @priyank04,
You're probably using your account credentials while also having 2-FA enabled. You need to generate an access token and use it as the password.
Please see:
https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/managing-your-personal-access-tokens

That was it. Didn't realize on the MFA for the github account. Thanks for the prompt response.

I'm having the same issue, but even after creating a token, I still get an error when I try to connect.


Cannot Run Migrations because Connection is required to live Forever

Setup
Versions

Rust: 1.83
Diesel: 2.2.6
Diesel_async: 0.5.2
Database: PostgreSQL
Operating System Windows 11

Feature Flags

diesel: postgres, r2d2
diesel_async: postgres, bb8

Problem Description
I am trying to run my migrations in my connect function of my app, but I cannot seem to pass pool to run_pending_migrations because it requires the pool, and henceforth connection to live forever, but it will be freed after run_pending_migrations is done.
What are you trying to accomplish?
Run Migrations in establish_connection :
pub async fn establish_connection() -> Result<DatabasePool, Box<dyn std::error::Error>> {
    // -- Load .env
    dotenv().ok();

    // -- Get Database URL
    let database_uri = env::var("DATABASE_URI").expect("[!] DATABASE_URI Environment Variable Must Be Set");

    // -- Create Manager
    let manager = AsyncDieselConnectionManager::<AsyncPgConnection>::new(database_uri);

    // -- Create Database Pool
    let pool = Pool::builder()
        .max_size(10)
        .build(manager)
        .await
        .expect("[!] Could Not Create Database Pool");

    // -- Define Migrations
    pub const MIGRATIONS: EmbeddedMigrations = embed_migrations!("migrations");

    // -- Get Database Connection
    let mut connection = pool.clone().get().await.ok().unwrap();

    // -- Run Migrations
    MIGRATIONS
        .run_pending_migrations(&mut connection)
        .await
        .map_err(|err| anyhow!("[!] Error Running Database Migrations: {err}"))?;

    // Return Pool
    Ok(pool)
}

What is the expected output?
Migrations are run and app startup is normal
What is the actual output?
error[E0716]: temporary value dropped while borrowed
  --> src\db.rs:41:26
   |
41 |     let mut connection = pool.clone().get().await.ok().unwrap();
   |                          ^^^^^^^^^^^^------                    - temporary value is freed at the end of this statement
   |                          |
   |                          creates a temporary value which is freed while still in use
   |                          argument requires that borrow lasts for `'static`

Are you seeing any additional errors?
Not that I have come across yet
Steps to reproduce
follow my exact setup and course of actions, you can access my repository at https://github.com/TeamHypertrophy/Protein
I will update it shortly.

Checklist

[ x] I have already looked over the issue tracker for similar possible closed issues.

[ x] This issue can be reproduced on Rust's stable channel. (Your issue will be
closed if this is not the case)
[ ] This issue can be reproduced without requiring a third party crate

The run_pending_migrations method expects a type that essentially implement diesel::Connection. That's not the case in your example, therefore the error. See this example for how to run migrations with diesel-async.
As for the error message: That one is really bad, please fill an issue in the rustc issue tracker, as that's the only place where this could realistically be improved.


Add documentation of configuration schema

Codecov Report
Base: 51.93% // Head: 51.86% // Decreases project coverage by -0.07% :warning:

Coverage data is based on head (67f102e) compared to base (2f51e2e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
- Coverage   51.93%   51.86%   -0.07%
==========================================
  Files          24       24
  Lines        1656     1658       +2
==========================================
  Hits          860      860
- Misses        796      798       +2

Impacted Files
Coverage Δ

openqabot/types/incidents.py
18.90% <0.00%> (-0.36%)
:arrow_down:

openqabot/args.py
58.90% <0.00%> (ø)

openqabot/utils.py
100.00% <0.00%> (ø)

openqabot/aggrsync.py
0.00% <0.00%> (ø)

openqabot/approver.py
94.78% <0.00%> (ø)

openqabot/commenter.py
0.00% <0.00%> (ø)

openqabot/smeltsync.py
87.64% <0.00%> (ø)

openqabot/incsyncres.py
89.74% <0.00%> (ø)

openqabot/loader/qem.py
32.63% <0.00%> (ø)

openqabot/loader/smelt.py
56.25% <0.00%> (ø)

... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

+1


Update testcontainers-scala-postgresql to 0.39.11

Updates com.dimafeng:testcontainers-scala-postgresql from 0.39.8 to 0.39.11.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.dimafeng", artifactId = "testcontainers-scala-postgresql" } ]

labels: test-library-update, early-semver-minor, semver-spec-patch

Superseded by #473.


Could you pass children and containerelement to onChange and onChangeEnd to make the latter more useful?

There is not much one can do within onChange and onChangeEnd callbacks with only next and current indexes provided.
Just for my case I need to dynamically change the style attributes on the slides in addition to prop management the simple-slider provides. It is again just a tiny fix allowing for much wider customization.
This would only require the following change starting line 145:
        if (onChange) {
          onChange(actualIndex, nextIndex(), containerElem, imgs);
        }

And the similar for onChangeEnd on line 210.

👍 sounds like a great idea!


Project with 4200 persistent var, save to file an empty file

Hello, my project has "only" 4200 persistent variables, but after "Read from PLC" and "Save to file" the file created has only this result:
{}
Here is my project clean with only persistent Var.
I'm using TwinCat 4024.07
Thanks for your help
Massimo
Backup_2020-02-21-091125.json.txt
CX5130-TwinCat_4024_07.tnzip.zip

Thank you for reporting this bug!
I fixed and tested with your example.


Adds indexing event for saving transferFrom and burnFrom transactions.

Fixes #707
🚀 Description

I have added a new indexing Event to save the transfers from another wallet. I know it is not a game changer.

[x] 📘 I've reviewed the OpenZeppelin Contributor Guidelines
[x] ✅ I've added tests where applicable to test my new functionality.
[x] 📖 I've made sure that my contracts are well-documented.
[x] 🎨 I've run the JS/Solidity linters and fixed any issues (npm run lint:all:fix).

Hello @fragio, I really don't think this must %100 be in the ERC20 but I saw a comment in ERC20.sol _burnFrom function and said "It is simple why not just do it." and thank you for the comments about Transfer event, appreciated. This is kind of improvement which only covers token holders who want to check their data with other spenders like exchanges. But as I said it is not an essential improvement that must be in contracts.

Hi @ardagokcek, thanks for contributing to OpenZeppelin!
After considering this for a while, I think the approach suggested in #707 better suits our current needs, since we're not introducing any new non-standard events. I will keep this in mind though when considering how to differentiate transfer and transferFrom calls.
Thanks again!


If emoj reaction has no points, make it greyscale

filter: grayscale(1);

Fixed and published (used luminosity instead of grayscale, since that's what was already there)


Add a label command to kubectl.

@bgrant0607 @jlowdermilk @smarterclayton

Should this support bulk assignment from day one?  Seems like this is the equiv style command as update.

Yes, it should support bulk assignment.

I was thinking about a postfix minus sign for delete. eg. kubectl label pods foo bar-  I'd prefer a prefix, but I don't think the flags library can handle that.

If the remove label syntax is acceptable folks, I'll code that up and send this for review.

I was thinking about a postfix minus sign for delete. eg. kubectl label pods foo bar-
How would that work with removing multiple labels?

@jlowdermilk
kubectl label pods foo bar- baz- blah- another=value removethis- add=this ...
--brendan

what does bulk update mean in this context?  Do we want to support a label query?  Do we want to support labeling all resources in a collection?
This is kind of unlike update because we don't specify files to relabel.
I'd prefer to add bulk update in a separate PR.

Remove label and bulk update as separate PR sg. LGTM.

On Feb 9, 2015, at 3:46 PM, Brendan Burns<EMAIL_ADDRESS>wrote:
what does bulk update mean in this context? Do we want to support a label query? Do we want to support labeling all resources in a collection?

I think selecting a set of things to make more selective (by adding labels) prior to adding a new thing that uses the old label may not be an uncommon use of this command

This is kind of unlike update because we don't specify files to relabel.

Hrm - it's like delete though, and delete lets you use a directory of config to select the items to delete.

I'd prefer to add bulk update in a separate PR.

I'm fine with it being a follow on that is to be done before 1.0

—
Reply to this email directly or view it on GitHub.

Remove implemented.
@smarterclayton I 100% agree that it will be a common use case.
Promise to do 2 PRs before 1.0 (probably this week):

use a selector to select objects, update all objects matched.
load objects from a config directory

sg?

SGTM
----- Original Message -----

Remove implemented.
@smarterclayton I 100% agree that it will be a common use case.
Promise to do 2 PRs before 1.0 (probably this week):

use a selector to select objects, update all objects matched.
load objects from a config directory

sg?

Reply to this email directly or view it on GitHub:
https://github.com/GoogleCloudPlatform/kubernetes/pull/4237#issuecomment-73589813

Reassigning to @jlowdermilk since he left comments that still look unresolved.

PR updated to document the remove label syntax.

lgtm


[Telegram] Webhook "Active" flag ignored

Description
I noticed that after configuring a Telegram webhook, new repos in a private org trigger the webhook too, even private repos themselves (but this is a separate issue).
I then disabled the webhook by unflagging the "Active" section in the webhook settings, tho it still sends out Telegram messages via the bot.
In the logs I flag the webhook enabled, save the webhook configuration, disable it again and save it again, create a test repository, and finally delete it.
Gitea Version
1.16.5
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
https://gist.github.com/bryanpedini/3f191cf3b8ae706541f511e809961282
Screenshots
N/A
Git Version
2.20.1
Operating System
Debian 10 + official Docker image
How are you running Gitea?
Docker Compose stack: deployments/gitea
Database
MySQL

Is this a system webhook or a repository webhook?

I've noticed a few bugs - which assuming that these represent your problems then should they should fix the problem.

I've noticed a few bugs - which assuming that these represent your problems then should they should fix the problem.

Thank you a lot Zeripath!!

Is this a system webhook or a repository webhook?

Sorry for the missing information, it was a system-wide wehbook that sent a Telegram notification whenever action X happened on the Gitea server.
Would it be possible to take a look at why it sends webooks even for private repos too? Or is it "normal" behavior?

A system webhook runs on every webhook - that is why it is a system webhook.


Create route to display information about single refill spot

When you click a marker, or access it via a permalink like
https://{APP_URL}/refill_spots/{refill_spot_slug}
It should:

Load information about the refill spot
Centre the map at the coordinates, refresh the map
Show the pop up of individual refill spot info

Reference: https://www.figma.com/file/HfT3GwZlpR6q9RScMNdF5D/mymizu-Web-App?node-id=0%3A1

https://mymizu.notion.site/Copy-share-link-for-Refill-Spot-Page-89e414fc14e24998832702ba46a86a0b


Pgina Compilation issue on 64 bit

Dears,
I'm facing one issue, When I compile the latest pgine code for 64 bit on visual studio 2010 and replace with the installation pGinaCredentialProvider.dll in system32 then I'm not able to see pgina credential on screen. Even though I didn't get any error while compilation.
I need to customize code for some testing, Could you please help me on this.
Talha

I tried with debug mode it's working fine but when I compile on release mode it doesn't work.
Please help me.

I had a similar problem which turned out to be caused by missing/mismatched libraries. Try running pGina Configuration utility, going to Simulation tab, switching Simulation Method to "Launch a CreditUI Prompt" and clicking the button. In my case that displayed the error that helped me solve the problem.

I Compiled the same code on Visual Studio 2012 in release mode. Now it's working fine
I guess it was libraries mismatch issue.


Check Pedersen and Sqrt performance

We received a profiling report of the execution of some blocks, which indicates that Cairo native is spending a significant amount of time on Pedersen hashing and performing sqrt operations.

First, we need to rerun several blocks to verify if we get the same results.
In case it is true, it would be good to identify any low-hanging fruit to improve the performance of these operations.

I run some benchmarks locally and got the same results (https://share.firefox.dev/47qLetx). Unfortunately, I couldn't find any possible optimizations to improve this.
I tried updating the pedersen dependency to see if that would improve it, but had no luck (#796).
It seem that pedersen is just a very expensive operation.

It seems that pedersen is just a very expensive operation.

This has been the case for cairo-rs as well, so it checks out. That said, I believe we can improve sqrt on lambdaworks a little bit.


Unity client fails to connect on iOS (Updated for 0.14.5)

Tested on the latest Unity client (0.14.4): When ran on an iOS device, the join room task returned by Client.JoinOrCreate always finish immediately with Faulted status. No connection attempt is received on server-side (running Colyseus 0.14.13).
When running inside Unity Editor on MacOS, Colyseus Unity client is still able to connect.

This issue still remains in the 0.14.5 client.

This turned out to be an inexplicable iOS-specific quirk. By all online documentation, setting NSAllowsArbitraryLoads in XCode's propertly list to true should allow all http connections, but for some reason, our builds refuse to acknowledge this property and we had to add our Colyseus server domain to the exception list. I'm just about fed up with Apple products. But anyway, this issue is not related to Colyseus. Closing.


tests/raftstore: fix down peers test

The test fails occasionally because the down_secs can be 0.

LGTM

Why down_secs can be 0?

Then we should change the behaviour of mock pd, when receives a report for down peers, it should set the down time of these peer to a non-zero value.

Any progress? This issue blocks #1473

ping @huachaohuang

I don't think we should change the behavior of mock pd for this test, it's weird.
The current patch should be enough to ensure the down time is reset after leader switch.
PTAL

I think it's weird too when down time is 0. Maybe we can change the downtime configuration to 1s instead of 0.5s.


Additional fields

Hi, is it possible to provide additional fields inside API response?
Currently using ooth-local login or getStatus I get response similar to this:
<EMAIL_ADDRESS>
Is it possible to add for example permissions key to get response similar to this:
{"user":{"_id":"5af48ba5b91e401fb62800c6","local":{"email":"test@test.com","permissions":"admin"}}}

For this specific use case use the ooth-roles plugin. https://github.com/nmaro/ooth/wiki/Plugins#managing-user-roles

Thanks, it looks like something that I was looking for.


🌲 [Request] Better support for testing in a domain driven design application

Feature Request
Say an application is separated into multiple pairs of a domain implementation project and domain interface project i. e.

The interface project here would utilize its implementation project to define how data from its' domain can be accessed from other domains.  Logically, the interface project should not have any direct connection to a database. However, currently, for it to be tested with ABLUnit, an interface project would need to have a database connection defined in its openedge-project.json file.
It would be useful if it was possible to somehow account for a situation like this in the ABLUnit configuration.

Just want to make sure I'm understanding... the ask is that ABLUnit tests can be run with no database connection?

the ask is that ABLUnit tests can be run with no database connection?

It's the opposite.
Consider two projects in a workspace:

XYZ-Implementation with a database connection
XYZ-Interface with no database connection.

XYZ-Interface references XYZ-Implementation in the Propath.
When running an unit-test in XYZ-Interface project, the code that is tested my run test in the XYZ-Implementation project that relies on the database connection. So we need to understand how to configure the test-runtime for tests in XYZ-Interface to use a DB connection when the openedge-project.json for this project does not require the DB.
Hope that makes sense?

Are these projects co-dependent or is XYZ-Interface dependent on XYZ-Implementation but not vice versa?  The reason I ask is usually terms "Implementation" and "Interface" imply that XYZ-Implementation would depend on XYZ-Interface but the reverse would not be true.

"XYZ-Interface references XYZ-Implementation in the Propath"

How would the database connection be made when executing this code at runtime if the XYZ-Interface project has no database connection?
Can you share details about how the test would execute outside of this extension?  Is there something specific to that environment that we could accommodate within this extension?

So we need to understand how to configure the test-runtime for tests in XYZ-Interface to use a DB connection when the openedge-project.json for this project does not require the DB.

One idea would be to have the test connect to the database using the CONNECT statement in either the @Before or @BeforeAll method.
This extension also allows for executing tests using database connection(s) that differ from the active profile used by the OpenEdge ABL plugin which can be configured in .vscode/ablunit-test-profile.json.  There are two ways this might be accomplished:

Add a profile to openedge-project.json that defines the the database connection and reference the profile name in the extension configuration:{
    "configurations": [{
        "openedgeProjectProfile": "testing with DB"
    }]
}

Add the required parameters necessary to establish connection(s) when the _progres process launches using the additionalArgs field:{
    "configurations": [{
       "command": {
            "additionalArgs": [
                "-pf",
                "path/to/dbconnections.pf"
            ]
        }
    }]
}

Details regarding extension configuration can be found here: resources/ablunit-test-profile.detail.jsonc.  This file also appears in VSCode when you run the Configure Test Profiles command and no .vsocde/ablunit-test-profile.json exists.
Another idea would be to move the test case to the XYZ-Implementation project.  Theoretically unit tests should be testing small components specific to a project.  The requirement of the DB connection implies the test case might actually be testing functionality in the XYZ-Implementation project and would be better suited to execute from that project.  Practically speaking, I understand that code dependencies don't always make so easy.
A third idea would be to mock the XYZ-Implementation code required for this test.  The mock would allow validating behavior to a given response without actually executing the code to create the response, thus eliminating the DB connection required to execute the unit test and reducing the scope of code run during test execution.

Would it be possible to share a project so I can recreate the situation first-hand?  This seems like it could be more of a project architecture question and not specific to this extension, but I could be wrong.  Regardless, if there is functionality that can be added to this extension to help accommodate your use case I'm certainly interested in doing so.  A sample project would help me avoid guesswork and ensure any new functionality is accurate for your use case.

@kenherring thanks for that. We have managed to define a second profile with the DB connections in openedge-project.json and refer to that in the .vscode/abunit-test-profile.json
What bugs me is that the "configurations" array in that file only supports 0 or 1 entries. Is it possible to define multiple configurations (e.g. with small local and large remote databases) and switch them when running a test?
I do not want to select a new profile for the language server.

The array annoys me too :D
It was originally put in place to work with a pre-release version of the VSCode testing api.  That specific functionality didn't make the final cut.
I've been wavering between a few options, or some combination of these options, which could make use of the array.

Remove the array so there is a singular configuration.
Allow multiple entries which define named "profiles".  A profile could be selected prior to test execution.

This would make it easier to run tests for all the environmental permutations the final product needs to function with.

Add files.include and files.exclude fields so that test cases within a project could execute with different config based on which array item was matched.  I'm not totally in love with this idea because it feels like doing so is bad practice, but I haven't completely written off the idea.

Using the @BeforeAll annotation or similar lifecycle functionality tends to result in more repeatable tests due to reduced outside dependency.

Add a testRunProfileKind with values test, debug, or coverage.  This would allow different configuration depending on which test run type is used.  I've been moving farther away from this with time though, preferring to let the extension be opinionated. The option is on the table though.

There is no immediate plan to change the config as I don't have a good reason to just yet.  I'd also like to see how the VSCode testing api evolves as that could affect what profiles are capable of.  That said, any feedback that would help drive the implementation is always welcome.

multiple configurations (e.g. with small local and large remote databases)

Does this result in flaky tests, especially for the large remote (and presumably shared) databases?  My preference is to have developers run tests with exactly the same DBs which are spun up for CI/CD (a docker image containing DBs, or create an empty database from schema on the fly).  This ensures test results for a given commit are always the same (repeatability), and avoids the "works on my machine" problem.
My long term vision is to have a GitHub Action and/or CircleCI orb that can automatically run tests using the config defined for this extension.

Closing for now as I believe you were able to configure this for your scenario, but feel free to re-open or log a new issue if necessary.


Change: RngDropBanner changes

fixed not using banner scale
should work with other rare drops (crazy rng, rngesus, ...)
cleanup

PLEASE TEST THIS, I DID NOT AND CAN'T EVEN TEST THIS !!

Might want to make this an independent slider

Not sure, its a banner so it should be affected by that

We could also just make the general size a bit smaller


What role is needed (besides full admin) to access the new admin center?

you should detail this clearly.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2c9b7f77-061d-a224-ff1c-8d3e15d21221
Version Independent ID: 00fa9550-c4c4-3398-ffbb-271cc724048f
Content: Manage Microsoft Teams features in your Office 365 organization
Content Source: Teams/enable-features-office-365.md
Service: msteams
GitHub Login: @LolaJacobsen
Microsoft Alias: lolaj

@cking22001  Thank you for this feedback
We appricate you pointing out the clerification need on this article. I am sending this to our Teams/Skype for Business team to get this addressed properly.
I was able to get this into the backlog for the Teams/Skype for Business team. The team will get this prioritized into a sprint plan. Thank you for reporting and making the docs better. Much appreciated.
I made a note to request the team to update this when the work is complete.

@SharS is investigating this


ipsec: Feed src_id to traces in do_netdev_encrypt for native routing

Please see the commit message for more details.
Add missing source identity to drop notifications during encryption with native routing mode

This is trivial enough that I don't think we need to run the full end-to-end tests. Marking ready-to-merge.
I've also marked this for backport because it can be argued it's a bugfix, it's trivial, and the commit on which it's based will be backported as well (cf. https://github.com/cilium/cilium/pull/18608).


Use /usr/bin/env bash

This helps us who don't have /bin/bash

any chance this can be merged? it is very small

thanks :)


User cannot set properties for some fields of defect

Test with ALM 12.50
Eclipse Java EE IDE for Web Developers.
Version: Mars.1 Release (4.5.1)
HP ALI Dev For Eclipse: <IP_ADDRESS>50804-2304-RELEASE

This plugin has no relation to Eclipse, you need to report your defect elsewhere.


fix!: Game.mouseCursor and Game.overlays can now be safely set during onLoad

Description
Refactor state management between the GameWidget and a Game instance. Now instead of having multiple properties each having its own state notifications, the Game exposes a unified interface to signal that the internal state has changed. That interface makes sure that changing Game's properties during onLoad() is safe.
The mouseCursor property is now a plain property with a setter, not a ChangeNotifier. Consequently, instead of writing game.mouseCursor.value = ..., one needs to write game.mouseCursor = ... now.
Checklist

[x] The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
[x] I have read the Contributor Guide and followed the process outlined for submitting PRs.
[x] I have updated/added tests for ALL new/updated/fixed functionality.
[-] I have updated/added relevant documentation in docs and added dartdoc comments with ///.
[-] I have updated/added relevant examples in examples.

Breaking Change

[x] Yes, this is a breaking change.
[-] No, this is not a breaking change.

Related Issues
Closes #1493
WIP for #1452

I am not sure about doing a refactor and breaking change due to an issue that could have a simple fix.

The refactor is useful in itself, it's just that we don't usually create issues for refactors. What this refactor does is that it notices that there are 2 (3) Game properties that communicate with the GameWidget, and it would be less code, and less bugs, to do this through a common mechanism.
Current line count for the PR is +56/-102, so it means this approach saves at least 50 lines.
As for the breaking change, the only thing that is breaking here is that instead of game.mouseCursor.value we now say game.mouseCursor. Which is arguably an improvement. If not, this particular part of the PR can be undone -- but I don't think there is a way to effect the change to mouseCursor through the normal deprecation process.

This part of the code is kind sensitive as there are many edge cases, so any refactor here should be done with a lot of care and a lot of testing.

Agree. Perhaps I should add some more tests here? Do you have any recommendations on which specific scenarios to test?
So far, this PR only relied on the existing tests, plus I checked that the examples are working as expected.

I do think the API proposal is an improvement! Not needing to to .value definitely makes it better to read, write, etc.
But the new API will:

Be a breaking change
Require more tests

Meanwhile this bug is already affecting the users, and its fix should be easy, so my proposal here is:

Lets fix the bug with the current source, without generating a breaking change
Lets write more tests for these features
Lets release a patch with the fix

Then in a separate issue/PR we can refactor. Ideally we will want to deprecate the current way so users have a warning before having their code broke.

@erickzanardo I've just tried your suggestion about checking GameWidget.mounted like this:
  void onChangeMouseCursor() {
    if (mounted) {
      setState(() {
        _mouseCursor = widget.game.mouseCursor.value;
      });
    }
  }

However, this didn't work -- the error remains.
I believe the problem is that .mounted is very broad: it's set to true before initState(), and then to false after dispose(). Which means that during build() this property is true, so setState() is still called, and then an exception is thrown because setState() is not allowed to be called during build().
So, ultimately, we need some reliable mechanism to stop any calls to setState() during build(), and then if they do happen, schedule a new build right after the current build finishes.
The approach taken in this PR is probably not very reliable either. Maybe we should add some explicit flags like isBuilding into the game widget, WDYT?


added code to HTML file

This PR adds all the HTML we need for the study guide application.

Added 1st PR code from htnl feature


Re-building stage1-kvm fails

I initially built my stage1-kvm without any problem using:
./autogen.sh && ./configure --with-stage1-flavors=kvm && make
If I try to rebuild it afterwards, I always get the error shown below. I believe a target should be added to clean the built.
I want to rebuild my stage1 stage1-kvm because I need to enable CONFIG_CPUSETS=y which was initially disabled by default in https://github.com/coreos/rkt/blob/master/stage1/usr_from_kvm/kernel/cutdown-config#L152.
I tried couple of times, and I always got into the same error. So I tested other revisions and managed to build it but once I enable this kernel configuration.   Stop.
make[1]: *** [sub-make] Error 2
make: *** [/home/hector/.giantswarm/rkt/build-rkt-1.6.0+git/stamps/__stage1_usr_from_kvm_kernel_mk_bzimage.stamp] Error 2

Could you provide diff of you working directory, because I can not replicate such situation?
Also I have to ensure on which commit your branch is based. Do it contain change provided yesterday in this commit?

Hmmm... looking on error message, this looks like you manually modified .config.
Better error message you will have if you will run make with V=3 - you will get more detailed description of failure.

@jellonek I used the latest version and it worked. However I can only succed to apply my kernel changes if I run the command with make V=*. Otherwise I am not asked during the compilation whether I want to apply new changes to my kernel configuration via a [y|n] steps.
Thanks for your help :)

So could we close this issue, as changing kernel configuration during compilation time shouldn't be IMO required as accessible "for usual cases"? :)

Yes @jellonek, I guess you could close this issue :)