laradock_postgres container exist immediately after starting

Info:

Docker version ($ docker --version): 18.06.0-ce
Laradock commit ($ git rev-parse HEAD): ca80dd1
System info (Mac, PC, Linux): PC (Dell Inspiron 7573)
System info disto/version: Windows 10 Home

Issue:

This is my first attempt using laradock for containerizing a laravel app using Docker Toolbox on windows. I tried to set up an nginx, postgres and pgadmin environment but only the postgres container fails. So it gets started then exits immediately. The logs show that the error
FATAL:  data directory "/var/lib/postgresql/data" has wrong ownership
HINT:  The server must be started by the user that owns the data directory.

Expected behavior:

Like nginx server and pgadmin containers, postgres container should be up so the laravel app can be connected.
Reproduce:

docker-compose up -d postgres
Relevant Code:
Full log
The files belonging to this database system will be owned by user "postgres".
This user must also own the server process.

The database cluster will be initialized with locale "en_US.utf8".
The default database encoding has accordingly been set to "UTF8".
The default text search configuration will be set to "english".

Data page checksums are disabled.

fixing permissions on existing directory /var/lib/postgresql/data ... ok
creating subdirectories ... ok
selecting default max_connections ... 20
selecting default shared_buffers ... 400kB
selecting default timezone ... UTC
selecting dynamic shared memory implementation ... posix
creating configuration files ... ok
2019-06-28 14:27:44.010 UTC [47] FATAL:  data directory "/var/lib/postgresql/data" has wrong ownership
2019-06-28 14:27:44.010 UTC [47] HINT:  The server must be started by the user that owns the data directory.
child process exited with exit code 1
initdb: removing contents of data directory "/var/lib/postgresql/data"
running bootstrap script ...

This issue can be fixed by creating a volume and ataching it to postgres container. I had the same issue on Windows 10.

This issue can be fixed by creating a volume and ataching it to postgres container. I had the same issue on Windows 10.

How did you do it? could show the settings/code? Thanks

docker-compose up -d postgres pgadmin

C:\Users\dhn\git\laradock>docker-compose ps
           Name                          Command                State                         Ports
------------------------------------------------------------------------------------------------------------------------
laradock_docker-in-docker_1   dockerd-entrypoint.sh            Exit 128   2375/tcp, 2376/tcp
laradock_mysql_1              docker-entrypoint.sh mysqld      Exit 255   <IP_ADDRESS>:3306->3306/tcp, 33060/tcp
laradock_nginx_1              /bin/bash /opt/startup.sh        Exit 255   <IP_ADDRESS>:443->443/tcp, <IP_ADDRESS>:80->80/tcp,
                                                                          <IP_ADDRESS>:81->81/tcp
laradock_pgadmin_1            /entrypoint.sh                   Up         443/tcp, <IP_ADDRESS>:5050->80/tcp
laradock_php-fpm_1            docker-php-entrypoint php-fpm    Exit 255   9000/tcp
laradock_phpmyadmin_1         /docker-entrypoint.sh apac ...   Exit 255   <IP_ADDRESS>:8081->80/tcp
laradock_postgres_1           docker-entrypoint.sh postgres    Exit 1
laradock_workspace_1          /sbin/my_init                    Exit 255   <IP_ADDRESS>:2222->22/tcp, <IP_ADDRESS>:8001->8000/tcp,
                                                                          <IP_ADDRESS>:8080->8080/tcp

C:\Users\dhn\git\laradock>docker-compose logs postgres
Attaching to laradock_postgres_1
postgres_1             | The files belonging to this database system will be owned by user "postgres".
postgres_1             | This user must also own the server process.
postgres_1             |
postgres_1             | The database cluster will be initialized with locale "en_US.utf8".
postgres_1             | The default database encoding has accordingly been set to "UTF8".
postgres_1             | The default text search configuration will be set to "english".
postgres_1             |
postgres_1             | Data page checksums are disabled.
postgres_1             |
postgres_1             | fixing permissions on existing directory /var/lib/postgresql/data ... ok
postgres_1             | creating subdirectories ... ok
postgres_1             | selecting default max_connections ... 20
postgres_1             | selecting default shared_buffers ... 400kB
postgres_1             | selecting default timezone ... UTC
postgres_1             | selecting dynamic shared memory implementation ... posix
postgres_1             | creating configuration files ... ok
postgres_1             | 2020-05-30 16:16:26.186 UTC [47] FATAL:  data directory "/var/lib/postgresql/data" has wrong ownership
postgres_1             | 2020-05-30 16:16:26.186 UTC [47] HINT:  The server must be started by the user that owns the data directory.
postgres_1             | child process exited with exit code 1
postgres_1             | initdb: removing contents of data directory "/var/lib/postgresql/data"
postgres_1             | running bootstrap script ...

My solution:

modify the docker-compose.yml :

### PostgreSQL ###########################################
    postgres:
      build:
        context: ./postgres
        args:
          - POSTGRES_VERSION=${POSTGRES_VERSION}
      volumes:
        - ${DATA_PATH_HOST}/postgres:/var/lib/postgresql/data
        - ${POSTGRES_ENTRYPOINT_INITDB}:/docker-entrypoint-initdb.d
      ports:
        - "${POSTGRES_PORT}:5432"
      environment:
        - PG_DATA=/var/lib/postgresql/data
        - POSTGRES_DB=${POSTGRES_DB}
        - POSTGRES_USER=${POSTGRES_USER}
        - POSTGRES_PASSWORD=${POSTGRES_PASSWORD}
        - GITLAB_POSTGRES_INIT=${GITLAB_POSTGRES_INIT}
        - GITLAB_POSTGRES_USER=${GITLAB_POSTGRES_USER}
        - GITLAB_POSTGRES_PASSWORD=${GITLAB_POSTGRES_PASSWORD}
        - GITLAB_POSTGRES_DB=${GITLAB_POSTGRES_DB}
        - JUPYTERHUB_POSTGRES_INIT=${JUPYTERHUB_POSTGRES_INIT}
        - JUPYTERHUB_POSTGRES_USER=${JUPYTERHUB_POSTGRES_USER}
        - JUPYTERHUB_POSTGRES_PASSWORD=${JUPYTERHUB_POSTGRES_PASSWORD}
        - JUPYTERHUB_POSTGRES_DB=${JUPYTERHUB_POSTGRES_DB}
        - SONARQUBE_POSTGRES_INIT=${SONARQUBE_POSTGRES_INIT}
        - SONARQUBE_POSTGRES_DB=${SONARQUBE_POSTGRES_DB}
        - SONARQUBE_POSTGRES_USER=${SONARQUBE_POSTGRES_USER}
        - SONARQUBE_POSTGRES_PASSWORD=${SONARQUBE_POSTGRES_PASSWORD}
        - POSTGRES_CONFLUENCE_INIT=${CONFLUENCE_POSTGRES_INIT}
        - POSTGRES_CONFLUENCE_DB=${CONFLUENCE_POSTGRES_DB}
        - POSTGRES_CONFLUENCE_USER=${CONFLUENCE_POSTGRES_USER}
        - POSTGRES_CONFLUENCE_PASSWORD=${CONFLUENCE_POSTGRES_PASSWORD}
      networks:
        - backend

Make sure you delete first the postgres folder in ./laradock/data (NOTE: I can't help you to restore existing data later, so consider not todo my solution then)

rebuild the container using docker-compose build --no-cache postgres

re-run the container using docker-compose up -d postgres


Update default prompt for bash to use OSC 9;9

Is your feature request related to a problem? Please describe.
OSC 9;9 would allow to open new tab with same cwd. Currently, it requires manual intervention. If it was the default, it would make it easier for more developers to make use of the feature.
Describe the solution you'd like
wrt https://github.com/microsoft/terminal/issues/8166 and https://gist.github.com/skyline75489/d655aede4c729eff178a1c0bfd10f622
It would make it easier for people to make use of this feature if it was the default.
Describe alternatives you've considered
Additional context

Eh, i just remembered, this is on the distro guys not the wsl team.


Lift AbstractString type restriction on summary arg of details

Fixes: https://github.com/JuliaPluto/PlutoUI.jl/issues/295
Allows any type to be used as summary and leaves it up to the user to decide what is rational.
Unlike the details argument, summary is not embedded using embed_display. Instead summary is only wrapped by a simple div with appropriate CSS to provide a decent display for html-like objects.
Examples

summary type
Output

String (unchanged)

@md

@htl

other (dict)

Chrome is currently unhappy :(

Parity on my machine.

Browser
Example

Chrome

Firefox

Quoting: @rgouveiamendes from https://github.com/JuliaPluto/PlutoUI.jl/pull/290#issuecomment-1960407133

... Is there any particular reason why you prefer display: inline-block; to display: inline-flex;? The difference I see is the position of the triangle at the top or bottom of the block. ...

No particular conviction, inline-block was the only option I saw when looking for examples of elements nested within a <summary> tag and it looked good to me.
Upon comparison, inline-flex is most similar to default <summary> behavior with simple contents, though I don't think any nested div solution could perfectly mimic default behavior.

Style
Result

Default <summary>, no nested <div>

Nested div with display: inline-block; (current)

Nested div with display: inline-flex; (proposed)

While doing this comparison I have become partial to inline-flex, but unfortunately it has its own problems! Yet somehow inline-table appears to be a potential panacea to our present predicament.

Style
Result

Nested div with display: inline-flex;

Nested div with display: inline-table;

I cannot say I fully comprehend the depth of the implications were we to opt for inline-table. inline-block makes simple sense to my grug brain, but I'll gladly change the display if those with bigger brains say unto me, "grug, inline-table is good."

I'm really happy with your contributions to PlutoUI! Are you interested in other projects? I'm thinking about:

Something bigger: making ExperimentalLayout more user-friendly https://github.com/JuliaPluto/PlutoUI.jl/issues/237
Similar PRs: more nice display utilities, like a carousel (i have a prototype in https://computationalthinking.mit.edu/Fall23/climate_science/inverse_climate_model/)
New output widgets, see https://github.com/JuliaPluto/PlutoUI.jl/issues/208

Do you know JavaScript? In that case there are lots of possible projects similar to https://github.com/lukavdplas/PlutoMapPicker.jl . Also check out the recent new feature: https://github.com/fonsp/Pluto.jl/pull/2726
Anyway, big thanks for your work so far and maybe we can find something fun to work on! I'm also happy to chat on zulip or have a video call to discuss!

Wow! @fonsp let me see what I can do. I will analyze the links you've mentioned. However, I am quite busy right now... :( Maybe just in summer.
Regarding flex-inline what are exactly the problems you detected @genericallyterrible? I am using it without any problem in Brave (Chrome).

Regarding flex-inline what are exactly the problems you detected @genericallyterrible?

My screenshots above could've been clearer and I should've explicitly stated what I found rather than making assumptions, apologies. With inline-flex, summaries made with @md are fantastic and appear exactly as I'd expect but summaries made with @htl aren't nearly as pretty :(
The following screenshot showcases functionally equivalent markdown and html producing wildly different results when using display: inline: flex.

inline-table is not consistent across Chrome and Firefox so there goes that idea 🙃
Nothing an extra wrapper can't fix though, eh?

Looks good! Let's merge?
@rgouveiamendes My invitation for future contributions was meant more for @genericallyterrible who made a couple of really well implemented pull requests recently but of course everyone should feel welcome to contribute! Open a draft PR when you start working and let's make something nice!

I'm ready to send it!


yarn: 0.20.3 -> 0.21.3

Motivation for this change
Update yarn to latest version
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Applied in 6dd19dc4e31e7c8ebe1789c569782844acfcf945, thank you!


Install newer Karma package to get rid of parseJson dependency

parseJson is a vulnerable package #30

This fixed the GitHub alert for parseJson and introduced a new lower risk timeSpan alert.


build: setup ios example to use locally installed iOS SDK if found

Setup iOS sample app to install iOS SDK locally if found.
This is a similar setup that we use in Remote Habits iOS: Automatically install locally installed iOS SDK if the iOS SDK directory exists at a certain path.
So, if you clone your git repos in the same directory on your computer:
customerio-flutter/
customerio-ios/

Then Flutter SDK will use the locally installed iOS SDK.

Closing this as this has been tackled.


Iceberg DNU When saveToSCM:

When calling saveToSCM: I have the following error:
IceRepository class(Object)>>doesNotUnderstand: #origin:
CGOGitRepository>>iceRepository
CGOGitHostedPackageVersion>>iceRepository
CGOGitHostedPackageVersion>>savePackageSourcesToIndexWithMessage:
CGOGitHostedPackageVersion>>saveWithMessage:andMetadataString:
[ :unit |
unit sourcePackageVersion
	saveWithMessage: commitMessage
	andMetadataString: (self metadataStringFor: unit) ] in CGOGitRepository>>savePackageUnits:withMessage: in Block: [ :unit | ...
Set>>do:
CGOGitRepository>>savePackageUnits:withMessage:
CGOGitRepository>>savePackageUnits:andProjectMetadata:withMessage:
CGOOngoingProject>>saveToSCM:
UndefinedObject>>DoIt
OpalCompiler>>evaluate
RubSmalltalkEditor>>evaluate:andDo:
RubSmalltalkEditor>>highlightEvaluateAndDo:
GLMMorphicPharoScriptRenderer(GLMMorphicPharoCodeRenderer)>>popupPrint
MorphicAlarm(MessageSend)>>value
MorphicAlarm>>value:
WorldState>>triggerAlarmsBefore:
WorldState>>runLocalStepMethodsIn:
WorldState>>runStepMethodsIn:
WorldMorph>>runStepMethods
WorldState>>doOneCycleNowFor:
WorldState>>doOneCycleFor:
WorldMorph>>doOneCycle
WorldMorph class>>doOneCycle
[ [ WorldMorph doOneCycle.
Processor yield.
false ] whileFalse: [  ] ] in MorphicUIManager>>spawnNewProcess in Block: [ [ WorldMorph doOneCycle....
[ self value.
Processor terminateActive ] in BlockClosure>>newProcess in Block: [ self value....

This happens in the following method
iceRepository
	^ (IceRepository origin: repositoryUrl)
		subdirectory: (subdirectory ifNil: ['']); "Optional, default = '' = code in repository root"
		yourself

I checked implementors of origin: and there are no implementors of it in Iceberg in the image. I did not install any previous version of Iceberg, so this should be the version installed by Cargo.

Apparently, this code could be replaced by:
| repository |
repository := IceRepositoryCreator new
		remote: (IceRemote url: repositoryUrl);
		subdirectory: (subdirectory ifNil: ['']); "Optional, default = '' = code in repository root"
		createRepository.
repository register.
^ repository

However, using that, I have another error if the project was already imported (take that I'm starting from a project that is already in git).

If you really whant create another one,
please locate it in a different directory.```

fixed


python311Packages.azure-mgmt-redis: 14.2.0 -> 14.3.0

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 256282 run on x86_64-linux 1

6 packages built:

azure-cli
azure-cli.dist
python310Packages.azure-mgmt-redis
python310Packages.azure-mgmt-redis.dist
python311Packages.azure-mgmt-redis
python311Packages.azure-mgmt-redis.dist


Get route title when using renderTitle

How do I get the title of a route when using the renderTitle property? I tried using below code but it doesn't work.
renderTitle={props => (<CustomTitle { ...props } />)}

When using the default title functionality it works as expected, I can pass the title property in the action to the next route.
Actions.login({ title: 'Hello user' })

route is passed as first argument, so you need to use route.title

Hm, still doesn't work.
The part of my router that I'm having trouble with looks like this:
<Route name="tabbar">
  <Router footer={TabBar} showNavigationBar={false}>
    <Route name="tab_menu" schema="tab" title="Sections" style={styles.route}>
      <Router>
        <Route name="menu" schema="firstView" component={MenuView} />
        <Route name="page" schema="secondView" component={PageView} />
        <Route name="article" schema="secondView" component={ArticleView} />
      </Router>
    </Route>
  </Router>
</Route>

So, when switching to the tab tab_menu the menu route is default.
When dispatching an action from MenuView to go to the page route like this:
Actions.page({ title: 'Sports' })
I get "Sections" as the route.props.title in my custom title.
If I remove the renderTitle prop from my scheme (also tried adding directly to the routes with the same result) I get "Sport" as the title. So it works when using the default title behaviour.

Could you debug? It maybe bug.

Seems like route is not passed to renderTitle callback. I created a PR for ex-navigator to fix this.
https://github.com/exponentjs/ex-navigator/pull/97

Hm, why PR to ex-navigator? ex-navigator is not connected with routing from this component.
As far as i see renderTitle is binded to route within ExRouter:
        if (this.route.props.renderTitle){
            this.renderTitle = this.route.props.renderTitle.bind(this.route);
        }

When passing in the route like in my PR you get an ExRouteAdapter as the first argument in renderTitle. When removing it, you get a ExNavigator. So I guess the .bind part is not working as expected? Do you have any ideas how this could be fixed within RNRF?

So, I found the problem with the .bind and created a PR.

Please check issue for new 3.0 release. Closing this ticket (because it is for outdated 2.x release)


Private autoloads don't work when .doom.d's contents are symlinked

What did you expect to happen?
Autoloads in ~/.doom.d/autoload/misc.el would be autoloaded.
What actually happened?
They are not autoloaded, and don't appear in  ~/.emacs.d/.local/autoloads.el
Additional details:
The files within my ~/.doom.d are symlinked to the actual files in ~/.dotfiles/doom.d.
Steps to reproduce:

Have an autoloads file in .doom.d symlinked as above
Run doom sync
Any autoloads in the symlinked file are not collected

System information:

((system
  (type . darwin)
  (config . "x86_64-apple-darwin19.5.0")
  (shell . "/bin/zsh")
  (uname . "Darwin 19.6.0 Darwin Kernel Version 19.6.0: Thu Jun 18 20:49:00 PDT 2020; root:xnu-6153.141.1~1/RELEASE_X86_64 x86_64")
  (path "~/bin"<EMAIL_ADDRESS>"~/.poetry/bin" "/usr/local/bin" "/usr/bin" "/bin" "/usr/sbin" "/sbin" "/Applications/VMware Fusion.app/Contents/Public" "/Library/TeX/texbin" "/opt/X11/bin" "/Applications/Wireshark.app/Contents/MacOS" "~/.poetry/bin" "~/.local/bin" "~/.local/bin" "~/.emacs.d/bin" "~/Library/Python/3.8/bin" "/usr/local/Cellar/emacs-mac/emacs-27.1-mac-8.0/libexec/emacs/27.1/x86_64-apple-darwin19.5.0"))
 (emacs
  (dir . "~/.emacs.d/")
  (version . "27.1")
  (build . "Aug 20, 2020")
  (buildopts . "--enable-locallisppath=/usr/local/share/emacs/site-lisp --infodir=/usr/local/Cellar/emacs-mac/emacs-27.1-mac-8.0/share/info/emacs --prefix=/usr/local/Cellar/emacs-mac/emacs-27.1-mac-8.0 --with-mac --enable-mac-app=/usr/local/Cellar/emacs-mac/emacs-27.1-mac-8.0 --with-gnutls --with-modules")
  (features . "NOTIFY KQUEUE ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS MODULES THREADS JSON PDUMPER GMP")
  (traits batch server-running envvar-file))
 (doom
  (dir . "~/.doom.d/")
  (version . "2.0.9")
  (build . "HEAD -> develop 1456108d5 2020-09-10 18:03:32 -0400")
  (elc-files . 0)
  (modules :completion company (helm +fuzzy) :ui deft doom doom-dashboard doom-quit hl-todo hydra minimap modeline ophints (popup +defaults) treemacs vc-gutter vi-tilde-fringe (window-select +switch-window) workspaces :editor (evil +everywhere) file-templates fold (format +onsave) multiple-cursors snippets word-wrap :emacs dired electric undo vc :term vterm :checkers syntax spell :tools biblio direnv (eval +overlay) (lookup +dictionary +offline) lsp (magit +forge) pdf :lang clojure data emacs-lisp json javascript (latex +cdlatex) lua markdown (org +roam +jupyter +present +pomodoro) (python +lsp) sh yaml :email mu4e :os macos :config literate (default +bindings +smartparens))
  (packages (org-ref :pin "9465ab") (graphviz-dot-mode :pin "3642a0a") (org-roam-bibtex :pin "89e9121f26cf03bb7820d257cd9d9106916cd1e9" :recipe (:host github :repo "org-roam/org-roam-bibtex")) (org-roam :pin "89e9121f26cf03bb7820d257cd9d9106916cd1e9") (org-roam-server :pin "fe0364ef63928337f442c1d987d17cfe9619df2d") (sparql-mode :pin "62f198256453265af48bef3a0207e80143fbff1e") (ttl-mode :pin "b8f0a3f5125542ec411e4def1f64c4ac087e0140" :recipe (:host github :repo "jeeger/ttl-mode")) (deadgrep) (org-re-reveal :pin "27a0ce45523255b66e7b14567837f0358a747d09"))
  (unpin org-roam org-roam-bibtex company-org-roam bibtex-completion helm-bibtex ivy-bibtex)
  (elpa "n/a")))

I think this is due to the use of file-truename here. This is applied to the autoloads path but not to doom-private-dir, so this test always fails.
This could also be the cause of https://github.com/hlissner/doom-emacs/issues/2288

It shouldn’t matter. file-in-directory-p uses file-truename on both its arguments, as stated in the documentation

I guess more specifically there is a problem because doom-private-dir is not symlinked, but the files within it are (this is the default result of using rcm to manage dotfiles).
(file-truename "~/.doom.d/autoload/misc.el")
;; "/Users/xxx/.dotfiles/doom.d/autoload/misc.el"

doom-private-dir
;; "~/.doom.d/"

(file-truename doom-private-dir)
;; "/Users/xxx/.doom.d/"

(file-in-directory-p (file-truename "~/.doom.d/autoload/misc.el") doom-private-dir)
;; nil

I'd like the last test to return true so that my autoload file is recognised by Doom. I'm not sure if there's any automatic way of fixing this; perhaps I just need to set doom-private-dir manually to the target of the symlink (~/.dotfiles/doom.d).

perhaps I just need to set doom-private-dir manually to the target of the symlink (~/.dotfiles/doom.d).

I think this is your only choice. By linking the contents of ~/.dotfiles/doom.d instead of the folder itself, you have created a non-standard directory structure. Accommodating this is non-trivial (much more complicated than simply removing that file-truename call, and that file-in-directory-p uses file-truename works against us here) and would require a redesign of Doom's core (and sacrifice of some of our optimizations -- resolving symlinks can be expensive in the long run), unfortunately, which is exceptionally low priority when a workaround for non-standard setups already exists (an explicit DOOMDIR).

Makes sense, thank you.
I only have it set up this way because that’s what rcm does so perhaps the solution is to use a different tool to manage dot files.

Is this also the case if ~/.emacs.d is symlinked even if ~/.config/doom is not?

@jedahan No. It doesn't matter if ~/.emacs.d, ~/.config/emacs, ~/.doom.d or ~/.config/doom are symlinks. What matters if the files inside those directories are symlinked. Accommodating every permutation of symlink arrangment inside those directories is impossible.

ahh thanks for clarification, awesome


1.21 support

Issue #103 will have to happen first

Please update to 1.21!

Copied from Discord so everyone can see:
Here's the entire release process:
Part 1: 1.20.5
Part 2: 1.20.6
Part 3: 1.21
Part 1: 1.20.5:

Change the Minecraft version to 1.20.5, resulting in ~150 compile errors
Fix all non-nbt related compile errors
Scan through all 30,000 lines of code to find everywhere that needs to be updated to simultaneously support pre and post item components - requires fixing an unknown number of problems with varying complexity
Repeatedly try to launch the game, fixing an unknown number of crashes in the process with varying complexity
Repeatedly try to join a world, fixing an unknown number of crashes in the process with varying complexity
Test every feature I can think of, fixing an unknown number of crashes and bugs in the process with varying complexity
Repeat steps 4-6 in 1.17, fixing an unknown number of crashes and bugs in the process with varying complexity, and making sure not to break 1.20.5 in the process
Repeat step 7 in other versions (usually at least 1.19.4 and 1.18.2), plus simply launching in other versions, making sure not to break any other version in the process
Repeat step 7 in 1.20.5 (outside of the development environment)

Part 2: 1.20.6:

Similar to Part 1, but will most likely not have any compile errors and will not require scanning the entire project for problems, plus I will only need to test things related to the small change
Release v2.0.1 with 1.17-1.20.6 support

Part 3: 1.21:

Similar to Part 1, but there is currently an unknown number of compile errors and will not require scanning the entire project for problems
Release v2.0.2 with 1.17-1.21 support

Also, while Parts 1-3 is going on, I will be fighting burnout as supporting new Minecraft versions is the most frustrating and unrewarding part of mod development. This will likely involve working other projects.

any progress?? Part 2 completed now!

Most likely, there are successes, I think that the 1.21 update will be released this month

dev branch seems to run perfectly fine on 1.21.1


Feature/Melina-Lillian/footer

Tracking Info
Resolves #7
Make sure your branch name conforms to: <feature|staging|bugfix|...>/<username>/<3-4 word description separated by dashes>. Otherwise, please rename your branch and create a new PR.
Changes
What changes did you make?

Worked on the Get Involved and Footer sections.

Testing
How did you confirm your changes worked?

We tested our changes using the development server on various screen sizes, primarily with the responsive tool.

Confirmation of Change
Upload a screenshot, if possible. Otherwise, please provide instructions on how to see the change.

TODO...

Looks good!


Revert "BUG: allow sample filtering in evaluate-busco qzv (#142)"

This reverts commit 1e9cc2c83f336b7ddb3c6f73978152de6f603055. This issue will be addressed again in a later PR.

ping @ebolyen - hope it works now! 🤞

Thanks!


Set also option as selected

Hi,
how can I set also the original HTML select option as selected if I select a select2 item?
I need this for saving this information inside an DB.
I tried this:
        var selectBox = '.iconselectfield .selectbox';
        $(selectBox).on("select2:selecting", function(e) {
            $(this).prop('selected', true);
        });

But this doesn't add the property selected to the option.
But if I show the value of this in the console (console.log($(this).val());) I get the right option value displayed. But if I log only this I get only the selectbox-element displayed.
This is a little bit confusing me.
Cheers

Anyone looking into this? I am also facing same challenge.
Actually I am working on a web applicaiton where I have to convert default <select> tags with select2 custom dropdown and I did that. The only issue is I am facing is the SYNC.
Sync means, however, the select tag is hidden visually, that might be used for logocal purpose to avoid extra coding with custom one...
Make sense right?
Please do let me know if anyone looking to fix this...
Thanks.

Also related to #4705.  The general issue is that changes made via Select2's API are not consistently reflected in the DOM.


Zones not displayed

I cannot see any of my configured cleaning zones (two zones configured in valetudo) if I start zoned cleaning. I can only see the map, the icons, and the controls (and of course the black lines/routes).
Second question is: I add custom buttons to clean my zones, but cannot set any name. I have few zones (kitchen, floor, living room) and cannot find any suitable icon for it.
I use Xiaomi Roborock S5(0) with newest Valetudo 0.6.1, mqtt and the newest HA+Hass.io (on Rpi3).
My map card:
type: 'custom:valetudo-map-card'
entity: sensor.xiaomi_map
vacuum_entity: vacuum.staubsauger
title: Staubsauger Karte
rotate: 0
map_scale: 3
crop:
  top: 0
  bottom: 0
  left: 0
  right: 0
min_height: 0
custom_buttons:
  - service: script.staubsauger_zone_flur

For your second question, I'll just implement https://github.com/TheLastProject/lovelace-valetudo-map-card/issues/65 as a string next to the button as I originally intended.
The zones... are the available over MQTT? I thought they weren't and that is why I created https://github.com/Hypfer/Valetudo/pull/507.

Ah ok its actually broken? Because you have zone options in
https://github.com/TheLastProject/lovelace-valetudo-map-card#options

Oh, it may be. I never use zoned cleanup. I understand you better now, I'll see if I can reproduce the issue.

For your questions about zones over mqtt. In the mqtt settings in valetudo there is an options box named "provide map data". But I think this is for the live map (png file?!).
If I check my roborock device under mqtt integration section (Home Assistant) I can see following Subscribed topics:
valetudo/Staubsauger/status
valetudo/Staubsauger/attributes
valetudo/Staubsauger/state
and MQTT discovery data:
homeassistant/vacuum/valetudo_Staubsauger/config
under "valetudo/Staubsauger/attributes" I get message like this:
Received 17:14:37
QoS: 0
Payload: mainBrush: 144.8
sideBrush: 44.8
filter: 128.9
sensor: 8.9
cleanTime: 154.8
cleanArea: 8681.6
cleanCount: 593
lastCleanedArea: 4
lastCleaningTime: 3
last_run_stats:
startTime:<PHONE_NUMBER>000
endTime:<PHONE_NUMBER>000
duration: 40
area: 0.3
errorCode: 0
errorDescription: No error
finishedFlag: false
state: cleaning
valetudo_state: cleaning
zoneStatus:

Flur

zoneStatus => my actual choosen zone (room to clean) to clean.

Am I right That your commit #507 on Valetudo is already included in 0.6.1, so that I can use it with these entry:
sensor:
  - platform: mqtt
    state_topic: "valetudo/rockrobo/state"
    json_attributes_topic: "valetudo/rockrobo/zones"
    name: xiaomi_map_zones
    value_template: 'OK'
    scan_interval: 5

No, it is not included. You can see that because it is closed, not merged. But need something similar to be able to implement it I think

Here are few screenshots showing my problem.
Map in HA showing only the map with forbidden zone

Map in Valetudo showing my cleaning zone:

Here are few screenshots showing my problem.
Map in HA showing only the map with forbidden zone

Map in Valetudo showing my cleaning zone:

Well, my point is, if Valetudo doesn't show that zone info in MQTT somehow I can't show it either. I've not really had time to double check if it updates, which is kinda hard to do too because looking at the Valetudo MQTT entity in Home Assistant to check what is exactly in their while cleaning kinda locks up Home Assistant's UI

Well, my point is, if Valetudo doesn't show that zone info in MQTT somehow I can't show it either. I've not really had time to double check if it updates, which is kinda hard to do too because looking at the Valetudo MQTT entity in Home Assistant to check what is exactly in their while cleaning kinda locks up Home Assistant's UI

Hypfer released a new Valetudo version (Valetudo 2021.01.0b0) with completely rewritten mqtt.

Hypfer released a new Valetudo version (Valetudo 2021.01.0b0) with completely rewritten mqtt.

Someone else helped me debug this recently and this should be fixed in b32c9f41b686af0fac46c7e64f51a4d562c8fc13. Please reopen if it's still not fixed.


matplotlib.units.ConversionError using datetime

I'm getting a ConversionError when using datetime as x axes values in matplotlib.
The used environment:
python -m nuitka --version
1.0.6
Commercial: None
Python: 3.10.6 (tags/v3.10.6:9c7b4bd, Aug  1 2022, 21:53:49) [MSC v.1932 64 bit (AMD64)]
Flavor: Unknown
Executable: C:\temp\test\.venv\Scripts\python.exe
OS: Windows
Arch: x86_64
WindowsRelease: 10

python -m pip freeze
cycler==0.11.0
fonttools==4.37.1
kiwisolver==1.4.4
matplotlib==3.5.3
Nuitka==1.0.6
numpy==1.23.2
ordered-set==4.1.0
packaging==21.3
Pillow==9.2.0
pyparsing==3.0.9
python-dateutil==2.8.2
six==1.16.0

The setup of the virtual environment:
python -m venv .venv
.\.venv\Scripts\Activate.ps1
python -m pip install --upgrade pip
pip install --upgrade nuitka
pip install --upgrade matplotlib numpy ordered-set

The Nuitka options:
python -m nuitka --follow-imports test.py

or
python -m nuitka --enable-plugin=numpy --enable-plugin=tk-inter --standalone test.py

The code sample (test.py):
import matplotlib.pyplot as plt
import numpy as np
import datetime as dt

buffer_size = 256

# the following is working
# ---
# x = np.linspace(0, 2 * np.pi, buffer_size)
# y = np.sin(x)
# ---

# this does not work
# ---
dtn = dt.datetime.now() - dt.timedelta(minutes=1)
x = [dtn + dt.timedelta(minutes=(x/buffer_size)) for x in range(0, buffer_size)]
y = np.linspace(0, 100, buffer_size)
# ---

fig, ax = plt.subplots()
ax.plot(x, y)
plt.show()

The output of test.cmd:
Traceback (most recent call last):
  File "C:\temp\test\.venv\lib\site-packages\matplotlib\axis.py", line 1506, in convert_units
    ret = self.converter.convert(x, self.units, self)
  File "C:\temp\test\.venv\lib\site-packages\matplotlib\dates.py", line 1922, in convert
    return self._get_converter().convert(*args, **kwargs)
SystemError: NULL result without error from call

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "C:\temp\test\test.py", line 15, in <module>
    ax.plot(x, y)
  File "C:\temp\test\.venv\lib\site-packages\matplotlib\axes\_axes.py", line 1635, in plot
    lines = [*self._get_lines(*args, data=data, **kwargs)]
  File "C:\temp\test\.venv\lib\site-packages\matplotlib\axes\_base.py", line 312, in __call__
    yield from self._plot_args(this, kwargs)
  File "C:\temp\test\.venv\lib\site-packages\matplotlib\axes\_base.py", line 493, in _plot_args
    self.axes.xaxis.update_units(x)
  File "C:\temp\test\.venv\lib\site-packages\matplotlib\axis.py", line 1454, in update_units
    self._update_axisinfo()
  File "C:\temp\test\.venv\lib\site-packages\matplotlib\axis.py", line 1490, in _update_axisinfo
    self.set_default_intervals()
  File "C:\temp\test\.venv\lib\site-packages\matplotlib\axis.py", line 2254, in set_default_intervals
    xmin, xmax = self.convert_units(info.default_limits)
  File "C:\temp\test\.venv\lib\site-packages\matplotlib\axis.py", line 1509, in convert_units
    f'units: {x!r}') from e
matplotlib.units.ConversionError: Failed to convert value(s) to axis units: (datetime.date(2000, 1, 1), datetime.date(2010, 1, 1))

Do I need some special options in order to compile/run that code correctly?
The code works fine when running in Python or compiling just the main program:
python -m nuitka test.py

Perfect report, it seems that something is afoul with these converters, and needs a change in Nuitka. I will look into it.

i have the same problem,'matplotlib.units.ConversionError: Failed to convert value(s) to axis units: (datetime.date(2000, 1, 1), datetime.date(2010, 1, 1))'.when i want to use ax2.bar(time_series,P[:, 0])

It is not really related to this repo but maybe someone like me found this issue with the ConversionError .
I have solved the problem by matplotlib.pyplot.scatter(x=list(df[DATE_COLUMN].astype('datetime64[us]').values), y=...)
Basically, there was a check for the datetime64[us] type. If you convert data to this type upfront you will avoid the bugged code part.

this works nowadays, however, only if  --enable-plugin=tk-inter is used, it seems like the part in the plugin that queries matplotlib for the backend is broken
Traceback (most recent call last):
  File "C:\Users\Divine\Desktop\PyDis\MAIN~1.DIS\main.py", line 20, in <module>
  File "C:\Users\Divine\Desktop\PyDis\MAIN~1.DIS\matplotlib\pyplot.py", line 1613, in subplots
  File "C:\Users\Divine\Desktop\PyDis\MAIN~1.DIS\matplotlib\pyplot.py", line 934, in figure
  File "C:\Users\Divine\Desktop\PyDis\MAIN~1.DIS\matplotlib\pyplot.py", line 464, in new_figure_manager
  File "C:\Users\Divine\Desktop\PyDis\MAIN~1.DIS\matplotlib\pyplot.py", line 441, in _warn_if_gui_out_of_main_thread
  File "C:\Users\Divine\Desktop\PyDis\MAIN~1.DIS\matplotlib\pyplot.py", line 280, in _get_backend_mod
  File "C:\Users\Divine\Desktop\PyDis\MAIN~1.DIS\matplotlib\pyplot.py", line 342, in switch_backend
  File "importlib.py", line 126, in import_module
  File "<frozen importlib._bootstrap>", line 1204, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1176, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1140, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'matplotlib.backends.backend_tkagg'

And without, I got this, very strange: matplotlib.backends.backend_qtagg, so I guess, it's the real issue, that there is no dependency on the backend. Not sure why we got away without the previously, but adding that it prompts me for using the Qt bindings, and I assume your tk-inter would be prompted and work. For me I would have to manually force tk-inter to be used, since with the backend selection as it is now, it will just use Qt and not work when I enable tk-inter, but it's sort of by design.

Part of the 2.1.4 hotfix release, the matplotlib stuff as well


Document Veracode policy failures ingestion

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description

Please describe your changes: __________________________________
Jira/GitHub Issue numbers (if any): ______________________________
Preview links/images (Internal contributors only): __________________

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[ ] Successful preview build.
[ ] Code owner review.
[ ] No merge conflicts.
[ ] Release notes/new features docs: Feature/version released to at least one prod environment.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://67212d8e0f4d4b4bf58f1bb0--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://672133006f1f19540b4e35a7--harness-developer.netlify.app


Can't tell if Object.Open supports RangeOption or not

Remotes can optionally support RangeOption in Open.  It would be very useful if callers could know in advance which will work.
SeekOption is a required feature so this will work with all remotes.
Fix this by promoting RangeOption could to be a required option - this will need a bit of wrapping with a LimitedReader for remotes which really don't support it.  That would be relatively easy - the wrapping code will be the same for all the remotes so can be written once in fs/.
This needs a test also which should check for

start and/or end being -1
end being bigger than the  length of the object
see https://tools.ietf.org/html/rfc7233#section-2.1 for other possble ideas

Once implemented we can use to

make cat more efficient.
make cryptcheck fetch of the nonce more efficient
optionally make mount use it to read all its data rather than streaming.

From #1585

@B4dM4n do you want me to take your Chunked Reader code and start whacking on it to make the crypt RangeOption work, or are you working on something?

Sure, you can work on this. I'm busy enough with debugging the vfs changes.

I think this issue is done now.  There is outstanding work to make mount use RangeOption, but there is a PR open for that already.


Upgrade to Node.js 16.14.0

Closing this PR since it turned out Angular 13 is required to use Node.js 16.


code to fix quotes with a fullstop at the beginning is a really cool implementation! just a minor error in variable declaration.

The page does not load the quotes with a fullstop at the start, because trumpLowerCase is declared and given a value AFTER you're using it in the code.
var trumpData = JSON.parse(xhr.responseText);
      // fix quotes that start with a random full stop
      console.log(trumpData.value);
      if (trumpData.value.charAt(0) == ".") {
        trumpData.value = trumpData.value.slice(1, trumpLowerCase.length);
      }
      // filter obvious answers
      var trumpLowerCase = trumpData.value.toLowerCase();

when you assign
trumpData.value = trumpData.value.slice(1, trumpLowerCase.length);
trumpLowerCase.length will have a value of undefined,
because you are declaring trumpLowerCase further down in the code(using a variable before giving it a value).
The fix would be to declare trumpLowerCase before the if block.
     var trumpLowerCase = trumpData.value.toLowerCase();
      // fix quotes that start with a random full stop
      if (trumpData.value.charAt(0) == ".") {
        trumpData.value = trumpData.value.slice(1, trumpLowerCase.length);
      }```

Thanks - yeah, I know you can't use a variable before having defined it. I wrote it normally, then rearranged some lines for "clarity" but clearly missed the fact that I hadn't only used that variable in the "filter" section.


feati: initial iroh-embed for using iroh as a library

Design & implement iroh-embed

Hijacking this issue to discuss using Iroh as a library. We've recently had a bunch of interest in being able to embed iroh in other rust applications, using a high level API:

#385
#468
https://social.linux.pizza/@musicmatze/109312862995448032

We've talked a bunch about this as a team, and have been planning to make iroh work as an embeddable library from day one, with numerous iterations on an API to date. Recently we've been focusing on how "iroh as a library" interacts with what we've been calling "iroh-one" up until this point.
For context, iroh-one is a binary that takes the [gateway, store, p2p ] services & runs them together in a single process using in-memory channels for cross-service communication instead of networked RPC calls. @fabricedesre wrote the initial code & is using it in capyloon. Where we've been stuck is on the design of the API for iroh-one.
We spent time as a team thinking about the use case for iroh-one to help inform the API design discussion, and have come to believe the iroh-one use case is the same as what many folks would want from the iroh-as-embeddable-library use-case: you want IPFS functionality, in a single box, with a high-level API. @joepio's API sketch captures this point well.
To that end, we think some renaming might be in order to make this easier to discern. We were initially thinking something like this:

create a new crate called iroh-embed, which is the "server side" bundling of [gateway, p2p, store] services into a single package
iroh-one becomes a thin wrapper around iroh-embed that turns it into a binary
regardless of how it's created, use the same iroh-api interface to interact with iroh

I've worked up a code spike to explore how this would fit together with practice, feedback welcome on that PR:
#485

@b5 @flub can we close this, given that we have merged a first version of iroh-embed?

sure thing, closed by #565


ProductStorage/DefaultProductImporter fails for product with part links

Describe the bug
The product storage fails while saving product with part link-list which is null. Products created with DefaultProductImporter.
To Reproduce
Develop product:
public class MyProductType : ProductType
{
    public List<MyPartLink> MyParts { get; set; }
    ...
}

then: create product by using DefaultProductImporert. An null-ref exception is thrown in ProductStorage.
Additional context
If I initialize the list, it is no problem anymore ( = new List<MyPartLink>();)

It's not really a bug, as we never suggested that MORYX populates that list, as also shown in the samples. However I agree it is inconsistent with other definitions of domain objects and worth a look if we can take care of it in the Framework.

Good point - but maybe it is a low hanging fruit :-)


Fiverr clone

Describe the project you want to add with tech stack
Frontend of fiverr. techStack: Vite.js tailwindcss
Please assign under gssoc

@TusharKesarwani @MohitGupta121  Please assign


Candlestick Chart changes

Design has made tweaks to charts.
move ETH label to top to reduce redundancy

@matt-bullock plz rvw and close if complete

Label is in but needs correct type size and spacing. Closing for now as this can be addressed in ticket 1602


Fix refresh icon alignment for collectibles

this can be done in the Brand audit ticket pherhaps, since it will also update the font size?
https://github.com/orgs/leather-wallet/projects/1/views/1?pane=issue&itemId=39370740

Yes I can fix that in issue #4249 .
@mica000 I was changing the font there to be label.01 but it still looks wrong compared to the design.
In our system label.01 is using 'Diatype' but in the brand audit file it's Inter.
Does it look OK here using label.01 ?


Capv v1beta1

Issue #, if available: https://github.com/aws/eks-anywhere-build-tooling/issues/174
Description of changes:

Update CAPV to v1.0.1 tag
Update capv golang version to 1.16
Removed kube-rbac-proxy from create-manifest.sh as it is removed upstream
Changes to patches:

Locally checked out capv v1.0.1 tag and applied both patches from under the patches/ folder.
The patch for adding support for bottlerocket required changes because the file cluster_template.yaml has been moved upstream.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm


Paragraph selection can be inconsistent

Paragraph selection can be inconsistent resulting in different behaviors esp around copy and paste.
https://user-images.githubusercontent.com/1952520/150236285-d8558660-c7c5-43c3-b11e-bec869b8995e.mov

I can't reproduce this bug anymore, I want to know if you can still reproduce this bug in 👀

I finally got a chance to take a look at this issue. I can replicate it but I think it's expected browser behaviour we probably shouldn't override.
When you do the selection dragging down and then going back up, your cursor is still just below the first paragraph, which places the focusNode of the selection at the start of the new line. Copying and pasting therefore makes sense to include the start of the new line as well.
If you drag down and then drag back up though, but put your cursor is at the end of the first paragraph, so the focusNode of the selection is at the end of the first paragraph, the new line is not included in the copy and paste.
https://user-images.githubusercontent.com/7748470/188322708-acd7c3bb-3819-4dc5-8d08-91322e39d111.mov


Non browser client fails https connection ( 1.1.0-preview3-35497)

Hi
There seems to be bug in preview version of npm "@aspnet/signalr": "^1.1.0-preview3-35497" when using SSL connection ( https / secure socket ). Our SignalR server is not accepting non secure connections and defining secure url does not use secure connection on non browser environment.
Tested in
Windows 10 + NodeJS  v10.11.0
If you look into source code, it hard coded to use "http" client when using nodeJS. See here:
https://github.com/aspnet/SignalR/blob/a51eec7a1d76272721da7437a273b3c6c74c581a/clients/ts/signalr/src/DefaultHttpClient.ts#L10-L13
https://github.com/aspnet/SignalR/blob/a51eec7a1d76272721da7437a273b3c6c74c581a/clients/ts/signalr/src/NodeHttpClient.ts#L4
In NodeJS to open secure http connection it needs https client
Steps to reproduce:
index.js
const signalR = require('@aspnet/signalr');

connection = global._conn = new signalR.HubConnectionBuilder().withUrl(
  'https://URL'
).build();

// Add connection listeners....

connection.start().catch(err => {console.error(err);});

Server responds http https redirection answer: Error: Moved Permanently: 301
If I change source code to use require("https"); instead of require("http");  it goes through.
But fails to Websocket connection Error: Failed to start the transport 'WebSockets': null
to fix that I changed:
https://github.com/aspnet/SignalR/blob/a51eec7a1d76272721da7437a273b3c6c74c581a/clients/ts/signalr/src/WebSocketTransport.ts#L46
http => https and ws => wss
Without secure connection all works as expected

Closed, duplicate created because of Github slow down


Enable test for issue 18956

This issue https://github.com/quarkusio/quarkus/issues/18956 is not longer happening, so enabling the tests.

Depends on https://github.com/quarkus-qe/quarkus-test-framework/pull/228


restore handmade tests to their state immediately before the parser…

…merge, at commit #134

Excellent; thanks for fixing this!


Use the correct pull secret for HCP KubeVirt components

The the kubevirt-csi and cloud-provider-kubevirt pods were not being pulled using the correct pull secret. This resulted in some odd behavior where the mgmt cluster could only deploy these components if the management cluster's global pull secret had access to the containers. Instead, we should be able to pull these components based on the HCP's pull secret.

/test e2e-kubevirt-aws-ovn

/test e2e-kubevirt-aws-ovn

/test e2e-kubevirt-aws-ovn

/lgtm
/approve

/retest-required

/retest-required


propagate keywords (i.e. :debug) from find_method to find

See https://github.com/citizen428/methodfinder/issues/10 for more details.

Thanks a lot @chocolateboy, I'll merge and prepare a new release!


CSHARP-2248: Synchronize JSON driven test files

Turned out to be just as easy to synchronize all out of sync tests at once.

The only way to review this is to just verify that no .cs files were changed.
And that all the .json files that were changed are in a project called Xyz.Tests.Dotnet (and NOT Xzy.Tests).


Ported the molecules tests

I saw only one, the marked-element.  It seemed a good place to get my feet wet and obtain feedback before tackling anything more complicated.

FYI, I signed a CLA last year.  Let me know if I need to sign another.

Yep, just the one thanks!


Blank white screen displayed

I have installed Karavan extension in Visual Studio code. I tried to create a Karavan Integration using the command pallette. I am getting a blank white screen displayed instead of the UI

Whats is your Karavan version?
What Operating system you use?
Could you please attach screenshot/s of your problem?
Do you have any Error messages?
Could you please open View/Command palette/Developer: Toggle Developer Tools  and copy error messages?

Same issue:
Karavan 3.18.4
macOS 13.0 / Apple M1 Pro
Visual Studio Code 1.17.2

No error message
Dev tools console:
console.ts:137 [Extension Host] openKaravanWebView
webview.js:2 message.command activate
20
Failed to decode downloaded font:
20
OTS parsing error: invalid sfntVersion:<PHONE_NUMBER>
webview.js:2 message.command kamelets
webview.js:2 message.command components
webview.js:2 message.command showStartHelp
webview.js:2 message.command open
webview.js:2 saveScheduledChanges true
webview.js:2 Error: Minified React error #130; visit https://reactjs.org/docs/error-decoder.html?invariant=130&args[]=undefined&args[]= for the full message or use the non-minified dev environment for full errors and additional helpful warnings.
at Wl (webview.js:2:188336)
at webview.js:2:136917
at Lo (webview.js:2:148496)
at Us (webview.js:2:192919)
at _l (webview.js:2:179771)
at Dl (webview.js:2:179699)
at Cl (webview.js:2:179562)
at gl (webview.js:2:176549)
at webview.js:2:126370
at t.unstable_runWithPriority (webview.js:2:211571)
webview.js:2 Uncaught Error: Minified React error #130; visit https://reactjs.org/docs/error-decoder.html?invariant=130&args[]=undefined&args[]= for the full message or use the non-minified dev environment for full errors and additional helpful warnings.
at Wl (webview.js:2:188336)
at webview.js:2:136917
at Lo (webview.js:2:148496)
at Us (webview.js:2:192919)
at _l (webview.js:2:179771)
at Dl (webview.js:2:179699)
at Cl (webview.js:2:179562)
at gl (webview.js:2:176549)
at webview.js:2:126370
at t.unstable_runWithPriority (webview.js:2:211571)

Done. I forgot to specify that the blank screen issue happens when on the "Welcome to Karavan" dialog selecting the  Get started button. (Extension 3.18.4)
The extension 3.18.5 does not present that dialog, and yes I can edit a route as it was already possible in 3.18.4

Thanks for your feedback. Yes, this tour was quite buggy. We removed it for now.


feat: changed the export icon

Solving an issue. Changed the icon for export project so that it is different from the icon for export settings. Solves issue #816.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: riagarg sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


fix: fixes an intentional panic issue discovered via clippy

@homu r+

:pushpin: Commit ea83a3d has been approved by kbknapp

:hourglass: Testing commit ea83a3d with merge 4be787b...

:sunny: Test successful - status


Page transition _leaveCb error

Describe the bug
Using latest vite, vue-router and vuex with transition gives:
TypeError: Cannot read property '_leaveCb' of null

Maybe it is a vue-router bug or I am doing something wrong.
Some help please.
Reproduction
https://codesandbox.io/s/fancy-shadow-04mrv?file=/package.json
System Info

required vite version: 1.0.0-beta.8
required Operating System: Windows 10 LTSC
required Node version: 14.4.0
Optional:

npm/yarn version:
6.14.5 / 1.22.4
Installed vue version (from yarn.lock or package-lock.json)
3.0.0-beta.16
Installed @vue/compiler-sfc version
^3.0.0-beta.16

Run vite or vite build with the --debug flag.

vite v1.0.0-beta.8
  vite:config env mode: development +0ms
  vite:config env: {} +2ms
  vite:optimize Hash is consistent. Skipping. Use --force to override. +0ms
Port 3000 is in use, trying another one...
  vite:optimize Hash is consistent. Skipping. Use --force to override. +105ms

  Dev server running at:
  > Network:  http://<IP_ADDRESS>:3001/
  > Local:    http://localhost:3001/

  vite:server server ready in 351ms. +0ms

vite v1.0.0-beta.8
  vite:config env mode: production +0ms
  vite:config env: {} +1ms
Building for production...
[write] dist\_assets\index.2ffa22c9.js 74.65kb, brotli: 25.24kb
[write] dist\_assets\style.3b64d8ed.css 0.23kb, brotli: 0.09kb
[write] dist\index.html 0.66kb, brotli: 0.27kb
Build completed in 3.67s.

Provide the error log here.

TypeError: Cannot read property '_leaveCb' of null
    at Object.beforeEnter (https://04mrv.sse.codesandbox.io/@modules/vue.js:5176:33)
    at mountElement (https://04mrv.sse.codesandbox.io/@modules/vue.js:4020:28)
    at processElement (https://04mrv.sse.codesandbox.io/@modules/vue.js:3967:13)
    at patch (https://04mrv.sse.codesandbox.io/@modules/vue.js:3880:21)
    at componentEffect (https://04mrv.sse.codesandbox.io/@modules/vue.js:4343:21)
    at reactiveEffect (https://04mrv.sse.codesandbox.io/@modules/vue.js:295:24)
    at effect (https://04mrv.sse.codesandbox.io/@modules/vue.js:270:9)
    at setupRenderEffect (https://04mrv.sse.codesandbox.io/@modules/vue.js:4309:27)
    at mountComponent (https://04mrv.sse.codesandbox.io/@modules/vue.js:4267:9)
    at processComponent (https://04mrv.sse.codesandbox.io/@modules/vue.js:4223:17)

Likely a vue-router + vue 3 issue, either way this is not related to Vite. I'd suggest opening the issue in vue-router's repo instead.


Update README badges

New Spack badge 👌🏻
We should probably merge https://github.com/spack/spack/pull/17685 before this patch
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This is gtg now as https://github.com/spack/spack/pull/17685 was merged

This looks like (the sharper badges):


Cron monitor slug truncates if Celerybeat periodic task name contains a 2nd ":"

How do you use Sentry?
Sentry Saas (sentry.io)
Version
2.13.0
Steps to Reproduce
We are using the automatic Celerybeat integration. We are seeing odd slug names being generated by Sentry.
We have several periodic tasks that we have setup with names like:

"Office: Send Daily Reminder Email (8:00 am)"
"Office: Send Daily Reminder Email (8:30 am)"
"Office: Send Daily Reminder Email (9:00 am)"
"Office: Send Daily Reminder Email (9:30 am)"

The slugs that get registered in Sentry are:

"Office: Send Daily Reminder Email (8:00 am)" -> office-send-daily-birthdayanniversary-email-8
"Office: Send Daily Reminder Email (8:30 am)" -> office-send-daily-birthdayanniversary-email-8
"Office: Send Daily Reminder Email (9:00 am)" -> office-send-daily-birthdayanniversary-email-9
"Office: Send Daily Reminder Email (9:30 am)" -> office-send-daily-birthdayanniversary-email-9

Initially, we thought that the slug name had an undisclosed maximum character length however we discovered that occurs if there is a 2nd : (colon) in the name and it truncates the slug after that.
This had led to some strange results in Cron Monitoring where 2 separate check-ins are made on a monitor configured for a single time:

Expected Result
Expected unique slugs that did not truncate.
Actual Result
Two separate periodic tasks with unique names getting the same slug name due to the truncation.

@peterfarrell, could you please share a minimal reproduction? I tried to reproduce your error with the code snippet provided below, but got the following monitor slug in Sentry, which was not truncated: office-send-daily-reminder-email-800-am.
In any case, this problem likely does not originate from the SDK, since the SDK appears to send Office: Send Daily Reminder Email (8:00 am) as the monitor slug. Likely, Relay or possibly the Sentry backend are converting the provided text to a valid monitor slug. Depending on what I find from the minimal reproduction you provide, I will transfer this issue to the appropriate repository.
As a workaround, I would suggest setting the task name to a valid monitor slug. Valid monitor slugs can include lowercase letters, numbers, dashes, and underscores. Setting the task name to a valid monitor slug is also probably generally a more robust solution.

@szokeasaurusrex I don't the slug truncation in the SDK just as you found. It appears it's happening upstream which is impacting the auto-instrumentation with Celery Beat.

This is about the backend slugification logic so I will transfer this issue to the main sentry repo and tag the Crons team.


use bevy_utils::HashMap for better performance. TypeId is predefined …

…u64, so hash safety is not a concern
Objective

While reading the code, just noticed the BundleInfo's HashMap is std::collections::HashMap, which uses a slow but safe hasher.

Solution

Use bevy_utils::HashMap instead

benchmark diff (I run several times in a linux box, the perf improvement is consistent, though numbers varies from time to time, I paste my last run result here):
cargo bench -- spawn
   Compiling bevy_ecs v0.9.0 (/home/lishuo/developer/pr/bevy/crates/bevy_ecs)
   Compiling bevy_app v0.9.0 (/home/lishuo/developer/pr/bevy/crates/bevy_app)
   Compiling benches v0.1.0 (/home/lishuo/developer/pr/bevy/benches)
    Finished bench [optimized] target(s) in 1m 17s
     Running benches/bevy_ecs/change_detection.rs (/home/lishuo/developer/pr/bevy/benches/target/release/deps/change_detection-86c5445d0dc34529)
Gnuplot not found, using plotters backend
     Running benches/bevy_ecs/benches.rs (/home/lishuo/developer/pr/bevy/benches/target/release/deps/ecs-e49b3abe80bfd8c0)
Gnuplot not found, using plotters backend
spawn_commands/2000_entities
                        time:   [153.94 µs 159.19 µs 164.37 µs]
                        change: [-14.706% -11.050% -6.9633%] (p = 0.00 < 0.05)
                        Performance has improved.
spawn_commands/4000_entities
                        time:   [328.77 µs 339.11 µs 349.11 µs]
                        change: [-7.6331% -3.9932% +0.0487%] (p = 0.06 > 0.05)
                        No change in performance detected.
spawn_commands/6000_entities
                        time:   [445.01 µs 461.29 µs 477.36 µs]
                        change: [-16.639% -13.358% -10.006%] (p = 0.00 < 0.05)
                        Performance has improved.
spawn_commands/8000_entities
                        time:   [657.94 µs 677.71 µs 696.95 µs]
                        change: [-8.8708% -5.2591% -1.6847%] (p = 0.01 < 0.05)
                        Performance has improved.

get_or_spawn/individual time:   [452.02 µs 466.70 µs 482.07 µs]
                        change: [-17.218% -14.041% -10.728%] (p = 0.00 < 0.05)
                        Performance has improved.
get_or_spawn/batched    time:   [291.12 µs 301.12 µs 311.31 µs]
                        change: [-12.281% -8.9163% -5.3660%] (p = 0.00 < 0.05)
                        Performance has improved.

spawn_world/1_entities  time:   [81.668 ns 84.284 ns 86.860 ns]
                        change: [-12.251% -6.7872% -1.5402%] (p = 0.02 < 0.05)
                        Performance has improved.
spawn_world/10_entities time:   [789.78 ns 821.96 ns 851.95 ns]
                        change: [-19.738% -14.186% -8.0733%] (p = 0.00 < 0.05)
                        Performance has improved.
spawn_world/100_entities
                        time:   [7.9906 µs 8.2449 µs 8.5013 µs]
                        change: [-12.417% -6.6837% -0.8766%] (p = 0.02 < 0.05)
                        Change within noise threshold.
spawn_world/1000_entities
                        time:   [81.602 µs 84.161 µs 86.833 µs]
                        change: [-13.656% -8.6520% -3.0491%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high mild
Benchmarking spawn_world/10000_entities: Warming up for 500.00 ms
Warning: Unable to complete 100 samples in 4.0s. You may wish to increase target time to 4.0s, enable flat sampling, or reduce sample count to 70.
spawn_world/10000_entities
                        time:   [813.02 µs 839.76 µs 865.41 µs]
                        change: [-12.133% -6.1970% -0.2302%] (p = 0.05 < 0.05)
                        Change within noise threshold.

Changelog

This section is optional. If this was a trivial fix, or has no externally-visible impact, you can delete this section.

use bevy_utils::HashMap for Bundles::bundle_ids

Migration Guide

This section is optional. If there are no breaking changes, you can delete this section.

Not a breaking change, hashmap is internal impl.

LGTM. Could you also try using the FxHash used by Components here too? Could net a bit more of a performance gain.

Ha, I'm just thinking replace the HashMap for component with AHash, so we can drop one dependency.

LGTM. Could you also try using the FxHash used by Components here too? Could net a bit more of a performance gain.

@james7132 I tried FxHash, the performance difference is not obvious. Also fxhash repo is not well maintained compare to ahash. so I modify component's hashmap to ahash, is it ok?

@james7132 sure, I'll do a test. The key is figuring out which HashMap is better(runtime perf faster) with Key = u64.  "std::collections::HashMap", "hashbrown::HashMap" combine with Hasher "FxHash", "AHash".

I just finished the benchmark.
In my benchmark, with u64 as key, fxhash both faster and smaller than ahash. Details pls refer to https://github.com/shuoli84/rs_hashmap_bench. Benched in arch arm64, lto = 'fat' and opt-level as 3. I'll update the pr to use fxhash for both Component and Bundle.
get_std_default_2000    time:   [16.483 µs 16.498 µs 16.515 µs]
get_std_fxhash_2000     time:   [6.4908 µs 7.3761 µs 8.4999 µs]
get_std_ahash_2000      time:   [6.7078 µs 9.1841 µs 13.483 µs]

insert_std_default_2000 time:   [34.214 µs 34.263 µs 34.296 µs]
insert_std_fxhash_2000  time:   [5.0889 µs 5.0895 µs 5.0901 µs]
insert_std_ahash_2000   time:   [7.3801 µs 7.3832 µs 7.3858 µs]

fxhash's code size is also smaller.
std_fxhash around 52 instructions.
std_ahash around 76 instructions.

@james7132 ping


add alertdialog before signout

#63

I made new pull request. Since the previous one ( #81 ) is really messed up

checkstyle rules are getting violated. Please look into it.

Done. It looks okay now

Merged in 39507e2d2e3f775cf461467ed3b42b4483721226 👍


Have an option to print the URL and body of the request that will be sent to the server

For educational purposes it would be cool if you could request to have kubectl dump to stdout or stderr the REST path and request body corresponding to the kubectl command you run. Perhaps if this were implemented it would make sense to also have a "dry run" mode so you would only get this output and not actually make the request to the server.

@davidopp what's the difference between using high log level and using this option? use --v=10 will also print the URL and request body that will be sent to the server. As for dry-run I think many of kubectl commands has implement this functionality.

Oh cool, I didn't realize --v=10 already did this. Thanks!


Fix compatibility issues with TypeScript v5.5

The type of LargestContentfulPaint conflicts with the new<EMAIL_ADDRESS>which throws an error:
error TS2687: All declarations of 'element' must have identical modifiers.
error TS2687: All declarations of 'id' must have identical modifiers.
...

The type has readonly which requires our type to be identical as well. The TypeScript:
// typescript@5.5.2/node_modules/typescript/lib/lib.dom.d.ts:14706:14

/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/LargestContentfulPaint) */
interface LargestContentfulPaint extends PerformanceEntry {
    /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/LargestContentfulPaint/element) */
    readonly element: Element | null;
    /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/LargestContentfulPaint/id) */
    readonly id: string;
    /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/LargestContentfulPaint/loadTime) */
    readonly loadTime: DOMHighResTimeStamp;
    /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/LargestContentfulPaint/renderTime) */
    readonly renderTime: DOMHighResTimeStamp;
    /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/LargestContentfulPaint/size) */
    readonly size: number;
    /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/LargestContentfulPaint/url) */
    readonly url: string;
    /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/LargestContentfulPaint/toJSON) */
    toJSON(): any;
}

Fixes #498

@philipwalton Sorry to ping you, this issue is a blocker of upgrading TypeScript version, would love your review for it. 🙏

This is added in v4.2.1, let me know if you're still seeing issues after upgrading.


Review of AIPS structure

Own branch for discussing comments, questions, corrections

added an overview picture in the related branch

showing the module types with the currently already known indivdual modules
along with some information about input/output exchange
profileInstances notes
and possible service ideas

moved all relevant changes from related branch to #31


function flash() not working with redirect()

Here's the example:
from flask import Flask, flash, get_flashed_messages, redirect, url_for

app = Flask(__name__)
app.secret_key = 'some_secret'

@app.route('/')
def index():
    app.logger.debug(get_flashed_messages())
    return 'Hello world'

@app.route('/generate/success')
def page_success():
    flash('This message will be visible!')
    return str(get_flashed_messages())

@app.route('/generate/fail',)
def page_fail():
    flash('This message will be lost!')
    return redirect(url_for('index'))

if __name__ == "__main__":
    app.run()

As you can see flash() fails when using redirect. Tried with SERVER_NAME both set and unset. Using Flask==0.10.1.
Please resolve the issue ASAP since it's a top blocker in my project.

Encountered this today, removed APPLICATION_ROOT, and problem fixed.  Thanks for the update after your fix @robin92, much appreciated.

I am having the same issue and I don't have an APPLICATION_ROOT in my project. After flashing a message, if I return redirect('/ ') the message doesn't appear on the redirected page but if I comment out the redirect and use return render_template("index.html") the message does display.
Setting cache timeout to 0 "fixes" this but this site relies on caching for performance reasons so if there is some way to get message flashing to work on redirect and WITH caching enabled, please let me know. Thanks!!


Number of calls?

Hi,
I'd like to know the number of calls that this makes to Lithium.  During the import process, on subsequent refreshes, etc.
Also, is it possible to reduce the amount of data pulled by limiting the scope to certain categories or boards?
Thank you.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6faf733f-4da2-a32d-4ca4-a275a6b4a2e0
Version Independent ID: 0181ac54-9860-96de-cf20-7f95a85cf84a
Content: Connect to Lithium with Power BI - Power BI
Content Source: powerbi-docs/service-connect-to-lithium.md
Service: powerbi
GitHub Login: @SarinaJoan
Microsoft Alias: sarinas

Thanks for your comment, @tofu001 .
We’ve forwarded your feedback to the writer, who should respond to this thread shortly. Thanks!

Hi, @tofu001 -- I'll see if I can find an answer to your question. Thanks!

Hi @maggiesMSFT, were you able to find any info about this?

Hi @tofu001 -- ugh, I'm sorry, no info yet. I'll ping the PM again. Thanks for the reminder.

Closing b/c this content pack will be deprecated on Sept. 25.


chore: bdd-nh-1584299001 to 0.0.1

chore: Promote bdd-nh-1584299001 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


[spdlog] update to v1.5.0

Library name: spdlog
New version number:  v1.5.0
Other information that may be useful (release notes, etc...)
https://github.com/gabime/spdlog/releases/tag/v1.5.0

Also need to update to 1.6.0.

Hi @L-Sun
Thanks for posting this issue.
spdlog has been updated to 1.6.1. Please try to update vcpkg and use it.


bug (or not) with pause and onComplete

When I use the function :
$(function(){
$('.timer').startTimer({
onComplete: function(){
console.log('Complete');
},
allowPause: true
});
If you do nothing, the console show 'Complete', but if you pause it (by clicking on timer), at the end time, there is nothing on the console to try :
https://rawgit.com/caike/jQuery-Simple-Timer/master/examples/index.html

Thank you for catching this! It's been fixed.


Documentation

Normally, docs provide the logical foundation, or motivating factors for a project.
I would really, truly love to see that added. FOAAS provides new and exciting ways to communicate with, and about, coworkers.

http://foaas.com is self documenting.


Revert "[flutter_tools] always initialize the resident runner from di…

…ll (#52497)"
This reverts commit f149eec31bfeb5b165cdd507397c657c8c876b56.

This is the revert for https://github.com/flutter/flutter/issues/54420

cp label is used on the issue rather than individual commits, so removing it here.
https://github.com/flutter/flutter/commit/a1636b6fef2ebe7840ba6dc1b3f9d77095ef3b45 doesn't merge cleanly into flutter-1.17-candidate.3 - @jonahwilliams or @zanderso can one of you manually merge it and cc me on the PR for review?

Yeah, I can take care of that today


build out of sync? Still at 0x020503, looks like 2.5.3 rather than 2.6.0

Could it be that
__build__ = 0x020503

at https://github.com/kennethreitz/requests/blob/master/requests/init.py#L46
went out of sync? It looks like 2.5.3 rather than 2.6.0.
Best, Sebastian

Yup, this looks wrong.


Missing underscored

Where did underscored go? It was present in 0.8.0.

Found it!
https://funcool.github.io/cuerdas/latest/
is not up to date. (current 1.0.2 not 1.0.1)

Updated, thanks!


Working on a C2C video conferencing application

Trying to stream to a server (which I own, I have root access, using a single IP address and whatever ports needed) however I can't find a way of using the StreamServer or StreamClient classes by @hepin1989 to stream from one client to another.
Localhost works fine however I have a requirement of using intermediary server.
Any suggestions would be appreciated!

hello rishi, are you already done this engine ?
I'm looking for some like webinar, (video conference) in java, I found the xuggler plugin .
Did you heart about it ?
https://github.com/piotr-wilczynski/VideoConference
I need to develop an poc about web conference online ...
If you have further  information, please could you share?


Add brandmaster envs to the satellites studios

The secrets for brandmaster to work with the satellites studios are missing:
SANITY_STUDIO_BRANDMASTER_URL,  SANITY_STUDIO_BRANDMASTER_PLUGIN_SOURCE
These secrets should be passed as arguments to the docker file, following the same approach used for the sanityPreviewToken

Labeled this with on hold since we do not actually need news letters for the satellites. We need to figure out how to proceed with this task.

This is actually needed

Hi @nilsml, can you review this one? The approach used was fetching the secrets from github, passing as arguments to the dockerfile, and converting to an environment variable - as we did during xmas.
The only secrets that now needs to be manually added are:
        - BRANDMASTER_EMAIL_CLIENT_SECRET
        - BRANDMASTER_EMAIL_PASSWORD

For the global web instance

I will have a look

Seems to be working. Closing!


batching in vllm

Team, I was trying to run VLLM with AWQ & FP16 with batch size of 32 & my prompts are approx 1000-2000 tokens. I was running on 1x A100 80GB system & I have observed a strange thing, in the entire batch the first sequence is taking most time to generate response among all the sequence. Please see the below example for batch id 9 where time to complete is around 20 sec for first sequence & remaining sequences are less than 1 sec. Same type of pattern I have observed for rest of batches I ran.

Did anyone observed the same pattern while using batches in VLLM  or has any idea on why we are getting this pattern ?

How are you calculating the time for each sequence?
vLLM will process as many of the sequences in the same batch as your system allows (based on GPU memory). If you're calcuating sequence_i's time as arrival_time_i - arrival_time_i-1 then these results are what I would expect

Closing as stale.


Creating Crow server in Server class

Hello.
I want to create Crow server in object oriented paradigm. Something like this:
class Server
{
public:
	Server(){
		Application = new crow::SimpleApp;
		Application->route("/", [&](const crow::request& req, crow::response& res) {
		return "index"});
	};
;
private:
	crow::SimpleApp* Application;

But I get error with route method of my Application method - "no instance of function template ...". Tell me please, how I supposed to property use route method properly to create route analogically to this:
CROW_ROUTE(Application, "/")([](const crow::request& req, crow::response& res) {
        return "index";
        });

CROW_ROUTE looks like this -> #define CROW_ROUTE(app, url) app.route<crow::black_magic::get_parameter_tag(url)>(url). Maybe try something like this:
Application->route<crow::black_magic::get_parameter_tag("/")>("/")([&](const crow::request& req, crow::response& res) {return "index"});?

On this case I get:

Look into code ;) If you pass request and response object, then lambda can't return anything.

@mrozigor thank you 😊


Search engines indexing old releases

Problem:
Google search for "kubernetes secrets v2" returns:

(notice the URL subdomains)
Proposed Solution:
I need to do some more research but a few things come to mind:

enableRobotsTXT = true is in config.toml and set in the couple release-1.xx repos I checked.
X-Robots-Tag: noindex is set in layouts/index.headers. I believe this is for non-prod sites that are running, however I believe even the old released sites are considered "production"

That is assuming robots tag is the culprit. What's also strange is that the above robot config is set in release-1.19 but doesn't appear in the search results
I also think looking at old robot TXT issues might help. It's possible this problem has been solved and phased out with future releases.
/priority important-soon
/triage accepted
/help
/cc @reylejano

In the v1.19 docs, <META NAME="ROBOTS" CONTENT="INDEX, FOLLOW"> appears in the page head. That's wrong.

/lifecycle frozen

/retitle Search engines indexing old releases
Also, the upcoming release is also being indexed and we don't actually want that. Same cause I think.

I've proposed a PR to fix this.
:crossed_fingers:

/reopen
We also need to merge 4 backport PRs.

[Backport PRs]

v1.19
v1.20
v1.21
v1.22

It's fixed. I checked.
/close


[Feature Request] Update the JDA version to the last version

Is your feature request related to a problem? Please describe.
Update to the new update of JDA (https://github.com/DV8FromTheWorld/JDA/releases/tag/v4.3.0)
Describe the solution you'd like
Just update the JDA version for use the / commands and more !
The bot uses JDA version (4.2.1_253). But the latest version is 4.3.0
Describe the basic flow/steps of using this feature
How this feature would be used:

This is not a bug or an enhancement, just an update of JDA.

Additional context
None
Please check the following links to confirm that your feature has not already been requested:
https://github.com/jagrosh/MusicBot/labels/enhancement ✅
https://github.com/jagrosh/MusicBot/wiki/Things-That-Won't-Be-Added ✅
PS : When i use EVAL commands, in the console i have that :

Simply updating the JDA version will not automatically make slash commands work; those will need to be implemented separately. Additionally, updating the JDA version is normal for every new release of JMusicBot. Finally, that warning is normal, the Nashorn engine may get removed at some point, but for now, it's fine to continue using it.


EnumRequest - Table 38 Purchase Header -Field - Bal. Account Type

EnumRequest - Table 38 Purchase Header -Field - Bal. Account Type

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Clipped line in the response

When filtered with a keyword, last line seems to get clipped:

For reference:

@KaustubhDeshmukh - finally fixed it. I should have used a smaller chunk size from the beginning to reproduce your observations.
Anyhow thanks for your time! Feel free to give it a shot.


hare configuration

please run go fmt

just a note, we'll probably need approx layersize configuration. when we'll have you could also use it for the set size.
We'll probably need it soon for testing so I'm mentioning @zalmen @almogdepaz @beckmani

True. I even think we have something like that already. But as you said before, the impact is insignificant so, for now, I will not introduce changes unless there is a good reason to.


SECURITY: Vulnerability reporting and vendor update

What this PR does / why we need it:
Clarifying how KubeVirt is supported by vendor security teams, removes the requirement for PGP encrypted vulnerability reporting.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Removal of PGP encryption got discussed offlist.
While it is less confidential, it is removing friction on the reporter side, as well as on the maintainer side - this benefit is considered to be more beneficial (aka faster and lower burden for reporters) besides the increased security of an encrypted email.
Release note:

NONE

@rthallisey @vasiliy-ul please review

/lgtm

/lgtm

Thanks!
Now we just need approvals!

Two maintianers lgtm and one maintainer creating it makes 3 +1 already. Probably fair to approve.
/approve
/hold
just placing a hold in case you disagree.

/unhold

Thanks, I agree that this is enough. After all it's "backwards compatible"

/retest


Create msdos.cfg

adding MSDOS support via dosbox-pure

Guess this closed when I renamed it. Not the end of the world, I know this would be for v41 anyway.  We might have to add the mapping to the documentation, and it will be relying on the Steam keyboard and based on it's mappings:
R stick = Mouse (shoulders = left and right click, X = middle click)
Y button = Spacebar (from Steam keyboard)
L2 = Shift (from Steam keyboard)
R2 = Enter (from Steam keyboard)
Select = Tab
Start = Enter
A and B mapped to respective A and B keys
D-pad maps to arrow keys
L3 and R3 are unmapped

Mapping updated, needed an ESC key, TAB is available on the Steam keybard while ESC isn't.
R stick = Mouse (shoulders = left and right click, X = middle click)
Y button = Spacebar (from Steam keyboard)
L2 = Shift (from Steam keyboard)
R2 = Enter (from Steam keyboard)
Select = ESC
Start = Enter (Keypad ENTER but it shouldn't matter)
A and B mapped to respective A and B keys
D-pad maps to arrow keys
L3 and R3 are unmapped

https://github.com/ChimeraOS/chimeraos/pull/537 required for this


SD 1.x to SDXL refiner

Hey! Very cool that you've made this! I tried to combine you converter with SD 1.x and the SDXL refiner but so far I haven't had much luck. Is this something you've managed to do successfully?
Here is the code I've used to combine SD 1.x and the SDXL refiner:
https://colab.research.google.com/drive/1lUHih8KsSGuKFTfYBz0I-6FkMEU5GkdP?usp=sharing
Here is an example of what I get out from the refiner atm:

Hi! I did a quick test and using the refiner with 1.5 works with the ComfyUI node, meaning the issue is somewhere else.
Could it be a scaling issue? Just looking at the code it looks like you're passing the scaled latents directly to the refiner. Try modify the code like this:
scaled_latents = 1 / 0.18215 * latents
sdxl_scaled_latents = convert(scaled_latents.to(dtype=torch.float32), "v1", "xl", torch.float32, torch_device)
sdxl_latents = 0.18215 * sdxl_scaled_latents

I made a simplified notebook to limit the number of potential issues. Still having the same problem as in the previous notebook unfortunately.
I'm not very familiar with ComfyUI and I don't know how exactly you connect the two models, so it's hard for me to pinpoint what the issue is. Could you share some details on how you connected SD1.5 and the refiner and/or can you have a look at the simplified notebook to see if there are any obvious issues?
Could it be that the interposer was trained on a specific vae and the default vae for SD1.5 are not compatible?

Your notebook asks me to log in, which I assume means it's set to private. Could you check the visibility settings?
ComfyUI is just a node-based frontend to the LDM code, so internally it uses the same models/etc as diffusers, so that shouldn't matter in this case.
Here is a quick and dirty example of the refiner being connected to the output of a 1.5 model. (Officially, this isn't quite correct, since you're supposed to return the noisy latent at around 80% denoise, then pass it to the refiner for the final 20%, but it works as an example here.)

I don't think it's a VAE incompatibility issue either, the encoder part is the same for all v1.5 VAE as far as I know.
I can try to write some example code for how to use this with diffusers if you want. I still suspect it's a scaling issue.

Not great but it works.

Code below
import torch
from diffusers import StableDiffusionPipeline, StableDiffusionXLPipeline

# Load pipelines
pipe = StableDiffusionPipeline.from_single_file(
    r"D:\Software\AI\sd-models\checkpoints\mix\Silicon29_dark.safetensors",
    load_safety_checker=False, # takes forever to download
    torch_dtype=torch.float16,
)
pipe.enable_xformers_memory_efficient_attention()
refiner = StableDiffusionXLPipeline.from_single_file(
    r"D:\Software\AI\sd-models\checkpoints\sd\sdxl_v1.0_refiner.safetensors",
    torch_dtype=torch.float16,
)
refiner.enable_xformers_memory_efficient_attention()

# Generate image on SDv1
pipe.to("cuda")
scaled_latent = pipe(
    prompt,
    height = 1024,
    width  = 1024,
    output_type = "latent",
    # denoising_end = 0.90, # doesn't work on v1
    num_inference_steps=20,
).images[0]
del pipe # free VRAM

# Convert latent
latent = scaled_latent * (1/0.18215)
xl_latent = convert_latent(latent, "v1", "xl") # code for the interposer, from your notebook
xl_scaled_latent = xl_latent * 0.18215

# Finish with refiner
refiner.to("cuda")
image = refiner(
    prompt = prompt,
    image  = xl_scaled_latent,
    denoising_start = 0.90,
    num_inference_steps=20,
).images[0]
del refiner # free VRAM
image.show()

Awesome! Thanks for a thorough answer. It definitely seems like the issue was the scaling. With you code I got some more acceptable output.
I made the notebook public, so it should be possible to view it now.
In the notebook I made a simple test and I'm curious to get your opinion on whether this is the expected quality or not.
import requests
import torch
from PIL import Image
from io import BytesIO
import torchvision.transforms as transforms
from diffusers.image_processor import VaeImageProcessor
import gc
from diffusers import AutoencoderKL

generator = torch.manual_seed(0)
response = requests.get("https://raw.githubusercontent.com/CompVis/stable-diffusion/main/assets/stable-samples/img2img/sketch-mountains-input.jpg")
init_image = Image.open(BytesIO(response.content)).convert("RGB")
init_image = init_image.resize((768, 512))

# Processing
sd_vae = AutoencoderKL().from_pretrained("runwayml/stable-diffusion-v1-5", subfolder="vae", variant="fp16", torch_dtype=torch.float16).to("cuda")
vaeImageProcessor = VaeImageProcessor(2 ** (len(sd_vae.config.block_out_channels) - 1))
init_pre_image = vaeImageProcessor.preprocess(init_image).to(dtype=torch.float16, device="cuda")

# Encode
sd_latents = sd_vae.encode(init_pre_image).latent_dist.sample(generator)
#sd_latents = sd_latents * (1/0.18215)

# Convert
sdxl_latents = convert(sd_latents, "v1", "xl", torch.float16, "cuda").to(dtype=torch.float32)
sdxl_latents = sdxl_latents * 0.18215

# Decode
sdxl_vae = AutoencoderKL().from_pretrained("stabilityai/sdxl-vae").to("cuda")
image_tensor = sdxl_vae.decode(sdxl_latents / sdxl_vae.config.scaling_factor, return_dict=False)[0]

# Post-processing
image = vaeImageProcessor.postprocess(image=image_tensor.detach())[0]
image

Input image:

Output image:

As you can see, it has some artifacts. I could've done something wrong there though, as I inferred a lot of the steps from the diffusers library and it has a lot of stuff going on.

Here is an example from the notebook with 80% steps on SD1.x and 20% on the refiner. Not getting great results unfortunately :(
SD1.5 output:

Refiner output:

That quality looks similar to what I get, maybe a bit worse but that could be from you running it in FP16. It's a tiny model so I'd recommend keeping the cast you had in the first nodebook and using it with FP32, though not sure how much that changes. It could also be a clamping difference on the output, hardware differences, etc, etc...
(Also noticed you were using the default XL VAE. I usually use this one since it lets me use FP16, though there's no noticeable difference in terms of visual quality.)
Doing v1=>xl is a lot harder than xl=>v1 because the XL latent contains more information than the V1 latent, so I could never get it 100% perfect since it has to "make up" fake details to fit the format I'm pretty sure.
For the generation example, I think the image degradation you're seeing might be from the fact that you're passing a fully denoised latent into the refiner. As I noted above, there's no denoising_end option for v1 to get the noisy latent, so you'd have to use what you did in your first notebook - add a custom sampler except stop it a few steps before the final one.
You could also try euler a for the refiner, which adds noise at every step so it might alleviate it a bit.
Again, I'm just guessing. You could also do a 3 stage thing where your initial image is v1 512x512, then upscale it and send it to v1 1024x1024 before sending it to the refiner. v1 doesn't like generating at resolutions that high natively. (xl=>v1 is simpler since v1 can handle the 1024x1024 image from xl nicely as there it's basically img2img at a low denoise, meaning no weird hires repetition problems appear.)

@city96 thank you for the great work and I hope that there will be a new version with less artifacts, and that latent space expansion is a tough problem indeed. Here is a small question: can a LoRA or embedding be transferred the same way?
@holwech could you interpolate between 70-30, 80-20, and 90-10 to see if the issue is "too much" or "not enough"?


Delete gpr_log(GPR_DEBUG, ...) in release branch

When I run php -v, it output the follow contents:
➜  unit_tests git:(master) ✗ php -v
D0716 08:35:25.383509000<PHONE_NUMBER>02304 ev_posix.c:106] Using polling engine: poll
PHP 5.6.20 (cli) (built: Mar 31 2016 17:14:52)
Copyright (c) 1997-2016 The PHP Group
Zend Engine v2.6.0, Copyright (c) 1998-2016 Zend Technologies
    with Xdebug v2.3.3, Copyright (c) 2002-2015, by Derick Rethans
➜  unit_tests git:(master) ✗

So, I think it should not be used in release branch.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test.

@thinkerou - what do you think of #7438 instead?

@ctiller Yeth, thanks, #7438 is OK, when I not set GRPC_VERBOSITY env, php -v also not output DEBUG info.

#7438 can cover the commit.


Support playing random movie by genre

From the TODO features list, this PR provides support for playing back a random movie by genre
I've modified the existing PlayRandomMovie intent to include an optional genre and the associated alexa_play_random_movie function in wsgi.py to limit selection of a movie to a specific genre when one is provided.
I've taken a steer from the ongoing discussion about CHANGELOG versions and left that as is.
I've got a branch of slot-generator which contains what I think are the changes required to generate the additional slot using the web app, although I can't easily test those. I'll submit these as a PR to @m0ngr31's slot-generator which will need to be taken with a pinch of salt.

Looks good.  I'll test this and https://github.com/m0ngr31/slot-generator/pull/6 just as soon as I get some free time.

Working great here.  Thanks for the contribution!

Thanks @jingai, glad to contribute. I've merged and squashed @digiltd's fixes into my branch of slot-generator, so this may now be OK (Not really knowing what i'm doing with slot-generator notwithstanding)


Update proof-systems for generic gate inside linearization

This is the Mina counterpart to https://github.com/o1-labs/proof-systems/pull/846. This is a no-op, but allows us to delete some legacy code in the proof-systems submodule.
Checklist:

[ ] Modified the current draft of release notes with details on what is completed or incomplete within this project
[ ] Document code purpose, how to use it

Mention expected invariants, implicit constraints

[ ] Tests were added for the new behavior

Document test purpose, significance of failures
Test names should reflect their purpose

[ ] All tests pass (CI will check this if you didn't)
[ ] Serialized types are in stable-versioned modules
[ ] Does this close issues? List them

!ci-build-me


Enable strict null checks

The main motivation was to make sure to not access the setting registry if the service is not available (optional), but this also applies to the rest of the code base.

I push a different version to improve that part of the code

Nice, thanks!


Add a warning for %matplotlib

Fixes #8365

Looks like this

Code looks fine, just a bit unsure on the overall change here. Is widget recommended over inline? Should we change our default?

Codecov Report

Merging #8449 (6546565) into main (8f6665e) will decrease coverage by 0%.
The diff coverage is 56%.

:exclamation: Current head 6546565 differs from pull request most recent head 3f01689. Consider uploading reports for the commit 3f01689 to get more accurate results

@@          Coverage Diff          @@
##            main   #8449   +/-   ##
=====================================
- Coverage     71%     71%   -1%
=====================================
  Files        376     376
  Lines      23814   23833   +19
  Branches    3669    3668    -1
=====================================
- Hits       17124   17104   -20
- Misses      5200    5235   +35
- Partials    1490    1494    +4

Impacted Files
Coverage Δ

...client/datascience/notebook/diagnosticsProvider.ts
79% <53%> (-9%)
:arrow_down:

src/client/common/utils/localize.ts
95% <100%> (+<1%)
:arrow_up:

...ent/datascience/jupyter/pythonVariableRequester.ts
64% <0%> (-10%)
:arrow_down:

...ook/intellisense/pythonKernelCompletionProvider.ts
73% <0%> (-4%)
:arrow_down:

src/client/datascience/jupyter/kernelVariables.ts
53% <0%> (-3%)
:arrow_down:

src/client/datascience/jupyter/kernels/kernel.ts
76% <0%> (-2%)
:arrow_down:

src/client/debugger/jupyter/kernelDebugAdapter.ts
77% <0%> (-1%)
:arrow_down:

...ence/editor-integration/cellHashProviderFactory.ts
100% <0%> (+2%)
:arrow_up:

Is widget recommended over inline? Should we change our default?

Not sure what you mean by inline? If somebody is using %matplotlib (the magic) they are picking a different renderer.

@IanMatthewHuff were you thinking this comes up anytime the user types 'matplotlib'?
It's only for the magic, which is a specific command for changing how matplotlib renders. If you're doing this, you're not using inline.

@IanMatthewHuff were you thinking this comes up anytime the user types 'matplotlib'?
It's only for the magic, which is a specific command for changing how matplotlib renders. If you're doing this, you're not using inline.

It's picking the renderer, and [inline] is a renderer option. We don't want a squiggly for that do we?

It's picking the renderer, and [inline] is a renderer option. We don't want a squiggly for that do we?

I didn't even notice inline was an option. A redundant option but nevertheless we should skip the warning on that one.

It's picking the renderer, and [inline] is a renderer option. We don't want a squiggly for that do we?

I didn't even notice inline was an option. A redundant option but nevertheless we should skip the warning on that one.

Sure that make sense. The initial change looked like a partial attempt to replace one with the other. If you exclude inline as well then I'm fine with this.

Approved if 'inline' is excluded from squiggle warning.

Actually I just tried 'inline'. It crashes the kernel. Seems it's not the default. Not sure what it is.

Okay never mind, that kernel is just hosed. Another kernel, inline is the default and should work.


[EngSys] Update @azure-rest ARM packages to mgmt not client

Packages impacted by this PR

@azure-rest/arm-appservice
@azure-rest/arm-compute
@azure-rest/arm-containerservice
@azure-rest/arm-network
@azure-rest/arm-servicefabric

Issues associated with this PR
Describe the problem that is addressed by this PR
Moves the following packages from the client to mgmt for the sdk-type to reflect these are ARM packages and not data-plane packages.
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists

[ ] Added impacted package name to the issue description
[ ] Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
[ ] Added a changelog (if necessary)

API change check
API changes are not detected in this pull request.

Going to merge this, let me know if any concerns. thanks