error in converting .pkl to .pt

I used google colab to convert from a model trained from a custom dataset with stylegan2-ADA-PyTorch with all default settings and got this error message:
Traceback (most recent call last):
File "/content/stylegan2-pytorch/convert_weight.py", line 236, in
generator, discriminator, g_ema = pickle.load(f)
ModuleNotFoundError: No module named 'torch_utils'
After I pip install torch_utils, I got the following message:
Traceback (most recent call last):
File "/content/stylegan2-pytorch/closed_form_factorization.py", line 18, in
ckpt = torch.load(args.ckpt)
File "/usr/local/lib/python3.7/dist-packages/torch/serialization.py", line 608, in load
return _legacy_load(opened_file, map_location, pickle_module, **pickle_load_args)
File "/usr/local/lib/python3.7/dist-packages/torch/serialization.py", line 777, in _legacy_load
magic_number = pickle_module.load(f, **pickle_load_args)
ModuleNotFoundError: No module named 'torch_utils.persistence'
What should I do?

convert_weight.py does not supports stylegan2-ada-pytorch.

I see. Thanks!
On Thu, Aug 19, 2021 at 8:49 PM Kim Seonghyeon @.***>
wrote:

convert_weight.py does not supports stylegan2-ada-pytorch.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rosinality/stylegan2-pytorch/issues/250#issuecomment-902348398,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQSBAG6XBAWB6PYNIEWR37TT5WRATANCNFSM5CO7HA5A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.

Hello ! I used $ python convert_weight.py --repo ~/stylegan2 stylegan2-ffhq-config-f.pkl
I downloaded .pkl  file from here https://nvlabs-fi-cdn.nvidia.com/stylegan2/networks/   .
The conversion on my machine is in stall, without any signal, why can i get this issue .Have you any ideas?
How can i get clear .pt format in ModeuleScripting  torch format to use in CPP. I need format like in torch.jit.save("model.pt")

I used google colab to convert from a model trained from a custom dataset with stylegan2-ADA-PyTorch with all default settings and got this error message: Traceback (most recent call last): File "/content/stylegan2-pytorch/convert_weight.py", line 236, in generator, discriminator, g_ema = pickle.load(f) ModuleNotFoundError: No module named 'torch_utils'
After I pip install torch_utils, I got the following message: Traceback (most recent call last): File "/content/stylegan2-pytorch/closed_form_factorization.py", line 18, in ckpt = torch.load(args.ckpt) File "/usr/local/lib/python3.7/dist-packages/torch/serialization.py", line 608, in load return _legacy_load(opened_file, map_location, pickle_module, **pickle_load_args) File "/usr/local/lib/python3.7/dist-packages/torch/serialization.py", line 777, in _legacy_load magic_number = pickle_module.load(f, **pickle_load_args) ModuleNotFoundError: No module named 'torch_utils.persistence'
What should I do?

i got the same question,have you solved it?

No, yes no.. there are problem with converting GAN from .pkl to python torch file format

Compling custom operations could take a long time, and it is required both for official stylegan2 codes and in this repositories. I think you can try to spot the codes which causes the stall.
Regarding pytorch jit, I haven't tried to do it. But I think it is possible if you trace the model without custom operators.

It turned out to move forward, but the internal structure of the GAN contains various calls that are not traced.
We must define all class structure for pickle file - original class and pickle structure, for restore model, than trace it.

I use docker from NVlab, and add project to internal struccture but in original NVlabs docker there are no TF, Cublast, and other. Have you any docker configuration or dependence list for this project correct start?

Hello, my stack trace, what is you python interpreter version ? i use 3.6. with CUDA 10.2.
stylegan2-pytorch$ python convert_weight.py --repo ../stylegan2 ./stylegan2-ffhq-config-f.pkl
Traceback (most recent call last):
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/pywrap_tensorflow.py", line 58, in
from tensorflow.python.pywrap_tensorflow_internal import *
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/pywrap_tensorflow_internal.py", line 28, in
_pywrap_tensorflow_internal = swig_import_helper()
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/pywrap_tensorflow_internal.py", line 24, in swig_import_helper
_mod = imp.load_module('_pywrap_tensorflow_internal', fp, pathname, description)
File "/usr/lib/python3.6/imp.py", line 243, in load_module
return load_dynamic(name, filename, file)
File "/usr/lib/python3.6/imp.py", line 343, in load_dynamic
return _load(spec)
ImportError: libcublas.so.10.0: cannot open shared object file: No such file or directory
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "convert_weight.py", line 14, in
from dnnlib import tflib
File "/media/interceptor/SSDStorage/Git_Medium_repo/Binary_search_engine_CUDA/converterGAN/stylegan2-pytorch/dnnlib/tflib/init.py", line 7, in
from . import autosummary
File "/media/interceptor/SSDStorage/Git_Medium_repo/Binary_search_engine_CUDA/converterGAN/stylegan2-pytorch/dnnlib/tflib/autosummary.py", line 26, in
import tensorflow as tf
File "/usr/local/lib/python3.6/dist-packages/tensorflow/init.py", line 24, in
from tensorflow.python import pywrap_tensorflow  # pylint: disable=unused-import
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/init.py", line 49, in
from tensorflow.python import pywrap_tensorflow
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/pywrap_tensorflow.py", line 74, in
raise ImportError(msg)
ImportError: Traceback (most recent call last):
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/pywrap_tensorflow.py", line 58, in
from tensorflow.python.pywrap_tensorflow_internal import *
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/pywrap_tensorflow_internal.py", line 28, in
_pywrap_tensorflow_internal = swig_import_helper()
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/pywrap_tensorflow_internal.py", line 24, in swig_import_helper
_mod = imp.load_module('_pywrap_tensorflow_internal', fp, pathname, description)
File "/usr/lib/python3.6/imp.py", line 243, in load_module
return load_dynamic(name, filename, file)
File "/usr/lib/python3.6/imp.py", line 343, in load_dynamic
return _load(spec)
ImportError: libcublas.so.10.0: cannot open shared object file: No such file or directory
Failed to load the native TensorFlow runtime.
See https://www.tensorflow.org/install/errors
for some common reasons and solutions.  Include the entire stack trace
above this error message when asking for help.

May be problem in here ? I use CUDA 10.2 but TF 1.13. -1.15. not support it, only CUDA 10.0?
https://stackoverflow.com/questions/50622525/which-tensorflow-and-cuda-version-combinations-are-compatible

@AlexTitovWork Yes, tf 1.X binaries only supports 10. It would be easier to use cuda 10.0 and use the pytorch releases that supports it. https://github.com/rosinality/alias-free-gan-pytorch/blob/main/Dockerfile

Thanks @rosinality for the Docker config. I builded docker images successful. It works well on NVIDIA-docker. But there are questions.

In docker images I used cuda 10.0, I installed tensorflow-gpu==1.4.0, and also docker used torch1.7.1+cu92.
But in the project you have tested on:
    PyTorch 1.3.1
    CUDA 10.1/10.2
Can this fact affect on execution of the .pkl converter?

 3. After running the script, nothing happens ... What could be the reason? Maybe I am using the old architecture with CC 5.0?

I Used
CUDA Device Query (Runtime API) version (CUDART static linking)
Detected 1 CUDA Capable device(s)
Device 0: "NVIDIA GeForce GTX 850M"
CUDA Capability Major/Minor version number:    5.0
  Total amount of global memory:                 4046 MBytes<PHONE_NUMBER> bytes)
  ( 5) Multiprocessors, (128) CUDA Cores/MP:     640 CUDA Cores
  GPU Max Clock rate:                            902 MHz (0.90 GHz)
  Memory Clock rate:                             1001 Mhz
  Memory Bus Width:                              128-bit
  L2 Cache Size:                                 2097152 bytes
  Maximum Texture Dimension Size (x,y,z)         1D=(65536), 2D=(65536, 65536), 3D=(4096, 4096, 4096)

@AlexTitovWork How long does it stalled? It could take some time. As it does not show error message, it is hard to guess what could be the problem. You can use Ctrl+C to show stack traces.

Hello @rosinality ! It in stall very long, more than 8 hour. Thanks for support.
i geted stack trace by Ctrl+C.
root@1da8e0e33d03:/home/git_repos/stylegan2-pytorch# python convert_weight.py --repo ../stylegan2 stylegan2-ffhq-config-f.pkl
^CTraceback (most recent call last):
File "convert_weight.py", line 11, in
from model import Generator, Discriminator
File "/home/git_repos/stylegan2-pytorch/model.py", line 11, in
from op import FusedLeakyReLU, fused_leaky_relu, upfirdn2d, conv2d_gradfix
File "/home/git_repos/stylegan2-pytorch/op/init.py", line 1, in
from .fused_act import FusedLeakyReLU, fused_leaky_relu
File "/home/git_repos/stylegan2-pytorch/op/fused_act.py", line 15, in
os.path.join(module_path, "fused_bias_act_kernel.cu"),
File "/usr/local/lib/python3.7/dist-packages/torch/utils/cpp_extension.py", line 997, in load
keep_intermediates=keep_intermediates)
File "/usr/local/lib/python3.7/dist-packages/torch/utils/cpp_extension.py", line 1206, in _jit_compile
baton.wait()
File "/usr/local/lib/python3.7/dist-packages/torch/utils/file_baton.py", line 48, in wait
time.sleep(self.wait_seconds)
KeyboardInterrupt
root@1da8e0e33d03:/home/git_repos/stylegan2-pytorch#

Like in this post message
https://github.com/zhou13/neurvps/issues/1

It works: go to your .cache directory, delete the lock file for your cpp extension (it is likely under the directory ~/.cache/torch_extensions/something), and you should be able to run it again.
If you can't find your cache directory, you can run python -m pdb your_program.py and break at your .../lib/python3.X/site-packages/torch/utils/cpp_extension.py line 1179 (specifically the line containing "baton = FileBaton(os.path.join(build_directory, 'lock'))") and then print "build_directory". That should be the cache directory for your programs

.

@rosinality  i started model converter, but i have not enought memory, How much memory we need for converting stylegan2-ffhq-config-f.pkl for example?
I have 4Gb Video RAM, but the project crashed when memory filled.

@AlexTitovWork Converting itself will not require gpu memory. GPU memory consumption is came from sample generation. Converted .pt file should be generated anyway.

![Снимок экрана от 2021-11-28 21-22-22](https://user-images.githubusercontent.com/23102376/143780938-6dd8d845-4b9f-493f-a5f3-f290ea1bff7f.png

)
GPU usage 100% and more from nvidia-smi request.

@AlexTitovWork I think you can use CUDA_VISIBLE_DEVICES=-1 to prevent tensorflow to use gpu.

I used google colab to convert from a model trained from a custom dataset with stylegan2-ADA-PyTorch with all default settings and got this error message: Traceback (most recent call last): File "/content/stylegan2-pytorch/convert_weight.py", line 236, in generator, discriminator, g_ema = pickle.load(f) ModuleNotFoundError: No module named 'torch_utils'
After I pip install torch_utils, I got the following message: Traceback (most recent call last): File "/content/stylegan2-pytorch/closed_form_factorization.py", line 18, in ckpt = torch.load(args.ckpt) File "/usr/local/lib/python3.7/dist-packages/torch/serialization.py", line 608, in load return _legacy_load(opened_file, map_location, pickle_module, **pickle_load_args) File "/usr/local/lib/python3.7/dist-packages/torch/serialization.py", line 777, in _legacy_load magic_number = pickle_module.load(f, **pickle_load_args) ModuleNotFoundError: No module named 'torch_utils.persistence'
What should I do?

Hi Sam
Did you ever managed to do the model conversion?
Looking forward to hear good news from you
Thanks

I used google colab to convert from a model trained from a custom dataset with stylegan2-ADA-PyTorch with all default settings and got this error message: Traceback (most recent call last): File "/content/stylegan2-pytorch/convert_weight.py", line 236, in generator, discriminator, g_ema = pickle.load(f) ModuleNotFoundError: No module named 'torch_utils'
After I pip install torch_utils, I got the following message: Traceback (most recent call last): File "/content/stylegan2-pytorch/closed_form_factorization.py", line 18, in ckpt = torch.load(args.ckpt) File "/usr/local/lib/python3.7/dist-packages/torch/serialization.py", line 608, in load return _legacy_load(opened_file, map_location, pickle_module, **pickle_load_args) File "/usr/local/lib/python3.7/dist-packages/torch/serialization.py", line 777, in _legacy_load magic_number = pickle_module.load(f, **pickle_load_args) ModuleNotFoundError: No module named 'torch_utils.persistence'
What should I do?

Hi Sam Did you ever managed to do the model conversion? Looking forward to hear good news from you Thanks

I have been working on other projects lately and have not tried it again after rosinality said it was impossible.

我使用 google colab 从使用 stylegan2-ADA-PyTorch 和所有默认设置的自定义数据集训练的模型进行转换，并收到此错误消息： Traceback (last recent call last): File "/content/stylegan2-pytorch/convert_weight.py "，第 236 行，在生成器、鉴别器、g_ema = pickle.load(f) ModuleNotFoundError: No module named 'torch_utils'
在我 pip install torch_utils 后，我收到以下消息： Traceback（最近一次调用最后一次）：文件“/content/stylegan2-pytorch/closed_form_factorization.py”，第 18 行，在 ckpt = torch.load(args.ckpt) 文件中/usr/local/lib/python3.7/dist-packages/torch/serialization.py”，第 608 行，在加载中返回 _legacy_load(opened_file, map_location, pickle_module, **pickle_load_args) 文件“/usr/local/lib/python3 .7/dist-packages/torch/serialization.py"，第 777 行，在 _legacy_load magic_number = pickle_module.load(f, **pickle_load_args) ModuleNotFoundError: No module named 'torch_utils.persistence'
我应该怎么办？

嗨 Sam 你有没有设法进行模型转换？ 期待听到你的好消息 谢谢

Hi，has your problem been solved?

To whom it may interest,
on the documentation of stylegan3 it specifies that the code should torch_utils and ddnlib to be accessibly via PYTHONPATH.

To whom it may interest,
on the documentation of stylegan3 it specifies that the code should on the same path with torch_utils and ddnlib to be accessibly via PYTHONPATH. So basically reassure the location of the model you want to convert is on the same path as the stylegan source code.

still not working, wanting more hint. I have already put the torch_utils and dnnlib in the root path of my project(I also put my code there). I also import torch_utils and dnnlib at the beginning of my code. But it still says
  File "main.py", line 30, in <module>
    args.cur_model = get_model(args.model_type,args.model_path_,args)
  File "/hy-tmp/RONAN-main/inference_models.py", line 99, in get_model
    G = pickle.load(fp)['G_ema'].cuda()  # torch.nn.Module
ModuleNotFoundError: No module named 'torch_utils.persistence'


Indigo functions doen't work if quety atom and monomer on the canvas at the same time

Steps to Reproduce

Go to Molecules mode
Load from file: Indigo functions doen't work if quety atom and monomer on the canvas at the same time.zip
OR create following canvas:

Press Aromatize/Dearomatize/Calculate CIS/Check structure and etc buttons

Actual behavior
System throws exception: Given string could not be loaded as (query or plain) molecule or reaction, see the error messages: 'molecule json loader: 'A' label is allowed only for queries', 'RXN loader: bad header {', 'RXN loader: bad header {', 'molecule: casting to molecule is invalid'

Expected behavior
No exception. Works as intended (every function)
Versions

Ketcher Version 2.22.0-rc.2 Build at 2024-06-28; 05:30:15
Indigo Toolkit Version 1.22.0-dev.2.1-gd5637f75-wasm32-wasm-clang-12.0.0
Windows 10 Pro
Chrome Version 126.0.6478.127 (Official Build) (64-bit)

Issue found while testing - https://github.com/epam/ketcher/issues/4382

Moved to Indigo - https://github.com/epam/Indigo/issues/2195


Compile erros when using Decimal/Numeric types in diesel v2

Setup
Attempt to isolate in a snippet
[dependencies]
diesel = { version = "", features = ["postgres"] }
dotenvy = "0.15"
chrono = { version = "", features = ["serde"] }
rust_decimal = {version = "*", features = ["db-diesel-postgres"] }
Versions

*Rust: 1,63,0
**Diesel: v2.0
*Database: Postgres
**Operating System: WSL

Feature Flags

diesel:

Problem Description
error[E0277]: the trait bound (BigInt, diesel::sql_types::Numeric, Integer, diesel::sql_types::Text, diesel::sql_types::Nullable<BigInt>): load_dsl::private::CompatibleType<Payment, _> is not satisfied
What are you trying to accomplish?
Compile a previously working schema with v1.
What is the expected output?
No error messages
What is the actual output?
error[E0277]: the trait bound (BigInt, diesel::sql_types::Numeric, Integer, diesel::sql_types::Text, diesel::sql_types::Nullable<BigInt>): load_dsl::private::CompatibleType<Payment, _> is not satisfied
--> src/models.rs:47:10
|
47   |     payment.load::(connection).expect("Error getting payments")
|             ^^^^ the trait load_dsl::private::CompatibleType<Payment, _> is not implemented for (BigInt, diesel::sql_types::Numeric, Integer, diesel::sql_types::Text, diesel::sql_types::Nullable<BigInt>)
|
= help: the following other types implement trait load_dsl::private::CompatibleType<U, DB>:
(ST0, ST1)
(ST0, ST1, ST2)
(ST0, ST1, ST2, ST3)
(ST0, ST1, ST2, ST3, ST4)
(ST0, ST1, ST2, ST3, ST4, ST5)
(ST0, ST1, ST2, ST3, ST4, ST5, ST6)
(ST0, ST1, ST2, ST3, ST4, ST5, ST6, ST7)
(ST0, ST1, ST2, ST3, ST4, ST5, ST6, ST7, ST8)
and 24 others
= note: required because of the requirements on the impl of LoadQuery<'_, _, Payment> for schema::payment::table
note: required by a bound in diesel::RunQueryDsl::load
--> /home/serge/.cargo/registry/src/github.com-1ecc6299db9ec823/diesel-2.0.0/src/query_dsl/mod.rs:1499:15
|
1499 |         Self: LoadQuery<'query, Conn, U>,
|               ^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in diesel::RunQueryDsl::load
error[E0277]: the trait bound Payment: FromSqlRow<_, _> is not satisfied
--> src/models.rs:47:10
|
47   |     payment.load::(connection).expect("Error getting payments")
|             ^^^^ the trait FromSqlRow<_, _> is not implemented for Payment
|
= help: the following other types implement trait FromSqlRow<ST, DB>:
<(T1, T0) as FromSqlRow<(ST1, Untyped), __DB>>
<(T1, T2, T0) as FromSqlRow<(ST1, ST2, Untyped), __DB>>
<(T1, T2, T3, T0) as FromSqlRow<(ST1, ST2, ST3, Untyped), __DB>>
<(T1, T2, T3, T4, T0) as FromSqlRow<(ST1, ST2, ST3, ST4, Untyped), __DB>>
<(T1, T2, T3, T4, T5, T0) as FromSqlRow<(ST1, ST2, ST3, ST4, ST5, Untyped), __DB>>
<(T1, T2, T3, T4, T5, T6, T0) as FromSqlRow<(ST1, ST2, ST3, ST4, ST5, ST6, Untyped), __DB>>
<(T1, T2, T3, T4, T5, T6, T7, T0) as FromSqlRow<(ST1, ST2, ST3, ST4, ST5, ST6, ST7, Untyped), __DB>>
<(T1, T2, T3, T4, T5, T6, T7, T8, T0) as FromSqlRow<(ST1, ST2, ST3, ST4, ST5, ST6, ST7, ST8, Untyped), __DB>>
and 23 others
= note: required because of the requirements on the impl of LoadQuery<'_, _, Payment> for schema::payment::table
note: required by a bound in diesel::RunQueryDsl::load
--> /home/serge/.cargo/registry/src/github.com-1ecc6299db9ec823/diesel-2.0.0/src/query_dsl/mod.rs:1499:15
|
1499 |         Self: LoadQuery<'query, Conn, U>,
|               ^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in diesel::RunQueryDsl::load
Are you seeing any additional errors?
Steps to reproduce
diesel::table! {
payment (id) {
id -> Int8,
amount_amount -> Numeric,
amount_currency -> Int4,
account -> Text,
//transaction_date -> Nullable,
//posting_date -> Nullable,
billing_cycle -> Nullable,
}
}
use crate::schema::payment::dsl as dsl2;
use dsl2::;
use chrono::NaiveDate;
use rust_decimal::;
#[derive(Debug, Clone, Default, Queryable)]
#[diesel(table_name = payment)]
pub struct Payment {
pub id: i64,
pub amount_amount: Decimal,
pub amount_currency: i32,
pub account: String,
//pub transaction_date: Option,
//pub posting_date: Option,
pub billing_cycle: Option,
}
pub fn get_payments(connection: &mut PgConnection) -> Vec {
payment.load::(connection).expect("Error getting payments")
}
Checklist

[ ] I have already looked over the issue tracker  and the disussion forum  for similar possible closed issues.

[ ] This issue can be reproduced on Rust's stable channel. (Your issue will be
closed if this is not the case)
[ ] This issue can be reproduced without requiring a third party crate

The problem is with nullable, if you remove it
id -> Nullable<Integer> -> id -> Integer
then everything should work

I'm facing this issue as well. Is there any workaround or fix?

Change the nullable clause is not a fix but a workaround.  As the data element can be null and hence Option in rust this does work.  I consider this bug a showstopper for diesel 2.0 and stay with the 1.* series.

Support for using rust_decimal types with diesel is provided by rust_decimal and not by diesel. crates.io shows that the current rust_decimal release depends on diesel 2.0.0-rc.1 and not on diesel 2.0.0, so its expected not to work. Please raise this issue on the rust_decimal issue tracker because that needs to be fixed on their side.
As for the ”fix" of just removing the nullable wrapper: Please provide a minimal example of that, including your cargo.toml and cargo.lock files. This sounds like a possible bug.
Closed as this is not an diesel issue for the reasons outlined above.

The hint towards rust_decimal solved almost all my issues in my project but it does solve it for the code sample in this PR.  The fix was to use features = ["db-diesel2-postgres"].
As it was the case with this PR, I am battling the compiler errors that reminds me so much the C++ template error messages to understand the root cause of my outstanding compile errors.

@sergeken Suggestions on a better error message are welcome. Otherwise we cannot do much here as this specific integration is not maintained by diesel.


Microsoft.WindowsAppRuntime.Bootstrap.Net.dll not in Transport package

Microsoft.WindowsAppRuntime.Bootstrap.Net.dll was copied to the Transport's staging area not then not actually copied into the Transport package.

/azp run

/ap run

/azp run

/azp run


WIndowsPb: gpg signature verification for ANT binary

[x] commit message has one of the standard prefixes
[ ] faq.md updated if appropriate
[ ] other documentation is changed or added (if applicable)
[x] playbook changes run through VPC or QPC (if you have access)
[ ] VPC/QPC not applicable for this PR
[ ] for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

ref https://github.com/adoptium/infrastructure/issues/2908
It seems only the Ant download supplies a .asc or .sig file. For the other downloads, we supply a fixed checksum string which, since we do not plan on changing, provide adequate verification of a download.
Theres still the java downloads in the playbook which are capable of having gpg verification. Getting the signature file is a bit tricky, on unix we do something like this
curl -s 'https://api.adoptium.net/v3/assets/feature_releases/{{ jdk_version }}/ga?architecture={{ api_architecture }}&heap_size=normal&image_type=jdk&jvm_impl={{ bootjdk }}&os={{ platformLinux }}&page=0&page_size=1&project=jdk&vendor=eclipse' | grep signature_link | awk '{split($0,a,"\""); print a[4]}'

which does not seem to be working well in a windows environment. So until I can figure this out, I thought id merge my work so far

windows vpc https://ci.adoptium.net/job/VagrantPlaybookCheck/1661/console

Latest vpc https://ci.adoptium.net/job/VagrantPlaybookCheck/1662/console

You can set an environment variable GNUPGHOME=$WORKSPACE/.gnupg to a specific directory to use, so that may give you a way forward to use an alternate location (I use this for the Temurin GPG signing to store it in the jenkins workspace)

I would guess that's because it's running under cmd.exe (The windows shell) and not cygwin's bash and therefore doesn't understand /home/vagrant. When you tested outside ansible was it from a cygwin shell?

Works in a cmd.exe environment too

(There's probably a command line option to set it too, but I've not used that)

--homedir looks like it should work, just need to figure out how to use it properly

(both forward and backslash path locations)

Interesting ... the other thing to check would be whether there is another gpg tool on the machine that's being picked up instead of the cygwin one. Could run a test where you fully qualify c:\cygwin\bin\gpg to run it and see if that makes a difference.

Playbook checkers are failing, related?

Playbook checkers are failing, related?

Looks like it. (My review was based on reading the code, and so the check failures need to be understood and addressed before this is merged)

@Haroon-Khel needs a linter fix

Ant contrib is failing to download on the 2022 windows workflow
ASK [ANT : Download ant-contrib] **********************************************
fatal: [<IP_ADDRESS>]: FAILED! => {"changed": false, "dest": "c:\\temp\\ant-contrib.zip", "elapsed": 0.8295483, "msg": "Error downloading 'https://sourceforge.net/projects/ant-contrib/files/ant-contrib/ant-contrib-1.0b2/ant-contrib-1.0b2-bin.zip' to 'c:\\temp\\ant-contrib.zip': The request was aborted: Could not create SSL/TLS secure channel.", "status_code": null, "url": "https://sourceforge.net/projects/ant-contrib/files/ant-contrib/ant-contrib-1.0b2/ant-contrib-1.0b2-bin.zip"}

however that error is unrelated to this pr, the gpg check on the ant binary just before it passes without error
A bit confused by this linter error

Run # Ansible code static analysis
WARNING  Listing 1 violation(s) that are fatal
syntax-check[missing-file]: Unable to retrieve file contents
ansible/playbooks/AdoptOpenJDK_Windows_Playbook/roles/ANT:1:1 Could not find or access '/tmp/roles/GPG_signature_verification/tasks/main.yml' on the Ansible Controller.

Error: Unable to retrieve file contents

                    Rule Violation Summary
 count tag                        profile rule associated tags
     1 syntax-check[missing-file] min     core, unskippable

Failed after : 1 failure(s), 0 warning(s) on 505 files.
Error: Process completed with exit code 2.

Linter issue is solved. The pr checks are running now because I had to rebase (branch was out of date) but this pr is ready to be merged

The ant contrib error mentioned in https://github.com/adoptium/infrastructure/pull/3018#issuecomment-1558971620 is intermittent


Add Brazilian Portuguese translation (PT-BR)

Add a brazilian portuguese translation to the app.

Thanks for great translation! 👍 Hope to keep it up to date.

Thank you for the opportunity! If I could help in something else I'll be
really thankfull
On Jul 28, 2017 11:59 AM, "Paweł Gajda"<EMAIL_ADDRESS>wrote:

Merged #18 https://github.com/elpassion/teamcity-android-client/pull/18.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/elpassion/teamcity-android-client/pull/18#event-1183669569,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AbbqfHYFBJ00OHSuJRRHqqdAkb5_zhJeks5sSfddgaJpZM4OmrgC
.


AttributeError: 'PluginConfig' object has no attribute '_streamingllm'. Did you mean: '_streamingllm'?

System Info

CPU: X86
GPU: NVIDIA L20
python

tensorrt                 10.3.0
tensorrt-cu12            10.3.0
tensorrt-cu12-bindings   10.3.0
tensorrt-cu12-libs       10.3.0
tensorrt-llm             0.13.0.dev2024081300

Who can help?
No response
Information

[X] The official example scripts
[ ] My own modified scripts

Tasks

[ ] An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
[ ] My own task or dataset (give details below)

Reproduction
step 1:
pip install -r requirements.txt
apt-get update
apt-get install git-lfs
rm -rf chatglm*

git clone https://huggingface.co/THUDM/chatglm3-6b-base chatglm3_6b_base

step 2(that step get success):
python3 convert_checkpoint.py --model_dir chatglm3_6b_base --output_dir trt_ckpt/chatglm3_6b/fp16/1-gpu

step 3(get error at this step):
trtllm-build --checkpoint_dir trt_ckpt/chatglm3_6b_base/fp16/1-gpu \
        --gemm_plugin float16 \
        --output_dir trt_engines/chatglm3_6b_base/fp16/1-gpu

Expected behavior
when I operate as example, however get error at the step of:
trtllm-build --checkpoint_dir trt_ckpt/ --gemm_plugin float16 --output_dir trt_engines

actual behavior
[TensorRT-LLM] TensorRT-LLM version: 0.13.0.dev2024081300
[08/15/2024-06:04:26] [TRT-LLM] [I] Compute capability: (8, 9)
[08/15/2024-06:04:26] [TRT-LLM] [I] SM count: 92
[08/15/2024-06:04:26] [TRT-LLM] [I] SM clock: 2520 MHz
[08/15/2024-06:04:26] [TRT-LLM] [I] int4 TFLOPS: 474
[08/15/2024-06:04:26] [TRT-LLM] [I] int8 TFLOPS: 237
[08/15/2024-06:04:26] [TRT-LLM] [I] fp8 TFLOPS: 237
[08/15/2024-06:04:26] [TRT-LLM] [I] float16 TFLOPS: 118
[08/15/2024-06:04:26] [TRT-LLM] [I] bfloat16 TFLOPS: 118
[08/15/2024-06:04:26] [TRT-LLM] [I] float32 TFLOPS: 59
[08/15/2024-06:04:26] [TRT-LLM] [I] Total Memory: 44 GiB
[08/15/2024-06:04:26] [TRT-LLM] [I] Memory clock: 9001 MHz
[08/15/2024-06:04:26] [TRT-LLM] [I] Memory bus width: 384
[08/15/2024-06:04:26] [TRT-LLM] [I] Memory bandwidth: 864 GB/s
[08/15/2024-06:04:26] [TRT-LLM] [I] PCIe speed: 16000 Mbps
[08/15/2024-06:04:26] [TRT-LLM] [I] PCIe link width: 16
[08/15/2024-06:04:26] [TRT-LLM] [I] PCIe bandwidth: 32 GB/s
Traceback (most recent call last):
  File "/root/anaconda3/envs/trt_llm/bin/trtllm-build", line 8, in <module>
    sys.exit(main())
  File "/root/anaconda3/envs/trt_llm/lib/python3.10/site-packages/tensorrt_llm/commands/build.py", line 528, in main
    parallel_build(model_config, ckpt_dir, build_config, args.output_dir,
  File "/root/anaconda3/envs/trt_llm/lib/python3.10/site-packages/tensorrt_llm/commands/build.py", line 394, in parallel_build
    passed = build_and_save(rank, rank % workers, ckpt_dir,
  File "/root/anaconda3/envs/trt_llm/lib/python3.10/site-packages/tensorrt_llm/commands/build.py", line 361, in build_and_save
    engine = build_model(build_config,
  File "/root/anaconda3/envs/trt_llm/lib/python3.10/site-packages/tensorrt_llm/commands/build.py", line 303, in build_model
    assert not build_config.plugin_config.streamingllm or architecture == "LlamaForCausalLM", \
  File "/root/anaconda3/envs/trt_llm/lib/python3.10/site-packages/tensorrt_llm/plugin/plugin.py", line 79, in prop
    field_value = getattr(self, storage_name)
AttributeError: 'PluginConfig' object has no attribute '_streamingllm'. Did you mean: '_streamingllm'?

additional notes
[TensorRT-LLM] TensorRT-LLM version: 0.13.0.dev2024081300
[08/15/2024-06:04:26] [TRT-LLM] [I] Compute capability: (8, 9)
[08/15/2024-06:04:26] [TRT-LLM] [I] SM count: 92
[08/15/2024-06:04:26] [TRT-LLM] [I] SM clock: 2520 MHz
[08/15/2024-06:04:26] [TRT-LLM] [I] int4 TFLOPS: 474
[08/15/2024-06:04:26] [TRT-LLM] [I] int8 TFLOPS: 237
[08/15/2024-06:04:26] [TRT-LLM] [I] fp8 TFLOPS: 237
[08/15/2024-06:04:26] [TRT-LLM] [I] float16 TFLOPS: 118
[08/15/2024-06:04:26] [TRT-LLM] [I] bfloat16 TFLOPS: 118
[08/15/2024-06:04:26] [TRT-LLM] [I] float32 TFLOPS: 59
[08/15/2024-06:04:26] [TRT-LLM] [I] Total Memory: 44 GiB
[08/15/2024-06:04:26] [TRT-LLM] [I] Memory clock: 9001 MHz
[08/15/2024-06:04:26] [TRT-LLM] [I] Memory bus width: 384
[08/15/2024-06:04:26] [TRT-LLM] [I] Memory bandwidth: 864 GB/s
[08/15/2024-06:04:26] [TRT-LLM] [I] PCIe speed: 16000 Mbps
[08/15/2024-06:04:26] [TRT-LLM] [I] PCIe link width: 16
[08/15/2024-06:04:26] [TRT-LLM] [I] PCIe bandwidth: 32 GB/s
Traceback (most recent call last):
  File "/root/anaconda3/envs/trt_llm/bin/trtllm-build", line 8, in <module>
    sys.exit(main())
  File "/root/anaconda3/envs/trt_llm/lib/python3.10/site-packages/tensorrt_llm/commands/build.py", line 528, in main
    parallel_build(model_config, ckpt_dir, build_config, args.output_dir,
  File "/root/anaconda3/envs/trt_llm/lib/python3.10/site-packages/tensorrt_llm/commands/build.py", line 394, in parallel_build
    passed = build_and_save(rank, rank % workers, ckpt_dir,
  File "/root/anaconda3/envs/trt_llm/lib/python3.10/site-packages/tensorrt_llm/commands/build.py", line 361, in build_and_save
    engine = build_model(build_config,
  File "/root/anaconda3/envs/trt_llm/lib/python3.10/site-packages/tensorrt_llm/commands/build.py", line 303, in build_model
    assert not build_config.plugin_config.streamingllm or architecture == "LlamaForCausalLM", \
  File "/root/anaconda3/envs/trt_llm/lib/python3.10/site-packages/tensorrt_llm/plugin/plugin.py", line 79, in prop
    field_value = getattr(self, storage_name)
AttributeError: 'PluginConfig' object has no attribute '_streamingllm'. Did you mean: '_streamingllm'?

How about referring this one ?: https://github.com/NVIDIA/TensorRT-LLM/issues/1968#issuecomment-2252750163

I fixed this issue by editing plugin/plugin.py and changing all the dataclass fields in PluginConfig to have init=True

How about referring this one ?: #1968 (comment)

I had do that before report this issue, not work for me.

I fixed this issue by editing plugin/plugin.py and changing all the dataclass fields in PluginConfig to have init=True

It work for me, but the engine need verify correctness, thx for your help.

@BooHwang
https://github.com/NVIDIA/TensorRT-LLM/blob/main/examples/llama/README.md#run-llama-with-streamingllm
sorry, could you try --streamingllm enable when building the engine?

I fixed this issue by editing plugin/plugin.py and changing all the dataclass fields in PluginConfig to have init=True

It works,tks.


Generic/EmptyPHPStatement: inconsistent behavior when fixing superfluous semicolon

Describe the bug
While working on https://github.com/PHPCSStandards/PHP_CodeSniffer/pull/699, I noticed an inconsistency in how the Generic.CodeAnalysis.EmptyPHPStatement sniff fixes superfluous semicolons placed right after a PHP open tag when the PHP ini directive short_open_tag is enabled.
If a normal open tag is used, the superfluous semicolon is removed, and a space is left between the open tag and the rest of the code. If a shot open tag is used, no space is left between the open tag and the rest of the code. I'm inclined to think the sniff should behave the same for both types of open tags.
This is probably not a high-priority issue as the resulting code is not a parse error, and short open tags are not very popular.
Related to https://github.com/PHPCSStandards/PHP_CodeSniffer/issues/593
Code sample
<?php ; my_function(); ?>

<? ; my_function(); ?>

To reproduce
Steps to reproduce the behavior:

Ensure that the short_open_tag ini directive is enabled.
Create a file called test.php with the code sample above.
Run phpcbf --standard=Generic --sniffs=Generic.CodeAnalysis.EmptyPHPStatement test.php
See that the resulting test.php file contains the following. Note there is no space between <? and my_function();.

<?php my_function(); ?>

<?my_function(); ?>

Expected behavior
I expect the sniff to preserve the space between <? and my_function();.
Versions (please complete the following information)

Operating System
Ubuntu 24.04

PHP version
8.3

PHP_CodeSniffer version
master

Standard
Generic

Install type
git clone

Please confirm

[x] I have searched the issue list and am not opening a duplicate issue.
[x] I have read the Contribution Guidelines and this is not a support question.
[x] I confirm that this bug is a bug in PHP_CodeSniffer and not in one of the external standards.
[x] I have verified the issue still exists in the master branch of PHP_CodeSniffer.

Leaving a single space after a short open tag makes sense to me and a PR to add special handling for short open tags would be welcome.
Though as you already said: low priority as it's not a parse error and AFAICS not a cause for fixer conflicts.


JAVA/REST API Stress client system reports sockets on CLOSE_WAIT on java stress program after about 3 hours in netstat

The following issue was shared with me by Ajit George:
Ran a JAVA / REST API Stress test with failover on 7.0 nightly (ML Server 7.0-20150210) for more than 3hrs. Some time after this, it was noticed that the rest app server was not handling any new request, though the server itself is very responsive.
There were no new documents being written into the database.
The stress client Java program log in one of the test run reported :
com.sun.jersey.api.client.ClientHandlerException: org.apache.http.NoHttpResponseException: The target server failed to respond
Caused by: org.apache.http.NoHttpResponseException: The target server failed to respond
Looking at the netstat -p JavaClient output on the server where Stress program is being produced a list of 100 CLOSE_WAIT socket connections on port 8011. 8011 is the port for restappserver on the E Node.
Here is a snippet of netstat -p command. Was able to reproduce this on multiple runs.
builder@rh6-intel64-6$ netstat -p 10467
(Not all processes could be identified, non-owned process info
will not be shown, you would have to be root to see it all.)
Active Internet connections (w/o servers)
Proto Recv-Q Send-Q Local Address Foreign Address State PID/Program name
tcp 0 0 localhost:21416 localhost:sunrpc TIME_WAIT -
tcp 0 0 localhost:785 localhost:cadview-3d TIME_WAIT -
tcp 0 0 localhost:787 localhost:cadview-3d TIME_WAIT -
tcp 0 0 srv-403k.colo.marklogic:ssh ageorge-z620.marklogi:43084 ESTABLISHED -
tcp 0 0 srv-403k.colo.marklogic:ssh ageorge-z620.marklogi:44150 ESTABLISHED -
tcp 0 0 srv-403k.colo.marklogic:799 homer2.marklogic.com:nfs ESTABLISHED -
tcp 0 0 localhost:11076 localhost:sunrpc TIME_WAIT -
tcp 1 0 srv-403k.colo.marklog:39966 srv-410h.colo.marklogi:8011 CLOSE_WAIT 10467/java
tcp 1 0 srv-403k.colo.marklog:39901 srv-410h.colo.marklogi:8011 CLOSE_WAIT 10467/java
tcp 1 0 srv-403k.colo.marklog:39961 srv-410h.colo.marklogi:8011 CLOSE_WAIT 10467/java
tcp 1 0 srv-403k.colo.marklog:39884 srv-410h.colo.marklogi:8011 CLOSE_WAIT 10467/java

Ajit, can you tell me if you performed a failover during this test?  If so, can you tell me how the timing of it compared to the NoHttpResponseException?  We saw one NoHttpResponseException during our 8.0 stress tests: https://github.com/marklogic/java-client-api/issues/252
That issue we decided not to stop shipment for because it occurred during a failover/recovery.  We can perhaps make the same decision here.

From Ajit (he emailed me):
18:05:57 about to load the content
18:05:57 About to load 2501 documents.
Entering int  endFinishedTests()
Exiting int  endFinishedTests()0
Currently running 24
MinUsers 20
com.sun.jersey.api.client.ClientHandlerException: org.apache.http.NoHttpResponseException: The target server failed to respond
at com.sun.jersey.client.apache4.ApacheHttpClient4Handler.handle(ApacheHttpClient4Handler.java:184)
at com.marklogic.client.impl.DigestChallengeFilter.handle(DigestChallengeFilter.java:34)
at com.sun.jersey.api.client.filter.HTTPDigestAuthFilter.handle(HTTPDigestAuthFilter.java:493)
at com.sun.jersey.api.client.Client.handle(Client.java:648)
at com.sun.jersey.api.client.WebResource.handle(WebResource.java:680)
at com.sun.jersey.api.client.WebResource.access$200(WebResource.java:74)
at com.sun.jersey.api.client.WebResource$Builder.put(WebResource.java:537)
at com.marklogic.client.impl.JerseyServices.putPostDocumentImpl(JerseyServices.java:1238)
at com.marklogic.client.impl.JerseyServices.putDocument(JerseyServices.java:954)
at com.marklogic.client.impl.DocumentManagerImpl.write(DocumentManagerImpl.java:453)
at com.marklogic.client.impl.DocumentManagerImpl.write(DocumentManagerImpl.java:388)
at com.marklogic.client.impl.DocumentManagerImpl.write(DocumentManagerImpl.java:358)
at test.stress.JavaAPISession.putDocument(JavaAPISession.java:146)
at test.stress.RestLoadTester.loadContentFromDir(RestLoadTester.java:161)
at test.stress.RestCRUDTester.runTest(RestCRUDTester.java:533)
at test.stress.StressTest.run(StressTest.java:71)

A missing leaky handle somewhere? Seems potentially quite serious

Ajit, are you still seeing this error?  Does it also occur on 3.0.4?

Run a stress test with ML Server Build 20151103 for more than 7 hours. Was able to see sockets waiting and then getting closed. There were no sockets in CLOSE_WAIT state.
Here is a snippet of netstat command taken on the Java process (pid 29546):
Proto Recv-Q Send-Q Local Address               Foreign Address             State       PID/Program name
tcp        0     48 srv-214-10.colo.marklog:ssh client-250-254.sjc.vp:59759 ESTABLISHED -
tcp        0      0 srv-214-10.colo.marklog:851 homer2.marklogic.com:nfs    ESTABLISHED -
tcp        0      0 srv-214-10.colo.marklog:ssh ageorge-z620.marklogi:53728 ESTABLISHED -
tcp        0      0 srv-214-10.colo.marklo:5866 srv-214-9.colo.marklogi:ssh ESTABLISHED 10608/ssh
tcp        0      0 srv-214-10.colo.marklog:ssh ageorge-z620.marklogi:40961 ESTABLISHED -
tcp        0   1222 srv-214-10.colo.:ldoms-mgmt srv-208-24.colo.marklo:8011 ESTABLISHED 29546/java
tcp        0    436 srv-214-10.colo.marklo:6477 srv-208-24.colo.marklo:8011 ESTABLISHED 29546/java
tcp        0      0 srv-214-10.colo.marklo:6392 srv-208-24.colo.marklo:8011 ESTABLISHED 29546/java
tcp        0    456 srv-214-10.colo.marklo:6460 srv-208-24.colo.marklo:8011 ESTABLISHED 29546/java
tcp        0      0 srv-214-10.colo.marklo:6479 srv-208-24.colo.marklo:8011 ESTABLISHED 29546/java
tcp        0   2961 srv-214-10.colo:sun-sr-http srv-208-24.colo.marklo:8011 ESTABLISHED 29546/java
tcp        0    401 srv-214-10.colo.marklo:6447 srv-208-24.colo.marklo:8011 ESTABLISHED 29546/java
tcp        0    456 srv-214-10.colo.marklo:6463 srv-208-24.colo.marklo:8011 ESTABLISHED 29546/java
tcp        0      0 srv-214-10.colo.marklo:6472 srv-208-24.colo.marklo:8011 ESTABLISHED 29546/java
tcp        0      0 srv-214-10.colo.marklo:6475 srv-208-24.colo.marklo:8011 ESTABLISHED 29546/java
tcp        0    441 srv-214-10.colo.marklo:6448 srv-208-24.colo.marklo:8011 ESTABLISHED 29546/java
tcp        0      0 srv-214-10.colo:sun-sr-iiop srv-208-24.colo.marklo:8011 ESTABLISHED 29546/java
tcp        0    779 srv-214-10.colo.marklo:6395 srv-208-24.colo.marklo:8011 ESTABLISHED 29546/java
tcp        0    403 srv-214-10.colo.m:pgbouncer srv-208-24.colo.marklo:8011 ESTABLISHED 29546/java
tcp        0      0 srv-214-10.colo.marklo:6461 srv-208-24.colo.marklo:8011 ESTABLISHED 29546/java
tcp        0      7 srv-214-10.colo.:sun-sr-jms srv-208-24.colo.marklo:8011 ESTABLISHED 29546/java
tcp        0      0 srv-214-10.colo.marklo:6427 srv-208-24.colo.marklo:8011 ESTABLISHED 29546/java
tcp        0   2950 srv-214-10.colo.marklo:6470 srv-208-24.colo.marklo:8011 ESTABLISHED 29546/java
tcp        0      0 srv-214-10.colo.marklo:6431 srv-208-24.colo.marklo:8011 ESTABLISHED 29546/java
tcp        0    425 srv-214-10.colo.marklo:6457 srv-208-24.colo.marklo:8011 ESTABLISHED 29546/java
tcp        0   2937 srv-214-10.colo.:SunVTS-RMI srv-208-24.colo.marklo:8011 ESTABLISHED 29546/java
tcp        0    436 srv-214-10.colo.:lvision-lm srv-208-24.colo.marklo:8011 ESTABLISHED 29546/java
tcp        0    424 srv-214-10.colo.marklo:6478 srv-208-24.colo.marklo:8011 ESTABLISHED 29546/java
tcp        0    441 srv-214-10.colo:servicetags srv-208-24.colo.marklo:8011 ESTABLISHED 29546/java
tcp        0    464 srv-214-10.col:sun-sr-iiops srv-208-24.colo.marklo:8011 ESTABLISHED 29546/java
Active UNIX domain sockets (w/o servers)
Not able to reproduce the issue. Hence closed (ML Release 7.0-6, Client release 2.0-6).


mysql80: Can't compile

Describe the bug
mysql80 is failing to build
To Reproduce

checkout latest nixpkgs-unstable (c5147860e23ed75ce9d40298c66b416c00be1167 as of this issue)
nix-build -A mysql80

Expected behavior
mysql80 should build successfully
Additional context
Failure is the following:
[ 72%] Building CXX object sql/CMakeFiles/sql_main.dir/mysqld_thd_manager.cc.o
[ 72%] Building CXX object sql/CMakeFiles/sql_main.dir/mdl_context_backup.cc.o
[ 72%] Building CXX object sql/CMakeFiles/sql_main.dir/locking_service.cc.o
/build/mysql-8.0.22/sql/mysqld.cc: In function 'int mysqld_main(int, char**)':
/build/mysql-8.0.22/sql/mysqld.cc:6991:30: error: 'TRUE' was not declared in this scope
 6991 |     my_getopt_skip_unknown = TRUE;
      |                              ^~~~
[ 72%] Building CXX object sql/CMakeFiles/sql_main.dir/opt_costconstantcache.cc.o
[ 72%] Building CXX object sql/CMakeFiles/sql_main.dir/opt_costconstants.cc.o

Notify maintainers
@orivej
Metadata
❯ nix-shell -p nix-info --run "nix-info -m"
these paths will be fetched (0.00 MiB download, 0.00 MiB unpacked):
  /nix/store/mmj80vxbdyvxwfx3hvlynqmnw62rwqjc-nix-info
copying path '/nix/store/mmj80vxbdyvxwfx3hvlynqmnw62rwqjc-nix-info' from 'https://cache.nixos.org'...
 - system: `"x86_64-linux"`
 - host os: `Linux 5.7.17-1rodete5-amd64, Debian GNU/Linux, noversion`
 - multi-user?: `no`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.3.9`
 - channels(fmzakari): `"home-manager, nixpkgs-21.03pre254870.1121b2259b7"`
 - nixpkgs: `/home/fmzakari/.nix-defexpr/channels/nixpkgs`

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:

Looking online I think it has something to do with icu, but not sure.
I tried the following patch:
diff --git a/pkgs/servers/sql/mysql/8.0.x.nix b/pkgs/servers/sql/mysql/8.0.x.nix
index 3dbd84c2a98..9f372077511 100644
--- a/pkgs/servers/sql/mysql/8.0.x.nix
+++ b/pkgs/servers/sql/mysql/8.0.x.nix
@@ -54,6 +54,7 @@ self = stdenv.mkDerivation rec {
     "-DINSTALL_MYSQLTESTDIR="
     "-DINSTALL_DOCDIR=share/mysql/docs"
     "-DINSTALL_SHAREDIR=share/mysql"
+    "-DU_DEFINE_FALSE_AND_TRUE=1"
   ];

   postInstall = ''

That did not work.
Looks very similar to the issue described in https://bugs.gentoo.org/759388

@raskin I see you are the maintainer for icu and the gentoo bug describes something that has changed as part of icu 68+

An easy fix would be to downgrade icu for now.

@SuperSandro2000 trying locally with icu67

@SuperSandro2000 surprised how it got past ofborg though.


Fix the documentation for the PROFILE envvar passed to build scripts

Closes #2084 (+ a typo fix).

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

@bors: r+
Thanks!

:pushpin: Commit fb3213f has been approved by alexcrichton

:hourglass: Testing commit fb3213f with merge 3708b12...

:sunny: Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 3708b123fe8f135fae68b390bbb605efbfbcc0d1 to master...


Create User Story

AS A developer
I WANT a README generator
SO THAT I can quickly create a professional README for a new project

completed.


close() doesn't respond when called inside addListener("urlChangeEvent", () => {}) on Android.

Cannot close the window when a specific url is reached. Works well on iOS but no response on Android.

Can you provide code reproduction ? i cannot reproduce


How to edit icon colors?

I want to know to edit the colors of the icon..

You can Override the styles in your Atom Stylesheet (Atom -> Stylesheet...):
.tool-bar button.tool-bar-btn {
    color: red;
}

@jeselxe Is it possible to do this differently for every icon?

Works for me.
For every icon it's the same approach, but adding the icon class, which it can be get with the inspector (⌘ + ⌥ + I).

This is what I have.

Maybe it's because of the Windows version, I haven't tried it in Win, but it shouldn't have problems.
Sorry I cannot help you more :(

Ow I see.. Its okaym thank you anyway!


Remove use of DefinePlugin, switch to VUE_APP env vars

This uses a more standard way of injecting env vars, and removes most of the complexity from vue.config.js. I've also created a .env.default file, as a template that describes the new env vars.
Let me know what you guys think.

Looks like the client comes up during testing and on my local. However, running yarn test:client:up on my local fails because of one command, curl -s -I --max-time 0.5 http://localhost:8080/api/workspaces 404s.

Looks like the client comes up during testing and on my local. However, running yarn test:client:up on my local fails because of one command, curl -s -I --max-time 0.5 http://localhost:8080/api/workspaces 404s.

Ah I figured it out: the point of this PR is that it detaches the server from the client altogether. So it's no longer viable to use localhost:8080/api to probe whether the client build has succeeded; however, we can do the same thing by just curl'ing localhost:8080 instead. See 8e3d7a5b6b1bf44e1a4e1e786e804c44f738ccbd.


Fix results' moreInfo was not showing;  other fixes / clean

@mgaff plz merge if good.  notice needing to populate 'members' in #addMember, due to commenting-out of group pre init...are we ok w/populating 'members'?


Use readonly morphio Morphology

Codecov Report

:exclamation: No coverage uploaded for pull request base (v4@57b634d). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             v4      #979   +/-   ##
======================================
  Coverage      ?   100.00%
======================================
  Files         ?        36
  Lines         ?      2496
  Branches      ?         0
======================================
  Hits          ?      2496
  Misses        ?         0
  Partials      ?         0


Gadget SDK - Keystore Module

Closes #155

Mostly just things related to comments, readability, etc. Nothing super important or related to actual code

Thank you, addressed all of your comments.


[3.1][pipeline-connectors] Add Implementation of DataSink in Iceberg.

Search before asking

[X] I searched in the issues and found nothing similar.

Motivation
Add pipeline sink Implementation for https://github.com/apache/iceberg.
Solution
No response
Alternatives
No response
Anything else?
No response
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

@lvyanquan Hi I want to take this task. Can you assign me to try this challenge?

Closing this issue as it has been migrated to Apache Jira.


Better handling of non-existent node_modules directory

I ran this plugin in a project without a node_modules directory. I hadn't yet run npm install.
This is what I got:
test.js:2
✖  2:18  Unexpected use of file extension "" for "ava"         import/extensions
✖  2:18  Unable to resolve path to module 'ava'.               import/no-unresolved
✖  3:23  Unexpected use of file extension "" for "read-chunk"  import/extensions
✖  3:23  Unable to resolve path to module 'read-chunk'.        import/no-unresolved

I don't think the import/extensions rule should report in this case. It's just noise.

Ah, yeah, seems like package refs (even internal ones) should should not trigger extensions (always mode).
@vvo: did you imagine the always mode would disallow package references? I would think that ought to be a separate rule, or at least an option.
i.e.
import foo from './foo.js' // valid
import React from 'react' // valid if points to a package and not `react.js`

import bar from './bar' // invalid if filename is actually `bar.js`

Dunno about the "always mode" but your example is valid and expected.

But
import bar from './bar' // invalid if filename is actually `bar.js`

Actually if there's a folder named "bar" I would want to disable requiring it. Requiring folders involves magic and hides the filetree from the code.

Fair enough. So: a flag (allow-packages) that allows a folder reference?

Actually I just realized that the main issue may be that the extensions rule needs to ignore unresolved imports.
This is a standard behavior that would resolve @sindresorhus's original issue regardless of what mode he put it in.

fixed by #296


[BUG] crc setup fails with  yum: command not found

General information

OS: Linux / macOS / Windows
Hypervisor: KVM / Hyper-V / hyperkit / vfkit
Did you run crc setup before starting it (Yes/No)?
Running CRC on: Laptop / Baremetal-Server / VM

CRC version
$ crc version
CRC version: 2.11.0+823e40d
OpenShift version: 4.11.13
Podman version: 4.2.0

Host Operating System
NAME="Fedora Linux"
VERSION="38 (Rawhide Prerelease)"
ID=fedora
VERSION_ID=38
VERSION_CODENAME=""
PLATFORM_ID="platform:f38"
PRETTY_NAME="Fedora Linux 38 (Rawhide Prerelease)"
ANSI_COLOR="0;38;2;60;110;180"
LOGO=fedora-logo-icon
CPE_NAME="cpe:/o:fedoraproject:fedora:38"
DEFAULT_HOSTNAME="fedora"
HOME_URL="https://fedoraproject.org/"
DOCUMENTATION_URL="https://docs.fedoraproject.org/en-US/fedora/rawhide/system-administrators-guide/"
SUPPORT_URL="https://ask.fedoraproject.org/"
BUG_REPORT_URL="https://bugzilla.redhat.com/"
REDHAT_BUGZILLA_PRODUCT="Fedora"
REDHAT_BUGZILLA_PRODUCT_VERSION=rawhide
REDHAT_SUPPORT_PRODUCT="Fedora"
REDHAT_SUPPORT_PRODUCT_VERSION=rawhide

Steps to reproduce

crc setup

Expected
crc detects dnf package manager on fedora and ues it
Actual
INFO Using root access: Installing virtualization packages
Could not install required packages:  exit status 127: /bin/sh: line 1: yum: command not found

@T0MASD does fedora going to drop yum => dnf script which as of now call dnf if user execute yum command?

Fixed via #3454


Fix old child spec warning

Changes the syntax to define children to remove a compilation warning in Elixir 1.11

Thanks @eldano. I think the PR looks good. Though we could only accept this after bumping the supported version to Elixir 1.5+.

Thanks @eldano. I think the PR looks good. Though we could only accept this after bumping the supported version to Elixir 1.5+.

That's right. Are there plans to drop support to Elixir 1.4? The deprecation warning that we're getting on Elixir 1.11 could become an error in the near future.

Thanks @eldano.


Malformed Sitemap content when url contains searchParams

Which package is this bug report for? If unsure which one to select, leave blank
@crawlee/utils
Issue description

Pass a sitemap url that ends with searchParams
See that a warning is printed: WARN  Malformed sitemap content: <url>?from=1234&to=5678

Code sample
import { Sitemap } from "crawlee";

const sitemap = await Sitemap.load("https://www.fashionnova.com/sitemap.xml");

// sample of the sitemap:
// <sitemap>
//   <loc>https://www.fashionnova.com/sitemap_products_1.xml?from=175895313&to=8651136721</loc>
// </sitemap>

// Run the crawler as you do.
// Get the warning message above.

Package version
3.9.1
Node.js version
20
Operating system
Linux
Apify platform

[X] Tick me if you encountered this issue on the Apify platform

I have tested this on the next release
N/A
Other context
I see that the Sitemap module was updated recently to support additional content types. I would like to contribute an additional improvement that changes sitemapUrl from a string to a URL object.
something like:
// L150
let sitemapUrl = new URL(parsingState.sitemapUrls.pop()!);

// L156
const request = gotScraping.stream({ url: sitemapUrl.toString(), proxyUrl, method: 'GET' });

// L164
if (sitemapUrl.pathname.endsWith('.gz')) {
 // L166
 sitemapUrl = new URL(sitemapUrl.pathname.substring(0, sitemapUrl.pathname.length - 3), sitemapUrl);
}

// L172
if (['text/xml', 'application/xml'].includes(contentType ?? '') || sitemapUrl.pathname.endsWith('.xml') {}

// L176
if (contentType === 'text/plain' || sitemapUrl.pathname.endsWith('.txt')) { }

Hello @austinbuckler! Do I understand correctly that the problem is that the sitemap content type is not detected correctly because the extension is followed by a query string?
If that's the case, the solution that you propose should help. If you want to contribute a patch, feel free to do so - we'll be grateful to accept that!

Do I understand correctly that the problem is that the sitemap content type is not detected correctly because the extension is followed by a query string?

You are correct!

If that's the case, the solution that you propose should help. If you want to contribute a patch, feel free to do so - we'll be grateful to accept that!

Awesome, will submit a patch this week. Thank you for the prompt response!

@janbuchar here is the patch 🥂

Thank you very much! I assumed you'd open a pull request so that we 1. see if it passes tests and 2. can discuss it better. Also, if we accept that PR, you'll be listed as a contributor :slightly_smiling_face: Care to do that?

Also please don't update changelogs, they are generated.

Thank you very much! I assumed you'd open a pull request so that we 1. see if it passes tests and 2. can discuss it better. Also, if we accept that PR, you'll be listed as a contributor 🙂 Care to do that?

Sure, will get that done this evening.

Also please don't update changelogs, they are generated.

good to know, will adjust — the contribution document implies that it should be done manually 😅

good to know, will adjust — the contribution document implies that it should be done manually 😅

Ah, it's great that somebody actually reads those :grin: We'll update it!


rename to BasicBSplineExport.jl

I have created a new repository BasicBSplineExporter.jl, and I'll archive this package.


Local Repo Wont Change anymore

I have v2.8.29 installed and when I run
Set-BoxstarterConfig -LocalRepo "C:\Windows\Folder\packages\dev"
It only changes until I close the powershell windows or boxstartershell.
When I run the command again the local repo is appdata\local\boxstarter\buildpackages.

Set-BoxstarterConfig should not only edit the immediate value of $Boxstarter.LocalRepo it edits the configuration file boxstarter.config located at $boxstarter.base\boxstarter.config and sets its <LocalRepo> node to the set value. Susequent imports of the boxstarter module should lookup that value in that config file for the initial localrepo path.
I'm not sure why this is breaking for you, but can you check the contents of that file after setting the localrepo to see if it is written to with the new path?

No updates to this issue in some time so closing it. Can reopen in the future if needed.


Quaternion

Can you give some resources to understand and it's effective visualization with habitat api?

I am not sure if I understand your question correctly. Do you need some tutorials for habitat-sim? https://github.com/facebookresearch/habitat-sim/blob/main/examples/tutorials/notebooks/ECCV_2020_Navigation.ipynb this would be a good example and a good tutorial to start with. It is in the official tutorial of habitat-sim.

I want to understand about the line 71 of clip_mapping_utils , which is r=R.from_quat(quat) , so quat was taken as [3:] from pose file path , my question is what does those 3: values represent,  and what is the reference frame , how can I interactively check that using habitat. Also any resources to understand quaternion and specifically the line 71 , what does R.from_quat(quat) mean ?

ah I see. The pose file saves a 7-dim array which is the concatenation of the position (3-dim) and quaternion (4-dim) of the robot pose in habitat-sim. When you see quat = row[3:], we actually take the last 4 values in the array to obtain the quaternion. R.from_quat(quat) is a function call from scipy. This is used to convert a quaternion to a 3-by-3 rotation matrix. The reference frame of the pose is habitat-sim's global reference frame. If you want to check the pose in habitat-sim, you can initialize the agent and the simulator using the following code:
# sim_cfg should be setup as a dictionary (check cfg in https://github.com/facebookresearch/habitat-sim/blob/main/examples/tutorials/notebooks/ECCV_2020_Navigation.ipynb)
sim = habitat_sim.Simulator(sim_cfg)
agent = sim.initialize_agent(0)
agent_state = habitat_sim.AgentState()
random_pt = sim.pathfinder.get_random_navigable_point()
agent_state.position = random_pt
agent.set_state(agent_state)
obs = sim.get_sensor_observations(0)
# visualize the observations
bgr = cv2.cvtColor(obs["color_sensor"], cv2.COLOR_RGB2BGR)
# resize for less network traffic
if resize:
    bgr = cv2.resize(bgr, (640, 480))
cv2.imshow("rgb", bgr)
cv2.waitKey()

One example of [3:] , which has 4 elements is [0.0, -4.470348358154297e-08, 0.0 , -1 ], so what does each value indicate?

the quaternion format is consistent with scipy's definition, basically [x, y, z, w]. This is the input order for Rotation.from_quat() function as in https://docs.scipy.org/doc/scipy/reference/generated/scipy.spatial.transform.Rotation.from_quat.html.


Grape logger invalid

in  lib/grape/dsl/logger.rb,  we can see:
module Grape
  module DSL
    module Logger
      include Grape::DSL::Settings

      attr_writer :logger

      # Set or retrive the configured logger. If none was configured, this
      # method will create a new one, logging to stdout.
      # @param logger [Object] the new logger to use
      def logger(logger = nil)
        if logger
          global_setting(:logger, logger)
        else
          global_setting(:logger) || global_setting(:logger, ::Logger.new($stdout))
        end
      end
    end
  end
end

Here is a problem, we can not set logger by  Grape::API.logger = xxx, instead, we should call Grape::API.logger(xxx).
Seems something wrong with the attribute writter 'logger=' ?

Did you try setting this on your own API class that derives from Grape::API?

I have tried to set logger in my own API, and failed too.


Helidon 4 Tracing does not support FOLLOWS_FROM semantics

Environment Details

Helidon Version: 4.0.0
Helidon SE or Helidon MP : Helidon MP
JDK version: open jdk 21.0.1
OS: Mac 13.4 Ventura
Docker version (if applicable):

Problem Description

We are unable to use follows_from semantics in tracing where the parent span does not depend in any way on the result of the child span.
For example in messaging - the consumption of messages should be a follows from the produced message.
There are other use cases where async calls are made which would need a follows-from semantics.
Currently only CHILD_OF is supported in Helidon tracing which works fine.

Steps to reproduce

If the parent span is not dependent on the result of a child span.
We are unable to define a FOLLOWS_FROM semantic, as a result, the child span is orphan.
Please see the attached screenshot.

The follows-from semantics came primarily from OpenTracing which has merged with OpenCensus to form the OpenTelemetry effort. OpenTelemetry supports links between spans which is a generalization of relationships among spans, including parent-child and follows-from as well as potentially others. OpenCensus supported links of types parent, child, and unknown.
One solution, now that the fix in the linked PR above is in place, is for apps to unwrap the Helidon SpanBuilder to the OpenTelemetry SpanBuilder and invoke the addLink method (a generalization in OTel of the concepts of parent-child and follows-from relationships).
Clearly this approach binds the code to the OpenTelemetry API. The Helidon Jaeger tracer provider already delegates to OTel so the same approach should work there. To my knowledge Zipkin does not support follows-from semantics or the more general links concept.
We have tried to avoid adding elements to the Helidon neutral tracing API that are not implemented by all--or at least most--common tracing implementations. We do not currently anticipate adding explicit support for follows-from specifically or the more general links concept to the Helidon neural tracing API, at least not in the 4.x timeframe.
Given the above, I plan to close this issue as "won't fix" in a week or so.

Closing. Existing workaround via unwrap allows developers to access the OTel links.


Explicitly disable systemd support in podified env

If we are on a podified environment we should explicitly disable systemd support.
https://github.com/ManageIQ/manageiq-rpm_build/pull/62#issuecomment-644348692

Will need to go back to jansa if https://github.com/ManageIQ/manageiq-rpm_build/pull/62 does.

Jansa backport details:
$ git log -1
commit 9f2f4f740f226fb38ebe9e6914e10a872f7ca859
Author: Nick Carboni<EMAIL_ADDRESS>Date:   Mon Jun 15 16:59:58 2020 -0400

    Merge pull request #20277 from agrare/explicitly_disable_on_containerized

    Explicitly disable systemd support in podified env

    (cherry picked from commit 4701b115e424701719c12d2931c720819c80fda6)


feat(validation): validate concerto objects from dotnet using node

Closes #5

Validate Concerto objects against a provided concerto models from .Net code using Javascript.NodeJS to run the core Concerto engine in NodeJS.
Changes
This works by wrapping the core Concerto engine with a TypeScript function that is then webpacked to Module that Node can execute. Javascript.NodeJS takes care of orchestrating the communication between the host .Net application and NodeJS.
Flags

NodeJS needs to be present on the host system. There are two major alternatives to this approach:

ClearScript, which embeds V8.
One of the other embeddable JS engines (some are even written entirely in .Net)

Neither approach is suitable because Concerto requires enough functionality that is only present in either the browser or NodeJS that shimming or polyfilling the required types and functions is impractical.
Screenshots or Video

Author Checklist

[x] Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
[x] Vital features and changes captured in unit and/or integration tests
[x] Commits messages follow AP format
[ ] Extend the documentation, if necessary
[x] Merging to master from fork:branchname

It would be wonderful if you could describe the processes/architecture for a .NET application that is using this. For example, how does the  data get serialised between .NET and Node?

It would be wonderful if you could describe the processes/architecture for a .NET application that is using this. For example, how does the data get serialised between .NET and Node?

Added a brief description


What to do about JS extras in v2

I removed JS extras in 6996dddf8985be2474416d1d77b32d8f1b985e84, and I'm not sure whether we want to migrate it in its current form.
The problem is that JS extras was a modify dependency, so it worked by directly modifying JS. This meant that JS extras was extremely brittle, as any change to JS would likely break JS extras. Prism v2 does not have modify dependencies (which is good), so JS Extras has to be implemented as an optional dependency of JS. This is difficult. JS extras makes very specific changes, so applying those changes in an optional dependency format creates about as much code complexity as just moving over all the advanced tokens to JS and removing JS extras. Another route would be a custom tokenizer, but this might conflict with JSX which also has a custom tokenizer.
So I'm not sure what to do here. To make the tests pass, I removed it for now. We can re-add it when we have a solution.

Personally, my preference would be to either merge that functionality into JS proper or just kill it. How big is the extras package?

How big is the extras package?

About half the size of JS.


Attention: Prof Leis's ART needs input without duplicates

Otherwise, a leaf node with value v will be split to a Node4 with two leaf nodes both with value v.
The tree depth is increased! The real depth can be even larger than maxKeyLength.
   if (isLeaf(node)) {
      // Replace leaf with Node4 and store both leaves in it
      uint8_t existingKey[maxKeyLength];
      loadKey(getLeafValue(node),existingKey);
      unsigned newPrefixLength=0;
      while (existingKey[depth+newPrefixLength]==key[depth+newPrefixLength])
         newPrefixLength++;

      Node4* newNode=new Node4();
      newNode->prefixLength=newPrefixLength;
      memcpy(newNode->prefix,key+depth,min(newPrefixLength,maxPrefixLength));
      *nodeRef=newNode;

      insertNode4(newNode,nodeRef,existingKey[depth+newPrefixLength],node);
      insertNode4(newNode,nodeRef,key[depth+newPrefixLength],makeLeaf(value));
      return;
   }

Need a hash table to generate the input keys


Upgrade Haunted Doghouse.ash

if lastadv is caldera, supernag
else, optional task

for some reason it saved your new doghouse tile into "2015 " with a space on the end and it is causing every github related thing to go completely crazy. i am gonna close this one and just add your doghouse nag in your darts PR. thanks!


update to kfactory backend

work towards kfactory backend

@sebastian-goeldi

I wonder if the potential licensing conflict that may arise from bringing in a tight dependence to GPL-licensed code (KLayout) was analyzed and taken into account here. The author of KLayout interprets there not to be an issue with Python import statements, but it's not really his call since KLayout itself is forced to use GPL due to its dependencies. So it doesn't seem like a negligible risk, or at least it's a significant potential complication, and therefore worth putting some serious thought into before creating a hard-to-reverse dependence on GPL-licensed code. If this is already fully understood and the risk has been accepted, then no worries!


Feature: Auto issue assign feature

Are you adding a new feature?

[X] YES
[ ] NO

Are you enhancing the old feature?

[ ] YES
[X] NO

Is your feature request related to a problem?

[ ] YES
[X] NO

Describe your feature/enhancement.
By implementing the Auto Issue Assignment feature using GitHub Actions, the issue assignment process becomes automated and efficient. Issues matching specific comment-based criteria will be automatically assigned to the user who made the relevant comment, improving collaboration and task management within the repository.
Can you add the feature by yourself?

[X] YES
[ ] NO

Additional Information
GSSOC 2023

Hey @ighoshsubho Please review my pull request #453
Thank you

Hey @ighoshsubho Can you please elaborate
Thank you

No problem Thank you @ighoshsubho

Closing then!


Fix type definition docs

When using roku-deploy in a typescript file, the jsdoc information doesn't show up when using the roku-deploy imports. I believe this is because the index.ts creates local variables and then exports those. We should investigate how to fix this, as the typescript experience is lacking without full documentation info.

This was partially solved by exporting an instance of the RokuDeploy class. consumers can use this pattern
import { rokuDeploy } from 'roku-deploy';


Can't select only one variable after select all variable

I can't select only one variable after select all variable.
Using Grafana version 9.3.1

https://drive.google.com/file/d/1aigXm4zIRJcNP_4twXmI8iaWiqYy6aFz/view?usp=sharing
check this on screen record

@itsnull12 Is it a single select variable? I see radios instead of checkboxes on your screenshot.
I know that Grafana allows you to specify All for the single select, but have not tested it in this configuration.
Does multi-selection with checkboxes work correctly?
We will take a look.

@mikhail-vl it work after Multi-values is on

but gender only have 2 selection. i think only set Include All option for selecting Man and Woman

@itsnull12 Will be fixed in the upcoming version.
Meanwhile, you can test using the CI artifact: https://github.com/VolkovLabs/volkovlabs-variable-panel/actions/runs/5501567649


Refactor the trait interface for finitely generated things

This compiles, but doesn't pass lints. The idea behind this refactor is that we should be more explicit in our traits about finitely-generated categories and double theory models. Specifically, "finitely generated" traits should expose actual implementations of FinGraph. This is in accordance with what "finitely generated" means mathematically for categories.
Default TODO list

[x] Are all notable changes added to the changelog in dev-docs/?
[x] Are there any manual checks that you did while preparing this release that could be automated and become part of the CI?
[x] Are any relevant issues to the PR mentioned so that they will be automatically closed when the PR merges?

@olynch, I realized that there is a conceptual problem with the new design that I didn't detect in my first review. The problem is that:

The trait FgCategory is being thought of as describing bare categories (categories without extra structure) since object generators are identified with objects. Thus, it not make sense to write, say, FgMonoidalCategory: FgCategory because in a finitely generated monoidal category, the objects and the object generators will not coincide.
The trait FgDblModel should apply to models of double theories beyond discrete ones (or else what is the point of having a trait beyond the struct DiscreteDblModel), yet it extends FgCategory. But this means that it identifies objects and object generators, which won't be the case for double theories with nontrivial object operations.

I see two possible solutions:

change the scope of FgCategory by adding an ObGen associated type, or
have FgDblModel directly add the types it needs rather than extending FgCategory.

I'm inclined toward (1).

OK, for now I'm going to revert to using "Hom" to describe the external identities in a double theory. I'm open to revision of this terminology in a future PR but it needs to be done carefully and consistently throughout the codebase and documentation, and the present state of this PR is quite far from that.


heartbeat/simple_heart: touch the strategy immediately on boot

I noticed this when MONITORing some stuff on Notifyd today. Previously the
strategy would only insert the key after the interval had passed. This meant
that if the daemon crashed in that period of time, any items it read
from the queue would be irretreivably lost. This PR modifies the heart
beat so that it touches the hash once before returning. This'll cause
workers to exist in that hash before they start clamoring for queue
items.

CC: @ttaylorr for review

Looks good aside from small comments 👍

Responded to comments :wink:


Fix incorrect linking to sepolia.basescan

What changed? Why?
When a user is sending a name to a plain 0x.. address or an L1 ens name, we incorrectly set the baseNameChain as sepolia
This PR makes it so that we always infer the chain from the connected account instead from the ens name.

Notes to reviewers
How has it been tested?

🟡 Heimdall Review Status

Requirement
Status
More Info

Reviews

🟡
0/1

Denominator calculation

Show calculation

1 if user is bot
0

1 if user is external
0

From .codeflow.yml

1

Additional review requirements

Show calculation

Max
0

0

From CODEOWNERS

0

Global minimum
0

Max

1

1

1 if commit is unverified
0

Sum
1


[APIM 3.0.0] Subscription policy description is misleading when monetization is enabled

Description:
When monetization enabled, there is an inconsistency in subscription policy description which can be misleading.
Steps to reproduce:

Create a commercial policy with dynamic usage, attach it to an API and publish the API.
When going subscribe to the API in the dev portal, the description is shown as "10 AUD per week" which is incorrect since a dynamic plan is created. The description should be "10 AUD Per Request".

Affected Product Version:
3.0.0

Related to https://github.com/wso2/product-apim/issues/7615. Fixed in https://github.com/wso2/carbon-apimgt/pull/8308


WIP: Make file system thread safe

Description
This PR initially includes mock implementations of Lock/Unlock for LFS and uses the proper compile definitions.
Fixes #280

Codecov Report
Attention: Patch coverage is 14.28571% with 42 lines in your changes are missing coverage. Please review.

Project coverage is 84.03%. Comparing base (ab9c466) to head (90c19ed).

Files
Patch %
Lines

Sts1CobcSw/Utility/LinuxSemaphore.cpp
0.00%
42 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #284      +/-   ##
==========================================
- Coverage   88.34%   84.03%   -4.32%
==========================================
  Files          27       27
  Lines         695      739      +44
  Branches        8       16       +8
==========================================
+ Hits          614      621       +7
- Misses         81      118      +37

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


bug/website incorrectly marked as csv - support charset in content-type header?

Describe the bug
I came across a webpage which is being detected as a CSV file. It should be detected as html. The page, unfortunately, returns its content type as:
Content-Type: text/html; charset=utf-8
To Reproduce
file, filetype = file_and_type_from_url(
    url: "https://sites.google.com/umich.edu/mm-post-award-manual/project-management/cost-sharing-commitments-internal-agreements?authuser=0",
    headers: {'User-Agent': 'Mozilla/5.0'}
)

Expected behavior
I expect it to detect the page as html, it detects it as CSV.
Additional context
When the page is read in, only a portion of it is read and because Google Sites formats HTML a certain way, lines get split up like:
[
'<!DOCTYPE html><html lang="en-US" itemscope itemtype="http://schema.org/WebPage"><head><meta charset="utf-8"><script nonce="7aEdh0ByXXm4OdD9gpzmIA">var DOCS_timing={}; DOCS_timing[\'sl\']=new Date().getTime();</script><script nonce="7aEdh0ByXXm4OdD9gpzmIA">function _DumpException(e) {throw e;}</script><script nonce="7aEdh0ByXXm4OdD9gpzmIA">_docs_flag_initialData={"atari-emtpr":false,"atari-ebidm":true,"atari-ebids":true,"atari-edtm":true,"atari-eibrm":false,"atari-ectm":false,"atari-ects":false,"docs-text-elei":false,"docs-text-usc":true,"atari-bae":false,"docs-text-eessmkc":true,"docs-text-emtps":false,"docs-text-etsrdpn":false,"docs-text-etsrds":false,"docs-text-erdfs":false,"docs-text-encps":false,"docs-text-endes":false,"docs-text-escpv":true,"docs-text-ecfs":false,"docs-text-ecis":false,"docs-text-eessips":true,"docs-text-eectfs":false,"docs-text-edctzs":true,"docs-text-eetxpc":false,"docs-text-eetxp":false,"docs-text-lns":true,"docs-text-ertkmcp":true,"docs-text-ettctvs":false,"docs-text-ettts":false,"docs-text-issermps":false,"docs-text-emscts":false,"docs-text-ecgvd":false,"docs-text-esbbs":false,"docs-text-etccdts":false,"docs-text-etcchrs":false,"docs-text-etctrs":false,"docs-text-etctids":false,"docs-text-eltbbs":false,"docs-etshc":false,"docs-text-tbcb":2.0E7,"docs-efsmsdl":false,"docs-text-etb":false,"docs-text-esbefr":false,"docs-text-etof":false,"docs-text-ipi":false,"docs-text-ehlb":false,"docs-text-epa":true,"docs-text-ecls":true,"docs-text-dwit":false,"docs-text-elawp":false,"docs-eec":false,"docs-ecot":"","docs-text-enbcr":false,"docs-text-svofc":false,"docs-sup":"","umss":false,"docs-eldi":false,"docs-dli":false,"docs-liap":"/logImpressions","ilcm":{"eui":"AHKXmL0GP6UnOh4ObcyGLZyOq1-lslCu_VFbUQCm1RjpF5JAQeQnIevQskC6-rmVr_Xx1pjbMRTK","je":1,"sstu":1710189581077655,"si":"CJqZ6tOI7YQDFf4PbwYdF_IJYA","gsc":null,"ei":[5703839,5704621,5706832,5706836,5707711,5735806,5737800,5738529,5740814,5743124,5746992,5747261,5748029,5752694,5753329,5754229,5755096,5758823,5760348,5762259,5764268,5765551,5766777,5770435,5773678,5774347,5774852,5776517,5777194,5783801,5784947,5784967,5791299,5791782,5792684,5796151,5796473,5797291,14101306,14101502,14101510,14101534,49372443,49375322,49451559,49453045,49472071,49512373,49622831,49623181,49644023,49769345,49822929,49823172,49824163,49833470,49842863,49924714,50082748,50166959,50221728,50266230,50273536,50335897,50360148,50390165,50492350,50515335,50520321,50529111,50533184,50580252,50606355,70979410,71008281,71035308,71038263,71079946,71085249,71123572,71152133,71178680,71185178,71197834,71230233,71238954,71260350,71289154,71301338,71330601,71346960,71407393,71471882,71478208,71483995,71528605,71530091,71531305,71533377,71573878,71600925,71624114,71625588,71632274,71659821,71671626,71689868,71733783,71881299,71924359,71960548,94339809,94353376,94373966,94492857],"crc":0,"cvi":[]},"docs-ccdil":false,"docs-eil":true,"info_params":{},"buildLabel":"editors.sites-viewer-frontend_20240227.02_p0","docs-show_debug_info":false,"atari-jefp":"/_/view/jserror","docs-jern":"view","atari-rhpp":"/_/view","docs-ecuach":false,"docs-cclt":2033,"docs-ecci":true,"docs-esi":false,"docs-efypr":true,"docs-eyprp":false,"docs-eytpgcv":0}; _docs_flag_cek= null ; if (window[\'DOCS_timing\']) {DOCS_timing[\'ifdld\']=new Date().getTime();}</script><meta name="viewport" content="width=device-width, initial-scale=1"><meta http-equiv="X-UA-Compatible" content="IE=edge"><meta name="referrer" content="origin"><link rel="icon" href="https://lh3.googleusercontent.com/D7Lls9cfTmXrQ3tPDeQx-niO5hKS3yXYMB2K8ttobrQ9pg0as-PMZc9KGFojk9fZoiboMQUBBzIvU_fpK5hwznF5jlSRvZxxdWqiJKIHo7NR1SM"><meta property="og:title" content="Cost Sharing, Commitments & Internal Agreements"><meta property="og:type" content="website"><meta property="og:url" content="https://sites.google.com/umich.edu/mm-post-award-manual/project-management/cost-sharing-commitments-internal-agreements"><meta property="og:description" content="',
'Cost Sharing, Commitments & Internal Agreements"><meta itemprop="name" content="Cost Sharing, Commitments &'
]

I'm using the UnstructuredURLLoader:
loader = UnstructuredURLLoader(urls=["https://sites.google.com/umich.edu/mm-post-award-manual/project-management/cost-sharing-commitments-internal-agreements?authuser=0"], continue_on_failure=False, headers={'User-Agent': 'Mozilla/5.0'})

Internally this calls (pseudo-code):
from unstructured.partition.auto import partition

elements = partition(
       url=url, headers=self.headers, **self.unstructured_kwargs
)

I suppose this "bug report" might be better put in the UnstructuredURLLoader library (since partition takes a content_type param), but the bigger problem is, the document starts with a <!DOCTYPE html> declaration, which could factor into determining whether it was a csv or not.

The other thing I should point out, charset is a valid directive if the Content-Type header, and isn't non-standard:
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Type

FYI - the comma might be removed from the page title, which may fix the issue - see Additional Context for what text it was using to detect CSV

Yeah, I was just typing that :) This is a case we should handle.
You can try the content_type argument as a workaround for now, but I'll see about getting this fixed up.
I believe you can add {"content_type": "text/html"} as the unstructured_kwargs argument to the UnstructuredURLLoader call to pass it along to unstructured.

Yeah, I was just typing that :) This is a case we should handle.

Thanks!

You can try the content_type argument as a workaround for now, but I'll see about getting this fixed up.
I believe you can add {"content_type": "text/html"} as the unstructured_kwargs argument to the UnstructuredURLLoader call to pass it along to unstructured.

Ah - yes I believe that would work. Since this is part of a bigger, automated project I'm not able to do a one-off tweak like that (but something to consider).

Fixed awhile back.


Fix ReleasePaymentForm, add tests for ManagePaymentForms

This PR redoes the ReleasePaymentForm to don't inherit from ManagePaymentForm that expects user to input money amount that doesn't really make sense for releasing payment. Instead redone "Release payment" modal simply asks user to confirm the action.
This PR also adds tests checking that refund/capture/release forms return 400 if payment status is invalid, so we know that those are handled gracefully by Saleor's Dashboard.
Fixes #1791
Pull Request Checklist
(Please keep this section. It will make maintainer's life easier.)

[x] Privileged views and APIs are guarded by proper permission checks.
[x] All visible strings are translated with proper context.
[x] All data-formatting is locale-aware (dates, numbers, and so on).
[x] Database queries are optimized and the number of queries is constant.
[x] The changes are tested.
[x] The code is documented (docstrings, project documentation).
[x] Python code quality checks pass: pycodestyle, pydocstyle, pylint.
[x] JavaScript code quality checks pass: eslint.

Rebased against master


Network's initial state doesn't reflect connection status

Navigator's state is started as follows: state: NetworkProps = { online: false }. Given that the state is only changed inside handleOnline and handleOffline, the state only goes online after an online event.
For the component to work with SSR, I think it would be better to sync the state with navigator.onLine inside componenDidMount (something like this.setState({ online: navigator && navigator.onLine || false })). I will be submitting a PR.

It should instead Noop if navigator is undefined

What do you mean? Only set the state if navigator is defined?

Correct

There is no state on the server 😜

Oh, that makes sense. The PR I submitted only sets the state if navigator is defined (and does so inside componentDidMount), so everything should be fine. 😄


Setup appears broken

Adding this to pyproject.toml fixes it
license = {file = "LICENSE.txt"}
authors = [
{name = "Imbue", email =<EMAIL_ADDRESS>]
Maybe setuptools dependent? Either way, generally good to put this stuff in the toml

Thanks for the fix!


Figure out how to reduce the number of pins necessary to power a large quantity of LEDs

100 LEDs would take 300 pins if I wanted each individual LED to be powered.
Figure out how to reduce the number of pins necessary to drive them all. Consider:

In the game the LEDs would form lines of solid color
The LEDs as a chain would have two parameters to meet: what color they will all be and the number of LEDs of that color to light up
Make sure that a series of LEDs would not overdraw on current!

Each "route" of the game would only require three pins for each RGB value and the LEDs along a route will be connected in series. The routes would have a fixed length so no need for a parameter for different lengths.


key international academy

we want to implement the it pro

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 95a0b1ff-0498-505a-6024-b813980d310f
Version Independent ID: b8057930-b4bd-1304-17ce-5561f837e901
Content: Configuration options for the Office Deployment Tool
Content Source: DeployOffice/configuration-options-for-the-office-2016-deployment-tool.md
Service: o365-proplus-itpro
GitHub Login: @jwhit-MSFT
Microsoft Alias: jwhit

Sorry, I'm not sure what the question is. Can you clarify?


⚠ Bofrost.at has degraded performance

In 78702e8, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1833 ms

Resolved: Bofrost.at performance has improved in 32606af.


Add extended buildinfo to metadata

Extensions for re-recreatable builds as per: https://github.com/adoptium/temurin-build/issues/2594#issuecomment-841199132
Signed-off-by: Andrew Leonard<EMAIL_ADDRESS>

Depends on PR https://github.com/adoptium/temurin-build/pull/2636

@andrew-m-leonard https://github.com/adoptium/temurin-build/pull/2636 has landed

@andrew-m-leonard adoptium/temurin-build#2636 has landed

@thanks @karianna

@andrew-m-leonard adoptium/temurin-build#2636 has landed

@thanks @karianna

Does that mean this is ready for review?

run tests

@karianna yes, once ive run the tests

Seems unrelated but linux 11 x64 Openj9 build failed:
13:17:26  /bin/sh: CCACHE_COMPRESS=1: command not found
13:17:26  Makefile:9019: recipe for target 'test/rsa_complex' failed
13:17:26  gmake[5]: *** [test/rsa_complex] Error 127
13:17:26  gmake[5]: *** Waiting for unfinished jobs....
13:17:26  Makefile:174: recipe for target 'all' failed

That failure is due to https://github.com/adoptium/infrastructure/pull/2084
Investigation is needed as to why openssl won't compile.


[Bug]: The fullPage option is unavailable for some website

Bug description
Steps to reproduce the problem:

The page.screenShot option ‘fullPage’ is unavailable for 'https://qapm.qq.com'

Puppeteer version
13.5.2
Node.js version
16.15.0
npm version
8.5.5
What operating system are you seeing the problem on?
Windows
Relevant log output
await page.screenshot({
      path: `xxx.png`,
      fullPage: true,
      type: "png",
    });

Could you please provide a minimal repro documenting expected and actual results?


basemap.at overlay missing

the map overlay "basemap.at" for Austria is not visible in the editor anymore. Selecting this overlay results in a black background like "none". Perhaps the recent change to PNG tiles in the "basemap.at" service causes this behaviour.
Please make this overlay available again, as it is the most valuable source for current building data.

Looks like this was already fixed by @tyrasd in d2a05f5


ModuleNotFoundError: No module named 'ipyvolume' (RAPIDS Demo End-To-End ML Workflow)

Hi all, the RAPIDS Demo End-To-End ML Workflow is throwing the following error, could you help please?:
---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
<ipython-input-1-b0bb00575e05> in <module>
     11 from numba import cuda
     12
---> 13 import ipyvolume as ipv
     14 import matplotlib.pyplot as plt
     15 from fig_helpers import *

ModuleNotFoundError: No module named 'ipyvolume'

I fixed the error ModuleNotFoundError: No module named 'ipyvolume' by installing the below packages:
pip install ipywidgets~=7.4.0
pip install ipyvolume

But now I got this new error:
---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
<ipython-input-1-b0bb00575e05> in <module>
     13 import ipyvolume as ipv
     14 import matplotlib.pyplot as plt
---> 15 from fig_helpers import *
     16 import time

ModuleNotFoundError: No module named 'fig_helpers'

@Vilmara, i was going to update you with the fix once i figured out "fig_helpers"...which i did.  I've contacted the notebook maker and asked him to package it with matplotlib, which I believe he did.  Stay tuned for an update, as i verify and run tests :)

@vilmara , @miroenev updated the notebook.  Can you please see if this resolves your issue so i can close this?  Thanks!

@taureandyernv / @miroenev , notebook working. Thanks!


Provide IRS demonstrator setup

This PR will add a IRS demonstration in form of a helm setup for a fully isolated IRS including all external services
This can be startet locally or deployed to a ArgoCD instance.

⚠ GitGuardian has uncovered 60 secrets following the scan of your pull request.
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
🔎 Detected hardcoded secrets in your pull request
🛠 Guidelines to remediate hardcoded secrets
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.Our GitHub checks need improvements? Share your feedbacks!

GitGuardian findings can be accepted. The mentioned secrets and private keys are intended to be used by a demo application and were created for this purpose.


Getting Started page - Remove $DocIssue from line 36

In the first code example, we haven't added any flow annotations, but there is an error being indicated. It seems like $DocIssue is responsible.
Note: I have not gone through the build steps with OCaml in order to test this..

Thanks for opening this PR and I apologize for letting it sit unreviewed. Since we revamped the Web site, this issue no longer exists. Thanks again :)


Add option to format the date output

Hi @sindresorhus
I was not able to fix the formatting of the code.If you could guide me i can do that.Please review the fix that i have added and kindly guide me for the changes i have to make.
I tried writing a small test case to validate the same.But while running from the testscript the flag option doesnt seem to work.
Guide me if you have some time.
Thanking you in advance.
Fixes #1

Hi @sindresorhus
Kindly review the changes.Thanks for the help and reviews

Thank you, @sunilhari 🙌

Thank 'You' @sindresorhus


feat(server): plugin type-safety

Overview
This pull request aims to enhance type-safety for the Plugin type by introducing the option to pass an array of used keys as a type parameter, thereby enabling better checks for plugin configuration.
When creating Plugins, developers might unintentionally misspell an entrypoint import specifiers key, resulting in a 404 error. With this update, users will be able to explicitly specify those keys they intend to use when creating a plugin. This addition ensures that any potential mistakes or typos are caught.
API changes
The new way of creating a plugin would be as follows:

Note: omitting the type parameter fallbacks to the default behavior with no type-safety

import { Plugin } from "$fresh/server.ts";

export const info: Plugin<["log"]> = {
  name: "info",
  entrypoints: {
    log:
      `data:application/javascript,export default function e(n){ console.log(n + 1) }`,
  },
  render: (ctx) => {
    ctx.render();
    return {
      scripts: [{
        entrypoint: "log",
        state: 1,
      }],
    };
  },
};

Just a heads up that this will conflict with my suggested fix for a different "plugin typing" issue: https://github.com/denoland/fresh/issues/1531#issuecomment-1652953414. Maybe yours will get merged first, since I haven't even created a PR yet!
Btw, thanks for the nice article about plugins: https://javi-blog.deno.dev/fresh_plugins. FYI @bjesuiter
I will play with this PR later today, in order to more fully understand how this is all working.

Btw, thanks for the nice article about plugins: https://javi-blog.deno.dev/fresh_plugins.  Happy to help.

I will play with this PR later today, in order to more fully understand how this is all working.

It's a fairly easy addition in order to type the entrypoint keys and avoid errors, I'm open to suggestions.

Ok, the idea seems good, but somehow I can't get it working. I tried applying this to the three plugins that use entrypoints in the codebase:

js-inject-plugin.ts this was the only one I could get it working for
twind.ts
twindv1.ts

Maybe you could update these to make use of the new feature so there's always an example of how it works? And you could consider adding a dummy plugin that doesn't work, and then use // @ts-expect-error to assert the error. Or a new plugin that has multiple entrypoints.

The plugin itself would need some tweaking to match the new implementation due to the way this plugin is done. I'll use the one at twind.ts as an example.

Ok, the idea seems good, but somehow I can't get it working.

TypeScript complains because the scripts variable is set to any[], and when adding scripts here, the type of the entrypoint is string instead of the one that we want because we are just pushing an object.
The required change would be to annotate the expected entrypoints:
export default function twind(options: Options): Plugin<["main"]> {

There are two ways to do this, the easy way and the dynamic way.
Easy way
Change the scripts variable to match the expected type
const scripts: PluginRenderScripts<"main">[] = [];

Caveats
The maintainers need to manually update the return type and the scripts variable so they match whenever they want to add or remove an entrypoint.
Dynamic way
The main idea behind is to get the return type of the twind function, that is the Plugin type, and through the return type of render or renderAsync get the union of entrypoint literals that we can pass as a type parameter to PluginRenderScripts to maintain type safety.
In order to get this working dynamically we would need to add more types to help us out. I will extract the type from the renderAsync function.
First, one utility type to get the type parameter of a Promise
type UnwrapPromise<T> = T extends Promise<infer U> ? U : T;

Second, a type that gets the type parameter of a PluginRenderResult, whose type parameter is the entrypoint as a narrowed string literal, that is one of the exact entrypoints specified
type ExtractEntrypoints<T> = T extends
  PluginRenderResult<infer Entrypoints> ? Entrypoints : never;

Third, a type that gets the type of the plugin returned to avoid repetitions.
type TwindReturnType = ReturnType<typeof twind>;

Since the only difference between the return type of renderAsync and render is that the former is wrapped in a Promise, this type could be inferred from the render method, not needing the UnwrapPromise type and changing the renderAsync references for render

Fourth, a type that extracts the return type of the renderAsync function and unwraps any Promise.
type UnwrappedRenderAsyncReturn<
  T extends TwindReturnType["renderAsync"],
> = T extends (...args: infer _Args) => infer Return
  ? UnwrapPromise<Return>
  : never;

Fifth, a type that defines the type for the result of the renderAsync function
type RenderAsyncResult = UnwrappedRenderAsyncReturn<
  TwindReturnType["renderAsync"]
>;

Sixth, we get the union of all types specified when creating the Plugin through the type parameter
type EntrypointsType = ExtractEntrypoints<RenderAsyncResult>;

Lastly, we type that array that will hold our strongly typed scripts.
const scripts: PluginRenderScripts<EntrypointsType>[] = [];

Caveats
The complexity is way higher, making it more difficult to maintain should a change be needed.

Regarding the refactor and examples you suggested I could update those too if this PR goes forward. We will have to choose the easy or dynamic approach for it, though.

Closed since there's an ongoing plugin discussion at #1602