Looped animation shows wrong frame if last one is selected with cubic interpolation.

Tested versions
Reproducible in 4.2 stable
Not reproducible in 4.0 stable, but behave as described here.
System information
ubuntu 22.04
Issue description
Looped animation in animation editor shows wrong frame if last one is selected. Selected last frame in the timeline is not relevant to its time and visually you don't know how last frame looks. A similar problem was fixed here, but for linear interpolation, so it's probably related.
https://github.com/godotengine/godot/assets/72736632/e4356b8c-e876-413c-b8b3-133a2e272a8f
Steps to reproduce

Make looped animation.
Add frame in the end of the timeline.
Select last frame.

Minimal reproduction project (MRP)
N/A

If a looped animation has a length of 1.0, then 0.0 and 1.0 are effectively the same point in time. I'm not sure how Godot handles two keyframes at the same time, but it looks like the first one wins, which doesn't sound unreasonable. I suppose you could increase your animation length to 1.001 seconds, then 1.0 and 0.0 would be different points on the loop and you could seek to each independently.

Ah, I've read up on that other issue now and apparently this has already been addressed by the editor now automatically showing a point in time slightly before the end of the animation instead of the actual cursor position.
If you've got keyframes at 0.0 and 1.0 in a looping 1-second animation, then you probably want "Clamp" mode instead of "Wrap". That's the icon to the left of the trashcan on the animation track. Cubic interpolation doesn't react too kindly to zero time differences between keyframes.

If a looped animation has a length of 1.0, then 0.0 and 1.0 are effectively the same point in time. I'm not sure how Godot handles two keyframes at the same time, but it looks like the first one wins, which doesn't sound unreasonable. I suppose you could increase your animation length to 1.001 seconds, then 1.0 and 0.0 would be different points on the loop and you could seek to each independently.

I assume that you are right about the simultaneous processing of frames. It seems that with cubic interpolation Godot builds a transition between the last and first frame that is not instantaneous, which significantly deforms the animation (e.g. reversing the motion in the opposite direction).
In this case, the method you suggested does not help, because the animation simply works outside the range defined by the frames. I don't know why, but this transition is different from cubic interpolation between frames within the timeline. It's not like the regular easeInOutCubic.
Example. Linear interpolation shows the expected animation:
https://github.com/godotengine/godot/assets/72736632/331b36a9-7379-408a-addd-0310c4fafa23
All this applies only to wrap mode, clamp works fine.

Cubic interpolation doesn't react too kindly to zero time differences between keyframes.

This seems to better describe the original issue. As I wrote above, cubic interpolation between the last and first frames looks incorrect and works outside the designated frames.
Clamp mode can help, but it is not suitable for all animations.

I would assume that when overlaying last and first frames, the interpolation should become zero, but now the engine handles it somehow differently.
I'll try to illustrate it with curves.
https://github.com/godotengine/godot/assets/72736632/ed73ce37-aa2c-4eb8-a2d7-abbb01567a27
This is roughly how it should be, on overlapped frames:

And now, judging by the animation, it looks something like this:

Please update your comments instead of making multiple comments in a row, it notifies people in the thread and who watch the repo, and breaks the flow

The problem is that an animation track is a function over time, so $f(t) = y$ is your animated value for a given time $t$. Here, you've got multiple keyframes at the same point in time (time 1 is time 0 in the next iteration of the loop), so both $f(0) = f(1) = y_1$ and $f(0) = f(1) = y_2$ need to be true (for $y_1 \ne y_2$). That previous fix accounted for the user expectation that $f(0) \ne f(1)$ must be possible by replacing $f$ with a new function $g$, so that
$$
g(t) = \begin{cases}
f(t - \epsilon) & \text{if } t = 1 \
f(t) & \text{otherwise.}
\end{cases}
$$
That works for linear interpolation, because the singularity at $f(t) = 1$ only affects that particular $t$, so the problem can be hidden by just preventing the user from looking there. With cubic interpolation, however, the value at $f(t)$ is influenced by four different keyframes, so with only two keyframes in the animation (both of which will be used twice to get to the four keyframes required), the function is now undefined on the entire length of the animation. Internally, this leads to a number of division by zeros that the algorithm gracefully handles by just returning "something" when it encounteres zero-length segments. This prevents crashes, but the result is rather arbitrary and won't magically produce a function that can be in two places at once.
Enabling "Clamp" actually makes the function discontinuous at $t = 1$, so while $t = 0$ and $t = 1$ still refer to the same position in the loop, $f$ may now indeed have two different values at the loop point. The cubic interpolation will then see that there is no way to reach four keyframes along the time axis and fall back to linear interpolation, which most likely matches what users would expect should happen in this case.

This issue has nothing to do with #85068 but with how to retrieve keys specific to cubic interpolation.
I remember at some point in 4.0 dev we fixed the wrong interpolation during the wrap loop when the keys do not overlap. So the overview is not exactly correct, and the problem already existed in 4.0.
I think a special case for overlapping keys is needed for this problem.

https://github.com/godotengine/godot/issues/86003#issuecomment-1849063327

Thanks for the detailed explanation. I think that's what I see in animation and that's the most accurate description of the original issue. The graph depicts what is happening well.
It is true that the problem can be avoided by changing the animation technique and using additional frames + clamp, additional frames + easing or simply using curves depending on the situation. Here I just wanted to report unusual behavior from a user's perspective, giving an accurate description.

This issue is not related with #85068 but with how to retrieve keys specific to cubic interpolation.

I remember at some point in 4.0 dev we fixed the wrong interpolation during the wrap loop when the keys without overlap. So the description is not exactly correct, and the problem already existed in 4.0.

You are right, the problem also exists in 4.0. It also initially seemed related to #85068 due to similar symptoms, but bs-mwoerner's description now better explains what is happening independent of #85068.
Today I tested this in 3.5.2. This issue is completely absent there. I suggest using it as a reference for expected behavior for this animation setup.
https://github.com/godotengine/godot/assets/72736632/48e0daa0-b997-4527-abc8-77325ee5814e

Here I just wanted to report unusual behavior from a user's perspective, giving an accurate description.

Yes, and that's a good thing. I may have put a bit too much effort into explaining why I think what happens is technically correct, while the real issue should probably be: What is the user trying to achieve and how can Godot make it easy to find the right tools for the job and explain what the effects of the individual options are.
That observation for the different behavior in 3.5.2 is very interesting. I'm no expert on the animation system but I had a quick glance at the code and there is indeed a difference here in that 3.5.2 doesn't even take the time of the two outer keyframes into consideration, so short time intervals can't ever be an issue here. The definition of "cubic interpolation" changed between 3.5 and 4 and I'd assume that the 3.5 approach was much less prone to overswings. That change was made in #63602 and I think the idea was that this makes the resulting curve smoother, even though it may overshoot the keyframes. The PR has an animation where the overshoots indeed look quite natural.
So I suppose that's just how cubic interpolation works in Godot 4 now. And I see how for many 2D animations, you might have preferred the old way. Still, I think you should often be able to get a similar effect as before by using linear interpolation with easing.

Not dealing with the two outer keys in the wrap loop is a cubic completion in Godot 3.x. Obviously, it is a wrong completion.
If there is no key overlap, then the Godot4 behavior is correct and the 3.x behavior is clearly wrong . The problem is ambiguity in Godot4 in getting the key when the keys overlap.

What I meant by "3.5 was less prone to overswings" was that for Godot 4, #63602 replaced the previous _cubic_interpolate with _cubic_interpolate_in_time, which produces a curve that for non-regular keyframe intervals is much smoother but no longer restricted to the value range of the keyframes:

I'm not saying that's wrong, I just brought that up to clear up any misconceptions and explain the different behavior between Godot 3.5 and Godot 4. I can understand why a user less familiar with polynomial interpolation, who might think of cubic interpolation as "just like linear, but smoother" and would use it to interpolate typical 2D things like color fades, sliding doors, or opening menus, might be surprised that, for example, the animation can go well into the negatives even without a single negative keyframe. In most audio or video editing software that I know and that has 2D curves for volume, compositing levels, and the like, they usually offer quadratic, cubic, exponential etc. easing in/easing out modes per keyframe, but no interpolation across more than two keyframes:

Since the terms are similar, I can see why people may initially insist on using cubic interpolation in Godot even if it's not what they think of and detrimental to what they want to achieve. If you're making something like a path, however, and smoothness is your main priority and you don't want your spaceship to stop at every waypoint, then this corrected cubic interpolation is of course superior to any kind of linear interpolation with easing.

Since the terms are similar, I can see why people may initially insist on using cubic interpolation in Godot even if it's not what they think of and detrimental to what they want to achieve. If you're making something like a path, however, and smoothness is your main priority and you don't want your spaceship to stop at every waypoint, then this corrected cubic interpolation is of course superior to any kind of linear interpolation with easing.

In general, yes, cubic interpolation in 3.5 made it possible to set up smooth movement between frames in the easiest way possible. Now it creates less predictable motion. After your description, it's much better to understand exactly what's going on. Just because it looks different from the previous motion and from the behavior in other animation programs - it's a bit confusing. It's clear to me that there are many options to use the current behavior as more natural, I just don't have to deal with it in my tasks. It seems like it would be useful to just have both options for different situations.
Different programs use different animation interface designs, so it's always just a matter of getting used to it. For example, easing in Godot is rather strange to me, because it only customizes the ease_out of frame, as well as separating tracks into two types: curves and values, when they are essentially the same thing. Nevertheless the animation editor in Godot allows you to do all the non-necessary things its special way. A universal interface for all purposes is quite a challenge, I understand that. In my case, I found it most convenient to write a plugin to improve my workflow. Fortunately, it's pretty easy here. The main thing is to make sure that the system you have is stable - usually that's enough.


Consider removing :max-chunk-size option

The setting is available here and is used to create an instance of HttpObjectDecoder. I suggest marking this option as deprecated and using Integer/MAX_VALUE in the decoder as far as this limitation doesn't do any good in Netty's current architecture (it's better to get data as soon as it's ready).
Discussion on removing this entirely from Netty 5.
@ztellman If you don't have objections or other thoughts on that, - I'll make a PR.

Implementation has been already merged.


Service dialog enhancements.

Service Dialog Enhancements
*Created single copy of parsing code in separate automate method.
*Normalized Dialog information provided to Service provision state machine methods.
*Added clarity by the separation of dialog options and tags.
*Add tag_control support.
*Ability to override the service_name, service_description and vm_name.
*Service cleanup for failed service provision.
The catalogbundleinitialization and catalogiteminitialization automate methods had duplicated parsing code and had issues where tagging and options setting was not working correctly.
Created new dialog_parser automate method to be executed prior to catalogbundleinitialization and catalogiteminitialization methods to provide consolidated and configurable dialog parsing.
Sample parser method output:
dialog_options_hash: {1=>{:stuff=>"this is for items 1 only - FINAL TEST"}, 2=>{:stuff=>"option2 stuff"}, 3=>{:stuff=>"option 3"}, 0=>{:global_value=>"global value"}}
dialog_tags_hash: {0=>{:location=>"location"}, 2=>{:stuff=>"tag 2"}, 3=>{:stuff=>"tag_3_stuff"}}
The parsed dialog information is stored in YAML format in the options hash of the request task and is copied from the request task to the child task when the catalog item is processed. The information is stored in the options hash using the parsed_dialog_options and parsed_tag_options keys.
Tag control support input format:
Array::dialog_option_1_department3"=>"Classification::41,Classification::42,Classification::43,Classification::44"
Parsed Results: department3=>["accounting", "automotive", "communication"]}
CatalogBundleinitialization and catalogiteminitialization method changes:
Methods use normalized dialog information stored in options hash.
parsed_dialog_options: {1=>{:stuff=>"this is for items 1 only - FINAL TEST"}, 2=>{:stuff=>"option2 stuff"}, 3=>{:stuff=>"option 3"}, 0=>{:global_value=>"global value"}}
parsed_tag_options: {0=>{:location=>"location"}, 2=>{:stuff=>"tag 2"}, 3=>{:stuff=>"tag_3_stuff"}}
The zero key entries are global and passed to all service items.  The non-zero key entries are applied to the service item that have a matching provision index.  Service item 1 will have options for 0 and 1, service item 2 will have options for 0 and 2, …..
Pass dialog_value of “service_name” to override the service name:
Pass dialog_value of “service_description” to override the service description:
Pass dialog_value of “vm_name” or “vm_target_name" to override the VM name:
https://bugzilla.redhat.com/show_bug.cgi?id=1184267

@gmcculloug @mkanoor
Please review.

@mkanoor
Changes suggested made.

reran travis. think it was a false positive

@tinaafitz
Looks good

@gmcculloug
Changes made.

@gmcculloug - Added comment specifying that the dialog_parser automate method has be executed prior to the catalog bundle/item initialization.

The WIP label is on this one...is it still WIP?


[FEATURE] Multi-Page Support

Category:  Feature
Overview
You've requested it... here is a working implementation of multi-page support!
Will be ready for merge once I've figured out the merge for #606
Issue Number #584 #466
New Vars
pages
Screenshot
Code Quality Checklist (Please complete)

[ ] All changes are backwards compatible
[ ] All lint checks and tests are passing
[ ] There are no (new) build warnings or errors
[ ] (If a new config option is added) Attribute is outlined in the schema and documented
[ ] (If a new dependency is added) Package is essential, and has been checked out for security or performance
[ ] Bumps version, if new feature added

Allowing the path to the config file to be modified, could allow for a path traversal attack. Added safeguard in Node server, but still stricter permissions needed.


Bugfix/empty response body

If the response body is an empty string, a JSON exception is thrown. -> Fixed by checking for empty input and returning JSONObject.NULL

This PR was deleted due to changing the default branch name from master to main, not because it's a bad PR 😄. That being said, As Emily mentioned "" should throw an error in Chrome (Android) and Safari (iOS), so I don't think we should merge this in.

This PR was deleted due to changing the default branch name from master to main, not because it's a bad PR 😄. That being said, As Emily mentioned "" should throw an error in Chrome (Android) and Safari (iOS), so I don't think we should merge this in.

Ok. Thanks for the input that an empty string is invalid JSON. Will consider this.


feat(ci): Add a new workflow to label a PR wrt review duration

What does this PR do?
Add a new workflow PR complexity label to add a code review duration estimation label to a PR, based on PR attributes (files changed, additions, deletions, comments)
Motivation
Better inform PR author and reviewers about the complexity of the PR.
With the chosen criteria

easy PR (short review) are merged in an average time of 3 days, 2:49:10
medium PR (medium review) are merged in an average time of 7 days, 22:14:08
hard PR (short review) are merged in an average time of 26 days, 22:13:15

From the ~30k PR merged in datadog-agent, we have the following distribution:

complexity
percentage

easy
43%

medium
54%

hard
3%

The objective is to increase the number of PR merged in less than 1week
Describe how to test/QA your changes
n/a
Possible Drawbacks / Trade-offs
Additional Notes
It would be nice to have this label automatically posted when a PR review is required, to give an hint to reviewers.
If you want more details about the choice of criteria, you an have a look to a detailed document.

/merge


feat: wallet identifiers

Description
implements #728
Notice
Before submitting a pull request, please make sure you have answered the following:

[x] Have you followed the guidelines in our Contributing guide?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[x] Do all new and existing tests pass? Does the linter pass?

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[x] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)
closes #728
Testing
Please outline all testing steps

Setup local dev environment
Connect a wallet
Notice the new identifier in the top right

Screenshots (if applicable)
Dark mode:

Light Mode:

Additional Info
As this is supposed to be a bounty I am attaching the time I spent working on this: 3 hours

i took approval from @0xean before starting work on this bounty

NOTE: While working on this I noticed that when switching between wallets multiple times an issue emerges, the wallet identifier does not update. I tracked this issue down to a certain dependency called react-middle-ellipsis and confirmed that when the above mentioned dependency is not used this issue is solved. I'm not exactly sure why this dependency causes this behavior and did not investigate too deep into it as it was out of scope of this bounty. I'm leaving this note here as this will need to be fixed later on.

@amitojsingh366 Is this ready for review? I'd like to take a look today!

@amitojsingh366 Is this ready for review? I'd like to take a look today!

@gomesalexandre yup it's fully complete except the keepkey part, since I don't have a keepkey I couldn't test it out :(

@amitojsingh366 Is this ready for review? I'd like to take a look today!

@gomesalexandre yup it's fully complete except the keepkey part, since I don't have a keepkey I couldn't test it out :(

Yeah mine is still shipping unfortunately so I won't be able to test real hardware wallet implementation either but having deep dived into the chain-adapters implementations and having mocked it a few times, I would say that it's safe to assume this is properly abstracted and if it works for Metamask/Native, it will work for keepkey!

@amitojsingh366 Is this ready for review? I'd like to take a look today!

@gomesalexandre yup it's fully complete except the keepkey part, since I don't have a keepkey I couldn't test it out :(

Yeah mine is still shipping unfortunately so I won't be able to test real hardware wallet implementation either but having deep dived into the chain-adapters implementations and having mocked it a few times, I would say that it's safe to assume this is properly abstracted and if it works for Metamask/Native, it will work for keepkey!

oh ok that's good to hear then!

Portis wallet shows ETH address vs. expected email address for that Portis wallet account
@gomesalexandre I'm not sure if we're able or even allowed to access the email address on the portis wallet

Portis wallet shows ETH address vs. expected email address for that Portis wallet account

@gomesalexandre I'm not sure if we're able or even allowed to access the email address on the portis wallet

Yeah from what I grepped in hdwallets, doesn't seem like it's some info we have.

Portis wallet shows ETH address vs. expected email address for that Portis wallet account

@gomesalexandre I'm not sure if we're able or even allowed to access the email address on the portis wallet

Yeah that's a good one, doesn't look like that's possible! Just checked the reverse ENS lookup and it works fine 👑

Yeah from what I grepped in hdwallets, doesn't seem like it's some info we have.

Yeah that's what I thought

Yeah that's a good one, doesn't look like that's possible! Just checked the reverse ENS lookup and it works fine 👑

Great!


Open file from diff defunct

make changes
look at changes in diff
commit changes, diff stays open
select 'Open File'
🐛 nothing happens...

AHAH cc @isidorn
Fixed by<PHONE_NUMBER>be39972f6973eb8d413e7c5e95e855

@joaomoreno I told you everybody would hit this 🤓

Reopening this because when the diff editor is open in slot 2 or 3 the original file open in slot 1 which is not what I want. @joaomoreno You don't wanna use the open-command but the actual API for this

Closing, since the original issue is fixed. Moved @jrieken's suggestion to #23667


Maphilindo

KillerPotato
Yes, this is a realistic union. It was first conceptualized by Filipino writer and hero Jose Rizal, who saw that the only reason why the Malay race (shown in Vicky 2 as Malay, Indonesian, Filipino, and everything in between) wasn't a unified one because of colonial, and thus, artificial borders. It first gained political traction during the Philippines' stay as an American colony, and eventually reached the ears of the President Manuel L. Quezon, who sought an "integrated, pan-Malayan nationhood in the region."
Eventually, his successor, Diosdado Macapagal, convened an international meeting in Manila, where they signed the Manila Accords, a series of deals that gleaned over the territorial statuses of Sarawak and North Borneo, the latter of which being claimed by the Philippines, who claimed it as part of the former Sulu Sultanate, and thus, a part of the Philippines.
The entire concept of Maphilindo at the time was also made a tactic by Indonesia and the Philippines to ensure that The Federation of Malaysia as we know it wasn't to be, thus securing the local power balance and regional stability. The cession of Sarawak and North Borneo was taken as a British imperialist plot, which eventually lead to the dismantling of the union via the birthing of the Indonesian stance of 'Konfrontasi' against Malaysia.
In the end, the whole idea of the Union was dashed as the focus of the region was shifted from cultural unity to that of preventing the 'domino theory' of Communist advance. In response to this, ASEAN was formed with a larger sphere of influence, one that included the Indochinese area.
And thank you, The Sneaky Top Hat for sending that link before I could. Probably would've missed simsulla's reply if it wasn't for that. ^-^

austrianemporer
I disagree because Maphilindo was merely an opportunistic defense pact to stop Malaysia from evolving, Indonesia had no real interest in Maphilindo while opinion in the Philippines was divided. Anyways, ASEAN supersedes and outdates Maphilindo just like how the EU outdated a Franco- Anglo Union.Maphilindo did not have a chance in the world to even be a political union, it was designed as a military pact.
simsulla
I wasn't thinking of Maphilindo as a "super-state" like ASEAN, but more as a tool on struggle for power over Boreno. A Philipin-Maphilindo of "non-muslim" ares like Sabah as Sarawak (which was largely Christian).


Silently rewriting pubsubTopics

This is a bug report
Problem
When contentTopics is specified, options.shardInfo will get populated here https://github.com/waku-org/js-waku/blob/master/packages/sdk/src/utils/libp2p.ts#L98
If shardInfo is specified, pubsubTopics get rewritten https://github.com/waku-org/js-waku/blob/master/packages/sdk/src/utils/libp2p.ts#L105
Proposed Solutions
Either error out if both shardInfo and pubsubTopics is populated, or do not overwrite pubsubTopics if they are explicitly defined

WDYT @weboko ?

@vpavlin, what is the case for users to specify both shardInfo and pubsubTopics?

No idea:) I think the case is specifying contentTopic and pubsubTopic - maybe even unintentionally without fully understanding what they are doing?
Consider this with assumption js-waku works with TWN:

I specify contentTopic and lean on TWN
I decide to move to my own pubsub for arbitrary reason, so I simply add pubsubTopic assuming that is all I need
Things break:)

The actual case is this change https://github.com/waku-org/js-waku/commit/5b03709dfe683b1cb001fe67c5bd013e664b4d89 broke things that previously worked - i.e. contentTopic and pubsubTopic specified at once.
Regardless of what the use case for having both shardInfo and pubsubTopic js-waku should let users know they should not specify both - i.e. report the error - as I suggested in the description.

I think this is something that is not clear and we need more feedback on it.
Overall I think node should be run either in TWN or on custom network, not both.
For action point for this task I think we should refine createNode options as they are confusing.
My approach would be to:

accept pusbTopic or shardInfo;
have it as one field only and remove others;

Slightly intervened with https://github.com/waku-org/js-waku/issues/2034

This solution will be to complicated especially before we deprecate pubsubTopic - https://github.com/waku-org/js-waku/issues/2027#issuecomment-2194899424
Adding simple throw for now - https://github.com/waku-org/js-waku/pull/2056


"Cannot find source file: ggml.h" when trying to install on Ubuntu 22.04 on aarch64

Would appreciate some help on this.
I'm not sure why are some files are missing when trying to build the wheel.
This is an Oracle Cloud Free tier instance.
VM.Standard.A1.Flex (Arm processor from Ampere) - 4 CPU, 24 GB RAM.
ubuntu@server1:~$ pip install pywhispercpp
Defaulting to user installation because normal site-packages is not writeable
Collecting pywhispercpp
  Using cached pywhispercpp-1.0.8.tar.gz (229 kB)
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... done
Collecting pydub
  Using cached pydub-0.25.1-py2.py3-none-any.whl (32 kB)
Requirement already satisfied: platformdirs in /usr/lib/python3/dist-packages (from pywhispercpp) (2.5.1)
Requirement already satisfied: tqdm in ./.local/lib/python3.10/site-packages (from pywhispercpp) (4.64.1)
Requirement already satisfied: numpy in ./.local/lib/python3.10/site-packages (from pywhispercpp) (1.24.2)
Requirement already satisfied: requests in /usr/lib/python3/dist-packages (from pywhispercpp) (2.25.1)
Building wheels for collected packages: pywhispercpp
  Building wheel for pywhispercpp (pyproject.toml) ... error
  error: subprocess-exited-with-error

  × Building wheel for pywhispercpp (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [109 lines of output]
      running bdist_wheel
      running build
      running build_py
      creating build
      creating build/lib.linux-aarch64-3.10
      creating build/lib.linux-aarch64-3.10/pywhispercpp
      copying ./pywhispercpp/_logger.py -> build/lib.linux-aarch64-3.10/pywhispercpp
      copying ./pywhispercpp/__init__.py -> build/lib.linux-aarch64-3.10/pywhispercpp
      copying ./pywhispercpp/constants.py -> build/lib.linux-aarch64-3.10/pywhispercpp
      copying ./pywhispercpp/utils.py -> build/lib.linux-aarch64-3.10/pywhispercpp
      copying ./pywhispercpp/model.py -> build/lib.linux-aarch64-3.10/pywhispercpp
      creating build/lib.linux-aarch64-3.10/pywhispercpp/examples
      copying ./pywhispercpp/examples/main.py -> build/lib.linux-aarch64-3.10/pywhispercpp/examples
      copying ./pywhispercpp/examples/assistant.py -> build/lib.linux-aarch64-3.10/pywhispercpp/examples
      copying ./pywhispercpp/examples/__init__.py -> build/lib.linux-aarch64-3.10/pywhispercpp/examples
      copying ./pywhispercpp/examples/recording.py -> build/lib.linux-aarch64-3.10/pywhispercpp/examples
      copying ./pywhispercpp/examples/livestream.py -> build/lib.linux-aarch64-3.10/pywhispercpp/examples
      running build_ext
      -- The C compiler identification is GNU 11.3.0
      -- The CXX compiler identification is GNU 11.3.0
      -- Detecting C compiler ABI info
      -- Detecting C compiler ABI info - done
      -- Check for working C compiler: /usr/bin/cc - skipped
      -- Detecting C compile features
      -- Detecting C compile features - done
      -- Detecting CXX compiler ABI info
      -- Detecting CXX compiler ABI info - done
      -- Check for working CXX compiler: /usr/bin/c++ - skipped
      -- Detecting CXX compile features
      -- Detecting CXX compile features - done
      -- pybind11 v2.9.2
      -- Found PythonInterp: /usr/bin/python3 (found version "3.10.6")
      -- Found PythonLibs: /usr/lib/aarch64-linux-gnu/libpython3.10.so
      -- Performing Test HAS_FLTO
      -- Performing Test HAS_FLTO - Success
      -- Looking for pthread.h
      -- Looking for pthread.h - found
      -- Performing Test CMAKE_HAVE_LIBC_PTHREAD
      -- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
      -- Found Threads: TRUE
      -- CMAKE_SYSTEM_PROCESSOR: aarch64
      -- ARM detected
      -- CMAKE_SYSTEM_PROCESSOR: aarch64
      -- ARM detected
      -- Configuring done
      CMake Error at whisper.cpp/CMakeLists.txt:190 (add_library):
        Cannot find source file:

          ggml.h

        Tried extensions .c .C .c++ .cc .cpp .cxx .cu .mpp .m .M .mm .ixx .cppm .h
        .hh .h++ .hm .hpp .hxx .in .txx .f .F .for .f77 .f90 .f95 .f03 .hip .ispc

      CMake Error at whisper.cpp/CMakeLists.txt:190 (add_library):
        No SOURCES given to target: whisper

      CMake Generate step failed.  Build files cannot be regenerated correctly.
      Traceback (most recent call last):
        File "/usr/lib/python3/dist-packages/pip/_vendor/pep517/in_process/_in_process.py", line 363, in <module>
          main()
        File "/usr/lib/python3/dist-packages/pip/_vendor/pep517/in_process/_in_process.py", line 345, in main
          json_out['return_val'] = hook(**hook_input['kwargs'])
        File "/usr/lib/python3/dist-packages/pip/_vendor/pep517/in_process/_in_process.py", line 261, in build_wheel
          return _build_backend().build_wheel(wheel_directory, config_settings,
        File "/usr/lib/python3/dist-packages/setuptools/build_meta.py", line 230, in build_wheel
          return self._build_with_temp_dir(['bdist_wheel'], '.whl',
        File "/usr/lib/python3/dist-packages/setuptools/build_meta.py", line 215, in _build_with_temp_dir
          self.run_setup()
        File "/usr/lib/python3/dist-packages/setuptools/build_meta.py", line 158, in run_setup
          exec(compile(code, __file__, 'exec'), locals())
        File "setup.py", line 132, in <module>
          setup(
        File "/usr/lib/python3/dist-packages/setuptools/__init__.py", line 153, in setup
          return distutils.core.setup(**attrs)
        File "/usr/lib/python3/dist-packages/setuptools/_distutils/core.py", line 148, in setup
          return run_commands(dist)
        File "/usr/lib/python3/dist-packages/setuptools/_distutils/core.py", line 163, in run_commands
          dist.run_commands()
        File "/usr/lib/python3/dist-packages/setuptools/_distutils/dist.py", line 967, in run_commands
          self.run_command(cmd)
        File "/usr/lib/python3/dist-packages/setuptools/_distutils/dist.py", line 986, in run_command
          cmd_obj.run()
        File "/usr/lib/python3/dist-packages/wheel/bdist_wheel.py", line 299, in run
          self.run_command('build')
        File "/usr/lib/python3/dist-packages/setuptools/_distutils/cmd.py", line 313, in run_command
          self.distribution.run_command(command)
        File "/usr/lib/python3/dist-packages/setuptools/_distutils/dist.py", line 986, in run_command
          cmd_obj.run()
        File "/usr/lib/python3/dist-packages/setuptools/_distutils/command/build.py", line 135, in run
          self.run_command(cmd_name)
        File "/usr/lib/python3/dist-packages/setuptools/_distutils/cmd.py", line 313, in run_command
          self.distribution.run_command(command)
        File "/usr/lib/python3/dist-packages/setuptools/_distutils/dist.py", line 986, in run_command
          cmd_obj.run()
        File "/usr/lib/python3/dist-packages/setuptools/command/build_ext.py", line 79, in run
          _build_ext.run(self)
        File "/usr/lib/python3/dist-packages/setuptools/_distutils/command/build_ext.py", line 339, in run
          self.build_extensions()
        File "/usr/lib/python3/dist-packages/setuptools/_distutils/command/build_ext.py", line 448, in build_extensions
          self._build_extensions_serial()
        File "/usr/lib/python3/dist-packages/setuptools/_distutils/command/build_ext.py", line 473, in _build_extensions_serial
          self.build_extension(ext)
        File "setup.py", line 118, in build_extension
          subprocess.run(
        File "/usr/lib/python3.10/subprocess.py", line 524, in run
          raise CalledProcessError(retcode, process.args,
      subprocess.CalledProcessError: Command '['cmake', '/tmp/pip-install-0xv4591a/pywhispercpp_c5e26fcae91046c186dddac942177d54', '-DCMAKE_LIBRARY_OUTPUT_DIRECTORY=/tmp/pip-install-0xv4591a/pywhispercpp_c5e26fcae91046c186dddac942177d54/build/lib.linux-aarch64-3.10/', '-DPYTHON_EXECUTABLE=/usr/bin/python3', '-DCMAKE_BUILD_TYPE=Release', '-DEXAMPLE_VERSION_INFO=1.0.8', '-GNinja', '-DCMAKE_MAKE_PROGRAM:FILEPATH=/tmp/pip-build-env-mt4f3311/overlay/local/lib/python3.10/dist-packages/ninja/data/bin/ninja']' returned non-zero exit status 1.
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building wheel for pywhispercpp
Failed to build pywhispercpp
ERROR: Could not build wheels for pywhispercpp, which is required to install pyproject.toml-based projects

@FlippFuzz,
It looks like there are no prebuilt wheels for this VM CPU, you will need to build the project from source.
First make sure that whisper.cpp can be built without any errors.
Then try to install pywhispercpp from source
pip install git+https://github.com/abdeladim-s/pywhispercpp

You are welcome,
`Glad it worked.


bug: remove last visible tab / add new tab if no contract is present

I noticed following issues:

if I remove all my contract tabs via the "x" this is possible for every tab except the last one remaining for whatever reason

sometimes they also still remain in the menu (though the tab isn't displayed anymore)

I am able to remove really every contract/tab using the menu. after doing so everything is empty and cleaned up. BUT if I add a new tab which initializes the CryptoHamster example it isn't displayed to me. I need a page reload OR add another tab to let it show up

browser:

Brave Version 1.25.70 Chromium: 91.0.4472.77

hey,

if I remove all my contract tabs via the "x" this is possible for every tab except the last one remaining for whatever reason

On purpose, closing it was possible in the past, but then the UI was bugged as there was no editor to show. It's kind of assumed that you want to be working at least on one contract once you're using the tool already, right ? ;)

sometimes they also still remain in the menu (though the tab isn't displayed anymore)

Which menu do you mean exactly ? On the right, like ready to be deployed etc?

I am able to remove really every contract/tab using the menu. after doing so everything is empty and cleaned up. BUT if I add a new tab which initializes the CryptoHamster example it isn't displayed to me. I need a page reload OR add another tab to let it show up

Failing to reproduce (because I'm not getting it right I think), could you please share a quick screen cap ?

On purpose, closing it was possible in the past, but then the UI was bugged as there was no editor to show. It's kind of assumed that you want to be working at least on one contract once you're using the tool already, right ? ;)

then you should remove the "x" if only one tab is left? ;-)

Which menu do you mean exactly ? On the right, like ready to be deployed etc?

I mean the menu left where I can also remove the contracts/tabs (where it actually works to remove everything). the layout also seems to be a bit buggy there when trying to remove contracts.

Failing to reproduce (because I'm not getting it right I think), could you please share a quick screen cap ?

@marc0olo can you record a screen cap on this issue ?

https://user-images.githubusercontent.com/8124114/122568872-8015c600-d04a-11eb-9b31-b007bb1ffd72.mp4


[NEW FEATURE] Bootloader multicast upload binary

What feature would you like to be included in Luos?
The bootloader should flash the same binary on different nodes through multicast protocol

Done in Luos engine 2.7.0


Use kubernetes/kubectl lib for parsing config in svcat

This is for plugin mode only. There are some caveats:

the kubectl repo is new, and doesn't have releases yet. Their dependencies aren't pegged to release versions yet, so I had to add an override for a mutual import (client-go).

I refactored the IsPlugin() function out of cmd/svcat/plugin and into pkg/svcat as it was causing a recursive dependency loop. If you can think for a better place to put it, I'd be interested.

@carolynvs take a look?

@carolynvs
I had forgotten to rebase on master. Taking a look a this, there are non-trival merge conflicts from your commit yesterday to use the current namespace. Why did you switch to using a clientcmd.ClientConfig instead of a rest.Config? That isn't compatible with the library I wrote.

Why did you switch to using a clientcmd.ClientConfig instead of a rest.Config?

Because rest.Config doesn't contain the namespace from the current context, which was necessary for the bug fix.
Seems like what you have in kubectl is throwing away the current namespace though, and we will need that information:
https://github.com/kubernetes/kubectl/blob/315679d1c56ff401d0b20c9754f62cccd9212bf7/pkg/pluginutils/plugin_client.go#L65
// The _ is the namespace
clientConfig, _, err := clientFromConfig(kubeconfig)

Would it be possible to tweak the return type of pluginutils.InitConfig to return clientcmd.ClientConfig too? Seems like clientFromConfig could just return that instead of unpacking it into a rest client + namespace string.

Yeah, I can do that. Probably going to take a while to get the PR merged so I'll close this one and open another when I get it done.


Added unit tests to test updated Soot on a Java 17 compiled JAR

Added unit tests to test updated Soot on a Java 17 compiled JAR

TODOs

[x] Tests
[ ] Documentation

@henrikplate This PR is part of https://github.com/eclipse/steady/pull/589


[T4A3][T11-B3] Teh Chee Yeo

Ready for review.

@cheo1994 Some comments added. Please close the PR after reading comments.


Error: Standalone IL2CPP build fails

Definition
Builds fail with the following error:
Fatal error in Unity CIL Linker
Mono.Cecil.AssemblyResolutionException: Failed to resolve assembly: 'Newtonsoft.Json, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null'
OS: Windows 10
Unity version: 2021.3.23f1
SDK version: 1.5.1
Target platform: Windows Standalone
Steps To Reproduce

Create a new unity project
Import the sdk v1.5.1 from package manager
Install the sample
Add Demo Example scene to Build Settings
Change the Scripting Backend to IL2CPP by navigating to Edit/Project Settings/Player/Other Settings
Wait for the project to recompile and attempt to Build it

Possible Solution
Newtonsoft.Json.dll v13.0.0 does not support IL2CPP, changing current one to jilleJr's Newtonsoft.Json v13.0.1 should fix the issue.

I just disabled TezosUnitySDK.Newtonsoft.Json.dll and Newtonsoft.Json.dll, waiting for your confirmation to remove @k-karuna @m-kus . Added jilleJr's Newtonsoft.Json v13.0.1, fixes the issue.

I checked editor, win standalone IL2CPP and WebGL, everything works fine on both Unity 2021.3.21 and 2022.3.4


Issues installing/running server

Hello,
I tried to train the models and run the server per the readme file but have run into issues.  I am running a 64 bit Ubuntu Virtual Machine.   When I try to run the train.sh file I get an error that the python command can not be found.  When I try to run the server code the app.py script could not be found, but I saw the issue mentioning this file was in the server folder.  However, after updating the path there are several modules that can't be found.  I tried installing them with pip but got stuck when pip couldn't find components.standalone_parser  .   Note the yml file installs the most recent python in the conda environment I think as opposed to 3.5 or 2.7 as mentioned in READMe.  Are there updated instructions for getting this running on a Linux distribution?  Thanks for any pointers.

I got the same error,     "from components.standalone_parser import StandaloneParser
ModuleNotFoundError: No module named 'components'"

@Wynand212
same issue here.
Have you solved it already?
Thank you.

hey there! I managed to get it working on my machine (mac os) by doing some small changes, check it out on the pull request #36


Implement more precise abstract representation mapping

This PR implements const-to-absrepr mapping based on constant analysis.

Abstract representation of constants now almost correctly reflect the actual ext/trunc relationship
Assigning abstract representation to each constant is moved from AbsFpEncoding::constant() to AbsFpEncoding::addConstantsFromAnalysis()
Abstract representation of each constant now also reflects the actual order of values

About almost: In order to reflect the order of values using the abstract representation, f64 constants are floored during the mapping process.
This is not what typical FP applications would expect (which would be rounding)

The recent PR by @makesource fixes the issue where FP analysis missed out the constants inside linalg.generic block. I've checked by myself that our CI passes with both patches applied.

It appears that limit_bitwidth and prec_bitwidth must be adjusted according to the analysis result. I'll re-open this PR once it is implemented.

The above issue will be resolved in later PR

The issue stated above is fixed: When constructing an AbsFpEncoding, FP const analysis results are used to set the minimum required limit/prec bits to correctly encode constants


📝 Add links to the license file

Thanks! I'm not sure how necessary this is, but it doesn't hurt either, so I'll take it. 🤓 Thanks! :cake:


Vulkan validation errors caused by lifetime issue

Looks like make_device_queue_create_infos() is returning a vector containing pointers to its local default_queue_priority array, which is showing up as Vulkan validation errors. The obvious quick fix is to make the array static.

Thank you for reporting this. I am currently working on a giant pull request that I need to finish before I can really do anything else.

Fixed in a branch. It is going to take a while before it is merged in main.


recognizer.addFaces get stuck

When i'm using the face-recognition.js it won't do the training.
My images are jpg and resolutions more than 600x600 px
if (!fs.existsSync(trainedModelFile)) {
console.log('%s not found, start training recognizer...', trainedModelFile)
console.log("Read imgs");
const allFiles = fs.readdirSync(imgsPath)
const imagesByClass = nameMappings.map(c =>
allFiles
.filter(f => f.includes(c))
.map(f => path.join(imgsPath, f))
.map(fp => fr.loadImage(fp))
)
console.log("mapping");
imagesByClass.forEach(function (faces, label) {
console.log(label);
try {recognizer.addFaces(faces, nameMappings[label]);  -> it get's stuck in this line.
} catch (e){
console.log(e)
}
console.log("added");
})
console.log("write file");
fs.writeFileSync(trainedModelFile, JSON.stringify(recognizer.serialize()));

After some more tests i found out that it get stuck in this function:
const faceDescriptors = flatten(
faces.map(f => getJitteredFaces(f, numJitters).map(jf => getNet().computeFaceDescriptor(jf)))
)

How can i do a resize automatic from the pictures as you have in the opencv?

You can resize images using fr.resizeImage(image, scaleFactor). Is ot crashing during jittering or compueFaceDescriptors? Make sure your face images are atleast of size 105x105.

It works, but it takes so long to do the training that i thought it has stuck

i can specify the size of the images? like in this:
const targetSize = 200
const faceImages = detector.detectFaces(image, targetSize)

const fs = require('fs');
const path = require('path');
const cv = require('opencv4nodejs');
const fr = require('face-recognition').withCv(cv);
if (!cv.xmodules.face) {
throw new Error('exiting: opencv4nodejs compiled without face module');
}
const trainedModelFile = 'faceRecognition.json'
//const trainedModelFilePath = path.resolve(getAppdataPath(), trainedModelFile)
const imgsPath = 'imgs';
const nameMappings = ['diogo', 'pedro', 'rafael'];
//const imgFiles = fs.readdirSync(imgsPath);
const recognizer = fr.FaceRecognizer()
if (!fs.existsSync(trainedModelFile)) {
console.log('%s not found, start training recognizer...', trainedModelFile)
console.log("Read imgs");
const allFiles = fs.readdirSync(imgsPath)
const imagesByClass = nameMappings.map(c =>
allFiles
.filter(f => f.includes(c))
.map(f => path.join(imgsPath, f))
.map(fp => fr.loadImage(fp))
)
console.log("mapping");
imagesByClass.forEach(function (faces, label) {
for (var i=0 ; i<faces.length;i++)
{
  faces[i]= fr.resizeImage(faces[i], 0.2) -----> how can i change this to a value like 150x150?
}

console.log(faces);
try {recognizer.addFaces(faces, nameMappings[label]);
} catch (e){
  console.log(e)
}
console.log("added");

})
console.log("write file");
fs.writeFileSync(trainedModelFile, JSON.stringify(recognizer.serialize()));
console.log("Train is done and saved!");
}

I have done the resize, with:
const targetSize = 200
faces[i]= detector.detectFaces(faces[i], targetSize)[0]
to do the training.
But to use this in real time face recognition is not fast enough. For now, i will continue using the opencv4nodejs.

How can you get those results in the video?  https://www.youtube.com/watch?v=ArcFHpX-usQ

Now it takes 1200ms to get an answer, still far from 200ms or 20ms you can get

1200 ms for face detection or computing the face descriptor? I can get ~ 40-60ms for computing a face descriptor on my machine (intel core i5 4670K, 3.40GHz), when compiling with openblas. The mmod face detector still takes ~1s for me, but you can use faster face detectors, e.g. the frontal face detector or the OpenCV CascadeClassifier from opencv4nodejs.

to get the answer from the face recognizer,from the predictor: const prediction = recognizer.predictBest(cvFace, unknownThreshold).  I'm using the opencv CascadeClassifier to make the face detection, i have a intel i5 4210u at 2.4. but maybe later it will run on a server.
I'm trying to do compile the openblas, but for now i don't have it working, some errors in this command:
cmake .. -G "Ninja" -DCMAKE_CXX_COMPILER=clang-cl -DCMAKE_C_COMPILER=clang-cl -DCMAKE_Fortran_COMPILER=flang -DBUILD_WITHOUT_LAPACK=no -DNOFORTRAN=0 -DDYNAMIC_ARCH=ON -DCMAKE_BUILD_TYPE=Release

Hmm its better to ask openblas specific question in the openblas repo itself. They can probably provide you better help than I do.


Support bytes fields in path parameters

Just %-encoding is not a safe representation of an arbitrary byte sequence within path due to golang/go#10887.
We need to confirm the expected spec at first.


Source Replacement 2.0

Why

Enhance ability of source replacement work with vConsole
Blocking the race condition of script executing during the replacement process
Refactor and improve test quality

LGTM Krub

Don't forget to add BREAKING CHANGE: to footer


Demo broken

Looks like the demo page is broken.

I removed it because it was now gone from the old maintainer's github. Sorry, where do you still see a reference to it?

On the main package page: http://package.elm-lang.org/packages/Bogdanp/elm-datepicker/latest

Ah! That's actually the old, pre-conversion version of the package, which I don't think they'll unpublish in order not to break existing installs. I think that demo page is just a 404, and not broken due to the conversion. Here is the new page.


Typescript Errors

I am trying to use this component in Typescript but I am getting numerous errors and I am not sure how to solve this.
Failed to compile.

Error in ./src/App.tsx
(31,13): error TS2605: JSX element type 'Geosuggest' is not a constructor function for JSX elements.
  Types of property 'render' are incompatible.
    Type '() => Function' is not assignable to type '() => Element | null'.
      Type 'Function' is not assignable to type 'Element | null'.
        Type 'Function' is not assignable to type 'Element'.
          Property 'type' is missing in type 'Function'.

Can anyone suggest any help, or has anyone else used this successfully in Typescript at all ?
I've included the full library in my Typescript source because if I use the built library then I get a completely different error
Uncaught TypeError: Cannot read property 'PropTypes' of undefined
    at Object.9 (bundle.js:34639)
    at s (bundle.js:33255)
    at bundle.js:33255
    at Object.5../defaults (bundle.js:33806)
    at s (bundle.js:33255)
    at e (bundle.js:33255)
    at bundle.js:33255
    at a (bundle.js:33255)
    at Object.<anonymous> (bundle.js:33255)
    at Object.<anonymous> (bundle.js:34925)

bundle.js:798 ./src/GeoSuggest/react-geosuggest.js
Critical dependencies:
1:483-490 This seems to be a pre-built javascript file. Though this is possible, it's not recommended. Try to require the original source to get better results.
 @ ./src/GeoSuggest/react-geosuggest.js 1:483-490

Any help would be greatly appreciated.
Or even a simple Typescript app with it running so I can see where I am going wrong ;)
Regards
Anthoni

I'm not sure what your code looks like, but I was able to get it running in TypeScript with a default import:
import Geosuggest from "react-geosuggest";

class MyComponent extends React.Component<{}, {}> {

    public render(): JSX.Element {
        return (
            <div>
                <Geosuggest
                    placeholder="Your home city"
                    types={["(cities)"]}
                />
            </div>
        );
}

@AnthoniG Did this work? If not, reopen.
Thanks @mikebridge.  :)


Fix some logic found during e2e testing

This change is

Codecov Report
Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 66.73%. Comparing base (29c9799) to head (9ab4a77).

Files
Patch %
Lines

...chine.AspNetCore/Services/NmtPreprocessBuildJob.cs
66.66%
0 Missing and 1 partial :warning:

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #178   +/-   ##
=======================================
  Coverage   66.73%   66.73%
=======================================
  Files         438      438
  Lines       34387    34388    +1
  Branches     4609     4610    +1
=======================================
+ Hits        22948    22949    +1
  Misses      10350    10350
  Partials     1089     1089

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

src/SIL.Machine.AspNetCore/Services/NmtPreprocessBuildJob.cs line 124 at r1 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
The type is no longer nullable.

True. I'll fix it.


SmoothingRecursiveGaussianImageFilter with sharp discontinuity to background produces negative values in output

Description
SmoothingRecursiveGaussianImageFilter, as for example, implemented in ANTs' SmoothImage https://github.com/ANTsX/ANTs/blob/master/Examples/SmoothImage.cxx produces negative values for images with an object in the foreground surrounded by "0" or some very small value produces negative values after smoothing.
Steps to Reproduce

Grab http://www.bic.mni.mcgill.ca/~vfonov/icbm/2009/mni_icbm152_nlin_asym_09c_nifti.zip
ImageMath 3 extracted.nii.gz m mni_icbm152_t1_tal_nlin_sym_09c_mask.nii mni_icbm152_t1_tal_nlin_sym_09c.nii
SmoothImage 3 extracted.nii.gz 5 smooth.nii.gz 1 0
Observe negative values:
register smooth.nii.gz (set values under zero to be magenta)

Expected behavior
No negative values
Actual behavior
Negative values
Reproducibility
100%
Versions
ANTs HEAD
Environment
Linux Ubuntu 14.04

This may be expected for this implementation of the Gaussian. Here is the referenced paper:
Details of the implementation are described in the technical report: R. Deriche, "Recursively Implementing The Gaussian and Its Derivatives", INRIA, 1993, ftp://ftp.inria.fr/INRIA/tech-reports/RR/RR-1893.ps.gz

Thanks, I suspected the implementation details might be the cause.
Unfortunately, I think this may cause some issues with registration, since RecursiveGaussian was set as the default for optimizers as of https://github.com/InsightSoftwareConsortium/ITK/commit/569a4701b740d849a1efe20c9fd76a928c645fbb it can create features which aren't actually present.
At least a documentation update is warranted, beyond that I'm not sure what to do about it in general.


Update 03.1 Using pre trained word embeddings.ipynb

We've recently ran out of AWS credits and noticed that most of it is going to serving the GoogleNews word2vec vectors.  We'd appreciate it if you could change the link to our Azure hosted one instead.

Ooh, that is too bad!


Fix warnings

Fix all warnings, and make sure they won't sneak in again, by failing the Travis build in that case.
I also fixed the button_irq example, while I was at it.

Looks like the Travis build is failing on nightly due to deprecation warnings. I'll push another commit fixing this shortly.

Deprecation warnings have been fixed. Build is now fully green.

On "Warning Wednesday" of all days! The PR looks great, thanks Hanno!


Update api-reference.md

@PatrickFarley
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@jinruishao - Thanks for submitting the PR. The link that you are pointing to in your PR is still not on Learn. It'd be better if you point to this instead - [
Content Moderator | Microsoft Learn](https://learn.microsoft.com/en-us/rest/api/cognitiveservices/contentmoderator/operation-groups?view=rest-cognitiveservices-contentmoderator-v1.0)

@jinruishao - Can you respond to the requested changes or let us know if you would like us to commit them?
@PatrickFarley, @nitinme  - After the changes are made, please add a sign-off command to signal that the PR is ready to merge.

These changes have been made in the live article so we'll close this PR.


Serious problem with licensing

The GNU GPL v3 only requires people to provide source code with actual copies of the program. This means that if someone hosts this on the internet, as long they don't provide a download for the program, they do not need to provide source code. I highly recommend switching to the AGPL v3 in order to fix this.

Thanks for bringing this to my attention. Honestly I'm not that worried about this but I'll look into it.

The sniper is done, so I'm closing this with no further action. Thanks for bringing this to my attention though 😄


Update package

Hi, I've been looking at this package and its really helpful, but it wont install on symfony +7.0 and deepface made some changes to their package adding an anti_spoofing functionality that its currently missing on this package.
I updated the symfony version and added the new anti_spoofing thing. Do you want me to open a new pull request or are you going to update the package on your own?
Thanks!

Hey, the Symfony update is done and released - so feel free to open a new MR for the new feature.


Make the escape key work in order to close rdf modal

Currently it's really annoying to have to find and click the "Close" button every time....

moving this to future given other things that need to get done

Fixed in master.


Fix for the disappearing searchbar in new Spotify UI

After examining the code of SpicetifyDefault there is a fix for the disappearing searchbar.
/* Topbar visibility bug */ .main-topBar-topbarContent:not(.main-topBar-topbarContentFadeIn)>* {     opacity: unset !important; } .main-entityHeader-topbarContent:not(.main-entityHeader-topbarContentFadeIn)>* {     opacity: 0 !important; }
Originally posted by @SaruDesu in https://github.com/morpheusthewhite/spicetify-themes/issues/358#issuecomment-841766818

Edit after @Vialma7 's comment : this code just gets pasted into the user.css file for your theme. Any free line in the file will do.

This fix also worked for me on my WintergatanBlueprint theme. It was the one critical flaw affecting the usability of the new Spotify UI with Spicetify and I think this solves it (albeit only functionally, not by any beautiful integration with a theme).

hi how should I add the code for this?

Thank you so much, I was trying to find out how to restore it and this worked so easily :)

hi how should I add the code for this?
Go to the user.css file from your theme and just copy/paste there the code physcrowley shared.

After examining the code of SpicetifyDefault there is a fix for the disappearing searchbar.
/* Topbar visibility bug */ .main-topBar-topbarContent:not(.main-topBar-topbarContentFadeIn)>* { opacity: unset !important; } .main-entityHeader-topbarContent:not(.main-entityHeader-topbarContentFadeIn)>* { opacity: 0 !important; }
Originally posted by @SaruDesu in #358 (comment)

Edit after @Vialma7 's comment : this code just gets pasted into the user.css file for your theme. Any free line in the file will do.

This fix also worked for me on my WintergatanBlueprint theme. It was the one critical flaw affecting the usability of the new Spotify UI with Spicetify and I think this solves it (albeit only functionally, not by any beautiful integration with a theme).

Personaly i just found the first rule you mentioned and it works immediatly through the CSS inspector, i didn't understand speciticly wich element the second CSS pattern target.

Closing this issue as obsolete. New themes are currently being developed

Indeed!
I have been using the V2 branch's stuff for at least a week and a half now and it is a much better experience than these patches on the obsolete themes.


clang-tidy 14 segfault

Hello,
Running clang-tidy 14 on my available systems (ubuntu 22.02, Gentoo or arch linux) results in a segfault.
clang-format 14 doesn't segfault, nor does clang-tidy 13, 12...
Any idea?
This is an extract running the program with valgrind:
==1536299== Memcheck, a memory error detector
==1536299== Copyright (C) 2002-2017, and GNU GPL'd, by Julian Seward et al.
==1536299== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info
==1536299== Command: ./clang-tidy-14_linux-amd64
==1536299== Parent PID: 1534110
==1536299==
==1536299== Syscall param set_robust_list(head) points to uninitialised byte(s)
==1536299==    at 0x1B27B95: ??? (in /home/user/Downloads/clang-tidy-14/clang-tidy-14_linux-amd64)
==1536299==    by 0x1C2DD4E: ??? (in /home/user/Downloads/clang-tidy-14/clang-tidy-14_linux-amd64)
==1536299==    by 0x42BD1D: ??? (in /home/user/Downloads/clang-tidy-14/clang-tidy-14_linux-amd64)
==1536299==    by 0x1FFF000417: ???
==1536299==  Address 0x4000bf0 is in the brk data segment 0x4000000-0x400123f
==1536299==
==1536299== Conditional jump or move depends on uninitialised value(s)
==1536299==    at 0x1C62FF0: ??? (in /home/user/Downloads/clang-tidy-14/clang-tidy-14_linux-amd64)
==1536299==    by 0x1C62FBC: ??? (in /home/user/Downloads/clang-tidy-14/clang-tidy-14_linux-amd64)
==1536299==    by 0x1B27D86: ??? (in /home/user/Downloads/clang-tidy-14/clang-tidy-14_linux-amd64)
==1536299==    by 0x1C2DD4E: ??? (in /home/user/Downloads/clang-tidy-14/clang-tidy-14_linux-amd64)
==1536299==    by 0x42BD1D: ??? (in /home/user/Downloads/clang-tidy-14/clang-tidy-14_linux-amd64)
==1536299==    by 0x1FFF000417: ???
==1536299==
==1536299== Conditional jump or move depends on uninitialised value(s)
==1536299==    at 0x1C63074: ??? (in /home/user/Downloads/clang-tidy-14/clang-tidy-14_linux-amd64)
==1536299==    by 0x1C62FBC: ??? (in /home/user/Downloads/clang-tidy-14/clang-tidy-14_linux-amd64)
==1536299==    by 0x1B27D86: ??? (in /home/user/Downloads/clang-tidy-14/clang-tidy-14_linux-amd64)
==1536299==    by 0x1C2DD4E: ??? (in /home/user/Downloads/clang-tidy-14/clang-tidy-14_linux-amd64)
==1536299==    by 0x42BD1D: ??? (in /home/user/Downloads/clang-tidy-14/clang-tidy-14_linux-amd64)
==1536299==    by 0x1FFF000417: ???
==1536299==
==1536299== Conditional jump or move depends on uninitialised value(s)
==1536299==    at 0x1C68140: ??? (in /home/user/Downloads/clang-tidy-14/clang-tidy-14_linux-amd64)
==1536299==    by 0x1CCE1DA: ??? (in /home/user/Downloads/clang-tidy-14/clang-tidy-14_linux-amd64)
==1536299==    by 0x1CD2E44: ??? (in /home/user/Downloads/clang-tidy-14/clang-tidy-14_linux-amd64)
==1536299==    by 0x1CD60F5: ??? (in /home/user/Downloads/clang-tidy-14/clang-tidy-14_linux-amd64)
==1536299==    by 0x1C2DD88: ??? (in /home/user/Downloads/clang-tidy-14/clang-tidy-14_linux-amd64)
==1536299==    by 0x42BD1D: ??? (in /home/user/Downloads/clang-tidy-14/clang-tidy-14_linux-amd64)
==1536299==    by 0x1FFF000417: ???

@muttleyxd ?

Hi! I forked muttleyxd's repository, bisected between v.13.0.0 and v14.0.0 and I was able to locate the first bad commit - 6a605b97a2006bd391f129a606483656b7c6fb28 as I'm not familiar with these regions of LLVM codebase. I've yet to try to understand this commit in terms of why it has such effects, but hopefully this investigation will push things further for us.

Thank you for investigating. I compiled version 14.0.5 under Ubuntu 22.04 without LTO (otherwise link time never ends) which runs quite well also under Ubuntu 22, Gentoo and Arch Linux.
Thank you again!

ubuntu-22.04 is now available for github runners: https://github.com/actions/runner-images/issues/5998
I can confirm building clang-tidy-14 using ubuntu-22.04 in CI does fix this.

I confirm that higher version of clang-tidy linux amd64 are still segfaulting

same segfault on centos 7.6


DownloadPackagesV1 may report success, even if the download fails

Required Information
Question, Bug, or Feature?  Bug
Type: Error handling
Enter Task Name: DownloadPackagesV1
Environment

Server - Azure Pipelines or TFS on-premises? Azure Pipelines

Issue Description
Customer reported that in a build, the actual download failed with a message "UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Failed to extract package with error Error: Could not find the End of Central Directory Record", but the task still completed without error.
The task needs to handle, and correctly report errors in the download promise.
Additionally, add some debug logging before and after the download/process calls

Just chiming in that I saw this on 1/2/2020 too:

(node:8376) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Fetching package metadata using url ... Get failed with error Error: 404: null

It obviously failed, but the task "completed successfully."

I am seeing this as well today for the following error:
(node:9820) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Failed to download package file from **** got the following error: Error: 400: Bad Request


Update gallery.css

Closes
Closes #1109

Description

Screenshots

Note to reviewers

Checklist:

[x] I have linked the PR to the correct issue.
[x] I have read the Contribution Guidelines
[x] I have built and tested the changes, and they do not break or show any errors.

@Vaishnavi-Patil2211 please review the pr


Suppress npm warning messages

Get rid of missing package.json warnings when installing npm packages.
Also eliminating package-lock.json.

@theJian you tested installing a fresh server w/ the new command?
@teto LGTM, I don't really know much about NPM though.

I don't want to comment on issues related to 3rd party software since I dont believe nvim-lsp should do it. I don't know much about the npm ecosystem, silencing warnings in general looks like a bad idea or may mean we don't follow the normal guidelines.

Ah, good point about silent. Why do you want it to run silent @theJian ?

@tjdevries Because there was some output from npm when I ran :LspInstall vimls. Npm complains missing package.json and that really doesn't matter since our purpose is fetching npm package.

@tjdevries I tested installing vimls. It looks good. There is no warning output if installing success. I think the warning output from npm does not help but confuse users.

@theJian Neither I nor @teto are the normal maintainers here, so we're working to figure out exactly how we want to handle these kinds of PRs right now. After we figure that out, we'll give you more information about what we'll do next (or merge it, if that's the case)

merged without --silent. It's conventional in vim ecosystem to show shell output, see e.g. fugitive. And ignoring warnings/errors in general tends to be a bad tradeoff.


Multiple Controllers: DND-SD should be able to support multiple consu…

…mers
Problem
DNS-SD only supports 1 resolver delegate.
This is a problem for #10089 and for having multiple controller/commissioner objects in a single process.
Change overview

Add support for multiple delegates

Testing
It was tested by locally modifying chip-tool by having multiple instances of the CHIPDeviceController into the same process.
Fix #11562

I'm closing this one in favour of ##12481 as it does not limit the number of delegates and it has a better routing mechanism .


CT Log monitoring

Allows people to look for unauthorized certificates

Build off of this scan (https://github.com/cisagov/crossfeed/blob/master/backend/src/tasks/sslyze.ts#L16)
We need to call crt.sh for that particular domain (https://github.com/cisagov/admiral/blob/develop/src/admiral/certs/tasks.py#L46) and then save information (such as issuer name, expiration date, etc.) to the database.

The Censys Search API is another potential resource.

https://sslmate.com/ct_search_api/ is another potential source.


yarn breaks on Node 10.0

Installing heroku dependency: node
==> Downloading https://homebrew.bintray.com/bottles/node-10.0.0.high_sierra.bottle.tar.gz
==> Downloading from https://d29vzk4ow07wi7.cloudfront.net/6413fac659d9571e07eaef5cba9a2b150e04c6114984fa4ab39b05733065469b?response-content-disposition=attachment%3Bfilename%3D%22node-10.0.0.high_sierr
######################################################################## 100.0%
==> Pouring node-10.0.0.high_sierra.bottle.tar.gz
$ yarn
yarn install v1.6.0
(node:11498) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
$ node tools/nodeVersionCheck.js
[1/5] 🔍  Validating package.json...
[2/5] 🔍  Resolving packages...
[3/5] 🚚  Fetching packages...
error<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version ">=4 <=9".
error Found incompatible module
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

$ brew install node@8
$ brew link --overwrite --force node@8

got me working again, but we should be able to support Node 10 after updating our dependencies.


addAttachmentToIssue is failed to upload the file

My Code like that：

File file = new File("D:\111.txt");
attachmentManager.addAttachmentToIssue(4031, file, ContentType.TEXT_PLAIN.getMimeType());

when go to upload function, send(request) is return "Bad request (request may not contain both Content-Length and Transfer-Encoding)"

public String upload(InputStream content, long contentLength) throws RedmineException {
......
final String result = send(request);
return parseResponse(result, "upload", input -> JsonInput.getStringNotNull(input, "token"));
}

Finally, the error is "com.taskadapter.redmineapi.RedmineFormatException: org.json.JSONException: A JSONObject text must begin with '{' at character 1"

this test currently passes:
`    @Test
public void addAttachment() throws RedmineException, IOException {
String attachmentContent = "some text";
File tempFile = createTempFile(attachmentContent);
    final Issue issue = IssueFactory.create(projectId, "task with attachment");
    final Issue createdIssue = issueManager.createIssue(issue);
    attachmentManager.addAttachmentToIssue(createdIssue.getId(), tempFile, ContentType.TEXT_PLAIN.getMimeType());
    try {
        Issue loadedIssue = issueManager.getIssueById(createdIssue.getId(), Include.attachments);
        final Collection<Attachment> attachments = loadedIssue.getAttachments();
        Attachment next = attachments.iterator().next();
        assertThat(next.getFileName()).isEqualTo(tempFile.getName());
        final byte[] receivedContent = attachmentManager.downloadAttachmentContent(next);
        String contentAsString = new String(receivedContent);
        assertThat(contentAsString).isEqualTo(attachmentContent);
    } finally {
        issueManager.deleteIssue(createdIssue.getId());
    }
}

`
with a dev Redmine install behind  NGinx.
feel free to provide a test case showing a problem, if it still exists.  I will close this issue for now


[pilot][upload_to_testflight] Add missing method

Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.

Motivation and Context

While setting up TestFlight for our Mac app I came across this error:
/opt/homebrew/Cellar/fastlane/2.193.0/libexec/gems/fastlane-2.193.0/pilot/lib/pilot/manager.rb:86:in `fetch_app_platform': \e[0;31;49m[!] undefined method `fetch_app_platform' for FastlaneCore::PkgFileAnalyser:Class (NoMethodError)
Did you mean?  fetch_app_identifier\e[0m
Did you mean?  fetch_app_identifier

Description

This pull request adds the missing method so that folks do not have to specify the app_platform and Fastlane can figure it out automatically. I'm not 100% sure of this solution but it seemed like the simplest. I think it is a safe assumption that any .pkg will be for a Mac app but would be happy to adjust the solution if I'm making a bad assumption.
Testing Steps

After this fix I get
/Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/fastlane_core/lib/fastlane_core/build_watcher.rb:159:in `processed?': \e[31m[!] undefined method 'processed?' for nil:NilClass\e[0m (NoMethodError)

Full stack trace:
[17:26:00]: ----------------------------------
549[17:26:00]: --- Step: upload_to_testflight ---
550[17:26:00]: ----------------------------------
551[17:26:00]: Login to App Store Connect (_[DELETED]_)
552[17:26:02]: Login successful
553[17:26:07]: Ready to upload new build to TestFlight (App: ._[DELETED]_.)...
554[17:26:07]: Fetching password for transporter from environment variable named `FASTLANE_APPLE_APPLICATION_SPECIFIC_PASSWORD`
555[17:26:08]: Going to upload updated app to App Store Connect
556[17:26:08]: This might take a few minutes. Please don't interrupt the script.
557[17:26:46]: iTunes Transporter successfully finished its job
558[17:26:46]: --------------------------------------------------------------------
559[17:26:46]: Successfully uploaded package to App Store Connect. It might take a few minutes until it's visible online.
560[17:26:46]: --------------------------------------------------------------------
561[17:26:46]: Successfully uploaded the new binary to App Store Connect
562[17:26:46]: If you want to skip waiting for the processing to be finished, use the `skip_waiting_for_build_processing` option
563[17:26:46]: Note that if `skip_waiting_for_build_processing` is used but a `changelog` is supplied, this process will wait for the build to appear on AppStoreConnect, update the changelog and then skip the remaining of the processing steps.
564[17:26:46]: $ xar -C /var/folders/xq/3nsr0qsn5cx5wvr875qgdkx80000gn/T/d20210902-66329-kf5hq0 -xf /Users/hseapps/builds/dEnP68g9/0/hse-apps/apps/HSEAppX/HSE\ App\ X.pkg
565[17:26:46]: $ xar -C /var/folders/xq/3nsr0qsn5cx5wvr875qgdkx80000gn/T/d20210902-66329-1ieb92u -xf /Users/hseapps/builds/dEnP68g9/0/hse-apps/apps/HSEAppX/HSE\ App\ X.pkg
566[17:26:46]: Waiting for processing on... app_id:<PHONE_NUMBER>, app_version: 1.11, build_version: 3317, platform: MAC_OS
567[17:26:47]: Read more information on why this build isn't showing up yet - https://github.com/fastlane/fastlane/issues/14997
568[17:26:47]: Waiting for the build to show up in the build list - this may take a few minutes (check your email for processing issues if this continues)
569[17:27:18]: Waiting for the build to show up in the build list - this may take a few minutes (check your email for processing issues if this continues)
570+------------------------------------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
571|                                                                                Lane Context                                                                                |
572+------------------------------------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
573| PLATFORM_NAME                      |                                                                                |
574| LANE_NAME                          | macos                                                                                |
575| SIGH_PROFILE_TYPE                  | app-store                                                                                |
576| MATCH_PROVISIONING_PROFILE_MAPPING | {_[DELETED]_} |
577| BUILD_NUMBER                       | 3317                                                                                |
578| PKG_OUTPUT_PATH                    | /Users/hseapps/builds/dEnP68g9/0/hse-apps/apps/HSEAppX/HSE App X.pkg                                                                                |
579| XCODEBUILD_ARCHIVE                 | /Users/hseapps/Library/Developer/Xcode/Archives/2021-09-02/HSE App X 2021-09-02 17.22.36.xcarchive                                                                                |
580| FL_CHANGELOG                       | bundle bump (fix fastlane)                                                                                |
581|                                    |
_[DELETED]_
_[DELETED]_                                                                                |
608+------------------------------------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
609+------+----------------------------+-------------+
610|                fastlane summary                 |
611+------+----------------------------+-------------+
612| Step | Action                     | Time (in s) |
613+------+----------------------------+-------------+
614| 1    | match                      | 8           |
615| 2    | cocoapods                  | 77          |
616| 3    | increment_build_number     | 1           |
617| 4    | build_mac_app              | 211         |
618| 5    | changelog_from_git_commits | 0           |
619| 💥   | upload_to_testflight       | 117         |
620+------+----------------------------+-------------+
621[17:27:57]: fastlane finished with errors
622Looking for related GitHub issues on fastlane/fastlane...
623➡  `error=undefined method `status' for nil:NilClass` while waiting for screenshots to appear
624    https://github.com/fastlane/fastlane/issues/17831 [closed] 9 💬
625    20 Feb 2021
626➡  undefined method `login' for Spaceship::Tunes:Module
627    https://github.com/fastlane/fastlane/issues/15495 [closed] 7 💬
628    13 Feb 2020
629➡  [deliver] submit_build, promote build to production: undefined method `select_build' for nil:NilClass
630    https://github.com/fastlane/fastlane/issues/13809 [closed] 36 💬
631    28 Jan 2020
632and 15 more at: https://github.com/fastlane/fastlane/search?q=undefined%20method%20%60processed%3F%27%20for%20nil&type=Issues&utf8=✓
633🔗  You can ⌘ + double-click on links to open them directly in your browser.
634bundler: failed to load command: fastlane (/Users/hseapps/.gem/ruby/2.7.0/bin/fastlane)
**635/Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/fastlane_core/lib/fastlane_core/build_watcher.rb:159:in `processed?': \e[31m[!] undefined method `processed?' for nil:NilClass\e[0m (NoMethodError)**
636	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/fastlane_core/lib/fastlane_core/build_watcher.rb:166:in `report_status'
637	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/fastlane_core/lib/fastlane_core/build_watcher.rb:44:in `block in wait_for_build_processing_to_be_complete'
638	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/fastlane_core/lib/fastlane_core/build_watcher.rb:36:in `loop'
639	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/fastlane_core/lib/fastlane_core/build_watcher.rb:36:in `wait_for_build_processing_to_be_complete'
640	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/pilot/lib/pilot/build_manager.rb:112:in `wait_for_build_processing_to_be_complete'
641	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/pilot/lib/pilot/build_manager.rb:68:in `upload'
642	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/fastlane/lib/fastlane/actions/upload_to_testflight.rb:34:in `run'
643	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/fastlane/lib/fastlane/runner.rb:263:in `block (2 levels) in execute_action'
644	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/fastlane/lib/fastlane/actions/actions_helper.rb:69:in `execute_action'
645	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/fastlane/lib/fastlane/runner.rb:255:in `block in execute_action'
646	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/fastlane/lib/fastlane/runner.rb:229:in `chdir'
647	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/fastlane/lib/fastlane/runner.rb:229:in `execute_action'
648	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/fastlane/lib/fastlane/runner.rb:157:in `trigger_action_by_name'
649	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/fastlane/lib/fastlane/fast_file.rb:159:in `method_missing'
650	from Fastfile:32:in `block in parsing_binding'
651	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/fastlane/lib/fastlane/lane.rb:33:in `call'
652	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/fastlane/lib/fastlane/runner.rb:49:in `block in execute'
653	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/fastlane/lib/fastlane/runner.rb:45:in `chdir'
654	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/fastlane/lib/fastlane/runner.rb:45:in `execute'
655	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/fastlane/lib/fastlane/lane_manager.rb:47:in `cruise_lane'
656	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/fastlane/lib/fastlane/command_line_handler.rb:36:in `handle'
657	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/fastlane/lib/fastlane/commands_generator.rb:109:in `block (2 levels) in run'
658	from /Users/hseapps/.gem/ruby/2.7.0/gems/commander-4.6.0/lib/commander/command.rb:187:in `call'
659	from /Users/hseapps/.gem/ruby/2.7.0/gems/commander-4.6.0/lib/commander/command.rb:157:in `run'
660	from /Users/hseapps/.gem/ruby/2.7.0/gems/commander-4.6.0/lib/commander/runner.rb:444:in `run_active_command'
661	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb:117:in `run!'
662	from /Users/hseapps/.gem/ruby/2.7.0/gems/commander-4.6.0/lib/commander/delegates.rb:18:in `run!'
663	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/fastlane/lib/fastlane/commands_generator.rb:353:in `run'
664	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/fastlane/lib/fastlane/commands_generator.rb:42:in `start'
665	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/fastlane/lib/fastlane/cli_tools_distributor.rb:122:in `take_off'
666	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/bin/fastlane:23:in `<top (required)>'
667	from /Users/hseapps/.gem/ruby/2.7.0/bin/fastlane:23:in `load'
668	from /Users/hseapps/.gem/ruby/2.7.0/bin/fastlane:23:in `<top (required)>'
669	from /Users/hseapps/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/bundler-2.2.0/lib/bundler/cli/exec.rb:63:in `load'
670	from /Users/hseapps/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/bundler-2.2.0/lib/bundler/cli/exec.rb:63:in `kernel_load'
671	from /Users/hseapps/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/bundler-2.2.0/lib/bundler/cli/exec.rb:28:in `run'
672	from /Users/hseapps/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/bundler-2.2.0/lib/bundler/cli.rb:497:in `exec'
673	from /Users/hseapps/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/bundler-2.2.0/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
674	from /Users/hseapps/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/bundler-2.2.0/lib/bundler/vendor/thor/lib/thor/invocation.rb:127:in `invoke_command'
675	from /Users/hseapps/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/bundler-2.2.0/lib/bundler/vendor/thor/lib/thor.rb:392:in `dispatch'
676	from /Users/hseapps/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/bundler-2.2.0/lib/bundler/cli.rb:30:in `dispatch'
677	from /Users/hseapps/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/bundler-2.2.0/lib/bundler/vendor/thor/lib/thor/base.rb:485:in `start'
678	from /Users/hseapps/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/bundler-2.2.0/lib/bundler/cli.rb:24:in `start'
679	from /Users/hseapps/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/bundler-2.2.0/exe/bundle:49:in `block in <top (required)>'
680	from /Users/hseapps/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/bundler-2.2.0/lib/bundler/friendly_errors.rb:130:in `with_friendly_errors'
681	from /Users/hseapps/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/bundler-2.2.0/exe/bundle:37:in `<top (required)>'
682	from /Users/hseapps/.rbenv/versions/2.7.1/bin/bundle:23:in `load'
683	from /Users/hseapps/.rbenv/versions/2.7.1/bin/bundle:23:in `<main>'
684/Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/fastlane_core/lib/fastlane_core/build_watcher.rb:159:in `processed?': undefined method `processed?' for nil:NilClass (NoMethodError)
685	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/fastlane_core/lib/fastlane_core/build_watcher.rb:166:in `report_status'
686	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/fastlane_core/lib/fastlane_core/build_watcher.rb:44:in `block in wait_for_build_processing_to_be_complete'
687	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/fastlane_core/lib/fastlane_core/build_watcher.rb:36:in `loop'
688	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/fastlane_core/lib/fastlane_core/build_watcher.rb:36:in `wait_for_build_processing_to_be_complete'
689	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/pilot/lib/pilot/build_manager.rb:112:in `wait_for_build_processing_to_be_complete'
690	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/pilot/lib/pilot/build_manager.rb:68:in `upload'
691	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/fastlane/lib/fastlane/actions/upload_to_testflight.rb:34:in `run'
692	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/fastlane/lib/fastlane/runner.rb:263:in `block (2 levels) in execute_action'
693	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/fastlane/lib/fastlane/actions/actions_helper.rb:69:in `execute_action'
694	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/fastlane/lib/fastlane/runner.rb:255:in `block in execute_action'
695	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/fastlane/lib/fastlane/runner.rb:229:in `chdir'
696	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/fastlane/lib/fastlane/runner.rb:229:in `execute_action'
697	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/fastlane/lib/fastlane/runner.rb:157:in `trigger_action_by_name'
698	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/fastlane/lib/fastlane/fast_file.rb:159:in `method_missing'
699	from Fastfile:32:in `block in parsing_binding'
700	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/fastlane/lib/fastlane/lane.rb:33:in `call'
701	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/fastlane/lib/fastlane/runner.rb:49:in `block in execute'
702	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/fastlane/lib/fastlane/runner.rb:45:in `chdir'
703	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/fastlane/lib/fastlane/runner.rb:45:in `execute'
704	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/fastlane/lib/fastlane/lane_manager.rb:47:in `cruise_lane'
705	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/fastlane/lib/fastlane/command_line_handler.rb:36:in `handle'
706	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/fastlane/lib/fastlane/commands_generator.rb:109:in `block (2 levels) in run'
707	from /Users/hseapps/.gem/ruby/2.7.0/gems/commander-4.6.0/lib/commander/command.rb:187:in `call'
708	from /Users/hseapps/.gem/ruby/2.7.0/gems/commander-4.6.0/lib/commander/command.rb:157:in `run'
709	from /Users/hseapps/.gem/ruby/2.7.0/gems/commander-4.6.0/lib/commander/runner.rb:444:in `run_active_command'
710	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb:117:in `run!'
711	from /Users/hseapps/.gem/ruby/2.7.0/gems/commander-4.6.0/lib/commander/delegates.rb:18:in `run!'
712	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/fastlane/lib/fastlane/commands_generator.rb:353:in `run'
713	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/fastlane/lib/fastlane/commands_generator.rb:42:in `start'
714	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/fastlane/lib/fastlane/cli_tools_distributor.rb:122:in `take_off'
715	from /Users/hseapps/.gem/ruby/2.7.0/gems/fastlane-2.193.1/bin/fastlane:23:in `<top (required)>'
716	from /Users/hseapps/.gem/ruby/2.7.0/bin/fastlane:23:in `load'
717	from /Users/hseapps/.gem/ruby/2.7.0/bin/fastlane:23:in `<top (required)>'
718	from /Users/hseapps/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/bundler-2.2.0/lib/bundler/cli/exec.rb:63:in `load'
719	from /Users/hseapps/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/bundler-2.2.0/lib/bundler/cli/exec.rb:63:in `kernel_load'
720	from /Users/hseapps/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/bundler-2.2.0/lib/bundler/cli/exec.rb:28:in `run'
721	from /Users/hseapps/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/bundler-2.2.0/lib/bundler/cli.rb:497:in `exec'
722	from /Users/hseapps/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/bundler-2.2.0/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
723	from /Users/hseapps/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/bundler-2.2.0/lib/bundler/vendor/thor/lib/thor/invocation.rb:127:in `invoke_command'
724	from /Users/hseapps/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/bundler-2.2.0/lib/bundler/vendor/thor/lib/thor.rb:392:in `dispatch'
725	from /Users/hseapps/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/bundler-2.2.0/lib/bundler/cli.rb:30:in `dispatch'
726	from /Users/hseapps/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/bundler-2.2.0/lib/bundler/vendor/thor/lib/thor/base.rb:485:in `start'
727	from /Users/hseapps/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/bundler-2.2.0/lib/bundler/cli.rb:24:in `start'
728	from /Users/hseapps/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/bundler-2.2.0/exe/bundle:49:in `block in <top (required)>'
729	from /Users/hseapps/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/bundler-2.2.0/lib/bundler/friendly_errors.rb:130:in `with_friendly_errors'
730	from /Users/hseapps/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/bundler-2.2.0/exe/bundle:37:in `<top (required)>'
731	from /Users/hseapps/.rbenv/versions/2.7.1/bin/bundle:23:in `load'
732	from /Users/hseapps/.rbenv/versions/2.7.1/bin/bundle:23:in `<main>'
734ERROR: Job failed: exit status 1

@Igralino, could you open a separate issue?

@lucgrabowski made an issue: https://github.com/fastlane/fastlane/issues/19330


Added YouTube Channels under DBMS section

DBMS (Database)- YouTube Channels under tutorial section

Fixes Issue #305

Description:
Added YouTube channels links for learning about DBMS .

Checklist:
Before submitting your pull request, ensure that you have completed the following tasks:

[x] I have carefully reviewed and adhered to the contributing guidelines before creating this pull request.
[x] I followed the prescribed PR title template. (Check this if you're adding a resource)

Changes done @jfmartinz

Can you solve the conflict?


Why check anchors for download & svg not in docs ?

Describe the problem
https://github.com/sveltejs/kit/blob/e79cf049ab36d42d6db0d0bb0092ea4e36dc937f/packages/kit/src/runtime/client/router.js#L144
Describe the proposed solution
add explanation of this behavior in docs anchors attributes
Alternatives considered
No response
Importance
would make my life easier
Additional Information
No response

I don't quite understand what's there to document. download is checked and skipped because routing downloads doesn't make sense as a browser behaviour. And we're also not doing different behaviours for SVG, we're handling it that way because anchors in SVG has a different API.

Not explicit behaviour for users. I’m understood - it’s default & native but in sveltekit scope… I think it’s maybe usefull

Also, the rel=external behavior is documented here.

Not explicit behaviour for users. I’m understood - it’s default & native but in sveltekit scope… I think it’s maybe usefull

Having download anchors to download stuff sounds like an expected behaviour, I don't think this needs to be documented. As rmunn pointed out, we have special handling for rel=external and that's already documented. Unless you have something else in mind to document?


Implement new naming

hivereview should be registered on the following platforms:

[x] Email
[x] GitHub

[x] Rename 'master' branch to 'main'

[x] Twitter (claim an impersonation - need to register domain and email first)
[ ] Instagram
[ ] Slack channels

[ ] Name in README

[ ] AWS

[ ] Cloudwatch dashboard name and link in README

[ ] Codebase
[ ] URLS
[ ] Logging
[x] User-facing page titles
[x] About page
[ ] NPM
[ ] Docker
[ ] Feedback form

Created the twitter account today #222 and attempted an impersonation request for @thehive

On GitHub or Twitter?

On GitHub or Twitter?

Twitter, then if that doesn't work, try and claim @hivereview to match @hivereview
It wasn't until I saw the link turn to GitHub that I realised there was one we could claim.

There are 4 cards on the Miro Kanban board that cover the 4 remaining tasks in here

According to https://docs.aws.amazon.com/Route53/latest/DeveloperGuide/migrate-dns-domain-inactive.html, change the NS records on the other DNS provider to:
ns-369.awsdns-46.com.
ns-1354.awsdns-41.org.
ns-1700.awsdns-20.co.uk.
ns-532.awsdns-02.net.

which come from https://console.aws.amazon.com/route53/v2/hostedzones#ListRecordSets/Z0299021AEV76N8DAORB

NS records have propagated according to https://checkdns.one/#/NS/hive.review and staging.hive.review is working correctly. So deploying production to create the hive.review A record.


Rexport dependencies from gtk

Fixes #73

Can you do the same for gtk-rs too?

Can you do the same for gtk-rs too?

Sure

Shouldn't the same be done for gdk4/gsk4?

Shouldn't the same be done for gdk4/gsk4?

Which makes me wonder, should gdk re-export gdk-x11/gdk-wayland using a feature flag?

Which makes me wonder, should gdk re-export gdk-x11/gdk-wayland using a feature flag?

That seems potentially useful, but it would make gdk depend on those crates... while those crates themselves already depend on gdk :)

This one should be ready, it makes getting started with gtk-rs much simpler as you don't have to know all the details to display a window. I like it :)


Add Value Objects

Adding Value Objects For just Two Aggregate root Models :
Passenger and Aircrafts

I'll work on implementing the recommended changes.


modernize js

the examples could be better (what is example 1 doing?) but at least this is an obvious improvement
also one of those times Functional classes are faster (example 2)
example 3 has a few polyfills and is outdated but didn't change it. Also I found the source: https://github.com/xui/xui/blob/master/src/base.js
    throw RangeError(`Cannot create product ${this.name} with a negative price`);

has 4 indent and then 77 chars = 81 chars. There might've been a line length max but it's not documented and https://github.com/pulsar-edit/language-examples/blob/master/languages/git.COMMIT_EDITMSG has a longer line.
kinda resolves #1

I mean that is why I opened a issue against it. Even from my rudimentary knowledge of js.... Even I knew it was outdated 😅


Include image_decoders-es5/minified-es5 in the pdfjs-dist library (issue 12220)

Add a image_decoders-es5 gulp task, and include it in the pdfjs-dist library

Include minified-es5 in the pdfjs-dist library (issue 11892)
Note that this will increase the run-time of gulp dist and gulp dist-install, but that's unavoidable given that there's now additional building happening.

Fixes #12220

Tested locally and this seems to work just fine. Thanks!


Deleting feature in Settings doesn't work

Regardless if I try to use any of those the feature doesn't work and my data isn't deleted.

Update: deleting all previous exams works.