Appstudio update test-component-pac-ukyy

Pipelines as Code configuration proposal

Pipelines as Code CI/test-component-pac-ukyy-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
26 seconds
init

✅ Succeeded
44 seconds
clone-repository

✅ Succeeded
1 minute
build-container

✅ Succeeded
28 seconds
deprecated-base-image-check

✅ Succeeded
29 seconds
sanity-inspect-image

✅ Succeeded
3 minutes
clair-scan

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
23 seconds
sbom-json-check

✅ Succeeded
11 seconds
sanity-optional-label-check

✅ Succeeded
9 seconds
sanity-label-check

✅ Succeeded
13 seconds
show-summary

Pipelines as Code CI/test-component-pac-ukyy-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
26 seconds
init

✅ Succeeded
44 seconds
clone-repository

✅ Succeeded
1 minute
build-container

✅ Succeeded
28 seconds
deprecated-base-image-check

✅ Succeeded
29 seconds
sanity-inspect-image

✅ Succeeded
3 minutes
clair-scan

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
23 seconds
sbom-json-check

✅ Succeeded
11 seconds
sanity-optional-label-check

✅ Succeeded
9 seconds
sanity-label-check

✅ Succeeded
13 seconds
show-summary

Pipelines as Code CI/test-component-pac-ukyy-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
10 seconds
init

✅ Succeeded
22 seconds
clone-repository

✅ Succeeded
49 seconds
build-container

✅ Succeeded
15 seconds
sanity-inspect-image

✅ Succeeded
14 seconds
deprecated-base-image-check

✅ Succeeded
47 seconds
clamav-scan

✅ Succeeded
13 seconds
clair-scan

✅ Succeeded
10 seconds
sbom-json-check

✅ Succeeded
14 seconds
sanity-label-check

✅ Succeeded
14 seconds
sanity-optional-label-check

✅ Succeeded
6 seconds
show-summary


forensic graph shows lists of types

The forensic graph displays lists of entity types in the legend like person, agent, officeholder instead of just the primary, Person.

After talking with Brandon and seeing the behavior, I think this has been addressed.


OnChooseFile event generateBlob/generateImage empty

pretty much what the title said.
example:
<croppa v-model="img"
	@zoom="generateImage"
	@move="generateImage"
	@file-choose="generateImage"
	@image-remove="generateImage"
></croppa>
<button type="button" @click="generateImage">try</button>

methods: {
    generateImage: function() {
	this.img.generateBlob(
	  blob => {
		console.log(blob); // empty on @file-choose it is empty, any other event is is filled. Also the button click event
	},
	'image/jpeg',
	0.8
	); // 80% compressed jpeg file;
	},
     }
}

Or is it the wrong event that I am using?

Why u use image-remove?
Maybe u can use this.
<croppa v-model="myCroppa"
name="croppaLab"
@mousemove="generateImage"
id="avatarPicture"
ref="myCroppaRef"
:width="300"
:height="300"
:prevent-white-space="true"
:show-remove-button="false"
:canvas-color="'#C0C0C0'"
:zoom-speed="5"
@new-image-drawn="generateImage"
:show-loading ="true"
:loading-size ="10"
loading-color = "'#606060'">

methods: {
storeInfo: function() {
let image = this.myCroppa.generateBlob(
blob => {
let formData = new FormData()
      if(this.email != localStorage.usr_email){
      formData.set("usr_email", this.email)
      this.sendParams = true
      }

      if(this.fullnameBase != localStorage.usr_fullname){
      formData.set("usr_fullname", this.fullnameBase)
      this.sendParams = true
      }

      if(this.phone != localStorage.usr_phone){
      formData.set("usr_phone", this.phone)
      this.sendParams = true
      }

      if(blob === null){
      }else{
      formData.set("usr_photo", blob)
      this.sendParams = true
      }
      if(this.sendParams == true){
      api.changeUserData(formData).then(response => {
        // console.log(response.data)
        if (response.data.Result === "OK") {
          localStorage.setItem("usr_fullname", this.fullnameBase)
          localStorage.setItem("usr_email", this.email)
          localStorage.setItem("usr_phone", this.phone)
          blob = this.myCroppa.generateDataUrl()
          this.imgUrl == blob
          // console.log(this.imgUrl)

          localStorage.setItem("usr_photo", this.imgUrl)
           location.reload();

        }

      })}
    },
    "image/jpeg",
    1
  )
}

,generateImage: function() {
let url = this.myCroppa.generateDataUrl()
if (!url) {
return
}
localStorage.removeItem("usr_photo")
localStorage.usr_photo = this.myCroppa.generateDataUrl()
this.imgUrl = localStorage.usr_photo
}

@MomciloNikolic that is 100% unhelpfull. You are not describing what your code does and for what I see it has totally nothing to do with what I am asking for. You ask why i use the remove event, because I want to update the blob value to the parent when you remove a image. Otherwise you would delete it, but there will be no event send to parent with a 'null' value. So the parent still got the previous value (if there was a blob before);

@nielslucas sorry about the late reply. When file-choose event fired the image is not yet drawn on the canvas so the blob is empty. new-image-drawn is the right event you should use.


Remove all references to 2DII

[ ] DESCRIPTION file
[ ] GH actions
[ ] (Maybe) License file(s)
[ ] Function docs
[ ] README
[ ] pkgdown links
[ ] vignettes
[ ] update NEWS.md (if relevant)

Relates to https://github.com/RMI-PACTA/r2dii.data/issues/295

also change links from https://github.com/2DegreesInvesting/r2dii.colours to https://github.com/RMI-PACTA/r2dii.colours, e.g. in the README

still relevant issue


Fixed attributes update on cvat-canvas

Motivation and context
Resolved #8133
How has this been tested?

Checklist

[x] I submit my changes into the develop branch
[x] I have created a changelog fragment
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] I have linked related issues (see GitHub docs)
[x] I have increased versions of npm packages if it is necessary
(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.

Summary by CodeRabbit

Improvement

Enhanced the clarity and accuracy of attribute names displayed within the canvas view by using a more precise mapping from attribute IDs to names.

Codecov Report
Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.27%. Comparing base (b17d293) to head (f3d2d4f).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8137      +/-   ##
===========================================
- Coverage    83.62%   83.27%   -0.35%
===========================================
  Files          383      389       +6
  Lines        40507    41272     +765
  Branches      3830     3855      +25
===========================================
+ Hits         33873    34369     +496
- Misses        6634     6903     +269

Components
Coverage Δ

cvat-ui
79.39% <76.43%> (-0.25%)
:arrow_down:

cvat-server
86.75% <75.90%> (-0.51%)
:arrow_down:


fix: check if alacrittyConfigPath is undefined before reading the file

fix for #73

Good catch! Thank you 😎

:tada: This PR is included in version 4.1.6 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[sqllab] sql editor is not accessible

A clear and concise description of what the bug is.
When clicked on sqleditor blank page appears
Expected results
Should open sql editor
Actual results
For admin user

Screenshots
If applicable, add screenshots to help explain your problem.
How to reproduce the bug

login with admin
Click on sqllab

Logs from browser console
Unexpected key "requestedQuery" found in previous state received by the reducer. Expected to find one of the known reducer keys instead: "sqlLab", "localStorageUsageInKilobytes", "messageToasts", "common". Unexpected keys will be ignored. redux.js:319

Uncaught TypeError: theme.colors is undefined
    css index.tsx:43
    handleInterpolation emotion-serialize.browser.esm.js:137
    serializeStyles emotion-serialize.browser.esm.js:251
    Emotion emotion-element-4fbd89c5.browser.esm.js:150
    withEmotionCache emotion-element-4fbd89c5.browser.esm.js:27
    renderWithHooks react-dom.development.js:14826
    updateForwardRef react-dom.development.js:16841
    beginWork react-dom.development.js:18679
    callCallback react-dom.development.js:189
    invokeGuardedCallbackDev react-dom.development.js:238
    invokeGuardedCallback react-dom.development.js:293
    beginWork$1 react-dom.development.js:23235
    performUnitOfWork react-dom.development.js:22186
    workLoopSync react-dom.development.js:22162
    performSyncWorkOnRoot react-dom.development.js:21788
    scheduleUpdateOnFiber react-dom.development.js:21220
    updateContainer react-dom.development.js:24408
    legacyRenderSubtreeIntoContainer react-dom.development.js:24793
    unbatchedUpdates react-dom.development.js:21935
    legacyRenderSubtreeIntoContainer react-dom.development.js:24792
    render react-dom.development.js:24875
    <anonymous> index.tsx:23
    tsx sqllab.2a7335f4.entry.js:5243
    __webpack_require__ sqllab.2a7335f4.entry.js:854
    fn sqllab.2a7335f4.entry.js:151
    19 sqllab.2a7335f4.entry.js:5962
    __webpack_require__ sqllab.2a7335f4.entry.js:854
    checkDeferredModules sqllab.2a7335f4.entry.js:46
    <anonymous> sqllab.2a7335f4.entry.js:994
    <anonymous> sqllab.2a7335f4.entry.js:997
index.tsx:43

The above error occurred in the <EmotionCssPropInternal> component:
    in EmotionCssPropInternal (at SqlEditorLeftBar.jsx:160)
    in div (created by Styled(div))
    in Styled(div) (at SqlEditorLeftBar.jsx:159)
    in div (created by Styled(div))
    in Styled(div) (at SqlEditorLeftBar.jsx:158)
    in div (at SqlEditorLeftBar.jsx:142)
    in SqlEditorLeftBar (at SqlEditor.jsx:698)
    in div (created by SqlEditor)
    in Transition (created by CSSTransition)
    in CSSTransition (at SqlEditor.jsx:692)
    in div (at SqlEditor.jsx:691)
    in SqlEditor (created by ConnectFunction)
    in ConnectFunction (at TabbedSqlEditors.jsx:387)
    in div (created by TabPane)
    in TabPane (created by Styled(TabPane))
    in Styled(TabPane) (at TabbedSqlEditors.jsx:381)
    in div (created by TabPanelList)
    in div (created by TabPanelList)
    in TabPanelList (created by ForwardRef(Tabs))
    in div (created by ForwardRef(Tabs))
    in ForwardRef(Tabs) (created by Tabs)
    in Tabs (created by Styled(Tabs))
    in Styled(Tabs) (at TabbedSqlEditors.jsx:407)
    in TabbedSqlEditors (created by ConnectFunction)
    in ConnectFunction (at App.jsx:104)
    in div (at App.jsx:110)
    in ThemeProvider (at App.jsx:109)
    in App (created by ConnectFunction)
    in ConnectFunction (at App.jsx:114)
    in ThemeProvider (at App.jsx:113)
    in Provider (at App.jsx:112)
    in Application (created by HotExportedApplication)
    in AppContainer (created by HotExportedApplication)
    in HotExportedApplication (at SqlLab/index.tsx:22)

React will try to recreate this component tree from scratch using the error boundary you provided, AppContainer. react-dom.development.js:19561

Environment
Latest master
(please complete the following information):

superset version: latest master
python version: 3.8

Checklist
Make sure to follow these steps before submitting your issue - thank you!

[x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[ ] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context
Add any other context about the problem here.

I'm having the same problem, could you tell me if you found a solution?
Thank you very much in advance.
Regards.-


[Service fabric deploy] Diff package should only be created for an upgrade scenario

Diff package creation takes dependency on the currently deployed application. In case the application is removed(if user has selected to overwrite application), then diff package becomes invalid.
Hence we should only create diff package in case of application upgrade.

This issue is stale because it has been open for a year with no activity. Remove the stale label or comment on the issue otherwise this will be closed in 5 days


Add recipe that allows getting a payload without using PushMessageData

This would be useful when replying to some StackOverflow questions (since usually people want a browser-agnostic way to get the payload and Chrome doesn't support push payloads yet).

I like it, well documented!


Imdb_list rejects

I'm not sure if this issue is related to this report https://github.com/Flexget/Flexget/issues/729 .. But all new movies in watch list from the imdb_list is being rejected because of possible login page.  Nothing from the watch list is getting through to be added to the movie-queue.  Thanks
Attached is a debug log
imdb_list_debug.txt

If this is meant to be a task that adds to your movie queue, you shouldn't have the download plugin in there.

That's the weird thing... I don't have a download plugin with my imdb task. It's only to fill the movie queue and I use discover with the movie queue to download..
 The reason why it's rejecting and trying to download is because of the transmission plugin under global template. It's trying to pass the accepted imdb entry through transmission, then rejecting. The retry_failed keeps trying in a endless loop and nothing gets added to the movie queue.
:facepunch: for myself. Sorry


Bug in actions timeout on low resource systems

Environment
Device and OS: GitHub CI runners
Steps to reproduce

CI/CD pipeline

Expected result
Timeout error.
Actual Result

Visual Proof (screenshots, videos, text, etc)
Severity/Priority
Additional Context
Only occurs on low resource systems like GitHub runners.

Current go tests do not properly parse and verify this returned error is of the correct format, only that an error is returned.  For our tests we should go back and make sure we are verifying the format of returned errors is of the expected form.

This doesn't seem to be only on "low resource" systems - I can observe this on my System76 darp8 - I think this has to do with how we execute the commands with context and do the wait group stuff...

https://stackoverflow.com/questions/71714228/go-exec-commandcontext-is-not-being-terminated-after-context-timeout

The only issue with that is that it uses syscall: https://go.googlesource.com/proposal/+/refs/heads/master/design/freeze-syscall.md


Cannot build a project on mac

HI! Could you help me? I Create a project by using init script:
dub run godot-dlang:init
Project successfully initialized.
(dmd-2.109.1) 12:20:49 ~/stan/ddd $ dub build

    Starting Performing "debug" build using /Users/user/dlang/dmd-2.109.1/osx/bin/dmd for x86_64.

  Up-to-date godot-dlang:util 0.7.0: target for configuration [library] is up to date.

  Up-to-date utf_bc 0.2.1: target for configuration [library] is up to date.

    Building godot-dlang 0.7.0: building configuration [default]

   Pre-build Running commands

../../.dub/packages/godot-dlang/0.7.0/godot-dlang/classes/godot/builtins.d(9947,15): Error: unable to read module `packedvector4array`

../../.dub/packages/godot-dlang/0.7.0/godot-dlang/classes/godot/builtins.d(9947,15):        Expected 'godot/packedvector4array.d' or 'godot/packedvector4array/package.d' in one of the following import paths:

import path[0] = ../../.dub/packages/godot-dlang/0.7.0/godot-dlang/src

import path[1] = ../../.dub/packages/godot-dlang/0.7.0/godot-dlang/classes

import path[2] = ../../.dub/packages/godot-dlang/0.7.0/godot-dlang/modules/util/

import path[3] = ../../.dub/packages/utf_bc/0.2.1/utf_bc/source/

import path[4] = /Users/user/dlang/dmd-2.109.1/osx/bin/../../src/phobos

import path[5] = /Users/user/dlang/dmd-2.109.1/osx/bin/../../src/druntime/import

Error /Users/user/dlang/dmd-2.109.1/osx/bin/dmd failed with exit code 1.

Can you build asteroids example to see if it is working? If so, it could be init script that has not been updated for quite some time.


helm: Fix indentation

Fixes: #10827
Signed-off-by: Michi Mutsuzaki<EMAIL_ADDRESS>

updated https://github.com/cilium/cilium/pull/10794 instead

updated #10794 instead

So this PR can be closed?

Coverage decreased (-0.02%) to 45.463% when pulling 9ea041e6ea396dc05192cc1e0500e9b79a11df63 on pr/michi/indent into 8162f6b69d4b571705bcc30e19f6bfdf53b66b96 on master.


openmx: parse vdW info

Parse the info about used van der Waals correction method with test.
I used G10 key for the DFT-D3 method (S. Grimme, J. Antony, S. Ehrlich, and H. Krieg, J. Chem. Phys. 132, 154104 (2010)), it is not defined in the metainfo, but at least one parser already uses it and it is consistent with the G06 definition).
However I have to say I'm not too happy about the metainfo shortcuts (for the Grimme's methods), to be honest I've never seen G06 or G10 used as a shortcut for them, while in contrary DFT-D2 and DFT-D3 (and recently DFT-D4) seems to be the defacto standard nomenclature.
For example:
https://www.chemie.uni-bonn.de/grimme/de/software/dft-d3 (this is the Grimme's page)
https://www.vasp.at/wiki/index.php/Category:Van_der_Waals_functionals
https://www.quantum-espresso.org/Doc/INPUT_PW.html#idm656
https://www.openmx-square.org/openmx_man3.9/node164.html
https://wiki.fysik.dtu.dk/ase/ase/calculators/dftd3.html
etc...
I plan to add support for this to more parsers as I have some plans for some data mining from NOMAD where it would be very usefull if I could tell if vdW correction was used or not, so now might be a good time to open the discussion about the metainfo clarification...
Also "none" or "no" instead of empty string might be a better value for the case when no correction was applied?

ping @ladinesa @ndaelman-hu as possible reviewers

@ondracka we are also trying out Discord now as the new place of community support: https://discord.gg/q9bg7DD6
Obviously, technical discussions about an issue can remain on the Git repo :)

Also "none" or "no" instead of empty string might be a better value for the case when no correction was applied?

It should be None, I agree.
Moreover, the name VdW should be changed to clarify when we mean an external correction or the physics of the Hamiltonian. @JosePizarro3 We should look into an approach for this when designing ModelMethod.

@ondracka The workflow doesn't seem to have triggered. Did you try the tests locally?

@ondracka The workflow doesn't seem to have triggered. Did you try the tests locally?

I think it was because the upstream moved in the meantime, it runs fine after rebasing...

So should I reduce this new testcase? BTW in the past I always commited full calculations so that we test in same scenario as during upstream upload and also to save myself some work in the future (so that I don't have to add new testcase for every new feature, sometimes the new tests could just reuse the calculation data that is already in the repo). Just let me know how to do it properly.

Let's see what @ladinesa says. Probably this is best for when we move to the standalone sections.
In that case, we will reduce them later on.
I understand reusing tests for features, but in many cases new calculations have to be generated anyhow, meaning the work and volume is bigger anyhow.

OK, sorry, might have been too hasty with the merge button when I saw the approval.

OK, sorry, might have been too hasty with the merge button when I saw the approval.

It's fine. No worries. Thx for contributing!

Thanks for the review.


DNS False Negatives

🐛 Summary
If ScubaGoggles is unable to make DNS queries at all (e.g., due to network issues), the report will display passes for all SPF, DKIM, and DMARC checks.
To reproduce
Easiest way to reproduce this is to hard-code an error at the top of the query function within the RobustDNSClient so that the DNS calls don't work.
Expected behavior
You'd expect the report to display failures.
Any helpful log output or screenshots
The fix is super easy. Within Gmail.rego, change
AllDomains contains Domain.domain if {
    some Domain in input.dkim_records
}

to
AllDomains := {Domain | some Domain in input.domains}

Note that you'll also need to update the rego unit tests.

Blocked by https://github.com/cisagov/ScubaGoggles/pull/146.


[Slider]: Fix Slider div styles.

[ ] PR has tests / docs demo, and is linted.
[ ] Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
[ ] Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

Resolves: https://github.com/callemall/material-ui/issues/3282
The issue with the current slider style was that it used to apply styles twice because of the prepareStyles being used and hence the width % was being applied twice.
I removed the prepare styles component and replace it with the inline style class which was being used anyway. So the style will be applied only once to the "root" div.
I only changed two lines though the others where included when I made a pull from the upstream master.

@tintin1343 Notice that fixing the issue will introduce a breaking change.

Closing this as I was having issues with the commit log. Created a new PR #4087


Summary
Feature to check if the location comes from gps provider or mock location app
API Changes
Shiny.Locations/IGpsReading.cs
bool IsFromMockProvider {get;}

Shiny.Locations/Platforms/Android/GpsReading.cs
public bool IsFromMockProvider  => this.location.IsFromMockProvider;

Shiny.Locations/Platforms/macOS+iOS/GpsReading.cs
public bool IsFromMockProvider  => DeviceInfo.DeviceType == DeviceType.Virtual

Shiny.Locations/Platforms/Uwp/GpsReading.cs
We can use PositionSource but there is no guarantee that all unknown or obfuscated PositionSources are mocked
public bool IsFromMockProvider  => false;

Shiny.Locations/Platforms/Tizen/GpsReading.cs
Is there a way to check is gps mocked? With the tizen location manager we can only check if a mock location is enabled, but it may not help determine if each location is mocked.
public bool IsFromMockProvider  => false;

Intended Use Case
As an example, I would like to use a custom gps delegate that would not perform any action if the gps data were received from mock provider

This isn't something I want to add at this time since it only applies to Android.


Use fnmatchcase for case sensitivity on all platforms

It turns out fnmatch is case-insensitive on Windows, causing some very rare build failures, e.g. https://github.com/stm32-rs/stm32-rs/pull/369. Using fnmatchcase should remedy the issue.

bors r+


xtask: allow clippy needless borrows

Signed-off-by: John Eckersberg<EMAIL_ADDRESS>

I'm OK with this but can you explain why you're adding this?
Isn't this covered by the usage of global lints in Cargo.toml now?
Is this prep for another PR?

Hm no it looks like the global lints aren't covering it.  I just noticed that clippy started complaining after https://github.com/containers/bootc/pull/703/files#diff-1b2f83403e0dae2d6172ad76c50e66039ec03402104f90900a29203790d21051R144

Looks like I can fix it globally by just adding it to the root Cargo.toml so I'll change this to do that instead.

I'm not getting any errors from make validate on current git main though. Oh...is this rustc version drift? My toolchain refresh cycle is a bit slow, was on 1.77. Just updated to 1.79, but I still don't see any clippy warnings on current git main.

I'm not getting any errors from make validate on current git main though. Oh...is this rustc version drift? My toolchain refresh cycle is a bit slow, was on 1.77. Just updated to 1.79, but I still don't see any clippy warnings on current git main.

With stable/1.79 I get:
$ cargo +stable clippy
   Compiling bootc-lib v0.1.13 (/var/home/jeckersb/git/bootc/lib)
    Checking tests-integration v0.1.0 (/var/home/jeckersb/git/bootc/tests-integration)
    Checking xtask v0.1.0 (/var/home/jeckersb/git/bootc/xtask)
warning: the borrowed expression implements the required traits
   --> xtask/src/xtask.rs:144:28
    |
144 |     std::fs::write(target, &schema)?;
    |                            ^^^^^^^ help: change this to: `schema`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
    = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default

warning: `xtask` (bin "xtask") generated 1 warning (run `cargo clippy --fix --bin "xtask"` to apply 1 suggestion)
    Checking bootc v0.1.9 (/var/home/jeckersb/git/bootc/cli)
    Finished `dev` profile [optimized + debuginfo] target(s) in 3.42s

I'm a bit confused as I don't get that with the same rust version; but it's OK no need to dig in now...

I'm a bit confused as I don't get that with the same rust version; but it's OK no need to dig in now...

Was/is your local main branch behind upstream?  #703 only went in last night.


fix(network): using the last forwarded IP from the list

Description
This PR changes the user IP to get the last IP from the list in X-Forwarded-For instead of the first since the AWS Load Balancer appends the IP to the end.
How Has This Been Tested?
Not tested.

Due Diligence

[ ] Breaking change
[ ] Requires a documentation update
[ ] Requires a e2e/integration test update

I think this works, but can we switch to this library? https://github.com/WalletConnect/push-server/blob/8b7d285271d011061b6aa282eacecc8587b2529b/src/lib.rs#L202

Added the unit test to make sure it works as expected. Yes, this should be a follow-up after this quick fix.


Split ip field if it contains multiple ips, and lookup the first public ip.

This adresses issue 58 https://github.com/logstash-plugins/logstash-filter-geoip/issues/58
When containing more than one ip, only the first non private (RFC1918) ip will be used for lookup. This is helpful if you want to remove proxy ips and use the actual client ip.
If desired, this can be deactivated in the config to restore the previous behaviour.

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then  say 'jenkins, test it'.

This is really useful since it allows to simply use the X-Forwarded-For header without modification. It evens handles (with a warning) the "unknown" ip sent by some squid servers with forwarded_for=no, instead of dropping the whole log when first ip in array is "unknown" (current behaviour)

I'm getting Invalid IP network, skipping for 10/8 and 192.168/16 shouldn't those be <IP_ADDRESS>/8 and <IP_ADDRESS>/16 ?

@Cactusbone thanks for the feedback, I will look into it.

Hey guys, I would appreciate it if you close this PR, because

it's been a year and the whole thing is quite outdated
I have come to the conclusion that it would be better to extract the functionality into a separate field, so as to maintain everything easily. Here's the repo: https://github.com/IngaFeick/logstash-filter-forwarded
Cheers and thanks!


Notify amount of RAM bought in buyram action

Relayed for @chengevo from EOSIO/eos#5350
Currently there's no way to tell how much RAM bought in a buyram transaction, except for comparing the RAM change before and after buying.
The reason is, unlike any token transfer in EOSIO system, is handled by specific action in that token contract, by tracking that action, you can tell much token an account received/sent. However, when a account "received" certain amount of RAM, the eosio.system contract simply changes account's RAM amount, and didn't reveal how much RAM you bought.
Event though there's a buyrambytes function provided, while upon buying ram, user can specify the amount of RAM want to buy instead of the token to spend. Underneath it firstly calculate the amount of EOS going to cost given how much RAM you want to buy.
But I think this approach might not that accurate, given that the actual RAM market price can differ that the price doing the calculation. So user cannot 100 percent trust that he/she can get the RAM claims to buy.
It would be nice to include a receipt indicating how much RAM bought in a transaction. And it can be achieved by setup an action(function), which did nothing just accepting the amount of RAM bought in a transaction. Every time when the RAM market response with filling result, call this function as a inline action, so that buyer can be notified how much RAM he/she got.
The implementation might looks like this:
void system_contract::buyram( account_name payer, account_name receiver, asset quant )
{
    // ....
     int64_t bytes_out;

      const auto& market = _rammarket.get(S(4,RAMCORE), "ram market does not exist");
      _rammarket.modify( market, 0, [&]( auto& es ) {
          bytes_out = es.convert( quant_after_fee,  S(0,RAM) ).amount;
      });

      SEND_INLINE_ACTION( *this, notifyRAM, {from, N(active)}, {payer, receiver, bytes_out, "RAM bought"} );

    // ....
}

Looks like this problem exists in other system calls： https://github.com/EOSIO/eosio.contracts/issues/38#issuecomment-414679115


Add a regression test for #280

Releated issue: #280
JerryScript-DCO-1.0-Signed-off-by: Hanjoung Lee<EMAIL_ADDRESS>

Looks good

lgtm

Merged 3606350a48c4434c5ed64b8665f2c015d1cac5e2


[Flutter Web] Browser Compatibility Issue on JavaScript "Nullish coalescing operator (??)"

Description
In web app built by flutter, the generated JavaScript adopted "Nullish coalescing operator (??)" which is not supported by old version browser. So, it cause blank page with JavaScript error.
In generated index.html
waitForActivation(reg.installing ?? reg.waiting);

it cause the following error in chrome version less than 80.
VM119:1 Uncaught SyntaxError: Unexpected token ?

Please check the compatible browser list here:  https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Nullish_coalescing_operator#browser_compatibility
This operator only supported since Chrome version 80. But there are still lots of existing browser cannot meet this requirement.
Steps to Reproduce
flutter create sampleweb
cd sampleweb
flutter run -d chrome

Access the website with old version of chrome < version 80
Expected results:
Expect the web page rendered in browser.
Actual results:
Nothing displayed in mobile browser.
Check the browser console with developer tools and get the following error message.
VM119:1 Uncaught SyntaxError: Unexpected token ?

Environment
❯ flutter channel
Flutter channels:
  master
  dev
  beta
* stable
❯ flutter --version
Flutter 2.2.3 • channel stable • https://github.com/flutter/flutter.git
Framework • revision f4abaa0735 (8 days ago) • 2021-07-01 12:46:11 -0700
Engine • revision 241c87ad80
Tools • Dart 2.13.4

Logs

is it possible to generate JavaScript for web without "Nullish coalescing operator"? It is easy to replace it with much normal expression. The syntactic sugar is used to improve developer productivity. But it not good idea for generated language which may cause compatibility issue and reduce readability.

I manually replaced ?? with || operator and works on old chrome v76. Not sure if it can cover edge cases, but at least it works.
waitForActivation(reg.installing || reg.waiting);

check the with source code. it is same issue with #83176 and fixed in #83732. But not in stable channel yet.


Add params scene, mesh to function getAttributes

For the class MaterialPluginBase,  add params scene and mesh to the function getAttributes so that they can be used to determine which attributes to use.
Forum: https://forum.babylonjs.com/t/using-custom-attribute-with-material-plugin/31142/7

should be the mesh or submesh here ?

Petty sure it should be the mesh because that's what's passed to the PBR and StandardMaterial functions that trigger the event, not a sub mesh, and also that's what prepareDefines passes.


Prototype for outbreak phylogenetic trees

To do:

push new ecr image (already built on the test machine)
test phylo_tree run end-to-end
test sample upload end-to-end to see if pipeline/result monitors still work

Please, also wait for @yunfangjuan approvals on the backend parts of the code.

Looks pretty good to me although would've been easier to review in smaller chunks? (e.g. with dag templating re-arrangement broken off)
nit on keeping JS naming camelCase w.r.t. https://czi.quip.com/c7sGAU2bOXVX/IDSeq-Frontend-Development-Guidelines


Want proper documentation and usage examples

Any documentation of the code will be appreciated. It can be Jupyter notebooks for examples.

Fixed by PR #13


Fix binary arch issue in memcache-proxy

This whole things is pretty hacky, so I just added the workaround of least resistance:
manually building the binary again after running the build.sh script.

Could you explain what the issue is with this container?

We need to compile this with these compiler flags, which aren't the defaults used in the build.sh script. It would be sufficient to hack this in to that script, but I figure it's simpler to rebuild it after the script does its renaming, because this might break people running the script locally to put these flags directly in to the script.


Suggestion: support Bash-style brace expansions

Bash has an expressive feature called brace expansion, which elegantly supports generating "Cartesian products" to generate multiple arguments from a single expression based on token lists and ranges.
As an aside: The bash implementation is actually severely hampered by the inability to base brace-expansion expressions on variables, but the ksh and zsh implementations do support that.
Some Bash examples:
$ printf '%s\n'  a{1,2,3}  # list form
a1
a2
a3

$ printf '%s\n'  a{1..3}  # range form
a1
a2
a3

$ printf '%s\n'  {a,b}-{1..3}  # multiple expressions can be combined
a-1
a-2
a-3
b-1
b-2
b-3

Note: While the range form is reminiscent of PowerShell's .. operator, it supports additional features:
$ printf '%s\n' {a..c}.   # character ranges
a.
b.
c.

$ printf '%s\n' a{01..03}.   # padded number ranges (Bash v4+)
a01.
a02.
a03.

$ printf '%s\n' a{1..5..2}.   # number ranges with custom stepping (Bash v4+)
a1.
a3.
a5.

A potential PowerShell approach:
Emulation with PowerShell's current capabilities is somewhat cumbersome and definitely slow:
1..3 | % { "a$_" }  # Equivalent of Bash `a{1..3}`

In Bash, brace expansion is applied to unquoted (parts of) tokens on the command line, which, for reasons of backward compatibility and different {...} semantics, is not an option in PowerShell, so perhaps a new array-valued unary operator, such as -x,  is the solution:
# Wishful thinking; equivalent of Bash `a{1..3}`
-x "a", (1..3)  # -> 'a1', 'a2', 'a3'

Environment data
PowerShell Core v6.0.0-beta.4

We have a format operator -f. So maybe
"a" -x (1..3)  # -> 'a1', 'a2', 'a3'

@iSazonov:  A binary operator is too limiting in this case, which is why a suggested an array-valued unary operator:
# The equivalent of {a,b}-{1..3}
-x ('a', 'b'), '-', (1..3)  # -> 'a-1', 'a-2', 'a-3', 'b-1', 'b-2', 'b-3'

Still wanted.

Sooo, after the bot auto-adds "Resolution-No Activity", the issue basically needs to have a new comment at least once a week to prevent it from getting closed (unless someone removes the label manually)?

@StevenBucher98 @kilasuit can you reopen this, please?


Facing Microsoft.AspNetCore.Server.Kestrel.Core.BadHttpRequestException: Unexpected end of request content (Without high CPU usage/Thread starvation/network starvation for small requests)

We have been intermittently seeing issues with our Windows Docker hosted service on a Service Fabric cluster where for a fraction of the requests we start seeing this exception. Our payloads are very small (around 3 Kb at max) and the service fabric cluster sits behind an API-Management layer which doesn't show any issues. We also don't see high CPU usage/Thread starvation/Network starvation. The machines are hardly receiving 5 RPS.
I want to understand 2 things -

What could be the possible reasons for this happening in our scenario?
What is the best way to debug this issue ?

I have read other threads on this and they didn't help a lot.
Here is the callstack from the exception out of the middleware -
Microsoft.AspNetCore.Server.Kestrel.Core.BadHttpRequestException: Unexpected end of request content.\r\n   at
Microsoft.AspNetCore.Server.Kestrel.Core.BadHttpRequestException.Throw(RequestRejectionReason reason)\r\n   at
Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.Http1MessageBody.PumpAsync()\r\n   at
System.IO.Pipelines.PipeCompletion.ThrowLatchedException()\r\n   at
System.IO.Pipelines.Pipe.GetReadResult(ReadResult& result)\r\n   at
System.IO.Pipelines.Pipe.GetReadAsyncResult()\r\n   at
Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.MessageBody.ReadAsync(Memory"1 buffer, CancellationToken cancellationToken)\r\n   at
Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.HttpRequestStream.ReadAsyncInternal(Memory"1 buffer, CancellationToken cancellationToken)\r\n   at
Microsoft.AspNetCore.WebUtilities.FileBufferingReadStream.ReadAsync(Byte[] buffer, Int32 offset, Int32 count, CancellationToken cancellationToken)\r\n   at
Microsoft.AspNetCore.WebUtilities.StreamHelperExtensions.DrainAsync(Stream stream, ArrayPool"1 bytePool, Nullable"1 limit, CancellationToken cancellationToken)\r\n   at
Microsoft.AspNetCore.Mvc.Formatters.JsonInputFormatter.ReadRequestBodyAsync(InputFormatterContext context, Encoding encoding)\r\n   at
Microsoft.AspNetCore.Mvc.ModelBinding.Binders.BodyModelBinder.BindModelAsync(ModelBindingContext bindingContext)\r\n   at
Microsoft.AspNetCore.Mvc.ModelBinding.ParameterBinder.BindModelAsync(ActionContext actionContext, IModelBinder modelBinder, IValueProvider valueProvider, ParameterDescriptor parameter, ModelMetadata metadata, Object value)\r\n   at
Microsoft.AspNetCore.Mvc.Internal.ControllerBinderDelegateProvider.<>c__DisplayClass0_0.<g__Bind|0>d.MoveNext()\r\n
--- End of stack trace from previous location where exception was thrown ---\r\n   at
Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.InvokeInnerFilterAsync()\r\n   at
Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.InvokeNextResourceFilter()\r\n   at
Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.Rethrow(ResourceExecutedContext context)\r\n   at
Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)\r\n   at
Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.InvokeFilterPipelineAsync()\r\n   at
Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.InvokeAsync()\r\n   at
Microsoft.AspNetCore.Builder.RouterMiddleware.Invoke(HttpContext httpContext)\r\n   at
Microsoft.AspNetCore.Cors.Infrastructure.CorsMiddleware.Invoke(HttpContext context)\r\n   at
Microsoft.Commerce.UniversalStore.Authorization.AuthorizationRuntime.WebAPI.AuthorizationRuntimeMiddleware.Invoke(HttpContext context)\r\n   at
Microsoft.AspNetCore.Builder.Extensions.UsePathBaseMiddleware.Invoke(HttpContext context)\r\n   at
RaaS.KnowledgeGateway.Service.API.Middlewares.RequestLoggerMiddleware.Invoke(HttpContext context) in D:\Source\Repos\2-MKG.RaaS.Service.Knowledge\Knowledge\RaaS.KnowledgeGateway.Service.Container\Middlewares\RequestLoggerMiddleware.cs:line 73\r\n   at
RaaS.KnowledgeGateway.Service.API.Middlewares.RequestLoggerMiddleware.Invoke(HttpContext context) in D:\Source\Repos\2-MKG.RaaS.Service.Knowledge\Knowledge\RaaS.KnowledgeGateway.Service.Container\Middlewares\RequestLoggerMiddleware.cs:line 100\r\n   at
RaaS.KnowledgeGateway.Service.API.Middlewares.ErrorHandlerMiddleware.Invoke(HttpContext context) in D:\Source\Repos\2-MKG.RaaS.Service.Knowledge\Knowledge\RaaS.KnowledgeGateway.Service.Container\Middlewares\ErrorHandlerMiddleware.cs:line 41

@shreyagr, Is this issue resolved at your end?.

Is anyone able to provide a runnable sample and/or wireshark trace? We don't have much to go on here unfortunately.

Closing as we don't really have any data to go on here. If anyone is able to provide some more detailed information here, feel free to comment and we can reopen our investigation!


Don't freeze event dataclasses. Version bump to v0.0.42

Keeping frozen dataclasses and making the change downstream

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.22%. Comparing base (512e82e) to head (5110406).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #134   +/-   ##
=======================================
  Coverage   71.22%   71.22%
=======================================
  Files          50       50
  Lines        2318     2318
=======================================
  Hits         1651     1651
  Misses        667      667

Flag
Coverage Δ

unittests
71.22% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


show_system for AtomsBase interface

Hello. I think it would be nice to add a Base.show function similar to the way it is done in AtomsBase.
In this routine the atomic_symbols, the box, and if all boundary_conditions are the same, the boundary_conditions are showed.
Additionally, at the beginning, there is written whether the system is a FlexibleSystem or a FastSystem.
If one just creates an atomic_system in AtomsBase, there is a FlexibleSystem created.
I am not complete sure if ExtXYZ would create a system similar to a FlexibleSystem or a FastSystem?
I would like to add this function, any thoughts on this?

Happy to add this. The idea of the ExtXYZ.Atoms struct is that it is both flexible and fast, since the type information for all properties is included in the parametric type definition.

Okay so that means we would skip the part where it is showed which kind of system it is?

Yes that sounds right - I should have a look at what the text output looks like, but if you are willing to implement this I'll try it out

In AtomsBase they do this for both, FastSystem and FlexibleSystem, by using their routine show_system.
I think it is possible to do the same here.
function Base.show(io::IO, system::Atoms)
print(io, "System")
AtomsBase.show_system(io, system)
end
seems to work.
In AtomsBase the "System" in the print is "FastSystem" or "FlexibleSystem", I am not sure about the best name for it in this case.
In a case where I tried this the system was showed like this:
System(Mn₃Si, AtomsBase.Periodic, box=[[3.99986972, 0.0, 0.0], [1.9999348600000004, 3.463988789348149, 0.0], [1.9999348600000004, 1.1546629297827167, 3.2658799505363403]]u"Å")
If i am not forgetting anything important here I think it could work with this code example, depending on how to call the system.

Should the name not just be Atoms() to match the struct name?

From: Jan Habscheid @.>
Sent: Monday, September 26, 2022 5:16:28 PM
To: libAtoms/ExtXYZ.jl @.>
Cc: James Kermode @.>; Comment @.>
Subject: Re: [libAtoms/ExtXYZ.jl] show_system for AtomsBase interface (Issue #21)
In AtomsBase they do this for both, FastSystem and FlexibleSystem, by using their routine show_system.
I think it is possible to do the same here.
function Base.show(io::IO, system::Atoms)
print(io, "System")
AtomsBase.show_system(io, system)
end
seems to work.
In AtomsBase the "System" in the print is "FastSystem" or "FlexibleSystem", I am not sure about the best name for it in this case.
In a case where I tried this the system was showed like this:
System(Mn₃Si, AtomsBase.Periodic, box=[[3.99986972, 0.0, 0.0], [1.9999348600000004, 3.463988789348149, 0.0], [1.9999348600000004, 1.1546629297827167, 3.2658799505363403]]u"Å")
If i am not forgetting anything important here I think it could work with this code example, depending on how to call the system.
—
Reply to this email directly, view it on GitHubhttps://github.com/libAtoms/ExtXYZ.jl/issues/21#issuecomment-1258292166, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAIAKTBHORFZDOS5F5OI7TTWAHD5ZANCNFSM6AAAAAAQVAQSJA.
You are receiving this because you commented.Message ID: @.***>


Remove no_internal_links

Pull request information

Status: Ready to merge
Kind of changes: Cleanup
Code affected: scenario and net_params
Related PR or issue: resolves #489

Description

The no_internal_link attribute in NetParams exists only for the ring road (all other networks have junctions) and is only valid in sumo. Accordingly, this PR serves to remove it. The changes are as follows:

removed mentions of no_internal_links
added internal edge starts to loops
modified tests to match changes

Pull Request Test Coverage Report for Build 3642

34 of 34 (100.0%)  changed or added relevant lines in 16 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.0005%) to 91.288%

Totals

Change from base Build 3631:
0.0005%

Covered Lines:
8288

Relevant Lines:
9079

💛  - Coveralls

@ashkan-software can you review this? I need to merge this in to change some of the examples stuff without encountering merge conflicts later?

I can. I am just moving out of my apartment and can get back to this on Monday. Is that too late?


Space-Travelers-Hub: Mission setup

This part of the project required rendering the lists fetched from the API
This includes the following:

Fetch data from the API when a user navigates to the Missions section.
Used useSelector() Redux Hook to select the state slices and render lists of missions.
Dispatched an action to store the selected data in the Redux store.
Rendered a table with the missions' data.

Thank you🤝

Thank you for the feedback


Add onInput action

The up-to-date ember-power-select has an oninput, so it would be nice if ember-power-select-with-create would expose it as well.

Released. Thanks.


haste-map: Support extracting dynamic imports

Summary
Support import('some-module') when building up a dependency tree within jest-haste-map.

Test plan
Assertion added

Not sure if we care, but this pass:
import(`${a}-b`)

it only checks for ' and ", same as with the existing ones. We probably should support backticks as well

Very nice! Can you do a follow-up to add backtick support? Note that we only want static dependencies so we are looking for:
import(`banana`)

// But not:
import(`${apple}`);

cc @mjesun I just realized we run multiple regexes. This is run on every single file to extract deps, so could be a major factor in cold start time. What do you think would happen if we merged the regexes into a single one and call  .replace only a single time? Alternatively, @qfox built a fast parser for static deps at FB, I wonder if it's slower or faster than what we have here.

combining into a single regexp would make my (currently not pushed) haste.moduleImportPatterns simpler to implement as well. What I currently have (ish, from memory) is a Object.values(replacePatterns).concat(extraPatterns).forEach(pattern => source.replace(pattern, addDependency)). I bet that would make it even worse :P

Can you do a follow-up to add backtick support?

I'll see what I can do, my regex-fu is really weak, though.

@cpojer Yup, this should speed up stuff, because of a) only parsing once and b) making the RegExp state machine to avoid one use case when we are already in another one. I'll check later.


tanh_should_not_have_numerical_bugs_on_macos is failing on MacOS

Describe the bug
failures:

---- kernel::unary::tests::tanh_should_not_have_numerical_bugs_on_macos stdout ----
thread 'kernel::unary::tests::tanh_should_not_have_numerical_bugs_on_macos' panicked at burn-wgpu/src/kernel/unary.rs:260:9:
assertion failed: !zero.is_nan() && zero == 1.0

failures:
    kernel::unary::tests::tanh_should_not_have_numerical_bugs_on_macos

test result: FAILED. 1238 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 14.63s

error: test failed, to rerun pass `-p burn-wgpu --lib`

To Reproduce
./run-checks all
Desktop (please complete the following information):
[burn]$ uname -a
Darwin MacBook-Pro-Max.attlocal.net 23.1.0 Darwin Kernel Version 23.1.0: Mon Oct  9 21:33:00 PDT 2023; root:xnu-10002.41.9~7/RELEASE_ARM64_T6031 arm64
[burn]$

Fails for me too. It's due to @nathanielsimard 's refactoring (#1069) in which the "safe_tanh" alternative was removed

@louisfd We can reintroduce the "hack," but with the new codegen in place. I would have thought that the new Mac CI would have encountered the same error, but I suppose it might be specific to newer Macs.


Update to maki v2

This updates to use maki v2. Since maki no longer exposes individual PNGs but rather SVGs, this PR loads all SVGs into memory as mapnik images when the lib is required.
Some things I'm thinking about:

[ ] There is no longer a 1px black border around maki images.
[ ] I've had to add special offsets for maki images, it'd be nice if both maki and other images shared the same offsets

/cc @samanpwbb @yhahn

I think this is okay for now – a more robust solution that supported more than @2x and generated alphanumeric values is something we should consider.
On strokes:
You could add strokes to Maki by adding an SVG processing script as a build step that just duplicates all paths in the SVGs and adds strokes to them.
However, I would rather see us drop stokes entirely and instead include a heuristic for judging whether to use a light or a dark icon based on which color is supplied to the API, and then supply the correct icon. We would then need to refactor how alphanumeric icons are assembled.
The offset issue could also be fixed by assembling the icons as SVGs rather than as PNGs.

While you're refactoring makizushi, i would love to introduce a new design of the marker.

I forgot to mention one more maki constraint: latest maki has different icon sizes across the board now. We now include only 15px and 11px icons. The old version of maki supported 12/18/24.

Here's the marker I think we should use (there are two sizes, corresponding to -15 and -11 maki icons): https://gist.github.com/samanpwbb/30a00422e6f73e24e84f0276fb4a121a
This marker is compact, has a border so individual markers are discernable when stacked, and has a gradient shadow so it stands out on top of a busy map.


Update MQTT

Fixes the issue with make_safe not running when killed from the webUI when used with https://github.com/srobo/astoria/pull/180.
Decouples the MQTT section of Astoria from sr-robot3, the message structures are still imported from Astoria.
To avoid the issues surrounding appropriate methods to do async event loop clean up in a largely synchronous codebase, this moves to using the paho-mqtt library which uses a background thread to handle the network loop. Cleanup is then handled by an atexit handler to disconnect and close the network loop thread.
To keep it simple there is a single long running client that is created within the robot's init routine and metadata and wait_start are done by temporarily subscribing to the relevant topics. Timeouts are used on the threading Events to prevent indefinite blocking.

This actually merged @ e2cef81, github seems to have glitched.

much glitch lol


Config aware validation for acceptedResourceRoles on Resident Apps

#3673 introduced validation for acceptedResourceRoles on resident apps, which currently only validates the value set on an AppDefinition. If no acceptedResourceRoles are set, the defaultAcceptedResourceRoles are used later on, which would be invalid if the default is set to a role and a resident app inherits that setting (The implementation of #3673 logs a warning in that case and uses "*").
The validation should however include the defaultAcceptedResourceRoles and fail if no explicit value is given and the inherited value is invalid. To achieve this, we need to have config aware validators, which needs some work on the current structure and usage of validation methods/vals.

Note: This issue has been migrated to https://jira.mesosphere.com/browse/MARATHON-2506. For more information see https://groups.google.com/forum/#!topic/marathon-framework/khtvf-ifnp8.


profilesByName emitting doesn't escape strings

Howdy.
I tried adding:
[profile.release]
lto = "fat"

To my Cargo.toml, but when cargo2nix generates Cargo.nix, it emits:
   profilesByName = {
     release = builtins.fromTOML "lto = "fat"
 ";
   };

I'm unclear about the redundant new-line, but the main thing here is that the quotes inside of the TOML need escaping somehow, presumably before being passed to the template.
As a workaround, I'm able to use lto = true instead, but there are other potentially string-valued parameters that folks might want to change, for example the panic parameter.

Hey there, @philipstears! Thanks for reporting this issue, and we're sorry you encountered it.
If you check the Tera templating code for BuildPlan in src/template.rs:33, the profilesByName entry values are computed by deserializing the Cargo profile struct into TOML using toml::ser::to_string(). Unfortunately, the code wasn't rigorously tested, and it dumps the unsanitized TOML directly into a double-quoted Nix string, which causes the issues you saw. The trailing newline in the string is because toml::ser::to_string() apparently decided to insert one.
This bug should be fixable by calling .replace("${", "\${").escape_debug() on the output of toml::ser::to_string() to ensure that it's perfectly safe for the Nix expression to consume.

I've opened https://github.com/tenx-tech/cargo2nix/pull/121 with a potential fix. It should be backwards-compatible with older versions of the overlay.

Hey @ebkalderon - thank you so much!

No worries! Hope this fix solves the problem in a satisfactory way. Feel free to test locally on your machine and leave any feedback on the PR itself.


[BOT PR] to update dependencies of istio

This PR will be merged automatically once checks are successful.
none

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: istio-testing
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm
If they are not already assigned, you can assign the PR to them by writing /assign @costinm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
21bb7f19eb99c705a4d370c137412954200e7674
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
21bb7f19eb99c705a4d370c137412954200e7674
link
/test istio-unit-tests

prow/istio-pilot-multicluster-e2e.sh
21bb7f19eb99c705a4d370c137412954200e7674
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


small-code-quality-improvements

Made small code quality improvements.

That last build failure wasn't on you....just fixed it in the master branch.

@chtompki
If you want me to re-push any minor change to re-trigger the build just tell.

Well, of course!
And much, much, much more in Java!

:-)

Merged in : https://github.com/apache/commons-text/commit/5598109efb2365384b9a9110323ed9a7004cc905 Thanks!

You're welcome.


Unit and Integration Testing

Unit and Integration Tests should be done for the searching functionality (backend).

@Dindosss
Some of the tickets unit tests has been done. Please complete the remainder of the unit and integration tests for tickets.
Then all backend tests should be up to date for the time being.

Unit Testing for additional interaction with tickets have been done.


Doesn't support supported file extension

Service
OpenAI
Describe the bug
Invalid extension vb. Supported formats: "c", "cpp", "css", "csv", "docx", "gif", "go", "html", "java", "jpeg", "jpg", "js", "json", "md", "pdf", "php", "pkl", "png", "pptx", "py", "rb", "tar", "tex", "ts", "txt", "webp", "xlsx", "xml", "zip"'
.vb is a code file of Microsoft Visual Basic .NET
Steps to reproduce
Try to upload .vb file, e.g. fileClient.UploadFile("myfile.vb", FileUploadPurpose.Assistants);
Code snippets
No response
OS
Windows
.NET version
8
Library version
2.0.0

Thank you for reaching out, @dmki ! Unfortunately, this is a limitation of the underlying OpenAI REST API and not an issue with the .NET library. If you would like to do so, you can submit a feature request for the underlying OpenAI REST API on the Developer Community website here:
🔗 https://community.openai.com/c/api


Invoke-TmfAccessPackageCatalog does not create resources

When using Invoke-TmfAccessPackageCatalog results in no resources getting created. This appears to be due to lines 27 and 30 in that function using the  Test-TmfAccessPackage function instead of  Test-TmfAccessPackageCatalog.
This is to address issue #7

I'm working on it. :)

@johannesvwgs  I have the fixes present, happy to submit the PR

@salty2011 Thanks for your PR! I already merged in on our side. Fix is now in the v1.4 branch. Build for the preview version currently running.
Feel free to create pull requests to the prepare-release branches in the future!


[Bug]: Bank Channel names have the suffix "placeholder"

Description
When you add a bank channel to your list of channels, it is added with the suffix "placeholder". For instance COOP Bank as a channel would be added as "COOP Bank placeholder"
Steps to reproduce

Open Stax app
On Home Screen tap the Add an account button
Select any channel that is a bank e.g COOP Bank, Equity or Bank of Africa
Tap continue to add it.

Expected result
That the channel is added with the same title that the user select in the channel list.
Actual result
The channel is added with the the suffix "placeholder" and this naming is consistent across most if not all the screens.
Link to screenshots/screen recordings
https://drive.google.com/drive/folders/1dqPe12hlO9dSE9kcFtrd7455wkp-gliw
Device name
Samsung M31s
Android OS
12
Is your phone dual SIM or single SIM?
Dual SIM
Which telco are you using for this test?
Safaricom
Stax device ID or email address
<EMAIL_ADDRESS>

This is now fixed.


Create Inventory.py

inventory management system made using python

The Basic Inventory Management System is a simple console-based application designed to help small businesses or individual users manage their inventory. The system allows users to add, update, delete, and view inventory items efficiently, providing a streamlined process for managing stock levels and item information. The system is intended to be user-friendly and requires no prior experience in inventory management.


x86_64 binary in swig-4.1.1-py2.py3-none-macosx_11_0_arm64.whl

Installing swig using pip on an ARM mac-mini seems to install an x86_64 binary, which fails at runtime.
My system is:
% uname -a
Darwin mac-mini 22.6.0 Darwin Kernel Version 22.6.0: Wed Jul  5 22:22:52 PDT 2023; root:xnu-8796.141.3~6/RELEASE_ARM64_T8103 arm64
%

Here's a reproducer:
% python3 -m venv pylocal
% . pylocal/bin/activate
(pylocal) % python -m pip install --upgrade pip
Requirement already satisfied: pip in ./pylocal/lib/python3.9/site-packages (21.2.4)
Collecting pip
  Using cached pip-23.2.1-py3-none-any.whl (2.1 MB)
Installing collected packages: pip
  Attempting uninstall: pip
    Found existing installation: pip 21.2.4
    Uninstalling pip-21.2.4:
      Successfully uninstalled pip-21.2.4
Successfully installed pip-23.2.1
(pylocal) % pip install swig
Collecting swig
  Using cached swig-4.1.1-py2.py3-none-macosx_11_0_arm64.whl (1.7 MB)
Installing collected packages: swig
Successfully installed swig-4.1.1
(pylocal) % swig --version
Traceback (most recent call last):
  File "/Users/jules/artifex-remote/pylocal/bin/swig", line 8, in <module>
    sys.exit(swig())
  File "/Users/jules/artifex-remote/pylocal/lib/python3.9/site-packages/swig/__init__.py", line 24, in swig
    raise SystemExit(_program("swig", sys.argv[1:]))
  File "/Users/jules/artifex-remote/pylocal/lib/python3.9/site-packages/swig/__init__.py", line 20, in _program
    return subprocess.call([os.path.join(BIN_DIR, name)] + args, env=SWIG_LIB_ENV)
  File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/subprocess.py", line 349, in call
    with Popen(*popenargs, **kwargs) as p:
  File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/subprocess.py", line 951, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/subprocess.py", line 1821, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
OSError: [Errno 86] Bad CPU type in executable: '/Users/jules/artifex-remote/pylocal/lib/python3.9/site-packages/swig/data/bin/swig'
(pylocal) %
(pylocal) % file /Users/jules/artifex-remote/pylocal/lib/python3.9/site-packages/swig/data/bin/swig
/Users/jules/artifex-remote/pylocal/lib/python3.9/site-packages/swig/data/bin/swig: Mach-O 64-bit executable x86_64
(pylocal) %

The same thing happens with pip install -vv --force-reinstall --no-cache-dir swig.
This can also be seen by looking at swig/data/bin/swig in: https://files.pythonhosted.org/packages/56/2e/094303ec29243111a81b26bb91d0d2692db05159451416490acc8b33fca1/swig-4.1.1-py2.py3-none-macosx_11_0_arm64.whl
Thanks in advance for any help.

Looks like things can be made to work by installing Rosetta with:
softwareupdate --install-rosetta --agree-to-license

Thanks for the report and the Rosetta workaround. It's interesting that the compiled swig binary doesn't have an arm64 segment -- I'm kind of wondering if it's an issue with the cibuildwheel or the macOS GitHub Actions runner environment. There is a public beta of GitHub hosted Apple Silicon runners on the GitHub roadmap listed for this Oct-Dec (https://github.com/github/roadmap/issues/528), which could address the issues building native arm64 wheels for macOS.

The underlying issue (CMAKE_OSX_ARCHITECTURES not getting propagated to the swig and pcre builds) has been fixed in #99. I'll make an updated 4.1.1 release with the updated swig binaries for macOS.

4.1.1.post0 has been uploaded to PyPI -- no change to the version of swig, but now the universal2 and arm64 wheels for macOS actually have arm64 architectures in them instead of just x86_64. Hopefully that means installing Rosetta is no longer needed.


Maximum Circular Subarray Sum

Solving Issue #217
Added necessary code in cpp.
Checklist

[x] ✅ My code follows the code style of this project.
[ ] 📝 My change requires a change to the documentation.
[x] 🎀 I have updated the documentation accordingly.
[x] 👀 I have read the CONTRIBUTING document.
[ ] ✨ I have added tests to cover my changes.
[x] 🚩 All new and existing tests passed.
[x] 🌟 ed the repo

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Output Screenshots

I see you haven't descibed your issue yet as stated by @miraj0507  look here

Hey @Gaurika-Gupta you need to follow particular guidelines for your README , please follow
these guidelines click here
also you can see how your README should look like see here
for more please go through these here

Closing this pr!


Crash when Coin library is used

When Coin is found the GUI crashes during the spashscreen, because FUI is initialized here, and then FdDB is asked to intialized also here.
Unfortunately, Fui::getMainWindow() cannot be called until Fui::start() is called at https://github.com/SAP/fedem-gui/blob/main/src/vpm_main.C#L244
Thus a NULL is passed to SoQt::init(), so the program crashes.

I can't reproduce this crash on my system (Windows, with Visual Studio 2019), but I could verify that a NULL pointer is passed to SoQt::init() like you said. Maybe you are using a different (newer) version of the SoQt library, @sanguinariojoe ? Anyway, I tried a fix (see top commit on the PR #18), where the creation of the mainWindow object is moved to Fui::init() instead. It works well for me, but it would be great if you could verify that it fixes the crash on your side as well, before this is merged. Thanks!

It is not NULL anymore. It is still crashing to me though. I will further investigate and let you now. But I will say your commit fixed the issue


Getting false positives for 'Alt' key.

We have a piece of software that tries to listen to certain key combinations. When we use the 'Alt' key in version 5.x, it sometimes gets stuck in the 'pressed' state and stay that way until we manually press it again. This issue didn't happen with version 4.2.x.
        private void OnKeyPressed(object? sender, KeyboardHookEventArgs args)
        {
            // [...]
            if ((args.RawEvent.Mask & ModifierMask.Alt) > 0)
            {
                // this gets here even when alt is not pressed down.
            }

Our full implementation of the class is here.
I have tried to comment out pieces of code to get to the bare minimum and the false positives appear to stay there. Then when I 'spam' the alt key to kind of unstick it, keybinds work as expected.

Hi! Thanks for posting this issue! Could you please provide a little more info? I need to know which OS it is, for example. Also, it would be great if you shared libuiohook debug logs so that I can get a better idea of what's going on in libuiohook when you use the global hook (I'm almost sure it's a problem in libuiohook itself).

Unrelated thing, but I've noticed that you're suppressing the event inside the event handler. This doesn't work with TaskPoolGlobalHook since event suppression must be synchronous, i.e. on the same thread as the event handler of libuihook. You should instead use SimpleGlobalHook - it runs its event handlers on the same thread, but make sure that the event handler doesn't run for a long time, or the OS won't like it (I see that the event handler is short, so it should be OK). Also, if your app is cross-platform, then bear in mind that event suppression works only on Windows and macOS.

Thanks for taking the time to look into this. I will get you the logs when I next see the problem.
We are currently only supporting Windows. We had a goal of cross platform at some point, but that goal keeps moving as we always struggle to find cross platform solutions.

Log implementation
I implemented the logging as you described. The minimum level is debug as anything less would give no log information. I had to adjust the number of functions that were written to logs. Let me know if some of these functions are necessary for you to debug. The relevant pieces of the implementation are as follows:
            // Configure hook logging
            LogSource = LogSource.Register(minLevel: SharpHook.Native.LogLevel.Debug);
            LogSource.MessageLogged += OnMessageLogged;

        private Regex IgnoreHookLogs = new Regex("(?:dispatch_mouse_move|hook_get_multi_click_time|dispatch_event|win_hook_event_proc|dispatch_mouse_wheel|dispatch_button_press|dispatch_button_release)", RegexOptions.Compiled);

        private void OnMessageLogged(object? sender, LogEventArgs e)
        {
            if (IgnoreHookLogs.IsMatch(e.LogEntry.Function))
            {
                return;
            }

            switch (e.LogEntry.Level)
            {
                case SharpHook.Native.LogLevel.Debug:
                    logger.LogDebug("[KeyboardHook] {0}", e.LogEntry.FullText);
                    break;

                case SharpHook.Native.LogLevel.Info:
                    logger.LogInformation("[KeyboardHook] {0}", e.LogEntry.FullText);
                    break;

                case SharpHook.Native.LogLevel.Warn:
                    logger.LogWarning("[KeyboardHook] {0}", e.LogEntry.FullText);
                    break;

                case SharpHook.Native.LogLevel.Error:
                    logger.LogError("[KeyboardHook] {0}", e.LogEntry.FullText);
                    break;
            }
        }

Working keybind (F6)
In the game, press F6 to open a window.
2023-08-29 17:41:29.379 -04:00 [DBG] [KeyboardHook] dispatch_key_press [165]: Key 0X75 pressed. (0X75)
2023-08-29 17:41:29.382 -04:00 [DBG] [Keyboard] Received key pressed event F6.
2023-08-29 17:41:29.382 -04:00 [DBG] [Keyboard] Executing keybind handler for F6.
2023-08-29 17:41:29.382 -04:00 [DBG] [KeyboardHook] keyboard_hook_event_proc [117]: Consuming the current event. (-1)
2023-08-29 17:41:29.447 -04:00 [DBG] [KeyboardHook] dispatch_key_release [237]: Key 0X75 released. (0X75)
2023-08-29 17:41:29.587 -04:00 [DBG] [Keyboard] Completed Keybind Handler for F6.
2023-08-29 17:41:29.719 -04:00 [DBG] Adding entry for "5597b493-f106-4955-8b0a-7bd9c97f84a2"/MudBlazor.MudPopoverProvider. 1 total observers after add.
2023-08-29 17:41:29.719 -04:00 [DBG] Updating entry for "5597b493-f106-4955-8b0a-7bd9c97f84a2"/MudBlazor.MudPopoverProvider. 1 total observers.
2023-08-29 17:41:29.932 -04:00 [DBG] Adding entry for MudBlazor.BrowserViewportSubscription/MudBlazor.MudDrawer. 1 total observers after add.

What triggers the modifier key to stay 'pressed'
In Visual Studio or any text editor, I press Alt+Down.
2023-08-29 17:41:39.751 -04:00 [DBG] [KeyboardHook] dispatch_key_press [165]: Key 0XA012 pressed. (0XA4)
2023-08-29 17:41:39.752 -04:00 [DBG] [KeyboardHook] keycode_to_unicode [590]: Using keyboard layout 0X0000000004091009.
2023-08-29 17:41:40.017 -04:00 [DBG] [KeyboardHook] dispatch_key_press [165]: Key 0X28 pressed. (0X28)
2023-08-29 17:41:40.018 -04:00 [DBG] [Keyboard] Received key pressed event Alt+Down.
2023-08-29 17:41:40.018 -04:00 [DBG] [KeyboardHook] keycode_to_unicode [590]: Using keyboard layout 0X0000000004091009.
2023-08-29 17:41:40.091 -04:00 [DBG] [KeyboardHook] dispatch_key_release [237]: Key 0X28 released. (0X28)
2023-08-29 17:41:40.194 -04:00 [DBG] [KeyboardHook] dispatch_key_release [237]: Key 0XA012 released. (0XA4)

Log of the failing keybind. We now receive Alt+F6 instead of only F6
In the game, press F6 to open a window. No window opens as it detects Alt+F6
2023-08-29 17:41:44.042 -04:00 [DBG] [KeyboardHook] dispatch_key_press [165]: Key 0X75 pressed. (0X75)
2023-08-29 17:41:44.043 -04:00 [DBG] [Keyboard] Received key pressed event Alt+F6.
2023-08-29 17:41:44.043 -04:00 [DBG] [KeyboardHook] keycode_to_unicode [590]: Using keyboard layout 0X0000000004091009.
2023-08-29 17:41:44.125 -04:00 [DBG] [KeyboardHook] dispatch_key_release [237]: Key 0X75 released. (0X75)

Full Logs
2023-08-29 17:41:18.412 -04:00 [DBG] Adding entry for "4efb3cd4-0490-4286-b196-fffffe0e856e"/MudBlazor.MudPopoverProvider. 1 total observers after add.
2023-08-29 17:41:18.424 -04:00 [DBG] Updating entry for "4efb3cd4-0490-4286-b196-fffffe0e856e"/MudBlazor.MudPopoverProvider. 1 total observers.
2023-08-29 17:41:18.537 -04:00 [INF] [Initiazation] Initializing Sidekick.Common.Localization.UILanguageProvider
2023-08-29 17:41:18.641 -04:00 [INF] [Initiazation] Initializing Sidekick.Common.Game.Languages.GameLanguageProvider
2023-08-29 17:41:18.755 -04:00 [INF] [Initiazation] Initializing Sidekick.Common.Platform.Windows.Processes.ProcessProvider
2023-08-29 17:41:18.858 -04:00 [INF] [Initiazation] Initializing Sidekick.Common.Platform.Keyboards.KeyboardProvider
2023-08-29 17:41:18.890 -04:00 [DBG] [KeyboardHook] hook_set_dispatch_proc [41]: Setting new dispatch callback to 0X00007FF7D4543DA4.
2023-08-29 17:41:18.896 -04:00 [DBG] [KeyboardHook] hook_run [413]: SetWindowsHookEx() successful.
2023-08-29 17:41:18.896 -04:00 [DBG] [KeyboardHook] refresh_locale_list [369]: GetKeyboardLayoutList(0, NULL) found 3 layouts.
2023-08-29 17:41:18.896 -04:00 [DBG] [KeyboardHook] refresh_locale_list [384]: Received 3 locales.
2023-08-29 17:41:18.896 -04:00 [DBG] [KeyboardHook] get_keyboard_layout_file [325]: Found keyboard layout "00000409".
2023-08-29 17:41:18.896 -04:00 [DBG] [KeyboardHook] refresh_locale_list [458]: Loading layout for 0X0000000004091009: KBDUS.DLL.
2023-08-29 17:41:18.897 -04:00 [DBG] [KeyboardHook] get_keyboard_layout_file [325]: Found keyboard layout "00000409".
2023-08-29 17:41:18.897 -04:00 [DBG] [KeyboardHook] refresh_locale_list [458]: Loading layout for 0X0000000004090409: KBDUS.DLL.
2023-08-29 17:41:18.897 -04:00 [DBG] [KeyboardHook] get_keyboard_layout_file [325]: Found keyboard layout "00001009".
2023-08-29 17:41:18.897 -04:00 [DBG] [KeyboardHook] refresh_locale_list [458]: Loading layout for 0X0000000010090C0C: KBDCA.DLL.
2023-08-29 17:41:18.898 -04:00 [DBG] [KeyboardHook] dispatch_key_release [237]: Key 0XA011 released. (0XA2)
2023-08-29 17:41:18.899 -04:00 [DBG] [KeyboardHook] load_input_helper [623]: refresh_locale_list() found 3 locale(s).
2023-08-29 17:41:18.982 -04:00 [INF] [Initiazation] Initializing Sidekick.Apis.Poe.Parser.Patterns.ParserPatterns
2023-08-29 17:41:19.088 -04:00 [INF] [Initiazation] Initializing Sidekick.Apis.Poe.Metadatas.ItemMetadataProvider
2023-08-29 17:41:19.219 -04:00 [INF] [Initiazation] Initializing Sidekick.Apis.Poe.Static.ItemStaticDataProvider
2023-08-29 17:41:19.328 -04:00 [INF] [Initiazation] Initializing Sidekick.Apis.Poe.Modifiers.EnglishModifierProvider
2023-08-29 17:41:19.457 -04:00 [INF] [Initiazation] Initializing Sidekick.Apis.Poe.Modifiers.ModifierProvider
2023-08-29 17:41:19.782 -04:00 [INF] [Initiazation] Initializing Sidekick.Apis.Poe.Pseudo.PseudoModifierProvider
2023-08-29 17:41:19.783 -04:00 [INF] Pseudo stat service initialization started.
2023-08-29 17:41:19.837 -04:00 [INF] 13 attributes fetched.
2023-08-29 17:41:20.037 -04:00 [INF] [Initiazation] Initializing Sidekick.Apis.PoeNinja.PoeNinjaClient
2023-08-29 17:41:20.138 -04:00 [INF] [Initiazation] Initializing Sidekick.Apis.PoeWiki.PoeWikiDataProvider
2023-08-29 17:41:24.498 -04:00 [ERR] Unable to find view https://<IP_ADDRESS>/
2023-08-29 17:41:29.379 -04:00 [DBG] [KeyboardHook] dispatch_key_press [165]: Key 0X75 pressed. (0X75)
2023-08-29 17:41:29.382 -04:00 [DBG] [Keyboard] Received key pressed event F6.
2023-08-29 17:41:29.382 -04:00 [DBG] [Keyboard] Executing keybind handler for F6.
2023-08-29 17:41:29.382 -04:00 [DBG] [KeyboardHook] keyboard_hook_event_proc [117]: Consuming the current event. (-1)
2023-08-29 17:41:29.447 -04:00 [DBG] [KeyboardHook] dispatch_key_release [237]: Key 0X75 released. (0X75)
2023-08-29 17:41:29.587 -04:00 [DBG] [Keyboard] Completed Keybind Handler for F6.
2023-08-29 17:41:29.719 -04:00 [DBG] Adding entry for "5597b493-f106-4955-8b0a-7bd9c97f84a2"/MudBlazor.MudPopoverProvider. 1 total observers after add.
2023-08-29 17:41:29.719 -04:00 [DBG] Updating entry for "5597b493-f106-4955-8b0a-7bd9c97f84a2"/MudBlazor.MudPopoverProvider. 1 total observers.
2023-08-29 17:41:29.932 -04:00 [DBG] Adding entry for MudBlazor.BrowserViewportSubscription/MudBlazor.MudDrawer. 1 total observers after add.
2023-08-29 17:41:39.751 -04:00 [DBG] [KeyboardHook] dispatch_key_press [165]: Key 0XA012 pressed. (0XA4)
2023-08-29 17:41:39.752 -04:00 [DBG] [KeyboardHook] keycode_to_unicode [590]: Using keyboard layout 0X0000000004091009.
2023-08-29 17:41:40.017 -04:00 [DBG] [KeyboardHook] dispatch_key_press [165]: Key 0X28 pressed. (0X28)
2023-08-29 17:41:40.018 -04:00 [DBG] [Keyboard] Received key pressed event Alt+Down.
2023-08-29 17:41:40.018 -04:00 [DBG] [KeyboardHook] keycode_to_unicode [590]: Using keyboard layout 0X0000000004091009.
2023-08-29 17:41:40.091 -04:00 [DBG] [KeyboardHook] dispatch_key_release [237]: Key 0X28 released. (0X28)
2023-08-29 17:41:40.194 -04:00 [DBG] [KeyboardHook] dispatch_key_release [237]: Key 0XA012 released. (0XA4)
2023-08-29 17:41:44.042 -04:00 [DBG] [KeyboardHook] dispatch_key_press [165]: Key 0X75 pressed. (0X75)
2023-08-29 17:41:44.043 -04:00 [DBG] [Keyboard] Received key pressed event Alt+F6.
2023-08-29 17:41:44.043 -04:00 [DBG] [KeyboardHook] keycode_to_unicode [590]: Using keyboard layout 0X0000000004091009.
2023-08-29 17:41:44.125 -04:00 [DBG] [KeyboardHook] dispatch_key_release [237]: Key 0X75 released. (0X75)

Also of note, I have seen other cases with other modifier keys such as Shift and Ctrl. I have a harder time making the handler fail as consistently as with the Alt key.

It appears that this issue is caused by libuiohook not receiving key up events (as described in issue #61). On Windows libuiohook manages the modifier mask by itself, simply adding/removing current modifiers on key down/up events. This is why if it doesn't receive the key up event for Alt, it will think that it's still pressed and will add it to the modifier masks of future events.
I could reproduce this issue (typing really fast and seeing that keys sometimes remained in the pressed state), but I don't know why that happens and how to fix that. Googling doesn't help either. I think this is a problem with Windows itself, but not sure.
So, I don't really know what to do about this issue. I'll try googling some more and trying to debug it further, but no promises about the result.

Thanks for looking into this.
I mentioned it in the initial post, but this issue doesn't happen with version 4. It started appearing with version 5. We can keep using version 4 for now with no issue.
I understand this kind of issue is awkward to debug and resolve, but maybe there is something between the versions that changed this mechanism?
Love the library, makes keybinds so much easier.

Right, I totally forgot you said that it worked with version 4. I will look at the diff between libuiohook used in version 4 and 5 and see whether I can find anything.

Can confirm this bug on Windows 11!

Hi @leMicin @TigerHix! I may have fixed the issue in the latest build of SharpHook - it's hard to know since the issue itself is hard to reproduce. Could you please download the latest libuiohook binary and replace it directly in the bin folder of your application to verify that it works for you? If the issue is indeed fixed, then I'll release version 5.1.0 soon (hopefully).
You can get the latest libuiohook binary from the latest GitHub Actions artifact. Download libuiohook-build and inside it windows//bin/uiohook.dll is the file you need.

I've come across the same issue with the Ctrl key, just as described by @leMicin (I'm a SharpHook newbie).
What I have found is that if you put a breakpoint on the KeyTyped event, then the Mask sticks until you press the key again (I've tried the uiohook.dll from 1/10/23 as well).
Without the breakpoint it seems to work fine.
public partial class MainPage : ContentPage
{
	private void _hook_KeyTyped(object sender, KeyboardHookEventArgs e)
	{
		if (e.Data.KeyCode == KeyCode.VcV &&
			(e.RawEvent.Mask & ModifierMask.Ctrl) != ModifierMask.None)
		{
			// TODO
		}
	}

	private readonly TaskPoolGlobalHook _hook;
	public MainPage()
	{
		InitializeComponent();

		_hook = new TaskPoolGlobalHook();
		_hook.KeyTyped += _hook_KeyTyped;

		Task.Run(async () =>
		{
			await _hook.RunAsync();
		});
	}

	protected override void OnDisappearing()
	{
		base.OnDisappearing();
		_hook.Dispose();
	}
}

Hi @Herdubreid! This is expected behavior actually. If you pause on a breakpoint, then the global hook won't be able to process events (as all threads are stopped) and so when you release the Ctrl key it doesn't know about it, and so the Ctrl mask stays. Not much I can do about it unfortunately, this is just the way Windows handles global hooks.

This makes sense @TolikPylypchuk and not a problem as long as you're aware of it.
Great work by the way!

I released version 5.1.0 today which should contain the fix for this issue (at least it's not reproducible for me anymore), so this issue can be closed. If it doesn't fix the issue after all, then we can reopen this issue.

@TolikPylypchuk Hi, thanks for checking this out! I couldn't check earlier but I just updated and tried this scenario again. Everything appears to be working now! I am glad you figured it out.
Thank you!


Update Composer dependencies (2019-04-15-00-01)

Loading composer repositories with package information
Updating dependencies
Writing lock file
Generating optimized autoload files
> DrupalProject\composer\ScriptHandler::createRequiredFiles

Visual regression test passed!
View the visual regression test report


cannot compute loss

Hi, can you please update the rquirement.txt file with the correct versions required for the Bert summarisation code. I  am getting a name error with flattened loss in the summary loss function.I suppose this is because of the version mismatch.

I've added this notebook which should help you use Bert for summarisation since the bertextabs one is fairly out of date https://github.com/CurationCorp/curation-corpus/blob/master/examples/hf_encdec/encdec.ipynb

thanks


Fix typo in set-up instructions of git merge driver

There are two files: .gitattributes and .gitconfig, not to be confused :)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.25%. Comparing base (ba76361) to head (4f629b7).
Report is 8 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #527      +/-   ##
============================================
- Coverage     82.70%   82.25%   -0.46%
+ Complexity      363      357       -6
============================================
  Files            43       43
  Lines          1769     1724      -45
  Branches        303      303
============================================
- Hits           1463     1418      -45
+ Misses          180      179       -1
- Partials        126      127       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Notebook: Alt-Enter should move keyboard focus to newly created cell

create a new gh issues nb
place keyboard focus in cell 1
Alt+Enter
=> keyboard focus should be in cell 2

Already fixed.


⚠ Bofrost.es has degraded performance

In 29d2d29, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1640 ms

Resolved: Bofrost.es performance has improved in f09f014 after 6 minutes.


How can I alter tab using chrome headless?

     :wallaby, "~> 0.19.2"       :elixir, "~> 1.6.0"

Hey @josuehenrique. Can you provide more information about what you're trying to achieve here?

I'm going to go ahead and close this for now. If you want to re-open with more information please do.


5GHz Wifi doesnt work on Linksys WRT1200AC

Cant get the 5GHz Network running. 2,4 GHz works fine.

Problem doesn´t disappear with a fixed channel (e.g. channel 56)

I will post the issue now in OpenWRT forum. Thanks for your help.


HashedElGamalCiphertext implementation issues.

ContestData not exactly correct specification.

String hashing (See Issue #377)

Create general form that can be used for CAVE encrypted  "ballotData".
"Add extra_ballot_data, much like extra_contest_data, for the sake of adding encrypted ballot identifier. John to add a decryption function for the extra_ballot_data."


Update kind-of to ^6.0.3 and jQuery to ^3.5.0 to resolve security vulns

Description
Updates kind-of (not used directly, but by dependencies) to ^6.0.3 and jQuery to ^3.5.0 to resolve security vulnerabilities. Refreshed package-lock.json.
Notes
All dependencies updated minimist to at least ^1.2.5, and eslint-scope to at least 3.7.1, obviating the need for a dependency resolution entry.
extract-text-webpack-plugin was removed since it is no longer in use.
Tests

Webpack builds succeed
Smoke testing the website revealed nothing different.
Deployed to sandbox environment, no differences detected.

I could try - it's only used in three components. I'll take a stab at it and see what happens :)

Looking at it more closely, I think that's best saved for another PR since it would affect some critical functionality (e.g. login). But I'll put up a ticket for it.


Update p4v to version 2017.1

This updates the p4v cask to the latest version and adds all the tools that come from the dmg (p4v, p4merge, p4admin).
After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} reports no offenses.
[x] The commit message includes the cask’s name and version.

Thank you for your contribution.


Android Studio Preview not working

Hi Florent,
Firstly, thank so much for awesome work, I really love it.
I checkout project then try to run on my own but there's something not correct
Here is design mode:

In activity:

Image preview and set text seems not working. Can you help me to find out what going not correct ?
Thanks :)

Hi, sometimes the preview don't do the work the first time, click on the refresh button, it should work :)

It would be worth adding a (large?) note to the README and/or Wiki because I had this problem and had almost given up on the library before seeing this issue.


Allow setting Azure Key Vault API version in ClientOptions for Secrets, Keys and Certificates

Feature Request

When a new client version is released because support is added to a new Azure Key Vault API version (like in case of the recently added 7.5 API support), the default API version is always the latest.
Since setting API Version is not possible, I am not able to continue using the 7.4 API if I want to.
I have tried setting the APi version like this:
httpClient := prepareClient()
cred, _ := azidentity.NewDefaultAzureCredential(nil) // Will use Managed Identity via the Assumed Identity container
client, _ := azcertificates.NewClient("https://localhost:8443",
	cred,
	&azcertificates.ClientOptions{ClientOptions: struct {
		APIVersion       string
		Cloud            cloud.Configuration
		Logging          policy.LogOptions
		Retry            policy.RetryOptions
		Telemetry        policy.TelemetryOptions
		TracingProvider  tracing.Provider
		Transport        policy.Transporter
		PerCallPolicies  []policy.Policy
		PerRetryPolicies []policy.Policy
	}{APIVersion: "7.4", Transport: &httpClient}, DisableChallengeResourceVerification: true})

Which generated this error:
failed to get the secret: this client doesn't support overriding its API version

Assuming, that this is the intended way to set the API version, could you please add support to API version overrides?
I can understand if it can be only set to certain values ("7.2", "7.3", "7.4", "7.5", etc.), but it would help me reduce the number of times my build breaks if I had a way to set the API version to not use latest.
Would this be possible?
Thank you in advance!

Hi @nagyesta! With each release we generate from a specific service version. Could you use an older version of the SDK? For example, if you need to use service version 7.4 you can use v1.0.0 of the SDK.
Is there a particular reason why you need this feature? There shouldn't be any breaking changes between minor version releases of the SDK.

Hi @gracewilcox ,
thank you for looking into this and thank you for the additional details!
I realize, that my case might be fairly uncommon and I should have shared more context to make it more compelling. Sorry for not doing so in my initial post!
I need this feature, because I am the developer of an Azure Key Vault test double. As part of this effort, I am providing example code, just like the snippet I have shared above, to let our users (i.e., people who are using both Azure Key Vault, your SDK and my test double) see how they need to configure their tests when the test double is used.
As a result, I must consider their reasons too and let them use the latest SDK versions when possible, so that they can benefit from all the great features and improvements you are including in these SDKs. I assume the list would contain the following items:

Security - Being able to use the latest SDK and relevant dependencies is a fair requirement when we are talking about a security solution like Azure Key Vault.
New features - As soon as your new SDK contains a new feature which people want to use, they will be keen to upgrade. I know this would generate work for me as well, but at least their build would not be broken right away, while I am working on the update.
Using a non-bleeding edge API version in production - According to the currently available, official REST documentation, the API version is 7.4 everywhere, so it might be a natural expectation that people might want to set it as a fixed version when configuring their clients, so that there are no surprises when the SDK is updated.

Since the test doubles are always one step behind the official API changes, whenever the new API version is released (or in the Go SDKs case being prepared) and the API version parameter changes, the test double needs to be updated to support the requests which are sent to the new API. While this is not done, the people using the SDK might need to make a choice to either use the latest SDK version to benefit from the items above, OR test their code using their existing pipeline. This is not a great trade-off to make in my opinion.
With that in mind, I have started to look for a way to override the API version similarly to the way the other official SDKs support it (.Net, Java, Python, NodeJS) and I have found this option:
https://github.com/Azure/azure-sdk-for-go/blob/main/sdk/azcore/policy/policy.go#L35-L37
As I have read the comment, I assumed, that the intention is in fact to allow overriding the version, but as soon as I have attempted it, I have received the error I mentioned in the ticket. With this, I assumed that it must be an unintended limitation or bug as only the Go SDK is behaving like this, the others allow setting it to the known service version without issues.
What do you think? Would it make sense to support the API version override considering these?
Thank you again for your efforts!

Hi nagyesta! Sorry for the late response, we've discussed this new feature as a team and decided to add it for Key Vault. We're discussing where to fit the work in in the next semester planning.

Hi @gracewilcox ,
thank you! That is great news!


No map layer showing on Pixel 6a

I couldn't get the map to show on a new Google Pixel 6a. The app loads but the map shows as a grid and never loads.
Interesting to note that the versions for the OSM Viewer and OSM Droid are both unknown.
I decided to download and debug the app on my phone, to see if I could help find what the issue could be.
For some unknown reason the map loads when installed from src on Android Studio.

Just an idea. The app was compiled/released under API level 30. Maybe the new phones can be picky on the API level. Maybe just recompiling the app under higher API level and releasing the version even for the same codebase can fix the issue.


[SPARK-28560] [1] collect the runtime statistics of row count in map stage

What changes were proposed in this pull request?
Similar with the approach of collecting data size, this PR collect the row count info when shuffle write and wrap it in MapStatus, then driver can get the row count info from the returned MapStatus.

Why are the changes needed?
In order to optimize the skewed partition, we need collect the row count statistics in map stage.

Does this PR introduce any user-facing change?
No

How was this patch tested?
unit tests

@cloud-fan This is the first PR of optimizing skewed partition. Please help me review. Thanks.

Test build #112889 has started for PR 26309 at commit 511481d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17813/
Test PASSed.

Test build #112889 has finished for PR 26309 at commit 511481d.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class MapInfo

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112889/
Test FAILed.

Test build #112893 has started for PR 26309 at commit ba283d1.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17818/
Test PASSed.

Test build #112893 has finished for PR 26309 at commit ba283d1.

This patch fails build dependency tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112893/
Test FAILed.

Test build #112904 has started for PR 26309 at commit 0032448.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17829/
Test PASSed.

Test build #112904 has finished for PR 26309 at commit 0032448.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112904/
Test FAILed.

Test build #112980 has started for PR 26309 at commit b43e693.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17903/
Test PASSed.

Test build #112980 has finished for PR 26309 at commit b43e693.

This patch fails build dependency tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112980/
Test FAILed.

retest this please

Test build #112999 has started for PR 26309 at commit b43e693.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17922/
Test PASSed.

Test build #112999 has finished for PR 26309 at commit b43e693.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112999/
Test FAILed.

@cloud-fan please help retest again. The error may be not related. Thanks.

@cloud-fan please help retest again. Thanks.

retest this please

Test build #113086 has started for PR 26309 at commit b43e693.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18003/
Test PASSed.

Test build #113086 has finished for PR 26309 at commit b43e693.

This patch fails build dependency tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113086/
Test FAILed.

Retest this please

BTW, @JkSelf . The component name depends on the code you touched. This PR touches core module only.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18614/
Test PASSed.

Test build #113736 has started for PR 26309 at commit b43e693.

Test build #113736 has finished for PR 26309 at commit b43e693.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113736/
Test PASSed.