Add panic propagation

Resolves #36 by making it so, when the std feature is enabled, panics are caught and then propagated when the Task is polled. This generally makes more sense than whatever thread polling the Runnable panicking.
I had to adjust some tests which seemed to assume that the Runnable panics rather than the Task, I'm not sure whether this is an intended feature I'm overwriting or not.

Hmm... It is a bit annoying that it works differently with and without the feature flags.
I think it would be possible to use the builder to allow users to explicitly opt-in to this behavior, but given that the current behavior is somewhat odd, I'm not clear that that is a good idea.

I think it would be possible to use the builder to allow users to explicitly opt-in to this behavior, but given that the current behavior is somewhat odd, I'm not clear that that is a good idea.

Good idea, just to make sure no one is surprised by the new behavior. I've rebased on master and made panic propagation a thing that can be set in the builder.


Scattering not working as it's supposed to

Description of the bug
goleft_indexsplit makes more regions than it's supposed to when the reference contains more contigs than the scatter count => possible fix is to return to bed files to determine the regions and merge all alt contigs into one bed file and make bed files per all other regions
Command used and terminal output
No response
Relevant files
No response
System information
No response

Fixed in v1.1.1


upgrade Show component - added prop checkObjectValues

First of all - this PR is open for discussion
Before adding changes, documentation, etc. I just wanted to get some feedback if this has a chance to be merged.
-- no breaking change --
Show will just behave as before when checkObjectValues is not set / true.
Motivation: e.g.From Discord
Setting it to true will allow narrow the type of all values to NonNullable.
Imagine this case where you have a signal and store that relies in user input without initial values and you need to pass them to a child component which has strict non-null types.
With current Show typescript will complain that first and last might be undefined. So you either have to use the bang operator or use createMemo to narrow like
const narrow = createMemo(()=> {
  if (selected() && store.data?.first && store.data?.second) return {selected:selected(),first:store.data?.first, second:store.data?.second}
  return false
}

And pass it to Show which now correctly narrows to non-null types.
With the added prop you can just:
const [selected,setSelected] = createSignal<Date|null>(null);
const [store,setStore] = createStore<{data?:{first?:Date,last?:Date}}>({})

return <Show when={{selected:selected(),first:store.data?.first, second:store.data?.second}} checkObjectValues>
// children will only render if all values are truthy
// item is now narrowed to {selected:Date, first:Date,second:Date}
   {item => <StrictChild {...item} />}
</Show>

Summary

How did you test this change?

@davedbase you're also quite active on discord. What are your thoughts on this?

@davedbase you're also quite active on discord. What are your thoughts on this?

That would be quite handy tbh.

So,...
I dug deeper and tested a lot, realizing that the with the first implementation, granular updates ware lost. To fix that I implemented a store in the case the checkObjectValues prop is set to true, if false the store won't be created.
So we get fine grained updates for the cost of having createStore and reconcile as dependencies.
But we get closer to type narrowing like in React.
Few questions:

Is it worth to proceed and invest more time, or does this not have a chance to be merged. Then I'll remove the PR. @ryansolid and @davedbase

With latest commit it is still possible to get the callback as an accessor or 'keyed'. But there's really no point of accessing a store. So we could always just return the store. But this would then make the keyed prop obsolete when checkObjectValues is set, because it doesn't change anything. So we have 3 options
2a. Keep the current implementation
2b. always return the store
2c. remove the checkObjectValues prop and add it as an option of keyed keyed:boolean | "checkObjectValues"

if 1. true :-P I would add documentation and also implement the same options for Switch/Match

This feels Solid Primitives area. As you have noted the implementation becomes more complicated as you try to do these checks. Generally I try avoid any base implementation that gets us into Stores because not every platform supports Proxies. It is unlikely a change like this happens in 1.x time period but I'm definitely interested in this area to understand the problems this solves and understand all the scenarios as we approach control flow improvements for 2.0.
That being said it seems to have value today which is why I point to Solid Primitives:  https://github.com/solidjs-community/solid-primitives

Just pasting some comments from the SolidJack 2024 channel about this topic:
Discord


Update Post “best-chemical-to-use-for-termite-treatment”

Automatically generated by Netlify CMS

👷 Deploy Preview for chic-shortbread-66a66b processing.

Name
Link

🔨 Latest commit
a83a09748e2ad642d0b2c7c9b5f4b0283728756c

🔍 Latest deploy log
https://app.netlify.com/sites/chic-shortbread-66a66b/deploys/654ae614b087240008cb1dd5


Feat: restrict the read restricted role

Link to JIRA ticket if there is one:
https://ctds-planx.atlassian.net/browse/VADC-1071,
https://ctds-planx.atlassian.net/browse/VADC-1209
Improvements

restrict role 15 (the "read restricted role") to a smaller set of permissions. Compare this to V<IP_ADDRESS>31025170057__altas_read_restricted_role_and_permissions.sql  or to https://github.com/OHDSI/WebAPI/pull/2342/files
enable the system to work for users that ONLY have role 15. This means "Atlas user" (role 10) and "Source user (omop)" roles are also not required anymore, which is important, since close review shows that they are too broadly defined as well (lots of * permissions).

Bug fixes

fixes an issue where users would be able to copy cohortdefinitions for which they would not be expected to have permissions. This happened because of a * permission, and now fixed in src/main/java/org/ohdsi/webapi/security/model/CohortDefinitionPermissionSchema.java so a more specific permission is  stored. Comes with respective migration script (at the end of src/main/resources/db/migration/postgresql/V<IP_ADDRESS>40617204600__custom_ctds_more_restricted_read_restricted_role.sql)
fixes incorrect use of sec_permission_id_seq in src/main/java/org/ohdsi/webapi/shiro/Entities/PermissionEntity.java. Now using sec_permission_sequence
fixes the issue where only one permission is expected from Arborist in src/main/java/org/ohdsi/webapi/shiro/filters/TeamProjectBasedAuthorizingFilter.java. Now updated to two.

fixes incorrect use of sec_permission_id_seq in src/main/java/org/ohdsi/webapi/shiro/Entities/PermissionEntity.java. Now using sec_permission_sequence\

Careful of this one, there was a permission PR in WebAPI where the duplicate sequence was identified for that table, and the one that was specified in the PermissionEntity was deemed the one 'in use' but this PR indicates that the entity's sequence was switched.   The reason why the choice was made on the WebAPI side was that we expected that permissions were created under this entity-specified sequence and we didn't want to deal with updating the unused sequence by renaming the one in the Entity.   I think this PR took the approach of choosing the one that follows the correct naming conventions.  Either choice has merit, but I wanted to call out here the consequence.

@chrisknoll thanks for the heads up. So does this mean that the solution discussed in the ticket https://github.com/OHDSI/WebAPI/issues/2352 is outdated? Can you please add a link to the PR where this was done? I'll close the outdated ticket in this case and will probably merge in your solution.

I had to check to see what the current state is.
Looks like master is using sec_permissin_id_seq.  From the discussion in the above ticket,  we noted that the sec_permission_sequence wasn't used and could be dropped, but in this PR the JPA entity was changed to use the unused sequence sec_permission_sequence.
So, if you want to use the sec_permission_sequence as it's done in this PR, you need the following:

update the JPA Entity to use the sequence sec_permission_sequence (this was done here)
Create a migration script that re-sets the sec_permission_sequence to the max of sec_permission.id and drop the old one
You provided what that migration would look like in the othe thread:

SELECT setval('${ohdsiSchema}.sec_permission_sequence', (select max(id)+1 from sec_permission), false);
DROP SEQUENCE ${ohdsiSchema}.sec_permission_id_seq;

The other Issue doesn't appear to have a PR associated with it, so the Issue just raised the concern, but there wasn't any change to address it (I thought there was, that's why I raised the flag above).
I probably would have avoided making the change to the JPA sequence in this PR, but I understand that it looked reasonable and the change was made as part of the 'read restricted role' PR.   I'm not sure how the changes in this fork are going to propogate over to the WebAPI codebase, but I feel like if we want to fix a sequence, we should make the change up on the WebAPI and propogate that change down to your fork.
But, considering the sequence was changed in your fork, I'm unsure what the easiest path is to get the sequence in the upstream to agree with this fork....unless ultimately we will make a PR from your fork into WebAPI...if that's the case, we should probably introduce another migration script to re-set the sec_permission_sequence.


Add layout virtual scroll component

Create branch from main
issue-12-add-layout-virtual-scroll-component


RC Spot-Check Test: Mean: Share and Balance 1.1.0-rc.5

RC Spot-Check Test
Mentions: @marlitas, @jbphet, @amanda-phet
Simulation links

github repository for issues
phet top-level directory
sim: all_phet.html
phet-io wrapper index
link to phet-io zip file

Test Matrices
General Test:

[x] Tester =MM , Platform =Win 11 Firefox , Time =1
[x] Tester = KW, Platform = Win 11 Chrome, Time = .75

PhET-iO Test:

[ ] Tester = , Platform = , Time =
[ ] Tester = , Platform = , Time =

Additional Features Test:

[ ] Tester = , Platform = , Time =
[ ] Tester = , Platform = , Time =

Features included

[x] PhET-iO
[x] Dynamic Locale
[x] Alternative Input
[x] UI Sound
[x] Sonification
 [ ] Description
[ ] Voicing

Focus and Special Instructions
This is a spot check where two issues relating to group sort interaction were addressed (listed below).  The focus
should be on verifying these issues and regression testing other group sort behavior, as well as dragging and stacking
of the candy bars on screen 2, since this code had some small changes.
Issues to Verify

[x] https://github.com/phetsims/mean-share-and-balance/issues/351
[x] https://github.com/phetsims/mean-share-and-balance/issues/352

For QA...

General features

What to Test

Click every single button.
Test all possible forms of input.

Test all mouse/trackpad inputs.
Test all touchscreen inputs.

If there is sound, make sure it works.
Make sure you can't lose anything.
Play with the sim normally.
Try to break the sim.
Test some query parameters. (See QA Book for a
list of query parameters.)
When making an issue, check to see if it was in a previously published version.
Try to include version numbers for browsers.
If there is a console available, check for errors and include them in the Problem Description.
As an RC begins and ends, check the sim repo. If there is a maintenance issue, check it and notify developers if there
is a problem.
As the RC ends, notify the developer of any new QA credits that need to be added.

PhET-iO features

What to Test

Make sure that public files do not have password protection. Use a private browser for this.
Make sure that private files do have password protection. Use a private browser for this.
Make sure standalone sim is working properly.
Make sure the wrapper index is working properly.
Make sure each wrapper is working properly.
Launch the simulation in Studio with ?stringTest=xss and make sure the sim doesn't navigate to youtube
For newer PhET-iO wrapper indices, save the "basic example of a functional wrapper" as a .html file and open it. Make
sure the simulation loads without crashing or throwing errors.
Load the login wrapper just to make sure it works. Do so by adding this link from the sim deployed root:/wrappers/login/?wrapper=record&validationRule=validateDigits&&numberOfDigits=5&promptText=ENTER_A_5_DIGIT_NUMBER

Further instructions in QA Book
Conduct a recording test to Metacog, further instructions in the QA Book. Do this for iPadOS + Safari and one other
random platform.
Conduct a memory test on the stand alone sim wrapper (rc.1).
Test one platform combination with ?phetioDebug=true on the Studio and State wrapper.
If Pan/Zoom is supported, make sure that it works when set with PhET-iO State.
Test that the sim works offline:

Click the link to the phet-io zip file (at top of issue) to download the zip file.
Unzip it to a spot locally.
Open index.html by double clicking it on your desktop or in a Finder-view.
It should look like the standalone version of the sim in PhET-iO brand.

Accessibility features

What to Test

Specific instructions can be found above.

Make sure the accessibility (a11y) feature that is being tested doesn't negatively affect the sim in any way. Here is
a list of features that may be supported in this test:

Alternative Input
Interactive Description
Sound and Sonification
Pan and Zoom
Mobile Description
Voicing

Test all possible forms of input.

Test all mouse/trackpad inputs.
Test all touchscreen inputs.
Test all keyboard navigation inputs (if applicable).
Test all forms of input with a screen reader (if applicable).

If this sim is not in this list or up to date there, make an
issue in website to ask if PhET research page links need updating. Please
assign to @terracoda and @emily-phet.

Screen Readers
This sim may support screen readers. If you are unfamiliar with screen readers, please ask Katie to introduce you to
screen readers. If you simply need a refresher on screen readers, please consult the
QA Book, which should have all of the information
you need as well as a link to a screen reader tutorial made by Jesse. Otherwise, look over the a11y view before opening
the simulation. Once you've done that, open the simulation and make sure alerts and descriptions work as intended.

Platforms and Screen Readers to Be Tested

Windows 10 + Latest Chrome + Latest JAWS
Windows 10 + Latest Firefox + Latest NVDA
macOS + Safari + VoiceOver
iOS + Safari + VoiceOver (only if specified in testing issue)

Critical Screen Reader Information
We are tracking known screen reader bugs in
here. If you find a screen reader bug,
please check it against this list.

Keyboard Navigation
This sim supports keyboard navigation. Please make sure it works as intended on all platforms by itself and with a
screen reader.
Magnification
This sim supports magnification with pinch and drag gestures on touch screens, keyboard shortcuts, and mouse/wheel
controls. Please test magnfication and make sure it is working as intended and well with the use cases of the
simulation. Due to the way screen readers handle user input, magnification is NOT expected to work while using a screen
reader so there is no need to test this case.

FAQs for QA Members

There are multiple tests in this issue... Which test should I do first?
Test in order! Test the first thing first, the second thing second, and so on.

How should I format my issue?

We typically assign the developer who opened the issue in the QA repository.

My question isn't in here... What should I do?
You should:

Consult the QA Book.
Google it.
Ask Katie.
Ask a developer.
Google it again.
Cry.

QA is done

Thanks @KatieWoe - I'll follow up on the issue that was logged and will close this one.


Features not available

Hi, I just tried your program and found 2 issues. First, it does not accept emails in the following format:
"some person"<EMAIL_ADDRESS>Next, the web interface only allows you to view messages if there is a subject line. But a lot of what I send are text messages where there is no subject line, so I can't review those messages.
These two features would be nice to see on your application, just a heads up...

In the first issue are you referring to the format of a recipient?

I found the answer to the first issue. Sooooo.... Nevermind on that. The
email messages were getting sent to the application empty. The format
function is throwing an error and that makes the body empty. I assumed it
was the email address since my logs reported bad address. So I sent the
messages to an output folder and found that the messages in question indeed
did not have a message in the body. I missed it because the majority of the
messages that are sent are text messages, which does have a body.
Thanks for your support on this, sorry if you got into what turns out to be
a nonproblem. But Item #2 would be a great feature. Thanks...
On Fri, Feb 23, 2018 at 3:21 PM, Paul Wright<EMAIL_ADDRESS>wrote:

Yes, that is the mail format I get when I use the c# SMTPClient.
On Fri, Feb 23, 2018 at 3:12 PM, Adam Presley<EMAIL_ADDRESS>wrote:

In the first issue are you referring to the format of a recipient?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mailslurper/mailslurper/issues/66#issuecomment-368165691,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AXO95s6eGARQKByzS5vT4qF1QdDfQPIyks5tX0XtgaJpZM4SRfqP
.

OK, cool. Yeah, so I'll look at adding a fix for the second item.

Awesome, I can't wait till it's released. Thanks Adam...
On Wed, Mar 7, 2018 at 6:36 PM, Adam Presley<EMAIL_ADDRESS>wrote:

Closed #66 https://github.com/mailslurper/mailslurper/issues/66.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mailslurper/mailslurper/issues/66#event-1510290584,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AXO95p5jEvMeawe6jRYOQlyAehgiIloiks5tcJkSgaJpZM4SRfqP
.


NuGet.Config File Reference (proxy configuration)

Please, increase the proxy configuration documentation in https://github.com/NuGet/docs.microsoft.com-nuget/blob/00df19348edfef840ff92abf260cf0af9ef246d7/docs/Schema/nuget-config-file.md.
In particular, the no_proxy format is undocumented. After a try / error cycle I saw that exceptions are stored with regular expressions and wildcards must be escaped
in my configuration I wrote <add key="no_proxy" value="*.mydomain.com" />
but when updating (nuget update -self) an exception was trown parsing the proxy configuration.
The correct syntax is <add key="no_proxy" value="\*.mydomain.com" />

@karann-msft Another one to confirm with engineering.

@mnieto what version of nuget.exe are you running?
I tried that exact scenario with the latest version - 4.4, and I could not reproduce the error.

Rolled up to #776


raftstore: enhance raft snapshot metrics

This pull request enhances metrics for the raft snapshot workflow, includes:
1.Use generate-kv, generate-sst and generate-plain metrics to measure snapshot generation speed. These metrics offer better visibility, allowing for a clearer comparison between snapshot generation throughput and send/receive throughput, making it easier to identify bottlenecks.

2.Add metrics for various snapshot tasks to the Snapshot Actions, including send, recv, recv_droppedn and others, providing better visibility for snapshot actions.

What is changed and how it works?

Issue Number: Ref #15990

What's Changed:
This pull request refines metrics for the raft snapshot workflow, includes:
1. Use generate-kv, generate-sst and generate-plain metrics to measure snapshot generation speed. These metrics offer better visibility, allowing for a clearer comparison between snapshot generation throughput and send/receive throughput, making it easier to identify bottlenecks.
2. Add metrics for various snapshot tasks to the Snapshot Actions, including send, recv, recv_droppedn and others, providing better visibility for snapshot actions.

Related changes

[ ] PR to update pingcap/docs/pingcap/docs-cn:
[ ] Need to cherry-pick to the release branch

Check List
Tests

[ ] Unit test
[ ] Integration test
[x] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Release note

none

/cc @Connor1996 @glorv @LykxSassinator @hbisheng PTAL, thx~

@hbisheng @LykxSassinator PTAL again, thx~  and if everything looks good, please give on ok-to-test.

/ok-to-test

/retest


Suggestion: Storage Cycling by size

Suppose we have 1Gb disk free space. And we don't know how many backups would fit in. It is great to haave an option such as sftp.keep_sizeit  = 1.gigabyte.
if backup_size > keep_size
  raise Error
until storage_free_space >= backup_size
  remove_oldest_backup!
end

But it's a question how to compose keep and keep_size... Which of them is dominant, there ara variants.

Interesting idea. Well, I think it would just do what you define it to do. Say if we'd allow you to specify an option like so:
keep 20, size: 200

Then it would first ensure there are no more 20 backups on in your storage location. Afterwards, it would simply summarize all the file sizes and if the total amount exceeds 200 megabytes, then it will start with the oldest backup file and add it to the queue to be deleted.
# Assuming this was set by the user
KEEP = 20
KEEP_SIZE = 200

# And this was gathered by Backup
@backup_objects = [obj1, obj2, obj3...obj25] # all backup stored objects found by Backup
@total_size = 300 # total size of all backups combined calculated by Backup
@deletion_queue = [] # a new array to hold the objects that needs to be removed

# get rid of the last 5 backups since we have 25, and only keep 20
while @backup_objects > KEEP
  oldest_backup = @backup_objects.shift
  @total_size -= oldest_backup.file_size
  @deletion_queue.push(oldest_backup) # add oldest to deletion queue
end

# ensure the total file size doesnt exceed 300 (minus the 5 backups' sizes combined).
# basically same procedure except for the while condition
while @total_size < KEEP_SIZE
  oldest_backup = @backup_objects.shift
  @total_size -= oldest_backup.file_size
  @deletion_queue.push(oldest_backup) # add oldest to deletion queue
end

# get rid of the backups that either exceed the KEEP or KEEP_SIZE
@deletion_queue.each do |backup_object|
  backup_object.send(:remove!)
end

# register/persist the remaining backups
persist(@backup_object)

Additionally one could do something like this:
keep :all, size: 200˜

This would then just keep all backups based on KEEP, and only cycle based on KEEP_SIZE. These are just some ideas.

Note: This is not what the actual Backup implementation/internals looks like, it's just a quick write-up/note in a few lines for future reference if we decide to implement this. But, I think that this is basically the logic that would be implemented, just in a proper/tested way.


add max-txn-ops, nodeselector and toleration

Following this issue https://github.com/pachyderm/helmchart/issues/211

add nodeselector and toleration
fix bug in etcd command if dynamicNodes > 1
add max-txn-ops variable for etcd

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@robert-uhl would you mind taking a look at this for us? Seems pretty straightforward to me but someone who knows helm better should take a look.

Hi @GuiGav, thanks for you patience here!
This is a great contribution. I've also ported it over to our master branch: https://github.com/pachyderm/pachyderm/pull/7082
I have a couple small comments to address but otherwise this looks good!


[WIP] Sequel integration

#45 (with already merged #37)

@AlessandroMinali take a look. Actually i'm a bit exhausted by writing so much tests :)
Is there something that is not covered here from your point of view?
Glad to say that Sequel works perfectly by returning instances of models & plain Ruby arrays instead of some weird "association proxies". So no actual code was touched in this PR, only tests.


Touch Interaction not working in java code

I have made the app in java so I am having problem regarding touch interaction part because some function don't match in kotlin and java. Please provide code for java too.

Is the issue on index other than 0 in the LiquidSwipeViewPager? I'm having a problem were recycler don't scroll and it's on index 1.

Is the issue on index other than 0 in the LiquidSwipeViewPager? I'm having a problem were recycler don't scroll and it's on index 1. Thinking about opening a separate ticket.


URIs are sent unnormalized

According to the CoAP RFC, the Uri-Path option is a “string”, which is supposed to be encoded in the Net-Unicode (UTF-8 + NFC) format. Node-coap currently send URIs unchanged, allowing users to pass unnormalized strings.
I think Uri-Path (and potentially other “string” options) fall in the “imported from sources outside the CoAP protocol” category mentioned in the RFC.

@guimier any pending work here or should I close?


[Feature request]Is it possible to map the Quest VR controllers as trackers and use hand tracking as the controllers?

Is it possible to map the Quest VR controllers as trackers and use hand tracking as the controllers?
Like this:https://x.com/i/status/1791187692094447997
(gpt translation)

Seems kinda useless, because nearly all wireless vr headsets have camera-based tracking (and if you have base-station tracking then that already works with steamvr with alvr). This means that it's incredibly easy for your feet to go out of the field of view of the cameras and for your feet to loose tracking. If you pr this it might get merged, since it might be useful for other things, but otherwise this is not planned

@979500318 like the author says in the post comments, the video is fake. Because Meta hasn't provided a suitable API to make it possible, so we cannot do it either. it doesn't mean the hardware forbids it, actually Meta already has a api to track controllers and fingers at the same time, but only when the controllers are in the hands.

@979500318 like the author says in the post comments, the video is fake. Because Meta hasn't provided a suitable API to make it possible, so we cannot do it either. it doesn't mean the hardware forbids it, actually Meta already has a api to track controllers and fingers at the same time, but only when the controllers are in the hands.

So it's a fake? That's a shame. Thanks.

I want to implement concurrent tracking of controllers and hand skeleton rather soon, so we can see how it behaves then.


Showcase Submission for challenges/171-wave-function-collapse

Thank you gagan mishra for your contribution! A member of the Coding Train team will review it shortly.

Wave Function Collapse
gagan mishra

Great work!


Make accommodation image optional

Accommodation images will be optional in the next release. Every listing without an image will get an default icon instead.

Done


Gestures

Hey folks,
I've just:

synchronized the gestures branch on master.
updated UISpec submodule to pull the frank_additions branch of UISpec
updated frank's pbxproj to include extra files from UISpec branch

This should be enough to have an out of the box build for gestures by doing:

git clone frank
git branch gestures
git submodule init
git submodule update

I'm not extremely familiar with git submodules, they seem to be a weird beast.
What I did to get that working is:
git branch gestures
git submodule init
git submodule update
cd lib/UISpec
git branch frank_additions
cd ../
git add UISpec
If I understood properly how these freaking submodules work, that should stick it to whatever revision was the head of the frank_additions branch.

Hu.
Just realized the pull request is going to moredip:master, that wasn't my intention, I just wanted to resync the gestures branch with master branch so the gestures branch is using the latest Frank goodies, not pull the gestures into master :/


Fixing test mixup

What's the problem this fixes?

As I'm publishing 1.0.x I'm finding that test JARs are getting used instead of compile JAR due to weird Ivy-Maven mismatch and sbt's buggy behavior around it. Instead of relying on "test->test", I'm duplicating a few files across repos.

See
[info] downloading https://repo1.maven.org/maven2/org/scala-sbt/util-logging_2.11/0.1.0-M12/util-logging_2.11-0.1.0-M12-tests.jar ...
[info] 	[SUCCESSFUL ] org.scala-sbt#util-logging_2.11;0.1.0-M12!util-logging_2.11.jar (470ms)
[info] downloading https://repo1.maven.org/maven2/org/scala-sbt/util-logging_2.11/0.1.0-M12/util-logging_2.11-0.1.0-M12.jar ...
[info] 	[SUCCESSFUL ] org.scala-sbt#util-logging_2.11;0.1.0-M12!util-logging_2.11.jar (370ms)

https://gist.github.com/eed3si9n/27e5b494d0b00eee1a67d5bf3bc02af2
This happening to one of the sbt modules is resulting to runtime error when trying to use zinc from sbt.
Error during sbt execution: java.lang.NoClassDefFoundError: sbt/internal/util/ConsoleOut$


Thread interrupt flag persists between test methods

TestNG Version
v6.14.3
Expected behavior
When a test method returns with the current thread interrupt flag set, I would expect one of the following things to happen

The interrupt flag is silently cleared, so that subsequent tests that make interruptible calls don't fail in unexpected ways
The test fails due to finishing with the interrupt flag set to true

Either of the above approaches would be reasonably easy to deal with and understand what's going on
Actual behavior
The interrupt flag stays on the thread running the test, which means if that particular thread executes another test which makes an interruptible call, it will throw an interrupted exception, typically leading to unexpected failures that have nothing to do with the current test.
Is the issue reproductible on runner?

[ ] Shell - Not tested
[X] Maven
[ ] Gradle - Not tested
[ ] Ant - Not tested
[X] Eclipse
[ ] IntelliJ - Not tested
[ ] NetBeans - Not tested

Test case sample
public class InterruptTest {
    @Test(priority=1)
    public void interruptsTheCurrentThread() {
        Thread.currentThread().interrupt();
    }
    @Test(priority=2)
    public void shouldntGetInterruptedButDoes() throws InterruptedException {
        Thread.sleep(0); // this will throw an exception
    }
}

I'm not sure it is an issue: by design, TestNG keeps state between tests and you have to clean the context by yourself.
But agree, it could be difficult to understand why it is failing.

The test fails due to finishing with the interrupt flag set to true

is definitively my favorite solution.
Fyi, you should be able to have the expected behavior by using a listener that will check the thread flag and mark the test as failed.

@kcorman - As @juherr  mentioned, TestNG is not supposed to be aware of the interrupted states because it doesn't set them. You should be able to get this sorted out at your test project level itself by building an IInvokedMethodListener implementation wherein you do something like this
if (Thread.currentThread().isInterrupted()) {
   Thread.interrupted();
}

Closing this issue.


autoreload doesn't work in the new version of jupyter notebook supporting

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:  Version: 1.58.1 (Universal)
OS Version: Mac OS 11.3.1

Steps to Reproduce:

have a script called xxx.py
create a jupyter notebook inside the vscode with
%load_ext autoreload
%autoreload 2
import xxx
make modifications in xxx.py
jupyter notebook won't reloading the modified module of xxx.py. Current solution: restart the notebook

@kid3night I'm so sorry, I missed this issue.
Will look into this today.


A typo?

"ContentControl and ItemsControl" section:
"Likewise, an ItemsPresenter that is in the ControlTemplate of an ItemsControl will automatically bind to the Items and ItemsPresenter properties."
ItemsPresenter ... bind to ... ItemsPresenter
It seems that instead of the second ItemsPresenter there should be ItemTemplate.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9dfc55ee-0061-cd98-fd01-ad6156f8d155
Version Independent ID: 594e424a-30ed-9f1e-dac7-e56acdd022e0
Content: Styles and templates - WPF
Content Source: docs/desktop-wpf/fundamentals/styles-templates-overview.md
Product: dotnet-desktop
Technology: dotnet-wpf
GitHub Login: @Thraka
Microsoft Alias: adegeo

Thank you for reporting this.


Directional keys don't work while in media playback

AFAIK jsonrpc doesn't have any method that does the 10s skipping thing. That is only available through EventServer, which Kore doesn't use.
There are valid alternatives (re/ffw, using the position tracker on now playing), so imo it's not justified implementing a EventServer interface just for this.

imo we should be imitate the directional keys that you have using a regular keyboard/remote.
So is this only possible using eventserver during playback?
@Montellese you know a way to do this with JSON-RPC?

You have to use Player.Seek with smallstepforward, bigstepforward, smallstepbackward and bigstepbackward.

@Montellese The thing is, afaict the remote can't reliably decide when to call Input.Left/Right or Player.Seek. Both these actions can be invoked by the same button in the remote D-Pad, and it can't decide when to call one or the other (media is playing isn't a sufficient condition because there might be some UI present, and in that case it should send Input.Left instead of Player.Seek).
The EventServer code probably includes some logic to deal with this (i haven't checked, guilty as charged), but it knows more about Kodi state than the remote.
In jsonrpc API there's Input.Left/Right/Up/Down and there's Input.ExecuteAction which can take "left"/etc - both behave the same way afaict. I don't know if it is possible, if it is simple or even if it makes sense, but isn't it possible to change Input.ExecuteAction to behave exactly as in the EventServer?

@MartijnKaijser what you ask is a 2 years old fight that I've lost :)
There's a problem for most of the Team about how action should be handled and how to offer them to remotes.
I should be able to find the threads to re open the discussion but the core was remote should not be able to call things that depends on keymaps that can be changed by users.
From an user point of view this means : I can configure Kodi to behave the way I like from my keyboard and physical remote but I have to do the same configuration on Android / iOS remote because it's not good the allow users to have the same behavior everywhere.
The team point of view was it's bad to allow a command to not have a predictable action, the user point of view is I have modified my keymap for a reason why don't you let me use my choice ?
I know for sure that users are right on this, but was never able to make someone on the team understand user point of view and need. Maybe this is another chance ?

Please bring back the functionality from the old XBMC remote! If using the same buttons is not an option, at least add a settings to re-map the fast-forward/fast-rewind buttons. I think they are inferior to the +/-10s seeks in all aspects - in what's probably the most common case, i.e. skipping the repetitive intro of a tv show, it's so easy to simply hit the seek-forward button a few times instead of playing with fast-forward (and being tortured by the terrible audio that comes with fast-forward playback) and then switching back to normal playback speed in the right moment.

The team point of view was it's bad to allow a command to not have a predictable action, the user point of view is I have modified my keymap for a reason why don't you let me use my choice ?

I think the solution for this could be quite simple: Add another command "seek backwards or go left". That way there would be the unambiguous "seek backwards" and "go left" actions, but remotes that want to use the button for both could use the combined action.

I have to say that I think it is most definitely worth "implementing a EventServer interface just for this." There are NOT any valid alternatives. Other than pause/play and stop, these are the functions that I absolutely have to during playback. This app has a terrific interface, but without this functionality, I'll keep using Yatse instead. I have not seen any of the discussions that are mentioned, but this really seems like a case of developers making decisions about what is important to their users, rather than actually asking the users or doing any usability testing. A real shame, as this is otherwise a great app.

I have to say that I think it is most definitely worth "implementing a EventServer interface just for this." There are NOT any valid alternatives. Other than pause/play and stop, these are the functions that I absolutely have to during playback. This app has a terrific interface, but without this functionality, I'll keep using Yatse instead. I have not seen any of the discussions that are mentioned, but this really seems like a case of developers making decisions about what is important to their users, rather than actually asking the users or doing any usability testing. (Maybe I am wrong, but that is the impression I get.) A real shame, as this is otherwise a great app with a really nice design.

I have the same approach here. This wonderful remote is completely useless during playback for me, and I keep switching from this to old remote while on playbak. The skip function is essential to me while watching TV series (and some movies).
PLEASE, implement this so needed feature!

I'd like to also ask that this feature be considered. I'm unfamiliar with the API's so I won't suggest a solution but I'm sure a good solution can be found for this and I think it's a perfectly valid use-case.

I would expect that, like me, those that use the skip functionality prefer it over fast forward and rewind. Could this be added as an option in the app settings that changes the function of the << and >> buttons to skip back and skip forward instead?

It´s already been said that other approach has to be taken for skip to
work, and they seem to think that this is not worth it. Se we have to keep
using another remote. Really sad.
2015-06-06 0:02 GMT+02:00 CGorni<EMAIL_ADDRESS>
I would expect that, like me, those that use the skip functionality prefer
it over fast forward and rewind. Could this be added as an option in the
app settings that changes the function of the << and >> buttons to skip
back and skip forward instead?
—
Reply to this email directly or view it on GitHub
https://github.com/xbmc/Kore/issues/46#issuecomment-109453210.

--
Saludos cordialesAugusto Montes"Solo hay 2 cosas infinitas: el universo y
la estupidez humana, y de la primera no estoy seguro"
Albert Einstein

Yes, but hopefully the development team is not completely closed minded on the subject, and if enough users let them know how they feel, they will change their mind. If they really care they could always start a poll on the forum. Thankfully  Yatse works great, and I'll always take functionality over style.

+1
On Sat, Jun 6, 2015 at 3:15 PM waltermartin<EMAIL_ADDRESS>wrote:

Yes, but hopefully the development team is not completely closed minded on
the subject, and if enough users let them know how they feel, they will
change their mind. If they really care they could always start a poll on
the forum. Thankfully Yatse works great, and I'll always take functionality
over style.
—
Reply to this email directly or view it on GitHub
https://github.com/xbmc/Kore/issues/46#issuecomment-109577443.

+1000
2015-06-07 14:07 GMT+02:00 Oskar Risberg<EMAIL_ADDRESS>
+1
On Sat, Jun 6, 2015 at 3:15 PM waltermartin<EMAIL_ADDRESS>wrote:

Yes, but hopefully the development team is not completely closed minded
on
the subject, and if enough users let them know how they feel, they will
change their mind. If they really care they could always start a poll on
the forum. Thankfully Yatse works great, and I'll always take
functionality
over style.
—
Reply to this email directly or view it on GitHub
https://github.com/xbmc/Kore/issues/46#issuecomment-109577443.

—
Reply to this email directly or view it on GitHub
https://github.com/xbmc/Kore/issues/46#issuecomment-109745249.

--
Saludos cordialesAugusto Montes"Solo hay 2 cosas infinitas: el universo y
la estupidez humana, y de la primera no estoy seguro"
Albert Einstein

+1 ... I hope that it will at least the same as XBMC remote was, since it was working at least... how was these features implemented there? the hacky way?

They have to implement EventServer, wich is a separate service from
JsonRPC, since it doesn´t support the 10s skipping. Anyway, it´s at the top
of the post...
2015-06-08 12:35 GMT+02:00 B. Roland<EMAIL_ADDRESS>
+1 ... I hope that it will at least the same as XBMC remote was, since it
was working at least... how was these features implemented there? the hacky
way?
—
Reply to this email directly or view it on GitHub
https://github.com/xbmc/Kore/issues/46#issuecomment-109945182.

--
Saludos cordialesAugusto Montes"Solo hay 2 cosas infinitas: el universo y
la estupidez humana, y de la primera no estoy seguro"
Albert Einstein

BTW.
Why not open a poll?? I´m not sure if any user can do it, put perhaps we can convince a mod/dev to open one...

Ok, but why not put this extra feature to JsonRPC at the Kodi's site? So it can be accessible using just one "protocol".

JsonRPC comes as is, it´s not easyly modifiable. It´s a structural change we´re talking about.

I've used RPC technology (RMI) via Java, and I just needed to define a new function on server's side, if I wanted some extra functionality. Is JsonRPC's source closed, or why is not modifiable?

https://github.com/xbmc/Kore/issues/46#issuecomment-85572364

I can't see any relevance with that comment, just excuses. I still don't get, why can't the team add more features/functions to JsonRPC?! If EventServer is not good, don't use it at all, but add this feature to that JsonRPC...

@antivirtel they are pretty good excuses. If you alter the function of the buttons at Kodi side you alter the function of the remote as well. As such you will not have consistent for the remote if you switch Kodi installs.
Kodi is open source, if you think you can add the correct function to JSON-RPC feel free to do so. Why it hasn't been done yet is time and the proper implementation to make it consistent regardless of the Kodi install and advancedsettings used.

@MartijnKaijser there was proposal to improve JSON and add correct support for users needs, all were refused, so yes Kodi is open source, but not all features users want can get in even if someone code them. (And I did try a few times already)
I still have not seen any explanation or real discussion on why users from remote should not have access to configuration they have made.
The fact that input.right does trigger input.right and not a random function is logical and wanted.
But the refusal to have a way to trigger remote.right from JSON so that users have access to their keymaps they wanted and took time to configure is not logical at all.
This is the same for advanced settings, each time I asked on adding support for reading them from remotes the answer was no it's not wanted, so a user configure it's wanted articles for sorting, but remotes can't get the values he configured.
Anyway for this specific skip things, there's no possible workaround apart using EventServer, as there's no way to detect when to use right or skip (and it would need the user to reconfigure the skip to behave the way he loves as new progressive seek won't be loved by all users). (It's impossible to know if there's a window over the video or under like subtitles delay or OSD, hacks to detect commons window visible via labels may be done but it's not possible to cover all cases).

I'm going to implement eventserver in the next version, so no need to argue further.

:( I was hopping official remote problems, becomes official and thing may change, but if even you give up and use hacks and this then it's a lost battle :(

SyncedSynapse just said that he´s going to implement event server. I don´t get what battle was lost.
Let´s just say thank you for your support, which by the way, is free.
Many thanks guys.

Well because you are not developer and do not understand the impact of what's going on in this thread ;)
You as Kore user have a little win, us remote developer have a big loose.

For us users it´s a huge win. It´s perhaps one of the three functions most
used by everyone I know (including play and pause). As for the developers
point of view, yes, I can understand you are letting go so much.
2015-06-09 18:47 GMT+02:00 Tolriq<EMAIL_ADDRESS>
Well because you are not developer and do not understand the impact of
what's going on in this thread ;)
You as Kore user have a little win, us remote developer have a big loose.
—
Reply to this email directly or view it on GitHub
https://github.com/xbmc/Kore/issues/46#issuecomment-110428594.

--
Saludos cordialesAugusto Montes"Solo hay 2 cosas infinitas: el universo y
la estupidez humana, y de la primera no estoy seguro"
Albert Einstein

I am a developer, but not for Kodi or using the particular technologies involved, so I don't know if there is a better way to do this. However, I am glad to read what SyncedSynapse wrote. This is more than just a little win for me as a Kore user.

@Tolriq

MartijnKaijser there was proposal to improve JSON and add correct support for users needs, all were refused

input.something

I'm not involved to the development of Kodi &  Kore (yet), but I'm a Java developer, and I think, that using input object is considered as a hacky solution, and that's why the head developers refuse to merge the pull requests.
My suggestion is, that those jump or seek functions bound to keyboard's arrows - already mentioned here - should be made public/available from JsonRPC... (ONLY IF something's playing AND that menu with the Stop, Play/Pause, FF... is not opened), it will use these functions, not the left/right functions!
I don't know what technology is used by the  EventServer, but the RPC is widely used, and I think one technique is far enough for remote controlling...
BTW, XBMC's official remote had that Swipe control mode, instead of these arrow up/down, left/right buttons - did those buttons need any back-end adjustments, or just UI and some time counter loops?

@antivirtel Well I tried to be involved numerous times (and have been some times) ;) And I'm developer of Yatse a way older remote than Kore, so I have a little more insight about how things works and what users want ;)
What you do miss is that the keyboard arrows are tied to keymaps and that's the main problem ;)
(Even if it should not but well no way to discuss). And no Input.something is not hacky it's opening the configuration users have made to remote, it should allows keyboard(xxx) and remote(xxx) to emulate keyboard and remotes from JSON, there's no valid reason to not open this and never was any real argument / discussions. (Specially when it's also refused to get access to those keymaps / advanced settings to try to reproduce without having user to do it's configuration again).
So it's a little more complicated than that, what the core team seems to want is a duplication of default keymaps code to handle this, or to hard code some actions when something is playing or tons of other things, but using the keymap that contains the configuration that the user wants.
(Keymap that change beetween Kodi release)
I'm a user I want left / right to skip 10 sec and up / down 30 sec I modify my keymap to do that, but when using a remote I need to find a remote that allows configuration of the buttons to reproduce the same behavior, but even if remotes could do that it's now impossible due to the lack of API to know if we should send UI commands or player commands.
And as you can see again in this thread, there's no way to discuss anything, no arguments, and when making PR you'll get as before a refusal without better proposal and have loose time for nothing.
So until the Team understand the need or agree to discuss on what should be done, EventServer that use the configuration of the user is the only possible solution and that's a shame.

Yes, I've already been understood this problem, but I still have doubts, because it seems, that you all not really get my question and/or suggestion.
That's why I'll investigate this JsonRPC, if I'd have time, and will write concrete suggestion, instead of the logical reasoning!
(don't expect this, till the end of the week!)

This is a must-have!
Any news?

it's so queer it works for Mac but doesn't work for PC

Kore v2.3.2 + Kodi 14.4 Git:20170913-5cc491e on Raspbian Stretch  and directional keys don't work during playback. Any ideas how to check what is causing a problem, it was update for both Kore and Kodi in last mounth?

@sokarsg-1 Anything changed in your network that might be blocking port 9777 (or whatever you've set up for EventServer)?

Its look like that, but only think i changed is samba config.
All my open ports:
PORT     STATE SERVICE     VERSION
22/tcp   open  ssh         (protocol 2.0)
139/tcp  open  netbios-ssn Samba smbd 3.X - 4.X (workgroup: CELL)
445/tcp  open  netbios-ssn Samba smbd 4.5.8-Debian (workgroup: CELL)
1054/tcp open  upnp        Platinum UPnP <IP_ADDRESS> (UPnP/1.0 DLNADOC/1.50)
5900/tcp open  vnc         RealVNC Enterprise 5.3 or later (protocol 5.0)
8080/tcp open  http        XBMC Web Media Manager
9090/tcp open  jsonrpc     XBMC JSON-RPC 2.0

Try opening pot 9777


incorrect range for was_informed_by

WorkflowExecutionActivity subclasses populated was_informed_by with OmicsProcessing values. @picowatt pointed out that the specified range for was_informed_by is Activity and OmicsProcessing is a PlannedProcess, rooted in NamedThing, not under Activity. I'm not sure if this is from re-rooting OmicsProcessing. This is not causing any errors in production but the documentation is inaccurate and confusing and I can't recall where we are at with linkml enforcing range. was_informed_by doesn't not currently have a pattern constraint on it which is why we haven't been seeing any issues.

@mbthornton-lbl notes we have the same issue with was_generated_by.
@cmungall @turbomam  where are we at with having linkml enforce a range.

Are you talking about applying id pattern constraints for foreign keys (full referential or integrity would require more coupling with mongo). I believe it is supported.

I’m talking about enforcing a class constraint via range without specifying
a structured syntax
On Tuesday, April 2, 2024, Chris Mungall @.***> wrote:

Are you talking about applying id pattern constraints for foreign keys
(full referential or integrity would require more coupling with mongo). I
believe it is supported.
—
Reply to this email directly, view it on GitHub
https://github.com/microbiomedata/nmdc-schema/issues/1846#issuecomment-2032687462,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB6RD36QWPOHFJJ4UQNNZNTY3LVUJAVCNFSM6AAAAABEW276RCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZSGY4DONBWGI
.
You are receiving this because you authored the thread.Message ID:
@.***>

newbie question: @aclum - can you point me to the code that is returning the "type" of object in the was_informed_by slot on WorkflowExecutionActivity?  Said another way, how do you know that type(WorkflowExecutionActivity.get("was_informed_by") == "nmdc:OmicsProcessing" -- this might help me figure out why the validation code can't recognize the error here.
e.g. can you tell by looking at the id of the data an incorrect object is being asserted here?

I'm also assuming this is operating against the main branch of NMDC schema, not the Berkeley schema?

Yes, the main branch of the schema.
Mark updated the berkeley schema to enforce type but that isn't in main yet so for now you could look at the type code for the identifier (nmdc:omprc), look for that typecode in the structured_pattern.syntax in nmdc.yaml (ie https://github.com/microbiomedata/nmdc-schema/blob/f88ec8462b90102ebeddbcdc8903959883e175d0/src/schema/nmdc.yaml#L1695) look at is_a for that class. OmicsProcessing is_a PlannedProcess, from core.yaml PlannedProcess is a NamedThing. NameThing is a top level class. https://github.com/microbiomedata/nmdc-schema/blob/f88ec8462b90102ebeddbcdc8903959883e175d0/src/schema/core.yaml#L79
Alternatively you could use the graphdb version of the schema, if you search by ID as the 'subject' most of those documents have nmdc:type and nmdc:designated_class.

Thanks, yes, I found the schema requirements - I was curious how @picowatt determined that the data was wrong.  Was it because the OmicsProcessing identifier had a specific nomeclature different than a typical Activity identifier nomeclature?

Yes, nmdc:omprc, they typecode for OmicsProcessing is different than the activity identifiers which are typically nmdc:wf*

Updates from my debugging:
The linkml JSONSchema generator currently recognizes  linkml:pattern not linkml:structured_pattern metamodel syntax.  linkml:pattern from the nmdc:id slot is being applied to all classes that use that slot.  nmdc:was_informed_by has no pattern, but does have: range: Activity.  I think the ask here is that the linkml JSONSchema generator:

For a ClassB.slot_a with a range constraint of ClassC in the model, apply to ClassB.slot_a the rules/patterns/slot_usages of the linkml:identifier slot on ClassC and validate accordingly.  Is this right?

In our example, because nmdc:Activity has a linkml:identifier slot, nmdc:id, and nmdc:was_informed_by declares its range to be nmdc:Activity, the JSONSchema generator would apply the slot_usage rules for nmdc:Activity.nmdc:id to the nmdc:was_informed_by slot.

Though kind of complex, I can at least see a path for support here.  It's worth thinking about the edge cases and @cmungall  might've already done so.  (e.g. do we always only traverse parents?  what if a grandparent has slot_usage for an identifier slot and not the parent?)
As a workaround, if I change nmdc:Activity to use a linkml:pattern in linkml:slot_usage instead of a linkml:structured_pattern (and unfortunately, we need to copy the regex syntax instead of the nice structured_pattern syntax) the validation works as expected, even with the slot_usage declared in the parent nmdc:Activity class.
Activity:
  description: Something that occurs over a period of time and acts upon or with entities;
    it may include consuming, processing, transforming, modifying, relocating, using, or generating entities.
  slots:
    - id
    - was_informed_by
  mappings:
    - prov:Activity
  slot_usage:
    id:
      required: true
      pattern: '^nmdc:act-[a-zA-Z0-9_][a-zA-Z0-9_\-\/\.,]*$'
    was_informed_by:
      required: false
      pattern: '^nmdc:act-[a-zA-Z0-9_][a-zA-Z0-9_\-\/\.,]*$'

So I guess there are two (or possibly three) action items here?

support structured patterns in JSONSchema generator - there is already an open ticket and we've done some work to support structured patterns already, but not quite there yet: https://github.com/linkml/linkml/issues/1557, https://github.com/linkml/linkml/blob/main/tests/test_compliance/test_pattern_compliance.py

decide if we want to support the inference of rules from slot_usage of parent (grandparent) identifier slots.  I'll take this to a linkml dev call.

decide if we want to use the pattern workaround in NMDC in the meantime.

The experimental repo that helped me debug this: https://github.com/sierra-moxon/nmdc-patterns
%  git clone https://github.com/sierra-moxon/nmdc-patterns # or fork
%  poetry install
%  cd nmdc-patterns
%  make gen-project
%  poetry run linkml-validate -f yaml -s src/nmdc_patterns/schema/nmdc_patterns.yaml -C WorkflowExecutionActivityCollection examples/Activity-001.yaml

I think the general issue here is: can we force the nmdc-schema, using core LinkML tools, to require that mentioned ids follow the pattern specified in the definition of the id for the mentioned id class?
And at what cost?
I am going to create a test repo to check some of my assumptions too. Hopefully we can make a decision on this by next week's Schema/Metadata meeting.

My next step is to analyze using gen-linkml to materialize structured patterns.

@shreddd  Tagging you in this issue as it pertains to the database discussion. This would be easy in a relational database with a foreign key constraint. In practice for re-iding this has meant we've had to write a bunch of ad hoc mongo scripts to try and cover the gaps in using linkmls existing validation.

@turbomam or @sierra-moxon do you have time to fix the ranges for was_informed_by and was_generated by separate if figuring out how to validate this. Code that @PeopleMakeCulture  is prototyping checks the type and some of the data objects are showing errors b/c was_generated_by values are not of type Activity.

spoke about this at the LinkML dev call today.
we propose a two-pronged approach here:

fix the "structured_pattern" support in JSONSchema generator
add flag to OWL generator to ignore structured patterns when a range constraint consisting of another class is specified.

Then in the NMDC schema, we specify structured patterns and class-range constraints to fully reconcile this.


Passport install key cause "Segmentation fault"

In our Project we use Laravel Passport.
And passport require a generated key and this cause a segmentation fault.
$ php artisan passport:keys
Encryption keys generated successfully.
/bin/bash: line 76:   510 Segmentation fault      (core dumped) php artisan passport:keys

Interesting part is that the command already sending "Encryption keys generated successfully.".
So is the simple output the cause of the seg.fault?

 public function handle(RSA $rsa)
    {
        $keys = $rsa->createKey(4096);

        list($publicKey, $privateKey) = [
            Passport::keyPath('oauth-public.key'),
            Passport::keyPath('oauth-private.key'),
        ];

        if ((file_exists($publicKey) || file_exists($privateKey)) && ! $this->option('force')) {
            return $this->error('Encryption keys already exist. Use the --force option to overwrite them.');
        }

        file_put_contents($publicKey, array_get($keys, 'publickey'));
        file_put_contents($privateKey, array_get($keys, 'privatekey'));

        $this->info('Encryption keys generated successfully.');
    }

Hi @pfaffenrodt, please share your gitlab ci config and what image tag are u using?

I was able to replicate in https://gitlab.com/edbizarro/gitlab-ci-pipeline-php-ci-test/pipelines/31091340
Looking into it

fixed


Create text-editors

add a list of text editors for you to get started. Choose one based on your preference

thanks again this is a nice addition. I already have VS but thank you


Documentation on where and SQL syntax

I might have missed something, but the documentation link for the where keyword did not get me very far.
From what I tested, it seems to work like in GDAL, so this link could be more helpful?
Something that would also be nice is an additional explanation on how to deal with:

booleans (should one use 0/1, true/false, True/False, something else?)
potential None/Null/NaN differences and how to deal with them

I might have missed something, but the documentation link for the where keyword did not get me very far.
From what I tested, it seems to work like in GDAL, so this link could be more helpful?

Indeed, the information in the page currently being linked to isn't up-to-date anymore. It states e.g. that NOT and LIKE are not supported, but a quick test shows that they are.
I also tested some more specific things mentioned on the OGRSQL page (the page you suggest to link to) and you are right that that seems to contain a better and more and up-to-date description of the currently supported syntax.
The reason that page is being linked to is because this is the page being linked to in the relevant gdal C API documentation as well, so I'll log an issue in the gdal issue tracker to suggest the link being changed there as well.
For reference, the script I used to do some validations on the supported syntax:
import pyogrio

url = "https://github.com/theroggy/pysnippets/raw/main/pysnippets/pyogrio/polygon-parcel_31370.zip"
wheres = [
    None,
    "LBLHFDTLT LIKE 'Gras%'",
    "LBLHFDTLT LIKE 'gras%'",
    "LBLHFDTLT ILIKE 'gras%'",
    "LBLHFDTLT NOT LIKE 'Gras%'",
    "LBLHFDTLT != 'Grasklaver'",
    "LBLHFDTLT IN ('Hoofdgebouwen', 'Grasklaver')",
]

for where in wheres:
    df = pyogrio.read_dataframe(url, where=where)
    print(f"\nnb_rows with where: {where}: {len(df)}")
    print(df["LBLHFDTLT"].unique())

Something that would also be nice is an additional explanation on how to deal with:

As a general remark, because we'll be changing the link to point to the OGRSQL page, it will probably be the way to go to add any additional information regarding the syntax to use is added to that page. Because that page is part of the gdal documentation, the way to go to get any changes applied to it is to open an issue in the gdal issue tracker.

booleans (should one use 0/1, true/false, True/False, something else?)

Specifically for this remark: I'm not sure if there is a generic answer to your questions/suggestions for clarification. As you probably know, gdal support a lot of file formats and booleans are not very well defined in general. Many file formats don't even support them at all and then you need to fallback to using 0/1,... I didn't do any testing and I might be wrong, but I think it is likely that the only possible answer will be: it depends on the file format.
So personally I think the best way forward would be if you could do some tests on different file formats regarding booleans. Based on those experiences you could open an issue in the gdal issue tracker to suggest some clarifications, if possible.

potential None/Null/NaN differences and how to deal with them

Because OGRSQL is an sql dialect, the syntax that is being described there in the OGRSQL documentation is to use "IS NULL" and "IS NOT NULL". As far as I know, the distinction between None and Nan is not a thing in SQL and they both map to NULL.

@tfardet the documentation of the where parameter of read_dataframe will be updated in the "stable" documentation once a new version of pyogrio will be released. However, you can already have a preview at the "latest" version with this link:
https://pyogrio.readthedocs.io/en/latest/api.html#pyogrio.read_dataframe
I'll close this issue now, but if you think there are still things to be done on the pyogrio side, feel free to reopen it.

Looks good, thanks for your detailed answers!


Special characters (spaces, quotes, brackets) break auth

We have had several issues with peoples names having quotes and other special characters returning 'Invalid login credentials'
Seems to probably be an escape character problem.

@sirboldilox


[CARBONDATA-1236] Support absolute path without scheme in loading - h…

we should not check for the file type after adding a / in front. this PR will change the logic to first check the file type and then append a / if needed

Can one of the admins verify this patch?

Build Success with Spark 1.6, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/184/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2763/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/carbondata-pr-spark-1.6/693/

LGTM


Make HARK substantially compatible with both Py2 and Py3

This pull request is a first step in making HARK substantially compatible with both Python 2 and Python 3. See commit notes here for more details.
Note that this pull request may be substantially superseded by another PR on the same topic, particularly if the items in the above commit message are addressed.

Quick note: there is a place in that commit message that says "2.6" where it should say "3.6" I'll fix it as soon as I can figure out how to edit commit messages...

Merge of "Installibility" PR made this PR full of conflicts; all the files are now in different places.  Should we close this PR / branch and recreate the work for the new package-ified HARK?

Yes, I think that is the cleanest approach.
On Mon, Jun 25, 2018 at 5:08 PM, Matthew N. White<EMAIL_ADDRESS>wrote:

Merge of "Installibility" PR made this PR full of conflicts; all the files
are now in different places. Should we close this PR / branch and recreate
the work for the new package-ified HARK?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/econ-ark/HARK/pull/162#issuecomment-399985581, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ARCkjRTKNnyUpCLpxYVLzmVn1EG0Jpr3ks5uAPzegaJpZM4Up0aQ
.

@mnwhite Yes, I think that is the cleanest approach. I am closing this PR now, and will send a new pull request likely sometime tomorrow.


fix etcd full backup will always alert when create new shoot

How to categorize this PR?

/area monitoring
/kind enhancement
/priority normal
What this PR does / why we need it:
the KubeEtcdFullBackupFailed will always alert when creating a new shoot. I hope this just alerts when etcdbr_snapshot_latest_revision!=0
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thank you @zjj2wry for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

Fixes https://github.com/gardener/gardener/issues/2894

Thanks for the PR!
/assign @wyb1 @istvanballok
/reviewed ok-to-test

/status author-action

@zjj2wry Thanks for your PR! Ideally, this alert shouldn't be firing at shoot creation, since the first thing etcd-backup-restore does is take a full snapshot of the freshly bootstrapped etcd. If the alert is firing, that probably means that backup sidecar isn't able to take/upload a snapshot of the etcd to the configured object storage bucket (probably due to misconfigured credentials or network issues), which would mean the etcd would be at risk of data loss on possible data corruption.

time() - etcdbr_snapshot_latest_timestamp{job="kube-etcd3-backup-restore",kind="Full",role="main"} > bool 86400 always true when etcd startup, this will alert when etcd restart

@zjj2wry Partially yes, that expression will evaluate to true, but only on fresh etcd start or if full snapshot hasn't been taken for more than a day. We also combine this check with etcdbr_snapshot_required{kind="Full", role="main"} so that the alert is triggered only if a full snapshot is actually required (which evaluates to true when etcd and backup sidecar start, but once full snapshot is uploaded, evaluates to false). So the alert would fire only if full snapshot wasn't taken for 15 minutes, which is the alert evaluation period. Can you please check whether backup sidecar is able to upload snapshots to the configured bucket? Or if you have disabled backups, check the health of the etcd pod. You can see the logs of the backup-restore container for more information regarding the backups being or not being taken.

@zjj2wry can you please comment on the concerns of @shreyas-s-rao?

/close for now due to inactivity, feel free to reopen if you think it is necessary

So the alert would fire only if full snapshot wasn't taken for 15 minutes

We currently do a full backup every 24 hours. If etcd is restarted, will it be backed up immediately? or wait 24h?

for now due to inactivity, feel free to reopen if you think it is necessary
can you help reopen this, seems I do not have permissions. I am on vacation last week because of China National Day

@shreyas-s-rao this alert will trigger when ETCD restart, would you like to verify it?

We currently do a full backup every 24 hours. If etcd is restarted, will it be backed up immediately? or wait 24h?

I think it will wait till 24h for the full backup. https://github.com/gardener/etcd-backup-restore/blob/master/pkg/server/backuprestoreserver.go#L187-L231

We currently do a full backup every 24 hours. If etcd is restarted, will it be backed up immediately? or wait 24h?

I think it will wait till 24h for the full backup. https://github.com/gardener/etcd-backup-restore/blob/master/pkg/server/backuprestoreserver.go#L187-L231

tks, I will receive an alert when ETCD restarts in my env.

@zjj2wry I'm guessing the etcd restart takes more than 15 minutes, due to which prometheus isn't able to scrape etcdbr_ metrics for more than 15 minutes, which triggers the alert. The alert wouldn't fire immediately on etcd restart.

@zjj2wry can you confirm this?

@zjj2wry I'm guessing the etcd restart takes more than 15 minutes, due to which prometheus isn't able to scrape etcdbr_ metrics for more than 15 minutes, which triggers the alert. The alert wouldn't fire immediately on etcd restart.

why 15 minutes? Where is configured for 15 minutes

@zjj2wry FYI

Where is configured for 15 minutes

The for field here specifies how long the alert condition has to be true before actually firing an alert for the rule.

the backup job will start after 24h?

No. The first backup will be taken conditionally as soon as the sidecar starts, based on the following policy: "if there has NOT been a full snapshot in the last 24 hours, take a full snapshot. Else, schedule the next full snapshot according to the given cron schedule (passed to the etcdbrctl command via the command line parameter --schedule)". The alert is also configured to use the etcdbr_snapshot_required metric, which specifies whether a snapshot is actually required at that moment or not.
For a fresh etcd, as soon as the etcd pod is up, an initial full snapshot is taken, and the next full snapshot is configured according to the cron schedule that has been set. As soon as the full snapshot is taken, etcdbr_snapshot_required is set to false, until etcd receives some writes/updates (PUT or DELETE), after which etcdbr_snapshot_required is set to true.
In other words, this alert will only fire if there has been no full snapshot for the past 24 hours and etcd has received some new data which has not been backed up yet. So if the alert is firing for you on etcd startup, that means the backup sidecar isn't able to upload a snapshot to the specified backup storage bucket. Can you please confirm this? You may refer to the etcd-main-0 pod's backup-restore container logs, as well as the specified storage bucket for more insight into the backups.

@shreyas-s-rao
delete etcd pod, search the expr will true

the last_timestamp_full_backup is 0

this is our backup-restore log, seems not doing full backup
➜  ~ k logs -f etcd-main-0 -n shoot--staging--3c107348 -c backup-restore
time="2020-10-19T10:06:31Z" level=info msg="etcd-backup-restore Version: v0.9.0"
time="2020-10-19T10:06:31Z" level=info msg="Git SHA: 105deb66"
time="2020-10-19T10:06:31Z" level=info msg="Go Version: go1.12.7"
time="2020-10-19T10:06:31Z" level=info msg="Go OS/Arch: linux/amd64"
time="2020-10-19T10:06:31Z" level=info msg="defragmentationSchedule: 14 19 */3 * *\netcdConnectionConfig:\n  caFile: /var/etcd/ssl/ca/ca.crt\n  certFile: /var/etcd/ssl/client/tls.crt\n  connectionTimeout: 5m0s\n  endpoints:\n  - https://etcd-main-local:2379\n  keyFile: /var/etcd/ssl/client/tls.key\nrestorationConfig:\n  embeddedEtcdQuotaBytes:<PHONE_NUMBER>\n  initialAdvertisePeerURLs:\n  - http://localhost:2380\n  initialCluster: default=http://localhost:2380\n  initialClusterToken: etcd-cluster\n  maxFetchers: 6\n  name: default\n  restoreDataDir: /var/etcd/data/new.etcd\nserverConfig:\n  port: 8080\n  server-cert: /var/etcd/ssl/server/tls.crt\n  server-key: /var/etcd/ssl/server/tls.key\nsnapshotterConfig:\n  deltaSnapshotMemoryLimit: 104857600\n  deltaSnapshotPeriod: 5m0s\n  garbageCollectionPeriod: 12h0m0s\n  garbageCollectionPolicy: LimitBased\n  maxBackups: 7\n  schedule: 59 17 * * *\nsnapstoreConfig:\n  container: \"\"\n  maxParallelChunkUploads: 5\n  prefix: shoot--staging--3c107348--849357e8-4900-4c1d-9f37-611e1426e9ac/etcd-main/v1\n  provider: GCS\n  tempDir: /var/etcd/data/temp\n"
time="2020-10-19T10:06:31Z" level=info msg="Creating snapstore from provider: GCS" actor=backup-restore-server
time="2020-10-19T10:06:31Z" level=info msg="Creating snapshotter..." actor=backup-restore-server
time="2020-10-19T10:06:31Z" level=info msg="Setting status to : 503" actor=backup-restore-server
time="2020-10-19T10:06:31Z" level=info msg="Registering the http request handlers..." actor=backup-restore-server
time="2020-10-19T10:06:31Z" level=info msg="Starting the http server..." actor=backup-restore-server
time="2020-10-19T10:06:31Z" level=info msg="Probing etcd..." actor=backup-restore-server
time="2020-10-19T10:06:31Z" level=info msg="Starting HTTP server at addr: :8080" actor=backup-restore-server
time="2020-10-19T10:06:31Z" level=info msg="TLS enabled. Starting HTTPS server." actor=backup-restore-server
time="2020-10-19T10:06:31Z" level=info msg="Responding to status request with: New" actor=backup-restore-server
time="2020-10-19T10:06:31Z" level=info msg="Received start initialization request." actor=backup-restore-server
time="2020-10-19T10:06:31Z" level=info msg="Updating status from New to Progress" actor=backup-restore-server
time="2020-10-19T10:06:31Z" level=info msg="Changed handler state." actor=backup-restore-server
time="2020-10-19T10:06:31Z" level=info msg="Waiting for acknowledgment..." actor=backup-restore-server
time="2020-10-19T10:06:31Z" level=info msg="Validation failBelowRevision: " actor=backup-restore-server
time="2020-10-19T10:06:31Z" level=info msg="Validation mode: sanity" actor=backup-restore-server
time="2020-10-19T10:06:31Z" level=info msg="Checking for data directory structure validity..."
time="2020-10-19T10:06:31Z" level=info msg="Responding to status request with: Progress" actor=backup-restore-server
time="2020-10-19T10:06:31Z" level=info msg="Checking for revision consistency..."
time="2020-10-19T10:06:32Z" level=info msg="Data directory valid."
time="2020-10-19T10:06:32Z" level=info msg="Successfully initialized data directory for etcd." actor=backup-restore-server
time="2020-10-19T10:06:32Z" level=info msg="Responding to status request with: Successful" actor=backup-restore-server
time="2020-10-19T10:06:32Z" level=info msg="Updating status from Successful to New" actor=backup-restore-server
time="2020-10-19T10:06:34Z" level=info msg="Applied watch on etcd from revision: 1517112" actor=snapshotter
time="2020-10-19T10:06:34Z" level=info msg="Taking delta snapshot for time: 2020-10-19 10:06:34.845223308 +0000 UTC" actor=snapshotter
time="2020-10-19T10:06:34Z" level=info msg="Uploading snapshot of size: 1214787, chunkSize: 5242880, noOfChunks: 1"
time="2020-10-19T10:06:34Z" level=info msg="Triggered chunk upload for all chunks, total: 1"
time="2020-10-19T10:06:34Z" level=info msg="No of Chunks:= 1"
time="2020-10-19T10:06:34Z" level=info msg="Uploading chunk with offset : 0, attempt: 0"
time="2020-10-19T10:06:34Z" level=info msg="Received chunk result for id: 1, offset: 0"
time="2020-10-19T10:06:34Z" level=info msg="Received successful chunk result for all chunks. Stopping workers."
time="2020-10-19T10:06:34Z" level=info msg="All chunk uploaded successfully. Uploading composite object."
time="2020-10-19T10:06:34Z" level=info msg="Composite object uploaded successfully."
time="2020-10-19T10:06:34Z" level=info msg="Total time to save delta snapshot: 0.115302 seconds."
time="2020-10-19T10:06:34Z" level=info msg="Successfully saved delta snapshot at: Backup-1603043940/Incr-01517112-01518201-1603101994" actor=snapshotter
time="2020-10-19T10:06:34Z" level=info msg="Setting status to : 200" actor=backup-restore-server
time="2020-10-19T10:06:34Z" level=info msg="Starting snapshotter..." actor=backup-restore-server
time="2020-10-19T10:06:34Z" level=info msg="Will take next full snapshot at time: 2020-10-19 17:59:00 +0000 UTC" actor=snapshotter
time="2020-10-19T10:11:34Z" level=info msg="Taking delta snapshot for time: 2020-10-19 10:11:34.965304551 +0000 UTC" actor=snapshotter
time="2020-10-19T10:11:34Z" level=info msg="Uploading snapshot of size: 1283321, chunkSize: 5242880, noOfChunks: 1"
time="2020-10-19T10:11:34Z" level=info msg="Triggered chunk upload for all chunks, total: 1"
time="2020-10-19T10:11:34Z" level=info msg="No of Chunks:= 1"
time="2020-10-19T10:11:34Z" level=info msg="Uploading chunk with offset : 0, attempt: 0"
time="2020-10-19T10:11:35Z" level=info msg="Received chunk result for id: 1, offset: 0"
time="2020-10-19T10:11:35Z" level=info msg="Received successful chunk result for all chunks. Stopping workers."
time="2020-10-19T10:11:35Z" level=info msg="All chunk uploaded successfully. Uploading composite object."
time="2020-10-19T10:11:35Z" level=info msg="Composite object uploaded successfully."
time="2020-10-19T10:11:35Z" level=info msg="Total time to save delta snapshot: 0.173555 seconds."
time="2020-10-19T10:11:35Z" level=info msg="Successfully saved delta snapshot at: Backup-1603043940/Incr-01518202-01519428-1603102294" actor=snapshotter
time="2020-10-19T10:11:35Z" level=info msg="Stopping delta snapshot..." actor=snapshotter
time="2020-10-19T10:11:35Z" level=info msg="Resetting delta snapshot to run after 5m0s." actor=snapshotter

@zjj2wry I see you're using an older version of Gardener, which uses etcd-backup-restore v0.9.0, which had a bug in metric initialization logic. This has been fixed here, and is part of etcd-backup-restore v0.10.0. Please consider upgrading your Gardener setup to use this fix.

@zjj2wry I see you're using an older version of Gardener, which uses etcd-backup-restore v0.9.0, which had a bug in metric initialization logic. This has been fixed here, and is part of etcd-backup-restore v0.10.0. Please consider upgrading your Gardener setup to use this fix.

got it, I will close this issue.  thank you very much :))


Add filterOptions.renderValue

Adds option to control display of items in filter controls for checkbox, multiselect and select filter types.

Coverage decreased (-0.3%) to 76.196% when pulling 576cc21615f1afa38b5d0669dea5abe27f0f0940 on Legogris:add-filterOptions-renderValue into 12b2d2baadd2fe4815ea04fe9f9240a1687876d7 on gregnb:master.

@gregnb

Thank you for putting this together and sorry it has taken so long for a review. This appears to be pretty useful and looks good other than the two small comments I made, though I've gone ahead and made the fixes. I've merged this into the v3 branch which will hopefully release later this month.


[feature] add the great GroundingDINO into huggingface

Hi,
Would you add your model in the huggingface , not just a demo, but also an API to use?
Thanks.

Hi, Would you add your model in the huggingface , not just a demo, but also an API to use?
Thanks.

Sure, we plan to implement Grounding-DINO to huggingface recently! Stay tuned!


fix(UForm): success message not rendered

Scope
What's changed:

We now correctly render the success message as HTML. HTML is purified before render for security.

Potential Risks / Drawbacks

N/A

Review Notes / Questions

N/A

Fixes: #32

LGTM


feat: support edge runtimes

This PR makes the Node SDK compatible with edge runtimes including Vercel Edge functions. The main changes include:

Replace Axios with a native fetch wrapper
Replace jsonwebtoken with jose as jsonwebtoken uses Node APIs like Crypto which aren't supported by the edge runtime

Note: This could use a fair amount of testing, especially around error handling. Here's an repo with a test Next 13 app which has an edge function to test against: https://github.com/knocklabs/next-edge-test. You can also use npx ts-node test.ts to run a typescript script and run the client directly.
Post-release: Bump minor version and announce breaking change in release notes
Resolves #38

Taking another look 👀

Getting this error in production for v0.6.0, and am unable to debug it because the error message isn’t clear. No errors for 0.5.1.

Code:

Hey @heymartinadams, thanks for reporting this issue, we'll look into it this week.
For ease of tracking it, could you open this as a separate issue in this repo? Also, it'd be big help if you could include that code snippet as text instead of an image.


Removed rules keep re-appear

This is an UI error makes already deleted rules appear in the Defaults rule list.
Restart the application can resolve this issue.
Reproduce steps:

Create a rule in Defaults tab.
Delete the rule by clicking the X on the right.
Create another rule.

OS version: 22631.3447

Thanks for the report, I've patched the bug!


Social login and authentication mobile ios

Add social authentication options including - Apple, Microsoft, Facebook, and Google
in config you need add:
SOCIAL_LOGINS:
ENABLED: true
APPLE_SIGNIN_ENABLED: true
MICROSOFT:
ENABLED: true
APP_ID: 'id'
GOOGLE:
ENABLED: true
GOOGLE_PLUS_KEY: 'id.apps.googleusercontent.com'
CLIENT_ID: 'id.apps.googleusercontent.com'
FACEBOOK:
ENABLED: true
FACEBOOK_APP_ID: 'id'
CLIENT_TOKEN: 'id'

in config you need add:
SOCIAL_LOGINS:
ENABLED: true
APPLE_SIGNIN_ENABLED: true
MICROSOFT:
ENABLED: true
APP_ID: 'id'
GOOGLE:
ENABLED: true
GOOGLE_PLUS_KEY: 'id.apps.googleusercontent.com'
CLIENT_ID: 'id.apps.googleusercontent.com'
FACEBOOK:
ENABLED: true
FACEBOOK_APP_ID: 'id'
CLIENT_TOKEN: 'id'

added SocialSignView_Previews

@eyatsenkoperpetio i see in config we have Apple under SOCIAL_LOGINS
like this
SOCIAL_LOGINS:
            ENABLED: true
            APPLE_SIGNIN_ENABLED: true

how about remove SOCIAL_LOGINS and make separate for Apple?
in this way we dont have to relay on SOCIAL_LOGINS dictionary.
Also can you update ConfigTests with the new dictionary and add test cases there?

@saeedbashir please take a look into this.

@saeedbashir  Apple Signin throughing an error on click for me. What'm I missing here?

It seems Apple Sign In capability entitlement is missing and thats why Apple Sign in isn't working
added but,  OpenEdx will not use social auth

@eyatsenkoperpetio I've discussed the matter with @saeedbashir and seems like the issue was with the implementation and is now fixed in your recent commits.

@eyatsenkoperpetio Tests are also failing. Please take a look into it as well.


Document properties are not set

I try to set document properties, but none of them shows up when I open the document in Microsoft Word.
document.BuiltinDocumentProperties.Creator = "foo";
document.BuiltinDocumentProperties.Description = "foo";
document.BuiltinDocumentProperties.Title = "foo";
document.BuiltinDocumentProperties.Creator = "foo";
document.BuiltinDocumentProperties.Keywords = "foo";

Did you save?

public static void Example_AdvancedWord(string folderPath, bool openWord) {
    Console.WriteLine("[*] Creating advanced document");
    string filePath = System.IO.Path.Combine(folderPath, "AdvancedDocument.docx");
    using (WordDocument document = WordDocument.Create(filePath)) {
        // lets add some properties to the document
        document.BuiltinDocumentProperties.Title = "Cover Page Templates";
        document.BuiltinDocumentProperties.Subject = "How to use Cover Pages with TOC";
        document.BuiltinDocumentProperties.Creator = "foo";
        document.BuiltinDocumentProperties.Description = "foo";
        document.BuiltinDocumentProperties.Title = "foo";
        document.BuiltinDocumentProperties.Creator = "foo";
        document.BuiltinDocumentProperties.Keywords = "foo";

        document.Save(openWord);
    }
}

This seems to work

It works when saving to a file, but not when saving to a stream:
var wordDocument = WordDocument.Create();

document.BuiltinDocumentProperties.Title = "Cover Page Templates";
document.BuiltinDocumentProperties.Subject = "How to use Cover Pages with TOC";
document.BuiltinDocumentProperties.Creator = "foo";
document.BuiltinDocumentProperties.Description = "foo";
document.BuiltinDocumentProperties.Title = "foo";
document.BuiltinDocumentProperties.Creator = "foo";
document.BuiltinDocumentProperties.Keywords = "foo";

var stream = new MemoryStream();
wordDocument.Save(stream);


Issues of exploit

I'm going to apologize, I had high hopes for this since I read some of your articles and correct me if I missed something.
My issue is that I could very easily see something like this becoming a popularity contest or, even worse; as a way of disenfranchising people or a group of people.  Guns aren't the internet and they are not ssl certs.  Everyone on the internet is devoid of race, religion, sexual identity, etc until they let it be known.
I don't see anything in this that would protect against say a racist local community leader and their 4 friends from being the only shooter network in a small town.  This would give them the power to deny anyone of color a firearm.  This isn't a new thing, there was a point in time where african americans were denied firearms.  An example from history would be MLK being denied after he requested a permit because of the alarming number of death threats he was receiving.
As much as I'd love to believe there are no motivated racist, sexist, and/or homophobic gun owners that's just not the case and it never will be.  I could see this system being easily gamed by groups of people with ill intent.
I also don't agree with the loner comment, some people are loners in one group, but thrive in others.  It's just not their tribe.  I grew up in the suburbs and felt very outside of the community, but found other communities of like minded people and that's not a unique experience.  My community happened to be spread across continents instead of blocks.  As someone working in tech and with a creative community, you have to have encountered hundreds of people like that.
Part of the reason I like the 2nd amendment is that everyone can buy them, that doesn't mean everyone should buy them.  I just don't think this is the answer.

I'm don't think it follows from the proposal that only one group in an area could get licensed from a central authority, though. What are you seeing in here that you think would stop, say, a group of black gun owners in Ferguson from coming together and forming a group, despite what local racists might want?

What are you seeing in here that you think would stop, say, a group of black gun owners in Ferguson from coming together and forming a group, despite what local racists might want?

What I see is a structural problem.  How are poor people going to be able to learn how to jump through all these hoops, gain trust in a network or make their own, keep ahead of everything required to retain that trust, etc?  This all seems to take time, energy, and money, all of which are in short supply for many people.  Many folks have a hard time connecting to people in their own community, let alone finding a virtual community somewhere else.  These people would be disenfranchised not because of their ability to be responsible gun owners, but by their lack of resources and connections.  Think homeless people, or immigrants, or people who never can get to the library to use the internet because they work 3 jobs.
This barrier to entry is also actually much higher than you think because once you get your firearms, you are in constant jeopardy of becoming a felon because of somebody else in your network being a bad actor coupled with some inattention, if I understand your proposal right.  Like it sounds like many people would look at this and say "this seems like a great way to set me up to get arrested.  I guess I better not."  Which is great for the people who want to kill Gun Culture, but I think that it's wrong to try to discourage the exercise of a civil right.  For instance, I would be in jeopardy of a felony because I let my son go shoot his rifle outside at our cabin while I sit inside and read, because he's not supervised.  Or I couldn't let him go hunting on his own.
Another problem is that of timeliness.  I haven't read through all the issues yet, but if a hypothetical cousin were to have problems with an ex threatening her, I would want her to be able to acquire a firearm as soon as she were threatened.  Time is of the essence here, because when the threat is issued, it's not unreasonable to expect that it would be carried out pretty soon.  It seems like this network requirement is going to, again, be a significant barrier for them being able to go to the store and get a firearm in time for her to use it against the immanent threat, or be lent one by me or a friend legally.
On the other hand, if this reputation system were all actually advisory for firearms transactions, rather than a legal requirement with felonies on the line, I'd be all for this.  Like if you don't have a network card, then people doing private transactions might be more inclined to go do a transfer through an FFL or decline to sell, but if you did have one, then they could sell to you with less fear just like they do with CCLs now.  FFLs could use it instead of a NICS check, like some states do with CCLs.  This would be less like the Thawte Web Of Trust ecosystem, and more like the antispam reputation systems.  I would love for there to be a good way to know that the person I'm transferring a firearm to is not a prohibited or dangerous person.  I have some ideas on that, but this response is supposed to be about barriers to entry, and I've already made this too long of a response.  :-)


[BEAM-155] Use only WindowFn in TriggerTester

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[x] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[x] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[x] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[x] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

This change is preparatory for separating trigger syntax from implementation.
Previously, the whole WindowingStrategy was passed in, but not used. Since the tester is really a test of the state machine, it will be moved to runners-core alongside the trigger implementation. The requirement to provide a WindowingStrategy with the original syntax is extraneous.

R: @bjchambers
BTW I know that this is helpful because I am working a few commits ahead.

LGTM


Fix for issue #754.

Fixed thread safety issue in LargePoolArray.cs. Garbage collector can be called on another thread after the x.IsAlive test and before buffer is assigned. This can lead to a null pointer exception as x.Target will be null after the garbage collector has freed it.
(Refer to https://stackoverflow.com/questions/1687045/thread-safety-of-weakreference for more info.)
Fixes #754
Description of the changes:
Add a test to see if buffer is null before using it.

Before submitting a Pull Request:

[x] I reviewed CONTRIBUTING.md
[x] I built my changes locally
[x] I ran the unit tests
[x] I ran the functional tests with a device
[x] I ran the performance tests with a device

I tested changes on:

[x] Windows
[ ] Linux

Manually tested in application where issue was occurring. Confirmed fixed in that application.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: robharrisonuk sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

\azp run

/azp run

Thanks @robharrisonuk, this looks good.


iOS: Can no longer tap on title of YouTube video to open in YouTube app

Previously if I had subscribed to a YouTube feed in NewsBlur I could tap on the title of the YouTube video to open it in the YouTube app. Now I have to tap, hold and choose “Open Link” to get this to happen.

Tapping on a YT title opens the in app browser for me. Did it ever open in the YT app?

In previous NewsBlur iOS versions (for years), tapping the title of the video opened the YouTube app (not the in-app browser). You can still do this if you tap and hold and choose 'open link', but now single-tapping does nothing. Tapping the icon of the channel does open the channel in the in-app browser.
This could have been a coincidental change on the YouTube side, not necessarily something that changed in the iOS app.

NewsBlur doesn't have any visibility into how taps on a YouTube IFRAME is handled; that's something handled by YouTube. So I'll close this.


[Backport to 1.2] fix missing dependency:commons-lang3 (#350)

Description
Backporting PR that added the commons-lang3. This was added in order to fix a missing dependency issue that appeared in 1.3.0. This same issue is now appearing in 1.2.4 opensearch build process.
Issues Resolved
https://github.com/opensearch-project/anomaly-detection/issues/359
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

This same issue is now appearing in 1.2.4 opensearch build process.

Can you confirm if the missing dependency issue happens on 1.2.4 branch?
1.2.4 can build successfully locally for me and I see the latest commit passed CI workflow https://github.com/opensearch-project/anomaly-detection/runs/4800168307?check_suite_focus=true

Checked job-scheduler 1.2 branch, they have upgraded com.cronutils:cron-utils to 9.1.6 https://github.com/opensearch-project/job-scheduler/pull/118
But the job-scheduler-spi 1.2.4 maven snapshot not built from latest code. So I can build locally and the github CI workflow can pass. @peternied can you help rebuild job-scheduler-spi 1.2.4 snapshot and upload to maven?

LGTM. Make sure CI can pass after infra team upload latest job-scheduler-spi 1.2.4 snapshot to maven.

There's a chicken and egg problem where the distribution can't build without AD, so it won't upload the job-scheduler snapshot to maven.  I PRed https://github.com/opensearch-project/opensearch-build/pull/1462, see https://github.com/opensearch-project/opensearch-build/issues/1463 for a description of the bug.

@amitgalitz You'll need to fix DCO, please -s.

@amitgalitz You'll need to fix DCO, please -s.

I did signoff it off with that flag. Since its a backport PR its failing on Yaliangs signature. The failures is because Yaliang's email is set to private so the signature and the email github is accepting doesn't match. It seems like the way to fix it is to make the email public. I tried recommiting it after running this command (git commit --amend --signoff) and it didn't help. Do you suggest ignoring DCO for this issue or for me to make a new PR that isn't a backport but simply the exact same changes again (I didn't want to do this originally to not mess with commit history)

Btw, if you run into future problems, you can try something like git rebase --signoff HEAD~2, which should add the "Signed off by <>" message to the last 2 commits, for example

The 1.2.4 snapshot build completed - I've retriggered the Build and Test CI check

The 1.2.4 snapshot build completed - I've retriggered the Build and Test CI check

Thank you Peter!

Thanks @dblock , I thought we have separate workflow or manual way to build job-scheduler-spi snapshot and upload to maven. Bind all plugins together in workflow will make things complicated. We need 2 PRs to break the circular dependency.


[Feature]: Add backdated Incidents and Maintenance

Is your feature request related to a problem? Please describe.
When I try to add some Incident or Maintenance which Resolved/Completed.
I expect it will be added in Datebare on the date I set up.
But it is adding in Datebare as today's.
Describe the solution you'd like
Example: I have the incident, which was 17.02.23 at 17:00, but I forgot to add it to status page, and when I tried to add it today, it added it as today's
Create:

Result:

Describe alternatives you've considered
Mentioned problem is actual and for Maintenance.
Thank you in advance.
Additional context
No response

Dear @HerrTxbias
Thank you for your work.
I found one defect with the Created Date.
When I try to create some Incident and set Creation Date, it anyway sets the Creation Date automatically.
It set the date which I set when creating the Incident in main configuration of Incident, but in the "Editing incident update" it set present time, and in Client dashboard it shows that it was created at present time.
Create Incident: Attention to Created date

Customer Dashboard: Attention to Created date

In Editing incident update: Attention to Created date

Editing main Incident configuration: The Creation date here is fine

For Maintenance it's the same

@palicepta This has been fixed in #491


gtk: Unsound call to std::str::from_utf8_unchecked

This line calls std::str::from_utf8_unchecked: https://github.com/linebender/druid/blob/057f9f9bbf529c6fd60f00afaa8494fa3a7a4300/druid-shell/src/platform/gtk/clipboard.rs#L68
The given data is directly provided by the library user, thus making it trivial to violate the safety contract of this function.

Fixed by #1820


v3 branch

Hey folks.
I don't have time to finish Ramme v3 at the moment. If anybody want to help, you're more than welcome!

I've been busy as well lately but I'm getting back on it ASAP. Also, let us know if you want to contribute & we'll add you to the Slack channel.

Hi, I'd like to help. Do you have any directions of what I can help ?

We could use a bit more clean up in the code base, structure and if you like you're more than welcome to look at photo upload 👍