[error] Bad input fd in erts_poll()!

When I execute any of provided examples it shows error on terminal screen.
[error] Bad input fd in erts_poll()! fd=0, port=#Port<0.3>, driver=fd, name=0/1
Most simple example to reproduce the error:
Application.ensure_started(:ex_ncurses)

ExNcurses.initscr()
ExNcurses.getch()
ExNcurses.endwin()

I enabled DEBUG option in ex_ncurses.c file and log file contains next lines:
load
ex_newterm
newterm done
ex_poll
enif_select -> 0
ex_read
ex_read calling enif_select
ex_read enif_select returned 0
ex_read returning 10
endwin
rt_stop called DIRECT, polling=0
endwin done

I am having the same issue.

This appears to be on the first use of ExNcurses.getch()
All uses after the first appear to work fine.


HADOOP-17056. shelldoc fails in hadoop-common.

JIRA: https://issues.apache.org/jira/browse/HADOOP-17056
Skip GPG verification in the docker build image.

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/hadoop-multibranch/job/PR-2045/1/console in case of problems.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 22s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  0s
Shelldocs was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ trunk Compile Tests _

+0 :ok:
mvndep
1m 16s
Maven dependency ordering for branch

+1 :green_heart:
shadedclient
16m 21s
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 31s
Maven dependency ordering for patch

+1 :green_heart:
hadolint
0m  5s
There were no new hadolint issues.

+1 :green_heart:
shellcheck
0m  0s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
15m 50s
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
asflicense
0m 32s
The patch does not generate ASF License warnings.

37m 48s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2045/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2045

Optional Tests
dupname asflicense shellcheck shelldocs hadolint

uname
Linux 23cbe5ee7213 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 9fe4c37c25b

Max. process+thread count
314 (vs. ulimit of 5500)

modules
C:  U:

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-2045/1/console

versions
git=2.17.1 maven=3.6.0 shellcheck=0.4.6 hadolint=1.11.1-0-g0e692dd

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Is this message in cosole output relevant?
17:33:05  WARNING: shellcheck needs UTF-8 locale support. Forcing C.UTF-8.
17:33:05  executable '/testptch/hadoop/dev-support/bin/shelldocs' for 'shelldocs' does not exist.

Thank @iwasakims for your comment.
I think this output is not related to the patch. The warning has been there since at least May https://github.com/apache/hadoop/pull/1887#issuecomment-596566303
We should fix it in a separate jira.

Filed https://issues.apache.org/jira/browse/HADOOP-17062 for tracking the issue.

Thank you @iwasakims and @ayushtkn for your review.

I found a typo after committing this.


Possible for Video Playlists?

Hi Swolekat,
I am not so familar with Github and so not quite sure if my question is a "Issue" or a "Pull Request".
First of all your tool for bringing the YT Title to OBS is quite awesome.
But I wanna kindly ask if it is also possible to show up the video files if your tool is used with a video playlist instead of a music playlist.
I think on using it in a break scenze scenario or stream ended case.
Thanks a lot for letting me know.

Hello, I'm not sure I entirely understand your request.
If you're asking to show the youtube video itself I guess that wouldn't be too hard to do although I'm not sure if another solution exists that might be better.
If you're asking for supporting local files that's probably outside of the scope of the project since it's based on embedding a youtube player.
Oddly enough I did do a similar project for showing random twitch clips here that you might find useful: https://github.com/swolekat/se-widgets/tree/main/continuous-clip-player

Hi,
Thank you for your quick response.
If I understood correctly, you designed your tool for

Playing music YT playlist
Displaying author + title of the current title from the YT playlist
Since it is music, no image is transmitted

I would really like to integrate the tool into the stream because I use video playlists from my own YT channel in certain scenes.
However, I would need the image to be displayed from the YT Playlist (no offline sources), as well as the title and author, of course.
I have spent the whole weekend researching Github, OBS forum and various YouTube guides, but your tool approach seems to be the very best for implementing it.
If you see a possibility, I would be very happy.

Thank you for the quick solution.
It works as intended, but the YouTube API seems to be blocking it. The video loads briefly and then there is an endless loop. It's as if the video can't be buffered properly.
But of course that's not your fault and maybe Google will find a solution.
As a workaround, I'll play the video playlist directly in the local browser and capture the window and use your tool to display the title.
Thank you again.

I found it out. When I uncheck the browser source hardware acceleration ist works perfect.
Just one final question: Is there maybe a command to fade out the scroll bar on the side?
Attach a Sreenshot from the preview of the Source.

@SirBassi can you try adding this custom css in obs and let me know if it works? If it does I'll add it in by default
* { overflow: hidden; }

Yes, this works very perfect.
Everything is running now as I wished as I started to search about this topic.
Absolute amazing your help, I am deeply thankful.


Refactored step 7 & 8 + added first wow moment (publish after first page)

Refactored step 7 & 8 + added first wow moment (publish after first page)

Arjan, please sign the CLA.


Add new RPC endpoint to parse the contact and return the ABI without deploy

Closed in: https://github.com/yeagerai/genlayer-simulator/pull/109


[Bug] Toolbar items are white text on white background on Android sample

Description
The settings and About buttons in the Tool Bar are white and the background color is a slightly different white. This makes it tricky to see the wonderful list of contributors.
I think this is probably fixed in the android resource xml styles.
See screenshot below.
Steps to Reproduce

Run sample on Android
Look very closely at the top right of the screen, it says "Settings" and "About", but they're hard to see

Expected Behavior
Text should be black.
Actual Behavior
Text is white
Basic Information

Version with issue: Current Main

Last known good version: Probably never?

IDE: VS Windows 2019

Platform Target Frameworks:

Android: 9, 10
UWP:

Android Support Library Version:

Nuget Packages:

Affected Devices: PIxel 3a, Samsung T510

Workaround
Squint and move phone really close to face
Reproduction imagery

I bet it's that @sthewissen guy again only testing on iOS...

I bet its that @sthewissen guy again only testing on iOS...

iOS rules the World. We cannot blame him xD

Perhaps this is not a bug, but a difference of design oppinion. Steven knows more about design than me so I'll trust him and
close the issue.


tensorflow.python.framework.errors_impl.InvalidArgumentError: Index out of range using input dim 0; input has only 0 dims 	 [[{{node loss/efficientnet-b0_loss/strided_slice_2}}]]

2020-01-14 11:19:21.012255: W tensorflow/core/framework/op_kernel.cc:1655] OP_REQUIRES failed at strided_slice_op.cc:108 : Invalid argument: Index out of range using input dim 0; input has only 0 dims
2020-01-14 11:19:21.012262: W tensorflow/core/framework/op_kernel.cc:1655] OP_REQUIRES failed at strided_slice_op.cc:108 : Invalid argument: Index out of range using input dim 0; input has only 0 dims
2020-01-14 11:19:21.012287: W tensorflow/core/framework/op_kernel.cc:1655] OP_REQUIRES failed at strided_slice_op.cc:108 : Invalid argument: Index out of range using input dim 0; input has only 0 dims
2020-01-14 11:19:21.012255: W tensorflow/core/framework/op_kernel.cc:1655] OP_REQUIRES failed at strided_slice_op.cc:108 : Invalid argument: Index out of range using input dim 0; input has only 0 dims
Traceback (most recent call last):
File "keras_efficient_transfer_learning_2.py", line 319, in
verbose = 0
File "/home/timmy/anaconda3/envs/tf_gpu_0/lib/python3.7/site-packages/tensorflow_core/python/keras/engine/training.py", line 793, in fit
use_multiprocessing=use_multiprocessing)
File "/home/timmy/anaconda3/envs/tf_gpu_0/lib/python3.7/site-packages/tensorflow_core/python/keras/engine/training_generator.py", line 604, in fit
steps_name='steps_per_epoch')
File "/home/timmy/anaconda3/envs/tf_gpu_0/lib/python3.7/site-packages/tensorflow_core/python/keras/engine/training_generator.py", line 265, in model_iteration
batch_outs = batch_function(*batch_data)
File "/home/timmy/anaconda3/envs/tf_gpu_0/lib/python3.7/site-packages/tensorflow_core/python/keras/engine/training.py", line 1084, in train_on_batch
outputs = self.train_function(ins)  # pylint: disable=not-callable
File "/home/timmy/anaconda3/envs/tf_gpu_0/lib/python3.7/site-packages/tensorflow_core/python/keras/backend.py", line 3567, in call
run_metadata=self.run_metadata)
File "/home/timmy/anaconda3/envs/tf_gpu_0/lib/python3.7/site-packages/tensorflow_core/python/client/session.py", line 1474, in call
run_metadata_ptr)
tensorflow.python.framework.errors_impl.InvalidArgumentError: Index out of range using input dim 0; input has only 0 dims
[[{{node loss/efficientnet-b0_loss/strided_slice_2}}]]

Does anyone see this error before?


Fixed Arbitrary code execution in pyAudioAnalysis

📊 Metadata *
Fixed Arbitrary code execution in pyAudioAnalysis
Bounty URL: https://www.huntr.dev/bounties/1-other-pyAudioAnalysis/
⚙ Description *
pyAudioAnalysis is an open Python library that provides a wide range of audio-related functionalities focusing on feature extraction, classification, segmentation and visualization issues. This package is vulnerable to Arbitrary Code Execution.
💻 Technical Description *
The function load_model() blindly loads a pickle file without any validation making it vulnerable to Arbitrary Code Execution. If the input pickle file is a malicious payload,  create a file remotely.
🐛 Proof of Concept (PoC) *
import pickle
import os
from pyAudioAnalysis import audioTrainTest as aT

class EvilPickle(object):
    def __reduce__(self):
        return (os.system, ('touch HACKED', ))

payload = pickle.dumps(EvilPickle())

with open('MEANS', 'wb') as file:
    file.write(payload)

aT.load_model('')

🔥 Proof of Fix (PoF) *

For subprocess

👍 User Acceptance Testing (UAT)
Applied fix from pickle official fix as explained in here.
https://www.cmi.ac.in/~madhavan/courses/python-2014/docs/python-3.2.1-docs-html/library/pickle.html

@Mik317 I hope this could be used as a sample of the normal usage.

@Mik317 I hope this could be used as a sample of the normal usage.

Congratulations d3m0n-r00t - your fix has been selected! 🎉
Thanks for being part of the community & helping secure the world's open source code.
If you have any questions, please respond in the comments section, or hit us up on Discord. Your bounty is on its way - keep hunting!
Come join us on Discord

Congratulations d3m0n-r00t - your fix has been selected! 🎉
Thanks for being part of the community & helping secure the world's open source code.
If you have any questions, please respond in the comments section, or hit us up on Discord. Your bounty is on its way - keep hunting!
Come join us on Discord


Logging implementation

Coverage decreased (-2.8%) to 82.147% when pulling d2c75cfead02f1f10ed62b0502fb77f7defbcfb9 on logging_implementation into 165f6bfc5177adedda3a11445a814c1e763e8d37 on master.


Document --source-only and add --push-only

The --source-only already works to only build and not deploy. But
sometimes we want to just push and not build. An example of that is
when you want to use Docker to build the project, avoiding the
installation of the whole Ruby environment on your computer.
This PR adds --push-only to add the ability to execute only the
actions related to git and avoid the project build.
No API was broken by this commit, it's a minor change.

@PotHix sorry for the slow reply, this is a great change! One quick question — forgive me, I'm not super familiar with the shell language, but since we're checking if $1 is the flag, will that only check if the flag is in the first argument position? For instance, would ./deploy.sh -n --source-only not be detected as source only?

Yes, that's right, we're using just the first argument. Here is a sample code:
[Gondor tmp] cat > test.sh
echo $1
^C
[Gondor tmp] bash test.sh --test
--test
[Gondor tmp] bash test.sh -a --test
-a

We are using just the first argument. I assumed it was not a problem since we already had [[ $1 = --source-only ]] || main "$@"

Hrm, how difficult would it be to check all arguments for the flag? If we're going to add it to the command documentation, it might be nice to check all the positions for it so people don't get surprised by a push or build when they don't expect it.

It would need some changes to be able to do that in case we want to reuse parse_args. Currently, it does more than just parse args. We could use getopts but it would also add some more code and need some refactoring.
And don't know if it would be a good fit for this PR. The --source-only already works like this for a while, the only difference is that we will now have --push-only as well.

Fair enough, no need for any crazy changes. Thanks for the quick responses!


Compatibility with ember-cli-materialize button components

I am able to achieve full functionality with the template code given in the readme, but swapping out
Add an Image.

with
{{md-btn text='Upload Image' id='upload-image'}}

causes the browse box to no longer appear.  Is this due to an incompatibility with ember-cli-materialize, perhaps?  It doesn't seem to be the fact that it's a component, as I've been able to create a custom component and the upload still works fine.

I just bootsrapped a new app with the following code in a template:
{{#pl-uploader extensions="jpg jpeg png gif" action="/api/images/upload" for="u\
pload-image" when-queued="uploadImage" as |queue features|}}

  {{#if features.drag-and-drop.drag-data}}
    {{#if features.drag-and-drop.drag-data.valid}}
      Drop to upload
      {{else}}
      Invalid
    {{/if}}
    {{else if queue.length}}
    Uploading {{queue.length}} files. ({{queue.progress}}%)
    {{else}}

Upload Images

      {{#if features.drag-and-drop}}
        Drag and drop images onto this area to upload them or
      {{/if}}
      {{md-btn text="Add an Image." id="upload-image"}}

  {{/if}}

{{/pl-uploader}}

And there isn't any problems. Please try to isolate your test cases before reporting :3 Thanks!

I've determined this is a browser compatibility issue.  I did the same as you and created a new app, still with no success.  Then I tried using Firefox, and it works correctly.  Apparently Chromium 41 does not like something with the combination of materialize and plupload.  I don't have enough experience with browsers to take even the first steps towards figuring out why.


Fix import d3 error

src/lasso.js updated to use imported libs (d3-selection and d3-drag) instead of d3 library. This way it is possible to use d3-lasso in a d3 modules based project without the need of installing the whole d3 library.

Thanks!


Offline support

We should think about offline support at some point. This was mentioned by @Rajan in https://github.com/rethinkdb/rethinkdb/issues/5239#issuecomment-167700641 .
The idea is that it will make it a lot easier to build mobile applications on top of Fusion.
As a first simpler step, we could allow mirroring certain data to the client for read-only access.
In a second step, we could hook into our optimistic write infrastructure (that we still need to build, https://github.com/rethinkdb/fusion/issues/42) to allow for syncing back writes once the user gets online again.

Related to #358

yes, puchdb like offline sync is absolutely needed in 2016 for any mobile app platform, please work on this so it can be done with rethinkdb, thanks!

Progressive Web Apps and offline first are gaining momentum. There is real need for fully fledged database capabilities in the Browser that can be used offline, with sync + conflict resolution back to the server when a connection is available again. This could be days or weeks later.
By fully fledged I mean all CRUD operations, so from the user's perspective the app has all the same functionality whether they are online or offline. The Browser database world is unfortunately constrained to IndexedDB, so we need to build on top of that.
My own use case is to enable Clibu the Knowledge Base Web App I'm developing to work offline. Right now it uses MongoDB on the server along with realtime websocket push of updates to the Browser, but it has no offline capabilities. The only option I can see at this point is to use something like Dexie.js along with it's Syncable module, but I can see that being a lot of work.  An end-to-end solution such as RethinkDB + Horizon suggests itself to be far better.
I continue to be surprised that no one has  yet come up with a modern NoSQL package that accomplishes what PouchDB and CouchDB do, clearly there is a now more of a need than ever.

I continue to be surprised that no one has yet come up with a modern NoSQL package that accomplishes what PouchDB and CouchDB do, clearly there is a now more of a need than ever.

This is the point.

https://github.com/hoodiehq/hoodie

@aristidesfl Have you actually used Hoodie and if so how did your project work out.
I personally find the Hoodie website and documentation quite difficult to follow, with no clear explanation about what it actually is.

@nevf I only played with it but the experience was very good. The website however has seen better days I agree. The docs are based on https://readthedocs.org/.
If you jump into their chat you will receive awesome support.

If you're wanting offline sync support you might want to have a look at Superlogin. It's based on Couch/Pouch but adds Node/Express/Passport to do authentication and very feature complete user account management API (if you're not using Passport OAuth).  Great documentation & demo. Includes a nice client side API and an AngularJS wrapper. CouchDb can also used Javascript validation rules stored and replicated as part of a "design document". PouchDb has a plugin to execute these when offline.
For best practice distributed syncing you need a database that supports multi-version concurrnecy control (MVCC) which is what CouchDb and it's replication protocol is designed to do. Like RethinkDB, CouchDb supports a realtime changes feed.  Changes filtering is slow in CouchDb 1.x but CouchDb 2.0 addresses this and also adds a decent query language.

Couldn't agree more with @tohagan. I've been using pouchdb and superlogin for awhile... CouchDB/PouchDB/Superlogin are really awesome!


Add compare link to public maps page

I'd like to get this a little closer to the mockup with placeholder "Left" and "Right" rows, but am also exploring non-table forms in design. @vgeorge would be good to get your feedback on the designs in the ticket.
Closes #68

Updated with fixed left and right sides, modified checkbox handler, and styled:

@vgeorge ready to review. Can you also confirm that you see all of these maps when you visit the page, so we can confirm they are indeed public to all users?

@vgeorge Thanks for the suggestions - I made them after merging this first into the test-compare branch as I wanted to ensure that merging this didn't cause any issues. See: https://github.com/developmentseed/pearl-frontend/pull/96/commits/03a4747fae73766990d8a3dfa31e8fd650d2cd4b


2.8.2 Forge - Latest - ClassNotFound Exception

Seems like your calling some client files at the server when your not suppose to be:
http://pastebin.com/raw/QHQv8dZJ

Thanks, this should be fixed in build 159.


Create a Reusable Service (Tutorial Build a Business Application Using CAP for Java)

Tutorials: https://developers.sap.com/tutorials/cp-cap-java-reusable-service.html
Could not do step 8 (Run and test your application) of the tutorial due to error on sqlite.
Build failed with error:
2022-05-25 10:56:49.238  WARN 2394 --- [           main] ConfigServletWebServerApplicationContext : Exception encountered during context initialization - cancelling refresh attempt: org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'dataSource' defined in class path resource [org/springframework/boot/autoconfigure/jdbc/DataSourceConfiguration$Hikari.class]: Bean instantiation via factory method failed; nested exception is org.springframework.beans.BeanInstantiationException: Failed to instantiate [com.zaxxer.hikari.HikariDataSource]: Factory method 'dataSource' threw exception; nested exception is java.lang.IllegalStateException: Cannot load driver class: org.sqlite.JDBC
Do i missed any configuration step on Business Application Studio ?
Step 6: Deploy the domain model was done sucessfully.
(Database installed and initialized)
Only update i have made was changing the initialization-mode due to Deprecated-message.
Property 'spring.datasource.initialization-mode' is Deprecated: Use 'spring.sql.init.mode' instead.
(Hint: application.yaml file could be updated in the tutorial)
Installed package of sqlite is<EMAIL_ADDRESS>Is there any recommendation for using a special version of sqlite ?
Could not find a solution in the community and the capire documentation.
Thanks for help.
Regards
Jürgen

HI @JuBerndt,
We are in the process of updating the entire Java mission and will publish the changes asap. Will mention the pull request here in this issue once we are done.
Best regards,
Iwona

Hi @JuBerndt,
The dev colleagues are still reviewing the updated content and two new tutorials, so please give us some more time. Will get back to you here.
Best regards,
Iwona

Hi @JuBerndt,
The dev colleagues are still reviewing the updated content and two new tutorials, so please give us some more time to test it with the latest release. Will get back to you here.
Best regards,
Iwona

Hi @JuBerndt,
The issue should be resolved with the update we did yesterday, so I am closing the issue. If you still have questions, feel free to reopen the issue.
Best regards,
Iwona


ensure that use of importFrom in NAMESPACE of nimble-using packages works

A user reports a problem with nimble functions called with nimble:: and without using library(nimble) or require(nimble) - which is required to use Nimble functions inside a package function. This problem disappears when I load Nimble with librray(nimble).
I then get an error telling me that it is impossible to find the "getNimbleOption" function. When ding a traceback() I get the info that this problem arises inside the function init_isDataEnv(). When I do librray(nimble) first, there is no problem.
Looking at the code (e.g. https://rdrr.io/cran/nimble/src/R/BUGS_model.R) I was wondering if getNimbleOption shuld not be replaced throughout by nimble::getNimbleOption.

Ok, so what I am seeing at the moment is that ReferenceClasses, such as modelBaseClass do not have the nimble namespace in their enclosing environment (unlike functions in the nimble package that do have the nimble namespace in their enclosing environment). That seems crazy, but it is what I am seeing. This would explain why getNimbleOption can't be found when a modelBaseClass method such as init_isDataEnv is run because of calls from some package that uses nimble but doesn't load it with library or via Depends.

Sidenote: R6 classes do seem have have the nimble namespace as enclosing environment, which is promising for nCompiler and nimbleModel.

I think we may be able to use the where argument to setRefClass.
But...
help(setRefClass)

 where: for ‘setRefClass’, the environment in which to store the
          class definition.  Should be omitted in calls from a
          package's source code.

Ok, after more investigation:

environment(modelBaseClass) does indeed return the nimble namespace, which makes sense.

We dynamically create the generated reference class such that it is in the global environment (by using the where argument).

help(setRefClass) indicates that:
The environment of a method in a reference class is the object
itself, as an environment. This allows the method to refer
directly to fields and other methods, without using the whole
object and the ‘"$"’ operator. The parent of that environment is
the namespace of the package in which the reference class is
defined. Computations in the method have access to all the objects
in the package's namespace, exported or not.

but that doesn't help us because the reference class is defined at the user level. So this issue does indeed seem to be the same issue discussed in NCT issue 176.

This came up again in a user query. One thing I'm confused about is why getNimbleOption is not found when called from an object of a reference class (such as modelBaseClass) defined in the nimble namespace rather than reference classes we define on the fly for a user. In any event, given we need to generate reference classes, I don't think solving my confusion would change anything.


Support loading domain bridge settings from multiple yaml files

I have just generated conflicts after merging https://github.com/ros2/domain_bridge/pull/63, I will resolve them ...


Allow for duplicate indicators which "inherit" from other indicators

Some indicators are 99% the same as others, but still need some differences. Implement a way for indicators to "inherit" from others and only specific fields that need to be different.

This hasn't been pursued and is a thorny problem. I wonder if this can be handled in a manual, non-technical way, by instructing translators to copy/paste translations from one indicator onto any duplicate indicators.

I'll go ahead and close this, since it has not come up, and translators are handling it on their own.


[REMOVE]: NODE MODULES FROM EXERCISE TRACKER MERN PROJECT ❌

Description

The issue is about removing node_modules from Exercise Tracker MERN Stack Project.
The node_modules itself weighs more than 87mb.
There no need to have node_modules, since the application has proper package.json file to install the dependencies whenever the user wants.
Already our repository is exceeding 1.39gb, we need to remove these types space occupiers otherwiser the repository size will even be increased.

Hey there @MohitGupta121, assign this issue to me to make the work done.


Appfile: git recommandation

Why is Appfile recommended to be commited to git? I noticed it contains my apple_id, so it makes no sense at all to commit it as it is. Though the team_id could be commited.
Is there a way to split this file? As every team member has a different Apple ID.
In my case, app_identifier makes no sense too because I have 33 bundle identifiers for the same project. Can this be omitted?
Environment
Please run fastlane env and copy the output below. This will help us help you :+1:
If you used --capture_output option please remove this block - as it is already included there.
✅ fastlane environment ✅
Stack

Key
Value

OS
10.11.6

Ruby
2.0.0

Bundler?
true

Git
git version 2.9.3 (Apple Git-75)

Installation Source
/Users/Iulian/.gems/bin/fastlane

Host
Mac OS X 10.11.6 (15G1004)

Ruby Lib Dir
/Users/Iulian/.rbenv/versions/2.0.0-p353/lib

OpenSSL Version
OpenSSL 1.0.2e 3 Dec 2015

Is contained
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
8.1

System Locale

Variable
Value

LANG

LC_ALL
en_US.UTF-8
✅

LANGUAGE

fastlane gems

Gem
Version
Update-Status

credentials_manager
0.16.2
✅ Up-To-Date

fastlane_core
0.56.0
✅ Up-To-Date

spaceship
0.37.0
✅ Up-To-Date

cert
1.4.4
✅ Up-To-Date

deliver
1.15.0
✅ Up-To-Date

frameit
3.0.0
✅ Up-To-Date

gym
1.12.0
✅ Up-To-Date

sigh
1.11.2
✅ Up-To-Date

match
0.11.0
✅ Up-To-Date

pem
1.4.0
✅ Up-To-Date

pilot
1.12.0
✅ Up-To-Date

produce
1.3.0
✅ Up-To-Date

scan
0.14.1
✅ Up-To-Date

screengrab
0.5.6
✅ Up-To-Date

snapshot
1.16.3
✅ Up-To-Date

supply
0.7.1
✅ Up-To-Date

fastlane
1.109.0
✅ Up-To-Date

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

bundler
1.13.6

CFPropertyList
2.3.3

i18n
0.7.0

json
1.8.3

minitest
5.9.1

thread_safe
0.3.5

tzinfo
1.2.2

activesupport
<IP_ADDRESS>

public_suffix
2.0.4

addressable
2.5.0

babosa
1.0.2

colored
1.2

highline
1.7.8

commander
4.4.0

security
0.1.3

credentials_manager
0.16.2

excon
0.54.0

gh_inspector
1.0.2

multi_json
1.12.1

plist
3.2.0

rubyzip
1.1.7

terminal-table
1.4.5

fastlane_core
0.56.0

multipart-post
2.0.0

faraday
0.10.0

unf_ext
<IP_ADDRESS>

unf
0.1.4

domain_name
0.5.20161021

http-cookie
1.0.3

faraday-cookie_jar
0.0.6

faraday_middleware
0.10.1

fastimage
1.6.8

multi_xml
0.5.5

claide
1.0.1

dotenv
2.1.1

mini_magick
4.5.1

rouge
1.11.1

xcpretty
0.2.4

net-ssh
3.2.0

net-sftp
2.1.2

krausefx-shenzhen
0.14.11

slack-notifier
1.5.1

xcpretty-travis-formatter
0.0.4

jwt
1.5.6

little-plugger
1.1.4

logging
2.1.0

memoist
0.15.0

os
0.9.6

signet
0.7.3

googleauth
0.5.1

httpclient
<IP_ADDRESS>

hurley
0.2

mime-types-data
3.2016.0521

mime-types
3.1

uber
0.0.15

representable
2.3.0

retriable
2.1.0

google-api-client
0.9.20

terminal-notifier
1.7.1

word_wrap
1.0.0

xcode-install
2.0.9

nanaimo
0.2.2

xcodeproj
1.4.1

generated on: 2016-11-17

@revolter i just have "demo.app" in all my Appfiles :D - and set app_identifier on the other tools directly like match, deliver....
about the apple_id - we use one "fastlane" apple-id accross all devs. - but you can also set it to a dummy account, and set the account name on the tools - like with app_id.
deliver(
  username<EMAIL_ADDRESS>  app_identifier: "my.app.id"
)

you can also use ".env" files. as described here: https://github.com/fastlane/fastlane/blob/master/fastlane/docs/Advanced.md#environment-variables
e.g. if you set DELIVER_USERNAME in an .env file - you can totally ommit the username param.
and then just add the .env file to .gitignore - and every dev gets his own .env file.
does that help?

Immensely, this should be in the docs in a section named something like "Dealing with multiple apple ids/bundle identifiers".
Though, can apple id and bundle identifier be removed safely from that file?

@revolter  i am not sure - just try it.
let me know if you found a solution for your issue - and please close the issue if so.

Seems to work. I'll reopen if anything comes up. Thanks!

Just noticed that I'll have to use:
<EMAIL_ADDRESS><EMAIL_ADDRESS>
which is a bit of an overkill. Isn't there a global environment variable for the username that will be used by all the commands?


Implement state-of-the-art MIP models for lexicographic order

Looks like only one inequality is enough to encode a lexicographic inequality, for binary variables at least.
<EMAIL_ADDRESS>

Other improvements, for integer variables: orbitope constraints.
https://github.com/MiniZinc/libminizinc/blob/master/share/minizinc/std/fzn_lex_chain_lesseq_orbitope.mzn


Multibyte characters are displayed out of the box when entered with non default zoom level

VS Code Version: Version: 1.56.0-insider (0310f02dc5d834bb3a7cc421ea5374aec8d011f1)
OS Version: Windows_NT x64 10.0.19042

Steps to Reproduce:

Open Editor
Zoom In (Ctrl +)
Type Japanese by using Japanese IME

Does this issue occur when all extensions are disabled?: Yes

https://user-images.githubusercontent.com/1955233/115997450-17980300-a61e-11eb-93b9-fec336ef3f05.mp4
~ok: Version: 1.55.2 (3c4e3df9e89829dce27b7b5c24508306b151f30d)~
~ng: Version: 1.56.0-insider (0310f02dc5d834bb3a7cc421ea5374aec8d011f1)~

From my testing I think this issue is also fixed by https://github.com/microsoft/vscode/pull/139394


Fix panic on UserController

User controller could panic on cluster deletion due to accessing a nil
reference of cluster.Name within the set. Non-exitent clusters now will
not be added to the map.

lgtm

lgtm


그냥 구경이나 하시라고

이 풀리퀘는 내일 자동 폭파됩니다.

This change is

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable


[FLINK-6575] Disable tests on Windows that use HDFS

This PR disables all tests on Windows that rely on HDFS.

This looks good! +1, merging ...

One question: I'm curious how the scan for tests that use HDFS was done?

I ran the tests repeatedly and analyzed why they failed. For these i determined the cause to be hdfs.


⚠ Bofrost.de has degraded performance

In 70b0714, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1222 ms

Resolved: Bofrost.de performance has improved in 54ce13d.


How to know if user watch the entire reward video

There is an method to get reward ad when it is read, but how to know if the user watch entire reward video or don`t? Right know I am calling this
    showRewardVideo() {
        let engine = this.getEngine();
        if (!engine) {
            return;
        }
        this.isRewardVideoReady().then((isReady) => {
            console.log(isReady);
            if (isReady) {
                engine.rewardvideo.show().then((res) => {
                    console.log(res);
                }).catch((err) => {
                    console.log('erro', err);
                });
            } else {
                this.prepareRewardVideo();
            }
        });
    }

Your current code makes a console.log just after the reward video has been shown. If you want to do some extra action when full video has been watched you need to use event:
    document.addEventListener('admob.rewardvideo.events.REWARD', () => {
      console.log("GIVE USER A REWARD HERE");
    });

@calebeaires I am not able to get reward videos in my App. can you please share the file where you have configured coded reward video.
Thanks in advance!

@PrithiviRajG Are you using an emulator or an real device to test it? With this plugin rewards video does not works on a real device.

@calebeaires I am using real device. How to use it or test it for real device?
any other ways to use reward videos in cordova App using AdMob?

@PrithiviRajG with Android Studio, download and active emulated devices, then you can emulate your cordova app on it with something like this: cordova emulate android. video tips

This will produce Uncaught SyntaxError: Unexpected token )

Closing it, as answer has been already provided in the first comment. That's how you recognize if the reward video has been fully watched.


TypeError in acc_offsets method in Kernel.py

Seems like upcasted_i is a List[Tuple[sint, Optional[sint], bool]] which is a value returned by the upacsted_axis method which uses the shape property of shapetrackers (ret -> sint), real_strides property of shapetrackers (ret -> sint) and bool
https://github.com/tinygrad/tinygrad/blob/778d17fbd311ba1d6a759472667295b74a0ccea7/tinygrad/codegen/kernel.py#L176

The first element (sint) of each tuple in this list is used in the range function during iteration
After generating a Cartesian product from sint types using itertools.product, the resulting values are summed to give List[sint], but the return type of the function is expected to be List[int].

I don't think so because you can't convert a sint which is a union of int, mulnode, numnode and sumnode into an int. See #3439 for more information on sints and its known issues.


Wait before toggling keyboard

There's some kind of race condition situation happening here (as reported by @hxrts). Hopefully waiting a millisecond before dismissing the keyboard squashes it.

*waiting 100 milliseconds


D16078_Alm Design changes

Thank you for your contribution.
Before submitting this PR, please make sure:

[x] PR description and commit message should describe the changes done in this PR
[x] Verify the PR is point to correct branch i.e. Release or Beta branch if the code fix is for specific release , else point it to master
[x] Latest Code from master or specific release branch is merged to your branch
[x] No unwanted\commented\junk code is included
[ ] No new warning upon build solution
[x] Existing unit test cases are passed
[ ] New Unit tests are added for your development
[x] Sanity Tests are successfully executed for Existing Functionality
[x] After creating pull request there should not be any conflicts
[ ] Resolve codacy comments
[ ] Builds and checks are passed before PR is sent for review
[ ] Resolve code review comments

Please change target branch to master instead of Releases/Beta

Please change target branch to master


⚠ API - Lens has degraded performance

In bb56813, API - Lens ($LENS_API_URL) experienced degraded performance:

HTTP code: 503
Response time: 330 ms

Resolved: API - Lens performance has improved in 349110f after 8 minutes.


⚠ PostgreSQL has degraded performance

In 7fb0edc, PostgreSQL (https://news.ycombinator.com) experienced degraded performance:

HTTP code: 200
Response time: 741 ms

Resolved: PostgreSQL performance has improved in aa4f1a3.


clear the doc related to Ecto.Model

I have no idea why the test failed 🤔

This test fails sometimes, nothing to worry about.
Thank you! :heart:


go run -tags=example rotate/main.go returning errors

Hello! New to the project here. I ran into these errors when following the getting started guide.
$ go run -tags=example rotate/main.go
# github.com/go-gl/glfw/v3.2/glfw
cc1.exe: sorry, unimplemented: 64-bit mode not compiled in
# github.com/go-gl/gl/v2.1/gl
cc1.exe: sorry, unimplemented: 64-bit mode not compiled in

Any suggestions?

I fixed my issue. Turns out I had an entry in my PATH for MinGW pointing at some QT directory. I removed the entry and installed MinGW-64bit using TDM then adding the bin/ to my system path.
Hopefully this fix helps someone else!~


Update version of swagger-converter

Update to 1.0.1

version 1.0 has breaking API changes.

Anyone mind sending a PR for this?  I haven't kept up with swagger-converter and since it's got breaking changes, it might make sense to have someone else do this.  (I'm capable, just wanting to avoid the extra round trips.)  /cc @IvanGoncharov

Problem is that you need to change CLI.

And in new version you need to match paths inside resourceListing and actual sub-resources referenced by them.
So it required to design new CLI syntax.

See this commit.

I don't see a good way to do this so I don't see it happening.  The API changes make it very difficult because either the CLI caller needs to know the order and use that or there needs to be some consistent way to guess the paths based on the file names.

Maybe we can default to guessing paths based on file names and have the option to specify it explicitly. That way we can keep it backward compatible. I'm not sure how the arguments lists should look like though...

Yeah, that's the rub.  I'll give it some thought.

@whitlockjc I added new function which provide list of resourceListings with path to them. You can pass file path instead of URL as first argument and then function will also produce file paths. So you make CLI command which with resourceListing as first argument and path to resourceListings as second.
Note: resourceListing can have basePath which can affect result. So good idea is to remove basePath before passing it to listApiDeclarations.


Can't run these commands on Powershell

I'm trying to follow the documentation ton install powerline in Powershell (Windows Terminal) but the commands listed on the article doesn't run in my terminal. This is the error it shows:

What can I do to solve this?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d3cbeb9a-9e7c-f8f4-5c03-5d6262d2b440
Version Independent ID: eb575c79-5b2a-45f6-646f-9d41d5d223e8
Content: Windows Terminal Powerline Setup
Content Source: TerminalDocs/tutorials/powerline-setup.md
Product: dev-environment
Technology: windows-terminal
GitHub Login: @cinnamon-msft
Microsoft Alias: cinnamon

Closing this as we did some major updates to the command prompt customizing tutorial (replacing the powerline tutorial with Oh My Posh): https://docs.microsoft.com/windows/terminal/tutorials/custom-prompt-setup
Try it out and if you still have trouble please reopen or let me know if you see any issues with this new method of customizing your prompts. Thanks for the contribution and sorry for trouble / slow reply!


table name add ` symbols when TDengine

Description
An anomaly occurs when clicking on a table

Example

DBeaver Version
community <IP_ADDRESS>310221533
Operating System
macOS 14.0
Database and driver
Driver name : com.taosdata.jdbc:taos-jdbcdriver:RELEASE 3.2.1
Steps to reproduce
No response
Additional context
No response

I have confirmed here that if the ` symbol is not used
Table names will not be case sensitive.
will not be able to get the table data , table does not exist

Any other database object names require quotes in case special symbols are inside these names.
An example of the table name on your screen does not contain special symbols. For this reason - it is not quoted by DBeaver.
So, what is the rule for quoting for TDengine?

Because I used backticks (`) when creating the table name, it resulted in case sensitivity. To correctly retrieve the data during a search, I need to include the backticks again.
Naming Rules (Organized by ChatGPT) :
The page from the TDengine documentation discusses naming conventions and limitations for databases, tables, columns, and tags in TDengine. Key points include:
Naming Rules: Names can start with a letter or underscore, but not a number, and are case-insensitive. A special escape character "`" allows for more naming options while preserving case sensitivity.
Character Set for Passwords: Specifies allowable characters for passwords, excluding quotes, backslashes, and spaces.
General Limitations: This section covers various limits, such as maximum lengths for database names, table names, column names, and tag names. It also addresses limitations on the number of columns, tags, SQL statement length, and the total number of rows.
Table and Column Naming: Explains the constraints and length limits for table and column names, including rules for names with escape characters.
For detailed information and examples, you can visit the TDengine Documentation.

And I'm still confused.

Names can start with a letter or underscore, but not a number, and are case-insensitive.

So, names are case-insensitive but with a special escape character - they are case-sensitive.
But how we can determine that this name has escaped? Maybe any system table has this info?
And what if you create a table with the name "aBc" - will it be converted to "ABC" or "abc"?

If backticks are used, you'll get "aBc"; without them, it's "abc".

When I execute the two sql:
create table if not exists `device_property_ABC_d0000000001_e_1` (ts timestamp, param bigint, device_name varchar(50), property_type varchar(50));

create table if not exists device_property_ABC_d0000000001_e_1 (ts timestamp, param bigint, device_name varchar(50), property_type varchar(50));

I will get two tables named:
device_property_ABC_d0000000001_e_1  and device_property_abc_d0000000001_e_1

Ok. Could you please try to change these settings in your connection settings?

Then reconnect and do some operations with your table.

I have tried adjusting these settings, but the error still persists.
These are the SQL commands I used to create my table

#step1:
CREATE STABLE `model_custom_property_27NbfMsBLLa_e_1` (`ts` TIMESTAMP, `param` BIGINT) TAGS (`device_name` VARCHAR(50), `property_type` VARCHAR(50));

#step2:
CREATE TABLE `device_property_27NbfMsBLLa_d0000000001_e_1` USING `model_custom_property_27NbfMsBLLa_e_1` (`device_name`, `property_type`) TAGS ("d0000000001", "int");

Also, could you please specify this setting with quotes parameters: `:`

Fixed. The fix will be available in the next DBeaver version, 23.3.4, on 05-02-2024.


Add custom color parameters

/textcolor "RRGGBB" (default="000000")
/bgcolor "RRGGBB" (default="F4F4F4")

This change is

(For what it's worth)  We use UltraModernUI for NSIS with different skins for different flavors of our installer, so I needed an easy way to recolor based on the flavor, so I whipped a parameter-ized version of rmangroliya's snippet from here: http://forums.winamp.com/showthread.php?t=334819 and then add "/textcolor ${UMUI_TEXT_COLOR} /bgcolor ${MUI_BGCOLOR}" to my inetc call.

@Nutzzz This sounds like a addition. I'd just like to make sure that you've noticed that this isn't the "official" InetC plugin, but a fork I've made with an alternative download dialog.
If your modification is intended for the "original" it needs to be posted elsewhere.
I'll do a review using Reviewable.

@Nutzzz Even when building in ANSI mode I get errors with VS2012 (which is what has been used for this plugin:
1>inetc.obj : error LNK2001: unresolved external symbol _purecall
1>inetc.obj : error LNK2019: unresolved external symbol "void * __cdecl operator new(unsigned __int64)" (??2@YAPEAX_K@Z) referenced in function "char * __cdecl std::_Allocate<char>(unsigned __int64,char *)" (??$_Allocate@D@std@@YAPEAD_KPEAD@Z)
1>inetc.obj : error LNK2019: unresolved external symbol "void __cdecl operator delete(void *)" (??3@YAXPEAX@Z) referenced in function "public: __cdecl std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >::~basic_string<char,struct std::char_traits<char>,class std::allocator<char> >(void)" (??1?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@QEAA@XZ)
1>inetc.obj : error LNK2019: unresolved external symbol atexit referenced in function "void __cdecl `dynamic initializer for 'public: static class std::_Generic_error_category std::_Error_objects<int>::_Generic_object''(void)" (??__E?_Generic_object@?$_Error_objects@H@std@@2V_Generic_error_category@2@A@@YAXXZ)
1>inetc.obj : error LNK2019: unresolved external symbol memcpy referenced in function "public: void __cdecl std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >::_Copy(unsigned __int64,unsigned __int64)" (?_Copy@?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@QEAAX_K0@Z)
1>inetc.obj : error LNK2019: unresolved external symbol strlen referenced in function "public: __cdecl std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >(char const *)" (??0?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@QEAA@PEBD@Z)
1>inetc.obj : error LNK2019: unresolved external symbol memmove referenced in function "public: class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > & __cdecl std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >::erase(unsigned __int64,unsigned __int64)" (?erase@?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@QEAAAEAV12@_K0@Z)
1>inetc.obj : error LNK2019: unresolved external symbol sscanf_s referenced in function "__int64 __cdecl dlgProc(struct HWND__ *,unsigned int,unsigned __int64,__int64)" (?dlgProc@@YA_JPEAUHWND__@@I_K_J@Z)
1>inetc.obj : error LNK2019: unresolved external symbol "void __cdecl std::_Xbad_alloc(void)" (?_Xbad_alloc@std@@YAXXZ) referenced in function "char * __cdecl std::_Allocate<char>(unsigned __int64,char *)" (??$_Allocate@D@std@@YAPEAD_KPEAD@Z)
1>inetc.obj : error LNK2019: unresolved external symbol "void __cdecl std::_Xlength_error(char const *)" (?_Xlength_error@std@@YAXPEBD@Z) referenced in function "public: bool __cdecl std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >::_Grow(unsigned __int64,bool)" (?_Grow@?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@QEAA_N_K_N@Z)
1>inetc.obj : error LNK2019: unresolved external symbol "void __cdecl std::_Xout_of_range(char const *)" (?_Xout_of_range@std@@YAXPEBD@Z) referenced in function "public: void __cdecl std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >::_Xran(void)const " (?_Xran@?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@QEBAXXZ)
1>inetc.obj : error LNK2019: unresolved external symbol "char const * __cdecl std::_Syserror_map(int)" (?_Syserror_map@std@@YAPEBDH@Z) referenced in function "public: virtual class std::error_condition __cdecl std::_System_error_category::default_error_condition(int)const " (?default_error_condition@_System_error_category@std@@UEBA?AVerror_condition@2@H@Z)
1>inetc.obj : error LNK2019: unresolved external symbol "char const * __cdecl std::_Winerror_map(int)" (?_Winerror_map@std@@YAPEBDH@Z) referenced in function "public: virtual class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl std::_System_error_category::message(int)const " (?message@_System_error_category@std@@UEBA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@2@H@Z)
1>inetc.obj : error LNK2019: unresolved external symbol _CxxThrowException referenced in function __catch$?_Copy@?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@QEAAX_K0@Z$1
1>inetc.obj : error LNK2001: unresolved external symbol __CxxFrameHandler3
1>inetc.obj : error LNK2001: unresolved external symbol "const type_info::`vftable'" (??_7type_info@@6B@)

I assume that you were able to build it successfully?

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Contrib/Inetc/inetc.cpp, line 1429 at r1 (raw file):

		{
			unsigned int fgR, fgG, fgB;
			sscanf_s(szTextColor, "%02x%02x%02x", &fgR, &fgG, &fgB);

This fails to compile with Unicode, argument of type TCHAR * is incompatible with parameter of type const char *
This is the same for all calls to sscanf_s(). I'm not anywhere close to knowing C++ types well enough to find a solution, but hopefully you are.

Comments from Reviewable

Re: it being an addition, well, that was the "(For what it's worth)"; seeing as I liked your addition, and there was nowhere else to really contribute... here it is.
Re: not compiling, Release (but not Debug) has "Linker > Input > Ignore All Default Libraries" turned on, but it compiles if you set it back to the default (No).
As for Unicode support, we don't need at the moment for our purposes, so it wasn't on my radar, but it should be an easy fix.  We'll take a look.

@Nutzzz It seems a word was missing in my response, which made it a bit hard to understand. What I meant to say was

his sounds like a nice addition

Adding things to this repo is fine by me, I just wanted to make sure that you knew that it wasn't the "official" repo.
As I'm sure you understand, C++ is not my language, and VS is completely alien to me. The default libraries setting makes sense, but it makes me worry about the consequences of referencing one of these "default" libraries. Does that mean that it won't run without VCRedist or (god forbid) .NET installed? If so, I think that is a big limitation because of such a simple task. It that's the case, wouldn't it be better to make a parser for the color values that manages without extra libraries?

OK.  Up'd a couple of quick ifdefs for Unicode, and the new project file should allow you to build everything, including x64.
The required libraries are statically linked, so no redistributables are required.

FYI, I'm now getting a crash.  Debugging...

Review status: 0 of 2 files reviewed at latest revision, 2 unresolved discussions.

Contrib/Inetc/inetc.cpp, line 1429 at r1 (raw file):
Previously, Nadahar (Nadar) wrote…
This fails to compile with Unicode, argument of type TCHAR * is incompatible with parameter of type const char *
This is the same for all calls to sscanf_s(). I'm not anywhere close to knowing C++ types well enough to find a solution, but hopefully you are.

Done.

Comments from Reviewable

Review status: 0 of 2 files reviewed at latest revision, 2 unresolved discussions.

Contrib/Inetc/inetc.cpp, line 1461 at r3 (raw file):
Previously, Nadahar (Nadar) wrote…
@Nutzzz As stated before, I'm really not up to speed with C++, but how you can set index 6 of szBgColor when it according to the next if might be NULL? Won't that lead to an error if it is in fact NULL?

Done.

Comments from Reviewable

@Nutzzz I've found some problems with your code, but I haven't been able to solve it yet. Since I don't use C++ and isn't used to VS, this is very time consuming. The fact that I have to compile the plugin and then compile NSIS for every test makes it even slower, and I don't have the slightest idea of how to get a debugger (break points, variable inspection) up and running for this I'm pretty much blind as well.
What I have found this far is:

I'm not convinced that your string initialization { 0 } is safe. As far as I can understand, that is only correct in ANSI mode while Unicode requires two "null" values. I'm not sure though, but I think TEXT("") handles this properly.
The code doesn't work properly when not setting any of your parameters. You seem to have hardcoded the "default" values, but that doesn't cut it. The default theme colors must be preserved when custom colors aren't specified.
The code breaks compatibility with older Windows versions. WM_CTLCOLORSTATIC is only defined for Vista and later. Since it's not defined for earlier versions, I guess the message will never come. In addition I'm afraid that the constant itself isn't defined and thus might be invalid. Since I know so little about how the compiler works, I don't know if this is simply replaced by the value (0x0138 ?) when compiled, in which case that won't be a problem - but the code will never be called.
I'm a bit confused why you set the background color two different places, and why you set the background mode to "TRANSPARENT".
The MSDN documentation clearly states that the brushes creates should be reused, and must be freed after use. This code seems to create a new brush for every message (and never released), which means it's a memory leak and quite inefficient.

@Nutzzz After a lot of struggeling with things I do not know, I came up with this solution that I think deals with all my issues: ea5ab8d64e62e90bdb38f1315d44642fb9204a3b
I've tested it to the best of my abilites, and it now avoids the memory leak, works on XP and keeps the default colors if no colors are specified. Please not that it's not possible to change only the text color, nothing happens unless background color is also specified.
I'd appreciate if you'd review and test it and give some feedback.

My abilities are less than yours, though I have had a bit of help from a more expert coworker.  I hope you've viewed this as a learning experience rather than just a pain in the butt.  Your changes look good to both of us, should cover a much wider audience, and resolve the crashing I had observed with my latest pull requests.

@Nutzzz Thank you for your feedback. I do know programming, just not in C/C++ :wink: Of course this isn't a "pain in the butt", we both try to learn and share as best we can. I don't think anyone can ask for anything more from volunteers.
It's good to hear that this works for you and that you don't see any problems with the code :+1:

I know I've been slow to work this out, but as my C/C++ skills is appalling and I've only worked on it a little now and then, it's taken time. I'm finally ready now though, so I'll merge this and then add my fixes in another commit.


Scene under SubViewport renders at screen resolution instead of SubViewport resolution

Godot version
4.1.3
System information
windows 11 - Godot 4.1.3 - Mobile
Issue description
Hello, i am having issues when trying to edit scenes under ViewPort.
I am working on a mobile game so i set the screen resolution to be 1024:600 with Mode: viewport and aspect: ignore.
I want to display a different scene on my mobile like this

I have set a viewport with size of 325x and 200y

Now the issue is that i don't know where are the boundries of that scene when working on the scene.

As you can see it render right on my Mobile because I guessed to myself where approximity the boundries are located.
Steps to reproduce
Go to Project settings -> Window and Resolution

and stretch and handheld

Create two scenes, one with viewport and the other with some gui on it
Setup viewport with canvas layer and container

and then add camera2d and the scene with the gui

and you will see how hard it's to place the sprites
Minimal reproduction project
ProdQuest-master.zip

Please upload a minimal reproduction project[^1] to make this easier to troubleshoot.
[^1]: A small Godot project which reproduces the issue, with no unnecessary files included. Be sure to not include the .godot folder in the archive (but keep project.godot).Drag and drop a ZIP archive to upload it. Do not select another field until the project is done uploading.Note for C# users: If your issue is not Mono-specific, please upload a minimal reproduction project written in GDScript or VisualScript. This will make it easier for contributors to reproduce the issue locally as not everyone has a Mono setup available.

Please upload a minimal reproduction project1 to make this easier to troubleshoot.
Footnotes

A small Godot project which reproduces the issue, with no unnecessary files included. Be sure to not include the .godot folder in the archive (but keep project.godot).Drag and drop a ZIP archive to upload it. **Do not select another field until the project is done uploading.**Note for C# users: If your issue is not Mono-specific, please upload a minimal reproduction project written in GDScript or VisualScript. This will make it easier for contributors to reproduce the issue locally as not everyone has a Mono setup available. ↩

Done

Related to #68309


Call an asserter from another asserter

Hello,
is there a way to call an asserter from another asserter? In my case I would like to call botium-asserter-basiclink only if I don't find a "filterString" in the chatbot text otherwise return true. Maybe there is already something dealing with "assertConvoStep" .
Sorry for my very basic javaScript understanding
Thanks

No reason why not. Just instantiate the other asserter (with same args as yours), and call the assertConvoStep function, again with the same args as yours ...

I started with a new basic asserter but " Failed to fetch CUST_ASS asserter, no idea how to load  " Adding under Capabilities in botium.json
"ASSERTERS": [
{
"ref": "CUST_ASS",
"src": "/app/custAsserter.js"
}
]
So tried to call with CUST_ASS myText in #bot section . I have already created in /app/custAsserter.js:
const _ = require('lodash')
const { BotiumError } = require('botium-core')
//const { BotiumError } = require('../../BotiumError')
///usr/local/lib/node_modules/botium-cli/node_modules/botium-core/src/scripting/BotiumError.js
module.exports = class custAsserter {
constructor (context, caps = {}) {
this.context = context
this.caps = caps
}
assertConvoStep ({ convo, convoStep, args, botMsg }) {
if (!args || args.length < 1) {
return Promise.reject(new BotiumError(${convoStep.stepTag}: custAsserter Missing argument,
{
type: 'asserter',
subtype: 'wrong parameters',
source: 'custAsserter',
cause: { args }
}
))
}
////botMsg.messageText botMsg.buttons ||  _.isString(shallContained)
if (args.length >= 1) {
if(botMsg.messageText.includes("Do you find any of the options") && !botMsg.messageText.includes(args[0]))
return Promise.reject(new BotiumError(${convoStep.stepTag}: custAsserter Alternative Button not found "${args}",
{
type: 'asserter',
subtype: 'wrong parameters',
source: 'custAsserter',
cause: { args }
}
))
}
return Promise.resolve()

} //END assertConvoStep
}

Error:
Failed to fetch CUST_ASS asserter, no idea how to load ...
at LogicHookUtils._loadClass (/usr/local/lib/node_modules/botium-cli/node_modules/botium-core/src/scripting/logichook/LogicHookUtils.js:263:11)
at caps.(anonymous function).map.asserter (/usr/local/lib/node_modules/botium-cli/node_modules/botium-core/src/scripting/logichook/LogicHookUtils.js:96:45)
at Array.map ()
at LogicHookUtils._fetchAsserters (/usr/local/lib/node_modules/botium-cli/node_modules/botium-core/src/scripting/logichook/LogicHookUtils.js:92:8)
at new LogicHookUtils (/usr/local/lib/node_modules/botium-cli/node_modules/botium-core/src/scripting/logichook/LogicHookUtils.js:63:10)
at ScriptingProvider.Build (/usr/local/lib/node_modules/botium-cli/node_modules/botium-core/src/scripting/ScriptingProvider.js:259:28)
at BotDriver.BuildCompiler (/usr/local/lib/node_modules/botium-cli/node_modules/botium-core/src/BotDriver.js:164:16)
at handler (/usr/local/lib/node_modules/botium-cli/src/run/index.js:79:27)
at Object.builder.handler (/usr/local/lib/node_modules/botium-cli/bin/botium-cli.js:34:7)
at Object.runCommand (/usr/local/lib/node_modules/botium-cli/node_modules/yargs/lib/command.js:242:26)
at Object.parseArgs [as _parseArgs] (/usr/local/lib/node_modules/botium-cli/node_modules/yargs/yargs.js:1078:30)
at Object.get [as argv] (/usr/local/lib/node_modules/botium-cli/node_modules/yargs/yargs.js:1012:21)
at Object. (/usr/local/lib/node_modules/botium-cli/bin/botium-cli.js:74:3)
at Module._compile (module.js:653:30)
at Object.Module._extensions..js (module.js:664:10)
at Module.load (module.js:566:32)

Pls enable debug mode, should get more details then

In debug mode the problem show is code: 'MODULE_NOT_FOUND' related to const { BotiumError } = require('botium-core')

Can you try to install botium-core into the global npm cache (npm install -g botium-core)

Still error also after explicit global install
root@567ac8c17f9a:/app# npm list -g | grep botium
+--<EMAIL_ADDRESS>| +--<EMAIL_ADDRESS>| +--<EMAIL_ADDRESS>| +--<EMAIL_ADDRESS>| +--<EMAIL_ADDRESS>| +--<EMAIL_ADDRESS>| +--<EMAIL_ADDRESS>| +--<EMAIL_ADDRESS>| +--<EMAIL_ADDRESS>| +-- UNMET PEER DEPENDENCY<EMAIL_ADDRESS>| +--<EMAIL_ADDRESS>| +--<EMAIL_ADDRESS>| +--<EMAIL_ADDRESS>| +--<EMAIL_ADDRESS>| +--<EMAIL_ADDRESS>| +--<EMAIL_ADDRESS>| +--<EMAIL_ADDRESS>| +--<EMAIL_ADDRESS>| +--<EMAIL_ADDRESS>| +--<EMAIL_ADDRESS>| +--<EMAIL_ADDRESS>npm ERR! peer dep missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>

ok I will try to reproduce this on a new machine

one thing you can try: in /app, run "npm init -y" and "npm install botium-core" to install botium-core locally to your asserter

with npm init -y" and "npm install botium-core seems to work.
So calling in my custom asserter the button asserter how can be made?

something like this:
const ButtonsAsserter = require('botium-core/src/scripting/logichook/asserter/ButtonsAsserter')
....
constructor (context, caps = {}) {
    this.context = context
    this.caps = caps
    this.defaultButtonsAsserter = new ButtonsAsserter(context, caps)
}
...
...
assertConvoStep ({ convo, convoStep, args, botMsg }) {
    ....
    return this.defaultButtonsAsserter.assertConvoStep({convo, convoStep, args, botMsg})

It's ok, thanks : )


(Investigate) Clear SQS events

Investigate if removing/cleaning of SQS generated events is necessary.

AWS SDK doesn`t remove message from SQS after it was received. Call to delete message is required.
https://docs.aws.amazon.com/sdk-for-javascript/v2/developer-guide/sqs-examples-send-receive-messages.html#sqs-examples-send-receive-messages-receiving


xml2rfc: init at 2.9.6

Motivation for this change
xml2rfc not present in nixpkgs
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Sorry, I didn't get the memo. What should I be using now?

@FRidh Frederik, is the new update any better?

@yrashk xm2rfc appears to be primarily an application and should therefore be called directly from all-packages.nix, and not via python-packages.nix.

@FRidh how about now?

@FRidh is this what you had in mind?

@GrahamcOfBorg build xml2rfc

Success on x86_64-darwin (full log)
Attempted: xml2rfc
Partial log (click to expand)
test_status_irtf_info_no (test.WriterRfcTest) ... ok
test_status_irtf_info_nowg (test.WriterRfcTest) ... ok
test_status_irtf_info_yes (test.WriterRfcTest) ... ok
test_top (test.WriterRfcTest) ... ok

----------------------------------------------------------------------
Ran 42 tests in 0.369s

OK
/nix/store/plz2z6f9yd92n376m2kf9yv1scpzyd9c-python2.7-xml2rfc-2.9.6

Success on x86_64-linux (full log)
Attempted: xml2rfc
Partial log (click to expand)
ok

----------------------------------------------------------------------

Ran 42 tests in 0.542s

OK

Success on aarch64-linux (full log)
Attempted: xml2rfc
Partial log (click to expand)
test_status_irtf_info_no (test.WriterRfcTest) ... ok
test_status_irtf_info_nowg (test.WriterRfcTest) ... ok
test_status_irtf_info_yes (test.WriterRfcTest) ... ok
test_top (test.WriterRfcTest) ... ok

----------------------------------------------------------------------
Ran 42 tests in 2.528s

OK
/nix/store/d7azhxzwm68h485x0ap1dis52wkg9196-python2.7-xml2rfc-2.9.6


[Kernel] Support prefill and decode attention kernel in parallel

Support prefill and decode stage attention kernel in parallel when chunked prefill is enabled use cuda multi-stream, Currently support LLama Model with Flash Attention, No impact on other models and kernles.
Same Logic with LMDeploy and TRT-LLM，When the Chunked Prefill flag is turned on, GPU resources can be better utilized.

BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE

 PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

[Bugfix] for bug fixes.
[CI/Build] for build or continuous integration improvements.
[Doc] for documentation fixes and improvements.
[Model] for adding a new model or improving an existing model. Model name should appear in the title.
[Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
[Kernel] for changes affecting CUDA kernels or other compute kernels.
[Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
[Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
[Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:

We adhere to Google Python style guide and Google C++ style guide.
Pass all linter checks. Please use format.sh to format your code.
The code need to be well-documented to ensure future contributors can easily understand the code.
Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.
What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

 After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
 After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
 After the review, the reviewer will put an  action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
 Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You
 Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

Thanks for the PR! A few questions:

Do you have some benchmark results to show the speedup of this optimization? Is it always beneficial (or at least no regression) on all models and GPUs?
The current implementation requires each model to define and pass an auxiliary stream. This is not a common practice for model implementation. Can we figure out a way to enable auxiliary stream automatically (i.e. do need to change model code)?

Looks interesting and reasonable to me. I have the same question as @comaniac , does this always bring speedup?
I don't think you need to change model's code. If this is beneficial, we can directly add it in the modelrunner level, provide 2 streams for all models directly.

Thanks for the PR! A few questions:

Do you have some benchmark results to show the speedup of this optimization? Is it always beneficial (or at least no regression) on all models and GPUs?
The current implementation requires each model to define and pass an auxiliary stream. This is not a common practice for model implementation. Can we figure out a way to enable auxiliary stream automatically (i.e. do need to change model code)?

Nice!

Thanks for the PR! A few questions:

Do you have some benchmark results to show the speedup of this optimization? Is it always beneficial (or at least no regression) on all models and GPUs?
The current implementation requires each model to define and pass an auxiliary stream. This is not a common practice for model implementation. Can we figure out a way to enable auxiliary stream automatically (i.e. do need to change model code)?

Thank you for your replay，I am doing some detailed testing to prove the effectiveness of this optimization, and will post the data in this PR later.

Thanks for the PR! A few questions:

Do you have some benchmark results to show the speedup of this optimization? Is it always beneficial (or at least no regression) on all models and GPUs?
The current implementation requires each model to define and pass an auxiliary stream. This is not a common practice for model implementation. Can we figure out a way to enable auxiliary stream automatically (i.e. do need to change model code)?

Theoretically, the attention in the decoding phase is memory bound, while the attention in the prefill phase is compute bound. If both can be run at the same time, there should be some benefits.
And regarding the aux_stream design, when I get the current PR that is effective for performance or analyze the boundaries of the problem, I will refactor the code.


Fix grid_client tests

Description
Fix grid_client tests
Changes

fix: mycelium flag error

Related Issues

https://github.com/threefoldtech/tfgrid-sdk-ts/issues/2289

Checklist

[ ] Tests included
[ ] Build pass
[ ] Documentation
[ ] Code format and docstrings
[ ] Screenshots/Video attached (needed for UI changes)

For https://github.com/threefoldtech/tfgrid-sdk-ts/runs/22340536329#r0s0
Both cases fails while requesting http://node.testnet.algoexplorerapi.io/v2/accounts/LEFOFMMJ2MO26BZT3Q2I2SO5W6IKTFQUUSJUQKX5MXCCMW56UD5XIZFHZM/
in algorand.ts (method: assetsByAddress)


Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: Index 1 out of bounds for length 1

After recently patching Java on an Ubuntu bionic server with this version:
commafeed@neibu:~/commafeed$ java --version
openjdk 11.0.2 2019-01-15
OpenJDK Runtime Environment (build 11.0.2+9-Ubuntu-3ubuntu118.04.3)
OpenJDK 64-Bit Server VM (build 11.0.2+9-Ubuntu-3ubuntu118.04.3, mixed mode, sharing)

I am getting this error trying to start a commafeed install which was previously working ok:
commafeed@neibu:~/commafeed$ java -Djava.net.preferIPv4Stack=true -jar commafeed.jar server config.yml
Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: Index 1 out of bounds for length 1
        at org.hibernate.validator.internal.util.Version.getJavaRelease(Version.java:36)
        at org.hibernate.validator.internal.engine.ConfigurationImpl.<init>(ConfigurationImpl.java:120)
        at org.hibernate.validator.internal.engine.ConfigurationImpl.<init>(ConfigurationImpl.java:106)
        at org.hibernate.validator.HibernateValidator.createSpecializedConfiguration(HibernateValidator.java:27)
        at org.hibernate.validator.HibernateValidator.createSpecializedConfiguration(HibernateValidator.java:24)
        at javax.validation.Validation$ProviderSpecificBootstrapImpl.configure(Validation.java:220)
        at io.dropwizard.validation.BaseValidator.newConfiguration(BaseValidator.java:28)
        at io.dropwizard.jersey.validation.Validators.newConfiguration(Validators.java:35)
        at io.dropwizard.jersey.validation.Validators.newValidatorFactory(Validators.java:27)
        at io.dropwizard.setup.Bootstrap.<init>(Bootstrap.java:68)
        at io.dropwizard.Application.run(Application.java:72)
        at com.commafeed.CommaFeedApplication.main(CommaFeedApplication.java:172)

I cloned the master branch, copied my configuration which I've only changed to use a MySQL database, and now the application starts ok.  There are a few warnings now when I start it up:
commafeed@neibu:~/git/commafeed$ java -Djava.net.preferIPv4Stack=true -jar target/commafeed.jar server config.yml
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by com.fasterxml.jackson.module.afterburner.util.MyClassLoader (file:/opt/commafeed/git/commafeed/target/commafeed.jar) to method java.lang.ClassLoader.defineClass(java.lang.St
ring,byte[],int,int)
WARNING: Please consider reporting this to the maintainers of com.fasterxml.jackson.module.afterburner.util.MyClassLoader
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release

I don't know what they mean, but possibly this issue is resolved.

I made changes recently to support java 9+ (https://github.com/Athou/commafeed/issues/904). The app works fine but there are warning like these.
They can be ignored for now. It would be nice if Jackson was updated though. The discussion takes place here https://github.com/FasterXML/jackson-modules-base/issues/37


Adding new field to document

Let`s say i have already 1m rows and i want to add field to it. Will it work?

Hi @Warmcher, yes. Take a look in this doc about document database from mongodb: https://docs.mongodb.com/manual/data-modeling/   all conepts are the same in litedb


Integrate Snapshot functionality for Java with Kubernetes

We need to integrate the Snapshot based functionality for Java/Spring Boot based microservice with Kubernetes

Yes, the snapshot maker should work for this issue.


Can CRC support specifying particular OpenShift version

General information

OS: macOS
Hypervisor: hyperkit
Did you run crc setup before starting it (Yes)?

CRC version
# Put the output of `crc version`
$ crc version
version: 1.0.0-beta.5+f2aa58c
OpenShift version: 4.1.14 (embedded in binary)

Host Operating System
# put the output of `sw_vers` in case of Mac
$ sw_vers
ProductName:	Mac OS X
ProductVersion:	10.13.6
BuildVersion:	17G3025

Steps to reproduce
It looks currently the CRC installation program binds to fixed OpenShift version, e.g.

1.0.0-rc.0 bounds to OpenShift v4.2.0-0.nightly-2019-09-26-192831
1.0.0-beta.5 bound to OpenShift v4.1.14
1.0.0-beta.3 bound to OpenShift v4.1.11

Can this be customized by user to specify a particular OpenShift version for the CRC being run? The business reason behind is that we are currently targeting OpenShift v4.1, while the latest CRC installation program has been bumped to v4.2. Or, we have to go back to use a previous version of CRC.
It'd be nice if that does not conflict w/ the design principle of CRC. Or, let me know if there's anything I missed. Thanks.
Expected
Support specifying particular OpenShift version for CRC.
Actual
It seems CRC does not support specifying particular OpenShift version.

In that case you have to remain using an older version CRC. At the moment the version of OpenShift is tied to the release of CRC. The caveat is that the certificates expire and would not allow this to work longer than 30 days.
Note: this is IIRC also not possible with the installer. The OCP platform will auto-update using the Cluster Version Operator to the latest version.
We will have a look at this, but this is currently not priority. We haven't done a GA yet.

This is IIRC also not possible with the installer. The OCP platform will auto-update using the Cluster Version Operator to the latest version.

Using installer you can do, auto-update is by default disabled until user push a button.

@gbraad @praveenkumar Thanks for your prompt replies.
Understood that's not current priority:-)
The problem is that some features may not be available in previous version of crc. Just as an example, I noticed the crc console --credentials option is only available since version 1.0.0-rc.0.
If it's supposed to be tied to OpenShift version, then, it would be good to see several stable crc deliveries for major OpenShift releases, e.g. 4.1, 4.2, and so on... although that could make things complicated.

At some point in time we have stabilized on the core set of features, which we will then carry forward and test thoroughly. However, there will always be a cut-off point to what we can do between versions of CRC in combination of OpenShift. We are still investigating what is possible.
@praveenkumar so I can use the installer to install 4.1.1 or 4.1.2, or even 4.2-rc0 as a very specific version? Or I can only specifying with major releases between either 4.1 or 4.2?

Hi @gbraad There's one thing that I do not understand:

The caveat is that the certificates expire and would not allow this to work longer than 30 days.

This seems to imply that we can only use the latest version, because previous versions will be expired in 30 days. Just curious, what's the rational behind this design?

This is not something crc does by design. This is a limitation we get from OpenShift, which wants certificates to be rotated once a month at most for security reasons. With clusters which are up most of the time, this is not a problem. With our usecase, where clusters are down most of the time, this becomes an issue.
Getting rid of this limitation is high on our priority list, but it's not easy.

Since #11 has been closed. Will it be possible to support this requirement? @gbraad @cfergeau

We need to figure out how to do it correctly as we are only able to test and support one bundle version per crc release. If we let users use difference bundle versions, it needs to be explicit that this is an unsupported scenario.


Bump to Kubernetes v1.14.0

This bumps Kubernetes vendoring to v1.14.0.
2 notable changes:

client-go does not include all the TLS bundle generation code we used to consume. This has been replaced by an internal package, covered with tests
include-uninitialized does not exist anymore, and resources pending finalization are now returned by default by get/list.

Codecov Report

Merging #95 into master will decrease coverage by 0.12%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
- Coverage   64.78%   64.65%   -0.13%
==========================================
  Files          89       90       +1
  Lines       10855    10922      +67
==========================================
+ Hits         7032     7062      +30
- Misses       3535     3556      +21
- Partials      288      304      +16

Impacted Files
Coverage Δ

internal/controller/childrenstore.go
82.89% <ø> (-0.23%)
:arrow_down:

cmd/api-server/main.go
73.68% <ø> (ø)
:arrow_up:

install/uninstall.go
0% <0%> (ø)
:arrow_up:

install/installer.go
1.53% <0%> (ø)
:arrow_up:

install/update.go
0% <0%> (ø)
:arrow_up:

internal/controller/resourceupdater.go
36.11% <100%> (-17.1%)
:arrow_down:

internal/controller/stackownercache.go
95.45% <100%> (ø)
:arrow_up:

internal/controller/stacklistener.go
71.15% <100%> (-1.07%)
:arrow_down:

cmd/api-server/cli/root.go
69.66% <55.55%> (+5.14%)
:arrow_up:

internal/registry/stackregistry.go
71.42% <66.66%> (ø)
:arrow_up:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57a7d2e...25184e0. Read the comment docs.


Storm Weaver Cluster

There is an issue in the Storm Weaver cluster. It looks like it skips over nodes when you click on other nodes in the cluster. I'm not sure how to explain it, but here's how to reproduce it:
Having the Intelligence node outside the cluster, hover over Storm Weaver. The path will appear to cross through Cold and Lightning Damage, and Cold Damage. Click on Storm Weaver and the Cold Damage node will not light up. Now click on the Lightning Damage node and the path between it and Storm Weaver will not light up.
Version 2.6.0.

This is a problem with the data from GGG, see #442


edupont04 from OPS portal: Merge from master to live

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

README.md
:white_check_mark:Succeeded

archive/ui-user-personalization.md
:white_check_mark:Succeeded

dynamics-nav-app/across-log-changes.md
:white_check_mark:Succeeded

dynamics-nav-app/admin-configure-user-interface.md
:white_check_mark:Succeeded

dynamics-nav-app/finance-manage-payables.md
:white_check_mark:Succeeded

dynamics-nav-app/includes/nav_web_server_instance_md.md
:white_check_mark:Succeeded

dynamics-nav-app/madeira-outlook.md
:white_check_mark:Succeeded

dynamics-nav-app/marketing-campaigns.md
:white_check_mark:Succeeded

dynamics-nav-app/media/personalization-lock-icon.png
:white_check_mark:Succeeded

dynamics-nav-app/media/ui-search/search_small.png
:white_check_mark:Succeeded

dynamics-nav-app/media/ui_personalization_blocked.png
:white_check_mark:Succeeded

dynamics-nav-app/projects-how-manage-project-supplies.md
:white_check_mark:Succeeded

dynamics-nav-app/sales-how-drop-shipment.md
:white_check_mark:Succeeded

dynamics-nav-app/ui-change-basic-settings.md
:white_check_mark:Succeeded

dynamics-nav-app/ui-extensions.md
:white_check_mark:Succeeded

dynamics-nav-app/ui-personalization-locked.md
:white_check_mark:Succeeded

dynamics-nav-app/ui-personalization-manage.md
:white_check_mark:Succeeded

dynamics-nav-app/ui-personalization-overview.md
:white_check_mark:Succeeded

dynamics-nav-app/ui-personalization-user.md
:white_check_mark:Succeeded

dynamics-nav-app/ui-personalization-windows-client.md
:white_check_mark:Succeeded

dynamics-nav-app/ui-smart-notifications.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Using responseType=none to generate a bearer for two different services/scopes

Hello, I am trying to use responseType=none.
http://openid.net/specs/oauth-v2-multiple-response-types-1_0-08.html#none
Does anyone have an example of how this is supposed to work with this library?
I have been using responseType=token for a while now but I need to generate a token for two services now which changes things up a bit.
Thanks

Alas, this response type is not supported with this library. Sorry for the late response!
Let others know if you found a resolution (with this library, or another) - or let us know if we should reopen the issue for something.


Fixes #372 - Change default branch from master to main

Merge Checklist

[x] Have you linked this Pull Request to an Issue?
[x] Have you updated any relevant README files, to explain how this new feature works (with examples)?
[x] Have you added relevant test cases for your change?
[x] Do all tests and code style checks pass with ./gradlew check --info?
[x] Have you updated the CHANGELOG?

This change replaces master with main in both code and textual references.
It also updates references to master and slave in text.

Codecov Report

Merging #434 (7300ef3) into master (20765fb) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #434   +/-   ##
=======================================
  Coverage   82.49%   82.49%
=======================================
  Files          54       54
  Lines        1508     1508
  Branches      321      321
=======================================
  Hits         1244     1244
  Misses        115      115
  Partials      149      149

Impacted Files
Coverage Δ

src/ConditionalApplyPlugin.groovy
80.76% <100.00%> (ø)

src/RegressionStage.groovy
78.37% <100.00%> (ø)

src/TerraformTaintPlugin.groovy
65.71% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20765fb...7300ef3. Read the comment docs.


Add commit description to nightly packages changelog

The detail of changes will visible in commits. We didn't wrote any release notes after publish. May I will try to write some release notes I think.
Originally posted by @appleneko2001 in https://github.com/AvaloniaCommunity/Material.Avalonia/issues/151#issuecomment-1025922770

I think what i need to attach commit message as release notes for nightly packages to clearly see changes

Could we use GitHub API to fetch commits of repository and create a base of release notes automatically? I still searching a way for archiving this.

@appleneko2001 Don't waste your time on this. I'll do it myself, it's easy enough.

Ok then. Text me if you need ask somethin or any questions about this issue.

Done with latest buildscript changes


Simplify ci master nbest rescoring

Codecov Report

Merging #32 (b04dd52) into master (31de8f2) will increase coverage by 24.41%.
The diff coverage is 30.47%.

:exclamation: Current head b04dd52 differs from pull request most recent head 81f40d3. Consider uploading reports for the commit 81f40d3 to get more accurate results

@@             Coverage Diff             @@
##           master      #32       +/-   ##
===========================================
+ Coverage   56.53%   80.94%   +24.41%
===========================================
  Files         741      416      -325
  Lines       64483    34786    -29697
===========================================
- Hits        36457    28159     -8298
+ Misses      28026     6627    -21399

Impacted Files
Coverage Δ

espnet2/asr/espnet_model.py
72.95% <6.45%> (-18.46%)
:arrow_down:

espnet2/fst/lm_rescore.py
13.04% <13.04%> (ø)

espnet2/lm/espnet_model.py
64.17% <20.00%> (-35.83%)
:arrow_down:

espnet2/bin/asr_inference_k2.py
68.48% <54.16%> (ø)

espnet/nets/pytorch_backend/nets_utils.py
85.15% <100.00%> (+0.35%)
:arrow_up:

espnet2/asr/decoder/transformer_decoder.py
96.63% <100.00%> (ø)

espnet2/asr/ctc.py
62.12% <0.00%> (-21.22%)
:arrow_down:

espnet/nets/pytorch_backend/ctc.py
51.93% <0.00%> (-12.41%)
:arrow_down:

espnet2/layers/stft.py
85.89% <0.00%> (-6.42%)
:arrow_down:

espnet/transform/transform_interface.py
66.66% <0.00%> (-3.34%)
:arrow_down:

... and 392 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31de8f2...81f40d3. Read the comment docs.


Please give more space to code

What problem does this feature solve?
More convenient when watching code
What does the proposed API look like?
I hope there is a larger space to display the code, which can display the code completely without sliding up, down, left and right. It can learn the ng-zorro-mobile

Actually, I prefer the doc style of zorro-pc. Maybe develop team can provider 2  doc styles.

This issue has been closed due to inactivity.
Please file a new issue or discussion if you are encountering a similar or related problem.


Mapping json results to classes

Instead of returning raw objects, using something like JsonMapper to map responses to custom classes.

Already working on it on the branch: https://github.com/namelivia/travelperk-http-php/tree/use_json_mapper_for_results


Standard event stream

we are missing some events but I'm opening separate issues to tackle those

resolves #1209

https://github.com/ChainSafe/lodestar/pull/1586/checks?check_run_id=1167215923
wth? maybe rebase off latest master?

https://github.com/ChainSafe/lodestar/pull/1586/checks?check_run_id=1167215923
wth? maybe rebase off latest master?

Yeah seems like it. I'll open Pr to add back check-types step in CI to avoid things like that


jib-maven-plugin randomly fails on the docker authentication

jib-maven-plugin version: 0.9.13
I use credentials from ~/.docker/config.json and sometimes build fails with:
[INFO] --- jib-maven-plugin:0.9.13:build @ application ---
[INFO]
[INFO] Containerizing application to private_registry/application:1.7.1-SNAPSHOT...
[INFO]
[INFO] Retrieving registry credentials for private_registry...
[INFO] Getting base image private_registry/oracle-jdk...
[INFO] Building snapshot dependencies layer...
[INFO] Building resources layer...
[INFO] Building dependencies layer...
[INFO] Building classes layer...
[INFO] The base image requires auth. Trying again for private_registry/oracle-jdk...
[INFO] Retrieving registry credentials for private_registry...
[ERROR] Failed to retrieve authentication challenge for registry that required token authentication

But when I restart the build (without any changes) - it runs successfully. How can I debug this behavior? I use Nexus OSS as registry if it matters.
Plugin configuration:
            <plugin>
                <groupId>com.google.cloud.tools</groupId>
                <artifactId>jib-maven-plugin</artifactId>
                <version>0.9.13</version>
                <configuration>
                 <to>
                    <image>${dockerregistry.url}/${project.artifactId}:${project.version}</image>
                </to>
                <from>
                    <image>private_registry/oracle-jdk:1.0.0</image>
                </from>
                <container>
                    <jvmFlags>
                        <jvmFlag>-XX:OnOutOfMemoryError=kill -9 %p</jvmFlag>
                        <jvmFlag>-XX:+HeapDumpOnOutOfMemoryError</jvmFlag>
                    </jvmFlags>
                </container>
                </configuration>
                <executions>
                    <execution>
                        <id>build-image</id>
                        <phase>install</phase>
                        <goals>
                            <goal>build</goal>
                        </goals>
                    </execution>
                </executions>
            </plugin>

Are you literally using "private_registry/oracle-jdk:1.0.0" as the base image and "private_registry/application:1.7.1-SNAPSHOT" as the target image? I believe this kind of image reference form points to the Docker Hub registry.

@chanseokoh private_registry = registry.ourdomain.com, it referenced to our registry address. :)

That's what I suspected. One possibility I'm thinking of is that there are multiple distributed registry servers accessible through the registry.ourdomain.com address, and you are routed to different servers during the build, which sometimes causes this inconsistent results. Is it possible to fix a server (for example, by putting registry.ourdomain.com entry in /etc/hosts if using a fixed IP can serve the purpose) and see if that clears the problem?

Nope, we have only one DNS record for our registry. native docker pull/push (and io.fabric8.docker-maven plugin) works without any problems.

Hmmm. Can't reproduce. Possibly this was been network issues. I'll try again tomorrow and will close the issue if all will works as expected. Sorry for bothering. :)

Looks like it was the network issues. Can't reproduce now.


Updates to repo structure and release processes post 1.0

This epic addresses the additional work needed to update the repo and release processes following #8007 (which is considered the baseline needed for the 1.0 release).  These items are not necessary to make the 1.0 release, but should be considered necessary for the longer-term sustainability of releases following 1.0.
Goals

Developers can create releases with minimal manual steps. This involves simplifying the existing release process.
~Developers can work easily across multiple development branches that permit different levels of breaking changes.  This involves setting up parallel dev branches for changes that are not allowed on the primary dev branch (e.g. due to the level of breaking changes permitted at any time) and the related processes and dev education to support this.  This is expected to involve creating a branch for major changes that must wait until the next major release cycle while the main branch can only make minor releases.~ Moved to pre 1.0
Our packages are in the same repository (as opposed to the current split repos of client, server, common-definitions, etc.)
Packages are versioned independently. Packages may be assigned to groups which are versioned in lockstep

Work items
Release process simplification

[ ] #8948
[ ] #8056

Developers do not need to consider layers when making changes

[ ] #8055
[ ] #8105

Packages are versioned independently

[ ] #8459
[ ] Enable reactive versioning for all packages/groups across the repo

Moved to ADO


Unlock only when lock was successful

Addressing issue (#24517):
(1/3) Updated the example in CRYPTO_THREAD_run_once.pod to reflect that an unlock call should not be made if a write_lock failed.
(2/3) Updated BIO_lookup_ex in bio_addr.c and ossl_engine_table_select in eng_table.c to not call unlock if the lock failed.

Checklist

[x] documentation is added or updated

Thanks for the suggestions @nhorman , I have updated the commit to reflect the requests you have asked. Passed the test so no issues! I closed and reopened the repo as per the email for agreeing to the CLA.

This pull request is ready to merge

comitted to master, 3.0, 3.1, 3.2 and 3.3.  Thank you!


Power spectral density (PSD) with "rapsd" function

First of all, thank you very much for providing this tool. I very much like it!
Just quick question regarding one of the function rapsd from utils.
1: According to the discription, it computes the radially averaged PSD for a 2d array. However, if I want to compute the PSD for a normal cartesian coordinate array (rather than a radial one), how should I implement it?
2: Regarding the output of this function, I am not really sure about the unit and type of each axis. Could you please tell a bit more about this? (Ex. the following figure)

Thank you very much!!

Hello @ZHANGZ1YUE

1: According to the description, it computes the radially averaged PSD for a 2d array. However, if I want to compute the PSD for a normal cartesian coordinate array (rather than a radial one), how should I implement it?

The input to utils.spectal.rapsd can be a 2d cartesian field. In this case, you must pass the fft_method argument, e.g. you could pass np.fft. If fft_method is None (the default), then is it assumed that the input array is the Fourier transform of the original field.

2: Regarding the output of this function, I am not really sure about the unit and type of each axis. Could you please tell a bit more about this?

You can set return_freq=True in the above method to get the coordinates of the x axis. The y axis depends on the units of the input array: e.g., if the original field in is "mm" and 1 grid point corresponds to 1 km, the PSD will be in units of mm^2 / km.
Note 1: there is utility function to plot 1D spectra: https://pysteps.readthedocs.io/en/stable/generated/pysteps.visualization.spectral.plot_spectrum1d.html
Note 2: you can have a look a this example on how we typically produce and plot PSD for precipitation fields: https://github.com/pySTEPS/pysteps-publication/blob/415d0bb69e70fa072a06138778085ed829260894/plot_cascade_spectra_SPROG_MEAN.py#L173
Finally, please let us know if you see any opportunity to improve the documentation of the methods above.

Hi @dnerini
Your explanation and the provided example can't be more helpful. I might have more question in future regarding the details but so far, it does plot what I expected.

Finally, please let us know if you see any opportunity to improve the documentation of the methods above.

Definitely! Once I have a deeper understanding regarding these functions, I'll let you know if I have any suggestions for the documentation.
Thank you very much.