User should be able to comment on others comments

Update creator in the comment DB

Reply on Comments- Update the comment object with the parent id of the original comment. Assigning this task to the frontend team.


Will this be a component?

Curious if you're looking to publish to npm.

yes, I plan to publish it as npm module - just need one evening of free time :)

now it is: https://www.npmjs.com/package/react-multistep
:)

nice!


Force login locale doesn't seem to work with extraQueryParameters

Core Library
MSAL.js v2 (@azure/msal-browser)
Core Library Version
2.28.0
Wrapper Library
MSAL React (@azure/msal-react)
Wrapper Library Version
1.4.4
Description
Based on #4289, we should be able to override the browser's preferred language setting with a locale parameter in the extraQueryParameters property of the login request.
However, this does not seem to work. The original poster of the related issue did not provide any followup so I'm creating this one instead :)
Error Message
No response
Msal Logs
No response
MSAL Configuration
const msalConfig = {
  auth: {
    clientId: config.msal.CLIENT_ID,
    authority: config.msal.AUTHORITY,
    redirectUri: config.msal.REDIRECT_URI,
    postLogoutRedirectUri: config.msal.POST_LOGOUT_REDIRECT_URI,
  },
  cache: {
    cacheLocation: 'localStorage',
    storeAuthStateInCookie: false,
  },

Relevant Code Snippets
const accessTokenRequest = {
    scopes: [...],
    extraQueryParameters: {
      locale: 'en',
    },
  };
  instance
    .acquireTokenPopup(accessTokenRequest)
    .then(() => {})
    .catch((error) => {
      // eslint-disable-next-line no-console
      console.log(error);
    });

### Reproduction Steps

1. Change browser preferred language to something other than English (I changed it to fr-CA in Edge).
2. Go to app and trigger login popup with above configuration

### Expected Behavior

The login popup text is in English due to the `locale` param in the `extraQueryParameters`.

### Identity Provider

Azure AD / MSA

### Browsers Affected (Select all that apply)

Edge

### Regression

_No response_

### Source

External (Customer)

@michaelhum  Thanks for creating a new issue.  I am able to reproduce this behavior.
Just FYI, if you are using Azure b2c, there are detailed steps for language customization here https://docs.microsoft.com/en-us/azure/active-directory-b2c/enable-authentication-react-spa-app-options?tabs=popup.
The locale parameter doesnt override the default browser setting and  I am checking if we can support this feature going forward. I am curious if you have considered writing your own click handler to force set the popup dialog language?

Hi @bmahall we are unfortunately not using B2C yet, but that's good to know for the future thanks!
I am not sure I follow regarding trying to write a dedicated handler - is this something supported by msal? Or do you mean trying to edit the text of the popup manually? I don't see a setting to swap the locale of the popup once it's opened (unless I am missing something here) - sorry for the confusion :)

@michaelhum Can you please try using mkt parameter?
Example: mkt=fr-fr

@bmahall the mkt parameter seems to work! I am able to swap between English/French with en/fr as input for both the login and logout popup. Thanks!

Hello @bmahall, I am using mkt parameter and it is working fine for login. for log out pop up, When it says "Please wait while we sign out", I still get it in English even though, the mkt parameter passed was fr.
Could you share some thoughts.
Thanks


Base class with MIFARE and card emulation plugins

Looks like a good start!
I'm curious how you actually go about finding nearby cards; does the application have to set up its own polling to find nearby cards? Is there another flow where the PN532 does the polling itself and throws an interrupt? It'll be helpful for the review to see some example code.
Some more code-specific comments:

There are a lot of places in the code where the raw offset in a packet to a specific field is stored as a magic number, which I'm generally ok with as it gets very tedious naming all those offsets. However, there are some places where I think I'd rather see things as statics or consts. Things like frame lengths, or the "0 means OK" on line 125 of the MiFare Class.
In the README and the PN532 base class, I see you're sticking with the datasheet's terminology on pin names. I generally agree with this, but personally never mimic the use of the term "slave select", opting instead for the perfectly understandable and widely used "chip select".

Looking forward to sharing! This is a useful part.

Ok! Looks good to merge from here.


Issue #5: Replace the MLH Fellowship logo with the MLH Prep logo

This Pull request fixes the bug wherein MLH Fellowship logo shows instead of the Prep Logo.
The pull request is for issue #5 which asks to replace the MLH Fellowship logo with the MLH Prep logo on the Projects page. It is important since this portfolio website is a part of MLH Prep and hence the logo.

I have also added a boilerplate for Dark mode functionality which requires JavaScript.
Kindly ignore the 4 commits pertaining to the dark mode. Only the first is relevant.

Hey Alex! That JS file is meant for implementing the dark mode functionality. Its just a boiler plate. I'll remove it because it doesn't pertain to the issue I resolved.

Great, thank you!


Add Monkey C language

Resolve #5563

Description

Adds the MonkeyC language.
Color from logo on website
Checklist:

[x] I am adding a new language.

[x] The extension of the new language is used in hundreds of repositories on GitHub.com.

Search results for each extension:

6K+ with exact keywords ("using Toybox", the stdlib)
16K+ with just "using"
58K overall

[x] I have included a real-world usage sample for all extensions added in this PR:

Sample under Apache2

[x] I have included a syntax highlighting grammar:

Source
Preview

Other stuff with .mc:

14K of this translation file thing
8K/9K for some mail thing
3K of something Oracle-related
25K other

Should be good now.
The 3K "© Oracle" files seem to be assembly but look like they are all inside a jdk-* folder.
I can't find any other common languages in the other 25K results.

The syntax error was added in the second edit but for some reason the first edit failed as well. Whats up with that.


[Bug] [Seatunnel-web] gc.log, nohup.out is created outside of logs directory

Purpose of this pull request

Check list

[ ] Code changed are covered with tests, or it does not need tests for reason:
[ ] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs

After fix below seatunnel-web start command creates logs,out file and gc files inside logs directory
sh bin/seatunnel-backend-daemon.sh start

Thanks @Hisoka-X for reviewing and merging this PR.


Lens missing when using NovaResource::make(...)

I have a App\Nova\Resource that has lenses, they work fine when this tool is not registered in Nova.
The lenses drop down selection does not appear on the resource after I use this tool to modify the sidebar navigation.

Not sure why, but it is ok now. Probably some issue at my end. Closing first. Thank you.


x/tools/gopls: gopls seems to be leaking memory on macOS Big Sur

What did you do?
When working with large codebases gopls seems to be consuming unhealthy amount of memory

this leads to the point that my os is prompting me to force quit the terminal app.
What did you expect to see?
Less memory usage.
What did you see instead?
Excessive amount of memory used by gopls
Build info
# redacted
$ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOOS="darwin"
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/Cellar/go/1.15.3/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.15.3/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/2q/5_4ntfd5369552_qb4_plfz40000gn/T/go-build998481377=/tmp/go-build -gno-record-gcc-switches -fno-common"

golang.org/x/tools/gopls v0.5.1
<EMAIL_ADDRESS>h1:AF3Uh7HF08SZpKFfgJO6zfF3bbxyDXWqdkK4kMXiQ1o=
<EMAIL_ADDRESS>h1:WXkYYl6Yr3qBf1K79EBnL4mak0OimBfB0XUf9Vl28OQ=
<EMAIL_ADDRESS>h1:JFrFEBb2xKufg6XkJsJr+WbKb4FQlURi5RUcBveYu9k=
<EMAIL_ADDRESS>h1:we8PVUC3FE2uYfodKH/nBHMSetSfHDR6scGdBi+erh0=
<EMAIL_ADDRESS>h1:RM4zey1++hCTbCVQfnWeKs9/IEsaBLA8vTkd0WVtmH4=
<EMAIL_ADDRESS>h1:qwRHBd0NqMbJxfbotnDhm2ByMI1Shq4Y6oRJo21SGJA=
<EMAIL_ADDRESS>h1:1R38tQp22dcHpTKJPjgVa16FhlDy/kHEaCM/ndi/FIc=
<EMAIL_ADDRESS>h1:go1bK/D/BFZV2I8cIQd1NKEZ+0owSTG1fDTci4IqFcE=
<EMAIL_ADDRESS>h1:nI5egYTGJakVyOryqLs1cQO5dO0ksin5XXs2pspk75k=
<EMAIL_ADDRESS>h1:t8TAw9WgTLghti7RYkpPmqk4JtQ3+wcP5GgZqgWeWLQ=
<EMAIL_ADDRESS>h1:NSZPykBXJFCetGZykLAxaL6SIpvbVy/UFEniIfHAa8A=

Can you please follow the memory usage troubleshooting steps and share the memory debug information?
Also, it looks like you have 5 gopls processes running--do you have 5 editors open or just one?
By the way, the latest version of gopls is v0.5.2--please update by running GO111MODULE=on go get golang.org/x/tools/gopls@latest.

Occasionally I might have few instances of different editors opened, yes. Unfortunately, that's necessary due to my work. I shall update gopls and grab the memory debug info soon.

I have not noticed anything weird going on since the last macOS release candidate so I'm closing this. Thanks.


Documentation is missing a few math functions

I'm not sure why, but https://triton-lang.org/python-api/triton.language.html is missing tl.sqrt, tl.sin, and tl.cos, all of which work perfectly fine as far as I can tell.

Thanks! This has been fixed :)


added viridis colormap

Hi Til,
This commit adds the "viridis" colormap from matplotlib. This colormap will be the new standard colormap (replacing jet) in the upcoming release. It is (kind of) close to parula, Matlabs new default.
I also added a shortcut for it (alt+v) because I am lazy.
Here is a quick comparison of the colormaps:

Interested?

Cool, thanks!
I'll just merge this commit without testing. It looks good to me and I'm pretty sure you know what you're doing :)


[BUG]:  "zenml example pull" still refers to an older release

Contact Details [Optional]
No response
System Information
ZenML version: 0.10.0
Install path: /home/t00238/miniconda3/envs/zenml_v0_10/lib/python3.8/site-packages/zenml
Python version: 3.8.13
Platform information: {'os': 'linux', 'linux_distro': 'ubuntu', 'linux_distro_like': 'debian', 'linux_distro_version': '20.04'}
Environment: native
Integrations: ['great_expectations', 'scipy', 'sklearn']
What happened?
zenml example pull is not able to check out to the latest release branch.
I also have other instances of zenml installed in different virtual environment. Not sure if there is data leakage from existing zenml installations to this one. Do they share any user level files? Or each zenml installation is isolated in their virtual environment completely?
Reproduction steps

Have multiple zenml installations in various venvs.
Follow the instructions on https://github.com/zenml-io/zenml/tree/main/examples/great_expectations_data_validation

Relevant log output
> zenml example pull great_expectations_data_validation

Checking out branch: release/0.10.0
The specified branch release/0.10.0 not found in repo, falling back to the latest release.
Checking out branch: release/0.6.0
Error: "Example great_expectations_data_validation does not exist! Available examples: ['airflow_local', 'caching', 'class_based_api', 'custom_materializer', 'dag_visualizer', 'drift_detection', 'fetch_historical_runs', 'functional_api', 'kubeflow', 'lineage', 'mlflow_tracking', 'not_so_quickstart', 'quickstart', 'standard_interfaces', 'statistics', 'whylogs']"

Code of Conduct

[X] I agree to follow this project's Code of Conduct

@tunayokumus thank you for filing this !
I think yours might be a case of cache deprecation. ZenML does keep a cache of all examples it downloads locally in the global configuration directory under a zenml_examples subfolder.
You can correct the problem by simply passing the -y option when you run zenml example pull:
zenml example pull -y great_expectations_data_validation

Fixed the underlying issue in #776


Add rubocop

from https://github.com/winebarrel/ridgepole/issues/167

Coverage remained the same at 97.193% when pulling 882596b4947403f87f4af70b1593da77069ee426 on add_rubocop into 6db2172978ce9f3ab1b960b656c4f4cd685af1f4 on 0.7.


vote: tag v1.1.0-beta.1

Release
This would mean tagging f45197cbd53b9cbaf867cfe5152e3b8cf4ea9766 as v1.1.0-beta.1 to release.
Vote
We need at least 4 approvals from 6 maintainers to release notation-core-go v1.1.0-beta.1.

[x] Junjie Gao (@JeyJeyGao)
[ ] Milind Gokarn (@gokarnm)
[x] Patrick Zheng (@Two-Hearts)
[ ] Pritesh Bandi (@priteshbandi)
[ ] Rakesh Gariganti (@rgnote)
[x] Shiwei Zhang (@shizhMSFT)

Changes

build(deps): bump github.com/fxamacker/cbor/v2 from 2.6.0 to 2.7.0 by @dependabot in https://github.com/notaryproject/notation-core-go/pull/208
build(deps): bump golang.org/x/crypto from 0.23.0 to 0.24.0 by @dependabot in https://github.com/notaryproject/notation-core-go/pull/206
fix(ci): pass CODECOV_TOKEN to reusable-build.yml by @JeyJeyGao in https://github.com/notaryproject/notation-core-go/pull/209
feat: Timestamp by @Two-Hearts in https://github.com/notaryproject/notation-core-go/pull/207
build(deps): bump golang.org/x/crypto from 0.24.0 to 0.25.0 by @dependabot in https://github.com/notaryproject/notation-core-go/pull/210
fix: fix signerInfo.authenticSigningTime according to spec by @Two-Hearts in https://github.com/notaryproject/notation-core-go/pull/211

Full Changelog: https://github.com/notaryproject/notation-core-go/compare/v1.0.3...f45197cbd53b9cbaf867cfe5152e3b8cf4ea9766
Action Requested
Please respond LGTM or REJECT (with reasoning).

LGTM

LGTM

LGTM

LGTM

Closing as v1.1.0-beta.1 has been released.


Add hardware sizing guide

Originally: https://github.com/influxdb/influxdb.com/pull/529

@rkuchan What number stands for 10MM? 10E12?

@janantala, 10MM is 10 million. I edited the document to reflect the written-out form of the numbers for clarification.

Thanks. I was confused because you use 1M and 10MM expressions.

Fixes https://github.com/influxdata/docs.influxdata.com/issues/66


Add Swift package manifest

The file is generated by swift package init and then manually edited a bit.
I tried it in my own project and it seems to work.

@b123400 Thank you for supporting the swift package manager! Can you add an instruction to the installation section of the README if possible?

I am not that familiar with Swift Package that I don't know if there's any instruction at all. All I did was adding the package repo via Xcode's GUI.


Edited for more natural English.

I'm just starting to use your project, and I like it a lot, including the documentation. I was able to follow along and wanted to help a little where I could. These are just a few minor edits to help the descriptions flow smoothly for native speakers.

Thanks for this contribution. Best regards.


Initial component infrastructure

Adding basic component functions, to be elaborated on.

Apologies; I keep selecting the incorrect base repository when submitting PRs -__-'


Use dependabot to keep our deps up2date

Let's use dependabot:
https://github.blog/2020-06-01-keep-all-your-packages-up-to-date-with-dependabot/
https://help.github.com/en/github/administering-a-repository/about-github-dependabot
to keep our dependencies up-to-date and avoid CVEs in our code.
Dependabot would try to add the /ok-to-test label so that our CI runs
automatically.

/lgtm


Allow for the setting of the line width

It would be nice if mesh.to_slice(gfx::Line) would allow you to set the line width.
https://www.opengl.org/sdk/docs/man4/html/glLineWidth.xhtml

Closing due to inactivity.

:+1:


cant start with intel gpu hd5500

Step 1
run game
Step 2
fail to get graphics initialisation

running stable version
log
http://pastebin.com/KnNqAKbw

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/35709888-cant-start-with-intel-gpu-hd5500?utm_campaign=plugin&utm_content=tracker%2F5279&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F5279&utm_medium=issues&utm_source=github).

Hi @chriscamacho :-)
Thanks for the extra comments in the paste. Do you have experience with upgrading LWJGL 2 -> 3? Do you think that would matter in this case? We often hit issues with Intel HD chips but usually on older hardware.
The full but quiet crash during initialization is more rare though, usually we get a cleaner complaint about the gpu missing features or outright visible graphic artifacts. Probably the 5500 being far newer indicates a different problem.
@emanuele3d and @tdgunes are at present working on a rendering overhaul. It doesn't involve upgrading LWJGL so far, and we're considering going directly to a LWJGL-3 based LibGDX instead. I haven't kept good track of the completeness of LWJGL 3, last I knew some of the extras were still being upgraded. If it can serve as an almost drop-in replacement that would be interesting, especially if that could show an improvement on this issue.
There are some more details on LWJGL 3 / LibGDX in #2099 although there it looks like the changes from LWJGL 2 to 3 are more substantial.

I wouldn't just be a "drop in" sorry if I gave that impression, for
example there is NO Display class
Instead you must open a "window" for yourself using glfw - however this
shouldn't be an really that much of an issue....
lwjgl2 is substantially out of date and afaict no longer maintained
lwjgl3 works really nicely on my intel GPU well worth the effort
lwjgl3 has reached v3.0 and is stable and a sight easier to use.
libgdx while excellent for what it is does rather bring the kitchen sink

lwjgl - I could see a lot of libgdx not being used, unless you're
going to rewrite all the 3d stuff to use gdx's engine - which if you're
already doing it with OpenGL alone seems counter productive...

On 03/07/16 18:28, Rasmus Praestholm wrote:

Hi @chriscamacho https://github.com/chriscamacho :-)
Thanks for the extra comments in the paste. Do you have experience
with upgrading LWJGL 2 -> 3? Do you think that would matter in this
case? We often hit issues with Intel HD chips but usually on older
hardware.
The full but quiet crash during initialization is more rare though,
usually we get a cleaner complaint about the gpu missing features or
outright visible graphic artifacts. Probably the 5500 being far newer
indicates a different problem.
@emanuele3d https://github.com/emanuele3d and @tdgunes
https://github.com/tdgunes are at present working on a rendering
overhaul. It doesn't involve upgrading LWJGL so far, and we're
considering going directly to a LWJGL-3 based LibGDX instead. I
haven't kept good track of the completeness of LWJGL 3, last I knew
some of the extras were still being upgraded. If it can serve as an
almost drop-in replacement that would be interesting, especially if
that could show an improvement on this issue.
There are some more details on LWJGL 3 / LibGDX in #2099
https://github.com/MovingBlocks/Terasology/issues/2099 although
there it looks like the changes from LWJGL 2 to 3 are more substantial.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MovingBlocks/Terasology/issues/2393#issuecomment-230164816,
or mute the thread
https://github.com/notifications/unsubscribe/AAruSSBmR5Yh5fS2RvokP-PjgnWry1Rwks5qR_E7gaJpZM4JD4_G.

Hi @chriscamacho, unfortunately the very last line of the log you provided hints to an unsupported GPU. Specifically, integrated GPUs are known to cause problems as they do not support all the OpenGL features Terasology takes advantage of. Which is peculiar though as this particular card supports OpenGL 4.3 while we use ancient OpenGL 2.1 plus a few extensions that have later been included in OpenGL 3.0. My suspicion is that it might be these extensions to cause the failure: they probably haven't been implemented because they are provided by the 3.0+ implementation.
In the medium term the rendering engine is being opened up to have an extendable architecture that, in the longer term, might lead to alternative rendering engines, i.e. taking advantage of the latest OpenGL features or providing support for older platforms.
In the short term I'm afraid your best bet is to play Terasology on a system with a discrete GPU.
Sorry I can't be more helpful at this point.
Thank you for your assessment of LWJGL 3 and LibGDX. It's good to know.


Take 2 of gittuf verification functions

The last part of #52.

Addressed outstanding comments from #52.
Still relevant: https://github.com/adityasaky/gittuf/pull/52#discussion_r1261640641 and https://github.com/adityasaky/gittuf/pull/52#discussion_r1261638135

Changed from #52: this PR updates the CLI to gittuf verify-ref. This can be used to demonstrate branch protection features but file access rules are WIP while we work out the nuances of file rules in combination with git ref rules.

@wlynch I think this may be ready for another pass!


interface address is weird..

I'm opening this issue because:

[ ] I have found a bug
[ ] I want to request a feature
[X] I have a question
[ ] Other

My OS is windows 10, I have a weird thing when I use qrcp. I choose interfaces and the address of WLAN looks weird, like " WLAN ([2402:7500:58e:bcec:c8a9:673:4fab:8107])" . I can receive or send any file by this address. How do I figure out it?

That's an IPv6, not sure why it's not picking up the IPv4.
Can you run the config wizard with the --list-all-interfaces flag, scroll through the list and see if you find your IPv4?
qrcp config --list-all-interfaces

Thanks,
Claudio

That's an IPv6, not sure why it's not picking up the IPv4.
Can you run the config wizard with the --list-all-interfaces flag, scroll through the list and see if you find your IPv4?
qrcp config --list-all-interfaces

Thanks,
Claudio

I have the same problem with Laviklee. My computer has both ipv4 and ipv6 address, but the qrcp just only show ipv6 address, although I added the --list-all-interfaces command option. It seems doesn't help.

@Supresun thanks for the feedback, will try to figure out how to reproduce (I'm not a Windows user).

Hello @Supresun @LavikLee, I just released a new version https://github.com/claudiodangelis/qrcp/releases/tag/0.8.3 which should fix the issue for you.
Can you please give it a try and let me know?
Cheers,
Claudio

Thanks a lot. I enabled the IPv6 protocol and tried the new qrcp. It looks
everything is fine, gets the IPv4 address correctly.
claudiodangelis @.***> 于 2021年4月25日周日 上午12:53写道：

Hello @Supresun https://github.com/Supresun @LavikLee
https://github.com/LavikLee, I just released a new version
https://github.com/claudiodangelis/qrcp/releases/tag/0.8.3 which should
fix the issue for you.
Can you please give it a try and let me know?
Cheers,
Claudio
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/claudiodangelis/qrcp/issues/196#issuecomment-826121076,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKZOOTLNRNOFL6JXN6CMBZDTKLZRZANCNFSM4Z7Q7OHQ
.


Angle Sharp sample breaks when browsing local HTML static files

Hi,

I added a file browser near the go button on top, to support browsing of browse local HTML files and when I browse local html files it breaks.

In the query section, I was also trying to add a listener , where when I clicked on the div, it would show the query text for the element clicked in the textbox below for  the Xpath or QuerySelector of the Div with the attributes, what function code would give me that?

Can you tell me how to add my own functions, like comments or strings, currently its mostly HTML elements and I would like to extend and write to the DOM tree

Is the Dom and IDocument the same in the sample, or are they different pruposed?
thanks

DOM = Document Object Model. IDocument is the document interface of the DOM. Thus the DOM contains the IDocument, and the IDocument is part of the DOM.

Can't say anything about your changes. You need either a valid file: path (be sure to have a proper requester set up for that) or process the text or stream content of the file.
There is no such thing. You entered the query right? So the query is the same thing as you entered. If you would select some element then there is no one query for that. Multiple queries may lead to that element and thus one cannot show a particular query to end up with one element (plus the query may break if the DOM changes, so this is impossible).
I don't understand this question. Comments and text are part of the DOM and available in AngleSharp.


Update submodules and remote refs

Make sure that the lustre-csi-driver and lustre-fs-operator submodules are also up to date with master.

They are, they just apparently haven't changed.


Using django-ckeditor with dynamically added forms (from formset)

I'm using django-ckeditor with a model formset and I'd like to add and remove forms dynamically, not only after the last form, but also in between pre-existing forms. I had done this before using django-ckeditor, but I can't make it work with it. I can't clone or insert the contents of the <iframe>, which is the HTML document with the editable field. I'm doing this outside of the admin page.
Is this possible?

Yes, this is possible. django-ckeditor can be used in Django's admin inlines too, see here: https://github.com/django-ckeditor/django-ckeditor/blob/3951b726013f5c4ae465e907fba575f9b418bb95/ckeditor/static/ckeditor/ckeditor-init.js#L40-L44
The code ensures that CKEditor isn't activated on the template used for new fields (IDs having __prefix__ somewhere) and that you only activate the CKEditor after reinserting the textarea element with a new ID. Django's inlines.js does this automatically. If you want the same outside the administration panel you'll have to reimplement parts of it. Here's some old code which may work (but it's not maintained well anymore) https://github.com/matthiask/towel/blob/master/towel/static/towel/towel.js

@matthiask Thank you very much for your reply and the code you shared.
I see that the code is for inserting new forms dynamically. In my case, it took more work and code because I need to add the forms in between others while keeping their form indexes in order. This was especially necessary because I am also deleting forms, which need to be hidden while maintaining their form indexes and their ids in order to have them deleted in the database when I submit. Every time I submitted the html form with these indexes and ids and their orders altered, I had validation errors. Of course, I also alter the TOTAL-FORMS so django can save those instances in the database. I was able to fix that before using CKEditor (the ckeditor.fields.RichTextField) and it works great without it, but now I can't make the django-ckeditor widget be applied to the newly added forms, just as it is for the originally rendered ones.
Excuse me if my questions are a bit basic; I'm still dipping my toes in this.
From this,

The code ensures that CKEditor isn't activated on the template used for new fields (IDs having prefix somewhere) and that you only activate the CKEditor after reinserting the textarea element with a new ID.

I understand that any new form added will not have a CKEditor isntance, instead I'd need to re-render my html with a new context that contains that form, which is what I'm seeing right now. Am I correct? However, I don't understand the __prefix__ part. Doesn't this apply only when I'm using empty_form? Should I mix the django template language in JavaScript code to use it?
I would appreciate it if you can elaborate a bit more.

@SnakeWhisperer
i'm facing the same problem:

I can't make the django-ckeditor widget be applied to the newly added forms, just as it is for the originally rendered ones

did you find a working solution?

@SnakeWhisperer
i'm facing the same problem:

I can't make the django-ckeditor widget be applied to the newly added forms, just as it is for the originally rendered ones

did you find a working solution?

What I'm doing in https://github.com/matthiask/django-content-editor is that I reorder inlines using Flexbox ordering. This allows me to append a new form at the end (in the HTML) but still move it somewhere in-between other forms.

What I'm doing in https://github.com/matthiask/django-content-editor is that I reorder inlines using Flexbox ordering. This allows me to append a new form at the end (in the HTML) but still move it somewhere in-between other forms.

I am able to dynamically add forms to the formset that's not the issue, the only thing is that the new forms don't have the ckeditor widget

I am able to dynamically add forms to the formset that's not the issue, the only thing is that the new forms don't have the ckeditor widget

Well yes, you'll have to call initialiseCKEditor somehow yourself, if your code doesn't run in the admin panel where a formset:added event handler does this for you.

Well yes, you'll have to call initialiseCKEditor somehow yourself, if your code doesn't run in the admin panel where a formset:added event handler does this for you.

@bb4L
Hi. I hadn't had the chance to update here. But yes, exactly as @matthiask  says, you only need to call initialiseCKEditor, which is in ckeditor-init.js.
I really didn't have to call the actual initialiseCKEditor, and you don't have to either, actually. Only try to understand how it works and see what CKEDITOR.plugins.addExternal() and CKEDITOR.replace() do in the documentation. Then you only have to call them on your newly added textareas. Or, if you don't want to do this, just copy the contents of initialiseCKEditor and paste it in your own script under another function name. You'll have unnecessary iterations over the already processed textareas, but it'll initialize the editor correctly for your newly added ones.
Just make sure these dynamically added forms have the correct structure. Create the div.django-ckeditor-widget with the textarea inside.

@bb4L
Hi. I hadn't had the chance to update here. But yes, exactly as @matthiask  says, you only need to call initialiseCKEditor, which is in ckeditor-init.js.
I really didn't have to call the actual initialiseCKEditor, and you don't have to either, actually. Only try to understand how it works and see what CKEDITOR.plugins.addExternal() and CKEDITOR.replace() do in the documentation. Then you only have to call them on your newly added textareas. Or, if you don't want to do this, just copy the contents of initialiseCKEditor and paste it in your own script under another function name. You'll have unnecessary iterations over the already processed textareas, but it'll initialize the editor correctly for your newly added ones.
Just make sure these dynamically added forms have the correct structure. Create the div.django-ckeditor-widget with the textarea inside.

The last comment answers the original question.

The last comment answers the original question.

@SnakeWhisperer
sorry for not reporting back
indeed the initialiseCKEditor did solve the problem
thank you for the help

@SnakeWhisperer
sorry for not reporting back
indeed the initialiseCKEditor did solve the problem
thank you for the help

@bb4L @SnakeWhisperer @matthiask
I am facing this same issue, please how exactly did you solve yours?
Adding this:
function initialiseCKEditorInInlinedForms() {     if (typeof django === 'object' && django.jQuery) {       django.jQuery(document).on('formset:added', initialiseCKEditor);     }   }
to my code didn’t solve it..
Please if you can see this, I need some assistance


Fix escape sequences for reverse-video and hidden text

Based on the documentation in:
http://invisible-island.net/xterm/ctlseqs/ctlseqs.html
Tested with xterm and gnome-terminal, both of which render reverse-video
and hidden text as expected with this change.  Without this change,
hidden text would show up as reverse-video instead.

This fixes issue #17.

Thanks for this, and especially for testing it with terminals I don't have access to! :+1:

Reverse seems extremely common. Hidden much less so; I would not suggest relying on hidden; better to just print spaces if you want that.

Sometimes, italic terminal text turns into reversed text instead (I think this happens in tmux)

@ogham Yeah, not all terminals support italics.  That lack of widespread compatibility led to this sentence in the manpage for "man" itself: "Exact rendering may vary depending on the output device.  For instance, man will usually not be able to render italics when running in a terminal, and will typically use underlined or coloured text instead."


Deno support for IntelliJ

Thank you for this plugin! It has helped me a lot when working with Go and NodeJS.
Could you provide support for Deno, such as automatically detecting the Deno version?

I'll check it soon!

Hi, @itsbradd
Is this settings page is what you want to change automatically, right?

No, You need to Install Deno plugin for IntelliJ first, then you will have the settings for Deno.
I want to use Mise to manage Deno, not NodeJS. Your plugin support for NodeJS work great already.

@itsbradd
Sorry, It maybe unavailable by the same reason for this.

https://github.com/134130/intellij-mise/issues/29

@itsbradd Hi, I found the way. The release v2.3.0 will bind it. Thank you for using this plugin!

Hi @134130 , thank you for your hard working.
I just checked and confirmed that your plugin correctly detects Deno installed by Mise. However, the path is not perfect yet; it’s missing /bin/deno.
Example: The correct path is /Users/brad/.local/share/mise/installs/deno/2.0.5/bin/deno

@itsbradd
Hi, sorry for my bad. I've just released v2.4.0 again. Thanks!


Unique JsonMessage.name()

In a system only unique message names should be exist. This is could be enforced with an assertion verticle. For reference hav a look at the name checks in HistoryCache.

Still relevant or already closed in #104

I think for now it is fine. If we run into trouble because somebody introduces a variable called className in its message, we will see how to solve it.


No Error response on void envelope request

Request:
ETHON: performed EASY effective_url=https://demo.docusign.net/restapi/v2.1/accounts/xxxxxx/envelopes/9316039f-7e71-483f-ae3b-d1613970505c response_code=0 return_code=ok total_time=0.000605
Response:
#<DocuSign_eSign::ApiError: No error>
Body:
#<DocuSign_eSign::Envelope:0x000055c0aa572f40 @status="voided", @voided_reason="Test">
Code:
def void_envelope(options = {})
  retry_count ||= 0
  envelope = DocuSign_eSign::Envelope.new
  envelope.status = 'voided'
  envelope.voided_reason = 'Test'
  envelope_api.update(account_id, options[:envelope_id], envelope)
rescue DocuSign_eSign::ApiError => e
  Rails.logger.info "exception #{e.inspect}"
  raise if retry_count > 0
  retry_count += 1
  retry
end

API Dashboard:

Skipping envelope_api definition code as it is standard instance method of DocuSign_eSign::EnvelopesApi
I don't see any logs on DocuSign API Dashboard page.
Same request works on retry.
Same request works fine always with V2 version and no gem setup.
I am not sure how to debug this further without proper error details. Please help. Thanks.

Update:
Seeing response_code=0 for different requests randomly. E.g update recipients
ETHON: performed EASY effective_url=https://demo.docusign.net/restapi/v2.1/accounts/xxxx/envelopes/85597d68-2ea7-4386-813c-a9727e7e4ab1/recipients?resend_envelope=true response_code=0 return_code=ok total_time=0.000728

Update:
I tried replacing typhoeus gem with rest-client thinking response_code is somehow related to typhoeus gem. Here are my  changes https://github.com/pramodtech/docusign-ruby-client/pull/1/files
This we deployed to our QA servers and it has been working fine, we don't see any errors and so we don't have to use retry option.
Can someone please check if my analysis and changes makes sense and there is some issue with gem? Thanks.

@pramodtech thanks for bringing this to our attention, we will look into this issue internally and provide an update as soon as possible. Thanks for your patience.

@pramodtech I have updated DCM-5594 with the latest details from case #07555476. However, because this case is now closed, if you are able in the future to provide a reproducible error code example, please attach it here


Verify link invalid/expired bad UI experience

I think we are getting into issues that people create our dex account, then receive the verification link to their email. If they come few days later to click that link and want to proceed to use our site, they get this.

I think this page should give a common sense error and provide a link where you can request a new verification link to your email. I'm not sure if there even exists such a page at the moment? If not it should be created. Easy to access page that my service can redirect to or you can use internally like /verify/resend. Just a simple page with a field to input your email and a send button. After send is clicked, some text should appear Link sent, please check your inbox at <given email>
The above screenshot page could look something like this instead of obscure "hard to read" technical error. As this page is user facing, not developer facing.
This verification link is not valid or has expired.

Click here to send a new verify link

Dex no longer uses SMTP settings to send mail. This should be handled by an external app.


Looking for a home for my FindNojeJS.cmake

Hey, this is rather an odd request, but I've written a find_package() routine to find Node.JS in CMake, and I'm looking for its permanent home, to be a part of a native addon builder node package.
https://github.com/hokiedsp/cmake-modules/blob/master/FindNodeJS.cmake
It is a fairly complete routine (downloads the version-matched node/nw/electron runtime files on the fly).  The usage (supported components and output variables) is included in the file's header comment block.
I've been using it to build native addons independent of node (I'm a node.js newbie, coming from native side) and it has been working well for what I do. I suspect there are some overlapping features to your NodeJS.cmake (like runtime downloading) but if there is any interest in reviving(?) the find_package() support, I could help merging them. The only caveat of my file is that it has not been tested on non-Windows environment.
Thanks

I'm not sure I get the point of this. NodeJS.cmake is a module itself that you just have to copy and paste into your cmake modules directory and include. What does find_package here bring to the table?

Very late, but I agree with @computerquip-streamlabs. The original version of this package tried to use find_package() and it had a lot of limitations, so much so that I completely rewrote it for 2.0 without it to address them. I think it works pretty well exactly as is, and conforming to find_package() semantics, which is meant for finding libraries and modules to link against, is either neutral or slightly worse.
Is there something that you do that I don't? node-cmake also works completely independently of node and provides a complete system for building modules, so I'm struggling to see how these are different.
Your caveat of no windows testing is also a no-go for me; I go to great lengths to try to make sure this works across Windows, Linux and MacOS, even though I don't regularly use Windows myself. I've already established a policy that I won't include / will reject any feature that doesn't work in all contexts, and that isn't going to change. The point of a tool like this is that it needs to work everywhere node does, and node supports all three platforms.


Fixed links, changed article names, added clients page back to IA

Motivation and Context

How Has This Been Tested?

Breaking Changes

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation update

Checklist

[ ] I have read the MCP Documentation
[ ] My code follows the repository's style guidelines
[ ] New and existing tests pass locally
[ ] I have added appropriate error handling
[ ] I have added or updated documentation as needed

Additional context

introduction.mdx, lines 77 and 84, the links should be:
/tutorials/building-a-client
/tutorials/building-mcp-with-llms
introduction.mdx, line 47
my personal opinion, but i think stick with 2 cols and accept that you have an odd number of cards. everywhere else on the site, you use 2 cols; i think it fits in better

thank you @m-atthart ! Just made those changes 🙌


Is this OK to install requirements from source ?

When build on Ubuntu, paddle's requirements(cmake, protobuf, blas, etc.) can be installed using following way:
sudo apt-get install -y g++ make cmake build-essential libatlas-base-dev python python-pip libpython-dev m4 libprotobuf-dev protobuf-compiler python-protobuf python-numpy git
But if i want to build paddle on other platform which can not connect to internet, the only way is to build these requirements(cmake, g++, blas, protobuf, python) from downloaded source code.
So i want to confirm is this ok to install these requirements from source.
thanks~

It should be ok.

And please note that we use protobuf version 2, not version 3.

thanks, guys~


Problem: Layer2.Finance-zk project page

This project has been terminated.
Please remove it.

It has been marked as archived.


Delete slashCommandsTable.PNG

Closing this PR since the PR to add the new table should contain the delete and new table


[FEATURE REQUEST] ...

Is your feature request related to a problem? Please describe.
I LOVE the idea of the pace feature. I think it is a fantastic idea for those categories that we fully fund a month ahead but use little bits at a time, such as groceries. I just found this extension today and played around with it. When I enabled the Pace feature, it automatically applied to every single one of my categories. I might have been ok with this, but it showed my rent and many other categories as behind when really I was good for the month on them, since January rent was fully funded in December and then the entire balance paid on January 1st.
Describe the solution you'd like
I would like to have the option to choose which categories to apply the pace feature to. If I can have pace disabled for 98% of my budget and only enable for groceries and fun money, then that feature would work like charm for my budget.
Describe alternatives you've considered
If choosing the actual category name from our budget won't work then maybe being able to choose which category line numbers might work. So if I have 25 category lines (not including the header line), I could possible choose lines 3 and 15 to apply the pace to. Of course the only downside to doing it this way would be if someone reorders their categories then the pace feature wouldn't match the category anymore, requiring the user to go into settings and adjust it there again (unless the extension is can be made smart enough to see the change and manually adjust).
Thank you all for the work you've all done on this, I think it looks amazing and I love that each feature can be toggled individually so we can really customize to suit our own needs.

Please rename this Feature Request with description such as "Choose which categories to apply the Pace Feature".

You can actually already do this! Just click the pacing amount on the category itself and it will "de-emphasize" that category!


Badge on Remote Explorer makes icon harder to recognize

Please see the screenshot below:

Given the rich information that can be shown in the status bar I wonder whether the badge is still needed

The badge on the activity bar icon makes it more discoverable and matches the pattern for debug, though it can feel heavy handed. I do personally prefer the status bar item if we had to chose one though.

@misolori

The badge on the activity bar icon makes it more discoverable and matches the pattern for debug, though it can feel heavy handed.

Makes sense.
However, in contrast to the debug icon the remote explorer icon is not badge friendly. The 'ports available badge' covers the 'remote decoration' of the icon. Without the remote decoration visible, the remote explorer icon is not easy to spot.

@misolori could we flip the remote explorer icon? Badges in the activity bar are an expected and normal occurrence, so it seems like all icons in the activity bar should be badge friendly.
I am open to removing the badge, but it is consistent with how debug works.

I think if we move the remote decoration to the left it'll look odd and introduce inconsistencies with our other icons:

In that case, I'll remove the badge.


求助：使用mac vscode, 查找后使用command g或者上下箭头切换上下一个，视图位置偏了，居中展示的不是期待查找的那项

感谢您创建此问题！
然而，由于您没有使用英语，我们很难进行处理。如果可能，请您将此问题描述修改为英文。请您直接编辑此问题，不要提交回复或新问题。
请注意，机器翻译服务通常无法处理用于讨论软件问题所需的技术性语言，所以我们推荐您寻找一位熟悉相关技术的人来协助翻译。
如果您无法做到，没有关系。此问题已经被标记为需要翻译，等待社区成员志愿进行翻译。

Thanks for creating this issue!
Unfortunately, as the description is not in English, it's hard for us to work on. If possible, please edit the original issue to be in English.
In our experience, automatic translation services are not able to handle the technical language needed to effectively communicate about software issues, so we recommend finding a human translator who is familiar with our technology to help.
Otherwise, we have marked this as needing translation and a community member may be able to help out.

Help: After using mac vscode, using command g or up and down arrows to switch to the next one after searching, the view position is off, and the centered item is not the one you expect to find.

Hey @rebornix, this issue might need further attention.
@hanshu0513, you can help us out by closing this issue if the problem no longer exists, or adding more information.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


set default time zone for the app to Pacific; revert embargo changes

Why was this change made?
This reverts #2179 (use Pacific time for embargo dates), and instead just sets the application's default time zone to Pacific.  This will have the same effect as the reverted change for the embargo dates, and will also make the date displays for users show in the Pacific time zone.  This will prevent weird "from the future" things like below happening, where I edited an item on March 4 after 4pm, but it showed as last updated on March 5 (since anytime after 4pm Pacific is now the next day in UTC).  Since we display dates (and not timestamps) to users, I think this change should do the expected thing for anyone in North America.

How was this change tested?
Tests and localhost browser.
Which documentation and/or configurations were updated?

I would suggest that the correct way to fix that bug in the display would be to use the LocalTimeComponent. Then the dates show correct for whatever timezone the user happens to be in: https://github.com/sul-dlss/happy-heron/blob/main/app/components/local_time_component.rb
I would be very careful deploying the change you just made because this app was fully tested with the UTC timezone and changing zones possibly introduces a number of new bugs.

I would suggest that the correct way to fix that bug in the display would be to use the LocalTimeComponent. Then the dates show correct for whatever timezone the user happens to be in: https://github.com/sul-dlss/happy-heron/blob/main/app/components/local_time_component.rb
I would be very careful deploying the change you just made because this app was fully tested with the UTC timezone and changing zones possibly introduces a number of new bugs.

That makes sense, after making the change I wondered about other side effects.  I'm not sure really what could they be,  but would rather revert and tackle on the display side instead instead of risk adding new issues.  See #2183

Attempt at using the LocalTimeComponent: #2184


[bug] cargo run --example streaming isn't working on linux (tested on ubuntu, archlinux)

Describe the bug
I am interested in the Tauri streaming feature; I run the cargo run --example streaming. The window with the video player opened, but no video is shown. It was downloaded, and the mp4 file is working (verified in another video player), but playback/streaming in the Tauri example seems not to work.
I tried in macOS and Windows and it all works, but in Linux(Arch vanilla, Manjaro, Ubuntu22.04) won't work.
Reproduction
No response
Expected behavior
No response
Platform and versions
Environment
› OS: Arch Linux Rolling Release X64
› Node.js: 16.13.2
› npm: 8.15.1
› pnpm: 6.32.3
› yarn: 1.22.19
› rustup: 1.25.1
› rustc: 1.63.0
› cargo: 1.63.0
› Rust toolchain: stable-x86_64-unknown-linux-gnu
Packages
› @tauri-apps/cli [NPM]: 1.1.1
› @tauri-apps/api [NPM]: Not installed!
› tauri [RUST]: 1.1.1,
› tauri-build [RUST]: 1.1.1,
› tao [RUST]: 0.14.0,
› wry [RUST]: 0.21.1,
App
› build-type: bundle
› CSP: unset
› distDir: []
› devPath: []
App directory structure
├─ target
├─ .docker
├─ .vscode
├─ .changes
├─ .devcontainer
├─ .github
├─ core
├─ .git
├─ .husky
├─ .scripts
├─ audits
├─ examples
└─ tooling
Stack trace
No response
Additional context
No response

Streaming doesn't work on Linux because it doesn't have headers support see https://github.com/tauri-apps/wry/issues/422

Yes, I just found out this is the reason.
But maybe notice this in the readme section of the example? Cause I only see a little comment on line 87 of the source code.

// Actually only macOS and Windows are supported. Linux will ALWAYS return empty headers.

yeah sure, feel free to PR it

I think it's actually https://github.com/tauri-apps/tauri/issues/3725
the streaming example used to work on Linux too, it just didn't stream the file but pushed the whole file at once instead.

Yeah, that's what I thought at first, on line 109 it read the whole file to buffer and sent status code 200 to the front end.
But what I got in the network tab is the same as #3725.


Add Adreno GPU support

Add new OpenCL backend to support Adreno GPUs

[x] I have read the contributing guidelines
Self-reported review complexity:

[ ] Low
[ ] Medium
[ ] High

@lhez  I looks a nice feature for qualcomm SoCs.
I've tested this on QCS8550, and faced a following issue. (It might be a problem dependent on gpu driver.)
1st (Due to the different gpu device name, ignored gpu acceleration)
ggml_opencl: selecting platform: 'QUALCOMM Snapdragon(TM)'
ggml_opencl: selecting device: 'QUALCOMM '

So, tested with the following change.
// ggml/src/ggml-opencl/ggml-opencl.cpp
-    if (strstr(default_device->name, "Adreno")) {
+    if (strstr(default_device->name, "Adreno") || strstr(default_device->name, "QUALCOMM")) {

2nd (runtime error)
llama-cli -m /mnt/sdcard/models/Qwen1.5-7B-Chat-Q4_0.gguf -b 128
  -p "Explain LG." -ngl 20
ggml_opencl: selecting platform: 'QUALCOMM Snapdragon(TM)'
ggml_opencl: selecting device: 'QUALCOMM '
ggml_opencl: Unsupported Adreno GPU: , using wave size 128, may not work as expected
ggml_opencl: device OpenCL version: OpenCL 3.0
ggml_opencl: OpenCL driver: OpenCL 3.0 QUALCOMM build: commit unknown Compiler E<IP_ADDRESS>
ggml_opencl: vector subgroup broadcast support: false
ggml_opencl: device FP16 support: true
ggml_opencl: mem base addr align: 1024
ggml_opencl: max mem alloc size: 256 MB
ggml_opencl: SVM coarse grain buffer support: true
ggml_opencl: SVM fine grain buffer support: true
ggml_opencl: SVM fine grain system support: false
ggml_opencl: SVM atomics support: true
ggml_opencl: flattening quantized weights representation as struct of arrays (GGML_OPENCL_SOA_Q)
ggml_opencl: using kernels optimized for Adreno (GGML_OPENCL_USE_ADRENO_KERNELS)
ggml_opencl: (backend_ctx->A_q_d_max = clCreateBuffer(context, 0, max_A_q_d_bytes, NULL, &err), err) error -61 at /usr/src/debug/llama-cpp-adreno/1.0-r0/git/ggml/src/ggml-opencl/ggml-opencl.cpp:803
/usr/src/debug/llama-cpp-adreno/1.0-r0/git/ggml/src/ggml-opencl/ggml-opencl.cpp:803: GGML_ASSERT(0) failed
[New LWP 3809968]
warning: Unable to determine the number of hardware watchpoints available.
warning: Unable to determine the number of hardware breakpoints available.
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/libthread_db.so.1".
0x0000007f8b26a558 in __GI___wait4 (pid=3809976, stat_loc=0x7fe7fb8468, options=0, usage=0x0) at ../sysdeps/unix/sysv/linux/wait4.c:30
30	../sysdeps/unix/sysv/linux/wait4.c: No such file or directory.
#0  0x0000007f8b26a558 in __GI___wait4 (pid=3809976, stat_loc=0x7fe7fb8468, options=0, usage=0x0) at ../sysdeps/unix/sysv/linux/wait4.c:30
30	in ../sysdeps/unix/sysv/linux/wait4.c
#1  0x00000055745b2cf8 [PAC] in ?? ()
#2  0x00000055745addec [PAC] in ?? ()
#3  0x00000055745af0e8 [PAC] in ?? ()
#4  0x00000055745af514 [PAC] in ?? ()
#5  0x000000557456ab00 [PAC] in ?? ()
#6  0x000000557456b3b4 [PAC] in ?? ()
#7  0x00000055744bb2e0 [PAC] in ?? ()
#8  0x0000005574454038 [PAC] in ?? ()
#9  0x000000557445b2cc [PAC] in ?? ()
#10 0x0000005574433988 [PAC] in ?? ()
#11 0x0000007f8b1db4b0 [PAC] in __libc_start_call_main (main=main@entry=0x5574433910, argc=argc@entry=9, argv=argv@entry=0x7fe7fbe4d8) at ../sysdeps/nptl/libc_start_call_main.h:58
58	../sysdeps/nptl/libc_start_call_main.h: No such file or directory.
#12 0x0000007f8b1db58c [PAC] in __libc_start_main_impl (main=0x5574433910, argc=9, argv=0x7fe7fbe4d8, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=<optimized out>) at ../csu/libc-start.c:389
389	../csu/libc-start.c: No such file or directory.
#13 0x000000557443e570 [PAC] in ?? ()
[Inferior 1 (process 3809967) detached]
Aborted (core dumped)


Change nav to within container rather than full width?

This came up in #111
Currently the nav goes full width.
Full Width Navigation (current behavior)

Should we change it to be within the .container area?
Within Container Navigation (new default?)

Yes! You answered my issue I asked about this (fixed it, thank you) and yes I totally think this should be the default, 100%.

I mentioned this idea here awhile back about changing the .wrap class in structural wraps to .container.
I think we should reconsider this or doing something similar.
Currently "almost" every aspect of this theme is customizable via actions/filters, with the menu containers being one of the exceptions. True, there's always the option of completely overriding the bsg_nav_menu_markup_filter, but that would be a TON of code to copy and paste into another function when simply trying to change
  to
.
The obvious answer is just hard code the change on a theme to theme basis, but this defeats a lot of what the theme is trying to accomplish. For example, filters like bsg_navbar_brand become completely pointless the second we edit the bootstrap-genesis/lib/nav.php file.
So if we did something like this (this could also be added to bsg-classes-to-add instead):
add_filter( 'genesis_attr_structural-wrap', 'bsg_attributes_structural_wrap' );
function bsg_attributes_structural_wrap( $attributes ) {
	$attributes['class'] = 'container';
	return $attributes;
}

We could delete
 all together from nav.php.
Then by simply adding the nav and subnav to genesis-structural-wraps we can let people edit this via a filter...
add_theme_support( 'genesis-structural-wraps', array(
        'nav',
        'subnav',
	//'header',
	//'site-inner',
	//'footer-widgets',
	//'footer'
) );

Then the site developer could override much easier... For example they could change all wrap containers to container-fluids or do things on an individual basis.... Like if they wanted to remove or change one just filter the specific wrap
add_filter( 'genesis_structural_wrap-menu-primary', '__return_empty_string' );

Update: Adding a helper function would let developers change or remove container to container-fluid wraps on the fly. Currently the hard coded container-fluid method were implementing limits the value a lot of the functionality in that file if the developer has to make his changes there instead of functions.php. We have a filter for the navbar-brand and are even conditionally checking for ubermenu. This is the only part in that entire file that's not overridable with a filter (as far as I'm aware).
So basically if we implement this code below, developers will be able to change and add structural wraps and fluid structural wraps to any part of their site dynamically.
// Replace wrap with container
add_filter( 'genesis_attr_structural-wrap', 'bsg_attributes_structural_wrap' );
function bsg_attributes_structural_wrap( $attributes ) {
    $attributes['class'] = 'container';
    return $attributes;
}
// Allow for containers to be changed on the fly with a filter
function bsg_wrap_container_fluid( $output, $original_output ) {
	if ( $original_output == 'open' ) {
	   	$output = sprintf( '
', genesis_attr( 'container-fluid' ) );
	}
	return $output;
}

Then all that's needed to change the menus is this, which could be added to functions.php, templates, etc.
add_filter( 'genesis_structural_wrap-menu-primary', 'bsg_wrap_container_fluid', 16, 2); // .container-fluid primary menu
add_filter( 'genesis_structural_wrap-menu-secondary', 'bsg_wrap_container_fluid', 16, 2); // .container-fluid secondary menu

So it would now look like this:
function bsg_nav_menu_markup_filter( $html, $args ) {
    if (
        'primary'   !== $args->theme_location &&
        'secondary' !== $args->theme_location
    ) {
        return $html;
    }
    $data_target = "nav-collapse" . sanitize_html_class( '-' . $args->theme_location );
    $output = <<<EOT

          <button type="button" class="navbar-toggle collapsed" data-toggle="collapse" data-target="#{$data_target}">
            Toggle navigation

          </button>
EOT;
        if ( 'primary' === $args->theme_location ) {
            $output .= apply_filters( 'bsg_navbar_brand', bsg_navbar_brand_markup() );
        }
        $output .= '
'; // .navbar-header
        $output .= "
";
        $output .= $html;
        $output .= '
'; // .collapse .navbar-collapse
    return $output;
}

This would also allow you to add additional items to the navbar dynamically....
Alternatively, the bsg-classes-to-add way we change:

to use genesis_attr....
printf( '
', genesis_attr( 'menu-container' ) );
Then in bsg-classes-to-add you add:
'menu-container' => 'container',
Personally I think the first ways better since it adds support for structural wraps.
I'm using this on all my sites and it's very handy.


embed如何使用?

embed如何使用?

Hi, u can improve the question according to the issue template to provide more information👏.

这个web框架还不支持使用 embed吗

这个web框架还不支持使用 embed吗

Yes and same to https://github.com/cloudwego/hertz/issues/324 cc @welkeyever

Hi, u can improve the question according to the issue template to provide more information👏.

Perhaps we could add a CI to limit the specification of the pull request and issue template.  refer to https://github.com/go-gorm/gorm.

Repeated PR's are temporarily closed.


the way for checking if a file is APK is not so accurate

Hi all:
I just found one file whose first two bytes is "PK" and after being unzipped it contains the AndroidManifest.xml file but it's not APK file, the file is identified as APK file by androguard but in fact it doesn't contain classes.dex file, and I tried to install it on the mobile phone, it failed.
so when checking if a file is APK or not, it's more accurate to adding another condition for checking if it contains AndroidManifest.xml file and classes.dex at the same time after being unzipped.
androguard version: Androguard 2.0
python version: 2.7
the wrongly judged file is in the attachment.
libandroid-phone-businesscommon-language.zip

Checking for AndroidManifest.xml is the valid way. An APK is not obligated to contain classes.dex or resources.arsc nor any other files but must have a AndroidManifest.xml.
If the file is installable on an android device is another question, but as far as i know we can unfortunately not check that...


[5.5] clone query without order by for aggregates

Right now if there is a global scope that applies an order to the query, it will break counts and other aggregates when MySQL is in strict mode and there is no group-by in place (see issues like 15232, 18789, 14997, etc). This change is to fix that without having to set MySQL to non-strict mode or tell users to change their strict mode flags. It's also a low-impact change - if there are no groupings on the query, then any order is irrelevant anyway so this does not have any side-effects.

@taylorotwell if I PR this on the 5.4 branch, can this get merged for a future 5.4.x patch release?

@vetruvet you only mentioned MySQL but I can attest the same fix is necessary for Postgres too. We previously used a local workaround which, thank to your PR, isn't needed anymore 👍


Error fetching sbt-giter8-scaffold

steps

ENV:
System: Darwin MacBookPro.local 21.4.0 Darwin Kernel Version 21.4.0;
root:xnu-8020.101.4~2/RELEASE_ARM64_T6000 arm64

JDK: OpenJDK 11.0.18

SBT: sbt 1.5.2

problem

The dependency download fails. Status 404 is returned from the repository.
[info] welcome to sbt 1.5.2 (Eclipse Adoptium Java 11.0.18)
[info] loading settings for project bzm-lounge-build from plugins.sbt ...
[info] loading project definition from {project}
[warn]
[warn] 	Note: Some unresolved dependencies have extra attributes.  Check that these dependencies exist with the requested attributes.
[warn] 		org.foundweekends.giter8:sbt-giter8-scaffold:0.11.0 (sbtVersion=1.0, scalaVersion=2.12)
[warn]
[warn] 	Note: Unresolved dependencies path:
[error] sbt.librarymanagement.ResolveException: Error downloading org.foundweekends.giter8:sbt-giter8-scaffold;sbtVersion=1.0;scalaVersion=2.12:0.11.0
[error]   Not found
[error]   Not found
[error]   not found: https://repo1.maven.org/maven2/org/foundweekends/giter8/sbt-giter8-scaffold_2.12_1.0/0.11.0/sbt-giter8-scaffold-0.11.0.pom
[error]   not found: https://repo.typesafe.com/typesafe/ivy-releases/org.foundweekends.giter8/sbt-giter8-scaffold/scala_2.12/sbt_1.0/0.11.0/ivys/ivy.xml

[error] (update) sbt.librarymanagement.ResolveException: Error downloading org.foundweekends.giter8:sbt-giter8-scaffold;sbtVersion=1.0;scalaVersion=2.12:0.11.0
[error]   Not found
[error]   Not found
[error]   not found: https://repo1.maven.org/maven2/org/foundweekends/giter8/sbt-giter8-scaffold_2.12_1.0/0.11.0/sbt-giter8-scaffold-0.11.0.pom
[error]   not found: https://repo.typesafe.com/typesafe/ivy-releases/org.foundweekends.giter8/sbt-giter8-scaffold/scala_2.12/sbt_1.0/0.11.0/ivys/ivy.xml

Accessing the following link(https://scala.jfrog.io/ui/native/ivy-releases/org.foundweekends.giter8/sbt-giter8-scaffold/scala_2.12/sbt_1.0/0.11.0/ivys/ivy.xml) returns the 404 page as follows.

expectation
Dependencies should be download successfully.

notes

is the problem reproducible with sbt 1.8.2? 1.5.2 is very old.
the plugin fetches fine for me with 1.8.2:
% cat project/plugins.sbt
addSbtPlugin("org.foundweekends.giter8" % "sbt-giter8-scaffold" % "0.11.0")
[info] welcome to sbt 1.8.2 (Eclipse Adoptium Java 17.0.6)
[info] loading settings for project sbt-7211-build from plugins.sbt ...
[info] loading project definition from /Users/tisue/tmp/sbt-7211/project
[warn] sbt-giter8-scaffold.jar no longer exists at /Users/tisue/Library/Caches/Coursier/v1/https/repo.scala-sbt.org/scalasbt/sbt-plugin-releases/org.foundweekends.giter8/sbt-giter8-scaffold/scala_2.12/sbt_1.0/0.11.0/jars/sbt-giter8-scaffold.jar
[info] Updating
https://repo.scala-sbt.org/scalasbt/sbt-plugin-releases/org.foundweekends.giter8/sbt-giter8-scaffold/scala_2.12/sbt_1.0/0.11.0/ivys/ivy.xml
  100.0% [##########] 1.7 KiB (1.3 KiB / s)
[info] Resolved  dependencies
[info] Fetching artifacts of
[info] Fetched artifacts of
[info] set current project to sbt-7211 (in build file:/Users/tisue/tmp/sbt-7211/)
...

perhaps you are experiencing some transient and/or local aftereffect of #7202

@joelonsw I see that you :+1: Seth's response so I am closing this issue. Feel free to reopen it if you think there is still a bug.

@joelonsw you are mistaken; those artifacts never existed on repo1.maven.org or repo.typesafe.com. see #7205
the artifacts do exist on repo.scala-sbt.org — please re-read my comment above

glad to hear it’s sorted! when I get a moment I’ll add your caching advice to the other tickets


chore(apps/gcp/prow/release): update deployment for jenkins operator to skip report

Reverts PingCAP-QE/ee-ops#492

/hold

/chatgpt review it again

/unhold


How to play 4 simultaneous streams ?

Hello everyone !
Thanks for this awesome project !!
I've added 4 rtsp sources but I want to stream all of them into one single stream
How can I do that ?
Thanks a lot

Just use ffmpeg https://github.com/AlexxIT/WebRTC/issues/73#issuecomment-1221529663

streams:
mosaic: exec:ffmpeg -i<EMAIL_ADDRESS>-i<EMAIL_ADDRESS>-vcodec libx264 -tune zerolatency -filter_complex "[0:v]scale=640:-1[v0];[v0][1:v]hstack=inputs=2" -f rtsp {output}

streams:
    mosaic: exec:ffmpeg -i<EMAIL_ADDRESS>-i<EMAIL_ADDRESS>-vcodec libx264 -tune zerolatency -filter_complex "[0:v]scale=640:-1[v0];[v0][1:v]hstack=inputs=2" -f rtsp {output}

Can you share some additional context on how this is used?


Can I derive a 3D obj model for mapping?

You can use the DSM (.tif file) generated by create_satnerf_dsm.py for this. But the conversion from .tif to 3D formats like .obj or .ply is not part of this code. There are multiple online tools for that, you can check this discussion for instance.

Thanks!


Add mechanism to show contextual alerts and show 'Saved' when successful update

Introduce GradebookNotificationSystem to handle displaying contextual alert messages (info, success, errors).
Replace global Wicket-Ajax event listener with specific AjaxCallListeners on the AjaxEditableLabels.  These new events now trigger a global GradebookWicketEventProxy which passes the event on the cell's model to handle.
Show a success alert upon successful save.

I think we can do this a more Wickety way. There is already a feedback panel on the BasePage that we can load messages into.  The Morpheus styles are getting in the way again, though but that can be adjusted.
In the BasePage.java it adds the 'alertMessage' or 'success' classes to the component depending on the type of message that it receives, so we can load error/success/info etc message into it. Those styles can definitely change, perhaps this could be modified to use the styles that you created for this? We could attach a fadeout as well, I did that in Profile2.
I can then update the message that it prints out.
cheers

Ah cool no probs.  There's some javascript changes I'd still like to be merged, so I'll remove my GradebookNotificationSystem and submit a new PR with just those changes.
Thanks

Ok nice one. Cheers :)
On Thu, Apr 2, 2015 at 10:19 AM, Payten Giles<EMAIL_ADDRESS>wrote:

Ah cool no probs. There's some javascript changes I'd still like to be
merged, so I'll remove my GradebookNotificationSystem and submit a new PR
with just those changes.
Thanks
—
Reply to this email directly or view it on GitHub
https://github.com/steveswinsburg/gradebookNG/pull/32#issuecomment-88662006
.


Help deploying Grafana Dashboards using Generic Rules

Hi,
First and foremost, just wanted to say that this is a fantastic project and that I thoroughly appreciate all of the work that has gone into this so far!
I was setting up a POC using the example manifests which is working great so far.
I also wanted to get the Grafana Dashboards working however I am relatively new to Grafana and feel like I am missing something obvious. I followed your instructions and created a ConfigMap containing the Generic Rules definition. I the tried to mount that ConfigMap as a volume inside the pyrra kuberentes Deployment and pass it the --generic-rules arg along with the path to the file however, the pyrra image doesn't seem to like that flag and is Crash Looping with the following message:
pyrra: error: unknown flag --generic-rules

Am I going about this the correct way?

Maybe it would be great to specify which image/chart you are using 🙄.

Are you using it correctly 🤔? I got same error only if I use it wrongly, like:
$ docker run -ti ghcr.io/pyrra-dev/pyrra:v0.7.0  --generic-rules
pyrra: error: unknown flag --generic-rules

If I use it in correct way, then there is no such an error:
$ docker run -ti ghcr.io/pyrra-dev/pyrra:v0.7.0 generate --generic-rules
level=info ts=2023-10-25T13:27:24.404827723Z caller=main.go:142 msg="using Prometheus" url=http://localhost:9090

Awesome, thanks! Will close now.

Glad you found a solution!
--generic-rules actually only works on the filesystem, kubernetes or generate sub commands. It doesn't work on the default api command as that one only serves APIs and UIs and never generates anything.


Drop foreman develop PR upgrade job

The idea is to drop this as it's not as useful given it's not testing very much data and to explore a similar test using a more robust database.

I'll mention that.


Codeunit : Undo Purchase Receipt Line (5816) - Procedure: UpdateOrderLine

Hi,
can you please add a new event in the procedure UpdateOrderLine of "Undo Purchase Receipt Line" codeunit
//>New Event
OnBeforeUpdateSalesLine(var ReturnRcptLine: Record "Return Receipt Line",var isHandled: boolean);
//<New Event
//>Old Procedure
procedure UpdateOrderLine(ReturnRcptLine: Record "Return Receipt Line")
var
SalesLine: Record "Sales Line";
begin
with ReturnRcptLine do begin
SalesLine.Get(SalesLine."Document Type"::"Return Order", "Return Order No.", "Return Order Line No.");
UndoPostingMgt.UpdateSalesLine(SalesLine, Quantity, "Quantity (Base)", TempGlobalItemLedgEntry);
OnAfterUpdateSalesLine(ReturnRcptLine, SalesLine);
end;
end;
//<Old Procedure
//>New Procedure
procedure UpdateOrderLine(ReturnRcptLine: Record "Return Receipt Line")
    var
        IsHandled: Boolean;
        SalesLine: Record "Sales Line";
    begin
        with ReturnRcptLine do begin
            IsHandled := false;
           OnBeforeUpdateSalesLine(ReturnRcptLine,isHandled);
           if IsHandled then
               exit;
           SalesLine.Get(SalesLine."Document Type"::"Return Order", "Return Order No.", "Return Order Line No.");
           UndoPostingMgt.UpdateSalesLine(SalesLine, Quantity, "Quantity (Base)", TempGlobalItemLedgEntry);
           OnAfterUpdateSalesLine(ReturnRcptLine, SalesLine);
        end;
    end;

//<New Procedure

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Suggestion for installing scoped generator is wrong

Type of issue
Bug

My environment

OS version/details: Windows 10 64-bit
Node version: 6.1.0
npm version: 4.5.0
Version of yo : 1.8.5

Expected behavior
Attempting to run a scoped generator (e.g. yo @somescope/somegen) should tell the user how to install it if it doesn't exist. The npm install suggestion should be npm install @somescope/generator-somegen.
Current behavior
The message is npm install generator-@somescope/somegen.
Steps to reproduce the behavior
Run yo @foo/bar when you do not have @foo/generator-bar installed.
Command line output
λ yo @foo/bar
Error @foo/bar

You don’t seem to have a generator with the name “@foo/bar” installed.
But help is on the way:

You can see available generators via npm search yeoman-generator or via http://yeoman.io/generators/.
Install them with npm install generator-@foo/bar.

To see all your installed generators run yo without any arguments. Adding the --help option will also show subgenerators.

If yo cannot find the generator, run yo doctor to troubleshoot your system.

PR welcomed, it should be an easy fix on that line: https://github.com/yeoman/environment/blob/566db2a04fec5ab525b63aca0d600ecef5510b9d/lib/environment.js#L343

Can you guys please close the issues that are fixed

@buoyantair We try to. But it’s kinda hard to keep track of every single issue within the yeoman organisation.
So any help really is appriciated. Even if you just leave a not like to did in here.
So, thank you for pointing to this.

Can scoped generators just be @foo/generator?


Enhancing Data Package Linking: Declare Revisions During Submission

We have encountered a recurring problem where data package submissions are inadvertently published as new data package series instead of being published as revisions to existing ones. This leads to data discovery issues, as data users may not be aware of the updated packages, causing fragmentation in data access.
This issue typically arises due to either a lack of communication from the author regarding the nature of the submission or an oversight on the part of data curators to request this information. As a result, information is lost, and suboptimal actions are taken.
To mitigate this problem, we propose implementing a solution within the "Submit Package to EDI" page of ezEML. Specifically, we suggest introducing a simple yes/no radio button for submitters to answer the question: "Is this submission an update to an existing data package?"
If the submitter selects "yes," an additional text field would appear, prompting them to provide the data package's URL, DOI, or data package identifier.
The information gathered through this inquiry would be sent along with the submission to<EMAIL_ADDRESS>making it readily available for curators to review and act upon.
Thoughts?

Sounds like a great idea. Should be easy to add...

Thanks for considering this @jon-ide.
If you think it might be helpful, I'd be happy to bring this up in the team meeting this week to get other perspectives on it and   then summarize the conversation back here.

Doesn't seem controversial...

Hi @jon-ide, the changes applied in 7ef5c45c3060f6c77e3add55b0d581fa9fbb8601 look great!
What do you think about setting the initial state of the radio buttons to be off/unselected and then validating that the user has selected one or other options before the submission is allowed to pass?
This would catch the case where a rushed user mistakenly overlooks the prompt.

I've made the change @clnsmth suggested, to leave the radio buttons unselected by default and check that a selection is made. Thanks for the suggestion!

This looks great @jon-ide, thanks.


Server initiated WebSocket close does not wait for client close handshake before closing the socket

After sending down a close frame to the client, the server code closes the socket immediately, without waiting for the client to respond. This violates the WebSocket specification: https://tools.ietf.org/html/rfc6455#section-7.1.2

Once an endpoint has both sent and received a Close control frame, that endpoint SHOULD Close the WebSocket Connection

I noticed this while trying to return a status code down to the client (in this case, SocketRocket). SocketRocket considers a TCP socket closure before it can send its close handshake as an abnormal socket termination, and thus does not propagate up the status code from the close frame to the calling code, and instead returns an error code. As mentioned above, this is compliant with the WebSocket specification.
I'm happy to submit a patch addressing this, but I'd like some guidance on behavior:

Per the spec, after sending a close frame, there should no longer be any writes to the socket. After receiving the close handshake, it can close the socket. Due to the asynchronous nature of cowboy, data frames may still be received by the handler process after the close frame is sent, and a handler could still attempt to send some data down in response to these frames. What should happen here? We could return an error back up somehow, or silently drop the incoming frames, or silently drop any outgoing frames, or consider this behavior buggy and crash the process. Or make this configurable among some or all these options. Thoughts?

There probably should be some sort of timeout option to shutdown things in case the close handshake is not received. Should this be configurable on its own, or tied in with the init handshake timeout? If the former, what should the default be?

It does not violate the spec. SHOULD is not an absolute requirement, it can be ignored if there are good reasons. In Cowboy's case the reason is to not want to keep around connections unnecessarily. In the spec it means we are not closing the connection cleanly.
There is however an issue in your client, since all the spec in 7.1.5 says is:
   The WebSocket Connection Close Code_ is
   defined as the status code (Section 7.4) contained in the first Close
   control frame received by the application implementing this protocol.

It doesn't say anywhere that the connection needs to be cleanly closed to give a close code to the application, just that the first close frame contains it. Also read the rest of this section as it explains what the close code is when the close frame doesn't contain a code, or the connection was closed without a close frame. In all cases there's a close code defined. In our case it's the one sent by the server.
Closing, thanks!


Move Google Analytics directly into the app

Now that we're not serving with GH Pages, the analytics can't be added outside the app

Update - well, most of the things don't work, because they only let you edit the body, not the header and the header is what we need. So I went with this hack, adding the analytics code directly to the local streamlit package's index.html. If we end up putting another app here, that we want to track, then we'll need to set up some venvs and fix some stuff.


A way to replace elements instead of using it as a container (feature request)

Ractive is awesome! I'd also love to be able to do:
new Ractive({
  template: '
New h2
',
  el: $('h1'),
  replace: true
});

...and have the
 be replaced with the new
, instead of having h2 being contained inside the h1.
(Related: #471)

I'm closing this since you can insert templates before elements, so replacing an existing element would not be too difficult using ractive.render and a bit of js.


Add json patch updates

Add support for json patch updates: https://identity.foundation/sidetree/docs/spec/#ietf-json-patch
Refactor resolve utils
Add more logs when running tests locally (not CI)

Codecov Report

Merging #185 into master will increase coverage by 0.09%.
The diff coverage is 95.68%.

@@            Coverage Diff             @@
##           master     #185      +/-   ##
==========================================
+ Coverage   35.46%   35.55%   +0.09%
==========================================
  Files         186      187       +1
  Lines        3023     3029       +6
  Branches      231      231
==========================================
+ Hits         1072     1077       +5
- Misses       1841     1842       +1
  Partials      110      110

Impacted Files
Coverage Δ

packages/element-lib/src/__tests__/test-utils.js
100.00% <ø> (ø)

.../element-lib/src/sidetree/resolve/resolve-utils.js
95.62% <95.58%> (ø)

packages/element-lib/src/sidetree/resolve/index.js
100.00% <100.00%> (+2.95%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 405488e...3826df6. Read the comment docs.

Codecov Report

Merging #185 into master will increase coverage by 0.38%.
The diff coverage is 94.90%.

@@            Coverage Diff             @@
##           master     #185      +/-   ##
==========================================
+ Coverage   35.46%   35.85%   +0.38%
==========================================
  Files         186      187       +1
  Lines        3023     3046      +23
  Branches      231      232       +1
==========================================
+ Hits         1072     1092      +20
- Misses       1841     1844       +3
  Partials      110      110

Impacted Files
Coverage Δ

.../element-lib/src/sidetree/resolve/resolve-utils.js
94.59% <94.59%> (ø)

packages/element-lib/src/sidetree/op/index.js
100.00% <100.00%> (ø)

packages/element-lib/src/sidetree/resolve/index.js
100.00% <100.00%> (+2.95%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 405488e...ff58af7. Read the comment docs.


Fully enforce model permissions in search

This makes various changes to get permissions fully working with search:

Enforces read permissions in global search
Enforces investment association permissions in global and investment project entity search
Updates ES models so that created_by and various investment project fields include the adviser's team
Adds signal receivers for investment project team member changes

The datahub.search.elasticsearch module really needs splitting up into multiple modules, hopefully we can look at that soon.

Codecov Report

Merging #706 into develop will increase coverage by 0.08%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #706      +/-   ##
===========================================
+ Coverage    96.53%   96.61%   +0.08%
===========================================
  Files          132      133       +1
  Lines         3781     3812      +31
  Branches       345      354       +9
===========================================
+ Hits          3650     3683      +33
+ Misses          87       86       -1
+ Partials        44       43       -1

Impacted Files
Coverage Δ

datahub/search/company/views.py
100% <ø> (ø)
:arrow_up:

datahub/search/omis/views.py
100% <ø> (ø)
:arrow_up:

datahub/search/event/views.py
100% <ø> (ø)
:arrow_up:

datahub/search/companieshousecompany/views.py
100% <ø> (ø)
:arrow_up:

datahub/search/contact/views.py
100% <ø> (ø)
:arrow_up:

datahub/search/investment/views.py
100% <ø> (ø)
:arrow_up:

datahub/search/interaction/views.py
100% <ø> (ø)
:arrow_up:

datahub/search/urls.py
88.88% <ø> (ø)
:arrow_up:

datahub/core/permissions.py
91.3% <100%> (+5.09%)
:arrow_up:

datahub/search/dict_utils.py
75% <100%> (+1.19%)
:arrow_up:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c84a27f...5f3bae5. Read the comment docs.

I'm a bit worried that the logic behind permissions on an endpoint is in different places (IsAssociatedToInvestmentProjectFilter and InvestmentSearchApp).
Not sure if we can do anything about it

Yes, that's a fair point. I think I can centralise a bit more of the logic so I'll give that a go.

@marcofucci I centralised the generation of the filtering rules in datahub.investment.permissions.get_association_filters(). I also noticed and fixed a couple of problems around users with no teams.
I think we can get rid of InvestmentProject.get_associated_advisers() as well (and use get_association_filters()), but that might be something to look at another time.

Looks good to me. Nice.


installation waybar fails (catch2/mathcers/catch_mathcers_range_equals.hpp) can't be found

Heija and thanks for your work.
If been trying to build waybar with experimental options enabled.
However ninja -C build runs into a problem with catch2. Compilation of the test/waybar_test.p/main.cpp.o file fails as catch2/matchers/catch_matchers_range_equals.hpp on Line 30 can't be found.
Is this a general problem?

Hi @krankeradler . Waiting for Catch release:  catchorg/Catch2#2722

I'm getting the same error building on Ubuntu 22.04. I used the apt install <dependencies> snippet in the readme. meson build passes. ninja -C build does not.
Full log:
~ git clone https://github.com/Alexays/Waybar && cd Waybar
Cloning into 'Waybar'...
remote: Enumerating objects: 17802, done.
remote: Counting objects: 100% (17802/17802), done.
remote: Compressing objects: 100% (4617/4617), done.
remote: Total 17802 (delta 12986), reused 17757 (delta 12974), pack-reused 0
Receiving objects: 100% (17802/17802), 3.85 MiB | 2.22 MiB/s, done.
Resolving deltas: 100% (12986/12986), done.

~ meson build
The Meson build system
Version: 0.61.2
Source dir: /home/nsbruce/Waybar
Build dir: /home/nsbruce/Waybar/build
Build type: native build
Project name: waybar
Project version: 0.9.24
C compiler for the host machine: cc (gcc 11.4.0 "cc (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0")
C linker for the host machine: cc ld.bfd 2.38
C++ compiler for the host machine: c++ (gcc 11.4.0 "c++ (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0")
C++ linker for the host machine: c++ ld.bfd 2.38
Host machine cpu family: x86_64
Host machine cpu: x86_64
Compiler for C++ supports link arguments -lc++fs: NO
Compiler for C++ supports link arguments -lc++experimental: NO
Compiler for C++ supports link arguments -lstdc++fs: YES
Program git found: YES (/usr/bin/git)
WARNING: You should add the boolean check kwarg to the run_command call.
         It currently defaults to false,
         but it will default to true in future releases of meson.
         See also: https://github.com/mesonbuild/meson/issues/9300
Has header "filesystem" : YES
Checking if "nl_langinfo with _NL_TIME_WEEK_1STDAY, _NL_TIME_FIRST_WEEKDAY" : links: YES
Run-time dependency threads found: YES
Found pkg-config: /usr/bin/pkg-config (0.29.2)
Run-time dependency fmt found: YES 9.1.0
Dependency spdlog found: NO found 1.9.2 but need: '>=1.10.0'
Found CMake: /usr/bin/cmake (3.22.1)
WARNING: CMake: Dependency -Wl,--as-needed for spdlog was not found
Dependency spdlog found: NO found 1.9.2 but need: '>=1.10.0'
Run-time dependency spdlog found: NO (tried pkgconfig and cmake)
Looking for a fallback subproject for the dependency spdlog
Downloading spdlog source from https://github.com/gabime/spdlog/archive/v1.11.0.tar.gz
Downloading file of unknown size.
Downloading spdlog patch from https://wrapdb.mesonbuild.com/v2/spdlog_1.11.0-2/get_patch
Download size: 2645
Downloading: ..........

Executing subproject spdlog

spdlog| Project name: spdlog
spdlog| Project version: 1.11.0
spdlog| C++ compiler for the host machine: c++ (gcc 11.4.0 "c++ (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0")
spdlog| C++ linker for the host machine: c++ ld.bfd 2.38
spdlog| Dependency threads found: YES unknown (cached)
spdlog| Dependency fmt found: YES 9.1.0 (cached)
spdlog| Build targets in project: 1
spdlog| Subproject spdlog finished.

Dependency spdlog from subproject subprojects/spdlog-1.11.0 found: YES 1.11.0
Run-time dependency wayland-client found: YES 1.20.0
Run-time dependency wayland-cursor found: YES 1.20.0
Run-time dependency wayland-protocols found: YES 1.25
Run-time dependency gtkmm-3.0 found: YES 3.24.5
Run-time dependency dbusmenu-gtk3-0.4 found: YES 16.04.0
Run-time dependency gio-unix-2.0 found: YES 2.72.4
Run-time dependency jsoncpp found: YES 1.9.4
Run-time dependency sigc++-2.0 found: YES 2.10.4
Run-time dependency libinotify found: NO (tried pkgconfig and cmake)
Run-time dependency epoll-shim found: NO (tried pkgconfig and cmake)
Run-time dependency libinput found: YES 1.20.0
Run-time dependency libnl-3.0 found: YES 3.5.0
Run-time dependency libnl-genl-3.0 found: YES 3.5.0
Run-time dependency upower-glib found: NO (tried pkgconfig and cmake)
Run-time dependency libpipewire-0.3 found: NO (tried pkgconfig and cmake)
Run-time dependency playerctl found: NO (tried pkgconfig and cmake)
Run-time dependency libpulse found: YES 15.99.1
Run-time dependency libudev found: YES 249
Run-time dependency libevdev found: YES 1.12.1
Run-time dependency libmpdclient found: YES 2.20
Run-time dependency xkbregistry found: YES 1.4.0
Run-time dependency jack found: NO (tried pkgconfig and cmake)
Run-time dependency wireplumber-0.4 found: NO (tried pkgconfig and cmake)
Library sndio found: NO
Run-time dependency gtk-layer-shell-0 found: NO (tried pkgconfig and cmake)
Looking for a fallback subproject for the dependency gtk-layer-shell-0
Downloading gtk-layer-shell source from https://github.com/wmww/gtk-layer-shell/archive/v0.4.0/gtk-layer-shell-0.4.0.tar.gz
Downloading file of unknown size.

Executing subproject gtk-layer-shell

gtk-layer-shell| Project name: gtk-layer-shell
gtk-layer-shell| Project version: 0.4.0
gtk-layer-shell| C compiler for the host machine: cc (gcc 11.4.0 "cc (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0")
gtk-layer-shell| C linker for the host machine: cc ld.bfd 2.38
gtk-layer-shell| Run-time dependency gtk+-wayland-3.0 found: YES 3.24.33
gtk-layer-shell| Dependency wayland-client found: YES 1.20.0 (cached)
gtk-layer-shell| Run-time dependency wayland-server found: YES 1.20.0
gtk-layer-shell| Run-time dependency wayland-scanner found: YES 1.20.0
gtk-layer-shell| Dependency wayland-protocols found: YES 1.25 (cached)
gtk-layer-shell| Program /usr/bin/wayland-scanner found: YES (/usr/bin/wayland-scanner)
gtk-layer-shell| Run-time dependency gobject-introspection-1.0 found: YES 1.72.0
gtk-layer-shell| Dependency gobject-introspection-1.0 found: YES 1.72.0 (cached)
gtk-layer-shell| Program g-ir-scanner found: YES (/usr/bin/g-ir-scanner)
gtk-layer-shell| Dependency gobject-introspection-1.0 found: YES 1.72.0 (cached)
gtk-layer-shell| Program g-ir-compiler found: YES (/usr/bin/g-ir-compiler)
gtk-layer-shell| Program python3 found: YES (/usr/bin/python3)
gtk-layer-shell| Build targets in project: 6
gtk-layer-shell| NOTICE: Future-deprecated features used:
gtk-layer-shell| * 0.56.0: {'Dependency.get_pkgconfig_variable'}
gtk-layer-shell| Subproject gtk-layer-shell finished.

Dependency gtk-layer-shell-0 from subproject subprojects/gtk-layer-shell-0.4.0 found: YES 0.4.0
Run-time dependency systemd found: YES 249
Computing int of "__cpp_lib_chrono" : 201611
Run-time dependency date found: NO (tried pkgconfig and cmake)
Looking for a fallback subproject for the dependency date (modules: date::date, date::date-tz)
Downloading date source from https://github.com/HowardHinnant/date/archive/v3.0.1.tar.gz
Download size: 825542
Downloading: ..........
Downloading date patch from https://wrapdb.mesonbuild.com/v2/hinnant-date_3.0.1-2/get_patch
Download size: 2093
Downloading: ..........

Executing subproject date

date| Project name: hinnant-date
date| Project version: undefined
date| C++ compiler for the host machine: c++ (gcc 11.4.0 "c++ (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0")
date| C++ linker for the host machine: c++ ld.bfd 2.38
date| Dependency threads found: YES unknown (cached)
date| Build targets in project: 7
date| Subproject date finished.

Dependency date (modules: date::date, date::date-tz) from subproject subprojects/date-3.0.1 found: YES undefined
Configuring waybar.service using configuration
Run-time dependency cava found: NO (tried pkgconfig and cmake)
Looking for a fallback subproject for the dependency cava
Downloading cava source from https://github.com/LukashonakV/cava/archive/0.9.1.tar.gz
Downloading file of unknown size.

Executing subproject cava

cava| Project name: cava
cava| Project version: 0.9.1
cava| C compiler for the host machine: cc (gcc 11.4.0 "cc (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0")
cava| C linker for the host machine: cc ld.bfd 2.38
cava| Has header "iniparser.h" : NO
cava| Has header "iniparser4/iniparser.h" : NO

cava| subprojects/cava-0.9.1/meson.build:65:3: Exception: Problem encountered: iniparser library is required

Subproject subprojects/cava-0.9.1 is buildable: NO (disabling)
Dependency cava from subproject cava found: NO (subproject failed to configure)
Message: cava is not found. Building waybar without cava
Message: cava is not found. Building waybar without cava
Program wayland-scanner found: YES (/usr/bin/wayland-scanner)
Program gdbus-codegen found: YES (/usr/bin/gdbus-codegen)
Found pkg-config: /usr/bin/pkg-config (0.29.2)
Program glib-compile-resources found: YES (/usr/bin/glib-compile-resources)
Build-time dependency scdoc found: YES 1.11.2
Program /usr/bin/scdoc found: YES (/usr/bin/scdoc)
Program sh found: YES (/usr/bin/sh)
Configuring waybar.5.scd using configuration
meson.build:531: WARNING: Source item '/home/nsbruce/Waybar/build/waybar.5.scd' cannot be converted to File object, because it is a generated file. This will become a hard error in the future.
Run-time dependency catch2 found: YES 3.4.0
Program clang-tidy found: YES (/usr/bin/clang-tidy)
Build targets in project: 57
NOTICE: Future-deprecated features used:
 * 0.55.0: {'ExternalProgram.path'}
 * 0.56.0: {'Dependency.get_pkgconfig_variable', 'meson.source_root', 'meson.build_root'}

waybar 0.9.24

  Subprojects
    cava           : NO Problem encountered: iniparser library is required
    date           : YES
    gtk-layer-shell: YES 1 warnings
    spdlog         : YES

Found ninja-1.10.1 at /usr/bin/ninja

~ ninja -C build
ninja: Entering directory `build'
[13/207] Generating 'subprojects/gtk-layer-she...ayer-shell.a.p/wlr-layer-shell-unstable-v1.c'.
Using "code" is deprecated - use private-code or public-code.
See the help page for details.
[16/207] Generating 'subprojects/gtk-layer-shell-0.4.0/src/libgtk-layer-shell.a.p/xdg-shell.c'.
Using "code" is deprecated - use private-code or public-code.
See the help page for details.
[49/207] Generating resources/icons/icon-resources_c with a custom command
xml-stripblanks preprocessing requested, but XMLLINT is not set, and xmllint is not in PATH
[60/207] Generating resources/icons/icon-resources_h with a custom command
xml-stripblanks preprocessing requested, but XMLLINT is not set, and xmllint is not in PATH
[81/207] Generating subprojects/gtk-layer-shel...rc/GtkLayerShell-0.1.gir with a custom command
g-ir-scanner: link: x86_64-linux-gnu-gcc -o /home/nsbruce/Waybar/build/tmp-introspectvz_t197c/GtkLayerShell-0.1 /home/nsbruce/Waybar/build/tmp-introspectvz_t197c/GtkLayerShell-0.1.o -L. -Wl,-rpath,. -Wl,--no-as-needed /home/nsbruce/Waybar/build/subprojects/gtk-layer-shell-0.4.0/src/libgtk-layer-shell.a -lgtk-3 -lgdk-3 -lpangocairo-1.0 -lpango-1.0 -lharfbuzz -latk-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -lwayland-client -lgirepository-1.0 -lgio-2.0 -lgobject-2.0 -Wl,--export-dynamic -lgmodule-2.0 -pthread -lglib-2.0
[91/207] Compiling C++ object waybar.p/src_factory.cpp.o
In file included from ../include/modules/clock.hpp:4,
                 from ../include/factory.hpp:5,
                 from ../src/factory.cpp:1:
../include/util/date.hpp:34:26: warning: literal operator suffixes not preceded by ‘_’ are reserved for future standardization [-Wliteral-suffix]
   34 | constexpr decltype(auto) operator""d(unsigned long long d) noexcept {
      |                          ^~~~~~~~
[118/207] Compiling C++ object waybar.p/src_bar.cpp.o
In file included from ../include/modules/clock.hpp:4,
                 from ../include/factory.hpp:5,
                 from ../src/bar.cpp:11:
../include/util/date.hpp:34:26: warning: literal operator suffixes not preceded by ‘_’ are reserved for future standardization [-Wliteral-suffix]
   34 | constexpr decltype(auto) operator""d(unsigned long long d) noexcept {
      |                          ^~~~~~~~
[151/207] Compiling C++ object test/waybar_test.p/main.cpp.o
FAILED: test/waybar_test.p/main.cpp.o
c++ -Itest/waybar_test.p -Itest -I../test -I../include -I../subprojects/spdlog-1.11.0/include -I../subprojects/date-3.0.1/include -I/usr/local/include -I/usr/include/gtkmm-3.0 -I/usr/lib/x86_64-linux-gnu/gtkmm-3.0/include -I/usr/include/atkmm-1.6 -I/usr/lib/x86_64-linux-gnu/atkmm-1.6/include -I/usr/include/gtk-3.0/unix-print -I/usr/include/gdkmm-3.0 -I/usr/lib/x86_64-linux-gnu/gdkmm-3.0/include -I/usr/include/giomm-2.4 -I/usr/lib/x86_64-linux-gnu/giomm-2.4/include -I/usr/include/gtk-3.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I/usr/include/gio-unix-2.0 -I/usr/include/cairo -I/usr/include/atk-1.0 -I/usr/include/pangomm-1.4 -I/usr/lib/x86_64-linux-gnu/pangomm-1.4/include -I/usr/include/glibmm-2.4 -I/usr/lib/x86_64-linux-gnu/glibmm-2.4/include -I/usr/include/cairomm-1.0 -I/usr/lib/x86_64-linux-gnu/cairomm-1.0/include -I/usr/include/sigc++-2.0 -I/usr/lib/x86_64-linux-gnu/sigc++-2.0/include -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/fribidi -I/usr/include/pixman-1 -I/usr/include/uuid -I/usr/include/freetype2 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16 -I/usr/include/x86_64-linux-gnu -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -std=c++20 -O3 '-DVERSION="0.9.24-81-g3e55d0d7 (branch '"'"'master'"'"')"' -DHAVE_LANGINFO_1STDAY '-DSYSCONFDIR="//usr/local/etc"' -DHAVE_CPU_LINUX -DHAVE_MEMORY_LINUX -DHAVE_SWAY -DHAVE_WLR -DHAVE_RIVER -DHAVE_DWL -DHAVE_HYPRLAND -DHAVE_LIBNL -DHAVE_GAMEMODE -DHAVE_LIBPULSE -DHAVE_DBUSMENU -DHAVE_LIBUDEV -DHAVE_LIBEVDEV -DHAVE_LIBINPUT -DHAVE_LIBMPDCLIENT -DHAVE_GTK_LAYER_SHELL -DHAVE_GIO_UNIX -DHAVE_LIBDATE -DUSE_OS_TZDB=1 -pthread -DSPDLOG_FMT_EXTERNAL -MD -MQ test/waybar_test.p/main.cpp.o -MF test/waybar_test.p/main.cpp.o.d -o test/waybar_test.p/main.cpp.o -c ../test/main.cpp
In file included from /usr/local/include/catch2/catch_all.hpp:126,
                 from ../test/main.cpp:7:
/usr/local/include/catch2/matchers/catch_matchers_all.hpp:30:10: fatal error: catch2/matchers/catch_matchers_range_equals.hpp: No such file or directory
   30 | #include <catch2/matchers/catch_matchers_range_equals.hpp>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
[160/207] Compiling C++ object waybar.p/src_modules_clock.cpp.o
In file included from ../include/modules/clock.hpp:4,
                 from ../src/modules/clock.cpp:1:
../include/util/date.hpp:34:26: warning: literal operator suffixes not preceded by ‘_’ are reserved for future standardization [-Wliteral-suffix]
   34 | constexpr decltype(auto) operator""d(unsigned long long d) noexcept {
      |                          ^~~~~~~~
ninja: build stopped: subcommand failed.

FWIW: I just commented out the relevant test lines in meson.build and waybar build and installed just fine.
~ git diff
diff --git a/meson.build b/meson.build
index df245a28..8205f305 100644
--- a/meson.build
+++ b/meson.build
@@ -537,11 +537,11 @@ catch2 = dependency(
     'catch2',
     version: '>=2.0.0',
     fallback: ['catch2', 'catch2_dep'],
-    required: get_option('tests'),
+    # required: get_option('tests'),
 )
-if catch2.found()
-    subdir('test')
-endif
+# if catch2.found()
+#     subdir('test')
+# endif

 clangtidy = find_program('clang-tidy', required: false)