Review - Spatial correlations

Regarding the spatial correlations, in 005_visualize_your_data and 006_data_analysis we see spatial auto-correlation plots for convective precipitation and lsp. These plots show the effects of spatial proximity on a single variable. This is very interesting but please make your findings clearer: please comment on the radius of influence and how do you know this does not change over time and for other variables?

In 007_investigate_a_major_flooding_event, the exploration of the spatial correlations across different variables is also interesting but there are only basic comments. Could you please expand the interpretation of the plots?

At the moment it is unclear how the exploration of spatial correlations has influenced the subsequent work, could you please elaborate on that? Did that influence the dimensionality of your problem? Please interpret the plot of spatial correlations.

Although the project is already succesfully finished, for completeness sake here is what we thought while exploring this metric:
The first approach to incorporate spatial meteorological information into discharge was to plainly iterate over the points of interest (river network), while using grid points in the vicinity as additional features in the model. So the idea was to simply determine a rain-runoff relationship. Due to the large size of the catchment we were interested in, we wanted to determine a rough estimate of the radius of impact (neglecting more complex effects), to cut off all the data outside of it.
We compared different scenarios (investigate a major flooding event) to see if there is any systematic behaviour, attributable solely to the kind and/or magnitude/frequency of rain.
In the end it was not (yet) necessary, because we changed the way how we would set up the models (spatial average of the catchment for the predictor data).
Where this does in fact come a little bit into play again, is for the concept model, in which the radius of impact should give a measure on the spatial extent where predictors have significant impact on the predictand. But nevertheless, there are probably better measures than the threshold of the spatial correlation. For example the average distance a water particle covers in a day (assuming average river flow, no eddys etc.), when doing daily predictions, if rain falls inside this distance upstream.


ENV2023-01-11 DOME Litter codes request

While we're working on the new Litter format proposal for DOME, a submitter wants to deliver data in water and sediment asap, and needs codes as follows

| Progress and code | Description | Comment_AO | Comment_TW
-- | -- | -- | -- | --
LTPRP or PARAM ot TYPPL (see comment in right-hand column) | Done LTREF H01 + H01 code for foam| Expanded cellular plastic | I expect shapes to be further discussed at the WGML-2023,   but they seemed quite redundant related to the litter categories and material   type | I agree, simple shape descriptions like   "rectangle", "triangle", "sub-irregular", dont   seem useful. Maybe the descriptive codes I have requested here should not be   shape/SHP codes, but some kind of morphological descriptions that distinguish   the type of microlitter, and can be recorded from basic analysis with a light   microscope. For example "preproduction pellet","film",   "expanded cellular plastic", "synthetic sponge",   "foam", "filament >50 um thick", "micro fibre   <50um thick", seem relevant for linking microlitter to its source.
" | Done: PARAM LT253 | Waxy semisolid |   | To distinguish the fraction of paraffin-like particles,   important in North Sea/Skagerrak.
" | cancelled/changed - to be reported with H01 code for pre-prod pellets and SIZCL  | Pre-production pellet (<1mm) |   | For smaller, often irregularly shaped, preproduction   powders, often referred to as fluff, Karlsson et al. (2018). https://www.sciencedirect.com/science/article/pii/S0025326X18300523
" | E.g.   "TAC1", "TAC2", "TAC3". Done: PARAM LT253 | consider codes for tactile characteristics such as   "semisolid" | I expect tactile characteristics to be further discussed   at the WGML-2023 | Yes, would be good if they would include tactile   characteristics for the new format. For this submission, an important aspect   of the GU Byfjorded water data is a substantial proportion of micro-paraffin   particles in most/all samples. Is there a way that these can be distinguished   from the more usual, harder, thermoplastics? Would it work for example to   create a LTPRP or PARAM code (e.g. SHP6 for "waxy semisolid") to   avoid loss of information for this submission?
MATRIX | E.g.   "SEDfrac". DONE: new codes for specific fractions are offered, also MATRX SEDtot + METPT SVW | "Sediment" or "Size fractionated   sediment" | Please check if any of these work for you, and let me know   if more codes need to be added | None of the existing codes, such as those you listed with   specific grain sizes, would work, as the size classes do not match those in   the datasets from either of the two universities.     However, I am a bit confused now, as when I searched for MATRX options   within LT, I found only BE, SF, WC, and SF. I think I also got an issue   raised by DATSU related to invalid MATRX codes for LT. Should I just record   SF in the MATRX column, or can a more appropriate code be created and used   such a "sediment" (our sediment could be described as "size   fractionated sediment")? A code like this might be widely applicable to   diverse microlitter submitters.
LTSZC | Done. 38 | microns 100-299 | Would you like me to create these size categories or   follow the EMODnet/TGML recommendations for standardized size categories   reporting? | Adil discussed as standard (from OSPAR?) at WKLIDA. Yes,   please create for GU sed and water datasets
LTSZC | Done. 39 | microns 300-999 |   | Adil discussed as standard (from OSPAR?) at WKLIDA. Yes,   please create for GU sed and water datasets
LTSZC | Done. 40 | 1 mm-5 mm |   | Adil discussed as standard (from OSPAR?) at WKLIDA. Yes,   please create for GU sed and water datasets
LTSZC | Done. 41 | microns 50-299 |   | Non-standard but needed for ORU sediment and water   datasets
LTSZC | Done. 42 | microns 300-5000 |   | Non-standard but needed for ORU sediment and water   datasets
LTSZC | Done. 18 | 5 mm-25 mm |   | Not discussed at WKLIDA but needed for a few records   within the GU datasets, if they are not to be excluded. 5-25 mm was proposed   for mesolitter by Kroon et al., 2018 (Nature).
MUNIT | Done (partially). items/kg | items/kg (dry weight) sediment | Dry weight will be covered by BASIS, sediment is covered   by MATRX. Items/g exists already, items/kg can be added | OK, then just items/kg should work. Then I just need to   add a column titled BASIS with the code D, or?
TYPPL | Cancelled. AC | akrylglas/perspex | Request should be sent to EMODnet Chem/TGML as well for   adding an H05 category | Could a DOME code be created for the current submission?
TYPPL | Done. PES | Polyester | Ok to add |
METPT | Cancelled. SVW| Size fractionated |   | Useful to describe pretreatment of sediment samples. I can   leave this column blank.
METCX | Done. ALDKNC | "KOH + NaOCl digestion of biogenic matter" | Right now, variety of digestion methods is added to the   METCX. If WGML suggests moving it to METPT for plastics, we’ll look at it   with MCWG as well. | You are right, I should have been looking in METCX, not   METPT. As also suggested by Adil in his sediment spreadsheet, it would be   useful to have a METCX code for digestion using a mixture of KOH and NaOCl   (Strand & Tairova, 2016). e.g. "KOH + NaOCl digestion" (we call   it Strand solution).

LTSZC okay to implement
MUNIT items/kg OK. Dry weight to think about
Polyester okay to add
Digestion generic code/description

also see #416

MATRX SEDfrac is still in discussion, but check https://vocab.ices.dk/?CodeID=26973 vs. https://vocab.ices.dk/?ref=55

Suggestion_fibres-lines from Lisa Roscher.docx
Gagoetal.2019.pdf
Khnetal.2020.pdf
TanakaTakada2016.pdf

MATRX we can allow ranges
TYPPL ok
PARAM ok

Some details might have not be logged here. check ENV2023-01-11 in the accessions.


[Feature]: allow deploying other artifacts alongside executable during build

Describe the feature
This should be possible so stuff needed at runtime, e.g. a binary-only dynamic library from a commercial vendor or some other runtime dependency that is not part of the build can be downloaded and moved there.

One way would be to expose the final executable destination during build.rs. E.e. via SHUTTLE_DEPLOY_DIR, so one could copy stuff there.

Alternatively this could be done the other way around. I.e. build.rs would set an environment variable that contains a list of artifacts that shuttle needs to make sure are available in the same folder as the executable being built.
For example, if a the crate foo's build.rs downloads to OUT_DIR and the resp. crate is a dependency of bar which is depolyed to shuttle, the artifacts downloads would end up deep in bar's target folder:
target/debug/build/foo-6039619eac329ac4/artifact
target/debug/build/foo-6039619eac329ac4/other_artifact

So one option would be to set SHUTTLE_DEPLOY_ARTIFACTS to
target/debug/build/foo-6039619eac329ac4/artifact:target/debug/build/foo-6039619eac329ac4/other_artifact

And shuttle would make sure those are copied from there to be available alongside the executable at runtime.

Lastly there could be a crate from shuttle that allows just doing this via calling some methods during build.rs.

All that matters is that there is a way to deploy stuff beside the executable in the final destination.
Duplicate declaration

[X] I have searched the issues and this feature has not been requested before.

Is there any internal progress on this? I.e. maybe a spec. to comment on?
Now that #906 was merged I am only one step away from being able to actually deploy my shuttle Discord bot.
This bot needs a 3rd party commercial 3D renderer, 3Delight, packaged as a binary (lib3delight.so) to be availabel during runtime. My build.rs dowloads artifact from the cloud but I have no idea where to move it so it is actually found during runtime on the shuttle infrastructure, by my bot.

Hey! We did discuss this recently, but since we are in the middle of a larger refactoring of the relevant services (builder service PR should be up in a few days) we won't be implementing new functionality for this use-case just yet. But perhaps you could use the static folder as a work-around in the meantime?

As far as I can see from the docs the static folder is runtime. I.e. that would mean I have to download the library artifact at startup of the service and store it there.
I can't use this during build, right?

That's correct, yes. Can you work with that?

Can you work with that?

Yes, I'll give it a try. I guess I'll just move the code from the build.rs of the wrapper for the renderer to my bot.
I would still keep this open as ultimately a less involved solution should be available out-of-the-box with shuttle. Do you agree?

I agree, we should keep this use-case in mind and try to support it in the future. 👍

@iulianbarbu very cool. When can I test this on an actual deploy on your infra? Do I have to wait for the next shuttle release?


Adding an options hook

A quick search through tex.stackexchange.com  reveals a large number of posts about option clashes when using xcolor. Many of these are caused by packages loading xcolor with different options. If xcolor provided a command for changing these options then most of these problems would disappear.
Not all of the xcolor options can be changed mid document but many of them can.

I have uploaded a new version 3.00 which uses the new LaTeX options handler. With a current LaTeX this will avoid option clash errors. Options can now be used also in a second \usepackage command if it  makes sense, and it is also possible to set some options in the preamble directly. As an example
\documentclass{article}
\usepackage{xcolor}
\usepackage[monochrome,table]{xcolor}
\SetKeys[xcolor]{dvipsnames}
\begin{document}
\color{RedOrange} xxxx
\end{document}

This will ignore the monochrome option with a warning:

LaTeX Warning: Package "xcolor" has already been loaded: ignoring load-time option "monochrome".

It will load colortbl (through the table option)
It will load dvipsnam.de (through the \SetKeys).

Yes, thank you for the quick fix.  I was just starting to look into an "xcolor" option error that started last week on a university-specific document class that I help maintain.  The newtxtext package just started loading xcolor and I had been loading it subsequently with the table option.  Your update here fixes this issue for me.  Thank you!

Well it wasn't really quick, the code was sitting there since a year, the issue only pushed me to finally sent it to ctan. ;-)

The above part of the documentation appears to be outdated now that this issue has been fixed.


encode current list as URL if small enough

Rather than forcing users to always export their list and exchange files with people, allow them to instead, get a URL that has the list (and filter/sort) encoded in it. As long as the resultant URL is not too long, it can be directly shared

merged


Beautifulsoup collapses when I try to open this object in variable explorer

Description
What steps will reproduce the problem?

What is the expected output? What do you see instead?
Please provide any additional information below
File "C:\Users\Jiajun\Anaconda3\lib\copy.py", line 150, in deepcopy
y = copier(x, memo)
File "C:\Users\Jiajun\Anaconda3\lib\copy.py", line 240, in _deepcopy_dict
y[deepcopy(key, memo)] = deepcopy(value, memo)
File "C:\Users\Jiajun\Anaconda3\lib\copy.py", line 180, in deepcopy
y = _reconstruct(x, memo, *rv)
File "C:\Users\Jiajun\Anaconda3\lib\copy.py", line 280, in _reconstruct
state = deepcopy(state, memo)
File "C:\Users\Jiajun\Anaconda3\lib\copy.py", line 150, in deepcopy
y = copier(x, memo)
File "C:\Users\Jiajun\Anaconda3\lib\copy.py", line 240, in _deepcopy_dict
y[deepcopy(key, memo)] = deepcopy(value, memo)
File "C:\Users\Jiajun\Anaconda3\lib\copy.py", line 150, in deepcopy
y = copier(x, memo)
File "C:\Users\Jiajun\Anaconda3\lib\copy.py", line 215, in _deepcopy_list
append(deepcopy(a, memo))
File "C:\Users\Jiajun\Anaconda3\lib\copy.py", line 180, in deepcopy
y = _reconstruct(x, memo, *rv)
File "C:\Users\Jiajun\Anaconda3\lib\copy.py", line 280, in _reconstruct
state = deepcopy(state, memo)
File "C:\Users\Jiaju

I think this is already fixed. Please update Spyder and let us know if that's the case.

Closing because of lack of response.


Publish SCM / URL Information in Plugin POM

Expected Behavior
The POM files for plugin artifacts should include the scm/project URL
Current Behavior (optional)
The URLs are not included in the POM
Context
Currently, Dependabot updates for Gradle plugins in GitHub do not include any of the release note information for the update.
If you look at the Dependabot source code it appears to try and look up the project, scm, and issue management URLs from the POM in order to track the project back to GitHub and link the release notes to it.
Having the release note information available directly in the Dependabot PR body would be a huge QOL improvement

The issue is in the backlog of the relevant team and is prioritized by them.

@austinarbor FTR, you mean plugins hosted by the Gradle Plugin Portal, right?

@ov7a that's correct
For full transparency I am not 100% sure this will solve the issue - that is my interpretation of the root cause based on convos with GH support, interpretation of the linked source, and comparison on what is different vs my other published dependencies. If you have connections at GH to confirm, or can push up a sample plugin to the Gradle plugin repo with the SCM info included it should be easy to test and verify

Ok. I'm moving this issue to PP requests then cause it's the place where Gradle can affect this.
Most plugins use The Plugin Publishing plugin, which can be modified to include the data in the generated POM file.
However, there are alternative ways to create and publish a plugin for which it should be solved in a different way.


Create get-started-windows-instructions.md

Summary
This PR create the tutorial of getting started with .NET for Apache Spark on windows.
Move contents from Spark Dotnet to docs.

This PR has some overlapped contents with get-started. Do we want to move it to other categories or create a subsession like Get Started for windows, ubuntu and macos tutorials?

Why not combine all the three articles into one ?
The 3 articles (Windows, Ubuntu, and macOS) has the same structure.

Why not combine all the three articles into one ?
The 3 articles (Windows, Ubuntu, and macOS) has the same structure. Having them in only one article would be much easier to maintain.

Thanks for your comments and suggestion! These three articles do have similar structure and contents. 1) Do we want to combine them and 2) how do we separate these get-started articles(Windows, Ubuntu, macOS) with the existing tutorial get-started? @rapoth @imback82 Any suggestions?

Why not combine all the three articles into one ?
The 3 articles (Windows, Ubuntu, and macOS) has the same structure. Having them in only one article would be much easier to maintain.

Thanks for your comments and suggestion! These three articles do have similar structure and contents. 1) Do we want to combine them and 2) how do we separate these get-started articles(Windows, Ubuntu, macOS) with the existing tutorial get-started? @rapoth @imback82 Any suggestions?

Separating the existing Get started with this new one has nothing to do with combining 3 OS articles into one.

Yes, you are right. These are two different questions and they are not related.
I just also want to get the clarification of how we differentiate these two types of get-started tutorials to customers.

Build status was stuck on this one

I don't work on the Spark content but stumbled by accident on this PR.
Left a few comments for you to consider @elvaliuliuliu.

Thanks for your comments/feedback! Really appreciated it!


Improve "new proposal" user journey

Discussed in https://github.com/vegaprotocol/feedback/discussions/154

Originally posted by jubiliance August  3, 2023
Hey team,
I think from a user experience perspective and as someone who has submitted a couple of proposals now it's a bit annoying that when you click on "New Proposal" (https://token.vega.xyz/proposals) it redirected to Vega Docs/tutorials. I know this is intended, but I think I'd prefer to just be taken to a page where I can submit my proposal straightaway instead of digging through the tutorial docs.
Having a separate button or small link to tutorials underneath would be much better in my opinion, or even have this on the page where you submit the JSON proposals

Suggested plan of action:

[ ] Change button text to 'New Proposal'
[ ] Direct the 'New Proposal' button to the raw proposal screen
[ ] On the raw proposal screen, include a 3-step process for proposals:
1. Sense check your proposal idea on the forum
2. Use the proposal templates in [the docs] (relevant network link to the proposals index page)
3. Submit on-chain below
[ ] Make the links/text prominent (i.e. not gray on black)
[ ] Remove explorer link

Validation options:

Protobuff encoder & decoder (Emil has something)
Preview tab (the issue here is still that thing that the Core governance API output is different to the inbound proposal shape)

Can we explore these?  But in another ticket probably!


feat!: add DiscriminantValue to Definition::Enum::variants tuples

resolves #230

this commit was added to restrict possible values of discriminants to u8 range for BorshSchema to be congruent with what BorshSerialize, BorshDeserialize derives do.
with it:
    #[derive(BorshSchema)]
    #[borsh(use_discriminant = true)]
    enum XYa {
        A,
        B = discrim(),
        C,
        D,
        E = -100,
        F,
    }

    const fn discrim() -> isize {
        0x14
    }
//     |
// 277 |     #[derive(BorshSchema)]
//     |              ----------- expected due to this
// ...
// 281 |         B = discrim(),
//     |             ^^^^^^^^^ expected `u8`, found `isize`
//     |
// help: you can convert an `isize` to a `u8` and panic if the converted value doesn't fit
// 4  error[E0277]: the trait bound `u8: Neg` is not satisfied
//    --> borsh/tests/test_enum_discriminants.rs:284:13
//     |
// 284 |         E = -100,
//     |             ^^^^ the trait `Neg` is not implemented for `u8`
//     |
//     = help: the following other types implement trait `Neg`:

Without it:
    #[derive(BorshSchema)]
    #[borsh(use_discriminant = true)]
    enum XYa {
        A,
        B = discrim(),
        C,
        D,
        E = -100,
        F,
    }

    const fn discrim() -> isize {
        0x14
    }
//  1  error[E0308]: mismatched types
//     --> borsh/tests/test_enum_discriminants.rs:281:13
//      |
//  281 |         B = discrim(),
//      |             ^^^^^^^^^ expected `i64`, found `isize`
//      |
//  help: you can convert an `isize` to an `i64` and panic if the converted value doesn't fit

but
    #[derive(BorshSchema)]
    #[borsh(use_discriminant = true)]
    #[repr(i64)]
    enum XYa {
        A,
        B = discrim(),
        C,
        D,
        E = -100,
        F,
    }

    const fn discrim() -> i64 {
        0x14
    }
// OK


AN-1113: Update Performance Suite

Issue #, if available:
AN-1113
Description of changes:
Updated the performance suite to include throughput along with the connection pooling tests.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Codecov Report

Merging #102 (9db51ff) into gremlin-go-ms6 (b3d378b) will decrease coverage by 0.30%.
The diff coverage is 0.00%.

:exclamation: Current head 9db51ff differs from pull request most recent head 5c2484d. Consider uploading reports for the commit 5c2484d to get more accurate results

@@                Coverage Diff                 @@
##           gremlin-go-ms6     #102      +/-   ##
==================================================
- Coverage           67.20%   66.89%   -0.31%
==================================================
  Files                  23       23
  Lines                3494     3510      +16
==================================================
  Hits                 2348     2348
- Misses                960      976      +16
  Partials              186      186

Impacted Files
Coverage Δ

gremlin-go/driver/performance/performanceSuite.go
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3d378b...5c2484d. Read the comment docs.


Google Cloud Logging/Stackdriver doesn't include request ID field

I found it very interesting that the log from Google Cloud Logging/Stackdriver monitoring activities in my Bucket does not have the request ID. In Google Storage access log it has the request ID of any activities happening in the Bucket. It would be nice if the log from the Stackdriver has request ID field that can be correlated to the Google Storage access log.

Thanks @ihsanhaikalz, i'll forward this feature request to the GCS backend team. I won't be able to give a timeline or if it will be implemented. For now closing this issue.


apps/openssl: make index.txt errors more verbose

openssl ca was  a little bit too silent, when it couldnt parse index.txt ...
steps to reproduce: create index.txt with

echo "" > index.txt

which creates

hexdump index.txt
0000000 000a
0000001

-> a "trivial" change, tested with openssl ca to sign a csr
-> the ocsp and svr changes were only compile tested by me, but seemed to make sense. ?
History:

Earlier Pull Request with erronous "CLA:Trivial Line": https://github.com/openssl/openssl/pull/10818

Sadly i used the master branch for that earlier one, which i force pushed to in order to update and rebase to current master.
This time I used a separate branch which I will not mess about with.
I removed the CLA:Trivial line from them and send in an ICLA.

@paulidale @t8m
Checklist

just FYI (not least since that other PR was approved already), you could have rewound using git reflog to look up the previous commit, and then done something like
git reset --hard <hash>
git push -f origin master

This pull request is ready to merge

Merged to master. Thank you for your contribution.


feat(swaps): Support cross-chain swaps, swap screen redesign

Description
For RET-1065. Adds support for cross-chain swaps, and completes the redesign of the main swap screen.
One consequence of this redesign is that the confirm swap button can no longer be pressed unless a swap is actually possible given the current parameters. This means that several conditional bottom sheets that only appeared upon pressing confirm have been removed from the screen, which is kinda nice. Since there are now a ton of possible inline notifications and their order of precedence was already pretty messy, I've refactored how notifications are handled a bit.
Test plan
Manual and unit tested. See videos below:
Cross-chain swap from Celo -> Arbitrum on Mainnet
https://github.com/valora-inc/wallet/assets/569401/51e10c4b-7fa2-4693-8561-7662c0adb048
Cross-chain fee warning
https://github.com/valora-inc/wallet/assets/569401/73e2cd39-b5df-4b26-be9c-343f9dd840bc
Not enough of any fee currency available, no way to swap
https://github.com/valora-inc/wallet/assets/569401/94facfc9-fa03-4c05-a732-1f5435bf9f36
Swapping (a) fee currency and can proceed with swap only after reducing swap amount
https://github.com/valora-inc/wallet/assets/569401/d63c4de1-35ff-43a6-b3cf-ad20478dc06e
Unsupported tokens from providers
https://github.com/valora-inc/wallet/assets/569401/45a12e18-598d-4c02-9c08-18b39c2b9098
Related issues

Fixes RET-1065

Backwards compatibility

Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will:

[X] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

Codecov Report
Attention: Patch coverage is 93.51852% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 86.36%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5461      +/-   ##
==========================================
- Coverage   86.36%   86.36%   -0.01%
==========================================
  Files         757      757
  Lines       31288    31302      +14
  Branches     5377     5404      +27
==========================================
+ Hits        27022    27033      +11
- Misses       4035     4037       +2
- Partials      231      232       +1

Files
Coverage Δ

src/icons/CrossChainIndicator.tsx
100.00% <100.00%> (ø)

src/statsig/constants.ts
100.00% <ø> (ø)

src/statsig/types.ts
100.00% <100.00%> (ø)

src/swap/types.ts
100.00% <ø> (ø)

src/swap/useSwapQuote.ts
93.25% <ø> (ø)

src/swap/SwapScreen.tsx
92.90% <93.06%> (-0.88%)
:arrow_down:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48373ce...1fc6f97. Read the comment docs.


Lost icon in FAKIonIcons

Refers to IonIcon page, I found that the ion-ios-list is not found in the FAKIonIcons class, please add this

(instancetype)iosStarIconWithSize:(CGFloat)size { return [self iconWithCode:@"\uf4b3" size:size]; }
(instancetype)iosStarOutlineIconWithSize:(CGFloat)size { return [self iconWithCode:@"\uf4b2" size:size]; }

are missing, please include

@JacquesPienaar I can see these icons being rendered in the demo app, they're not missing. What's wrong?

I get the following

@JacquesPienaar So, problem solved?

yes


Avoid throwing a warning when checking for git capabilities

When checking for git availability, we check the cat-file command capabilities with git cat-file -h. This command exits with code 129 (expected behavior). This logs a warning in the output log, which when cooking content ends up in the list of warnings at the end.
This pull request adds support for custom return codes in RunCommandInternalRaw so that we can pass in an expected non zero code.
Didn't cascade the argument from the higher-level methods for now. The argument defaults to zero to maintain the same behavior.

Hi, I really like that, simple and efficient!


How to get generated report from job

Code
$report = $job->createReport()

In $report setted object JobReport, but not filled

Sorry


GPU with CUDA capability 6 1 is not supported

Hi Folks ,
I am encountering an issue where my GPU (gtx-1080 ti ) with CUDA capability 6.1 is not being supported by the docker build.
full stack trace :
, max_concurrent_requests: 128, max_best_of: 2, max_stop_sequences: 4, max_input_length: 1000, max_total_tokens: 1512, max_batch_size: 32, max_waiting_tokens: 20, port: 80, shard_uds_path: "/t
mp/text-generation-server", master_addr: "localhost", master_port: 29500, huggingface_hub_cache: Some("/data"), weights_cache_override: Some("/home/antpc/Documents/data_mount/hf-inference-serv
er/text-generation-inference/open-assistant-weights/oasst-sft-4-pythia-12b-epoch-3.5"), disable_custom_kernels: false, json_output: false, otlp_endpoint: None, cors_allow_origin: [], watermark
_gamma: None, watermark_delta: None }
2023-04-20T15:40:14.155684Z  INFO text_generation_launcher: Starting shard 0
2023-04-20T15:40:17.755793Z  WARN shard-manager: text_generation_launcher: Could not import Flash Attention enabled models
Traceback (most recent call last):
  File "/opt/conda/bin/text-generation-server", line 8, in <module>
    sys.exit(app())
  File "/opt/conda/lib/python3.9/site-packages/typer/main.py", line 311, in __call__
    return get_command(self)(*args, **kwargs)
  File "/opt/conda/lib/python3.9/site-packages/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
  File "/opt/conda/lib/python3.9/site-packages/typer/core.py", line 778, in main
    return _main(
  File "/opt/conda/lib/python3.9/site-packages/typer/core.py", line 216, in _main
    rv = self.invoke(ctx)
  File "/opt/conda/lib/python3.9/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/opt/conda/lib/python3.9/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/opt/conda/lib/python3.9/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/opt/conda/lib/python3.9/site-packages/typer/main.py", line 683, in wrapper
    return callback(**use_params)  # type: ignore
  File "/opt/conda/lib/python3.9/site-packages/text_generation_server/cli.py", line 51, in serve
    from text_generation_server import server
  File "<frozen importlib._bootstrap>", line 1058, in _handle_fromlist
  File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
  File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
  File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 850, in exec_module
  File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
  File "/opt/conda/lib/python3.9/site-packages/text_generation_server/server.py", line 12, in <module>
    from text_generation_server.cache import Cache
  File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
  File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 850, in exec_module
  File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
  File "/opt/conda/lib/python3.9/site-packages/text_generation_server/cache.py", line 3, in <module>
      from text_generation_server import server
  File "<frozen importlib._bootstrap>", line 1058, in _handle_fromlist
  File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
  File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
  File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 850, in exec_module
  File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
  File "/opt/conda/lib/python3.9/site-packages/text_generation_server/server.py", line 12, in <module>
    from text_generation_server.cache import Cache
  File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
  File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 850, in exec_module
  File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
  File "/opt/conda/lib/python3.9/site-packages/text_generation_server/cache.py", line 3, in <module>
    from text_generation_server.models.types import Batch
  File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
  File "<frozen importlib._bootstrap>", line 972, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
  File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
  File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 850, in exec_module
  File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
> File "/opt/conda/lib/python3.9/site-packages/text_generation_server/models/__init__.py", line 28, in <module>
    raise ImportError(
ImportError: GPU with CUDA capability 6 1 is not supported

Machine configuration :
Nvidia-smi ->
+-----------------------------------------------------------------------------+
| NVIDIA-SMI 520.61.05    Driver Version: 520.61.05    CUDA Version: 11.8     |
|-------------------------------+----------------------+----------------------+
| GPU  Name        Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp  Perf  Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
|                               |                      |               MIG M. |
|===============================+======================+======================|
|   0  NVIDIA GeForce ...  Off  | 00000000:02:00.0 Off |                  N/A |
| 17%   33C    P0    58W / 250W |      0MiB / 11264MiB |      0%      Default |
|                               |                      |                  N/A |
+-------------------------------+----------------------+----------------------+
|   1  NVIDIA GeForce ...  Off  | 00000000:03:00.0 Off |                  N/A |
| 18%   33C    P0    58W / 250W |      0MiB / 11264MiB |      0%      Default |
|                               |                      |                  N/A |
+-------------------------------+----------------------+----------------------+
|   2  NVIDIA GeForce ...  Off  | 00000000:81:00.0 Off |                  N/A |
| 20%   33C    P0    55W / 250W |      0MiB / 11264MiB |      0%      Default |
|                               |                      |                  N/A |
+-------------------------------+----------------------+----------------------+
|   3  NVIDIA GeForce ...  Off  | 00000000:82:00.0 Off |                  N/A |
| 25%   38C    P0    59W / 250W |      0MiB / 11264MiB |      1%      Default |
|                               |                      |                  N/A |
+-------------------------------+----------------------+----------------------+
+-----------------------------------------------------------------------------+
| Processes:                                                                  |
|  GPU   GI   CI        PID   Type   Process name                  GPU Memory |
|        ID   ID                                                   Usage      |
|=============================================================================|
|  No running processes found                                                 |
we tried disabling BUILD_EXTENSIONS=False using this command still no effect.

This is not an error but a warning that you can't use flash attention based models as it does not support GPUs with capability < 7.5.
You can still use all the others models.


Crash in dev with TheOneProbe + CompatLayer

Trying to boot up in a dev environment and updated TOP to v1.1x-1.4.4-55
Had to add CompatLayer, v1.10-0.2.2
I'm crashing on world load with this:
http://pastebin.com/K3XELXx0
Any ideas?

Hmm, do you have recent mappings?

My mappings are stable_29.

I'm not sure how old those are. I always try to use latest. I guess something has changed there.

I'll try updating to the newest snapshot and test.

So I'm getting an error on decompile with the latest 1.10.2 snapshot for some reason, but they were exported on the same day (http://export.mcpbot.bspk.rs/) which were several months after the ones used in compatlayer.
I do remember that (fairly) recently, things like .worldObj in TEs became .world, not sure if it's the same issue that may be flagging up here?

I do remember that (fairly) recently, things like .worldObj in TEs became .world, not sure if it's the same issue that may be flagging up here?

Using getWorld() instead of accessing the fields directly should solve problems like those I guess.

When you're using mods in dev, you should include their SRG-mapped jar via deobfCompile in gradle. This will automatically convert them to whatever MCP mappings your mod uses. Is that how you're including it? If not, what are you doing, and does that work?


Main Page Modification

How to change main page as:
https://drive.google.com/file/d/0BxH6V5haSQjeN1hlMjhCZG5VeEU/view?usp=sharing
Thanks

I'd be interested in pointers to whatever the key variables are for the title header height as well.  (I dinked around a bit in "inspect element" but ended up breaking things when I made what I thought would be fairly innocuous edits.)
Thanks again for a great theme!

@sgfin for some style modification, take a look here: https://github.com/aron-bordin/neo-hpstr-jekyll-theme#style-customization, here: https://github.com/aron-bordin/neo-hpstr-jekyll-theme/blob/master/_sass/_variables.scss
You will see how to change the height ^ and some other variables.

This month I'm really really busy, and unfortunately I'm not able to respond in time and  not able to provide the answers fast. Sorry @cakirhal , I'll return to this issue in the next month if you still interested.

Thank you.  I was able to find (in that page) the navbar height, but was (and continue to be) unable to find the height for the black title header thing that @cakirhal was trying to shrink in his image as well.  If you get a chance to point out what you named that object and/or where in _variables you store it's height, that'd be awesome.  Of course, no hard feelings if you're too busy!
Apologies again for the noobishness, and thanks for freely sharing such great work.

No problem @aron-bordin. I will be waiting for your answer in the next month. Thanks for your efforts.


Navigation Agent doesn't work when the target is a generic Node3D

Tested versions
Only tested in Godot v4.1.3 stable
System information
Windows 10 Home Single Language version 22H2 - Godot v4.1.3 stable
Issue description
The issue is that when trying to set the target (who is part of the navigation mesh, but also a Node3d) of an NavigationAgent3D, the Agent goes to the first position, then stops. However, doing the exact same configuration, but using a target that's a scene with a root as a CharacterBody3D, it works flawlessly.
There's a further description of the problem here and these are the two target scenes I mentioned, in the attached images.

To make the CharacterBody3D-root scene I literally just simply copy and pasted the original, which means there's no differences in terms of script, or settings of the navagent.
Steps to reproduce
Create a scene. Go through the effort of setting a player controller and an enemy with navigationagent3D, test it.
Minimal reproduction project (MRP)
Use this as your base project, this is where I based my scripts on, I'm not making a new scene just for a bug report:
https://github.com/LegionGames/ZombieEnemies

I'm not making a new scene just for a bug report

Please do, a complete project like this is not minimal, it should be specific to help reviewing, not a large project with irrelevant parts

However, doing the exact same configuration, but using a target that's a scene with a root as a CharacterBody3D, it works flawlessly.

If the used target node types makes a difference as describes this is a project specific node setup or scripting bug.
The navigation system and path queries all use global position vectors as targets, nothing there uses or depends on a node (type) as target.

I'm at a loss on how to proceed here, the project is itself quite large but it has a lot of unnecessary assets.
This is the agent's script for following the player:
`extends CharacterBody3D
var player = null
const SPEED = 5.0
@export var player_path : NodePath
@onready var nav_agent = $NavigationAgent3D
Called when the node enters the scene tree for the first time.
func _ready():
velocity = Vector3.ZERO
player = get_node(player_path)
# These values need to be adjusted for the actor's speed
# and the navigation layout.
nav_agent.path_desired_distance = 0.5
nav_agent.target_desired_distance = 0.5
nav_agent.set_path_max_distance(0)

# Make sure to not await during _ready.
call_deferred("actor_setup")

func actor_setup():
# Wait for the first physics frame so the NavigationServer can sync.
await get_tree().physics_frame
# Now that the navigation map is no longer empty, set the movement target.
set_movement_target(player.global_position)

func set_movement_target(movement_target: Vector3):
nav_agent.set_target_position(movement_target)
Called every frame. 'delta' is the elapsed time since the previous frame.
func _physics_process(delta):
if nav_agent.is_navigation_finished():
return
Called every frame. 'delta' is the elapsed time since the previous frame.
func _process(delta):
velocity = Vector3.ZERO
nav_agent.set_target_position(player.global_transform.origin)
var next_nav_point = nav_agent.get_next_path_position()
velocity = (next_nav_point - global_transform.origin).normalized() * SPEED
rotation.y = lerp_angle(rotation.y, atan2(-velocity.x, -velocity.z), delta * 10.0)

move_and_slide()`

This is the player script (which shouldn't bear any form of influence on enemy navigation afaik):
`extends CharacterBody3D
signal player_fired
#consts
const MAXSPEED : float = 10.0        # default: 32.0
const WALKSPEED : float = 5.0       # default: 16.0
const STOPSPEED : float = 10.0       # default: 10.0
const GRAVITY : float = 10.0         # default: 80.0
const ACCELERATE : float = 10.0      # default: 10.0
const AIRACCELERATE : float = 0.25   # default: 0.7
const MOVEFRICTION : float = 2.0     # default: 6.0
const JUMPFORCE : float = 5.0       # default: 27.0
const AIRCONTROL : float = 0.9       # default: 0.9
const STEPSIZE : float = 1.8         # default: 1.8
const MAXHANG : float = 0.2          # default: 0.2
const PLAYER_HEIGHT : float = 3.6    # default: 3.6
const CROUCH_HEIGHT : float = 2.0    # default: 2.0
const LADDER_LAYER = 2
var direction
var deltaTime : float = 0.0
var movespeed : float = 32.0
var fmove : float = 0.0
var smove : float = 0.0
var ground_normal : Vector3 = Vector3.UP
var hangtime : float = 0.2
var impact_velocity : float = 0.0
var is_dead : bool = false
var jump_press : bool = false
var crouch_press : bool = false
var ground_plane : bool = false
var prev_y : float = 0.0
var ladder_normal : Vector3 = Vector3.UP
var _can_fire : bool = false
var _can_fire_counter = 0
enum {GROUNDED, FALLING}
var state = GROUNDED
#bullets
var bullet = load("res://prefabs/rifle_bullet.tscn")
var bulletFX = load("res://prefabs/particles_hit_metal.tscn")
var instances
#vars
@export var sensitivity = 0.10
@export var max_angle = 80
@export var min_angle = -70
var look_rot = Vector3.ZERO
@onready var head = $head
@onready var firesfx = $ShootingSFX
@onready var raycast = $head/RayCast3D
@onready var gun     = $"head/Fps Rig AKM/GunBarrel"
Get the gravity from the project settings to be synced with RigidBody nodes.
var gravity = ProjectSettings.get_setting("physics/3d/default_gravity")
func _ready():
Input.mouse_mode = Input.MOUSE_MODE_CAPTURED
PlayerAutoload.player = self
func _input(event):
if event is InputEventMouseMotion:
look_rot.y -= event.relative.x
look_rot.x -= event.relative.y
look_rot.x = clamp(look_rot.x, min_angle, max_angle)
movespeed = WALKSPEED if Input.is_action_pressed("shift") else MAXSPEED

if Input.is_action_just_pressed("fire"):
	fire_shot()

# Handle Jump.
if Input.is_action_just_pressed("jump") and !jump_press:
	jump_press = true
elif Input.is_action_just_released("jump"):
	jump_press = false

func _physics_process(delta):
if Input.is_key_pressed(KEY_ESCAPE):
get_tree().quit()
deltaTime = delta
update_fire()
ground_normal = get_floor_normal()
# Get the input direction and handle the movement/deceleration.
# As good practice, you should replace UI actions with custom gameplay actions.
var input_dir = Input.get_vector("ui_left", "ui_right", "ui_up", "ui_down")
fmove = Input.get_action_strength("move_forward") - Input.get_action_strength("move_backward")
smove = Input.get_action_strength("move_right") - Input.get_action_strength("move_left")
direction = (transform.basis * Vector3(input_dir.x, 0, input_dir.y)).normalized()
direction = Vector2(direction.x, direction.z)
#Rotation
rotation_degrees.y = look_rot.y
head.rotation_degrees.x = look_rot.x

$AnimationTree.set("parameters/conditions/stop", input_dir == Vector2.ZERO and is_on_floor())
$AnimationTree.set("parameters/conditions/walk", input_dir == Vector2.UP and is_on_floor())
$AnimationTree.set("parameters/conditions/right", input_dir == Vector2.RIGHT and is_on_floor())
$AnimationTree.set("parameters/conditions/left", input_dir == Vector2.LEFT and is_on_floor())
$AnimationTree.set("parameters/conditions/retreat", input_dir == Vector2.DOWN and is_on_floor())
$AnimationTree.set("parameters/conditions/right_walk", input_dir.angle() < Vector2.UP.angle() and is_on_floor())
$AnimationTree.set("parameters/conditions/left_walk", (input_dir.angle() - Vector2.UP.angle() > 0) and input_dir.angle() < Vector2.LEFT.angle() and is_on_floor())
$AnimationTree.set("parameters/conditions/left_retreat", (input_dir.angle() - Vector2.LEFT.angle() > 0) and input_dir.angle() < Vector2.DOWN.angle() and is_on_floor())
$AnimationTree.set("parameters/conditions/right_retreat", (input_dir.angle() - Vector2.DOWN.angle() > 0) and is_on_floor())
$AnimationTree.set("parameters/conditions/jump", (velocity.y != 0) or !is_on_floor())
$AnimationTree.set("parameters/conditions/landed", is_on_floor())

if(velocity.y != 0 or (!is_on_floor() and !is_on_ceiling())):
	state = FALLING
elif is_on_ceiling() or is_on_floor():
	state = GROUNDED

jump_button()
check_state()

move_and_slide()

func jump_button():
if is_dead:
return
if state == GROUNDED and jump_press:
$JumpSFX.play_sfx()
$JumpGruntSFX.play()
state = FALLING
jump_press = false
velocity.y += JUMPFORCE
func check_state():
match(state):
GROUNDED:
ground_move()
FALLING:
air_move()
func ground_move():
if direction:
process_footsteps(true)
var current_horizontal_v = Vector2(velocity.x, velocity.z)
current_horizontal_v = Vector2(velocity.x, velocity.z).lerp(movespeed * direction, ACCELERATE * deltaTime)
velocity.x = current_horizontal_v.x
velocity.z = current_horizontal_v.y
else:
process_footsteps(false)
var current_horizontal_v = Vector2(velocity.x, velocity.z)
current_horizontal_v = Vector2(velocity.x, velocity.z).lerp(Vector2.ZERO, MOVEFRICTION * deltaTime)
velocity.x = current_horizontal_v.x
velocity.z = current_horizontal_v.y
impact_velocity = 0

func air_move():
var wishdir = (global_transform.basis.x * smove + -global_transform.basis.z * fmove).normalized()
air_accelerate(wishdir, STOPSPEED if velocity.dot(wishdir) < 0 else AIRACCELERATE)
velocity.y -= GRAVITY * deltaTime
if global_transform.origin[1] >= prev_y:
	prev_y = global_transform.origin[1]

impact_velocity = abs(int(round(velocity[1])))

func air_accelerate(wishdir : Vector3, accel : float):
var addspeed     : float
var accelspeed   : float
var currentspeed : float
var wishspeed = slope_speed(ground_normal[1])

currentspeed = velocity.dot(wishdir)
addspeed = wishspeed - currentspeed
if addspeed <= 0.0:
	return

accelspeed = accel * deltaTime * wishspeed
if accelspeed > addspeed: accelspeed = addspeed

velocity[0] += accelspeed * wishdir[0]
velocity[1] += accelspeed * wishdir[1]
velocity[2] += accelspeed * wishdir[2]

"""
air_control
"""
func air_control(wishdir : Vector3):
var dot        : float
var speed      : float
var original_y : float
if fmove == 0.0:
	return

original_y = velocity[1]
velocity[1] = 0.0
speed = velocity.length()
velocity = velocity.normalized()

# Change direction while slowing down
dot = velocity.dot(wishdir)
if dot > 0.0 :
	var k = 32.0 * AIRCONTROL * dot * dot * deltaTime
	velocity[0] = velocity[0] * speed + wishdir[0] * k
	velocity[1] = velocity[1] * speed + wishdir[1] * k
	velocity[2] = velocity[2] * speed + wishdir[2] * k
	velocity = velocity.normalized()

velocity[0] *= speed
velocity[1] = original_y
velocity[2] *= speed

"""
slope_speed
Change velocity while moving up/down sloped ground
"""
func slope_speed(y_normal : float):
if y_normal <= 0.97:
var multiplier = y_normal if velocity[1] > 0.0 else 2.0 - y_normal
return clamp(movespeed * multiplier, 5.0, movespeed * 1.2)
return movespeed
func fire_shot():
if _can_fire:
#firesfx.play()
$ShootingSFX2.play_sfx()
_can_fire = false
_can_fire_counter = 0
emit_signal("player_fired")
instances = bullet.instantiate()
instances.position = gun.global_position
instances.transform.basis = gun.global_transform.basis
get_parent().get_parent().add_child(instances)
var center_of_camera = get_viewport().get_size()/2
var ray_origin = head.project_ray_origin(center_of_camera)
var ray_end    = ray_origin + head.project_ray_normal(center_of_camera)*50
	var new_intersection = PhysicsRayQueryParameters3D.create(ray_origin, ray_end)
	var Intersection = get_world_3d().direct_space_state.intersect_ray(new_intersection)

	if !(Intersection.is_empty()):
		var shotFX = bulletFX.instantiate()
		get_parent().get_parent().add_child(shotFX)
		shotFX.global_position = Intersection.position
		shotFX.look_at(ray_origin + Intersection.normal, Vector3.UP)
		shotFX.find_child("GPUParticles3D").emitting = true
		shotFX.find_child("GPUParticles3D2").emitting = true
		shotFX.find_child("AudioStreamPlayer3D").play()

func update_fire():
if _can_fire == false:
if _can_fire_counter > 0.167:
_can_fire = true
_can_fire_counter += deltaTime
else:
_can_fire_counter += deltaTime
func _on_timer_timeout():
pass
func process_footsteps(play : bool) -> void:
if($Timer.is_stopped() and play):
$Timer.start()
$PlayerFootstep.pitch_scale = randf_range(0.7,0.95)
$PlayerFootstep.play_sfx()
elif !play:
$Timer.stop()
$PlayerFootstep.stop()`
With either approach the project runs without errors pertaining to navigation

Please upload a project instead, and if you are adding code please put it between tripple backticks as per the instructions, like so:
```gdscript
...
```

I'll try to setup a minimum project, this may take a while, if I don't manage to reproduce the error that way I'll close the issue.

If you set the path max distance to 0 the agent will query a new navigation path every single update.  I now remember this youtube tutorial, it tripped a few other users into problems in the past because it is has basics things wrong, like using the correct process mode for physics nodes.
The documentation has working script templates for NavigationAgents used with common node types that you can find here https://docs.godotengine.org/en/latest/tutorials/navigation/navigation_using_navigationagents.html#navigationagent-script-templates.

@smix8 this minimum distance was set in my desperate attempts to solve the issue, it wasn't explicitly called for in the tutorial. however, despite it not working, it got through the resulting code

Well the main problem in that project is that you have 2 "Player" nodes. The one that is tracked by your enemy is the parent node that is never moving. The child node that is moving is not tracked by the enemy.


migrated to external dependency

Pull Request Test Coverage Report for Build 874829677

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 81.803%

Totals

Change from base Build 874362574:
0.0%

Covered Lines:
980

Relevant Lines:
1198

💛  - Coveralls

Pull Request Test Coverage Report for Build 874829677
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 81.803%

Totals

Change from base Build 874362574:
0.0%

Covered Lines:
980

Relevant Lines:
1198

💛  - Coveralls


Switch to org.locationtech's JTS version

As discussed in #1039 and elsewhere. Seems to work.

Thanks for that JTS Jackson Datatype fork thing, @karussell

Something observed elsewhere:
JTS 1.16 have problems on Android, requires latest Android 7 Nougat (API 24):
D8: Default interface methods are only supported starting with Android N (--min-api 24):
org.locationtech.jts.geom.Coordinate org.locationtech.jts.geom.CoordinateSequence.createCoordinate()

See also https://github.com/locationtech/jts/issues/145

Thanks!

JTS 1.16 have problems on Android

Is JTS 1.15 okay with older versions?

Is JTS 1.15 okay with older versions?

JTS 1.15.0 definitely works, that what we use in VTM.
Though have not checked lately the state of 1.15.1.


Option to install splunkforwarder via system pkg manager (ie yum repo) not download URL

I have a use case where splunkforwarder RPM is already installed via company wide managed yum repo, such that the installed version is newer than what it is set in attributes.
It'd be nice if cookbook had option for a "no frills" package install which just relies on the system pkg manager instead of installing from cached remote file from the hardcoded URL in attributes

This could be relatively simple to add to the splunk_installer resource that was added in v2.0.0.


Just a feedback

From what I understood from ES2015 - event hough I didn't find any resource talking about that - trailing semicolons and commas are best not used where possible.
Not: this package, that comes with eslint, throws nothing but errors because of missing commas and semicolons.
Why is that? Why is the package's eslint not configured the way the package needs it to be?
Any reasons?

@rowild What lint configuration do you use?

standard
airbnb
none

AirBnb. I already adjusted the rc file and it is working now.
But for something that should work out-of-the box, there should be some info coming along, when the user selects the options...

Semicolons are enforced by the airbnb style https://github.com/airbnb/javascript/blob/master/README.md#semicolons
There is a simple and quick fix to most eslint problems:
npm run lint --fix

or
yarn run lint --fix

Thanks! That is a very good tip! (It should be mentioned in the setup process, but I assume you are not one of the developers, are you?)

No, I've never contributed to this project yet.

Looking at the source code, there is a message with that lint fix tip. https://github.com/vuejs-templates/webpack/blob/4f564a2715dd9ca39307c5603a3b91f0523f1f67/utils/index.js#L95


Work with user profiles to see if user is in a tournament

Currently, there is no way to differentiate between a user that is participating in a tournament, a user that is spectating a tournament, and a user who is not currently in a tournament. We would like to work with the User Profile team to come up with a resolution to this problem. One idea I propose is to add an attribute that contains some variables that update when a user enters a tournament.

The current solution we came up with was that a user would receive a notification informing them that it is time to join their lobby for a match in the tournament once that tournament is full. This would be one of the many different notification types that would be sent out as specified in the Notifications class created by the Users team. We are not working with the other types of notifications for now, but if we need to, we can always revisit it. I'll close this issue for now, but if there are complications that arise as a result of this decision, we can modify our approach.

Issue Score: Excellent.
Comments:
Good work reaching out and communicating with the user profiles team! I'd like to see some documentation next time if you decide to create a larger change. Because this issue only focused on communication and didn't result in any changes yet, I'm going to make it a minor issue.


lua function not execute on readonly slave node

I noticed lua function not execute on readonly slave node
I used redis.defineCommand to define the lua function
I defined readonly nodes during the connection.
Redis 3.05 cluster

Could you please post your code here that can reproduce the problem?

var Redis = require('ioredis');

var r1 = "x.x.x.x";
var r1s = "x.x.x.x";
var r2 = "x.x.x.x";
var r2s = "x.x.x.x";
var r3 = "x.x.x.x";
var r3s = "x.x.x.x";
var r4 = "x.x.x.x";
var r4s = "x.x.x.x";

var redisNodes= [{
    port: 6379,
    host: r1
},{
    port: 6379,
    host: r2
},{
    port: 6379,
    host: r3
},{
    port:6379,
    host:r4
},{
    port:6379,
    host:r4s,
    readOnly: true
},{
    port:6379,
    host:r1s,
    readOnly: true
},{
    port:6379,
    host:r2s,
    readOnly: true
},{
    port:6379,
    host:r3s,
    readOnly: true
}];

var redis = new Redis.Cluster(redisNodes);

redis.defineCommand('calc', {
    numberOfKeys: 1,
    lua: '.....lua code'
});

redis.calc(key,start,end,screen,function(err,data){
    #process result or err
})

The readOnly option should be defined in the second parameter:
var cluster = new Redis.Cluster(nodes, { readOnly: true });

This option means every command sent from the cluster instance is readonly so that ioredis will send them to both masters and slaves instead of just masters in order to scale reads and writes.
I understand you intention that sending readonly commands to slaves and others to masters. This feature has been discussed in #170 and will be implemented in ioredis v2.0.

Thx. I got it.


Update mongo-xlsx.js

return value from xlsxRW if save==false

Hi, I'm guessing other file is missing?


Compilation errors on MSVC 2015 after doctest update to 2.4.7

Description
Code below doesn't compile on MSVC 2015 when doctest 2.4.7 is used (but compiles fine when doctest is 2.4.6).
Compiler output:
d:\doctest_bug\doctest.h(821): error C2440: 'return': cannot convert from 'const char [4]' to 'const char (&&)[4]'
d:\doctest_bug\doctest.h(821): note: You cannot bind an lvalue to an rvalue reference
d:\doctest_bug\doctest.h(1320): note: see reference to function template instantiation 'T (&&doctest::detail::forward<const R>(const char (&)[4]) noexcept)' being compiled
        with
        [
            T=char [4],
            R=char [4]
        ]
d:\doctest_bug\doctest_bug.cpp(7): note: see reference to function template instantiation 'doctest::detail::Result doctest::detail::Expression_lhs<const std::string &>::operator ==<char[4],0x0>(const R (&))' being compiled
        with
        [
            R=char [4]
        ]
d:\doctest_bug\doctest_bug.cpp(7): note: see reference to function template instantiation 'doctest::detail::Result doctest::detail::Expression_lhs<const std::string &>::operator ==<char[4],0x0>(const R (&))' being compiled
        with
        [
            R=char [4]
        ]

Steps to reproduce

Create file doctest_bug.cpp with following content:

#define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
#include "doctest.h"
#include <string>

TEST_CASE("string comparison") {
    std::string str = "ABC";
    CHECK(str == "ABC");
}

Compile it with MSVC 2015 and Doctest 2.4.7

Extra information

doctest version: 2.4.7
Operating System: Windows 10
Compiler+version: MSVC 2015

Turns out the latest release was without MSVC 2015 testing due to the migration to a github org & relying solely on github actions - re-enabling appveyor now...
Just committed a test like your snippet and holy cow:
https://github.com/doctest/doctest/runs/4509284329?check_suite_focus=true
seems that GCC & new versions of MSVC handle it properly, but clang & MSVC 2015 error on it, and in different ways.

MSVC cannot compile
clang constructs the stringified version incorrectly (for CHECK(str == "ABC2");) which might be related to #567 :

-  values: CHECK( ABC == ABC2 )
+  values: CHECK( ABC == ABCABC2 )

It seems simple fix is to remove doctest::detail::forward call on const lvalue reference, what I done in the commit: https://github.com/rmisev/doctest/commit/f707ccb554d60749e4843051511f7843ce75ca16
It fixes this issue, and seems doesn't break other tests.

@rmisev Thanks, I'll review it in the following days!

just pushed to dev - should be fixed, thanks!


feat(http): add get guild role endpoint

Discord supports an endpoint that allows to fetch a single guild role.

https://github.com/discord/discord-api-docs/pull/7074

Thanks for the PR!


xml_parse_result causing stack corruption in MFCx64 project

I have an MFCx64 c++ program where InitInstace() is calling a ReadXML function that uses pugixml (latest version 1.13). Pugixml was compiled by including the pugixml.cpp file into the project. The creation of a pugi::xml_parse_result object is then causing a stack corruption when exiting the ReadXML function (so it might be destruction of the object that is causing trouble).
Minimum code causing the error:
int CMyApp::ReadXML()
{
   pugi::xml_parse_result result1;
   return 0;  //program will throw exception when leaving the function
}

BOOL CMyApp::InitInstance()
{
   int test = ReadXML();

   //rest of InitInstance() here...
}

When the code leaves the ReadXML() function I get this exception: Run-Time Check Failure #2 - Stack around the variable 'result1' was corrupted. Stack corruption happens in both release and debug (but a few more code lines might be needed to avoid the result1 object to be optimized away in release).
What in this very minimalistic code could be causing a stack corruption???
It should be noted that, of course, this was originally part of a much bigger code base. Initially the problematic code line was status = pDoc->load_file(file).status;, or  status = myDoc.load_file(file).status; - but that was much harder to debug since the stack corruption was silent (no exceptions, just stack corruption including a messed up this pointer in InitInstance). I have now reason to suspect that it was the creation/deletion of some intermediate xml_parse_result object returned by load_file() that was causing the stack corruption.
More details about the compiler settings causing this error:
Studio: VS2019
Platform: x64
Build: Both Debug and Release
Toolset: Visual Studio 2019 (v142)
MFC in a static library
Runtime library: /MT or /MTd
Struct alignment: Default

I'm fairly confident that this is something specific to your setup as pugixml does nothing unusual. It's possible perhaps that the way you're configuring the project, the .obj files for pugixml aren't rebuilt with correct settings. One other possibility is that you're including pugixml.cpp into the project, and also linking to some prebuilt library that contains pugixml.obj redundantly. Of course absent an actual example there's not much else that's possible to debug here...

Thank you for your reply zeux. Sorry, but I forgot to remove this issue when I found out what the root cause was. There was a bad #pragma pack (2) directive on the loose at one place in my codebase that caused the memory corruption. It just happened to show up first in the pugixml part, which I call early in my code.


"Python extension loading" super slow

Environment data

VS Code version: 1.50.1 (local)
Extension version (available under the Extensions sidebar): local : python v2020.10.332292344 remote :v2020.10.332292344
OS and version: Ubuntu 19.10
Python version (& distribution if applicable, e.g. Anaconda): XXX
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): venv
Value of the python.languageServer setting: Jedi

Expected behaviour
Be able to connect to VScode in remote in less than 15mins
Actual behaviour
Connects after 10/15 mins
Steps to reproduce:

Connect to my company VPN
open VScode
connect to remote ssh (working)
open a project and try to load kernels

XXX

Logs
console.ts:137 [Extension Host] (node:17707) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
t.log @ console.ts:70
workbench.html:1 A cookie associated with a cross-site resource at https://visualstudio.com/ was set without the `SameSite` attribute. A future release of Chrome will only deliver cookies with cross-site requests if they are set with `SameSite=None` and `Secure`. You can review cookies in developer tools under Application>Storage>Cookies and see more details at https://www.chromestatus.com/feature/5088147346030592 and https://www.chromestatus.com/feature/5633521622188032.
localProcessExtensionHost.ts:257 Extension Host
localProcessExtensionHost.ts:258 Debugger attached.
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] starting reconnecting loop. You can get more information with the trace log level.
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] waiting for 5 seconds before reconnecting...
console.ts:137 [Extension Host] (node:28811) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
t.log @ console.ts:70
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] resolving connection...
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] connecting to <IP_ADDRESS>:33637...
localProcessExtensionHost.ts:257 Extension Host
localProcessExtensionHost.ts:258 Debugger attached.
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] reconnected!
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] starting reconnecting loop. You can get more information with the trace log level.
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] waiting for 5 seconds before reconnecting...
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] resolving connection...
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] connecting to <IP_ADDRESS>:33637...
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] reconnected!
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] starting reconnecting loop. You can get more information with the trace log level.
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] waiting for 5 seconds before reconnecting...
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] resolving connection...
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] connecting to <IP_ADDRESS>:33637...
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] reconnected!
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] starting reconnecting loop. You can get more information with the trace log level.
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] waiting for 5 seconds before reconnecting...
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] resolving connection...
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] connecting to <IP_ADDRESS>:33637...
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] reconnected!
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] starting reconnecting loop. You can get more information with the trace log level.
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] waiting for 5 seconds before reconnecting...
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] resolving connection...
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] connecting to <IP_ADDRESS>:33637...
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] reconnected!
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] starting reconnecting loop. You can get more information with the trace log level.
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] waiting for 5 seconds before reconnecting...
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] resolving connection...
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] connecting to <IP_ADDRESS>:33637...
localProcessExtensionHost.ts:257 Extension Host
localProcessExtensionHost.ts:258 Debugger attached.
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] reconnected!
localProcessExtensionHost.ts:257 Extension Host
localProcessExtensionHost.ts:258 Debugger attached.
localProcessExtensionHost.ts:257 Extension Host
localProcessExtensionHost.ts:258 Debugger attached.
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] starting reconnecting loop. You can get more information with the trace log level.
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] waiting for 5 seconds before reconnecting...
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] resolving connection...
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] connecting to <IP_ADDRESS>:33637...
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] reconnected!
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] starting reconnecting loop. You can get more information with the trace log level.
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] waiting for 5 seconds before reconnecting...
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] resolving connection...
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] connecting to <IP_ADDRESS>:33637...
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] reconnected!
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] starting reconnecting loop. You can get more information with the trace log level.
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] waiting for 5 seconds before reconnecting...
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] resolving connection...
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] connecting to <IP_ADDRESS>:33637...
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] reconnected!
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] starting reconnecting loop. You can get more information with the trace log level.
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] waiting for 5 seconds before reconnecting...
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] resolving connection...
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] connecting to <IP_ADDRESS>:33637...
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] reconnected!
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] starting reconnecting loop. You can get more information with the trace log level.
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] waiting for 5 seconds before reconnecting...
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] resolving connection...
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] connecting to <IP_ADDRESS>:33637...
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] reconnected!
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] starting reconnecting loop. You can get more information with the trace log level.
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] waiting for 5 seconds before reconnecting...
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] resolving connection...
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] connecting to <IP_ADDRESS>:33637...
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] reconnected!
log.ts:185  INFO [remote-connection][Management   ][ae41d…][reconnect] starting reconnecting loop. You can get more information with the trace log level.
log.ts:185  INFO [remote-connection][Management   ][ae41d…][reconnect] waiting for 5 seconds before reconnecting...
extensionsViews.ts:288 Error querying extensions gallery Canceled
(anonymous) @ extensionsViews.ts:280
log.ts:185  INFO [remote-connection][Management   ][ae41d…][reconnect] resolving connection...
log.ts:185  INFO [remote-connection][Management   ][ae41d…][reconnect] connecting to <IP_ADDRESS>:46331...
log.ts:185  INFO [remote-connection][Management   ][ae41d…][reconnect] reconnected!
log.ts:197   ERR read ECONNRESET: Error: read ECONNRESET
	at TCP.onStreamRead (internal/stream_base_commons.js:200:27)
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] starting reconnecting loop. You can get more information with the trace log level.
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] waiting for 5 seconds before reconnecting...
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] resolving connection...
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] connecting to <IP_ADDRESS>:46331...
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] reconnected!
log.ts:197   ERR Unknown terminal: 4: Error: Unknown terminal: 4
    at f._getTerminalProcess (file:///usr/share/code/resources/app/out/vs/workbench/workbench.desktop.main.js:5247:326)
    at f._onRequestLatency (file:///usr/share/code/resources/app/out/vs/workbench/workbench.desktop.main.js:5246:792)
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] starting reconnecting loop. You can get more information with the trace log level.
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] waiting for 5 seconds before reconnecting...
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] resolving connection...
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] connecting to <IP_ADDRESS>:46331...
localProcessExtensionHost.ts:257 Extension Host
localProcessExtensionHost.ts:258 Debugger attached.
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] reconnected!
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] starting reconnecting loop. You can get more information with the trace log level.
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] waiting for 5 seconds before reconnecting...
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] resolving connection...
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] connecting to <IP_ADDRESS>:46331...
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] reconnected!
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] starting reconnecting loop. You can get more information with the trace log level.
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] waiting for 5 seconds before reconnecting...
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] resolving connection...
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] connecting to <IP_ADDRESS>:46331...
log.ts:197   ERR write EPIPE: Error: write EPIPE
	at afterWriteDispatched (internal/stream_base_commons.js:149:25)
	at writeGeneric (internal/stream_base_commons.js:140:3)
	at Socket._writeGeneric (net.js:776:11)
	at Socket._write (net.js:788:8)
	at doWrite (_stream_writable.js:435:12)
	at writeOrBuffer (_stream_writable.js:419:5)
	at Socket.Writable.write (_stream_writable.js:309:11)
	at Socket.ondata (_stream_readable.js:728:22)
	at Socket.emit (events.js:223:5)
	at addChunk (_stream_readable.js:309:12)
	at readableAddChunk (_stream_readable.js:290:11)
	at Socket.Readable.push (_stream_readable.js:224:10)
	at TCP.onStreamRead (internal/stream_base_commons.js:181:23)
console.ts:137 [Extension Host] Error: Unexpected SIGPIPE	at process.<anonymous> (/usr/share/code/resources/app/out/bootstrap.js:5:377)	at process.emit (events.js:223:5)
t.log @ console.ts:70
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] reconnected!
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] starting reconnecting loop. You can get more information with the trace log level.
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] waiting for 5 seconds before reconnecting...
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] resolving connection...
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] connecting to <IP_ADDRESS>:46331...
log.ts:197   ERR write EPIPE: Error: write EPIPE
	at afterWriteDispatched (internal/stream_base_commons.js:149:25)
	at writeGeneric (internal/stream_base_commons.js:140:3)
	at Socket._writeGeneric (net.js:776:11)
	at Socket._write (net.js:788:8)
	at doWrite (_stream_writable.js:435:12)
	at writeOrBuffer (_stream_writable.js:419:5)
	at Socket.Writable.write (_stream_writable.js:309:11)
	at Socket.ondata (_stream_readable.js:728:22)
	at Socket.emit (events.js:223:5)
	at addChunk (_stream_readable.js:309:12)
	at readableAddChunk (_stream_readable.js:290:11)
	at Socket.Readable.push (_stream_readable.js:224:10)
	at TCP.onStreamRead (internal/stream_base_commons.js:181:23)
console.ts:137 [Extension Host] Error: Unexpected SIGPIPE	at process.<anonymous> (/usr/share/code/resources/app/out/bootstrap.js:5:377)	at process.emit (events.js:223:5)
t.log @ console.ts:70
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] reconnected!
DevTools failed to load SourceMap: Could not load content for file:///usr/share/code/resources/app/node_modules.asar/semver-umd/lib/semver-umd.js.map:
DevTools failed to load SourceMap: Could not load content for file:///usr/share/code/resources/app/node_modules.asar/tas-client-umd/lib/tas-client-umd.js.map:
DevTools failed to load SourceMap: Could not load content for file:///usr/share/code/resources/app/node_modules.asar/xterm/lib/xterm.js.map:
DevTools failed to load SourceMap: Could not load content for file:///usr/share/code/resources/app/node_modules.asar/xterm-addon-unicode11/lib/xterm-addon-unicode11.js.map:
DevTools failed to load SourceMap: Could not load content for file:///usr/share/code/resources/app/node_modules.asar/xterm-addon-search/lib/xterm-addon-search.js.map:
DevTools failed to load SourceMap: Could not load content for file:///usr/share/code/resources/app/node_modules.asar/vscode-textmate/release/main.js.map:
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] starting reconnecting loop. You can get more information with the trace log level.
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] waiting for 5 seconds before reconnecting...
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] resolving connection...
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] connecting to <IP_ADDRESS>:46331...
log.ts:197   ERR write EPIPE: Error: write EPIPE
	at afterWriteDispatched (internal/stream_base_commons.js:149:25)
	at writeGeneric (internal/stream_base_commons.js:140:3)
	at Socket._writeGeneric (net.js:776:11)
	at Socket._write (net.js:788:8)
	at doWrite (_stream_writable.js:435:12)
	at writeOrBuffer (_stream_writable.js:419:5)
	at Socket.Writable.write (_stream_writable.js:309:11)
	at Socket.ondata (_stream_readable.js:728:22)
	at Socket.emit (events.js:223:5)
	at addChunk (_stream_readable.js:309:12)
	at readableAddChunk (_stream_readable.js:290:11)
	at Socket.Readable.push (_stream_readable.js:224:10)
	at TCP.onStreamRead (internal/stream_base_commons.js:181:23)
console.ts:137 [Extension Host] Error: Unexpected SIGPIPE	at process.<anonymous> (/usr/share/code/resources/app/out/bootstrap.js:5:377)	at process.emit (events.js:223:5)
t.log @ console.ts:70
$logExtensionHostMessage @ remoteConsoleUtil.ts:29
_doInvokeHandler @ rpcProtocol.ts:401
_invokeHandler @ rpcProtocol.ts:332
_receiveRequest @ rpcProtocol.ts:278
_receiveOneMessage @ rpcProtocol.ts:220
(anonymous) @ rpcProtocol.ts:93
fire @ event.ts:535
fire @ ipc.net.ts:407
_receiveMessage @ ipc.net.ts:755
(anonymous) @ ipc.net.ts:630
fire @ event.ts:535
acceptChunk @ ipc.net.ts:224
(anonymous) @ ipc.net.ts:149
t @ ipc.net.ts:892
emit @ events.js:223
addChunk @ _stream_readable.js:309
readableAddChunk @ _stream_readable.js:290
Readable.push @ _stream_readable.js:224
onStreamRead @ internal/stream_base_commons.js:181
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] reconnected!
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] starting reconnecting loop. You can get more information with the trace log level.
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] waiting for 5 seconds before reconnecting...
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] resolving connection...
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] connecting to <IP_ADDRESS>:46331...
log.ts:197   ERR write EPIPE: Error: write EPIPE
	at afterWriteDispatched (internal/stream_base_commons.js:149:25)
	at writeGeneric (internal/stream_base_commons.js:140:3)
	at Socket._writeGeneric (net.js:776:11)
	at Socket._write (net.js:788:8)
	at doWrite (_stream_writable.js:435:12)
	at writeOrBuffer (_stream_writable.js:419:5)
	at Socket.Writable.write (_stream_writable.js:309:11)
	at Socket.ondata (_stream_readable.js:728:22)
	at Socket.emit (events.js:223:5)
	at addChunk (_stream_readable.js:309:12)
	at readableAddChunk (_stream_readable.js:290:11)
	at Socket.Readable.push (_stream_readable.js:224:10)
	at TCP.onStreamRead (internal/stream_base_commons.js:181:23)
console.ts:137 [Extension Host] Error: Unexpected SIGPIPE	at process.<anonymous> (/usr/share/code/resources/app/out/bootstrap.js:5:377)	at process.emit (events.js:223:5)
t.log @ console.ts:70
$logExtensionHostMessage @ remoteConsoleUtil.ts:29
_doInvokeHandler @ rpcProtocol.ts:401
_invokeHandler @ rpcProtocol.ts:332
_receiveRequest @ rpcProtocol.ts:278
_receiveOneMessage @ rpcProtocol.ts:220
(anonymous) @ rpcProtocol.ts:93
fire @ event.ts:535
fire @ ipc.net.ts:407
_receiveMessage @ ipc.net.ts:755
(anonymous) @ ipc.net.ts:630
fire @ event.ts:535
acceptChunk @ ipc.net.ts:224
(anonymous) @ ipc.net.ts:149
t @ ipc.net.ts:892
emit @ events.js:223
addChunk @ _stream_readable.js:309
readableAddChunk @ _stream_readable.js:290
Readable.push @ _stream_readable.js:224
onStreamRead @ internal/stream_base_commons.js:181
log.ts:185  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] reconnected!
  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] starting reconnecting loop. You can get more information with the trace log level.
  INFO [remote-connection][ExtensionHost][bfd86…][reconnect] waiting for 5 seconds before reconnecting...

I succesfully connect to notebooks thanks to our Jupyterhub. Don't know if my VPN is not stable enough however it is strange because I do not have problems on youtube for example.

It seems to be linked to instable VPN connection.
However, I had the same problem at my parents house few weeks ago. As soon as the connexion is not perfect VScode heavily struggle to connect. So obviously, having a perfect connexion solve things, but when I'm able to watch youtube/twitch in 1080p, use Jupyterhub, I'm surprised that using VPN needs more bandwidths to start a kernel.

@jacquespeeters This occurs potentially because we try to run python for each of the installed and know virtual environments. We are working on refactoring how we look for environments to avoid this on extension load.

Great news, thank you for giving me visibility.

Hi,
Adding more information to whats allready provided - as I have the same issue "Python extension takes minutes to load".
In my case :
a. there is no VPN involved
b. 3 Virtual enviornements
c. Using Conda
Regards

Hi,
Adding more information to whats allready provided - as I have the same issue "Python extension takes minutes to load".
In my case :
a. there is no VPN involved
b. 3 Virtual enviornements
c. Using Conda
Regards

I still have huge trouble connecting in remote, it becomes really difficult to use VScode.
Here is another round of log
vscode_slow_connexion.log

I still have huge trouble connecting in remote, it becomes really difficult to use VScode.
Here is another round of log
vscode_slow_connexion.log

A quick update on this issue. We have a new environment discovery module, we are working on getting it to parity with the types of environments that we support. A change we did was to avoid running python and get as much detail about an environment using meta-data only. In cases where we do need to run python we throttle the number of processes to reduce the load. We are working on some bugs with the new code, when it is ready I will report back here with instructions on how to enable it.

A quick update on this issue. We have a new environment discovery module, we are working on getting it to parity with the types of environments that we support. A change we did was to avoid running python and get as much detail about an environment using meta-data only. In cases where we do need to run python we throttle the number of processes to reduce the load. We are working on some bugs with the new code, when it is ready I will report back here with instructions on how to enable it.

We have "pythondiscoverymodule" experiment that you can opt into to see if this helps with the loading issue, this should also reduce high-CPU issues.

Please try opting into pythondiscoverymodule experiment. This should resolve most of the issues where the extension ran too many python processes on startup. This will soon be enabled for all users, so closing this. Anyone running into this issue please try this and if you run into any bugs please file separate issues.
"python.experiments.optInto": ["pythonDiscoveryModule"]

I wasn't able to enable the experimental option pythonDiscoveryModule in version. Rolling back to an earlier version of the Python extension seemed to solve my issue. (Extensions > Python > Right-click > install another version > v2021.3.680753044).
VSCode Info:
Version: 1.55.1
Commit: 08a217c4d27a02a5bcde898fd7981bda5b49391b
Date: 2021-04-07T18:22:52.186Z (3 wks ago)

Please try opting into pythondiscoverymodule experiment. This should resolve most of the issues where the extension ran too many python processes on startup. This will soon be enabled for all users, so closing this. Anyone running into this issue please try this and if you run into any bugs please file separate issues.
"python.experiments.optInto": ["pythonDiscoveryModule"]

Was this rolled in to 1.57.1?
Connecting to a remote VM via SSH is unbearably slow still.

Was this rolled in to 1.57.1?

That is VS Code version number not the python extension version number. But yes, this is available in the latest version of the extension.
you might want to try opting into "python.experiments.optInto": ["pythonDiscoveryModuleWithoutWatcher"], this removes additional things to reduce that we search for. hopefully that should get you better perf.


[9.0.0] fix Wasi rights system to work with wasi-libc

https://github.com/bytecodealliance/wasmtime/pull/6265 introduced a regression with programs using wasi-libc, reported at https://github.com/WebAssembly/wasi-libc/issues/415.
Wasi-libc read the rights of the base directory (using fd_fdstat_get) and used those to mask the rights requested to path_open. In 6265, I changed the behavior of fdstat_get to always report and empty set of rights. This means that Wasi-libc will always pass an empty set of rights to path_open, which is a problem because the FD_READ and FD_WRITE rights are how path_open determines if a descriptor is to be opened for reading, writing, or both.
The fix is as follows:

directories always return the full set of rights in fd_fdstat_get.
we record the access mode that a file is opened with, and use that to set the FD_READ and FD_WRITE bits in fs_rights_base for a file's fd_fdstat_get.
A test demonstrates the behavior of the fdstat rights bits, and that opening for reading, writing, or reading and writing behaves correctly when calling fd_read and fd_write

This PR is just for the release-9.0.0 branch, I will work on upstreaming it to main but the situation there is slightly more complex because the test also needs to pass under the preview 2 implementation.

The bug that this fixed seems to have been reintroduced. With wasmtime 23.0.1 and wasi-sdk 23.0:
open-rw.c:
#include <stdio.h>
#include <stdlib.h>

int main() {
    // Note: using an `openat` call directly here with O_WRONLY or O_RDWR would have the same result
    FILE* file = fopen("testfile", "w");
    if (!file) return 1;
    fclose(file);
    return 0;
}

$ ls testfile
testfile
$ $WASI_SDK/bin/clang --sysroot=$WASI_SDK/share/wasi-sysroot open-rw.c -o open-rw-sdk.wasm
$ strace -e trace=openat2 wasmtime --dir=. open-rw-sdk.wasm
openat2(3, "testfile", {flags=O_RDONLY|O_CLOEXEC, resolve=RESOLVE_NO_MAGICLINKS|RESOLVE_BENEATH}, 24) = 5
+++ exited with 0 +++

wasmtime is calling openat2 with RDONLY, but "w" was passed as the access mode.


Can't Login Error 1020

Hey, thanks for the work you put in this repo.
I have an error 1020 when i'am trying to login with okcupidjs. It seems that cloudflare is blocking my attempt to login.
Here's my code:
okc.login(okc_username, okc_password, function(err, res, body) {
  if (err) {
    console.log("Failed to login.");
    console.log(body);
    process.exit();
  } else {
    console.log("Login succed.")
  }
})

Result:

Does anyone experienced this issue ?
Thanks for your help :)

It seems that OKC pass their API to graphql in late Feb. I believe this repo can't be use properly now and need update on all API point

Hi @mrpandat I am interested in fixing this repo. However, I couldn't really get that whether public API of OKC is available in any way? Do you have an answer?

hey, they don't have any public API, you have to retro-engineer their API calls with your web-inspector.
For example, the login through graphql look like this:

I made an example for login through graphql, but it still does not work... Still looking for a fix :)
https://github.com/mrpandat/okcupid-API/blob/1ec2d8c95c37f02b6b3576913db69bb8d71579d8/lib/client.js#L46

I'm trying to intercept okcupid calls through Burp. It seems like they're aware when I'm creating requests outside of the browser context and forbidding me to login (I tried with Python aswell).
Perhaps they started using cloudflare fingerprinting (https://github.com/cloudflare/mitmengine)?
Or does it work for you?

Can maybe someone confirm @tsarpaul hypothesis ?

I am able to create requests when using the browser's console, since it's using the firefox/chrome networking suite

want to be able to generate massive visibility on okc. started to get familiar with graphql and playwright library today. let's see how browser fingerprinting works. thanks for the quick reply @tsarpaul.  i stay tuned guys

want to be able to generate massive visibility on okc. started to get familiar with graphql and playwright library today and yesterday. let's see how browser fingerprinting works. thanks for the quick reply @tsarpaul. I stay tuned guys to that thread

It seems that all requests that are not HTTP2 are blocked. In addition to that a special cookie is required. Here is a starting point in Python for everyone who likes to port this to javascript:
import httpx
import uuid

query = '''mutation authUserLoginWithEmail($input: AuthUserLoginWithEmailInput!) {
		authUserLoginWithEmail(input: $input) {
			userid
			statusCode
			reenableAuthCode
			reenableUserid
			onboardingIncomplete
			__typename
		}
	}'''

variables = {'input': {'deviceId': uuid.uuid4().hex,
                       'email'<EMAIL_ADDRESS>                       'forceCaptcha': False,
                       'password': "password123"}}

client = httpx.Client(http2=True)

client.get('https://www.okcupid.com/login')  # initial cookies
client.cookies.set('ua', '531227642bc86f3b5fd7103a0c0b4fd6', domain='okcupid.com')  # static cookie to prevent auto login

r = client.post('https://www.okcupid.com/graphql',
                json={'operationName': 'authUserLoginWithEmail', 'query': query, 'variables': variables})

print(r.status_code)
print(r.text)


added version

with that, the users can chekc by script, if they are still up to date

This is a good change.  I used
version = importlib.metadata.version('laserbeamsize')
instead.  (I only want to update the version number in one place.)
Please let me know if the change works with your scripts.
Thanks again.

Well using importlib fails with my local (non-installed) version of laserbeamsize.  Now using your exact change.


Format Procedures and Functions

Unable to format Procedures and Functions
I was writing a trigger then I noticed that it was not able to format it and threw an error.
After the error is thrown it does not format any other code

As mentioned in the readme, the formatting of stored procedures is not supported.
Supporting this is not really feasible with the current architecture of the formatter. Also, various SQL dialects have different syntax for the procedures and this feature request does not mention an SQL dialect.


Google Safe Browsing API v3

Thanks @rjohnsondev for this cool library, and thanks @kgilonne for the port to GSBv3.
It would be great if we could merge the API version changes back into the original repository, or what do you think?
I have opened a bunch of other pull requests, both to the initial repository and the GSBv3 fork:
Pass HTTP transport object to initialisation:
https://github.com/rjohnsondev/go-safe-browsing-api/pull/7
https://github.com/kgilonne/go-safe-browsing-api/pull/1
Fix bug in conversion between C strings and go strings:
https://github.com/rjohnsondev/go-safe-browsing-api/pull/8
https://github.com/kgilonne/go-safe-browsing-api/pull/2
Retry initial update in case of errors:
https://github.com/kgilonne/go-safe-browsing-api/pull/3
If you have any suggestions or concerns, please let me know.
Regards,
Mathias

@rjohnsondev, are you interested in merging this back? I'm open for discussions if there are any concerns.

I am, but things like the CI need to be fixed and documentation updated.


A compiled binary file has been committed to git

I'm planning to use Digger and reading the source code.
I was surprised to see a 76MB compiled binary file committed to git in ./next/main. Is this intended?
https://github.com/diggerhq/digger/blob/9039c3a02f1becedf4aa943bde75ce6f8a9391aa/next/main
I'm new to Digger, so I don't fully understand the whole picture, but I just noticed it, so I'm reporting it.

I can raise a PR for this can I ?

Hi @Kamalesh-Seervi unfortunately to fix this it needs a force push to the main branch and rewrite of history so only someone with wrote access to the repo would be able to fix this