investigate coverage change in latest test runs

This pull request is an org file exploring our change in coverage.  That file was converted to markdown and included below

Summary
Current coverage
add older coverage
Separate old coverage from current coverage
Compare coverage
Which test changed?
Conclusion
appendix

About the test

Where is it?
What does this test hit now?

Add pending endpoints

Summary
Investigate the latest change in coverage, where 12 endpoints that were tested are no longer tested.

Current coverage
When we start up , we load up the most recent successful runs.
select distinct release,
                to_timestamp(release_date::bigint) as run_date,
                source
  from audit_event;

 release |        run_date        |                                                    source
---------+------------------------+---------------------------------------------------------------------------------------------------------------
 1.27.0  | 2023-03-13 18:56:16+00 | https://prow.k8s.io/view/gcs/kubernetes-jenkins/logs/ci-kubernetes-gce-conformance-latest/1635320420674572288
 1.27.0  | 2023-03-13 17:12:25+00 | https://prow.k8s.io/view/gcs/kubernetes-jenkins/logs/ci-audit-kind-conformance/1635327466912354304
 1.27.0  | 2023-03-13 20:11:55+00 | https://prow.k8s.io/view/gcs/kubernetes-jenkins/logs/ci-kubernetes-e2e-gci-gce/1635363958028242944
(3 rows)

From our current runs, we can see 12 endpoints are no longer covered. We do this by aggregating and tallying the conformance test hits from the latest runs.
with eligible as (
  select endpoint from conformance.eligible_endpoint_coverage e
   where not exists(
     select endpoint
       from conformance.pending_endpoint p
      where p.endpoint = e.endpoint
   )
), current_event as (
  select endpoint,
         test,
         release,
         to_timestamp(release_date::bigint) as release_date
    from audit_event
   where to_timestamp(release_date::bigint) >= current_date
)

select eligible.endpoint,
       count (distinct ce.test) filter(
         where ce.test like '%[Conformance]%'
       ) as current_conf_test_count
  from eligible eligible
       join current_event ce on (ce.endpoint = eligible.endpoint)
 group by eligible.endpoint
 order by current_conf_test_count asc
 limit 20;

                     endpoint                     | current_conf_test_count
--------------------------------------------------+-------------------------
 getSchedulingV1APIResources                      |                       0
 getAppsV1APIResources                            |                       0
 getBatchV1APIResources                           |                       0
 getPolicyV1APIResources                          |                       0
 getAuthorizationV1APIResources                   |                       0
 getApiregistrationV1APIResources                 |                       0
 getAuthenticationV1APIResources                  |                       0
 getAutoscalingV2APIResources                     |                       0
 getCoreV1APIResources                            |                       0
 getEventsV1APIResources                          |                       0
 getCoordinationV1APIResources                    |                       0
 getAutoscalingV1APIResources                     |                       0
 connectCoreV1OptionsNamespacedPodProxyWithPath   |                       1
 connectCoreV1OptionsNamespacedPodProxy           |                       1
 connectCoreV1DeleteNamespacedPodProxy            |                       1
 connectCoreV1HeadNamespacedServiceProxyWithPath  |                       1
 connectCoreV1HeadNamespacedServiceProxy          |                       1
 connectCoreV1DeleteNamespacedServiceProxy        |                       1
 connectCoreV1PatchNamespacedServiceProxyWithPath |                       1
 connectCoreV1HeadNamespacedPodProxyWithPath      |                       1
(20 rows)

add older coverage
Now, we will add the test runs currently on apisnoop:

ci-kubernetes-gce-conformance-latest/1631916050549313536

ci-audit-kind-conformance/1631923600443314176
    select * from load_audit_events('ci-kubernetes-gce-conformance-latest','1631916050549313536');

                                          load_audit_events
      -----------------------------------------------------------------------------------------
       events for 1.27.0 loaded, from ci-kubernetes-gce-conformance-latest/1631916050549313536
      (1 row)

     select * from load_audit_events('ci-audit-kind-conformance','1631923600443314176');

                                   load_audit_events
     ------------------------------------------------------------------------------
      events for 1.27.0 loaded, from ci-audit-kind-conformance/1631923600443314176
     (1 row)

Separate old coverage from current coverage
We can make a distinction in our events based on the release_date of the conformance run.
select to_timestamp(release_date::bigint) as release_date,
       case
       when to_timestamp(release_date::bigint) >= current_date
         then 'current'
       else 'previous'
       end as coverage_group,
       source
  from audit_event
 group by release_date,source;

      release_date      | coverage_group |                                                    source
------------------------+----------------+---------------------------------------------------------------------------------------------------------------
 2023-03-04 07:46:33+00 | previous       | https://prow.k8s.io/view/gcs/kubernetes-jenkins/logs/ci-audit-kind-conformance/1631923600443314176
 2023-03-04 09:20:45+00 | previous       | https://prow.k8s.io/view/gcs/kubernetes-jenkins/logs/ci-kubernetes-gce-conformance-latest/1631916050549313536
 2023-03-13 17:12:25+00 | current        | https://prow.k8s.io/view/gcs/kubernetes-jenkins/logs/ci-audit-kind-conformance/1635327466912354304
 2023-03-13 18:56:16+00 | current        | https://prow.k8s.io/view/gcs/kubernetes-jenkins/logs/ci-kubernetes-gce-conformance-latest/1635320420674572288
 2023-03-13 20:11:55+00 | current        | https://prow.k8s.io/view/gcs/kubernetes-jenkins/logs/ci-kubernetes-e2e-gci-gce/1635363958028242944
(5 rows)

so we can group our previous query to see if there’s been a change in test count.

Compare coverage
Putting it all together, we have this comparison query.
with eligible as (
  select endpoint from conformance.eligible_endpoint_coverage e
   where not exists(
     select endpoint
       from conformance.pending_endpoint p
      where p.endpoint = e.endpoint
   )
), event as (
  select endpoint,
         test,
         release,
         to_timestamp(release_date::bigint) as release_date,
         case
         when to_timestamp(release_date::bigint) >= current_date
           then 'current'
         else 'previous'
         end as time_period
    from audit_event
)

select eligible.endpoint,
       count (distinct test) filter(
         where test like '%[Conformance]%' and time_period = 'current'
       ) as current_conf_test_count,
       count (distinct test) filter(
         where test like '%[Conformance]%' and time_period = 'previous'
       ) as previous_conf_test_count
  from eligible eligible
       join event event on (event.endpoint = eligible.endpoint)
 group by eligible.endpoint
 order by current_conf_test_count asc
 limit 20;

                     endpoint                     | current_conf_test_count | previous_conf_test_count
--------------------------------------------------+-------------------------+--------------------------
 getSchedulingV1APIResources                      |                       0 |                        1
 getAppsV1APIResources                            |                       0 |                        1
 getBatchV1APIResources                           |                       0 |                        1
 getPolicyV1APIResources                          |                       0 |                        1
 getAuthorizationV1APIResources                   |                       0 |                        1
 getApiregistrationV1APIResources                 |                       0 |                        1
 getAuthenticationV1APIResources                  |                       0 |                        1
 getAutoscalingV2APIResources                     |                       0 |                        1
 getCoreV1APIResources                            |                       0 |                        1
 getEventsV1APIResources                          |                       0 |                        1
 getCoordinationV1APIResources                    |                       0 |                        1
 getAutoscalingV1APIResources                     |                       0 |                        1
 connectCoreV1OptionsNamespacedPodProxyWithPath   |                       1 |                        1
 connectCoreV1OptionsNamespacedPodProxy           |                       1 |                        1
 connectCoreV1DeleteNamespacedPodProxy            |                       1 |                        1
 connectCoreV1HeadNamespacedServiceProxyWithPath  |                       1 |                        1
 connectCoreV1HeadNamespacedServiceProxy          |                       1 |                        1
 connectCoreV1DeleteNamespacedServiceProxy        |                       1 |                        1
 connectCoreV1PatchNamespacedServiceProxyWithPath |                       1 |                        1
 connectCoreV1HeadNamespacedPodProxyWithPath      |                       1 |                        1
(20 rows)

Which test changed?
From the above query, we can limit to only those tests who do not have current_test_coverage, and see what tests hit them previously.
with eligible as (
  select endpoint from conformance.eligible_endpoint_coverage e
   where not exists(
     select endpoint
       from conformance.pending_endpoint p
      where p.endpoint = e.endpoint
   )
), event as (
  select endpoint,
         test,
         release,
         to_timestamp(release_date::bigint) as release_date,
         case
         when to_timestamp(release_date::bigint) >= current_date
           then 'current'
         else 'previous'
         end as time_period
    from audit_event
), diff as (
  select eligible.endpoint,
         count (distinct test) filter(
           where test like '%[Conformance]%' and time_period = 'current'
         ) as current_conf_test_count,
         count (distinct test) filter(
           where test like '%[Conformance]%' and time_period = 'previous'
         ) as previous_conf_test_count
    from eligible
         join event on (event.endpoint = eligible.endpoint)
   group by eligible.endpoint
   order by current_conf_test_count asc
)
select test
  from event
       join diff using(endpoint)
 where diff.current_conf_test_count = 0
   and event.time_period = 'previous'
   and test like '%[Conformance]%'
 group by test;

                                                              test
--------------------------------------------------------------------------------------------------------------------------------
 [sig-api-machinery] Aggregator Should be able to support the 1.17 Sample API Server using the current Aggregator [Conformance]
(1 row)

Conclusion
There were 12 points previously hit by a single test that, when this test changed sometime between 04/03 and 13/3 are no longer covered.

appendix

About the test

Where is it?
select  file
  from conformance.test
 where codename = '[sig-api-machinery] Aggregator Should be able to support the 1.17 Sample API Server using the current Aggregator [Conformance]';

                file
-------------------------------------
 test/e2e/apimachinery/aggregator.go
(1 row)

What does this test hit now?
select endpoint
  from audit_event
 where test = '[sig-api-machinery] Aggregator Should be able to support the 1.17 Sample API Server using the current Aggregator [Conformance]'
       and to_timestamp(release_date::bigint) >= current_date
 group by endpoint;

                    endpoint
------------------------------------------------
 createApiregistrationV1APIService
 createAppsV1NamespacedDeployment
 createCoreV1Namespace
 createCoreV1NamespacedSecret
 createCoreV1NamespacedService
 createCoreV1NamespacedServiceAccount
 createRbacAuthorizationV1ClusterRole
 createRbacAuthorizationV1ClusterRoleBinding
 createRbacAuthorizationV1NamespacedRoleBinding
 deleteApiregistrationV1APIService
 deleteApiregistrationV1CollectionAPIService
 deleteAppsV1NamespacedDeployment
 deleteCoreV1Namespace
 deleteCoreV1NamespacedSecret
 deleteCoreV1NamespacedService
 deleteCoreV1NamespacedServiceAccount
 deleteRbacAuthorizationV1ClusterRole
 deleteRbacAuthorizationV1ClusterRoleBinding
 deleteRbacAuthorizationV1NamespacedRoleBinding
 getAPIVersions
 getCoreAPIVersions
 listApiregistrationV1APIService
 listAppsV1NamespacedReplicaSet
 listCoreV1NamespacedConfigMap
 listCoreV1NamespacedPod
 listCoreV1NamespacedServiceAccount
 listCoreV1Node
 listRbacAuthorizationV1ClusterRole
 patchApiregistrationV1APIService
 patchApiregistrationV1APIServiceStatus
 readApiregistrationV1APIService
 readApiregistrationV1APIServiceStatus
 readAppsV1NamespacedDeployment
 replaceApiregistrationV1APIService
 replaceApiregistrationV1APIServiceStatus

(36 rows)

Add pending endpoints
This view was not yet in the db, but we needed it to make sure we were limiting to the right set of endpoints. I took the list from apisnoop’s pending endpoints list: https://apisnoop.cncf.io/conformance-progress/pending-endpoints
begin;
create table conformance.pending_endpoint(endpoint text);
insert into conformance.pending_endpoint(endpoint)
            values
                  ('createCoreV1NamespacedPersistentVolumeClaim'),
    ('createCoreV1NamespacedServiceAccountToken'),
    ('createCoreV1Node'),
    ('createCoreV1PersistentVolume'),
    ('createStorageV1CSINode'),
    ('createStorageV1StorageClass'),
    ('createStorageV1VolumeAttachment'),
    ('deleteCoreV1CollectionNamespacedPersistentVolumeClaim'),
    ('deleteCoreV1CollectionPersistentVolume'),
    ('deleteCoreV1NamespacedPersistentVolumeClaim'),
    ('deleteCoreV1Node'),
    ('deleteCoreV1PersistentVolume'),
    ('deleteStorageV1CollectionCSIDriver'),
    ('deleteStorageV1CollectionCSINode'),
    ('deleteStorageV1CollectionStorageClass'),
    ('deleteStorageV1CollectionVolumeAttachment'),
    ('deleteStorageV1CSINode'),
    ('deleteStorageV1StorageClass'),
    ('deleteStorageV1VolumeAttachment'),
    ('getFlowcontrolApiserverAPIGroup'),
    ('getInternalApiserverAPIGroup'),
    ('getResourceAPIGroup'),
    ('getStorageAPIGroup'),
    ('getStorageV1APIResources'),
    ('listCoreV1NamespacedPersistentVolumeClaim'),
    ('listCoreV1PersistentVolume'),
    ('listCoreV1PersistentVolumeClaimForAllNamespaces'),
    ('listStorageV1CSINode'),
    ('listStorageV1StorageClass'),
    ('listStorageV1VolumeAttachment'),
    ('patchCoreV1NamespacedPersistentVolumeClaim'),
    ('patchCoreV1NamespacedPersistentVolumeClaimStatus'),
    ('patchCoreV1NamespacedPodEphemeralcontainers'),
    ('patchCoreV1PersistentVolume'),
    ('patchCoreV1PersistentVolumeStatus'),
    ('patchNetworkingV1NamespacedNetworkPolicyStatus'),
    ('patchStorageV1CSIDriver'),
    ('patchStorageV1CSINode'),
    ('patchStorageV1StorageClass'),
    ('patchStorageV1VolumeAttachment'),
    ('patchStorageV1VolumeAttachmentStatus'),
    ('readCoreV1NamespacedPersistentVolumeClaim'),
    ('readCoreV1NamespacedPersistentVolumeClaimStatus'),
    ('readCoreV1NamespacedPodEphemeralcontainers'),
    ('readCoreV1NodeStatus'),
    ('readCoreV1PersistentVolume'),
    ('readCoreV1PersistentVolumeStatus'),
    ('readNetworkingV1NamespacedNetworkPolicyStatus'),
    ('readStorageV1CSINode'),
    ('readStorageV1StorageClass'),
    ('readStorageV1VolumeAttachment'),
    ('readStorageV1VolumeAttachmentStatus'),
    ('replaceCoreV1NamespacedPersistentVolumeClaim'),
    ('replaceCoreV1NamespacedPersistentVolumeClaimStatus'),
    ('replaceCoreV1NamespacedPodEphemeralcontainers'),
    ('replaceCoreV1NodeStatus'),
    ('replaceCoreV1PersistentVolume'),
    ('replaceCoreV1PersistentVolumeStatus'),
    ('replaceNetworkingV1NamespacedNetworkPolicyStatus'),
    ('replaceStorageV1CSIDriver'),
    ('replaceStorageV1CSINode'),
    ('replaceStorageV1StorageClass'),
    ('replaceStorageV1VolumeAttachment'),
    ('replaceStorageV1VolumeAttachmentStatus')
                  ;
select count(*) from conformance.pending_endpoint;
commit;

Addressed with https://github.com/kubernetes/kubernetes/pull/116658 to merge


Bigquery support

This PR add basic support for BigQuery backend.
Main changes:

uses sqlalchemy-bigquery package
add patches to re-map the UNION, INTERSECT and EXCEPT to the corresponding DISTINCT version which is a required keyword in BigQuery
use dialect specific date_diff syntax
fix under-determined "order by" function for the creation of the ranking column, which previously returned non deterministic results
adapt tests on column capitalization
adapt test on uniqueness by using the mod functions instead of "%"
skip tests on regex which is not supported by current sqlalchemy-bigquery
skip tests on primary keys not supported by BigQuery
skip tests based on random_normal_table which takes way to long to create

Btw, code coverage decreased but is related to the missing BigQuery backend in cicd, right?

Btw, code coverage decreased but is related to the missing BigQuery backend in cicd, right?

I would say so, yes.

Many thanks!


Better Form Validation for Forgive

You can't forgive someone more than your current balance, and you can't forgive them more than their current balance.
Check this before allowing people to sign a tx which then fails.

Put a close button in the InspectModal while at it.


Create umbraco-marketplace.json

Hi @AndyBoot - I noted you'd listed this package on the Umbraco marketplace, so firstly, thanks for taking the time to do that.  I noticed though that we only have the details collected from NuGet for the package... which is fine, but to help it to be found more easily it's possible to provide additional information, as is discussed here.
To get started with this I've created this PR, which will at least ensure your package is listed under what looks to be the appropriate category.  You can add more, like more tags, links, developer information, or extended descriptions and readme information.  I hope that's useful for you.

Thanks @AndyButland, I'll take a look at this later on this week 👍


XGboost get same result regardless of different random seed

Environment info
Operating System: Win7 64
Package used (python/R/jvm/C++): Python 2.7.13 [MSC v.1500 64 bit (AMD64)] on win32
xgboost version used: 0.6
Steps to reproduce

bst = xgb.train(param, xg_train, num_round, watchlist );
param['seed'] = 123
bst.predict( xg_train)

Issue
Use the same data and run above commands to train and predict data twice with different random seed set in step2, we get same predict result.
As my understanding, user need to set same random seed in order to get same result or it will get different result.  So now I am confused why we need random seed here.

Try using the subsample or colsample parameters and see if you still get the same result with different seeds.


fix example todo-mvc-react.

In this example the Todo final state is not declared final indeed I've noticed that Todos state.children keep growing while adding /removing Todo items. With just one line the problem get fixed.
The problem is probably present also into the other todo-mvc examples.

Thank you!


Horizontal scrolling using native Logitech feature

Description
Horizontal scrolling works using Shift+Wheel but it doesn't using the dedicated wheel for lateral scrolling with mice having that feature. The scroll bar flashes but editor or grid don't move.
Tested with Logitech MX Master
DBeaver Version
CE 22.3.2
Operating System
No response
Database and driver
No response
Steps to reproduce
No response
Additional context
No response

Hmm. Updating the Logitech Options software resolved the issue... Let's say I opened this if someone hit the snag.

Re-opening as behavior is not consistent. It does not work more often than it does.
Shift-Scroll is a workaround but native horizontal scrolling is better - and works in most other apps.

Please, specify your OS

updated + recorded video

Duplicate #8404 dbeaver/dbeaver/issues/8404


feat: added plugins

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


ch(reademe): update reademe

Coverage remained the same at 84.719% when pulling d0cc1b20eab4ba097457e44e6f949f38a1995bf5 on ch-update-readme-153980610 into feebdd76d53c0dcd12d276311a91f5790a81e764 on development.


Feature Request: t:uppercase is missing

Current version of the Reference Manual refers to a transform (https://github.com/SpiderLabs/ModSecurity/wiki/Reference-Manual#base64decode) t:uppercase that does not exist. It isn't a great issue, but in some circumstances it can be helpful and it is the perfect complement to the lowercase transform function. Now I've implemented it in Lua but I'm not so happy.

yeah, interesting. In general i can't think of a reason where uppercase would be needed versus lowercase on the backend like this as ascetics don't matter. In any event i've created a pull request to update the docs

@angeloxx I removed a reference, what were you thinking as the use case for this transformation? I'm more than happy to add it as a feature to v3 if we determine that it makes sense.

Thank you @csanders-git for your question; my use case is very trivial, I need to log the SHA1 version of the sessionid and I want it in uppercase format to find it easly in the log file. It isn't the most common use of a transform, but if the lowercase is available I think is a good idea to implement the uppercase also.
To be more serious, always in the same context will be useful to also have the SHA256 (or similar) hashing algorithm because the md5 and sha1 - in our use case - is too weak.

@angeloxx I've submitted pull request #1439 for this feature in libModSecurity. It should be accepted to the main v3 branch once @zimmerle finishes his review process. You might want to give it a try before to see if helps with your needs.

I will close this one now and update the docs once the patch is accepted in the master. Let us know if anything and we reopen it if needed.

Added to the Reference manual as of 4a6998b


nvm self update

looking at the docs I don't see a great way to keep nvm itself updated, if you aren't using a package manager to install it anyways. The only way I can think of is to download the install.sh from master instead of a tag, though I suspect this is dangerous due to master being a non release point. Ideas

have a maint branch that is only merged into upon release
have a latest tag that can be used to reference the latest release
if needed have maint-vx.x branches to maintain multiple versions

Duplicate of #400.

Duplicate of #400.


Aws auth

Grant additional AWS users or roles the ability to interact with the EKS cluster.
Update the advanced example to reflect this new addition.
Fix the advanced example as the master branch has a broken version of it.

@vlesierse Is there anything I can do to get this moved forward? Thanks!

Hi, I'm interested in this too; is there anything needed to merge it? @vlesierse

Great idea which I've thought about as well.

Ok, merged the PR. Will create a new release.


enable embargo feature

This should allow us to block access, on a per course basis, from certain countries.
from the documentation:

reverse proxy should be configured appropriately for example Client IP address headers (e.g HTTP_X_FORWARDED_FOR) should be configured.

This setting may have some unintended side effects, as well as some undocumented dependencies. We should enable it in a CI or QA environment first, for testing.

:+1:


ENH: Move definition of ITK_TEMPLATE_EXPORT

Move the hard-coded defintion of ITK_TEMPLATE_EXPORT to
a cmake GENERATE_EXPORT_HEADER generated file
that provides consistent definitions and protocols
for defining how symbols are exported.
https://cmake.org/cmake/help/v3.10/module/GenerateExportHeader.html
This is a first step towards using a more consistent
approach to defining export symbols.

Abandoning this work.


Addition of time picker

Not sure if this makes sense within existing date picker, or a separate element.  However it would be nice to be able to pick a date and time.

It would be great if there was option for both a separate element and along with the existing date picker. Will this be implemented in the near future?

In Android 5, there's a separate dialog for time picking. It's very well designed, it looks like a clock with two rings of labels (1-12 and 13-24), or, if your locale uses 12h format, one label ring and two buttons for AM and PM:

After picking the hour, there's a transition of the label ring(s) to a label ring for the minutes, in 5 minute steps. You can either tap on one of them, or drag to enter a precise minute. A confirmation is required after picking the minute to close the dialog.
If you click on the hour at the top, it will return to the hour picking mode (also with a nice animation).

This is great for mobile but there is no material design Date time picker for the web.

The original pickadate.js which materialize's is based on does have a time picker. So perhaps, that could be extended similarly.

Echoing what @syedsuhail said, these time pickers are nice for mobile devices, but they do not work so well on desktop devices. More thought will have to go in to these.

I'd love to see some sort of timepicker as well :+1:
For the moment if would be great to add a little bit of styling to the time input, as it is currently completely unstyled.

:+1:

@Dogfalo It's been quite a while since this was suggested, are there any plans to implement some kind of time picker?

@Dogfalo, I'd love to see some kind of time picker, as @carlosperate mentioned earlier.

Heavily inspired from http://simeonc.github.io/md-date-time/ I develop this very simple time picker for my project. I'll try to keep it as simple as possible.
Require Materialize and jquery.
http://jsfiddle.net/kakamiokatsu/o3osy173/
Any feedback is welcome!

I found this one by chance, looks promising: https://github.com/weareoutman/clockpicker

@ABeltramo : that one (md-date-time) is awesome and it has a date- and timepicker

I see it but I need somenthing simpler and I don't want to include angular..

:+1:

:+1:

This one also looks nice: https://github.com/mattkrick/lolliclock

:+1:

+1

:+1:

:+1:

:+1: I'm also all for the Android/Lolliclock implementation. Don't care if it's the same on web as on mobile.

:+1:

this one also looks nice: http://material-ui.com/#/components/time-picker

:+1: This along with date pick would be a great addition

Any appetite for something like this @Dogfalo and co?

:+1:

:+1:

:+1: Datetime picker would be a great improvement !

Best would be Date and Time picker as one component !

I second a combined date and time picker.

+1

+1 on a datetime and a time picker (:

A combined datetimepicker would be very nice

+1

+1

+1

+1

so if this makes a change, +1 from me too ;)

+1

+1 We need this

:+1:

+1 Where is the time support?

+1

+1 Time support would be awesome

Input type=type is there in css file What is the class and js required?

Docs for timepicker are here : http://amsul.ca/pickadate.js/time/
Two things missing : datetime picker and timepicker with material

Any solution ?

I made a some modification to https://github.com/weareoutman/clockpicker
Now, it can be used as a addition clockpicker to materializecss
https://github.com/chingyawhao/materialize-clockpicker

@chingyawhao great work man, could you please make a pull request or maybe publish your work on atmosphere ?

@boustanihani thanks, but I'm not too familiar with git...can you fork a branch..?

I'll take a look...

Forking is not an issue, but I never used grunt before :( so I guess we have to leave this for the material guys...

I see...thanks for your help anyway

Please add TimePicker and DatetimePicker like "Bootstrap Material DatePicker"
Demo: http://t00rk.github.io/bootstrap-material-datetimepicker/

+1

+1 for chingyawhao's design. Looks really good! :)

Thanks @Tobi042...

+1

+1

Would love to know if there are any plans to implement the date/time picker and if so what the timeline is looking like.

+1

+1

+1

+1

+1

+1

+1

:+1:

+1 :laughing:

+1

+1

+1

+1

+1

+1

+1

Datetime Picker that you can opt use only Date Picker or Time Picker.

This one is nice: http://jonthornton.github.io/jquery-timepicker/

:+1:

+1

:+1:

I ended up using @chingyawhao's materialize-clockpicker

Copy the JS and CSS into project
Create a text input which includes timepicker class
Add the following code to your application.js or wherever you fancy. This initialises the time picker as well as stop error styling being eagerly activated if you are using client side validations.

  $('.timepicker').pickatime({
    twelvehour: true,
    donetext: 'Done',
    beforeShow: function() {
      activeElement = $(document.activeElement)
      activeForm = activeElement.closest('form')[0]

      // Remove existing validation errors
      activeForm.ClientSideValidations.removeError(activeElement)

      // Prevent a validation error occurring when element un-focusses
      activeElement.disableClientSideValidations();
    },
    afterDone: function() {
      activeElement = $(document.activeElement)
      $(activeElement).enableClientSideValidations();
    }
  });

Thanks @chingyawhao !

:+1:

@patricklindsay Dear Patrick, I've followed your suggestion but it when I click into a text field, it says: ncaught TypeError: Cannot read property 'removeError' of undefined, at line:
activeForm.ClientSideValidations.removeError(activeElement)
Can you help me? I think that I followed your solution to the letter :(

It looks like the above code doesn't seem to be working so well... seems to conflict slightly with the pickadate dom for me.

If you want, you can take my solution.
https://github.com/artfable/plugins/tree/master/timepicker

+1

:+1:

+1

:+1:

:+1:

:+1:

:+1:

+1

:+1:

This is one i made a while ago, not to many options. It CSS Powered so its quick, not a lot of JS going on. If you want to fork and fix it up go for it. Theme is set for the project i was working on by everything is editable. Materialize or pickatime is not a dependency, just jQuery. Auto-initializing, just use the right class on a text field.
https://github.com/clandestine8/GMD-SimpleFancy-Timepicker

I ended up using @chingyawhao 's as well. The styling and look are great, but I think if a solution is officially incorporated into materialize it would be served using the pickatime library from Amsul. This would provide a consistent interface between date picking and time picking within materialize, which would be much more straightforward for developers adopting materialize as their front end framework of choice.
If time permits, I'm considering trying to shoehorn @chingyawhao 's picker into materialize using the pickatime library instead of clockpicker. I think @chingyawhao 's picker really nails the look and feel of materialize, but the underlying JS library is a bit cumbersome compared to the simplicity and straightforward nature of pickatime.js. Is this something the materialize devs would be interested in me working into a PR? I hope to be able to do this, but once again, it all comes down to time for me. Hopefully I can make it happen.

Wondering if this is going to happen at some point.  Seems like we really need a time picker

We resorted to using the timepicker that comes as an add on to the one used in the geeks lab materialise admin them. There's a demo used which you can use to see how it works
On Sun, Sep 4, 2016 at 7:19 PM +1000, "Joel Albert"<EMAIL_ADDRESS>wrote:
Wondering if this is going to happen at some point.  Seems like we really need a time picker
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

any update ? I really want one for a "X minutes from now" style

+1..
Does some of the suggestions include a time-picker not referred to TimeOfDay, but TimePeriod instead?. Where it is possible to introduce something like this:
52:42:51
or
00:00:00.123

+1

+1

+1

+1

+1

I'm not the only one who wish to see a timepicker in the materialize framework. 👍
What you other are using for replacement for now?

+1

+1

+1

+1

+1 We need this badly

I'm gonna start working on this, but it might take me a while
Wish me luck

+1

Would you guys mind having moment.js added as a requisite?  its fairly light, however I'm going to extract the code needed

I know that pickatime.js is made by the same people that did the date picker so that could also be an option
Get Outlook for iOS
On Sun, Nov 20, 2016 at 11:47 AM +1000, "Noah Overcash"<EMAIL_ADDRESS>wrote:
Would you guys mind having moment.js added as a requisite?  its fairly light, however I'm going to extract the code needed
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

I'm looking at https://github.com/T00rk/bootstrap-material-datetimepicker (ignore the name, doesnt require bootstrap anymore)

That is pick a time.js

Heres what im working on

Yeah, I think in materialize admin they added a skin for pickatime
Get Outlook for iOS
On Sun, Nov 20, 2016 at 12:01 PM +1000, "Noah Overcash"<EMAIL_ADDRESS>wrote:
That is pick a time.js
Heres what im working on
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Alright, I'm preparing a pull request

FWIW I think a time picker does also well on desktops with a mouse and keyboard. Users rather click and drag things than select a dropdown list or even type values.
:+1: for a time picker component.

I'm getting a PR ready, but I'm short on time today.  Here's a JSFiddle (code's messy, couldn't get jQuery to load right)
https://jsfiddle.net/1yt7241c/

Can anyone test the above link and provide some feedback before I implement?  Thanks

I did some tests, its a great first start. Here's my feedback:

You can't drag the time pieces
There are no animations or smooth transitions
Bottom buttons should be centred

Just my 2c. Hope that helps!

Thanks, ill work it

I can't figure out quite how to make them draggable.  Any tips?

I changed the buttons, hopefully they are better now.

I feel like an SVG is the easier way to go… but you’d probably need to do some maths to get that to work and tie in with mouse x+y
From: Noah Overcash<EMAIL_ADDRESS>Reply-To: Dogfalo/materialize<EMAIL_ADDRESS>Date: Wednesday, 23 November 2016 at 06:30
To: Dogfalo/materialize<EMAIL_ADDRESS>Cc: Daniel Holmes<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [Dogfalo/materialize] Addition of time picker (#473)
I changed the buttons, hopefully they are better now.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

It's an SVG, I just dont know how to make the mouse interaction work.

Hello, Nice work. If I can give my 2 cent. The OK Button is not clear. I expect that the ok button will validate and not let us choose the minutes. Maybe a button which let us change the hours and the minute and then click OK only to validate the choice.
Maybe to click on the hour could allow us to choose the hour and to click in the minute will allow us to choose the minute.

Would changing the OK button to "NEXT" on the hour picker work?

https://jsfiddle.net/1yt7241c/3/ try this.

@smileytechguy To get dragging working, you'd need to setup:

When the clock is clicked (touchstart, mousedown) events, register an event handler on the window for the touchmove and mousemove events. These events will send the x,y coords of the mouse or finger which we can use to determine the angle around the circle.
When we setup our touchmove and mousemove events we'll also need to setup a touchend and mouseup event to cancel the event listeners.
To calculate the angle around the circle we need to get the center of the clock (x1, y1) and pass it into Math.atan2. The mouse position is (x2, y2) so we can get the angle of the mouse around the clock (in radians not degrees) by calculating Math.atan2(y2-y1, x2-x1)

From that you should have enough to work with to get the dragging working. The math might need a little tweaking and I'm sure someone more mathy than I will chime out if I've made any mistakes here :)
Hope that helps!

Thanks for the tips, but I don't think I can do all that.  Maybe in a later PR.  For now, unless anyone thinks I need to change anything on https://jsfiddle.net/1yt7241c/3/, I'll make an initial PR.

Sorry to be so meticulous, but when clicking the 'next' button, the 'cancel' button should turn to 'back'.
Also when we click 'next' the button change to 'OK' which is good, but if we click cancel to choose go back to hours, the 'OK' button should thenchange to 'next' again and not stay 'OK'.

I've made a pr a while back: https://github.com/Dogfalo/materialize/pull/2732
Maybe the code can help you.
it's responsive and the timepicker is draggable.

@philipraets This seems perfect. Why wasn't this merged in?  No movement from authors?

I have no idea why it hasn't been merged yet.
If anyone wants to try, test, bugfix or update it to the latest code of materializecss and merge it, please do. I don't have time to maintain it, and my project hasn't been updated with the latest code from materializecss after I've made this, but the date-and timepicker are used on a daily basis at the company I work for.

I've created a codepen so you can see it in action: http://codepen.io/anon/pen/woqevN

I just tested on a few phones, and laptops of varying os and browsers. It's practically flawless!
_____________________________
From: Philip Raets<EMAIL_ADDRESS>Sent: Sunday, November 27, 2016 07:07
Subject: Re: [Dogfalo/materialize] Addition of time picker (#473)
To: Dogfalo/materialize<EMAIL_ADDRESS>Cc: Comment<EMAIL_ADDRESS>Daniel Holmes<EMAIL_ADDRESS>I've created a codepen so you can see it in action: http://codepen.io/anon/pen/woqevN
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Looks great!  Someone needs to get @Dogfalo or another maintainer to approve the PR, probably a lot to merge now.

cc @acburst

Any updates on this guys?

@shigawaka not afaik

@shigawaka not afaik
Personally, I just forked his version and used it

@smileytechguy Did you successfully merge the pickatime code into your fork of v0.97.8? I don't see the code in your master.

@calitidexvii no i didnt, that fork is unrelated afaik.  havent messed with it in a while

@smileytechguy Thanks.
Has anyone else worked on updating PR 2732 for v0.97.8? I'd be willing to work on it if I could get a commitment from the maintainers to actually merge it, or an explanation of what's missing. It seems to be the most complete implementation and works great on desktop.

Like other people, I'm using materialize.clockpicker from @chingyawhao. Why not create a PR based on that? Visually at least it's very nice.

I do agree about it, it's vert nice, but it lacks some functionality
You can't change easly year  (current datepicker it's also a bit buggy about)
I would be nice to have a single datetime picker field.
And maybe a range picker.
Anyway this seems much better than current solution.

Has this been implimented? There's no reason why @jaitaiwan's solution shouldn't be implimented. it's exactly like the built-in time picker in android.

Has any time picker been implemented yet? Is there a reason some of the examples above can't be?

I've created a new clean PR #4445 which is compatible with the latest code.

Added in https://github.com/Dogfalo/materialize/commit/12003cea3c932232d59c25560f0c2973ab46ec11


bugfix: create folders as needed

closed in favor of https://github.com/PhotoboothProject/photobooth/pull/741


Add option for enabling complex number support.

I'm not familiar with the codebase of DesModder, but I recently figured out how to enable what seems like experimental complex number support in Desmos. It needs to be done very early on in the initialization of the Calculator object, but if you set Calc.controller.graphSettings.config.allowComplex = true right when the calculator initializes (or just pass it in as true in the config object for the Calculator constructor), it enables this switch:

From my testing it appears to work pretty well too.

Seems like it would be pretty simple, just adding something to settingsConfigList in https://github.com/DesModder/DesModder/blob/main/src/plugins/builtin-settings/config.ts like
{
    key: "allowComplex",
    type: "boolean",
    default: false,
 }

Not planned, sorry. It will come out when it comes out (hopefully soon).


remove the special character from the first and last lines

What this PR does / why we need it:
This PR will remove  "```" characters appearing on the first and last lines during Auto Generate Release Log execution.
And this will facilitate developers to not manually delete special characters after automatic generation. (Auto Generate Release Log)
This issue will not affect the user experience, but it will affect the efficiency of developers.
Will this PR make the community happier?
Yes
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
How is this PR tested

[x] unit test
[ ] e2e test
[ ] other (please specify)

Special notes for your reviewer:
Release note:

- remove the special character from the first and last lines on changelog

In the past, every time an Auto Generate Release Log was executed, it would generate code as shown in the following figure:

As you can see, the generated changelog will add  ```  characters to the first and last lines, but in reality, the changelog you see does not have this character. This is all thanks to our developers manually deleting it.
Now this patch will remove those characters, eliminating the need for developers to manually delete those.
Like this:


Disallow following symlinks in 6.2.9

Overall Review of Changes:
Enforced to not follow symlinks in ansible > 2.5, please see:
https://docs.ansible.com/ansible/latest/collections/ansible/builtin/file_module.html
https://docs.ansible.com/ansible/latest/collections/ansible/posix/acl_module.html
Issue Fixes:
There is no issue reported, running the playbook found it change chmod in /usr directory files where venv environment exists in user directories. (Not tested) but seems to basically follow symbolic links so if user make symbolic link in his home directory to /usr the playbook change all attributes in /usr directory.
How has this been tested?:
Yes seems to be working correctly

hi @dulin-gnet
Thank you for raising this PR. Feedback like this helps us to improve. This is a great find for cases such as these were it will break things for some users.
How about if we made this a variable that can be toggled? leaving the default as it is now as true. But the option to change it based upon the circumstances for each configuration?
We could add the new variable into the defaultas main and then update the control?
This allows users to not have to change anything as it currently runs but gives them the option as you have found.
e.g.
Allow rule to follow symlink to change perms default true
rhel8cis_6_2_9_follow_symlinks: true
We do also ask with each PR that we have a signoff and gpg signing for each commit. Currently the pipeline has failed as the sign off is missing.
best regards
uk-bolly

Hi @uk-bolly
Thanks for prompt response.
As you can see the default behavior was changed in ansible:

I do not think so the following symlinks is recommended in this section as can generate mess in any directory.
Not sure regarding signing of is enabled by default in my environment :

  signingkey = FE006FAA
  gpgsign = true```

Followed the instruction and forced update.

Going to run another test and leave some more info soon.

hi @dulin-gnet
Thank you again for getting back so quickly.
I can see that the gpg sign exists but the "signed-off-by" line was missing from the commit.
here is an example of my git config file that sets this up in my circumstances. I hope this helps.
trailer.sign.key=Signed-off-by:
trailer.sign.ifmissing=add
trailer.sign.ifexists=doNothing
trailer.sign.command=echo "$(git config user.name) <$(git config user.email)>"

With regard to the variable, the default being true is what many people are currently using. So they will be following symlinks as it currently stands. We have only supported 2.9+ for some time.
While I agree we shouldn't follow symlinks be default, in this case but to change the way it actually works and has done for some time could have an affect some users. This way this enables them to adjust if needed without actually forcing the change in this in the code but overridden by variables.
I hope that makes some sense?
Kindest regard
uk-bolly

Hi @uk-bolly
Thanks for config going to use!
So I have done one more tests:
So basically created symbolic link to /usr/bin directory and run CIS playbook:
[m.dulinski@lab ~]$ ln -s /usr/bin
[m.dulinski@lab ~]$ ls -ZFlah /usr/bin/alias
-rwxr-xr-x. 1 root root system_u:object_r:bin_t:s0 29 Jun 20  2022 /usr/bin/alias*
[m.dulinski@lab ~]$ ls -ZFlah /usr/bin/alias
-bash: /home/m.dulinski/bin/ls: Permission denied

So after run we got issue with executing the commands:
changed: [LVD-NBX-APP-L2] => (item=/home/m.dulinski)

failed: [LVD-NBX-APP-L2] (item=/home/foreman-proxy) => {
    "ansible_loop_var": "item",
    "changed": false,
    "item": [
        "/home/foreman-proxy",
        {
            "atime":<PHONE_NUMBER>.3184211,
            "attr_flags": "",
            "attributes": [],
            "block_size": 4096,
            "blocks": 0,
            "charset": "binary",
            "ctime":<PHONE_NUMBER>.102937,
            "dev": 64775,
            "device_type": 0,
            "executable": true,
            "exists": true,
            "gid": 1008,
            "gr_name": "foreman-proxy",
            "inode": 2117770,
            "isblk": false,
            "ischr": false,
            "isdir": true,
            "isfifo": false,
            "isgid": false,
            "islnk": false,
            "isreg": false,
            "issock": false,
            "isuid": false,
            "mimetype": "inode/directory",
            "mode": "0700",
            "mtime":<PHONE_NUMBER>.47223,
            "nlink": 3,
            "path": "/home/foreman-proxy",
            "pw_name": "foreman-proxy",
            "readable": true,
            "rgrp": false,
            "roth": false,
            "rusr": true,
            "size": 74,
            "uid": 1008,
            "version": "1296879448",
            "wgrp": false,
            "woth": false,
            "writeable": true,
            "wusr": true,
            "xgrp": false,
            "xoth": false,
            "xusr": true
        }
    ],
    "rc": 1
}

MSG:

MODULE FAILURE
See stdout/stderr for the exact error

MODULE_STDERR:

/bin/bash: Permission denied

As we can see, the running the role is unsafe, and the section:
TASK [RHEL8-CIS : 6.2.9 | PATCH | Ensure all users' home directories exist] ******
Should only do the changes in user home directory. Not in symlinks It is pointless to define any variable which by default is wrong and can make changes. I think the role should be safe to re-run at any time, but in current state it isn't.
Just for more info:
➜  ~ ansible --version
ansible [core 2.13.6]
  config file = None
  configured module search path = ['/home/martin/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /home/martin/.local/lib/python3.11/site-packages/ansible
  ansible collection location = /home/martin/.ansible/collections:/usr/share/ansible/collections
  executable location = /home/martin/.local/bin/ansible
  python version = 3.11.1 (main, Dec 31 2022, 10:23:59) [GCC 12.2.0]
  jinja version = 3.1.2
  libyaml = True

I have recently switch to the devel version of RHEL8-CIS as it support never version of ansible, this issue happens before with the dev boxes where users created their virtualenv directories.
Regards,
Marcin

For what it's worth, I have 6.2.9 disabled everywhere because of this issue :-) it really breaks all the time due to weird symlinks


Fix isGenericReducibleType to allow HKT technique to function again

Fixes #53970.

@typescript-bot test this
@typescript-bot user test this inline
@typescript-bot run dt
@typescript-bot perf test faster
@typescript-bot test top100

@typescript-bot pack this

@ahejlsberg nice, i confirm that zodios use case is working again : link to playground

Amazing thank you!

Latest commit reverts the changes to type inference and instead fixes the issue by making isGenericReducibleType more conversative. The previous logic would wrongly classify TTypeLambda & { readonly A: A; } as being reducible even though there are no discriminant properties in the type. That's now fixed.

@typescript-bot test this
@typescript-bot user test this inline
@typescript-bot run dt
@typescript-bot perf test faster
@typescript-bot test top100

@typescript-bot pack this

Amazing! Looks great

@weswigham mentioned that this may break a case where two generic litearl kind props were intersected, but I can't seem to make this case up; can you give an example?
I've tried this to no avail. Playground Link

@typescript-bot cherry-pick this to release-5.1

@typescript-bot cherry-pick this to release-5.1
... please?


Update azure-core-test dependency version

Description
Since azure-core-test is meant to be a test-only dependency within the SDKs, this updates the dependency version to the last released beta version. The plan moving forward is that azure-core-test will only release as a beta version from here on out, allowing for greater flexibility in making changes to the library.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

LGTM for mgmt libs.


Update README.

Update list of dependencies.
Update Go version.
Clarify usage of GO15VENDOREXPERIMENT.
Provide link to ARM readme.

LGTM


Is there a method to config the target of live migration ?

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:
/kind bug
/kind enhancement

As far as I know, there is no setting of target migration.
Sometimes we need to set specific target of migration due to rebalancing resource.
What happened:
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

KubeVirt version (use virtctl version):
Kubernetes version (use kubectl version):
VM or VMI specifications:
Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

@qkfrksvl the migration target will be chosen based on VMI node selectors, affinities and so forth. This turned out to be sufficient in the past for most relevant use-cases. Could you share what you are trying to achieve? That would help us either working with you on a solution based on implemented flows, or would provide a use-case which may make us reconsidering our current possibilities.
/triage needs-information

@rmohr  it would be possible if kubevrit admission webhook allow to edit property spec.nodeSelector in VMI manifest. So the steps will be:

edit or add spec.nodeSelector in VMI object and put the target node label
apply VirtualMachineInstanceMigration to run live migration

/reopen
/remove-lifecycle rotten

/remove-lifecycle stale

/reopen


Updating roadmap image to latest

Description
Removed the outdated roadmap image for WinUI 3 and updated it to show the latest one featured in the last community call.
Thanks to @dotMorten for bringing this to my attention.

/azp run

@StephenLPeters Also added updates to P1->P2 upgrade instructions in this PR.

you should be able to kick off the pipeline yourself if you'd like by adding a comment with /azp run

Looks good :)

/azp run

@StephenLPeters Thanks! I'll do that from now on.

@anawishnoff can you merge this with master to pick up the fix for the pipeline failure we are seeing here?

/azp run

Hey @StephenLPeters not sure why these tests are failing. I merged with master again yesterday. Any ideas?

@anawishnoff Looking at the failing test - TabViewTests.GamePadTest - pretty sure you just got "unlucky" here and there's a good chance another run of the test pipeline will succeed. Sometimes it just happens that completely unrelated tests fail.

I'm sure it'll work if you change the roadmap so WinUI3 will be release this year ;-)

/azp run


Bug: Gate Links should open in correct leaf

https://github.com/nguyenvanduocit/obsidian-open-gate/blob/main/src/main.ts#L187
Bug:
This line does not pass in the gate's position when a gate is matched on title. The result is that it opens up in wrong spot in the UI (defaults to the right side).
Desired Behaviour:
Opening a gate via a link should open in the position configured in the gate settings.
Solution:
Pass the gate position into the call to openView.

Thank you, fixed in master


Style labels

Style labels to look similar to what they look like in GitHub.
Will need to convert RGB values to HSL for label background and text-highlight.

Fixed in 0cd4b38c89426959bf1bd16910eec0740389f22c


[Application Roles] : After deletion, role is not removed from an application

Describe the issue:
After deleting an application role from the "Roles" page, the role is not removed from the application.
https://drive.google.com/file/d/1M0ssJwGj4RaMpviH_BJUJhlcEOXt1_Mx/view?usp=sharing
How to reproduce:

Login to IS Console
Navigate to "Roles" page
Create an application role and assign it to a relevant application
Delete the above role from the "Roles" page
Navigate to the application and verify the roles connection

Expected behavior:
Once deleted, role should be removed from the application successfully
Environment information (Please complete the following information; remove  any unnecessary fields) :

Product Version: [e.g., IS 5.10.0, IS 5.9.0]
OS: [e.g., Windows, Linux, Mac]
Database: [e.g., MySQL, H2]
Userstore: [e.g., LDAP, JDBC]

Optional Fields
Related issues:

Suggested labels:

Tried with the latest master of product-is (8:40am 2023-11-18) and unable to reproduce this

https://github.com/wso2/product-is/assets/39567992/39ba140e-7d05-4312-9e5d-2e5eb3c45905

@GoushiRam can you verify whether the tried flow is correct?

@GoushiRam can you verify whether the tried flow is correct?

Previous pack where this was verified is having this issue. The latest pack verified with "#4931" this issue is not reproducible. Hence closing this issue
cc: @somindatommy @NilukaSripalim


Is it a good idea to extend cli to forward arbitrary AfterEffects parameter?

Recently, we have found the need to render with the –close SAVE_CHANGES parameter for AfterEffects.
As far as i see this is not yet possible with nexrender.
I could add this single option and create a pull request.
However, I think it might be more useful to extend the cli to forward any such parameter.
This could look like this:
nexrender --aerender-parameter 'close SAVE_CHANGES' --ae 'i 10' job.json
with --ae being a short hand for --aerender-parameter.
Then this kind of issue would be solved for good.
What do you think?

Hey @brassel
Good to hear back from you!
I think you are right with the second assumption. I also catch myself thinking over and over that having a way to directly pass parameters to aerender would be much more beneficial, than just adding more and more custom differently names parameters.
So I think adding a pass option like you've mentioned is a great idea. My only 2 concerns are:

Ability to override parameters passed by nexrender by default (assuming that users that are using custom pass parameters knows what they are doing; that can be much more beneficial to them)
Format, preferably generally used one, for passing parameters, that would allow (1) to be easily achievable.

What do you think about those points?
And finally, the --ae and --aerender-parameter names look good to me.

Hey @inlife, big hello back! :o)
If I understand point 1 correctly, it is about where to put the transfer of the command line settings to the render settings in render.js, maybe? I would put this last as the command line parameters seem to me most specific. And the specific should override the less sepcific. This way any nexrender defaults could be overridden by command line parameters. But maybe I misunderstood the question?
As to point 2, my suggestion would use exactly the format given to aerender. Is that what you meant?

Let me clarify things:

nexrender passes a lot of parameters to the aerender binary, that happens in the tasks/render.js. My point was that, if we provide any additional arguments via the method you suggested, they should override those that are already passed in tasks/render.js.

By format I meant some usual case how it is done. From my experience, I've came to see often something like being used: $ parent -a -b -c -- -childa -childb -childc, where children arguments start after -- sequence, we can follow same Unix (I believe) concept here as well

Does it help with understanding?

Does it help with understanding?

Yes, now I got it! Thanks for clarifying.

if we provide any additional arguments via the method you suggested, they should override those that are already passed in tasks/render.js.

Yes, I also think that this is the best way to go. I have done this in render.js, as you will see in the pull request.

we can follow same Unix (I believe) concept here as well

Yes, I agree. In this case the format is
nexrender --ae 'key value' --ae 'key value'
which would be the usual Unix way to add a parameter with an argument. Following these patterns is also the reason why I suggest to take the -  away for the `key' and combining the flags. For example to have
nexrender --ae 'close SAVE_CHANGES'
instead of
nexrender --ae -close SAVE_CHANGES
which would be very confusing with regard to the Unix pattern as close is not a parameter for nexrender.
As a next step I would prepare the pull request.
Please have a look if it is to your liking.
Cheers!

Pull request has been created.


boards: arm: same70: Add mcuboot flash partitions to dts

Signed-off-by: Jonas Pfaff<EMAIL_ADDRESS>

Do you mind to rebase this?

Rebased. Sorry for the long delay.

@mbolivar can you take a quick look and review this.  Thanks


Example application: joint fit of RV and astrometric data

@dfm
The planet candidate &epsilon Indi A b has a claimed detection in combined RV and astrometric data.  This might be an interesting case to study with exoplanet:
https://arxiv.org/abs/1910.06804
although this star is active:
https://arxiv.org/abs/1803.08163

And also join fit of direct-imaging and astrometric data:
https://arxiv.org/abs/1910.10169


coloring chapters, sections, etc

hello,
is it possible to color referred chapters, sections, etc? for instance, it could be nice if the \refch produces a chapter No in colors

Hello yordiak, thank you for your patience. Yes, what you ask is possible, but you will have to edit the macros in the stles/kaorefs.sty package (or, alternatively, redefine them in the main.tex). The idea is to call \hypersetup just before the chapter number is printed, for instance, if you change
\newcommand{\refch}[1]{\hyperref[ch:#1]{\chaptername\xspace\ref{ch:#1}}}

into
\newcommand{\refch}[1]{\hyperref[ch:#1]{\chaptername\xspace\hypersetup{linkcolor=red}\ref{ch:#1}}}

you'll get something like this:

Sometimes after the number we also print the name of the chapter (e.g. with \nrefch); in those case it will suffice to use \hypersetup a second time after the chapter number:
\newcommand{\nrefch}[1]{\hyperref[ch:#1]{\chaptername\xspace\hypersetup{linkcolor=red}\ref{ch:#1}\hypersetup{linkcolor=black} (\nameref{ch:#1})}}

Of course you can do the same for the other referencing commands.


Theme fonts are not affecting children 'button' nodes

Godot version
4.0.2 stable
System information
Win 10 - Vulcan disabled (not supported)
Issue description
Setting custom fonts for a Theme resource in a parent Control node does not affect Button nodes in it's children. However, Options buttons work just fine.
(I'm really sorry, but I have no clear idea how to export a scene or a project from Godot, and I'm really bad with GitHub, so if there is a problem with the archive in the reproduction project, here's the link to my repo with the same archive: https://github.com/Xerathe/Godot_Theme_Fonts_Bug.git)
Steps to reproduce

Set a control node as the main one
Add a couple of child nodes/scenes (both are of the control type) with buttons
Create a new Theme resource for the parent
Add a custom font to the Theme
The change should be seen in the editor (only Options buttons are affected)

Minimal reproduction project
TEST_Button_Bug.zip

You're setting the default font, with a font already configured for the button, it won't use the default font if one is already configured for those buttons

You're setting the default font, with a font already configured for the button, it won't use the default font if one is already configured for those buttons
You need to set the Button/fonts/font font property, set by set_font("font", "Button", my_font), which I think can also be accessed as teme.Button.fonts.font = my_font but haven't used themes like that much
The reason it applies to OptionButton is that it doesn't have a font configured

You are genious, thank you) All I had to do was just delete that font in the theme editor for the button specifically and it loaded the default font correctly

You probably created the theme and accidentally copied the defaults into your theme

Closing as per the above responses


⚠ Bofrost.at has degraded performance

In acc04cb, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1133 ms

Resolved: Bofrost.at performance has improved in 713b3db.


One physics body shared by multiple sprites

I want to let multiple sprites to share ONE physics body.
But, Phaser.Group does not have that feature.
I think that creating Phaser.Sprite without texture is wrong way.
Thank you.

You can add multiple sprites as children of Phaser.Sprite and apply the body to the parent sprite. Is this what you want?

@Cristy94
Thank you for your reply.
I can resolve my problem by its way.
But, Creating Phaser.Sprite without texture as parent that called "Sprite" I feel bad knowhow and last resort.
If it only way, I have no choice.

@zukkun Currently creating a Sprite (without a texture) is the best way to create a 'full featured game object', including support for collisions.

@pnstickne Thank you for your reply.
I will try create a Sprite (without a texture).
But, I feel a sense of discomfort.
That is referred to as the "drink" the cup that does not contain drink.


Does this actually work?

I haven't been able to get this loader to function. I set it up as described in the docs, require a jade file, and get a parse error with "unexpected token". It seems like webpack is trying to parse the html as javascript. Even the most basic and bare bones setup is giving me this error.
That being said, I did go into the source and log some things out. It is without a doubt compiling the jade and returning the source correctly as a string. It doesn't seem like a bug in the loader, I'm just curious whether it's actually possible to require something that is not javascript and have webpack not crash, which doesn't appear to be the case for me. But of course I might be missing something, if I am please let me know!

I wrote about it #12


Added the Dockerfile in ihr-archieve-website

@romain-fontugne please review this.

for #11

The command line in the readme misses the port redirection (for example -p 80:80).
And also it lacks letsencrypt to do https. I'm not sure how to add this to the image, and if it will really work?

The command line in the readme misses the port redirection (for example -p 80:80). And also it lacks letsencrypt to do https. I'm not sure how to add this to the image, and if it will really work?

So Sorry, This is new to me...I study about it and soon suggest it. Thankss

Hii @romain-fontugne. i learn about it and got many new things..
I published by blog on the same and i drafted it- here is the link-<EMAIL_ADDRESS>and in the 2nd example i took ihr-archievev-website. Please could you look at and provide your views.
and i have to add my IP to the domain. to generate the certificate. Idk i may  be wrong as this is new to me.
I tried to took a domain if failed as because mine ip is not listed in dns.

I updated docker file to use certbot and created nginx.conf. and i automate the process through the help of shellscript. So we have https.
here is blog link-<EMAIL_ADDRESS>if you feel it worth we can continue. Thanks.

OK, I feel that here it is actually easier to manually deploy the server on a VM, no need for a docker image. Let's close this one. Anyways thanks @Srijan-SS02 and @anmode for looking into this, this is good progress too and I'm learning things too! :)


Proposal: Eliminate redundancy between documentation.json and docs/*.json

Right now, for each package there is a documentation.json file and additionally for each module of the package a docs/ModuleName.json file. As far as I can tell, the latter are redundant in terms of information: The content of ModuleName.json is an excerpt of documentation.json (and easily found in there if desired).
Why do the docs/*.json files exist? One reason I can imagine is an attempt at optimization for efficiency: When rendering a module page (rather than the package page), one only reads and parses the information from docs/ModuleName.json rather than the whole documentation.json. Is that the sole reason? If so, it is obsolete. In the course of recent improvements like https://github.com/elm-lang/package.elm-lang.org/pull/60 and https://github.com/elm-lang/package.elm-lang.org/pull/91, it already became necessary for the module page renderer to also read and process the whole documentation.json. In fact, https://github.com/elm-lang/package.elm-lang.org/blob/master/frontend/Page/Module.elm now reads both documentation.json and docs/ModuleName.json. It processes the former for some information, and also extracts information from the latter. But that latter, it could directly take from the former just as well.
Two knock-on benefits from going the route of doing away with docs/ModuleName.json stuff:

Issues like https://github.com/elm-lang/elm-package/issues/153 would be fixed even on old module pages. Because that error with the wrong printing of union types is only present in the docs/ModuleName.json files, not in documentation.json.
Faster rendering of the module pages. Right now, since both documentation.json and docs/ModuleName.json are read, and come back asynchronously, the view function is called twice in main = Signal.map3 view Window.dimensions modulesAndMentionedTypes.signal documentation.signal in https://github.com/elm-lang/package.elm-lang.org/blob/master/frontend/Page/Module.elm, because modulesAndMentionedTypes.signal and documentation.signal fire independently. Getting both the "modules and mentioned types" and the "documentation for the specific module" information from a single read of documentation.json would lead to only one call of the view function.

Am I missing something? Is there an important, still relevant, reason for having the duplication of information between documentation.json and the docs/*.json files?

Seems reasonable. You are correct about the initial reasoning.
I'm working on a revamp of the site right now, so I was thinking about this as well.
I'll share the stuff I'm working on (called the revamp branch) that is moving things to elm-html, the new elm-markdown, and the Elm Architecture. Lots of stuff has yet to be transferred over, but I guess it'd be good to share.

If (and when) you want me to make the changes to avoid creation and use of the docs/*.json files, let me know which branch to target.

It's all on revamp but I'm trying to work on this myself, I've had a lot of days that are like 30% handling issues and it is not good for me. I did two days of no email and felt a lot better than in a while.

I closed because I think I'm gonna do this. Or at least we have had the conversation about whether it's a good idea for not. If I mess it up, let's open another one later.


Rebuild very slow after a datable is assigned to a dataset in the rdl

I wrote this method in a my class;
public void SetDataSource(DataTable TableSource, int DataSetPosition) {
int Counter = 0;
		foreach(fyiReporting.RDL.DataSet D in  Viewer.Report.DataSets) {
			if(Counter == DataSetPosition) {
				D.SetData(TableSource);
				break;
			}
			Counter++;
		}
		//Very Slow
		Viewer.Rebuild();
	}

but even if in the table there are few records the rebuild is very slow.

After many test i have found the problem, but not (for now) the solution.
The problem is that in the report there is defined a sql datasource that have a connection string used to test the report in reportdesigner. this connection sring is invalid in production, even if i passed a datatable with all data, the rebuild seem to try to connect ... if fails connection without any warning. The result is that to print a simple label it takes 20 seconds plus or minus.
NOW i tried to eliminate brutally the connection string ... but the report emit error. Any Suggestion to avoid the connection on rebuild() ?

After other test. A brutal solution is setting the flag shared datasource reference and leave blank the field. Isn't elegant. So my question is there is a way to programatically do this ?

Not sure I fully understand the issue.  But what I do, is I dynamically
pass the connection string in via a report variable.  This allows me to use
one connection string for testing and one for production; both stored in
the web.config.
Documentation is here:
https://github.com/majorsilence/My-FyiReporting/wiki/Set-Connection-String---Runtime
The Kernel
On Wed, Aug 29, 2018 at 3:35 PM EmanueleBonin<EMAIL_ADDRESS>wrote:

After other test. A brutal solution is setting the flag shared datasource
reference and leave blank the field. Isn't elegant. So my question is there
is a way to programatically do this ?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/majorsilence/My-FyiReporting/issues/183#issuecomment-417077954,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF32L6soRCyoeiUks53nxoeRm2wb5e9Kks5uVu0CgaJpZM4WIPZk
.

First of all thanks for your suggestion but in my tests i tried to eliminate the connection string (in production i doesn't need it) but this emit error during printing. seem that the schema was deleted. ("error field is not defined" ... or something similar ... i don't remember). But if i ONLY set the check "Shared datasource definition" in my datasource (that was a sql connection) all things worked properly.


Fork dialogs with goals and free up movement - CH4

Forked dialogs with goals, with some exceptions, most notably the part where we have a player press some key - since we have the new panel that shows info about your actual hotkey, it seemed confusing to show it at the same time as the dialog, and both the show and hide logic for the panel are inside a single step

Free up movement except in the case when player picks up the dust; figured that's easier right now than making sure Riki is in dust range, although this can be changed later if we have time, but pretty low priority

Clear green markers for wards in onStop in the Wards section, similar to how the green markers for scans in the Opening section are cleared

Play scan failed dialogue only for the second scan target location

Todo:

Maybe use our orange arrow particle instead of the default green ones for the wards and scan goals

Also, it won't let me review it because that's technically not a line that changed, but Kunkka's having the camera locked on him is weird when you have free movement. It made sense because you couldn't move, but now that you can, it just feels forced - like you should be able to move it but can't. Please pan to Kunkka instead of setting the camera target on it, then release the camera.

Also, it won't let me review it because that's technically not a line that changed, but Kunkka's having the camera locked on him is weird when you have free movement. It made sense because you couldn't move, but now that you can, it just feels forced - like you should be able to move it but can't. Please pan to Kunkka instead of setting the camera target on it, then release the camera.

Changing it now so we use pans except for the initial sequence when they just spawn in - seems better to lock the camera on kunkkka/kotl during the time they are walking towards you, imo


Update ZooKeeper to 3.6.2 and Curator to 5.1.0

Motivation
Upgrade to latest stable ZK version 3.6.2. The new minor versions brings several advantages:
Performance improvements (eg: tuning group commit on txn log)
Prometheus based metrics (so that we can get rid of AspectJ hacky way to instrument ZK)
New features like persistent recursive watches which would greatly simplify the logic to handle metadata cache invalidations.
The possibility of rollback to previous version has also been validated.
Modifications

Update ZooKeeper to 3.6.2
Updated Apache Curator to 5.1.0 (that supports ZK 3.6.x), Curator was implicitly imported by BookKeeper Storage Service

Verifying this change

This change is already covered by existing tests, such as (please describe tests).
Test manually a Pulsar service and Pulsar Standalone
Test ZooKeeper metrics

Problems
Unfortunately we cannot upgrade Curator because there is an error with "pulsar standalone":
Basically we have to upgrade ZooKeeper and Curator on BookKeeper before doing this change here
09:40:36.781 [main] ERROR org.apache.bookkeeper.common.component.AbstractLifecycleComponent - Failed to start Component: zk-storage-container-manager
java.lang.NoSuchMethodError: 'org.apache.curator.framework.listen.ListenerContainer org.apache.curator.framework.recipes.cache.NodeCache.getListenable()'
	at org.apache.bookkeeper.stream.storage.impl.cluster.ZkClusterMetadataStore.watchClusterAssignmentData(ZkClusterMetadataStore.java:169) ~[org.apache.bookkeeper-stream-storage-service-impl-4.12.0.jar:4.12.0]
	at org.apache.bookkeeper.stream.storage.impl.sc.ZkStorageContainerManager.doStart(ZkStorageContainerManager.java:105) ~[org.apache.bookkeeper-stream-storage-service-impl-4.12.0.jar:4.12.0]
	at org.apache.bookkeeper.common.component.AbstractLifecycleComponent.start(AbstractLifecycleComponent.java:83) [org.apache.bookkeeper-bookkeeper-common-4.12.0.jar:4.12.0]
	at org.apache.bookkeeper.stream.storage.impl.StorageContainerStoreImpl.doStart(StorageContainerStoreImpl.java:97) [org.apache.bookkeeper-stream-storage-service-impl-4.12.0.jar:4.12.0]
	at org.apache.bookkeeper.common.component.AbstractLifecycleComponent.start(AbstractLifecycleComponent.java:83) [org.apache.bookkeeper-bookkeeper-common-4.12.0.jar:4.12.0]
	at org.apache.bookkeeper.stream.server.service.StorageService.doStart(StorageService.java:47) [org.apache.bookkeeper-stream-storage-server-4.12.0.jar:4.12.0]
	at org.apache.bookkeeper.common.component.AbstractLifecycleComponent.start(AbstractLifecycleComponent.java:83) [org.apache.bookkeeper-bookkeeper-common-4.12.0.jar:4.12.0]
	at org.apache.bookkeeper.common.component.LifecycleComponentStack.lambda$start$4(LifecycleComponentStack.java:144) [org.apache.bookkeeper-bookkeeper-common-4.12.0.jar:4.12.0]
	at com.google.common.collect.ImmutableList.forEach(ImmutableList.java:405) [com.google.guava-guava-30.0-jre.jar:?]
	at org.apache.bookkeeper.common.component.LifecycleComponentStack.start(LifecycleComponentStack.java:144) [org.apache.bookkeeper-bookkeeper-common-4.12.0.jar:4.12.0]
	at org.apache.bookkeeper.stream.server.StreamStorageLifecycleComponent.doStart(StreamStorageLifecycleComponent.java:51) [org.apache.bookkeeper-stream-storage-server-4.12.0.jar:4.12.0]
	at org.apache.bookkeeper.common.component.AbstractLifecycleComponent.start(AbstractLifecycleComponent.java:83) [org.apache.bookkeeper-bookkeeper-common-4.12.0.jar:4.12.0]
	at org.apache.pulsar.zookeeper.LocalBookkeeperEnsemble.runStreamStorage(LocalBookkeeperEnsemble.java:350) [org.apache.pulsar-pulsar-zookeeper-utils-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
	at org.apache.pulsar.zookeeper.LocalBookkeeperEnsemble.startStandalone(LocalBookkeeperEnsemble.java:432) [org.apache.pulsar-pulsar-zookeeper-utils-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
	at org.apache.pulsar.PulsarStandalone.start(PulsarStandalone.java:258) [org.apache.pulsar-pulsar-broker-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
	at org.apache.pulsar.PulsarStandaloneStarter.main(PulsarStandaloneStarter.java:115) [org.apache.pulsar-pulsar-broker-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
09:40:36.782 [main] ERROR org.apache.bookkeeper.common.component.AbstractLifecycleComponent - Failed to start Component: range-service
java.lang.NoSuchMethodError: 'org.apache.curator.framework.listen.ListenerContainer org.apache.curator.framework.recipes.cache.NodeCache.getListenable()'
	at org.apache.bookkeeper.stream.storage.impl.cluster.ZkClusterMetadataStore.watchClusterAssignmentData(ZkClusterMetadataStore.java:169) ~[org.apache.bookkeeper-stream-storage-service-impl-4.12.0.jar:4.12.0]
	at org.apache.bookkeeper.stream.storage.impl.sc.ZkStorageContainerManager.doStart(ZkStorageContainerManager.java:105) ~[org.apache.bookkeeper-stream-storage-service-impl-4.12.0.jar:4.12.0]

@sijie @jiazhai
This is the patch on BookKeeper, we could make a 4.12.1 release in the future
https://github.com/apache/bookkeeper/pull/2491
there is no hurry at all

This patch is waiting for BK 4.12.1 release, a VOTE is pending on BK community

This patch is waiting for BK 4.12.1 release, a VOTE is pending on BK community

BK vote completed
now this patch depends on the BK upgrade to 4.12.1
https://github.com/apache/pulsar/pull/9019
@codelipenghui PTAL

BK vote completed
now this patch depends on the BK upgrade to 4.12.1
https://github.com/apache/pulsar/pull/9019
@codelipenghui PTAL

@merlimat @codelipenghui this patch is good to go as soon as CI passes

@merlimat @codelipenghui this patch is good to go as soon as CI passes

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

thank you @merlimat for your fixes.


[BUG]

OpenIM Server Version
3.5.3
Operating System and CPU Architecture
Linux (AMD)
Deployment Method
Docker Deployment
Bug Description and Steps to Reproduce
在解除了好友关系后，然后在发送好友申请，接收方有收到好友申请同意的状态变化，但是发送方没有收到发送的状态变化，只有在浏览器无痕模式下才能获取到发送方的好友申请状态变化。
Screenshots Link
No response

you can update the sdk and server to the latest version and try again.

you can update the sdk and server to the latest version and try again.

server版本是v3.5 做了很多业务，升级有比较大的问题。请问这个问题能否在3.5版本的sdk 做个修复。

Due to limited team resources, currently only version v3.8 is supported and maintained. Moreover, version 3.8 has fixed a large number of issues and been optimized. It is more recommended to upgrade and use it.

you can update the sdk and server to the latest version and try again.
主要是后端服务牵扯太多开发和业务，如果调整后端可能会有非常大的工作量调整。