feat(Mathlib/LinearAlgebra/DirectSum/Finsupp): tensor products of finsupp sums

Modules

TensorProduct.finsuppLeft, the tensor product of ι →₀ M and N is linearly equivalent to ι →₀ M ⊗[R] N

TensorProduct.finsuppScalarLeft, the tensor product of ι →₀ R and N is linearly equivalent to ι →₀ N

TensorProduct.finsuppRight, the tensor product of M and ι →₀ N is linearly equivalent to ι →₀ M ⊗[R] N

TensorProduct.finsuppLeft', if M is an S-module, then the tensor product of ι →₀ M and N is S-linearly equivalent to ι →₀ M ⊗[R] N

This is the first part of PR #10824 which contains three applications of these functions to monoid algebras, polynomials and multivariate polynomials.
It has been split because this part is reasonably sound, while the three other files are more like propositions.

Thank you very much! It looks good for me.

!bench

Thanks for the shorter versions, I'll use them, and I'm OK to make the arguments of finsuppLeft explicit, in accordance with what is done for docs#TensorProduct.directSumLeft

Can you please fix the compile errors (which probably results from the implicitness changes)? Thanks!

I had not noticed that there were errors left, sorry. I make the necessary adjustments at once.

Thanks 🎉
maintainer merge

Thanks!
bors merge


Create HowTo page on Wiki

We can write following how-to documents:

How to write plugins?

ruby input plugin
ruby output plugin
java input plugin
java output plugin
java file input plugin
java file output plugin
java parser plugin
java formatter plugin
java encoder plugin
java decoder plugin

How to read and write local CSV files?
How to read and write files on S3?

#161 created documents for plugin development.


Fix Dart API generation bugs; Add ability to generate API for path parameters

Fix Dart API generation bugs; Add ability to generate API for path parameters
Suppose I have a following API definition, filename is greet.api:
service greet-api {
	@handler GreetHandler
	get /from/:name(GreetRequest) returns (GreetResponse)
}

Bug 1: Dart import path does not match actual dart file path.
Actual dart file path is ../data/greet-api.dart
Generated import path is import '../data/greet.dart'. This is WRONG because it took the greet.api file name by mistake.
This bug was solved by replacing the import path to the actual file path. Now it looks like this:
import '../data/greet-api.dart'
Bug 2: Generated API function name is not a valid function name
Generated dart function name is:
Future apiFrom:name(
    {Function(GreetResponse)? ok,
    Function(String)? fail,
    Function? eventually}) async {
  await apiGet('/from/:name',
  	 ok: (data) {
    if (ok != null) ok(GreetResponse.fromJson(data));
  }, fail: fail, eventually: eventually);
}

The function name apiFrom:name is not a valid function name, which results a compilation error.
This bug was solved by replacing the function to the actual handler name, which is Greet by removing the suffix Handler from GreetHandler in this case. Now it looks like this:
Future Greet(
    {Function(GreetResponse)? ok,
    Function(String)? fail,
    Function? eventually}) async {
  await apiGet('/from/:name',
  	 ok: (data) {
    if (ok != null) ok(GreetResponse.fromJson(data));
  }, fail: fail, eventually: eventually);
}

Bug 3: It does not support path tag generation
The following code is not correct, because the path param :name should be replace by a real parameter value, whereas it isn't.
Future Greet(
    {Function(GreetResponse)? ok,
    Function(String)? fail,
    Function? eventually}) async {
  await apiGet('/from/:name',
  	 ok: (data) {
    if (ok != null) ok(GreetResponse.fromJson(data));
  }, fail: fail, eventually: eventually);
}

After adding support to generate API for path parameters. API users can now pass in the real parameter value for name. Now it looks like this:
Future Greet(
    String name,
    {Function(GreetResponse)? ok,
    Function(String)? fail,
    Function? eventually}) async {
  await apiGet("/from/${name}",
  	 ok: (data) {
    if (ok != null) ok(GreetResponse.fromJson(data));
  }, fail: fail, eventually: eventually);
}

@kevwan Please look at this PR, in which a couple of critical bugs were solved.


Make sure we grab Twitter photos in create_resized_images_for_voters function

Upgrade image/controllers.py create_resized_images_for_voters. If a voter is linked to a Twitter account in the "TwitterLinkToVoter" table, and we don't have Twitter photos for this voter yet, we should reach out to the Twitter API and cache the images in our Images table.

Great work @jainanisha90!


unable to resolve module 'react-native'

Is this a bug report?
yes

Have you read the Contributing Guidelines?
yes
Environment

Steps to Reproduce

(Write your steps here:)

I run the project
I followed the git issues link on the screen I had
run the project again

Expected Behavior

I expected it to run smoothly
Actual Behavior

Reproducible Demo

(Paste the link to an example project and exact instructions to reproduce the issue.)

This message was created automatically by mail delivery software.
A message that you sent could not be delivered to one or more of its
recipients. This is a temporary error. The following address(es) deferred:
<EMAIL_ADDRESS>Domain salmanwaheed.info has exceeded the max emails per hour (157/150 (104%)) allowed.  Message will be reattempted later
------- This is a copy of the message, including all the headers. ------
Received: from o3.sgmail.github.com ([<IP_ADDRESS>]:19281)
by box1177.bluehost.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128)
(Exim 4.89_1)
(envelope-from<EMAIL_ADDRESS>id 1epQUo-003Imu-2s
for<EMAIL_ADDRESS>Fri, 23 Feb 2018 20:27:36 -0700
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com;
h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe;
s=s20150108; bh=cpySkZXYP/5jAxLNJhJr/GMbogg=; b=ka24qB9uBIhGZ985
FHdBZaQ6yDhR/P1Kr0grzidDu2mOyUk8GCGIcNLP5nuGnVU3wDRy50tDVUuY0CT4
kprwTwHlSYy6IB6eL5omMEPIJoFS0wkQofSg7/d/B4VSpL0Sa25TU4cFA3aEMsc2
dtC5fT3svgG6gNlp38Wdgxfuh+c=
Received: by filter0526p1las1.sendgrid.net with SMTP id filter0526p1las1-22489-5A90DB98-F
2018-02-24 03:27:21.063056554 +0000 UTC
Received: from github-smtp2b-ext-cp1-prd.iad.github.net (github-smtp2b-ext-cp1-prd.iad.github.net [<IP_ADDRESS>])
by ismtpd0005p1iad1.sendgrid.net (SG) with ESMTP id espHqRkjQNmVmZ1p1p6a9Q
for<EMAIL_ADDRESS>Sat, 24 Feb 2018 03:27:21.117 +0000 (UTC)
Date: Sat, 24 Feb 2018 03:27:21 +0000 (UTC)
From: React Native Bot<EMAIL_ADDRESS>Reply-To: facebook/react-native<EMAIL_ADDRESS>To: facebook/react-native<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Message-ID<EMAIL_ADDRESS>In-Reply-To<EMAIL_ADDRESS>References<EMAIL_ADDRESS>Subject: Re: [facebook/react-native] unable to resolve module 'react-native'
(#17761)
Mime-Version: 1.0
Content-Type: multipart/alternative;
boundary="--==_mimepart_5a90da918e661_79153fde246eef282604b8";
charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: react-native-bot
X-GitHub-Recipient: salmanwaheed
X-GitHub-Reason: subscribed
List-ID: facebook/react-native <react-native.facebook.github.com>
List-Archive: https://github.com/facebook/react-native
List-Post<EMAIL_ADDRESS>List-Unsubscribe<EMAIL_ADDRESS>https://github.com/notifications/unsubscribe/AO8bOEzIQpMMpLatjvvHXPCsNtm3rUSyks5tX4CRgaJpZM4RvXFJ
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address<EMAIL_ADDRESS>X-SG-EID: 92ws1MVnlto3blxqXlf5goB0ee0kdDGWR6vcWx8d64+xIhseZYnOSN5xYNdGPNe5CnudumkTQItrDL
AnKUhyhjlWhdO4wAZQseNDgdrHmqRSDjShDf1NP0lvsazQUrbaIiQE1UA4hkFzSTlQQrbQadYAL0Pq
ogyiBC2b6DP95zRMLeUXPde99Ja8/fQqRcHfbwg1m1QYx6rnCCjan+TaeGY/p6Q7cFX0DcMw4+iGOd
Q=
X-Spam-Status: No, score=0.8
X-Spam-Score: 8
X-Spam-Bar: /
X-Ham-Report: Spam detection software, running on the system "box1177.bluehost.com",
has NOT identified this incoming email as spam.  The original
message has been attached to this so you can view it or label
similar future email.  If you have any questions, see
root@localhost for details.
Content preview:  Closed #17761. -- You are receiving this because you are subscribed
to this thread. Reply to this email directly or view it on GitHub: https://github.com/facebook/react-native/issues/17761#event-1490267582
[...]
Content analysis details:   (0.8 points, 5.0 required)
pts rule name              description

0.0 URIBL_BLOCKED          ADMINISTRATOR NOTICE: The query to URIBL was blocked.
See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
for more information.
[URIs: github.com]
-0.5 SPF_PASS               SPF: sender matches SPF record
-0.0 T_RP_MATCHES_RCVD      Envelope sender domain matches handover relay
domain
1.3 HTML_IMAGE_ONLY_24     BODY: HTML: images with 2000-2400 bytes of words
0.0 HTML_MESSAGE           BODY: HTML included in message
2.5 DCC_CHECK              No description available.
-0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from author's
domain
-0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily valid
-2.3 AWL                    AWL: Adjusted score from AWL reputation of From: address
X-Spam-Flag: NO
----==_mimepart_5a90da918e661_79153fde246eef282604b8
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
Closed #17761.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/facebook/react-native/issues/17761#event-1490267582
----==_mimepart_5a90da918e661_79153fde246eef282604b8
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: 7bit
Closed #17761.
—You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or mute the thread.

----==_mimepart_5a90da918e661_79153fde246eef282604b8--

In my case, this error was occurred due to an import of 'dns' in a js file.

How can i do that on windows?

Make sure you download the release matching with your Unity version.


pipelined mode for WP8 benchmark

Add the pipelined mode to the WP8 benchmark.
This is a bit awkward because to work with the real implementation it requires the duplicate action, which isn't implemented yet. So we can't get performance results for this yet.
I've tested the pipelined mode with the model implementation and that works fine, but I don't want to include that in the benchmark code because it pulls in too many other dependencies.
So to test the pipelined (and sequential) versions I've included a dynamic check that the results are the same as a simple pure reference function. This is enabled by --check. Hopefully the presence of the observation/output doesn't have much of a performance impact when it is disabled. Casual benchmark runs indicated the cost was less than the run-to-run variation.
The PR starts with a bunch of tidying up, including the patch from #271.

I'll do the syncing of the rocksdb benchmark as a follow-up.


Add shellcheck to ci

Add shellcheck to ci and fix some scripts that fail linting
This PR adds the framework for running shellcheck in ci
Im not sure if where i have hooked it in is the best place, apart from anything shellcheck does not give very reliable fixes - so it does not provide a patch to remedy as other code formatting ci does.
I have fixed some of the low-hanging fruit, but figured that it would probably be a good idea to fix other parts in separate PRs as they touch other parts of the code base
Signed-off-by: Ryan Northey<EMAIL_ADDRESS>Commit Message: Add shellcheck to ci
Additional Description:
Risk Level: low/medium
Testing:
Docs Changes:
Release Notes:
[Optional Runtime guard:]
[Optional Fixes #Issue] Partial fix for #7793
[Optional Deprecated:]

wierdly, shellcheck is failing a script that is only present in master, and not in this PR
ive disabled it for now, but im wondering why the script appeared and was being checked.

wierdly, shellcheck is failing a script that is only present in master, and not in this PR
ive disabled it for now, but im wondering why the script appeared and was being checked.

This is expected, Azure pipelines (or GitHub Actions) runs CI on PR merge commit instead of PR head.


Pass inputref to internal ref in Checkbox and other control element components

Summary
The Button component passes the inputref property down to its internal button element.
(See here: https://github.com/IBM/carbon-components-react/blob/master/src/components/Button/Button.js#L51)
This allows users to send in a ref and then use it (for focusing, etc.).
It would be useful if other control elements also did the same thing. (The component that we're currently working with is Checkbox, but ideally this gets added everywhere applicable.)
Justification
We'd like to be able to programmatically focus on these control elements within Watson Compare & Comply Tooling UI.
Specific timeline issues / requests
As soon as possible, these changes are related to our going GA (accessibility).

Hi @ColbyJohnIBM thank you for reporting! Do you want to send us a PR? If so, great if React latest ref API can be used there. If not, you may want to do your own checkbox implementation for now, given your presumable time constraints.

Does it really make sense to close "stale" issues? Won't that just hide issues that should be eventually fixed?
I'm fine if a person on the dev team decides that this issue (or any issue) is not worth the effort to fix, but it doesn't seem like the default case should be to close an issue just because no one has addressed it in a while.

Addressed by #1859. @ColbyJohnIBM The stalebot thing is similar to other stalebots out there, closing ones with inactivity. As you may have noticed, adding an activity to the issue prevents the issue from being closed. Even if it's closed, a new issue can be created for continued discussion. But good to continue the discussion, probably at #2289 or a new issue.


Use co-mocha for async tests

This improves error handling within tests so that they shouldn't time out when an assertion fails from within a callback. Server instances created within tests are also closed in finally blocks to avoid making Mocha hanging at the end.
This also greatly improves the performance of bulk generation of objects by allowing 100 concurrent uploads at a time. The indefinite timeout on these long-running tests has been removed.
edit: wooo new record of only 3:28 for total test runtime on Travis!

Cool, I'll merge now since it looks like we'll need to be adding some more tests pretty soon.


Create spec for shift up

Summary
This pull request creates a spec to tests shift+up keyboard shortcut focus on RHS.
Ticket Link
Fixes https://github.com/mattermost/mattermost-server/issues/18808
Related Pull Requests
Release Note

Hello @berkeka,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.


New version: GEMPIC v0.3.3

Registering package: GEMPIC
Repository: https://github.com/JuliaVlasov/GEMPIC.jl
Created by: @pnavaro
Version: v0.3.3
Commit: 842b22768b802bb18b4d5429a922a9d563835cb0
Reviewed by: @pnavaro
Reference: https://github.com/JuliaVlasov/GEMPIC.jl/issues/8#issuecomment-615832682

OK

Just wanted to add that a new version of GEMPIC has successfully been registered via #13248.
This PR can safely be closed. Thanks!


How to embed this into StyleGAN-ada?

Hi, thank you for your sharing. May I know how can I embed this encoder into a stylegan-ada?

Hi @JJack27!
Can you elaborate on what you are interested in?
Ill try to give a general answer:

If you have a pretrained model from the StyleGAN-ADA repositories of NVIDIA, you can check out rosinality's stylegan2-pytorch repository for a conversion script which will create a checkpoint suitable for use in this repo.
If you wish to integrate any of NVIDIAs repositories, you should add the files defining the stylegan generator, and replace all the calls to rosinality's stlyegan2 generator in this repo with the appropriate API of the NVIDIA repo.

Best,
Omer

Hi @omertov !
Thank you for you fast reply. I'm trying for the option 2. May I know where did you call the styleGAN2 the most? So that I can investigate and analyze if it's possible to replace it with stylegan-ada.
Regards,
Jack


Specify the final position of all animations

I had a bug where some of the animations slid to the left when they finished their animations. By specifying the final position of the animation I removed this bug.
Hope it helps

:+1:


Fixed 4115 achievement issue

Description (required)
Fixes #4115
What changes did you make and why?

Achievement fragment now looks like the screenshot attached below.
There was a function HideLayouts() which was hiding all the layouts till the fetching of all data is complete.
when their visibility was again set to VISIBLE it was not working properly because, in HideLayouts() we were hiding complete relative layouts and according to android documentation hiding complete layouts cannot be undo after loading activity(or after execution of onCreate function, hideLayout() was called inside onCreate and commands for showing layout were called outside onCreate thats why this problem was occuring).
as they all are linked using bindview like "RelativeLayout layoutImageUploaded;" , using layoutImageUploaded.setVisibility(View.INVISIBLE); makes them invisible but when we try to use visible it doesn't work.
I have currently deleted the HideLayouts() funtion and removed it from places it was called.
It is now working all fine according to me.
If you want me to keep it like it was earlier and find a way to display layout after fetching results I could try that : )

Tests performed (required)
Tested {build variant, e.g. ProdDebug} on {Realme 3 pro} with API level {29}.
Screenshots (for UI changes only)

@misaochan @sivaraam Please review this
Need help? See https://support.google.com/android/answer/9075928

Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.

Codecov Report

Merging #4138 (161f8c6) into master (5bdb21c) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4138      +/-   ##
============================================
+ Coverage     10.58%   10.59%   +0.01%
  Complexity      476      476
============================================
  Files           343      343
  Lines         12908    12894      -14
  Branches       1005     1005
============================================
  Hits           1366     1366
+ Misses        11474    11460      -14
  Partials         68       68

Impacted Files
Coverage Δ
Complexity Δ

...ons/profile/achievements/AchievementsFragment.java
0.00% <ø> (ø)
0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bdb21c...161f8c6. Read the comment docs.

Thanks for the investigation @Saral-code ! :) I think it is OK to solve it in this method for now. If any issues crop up from that, we will create a new issue.


Add support for 3.12

Python 3.12 is now out, we should add support for it to keep up to date.
Depends on p4p compatibility https://github.com/mdavidsaver/p4p/pull/126
Acceptance Criteria

Non-test builds are unpinned (e.g. reverse https://github.com/DiamondLightSource/dodal/pull/221/commits/b980f9bf3df0e0042a650dd9d46540d12f7589ab)
CI runs tests under 3.12
CI all still passes
Documentation is updated to reflect we support 3.12

update:
original p4p PR was closed.
This PR is where it seems the cutting edge is
https://github.com/mdavidsaver/p4p/pull/141

latest main branch seems to support 3.12 https://github.com/DiamondLightSource/dodal/blob/main/pyproject.toml
can we close this @DominicOram ?

Not until CI is in properly https://github.com/DiamondLightSource/dodal/blob/46132f0e066debaf906c1a80dcefca175b3f5c01/.github/workflows/ci.yml#L24

ah right I forgot about this


MoorDyn v2 updates to OpenFAST

This is a draft pull request.
These pull requests should be merged first:

[ ] #664

Feature or improvement description
This brings in all the updates for MDv2, including new object types and capabilities for active tensioning, linearization, buoyancy cans, and wave kinematics. Capabilities for wave kinematics are commented out (in MD and in HD), to be replaced with future wave kinematics grid approach.
Impacted areas of the software
MoorDyn significantly changed. Glue code changed for additional fields in MoorDyn input/output meshes. FAST_Lin changed to support MoorDyn linearization.
Input file changes
MoorDyn input file format is changed. Will be documented on MoorDyn's readthedocs.
Test results, if applicable
New buoyancy can and wave kinematics capabilities compared well with OrcaFlex simulations. MD Linearization still needs to be tested and debugged.
Items to complete:

[ ] update regression test input files
[ ] rerun MD related regression tests
[ ] documentation updates?
[ ] Single precision compilation working

Closing this since it will be replaced with a PR for MDv2-farm.


Number of pumps needed for fluids when set to belt display.

Suggestion
Have it so that when showing the amount of belts needed for items, also show the amount of pumps that would be needed to move the fluids between pipe extents.

That is not a bad idea actually, thanks!

I implemented this for the next release, thanks again


Add Windows and Mac to CI tests

r? @jyn514

If you're still interested in working on this, I think you could make it work without createuser and createdb as long as you have super user privileges:
sudo -u postgres psql -c "CREATE USER cratesfyi WITH PASSWORD 'password';"
sudo -u postgres psql -c "CREATE DATABASE cratesfyi OWNER cratesfyi;"

Not sure how to get those privileges without sudo, I know it doesn't exist on Windows and not sure about MacOS.


Implement execute query for selected text in query editor

Like PgAdmin Allows

Hi @palmerj ,
Thanks for your feedback. We are implementing this feature and will deliver it on next release, 2.6.0, which will be published soon.
We will keep this issue open until there.
Regards,
William

Duplicate of #396 .

Hi @palmerj ,
We just released OmniDB 2.6.0 with this implementation. Now you can select a portion of the text in the Query Tab and execute it:

The shortcut to execute is the same to execute the entire text or only a portion of it. The default is Ctrl-Q, but version 2.6.0 also allows you to define your own shortcuts:

We would like to know your feedback on this, please. So I'm keeping this issue open for now.
Regards,
William Ivanski

Hi,
It's been a while, so we are closing this issue now. Feel free to comment here or open a new issue anytime!
Thanks and regards,
William Ivanski


OTP 21 compatibility, or get_stacktrace workaround

This PR adds workaround for OTP 21 deprecation of get_stackgrace function.
Also, Travis CI target of 21.0-rc1 is added.
(rc2 request: https://github.com/travis-ci/travis-ci/issues/9685 )
This PR is tested with:

OTP 21.0-rc2
OTP 21.0-rc1
OTP 20.3.4
OTP 19.3

The test script is : https://gist.github.com/shino/d14d26ed42bfe4aab81361b338780c3b

Enabled OTP 21 rc2 at Travis CI.

PIng?

@andreineculau Thanks for merging and updating travis configuration!
Just a question, is there a plan for the next tag/release?

@shino https://github.com/for-GET/jesse/releases/tag/1.5.1

@andreineculau Thanks a lot!!


Packs that require OF doesnt work

So idk if i understood how the mods work but i think that packs that require OF have to work without it if you have the mod on. So there is a durability pack that makes it so when ur armor piece is low it turns red and when it even more low it turns dark red and it requires OF but it doesnt when i dont have OF and the CIT mod on

The pack needs to use CIT, as this is what CIT Resewn adds. If the pack is cit it should work and if it doesnt you need to open an issue with both the logs and the pack in question.


Audio focus cherry pick

Cherry-pick of:
https://github.com/scheib/chromium/commit/3d020b1e04e93bbd318105276a89dd3aa4af1a27
*Solves the issue with Audio-focus.
Current version of crosswalk-chromium does not have these changes, part of the changes done to MediaPlayerListener were same/similar to what I had done earlier, this would serve as more complete implementation.
Unit tests done:

Audio plays fine on Mobile/Leanback/Amazon devices
Takes Focus from Audio already playing in background
On pausing / resuming video in our app, doest not give away Audio-focus

This is a fairly long set of patches, and the final diff is huge. Since this is already present in Chromium 45, I think it makes sense to just wait until we roll 45 into Crosswalk master (should be really soon).


added method-style rule for eslint

Closes: RHOAIENG-4721
Description

Set this eslint rule: "@typescript-eslint/method-signature-style": "error" to have consistency for interface functions. The standard we're trying to achieve is func: (arg: type) => type;
details: https://issues.redhat.com/browse/RHOAIENG-4721
How Has This Been Tested?

npm run test:lint
Request review criteria:

Self checklist (all need to be checked):

[x] The developer has manually tested the changes and verified that the changes work
[x] Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).

After the PR is posted & before it merges:

[ ] The developer has tested their solution on a cluster by using the image produced by the PR to main

/lgtm
/approve

Sorry, resolving merge conflicts

/lgtm


VScodeVim:  When type Chinese character, the editor appear blinking

Describe the bug
A clear and concise description of what the bug is.
When I switch to Chinese input method and start inputing the character, The Chinese character is blinking.
To Reproduce
Just enter the insert mode, and switch the input method to Chinese, then type in some words.
Expected behavior
the normal visual performance
Screenshots

Environment (please complete the following information):

Extension (VsCodeVim) version: v1.22.2
VSCode version: 1.67.2 (Universal)
OS: Darwin arm64 21.4.0

Additional context
the english input method works normally

When I uninstall the Vscode Vim extention, It's back to normal

jupyternotebook appear the same issue

I test vscode 1.54.3 + vim 1.21.5, it's ok.
Version: 1.54.3
Commit: 2b9aebd5354a3629c3aba0a5f5df49f43d6689f8
Date: 2021-03-15T11:00:52.911Z (1 yr ago)
Electron: 11.3.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 21.5.0
But 1.66+ this bug occurred.
Now I'm using the old version vscode, I hope this bug would be fixed soon and we who like vim could enjoy the newest version vscode as soon as possible :)

version: 1.63.2 is OK, but 1.64.2 this bug occurred

https://github.com/microsoft/vscode/issues/154935
https://github.com/VSCodeVim/Vim/issues/7496

So since this is something that used to work but no longer is this sounds like a perfect use case for git bisect.
Step 1: Verify that the issue occurs with the compiled development version in this repository.
Step 2: git bisect start
Step 3: git bisect good 1.63.2
Step 4: git bisect bad 1.64.2
Step 5...: investigate

Hi thank you for filing this issue. This issue should be fixed with the new experimental setting editor.experimentalEditContextEnabled which will be made available in the next Insiders release. This issue will be closed.


Checking for banned dependencies is incorrect

Checking for banned dependencies is incorrect.
As I understand currently it searches for banned dependencies as keywords in package.json. It should look what is under dependencies instead, because project name, other dependencies or scripts could have banned dependency name inside it.
For example problem that I got was it found banned dependency 'eunha' inside my script command
vitest --dangerouslyIgnoreUnhandledErrors

This is indeed a valid concern, but is not an issue with the CLI specifically. Can you please create a bug/feature request in Canny instead https://railway.canny.io/feature-requests


when the code-server killed or has error, the website has no attentions

code-server version:
OS Version:
version: all
os version: mac os, linux

Description

when the code-server was killed ,the websites at the front not work without any attentions
Steps to Reproduce

step 1 :start the code-server

step 2: open the code-server website
step 3: kill the code-server
step 4: create file or do something at the website, not work and no attentions

This is intended by design. Again, VS Code Web is in its early days so there's no indication that it's offline. Closing as upstream issue.

1.39.1 has an indicator for this so we just need to update. Also see https://github.com/cdr/code-server/issues/1046 since it's essentially the same thing.


Removes unnecessary scrollbars from homepage

Fixes Issue

Closes #1415
Changes proposed

Removes those unwanted scrollbars from the homepage for LinkFree. Both horizontal and vertical scrollbars.

Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

Screenshots

Vertical scroll bar removed:

Horizontal scroll bar removed:

Can someone please review this pull request?

I resolved the conflicts! Hope it's better now😄

It was my pleasure to contribute 😄


Replace sevenzipjbinding with Apache commons-compress

Apparently Apache commons-compress supports 7Zip compression, possibly with a dependency on xz as well.
sevenzipjbinding is not thread/process safe

Codecov Report

Merging #49 (0a0bb45) into master (1f9c528) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #49   +/-   ##
=======================================
  Coverage   29.92%   29.92%
=======================================
  Files          61       61
  Lines       11191    11191
  Branches      146      146
=======================================
  Hits         3349     3349
  Misses       7696     7696
  Partials      146      146

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f9c528...0a0bb45. Read the comment docs.

Until commons-compress supports multi input/output stream coders this won't work https://issues.apache.org/jira/browse/COMPRESS-431


Added the ability to keep n% of the final image transparent

Thanks for these!  I will review them at some point (want to compile & test them locally before merging) but have been having a fairly hectic time at work lately and haven't gotten to it yet.


Add ResetFailureCountOnServiceRestart

Issue: https://github.com/rancher/rancher/issues/42458, RFC-13
This PR adds the ResetFailureCountOnStartup field to the OneTimeInstruction struct. If this field is set to true, during the initial force application of the one-time instruction set  the plans failure-count and applied-checksum fields will be reset. This ensures that the max-failures field is always respected, even if the plan had previously succeeded when executed by a prior instance of the system-agent. Due to the fact that the failure-count and applied-checksum fields are stored at the top level (and not as an attribute of the plan key) this will occur if any of the one time instructions set ResetFailureCountOnStartup to true.

After discussing this with @Oats87 this PR has been updated to move the ResetFailureCountOnStartup field from the OneTimeInstruction struct to the Plan struct


Not Scrolling in LoginActivity

In landscape mode, it is not scrolling.
Improvement: Make ScrollView as parent in activity_login.xml.
Should I do it?

Sure, please go ahead. 👍

@the-dagger created PR #8. Please review it.

@the-dagger  thanks


Update required go version in Readme.md

As stated in the Readme.md, the minimum go version required is 1.14
By the way, trying to build the master branch with that version fails due to
pkg/core/mempool/mempool.go:159:10: ticker.Reset undefined (type *time.Ticker has no field or method Reset)
ticker.Reset was added in 1.15

Closed by #1190


Add get/accept quote via public facing API

This adds two endpoints:
GET /v3/order/public/<public_token>/quote which returns details of a quote
POST /v3/order/public/<public_token>/quote/accept which accepts a quote
It also changes the way an order is reopened.
Before: you could reopen an order even if it was in draft already.
After: if the order is in draft and you try to reopen it a 409 is returned.
This is to be consistent with all the other state change methods.

Codecov Report

Merging #488 into develop will increase coverage by 0.02%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #488      +/-   ##
===========================================
+ Coverage    96.45%   96.48%   +0.02%
===========================================
  Files          114      115       +1
  Lines         3613     3643      +30
  Branches       335      335
===========================================
+ Hits          3485     3515      +30
  Misses          87       87
  Partials        41       41

Impacted Files
Coverage Δ

datahub/omis/urls.py
100% <ø> (ø)
:arrow_up:

datahub/omis/order/manager.py
100% <100%> (ø)

datahub/omis/quote/serializers.py
100% <100%> (ø)
:arrow_up:

datahub/omis/quote/views.py
100% <100%> (ø)
:arrow_up:

datahub/omis/quote/urls.py
100% <100%> (ø)
:arrow_up:

datahub/omis/order/views.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8c0caf...6344981. Read the comment docs.


Add support for Tailwind CSS IntelliSense

What problem would you like to solve or improve?
When using the cn() utility function to write Tailwind CSS classes, it can sometimes be challenging to remember and efficiently input the desired classes. This results in slower development workflows and potentially introduces errors in the class names.
Describe your proposed solution or enhancement.
To enhance the development experience and streamline the process of writing Tailwind CSS classes using the cn() utility function, I propose adding improved support for Tailwind CSS IntelliSense.
Describe any alternative solutions you've considered (optional).
No response
Additional context or information (optional).
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct.

Done!


Bad performance when used with threaded mpms and a libapr compiled with  "--enable-allocator-uses-mmap" option

Originally reported by: Nelson Elhage and Stefan Fritsch.
It seems that ModSecurity is having bad performance whenever used with threaded mpms and a libapr compiled with  "--enable-allocator-uses-mmap" option.
According to Stefan that option is used on apr's Debian package for over 3 years.
It is somehow related to the way that ModSecurity is individually handling every connection, by created a new memory allocator.
Relevant piece of code:

https://github.com/SpiderLabs/ModSecurity/blob/master/apache2/mod_security2.c#L447-L451

Original report:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=758068
Option "--enable-allocator-uses-mmap" was added on libapr by Stefan as of 1.4.3, ChangeLog:
http://svn.apache.org/viewvc/apr/apr/branches/1.4.x/CHANGES?view=markup
Mail sent to ModSecurity devs mailing list:
http://sourceforge.net/p/mod-security/mailman/message/32723547/

@s-fritsch  Can you provide a pull-request?

This crashes httpd 2.4.23 on Windows

The global mutex is optional since 112ba45 (included in 2.9.2 release).
This shouldn't be a concern with libModSecurity. libModSecurity (aka v3) is already officially released: https://github.com/SpiderLabs/ModSecurity/releases/tag/v3.0.2 (3.0.3 upcoming)
Thanks!

It's not quite clear how this is related to the global mutex from #1224
The fixed allocator mentioned in the original reports is still around https://github.com/SpiderLabs/ModSecurity/blob/v2/master/apache2/mod_security2.c#L481

hummm indeed @shallot. My bad. It was closed by mistake when looking for issues related with the mutex.
Reopening and tagging for review prior to 2.9.4 release.
If you would like to help the community by testing the proposed patch and reporting back it would be great too!
Thanks!


Error in Log: ERROR (XmlRpcServer on port 49883) [hahomematic.central] FIRE_HA_EVENT_CALLBACK

Describe the issue you are experiencing
I am using RaspberryMatic under Homeassistant. I see the following error messages in the log:
2024-09-12 21:21:35.194 ERROR (XmlRpcServer on port 49883) [hahomematic.central] FIRE_HA_EVENT_CALLBACK: Unable to call handler: Detected that custom integration 'homematicip_local' calls issue_registry.async_delete from a thread other than the event loop, which may cause Home Assistant to crash or data to corrupt. For more information, see https://developers.home-assistant.io/docs/asyncio_thread_safety/#issue_registryasync_delete at custom_components/homematicip_local/control_unit.py, line 354: async_delete_issue(. Please report it to the author of the 'homematicip_local' custom integration.

and the following warnings:
2024-09-12 21:21:35.183 WARNING (XmlRpcServer on port 49883) [homeassistant.helpers.frame] Detected that custom integration 'homematicip_local' calls issue_registry.async_delete from a thread other than the event loop, which may cause Home Assistant to crash or data to corrupt. For more information, see https://developers.home-assistant.io/docs/asyncio_thread_safety/#issue_registryasync_delete at custom_components/homematicip_local/control_unit.py, line 354: async_delete_issue(, please report it to the author of the 'homematicip_local' custom integration

2024-09-12 21:21:14.907 WARNING (MainThread) [homeassistant.util.loop] Detected blocking call to read_text with args (PosixPath('/usr/local/lib/python3.12/site-packages/hahomematic/client/../rega_scripts/get_serial.fn'),) inside the event loop by custom integration 'homematicip_local' at custom_components/homematicip_local/control_unit.py, line 123: await self._central.start() (offender: /usr/local/lib/python3.12/site-packages/hahomematic/client/json_rpc.py, line 270: if script := Path(script_file).read_text(encoding=DEFAULT_ENCODING):), please create a bug report at https://github.com/danielperna84/hahomematic/issues
For developers, please see https://developers.home-assistant.io/docs/asyncio_blocking_operations/#read_text
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/usr/src/homeassistant/homeassistant/__main__.py", line 223, in <module>
    sys.exit(main())
  File "/usr/src/homeassistant/homeassistant/__main__.py", line 209, in main
    exit_code = runner.run(runtime_conf)
  File "/usr/src/homeassistant/homeassistant/runner.py", line 189, in run
    return loop.run_until_complete(setup_and_run_hass(runtime_config))
  File "/usr/local/lib/python3.12/asyncio/base_events.py", line 674, in run_until_complete
    self.run_forever()
  File "/usr/local/lib/python3.12/asyncio/base_events.py", line 641, in run_forever
    self._run_once()
  File "/usr/local/lib/python3.12/asyncio/base_events.py", line 1990, in _run_once
    handle._run()
  File "/usr/local/lib/python3.12/asyncio/events.py", line 88, in _run
    self._context.run(self._callback, *self._args)
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 752, in async_setup_locked
    await self.async_setup(hass, integration=integration)
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 604, in async_setup
    result = await component.async_setup_entry(hass, self)
  File "/config/custom_components/homematicip_local/__init__.py", line 55, in async_setup_entry
    await control.start_central()
  File "/config/custom_components/homematicip_local/control_unit.py", line 218, in start_central
    await super().start_central()
  File "/config/custom_components/homematicip_local/control_unit.py", line 123, in start_central
    await self._central.start()

2024-09-12 21:21:14.937 WARNING (MainThread) [homeassistant.util.loop] Detected blocking call to open with args (PosixPath('/usr/local/lib/python3.12/site-packages/hahomematic/client/../rega_scripts/get_serial.fn'),) inside the event loop by custom integration 'homematicip_local' at custom_components/homematicip_local/control_unit.py, line 123: await self._central.start() (offender: /usr/local/lib/python3.12/pathlib.py, line 1027: with self.open(mode='r', encoding=encoding, errors=errors) as f:), please create a bug report at https://github.com/danielperna84/hahomematic/issues
For developers, please see https://developers.home-assistant.io/docs/asyncio_blocking_operations/#open
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/usr/src/homeassistant/homeassistant/__main__.py", line 223, in <module>
    sys.exit(main())
  File "/usr/src/homeassistant/homeassistant/__main__.py", line 209, in main
    exit_code = runner.run(runtime_conf)
  File "/usr/src/homeassistant/homeassistant/runner.py", line 189, in run
    return loop.run_until_complete(setup_and_run_hass(runtime_config))
  File "/usr/local/lib/python3.12/asyncio/base_events.py", line 674, in run_until_complete
    self.run_forever()
  File "/usr/local/lib/python3.12/asyncio/base_events.py", line 641, in run_forever
    self._run_once()
  File "/usr/local/lib/python3.12/asyncio/base_events.py", line 1990, in _run_once
    handle._run()
  File "/usr/local/lib/python3.12/asyncio/events.py", line 88, in _run
    self._context.run(self._callback, *self._args)
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 752, in async_setup_locked
    await self.async_setup(hass, integration=integration)
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 604, in async_setup
    result = await component.async_setup_entry(hass, self)
  File "/config/custom_components/homematicip_local/__init__.py", line 55, in async_setup_entry
    await control.start_central()
  File "/config/custom_components/homematicip_local/control_unit.py", line 218, in start_central
    await super().start_central()
  File "/config/custom_components/homematicip_local/control_unit.py", line 123, in start_central
    await self._central.start()

Describe the behavior you expected
No warnings / errors in log
Steps to reproduce the issue

Reboot Home Assistant system with version <IP_ADDRESS>40826 of RaspberryMatic installed
inspect logs

What is the version this bug report is based on?
<IP_ADDRESS>40826
Which base platform are you running?
rpi3 (RaspberryPi3, ARM64/aarch64)
Which HomeMatic/homematicIP radio module are you using?
RPI-RF-MOD
Anything in the logs that might be useful for us?
See above

Additional information
I don't know if this is a regression or not - I inspected the logs cause of a different issue.

Sorry, but I think the message in the error is quite clear:
...
 please report it to the author of the 'homematicip_local' custom integration
...

So please go ahead and report this to the authors of the homematicip_local integration and not RaspberryMatic.

@jens-maus : it is a bit confusing that there are 3 parties involved: RaspberryMatic, homematicip_local and home assistant. I can't say this is 100% clear to me how this is all connected. Is it so that the mechanisms to run RaspberryMatic under home assistant are maintained by you and that this additional plugin is just needed to allow to read/write values from RaspberryMatic in Home assistant?

That's the right place for your issue: https://github.com/danielperna84/hahomematic


Move jolokia.feature to cct_module

This should not be merged until after this one: https://github.com/jboss-openshift/cct_module/pull/363

This PR superceded the one mentioned in the last comment https://github.com/jboss-openshift/cct_module/pull/369 and is now merged, so this is ready


Store and display the config file used for each check

Motivation
We want to be able to display the source of the config for each check in status/web-gui.
I added this to the Check interface, so it required a ton of changes. If anyone has a better solution for this, it's welcome.

How does Source differs from Provider which is displayed in the configcheck command?

How does Source differs from Provider which is displayed in the configcheck command?

It differs in that I didn't know about Provider 😅
That aside, Provider just displays "file" for plugins loaded from a config file, instead of the actual filename and path, so it's not the same.
In any case, it totally looks like I could re-use a lot more code if I base my patch on the already implemented Provider field :)
I will give it a try and update my patch.

Unfortunately, the info from agent configcheck and agent status comes from very different places: the first comes from GetLoadedConfigs(), while the second from the Status structs tied to each Check. Even if we pass the filename information to the Config struct (that's easy), we wouldn't have it in Check nor in Status, where we need it for the command agent status.
I've tried to make agent status get both sources of information and match them together before rendering the status template, but unfortunately there is no common unique identifier in both places to do the match.
The other alternative is to get the filename in Status, and for that we need to pass it from Check, and to have it in Check we need to provide it either when the Check is created or in Configure(), like this patch does.
I don't really like this patch myself, but I can't find a better way of matching Checks and Configs. Any ideas?

Superseded by https://github.com/DataDog/datadog-agent/pull/3916


Implement AI component

Problem description
A couple of weeks ago, we temporarily hid the AI dialog in the ODE because our team decided to first reflect on how we would make the AI integration. The process involved several team discussions guided by Madelon Hulsebos (AI consultant) to get feedback, insights and recommendations. In this process, we tried to address these key topics:

What would be a useful AI integration for the user?
How would we communicate it (transparency aspect)
Privacy conversations.

Step 1

Enable the AI button at the top of the datagrid:

Order: AI, Publish and Save Changes.
Button name: AI
Since the name is short, you can add the same icon we used in the past:
Other specifications: because the aim of the AI integration will help users improve name and descriptions for columns, please, activate the AI button whenever a user ingest a table in csv, Excel or Google Sheets.

Predefined prompt: suggest improvements to the names of the columns in the table and provide descriptions for each of them

Step 2
After clicking on the AI button, the user adds their credentials to activate the AI feature.
Step 3
Then, the ODE displays a new dialog with this message to inform the user what will happen after validating credentials with the AI system:
If you proceed, the Open Data Editor will only share the names of the columns in your table to suggest improvements to the titles and descriptions associated with them. Do you want to proceed?
Cancel / OK
Step 4
If the user clicks on Cancel, the ODE will show the datagrid again. If the user accepts, the ODE will show the output in a pop up window:**
Note: it's up to the user to decide to edit column names and descriptions after the AI result.

Looks good! Two comments:

naming the button "AI" might be too generic if there is no further description of the functionality provided (if you see "AI" in Excel, it can refer to anything).
if the ODE provides the column names to an LLM anyway for descriptions, it might also prompt the LLM to suggest 1) data validation rules (the checks integrated in the ODE can be provided), and 2) relevant analysis questions. The AI could then be a dropdown with "column descriptions", "data validation rules", "analysis questions". But this could be considered for another iteration, the value gain for the ODE might be significant.

Thanks for your comments @madelonhulsebos! @roll please, discuss this today un our meeting.


Add javadoc publishing tool

I just want to get the tool loaded early before I forget about it. I also set up GH Pages to read from the gh-pages branch.

I'm going to force-merge this since there is nothing else in the repo


Remove mutex

This PR

Refactors MerkleDatabase slightly to remove the use of Mutex wrapping root_node and root_hash. It creates a new struct MerkleState that wraps an LMDB database and implements the Read,
Write and Prune traits. MerkleState creates an instance of MerkleDatabase and call its methods
to perform read, write and prune operations.
MerkleDatabase is renamed MerkleRadixTree.
Fix a few compiler warnings in the merkle test module

commit 8980f70a3ef3bbc0ffdac55cd1bbd9a9e332696d is missing DCO


Move delete deploy keys into service layer

Last call for another review @go-gitea/technical-oversight-committee


find_volume_changes needs a rewrite

Once issues #289, #351 and #352 are closed, flocker.node._deploy.find_volume_changes will need rewriting, as its logic was implemented as a workaround to these issues.

We are moving our development planning to JIRA. This is issue is now being tracked at https://clusterhq.atlassian.net/browse/FLOC-914. You are welcome to file additional issues in GitHub if that's easier for you.


Update Dockerfiles

dockerfile images have been moved

see https://blog.docker.com/2015/03/updates-available-to-popular-repos-update-your-images/

datastax apt key has changed

curl the key when building now to get the latest

use openjdk-7-jre instead of oracle-java7 which no longer exists as a tag

@spotify/helios-team
I've already built and pushed newer images to docker hub to upgrade glibc6 to 2.19-18+deb8u3 which fixes CVE-2015-7547: https://security-tracker.debian.org/tracker/CVE-2015-7547

lgtm


Python CFFI build problem on Windows

On Windows, the current CMake build ends with a Python CFFI problem.
This is unfortunately unsolved so far, and help for fixing this problem is welcome
...
...
  Building CFFI lib
  PyCFFIlib_cffi.c
CUSTOMBUILD : warning : I don't know what to do with 'runtime_library_dirs': ['.'] [C:\Users\a4z\work\djinni\support-lib\build\py2\test-suite\PyCFFIlib_cffi.vcxproj]
  Traceback (most recent call last):
    File "C:\Users\a4z\work\djinni\support-lib\build\py2\test-suite\generated-src\cffi\pycffi_lib_build.py", line 25, in <module>
      ffi.compile()
    File "C:\Users\a4z\AppData\Local\Programs\Python\Python39\lib\site-packages\cffi\api.py", line 725, in compile
      return recompile(self, module_name, source, tmpdir=tmpdir,
    File "C:\Users\a4z\AppData\Local\Programs\Python\Python39\lib\site-packages\cffi\recompiler.py", line 1564, in recompile
      outputfilename = ffiplatform.compile('.', ext,
    File "C:\Users\a4z\AppData\Local\Programs\Python\Python39\lib\site-packages\cffi\ffiplatform.py", line 22, in compile
      outputfilename = _build(tmpdir, ext, compiler_verbose, debug)
    File "C:\Users\a4z\AppData\Local\Programs\Python\Python39\lib\site-packages\cffi\ffiplatform.py", line 51, in _build
      dist.run_command('build_ext')
    File "C:\Users\a4z\AppData\Local\Programs\Python\Python39\lib\distutils\dist.py", line 985, in run_command
      cmd_obj.run()
    File "C:\Users\a4z\AppData\Local\Programs\Python\Python39\lib\site-packages\setuptools\command\build_ext.py", line 79, in run
      _build_ext.run(self)
    File "C:\Users\a4z\AppData\Local\Programs\Python\Python39\lib\distutils\command\build_ext.py", line 340, in run
      self.build_extensions()
    File "C:\Users\a4z\AppData\Local\Programs\Python\Python39\lib\distutils\command\build_ext.py", line 449, in build_extensions
      self._build_extensions_serial()
    File "C:\Users\a4z\AppData\Local\Programs\Python\Python39\lib\distutils\command\build_ext.py", line 474, in _build_extensions_serial
      self.build_extension(ext)
    File "C:\Users\a4z\AppData\Local\Programs\Python\Python39\lib\site-packages\setuptools\command\build_ext.py", line 196, in build_extension
      _build_ext.build_extension(self, ext)
    File "C:\Users\a4z\AppData\Local\Programs\Python\Python39\lib\distutils\command\build_ext.py", line 551, in build_extension
      self.compiler.link_shared_object(
    File "C:\Users\a4z\AppData\Local\Programs\Python\Python39\lib\distutils\ccompiler.py", line 713, in link_shared_object
      self.link(CCompiler.SHARED_OBJECT, objects,
    File "C:\Users\a4z\AppData\Local\Programs\Python\Python39\lib\distutils\_msvccompiler.py", line 460, in link
      lib_opts = gen_lib_options(self,
    File "C:\Users\a4z\AppData\Local\Programs\Python\Python39\lib\site-packages\setuptools\msvc.py", line 329, in msvc14_gen_lib_options
      return get_unpatched(msvc14_gen_lib_options)(*args, **kwargs)
    File "C:\Users\a4z\AppData\Local\Programs\Python\Python39\lib\distutils\ccompiler.py", line 1093, in gen_lib_options
      opt = compiler.runtime_library_dir_option(dir)
    File "C:\Users\a4z\AppData\Local\Programs\Python\Python39\lib\distutils\_msvccompiler.py", line 519, in runtime_library_dir_option
      raise DistutilsPlatformError(
  distutils.errors.DistutilsPlatformError: don't know how to set runtime library search path for MSVC
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(241,5): error MSB8066: Custom build for 'C:\Users\a4z\work\djinni\support-lib\build\py2\CMakeFiles
\aadf18d4fcbdff197304b4b5d83cea85\pycffi_lib_build.py.rule;C:\Users\a4z\work\djinni\support-lib\build\py2\CMakeFiles\5ce445708c0c39eeaefe4c3c138abd3a\Foo_Record.py.rule;C:\Users\a4z\work\djinni\support-lib\build\py
2\CMakeFiles\0723da9f51c0e0e7e15825be3e6cbffb\PyCFFIlib_cffi.rule' exited with code 1. [C:\Users\a4z\work\djinni\support-lib\build\py2\test-suite\PyCFFIlib_cffi.vcxproj]
~\work\djinni\support-lib [private/moreWindowsTweaks +4 ~1 -0 !] (18:36:58)

Hi,
The module distutils is deprecated:
https://bugs.python.org/issue2437
https://www.python.org/dev/peps/pep-0632/
Need use setuptools instead.

that gets pulled in from cffi, so this is not our dependency

a little bit of progress, maybe
runtime lib dir setup
https://github.com/cross-language-cpp/djinni-generator/blob/4854a164b1aa737b4e09c36b1b403b3048346bd7/src/main/scala/djinni/CffiGenerator.scala#L56
needs kind of such a logic
if sys.platform=='win32':
   runtime_lib_dirs = []
else:
   runtime_lib_dirs = ['.']

Missing symbols
Additionally, our generated libraries do not export any symbols on Windows
This is a problem since there is nothing to link against
(when creating the test mylib.dll, we do not get the mylib.lib file so the Windows linker can find mylib from the python test)


GL_EXT_buffer_reference support?

Hi, I am trying to use GL_EXT_buffer_reference extension in MoltenVK without luck so far. Is this feature supported? I can provide an example if required.

GL_EXT_buffer_reference requires the Vulkan extension VK_KHR_buffer_device_address. That is under development, but is not available yet. It should be in place over the next few weeks.

Implemented in PRs #1619 and #1638.


In anchor story, only emit contenteditable when set

Pull Request
🤨 Rationale
Fixes #1723
👩💻 Implementation
Treat contenteditable setting as a boolean rather than a string, and omit the attribute when the setting is false.
🧪 Testing
Storybook
✅ Checklist

[x] I have updated the project documentation to reflect my changes or determined no changes are needed.

Oops, @jattasNI I absent-mindedly set auto-merge before you reviewed. If you see anything you want changed, though, I'll open a new PR.


Content reasons for rejection tweak

Content reasons for rejection tweak

There's a broken section here for safeguarding...will close this for now.


Fixed share buttons - I think. Will need to test with Heroku

Facebook and Twitter definitely look like they're working because they show the link to my localhost. The others may need an actual live website, for instance Google says the link cannot be found. So Heroku will be good to test full functionality.

👍


add paging support for aarch64

Currently, libhermit supports only 4K pages. In addition, libhermit initialize the freelists for the virtual and physical memory.
These changes requires hermitcore/rusty-loader#56

bors try

bors r+

bors r+

bors r+

bors r+

bors r+

bors try

bors r+

bors r+

bors r+


Automatic update breaks the application on OSX El Capitan

I'm seeing the same symptoms described in #47941, but that issue has been closed and I cannot comment on there.

VSCode Version: latest, but I've observed this issue for a few months now
OS Version: OSX 10.11.6

Steps to Reproduce:

install VScode
wait for an automatic update to happen
try to launch VScode again

Does this issue occur when all extensions are disabled?: Yes
It appears that automatic update breaks the Electron framework distributed with the app
~ code
dyld: Library not loaded: @rpath/libnode.dylib
  Referenced from: /Applications/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework
  Reason: image not found
/usr/local/bin/code: line 10: 66649 Trace/BPT trap: 5       ELECTRON_RUN_AS_NODE=1 "$ELECTRON" "$CLI" "$@"

Re-installing VScode fixes the issue, but it's quite annoying

So... reinstalling the issue fixed it... but only until the next update?
Where do you usually place VS Code's app bundle?

Yes, exactly. My app bundle is in /Applications, it should be a standard location

@bpasero Have you seen this?

@joaomoreno nope, first time

I am clueless on this one. Can you reproduce it on other machines?

Unfortunately this is the only machine I have available. #47941 suggests it happened also for at least someone else.
It also seems an Electron issue more than a Visual Studio Code specific issue. Have a look at this issue in the Atom repository https://github.com/atom/atom/issues/3093#issuecomment-327482918
At the moment I'm afraid there isn't much I can do, but I'll report back what happens the next time vscode tried to update itself.


Merging v10 into master.

Codecov Report

Merging #99 into master will not impact coverage.

@@          Coverage Diff           @@
##           master    #99    +/-   ##
======================================
  Coverage     100%   100%
======================================
  Files          63     72     +9
  Lines        1837   1985   +148
======================================
+ Hits         1837   1985   +148

Impacted Files
Coverage Δ

shelf/artifact_manager.py
100% <100%> (ø)
:white_check_mark:

shelf/utils.py
100% <100%> (ø)
:white_check_mark:

shelf/metadata/manager.py
100% <100%> (ø)
:white_check_mark:

shelf/hook/background/command_runner.py
100% <100%> (ø)

shelf/logger_creator.py
100% <100%> (ø)

shelf/container.py
100% <100%> (ø)
:white_check_mark:

shelf/hook/background/command_result.py
100% <100%> (ø)

shelf/hook/null_manager.py
100% <100%> (ø)

shelf/configure.py
100% <100%> (ø)
:white_check_mark:

shelf/hook/event.py
100% <100%> (ø)

... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c389d17...77cf3ca. Read the comment docs.


Revert libnames to v2.4 style

In v2.5.x, the library names got a Shared and Static suffix which was a leftover from the intermediate presence of yoda.
Here, we revert to the library names of v2.4.x.

replaced by #231


How to use local LMM in this repo?

How to use local LMM in this repo?

+1

You can use different backends for the coders, documentation is here https://landing-ai.github.io/vision-agent/#additional-backends
For local LLMs it runs on llama, just use this command to install the necessary models:
ollama pull llama3.1
ollama pull mxbai-embed-large

And then you can run the Ollama vision agents with this code:
>>> import vision_agent as va
>>> agent = va.agent.OllamaVisionAgentCoder()
>>> agent("Count the apples in the image", media="apples.jpg")


Reduce pointer size

There one object with one thread pointer, if we have a hundred objects, there have a hundred thread pointers takes about 200 Bytes memory (pointer size is 2 Bytes). That's great waste in resource limited environment which may only have 4KBytes memory or less.
There may be 4 threads already enough for a system, so we could limit the thread counts by a limited map and return an minimal type uint8_t as thread id.
Though this design will get us more slower to access to a thread stuffs, but it's worth to earn more precious memory.

Maybe we could not only reduce the thread pointer size, but also all pointer size around the program! There are references hanging around the program, if we could reduce half of them, that's a great effort.


Update certain cells without reloading the whole grid

Is this possible ?
I have a huge grid, and upon changing a cell, im calling an API to get some updates, these updates might affect a few cells.
Is there a way to update said cells, without having HotTable reloading the whole grid ?

Hi @coljung
Currently, it is not available to update only single cell/area of cells. The whole grid is rerendered when you change a single cell.
We are planning to change the behavior via, what I like to call an eco-rendering. But the project hasn't started yet. Here's a Trello card to follow for updates https://trello.com/c/m9KTygSV/80-rewrite-renderers-to-improve-performance-2152

Will this affect 'Undo' as well ?
When the whole grid is rerendered, does it keep the 'undo' history, or is that reseted as well ?

The undo stack has (or should, as there are some issues related) hold the changes for all the cells regardless the rendering process.


png为4个channel时报错

rank0]: Traceback (most recent call last):
[rank0]:   File "/mnt/workspace/wuyu_workspace/download/x-flux/train_flux_lora_deepspeed.py", line 301, in
[rank0]:     main()
[rank0]:   File "/mnt/workspace/wuyu_workspace/download/x-flux/train_flux_lora_deepspeed.py", line 218, in main
[rank0]:     x_1 = vae.encode(img.to(accelerator.device).to(torch.float32))
[rank0]:   File "/mnt/workspace/wuyu_workspace/download/x-flux/src/flux/modules/autoencoder.py", line 303, in encode
[rank0]:     z = self.reg(self.encoder(x))
[rank0]:   File "/mnt/data/miniconda3/envs/comfyui/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1532, in _wrapped_call_impl
[rank0]:     return self._call_impl(*args, **kwargs)
[rank0]:   File "/mnt/data/miniconda3/envs/comfyui/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1541, in _call_impl
[rank0]:     return forward_call(*args, **kwargs)
[rank0]:   File "/mnt/workspace/wuyu_workspace/download/x-flux/src/flux/modules/autoencoder.py", line 161, in forward
[rank0]:     hs = [self.conv_in(x)]
[rank0]:   File "/mnt/data/miniconda3/envs/comfyui/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1532, in _wrapped_call_impl
[rank0]:     return self._call_impl(*args, **kwargs)
[rank0]:   File "/mnt/data/miniconda3/envs/comfyui/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1541, in _call_impl
[rank0]:     return forward_call(*args, **kwargs)
[rank0]:   File "/mnt/data/miniconda3/envs/comfyui/lib/python3.10/site-packages/torch/nn/modules/conv.py", line 460, in forward
[rank0]:     return self._conv_forward(input, self.weight, self.bias)
[rank0]:   File "/mnt/data/miniconda3/envs/comfyui/lib/python3.10/site-packages/torch/nn/modules/conv.py", line 456, in _conv_forward
[rank0]:     return F.conv2d(input, weight, bias, self.stride,
[rank0]: RuntimeError: Given groups=1, weight of size [128, 3, 3, 3], expected input[1, 4, 1024, 1024] to have 3 channels, but got 4 channels instead

Hi! Yeah, it seems there is a different format of your input images, so they don't match the model architecture.
Check this line, the img should have 3 channels

I think there are transparent pictures(.png) in your dataset It have 4 channels RGBA May be pre-operate your dataset,for example image.convert('RGB') will work

thx, isfixed it

I think there are transparent pictures(.png) in your dataset It have 4 channels RGBA May be pre-operate your dataset,for example image.convert('RGB') will work

u r my hero thx


[FEATURE] - Multus CNI

Telecom customers want to use Multus CNI with EKS. See https://aws.amazon.com/blogs/containers/amazon-eks-now-supports-multus-cni/ for more information.

Do we have a customer need or any justification why we needs or is this a stale one @askulkarni2  ?


fix: Change internal fields to _tigris prefix

Describe your changes
This change will allow users to have created_at/updated_at field in the model. After this is deployed, the internal timestamps will be indexed using _tigris_ prefix.
How best to test these changes
Issue ticket number and link

LGTM. Changes the internal fields to be _ prefixed, as stated on the can.


Small update to animation documentation

Ref: #7223, #7151

These changes look good to me. I'm happy if you want to merge this now. I might not close the tickets out yet though because I think some examples would also be helpful.
The part that's probably hardest to understand is the [property], [collection], [mode] section. We could probably make the description for "[property]" clearer. Maybe something like "Option overrides for element property with name [property]." But mostly I think we just need an example demonstrating one or all of these
Thanks for this change! You caught some good things!


feat!: Big changes to the navigation system

https://github.com/lenra-io/client-backoffice/issues/50
Checklist

[ ] I didn't over-scope my PR
[ ] My PR title matches the commit convention
[ ] I did not include breaking changes
[ ] I included unit tests that cover my changes
[ ] I added/updated the documentation about my changes
[ ] I made my own code-review before requesting one

Description of the changes
Big changes to switch to GoRouter navigation.

:tada: This PR is included in version 1.0.0-beta.22 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-alpha.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Cleanup

[chrisgor@sherlock-ln01 login_node ~]$ du -h /scratch/users/chrisgor/ndmg_output/
1.9G    /scratch/users/chrisgor/ndmg_output/reg_dti
624K    /scratch/users/chrisgor/ndmg_output/graphs/slab1068
60K     /scratch/users/chrisgor/ndmg_output/graphs/DS00096
80K     /scratch/users/chrisgor/ndmg_output/graphs/DS00108
368K    /scratch/users/chrisgor/ndmg_output/graphs/slab907
29M     /scratch/users/chrisgor/ndmg_output/graphs/DS16784
1.5M    /scratch/users/chrisgor/ndmg_output/graphs/DS01216
4.5M    /scratch/users/chrisgor/ndmg_output/graphs/DS03231
1.7M    /scratch/users/chrisgor/ndmg_output/graphs/Talairach
340K    /scratch/users/chrisgor/ndmg_output/graphs/DS00350
52K     /scratch/users/chrisgor/ndmg_output/graphs/DS00071
936K    /scratch/users/chrisgor/ndmg_output/graphs/DS00833
157M    /scratch/users/chrisgor/ndmg_output/graphs/DS72784
108K    /scratch/users/chrisgor/ndmg_output/graphs/HarvardOxford
644K    /scratch/users/chrisgor/ndmg_output/graphs/DS00583
2.4M    /scratch/users/chrisgor/ndmg_output/graphs/DS01876
9.8M    /scratch/users/chrisgor/ndmg_output/graphs/DS06481
136K    /scratch/users/chrisgor/ndmg_output/graphs/AAL
136K    /scratch/users/chrisgor/ndmg_output/graphs/CPAC200
432K    /scratch/users/chrisgor/ndmg_output/graphs/DS00446
40K     /scratch/users/chrisgor/ndmg_output/graphs/JHU
248K    /scratch/users/chrisgor/ndmg_output/graphs/DS00278
92K     /scratch/users/chrisgor/ndmg_output/graphs/DS00140
148K    /scratch/users/chrisgor/ndmg_output/graphs/DS00195
92K     /scratch/users/chrisgor/ndmg_output/graphs/desikan
210M    /scratch/users/chrisgor/ndmg_output/graphs
4.0K    /scratch/users/chrisgor/ndmg_output/tensors
3.1G    /scratch/users/chrisgor/ndmg_output/fibers
20K     /scratch/users/chrisgor/ndmg_output/tmp
5.2G    /scratch/users/chrisgor/ndmg_output/

I wonder if there is need to keep the fibers and reg_dti folder. They take up a lot of space and would be only useful for debugging. Maybe it would be better if their content would deleted upon successful completion of each subject calculation unless a --debug flag was set?

Yup, there is currently a clean flag, I just have it turned off to keep derivatives. I'll make it optional and default to cleaning rather than keeping in the workflow which we execute in the container.

Closed with https://github.com/neurodata/ndmg/commit/723a92fb98d11fb38d24544d7bdb9dfc9e889dc5


Recipe / API: pluck / map after a join

API docs for eq_join, inner_join, and outer_join doesn't describe how to use zip to combine the output
In the joins documentation, we should explain how to use pluck and map

The eq_join documentation now goes into some detail about zip. The examples for outer_join and inner_join use zip but don't explain it, they just link to it. However, I'm not sure it's worth elaborating much on it, given that we advise not using these commands and there's still a "modernizing joins" proposal open that might get rid of those commands entirely.
Given that there's a whole separate document on Map-Reduce, I don't think we should explain how to use map in the Table Joins document, and I'm not sure why we'd need to elaborate on pluck there specifically.
tl;dr: closing. Reopen something more specific if it seems like a good idea.


Issue HEAD requests to determine if client is ready

As opposed to making a query-param-less GET to the clients, which could cause a test-case to accidentally execute.

i want @kriskowal's opinion here

fixed by #15


(WIP) rustdoc redirect caching in the CDN

regularly using docs.rs there was another possible performance improvement that I saw.
I feel currently the server-side performance is (for now) not the issue any more, the next big lever would be working on caching the S3 file downloads. In #1004 if we combine it with local caching on the server, or just a webserver-local LRU cache, or perhaps a proxy between the webserver and S3.
From what I see, for users outside the US most of the time is not spent on the webserver any more, but on the roundtrip to the US, or data-download from the US.
Both could be solved by starting to cache more things on the CDN level.
Coming from previous discussion in the channel, I would rule out:

active invalidation-requests because of costs
caching the doc-pages themselves because of WIP around security with @pietroalbini
moving to a more capable CDN  (fastly for example is used my many other open source projects, while I'm not sure if it's really free or only cheap :) )

The remaining thing are (IMHO) the redirects, which are (according to @jyn514 ) also heavily used. When I test these from Berlin, it's about 150-200ms only spent in the redirect.
A simple strategy which has often more impact that we think is setting cache-headers for the CDN to a short amount of time. Even caching a thing for 15, 30, 60 minutes will gain quite much performance for pages that are regularly used, at least because the response is returned from a local POP.
In a discussion with @pietroalbini I got the impression (correct me if I'm wrong please 😄 ) that we can actually assume old version builds won't change any more. Also in that discussion a label like this version is yanked or go to latest version was ok to be outdated for 15 minutes (or so).
This would actually lead me to the conclusion that we can

cache crate/version internal redirects forever
cache redirects that are based on the latest version for 15-30 minutes

under the assumption that we cache only on the CDN level, which enables us to manually invalidate the whole cache if we want to (up to 1000 invalidations are free in CloudFront, which likely is fine for manual invalidations/new code, but not for automatic invalidations for every crate release).
If in general this is fine for you, I can continue on working out more details, likely

add tests
change the version-internal redirects to cache longer
add more caching headers (?)
do some testing with CloudFront (do we have a staging environment?).

This is just an offer and I won't take it personally if it doesn't match your strategy for the platform. Also my assumptions or my understand might be wrong, please point me to mistakes I made.
I definitely would be happy to invest more time in this to improve the site.
links

AWS cross-datacenter roundtrip times: example for me: eu-central-1 (Frankfurt) to us-east-1 (are we located there?)  are still ~100ms
CloudFront caching headers + behavior

@jyn514 thanks for the reviews and the support :)
I'll continue working on this and will ping you when it's ready for another review

@jyn514 thanks for the reviews and the support :)
I'll continue working on this and will ping you when it's ready for another review

Won't have time to review the actual changes, but I have a few comments:

cache redirects that are based on the latest version for 15-30 minutes

While I think it's true that for the warnings on the top bar being out of date for 15-30 minutes is fine, I don't think the same applies for the redirects themselves. People often link to https://docs.rs/crate-name when announcing new releases of their crate, and having inconsistent redirects for it would be a bad user experience.

to us-east-1 (are we located there?)

No, we're in us-west-1.

Won't have time to review the actual changes, but I have a few comments:

cache redirects that are based on the latest version for 15-30 minutes

While I think it's true that for the warnings on the top bar being out of date for 15-30 minutes is fine, I don't think the same applies for the redirects themselves. People often link to https://docs.rs/crate-name when announcing new releases of their crate, and having inconsistent redirects for it would be a bad user experience.

to us-east-1 (are we located there?)

No, we're in us-west-1.

Won't have time to review the actual changes, but I have a few comments:

cache redirects that are based on the latest version for 15-30 minutes

While I think it's true that for the warnings on the top bar being out of date for 15-30 minutes is fine, I don't think the same applies for the redirects themselves. People often link to https://docs.rs/crate-name when announcing new releases of their crate, and having inconsistent redirects for it would be a bad user experience.

@pietroalbini thanks for the input, in my mind there is already a delay due to the queue and build, so adding to that wouldn't be too bad.
But up to you :)

Won't have time to review the actual changes, but I have a few comments:

cache redirects that are based on the latest version for 15-30 minutes

While I think it's true that for the warnings on the top bar being out of date for 15-30 minutes is fine, I don't think the same applies for the redirects themselves. People often link to https://docs.rs/crate-name when announcing new releases of their crate, and having inconsistent redirects for it would be a bad user experience.

@pietroalbini thanks for the input, in my mind there is already a delay due to the queue and build, so adding to that wouldn't be too bad.
But up to you :)

My main worry is inconsistency: someone could see that docs.rs/crate-name redirects to the correct versions and starts sending the link around, while people in other parts of the world (served by different POPs) will get a different link.

My main worry is inconsistency: someone could see that docs.rs/crate-name redirects to the correct versions and starts sending the link around, while people in other parts of the world (served by different POPs) will get a different link.

yeah, we will always have that when we start caching without invalidation. In the end, it's speed vs stronger consistency guarantees (and edge-case vs the regular case). Only solvable in a good way with a better CDN.
To me that makes the impression that there are different opinions among the owners here which is more important. (no hard feelings :) )
I would actually leave this PR for others until that decision is made.

yeah, we will always have that when we start caching without invalidation. In the end, it's speed vs stronger consistency guarantees (and edge-case vs the regular case). Only solvable in a good way with a better CDN.
To me that makes the impression that there are different opinions among the owners here which is more important. (no hard feelings :) )
I would actually leave this PR for others until that decision is made.

the latest-version redirect is the one I'm hitting the most, and likely I'm not the only one.
From my personal perception a slight delay for the build is ok, the same way as caching would be ok, if communicated.
(but that's personal opinion, your constraints for improvements  might be different, which is ok)

the latest-version redirect is the one I'm hitting the most, and likely I'm not the only one.
From my personal perception a slight delay for the build is ok, the same way as caching would be ok, if communicated.
(but that's personal opinion, your constraints for improvements  might be different, which is ok)

After having slept over it this feels like a micro-optimization with the constraints that exist and the effort of finishing this up.
I'll drop it for now.
I've done multiple setups with Fastly as CDN, where we could have worldwide full page caching with worldwide, free invalidation in < 1 second (and then stable response times ~20ms). That means the pages would be updated <1s after the build finished.


#1139 Solved

🛠 Fixes Issue

👨💻 Changes proposed

✔ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[ ] This PR does not contain plagiarized content.
[ ] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers

📷 Screenshots

@PayalPadmalyaPrusty you need to rename the page name from index.html to 404.html

@SauravMukherjee44 Can you please check it

@SauravMukherjee44 I renamed it.Can you please check it


Help! I have an issue when importing TF!

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
no, it is custom code but I did not write it https://medium.com/swlh/nvidia-jetson-nano-custom-object-detection-from-scratch-using-tensorflow-and-opencv-113fe4dba134 I got it from here and the TF conversion script
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Windows 10 x64
TensorFlow installed from (source or binary): I installed with pip install Tensorflow and Tensorflow-gpu
TensorFlow version (use command below): 2.1.0
Python version: 3.7.6
CUDA/cuDNN version: 10.1
GPU model and memory: 960M 4gb

Describe the current behavior
When I run the script I get the error Failed to load the native TensorFlow runtime. with a bunch of other errors that I will paste down bellow.
Describe the expected behavior
To run the script lol
Code to reproduce the issue
I am just running python and then the directory to the .py file
Any help is appreciated thanks!!!!
Other info / logs
Traceback (most recent call last):
File "C:\Python37\lib\site-packages\tensorflow_core\python\pywrap_tensorflow.py", line 58, in
from tensorflow.python.pywrap_tensorflow_internal import *
File "C:\Python37\lib\site-packages\tensorflow_core\python\pywrap_tensorflow_internal.py", line 28, in
_pywrap_tensorflow_internal = swig_import_helper()
File "C:\Python37\lib\site-packages\tensorflow_core\python\pywrap_tensorflow_internal.py", line 24, in swig_import_helper
_mod = imp.load_module('_pywrap_tensorflow_internal', fp, pathname, description)
File "C:\Python37\lib\imp.py", line 242, in load_module
return load_dynamic(name, filename, file)
File "C:\Python37\lib\imp.py", line 342, in load_dynamic
return _load(spec)
ImportError: DLL load failed: The specified module could not be found.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\Users\minec\Desktop\Robotics_stuff\TFconvert.py", line 4, in
import tensorflow as tf
File "C:\Python37\lib\site-packages\tensorflow_init_.py", line 101, in
from tensorflow_core import *
File "C:\Python37\lib\site-packages\tensorflow_core_init_.py", line 40, in
from tensorflow.python.tools import module_util as module_util
File "C:\Python37\lib\site-packages\tensorflow_init.py", line 50, in getattr
module = self.load()
File "C:\Python37\lib\site-packages\tensorflow_init.py", line 44, in _load
module = importlib.import_module(self.name)
File "C:\Python37\lib\importlib_init.py", line 127, in import_module
return _bootstrap.gcd_import(name[level:], package, level)
File "C:\Python37\lib\site-packages\tensorflow_core\python_init.py", line 49, in
from tensorflow.python import pywrap_tensorflow
File "C:\Python37\lib\site-packages\tensorflow_core\python\pywrap_tensorflow.py", line 74, in
raise ImportError(msg)
ImportError: Traceback (most recent call last):
File "C:\Python37\lib\site-packages\tensorflow_core\python\pywrap_tensorflow.py", line 58, in
from tensorflow.python.pywrap_tensorflow_internal import *
File "C:\Python37\lib\site-packages\tensorflow_core\python\pywrap_tensorflow_internal.py", line 28, in
_pywrap_tensorflow_internal = swig_import_helper()
File "C:\Python37\lib\site-packages\tensorflow_core\python\pywrap_tensorflow_internal.py", line 24, in swig_import_helper
_mod = imp.load_module('_pywrap_tensorflow_internal', fp, pathname, description)
File "C:\Python37\lib\imp.py", line 242, in load_module
return load_dynamic(name, filename, file)
File "C:\Python37\lib\imp.py", line 342, in load_dynamic
return _load(spec)
ImportError: DLL load failed: The specified module could not be found.
Failed to load the native TensorFlow runtime.
See https://www.tensorflow.org/install/errors
for some common reasons and solutions.  Include the entire stack trace
above this error message when asking for help.

Hi @Brayden1000,
Did you install the Microsoft Visual C++ Redistributable for Visual Studio 2015, 2017, and 2019?
According to the docs at https://www.tensorflow.org/install/pip,

Install the Microsoft Visual C++ Redistributable for Visual Studio 2015, 2017, and 2019. Starting with the TensorFlow 2.1.0 version, the msvcp140_1.dll file is required from this package (which may not be provided from older redistributable packages). The redistributable comes with Visual Studio 2019 but can be installed separately:

Go to the Microsoft Visual C++ downloads,
Scroll down the page to the Visual Studio 2015, 2017 and 2019 section.
Download and install the Microsoft Visual C++ Redistributable for Visual Studio 2015, 2017 and 2019 for your platform.
Make sure long paths are enabled on Windows.

Install the 64-bit Python 3 release for Windows (select pip as an optional feature).

Tensorflow 2.1.0 is compiled using MSVC 2019, which appears to require an additional DLL.


You can spam the connect button on the launcher and connect as many times as you want.

To replicate start the launcher and click the connect button many times. It will open a window for each time you connect and create your player name with a _# at the end. This is probably bad and should be clamped at 2 Robust.Clients open at one time.

Shouldn't this be an issue in the launcher repo? https://github.com/space-wizards/SS14.Launcher

Yes


Adding functionality for Discord formatted timestamps

Need to equate for timezones with this. Restoring branch to rectify.

This feature requires extensive changes to the way datetimes are stored in the database, and thus the helper methods will be added but not utilized in the upstream for now.


Failed to compress svg's

I got this error while trying this plugin. Any idea how to exclude svg's ? I tried : compress({ exclude: ["*.svg"] })
✓ 560 modules transformed.
[vite:compress] setAssetSource cannot be called in transform for caching reasons. Use emitFile with a source, or call setAssetSource in another hook.
file: F:/GitHub/senf/apps/senf-client/src/images/svgIcons/plus.svg
error during build:
Error: setAssetSource cannot be called in transform for caching reasons. Use emitFile with a source, or call setAssetSource in another hook.    at error (F:\GitHub\senf\apps\senf-client\node_modules\rollup\dist\shared\rollup.js:198:30)
at throwPluginError (F:\GitHub\senf\apps\senf-client\node_modules\rollup\dist\shared\rollup.js:21847:12)
at Object.error (F:\GitHub\senf\apps\senf-client\node_modules\rollup\dist\shared\rollup.js:22570:20)
at Object.error (F:\GitHub\senf\apps\senf-client\node_modules\rollup\dist\shared\rollup.js:22024:42)
at Object.setAssetSource (F:\GitHub\senf\apps\senf-client\node_modules\rollup\dist\shared\rollup.js:22043:33)
at Object.transform (F:\GitHub\senf\apps\senf-client\node_modules\vite-plugin-compress\dist\plugin.js:107:34)
at async transform (F:\GitHub\senf\apps\senf-client\node_modules\rollup\dist\shared\rollup.js:21994:16)
at async ModuleLoader.addModuleSource (F:\GitHub\senf\apps\senf-client\node_modules\rollup\dist\shared\rollup.js:22220:30)
source code looks like this:
import Plus from "../../../images/svgIcons/plus.svg";
<img src={Plus} width="25" alt="AddIcon" />

Fixed in v2.1.1

Well, the exclude option should work as intended, at least.
I haven't investigated the setAssetSource error yet.

Well, the exclude option should work as intended, at least.
I haven't investigated the setAssetSource error yet.

I am not even sure if I used glob pattern correctly for exclude option, but after failed tries, I just moved to another vite plugin which does not compress png's and svg's and that one seems to be working. But let me know if you find any fixes

Well, the exclude option should work as intended, at least.
I haven't investigated the setAssetSource error yet.

I am not even sure if I used glob pattern correctly for exclude option, but after failed tries, I just moved to another vite plugin which does not compress png's and svg's and that one seems to be working. But let me know if you find any fixes

compress({ exclude: ["**/*.svg"] }), works for me.
*.svg only match foo.svg not foo/bar.svg. **.svg do that. globs special-character--double-star

Same setAssetSource error for<EMAIL_ADDRESS>and<EMAIL_ADDRESS>[vite:compress] setAssetSource cannot be called in transform for caching reasons. Use emitFile with a source, or call setAssetSource in another hook.

thanks for explanation !

hi :)
I also have the same error when running a build. However, I do want svg compression.
here's the error:
vite v2.9.8 building for production...
transforming (1) index.html Running elm make /Users/gacallea/Projects and Ideas/Sites/anerandros.info/src/elm/Main.elm --output /var/folders/f2/zz4hj6h97sq264l9fpxrgh7h0000gn/T/2022414-35553-m4886d.vgfmi.js --optimize
Success!

    Main ───> /var/folders/f2/zz4hj6h97sq264l9fpxrgh7h0000gn/T/2022414-35553-m4886d.vgfmi.js

✓ 5 modules transformed.
[vite:compress] setAssetSource cannot be called in transform for caching reasons. Use emitFile with a source, or call setAssetSource in another hook.
file: /Users/gacallea/Projects and Ideas/Sites/anerandros.info/src/img/covers/eos1.svg
error during build:
Error: setAssetSource cannot be called in transform for caching reasons. Use emitFile with a source, or call setAssetSource in another hook.
    at error (/Users/gacallea/Projects and Ideas/Sites/anerandros.info/node_modules/rollup/dist/shared/rollup.js:198:30)
    at throwPluginError (/Users/gacallea/Projects and Ideas/Sites/anerandros.info/node_modules/rollup/dist/shared/rollup.js:21902:12)
    at Object.error (/Users/gacallea/Projects and Ideas/Sites/anerandros.info/node_modules/rollup/dist/shared/rollup.js:22625:20)
    at Object.error (/Users/gacallea/Projects and Ideas/Sites/anerandros.info/node_modules/rollup/dist/shared/rollup.js:22079:42)
    at Object.setAssetSource (/Users/gacallea/Projects and Ideas/Sites/anerandros.info/node_modules/rollup/dist/shared/rollup.js:22098:33)
    at Object.transform (/Users/gacallea/Projects and Ideas/Sites/anerandros.info/node_modules/vite-plugin-compress/dist/plugin.js:107:34)
    at async transform (/Users/gacallea/Projects and Ideas/Sites/anerandros.info/node_modules/rollup/dist/shared/rollup.js:22049:16)
    at async ModuleLoader.addModuleSource (/Users/gacallea/Projects and Ideas/Sites/anerandros.info/node_modules/rollup/dist/shared/rollup.js:22275:30)

the repo is public: https://github.com/gacallea/anerandros.info/
happy to provide more info and setup if needed :)


added restricted groups

Added public/restricted groups:

all groups are public by default. Also set up some scaffolding for private groups.
People will now be able to add their own markets to public groups even if they're not members

Sorry for the merge conflict churn on this. I changed very little, just moved the files around a little.

Also,  a "Curated" group is way better sounding than a "Restricted" group, and helps people understand the use-case.


Disappearing image when start typing in a text box below

After each image is uploaded we render it using this line: pc.foreach(State.img, lambda img: pc.image(src=img))
However when we go to type in the text box below afterwards (in this line: pc.input(placeholder="Enter a prompt..", on_change=State.set_prompt)) the image that we have previously rendered disappears. It then reappears if we refresh the page.
def index():
    """The main view."""
    return pc.center(
        pc.vstack(
            pc.heading("Stable Diffusion", font_size="1.5em"),
            pc.upload(
                pc.vstack(
                    pc.button(
                        "Select File",
                        color="blue",
                        bg="white",
                        border=f"1px solid blue",
                    ),
                    pc.text("Drag and drop files here or click to select files"),
                ),
                border=f"1px dotted blue",
                padding="5em",
            ),
            pc.button(
                "Upload",
                on_click=lambda: State.handle_upload(pc.upload_files()),
            ),
            pc.foreach(State.img, lambda img: pc.image(src=img)),
            pc.vstack(
                pc.input(placeholder="Enter a prompt..", on_change=State.set_prompt),
                pc.text("Number of inference steps: " + State.inference_steps),
                pc.slider(
                    on_change_end=State.set_inference_steps,
                    color_scheme="green",
                    default_value=100,
                    min_=3,
                    max_=200,
                ),
                pc.button(
                    "Generate New Image",
                    on_click=[State.process_image, State.stable_diffusion],
                    width="100%",
                ),
                pc.divider(),
                pc.cond(
                    State.image_processing,
                    pc.circular_progress(is_indeterminate=True),
                    pc.cond(
                        State.image_made,
                        pc.image(src=State.image_url),
                    ),
                ),
            ),
            bg="white",
            padding="2em",
            shadow="lg",
            border_radius="lg",
        ),
        width="100%",
        height="100vh",
        background="radial-gradient(circle at 22% 11%,rgba(62, 180, 137,.20),hsla(0,0%,100%,0) 19%),radial-gradient(circle at 82% 25%,rgba(33,150,243,.18),hsla(0,0%,100%,0) 35%),radial-gradient(circle at 25% 61%,rgba(250, 128, 114, .28),hsla(0,0%,100%,0) 55%)",
    )

Doesn't occur anymore.


Starting a paused tween does not work

This Issue is about

A bug in the API (using 3.3.0)

I'm trying to create a paused tween and start it on pointerdown:
  // Doesn't really matter just some properties
  const x = {
    duration: 4000,
    ease: 'Sine.easeInOut',
    flipX: true,
    repeat: -1,
    value: 700,
    yoyo: true,
  }

  const props = {
    targets: [sprite],
    x,
    paused: true, // <-- Starting in paused state
  }

  const tween = this.tweens.add(props)

  sprite
    .setInteractive()
    .on(`pointerdown`, pointer => {
      if (tween.isPlaying()) {
        tween.pause()
      } else {
        tween.resume() // <-- Does not start/resume the tween?
      }
    })

Interestingly it works if I remove the paused property and create the tween conditionally in the pointerdown handler (and immediately pause it):
  const props = {
    targets: [card],
    x,
    // paused: true,  <-- Removed
  }

  let tween = null;

  card
    .setInteractive()
    .on(`pointerdown`, pointer => {
      tween = tween || this.tweens.add(props) // <-- Create here if not done yet

      if (tween.isPlaying()) {
        tween.pause() // <-- Playing now, so pause it immediately
      } else {
        tween.resume()
      }
    }

Am I misunderstanding something or is this behaviour not expected?

Thank you for submitting this issue. We have fixed this and the fix has been pushed to the master branch. It will be part of the next release. If you get time to build and test it for yourself we would appreciate that.

Thank you :)

I'm still having this issue. If the tween starts paused, it doesn't resume. It only works if it isn't started paused and is then paused and resumed later.


ksm.go: move global vars to be local vars

These vars are used only in calculateNewRunSleepAndPages They should be defined in this func as local vars
For better Encapsulation.

What this PR does
Before this PR:
After this PR:

Fixes #
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer

Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note

NONE

/sig code-quality

/approve


Service returns random 403 RBAC Access denied

Describe the bug
Defining multiple ServiceRole and ServiceRoleBinding leads to random 403s responses
We defined different service roles and service role bindings, one for ambassador (saturn-ambassador-role, saturn-binding-ambassador-role), one for the internal service communication (saturn-services-role, saturn-services-role-binding) and another one for ingress gateway (saturn-istio-gateway-auth, saturn-istio-gateway-auth-binding)
What we noticed for example is that calls from ambassador to the account.saturn.svc.cluster.local service sometimes are ok, and sometimes return 403s RBAC denied.
Expected behavior
The calls to the services should always be allowed or denied in a deterministic way.
Steps to reproduce the bug
apiVersion: rbac.istio.io/v1alpha1
kind: ServiceRole
metadata:
  name: saturn-services-role
  namespace: saturn
spec:
  rules:
  - methods:
    - '*'
    services:
    - '*.saturn.svc.cluster.local'
---
apiVersion: rbac.istio.io/v1alpha1
kind: ServiceRoleBinding
metadata:
  name: saturn-services-role-binding
  namespace: saturn
spec:
  roleRef:
    kind: ServiceRole
    name: saturn-services-role
  subjects:
  - properties:
      source.namespace: mercury
  - properties:
      source.namespace: mars
  - properties:
      source.namespace: venus
  - properties:
      source.namespace: jupiter
  - properties:
      source.namespace: saturn
  - properties:
      source.namespace: neptune
---
apiVersion: rbac.istio.io/v1alpha1
kind: ServiceRole
metadata:
  name: saturn-ambassador-role
  namespace: saturn
spec:
  rules:
  - methods:
    - '*'
    services:
    - product.saturn.svc.cluster.local
    - cart.saturn.svc.cluster.local
    - order.saturn.svc.cluster.local
    - account.saturn.svc.cluster.local
---
apiVersion: rbac.istio.io/v1alpha1
kind: ServiceRoleBinding
metadata:
  name: saturn-binding-ambassador-role
  namespace: saturn
spec:
  roleRef:
    kind: ServiceRole
    name: saturn-ambassador-role
  subjects:
  - user: cluster.local/ns/api-gateway/sa/ambassador
---
apiVersion: rbac.istio.io/v1alpha1
kind: ServiceRole
metadata:
  name: saturn-istio-gateway-auth
  namespace: saturn
spec:
  rules:
  - constraints:
    - key: request.headers[Authorization]
      values:
      - Basic myBasicAUthCredentialsBase64
    methods:
    - '*'
    services:
    - '*.storks.svc.cluster.local'
---
apiVersion: rbac.istio.io/v1alpha1
kind: ServiceRoleBinding
metadata:
  name: saturn-istio-gateway-auth-binding
  namespace: saturn
spec:
  roleRef:
    kind: ServiceRole
    name: saturn-istio-gateway-auth
  subjects:
  - user: cluster.local/ns/istio-system/sa/istio-ingressgateway-service-account

Version
Kubernetes: 1.12.3
Istio 1.0.6
Installation
Installation using helm
Environment
AWS
CoreOS-stable-1911.3.0-hvm

Is saturn-istio-gateway-auth applied to the ingress gateway? This is actually not supported yet, I have a PR to support this in 1.2. See https://github.com/istio/istio/pull/12415
The RBAC should be deterministic, do you have some more information for the request when it has different result?
Also just to confirm, your saturn-services-role is a super set of saturn-ambassador-role which means the identities in saturn-services-role-binding are also able to access the services in saturn-ambassador-role.

@klucerof did you resolve this issue? I seem to be having similar issues.

@walterTyro
Are you also seeing random 403 from RBAC? Would you mind to follow https://istio.io/docs/ops/security/debugging-authorization/ to get some logs to help debugging? Thanks.

Issue seems abandoned. I would encourage anyone seeing similar issues to open a new issue so we can get to the bottom of it. Thanks!