Just updated the README.md file to make it easier for people to understand like novices like myself, it explains what things are, what they do.

Confirm this is a feature request for the Python library and not the underlying OpenAI API.

[X] This is a feature request for the Python library

Describe the feature or improvement you're requesting
Enhanced README.md with Teen-Friendly Explanations.
N.B if needed i can complete the readme and have all the internal hyperlinks working to connect to the Quick Definitions section. And to have these links in blue for people to learn.
Summary
This pull request updates the README.md file, specifically enhancing the Pagination section with additional explanations tailored for younger audiences (around 15 years old). The changes aim to make the documentation more accessible and easier to understand for newcomers to the OpenAI API and programming concepts.
Changes Made
Added emoji-prefixed explanations after each code block in the Pagination section.
Introduced relatable analogies (e.g., books, relay races, encyclopedias) to explain complex concepts.
Maintained the original code examples and structure while improving readability.
Ensured explanations cover both synchronous and asynchronous pagination methods.
Benefits
Improves accessibility of the documentation for younger developers or those new to API concepts.
Provides clear, relatable explanations without sacrificing technical accuracy.
Enhances overall user experience by making complex topics more approachable.
Additional context
This is 90% finished, but wanted to share before i finished if this is not needed, but love helping out and making the README easier to understand by new users who know nothing (Just like myself!)
README.md

@davidtkeane please open a PR so we can review the changes more easily, it doesn't matter if it's not finished yet :)

@davidtkeane please open a PR so we can review the changes more easily, it doesn't matter if it's not finished yet :)

@RobertCraigie
Thank you Robert for the encouragement. I will continue to finish the document and see what happens. A PR has been created https://github.com/openai/openai-python/pull/1555
Thanks again!
Kind regards,
David.


[Blazor] Frameless browser window

Is it possible to implement a feature in Blazor to make the browser window frameless as in Electron?

@WillianGruber thanks for contacting us.
If you are talking of server-side blazor or client-side blazor, the short answer is no. They run inside a browser and hence the browser UI will always show up.
The best you can do is make the browser window/tab full screen with F11 to remove the browser frame.
I believe we have some ongoing experiments with blazor an electron, but we are still investigating that space.


Will this theme be updated?

Describe your feature request!
I like this theme very much, but hugo has been updated to v0.121.1, will the "syna" theme continue to be updated?

It's planned to get this updated again, but until now time didn't permit this. Happy for any contributions to help with this.
Overall hope for 2024 to be a bit more permitting in terms of time on this.


Startup time of extension is slower when using new analysis engine

With jedi loads in 700ms, with analysis loads in 1700ms
Need to improve caching of interpreter info

OK, I can reduce it ~30-40%. Does not affect actual completion availability time, but awaiting in the activator is quite a bit shorter so UI won't get blocked for as long.

https://github.com/Microsoft/PTVS/pull/4634

https://github.com/Microsoft/PTVS/pull/4645


feat: add password policy manager

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.
Summary of Pull Request
add a script to sample script
passwordpolicymanager.ps1
standardconfiguration-sample.json
standcarconfiguration_guide.txt
Signed-off-by: Kevin Teng<EMAIL_ADDRESS>Type of Pull Request

[ ] This is a bug fix.
[x] This is an enhancement or feature.
[ ] This is a code style / formatting update.
[ ] This is a documentation update.
[ ] This is a refactoring update.
[ ] This is something else.
Please describe:

Context of the Pull Request*

Related to Existing Issues

Issue Number: N/A
Test and Documentation Coverage

[x] Tests have been completed (for bug fixes / features).
[ ] Documentation has been added / updated (for bug fixes / features).

Breaking Changes?

[ ] Yes, there are breaking changes.
[x] No, there are no breaking changes.

Hey, Kevin!
Great to see this being submitted!
Would you mind opening an enhancement issue for this feature and then linking it back to the pull request with "Resolves: #xx"?
You'll notice that I have several loaded in that you can quickly mimic.
I'll start to look over this tomorrow. One item that I'd like to consider is modifying the .txt content to be authored in markdown as a README.md, but that could come in a follow up once we've ironed out any code reviews and tests.
Ryan Johnson
Senior Staff Solutions Architect | Product Engineering @ VMware, Inc.

@garlicNova - If you want any help resolving some of these comments, let me know and I'll be happy to assist and coordinate the edits on your branch. Just let me know!

Looking much better @garlicNova just a few more items to review and address along with the file renames and then I think we will be good to get it merged into main

@garlicNova - thanks for your diligence and patience with the review and updates. I'll provide an updated review tomorrow based on these changes.
Ryan Johnson
Senior Staff Solutions Architect | Product Engineering @ VMware, Inc.


Also, in the "Next Steps" it should clearly say, "Don't forget to attach a copy of your Grievance Decision to the letter."

edits made #4


Add runtime handlers unit tests

Codecov Report

Merging #436 into develop will decrease coverage by 0.1%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           develop    #436      +/-   ##
==========================================
- Coverage     50.6%   50.5%   -0.11%
==========================================
  Files           67      67
  Lines         1980    1984       +4
  Branches       212     212
==========================================
  Hits          1002    1002
- Misses         910     914       +4
  Partials        68      68

Impacted Files
Coverage Δ

...zure/maven/webapp/handlers/HandlerFactoryImpl.java
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f71f3dd...9e060d0. Read the comment docs.


[vcpkg osx] Fix building for non-x86_64 archs on macOS (OSX) and fixes escapes for some params

I discovered upon some tests with Xcode 12 that the arm64-osx triplet was not correct and didn't actually build for arm64 based on the output of lipo -archs mylib.a. After a long conversation in Discord, we discovered a few issues and made a few fixes:

-DCMAKE_OSX_ARCHITECTURES should be set/used in order to properly tell cmake which architectures to build for. Based on the conversation in Discord, it was decided to set CMAKE_OSX_ARCHITECTURES based on the value of VCPKG_TARGET_ARCHITECTURE if the target was iOS or macOS.
If you set multiple architectures, the args weren't escaped properly. That escaping is also fixed, here.
In order to make the code more readable for checking the target, a VCPKG_TARGET_IS_IOS definition was added.
To test out the multiple VCPKG_TARGET_ARCHITECTURE for arm64 with x86_64, a new community triplet was added.

In theory, now you can run commands like ./vcpkg install libzip[core] --triplet x64_arm64-osx and get a build that, with a lipo -archs libzip.a check, will contain both x86_64 and arm64 code.
CI:
No CI changes have been made.
Special thanks
Many thanks to @strega-nil and @ras0219-msft for their large amount of help in figuring things out in Discord. Thank you!

After reviewing this code and examining the various uses and cases for VCPKG_TARGET_ARCHITECTURE throughout the code[1], I think that there are some deeper issues that will eventually need to be addressed.
For example, how do we handle the many existing libraries that check the target architecture to add target-specific code (such as assembly files)? This is an issue in CMake as much as it is in other buildsystems. I don't think it is realistic to assert that every buildsystem and every library will be patchable to support lipo'd binaries -- and even a single link in the chain breaks the entire system.
There are other obvious issues, such as where do you stuff flags specifically for one or the other target? Maybe CMake has generator expressions, but again, what about autoconf/make/bazel/meson/etc?
Until we have a credible solution for these issues, I don't see how vcpkg can properly support universal binaries. I suspect a solution will at a minimum require vcpkg to invoke separate underlying builds for each architecture (similar to how we have separate release and debug builds), and then owning the lipo process to merge the output binaries -- however even this may be insufficient due to unknown obstacles. Depending on the use case, maybe this is more appropriate as a custom exporter that at export time lipos together multiple triplets into an SDK.
Therefore, because any short-term solution is going to be a hack, I think that the design here should adjust away from how to properly support it (since I do not think we have answers to all the above questions at this time) and instead focus on what exactly @Deadpikle is looking to achieve in their specific situation. Because we already support VCPKG_OSX_ARCHITECTURES, it seems appropriate to just fix the handling of lists for this particular item and have @Deadpikle create a custom triplet that sets it to x86_64;arm64. I do not think it's appropriate to create a community triplet for this at this time because it's going to fall over as soon as it sees a moderately complicated CMake project or anything besides CMake.
tl;dr:

I think this is a much more difficult problem than initially expected.
Therefore I think we should stick with the existing VCPKG_OSX_ARCHITECTURES (and fix the bugs) instead of trying to make things seamlessly work with VCPKG_TARGET_ARCHITECTURE
I think things here are too experimental and unstable for even a community triplet
You probably will want to set VCPKG_TARGET_ARCHITECTURE to x64 instead of ignore to maximize the chances for things to "just work", but many libraries will likely still be pretty broken.

[1] git grep "VCPKG_TARGET_ARCHITECTURE"

Thanks for the feedback on the PR and for taking a deeper look.
I think it's safe to say that the PR could probably be closed/shelved and then the following action items taken:

Submit a PR that fixes the arm64-osx triplet to use VCPKG_OSX_ARCHITECTURES. I don't see why that wouldn't work pretty much out of the box.
Submit a second PR for the lists in configuration vars (this would allow me to create a custom triplet with two VCPKG_OSX_ARCHITECTURES archs, as you noted) -- again, this was entirely @strega-nil, here, so I feel a little bit odd acting like it was me, even if the commits are cherry-picked from her work. Credit where credit is due and all that! 😄
Submit a 3rd PR with the prettify fixes (or let @strega-nil do that since it was entirely her fix and there won't be an open PR that exposes that problem?)

This would keep things fairly separated for now and avoid getting into the deeper issues you've noted. Note: I can do without items 2 and 3 for my use case -- I can manually set up my dependency building script to lipo things for me. Really, the main "broken" thing here was that the arm64-osx triplet didn't work at all (and, frankly, I suppose I could just manually edit the existing triplet, anyway.)

The main concern for me is that it's really important that this gets done before the full ARM macOS devices are released.

Really, the main "broken" thing here was that the arm64-osx triplet didn't work at all

So, focusing on that specifically, how do we get that fixed? Does it just need to have set(VCPKG_OSX_ARCHITECTURES arm64) added?
I would really like to have the list fixes; those are just goodness. I think it would be ideal to open a new PR with just those changes (list fixes + whatever is needed to fix arm64-osx without the lipo rabbit hole).

So, focusing on that specifically, how do we get that fixed? Does it just need to have set(VCPKG_OSX_ARCHITECTURES arm64) added?

I believe that's what was needed, yes. I will take a look at this again on Monday and verify that unless something else comes up and will submit new PR(s) as needed to keep things clean.

So, focusing on that specifically, how do we get that fixed? Does it just need to have set(VCPKG_OSX_ARCHITECTURES arm64) added?

I believe that's what was needed, yes. I will take a look at this again on Monday and verify that unless something else comes up and will submit new PR(s) as needed to keep things clean.

OK, yes, all that was needed to fix the arm64-osx build was VCPKG_OSX_ARCHITECTURES. So, I have split this PR into multiple PRs for easier review and to have more focus:

#12715 -- adding the VCPKG_TARGET_IS_IOS common definition.
#12716 -- the actual fix for the arm64-osx community triplet
#12717 -- fixing the prettify output
#12718 -- list fixes

With those PRs, I should be able to do everything I want to do with my own triplets or whatnot. I see that there's some discussion above, so I'm hesitant to close this PR directly until that discussion is done.
Really appreciate all who have been involved thus far. :)

Closing since we have other PRs merged that do the same thing; thanks so much @Deadpikle for your contributions!


Swipe is not desktop friendly

The Swipe UX to roll through the available times is not desktop friendly as some users might not be used to that gesture on that platform or might not have that gesture at all (mouse)
I'm not sure what would be the best way to achieve good UX here so here are two proposals
Proposal 1: expose a controller
Expose a controller so swipe right and left can be triggered via buttons for desktop users:
Row(
  children: [
     MySwipeLeftButton(onPressed: controller.moveLeft),
     TimeRane(controller: controller),
     MySwipeRightButton(onPressed: controller.moveRight),
  ]
)

Proposal 2:
Add a desktop specific variant. What I have in mind is two context menus side by side
From [  start select menu ] To [  end select menu ].

I'm not convinced by either  options so hopefully some people will chime in to give other ideas before a PR can eventually be landed

You also cannot wrap it with horizontal scroller.


Error when run QA toturial

Version
0.2.2
Problem Area
react-native-pytorch-core (core package)
Steps to Reproduce
No response
Expected Results
No response
Code example, screenshot, or link to repository
Dear Playtorch Team,
When i run program according your toturial (I program by transcrypt), it can't show answer.
Please tell me why it, and at line 15 of code, it warning that download now is deprecated (MobileModel.download(MODEL_URL) )
here is my snack:
https://snack.expo.dev/@dau123/questionanswer

@NgoVanDau, here is a working example with changes marked as inline comments:
var __name__ = 'torchApp.QuestionAnswer.QuestionAnswer';
export var pytorch = require ('react-native-pytorch-core');
export var torch = pytorch.torch;
export var MobileModel = pytorch.MobileModel;
export var text = pytorch.text;
export var BERT = require ('../BERTVocab.json');
export var tokenizer = new text.WordPieceTokenizer (dict ({'vocab': BERT.vocab}));
export var MODEL_URL = 'https://github.com/facebookresearch/playtorch/releases/download/v0.1.0/bert_qa.ptl';
export var model = null;
export var answerQuestion = async function (sourceText, question) {
  console.log('model = ', model);
	if (model == null) { // <<-- change to `model == null`. The model variable is `undefined` and not null despite being assigned null. You can see this with the console.log statement above. Generally, `model === null` should have worked, and I don't if this is an artifact due to Transcrypt (I don't know Transcrypt)
		var filePath = await MobileModel.download(MODEL_URL); // <<-- Use download function. MobileModel(MODEL_URL) doesn't work
		console.log ('load model:', filePath);
		var model = await torch.jit._loadForMobile (filePath);
		console.log ('model = ', model);
	}
  console.log ('model = ', model);
	var inputText = '[CLS] {} [SEP] {} [SEP]'.format (question, sourceText);
	var tokens = tokenizer.encode (inputText);
	var inputs = torch.tensor ([tokens], {dtype: torch.int}); // <<-- Change this to ideomatic JavaScript. JavaScript doesn't have kwargs, so it needs to be in object notion
  console.log('inputs:', inputs)
	var output = await model.forward (inputs);
	console.log ('output = ', output);
	var startId = output.start_logits.argmax ().item ();
	var endId = output.end_logits.argmax ().item ();
	var answer = tokenizer.decode (tokens.slice (startId, endId + 1));
	return answer;
};

PlayTorch Snack: https://snack.expo.dev/@raedle/questionanswer-test
You can ignore the warning about MobileModel.download or use a different way to download the PyTorch Mobile model onto the device

Thanks @raedle.
It run, but very slow. can you optimize to increase speed in inference.
it my code: https://snack.expo.dev/@dau123/questionanswer.
My transcrypt code,is it easy?:
**_async def answerQuestion(sourceText, question):
if model == None:
    filePath = await MobileModel.download(MODEL_URL)
    #console.log('load model:', filePath)
    model = await torch.jit._loadForMobile(filePath)
    #console.log('model = ', model)

inputText = f'[CLS] {question} [SEP] {sourceText} [SEP]'
tokens = tokenizer.encode(inputText)

inputs = torch.tensor([tokens], torch.int)

output = await model.forward(inputs)
console.log('output = ', output)

startId = output.start_logits.argmax().item()
endId = output.end_logits.argmax().item()
answer = tokenizer.decode(tokens.slice(startId, endId + 1))

return answer_**

Model training and model optimization is out of scope of PlayTorch. If you want to train a custom model and optimize for mobile (e.g., quantize), I recommend looking at the PyTorch Mobile documentation: https://pytorch.org/mobile/home/


Change the field escuela in the Integrante form to plantel. And add a

optional value escuela to all members
What's this PR do?
Change the field escuela in the Integrante form to plantel. And add an optional value escuela to all members
Where should the reviewer start?
First, he would to check the file familias/models.py, and see that a the new field escuela was added to Integrante.
Next, view familias/form and review the changes to IntegranteModelForm, on which escuela was changed to plantel.
Finally, you can also view captura/views.py, in which I change escuela to plantel, and the tests.
How should this be manually tested?
Enter as a Capturista to a socioeconomical study, and create a new integrante. Write something in the school field, and if the integrante is an alumno, also you must to choose a plantel.
After you save, edit the integrante to see that also update works.
Any background context you want to provide?
This has been added as per request by stakeholders.
This template was adapted ~stolen~ from Quickleft/Sprint.ly

Y porfavor checa las migraciones que tienen conflicto con las que están en develop

Listo!

Conflicting migrations, are still there, please make a manual merge from develop to your branch, once that's done check the migrations and fix the conflicts.


Architectury API

Why this feature?
Allows easy coding using both Fabric and Forge to, maybe, get a bigger player base
How can it be done?
Follow the instructions on their website
Any alternatives?
Make 2 separate repositories, one Fabric and one Forge
Additional context
From #12

Should've made a branch, gonna do a branch with the backup files


xpra: 2.5.3 -> 3.0.5

Motivation for this change
Closes #78707.
Old version (2.5.3) is EOL from upstream.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

I just got a chance to test this, but it seems like (likely due to unrelated changes?) both this and a self-built Xpra hang immediately after opening a socket. strace shows that the hang is on a poll. I have to pkill -9 or ^\, not just ^C.


HA Status is "active" before Strongswan associations came up

$ oc describe Gateway -n submariner-operator # | grep 'Ha Status:\s*active'

Name:         ip-10-166-5-197
Namespace:    submariner-operator
Labels:       <none>
Annotations:  update-timestamp:<PHONE_NUMBER>
API Version:  submariner.io/v1
Kind:         Gateway
Metadata:
  Creation Timestamp:  2020-06-04T21:09:20Z
  Generation:          2
  Resource Version:    26737
  Self Link:           /apis/submariner.io/v1/namespaces/submariner-operator/gateways/ip-10-166-5-197
  UID:                 90e63ced-51c8-44c6-8315-7e52809ca598
Status:
  Connections:
    Endpoint:
      Backend:      strongswan
      cable_name:   submariner-cable-nmanos-cluster-b-10-1-0-13
      cluster_id:   nmanos-cluster-b
      Hostname:     default-cl1-8pt5x-worker-5fm49
      nat_enabled:  true
      private_ip:   <IP_ADDRESS>
      public_ip:    <IP_ADDRESS>
      Subnets:
        <IP_ADDRESS>/19
    Status:          connecting
    Status Message:  Connecting to <IP_ADDRESS>:4501
  Ha Status:         active
  Local Endpoint:
    Backend:      strongswan
    cable_name:   submariner-cable-nmanos-cluster-a-10-166-5-197
    cluster_id:   nmanos-cluster-a
    Hostname:     ip-10-166-5-197
    nat_enabled:  true
    private_ip:   <IP_ADDRESS>
    public_ip:    <IP_ADDRESS>
    Subnets:
      <IP_ADDRESS>/19
  Status Failure:
  Version:         v0.4.0-rc1
Events:            <none>

$ subctl info

    Discovered network details:
        Network plugin:  OpenShift
        Service CIDRs: [<IP_ADDRESS>/16]
        Cluster CIDRs: [<IP_ADDRESS>/14]

$ oc describe cm -n openshift-dns

Name:         dns-default
Namespace:    openshift-dns
Labels:       dns.operator.openshift.io/owning-dns=default
Annotations:  <none>

Data
====
Corefile:
----
# lighthouse
supercluster.local:5353 {
    forward . <IP_ADDRESS>
}
.:5353 {
    errors
    health
    kubernetes cluster.local in-addr.arpa ip6.arpa {
        pods insecure
        upstream
        fallthrough in-addr.arpa ip6.arpa
    }
    prometheus :9153
    forward . /etc/resolv.conf {
        policy sequential
    }
    cache 30
    reload
}

Events:  <none>

$ oc get pods -n submariner-operator --show-labels

NAME                                             READY   STATUS    RESTARTS   AGE   LABELS
submariner-gateway-frtvd                         1/1     Running   0          32s   app=submariner-engine,controller-revision-hash=5fc48cc9f8,pod-template-generation=1
submariner-globalnet-94vx8                       1/1     Running   1          30s   app=submariner-globalnet,component=globalnet,controller-revision-hash=7cb9d85dc,pod-template-generation=1
submariner-lighthouse-agent-69f7b6b9f8-2dn7v     1/1     Running   0          29s   app=submariner-lighthouse-agent,component=submariner-lighthouse,pod-template-hash=69f7b6b9f8
submariner-lighthouse-coredns-69b5cc5746-5rl8w   1/1     Running   0          27s   app=submariner-lighthouse-coredns,component=submariner-lighthouse,pod-template-hash=69b5cc5746
submariner-lighthouse-coredns-69b5cc5746-777wx   1/1     Running   0          27s   app=submariner-lighthouse-coredns,component=submariner-lighthouse,pod-template-hash=69b5cc5746
submariner-operator-7b554d7c98-7bd28             1/1     Running   0          57s   name=submariner-operator,pod-template-hash=7b554d7c98
submariner-routeagent-28t2s                      1/1     Running   0          30s   app=submariner-routeagent,component=routeagent,controller-revision-hash=849768458d,pod-template-generation=1
submariner-routeagent-hl97d                      1/1     Running   0          30s   app=submariner-routeagent,component=routeagent,controller-revision-hash=849768458d,pod-template-generation=1
submariner-routeagent-kplwb                      1/1     Running   0          30s   app=submariner-routeagent,component=routeagent,controller-revision-hash=849768458d,pod-template-generation=1
submariner-routeagent-rcntb                      1/1     Running   0          30s   app=submariner-routeagent,component=routeagent,controller-revision-hash=849768458d,pod-template-generation=1

$ oc get clusters -n submariner-operator -o wide
NAME               AGE
nmanos-cluster-a   8s
nmanos-cluster-b   8s

$ oc describe cluster "nmanos-cluster-a" -n submariner-operator

Name:         nmanos-cluster-a
Namespace:    submariner-operator
Labels:       <none>
Annotations:  <none>
API Version:  submariner.io/v1
Kind:         Cluster
Metadata:
  Creation Timestamp:  2020-06-04T21:09:21Z
  Generation:          1
  Resource Version:    26686
  Self Link:           /apis/submariner.io/v1/namespaces/submariner-operator/clusters/nmanos-cluster-a
  UID:                 3cf75eb2-3425-470b-a7ef-ce4521a676eb
Spec:
  cluster_cidr:
    <IP_ADDRESS>/14
  cluster_id:  nmanos-cluster-a
  color_codes:
    blue
  global_cidr:
    <IP_ADDRESS>/19
  service_cidr:
    <IP_ADDRESS>/16
Events:  <none>

$ oc exec submariner-gateway-frtvd -n submariner-operator strongswan stroke statusall # | grep 'Security Associations \(1 up'

Status of IKE charon daemon (strongSwan 5.8.2, Linux 4.18.0-147.8.1.el8_1.x86_64, x86_64):
  uptime: 10 seconds, since Jun 04 21:09:21 2020
  malloc: sbrk 2830336, mmap 0, used 901296, free 1929040
  worker threads: 11 of 16 idle, 5/0/0/0 working, job queue: 0/0/0/0, scheduled: 1
  loaded plugins: charon pkcs11 tpm aesni aes des rc2 sha2 sha1 md4 md5 mgf1 random nonce x509 revocation constraints acert pubkey pkcs1 pkcs7 pkcs8 pkcs12 pgp dnskey sshkey pem openssl gcrypt fips-prf gmp curve25519 chapoly xcbc cmac hmac ctr ccm gcm drbg curl attr kernel-netlink resolve socket-default farp stroke vici updown eap-identity eap-sim eap-aka eap-aka-3gpp eap-aka-3gpp2 eap-md5 eap-gtc eap-mschapv2 eap-dynamic eap-radius eap-tls eap-ttls eap-peap xauth-generic xauth-eap xauth-pam xauth-noauth dhcp led duplicheck unity counters
Listening IP addresses:
  <IP_ADDRESS>
  <IP_ADDRESS>
  <IP_ADDRESS>
Connections:
submariner-cable-nmanos-cluster-b-10-1-0-13:  <IP_ADDRESS>...<IP_ADDRESS>  IKEv2
submariner-cable-nmanos-cluster-b-10-1-0-13:   local:  [<IP_ADDRESS>] uses pre-shared key authentication
submariner-cable-nmanos-cluster-b-10-1-0-13:   remote: [<IP_ADDRESS>] uses pre-shared key authentication
submariner-child-submariner-cable-nmanos-cluster-b-10-1-0-13:   child:  <IP_ADDRESS>/32 <IP_ADDRESS>/19 === <IP_ADDRESS>/32 <IP_ADDRESS>/19 TUNNEL
Security Associations (0 up, 1 connecting):
submariner-cable-nmanos-cluster-b-10-1-0-13[2]: CONNECTING, <IP_ADDRESS>[%any]...<IP_ADDRESS>[%any]
submariner-cable-nmanos-cluster-b-10-1-0-13[2]: IKEv2 SPIs: e5c4b4d50423c3c1_i*<PHONE_NUMBER>000000_r
submariner-cable-nmanos-cluster-b-10-1-0-13[2]: Tasks active: IKE_VENDOR IKE_INIT IKE_NATD IKE_CERT_PRE IKE_AUTH IKE_CERT_POST IKE_CONFIG CHILD_CREATE IKE_AUTH_LIFETIME

That is correct, those are unrelated things.
"active" means, that the gateway, via the HA election protocol has gained "active" status, that means it can start creating connections and publishing himself as an endpoint of the cluster.
At the start it's normal that the connections still don't exist, and will need a few seconds to be created (until the other clusters publish endpoints on the broker, and the specific cluster will receive those endpoints and process...)
A bug would be if this keeps happening for a long time even after the remote clusters have published endpoints, etc... but at the start is completely normal and inside of the expected behavior, as I said they are independent things HA status, and connection status.

That is correct, those are unrelated things.
"active" means, that the gateway, via the HA election protocol has gained "active" status, that means it can start creating connections and publishing himself as an endpoint of the cluster.
At the start it's normal that the connections still don't exist, and will need a few seconds to be created (until the other clusters publish endpoints on the broker, and the specific cluster will receive those endpoints and process...)
A bug would be if this keeps happening for a long time even after the remote clusters have published endpoints, etc... but at the start is completely normal and inside of the expected behavior, as I said they are independent things HA status, and connection status.

I agree with @mangelajo. Also HA status does not fit into connection status when we have more than 2 clusters as there could be a connection loss with a single remote cluster while the connections to all other clusters are still intact.

Up untill now I was watching the output of:
$ oc exec $submariner_pod strongswan stroke statusall | grep 'Security Associations \(1 up'
This works great, and makes the automation wait until strongswan associations came up, before continuing with submariner tests. It could take 3-10 minutes...
But now when Strongswan will not be the default cable-driver, how should we watch for Submariner readiness ?

@mangelajo, maybe if in addition to "HA Status active", you can show number of connections established ?
In another test I saw that the Gateway still shows "Status: connecting", even after StrongSwan is up:
$ oc exec submariner-gateway-knc98 -n submariner-operator strongswan stroke statusall | grep 'Security Associations \(1 up'

Status of IKE charon daemon (strongSwan 5.8.4, Linux 4.18.0-147.8.1.el8_1.x86_64, x86_64):
   uptime: 52 seconds, since Jun 11 09:17:26 2020
   malloc: sbrk 2830336, mmap 0, used 1000880, free 1829456
   worker threads: 11 of 16 idle, 5/0/0/0 working, job queue: 0/0/0/0, scheduled: 5
   loaded plugins: charon pkcs11 tpm aesni aes des rc2 sha2 sha1 md4 md5 mgf1 random nonce x509 revocation constraints acert pubkey pkcs1 pkcs7 pkcs8 pkcs12 pgp dnskey sshkey pem openssl gcrypt fips-prf gmp curve25519 chapoly xcbc cmac hmac ctr ccm gcm drbg newhope curl attr kernel-netlink resolve socket-default farp stroke vici updown eap-identity eap-sim eap-aka eap-aka-3gpp eap-aka-3gpp2 eap-md5 eap-gtc eap-mschapv2 eap-dynamic eap-radius eap-tls eap-ttls eap-peap xauth-generic xauth-eap xauth-pam xauth-noauth dhcp led duplicheck unity counters
 Listening IP addresses:
   <IP_ADDRESS>
   <IP_ADDRESS>
   <IP_ADDRESS>
 Connections:
 submariner-cable-nmanos-cluster-b-10-166-0-26:  <IP_ADDRESS>...<IP_ADDRESS>  IKEv2
 submariner-cable-nmanos-cluster-b-10-166-0-26:   local:  [<IP_ADDRESS>] uses pre-shared key authentication
 submariner-cable-nmanos-cluster-b-10-166-0-26:   remote: [<IP_ADDRESS>] uses pre-shared key authentication
 submariner-child-submariner-cable-nmanos-cluster-b-10-166-0-26:   child:  <IP_ADDRESS>/32 <IP_ADDRESS>/19 === <IP_ADDRESS>/32 <IP_ADDRESS>/19 TUNNEL
 Security Associations (1 up, 1 connecting):
 submariner-cable-nmanos-cluster-b-10-166-0-26[3]: ESTABLISHED 1 second ago, <IP_ADDRESS>[<IP_ADDRESS>]...<IP_ADDRESS>[<IP_ADDRESS>]
 submariner-cable-nmanos-cluster-b-10-166-0-26[3]: IKEv2 SPIs: e85d05d025f69511_i 80628238eb3932a7_r*, rekeying in 3 hours
 submariner-cable-nmanos-cluster-b-10-166-0-26[3]: IKE proposal: AES_GCM_16_128/PRF_HMAC_SHA2_256/MODP_2048
 submariner-child-submariner-cable-nmanos-cluster-b-10-166-0-26{1}:  INSTALLED, TUNNEL, reqid 1, ESP in UDP SPIs: cbcbcf94_i c5a99d8a_o
 submariner-child-submariner-cable-nmanos-cluster-b-10-166-0-26{1}:  AES_GCM_16_128, 0 bytes_i, 0 bytes_o, rekeying in 56 minutes
 submariner-child-submariner-cable-nmanos-cluster-b-10-166-0-26{1}:   <IP_ADDRESS>/32 <IP_ADDRESS>/19 === <IP_ADDRESS>/32 <IP_ADDRESS>/19
 submariner-cable-nmanos-cluster-b-10-166-0-26[2]: CONNECTING, <IP_ADDRESS>[%any]...<IP_ADDRESS>[%any]
 submariner-cable-nmanos-cluster-b-10-166-0-26[2]: IKEv2 SPIs: 99dc41f4c459ba83_i*<PHONE_NUMBER>000000_r
 submariner-cable-nmanos-cluster-b-10-166-0-26[2]: Tasks active: IKE_VENDOR IKE_INIT IKE_NATD IKE_CERT_PRE IKE_AUTH IKE_CERT_POST IKE_CONFIG CHILD_CREATE IKE_AUTH_LIFETIME

$ oc exec submariner-gateway-knc98 -n submariner-operator -- bash -c "swanctl --list-sas --uri unix:///var/run/charon.vici"

  submariner-cable-nmanos-cluster-b-10-166-0-26: #3, ESTABLISHED, IKEv2, e85d05d025f69511_i 80628238eb3932a7_r*
    local  '<IP_ADDRESS>' @ <IP_ADDRESS>[4501]
    remote '<IP_ADDRESS>' @ <IP_ADDRESS>[4501]
    AES_GCM_16-128/PRF_HMAC_SHA2_256/MODP_2048
    established 2s ago, rekeying in 13540s
    submariner-child-submariner-cable-nmanos-cluster-b-10-166-0-26: #1, reqid 1, INSTALLED, TUNNEL-in-UDP, ESP:AES_GCM_16-128
      installed 2s ago, rekeying in 3396s, expires in 3958s
      in  cbcbcf94,      0 bytes,     0 packets
      out c5a99d8a,      0 bytes,     0 packets
      local  <IP_ADDRESS>/32 <IP_ADDRESS>/19
      remote <IP_ADDRESS>/32 <IP_ADDRESS>/19
  submariner-cable-nmanos-cluster-b-10-166-0-26: #2, CONNECTING, IKEv2, 99dc41f4c459ba83_i*<PHONE_NUMBER>000000_r
    local  '%any' @ <IP_ADDRESS>[501]
    remote '%any' @ <IP_ADDRESS>[4501]
    active:  IKE_VENDOR IKE_INIT IKE_NATD IKE_CERT_PRE IKE_AUTH IKE_CERT_POST IKE_CONFIG CHILD_CREATE IKE_AUTH_LIFETIME

$ oc describe Gateway -n submariner-operator | grep "Ha Status:\s*active"

 Name:         ip-10-166-16-21
 Namespace:    submariner-operator
 Labels:       <none>
 Annotations:  update-timestamp:<PHONE_NUMBER>
 API Version:  submariner.io/v1
 Kind:         Gateway
 Metadata:
   Creation Timestamp:  2020-06-11T09:17:27Z
   Generation:          2
   Resource Version:    24899
   Self Link:           /apis/submariner.io/v1/namespaces/submariner-operator/gateways/ip-10-166-16-21
   UID:                 887479e9-20ce-45cf-a086-7407d95b25cc
 Status:
   Connections:
     Endpoint:
       Backend:      strongswan
       cable_name:   submariner-cable-nmanos-cluster-b-10-166-0-26
       cluster_id:   nmanos-cluster-b
       Hostname:     default-cl1-9vgwj-worker-bq8rt
       nat_enabled:  true
       private_ip:   <IP_ADDRESS>
       public_ip:    <IP_ADDRESS>
       Subnets:
         <IP_ADDRESS>/19
     Status:          connecting
     Status Message:  Connecting to <IP_ADDRESS>:4501
   Ha Status:         active
   Local Endpoint:
     Backend:      strongswan
     cable_name:   submariner-cable-nmanos-cluster-a-10-166-16-21
     cluster_id:   nmanos-cluster-a
     Hostname:     ip-10-166-16-21
     nat_enabled:  true
     private_ip:   <IP_ADDRESS>
     public_ip:    <IP_ADDRESS>
     Subnets:
       <IP_ADDRESS>/19
   Status Failure:
   Version:         v0.4.0-rc2
 Events:            <none>

$ subctl info

     Discovered network details:
         Network plugin:  OpenShift
         Service CIDRs: [<IP_ADDRESS>/16]
         Cluster CIDRs: [<IP_ADDRESS>/14]

Up until now I was watching the output of:
$ oc exec $submariner_pod strongswan stroke statusall | grep 'Security Associations \(1 up'
This works great, and makes the automation wait until strongswan associations came up, before continuing with submariner tests. It could take 3-10 minutes...
But now when Strongswan will not be the default cable-driver, how should we watch for Submariner readiness ?

@manosnoam Recently, subctl was enhanced to support some additional commands where we can get the status of connections/endpoints/gateways etc. Can you check if "subctl show connections" is suitable for your needs?
[sgaddam@localhost debug_job_Tests_10082020_0939]$ subctl show connections
GATEWAY                                       CLUSTER               REMOTE IP       CABLE DRIVER            SUBNETS                                 STATUS
default-cl1-ff6px-worker-kjg2n   nmanos-cluster-b  <IP_ADDRESS>    libreswan               <IP_ADDRESS>/19                         connected

@mangelajo, maybe if in addition to "HA Status active", you can show number of connections established ?
In another test I saw that the Gateway still shows "Status: connecting", even after StrongSwan is up:

Was this on the AWS Cluster? If so, yeah on AWS Cluster with Strongswan we do notice that the connection request from OnPremCluster to AWS will be in ESTABLISHED state but the connection request that is initiated from AWS to OnPremCluster will be in CONNECTING state as the connection cannot be established. However, the datapath works fine as it seems to use the ESTABLISHED connection.
CC: @skitt @nyechiel

Thanks @sridhargaddam
I've changed the tests order, so first I'm testing that the cable driver is ready, and then checking that HA status is active.
Works good, closing issue.


fix(inline): #426 concat lines with \n instead of   two spaces

Description

In this particular circumstance with a visual selection when running :CodeCompanion <write a promp> it will use this logic branch in the code to put together the markdown codeblock, but instead of concatenating the lines with a \n line break, it uses   two spaces. All other codecompanion features operate using \n. This PR makes it consistent with the rest of the plugin.
Related Issue(s)

Fixes #426

Screenshots

See linked gh issue for screenshots.
Checklist

[x] I've read the CONTRIBUTING guidelines and have adhered to them in this PR
[x] I've updated the README and ran the make docs command

@olimorris finally got around to submitting this :-) feel free to re-word depending on how you like to style conventional commits etc. Let me know if you have any questions.


Call load_from_checkpoint when trainer load state

🚀 Feature
When use Trainer class to load the model state instead of using load_from_checkpoint, the hook on_load_checkpoint won't be called. It's better to let trainer call load_from_checkpoint instead of directly call model.load_state_dict, thus on_load_checkpoint and other hooks can be called.
Motivation
I need to do some sanity check of saved hparams and I found the suitable location for this is on_load_checkpoint. But this method is not called when use Trainer to load states.

to me it makes sense call on_load_checkpoint inside load_from_checkpoint :]
@jeffling @hadim ano thoughts?

This is a good change, but we may want to think about the versioning here since it may break some codebases.

@PyTorchLightning/core-contributors any other thoughts?

I just hit this issue, and would love it in the next release!


Update Button in Proposal Status on Details Views

Feature
Proposal Details
App

Admin

Expected Behavior
Would expect the button text to be on a single line with more space between the button and text on left
Actual Behavior
Show Votes is broken onto two lines in the Voting in Progress phase
Steps to Reproduce

Create Issue Tokens proposal
Go into voting phase
View proposal details

Browser
No response
Screenshots and Context

Align the button with the top of the heading Voting in Progress
Do this for all phases (Submitted, Sponsored, Voting, Proposal Completion
Make sure the Show Votes text does not break onto two lines


Issue on compilation // Sodaq Explorer - 32 Bits - Cortex M0+

Hi,
I don't know if you're library is compatible with Cortex M0+ (SAMD21J18), it's board with  LoRa modem (Low Band), and bluetooth.
In first time, when i selected this type of board, the IDE put your library in not compatible directory, when i take a sample and i try to compile, i have this errors:
Compilation du croquis...
"/Users/pascalchignon/Library/Arduino15/packages/arduino/tools/arm-none-eabi-gcc/4.8.3-2014q1/bin/arm-none-eabi-g++" -mcpu=cortex-m0plus -mthumb -c -g -Os -w -std=gnu++11 -ffunction-sections -fdata-sections -fno-threadsafe-statics -nostdlib --param max-inline-insns-single=500 -fno-rtti -fno-exceptions -MMD -DF_CPU=48000000L -DARDUINO=10802 -DARDUINO_SODAQ_EXPLORER -DARDUINO_ARCH_SAMD  -D__SAMD21J18A__ -DUSB_VID=0x2341 -DUSB_PID=0x804d -DUSBCON '-DUSB_MANUFACTURER="SODAQ"' '-DUSB_PRODUCT="SODAQ ExpLoRer"' "-I/Users/pascalchignon/Library/Arduino15/packages/arduino/tools/CMSIS/4.5.0/CMSIS/Include/" "-I/Users/pascalchignon/Library/Arduino15/packages/arduino/tools/CMSIS-Atmel/1.1.0/CMSIS/Device/ATMEL/" "-I/Users/pascalchignon/Library/Arduino15/packages/SODAQ/hardware/samd/1.6.14/cores/arduino" "-I/Users/pascalchignon/Library/Arduino15/packages/SODAQ/hardware/samd/1.6.14/variants/sodaq_explorer" "-I/Users/pascalchignon/Documents/Arduino/libraries/SDI12" "/var/folders/b_/fzlgd0l12f79w7x8vsjv411w0000gn/T/arduino_build_659337/sketch/e_simple_parsing.ino.cpp" -o "/var/folders/b_/fzlgd0l12f79w7x8vsjv411w0000gn/T/arduino_build_659337/sketch/e_simple_parsing.ino.cpp.o"
In file included from /Users/pascalchignon/Documents/Arduino/libraries/Arduino-SDI-12-develop/examples/e_simple_parsing/e_simple_parsing.ino:57:0:
/Users/pascalchignon/Documents/Arduino/libraries/SDI12/SDI12.h:63:5: error: 'KINETISK_UART_t' does not name a type
KINETISK_UART_t   REG;
^
/Users/pascalchignon/Documents/Arduino/libraries/SDI12/SDI12.h: In constructor 'UART::UART()':
/Users/pascalchignon/Documents/Arduino/libraries/SDI12/SDI12.h:44:9: error: class 'UART' does not have any field named 'REG'
REG( nullptr ),
^
/Users/pascalchignon/Documents/Arduino/libraries/Arduino-SDI-12-develop/examples/e_simple_parsing/e_simple_parsing.ino: At global scope:
e_simple_parsing:60: error: invalid conversion from 'int' to 'Stream' [-fpermissive]
SDI12 mySDI12(DATAPIN);
^
In file included from /Users/pascalchignon/Documents/Arduino/libraries/Arduino-SDI-12-develop/examples/e_simple_parsing/e_simple_parsing.ino:57:0:
/Users/pascalchignon/Documents/Arduino/libraries/SDI12/SDI12.h:90:5: error:   initializing argument 1 of 'SDI12::SDI12(Stream*)' [-fpermissive]
SDI12( Stream *port ) {
^
If you hava an idea, of the problem, i need to do a POC, read a Aquacheck 4 probes ( 2 xTemp & 2 x humidity), and transfer this informations with the modem.
Regards,

I'm sorry for not getting to this yet.  I don't have a Sodaq Explorer, so I can only get as far as compiling for the board.
I am not getting any compilation errors for the SODAQ ExpLoRer in the Arduino.cc IDE when I use SODAQ SAMD Boards version 1.6.11 (which is the most recent version accessible in the boards manager).  Is that the IDE and the board version you are using?
I am getting errors when I try to use PlatformIO to compile, but not the same errors you are seeing.  If it is PlatformIO that's giving you trouble, try the Arduino IDE.

Just FYI, I raised an issue on the PlatformIO side, and it sounds like it is in the process of being fixed.  (https://github.com/platformio/platformio-pkg-framework-arduinosam/issues/2)
If your issue was with the Arduino.cc IDE, I'm kind-of stumped.

PlatformIO has been updated, fixing that issue and the Arduino.cc IDE also succeeds, so I'm closing this issue.  If you're still having trouble, let me know and I can reopen this.


Fix logprobs openai api

Motivation
When temperature is a small value like 0.01, the logprob may be -inf which cant not convert to json

fixed. LGTM


Format port errors for undefined values

Before: (note the very last line)
Uncaught Error: Port Error:
Regarding the port named 'setParagraphs' with type:

    List Quiz.Question.Paragraph

You just sent the value:

    undefined

but it cannot be converted to the necessary type.
Runtime error when sending values through a port.
Expecting an array but was given

After: (note the difference in the very last line)
Uncaught Error: Port Error:
Regarding the port named 'setParagraphs' with type:

    List Quiz.Question.Paragraph

You just sent the value:

    undefined

but it cannot be converted to the necessary type.
Runtime error when sending values through a port.
Expecting an array but was given undefined

@evancz this should be ready to merge now!

Looks good, thanks!


Render font variants / font-weights

There is no real explanation how I can render the font variants, let's say Open Source Sans Bold?
I can see in the react dev tools that I defined the variants in my "name" JSON object...
Any help would be appreciated.
Great plugin, works right out of the box!

Hi @nilsdenon, thanks!
You can specify the font variants which should be downloaded using the variants attribute in the options prop. Example:
<FontPicker
  apiKey={apiKey}
  activeFont={activeFont}
  onChange={nextFont => setActiveFont(nextFont.family)}
  options={{
    variants: ["900", "400"]
  }}
/>

The first variant specified in the array will automatically be applied to the font picker and the .apply-font class. If you'd like to use multiple variants in elements with the .apply-font class, you can simply override the default styles using CSS.
I'm currently working on a rewrite of the project and this should be a bit simpler in the next version :)


Remove tarsum support for digest package

tarsum is not actually used by the registry. Remove support for it.
Convert numerous uses in unit tests to SHA256.
Update docs to remove mentions of tarsums (which were often inaccurate).
Remove tarsum dependency.
@stevvooe @dmcgowan

LGTM

LGTM


Thank you :)

And yes, you can use env up to 30k, and the fps will continuely increase :)

Genesis is a great work! Hope it can keep updating and accelerate the research of embodied AI!


feat(core): add preset module to enable form config re-use

#3208
Please check if the PR fulfills these requirements

[x] The commit messages follow our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format
[x] A unit test has been written for this change.
[x] Running npm run build produced a successful build. (Unit testing can be done by running npm test;)
[x] My code has been linted. (npm run lint to do this. npm run build will fail if there are files not linted.)

Please provide a screenshot of this feature before and after your code changes, if applicable.
Other information:

Hi @aitboudad, I think this feature is pretty done.
I managed without an extra service, every thing is done in the extension and the formly config service.
I added a guide and an example as well as tests.
I have another PR in the pipeline where I make some changes and add more tests but it's kind of out of scope for this PR.

What do you think? :)

Looks good at the first sight, will check it further at the end of week and making a merge.
Thank you!

What do you think? :)

Looks good at the first sight, will check it further at the end of week and making a merge.
Thank you!

@aitboudad any updates?

Sorry due to lack of time 🙏, will try to force myself to check it late this week.

No don't worry, take your time. I just wanted to check in. Thank you so much for all the time you spend on formly 🙏 🙏

Thank you @MaxKless!


Add Orphanet to associations page facets

Can we please update the dataSources.js file to display "Orphanet" in the association page facets?
{ id: 'orphanet', label: 'Orphanet' }

closing issue as work done.


Portal links for main branch

Adds portal links for SQLDB creation in Resource Deployment extension

Pull Request Test Coverage Report for Build 256394353

0 of 3 (0.0%)  changed or added relevant lines in 1 file are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.006%) to 38.943%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

extensions/resource-deployment/src/ui/resourceTypePickerDialog.ts
0
3
0.0%

Files with Coverage Reduction
New Missed Lines
%

extensions/notebook/src/common/ports.ts
4
74.14%

Totals

Change from base Build 256278683:
-0.006%

Covered Lines:
19147

Relevant Lines:
44853

💛  - Coveralls


General node editor

resolves #576

SonarQube analysis reported 14 issues

 13 minor
 1 info

Watch the comments in this conversation to review them.
Top 10 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 AncientFungus:LGEPR: Cppcheck cannot find all the include files (use --check-config for details)
 Hymn.cpp#L172: Variable 'model' is assigned a value that is never used.
 RenderManager.cpp#L360: The function 'GetDirectionalLights' is never used.
 RenderManager.cpp#L399: The function 'GetMaterials' is never used.
 RenderManager.cpp#L417: The function 'GetMeshes' is never used.
 RenderManager.cpp#L437: The function 'GetPointLights' is never used.
 RenderManager.cpp#L458: The function 'GetSpotLights' is never used.
 RenderManager.cpp#L475: The function 'GetControllers' is never used.
 ResourceManager.hpp#L28: Member variable 'ResourceManager::rectangle' is not initialized in the constructor.
 ResourceManager.hpp#L28: Member variable 'ResourceManager::cube' is not initialized in the constructor.

SonarQube analysis reported 14 issues

 13 minor
 1 info

Watch the comments in this conversation to review them.
Top 10 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 AncientFungus:LGEPR: Cppcheck cannot find all the include files (use --check-config for details)
 Hymn.cpp#L172: Variable 'model' is assigned a value that is never used.
 RenderManager.cpp#L360: The function 'GetDirectionalLights' is never used.
 RenderManager.cpp#L399: The function 'GetMaterials' is never used.
 RenderManager.cpp#L417: The function 'GetMeshes' is never used.
 RenderManager.cpp#L437: The function 'GetPointLights' is never used.
 RenderManager.cpp#L458: The function 'GetSpotLights' is never used.
 RenderManager.cpp#L475: The function 'GetControllers' is never used.
 ResourceManager.hpp#L28: Member variable 'ResourceManager::rectangle' is not initialized in the constructor.
 ResourceManager.hpp#L28: Member variable 'ResourceManager::cube' is not initialized in the constructor.

SonarQube analysis reported 14 issues

 13 minor
 1 info

Watch the comments in this conversation to review them.
Top 10 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 AncientFungus:LGEPR: Cppcheck cannot find all the include files (use --check-config for details)
 Hymn.cpp#L172: Variable 'model' is assigned a value that is never used.
 RenderManager.cpp#L360: The function 'GetDirectionalLights' is never used.
 RenderManager.cpp#L399: The function 'GetMaterials' is never used.
 RenderManager.cpp#L417: The function 'GetMeshes' is never used.
 RenderManager.cpp#L437: The function 'GetPointLights' is never used.
 RenderManager.cpp#L458: The function 'GetSpotLights' is never used.
 RenderManager.cpp#L475: The function 'GetControllers' is never used.
 ResourceManager.hpp#L28: Member variable 'ResourceManager::rectangle' is not initialized in the constructor.
 ResourceManager.hpp#L28: Member variable 'ResourceManager::cube' is not initialized in the constructor.

Please don't review this yet.

Closing as this is part of #677


Filter on bool column not working properly in SQL Lab -> Explore

When a query in SQL Lab is executed and a filter is applied to a boolean column, it errors out on datatype comparison (boolean vs string).
Note - the behavior
Expected results
The filter should work - the generated query should not enclose the field value in single quotes.
Actual results
The query generated encloses the filter value in single quotes so the where clause generated looks (some_bool_flag = 'true') and this that in turn generates type mismatch
How to reproduce the bug

Go to SQL Lab -> SQL Editor
Write a query that returns a boolean column
Execute the query
Click on Explore
Scroll down to filters
Add a filter on a boolean column and make sure you stay in Simple (not Custom SQL)
Use equals and set filter value to "true" (without double quotes)
Execute the query to see the error messge
Click on menu -> View query to inspect that the filter value was enclosed in single quotes

Environment
(please complete the following information):

superset version: `superset version
0.34.1
python version: python --version
Python 3.6.9
node.js version: node -v
v12.18.0
npm version: npm -v
6.14.4

Checklist
Make sure these boxes are checked before submitting your issue - thank you!

[x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[ ] I have reproduced the issue with at least the latest released version of superset.
I have no control over the environment :(
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context
When the filter is entered using the Custom SQL instead of Simple, it works fine

Could you add the type of database, please?

It's presto and that particular query goes to hive

issue still persists on presto database. It's not possible to replicate for mysql as mysql interpret boolean as tinyint.
Selector looks like this:

Clicking on it results in:

@etr2460, @john-bodley  - curious if you have similar issue @ airbnb.

I see the same issue with Vertica DB. It does not show the option but if you choose the second one you have a TRUE but the first is empty. I work around by going to CUSTOM SQL but this should be resolved.

Maybe we need conditional operators based on data type. BOOLEAN should only offer IS NULL IS TRUE and  IS FALSE

@junlincc @zuzana-vej I wonder if we should prioritize this, i.e., not being able to filter on a boolean column using IS TRUE, IS FALSE etc. seems fairly problematic.

@john-bodley @zuzana-vej we will work on this issue next week!
@michael-s-molina @geido


Fix up terminology: Change instances of datagroup to datadir and data to datafile

We changed the term from datagroup to datadir, and data to datafile to more closely match what the items represent. The website still uses the old terminology in some spots.

To invasive at this point. Closing.


fix: decode url params

https://ossinsight-lite-git-fix-dashboard-404-pingcap.vercel.app/dashboards/github style

https://github.com/hooopo/repo-track-pipeline/pull/11 fix mysql://

White area on the right


improve README file

we need to:

explain the purpose of this repo
the organization of the repo
the ADI direcoty

@thiagomanel done!


[Impeller] Image drawn with MatrixImageFilter draws nothing at particular coordinates.

description
I noticed this bug when trying to reproduce https://github.com/flutter/flutter/issues/126583, it may be the same issue.
reproduction code
TEST_P(AiksTest, MatrixImageFilterMagnifyPan) {
  static uint64_t count = 0;

  auto callback = [&](AiksContext& renderer) -> std::optional<Picture> {
    Canvas canvas;
    canvas.Scale(GetContentScale());
    auto image = std::make_shared<Image>(CreateTextureForFixture("airplane.jpg"));
    Scalar x = 600 * sin(0.5 * 2.0 * 3.1415 * count / 60.0);
    Scalar y = 200 * sin(0.1 * 2.0 * 3.1415 * count++ / 60.0);
    canvas.Translate({x, y});
    canvas.SaveLayer({
        .image_filter = std::make_shared<MatrixImageFilter>(
            Matrix{
                2, 0, 0, 0,  //
                0, 2, 0, 0,  //
                0, 0, 2, 0,  //
                0, 0, 0, 1   //
            },
            SamplerDescriptor{}),
    });
    canvas.DrawImage(image, {0, 0}, Paint{.color = Color(1.0, 1.0, 1.0, 0.5)});
    canvas.Restore();
    return canvas.EndRecordingAsPicture();
  };

  ASSERT_TRUE(OpenPlaygroundHere(callback));
}

results
Notice that the plane image disappears when it gets to around x = -600.

cc @bdero

The image is 487px wide, it looks like it is winking out at -487px translation in the x direction.

When fixing the x,y offset to (-600, 0).  The stencil coverage rect is reported as (x:1200, y:0, w:2048, h:1536).  But the coverage of the image is reported as (x:0, y:0, w:974, h:756).
I haven't determined what the correct values for these should be yet.  Assuming the stencil coverage rect is right, the x component of the image should be 600.

The coverage rect for the image is still reported as (x:0, y:0, w:974, h:756) if the MatrixImageFilter is converted to 3x.  So that rect is not properly calculating it's global position based on the MatrixImageFilter but it isn't wholly local either since it is picking up 2x scale.

So, working backwards I can set the transform to what I know it should be in the GetCoverage.  This fixes the coverage rectangle.  But surprisingly it effects the contents that is actually getting drawn.

We are only tracking a vector3, global_pass_position, in order to convert from a passes coordinate space to it's global space.  That seems error-prone and we should instead just have the transform for the pass.  That may be the source of this problem.
So the code is
  if (const auto& entity = std::get_if<Entity>(&element)) {
    element_entity = *entity;
    element_entity.SetCapture(capture.CreateChild("Entity"));
    if (!global_pass_position.IsZero()) {
      // If the pass image is going to be rendered with a non-zero position,
      // apply the negative translation to entity copies before rendering them
      // so that they'll end up rendering to the correct on-screen position.
      element_entity.SetTransformation(
          Matrix::MakeTranslation(Vector3(-global_pass_position)) *
          element_entity.GetTransformation());
    }
  }

I think it may need to be:
  if (const auto& entity = std::get_if<Entity>(&element)) {
    element_entity = *entity;
    element_entity.SetCapture(capture.CreateChild("Entity"));
    if (!pass_to_global_transform.IsIdentity()) {
      // If the pass image is going to be rendered with a non-zero position,
      // apply the negative translation to entity copies before rendering them
      // so that they'll end up rendering to the correct on-screen position.
      element_entity.SetTransformation(
          pass_to_global_transform * // <-- This may not be tracked.
          element_entity.GetTransformation());
    }
  }

Okay, I think what is happening is we are making entities that in a coordinate space relative to their pass, but the coverage tests are trying to work in a global space.  That would mean GetCoverage would need to look at it's passes transform to calculate the space.  My concern is that transforms are getting baked and it won't be easy to extract the transforms we want.

Okay, I've been barking up the wrong tree.  The coverage problem isn't with drawing the image, it's with drawing the subpass.
The following hack makes the image draw correctly with translation {-600, 0}.
--- a/impeller/entity/contents/texture_contents.h
+++ b/impeller/entity/contents/texture_contents.h
@@ -75,6 +75,12 @@ class TextureContents final : public Contents {

   void SetDeferApplyingOpacity(bool defer_applying_opacity);

+  // | Contents|
+  bool ShouldRender(const Entity& entity,
+                    const std::optional<Rect>& stencil_coverage) const override {
+    return true;
+  }
+
  private:
   std::string label_;

Here is another hack that fixes the rendering.  This just gives up on the coverage test if a subpass is getting rendered:
--- a/impeller/entity/entity_pass.cc
+++ b/impeller/entity/entity_pass.cc
@@ -769,7 +769,8 @@ bool EntityPass::OnRender(
       current_clip_coverage->origin -= global_pass_position;
     }

-    if (!element_entity.ShouldRender(current_clip_coverage)) {
+    if (global_pass_position == Point(0, 0) &&
+        !element_entity.ShouldRender(current_clip_coverage)) {
       return true;  // Nothing to render.
     }

We could potentially change the math for how current_clip_coverage is calculated, but then it won't match the comments in the code about how it should work.
So the problem is that the stencil_clip_coverage is in global coordinates, and the coverage rect is in local coordinates.  They are both working as they describe themselves to be working.  We need to make one take into account the missing math without breaking existing calculations.


Editor crashes when attempting to rename node within BlendTree editor

Godot version
4.0.alpha9
System information
osx Monterey 12.3.1, Vulkan, MacBook Pro (14-inch, 2021
Issue description
Editor crashes when attempting to rename node within BlendTree editor.
Steps to reproduce
Create an AnimationTree
Add a BlendTree node
Edit the BlendTree
Add a OneShot (or any other) node
Click the text entry box to rename the new OneShot node
Editor hard crashes!
Minimal reproduction project
No response

Related to https://github.com/godotengine/godot/issues/58822 (possible duplicate?).

I have the same issue in 4.0 alpha 10. I'm also seeing the same behavior as in #58822. When a crash doesn't occur, the resulting name changes randomly or it changes to null. At times, the name of the previously selected node changes (to null or to some other name previously used by some other randomly chosen node) at the same time.
The name change seems to work more frequently when I tab out of the name field, but not always.

Duplicate of https://github.com/godotengine/godot/issues/58822.


Question: What is the correct allignment in SKY130? Intermediate Pins are not connected to the grid. Likely user mistake.

Describe the bug
Some  pins are not connected to the routing grid. In more detail, sometimes zero, one, or two intermediate pins are not connected.
Could be user error.
Version
OpenRAM 1.2.48
OpenLane 2
To Reproduce

Modify LEF to 1000 microns database unit as described here.
Instantiate a macro in openlane2, connect it, run synthesis, and fail at the verification step.
Macro is not connected to the power grid, yet.

I reproduced this bug using two different macros and locations. Different pins were disconnected. So, I guess no explicit conf file needs to be reproduced.
Expected behavior
Successfully connecting all pins to the memory macro.
Logs
Notice the pattern. Sometime zero skips, then one or two skips.

Non-functional:

Functional:

Questions:

Does the macro need to be manually aligned to a specification?
Or is this due to the 2:1 LEF unit scaling?

Your image suggests the LEF and connections are fine. I'm not sure what the issue is in the router.

Thanks for your quick response.
Yes, I noticed the connections are not always 100% centered within the pin area. But they look connected.
For example pin 0 does not look "perfect" (still visually looks connected). However, it raises the error.

Pins 1 & 2 look fine and are connected. Pin 3 looks fine, but is not connected.
I manually changed only the database microns in the LEF. I did not modify other values. The LEF and instantiation looks good to me.
I can send the exact positions if this helps.

Thanks again for your feedback.
I am still not sure what is really happening.
Another pin seems to be more offset, but does not raise an error.

I agree: Increasing pin size in GDS2 and LEF will be the resonable next step.
Just a sidenote: DFFRAM provides pins on another layer and connects without error.

I would also confirm with the router people why the error is there. These seem like perfectly good connections.

It would be helpful to turn on the routing grid in your images.

Instantiate a macro in openlane2, connect it, run synthesis, and fail at the verification step.

Is too vague.  Please make a standalone routing test case that shows the problem.

Thanks for the suggestion! I will prepare a standalone test, but need some days.
I activated the grid view in openroad, but I need to double-check if the grid settings correspond to the router grid settings from openlane2.

As suspected in the initial issue, I discovered this was a user error. Thanks for the responses so far.
My solution/approach:

The red macro connections to the macro are on the metal 4 layer. I have seen this in the openroad gui.

The non-modified default settings from the openlane2's openroad-globalrouting.log are:

[INFO GRT-0088] Layer li1     Track-Pitch = 0.4600  line-2-Via Pitch: 0.3400
[INFO GRT-0088] Layer met1    Track-Pitch = 0.3400  line-2-Via Pitch: 0.3400
[INFO GRT-0088] Layer met2    Track-Pitch = 0.4600  line-2-Via Pitch: 0.3500
[INFO GRT-0088] Layer met3    Track-Pitch = 0.6800  line-2-Via Pitch: 0.6150
[INFO GRT-0088] Layer met4    Track-Pitch = 0.9200  line-2-Via Pitch: 1.0400
[INFO GRT-0088] Layer met5    Track-Pitch = 3.4000  line-2-Via Pitch: 3.1100

The Track-pitch is defined as the minimum distance from track-center to track-center.

By moving the macro: The center of the leftmost pin is now at X-Position 138,46, which makes 138,46 / 0,92=150,5, matching the grid. The error is solved.

If my explanation is correct:
Maybe we should add this alignment explanation to the openlane2 and/or the OpenRAM documentation?

Moving the macro to the correct pin coordinate works only if the pins on the upper and lower sides both match to the routing grid. However, this does not always seem to be the case. Thus, the lower side io pins connect, but some upper side pins raise an error - as they mismatch the grid.

Yes, making the pins a bit bigger might ensure that all pins align in the center and the router doesn't give this error.

I am not sure which place is correct for implementing this modification.
As the add_io_pin function instantiates a power_pin, this looks like the correct place.
However, modifying it for example from
min_area = drc["minarea_{}".format(self.pwr_grid_layers[1])]
to
min_area = drc["minarea_{}".format(self.pwr_grid_layers[1])] *2
only scales all internally existing IO pins (marked in red), but does not scale the desired pins that actually connect the macro to the surrounding world (marked in blue).

How can I scale the "outer-world-pins"?


Current items in route

I want to add constraint that would calculate some value depending on current items already in the route. (Bin packing basically, which requires the knowledge of all items to be packed). The constraints added has the structure of def demand_evaluator(from_node, to_node): which doesn't contain previously selected items in the route. Is there a way to get that information?

What's about creating a new Dimension let's call it "Value" dimension to accumulate the value of items like a kind of capacity ?

Yes you are right, otherwise you may be "unfortunately" interested in issue #339

No, this is by design not possible.


DEV-38326; fix: filter insignificant whitespace matches

Add utility to filter insignificant whitespace matches

Code moved to internal repo


neocities.org and its websites break

For example, try open https://spyware.neocities.org

neocities.org was in CoinBlockerList. It seems, later it was narrowed to p2pool.neocities.org (or maybe it was my mistake). Of course, you are right, it is obvious false positive. Thanks.

Yep, but even with unblocked neocities.org some sites have broken css, look:

Sometimes all that blocking things are very useful (thank you for it) but I want to disable it for some websites. Do you know how can I make it?

Yes, general rule, removing backgrounds, sometimes misses. I made rules for that site. It is enough?
The site author wanted black page and white text, now it is vice versa :-) More readable, I think.

Thanks!

And one more correction for the footer text. Please update.


S3 too many requests

More details:
https://github.com/thephpleague/flysystem/issues/744
Write and update methods are the same, so we don't need to check if file exists:
https://github.com/thephpleague/flysystem-aws-s3-v3/blob/master/src/AwsS3Adapter.php#L117
https://github.com/thephpleague/flysystem-aws-s3-v3/blob/master/src/AwsS3Adapter.php#L131

Hi,
delete() also should not call has()

Closing this because the main repo fixed this problem.


VM: Detect broken/hung qemu process and reflect in LXD state output

This PR should help detect scenarios such as those in https://github.com/lxc/lxd/issues/7962 where the QMP monitor isn't reachable, but the qemu process is still running.
The way I've simulated this is to start a VM, then remove the qmp socket file, and restart lxd so that it cannot open a monitor connection. This simulates a broken/unreachable qemu process.
Fixes https://github.com/lxc/lxd/issues/7962

@stgraber I was thinking in such situations where the qemu process is hung and the qmp socket isn't reachable, should we update lxc stop -f to just kill the process referenced in qemu.pid, rather than trying to connect to the qmp socket?

@tomponline yeah, I think that'd be fine

@stgraber I was thinking in such situations where the qemu process is hung and the qmp socket isn't reachable, should we update lxc stop -f to just kill the process referenced in qemu.pid, rather than trying to connect to the qmp socket?

Unless I'm missing something, this has the (small) potential to kill random processes that happen to have the PID the VM had?

Testsuite passed


Problem when scrolling in angular-handsontable demo

When scrolling the demo at https://handsontable.github.io/angular-handsontable/examples/settings-object the scrolling seems to be bugged:

I'm using Linux Mint 18.2 with Firefox 55.0.2

Thank you @madoar. Now should be ok.

Yes, it's fixed now :)


Error at launch - invalid plist

Hello,
I downloaded the plist in my firebase project and put it in my root folder.
When I launch my app I get :
 Terminating app due to uncaught exception 'com.firebase.core', reason: '[FIRApp configure] could not find a valid GoogleServices-Info.plist in your project. Please download one from https://console.firebase.google.com/.'
Why could it be invalid ?

did you run cordova prepare after putting GoogleServices-Info.plist into the project?

I tried, it still doesn't work

The message is now : HelloCordova[2207:612538] Could not locate configuration file: 'GoogleService-Info.plist'.

are you using phonegap build?


Bump sdk_release_scripts lxml requirement to 4.6.5

Resolving a CG alert.

/check-enforcer override


Feature : Specify node version

Would be nice to be able to specify the node version to avoid a separate setup node action.

This action is only for bun not for node. Adding complexity just for avoiding setup-node is unnecessary. If you need nodejs in your workflow, use actions/setup-node


IsADirectoryError: [Errno 21] Is a directory

So what is this that is happening every time I try to run it using Runpod. Anyone?
Epoch 0:   4%| | 435/10100 [11:05<4:06:18,  1.53s/it, loss=0.427, v_num=0, trainHere comes the checkpoint...
Prunin' Checkpoint
Checkpoint Keys: dict_keys(['epoch', 'global_step', 'pytorch-lightning_version', 'state_dict', 'loops', 'callbacks', 'optimizer_states', 'lr_schedulers'])
Removing optimizer states from checkpoint
This is global step 435.
Training complete. max_training_steps reached or we blew up.
Traceback (most recent call last):
  File "main.py", line 867, in <module>
    trainer.fit(model, data)
  File "/opt/conda/lib/python3.7/site-packages/pytorch_lightning/trainer/trainer.py", line 771, in fit
    self._fit_impl, model, train_dataloaders, val_dataloaders, datamodule, ckpt_path
  File "/opt/conda/lib/python3.7/site-packages/pytorch_lightning/trainer/trainer.py", line 723, in _call_and_handle_interrupt
    return trainer_fn(*args, **kwargs)
  File "/opt/conda/lib/python3.7/site-packages/pytorch_lightning/trainer/trainer.py", line 811, in _fit_impl
    results = self._run(model, ckpt_path=self.ckpt_path)
  File "/opt/conda/lib/python3.7/site-packages/pytorch_lightning/trainer/trainer.py", line 1236, in _run
    results = self._run_stage()
  File "/opt/conda/lib/python3.7/site-packages/pytorch_lightning/trainer/trainer.py", line 1323, in _run_stage
    return self._run_train()
  File "/opt/conda/lib/python3.7/site-packages/pytorch_lightning/trainer/trainer.py", line 1353, in _run_train
    self.fit_loop.run()
  File "/opt/conda/lib/python3.7/site-packages/pytorch_lightning/loops/base.py", line 204, in run
    self.advance(*args, **kwargs)
  File "/opt/conda/lib/python3.7/site-packages/pytorch_lightning/loops/fit_loop.py", line 266, in advance
    self._outputs = self.epoch_loop.run(self._data_fetcher)
  File "/opt/conda/lib/python3.7/site-packages/pytorch_lightning/loops/base.py", line 204, in run
    self.advance(*args, **kwargs)
  File "/opt/conda/lib/python3.7/site-packages/pytorch_lightning/loops/epoch/training_epoch_loop.py", line 171, in advance
    batch = next(data_fetcher)
  File "/opt/conda/lib/python3.7/site-packages/pytorch_lightning/utilities/fetching.py", line 184, in __next__
    return self.fetching_function()
  File "/opt/conda/lib/python3.7/site-packages/pytorch_lightning/utilities/fetching.py", line 259, in fetching_function
    self._fetch_next_batch(self.dataloader_iter)
  File "/opt/conda/lib/python3.7/site-packages/pytorch_lightning/utilities/fetching.py", line 273, in _fetch_next_batch
    batch = next(iterator)
  File "/opt/conda/lib/python3.7/site-packages/pytorch_lightning/trainer/supporters.py", line 558, in __next__
    return self.request_next_batch(self.loader_iters)
  File "/opt/conda/lib/python3.7/site-packages/pytorch_lightning/trainer/supporters.py", line 570, in request_next_batch
    return apply_to_collection(loader_iters, Iterator, next)
  File "/opt/conda/lib/python3.7/site-packages/pytorch_lightning/utilities/apply_func.py", line 99, in apply_to_collection
    return function(data, *args, **kwargs)
  File "/opt/conda/lib/python3.7/site-packages/torch/utils/data/dataloader.py", line 652, in __next__
    data = self._next_data()
  File "/opt/conda/lib/python3.7/site-packages/torch/utils/data/dataloader.py", line 1347, in _next_data
    return self._process_data(data)
  File "/opt/conda/lib/python3.7/site-packages/torch/utils/data/dataloader.py", line 1373, in _process_data
    data.reraise()
  File "/opt/conda/lib/python3.7/site-packages/torch/_utils.py", line 461, in reraise
    raise exception
IsADirectoryError: Caught IsADirectoryError in DataLoader worker process 0.
Original Traceback (most recent call last):
  File "/opt/conda/lib/python3.7/site-packages/torch/utils/data/_utils/worker.py", line 302, in _worker_loop
    data = fetcher.fetch(index)
  File "/opt/conda/lib/python3.7/site-packages/torch/utils/data/_utils/fetch.py", line 49, in fetch
    data = [self.dataset[idx] for idx in possibly_batched_index]
  File "/opt/conda/lib/python3.7/site-packages/torch/utils/data/_utils/fetch.py", line 49, in <listcomp>
    data = [self.dataset[idx] for idx in possibly_batched_index]
  File "/workspace/Dreambooth-Stable-Diffusion/main.py", line 244, in __getitem__
    return tuple(d[idx] for d in self.datasets)
  File "/workspace/Dreambooth-Stable-Diffusion/main.py", line 244, in <genexpr>
    return tuple(d[idx] for d in self.datasets)
  File "/workspace/Dreambooth-Stable-Diffusion/ldm/data/personalized.py", line 67, in __getitem__
    image = Image.open(self.image_paths[i % self.num_images])
  File "/opt/conda/lib/python3.7/site-packages/PIL/Image.py", line 2953, in open
    fp = builtins.open(filename, "rb")
IsADirectoryError: [Errno 21] Is a directory: '/workspace/Dreambooth-Stable-Diffusion/regularization_images/style_ddim/.ipynb_checkpoints'

Some jupyter leftover folder. Something like this, executed anywhere before the training starts, should fix it:
!rm -rf /regularization_images/{dataset}/.ipynb_checkpoints
You can also do this via ssh if you want.

Thanks @nikolak I will try again using Runpod but funny thing is that Avast runs smooth and no errors at all. Maybe because I was using the Runpod community rentals and that could cause some weird issues? Not idea what I am saying here but the procedure was exactly the same on both providers. I might get a secure one next time because I still have credit there. If it happens again will use insert a cell before the training and run that to see if that problem goes away.


MB-7007 Update configuration of auto-approve plugin

Description
Starting Mar 1 a change to github actions started causing inconsistent
failures in the auto-approve job. This commit applies a fix mentioned in
the github issue on the auto-approve repo.
See https://github.com/hmarr/auto-approve-action/issues/183
Thanks to a tip from @chrisgilmerproj
https://github.com/transcom/mymove/pull/6098#issuecomment-797102346
Reviewer Notes
Not sure there is anything we can do beyond see if the job builds and actions still trigger.
Setup
None
Code Review Verification Steps

[X] Request review from a member of a different team.
[X] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change
this comment on a dependabot pr
this github issue on auto-approve explains more about the approach used.

Messages

:book:
:link: MB-7007

  Generated by :no_entry_sign: dangerJS against 782c4648dd44446a6d5bfa9aa9967efcd6f86d99

Happy to help ;)


DRILL-7056: Drill fails with NPE when starting in distributed mode & …

…31010 port is used
This occurs because during the WebServer.close() , one of the tasks for clean up is to delete the temp directory which never existed. This PR's fix does a check for that.

@kkhatua, please add the unit test (you may use TestGracefulShutdown.testDrillbitWithSamePortContainsShutdownThread as an example).
Also, in WebServer tmpJavaScriptDir is marked for deletion (tmpJavaScriptDir.deleteOnExit()) and this directory is also deleted in the close() method. Please either remove deleteOnExit() call or remove FileUtils.deleteDirectory(tmpJavaScriptDir);.
If FileUtils.deleteDirectory(tmpJavaScriptDir); will be left, I think it makes sence to replace it with FileUtils.deleteQuietly(tmpJavaScriptDir); to avoid possible errors in close() method.
And finally please order the methods in WebServer according to JCC, since getTmpJavaScriptDir() method is added before the constructor in your fix for DRILL-5735.

@vvysotskyi
I've made the changes and added a unit test. Please review

@vvysotskyi  please review the changes. I've merged the test into Graceful Shutdown tests as that class was the closest in terms of what we are testing.

@vvysotskyi  Done

Updated the PR.


Comments in use-blocks may vanish

When cargo fmt is run with the default configuration, comments in use-blocks may be removed unexpectedly.
cargo fmt --version
rustfmt 1.5.1-stable (d5a82bb 2023-02-07)

cat src/main.rs
use std::{
    /*
    io::{Read, Seek, Write},
    */
    path::{Path, PathBuf},
    // important stuff
};

fn main() {
    println!("Hello, world!");
}

cargo fmt -- --emit stdout
./src/main.rs:

use std::path::{Path, PathBuf};

fn main() {
    println!("Hello, world!");
}

Thanks for reaching out. Closing this as a duplicate of #4708


feat: add getTarget method to CloudMessage class

Hi,
I am building a package around this package, where a developer can set target to CloudMessage and my package will be consuming the class instance, but there is no way to retrieve the target.
I have added a method to retrieve the target, this will be a nice addition since there is already a hasTarget method is the class.
<?php

$message = CloudMessage::new()->withChangedTarget('topic', 'nice topic');

if($message->hasTarget()) {

 $target = $message->getTarget();
 // do something with target

}

Thanks.

This should be a pretty easy test to add. See [https://github.com/kreait/firebase-php/tree/6.x/tests/Unit/Messaging].

@MGatner
Test case has been a added :crossed_fingers:

The CloudMessage not meant to be used outside of the SDK. If it was added to the class, it would also have to be added to the Message interface, and I'm not prepared to do that "just" to satisfy a requirement outside of the scope of the SDK, which doesn't need it.
If I was to add this method, it would invite other requests to add getters for all the possible properties of a message, with the argument that this getter has been provided as well. I hope you can understand.
You could use the jsonSerialize() method (or, more safely, json_encode() + json_decode() the message) to then get the target out of it. An alternative would be to create your own implementation of the Message interface and wrap the CloudMessage inside it (e.g. with a _call() method to proxy the calls to the CloudMessage).
I'm not at the computer right now, but I can provide examples later if you need them.

Thanks, i like your suggestion to create my own implementation.


Flatbuffers Checksum Issue Building With Make

System information

No custom code
Windows 10
TensorFlow installed from source
TensorFlow current version

Describe the current behavior
Using make to build Tensorflow Lite example projects fails using make for several projects. On Windows, setting command prompt to the tensorflow repository directory, and following the README for tensorflow\lite\micro\examples\magic_wand:
make -f tensorflow/lite/micro/tools/make/Makefile test_magic_wand_test
That produces the following results:
C:\Users\jtork\CMake\tensorflow_src>make -f tensorflow/lite/micro/tools/make/Makefile test_magic_wand_test
FIND: Parameter format not correct
FIND: Parameter format not correct
--2021-02-28 19:42:41--  http://mirror.tensorflow.org/github.com/google/flatbuffers/archive/dca12522a9f9e37f126ab925fd385c807ab4f84e.zip
Resolving mirror.tensorflow.org (mirror.tensorflow.org)... <IP_ADDRESS>, 2607:f8b0:4023:1000::80
Connecting to mirror.tensorflow.org (mirror.tensorflow.org)|<IP_ADDRESS>|:80... connected.
HTTP request sent, awaiting response... 200 OK
Length: 1760478 (1.7M) [application/zip]
Saving to: '/tmp/dca12522a9f9e37f126ab925fd385c807ab4f84e.zip'

/tmp/dca12522a9f9e37f126ab925 100%[=================================================>]   1.68M  8.87MB/s    in 0.2s

2021-02-28 19:42:41 (8.87 MB/s) - '/tmp/dca12522a9f9e37f126ab925fd385c807ab4f84e.zip' saved [1760478/1760478]

/tmp/dca12522a9f9e37f126ab925fd385c807ab4f84e.zip: line 1: $'PK\003\004': command not found
/tmp/dca12522a9f9e37f126ab925fd385c807ab4f84e.zip: line 2: nL8Q5: command not found
/tmp/dca12522a9f9e37f126ab925fd385c807ab4f84e.zip: line 3: nL8Q?: command not found
/tmp/dca12522a9f9e37f126ab925fd385c807ab4f84e.zip: line 4: $'\bnL8Qw\030B\005\352\002\304\005V': command not found
/tmp/dca12522a9f9e37f126ab925fd385c807ab4f84e.zip: line 4: $'\367\257XY': command not found
/tmp/dca12522a9f9e37f126ab925fd385c807ab4f84e.zip: line 5: $'\002T': command not found
/tmp/dca12522a9f9e37f126ab925fd385c807ab4f84e.zip: line 5: $'v\355\236\215\265M4\036w]\027\262\036p\250t5\256\367\245f': command not found
/tmp/dca12522a9f9e37f126ab925fd385c807ab4f84e.zip: line 5: $'\225L\347\313l\036\020\350\341\320\265\254\3218\002~\264B\323\302\371\016XC\2408\313': command not found
/tmp/dca12522a9f9e37f126ab925fd385c807ab4f84e.zip: line 5: $'@\244\315\217\v\2105': command not found
/tmp/dca12522a9f9e37f126ab925fd385c807ab4f84e.zip: line 5: $'\301\2173H2\037.\342,\311N\223\233d}\231^\257\341': command not found
/tmp/dca12522a9f9e37f126ab925fd385c807ab4f84e.zip: line 5: $'^\255\342\345:\231g\220\256': command not found
/tmp/dca12522a9f9e37f126ab925fd385c807ab4f84e.zip: line 5: $'m\237\220Q7\037\324\242\304R\234R\372T\235\317k\347T\347\316\334\235\353F\352\217g\317q': command not found
/tmp/dca12522a9f9e37f126ab925fd385c807ab4f84e.zip: line 5: 6□m@0□cs/d□□ □j☼□4□E)8□&□□□z@-i#hPo□q□→☻X□6□□
□l□□▼{□□A♂y+□□□→□□□Ff□‼%□□3⌂2□□܇□5□s□□D%→k<□Ȃ§J□□□↔W♣□9□►□0□ub♦OO□□□_□ɕ□@□□Y→□0□!□↓□m□□b□Ѫh□R□(K□H□2@L□90j□□63J□^%,□G□□j-\□□↓♦☺liW□□□A♀□27/□1□□□∟U□e☺'□j♀Yk§□u9□□□#□3□(lඤ□d7□□□Z4K▬□Ez□□y}□]O□□,□m⌂'>!□(□}□□□□►□W□t§□□⌂|^□□□8□□Zu□↕□∟v{♫□♠□Jt+{ߐ%^□□k<~.□ـ□Z46♦□□v9□□   ↕□□v□□Z□Ԋ□ݏܲ{7□oȽ♦□⌂)♀‼H\□/     □e▼□C□w□□@□□□□□☼□□B2□#-{♥□□0□□□□□l>9�□t)□□s↓↑_□□P2□     PK♥♦
/tmp/dca12522a9f9e37f126ab925fd385c807ab4f84e.zip: line 11: $'OO\337\367\312\262\204\0365\3341P]\034\327\025ZL4\237t\364]r\363\024c\020\202\216\214?h\210\254N\326\b\a\275\221z]P\022\301c\177\346\2608\274\350\234\3230tl4y\006\244\272h.y\371\214i\201,': command not found
nL8Q>   flatbuffers-dca12522a9f9e37f126ab925fd385c807ab4f84e/.bazelci/UT♣☺□□l_PK♥♦
nL8Q=□!X□K      flatbuffers-dca12522a9f9e37f126ab925fd385c807ab4f84e/.bazelci/presubmit.ymlUT♣☺□□l_□□□□J*□□I□L□L-□R□I,I-.□*□i□E□□V
□I□y%□□f♠& □□☻X}|IbQzjI1DHWAIOOO        □♠↓□K▬j□♣§□□ML□/□□¶PK♥♦
nL8Q□4%_□0☺B    flatbuffers-dca12522a9f9e37f126ab925fd385c807ab4f84e/.clang-formatUT♣☺□□l_m□Mn□@♀□□>♣↨)[v►□□*RP□♣\p♠+□y□n□Q⌂□E□: No such file or directory
/tmp/dca12522a9f9e37f126ab925fd385c807ab4f84e.zip: line 11: $'\034Z\303\211\346\236\223\377\b\277\211\215l\270\247\326\b\257ot[\005\235:\232\004\235\243\246\277\231\304m\242\3711\277\356\361\235$\235\264\031Y\363\351\2365\363\334\356\004\343\232-_\346_\332+\355[\264\371\021\324J\234\256\377B\252\252\002\370\004PK\003\004': command not found
/tmp/dca12522a9f9e37f126ab925fd385c807ab4f84e.zip: line 12: $'\bnL8Q\33088\322\236\337B': command not found
/tmp/dca12522a9f9e37f126ab925fd385c807ab4f84e.zip: line 13: $'\302@\020D\373': command not found
/tmp/dca12522a9f9e37f126ab925fd385c807ab4f84e.zip: line 16: $'\021\301\336\316\322?\020': command not found
/tmp/dca12522a9f9e37f126ab925fd385c807ab4f84e.zip: line 16: r□□□□▲T↑□bLl□XN□□□QtK*◄4: No such file or directory
/tmp/dca12522a9f9e37f126ab925fd385c807ab4f84e.zip: line 16: $'\202\v%Q\256\253\333\341^\211ulh': command not found
/tmp/dca12522a9f9e37f126ab925fd385c807ab4f84e.zip: line 17: $'f\345eey\206\310?S\336\253wZ\270pF\223\304\2026\306\3236\375{\351\003PK\003\004': command not found
/tmp/dca12522a9f9e37f126ab925fd385c807ab4f84e.zip: line 18: $'\bnL8Q\324\240P3\211\375A': command not found
/tmp/dca12522a9f9e37f126ab925fd385c807ab4f84e.zip: command substitution: line 19: syntax error near unexpected token `)'
/tmp/dca12522a9f9e37f126ab925fd385c807ab4f84e.zip: command substitution: line 19: `☻1♀D□□□□▬▬□□□□⌂□▲d□mJ□□.□□[□^ĝ3o↕=☻&♦9bxB □0j□<□□□□k$□♦↨x)(b"1 □□P□x□□l'
/tmp/dca12522a9f9e37f126ab925fd385c807ab4f84e.zip: line 16: $'\305\202\205\270\312\0261\315\274\304RT\373t\363\206\036t\371\261\204d\340V\327\257v\230\036\236\332\300U0\330_\246\345\f\343L\336\027\027mg\252\333\256\230\235g\376\201I\275\317\037PK\003\004': command not found
/tmp/dca12522a9f9e37f126ab925fd385c807ab4f84e.zip: line 17: $'\bnL8Q\026\345\365\275OUC': command not found
/tmp/dca12522a9f9e37f126ab925fd385c807ab4f84e.zip: line 18: $'\200': command not found
/tmp/dca12522a9f9e37f126ab925fd385c807ab4f84e.zip: line 18: $'\365\370\243\371PK\003\004': command not found
/tmp/dca12522a9f9e37f126ab925fd385c807ab4f84e.zip: line 19: flatbuffers-dca12522a9f9e37f126ab925fd385c807ab4f84e/.github/UT♣☺□□l_PK♥♦: No such file or directory
/tmp/dca12522a9f9e37f126ab925fd385c807ab4f84e.zip: line 20: syntax error near unexpected token `('
/tmp/dca12522a9f9e37f126ab925fd385c807ab4f84e.zip: line 20: nL8Q}□□□B☻N flatbuffers-dca12522a9f9e37f126ab925fd385c807ab4f84e/.github/ISSUE_TEMPLATE.mdUT♣☺□□l_U□AO□0♀□□□§o□□(□□v@∟ABp☻  ♫H□♫^□□□Ҥ□]`□▲□C□I□!□□□=□□□□□!□hr□□□>□□Ԃ↕□□□♂□^#□0zڳU¶□□C□q□↓□1↕□,□□|□□a□\#RjGj□B.+□□☼!r□'↨     9y□B□□∟D□?KR□□↑I□GkX□$g□‼B9☻B□F^9□□♣A□q►□□□u□□□¶□1□□□bj□↓1□=HO□□□□□□,□□□!▲-□9□G□s□→☼□□□W□      □=□L□□□□<\]Uh□□zu[□□▼□□□□□□□S□7□dvT@↑JּeY□      ∟□      q)Z□□r□□□♦□;□□򑱡 ↑□♠,□٠nV□□sϿ□□6□□□□{4=;□I♫%□▲□f□□□□☺PK♥♦'
tensorflow/lite/micro/tools/make/Makefile:525: *** Something went wrong with the flatbuffers download: Bad checksum. Expected: aa9adc93eb9b33fa1a2a90969e48baee, Got: .  Stop.

I believe this same issue occurs for all make options I have tried.
Describe the expected behavior
All dependencies should be resolved and the project should build.

@embeddetech,
Please go through these comments from similar issues #46916 and #46936 and check if it helps. Thanks!

Thank you @amahendrakar , I see that there appears to not be a Windows build solution for a TFLite for Microcontrollers project. Will it be possible to create/repair a functioning Micro project build so as to have at least a single reference?
Note that I am currently able to CMake TFLite as of today. However I am not exactly clear the distinction between TensorFlow Lite and Tensorflow Lite for Microcontrollers. A minimal build in Windows for Tensorflow Lite for Microcontrollers would be enormously helpful! Coming in from Windows, having to go through a Docker learning curve and work in Linux would be somewhat tedious...

Could you please try again with the latest Tensorflow version, the above micro related files have been moved to separate repository tensorflow/tflite-micro.
You can find the details on the magic_wand examples here.


[SEDONA-102] Use spotless as Java and Scala code formatter

Did you read the Contributor Guide?

Yes, I have read the Contributor Rules and Contributor Development Guide

Is this PR related to a JIRA ticket?

Yes, the URL of the associated JIRA ticket is https://issues.apache.org/jira/browse/SEDONA-102. The PR name follows the format [SEDONA-XXX] my subject.

What changes were proposed in this PR?
Use spotless to format Java and Scala code. Format is checked when running mvn compile, code can be automatically formatted by running mvn spotless:apply command.
How was this patch tested?
Passing existing tests.
Did this PR include necessary documentation updates?

Yes, I have added the mvn spotless:apply step to the contribution rule.

Let's put a hold on this. A big batch of ST functions will be cherry picked from Wherobots to Apache Sedona next week 😁

Let's put a hold on this. A big batch of ST functions will be cherry picked from Wherobots to Apache Sedona next week 😁

Have we finished cherry-picking ST functions? Is it OK to enable spotless for now?

Yes, it's all done. Let's enable Spotless @Kontinuation


put a limit on player stats.

Intended to solve Issue #47 and prevent the abuse @wildlovelies pointed out with Cyborg especially.
Can I get a Shipit?

review changes made. Can I get a re-review and maybe a shipit?


Clean up flagged code

We have a large amount of code which is unused once
flags have flipped. This change removes it all.
Closes #
Changes proposed in this pull request:

...

Rebasing appears to break PRs when the difference is this big. Will close and rebuild


Incorrect positioning of fields on Mac Retina

Operating system or device - Godot version:
Mac OS X 11.6, Retina Mac Book Pro running at highest scale setting (though other scale settings have same behaviour)
Godot 2.1 and 2.1.1 RC
Issue description (what happened, and what was expected):
Object seem wrongly positioned or too large, for instance the preview button for the selected camera:

http://s95.photobucket.com/user/Mux213/media/Preview hidden.png.html
Popup for entering coordinates/rotations has text overlapping:

http://s95.photobucket.com/user/Mux213/media/Coordinate popups.png.html
Saw some more in other places but most likely all the same cause. It must be getting sizing info wrong from somewhere.
Steps to reproduce:
Just open the interface :)
Link to minimal example project (optional but very welcome):

Still valid?

Just did a fresh build from Master, yup still valid

First of all thank you for your report and sorry for the delay.
We released Godot 3.0 in January 2018 after 18 months of work, fixing many old issues either directly, or by obsoleting/replacing the features they were referring to.
We still have hundreds of issues whose relevance/reproducibility needs to be checked against the current stable version, and that's where you can help us.
Could you check if the issue that you described initially is still relevant/reproducible in Godot 3.0 or any newer version, and comment about it here?
For bug reports, please also make sure that the issue contains detailed steps to reproduce the bug and, if possible, a zipped project that can be used to reproduce it right away. This greatly speeds up debugging and bugfixing tasks for our contributors.
Our Bugsquad will review this issue more in-depth in 15 days, and potentially close it if its relevance could not be confirmed.
Thanks in advance.
Note: This message is being copy-pasted to many "stale" issues (90+ days without activity). It might happen that it is not meaningful for this specific issue or appears oblivious of the issue's context, if so please comment to notify the Bugsquad about it.

I'm pretty sure this has been fixed a long time ago.


dev: Calldata update process

Flow:

Hyperlane dispatch -> DispatchEvent, with a list of updateData
Form message id from message
Find correspondance in the checkpoint storage
if matches updates store with updateData and message_feed id

User flow:

Users call the api endpoint with the feed_id
Since stored with feed_id, just return associate infos

TODO:

[ ] function to


How should we we bucket user input?

Cluster = Cluster* | Commodity* | Vehicle*
Recursive definition of a cluster, contains zero of more clusters, commodities, and/or vehicles. Permissions cascade down clusters, once granted, goes forever.
API access would look something like client.cluster('foo/bar/baz').addCommodity(), or .getRoute(). It's important that the clusters can be created on the fly, and that if someone creates 'foo/bar/baz' that 'foo' and 'foo/bar' are also created appropriately.

This was completed. :rocket:


Changing the type of a primary key doesn't result in a valid migration.

Steps to reproduce

Create a new two-table code-first schema:public class Product
{
	[Key]
	public Guid Id { get; set; }
	public List<Tag> Tags { get; set; }
}

public class Tag
{
	[Key]
	public Guid Id { get; set; }
}

Create and apply an initial migration to SQL Server (Azure DB).
Change the type of both Id columns to Int32 in code.
Create a new migration.
Attempt to apply the migration.  NOTICE that the migration fails because it didn't correctly remove and re-create the indexes and foreign keys.

The issue
Describe what is not working as expected.
If you are seeing an exception, include the full exceptions details (message and stack trace).
System.Data.SqlClient.SqlException: The index 'IX_Tags_ProductId' is dependent on column 'ProductId'.
The object 'FK_Tags_Products_ProductId' is dependent on column 'ProductId'.
ALTER TABLE ALTER COLUMN ProductId failed because one or more objects access this column.
   at System.Data.SqlClient.SqlConnection.OnError(SqlException exception, Boolean breakConnection, Action`1 wrapCloseInAction)
   at System.Data.SqlClient.TdsParser.ThrowExceptionAndWarning(TdsParserStateObject stateObj, Boolean callerHasConnectionLock, Boolean asyncClose)
   at System.Data.SqlClient.TdsParser.TryRun(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject stateObj, Boolean& dataReady)
   at System.Data.SqlClient.SqlCommand.RunExecuteNonQueryTds(String methodName, Boolean async, Int32 timeout, Boolean asyncWrite)
   at System.Data.SqlClient.SqlCommand.InternalExecuteNonQuery(TaskCompletionSource`1 completion, String methodName, Boolean sendToPipe, Int32 timeout, Boolean asyncWrite)
   at System.Data.SqlClient.SqlCommand.ExecuteNonQuery()
   at Microsoft.EntityFrameworkCore.Storage.Internal.RelationalCommand.Execute(IRelationalConnection connection, String executeMethod, IReadOnlyDictionary`2 parameterValues, Boolean openConnection, Boolean closeConnection)
   at Microsoft.EntityFrameworkCore.Storage.Internal.RelationalCommand.ExecuteNonQuery(IRelationalConnection connection, IReadOnlyDictionary`2 parameterValues, Boolean manageConnection)
   at Microsoft.EntityFrameworkCore.Storage.Internal.RelationalCommandExtensions.ExecuteNonQuery(IEnumerable`1 commands, IRelationalConnection connection)
   at Microsoft.EntityFrameworkCore.Migrations.Internal.Migrator.Execute(IEnumerable`1 relationalCommands)
   at Microsoft.EntityFrameworkCore.Migrations.Internal.Migrator.Migrate(String targetMigration)
   at Microsoft.EntityFrameworkCore.Design.MigrationsOperations.UpdateDatabase(String targetMigration, String contextType)
   at Microsoft.EntityFrameworkCore.Tools.Cli.DatabaseUpdateCommand.<>c__DisplayClass0_0.<Configure>b__0()
   at Microsoft.Extensions.CommandLineUtils.CommandLineApplication.Execute(String[] args)
   at Microsoft.EntityFrameworkCore.Tools.Cli.Program.Main(String[] args)
ClientConnectionId:b1c447f8-9278-4912-aa5d-a0630579e398
Error Number:5074,State:1,Class:16
The index 'IX_Tags_ProductId' is dependent on column 'ProductId'.
The object 'FK_Tags_Products_ProductId' is dependent on column 'ProductId'.
ALTER TABLE ALTER COLUMN ProductId failed because one or more objects access this column.

Further technical details
EF Core version: 1.0.0-rc2-final
Operating system: Windows 10
Visual Studio version: VS 2015
Other details about my project setup:
"Microsoft.EntityFrameworkCore.Tools": "1.0.0-preview1-final",

Note: there are other problems with this migration that I don't reasonably expect Entity Framework to solve for me (though it would be cool if it did).  However, the error I got was one that could occur with any kind of type change, not just GUID to INT.

This is one of many scenarios that would be unblocked by the wider "table rebuilds" feature (https://github.com/aspnet/EntityFramework/issues/329). Closing this issue as we are tracking all of them via #329