Migrate all stylus styles to sass

We currently have at least 2 style engines utilized: sass and stylus. There is no need in stylus as we have sass already. We need to migrate all styles to sass to be able to customize theme colors in the future
Some examples:
https://github.com/bitcartcc/bitcart-store/blob/ca1ba4e8d782999c9c02e46fbddf9ec806dd6bfb/components/Switch.vue#L24-L26
https://github.com/bitcartcc/bitcart-store/blob/8909d56c7c2cf431ae93e8b97958a418cd3aa366/pages/index.vue#L53-L68
https://github.com/bitcartcc/bitcart-store/blob/8909d56c7c2cf431ae93e8b97958a418cd3aa366/components/Sidebar.vue#L64-L101
Also any improvements to the existing files are welcome!

Hey, I could take a look at this issue if it's alright with you?

Sure! Thank you very much

@MaximeKoitsalu Did you have any problems with setting it up?
It requires our merchants api instance running (from main bitcart repository).
You have two ways:

Use our demo api instance to just test UI changes

export BITCART_STORE_API_URL=https://api.bitcartcc.com
yarn dev

Run merchants api locally (I do it this way, but I often make changes in both projects, for UI changes it is not required): see https://github.com/bitcartcc/bitcart/blob/master/CONTRIBUTING.md#setting-up-python-development-environment

Let me know if it was not very obvious/undocumented. Also I guess a better error message should be displayed when merchants api is not accessible. Will open a separate issue for that

Thanks for the guide, I haven't gotten to it yet but will get to it tomorrow 🙏

Fixed by #321


Azure Synapse Analytics is mislabeled.  This should be Azure Synapse DW.

I'm not sure the diagram shown on the page reflects the actual product features and capabilities correctly.  For a start, Azure Synapse Analytics seems to be in the "model and serve" zone, but I think that should be shown as Azure Synapse DW (not Analytics).  The diagram also shows Data Bricks and Data Factory which are now part of Azure Analytics.  So That seems to be wrong also.  Why would you have DB and DF if you have Azure Synapse Analytics.  My guess is that the article is from last year before the Azure Synapse branding and features were fully defined.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2ac60d9e-b851-afa6-beeb-74cdaa2a9146
Version Independent ID: e300615f-1b32-df63-bc89-54b3b17dced5
Content: Modern Data Warehouse Architecture - Azure Solution Ideas
Content Source: docs/solution-ideas/articles/modern-data-warehouse.md
Service: architecture-center
Sub-service: solution-idea
GitHub Login: @doodlemania2
Microsoft Alias: pnp

Thanks for reporting - this issue is under review.  This is a Microsoft Internal DevOps Bug ID AB#322643

This article has been updated: https://docs.microsoft.com/en-us/azure/architecture/solution-ideas/articles/enterprise-data-warehouse
Thank you!


Add new ietf softwire schemas

This PR adds the ietf-softwire-common and ietf-softwire-br schemas from https://tools.ietf.org/html/draft-ietf-softwire-yang-02.  As part of that, it adds support for the refine YANG statement, which is a facility used by this new schema that we hadn't needed before.

No idea why the intel_mp test did not work, in any case it's irrelevant AFAIU


Tree-View In Superset: Is this possible? If yes, please guide.

I have a requirement where we want a visualization showing TREE-VIEW(Like Hierarchy). If we click on a tab, it should branch out into sub-components, looking like a tree.

It would be useful to me too.

#metoo

count me in

I think now it's time to some contributing from people here. Maybe I will pick that requirement and try to implement a viz plugin as a learning project.

I think now it's time to some contributing from people here. Maybe I will pick that requirement and try to implement a viz plugin as a learning project.

@caiobelfort we would love your contribution! if you are on slack, please reach out to me

I think now it's time to some contributing from people here. Maybe I will pick that requirement and try to implement a viz plugin as a learning project.

@caiobelfort we would love your contribution! if you are on slack, please reach out to me

@caiobelfort we would love your contribution! if you are on slack, please reach out to me

I think now it's time to some contributing from people here. Maybe I will pick that requirement and try to implement a viz plugin as a learning project.

@caiobelfort we would love your contribution! if you are on slack, please reach out to me

Well, don't expected this to be fast. I will use as opportunity to reforge my javascript skills.


Error when joining server with Floodgate

Upon joining the server, I lose connection with the message "{0}" and a very strange error appears in the log, which makes me think there's some issue with the class paths.
[15:21:24] [Server thread/INFO]: /<IP_ADDRESS>:58727 lost connection: Internal Exception: java.lang.NoSuchMethodError: it.unimi.dsi.fastutil.ints.Int2ObjectMap.computeIfAbsent(ILit/unimi/dsi/fastutil/ints/Int2ObjectFunction;)Ljava/lang/Object;

Generated log: latest.log

Should be fixed in the latest build.


There may be a memory leak

There may be a memory leak

I fix it, may solve the problem.

@LightNightCode
I think the version you're using is old.


Viztracer result becomes wrong after some pytorch function call with exclude_files

Environment
torch 2.5.1, python 3.11.10, ubuntu 22.04
Problem
I don't need trace results inside torch.export module, so I use exclude_files to ignore it. The problem is if I trace with exclude_files, after calling torch.distributed.pipelining.pipeline, trace result of following calls only keep stack depth <= 4 result.
with exclude_files:

without exclude_files:

Reproduce

install pytorch >= 2.5

get exclude_files by import torch.export; print(torch.export.__file__)

launch viztracer with following script and command:

import torch
import torch.export
from torch.distributed.pipelining import pipeline
from torch.distributed.pipelining import SplitPoint
in_dim = 16
C = 64
HIDDEN = 256
layer_dims = [C] * 8
out_dim = 10
STAGE = 8

class MyNetworkBlock(torch.nn.Module):
    def __init__(self, in_dim, out_dim):
        super().__init__()
        mid_dim = HIDDEN
        self.lin1 = torch.nn.Conv2d(in_dim, mid_dim, 3, padding=1)
        self.lin2 = torch.nn.Conv2d(mid_dim, mid_dim, 3, padding=1)
        self.lin3 = torch.nn.Conv2d(mid_dim, out_dim, 3, padding=1)

    def forward(self, x):
        x = self.lin1(x)
        x = torch.relu(x)
        x = self.lin2(x)
        x = torch.relu(x)
        x = self.lin3(x)
        x = torch.relu(x)
        return x

class MyNetwork(torch.nn.Module):
    def __init__(self):
        super().__init__()
        self.num_layers = len(layer_dims)

        prev_dim = in_dim
        for i, dim in enumerate(layer_dims):
            super().add_module(f"layer{i}", MyNetworkBlock(prev_dim, dim))
            prev_dim = dim
        self.output_proj = torch.nn.Conv2d(layer_dims[-1], out_dim, 3, padding=1)

    def forward(self, x):
        for i in range(self.num_layers):
            layer = getattr(self, f"layer{i}")
            x = layer(x)

        return self.output_proj(x)

print(torch.export.__file__)
example_input = torch.randn(16, in_dim, 240, 320)

split_spec = {}
for j in range(STAGE - 1):
    split_spec[f"layer{j}"] = SplitPoint.END

pipe = pipeline(MyNetwork(), mb_args=(example_input,), split_spec=split_spec)

# after pytorch pipeline, the trace result (stack depth) of viztracer becomes wrong,
# we can only see results with stack depth <= 4.
class A:
    def a(self):
        print("a")
        self.b()
    def b(self):
        print("b")
        self.c()

    def c(self):
        print("c")
        self.d()
    def d(self):
        print("d")
        self.e()
    def e(self):
        print("e")
        # self.f()

a = A()
a.a()

viztracer --exclude_files /path/to/torch/export --max_stack_depth 15 /path/to/script.py

Which version of viztracer are you using? I can't repro this on 3.12, the stack looks fine. To be honest, I don't recommend the --exclude_files command for heavy filtering. The command itself has a relatively large overhead. It's helpful for understanding the code, but might be a bit slow for profiling.

I tried on python 3.11/3.12 on Mac OS, this problem exists on python 3.11, OK on 3.12.
I convert result from viztracer to tree view and tree filtering to analysis complex project such as PyTorch, the tree filtering is done in frontend and become slow if number of entries larger than 100000, so I need exclude_files  to reduce size. Another option is remove them after tracing, maybe slower than exclude_files since your code handle this in C.

Okay it only repros on 3.11, interesting. I can try to repro it and see if it's a VizTracer issue. For the latest version of Perfetto, you can just select the part you need and do a flamegraph, not sure if it's helpful. Removing after tracing is not as fast, but it does not use your program time so your result would be more accurate. If you can narrow down your interest area, log_sparse would be very helpful to reduce the entries.

I believe I found the issue, and I'll fix it soon.


BUG- selector with multiple items doesn't respect width and doesn't display label

Description
If using the selector control, there are 2 problems I have found when you specify  multiple=True or dropdown=False

If you specify a label, the label does not appear
If you specify width, the width is not respected.

How to reproduce
from taipy import Gui

selection1 = []
selection2 = "Item 2"
selection3 = "Item 3"

page = (
    "## Multiple Selection Too Wide Missing Label\n"
    + "<|{selection1}|selector|lov=Item 1;Item 2;Item 3|"
    + "multiple=True|label=Choose Your Item|"
    + "width=300px|>\n"
    + "## Single Selection Just Right With Label\n"
    + "<|{selection2}|selector|lov=Item 1;Item 2;Item 3|"
    + "dropdown=True|label=Choose Your Item|"
    + "width=200px|>\n"
    + "## Single Selection Too Wide Missing Label\n"
    + "<|{selection3}|selector|lov=Item 1;Item 2;Item 3|"
    + "dropdown=False|label=Choose Your Item|"
    + "width=250px|>\n"
)

if __name__ == "__main__":
    gui = Gui(page=page)

    gui.run(
        async_mode="threading",
        title="Multiselector Demo",
        debug=True,
        use_reloader=True,
    )

Expected behavior
The label should appear, and the width should be respected.
Screenshots

Note the grey area on the right extends all the way to the right end of the browser.  The width is respected for the elements that you can select, but not for the bounding box.
Runtime environment
Please specify relevant indications.

OS:  Windows 10
Browser: Chrome

Thank you Irv! In fact, it seems that the label is missing only when dropdown=False. This visual element will show the correct label:
<|{selection4}|selector|lov=Item 1;Item 2;Item 3|dropdown|multiple|label=Choose Your Item|>

Thank you Irv! In fact, it seems that the label is missing only when dropdown=False. This visual element will show the correct label:

Thanks.  I can use that in the demo I'm working on.  Also, dropdown=True removes the width problem, so both the width and missing label are issues with dropdown=False.

Exact!


Repo sync for protected CLA branch

The pull request is created from main638025751120497754sync_temp to main to fix git push error for protected CLA branch

Learn Build status updates of commit 7292794:
:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


fix: Exclude "main" suffices from version checks.

This exception is around internal tooling; what is publicly released still corresponds to AIP-215.
Ultimately the right way to do this sort of thing is with internal extensions but we do not have a good internal way to add a granular exception like this so I am accepting the wart for the moment.


Migrate Instagram API (deprecated) to Instagram Basic Display. Issue #964

Hey, so we've had a go at this issue and it feels like we're so close to solving it but we have hit a problem which we can't seem to get past.
Where the request going out to Instagram contains the sessions "user" details, but the callback request it's missing.
The error is TypeError : Cannot read property '_id' of undefined.
This happens when trying to call GET /auth/instagram/callback/code={authCode} (this request comes via ngrok), and I believe that up until this call - the request contains the user{ _id{ ... } } properties. Then it is completely stripped away on the way back.
Any idea on what we're missing?

I got stuck trying to test your code at the auth step.  More specifically it looked like I have to create a new Instagram API app and when I tried to do so it pushed me to go through the verification with video of how the app is used.  I created a video and submitted it, but they rejected the scope request for instagram_graph_user_profile and instagram_graph_user_media.  Can a developer (in the scope of a hackathon) put something together without going through video/screencast submission to Instagram for app permissions?  If so, can you add some instructions in Readme.md about obtaining an API key and credentials?  Thanks!


remove the skipTests configuration from openshift profile

This is inconsistent with other Swarm boosters, and there's
really no need to skip tests in the openshift profile
by default. It might possibly speedup deployment a bit,
which is probably why the Jenkinsfile uses -DskipTests,
but that's no reason to skip tests by default in the POM.

Did anyone verify that running maven with -Popenshift profile actually works now?
The whole reason to skip surefire tests in the openshift profile was because they require different database drivers, and to prevent h2 from ending up in the uber jar when deployed to openshift

Oh wow! Hmm. Looks like I've been too eager with this. Let me verify.

@kenfinnigan You're right obviously. Sent a PR with revert. Sorry about the mess.

No problem


K8s guidance: running a single container

First shot at writing a k8s doc.  Covers basic use-cases like starting pods, services, and management with json/yaml.
Feedback welcome.
refs coreos-inc/coreos-pages/issues/583
cc: @joshix @philips et al.

@robszumski Thank's for the feedback. I didn't delete the $VARIABLE commands. I do think they can help beginners better understand the commands they're running in more abstractly (speaking as somebody that just learned a lot of this).  I am open to getting rid of them if you / others feel strongly that they don't help though.
As a compromise we can link to a relevant upstream doc for each section.

Closing for age; used in pieces in tutorials and other locations.


why break and continue can follow with a tag name?

What version of Go are you using (go version)?

$ go version
go version go1.13.1 darwin/amd64

Does this issue reproduce with the latest release?
yeah
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/didi/Library/Caches/go-build"
GOENV="/Users/didi/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GONOPROXY="git.xiaojukeji.com,go.intra.xiaojukeji.com"
GONOSUMDB="git.xiaojukeji.com,go.intra.xiaojukeji.com"
GOOS="darwin"
GOPATH="/Users/didi/go"
GOPRIVATE="git.xiaojukeji.com,go.intra.xiaojukeji.com"
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/didi/workspace/go-dev/src/demo/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/2w/tt1p_4td3yq9xlbl7c2t4jn00000gn/T/go-build663163938=/tmp/go-build -gno-record-gcc-switches -fno-common"
GOROOT/bin/go version: go version go1.13.1 darwin/amd64
GOROOT/bin/go tool compile -V: compile version go1.13.1
uname -v: Darwin Kernel Version 19.0.0: Thu Oct 17 16:17:15 PDT 2019; root:xnu-6153.41.3~29/RELEASE_X86_64
ProductName:	Mac OS X
ProductVersion:	10.15.1
BuildVersion:	19B88
lldb --version: lldb-1<IP_ADDRESS>
Apple Swift version 5.1.2 (swiftlang-1100.0.278 clang-1<IP_ADDRESS>)

What did you do?

package main

import "fmt"

func main() {
	foo()
}

func foo() {

TAG:
	for i := 0; i < 3; i++ {
		fmt.Println("tag")
		if i == 2 {
			break TAG
		}
	}
}

What did you expect to see?
just not pass when go build
What did you see instead?
passed
What is the problem?
break TAG is the same with break.  So, what`s the purpose of allowing a tag follow by it? I think that doing so violates the code's simplicity guidelines. And this is not allow in c/c++.

If you have nested loops that look like this:
TAG:
    for ( ... ) {
        for ( ... ) {
            if ( ... ) {    }
        }
    }

Inside the if, break will break out the inner loop, while break TAG will break out the outer loop. Without allowing the break [ Label ]  variant, you wouldn't be able to break out the outer loop.
See the Language Specification: https://golang.org/ref/spec#Break_statements
Closing here, since this is working as intended.

@ALTree nice to meet you again! I understand the use age of break [label], but how about continue [label] which seems useless.
package main

import "fmt"

func main() {
	foo()
}

func foo() {

Tag:
	for i := 0; i < 4; i++ {
		for j := 0; j < 3; j++ {
			if i == 2 {
				continue Tag
			}
			fmt.Println(i, j)
		}
	}
}

@xlionet In your example are the same, but in other cases they are not:
main

import "fmt"

func main() {
	foo()
}

func foo() {

Tag:
	for i := 0; i < 4; i++ {
		for j := 0; j < 3; j++ {
			if j == 1 {
				continue Tag
			}
			fmt.Println(i, j)
		}
	}
}

continue Tag prints
0 0
1 0
2 0
3 0

while continue prints
0 0
0 2
1 0
1 2
2 0
2 2
3 0
3 2

@ALTree thank you very much, and i understand now!!!

@xlionet you are welcome.
Please remember that we use the Github issue tracker exclusively for bugs in Go itself. If you have a question about the language, it's better to ask it in one of the places linked here: https://github.com/golang/go/wiki/Questions. If then it turns out you have found a bug in Go, you can open an issue here in Github.

@xlionet ok，i got it！


Add a blog post about Mixer adapters.

Jenkins job istio.github.io/presubmit passed

Jenkins job istio.github.io/presubmit passed

Ugh, those are markdown conversion errors. They're fixed now.
Good catch.
PTAL.

Fixed. Thanks.
On Fri, Nov 3, 2017 at 10:12 AM, Douglas Reid<EMAIL_ADDRESS>wrote:

@douglas-reid commented on this pull request.
One small markdown issue (at least in github's view mode).
In _posts/2017-11-03-adapter-model.md
https://github.com/istio/istio.github.io/pull/700#discussion_r148841650:

+You configure each adapter by creating handlers for them. A handler is a
+configuration resource which represents a fully configured adapter ready for use. There can be any number of handlers for a single adapter, making it possible to reuse an adapter in different scenarios.

+## Templates: Adapter Input Schema
+
+Mixer is typically invoked twice for every incoming request to a mesh service, once for precondition checks and once for telemetry reporting. For every such call, Mixer invokes one or more adapters. Different adapters need different pieces of data as input in order to do their work. A logging adapter needs a log entry, a metric adapter needs a metric, an authorization adapter needs credentials, etc.
+Mixer templates are used to describe the exact data that an adapter consumes at request time.
+
+Each template is specified as a protobuf message. A single template describes a bundle of data that is delivered to one or more adapters at runtime. Any given adapter can be designed to support any number of templates, the specific templates the adapter supports is determined by the adapter developer.
+
+metric and logentry are two of the most essential templates used within Istio. They represent respectively the payload to report a single metric and a single log entry to appropriate backends.
+
+## Instances: Attribute Mapping
+
+You control which data is delivered to individual adapters by creating [instances](https://istio.io/docs/concepts/policy-and-control/mixer-config
+.html#instances https://istio.io/docs/concepts/policy-and-control/mixer-config+.html#instances). Instances control how Mixer uses the attributes delivered by the proxy into individual bundles of data that can be routed to different adapters.
i think the line break here (between mixer-config and .html) screws up
the markdown for the link.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio.github.io/pull/700#pullrequestreview-74150850,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AVucHVwuMtkinwp6yu1y79nahZuFpwdVks5sy0lhgaJpZM4QRE3j
.

Jenkins job istio.github.io/presubmit passed


CLOCQ EL API down?

Hey there!
I am working on researching a variety of entity linking approaches, attempting to generate result explanations and ran across CLOCQ - it looks like very useful and interesting project!
I found https://clocq.mpi-inf.mpg.de/ site and wanted to test the EL aspect of the API, but the service seems unavailable.
Will it be coming back up or would you advise rather going for the code?
While I am at it: I am planning on running it on-site along a variety of other services - are you planning on dockerizing CLOCQ? If so, I'd love to include it!
Best regards & continued success!
kmdn

Hi,
First of all, thanks a lot for your interest in our work and the nice words!
The EL service was just restarted, thanks for the note.
We will add a regular test to check for its availability.
There are currently no plans to dockerize CLOCQ though.
CLOCQ uses the full Wikidata KB internally, which comes
with quite some disk space and memory requirements.
For the EL service, we provide a module that could be
run locally, but still makes use of the CLOCQ API:
https://github.com/PhilippChr/CLOCQ-pruning-module/
This essentially wraps around the CLOCQ service/API.
All the best for your research!
Explainability is indeed an interesting topic,
for many IR/NLP related tasks.
Regards,
Philipp


Fix doc and auth issue

Refer to newer pyicloud-ipd (see https://github.com/ndbroadbent/pyicloud/pull/3).
Include fix from @danielfmolnar (don’t really know what that does).
Document changed command line options.
Fixes #139

Where is pyicloud_ipd==0.11.0 coming from? It doesn't appear to be on PyPI and I can't find the source repo.

Oh, I see, it's probably this PR right here.

Hello, thanks for the PR, and sorry for the delay! Unfortunately I don't have time to investigate and test the issue, but if you are still interested, could you (or someone else) please rebase and fix the conflicts, and then make sure all the tests and linters are passing? Thanks a lot!

Documentation issues have been addressed in #197, all the other issues should be fixed already for quite some time. If you still experience these issues, please open a new ticket! Thanks!


Switch axios and SWR to Ky and react-query

A summary :

Why Ky over Axios
Why React-query over SWR

Thank you but I don't think we'll do this any time soon. There's also quite a bit of unrelated style changes here.


Kafka producer

Pull request for Kafka producer.
Still WIP.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Figure out a way to manage client side migrations of store data

We'll need to do this once people have existing channels in their IndexedDB and we change the store schema.

Dexie (as well as the indexedDB API) expose onVersionChanged callbacks: https://dexie.org/docs/Dexie/Dexie.version()


Dialyzer

Split from #2

http://erlang.org/doc/man/dialyzer.html

Does it integrate with rebar3 well #4 ?

@rexim yes it does

When I type
$ rebar3 dialyzer

I get the following error on my machine:
...
===> Error in dialyzing apps: Could not get abstract code for file: /nix/store/z8dhzh46krvs32lgp8bqqh65w93ia1ai-erlang-<IP_ADDRESS>/lib/erlang/lib/crypto-3.6.3/ebin/crypto.beam (please recompile it with +debug_info)
...

OS: NixOS 17.03.1461.ebeb8901a2 (Gorilla)


jQuery.fx.off = true;

SwaggerUI feels like Adobe Flash demos circa 2003.

@chadwackerman - can you elaborate here a little?
It's also worth noting that Swashbuckle is a server-side Swagger generator that bundles in an embedded version of the awesome (swagger-ui)[https://github.com/swagger-api/swagger-ui] tool for convenience. If you have an issue with the UI, you'd be better off logging it over at that repo.


Feature/logging data

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

logging of augmentation, training and evaluation details for data analysis
Fixes / issues

logging of augment folder name, training key and count , validation key and count
logging of training time, epoch, accuracy, loss , val_accuracy and val_loss
logging of evaluation folder_name, label_name, total_images_count, correct_pred and outflow

Type of change

Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist before requesting a review

[x] I have performed a self-review of my code
[ ] If it is a core feature, I have added thorough tests.
[ ] Do we need to implement analytics?
[ ] Will this be part of a product update? If yes, please write one phrase about this update.

Too many restrictions and future proofing required to update the logger.


Need to update k8s version in kraken.config/files/config.yaml to 1.5.7

K2 tools has already been updated.

good catch, but we're in the process of moving this version to 1.6.4.  If that process stalls or fails out we can bump the 1.5 version.

closing, we've moved to 1.6.4


Problems with paid Posts

When visiting own paid-Post, I ended up paying for it (shows up in transaction).
When visiting own paid-Post but I don't have enough credits for the price, it won't load.

Also affects own videos with price. If spendable amount is too low, it just shows the "Loading..." text.
The purchasing of own content also happens with video


null is not an object (evaluating 'Settings.initializeSDK')

I am trying to integrate facebook sdk into my react native app with a goal of optimizing app installs through the fb ads.
I followed all the steps mentioned here
https://www.npmjs.com/package/react-native-fbsdk-next
https://developers.facebook.com/quickstarts/487102509986353/?platform=android
But while trying to initialise sdk via Settings.initializeSDK() ( as mentioned in the usage section) getting the following error. null is not an object (evaluating 'Settings.initializeSDK') in the native android build.
What is going wrong? Also, do we need to use Settings.initializeSDK() for fb to track app installs?
To Reproduce
import { Settings } from 'react-native-fbsdk-next';

 Settings.initializeSDK();

Environment
Expo Bare Workflow
React version : "0.64.3"
Android Build

Hi there!
Not sure why you would base on react-native 0.64, that's too old to support really. Probably not directly related to this problem, but I would upgrade.
If you ever see an error "null is not an object" when evaluating something that is likely a native module, you probably have not installed things correctly or built them, such that the native object is not present + available in the native app.
I suggest you create a new clean / throwaway app following the instructions to see that it works.
We do that in this script here and it works: https://github.com/thebergamo/react-native-fbsdk-next/blob/master/refresh-example.sh
So this will likely be project-specific and no further action is possible in this repo


Question- language model onnx files location

Hi, I had a general question
For LLM models eg: llama, when we build the engine from the .safetensors and the json file created in convert_checkpoint.py , while building the TRT engine in tensorrt_llm/commands/build.py  is the engine directly created from the safetensors or is it converted to some intermediate format, eg : onnx. If so where is this (eg: onnx file) created?

The engine is created from the safetensors.


pr-4

Started jenkins build -  pls check after some time for build and test status

BUILD SUCCESS

BUILD SUCCESS


what's this?

not an issue per se, inasmuch as a request for documentation. what's the goal of this project? is it just a gadget for users to drop an icon on the page, so could be used just the same for other icons like font-awesome? I am curious because I was recently introduced to https://material.google.com/ and it's pretty, wow. Not sure how we're going to integrate these new design principles with OU, but seeing this repo I'm very intrigued with your approach.

Hey Jeff, it is still in progress, I should have it completed by Monday or Tuesday and I'll provide "full" documentation thenish.
Our web authors really want the ability to add icons to their pages and our designer found the Material icons as one that she liked. So the original thought was to use snippets to place icons in but there are hundreds of icons so that would clutter up the snippet list. The other problem is that the WYSIWYG editor doesn't do well with empty divs, especially trying to place the cursor before or after them. So I figured a table transformation would be a "good" solution.
Well, tables suck, and although you can put your mouse before and after them, they are block elements so inline icons won't work. So, the gadget will place in a placeholder icon and then the XSL transformation will convert it to the icon on preview and publish.
Yes, I think this could work with font-awesome as well. I don't think OUCampus would ever implement icons natively since they would be part of the design.
Let me finish up early this week and then I'd be happy to chat about the logistics of the whole thing and then contributing if you are interested.

I have finished up the last little bit of code and will post something over on the OU Forum in a little bit. I have beefed up the documentation and added an install via github pages. If you have time, please check it out! All feedback is welcomed!


onProgress no update after refreshing page - vuejs

I am uploading videos to vimeo from my frontend, using tus-js-client. The load happens without problems and everything works fine, the onProgress function receives the load data fine. I am using vue and these are the functions that I use to load.
async vimeoQueryLink () {
  try {
    const { size } = this.upload.video

    const body = {
      name: Number(new Date()).toLocaleString(),
      upload: {
        approach: 'tus',
        size
      }
    }

    const response = await fetch('https://api.vimeo.com/me/videos', {
      method: 'POST',
      mode: 'cors',
      cache: 'no-cache',
      credentials: 'same-origin',
      headers: {
        Authorization: 'bearer TOKEN',
        'Content-Type': 'application/json',
        Accept: 'application/vnd.vimeo.*+json;version=3.4'
      },
      redirect: 'follow',
      referrerPolicy: 'no-referrer',
      body: JSON.stringify(body)
    })

    return response.json()
  } catch (error) {
    console.log(error)
  }
}

async vimeoUploadVideo () {
  const { upload } = await this.vimeoQueryLink()

  const tusUpload = new tus.Upload(this.upload.video, {
    uploadUrl: upload.upload_link,
    onError (error) {
      console.log('vimeoUploadVideo: error =>' + error)
    },
    onProgress (bytesUploaded, bytesTotal) {
      /**
      *   After refreshing the page, it only shows when it starts and when it loads 100%
      **/

      const percentage = (bytesUploaded / bytesTotal * 100).toFixed(2)
      console.log(bytesUploaded, bytesTotal, percentage + '%')
    },
    onSuccess () {
      console.log('Download %s from %s', tusUpload.file.name, tusUpload.url)
      console.log('vimeoUploadVideo: finish')
    }
  })

  tusUpload.start()
}

The problem happens when I update the page, for some reason, the onProgress function only indicates 0% and 100% load, it does not show the progress during the upload of the video.
The video uploads to vimeo 100%, I just don't know the% load while it uploads. To make it work once again I have to clear all the manual cache or refresh with ctrl + f5
Check if it was saving something in the localstorage or cookies but I don't see anything that could link or cause the problem.

Problem caused by service worker configuración. 😑

Problem caused by service worker configuración. 😑

I have the same problem with VueJS. it jumps from 0% 100%. what do you mean by service worker configuration? How did you fixed it?

If it jumps directly from 0% to 100% it could be that the file is not uploaded again, because you instructed tus-js-client to resume previous uploads and it realizes that it uploaded the file already, so it does not repeat the upload again. Are you using the findPreviousUploads method?

Nope. just
new tus.Upload(files[0], this.options).start() //omitting other code.

In options I have;
        onProgress: function (bytesUploaded, bytesTotal) {
            var percentage = (bytesUploaded / bytesTotal * 100).toFixed(2);
            methodScope.currentProgress = percentage;
        },

here methodScope is basically the reference to the VueJS component and currentProgress is a data field that gets bound to the view template. problem is this onprogress event is fired once. So progress bar fills at 100 after everything has gone to server. No errors logged what so ever.
I don't think it's an error on Vue or Tus.. may be I am missing something in wireup. That is why I asked what made it to work for @vghernandz

Ok, are you using tus-js-client v2 or v1?

Using "library"<EMAIL_ADDRESS>....

Hi guys!
based on my problem was the following, I was using nuxtjs in my project and had integrated @ nuxtjs / firebase in the latter, to be able to use the uth ssr I had to call a sw file here
So, I needed to exclude from the requests the video provider where I was uploading, vimeo was my case and with this the onProgress function worked fine, but unfortunately for a long time I had little time to try it.
I asked in the nuxt pwa-module project here and I had no answers for the short time available. In the end I solved removing from my project @ nuxtjs / firebase

In my case it's pure vuejs and nothing else. For server side I am using tusdotnet. Everything works perfectly except for this progress. I feel it's something to do with my configuration but since it doesn't throw any error/warning I can't figure it out.

What does the options look like that you are passing to new tus.Upload?

Well it goes like this;
        this.options = {
        endpoint: uploadEndPoint,
        retryDelays: [0, 1000, 3000],
        parallelUploads: 1,
        metadata: {
            filename: null,
            filetype: null
        },
onError ... onProgress ... onAfterResponse ...

my onProgress is like;
            onProgress: function (bytesUploaded, bytesTotal) {
            var percentage = (bytesUploaded / bytesTotal * 100).toFixed(2);
            methodScope.currentProgress = percentage;
        },

Ok, thanks. Those options look normal and sensible. Nothing that would be suspicious immediately. Maybe it is indeed caused by Vuejs.

I am also now thinking the same. Let's close the case and will get back if I find anything new which i think is related to tus. Thank you.

Add this to your fetch function in your service worker. J's
if (event.request.url.indexOf('tus') !== -1) {
return;
}


CompressionCodec class not found if the codec class is not in the same defining classloader as the CodecFactory class

Reporter: Terence Yim / @chtyim
Assignee: Terence Yim / @chtyim
PRs and other links:

GitHub Pull Request #760

Note: This issue was originally created as PARQUET-1802. Please see the migration documentation for further details.

Terence Yim / @chtyim:
In the CodecFactory class, it loads the codec class via Class.forName(className), which assume the codec class is loadable via the defining classloader of the CodecFactory class. However, it may not always be the case. Ideally it should be using the ClassLoader from the job Configuration instead.


[ConstraintSystem] NFC: Check whether opened type has a binding befor…

…e printing
In some circumstances opened type might not have a fixed binding.
A good example could be dependent sub-component produced for
result builder transformed code (connected via one-way constraints),
in such a case OpenedTypes would have outer generic parameters
but they might not be bound yet, so they have to be printed as
type variables.

/cc @amritpan

@swift-ci please test


go2rtc running on Unraid - fails to playback WebRTC for 3 out of 4 Ring cameras.

I've been working with @tsightler on this issue for awhile now, and we seem to have narrowed it down to go2rtc running on the latest version of Unraid.
Setup is:
Home Assistant running in Unraid - Docker with
RTSPtoWebRTC built-in integration
ring-mqtt running in Unraid - Docker
go2rtc running in Unraid - Docker
4 Ring devices.  A doorbell Pro, an older Floodlight, a Spotlight, and a newer Floodlight Plus
Up until recently everything worked perfectly.  Now only 1 of the 4 cameras is able to playback in Home Assistant.  Using the go2rtc web interface, all streams can playback in MSE mode, but only the one camera can do WebRTC.
Running go2rtc on a different computer (Windows 11) didn't have the problem at all, so seems like a compatibility issue with Unraid.  Also RTSPtoWEB is able to play all cameras in WebRTC without issue on the same Unraid Server.
There's a ton of additional detail in the original ring-mqtt Issue linked above.

So earlier all was fine. And from some moment only 1 camera can use WebRTC mode?

Exactly ... I had this setup up and running and everything worked perfectly.  My suspicion is something changed in the Docker networking environment with the recent Unraid versions.
The one difference with the working camera that @tsightler and I caught was that it was negotiating a lower H.264 level ... usually 3.2 or 4.0 Main .... while the 3 "bad" cameras were 4.1 High.

Do your problem cameras have a high bitrate?

I don't think so, they're all close to 5 years old, none of them offer the "Legacy Video Mode" in the Ring App, suggesting that they don't support H.265 like newer Ring cameras do.

Update, I just downgraded Unraid back to 6.11.5 which was released last November, a known "working good" version and the behavior hasn't changed.  I'm wondering if the problem is caused by something Ring recently changed...

How you can say that that switch is the problem?

How you can say that that switch is the problem?

Because all the cameras work with WebRTC when I swap it out with something else.  @tsightler has a theory (that I agree with) that the switch doesn't have a large enough buffer to handle the bursty nature of the way the traffic comes in from Ring.

To add some detail, I don't really know why a specific switch would cause any problems, especially with 3 streams not working and 1 working, but there are some more potential clues.
@AlexxIT Asked about bitrate above.  Well, Ring cameras have a notoriously low bitrate overall, averaging only ~2.5Mb for most cameras, they use a dynamic bitrate so sometimes it's even less.
@Scope666 had one live stream that did work and 3 that did not.  The one that did work appeared to be negotiating a slightly lower H.264 profile, main profile level 3.1 vs the other three cameras, which negotiated high profile level 4.1.  Now, I wouldn't expect this to have a huge impact on the bitrate, but almost certainly it was a little bit lower.
But, there is even more evidence that bitrate is somehow involved in the failure.  The ring-mqtt code also includes the ability to play back recorded video streams.  Ring offers both raw video recording (exactly as the camera recorded it) and "transcoded" videos, the latter of which can be optimized to be downloaded and played back locally.  These transcoded videos include things like timestamps, etc.
These videos are generally the same, or even slightly lower bitrate than the original recording, but because they are optimized for downloading, they don't stream very well,  When a user requests to stream them, I overcome this by using ffmpeg to stream the file directly from the S3 storage over HTTPS, and then retranscoding the file on the fly, however, because my project runs commonly on low-end hardware like RPi's, and I can't be sure the code has access to hardware acceleration, I use the ultrafast profile instead, which of course trades CPU for size, creating significantly higher bitrate files, usually around 10-12Mb.
So, with this switch in place there are 7 out of 8 streams that won''t play back:
4 event streams at ~10-12Mb won't play back
3 live streams at ~2.5Mb won't play back
1 live stream at slightly lower bitrate (unconfirmed), that does play back
However, once the switch was removed from the environment, all 8 streams play back fine with no other changes.  This seems to indicate something with the switch, perhaps some unexpected interaction, etc.  I'm not 100% sure why a switch would have such behavior, but it is a small "smart" switch, with QoS and storm control.  I know these devices are regularly underpowered, have smaller buffers and processors than would be ideal, so my thought is that maybe this switch is just dropping too many UDP packets to get the stream started.  The one stream that worked was just slightly lower bitrate just below the threshold.  I certainly don't have any proof of this, was just trying to come up with a theory as to why a switch would impact 7 of 8 streams.
I'm certainly open to other theories.

I plan to investigate the stability of the WebRTC UDP vs WebRTC TCP.
There is known problem with WebRTC UDP on hi bitrates
https://habr.com/en/companies/flashphoner/articles/480006/

Latest version supports webrtc/tcp mode. It can be used with this integration https://github.com/AlexxIT/WebRTC

Thanks for the update! ... I'm assuming you're talking about 3.2.1?  Do you have to do anything special to tell it to use TCP instead of UDP?  @tsightler Not sure what I would have to change on the ring-mqtt side to test this out.  (also the go2rtc cooked into your container)

Thanks for the update! ... I'm assuming you're talking about 3.2.1? Do you have to do anything special to tell it to use TCP instead of UDP? @tsightler Not sure what I would have to change on the ring-mqtt side to test this out. (also the go2rtc cooked into your container)
btw, the article you linked above really did a good job explaining WHY this is happening. With a dumb switch it just works, but with the "smart" one, the qos, buffers, etc, can't handle the UDP at that resolution / bitrate / burstiness. At least with TCP it KNOWS the packet(s) was lost and retransmits.
"Why stream over TCP at all if there is UDP
This is a reasonable question to ask. The answer is, for pushing big resolutions through the channel. For example, in the case of VR (Virtual Reality) streaming the resolutions may begin from 4k. It does not seem possible to push a stream with such a resolution and with a bitrate of about 10 Mbps into a regular channel without losses, the server spits out the UDP packets and they begin to be lost in the network in bunches, then the remainder of them begins to be sent, and so on. Big amounts of discarded video packets corrupt the video, and the net result is that the quality becomes very poor. This is the reason why WebRTC over TCP is used for delivering the video in general purpose networks and with high resolutions, such as Full HD and 4k, in order to rule out network packet losses at the expense of a slight increase in the communication latency."

@tsightler Not sure what I would have to change on the ring-mqtt side to test this out. (also the go2rtc cooked into your container)

No changes are needed since the go2rtc instance in the ring-mqtt container is used only as an RTSP proxy and does not provide WebRTC at all (it's actually disabled).

Please reopen the issue if it is still relevant


[AutoPR eventgrid/data-plane] Create KeyVault.json

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/6975

(message created by the CI based on PR content)

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/6818


Create partials for email templates

https://firebase.google.com/docs/extensions/official/firestore-send-email/templates?hl=en

Club Requests missing

Add partials to git as well


Type System Bug: Function.prototype.call variance error

Bug Report
🔎 Search Terms
(is:open label:Bug) function, call, prototype method, variance
🕗 Version & Regression Information

This is a type system error
This is the behavior in every version I tried (3.3, 4.9.4, 5.0.0-dev.20230113), and there is no FAQ about this

⏯ Playground Link

Playground link with relevant code
💻 Code

interface Animal {
    getAttention(): void;
}

class Cat implements Animal {
    private meow(): void {
        console.log("meow!");
    }
    getAttention() {
        this.meow();
    }
}

class Dog implements Animal {
    private bark(): void {
        console.log("bark!");
    }
    getAttention() {
        this.bark();
    }
}

function animalGetsAttention(it: Animal, method: (this: Animal) => void) {
    method.call(it);
}

animalGetsAttention(new Dog(), Cat.prototype.getAttention); // Error: this.meow is not a function

🙁 Actual behavior
The code passed the type checker and compiled even though it is incorrect and fails at runtime.
🙂 Expected behavior
The compiler should not allow calling the method; the type system should not allow generalizing this in this case (as far as I understand it, as Cat.prototype.getAttention should require this to extend Cat and not Cat to extend Animal).
I believe this has to do with Co- and Contravariance.

Methods don't have automatic this types for performance reasons (my understanding is that this makes all methods implicitly generic under the hood).  Specifying the this type for getAttention explicitly (as either this: this or this: Cat) makes your example error as expected.

Found the relevant issue: https://github.com/microsoft/TypeScript/issues/35451

Methods don't have automatic this types for performance reasons (my understanding is that this makes all methods implicitly generic under the hood). Specifying the this type for getAttention explicitly (as either this: this or this: Cat) makes your example error as expected.

True, and I did not know this was possible. Though, the type-checker still accepted code that is not valid. It should either not accept it when calling the prototype or when declaring the function and calling the private method.
Code
interface Animal {
    getAttention(): void;
}

class Cat implements Animal {
    private meow(): void {
        console.log("meow!");
    }
    getAttention(this: this) {
        this.meow();
    }
}

class Dog implements Animal {
    private bark(): void {
        console.log("bark!");
    }
    getAttention(this: this) {
        this.bark();
    }
}

function animalGetsAttention(it: Animal, method: (this: Animal) => void) {
    method.call(it);
}

// Argument of type '(this: Cat) => void' is not assignable to parameter of type '(this: Animal) => void'.
animalGetsAttention(new Dog(), Cat.prototype.getAttention);

Found the relevant issue: #35451

If the compiler accepts invalid code for performance reasons, then why is there no tsconfig compiler option for stricter type checking in that case? It would add better type safety for code bases which are not class-heavy.

Though, the type-checker still accepted code that is not valid.

Just for future reference, this is unavoidable in general; it's explicitly called out in the design goals for TS that the compiler tries to "strike a balance between correctness and productivity".  Plus the type system seeks to be friendly to idiomatic JS patterns as possible, which as you can probably imagine is its own entire can of worms.  Tradeoffs will inevitably be made.

If the compiler accepts invalid code for performance reasons, then why is there no tsconfig compiler option for stricter type checking in that case?

Interestingly, discussion in #6739 suggests this behavior was intended to be behind a flag (so not the default), but the perf implications were ultimately considered severe enough that it wasn't considered worth the tradeoff even then.

So this is a "Won't fix", then I will close this issue.

Relevant non-goal from the TypeScript Design Goals:

Apply a sound or "provably correct" type system. Instead, strike a balance between correctness and productivity.

So this is a "Won't fix"

Considering that #35451 was closed as design limitation, most likely yes, unfortunately.  Disclaimer: I'm not a TypeScript maintainer, I just lurk around here a lot (probably more than is healthy, actually...)


Support for Source Maps for upload into bug tracking tools like Sentry

Please list the related package(s)

checkout-ui-extensions
If this related to specific APIs or components, please list them here

I've followed the guide on https://shopify.dev/docs/api/checkout-ui-extensions/2024-07/error-handling.
Is your feature request related to a problem? Please describe.

We are getting a number of errors from our new Shopify Checkout Extension(s).
The errors are cryptic, like:

While I can probably work out what it is, it'd be delightful to be able to have proper source mapping in the error reporting so that we can easily map our code to the error.
From looking at the link above, and from browsing other documentation (e.g. Sentry Issue and a guide someone produced), I can't see anything about source maps.
Describe the changes you are looking for

I would like an update to the documentation linked above to explain how to extract a source map from Shopify to upload into Sentry.
Describe alternatives you’ve considered

I haven't tried anything else - I wouldn't know where to begin!
Additional context

An example of this which we're seeing today:
(t,i=>n+=Hc(i));return function(c,f){let d=0,p=0;for(;(p=c.indexOf("&",p))>=0;){n+=c.slice(d,p),u.startEntity(f);let g=u.write(c,p+1);if(g<0

It's impossible to tell what this relates to.


Update to refresh-token function

refresh-token was throwing an ArityException because it wasn't sending nonce and timestamp to sig/oauth-params.  I also updated it to accept verifier code and sign the request with the same signature as the access-token request.

👍  refresh-token has been objectively broken since 28f68daf07f157f949fe3d7d87550734e0f5af22 (September 2012) when the 2-arity version of oauth-params was removed.

Thanks for the report. Can you please describe the issue?

On Dec 19, 2017, at 16:36, Cameron Desautels<EMAIL_ADDRESS>wrote:
👍 refresh-token has been objectively broken since 28f68da (September 2012) when the 2-arity version of oauth-params was removed.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Ah, didn’t see there was previous report. Will take a look. Thanks for bumping.

@mattrepl Invoke refresh-token with any valid parameters—you'll get an ArityException from the call to sig/oauth-params on line 172 because it passes two arguments where at least three are required.
The rest of the changes appear to me to essentially maintain behavior while providing the necessary parameters to sig/oauth-params and refactoring a touch by leveraging build-oauth-token-request to generate the signature.
For the record, I haven't run this yet, but it looks sensible. I will probably be using it in the next day or two, so I can report back later if that's helpful.

Can now confirm that I'm able to successfully use this new implementation of refresh-token.

Ok, thanks for the update. Will merge, there may be a delay for release to clojars.

@mattrepl Fantastic. Thanks for taking the time to review and for the merge.
If there is a delay getting it to Clojars and anyone needs it sooner, there's an alternate version on Clojars at org.clojars.eraffoul/clj-oauth (by the originator of this PR, @eraf2135) that is precisely this project at the current state of master.

Any chance of a new release soon? 🙏  I'd love to see this fix on Clojars so I can throw away my local hacks. Thanks!


Testcafe adds own logging statements to the browser console

What is your Test Scenario?
Check with testcafe if the application adds certain log statements to the browser console
What is the Current behavior?
testcafe adds own logging statements to the browser console
What is the Expected behavior?
testcafe does not add own logging statements to the browser console. See those on the screenshots.
P.S. They are not testcafe's logging statement of level failure or error, which i would else very much prefer to stay. Else if it is a feature of testcafe, then make it a planned feature with on/off option. I am very much a fan of logging, better noisy than failing silently. But then in a mangeable way. Plus explain how to interpret that logging statements
What is your web application and your TestCafe test code?
git clone https://github.com/joma74/angular-ultimate-pro.git --branch testcafe-0.23.1-logging-issue --single-branch testcafe-0.23.1-logging-issue
See also https://travis-ci.org/joma74/angular-ultimate-pro/builds/452767145

Your complete test report:
```

    <![CDATA[
      1) AssertionError: expected '[object Object] object' to deeply equal 'Login
      {"email":"","password":"","rememberMe":true}'
<pre>     Browser: Firefox 63.0.0 / Ubuntu 0.0.0
     Screenshot:
  /home/joma/entwicklung/nodews/angular-ultimate-pro/target/reports/screenshots/actual/Index_Page_Test/console_has_messages/Firefox_63.0.0_Ubuntu_0.0.0/errors/1.png

        32 |
        33 |  const { log, error } = await t.getBrowserConsoleMessages()
        34 |  await t.expect(error.length).eql(0, JSON.stringify(error))
        35 |  await t
        36 |    .expect(log[2])
      > 37 |    .eql('Login {"email":"","password":"","rememberMe":true}')
        38 |})
        39 |
        40 |const testName2 = "can_destroy_component"
        41 |
        42 |test(testName2, async (t) => {

        at eql (/home/joma/entwicklung/nodews/angular-ultimate-pro/src/tests/index-test.js:37:6)

  2) AssertionError: expected '[object Object] object' to deeply equal 'Login
  {"email":"","password":"","rememberMe":true}'

     Browser: HeadlessChrome 70.0.3538 / Linux 0.0.0
     Screenshot:
  /home/joma/entwicklung/nodews/angular-ultimate-pro/target/reports/screenshots/actual/Index_Page_Test/console_has_messages/HeadlessChrome_70.0.3538_Linux_0.0.0/errors/1.png

        32 |
        33 |  const { log, error } = await t.getBrowserConsoleMessages()
        34 |  await t.expect(error.length).eql(0, JSON.stringify(error))
        35 |  await t
        36 |    .expect(log[2])
      > 37 |    .eql('Login {"email":"","password":"","rememberMe":true}')
        38 |})
        39 |
        40 |const testName2 = "can_destroy_component"
        41 |
        42 |test(testName2, async (t) => {

        at eql (/home/joma/entwicklung/nodews/angular-ultimate-pro/src/tests/index-test.js:37:6)
]]>
</failure>

```

Screenshots:

Steps to Reproduce:

git clone https://github.com/joma74/angular-ultimate-pro.git --branch testcafe-0.23.1-logging-issue --single-branch testcafe-0.23.1-logging-issue
yarn
yarn ci
See the test failures

Your Environment details:

testcafe version:                   0.23.1
node.js version:                    v10.13.0
command-line arguments:  testcafe 'firefox:headless,chrome:headless --no-sandbox --disable-gpu' -S -s $npm_package_config_screenshots -p $npm_package_config_screenshot_path_pattern -r spec,xunit:$npm_package_config_reports/report.xml src/tests/index-test.js
browser name and version: HeadlessChrome 70.0.3538,  Firefox 63.0.0
platform and version:          Ubuntu 16.04.5 LTS
other:

Seeing the same breaking our tests and capturing of any console.log output

I have managed to replicate this behavior. Our team will research it and find a suitable solution if any.

It's my fault. I added this line directly to the replicator package installed on my machine and forgot about it. When I executed npm install before publishing, it didn't go away because module's version was actual. Then webpack added modified replicator's module code to the client script's bundle, and the package was published with the contaminated script bundle.
We have to publish a new version ASAP, and modify the pre-publish script to clean and reinstall modules before building the package.

I've published the<EMAIL_ADDRESS>version with the fix. I can't reproduce the problem on my machine with this version. Could you please try it in your environments? Our team will test this pre-release version and publish the stable<EMAIL_ADDRESS>release on Monday.

Testing with v0.23.2-alpha.1 solves the issue for me here.

LGTM :+1:


Tox and travis tests - make test

So, in a feature branch, I've just made some changes to the test target in the Makefile and it has occurred to me that the tox.ini and the travis.yml issue explicit py.test tests commands rather than running make test.  Is there some reason we shouldn't use make test in those places?
CC: @wtolson

Not actually sure if it will break anything. I was mainly following the example of https://github.com/audreyr/cookiecutter-pypackage

Thanks for the response!
Basically, I am trying to make sure that doctests in the source get tested when we run make test so I have changed the target to this:
py.test --doctest-modules --ignore=setup.py

Then I realized that tox and travis would still run the old version.  I will ponder this a bit, I need to fiddle with the planetary_test_data package a bit now.

I have just duplicated the py.test command in all three places.


Merge PUM1-associated developmental disability-ataxia-seizure syndrom…

…e with Spinocerebellar ataxia 47
Closes #7851
Orphanet and OMIM terms are exact. Merging PUM1-associated developmental disability-ataxia-seizure syndrome with Spinocerebellar ataxia 47. Placed label as exact synonym.

This merge was made manually, and there are many problems with x-refs that were not transferred to the remaining term, etc. Closing this PR. We will create a new one using the merge owltools.


[Backport] [BUG] fsfreeze race condition

ref: #3125

Verified with V1.2.2
Validation - Pass

Validated the creation, deletion of snapshot. Revert to snapshot, snapshot while writing data.
Validated the recurring job snapshot/backup - Scheduled recurring jobs are getting skipped if there is no change in the data.

time="2021-10-07T21:11:01Z" level=info msg="Skipping taking backup because volume volume-test-1 is either empty or doesn't have new data since the last backup" jobType=backup labels="map[RecurringJob:c-mbjyor]" namespace=longhorn-system retain=1 snapshotName=c-mbjyor-c-fe94499f volumeName=volume-test-1
--
Thu, Oct 7 2021 2:11:01 pm | time="2021-10-07T21:11:01Z" level=info msg="Finish running recurring backup" jobType=backup labels="map[RecurringJob:c-mbjyor]" namespace=longhorn-system retain=1 snapshotName=c-mbjyor-c-fe94499f volumeName=volume-test-1
Thu, Oct 7 2021 2:11:01 pm | time="2021-10-07T21:11:01Z" level=info msg="Created job" concurrent=1 groups= job=c-mbjyor labels="{\"RecurringJob\":\"c-mbjyor\"}" retain=1 task=backup volume=volume-test-1

Validated the interruption in recurring jobs - Detached volume when a recurring backup was in progress, the next recurring job worked fine.
Validated recurring jobs with detached volume when Allow Recurring Job While Volume Is Detached is enabled.

Additionally observed below beahior:

Observed the snapshot creation time has increased. For a 1 GB data, snapshot creation takes 10-15 sec. Even the subsequent snapshot takes 10-15 sec.
With v1.1.2, it's around 1-2 sec. - Not sure this is because my Cluster config. I will retry this on another cluster to confirm this behavior.

https://longhorn.github.io/longhorn-tests/manual/pre-release/basic-operations-parallelism/snapshot-while-writing-data/ will not work as mentioned.


Update ParaSpell to v5.6.0

Thank you for your contribution to the Koda - Generative Art Marketplace.
👇 __ Let's make a quick check before the contribution.
PR Type

[ ] Bugfix
[x] Feature
[ ] Refactoring

(please remove design and QA checks below if not needed)
Needs Design check

Needs QA check

Context
The following PR features ParaSpell v5.6.0 which brought many useful features such as custom multilocations, customizable xcm version, Polkadot<>Kusama bridge and many more..
Along with features it brought many safety advancements such updating every package used in SDK to latest version.
Before submitting pull request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality

Optional

[ ] I've tested it at </ahp/collection>
[ ] I've tested PR on mobile
[ ] I've written unit tests 🧪
[ ] I've found edge cases
[x] Tested on main net

Did your issue had any of the "$" label on it?

Community participation

[x] Are you at Koda Ecosystem Telegram?

Screenshot 📸

[ ] My fix has changed something on UI; a screenshot is best to understand changes for others.

Hey, Is there any breaking change?

Hey @vikiival , no, there isn't, we have locally tested SDK on your project and everything works as expected.


Optimize docs preview github action trigger rule

What type of PR is this?
fix
What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

/LGTM


Update Beta status on Stackdriver gems

Change beta labels. Also fixed monitoring branding.

Coverage remained the same at 94.056% when pulling 43431bdf48ab5430ca00a52bae9e4fdf941eadff on stackdriver-beta into bb4878047e022dbfea9ee8a3aae30464d6d1c9a7 on master.


HTTP HEAD Content-Length header returns zero on Python 2.6

Pretty simple code
@route('/static/filename:path')
def send_static(filename):
return static_file(filename, root='static')
curl -I http://my.server.here/static/images/1.jpg
HTTP/1.0 200 OK
Date: Mon, 03 Jun 2013 18:15:04 GMT
Server: WSGIServer/0.1 Python/2.6.5
Last-Modified: Thu, 23 May 2013 21:09:12 GMT
Content-Type: image/jpeg
Accept-Ranges: bytes
Content-Length: 0
Inserted a print call at the end of static_file and Content-Length is set properly as it should be before the return.
Edit: Removed "static file" from title since it doesn't seem to just be static files

Can this bug be closed? It hasn't been updated in a long time, doesn't have a consistent repro, and makes reference to versions of Python (2.6 and 3.2) that are obsolete now.


documentation

Can you please provide step by step instructions?
the readme doesn't give me enough information for me to set it up and run inference on my computer.

I'll write a more detailed version of them.
I'll upload an inference example / training example later.

First of all want to say my thanks for sharing your code - its great. I've took a liberty to write a short guide on how to start the model with your code under Windows 10 WSL. Hope it helps - https://github.com/s4rduk4r/alpaca_lora_4bit_readme/blob/main/README.md

First of all want to say my thanks for sharing your code - its great. I've took a liberty to write a short guide on how to start the model with your code under Windows 10 WSL. Hope it helps - https://github.com/s4rduk4r/alpaca_lora_4bit_readme/blob/main/README.md

Oh Thank you!

Thank you @s4rduk4r


linted, fix json, added package.json

this PR fixes the invalid json and add a package.json for node.js

Please rebase and squash commits

@obscuren moved to #10


Revert "ciao-deploy: use a generic base clear image for building cnci."

Reverts ciao-project/ciao#1567 due to #1586

Coverage remained the same at 65.144% when pulling 5bbaf6072bf0876ba5da447aa29d343411bbed55 on revert-1567-topic/update-cnci-image into c84b55bed9f9bd4ca20f23c3b59e5fb98136b9b5 on master.

Coverage remained the same at 65.144% when pulling 5bbaf6072bf0876ba5da447aa29d343411bbed55 on revert-1567-topic/update-cnci-image into c84b55bed9f9bd4ca20f23c3b59e5fb98136b9b5 on master.


⚠ Processors has degraded performance

In 8448a95, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 49 ms

Resolved: Processors performance has improved in 12f4124.


Custom Validators Should Behave Similarly to Built-In Model Validation

Initial Checks

[X] I have searched Google & GitHub for similar requests and couldn't find anything
[X] I have read and followed the docs and still think this feature is missing

Description
Pydantic provides great validation on models, however, sometimes it's not enough. For example, if a field is only required if another field is a certain value, then custom validators must be used.
When a custom validator raises on validation inside of a function decorated with root_validator, then the function is exited. If it's raised in a function decorated with field_validator, then all later custom validators are skipped. This behaviour means that it's difficult to wrangle a consistent output to the user.
Whilst it's possible to collect validation errors in a list, and return a ValueError with all of the values, this presents the challenge of pulling each individual error out, and is very much a hack. I believe this approach was once viable using ErrorWrapper, however, this was removed in Pydantic v2.
I am not the only person that's experienced this issue: Stack Overflow question.
Example
class DependentModel(BaseModel):
   field_a: str
   field_b: str
   field_c: str

   @root_validator('field_b'):
   def field_b_validation(cls, values):
      field_a = values.get('field_a')
      field_b = values.get('field_b')

      if field_a == "sausages" and field_b == "":
         raise ValueError("field_b must have a value if field_a has value 'sausages'")

      if field_a == "sausages" and field_b == "burgers" and field_c == "":
         # this will never be reached if the prior logic is true. Ideally we could collect the errors and return them all at once.
         raise ValueError("field_c must have a value if field_a has value 'sausages' and field_b has value 'burgers')

class Parent(BaseModel):
   parent_field_a: str
   field_b: DependentModel

Affected Components

[ ] Compatibility between releases
[X] Data validation/parsing
[ ] Data serialization - .model_dump() and .model_dump_json()
[ ] JSON Schema
[ ] Dataclasses
[ ] Model Config
[ ] Field Types - adding or changing a particular data type
[ ] Function validation decorator
[ ] Generic Models
[ ] Other Model behaviour - model_construct(), pickling, private attributes, ORM mode
[ ] Plugins and integration with other tools - mypy, FastAPI, python-devtools, Hypothesis, VS Code, PyCharm, etc.

Is this likely to be considered @hramezani ? Unless I'm missing something, it seems odd that the (to the best of my knowledge) the way of achieving this was removed. I would have thought the ability to achieve such a thing is often required. Thanks

@JKFSOM Thanks for creating this feature request 🙏
Currently(in Pydantic V2), we stop as soon as we get the first error.
Yes, We would perhaps make it possible at some point.

Thanks for the response @hramezani. I understand that there's some difficulty in continuing past the first exception. I presume that's why originally it was possible to pass a list of ValueErrors using ErrorWrapper. However, this was removed in v2. I haven't yet tracked down a good reason for why it was removed.

I've been able to achieve what I was looking for without any changes to Pydantic. See this discussion.


When select is rendered it should not fire onChange action if value property is equal to null or undefined

Version of x-select: 4.0.0-beta.2
Ember Version: 3.10.2
Ember CLI Version: 3.10.1
I think when select is rendered it should not fire onChange action if the value property is equal to null or undefined. BTW, if value property is equal to anything else, then null or undefined the onChange action does not fire.
For example, I have a list of insurance types:
<XSelect @value={{this.insuranceTypeId}} @onChange={{action "showInsuranceTypePopup"}} as |xs|>
    <xs.option>None</xs.option>
    <xs.option @value=1>Medicare</xs.option>
    <xs.option @value=2>Medicaid</xs.option>
    <xs.option @value=3>Tricare Champus</xs.option>
    <xs.option @value=4>Champva</xs.option>
    <xs.option @value=5>Group Health Plan</xs.option>
    <xs.option @value=6>FECA Black Lung</xs.option>
    <xs.option @value=7>Other</xs.option>
</XSelect>

The initial value of 'this.insuranceTypeId' is equal to null, because no of the license is chosen and this is normal. But the addon fires onChange action. I do not get it why? Nothing changed. In my case it brings an issue, because implementation of showInsuranceTypePopup action shows a popup, so my users, when page has been loaded, have to close the popup first, then do what they want. In every such case, I have to workaround this issue.
In emberx-select version 3.x it did not fire the event, now it does.
What do you think?

Seeing the same thing. It confused me as it had a weird behavior in my app.

+1


fix: revert cbind breakage

These require careful naming for the binding script to understand.

Benchmark results
Metrics with a significant change:

note_history_successful_decrypting_time_in_ms (10): 4,593 (+92%)
note_trial_decrypting_time_in_ms (32): 63.9 (+85%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Values are compared against data from master at commit 13cef1f7 and shown if the difference exceeds 1%.
L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
64 txs

l1_rollup_calldata_size_in_bytes
5,668
18,852
36,420

l1_rollup_calldata_gas
66,280
239,280
469,164

l1_rollup_execution_gas
648,018
932,198
1,310,464

l2_block_processing_time_in_ms
1,302
4,796 (+3%)
9,494 (+5%)

note_successful_decrypting_time_in_ms
175 (-7%)
550 (+6%)
956 (-3%)

note_trial_decrypting_time_in_ms
76.3 (-16%)
:warning: 63.9 (+85%)
90.7 (-21%)

l2_block_building_time_in_ms
17,723
67,177
133,760 (+1%)

l2_block_rollup_simulation_time_in_ms
8,030 (+1%)
28,516
56,554 (+1%)

l2_block_public_tx_process_time_in_ms
9,672
38,608
77,109

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
14,468 (+1%)
28,898 (+9%)

note_history_successful_decrypting_time_in_ms
1,384 (+9%)
:warning: 4,593 (+92%)

note_history_trial_decrypting_time_in_ms
92.9 (-6%)
159 (+31%)

node_database_size_in_bytes
18,653,264
35,029,072

pxe_database_size_in_bytes
29,859
59,414

Circuits stats
Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit
circuit_simulation_time_in_ms
circuit_input_size_in_bytes
circuit_output_size_in_bytes

private-kernel-init
280
44,366
28,245

private-kernel-ordering
215
52,869
14,327

base-parity
1,885 (+7%)
128
311

base-rollup
722 (+2%)
165,788
925

root-parity
1,459 (-10%)
1,244
311

root-rollup
55.6 (+8%)
4,487
725

private-kernel-inner
645
73,772
28,245

public-kernel-app-logic
438 (+3%)
35,260
28,215

public-kernel-tail
174 (+1%)
40,926
28,215

merge-rollup
9.32 (+12%)
2,696
925

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
1 leaves
16 leaves
64 leaves
128 leaves
512 leaves
1024 leaves
2048 leaves
4096 leaves
32 leaves

batch_insert_into_append_only_tree_16_depth_ms
10.3 (+3%)
16.5 (+3%)
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.8
31.6
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.602 (+3%)
0.510 (+3%)
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
45.8
72.3
230
446
875 (+1%)
1,720
N/A

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
96.0
159
543
1,055
2,079
4,127
N/A

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
0.471
0.447
0.421 (+1%)
0.419 (+1%)
0.415 (+1%)
0.413
N/A

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
54.7 (+2%)
106
334
695 (+5%)
1,307 (+1%)
2,606
N/A

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
104
207
691
1,363
2,707
5,395
N/A

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
0.489 (+2%)
0.480
0.455
0.479 (+5%)
0.453
0.452
N/A

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
61.8 (+1%)

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
109

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
0.541 (+1%)

Miscellaneous
Transaction sizes based on how many contract classes are registered in the tx.

Metric
0 registered classes

tx_size_in_bytes
22,013

Transaction processing duration by data writes.

Metric
0 new note hashes
1 new note hashes

tx_pxe_processing_time_ms
3,260 (+2%)
1,744

Metric
0 public data writes
1 public data writes

tx_sequencer_processing_time_ms
10.5 (-13%)
1,228 (+2%)


[docs] Minor typo correction in breakpoints' docs

[x] I have followed (at least) the PR section of the contributing guide.

@tonytino Thanks.


{% increment ... %} / {% decrement %} overrides variables defined using assign and capture

increment and decrement tags are overriding variables that are defined by assign and capture. This is because liquex currently has only one level of variable scopes. In the Liquid gem, there are multiple with increment/decrement accessing the base scope while the rest work on nested scopes.

In the example below, a variable named “var” is created using assign. The increment tag is then used several times on a variable with the same name. Note that the increment tag does not affect the value of “var” that was created using assign.

<===> increment.json
{
  "x": 10
}

<===> increment.liquid
{% assign var = 10 %}
{% increment var %}
{% increment var %}
{% increment var %}
{{ var }}
---
{% increment x %}
{% increment x %}
{% increment x %}
{{ x }}

Expected output:
0
1
2
10
---
10
11
12
13

Current output:
11
12
13
13
---
11
12
13
13

Fixed in 0.8.0


[HOLD for payment 2023-06-29] [HOLD for payment 2023-06-28]  Incomplete Member Information Displayed When Hovering Over Photos in Admin Rooms

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open app settings.
Go to the workspace section.
Create a new workspace.
Click the three-dot icon and go to the admin section.
Click the header and go to members.
Hover over member email and photos. Only email is displayed when hovering over photos, while both name and email are displayed when hovering over email.
Note: Display name must be set in settings>profile>display name with a desired first name to reproduce.

Expected Result:
Hovering over member photos should display both name and email like when hovering over email.
Actual Result:
Hovering over member photos only displays email.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.29-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
screen-capture (4).webm
https://github.com/Expensify/App/assets/43996225/932bee71-1d37-428b-a543-8b50e686baf3
Expensify/Expensify Issue URL:
Issue reported by: @tewodrosGirmaA
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687003462951499
View all open jobs on GitHub

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@kavimuru confirmed 👍

Greetings @flodnv,  I believe the bug has been resolved. May I know if I am eligible for payment? Kindly inform me. Thank you.

Thank You

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~0142af0eda23e59363

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~0142af0eda23e59363


Is only one level of inheritance supported? If so why not multiple levels like other devops tools?

Is only one level of inheritance supported? If so why not multiple levels like other devops tools?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f5969861-6f6b-3da1-7eb3-2ee278110937
Version Independent ID: ae1c687d-7c93-ba01-f63c-2f1df95ed873
Content: Create and manage an inherited process - Azure DevOps Services
Content Source: docs/organizations/settings/work/manage-process.md
Product: devops
Technology: devops-agile
GitHub Login: @KathrynEE
Microsoft Alias: kaelli

@vijay-gowda - you should reach out to the dev community with this question. You can make feature requests, there. To make sure it gets in front of the right people, please submit your issue here.


Acceptable asset types and durations

The current standard suggests ncdf and grib2 as recognized assets.  This is a great start but I think too narrow.  Importantly, I think neither of these formats are really cloud-optimized, i.e. GDAL VSI requests will be slower trying to extract specific regions than  cog geotif, which should also be an option?  Likewise, some forecasts will be for non-raster data, I think it would make sense to allow assets to be in formats like geoparquet, etc?  What about zarr?  Is there a reason to pre-define the acceptable asset types?
Also, I'm a bit unclear what if anything is assumed about the dimensionality of an individual asset. i.e. does an asset have to represent a single forecast:datetime?  This makes sense for assets which are fundamentally 2d, like geotif or grib2, but a ncdf file (or hdf5, zarr, etc) can have arbitrary dimensions, i.e. forecast:datetime could be a dimension in the ncdf file, rather than serialized as metadata of separate assets.
I think these different serialization strategies should all be supported.

This is a misunderstanding, I just wanted to list potential media types to help implementors to use the right media type but the list was neither meant to be exclusive nor complete. So this is meant to work for any file format. I'll clarify...

Closing this as the asset types were clarified and I opened another specific issue around the multi-dimensionality issue: #8


Embed code is throwing errors

Yet somehow only on the dist version. So annoying.

Fixed in a5529363c74a8f92e9c348edf403081cf5da2b58.


how do you install different versions of laravel?

Currently it defaults to 5.2 even though 5.3 is the latest stable. How do you change which versions you want to install on a fresh new project?

I just went again and cloned the 5.3 branch, you should really update master to be the latest stable release.
clone -b 5.3 git@github.com:InfyOmLabs/adminlte-generator.git


Delegate V1

Includes:

Ability to stake with a whitelisted validator
Unstake (full amount)
Withdraw (full amount)

@Patrick1904 @mattlockyer @vgrichina Do we think this is ready to merge and test in staging? Seems good to me

@Patrick1904 @mattlockyer @vgrichina Do we think this is ready to merge and test in staging? Seems good to me

I think this is ready for testing in staging


[ISSUE #902]✨Implement Produer send batch message other methods🔥

Which Issue(s) This PR Fixes(Closes)

Fixes #902
Brief Description

How Did You Test This Change?

🚀Thanks for your contribution🎉. CodeRabbit(AI) will review your code first🔥


Worse image quality with tiles cut using rio-tiler than GDAL

When I use rio-tiler directly on (space-projected) tiffs, the quality of the tiles is noticeably worse than if I first cut them to GoogleMapsCompatible COG's using gdal.
I think given GDAL is the backend of rasterio/rio-tiler, and it's cutting the same size output tiles, the result should be the same quality if not pixel-identical.
Data: http://static.skysight.io/rio-bug/orig.tiff
Warp command: gdalwarp -multi -co TILED=YES -wo NUM_THREADS=64 -co BIGTIFF=YES -t_srs EPSG:3857 -of COG -co QUALITY=100 -co COMPRESS=JPEG -co TILING_SCHEME=GoogleMapsCompatible -co ZOOM_LEVEL=7 -co BLOCKSIZE=512 --config GDAL_TIFF_OVR_BLOCKSIZE 512 orig.tiff reproj.tiff
Code:
from rio_tiler.io import Reader
with Reader("orig.tiff") as src:
    img = src.tile(226,162,8,512)
    f = open("orig.png", "wb")
    f.write(img.render())

with Reader("reproj.tiff") as src:
    img = src.tile(226,162,8,512)
    f = open("reproj.png", "wb")
    f.write(img.render())

rio-tiler reprojected and extracted tile:

gdal reprojected and rio-tiler extracted tile:

The difference is subtle but if you zoom right in, you can see the GDAL reprojected tile appears to have double(?) the vertical pixel resolution.

rio-tiler 6.2.3-post1
rasterio 1.3.9 but built with GDAL 3.8.1
GDAL 3.8.1 for the projection
OSX 14.1.2

@Plantain I wouldn't compare GDAL COG with rio-tiler but you can compare the output of gdalwarp command to read part of your file
import os
from rio_tiler.io import Reader

with Reader("http://static.skysight.io/rio-bug/orig.tiff") as src:
    img = src.tile(226, 162 ,8, tilesize=512, reproject_method="nearest", resampling_method="nearest")
    with open("226-162-8_RIOTILER.png", "wb") as f:
        f.write(img.render())

os.system("gdalwarp -of PNG -q /vsicurl/http://static.skysight.io/rio-bug/orig.tiff 226-162-8_GDAL.png -t_srs EPSG:3857 -ts 512 512 -te 15341217.324948 -5479006.187481 15497760.358876 -5322463.153553 -overwrite")

GDAL

rio-tiler

ahhhhhh this is because of #654 if you use 6.2.2 we get similar output

@Plantain I'm going to closes because it's related to #654

#654 was only resolved in 6.2.7 so any version from 6.2.3 to 6.2.7 would have the same behaviour


Strava Block References

@dvargas92495 What are your thoughts on this integration? Would your workouts automatically be imported block references?

current thought is that {{strava}} components renders into a view to the day's workout (based on daily note page), but am open to ideas!

Audit: Won't do


Cancel Payment command (again and again)

HOLD https://github.com/Expensify/Auth/pull/9797
Details

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/327308
$ https://github.com/Expensify/App/issues/34650
$ https://github.com/Expensify/App/issues/34676
PROPOSAL:
Tests
Pay elsewhere

From an account (account A) create a new workspace and invite account B to it.

Log into account B and request money from the new workspace.

Log back into account A and Pay the money request. Select "Pay elsewhere" It should end up like this:

Confirm you now see the 3dot menu on the top right. Click on it:

Select the cancel payment option. A modal should appear. Confirm the cancellation:

The payment should now be cancelled and you should see a message indicating so. You should now be able to pay again (and you can repeat this process a bunch of times):

After paying the money request report, request money, again, from account B. The request should be created in a new report.

Cancel the payment in the old report. You should end up with two processing reports. Any new requests should go to the newer report.

Pay the newer report. The older one should remain "processing", and any new requests should go to it.

Pay with expensify

Make sure your admin has a valid withdrawal bank account, and your user a valid deposit one
Repeat the previous flow, but using "Pay with Expensify" instead of "Pay elsewhere"
Confirm it basically behaves the same way

Paid policies

Log into oldDot from account A and go to Settings > Workspaces.

Create a new Collect workspace and open it.

Once it is open, follow these steps to make it available in NewDot.

Invite Account B to the workspace.

Log into Account B in NewDot. You should have a room for the new Collect workspace. Request money there.

Make sure your admin has a valid withdrawal bank account, and your user a valid deposit one

Basically repeat the previous flow. Everything should behave more or less the same, with the difference that, after cancelling, the report should go back to an "Approved" state, instead of "Processing" (You should not be able to re-approve it and the "Approve" button shouldn't be visible).

[x] Verify that no errors appear in the JS console

Offline tests
Same as tests, but offline
QA Steps
Same as tests

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@sobitneupane, this is on HOLD for the paid workspaces. You probably can't test that part anyways, so feel free to go ahead and start on this for free workspaces

Removing HOLD for now, as you cn start testing with free plans @sobitneupane

I could not pay the amount from account A.

https://github.com/Expensify/App/assets/25876548/530e22b3-803c-4fd1-9f52-952476a36978

I could not pay the amount from account A.
Untitled.mov
I managed to pay from the Workspace Report Page, but I couldn't cancel the payment with following console error.

 Screen.Recording.2024-02-05.at.13.04.56.mov

Ah, likely something changed after merging main. Taking a look

@sobitneupane, I can't seem to reproduce the issue. I merged main again, can you give it another shot?

Thanks for the update @Gonals. I cannot reproduce the issue any longer.
I was able to reproduce this issue.
https://github.com/Expensify/App/assets/25876548/38c500de-5151-4259-bacb-909f14376a54
I was also able to reproduce this issue and this issue.
https://github.com/Expensify/App/assets/25876548/164d84bc-2ccd-466f-9546-786bc36a3549

Is cancel payment only limited to workspace? I could not cancel payment for transaction between two users.

Ok! Issues fixed!

Negative amount issue fixed
We shouldn't even be displaying the "Marked as reimbursed" message, so removing it.
Due to non-related changes, we now display the Report's title on unsettled reports, so we should no longer see the cancelled/owes change

@Gonals I can still reproduce this issue.

It first shows following message in LHN.

which changes to following message after refreshing.

I found another weird issue. I requested $100 from a workspace(with NPR as default currency) as a member. Then I change the default currency to USD. I paid the amount. Now the message should be either paid $100 or NPR (something) but it is paid NPR 100.0.
Steps to reproduce:

[Member]Go to an workspace(with default currency other than USD) as a member
[Member] Actions> Request money > change the currency to USD and add amount > Next > Request
[Admin] Change the default currency of the workspace to USD
[Admin] Pay the amount
Notice that the amount is in one currency with the symbol of another currency (for example:- NPR100 expected: $100 or NPR (something))

https://github.com/Expensify/App/assets/25876548/195c36f1-3de8-4b25-a3b2-9736a2d341a1

@Gonals I can still reproduce this issue.
It first shows following message in LHN.
which changes to following message after refreshing.

Taking another look! I wasn't able to see it happen, but it is likely due to me being in the canUseReportFields beta, which changes this behavior

I found another weird issue. I requested $100 from a workspace(with NPR as default currency) as a member. Then I change the default currency to USD. I paid the amount. Now the message should be either paid $100 or NPR (something) but it is paid NPR 100.0.
Steps to reproduce:

[Member]Go to an workspace(with default currency other than USD) as a member
[Member] Actions> Request money > change the currency to USD and add amount > Next > Request
[Admin] Change the default currency of the workspace to USD
[Admin] Pay the amount
Notice that the amount is in one currency with the symbol of another currency (for example:- NPR100 expected: $100 or NPR (something))

Screen.Recording.2024-02-08.at.17.53.37.mov

I'd say this is unrelated to this PR. This PR may have made this issue visible, as we were using the wrong function to display these messages before (I'm surprised no one fixed that earlier), but it is not really causing the issue

@Gonals I can still reproduce this issue.
It first shows following message in LHN.
which changes to following message after refreshing.

Taking another look! I wasn't able to see it happen, but it is likely due to me being in the canUseReportFields beta, which changes this behavior

I think this is fixed now. I wasn't able to reproduce it consistently before, but I've tried a few rounds and it seems to work fine now.

Thanks for the update @Gonals . I can no longer reproduce this issue. I will perform more extensive tests and will update.
https://github.com/Expensify/App/assets/25876548/f5003701-eac3-4093-a703-d7a7780576ec

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/blimpich in version: 1.4.42-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.4.42-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


remove duplicated keys

Follow up from @danp' #351
the generation did re-order keys, and they got accidentally added (as dup)

👍, apologies

/assign @Harwayne