WIP - DO NOT MERGE: a missing break in computation of solution diff

@swift-ci Please smoke test

@swift-ci Please smoke test

This was not necessary to reproduce the siesta compiler crash.

@swift-ci Please smoke test

@swift-ci Please smoke test

@moiseev @airspeedswift @xedin I think we need to get this change in so that we can start making progress on working through the remaining issues with unexpected ambiguities.
Any suggestions on what we'll need to update in the standard library to get this fix in?

@rudkx last time we talked, you mentioned some other change that needed to be applied before this one. If that's done – we just need to add this break and fix what breaks.

@moiseev It's not that we need to apply another one before this, it's that this is just one known issue with a problem around how we disambiguate. I thought we might be able to tackle all of them at once but that's unlikely to happen and in the mean time this particular issue is obviously quite bad, easy to fix (well, the compiler part for sure), and leaving it in could lead to more unnecessary changes being made to the stdlib to "account" for it.

@xedin took care of this. Closing.


fix: jupyter-notebook issue issue-547

Kindly asking for a review - I removed the "python"-language alias which causes #547

Codecov Report

Merging #570 (42f1ac9) into master (471a04d) will decrease coverage by 1.09%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master     #570      +/-   ##
==========================================
- Coverage   60.28%   59.19%   -1.10%
==========================================
  Files          18       18
  Lines         841      843       +2
  Branches      170      169       -1
==========================================
- Hits          507      499       -8
- Misses        334      344      +10

Impacted Files
Coverage Δ

src/extension.ts
22.47% <0.00%> (+0.24%)
:arrow_up:

src/authextension.ts
42.50% <33.33%> (-2.24%)
:arrow_down:

src/redhatTelemetry.ts
60.86% <55.55%> (-2.77%)
:arrow_down:

src/multimanifestmodule.ts
46.26% <0.00%> (-5.98%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad4a33f...42f1ac9. Read the comment docs.

Thanks for the fix, I verified this change and works as expected

Thanks for the merge. :-)


perf: refactor benchmarks to js framework benchmark]

Please describe the changes this PR makes and why it should be merged:
Status

[x] Code changes have been tested against prettier, or there are no code changes
[x] I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

[x] This PR changes the codebase

[ ] This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
[ ] This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)

[ ] This PR only includes non-code changes, like changes to documentation, README, etc.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
32

Relevant Lines:
32

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
32

Relevant Lines:
32

💛  - Coveralls


Fixes issue #1

Hi @scottwedge , thanks for the PR
The issues and non issues have been resolved in the commit c1a632aec0c4572e94acce1d34f15245e39ce61b
Thanks again!


Migrate SnsIO.write to async implementation

In  BEAM-13203 SnsIO.writeAsync was deprecated to address the risk of data loss in that transform. Unfortunately, it has considerable issues in design and implementation with respect to the beam programming model as well as general async programming:

Output for a bundle may be emitted even after the bundle is finished (lack of join / waiting for pending futures), additionally output is emitted from multiple threads risking concurrent modification issues on underlying data structures.
Exceptions disappear into the void (respective tests are implemented incorrectly as they don't throw asynchronously and could make one think this works).
Parallelism is unlimited causing the writer to instantly accumulate everything into memory.

With BEAM-13563 it will be possible to change SnsIO.write into a more performant async implementation without any breaking changes to the public user facing API making SnsIO.writeAsync obsolete.
Imported from Jira BEAM-13824. Original Jira may contain additional context.
Reported by: mosche.

A new async implementation should also use the batch API, see related
https://github.com/apache/beam/issues/21429


Support for monochrome framebuffer

Currently, fbdev driver does not support monochrome framebuffers.
The attached patch adresses this issue. I've tested on linux with ssd1307 frame buffer driver (https://github.com/torvalds/linux/blob/master/drivers/video/fbdev/ssd1307fb.c) and it worked perfectly.
fbdev_patch.txt

Hi,
Thank you!
Can add your update as a Pull request?


[Env] Set up the RN JS environment before requiring other modules

Set up the polyfills for console and process before initializing other modules. Some modules do work (e.g. call invariant) when they are first required, so requiring the DefaultInjection module at the beginning ensures we have a consistent JS environment.
Test Plan: There is a packager bug that bundles a copy of invariant from npm under the name "invariant", which conflicts with RN's copy of invariant. That bug should be fixed, but it revealed another bug in which the JS environment doesn't get set up until a couple modules have already been required.
With this diff, the npm copy of invariant, which relies on process.env`, no longer fatals.

cc @martinbigio there's a second bug related to the packager as well (#3525). We could ask the upstream maintainer of invariant to remove the Haste docblock though making the packager more robust seems like the "right" solution.

lgtm, let me run some fb tests

@facebook-github-bot import

I don't understand what this fixes. invariant shouldn't rely on ReactNativeDefaultInjection at all. I guess it's that the exception logging isn't set up?
The packager should really have a way to insert require('InitializeJavaScriptAppEngine') before any code which would solve all of these problems. As is, this solution doesn't work if you require ReactNative late in your own app's code. I thought @amasad was going to add that feature. (Though now @vjeux tells me he'll do it if it's not done soon.)

@spicyj There are two bugs at hand. The first is that the packager is not namespacing packages correctly -- RN ships with a file containing @providesModule invariant and there is also a file on npm with the same Haste pragma. The JS bundle defines two modules named "invariant" instead of munging/namespacing at least one of them.
So what's happening is that the "invariant" from npm ends up clobbering RN's copy. It references "process.env" inside of it, but there's code in RN that calls invariant before the process.env stub is set up.
The second bug (which this PR addresses) is the fact there is code within RN that runs before require('InitializeJavaScriptAppEngine') does. I agree with your general observation that InitializeJavaScriptAppEngine should run before anything (RN and app code) -- since I have control over my app code I can easily make sure import react-native comes before anything else, but need a PR like this to ensure InitializeJavaScriptAppEngine is set up before RN's internal code.

The first is that the packager is not namespacing packages correctly

Haste names are global by design and I don't think we've ever intended to namespace them.

The JS bundle defines two modules named "invariant"

This sounds like a bug. From my understanding, it is supposed to give you an error at bundle time.

since I have control over my app code I can easily make sure import react-native comes before anything else

I'd rather fix it for everyone, including our internal apps, none of which import react-native first.

Haste names are global by design and I don't think we've ever intended to namespace them.

There are people publishing modules with @providesModule to npm. We could tell them to quit it but I also think the packager should be robust if possible.

If you require('invariant') and have two packages in node_modules that have @providesModule invariant, which should you get?

You should get neither, but if you have a file with @providesModule invariant in your own package you should get that. That is, @providesModule should be scoped to the npm package.

Oh, I see.


Correctly find all critical CRL extensions

Unhandled critical CRL extensions were not detected if they appeared
after the handled ones.  (GitHub issue 1757).  Thanks to John Chuah
for reporting this.

Fixes #1757

Have you double checked that this is already done correctly in master and 1.1.0?

commit 3ade92e, thanks.

No tests? This one's pretty straight-forward to write a regression test for:
https://boringssl-review.googlesource.com/c/11720/

Can I get permission to use this test in openssl, with openssl copyright?

Yes, I looked.  The loop is different, it’s in x509/x_crl.c

(Responded on the PR.)

Thanks ☺


CouchDB Spray client

Testing pending. Currently for reviewing purposes only.

Made an initial pass and will review the substantial parts again more slowly.
Is it true that couch in a box (local instance) is now http?

The first commit broke a deploy script. Fixing that.

I fixed the shell script issue (which is why, I assume, the commits are not in logical order in the GitHub listing; probably sorted by commit date).
Perf PG 266

pg 208 post rebase, and pg 209 post-(post-rebase)-rebase

Merged as 64b74938c7eb113a3c8e78444f3ae2b20f65974a


Improve error message when you enter a zip code that can't be found

With the addition of ZIP code search, I've heard from one user that I think was rightfully confused that they couldn't search for zip codes in other states and get any results. I think in the error message when a ZIP code isn't found in your state, we could provide better guidance on this and maybe point towards the other states.
This could also perhaps be made better by improving the overall navigation so it's more obvious how to switch between states: https://github.com/GUI/covid-vaccine-spotter/issues/52
There's maybe a broader issue here of whether or not the state-centric search makes sense, but I'm sort of in favor of keeping it that way for the purposes of this tool. I'm doing a sort of dumb client-side ZIP code lookup so I don't have to pay for geocoding services, and while loading an entire state's worth of zip codes is semi-okay (still a bit big), loading the entire US would probably be too much. And given the state-centric nature of vaccinations, I think this state-based approach mostly makes sense, it's maybe just less convenient if you're helping friends in other states and needing to swap between states.

I think I have an idea for doing this fairly efficiently. US Zip Codes generally follow a pattern. Since you're wanting to keep this client side, we could send a payload of zip code prefixes associated with each state. Then, when the user enters a zip code, the first three digits they enter are cross-referenced to this data. If it is found that the zip code belongs to another state, the can automatically be redirected to the proper state's page. Then, the results for this zip code will be displayed.
The zip code prefixes I mentioned are easily viewable at https://en.wikipedia.org/wiki/List_of_ZIP_Code_prefixes.
If this sounds like a good approach, I would be happy to work on contributing this!


[roi] add isIn functions

Few comments:

isIn:

you definitely have to rename it into contains
remove "pixel" from the documentation. There is nothing about screen, so if think it would be much better to talk about "point".
:param Union[float,tuple] value: as the function is inherited, arguments must always be the same. The input argument must always be Union[Tuple[float,float]].

BoundingBox, maybe you could move it into silx.math?

A few comments:

+1 for contains (as in QRect) and a unique kind of argument.
For the docstrings, you probably want to use a generic docstring and the docstring decorator (https://github.com/silx-kit/silx/blob/658dd96021ecaa3d94d5b3434cb0eaff0333fc5c/silx/utils/proxy.py#L226)
I would avoid definition of functions within function and put lines_intersection and segments_intersection somewhere else. BTW, in the OpenGL backend I'm using: https://en.wikipedia.org/wiki/Cohen–Sutherland_algorithm which does the same unless I missunderstood (https://github.com/silx-kit/silx/blob/master/silx/gui/plot/backends/glutils/GLPlotCurve.py#L1299).
BoundingBox could be moved to silx.image since it is 2D.. or kept private for now.


Add services_to_ips.pxl

Returns a list of services that have active traffic to a list remote IPs.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I recommend we just use #111 because it has a vis spec + new query language features

This is supersedes by https://github.com/pixie-labs/pixie/pull/111


'go mod tidy' + replaced a dependency that isn't resolvable

The dependency on vbom.nl/util is failing for pristine environments, such as the one used by 'dependabot'. This is a transitive dependency from the operator-sdk -> kubectl.
Signed-off-by: Juraci Paixão Kröhling<EMAIL_ADDRESS>

@jpkrohling Any idea what is the underlying problem? This may be ok as a workaround, but would be good to understand whether there is a bug somewhere that needs to be tracked?

Basically, the author of the module was using a vanity URL (vbom.nl) that isn't available anymore, breaking pretty much every project that depends, even transitively, on kubectl.

Looks like kubectl 1.20 should have a fix - so need to remove this after updating.


Very appealing

The experience just feels right. Good work! Keep it up.

This is an amazing project!

btw how does the Component Previewing work? At the moment its blank for me whenever I try to preview a component

Thanks a lot guys, this is just a beginning. We'll certainly make it way better over time. For now, it is mostly just a draft. :)
@joshuaquek the component preview is something I'll focus my effort on for the next update. It is not indicated but the first time you'll try to preview something, it'll take some time to install required modules to compile your code. So far, it doesn't indicate it anywhere and keeps showing "compiling...".
If you have any interest, you can dive into the code and give it a try. There is nothing fancy, only plain javascript and react components. 😄
Thanks again guys, your words mean a lot.


Base Space Engineers server has possible config issues (Out of date?)

Bug Report
System Information

Win 10 Pro 20H2
AMP Release "Callisto" v<IP_ADDRESS>, built 26/07/2021 12:53
Mainline

I confirm:

[x] that I have searched for an existing bug report for this issue.
[x] that I am using the latest available version of AMP.
[x] that my operating system is up-to-date.

Symptoms

What are you trying to do?

Start a Space Engineers server.

What are you expecting to happen?

Create a new instance, install server, set up configs through AMP, everything works fine

What is actually happening? ('Nothing' is not an acceptable answer!)

Everything works, but when you get in-game it is impossible to obtain ore by using the base hand drill.  The nuggets simply don't spawn when you drill the ground.
After playing with configs for a while, searching online, posting on the forums and not being able to find anyone with the same issue, I started a fresh instance and had the same issue.  I then navigated to the dedicated server folder manually,  launched the dedicated server tool for the game and launched a fresh server directly and the game worked fine.
On comparison it looks like there are some considerable differences in the config files and the game has undergone some bigger updates so this seems likely to be the issue.  Not only does it look like there may be some new lines not included with the base one on AMP (Which may be fine if they are only needed to change defaults), it does look like some existing config lines have been changed or renamed from what they are in the AMP config.
Reproduction

Create a new Space Engineers instance
Configure it however you like
Once all installed, launch the server and join it.  You will not be able to progress or obtain any ore.

This Settings are missing without some of them Server is unplayable. https://hastebin.com/umosavovap.xml

<BlockTypeLimits>

true
false
99
false
true
false
0
0
0
true
false
1
true
1
false
5
false

Settings above all Belong in the   bracket

false
true
0
true
false
10
15

 (Random Chars(Numbers, Letters in between)
0.05
5
Server will be shut down in {0} min(s).
true
steam
false

The Settings above belong under the   bracket. All Settings are Posted with the Default Values

Added missing session settings for the next update.


Use the v4 IAS API and the 2.11 SGX SDK

Tested with real hardware against the live IAS.

Closing in favor of #2 that includes SGXSSL properly.


Bold text on some properties

Hello, thank you for great theme.
I've just installed it, and see some issues with bold text:

This is how it looks on my Atom editor with the same theme:

Hey @Kolyasya,
Sorry, I didn't see this issue before - I must have turned off notifications by mistake. My bad.
I just did an update to the theme that removes a bunch of unnecessary bolds and add a few missing scopes. Please install 2.0.0 when you can! (You may need to have to re-select the theme again from the menu)

Closed as it should be fixed. Please let me know if you run into any other issue.

Hello! I've reinstalled theme and still have bold text

The language is Javascript React if it matters

Hey Kol


Issue 6365 - Multiple var declaration (AutoTupleDeclaration)

http://d.puremagic.com/issues/show_bug.cgi?id=6365
Based on #321, declare multiple variables at once, and initialize them in the corresponding tuple fields.
Syntax:

TupleDeclaration:
    StorageClasses ( TupleTypeList ) = Initializer ;
    ( TupleTypeList ) = Initializer ;

TupleTypeList:
    TupleType
    TupleType , TupleTypeList

TupleType:
    StorageClasses BasicType Declarator
    BasicType Declarator
    StorageClasses Identifier
    Identifier

TupleTypeList is similar to ForeachTypeList.
If you want to write left parenthesis at beginning, you cannot omit the type or storage class of first variable.

(x, y) = getCoordinate();  // NG, this is not multiple var declaration
(auto x, y) = getCoordinate();  // OK
(double x, y) = getCoordinate();  // OK, types are specified explicitly

I love this idea.  Is there any language design-level reason why it shouldn't be included or are we just waiting for Walter to get around to merging it?


metric: fix the incorrect txn size metric usages

The TxnWriteSizeHistogram shortcuts should use TiKVTxnWriteSizeHistogram objects.

/merge


I completed CS50, should I start Introduction to Computer Science and Programming using Python

I completed CS50 and now wondering if I should start intro course: "Introduction to Computer Science and Programming using Python"  or skip it? CS50 was my first course about programing. Would be intro course useful for me?

@Rita1 as noted in the curriculum, Intro CS is recommended "for students to try out CS and see if it's right for them". If you completed CS50 and found yourself interested in learning more, I recommend diving into Core CS. I also suggest that if you have more questions about individual approach (rather than suggested changes to the curriculum) that you post in the OSSU CS Gitter. There are often individuals there who will be happy to talk about their experience and offer advice.


Fix the build

Running yarn ember try:each would fail on recent ember versions. The PR makes the minimal updates to get the project building again. Can be reviewed commit by commit. There are still a bunch of warnings that can be cleaned up in subsequent PRs.

https://www.notion.so/qonto/Fork-and-fix-ember-api-actions-build-184cb624f8874f9db8af0566834c056b

One question: why settled is now required for the test suite to pass? Did it work for earlier Ember versions and stopped for newer ones?

Two questions ;)

Did it work for earlier Ember versions

Yes, think it's breaking for 4.x

Why settled

Not sure of root cause, want to do minimal required to get the build working. Hoping that settled can be removed in future MRs, maybe when @ember/test-helpers is updated or some other dependency?

Invite sent!


endConversation is not working

Hello,
I am using the latest sdk, in directline session.endConversation("endmessage") seems not working.
What can I do instead to end the conversation properly?
Thank you

Hi tahsintahsin,
Thank you for your submission.   However, the Microsoft Bot Framework team prefers that how to and clarification questions be submitted on Stack Overflow. The official Bot Framework Github repo  is the preferred platform for submitting bug fixes and feature requests.

Please submit your question over on Stack Overflow and one of our support engineers will help you out as soon as possible.  As a suggestion: also indicate more succinctly what exactly is "not working".


fix: same vcs info appened twice when running jf rt build-add-git command twice

[x] All tests passed. If this feature is not already covered by the tests, I added new tests.
[x] All static analysis checks passed.
[x] This pull request is on the dev branch.
[x] I used gofmt for formatting the code before submitting the pull request.

@eyalbe4 Thanks! I found evidence that this whould be fixed by a go upgrade, so I merged to already approved (at least partly) sibling PR: https://github.com/jfrog/build-info-go/pull/249

Hey @gerrnot
We've just update to go 1.22.3,
Can you confirm that the issue is resolved by updating the go version?

I have read the CLA Document and I hereby sign the CLA

@EyalDelarea Thanks, yes, the build was green after that. I rebased.


twin info get updated

each time i used the go client, twin info get updated. i believe for some reason public key info is set to null.

please try on a fresh account and if the problem still stands let's reopen


[ci] Run GTK tests as separate job

The linux builds are by far the slowest part of CI, and we
should see some modest gain by splitting them in two.

Looks like this gives us a reasonable speedup; testing wasm is now the bottleneck.


Updated repository organization.

This PR resolves the following issues:

#28
#29

In addition to these two issues, I've included the defaultSolution setting added by the C# Dev Kit by default to complete issue #27

There are two files in this PR that should not have been included yet. I will push an update that removes them.

This PR fixes issue #28.

This PR fixes issue #29.


Updated CHANGELOG

Please use this template to ensure easier processing of your pull request
Category

[X] Content fix
[ ] New article
[x] Example checked item (delete this line)

Docs Build status updates of commit 4b2a70c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

CHANGELOG.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Fix: Sync Representations query limit

Big queries might block the server to process because they are too heavy (>100MB). Fixed by limiting the aggregation to a certain amount.
Testing notes:

Stop Openpype of a site
Assign a lot of representations to the site
Restart OP on the site

You can use these files by changing the extension to .py:

Remove all representations of site: adhoc_site_sync_remove_site.txt
Add all last and hero version to site (around 19000 repres): sync_all_hero_and_last_versions_representations.txt

NB: If run headless, make sure the site name env var OPENPYPE_LOCAL_ID is set correctly.

I left the adhoc_site_sync_remove_site running for hours and it was just skipping every sites one after another endlessly

I left the adhoc_site_sync_remove_site running for hours and it was just skipping every sites one after another endlessly

I need to know the site's name you ran it on. Are you sure the OPENPYPE_LOCAL_ID was correctly set?

I left the adhoc_site_sync_remove_site running for hours and it was just skipping every sites one after another endlessly

I need to know the site's name you ran it on. Are you sure the OPENPYPE_LOCAL_ID was correctly set?

My local ID is grinning-toad-of-abracadabra, do I need to manually set this environment variable?

I left the adhoc_site_sync_remove_site running for hours and it was just skipping every sites one after another endlessly

I need to know the site's name you ran it on. Are you sure the OPENPYPE_LOCAL_ID was correctly set?

My local ID is grinning-toad-of-abracadabra, do I need to manually set this environment variable?

I've edited the adhoc_site_sync_remove_site script which should be much more optimized, you tell me


Create, Edit, Delete NSG rules

A script for someone to logon and then go through steps to create, edit or delete nsg rules from a NSG.

The Edit function is still incomplete.
The current state of the script doesn't allow for it to be single click deployment of multiple NSGs on subnets or VMs. Still need to think on how I could make that work.


Is this project active?

Hi.
I want to help, but I want to know if this project is active. Is this project active?

Hey @raphaellouisandress,
Yes it is still active, it's just that I didn't have the chance to update it recently! 🙌

Hi @kekkorider, how are you?

Yes it is still active, it's just that I didn't have the chance to update it recently! 🙌

thanks for information!


Feature Request LiveWire

As for ->html and ->view it would be nice with a ->liveWire('my-livewire-component')
Sure, I can use views but...

Just reference the livewire blade directly works! Happy!

@ekandreas
Could you please explain more so other users can use your info? Thanks!

Just call it! Eg,
return [
            (new HtmlCard())->width('1/3')->view('livewire.cards.my-awesome-livewire-component'),
];

How do you handle "wire:click" when loading your livewire components? all my functionallty is gone when loading livewire component with this example

I don't! Right now we can't get the Livewire to work in a html card as it is rendered as plain html-code and not as an interactive php component.

@daggemarren
@ekandreas
In our team we don't use livewire, so we don't have plans to support this. Feel free to create a PR for support it.

Sorry to hear that! The TALL stack is awesome!

Ok, then... Heard of Blade x-components in Laravel? Also a kind of dynamic rendering in blade...

@ekandreas
that's a great idea! You re welcome to create a PR. We’ve added it to our backlog, but it as not a high priority, I assume we'll find a time for it in 1-2 months. So, you can help us to implement it faster ;)


a11y: support prefers-reduced-motion: reduce

Is your feature request related to a problem? Please describe.
Accessibility support for reduced motion
Describe the solution you'd like
https://twitter.com/nathansmith/status/1242606456677040128
Describe alternatives you've considered
none
Additional context
As we are getting more into design and motion within the various apps, we need to be cogitative of people who are sensitive to motion.

:tada: This issue has been resolved in version 2.8.14 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Websockets, Channels, PubSub and Presence

Hi everyone, I'm up for grabs to a Websocket + PubSub + Presence implementation for Giraffe. I think that, with the needs of realtime web, and from my experience seeing people coming from Rails to Elixir + Phoenix Framework for realtime + performance, it's something we should consider to have an implementation in Giraffe out of the box.
So I want to open a discussion on the idea. My initial roadmap is to have the following:

Add websockets + channels to the routing layer of Giraffe.
Create a JS library to handle the channel layer.
Add support for PubSub.
Add presence on top of PubSub.

For someone who is not familiar with Channels, the ideia is that we can route messages to specific topic:subtopic, much in a way an URL route is, so you can run authentication/authorization rules specific for each channel.
For the PubSub layer, well, if you are running multiple instances of Giraffe, you need a way to broadcast to all connected clients to that channel, independently if they are connected to node 1 or 2. So, my idea is to have an in-memory backend for testing purposes and an Redis backend. Maybe use the Microsoft.Extensions.Caching.* namespace (?). Probably need some advice here. :)
For the Presence layer, the idea is to have a CRDT, so you can, for example, count the amount of devices for account X, connected in the channel, at the same time. For example, if John is connected both on his phone and on a web browser, it should show John only once. Or you can just show John <mobile> <desktop>, for example. The sky is the limit. :)
Thoughts?

@imetallica Hey, when you say 'you're up for grabs', are you saying you're building it?
I fully agree it would be a nice thing to work towards, but I noticed you didn't mention SignalR at all, it seems bit mad to build a whole new system from scratch when same can be achieved with a system built on top of asp.net core already?
It is possible to use the low-level api's in SignalR to avoid all the hubs controllers and proceed to replicate HttpHandler pipelines for subscribed events etc. so it becomes a task of integrating SignalR into functional pipeline more then anything else.

@gerardtoconnor yes I'm up for building it. The reasoning I didn't mention SignalR is because there is no implementation yet for core. We could wait or we could roll our own and when SignalR comes we migrate to use it.

@imetallica https://github.com/aspnet/SignalR

With SignalR being ported to ASP.NET Core by Microsoft is there still anything to do here or can this be closed?

Yeah it's pretty pointless when SignalR is in place so can be closed.


MsgConnOpenTry builder and CLI

Closes: #372
Description

new the raw tx conn-try CLI
version handling, validation, (de)serialization)
merkle proof (de)serialization
basic functions to create the ConnTry message that can be used with minimal changes from the relayer
changed ConnInit and the client messages builders to allow usage from the relayer
add proven_.. queries that return proofs
changed some queries to use ICSHeight instead of tendermint defined Height

For contributor use:

[ ] Updated the Unreleased section of CHANGELOG.md with the issue.
[ ] If applicable: Unit tests written, added test to CI.
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Updated relevant documentation (docs/) and code comments.
[ ] Re-reviewed Files changed in the Github PR explorer.

Codecov Report

Merging #388 (dcb1be6) into master (b1b37f5) will increase coverage by 19.9%.
The diff coverage is 65.1%.

@@            Coverage Diff            @@
##           master    #388      +/-   ##
=========================================
+ Coverage    13.6%   33.6%   +19.9%
=========================================
  Files          69     147      +78
  Lines        3752    9655    +5903
  Branches     1374    3313    +1939
=========================================
+ Hits          513    3250    +2737
- Misses       2618    6154    +3536
+ Partials      621     251     -370

Impacted Files
Coverage Δ

modules/src/events.rs
0.0% <0.0%> (ø)

modules/src/ics02_client/events.rs
0.0% <ø> (ø)

modules/src/ics02_client/msgs.rs
0.0% <0.0%> (ø)

modules/src/ics02_client/raw.rs
0.0% <0.0%> (ø)

modules/src/ics03_connection/error.rs
13.6% <0.0%> (-19.7%)
:arrow_down:

modules/src/ics04_channel/error.rs
75.0% <ø> (+50.0%)
:arrow_up:

modules/src/ics04_channel/packet.rs
0.0% <0.0%> (ø)

modules/src/ics07_tendermint/client_def.rs
0.0% <0.0%> (ø)

modules/src/ics07_tendermint/error.rs
75.0% <ø> (+75.0%)
:arrow_up:

modules/src/ics18_relayer/error.rs
0.0% <0.0%> (ø)

... and 271 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2858779...bde1468. Read the comment docs.


Fix for critical vulnerability - CVE-2023-45853 (BDSA-2023-2778) - related to zlib

Question
Is the high score vulnerability - CVE-2023-45853 (BDSA-2023-2778) - which affects the files libjli.so/libzip.so fixed on any latest JDK 17 or 21 versions?
Context
Java version: 17 or higher

OS : Linux 64 Bit- RedHat

Yes, please upgrade to the latest.

Verified the Source code of 21 - https://github.com/adoptium/temurin21-binaries/releases/download/jdk-21.0.2%2B13/OpenJDK21U-jdk-sources_21.0.2_13.tar.gz, having the same issue.

@osramesh You can report this to<EMAIL_ADDRESS>


Fix typo in as reported in issue #62

Description
Fix typo in as reported in issue #62 by @jseemann
Related Issue
#62
Motivation and Context
Fix typo
How Has This Been Tested?
Fix in text output, no testing required.
Screenshots (if appropriate):
Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:
Go over all the following points, and put an x in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTION document.
[x] I have updated the CHANGELOG file accordingly for the version that this merge modifies.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Resolve #62


Use protocol-relative URL for jQuery script

So after a while of not using Ghost I upgraded from 0.9.0 to 0.11.2, then I noticed the menu didn't work, because for some reason "https://code.jquery.com/jquery-1.12.0.min.js" was not resolving:

So I tried "http://code.jquery.com/jquery-1.12.0.min.js" and it was working perfectly, same with "//code.jquery.com/jquery-1.12.0.min.js" since my blog doesn't use SSL .
I see that the link to fonts.googleapis.com is a protocol-relative URL, so it would be good to do the same with code.jquery.com?

Seems like a sensible & consistent change to make, thanks 👍


Error compiling. Azure might have changed SDK

../github.com/graymeta/stow/azure/container.go:61: c.client.ListBlobs undefined (type *storage.BlobStorageClient has no field or method ListBlobs)
../github.com/graymeta/stow/azure/location.go:23: l.client.CreateContainer undefined (type *storage.BlobStorageClient has no field or method CreateContainer)
../github.com/graymeta/stow/azure/location.go:112: l.client.DeleteContainer undefined (type *storage.BlobStorageClient has no field or method DeleteContainer)

@piotrrojek Can you have a gander at this please?


chore: upgrade lingui to 2.8.0

Overview
I added a feature to lingui that allows a config file to be specified which really helps out with our externalplugins configuration. Therefore we no longer need to swap out config files when extracting messages.
The practical result is simplified lingui-extract and lingui-compile scripts
Testing
check out companion plugins-private PR https://github.com/mesosphere/dcos-ui-plugins-private/pull/1008

npm run util:lingui:extract
npm run util:lingui:compile
(With and without plugins-ee symlink)

Dependencies
I had to rename the .linguirc config file in the plugins-private repo (https://github.com/mesosphere/dcos-ui-plugins-private/pull/1008)

Build is failing with npm ERR! cipm can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with npm install before continuing..

:tada: This PR is included in version 2.111.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Amend authorized-changes users for PostgreSQL Operator

This adds "jkatz" as one of the authorized-changes users for
the PostgreSQL Operator projects.

/hold cancel

/merge possible


The minimum required Cuda capability is 6.0 for the binary C-API releases 1.14.0 and 1.15.0

System information

OS Platform and Distribution: Ubuntu 18.04
TensorFlow installed from: binary C-API release (https://storage.googleapis.com/tensorflow/libtensorflow/libtensorflow-gpu-linux-x86_64-1.14.0.tar.gz)
TensorFlow version: 1.14.0
Docker image: tensorflow/tensorflow:1.14.0-gpu-py3
GPU model and memory:

+-----------------------------------------------------------------------------+
| NVIDIA-SMI 440.59       Driver Version: 440.59       CUDA Version: 10.2     |
|-------------------------------+----------------------+----------------------+
| GPU  Name        Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp  Perf  Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
|===============================+======================+======================|
|   0  GeForce GTX 960M    Off  | 00000000:01:00.0 Off |                  N/A |
| N/A   36C    P8    N/A /  N/A |      0MiB /  2004MiB |      0%      Default |
+-------------------------------+----------------------+----------------------+

+-----------------------------------------------------------------------------+
| Processes:                                                       GPU Memory |
|  GPU       PID   Type   Process name                             Usage      |
|=============================================================================|
|  No running processes found                                                 |
+-----------------------------------------------------------------------------+

Describe the problem
Using the C-API, the following error occurs when attempting to run inferences with the above GPU setup.
2020-02-18 09:42:51.504548: I tensorflow/core/platform/cpu_feature_guard.cc:142] Your CPU supports instructions that this TensorFlow binary was not compiled to use: AVX2 FMA
2020-02-18 09:42:51.529888: I tensorflow/core/platform/profile_utils/cpu_utils.cc:94] CPU Frequency:<PHONE_NUMBER> Hz
2020-02-18 09:42:51.530480: I tensorflow/compiler/xla/service/service.cc:168] XLA service 0x555dbf23f760 executing computations on platform Host. Devices:
2020-02-18 09:42:51.530508: I tensorflow/compiler/xla/service/service.cc:175]   StreamExecutor device (0): <undefined>, <undefined>
2020-02-18 09:42:51.531487: I tensorflow/stream_executor/platform/default/dso_loader.cc:42] Successfully opened dynamic library libcuda.so.1
2020-02-18 09:42:51.541446: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:1005] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
2020-02-18 09:42:51.542021: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1640] Found device 0 with properties:
name: GeForce GTX 960M major: 5 minor: 0 memoryClockRate(GHz): 1.0975
pciBusID: 0000:01:00.0
2020-02-18 09:42:51.542289: I tensorflow/stream_executor/platform/default/dso_loader.cc:42] Successfully opened dynamic library libcudart.so.10.0
2020-02-18 09:42:51.543592: I tensorflow/stream_executor/platform/default/dso_loader.cc:42] Successfully opened dynamic library libcublas.so.10.0
2020-02-18 09:42:51.544681: I tensorflow/stream_executor/platform/default/dso_loader.cc:42] Successfully opened dynamic library libcufft.so.10.0
2020-02-18 09:42:51.545006: I tensorflow/stream_executor/platform/default/dso_loader.cc:42] Successfully opened dynamic library libcurand.so.10.0
2020-02-18 09:42:51.546594: I tensorflow/stream_executor/platform/default/dso_loader.cc:42] Successfully opened dynamic library libcusolver.so.10.0
2020-02-18 09:42:51.547771: I tensorflow/stream_executor/platform/default/dso_loader.cc:42] Successfully opened dynamic library libcusparse.so.10.0
2020-02-18 09:42:51.551039: I tensorflow/stream_executor/platform/default/dso_loader.cc:42] Successfully opened dynamic library libcudnn.so.7
2020-02-18 09:42:51.551147: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:1005] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
2020-02-18 09:42:51.552024: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:1005] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
2020-02-18 09:42:51.552531: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1717] Ignoring visible gpu device (device: 0, name: GeForce GTX 960M, pci bus id: 0000:01:00.0, compute capability: 5.0) with Cuda compute capability 5.0. The minimum required Cuda capability is 6.0.
2020-02-18 09:42:51.585097: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1181] Device interconnect StreamExecutor with strength 1 edge matrix:
2020-02-18 09:42:51.585122: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1187]      0
2020-02-18 09:42:51.585128: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1200] 0:   N

This issue has previously been raised and fixed in https://github.com/tensorflow/tensorflow/issues/25329 for another setup, but the error remains when using the C-API.
I have also confirmed the same issue when using the 1.15.0 binary release.

I am using tfjs-node-gpu, which uses the binary C-API release (https://storage.googleapis.com/tensorflow/libtensorflow/libtensorflow-gpu-linux-x86_64-1.14.0.tar.gz)。         My GPU is Titan X, which has cuda capacity 5.2.
I got exactly the same error:
I tensorflow/core/common_runtime/gpu/gpu_device.cc:1717] Ignoring visible gpu device (device: 0, name: GeForce GTX TITAN X, pci bus id: 0000:02:00.0, compute capability: 5.2) with Cuda compute capability 5.2. The minimum required Cuda capability is 6.0.

@johan-andersson01,
Could you please provide the exact sequence of commands that you executed before running into this issue? Thanks!

Any updates regarding this issue? Thanks!

Unfortunately I can't publish the original code, but I'll try to create a simpler working example when I find the time. Thanks for your patience. :)

@johan-andersson01,
Did you get the time to work on the example? Thanks!

Any updates regarding this issue? Thanks!

Automatically closing due to lack of recent activity. Please update the issue when new information becomes available, and we will reopen the issue. Thanks!

@amahendrakar I am having the same issue.
With
{"dependencies": {"@tensorflow/tfjs-node-gpu": "^1.7.3"}} as package.json
followed by npm install and importing tfjs-node-gpu
const tf = require('@tensorflow/tfjs-node-gpu');
I get the error @johan-andersson01 printed. I am using GeForce GTX 960M as well, tensorflow 1.15.0.

@MitskiP,
Could you please create a new issue from this link and fill in the issue template, so that we can track it there. Thanks!


C++/WinRT variant of each sample app to show C# to C++/CX to C++/WinRT cycles of learning

For each of the C++/CX cpp versions of these sample apps, please •add• a C++/WinRT version too.  Please don't •replace• the C++/CX version in the cpp subdirectories with C++/WinRT as time marches onward.  In addition to the existing cpp subdirectories, please add a cppwinrt subdirectory, so that developers can see a before & after version in C++/CX versus C++/WinRT (as well as compare to C# so that developers can see the incremental/smaller mental leaps from C# to C++/CX to C++/WinRT).  The C# and C++/CX variants of each app will resemble each other more than the C++/CX and C++/WinRT variants will resemble each other.  Comparing the C# and C++/WinRT without preserving the C++/CX incremental step would excessively complicate cycles of learning; people learn better deeper faster when traversing multiple smaller incremental cycles of learning than one big larger one-big-gulp cycle of learning.
As much as one would like conversion to C++/WinRT to be only minor mechanical edits, the fact that C++/WinRT represents what would otherwise seem (historically) like strongly-typed types (in the C++ sense of types) to instead be object instances with value semantics that encapsulate operations that represent an ATL/COM type in a WinRT component (.DLL & .winMD file-pair).  Because of this splitting of true C++ types versus COM-typish objects in C++/WinRT, sometimes the transformation from C++/CX to C++/WinRT is substantially different, as C++/CX ^ actual-type operations/casting/polymorphism/template-parameters get reworked in C++/WinRT to be value-semantics operations on object instances that merely conceptually represent types.  Sometimes when converting from C++/CX to C++/WinRT, it is merely the matter of a quick-&-dirty little editing trick of putting () here or replacing -> with . there.  But other times what was a terse type-cast from one ^ type to another ^ type in C++/CX gets transformed into at least a .as or .try_as, and perhaps greater multi-line overhaul than that.  Analyzing the various categories of greater overhaul that is occasionally necessary is the true substantial learning opportunity in comparing the C++/CX cpp variant with a C++/WinRT variant.
Btw, this applies to the XAML samples only as C++/WinRT's support for code-behind the XAML compiler emerges.

Yes, we already have work items tracking the addition of C++/WinRT samples.

The conversion to C++/WinRT has begun - if there are specific samples you would like to prioritize over others let me know.


Switch to simpler peering path construction

The current codebase uses 3 HopField's (HopF 0, HopF peer, and upstream HopF) for a peering AS in a path. The updated design in the book uses 2 HopFields (HopF peer and HopF 0). We need to update the code to the new design. It's both simpler, and uses 8B fewer in the path header.

Replaced by the header v2 proposal (#3714).


draw_keypoints() float support

Follow-up PR: #8150
Issue: #8138
Hey there!
I've added functionality to the draw_keypoints() method, allowing it to handle both uint8 and float32 image types.
I welcome any feedback you may have on these changes.
Thank you!

Hey @NicolasHug,
Thank you for pointing out my mistakes. While it might be second nature for you to find these bugs, I am still in the learning process. I apologize for making you go through my code once again.
Thanks again.

No problem at all @GsnMithra thank you for the PR


Add overflow-checking variants of arithmetic dyn kernels

Which issue does this PR close?

Closes #2739.
Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

cc @sunchao

The CI failure looks unrelated.

I would move away from using trusted len iter, it's basically a hack and internal iteration will optimise better or the same
FYI @Dandandan

Sure - if we get a similar performance or better I've no problems with that.
I am not sure I would call it a hack though - the Rust standard library uses the same technique.

Agreed, iterators can be made to perform the same, but it requires a significant amount of trickery and is subject to the whims of LLVM. For the purposes of arrow kernels, its just unnecessary imo.
https://medium.com/@veedrac/rust-is-slow-and-i-am-the-cure-32facc0fdcb may also be of interest, sadly it isnt't possible to implement try_for_each currently.

Could we run the arithmetic benchmarks possibly?

Yea, checked kernels with no null values show obvious regression.

Thanks for review!


Correct syntax

Wait, how did the comma get removed again when my PR #268 that was merged before this added both the bracket and the comma? I'm looking at the history and am very confused.

@ProfessorDey could it be the precommit hook?

Pretty sure this was just because of a merging order honestly. I think someone made a PR before you did and the order I merged them caused your changes to become undone


Go: revamp the Start/Run procedures

Currently we offer two means to run hyperkit: Start and Run. Both run the process in background (using exec.Cmd.Start), in order to be able to save the state when launching succeeded.
Both wait for the command to finish.  Run returns the exit status. Start waits in a goroutine and discard the result.
As a result, the user has no clean means to run in background and get the exit status.  The Start function discards the exit status.  But since Run is blocking, the caller must run it in a goroutine.  Therefore the callers needs to watch the process to know when it is actually running (e.g., by watching h.Pid).
Revamp this.

First, make changes easier by isolating the checking and the exec.Cmd creation parts into their own functions
Provide the HyperKit struct with a channel to publish the result of waiting for hyperkit
Move what remains of execute/execHyperKit into Start
Write Run on top of Start.

I have not included the exec.Cmd in the HyperKit struct, but that was an option.
Preparing the Cmd and leaving it to the user was also an option.  I stayed with the current approach.
Docker for Mac is made cleaner/faster thanks to these changes.
-   hypErr := make(chan error, 1)
-
-   go func() { hypErr <- h.Run("") }()
-
-   // Wait for the process to be created.
-   for i := 0; i < 10; i++ {
-           if h.Pid != 0 {
-                   break
-           }
-           select {
-           case err := <-hypErr:
-                   log.Fatalf("Hyperkit failed to start: %v", err)
-           default:
-                   log.Infof("Waiting for %#v to start", h)
-                   time.Sleep(500 * time.Millisecond)
-           }
-       }
-   if h.Pid == 0 {
-           log.Fatalf("hyperkit did not start")
-   }
-   return h.Pid, hypErr
+   if err := h.Start(""); err != nil {
+           log.Fatalf("Hyperkit failed to start: %v", err)
+       }
+   return h.Pid, h.ErrorCh

@rn @ijc @djs55 PTAL.

Testify is fine by me. FYI I'm about to go on PTO until next year so I won't be able to have a proper look at this PR until then, sorry. Not sure when the others are back but I'd bet on "next year" for them too.

@ijc Enjoy your vacations!


[SMALLFIX] Use static imports for standard test utilities

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/2836/
Test PASSed.

alluxio-bot, merge this please


Prefix-based log routing

I like to route my application logs to their own file to aid debugging.  All my logs are done using slf4j, so there's very little use of markers to be converted into tags.  Would it be possible to support some kind of prefix such that I could say that either:

Only com.myapp logs go into this file
com.myapp is tagged as "APP", and then use that to do the routing

Right now, we achieve this with logback, but tinylog's benchmarks and simple configuration are alluring.  Although I'm yet to test the benchmarks when used in conjunction with slf4j, I have no idea what kind of overheads would be present.

You can archive this with the current tinylog version by creating your custom logging provider. Just extend TinylogLoggingProvider and override both log() methods. There, you can modify the tag and map com.myapp to the tag "APP".


autodoc not displaying properly on eus 9.26

Several internal erros and miscompletions.

We need euslisp 9.27+, which provides proper help functions to be used internally.
Including https://github.com/euslisp/EusLisp/pull/359 and others.


Is it possible to create custom scalars like DateTime?

I've got some field that in typescript has Date type. I'd like to have it coveret in more advanced way than string (eg, having some parsing in both directions). Is it possible?

Hi @pie6k, you should take a look at graphql-iso-date, which is the one I have been using in my projects whenever date parsing is needed.


Add global module "use strict" statement

Related to #108

Github doesn't like me right now :laughing:


Animations of FBX models are imported incorrectly in Godot 3.3 and later

Godot version
3.3.4 stable
System information
Kde neon 5.22 user edition - Linux 5.11.0-34-generic
Issue description
The animations in the AnimationPlayer are totally broken, and the only way to make them work is to import them with godot3.2.3 and then copy them into a godot3.3.4 project.
maybe it is better to create another report (tell me if I have to do it), but I want to add that I have noticed that in godot 3.3.4 the "Fps" parameter in the import tab has no effect on the number of key frames.
Steps to reproduce

Download this: https://kaylousberg.itch.io/kaykit-animations
Import KayKit Animated Character_v1.1.fbx into a new godot 3.3.4 project (or any version higher than 3.2.3)
Try to play some animation

For the workaround:

Download this: https://kaylousberg.itch.io/kaykit-animations
import KayKit Animated Character_v1.1.fbx into a new godot 3.2.3 project with the "import with separate animations" preset
Move the animations (file.anim) into a godot 3.3.4 project and add them to the AnimationPlayer
Play the imported animations

edit: I changed the link to the correct one to download the 3d model
Minimal reproduction project
This is a godot 3.3.4 project and contains the model with the animations of godot 3.2.3 and godot 3.3.4: AnimationBug.zip
video:
video_anim.zip

This is probably fixed with the new FBX importer using FBX2glTF.
You can test it in Godot 4.0 alpha 6: https://godotengine.org/article/dev-snapshot-godot-4-0-alpha-6
This new importer might also be backported for the 3.x branch eventually.
If you still find issues with these models using the new importer, we suggest opening a new issue with details about the problems in Godot 4.0 alpha 6 or later.


gh-624 : Added index parameter to to_dict and added axis argument to Series.add_suffix(), DataFrame.add_suffix(), Series.add_prefix() and DataFrame.add_prefix()

[ ] Closes #624
[ ] Tests added: Please use assert_type() to assert the type of any return value

I added the parameters, but just a question do we have to add test in these compatibility changes also

I think, but I'm not sure, that the changes I suggested will fix your problems. You have to really understand how typing works to debug what is going on. Make the changes incrementally, and test locally.

Yes now I'll try harder in the  all upcoming issues


Dashboard groups cancel button needed in the assign global roles

v2.5-fa087c81628de057406608f077d0952bb03cea56-head
From the cluster explorer --> Users and auth --> groups --> Assign global roles --> cancel button is missing at the bottom.
It appears only if we enter a name in the select member.

https://github.com/rancher/dashboard/issues/2530

Verified on v2.5-b2a34d7cef440e3ed1de7d506233aa3a332649ae-head
Steps:
From rancher cluster explorer --> Users and auth providers -> Auth Providers --> Enable auth
Users and authentication --> Groups --> Assign Global roles --> Cancel button is present [click on cancel to go back to the groups page]


Proposal: Sync Template & TemplateInstance

Problem
Templates are a great tool to define resources that should be created on space creation. After the resources are created by the TemplateInstance, changes to the corresponding Template do not change any deployed resources created by the TemplateInstance anymore (which is initially good and should stay the default behavior).
However, I argue that there are cases where a user wants to sync a TemplateInstance with a Template: imagine an organization that has a common helm chart that takes care of isolation practices the organization wants to enforce for (certain) spaces (e.g. LimitRanges, NetworkPolicies etc.). With the current features of kiosk, the organization has to handle the synchronization of the common helm chart and actual deployed instances of this chart itself, which is not an easy task especially if tenants should be still able to create namespaces on demand.
Solution
We allow and take care of synchronization between TemplateInstances and Templates. I propose a new property in the TemplateInstanceSpec called sync that, when enabled, ensures changes to the Template are reflected by the corresponding TemplateInstance. This makes it easy to enable synchronization on a case to case basis and plays nicely with the proposed changes in #32.
Potential Implementation
Currently the TemplateInstance already records several metadata fields of the deployed resources, which can be used to uniquely identify them. On template change we can compute a delta between the before deployed resources and new resources and apply the changes. However, there are still several challenges on the implementation part:

What happens to changes that were made by the user / admin to deployed resources by the TemplateInstance? Should we use the three way merge helm uses?
Should we convert the to deploy resources on the fly into a helm chart and let helm do the delta / merging part on a parent Template update? (especially since helm3 does not require a tiller anymore and we have helm in the container image anyways) One potential problem I see, is that namespace users potentially could delete the created helm secret and make updating the chart harder.
If we fail once, should we retry or stay in a failed state? If we retry, can we ensure that the sync is an atomic operation and is reverted on failure? What if this cannot be ensured?

Done with #39


windows: race condition in getting environment variable

https://github.com/golang/sys/blob/master/windows/env_windows.go
This code exhibits a common bug.
Other threads can change the value, or unset it, while it is being retrieved.
You should loop until either
not found
or variable fits in buffer

Can you demonstrate the bug with a bit of code? I really don't see what the problem is. Thank you.
Alex

Consider another thread calling SetEnvironmentVariable concurrently with this code.

Jay

On Feb 2, 2015, at 10:43 PM, alexbrainman<EMAIL_ADDRESS>wrote:

Can you demonstrate the bug with a bit of code? I really don't see what the problem is. Thank you.
Alex
—
Reply to this email directly or view it on GitHub.

Same bug here:
https://github.com/golang/sys/blob/master/windows/exec_windows.go
Consider another thread calling SetCurrentDirectory.
Again the correct code requires a loop.

Jay

On Feb 3, 2015, at 12:07 AM, Jay<EMAIL_ADDRESS>wrote:

Consider another thread calling SetEnvironmentVariable concurrently with this code.

Jay

On Feb 2, 2015, at 10:43 PM, alexbrainman<EMAIL_ADDRESS>wrote:

Can you demonstrate the bug with a bit of code? I really don't see what the problem is. Thank you.
Alex
—
Reply to this email directly or view it on GitHub.

package main

import (
	"os"
	"runtime"
)

func main() {
	runtime.GOMAXPROCS(runtime.NumCPU())
	go func() {
		for {
			os.Setenv("FOO", "GO")
			os.Setenv("FOO", "GOLAAAAAAAAAAAAAAAAAAAAAANG")
		}
	}()

	for {
		e := os.Getenv("FOO")
		if e != "GO" && e != "GOLAAAAAAAAAAAAAAAAAAAAAANG" {
			panic("BUG!")
		}
	}
}

Ooops Sorry. It's my bug.

package main

import (
	"fmt"
	"os"
	"runtime"
	"strings"
	"time"
)

func main() {
	runtime.GOMAXPROCS(runtime.NumCPU())
	n := 1
	go func() {
		for {
			os.Setenv("FOO", "GOL"+strings.Repeat("O", n)+"NG")
			if n++; n > 5000 {
				n = 1
			}
		}
	}()

	time.Sleep(1e9)

	for {
		s := os.Getenv("FOO")
		if !strings.HasSuffix(s, "ONG") {
			panic(fmt.Sprintf("BUG(%d): %s", n, s))
		}
	}
}

http://play.golang.org/p/srvhu31O1r
I could make this crash on windows easily... :-1:
panic: BUG(228):

goroutine 1 [running]:
main.main()
        C:/dev/envrace.go:28 +0x274

goroutine 4 [runnable]:
syscall.UTF16FromString(0x118d9d10, 0xf0, 0x0, 0x0, 0x0, 0x0, 0x0)
        c:/go/src/syscall/syscall_windows.go:42 +0xf7
syscall.UTF16PtrFromString(0x118d9d10, 0xf0, 0xf0, 0x0, 0x0)
        c:/go/src/syscall/syscall_windows.go:66 +0x40
syscall.Setenv(0x4cebe0, 0x3, 0x118d9d10, 0xf0, 0x0, 0x0)
        c:/go/src/syscall/env_windows.go:35 +0x40
os.Setenv(0x4cebe0, 0x3, 0x118d9d10, 0xf0, 0x0, 0x0)
        c:/go/src/os/env.go:87 +0x50
main.funcﾂｷ001()
        C:/dev/envrace.go:16 +0x96
created by main.main
        C:/dev/envrace.go:21 +0x90
exit status 2

GetEnvironmentVariable is not thread-safe!?

I see. I agree we should fix this. Thank you.
Alex

GetEnvironmentVariable is not thread-safe!?

It is thread-safe. But there is no public lock to be had around multiple calls to it. This a common aspect of various "Get" functions. GetFullPathame, GetModuleFileName, etc.

Jay

On Feb 3, 2015, at 12:33 AM, mattn<EMAIL_ADDRESS>wrote:

GetEnvironmentVariable is not thread-safe!?

I looked in main repo. These are to be fixed:
net/getAdapterList
path/filepath/toShort
path/filepath/toSLong
syscall/FullPath
syscall/Getenv
syscall/security_windows.go everything that returns ERROR_INSUFFICIENT_BUFFER error
syscall/TempDir
(@jaykrell can you see others?)
None of them look likely to happens in real program (IMO), but we might as well fix them. Once fixed we should copy syscall changes into golang.org/x/sys/windows.
@jaykrell interested to make changes? If not I will do it myself.
Alex

Here https://go-review.googlesource.com/4940 is the fix.
Alex


Textmate 2 Bundle conflict with PHP

The PHP-twig bundle is making the PHP bundle not style the *.php files.
PHP Bundle https://github.com/textmate/php.tmbundle

This bundle doesn't interact with PHP files in any way. PHP is only in the name as Twig is a PHP library. My best guess would be a configuration issue or a modification to your local copy of the bundle.


regressor load with torch

Thanks for your great work
I trained a regressor myself which is similar to https://github.com/miccunifi/ARNIQA/issues/3.  I save the regerssor model with torch.save and try to load it by torch.load. But when i eval it shows TypeError: 'Ridge' object is not callable.  Do you have any suggestions for solving it?

Hi @superxi!
Thanks for your interest in our work.
I need some additional details to guide you in the best way. Could you paste here the code that you are using to load the model and the regressor?

I would like to ask how the model changes from pkl https://github.com/miccunifi/ARNIQA/blob/baee457a1f75a8475a767efc943268b116ef19be/test.py#L159 to torch version https://github.com/miccunifi/ARNIQA/blob/baee457a1f75a8475a767efc943268b116ef19be/hubconf.py#L56
1、I trained the regressor, and saved the model with fellow code
with open(regressor_path / filename, "wb") as f:             pickle.dump(regressor, f)
2、I try convert It to a torch version, so that i can use it like the https://github.com/miccunifi/ARNIQA/blob/main/hubconf.py . So I resave the model with
'
tmp = pickle.load(open('experiments/test/regressors/kvq_srocc_0.9269_plcc_0.9303.pkl','rb'))
torch.save(tmp,'regressor.pth')
'
3、I load the model with fellow code, it can be load normally, but when I eval the image it will hit TypeError: 'Ridge' object is not callable
self.encoder = ResNet(embedding_dim=128, pretrained=True, use_norm=True) self.encoder.load_state_dict(torch.load(encoder_path, map_location="cpu")) self.encoder.eval() self.regressor: nn.Module = torch.load(regressor_path, map_location="cpu")
4、I chang the way load and inf model like below, it can eval normally.  I eval the whole test dataset, but the plcc is very different with the one in the test (0.93/0.69). I'm not sure if it's because of the partitioning of the dataset or if I have some issues using it
`
def init(self, encoder_path, regressor_path):
super(ARNIQA, self).init()
self.encoder = ResNet(embedding_dim=128, pretrained=True, use_norm=True)
self.encoder.load_state_dict(torch.load(encoder_path, map_location="cpu"))
self.encoder.eval()
# self.regressor: nn.Module = torch.load(regressor_path, map_location="cpu")
self.regressor = pickle.load(open(regressor_path,'rb'))
# self.regressor.eval()
def forward(self, img, img_ds, return_embedding: bool = False, scale_score: bool = True):
    f, _ = self.encoder(img)
    f_ds, _ = self.encoder(img_ds)
    f_combined = torch.hstack((f, f_ds))
    # score = self.regressor(f_combined)
    score = self.regressor.predict(f_combined.cpu())
    if scale_score:
        score = self._scale_score(score)
    if return_embedding:
        return score, f_combined
    else:
        return score

`

Thanks for the additional details, now I understand your issue.
The regressor is transformed from a scikit-learn model to a torch model via the sk2torch library in this way:
scikit_regressor = pickle.load(open("<pickle-path>", "rb"))
torch_regressor = sk2torch.wrap(sk_reg).float()
torch.jit.script(torch_regressor).save("<torch-path>")

The torch version of the regressor can then be loaded doing:
torch_loaded_regressor = torch.jit.load("<torch-path>")

In this way, you should be able to use the model as intended.
However, the strategy that you reported in point 4. should work AFAIK. I would suggest you to try to use the torch version of the regressor and then let me know in this issue if you still have problems, so I can help you further. In the meantime, could you tell me if you notice a similar performance drop also for the SRCC metric? Because if the difference is only in the PLCC metric then the issue is probably in a different part of the code.

Yes, it also drop with SRCC, but I find the reason。
The code for my eval full test set is based on the Minimal Working Example provided in the readme, which input is the entire image. And the input in test.py is the center and corners crops. I can get approximate results after changing the preprocessing of the input image.
Thanks for your help !

That's very good to hear! Thanks again for your interest in our work!


Refactor registration to artifact operation

Summary
Addresses https://github.com/dotnet/dotnet-monitor/issues/3916.

Release Notes Entry
Fixes issue where trace operations with an egress provider and rundown on Linux would cause dotnet-monitor to lose connectivity with the target application.

FYI, this has each of the operations register themselves with the tracker regardless of listen vs connect mode, but I think that should be fine.

That's a good point, but I'm actually going to leave this for now. If we bridge more of the capabilities between connect and reverse modes, this may end up being useful.


Tab parameter in url should be responsive to tab changes

From @tmheunis:

E.g. If I click on 'funding' and copy the url it does not include the tab parameter in the url. The same applies for the 'content' tab. If I do include the 'funding' tab parameter in the url it correctly opens that tab, but if I then click on 'content', for instance, the url still displays 'funding'. The url should end with 'content' if I am on the 'content' tab, and end on 'funding' if I am on the 'funding' tab.

Consider moving to using queries for tabs, rather than the current route parameter. This would mean a URL in the format:
https://mycatalog.com/#/dataset/<dataset_id>/<dataset_version>/?tab=content
rather than
https://mycatalog.com/#/dataset/<dataset_id>/<dataset_version>/content

Some notes after a couple of hours' worth of testing, reading, breaking stuff:

I started started mapping out the landscape of vuejs and vue-router navigation for the catalog here: https://github.com/datalad/datalad-catalog/issues/393
Current thought is to try and update the URL when a new tab is selected, without reloading the component, i.e. without router triggering a navigation. This means, if I'm reading the docs correctly, not using router.push or router.replace. An alternative could be to use the History interface as a means to bypass Vue-router navigation. However, trying out history.replaceState and history.pushState in javascript (based on https://stackoverflow.com/a/56691294) hasn't delivered useful results.
Could also investigate running some functions in beforeRouteLeave?

Perhaps this issue could be resolved as part of the general move to query params and the upcoming router change in https://github.com/datalad/datalad-catalog/pull/430


How to save the zoom+ setting, when Dynamic Update

When i zoom+ or drag, candlestick will reactive, but dynamic data update will set to show all data, no zoom
http://xiongqs.com/d3/trade.html
so how can i save the zoom settings

figure out, thx!

Hi easygavin. Goo job!
Have you more examples?
Thanks

What was the solution? I'm having the same issue


Neon Button Animation Effects

Add my Neon light Button Animation Effects  in main repo.

@akpaswan67 You forgot the Main.jsx part.
Kindly check the README.md and push the code

I have updated Main.jsx file. Kindly review it.

@akpaswan67  Thank you for your contribution 🌟
Star the repo if you like it. 🤩


Misleading text in Pod Security Admission metrics

This is a Bug Report

Problem:
The term “evaluation“ in the metrics section of the Pod Security Admission page is slightly misleading.
Proposed Solution:
Change “evaluation“ to “enforcement” in the text:

Non-fatal errors may result in the latest restricted profile being used for enforcement.

Page to Update:
https://k8s.io/docs/concepts/security/pod-security-admission/

Additional Information:
Mentioned as https://github.com/kubernetes/website/pull/41814#discussion_r1293784723
/good-first-issue
/language en
(extra credit: also tell readers that they can find more detail in https://kubernetes.io/docs/reference/instrumentation/metrics/)

/assign

/assign

/triage accepted

Fixed with #42856
/close


feat: Add DNS patch

Depends on #129.

@dkoshkin do we really need to be able to override DNS image repo here? Is it not enough to just be able to override the registry images come from at kubeadmconfig top level that applies to all images?

@dkoshkin do we really need to be able to override DNS image repo here? Is it not enough to just be able to override the registry images come from at kubeadmconfig top level that applies to all images?

I had the same thought for this repo, DKP has a very specific usecase because of how FIPS support works, but for a more generic solution I think having a variable for the registry is much more valuable.

For the fips case do we really need to override the DNS registry via "/spec/template/spec/kubeadmConfigSpec/clusterConfiguration/dns/imageRepository" or is it enough to be able just to override "/spec/template/spec/kubeadmConfigSpec/clusterConfiguration/imageRepository" (https://github.com/kubernetes-sigs/cluster-api/blob/82eff49867008365d3b26f82b55ff29a67880aa7/bootstrap/kubeadm/api/v1beta1/kubeadm_types.go#L139)? Why do we need to override the individual component image repositories (which really should be image registry iiuc...)?

We could also just solve that with inline patches on fips cluster classes perhaps in addition to generic external patches 🤔

Ah I see the note that coredns should always be pulled from default k8s registry

Closing - as discussed above this does not appear to be a common enough use case to provide a patch for. This can be handled via inline patches, or a different patch webhook deployment.


Fix trait bound on arr1 (op) &arr2

The implementation of arr1 (op) &arr2 mutates arr1 for efficiency, but this caused surprising behavior if arr1 was ArrayViewMut. This commit requires that arr own its data to avoid surprising side effects.
This is an example of the old behavior that was surprising:
extern crate ndarray;

fn main() {
    let mut a = array![1., 2.];
    let b = array![3., 4.];

    // Prints a = [1, 2].
    println!("a = {}", a);

    {
        let a_view_mut = a.view_mut();
        // Prints a + b = [4, 6].
        println!("a + b = {}", a_view_mut + &b);
    }

    // Prints a = [4, 6]; would expect a = [1, 2].
    println!("a = {}", a);
}

Note that while this is a breaking change, the stricter trait bound is actually the correct bound according to the documentation.

Right, we have probably fixed this already for the other ops.

Thanks

Previous pr #93
Unrelated pr, but something we talked about today was  #103


Fix sns.subscribe validation for sms numbers

Fixes #2529

Coverage decreased (-0.08%) to 93.574% when pulling 58daa428f302c3dfff6e33c7ae6cd3d50ee1b7f5 on edekadigital:fix-sns-subscribe-sms-validation into e00af2f73cb7d27c3755f18b2161b9acbd8ca8aa on spulec:master.

Thank you!


Add systemd user service for ntfy-client.service

We can offer ntfy-client.service as a user service along the already existing system service.
This allows the use of ~/.config/ntfy/client.yaml for configuration (for the system service, the config is hardcoded to use
/etc/ntfy/client.yaml). It also means that we can update the docs to recommend enabling the user service for "personal desktop machine" use in https://docs.ntfy.sh/subscribe/cli/?h=systemd#using-the-systemd-service and remove the part about using an override.conf (unless this has another use case for the ntfy-client that I am missing?).
Repos would need to update their packages to copy over client/user/ntfy-client.service to /usr/lib/systemd/user/ntfy-client.service.
I've been using it successfully so far. I've also added entries to scripts/postinst.sh and .goreleaser.yml, but haven't tested those.

Will this be possible to add to the docker image as well, so that it starts both server and client?

@Migs3 Not via this user service - the docker image doesn't (and shouldn't) use systemd. My use case was more for desktop machines that want to use only the client so that notifications can pop up with notify-send (without configuring anything in /etc like the override.conf or client.yml). If you want this functionality with a docker container, I think you would have to do what the override.conf did, i.e. include something like
    environment:
      - DISPLAY=:0
      - DBUS_SESSION_BUS_ADDRESS=unix:path=/run/user/1000/bus
    volumes:
      - /run/user/1000/bus:/run/user/1000/bus
    command:
    #  - serve
    - subscribe


Spring homework - 10 Security

Metric
Value

alert_status
:white_check_mark: OK

bugs
0

code_smells
8

reliability_rating
A (0 Bugs)Note: A being best, E being worst

security_rating
E (at least 1 Blocker Vulnerability)Note: A being best, E being worst

vulnerabilities
2


Step Template Library listing on Step Template page

How about having the step template library show up on the step template page.
Then you could just click import on one you like and it imports it for you in one step.

Turns out someone else had this idea as well.
https://octopusdeploy.uservoice.com/forums/170787-general/suggestions/6994715-tighter-integration-between-step-templates-and-com

Quick and rough copy paste of the template library onto the step template screen for an initial idea:

What it looks like at the moment. I plan getting the list sorted and adding a search input as well.


[Bug]: When opening the bot webpage on an Android mobile device, performing screen interactions such as clicking and swiping causes script error.

Telegram Application
Telegram for Android
Describe the Bug
When opening the bot webpage on an Android mobile device, performing screen interactions such as clicking and swiping causes script error.
To Reproduce
In my React project, when the bot connects to my webpage and screen interactions occur, a script error overlay appears. This issue only occurs on Android mobile devices.
Expected Behavior
I would like to seek some help (I have already used es-module-shims for compatibility)

Any information on what error occurs exactly?

like this    screen interactions such as clicking and swiping

I am not sure, this is related to tma.js. Check the code if it has some unhandled errors


feat: flow id should automatically be configured

For wolf deployment, it should the flow id can be fetched from the environment variables and for local it should be local host

solved


Moving iap (2) resources to v1beta1 version

Moving iap 2 resources in the  group:

[ ]  google_iap_brand
[ ]  google_iap_client

Blocked due to need support Email account.
Error message:
apply failed: Error creating Brand: googleapi: Error 400: Support email is not allowed:


An error appears in the script selector

There's nothing wrong with the sampler behavior, but it's annoying.

Seems like this can be fixed by adding:
            def show(self, is_img2img):
                return False

to the SMEA class in scripts/smea.py.


Prepare object_store 0.10.0

Which issue does this PR close?

Closes #5647
Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

DF PR - https://github.com/apache/arrow-datafusion/pull/10116
I've also confirmed that the parquet crate compiles against this version of object_store without issue


How can we stop a hacker from reverse engineering a react-native app ?

[x] Review the documentation: https://facebook.github.io/react-native
[x] Search for existing issues: https://github.com/facebook/react-native/issues
[x] Use the latest React Native release: https://github.com/facebook/react-native/releases

Environment
React Native Environment Info:
System:
OS: macOS High Sierra 10.13.6
CPU: x64 Intel(R) Core(TM) i5-3210M CPU @ 2.50GHz
Memory: 844.41 MB / 12.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 10.8.0 - /usr/local/bin/node
npm: 6.2.0 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 11.4, macOS 10.13, tvOS 11.4, watchOS 4.3
Android SDK:
Build Tools: 23.0.1, 23.0.3, 25.0.2, 26.0.0, 26.0.1, 26.0.2, 26.0.3, 27.0.0, 27.0.2, 27.0.3, 28.0.0
API Levels: 23, 25, 26, 27
IDEs:
Android Studio: 3.0 AI-171.4443003
Xcode: 9.4.1/9F2000 - /usr/bin/xcodebuild
npmPackages:
react: 16.6.1 => 16.6.1
react-native: 0.57.7 => 0.57.7
npmGlobalPackages:
react-native-cli: 2.0.1
react-native-fetch-blob: 0.10.8
react-native-mail: 3.0.6
Description
Hi All,
Can you suggest the best practices to store sensitive information in a react-native app?
Currently I have my api_keys and other sensitive information in a config.js file which could be easily read using reverse engineering techniques.
Reproducible Demo
This issue is related to any react native project build as all the code is minified in a mainbundle.js file which can be easily opened in any text editor.

Yes the issue exists in latest version as well

#1093

This issue repository is for tracking bugs in the React Native SDK. Can you post your question to one of the other community forums instead?


Docs hig merge

Merges the HIG into a single massive (but now searchable) document. A good review of this branch would make sure:

[ ] All the links work correctly
[ ] We're not missing sections
[ ] Things are in a sane order
[ ] Heading levels make sense

[ ] Duplicate IDs (i.e. #usage)

The link at "Portions of this page are derived from work created and shared by the Android Open Source Project and used according to..." is broken. Do we want to use http://developer.android.com/license.html as the current license page for Android documentation.


refactor: location module migrate

location module migration from class to functions within location namespace

#675

i think the example is not tested in our testcase, if i am not wrong?


DOC-5751 add regions column for show backup

Addresses DOC-5751:

Adds the 'regions' column to SHOW BACKUP which outputs a string of ALTER DATABASE commands if
the database is a multi-region database and NULL if not

Preview:

SHOW BACKUP

Merging in a separate branch created https://github.com/cockroachdb/docs/pull/17243 as this was done before the main branch cut


HookedSAETransformer

Description
Implements HookedSAETransformer - an extension of HookedTransformer that enables attachment of SAEs to activations. I implemented this for MATS research, and found it useful, so I'm excited to open source it. Feedback is welcome!
Here's a demo notebook: https://colab.research.google.com/github/ckkissane/TransformerLens/blob/hooked-sae-transformer/demos/HookedSAETransformerDemo.ipynb
Type of change
Please delete options that are not relevant.

[ x] New feature (non-breaking change which adds functionality)
[ x] This change requires a documentation update

Checklist:

[ x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[ x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ x] I have not rewritten tests relating to key interfaces which would affect backward compatibility

Making it so model.run_with_saes resets the SAE states to the same state as before the function was called would be a big improvement

@nix-apollo I suggested this here https://github.com/neelnanda-io/TransformerLens/pull/536#discussion_r1569800199 but deferred to Connor and Joseph who have used the library.
Persistent state seems OK to me? TransformerLens already has add_hook and reset_hooks which are really similar to attach_sae and turn_off_all_saes

To me HookedSAETransformer.attach_sae seems more analogous to add_hook. I like having this version of statefulness! Having an object that represents "GPT2 with this set of SAEs attached" seems useful to me. But being able to represent "GPT2 with these 12 SAEs attached, except only 4 of them are turned on" doesn't seem useful.
But I generally dislike persistent state, and avoid it when possible. This includes avoiding using add_hook and reset_hook whenever possible in normal TL. Maybe my opinion is too extreme here -- again, do feel free to ignore it!
The flag is probably a fine middle ground. Just imo adds a bunch of complexity for features that are more dangerous than useful.

Thanks for the feedback Nix! I think that there's cases where I want a stateful workflow, eg I have a single residual stream SAE that I want to attach to the model, and then just do normal mech interp to. Or I have a fixed suite of SAEs, and want to include all of them (plus error terms) and do circuit analysis. I also think there's cases where I want an ephemeral stateless workflow, eg if I'm analysing feature splitting and have 8 different SAEs on the same layer's residual stream of different widths, and want to easily swap them out for each other. So it seems clearly good to support both. IMO the best solution to avoid footguns is to have run_with_saes return the SAEs to their original state after it runs, and to support both attach_saes/turn_all_saes_off and run_with_saes/run_with_saes_and_cache/run_with_saes_and_hooks

@neelnanda-io I moved discussion to the Open Source slack about this issue as the interface is better.
TLDR support both permanently attached SAEs with add_sae and transiently attached SAEs with run_with_SAEs matching transformer lens symtax, do not use on/off at all


docs: update readme install instructions

Hey @sherwinski. I was running through a test of ng-imgix in an example app and I thought I'd help out and submit a PR to make the installation instructions a bit easier to use. Also, I added a step to disable Angular Ivy since it seems that app currently isn't compatible with that rendering engine. Please note that my familiarity with Angular is about 1.2/10 so let me know if there's something I should be doing here to have it run with Angular Ivy!
Feel free to merge this if you're happy with it, or edit as you see fit 😄

@allcontributors-bot add @sherwinski for maintenance and code

@allcontributors add @sherwinski for maintenance and code

@all-contributors add @sherwinski for maintenance and code

@all-contributors add @sherwinski for maintenance and code


NO. instead i started using a behavior tree solution


Feature request: Allow multiple files open on single executable

The title says it all. If I edit file A and want to save a piece from it to file B, I cannot open a blank file to do that. I need to first save, maybe copy the part to other editor and then resume to file A.

Hi!
This was requested long ago and is already planned for development. Meanwhile, you can try using Calcpad in an external editor. Here are the plugins:
https://github.com/Proektsoftbg/Calcpad/tree/main/Setup/Syntax-for-external-editors
They all has more powerful editting capabilities than Calcpad. We will iclude them as well, but it will take time.


Source code analysis should label version

Now we have some articles about analysis of source code of dubbo. Because the code is changing and updating, the articles may be out of date. So we should give the version of the source code that is analyzed. And reader can hack the code by themself with the articles.

Thanks for the feedback, these articles were modified from my personal blog, and I mentioned Dubbo's version (2.6.4) in some articles. Of course, it is more appropriate to emphasize the source version at the beginning of the first article. I will make some modifications to the article.

@code4wt Thank you! Good job


WebSQL is not supported from WebWorkers

https://groups.google.com/a/chromium.org/forum/m/#!topic/Blink-dev/SYlD0YVUnQk

Thanks!


More complete MessageSignature.is_signed_by_address

I noticed that the current version only seems to support p2pkh and all other address types default to false with no error thrown.
I effectively just ported this piece from bitcoinjs-message: https://github.com/bitcoinjs/bitcoinjs-message/blob/c43430f4c03c292c719e7801e425d887cbdf7464/index.js#L181-L233
I'm fairly new to rust, but I'm open to all suggestions to learn and to get this merged.
Testing
I included unit tests for

p2pkh
p2wpkh
p2shwph

I also amended the test_message_signature test which was asserting false on values that should clearly be true, but were just returning false due to lack of support.

Address all feedback as of this comment. I closed threads on anything with direct actionable feedback. Hopefully that's not a faux pas.

./contrib/test.sh now passes locally after f613214476

I can't seem to reproduce this CI result locally: https://github.com/rust-bitcoin/rust-bitcoin/runs/4081690675?check_suite_focus=true
Can anyone offer assistance so I fixing this doesn't require such long cycle times? I assume the 1.29.0 is the rust version. I tried rustup default 1.29.0 and then rerunning but then I get
error: failed to parse lock file at: /home/shatnerz/dev/rust/rust-bitcoin/Cargo.lock

Caused by:
  invalid serialized PackageId for key `package.dependencies`

If there is ever indication that this might get reviewed, I can also start looking into a follow up MR to support taproot addresses when using is_signed_by_address

Sorry for leaving this PR for some time w/o review; all maintainers are currently focused on completing Taproot support as highest priority. I will be able to review this PR as soon as Taproot release is out and I can read the specs on how the message signing should be done. But for sure I'd like to have this functionality into the library - especially with Taproot follow-up

@dr-orlovsky sounds good and no worries.I forgot that the taproot launch was so soon (lol days ago now). Hopefully I can get some time to look into taproot signature verification

Sorry for being late, but AFAIK there is no standard for message signatures using wpkh or p2shwpkh addresses. The closest thing is BIP322, which is not implemented anywhere.

@apoelstra

Sorry for being late, but AFAIK there is no standard for message signatures using wpkh or p2shwpkh addresses. The closest thing is BIP322, which is not implemented anywhere.

I don't quite understand this comment. Does that actively change anything about verifying a signature using an address?
Are you referring to a specific piece of code. Sorry some time has passed so I may need a refresher.

I don't quite understand this comment. Does that actively change anything about verifying a signature using an address?

No, nothing has changed about verifying a siganture using an address since it was implemented in Bitcoin Core in 2011.

concept NACK this PR. There is no signmessage standard for non-pkh address types.

Agree with @apoelstra on concept NACK but would accept a PR (or two PRs) that returns Result<bool, UnsupportedAddress> and a method to check if a PublicKey is associated with an address. The former could reduce foot-gunnyness of it and the latter would enable people to conveniently build a new signing standard separately and iterate on it for a while.

When I get funds, some non-profits are asking me to sign my address - and I am hesitant to move on old P2PKH just because there is not standard to sign with an address for P2WPKH or P2TR. If there is no standard for that, let's make it. @Shatnerz you are welcome to do this contribution to a descriptor-wallet library (https://github.com/LNP-BP/descriptor-wallet) extending rust-bitcoin wallets - and also propose a new standard to LNPBPs set (https://github.com/LNP-BP/LNPBPs)

Yes, let's make it! I think this is BIP-worthy.

Have you looked at BIP-322? https://github.com/bitcoin/bitcoin/pull/24058

@apoelstra

concept NACK this PR. There is no signmessage standard for non-pkh address types.

There is, as mentioned above. (You yourself revised it recently.)

I would ACK a correctly written implementation of BIP-322 or, preferably, required additional methods to make it implementable in a separate crate. We need to stop the scope creep.

Also found this: https://github.com/rust-bitcoin/rust-miniscript/pull/240

Sorry guys. The timing is unfortunate because I'm incredibly busy this month. I'll try to review the above comments more closely when I get a chance.
It looks like a negative response to this PR. I'm probably missing something at a glance. Comments seem to talk about signing when this PR only affects verification.
Do you have any suggestions on fixing is_signed_by_address for P2SH, P2WPKH, and P2WSH as currently they are a tad misleading as they always return false (https://github.com/rust-bitcoin/rust-bitcoin/blob/master/src/util/misc.rs#L166-L174) in a manner that will be accepted? Aside: I don't think this will work for P2TR unless a pubkey is provided as well. I have some ideas for P2TR but would like to see other addresses handled properly first.

I'm just closing due to inactivity.
Feel free to reach out if you ever need a hand expanding MessageSignature support.

Thanks for showing an interest in this @Shatnerz, I look forward to your future PRs!


Best Practice For Using Image in Bit

Hi There
I Was Trying To Use Byte Array To Save My Picture But The Code  Generator Had Some Issue We That.
What Should I Do?

Consider this model:
public class Product : IEntityWithDefaultGuidKey
{
    [Key]
    public virtual Guid Id { get; set; }
    public virtual string Name { get; set; }
    public virtual byte[] Image { get; set; }
}

Having this model caused you not have any problems, but if you want to use byte[] in DTO, we haven't supported it yet.
All in all, there are some solutions:
First solution: For small size pictures, use base64 format, so you can declare Image property as string in both model and DTO.
http://www.url-encode-decode.com/base64-encode-decode/
Second solution: Remove byte[] Image property from your DTO but not from model, and write a basic ApiController to get a product's image with its Id. The same solution could be used to edit images too.
public class ProductImagesController : ApiController
    {
        public IEntityWithDefaultGuidKeyRepository<Product> ProductsRepository { get; set; }

        [HttpGet]
        [Route("products/{productId}.png")]
        public virtual async Task<HttpResponseMessage> GetProductImageById(Guid productId, CancellationToken cancellationToken)
        {
            byte[] productImageData = await ProductsRepository.GetAll()
                .Where(p => p.Id == productId)
                .Select(p => p.Image)
                .FirstOrDefaultAsync(cancellationToken);

            if (productImageData == null)
                throw new ResourceNotFoundaException();

            MemoryStream productImageMemoryStream = new MemoryStream(productImageData);
            HttpResponseMessage response = new HttpResponseMessage(HttpStatusCode.OK);
            response.Content = new StreamContent(productImageMemoryStream);
            response.Content.Headers.ContentType = new MediaTypeHeaderValue("image/png");
            return response;
        }
    }

You can use following uri to get your image, for example as a src of a image elements etc.
http://your-site.com/api/products/27C3BB81-E9B1-43D7-854E-6CDCB427A680.png
To upload a file, you can use following code:
        [HttpPost]
        [Route("products/{productId}.png")]
        public async Task<IHttpActionResult> SetProductImage(Guid productId, CancellationToken cancellationToken)
        {
            if (!Request.Content.IsMimeMultipartContent())
            {
                throw new BadRequestException();
            }

            Product product = await ProductsRepository.GetByIdAsync(productId, cancellationToken);

            if (product == null)
                throw new ResourceNotFoundaException();

            MultipartMemoryStreamProvider streamProvider = new MultipartMemoryStreamProvider();

            await Request.Content.ReadAsMultipartAsync(streamProvider, cancellationToken);

            byte[] productImageData = await streamProvider.Contents.Single()/*Single: Let's say that we've one image for each product*/.ReadAsByteArrayAsync();

            product.Image = productImageData;

            await ProductsRepository.UpdateAsync(product, cancellationToken);

            return Ok();
        }

Then you can upload files using any standard file uploader:
This is a sample C# code:
            using (WebClient client = new WebClient())
            {
                client.UploadFile(@"http://your-site.com/api/products/27C3BB81-E9B1-43D7-854E-6CDCB427A680.png", HttpMethod.Post.Method, @"C:\myImage.png");
            }


Quick mobile toc for act-and-prepare

This is a lazy quick fix for https://github.com/flattenthecurve/guide/issues/190
It's not awesome, but it's literally better than nothing...

It's very difficult to understand that it is a TOC as it is right now. Can we try being more explicit? Maybe add a "Table of Contents" title at least?

This was supposed to be a quick stop-gap solution... I thought anything was better than nothing. Rather than iterate on this placeholder, I will try to PR a “real” solution tonight.

On Apr 2, 2020, at 2:40 AM, Martin Verzilli<EMAIL_ADDRESS>wrote:

It's very difficult to understand that it is a TOC as it is right now. Can we try being more explicit? Maybe add a "Table of Contents" title at least?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


DBZ-5087 Added a decorator for result sets that can cancel the parent statements

Overview
The changes and rationale are detailed in the DBZ ticket but the gist is that some JDBC drivers (for example, SQL Server for JDBC > 2.0) cannot close() a ResultSet without first looping through all the remaining rows. This means that when we try to interrupt a snapshot process it might hang indefinitely for all intents and purposes.
The fix is to cancel() the parent Statement which usually involves a round trip to the server, which means that no further results will be returned within the result set.
I tested that it definitely solves our problem with the event change coordinator thread taking too long to stop and doing it not-so-gracefully when it does.
https://issues.redhat.com/browse/DBZ-5087
Open to feedback, thank you!

Hey all, is there anything that needs to be done to run the remaining builds and to target 1.9 in addition to main? Thank you!

@alwaysbemark Thanks a lot! Do you think that other Debezium code would benefit form this as well?
If yes then I can imagine io.debezium.jdbc.JdbcConnection.connection(boolean) to return decorated connection that would return decorated resultset.

@alwaysbemark Thanks a lot! Do you think that other Debezium code would benefit form this as well? If yes then I can imagine io.debezium.jdbc.JdbcConnection.connection(boolean) to return decorated connection that would return decorated resultset.

Hey @jpechane , thanks for having a look! I went through the main flow again and could not identify any other potentially massive queries (like the initial table snapshot) so considering the fact that this adds another potential round trip to the server (and even more, depending on the implementations of JDBC driver) I can't recommend adding it anywhere else for now, but I tried to keep it generic so that it can be!
Is this something that could target 1.9 as well by any chance? Thanks again!

@alwaysbemark Applied, thanks.  As this is pretty isolated change I am going to add it to 1.9 too.


Update extensions.md - adding react-storybook-addon-add-stories-group

the package is available on npm

Awesome.


Implement rex_selectedSegmentIndex for UISegmentedControl

Title says it all

Hm, the first CI fails were because I've added UISegmentedControl to all targets instead of only to the iOS target. I've already fixed that.
But now, it seems to still fail for the tvOS target:

-> Rex (0.10.0)
- ERROR | [tvOS] xcodebuild: Returned an unsuccessful exit code. You can use --verbose for more information.
- ERROR | [tvOS] xcodebuild:  /Users/travis/build/neilpa/Rex/Source/UIKit/UISegmentedControl.swift:16:21: error: use of unresolved identifier 'rex_controlEvents'>

even though the UISegmentedControl.swift is not added to the tvOS target anymore 😕

Oh nevermind, i guess UISegmentedControl.swift needs to be explicitly excluded for the tvOS target in the Podspec.

Oh nevermind, i guess UISegmentedControl.swift needs to be explicitly excluded for the tvOS target in the Podspec.

I've hit this problem a couple times too. One of the reasons I'm not a fan of pods since you have multiple project definitions.

@iv-mexx I invited you as a collaborator to the repo. Feel free to review and merge PRs since I'm not as on top of them these days.

@neilpa Cool, thanks 😃 🎉


Sentry Error

*
Bot starts up and logins in fine. Thirty seconds later, error pops up and logs out the bot.
Windows 7 64bit

Never mind, I didn't research enough. Found previous post regarding this issue.