Behat error.

Environment:
Postgresql: v9.6

oro/redis-config | 2.0.0-beta.1 | MIT
-- | -- | --
oro/doctrine-extensions | 1.1.2 | MIT
oro/platform | 2.3.16 | MIT
oro/platform-enterprise | 2.3.9 | Commercial
oro/marketing | 2.3.7 | OSL-3.0
oro/calendar-bundle | 2.3.3 | OSL-3.0
oro/platform-serialised-fields | 2.3.1 | OSL-3.0
oro/customer-portal | 2.3.7 | OSL-3.0
oro/commerce | 1.3.16 | OSL-3.0
oro/commerce-enterprise | 1.3.9 | Commercial
oro/crm-call-bundle | 2.3.2 | OSL-3.0
oro/crm-task-bundle | 2.3.2 | OSL-3.0
oro/crm | 2.3.12 | OSL-3.0
oro/crm-enterprise | 2.3.3 | Commercial
oro/commerce-crm | 1.3.2 | OSL-3.0
oro/crm-hangouts-call-bundle | 2.3.1 | OSL-3.0
oro/crm-mail-chimp | 2.3.4 | OSL-3.0
oro/crm-abandoned-cart | 2.3.1 | OSL-3.0
oro/crm-magento-embedded-contact-us | 2.3.1 | OSL-3.0
oro/crm-dotmailer | 2.3.3 | OSL-3.0
oro/crm-zendesk | 2.3.4 | OSL-3.0
oro/crm-pro-ldap-bundle | 2.3.1 | OSL-3.0
oro/commerce-crm-ee | 1.3.1 | Commercial

Error after test success:
Process message queue
Stop message queue
time: 1024 ms
Restore database from dump

  [Symfony\Component\Process\Exception\ProcessFailedException]
  The command "PGPASSWORD="dbpassword" psql -h localhost --port= -U dbname -t -c "SELECT pg_terminate_backe
  nd(pid) FROM pg_stat_activity WHERE datname in ('dbname', 'dbnamedb5a3391c5bf8ed235967443') AND pid <
  > pg_backend_pid()"" failed.
  Exit Code: 2(Misuse of shell builtins)
  Working directory: /home/user/oro/
  Output:
  ================
  Error Output:
  ================
  psql: FATAL:  database "dbname" does not exist

I think because we drop database before killing connections:
https://github.com/oroinc/platform/blob/master/src/Oro/Bundle/TestFrameworkBundle/Behat/Isolation/UnixPgsqlIsolator.php#L90
https://github.com/oroinc/platform/blob/master/src/Oro/Bundle/TestFrameworkBundle/Behat/Isolation/UnixPgsqlIsolator.php#L91
https://github.com/oroinc/platform/blob/master/src/Oro/Bundle/TestFrameworkBundle/Behat/Isolation/UnixPgsqlIsolator.php#L197
https://github.com/oroinc/platform/blob/master/src/Oro/Bundle/TestFrameworkBundle/Behat/Isolation/UnixPgsqlIsolator.php#L234

something wrong with port --port= . Could you please provide your parameters.yml

parameters.yml
parameters:
    database_driver: pdo_pgsql
    database_host: localhost
    database_port: null

I don't think so, because the test is successful, it ran as I expected. If I comment out this line, it works:
$this->killConnections();
https://github.com/oroinc/platform/blob/master/src/Oro/Bundle/TestFrameworkBundle/Behat/Isolation/UnixPgsqlIsolator.php#L197

@xgitxhubx the issues with database name, it can't find database.

@spolischook But the test is successful. It can backup database, create test database, run test, drop database and only error when restore database.
Don't know why the error occurs. I tried to revoke connection before killing connections but have no luck.
https://stackoverflow.com/questions/5108876/kill-a-postgresql-session-connection

this is issue with compose command for restore database, try to debug behat pg isolator.
try var_dump($process); sleep(90); here https://github.com/oroinc/platform/blob/master/src/Oro/Bundle/TestFrameworkBundle/Behat/Isolation/UnixPgsqlIsolator.php#L234 and check command by hands while pause in behat execution.

The result:
PGPASSWORD="dbpassword" psql -h localhost --port= -U dbuser -t -c "SELECT pg_terminate_backend(pid) FROM pg_stat_activity WHERE datname in ('dbname', 'dbnamedb5a3a158b157ce712224359') AND pid <> pg_backend_pid()"
psql: FATAL:  database "dbname" does not exist

yep, this mean that db, does not exist any more, did you know why this happen?

check carefully db name

If the database name is mistake, why it can run test, backup database, and drop database?

I believe that it issue (it's bug actually) in command, but I don't see where. Please double check dbname, the error is about that it unable to find db with specified name, but it should be, isn't it?

I think the problem occurs after dropping the test database process. As I commented above, if I comment out this line, it works normally.
https://github.com/oroinc/platform/blob/master/src/Oro/Bundle/TestFrameworkBundle/Behat/Isolation/UnixPgsqlIsolator.php#L197
I think the system tried to connect to "dbname" when run the kill connections command.
If I change the command to connect to other database, it works.
ie:
PGPASSWORD="dbpassword" psql -h localhost --port= -U dbuser --dbname=dbnamedb5a3a158b157ce712224359 -t -c "SELECT pg_terminate_backend(pid) FROM pg_stat_activity WHERE datname in ('dbname', 'dbnamedb5a3a158b157ce712224359') AND pid <> pg_backend_pid()"

psql: FATAL:  database "dbname" does not exist

this mean that db does not exist. It unable to connect to DB that was dropped or not exist at all. You should recognize why this happen

Same as this case:
https://superuser.com/questions/655399/calling-the-psql-command-without-selecting-any-database

The db name get here

Please understand me, the problem is not in the database name, it is in the kill connection command. Because the kill connection command does not select any database, so it'll use the username as database.
In my case, the username and database name are same: "dbname" => "dbname" is used but "dbname" does not exist.

As I see there are parameters for dbname see https://github.com/oroinc/platform/blob/master/src/Oro/Bundle/TestFrameworkBundle/Behat/Isolation/UnixPgsqlIsolator.php#L242-L243 Can you recognize where issue is?

https://github.com/oroinc/platform/blob/master/src/Oro/Bundle/TestFrameworkBundle/Behat/Isolation/UnixPgsqlIsolator.php#L235
The command does not select any database to connect to. It only specifies host, port, username.
https://www.postgresql.org/docs/9.2/static/app-psql.html

why not, see
https://github.com/oroinc/platform/blob/b90343b4464f9aea5094b1ea911c5aa8639f6fef/src/Oro/Bundle/TestFrameworkBundle/Behat/Isolation/UnixPgsqlIsolator.php#L237
WHERE datname in (\'%s\', \'%s\')

PGPASSWORD="dbpassword" psql -h localhost --port= -U dbuser -t -c "SELECT pg_terminate_backend(pid) FROM pg_stat_activity WHERE datname in ('dbname', 'dbnamedb5a3a158b157ce712224359') AND pid <> pg_backend_pid()"
It just a command to execute, before execute command, you must connect to a database.

It is equal to:
PGPASSWORD="dbpassword" psql -h localhost --port= -U dbuser -t -c "Command to execute"

Should we specify the database name? ie:
 PGPASSWORD="dbpassword" psql -h localhost --port= -U dbuser -t -c "Command to execute" -d "dbname"
Or
PGPASSWORD="dbpassword" psql -h localhost --port= -U dbuser -t -c "SELECT pg_terminate_backend(pid) FROM pg_stat_activity WHERE datname in ('dbname', 'dbnamedb5a3a158b157ce712224359') AND pid <> pg_backend_pid()" -d dbname

yep. If it will resolve your issue. Please check the solution and let me know, I'll check it on our CI

@xgitxhubx please setup port 5432 in your parameters file as a workaround, --port= is a wrong way to define bash options, should be --port=5432

@sergeyz It works without the port. Because I used prod env for testing.

I suggest to connect to template0 or template1 database then

@sergeyz and @spolischook I have the same issue as @xgitxhubx.
The behavior is the same. And the error is like:
[Symfony\Component\Process\Exception\ProcessFailedException]
  The command "PGPASSWORD="root" psql -h db --port=5432 -U root -t -c "SELECT pg_terminate_backend(pid) FROM pg_stat_activity WHERE datname in ('orocommerce', 'orocommercedb5a7b1a5994c54003429856') AN
  D pid <> pg_backend_pid()"" failed.

  Exit Code: 2(Misuse of shell builtins)

  Working directory: /var/www/htdocs

  Output:
  ================

  Error Output:
  ================
  psql: FATAL:  database "root" does not exist

I tried to add the -d dbname to command and I works when tries to create the dump but then fails on "Restore database from dump".
@xgitxhubx how did you fix that?

I created a new database with username = 'root'  and dbname='root' to test, and it worked on "Dumping current application database" step. But it failed after when it tried to execute the step "Run message queue"
Dumping current application database
time: 595 ms
Booting the Kernel
Application ready for tests
Run message queue

  [Doctrine\DBAL\Exception\DriverException]
  An exception occurred while executing 'SELECT * FROM oro_message_queue':

  SQLSTATE[57P01]: Admin shutdown: 7 FATAL:  terminating connection due to administrator command
  server closed the connection unexpectedly
        This probably means the server terminated abnormally
        before or while processing the request.

Looks like this is caused by the killConnections() method, am I right? How to fix this?

@nevoeiro in my case, I commented this line https://github.com/oroinc/platform/blob/b90343b4464f9aea5094b1ea911c5aa8639f6fef/src/Oro/Bundle/TestFrameworkBundle/Behat/Isolation/UnixPgsqlIsolator.php#L197 to fix it temporarily.

It happens when your database_name is equal to database_user.
In this case database specified in database_name will be removed during the restoration state process.
But command psql which kills connection need to have database with the same name as database_user.
Please try to use different values for database_name and database_user.


Should we move the Command Reference to a separate doc

What is the problem you're trying to solve
Currently the Command reference is part of the README.md. Although it makes the command reference more visible, I feel it has several drawbacks:

It makes the README very long, and makes other sections less visible. For example,

Sometimes new contributors have to read README carefully to notice how to test nerdctl.
It makes other documents less visible: other document is after the long command reference in README. Without a heading TOC, it's hard to notice there is an other document section at the end.
It makes unimplemented commands less visible: e.g., https://github.com/containerd/nerdctl/issues/1854

We don't have a single page/link that can direct users to nerdctl command document.

Although we have a README header link, the same page has many sections that are not relevant to end-users (i.e. not nerdctl developers/contributors).

Describe the solution you'd like
We shoud have a command-reference.md in nerdctl/docs (similar to faq) that are only for command reference/doc. We should hightlight the reference doc in the beginning of README, and probably put the link in the About section of the repo.
Additional context
cc @containerd/nerdctl-maintainers

SGTM

If there is a possibility that we may want to split the command reference into multiple files, maybe it should be placed in a directory like docs/command-reference/README.md

If there is a possibility that we may want to split the command reference into multiple files, maybe it should be placed in a directory like docs/command-reference/README.md

Currently I feel a single md should serve us/users well given that we use the markdown preview for visualization/navigation, and the single file can be used as the link to our command reference.
We can split and place in a directory if later we decide to build a website for command reference, maybe something similar to docker reference
https://docs.docker.com/engine/reference/commandline/docker/
https://github.com/docker/cli/tree/master/docs/reference/commandline

If decide to build a website, it can be a part of containerd docs IMO.


ubuntu: Add libcap2-bin for capsh

Fixes: https://github.com/toolbx-images/images/issues/73

This file is used during the container build to include the package in the container.

This file is used during the container build to include the package in the container.

What I mean is - add it directly to the Containerfile - same install command but explicitly on the command line there.
Because packages listed in extra-packages are supposed to be 'extra' as the name suggests (i.e. optional) and one can expect to clean this file and the image to still be functional (which it won't be, without capsh).

Feel free to make a PR to create that split :)

We don't split between "mandatory" and "extra" packages as far as I know.

I consider whatever we install in the Containerfile to be required for the image to function, by this logic - there is a split already :) For example, ubuntu-minimal, ubuntu-standard and libnss-myhostname installed there are mandatory.

Opened #75 which reverts this partially (not the sort).

For example, ubuntu-minimal, ubuntu-standard and libnss-myhostname installed there are mandatory.

The Git history says that /usr/local/sbin/unminimize, ubuntu-minimal and ubuntu-standard were removed in commit 5cbaecde2f30ea1d to fix the build.

For example, ubuntu-minimal, ubuntu-standard and libnss-myhostname installed there are mandatory.

The Git history says that /usr/local/sbin/unminimize, ubuntu-minimal and ubuntu-standard were removed from ubuntu-toolbox:18.04 in commit 5cbaecde2f30ea1d to fix the build.

I'm curious what happened there.. but it has worked before that and it works now (unminimizing and installing ubuntu-minimal and ubuntu-standard metapackages; plus other container are just like this). Hopefully it was just an intermittent failure...


Xamarin - System.MissingMethodException - 'Microsoft.AspNetCore.SignalR.Client.HubConnectionExtensions.InvokeAsync' not found

Hi,
I have create a Xamarin Forms solution with 4 projets :

Client.DataAccess (for my data access layer using SignalR to communicate with Server)
Client (the UI and VM for the Xamarin Forms)
Client.Android (application Android)
Client.UWP (application universal Windows Plateform)

Client have Client.DataAccess has reference
Client.Android have Client has reference
Client.UWP have Client has reference
The Client.DataAccess and Client projects target netstandard2.0.
the Client.DataAccess use this two packages :

"Microsoft.AspNetCore.SignalR.Client" version "1.0.0-alpha2-final"
"Microsoft.AspNetCore.SignalR.Client.Core" version "1.0.0-alpha2-final"

The UWP version of the Xamarin application work without a problem.
The Android version crash went trying to evaluation this method :
 private async Task CreateConnection(string token, AuthentificationProvider provider)
 {
            _server = new HubConnectionBuilder()
                    .WithUrl("http://<IP_ADDRESS>:50050/services")
                    .WithMessagePackProtocol()
                    .WithConsoleLogger(LogLevel.Debug)
                    .Build();
            await _server.StartAsync();
            var temp = await _server.InvokeAsync<Guid?>("Authenticate", token, provider);
}

I got the error :
System.MissingMethodException: Method 'Microsoft.AspNetCore.SignalR.Client.HubConnectionExtensions.InvokeAsync' not found.
look like the method extension method "InvokeAsync" is not found at runtime.
I try to add the reference directly in the packages.config to this two packages but the error still persist.
the Client.Android project have reference to "NETStandard.Library" package.
thank for your help :)
sorry for my English.

Can you share a minimal repro as a github repo? This seems like a package version mismatch (i.e. using the alpha1 Microsoft.AspNetCore.SignalR.Client.Core somewhere but from your description it seems you are using the correct version). As a side note - you don't need to bring Microsoft.AspNetCore.SignalR.Client.Core package explicitly. The right version should be installed for you automatically when you add a reference to the Microsoft.AspNetCore.SignalR.Client package.

Hi Moozzyk, thank for your reply, help and time. The problem was my fault, I make a mistake with the reference, now my solution have only one reference to the package "Microsoft.AspNetCore.SignalR.Client" inside the "Client.DataAccess" (netstandard2) and everything work 👍 . Thanks also for your side note about the other package, I have remove him.


SQLitePCL.raw and msvcr110.dll

Hi,
I want to avoid install vc++ redistributable on every client machine. But when I try to copy compiled program to another computer I've got error.
The program can't start because MSVCR110.dll is missing from your computer. Try reinstalling the program to fix thix problem.
Exception thrown: 'System.DllNotFoundException' in SQLitePCL.raw.dll
I cannot copy MSVCR110.dll because some computers are Vista and MSVCR110.dll from Windows 7 doesn't work.
Is it possible to exclude this requirments from your library ?
Best regards,
alexiej
Version Used: Latest Stable: 1,1,
,NET Framework used: 4.5.1
Visual Studio 2015

Version 0.9.0 (to be released soon) addresses this problem by allowing/requiring you to specify exactly which native code implementation of SQLite you want to use and providing SQLitePCL.native.sqlite3.v110_xp, which is the one you want.  The README (front page of this github repo) is currently being updated with more info along these lines.

Closing this issue because 0.9.x has been released.


helm: support resources override for gateway injection

Gateway injection currently doesn't support having configurable resource requests and limits. This PR uses similar annotations that are currently used by sidecar injection to override resources.
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

[ ] Ambient
[X] Configuration Infrastructure
[ ] Docs
[ ] Dual Stack
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[ ] Upgrade
[ ] Multi Cluster
[ ] Virtual Machine
[ ] Control Plane Revisions

Please check any characteristics that apply to this pull request.

[X] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

Hi @itsLucario. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

/ok-to-test

@itsLucario: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
b2653ee5cc668ec9ec54bf07b572cc1c09e4e66f
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@itsLucario: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
b2653ee5cc668ec9ec54bf07b572cc1c09e4e66f
link
true
/test gencheck

release-notes_istio
b2653ee5cc668ec9ec54bf07b572cc1c09e4e66f
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@itsLucario: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
ef10b177370384ddd6b49e082802d86d9aa2e78e
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@itsLucario: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
ef10b177370384ddd6b49e082802d86d9aa2e78e
link
true
/test release-notes

integ-security-istiodremote_istio
ef10b177370384ddd6b49e082802d86d9aa2e78e
link
true
/test integ-security-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

/retest

@itsLucario: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-istiodremote_istio
ef10b177370384ddd6b49e082802d86d9aa2e78e
link
true
/test integ-security-istiodremote

release-notes_istio
ef10b177370384ddd6b49e082802d86d9aa2e78e
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@itsLucario: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
926d1a9eac528b4b9189ed2f1b975f71768d4eda
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jacob-delgado Is release note required for this? I see the check failing

PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@itsLucario: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
e5cabe8f90519739aa4d0c88ed2ac5273840eb90
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@itsLucario: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
e5cabe8f90519739aa4d0c88ed2ac5273840eb90
link
true
/test release-notes

gencheck_istio
e5cabe8f90519739aa4d0c88ed2ac5273840eb90
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Would love to see this feature get merged. I had an almost identical PR open for this that's now closed due to being stale, hoping this one doesn't meet the same fate. 🙏

PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.


ContentWrapper should implement Enumerable and not use Method Missing

Using Method Missing is a messy hack to pass messages from ContentWrapper to its content. It allows ContentWrapper to behave like its content in ways that were not necessarily intended. ContentWrapper should probably implement enumerable and delegate enumerable methods to its content.

No longer an issue since ContentWrapper has been removed


Run all Relay tests from facebook/relay using this package

I suspect that if those pass, then we have been 100% successful with this package - right now it seems like not everything works, according to issues like #3.

Note, tests don't pass with Node 5: https://github.com/facebook/relay/issues/832


feat(react): Implementation of Card and CardGroup components

This commit also covers a patch fix issue #299.

@wc-lei we said this was just missing a tweak to the controls and could then be merged.


compose: Add clear field button for compose topic name Fixes #21464

Added a button to clear the compose thread name field.  I used existing CSS to replicate the button found in the filter streams text input.  I also added a little bit of padding so the words don't overlap with the button as they do in the filter streams input.  Added a simple click listener to clear the input.
Edit:
Added functionality to automatically show/hide the clear topic button:
static/js/click_handlers.js

Removed click listener, moved it to compose.js

static/js/compose.js

Added update_topic_clear_button_display() which checks to see if the topic input box is empty.  If it's empty it hides the clear button.  Otherwise it shows it.
Added call to above function when focus is given to topic input
Added keyup listener inside topic input to call above function
Moved click listener for clear button to this file, it makes more sense here

static/js/compose_actions.js

Added a few lines to unhide the clear button when the compose box is closed.  Otherwise clearing the box, then closing the compose box and reopening it resulted in the button remaining hidden.

compose.css

Modified width to match recently merged changes
Added selector to adjust width/padding when empty class is applied.  This keeps the box from changing sizes when the button is shown/hidden.
Default padding was causing the box to be unstable and change size when hiding/showing the button.  So I overrode it.

CZO discussion
Testing plan: Manually tested
Button Shown

Button Hidden

fixes #21464

@alya Yeah sorry I didn't notice that part.  I've updated the PR to automatically hide/show the button.
As far as the other changes, it looks like they're resolved in #20063, it just hasn't been merged yet.

Great, thanks! Have you had a chance to review #20063? Please feel free to leave any ocmments.

@amanagr would you be up for reviewing this one?

@riedldsr can you fix the merge conflicts so that I can review this?

@amanagr Sorry I'm still trying to understand Git all the way.  I think that fixed it?

@riedldsr unfortunately that generated a merge commit, which generally one doesn't want. (GitHub's UI really pushes you to make them).  We use a rebase-based workflow. Check out our GitHub guide and commit guidelines for more details -- the Git guide in particular has a pretty extensive set of materials, including some on the rebase-based workflow we use (though
not as many as I'd like).

@timabbott I messed it up big time!  I just made a new PR #21845 with the same changes.
Thank you!


android sdk 1.2.2 notes update

Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the CODEOWNERS.
What Type of PR is This?

[ ] Issue
[ ] Feature
[X] Maintenance/Chore

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6581e204e552d049adf9c3aa--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6581e41e01e0a84e1b43a0cd--harness-developer.netlify.app


[Fix]: MenuAnchor is close when screen size change (#146380)

Fix https://github.com/flutter/flutter/issues/146380
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

This is a difficult problem in general, please see https://github.com/flutter/flutter/issues/146380#issuecomment-2048203784

This is a difficult problem in general, please see #146380 (comment)

@HansMuller  I understand, so I added a parameter closeMenuWhenViewChange to allow the user to close the window when it changes. The default is closed.  can we do this?

Hi @zeqinjie thank you for your contribution. Based on the feedback from @HansMuller and the discussion in the issue, we think this is WAI, but if not, we would want to resolve this issue in a different way. I appreciate you looking into this and sending a proposal! If you are still interested in working on a solution, I would recommend discussing it in the issue. Thank you!


Fix json content headers

We were returning data as text/html from 5 routes; this fixes that and also:

returns a non-error response from /api/organizations/<organization_name>/attendance when there is no attendance data available
changes the format of what's returned from /api/organizations/attendance because a list isn't valid JSON

@ondrae is anything or anybody consuming the /api/organizations/attendance endpoint that we'd need to change or inform before we merge this PR?
Closes #279

No nobody is using that attendance endpoint. Its not documented anywhere either #249


Use SDL3_ttf_0.0.0 for versioned symbols, not SDL3_mixer_0.0.0

I assume this was a copy/paste mistake.

This was my bad. Thanks for noticing and fixing.

FYI I'm starting to look at packaging the SDL3 satellite libraries in Debian experimental, which is why I'm noticing this sort of thing. (I know they're not stable APIs yet, but in Debian experimental there's no expectation of things working reliably - it's for developers only, and breaking changes are considered to be OK.)


Filtering items through all pages

I would like to have my collection paginated, but I would like to have a filter text box at the top of the table where a user can start typing and it'll show everything matching what they are typing.
How would I go about doing this with your pagination ?

For me moving itemsPerPage to the last item fixed the fact it would only order the current page. Thanks!


Unable to load the session repo projects

After I get the latest changes specially "Update .kproj => .xproj", the VS can't load the projects properly

FYI whenever I modify the solution and change the projects extension to .kproj it works fine, i'm still asking is there any reason for this update kproj -> xproj

I run kvm upgrade to get the dnvm and everything works fine from Power Shell, still i'm working with Sublime integration in windows, and hopefully this issue got fix in the next release of VS

@hishamco - change from .kproj => .xproj happened only on the dev branch. So VS to load the .kproj files will be available in future. Beta3 code lives in master branch. You could try that.


Update Composer command.

Closes #11.

Just found this in my list of pull requests. I honestly couldn't tell you which project I had this issue with, so I'm going to close it. Thanks for reviewing :)


failed to run ["scripts/get_maintainer.pl" "--git-min-percent=15" "-f" "home/aota06/uncontained/uncontained/runtime/uncontained_kasan.c"]: exit status 2

When I am doing experiment 1, I come up with an error information:
2023/09/27 12:19:56 failed to symbolize report: failed to run ["scripts/get_maintainer.pl" "--git-min-percent=15" "-f" "home/aota06/uncontained/uncontained/runtime/uncontained_kasan.c"]: exit status 2
scripts/get_maintainer.pl: file 'home/aota06/uncontained/uncontained/runtime/uncontained_kasan.c' not found
2023/09/27 12:19:56 vm-3: crash: KFENCE: use-after-free in uncontained_type_check
2023/09/27 12:19:56 vm-5: running for 5m42.812482747s, restarting
2023/09/27 12:19:56 vm-2: running for 1m46.975798594s, restarting
2023/09/27 12:19:57 VMs 0, executed 1157610, cover 83684, signal 155599/182044, crashes 70, repro 1
2023/09/27 12:20:07 VMs 0, executed 1157610, cover 83684, signal 155599/182044, crashes 70, repro 1
2023/09/27 12:20:17 VMs 0, executed 1157610, cover 83684, signal 155599/182044, crashes 70, repro 1
2023/09/27 12:20:27 VMs 0, executed 1157610, cover 83684, signal 155599/182044, crashes 70, repro 1
2023/09/27 12:20:37 VMs 0, executed 1157610, cover 83684, signal 155599/182044, crashes 70, repro 1
2023/09/27 12:20:40 vm-6: running for 758.702µs, restarting
2023/09/27 12:20:41 reproducing crash 'KFENCE: use-after-free in uncontained_type_check': 953 programs, 4 VMs, timeouts [15s 1m40s 6m0s]

It seems like a typo about the file path. I checked my kernel-tools/.env file and it seems correct:
REPOS=/home/aota06/uncontained/uncontained
LLVMPREFIX=/home/aota06/uncontained/uncontained/llvm-project/build
KERNEL=/home/aota06/uncontained/uncontained/linux
ENABLE_KASAN=1
ENABLE_DEBUG=1
ENABLE_SYZKALLER=1
ENABLE_GDB_BUILD=1
ADDITIONAL_LLVM_VARIABLES=-DLLVM_ENABLE_EH=ON -DLLVM_ENABLE_RTTI=ON

Do you know the root cause of this problem? Thanks!

Sorry, haven't seen this until know. I can't seem to reproduce this but it seems like something internal on how scripts/get_maintainer.pl gets invoked. The kernel does not expect absolute paths for some of their tooling (required for the runtime) and then most likely breaks.
Since I'm not able to reproduce, I'll close it for now.


duffle version returns the commit even with a "release" name

for https://github.com/deislabs/duffle/releases/tag/0.3.2-beta.1, for which there is a formal "release name", the command duffle version merely lists the commit. This is fine for developers of duffle, but for general users, release names should be of the form "release-name (commit)"
 🔋 55% (1:19)  duffle version                                                                                 ✔  8877  15:53:56
44aad89

https://github.com/deislabs/duffle/blob/44aad89f21eec35fbb6b1400e33ed4e1a565a361/Makefile#L11


No sound on iPad Pro

First of all I want to thank you all for developing this project and making it open source!
So I just “installed” the Game Play Color by adding the website to my Home Screen. All the .gb and .gbc files I have are running smoothly, only the sound is not working on any of them. The device I’m running it on is: iPad Pro (12.9-inch) (3rd generation) with iPadOS 15.5 (19F77)
Maybe the cause is the game boy files themselves, if you want to check that let me know and I can add a link to them.

I've double checked this and it seems to be working for me. I've always found the iPad's audio controls to be a little more confusing than on the iPhone as you have to make sure the device isn't in silent mode for the sound to work in-browser, even though that isn't necessary for some other apps. Perhaps that's the issue you were seeing?
Closing as not planned since I don't think there are meaningful changes to make here.


introduced assert-twice-that object

Closes: #167
What is done:

added new assert-twice-that object
added several tests
added several todos

@yegor256 Please, have a look

@rultor merge

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 19min)


Copy-paste screws up indentation for no reason AND alters contents of pasted string

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.95.3
OS Version: Manjaro Linux

Steps to Reproduce:

I start with this code:

Then I start adding this:

I copy this portion of code from above:

And  I paste it here:

Expected behavior:
I should get this:

Observed behavior:
I get this instead:

This is completely bonkers! Not only is this not sensible indentation, but crucially, the pasted code alters the contents of the string!!!!!!
Sometimes, when pasting a multi-line string into a region of code with different indentation than the one the original string was copied from, one doesn't get the desired indentation and that's expected because the contents of the string are sacred. The IDE doesn't know whether the whitespaces inside the string matter, so, at least by default, it preserves the contents of the string at the expense of indentation. And that's expected.
But here, the resulting indentation makes no sense AND the contents of the pasted string are altered with  respect to the copied one!! This makes no sense whatsoever! The indentation of the code where the new code is pasted is the same as where the code is copied from, so there's no need to alter the indentation in the first place, but the IDE is removing spaces for no reason whatsoever AND it's changing the contents of  a pasted string, even unnecessarily.

/assign -rebornix +@aiday-mar

can also confirm in typescript
multi-line strings get de-indented on paste 🐛


Dupe bug

If a tank is in pulling on a side with a pipe that is pumping out of the tank, it causes the fluid inside to be duplicated.

Wrong mod


facedev !gi

@face-hh talk to me to try fixing your issue https://youtu.be/37ISfJ2NSXQ?feature=shared&t=293
Two solutions:

remove https://github.com/face-hh/wattesigma/blob/main/Scripts/CEF.gd#L114
Is this code did not work for you ?

func _on_page_failed_loading(err_code, err_msg, node):
	if err_code == -3:
		return
	serve_error(err_code, err_msg, node)

I tried facedev !gi but it seems you have disabled it, now ?
Please add !ph, !xv and !xh for my personal usage :)

I wonder what !ph would be...
Please don't implement that

Also, xh seems to be a bad site when you search xh... I have no idea what you're referring to, could you elaborate?

Relax I'm trolling 😜

@face-hh talk to me to try fixing your issue https://youtu.be/37ISfJ2NSXQ?feature=shared&t=293
Two solutions:

remove https://github.com/face-hh/wattesigma/blob/main/Scripts/CEF.gd#L114
Is this code did not work for you ?

func _on_page_failed_loading(err_code, err_msg, node):
	if err_code == -3:
		return
	serve_error(err_code, err_msg, node)

I tried facedev !gi but it seems you have disabled it, now ?
Please add !ph, !xv and !xh for my personal usage :)

I'll try the 1st solution when I get home, and the 2nd solution seems to simply ignore the error and not serve the error page.

!ph 😂

!ph 😂

its !ph is Product Hunt, not the naughty Hub...

I'm only productive with the naughty one. Joke apart: CEF does not embed h264 or ffmpeg for licence reasons.


can't read docs on small screen

I looked at docs on my phone to find out what this is but is not responsive so I still don't know. :(

Duplicate #2443.
Currently we don't have time to optimize docs for mobile devices, however it's somewhere in my personal priority list 🐱
It's not a critical issue for us because SUIR and SUI are responsive, you can check layout examples. Also, we will accept PR that improves docs accessability.

NP, sorry  it's a duplicate.

NP, feel free to submit PR that improves this 👍


PR: Add Phosphor and Remix Icon support

This PR adds Phosphor and Remix Icon support.
I think these fonts provide many icons and are useful.
Can you pull it if possible?
Phosphor
MIT License
https://github.com/phosphor-icons/phosphor-icons/commit/c64475a0a807d526bd39bf7b3de6fb0f7d872584
Remix Icon
Apache License Version 2.0
https://github.com/Remix-Design/RemixIcon/commit/943f2e7c45ad81ff95bf444ed4c4ada90a46de5a

Hi @dalthviz, thank you for the review. I applied your all suggestions.


Persist TessBaseAPI over calls for better performance

Hi there!
I see that, out of tens of tesseract_ocr forks, this one seems most maintained - thank you!
I don't know what are your plans, but core feature of my app is ocr, so I'm very interested in helping you to maintain this!
Okay, countresy aside - I see that the TessBaseAPI object is re-initiated every call:
https://github.com/khjde1207/tesseract_ocr/blob/934300d2cdf321a2182195c917cb219267f56e10/android/src/main/java/io/paratoner/flutter_tesseract_ocr/FlutterTesseractOcrPlugin.java#L45
Isn't this inafficient? Can we persist it somewhere and expose methods to init/dispose it?

Good idea.
It's currently being developed for web support.
I'll check it out when the web support development is done.

0.2 seconds faster per page than before
I tested it with 10 pages.
About 2 seconds faster.

This is great! Thanks!!


DAQ misbehavior when changing channel sampling range

When we change the signal start and end values and hit apply, we get the above error. Sometimes.

probably user error?


Allow disabling inlining for MultiZarrToZarr

I am trying to combine some massive S3-based Zarr references. A MultiZarrToZarr operation which would otherwise take a minute would take days because the size of each file on S3 is being queried. Thus I want to be able to pass in inline_threshold=None so that my datasets combine in a reasonable timeframe.

I think this was already possible with inline_threashold=0 ?

Nope, if inline_threshold=0 then fs.info(fn) still gets called in order to ensure that the file size isn't negative. :sweat_smile:
We could change this so that we use 0 in place of None. That would probably make more sense actually. Then my conditional self.inline is not None becomes self.inline > 0.

That sounds like a good plan

Ok @martindurant, that should take care of it.
Now the code should be functionally identical to the previous, except that the file size lookup is skipped when unneeded. In other words, no more inline_threshold=None but instead inline_threshold=0 is optimized.

Oh, I'm sorry, I'm on my laptop at the moment and it looks like I forgot to set up pre-commit :see_no_evil:
Please feel free to squash this PR.

Hmm, this test failure I can reproduce locally, also from main. I'm guessing it's a dependency issue.

@Anu-Ra-g , any idea?
>       assert (
            idx_df["typeOfLevel"][[42, 46, 49, 50]]
            == ["heightAboveGround", "isobaricInhPa", "surface", "heightAboveGround"]
        ).all()
E       AssertionError: assert False
E        +  where False = <bound method NDFrame._add_numeric_operations.<locals>.all of 42     True\n46     True\n49     True\n50    False\nName: typeOfLevel, dtype: bool>()
E        +    where <bound method NDFrame._add_numeric_operations.<locals>.all of 42     True\n46     True\n49     True\n50    False\nName: typeOfLevel, dtype: bool> = 42    heightA... dtype: object == ['heightAbove...tAboveGround']
E             Full diff:
E             - [
E             -  'heightAboveGround',
E             ? ^^                 --
E             + 42    heightAboveGround
E             ? ^^^^^^
E             -  'isobaricInhPa',...
E
E             ...Full output truncated (8 lines hidden), use '-vv' to show.all

Interesting, it seems like something's getting mangled. When I run locally the assert above passes for me, but the subsequent one fails.
Note that for me stepType is instant instead of the asserted accum.
idx_df.iloc[83]
varname                                                             wz
typeOfLevel                                              isobaricInhPa
stepType                                                       instant
name                                       Geometric vertical velocity
isobaricInhPa                                                    975.0
step                                                   0 days 06:00:00
time                                               2023-09-28 00:00:00
valid_time                                         2023-09-28 06:00:00
uri                  ~/repos/kerchunk/kerchunk/tests/gfs....
offset                                                        21234675
length                                                         1035696
inline_value                                                      None
surface                                                            NaN
heightAboveGround                                                  NaN
meanSea                                                            NaN
Name: 83, dtype: object
GitHub request

I'm guessing it's a dependency issue.

The culprit is eccodes v2.38.0.

@maresb I tried to emulate the above steps on my local system. The error is not occurring consistently.
And this object is still accum when I tried it locally,
varname                                                           watr
typeOfLevel                                                    surface
stepType                                                         accum
name                                                      Water runoff
isobaricInhPa                                                      NaN
step                                                   0 days 06:00:00
time                                               2023-09-28 00:00:00
valid_time                                         2023-09-28 06:00:00
uri                  ./kerchunk/tests/gfs.t00z.pgrb2.0p25.f006.test...
offset                                                        59215098
length                                                          348767
inline_value                                                      None
surface                                                            0.0
heightAboveGround                                                  NaN
meanSea                                                            NaN
Name: 83, dtype: object

Thanks @Anu-Ra-g! May I ask which version of eccodes you are using?

I'm on eccodes version 2.36.0

Since the test failure is unrelated to this PR, I recommend moving discussion to #508.
@Anu-Ra-g, to reproduce the failure you need to upgrade to eccodes v2.38.0.

Thanks a lot @martindurant for the merge!!! :pray:


image build: support arm and amd64

Summary
What change needs making?
Now， if we build controller image, the imgae Architecture will be same as your machine, it can not use on arm and amd64 at the same time. so we want to change.
Use Cases
When would you use this?

Message from the maintainers:
Love this enhancement proposal? Give it a 👍. We prioritize the proposals with the most 👍.

Are you asking for the ability to choose which single architecture to build for, or the ability to build multiple architectures into a single image with manifest?
Is this just for the docker images?
As a temporary workaround for building images you can set one or more platforms in the Makefile with
%-image:
	[ ! -e dist/$* ] || mv dist/$* .
	docker buildx build \
		--platform linux/amd64,linux/arm64 \
		--build-arg GIT_COMMIT=$(GIT_COMMIT) \
		--build-arg GIT_TAG=$(GIT_TAG) \
		--build-arg GIT_TREE_STATE=$(GIT_TREE_STATE) \
		-t $(IMAGE_NAMESPACE)/$*:$(VERSION) \
		--target $* \
		--load \
		 .

The critical changed line there being --platform.
We'd accept a PR for formalizing this if you want to do it, so long as it only built for the "same as your machine" in the default case. You could set an environment variable to override this behavior.

Are you asking for the ability to choose which single architecture to build for, or the ability to build multiple architectures into a single image with manifest? Is this just for the docker images? As a temporary workaround for building images you can set one or more platforms in the Makefile with
%-image:
	[ ! -e dist/$* ] || mv dist/$* .
	docker buildx build \
		--platform linux/amd64,linux/arm64 \
		--build-arg GIT_COMMIT=$(GIT_COMMIT) \
		--build-arg GIT_TAG=$(GIT_TAG) \
		--build-arg GIT_TREE_STATE=$(GIT_TREE_STATE) \
		-t $(IMAGE_NAMESPACE)/$*:$(VERSION) \
		--target $* \
		--load \
		 .

The critical changed line there being --platform.
We'd accept a PR for formalizing this if you want to do it, so long as it only built for the "same as your machine" in the default case. You could set an environment variable to override this behavior.

yeah, I have test it locally, when I add the arg --platform linux/amd64,linux/arm64, it will failed with error ERROR: docker exporter does not currently support exporting manifest lists, It seems that the limitation is combination of --load and multiple values to --platform. Eg. --platform linux/arm64 --load works fine. So I solve it according to https://github.com/docker/buildx/issues/59 to set * enable "User containerd for pulling and storing images" in Settings > Features in development > Beta features, it works but need more time to build images.


Collection search draft

Related Issue(s):
Hi, I'm using this branch to discuss about collection search which is an hot topic for me and I needed to sort it out as per this pull request.
I'm encountering the following problems:

We still need to use the POST to create new Collection(s) but the incoming expexted body is different
Incompatible with Transactional (how to have it working?)

[The pull request uses another endpoint to avoid the clash]
Questions:

Why the specifications define a new endpoint to search for items: .../search  while for the collections we are overloading the /collections ?
Do you have any working example about having both search and creation working at the same time?

Description:
This patch reduced code duplication and implements the same search capabilities that we have over items but over collections returning a standard (?) /collections search response with the result of the search in the collection index.
The collectionID list for now is simply ignored.
PR Checklist:

[x] Code is formatted and linted (run pre-commit run --all-files)
[ ] Tests pass (run make test)
[ ] Documentation has been updated to reflect changes, if applicable
[ ] Changes are added to the changelog

here it is:
https://github.com/stac-utils/stac-fastapi/issues/749

@ccancellieri great thank you!

https://github.com/stac-api-extensions/collection-search/issues/17


Closed laptop display not enabled after unplugging other displays

Start with displays connected, lid closed
Unplug displays
Open lid

Laptop display is off. Plugging other displays does nothing. User can successfully switch to a console however the compositor session remains off when switched to.
Possible sway/wlroots issue. #31 with some automation may be a solution.
See https://github.com/alex-courtis/way-displays/issues/33#issuecomment-1093960493 for logs.

Attaching another log with this problem, this time with debug flag enabled.
Opened lid immediately after disconnecting laptop (few seconds max), and for some amount of time, I am unable to even switch to non-graphical console (ctrl+alt+F2), it seems the laptop is completely hung. However, after repeated trying, I am able to switch to console, and from then, switching works every time. There have also been instances when I am unable to switch back at all. Process list indicates way-displays as well as Sway is running. Log ends when I kill Sway process manually.
way-displays.debug.unplug-closed.log

Another different scenario, simulating normal day-to-day workflow with laptop/dock operation. I have been able to repeat this twice.
Start with freshly launched Sway/way-displays, laptop unplugged, lid open.

Close lid (laptop should go into s2idle suspend)
Wait 5-10 seconds, plug laptop (still closed) into dock. Laptop wakes up, both displays are detected and set up properly. However, the closed laptop display seems to still be active, as one of my workspaces is not visible, yet I can still operate on whatever is on it.
Unplug laptop from dock. From previous experience, I expect it goes back to s2idle at this point.
Wait 5-10 seconds. Open lid. After initial delay of some seconds, the display comes alive complete with sway workspace, but goes blank after a split second. A few seconds after that, display comes back on and behaves as expected, however, way-displays has exited at this point.
Looking at the log, it seems that when laptop wakes after opening the lid, way-displays detects the lid open event, but still consider the (now long gone) external displays to be attached, and attempts to rearrange them, only later registering the "Departed" events.
way-displays.debug.sleep-plug-unplug.log

Opened lid immediately after disconnecting laptop

That's fantastic - exactly what I was after!
[15:08:26] eDP-1 Changing: is the key: we are not getting any response for that operation until [15:08:38] [src/listener_output_configuration.c:51] Output Configuration cancelled 0xb5e which occurs after the unplug of the external displays. It may be a sway/wlroots failure which results in the response not being sent.
This can be worked around / fixed.

2. However, the closed laptop display seems to still be active

That can be fixed now: incoming. The event logging shows that changes may be aggressively retried following a cancellation.

4. Looking at the log, it seems that when laptop wakes after opening the lid, way-displays detects the lid open event, but still consider the (now long gone) external displays to be attached, and attempts to rearrange them, only later registering the "Departed" events.

The delayed processing until the lid is opened will be resolved with the above fix.
The arrive/depart/arrive is "normal" finnicky monitor behaviour. That is not a problem however the failure during that behaviour is, and will be investigated/fixed.

Fix: aggressively retry after cancellation, as there are no other update/change events in flight. If there are, subsequent retries will handle the situation, as they will operate on the updated information.


Nothing shown on fitness trend page after selecting 24 months

Environment:

Plugin version: 6.01
Chrome/Opera/Chromium version: 64.0.3282.186
OS version: OSX 10.13.3

The problem:
Steps to reproduce:

On the fitnesstrend page, select 24 months as the timeframe
The page shows an empty bar, indicating that it is loading, but even after 5 minutes no result.
It seems that the problem is that I do not have any activity from 24 month old. My oldest is about 18 months old, so the problem could be that.

Actual Behavior:
Warning shown: No start activity index found for this FROM date

Media attachement:
Attached 2 screenshots, one from console log and one from fitnesstrend page.

Sync history

To export you history click on "sync button" (top right and corner), then "Backup history". You can zip the file and upload it here.
2018.3.4-14.22_v6.0.1.history.json.zip

@florisvanwoudenberg Seen! Thanks for the report that bug. Indeed your first activity of all time on strava has a date of 2016/11/23.
My code and unit test mark this as failure when a from/to date is unknown in athlete history. Dumb i am !
I will use the date of the first known activity instead in that case ;)
Tom

@florisvanwoudenberg It's fixed !
Once the CI has finished that build (When it's green :))
Could you perform a quick test by using the latest CI build located here: https://bintray.com/thomaschampagne/stravistix/travis-ci-builds/develop#files ?
Reopen if not fixed !
Thanks for your help!
Tom

@florisvanwoudenberg finally wait for this one: https://travis-ci.org/thomaschampagne/stravistix/builds/349006107

HI Thomas,
I tested the new build and can confirm that it works now as expected. Nothing breaks when no activity is available at the beginning of the timeframe.
Thanks!


Fails on Update / Restart

Describe the bug
On loading EDMC today, BGS-Tally notes that an update will be applied on restart. On restart the plugin fails to load
To Reproduce
Steps to reproduce the behavior:

Await autoupdate
When promoted to exit to update / update on restart do so
Start EDCM again
See error

Expected behavior
Update applied with no apparent ill effect / normal operation of EDMC / BGS-Tally
Screenshots

Desktop (please complete the following information):

OS: Win11
Plugin Version 3.4.0 (presumed)
EDMC Version 5.10.1+5419e2e

Additional context
EDMC logs show the issue is potentially related to a datetime parsing issue (paths truncated)
2024-02-10 16:02:03.271 UTC - ERROR - 43044:48716:48716 plug._load_found_plugins:203: Failure loading found Plugin "BGS-Tally-Vanilla"
Traceback (most recent call last):
  File "plug.pyc", line 200, in _load_found_plugins
  File "plug.pyc", line 74, in __init__
  File "EDMarketConnector\plugins\BGS-Tally-Vanilla\load.py", line 21, in plugin_start3
    this.plugin_start(plugin_dir)
  File "EDMarketConnector\plugins\BGS-Tally-Vanilla\bgstally\bgstally.py", line 76, in plugin_start
    self.tick:Tick = Tick(self, True)
                     ^^^^^^^^^^^^^^^^
  File "EDMarketConnector\plugins\BGS-Tally-Vanilla\bgstally\tick.py", line 25, in __init__
    if load: self.load()
             ^^^^^^^^^^^
  File "EDMarketConnector\plugins\BGS-Tally-Vanilla\bgstally\tick.py", line 66, in load
    self.tick_time = datetime.strptime(config.get_str("XTickTime", default=self.tick_time.strftime(DATETIME_FORMAT_ELITEBGS)), DATETIME_FORMAT_ELITEBGS)
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "_strptime.pyc", line 568, in _strptime_datetime
  File "_strptime.pyc", line 349, in _strptime
ValueError: time data '2024-02-10T07:13:12' does not match format '%Y-%m-%dT%H:%M:%S.%fZ'

Btw: Reverting to 3.3.0 works but immediately tries to update on restart

Huh...  That's an internal state variable that hasn't changed in this version (or for years). Somehow it has been set to a different format.
Do you have any other plugins installed in EDMC?

I'll double check in the morning but I haven't added or removed any plugins recently.

Edmccarrier
massacre

Rest are disabled I think. When next at pc I'll disable all and test bgstally clean with no others

Do you have download links for those two plugins?  I'll take a look and see whether either could be using the same XTickTime state.

Huh. Put in a bit of logging and discovered that the tick ID being retreived from the config is 2024-02-10T07:13:12. So not being parsed from another format into this.
To test a theory I put a temporary try-catch around the tick::load method to get the plugin loading with some logging and then forced the tick... now working fine. So overwriting the problematic last time time in config sorted the problem.
I'm not familiar enough with EDMC or Python really but it looks like these settings were persisted somewhere despite me removing all plugin files and deploying latest from the repo's releases list. Can't see any of these settings in config/config.ini though.
Other Plugins For Reference

https://github.com/pudgebrownie/edmc-carrier/
https://github.com/CMDR-WDX/EDMC-Massacres
https://github.com/CMDR-Kiel42/EDMC_SpanshRouter
EDMC Overlay

Yes the XTickTime value is retrieved from EDMC config. On Windows, EDMC stores this in the Windows Registry, so you won't see it in any files on disk.
These Registry keys are unfortunately shared between all EDMC plugins, hence my question about other plugins, because if something else uses the key XTickTime it will overwrite it.  I inherited that key name from Tez's original plugin code, and for more recent config values I've used a more distinct BGST_ prefix instead, to make the BGST keys more globally unique.
I've taken a look through the code for those other three plugins and can't see any references to XTickTime in them, so am still scratching my head as to how that could have got in there with the wrong date format.

Would you like to submit a PR to handle the exception, or if not I'll get a fix done under this issue. Though I think this is a one-off as I haven't had any other problem reports (yet) with 3.4.0.

After a bit of thought... I wonder if this was related to the experimental PR for change of tick detection? Noone else in the sqdn has yet reported the same issue. The tick datetime format was different on the EDCD variant I think which would explain this adjustment between versions.

Ah, gosh yes I forgot you were involved with that PR!  That will definitely be the cause of this problem - BGST assumes a set format for the tick date/time and if it was different then that would explain it.
I've had 500 installs of the new version and no other reports of this problem so yes, I think we can be certain this is the cause.

Yeh its looking that way - sorry for the wild goose chase there.PEBKAK at my end :) ---- On Mon, 12 Feb 2024 13:19:53 +0100  @.***  wrote ----
Ah, gosh yes I forgot you were involved with that PR!  That will definitely be the cause of this problem - BGST assumes a set format for the tick date/time and if it was different then that would explain it.
I've had 500 installs of the new version and no other reports of this problem so yes, I think we can be certain this is the cause.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

Heh, no problem sir!  Closing.


How to install in windows?

^

As long as you can install ghostscript so it's callable with gs, you should be able to install from pip. If you find an easy way of installing it please feel free to add to the documentation. Sorry the code isn't tested on Windows.

Adding gs.bat containing
Start "" "C:\Program Files (x86)\gs\gs9.20\bin\gswin32c.exe" %* to PATH didnt help, even thoigh typing gs in cmd runs it. Here is the error:
Traceback (most recent call last):   File "C:/Users/Niedzwiedz/PycharmProjects/barcodeScanner/main.py", line 8, in <module>     options={},   File "C:\Users\Niedzwiedz\AppData\Local\Programs\Python\Python36-32\lib\site-packages\treepoem\__init__.py", line 123, in generate_barcode     bbox_lines = _get_bbox(code)   File "C:\Users\Niedzwiedz\AppData\Local\Programs\Python\Python36-32\lib\site-packages\treepoem\__init__.py", line 84, in _get_bbox     stderr=subprocess.PIPE,   File "C:\Users\Niedzwiedz\AppData\Local\Programs\Python\Python36-32\lib\subprocess.py", line 707, in __init__     restore_signals, start_new_session)   File "C:\Users\Niedzwiedz\AppData\Local\Programs\Python\Python36-32\lib\subprocess.py", line 990, in _execute_child     startupinfo) FileNotFoundError: [WinError 2] Nie można odnaleźć określonego pliku
Code executed:
`import treepoem
image = treepoem.generate_barcode(
barcode_type='qrcode',  # One of the BWIPP supported codes.
data='barcode payload',
options={},
)
image.save('barcode.png')  # This is an instance of PIL.EpsImagePlugin.EpsImageFile`
Maybe you see something here...

Afraid I don't know enough about windows and paths to debug that. Potentially it has to be called 'gs' instead of 'gs.bat', but I'm just guessing.


make peer connection issue

Hi sepfy,
Recently I just down & try this , & when I run the examples/samples on different 2 clients , only run to the line as snapshoot ,"MQTT_PACKAGE_TYPE_PUBLISH" , and no any more ,has the connection build from peer to peer .
,
and another client's log , run to MQTT_connect successed & pending , pls. let me know how to debug more and what's lack of of this ,thanks.

Hello,
from the first log, could you check your STUN server? looks cannot resolve the host name
For the second one, can you check the device id in your website, looks the device didn't receive the message


Add support for Python 3.10 on CI

Found 1 bug as a result of this PR

Codecov Report

Merging #8524 (f5f61df) into main (9fc3c2e) will decrease coverage by 0%.
The diff coverage is n/a.

:exclamation: Current head f5f61df differs from pull request most recent head de67524. Consider uploading reports for the commit de67524 to get more accurate results

@@          Coverage Diff          @@
##            main   #8524   +/-   ##
=====================================
- Coverage     72%     71%   -1%
=====================================
  Files        378     378
  Lines      23985   23985
  Branches    3692    3692
=====================================
- Hits       17277   17264   -13
- Misses      5216    5229   +13
  Partials    1492    1492

Impacted Files
Coverage Δ

...ience/variablesView/variableViewMessageListener.ts
77% <0%> (-23%)
:arrow_down:

...ent/common/application/webviewViews/webviewView.ts
67% <0%> (-11%)
:arrow_down:

src/client/datascience/dataScienceSurveyBanner.ts
54% <0%> (-9%)
:arrow_down:

...client/datascience/notebook/cellLanguageService.ts
71% <0%> (-5%)
:arrow_down:

...tascience/jupyter/kernels/kernelCommandListener.ts
67% <0%> (-4%)
:arrow_down:

...lient/datascience/variablesView/notebookWatcher.ts
90% <0%> (-3%)
:arrow_down:

src/client/datascience/raw-kernel/rawSocket.ts
82% <0%> (-2%)
:arrow_down:

src/client/datascience/baseJupyterSession.ts
76% <0%> (-1%)
:arrow_down:

.../datascience/editor-integration/codeLensFactory.ts
89% <0%> (+1%)
:arrow_up:

src/client/datascience/webviews/webviewHost.ts
82% <0%> (+1%)
:arrow_up:

... and 4 more


Chart height determination by parent element not working

When chart height is unspecified it defaults to 320px, instead of parent element height.
It seems the reason is because ChartInternal.prototype.getParentHeight returns the height of chart itself. ChartInternal.prototype.getParentWidth on the other hand functions as intended.
https://github.com/c3js/c3/blob/947cd4794916109e33010e98c1dc0665be10c4e8/src/size.js#L75

I put in a PR for this to fix this issue.

The fix has been released as v0.6.11.

I think we can't change this behavior without breaking exsting apps. (See #2567 ) Please use a workaround like chart.resize({ height: parentDom.clientHeight }) for now.

Hi all,
I was wondering if there are plans for another attempt at a fix to avoid the need for a workaround?


pythonPackages.docrep: init at 0.2.3

Motivation for this change
docrep is dependency for package that I would like to build dask-jobqueue.
Things done
pythonPackages.docrep: init at 0.2.3

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[X] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[X] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Fits CONTRIBUTING.md.

Requires myself to be added to maintainers (pull request #44655) list before this pull request

@GrahamcOfBorg eval

@GrahamcOfBorg build python2.pkgs.docrepp python3.pkgs.docrep

Success on aarch64-linux (full log)
Attempted: python3.pkgs.docrep
The following builds were skipped because they don't evaluate on aarch64-linux: python2.pkgs.docrepp
Partial log (click to expand)
Installing collected packages: docrep
Successfully installed docrep-0.2.3
/build/docrep-0.2.3
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/67gsv6vkg2x0m07589h4hqh9pmh0amki-python3.6-docrep-0.2.3
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/67gsv6vkg2x0m07589h4hqh9pmh0amki-python3.6-docrep-0.2.3/lib
patching script interpreter paths in /nix/store/67gsv6vkg2x0m07589h4hqh9pmh0amki-python3.6-docrep-0.2.3
checking for references to /build in /nix/store/67gsv6vkg2x0m07589h4hqh9pmh0amki-python3.6-docrep-0.2.3...
/nix/store/67gsv6vkg2x0m07589h4hqh9pmh0amki-python3.6-docrep-0.2.3

Success on x86_64-linux (full log)
Attempted: python3.pkgs.docrep
The following builds were skipped because they don't evaluate on x86_64-linux: python2.pkgs.docrepp
Partial log (click to expand)
Installing collected packages: docrep
Successfully installed docrep-0.2.3
/build/docrep-0.2.3
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/nxysam5fy2f633d3f17hz8f0gzqnbcc2-python3.6-docrep-0.2.3
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/nxysam5fy2f633d3f17hz8f0gzqnbcc2-python3.6-docrep-0.2.3/lib
patching script interpreter paths in /nix/store/nxysam5fy2f633d3f17hz8f0gzqnbcc2-python3.6-docrep-0.2.3
checking for references to /build in /nix/store/nxysam5fy2f633d3f17hz8f0gzqnbcc2-python3.6-docrep-0.2.3...
/nix/store/nxysam5fy2f633d3f17hz8f0gzqnbcc2-python3.6-docrep-0.2.3

Success on x86_64-linux (full log)
Attempted: python2.pkgs.docrep, python3.pkgs.docrep
Partial log (click to expand)
Successfully installed docrep-0.2.3
/build/docrep-0.2.3
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/nxysam5fy2f633d3f17hz8f0gzqnbcc2-python3.6-docrep-0.2.3
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/nxysam5fy2f633d3f17hz8f0gzqnbcc2-python3.6-docrep-0.2.3/lib
patching script interpreter paths in /nix/store/nxysam5fy2f633d3f17hz8f0gzqnbcc2-python3.6-docrep-0.2.3
checking for references to /build in /nix/store/nxysam5fy2f633d3f17hz8f0gzqnbcc2-python3.6-docrep-0.2.3...
/nix/store/pdr39jxj68jwgqxyij25rz9xzfmqgsgj-python2.7-docrep-0.2.3
/nix/store/nxysam5fy2f633d3f17hz8f0gzqnbcc2-python3.6-docrep-0.2.3

Success on aarch64-linux (full log)
Attempted: python2.pkgs.docrep, python3.pkgs.docrep
Partial log (click to expand)
Successfully installed docrep-0.2.3
/build/docrep-0.2.3
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/qsz0hh16iy9lbbr9235w3nzxa380wxik-python2.7-docrep-0.2.3
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/qsz0hh16iy9lbbr9235w3nzxa380wxik-python2.7-docrep-0.2.3/lib
patching script interpreter paths in /nix/store/qsz0hh16iy9lbbr9235w3nzxa380wxik-python2.7-docrep-0.2.3
checking for references to /build in /nix/store/qsz0hh16iy9lbbr9235w3nzxa380wxik-python2.7-docrep-0.2.3...
/nix/store/qsz0hh16iy9lbbr9235w3nzxa380wxik-python2.7-docrep-0.2.3
/nix/store/67gsv6vkg2x0m07589h4hqh9pmh0amki-python3.6-docrep-0.2.3


Question: awaiting during app exit

I have a one-window application using WinUI 3 with the WindowsAppSDK. In OnLaunched I create a Window, assign content to Window.Content, hook up the Close event, and call Window.Activate(). It all works fine. When the window is closed I receive the Close event on the UI thread. When the close event handler exits (with args.Handed = false), the app exits.
My question is, how can I await a cleanup task before the app exits? Say I create a cleanupTask for the cleanup work -- writing a file, for example. If I make the close handler async void and use await cleanupTask then the handler returns when it hits the await and the app exits before the task completes. On the other hand if I use cleanupTask.Wait() then it frequently deadlocks because at the time the Close was triggered by the user there were (or could be) various UI tasks being awaited within the app, any one of which may attempt to re-aquire the UI thread while the close handler is doing a Wait on the UI thread.
Is there some standard way of doing this?
Edit: what I am currently doing is cancelling the close by setting args.Handled = true, and then starting a task that awaits the cleanup and then closes the window. Since the "close" button is still accessible to the user during the cleanup, this means resetting the close event handler to do nothing but ignore intervening close requests, then resetting it again when the cleanup is done and we are actually ready to close. It's a bit of a pain and also one has to replace the rest of the UI so that the user doesn't do anything while the cleanup is in progress.  There should be an easier way --

@bpulliam FYI


white space

preview
when i more scroll down and fast scroll to top before collapsing header and recycle have space, how to fix it pleace help

facing the same issue
did you find and solution...

I think that when there are more elements, and the viewpager material can not calculate the height for each element

ok thanx for the reply
if you find any workaround please post it
thanx

okay


Pull Request for Issue #377

Based on @nenonix recommendation, created a PR for each Issue, this PR solved the issues #377 , In the committed Update-Office-365-Ip-Webservices (Issue #377) I only add a paragraph for the reworked script requested

@nenonix @JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks.

@mypil  I must deleted the file hybrid-modern-auth-overview.md because is not part of the PR, please take in account for the review and merge, only the changes to the file Update Office-365-Ip-Webservices (issue #377), Review and merge based on this !

@kelleyvice-msft - Can you please assist to check, approve and merge the content for this PR based on issue #377?
Thank you.

@kelleyvice-msft - We would like to follow up on this. Can you please assist to check, approve and merge the content for this PR based on issue #377?
Thank you.

This has conflicting edits to the same files as issue #392. Both PRs have conflicts. This PR has updates to hybrid-modern-auth-overview.md, while #392 deletes this file. I'm trying to sort out the best way to handle this before I merge either PR.

@kelleyvice-msft - Should we just let @ojrb close the 2 conflicting PRs and create just one PR which would cover the feedback from the 2 issues that talks about the same article?

@ojrb - Please proceed to close this PR and #392 then just create one PR which would address the feeback of the 2 issues for the same file/article. Thank you.


Minor docs fixes

Pull Request Test Coverage Report for Build 260e934ea8d6ee6ef00fe27b1d3136c7a2db1879-PR-1071

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 65.977%

Totals

Change from base Build 73393daf493203397e0ff353722a17f1cce3b8c4:
0.0%

Covered Lines:
1148

Relevant Lines:
1740

💛  - Coveralls


[VS Code] Please open a folder or workspace to share.

What is the specific issues you were experiencing?

It looked like an error but the issue was I needed to open a folder not just a file before I could share.
HEATH HODGERT Mobile Architect
971.255.4636 [d]    |<PHONE_NUMBER> [c]
From: Dominic Hopton<EMAIL_ADDRESS>Reply-To: MicrosoftDocs/live-share<EMAIL_ADDRESS>Date: Thursday, May 10, 2018 at 3:45 PM
To: MicrosoftDocs/live-share<EMAIL_ADDRESS>Cc: Heath Hodgert<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/live-share] [VS Code] Please open a folder or workspace to share. (#353)
What is the specific issues you were experiencing?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Flive-share%2Fissues%2F353%23issuecomment-388208271&data=02|01|heath.hodgert%40viewpoint.com|01dc7a4cc6334a08ae0d08d5b6c7b813|e04ac16841d04093bba326b197f141e1|0|0|636615891258432620&sdata=OynenHvy1HFL39UMZPcU839I24NRZNPtDF0IIdfn6rc%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALS0ZXG2F1D8Y_ak-yZB_Wby_2AYqBSMks5txMMDgaJpZM4T6XCS&data=02|01|heath.hodgert%40viewpoint.com|01dc7a4cc6334a08ae0d08d5b6c7b813|e04ac16841d04093bba326b197f141e1|0|0|636615891258432620&sdata=g%2FU%2Fk64WeWOimelUljTKr10J88lEKyd60mTEZRB0%2B%2FM%3D&reserved=0.

@heathhodgert Glad you were unblocked.  Live Share does not support sharing single files currently.  What would be awesome is if you'd up vote #54 which is a feature request to add in this support.  I'll close this issue in favor of this other one.


Add testing for GraphQL Mutation Types

This PR adds testing to verify metrics and span attributes for GraphQL mutations.

LGTM 🚀


fix cannot get RDS after grpc reconnect

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix cannot get RDS after grpc reconnect
after grpc reconnect,we did not clear the cache, and we forget to compare lastNonce in RDS,  so the judgment logic in the subsequent process believes that RDS does not need to be updated.
Which issue(s) this PR fixes:
Fixes #964
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Please fix the ut, then will approve


How to disable right click???

So, I know webwindow runs on the webview2 API that comes with the new Edge Chromium.
Would there be a way to completely disable the browser right click that opens the browser options?
It isn't really convenient for someone who is trying to make browser design look native

So I found out that to do this u need to update the WebView2 to the new version (0.9.430) and update the methods name in c++ .
Working on it at the moment.

You need this code on js side
window.οncοntextmenu=function(){return false;}

thanks, it worked for me although i did it in a different way
<body oncontextmenu="return false;">
anyway thanks @jinqi166


docs: Fix markdown

Resolve issues in the markdown files in this repo.
Fixes #433.
Signed-off-by: James O. D. Hunt<EMAIL_ADDRESS>

Ugh. Anyone know what this URL needs to change to?
INFO: Checking all document URLs

ERROR: Invalid URL 'https://run.conduit.io/install' found in the following files:

svc-mesh/service-mesh.md

@jodh-intel - looks like it changed name - I suspect maybe https://linkerd.io/2/getting-started/ but /cc @amshinde @mcastelino

@grahamwhaley correct. Looks like it got merged into linkerd project. So the url should now be "https://run.linkerd.io/install". We also need to rename all instances of conduit in that doc to linkerd.

Thanks @amshinde - doc updated. Note that the https://raw.githubusercontent.com/runconduit/conduit-examples/master/emojivoto/emojivoto.yml URL is still valid and there appears to be no linkerd equivalent.
Since I've only done a search'n'replace, I'd appreciate it if a conduit/linkerd person could sanity-check this!

Ping y'all!
/test

/retest

Good catches @chavafg! :smile:

Well, I'm happy that we land this asap as it's better than what we have currently! :smile:
But I can't ack as it's my PR :)
Restarted Travis which seems to have had a "wobble" as the error is incorrect fwics:
INFO: Checking all document URLs
ERROR: Invalid URL 'https://api.github.com/repos/intel/ovmf-virt/releases/latest' found in the following files:
how-to/how-to-use-kata-containers-with-nemu.md

Travis has now been disabused.

Rocking - thanks @chavafg!


fix(deps): update terraform terraform-ibm-modules/kms-all-inclusive/ibm to v4.15.12

This PR contains the following updates:

Package
Type
Update
Change

terraform-ibm-modules/kms-all-inclusive/ibm (source)
module
patch
4.15.11 -> 4.15.12

Release Notes

terraform-ibm-modules/terraform-ibm-kms-all-inclusive (terraform-ibm-modules/kms-all-inclusive/ibm)
v4.15.12
Compare Source
Bug Fixes

deps: update terraform ibm to latest for the deployable architecture solution (#546) (23941aa)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

:tada: This PR is included in version 3.17.8 :tada:
The release is available on:

GitHub release
v3.17.8

Your semantic-release bot :package::rocket:


Gitea should send tag webhook at release creation on UI

Gitea version (or commit ref): 1.7.1
Git version:
Operating system: CentOS 7
Database (use [x]):

[X] PostgreSQL
[ ] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[ ] No
[X] Not relevant

Log gist:

Description
If a release is created from the UI, gitea should send a tag webhook to trigger some CI Systems.

Look also https://github.com/go-gitea/gitea/issues/5288

Any ideas or workarounds? I can look into it if this does not require a big change.
I think this is useful. My goal is to have the non-devs in my department (like QA/PM and alike) can create the releases autonomously via the web interface.

@techknowlogick any chance to get this into gitea?

@typeless workaround is to create a tag in your local clone and push the tag to gitea. But it's a bit messy :)

@xoxys
Hi, I would like to fix this issue by sending a Push Event Hook when release created.
As I know, there is a func createTag in services\release\release.go, add a webhook event here seems to be a good idea.
However, as mentioned at #5288, Gitea already sends Release Event Hook. Not sure if there is any concern to send an extra webhook event.
I need some suggestions before push my codes.
Below is my draft codes (not finished yet):
func createTag(gitRepo *git.Repository, rel *models.Release) error {
  // Only actual create when publish.
  if !rel.IsDraft {
    if !gitRepo.IsTagExist(rel.TagName) {
      commit, err := gitRepo.GetCommit(rel.Target)
      if err != nil {
        return fmt.Errorf("GetCommit: %v", err)
      }

      // Trim '--' prefix to prevent command line argument vulnerability.
      rel.TagName = strings.TrimPrefix(rel.TagName, "--")
      if err = gitRepo.CreateTag(rel.TagName, commit.ID.String()); err != nil {
        if strings.Contains(err.Error(), "is not a valid tag name") {
          return models.ErrInvalidTagName{
            TagName: rel.TagName,
          }
        }
        return err
      }
      rel.LowerTagName = strings.ToLower(rel.TagName)

      // Prepare Webhook
      if err := rel.LoadAttributes(); err != nil {
        log.Error("LoadAttributes: %v", err)
      } else {
        var shaSum string
        mode, _ := models.AccessLevel(rel.Publisher, rel.Repo)
        apiRepo := rel.Repo.APIFormat(mode)
        apiPusher := rel.Publisher.APIFormat()
        shaSum, err = gitRepo.GetTagCommitID(rel.TagName)
        if err != nil {
          log.Error("GetTagCommitID[%s]: %v", rel.TagName, err)
        }
        if err = models.PrepareWebhooks(rel.Repo, models.HookEventPush, &api.CreatePayload{
          Ref:     git.TagPrefix + rel.TagName,
          Sha:     shaSum,
          RefType: "tag",
          Repo:    apiRepo,
          Sender:  apiPusher,
        }); err != nil {
          log.Error("PrepareWebhooks: %v", err)
        } else {
          go models.HookQueue.Add(rel.Repo.ID)
        }
      }
    }
    commit, err := gitRepo.GetTagCommit(rel.TagName)
    if err != nil {
      return fmt.Errorf("GetTagCommit: %v", err)
    }

    rel.Sha1 = commit.ID.String()
    rel.CreatedUnix = timeutil.TimeStamp(commit.Author.When.Unix())
    rel.NumCommits, err = commit.CommitsCount()
    if err != nil {
      return fmt.Errorf("CommitsCount: %v", err)
    }
  } else {
    rel.CreatedUnix = timeutil.TimeStampNow()
  }
  return nil
}

@blueworrybear sending a push event in case a release was created is not the right solution. As mentinoned in the first post, a tag event is needed

@xoxys
Thanks for your feedback. I had read the first post and understand that creating tag event is needed.
But drone seems to handle tag event during somebody pushed a new tag.
It seems to me that it makes sense if we treat the release creation as someone creates a tag,  push it to the remote and update the Gitea page.
In fact, publishing a tag indeed requires push. Therefore sending a push event in the same time seems to be okay.
I think send a tag create and push tag event in the same time is not a big deal. I'll update my code to do so.


Registry credentials not functioning

v0.20.1
Steps:

Create a registry using Quay.io and enter valid username and password
Try to create a container using quay.io/rancher/authorized

Results:
Container won't create, says I don't have permission
Expected:
Container should create

v0.20.2
Verified fixed


Migrate current ipfs blocks (profile data) from backup to shared data layer.

We should be able to implement a migration function that takes the data from our backup and writes it to our new store. We could also get the same effect a level up by just simulating users/opening stores on both our pinning node and the new one. Both are probably similar amounts of work, but the first we can get a bit better guarantees. This store is the first attempt at do this, will still need more validation and testing stories in the future before actually moving over.
For this one, the new store and backup may be very similar, making migration simple.

Ok much simpler than expected, mapping fs on pinning node to s3 bucket is very simple.
example:
 aws s3 jsipfs s3://our-ipfs-bucket/jsipfs

I think is an option to also only copy files that don't exist in s3, will add here after.
Had originally thought about more general solution of mapping one js ipfs repo instance to another. But this entirely sufficient for our use case. Was already able to transfer our ipfs data to a s3 bucket and run another node with that bucket.

Oh, that really sweet!


Install pyright and provision the nodeenv in one go

How can I install pyright and have the install provision the nodeenv simultaneously?

Hey @hholst80, there isn't a "built-in" way to do this but you can run pip install pyright && pyright --help to ensure the nodeenv is cached.

That's exactly what I am doing in the docker build right now. If that's the recommended way, all good.

Yeah, sorry this isn't documented! I'll re-open this to track docs.


multiple-gpu case

@HongguLiu
have you tested your training code with multiple gpu? I got the RuntimeError: NCCL Error 2: unhandled system error. One gpu case is fine for me. Thanks.

We usually train our model with multiple gpu. And this code is support of training with multiple gpu.


CI caching is not working

Caching states that it's finds an exact key match, and loads the cache, but then requires 10 minutes to run Clippy, suggesting that the cache isn't working.
Here's an example:
https://github.com/PRQL/prql/actions/runs/4289142805/jobs/7472228523
  Cache Key:
      v0-rust-test-8c56ab4dfbfcd813a0470329fa58be407810fe57-794ab014af7a25596080ed20be142dbaa0f4b93c

...

Restored from cache key "v0-rust-test-8c56ab4dfbfcd813a0470329fa58be407810fe57-794ab014af7a25596080ed20be142dbaa0f4b93c".

But then when we need it:
   ...
   Compiling rustler_codegen v0.27.0
   ...

This started in the past day or so. I definitely don't think it's caused by the Chumsky merge, but may be correlated in some way.
Without caching, builds take >5x as long, and a queue would likely form that would exacerbate this, so it's quite important we solve it.
I'll have a look soon.

Initially findings:

I don't think it's our code.
Here's a run yesterday which loaded a 1460 MB cache https://github.com/PRQL/prql/actions/runs/4276246907/jobs/7444198258, and was successful in compiling quickly
Here's the same commit re-run just now, which loads a 308 MB cache, and required a complete recompilation https://github.com/PRQL/prql/actions/runs/4276246907/jobs/7472559056

Between the two runs, the cache entry was evicted, possibly because we've been doing lots of changes to the dependencies, and don't have space for more than a couple of versions. So another cache was built since yesterday and, for some reason, didn't cache the full dependencies.
I say it's unlikely to be our code because between the cache key remaining the same means that no files that we'd expect to impact our caching (e.g. Cargo.toml) could have been changed. It is possible that something outside that set of files impacts caching though.
I'll open an issue on Swatinem/rust-cache and see if others are getting this.

OK so I think this might have been a temporary lapse somewhere, but it's now working:

I wiped that cache entry
I re-ran that job, it built and pushed the cache
I re-ran again, and it seems to have worked: https://github.com/PRQL/prql/actions/runs/4276246907/jobs/7472879809

So I'll close this and reopen if it reappears.


patch istio to support multi ns deploy & query prefix match

Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #280 (80972e0) into main (96e7153) will decrease coverage by 0.09%.
The diff coverage is n/a.

:exclamation: Current head 80972e0 differs from pull request most recent head d194d95. Consider uploading reports for the commit d194d95 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #280      +/-   ##
==========================================
- Coverage   42.07%   41.99%   -0.09%
==========================================
  Files          44       44
  Lines        5787     5796       +9
==========================================
- Hits         2435     2434       -1
- Misses       3180     3191      +11
+ Partials      172      171       -1

see 3 files with indirect coverage changes


Multiple results returned for each timestamp in a group-by

Steps to reproduce:
On data with a schema like: m0,tenant_id=a,env=a total_count=5
Run a query like: SELECT SUM(ncount) as scount FROM (SELECT NON_NEGATIVE_DIFFERENCE(total_count) as ncount FROM m0 AND t='tb' GROUP BY env) GROUP BY time(1d)
Expected behavior:
There should be a single row for each day
Actual behavior:
There are multiple rows for each day.

This is newly present in 1.9 (both open-source and Enterprise). It is due to an incorrect optimization added for 1.9, the fix will be to revert that change.

The important features of the query to hit the bug:

The inner group-by needs to both select and filter, and the select + filter probably need to cover the whole tag set
The inner group-by needs a function call (like non_negative_differnence) that requires ordered output
The outer aggregation should by a looser group-by than the inner one.


consider Object.freeze on manifest/flags/transportUrl/transportName

solved in https://github.com/Stremio/stremio-addon-client/commit/650be1b565f50a7e054963f50123758a6a4364ef


Add support for add_headers

Add support for add_headers globally. Uses similar pattern as custom proxy headers in https://github.com/kubernetes/ingress/pull/246 .
Could be taken further by adding support for annotations and adding this per location, but global is what our usecase needs right now

This change is

CLA signed

CLA signed by having trouble linking it to GH, lets see if it worked now

Coverage decreased (-0.1%) to 46.994% when pulling 551410a8cce4f8c0a05a83aae5d42afd664dbf83 on n1koo:add_headers_support into b7bf78379c4fd696aab2da4a6ca19d5f571a277f on kubernetes:master.

@aledbf any opinions?
@n1koo can you see if you can get the CLA sorted out?
we're looking forward to this too 👍

@JonPulsifer this PR needs a rebase

Sorry about that, totally forgot this PR altogether. Rebased and CLA happy now :)

Coverage decreased (-0.06%) to 44.323% when pulling 02832dec6c32346229b2e2e7c350d64b7607c885 on n1koo:add_headers_support into c1e7c7a29015ff1b4d3fae576201dc4e339f4221 on kubernetes:master.

/lgtm

@n1koo thanks!


HACS Integration

Would it be possible to update the repo to allow installation through HACS?

It may be possible - I haven't done any development for HACS yet and I'm not sure if they have the same kinds of stringent requirements that HA core has, but I'll look into it.

Closed by https://github.com/jlamendo/ha-sensor.owlet/pull/3 - thanks for the suggestion. Readme has been updated with a new HACS install option.

Amazing work! Thank you!

On 21 Nov 2020, at 23:12, Jonathan Lamendola<EMAIL_ADDRESS>wrote:

Closed by #3 - thanks for the suggestion. Readme has been updated with a new HACS install option.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


Remove "enableCreateFromFile" property from Geomark tool config

As we are removing the "Load File" button and functionality in SMK (https://github.com/bcgov/smk/issues/162), we no longer need the ability to create or configure the "enableCreateFromFile" property of the Geomark tool.

This was implemented in pull request https://github.com/bcgov/smk-cli/pull/83.


⚠ Processors has degraded performance

In ac36463, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 87 ms

Resolved: Processors performance has improved in 2147ecd.


uro error

cat urls.txt | uro > test
Traceback (most recent call last):
File "/usr/local/bin/uro", line 8, in
sys.exit(main())
File "/usr/local/lib/python3.10/dist-packages/uro/uro.py", line 123, in main
for line in sys.stdin:
File "/usr/lib/python3.10/codecs.py", line 322, in decode
(result, consumed) = self._buffer_decode(data, self.errors, final)
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xff in position 0: invalid start byte
@s0md3v

Use this github.com/Karthik-HR0/uro

cat urls.txt | uro > test
Traceback (most recent call last):
File "/usr/local/bin/uro", line 8, in
sys.exit(main())
File "/usr/local/lib/python3.10/dist-packages/uro/uro.py", line 123, in main
for line in sys.stdin:
File "/usr/lib/python3.10/codecs.py", line 322, in decode
(result, consumed) = self._buffer_decode(data, self.errors, final)
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xff in position 0: invalid start byte
@s0md3v

Use this tool GitHub.com/Karthik-HR0/uro

This issue has been fixed in latest release (v1.0.1).


Individual periods for experiment steps

Summary
The period argument of pybamm.Experiment controls the frequency with which data is recorded. This argument is currently a single value, applied to every step of the experiment. It would be useful to be able to set different periods for individual experiment steps.
Motivation
When running an experiment where the current-step response is of interest, e.g. GITT or HPPC, it is necessary to set period to a very small value (<< 1 s) in order to capture transient effects close to the current step. Such a small period is not warranted further away from the current step, and only serves to inflate the size of the recorded data.
Using very small periods results in prohibitively large output data for longer experiments (multiple GB, all of which must be loaded into RAM when plotting).
Additional context
A comparison of a GITT pulse with period="0.01 seconds" and period="1 minute" (the default value).

In this example, it would be useful to be able to split the second and third steps into smaller steps with different periods. The periods would be smaller immediately after each current step, and get increasingly larger further away from the steps.

You can define custom periods for each step by adding (30 second period) at the end of your step statement. If you want different periods in the same step, you can define two identical steps with different period. For example:
experiment = pybamm.Experiment(
    (
        "Discharge at 2C until 2.5 V (30 second period)",
        "Rest for 15 minutes (30 second period)",
        "Rest for 105 minutes (5 minutes period)",
    )
)

does a 2 hour rest after discharge, but the first 15 minutes are sampled every 30 seconds to capture the transient effects, while the remaining 105 minutes are sampled at a much longer period. Does this help?

Absolutely, that's exactly what I want to do. Thank you!


Backdrop APIs in 1.3 still require the window to have some content

Seems like for the new XAML Backdrop APIs to work you have to have both a xaml and a xaml.cs file?
Just doing it like this crashes the application with code<PHONE_NUMBER> (0xc000027b):
public partial class App : Application
{
  public App()
  {
    this.InitializeComponent();
  }

  protected override void OnLaunched(Microsoft.UI.Xaml.LaunchActivatedEventArgs args)
  {
    m_window = new Window();
    m_window.SystemBackdrop = new DesktopAcrylicBackdrop();
    m_window.Activate();
  }

  private Window m_window;
}

Originally posted by @Balkoth in https://github.com/microsoft/WindowsAppSDK/discussions/3406#discussioncomment-4955796

The fix for this issue is in 1.3.1 that is now available.

1.3.1 = 1.3.230502000 (built May 2, 2023)


java.util.NoSuchElementException

java.util.NoSuchElementException
at com.squareup.okhttp.internal.http.RouteSelector.next(RouteSelector.java:79)
at com.squareup.okhttp.internal.http.StreamAllocation.findConnection(StreamAllocation.java:164)
at com.squareup.okhttp.internal.http.StreamAllocation.findHealthyConnection(StreamAllocation.java:126)
at com.squareup.okhttp.internal.http.StreamAllocation.newStream(StreamAllocation.java:95)
at com.squareup.okhttp.internal.http.HttpEngine.connect(HttpEngine.java:283)
at com.squareup.okhttp.internal.http.HttpEngine.sendRequest(HttpEngine.java:224)
at com.squareup.okhttp.Call.getResponse(Call.java:286)
at com.squareup.okhttp.Call$ApplicationInterceptorChain.proceed(Call.java:243)
at com.squareup.okhttp.Call.getResponseWithInterceptorChain(Call.java:205)
at com.squareup.okhttp.Call.access$100(Call.java:35)
at com.squareup.okhttp.Call$AsyncCall.execute(Call.java:171)
at com.squareup.okhttp.internal.NamedRunnable.run(NamedRunnable.java:33)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
at java.lang.Thread.run(Thread.java:818)
Can you help me to find why it is happened?
Thanks!

Two possibilities:

OkHttp has a bug where we’re attempting to recover when we shouldn't be because we’ve exhausted all of the available routes.
OkHttp has a bug where you’ve got a custom DNS implementation that returned zero IP addresses for a host and we didn't reject that.

Please try OkHttp 2.7.1 which has a targeted fix for this problem.

Please try OkHttp 2.7.1 which has a targeted fix for this problem.

I believe we have this fixed with 2.7.1. Will reopen if that fix wasn't sufficient.

I believe we have this fixed with 2.7.1. Will reopen if that fix wasn't sufficient.

2.6 is Ok, I will try 2.7.1 later, thanks very much! Merry Christmas！


Fix typo in "non-existent"

We were spelling "non-existent" as "non-existant", which is incorrect.

Thanks @timblair.  I've also updated the ADR in case anyone is grepping specifically for this word.


Feature: Plannings - allow to delete a planning

Is your feature request related to a problem? Please describe.
Actually, it is not possible to delete a planning.
Describe the solution you'd like
Add a deletion button in the planning view (as for devices).
Describe alternatives you've considered
N/A
Additional context
N/A

The scedule must be deleted too
The planning in the layer must be deleted when the planning is deleted
The list of layers in the planning's screen should indicate if it's already linked to another planning