1229 support autofocus on picker

Closes #1229
✅ Pull Request Checklist:

[ ] Included link to corresponding React Spectrum GitHub Issue.
[ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
[ ] Filled out test instructions.
[ ] Updated documentation (if it already exists for this component).
[ ] Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

I'm not sure I'm allowed to change existing APIs like useSelect - I've also altered the logic to update the focus-State of the widget (I looked at ComboBox and how it is done there I hope that is the right way)

In the latest changeset I aligned the properties-inheritence to the other controls like TextField

So while testing all that I came across something I have no idea how to fix. It can be reproduced like this:

Open the popup
Hit Tab (or SHIFT-Tab, or Click somewhere)
Move the focus back to the control

You'll notice the following:

we did not get any blur event when the focus moved to the other control (and we don't update the focus-state)
because of the above we don't get a focus-event when we moved back the focus

My guess is that from the browsers point of view the control is not the one who owns the focus hence it does not have to generate an onBlur-FocusEvent. I then checked ComboBox and there it works appropriately but I could not find the reason for that (triggered by useFocus)

so I think I found the reason: ComboBox creates the ListBoxBase with shouldUseVirtualFocus but just using that in the select would require more changes.

@tomsontom So the ComboBox behaves a bit differently from the Picker. When the Picker is opened, focus actually moves away from the button and into the dropdown menu hence the lack of a onBlur call when you tab away from the opened menu (e.g. onBlur listener is attached to the button). For the ComboBox, focus never actually leaves the input, and the highlight that you see on the items from keyboard interactions is the so called "virtual" focus (the "focused item" is tracked internally and focus style applied appropriately). So when you open the ComboBox menu and then "Tab" away, onBlur is called because focus was still on the input.
IMO I think we shouldn't adopt the virtual focus model here with the Picker, perhaps we could attach a separate onBlur handler on the menu props here in useSelect? Something like the following?
      ...menuProps,
      onBlur: (e) => {
        if (props.onBlur) {
          props.onBlur(e);
        }

        state.setFocused(false)
      }

Perhaps it would be odd to receive a e.target that references the menu item instead of the button though, a possible argument for switching to a virtual focus model. Lemme know your thoughts, I'll bring this up with the team

@LFDanLu - I would not mind the different target but that leads to a blur as well when I:

click the picker (list opens)
click the picker (list closes)
which is something that should not happen and if it happens it should be followed immediately by a new focus-event. The native new focus event is there but because the state.isFocused is not YET switched (it would be in the next frame) the outside observer does not receive an event.

Coming back to my initial request, would it make sense to do the whole thing in 2 steps:

step 1: introduce "autofocus"-Property directly on picker (instead of inheriting)
step 2: implement the full focus-story

Yeah, I think that's a good idea!

Btw, to handle this more correctly, I think you'd have to fire onBlur when the menu closes, if focus moved somewhere other than the button.

that's what I tried to implement using the onBlur as suggested by @LFDanLu but that just brought me to what I describe in my comment above - where from do I know that that focus has:

move back to the button (don't send any blur)
moved somewhere else (send a blur)

@tomsontom maybe the onBlur could have another check where the e.relatedTarget is compared to ref.current (aka the trigger button) and if they are the same then don't call props.onBlur. Unfortunately navigating up/down the picker menu via the arrow keys is triggering the onBlur still, not sure why...
Yeah, probably best to add autoFocus directly to Picker for now...

oh well the up/down is something one can fix as well - it is done in combobox as well (see the onBlur in useComboBox) - I just have to reintroduce passing the popoverReference

@LFDanLu so it's working - why I haven't thought about e.relatedTarget myself is a mystery - I'll go and try to enhance the test-suite to check the usecases but from manual testing this now looks good to me.

@devongovett @LFDanLu it's your turn now to decide if you feel we are getting close or I should follow up with the 2 step approach - I would then leave the PR open and create a new onw just introducing the property.

Is there a timeframe one of you can review or send me towards implementing the simple autofocus path?

@tomsontom Sorry about the delay, discussed this with the team and for now it would be best to do the simple autofocus path.

@LFDanLu done as #1330

I added some tests, hoping they'll help in the team's discussion, sorry for the delay


feat: intersect StandardTx type with chain-adapters Transaction

Description
WIP - This adds the fields from chain-adapters Transaction type to unchained-clientStandardTx, to be able to eventually consolidate them and remove the chain-adapters ones.
Note that for now, there is some amount of duplication (e.g chain and chainId, tradeDetails and trade until this is consolidated)
Needed to unrug https://github.com/shapeshift/web/pull/2257
Issue

contributes to https://github.com/shapeshift/web/issues/2279
contributes to the already closed https://github.com/shapeshift/lib/issues/658

Current dependencies on/for this PR:

main

PR #936   👈

This comment was auto-generated by Graphite.

Closing as superseeded by https://github.com/shapeshift/lib/pull/944


Unable to return TXT records

Describe the bug
When querying TXT records, some domains do not return any data.
Steampipe version (steampipe -v)
steampipe version 0.18.1
Plugin version (steampipe plugin list)

Installed Plugin
Version
Connections

hub.steampipe.io/plugins/turbot/aws@latest
0.92.1
aws

hub.steampipe.io/plugins/turbot/crowdstrike@latest
0.1.0
crowdstrike

hub.steampipe.io/plugins/turbot/csv@latest
0.5.0

hub.steampipe.io/plugins/turbot/jira@latest
0.8.0
jira

hub.steampipe.io/plugins/turbot/net@latest
0.8.1
net

hub.steampipe.io/plugins/turbot/okta@latest
0.8.0
okta

hub.steampipe.io/plugins/turbot/salesforce@latest
0.2.0
salesforce

To reproduce
Steps to reproduce the behavior (please include relevant code and/or commands).
Run the following query in Steampipe
select
  value,
  ttl
from
  net_dns_record
where
  domain = 'github.com'
  and type = 'TXT' and dns_server = '<IP_ADDRESS>';

Expected behavior
Expecting the result to be similar to nslookup -query=txt github.com <IP_ADDRESS>, however no data is being returned.
Additional context
While running the same query on my private domain massyn.net, the result is being returned as expected.  It would appear that there may be some characters or text in the output result of the DNS query that is causing the plugin to drop it.

Thanks for raising this issue @massyn 👍.
Relevant slack thread - https://steampipe.slack.com/archives/C01UECB59A7/p1674631153271819

Hi @misraved - what is the expected ETA on having this issue resolved?  Just curious as to how long I need to be operating my workaround script while steampipe has this bug.

I'm sorry for the delayed response @massyn, we have successfully managed to reproduce the issue, but the details leading up to it is a bit sparse.
For instance, @Subhajit97 is able to successfully query the TXT records with one of his internet providers however I am facing a similar issue as you are. When he switched to a different internet provider, however, he could not query the TXT records for google.com and github.com.
We managed to query the TXT records for steampipe.io and facebook.com successfully but the results don't seem promising for google.com and github.com. We are looking to nail down the root cause of this issue, and hopefully, towards the end of this week, we will have a solution in place.
Thank you once again for your patience and for providing such detailed insight into the issue.

@massyn I believe the incomplete results are due to truncated results, as the response for GitHub's DNS records is greater than 512 bytes. This results in some records being returned when not specifically looking for TXT records:
> select
  *
from
  net_dns_record
where
  domain = 'github.com' and
  dns_server = '<IP_ADDRESS>';
+------------+------+------------+--------------+--------------------------+----------+-----------+----------------+------+------------+---------+---------+--------+---------+---------------------------+
| domain     | type | dns_server | ip           | target                   | priority | tag       | value          | ttl  | serial     | minimum | refresh | retry  | expire  | _ctx                      |
+------------+------+------------+--------------+--------------------------+----------+-----------+----------------+------+------------+---------+---------+--------+---------+---------------------------+
| github.com | A    | <IP_ADDRESS>    | <IP_ADDRESS> | <null>                   | <null>   | <null>    | <null>         | 60   | <null>     | <null>  | <null>  | <null> | <null>  | {"connection_name":"net"} |
| github.com | CAA  | <IP_ADDRESS>    | <null>       | <null>                   | <null>   | issue     | digicert.com   | 3590 | <null>     | <null>  | <null>  | <null> | <null>  | {"connection_name":"net"} |
| github.com | CAA  | <IP_ADDRESS>    | <null>       | <null>                   | <null>   | issuewild | digicert.com   | 3590 | <null>     | <null>  | <null>  | <null> | <null>  | {"connection_name":"net"} |
| github.com | CAA  | <IP_ADDRESS>    | <null>       | <null>                   | <null>   | issue     | globalsign.com | 3590 | <null>     | <null>  | <null>  | <null> | <null>  | {"connection_name":"net"} |
| github.com | MX   | <IP_ADDRESS>    | <null>       | alt2.aspmx.l.google.com. | 5        | <null>    | <null>         | 2245 | <null>     | <null>  | <null>  | <null> | <null>  | {"connection_name":"net"} |
| github.com | MX   | <IP_ADDRESS>    | <null>       | alt3.aspmx.l.google.com. | 10       | <null>    | <null>         | 2245 | <null>     | <null>  | <null>  | <null> | <null>  | {"connection_name":"net"} |
| github.com | MX   | <IP_ADDRESS>    | <null>       | alt4.aspmx.l.google.com. | 10       | <null>    | <null>         | 2245 | <null>     | <null>  | <null>  | <null> | <null>  | {"connection_name":"net"} |
| github.com | MX   | <IP_ADDRESS>    | <null>       | aspmx.l.google.com.      | 1        | <null>    | <null>         | 2245 | <null>     | <null>  | <null>  | <null> | <null>  | {"connection_name":"net"} |
| github.com | MX   | <IP_ADDRESS>    | <null>       | alt1.aspmx.l.google.com. | 5        | <null>    | <null>         | 2245 | <null>     | <null>  | <null>  | <null> | <null>  | {"connection_name":"net"} |
| github.com | NS   | <IP_ADDRESS>    | <null>       | ns-520.awsdns-01.net.    | <null>   | <null>    | <null>         | 2306 | <null>     | <null>  | <null>  | <null> | <null>  | {"connection_name":"net"} |
| github.com | NS   | <IP_ADDRESS>    | <null>       | dns4.p08.nsone.net.      | <null>   | <null>    | <null>         | 2306 | <null>     | <null>  | <null>  | <null> | <null>  | {"connection_name":"net"} |
| github.com | NS   | <IP_ADDRESS>    | <null>       | ns-1283.awsdns-32.org.   | <null>   | <null>    | <null>         | 2306 | <null>     | <null>  | <null>  | <null> | <null>  | {"connection_name":"net"} |
| github.com | NS   | <IP_ADDRESS>    | <null>       | dns1.p08.nsone.net.      | <null>   | <null>    | <null>         | 2306 | <null>     | <null>  | <null>  | <null> | <null>  | {"connection_name":"net"} |
| github.com | NS   | <IP_ADDRESS>    | <null>       | ns-1707.awsdns-21.co.uk. | <null>   | <null>    | <null>         | 2306 | <null>     | <null>  | <null>  | <null> | <null>  | {"connection_name":"net"} |
| github.com | NS   | <IP_ADDRESS>    | <null>       | dns2.p08.nsone.net.      | <null>   | <null>    | <null>         | 2306 | <null>     | <null>  | <null>  | <null> | <null>  | {"connection_name":"net"} |
| github.com | NS   | <IP_ADDRESS>    | <null>       | ns-421.awsdns-52.com.    | <null>   | <null>    | <null>         | 2306 | <null>     | <null>  | <null>  | <null> | <null>  | {"connection_name":"net"} |
| github.com | NS   | <IP_ADDRESS>    | <null>       | dns3.p08.nsone.net.      | <null>   | <null>    | <null>         | 2306 | <null>     | <null>  | <null>  | <null> | <null>  | {"connection_name":"net"} |
| github.com | SOA  | <IP_ADDRESS>    | <null>       | dns1.p08.nsone.net.      | <null>   | <null>    | <null>         | 3236 |<PHONE_NUMBER> | 3600    | 43200   | 7200   | 1209600 | {"connection_name":"net"} |
+------------+------+------------+--------------+--------------------------+----------+-----------+----------------+------+------------+---------+---------+--------+---------+---------------------------+

As an experiment, I increased the buffer size to 4096 with EDNS in https://github.com/turbot/steampipe-plugin-net/commit/869fe3e5027047d50b7e74342c4cfd52365f7b72, which then allowed me to retrieve all of the records (output is truncated for the value column):
> select
  *
from
  net_dns_record
where
  domain = 'github.com' and
  dns_server = '<IP_ADDRESS>';
+------------+------+------------+--------------+--------------------------+----------+-----------+-----------------------------------------------------------------------------------------------------------------
| domain     | type | dns_server | ip           | target                   | priority | tag       | value
+------------+------+------------+--------------+--------------------------+----------+-----------+-----------------------------------------------------------------------------------------------------------------
| github.com | A    | <IP_ADDRESS>    | <IP_ADDRESS> | <null>                   | <null>   | <null>    | <null>
| github.com | CAA  | <IP_ADDRESS>    | <null>       | <null>                   | <null>   | issuewild | digicert.com
| github.com | CAA  | <IP_ADDRESS>    | <null>       | <null>                   | <null>   | issue     | digicert.com
| github.com | CAA  | <IP_ADDRESS>    | <null>       | <null>                   | <null>   | issue     | globalsign.com
| github.com | MX   | <IP_ADDRESS>    | <null>       | alt2.aspmx.l.google.com. | 5        | <null>    | <null>
| github.com | MX   | <IP_ADDRESS>    | <null>       | alt3.aspmx.l.google.com. | 10       | <null>    | <null>
| github.com | MX   | <IP_ADDRESS>    | <null>       | alt4.aspmx.l.google.com. | 10       | <null>    | <null>
| github.com | MX   | <IP_ADDRESS>    | <null>       | alt1.aspmx.l.google.com. | 5        | <null>    | <null>
| github.com | MX   | <IP_ADDRESS>    | <null>       | aspmx.l.google.com.      | 1        | <null>    | <null>
| github.com | NS   | <IP_ADDRESS>    | <null>       | ns-520.awsdns-01.net.    | <null>   | <null>    | <null>
| github.com | NS   | <IP_ADDRESS>    | <null>       | dns4.p08.nsone.net.      | <null>   | <null>    | <null>
| github.com | NS   | <IP_ADDRESS>    | <null>       | dns1.p08.nsone.net.      | <null>   | <null>    | <null>
| github.com | NS   | <IP_ADDRESS>    | <null>       | ns-1283.awsdns-32.org.   | <null>   | <null>    | <null>
| github.com | NS   | <IP_ADDRESS>    | <null>       | dns2.p08.nsone.net.      | <null>   | <null>    | <null>
| github.com | NS   | <IP_ADDRESS>    | <null>       | ns-1707.awsdns-21.co.uk. | <null>   | <null>    | <null>
| github.com | NS   | <IP_ADDRESS>    | <null>       | dns3.p08.nsone.net.      | <null>   | <null>    | <null>
| github.com | NS   | <IP_ADDRESS>    | <null>       | ns-421.awsdns-52.com.    | <null>   | <null>    | <null>
| github.com | SOA  | <IP_ADDRESS>    | <null>       | dns1.p08.nsone.net.      | <null>   | <null>    | <null>
| github.com | TXT  | <IP_ADDRESS>    | <null>       | <null>                   | <null>   | <null>    | <IP_ADDRESS> ip4:<IP_ADDRESS> ip4:<IP_ADDRESS> ip4:<IP_ADDRESS>/28 ip4:<IP_ADDRESS> ip4:<IP_ADDRESS>/31 i
| github.com | TXT  | <IP_ADDRESS>    | <null>       | <null>                   | <null>   | <null>    | MS=6BF03E6AF5CB689E315FB6199603BABF2C88D805
| github.com | TXT  | <IP_ADDRESS>    | <null>       | <null>                   | <null>   | <null>    | MS=ms44452932
| github.com | TXT  | <IP_ADDRESS>    | <null>       | <null>                   | <null>   | <null>    | MS=ms58704441
| github.com | TXT  | <IP_ADDRESS>    | <null>       | <null>                   | <null>   | <null>    | adobe-idp-site-verification=b92c9e999aef825edc36e0a3d847d2dbad5b2fc0e05c79ddd7a16139b48ecf4b
| github.com | TXT  | <IP_ADDRESS>    | <null>       | <null>                   | <null>   | <null>    | apple-domain-verification=RyQhdzTl6Z6x8ZP4
| github.com | TXT  | <IP_ADDRESS>    | <null>       | <null>                   | <null>   | <null>    | atlassian-domain-verification=jjgw98AKv2aeoYFxiL/VFaoyPkn3undEssTRuMg6C/3Fp/iqhkV4HVV7WjYlVeF8
| github.com | TXT  | <IP_ADDRESS>    | <null>       | <null>                   | <null>   | <null>    | docusign=087098e3-3d46-47b7-9b4e-8a23028154cd
| github.com | TXT  | <IP_ADDRESS>    | <null>       | <null>                   | <null>   | <null>    | facebook-domain-verification=39xu4jzl7roi7x0n93ldkxjiaarx50
| github.com | TXT  | <IP_ADDRESS>    | <null>       | <null>                   | <null>   | <null>    | google-site-verification=UTM-3akMgubp6tQtgEuAkYNYLyYAvpTnnSrDMWoDR3o
| github.com | TXT  | <IP_ADDRESS>    | <null>       | <null>                   | <null>   | <null>    | krisp-domain-verification=ZlyiK7XLhnaoUQb2hpak1PLY7dFkl1WE
| github.com | TXT  | <IP_ADDRESS>    | <null>       | <null>                   | <null>   | <null>    | loom-site-verification=f3787154f1154b7880e720a511ea664d
| github.com | TXT  | <IP_ADDRESS>    | <null>       | <null>                   | <null>   | <null>    | stripe-verification=f88ef17321660a01bab1660454192e014defa29ba7b8de9633c69d6b4912217f
| github.com | TXT  | <IP_ADDRESS>    | <null>       | <null>                   | <null>   | <null>    | v=spf1 ip4:<IP_ADDRESS>/22 include:_netblocks.google.com include:_netblocks2.google.com include:_netblocks3.goog
+------------+------+------------+--------------+--------------------------+----------+-----------+-----------------------------------------------------------------------------------------------------------------

So I believe the net_dns_record table should fallback to EDNS and/or TCP, similar to https://github.com/miekg/exdns/blob/master/q/q.go#L385-L407.
I haven't had a chance to fully implement fallback yet, but I'm planning to look into this functionality hopefully sometime this week (and ensure that there are no security implications with its addition).
@massyn If you're interested, can you please test the add-dns-truncated-fallback branch locally and see if you can get the missing DNS records for github.com? If you get the records, then I believe this is the root cause for your original issue and fallback implementation should solve it.
Thanks!

Hi @cbruno10 - I applied this branch to my instance, and it is working as expected.  Let me know the next steps (if you'll create the pull request, or if you'd like me to initiate it).

Not stale

As mentioned in https://github.com/turbot/steampipe-plugin-net/pull/57#issuecomment-1660962853, this issue is on our overall TODO list but is not planned at the moment. There's a workaround in https://github.com/turbot/steampipe-plugin-net/commit/869fe3e5027047d50b7e74342c4cfd52365f7b72, which increases the buffer size to 4096, but we'd like to fallback to TCP if we receive a truncated response for a more long term solution.
I'm closing this issue due to lack of prioritization, but if anyone is interested at implementing fallback, we can re-open this issue.


[Text Analytics] Add advanced sample for NER resolutions

Resolves: https://github.com/Azure/azure-sdk-for-net/issues/33719

API change check
API changes are not detected in this pull request.


Issue of managing NuGet package

Hi,
I have an issue of managing NuGet package. Basically I tried to resolve this issue with a new Visual Studio installation after uninstalling the existing one. This happens in both Visual Studio 2015 Professional and Enterprise edition in Windows Server 2012.
The error message I have encountered: "Solution is not saved. Please save your solution before managing NuGet packages."
Could someone please help on this?
Kind regards,
Samuel

Issue moved to NuGet/Home #6255 via ZenHub


Release build has tree_exiting error that doesn't occur in debug build/editor

Tested versions
Reproducible in 4.3rc3, 4.3rc2
System information
Windows 10
Issue description
I have a project that plays in editor with no errors, exported debug builds play fine too, but exported release builds have a new major error: a type of object that is meant to be destroyed will not be removed and give this error:
ERROR: Attempt to disconnect a nonexistent connection from '@AnimatableBody2D@557:<AnimatableBody2D#149350782344>'. Signal: 'tree_exiting', callable: ''.
   at: (core/object/object.cpp:1462)

There isn't any code that connects to these objects tree_exiting signal.
I've tried Windows and Web builds and it happens in both.
It's worth noting the project was originally created in 4.2.1, it never had these errors in editor but no builds were tested until bringing it to 4.3, so I have no idea if this error is specific to 4.3 or can happen in older versions. When I attempt to open it back up in 4.2.1 any builds are broken and the log tells me it can't open scenes made in 4.3.

Steps to reproduce
Export a Windows 64bit build with debug enabled and it will play correctly, clicking on tiles will make them disappear.
Then export a Windows 64bit build with debug disabled and launch with the console, the tiles will not disappear and multiple identical errors fill the log.
Minimal reproduction project (MRP)
broken-export.zip

I can confirm the issue with a Windows release export in 4.3.rc2 (don't have 4.3.rc3 release templates to test but according to the OP it should be affected too).
I do not reproduce the issue with a Linux release export on the other hand.
After downgrading the project to Godot 4.2.2.stable, the bug doesn't seem reproducible with a Windows release export, so it appears to be a regression in 4.3.

When I attempt to open it back up in 4.2.1 any builds are broken and the log tells me it can't open scenes made in 4.3.

FYI, you need to remove the .godot folder to force a reimport when downgrading to an older Godot version.

So there are two issues:

The error spam with not being able to disconnect signals is reproducible with the Windows release export but not the Linux release export, and I narrowed it down to being introduced between 4.3.beta1 (good) and 4.3.beta3 (bad). I don't have 4.3.beta2 export templates locally to test and I have limited connectivity today, so if someone else can check beta2, that would be useful.

Regardless of that error spam, the project doesn't work as intended with any release build (Windows or Linux) in any recent Godot version (tested 4.2.2.stable, 4.3.dev1, 4.3.dev4, 4.3.beta1, 4.3.beta3 and 4.3.rc2). There's no signal error in the earlier versions, but the tiles don't get actually deleted in a release build. In a debug build, they get deleted.

There isn't any code that connects to these objects tree_exiting signal.
I've tried Windows and Web builds and it happens in both.

I can't reproduce issue (1) that I described above with the Web build, so it really seems to be a Windows specific regression.
The Web build behaves like the Linux build in 4.2.2 and 4.3.rc2: Tiles don't get removed, but there's no error in the console.

Regardless of that error spam, the project doesn't work as intended with any release build (Windows or Linux) in any recent Godot version (tested 4.2.2.stable, 4.3.dev1, 4.3.dev4, 4.3.beta1, 4.3.beta3 and 4.3.rc2). There's no signal error in the earlier versions, but the tiles don't get actually deleted in a release build. In a debug build, they get deleted.

That's caused by a user error, there's a part of logic within assert, which thus is removed in a release build. Moving it out of assert makes tile deletion work in a release build.
# MRP, world.gd, line 54:
assert(grp.members.erase(key), "Tile not found in member list!")

https://github.com/godotengine/godot/blob/06fbc8395b3c0ec6fa38588caea2ee94837f7b97/modules/gdscript/doc_classes/%40GDScript.xml#L37

(2)

That's caused by a user error, there's a part of logic within assert, which thus is removed in a release build. Moving it out of assert makes tile deletion work in a release build.

Indeed, I confirm that changing this fixes the logic error on Linux and Windows release exports, where tiles then properly get removed. There's still signal error spam on Windows but the project works as intended.

Regarding the signal error spam, @bruvzg did some testing:

I can reproduce it with the official Windows release template, but not with my local builds.
Seems to be reproducible with GCC + LTO build (tested with MinGW 12.0.0.r235 / GCC 14.2.0 using MSYS on Windows). MSVC builds, and non-LTO GCC builds are not affected.

We updated MinGW/GCC version in 4.3.beta2 when upgrading the build containers to Fedora 40, so this might be a recent regression in MinGW/GCC/binutils that was exposed by this toolchain update. https://github.com/godotengine/build-containers/pull/141#issuecomment-2180061082
We're unlikely to be able to solve that in time for 4.3, so I'm bumping to the 4.4 milestone, but that's still something we should look into to fix or workaround in 4.3.x.

I don't get any signal spam in my custom 4.3.rc build on Windows. Neither in debug nor release export.
Godot v4.3.rc (59a9a9b49) - Windows 10.0.22631 - GLES3 (Compatibility) - ANGLE (AMD, AMD Radeon HD 5450 (0x000068F9) Direct3D11 vs_5_0 ps_5_0, D3D11-<IP_ADDRESS>3) - AMD Ryzen 5 3600X 6-Core Processor (12 Threads)

My custom build is based on (4bef4d9808848c38c3f285edb300b4f3a843e543), which then my custom features are added on top.

I can confirm that 4.3.rc3 and 4.3.beta2 have the error spam on release exports @akien-mga.
4.3.beta2:

4.3.rc3:

Also in both versions, the tree_exiting and tree_entered signal attempt to disconnect error happens when the game closes.

I just built 4.3.rc3 (03afb92efa18874da19f7fc185a32c005d20aa1d) with LLVM MinGW 18.1.0 and all the above issues do not occur.

So, hopefully this narrows it down further.

Hello, I don't know if this is related, but I'm getting an error in 4.3.stable when exporting as release, on Windows x86_64 and Linux arm64 which does not appear in a debug release.

The game plays fine in the editor or an debug export, but in a release export this script fails to load due to ""free()" not found in base self", "queue_free()" works in the same node, and calling "free()" from another node works.

Happening on Linux also for me when exporting a release version.

im also suffering from this Issue. Does anyone have any Idea what could cause it? makes logs from release exports very hard to use :(

This started in 4.3.
I've noticed coloration between Area2D and Characterody2D when Area2D has body_entered signal assigned to A function. Weird part is that when they overlap there's a rogue connections. Sometimes I catch CharacterBody2D tree_entered is connected to Area2D _body_enter_tree which is only in C++ code.


source tcl on Windows

source C:\some_your_path\OpenHBMC\examples\mb_single_ram mb_single_ram.tcl
doesn't work on Windows, it generae an  "error: [common 17-165] too many positional options when parsing"
I had to use:
C:/some_your_path/OpenHBMC/examples/mb_single_ram/mb_single_ram.tcl
no spaces, no backslash and it's work fine.

Hello!
Right, thanks a lot. There is a typo, a space before "mb_single_ram" instead of backslash.
BTW, both backslash and forward slash in the path are ok, vivado accepts both.
Have fixed readme.md
Best regards


build: add license auto updater

Coverage remained the same at 100.0% when pulling f47d965cfbaf5f73773f74587567218aec7817d6 on add-license-updater into cb6c4f1cb3e1dd512a833aaee671780d5ce22794 on main.

Coverage remained the same at 100.0% when pulling f47d965cfbaf5f73773f74587567218aec7817d6 on add-license-updater into cb6c4f1cb3e1dd512a833aaee671780d5ce22794 on main.

:tada: This PR is included in version 1.2.11 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Access request for Source Data SFTP

Hi,
I would like access to Data Commons to access physical risk, transition risk and ITR tool.
Email<EMAIL_ADDRESS>Thank you!

Hi Ashu - You should have access to all the repos.  I added Erik to provide credentials for data access.
This link provides you more info on repos associated with the various tools and how to join the various project meetings. If you have questions please let me know: https://github.com/os-climate/OS-Climate-Community-Hub#readme

Thank you!

From: Heather Ackenhusen @.>
Sent: Wednesday, October 19, 2022 2:56 PM
To: os-climate/os_c_data_commons @.>
Cc: Ashu Singh @.>; Author @.>
Subject: Re: [os-climate/os_c_data_commons] Access request for Source Data SFTP (Issue #219)
Hi Ashu - You should have access to all the repos. I added Erik to provide credentials for data access.
This link provides you more info on repos associated with the various tools and how to join the various project meetings. If you have questions please let me know: https://github.com/os-climate/OS-Climate-Community-Hub#readmehttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fos-climate%2FOS-Climate-Community-Hub%23readme&data=05|01|ashu%40yves.blue|847da66b5db649ddf20d08dab203b149|77809dffc9a44b4dbb3c98ac10b0bc70|0|0|638018026185596492|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=CjexQ0EaBJcOjBRK9lp8qDBschqKbv9KUy0fqIIbtG8%3D&reserved=0
—
Reply to this email directly, view it on GitHubhttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fos-climate%2Fos_c_data_commons%2Fissues%2F219%23issuecomment-1284442498&data=05|01|ashu%40yves.blue|847da66b5db649ddf20d08dab203b149|77809dffc9a44b4dbb3c98ac10b0bc70|0|0|638018026185596492|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=VO%2F1lAu%2B0GnLwZI2uVHbgxpobDRHz1H9IsgLR0MSKr8%3D&reserved=0, or unsubscribehttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAVNTN6KMJZRAHJW43IFPUJ3WEA77PANCNFSM6AAAAAARJL7NY4&data=05|01|ashu%40yves.blue|847da66b5db649ddf20d08dab203b149|77809dffc9a44b4dbb3c98ac10b0bc70|0|0|638018026185596492|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=71TTYnd63jCT5%2FoVKmSgk6IiVnuFDC7hlLNGRYYW5fI%3D&reserved=0.
You are receiving this because you authored the thread.Message ID: @.***>


very small thing... typography stuff

hi,
there is one small thing that bugs me... in "Weather: ☀ Clear, +21°C, 28%, ↙6 km/h, 1015hPa" there shouldn't be a space between the figure and the unit for windspeed. besides, it's not coherent with your choice of typographical rules...
i am sure it is super easy to fix.
and, do not get me wrong, wttr.in is totally amazing.
cheers from france (yes yes in lockdown... time to mess around on the computer)
best,
a-

Bonsoir, merci pour la suggestion :)
We here in Bavaria have the lockdown too, not so hard as you of course, and it is supposed to start weakening from the next week; we will see.
Back to your suggestion: if I understood it right, you mean the v2.wttr.in view.
Please test it now

hi, that was fast :)
yes indeed that fixed it... i failed to mention it appeared also with the wttr.in/Wherever?format=4 (or using the %x thing... i use that for my conky config) but as i guessed it worked as well there. very nice and consistent now. it actually doesn't matter if you put a space between a figure and its associated unit or not, as long as you do it always the same way. i do some scientific journal layouting and magazine layouting so i'm kinda cranky when it gets to typography ahah...
anyhow thanks again and glad i could help a tiny little bit.
i'm all new to this git and github stuff so it was nice to be able to do it.
ce fut un plaisir, bien amicalement...
all the very best, stay safe.
a-
ps: i enjoy tremendously your list of things console-based, being a fan of console versions of all things because i find it pretty... i worship ncurses.

@hern42 Thank you for your help! I think it is better now, though it is still not fully
consistent, because at the main view we still have a space between the value and the unit name.
Probably, we should make it with spaces everywhere. What do you think?

well. that's a tough one...
https://www.bipm.org/utils/common/pdf/si-brochure/SI-Brochure-9.pdf (go page 38 section 5.4.3)
so it seems that there should be a space indeed.
however one may think that it can be more compact and readable without as it "separates" data better... and we are not speaking typesetting for paper print here. so i guess at the end it is your choice :) my gut feeling and scientific upbringing would point at following the rule but i love compact things, especially for terminal/console applications.
as i said, tough one.

there is the english version p149 of the pdf... sorry, didn't check that. just after a while i wondered if the french and english rules were different (they are for punctuation...)
doesn't change a thing though...

I think that it is better with space, because in UNIX/Linux it is better to have spaces, as additional separators for the case if the user wants to cut something (units in this case) off.
Also, it is easier to remove space (if the user doesn't like it) than add space.
So I would say, with space it is better

Also, it is easier to remove space (if the user doesn't like it) than add space.
word!
i totally agree...
let me know if it is up to me to close that thread or whatever.

If everything works as expected, let's close it :)

ok let's wait until you do your magic then...

I think we can close it :)


Launch failed: Installation failed. Failure [INSTALL_FAILED_TEST_ONLY: installPackageLI]

Configuration File:
{
    "configurations": [
        {
            "type": "android",
            "request": "launch",
            "name": "Android Launch",
            "appSrcRoot": "${workspaceRoot}/app/src/main",
            "apkFile": "${workspaceRoot}/app/build/outputs/apk/debug/app-debug.apk",
            "adbPort": 5037
        },
    {
        "type": "android",
        "request": "attach",
        "name": "Android Attach",
        "appSrcRoot": "${workspaceRoot}/app/src/main",
        "adbPort": 5037,
        "processId": "${command:PickAndroidProcess}"
    }
    ]
}

Build Output:
Checking build
Searching for devices...
Found 1 device
Deploying current build...
Installing...
Launch failed: Installation failed. Failure [INSTALL_FAILED_TEST_ONLY: installPackageLI]

OS: elementary OS
VS Code: 1.50.0
Extension: 1.3.2

Just add
"pmInstallArgs": ["-t -r"]

Thanks for the tip! I'll check it out and reach here back.


Failed making a parser

I'm trying to create a brand new apiserver using code-generator. So I create an empty golang project, and add this project into vendor
mkdir ${GOPATH}/src/github.com/asdfsx/getkubeconfig
cd ${GOPATH}/src/github.com/asdfsx/getkubeconfig
glide init
glide get k8s.io/code-generator#kubernetes-1.11.3

then I try to generator the code as follow
vendor/k8s.io/code-generator/generate-groups.sh \
all \
github.com/asdfsx/getkubeconfig/pkg/client \
github.com/asdfsx/getkubeconfig/pkg/apis \
example:v1

but got the error
Generating deepcopy funcs
F0910 19:18:35.552948   12153 main.go:81] Error: Failed making a parser: unable to add directory "github.com/asdfsx/getkubeconfig/pkg/apis/example/v1": unable to import "github.com/asdfsx/getkubeconfig/pkg/apis/example/v1": cannot find package "github.com/asdfsx/getkubeconfig/pkg/apis/example/v1" in any of:
        /Users/sunxia/gocode/src/github.com/asdfsx/getkubeconfig/vendor/github.com/asdfsx/getkubeconfig/pkg/apis/example/v1 (vendor tree)
        /usr/local/opt/go/libexec/src/github.com/asdfsx/getkubeconfig/pkg/apis/example/v1 (from $GOROOT)
        /Users/sunxia/gocode/src/github.com/asdfsx/getkubeconfig/pkg/apis/example/v1 (from $GOPATH)

and if I create the direcotry /Users/sunxia/gocode/src/github.com/asdfsx/getkubeconfig/pkg/apis/example/v1 then the error change to
Generating deepcopy funcs
F0910 19:19:51.352507   12172 main.go:81] Error: Failed making a parser: unable to add directory "github.com/asdfsx/getkubeconfig/pkg/apis/example/v1": No files for pkg "github.com/asdfsx/getkubeconfig/pkg/apis/example/v1": map[parser.importPathString][]parser.parsedFile{}

Can someone tell me what's going wrong? thx a lot!

@asdfsx What was done ？

@yueyongyue I don't think so~I've forget the detail.
But I think the problem is codegenerator can not generate codes from an empty project.
You should add type definitions , and use comments like // +genclient to config the generator.
Then you can use generator to generate codes

https://github.com/kubernetes/code-generator/issues/99

Fixed similar issue with a symbolic link.


Don't require test-unit because it triggers autorun

Errbit doesn't have any test-unit tests. Requiring test-unit triggers a
test-unit autorun which breaks CI. The problem is similar to the one
described here:
http://stackoverflow.com/questions/1899009/why-are-tests-running-in-production-mode-and-causing-my-script-runners-to-fail

Example test run: https://ci-new.alphagov.co.uk/job/govuk_errbit/49/console

I was looking for more context around why errbit uses test-unit and came across this discussion, it seems rspec-rails needs test-unit.


Avoid using python 3.12 for now

Fixes #12
We are seeing an error with python 3.12.
The error comes from the intake-esm library.
This should resolve eventually as python 3.12 matures.    See this post:  https://github.com/pypa/pip/issues/11501
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
Cell In[11], line 2
      1 # Have the catalog interpret the "na-cordex-models" column as a list of values, as opposed to single values.
----> 2 col = intake.open_esm_datastore(catalog_url, read_csv_kwargs={"converters": {"na-cordex-models": ast.literal_eval}},)
      3 col

File /srv/conda/envs/notebook/lib/python3.12/site-packages/intake/__init__.py:66, in __getattr__(attr)
     64 if attr[:5] == "open_":
     65     if attr[5:] in registry.drivers.enabled_plugins():
---> 66         driver = registry[attr[5:]]  # "open_..."
     67         return driver
     68     else:

File /srv/conda/envs/notebook/lib/python3.12/site-packages/intake/source/__init__.py:32, in DriverRegistry.__getitem__(self, item)
     30 it = self.drivers.enabled_plugins()[item]
     31 if isinstance(it, entrypoints.EntryPoint):
---> 32     return it.load()
     33 elif isinstance(it, str):
     34     return import_name(it)

File /srv/conda/envs/notebook/lib/python3.12/site-packages/entrypoints.py:79, in EntryPoint.load(self)
     76 def load(self):
     77     """Load the object to which this entry point refers.
     78     """
---> 79     mod = import_module(self.module_name)
     80     obj = mod
     81     if self.object_name:

File /srv/conda/envs/notebook/lib/python3.12/importlib/__init__.py:90, in import_module(name, package)
     88             break
     89         level += 1
---> 90 return _bootstrap._gcd_import(name[level:], package, level)

File <frozen importlib._bootstrap>:1381, in _gcd_import(name, package, level)

File <frozen importlib._bootstrap>:1354, in _find_and_load(name, import_)

File <frozen importlib._bootstrap>:1304, in _find_and_load_unlocked(name, import_)

File <frozen importlib._bootstrap>:488, in _call_with_frames_removed(f, *args, **kwds)

File <frozen importlib._bootstrap>:1381, in _gcd_import(name, package, level)

File <frozen importlib._bootstrap>:1354, in _find_and_load(name, import_)

File <frozen importlib._bootstrap>:1325, in _find_and_load_unlocked(name, import_)

File <frozen importlib._bootstrap>:929, in _load_unlocked(spec)

File <frozen importlib._bootstrap_external>:994, in exec_module(self, module)

File <frozen importlib._bootstrap>:488, in _call_with_frames_removed(f, *args, **kwds)

File /srv/conda/envs/notebook/lib/python3.12/site-packages/intake_esm/__init__.py:6
      4 # Import intake first to avoid circular imports during discovery.
      5 import intake
----> 6 from pkg_resources import DistributionNotFound, get_distribution
      8 from . import tutorial
      9 from .core import esm_datastore

File /srv/conda/envs/notebook/lib/python3.12/site-packages/pkg_resources/__init__.py:2191
   2187     dist_groups = map(find_distributions, resolved_paths)
   2188     return next(dist_groups, ())
-> 2191 register_finder(pkgutil.ImpImporter, find_on_path)
   2193 if hasattr(importlib_machinery, 'FileFinder'):
   2194     register_finder(importlib_machinery.FileFinder, find_on_path)

AttributeError: module 'pkgutil' has no attribute 'ImpImporter'

This notebook relies on Dask parallelism to be responsive.   With four workers, it should complete in under ten minutes.
The GitHub build timeout value of 5 minutes is probably a bit too low for this notebook.

I remember talking with @brian-rose about running this notebook with a larger timeout value, and performing the nightly build action only once a week.
The nightly build workflow is still set up to run on Sunday at midnight.   I don't know how to increase the timeout value for this notebook, however.

With lower data requirements, the notebook ran in just over 6 minutes.   I don't know how the 5 minute timeout limit was circumvented this time, but...yay?

With lower data requirements, the notebook ran in just over 6 minutes. I don't know how the 5 minute timeout limit was circumvented this time, but...yay?

This cookbook is currently set to a one-hour timeout, see this line in the config file:
https://github.com/ProjectPythia/na-cordex-viz-cookbook/blob/2b07b1453e7b43f63cfeb139614d6eef392b0251/_config.yml#L13

Thanks for checking!   I guess this timeout error from yesterday was a fluke then?
https://github.com/ProjectPythia/na-cordex-viz-cookbook/actions/runs/7280739398/job/19839811580

Maybe! The notebook execution part of the builds are running on the Pythia binder, not on GitHub actions. Sometimes the lengthiest part of a Binder run is building the image, which needs to happen if there are any changes the environment file (which is the case in this PR).
We're also aiming to have better support for dask workers on demand for bigger builds through this Binder, but we're not there yet.

It's possible that there are still some hidden timeout conditions being passed through binderbot (the command line tool we are using the route the notebook execution to the Binder). Fixing up that software is also a 2024 priority. I don't currently have a good explanation for why you got a 5-minute timeout in one case but not others.

Okay, I understand.   We have another failure data point now.   I removed an "import pprint" in the notebook and we got another Binder build error.    I'm pretty sure the notebook is working now, despite the error.

Hmm different error this time. I will see what the old "unplug and plug back in" cycle accomplishes.

Unrelated failure. Now Binder is looking for the repo under my user name:
2023-12-21 18:06:10 [info     ] Binder: Get https://binder.projectpythia.org/build/gh/brian-rose/na-cordex-viz-cookbook/fix-environment action=binder-start phase=get-launch-url
2023-12-21 18:06:11 [info     ] Binder: Build Failed Could not resolve ref for gh:brian-rose/na-cordex-viz-cookbook/fix-environment. Double check your URL and that your repo is public. GitHub recently changed default branches from "master" to "main".

This is a bug in our workflows. It shouldn't matter who clicked the "reopen" button.
I'll try to document this elsewhere.
@bonnland you might try your own "close and reopen" and see what happens.

Unrelated failure. Now Binder is looking for the repo under my user name:
2023-12-21 18:06:10 [info     ] Binder: Get https://binder.projectpythia.org/build/gh/brian-rose/na-cordex-viz-cookbook/fix-environment action=binder-start phase=get-launch-url
2023-12-21 18:06:11 [info     ] Binder: Build Failed Could not resolve ref for gh:brian-rose/na-cordex-viz-cookbook/fix-environment. Double check your URL and that your repo is public. GitHub recently changed default branches from "master" to "main".

This is a bug in our workflows. It shouldn't matter who clicked the "reopen" button.
I'll try to document this elsewhere.
@bonnland you might try your own "close and reopen" and see what happens.

Actually this failure is for the same reason as https://github.com/ProjectPythia/cookbook-actions/issues/79

The failure now looks like
2023-12-21 18:18:05 [info     ] Binder: Build Failed Failed to create temporary user for ktyle/binder-dev-bonnland-2dna-2dcordex-2dviz-2dcookbook-66d65c:8a8dc18034a5c8ade71d7841ece57f446d518f0d

I got the same failure trying to run an interactive Binder session with a different repo. There's something wrong with the Binder currently, unrelated (as far as I can tell) to this PR.
I will check to @ktyle to see if we can find out what's up with the Binder.

It seems the Binder failure may be related to current maintenance on Jetstream2 where the Binder is running. @bonnland sorry for the multiple hiccups, but you should try closing and reopening again later.

It looks like the checks passed.   Should I merge to main, or let someone else when the timing is better?

Looks like our Binder is back in business! You should go ahead and merge if you're happy with the changes.

It looks like the merge to main workflow is failing because python 3.12 is being used somewhere.    The notebook environment specifies python <= 3.11 to avoid python 3.12.   But it must still be used somewhere in the build actions.

Ugh. I think this is another bug in our workflows. Looks like the Binder is being pointed to the wrong branch and picking up the wrong environment file.
I'll try manually triggering a new publish workflow.

Ok, so the manual publish run seemed to work fine: https://github.com/ProjectPythia/na-cordex-viz-cookbook/actions/runs/7294855106
You should be all set. I think there are still a number of bugs in our workflow logic for handling changes in the environment files. Things are simpler for PRs that don't modify environment.yml. Thanks for your patience as we continue to iron this out.


Connectors : OPENCTI_TOKEN not honored when set in envFromSecrets

Describe the bug a clear and concise description of what the bug is.
In connectors, when OPENCTI_TOKEN is set in envFromSecrets and not hard-coded as part of env.  This line here, gets evaluated to TRUE.
Condition 1 : (not (hasKey .env "OPENCTI_TOKEN"))  : True because value is not hard-coded in env
Condition 2 : ($.Values.env.APP__ADMIN__TOKEN)  : True because of default value ChangeMe
Thus, second instance of OPENCTI_TOKEN with "ChangeMe" takes precedence and connector errors out.
Whatever, I set in envFromSecrets OPENCTI_TOKEN is ignored.
Solution for this pbm is to use $envList instead of .env. Very similar to worker deployment.
What's your helm version?
v3.15.4
What's your kubectl version?
v1.30.4
Chart version
1.0.0 (latest)
Explain bug
Connector errors out without correct opencti_token
What you expected to happen?
To honor OPENCTI_TOKEN set in envFromSecrets
How to reproduce it?
OPENCTI_TOKEN is set in envFromSecrets and not hard-coded as part of env
Enter the changed values of values.yaml?
NONE

@ialejandro, I'm working on PR to resolve this issue. will send it to you once it is ready.

Pull request 37 is submitted for your review @ialejandro .

Maybe we need to improve this codeblock for worker and connectors, because I already tested some cases:
@acodefella thx a lot for you helper! I'll try reproduce all posible cases, what case you mean?

Case: with .env (on template)

env:
  APP__ADMIN__TOKEN: b1976749-8a53-4f49-bf04-cafa2a3458c1
...
secrets:
  OPENCTI_TOKEN: my-ci-cd
...
connectors:
- name: alienvault
  enabled: true
  replicas: 1
  env:
    OPENCTI_TOKEN: "issue-token"

Result:
...
      containers:
        - name: alienvault-connector
          securityContext:
            null
          image: "opencti/alienvault:6.2.15"
          imagePullPolicy: IfNotPresent
          env:
          # Variables from secrets have precedence

          # Special handling for OPENCTI_URL which is constructed from other values
          - name: OPENCTI_URL
            value: "http://opencti-ci-server:80"

          # Special handling for OPENCTI_TOKEN which is constructed from other values

          # Add Variables in plain text if they were not already added from secrets
          - name: OPENCTI_TOKEN
            value: "issue-token"

          resources:
            null

Case: with .env (on template) and .envFromSecrets (on connector):

env:
  APP__ADMIN__TOKEN: b1976749-8a53-4f49-bf04-cafa2a3458c1
...
secrets:
  OPENCTI_TOKEN: my-ci-cd
...
connectors:
- name: alienvault
  enabled: true
  replicas: 1
  env:
    OPENCTI_TOKEN: "issue-token"
  envFromSecrets:
    OPENCTI_TOKEN:
      name: opencti-ci-credentials
      key: OPENCTI_TOKEN

Result:
...
      containers:
        - name: alienvault-connector
          securityContext:
            null
          image: "opencti/alienvault:6.2.15"
          imagePullPolicy: IfNotPresent
          env:
          # Variables from secrets have precedence
          - name: OPENCTI_TOKEN
            valueFrom:
              secretKeyRef:
                name: opencti-ci-credentials
                key: OPENCTI_TOKEN

          # Special handling for OPENCTI_URL which is constructed from other values
          - name: OPENCTI_URL
            value: "http://opencti-ci-server:80"

          # Special handling for OPENCTI_TOKEN which is constructed from other values

          # Add Variables in plain text if they were not already added from secrets

Case: with $envList (on template)

env:
  APP__ADMIN__TOKEN: b1976749-8a53-4f49-bf04-cafa2a3458c1
...
secrets:
  OPENCTI_TOKEN: my-ci-cd
...
connectors:
- name: alienvault
  enabled: true
  replicas: 1
  env:
    OPENCTI_TOKEN: "issue-token"

Result:
Duplicate OPENCTI_TOKEN: wrong
...
      containers:
        - name: alienvault-connector
          securityContext:
            null
          image: "opencti/alienvault:6.2.15"
          imagePullPolicy: IfNotPresent
          env:
          # Variables from secrets have precedence

          # Special handling for OPENCTI_URL which is constructed from other values
          - name: OPENCTI_URL
            value: "http://opencti-ci-server:80"

          # Special handling for OPENCTI_TOKEN which is constructed from other values
          - name: OPENCTI_TOKEN
            value: "b1976749-8a53-4f49-bf04-cafa2a3458c1"

          # Add Variables in plain text if they were not already added from secrets
          - name: OPENCTI_TOKEN
            value: "issue-token"

Case: with $envList (on template) and .envFromSecrets (on connector):

env:
  APP__ADMIN__TOKEN: b1976749-8a53-4f49-bf04-cafa2a3458c1
...
secrets:
  OPENCTI_TOKEN: my-ci-cd
...
connectors:
- name: alienvault
  enabled: true
  replicas: 1
  env:
    OPENCTI_TOKEN: "issue-token"
  envFromSecrets:
    OPENCTI_TOKEN:
      name: opencti-ci-credentials
      key: OPENCTI_TOKEN

Result:
...
      containers:
        - name: alienvault-connector
          securityContext:
            null
          image: "opencti/alienvault:6.2.15"
          imagePullPolicy: IfNotPresent
          env:
          # Variables from secrets have precedence
          - name: OPENCTI_TOKEN
            valueFrom:
              secretKeyRef:
                name: opencti-ci-credentials
                key: OPENCTI_TOKEN

          # Special handling for OPENCTI_URL which is constructed from other values
          - name: OPENCTI_URL
            value: "http://opencti-ci-server:80"

          # Special handling for OPENCTI_TOKEN which is constructed from other values

          # Add Variables in plain text if they were not already added from secrets

I just ran into this issue too.  The MR associated with it seems to fix this for me also.  Even if you don't change the order of the variables, checking for OPENCTI_TOKEN in envList will fix it if there are no other conflicts.  By changing the ordering like in the MR, the value in a secret will take precedence though which is probably the more desirable behavior..

thx @acodefella. Already applied, the changes appears on this patch version.

Thanks for your comments @eawagner
Thanks for merging it in @ialejandro  :+1:


Decide on Fonts and Colour Theming

Decide as a team what kind of fonts and colour palette we'd like to use. We can use tailwind to easily integrate these choices into the app.
Low priority - can be changed whenever.

This was completed as part of milestone 3.


Fixing margins and id of the error message

fixes #103

This change is

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

vaadin-text-field.html, line 55 at r1 (raw file):

      }

      [part="error-message"][hidden] {

Why is this here? A "[hidden]" div has "display: none;" by default so this rule should have no effect.

Comments from Reviewable

vaadin-text-field.html, line 55 at r1 (raw file):
Previously, tomivirkki (Tomi Virkki) wrote…
Why is this here? A "[hidden]" div has "display: none;" by default so this rule should have no effect.

Ping @limonte, why is this rule here in the default styles? I see it's currently in master.

Comments from Reviewable

Review status: all files reviewed at latest revision, 1 unresolved discussion.

vaadin-text-field.html, line 55 at r1 (raw file):
@tomivirkki

A "[hidden]" div has "display: none;" by default

Usually yes, but not for the Valo theme: https://github.com/vaadin/vaadin-themes/blob/72f81a16415ab2952f06bff0fa656d55132801e7/valo/vaadin-text-field.html#L202

Comments from Reviewable

vaadin-text-field.html, line 55 at r1 (raw file):
Previously, limonte (Limon Monte) wrote…
@tomivirkki

A "[hidden]" div has "display: none;" by default

Usually yes, but not for the Valo theme: https://github.com/vaadin/vaadin-themes/blob/72f81a16415ab2952f06bff0fa656d55132801e7/valo/vaadin-text-field.html#L202

Then it’s Valo theme’s business. Text-field default styles should know nothing about nor should be affected by Valo theme.

Comments from Reviewable

Review status: all files reviewed at latest revision, 1 unresolved discussion.

vaadin-text-field.html, line 55 at r1 (raw file):
Previously, tomivirkki (Tomi Virkki) wrote…
Then it’s Valo theme’s business. Text-field default styles should know nothing about nor should be affected by Valo theme.

True that, I'll revert this change. Thanks!

Comments from Reviewable

vaadin-text-field.html, line 55 at r1 (raw file):
Previously, limonte (Limon Monte) wrote…
True that, I'll revert this change. Thanks!

Additionally, the proper fix is to enforce display:none for the "[hidden]" element, not override a margin value.

Comments from Reviewable


[Word] (typo) Fix code sample

Fixes #2720

Docs Build status updates of commit 8dc9f49:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/includes/file-get-the-whole-document-from-an-add-in-for-powerpoint-or-word.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Add ability to customize CMake build directory

Fixes #19.

By the way, no need to force-push your branch, we can always squash commits when merging. Actually separating commits might help pin-pointing the changes that were made after a review.

@foonathan thanks for this patch. I hope it will be merged. For now, I am using your branch 👍
I was surprised that by default it makes the build directory in-source because README says The built files will end up in the binary directory (out-of-source build).
Maybe one suggestion if it is possible to make interface something like this :CMakeGenerate <config> <cmake_build_directory>?
So one can specify  and overrides g:cmake_default_config and one can specify <cmake_build_directory> and overrides g:cmake_build_directory.

@karlosp I think you might have misunderstood what "out-of-source build" means, the README has a link to a post that explains it, here it is: https://cprieto.com/posts/2016/10/cmake-out-of-source-build.html
Out-of-source means that the build artifacts, including for instance the CMakeCache.txt file, are in a separate directory, but the directory can be a child of the root directory. E.g., if the root directory is project–foo/, your build artifacts can end up in project-foo/Debug/, and the cache file would be project-foo/Debug/CMakeCache.txt. In-source means that your build artifacts end up in your project root, not in a separate directory, i.e., your cache file would be project-foo/CMakeCache.txt (which is messy, because you'd potentially have build artifacts and source files in the same directory).
The goal of #19 (and thus this PR) is to specify a path where the build directory must be placed, which by default if the project root (so a Debug configuration would build in project-foo/Debug/). For instance, one could specify to place the build directory inside of builds/, relative to the project root, to have the build directory as project-foo/builds/Debug/.
I don't think one would want to place the build directory above the project root, or at the same level, but you could do that. Definitely not a smart choice if you have multiple projects at the same level, since there would be one Debug/ directory for both of them
.
├── project-foo/
├── project-bar/
└── Debug/  # artifacts of project-foo or project-bar?

Is this more clear?
Regarding this PR, I cannot merge it yet, as there is an issue, as I explained in this comment: https://github.com/cdelledonne/vim-cmake/pull/21#discussion_r528184283. @foonathan said he would address the issue to make this PR good to merge, even if he is not using this plugin any longer (thanks for that, and feel free to change your mind of course).

@ cdelledonne thanks for your detailed explanation!
I have two reasons why would one want to put the build directory above the project root:

Real example: you export C++ code from MATLAB Simulink. The project root folder is generated with unknown folder names inside i.e one folder name is always user`s username:

.
$username
2018

You want to create generic CMakeLists.txt that you can copy to that project, so you use file(GLOB ... Now because build is in the root it will pick up some additional *.cpp files inside causing compilation error.

Sometimes I want to put it outside project root so that does not pollute my git status.

@karlosp I see, thanks for sharing your use cases. Regarding Git, it's quite common to add build directories to the .gitignore, but of course that's not a rule.

Handled in 6318c72321d9be3ac9c1fc1dac88531069472d78


Why toParams.ncyBreadcrumbLabel is undefined inside a run block?

Hi!
I am trying to create/mimic a kind of custom stack for the current breadcrumbs behavior, but I notice that toParams.ncyBreadcrumbLabel is always undefined even if console.log(toParams) displays its value.
.run(['$rootScope', '$state', '$stateParams', '$breadcrumb', '$templateCache',
function run ($rootScope, $state, $stateParams, $breadcrumb, $templateCache) {
    $rootScope.statesStack = [];

    $rootScope.$on('$stateChangeSuccess', function(event, toState, toParams, fromState, fromParams) {
        $rootScope.statesStack.push({
            'toState': toState,
            'toParams': toParams,
            'fromState': fromState,
            'fromParams': fromParams,
            'fromLabel': toParams.ncyBreadcrumbLabel
        });

        console.log('run - $rootScope.statesStack', $rootScope.statesStack);
    });
}]);

Any help would be great!

Hello!
I can confirm the issue @josoroma is experiencing – it seems run blocks are only aware of the pre-resolved param ncyBreadcrumb despite console.log(toState) being able to see the entire resolved params (such as ncyBreadcrumbLabel).
I thought I might be able to mitigate it in a dirty way by using the $interpolate service in my run block to parse the label manually, but it doesn't have access to the proper scope to pull it off.
Any thoughts on where it's hiding? So far I haven't had any luck "promise-ing" it in either.


Containers/slots

I wondered if there is a way of doing something like Vue's slots, where a component of some kind can take arbitrary HTML and wrap it within an element. Non-working example:
include karax / prelude

template container (body) =
  tdiv(class="container"):
    h1: text "This is a container"
    body

proc createDom(): VNode =
  result = buildHtml(tdiv):
    container:
      p: text "Hello world"

    container:
      input()
      hr()
      p: "multiple elements"

setRenderer createDom

Is this already possible with Karax?

Ugly workaround:

import karax / [kbase, vdom, kdom, vstyles, karax, karaxdsl]

proc container(body: VNode): VNode =
  result = buildHtml():
    tdiv(class="container"):
      h1: text "This is a container"
      body

proc createDom(): VNode =
  result = buildHtml(tdiv):
    container buildHtml(p) do:
      p: text "Hello world"
    container buildHtml(tdiv) do:
      input()
      hr()
      text "multiple elements"

Thanks @Araq , I hadn't thought of using the do notation. Not as clean as I'd like but it'll work for now


Records with same name

I've migrated cloudflare-ddns from timothyjmiller to this one and I've encountered the following problem:
😞 Failed to add a new A record of data.domain.net: A CNAME record with that host already exists. For more details, refer to https://developers.cloudflare.com/dns/manage-dns-records/troubleshooting/records-with-same-name/. (81054)
I've disabled IPv6 and tried leaving the configuration as it was before, but I keep getting this message.
Has anyone else experienced this?

@vk2r Hi, do you have a CNAME for data.domain.net? You need either a CNAME record (as an alias of anther domain) or this tool to update the A record, but not both. You cannot have an A record and a CNAME record. You can check your current configuration in the Cloudflare dashboard.


Cc2024

For the  'BioNT Community Event & CarpentryConnect - Heidelberg 2024' I added a news post and as an external event.
I tried to use a button to go to the event page for the first time in the news post.
However, I was not able to build the gtn page locally to test this feature.

This PR is ready for review. Thanks a lot!

Thanks @teresa-m !


PyPI packaging for ReqMgr2

Fixes #8587 #9849 #9822
Status
In development
Description
PyPI updates to create an organized structure to build many packages from the WMCore repo. Uses a single setup_template.py to create the necessary setup.py build scripts. Uses a single requirements.txt file that is parsed to create per package requirements files for build and upload. These files are manipulated by tools/build_pypi_packages.sh.
As an example of the new method, ReqMgr2 can be packaged and uploaded to PyPI.
Also, does not use distutils.
Is it backward compatible (if not, which system it affects?)
YES
Related PRs
Other PRs here: https://github.com/dmwm/WMCore/projects/8
External dependencies / deployment changes
None

Currently this only supports wmcore, wmagent and reqmgr2. If you think this process for building packages looks good, I can update the requirements.txt file with the other services as well. The build script would need an update as well to be more streamlined.
In my testing, this method produces packages with similar contents for packages, modules, and data files. In some cases, there are additional files in the bin directory (regmgr2 for instance), and I have not figured out how they get there. Also, there are some init scripts that are missing from the etc dir that get adding during the RPM build process. These might need to change slightly for the pypi deployment procedure.

Here's how those files show up under the bin directory (and a few other things done during the RPM build):
https://github.com/cms-sw/cmsdist/blob/comp_gcc630/reqmgr2.spec#L22-L39
Could you please point me again to the procedure - considering these changes - to build and upload a pypi package? Just so I can see the full picture here.

The procedure is the same as before. https://github.com/dmwm/WMCore/wiki/DMWM-Packaging-with-PyPi
Reqmgr2 is on PyPI now if you want to install to see how the directory structure looks in a virtual environment: https://pypi.org/project/reqmgr2

I worked out the issue with including all files in the bin dir. The environment scripts that are placed in etc/profile.d in the RPMs should be handled during the creation of the Docker image for each service. The current method for creating the env scripts is specific to a cmsweb release, which is not known when we package and upload to pypi.

Is it ready to be merged? Or you still want to get something else in?


prisma generate doesn't create client in default location

Bug description
Following tutorial at the step npx prisma generate client doesn't appear at the default .prisma/client location.
Only if I specify in prisma.schema:
generator client {
  provider = "prisma-client-js"
  output   = "client"
}

it generates client.
EDIT: still the new client doesn't intellisense new schema. Still keeps the old user and posts:

EDIT2: New client is working after closing and reopening VSCode.
EDIT3: after changing schema and generating client, new client is not imported from @prisma/client . I have to import from ./prisma/client to have new client.
How to reproduce

Expected behavior
No response
Prisma information

Environment & setup

OS: Windows 10
Database: PostgreSQL
Node.js version: v16.13.1

Prisma Version
3.12.0

All new Prisma users are using the default location in node_modules/.prisma/client to generate their client, and no one reported this not working so I highly doubt this is generally broken for everyone.
Which tutorial are you following?

Hi, I was following this tutorial on how to add prisma to existing database: https://www.prisma.io/docs/getting-started/setup-prisma/add-to-existing-project/relational-databases-typescript-postgres

@pantharshit00 I only put that because default behavior doesn't work

Following that tutorial you should have a newer Prisma version, currently 3.14.0. Can you please try again and see if the error persists if you follow exactly the steps in the tutorial? Thanks.

I have tried again and all is normal. I think it's my mistake. I thought the client is generated in root prisma folder, not in node_modules/.prisma folder.
Thank you


Updates to Home and Services Page

Any progress on your work yet?
Have you gone through the links I sent, I can't see your branch up yet.
By the way, google recommends only one stylesheet. I will add a bot that would help optimize the images.
https://google.github.io/styleguide/htmlcssguide.html

By the way, I want you to run all your operations from the forked repo here
https://github.com/Furbixtubs/bubble-up/tree/bubble
And if you can no longer work from that branch (bubble). Please create a new one.


Duplicating a node doesn't duplicate its signals

Operating system or device, Godot version, GPU Model and driver (if graphics related):
Godot Build: b279f641c
Issue description:
I don't know if it's really a bug, or how it's supposed to work. But I find strange that signals aren't duplicated when duplicating nodes.

Steps to reproduce? There are many ways to "duplicate" nodes, you need to be more specific.

BTW @RandomShaper, we're duplicate signals twice it seems, both in Node::_duplicate(p_flags) and in Node::duplicate(p_flags) which calls the former. 4e22b6acd did not fix it, just put the duplicated duplication behind the DUPLICATE_SIGNALS flag.

@akien-mga

The problem is specific to the editor, as it uses SceneTree::_duplicate instead of Node::_duplicate and thus does not respect the DUPLICATE_SIGNALS flag: https://github.com/godotengine/godot/blob/c755b68/editor/scene_tree_dock.cpp#L824
Related to #11182 - fixing #11182 by making SceneTree::_duplicate use Node::_duplicate in the non-instance case would fix this issue.

Fixed by #12893.


Dock-widgets in TableView prevent TableView from closing upon application exit

Steps to reproduce the problem:

Open a TableView
Open a dock widget
"Quit" the MainWindow
Expected Outcome:
All windows close
Outcome;
TableView window remains visible.

The TopView has dockwidgets that work in this regard. One should be able to transfer the proper handling from TopView to TableView.

Hi @joernu76  @ReimarBauer ! I have solved this issue. Tests also passed. I have send a PR to develop.


Home Assistant Open / Close state

Hi,
Great solution and based on this I made two modules which are working nicely, thank you!
One thing I noticed is that the state changes even when the window is not opened or closed.
I think it is because only the closed state is set when it is returned from the Axa and all other states are supposed to be open.
When the state is used as a trigger this will result in a unwanted trigger.
I do not know whether the changes I made are the correct ones but they seem to work.
I added:
  `#define AXA_OPEN 210   // 210 Unlocked`

and:
 `if (axa_status==AXA_OPEN)
  {
    axa_window->publish_state(COVER_OPEN);  // Only 210 will return OPEN
  }`

What I see now is that the state only changes when the window is really closed or opened.

Hi,
Thank you for your feedback! The code is written to give a state update every 30 (30000 millis) seconds. Even when you use the remote control, this will work. The mentioned behaviour I can not reproduce in my setup (as seen in my ESP LOG file):
[21:23:45][D][sensor:092]: 'Axa Window': Sending state 1.00000  with 0 decimals of accuracy
[21:24:15][D][espaxa:056]: 210 UnLocked-> 210
[21:24:15][D][sensor:092]: 'Axa Window': Sending state 1.00000  with 0 decimals of accuracy
[21:24:45][D][espaxa:056]: 210 UnLocked-> 210
[21:24:45][D][sensor:092]: 'Axa Window': Sending state 1.00000  with 0 decimals of accuracy
[21:25:15][D][espaxa:056]: 210 UnLocked-> 210
[21:25:16][D][sensor:092]: 'Axa Window': Sending state 1.00000  with 0 decimals of accuracy

It is possible to change the code so only a 'change in state' would be transmitted, but as I use no triggers on this state, this would not add functionality for me. But may be it can be useful for others.

Hi,
the 30 seconds state transmit is working like in your log and is working fiine.
I do not have a log that long but it seems there are more (other) states transmitted then 210 when the window is closed looking at the state changes on the device in HA when the window is closed:
 ` else
  {
    axa_window->publish_state(COVER_OPEN);  // if not AXA_CLOSED the window is supposed to be open
  }`

If that is the case then the state of the window is changed to open even if it is closed.
Transmitting only a state change reduces the amount of transmits but not the state itself.
But like you said, if you do not use the state for a trigger (using this to turn off the radiator I my case) this is a none issue ;-)

Thanks for the new version; still working really nice.


Implement unarmed combat

Adds a second loop for IAttack on the character if the item in hand doesn't have an IAttack component.
Currently it's using the same IAttack as MeleeWeaponComponent.

fixes #395

he merge he own pr
aboos!!!


Create the new Validator component

📚 Context
The server-manager, developed by the Machine Unit, is a central component in the node design, as it's responsible for handling critical tasks such as interfacing with the Cartesi Machine. For a long time, there were talks of transferring server-manager's ownership to the Node Unit, and this shared vision finally came to be due to the output unification effort.
Since server-manager is a huge C++ project, to better adapt it to the architecture envisioned for the 2.0 release, it will be rewritten as two separate components: Machine Runner (#258) and Validator. Machine Runner will be the new interface with the Cartesi Machine and the Validator will handle epochs, claims, and proofs.
✔ Solution
Create a new sub-package of node called validator with three sequential tasks: finalize epochs, generate proofs, and create claims.

Finalize epochs
Epochs will be simplified:

Epoch length will now be determined in terms of blocks instead of seconds, thus changing the node's CARTESI_EPOCH_DURATION parameter. The new default value will be 7200 blocks, equivalent to a day in a chain that generates new blocks after 12s.
If there were no inputs within this block interval, the epoch will be finished but no claim will be generated as there's nothing to prove.

Generate proofs
After an epoch is finished, it must generate the output proofs and update the outputs Merkle tree in the database accordingly.
Create claims
After the proofs are generated, it will create the epoch's claim, although it won't be responsible for sending it: that will still be the authority-claimer's job. Since it reads claims from Redis, it will be necessary to write the claims to Redis. And since we will eventually remove both Redis and the authority-claimer the goal is to create a second, temporary component with the single goal of watching the database for new claims and sending them to Redis. Then, when the time comes to remove the authority-claimer we will only need to delete this smaller component instead of altering the validator's code.

📈 Subtasks

[x] Define the models and interactions with the database
[ ] #369
[ ] Write the proof-generating code in Go
[ ] Implement the final Validator
[ ] Implement the "claim-relay"

After an initial discussion with the @cartesi/node-unit, we reached a consensus around the following database schema:

This might still change though, so it might be a good idea to check the original and more up-to-date diagram here.

Here is also a draft of a to-be-implemented API for the Validator to interact with the node's database:
type ValidatorRepository interface {
	// GetMostRecentBlock returns the number of the last finalized block
	// processed by InputReader
	GetMostRecentBlock(ctx context.Context) (uint64, error)
	// GetCurrentEpoch returns the current epoch
	GetCurrentEpoch(ctx context.Context) (*Epoch, error)
	// GetMachineStateHash returns the hash of the state of the Cartesi Machine after processing
	// the input at `inputIndex`
	GetMachineStateHash(ctx context.Context, inputIndex uint64) (hexutil.Bytes, error)
	// GetAllOutputsFromProcessedInputs returns all outputs produced by inputs
	// sent between `startBlock` and `endBlock` (inclusive).
	// If one or more inputs are still unprocessed,
	// it waits for its status to change until it times out
	GetAllOutputsFromProcessedInputs(
		ctx context.Context,
		startBlock uint64,
		endBlock uint64,
		timeout time.Duration,
	) ([]Output, error)
	// InitConfigTransaction performs a database transaction
	// containing two operations:
	//
	// 1. Inserts a new Epoch, starting at `inputBoxDeploymentBlock` and
	// ending at `inputBoxDeploymentBlock` + `epochDuration`
	//
	// 2. Updates the current epoch to the newly created Epoch
	//
	// This should only be called once to set up the first Epoch in the database.
	// All subsequent calls will do nothing or, if the parameters do not match
	// the values already stored, it will return an `InvalidNodeState` error
	SetupFirstEpochTransaction(
		ctx context.Context,
		inputBoxDeploymentBlock uint64,
		epochDuration uint64,
	) error
	// FinishEmptyEpochTransaction performs a database transaction
	// containing two operations:
	//
	// 	1. Inserts a new Epoch starting at `nextEpochStartBlock` and ending at
	//
	// 	2. Updates the current epoch to the newly inserted one
	FinishEmptyEpochTransaction(ctx context.Context, nextEpochStartBlock uint64) error
	// FinishEpochTransaction performs a database transaction
	// containing three operations:
	//
	// 	1. Inserts a new Epoch
	//
	// 	2. Updates the current epoch to the newly inserted one
	//
	// 	3. Inserts a new claim in a single transaction
	FinishEpochTransaction(ctx context.Context, nextEpochStartBlock uint64, claim *Claim) error
}

The Validator tasks will now be tracked by #375


📗 Add more examples to tutorial notebooks

Follow-up from #152. Current example notebooks are in the /examples folder, and can be run with Binder.
Topics that would be good to cover:

[x] Searching observations
[x] Previewing API results
[x] How raw observation data maps to the familiar iNaturalist.org web UI
[x] Viewing observation photos in Jupyter
[x] Basic observation visualizations (histograms, maps, etc.)
[x] Searching taxa
[ ] Searching projects
[ ] Authentication
[ ] Creating observations
[ ] Uploading photo & sound files
[ ] Updating observations

I think that's enough for this release. I'll follow up with more examples for the next release.


Updating VFXs

Is there a way to Update all the VFXs in a workspace at the same time, if not could that be added? Thanks

ok now it works, I had to do it manually a couple times 🤔


Refactor page interface

Summary
Closes #332
What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[ ] Feature
[ ] Code style update
[x] Refactor
[ ] Docs
[ ] Build-related changes
[ ] Other, please describe:

If changing the UI/CSS related code, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)

[x] Yes
[ ] No

If yes, please describe the impact and migration path for existing applications:

page.attributes.* are now page.*
page.attributes.injectMarkdownHeadings is now page.markdownHeadings, so that this feature is consistent with page.excerpt.
In saber-plugin-query-posts categories and tags are injected as page.categoriesInfo and page.tagsInfo because page.categories and page.tags are already used in front matter.

The PR fulfills these requirements:

[ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

[x] Chrome
[ ] Firefox
[ ] Safari
[ ] Edge
[ ] IE

If adding a new feature, the PR's description includes:

[ ] A convincing reason for adding this feature
[ ] Related documents have been updated
[ ] Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information:

In saber-plugin-query-posts categories and tags are injected as page.categoriesInfo and page.tagsInfo because page.categories and page.tags are already used in front matter.

This is actually a bad UX 🤔It seems using page.attributes is still better in some extent.

In saber-plugin-query-posts categories and tags are injected as page.categoriesInfo and page.tagsInfo because page.categories and page.tags are already used in front matter.

Hmm never mind, let's just use this approach for now, when we have #183 implemented we won't have to inject variables like this.

In saber-plugin-query-posts categories and tags are injected as page.categoriesInfo and page.tagsInfo because page.categories and page.tags are already used in front matter.

Yes for now I use the page.categoriesInfo and page.tagsInfo, let me know if you have better names.

If anyone wants to try this PR out, jsut re-install all your saber-related dependencies from @canary channel.


Reduced FOV

The same thing happens with OpenTPCast as with the official version and is much reported but is there a reason for the image in the HMD to have a  curved pinch at the sides with an odd blue halo at the edge? Doesn't appear when my Oculus is tethered in the normal way.
Can someone look into it and see if a fix is possible?

Unfortunately this is an issue with the HDMI transmitter that affects all versions of the TPCast and does not have a fix available for the foreseeable future.  There is no simple way that we've found to inspect or modify the firmware on the HDMI transmitter which would make any kind of fix non-trivial for most users to apply if someone was able to figure out a fix.


fix move s3 providers to fe-common to be accessible for jni reader

Proposed changes
Issue Number: close #xxx

run buildall

run buildall


Edition of "integration name" is not reflected for Camel Route

the file name is used in this field, when editing it, nothign is modified. Either the filenmae should be changed or this field can be removed/greyed out?

This was already fixed


Incomplete screenshots caused by margin and translate3d

There is a canvas element in the dom of my screenshot, because of the translate3d attribute, the screenshot of this element is incomplete when printing. After I change the translate3d attribute to left and top, the first screenshot is normal, but there is a problem in the second screenshot

I'm sorry, one of the pictures was missent


helm_resource: add a test for charts with multiple namespaces

Hello @nicksieger,
Please review the following commits I made in branch nicks/namespace-semantics:
61f98c54b6af50bf500893108c07bfadc76f334e (2022-06-27 18:15:49 -0400)
helm_resource: add a test for charts with multiple namespaces
Code review reminders, by giving a LGTM you attest that:

Commits are adequately tested
Code is easy to understand and conforms to style guides
Incomplete code is marked with TODOs
Code is suitably instrumented with logging and metrics

sorry, should have added a test for this in the first place, because the semantics are really subtle. This would have caught the bug in the other PR.

Thanks for this. Yeah, I pulled the PR and ran the test locally before merging. And the test workflow didn't get triggered on the other PR, is that because of a first-time or outside contributor?

eh, we should have had a test for it anyway, i meant to add one but must have forgotten.

sent you a separate pr for the outside contributor ci


Joining server over link directly at bot start might cause it not to recognize it.

Shouldn't be that bad, cause it fixes itself in the request.

Not a problem. Bot starts not so often

Not a problem. Bot starts not so often


export model ModuleNotFoundError: No module named 'bioimageio.core.build_spec

Hi,
I have trained a new model without problems. The export model notebook shows this ModuleNotFoundError but bioimageio.core is installed.
Best regards,
Kai

Which version do you have? The environment spec calls for:
  - bioimageio.core=0.5.11
  - bioimageio.spec=0.4.9

no there was a version possibly incompatible - now I have installed
bioimageio.core==0.5.11
bioimageio.spec==0.4.9
The ModulesNotFoundError is now
ModuleNotFoundError: No module named 'bioimageio.spec.model.v0_4.raw_nodes'; 'bioimageio.spec.model.v0_4' is not a package
I am using Windows 10

[autoreload of bioimageio.spec.dataset failed: Traceback (most recent call last):
File "c:\Users\kai\source\repos\instanseg.venv\lib\site-packages\IPython\extensions\autoreload.py", line 276, in check
superreload(m, reload, self.old_objects)
File "c:\Users\kai\source\repos\instanseg.venv\lib\site-packages\IPython\extensions\autoreload.py", line 475, in superreload
module = reload(module)
File "C:\Users\kai\python-310-11-64\lib\importlib_init_.py", line 169, in reload
_bootstrap._exec(spec, module)
File "", line 619, in exec
File "", line 883, in exec_module
File "", line 241, in call_with_frames_removed
File "c:\Users\kai\source\repos\instanseg.venv\lib\site-packages\bioimageio\spec\dataset_init.py", line 4, in
from . import converters, raw_nodes, schema, utils
File "c:\Users\kai\source\repos\instanseg.venv\lib\site-packages\bioimageio\spec\dataset\converters.py", line 3, in
from .v0_2.converters import *
ModuleNotFoundError: No module named 'bioimageio.spec.dataset.v0_2.converters'; 'bioimageio.spec.dataset.v0_2' is not a package
]
site.config.json: 6.61kiB [00:00, 6.43MiB/s]
c:\Users\kai\source\repos\instanseg.venv\lib\site-packages\bioimageio\spec\shared_resolve_source.py:471: UserWarning: Download (6609) does not have expected size (2308).
warnings.warn(f"Download ({t.n}) does not have expected size ({total_size}).")
collection.json: 235kiB [00:00, 78.4MiB/s]
c:\Users\kai\source\repos\instanseg.venv\lib\site-packages\bioimageio\spec\shared_resolve_source.py:471: UserWarning: Download (234788) does not have expected size (28539).
warnings.warn(f"Download ({t.n}) does not have expected size ({total_size}).")
[autoreload of bioimageio.spec.model failed: Traceback (most recent call last):
File "c:\Users\kai\source\repos\instanseg.venv\lib\site-packages\IPython\extensions\autoreload.py", line 276, in check
superreload(m, reload, self.old_objects)
File "c:\Users\kai\source\repos\instanseg.venv\lib\site-packages\IPython\extensions\autoreload.py", line 475, in superreload
module = reload(module)
File "C:\Users\kai\python-310-11-64\lib\importlib_init.py", line 169, in reload
_bootstrap._exec(spec, module)
File "", line 619, in _exec
File "", line 883, in exec_module
File "", line 241, in call_with_frames_removed
File "c:\Users\kai\source\repos\instanseg.venv\lib\site-packages\bioimageio\spec\model_init.py", line 4, in
from . import converters, raw_nodes, schema, utils
File "c:\Users\kai\source\repos\instanseg.venv\lib\site-packages\bioimageio\spec\model\converters.py", line 3, in
from .v0_4.converters import *
ModuleNotFoundError: No module named 'bioimageio.spec.model.v0_4.converters'; 'bioimageio.spec.model.v0_4' is not a package
]

Hmm, bit concerned by the two download warnings:
UserWarning: Download (6609) does not have expected size (2308).

and
UserWarning: Download (234788) does not have expected size (28539).

for site.config.json and collections.json, though I'm not sure what they correspond to

I will try to install in Linux/WSL

To use with QuPath, you will need a directory similar to the downloaded models:
brightfield_nuclei
├── brightfield_nuclei_README.md
├── cover.png
├── instanseg_postprocess.ijm
├── instanseg_preprocess.ijm
├── instanseg.pt
├── per_sample_scale_range.ijm
├── rdf.yaml
├── sample_input_0.tif
├── sample_output_0.tif
├── test-input.npy
└── test-output.npy

but at the very least you need a valid rdf.yaml and modelname.pt file in a directory. You can then add this directory to the "downloaded models directory" that you set in the instanseg extension, and they should be picked up (you may need to relaunch QuPath)

I have added the rdf.yaml from your brightfield_nuclei model to my model and this works (for now with cpu, I will try to solve the cuda problems).


Typo: Phsyical -> Physical

Also, removed unneeded/unterminated quote

@AnoopVasudavan - Please review the proposed changes.  Thanks

This is good to merge

#sign-off


Update kernel version to 4.9.5

$subject

Merged in https://github.com/wso2/product-is/pull/15961


"az ssh vm" error from WSL2

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az ssh vm Extension Name: ssh. Version: 1.1.3.
Errors:
Paste here the error message you have received. Make sure to remove all sensitive information,
such as user name, password, credential, subscription ID, etc.

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az ssh vm --prefer-private-ip -n {} -g {}

Expected Behavior
Environment Summary
Linux-<IP_ADDRESS>-microsoft-standard-WSL2-x86_64-with-glibc2.31, Ubuntu 20.04.6 LTS
Python 3.10.10
Installer: DEB

azure-cli 2.47.0

Extensions:
ssh 1.1.3

Dependencies:
msal 1.20.0
azure-mgmt-resource 22.0.0

Additional Context

@efremropelato Can you provide the debug log of cmdlet you are using.

@efremropelato We are still waiting for your response.

@efremropelato We will now proceed to close this thread as we haven't heard back. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


Is the order of migrations reliable?

AFAIK the order on wich migrations are executed is important and it's derived from lexicographical order of migration id. Since each migration id has a fixed length prefix with the timestamp, then the migrations are supposed to execute in that order.
But digging into the code, i've the suspect that there is no real guaranty about this order: in fact it appears to me that the migrations order relies on the order of insertion in a Dictionary.
https://github.com/aspnet/EntityFrameworkCore/blob/4f65388bf68312e16fe07e62f79d8fad4e242f2a/src/EFCore.Relational/Migrations/Internal/MigrationsAssembly.cs#L49-L73
but FCL documentation states:

For purposes of enumeration, each item in the dictionary is treated as a KeyValuePair<TKey,TValue> structure representing a value and its key. The order in which the items are returned is undefined.

Isn't better to replace
var result = new Dictionary<string, TypeInfo>();
with
var result = new SortedList<string, TypeInfo>();
IMHO the same issue arises where MigrationsAssembly.Migrations is used:
https://github.com/aspnet/EntityFrameworkCore/blob/4f65388bf68312e16fe07e62f79d8fad4e242f2a/src/EFCore.Relational/Migrations/Internal/Migrator.cs#L180-L234
here you can add an explicit .OrderBy(m => m.Key) also when calculating migrationsToApply
Thanks

Another thing is system culture settings, If someone in a team use a calendar other than Georgian, migration orders get mixed. I have created an issue about it (https://github.com/aspnet/EntityFrameworkCore/issues/12978)

Triage; putting this into 2.2 since we should be more robust here.


Fix buffer overflow in ulog and binlog

This should fix the buffer overflow reported here https://github.com/01org/mavlink-router/issues/97#issuecomment-312353368

Thank you, pull request merged! :octocat: Sent from GH.


Social icons links now working

Describe the bug
Hey, @MonalikaPatnaik it seems that the links of the social icons are not working. Please assign me this issue. I want to add links to it. Thank you!
Screenshort

Hey @sumitkr2000, We haven't created any social media accounts yet.
You can find other other issue Thanks :)

Atleast add the repo kf github in GitHub icon.

Atleast add the repo of github in GitHub icon.

Hey yess ..but it's been already assigned!

Okay cool ...i have raised other issues also...pleas assign me those


Auto close when spliting a window?

and how to auto open when switching to single window.

use autocmd.😂


Added error for IdentifierStart immediately after a NumericLiteral

Fixes #4702.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: JoshuaKGoldberg sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Lol, I worked for Microsoft for 3 1/2 years, and I get to sign the CLA again. Exciting.

😕 build failed on node8 and node10 for server timeouts. Will force push to start it again...


[Scaffold] Recovery Phrase Display

Closes #45
This PR has the needed elements to show the UI of the recovery phrase that the user needs to back up. Validation will be addressed in a following PR

This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes (e.g. fixing a spelling typo in documentation).  For more in-depth discussion of how we think about code review, please see Code Review Guidelines.
Author

[x] Self-review: Did you review your own code in GitHub's web interface? Code often looks different when reviewing the diff in a browser, making it easier to spot potential bugs.
[x] Does the code abide by the Coding Guidelines?
[x] Automated tests: Did you add appropriate automated tests for any code changes?
[ ] Code coverage: Did you check the code coverage report for the automated tests?  While we are not looking for perfect coverage, the tool can point out potential cases that have been missed.
[ ] Documentation: Did you update Docs as appropiate? (E.g README.md, etc.)
[ ] Run the app: Did you run the app and try the changes?
[x] Did you provide Screenshots of what the App looks like before and after your changes as part of the description of this PR? (only applicable to UI Changes)
[x] Rebase and squash: Did you pull in the latest changes from the main branch and squash your commits before assigning a reviewer? Having your code up to date and squashed will make it easier for others to review. Use best judgement when squashing commits, as some changes (such as refactoring) might be easier to review as a separate commit.

Reviewer

[ ] Checklist review: Did you go through the code with the Code Review Guidelines checklist?
[ ] Ad hoc review: Did you perform an ad hoc review?  In addition to a first pass using the code review guidelines, do a second pass using your best judgement and experience which may identify additional questions or comments. Research shows that code review is most effective when done in multiple passes, where reviewers look for different things through each pass.
[ ] Automated tests: Did you review the automated tests?
[ ] Manual tests: Did you review the manual tests?You will find manual testing guidelines under our manual testing section
[ ] How is Code Coverage affected by this PR? We encourage you to compare coverage before and after your changes and when possible, leave it in a better place. Learn More...
[ ] Documentation: Did you review Docs, README.md, LICENSE.md, and Architecture.md as appropriate?
[ ] Run the app: Did you run the app and try the changes? While the CI server runs the app to look for build failures or crashes, humans running the app are more likely to notice unexpected log messages, UI inconsistencies, or bad output data.

As a side note, I know this is early work, just wanted to point out that RecoveryPhraseDisplayStore doesn't have any tests that I can see, unless I missed something.

@adamstener thanks for bringing this up. I created two (rather vanilla) tests for the actions that this PR is implementing :)

This looks great @pacu!
Regarding the TCA I think it's looking really good! It's very concise. I tried to focus a lot of review on that, I put some inline comments/ suggestions there. One of them (adding the error type) is more of a style thing and something that will likely take more shape in future PRs so not immediately important. The other two are a bit more relevant 🙂.
One "General" comment which can also be addressed later, but just worth making a note of is that the chips can get truncated text if the words are long, especially on smaller devices. Attached a screenshot from "iPod Touch" below. (word 16 and 19 get truncated)

I specially spent time working on this :(.  Thanks for double checking. The chip should never truncate.

@dh-ecc I fixed the truncated chip.

Now chips may look ulgy as Hword but, the will never truncate


DOC: add docs to explain behaviour of newton's mehod on arrays

Reference issue

Fixes #12006
What does this implement/fix?

Add a small note explaining the behaviour of newton's method on arrays.

@tirthasheshpatel sorry I didn't see this when I marked gh-12006 for a sprint. I adjusted the clarification to stress more what newton is, a solver for single-valued functions of a single variable, rather than emphasizing what fprime/fprime2 are not. If it looks good to you; I'll go ahead and merge.

I adjusted the clarification to stress more what newton is, a solver for single-valued functions of a single variable, rather than emphasizing what fprime/fprime2 are not.

Thanks for the changes! They clarify that newton doesn't support multivariate problems, so, feel free to merge.

Thanks @tirthasheshpatel!


[Gardening] Fix typo.

Replaced homophone of presence ("presents", i.e. 🎁🎁, 🖥, etc.) with the word itself.

@swift-ci please smoke test