QI-Core Model Info File 4.1.1 EncounterProcedure issue

QI-Core Model Info File 4.1.1  contains the following snippet for EncounterProcedureExtension:
   <typeInfo xsi:type="ClassInfo" baseType="QICore.Extension" namespace="QICore" name="EncounterProcedureExtension" identifier=http://hl7.org/fhir/us/qicore/StructureDefinition/qicore-encounter-procedure label="EncounterProcedureExtension" retrievable="false">       <element name="type" elementType="System.Concept" target="FHIRHelpers.ToConcept(%parent.extension[url='type'].value)" description="type" definition="Whether the procedure was primary or secondary."/>       <element name="rank" elementType="System.Integer" target="%parent.extension[url='rank'].value.value" description="rank" definition="The ranking of the procedure within the encounter."/>       <element name="procedure" elementType="QICore.Reference" target="%parent.extension[url='procedure']" description="procedure" definition="A reference to the procedure that was performed."/>       <element name="url" elementType="System.String" target="%value.value" description="identifies the meaning of the extension" definition="Source of the definition for the extension code - a logical name or a URL." comment="The definition may point directly to a computable or human-readable definition of the extensibility codes, or it may be a logical URI as declared in some other specification. The definition SHALL be a URI for the Structure Definition defining the extension."/>    </typeInfo>
The target for the element 'procedure' is missing .value. In talking with @brynrhodes it should be
target="%parent.extension[url='procedure'].value"
This is impacting a CMS measure developer who is working on measures for Connectathon - refer to BONNIEMAT-1387.

Fixed in 2.7.0


balena-yocto-scripts: Update to v1.16.3

Update balena-yocto-scripts from v1.16.2 to v1.16.3
Change-type: patch
Changelog-entry: Update balena-yocto-scripts to v1.16.3
Signed-off-by: Alex Gonzalez<EMAIL_ADDRESS>

@balena-ci I self-certify!


Fixed Thermistor and Kelvin Sense Math (Again)

Changed the thermistor and kelvin sense code in RLCS to include math, added extra message type for thermistor voltage
Fixed conversion for thermistor resistance and temperature conversion
Here's what I did to test my changes:

Ran parse_themistor_kelvin (adc_value, 10, 4.096) with various voltage values and verified temp output against datasheet
Tested standard temp parse_thermistor_kelvin(833, 10,4.096)
Returned expected resistance of near 10000 ohms, and 25 degrees C

This change is

sources/rlcs/rlcs.py line 114 at r1 (raw file):

This doesn't have to be changed, since we are not taking any extra input from rlcs, just generating new data, through computation.

I assume you are referring to my comment above. I think it does need to be changed because that is describing the RLCS message format, and you can only update that if you are also updating the RLCS

This is a me skill issue. I had it explained by Kavin earlier.
What I am doing is taking in the same standard RLCS values and then making some new data on them through calculations before returning that data. So I don't need to change msg format, just add more fields to the dictionary res.
I have made these edits and returned msg format to how it was originally.


Force unsubscribe on NewsListFragment when SideNav is clicked

Will solve the problem of inconsistent news type when user clicks sidenav too quickly

Updated!


Generate SDKs and store them on GitHub pages.

We can use swagger-codegen to generate SDKs on Travis and store them on GitHub pages.

Out of scope


Test perl versions 5.24 and 5.26

Debian stretch ships with perl version 5.24, and would be helpful to include it (plus 5.26 for giggles) in the CI testing. Does this seem reasonable? I don't see any need to restore testing for 5.*-shrplib, but these would be helpful :)

I would like to avoid running too many jobs on Travis, it's a free service after all.
Also, if you want to test Debian compatibility, you need shrplib variant anyway, for threads and multiplicity.


NO-ISSUE: Synchronize From Upstream Repositories

Replaces #656
The staging/ and vendor/ directories have been synchronized from the upstream repositories, pulling in the following commits:

Date
Commit
Author
Message

2024-01-09 18:13:48
operator-framework/operator-lifecycle-manager@920a921
dependabot[bot]
build(deps): bump golang.org/x/crypto from 0.14.0 to 0.17.0 (#3134)

2024-01-10 15:10:12
operator-framework/operator-lifecycle-manager@2bdaa66
dependabot[bot]
build(deps): bump github.com/containerd/containerd from 1.7.6 to 1.7.11 (#3135)

2024-01-11 17:25:52
operator-framework/operator-lifecycle-manager@f94a5ed
Todd Short
Add finalizer for CSV cleanup (#3148)

2024-01-12 17:49:39
operator-framework/operator-lifecycle-manager@5299830
Todd Short
Fix Condition check for Reconcile InstallPlan status (#3153)

2024-01-15 21:59:17
operator-framework/operator-lifecycle-manager@134ccee
Todd Short
Update to k8s v0.28.5 and other operator-framework components (#3155)

2024-01-09 13:45:07
operator-framework/operator-registry@cad0992
Joe Lanford
enable dependabot (#1178)

2024-01-09 22:14:48
operator-framework/operator-registry@fbc153c
dependabot[bot]
build(deps): bump actions/setup-go from 4 to 5 (#1183)

2024-01-09 22:17:31
operator-framework/operator-registry@60193c4
dependabot[bot]
build(deps): bump github.com/h2non/filetype from 1.1.1 to 1.1.3 (#1185)

2024-01-09 22:20:18
operator-framework/operator-registry@f4631ff
dependabot[bot]
build(deps): bump github.com/containerd/containerd from 1.7.6 to 1.7.11 (#1188)

2024-01-10 03:31:16
operator-framework/operator-registry@15c1a29
dependabot[bot]
build(deps): bump docker/login-action from 1 to 3 (#1192)

2024-01-10 03:36:27
operator-framework/operator-registry@c24ff15
dependabot[bot]
build(deps): bump actions/checkout from 3 to 4 (#1180)

2024-01-10 03:39:13
operator-framework/operator-registry@e4cb1ab
dependabot[bot]
build(deps): bump google.golang.org/grpc from 1.59.0 to 1.60.1 (#1186)

2024-01-10 12:54:46
operator-framework/operator-registry@631f2d9
dependabot[bot]
build(deps): bump sigs.k8s.io/yaml from 1.3.0 to 1.4.0 (#1187)

2024-01-10 12:57:30
operator-framework/operator-registry@4ad2d1c
dependabot[bot]
build(deps): bump github.com/golang-migrate/migrate/v4 (#1191)

2024-01-10 13:08:33
operator-framework/operator-registry@9446132
dependabot[bot]
build(deps): bump golang.org/x/net from 0.19.0 to 0.20.0 (#1190)

2024-01-10 13:27:46
operator-framework/operator-registry@588aab9
P. Radha Krishna
Update k8s dependencies to v0.28.5 (#1176)

2024-01-10 13:30:32
operator-framework/operator-registry@e8dbf24
dependabot[bot]
build(deps): bump docker/setup-qemu-action from 1 to 3 (#1181)

2024-01-10 13:47:01
operator-framework/operator-registry@6fd8cec
Joe Lanford
build(deps): bump actions/{download,upload}-artifact to v4 (#1193)

2024-01-10 15:34:16
operator-framework/operator-registry@087f3c5
Adam Cornett
updating operator-framework/api dependency which has k8s 1.28 changes (#1189)

2024-01-11 12:54:08
operator-framework/operator-registry@ecac387
dependabot[bot]
build(deps): bump github.com/mattn/go-sqlite3 from 1.14.17 to 1.14.19 (#1195)

2024-01-11 12:56:52
operator-framework/operator-registry@d3d17db
dependabot[bot]
build(deps): bump github.com/otiai10/copy from 1.2.0 to 1.14.0 (#1194)

2024-01-11 12:59:38
operator-framework/operator-registry@2794ce2
dependabot[bot]
build(deps): bump go.etcd.io/bbolt from 1.3.7 to 1.3.8 (#1196)

2024-01-11 15:58:29
operator-framework/operator-registry@b6f9cce
dependabot[bot]
build(deps): bump github.com/grpc-ecosystem/grpc-health-probe (#1197)

2024-01-11 16:45:09
operator-framework/operator-registry@8c11264
dependabot[bot]
build(deps): bump github.com/onsi/ginkgo/v2 from 2.12.0 to 2.13.2 (#1198)

2024-01-12 17:02:12
operator-framework/operator-registry@64ccd02
dependabot[bot]
build(deps): bump github.com/containers/common from 0.56.0 to 0.57.1 (#1200)

2024-01-09 18:04:31
operator-framework/api@9ffba44
Adam Cornett
k8s 1.28 version update and go 1.20 (#292)

2024-01-10 14:20:01
operator-framework/api@0d032b9
Joe Lanford
[chore]: Re-bump opentelemetry to v1.20.0 (#310)

2024-01-10 14:28:16
operator-framework/api@e6998ff
Jose R. Gonzalez
Catch whitespace csv.spec.provider.name values (#272)

This pull request is expected to merge without any human intervention. If tests are failing here, changes must land upstream to fix any issues so that future downstreaming efforts succeed.
/cc @openshift/openshift-team-operator-runtime
/cc @openshift/openshift-team-operator-ecosystem

/lgtm

This test is failing pretty consistently, AFAICT, it's not hitting the actual test yet (i.e. cluster startup failure)?
/test e2e-upgrade


Not reliably loading images

Hi. I love the effect this plugin achieves, but I find that occasionally my site will load but only the blurry placeholder will be displayed - even for those images in the viewport- until I commence a scroll. I’d say this occurs on 5% of page loads while the rest of the time the images visible in the viewport will automatically fade into view without a page scroll being required. How to fix this?

Do you have an example page?
Is it consistently failing in those 5% of pages?
Does it happen in all browsers? What browser are you using?

Closing. No information.


[IM] Return resource exhausted for too large attributes

Problem

Fixes #14566
If no attribute and event data encoded successfully, we should send status report instead of drop out

Change overview

Changed. the behavior to: If one attribute is too large to be encoded into the response, encode a "Resource Exhausted" status code

Testing

Updated the test for the case of list chunking and the case of atomic attribute, to ensure that we won't run into infinity loop when building reports.

So #15222 did not fix this?


Performance improvements

I want to fix any performance problems caused by the autoloader provided here or other items in this codebase.

The call to \mglaman\PHPStanDrupal\Drupal\DrupalAutoloader::register takes about 1.62s. This isn't horrible, but it adds up. The main caller is to Symfony\Component\Yaml\Yaml::parseFile. That is due to needing to parse all discovered services.yml files
https://github.com/mglaman/phpstan-drupal/blob/main/src/Drupal/DrupalAutoloader.php#L152-L153
It doesn't seem like much on a small scan, though.

The BrowserTestBaseDefaultThemeRule is performance hit:

I just ran against the action module with:
blackfire run php vendor/bin/phpstan.phar analyze --configuration core/phpstan-partial.neon --debug core/modules/action

The calls to getAncestorWithClassName are a major hit. This was fixed in https://github.com/mglaman/phpstan-drupal/pull/312. Needs re-profiling to see if it helped.

Tested on 1.1.10. Not much of a difference as the time just moved to isSuperTypeOf.

There isn't an easy way to handle this:
        $browserTestBaseType = new ObjectType('Drupal\\Tests\\BrowserTestBase');
        if (!$browserTestBaseType->isSuperTypeOf($classType)->yes()) {
            return [];
        }

Maybe PHPStan has some optimizations for a quick check with this.

Here is another profile: https://blackfire.io/profiles/b32d0300-5874-43d0-8afb-664ff944497b/graph
Off of dev-main against the Node module.
blackfire run --ignore-exit-status php vendor/bin/phpstan analyze --debug -c core/phpstan-partial.neon core/modules/node


ndarray improvements

Changes:

Bump ndarray. This is needed because the current 0.13.x version that we are using is not compatible with projects using the more modern 0.15.x versions, and interop between arrays from different versions of the library will fail in confusing ways
Implement From<ArrayBase<S, D>> for Robj ie conversion from any ndarray to an Robj, with tests

Outstanding questions:

How can we actually compare R objects in Rust? My tests are failing I assume because the pointers are not the same, even though the string representation seems identical
Why do the arrays created using R! not have any classes set when I a.get_attrib(class_symbol())?

You'll probably have to test for equality of each individual element, just like the other tests in the same source file.

Oh is that why all the other tests did that. Is there any discussion about implementing a PartialEq for Robj against Robj that compares by value?

Is there any discussion about implementing a PartialEq for Robj against Robj that compares by value?

I can't find any. My guess is that Robj is basically a pointer to a data owned by R, so the comparison is done in pointer-level. But I agree it's handy if we can compare by value somehow.

I can't find any. My guess is that Robj is basically a pointer to a data owned by R, so the comparison is done in pointer-level. But I agree it's handy if we can compare by value somehow.

Well I'll open an issue for it. Surely the R API has a way to compare by value? Or if not we can just write comparison functions like I have done here for vectors/arrays

Thanks, I think we need to write it by ourselves.

Turns out I'm wrong, actually. We're using the R_compute_identical API function in our implementation: https://github.com/extendr/extendr/blob/a06962c7e42e97bdc078a2ed4e4a47b54749f5d1/extendr-api/src/robj/mod.rs#L956-L967
And this function quite neatly compares all aspects of any Robj by value:
https://github.com/SurajGupta/r-source/blob/a28e609e72ed7c47f6ddfbb86c85279a0750f0b7/src/main/identical.c#L86
I think my code was not working with this function only because the attribute lists were different (which I still don't understand).

Oh, I didn't notice it, sorry.

@andy-thomason @clauswilke @Ilia-Kosenkov
Though I'm not familiar with the implementation around ndarray, this pull request basically looks good to me. We might need to tweak some implementation in association with the ongoing changes on conversions, but I expect this won't be a burden as the implementation is simple. Any major concerns?

I agree.

I just pushed a refactor, it should be much cleaner now.
Other than what is being discussed in the review, I'd appreciate review on:

The way that I'm cloning the data before conversion to R. Is that correct?
The way that I'm handling memory layouts. It occurred to me that since ndarray supports both C and F layouts, while R supports only F (I think?), there needed to be some kind of handling. I've since implemented this with a test, but it's doing my head in and I would appreciate someone double checking that I've done this correctly

@multimeric,
I enabled CI for you so you can test your changes en masse.

@multimeric

The way that I'm cloning the data before conversion to R. Is that correct?

I can answer this. We have recently devised some ground rules on how to handle the marshaling of R objects into Rust, starting with R vectors (not arrays of dim 1 though). As a result, the way we handle arrays will likely change in the future, but for now, I believe, any reasonably working solution will do fine.

Do we approve of using as i32 to convert between usize and i32? I gather that it truncates so that if we have a dimension that's too long to represent as an i32 then it will just fail silently and instead return the maximum i32 value.

I am not really familiar with ndarray, but I assume you are talking about converting array dimensions to i32 used to set dim.
I do not like such unchecked casts, if a Rust array is 'too large', I doubt R can handle it correctly anyway, so overflowing casts should just fail.
I suggest to at least leave a comment in the code mentioning this issue.

I am not really familiar with ndarray, but I assume you are talking about converting array dimensions to i32 used to set dim.
I do not like such unchecked casts, if a Rust array is 'too large', I doubt R can handle it correctly anyway, so overflowing casts should just fail.

Okay, I've changed this such that it will panic in this (rare) scenario. I could also change it to throw an error, but then we would have to implement TryFrom instead of From, but I don't think any other conversions do this?

Okay, I've changed this such that it will panic in this (rare) scenario. I could also change it to return an error, but then we would have to implement TryFrom instead of From, but I don't think any other conversions do this?

We're moving to TryFrom throughout to exactly avoid these kinds of issues. We're just not there yet, you caught us in the middle of this transition. I don't like random panics or unexpected data corruption, even if extremely rare.

If there's another branch I should target in order to use TryFrom, I happily will.

Therefore, I would suggest moving to TryFrom now rather than leaving the code half-finished and hoping somebody will fix it later. It'll cause 100x more pain later on, when people are actually using the API and experience breaking changes.

No, development is happening in master.

Okay. Do we have some kind of error scheme I should be following? Just strings?

Okay. Do we have some kind of error scheme I should be following? Just strings?

I think this is the one
https://github.com/extendr/extendr/blob/master/extendr-api/src/error.rs

Okay. Do I just add new errors to that enum? Because the kind of errors I expect are like "axis too long", and whatever kind of error set_attrib returns.

Maybe just use Other with a string? Since this is going to be an extremely rare and obscure error, I'm not sure it needs its own type.

Other with a string is probably preferable because this may be reworked in the nearest future (not entirely, of course), and other Error types may emerge. I am not entirely sure about the usage of the word axis though, perhaps array dimension?
Coming from R, I'd expect to receive "axis too long" when making plots, not when dealing with arrays.

Done.

LGTM, but I'd like to suggest to test one other edge case -- 'empty' arrays. As far as I can see, we have no such tests.
I propose something like matrix(integer(), nrow = 10), which actually produces an empty matrix.
I believe it is a valid use case as R matrix can be sliced into such 'empty' object.
PS: I was under the impression the CI will continue working after I approved it once, but it seems it requires manual triggering for now.

I believe CI needs to be approved manually until somebody has made at least one accepted contribution to a repo: https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks
It doesn't say so in the github docs, but I believe this is primarily to prevent cryptocurrency mining via github actions.

I'm re-running the tests. Not clear to me why OSX is failing.

The OSX failure has persisted for a while now. Maybe @yutannihilation knows what's going on?

Only the MacOS test is failing but I don't think it's due to my PR?

CRAN sometimes incorrectly distributes R binaries/sources,  especially devel ones. In our case, it fails at the R installation step with an HTTP 404 error while trying to download the newest version, which is pretty much self-explanatory :)
We can ignore this failure for now as there seem to be no other issues on other platforms, including macOS.

The OSX failure has persisted for a while now. Maybe @yutannihilation knows what's going on?

No idea, but let's ignore.
Error: Failed to get R devel: Failed to get R devel: Failed to download version devel: Error: Unexpected HTTP response: 404

First, I'd recommend to update the CHANGELOG.md

Done.
I also got some helpful comments from one of the ndarray devs here: https://github.com/rust-ndarray/ndarray/issues/1060 which I used to inform a slight optimisation.

Second, if you feel like doing some R coding, it could be nice to have some array tests in tests/extendrtests. This package showcases extendr features (and also tests them), so having, say, a Rust function that accepts two matrices, multiplies them, and then returns the product back to R would be nice. This is a topic for a separate PR and can be implemented by someone else.

Sounds good, but yes I would rather leave this to another PR.

@multimeric,
Seems all is good, thank you for your contribution. I am merging now.

Hooray! Thanks for the merge. I look forward to the next major release.


Safari Keyboard Shortcut Issue

Before opening the issue, have you...?

[X] Searched for existing issues
[X] Looked through the wiki
[X] Updated MonitorControl to the latest version (if applicable)

Describe the bug
In Safari, "command 0” shortcut for scaling change is not working when monitor control is turn on.
Upon using the app shortcutdetective to test, monitor control is receiving keyboard shortcuts. And turning monitor control off resolves the issue.
Steps to reproduce
Open any webpage on Safari, use "command +” or "command -” to zoom in or out the page. Then use "command 0” to set to default 100% scaling.
Expected behavior
Press "command 0” would roll back to the default 100% scaling.
Anything else?
For Anyone who also runs into this, here are a few workarounds.
— Directly click the menu item in Safari, “View” -> “Actual Size”
— Directly click preferece icon in the toolbar (gear icon) and select 100% in page zoom
— In System Preferences, set up a new keyboard shortcut for “Actual Size” in the “App Shortcuts” in ” Keyboard" under “Shortcuts.” Apple has instructions on this one.
Environment Information (please complete the following information)
- macOS version: Monterey 12.4
- Mac model: MacBook Air M1
- MonitorControl version:4.1.0
- Monitor(s): LG 27UN850-W
- Apple Silicon/M1 (yes or no): yes

I cannot seem to reproduce this one. Are sure there is no custom shortcut defined for Command+0 somehow? Are you using native keys for control?

Yah, I checked with shortcutdetective (it shows monitor control is receive the shortcuts when I use command+0 in safari) and I also turned off all the programs and tested one by one. Only upon closing monitor control, the shortcut command+0 would then work.
It is not pressing issue though.

With a fresh installation, it is fixed.
It was showing problems before with the autoupdated latest version (Version 4.2.0 Build 7048) but with a reinstallation it was fixed. Perhaps it was the helper not being installed correctly before, but that is just speculation.


Indexing finished with fatal error

I was trying to open magento2 in VSCode. After longer time output was filled with fatal error:
PHP Fatal error:  Maximum function nesting level of '256' reached, aborting! in /home/wywrzal/git/vscode-php-intellisense/vendor/nikic/php-parser/lib/PhpParser/NodeAbstract.php on line 75
PHP Stack trace:
PHP   1. {main}() /home/wywrzal/git/vscode-php-intellisense/vendor/felixfbecker/language-server/bin/php-language-server.php:0
PHP   2. Sabre\Event\Loop\run() /home/wywrzal/git/vscode-php-intellisense/vendor/felixfbecker/language-server/bin/php-language-server.php:33
PHP   3. Sabre\Event\Loop\Loop->run() /home/wywrzal/git/vscode-php-intellisense/vendor/sabre/event/lib/Loop/functions.php:122
PHP   4. Sabre\Event\Loop\Loop->tick($block = *uninitialized*) /home/wywrzal/git/vscode-php-intellisense/vendor/sabre/event/lib/Loop/Loop.php:194
PHP   5. Sabre\Event\Loop\Loop->runTimers() /home/wywrzal/git/vscode-php-intellisense/vendor/sabre/event/lib/Loop/Loop.php:216
PHP   6. LanguageServer\LanguageServer->LanguageServer\{closure}() /home/wywrzal/git/vscode-php-intellisense/vendor/sabre/event/lib/Loop/Loop.php:280
PHP   7. LanguageServer\PhpDocument->updateContent($content = *uninitialized*) /home/wywrzal/git/php-language-server/src/LanguageServer.php:153
PHP   8. LanguageServer\PhpDocument->parse() /home/wywrzal/git/php-language-server/src/PhpDocument.php:61
PHP   9. PhpParser\NodeTraverser->traverse($nodes = *uninitialized*) /home/wywrzal/git/php-language-server/src/PhpDocument.php:106
PHP  10. PhpParser\NodeTraverser->traverseArray($nodes = *uninitialized*) /home/wywrzal/git/vscode-php-intellisense/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:64
PHP  11. PhpParser\NodeTraverser->traverseNode($node = *uninitialized*) /home/wywrzal/git/vscode-php-intellisense/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:135
...

Apparently PHPParser works recursively and reaches maximum function nesting level. I think this can be set through ini_set or similar at runtime.
Would be nice to have some integration tests parsing popular PHP frameworks

Problem is releated to xdebug, without it magento2 indexing works ok. Problem will be solved when removing xdebug from ini file will be ready.

xdebug.max_nesting_level
Type: integer, Default value: 256
Controls the protection mechanism for infinite recursion protection. The value of this setting is the maximum level of nested functions that are allowed before the script will be aborted.
Before Xdebug 2.3, the default value was 100.

Also mentioned in the PHPParser docs:
https://github.com/nikic/PHP-Parser/blob/master/doc/2_Usage_of_basic_components.markdown#bootstrapping


Handling of optional bias

Hello,
Following https://github.com/LaurentMazare/tch-rs/pull/420 the type and device conversion of var stores (or sub-paths of it) seem to be working properly, and I managed to run a few models in fp16 mode with this new feature.
I encountered one issue with the linear layers when the bias was set to false. The current implementation then creates an internal Tensor of zeroes (which is not registered to the provided path) and adds it to the output of the weights-input matrix multiplication. This breaks when converting between type sand devices because the "dummy" bias tensor does not get converted (not registered in the var store).
I updated my local copy of tch-rs to make the bias truly optional (and avoid a dummy operation when set to false), along the lines of:
/// A linear fully-connected layer.
#[derive(Debug)]
pub struct Linear {
    pub ws: Tensor,
    pub bs: Option<Tensor>,
}

/// Creates a new linear layer.
pub fn linear<'a, T: Borrow<super::Path<'a>>>(
    vs: T,
    in_dim: i64,
    out_dim: i64,
    c: LinearConfig,
) -> Linear {
    let vs = vs.borrow();
    let bs = if c.bias {
        let bs_init = c.bs_init.unwrap_or_else(|| {
            let bound = 1.0 / (in_dim as f64).sqrt();
            super::Init::Uniform {
                lo: -bound,
                up: bound,
            }
        });
        Some(vs.var("bias", &[out_dim], bs_init))
    } else {
        None
    };

    Linear {
        ws: vs.var("weight", &[out_dim, in_dim], c.ws_init),
        bs,
    }
}

impl super::module::Module for Linear {
    fn forward(&self, xs: &Tensor) -> Tensor {
        if let Some(bias) = &self.bs {
            xs.matmul(&self.ws.tr()) + bias
        } else {
            xs.matmul(&self.ws.tr())
        }
    }
}

I believe this is closer to the C++ implementation and to the Conv block defined in this crate.
I'd be happy to contribute these changes back - but I wanted to check with you beforehand as this would cause breaking changes for dependents manipulating the bias field in Linear directly. Unfortunately, registering the bias field to the var store would solve the issue without causing breaking change, but would raise errors when loading weight files where this "dummy" bias is not saved.

Hi, indeed that's an interesting point. I think we should proceed with your changes and bump the version on the next release to signal the breaking change. It feels that anyway dependents manipulating the bias in the case where it would not be saved/used  by the optimizer etc are likely to hit some unexpected behavior.


ORA inputs to workflows (TN) require a --ora-reference input

If fastq-list-rows are used and read1 or read2 exit, user must specify --ora-reference which is a directory.
If --ora-reference is specified on the CLI, script must first extract the reference directory into the scratch space, much like what is done for the current reference tar.

Resolved for TN, might want to add it in for WTS / dragen alignment pipelines though


Invoke-WebRequest and Invoke-RestMethod do not support invalid HTTPS certificates

On Windows, I was able to connect to HTTPS endpoints with invalid certificates by setting a certificate policy via System.Net.ServicePointManager to ignore invalid certificates.
An integrated way to ignore invalid certificates with Invoke-RestMethod and Invoke-WebMethod would simplify implementing this cross platform.
When I run the same on Mac OS X, I get several errors regarding .NET dependencies. How can Invoke-RestMethod and Invoke-WebMethod be configured to ignore invalid certificates?
Steps to reproduce
add-type @"
using System.Net;
using System.Security.Cryptography.X509Certificates;
public class TrustAllCertsPolicy : ICertificatePolicy {
    public bool CheckValidationResult(
        ServicePoint srvPoint, X509Certificate certificate,
        WebRequest request, int certificateProblem) {
            return true;
        }
 }
"@
[System.Net.ServicePointManager]::CertificatePolicy = New-Object TrustAllCertsPolicy
Invoke-WebRequest https://expired.badssl.com/

Expected behavior
This is from Windows Server 2008R2 with PowerShell 5:
PS C:\>             add-type @"
>>                     using System.Net;
>>                     using System.Security.Cryptography.X509Certificates;
>>                     public class TrustAllCertsPolicy : ICertificatePolicy {
>>                        public bool CheckValidationResult(
>>                             ServicePoint srvPoint, X509Certificate certificate,
>>                             WebRequest request, int certificateProblem) {
>>                             return true;
>>                         }
>>                     }
>> "@
>>
PS C:\> [System.Net.ServicePointManager]::CertificatePolicy = New-Object TrustAllCertsPolicy
PS C:\> Invoke-WebRequest https://expired.badssl.com/

StatusCode        : 200
StatusDescription : OK
Content           : <!DOCTYPE html>
                    <html>
                    <head>
                      <meta name="viewport" content="width=device-width, initial-scale=1">
                      <link rel="shortcut icon" href="/icons/favicon-red.ico"/>
                      <link rel="apple-touch-icon" href="/i...
RawContent        : HTTP/1.1 200 OK
                    Connection: keep-alive
                    Accept-Ranges: bytes
                    Content-Length: 469
                    Cache-Control: no-store
                    Content-Type: text/html
                    Date: Fri, 19 Aug 2016 08:36:02 GMT
                    ETag: "57b263a4-1d5"
                    Last-Mo...
Forms             : {}
Headers           : {[Connection, keep-alive], [Accept-Ranges, bytes], [Content-Length, 469], [Cache-Control,
                    no-store]...}
Images            : {}
InputFields       : {}
Links             : {}
ParsedHtml        : mshtml.HTMLDocumentClass
RawContentLength  : 469

Actual behavior
PS /Users/ffeldhaus>             add-type @"                                                                                >>                     using System.Net;                                                                                >>                     using System.Security.Cryptography.X509Certificates;                                                                                >>                     public class TrustAllCertsPolicy : ICertificatePolicy {                                                                                >>                        public bool CheckValidationResult(                                                                                >>                             ServicePoint srvPoint, X509Certificate certificate,                                                                                >>                             WebRequest request, int certificateProblem) {                                                                                >>                             return true;                                                                                >>                         }                                                                                >>                     }                                                                                >> "@
add-type : (2) : The type or namespace name 'X509Certificates' does not exist in the namespace 'System.Security.Cryptography' (are you missing an assembly reference?)
(1) :                     using System.Net;
(2) : >>>                     using System.Security.Cryptography.X509Certificates;
(3) :                     public class TrustAllCertsPolicy : ICertificatePolicy {
At line:1 char:13
+             add-type @"
+             ~~~~~~~~~~~
    + CategoryInfo          : InvalidData: (Microsoft.Power...peCompilerError:AddTypeCompilerError) [Add-Type], Exception
    + FullyQualifiedErrorId : SOURCE_CODE_ERROR,Microsoft.PowerShell.Commands.AddTypeCommand

add-type : (3) : The type or namespace name 'ICertificatePolicy' could not be found (are you missing a using directive or an assembly reference?)
(2) :                     using System.Security.Cryptography.X509Certificates;
(3) : >>>                     public class TrustAllCertsPolicy : ICertificatePolicy {
(4) :                        public bool CheckValidationResult(
At line:1 char:13
+             add-type @"
+             ~~~~~~~~~~~
    + CategoryInfo          : InvalidData: (Microsoft.Power...peCompilerError:AddTypeCompilerError) [Add-Type], Exception
    + FullyQualifiedErrorId : SOURCE_CODE_ERROR,Microsoft.PowerShell.Commands.AddTypeCommand

add-type : (5) : The type or namespace name 'ServicePoint' could not be found (are you missing a using directive or an assembly reference?)
(4) :                        public bool CheckValidationResult(
(5) : >>>                             ServicePoint srvPoint, X509Certificate certificate,
(6) :                             WebRequest request, int certificateProblem) {
At line:1 char:13
+             add-type @"
+             ~~~~~~~~~~~
    + CategoryInfo          : InvalidData: (Microsoft.Power...peCompilerError:AddTypeCompilerError) [Add-Type], Exception
    + FullyQualifiedErrorId : SOURCE_CODE_ERROR,Microsoft.PowerShell.Commands.AddTypeCommand

add-type : (5) : The type or namespace name 'X509Certificate' could not be found (are you missing a using directive or an assembly reference?)
(4) :                        public bool CheckValidationResult(
(5) : >>>                             ServicePoint srvPoint, X509Certificate certificate,
(6) :                             WebRequest request, int certificateProblem) {
At line:1 char:13
+             add-type @"
+             ~~~~~~~~~~~
    + CategoryInfo          : InvalidData: (Microsoft.Power...peCompilerError:AddTypeCompilerError) [Add-Type], Exception
    + FullyQualifiedErrorId : SOURCE_CODE_ERROR,Microsoft.PowerShell.Commands.AddTypeCommand

add-type : (6) : The type or namespace name 'WebRequest' could not be found (are you missing a using directive or an assembly reference?)
(5) :                             ServicePoint srvPoint, X509Certificate certificate,
(6) : >>>                             WebRequest request, int certificateProblem) {
(7) :                             return true;
At line:1 char:13
+             add-type @"
+             ~~~~~~~~~~~
    + CategoryInfo          : InvalidData: (Microsoft.Power...peCompilerError:AddTypeCompilerError) [Add-Type], Exception
    + FullyQualifiedErrorId : SOURCE_CODE_ERROR,Microsoft.PowerShell.Commands.AddTypeCommand

add-type : Cannot add type. Compilation errors occurred.
At line:1 char:13
+             add-type @"
+             ~~~~~~~~~~~
    + CategoryInfo          : InvalidData: (:) [Add-Type], InvalidOperationException
    + FullyQualifiedErrorId : COMPILER_ERRORS,Microsoft.PowerShell.Commands.AddTypeCommand
PS /Users/ffeldhaus> [System.Net.ServicePointManager]::CertificatePolicy = New-Object TrustAllCertsPolicy
Unable to find type [System.Net.ServicePointManager].
At line:1 char:1
+ [System.Net.ServicePointManager]::CertificatePolicy = New-Object Trus ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: (System.Net.ServicePointManager:TypeName) [], RuntimeException
    + FullyQualifiedErrorId : TypeNotFound

PS /Users/ffeldhaus> Invoke-WebRequest https://expired.badssl.com/
Invoke-WebRequest : An error occurred while sending the request.
At line:1 char:1
+ Invoke-WebRequest https://expired.badssl.com/
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: (Method: GET, Re...rShell/6.0.0
}:HttpRequestMessage) [Invoke-WebRequest], HttpRequestException
    + FullyQualifiedErrorId : WebCmdletWebResponseException,Microsoft.PowerShell.Commands.InvokeWebRequestCommand

Environment data

Name                           Value
----                           -----
PSVersion                      6.0.0-alpha
PSEdition                      Core
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   <IP_ADDRESS>
GitCommitId                    v6.0.0-alpha.9
CLRVersion
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

Trusting self signed certifciates can be achieved in Mac OS X by adding them to the Mac OS X keychain (e.g. by opening the URI with Safari and always trusting the certificate) and restarting powershell. Then Invoke-RestMethod and Invoke-WebRequest will accept the certificate as trusted.

This isn't a question of trusting certificates. This is a question of getting/posting something even though you don't trust the certificate.

It would nice to have some a parameter like -IgnoreCertificateCheck which would be similar to wget's --no-check-certificate then also having a $IgnoreCertificateCheckPreference which can default to $false but still allows people to change it.

I'm not sure about the implementation details of Invoke-RestMethod and Invoke-WebRequest, but if they are using .NET functionality, then a -IgnoreCertificateCheck parameter could probably be implement using ServerCertificateCustomValidationCallback.  This Gist has an example of using ServerCertificateCustomValidationCallback to suppress certificate checks.

Let's PLEASE have a skip SSL verification switch at last! Nobody likes dealing with certs in development.

I created pull request #2006 to implement the -IgnoreCertificateCheck switch parameter. It does not yet support a $IgnoreCertificateCheckPreference variable, but that could be added.
This also requires libcurl to be build against openssl. See https://github.com/dotnet/corefx/issues/9728 for details and instructions how to build curl against openssl.

Please implement pull request #2006 This is critical functionality for internal API access to systems.

This needs to be done right -- not with a -IgnoreAllSSLErrors switch...
P.S. for those who need something right now you can use my TunableSSLValidator module

As pull request #2006 is now merged, I'm closing the issue. The functionality (e.g. -SkipCertificateCheck switch) is now similar to that offered via curl and other standard tools.

This is needed for those wanting to use MSRC's "SecurityUpdates" Module through a Proxy.

Which cacerts (approved CA Root) list does Invoke-WebRequest use? I have a curl request which works fine in bash on CentOS 7 but failed in pwsh with Invoke-WebRequest. It would seem PowerShell is not respecting the system's setup in /etc/pki/ca-trust/source/anchors.

My bad, it does respect them. I had copied the .cer files to the anchors directory but forgotten to run sudo update-ca-trust extract.

I have the same issue on Centos
PS /root/>   Add-Type -TypeDefinition @"

using System.Net;
using System.Security.Cryptography.X509Certificates;
public class TrustAllCertsPolicy : ICertificatePolicy {
  public bool CheckValidationResult(
  ServicePoint srvPoint, X509Certificate certificate,
  WebRequest request, int certificateProblem) {
    return true;
  }
}

"@
Add-Type: (3,40): error CS0246: The type or namespace name 'ICertificatePolicy' could not be found (are you missing a using directive or an assembly reference?)
public class TrustAllCertsPolicy : ICertificatePolicy {
^

Add-Type: Cannot add type. Compilation errors occurred.
PS /root/>
PS /root/> [System.Net.ServicePointManager]::CertificatePolicy = New-Object -TypeName TrustAllCertsPolicy
New-Object: Cannot find type [TrustAllCertsPolicy]: verify that the assembly containing this type is loaded.


Some feedback/suggestions

I was playing with your library and it seems nice. A few things that i found so far.

The list functions do not exists on the objects. This makes the sample on the readme incorrect
I think it's better to use the example with ca_content as this does not require a extra file
Add a option to ignore certificate. This should not be used in production but can be helpful during testing.
Adding the pypi packagename to the readme

Thanks for all the hard work.

Good morning, afternoon, or evening!

The list functions do not exists on the objects. This makes the sample on the readme incorrect

If you're referring to the alias object in list_output = alias.list() then the issue is that alias is actually a poorly named reference to opnsense.firewall.alias_controller.
In hindsight I should have done something like this in the readme: alias_controller = opnsense.firewall.alias_controller

I think it's better to use the example with ca_content as this does not require a extra file

I had documented the file since CA certs are verbose, but I think you're right in saying I should really document both.

Add a option to ignore certificate. This should not be used in production but can be helpful during testing.

Fair point, will do.

Adding the pypi packagename to the readme

Another fair point, will also do.
Thank you so much for your feedback!

This already seem to be enough
class OpnsenseApi(Opnsense):

    def get_aliasses(self) -> List['OpnSenseApiAlias']:
        return self.firewall.alias_controller.list_aliases()

class OpnSenseApiAlias(TypedDict):
    uuid: str
    enabled: bool
    name: str
    description: str
    type: str
    content: str
    current_items: int
    last_updated: str
    categories_uuid: List[str]


Timeout using Redis

Hi! I'm trying to connect to my redis instance using:
REDIS_HOST='....'
REDIS_PASSWORD='...'
REDIS_USER=default

However, I can't connect to the site when I run local development, the error shows:
error - uncaughtException: Error: connect ETIMEDOUT
    at Socket.<anonymous> (/Users/sivanding/my-notion-site/node_modules/ioredis/built/Redis.js:168:41)
    at Object.onceWrapper (node:events:627:28)
    at Socket.emit (node:events:513:28)
    at Socket._onTimeout (node:net:562:8)
    at listOnTimeout (node:internal/timers:564:17)
    at process.processTimers (node:internal/timers:507:7) {
  errorno: 'ETIMEDOUT',
  code: 'ETIMEDOUT',
  syscall: 'connect'
}

I get the same error, which is why I don't use redis.

Redis works for me now, although I'm not sure what has changed since the last time I deployed. I recall using these settings; at any rate, it does work.

However, I don't see why it is even necessary. Why Redis?

@skybird-dev what would you recommend instead?
For larger sites, it's really prohibitive to re-compute these images on every build. Very open to other KV stores if redis isn't the best choice, though.

Thanks for the comments! @transitive-bullshit I'm wondering if this is a way to solve the image-loading issue because the images on my website usually disappear every time.


Error getting sources using git when agent configured to use a proxy

Have you tried trouble shooting? Yes
Trouble shooting doc
Agent Version and Platform
Version of your agent? 2.0.27
OS of the machine running the agent? Windows
VSTS Type and Version
VisualStudio.com or On-Prem TFS? VisualStudio.com
If On-Prem TFS, which release? 2015 RTM/QU1/QU2/...
If VisualStudio.com, what is your account name? http://carnivalcruiselines.visualstudio.com
What's not working?
The agent has been configured for a proxy using this instructructions:
./config.cmd --url "https://carnivalcruiselines.visualstudio.com" --auth "pat" --runAsService --token "*********" --proxyurl proxy.carnival.com:8080 --proxyusername ":proxy_user_name " --proxypassword "proxy_password"
After the agent has been registered successful, the build fails upon getting sources from Git, with the following error:
2018-05-04T18:53:05.2672449Z ##[command]git -c http.extraheader="AUTHORIZATION: bearer ********" -c http.proxy="proxy.mycompany.com:proxy_user_name:proxy_password@8080" fetch --tags --prune --progress
Notice that the proxy setting should be user:password@host:port. But in the command, it's using host:user:password@port. There seems to be a parsing error somewhere in the building of the git command.
If I try instead to configure the agent with this command:
./config.cmd --url "https://carnivalcruiselines.visualstudio.com" --auth "pat" --runAsService --token "*********" --proxyurl http://proxy.mycompany.com:8080 --proxyusername ":proxy_user_name " --proxypassword "proxy_password"
The configuration fails, saying it can't connect to the proxy.
It looks like the agent has a problem building the git commands using the http.proxy configuration setting if the agent has been configured using:
--proxyurl proxy.mycompany.com:8080 --proxyusername ":proxy_user_name " --proxypassword "proxy_password"
without prepending the protocol (http) to the proxy server.

No. It does contain underscores.
On Thu, May 10, 2018 at 8:53 AM, Ting<EMAIL_ADDRESS>wrote:

@vpopiol https://github.com/vpopiol your proxy username contains :?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vsts-agent/issues/1552#issuecomment-388044384,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABu7X5ys6IR9QS-umWSx6T7_el6IW5Xpks5txDhKgaJpZM4T4VFx
.

--
Victor Popiol
(954)881-8919

@vpopiol
in the issue you create:
./config.cmd --url "https://carnivalcruiselines.visualstudio.com" --auth "pat" --runAsService --token "*********" --proxyurl proxy.carnival.com:8080 --proxyusername ":proxy_user_name " --proxypassword "proxy_password"

your proxy username is: --proxyusername ":proxy_user_name "
which contains a : and a trilling space.
can you share your agent diag log? so we can know what parameter you actually feed in to the process.

Hi all,
after troubleshooting with @TingluoHuang, the issue has been solved.
It turns out that the --proxyusername required the domain. I.E. --proxyusername "mycompany\myusername"
Thanks so much!


Changes to GUI's

I have been making some changes to a number of GUI elements to provide more flexibility and visual consistency between machines. Been working through the order of machines as listed in BlockMachine.java, so only a handful have been touched so far.
Key changes consist of:
Replacing some hard-coded values with variables in GuiElement.java and derivatives to allow for more flexible placement.
Placing power bar and power input slot in similar positions on each GUI - In some cases this requires rearranging other GUI elements.
This also reflects in the idea of "Inputs on the left, outputs on the right"
"Iconify" progress bars - have the progress bars visually reflect the machine's function. This is a part of some forward planning in that similar looking progress bars can be used in the factories to show the function of that factory.

Excellent work, thanks

@TehStoneMan, your changes have messed up the progress bars in NEI components a bit.  Would you mind fixing them up to match what you've added?

Reversing commits for now

Taken me a while to work out the NEI stuff, but now that I have a handle on it, shouldn't be too hard to fix it up


Test Runner

This branch contains a very basic testing mechanism. run_tests.py is a python script that compiles the test files under src/tests, runs the resulting binaries, and compares their output with the expected output. This approach is obviously very limited, but it's helping me prevent regressions from happening.
I've also refactored guard.c (now it only contains the __guard_failure callback and a global variable which needs to be visible in jump.s).
I have just realized libunwind's unw_set_reg might not actually be modifying any register values (I think it's just changing them in the internal structures used by libunwind). I need to investigate this further.

This looks good, but, as we discussed the other day, these PRs are so large it's hard to do a proper review.

@vext01 Thank you for your review!
I've documented all the non-obvious functions in the header files. Do I need to address anything else before I squash?

@vext01 My bad, I forgot to add the python test runner.

@vext01 Thank you for your review!
I've addressed your comment about the test runner. I am going to improve the tests and the runner in a future PR, as I am currently working on fixing an annoying bug.

Is this ready to squash?

@vext01 Squashed


new tag providing recent features to crate users

Two new features landed recently:

https://github.com/coreos/cargo-vendor-filterer/pull/97
https://github.com/coreos/cargo-vendor-filterer/pull/99

There is one in review https://github.com/coreos/cargo-vendor-filterer/pull/102 and hopefully can be merged soon.
Can we make a new tag of this crate providing them to crate users?
Thanks in advance.
/cc @cgwalters

This was done.


Simplify convert_seconds_to_hms() and show days for large numbers of hours

If the time represented is large (eg uptime might be several months) then hours becomes unhelpful, Put simply, it's clearer and more intuitive/meaningful to show "4921:02:06" as "205d 01:02:06". (Leading "days" value isn't shown unless >=1 for simplicity)
Optional arg added forcing HH:MM:SS without days (old behaviour) even when it's a large number of hours, in case it's useful in some contexts.
Notes -

Function  simplified and all "if" statements removed
Input validity check before trying to convert format
Renamed to convert_seconds_to_dhms()

typo in commit c57e936
"function name hms -> dhms to match edit to util.inc"
should be "...to pfsense-utils.inc".

It would be a lot easier to merge if everything was in a single commit :)


Add monthly and weekly targets for annual goals

This adds two new progress bars to the user's goals which track progress towards an annual goal but for for the current month and week. I think this satisfies #274 for the most part, except it doesn't do daily tracking. I'd be happy to add that as well if wanted.

I'm not entire sure if I added the new displayExtendedGoals setting correctly. I had to do some manually jiggling to get it to work. It seemed to be confused because the setting didn't previously exist so it showed up as undefined? 😕

Awesome job!

OMG !! Nice work !!
I will test this at home !
Thanks !

Wow! So wanted this feature

@Holiverh Coming back to your PR to merge it this week and release :)
Do you confirm your feature works only for premium users?
Thanks again :)

Sadly, yes, this would only work for Strava Premium. However, it has only just occurred to me that this change will almost certainly break if the user uses imperial units instead of metric. I'll look to update it within the week.

@Holiverh No problem ;)
I was asking about this because a similar "targets" system has be introduced in stravistix:

(You can view this target  in year progression graph (my profile))
I have to avoid confusion between "targets" system for premium/free users.
Maybe should we use always strava targets values for premium users and always stravistix targets values for free users.
Let me know what do you all think about.
Thanks for the clean and nice code of your PR :) It's well commented ;)
Thomas

@Holiverh Thanks for your work. Your PR has been released in 4.5.0 ;)

@Holiverh A user sent me this question few seconds ago:

Hello Thomas,

Where came the numbers from?
cycling:
my settings: 3500 km / year,  77 km left
1749 km / month and 437 km / week

running:
my settings: 600 km / year , 27 km left
14 km / month and 3 km / week ?

Best regards
Frank

Are his numbers correct?
On my side i'm not sure to understand that he has to done "1749 km / month'" for November 2016 since he has already done "3433/3500km" for 2016.
Thanks again for your work (and clean commented code).
Tom ;)

The problem comes from german number format. (point for thousand seperator)
with english language settings it works perfect.

Now swimming is wrong.


Include versions tested on Travis in Trove classifiers

This will show up on PyPI, making clear what is supported.

Coverage remained the same at 100.0% when pulling e6cbf0c51e3bd0f639584a3bbd97c394bd844c57 on jhermann:patch-2 into 1a9cc60f82c99e4bb4fed9acb9692f2a1aeba074 on mewwts:master.

Thanks!


upgrade to latest gen_flow

The version that lasp is currently using doesn't contain https://github.com/lasp-lang/gen_flow/pull/8, and has slowly-growing message queues while running that are never cleaned up.

As far as I can tell, lasp master is using the latest gen_flow on hex.  Does the package need updating?  cc: @tsloughter has the control to do that only, I think.

I feel like there was another recent mention of me regarding making some releases.
@cmeiklejohn do you know what I need to cut releases for? I can do it today.

@tsloughter I think we need lasp_pg, gen_flow, partisan, and lasp.


Upgrade FotoMagico.app to v4.5.5-19761

I tried to delete commit 0905933ccfa5e79d333d5b41bb395cce6641e7f5 for this pull request - but I didn't find out how it's possible.
I hope only commit 629793ec41001329a3ec42dd29d0c087fea37a76 will be merged

Thank you for the contribution. It needed some fixes, so they were made in the above referenced pull request. Your contribution is still included (and still credited to you), with the appropriate modifications. Please feel free to ask about any of the changes.


Rewrite get/update config rest APIs & support hot update for some fields.

related to https://github.com/nanomq/NanoNNG/pull/312

why all CI failed

why all CI failed

just need to rebase master

lets split it into multiple PRs to make sb happy


Parsing array with 1 field is not possible

Hi,
I'm trying to parse an array of arguments and convert it to a struct. It works great for when the struct contains more than 1 field, but when it's 1 field, it doesn't work as I would have expected.
#[derive(Deserialize_tuple)]
struct DoubleParam {
  id : u64,
  my_arg : String
}

#[derive(Deserialize_tuple)]
struct SingleParam {
  id: u64
}

// works
serde_json::from_str::<DoubleParam>(r#"[1, "my arg"]"#)
// fails with invalid type: sequence, expected a u64
serde_json::from_str::<SingleParam>(r#"[2]"#)

If I expand the macro it appears that the sequence visitor is added, however it also adds the visit_newtype_struct and uses
_serde::Deserializer::deserialize_newtype_struct(
    __deserializer,
    "SingleParam",
    __Visitor {
        marker: _serde::__private::PhantomData::<Inner>,
        lifetime: _serde::__private::PhantomData,
    },
)

The Double param macro expansion generates
_serde::Deserializer::deserialize_tuple_struct(
  __deserializer,
  "DoubleParam",
  2usize,
  __Visitor {
      marker: _serde::__private::PhantomData::<Inner>,
      lifetime: _serde::__private::PhantomData,
  },
)

It look like the default Deserialize for a tuple struct with 1 element uses the newtype struct.
As Deserialize_tuple adds the #[derive(Deserialize)] on the Inner tuple struct, it doesn't use the sequence but it uses the newtype_struct

As a possible solution could be to change the Inner struct to a [<Type>; 1] slice if it only contains 1 argument
So the macro would expand to
#[derive(Deserialize_tuple)]
struct SingleParam {
  id: u64
}

// Macro expansion
impl<'de> serde::Deserialize<'de> for SingleParam {
    fn deserialize<D>(deserializer: D) -> Result<Self, D::Error>
    where
        D: serde::Deserializer<'de>,
    {
        let [id] : [u64;1] = serde::Deserialize::deserialize(deserializer)?;
        Ok(SingleParam { id })
    }
}

Hi @benoist , can you confirm you are on version 0.5.0 (released 2020-03-20) of this crate? I believe this is more or less the same issue as https://github.com/kardeiz/serde_tuple/issues/6, which was fixed in that version.
I just tried it out and your example code runs fine on 0.5.0.

Oh dear, I apologise. I should have checked the versions better.
Thanks for the reply.


fails to build due to process_read_dir argument error

error[E0593]: closure is expected to take 4 arguments, but it takes 2 arguments
   --> /home/matt/.cargo/registry/src/github.com-1ecc6299db9ec823/dua-cli-2.10.7/src/common.rs:139:14
    |
139 |             .process_read_dir(|_, dir_entry_results| {
    |              ^^^^^^^^^^^^^^^^ ---------------------- takes 2 arguments
    |              |
    |              expected closure that takes 4 arguments

This appears to be due to a breaking change in jwalk between version 0.5.0 and 0.5.2.

Thanks a lot for the headsup - I have created an issue in jwalk which I believe is a better place for the fix - this probably is an accident.

Thanks a lot for the headsup - I have created an issue in jwalk which I believe is a better place for the fix - this probably is an accident.

It is weird though b/c your Cargo.toml explicitly calls for 0.5.0, so I couldn't figure out why I was getting that error when trying to build.

It is weird though b/c your Cargo.toml explicitly calls for 0.5.0, so I couldn't figure out why I was getting that error when trying to build.

I think by default the lock file is ignored unless some flag is provided to enforce it.
That certainly is a little surprising and I would expect it to be the default.
Sent from my iPhone

On Jan 4, 2021, at 11:05 AM, stevensonmt<EMAIL_ADDRESS>wrote:

It is weird though b/c your Cargo.toml explicitly calls for 0.5.0, so I couldn't figure out why I was getting that error when trying to build.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.

I think by default the lock file is ignored unless some flag is provided to enforce it.
That certainly is a little surprising and I would expect it to be the default.
Sent from my iPhone

On Jan 4, 2021, at 11:05 AM, stevensonmt<EMAIL_ADDRESS>wrote:

It is weird though b/c your Cargo.toml explicitly calls for 0.5.0, so I couldn't figure out why I was getting that error when trying to build.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.

Jwalk yanked the offending version, and the build fails again?
error[E0593]: closure is expected to take 2 arguments, but it takes 4 arguments
   --> .cargo/registry/src/github.com-1ecc6299db9ec823/dua-cli-2.10.8/src/common.rs:139:14
    |
139 |             .process_read_dir(|_, _, _, dir_entry_results| {
    |              ^^^^^^^^^^^^^^^^ ---------------------------- takes 4 arguments
    |              |
    |              expected closure that takes 2 arguments

Jwalk yanked the offending version, and the build fails again?
error[E0593]: closure is expected to take 2 arguments, but it takes 4 arguments
   --> .cargo/registry/src/github.com-1ecc6299db9ec823/dua-cli-2.10.8/src/common.rs:139:14
    |
139 |             .process_read_dir(|_, _, _, dir_entry_results| {
    |              ^^^^^^^^^^^^^^^^ ---------------------------- takes 4 arguments
    |              |
    |              expected closure that takes 2 arguments

Thanks for the heads-up - fixed in v2.10.9.

Thanks for the heads-up - fixed in v2.10.9.


Issue when calling delete_database() function in mock_glue decorator

Issue
Hello, I am having an issue when using mock_glue decorator, unittest, and pytest. I am setting up a fake db, but when I try and tear it down, I get an error: NotImplementedError: The delete_database action has not been implemented. Could someone please help me out?
NOTE: This is running on the most recent version of moto.
 Marking it as an enhancement to add this method


refactor: replace deno.land/std with jsr:@std

TODO:

[ ] update std/examples & testing examples
[ ] deno.lock looks differently now

Usage of --eval-file flag are now broken (https://github.com/denoland/deno/issues/23071) and deployctl doesn't support jsr specifiers for entrypoint

Oh whoops, just PRed almost the same thing and missed this: https://github.com/denoland/deno-docs/pull/587. Mine should be unblocked from landing as-is, but can change its scope or abandon if you prefer. @crowlKats


Stop mixing JUnit 4 with JUnit 5 for provider

Currently pact-jvm-provider-junit5 depends on pact-jvm-provider-junit. As result anybody putting pact-jvm-provider-junit5 on classpath is also putting two conflicting JUnit versions.
Reason: there are some annotation classes shared between both subprojects.
Possible solutions:

mark JUnit a compileOnly dependency
extract classes common to those subprojects to an another project, like pact-jvm-provider-junit-common

I can provide a pull request if you can state which approach you prefer.

Just noticed you were the driver for the consumer fix :-D


docs(index): describe your change...

Description:
Remove fromPromise from documentation has it has been removed from public API.
Related issue (if exists):

Pull Request Test Coverage Report for Build 7347

0 of 0   changed or added relevant lines in 0 files are covered.
5 unchanged lines in 3 files lost coverage.
Overall coverage increased (+0.2%) to 96.967%

Files with Coverage Reduction
New Missed Lines
%

src/internal/observable/fromPromise.ts
1
87.5%

src/internal/observable/fromIterable.ts
2
95.24%

src/internal/observable/fromObservable.ts
2
83.33%

Totals

Change from base Build 7346:
0.2%

Covered Lines:
5786

Relevant Lines:
5967

💛  - Coveralls


Release 1.1.0b3

Some poetry PRs have been waiting for a new poetry-core beta for some time now. Since the latest poetry beta pinned poetry-core to 1.1.0b2, the risk of a new beta should be low. Thus, I propose to just cut a new poetry-core beta.
(Order of sections according to https://github.com/python-poetry/poetry/pull/5725#issuecomment-1146874889.)
Added

Added support for valid PEP 517 projects with another build-system than poetry-core as directory dependencies  (#368, #377).
Added support for yanked files and releases according to PEP 592 (#400).

Changed

Relaxed schema validation to allow additional properties (#369).
Harmonized string representation of dependencies (#393).
Changed wheel name normalization to follow most recent packaging specification (#394).
Changed equality check of direct origin dependencies, so that constraints are not considered anymore (#405).
Deprecated Dependency.set_constraint() and replaced it by a constraint property for consistency (#370).
Removed Package.requires_extras (#374).
Improved marker handling (#380, #383, #384, #390, #395).

Fixed

Fixed hash method for PackageSpecification, Package, Dependency and their sub classes (#370).
Fixed merging of markers python_version and python_full_version (#382, #388).
Fixed python version normalization (#385, #407).
Fixed an issue where version identifiers with a local version segment allowed non local versions (#396).
Fixed an issue where version identifiers without a post release segment allowed post releases (#396).
Fixed script definitions that didn't work when extras were not explicitly defined (#404).

Does this need still to be a beta?  Why not release 1.1.0 proper?
(Arguably it should be 2.0.0 anyway because it surely has breaking changes since 1.0.x: but I'm more keen to encourage dropping the beta tag than I am to debate version semantic versioning)

I'm not aware of the full impact of a proper release. I suppose a beta does not influence projects with something like
[build-system]
requires = ["poetry-core>=1.0.0"]

whereas a proper release might. I suppose we will do the proper release of poetry-core immediately before poetry 1.2 and according to python-poetry/poetry#5586 we are still not close enough. (Just my personal opinion.)

fwiw I also think it's time to cut poetry 1.2.0 - all the blockers listed in #5586 have fixes pending, let's merge them and go.  But it really ought to be possible to cut releases in this project without being blocked on that.

Unless it was left out intentionally, #404 seems to be missing.

Slipped through my fingers. Added it. Thanks. 👍


Add Brazilian(?) variations for current sentences

Not exactly sure if those are strictly Brazilian sentences, but they're definitely stuff I would hear around here :)

Probably you commitd on wrong files, the correct ones should be under pt-br folders not pt

I actually committed when pt-br didn't even exist and I wasn't sure it
would 🤷🏼♂
Igor Santos
-- Desenvolvedor Web
[enviado do meu celular]
On Sun, Feb 26, 2023, 09:19 leozanotto @.***> wrote:

Probably you commitd on wrong files, the correct ones should be under
pt-br folders not pt
—
Reply to this email directly, view it on GitHub
https://github.com/home-assistant/intents/pull/856#issuecomment-1445347245,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEB6SYX7CGRZAQADYTIV7LWZNC4RANCNFSM6AAAAAAUOMG2QQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

I actually committed when pt-br didn't even exist and I wasn't sure it would 🤷🏼♂ but I guess I wasn't as fast/well connected as those who created the folder and didn't notice other Brazilian PRs.

I have created a PR right now, probably some of the changes you made are already there: #1146

I have created a PR right now, probably some of the changes you made are already there: #1146

Same regarding the PR #1111...


✨ Consumer health check

✨ Health component w/ grid for demo
✨ Port Sequin.Health and modify for multiple checks
✨ Consumer health check

#170  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @RTLS and the rest of your teammates on  Graphite


Multi 30K

I have collected multi30K from "https://github.com/multi30k/dataset", but En and DE are only 30K which is different from the paper.
The results for EN and DE in zero-shot are 76.6 and 76.4, which are very different from the 83.7 and 79.1 given in the paper.
When I use all the data from Flickr30K as EN, the EN result is 83.4, but the DE still works poorly. According to the paper, it should be 150K DE sentences, so how can I get the total DE data?
In the paper, it says that "Multi30K contains 31,783 images and provides five captions per image in English and German and one caption per image in French and Czech"?
Can you give the total data of multi30K or corresponding URL

En
De
Fr
Cs

30K
30K
30K
30K
multi30k in github

150K
150K
30K
30K
multi30k in your paper

can you give me the total data of Multi 30K you used?  I promise they will be used only for research purposed.

Hi,
Did you notice the fact that for En & De each image has 5 captions, while for Fr & Cs each image has only 1 caption?

Yes, but "https://github.com/multi30k/dataset" doesn't seem to be the case, so where can I download the full multi30k from, or can you provide a copy? I promise they will be used only for research purposed.

Hi,
I checked that I downloaded the dataset from the same link, and you can get the correct multi30k dataset after some simple preprocess.

Thank you，I will success sooner.


meson setup fails with 'Dependency "glib-2.0" not found'

Trying this on an Ubuntu 24.04 install on AmpereOne, I'm getting the following message when running the build script:
Run-time dependency glib-2.0 found: NO (tried pkgconfig)

../meson.build:926:10: ERROR: Dependency "glib-2.0" not found, tried pkgconfig

A full log can be found at /home/ubuntu/qemu-coremark/qemu-9.1.0/build/meson-logs/meson-log.txt

ERROR: meson setup failed

From that log...
-----------
Command line: `cc /home/ubuntu/qemu-coremark/qemu-9.1.0/scripts/xen-detect.c -o /home/ubuntu/qemu-coremark/qemu-9.1.0/build/meson-private/tmpuwkfbowk/output.exe -D_FILE_OFFSET_BITS=64 -O0 -std=gnu11 -DCONFIG_XEN_CTRL_INTERFACE_VERSION=40701` -> 1
stderr:
/home/ubuntu/qemu-coremark/qemu-9.1.0/scripts/xen-detect.c:105:12: fatal error: xenctrl.h: No such file or directory
  105 |   #include <xenctrl.h>
      |            ^~~~~~~~~~~
compilation terminated.
-----------
Pkg-config binary for 1 is cached.
Determining dependency 'glib-2.0' with pkg-config executable '/usr/bin/pkg-config'
env[PKG_CONFIG_PATH]:
-----------
Called: `/usr/bin/pkg-config --modversion glib-2.0` -> 1
stderr:
Package glib-2.0 was not found in the pkg-config search path.
Perhaps you should add the directory containing `glib-2.0.pc'
to the PKG_CONFIG_PATH environment variable
Package 'glib-2.0', required by 'virtual:world', not found
-----------
Run-time dependency glib-2.0 found: NO (tried pkgconfig)

../meson.build:926:10: ERROR: Dependency "glib-2.0" not found, tried pkgconfig

What does grep ID_LIKE /etc/os-release show on your system?

@bexcran
ubuntu@ubuntu:~$ grep ID_LIKE /etc/os-release
ID_LIKE=debian

@bexcran - After manually installing libglib-2.0-dev, it seems like the build is progressing further.

Hmm... now the launch script is showing VM 0 failed to start:
Running QEMU VMs...............................................
Checking if VMs successfully started.
QEMU VM 0 failed to start. See /tmp/qemu0.log for details.

Log file contents:
ubuntu@ubuntu:~/qemu-coremark$ cat /tmp/qemu0.log
WARNING: Image format was not specified for 'json:{"fat-type": 0, "dir": "phoronix-test-suite", "driver": "vvfat", "floppy": false, "rw": true, "write-target": {"driver": "qcow", "file": {"driver": "file", "filename": "/var/tmp/vl.VW2TW2"}}}' and probing guessed raw.
         Automatically detecting the format is dangerous for raw images, write operations on block 0 will be restricted.
         Specify the 'raw' format explicitly to remove the restrictions.
Could not access KVM kernel module: Permission denied
qemu-system-aarch64: failed to initialize kvm: Permission denied

If I try running the script with sudo it then shows me a bunch of permission denied warnings from subprocesses.
I'm only in the following groups:
ubuntu@ubuntu:~/qemu-coremark$ groups
ubuntu adm cdrom sudo dip plugdev lxd ollama

Do I need to ad myself to any more groups to make this work?

Try adding yourself to the kvm group.
You can check if that's the correct group by doing ls -l /dev/kvm and looking at the group.

Hooray!
sudo usermod -a -G kvm ubuntu

Then logout / login, and now ./launch_qemu.sh seems to be working.

ubuntu@ubuntu:~/qemu-coremark$ ./run_pts.sh 2
47 instances of pts/coremark running in parallel in arm64 VMs!
Round 1 - Total CoreMark Score is: 4697344
Round 2 - Total CoreMark Score is: 4684524

@geerlingguy now try it on x86 😁

@joespeed done! https://github.com/geerlingguy/sbc-reviews/issues/52#issuecomment-2489984207 ;)


Added cursorMove after line execution

@Ladvien Thank you for your Pull Request.
Looks solve #9, Very good!
Please waiting for my review.

No worries.  Let me know if it needs tweaks, if so I’ll edit and re-pull.
And thank you for the extension—I use R a lot and VSCode is my favorite editor, so a big thank you.
—C. Thomas Brittain
Aka, Ladvien

On Jul 4, 2017, at 12:19 PM, Yuki Ueda<EMAIL_ADDRESS>wrote:
@Ladvien https://github.com/ladvien Thank you for your Pull Request.
Looks solve #9 https://github.com/Ikuyadeu/vscode-R/issues/9, Very good!
Please waiting for my review.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/Ikuyadeu/vscode-R/pull/13#issuecomment-312922424, or mute the thread https://github.com/notifications/unsubscribe-auth/AF887Xr9rMf8rNZl_1PPjr5Pkwa0h8Wwks5sKnQngaJpZM4ONjEp.

@Ladvien I looked your change and very useful!
My review content is not so important, if you don't feel like it.

Very Good, Thank you!


refactor(Checkbox): update the state value callback

update the state value callback
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符；如果有关联 Issue 请在下方填写相关编号
Description
fixes #4645
Regression?

[ ] Yes
[ ] No

[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk

[ ] High
[ ] Medium
[ ] Low

[Justify the selection above]
Verification

[ ] Manual (required)
[ ] Automated

Packaging changes reviewed?

[ ] Yes
[ ] No
[ ] N/A

☑ Self Check before Merge
⚠ Please check all items below before review. ⚠

[ ] Doc is updated/provided or not needed
[ ] Demo is updated/provided or not needed
[ ] Merge the latest code from the main branch

Summary by Sourcery
Bug Fixes:

Fix the state value callback logic in the Checkbox component to correctly toggle the state.

@sourcery-ai review


ocamlPackages.hpack: 0.9.0 → 0.10.0

Description of changes
https://github.com/anmonteiro/ocaml-h2/blob/0.10.0/CHANGES.md
https://github.com/dinosaure/paf-le-chien/blob/0.5.0/CHANGES.md
https://github.com/roburio/http-mirage-client/blob/v0.0.3/CHANGES.md
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 225270 run on x86_64-linux 1

1 package built:

comby

nix run nixpkgs#nixpkgs-review pr 225270 happy on x86_64-darwin


Not-really-needed commit to retry CI.

The first build of this package didn't trigger AppVeyor, and so we don't have
a Windows version of this package. I don't know if a PR will fix that, but
it's worth a try. This commit updates bld.sh and build.sh based on my
subsequent work on getting X.org to build on Windows. The changes aren't
needed for this simple package, but as long as I'm looking for an excuse to
make a commit, I might as well incorporate them.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Russian Peasant Algorithm in Java

Have you read the Contributing Guidelines on Pull Requests?
Yes
(Write your answer here.)
Description
Russian Peasant multiplication algorithm in Java.
(Write your answer here.)
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
Issue #978
(Write your answer here.)

@iamrajiv @plazzy99 @Kajol-Kumari @siddharth25pandey please review this.

@iamrajiv sir here also, 3 approvals done, please merge


Open, modify then save xlsx file is slow

Since image is not supported by stream/xlsx, so I create Excel with WorkbookWriter and save it to file, then open it with file based Workbook.xlsx, add image to worksheets, then save it.
The size of generated Excel file is about 700kb, and there is only one sheet in workbook, only one image added to that worksheet. But this cost at least 6 minutes on i5-7400 machine with 20 percent cpu usage.
Is there better way to just add image to xlsx file?

Sorry, I tested this in debug mode before, and it's fairly fast in release mode, 3 Mb xlsx file cost 30 seconds.


Continuous loading and error message occurs when saving 'Staff' modal with no changes in facility detail page.

Expected behavior
Save button should appear disabled until any changes are done inside the modal.
Steps to reproduce the issue
Login the app with valid user credentials and click on any facility card on find facilities page.
Navigate to the 'Staff' section on the facility details page.
Click on the "Add Staff Member" button.
Attempt to save the selection without doing any changes.
Observe continuous loading on the UI and the appearance of the error toast message.
Environment details
App version : v1.7.0
App environment : UAT
Additional information
https://jam.dev/c/f0593eaa-908a-44b1-a95d-a30c7de666bf

Issue verified and working fine in release v1.9.0. Hence, closing it.


Get blurry color image and all black depth image

Describe the bug
I tried to store color and depth images captured from Kinect Azure using opencv for later application with Neural Networks. I just placed the camera pointing at the objects with the proper range. However my code just displayed blurry color image and all black depth image though k4aviewer works perfect.
To Reproduce
To reproduce the result I attached my code here.
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License.

#include <iostream>
#include <stdio.h>
#include <stdlib.h>
#include <k4a/k4a.h>
#include <opencv2/core/mat.hpp>
#include <opencv2/core/core.hpp>
#include <opencv2/highgui/highgui.hpp>

using namespace cv;
using namespace std;

int main()
{
	// 1.1: Start by counting the number of connected devices
	uint32_t device_count = k4a_device_get_installed_count();
	if (device_count == 0)
	{
		printf("No K4A devices found\n");
		return 0;
	}
	else
	{
		printf("Found %d connected devices:\n", device_count);
	}

	// 1.2: Define the Exit block
	int returnCode = 1;

	// 1.3 Initialize the the device and capture attributes
	k4a_device_t device = NULL;
	k4a_capture_t capture = NULL;
	const int32_t TIMEOUT_IN_MS = 1000;

	// 1.4: Initialize the frame count
	int totalFrame = 5;
	int captureFrameCount = totalFrame;
	printf("Capturing %d frames\n", captureFrameCount);

	// 2: Set the configuration of device, you can also set it after open the device but before starting the camera
	k4a_device_configuration_t config = K4A_DEVICE_CONFIG_INIT_DISABLE_ALL;
	config.color_format = K4A_IMAGE_FORMAT_COLOR_BGRA32;  // <==== For Color image
	config.color_resolution = K4A_COLOR_RESOLUTION_2160P;
	config.depth_mode = K4A_DEPTH_MODE_NFOV_UNBINNED;  // <==== For Depth image
	config.camera_fps = K4A_FRAMES_PER_SECOND_30;
	config.synchronized_images_only = true;

	// 3: Open the device
	if (K4A_RESULT_SUCCEEDED != k4a_device_open(K4A_DEVICE_DEFAULT, &device))
	{
		printf("Failed to open device\n");
		goto Exit;
	}

	// 4: Start the camera
	if (K4A_RESULT_SUCCEEDED != k4a_device_start_cameras(device, &config))
	{
		printf("Failed to start device\n");
		goto Exit;
	}

	// 5: Start to receive the captures and framess
	while (captureFrameCount-- > 0)
	{
		// Get a depth frame
		switch (k4a_device_get_capture(device, &capture, TIMEOUT_IN_MS))
		{
		case K4A_WAIT_RESULT_SUCCEEDED:
			break;
		case K4A_WAIT_RESULT_TIMEOUT:
			printf("Timed out waiting for a capture\n");
			continue;
			break;
		case K4A_WAIT_RESULT_FAILED:
			printf("Failed to read a capture\n");
			goto Exit;
		}

		printf("Capture %4d\n", captureFrameCount);

		// 5.1 Probe for a color image
		k4a_image_t image = k4a_capture_get_color_image(capture);
		if (image)
		{
			// 5.2 Get the sizes of color image
			int width = k4a_image_get_width_pixels(image);
			int height = k4a_image_get_height_pixels(image);
			int strides = k4a_image_get_stride_bytes(image);

			// 5.3 Store the image using opencv Mat
			uint8_t* color_image_data = k4a_image_get_buffer(image);
			const Mat color_image(width, height, CV_8UC4, (void*)color_image_data, Mat::AUTO_STEP);

			// 5.5 Display the images
			namedWindow("foobar", WINDOW_AUTOSIZE);
			imshow("foobar", color_image);
			waitKey(3000);

			// 5.6 release the image
			k4a_image_release(image);
		}
		else
		{
			printf(" | Color None                       ");
		}

		// 6.1 Probe for a depth16 image
		k4a_image_t image_depth = k4a_capture_get_depth_image(capture);
		if (image != NULL)
		{
			// 6.2 Get the sizes of depth image
			int width = k4a_image_get_width_pixels(image_depth);
			int height = k4a_image_get_height_pixels(image_depth);
			int strides = k4a_image_get_stride_bytes(image_depth);

			// 6.3 Store the image using opencv Mat
			uint8_t* depth_image_data = k4a_image_get_buffer(image_depth);
			const Mat depth_image(width, height, CV_16U, (void*)depth_image_data, Mat::AUTO_STEP);

			// 6.5 Display the images
			namedWindow("foobar", WINDOW_AUTOSIZE);
			imshow("foobar", depth_image);
			waitKey(3000);

			// 6.6 release the image
			k4a_image_release(image_depth);
		}
		else
		{
			printf(" | Depth16 None\n");
		}

		// release capture
		k4a_capture_release(capture);
	}

	returnCode = 0;
Exit:
	if (device != NULL)
	{
		k4a_device_stop_cameras(device);
		k4a_device_close(device);
	}

	return returnCode;
}

Expected behavior
Clear depth and color images show up.
Logs

Screenshots
Color image example here:

Depth image example here:

Desktop (please complete the following information):

OS with Version: Windows 10
SDK Version:  1.1.1
Firmware version:  N/A

Additional context
My very first guess is I need to set the correct configuration for the camera, or do I need to calibrate the camera in my code? Many thanks for your help!

Please look at the constructor of CV::Mat:
Mat (int rows, int cols, int type)
Seems that you are passing in width instead of height and vice versa.

@mbleyer Thanks you are correct! I modified the code and it is fine now:-).


Fix for #1888: check item's original namespace, not remapped one, for inclusion/exclusion

Closes #1888
cc @betta1 - would be great if you could test this out!  I can push an image if you need.

Thanks Steve, I'll checkout your branch and build the image. I'll update in a few mins.

Yes this 💯  fixes #1888, tested with the build from your branch and restore works as expected:
k get po -n mysql
NAME                     READY   STATUS    RESTARTS   AGE
mysql-5c5cd4b775-lrp29   1/1     Running   0          8m28s

k get deploy -n mysql
NAME    READY   UP-TO-DATE   AVAILABLE   AGE
mysql   1/1     1            1           8m55s

k get po -n nginx
NAME                        READY   STATUS    RESTARTS   AGE
my-nginx-6cc48cd8db-zx8fh   1/1     Running   0          9m23s

k get deploy -n nginx
NAME       READY   UP-TO-DATE   AVAILABLE   AGE
my-nginx   1/1     1            1           9m45s

# back up mysql, nginx namespaces
velero backup create backup-0 --include-namespaces mysql,nginx

velero get backups
NAME       STATUS      CREATED                         EXPIRES   STORAGE LOCATION   SELECTOR
backup-0   Completed   2019-09-25 12:56:40 -0700 PDT   29d       dd-bsl             <none>

# restore mysql namespace to new namespace
velero restore create mysql-restore --namespace-mappings mysql:mysql-new --from-backup backup-0 --include-namespaces mysql

# mysql deployment and pods restored into new namespace
k get po -n mysql-new
NAME                     READY   STATUS    RESTARTS   AGE
mysql-5c5cd4b775-lrp29   1/1     Running   0          34s

k get deploy -n mysql-new
NAME    READY   UP-TO-DATE   AVAILABLE   AGE
mysql   1/1     1            1           41s


#4804 Handle action parameters of type array correctly

This addresses issue #4804 and actually affects more than just remote shell runner actions.
In the beginning this looked like a simple issue with the serialization and parsing of the parameter but it actually looks like this did not work at all.
So I address 2 issues with this PR:

    elif argument_type == 'list': actually did not match when the type was array. This means that the final else matched and the parameter was just transformed to a unicode string. Although according to the documentation, array is the correct value (See https://docs.stackstorm.com/actions.html#action-metadata) I see some potential how this could break something in existing environments where the unicode string is already handled by the script and users did not notice that this is actually a bug.
Question 1: Do we want to address this and if yes, how? This change should at least be mentioned in the changelog once it's released.
Question 2: Is there any reason (i.e. backward compatibility) I am not aware of to check if the parameter type is either list or array and not just array?
Its required to map the values and cast them to strings to handle the case where not all the values of the array are either strings or integers. join on an array with strings and integers or other values for example would fail terribly.

The solution provided with this PR is the pragmatic approach. It's actually a trade-off and may apply unnecessary casting operations when applying str() to the item.
Alternative approach
The alternative would look like this:
    elif argument_type == 'list' or argument_type == 'array':
        # Lists are serialized a comma delimited string (foo,bar,baz)
        argument_value_types = set([type(value) for value in argument_value])
        if len(argument_value_types) == 1 and int in argument_value_types or str in argument_value_types:
            # join arrays that hold just strings or integers
            argument_value = ','.join(argument_value) if argument_value else ''
        else:
            # join arrays with items of any other type and transform these items to strings
            argument_value = ','.join(map(str, argument_value)) if argument_value else ''

Here we check the type of all the items in an array first and just join the items if they are either just strings or just integers. In all other cases, str() would be applied to all the items in the array.
But I think this just shifts the overhead to another place and is not worth it. I did not do any performance tests with real large arrays yet but I doubt that this matters here. Any input by more experienced experts is appreciated!

I will take a look at the failed test. I was actually reviewing the current tests already and was wondering why that tests did not fail in the past. So, let's see... Investigation ongoing.

So the failed test was caused by: https://github.com/StackStorm/st2/blob/cdfeeafc597cff44556a7b61a9e90426194313e0/st2common/tests/unit/test_action_db_utils.py#L466 where the used type was also 'list' and not 'array'.
So, since I don't believe in coincidence this seems to confirm the concerns I mentioned in the PR: just checking the type for array instead of list will break existing stuff and their might be historical reasons why st2 should support both types.
I pushed a commit that checks if the type is in [ 'array', 'list' ] and assume that the test will be fixed by this commit. In the end, I'm open to adapt the test to use type: array as well but I would like to get some feedback from the "old hands".

I reran the failing Travis test and it passed. Solving the intermittent failures on Travis is out of the scope of this PR.
At this point the only failing Travis build is the linting run, so fixing that as I've suggested should solve it. @winem If you're still interested in merging this, just make that fix and I'll approve it and merge it in! 😃

Hi @blag, do you have any opinion on the array vs. list vs. support both topic? Or maybe even some insights from the history of stackstorm?

I reran all of the failing tests - everything passes now!
At this point I think we'll need to support both list and array. I'm skeptical that argument_type is ever list in production, but I don't think it would hurt to support both.
However, this PR also needs at least a unit test for this function so nobody breaks it in the future. You should be able to extend the test for get_args to include tests for arrays.

Thanks for re-running the tests and and the feedback!
I just added the tests. Let's just wait for the unit tests to be done.

Sorry I should have mentioned this before: please add a changelog entry for this fix.

No worries, @blag. Could have though of it as well. Anyway, done. :+1:

Hi @m4dcoder,
to be honest, I can't follow, so I will just provide as much details as possible and hope that it helps.
Without the change from this PR an array would be passed to the shell command as a unicode string if the parameter type is array (as the documentation recommends).
So the parameter to the script was
[u'foo'
 u'bar'
 u'baz']

instead of the expected foo,bar,baz.
What this PR does is to handle parameters of both types, list and array, the same way and pass the list values as comma separated argument to the shell command runner.
I added unit tests which use the params.actionarray in addition to params.actionlist to ensure that we test both types of list parameters and have the same tests for both.
So I think I can just come up with tests that prove that the solution works but I can't provide one that reproduces the old behavior and would fail expectedly.
Please let me know if I miss anything or got something wrong.

This is primarily an issue with documented vs actual functionality.
In the docs:

parameters - A dictionary of parameters and optional metadata describing type and default. The metadata is structured data following the JSON Schema specification draft 4. The common parameter types allowed are string, boolean, number (...), object, integer (...) and array.

Which references the JSON Schema Spec 4. This section is particularly relevant:

JSON Schema defines seven primitive types for JSON values:

array  A JSON array.
boolean  A JSON boolean.
integer  A JSON number without a fraction or exponent part.
number  Any JSON number.  Number includes integer.
null  The JSON null value.
object  A JSON object.
string  A JSON string.

So, array is called out in the docs as "the" way to get a array/list parameter into an action, and cites an external spec as the source for the naming convention. However, only list was implemented, not array. So, this PR adds proper array support but maintains backwards compatibility for list.
The one thing I see that could probably still use another test is this line:
https://github.com/StackStorm/st2/blob/0725178b038c31222dae49c21d393fb340d3d6ce/st2common/st2common/util/action_db.py#L288
That is the implementation of @winem's second point:

Its required to map the values and cast them to strings to handle the case where not all the values of the array are either strings or integers. join on an array with strings and integers or other values for example would fail terribly.

Maybe this needs one or more tests that demonstrate a list that includes something that is neither int nor string to show when the casting to string is necessary.

Hi @cognifloyd, thank you for the extensive answer. Now I got it and totally agree that this kind of test is missing.
I added a test for arrays with values of different types and might have found another issue. But this may also be a matter of expectation. So when someone enters a complex number as value it will be interpreted as complex number first and st2 would just pass the result.
This is probably obvious for developers but may cause issues in the rare case that a user wants to pass a complex number as parameter to a script. Do we wanna add this to the documentation?

@cognifloyd Thanks for the review and feedback, that was helpful! :+1:
@m4dcoder this PR is up to you for the final decision.


feat: add alphabetical, commit and config order to ls and tui

This is still WIP.
Related to #193.
The ideas behind these changes are:

Using config.yaml to set the type of order for the repositories: alphabetical, commit or config.
Adding a new field sorted to the RepoSource struct.
Implementing a method Sort on RepoSource.
Calling this method Sort when the configuration is loaded.
It applies for both ls and TUI.
The default behavior is to follow the order in config.yaml. The remaining repositories that don't appear in the config file are appended at the end with no specific order.
If using commit, the repositories with most recent commits are shown first.
Some tests were added as well.

After giving it some thought, this is what felt sensible to me. Is it aligned with the original idea?
Thanks in advance for the feedback.

I don't find a simple way to add a test that validates the commit date order. If anyone has any suggestions, they're very welcome.
Other than that I think it is ready to review.

Any maintainer can take a look at this?

Thanks @salasberryfin for taking a look at this.
The idea I had in mind was like pinning repositories in GitHub. So the repos in config.yaml should always come first based on their order in the config. Other repositories, IMO, should be sorted by latest commit.
For ls, I think it's more sensible to make it mimic the shell ls command and sort repos in alphabetical order.
Let me know what you think.


Testing RestaurantDetailsGetter class

includes new test file for the RestaurantDetailsGetter java class

other than small nit, LGTM!
clean organization and nice naming :)


Bidirectional breadth first search 4e

parallel execution by utilizing streams

the readme asked for contributions, so I figured I could just try something from the ToDo list. I hope that's ok.

Hi, No problem tackling from the TODO list. As the pull request is not self contained (i.e. it impacts existing code and is not just the algorithm) I'll need to look over in detail. Hopefully, within the next couple of weeks.
One request, it looks like you added logic to ProblemFactory.java but may have also reformatted the entire file as well (I need to look in a different diff tool to confirm). Ideally, its best to separate global format changes from code changes as it makes it difficult to pick out the meaningful changes.
Thanks

| Ideally, its best to separate global format changes from code changes as it makes it difficult to pick out the meaningful changes.
Your right. I will revert that and maybe separate the new code
For the other changes comment on the PR and I will adjust as needed.


[Document] Fix document invalid image urls

Motivation
#1224
Some of the document's image URL needs to be updated.

Modifications
Fix URL path.
Documentation
None

@horoc also here needs a specific issue :)

@horoc also here needs a specific issue :)

Sorry for the omission, I have created a new issue for this.


In the text field of newly created pull request " " is mentioned in plain text

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
In the text field of the newly created pull request " " is mentioned in plain text.
Check the attachment for more details.
I think that some "GitHub flow templates" might have an error.

What you expected to happen
It's doesn't look nice
How to reproduce
Create a fork from DevLake
Create a branch with a fix
Create a pull request from your repo to devlake repo, like here

Check the text message. It containst "nbsp;" in plain text. not nice
Anything else
Smile, you are being recorded as a part of our stream at https://www.meetup.com/twosseng/
8 participants are benefitting from learning how high quality project work and how they can contribute to these project.
Version
main
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

happy coding

Hi, @nikitakoselev, Are you working on it?

No, I've left it as a good first time issue
On Fri, 26 Aug 2022, 04:20 Klesh Wong, @.***> wrote:

Hi, @nikitakoselev https://github.com/nikitakoselev, Are you working on
it?
—
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-devlake/issues/2511#issuecomment-1228007179,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABQWQ6RHPXC2QNUMXWLNUXDV3AZXTANCNFSM53XYSG6A
.
You are receiving this because you were mentioned.Message ID:
@.***>

I see, thanks


How to handle TypeScript Package?

I write packages in TypeScript (of course. :smile:) and used to expose them directly as .ts. This is possible as I use jspm.
Now as I try to get typings to work.  I am trying to compile them to .js and .d.ts but having some issues.
In stepping back, is it possible to use typings to include the .ts file directly?
I know that adding the file to tsconfig.json would work, but it is quite a manual process:
{
  "files": [
    ...
<EMAIL_ADDRESS>    ...
  ]
}

Currently no, Typings is only operating on .d.ts files and will be confused with .ts files. It's possible to add support for resolving .ts also, but wasn't currently on any roadmap.

Closing as answered. I don't think interpreting .ts files directly is a good investment of time (or a good idea to support), sorry!


{Dependency,Plugin}UpdatesReport overhaul

I see that there's quite some code duplication between DependecyUpdatesReport and PluginUpdatesReport. The classes could possibly use some refactoring. Plus maybe a name change to be in line with the convention (name should probably end with Mojo).
Speaking of which, DependencyUpdatesRenderer uses a completely different interface than DependencyUpdatesXmlRenderer. There's no common factory or a common interface to use the two and the user classes, need to create and handle the two different classes differently.
Here we should create a common API with probably a common abstract factory to instantiate the correct implementation of the renderer.
I appreciate this is not a functional nor a performance issue, but rather a code quality one. I will gladly take it.

Heads up: it looks like using dependency inversion can offer much here, going with it.

Extra item to do: convert xml report generators to "real" ReportGenerators using e.g. the RandomAccessSink or the normal text sink. Then it would be possible to generate those XML reports from <reporting/> too. The execute() invocation would be slightly different, it would simply delegate the generation to two different renderers (with their two different sinks).

Also, this is probably wrong:
If a dependency is in both management and normal dependencies, the one from management will get overwritten.
allUpdates = new TreeMap<>( new DependencyComparator() );
allUpdates.putAll( model.getDependencyManagementUpdates() );
allUpdates.putAll( model.getDependencyUpdates() );

Still work in progress, so far have introduced a common model for the renderers and changed renderers into injectable components. It's not done yet -- I'd like to use a templating engine like Velocity. Sadly, it's not possible to inject a "context" into AptParser, otherwise I'd use it and would create a few macros to process content.
For now, refactored and unified the renderers.
https://github.com/mojohaus/versions-maven-plugin/compare/master...ajarmoniuk:versions-maven-plugin:doxia-renderers

Please close @slawekjaranowski @slachiewicz


[BUG_FIX] : Updated subs_create_payment200_response import issue in api_client.py

Summary
When testing it for integrating I encountered this error which was saying ModuleNotFoundError

I dig down that and found out that the import was wrong and I have fixed that import in api_client.py

Thank you for pointing this. There are some more things that has to be done to make this live. We will fix it from our end.

Hi @AlankarSaxena2712
Please use 4.2.3
This should be fixed in that version