Tool for Perf Automation

Fixes #1305

/azp run tools - perf-automation

Hey Mike, I was reading through this and the thing that struck me is that there is a lot of knowledge about how to prepare and build each repository baked into this tool. Would it be easier (better?) for there just to be a simple script in each repo that you could invoke which takes some high level details (package name etc) to do all the setup and execute the stress run?

I agree we should avoid specific knowledge about how to build each language hard-coded inside this tool. It doesn't lend well to maintaining overtime. The knowledge of how to build and run tests in a language should live with the language repo itself.

@mikeharder have you looked at the System.CommandLine packages for command-line arg parsing. It takes a lot of the work out of setting it up. You can even specify a Main method with the arguments that you want to accept and it translates from the command-line for you.

@weshaggard, @benbp: I understand the feedback about splitting this tool and having the language-specific parts live in each language repo.  However, the way we currently run perf tests (across all languages in the same run), I think this would actually make maintenance more difficult.  I think a centralized approach is the best for now but I will be the first to want to refactor this if it becomes a problem to maintain.

@mikeharder I would prefer that we not merge this. I've been working hard to remove all these external dependencies like this as they are very difficult to maintain long-term across teams. I've spent a long time and still working on improving our spec-to-sdk automation for example which has duplicated parts of our build process in other automation and every time we make a change to our builds we break that process. I get that we want to run all the perf tests across all the languages but in order to do that we already have to clone all the language repos so moving these build steps into those language repos shouldn't be to much work and I'd prefer we do it from the start because it will only become more costly overtime. There have been too many cases where I see we break some process external to the repo that was duplicating something in the repo and instead of fixing it the correct way we just keep tweaking the external system and so it never gets fixed the correct way which is why I'd like to see this done correctly from the start.
It seems to me all we need to do is define some sort of interface in each of the repos, perhaps just a script entry point or maybe a config file like we do for sdk automation (https://github.com/Azure/azure-sdk-for-net/blob/main/eng/swagger_to_sdk_config.json), but once we define that the external perf infrastructure should be able to call into the language repo to handle the language specific aspects of building and running the tests.  That will ensure that when we do something like change the build in some way we can find and update all those steps in the language repo as opposed to another hard-coded tool in some other repo to make things continue to work.


CLI does not dereference $refs

Perhaps this is by design, but i feel as this might deserve a mention in the readme.
Was scratching my head trying to figure out why the CLI and node module were turning out different statistics, the $refs being the culprit.
Provided that the node module expects a parsed object then it is up to the client to decide if the document should be dereferenced or not. Given that the CLI takes the file directly, then the dereferencing responsibility is (arguably) moved onto the CLI and its internal parser.
OR
Simply mention in the readme that the CLI will not dereference. Could perhaps be added as a option?
My two cents,
Herman

@dpopp07

@dpopp07

@hpl002 I'm not sure what you mean so may need some more info.
The CLI validator does resolve references. What behavior are you seeing that indicates otherwise?
If the output from CLI and node module are different, there may be a bug for us to address. In that case, will you send the discrepancy you are seeing in the output?
Or even better, if you can link us to your OpenAPI document, we can try to reproduce on our end.

@hpl002 I'm not sure what you mean so may need some more info.
The CLI validator does resolve references. What behavior are you seeing that indicates otherwise?
If the output from CLI and node module are different, there may be a bug for us to address. In that case, will you send the discrepancy you are seeing in the output?
Or even better, if you can link us to your OpenAPI document, we can try to reproduce on our end.

Create a tiny working example: https://github.com/hpl002/issue-ibm-openapi-validator

Create a tiny working example: https://github.com/hpl002/issue-ibm-openapi-validator

Thanks for putting that together, I will check it out.

Thanks for putting that together, I will check it out.

any updated on this?

any updated on this?

Was not able to look at it yesterday, planning on looking today

Was not able to look at it yesterday, planning on looking today

@hpl002 Okay I know what is going on. There are two main factors at play in your diff:

The CLI dereferences the spec just fine but it also keeps the unresolved spec and performs validation on both. When you dereference the spec in your own code, before calling the validator, you lose the original information. That is why when you run the tool on the already resolved spec, you get warnings like

Response schemas should be defined with a named ref.

The tool looks for $ref fields in the original spec and does other processing on the fully resolved spec.

There is a file that is looking at only the original (unresolved) spec and performing validations. This was written with only one file in mind - using a multi-file spec leads to missed validations. This is the explanation for the warning:

Schema properties must have a description with content in it.
which was present when validating the already resolved spec.

This is a bug on our part, so I will make a note to fix it.
Just to let you know, my results were different than what you detailed in your index.js file. I got 7 warnings for the original spec and 13 warnings for the fully resolved spec. I am guessing that the 6 extra were the same as your 6 extra (consisting of the two messages above) but if not, let me know so I can see if there are other bugs.
I will also say, for clarity, both the CLI and node module will always dereference the spec and process the original spec alongside the resolved spec. There should not be a need to resolve the spec yourself in either case.

@hpl002 Okay I know what is going on. There are two main factors at play in your diff:

The CLI dereferences the spec just fine but it also keeps the unresolved spec and performs validation on both. When you dereference the spec in your own code, before calling the validator, you lose the original information. That is why when you run the tool on the already resolved spec, you get warnings like

Response schemas should be defined with a named ref.

The tool looks for $ref fields in the original spec and does other processing on the fully resolved spec.

There is a file that is looking at only the original (unresolved) spec and performing validations. This was written with only one file in mind - using a multi-file spec leads to missed validations. This is the explanation for the warning:

Schema properties must have a description with content in it.
which was present when validating the already resolved spec.

This is a bug on our part, so I will make a note to fix it.
Just to let you know, my results were different than what you detailed in your index.js file. I got 7 warnings for the original spec and 13 warnings for the fully resolved spec. I am guessing that the 6 extra were the same as your 6 extra (consisting of the two messages above) but if not, let me know so I can see if there are other bugs.
I will also say, for clarity, both the CLI and node module will always dereference the spec and process the original spec alongside the resolved spec. There should not be a need to resolve the spec yourself in either case.


handle unary expressions

Previously nodes with a type of UnaryExpression weren't being handled and would throw an error for an unexpected node type.
This PR handles the unary negation and unary plus operators as ast.Value types and assigns the values by multiplying by 1 or -1.

Released in 1.2.0


Remove leftover code bits about auth0

Thanks to @GeorgianaElena's amazing work, we no longer use auth0 for anything! This completely gets rid of the code we wrote to support it.
YAY FOR GETTING RID OF CODE!

THANK YOU SO MUCH FOR SPEARHEADING THIS EFFORT, @GeorgianaElena!!!


Pakace in Pypi might be good idea too

Not all CI are in GitHub and creating package to Pypi would be also nice.

one of the problems with Docker approach is that GitHub Actions cannot run docker on Win runners

Two things are needed:

semantic versioning in GitHub actions
package publishing

as an example pipeline from pytest-rts package could be used

Relevant files:

Commit Message Format in CONTRIBUTING.md
setup.py
Makefile

BTW what would be the right name for the repo/package?

fliprate_actions
fliprate-actions
or maybe we need better name like flaky-tests-detection, or something similar?

@tatu-aalto, @alexey-vyskubov, @oikarinen-fs?

When looking from Python code point of view, name with underscore is better. Based on famous gut feeling, flaky_tests_detection feels better because it describes what we are trying to achieve.

I think that is done now, @oikarinen-fs please reopen if there is still something to do.


feat: Elements less than some value of a sorted tuple are at the beginning of the tuple.

For a sorted (monotone) tuple containing n elements with exactly r elements less than or equal some value, all these elements are at the first r locations of the tuple.
Proofs by @Ruben-VandeVelde , @ericrbg @eric-wieser see Zulip Thread

You don't have to put in who wrote the proof! Thought is appreciated though :) I think splitting off the lemma that EricW said would be good

You don't have to put in who wrote the proof! Thought is appreciated though :) I think splitting off the lemma that EricW said would be good

Which suggestion for a split off lemma do you mean? Which lemma?

Do you mean this suggestion:
@_Eric Wieser|310045 said:
The proof would probably be clearer with a `calc` block or `transitivity` where that `show` is

No, this one:
/-- All the elements `· ≤ a` appear the start of a sorted tuple -/
lemma wierd2' {α} [LinearOrder α] (m : ℕ) (f : Fin m → α) (a : α)
    (h_sorted : Monotone f)
    (j : Fin m) (h : j < Fintype.card {i // f i ≤ a}) :
    f j ≤ a := by

No, this one:
/-- All the elements `· ≤ a` appear the start of a sorted tuple -/
lemma wierd2' {α} [LinearOrder α] (m : ℕ) (f : Fin m → α) (a : α)
    (h_sorted : Monotone f)
    (j : Fin m) (h : j < Fintype.card {i // f i ≤ a}) :
    f j ≤ a := by

But that is exactly what is in the PR:
I just called it a different name sort_lt_at_start_of_monotone
theorem sort_lt_at_start_of_monotone {α} [LinearOrder α] (m : ℕ) (f : Fin m → α) (a : α)
    (h_sorted : Monotone f)
    (j : Fin m) (h : j < Fintype.card {i // f i ≤ a}) :
    f j ≤ a := by

apologies! I'm clearly asleep at the wheel...

So you are requiring LE.le on the type to be decidable. But since we have the condition of cardinality of (. <= a) we have already compared against all elements and came up with true or false answers. By transivity of LE all the elements are comparable and we are back to linear order.
Unless you want to replace LinearOrder with a predicate about comparison between the m elements and the comparer a
I think what you is basically LinearOrder.
Can you think of an example satisfying PartialOrder and Decidable LE but not a LinearOrder?

We've compared all elements against a. Because the order is partial you cannot just flip. The relation ≤ on N given by a ≤ b iff a = b is decidable, but is not linear.

Can you think of an example satisfying PartialOrder and Decidable LE but not a LinearOrder?

Yes,  α = Finset Nat, which orders by subset inclusion

✌ MohanadAhmed can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

bors r+
Thanks a lot @ocfnash


chore: add codecov

What does this PR do?
Add code coverage to continuous integration.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@7eb124d). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             main       #17   +/-   ##
========================================
  Coverage        ?   100.00%
========================================
  Files           ?         2
  Lines           ?        42
  Branches        ?         6
========================================
  Hits            ?        42
  Misses          ?         0
  Partials        ?         0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eb124d...80b94cc. Read the comment docs.


aws-c-sdkutils do_configure failure when ptest is enabled

When ptest is enabled, aws-c-sdkutils do_configure fails with error messages like below:
-- Performing Test HAVE_SYSCONF
-- Performing Test HAVE_SYSCONF - Success
CMake Error at /ala-lpggp72/qichen/WRL/build-aws/tmp-glibc/work/core2-64-wrs-linux/aws-c-sdkutils/0.1.12-r0/re
cipe-sysroot/usr/lib64/cmake/AwsFindPackage.cmake:19 (find_package):
By not providing "Findaws-c-common.cmake" in CMAKE_MODULE_PATH this project
has asked CMake to find a package configuration file provided by
"aws-c-common", but CMake did not find one.
Could not find a package configuration file provided by "aws-c-common" with
any of the following names:
aws-c-commonConfig.cmake
aws-c-common-config.cmake

Add the installation prefix of "aws-c-common" to CMAKE_PREFIX_PATH or set
"aws-c-common_DIR" to a directory containing one of the above files.  If
"aws-c-common" provides a separate development package or SDK, be sure it
has been installed.
Call Stack (most recent call first):
CMakeLists.txt:70 (aws_use_package)
-- Configuring incomplete, errors occurred!
WARNING: exit code 1 from a shell command.
The ptest is enabled as below:
DISTRO_FEATURES:append          = " ptest"
EXTRA_IMAGE_FEATURES    += " ptest-pkgs"
PTEST_ENABLED                   = "1"
Some directory hierarchy:
$ find recipe-sysroot -name "aws-c-common*"
recipe-sysroot/sysroot-providers/aws-c-common
recipe-sysroot/usr/lib64/aws-c-common
recipe-sysroot/usr/lib64/aws-c-common/cmake/aws-c-common-config.cmake
recipe-sysroot/usr/lib64/aws-c-common/cmake/shared/aws-c-common-targets.cmake
recipe-sysroot/usr/lib64/aws-c-common/cmake/shared/aws-c-common-targets-debug.cmake

To reproduce the problem, multilib needs to be enabled.
e.g.,
MACHINE = "qemux86-64"
require conf/multilib.conf
MULTILIBS ?= "multilib:lib32"
DEFAULTTUNE:virtclass-multilib-lib32 ?= "core2-32"


Delete objects not in source - functionality

Thanks for developing this great tool. Its making our lives much easier while deploying adf code.
I'm facing trouble with "Delete objects not in source" option.
I have three pipelines (pipeline1, pipeline2, pipeline3) in target adf already
I want to deploy only pipeline2(updated), delete pipeline3 and no changes to pipeline1.
note: pipeline3 has been deleted from source. So it has to be deleted from target as well.
So I have updated my rules.txt as below
-pipeline.pipeline1
+pipeline.pipeline2
And I have selected "Delete objects not in source" option as I want to delete pipeline3
And also selected "Do not delete excluded objects" (in Advanced tab) as I don't want to delete excluded pipeline1 from deployment.
But pipeline3 is not deleted from target when I run the cicd pipeline.
If i uncheck "Do not delete excluded objects" then pipeline3 from target adf is getting deleted.
When I check the log says
Removing excluded object: [Pipeline].[pipeline3] as publish option 'DoNotDeleteExcludedObjects' = false.
As per the rules.txt the excluded object is pipeline1 but not sure why it is saying excluded object as pipeline3 in the logs.
Is the option "Do not delete excluded objects" applicable for objects not in source (pipeline3 in this case) or the objects excluded from deployment as per rules.txt?
I'm attaching rules.txt and logs file with or without selecting "Do not delete excluded objects".
tasklog_6.log
tasklog_6_Do_not_delete_excluded_objects.log
rules (1).txt

First of all, you can't use include and exclude rules together. See documentation:
https://github.com/SQLPlayer/azure.datafactory.tools#publish-options

Bear in mind that Includes and Excludes lists are rules out each other.
Objects would be excluded from deployment only if Includes list remains empty.
When both lists are empty - all objects going to be published.

In your case, you don't have to use "Do not delete excluded objects" option because pipeline1 still exists in the source, so will not be deleted in the target even though it is excluded from the deployment.


ref(go.mod): oras v0.8.0

Upgrade to oras 0.8.0
Still 2 replace statements in go.mod needed, hoping to follow up soon to get rid of them completely...

Hey @hickeyma and @jdolitsky! I'm trying to gauge whether this should go in for 3.0.0 or not. Since OCI support is an experimental feature of Helm, I'm thinking this should go into 3.1.0. This is one of the rare exceptions where breaking changes can be rolled along as oras continues to iterate. I'm also concerned about merging in a change that seemingly downgrades the docker client libraries.
What are your thoughts on this?

I'm happy to punt this. The whole oras 0.8 release came out of discussion w Martin about non-release version of containerd, which is only used in the experimental stuff.
Although it appears that github.com/Azure/go-autorest wasnt actually present in go.sum, does this mean it was in use? It looks like pkg github.com/Azure/go-autorest/autorest is still locked down:
github.com/Azure/go-autorest/autorest v0.9.0 h1:MRvx8gncNaXJqOoLmhNjUAKh33JJF8LyxPhomEtOsjs=
github.com/Azure/go-autorest/autorest v0.9.0/go.mod

The reason behind this was because ORAS and as a consequence Helm was using unreleased containerd and docker modules. It is best practice to try and release with dependencies modules that are released.
This also  has a knock on effect to apps using Helm as a client. An example is the Helm 2to3 plugin which needs to replace docker module as follows:
github.com/docker/docker => github.com/docker/docker v0.0.0-20190731150326-928381b2215c.
I am not sure about Azure's go-autorest client libraries. Why are they need by Helm?

My hesitation on this is that we are in a release candidate phase. That means we should only be merging in fixes for significant bugs to 3.0.0. We're past the point that dependency updates should go in on their own.

@mattfarina I agree with your response. It is probably too late in the day now that we are in the RC phase.

@jdolitsky Good catch on autorest.  That replace statement was part of the original setup for Go modules to support Kubernetes. Since that is no longer being imported this replace can be dropped as part of another PR.

updated a few more things, this should be good to merge

This is rebased and should be ready for re-review


Update Upstash Logo for White Background

This PR replaces the Upstash Vector Store logo with a new version that fits to a white background.

thanks!


c#/blazor Integration + component tests (UI)

[ ] for UI (Blazor) use bUnit test: https://github.com/bUnit-dev/bUnit on top of nunit or xunit (slightly better)
[ ] look at test frameworks like Selenium
[ ] look at regression test best practices

https://docs.microsoft.com/de-de/aspnet/core/blazor/test?view=aspnetcore-5.0

Why Regression Test Blazor Components?

Catch Breaking Changes: Regression testing helps detect unintended consequences of changes, ensuring that existing functionality remains intact.
Maintain Component Stability: Regular testing prevents component drift, ensuring that your Blazor app remains stable and reliable.
Improve Code Quality: Regression testing encourages writing better, more maintainable code, as developers are more likely to consider the impact of changes on existing functionality.
Choosing a Testing Framework
bUnit: A popular, community-driven testing library for Blazor components, providing a simple and intuitive API for writing unit tests.
xUnit: A widely-used, general-purpose testing framework that can be used with bUnit to write unit tests for Blazor components.
Playwright for .NET: An end-to-end testing framework for Blazor apps, allowing you to test components in a browser-like environment.
Regression Testing Strategies
Component-Based Testing: Focus on individual components, testing their behavior, and interactions with other components.
Scenario-Based Testing: Define scenarios that exercise specific functionality, such as user interactions or API calls.
Data-Driven Testing: Use data-driven approaches to test components with varying input data, ensuring they handle different scenarios correctly.
Best Practices
Write Tests Before Implementation: Test-driven development (TDD) ensures that components are designed with testability in mind.
Use Mocking and Stubs: Isolate dependencies and mock external services to simplify testing and improve test speed.
Test for Edge Cases: Include tests for unusual or corner-case scenarios to ensure component robustness.
Automate Testing: Use CI/CD pipelines to run regression tests automatically, ensuring consistent testing across builds and environments.
Monitor Test Results: Track test metrics and trends to identify areas for improvement and optimize testing efforts.


NIFI-3061 PutAzureEventHub blocks after network interruption

This change maintains status quo and does not enable the existing unit tests. The change was tested against NIFI-3061.xml though. As mentioned in NIFI-3070, there isn't a good way to provide meaningful unit tests so integration tests should be added as a new improvement.

[X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
[X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
[X] Has your PR been rebased against the latest commit within the target branch (typically master)?
[X] Is your initial contribution a single, squashed commit?
[X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?

Reviewing...

I've confirmed the upgrade works without problem using my Azure environment. +1, merged into master.
I agree with the idea of improving integration test. Thank you, @jfrazee !!


fix(body): validate body code to be 3 letters

Forced Body Code to be 3 letters long.
Furthermore in attached issue https://myaegee.atlassian.net/browse/MA-202

:tada: This PR is included in version 1.33.8 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Edit defaults

I have been testing the package and I think it would be interesting to allow editing of the default values.
The main problem I found is that I have to keep the user waiting 10 seconds to notify them that they have no internet. It would be very useful to be able to edit this default value

I'll add it in the next release @adri195

Is there any update on editing the default values like timeout, address etc?

if you want to set a timeout letter than 10 seconds you can set it by yourself, something like this:
try {       bool result = await InternetConnectionChecker().hasConnection.timeout(Duration(seconds: 5));       return result;     }catch (e) {       return false;     }

@rakesh0689 The update on editing the default values like timeout, address is available now in the latest version of the plugin


Add embed + NN test

Breaks on factory:
vespa/container-search/src/test/java/com/yahoo/search/searchers/ValidateNearestNeighborTestCase.java:[85,93] incompatible types: com.yahoo.tensor.TensorType cannot be converted to com.yahoo.search.schema.RankProfile.InputType


Hi Mark,
our fuzzing system found the same issue on FreeBSD and Linux tonight. :)

I fixed a some issues reported by OSS-Fuzz. I think the commit https://github.com/sctplab/usrsctp/commit/54f46950f494df7af9f61b617686ffa50a52815c fixes this issue. Can you retest and report?

Retested, and the fix above does address this issue. Closing.


Test run parameter added as part of CLI runsettings args

The following error is shown when TestRunParameter Argument is invalid.

Resources files need to be added

Update the docs, probably add a one pager on the vstest-docs

@mayankbansal018 Are you fine with the changes ? Just wanted to get a second opinion regarding the format expected from the user

Can we add acceptance tests for this?

d a

Are there doc updates to describe how to use this new capability? Or screenshots for this PR?

@hvinett : would you be able to point folks to docs for this in the main issue(#862) and close it out please?
/cc: @singhsarab


Merge hotfix from #119 into develop

This PR will merge the changes from #119 into develop.
It looks like #118 and #121 are in the commit log even though they were merged in #125, but that's probably because #125 was squashed-and-merged. For future merges from master to develop we might want to consider not squashing the merge.

Looks like this didn't work properly. I'll close and try again.


The use of the ToListAsync method leads to missing data in version 2.1.0 of Microsoft.AspNetCore.All

Hello everybody!
I have an issue since I changed one of my Asp.Net Core projects to target .Net Core 2.1 and updated to the version 2.1.0 of the Microsoft.AspNetCore.All NuGet package. I'm not sure if this is an EF Core issue so move this in the appropriate repo if necessary!
I'm attaching a demo project that reproduces the issue. The url to the controller's test action is _http://localhost:8099/demo/test_.
If someone changes the version of the Microsoft.AspNetCore.All package from 2.1.0 back to 2.0.8 everything works as intended.
So, I have an entity with two details.
public class User
{
    public int Id { get; set; }
    public string UserName { get; set; }

    public ICollection<Email> Emails { get; set; }
    public ICollection<Phone> Phones { get; set; }
}

What I want is to build a query and then execute it asynchronously using the ToListAsync extension. Since the details implement ICollection, in order to select specific fields, I use the ToList extension. But that would lead to the execution of the query before the call of the ToListAsync. So I figured out a way to avoid this by using the Task.FromResult method (I don't know if this is the best solution though).
var query = _dbContext.Users
    .Select(user => new User
    {
        Emails = Task.FromResult(user.Emails.Select(email => new Email { Address = email.Address }).ToList()).Result,
        Phones = Task.FromResult(user.Phones.Select(phone => new Phone { Number = phone.Number }).ToList()).Result
    });

var result = await query.ToListAsync();

The problem is that, after the call of the ToListAsync, only the second detail (Phones) has data and the first one (Emails) is empty. The problem disappears when I change back to version 2.0.8 of the Microsoft.AspNetCore.All package.
The Debug Output of the 2.1.0 version during the execution of the ToListAsync method is:

Microsoft.EntityFrameworkCore.Database.Command:Information: Executed DbCommand (0ms) [Parameters=[], CommandType='Text', CommandTimeout='30']
PRAGMA foreign_keys=ON;
Microsoft.EntityFrameworkCore.Database.Command:Information: Executed DbCommand (1ms) [Parameters=[], CommandType='Text', CommandTimeout='30']
SELECT "user"."Id"
FROM "Users" AS "user"
ORDER BY "user"."Id"
Microsoft.EntityFrameworkCore.Database.Command:Information: Executed DbCommand (0ms) [Parameters=[], CommandType='Text', CommandTimeout='30']
SELECT "t"."Id", "user.Emails"."Address", "user.Emails"."UserId"
FROM "Emails" AS "user.Emails"
INNER JOIN (
SELECT "user0"."Id"
FROM "Users" AS "user0"
) AS "t" ON "user.Emails"."UserId" = "t"."Id"
ORDER BY "t"."Id"
Microsoft.EntityFrameworkCore.Database.Command:Information: Executed DbCommand (0ms) [Parameters=[], CommandType='Text', CommandTimeout='30']
SELECT "t0"."Id", "user.Phones"."Number", "user.Phones"."UserId"
FROM "Phones" AS "user.Phones"
INNER JOIN (
SELECT "user1"."Id"
FROM "Users" AS "user1"
) AS "t0" ON "user.Phones"."UserId" = "t0"."Id"
ORDER BY "t0"."Id"

which is different from the Debug Output of the 2.0.8 version:

Microsoft.AspNetCore.Server.Kestrel:Warning: Heartbeat took longer than "00:00:01" at "06/14/2018 12:09:33 +00:00".
 Any ideas?
Thanx everyone in advance!
Further technical details
EF Core version: 2.1.0
Database Provider: Microsoft.EntityFrameworkCore.Sqlite
Operating system: win10 1703
IDE: Visual Studio 2017 15.7.3

@pavlospap I wasn't able to completely follow your intention, but if it is to load Users together with their Emails and Phones, then the normal way to do this is with Include:
var users = await _dbContext.Users
    .Include(e => e.Emails)
    .Include(e => e.Phones)
    .ToListAsync();

@ajcvickers thank you very much for your response but this is not what I need since, this way, every Email's and Phone's column will be included in the select statement in the query that will be executed in the database. I need to include only specific columns.

using System;
using System.Collections.Generic;
using System.Linq;
using System.Threading.Tasks;
using Microsoft.EntityFrameworkCore;
using Microsoft.Extensions.Logging;

namespace EFSampleApp
{
    public class Program
    {
        public static void Main(string[] args)
        {
            using (var db = new MyContext())
            {
                // Recreate database
                db.Database.EnsureDeleted();
                db.Database.EnsureCreated();

                // Seed database
                db.Add(new User
                {
                    UserName = "Test",
                    Emails = new List<Email>
                    {
                        new Email{ Address = "abc"}
                    },
                    Phones = new List<Phone>
                    {
                        new Phone
                        {
                            Number = 124
                        }
                    }
                });

                db.SaveChanges();
            }

            using (var db = new MyContext())
            {
                // Run queries
                var query = db.Users
                    .Select(user => new User
                    {
                        Emails = Task.FromResult(user.Emails.Select(email => new Email { Address = email.Address }).ToList()).Result,
                        Phones = Task.FromResult(user.Phones.Select(phone => new Phone { Number = phone.Number }).ToList()).Result
                    });
                var result = query.ToListAsync().GetAwaiter().GetResult();

                Console.WriteLine(result[0].Emails.Count);
                Console.WriteLine(result[0].Phones.Count);
            }

            Console.WriteLine("Program finished.");
        }
    }

    public class MyContext : DbContext
    {
        private static ILoggerFactory LoggerFactory => new LoggerFactory().AddConsole(LogLevel.Trace);

        // Declare DBSets
        public DbSet<Blog> Blogs { get; set; }
        public DbSet<User> Users { get; set; }

        protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
        {
            // Select 1 provider
            optionsBuilder
                .UseSqlServer(@"Server=(localdb)\mssqllocaldb;Database=_ModelApp;Trusted_Connection=True;Connect Timeout=5;ConnectRetryCount=0")
                //.UseSqlite("filename=_modelApp.db")
                //.UseInMemoryDatabase(databaseName: "_modelApp")
                .EnableSensitiveDataLogging()
                .UseLoggerFactory(LoggerFactory);
        }

        protected override void OnModelCreating(ModelBuilder modelBuilder)
        {
            // Configure model
        }
    }

    public class Blog
    {
        public int Id { get; set; }
    }

    public class User
    {
        public int Id { get; set; }
        public string UserName { get; set; }

        public ICollection<Email> Emails { get; set; }
        public ICollection<Phone> Phones { get; set; }
    }

    public class Email
    {
        public int Id { get; set; }
        public string Address { get; set; }
    }

    public class Phone
    {
        public int Id { get; set; }
        public int Number { get; set; }
    }
}

Generates output as 0 & 1 instead of 1 & 1. Potential data corruption issue.
Used to work correctly in 2.0 release. Issue in correlated subquery optimization.

@smitpatel you are absolutely right! I was pretty sure that ToList would cause the Queryable to enumerate. I don't know why I had that idea. I saw the Debug Output and, indeed, nothing happens before ToListAsync is executed. Was that always the case with previous versions? Because I really thought I've seen, during the debugging process, db queries being executed before ToListAsync was called. Obviously I was wrong. Thank you very much for the explanation.

Problem is in the TaskLiftingExpressionVisitor. We get the following expression as input:
Emails = Task<List<Email>> FromResult(List<Email> Result(Task<List<Email>> Unhandled parameter: queryContext.QueryBuffer.CorrelateSubqueryAsync(
	correlatedCollectionId: 0,
	navigation: User.Emails,
	resultCollectionFactory: (INavigation n) => new List<Email>(),
	outerKey: new MaterializedAnonymousObject(new object[]{ (object)!(Unhandled parameter: user.IsEmpty) ? Nullable<int> TryReadValue(Unhandled parameter: user, 0, User.Id) : default(Nullable<int>) }),
	tracking: False,
	correlatedCollectionFactory: (Func<IAsyncEnumerable<Tuple<Email, MaterializedAnonymousObject, MaterializedAnonymousObject>>>)() => IAsyncEnumerable<Tuple<Email, MaterializedAnonymousObject, MaterializedAnonymousObject>> _ShapedQuery(
		queryContext: Unhandled parameter: queryContext,
		shaperCommandContext: SelectExpression:
			SELECT [t].[Id], [user.Emails].[Address], [user.Emails].[UserId]
			FROM [Email] AS [user.Emails]
			INNER JOIN (
				SELECT [user0].[Id]
				FROM [Users] AS [user0]
			) AS [t] ON [user.Emails].[UserId] = [t].[Id]
			ORDER BY [t].[Id],
		shaper: TypedProjectionShaper<...>),
	correlationPredicate: (MaterializedAnonymousObject o | MaterializedAnonymousObject i) => object i.GetValue(0) == default(object) || object o.GetValue(0) == default(object) ? False : (Nullable<int>)(int)object o.GetValue(0) == (Nullable<int>)object i.GetValue(0),
	cancellationToken: Unhandled parameter: ct))).Result,

and it gets lifted twice (FromResult call and CorrelateSubqueryAsync call):
Task<User> _ExecuteAsync(
    taskFactories: new Func<Task<object>>[]
    {
        () => Task<object> _ToObjectTask(Task<List<Email>> FromResult(List<Email> Result(Task<List<Email>> Unhandled parameter: queryContext.QueryBuffer.CorrelateSubqueryAsync(
            correlatedCollectionId: 0,
            navigation: User.Emails,
            resultCollectionFactory: (INavigation n) => new List<Email>(),
            outerKey: new MaterializedAnonymousObject(new object[]{ (object)!(Unhandled parameter: user.IsEmpty) ? Nullable<int> TryReadValue(Unhandled parameter: user, 0, User.Id) : default(Nullable<int>) }),
            tracking: False,
            correlatedCollectionFactory: (Func<IAsyncEnumerable<Tuple<Email, MaterializedAnonymousObject, MaterializedAnonymousObject>>>)() => IAsyncEnumerable<Tuple<Email, MaterializedAnonymousObject, MaterializedAnonymousObject>> _ShapedQuery(
                queryContext: Unhandled parameter: queryContext,
                shaperCommandContext: SelectExpression:
                    SELECT [t].[Id], [user.Emails].[Address], [user.Emails].[UserId]
                    FROM [Email] AS [user.Emails]
                    INNER JOIN (
                        SELECT [user0].[Id]
                        FROM [Users] AS [user0]
                    ) AS [t] ON [user.Emails].[UserId] = [t].[Id]
                    ORDER BY [t].[Id],
                shaper: TypedProjectionShaper<...>),
            correlationPredicate: (MaterializedAnonymousObject o | MaterializedAnonymousObject i) => object i.GetValue(0) == default(object) || object o.GetValue(0) == default(object) ? False : (Nullable<int>)(int)object o.GetValue(0) == (Nullable<int>)object i.GetValue(0),
            cancellationToken: Unhandled parameter: ct)))),
        () => Task<object> _ToObjectTask(Task<List<Email>> Unhandled parameter: queryContext.QueryBuffer.CorrelateSubqueryAsync(
            correlatedCollectionId: 0,
            navigation: User.Emails,
            resultCollectionFactory: (INavigation n) => new List<Email>(),
            outerKey: new MaterializedAnonymousObject(new object[]{ (object)!(Unhandled parameter: user.IsEmpty) ? Nullable<int> TryReadValue(Unhandled parameter: user, 0, User.Id) : default(Nullable<int>) }),
            tracking: False,
            correlatedCollectionFactory: (Func<IAsyncEnumerable<Tuple<Email, MaterializedAnonymousObject, MaterializedAnonymousObject>>>)() => IAsyncEnumerable<Tuple<Email, MaterializedAnonymousObject, MaterializedAnonymousObject>> _ShapedQuery(
                queryContext: Unhandled parameter: queryContext,
                shaperCommandContext: SelectExpression:
                    SELECT [t].[Id], [user.Emails].[Address], [user.Emails].[UserId]
                    FROM [Email] AS [user.Emails]
                    INNER JOIN (
                        SELECT [user0].[Id]
                        FROM [Users] AS [user0]
                    ) AS [t] ON [user.Emails].[UserId] = [t].[Id]
                    ORDER BY [t].[Id],
                shaper: TypedProjectionShaper<...>),
            correlationPredicate: (MaterializedAnonymousObject o | MaterializedAnonymousObject i) => object i.GetValue(0) == default(object) || object o.GetValue(0) == default(object) ? False : (Nullable<int>)(int)object o.GetValue(0) == (Nullable<int>)object i.GetValue(0),
            cancellationToken: Unhandled parameter: ct)),

Same CorrelateCollection call (i.e. same correlatedCollectionId) is executed twice. Both executions share the same enumerator, so the first time it populates all entities, and second one finds nothing - hence the 0 elements we are seeing;

fixed in 3d2ba391cc1d8d6cc7b0a67ced4539067ad07a64


Notice Undefined offset: 1 in Line 172 SymmetricEncryptedText.module

When in debug mode using tracy in PW i often get an notice.
I guess its because the  explode('|', $rawinput); in line 172 does not like having no pipe delimiter in $rawinput.
Instead of doing
if(! $input) return $rawinput;
after explode , simply do a
if(strpos($rawinput,"|") ===false) return $rawinput;
before.

@NikoTechnik : I'm closing this issue for now. Feel free to reopen it if the fix doesn't work for you.


feat: define sugaroid's personality

Ok

pushed again, does it look right now?

pushed again, does it look right now?

Yesh, looks great now


Page State is Lost on Back Navigation when Navigating Back More Than 1 Page

This is a (multiple allowed):

[x] bug

[ ] enhancement

[ ] feature-discussion (RFC)

Framework7 Version: 1.6.4

Platform and Target: iOS

What you did
Use router.loadContent() to load content for new pages. Page A > Page B > Page C. Content of Page A is also loaded dynamically. There are also events assigned to DOM elements of each page with scope (not global).
Expected Behavior
When clicking back twice, Page A should be back in the center with existing content and events assigned to it.
Actual Behavior
Content of Page A disappeared. Page A is essentially reverted back to original state before content is loaded and events are assigned.
Expected Solution
Give developer control the stage of pages retained in the cache. The latest stage of the page should be cached instead of original state. If developer wanted to reload the page, they would have force it to reload especially when that option already exists in the framework.

I have the same error the navbar with the index.html web.html is duplicated
it generated two navbar =??

I have the exact same issue. I'm using nested views (using tabs) and have very tight control of which view (nested or not) is currently on screen. I'm opting to show the contents of the new page in a popup so I don't get the first page removed.

Same problem here :(

Let me be clear that I understand why it's being done. Browser generally downgrades in performance when there's too many DOM elements on the page til it pretty much freezes (last I tested in 2012 was 100k+, not sure what it is now). What I would typically do is detach it without unassign events so that I can just reattach it back. Since it's only in memory (stored in a variable), the browser doesn't have any issues (well, to a certain extent, but much more than keeping everything in the DOM). What I'm seeing in the behavior of Framework7 is that Page A is inserted back into the page with the cached HTML string rather than HTML element. So even if you cache the final state of the page as HTML string, all the events will still be lost. One workaround is to assign all events at the view-level, which is a very bad idea when you have a rather complex app since there will be conflicts everywhere.
Since I'm very new to Framework7, I couldn't determine whether this is a bug. All I know is how it behaves based on debugging through the code.
I really hope I don't have to write a wrapper to manage the state. I can't randomly use popup since it simply makes no sense from UX stand point.

You can just enable domCache view’s parameter and it will keep all the previous pages in DOM. In v2 same parameter called stackPages

@nolimits4web Thanks. That works very well for me.

@nolimits4web that partially does the trick, but seems to have a bug... my pages have nested navbars and while the first page is kept, the navbar is removed from the view. Any hint?

Issue is closed because of outdated, irrelevant or not actual
If this issue is still actual and reproducible for latest version of Framework7, please create new issue and fill the issue template correctly:

Clearly describe the issue including steps to reproduce when it is a bug.
Make sure you fill in the earliest version that you know has the issue.
Provide live link or JSFiddle/Codepen or website with issue


feat(Data/Matrix): Equalities relating mulVec and smul

These lemmas should make working with vectors easier in some cases. Check this related Zulip topic.

Hi, can you add a version for Matrix.scalar?

Hi, can you add a version for Matrix.scalar?

Sure, working on it

Hi, can you add a version for Matrix.scalar?

I don't think we want this, since scalar is not the simp-normal form.

Yes, good point.

bors d+
This looks great, thanks! I pushed some golfs and tweaked a name.
Please merge once this passes CI :)

bors r+


Stream is audio-only on linux?

I just downloaded the latest package. However, when I click on a stream, I only get audio. The stream box says that the stream is running, and I can hear the audio, but I have no idea how to access the stream itself. Audio runs, but there's no vlc box that pops up.
Running start.sh from cmd gives the warning
Syntax error: "(" unexpected (expecting "fi")

and trying to run the executable gives the warning
[12286:0525/152540:ERROR:browser_main_loop.cc(170)] Running without the SUID sandbox! See https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment for more information on developing with the sandbox on.

In both cases the app seems to work fine, though with the problem I mentioned

Hi...
The audio-only issue seems to be related to your video player... Which player do you use? Could you please check if this is happening as well when you try to launch a stream via the shell (using the same player)?
livestreamer twitch.tv/CHANNEL best -p /path/to/player

Syntax error: "(" unexpected (expecting "fi")

Start.sh is actually just a simple bash script which creates a link to a missing library on certain systems. This shouldn't be happening, unless there's something wrong with your bash or system, don't know.

the executable gives the warning

That's just a generic NW.js warning message and can be ignored. Can't do anything about that...

I did a little bit more digging, and it looks like you were right- my problem is something to do with vlc itself, not livestreamer-twitch-gui. It looks like vlc is failing to create a video output on my computer. I'll fix it and get back to you if interested.
Thanks for maintaining this app! I love its look and I look forward to using it once I get vlc working!


⚠ ClamAV has degraded performance

In 87efce3, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 205 ms

Resolved: ClamAV performance has improved in de8c449.


[WIP] Implement SimpleCustomData

API | Common
This implements my "simple" custom data as laid out in the API PR above.
Things to note with the implementation:

I've edited MixinCustomDataHolder so that the manipulator is always available to be written to. It's  a quirk of the data system that you can't write using the Key system if there is not datamanipulator present. This means the API can hide the implementation and just focus on the key-based system.
Any data that cannot be matched to a registered key gets preserved so that it will persist even with no serialisation mechanism present.

Tests
To come later

Please, nitpicking of licenses or code styles yet - not even implemented fully yet :P


API Design

This is a draft for the API design I currently have in mind, i'm currently thinking of 5 main objects;

DClientHandshaker, a state machine that performs in much the same way rustls::ClientCommon does, my current idea is as follows;

An application supplies it with datagram packets, then polls it, and in a black-box fashion, it'll only give one of three answers;

"Await until this deadline, then poll me again"
"I am ready to write to the socket"
"I have encountered an error"
(todo: how would handling an alert + error look like? "write this pls", poll(), "i got an error", in quick succession, writing the fatal but buffering the error until next call?)

This object handles retransmission timers internally
When complete, the poll() will return with "success, here's your connection object"

DClientConnection, a IO object for which the application can supply datagram packets, and supply it chunks of bytes it want to encode.

This will likely function exactly the same as rustls::ClientCommon, only that it supplies exact datagrams, and no streams of data.

"function exactly the same" wrt write_tls, read_tls, wants_write, etc. I don't believe wants_read is really needed, as all records are supposed to fit into one datagram, though i'll have to consult the RFC for that again.

The output will be datagram-based, so again, possibly no Read + Write traits

DServerListener, an object that handles all incoming "leftover" packets that do not belong to a connection, handles ClientHellos with HelloVerifyRequests, verifies ClientHellos with cookies, and if successful, then produces a handshaker object for the application to continue verifying with.

This object needs some sort of "cookie generator", which needs to be cryptographically secure and hard to guess, else DoS amplification attacks can be performed with this listener.

DServerHandshaker, pretty much the same as DClientHandshaker, only on the different side of the transaction.

DServerConnection, ditto.

These objects basically give an entirely hands-off buffer-based black-box approach to DTLS connection handling, with the application being who needs to handle underlying UdpSocket multiplexing, routing, buffering, and more.
This is to ensure this encryption layer can work over any kind of channel that is unreliable, unordered, but framed, this last guarantee is the most important one, and i'm not sure how to encode that into the IO. Rust doesn't give standard traits or libraries that "understand" a connections "framed-ness". Though luckily objects like UdpSocket don't provide Write + Read at all, and instead require manual polling of the recv and send functions, so i think it's plenty okay to leave that functionality to a wrapping connection manager (such as tokio-rustls is to rustls)

Also, i'd like a better name for the connection objects, "connection" is probably the wrong word, maybe "session"?

Draft 43 of DTLS v1.3 seems to define some terminology, I think it's best to have the names follow from these terms.


Add client assertion as optimal parameter on Authorization Code Flow

Describe the feature request?
I'm not sure if client assertion should be supported by okta-mobile SDK,client assertion used to be prevent replay attacks. but when I was looking at the documents for request  token, I noticed that there are two parameters: client_assertion_type and client_assertion. Do these two parameters need to be added to native SDK? Alternatively, is rfc7521 still the best current practice?
https://www.rfc-editor.org/rfc/rfc7521.html#section-4.2
POST /token HTTP/1.1
Host: server.example.com
Content-Type: application/x-www-form-urlencoded
grant_type=authorization_code&
code=n0esc3NRze7LTCu7iYzS6a5acc3f0ogp4&
client_assertion_type=urn%3Aietf%3Aparams%3Aoauth
%3Aclient-assertion-type%3Asaml2-bearer&
client_assertion=PHNhbW...[omitted for brevity]...Z
New or Affected Resource(s)
https://www.rfc-editor.org/rfc/rfc7521.html#section-4.2
https://www.rfc-editor.org/rfc/rfc8252#section-8.5
Provide a documentation link
No response
Additional Information?
No response

Hi @JayNewstrom ,thanks for reply, it's for purely enhanced security, I checked https://datatracker.ietf.org/doc/draft-ietf-oauth-security-topics/, and they explained that Authorization servers SHOULD use client authentication if possible. Because server-side recommends using client assertion, but what native SDK? I'm not fully understand how client assertion works. Documents also explain that PKCE is not a replacement for client authentication and that it does not allow treating a public client as a confidential client. https://oauth.net/2/pkce/  . Client assertion is mentioned in a lot of documents, but seems it never be used in native application sdk. I am just wondering why?

Hi @knsjk1204 after talking with the security team. They are in agreement that the Android SDK consumers (Android apps) should never be a confidential client.
I'm going to close this for now, as we don't have plans to implement this.
If you have a use case for this, please feel free to reach out to support or your customer success manger.

@JayNewstrom ,thanks for explanation, because client assertion is only used in confidential client, but since native application ( android & ios app) should never be a confidential client for security reason ,so that's why okta team don't have plans to implement this. did I understand correctly?sorry for asking again, Is any documents related about client_assertion only should be using on confidential client?

client assertion can be used in public clients as well. That being said, the biggest reason to choose client assertion is to use a confidential client without exposing the secret (using public key cryptography).
We don't see a use case for Android apps with this feature.


 Yeah I could do that.

You mean a pure black skin for OLED etc. devices? Yeah I could do that.

Don't let the hardware render black.  What I mean is that the color that has not been generated looks like black. For example, when the computer or mobile phone is turned on, the area outside the Logo is black, and only the Logo is generated by the hardware.


"CUDA is not available" on 1.3.2 Docker image

System Info
Using Docker image ghcr.io/huggingface/text-generation-inference:1.3.2
Using RTX 3090
Information

[X] Docker
[ ] The CLI directly

Tasks

[X] An officially supported command
[ ] My own modifications

Reproduction
version: "3.5"

  tgi:
    container_name: tgi
    image: ghcr.io/huggingface/text-generation-inference:1.3.2
    command: [
        "--quantize",
        "awq",
        "--model-id",
        "/data/TheBloke_Yi-34B-Chat-AWQ",
    ]
    volumes:
      - /llm/:/data/
    deploy:
      resources:
        reservations:
          devices:
            - driver: nvidia
              capabilities: [gpu]
              device_ids: ["0"]
    shm_size: "4g"

2023-12-13T03:16:21.518741Z  INFO text_generation_launcher: Args { model_id: "/data/TheBloke_Yi-34B-Chat-AWQ", revision: None, validation_workers: 2, sharded: None, num_shard: None, quantize: Some(Awq), speculate: None, dtype: None, trust_remote_code: false, max_concurrent_requests: 128, max_best_of: 2, max_stop_sequences: 4, max_top_n_tokens: 5, max_input_length: 2500, max_total_tokens: 3400, waiting_served_ratio: 1.2, max_batch_prefill_tokens: 2500, max_batch_total_tokens: None, max_waiting_tokens: 20, hostname: "323ed61165af", port: 80, shard_uds_path: "/tmp/text-generation-server", master_addr: "localhost", master_port: 29500, huggingface_hub_cache: Some("/data"), weights_cache_override: None, disable_custom_kernels: false, cuda_memory_fraction: 1.0, rope_scaling: None, rope_factor: None, json_output: false, otlp_endpoint: None, cors_allow_origin: [], watermark_gamma: None, watermark_delta: None, ngrok: false, ngrok_authtoken: None, ngrok_edge: None, env: false }
2023-12-13T03:16:21.518904Z  INFO download: text_generation_launcher: Starting download process.
2023-12-13T03:16:24.595808Z  INFO text_generation_launcher: Files are already present on the host. Skipping download.

2023-12-13T03:16:25.326439Z  INFO download: text_generation_launcher: Successfully downloaded weights.
2023-12-13T03:16:25.327071Z  INFO shard-manager: text_generation_launcher: Starting shard rank=0
2023-12-13T03:16:28.381947Z  WARN text_generation_launcher: We're not using custom kernels.

2023-12-13T03:16:28.424953Z  WARN text_generation_launcher: Could not import Flash Attention enabled models: CUDA is not available

2023-12-13T03:16:28.426838Z  WARN text_generation_launcher: Could not import Mistral model: CUDA is not available

2023-12-13T03:16:28.427444Z  WARN text_generation_launcher: Could not import Mixtral model: CUDA is not available

2023-12-13T03:16:28.491469Z ERROR text_generation_launcher: Error when initializing model
Traceback (most recent call last):
  File "/opt/conda/bin/text-generation-server", line 8, in <module>
    sys.exit(app())
  File "/opt/conda/lib/python3.10/site-packages/typer/main.py", line 311, in __call__
    return get_command(self)(*args, **kwargs)
  File "/opt/conda/lib/python3.10/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/opt/conda/lib/python3.10/site-packages/typer/core.py", line 778, in main
    return _main(
  File "/opt/conda/lib/python3.10/site-packages/typer/core.py", line 216, in _main
    rv = self.invoke(ctx)
  File "/opt/conda/lib/python3.10/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/opt/conda/lib/python3.10/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/opt/conda/lib/python3.10/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/opt/conda/lib/python3.10/site-packages/typer/main.py", line 683, in wrapper
    return callback(**use_params)  # type: ignore
  File "/opt/conda/lib/python3.10/site-packages/text_generation_server/cli.py", line 89, in serve
    server.serve(
  File "/opt/conda/lib/python3.10/site-packages/text_generation_server/server.py", line 215, in serve
    asyncio.run(
  File "/opt/conda/lib/python3.10/asyncio/runners.py", line 44, in run
    return loop.run_until_complete(main)
  File "/opt/conda/lib/python3.10/asyncio/base_events.py", line 636, in run_until_complete
    self.run_forever()
  File "/opt/conda/lib/python3.10/asyncio/base_events.py", line 603, in run_forever
    self._run_once()
  File "/opt/conda/lib/python3.10/asyncio/base_events.py", line 1909, in _run_once
    handle._run()
  File "/opt/conda/lib/python3.10/asyncio/events.py", line 80, in _run
    self._context.run(self._callback, *self._args)
> File "/opt/conda/lib/python3.10/site-packages/text_generation_server/server.py", line 161, in serve_inner
    model = get_model(
  File "/opt/conda/lib/python3.10/site-packages/text_generation_server/models/__init__.py", line 258, in get_model
    return CausalLM(
  File "/opt/conda/lib/python3.10/site-packages/text_generation_server/models/causal_lm.py", line 491, in __init__
    raise ValueError("quantization is not available on CPU")
ValueError: quantization is not available on CPU

2023-12-13T03:16:29.232603Z ERROR shard-manager: text_generation_launcher: Shard complete standard error output:

/opt/conda/lib/python3.10/site-packages/torch/cuda/__init__.py:138: UserWarning: CUDA initialization: Unexpected error from cudaGetDeviceCount(). Did you run some cuda functions before calling NumCudaDevices() that might have already set an error? Error 804: forward compatibility was attempted on non supported HW (Triggered internally at /opt/conda/conda-bld/pytorch_1699449201336/work/c10/cuda/CUDAFunctions.cpp:108.)
  return torch._C._cuda_getDeviceCount() > 0
/opt/conda/lib/python3.10/site-packages/bitsandbytes/cextension.py:34: UserWarning: The installed version of bitsandbytes was compiled without GPU support. 8-bit optimizers, 8-bit multiplication, and GPU quantization are unavailable.
  warn("The installed version of bitsandbytes was compiled without GPU support. "
Traceback (most recent call last):

  File "/opt/conda/bin/text-generation-server", line 8, in <module>
    sys.exit(app())

  File "/opt/conda/lib/python3.10/site-packages/text_generation_server/cli.py", line 89, in serve
    server.serve(

  File "/opt/conda/lib/python3.10/site-packages/text_generation_server/server.py", line 215, in serve
    asyncio.run(

  File "/opt/conda/lib/python3.10/asyncio/runners.py", line 44, in run
    return loop.run_until_complete(main)

  File "/opt/conda/lib/python3.10/asyncio/base_events.py", line 649, in run_until_complete
    return future.result()

  File "/opt/conda/lib/python3.10/site-packages/text_generation_server/server.py", line 161, in serve_inner
    model = get_model(

  File "/opt/conda/lib/python3.10/site-packages/text_generation_server/models/__init__.py", line 258, in get_model
    return CausalLM(

  File "/opt/conda/lib/python3.10/site-packages/text_generation_server/models/causal_lm.py", line 491, in __init__
    raise ValueError("quantization is not available on CPU")

ValueError: quantization is not available on CPU
 rank=0
2023-12-13T03:16:29.330149Z ERROR text_generation_launcher: Shard 0 failed to start
2023-12-13T03:16:29.330181Z  INFO text_generation_launcher: Shutting down shards

Expected behavior
It should start up without crashing, like it did on 1.1.1

Can you send us the output of --env?

Works now after updating CUDA version to 12.2.


Issue 132: Public Cython dump() function should take file object, not bytearray

Addresses #132

Thanks again. I was wondering though if it makes sense to keep write_data exposed in fastavro/writer.py. It seems like dump should be the interface. It could be potentially breaking to remove write_data from writer.py if someone has done from fastavro.writer import write_data but I think we'll eventually need a breaking change to rename some modules/functions/classes, so it might make sense at that time.
Thoughts?

I agree about write_data. It seems odd to expose the same functionality under two different names, and write_data definitely feels more like an internal name.


force config file to be created in utf-8 and without bom

Maybe fixes #204

Can confirm this has fixed the issue.


Performance issues if MapComponent state is updated

I am not sure if this is an issue of react-leaflet-markercluster, react-leaflet, leaflet, or my code. Sorry, if it doesn't belong here.
I have a map with several thousand markers and I am using react-leaflet-markercluster for marker clustering. If I need to update a global state of MapComponent, there is 1-3 seconds delay when this change is reflected.
I created a codesandox with 5000 markers and you can see there 2 use cases with performance issues:
1.) MapComponent is inside react-reflex element, that allows resizing panel and propagates new dimensions (width, height) to MapComponent. If width and height are changed, mapRef.invalidateSize() is called to update map dimensions. Resizing is extremely slow.
2.) If user clicks on Marker, global state selected is updated. It is a list of clicked marker ids. Map calls fitBounds method to focus on clicked marker and also marker icon is changed. There is around 1 second delay.
In my project, if I need to change a MapComponent state, it takes 2-3 seconds in dev mode when changes are reflected and it is just a single rerender of MapComponent and its elements (markers).
I took a look at Chrome performance profile and it seems most time is spent in internal React methods.
It is possible to fix this by preventing rerendering using memo, which is similar to shouldComponentUpdate, but it makes whole code base too complicated. preferCanvas option doesn't change anything. I am wondering what is a good way to fix these issues.

Please update README to memoize cluster elements:
const markerComponents = React.useMemo(() => {
return markers.map((marker) => {
return (
<MarkerContainer .../>
);
});
}, [markers, onMarkerClick]);
return (
<>
{markerComponents}
</>
);

Plus 100 points sir. I've been struggling for ages with my map. 15000 data points. Custom cluster icons and marker icons. Whenever I dragged the thing around, it was taking up to a full minute to become responsive again. I was trying all sorts to get something useable, and this was the missing piece for me. Everything is buttery smooth again. Thank you!

@Ali762 yeah if you haven't developed an interactive visualization with thousands of elements in a React project last 2 years, it's hard to figure it out. For this reason I think this should be in Readme, at least as a side note.

@Ali762 yeah if you haven't developed an interactive visualization with thousands of elements in a React project last 2 years, it's hard to figure it out. For this reason I think this should be in Readme, at least as a side note.

For this reason I think this should be in Readme, at least as a side note.

That is an open-source project.
Contributions are appreciated.
Originally that was a publicly published pet project.
Unfortunately, I'm overloaded with other projects.

@yuzhva Yes, of course. Everybody is busy now. I opened PR here.
The thing is that this is my first experience with this library so I thought there could be a reason why optimization with useMemo is not mentioned. I opened this issue first, because I wanted to know creator's opinion on that.


Update 01-installation.md

Livewire v3 requires Laravel 10 in their documentation, it seems wise to reflect that in the Filament docs as well.

[x] Changes have been thoroughly tested to not break existing functionality.
[x] New functionality has been documented or existing documentation has been updated to reflect changes.
[x] Visual changes are explained in the PR description using a screenshot/recording of before and after.

Livewire actually requires Laravel 9, so seems like an error in their documentation.


[ci:component:github.com/gardener/etcd-druid:v0.13.3->v0.14.2]

Release Notes:
Enables etcd-druid to trigger restarts of the etcd pods when peer URL is TLS enabled.

Updated condition used to decide when the `gardener.cloud/scaled-to-multi-node` annotation is added

Etcd druid will now use `policy/v1` for `PodDisruptionBudget`s for kubernetes >= 1.21. However, for kubernetes < 1.21, `PodDisruptionBudget`s will still default to `policy/v1beta1`

Claim logic for `PodDisruptionBudget`s have been removed. Already existing `PodDisruptionBudget` objects cannot be adopted anymore

Logic for deleting any leftover `CronJob`s created by `etcd-druid:v0.6.0` has been removed. Please deploy a lower version of `etcd-druid` before upgrading if you still have any leftover `CronJob`s or manually delete them

Golang version used upgraded to `1.18.6`

etcd-custom-image upgraded to `v3.4.13-bootstrap-8`

`Etcd-custom-image` will now retry fetching etcd configuration in case of any error

To avoid potential race-condition between go-routines updated `probeEtcd func()` to use shorter timeout.

Always update member peer URL, changed the way scale-up of etcd cluster is identified.

Updated golang version used to build images to 1.18.6

Updated golang version to 1.18

The decision to add the scale-up annotation to the etcd sts now considers the etcd status if an existing sts is not present

Added new field to the etcd CRD `etcd.Spec.Etcd.clientService`
Users can now add annotations to the client service by specifying them in the above field of the etcd resource

Decreases the likelihood of potential race condition between the go-routines while closing the snapshotter.

[bug-fix] backup-restore does not return error when it fails to update PeerURL of member.

A bug has been fixed that caused the wrong `minAvailable` configuration being calculated for multi-node etcd `PodDisruptionBudget`.

The `BackupReady` condition is not considered anymore when the `PodDisruptionBudget` configuration is calculated. This earlier blocked rolling out fixes that potentially solved problems with backup procedures.

Applying the annotation `druid.gardener.cloud/ignore-reconciliation` on the ETCD CR will stop etcd-druid from reconciling it.
This is helpful for operators to apply any manual fixes to the ETCD components, such as manually fixing permanent quorum loss as per the [playbook](https://github.com/gardener/etcd-druid/blob/master/docs/operation/Recover_From_Etcd_Permanent_Quorum_Loss.md).

Enhance `BackupReady` condition to take into account statefulset being scaled down and the backup section not being defined

/kind enhancement


Reduce warnings for services that don't have Connectors support

When auto-reconfiguration or service scanning is enabled, Connectors will log warnings for services that are bound to an app but don't have Connectors support.
WARN org.springframework.cloud.AbstractCloudConnector - No suitable service info creator found for service myServiceInstance Did you forget to add a ServiceInfoCreator?

These warnings are harmless, but cause unnecessary concern when apps have other issues.

Fixed via<PHONE_NUMBER>ef4845b09ab68cc07934b9d73ad142

@scottfrederick thats a great change. I have seen many people chase the wrong issue when they see those warnings.

:thumbsup:


Update README URLs based on HTTP redirects

Created with https://github.com/dkhamsing/frankenstein
GitHub Corrected URLs

Was
Now

https://github.com/bakkenbaeck/iOS-playbook
https://github.com/bakkenbaeck/iOS-handbook

WOW! 👏 👏 👏 👏 👏 👏  Nice work @dkhamsing !


partition wording mismatch

The docs say:
>Partition tolerance: the ability of a data processing system to continue processing data even if a partition failure occurs.
I think we should be able to make a distinction in partitions as specified in the CAP theorem, and partitions as used by Event Hubs, because they are not the same, which I think end up making this article a bit confusing, since theoretically you can have event hub partitions on the same server right?, no need for network traffic

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 44c8a071-97c3-3680-937d-ce96dca97426
Version Independent ID: fb85004b-e746-fe6a-e3fc-f8a2a2f08c18
Content: Availability and consistency - Azure Event Hubs
Content Source: articles/event-hubs/event-hubs-availability-and-consistency.md
Service: event-hubs
GitHub Login: @ShubhaVijayasarathy
Microsoft Alias: shvija

@videlalvaro Thanks for the feedback and bringing this to our notice . At this time we are reviewing the feedback and will update the document as appropriate .

@videlalvaro  : We are assigning this to the content author for review .@ShubhaVijayasarathy

@videlalvaro - Apologize for the delay in getting back to you. I have started reviewing old GitHub issues for Service Bus and taking care of them as early as I can.
As per the first paragraph, all partitions could be on the same server. We could mention that difference between Event Hubs and the CAP Theorem in a note. Thanks.

@videlalvaro - Apologize for the delay in getting back to you. I have started reviewing old GitHub issues for Service Bus and taking care of them as early as I can.
As per the first paragraph, all partitions could be on the same server. We could mention that difference between Event Hubs and the CAP Theorem in a note. Thanks.

#in-progress

#in-progress

Added the clarification. #please-close

Added the clarification. #please-close


Added embedded example HL7 file. Placed example HL7 text into text bo…

Added embedded example HL7 file. Placed example HL7 text into text box to prevent word adding linebreaks and carriage returns where they should not be.
Signed-off-by: James.Gilmore-A<EMAIL_ADDRESS>This PR ...
If you are suggesting a fix for a currently exploitable issue, please disclose the issue to the prime-reportstream team directly outside of GitHub instead of filing a PR, so we may immediately patch the affected systems before a disclosure. See SECURITY.md/Reporting a Vulnerability for more information.
Test Steps:

Copy/paste HL7 text from programmers guide into new .hl7 file
Test file with ReportStream Validation service and ensure it passes
Repeat step 2 with embedded HL7 file.

Changes
-Update to ReportStream programmer's guide to f
ReportStream-Programmers-Guide-v2.3.docx
ix Hl7 example text so that it can pass the ReportStream validation service.
-Add embedded Hl7 example file to programmer's guide.
Checklist
Testing

[ x] Tested locally?
[x ] Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
[ ] (For Changes to /frontend-react/...) Ran npm run lint:write?
[ ] Added tests?

Process

[ ] Are there licensing issues with any new dependencies introduced?
[ ] Includes a summary of what a code reviewer should test/verify?
[ ] Updated the release notes?
[ ] Database changes are submitted as a separate PR?
[ ] DevOps team has been notified if PR requires ops support?

Linked Issues

Fixes

To Be Done
Create GitHub issues to track the work remaining, if any

#issue

Specific Security-related subjects a reviewer should pay specific attention to

Does this PR introduce new endpoints?

new endpoint A
new endpoint B

Does this PR include changes in authentication and/or authorization of existing endpoints?
Does this change introduce new dependencies that need vetting?
Does this change require changes to our infrastructure?
Does logging contain sensitive data?
Does this PR include or remove any sensitive information itself?

If you answered 'yes' to any of the questions above, conduct a detailed Review that addresses at least:

What are the potential security threats and mitigations? Please list the STRIDE threats and how they are mitigated

Spoofing (faking authenticity)

Threat T, which could be achieved by A, is mitigated by M

Tampering (influence or sabotage the integrity of information, data, or system)
Repudiation (the ability to dispute the origin or originator of an action)
Information disclosure (data made available to entities who should not have it)
Denial of service (make a resource unavailable)
Elevation of Privilege (reduce restrictions that apply or gain privileges one should not have)

Have you ensured logging does not contain sensitive data?
Have you received any additional approvals needed for this change?

@GilmoreA6 , I copied to Visual Code Studio.  I only get one line.  In other word, there is no newline break.  I can't do HL7: Tokenize Document.  Can you fix that?

Maybe instead of applying the fix that @oslynn suggested, just put a note in the doc about HL7 being '\r' delimited, and that if they run into any issues tokenizing, to make sure each line ends with '\r' as expected.
I think it would be really hard to get Word to respect the line endings as we would want.

@GilmoreA6 , I copied to Visual Code Studio. I only get one line. In other word, there is no newline break. I can't do HL7: Tokenize Document. Can you fix that?

I think I got Word to respect the carriage returns so you can tokenize it in VScode, For some reason I had to manually add the carriage returns in the Word document even though Word was already showing them as there.


Fix syntax highlighting by changing how we include COMPATIBILITY_OVERRIDE_INCLUDE_PATH

The way that we include COMPATIBILITY_OVERRIDE_INCLUDE_PATH freaks out the syntax highlighting of editors like emacs. It causes the whole file to be highlighted like it is part of the include string.
To work around this, this patch creates a separate file called CompatibilityOverrideIncludePath.h that just includes COMPATIBILITY_OVERRIDE_INCLUDE_PATH. So its syntax highlighting is borked, but at least in the actual files that contain real code, the syntax highlighting is restored.

@swift-ci smoke test


refactor: rename v4 config Name to InstanceName

Renaming Name var to express functionality, so it can be distinguished from IntegrationName.
Doc reference: https://docs.newrelic.com/docs/create-integrations/infrastructure-integrations-sdk/specifications/host-integrations-newer-configuration-format

Pull Request Test Coverage Report for Build 315502211

2 of 3 (66.67%)  changed or added relevant lines in 2 files are covered.
6 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.01%) to 57.533%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/integrations/v4/config/config.go
0
1
0.0%

Files with Coverage Reduction
New Missed Lines
%

pkg/integrations/legacy/runner.go
6
77.6%

Totals

Change from base Build 315477268:
-0.01%

Covered Lines:
10727

Relevant Lines:
18645

💛  - Coveralls


Mio reintegration

Here's the second stab at mio integration.

Talks to event loop via TLS when possible.
Uses synchronization with the event loop (via futures) to acquire tokens, therefore allowing us to use a simple slab instead of a hashmap.
Generic ReadinessStream abstraction: a stream of () values to signify readiness, which in general can include spurious notifications.
A TcpListener, which wraps up a readiness stream with the ability to accept incoming connections.
tcp_connect, which acquires a TcpStream

I've also updated the main.rs to use these features. Right now, that means building directly on top of readiness streams (and hence using read directly). The plan from here is to build a simple tokio-like implementation of the /plaintext test, which should point the way toward using additional stream combinators etc. internally to structure things. Note, however, that you always have the option of continuing to work in "manual mode", basically pulling together readiness streams and IO actions into your own custom scheduler/dispatch within the futures framework. That means we have a great deal of flexibility in finding the right factoring.
Finally, adds a few stream combinators along the way.

Ok I haven't taken a peek at event_loop and the TCP stuff too closely yet, but I'm pretty confident that it's better than what's there now!
I want to start working towards removing PollError which'll just cause a bunch of conflicts with this, so I'm gonna merge. I'm sure I'll have more comments about this, though.


refactor tests to remove 2.0 errors

refactor to use @testable, remove publics
refactor and cleanup match
more router cleanup
cleanup request and route classes

@ollieatkinson please review if you get a chance

fixes #13 and fixes #16


Cannot read property 'instance' of undefined at i.trace exception

The following exception gets thrown from a limited set of IPs which are trying to reach pinterest.com:
TypeError: Cannot read property 'instance' of undefined
	at i.__trace__ (https://s.pinimg.com/webapp/js/bugsnag-693c66a9f6ec8285e05d.mjs:1:29967)

Related minified code:
if(n&&e.apply(this,r),"function"!=typeof i)return e.apply(this,r);if(i.__trace__)o.replace(i.__trace__);else{var a=f();i.__trace__=function(){d(a),g((function(){d(null)}),0);var e=i.apply(this,arguments);return d(null),e},i.__trace__.__trace__=i.__trace__,o.replace(i.__trace__)}}catch(s){}if(e.apply)return e.apply(this,r)

We use @bugsnag/js v7.0.0 and initialize the library this way:
import Bugsnag from '@bugsnag/js';
Bugsnag.start({
      apiKey,
      releaseStage,
      appVersion
});

Hey @christianvuerings, I'm wondering if since it's only affecting a certain number of select IPs, that this is related to a location or a VPN blocking an element of your Javascript from loading, and then when addressed throwing this undefined error.
The code at https://s.pinimg.com/webapp/js/bugsnag-693c66a9f6ec8285e05d.mjs looks to be a minified version of the bugsnag-js v7.0.0 code with some additional initialization code, but the sourceMappingURL is not found so I was unable to unminify this entirely to see what's different exactly.
Are you able to reproduce this error locally at all? If you could write in to<EMAIL_ADDRESS>letting us know the link to these errors that would be very helpful to find out any more information.


Mat/Par: Parental leave and allowance date messaging

User Story
“As a applicant I want clear guidance on when my allowance can end given when my leave occurs and when I choose to start my allowance so I can know the limit.”
When I selected a longer leave time than allowance time, in this case 35 weeks 4 days

I am confused about the message in the allowance section. The alert box says dates must be in between May 27 2024 and Jan 30 2025
but when I pick those dates I get and error that doesn't really make sense to me
> One parent cannot claim standard allowance for more than 35 weeks

Tasks
explore appropriate solutions
Acceptance Criteria
The leave and allowance time rules makes sense and work intuitively for users

@Stella-Archer is this the same as ticket #1577?

changing allowance day to have start date and Number of weeks #1627 may resolve this


When looking for react-native dir, include rootProject.projectDir

The code used to assume that node_modules is not in rootProject.projectDir
Maybe it's better to include that directory in the search.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@nokite I'm really sorry this has sat so long! I had it in my queue but things kept piling on top of it.
I can't see anything wrong with this approach - the plugin is very loud about what exact directory it is using (in case there is something unexpected as a result of merging this) and it's very specific about the shape of the directory it searches for, so seems risk of unexpected behavior change is pretty low

@nokite I'm really sorry this has sat so long! I had it in my queue but things kept piling on top of it.
I can't see anything wrong with this approach - the plugin is very loud about what exact directory it is using (in case there is something unexpected as a result of merging this) and it's very specific about the shape of the directory it searches for, so seems risk of unexpected behavior change is pretty low

@nokite 1.5 was just released! THanks again for the contribution, please give it a go and hopefully that resolves your issue

@nokite 1.5 was just released! THanks again for the contribution, please give it a go and hopefully that resolves your issue


c# Speech to text samples

Hi,
I see that all of c# speech to text samples are removed from here and from
https://cloud.google.com/speech-to-text/docs/endless-streaming-tutorial
will there be new samples or this is end for C# support :)
Thanks

FYI @telpirion for you to answer or forward to someone who can. Thanks.

Hello @koderi-dp,
C# is still a supported language with a client library--see the Google.Cloud.Speech package on Nuget. Samples have been removed due to maintenance concerns.

Don't undrestand why are you closing this ticket, so we have package available but without any example how to use it, are you planing to have examples for c# or answer is "mainteance concerns"?

The reference documentation is still available for the package, which should help you with usage. The product documentation is also available.

This is product documentation

dont see c# there, for package documentation is 2 code blocks and hot to install package

If your concern is with the product documentation, you should log an an issue there.

@telpirion thanks, you were very helpful.

@telpirion thanks, you were very helpful.

Hi,
I see that all of c# speech to text samples are removed from here and from
https://cloud.google.com/speech-to-text/docs/endless-streaming-tutorial
will there be new samples or this is end for C# support :)
Thanks

You can always browse an older commit and get the samples from there.


Add dns capabilities to allow for custom dns in Windows

Co-authored-by: James Sturtevant<EMAIL_ADDRESS>
What this PR does / why we need it:
Adds dns capability for custom DNS, which is only used on Windows.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): https://github.com/kubernetes/kubernetes/issues/74541
Special notes for your reviewer:
Release note:

Add DNS capability for custom DNS on Windows

The build error seems strange.
We ran ./build/build-all.sh windows amd64 and it built successfully, but the CI build is failing with
cni/network/network.go:349:16: undefined: getCustomDNS
cni/network/network.go:418:15: undefined: getCustomDNS

getCustomDNS is defined in network_windows.go

/lgtm

It looks like merging is blocked because of requested changes.

@ashvindeodhar Any new comments? This PR lgtm!


Adding template html snippets to typescript.json

Good afternoon John,
I found myself wanting to use the HTML snippets you created within a simple inline template I was creating within an @Component decorator, but since I was working within TypeScript and not an HTML file I found they were contextually unavailable.
I am not sure if what I did by copying the HTML snippets directly into the TypeScript snippets is the best approach, but it appears to work. I figured a PR might be a better means of discussing rather than just opening a new issue with the feature request. (For instance: Perhaps the HTML snippets within the TypeScript snippets should have 'template' in their prefix name like ng2-template-ngFor to provide clearer intent of purpose?)
Thank you!
Michael

interesting idea ... but i'd like to see what evolves with vs code first as they may make a hook to allow html in the editor, which may resolve this


Data persistence for controls (binds) and beatmap cache

Every time a player restarts the client, it reprocesses all the beatmaps and resets the controls configuration to the default one. This is not desirable and it would be better to save binds to a file (possibly requires a rework or an abstraction above the bind system), and it's possible to cache processed beatmaps like osu does. Caching will drastically improve startup times with massive amount of beatmaps.

Partially done, controls are now saved and restored from a file


Is the "-it" argument in the call to docker necessary in fmriprep-docker?

I've recently been running my preprocessing on an fairly hefty unused linux box I found in our server room.  I log in over ssh from my laptop to kick off the run, but I don't want to have to stay connected for days until its done.  The problem is, I can't detach.  If I try to detach, I get an "the input device is not a TTY" error from docker and it bails. Looking at the command fmriprep-docker generates, I tried changing the "-it" to "-i", and it seems to be perfectly happy running detached with no STDIN.  Since as far as I can see, I'm never going to be asked to send any input to docker during a run, what's the rationale for requiring a connection to STDIN?  Could "-i" be made the default?

Possibly. Are you able to Ctrl-C to quit without the -t? If I remember correctly, that was the main thing we needed.
In the meantime, you could also use screen, tmux, or byobu to keep a TTY session open that you can detach from and reattach to.

Admittedly, this is slightly different usage, but I am able to run fmriprep across multiple participants in parallel using docker and just -i, rather than -it.

@araikes If you're running on a single computer and have the resources to run multiple participants simultaneously, you can use --partcipant-label <label1> <label2> ... to run multiple participants in the same workflow. Because there won't be dependencies, the jobs from one will not block another, and Nipype will handle resource management.
However, if you're doing it to over-commit resources (especially useful during recon-all, as large chunks of time may be spent with several cores committed while one is being used), then your approach may be better.

Are you able to Ctrl-C to quit without the -t? If I remember correctly, that was the main thing we needed.

I just got around to checking. You cannot Ctrl-C without -t, and adding yet another option to fmriprep-docker does not seem worth it. If you cannot use screen or similar, you can copy and modify the docker command that fmriprep-docker generates.


toc extension patch

A quick hack to support non-ascii headings :
=== diff -u toc.py.old toc.py >>> ===
   --- toc.py.old	2011-11-20 20:03:03.000000000 +1100
   +++ toc.py	2011-11-20 20:04:22.000000000 +1100
   @@ -76,7 +76,7 @@
                    # Do not override pre-existing ids
                    if not "id" in c.attrib:
                        id = self.config["slugify"][0](c.text)
   -                    if id in used_ids:
   +                    if ( id == '' ) or ( id in used_ids ):
                            ctr = 1
                            while "%s_%d" % (id, ctr) in used_ids:
                                ctr += 1

=== <<< ===
Basically the slugify() method makes an empty slug for non-ascii headings, so we name them as "_%d" % (heading_occurence) then .

As the code has changed drastically here, your patch will not apply to the current code. In fact, we are now running unicodedata.normalize() on headers in our slugify() function to support non-ascii headers. Therefore, your patch should be unnecessary.


ci: Create dependabot.yml  #9

Added dependabot GitHub action

Solved #9

We are using yarn in our project does this work with yarn as well? As this is the first time I am seeing this

yeah no problem

That's nice thanks for contributing @priyankarpal 🚀🚀


"View this page source" link not working

Thanks for opening an issue!

[x] Bug
[ ] Feature Request
[ ] Question

Problem Report
The link "View this page source" on this page doesn't work.

Fixed


Philio PST03A-v2.2.5 support

Clean PR for Philio PST03A-v2.2.5 device support

Codecov Report

Merging #785 (941b49e) into dev (6ad2a10) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #785      +/-   ##
==========================================
+ Coverage   83.08%   83.14%   +0.05%
==========================================
  Files         176      178       +2
  Lines        3956     3970      +14
==========================================
+ Hits         3287     3301      +14
  Misses        669      669

Impacted Files
Coverage Δ

zhaquirks/philio/__init__.py
100.00% <100.00%> (ø)

zhaquirks/philio/pst03a.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ad2a10...941b49e. Read the comment docs.

Pull Request Test Coverage Report for Build 580181803

14 of 14 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.06%) to 83.149%

Totals

Change from base Build 568630289:
0.06%

Covered Lines:
3301

Relevant Lines:
3970

💛  - Coveralls


Fix expression order of precedence

Purpose
$title according to the spec[1]. However, this will break #17936 again, but with a mismatched input. And that needs to be fixed with https://github.com/ballerina-platform/ballerina-lang/issues/10736
[1] https://github.com/ballerina-platform/ballerina-spec/blob/master/lang/spec.html#L2462
Fixes #17938
Remarks
Fixes: #17938
Breaks; issue: #17936, pr: https://github.com/ballerina-platform/ballerina-lang/pull/18451
#10736

Codecov Report

Merging #18490 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #18490   +/-   ##
=======================================
  Coverage   15.15%   15.15%
=======================================
  Files          48       48
  Lines        1254     1254
  Branches      197      197
=======================================
  Hits          190      190
  Misses       1050     1050
  Partials       14       14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24b2dc5...e9cfcfe. Read the comment docs.


Request construction steps should have consistent phrasing for defaults and per-request assignments

Maybe similar to:
requests by default have the header `([^`]*)` assigned `([^`]*)
the request has the header `([^`]*)` assigned `([^`]*)

Resolved in previous work.


updated the ui🥷🥷🥷

https://github.com/ashut0sh75/Cartoon/assets/100133057/c4b09002-130b-4202-8a63-d157eb97d446

Everything looks fine.


Issue 3638 - Fixed the change source directory and workspace if a similar tracking config is existing

I've fixed the change source directory and workspace if a similar tracking config is existing. The problem occurs after certain actions, for example:

List of repositories of the pipeline is changed;
The pipeline created a new workspace when the pipeline run;
Reverted list of repositories to the original (before the first point);
The pipeline will incorrectly use workspace is created earlier (source directory will created in the new workspace).

This bug was a long time ago, but it was found out after fixing the tracking manager (commit).
Related issue: #3638
Checked cases:

Case from the example above;
Case with 1 workspace;
Case with 3 workspaces (3 options of pipeline's config);
Case with more workspaces (5 and more);

/azp run

/azp run


Test for socks4

Add test case for socks4 support on wslocal

Socks4 is too old, even java8's default implement for socks4 was broken
Remove it at 421b9f81477b804137c5642fe43d8e832245e026


What about handling side-effects outside?

Many approaches in Redux for handling side-effects and async code, do it outside the loop, by listening for specific actions and dispatching others accordingly. Notable examples are Redux-saga or Redux-observable.
Without an actual action type constant, this doesn't seem possible to achieve in repatch.

I can say many things related to this issue.

Repatch also has thunk middleware. With this you can handle side-effects via extraArgument.

Repatch also has middleware interface, those compose up the dispatch method . So you can create a middleware, which handles objects as actions. This way you can resolve any redux-specific middleware.

In the 2) case Repatch would be very similar to Redux. But the purpose is not there. Actually middlewares in Repatch do not make sense. The dispatched reducers are not serialisable entities. So analysing them could not be the Jedi way. The most of middleware functionality should be listeners on the store, like redux-persist. But I would like to provide a convenient way to handle side-effects before reducing without middlewares. I am considering this to a new major version.

I close this issue, because it does not bind tasks in the repository yet.
The next major version will ship a more repatch-like approximation to handling third-party side-effects.


Fixed successful Contact Primary Affiliation Field using Record Type instead of Field API Name

Critical Changes
Changes
Issues Closed
New Metadata
Unpackaged Metadata
Deleted Metadata
Testing Notes

QA Passes - Merging

QA Passes - Merging


Add Typescript support

Is your feature request related to a problem? Please describe.
I've integrated @googlemaps/extended-component-library into a React application and noticed that Typescript is not yet supported.

I've also installed @types/google.maps, but it doesn't contain type annotations for these extended components.
Describe the solution you'd like
It would be great to include the types in this library or e.g., @types/google.maps.

If you would like to upvote the priority of this issue, please comment below or react on the original post above with :+1: so we can see what is popular when we triage.
@tobiasbueschel Thank you for opening this issue. 🙏
Please check out these other resources that might help you get to a resolution in the meantime:

Check the issue tracker - bugs and feature requests for Google Maps Platform APIs and SDKs
Open a support case - Get 1:1 support in Cloud Console.
Discord - chat with other developers
StackOverflow - use the google-maps tag

This is an automated message, feel free to ignore.

While the specific issue can be solved by adding "/lib/" in the path, like this: @googlemaps/extended-component-library/lib/react, it is still very frustrating that there are a lot of issues when creating a .tsx file, based on the samples.  Simply copying class App into a .tsx file has many issues.  Very frustrating that this library is not plug and play.

the lib in the path didn't fix things for us, so we are just removing the types for now, adding:
// eslint-disable-next-line @typescript-eslint/triple-slash-reference
/// <reference path="../../types.d.ts" />

and types.d.ts
declare module '@googlemaps/extended-component-library/react' {
  // Disable type checking for the named export `PlacePicker`
  export const PlacePicker: any;
}

which is a horrible work-around, but it let's us keep moving for now.

Adding it to the paths in the main tsconfig.json for your project would solve the issue too:
"paths": {
      "@googlemaps/extended-component-library/react": [
        "node_modules/@googlemaps/extended-component-library/lib/react"
      ]
    }


Update gevent==1.1.2

did you run all tests with tox using gevent 1.1.2?

@cgoldberg Are there tests that aren't run by CI?

@di oops.. my bad.  travis used to not support Python 3.5, and we had to run them locally... but your results show 3.5 in there.  so I am :+1:


Test on 2.3

Cause why not. We'll see if this Just Works (TM).

Haha, thanks! I also intend to add an allow_fail'd ruby-head at some point. Will merge on :green_apple:.
(Let me know if you actually want to do anything with this project; it's unfortunately far from non-me-user ready...)

The load paths aren't quite working for me. bin/carbonmu doesn't work, and neither does rake console. Amidoinrite?
nodachi:carbonmu nateberkopec$ bin/carbonmu start
/Users/nateberkopec/.rubies/ruby-2.3.0/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require': cannot load such file -- carbonmu (LoadError)
	from /Users/nateberkopec/.rubies/ruby-2.3.0/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
	from bin/carbonmu:3:in `<main>'

Can confirm the bin/carbonmu start doesn't work for me either - try bundle exec carbonmu start. The rake console does work, though; can you paste the output if it's different than your bin output?

Ohhh, bundle exec fixes it for both. Why does that work? Is that because the gemspec is executed?

Also RE: this PR, I have no idea why that doesn't work. In raven-ruby we can test Ruby 2.3 by specifying ruby-2.3.0 as the version is that OK?

Sure, that's fine! And I just pushed 209ec8c2e280fcb42a600ecb9ca634991377e9e6 which corrects the bin script and Rakefile when run w/o bundle exec.


Use app classloader to load proxy

Describe what this PR does / why we need it
we should ensure the proxy object and itself has same class loader
Does this pull request fix one issue?
Fixes #678

Describe how you did it
Describe how to verify it
Special notes for reviews

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

the pr will be closed , you can reopen it after resolve conflicting files and the cla( Contributor License Agreement) .
thks