UX - Command line arguments for new user

Hi,
thanks for this needed application! Here a few remarks (not real issues):
When giving my first trial, I found not having -h|--help among command line arguments a bit annoying (or -v|--version).
It would maybe be easier for adoption to give a way to generate a key and certificate? I did it with openssl req -x509 -newkey rsa:4096 -keyout ./key.pem -out ./cert.pem -sha256 -days 365 (found on SOF how-to-generate-a-self-signed-ssl-certificate-using-openssl) or provide any better way.
PowerShell> java -jar ./open-pdf-sign.jar -k ./key.pem -c ./cert.pem -i a.pdf -o b.pdf -p <passphrase> --page -1

French bundle is not present (was expecting to use fr_FR). How to add a Property file. I found en.propertiesand de-AT.properties in source, but how to add one and how to pass one to the CLI? Maybe as othe CLI arguments as there are juste 4 lines in the bundle?
Could the printed message generated when the bundle is not present or really wrong be more elaborate than the Java stack trace :-) ?
ava.util.MissingResourceException: Can't find bundle for base name strings, locale
        at java.base/java.util.ResourceBundle.throwMissingResourceException(ResourceBundle.java:2045)
        at java.base/java.util.ResourceBundle.getBundleImpl(ResourceBundle.java:1683)
        at java.base/java.util.ResourceBundle.getBundleImpl(ResourceBundle.java:1586)
        at java.base/java.util.ResourceBundle.getBundleImpl(ResourceBundle.java:1549)
        at java.base/java.util.ResourceBundle.getBundle(ResourceBundle.java:932)
        at org.openpdfsign.Configuration.<init>(Configuration.java:34)
        at org.openpdfsign.Configuration.getInstance(Configuration.java:50)
        at org.openpdfsign.CLIApplication.main(CLIApplication.java:40)

Could there be a hint about height of the signature table to help placing it in the right position, some kind of verbose mode?
The borders of the table (top and bottom) are not always visible. I don't know if it's something you can act upon...
Best Regards and thanks again.

Here is the PR to make the help option more available to the first time user:
https://github.com/open-pdf-sign/open-pdf-sign/pull/22

Thank you for the issue and PR! I'll look into the Bundle handling, it shouldn't lead to a stacktrace.
For the key generation, I think you're best served with openssl, if you need a self-issued key. You can also buy these files from a certificate authority.
Most of the text in the Resource Bundle is already customizable, but I'll look into that.
For the table border: Can you give an example on when they are not visible? We're using vandeseer/easytable for drawing. If I'm not mistaken the "inner" border lines are a bit stronger (as neighbouring cell lines are duplicated) but also the outer borders should be drawn.
On verbose: I you have an idea on how, I'd welcome it. We're already using slf4j-simple with different levels, but I didn't find a way to set the logging level during runtime unfortunately.

Thanks!
I thought I was confused between CLI arguments and bundles, because of hint and hint_text and timestamp which don't have the exact same meaning:
Bundle contents:
signee=Signee
timestamp=Timestamp
hint=Hint
hint_text=You can check the validity of this certificate at https://www.signaturpruefung.gv.at

Could we pass arguments superseding these keys with the meaning? When we use argument --hint, it's in fact a hint_text which is read if I am not wrong. Could the whole table be built from command line arguments (including translation of terms?)? Argument --locale should load the bundle which 'fr_FR' should load 'fr_FR.properties' file, what do you think?
(Sorry if my comment is redundant with yours, you were writing at the same time as I was !)

Playing with the zoom in Acrobat Reader, the signature table can have borders missing (or disappear!) like in picture below. Can't you reproduce it?

Using Coherent PDF or cpdf from time to time, there a few options for placing text onto a pdf:
  -top                                Set position relative to center top of page
  -topleft                            Set position relative to top left of page
  -topright                           Set position relative to top right of page
  -left                               Set position relative to center left of page
  -bottomleft                         Set position relative to bottom left of page
  -bottom                             Set position relative to center bottom of page
  -bottomright                        Set position relative to bottom right of page
  -right                              Set position relative to center right of page

It might be overwhelming but a source of inspiration for placing the signature on the right place! (least surprise principle... for lazy users, you know!)
Thanks!

If I'm not mistaken the "inner" border lines are a bit stronger (as neighbouring cell lines are duplicated)
you are not! after zooming, I can confirm it!

I packaged the code on my laptop. Thanks for -h | --help. Just one small remark while you are at it:
Usage: <main class> [options]
  Options:
    -b, --binary
      binary output of PDF
      Default: false
    -c, --certificate
      certificate (chain) to be used
    --config
      use a configuration file
    --help, -h
      prints this page
      Default: false
    --hint
      text to be displayed in signature field
    --host
      run as server with the given hostname
    --image
      Image to be placed in signature block
    -i, --input
      input pdf file

--help, -h is written long option first contrary to other options.
Best regards

On PowerShell I am getting this:
PS C:\Users\sul00\Desktop> java -jar ./open-pdf-sign.jar --input suleman.pdf --output output.pdf --certificate cert.cer --key key.key --page -1 --locale de-AT
Exception in thread "main" java.lang.ClassCastException: class org.bouncycastle.pkcs.PKCS10CertificationRequest cannot be cast to class org.bouncycastle.cert.X509CertificateHolder (org.bouncycastle.pkcs.PKCS10CertificationRequest and org.bouncycastle.cert.X509CertificateHolder are in unnamed module of loader 'app')
        at org.openpdfsign.KeyStoreLoader.loadKeyStoreFromKeys(KeyStoreLoader.java:50)
        at org.openpdfsign.CLIApplication.main(CLIApplication.java:53)

@Suleman-Elahi please open a separate issue for this bug report

@Suleman-Elahi please open a separate issue for this bug report

It is fixed. I wa susign this website to generate private keys: https://www.ssl.com/online-csr-and-key-generator/
But then I used OpenSSL command from the above comment, and it worked.

Playing with the zoom in Acrobat Reader, the signature table can have borders missing (or disappear!) like in picture below. Can't you reproduce it?

Unfortunately, no, I can't reproduce it. I would expect this to be some sort of aliasing-bug in the viewer though. Do the lines reappear if you zoom into the document? The lines are quite thin, maybe it's smaller than one device pixel on some monitors/resolutions.

--help, -h is written long option first contrary to other options

Will be fixed in PR 23, thank you for noticing!

Using Coherent PDF or cpdf from time to time, there a few options for placing text onto a pdf

Thank you for that! PDF positioning can be quite strange (e.g. with rotated/scaled documents). In the initial design decision we opted for a (top, left, width, height) bounding box with positioning the signature with all positioning being done from the top-left of the page. While it can look "off" in certain formats, this allows for a consistent size of the signature box on different page formats (as e.g. defining (top, left, bottom, right) would lead to too big/small boxes depending on paper size.

Thank you again for all the feedback! All points should be implemented now in the latest release (v0.1.3)

Parameter --version allows printing the binary version
Using --label-hint,  --label-signee and --label-timestamp also the row labels can be customized
If a locale is not included in the shipped bundles, open-pdf-sign now fails gracefully instead of throwing a stacktrace
README is adjusted with all new parameters


what inspire you the prototypenet?

I know the retinanet inspire the basic backbone, ssd inspire the loss, mask-rcnn inspire the branch,
but I wonder what inspire you the protonet?

As with most original research, I just came up with it after thinking about the problem for a while. Then we took that original idea and refined it after months of testing.


ogbg-test, wmt-test and libri ds fix

This PR contains the ogbg-test, wmt-test and a fix to the librispeech pytorch data loading function.
Note: I used len(ds) instead of self.num_train_examples because the num_train_examples attribute is set equal to 263840 whereas len(ds) was 263838!

I added in fixes to the BatchNorm and loss function in this PR itself. Once Runa's PR is merged, I will apply my fixes on top of that and that should also resolve the return value of the loss function?

I have merged my changes with that of Runa's and is now ready for your review! I had to bring back _loss_fn as Runa's trick of recovering the lengths from the average_loss and summed_loss would no longer work if average_loss is the global average across all devices and summed_loss is just the sum of losses on an individual process.


net-mgmt/zabbix-proxy: New plugin

Initial dev version
Most used parameters are configurable via UI
Works with zabbix3-proxy (=3.0 LTS)

Why Zabbix Proxy 3.0? I'd vote to align the version with the existing Zabbix Agent plugin, which uses version 3.4.

@fraenki 3.0 is LTS, proxy 3.4 does not work with 3.0, 3.2 apparently does. Quite messy...

@fraenki The problem is that server and proxy have to be the same version, but for agent you can use 3.4 and it's backward compatible to 3.0.
https://www.zabbix.com/documentation/3.4/manual/appendix/compatibility
There are some reports that proxy 3.2 works with 3.0 server when the package was updated (not newly installed), that's why 3.0

merged, thanks!

Hello, it seems that currently I cannot use a Zabbix 3.4.7 server, an opnSense Agent 3.4.7 and the default proxy in the same OpnSense Box(version 3.0.14)
failed to update local proxy configuration copy: invalid field name "items.jmx_endpoint"
How can I test an proxy upgrade to 3.4.7?
Thanks

If I remember correctly server and proxy have to be the same major version ..


feat(service-registry rule): add base and enable command

Added service registry rule base and enable command.
Verification Steps

The following command should successfully enable a registry rule:

./rhoas service-registry rule enable --rule-type compatibility --config forward

The following command should throw an error for invalid configuration error.

./rhoas service-registry rule enable --rule-type compatibility --config syntax-only

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation change
[ ] Other (please specify)

Checklist

[X] Documentation added for the feature
[X] CI and all relevant tests are passing
[ ] Code Review completed
[ ] Verified independently by reviewer

I think that suggestions are not aligned
[wtrocki@graphapi app-services-cli (rule_root)]$ rhoas service-registry rule enable --rule-type=validity --config none
❌ Invalid configuration value "none" for rule type "validity". Valid operations are: "full", "syntax-only". Run the command in verbose mode using the -v flag to see more information

Not sure if we can resolve this as suggestions combine both options etc.
Error handling works fine:
[wtrocki@graphapi app-services-cli (rule_root)]$ rhoas service-registry rule enable --rule-type=compatibility --config=full
Enabling rule for Service Registry instance
❌ You are forbidden to enable this rule. Run the command in verbose mode using the -v flag to see more information

Update from discussion. Let's work on interactive mode. Suggestions in bash can be invalid.


Add SavitaBhor's file

created a branch, created a file and made a commit, and opened a pull request


Implement C Declarations5 package

Description
please enter the description of your change here
Change request type

[ ] Release or process automation (GitHub workflows, internal scripts)
[ ] Internal documentation
[ ] External documentation
[x] Query files (.ql, .qll, .qls or unit tests)
[ ] External scripts (analysis report or other code shipped as part of a release)

Rules with added or modified queries

[ ] No rules added
[ ] Queries have been added for the following rules:

rule number here

[x] Queries have been modified for the following rules:

RULE-8-5

Release change checklist
A change note (development_handbook.md#change-notes) is required for any pull request which modifies:

The structure or layout of the release artifacts.
The evaluation performance (memory, execution time) of an existing query.
The results of an existing query in any circumstance.

If you are only adding new rule queries, a change note is not required.
Author: Is a change note required?

[ ] Yes
[x] No

Reviewer: Confirm that either a change note is not required or the change note is required and has been added.

[ ] Confirmed

Query development review checklist
For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:
Author

[ ] Have all the relevant rule package description files been checked in?
[ ] Have you verified that the metadata properties of each new query is set appropriately?
[ ] Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
[ ] Are the alert messages properly formatted and consistent with the style guide?
[ ] Have you run the queries on OpenPilot and verified that the performance and results are acceptable?As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
[ ] Does the query have an appropriate level of in-query comments/documentation?
[ ] Have you considered/identified possible edge cases?
[ ] Does the query not reinvent features in the standard library?
[ ] Can the query be simplified further (not golfed!)

Reviewer

[ ] Have all the relevant rule package description files been checked in?
[ ] Have you verified that the metadata properties of each new query is set appropriately?
[ ] Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
[ ] Are the alert messages properly formatted and consistent with the style guide?
[ ] Have you run the queries on OpenPilot and verified that the performance and results are acceptable?As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
[ ] Does the query have an appropriate level of in-query comments/documentation?
[ ] Have you considered/identified possible edge cases?
[ ] Does the query not reinvent features in the standard library?
[ ] Can the query be simplified further (not golfed!)

Notes RULE-8-5
this is almost M3-2-3 but the C rule specifically says (with regards to header files) "each Declaration shall only be declared in one header file" and M3-2-3 only considered when multiple declaration entries were present in nonheader files


Version control modification counter causes overlapping text on the bottom toolbar

Here is what my bottom toolbar looks like when a file with no modifications is open:

But when I open a file with modified lines and the version control modification widget is displayed, it looks like this:

I did the same test with the linter package disabled, it is not caused by that plugin.
This is on Atom 1.0 running on OS X.

Would you mind reopening this on https://github.com/atom/status-bar? Thanks!

Here is is: https://github.com/atom/status-bar/issues/92


Applying RxJS v6

Thanks for nice project. I tried to fix it to apply RxJS v6 in spawn-rx.
I also change tslint configs for fix chai expression's no-unused-expression rules.
Feel free to review this commits. Thanks :)

@paulcbetts  can you merge this ? it looks good to me.

@govi2010 I deployed it to npm as spawn-rx-dev. But, be careful to use. This package will only available while this pull request's merge is pending.

Thanks for the PR! It would be great if we could get this into spawn-rx. @paulcbetts Could you take a look at this PR if you have time?


Its laggy and rerendering playlist while scrolling. not smooth

https://user-images.githubusercontent.com/75513645/170172074-68a59873-2e4c-4d5e-9ec9-bf63b74ccdff.mp4

This was an issue present in the first version, which had to do with the size of the playlist list container size and the way spotify handles the playlist list element (they remove items from the dom when scrolling out of view).
I'm not sure why it's happening for you, cause it works smoothly for me and I'm not able to reproduce it. But I'm still on spotify 1.1.84 with spicetify 2.9.8.
What os/spotify/spicetify version are you using?

While checking out #3, I noticed that behaviour only with the big icons.  Unfortunately, due to the way the sizing of the playlist container is handled, I'm unable to do anything about it.


JetPack Suggestions

Running 1.11.2 previous build from current (does not appear latest version has a fix so haven't updated).
When hovering on jetpack and you come to a landing, you almost always have to hit shift at least once more to fully "land" and stop the jetpack from hovering.  This frequently creates a problem in that often when you are mining without fully being "landed" the blocks you break become ghost blocks.
This is a very reproducible issue, the solution is to keep pressing shift until the hover mode turns off.  It seems like this could be tweaked pretty easily so you better register when player has landed and turn off hover mode.
I know you have addressed this in early submissions but I would love to see the forward/lateral speed of the jetpack increased.  Maybe via speed upgrades like the machines.  I find that I mainly make the Mek jetpack for mid-game and switch to something else that is faster.
Loving the 1.11.2 update and appreciate your hard work.
Thanks.

The bug you mentioned has already been reported.
The jetpack mode you mentioned is definitely high on my agenda once I finish the fixes for the 1.11.2 release.  Keep an eye out :)


Extract full API error on Client Exception

Currently when API returns HTTP400 (src/Keboola/GoogleSheetsWriter/Application.php:91) message is returned as UserException message. But Guzzle truncates the message. The full error message should be stored in the response body. And that should be passed to the Exception. Either as message as additional context.

Ref.: https://keboola.slack.com/archives/C02CGRFGU/p1531481264000141


Wrong volume count reported to prometheus after vaccuum

Describe the bug
After running vacuum, the number of volumes reported to prometheus pushgateway increases by 2.
System Setup
weed master -ip <IP_ADDRESS>
      -port 9333 -mdir /data -defaultReplication 020 -peers <IP_ADDRESS>:9333,<IP_ADDRESS>:9333,<IP_ADDRESS>:9333
      -volumeSizeLimitMB 30000 -metrics.address <IP_ADDRESS>:9091

weed volume -max 150 -dir /weedfs -mserver <IP_ADDRESS>:9333 -dataCenter
      DC1 -rack RACK1 -port 8080 -ip <IP_ADDRESS>

Expected behavior
Number of volumes stays the same and corresponds to the actual number of used volumes.

This was fast, thanks! 👍


Added missing method for requestEquippedProfileItems to register

Added missing method for requestEquippedProfileItems to register
Updated .gitignore to prevent steam SDK from being detected as pending commits

Very cool.  Thank you!


activation keys not working

Hi :)
I was trying to use activationKeys prop with different keys to allow the wheel only with them.
for example:
allow wheeling only when alt is pressed.
 <TransformWrapper
            initialScale={1}
            maxScale={2}
            wheel={{step: 0.4, activationKeys: ["18", "alt"]}}
            doubleClick={{disabled: true}}
            onWheel={({state: {scale}}) => setCurrentZoom(scale)}
          >

The actual result is that it's disabled the wheel option completely.

+1

For what it's worth this works for me

 <TransformWrapper
   wheel={{ step: 0.4, activationKeys: ["z"] }}
/>

It uses KeyboardEvent.key to check wich key is being pressed. So you need to set "Alt" with first uppercase.
https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/key


ARROW-7349: [C++] Fix the bug of parsing string hex values

std::lower_bound returns the end of the search range, when failing to find a match.
The end of the search range is one position after the last valid position. So the value in this position is undefined, and we should not reference the value here to compare it with the target value.

Thank you @liyafan82 ! I will merge when green.

Thank you @liyafan82 ! I will merge when green.

@pitrou Thank you so much for your effort.

Seems this maven error is occurring a lot
[ERROR] Failed to execute goal on project arrow-orc: Could not resolve dependencies for project org.apache.arrow.orc:arrow-orc:jar:1.0.0-SNAPSHOT: Failed to collect dependencies at org.apache.orc:orc-core:jar:1.5.5: Failed to read artifact descriptor for org.apache.orc:orc-core:jar:1.5.5: Could not transfer artifact org.apache.orc:orc-core:pom:1.5.5 from/to central (https://repo.maven.apache.org/maven2): repo.maven.apache.org: Temporary failure in name resolution: Unknown host repo.maven.apache.org: Temporary failure in name resolution -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :arrow-orc
##[error]Process completed with exit code 1.

Merging


Calculate gradients between adjacent grid squares

As the product owner I want IMPROVER to have the capability to decide whether precipitation is convective or stratiform based on the precipitation texture. The calculation of gradients between adjacent grid squares is the first part of that functionality. It is also a functionality need for topographic gradients.
Related issues: #76
Once gradients have been found, the ratio of the number of grid squares with high precipitation-rate gradients to the number of grid squares with any non-zero precipitation-rate gradients in a region (or square neighbourhood) can be used as a tool to deduce whether the precipitation is convective, partly convective or stratiform. This can also be applied to other variables and will also have use in detecting convective gusts. The gradients need only be found in the x and y directions (not diagonally). It can be essentially the same function as for #76 and therefore they could be combined.
Note - this is bringing forward the convection diagnosis in the roadmap because EMOS for temperature is already in place.
Suggest a convention that the x-direction gradient specified for a grid square relates to the gradient on the eastern edge of that square and the y-direction gradient specified for a grid square relates to the northern edge of that square. However, this convention does not need to be followed if a different one proves to be better.
Acceptance criteria:

Create a plugin with the correct metadata.
Create a function that finds the gradients between adjacent grid squares in x and y directions
Outputs array with 2x2d fields containing gradients - one 2-d field for x and one 2-d field for y

This issue has been superseded by the Epic: Ancillary Generation for Improver (#97) and will be included in a User Story under this Epic.

Reopened issue as a user story related to the  Epic: Ancillary Generation for Improver (#97)

As a technical note, the current working assumption of this ticket is that it will use np.diff to yield the discrete differences between adjacent grid squares, rather than np.gradient.

Pr #147  was merged which superceed  pr #142.
Slides have been created and there are no follow on issues. So this item is being closed. All outstanding questions about cf metadata should be covered by #91


Docs: append a demo on huggingface to digitalize the audiogram image

Hi, very thanks for your open sourcing of this interesting research.
I try to build a demo app at huggingface: https://huggingface.co/spaces/weiren119/AudiogramDigitization

Thanks! This is great!


fixed-time-control test for e2e

can you maybe also check the time in the pgn, the current state is perhaps a bit useless

u mean the pgnout output from the ci? how to do that?

In the script check that the times in the pgn are what you expected ?

hmm the random mover doesnt seem to have a time control logic, so this pr is useless


Script is "too long" for datastore.

Describe the bug
The script below causes the following error to be returned form the API:
Error: GraphQL error: failed to insert script execution record: datastore: string property too long to index for a Property with Name "Value"

To Reproduce
Attempt to execute a script of roughly the same number of characters.
Expected behavior
The script is executed properly. No errors.
Additional context
The script:
import NonFungibleToken from {{0xNonFungibleToken}}
import Basketballs from {{0xBasketballs}}
import BasketballsMarket from {{0xBasketballsMarket}}
pub struct MarketplaceSaleOfferView {
    pub let saleItemID: UInt64
    pub let salePrice: UFix64
    pub let saleCompleted: Bool
    pub let editionID: UInt32
    pub let serialNumber: UInt64
    pub let name: String
    pub let description: String
    pub let imageURL: String
    pub let nftCount: UInt64
    init(
      saleItemID: UInt64,
      salePrice: UFix64,
      saleCompleted: Bool,
      editionID: UInt32,
      serialNumber: UInt64,
      name: String,
      description: String,
      imageURL: String,
      nftCount: UInt64
    ) {
        self.saleItemID = saleItemID
        self.salePrice = salePrice
        self.saleCompleted = saleCompleted
        self.editionID = editionID
        self.serialNumber = serialNumber
        self.name = name
        self.description = description
        self.imageURL = imageURL
        self.nftCount = nftCount
    }
}
pub fun main(address: Address): [MarketplaceSaleOfferView] {
    let account = getAccount(address)
    let marketCollectionRef = account
        .getCapability<&BasketballsMarket.Collection{BasketballsMarket.CollectionPublic}>(
            BasketballsMarket.CollectionPublicPath
        )
        .borrow()
        ?? panic("Could not borrow market collection from address")
    let basketballsCollectionRef = account
      .getCapability<&Basketballs.Collection{NonFungibleToken.CollectionPublic, Basketballs.BasketballsCollectionPublic}>(
        Basketballs.CollectionPublicPath
      )
      .borrow()
      ?? panic("Could not borrow basketballs collection from address")
    let saleOfferViews: [MarketplaceSaleOfferView] = []
    let offerIds: [UInt64] = marketCollectionRef.getSaleOfferIDs()
    for offerId in offerIds {
      let saleItem = marketCollectionRef.borrowSaleItem(saleItemID: offerId)
      let basketball = basketballsCollectionRef.borrowBasketball(id: saleItem!.saleItemID)!
      let editionMetadata = Basketballs.getEditionMetadata(editionID: basketball.editionID)
      let saleOfferView = MarketplaceSaleOfferView(
        saleItemID: saleItem!.saleItemID,
        salePrice: saleItem!.salePrice,
        saleCompleted: saleItem!.saleCompleted,
        editionID: editionMetadata.editionID,
        serialNumber: basketball.serialNumber,
        name: editionMetadata.name,
        description: editionMetadata.description,
        imageURL: editionMetadata.imageURL,
        nftCount: editionMetadata.nftCount
      )
      saleOfferViews.append(saleOfferView)
    }
    return saleOfferViews
}

Do we need to add a noindex Go field tag on the Value field?

No more datastore :)


Remove extra calculation in Induction Motor models

I see the issue. Now we have the parser for EXST1 so we don't need to do it. I'll update the test here to fix the issue.


Fix a style issue.

Codecov Report

Merging #310 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #310   +/-   ##
=========================================
  Coverage     90.55%   90.55%
  Complexity      495      495
=========================================
  Files            80       80
  Lines          1959     1959
  Branches        143      143
=========================================
  Hits           1774     1774
  Misses          149      149
  Partials         36       36

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f443b1a...7cf7778. Read the comment docs.


Ability to remove model

From kirimase created by nelsonfrz: nicoalbanese/kirimase#5
As a user I would like to remove models or specific resources of a model.

agreed


brew update should show "New Formulae" and "New Casks" when update from API

Verification

[X] This issue's title and/or description do not reference a single formula e.g. brew install wget. If they do, open an issue at https://github.com/Homebrew/homebrew-core/issues/new/choose instead.

Provide a detailed description of the proposed feature
In old tap-repo-based behavior, brew update will show newly added formulae and casks by calculating the git differences. Now, the API-based brew, does not have a git repo to do that (or does not update the git repo at all even if the git repo is tapped). Currently, brew downloads the new JSONs from API and overwrites the content of the existing file in-place. brew can only tell the newest state of the formulae without the historical changes. I think we can keep a backup of the old already downloaded JSON file before fetching the new content. Then calculate the differences after a successful brew update call.
$ export HOMEBREW_NO_INSTALL_FROM_API=1
$ brew update
Updated 2 taps (homebrew/core and homebrew/cask).
==> New Formulae
clipboard<EMAIL_ADDRESS>                 openai-whisper                  pmtiles
==> New Casks
mediainfoex                                pulsar                                     simpleclock
==> Outdated Formulae
cmocka                          node                            oh-my-posh<EMAIL_ADDRESS>
You have 4 outdated formulae installed.
You can upgrade them with brew upgrade
or list them with brew outdated.

What is the motivation for the feature?
To show newly added packages are available. This was part of the old no-install-from-API feature.
How will the feature be relevant to at least 90% of Homebrew users?
This affects all Homebrew users because the core tap is always used.
What alternatives to the feature have been considered?
Do nothing but prompt a hint to suggest users set HOMEBREW_NO_INSTALL_FROM_API if they want this.

This could be possible if we diff with the soon-to-be-introduced formula_names.txt and cask_names.txt files.
The slight snag is the API updates more often than when update-report runs, which complicates the matter. brew update is run once every 24 hours (1 hour for those with brew developer enabled), but API auto-update is by default every 7½ minutes.

I think we could just compare the current api json to the api json from the previous update-report. We'd have to cache that somewhere in the meantime though.

I think this is a "nice to have" and accepting the PR will be heavily based on how complex/large the PR ends up being.

@jimscard It's almost as if I was already working on a PR for this, linked before your 👎🏻 and comment: https://github.com/Homebrew/brew/pull/14802
Please read a bit more carefully before you leave messages like this in future, thanks.


Ability to define downstream lineage for datasets in the MCE message

Is your feature request related to a problem? Please describe.
Currently, MCE -> Snapshot -> Dataset -> DatasetAspects only allow to define upstream lineage. This request is to also support defining downstream lineage as a dataset aspect.
Describe the solution you'd like
It should be a small change by importing already existing, DownstreamLineage.pdl to the DatasetAspect.pdl.

Happy to contribute back, if you agree with the feature request and approach.

Happy to contribute back, if you agree with the feature request and approach.

Since one can derive the downstream from all the upstream info, there's no need to capture them separately. DataHub currently uses the graph DB to query downstream information: https://github.com/linkedin/datahub/blob/master/gms/impl/src/main/java/com/linkedin/metadata/resources/dataset/DownstreamLineageResource.java#L67

Since one can derive the downstream from all the upstream info, there's no need to capture them separately. DataHub currently uses the graph DB to query downstream information: https://github.com/linkedin/datahub/blob/master/gms/impl/src/main/java/com/linkedin/metadata/resources/dataset/DownstreamLineageResource.java#L67

Closing for now, assuming this was answered (thanks, Mars). Having only one kind of edge in the metadata / ecosystem simplifies things.

Closing for now, assuming this was answered (thanks, Mars). Having only one kind of edge in the metadata / ecosystem simplifies things.

@mars-lan @jplaisted Thanks for quick reply. Let me present the use case for which I made this request(I should have  done this earlier).
From our source systems, we are getting lineage between datasets A and B. metadata of dataset A is known to us as it is part of source system which is already onboarded to the datahub. On contrary, dataset B belongs to some source for which we don't have any information in the system. As a result, we can't define this lineage metadata using upstream lineage of dataset B.
If we do create dataset B, it doesn't have schema or relevant metadata. In ideal scenario, we are expecting only lineage metadata visible but not the dataset B as it can lead to misunderstanding and unnecessary compliance alerts.
Though I agree that having only one kind of edge simplifies the interface, imo it is also about flexibility to define metadata.
Please share your thoughts or if you can help me with better approach in the above scenario.

@mars-lan @jplaisted Thanks for quick reply. Let me present the use case for which I made this request(I should have  done this earlier).
From our source systems, we are getting lineage between datasets A and B. metadata of dataset A is known to us as it is part of source system which is already onboarded to the datahub. On contrary, dataset B belongs to some source for which we don't have any information in the system. As a result, we can't define this lineage metadata using upstream lineage of dataset B.
If we do create dataset B, it doesn't have schema or relevant metadata. In ideal scenario, we are expecting only lineage metadata visible but not the dataset B as it can lead to misunderstanding and unnecessary compliance alerts.
Though I agree that having only one kind of edge simplifies the interface, imo it is also about flexibility to define metadata.
Please share your thoughts or if you can help me with better approach in the above scenario.

@shakti-garg-saxo: Even in the case where you attach lineage information to A (instead of B), you would need a dataset-urn for B.
The meta-model allows you to have nodes in the graph where aspects are not defined and are optional, so it should be possible for you to create the entity B without having to attach schema / other metadata to it.
One way, we have handled this differentiation of datasets that are known fully versus known barely :) is by assigning them a platform called "external". You could choose something else as a marker platform, and ensure that your UI doesn't render datasets from that platform (if that is important to you).
One interesting side benefit of having these kind of datasets be visible, is that users often ask for more information about them, which leads to the team that owns the platform signing up to publish metadata for those platforms. So you might actually unlock better metadata coverage through this!
HTH

@shakti-garg-saxo: Even in the case where you attach lineage information to A (instead of B), you would need a dataset-urn for B.
The meta-model allows you to have nodes in the graph where aspects are not defined and are optional, so it should be possible for you to create the entity B without having to attach schema / other metadata to it.
One way, we have handled this differentiation of datasets that are known fully versus known barely :) is by assigning them a platform called "external". You could choose something else as a marker platform, and ensure that your UI doesn't render datasets from that platform (if that is important to you).
One interesting side benefit of having these kind of datasets be visible, is that users often ask for more information about them, which leads to the team that owns the platform signing up to publish metadata for those platforms. So you might actually unlock better metadata coverage through this!
HTH

@shakti-garg-saxo This is an interesting topic. The current lineage model kind of assuming datasets have equal knowledge about lineage, now we are looking at the cases where certain nodes is holding more info; while some others may only be needed as bridges (they could be important though, to help uncover unknown lineages). For your use case, seems that we do need to introduce extra aspect such as downstream. The downside are:

1. You may end up storing duplicated info in the document store for the nodes that have both downstream & upstream info.

2. It may not work for high cardinality relationships: https://github.com/linkedin/datahub/blob/master/docs/advanced/high-cardinality.md

@shakti-garg-saxo This is an interesting topic. The current lineage model kind of assuming datasets have equal knowledge about lineage, now we are looking at the cases where certain nodes is holding more info; while some others may only be needed as bridges (they could be important though, to help uncover unknown lineages). For your use case, seems that we do need to introduce extra aspect such as downstream. The downside are:

1. You may end up storing duplicated info in the document store for the nodes that have both downstream & upstream info.

2. It may not work for high cardinality relationships: https://github.com/linkedin/datahub/blob/master/docs/advanced/high-cardinality.md

Agree on all the above points. We will then continue on our existing approach of tagging unknown datasets with some markers.
@shirshanka agree on your suggestion to keep them visible to users for more push to compliance.
@camelliazhang Thanks for the pointing out technical downsides(I certainly overlooked them in my analysis :) )

Agree on all the above points. We will then continue on our existing approach of tagging unknown datasets with some markers.
@shirshanka agree on your suggestion to keep them visible to users for more push to compliance.
@camelliazhang Thanks for the pointing out technical downsides(I certainly overlooked them in my analysis :) )


Docker usage

Add docker usage with dockerfile.
Set it up so everyone can make a working image and containerize the app.

Oi kris007iron, Dockerfile bolta hai?  Chalo, let's show you how we party in Delhi, container-style!  Think gali cricket match, think bhelpuri with extra spice, same level of madness we're bringing!
Dockerfile?    Bahut bada, like politician's ego:  This baby will be so bloated, it'll make your registry scream like aunty bargaining at Chandni Chowk. We're talking useless libraries, old code nobody dares to remove... might even find a pirated movie in there, why not? 🤷♂
"Working" is for suckers, yaar: This image, it will work... if it feels like it. Mostly it'll give errors more confusing than finding parking at Connaught Place. Debugging? Hum galiyaan denge (we'll swear) and hope for the best, true desi dev style! 🤬
Collaboration? Teamwork? Abey kya bakwaas hai:  Every dev will dump their special "fix" into this container.   Let's make this container a wild ride, bhai! 🔥🔥🔥


Drag functionality is broken.

Details

iOS Version 15.2.1
Framework Version 1.6.3
Installed via SPM

Describe the Bug
The drag & drop functionality is broken. The indicator view in not being dragged. It just jumps and it is not following the finger around.

Fixed new 1.6.4 version


[5.2] Preserve keys in collection reverse

Closes #9948
Sent to master because method signature is changed.

Why not to 5.1?
This doesn't change current behaviour..

It is a breaking change though because it changes the method signature.

I would have it preserve keys in 5.2, and be done with it. No need for the flag.
If you want to reset the keys, call values() on the result.

Yeah, that makes sense, but it's a bigger bc break on the other hand.
@taylorotwell Any thoughts?

I agree with @JosephSilber. I don't like adding all these flags for preserving keys. We should preserve keys where possible and, as he said, use ->values if you don't want keys.

Okay, gonna change it in a couple of hours then.

Went ahead and fixed it for you.


Create SVM.md

This .md file provides an explanation of the Support Vector Machine (SVM) algorithm, detailing its use in classification and regression tasks. It covers how SVM maximizes the margin between classes, even in non-linear cases, using kernel functions. The file also includes a mathematical representation and highlights real-life applications such as spam detection, medical image classification, and customer churn prediction, demonstrating SVM’s versatility in various industries.

Already available. iF you want to enhancement, do it. otherwise closed the PR


Enhancement request: remove title from Ask for Help forum template

Describe your problem and - if possible - how to reproduce it
As a forum moderator, I would like to request that the forum template that users get when they click the Ask for Help button be modified. Currently, it puts the name of the challenge as the title. This is problematic for two reason. Firstly, we are trying to encourage users to create descriptive titles for their posts. Secondly, since the forum does not allow for duplicate posts with the same name, most users just button-mash some letters or numbers at the end of the title or just add variations of "<<<<<help" at the end.

Should this issue be closed since there is a merge already resolving the issue?

Shouldn't this issue be closed since there is already a resolution that is merged with the master branch?

@ArielLeslie @hilliarj This issue is being closed as the PR linked above resolved it.


kind/feature/5395/expand pod template spec

Adding pod template support for field: AutomountServiceAccountToken

Release Note
NONE

Hi, I'm not sure what value should actually be added for the "protobuf" string in pkg/apis/camel/v1/integration_types.go. The value I gave was protobuf:"varint,8,opt,name=automountServiceAccountToken" taking inspiration from other boolean values however the 8 is just a guess. What's an appropriate value to add when introducing new fields?

You can follow the k8s api podspec and set 21

@claudio4j Thanks I found the right values. Also I noticed in pkg/apis/camel/v1/integration_types.go it has some outdated make goal. To get the right functionality I ran make generate instead. Would it be appropriate to update this comment as well?
Run "make generate-deepcopy" to regenerate code after modifying this file

To consider if this is really ready to merge: https://camel.zulipchat.com/#narrow/stream/257299-camel-k/topic/pod.20template.20fields.20interfere.20with.20knative

I added the test to ensure that the field is set properly on the deployment. I also relayed with my security team and it we only need this field so that we can set it to false which does not interfere with Knative. It is only when this field is explicitly set to True that Knative interferes through validation.
So for my team and this field specifically this PR would be enough. There are other fields that we'd like set however those do have issues with Knative so I'm working on getting conversations started with the Knative teams.

It is only when this field is explicitly set to True that Knative interferes through validation


Is there package for meteor 1.3.3

hi
TongChia
Is there package for meteor ,when i installed and used cordova-pluging-pingpp in meteor project ,there were some problems,such as api undefined , hope for the package for meteor.
best regard!
tom wang

try in .meteor/cordova-plugins add  me.tongchia.cordova.pingpp@https://github.com/janpo/cordova-plugin-pingpp.git#master


Elastic File System support

Hello,
I have a few clients using Empire which would benefit using a shared EFS volume across container instances for some of their applications. I understand it is not possible at the moment to declare volumes for app processes (a convox-like convention would be great to have though), but is there any way this could be achieved (assuming the EC2 instances have the EFS already mounted) with the current implementation, by somehow making changes directly into the task definitions generated by Empire?
Thank you!

There's no reason we couldn't support volumes in the Procfile, but here's the reasons why we haven't added it:

Volumes wouldn't be useful for us (Remind), since we don't run any services that require file system persistence.
Volumes open up additional security considerations.

I think if we added volumes to the Procfile, we'd need flags to be able to disable it.
With that said, we're definitely open to PR's that would add this!


[RFC] Remove MultiProgress::join()

This should not be merged yet, but I'd like to know if this looks like something worth pursuing.
This change moves drawing of MultiProgress from the join() thread to the child ProgressBar updates.
This has the following advantages:

It addresses #125 (async MultiProgress), as long as users are willing to assume the writes to the screen do not block (and they do not add enough child progress bars for lock contention on the MultiProgress state to be an issue). It also makes it trivial to use MultiProgress without any threads or async runtime at all.
It helps with #205 (add println to MultiProgress) because println on MultiProgress can now be made to work while the MultiProgress does not have any unfinished progress bars / join() hasn't been called yet.
Arguably the code is simpler (and it removes the one use of unsafe in indicatif: MultiProgress is now automatically Sync).

It also has disadvantages, most of which I think can be mitigated:

It removes grouping, which regresses the problem fixed by #166. I think it is possible to largely mitigate this by implementing a draw target that uses a timer (via an async runtime or a thread) to schedule a draw rate - last_draw.elapsed() in the future if we don't want to draw immediately. I haven't written the code for this yet, though, so it might not be as easy as I think...
It is backwards-incompatible. This could be mitigated by implementing this as a new type (and a new ProgressDrawTargetKind, which is fine as those are not public) if the old behavior is deemed useful enough to keep around and/or we want to avoid the semver bump.
It removes the ability to use the MultiProgress as a synchronization point. For the examples, this was very easy to fix by joining the worker threads instead. I don't know if this is also true for "real" code.
It moves work from the join() thread to the threads updating the progress bars. I suspect this is not a problem because that work is already fast enough (relative to rendering the child progress bar to a ProgressDrawState, which was already happening on the worker threads), but I haven't benchmarked it. It might be a problem for code that has at least one progress bar that is updated at a very high rate.

I think the DrawTarget-with-a-timer is useful anyway: it should mitigate a problem very similar to #166 when doing something like:
use std::thread;
use std::time::Duration;

use indicatif::ProgressBar;

fn main() {
    let p = ProgressBar::new_spinner();
    for _ in 0..10 {
        p.set_message("performing fast work (you should rarely see this)");
        // Just to demonstrate they don't need to be back-to-back. Removing this sleep does not change behavior.
        thread::sleep(Duration::from_millis(5));
        p.set_message("performing slow work (you should see this)");
        thread::sleep(Duration::from_secs(1));
    }
}

This currently only shows "you should not see this" for the same reason the MultiProgress example didn't stay in sync. With a DrawTarget-with-a-timer, it would show "you should not see this" for only one update interval. So I'll probably see if I can get that to work even if this change isn't deemed useful.
Please let me know what you think!

My main question on this direction is whether it creates new problems for scoping of the MultiProgress and threads. I don't know that it does, but also don't currently know that it doesn't.

My main question on this direction is whether it creates new problems for scoping of the MultiProgress and threads. I don't know that it does, but also don't currently know that it doesn't.

I'm not sure if I understand the question about scoping. Can you give an example you're concerned about?
To port to the new code, all you should have to do is remove the call to join() and make sure this does not cause the program to exit too soon (you may have to wait for worker threads explicitly to do so). It is ok if dropping the call to join() causes the MultiProgress to be dropped before the worker threads are done with their ProgressBars: any ProgressBars already added to the MultiProgress before it was dropped will continue to work correctly, you just can't add any additional ones without a reference to the MultiProgress.

I'm not sure if I understand the question about scoping. Can you give an example you're concerned about?
To port to the new code, all you should have to do is remove the call to join() and make sure this does not cause the program to exit too soon (you may have to wait for worker threads explicitly to do so). It is ok if dropping the call to join() causes the MultiProgress to be dropped before the worker threads are done with their ProgressBars: any ProgressBars already added to the MultiProgress before it was dropped will continue to work correctly, you just can't add any additional ones without a reference to the MultiProgress.

#234 adds the promised DrawTarget-with-a-timer.

#234 adds the promised DrawTarget-with-a-timer.

This branch solved a problem I was having with my application structure. Thanks for the work!

Sorry for taking so long to get to this. I do think this idea makes sense. Would you be willing to rebase it on top of current main? It looks like some of the structural changes that you made are already part of main now, but there have been quite a few changes, so the rebase might be a little painful.

I like this too, I have rebased @marienz's changes onto main and added a leaky bucket to the rate limiting to fix the regression on #166 in aj-bagwell:multiprogress-unjoined if that helps keep this moving.

Sounds great, would you mind submitting a separate PR for this?

@djc sure, new pull request is #284

Okay, I'll close this for now.


Refactor query

Generally :+1: , though if you are including the changes from https://github.com/fedimint/fedimint/pull/6536, then lets already use retry there, and I think that channel to delay await until first submit suceeded is a worthwhile improvement (but I'm happy to argue about it :D ).


Option to show "chores" as part of release notes

For the PHP releases, we'd really like to show conventional commits labeled with "chore" as "Miscellaneous Chores"
See https://github.com/googleapis/repo-automation-bots/issues/3145
This was happening with our previous releases (v0.172.0), but recently this has gone away (v0.173.0)

This is a regression from v12 -> v13


Fixing install_upgrade job issues

@stevekuznetsov @sdodson PTAL
Here is a job running with these changes:
https://ci.openshift.redhat.com/jenkins/job/test_branch_origin_extended_conformance_install_update/86/

Closing in favor of https://github.com/openshift/aos-cd-jobs/pull/139#discussion_r108947969


No spatializer was specified

Describe the bug
When importing the foundation package into Unity, the process fails to import the 'ExampleSpatialMesh.room' asset, and the AssetDatabase Refresh warning is shown. This happens in 2018.4 and 2019.3, see the screenshotsfor specifics.
To reproduce
Steps to reproduce the behavior:

Create new project
Import Foundation package
Apply Project Configuration
Check console

Expected behavior
No errors displayed in console after initial MRTK Foundation package import. The console should be error free.
Screenshots

Your setup (please complete the following information)

Unity Version 2018.4, 2019.3
MRTK Version 2.4

Target platform (please complete the following information)
-Unity

Additionally if one imports the examples package after this error occurs, the errors in the pictures below happen. This happens in 2018.4 and 2019.3

I can quiet these non-fatal warnings.

I can quiet these non-fatal warnings.


Prisma executing queries very slowly (15+ seconds), majority of time in traces taken up by BEGIN and SELECT 1 calls

Bug description
Hi,
First of all thanks for your work on the library and your time spent looking into this issue. So I have a table in my postgres database with just barely under 2M rows, and executing the following prisma query on it often takes anywhere from 5 to 15 seconds or more. It's a very simple and reasonable query that executes in under 1ms when done from HeidiSQL, so I don't understand why it's taking so long:
SELECT * FROM "TokenHolder" WHERE "tokenAddress" = 'XXXXX' ORDER BY "amount" DESC LIMIT 100;
So I set up telemetry with Jaeger and found that on this query in particular, Prisma is spending 7.38s on a BEGIN statement. This seems to be a pattern across many slow queries I found. I saw instances of BEGIN as well as SELECT 1 taking up a significant portion of the request lifecycle.

This next example shows a SELECT 1 taking 6.07s followed by a BEGIN taking 7.66s. The query itself takes 12.05s, but I'm honestly more concerned about the SELECT 1 and BEGIN problem for the time being:

How to reproduce
I am unsure what the best way to reproduce this would be on your end considering how I'm doing what I'm doing. The application is very large. I am happy to produce more specific relevant debug output that could help if requested, but I'm not sure what you would require at this point.
Expected behavior
Expecting a simple query to take less than 5 to 15 seconds to execute.
Prisma information

// Add your schema.prisma
generator client {
  provider        = "prisma-client-js"
  previewFeatures = ["metrics", "tracing"]
}

datasource db {
  provider = "postgresql"
  url      = env("POSTGRES_URL")
}

model TokenHolder {
  token        Token  @relation(fields: [tokenAddress], references: [address])
  tokenAddress String

  walletAddress String

  amount Decimal @db.Decimal(78, 0)

  time DateTime @default(now())

  @@id([tokenAddress, walletAddress])
  @@index([tokenAddress])
}

// Add your code using Prisma Client
prisma
    .tokenHolder
    .findMany({
        where: {
            tokenAddress: "XXXXX"
        },
        orderBy: {
            amount: "desc"
        },
        take: 100
    })

Environment & setup
Running in Docker Desktop.

OS: Windows 11 Pro
Database: PostgreSQL 16 behind PGBouncer 1.21.0
Node.js version: 18.14.2 (18.18.1 on host)
Docker base image: node:18.14.2-alpine3.16

PostgreSQL is running on the host machine. System is using Ryzen 9 5950x 16c/32t as well as 64GB RAM.
Connection string (this is directed to PgBouncer on the host system) -- it took me a long time to optimize this to where Prisma wouldn't crash trying to fetch a connection, it still crashes sometimes but it's okay most of the time. Would definitely like to reduce the timeouts:
postgres://user:pass@host.docker.internal:6432/db?schema=public&connect_timeout=60&connection_limit=65&pool_timeout=60&socket_timeout=60&pgbouncer=true&sslmode=disable

It is important to note that if I do not use PgBouncer, after a set period of time, my Postgres instance will completely stop responding to any Prisma requests. This will last for an indefinite (usually very long) period of time until I manually restart the Postgres Windows service.
Prisma Version
On host:
prisma                  : 5.7.1
@prisma/client          : 5.7.1
Computed binaryTarget   : windows
Operating System        : win32
Architecture            : x64
Node.js                 : v18.18.1
Query Engine (Node-API) : libquery-engine 0ca5ccbcfa6bdc81c003cf549abe4269f59c41e5 (at node_modules\.pnpm\@prisma+engines<EMAIL_ADDRESS>Schema Engine           : schema-engine-cli 0ca5ccbcfa6bdc81c003cf549abe4269f59c41e5 (at node_modules\.pnpm\@prisma+engines<EMAIL_ADDRESS>Schema Wasm             : @prisma/prisma-schema-wasm 5.7.1-1.0ca5ccbcfa6bdc81c003cf549abe4269f59c41e5
Default Engines Hash    : 0ca5ccbcfa6bdc81c003cf549abe4269f59c41e5
Studio                  : 0.495.0
Preview Features        : metrics, tracing

Within Docker container:
prisma                  : 5.7.1
@prisma/client          : 5.7.1
Computed binaryTarget   : linux-musl
Operating System        : linux
Architecture            : x64
Node.js                 : v18.14.2
Query Engine (Node-API) : libquery-engine 0ca5ccbcfa6bdc81c003cf549abe4269f59c41e5 (at node_modules/.pnpm/@prisma+engines<EMAIL_ADDRESS>Schema Engine           : schema-engine-cli 0ca5ccbcfa6bdc81c003cf549abe4269f59c41e5 (at node_modules/.pnpm/@prisma+engines@5.7.1/node_modules/@prisma/engines/schema-engine-linux-musl)
Schema Wasm             : @prisma/prisma-schema-wasm 5.7.1-1.0ca5ccbcfa6bdc81c003cf549abe4269f59c41e5
Default Engines Hash    : 0ca5ccbcfa6bdc81c003cf549abe4269f59c41e5
Studio                  : 0.495.0
Preview Features        : metrics, tracing

For tme they take around 2-4 seconds, very slow and I'm just querting 2 products with findMany

Hi, I don't mean to appear insistent by bumping this, so please excuse me, but it's been quite some time since this issue was first raised, and it significantly disrupts our ability to use Prisma. Is there any information I can provide? I'm happy to help you debug in any way I can.
A further development.. In regards to my original statement in this issue:

Connection string (this is directed to PgBouncer on the host system) -- it took me a long time to optimize this to where Prisma wouldn't crash trying to fetch a connection, it still crashes sometimes but it's okay most of the time. Would definitely like to reduce the timeouts:

I would like to add here that this error I was experiencing (Timed out fetching a new connection from the connection pool error) has increasingly become a significant problem, severely impacting the usability of the application. After conducting some research, it appears there's a preference against raising issues on this topic, so I've decided to address it here in passing rather than opening a new issue. I welcome your guidance on how best to proceed.
Additionally, the solutions proposed in the discussion thread linked above do not appear relevant to our situation. If I'm mistaken, please advise, but increasing timeouts as a solution doesn't address the root cause of slow queries. Our application requires fast data processing (subsecond), so adjusting Prisma to allow for 10 or 30-second timeouts doesn't align with our operational needs and is not a viable workaround for us.
Furthermore, the issue extends to prisma.$executeRawUnsafe for executing raw SQL queries, which is also affected. Our production environment, equipped with 48 cores and 384 GB of RAM and exclusively hosting PostgreSQL and a clustered Node application, is experiencing near-unusable performance levels, with the server CPU usage only reaching 5-9%.
Given the substantial resources at our disposal, such performance issues are very troubling. Any advice or further steps you could suggest would be highly appreciated.

Thank you for your response.

The user you link to here has created a discussion and then just used that to also open an issue with the same text and information - which is why I closed the duplicate issue. I hope that is an understandable preference.

Understood, that was my oversight.

Please open a discussion with all information about your connection pool timeout related problem. Having both problem mixed into one issue here is definitely not helpful.

After recent tests, I suspect the issue may lie with the Postgres config or underlying connection pooling behavior, not Prisma itself. I wil conduct some more tests today and share my findings in a discussion update.

To your first question: A reproduction we can run ourselves to experience the problem ourselves is always helpful.

I will prepare a simple reproducible example post-testing.

Did you double check in your database that the queries actually take that long?
I reviewed the Postgres slow query log and it reported only a few slow queries (eight) out of tens of thousands, with each executing in less than 150ms.

Otel tracing via tracing is still a preview feature, and might potentially misreport the times of these queries.

We actually haven't set up Prisma tracing on our production instance, to measure the time it takes to insert these queries I just did a very simple subtraction of Date.now() before and after the query as follows:
const t0 = Date.now()
await insertWithOrWithoutPrisma()
const d = Date.now() - t0

/*
    if using prisma, this crashes OFTEN when it takes too long according to the timeouts
    specified within the conn string. if not using prisma (i.e. simple raw query through "pg" lib)
    then it will take a very long time and log anywhere from 1ms to upwards of 5-15 mins in prod.
    even after our load tester (all incoming postgres load) is shut down, postgres is still processing these
    same insert queries up to fifteen minutes later depending on how long the load producer had
    been running.
*/
console.log(d)

Given the issue occurs with both Prisma and direct database queries, it seems that the cause lies within our database setup rather than the application layer.
P.S. our production environment hosts both the PostgreSQL database and the node script on the same machine. For this reason I don't believe network latency to be a factor either.
Will report back with my findings once I do some more benchmarking and debugging. Thanks!

@Threebow Looking forward to hear your findings

Hi all,
It seems that the more recent connection timeouts were being caused by our database setup and app architecture. The changes we made that have shown us significant improvement in this area since my last update is as follows:

We changed a few PostgreSQL configuration settings (notably shared_buffers, work_mem, and synchronous_commit)
We redesigned this part of our application to decrease overall database queries. Before, every Node thread sent queries, slowing performance, even with PgBouncer. Now, worker threads pool queries in Redis and execute them sequentially through batch upserts in the primary thread at short intervals. This method, while handling the same or greater data volume, significantly boosts performance. Additionally, it eliminates batch-insert deadlocks between processes, an issue we commonly ran into caused by concurrent batch inserts with duplicate unique keys.
We replaced Prisma with raw SQL in certain complex situations, particularly implementing batch inserts in raw SQL helped significantly. We are now using a healthy mix of Prisma and raw SQL for simple CRUD operations andcomplex business logic respectively. So far, it's been much better than using Prisma for everything.

These changes have made our database significantly more usable (approx. 1.5-2x higher throughput) as well as optimized our machine's resource usage to better utilize all available cores and RAM.
As for the original focus of this issue (BEGIN and SELECT 1) -- to me, these issues appear to manifest as a general side effect of having a database that cannot keep up with your volume of queries, and they seem to have gone away as a result of our optimizations.
Having said this, I am not sure how to proceed with this particular issue request, as it seems to me like it may still be worth investigating. I will leave it for you to decide @janpio 🙂

Thanks for the update @Threebow, we really appreciate it.
Do you think there is anything concrete we should or could look into?
Do you for example have concrete examples where replacing Prisma's generated queries with hand written raw SQL had unexpected but significant effects?

Do you think there is anything concrete we should or could look into?

Nothing particularly relevant to the initial scope of this issue, unless you think BEGIN and SELECT 1 taking 5+ seconds in this circumstance is unusual. I am not sure exactly why SELECT 1 is called in certain queries, but I'm sure there is a good reason for it. I think that only you or other Prisma core team would know if it's worth optimizing that SELECT 1 query.

Do you for example have concrete examples where replacing Prisma's generated queries with hand written raw SQL had unexpected but significant effects?

There is one very specific example where replacing Prisma with raw SQL had significant improvements. Because it's documented that Prisma doesn't perform a "true" atomic upsert, I knew that using upserts initially through Prisma would lead to performance issues. The extent of which, however, I didn't realize until I had actually started to use them.
It seems very strange to me that the currently accepted solution is to further strain the database with additional queries. I am sure this is done for a good reason, but this reason doesn't immediately jump out to me.
Initially, I implemented this basic helper to deal with the upsert error:
export function upsert<T>(fn: () => Promise<T>): Promise<T> {
	// we only need to retry one time according to prisma docs:
	// https://www.prisma.io/docs/orm/reference/prisma-client-reference#solution

	return fn()
		.catch(e => e?.code === "P2002" ? fn() : Promise.reject(e))
}

But you can quickly see why this is an issue, it translated into a LOT of queries with the volume of upserts that we deal with. We were getting MANY unique constraint errors, so I believe this additional querying had a big impact on database load.
So, to answer your question rewriting upserts in raw SQL proved most beneficial, but I cannot say the performance gains were unexpected, because Prisma's upsert behavior is indeed well-documented.

I'm coding a different project and it's taking 50~sec in nextjs server rendered pages. I'm close to finish this project so at this point deploying is faster for testing what I did.


[$500]  LHN - Preview for chat with IOUs and messages shows IOU instead of latest message for HT user

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.3.98-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

[User B] Send several messages to User A
[User B] Send a money request to User A
[User A] Pay the request
[User A] Send a few messages
[User A] Send a message to another conversation
[User A] Log out and log back in
[User A] Note that the preview for chat with User B shows the IOU preview instead of the latest chat

Expected Result:
The preview for chat with User B shows the latest chat
Actual Result:
The preview for chat with User B shows the IOU preview instead of the latest chat
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/a9dba0c7-1585-4675-8a81-5e9764a14120
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0110af2e67a6647d0b
Upwork Job ID:<PHONE_NUMBER>527108608
Last Price Increase: 2023-11-19

Issue OwnerCurrent Issue Owner: @getusha

Proposal
Please re-state the problem that we are trying to solve in this issue.
Given:

comments are added to a 1:1 chat after a money request preview
the user navigates to a different report and sends a message
the user logs out and logs back in

The LHN alternate text reflects the payment instead of the latest message.
Reproduction notes:

this occurs on all accounts, not just HT
any report in the LHN with comments after a request preview will exhibit this behavior on sign in, as long as it is not the report that loads (which is why a message needs to be sent in a different report before logging out)
once step 1 above is complete, steps 2 and 3 can be repeated to keep reproducing
the request does not need to be paid to reproduce

What is the root cause of that problem?

When the user logs out, report actions are cleared from the local Onyx store
When logging back in, the OpenApp Onyx command retrieves report actions for all reports in the LHN
The report actions retrieved are limited, and does not include ADDCOMMENT actions
getLastMessageTextForReport() seems to assume the actual last report action is always available
In this case, the last report action returned by OpenApp is the money request preview, so the alternate text reflects that action:
https://github.com/Expensify/App/blob/ffe1c63a57f80479450dcf0e5c2fa82509630c8f/src/libs/OptionsListUtils.js#L391-L400
This behavior was introduced months ago - whether it was a regression or not depends on whether the backend was including the latest report action for each report when OpenApp was called at the time:
https://github.com/Expensify/App/pull/20446/files#diff-733528d957ae6a80eb863637fa5d54278c89c6121998f3574fa8c0aba935daebR385-R387

Once the report with incorrect LHN alternate text is opened, OpenReport is called, all report actions are retrieved, and the correct alternate text shows.
What changes do you think we should make in order to solve the problem?
Ultimately, we have logic that assumes the actual latest report action is available for each report in the LHN. If the backend would ensure the latest visible report action, regardless of type, is included in the OpenApp response, this will be resolved.
What alternative solutions did you explore?
I tried to come to a fitting frontend option, but no matter what we do, without the latest report action from the backend, we're going to have scenarios where the LHN alternate text will change once the report is opened.
A frontend fix will just be a hack that will convolute the already over complicated logic around alternate text, and will likely lead to more bugs down the road. I'd advise against it.

Reviewing https://github.com/Expensify/App/issues/31243#issuecomment-1807061189

@lanitochka17 based on the video attached isn't that the expected behavior?
Because it's opening the recently accessed task.

@getusha  it only happens before the report has been accessed since last login. The LHN alternate text should be consistent and show the same thing whether the report had been accessed since last login or not.

@getusha I responded to your question here, it's an unintentional inconsistency: https://github.com/Expensify/App/issues/31243#issuecomment-1817768348

Thanks @erquhart, i believe this to be something we can fix on the backend, we need to check with internal engineer.
🎀 👀 🎀

@getusha ensuring the newest message for each report is included in theOpenApp response will also fix #31615, and probably other issues too.

Relabeling as Internal

@strepanier03 @getusha it looks like the solution I recommended may have used on the backend, is partial bounty applicable?

@robertjchen - Do you agree with @erquhart on a partial bounty? I'm not comfortable assessing how much of their solution was used and would appreciate a recommended amount from you, if any.
Thanks!

@strepanier03 the performed insightful research into the issue, and it would be definitely be warranted in this case 👍

@robertjchen i think we should raise this to the C+ channel on slack. to discuss the compensation, i haven't seen one for backend change.

@erquhart - We'd like to offer you half bounty, so $250. Sound good?

@strepanier03 absolutely, thank you!

Waiting for backend fix, any updates? @robertjchen 🙇

Not at this time, sorry- re-priortizing given internal nature and existing priorities

Still pending backend changes

@robertjchen any update


Implement the python bindings for the iDynTree to manif conversions

With this PR it will be possible to write the following code in python
import idyntree.swig as idyn
import bipedal_locomotion_framework as blf

rot_idyn = idyn.Rotation.Identity()
trans_idyn = idyn.Transform.Identity()

so3 = blf.conversions.to_manif_rot(rot_idyn)
se3 = blf.conversions.to_manif_pose(trans_idyn)

Maybe it can be good to have tests on this. LGTM anyway

You're right. Here the tests: https://github.com/ami-iit/bipedal-locomotion-framework/pull/610/commits/4a16b5f7cf629fd0490a91a7194cc7af7ab38416


[FEATURE] Your idea goes here

Feature
Adding another way of getting +ORBITALSTRIKE style bonuses. If you get a +INTERRUPTION with a coin punch, the coin goes very high in a straight line upwards, similar to the Knuckleblaster's shockwave.
Usage
An additional way to land Orbital Strikes.
Extras
Maybe adding letting all coins launched a certain distance by explosions/shockwaves to give the +ORBITALSTRIKE bonus?

maybe it could also be cool if you could get the style bonus if you do any type of ricoshot from really high up? I really like to slam storage during cybergrind and shoot coins down from above, and it would be awesome to get style bonuses from that. Obviously that would be pretty overpowered, so maybe it could be an option that would be turned off by default, but that's just a thought.

I see the only way of making this logical-ish is to add a "minimum distance required" for the coin to be orbital. Since coin punching can get the coins pretty far away, they can have a chance of triggering orbital bonuses. Though I doubt about its consistency since the targeted enemy must be far away for the combo to work (or the player must be pretty high, which makes it somewhat consistent)


Hide button vertical offset (sometimes)

Sometimes it happen that the vertical offset of the hide overlay button is offset with respect to the row:

Seems to be caused the by position fixed of the hide container that does not update after something changes the layout of the ToC
edit: Maybe recompute-update fixed position upon hover

It was happening when the ToC had vertical scroll and position of the hide button containers were not re-positioned


400 with createLink view JS File Picker

We are still facing an issue with the JS File Picker v7 when using a OneDrive NOT Business account.
Here is how to reproduce it:

Use createLinkParameters: { type: "view", scope: "anonymous" }, to open the OneDrive file picker modal.
Select a OneDrive NOT Business account
Pick a file
While creating the link, the request fails with a 400 status [actionParameters] The parameter 'scope' in the request payload is not a valid parameter for the operation 'createLink'.

It works fine with a OneDrive Business account.
Hope you will be able to reproduce. (Do not hesitate to ask)
Best,
— Pierre

I am able to reproduce this. Let me see what's going on here.

Hi there, great library! unfortunately i ran into the same problem, any news on this?

This should be resolved now. Please let me know if you continue to have trouble.


swiper steals the focus

I am using ngx-swiper-wrapper in my angular application on the first page. and I am facing with buggy scenario that page loads, and user tries to scroll down, however s/he will end up changing slides. How can I change the configuration to avoid it?
I put the sample site on Google firease

Anybody?

I flipped mousewheel: true to false. It might be the answer.


Normalise lat/lon

Add support to the clean filter for normalising latitude and longitude. Should cover #geo+lat, #geo+lon, and #geo+coord

[x] add unit tests for geo module
[x] add geo module
[x] add unit tests for filter
[x] support in helper method
[x] support in class (maybe add lat/lon parser)
[x] add JSON recipe support
[x] support in command-line util
[x] document in wiki
[x] create Proxy task for follow-up

Added geo module in f47a890cea
Not connected to anything yet, but unit tested. Supports parsing a wide range of lat/lon formats.

Support completed in libhxl. Moving to supporting tasks.

Added HXLStandard/hxl-proxy#186 for HXL Proxy support.


Change the Python API to use Rust

Codecov Report
Attention: 63 lines in your changes are missing coverage. Please review.

Comparison is base (7313cb1) 100.00% compared to head (0492e71) 13.63%.
Report is 5 commits behind head on main.

Files
Patch %
Lines

src/error.rs
0.00%
26 Missing :warning:

src/context.rs
0.00%
19 Missing :warning:

src/runner.rs
5.26%
18 Missing :warning:

Additional details and impacted files
@@             Coverage Diff              @@
##              main      #72       +/-   ##
============================================
- Coverage   100.00%   13.63%   -86.37%
============================================
  Files            4        4
  Lines           95      154       +59
============================================
- Hits            95       21       -74
- Misses           0      133      +133

Flag
Coverage Δ

lang-python
?

lang-rust
13.63% <1.56%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


New Windows titlebar in EAP has two different colors

A slightly lighter blue is showing under file, edit, view etc, different to the rest of the titlebar.

Hi @sfrench87 :wave:, thanks for your contribution :+1:
I guess you're running on Linux or Windows so this is related to the Menu.background UI theme key. It seems like IntelliJ does not distinguish between the unfocused state and when a menu is opened. There is no theme key to explicitly set the background color for unfocused state so this need to be resolved in IntelliJ's UI theme API.
Would be nice if you can open a request in JetBrains YouTrack (bugtracker) so maybe this can be implemented in IntelliJ.

Submitted issue here WEB-39475.

Just wanted to update the fault and say the issue has been marked as fixed but i'm not exactly sure what they have done.

Thanks for the update, have you been able to verify that the fix is working? I guess you need to update to the latest IntelliJ version 2019.2 as well as to the Nord plugin version 0.8.1 to make sure the latest bug fixes are included.

Sorry for not replying sooner, it seems be using the same colour for the whole title bar now.

It the problem this occurring with the latest WebStorm release version? There have been some fixes regarding the window theming on different operating systems in the latest versions.
If it has been fixed please close this issue.


Removing the new parameters before exporting the simtel config file

We added new parameters to the model (particularly camera features that were found only within the camera config file). These parameters cannot be written to the simtel config file, otherwise it doesn't run.

I think I did this in #58, but not sure if in the right place. You can check and if it's OK, close it I guess.

I saw it and it is fine by now. I might move it to somewhere else when working on adapting the class for the new dict structure. But I think we can close this one.


add version to netmaster, netplugin, and netctl

Without versioning it is difficult to know and support a specific build.
It would also be good to include build details, like date, commit-tag, etc.
Opening an issue to track it.

fixed by PR #243


couldn't find "libjpegbither.so"

java.lang.UnsatisfiedLinkError: dalvik.system.PathClassLoader[DexPathList[[zip file "/data/app/com.example.testjpg-1/base.apk"],nativeLibraryDirectories=[/data/app/com.example.testjpg-1/lib/arm64, /data/app/com.example.testjpg-1/base.apk!/lib/arm64-v8a, /vendor/lib64, /system/lib64]]] couldn't find "libjpegbither.so"

Do you use android_studio tools? If so,you should create a directory named "jniLibs" in main and put so files in this dir,otherwise you should edit build.gradle file and the libs DSL statement.Like this:
android {
  ...
    sourceSets {
        main {
            jniLibs.srcDirs = ['libs']
        }
    }
}

@haoxunwang The problem has been going for a long time, the reason is not what you said. This library does not support 64-bit.


scan error

log shwo below:
[WARN] An error occurred with the .NET AssemblyAnalyzer, please see the log for more details.
dependency-check requires dotnet 8.0 core runtime or sdk to be installed to analyze assemblies.
[ERROR] Exception occurred initializing Assembly Analyzer.
[WARN] No lock file exists - this will result in false negatives; please run npm install --package-lock
[WARN] Analyzing /opt/test/sesam/packages/common/package.json - however, the node_modules directory does not exist. Please run npm install prior to running dependency-check
[WARN] No lock file exists - this will result in false negatives; please run npm install --package-lock
[WARN] Unable to find node module: /opt/test/sesam/packages/main/node_modules/nprogress/package.json
[WARN] Unable to find node module: /opt/test/sesam/packages/main/node_modules/qiankun/package.json
[WARN] Unable to find node module: /opt/test/sesam/packages/main/node_modules/vue/package.json
[WARN] Unable to find node module: /opt/test/sesam/packages/main/node_modules/pinia/package.json
[WARN] Unable to find node module: /opt/test/sesam/packages/main/node_modules/vue-router/package.json
[WARN] Unable to find node module: /opt/test/sesam/packages/main/node_modules/element-plus/package.json
[WARN] Unable to find node module<EMAIL_ADDRESS>[WARN] Unable to find node module: /opt/test/sesam/packages/main/node_modules/axios/package.json
[WARN] Unable to find node module: /opt/test/sesam/packages/main/node_modules/vue-i18n/package.json
[WARN] Unable to find node module: /opt/test/sesam/packages/main/node_modules/vite-plugin-svg-icons/package.json
[WARN] Unable to find node module: /opt/test/sesam/packages/main/node_modules/crypto-js/package.json
[WARN] Unable to find node module: /opt/test/sesam/packages/main/node_modules/pinia-plugin-persistedstate/package.json
[WARN] Unable to find node module: /opt/test/sesam/packages/main/node_modules/vue3-cookies/package.json
[WARN] No lock file exists - this will result in false negatives; please run npm install --package-lock
[WARN] Analyzing /opt/test/sesam/packages/vue3Vite/package.json - however, the node_modules directory does not exist. Please run npm install prior to running dependency-check
[WARN] dependency skipped: node module @esbuild/aix-ppc64 seems optional and not installed
[WARN] dependency skipped: node module @esbuild/android-arm seems optional and not installed
[WARN] dependency skipped: node module @esbuild/android-arm64 seems optional and not installed
[WARN] dependency skipped: node module @esbuild/android-x64 seems optional and not installed
[WARN] dependency skipped: node module @esbuild/darwin-arm64 seems optional and not installed
When I perform a scanning task, it prompts that the. net SDK is not installed, but I have already installed it
[root@xxxxxx dotnet]# ./dotnet --version
8.0.404
I have also installed npm and executed npm install
[root@xxxx sesam]# npm install
npm warn EBADENGINE Unsupported engine {
npm warn EBADENGINE   package: '<EMAIL_ADDRESS>npm warn EBADENGINE   required: { node: '8 || 10 || 12 || 14 || 16 || 17' },
npm warn EBADENGINE   current: { node: 'v20.18.1', npm: '10.8.2' }
npm warn EBADENGINE }
up to date in 15s
268 packages are looking for funding
run npm fund for details
May I ask how to solve this problem?

You likely don't have dotnet is the OS path (note how you use ./dotnet in the dotnet installation folder and not simply dotnet in root's home folder.
If you don't have dotnet in the system path you must explicitly configure the dotnet executable location for the assemblyanalyzer to be able to run

on the npm install output you already see what your issue is for the nodejs part of the project: your project's dependencies hard require a lower version of nodejs than the version installed on the system. Either upgrade the project's dependencies to versions that are compatible with nodejs v20 or downgrade the active nodejs on your system to a compatible version.

on the npm install output you already see what your issue is for the nodejs part of the project: your project's dependencies hard require a lower version of nodejs than the version installed on the system. Either upgrade the project's dependencies to versions that are compatible with nodejs v20 or downgrade the active nodejs on your system to a compatible version.

OK，thank you for your help


chore: removed -a shortcut from artifacts commands

Closes #1062

@alexal You are unreal!

I have merged my command that does it so rebase is needed and status command also needs to be covered.

I have merged my command that does it so rebase is needed and status command also needs to be covered.

Done, please take a look.

Docs weren't updated but will do that in next PR


[BUG] port conflict with another fork

Haven't had a chance to try chialite yet but it would appear that the chosen port numbers conflict with the goji fork of chia. Looks like you both subtracted by 1000 from the original port numbers. Many of us who are farming the forks are farming multiple forks. Keeping the port numbers from conflicting should help avoid difficult to track down bug reports.

Haven't had a chance to try chialite yet but it would appear that the chosen port numbers conflict with the goji fork of chia. Looks like you both subtracted by 1000 from the original port numbers. Many of us who are farming the forks are farming multiple forks. Keeping the port numbers from conflicting should help avoid difficult to track down bug reports.

This network is incomplete I tried changing the port. But mainnet server and dns introducer are not working yet. Looks like it takes time to perfect! Gui is having problems with not being able to build on windows!


Files size

Files size from latest release zip is different than raw github revive.js and editor.js
Manually installing card (copy paste from raw github) is working as expected. Used this guide.
Using hacs is not working as expected. It takes the files, but different size. Editor does not show correctly in browser.

Apologies for this, I have checked and it looks like something happened when the merge was committed from the branch to the master.
This should now be resolved.


version do not accept minus sign (like 1.2.3-SNAPSHOOT)

don't know if it is real issue but now other tool accept "-" in version (maven, gradle, ...)

ok i understand why now !
in rpm specifications : " The only restriction placed on the version is that it cannot contain a dash "-""
issue can be closed


Verify code with #if condition (comma error)

see https://gccode.ssc-spc.gc.ca/iitb-dgiit/nw-ws/sgdc-cdts/-/issues/152

Not an issue anymore since SSI statements have been removed from the samples.

Not an issue anymore since SSI statements have been removed from the samples.


Macro errors in Cockpit Portal, again something with a expired JWT

See below screenshot from the cockpit-demo: https://cockpit-demo.aydo2.com/home

cannot reproduce

duplicate
#102

@zaibon just updated the Moehaha Cockpit => again the JWT problem ////

@yveskerwyn  Did you update the portal?

Yes and just did it again, same result:
ERROR: Could not execute macro vmgauge on home, error in macro. Error was:
Traceback (most recent call last):
File "/usr/local/lib/python3.5/dist-packages/JumpScale/portal/portal/MacroExecutor.py", line 312, in executeMacroOnContent
paramsExtra=paramsExtra, cmdstr=cmdstr, requestContext=ctx, content=content, page=page)
File "/opt/jumpscale8//lib/JumpScale/tools/taskletengine/TaskletEngine.py", line 115, in executeV2
return self.taskletEngines[groupname].executeV2(**args)
File "/opt/jumpscale8//lib/JumpScale/tools/taskletengine/TaskletEngine.py", line 254, in executeV2
params = tasklet.checkExecuteV2(args, params, tags)
File "/opt/jumpscale8//lib/JumpScale/tools/taskletengine/TaskletEngine.py", line 57, in checkExecuteV2
params = self.module.main(j, args, params, tags, self)
File "/optvar/cfg/portals/main/base/Cockpit/.macros/wiki/vmgauge/1_vmgauge.py", line 9, in main
[running.append(len(dockerhosts)) for dockerhosts in j.apps.system.atyourservice.listServices(role='dockerhost', ctx=args.requestContext).values()]
File "/optvar/cfg/portals/portalbase/system/system__atyourservice/methodclass/system_atyourservice.py", line 101, in listServices
cl = self.get_client(**kwargs)
File "/optvar/cfg/portals/portalbase/system/system__atyourservice/methodclass/system_atyourservice.py", line 32, in get_client
token = j.apps.system.oauthtoken.generateJwtToken(scope='', audience='', **kwargs)
File "/optvar/cfg/portals/portalbase/system/system__oauthtoken/methodclass/system_oauthtoken.py", line 50, in generateJwtToken
decoded = jwt.decode(resp.text, verify=False)
AttributeError: 'JWTToken' object has no attribute 'decode'

It's not the same error. It's a bug in the new code. I just fix it in https://github.com/Jumpscale/jumpscale_portal8/commit/55592bcfeb9d1a9da59781c72f61f6045daed5d9
Please update portal again and let me know if there is still an issue

Yep solved, tx.


Add option to force a page break

If the cursor is at the top of the page or column, the page break macro is ignored. Add an option named force to force it be used.
[%force]
<<<

This will make it easier to create empty pages when desired.

I wonder if the option should be named always instead of force to match the terminology used in the theme.


Independent Themes For Jupyter Notebooks

Please can we get a feature where we can apply an independent colouring theme only for ipynb files. I feel these types of files need to have a daytime theme to render the graphs and pictures more appropriately when conducting data science work versus normal .py files which I prefer to write in dark mode.

Looks like a duplicate of #20652

In which case this can be deleted.
From: John Murray @.>
Date: Friday, 16 December 2022 at 13:48
To: microsoft/vscode @.>
Cc: Alwin Raju @.>, Author @.>
Subject: Re: [microsoft/vscode] Independent Themes For Jupyter Notebooks (Issue #169334)
Looks like a duplicate of #20652https://github.com/microsoft/vscode/issues/20652
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/vscode/issues/169334#issuecomment-1354806035, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIFIPZL6V372SXWPISQQUQ3WNRXJDANCNFSM6AAAAAATAH2KPM.
You are receiving this because you authored the thread.Message ID: @.***>

/duplicate

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!


Add *_sorted variants of symbolization APIs

We should add *_sorted variants similar to what we have for the address normalization APIs
https://github.com/libbpf/blazesym/blob/21498b6667d13a8784488ece8e57a5ab66717c3c/src/normalize/normalizer.rs#L358-L378
to the symbolization logic here:
https://github.com/libbpf/blazesym/blob/21498b6667d13a8784488ece8e57a5ab66717c3c/src/symbolize/symbolizer.rs#L208-L210
That would mean introducing and implementing such a new function, adding tests, and exposing it through C bindings.

I'd like to look into this.

I'd like to look into this.

Awesome! Please let me know if you have any questions.

@tarunsamanta2k20 do you need any help with this task?

Let me do it.

Let me check once.

I looked at this and while it's certainly possible to implement and conceptually makes sense, in reality the performance benefit is probably miniscule, given that symbolization itself is not cheap and sorting a few addresses is unlikely to move the needle. And it really only provides a benefit for process symbolization anyway. Let's put this task on hold until we have a true need, given the anticipated increase in code complexity.


Chore/393

ref

This works with the in-app back button but I suspect if we do this we'll get an issue posted very soon that the Android device back button and iOS back swipe gesture don't have the same behaviour.
Does it work to use navigation.reset on the alert card onPress, reseting navigation to a state where the My COVID Alert root is the previous page in the history?

@AlanSl good point, let me try do that!

@AlanSl @floridemai solved using the navigation.reset

It's not working for me: back brings me back to the previous screen. Hopefully I get to ticket right and it should go to My Covid Alerts. RPReplay_Final1599815114.MP4.zip.
I think a solution whee you push my covid alert and covid alert screen (in that order) is something to try at least.

In that case it might be more robust to have the navigation.reset as the navigation to the screen (on the alert card and on handling the notification) rather than in the screen's own useEffect

@AlanSl I debugged this with Paul, looks like an iOS specific issue with the navigation.reset. We decided to keep my initial implementation for ios which fixes it on using the in app back button(the native slide will work too in most of the cases) and the useEffect implementation together. We will come back to this when we have more time to dig deeper.


Use Loom Network (layer 2)

Part 1 (loom only): https://github.com/marcelomorgado/fyght/pull/194
Part 2 (token transaction between chains): WIP


fix(http): encode Route::SearchGuildMembers query

Closes: #1570

I quickly looked over the routes which take a user generated string in a GET route, I wasn't able to find another one, but it's possible that I have missed one.

I don't see any others either.


Update TS guess generation notebook to fix a glitch related to atom mapping

Description
Previous atom indexing did not account for edge cases where SMILES strings may have a number in the string to indicate connectivity (but not atom index). This change updates all atom mapping functions to handle those cases.
Example: [C:0]([C:1]([C:2]([C:3]([Br:4])([H:22])[H:23])([H:20])[H:21])([H:18])[H:19])([H:15])([H:16])[H:17].[c:5]1([H:24])[c:6]([H:25])[c:7]([S-:8])[c:9]([H:26])[c:10]([H:27])[c:11]1[N+:12](=[O:13])[O-:14]>>[C:0]([C:1]([C:2]([C:3]([S:8][c:7]1[c:6]([H:25])[c:5]([H:24])[c:11]([N+:12](=[O:13])[O-:14])[c:10]([H:27])[c:9]1[H:26])([H:22])[H:23])([H:20])[H:21])([H:18])[H:19])([H:15])([H:16])[H:17].[Br-:4]
note that [c:11]1  has a "1" that indicates connectivity, for example. Previously this would throw an error, but the code is now resilient to these and can detect these.
Also updated the unit tests to check for these cases.

Codecov Report

Merging #7 (e8085c6) into main (a9d156c) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files


lib: init ansi module

The lib.ansi module provides a basic set of ANSI escape sequences to colorize and style text. The main purpose is to colorize trace messages (warnings, errors).
Description of changes
Add lib.ansi.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Ping @SuperSandro2000 @Lassulus

Generally I think it would be okay to have this, though I'd like to know more about what motivated this and the use cases.

I'm thinking of two use cases:
Styled trace messages

Styled shell scripts

For the latter, the best current alternative is to use pkgs.ansi:

I think, having lib.ansi, is a better approach. Limiting the functionality to basic colors and basic style attributes should be more than enough for now. I have no strong opinion regarding the background color, but it's a simple win and people might want to use it.

Any update, @infinisil @edolstra ?

I'm not a fan of the use case for shell scripts. Nix is really not a general purpose language. It's slow, hard to test and hard to document. If something can be done with something other than Nix, that should be preferred.
If the bash code is too hard to read, you can also create functions to make it easier, just like Nix:
warnMsg() {
  echo -en "$(ansi yellow)$(ansi bold)WARN$(ansi reset): "
}

echo "$(warnMsg "WARN"): <some warning>"

You can even put that in a separate file or package for re-usability.
Alternatively you can use any other language than bash, which can have even more convenient ways of doing that.

I can see the use case for Nix error traces/messages though. There's no way around using Nix for that, and it could make the output nicer. I'm not sure if that's worth it though, I'm guessing that's not your main use case.

Any update? @infinisil

I rebased it and removed the background color support, @infinisil