Crash on empty git repo

$ cargo install zee
....
$ cargo new anynewproject
     Created binary (application) `anynewproject` package
$ zee anynewproject/src/main.rs
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Error { code: -9, klass: 4, message: "reference 'refs/heads/master' not found" }', /home/tommy/.cargo.x86_64-linux/registry/src/github.com-1ecc6299db9ec823/zee-0.1.2/src/components/buffer.rs:529:67
               note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
                                                                                Aborted (core dumped)

Thank you for checking out zee and for the bug report. I was carelessly unwrapping assuming there exist some refs in a repo, I've just pushed a fix to correctly handle empty repos.

(Completely OT: I was disappointed to find Ctrl-t didn't transpose the two chars as in Emacs).

:+1: Absolutely, feeling at home with default Emacs bindings is a main goal of the project. It's just a consequence of not using C-t myself in Emacs, but learnt something new today! I will implement the change -- also hopding to systematically implement all basic text editing commands from Emacs + macros (with same default bindings) longer term

Awesome, thanks.  I have 35 years of emacs muscle memory and it’s jarring to be ripped out of the zone when suddenly things behave differently:)
Also OT: is it possible to reclaim the bottom two lines and only show them on demand (like when a prompt is needed)?

I apologize my Rust-fu is weak and I apparently don't know how to install from git.  Plain cargo install --path . doesn't work running it from within core gets me a binary that say
Error: X11ClipboardError: XCB connection error: ClosedParseErr

Caused by:
    0: XCB connection error: ClosedParseErr
    1: Connection closed, error during parsing display string

which surprised me a great deal.

Plain cargo install --path . doesn't work and running it from within core gets me a binary that say

It's a cargo workspace, so you need to cd to core like you already do :+1:

Error: X11ClipboardError: XCB connection error: ClosedParseErr

Ah, so zee does try to integrate with the system's clipboard, cross platform, using crossclip.  This is gated under feature system-clipboard which is enabled by default though (for X11 on Linux you need extra dependencies xorg-dev libxcb-shape0-dev libxcb-xfixes0-dev). Could you try without that feature?
cargo install --no-default-features --path .

Integrating with the system's clipboard on Linux X or Wayloand, Mac and Windows has been really painful so far..

Ok, that works.
Now when I exit Zee I get
                 diff:thread 'main' panicked at 'tried drawing while the app is exiting', /home/tommy/.cargo.aarch64-linux/registry/src/github.com-1ecc6299db9ec823/zi-0.2.0/src/app.rs:223:17                            master     0: 0  Top ▇
                                                                      note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
                           Aborted (core dumped)

This is 100% reproducible:
$ cd zee/core
$ zee src/undo.rs
^x ^c
Here's with a backtrace:
                 diff:thread 'main' panicked at 'tried drawing while the app is exiting', /home/tommy/.cargo.aarch64-linux/registry/src/github.com-1ecc6299db9ec823/zi-0.2.0/src/app.rs:223:17                            master     0: 0  Top ▇                                                                      stack backtrace:
                                                                                0: rust_begin_unwind
                                                                                at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/std/src/panicking.rs:498:5
                                                                                1: core::panicking::panic_fmt
                                                                                at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/core/src/panicking.rs:116:14
                                                                                2: zi_term::Crossterm<PainterT>::run_event_loop
                                3: zee::start_editor
                                                       4: zee::main
                                                                   note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
                                  Aborted (core dumped)

PS: I noticed that 'Ctrl-U' and 'Meta->' etc aren't working

Sorry for the delay in getting back to you on this, I've been away. Indeed, this was a bug in the underlying library zi that I refactored out to deal with low level rendering to the terminal -- you can check out the commits if interested. master branch was a bit in flux migrating fully to zi. The recent interest spurred me in wrapping up that transition. I've also just published a new version 0.2 as it addresses most of the existing issues (as well as a range of other known problems).
I've also changed cycling through the themes to be bound to C-x C-t to leave C-t swap characters like it does in Emacs. (and laid the foundations for making bindings configurable and commands extensible).
I am working on improving documentation, build instructions, creating a website and a tutorial. But once that's done, I'll priortise reproducing most of the core text editing bindings from Emacs.

Thanks, I’ll test some more and give feedback. Let’s close this now and I can reopen another as needed.


Round 4 of JUnit test refactorings

This refactors the last of the tests using the old JUnitMultiVersionTest and removes its infrastructure.

@bot-gradle test this

I've triggered the following builds for you:

PullRequestFeedback build

Will there be a round 5 PR to refactor tests using JUNIT_VINTAGE_JUPITER?

Yes, I've got another PR ready that reorganizes a bunch of this stuff and refactors one of these tests.  Then I have another set of changes staged that adjusts some of the coverage versions, groups, etc and as part of it refactors the other tests that use JUNIT_VINTAGE_JUPITER.

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

I've triggered a build for you.

@bot-gradle test and merge

I've triggered a build for you.


Why are deployment errors not shown through the UI?

Use Case: Using Portainer at Home in Core OS virtualized with my own app templates. Followed this guide: https://www.portainer.io/blog/from-zero-to-production-with-fedora-coreos-portainer-and-wordpress-in-7-easy-steps
Have you reviewed our technical documentation and knowledge base? Yes
Question:
Many times when deploying a container through the UI, a failure is just reported as a:

Failure
Request failed with status code 500

The response is shown in the Network tab of the browser as JSON but not on the UI.
Why is that? Can it not be shown in the error popup that appears?
Took me a while to understand that an actual error appeared, I could not find relevant info on portainer docs and other people on reddit had the same issue.

@UnconventionalMindset
Can you share a screenshot of the JSON error?
Thanks

@UnconventionalMindset
Thanks for that.
We have some engineering work in the pipeline to improve logging in general across the board. I'll add this into it for consideration.


[FEATURE] Recover index should have historical data

Is your feature request related to a problem?
Recover index should have historical data.
For example
[EMR AppId1 JobId1 StartTime EndTime]
What solution would you like?
A clear and concise description of what you want to happen.
What alternatives have you considered?
A clear and concise description of any alternative solutions or features you've considered.
Do you have any additional context?
Add any other context or screenshots about the feature request here.

[Catch All Triage - 1, 2, 3, 4]


Customize

Do you think it is a good idea to add renderTab prop to allow custom Tab bar?
I can make a pull

You can already customize every component in the TabBar.
<Scene key="main" tabs={true} component={TabBar}>
  <Scene key="showings" component={ShowingsList} title="Showings" icon={TabIcon} iconName="calendar" />
</Scene>

I want to custom tabbar itself not tabIcon because I want to use TouchNativeFeedback instead of TouchOpacity in react-native-tab.

Please see the first line, you can pass a component to the scene with tabs={true}. I would suggest using the TabBar in this component as a start, and edit from there.

yeah I tried and it works for most cases, but just not mine. Just want to add an option to not depend on another library.

Well, to be fair the tab library is the same maintainer as this library.
But if you don't want to use it you won't need to. You have full control over that component as it just reads the navigation state to decide what to do. I personally overwrote mine to hide it when the user is logged out.

I will change it in my fork then.
Thanks 😄

how can the tab text (which is key by default) can be changed or removed.


New term request:PM-WK

https://www.cellosaurus.org/CVCL_A665
17308088

Thank you for the suggestion; I was under the impression that each term might be allocated to a person, and sometimes there might be discussions - so chose to request separately.
For the future requests, I will bundle up. Just thought of letting you know that I have list of >1500 cell lines to clean up. I feel it is ongoing process, as I can’t clean them in one go. I will try to bundle my requests as much as possible.
Thanks again!
Best regards,
Kalpana

On 4 Jul 2023, at 2:29 pm, Christian-Alexander Dudek @.***> wrote:
Hi @kalpanaps https://github.com/kalpanaps, thank you for your contributions. Just wanted to let you know, that it would make sense to bundle your requests, since we'll be posting them together anyway.
—
Reply to this email directly, view it on GitHub https://github.com/BRENDA-Enzymes/BTO/issues/41#issuecomment-1620256015, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMIO24O3QNMRLFIJORI6JRDXOQLCTANCNFSM6AAAAAAZ5LN4EY.
You are receiving this because you were mentioned.


Install npm as per engines.npm

DO NOT LAND YET. This should land after the beta runtime builder becomes the default.
If the package.json specifies an engines.npm field, fetch and install that version of npm.

This PR has been replaced with PR #127.


Allow user to specify cluster name during creation

Allow the user to specify the name makes it easier to work with Flynn post-creation, especially if you have multiple clusters. Just one example:
> flynn -c prod apps

vs.

> flynn -c flynn-1234567 apps

I know I can create an environment variable in .bashrc, which is what I'm currently doing. But that doesn't help other engineers.
This change would also reduce the opportunities for mistakes. Is flynn-1234567 production or is flynn-1234576?

@tjboring You can change the name of the cluster (as seen by the flynn cmd) in your flynnrc file.

@jvatic OK, so the cluster-name argument to the flynn cluster add command is free-form; it's not validated against anything. Correct?
So, changing the name in .flynnrc is a short-term workaround. That said, I still think it'd be worthwhile if the cluster name could be specified by the user at cluster creation time. Here are some issues I see with this (which I probably should have outlined earlier):

I create a new cluster; flynn install assigns it name flynn-1234567
I change my .flynnrc file so the cluster name is dev
I tell our other 9 engineers to use the name dev when they do flynn cluster add on their machines
Another engineer goes to look at our machines in AWS and all they see is flynn-1234567

Is there a technical reason why the cluster name can't be specified by the user at creation time?

@tjboring There's no technical reason why you can't give a name before creation within the flynn install app.


importHelpers documented twice

https://www.typescriptlang.org/tsconfig documents twice importHelpers: once under “Project options” and once under “Advanced”.  All other options are documented only once.

@orta I confirmed ths issue fixed in latest https://www.typescriptlang.org/tsconfig.
I think this issue fixed by https://github.com/microsoft/TypeScript-Website/commit/b72ff9cdc6d3424edc91054485026606bd9da91d and Could you close?


feat: More flexible interval output. Add settings.

Thanks for the useful plugin. I added some features to allow more fine-grained control of the interval display.
Allow showing time intervals other than days:

Also settings to control output:

Note: Only lightly tested, but appears to work. I'm assuming the date format is consistent even with different localization settings. If that's not true, the time parsing part will probably fail.

Seems reasonable, I agree it's probably not all that useful. I've removed it.


feat(DropdownMenu, Popover): Using asChild on Trigger components no longer clones style to child

resolves #1794
BREAKING CHANGE: DropdownMenu.Trigger & Popover.Trigger no longer clone style to child on asChild

Reverted changes on hos Slot vs default component is used in Trigger components
Updated DropdownMenu stories to use asChild
Updated Box stories to use asChild

We should probably do this for ModalTrigger as well

We should probably do this for ModalTrigger as well

Done ✅

We should probably do this for ModalTrigger as well

Done ✅

Looks good, approve still stands 😄


output.outputFileName from project's build.gradle is ignored

I have a script which automatically upload my release build. But I need a custom name for release apk. So it edited my build.gradle as mentioned below. But flutter build doesn't respect that and always produce the apk named app-release.apk
Steps to Reproduce

Configure your build.gradle file as I did.
Try to build apk from the Build->Flutter->APK (and not by OPEN FOR EDITING IN AS and building there)

buildTypes {
        release {
            minifyEnabled true
            shrinkResources true
            proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
            file(rootProject.file('key.properties')).with { propFile ->
                if (propFile.canRead()) {
                    signingConfig signingConfigs.release
                }
            }

            applicationVariants.all { variant ->
                variant.outputs.all { output ->
                    output.outputFileName = "my-custom-name.apk"
                }
            }
        }
    }

Expected results:
The name of output file should be  my-custom-name.apk
Actual results:
It always release file named app-release.apk

Hi @ProblematicDude
app-release.apk is the default APK name, custom output.outputFileName is probably not supported
Similarly output.versionCodeOverride is also ignored in https://github.com/flutter/flutter/issues/62005

This is weird behavior.  At least things should be consistent. Follow everything or don't follow everything at all.
This one worked fine but not the above one.
debug{
            applicationIdSuffix ".dev"
        }

And I wasted 2 hours scratching my hairs , WHAT WENT WRONG. In the above case. Btw thanks for letting me know  :)

@blasten

The APK was generated:
$ ls -la build/app/outputs/apk/debug/
my-custom-name.apk    output-metadata.json

We generate an additional APK under build/app/outputs/flutter-apk, so the tool has a consistent location where to find it.


Callback instead of

This library only works with the ml way of writing classifiers.
I think we should allow any type of classifier to be used without having to write an adapter for each one.
I suggest using callbacks that take the test and train sets and expects the labels to be returned.
CV.leavePOut(dataSet, labels,  5, function(trainSet, trainLabels, testSet) {
    return myClassifierIsJustAFunction(trainSet, trainLabels, testSet);
});

#5


Adapt Crystal-GFN experiment config file to Evaluator

This PR updates the config files of the Crystal-GFN experiments to match the changes from the introduction of the Evaluator. This should have been done ideally in PR https://github.com/alexhernandezgarcia/gflownet/pull/320. Additional updates might be needed.
This PR only changes configuration files (related to the Crystal-GFN).

I will not request a review and bypass the branch protection since this is a pretty simple PR and tests are passed. In the worst case scenario, the required changes to the config files will be incomplete.


STOR-2012: Rebase to upstream v1.14.2 for OCP 4.18

Issue link:
https://issues.redhat.com/browse/STOR-2012
Diff to upstream v1.14.2:
https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/compare/v1.14.2...dfajmon:rebase-v1.14.2
Changes between v1.14.1 (OCP 4.18) and v1.14.2 (OCP 4.18):

https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/pull/1790

Full changelogs:
https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/releases/tag/v1.14.2
@openshift/storage

/lgtm
/approve
/label px-approved
/label docs-approved

/label qe-approved
/label cherry-pick-approved


data: SageKyle

update LinkFree profile by adding a milestones section
Note to reviewers
I changed the entire data because I used a JSON formater/validator to format the entire data before copying/pasting the formatted data.

LGTM


[woff2] fix for static linking and alternative compiler toolchains

This PR fixes static linking with the brotli port and fixes building woff2 with alternate compiler toolchains
Firstly, this change teaches the woff2 CMake configuration to understand vcpkg's custom unofficial-brotli pkg-config configuration in order to support static linking. This fixes a build failure on x64-osx, x64-linux triplet or other triplets when VCPKG_LIBRARY_LINKAGE is set to static.
Secondly, the CANONICAL_PREFIXES option for the woff2 CMake configuration has been changed to be on by default, otherwise
custom triplets or toolchains using alternate compilers such as Clang/LLVM or other versions of GCC will fail. Leaving CANONICAL_PREFIXES set to OFF causes -no-canonical-prefixes to be passed to the compiler, which prevents symlinked compiler toolchains from working correctly. If a user does actually need non-canonical prefixes, chances are they will have a custom triplet or toolchain file that passes in -no-canonical-prefixes as a CFLAG for every port, and so setting it to ON here is a better default for vcpkg.
EDIT: One other change I forgot to mention is that this specifies the BUNDLE DESTINATION parameter when calling install in CMakeLists.txt, setting it to the same path as the RUNTIME DESTINATION. The BUNDLE DESTINATION parameter is required for this to build on iOS and in some cases macOS, and does not affect other platforms.
Triplets fixed by this PR:
arm-ios
arm-linux
arm64-ios
arm64-linux
arm64-mingw-static
arm64-osx
arm64-windows-static
ppc64le-linux
s390x-linux
wasm32-emscripten
x64-ios
x64-openbsd
x64-osx
x64-linux
x64-mingw-static
x64-windows-static
x86-mingw-static
x86-windows-static
x86-windows-static-md

Sorry, I'm not sure what to do to get x86_windows Validate version files build step to pass in this case. Running the recommended command vcpkg x-add-version --all doesn't change any of the version files. Looking at versions/w-/woff2.json, I don't see anything off, but I must be missing something. Any ideas? Thanks!

strange that you have fixed many triplets but no changes are required in ci.baseline.txt
is woff2 not tested in CI?

strange that you have fixed many triplets but no changes are required in ci.baseline.txt
is woff2 not tested in CI?

Good question. Looking at ci.baseline.txt, I see:
woff2:x64-linux=fail
woff2:x64-osx=fail
woff2:x64-windows-static=fail
woff2:x64-windows-static-md=fail

Should I remove them from that file and submit it?

the system should have already told you...
please check in ci logs that the checks are performed. i will also check it later

@cenit @JonLiu1993

the system should have already told you...
please check in ci logs that the checks are performed. i will also check it later

Done! Should just b e the stalled x64_osx CI build holding things up now.

Please remake the patch file.

@jwtowner Seems you revert my suggestion?

@jwtowner Seems you revert my suggestion?

Sorry, botched patch regenertion somehow, trying again.

@BillyONeal is CI system not triggering "FIXED, REMOVE FROM FAILING" in the PR pipeline anymore?

@BillyONeal is CI system not triggering "FIXED, REMOVE FROM FAILING" in the PR pipeline anymore?

Correct; we did this to remove the need to have tombstones be a concept when binary caching was productized; instead we build everything every night now and someone is supposed to look at those and fix them regularly.

Correct; we did this to remove the need to have tombstones be a concept when binary caching was productized; instead we build everything every night now and someone is supposed to look at those and fix them regularly.

ok looks reasonable. But why is not the Support manifest tag treated the same way? If a port is ever going to be fixed, CI will never notice it automatically, always skipping it and leaving the burden on the author (which I am sure will forget it)


[CSS][HTML]  tag container is limited to browser viewport size.

The  semantic.css file limits a document's < html > tag container size to a user's browser viewport size. This causes page elements to spill outside of the < html > tag container when the total page content is larger than the viewport.
The issue can be observed by editing the following snippet in semantic.css from this:
/*******************************
             Page
*******************************/

html,
body {
  height: 100%;
}

to this:
/*******************************
             Page
*******************************/

html,
body {
  height: 100%;

  border-width: 2px;
  border-style: solid;
  border-color: red;
}

My suggestion for a fix is that the original snippet be replaced with:
/*******************************
             Page
*******************************/

html,
body {
  min-height: 100%;
}

Replacing height: 100% with min-height: 100% ensures the < html > tag container is always at least as big as the viewport without limiting its size in the case of longer, scrollable pages.

Hi @josedarioxyz, could you please provide a test case as per our contributing guidelines? You can fork this JSFiddle.


Add an option to hide 'previous' and 'next' buttons

It would be nice if there would be any config option to hide the previous and next buttons in the html output. I really don't like to have this buttons, but the only way seems to be a custom template. But I would like to work with the default theme, to keep it working on updates of daux.io.
For example:
{
  "html": {
    "jump_buttons": false
  }
}

Thank you!

Good for me :)

Thank you!

Is there a plan, when you will create a new release, so I could install this feature directly with composer?

I will try to make the release before the end of the week, in the meantime, you can directly install the master branch with composer with composer require justinwalsh/daux.io dev-master (with or without global, depends on how you install it)

Sounds great, I can wait until then! Thanks! ;)


Add rp-pico local initialized resources example

bors merge

@AfoHT I'm a bit confused. What is the "Ensure that 'depandabot.yml' is up to date (pull_request)" check doing? I don't see any changes to that file in either of the commits for this PR? Was there a change to dependabot.yml recently that may require these changes to be rebased?

Hello, I was a bit confused there too, and yes that dependabot.yml was introduced yesterday. :)
I took the liberty to rebase now, let's see how that goes


Add reactor time to stdout summaries

@opotowsky, @john-science - As I am looking at the open PR, I'm wondering now if we should also add anything about the reactors current "time" in the simulation as well. Cycle and Time node are great, but deciphering the cycle and node relationship to time step and cycle length could be helpful to users. @keckler I'm curious if this would helpful for you in multi cycle benchmarks like FFTF and EBR-II.
Originally posted by @jakehader in https://github.com/terrapower/armi/issues/1748#issuecomment-2210954513

I migrated this comment here so that it didn't get lost when #1748 was closed.
I agree with the suggestion above.
I would also propose that the cycle name gets added to the stdout summaries at each time node. With the detailed cycle histories, users are now able to enter a cycle name. Real reactors typically give their cycles names, and those are useful when searching through the results.

@opotowsky I know you just merged a PR with a vaguely similar goal.  Do you have any thoughts here, before I plow ahead?

@john-science yes the comment above came from that PR review. Chris seeks to extend that work, and I agree it's a great idea! Go for it!


Conduct interviews with industry

It's time to conduct interviews with industry operators! This card can stay in progress until this sprint's interviews are completed.
Acceptance criteria:

[x] Obtain User Engagement Consent Form
[x] Conduct interviews

Thank you @jaimiebutton. This was fascinating and so insightful to learn how industry is using/not using the data and information.


Consider using proxy types instead of undefined in some places

As I've been working more with Tupleable, etc, I've realized some differences (and potential pitfalls) of using undefined :: a instead of Proxy @a (or Proxy :: Proxy a for GHC < 8):
Unlike Proxy, undefined masquerades as a value of type a. If your API doesn't touch this value, then, of course,  you're fine. However, if you have any available constraints on a, then all of those type-class methods will work. For example, Tupleable a has NFData a and Binary a, which means the implementation of Tupleable can use methods of these classes, possibly inadvertently.
The benefit of a proxy type here is that you simply can't implement any of this incorrectly, because you never actually get a value of type a.
class Tupleable a where
  toAttributes :: proxy a -> [Attribute]
  ...

-- call-sight
toAttributes (Proxy @MyRecord)

It helps to know that you can make a type variable available in the body of a function using -XScopedTypeVariables and forall.

I thought I'd bring this up now as the API is still young.

I took a stab at this, but there is actually one case where the the value is essential for constructing the atom type: relations as atoms. Since relations have a type, that type is reflected back into the AtomType. Relations carry their types around as a set of attributes.
So, in order to replace the type-based APIs with proxies, we would have to drop support for relations as Atomable. I don't necessarily object to this if it improves the API, but it seems rather arbitrary. What do you think?

I've just started exploring project-m36, and was a bit irked by the undefined usage too.
I think there is a problem with the API of relations being Atomable.
For everything other than relations you have toAtomType being essentially a type-driven function, which is why you usually pass undefined. You don't want the AtomType corresponding to the value 12.0, but to the type Double. Indeed if the AtomType did depend on the value, then toAtomType wouldn't be particularly useful, because the expected pattern is that you can call it once before you have any values and get an AtomType that's useful for all values of that type.
But relations are dynamically typed, so there's no mapping from the Haskell type system to the database type system. So you have to use the Atomable functions with a completely different pattern; rather than the Haskell type determining the AtomType, you need to construct a Relation to indicate what the desired AtomType is (where I suppose an empty relation can stand in as a "type object").
It feels a bit fragile that for most types you're expected to pass undefined (and often won't have a sensible value to pass even if you didn't want to use undefined), but for Relation you must not pass undefined. It makes it difficult to write client code polymorphic in an Atomable type; how do you know which usage pattern you're supposed to be following?
To me it does hint that the way relations are "atomable" isn't really the same as the way that everything else is "atomable". My suggestion would be to to declare that Atomable is the class of Haskell types that uniquely determine an AtomType, and therefore Relation shouldn't have an instance. You could either have another class for "dynamically-typed" Haskell types (where you need more information than the type to know what the AtomType is; could be theoretically useful for other things like aeson?), or just standalone functions for embedding relations as atoms.
I don't really have enough usage experience yet to know whether the loss of Atomable Relation would be a pain though; it would mean the polymorphic instances like Atomable a => Atomable (Maybe a)  wouldn't apply to Relation, for example. Do things like Maybe Relation, [Relation], etc, arise naturally in practice?
Although I just had a look at the code for the polymorphic instances, and it looks like they all pass undefined to the underlying instance, which means as it stands they in fact wouldn't work with Relation! (That's what I was talking about when I referred to it being difficult to write Atomable-polymorphic code earlier)

A much more radical alternative would be to use a HList-like approach to make the Haskell type of relations reflect their database type. I imagine that would be a fairly huge overhaul though!


Set preferUnplugged to true

When using Yarn, the package is installed through Yarn PnP. This causes it to be stored in a zip, using either virtual folders or a zip filesystem. Because this is a compiled wasm plugin, and swc does not have support for loading plugins from the zipfs, the plugin fails to load when used with an obscured error.
The local workaround was to use yarn unplug which saves a dependenciesMeta field to the project package.json, but that is obviously not ideal, considering the plugin shouldn't work in any cases in which it uses PnP and it should be unplugged by default.
See https://yarnpkg.com/configuration/manifest#preferUnplugged for the docs on this package.json property.

LGTM


Contract test - additional properties

"additionalProperties: false" is powerful OpenAPI property, since it allows you to specify if your API has an evolving response or fixed response, when it comes to the properties documented.
This feature would allow Portman to inject/overwrite the "additionalProperties" setting for the response object, which is using in the Schema validation of a response.
Proposal:
     {
        "openApiOperation": "*::/crm/*",
        "schemaValidation": {
          "enabled": true,
          "additionalProperties": false
        }
      }

I would like this and should have raised a request here shouldn't I ;-)

Thanks for the suggestion, @savage-alex!

And yes @savage-alex - this is the place ;)

@savage-alex We have a PR in the making for providing the contract test extension for the JSON Schema validation.
Depending on the review & feedback, this will refined to make it part of one of the upcoming releases.

@AliKhalili is our Portman Expert. I will review with him. thanks all!

@thim81 I have tested it using the above setting and its not picking up additionalProperties I have included. Did you want a short call to discuss?

@savage-alex How did you test it?
We only just released the feature in Portman 1.13, so if you were testing it with the previous version, it is most-likely that the additionalProperties was not accepted by Portman.

hey I tested it by de-bugging the PR. I can see the additionalProperties is injected in postman just fine:

What I cannot work out is why it is flagging a response as having additional properties when it matches the schema

Ignore me. It was an actual additional property!! Works great

@savage-alex Are you OK, that we close the issue?

Please do.

Closing the issue, since the feature has landed in Portman version 1.13.


Question about DDPM: Meaning of L_{0} (in loss) , and how it gets simplified into L_{simple}?

What does the last term of the loss, -log p(x_0 | x_1) mean? It seems similar to the the log-likelihood of a single data point from VAE's ELBO.  It that's what it is, I'm puzzled how to interpret the conditional, | x_1.
Also, the paper's authors mention that this L_{0} term is included in the L_{simple} loss that they used, saying:

The t = 1 case corresponds to L0 with the integral in the discrete decoder definition (13) approximated by the Gaussian probability density function times the bin width, ignoring σ21 and edge effects.

How does this correspondence work?

The last term of loss $-log p(x_0 | x_1)$ is exactly the reconstruction term from the VAE, though showing up with slightly different contexts. Assuming we are approximating the dataset $x0 \sim p(x_0)$. Recall that  the final optimization objective of a VAE is composed of two terms, one is the KL divergence between the latent prior $p(z)$ and the posterior $q(z|x_0)$, the other one is the reconstruction term:
$$\mathop{\mathbb{E}}_{z\sim q(z|x_0)} [ log p(x_0|z) ]$$
That is, given a data point $x_0$, we approximate and sample from the posterior $p(z|x0)$ to obtain a latent $z$, then we reconstruct the data point $x_0$ with the latent $z$. In the context of DDPM, it's similar.
Instead of modeling $p(x_0|z)$ as a gaussian, which assumes the $x_0$ is continuos variable as in common practice, however, $x_0$ is dicrete image data whose values lie in the range [0, 255]. This answers the question that why the author design a separate dicrete decoder to model the distribution $p(x_0|x_1)$ ($x_1$ denotes $z$ in the context of DDPM).
Then, the authors make simplification by incorporating the separate decoder into the $L_{t-1}$ loss term

The t = 1 case corresponds to L0 with the integral in the discrete decoder definition (13) approximated by the Gaussian probability density function times the bin width, ignoring σ21 and edge effects.

It's been said, the integral is replaced by:
$$ \frac{1}{\sqrt{2\pi}\sigma}e^{\ (x_0\ -\ u_\theta(x_1 \ ,\ 1))\ /\ (\ 2\sigma^2\ ) }*\frac{2}{255} $$
then $log p(x_0|x_1)$ becomes:
$$\frac{-1}{2\sigma^2} * || x0 - u_\theta(x1, 1)  ||^2 + C$$
The constant $C$ is ignored as it does not affect the optimization, and after ignoring sigma^2, we get:
$$|| x0 - u_\theta(x1, 1)  ||^2$$
And, according to the definition in DDPM:
$$x0 = \frac{1}{\sqrt{\tilde{\alpha_1}}}  (x_1 - \sqrt{1-\tilde{\alpha}_1} \ \boldsymbol{\epsilon} )$$
$$u_\theta(x1, 1) = \frac{1}{\sqrt{\alpha_1}}  (x_1 - \frac{\beta_1}{ \sqrt{1-\tilde{\alpha}_1}} \boldsymbol{\epsilon} \theta )$$
Remember that $\tilde{\alpha}_1 =\alpha_1$ and $\beta_1=1-\alpha_1$ , Finally, we have:
$$  \frac{1}{\sqrt{\alpha_1}} || \boldsymbol{\epsilon} - \boldsymbol{\epsilon}\theta ||^2 $$
${\alpha_1}$ in DDPM is chosen as $1-1e^{-4} \approx 1$, we could simply ignore the first term.

Thanks for the explanation! @jiachenlei
I've been stuck trying to understand the same question, however, I have one thing to point out in the above.
$$ \frac{1}{2{\sigma_1}^2} || x_0 - \mu_\theta(x_1, 1) ||^2 $$
plugging in
$$x_0 = \frac{1}{\sqrt{\alpha_1}}(x_1 - \sqrt{1 - \alpha_1}\epsilon), \ \mu_\theta(x_1, 1) = \frac{1}{\sqrt{\alpha_1}}(x_1 - \sqrt{1 - \alpha_1}\epsilon_\theta)$$
gives
$$\frac{1 - \alpha_1}{2{\sigma_1}^2 \alpha_1} || \epsilon - \epsilon_\theta ||^2$$
which corresponds to to $L_{t-1} - C$ (Eq. (12) in the paper) when $t = 1$.
The approximation of integral by gaussian times the bin width ignores the edge effects. Using $L_{simple}$ ignores the coefficient $\frac{1 - \alpha_1}{2{\sigma_1}^2 \alpha_1}$, which ignores $\sigma_1^2$.

@emiz6413  Ok. Thanks for pointing out. I have updated my answer


Bug: Interfaces List Filter Doesn't Find Any Interfaces when Searching Device

Environment

Nautobot version (Docker tag too if applicable): v2.1.0
Python version: demo.nautobot.com
Database platform, version: demo.nautobot.com
Middleware(s): demo.nautobot.com

Steps to Reproduce

Navigate to Devices -> Interfaces
Add a filter for Device
Get no results

Expected Behavior
Expect to show all of the interfaces for the device

Observed Behavior

No interfaces are returned
Device Name search turns into an ID

Note, that if I filter with the advanced filter of Device name that the filter appears appropriately, but the same behavior of no interfaces appear.

Try to "enhance the InterfaceFilterSet.device filter to support UUIDs as well". If it ends up taking longer than 3 points, fall back to "Change InterfaceFilterForm to have a device_id field instead of a device field"

This is also impacting the API

We on v2.1.5.
This bug also occurs when you go into Devices --> Cables: filter for Rack. --> select a Rack --> Filter ends up with 'Rack (name)' with the rack ID value instead of the name.
And also for Devices --> Cables: filter for Device.
Workaround
Example for Devices --> Cables: filter for Rack. But this works for all the above mentioned cases.
Open the Filter menu, go to the Advanced tab and than correctly enter the rack name as the 'exact' value for 'Field: Rack (name)' or enter the rack ID as 'exact' match for 'Field: Rack (ID)'.

As a developper working with the API, I think consistency for filtering is important. Today I wanted to loop over all device components of a given device, let's say 37a938b0-bd5a-4c25-9d98-a51c75d15ba9 from the demo. Using Pyanutobot one could write the following.
import pynautobot

nautobot = pynautobot.api(
    url="https://demo.nautobot.com",
    token="aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
)

component_endpoints = [
    nautobot.dcim.interfaces,
    nautobot.dcim.console_ports,
    nautobot.dcim.power_ports,
    # ...
]

for endpoint in component_endpoints:
    records = endpoint.filter(device="37a938b0-bd5a-4c25-9d98-a51c75d15ba9")
    print(endpoint.url, records)

Unfortunately, this does not work. The device filter has different behaviour depending on the endpoint. It works for pretty much all endpoints but interfaces one. No interface is retrieved because the device filter for interface needs a name, not an id. Moreover using the filter device_id would fail since it is unkown for most of the components.


Ability to change User-Agent for azkeys

Feature Request
Hi!
I've been trying to figure out how to set the User-Agent header for the new azkeys client: https://github.com/Azure/azure-sdk-for-go/tree/main/sdk/keyvault/azkeys
With the previous client, it was possible using the following:
	err = keyClient.AddToUserAgent("sigstore")
	if err != nil {
		return keyvault.BaseClient{}, err
	}

Is there a way to do this today that I am missing?

It is a bit different in the new SDKs.  The general pattern is that the clients are created with mandatory/optional params and are then immutable.
When creating the client, the ClientOptions allows you to specify an ApplicationID in the TelemetryOptions.

@jhendrixMSFT thanks! I was in there looking, but didn't figure out that the ApplicationID was related to the User-Agent. 😊👍

Good point.  I've opened a PR to clarify the doc string.


Flutter Permission denied for IOS

How to open Flutter app on IOS Simulator ....I have seen below problem .

Solved : https://github.com/flutter/flutter/issues/19241

Solved : #19241

why Solved  error: expected identifier
result([@"Not yet Implemented in iOS"]);


Make sun angle readonly and calculate it based on time

This is a first step, I'll remove it (with the realistic road temp) from the data model when the other PR is done.

#14 is merged and should work, but I haven't tested it on a real server yet.

Rebased, didn't find anything else while testing


error in committees/CommitteeAgendaSearch: failed to get meetings for committee 6

This issue was automatically created, please do not modify the title or remove any labels
Unexpected exception received while trying to get meetings of committee 6: ('Connection aborted.', error(110, 'Connection timed out'))

Encountered the error again
Unexpected exception received while trying to get meetings of committee 6: ('Connection aborted.', error(110, 'Connection timed out'))

Encountered the error again
Unexpected exception received while trying to get meetings of committee 6: ('Connection aborted.', error(110, 'Connection timed out'))

Encountered the error again
Unexpected exception received while trying to get meetings of committee 6: ('Connection aborted.', error(110, 'Connection timed out'))

Encountered the error again
Unexpected exception received while trying to get meetings of committee 6: ('Connection aborted.', error(110, 'Connection timed out'))


Migrate dependencies away from code.google.com

godep restore warns:
warning: code.google.com is shutting down; import path code.google.com/p/go.crypto/ssh/terminal will stop working
warning: code.google.com is shutting down; import path code.google.com/p/go.net/websocket will stop working
warning: code.google.com is shutting down; import path code.google.com/p/gogoprotobuf/proto will stop working

Fixed with https://github.com/cloudfoundry/cli/commit/7113930c199c8cd0210eefa8716c9445b9cc58e8


BUG: Navbar is not proper

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
The login button in navbar is getting overlapped by the dark mode switch.

In the Buy products page, when we scroll down the navbar items change their position resulting in misalignment

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Resolve this issue for all the pages where it exists.

Okay


Update node 8.8.0 pre

Description
Add your description here, if it fixes a particular issue please provide a link to the issue.
Checklist

[ ] Commit sequence broadly makes sense
[ ] Commits have useful messages
[ ] New tests are added if needed and existing tests are updated
[ ] Any changes are noted in the changelog
[ ] Code is formatted with fourmolu on version <IP_ADDRESS> (which can be run with scripts/fourmolize.sh)
[ ] Self-reviewed the diff

Migrations

[ ] The pr causes a breaking change of type a,b or c
[ ] If there is a breaking change, the pr includes a database migration and/or a fix process for old values, so that upgrade is possible
[ ] Resyncing and running the migrations provided will result in the same database semantically

If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.

We seem to have lost cardano-chain-gen jobs in Hydra: https://ci.iog.io/eval/32753?compare=master&full=0

We seem to have lost cardano-chain-gen jobs in Hydra: https://ci.iog.io/eval/32753?compare=master&full=0

I accidentally removed them, will fix.

I realize it's a bit too late, but I had some questions on the commented-out code. Otherwise, LGTM


Unable disable logging

SugarRecord.java makes a lot of calls to Log.i. Every time a table is saved it seems to be logging which slows down the application when bulk saving lots of records. Is it possible to make this configurable, it should at least be possible to disable logging on release builds.

You may want to remove the entry QUERY_LOG from your manifest completely

@larrytech7 To clarify, this issue is about the <Table> saved: <id> message, not the select query logging. If a database is update-heavy, these messages are extremely redundant.

I think the @larrytech7 is the more accurate for the issue.
Since the getting started guide http://satyan.github.io/sugar/ is referencing 1.4 I was using 1.4, set to false, then remove the line in the manifest, no changes. still logs. But I notice 1.5 is reference here in github, so I update the sugar version, set to false, then remove, no changes, the logs are still there.

I save my data to the database on startup and it would be really great to remove a log on every line of insertion. Since logging isn't free when it comes to performance this is an easy performance win for the whole database.

At the very least, these log lines should be Log.d for debug, not Log.i for info; they're very intrusive when doing a huge number of updates.


Add Dragon fetch and List Render

This pull request fetches the dragon data using API and renders the required data on the UI

Everything is correct now, time to merge it.


javascript build process

I'm a bit unclear on how javascript is being dealt with in this repo in contrast to the "out of the box" handling of javascript that comes with webhook.

The gruntfile is pointing towards script/src/index.js being your entry point.
This is a pattern I discussed with Jay as being our default. All sites should be the same. But it doesn't look like that aspect has been baked into our webhook-generator repo. Unless it was implemented as a theme?


crate::core::Core::read_model_from_buffer example?

It is not very obvious how to create a model from memory.
Specifically, I couldn't figure out how to make a Tensor from a Vec<u8> read from a file.
The most obvious way to achieve that is Tensor::from_ptr, but it is only pub(crate)

Thanks for the report; take a look at #137 and let me know if that explains things well-enough.

Thanks for the swift reply! The example is great but still does not cover my particular use case. My goal is to acquire a Model object from files in OpenVino IR format without providing file paths directly.
For example this could be useful if I download model files over network and don't want to store them on the file system.
So in my mind the example looks like this:
use openvino::Core;
use std::fs;

fn main() -> anyhow::Result<()> {
    let mut core = Core::new()?;
    // imagine graph and weights are instead downloaded over network
    let graph = fs::read("model.xml")?;
    let weights = fs::read("model.bin")?;

    let weights_tensor = todo!(); // change me
    let model = core.read_model_from_buffer(&graph, Some(&weights_tensor))?;
    Ok(())
}

I guess your example works, but then how do I get the shape of the weights tensor, should I parse the graph file?

Ah, I see the missing link. What I put up in #137 is what you need in order to fill out the todo!() in your latest snippet but I didn't consider the read_model_from_buffer part which was your original question! Essentially, create a tensor from the weights bytes using the U8 and a 1 x <# bytes> shape and copy in the bytes like I showed in #137. Then you can pass that tensor to core_read_model_from_buffer. Here's an example of how this is used in Wasmtime: https://github.com/bytecodealliance/wasmtime/blob/8ea2590/crates/wasi-nn/src/backend/openvino.rs#L38-L41.
I'll merge #137 since that is helpful regardless but maybe we should use your snippet as a doc example on read_model_from_buffer. The problem is we would need a valid model but, hm, maybe we can just ignore the error... Thoughts?

Okay, so I wrote a small example test for reading a model from buffers: #138
But I think I stumbled into an upstream bug in the newer versions on openvino: passing ElementType:U8 does not allocate enough space for the tensor (at lest it seems so since the size coming from ov_tensor_get_byte_size is definitely smaller then expected (91447851 bytes vs expected 243860936 for alexnet). The bug happens somewhere between 2024.0.0 and 2024.2.0, but I couldn't pin it down for now
But it also shows that having an honest-to-god-not-failing test is valuable here, so this is where I think it belongs


Update to 101.0.4951.54

I will let you know once I have a successful build.

Hexavalent 101.0.4951.54 compiled successfully and is running well on Fedora.


Update cloud job cleanup scripts for correct secret access

Added sudo to the clean job script to align with the login process and ensure correct access to the necessary secrets. The clean job was failing to access the correct secrets because it was not using sudo, whereas the login process used with Jenkins account.

/skip-all

/skip-all


Optimize Webpack Configurations

Do you want to request a feature, improve documentation, or ask a question?
New Feature

[x] Add declarative way of providing configurations to support all the features listed below
[x] Add CommonsChunkPlugins for development and production
[x] JS Bundles should be saved to config.compiledAssets.js.[name].[hash]
[x] Add updates to webpack lib to dynamically generate loaders options based on config

[x] Add ExtractTextPlugin for extracting critical css
[x] Add Custom plugin to take that css and add it to config.compiledAssets.css.[name].[hash]

[x] Move webpack lib into utils and add some more functions.

[x] Generate JS Bundles
[ ] Pre-render components and save markup in config.compiledAssets.components.[name].[hash]

[x] Add common chunk bundles, js bundles (already in but path is changing), critical css, and pre-rendered content into pug templates.

All tasks completed except for pre-rendering static components as much as possible. Closing this for now in favor of some new tickets.


Uncaught auth error

When I use useAuthState with signInWithPopup and close the popup without authenticating, the error state is not reached.
After a second these two errors appear in the console:

Uncaught: {code: "auth/popup-closed-by-user", message: "The popup has been closed by the user before finalizing the operation."}

Uncaught Error: The error you provided does not contain a stack trace.

I was expecting this error to cause useAuthState to reach the error state. Is this behavior expected?
The following code dropped into the CreateReactApp boilerplate will reproduce this error. In fact, all errors seem to cause the aforementioned result.
import React from 'react'

import * as firebase from 'firebase/app'
import 'firebase/auth'

import { useAuthState } from 'react-firebase-hooks/auth'

const firebaseConfig = {
  // copied from firebase console
}

firebase.initializeApp(firebaseConfig)

const provider = new firebase.auth.GoogleAuthProvider()

const login = () => {
  firebase.auth().signInWithPopup(provider)
}

export const logout = () => {
  firebase.auth().signOut()
}

export const App = () => {
  const [user, initialising, error] = useAuthState(
    firebase.auth(),
  )

  if (initialising) {
    return (

Initialising User...

    )
  }
  if (error) {
    return (

Error: {error}

    )
  }
  if (user) {
    return (

Current User: {user.email}

        <button onClick={logout}>Log out</button>

    )
  }

  return <button onClick={login}>Log in</button>
}

My package versions:
{
  "firebase": "^6.6.2",
  "react": "^16.9.0",
  "react-firebase-hooks": "^2.1.0",
}

Thanks for the great library!

I am having a similar issue using signInWithEmailAndPassword.
auth.esm.js:873
Uncaught M {code: "auth/user-not-found", message: "There is no user record corresponding to this identifier. The user may have been deleted."}

Just tried the example you provided
import { useAuthState } from 'react-firebase-hooks/auth';

const CurrentUser = () => {
  const [user, initialising, error] = useAuthState(firebase.auth());
  const login = () => {
<EMAIL_ADDRESS>'password');
  };
  const logout = () => {
    firebase.auth().signOut();
  };

  if (initialising) {
    return (

Initialising User...

    );
  }
  if (error) {
    return (

Error: {error}

    );
  }
  if (user) {
    return (

Current User: {user.email}

        <button onClick={logout}>Log out</button>

    );
  }
  return <button onClick={login}>Log in</button>;
};

Same result. Uncaught error. Using v2.1.0

Same result. Uncaught error. Using v2.1.0

No guys, you can use the hook and its loading param after the user signs in, you are not using the hook to sign in the users right. You are using the firebase sdk so, you will have to handle auth errors during login and sign up yourself

No guys, you can use the hook and its loading param after the user signs in, you are not using the hook to sign in the users right. You are using the firebase sdk so, you will have to handle auth errors during login and sign up yourself


Add Storybook and Cypress to the project and complete the setup

Description
Add Storybook for documentation purposes and Cypress for testing purposes

The setup of storybook is done as well as the cypress one, I've updated to the newest version of yarn as well.


LMB 491 | Mandataris without person breaks burgemeester selector

Description
When no burgemeester is selected it errors in the console as it cannot fetch its data.
How to test

Do not select a person in the legislatuur page; it should not throw an error
Start selecting a person but than cancel the model; it should not throw an error

Attachments
Error

Keep in mind that when selecting a persoon and the correct mandates are not available the user will still see "Selecteer een persoon" again as they could not set it to the mandatees. Maybe add a warning for this in the future.


"Create AMM" tutorial

Add an interactive tutorial for creating an XLS-30d AMM on AMM-Devnet with sample code
Add dependencies (CSS, JS, React components, etc.) for interactive tutorials generally
Fix CSS for loading the Space Mono font
Remove unused Counter.tsx example component
Update portal version and lockfile so that local dev works for me at all
Link out to a separate, staged version of the tutorial that works interactively
Remove the :not_enabled: icons, which Redocly doesn't support, from AMM docs

LGTM ✅

Rebased on the latest main to resolve merge conflicts. For the transaction result codes in files with merge conflicts, I made sure the resulting table has the error codes in alphabetical order.


sequencefile: keylength isn't properly checked

in certain failure situations, a sequence file can fail to parse in strange ways that create records that report that they have negative key lengths.  When reading a sequence file, it's checked that the total key length cannot be less than 0, but then 4 is taken from that; keyLengths can thus be -1 to -3.
https://github.com/stripe/sequins/blob/b5e7a386814ffe1bb88a0092d7d57119a841b5f6/sequencefile/sequencefile.go#L243-L248
this part:
	if totalKeyLength < 0 {
		return nil, fmt.Errorf("Invalid key length: %d", totalKeyLength)
	}

	keyOffset := sf.offset + 4 // skip four for BytesWritable length
	keyLength := int64(totalKeyLength) - 4

should be:
	keyOffset := sf.offset + 4 // skip four for BytesWritable length
	keyLength := int64(totalKeyLength) - 4

	if keyLength < 0 {
		return nil, fmt.Errorf("Invalid key length: %d", keyLength)
	}

unless, of course, negative key lengths are sometimes valid.

I fixed this when I rewrote the sequencefile code in #4. Thanks for the report!


Fix a couple of CupertinoTextField tests to avoid leak-tracking test failures.

Description
This PR fixes a couple of CupertinoTextField tests to avoid leak-tracking test failures.
Fixes: https://github.com/flutter/flutter/issues/135803.
It happened that MagnifierController awaits the hide animation before removing and disposing an OverlayEntry.
https://github.com/flutter/flutter/blob/57ed72417780ae7c6f371b33e30e62ba489b0a18/packages/flutter/lib/src/widgets/magnifier.dart#L283-L295
The duration of this animation in CupertinoMagnifier according to the source code is 150 milliseconds:
https://github.com/flutter/flutter/blob/57ed72417780ae7c6f371b33e30e62ba489b0a18/packages/flutter/lib/src/cupertino/magnifier.dart#L278
To fix leak-tracking test failures I added skips of the hide animation by pumping 150 milliseconds in failing tests.
Tests

Updates cupertino/text_field_test.dart to fix leak-tracking test failures.

Pre-launch Checklist

[X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[X] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
[X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[X] I signed the [CLA].
[X] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[X] I added new tests to check the change I am making, or this PR is [test-exempt].
[X] All existing and new tests are passing.

cc @polina-c

@polina-c, thanks for the review!


How to get index quote

like $SPX

I don't know if that's a thing in Robinhood

You can check this with stock equivalents like $SPY, $QQQ, etc

@mchauhan3 drop me an email sometime anilashanbhag @ gmail .com

@anilshanbhag Sent you a mail from mhchauhan3 @ gmail . com


Add "social sharing image" image chooser to settings panel

This adds a new image chooser field that populates the HTML Open Graph meta tags (which is what Facebook and Twitter use when you share a page).
The logic in our base template has been changed to:
IF page.preview_image USE page.preview_image
OTHERWISE IF page.social_image USE page.social_image
OTHERWISE USE default_cfpb_logo

I also added some logic to instruct Twitter to use large cards if the supplied social sharing image is large enough.
Additions

Social image chooser in the settings panel of page's admin screen
Large twitter card option

Changes

meta image tag logic

Screenshots
New social sharing image field in the settings panel:

Current normal size Twitter cards:

New large Twitter cards:

Notes

I added the field to the CFGOVPage class which means almost every page on the website will have it available. @ielerol @schaferjh Let me know if you think we should instead restrict it to certain page types (blog post, askcfpb pages, etc.).

Checklist

[ ] PR has an informative and human-readable title
[ ] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[ ] Code follows the standards laid out in the front end playbook
[ ] Passes all existing automated tests
[ ] New functions include new tests
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged
[ ] Visually tested in supported browsers and devices
[ ] Project documentation has been updated
[ ] Reviewers requested with the Assignee tool :arrow_right:

👍  to including it on all page types

Could we get a couple unit tests please :)

@contolini pushed 156 commits.

Looks like we got a rebasing problem :(


Configure transforms from prefabs

Needed to make this work nicely with the character controller and make it possible to write docs.
Add the TransfromSynchronization component to a prefab and give it transform strategy scriptable objects.
Should really still be WIP but we need to get in the minimum stuff right now. Will be worked on for a while after it's merged before it looks how it is supposed to.

Superseded by new PR.


Table header (thead) wont appear on every page when print on Chrome

Any news, or work arounds for this?

@cristianocoelho No news. Please star the Chromium bug. I'm sure google can show you some super-hacky workarounds.


CB 7952: fix msg parsing

Description of the change
There can be many different libraries or even different posis instances sending messages via postMessage, so don't try to process messages unless they are meant for this instance.
Type of change

[x] The JIRA ticket referenced in this pull request is marked appropriately as Feedback Issue/Bug (non-breaking change that fixes an issue), or Story (non-breaking change that adds functionality).
[ ] Breaking change (fix or feature that requires changes in other repositories to function)
[ ] This change requires a documentation update on the Wiki.

Checklists
Development and Testing

[ ] I have added tests that prove my fix is effective or that my feature works.
[x] All linting rules and tests pass, indicated by the Continuous Integration build system status.

Code review

[ ] This pull request is using the issue tracker (JIRA) ID in the title, branch name, and commit message so that the issue tracker matches the link automatically. The issue tracker is also used to track related issues.
[ ] This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached.
[ ] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand, complex or unintuitive areas.

@bkempe I tried getting rid of JSON serialization, but some bad objects are passed in which results in clone exception (like device info etc.). It's too much work to try and fix that.


apps: Enable TCP Keepalive for Clients

Not sure why TCP Keepalive was not enabled. Theoretically (and in my test scenario where I found this, practically) even the TLS Handshake alone can take long, longer than a NAT port binding of the local router/firewall. In other words, I need this in my scenario, I am using a short system-wide TCP Keepalive because my TLS Handshake fails otherwise. Therefore, reporting this through a Pull Request to the general public. If it is invalid and it was discussed before, do not hesitate to close this Pull Request … but then, please, explain why, for example, by linking to such a discussion.

Wouldn't it make more sense for your application to set the keep alive?
You mention that you have a short system-wide TCP keep alive.  It seems, to me, that you are causing this problem for yourself.

your application to set the keep alive?

Not sure, I understand that question. The app I am using is openssl s_client. So it is not really ‘my’ app.
I found another place in code that does enable TCP Keep-Alive on default. Not sure which app, API, or use-case that covers.
I thought every TCP application should set TCP Keep-Alive, nowadays. Of course, that raises the question of why it is not enabled on default system-wide.

you are causing this problem for yourself

Not really. My home router has short-living port bindings because of its Firewall. This is a quite common issue here in my country. I tested several manufactures, and all except one had timeouts below those IETF recommended two hours. Only three (that includes the one with the long default) allow changing that default. Consequently, yes, I have to set the TCP Keep-Alive on my system lower manually. But no, without that, it would not work either.

This PR is in a state where it requires action by @openssl/otc but the last update was 61 days ago

Could you please rebase the PR to resolve conflicts?
Marking as inactive to be closed at the end of 3.4 dev barring further input.

This PR is in a state where it requires action by @openssl/otc but the last update was 30 days ago

This PR is in a state where it requires action by @openssl/otc but the last update was 61 days ago


WIP: Add mypy tests

I attempted adding the framework from sqlalchemy-tests but I learned that it involved bring in mypy as a submodule or something weird so I looked elsewhere.  I discovered https://pypi.org/project/pytest-mypy-plugins/ which sounded pretty good and lo and behold it seems to work well.  My hope is to add more tests, possibly all the ones I wrote for mypy, then bring the plugin over here afterwards with tests.
Pull Request Check List
This is just a friendly reminder about the most common mistakes.  Please make sure that you tick all boxes.  But please read our contribution guide at least once, it will save you unnecessary review cycles!
If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing left to do.  If your pull request is a documentation fix or a trivial typo, feel free to delete the whole thing.

[x] Added tests for changed code.
[ ] New features have been added to our Hypothesis testing strategy.
[ ] Changes or additions to public APIs are reflected in our type stubs (files ending in .pyi).

[ ] ...and used in the stub test file tests/typing_example.py.

[ ] Updated documentation for changed code.

[ ] New functions/classes have to be added to docs/api.rst by hand.
[ ] Changes to the signature of @attr.s() have to be added by hand too.
[ ] Changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives.  Find the appropriate next version in our __init__.py file.

[ ] Documentation in .rst files is written using semantic newlines.
[ ] Changes (and possible deprecations) have news fragments in changelog.d.

If you have any questions to any of the points above, just submit and ask!  This checklist is here to help you, not to deter you from contributing!

I can't figure out why the tests are being cancelled after 1 minute.


micah/4039/hide edges on zoom v2

This PR adds a new network interaction option to hide edges on zoom, hideEdgesOnZoom
This new option is patterned after the existing hideEdgesOnDrag option.
fix #4039
📄 steps to test

cd vis
run a local server on port 8080
visit the Dynamic Data - Neighbourhood Highlight example at  http://localhost:8080/examples/network/exampleApplications/neighbourhoodHighlight.html
scroll to zoom
notice that edges are not shown during zooming, and are shown again when zooming ends ✨

ported over from https://github.com/almende/vis/pull/4042

tests and build look good ✅
(we should really set up proper automated CI soon 😅)


fix caching on circle ci

closes #49

cache seems to have worked see
https://circleci.com/gh/braindecode/braindecode/229?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
but I do see many sphinx build warnings. Let's do this in another PR.
feel free to MRG

Great, merged


adapted migrations to django 1.7

In order to use the django migrations included in django 1.7 django-oauth2-provider needs to be updated
I just followed the docs:
https://docs.djangoproject.com/en/1.7/topics/migrations/#libraries-third-party-apps
Basically move migrations directory to south_migrations and run makemigrations.
This solves the issue of referencing django-oauth2-provider models from a new django 1.7 migration. The historical cannot be retrieved properly.

I have merged this pull request on my fork
https://github.com/stormsherpa/django-oauth2-provider/pull/2


add_comp_prot.R - sum_vars function handle the character vector of the column name instead of using !!!rlang::syms()

Discussed in https://github.com/impact-initiatives-hppu/humind/discussions/411

Originally posted by lanawwas July  5, 2024
There is an error currently in the unit-test due to the use of !!!rlang::syms() in the code. While the sum_vars can handle the column names as a character vector
I propose to change the following, by replace the !!!rlang::sysms() with character vector in add_comp_prot,R#L133 :
# now sum across with the following threshold: 11 and above = 5, 8 to 10 = 4, 5 to 7 = 3, 2 to 4 = 2, 1 = 1, NA = NA
df <- sum_vars(
  df,
  c("comp_prot_score_concern_freq_cope", "comp_prot_score_concern_freq_displaced", "comp_prot_score_concern_hh_freq_kidnapping", "comp_prot_score_concern_hh_freq_discrimination"),
  "comp_prot_score_concern",
  na_rm = FALSE,
  imputation = "none"
)

@gnoblet

solved in 59efc98


Develop feat/

Added Travis Build File

Closing this PR as it seems it was targeting the wrong branch


feat: add decorationLine for TextWidget

Hi, in my case I need this, so I added it for anyone who needs it

Wow, thank you for the feedback, this is my first PR , xD
Very helpful

Updated!

Hi, something happened so i will close this and create a new one, thank you for helping


MacOS deploymentTarget is added, when only iOS is specified

I have the following options set:
options:
  deploymentTarget:
    iOS: 13.0

The target that is generated is a Framework, and I have added platform: iOS to it.
Yet, when I generate the project, it keeps adding MacOS 10.15 as a target - is there any way to prevent this from being added?

I have the same issue

`` is only overriding the plaform version. Please use platform if you want to limit OS in target.
https://github.com/yonaskolb/XcodeGen/blob/8bfa2f33e4a7d99eb8b8068bf671c7060b8de63e/Docs/ProjectSpec.md#target

Ah I misread the initial report. I have this:
targets:
  MyTarget:
    type: framework
    platform: iOS
    deploymentTarget: 11.0

This generates the same result as the picture above.

I don't think you did misread it. I stated that I have also set platform: iOS as you have in your example.

deploymentTarget  is only for overriding the plaform version. Please use platform if you want to limit OS in target.
https://github.com/yonaskolb/XcodeGen/blob/8bfa2f33e4a7d99eb8b8068bf671c7060b8de63e/Docs/ProjectSpec.md#target

As I said in my post, I have set the platform to just iOS. I have the deploymentTarget set in the options as I want to specify the iOS version in one place.

This is how my target is configured:
targets:
  SomeFramework:
    type: framework
    platform: iOS

Ops, I'm sorry. How about setting TARGETED_DEVICE_FAMILY as 1 in settings?

targets:
  App:
    type: application
    platform: iOS
    ...
    settings:
      base:
        TARGETED_DEVICE_FAMILY: 1 # supports iPhone(1)

Thanks for the response. If I do that, it now looks like this:

But if I change the TARGETED_DEVICE_FAMILY to 2, or use 1,2 then MacOS is again automatically selected.

Thanks for your help. I realise now the project setup was correct, but that something else must be happening. I now found the answer to this: in your settings you need to add SUPPORTS_MACCATALYST: NO, so for example:
targets:
  App:
    type: application
    platform: iOS
    ...
    settings:
      base:
        SUPPORTS_MACCATALYST: NO


fix[logout via url]: Adds a logout route so the user can be logged out via the Sign out button or by visiting the logout url

Checklist

[X ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[X] Links to related issues (if applicable)

Closes #5690
Why is this needed?
When using an OIDC provider like keycloak you need to specify a Front-Channel logout URL in order to invalidate the session and the token for the client since the current way datahub implements logout is JS based you cannot logout of datahub unless you click on the sign out button.
Adding this enables the ability to logout via the nav item or via visiting the logout URL which can be triggered via the OIDC client.

Hi @benmarte.
We are syncing offline at this point. Going to close this until we have it in a state where we can accept.
Cheers
John

Hi,
Any work going around this PR


Bump rand dependency

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hey @nrc @BusyJay, can you please publish a new 0.4 crate with this (and all the other changes that piled since last release)?

Sure, will do it next Monday.


fix#6 support for torch state checking

This PR adds support for accessing the native torch mode (ON or OFF).
An initial torch switch from react-native is required to get the correct status of the Torch. Subsequent Torch mode switches (from anywhere) are well detected.
This method is currently only supported on Android >= 6.0 and on iOS (>= 8.0).

Looks good to me.

Hi @TwFlem
Can you please merge this change?
We need this change for our App.
Thanks.

@oguennec have you released your version on NPM, since this package does not seem to be maintained anymore?


upgrade to typescript 5

https://issues.redhat.com/browse/RHOAIENG-3260
Description

Upgrade typescript version 5.3.3
How Has This Been Tested?

npm run test
Ad hoc testing of app.
Test Impact

None
Request review criteria:

Self checklist (all need to be checked):

[x] The developer has manually tested the changes and verified that the changes work
[x] Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

[ ] Included any necessary screenshots or gifs if it was a UI change.
[ ] Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

[ ] The developer has tested their solution on a cluster by using the image produced by the PR to main

@christianvogt Anything scary about this upgrade? I don't see any code changes really... is there new features we can nab / should start telling the team to use?

@andrewballantyne the upgrade went through very easily - as expected. I don't think there's anything to worry about so long as it compiles and our cypress / ad hoc testing works.
TBH I'm not familiar with what new features we got since 4.0.3 that we should announce to use. Maybe best to just announce the update to the team and have them go out and find out on their own what new features may be of use and to share if they come across something work mentioning.

rebased

/lgtm


NO MRG: Add Registration (historic)

Fixes https://github.com/nanshe-org/nanshe_workflow/issues/45
Implements a simple translation based registration algorithm with Dask.
Note: Needs better test data for use with registration step. Also uses a development version of Dask. Any version of Dask 0.14.2+ provides the required functionality.

Going to leave this out of v2.2.0 as we are still playing with this. However, expect this will get cleaned up and land in v2.3.0.

As the new version of dask is out, this now passes. However we still have some work to do here.

The CI failure occurs in Dask as repeat is to restrictive about what types it will accept for the number of repeats. Have proposed a fix that has been accepted. ( https://github.com/dask/dask/pull/2371 ) Also have a workaround for the dask-ndfourier that can be relied upon if needed. ( https://github.com/dask-image/dask-ndfourier/pull/30 )
The cause is essentially a consequence of the shape not being a tuple of ints, but instead being a tuple of numpy.int64. The type change of the shape occurs because of a bug in dask-ndfilters. It occurs here because of a call to median_filter. Have opened issue ( https://github.com/dask-image/dask-ndfilters/issues/26 ) to document the issue, which it seems we understand clearly now. Should be easy enough to fix.

Test failure fixed by dask-ndfilters's 0.1.1 release. In particular, PR ( https://github.com/dask-image/dask-ndfilters/pull/27 ) addressed the unexpected integral types in the Dask Arrays' shape.

FWIW the reason Python 3 failed and not Python 2 is on Python 2 all NumPy integral types are subclasses of int. However on Python 3 this is not the case. Thus why PR ( https://github.com/dask/dask/pull/2371 ) was necessary to help address the issue.

Replacing with PR ( https://github.com/nanshe-org/nanshe_workflow/pull/95 ), which cleans this up a bit.


fixed extension to the surface values in vertical interpolation

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Trivial change (affects only documentation or cleanup)

Checklist:

[x] I have tested this change with a run of GEOSgcm (if non-trivial)
[ ] I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
[x] I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@bena-nasa For cell values vertical interpolation, there are no extension to the surface values ( no surface any way) . It becomes MAPL_UNDEF.  I guess it is what GEOS wants.

The lower bound of plx is probably not a bug. When it is passed in, the index is automatically starting from 1. @bena-nasa I would like your help to verify this PR.

@weiyuan-jiang As you are presenting this as a hotfix to main, can you put an explanation in the main commit message as to what bug it is fixing, where it was encountered, etc. Or is there an issue you can point to?
Since you say this is non-zero-diff, we'll need a good explanation of why we are going non-zero-diff to convince @sdrabenh, @gmao-rreichle, etc.

I'll take a closer look at this, until I test this in detail, I'm not comfortable merging this since the vertical interpolation is used in 100% of every geos run so we cannot break it.

I can honestly say that I have no clue what this is about, but if there is a bug, I'm wondering if the omission of the ppx<=ps*msn condition is the right fix.  To me, this looks like it's intended to be a physics limit -- something like "pressure cannot be higher than surface pressure".  If it's an intentional limit that's implemented wrongly, the solution wouldn't be to omit the limit.  What I'm saying here may not make any sense, but I agree with @bena-nasa that we should proceed carefully.  I also agree with @mathomp4  and @tclune that a better Description of the bug in the PR's introductory comment box is needed.

I run across the codes because of the other PR #2210 .  If I understand correctly, the conditions of the .and.  in the "where " block are contradictory.  So the codes there would never be executed.  If that is what GEOS wants ( after years of running), then this is not a bug any more.

Is there a resolution to this issue?     I'd like to either merge or reject this PR unless there is still work going on to evaluate it.

Is there a resolution to this issue?

I have no idea. Has anyone checked with the modeling group to see if the ppx<=ps*msn condition at issue is an intentional physics check that inadvertently doesn't kick in?   I don't think the SI team should merge or reject this without confirmation from an atm model developer.

This PR was rejected and would be closed. I had discussion with Ben and was convinced that we should not extend the values to the surface that has no values.

@weiyuan-jiang:  So did this get run by an atm model developer?  If not, I don't think the PR should be closed at this time.


[#22] Optional flag to write filenames using YYYYMMDD

It's nice to have file names based on the date with non-unique periods. This helps when pulling directories of logs into an elk-stack or splunk and with newsyslog file count and size rotations.

BTW, it makes it easier for reviewers to address comments as follow up commits, so that we can see only what changed. But this is a small pull request, I'll live. :smiley:

This whole feature opens up the possibility of two processes trying to write to the same log file at the same time, which I'm not too happy about... But this is an opt-in (doesn't happen without the flag), and I guess you better know what you're doing when you use that flag.
Maybe add a warning to that effect in the description of the flag, at least?

 I'd prefer if folks amend their commits.
It's great how GH squashes the previous notes on changed lines. It tells the reviewer "this previous comment no longer applies". If a line was not changed in an amend the note still stands! A reviewer can then isolate requests to change lines of code by leaving the "in-line" notes. General comments on the PR or comments that should persist amends can be left as "comments" in the conversation. I agree that when a non-trivial or "new" bit of work is added to a PR then a follow up commit is best.
This is one of those "semi-great debates"-- whether to ask folks to amend or submit follow up commits ((along with weather to merge a PR or land on master with a bot and keep the commit log clean)). I'm down to follow whatever the project prefers.

wrt two threads/processes/thingys writing to the same file: yeap. expected.
 Or do you think folks should expect that behavior? I'm in the boat of: if you're using a broad time range as your log sink you should be designing a process mutex (pidfile of some sort) around whatever is generating logs. I can try my hand at fitting something succinct into the description.

You get the "previous notes on changed lines squashed" effect with follow up commits as well, if I'm not mistaken? It's a good feature. Personally, I'd love it if we could use reviewable.io, but they need some GitHub permissions that the Google security team is not liking... :frowning:
While you mention whether to merge a PR or land on master, what I like is that once everyone likes the PR, rebase it on top of master as needed, squash it to a single commit (if there were more than one), and land on master. But I've merged PRs as well, when I found that this would be less work (unresponsive contributor, for example)...

For the concurrent access, I'm not saying it should be some all caps "DANGER! DANGER!" warning, but just a succint mention that this is unsafe if there is more than one process would do, yes.

I like that strategy too! Do you usually ask folks to squash commits once the PR is in an accepted state, or do you fetch, squash, land, for them?

I usually ask.

Friendly ping! @ukai, is there anything else you'd like done here?

I'm not convinced we really need such flag.
might be suffice by just setting logdir and capture all files in the dir?

For the most part, the current implementation of new file per process start works. Thanks for the help/time here, let's put this to rest.


Separate parsedatetime/__init__.py into several small .py files

The current parsedatetime/__init__.py is extremely huge (~ 2,800 lines) which is not human-friendly for both reading and debugging. We should find a way to separate this one into several small modules. My suggestion is:

__init__.py - an empty init module only import classes/functions that are exposed to public access;
helpers.py - all helper functions, for example, _extract_date, _extract_time and _pop_time_accuracy, etc.;
parse.py - all parser functions which can be separated from Calendar class;
calendar.py - for Calendar class which contains all variables for parser functions (or just keep context.py is enough?);
constants.py - for Constants class which contains all constants for parser functions;
shortcut.py - new shortcut functions, e.g. parse(), nlp(), etc.

These features should shoot for version 2.0 or later.

blocking https://github.com/bear/parsedatetime/issues/121


feat: next

This is a proposed new release of electron-download being renamed to @electron/download and brought into the modern era 👍

Missing .travis.yml? This git magic makes it confusing what's going to happen when the merge happens.

Once this is moved to electron/download I'll set up Circle CI

Ugh, latest got requires Node 8. Should we follow suit now that April is fast approaching?

Ugh, latest got requires Node 8. Should we follow suit now that April is fast approaching?

Yeah, let's do it 👍

Are we dropping the progress bar?

Yes, if someone wants a progress bar they can implement a custom downloader 👍

:shipit: Drop my request for changes and merge, I'm on mobile


chore(runtime): bump versions to 0.3.0

Only testnet runtime needs to be bumped.

why would devnet not be bumped too? Currently devnet and testnet are equivalent.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 10.60%. Comparing base (a9de17d) to head (873ea1e).
Report is 1 commits behind head on main.

@@           Coverage Diff           @@
##             main     #219   +/-   ##
=======================================
  Coverage   10.60%   10.60%
=======================================
  Files          27       27
  Lines        2132     2132
  Branches     2132     2132
=======================================
  Hits          226      226
  Misses       1906     1906

Files
Coverage Δ

runtime/testnet/src/lib.rs
14.88% <ø> (ø)


ionic 2 generator filenames don't follow naming conventions

When you create a component, page, service, etc with the cli generator, the filenames of the TypeScript files do not follow the naming conventions recommended in the official Angular Style Guide, in particular Style 02-02 and Style 02-03.  The files are missing the conventional suffix for the file type.
This may not be a crucial or pressing issue, but for the sake of promoting best practices, I think it would be a good idea for the generator to conform to these standard conventions.

This issue was moved to driftyco/ionic-app-generators#14


Check for update gives 500 internal server error.

When I press "Check for update" I get a 500 internal server error

@Ratingthomas Thank you very much for your issue.
Is there a file called prod-2023-03-16.log (the date may differ in your case) in the directory var/log/ in the mosparo root directory? In this file, mosparo should log all general errors. After you've clicked the 'Check for update' button, the last line of the file should show the error which occurred.
If there is no such file, please tell me more about your setup. Is it on a virtual/dedicated server or shared web hosting? Which PHP version and which operating system do you use?

Hi @zepich
Here a my logs for when I press the "Check for update" button
[2023-03-16T19:23:57.986063+01:00] php.CRITICAL: Uncaught Error: Call to undefined function Symfony\Component\HttpClient\Response\curl_multi_exec() {"exception":"[object] (Error(code: 0): Call to undefined function Symfony\\Component\\HttpClient\\Response\\curl_multi_exec() at /home/users/thomas/www/mydomain.example.com/vendor/symfony/http-client/Response/CurlResponse.php:304)"} []
[2023-03-16T19:23:58.036847+01:00] request.CRITICAL: Uncaught PHP Exception Symfony\Component\ErrorHandler\Error\UndefinedFunctionError: "Attempted to call function "curl_multi_exec" from namespace "Symfony\Component\HttpClient\Response"." at /home/users/thomas/www/mydomain.example.com/vendor/symfony/http-client/Response/CurlResponse.php line 304 {"exception":"[object] (Symfony\\Component\\ErrorHandler\\Error\\UndefinedFunctionError(code: 0): Attempted to call function \"curl_multi_exec\" from namespace \"Symfony\\Component\\HttpClient\\Response\". at /home/users/thomas/www/mydomain.example.com/vendor/symfony/http-client/Response/CurlResponse.php:304)"} []

I am using php version 8.1.

Hi @Ratingthomas
Thank you very much.
Are you on shared hosting, or can you check your php.ini file? There is a directive called disable_functions. Is this directive enabled (the line is not starting with a semicolon ;)?
; This directive allows you to disable certain functions for security reasons.
; It receives a comma-delimited list of function names.
; http://php.net/disable-functions
disable_functions =

If the directive is enabled, is the function curl_multi_exec visible in this line after the equal sign =?
If yes, that's probably the reason for the error. In general, mosparo uses the HttpClient of Symfony, which should automatically fall back to the native PHP methods to download files. But if the cURL extension is enabled and this function is disabled, the client cannot work correctly.
If the function is listed in the disable_functions directive, can you temporarily remove it to test if it works afterward?

If you're on a shared hosting: Please let me know which hoster you use if you're on shared hosting.

Hi
I checked my php.ini and indeed curl_multi_exec  was disabeld. I removed it from the list, and now it works perfectly.
Thanks.

Perfect, thank you for your feedback.
I will add a hint in the documentation and add a task to enhance the setup (automatic check if everything is set up correctly) and handle the error in the 'Check for update' function.


vNext: [IL2CPP] deployment failure (DEP0700) "splash screen image cannot be located"

Overview
Error		DEP0700: Registration of the app failed. [0x80073CF6] AppxManifest.xml(28,27): error 0x80070002: Cannot install or update package Microsoft.MixedReality.Toolkit_ph1m9x8skttmg because the splash screen image [SplashScreen.png] cannot be located. Verify that the package contains an image that can be used as a splash screen for the application, and that the package manifest points to the correct location in the package where this splash screen image can be found.
Expected Behavior
Can deploy
Actual Behavior
Cannot deploy
Steps to reproduce

Clone repository
Open project
Pick favorite scene
Build for UWP
Load sln in VS
Build/deploy (HoloLens or Immersive Headset)

Unity Editor Version
2018.1.9f1
Mixed Reality Toolkit Release Version
mrtk_development

Sounds like we didn't set a splash screen in the project settings.

The project looks ok. the asset is there and the manifest looks right... It builds and deploys fine using the .net backend

Wondering if this might actually be a unity bug. Seems like the asset is copied into the directory properly but not referenced by the generated solution.

Yes, confirmed, I'm getting this error in an empty project with IL2CPP.

Is there any workaround for this? I'm not actually using the MR toolkit, but just exported an IL2CPP VS project from Unity and got this error. We'd like to use IL2CPP with Vuforia to have (hopefully) faster tracking speeds.

Having the same issue, but no luck with the above workaround. I've reset the splash screen image in the manifest (although it seemed to be set correctly already), and checked the files are in the Assets folder. I even tried copying the Package.appxmanifest file a .net build folder to the IL2CPP build, but no luck. I am using the MRTK and Vuforia, though I realise this is considered a Unity issue. Can anyone please advise?
Attached is a screengrab of the splash screen settings in VS.

Here's the Unity bug tracking the splashscreen issue:
https://issuetracker.unity3d.com/issues/uwp-cpp-projects-report-not-having-a-splash-screen-set-which-fails-deployment
There are plans to backport to 2017.4 and 2018.2:
https://fogbugz.unity3d.com/default.asp?1082836_hvro1nvjegdd9bjt

Here's a work around:
        [PostProcessBuild(2)]
        public static void SplashScreenFix(BuildTarget target, string pathToBuild)
        {
            if (target != BuildTarget.WSAPlayer ||
                PlayerSettings.GetScriptingBackend(BuildTargetGroup.WSA) != ScriptingImplementation.IL2CPP)
            {
                return;
            }

            var vcxProj = Directory.GetFiles(pathToBuild, "*.vcxproj", SearchOption.AllDirectories)
                .Where(project => project.IndexOf("il2cppoutputproject", StringComparison.CurrentCultureIgnoreCase) < 0);
            var projects = vcxProj as string[];

            Assert.IsTrue(projects != null);
            Assert.IsTrue(projects.Length == 1);

            var vcxProject = projects[0];
            var projXml = XDocument.Load(vcxProject);
            var pngElements = projXml.Descendants().Where(x =>
            {
                var val = x.FirstAttribute?.Value.Contains(".png");
                return val.HasValue && val.Value;
            });

            foreach (var element in pngElements)
            {
                foreach (var child in element.Elements())
                {
                    if (child.Name.ToString().Contains("ExcludeFromResourceIndex"))
                    {
                        child.Remove();
                    }
                }
            }

            projXml.Save(vcxProject);
        }

Thanks much, where should I put this?

Any editor script

I'm having this problem on the non-vNext MRTK also, I think its a Unity bug. A way to solve it is:

Copy UWP/Proj/Assets/SplashScreen.Scale-200.png to UWP/Proj/Assets/SplashScreen.png
Add this "new" SplashScreen.png to the project.

Worked for me, thanks!

In the Unity 2018.2.9 release should be the fix:

(1073029 (1071331)) - Universal Windows Platform: Fixed "SplashScreen is missing" error when deploying UWP apps with Visual Studio 15.8.

I will update and give it a try.

An update on this issue from the Unity side, in case anyone else is still hitting it.
It's been fixed in 2018.2 and up and also 2017.4 (LTS) but won't be fixed for 2018.1 as that release is no longer being supported.
If you cannot migrate to one of these releases, the workaround is basically to remove the "true" tags from the SplashScreen and other "Logo" assets. Either re importing the assets or directly editing the VS project file should work.


Comment line is wrong when viewing non BASE-HEAD diffs

If you view a SHA-HEAD diff and leave a line comment, it leaves a comment on that line number on the BASE-HEAD diff, which may be woefully different to the intended line. This is actually kinda hard to fix without doing per-commit comments (which GH supports and shows in the PR UI but we don't do yet).

A stopgap for this would be to disallow SHA-HEAD comments until we can sort commit line comments out, which would remove the important flag from this bug.


[release-1.11] Fix windows tar ext name

This is an automated cherry-pick of #34163

@googlebot I consent.

/retest


The time axis in the diagram seems to be inconsistent with the formula - axis shown as Minutes but formula uses Second.

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: aea19668-9e4e-ee61-e5ec-725746f0c6fc
Version Independent ID: bac2197e-1698-6bc1-0282-d62154504bcc
Content: Sliding Window (Azure Stream Analytics) - Stream Analytics Query
Content Source: stream-analytics-docs/sliding-window-azure-stream-analytics.md
Service: stream-analytics
GitHub Login: @mamccrea
Microsoft Alias: mamccrea

Thanks @harrchen88! I've updated the screenshot. The changes should go live tomorrow.
#please-close


This fixes
runtimes/backlog/issues/517

Below is the verification job where copy happened successfully.
hyc-runtimes-jenkins/view/Test_grinder/job/Grinder/15735

This PR is related to SVTTestRepo/pull/30.

Approving based on test result at svt-jenkins/Grinder/15742


HOSTED VS2017 Has Preview 3 of dotnet core cli instead of final version preventing builds STILL.

After almost a month we still can't build dotnetcore applications properly on vsts because even with HOSTED VS2017 build agent we still get back 1.0.0-preview3-004056 instead of V1.0.0 as the version number which causes restore and build errors that aren't there with the proper version of dotnet core on it.
I've verified that there is no global.json file hanging around and it builds perfectly here in vs.net and at the command line with the right version installed.

I'd also like to add to this, currently experiencing issues with dotnet restore on (extremely basic) solutions created with vs2017 on the vs2017 hosted queue.
When running the dotnet restore task on an ASP.NETCore project created in Visual Studio 2017, the process fails to resolve project references for .netstandard projects that are referenced by the head project.
At the begging of the restore process, the following error message is shown for each .netstandard project that is included in the solution:
C:\a\1\s\Temporary\FormsMvvmcross\FormsMvvmcross\FormsMvvmcross.Server.Core\FormsMvvmcross.Server.Core.csproj(83,3): error MSB4019: The imported project "C:\Program Files\dotnet\sdk\1.0.0\Microsoft\Portable\v5.0\Microsoft.Portable.CSharp.targets" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exists on disk.
dotnet restore then continues to restore packages for the head netcore project as normal, then ends with the following error messages:
C:\Program Files\dotnet\sdk\1.0.0\NuGet.targets(97,5): error : Unable to resolve 'C:\a\1\s\Temporary\FormsMvvmcross\FormsMvvmcross.Models\FormsMvvmcross.Models.csproj' for '.NETCoreApp,Version=v1.1'. [C:\a\1\s\Temporary\FormsMvvmcross\FormsMvvmcross.sln] C:\Program Files\dotnet\sdk\1.0.0\NuGet.targets(97,5): error : Unable to resolve 'C:\a\1\s\Temporary\FormsMvvmcross\FormsMvvmcross.Server.Core\FormsMvvmcross.Server.Core.csproj' for '.NETCoreApp,Version=v1.1'. [C:\a\1\s\Temporary\FormsMvvmcross\FormsMvvmcross.sln]
I have tried the exact same build steps on the Hosted 2015 agent, and dotnet restore works perfectly fine, however the build tasks fail because the agent does not understand the new csproj format of the dotnet core project.

@JohnGalt1717 when you queue your build to the Hosted VS2017 pool, can you add a cmdline step at the top of your build definition:
file: dotnet
arguments: --version
I get 1.0.0. Are you saying you get 1.0.0-preview3-004056?

per @ericsciple comment, I still can't repo.
Here's what I get when I do that:
2017-03-22T17:51:54.9286497Z ##[section]Starting: dotnet --version
2017-03-22T17:51:54.9306495Z ==============================================================================
2017-03-22T17:51:54.9306495Z Task         : .NET Core (PREVIEW)
2017-03-22T17:51:54.9306495Z Description  : Build, test and publish using dotnet core command-line.
2017-03-22T17:51:54.9306495Z Version      : 0.4.1
2017-03-22T17:51:54.9306495Z Author       : Microsoft Corporation
2017-03-22T17:51:54.9306495Z Help         : [More Information](https://go.microsoft.com/fwlink/?linkid=832194)
2017-03-22T17:51:54.9306495Z ==============================================================================
2017-03-22T17:51:55.9234330Z [command]C:\Program Files\dotnet\dotnet.exe --version
2017-03-22T17:51:56.0105221Z 1.0.0
2017-03-22T17:51:56.0215334Z ##[section]Finishing: dotnet --version

Sorry meant to reply this afternoon. It started working with the exact same configuration and check-in this morning.
James Hancock
603.289.7972

From: Bryan MacFarlane<EMAIL_ADDRESS>Sent: Apr 4, 2017 10:20 PM
To: Microsoft/vsts-tasks
Cc: James Hancock; Mention
Subject: Re: [Microsoft/vsts-tasks] HOSTED VS2017 Has Preview 3 of dotnet core cli instead of final version preventing builds STILL. (#3898)
per @ericsciplehttps://github.com/ericsciple comment, I still can't repo.
Here's what I get when I do that:
2017-03-22T17:51:54.9286497Z ##[section]Starting: dotnet --version
2017-03-22T17:51:54.9306495Z ==============================================================================
2017-03-22T17:51:54.9306495Z Task         : .NET Core (PREVIEW)
2017-03-22T17:51:54.9306495Z Description  : Build, test and publish using dotnet core command-line.
2017-03-22T17:51:54.9306495Z Version      : 0.4.1
2017-03-22T17:51:54.9306495Z Author       : Microsoft Corporation
2017-03-22T17:51:54.9306495Z Help         : More Information
2017-03-22T17:51:54.9306495Z ==============================================================================
2017-03-22T17:51:55.9234330Z [command]C:\Program Files\dotnet\dotnet.exe --version
2017-03-22T17:51:56.0105221Z 1.0.0
2017-03-22T17:51:56.0215334Z ##[section]Finishing: dotnet --version
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/Microsoft/vsts-tasks/issues/3898#issuecomment-291719551, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AByBc9TVXgV6NNwwpCbvMUwsgFyxMWibks5rsvphgaJpZM4Ms8Vn.

OK.  Thanks for confirming.
Sorry for the issues you've had with the VS2017 rollout.  As a team we've taken the issues seriously and we're improving our image process and the ability to onboard preview versions of VS early.

Great news!  Thanks!