Read-only mode?

Not a bug, but a feature request. I LOVE the editor abilities of this, but would like the option to share it as read-only. I suppose an approach to having this work so that the author can still make changes, is perhaps a new link that references the original "tag", but is one that, when de-referenced, renders the code in a read-only console.
Or, if it can generate a new link "tag", of which it's read only? Not sure how it's implemented internally but either way, I would love this option if considered. Thanks.

Hi, thanks for the message. That's an interesting idea, what would your intended use-case for a read-only code editor be?

If I want to demo code changes to an audience that has no need to make (either intentionally or unintentionally) changes to the code. I may also want to write up a script, and send someone the link for them to view it later (they would have no need either to modify the code).

Thanks for telling me more about your use case! That sounds interesting and nice to have, though I'm not sure if it's worth the extra complexity in the application.

Seems like streaming a code session or remote instruction could benefit from a read-only viewer mode.


"az monitor log-analytics workspace --help" fail in azdev

Describe the bug
Command Name
az monitor log-analytics workspace
Errors:
cannot import name 'SkuNameEnum' from 'azure.mgmt.loganalytics.models' (e:\repos\azure-cli\venv\lib\site-packages\azure\mgmt\loganalytics\models\__init__.py)
Traceback (most recent call last):
lib\site-packages\knack\cli.py, ln 215, in invoke
    cmd_result = self.invocation.execute(args)
cli\core\commands\__init__.py, ln 572, in execute
    parsed_args = self.parser.parse_args(args)
lib\site-packages\knack\parser.py, ln 260, in parse_args
    return super(CLICommandParser, self).parse_args(args)
...
command_modules\monitor\operations\log_analytics_workspace.py, ln 5, in <module>
    from azure.mgmt.loganalytics.models import SkuNameEnum
ImportError: cannot import name 'SkuNameEnum' from 'azure.mgmt.loganalytics.models' (e:\repos\azure-cli\venv\lib\site-packages\azure\mgmt\loganalytics\models\__init__.py)

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Clone azure-cli repo (master branch) and type the cmds:
virtualenv --no-site-packages venv
.\venv\Scripts\activate
python -m pip install pywin32==225 azdev
python -m azdev setup -c
az monitor log-analytics workspace --help

Expected Behavior
Environment Summary
Windows-10-10.0.18362-SP0
Python 3.7.4
Installer: PIP

azure-cli 2.3.1

Additional Context

And If I clone the dev branch this is error would not happen.

HI @MyronFanQiu could you pls help to have a look? thanks

This is also causing azdev linter to fail with same error with attempting to lint extensions.

@colbylwilliams cloning the latest dev branch and running 'azdev setup' should solve the issue.

@MyronFanQiu Can you drive to merge the related code from dev to master and release new packages? If I install the azure-cli package (instead of 'azdev setup') directly, this still happen.
It is blocking the CLI document generation.

One dependency package azure-mgmt-loganalytic has released a new version 0.3.0 on 4.9. There is a breaking change in it. We locked the version to 0.2 instead of 0.2.0. We have fixed it in our dev branch in 4.10. We're discussing about cherry-picking the fix to master branch right now.

As CLI will release new version next Tuesday and we'll merge dev into master at that time and the issue should be resolved at that time.

add to S169

add to S171

This should be solved.


[flutter_tools] gradle cleanup 1 of 99999

Our gradle integration is difficult to contribute to and understand. This is partially due to the large library sizes and the extensive use of globals and mocking. Fixing this at once is not feasible, consider this a small step in that direction.

Make all of the gradle build APIs methods on an AndroidBuilder class instead of top level methods. This will allow us (eventually) to inject dependencies instead of using globals.

Attempt to separate the tests for the gradle helper methods and the end to end gradle builder tests into separate test libraries. Each library is still fairly large, but should be a bit more manageable.

Part of https://github.com/flutter/flutter/pull/76264


boards: nordic: Fix the label for nRF70 SR co-existence

The co-existence modules expect a common and fixed name, so, rename it to avoid churn.

@muraliThokala @bama-nordic

Based on https://github.com/zephyrproject-rtos/zephyr/pull/79606 (will be moved to ready for review once this is merged)


React Native CameraRoll.getPhotos API doesn't seem to return

Question
For some reason, I have failed to get images data from CameraRoll.getPhtos.
Here is my code
import React,{useState, useEffect} from 'react';
import {View} from 'react-native';
import * as Permissions from 'expo-permissions';
import CameraRoll from "@react-native-community/cameraroll";

const getImages = async (setImages) => {
   await Permissions.askAsync(Permissions.CAMERA_ROLL);
   const x=await CameraRoll.getPhotos({first:2})
   await setImages([...x.edges])
}

export default function App() {
  const [images,setImages]=useState([])
  useEffect(() => {
    console.log('loading photos')
    getImages(setImages)
    console.log('done')
    console.log(images)
  }, []);
  return (
    <View >
    </View>
  );
}

The code is intended to load images into the state when the component mounts. How can I fix this problem?
Link to question on Stack Overflow (Link)

Hey there, thanks for posting. This looks like a question about React state management to me. I see you also already posted it on Stack Overflow, which seems like the right place for this type of question. I'm going to close the issue here because it's not directly related to cameraroll. If you find a defect, specific to this library, let me know and I'll reopen the issue.


Update to docker image broke Azure Database Connection

Hello,
I had made an quick update to my wix site today, published it, checked my results on the live site, and realized that none of my database content was showing on our site.
After investigation and looking at the web app interface (with the wix logo and 3 pass/fail results):

DB Config Status: Missing Props: jwtPublicKey appDefId
Permissions Config Status: Permissions config read successfully
Connection Status: Connected to database successfully

Going by memory for above so I can't provide much more than there wasn't really much more helpful output than that from the dialog to remember.
I eventually fixed it reverting to the mysql docker image. I reviewed the documentation and found nothing significantly changed from when I set it up.
I'm seeing there was a new docker image within hours of this happening (10 hrs ago now). Being on the mysql image fixes it for now, but if this faced issue, the 1.0 tag does not seem to work in the current setup, there would be limited fall-back at the moment.
Current setup:
As described here for Microsoft Azure MySQL database:
https://dev.wix.com/docs/develop-websites/articles/databases/external-databases/microsoft/integrate-your-microsoft-azure-database-with-your-wix-site
Optional step of permissions also utilized to outline permissions for each table.
It's also unknown if the site was working before I published it, or if there was errors in the database on publish. I didn't touch the database, I just moved a pinned button's position. It was meant to be a very quick change, I didn't really take much of a baseline look before publishing.
I seem to be good from here on my own site, but wanted to bring it to your attention

Thank you very much for writing to us.
By mistake, a new version of the adapter (v3) was uploaded to the same link in docker hub.
We uploaded the v2 version again to the link defined in the guide you attached. (veloex/velo-external-db:latest)
The adapter in azure should be updated automatically as soon as a new image is uploaded to the same link.
If the adapter has not been updated, redeploy the adapter.
I would appreciate it if you could update me on whether the problem has been resolved.


My vs code cant find the .NET Core SDK but I can run the dotnet command in the vscode terminal

does anyone know how to fix this, its taken the better part of a day. I have tried uninstalling and reinstalling everything. I am running windows 10 and funny compatible versions with the VS code C# extension

Same problem here on Linux

If this is still an issue, you might want to look at the Omnisharp log and if necessary increase the logging level:

A lot has changed with O# sdk resolution since this issue was opened. If you are still having problems, please open a new issue at https://github.com/omnisharp/omnisharp-roslyn/issues


rename convert command to generate

@kadel Can you please rename the bits from the main readme and also the readmes in the example?

Yes other than docs update rest LGTM

updated

Good for merge from my side if @cdrage is fine with this.

LGTM for now and will merge, but once more variables come up, may be good to rename the variable names in the cmd files related to CLI. Mergin!


Vue3 Support

Amazing project! Best practice for Vue+Tradingview.
Is there a plan for vue3 compatibility and support?

where is the duplicate of this one?


Comprehensive code review prior to version 1.0 release

As discussed with many of the CCL team at CMU this past week, I'm going to try to do a comprehensive code review of CCL in conjunction with the paper and upcoming version 1.0 release of the code base.
Some comments on how I plan to do this:

To (re-) address the principal objection people had about this -- I recognize that many of you are counting on this paper at least being on the arXiv prior to the upcoming job search season.  I don't think this review will need to slow that down much if at all.  Only when aspects of this review will impact the paper will we want this review to slow down the paper at all.  And I don't anticipate much of this.  We agreed on hack day that the response to this review should be complete before releasing version 1.0, but that probably just needs to happen before the paper is accepted and published in a journal, and we should (!) be finished long before then.

The mechanics of this is a little different from a normal code review on a pull request, since I'll be reviewing everything, not just one coherent change to a part of the code.  To give me line-by-line commenting on all the code, I made a branch called empty, which doesn't have any code in it and a branch called review which is currently the same as master.  I copied over the non-code files from master, so none of them show up in the diff, but all the code and documentation files show up in full.  Once the review is done, we can switch the base for this PR from empty to master and merge any changes here back into the main code base.

There was a request to do this in stages by topic.  So there may be several reviews by me covering different subsets of the code.  The intent of this is that some of you can ignore reviews that cover parts of the code that you didn't work on and only bother reading the ones that are relevant to your work.  We'll see how this goes, but I'll try to break things up sensibly.

This is kind of an experiment.  I think it would be good if we can develop a culture in DESC to do these kinds of reviews occasionally.  Maybe usually more in advance of the paper draft, rather than coincident with it, but at some point before big releases of important DESC code bases.  But I don't really know how this is going to go exactly, so apologies in advance if there are some growing pains associated with this process.

I'm going to try to have my end of this complete by the middle of August (2 weeks from now).  This should roughly coincide with the end of IR for the paper I think.  This will allow you to address any paper-relevant concerns before or during CWR.

@rmjarvis - I think this could be a really useful exercise both for the CCL team and for the collaboration, to learn how this type of code review might be done.  As you said, it seems like a review from someone external to the core developer team could be useful at least for our larger code bases (especially when they will be relied on heavily by a broad swathe of the collaboration).  Looking forward to hearing your thoughts on how this could be done more generally once this one is over.

OK, I think I've finished going through all the main code (python and C layers).  I didn't go through the example scripts or ipython notebooks.  But I think there's enough here for you guys to chew on.
One thing that I think might affect the paper is my suggestion about the number of decimal places in what you pass to CLASS.  I know there were some regimes where you were finding that ccl and CLASS disagreed at some moderate level.  It seems at least possible that this loss of precision in how you pass the parameters could be relevant.  So I'd like someone to check if any of the comparison plots with CLASS change if you pass the parameters at full double precision.
I didn't notice anything else that might impact the paper, but I would encourage people going through my suggestions before the CWR for the paper just to make sure there isn't something that you think might matter for something you said in the paper.  But a thorough response to these suggestions can wait until the paper is finished with CWR if you want.

@rmjarvis:
So just to confirm regarding how we should handle changes - I have a tiny branch where I am working on the code changes to the mass function. Should I be making a PR to merge that branch onto the review branch to address concerns, making a PR to master, or making direct modifications to review?

That's a good question.  I don't know what will be the easiest.  I had been thinking that changes could be made directly on the review branch.  Then the commits will show up here, and the comments on the relevant lines usually get collapsed, so you can see the progress and what's left to address.  Then when we're ready, we just switch the target of the PR to master and merge the changes there.
But we don't have to do it that way.  Separate PRs onto master that cover some subset of these changes could also make sense.  In that case, it would be helpful to leave a response comment here to say that something is addressed by which PR, just to help keep track of things.
I'll leave it up to you which workflow you think is easier.

Oh, and I should add that some suggestions are probably too large a change to make sense making directly here in the review branch.  I think I suggested a few times to make an issue outlining the appropriate change, so that's also a fine response in some cases.

In lieu of not opening up a giant chain here for iteration, I have created PR #440 , which addresses the changes necessary to ccl_massfunc.c, ccl_massfunc.h, and (eventually), massfunction.py.

@rmjarvis Thanks for this review. With v0.9 we brought in some new features. In particular, there is the src/ccl_halomod.c which you probably didn't have in this version. If you want to also take a look at that, we'd be happy to address comments there.

This is a summary of the review to get the work organised:

Instalment 1. This covers the Python interface. Most suggested changes pertain documentation and small function changes in the unit tests. I think this is all quite self-contained and no more than a few hs work.

Instalment 2. This covers the C code: ccl_core, ccl_background, ccl_error, ccl_util.

The main high level comment is the need to set all parameters used by the C layer from python rather than just in the .ini file or (worse) by changing #define statements and recompiling. We currently set the cosmology from python but we should be able to set, for example, the spline parameters there as well. This is a significant amount of work that impacts all of the Python layer.
We should look into running coverage tests of your C layer code #448. This is a significant amount of work but self-contained.
There is a fair amount of repeated code that could be streamlined significantly. This is a simple self-contained task, no more than a day.

Instalment 3. ccl_cls and ccl_correlation. There are some comments on re-structuring ccl_cls and on improving their tests (includes #441). Probably a day's worth of work though the suggestion to make the Cls tests more stringent might be hard to satisfy without looking in more detail into the comparison benchmarks.

Instalment 4. ccl_power, ccl_emu17. Some tidying up in ccl_power and ccl_emu, including the neutrino file, but all minor.

Instalment 5. ccl_massfunc, ccl_neutrinos, and ccl_lsst_specs. ccl_massfunc already addressed in #440. Most significant changes in the structure of ccl_lsst_specs which will require a bit of work and testing. Probably at least a day's worth of work.

Looking at what is left to be done for the code review:

Some minor docs for E&Hu @damonge
ccl_neutrinos and lsst_specs in installment 5 @elisachisari @c-d-leonard
slow/fast C tests @elisachisari @joezuntz
installment 3 has not been addressed yet. This is for ccl_cls and ccl_correlation. @damonge @sukhdeep1989 This is a bit of work, and requires more CMB-related benchmarks
plus any open issues tagged as "v1": https://github.com/LSSTDESC/CCL/milestone/3

So do we merge this now? Not sure of the intended protocol here. I think all the installments have been completed. @rmjarvis @elisachisari @damonge

Since all the action happened on other branches, we can just close this now.  Thanks, y'all.


Use memory to ingest files, add slug to food groups

Contributes to #26 and #34.
Changes Added

Added a name slug to the food group, allowing the use of a web-friendly string to set colors in the UI
Refactored the data ingestion workflow to utilize memory as much as possible

How to Give Feedback
Start the local database and run pn db:seed. By default, the ingestion task will only process flow files smaller than 1 MB. This threshold was added to allow for quick database population in development mode. The value can be adjusted or removed by changing FLOW_FILE_SIZE_LIMIT_MB in the .env file to a higher value. With the default setting, the process took 15 minutes on my machine.
Known Issues
Maritime flows are not available because the CSV files in the v3 folder are not in the required format. Once new files are available, we can add them to the list of ingest files.
@oliverroick, this is ready for review.

I've ran this locally today, it took about one hour and then I saw the following error:
Running seed command `node --max-old-space-size=12096 --import tsx prisma/seed` ...
[2024-09-18T02:28:34.967Z] (+0.12s) Preparing to seed data to 'postgresql://postgres:postgres@localhost:5433/food-twin'
[2024-09-18T02:28:36.154Z] (+1.19s) Cleared nodes table.
[2024-09-18T02:28:40.959Z] (+4.80s) Ingested admin centroids to "Node" table...
[2024-09-18T02:29:09.707Z] (+28.75s) Ingested area limits.
[2024-09-18T02:29:12.114Z] (+2.41s) Ingested inland ports...
[2024-09-18T03:25:07.295Z] (+3355.18s) Ingested rail nodes.
[2024-09-18T03:25:12.155Z] (+4.86s) Ingested maritime nodes.
[2024-09-18T03:25:12.514Z] (+0.36s) Cleared edges table.
[2024-09-18T03:25:28.882Z] (+16.37s) Ingested maritime edges.
[2024-09-18T03:26:21.549Z] (+52.67s) Parsed land edges.
[2024-09-18T03:32:12.565Z] (+351.02s) Copied land edges to temporary table.
Error ingesting data: Error: Command failed: psql "postgresql://postgres:postgres@localhost:5433/food-twin" -c "
    COPY (
      SELECT le.id
      FROM \"land_edges_temp\" le
      LEFT JOIN \"Node\" n1 ON n1.id = le.\"from_node_id\"
      LEFT JOIN \"Node\" n2 ON n2.id = le.\"to_node_id\"
      WHERE n1.id IS NULL OR n2.id IS NULL
    ) TO STDOUT CSV HEADER
  " > "/Users/oroick/code/developmentseed/foodtwin-global-app/seed-data/v3/unmatched_land_edges.csv"
ERROR:  could not resize shared memory segment "/PostgreSQL.522842286" to 16777216 bytes: No space left on device

    at genericNodeError (node:internal/errors:984:15)
    at wrappedFn (node:internal/errors:538:14)
    at ChildProcess.exithandler (node:child_process:422:12)
    at ChildProcess.emit (node:events:519:28)
    at maybeClose (node:internal/child_process:1105:16)
    at Socket.<anonymous> (node:internal/child_process:457:11)
    at Socket.emit (node:events:519:28)
    at Pipe.<anonymous> (node:net:339:12) {
  code: 1,
  killed: false,
  signal: null,
  cmd: 'psql "postgresql://postgres:postgres@localhost:5433/food-twin" -c "\n' +
    '    COPY (\n' +
    '      SELECT le.id\n' +
    '      FROM \\"land_edges_temp\\" le\n' +
    '      LEFT JOIN \\"Node\\" n1 ON n1.id = le.\\"from_node_id\\"\n' +
    '      LEFT JOIN \\"Node\\" n2 ON n2.id = le.\\"to_node_id\\"\n' +
    '      WHERE n1.id IS NULL OR n2.id IS NULL\n' +
    '    ) TO STDOUT CSV HEADER\n' +
    '  " > "/Users/oroick/code/developmentseed/foodtwin-global-app/seed-data/v3/unmatched_land_edges.csv"',
  stdout: '',
  stderr: 'ERROR:  could not resize shared memory segment "/PostgreSQL.522842286" to 16777216 bytes: No space left on device\n'
}

@oliverroick this is likely due to unavailable memory in the Docker instance. As per our chat, let's go ahead and merge this and refine the process separately. I uploaded an updated DB dump to global-food-twin-test-db. You should be able to use it in the meantime.


[BUG]:Copy a data Microsoft excel to text-editor styles are missing

I'm submitting a
Bug report
Description
I have copied data excel to text-editor ,there is formatted data which is bold,table heading etc., So problem is that when we copy that data excel to text-editor that pasted data has removed it's CSS(also Table border). This issue is coming on all browsers which are copy data MS Office 365 excel to Text-editor.
Kindly please help for me that issue.
Version Information
ngx-editor: ^4.0.0
angular: ^6.0.3

Browser
Chrome -  71.0.3578.98

NOTE: We have all the data keep in Microsoft Excel like(Office 365).

Ngx-editor Excel copy paste to editor
@sibiraj-s  please give me suggest of that issue

Sorry for the huge delay. Can you try v5.
Note: Tables are not supported yet.


improv: wrap onboarding steps in form elements and make them keyboard accessible

Previously, the onboarding was not keyboard accessible - Pressing enter did not move to the next step. This commit wraps the onboarding steps in a form component and changes the button to a submit so that the whole flow is enter-accessible. Also to prevent default form submit behaviour, we also need to add e.preventDefault() on the button clicks
Fixes #267

Some things worth discussing

Since we are using an external package ( @hello-pangea/color-picker ) for picking the primary color. It does not have first class accessiblity support. Choosing a color through the picker and pressing Enter has no action. But pressing enter from the input fields in the color picker does submit the form.

Clicking on paragraphs and other elements in the form and pressing enter has no action. I'm not sure if there is a HTML way of accomplishing this.

If we want these to be fixed we can do that by using javascript, useRefs and a React'ive way of doing things, but it would also add to the complexity and there are a lot of edge cases to be considered. Let me know what you folks think.

@Pranav2612000 we are 99% going to use a different color picker component, so no need to do anything regarding the Color Picker. I want to rewrite that component.

Awesome work @Pranav2612000 and appreciate the call outs!
Recognize that enter doesn't work on most of the pages because most of the pages aren't actually forms! In hindsight, I think the only screen that matters is the one where you have to type, aka the one with an input.
I removed the autofocus because don't think it's necessary! Awesome stuff, will merge in shortly. Welcome to the contributors list!

Thank you @Teddarific and @alexdanilowicz


Payments test fix berk

https://github.com/MinaProtocol/mina/pull/13634

hm, those changes are not related to payments test fix... is the fix already merged or this is a mistake?

jiawei and i are looking into this

https://github.com/MinaProtocol/mina/pull/13634
this pr no longer needed


exists() for a QuerySet doesn't work

I want to use exists().
Here an example:
Entry.objects.filter(user='username').exists()
But it returns False.
But it returns something without exists()  like [<Entry: user01>]
Also if I use count(), it returns 1.
Entry.objects.filter(user='username').count()
Doesn't support django-ldapdb exists() or is there a bug?

Well, this looks like a bug indeed ;)
Probably some missing functions deep in the code.


feat: Make network mesh service timeout configurable.

Fixes #3295.

CI is failing

CI still not happy

CI is finally happy :)


Could not use databricks_test on windows, on version 0.0.3

On windows when running pytest following error occured
pyspark.sql.utils.IllegalArgumentException: 'java.net.URISyntaxException: Relative path in absolute URI: file:C:/Users/ANAND~1.MAU/AppData/Local/Temp/tmp_5luqhb7'

After checking online i found that when creating spark session, hive directory should be initialised like:
file:///C:/Users/ANAND~1.MAU/AppData/Local/Temp/tmp_5luqhb7'

As you can see after file: "///" are required on windows.
I checked on linux your code is working fine on that.

I've released 0.0.4 with this fix https://github.com/algattik/DataOps/commit/afbb5dbfadb5140dc232c5ecaa875cf7a79ae0c6, could you test it?

Running Okay, Thanks


Why are we still needing MVC now in the popularity of microservices?

From the .NET framework to the current .Net Core, MVC has been around for many years. Why don't we abandon or introduce new design concepts (such as Spring Boot WebFlux) to improve our application performance? Today, microservices are popular, we are still using MVC to design and build our API.

what do you think is unique about webflux and springboot compared to ASP.NET Core MVC?

what do you think is unique about webflux and springboot compared to ASP.NET Core MVC?

Faster response performance, non-blocking, streaming, etc.

Faster response performance,

By which measure? Spring vs ASP.NET Core MVC

non-blocking

ASP.NET Core is async so not blocking if you don't all blocking apis. If you call blocking IO in ASP.NET Core 3.0 it will prevent you by default https://github.com/aspnet/Announcements/issues/342

Right as @benaadams mentioned this is all doable with ASP.NET Core itself and even mvc. Unlike most java frameworks, it’s non blocking at the core and very lean and fast.

Faster response performance, non-blocking, streaming, etc.

Easy to do and IMO more elegant in c# than in java

Maybe we need a faster, more advanced technology, because we often hear about how Microsoft is still engaged in MVC. In today's more and more front-end separation technology, why do we need MVC? Instead of creating a better one. Come out.

You may want to watch this week's ASP.NET Community Standup where @rynowak talks about the unbundling of features for MVC so they can be utilised by other approaches and areas of the technology stack: https://youtu.be/R36j2KGBBhE?t=1295 it may unlock what you are looking for...

Right, the name MVC has stigma and really is just the name that was picked years ago (mostly because of rails and the MVC pattern) that stuck. The framework itself is modern and we're pushing more concepts into the core.

Personally feel that .NET CORE is a new .NET branch or modern technology or architecture, you should not continue to use the term MVC, or the feeling is that Microsoft has been playing MVC this old technology for years. And there should be a more resounding name to tell everyone, hey, I have a new generation of next-generation WEB technology, we have good performance and a more agile development language, want to try it?

The development friends and colleagues around me are puzzled. Why do we still use the old MVC framework when the micro-service usage rate is getting higher and higher? Why do we need to use ASP.NET MVC to complete the whole application development? Why not directly Use "Vue.js, AngularJS, NodeJS" for page rendering?

Personally feel that .NET CORE is a new .NET branch or modern technology or architecture, you should not continue to use the term MVC, or the feeling is that Microsoft has been playing MVC this old technology for years.

I generally agree with you. It's a double edged sword, it's a detractor for people like you that are looking at seemingly newer technologies on other stacks when comparing it to .NET Core but it's a comfort to people porting older applications for ASP.NET MVC to ASP.NET Core MVC.

And there should be a more resounding name to tell everyone, hey, I have a new generation of next-generation WEB technology, we have good performance and a more agile development language, want to try it?

We're working on it though, it's mostly marketing and it's really hard to rename things in .NET without breaking everyone. If one were to look past the artifical naming, the framwork itself is modern and fast.

The development friends and colleagues around me are puzzled. Why do we still use the old MVC framework when the micro-service usage rate is getting higher and higher? Why do we need to use ASP.NET MVC to complete the whole application development? Why not directly Use "Vue.js, AngularJS, NodeJS" for page rendering?

I've heard the same thing from folks that don't know what the tech stack has to offer. While the naming is unfortunate, the stack itself supports multiple ways of writing applications (you can easily remove the V from MVC). Just look at the wide variety of application types we offer (and this is just a small set) with ASP.NET Core 3.0:


feat: delete managed fields

This PR aims to delete managed fields as they are not necessary for scans

lgtm


Ingest Service Rest API ingest endpoint return value is documented incorrectly

It returns the Workflow Instance XML representation, not a Media Package XML representation.
https://github.com/opencast/opencast/blob/65e467a1e5be80ec4cd2e51de6117624d7d41087/modules/ingest-service-impl/src/main/java/org/opencastproject/ingest/endpoint/IngestRestService.java#L1122
I'll probably submit my own fix for this when I get around to it if somebody doesn't beat me to it.

https://github.com/opencast/opencast/pull/3892


unicode build

will he upcoming build works with unicode build  /D_UNICODE /DUNICODE

I think this is mostly irrelevant. We are using 'W' variants of Win32 API functions almost anywhere.
That said, there are still remains for 'A' variants to support Win98, it would probably a good idea to cleanup the code and remove those.


boundarynorm fix

[x] Closes #4061
[x] Closes #49
[x] Closes #7014
[x] Tests added
[x] User visible changes (including notable bug fixes) are documented in whats-new.rst
[ ] New functions/methods are listed in api.rst >> not applicable

Thanks @jklymak, that makes sense I guess. I have committed the changes again. Could you check if it can be merged?

Thanks for this PR!


EMR Unnecessarily Querying for Terminated Clusters

When doing a list_clusters call for the EMR resource, AWS and boto currently return ALL of the EMRs, including ones that were terminated. Since the default API rate limits for EMR are low, this causes problems related to throttling when the data from list_clusters is augmented with the response from the API call describe_clusters, since the latter requires it to be called for each cluster separately.
My solution involves passing the following as extra_args: {'ClusterStates': ['WAITING', 'BOOTSTRAPPING', 'RUNNING', 'STARTING']}.
This will only list the clusters that have not been terminated. From the current list of actions in cloud custodian for EMR, none of them apply to terminated clusters (or ones that are terminating). This is also to my knowledge and experience. There may be disagreements.
I will fork and submit the fix shortly.

thanks for the pr


Update the compilation profiles

Make the dev profile a little more optimized
Make the other profiles have the debug information

Seems good, but I just have a few questions:

What is the difference in run time for debug mode?
What is the rationale for adding debug information in release mode?
Does setting debug to on in release mode impact performance?

* What is the difference in run time for debug mode?

None, for the platforms we can target (ELF, MACH-O, PE). The debug information lives in a separate sections and could even be split in a separate file to keep the actual binary lean.

* What is the rationale for adding debug information in release mode?

It can be used to see what is going on on a per-function granularity and it is much better than landing in the disasm world at least on mac :)

* Does setting debug to on in release mode impact performance?

Luckily not, our drives are fast enough that the additional size is negligible :)

If debug is fast enough, we wouldn't need symbols in release. But fine for now. Not having symbols is super obnoxious.

Let see if the code coverage works on release this way.

The build time seems growing enough to have travis timeouts though...

Coverage remained the same at 80.308% when pulling f513df4cfc16790e052e5d32a3540f1c8d536cd5 on rust-av:update-profiles into 3d5389903a5c3166d6b3dbc5ec4b4b9a0e0a57fe on xiph:master.

It needs more experimentation, the time usage grow too much and using dav1d requires a new suppression map.


Code spacing standardization for BEAMS3D

This addressed issue #190 for BEAMS3D.  I've used:
fortran-linter -i --indent-size=3 *.f90

on the sources to fix any spacing issues.  The code compiles and runs throught the benchmarks with the usual quality of results.

Let's wait a bit before mergeing.  I want to see if I really like all the formatting.

This will have to wait till later.


Added a --files option to analyse rustc's --emit=llvm-lines output.

Since you can't use cargo-llvm-lines with x.py, I added a --files option, so that I could measure the llvm-lines of rustc itself.
I'm also writing an entry in rustc-dev-guide. Example usage:
RUSTFLAGS="--emit=llvm-ir" ./x.py build --stage 0 compiler/rustc

# Single crate, eg. rustc_middle
cargo llvm-lines --files ./build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/debug/deps/rustc_middle* > llvm-lines-middle.txt
# Whole compiler at once
cargo llvm-lines --files ./build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/debug/deps/*.ll > llvm-lines.txt

I successfully used this in rust-lang/rust#76680.

Thanks for addressing the review!


[Bug]: Library builds do not log from the very beginning

The logs only start when the game loop is created. Build the C example to test

done


Update to current population asset

Fixes #732
@TC25 does this look okay to you?

The new one seems to be an image collection.
You should use the 2020 image within the collection: 'CIESIN/GPWv411/GPW_Population_Count/gpw_v4_population_count_rev11_2020_30_sec' instead.

@TC25 thanks for catching that!
I've made the change.

Confirmed that everything is working after TC's comment change. @gino-m please review.


[Snyk] Upgrade @emotion/cache from 11.9.3 to 11.10.3

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade @emotion/cache from 11.9.3 to 11.10.3.

:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 4 versions ahead of your current version.
The recommended version was released 2 months ago, on 2022-08-23.

Release notes

Package name: @emotion/cache

11.10.3 - 2022-08-23Patch Changes

#2864 b9b8b749 Thanks @ Andarist! - Fixed a regression that could cause a crash when looking for an ignoring comment for unsafe pseudo-classes.

11.10.2 - 2022-08-22Patch Changes

#2751 0ffd6068 Thanks @ Andarist, @ kyoncy! - Fix /* emotion-disable-server-rendering-unsafe-selector-warning-please-do-not-use-this-the-warning-exists-for-a-reason */ not disabling the warning when there are multiple blocks of CSS.

11.10.1 - 2022-08-02Patch Changes

#2842 28e9b499 Thanks @ Andarist! - Thanks to the recently added exports field, the package now includes a worker condition that can be utilized by properly configured bundlers when targeting worker-like environments. It fixes the issue with browser-specific files being prioritized by some bundlers when targeting workers.

11.10.0 - 2022-07-31

11.9.3 - 2022-06-12

    from @emotion/cache GitHub release notes

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-10-26T02:03:19.382+0000

Duration: 10 min 18 sec

:robot: GitHub comments
Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

/test all : Re-trigger the build for all the stages.

resolved by #311


New package: CatPalette v0.1.0

Registering package: CatPalette
Repository: https://github.com/lyriath-love/CatPalette
Created by: @lyriath-love
Version: v0.1.0
Commit: 7cd919fe3fe48c63dba070b1007f596ddfdd514a
Git reference: main
Release notes:

First Version!

@lyriath-love just out of curiosity, have you seen Crayons.jl or StyledStrings.jl?

You also seem to have included the project Manifest, which isn't right.
[noblock]


Tasks 766-769 craigslist_bargains, qed

Please rename your tasks to 766-769 as task names till 768 are used in the previous PR.

Reviews: https://github.com/swarooprm/CSE576HW/pull/97

Fixed task numbers

Please make sure to set the "Categories": [""] and "Domains": [""] fields according to the taxonomy presented here.

@aarunku5 Fixed.
@danyaljj My 'Categories' fields seem to follow the taxonomy.

@ritvik7 the tests are failing at this point since all the task files must have language tags:
  "Input_language": ["English"],
  "Output_language": ["English"],
  "Instruction_language": ["English"],


Weather Sample and Upgrade Unity Version to 2022.3 LTS

Sample
Weather Sample
Summary
Upgrade Unity Samples to 2022.3 LTS
Weather Sample for Unity

Rain
Snow
Thunder & Lightning
Sound FX

Tests
Windows
ArcGIS Maps SDK Version
Unity 2022.3 LTS

Looks really good! The stereo sound effects are amazing! Very realistic. Great job!
Few very minor changes on the UI,

Outfield -> Select a city.., and then the instruction description needs to be updated

For some cities (for example, Alaminos Canyon), when you click from the dropdown, it just shows a comma on the top menu.

Please also make sure the sample viewer menu is updated :)

One optional suggestion, for snowy weathers, I think it would be nice to also add a sound effect, maybe something similar to this https://www.youtube.com/watch?v=7BrIJrjxVxA ?

God idea on the sound. I'll have to add it to UE too!
Totally forgot to add to sample viewer and to update directions. Will do today!


Whatsapp calls don't work

Whatsapp calls don't work. Is there a solution? Is it possible to configure configurations?

I have no idea

This repository contains only the docker image, not more. If you need support, you can contact the 3proxy author.


Do upgrades also have to be done via ARM?

This doc says "Applications which are not deployed as an Azure resource cannot have Managed Identities." That's fine, if ARM deployment works just as well (eg not slower than using using the .NET SF client library).
Once an application is deployed to an SF cluster using an ARM template, is it possible to upgrade the application outside of ARM (particularly data or config upgrades)? Or do all deployments of the application have to go through ARM?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cc5c2990-459f-b2be-7d0e-249f6ba99298
Version Independent ID: 4065f9e0-c5f3-0939-1339-33a9f58a75ec
Content: Azure Service Fabric - Deploy application with a user-assigned managed identity
Content Source: articles/service-fabric/how-to-deploy-service-fabric-application-user-assigned-managed-identity.md
Service: service-fabric
GitHub Login: @athinanthny
Microsoft Alias: atsenthi

Thanks for the question. We are currently investigating and will update you shortly.

For production workloads it is best practice to use ARM templates to manage just about every aspect of your cluster. You can do some of the upgrades via Azure portal as well as ARM. Portal is for Service Fabric Dev\Test scenario's only.
Please refer to the following documents which talk more about the upgrades. Let me know if you have any questions.
https://docs.microsoft.com/en-us/azure/service-fabric/service-fabric-cluster-config-upgrade-azure
https://docs.microsoft.com/en-us/azure/service-fabric/service-fabric-visualstudio-configure-upgrade

We will now close this issue. If there are further questions regarding this matter, please tag me in a comment. I will reopen it and we will gladly continue the discussion.


Github releases API does not provide the latest toolchain version information

I came here because of https://github.com/esp-rs/esp-hal/pull/2615, which sets the MSRV to 1.83. XTENSA_RUST_LATEST_API_URL in https://docs.rs/espup/0.14.0/src/espup/toolchain/rust.rs.html is https://api.github.com/repos/esp-rs/rust-build/releases/latest, from which v<IP_ADDRESS> is read instead of the newest v<IP_ADDRESS>.
This issue should be closed as soon as the current problem is fixed.

Oh no, I justed tried to compile a project based on the latest release version (0.22) of esp-hal after failing to make the git version of the wifi station example working (cannot connect to the AP), but it failed to build xtensa-lx-rt crate. The current git version of xtensa-lx-rt includes fixes for the newest toolchain (https://github.com/esp-rs/esp-hal/pull/2615), but it's unreleased.
I think you're doing the right thing to prvent most users from downloading the newest toolchain. Closing this issue.


KDL 2.0 compliance

KDL 2.0.0-draft.3 is now generally available (https://github.com/kdl-org/kdl/pull/286), and with it, we've decided to encourage existing implementations to start working towards 2.0 support and send feedback and suggestions for anything you might run into, so I'm making this tracking issue. :)

I have had a larger update planned for this library that I never got around to finishing unfortunately, but once I have some free time soon I will resume work on it and take the opportunity to upgrade to KDL 2.0 👍

KDL 2.0.0 has been released (https://github.com/kdl-org/kdl/releases/tag/2.0.0)!


Fix no results for the hit widget

Can you ammend commit first line to follow conventional changelog? (https://github.com/algolia/instantsearch.js/blob/develop/CONTRIBUTING.md)
feat(hits): pass the full results to the noResultsTemplate

You'll get used to it :)

Good ?

Good ?

better with full sentence ;) "no results" isn't very explicit

Sure :smile:


Update contract naming scheme.

We should migrate to a more consistent contract naming scheme.
Discussed in the discord, let's do cw-dao-<module_type>-<module_description>. For example, cw-proposal-single would change to cw-dao-proposal-single and cw20-staked-balances-voting to cw-dao-voting-cw20-staking. As part of this work, lets also move all of the proposal and voting modules to their own proposal-modules and voting-modules subfolders in contracts/. We can put READMEs in those subfolders explaining what the modules are and how they work.
Once we do this we will be ready to release these contracts on crates.io.

This will need to be the last step before we release v2. Otherwise, the rebase here is going to be insane.

https://github.com/DA0-DA0/dao-contracts/pull/497


Document pdfjs-dist/webpack

The current webpack example makes no mention of this as an option or how to correctly use it with worker loader. Instead, I only found it by looking at this comment: https://github.com/mozilla/pdf.js/issues/7612#issuecomment-315180521

I would like to take a look at this, it's my first time trying to contribute to an open source project

Exactly. I think a solution for this would be to extend https://github.com/mozilla/pdf.js/blob/master/examples/webpack/README.md with information about pdfjs-dist/webpack.

Just to clarify, what I get from this is that if you are using webpack, you should import PDF.js this way:
import * as pdfjsLib from 'pdfjs-dist/webpack';

instead of
import * as pdfjsLib from 'pdfjs-dist';

I was half-considering not coming back to my job and changing my name before I stumbled on this! Almost lost a full day of work on this...

Would be great to have documentation also on how to use built-in viewer with Webpack.


Timestamps and TOC updated only on grunt build

I've noticed @@timestamp and @@toc are only updated on grunt build but not when running watch tasks. This means that unless grunt build is run afterwards you will end with these placeholders. Is this intentional? Thanks

As far as I can tell, this is intentional, as grunt build runs every time a commit is deployed to previewized server.

Thanks!


Per container disk limits

It would be nice to have the option to limit container disk usage. In some cases programs in containers may cause gradually growing disk usage, which may eventually cause issues for other containers. Being able to impose constraints on disk usage per container helps isolate containers from one another and makes it easy to make the most efficient use of existing disk space in a predictable way.
LXD has this feature available so it would just be a matter of exposing the option in the Bravefile service section.
It could look something like this:
service:
    name: example-service
    resources:
        ram: 4GB
        cpu: 4
        disk: 2GB

Adding this field would not affect existing Bravefiles, since if the field is not specified no limits will be imposed, just as it currently behaves.

Implemented in https://github.com/bravetools/bravetools/pull/255


Feature Suggestion: Please add RC4 encryption

Hello could you please add RC4 encryption. I can appreciate your previous concerns for encryption in rattlegram but due to RC4's vulnerability think of it more like a dialect with extra steps. Thanks in advance.

Duplicate of #11


使用 --fork 选项不可以启动容器

报错
Error: failed to start container "coredns": Error response from daemon: OCI runtime create failed: container_linux.go:345: starting container process caused "exec: \"sh\": executable file not found in $PATH": unknown

对于这种容器是不是无解 。。。

AFAIK, there is no general way to keep the process 1 running in a distroless container. I don't know if there are other solutions by far.

Will providing an option to specify the start command of the forked container be helpful?


show stderr and auto scale in CTIS dashboard

closes #1019, closes #1023
Prerequisites:

[x] Unless it is a hotfix it should be merged against the dev branch
[x] Branch is up-to-date with the branch to be merged with, i.e. dev
[x] Build is successful
[x] Code is cleaned up and formatted

Summary

@ryantibs since you are testing the PR, please also comment here, on any changes that you would like to see.

Thanks!  I'd like to see:

Survey dashboard plot titles restored to what they are in the current live version.
Rescale Y-axis" toggle to say "Include 0 in Y-axis", and then set it to be "off" by default. (Same effective behavior, just different name---I'm open to tweak for the new name as well.)
Y-range to be properly computed always, there are currently bugs (as in #1023).

It's possible I'd like to see more.  I am working through several thoughts on related things now as I start looking at the dashboard and main viz site more.  @sgratzl: Would you like me to also comment on those on this PR?  Or somewhere else?

@sgratzl Ok so I think I'll save the other major things I'd like to see changed for a different conversation (I'll write it up in a google doc as we discussed).
Here's one more small thing though for the CTIS dashboard.  Where it says: The 7-day average of "Went to Work or School" on 09/24/2021 is based on 180,890 samples with a standard error of ±0.1. It was published on 09/26/2021.
I'd like to remove the part that reports the standard error here; it's already visible in the figure and it seems like a strange choice to display it there in this sentence anyway, where there is no reference to the value of the signal itself.

and 5. should be implemented. I extracted the rest to new issues, since they are not directly related to the issue #1019 which is the base of this PR

Whitespace -- "Include 0 in Y-axis" label is closer to the toggle for Raw Data than to its own toggle

re styling:

@krivard I'm looking at the CTIS dashboard now and notice that this still hasn't been ported over to the live version.  Is that because we are waiting to launch all the new changes to the dashboards at once?  (Sam is still working on things for the main COVIDcast dashboard, but that's nothing to do with the CTIS dashboard AFAIK?)


[improvement] Publish separate package

Looks like a copypaste and republishing of network_info_plus package
What about support consistency between this package and network_info_plus?
What about publishing a separate package? like https://pub.dev/packages/network_info_plus_macos
App developer:

install network_info_plus
install network_info_plus_apple_tv - package over the network_info_plus?

Currently, pub.dev package looks dirty.

Should be implemented as https://pub.dev/packages/package_info_plus_tizen until Flutter provided support of all needed platforms


Add NTP as dependency

In order to keep the system in sync with the s3 service to avoid synchronization errors.

Done!


Revert "use dart default line length (80 chars)"

Reverts bmw-tech/widget_driver#82
We decided to stick to the 120 line length and sacrifice 10 points in our pub.dev scores, since with default value readability became worse.

Should we also make a not in changelogs? And bump version numbers? Or that is not needed?

it's not needed from my POV


Implement dynamic scaling based on consumer lag

Fixes #33

This currently does not pass tests due to hardcoded kafka:9092

Rebased, make tests pass if running against local kafka.
Ready for review

not sure if you've already looked at these examples @garyrussell created in his sandbox repo...
using boot:
https://github.com/garyrussell/sandbox/blob/master/consumer-offsets-boot15/src/main/java/com/example/ConsumerOffsetsBoot15Application.java
lower-level:
https://github.com/garyrussell/sandbox/blob/master/consumer-offsets/src/main/java/com/example/ConsumerOffsetsApplication.java

Interesting. I originally thought about looking at the internal offset tracking topic but somehow disregarded that as no-one mentioned that as a viable solution. Seems like the most elegant solution

my mistake for not emphasizing it more I guess, but when we first discussed this I had mentioned my PoC using the offset topic... Gary pushed those projects to his sandbox at that time
we also briefly discussed the idea of a Flux consumer on the offset topic where we could determine scaling based on windowed operations, but that's something to revisit once we get the simple case in place (can probably think about this at the partition level initially though)
also worth a look: https://github.com/linkedin/Burrow

Yeah, when I reached out to Gary he showed me something, but that wasn't that at all (creating a Process that invoked kafka-consumer-groups and reading stdout! ).
I was gonna say that we shouldn't make this too smart while it's in java, because this would hinder our port to Go, but Burrow may be exactly what we need.
Will first rework the java version, hopefully in time for our 4:30 call

awesome!

I have discovered that the lag is made available via JMX and also by the consumer metrics() API...

tags={client-id=consumer-1}]=org.apache.kafka.common.metrics.KafkaMetric@3a407b47, MetricName [name=rjug-0.records-lag, group=consumer-fetch-manager-metrics, description=The latest lag of the partition,

average and max lag are also available

The getter was never called
Le 27 oct. 2017 7:02 PM, "Mark Fisher"<EMAIL_ADDRESS>a écrit :

@markfisher commented on this pull request.
In event-dispatcher/src/main/java/io/sk8s/event/dispatcher/
EventDispatcherProperties.java
https://github.com/markfisher/sk8s/pull/41#discussion_r147463562:

@@ -24,18 +24,8 @@
@ConfigurationProperties(prefix = "sk8s.event.dispatcher")
public class EventDispatcherProperties {

private String namespace = "default";

I believe @freynca https://github.com/freynca is depending on the
namespace being configurable.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/markfisher/sk8s/pull/41#pullrequestreview-72568330,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AATIlilKldQCJIMYqdavSUBVwY3yIpUmks5swgw3gaJpZM4P4uim
.

The déployer creates ressources in the same NS as the function
Le 27 oct. 2017 7:02 PM, "Mark Fisher"<EMAIL_ADDRESS>a écrit :

@markfisher commented on this pull request.
In event-dispatcher/src/main/java/io/sk8s/event/dispatcher/
EventDispatcherProperties.java
https://github.com/markfisher/sk8s/pull/41#discussion_r147463562:

@@ -24,18 +24,8 @@
@ConfigurationProperties(prefix = "sk8s.event.dispatcher")
public class EventDispatcherProperties {

private String namespace = "default";

I believe @freynca https://github.com/freynca is depending on the
namespace being configurable.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/markfisher/sk8s/pull/41#pullrequestreview-72568330,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AATIlilKldQCJIMYqdavSUBVwY3yIpUmks5swgw3gaJpZM4P4uim
.

The NS of what ? If you create a FN in the foo NS (using kubectl or our
cli), then it will create its pods in the foo NS
Le 27 oct. 2017 7:17 PM, "Felix Reyn"<EMAIL_ADDRESS>a écrit :

@freynca commented on this pull request.
In event-dispatcher/src/main/java/io/sk8s/event/dispatcher/
EventDispatcherProperties.java
https://github.com/markfisher/sk8s/pull/41#discussion_r147467343:

@@ -24,18 +24,8 @@
@ConfigurationProperties(prefix = "sk8s.event.dispatcher")
public class EventDispatcherProperties {

private String namespace = "default";

The namespace should absolutely be configurable
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/markfisher/sk8s/pull/41#discussion_r147467343, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AATIlvoDLKxyZZgk4SbCNAiq8Ew3fyneks5swhA9gaJpZM4P4uim
.

squashed and merged as https://github.com/markfisher/sk8s/commit/cf1163a5fe6a0b0e4d00690c14ec01ac1987a385


Update period to dash for action names with MD5

Need to update overload function ids which have MD5 hash appended to them. Change the "." before the hash to "-" and then append the hash.

@darrelmiller, can you confirm if this quick fix unblocks your scenarios?

Will do.

@madansr7 @xuzhg   That helps a whole lot.  It's not ideal, but definitely better.   What would be much better is if we only included the MD5 if there was a duplicate.  I realize that is likely much harder to do.

AFAIK, that's how it works today. MD5 is used only for the overloads.
@xuzhg , can you please confirm.

From the screenshot above it appears that there is only one function called Get-ReportEmailActivityCount.  However, there are two functions called Get-ReportEmailActivityUserDetail.  I suspect that all functions with parameters are getting the MD5 hash.

Fixed and merged at https://github.com/microsoft/OpenAPI.NET.OData/commit/6377ee0d470b0c6de78222f3a90ea3a36414b541


[medViewContainer] enhance settings buttons

An enhancement for medViewContainer: move the split-4 and Hist button in the "settings" button, and move the Scene button in the bar (where split-4 was for instance). Indeed, in "settings" there are already splits buttons, and Hist is not so much used (and misclicks are horrible for these 2 buttons), and we have already an "Import scene" button into the view, but the "Export scene" button is hidden.
What do you think?

Seen with @LoicCadour , i'll do my best ^^


device: add api to check if device initialized or not

Add api to check if device initialized success or not and
power management will create device list based on this API.
Fixes: #24750
Signed-off-by: Wentong Wu<EMAIL_ADDRESS>

The only failed case is not related to this PR, re-tun CI
2/2 qemu_x86_64               tests/drivers/ipm/peripheral.mailbox               FAILED: timeout
-------------out-3nd-pass/qemu_x86_64/tests/drivers/ipm/peripheral.mailbox/handler.log--------------
cSeaBIOS (version rel-1.12.1-0-ga5cab58e9a3f-prebuilt.qemu.org)
Booting from ROM..***** Booting Zephyr OS v1.14.2-1-gad387464460f *****
starting test - Test IPM
ipm_recv0: 'everything is awesome'
ipm_recv0: 'Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor '
ipm_recv0: 'incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nosASSERTION FAIL [z_spin_lock_valid(l)] @ ../../../../../../include/spinlock.h:95
	Recursive spinlock
*** FATAL ERROR vector 6661 code 1016
***  RIP 8:0x100dc7 RSP 16:0x105908 RFLAGS 0x2
***  RAX 0x105017 RCX 0xa RDX 0x3f8 RSI 0x5f RDI 0x104fc9
***  R8 0xffffffff R9 0x0 R10 0x0 R11 0x0
-------------out-3nd-pass/qemu_x86_64/tests/drivers/ipm/peripheral.mailbox/handler.log--------------
1 of 2 tests passed with 0 warnings in 70 seconds

why is this against the 1.4 branch and not master?

why is this against the 1.4 branch and not master?

@andrewboie @pabigot because master is doing the refactor of device module and also PM module. Thanks

I am not commenting the bug and the fix itself, but there is no need to add an API for a bug fix. Just check device->driver_api pointer where relevant directly (as it is being done in various places). It's not "nice" indeed, but adding an API won't fit with 1.14 maintenance I think.


WIP: Compliments - Advice API Update

Did some more testing locally and this works now!
Just add:
config: {
  advice: true
}

to the compliments section of the config and the following will happen:
It makes a request to the API, previously it was just returning 1 random piece of advice, which is not ideal if you're trying to loop through them over time.
So this update changes things so I make a simple query, enough to return many results (in this case simply for 'a'). And then filter for pieces of advice less than 30 characters. This is then put in the anytime object key and written over the compliments object resulting in the advice array being displayed.
I will make a PR to the docs repo shortly @MichMich

Warnings

:warning:

Please include an updated CHANGELOG.md file.This way we can keep track of all the contributions.

  Generated by :no_entry_sign: dangerJS

Why overwrite the config? Shouldnt i bei able to add more than one source of compliments to the Array?

What do you mean overwrite the config? No config gets overwritten. Just the object which contains the original compliments. If yuo set advice back to false and restart you'll be back to normal.

What do you mean overwrite the config? No config gets overwritten. Just the object which contains the original compliments themselves. If yuo set advice back to false and restart you'll be back to normal.

yeah, thats not good that the advices overwrite all other compliments. They should all be displayed and not depend on advice being set to false. For example I might want to show an advice anytime but in the evening also some other compliments. With your code that is not possible at the moment anymore

Well advice defaults to false, I pictured it as being like an optional different mode for the compliment module, either you can run it normally in "compliment mode" - no action required. Or if you want to get these advice lines, you set advice: true and you're in "advice mode".
I can just push the pieces of advice onto the anytime array though if you guys would rather have it that way. No problem.
And yeah I have some experience writing tests, let me take a look when I get back home to a computer.

yeah, thats not good that the advices overwrite all other compliments. They should all be displayed and not depend on advice being set to false. For example I might want to show an advice anytime but in the evening also some other compliments. With your code that is not possible at the moment anymore

I agree with this observation, it was more useful for the advice to appear randomly with compliments

Okay so I initially wrote it in vim and it was using spaces instead of tabs. VS Code picked up on this projects tab settings and fixed all that. Also I adjusted the core code to append the pieces of advice to the anytime array. That all seems to work well.
Then I began on the tests. I got it mostly setup afaik, including the mocking results. However, I couldn't get the actual spec test to work. If someone could take a look, I'm not super familiar with mocha so I'm probably just missing something simple. Happening at the bottom of /tests/e2e/modules/compliments_spec.js.
Thanks!

Same error as in #2021
Then:
Uncaught (in promise) TypeError: Cannot use 'in' operator to search for 'currentweather' in Some of life's best lessons are learnt at the worst times.
Now:
Uncaught (in promise) TypeError: Cannot use 'in' operator to search for 'currentweather' in Remember that spiders are more afraid of you, than you are of them.

Same error as in #2021
Then:
Uncaught (in promise) TypeError: Cannot use 'in' operator to search for 'currentweather' in Some of life's best lessons are learnt at the worst times.
Now:
Uncaught (in promise) TypeError: Cannot use 'in' operator to search for 'currentweather' in Remember that spiders are more afraid of you, than you are of them.

For context, the trace included:
if (this.currentWeatherType in this.config.compliments) {
	compliments.push.apply(compliments, this.config.compliments[this.currentWeatherType]);
}

Im not familiar with this if (... in ...)  syntax, but doesnt sound like you have the newest version either because the pieces of advice themselves are no longer directly in the compliments object, but in the anytime key of the compliments object. This should simply return false and continue on as far as I can tell..

but doesnt sound like you have the newest version either

The thing is: your PR here @ndom91 isnt yet merged in to develop. But develop technically is the "newest" version for developers. So in order to get it merged (and those errors fixed) this PR needs to get in good shape. Next step would be to fix those merge-conflicts, then tackle the test suite.

but doesnt sound like you have the newest version either

The thing is: your PR here @ndom91 isnt yet merged in to develop. But develop technically is the "newest" version for developers. So in order to get it merged (and those errors fixed) this PR needs to get in good shape. Next step would be to fix those merge-conflicts, then tackle the test suite.

Yeah I just meant it doesnt sound like he had the newest version of this branch, because he was specifically mentioning behavior regarding this advice stuff.
Anyway, I cleared up the conflicts now.

Hi @ndom91, what's the status of this PR? Travis is failing, so I can't merge it.

@MichMich Okay so I fixed that specific issue, but I'm still having trouble getting it to accept my mock data. I am basically doing the same thing that is being done with the weather module, to mock data normally gathered from a REST call, and for some reason it doesn't seem to get in there..
If anyone has some time, can they please take a look at: https://github.com/ndom91/MagicMirror/blob/964b92116e170905ba0f4e655b01ea1225fc4d31/tests/e2e/modules/compliments_spec.js#L155-L156

Not sure what's going on. It also gives some type lint errors. Does this PR fix any current issues with the new advice API? Otherwise I have to revert the Advice implementation altogether since the next master release is planned for 1st of July.

@MichMich no unfortunately I couldn't get the testing working. This was just a little fun addition anyway. No worries if we just revert this all together. Ya win some, ya lose some

I'll try to take a look at the tests this afternoon. I like the idea and would be sad to see it removed :-)

I've reverted the initial implementation of the Advice implementation. Feel free to send a new PR with the full implementation including tests. Just to be sure I won't be merging it before the upcoming release.

bad option anyway


A related tool

Hey @krystalgamer, thanks for your work, I already used the emulator and it worked perfectly.
This might seem like self promotion but I just wanted to tell you about a "follow-up" tool I made: https://github.com/nnmrts/merge-stems
I also wrote you on reddit about this. I also tried to make a post on reddit about it but the subreddit doesn't allow me to post for some reason. Would be nice if you could tell people about it in your readme or your reddit post or somewhere else, I just want the /r/Kanye community to know about it before they all have to merge their stems themselves.
Cheers!

I've checked your post on reddit and it's on moderator approval mode. As you might guess ye related subreddits have been flooded with people asking and begging for download links. Just wait a little someone will approve it.
I deliberately avoided anything related to merging stems because that would mean I'd have to give some kind of support. What I've been suggesting to people that ask me is either use audacity or use sox, both tools are simple enough that it's pretty hard to mess up.
I've taken a look at your tool and it seems to be a ffmpeg wrapper and the file size is quite large for such a small use-case, for reference sox is only 2Mb on windows. I don't think it's up to me to market the tool, you could easily do that by forwarding people to it when you see someone asking how to merge the stems.

I'll delete this since the user in question has been quite rude in DMs and is mad at me for his post getting blocked on a subreddit which I have no power in.


How to integrate own custom controllers?

Any wiki? As I see i have to implement initWithProps.. and performAction.. but also modify code RCCViewController.controllerWithLayout ? Looks strange, because it will require fork.

I've added custom controller successfully, but a lot of files were changed, so now i stuck to forked version of this great component. Let me know is there any plans to improve integration.

@aksonov a wiki is on the agenda. Also, this feature is implemented (partially) and we will provide an explanation and examples on how to do it.
As a side note, this is the downside of forks - you can get left behind :wink:

currently we have a kinda undocumented feature that we use in our project that allows you to add any external view controller as a child view controller.
You can use it when pushing or showing a modal, for example, by specifying your native class name and optional props that you want to pass to it:
externalNativeScreenClass: 'MyViewController',
externalNativeScreenProps: {}

The downside to this approach is that you still need a React component for this screen because it is added to an existing RCCViewController, meaning the external native view-controller "takes over" this component. So effectively the React component render does nothing since you can't actually see it.. but other logic like that communicates with your external screen (the RN native interface between this screen and your component) can still go there.
You can see an example for this feature using react-native-navigation here: https://github.com/wix/react-native-wordpress-editor

After the merge with react-native-navigation we nee to make sure parity with Android. See here: https://github.com/wix/react-native-navigation/issues/235


MultipleUniqueKeyFoundException for string primary key

Hi,
Awesome effort and library!
We are experiencing issue with database tables which has string primary keys with data which is different only by case sensitive which is not working for in memory scenario:
    public void Insert(TKey key, TEntity entity)
    {
        if (this.inner.ContainsKey(key))
        {
            throw new MultipleUniqueKeyFoundException();
        }
        else
        {
            this.inner.Add(key, entity);
        }

        this.Count++;
    }

Any ideas on how this could be fixed?

Hi,
Yes, capability for being case insensitive has been requested long ago. Unfortunately this would require deep architectural changes that I probably will not have resources for.

https://github.com/tamasflamich/nmemory/issues/6


Default Initializer for RxTableViewSectionedReloadDataSource does not exist

The default initializer for RxTableViewSectionedReloadDataSource does not exist. The initializer takes in arguments which is not mentioned in the docs.

I think there is no default initializer because configureCell is required.
In this section, we can see that configureCell is a required argument and the remaining arguements are optional.
https://github.com/RxSwiftCommunity/RxDataSources#how

Customize closures on the dataSource as needed:

configureCell (required)
titleForHeaderInSection
titleForFooterInSection
etc

dataSource.configureCell = { (ds: RxTableViewSectionedReloadDataSource<SectionOfCustomData>, tv: UITableView, ip: IndexPath, item: Item) in
  let cell = tv.dequeueReusableCell(withIdentifier: "Cell", for: ip)
  cell.textLabel?.text = "Item \(item.anInt): \(item.aString) - \(item.aCGPoint.x):\(item.aCGPoint.y)"
  return cell
}
dataSource.titleForHeaderInSection = { ds, index in
  return ds.sectionModels[index].header
}

The issue is to the point. This is from the README.md:
let dataSource = RxTableViewSectionedReloadDataSource<SectionModel<String, Int>>()
Observable.just([SectionModel(model: "title", items: [1, 2, 3])])
    .bind(to: tableView.rx.items(dataSource: dataSource))
    .disposed(by: disposeBag)

I think we need to update the documentation.

@mkko Great point here - the documentation here wasn't updated for too long with the change to requesting the configureCell closure on the data source's initialization. If anyone would like to make a PR around this, I'd love to review and merge. Thanks!

#255 address the issue.


Pin the ohai definition to use the ohai version from Gemfile.lock

Without this we end up with chef-client's definition using the version
of ohai in the gemfile.lock and the ohai defintion using whatever is in
master. This is bad for two reasons:

we're shipping an unreleased master version even when we ship chef 13
or chef 14
we ship the ohai gem twice which takes up space on disk

Signed-off-by: Tim Smith<EMAIL_ADDRESS>

if it builds correctly, ship it...  we may still wind up with transitive dep double-gems but if we're bumping both Gemfile.lock's constantly them maybe its not going to be a practical issue...


[Ben] add job allows empty description

not sure if this is intended
but it d/ is mandatory, does not make sense to have an empty description right


EntityQueryDynamicReturnTypeExtension: use while on chained methods in execute

In EntityQueryDynamicReturnTypeExtension we check for various instances. If any fail, we could try what phpstan-doctrine does by using a while loop to find the root.
See https://github.com/phpstan/phpstan-doctrine/blob/1.3.x/src/Type/Doctrine/DBAL/QueryBuilder/QueryBuilderExecuteMethodExtension.php#L46

I don't think we need this anymore.


[Event Request] Codeunit 12 "Gen. Jnl.-Post Line" - OnAfterInitCustLedgEntry

Hi, would it be possible to modify the OnAfterInitCustLedgEntry event in codeunit 12 (Gen. Jnl.-Post Line) by adding the GLReg parameter, like this:
    local procedure InitCustLedgEntry(GenJnlLine: Record "Gen. Journal Line"; var CustLedgEntry: Record "Cust. Ledger Entry")
    begin
        OnBeforeInitCustLedgEntry(CustLedgEntry, GenJnlLine);

        CustLedgEntry.Init();
        CustLedgEntry.CopyFromGenJnlLine(GenJnlLine);
        CustLedgEntry."Entry No." := NextEntryNo;
        CustLedgEntry."Transaction No." := NextTransactionNo;

        // New Event begin
        // OnAfterInitCustLedgEntry(CustLedgEntry, GenJnlLine);
        OnAfterInitCustLedgEntry(CustLedgEntry, GenJnlLine, GLReg);
        // New Event end
    end;

    [IntegrationEvent(false, false)]
    local procedure OnAfterInitCustLedgEntry(var CustLedgerEntry: Record "Cust. Ledger Entry"; GenJournalLine: Record "Gen. Journal Line"; GLReg: Record "G/L Register")
    begin
    end;

#19267
Thanks!

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 44163.


Placeholders

This PR is based on the conversations we had in our meeting last week. Dan wanted placeholder chapters before providing the link to students. I also reordered chapters based on the discussion we had last week.

Cool. So what's the plan for chapter 9, moved to 09_old?

The plan is to incorporate that material into one of the other chapters so I didn't want to get rid of it yet, but eventually we will delete those files. We will be working on reincorporating that over the next week or so


TypeError: gdbm key must be string, not unicode

The last dev gave me this weird error.
2016-08-25 18:17:23,739 [       cli] [INFO] PokemonGO Bot v1.0
2016-08-25 18:17:23,748 [       cli] [INFO] commit: 5e50264e7644b007dff7e0e057375cc433c36805
2016-08-25 18:17:23,751 [       cli] [INFO] Configuration initialized
Traceback (most recent call last):
File "pokecli.py", line 705, in
main()
File "pokecli.py", line 103, in main
bot = PokemonGoBot(config)
File "/Users/me/Documents/Pokebot/3_PokemonGo-Bot/pokemongo_bot/init.py", line 106, in init
if saved_info.has_key('client_id'):
File "/usr/local/Cellar/python/2.7.11/Frameworks/Python.framework/Versions/2.7/lib/python2.7/shelve.py", line 107, in has_key
return key in self.dict
TypeError: gdbm key must be string, not unicode
Any idea?

#4741 Looks like a lot of people are getting this at the moment (including me)

Hello me too :(


Canceling "clear" - unexpectedly clears the document anyway

It seems that there's a "safari only" feature (doesn't show in Chrome) that shows a "clear"/eraser button at the top of the screen - when clicked a prompt is shown with "Are you sure you want to close this file? Unsaved changes will be lost." [ok] or [cancel].
You'd expect that "cancel" would dismiss the prompt and allow you to keep editing your existing document in the background/behind the prompt.... but it doesn't, "cancel" does the same as "ok" and closes the doc showing the homescreen again.

[ ] change cancel to just dismiss the prompt dialog returning the user to their current doc

Version: v3.1.16
Tested at: https://md.nico.dev/

Hi @mountainash
Thanks for pointing that out!
I just fixed it with v3.1.17


[libxlsxwriter] Fix link zlib

Fix ZLib usage in pkg config file.

@damuellen Please add port-version.

Done.

Build #20230504.36 failed
I don't know what to change to fix the error.

t. The best solution is to do a patch which uses Requires.private: zlib instead. And once we are patching, we can also devendor minizip.

Implemented in #31262.
However the minizip port is currently marked as unsupported on uwp. I try to remove the restriction, #31261.

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

@dg0yt PR https://github.com/microsoft/vcpkg/pull/31262 is probably the better solution. I close mine.


fix(ingestion): don't dump variables for config errors

Checklist

[x] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable)

I was able to verify that it works locally - made one of the config validators throw an exception to test it.
However I think the approach is a bit ugly (particularly the SensitiveError.get_sensitive_cause() method) so open to suggestions/improvements


Migrate from Baseman to Cartopy Transforms

Some modules rely on Basemap for Map transform. Although Cartopy has an asymmetric API for transforms, one should move away from Basemap because it is no longer actively maintained.

Replaced baseman in mcd43.py


Migrate CircleCI release pipelines to GitHub

Summary
We will move CircleCI pipelines to Github Actions to fix race condition. Since we stop supporting CircleCI, we are migrating existing pipelines to Github Actions.
This PR contains migration of release pipelines.
Ticket Link
https://mattermost.atlassian.net/browse/CLD-3709
Failing CircleCI checks
Please ignore CircleCI checks, there is no circle pipeline configured in PR that causes builds to fail in CircleCI. That is because project is enabled in CircleCI.
After merging this PR to master we will disable builds at CircleCI.

I guess we need to disable CircleCI pipelines, to be able to merge this.

I guess we need to disable CircleCI pipelines, to be able to merge this.

Those checks are created automatically by CircleCI since this PR has no configuration. We can not disable circleci without merging this PR. (master still has circle-ci.yml and we need those pipelines to create releases until this pr is merged).
Will disable circleci integration after merging.

https://github.com/mattermost/mattermost-helm/pull/360#discussion_r940280062
@spirosoik
Do check the proposal here: https://github.com/mattermost/mattermost-helm/pull/360#discussion_r940317891
I would strongly suggest rethinking using Makefiles binded with bash scripts committed to repos codebase, to build/release software.


What is the exact protocol between docker engine and auth server?

What is the exact protocol between the docker engine and auth server?Is the HTTP or HTTPS?
As  the .yml file describes below:
#  auth:
#    token:
#      realm: "https://<IP_ADDRESS>:5001/auth"
#      service: "Docker registry"
#      issuer: "Acme auth server"
#      rootcertbundle: "/path/to/server.pem"

From the realm: "https://<IP_ADDRESS>:5001/auth" ,I know it is using HTTPS protocol!
But the question is that:
Now that we are using HTTPS protocol,where is the certificate and key on the side of auth server,and where is root certificate on the side of docker engine?

registry does not actually talk directly to the server. it sends the user to a particular server to obtain a token, which the user then sends to the registry. registry will verify it using the specified root bundle.
https connections are between the user and the auth server.
for more details, read the protocol spec here

Yes,I do know that  https connections are between the user and the auth server.So my question is where is the certificate and key on the side of auth server,and where is root certificate on the side of docker client?
you may not get my point! @rojer

cert and key on the auth server side are configured in, server.certificate and server.key. funny, i know. whoddathunk.
docker client uses system root ca store to verify.

As you said above,if auth server uses a self signed certificate, and docker client uses system root ca to verify, the result on the side of docker will be refused!
But my test shows the actual result is successful! I can normally use the docker,auth server and Registry v2!

i would hope that docker client does use cert verification when connecting, but have not actually tested it.
if you are working in an organization, it could also be that you have an org-wide CA installed on the workstations.
you can test SSL/TLS with e.g. curl -v or openssl s_client and check what cert is presented and if it is verified by your client.

thanks @rojer , My test shows that the docker client verify only in some situation.
If i use HTTPS protocol between the docker client and Registry v2, then docker client will verify!
If i use HTTP protocol between the docker client and Registry v2,then docker client will not verify!

there is nothing ti verify in the case of plain HTTP, so this is WAI.

@rojer I mean use HTTP

i'm not sure, but never mind.
i use https everywhere and everyone else should too.

Anyway,thankyou! @rojer

Anyway,thankyou! @rojer


Role claims

issues #127 , #122

This pull request is now managed with CodeReviewHub. Refresh.


Suppres of elements fails with ifTrue ifFalse was send to nil

This is an error in Release 1.3.2
RWDiagram automaticTestIsRunning returned nil when no automatic tests ever did run

It is corrected in the Smalltalk Hub Repository. The scripts do distribute will also include this fix.


Handle a private page better

At the moment a private page shows the user's display name (that's fine) but it shows the page as if the user doesn't have any data. Instead we want to pick and choose what to show based on the privacy setting of the user.

Oh wait! You don't even get access to a user's page if you're not allowed to see it - the above view was for an admin user.


dirSelectable: false, but still get the children

If I want to open the directory on single click, I have to set dirSelectable to false. Doing so stops my access to the children of the selected directory because 'on-selection' event is not fired.
Is it possible to not allow selection of directory, but still be able to get the children?
My scenarios is, when a directory is clicked, I show all of its children in a table. If I set dirSelectable to false, then I don't have access to the children to show.

go to angular-tree-control.js and change <div class="tree-label {{options.labelClass}}" ng-class="[selectedClass(), unselectableClass()]" ng-click="selectNodeHead(node)"


Different between processInTransactionAsync and beginTransactionAsync

DBFlow Version:
Description:
Hi! Could you explain me next situation:
I tried to ways to update my tables:
`
@Table(database = CityDatabase::class, name = StopData.TABLE_NAME)
class StopData : BaseModel() {
companion object {
const val TABLE_NAME = "Stops"
}
@Index
@Column
@PrimaryKey
@Unique(onUniqueConflict = ConflictAction.REPLACE)
var id = EMPTY_LONG

@Column
var latitude = EMPTY_DOUBLE
@Column
var longitude = EMPTY_DOUBLE
@Column
var name = EMPTY_STRING

@get: OneToMany(methods = arrayOf(OneToMany.Method.ALL))
var stopRoutes: List<StopRoutesData>? by oneToMany { select from StopRoutesData::class where (StopRoutesData_Table.stopId.eq(id)) }

stops: List<StopData> - not empty
            stops.processInTransactionAsync(
                    { stopData, databaseWrapper -> stopData.insert(databaseWrapper) },
                    Transaction.Success { },
                    Transaction.Error { transaction, error ->
                        transaction.cancel()
                    }
            )

and
database<CityDatabase>().beginTransactionAsync(object : ITransaction {
                override fun execute(databaseWrapper: DatabaseWrapper) {
                    stops.fastInsert()
                }
            }).build().execute()

And in the first variant my datas saved successfully,  but second variant didn't save my datas. What I missed?
And could you provide fast insert example with relationships ?

@ukevgen did you find the answer?

processInTransactionAsync is removed in 5.0.0-alpha1. beginTransactionAsync starts a Transaction.Builder but you need to explicitly execute() it.

stops.fastInsert() creates a FastStoreModelTransaction.Builder class, which does not actually execute the transaction yet. See this doc: https://dbflow.gitbook.io/dbflow/usage2/usage/storingdata#faststoremodeltransaction
still valid for 4.2.4, but in 5.0.0-alpha1 its the only way.


Add support for fastify

Added auto instrumentation for fastify framework https://www.fastify.io/. Issue: https://github.com/signalfx/signalfx-nodejs-tracing/issues/74

Hi @dbrixey, could you tell me if you're a customer of SignalFx / Splunk Observability (can be over e-mail, see my profile)? In the meantime I'll check if we can accept external contributions.

Answer sent over email

Hi @dbrixey, I talked to the team and it looks like we require a CLA to be signed https://www.splunk.com/en_us/form/contributions.html before we can accept your code. Let me know if that works for you.

We'll need to check with our Legal team before signing the CLA. I'll follow up with them and get back to you.
In the meantime can you update https://github.com/signalfx/signalfx-nodejs-tracing/blob/master/CONTRIBUTING.md to include the requirement to sign the CLA?

@dbrixey Any update on this? We're also looking for fastify support. Can we expect this PR to be merged soon or are we better off forking?

Hi @johanneslumpe, I can't merge dbrixey's PR without the CLA. I emailed you about possible alternative solutions. If it doesn't pan out, I'll reimplement dbrixey's PR to work around licensing issues.

@jtmalinowski I was exactly curious about the CLA. Great to hear though that this will go forward either way. Would another solution be to just cherry pick required commits from datadog’s library? They do have fastify support.

Yeah, we'll most likely do that, if the alternative I emailed you about doesn't work out.

Any updates on  this?

Because it is now official, I'd like to recommend https://github.com/signalfx/splunk-otel-js instead of signalfx-nodejs-tracing. It's more modern and it's designed to be more flexible. Fastify would be covered by https://opentelemetry.io/registry/?s=fastify&component=&language=, maybe you'll even be able to find more instrumentations you were missing. If you send me an email (address is in my profile), I can help with implementation. If you have reasons to keep using signalfx-nodejs-tracing, let me know and we'll move forward with this ticket.


fix: Issues Section

Description
This PR addresses 2 TODO items in #249 😄

[x] Add information about it, change the format in this section to undordered list, and adjust some wording for better read and understanding.

L29-40: Used ALERTS because suggested copy with ":::note text :::" was not rendering as alerts.

[x] Capitalize the "code of conduct" term in the last paragraph.

Noticed there was 2 "Code of Conduct" lines that were uncapitalized, so I did both

L20: Capitalization of "Code of Conduct"
L37: Capitalization of "Code of Conduct"

What type of PR is this? (check all applicable)

[ ] 🍕 Feature
[ ] 🐛 Bug Fix
[x] 📝 Documentation Update
[x] 🎨 Style
[ ] 🧑💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

Related Tickets & Documents
Fixes #249

Fixed in #269


Adding an extra repeater and builder header actions

[x] Changes have been thoroughly tested to not break existing functionality.
[x] New functionality has been documented or existing documentation has been updated to reflect changes.
[x] Visual changes are explained in the PR description using a screenshot/recording of before and after.

Same as modals have the ability to Adding an extra modal action button to the footer
The Result will be in:
Repeater

Builder

Duplicate of #8461 which will be released in 3.1

I tested that it did not work but my PR works well

What did not work

It's not released yet, so please fix that existing feature instead of adding it again

What did not work

After reviewing the code, I realized that there is a missing piece of code.
$this->registerActions([
    ...
    fn (Repeater $component): array => $component->getExtraItemActions(),
]);

You should not need to register the actions, because of how the actions are discovered using the HasHeaderActions interface

You should not need to register the actions, because of how the actions are discovered using the HasHeaderActions interface

before what I said before the ->requiresConfirmation() does not work for me


need to support wrap-around in text mode

In text mode, printing text that exceeds column 40 should wrap around. Instead, an exception is thrown because the print logic attempts to write past the buffer bounds.

Fixed in branch bc3-test.


Too many keybinding conflicts

So after logging in, I discovered there are way too many keybinding conflicts, many of which are not needed and can be optimized better.  Here is one possible setup to make it easier for the first time user.
A couple options you might consider, binding all tool selection changes to the same key so that when that tool is held, the action takes place.
Switching modes all to the same key, again should only affect the tool in hand.
The first image is of available keybindings with vanilla keys in Red
In the second image I've tried to show some suggested changes, and things to keep.  There are a number of purposed conflicts simply due to the fact that they perform a similar function.  For instance - everything involving a Helmet is relegated to "H" - since you can only wear one hat at a time. Also most of the inventory screens can be accessed from buttons on the inventory so they got either a (none) or E
Some testing obviously will need to be done as to which keybindings are effective, and which are not.  But this is hopefully a helpful start.

Loving the layout and excellent work.  Small suggestion, since it seemed to work on my other pack, inventory keys relegated to the number pad...

Here's the lastest edition of the keybinding setup.

Updated the options.txt here.  Will add the image when I get home and test keybindings then as well

I think once the new update is released we will have to go back and take another look at keybindings.

No problem, its pretty easy to update and change. I've kept every draft as a new page in publisher so far.

Excellent!  I will have more clarification this week and am planning an update withing the next day or so for you guys to test out.

http://www.keyboard-layout-editor.com/#/gists/971abdbcc65dc9fd1eb9
We should assign this mod to the github application list.

I think it is per user, and I have added it to my application list, still researching how we can merge this gist into this repository though

Options.txt: http://pastebin.com/q5DrERrZ
Now with more Colors! Updated to FallCraft 6.0.  If you'd like, I can start over with keyboard-layout-editor and figure out why it didn't save my original draft, and update it with FC mod keybindings.

It's super long, but here's the permalink to the vanilla keyboard layout.  Important to have a base without any mods to build from.
http://www.keyboard-layout-editor.com/##@@_c=#f51d2a;&=Esc

Menu&_x:1;&=F1
UI

Hide&=F2
Shot

Screen&=F3
ation

Inform&_c=#cccccc;&=F4&_x:0.5&c=#f51d2a;&=F5
pective

Pers&=F6
S/&S

Stream&=F7
Pause

Stream&_c=#cccccc;&=F8&_x:0.5&c=#f51d2a;&=F9

Chunk&_c=#cccccc;&=F10&_c=#f51d2a;&=F11
Screen

Full&_c=#cccccc;&=F12&_x:0.5;&=PrtSc&=Scroll Lock&=Pause
Break;&@_y:0.5;&=~
`&_c=#f51d2a;&=!
1&=/@
2&=#
3&=$
4&=%25
5&=^
6&=/&
7&=*
8&=(
9&_c=#cccccc;&=)
0&=/_
-&=+
/=&_w:2;&=Backspace&_x:0.5;&=Insert&=Home&=PgUp&_x:0.5;&=Num Lock&=//&=*&=-;&@_c=#f51d2a&w:1.5;&=Tab
Players

List&=Q
Item

Drop&_fa@:0&:0&:0&:0&:0&:0&:2;;&=W

Forward&_f:3;&=E
ory

Invent&_c=#cccccc;&=R&_c=#f51d2a&f:3;&=T
Chat

Open&_c=#cccccc;&=Y&=U&=I&=O&=P&={
[&=}
]&_w:1.5;&=|%0A&_x:0.5;&=Delete&=End&=PgDn&_x:0.5;&=7%0AHome&=8%0A%E2%86%91&=9%0APgUp&_h:2;&=+;&@_w:1.75;&=Caps%20Lock&_c=#f51d2a&f:3;&=A%0AStrafe%0A%0A%0A%0A%0ALeft&_f:3;&=S%0Awards%0A%0A%0A%0A%0ABack&_f:3;&=D%0AStrafe%0A%0A%0A%0A%0ARight&_c=#cccccc;&=F&=G&=H&=J&=K&=L&=/:%0A/;&=%22%0A%27&_w:2.25;&=Enter&_x:4;&=4%0A%E2%86%90&=5&=6%0A%E2%86%92;&@_f:3&w:2.25;&=Shift%0A%0A%0A%0A%0A%0ASneak&=Z&=X&=C&=V&=B&=N&=M&=%3C%0A,&=%3E%0A.&_c=#f51d2a&fa@:0&:0&:0&:0&:0&:0&:1;;&=Open%0A//%0A%0A%0A%0A%0ACommand&_c=#cccccc&w:2.75;&=Shift&_x:1.5;&=%E2%86%91&_x:1.5;&=1%0AEnd&=2%0A%E2%86%93&=3%0APgDn&_h:2;&=Enter;&@_c=#f51d2a&f:3&w:1.25;&=Ctrl%0A%0A%0A%0A%0A%0ASprint&_c=#cccccc&w:1.25;&=Win&_w:1.25;&=Alt&_c=#f51d2a&a:7&w:6.25;&=Jump&_c=#cccccc&a:4&w:1.25;&=Alt&_w:1.25;&=Win&_w:1.25;&=Menu&_w:1.25;&=Ctrl&_x:0.5;&=%E2%86%90&=%E2%86%93&=%E2%86%92&_x:0.5&w:2;&=0%0AIns&=.%0ADel;&@_c=#f51d2a&f:3;&=M1%0A%0A%0A%0A%0A%0AAttack&_f:3;&=M2%0APlace%0A%0A%0A%0A%0AUse&_f:3;&=M3%0ABlock%0A%0A%0A%0A%0APick

http://www.keyboard-layout-editor.com/#/gists/832b438909501253a832
Attempt #2 at vanilla layout

http://www.keyboard-layout-editor.com/#/gists/5c66886ed0284fd138aa
FC 6.0 layout using WASD keyboard color swatch

We will keep using this for any updates, but I updated the gist repository with all of the changes

So with the recent update, I noticed a couple of key conflicts, can we take a look and see if we can either make set them to none or find a new key? (I think they were related to flans)

Is there a conflict between Flans mode switch key, and control switch? If so, we could easily bind one to J, or comma.
Known conflicts include:
LControl: Sprint, Boost (IC2) , Down (Flans)
C: Mode Switch Key (Flans), Control Switch Key (Flans), Cycle Item Mode (CoFH)
Z: Special (Unknown), Zoom (Tinkers)
V: Bomb Key (Flans) , Empower/Quell Item (CoFH), Yeta Wrench Mode
H: Sound Locator (Dark Steel Armor), Night Vision (Dark Steel), Goggles of Revealing (Dark Steel), Goggles (Tinkers)
Out of these conflicts, the challenge arises which are true conflicts?  Most of these I have placed together because they require either the item in hand or item equipped or a contextual situation. For instance, the Yeta Wrench mode cant change if you have a CoFH omnitool in your hand or are holding a bomb.

I'll go double check tonight when I get home, can't remember the exact conflict that prompted my response here

how are you generating these images...?

The link is further up what we use.


Fix crash in ERTimeSortedParticipantsManager

Use concurrency to ensure (currently non-perfect) memory safety when sorting participants.
This, and everything related to concurrency, will be a bit ugly until more of the codebase starts adapting it.

This breaks compability with macOS 11.7.3 on my MacBook Air (13" Early 2014). It crashes on startup with the following error:
dyld: Library not loaded: /usr/lib/swift/libswift_Concurrency.dylib
Referenced from: /Users/kjh/Desktop/mautrix-imessage-universal/./barcelona-mautrix-macOS
Reason: image not found
Abort trap: 6

We've chosen to drop support for anything pre-Ventura (macOS 13) so we can take advantage of some newer pieces of functionality. For pre-ventura support, I've just pushed a branch pointing to the last commit that supports macOS 11 here: https://github.com/beeper/barcelona/tree/preventura

Thanks. What confused me was that in the README it says it will build on macOS Big Sur.
I've also asked about it in #imessage:maunium.net. There it was noted that the instructions on https://docs.mau.fi/bridges/go/imessage/mac-nosip/setup.html are more up to date.
It would be great if the README of this project gets updated, or links at the bridge documentation to see more up to date information.
Thanks for your awesome work!


Add command

Ensure "command" is passed in args

Not clear this actually does anything. So why doesn't it work now?


Can I reuse wasmer.Instance?

Summary
There are so many objects in wasmer: wasmer.Engine, wasmer.Store, wasmer.Module, wasmer.WasiEnvironment, wasmer.ImportObject, wasmer.Instance, wasmer.Memory
I think maybe wasmer.Module can be reused or used by many instance at the same time. (or is wrong?)
But could wasmer.Instance be reused many times? Or even be used concurrently?
Because my scenario is to call the wasm function frequently. I don't think it's a good idea to create a new instance every time you use it.

Thanks for @that-coder reply!


Separate http1 rx and tx state machines to support pipelining.

resolves #787 , in part.

@michalbiesek, I reverted my changes, and made them again from scratch.
I think I addressed all of your comments that didn't become obsolete during this process.  If I haven't don't hesitate to poke me again.

LGTM, regarding the comment.
  As @michalbiesek confirmed above, this isn't resolving everything, but is moving things forward.  #829 has been opened to help account for the fact that this PR not a complete fix for the original observation.


[Accessibility] - Talkback/Voiceover on mobile browser unable to read the role assigned to Navlink component.

Talkback/Voiceover on mobile browser unable to read the role assigned to Navlink component.
Package version: 4.3.1
OS version: Android 9 / iOS 13.3
Browser: Chrome / Safari 13.3
Screen reader: TalkBack/Voiceover

The problem is when we try to set the role attribute, for example to role="presentation", for the NavLink component it does not get read at all by the Narrator.

@dhiv-nitt That is exactly what the role "presentation" or "none" is for.

So what can i do for the role to be read to anything other than link ?

Could you explain in more detail what happens currently and what you expect instead? Or could you add a simple example via CodePen or so?

Could you explain in more detail what happens currently and what you expect instead? Or could you add a simple example via CodePen or so?

Pardon the delay in responding, I will write up the code on CodePen and send it across over here.

I wanted to understand if there is any way where the narrator CAN NOT Read Link. Is there a way to indicate the Narrator to not read out an  tag as a link ?

@dhiv-nitt Okay, so the link should be entirely ignored? As if it wasn't there? Maybe you try adding aria-hidden="true" to the link.

Ohkay Cool i will try that ! and get back to you !