Redesign: Reset boilerplate & fix linting errors

Updates in this PR:
#332 reset to use lib-franklin.js from boilerplate and updated scripts.js accordingly
#335 fix all warnings from stylelint on css, changed lint-staged in package.json back to original rule
  "lint-staged": {
    "*.css": "stylelint"
  }

updated scripts.test.js to lib-franklin.test.js & adjusted tests
minor style fixes

Note:

2 adjustments have been made in lib-franklin.js for maintaining the original status/layout on the site, which are in functions named decorateBlocks(main) and updateSectionsStatus(main)
The edited functions are marked with NOTE: and comments. In future for pulling the boilerplate, we may need to be careful on that / may be the boilerplate could be adjusted to solve the issue, which is deeply nested block are not being targeted in the functions
See if the tests folder is necessary to keep as the boilerplate doesn't have a test folder, but the original written script.test.js is now kept in codebase and changed to lib-franklin.test.js as most functions are now pulled from lib-franklin.js

Test Urls:
Root Folder
Before: https://main--helix-website--adobe.hlx.page/
After: https://redesign-reset-boilerplate--helix-website--adobe.hlx.page/
Home
Before: https://main--helix-website--adobe.hlx.page/home
After: https://redesign-reset-boilerplate--helix-website--adobe.hlx.page/home
Docs Page
Before: https://main--helix-website--adobe.hlx.page/docs/
After: https://redesign-reset-boilerplate--helix-website--adobe.hlx.page/docs/
Doc Detail Page
Before: https://main--helix-website--adobe.hlx.page/docs/authoring
After: https://redesign-reset-boilerplate--helix-website--adobe.hlx.page/docs/authoring
After this PR, we will need to take a closer look for improvement in performance on pages that are needed

@kptdobe For the boilerplate reset, it took like around 2 days for me as we need to take a careful look on updating the scripts to ensure that the site is kept intact after resetting. But resetting the boilerplate does seem to have a positive impact on the site performance. Personally, I think the boilerplate reset is worth the time if the site needs a performance bump or there're like new features from lib-franklin.js that can improve the workflow.

@kptdobe For the boilerplate reset, it took like around 2 days for me as we needed to take a careful look on updating the scripts to ensure that the site is kept intact after reset. But resetting the boilerplate does seem to have a positive impact on the site performance. Personally, I think the boilerplate reset is worth the time if the site needs a performance bump or there're like new features from lib-franklin.js that can improve the workflow.

Thanks, glad to hear that. I am a stronger believer that if you build a site with version X of the boilerplate (and you have a 100 score as expected), there is no reason to upgrade to version X+1. Nothing to gain apart from risk introducing a regression.
Again, as this is our demo flagship site, we want to use the latest version but there is no technical reason for it, only marketing.

If you manage to create an issue in the boilerplate describing why you had to patch lib-franklin (with isolate simple example) and create an issue in this repo to reset the lib-franklin when the other one is fixed, I am fine merging the patched lib-franklin for the time being...

@kptdobe thanks for your review, let's merge this and create follow-up issues for the tabs/testimonials, so that we can align even further.

Hey @trieloff, I'm going to merge this first and work on another PR for the new issue.
@kptdobe I agree that if the site has already scored 100 and there's no critical update on the boilerplate, there's no need for upgrading to newer version. For the update in boilerplate reset, I think we can treat the current ones as case-based updates only if we're okay with patching lib-franklin.js in this PR.


Add linux-arm64-gnu to prebuilt binaries

It's not clear to me where/how Github or the release process itself is defining which architectures to build against?
Thread: https://rust-bindings.slack.com/archives/C0H978T55/p1723665669205089

I'm sorry I overlooked this PR! This has been implemented in #63 and published in<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

And thanks so much for catching this oversight! I'm excited to add arm linux to the support matrix.


Crashing Terminal

Hey! First at all i really enjoy using this terminal. Thanks for keeping it alive.
But recently i have encountered some trouble with it. E.g. when i try to search some music in mpsyt or open my mailbox in neomutt, the terminal will crash. The programs run fine until that point. Maybe it has some problems with rendering big lists or something. I already reinstalled the terminal, but this didn't prevent ther terminal from crashing ;(
Here are some information about my system:
OS: Manjaro Linux 4.19.12-2
terminal version (installed from AUR): xst-git 20181014.5d2206e-1
email client (installed from AUR): NeoMutt 20180716
mpsyt 0.2.8
If you need more information, just asked. I don't know what to do about it, except asking here for help.

run terminal from another terminal and collect xst-s stdout/err at the moment of crashing

Thanks for your quick response!
I did as you suggested (open other terminal and start xst from in there) and this is the output after the crash:
NeoMutt
X Error of failed request:  BadLength (poly request too large or internal Xlib length error)
Major opcode of failed request:  139 (RENDER)
Minor opcode of failed request:  20 (RenderAddGlyphs)
Serial number of failed request:  4220
Current serial number in output stream:  4256
mpsyt
X Error of failed request:  BadLength (poly request too large or internal Xlib length error)
Major opcode of failed request:  139 (RENDER)
Minor opcode of failed request:  20 (RenderAddGlyphs)
Serial number of failed request:  1931
Current serial number in output stream:  2159
Is there anything else i can help with?

I changed the font from 'hack' to 'noto sans' and the output is only slightly different for neomutt:
X Error of failed request:  BadLength (poly request too large or internal Xlib length error)
Major opcode of failed request:  139 (RENDER)
Minor opcode of failed request:  20 (RenderAddGlyphs)
Serial number of failed request:  3970
Current serial number in output stream:  4022

Maybe my Xresources could be helpful to track it down:
! https://github.com/neeasade/xst/blob/master/doc/Xresources

st.termname:            xst-256color
st.shell:               /usr/bin/fish
!st.font:                Hack:pixelsize=16:antialias=true:autohint=true;
st.font:                Noto Sans:pixelsize=16;
st.borderpx:            40
st.cursorshape:         2
st.cursorthickness:     2
st.cursorblinkstyle:    0
st.cursorblinkontype:   1
st.bold_font:           0
st.xfps:                120
st.actionfps:           30
st.opacity:     255

! Kerning / character bounding-box height multiplier
st.chscale:           1.0
! Kerning / character bounding-box width multiplier
st.cwscale:           1.0
! blinking timeout for terminal and cursor blinking (0 disables)
st.blinktimeout:      800
! bell volume. Value between -100 and 100. (0 disables)
st.bellvolume:        0
! this is a char that is exposed like so: `printf '\033[z'`
st.prompt_char:       $

and can you reproduce the same problem in st?

fyi: https://lists.suckless.org/dev/1901/33147.html

i think it's ok to close it here


how to use custom trained checkpoint

Thanks for sharing this project!
I've followed the instructions to train a custom model. The tensorboard is showing decent progress and audio predictions are starting to sound good. But I am unable to load custom model checkpoint for inference. Can you share how to use the custom trained checkpoints for inference?
Thanks,
Emmanuel

Hi，I've met the same issue, any idea?


Content-Type Header empty for prometheus metric request on istio-gateways

Bug Description
The "Content-Type" header for prometheus metrics scrape on istio gateways is empty on port 15020
❯ kubectl exec istio-ingressgateway-7bdfb4cf6b-5fcjh -- curl -v localhost:15020/stats/prometheus
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0*   Trying ::1:15020...
* TCP_NODELAY set
* Connected to localhost (::1) port 15020 (#0)
> GET /stats/prometheus HTTP/1.1
> Host: localhost:15020
> User-Agent: curl/7.68.0
> Accept: */*
>
* Mark bundle as not supporting multiuse
< HTTP/1.1 200 OK
< Content-Type:
< Date: Wed, 01 Dec 2021 19:24:06 GMT
< Transfer-Encoding: chunked
<
{ [44090 bytes data]

This problem is only on port 15020 on all gateways (egress and ingress). The "content-type" header is set correctly

on sidecar envoys port 15020
on gateway pods port 15090 (only envoy metrics)

Tested on different installations (istio 1.12.0 on kind, istio 1.11.4 on VMWare PKS).  The specification does demand a "content-type" header.
Version
❯ istioctl version
client version: 1.12.0
control plane version: 1.12.0
data plane version: 1.12.0 (3 proxies)
❯ kubectl version --short
Client Version: v1.21.3
Server Version: v1.21.1

Additional Information
No response

I'd like to take a stab at this if nobody minds

I started looking into this but would appreciate help! I think the error is in this if block:
https://github.com/istio/istio/blob/409ccf1422a6843b4776fa5a99e1be91a49481b4/pilot/cmd/pilot-agent/status/server.go#L462
	var format expfmt.Format
	if s.prometheus != nil {
		var contentType string
		url := fmt.Sprintf("http://localhost:%s%s", s.prometheus.Port, s.prometheus.Path)
		if application, contentType, err = s.scrape(url, r.Header); err != nil {
			log.Errorf("failed scraping application metrics: %v", err)
			metrics.AppScrapeErrors.Increment()
		}
		format = negotiateMetricsFormat(contentType)
	}

format is only set if application metrics are available.

This change fixes it https://github.com/istio/istio/compare/master...davidmortiz:istio-36330?expand=1
Just working on a test

I think this's fixed by https://github.com/istio/istio/pull/36371


wrangler-action is broken

wrangler-action broke. it says it can't connect to the cloudflare api, so maybe github is blocking it now? cloudflare should fix it in v3 so I'll need to bump the version in the action once it's fixed

for the time being I'm just deploying using wrangler in my terminal

forgot, this also means the deploy button is broken


xbc1: verify checksum when decompressing

This adds checksum verification when decoding XBC1 files.
In the case of a checksum mismatch, the decompressed data is returned to attempt recovery.
I added the error variant to the DecompressStreamError enum. Originally, I tried creating an error type specific to Xbc1, but it would have been quite big of a refactor because the more generic error type is referenced in many other places.
I tested this on a local copy of ard-tools, as the xc3_test binary required some graphics-related system dependencies.

This is a nice change. Thanks.

I added the error variant to the DecompressStreamError enum.

I'm open to reworking the error types in the future if you think there's a better way of organizing things. Thank you for keeping the changes localized for this PR.

I tested this on a local copy of ard-tools, as the xc3_test binary required some graphics-related system dependencies.

There's no dependency on xc3_wgpu in xc3_test. You shouldn't have any issues building xc3_test on desktop at least in theory.


Hotfix/merge master to develop

@nc6 can you please merge your changes  into release/1.1.0? My brain will explode, I have two remaining commits to merge:

https://github.com/input-output-hk/cardano-sl/commit/4c27b16908893faf82ab7933b17746fb4857e665
https://github.com/input-output-hk/cardano-sl/commit/f843398a4114cfdcba83c59c3f7b01bc3453e12b

We require this for develop branch, the build will be possible after https://github.com/input-output-hk/cardano-sl/commit/4c27b16908893faf82ab7933b17746fb4857e665

As was clarified today, changes from master won't go to release/1.1.0, so I am closing this PR. Sorry for taking your time on it :(


Is there a way to have the groups user belongs in the token payload ?

Hi, Is there a way to have the groups user belongs in the token payload (cognito:groups) ?
Thanks

Sounds like a missing feature/bug.
It should be a relatively simple fix in the TokenGenerator service if you're feeling up for submitting a PR, otherwise I'll take a look when I get the time.


[FRON-472] enable console by default

We'll want to merge this last to release community edition console
With the context that console's being updated to work without authentication, is there anything else that'd need to be set here?

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@jrockway when can we merge this?

Any time @pleeko.  You'll also need to backport to the 2.2.x branch.


Misleading example description

The description leads the reader to believe that the provided code will "ensure that only one instance of a particular orchestrator runs at a time", however this is misleading. If an instance has ever been created, the existingInstance variable will not be null, even if said instance is no longer running (e.g. it completed).
I suggest either updating the description to accurately match what the provided code does – namely, check if an instance ever was created – or update the code to match the description, perhaps like the following code, which also provides a more helpful response in the case that an instance is still running.
const df = require('durable-functions')

module.exports = async function(context, req) {
    const client = df.getClient(context)
    const instanceId = req.params.instanceId
    const functionName = req.params.functionName

    const existingInstance = await client.getStatus(instanceId)
    const existingInstanceIsRunning = (instance) => {
        const runningStatuses = [
            df.OrchestrationRuntimeStatus.Pending,
            df.OrchestrationRuntimeStatus.Running,
            df.OrchestrationRuntimeStatus.ContinuedAsNew
        ]
        return runningStatuses.includes(instance.runtimeStatus)
    }
    if (!existingInstance || !existingInstanceIsRunning(existingInstance)) {
        const eventData = req.body
        await client.startNew(functionName, instanceId, eventData)
        context.log(`Started orchestration with ID = '${instanceId}'.`)
        return client.createCheckStatusResponse(req, instanceId)
    } else {
        return {
            status: 200,
            body: {
                msg: 'An instance with this ID already exists.',
                ...client.createHttpManagementPayload(instanceId)
            }
        }
    }
}

EDIT: Updated the suggestion a bit
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a5d6badc-f611-71ad-b167-aabfb95dc13f
Version Independent ID: db5c72cb-648c-5009-7261-1ba55703c08e
Content: Singletons for Durable Functions - Azure
Content Source: articles/azure-functions/durable/durable-functions-singletons.md
Service: azure-functions
GitHub Login: @cgillum
Microsoft Alias: azfuncdf

Hi @abiabsurd Thank you for your feedback! We will review and update as appropriate.

@cgillum Any thoughts here?

@cgillum just following up in case you missed .

Thanks for calling this out. I think the right thing to do here is update the description to match the code - e.g. say "check if an instance was already created".

I've run into the same issue. The sample provided by @abiabsurd  is better, but still prone to problems (eg the Fail state is not taken into account here). I would really like a sample where this pattern is implemented in a real world scenario.

Thanks for that! I like that a lot better as an option over just testing for nulls.

Looks like the sample in the docs was updated (but with checks for terminal states).


Allow a nicer access to the names of the bodies for a loaded model

This is how they do things in the Python bindings to get (for example) IDs from a body/geom/etc... name.
More explanation of the named access here


Set version number to 1.0.0.

Set the package version number to 1.0.0, so that we can use that for an initial release tag.

Yes please! thanks.


Exec tachikoma update<PHONE_NUMBER>1812

:hamster::hamster::hamster:   Strategy none
Powered by Interval Pull Request as a Service - Tachikoma.io Announcement: 2015-06-28 Updated permissions - Tachikoma.io

Coverage decreased (-0.009%) to 99.695% when pulling 1facab9462b75bd71ef09976bba87939978000ab on pazjacket:tachikoma/update-20160811151812 into 77a776d257a2436999eb722afb99b372b7aa9f95 on hoshinotsuyoshi:master.


driver: upgrade CSI version to v1.1.0

To follow Kubernetes's v1.13 release.

Kubernetes v1.13 and CSI v1.0 broke the backward compatibility, again.
Kubernetes v1.12 and less are still using e.g. service csi.v0, though there is no v0 endpoint available in the CSI v1.0 package. And Kubernetes v1.13+ cannot use csi.v0.
Seems we don't have a choice but use separate code bases for two now.
Maybe from v0.4.0+, we only support Kubernetes v1.13+. In the meantime, continuing maintaining 0.3.x for Kubernetes v1.12 and below.

Validation: PASSED
Test volume created by kubernetes on the old longhorn works on new longhorn, also you can create and use new volumes by kubernetes in new longhorn.


Help meta thrive

#assign:xelu86

Hey @ItsKylieCyrus,
Thanks again for contacting Microsoft. We value your feedback.
We're unable to determine what the intent of your question is. If there are any errors or areas of improvement with said documentation, please let us know so we may better assist.
We're closing this issue but please feel free to reopen it and advise us what revisions may be needed. Thank you and have a most pleasant day. #please-close


Tagged tables and other resources

We are going to be using tags more and more, in order to mark dynamo tables as belonging to a particular feature. Watchman should be able to using this grouping metadata to apply rules to dynamo tables, and to other resources that support tags.

Tags are becoming more common and widely used. We have legacy support for dynamo tables and SQS queues and generic support for everything else.
Ideally we want the generic config to support matching on tags for all resource types.

Suggest we add two properties to ResourceThreshold - something like ExcludedTags and RequiredTags.
Annoyingly the dynamo api (at least) only has ListTagsOfResource endpoint which only accepts one table at a time. So unless we are prepared to call this for every resource which has been discovered then tagging support for dynamo doesn't seem possible. It doesn't seem ideal for watchman to only support tags on certain resources.

Having looked at this a while back, the main challenge appears to be that (last time I looked) not all AWS services provide a method to retrieve tags for multiple resources at a time.  So, for example, you would end up requesting individual resources for every dynamo table in the account, whereas now we can list and filter dynamo tables in one call.

The approach we discussed was for IResourceSource<T>.GetResourceNamesAsync to return an object containing both the name and set of tags.
The thing that then filters on name can than be extended to also filter on the tags.
The type that is loaded from config, ResourceThresholds<TConfig>, could be extended to have a Tags set and an ExcludedTags set.


Get rid of nested objects in props

Props for a React component should always be flat - there are no extra props inside objects. When passing down props from a parent component, the spread notation can be used or the specific props explicitly passed down. I also prefer using the spread notation to other ways to merge, but that's open for discussion.

Thanks @shp54, some good changes! Check the review comments, of course, but my last question is whether or not you were going to continue the treatment for '/forms/formHelpers.js' - is that planned for this PR?

Added destructuring to make props explicit.

Just a note that this PR also removes old imports.


Inaccessible base and suspicious casts in FilesOpenDialog

It looks like IFileDialog is inaccessible due to imbiguity: https://github.com/files-community/Files/blob/39a40ed9556e559e5a0e57c256750379e9e6b978/Files.OpenDialog/CustomOpenDialog/FilesOpenDialog.h#L29
class CFilesOpenDialog ---> IFileDialog
class CFilesOpenDialog ---> IFileDialog2        ---> IFileDialog
class CFilesOpenDialog ---> IFileOpenDialog ---> IFileDialog
[clang-dignostic-inaccessible-base]
And due to inaccessible base cannot convert this to IFileDialog * https://github.com/files-community/Files/blob/39a40ed9556e559e5a0e57c256750379e9e6b978/Files.OpenDialog/CustomOpenDialog/FilesOpenDialog.cpp#L161
(workaround(?) reinterpret_cast<IFileDialog *>(this))
Cannot cast CFilesOpenDialog * to IFileDialog * via static_cast in
#define COM_INTERFACE_ENTRY(x)\
	{&_ATL_IIDOF(x), \
	offsetofclass(x, _ComMapClass), \
	_ATL_SIMPLEMAPENTRY},

-- offsetofclass(base, derived) -->
#define offsetofclass(base, derived) ((DWORD_PTR)(static_cast<base*>((derived*)_ATL_PACKING))-_ATL_PACKING)

https://github.com/files-community/Files/blob/39a40ed9556e559e5a0e57c256750379e9e6b978/Files.OpenDialog/CustomOpenDialog/FilesOpenDialog.h#L42

@gave92

@wnstngs thank you for bringing this up. Have you seen this causing issues? Appears to compile and run correctly except for a compile-time C4584 warning. Plus both IFileOpenDialog and IFileDialog2 are defined as ": public IFileDialog", why would it give "inaccessible base"?

If the modifier were private, then there'd be an error. Now it’s a warning, I think caused by multiple inheritance. I don’t have a code at the moment, but I think you’re inheriting something that you already have a copy of (e.g. inheriting object A which has base-class B and inheriting explicitly object B).

Correct, but it appears I have to do it or COM won't work for that interface (IFileDialog). Currently not seeing that working being an issue.

@gave92 Can you confirm it's resolved?


Feature/dot view

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@189e46a). Click here to learn what that means.
The diff coverage is 78.62%.

@@            Coverage Diff             @@
##             develop     #107   +/-   ##
==========================================
  Coverage           ?   91.69%
  Complexity         ?      333
==========================================
  Files              ?       25
  Lines              ?      626
  Branches           ?       88
==========================================
  Hits               ?      574
  Misses             ?       41
  Partials           ?       11

Impacted Files
Coverage Δ
Complexity Δ

src/main/groovy/graph/EdgeSpec.groovy
100% <ø> (ø)
2 <0> (?)

src/main/groovy/graph/VertexSpec.groovy
100% <ø> (ø)
2 <0> (?)

...roovy/graph/type/weighted/WeightedGraphType.groovy
66.66% <0%> (ø)
1 <0> (?)

...roovy/graph/type/directed/DirectedGraphType.groovy
91.66% <100%> (ø)
12 <3> (?)

.../graph/type/weighted/WeightedEdgeComparator.groovy
86.66% <100%> (ø)
8 <0> (?)

...main/groovy/graph/type/undirected/GraphType.groovy
100% <100%> (ø)
14 <7> (?)

.../type/directed/DirectedVertexSpecCodeRunner.groovy
100% <100%> (ø)
4 <0> (?)

.../graph/type/undirected/VertexSpecCodeRunner.groovy
71.42% <100%> (ø)
11 <0> (?)

src/main/groovy/graph/Graph.groovy
100% <100%> (ø)
141 <8> (?)

src/main/groovy/graph/type/AbstractEdgeSpec.groovy
100% <100%> (ø)
37 <1> (?)

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 189e46a...d1f70b5. Read the comment docs.


CANCEL (Speed up weights)

Added EVCouplings numba weights calc from https://github.com/debbiemarkslab/EVcouplings/blob/develop/evcouplings/align/alignment.py#L1172
Added some necessary EVCouplings util functions
Changed weights calc to match DeepSeq (we can easily sub in EVCouplings version too)
Added multiprocessing for EVE weights calc
Added multiprocessing for EVCouplings (decided not to use numba.prange as it fails silently, harder to track progress, and harder to control)
Added calc_weights.py function for calculating weights separately on CPU prior to GPU training (and corresponding force_load_weights in train_VAE.py file as an option to make sure we don't recalculate weights if weights aren't found.

Merging to OATML-MarksLab repo instead; got confused and thought this one was the one with most commits


Lock releases individually to reduce lock contention on deploy

We're seeing a number of deployment failures when we make several deployments simultaneously if those deployments all consume the same release, along the lines of:
Error: Failed to acquire lock for lock:release:consul
We believe that locking releases individually during bind_model will reduce the contention on these locks.
Thanks!
@henryaj and @tinygrasshopper

@cppforlife - what are your thoughts on this approach?

Sorry that we never reviewed this PR in a reasonable time frame. At this point I'm going to close this PR. Please feel free to resubmit the PR against the master branch if you would like us to consider this change.
Best,
@jfmyers9, CF BOSH


IMethodCallParser Optimization

The way that the Linq parsing determines which IMethodCallParser to use is a little bit slow because it's a table scan every time. I vote to use a new interface like this:
public enum MatchStyle
{
    DeclaringTypeAndMethodName,
    DeclaringTypeAndMethodNameAndArguments,
}

public interface IMethodCallParser
{
    // This is to short circuit the applicability
    // determination
    MethodInfo Method {get;}
    MatchStyle MatchStyle {get;}

    // This might not need to be used at all at runtime if the match style is by type and method name
    bool Matches(MethodCallExpression expression);
    IWhereFragment Parse(IQueryableDocument mapping, ISerializer serializer, MethodCallExpression expression);

    // I'd like to introduce this one
    bool TryParse(MethodCallExpression expression, IQueryableDocument mapping, ISerializer serializer, out IWhereFragment fragment)
}

The general idea is to have the IMethodCallParser matching memoized a bit by method so you don't waste time going through all the Matches() methods.
If we use C# 8, we might be able to use default interface implementations and make this change without breaking compatibility, which would allow us to pull this into 3.12

Nevermind, I can pull this off without any kind of breaking API change

This code from LinqParsing isn't going to be suitable out of the box, but it's still helpful:
        private ImHashMap<Type, ImHashMap<string, MethodCallParseDelegate>> _methodParsing = ImHashMap<Type, ImHashMap<string, MethodCallParseDelegate>>.Empty;

        /// <summary>
        /// High performance mechanism for registering custom Linq parsing for a method
        /// </summary>
        /// <param name="expression"></param>
        /// <param name="parsing"></param>
        /// <typeparam name="T"></typeparam>
        public void ParseMethod<T>(Expression<Func<T, bool>> expression, MethodCallParseDelegate parsing)
        {
            var type = typeof(T);
            var methodName = ReflectionHelper.GetMethod(expression).Name;

            ParseMethod(type, methodName, parsing);
        }

        public void ParseMethod(Type type, string methodName, MethodCallParseDelegate parsing)
        {
            if (!_methodParsing.TryFind(type, out var byType))
            {
                byType = ImHashMap<string, MethodCallParseDelegate>.Empty;
            }

            byType = byType.Update(methodName, parsing);

            _methodParsing = _methodParsing.Update(type, byType);
        }

I've got this finished in the linq-new branch. It's leaving the IMethodCallParser alone, but memoizing the matching so it doesn't have to run through all the parser.Matches() checks


Error in spotty helper

Hi,
I am running LMS in a docker container form here:
https://github.com/larsks/docker-image-logitech-media-server
which works with no issues up to the point in which I try to install the spotty plugin.
when entering the configuration page in order to setup my spotify account I see the error message below.
Is it true, that spotty doesn't work on x64 systems ? or might it be related to the docker installation ?
Beim Ausführen der Spotty Helfer-Anwendung ist ein Fehler aufgetreten. Vermutlich wird diese auf ihrem System nicht unterstützt. Bitte wenden Sie sich an mich, unter Angabe der folgenden Plattform-Informationen:
Betriebssystem: Debian / x86_64-linux
Ordner für Hilfsprogramme:
/usr/share/squeezeboxserver/Bin/x86_64-linux
/usr/share/squeezeboxserver/Bin
/usr/local/sbin
/usr/local/bin
/usr/sbin
/usr/bin
/sbin
/bin
/srv/squeezebox/cache/InstalledPlugins/Plugins/Spotty/Bin/i386-linux
/srv/squeezebox/cache/InstalledPlugins/Plugins/Spotty/Bin
ldd (Ubuntu GLIBC 2.23-0ubuntu10) 2.23

Linux x86_64 certainly should work - I'm using that myself. Docker otoh has been causing problems for quite a few people. Not in the way you are experiencing it, but often eg. players would not be seen by Spotify apps.
Anyway. Not sure what's wrong with your environment. Could be libc is too old?

tried native installation ... works like charm ....


Uncaught TypeError: Cannot set property '[Note ID: f8c936067e9595e2d19cafc019a629fd]' of null

[Enter steps to reproduce below:]

...
...

Atom Version: 1.3.3
System: Mac OS X 10.10.4
Thrown From: ever-notedown package, v0.2.18
Stack Trace
Uncaught TypeError: Cannot set property '[Note ID: f8c936067e9595e2d19cafc019a629fd]' of null
At /Users/qinf/.atom/packages/ever-notedown/lib/note-helper.coffee:95

TypeError: Cannot set property '[Note ID: f8c936067e9595e2d19cafc019a629fd]' of null
    at NoteIndex.addnote (/Users/qinf/.atom/packages/ever-notedown/lib/note-helper.coffee:95:5)
    at StorageManager.exports.StorageManager.StorageManager.addNote (/Users/qinf/.atom/packages/ever-notedown/lib/storage-manager.coffee:197:27)
    at /Users/qinf/.atom/packages/ever-notedown/lib/ever-notedown.coffee:1611:38
    at /Users/qinf/.atom/packages/ever-notedown/lib/evernote-helper.coffee:1056:9
    at ChildProcess.exithandler (child_process.js:206:7)
    at emitTwo (events.js:87:13)
    at ChildProcess.emit (events.js:172:7)
    at maybeClose (internal/child_process.js:817:16)
    at Socket.<anonymous> (internal/child_process.js:319:11)
    at emitOne (events.js:77:13)
    at Socket.emit (events.js:169:7)
    at Pipe._onclose (net.js:469:12)

Commands
     -5:57 core:copy (atom-notification.fatal.icon.icon-bug.native-key-bindings.has-detail.has-close.has-stack)
     -5:20.5.0 ever-notedown:open-config (div.pane-item.native-key-bindings.about)
     -5:05.2.0 ever-notedown:toggle (div.pane-item.native-key-bindings.about)
     -4:43.4.0 ever-notedown:import-note-from-evernote (div.pane-item.native-key-bindings.about)
     -3:21 ever-notedown:new-note (div.pane-item.native-key-bindings.about)
  2x -3:08.6.0 core:backspace (atom-text-editor.editor.is-focused)
  2x -2:59.8.0 editor:newline (atom-text-editor.editor.is-focused)
  2x -2:55 core:save (atom-text-editor.editor.is-focused)
  2x -1:05.4.0 core:copy (atom-notification.error.icon.icon-flame.native-key-bindings.has-detail.has-close.has-stack)
     -0:12.1.0 ever-notedown:import-note-from-evernote (atom-text-editor.editor.is-focused)

Config
{
  "core": {}
}

Installed Packages
# User
atom-beautify, v0.28.18
ever-notedown, v0.2.18

# Dev
No dev packages

echo "{}" > index.json can deal with this issue!
For more information, please go to visite Install ever-notedown

@qinf Thanks for the feedback!
And for those of you reading this post and having trouble opening the link, try this and click Installation -> Preparation from the Table of Contents


Create a file Panhala India.md

This pull requests resolves #42

:+1: sounds interesting :ship: it :shipit:


SQLite3::SQLException: no such column: distance

In this case, An error occurred when using the Near and Left Join.
Can you give me some advice?  ORDER BY distance ASC LIMIT ? (ActiveRecord::StatementInvalid)

Using includes is known to produce strange results and errors.


Inline the node versions in Github actions to test if renovate can include them in it's upgrade PR

@coderabbitai review


[Security page] Sentence does not make sense

The page:
https://dubbo.apache.org/docs/notices/security/
says:
"Before switching the serialization protocol or implementation, the user can, We should fully investigate ..."
This does not make sense. Perhaps it should read:
"Before switching the serialization protocol or implementation, the user should fully investigate ..."

thanks, I will fix it


Bump node version in travis to 18

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 7.74%. Comparing base (7c4085d) to head (27c9e86).

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #758   +/-   ##
======================================
  Coverage    7.74%   7.74%
======================================
  Files          68      68
  Lines        3860    3860
  Branches      837     837
======================================
  Hits          299     299
  Misses       3561    3561

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:tada: This PR is included in version 1.43.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


What is the procedure to run the apps?

How do you install the apps and run them please.

Hey @pbirch31 we have some instructions in the Readme


RebirthDB

Hey, listen! I don't know if your driver already supports fully the 2.3 version, but we've forked RethinkDB to release a 2.4 version and all drivers will have separate repositories under our organization, discussion here: https://spectrum.chat/rebirthdb
So I'm inviting you to join us, there you can have more visibility for your project, what do you think?

This driver isn't feature complete and isn't being actively maintained for the time being. I don't think it is ready to join RebirthDB yet (more work than gain). But I'm keeping an eye for that.


Terminal command history not preserved after reopening

Describe the bug
After reopening the terminal, I cannot access command history.
To Reproduce
Steps to reproduce the behavior:

Open the terminal.
Execute commands such as command1, command2, etc.
Close the terminal.
Reopen the terminal.
Try using arrow keys or any other method to access previous commands.

Expected behavior
I expected to be able to navigate through my command history using the arrow keys after reopening the terminal.
Environment

OS: ArchLinux
Output of is --version: 0.0.1-rc.15
Shell: zsh
Shell Version: 5.9 (x86_64-pc-linux-gnu)
Terminal emulator: Kitty

Additional context

I have not made any recent changes to my shell configuration.

it have fixed when I added the following lines to the .zshrc file.
SAVEHIST=1000  # Save most-recent 1000 lines
HISTFILE=~/.zsh_history


Generic type in class forgets that it has a super type when used as partial

🔎 Search Terms
typescript partial generic not working in class
🕗 Version & Regression Information
Tried with latest version: 5.3.2
⏯ Playground Link
No response
💻 Code
interface Bar {
    title: string
}

class Stool<T extends Bar = Bar> {
    // Ok
    one: Partial<T> = { }
    // Compiler error
    two: Partial<T> = { title: "barking dog"}
}

🙁 Actual behavior
Can't initialize with a field defined in the super type of the genereric type.
Getting the error: "Type '{ title: "barking dog"; }' is not assignable to type 'Partial'"
🙂 Expected behavior
Should be able to initialize with a field defined in the super type of the genereric type.
Additional information about the issue
No response

This is working as intended.
{} is a valid object for Partial<T>, regardless of what T is. But { title: "barking dog" } is not a valid object, because T might be typed { title: "Xi bear" }.
const s = new Stool<{ title: "Xi bear" }>

This is working as intended.
{} is a valid object for Partial<T>, regardless of what T is. But { title: "barking dog" } is not a valid object, because T might be typed { title: "Xi bear" }.
const s = new Stool<{ title: "Xi bear" }>

Ah (I hope I get it), so the issue is that the actual T might restrict the (string) type of "title" to specific string values, thus making "barking dog" be of invalid type since the actual type is not really known.
Hmm, kind of makes generics less usefull (for me at least).
Plus, it doesn't explain why I can assign any value I want after the object has been initialized:
interface Bar {
    title: string
}

class Stool<T extends Bar = Bar> {
    // Ok
    one: Partial<T> = { }

    constructor() {
        // Ok. So I can't use that value in an initializer, but I can assign it afterwards. Magic!
        this.one.title = "barking dog"
    }
}


Dimensiona transceiver needs documentation about fluid transfer limit

The dimensional transceiver has a limit on the amount of fluid it transfers per tick. After hours of trying new and better conduits, i'd like to suggest stating the transceiver's limit in a visible manner (not in a reddit thread buried in the archives of the internet)
What happens not: The fluid is delivered to my life-safing machines.
What happens: I die
Steps to reproduce:

Travel to extraplanet's Ceres while having some other bases needing oxygen
build a habitat and
connect the oxygen sealer to the transceiver
try to breath

EnderCore-1.12.2-0.5.73.jar
EnderIO-1.12.2-5.1.55.jar
EnderIO-endergy-1.12.2-5.1.55.jar
ExtraPlanets-1.12.2-0.6.2.jar
Galacticraft-Planets-1.12.2-<IP_ADDRESS>.jar
GalacticraftCore-1.12.2-<IP_ADDRESS>.jar
forge-1.12.2-<IP_ADDRESS>47-installer.jar
// no optifine, single player

The only limit is the amount of energy available in the sending transceiver.

Three vibrant capacitor banks next to the transceiver remained full, the ender fluid conduit sufficed to fill a second transceiver. Another user mentioned 4000 mB/second or /tick. The second transceiver is powered from the same capacitor bank.


chore: helm chart release for driver v1.1.1

Signed-off-by: Anish Ramasekar<EMAIL_ADDRESS>
Reason for Change:

Requirements

[ ] squashed commits
[ ] included documentation
[ ] added unit tests and e2e tests (if applicable).

Issue Fixed:

Does this change contain code from or inspired by another project?

[ ] Yes
[ ] No

If "Yes," did you notify that project's maintainers and provide attribution?
Special Notes for Reviewers:

Codecov Report

Merging #830 (7259fba) into master (35cc84f) will not change coverage.
The diff coverage is n/a.


Document using ttn-lw-migrate to migrate from v2

Summary

Update documentation to use ttn-lw-migrate instead of ttnctl for migrating from v2 to v3.
Checklist

[x] Scope: The referenced issue is addressed, there are no unrelated changes.
[x] Run Locally: Verified that the docs build using make server
[ ] New Features Marked: Documentation for new features is marked using the new-in-version shortcode, according to the guidelines in CONTRIBUTING.
[x] Style Guidelines: Documentation obeys style guidelines in CONTRIBUTING.
[x] Commits: Commit messages follow guidelines in CONTRIBUTING, there are no fixup commits left.

Why is this not followed up on?
@neoaggelos if you don't request reviews, it does not show up on the list for reviews and nothing happens.

Why is this not followed up on?
@neoaggelos if you don't request reviews, it does not show up on the list for reviews and nothing happens.

this is critical documentation so i vote if there are no serious issues that we merge now and improve along the way. @johanstokking, waiting on your review.


[Fix] Use MUI v4 CssBaseline to fix global styling

Before (demo.backstage.io)
After (local dev)

Issue:

a tag adapts native Browser styles as text-decoration is not overwritten
Slight changes in font-size etc.

Relates to https://github.com/backstage/backstage/pull/18495 & is a temporary fix until the PR is merged & shipped.

@tudi2d going to merge this so it's in and deployed, thanks!


#264: Bio: RDKit descriptors

Add RDKit descriptors calculated from SMILES generated from peptide sequence.

[x] Calculate SMILES for sequence column.
[ ] Use RDKit on calculated SMILES to get descriptors.
[ ] Add "Peptides" top menu to place these descriptors features into.

@skalkin , we still need it. It was not possible till the 'Macromolecules' approach was initiated. It will be done when tools for monomers are available.

This issue has been mirrored in Jira: https://reddata.atlassian.net/browse/GROK-14778

This issue has been mirrored in Jira: https://reddata.atlassian.net/browse/GROK-16040


feat: checked the type of config files

:tada: This PR is included in version 1.9.0 :tada:
The release is available on:

Visual Studio Marketplace
GitHub release

Your semantic-release bot :package::rocket:


[INLONG-564] Adjustment of the project LICENSE and NOTICE

Based on the discussion in [1], we need to sort out the various dependencies of TubeMQ, including the licenses of source code, scripts, binary components, etc.,
For quoted source code or scripts, we plan to directly use the corresponding binary package, or directly replace it with our own solution, to improve the cleanliness of the project license;
For the referenced binary components, we'll check the LICENSE, and adjust the implementation which the binary packages that do not conform to the apache specification to meet the requirements of the official release.
This task is divided into several sub-tasks for adjustment.
1. https://lists.apache.org/thread.html/r6858f56cb88ea8a279fb8bbce7be06b2230a701af46d4ac79fc08fee%40%3Cgeneral.incubator.apache.org%3E
JIRA link - [INLONG-564] created by gosonzhang

Closed due to long periods of inactivity
Please reopen it if needed


Gdrive requires permissions to manage your files on Google Drive, on remote ssh

I'm using gdrive remotely with ssh. I exported my user from local following your instructions and managed to add my account in the remote computer. When uploading the first file I get the Gdrive requires permissions to manage your files on Google Drive. message and a link to open and get the permissions. I can't open the link since I'm in ssh... How can I fix it?

run gdrive on your local machine and grant the permission in the browser before exporting the account


CFE Feature request: Add support for querying whether two types are incompatible

In certain situations one would like to detect statically whether an expression in the AST has a type that is incompatible with another type.
A recent motivating example: Future<R> foo() async { return <expr>; } functions can generally either return either a R or a Future<R>. The future implementation has to detect which is the case at runtime. Though if we know statically that all returned <expr>s are incompatible with Future we can implement the Future completion more efficiently (due to avoiding this is Future<R> runtime check).
It would therefore be nice to be able to query the TypeEnvironment whether a given <expr> or <expr>.getStaticType() is compatible/incompatible with another type. (not entirely sure whether there is a gray area where the answer cannot be given)
/cc @johnniwinther

/cc @chloestefantsova


whats the functionality of EEGStyleGAN-ADA/Image2EEG directory?

i am confused coz the code is very similar to EEGStyleGAN-ADA/Triplet_LSTM/. which dataset does it use?

@nihilisticneuralnet Hi, it maps unseen images to its equivalent EEG feature. It is something like zero-shot EEG feature generation. In paper, there is an experiment of image to image mapping which shows that, even if we have unseen image we can encode it into its equivalent EEG features and then pass it through the EEGStyleGAN for image generation.

thanks for the reply


Failure with new github repos that don't have a master branch

Since GitHub is is the process of moving away from the master branch and having all new repos created with the "main" branch instead.
Any github repo that doesn't have a master branch will fail, regardless of where it is being used.
It would be nice if the Terraform-Operator detected the default branch or accepted the branch as an input.

I haven't updated docs for branch support yet 😓 .
If you wanted to use a different branch, you can use ?ref query options to your github address. Here's an example:
  terraformModule:
    address: https://github.com/isaaguilar/non-main-default-test.git?ref=branch1
  terraformVersion: 0.12.23

Should also works for the ssh method too:
  terraformModule:
    # ?ref accepts a branch or sha-hash
    address: git@github.com:isaaguilar/non-main-default-test.git?ref=63b5bb4ddb1cf77f6bec8f02dbd04baefe768ffd
  terraformVersion: 0.12.23

I haven't updated docs for branch support yet 😓 .
If you wanted to use a different branch, you can use ?ref query options to your github address. Here's an example:
  terraformModule:
    address: https://github.com/isaaguilar/non-main-default-test.git?ref=branch1
  terraformVersion: 0.12.23

Should also works for the ssh method too:
  terraformModule:
    # ?ref accepts a branch or sha-hash
    address: git@github.com:isaaguilar/non-main-default-test.git?ref=63b5bb4ddb1cf77f6bec8f02dbd04baefe768ffd
  terraformVersion: 0.12.23

Thanks for the info and the quick response.

Thanks for the info and the quick response.


Basic API structure for rewrite

oopre

Write structure in rust?

Was planning on it, not sure this PR needed to be opened since i was doing most of it in another branch here


Merge Tobias-B-Besemer/hosts

Some time ago (long time before I found your list), I started my own hosts-list...
...but I stopped working on it...
Maybe you wanna merge some of my data...
My list is here: https://github.com/Tobias-B-Besemer/hosts
(With also some sublists e.g. for CP...)

Hi @Tobias-B-Besemer thank you for the suggestion.
At this juncture, and for the foreseeable future, I'm only considering actively curated data sources.  This is key to a good hosts file, in my view.
Happy computing!


Allow pipeline manipulation by user

This patch allows advanced users to manipulate the compiler pipeline with minimal changes to the core. All pipeline data structures can be accessed as well. Here is an example for adding a print stage before the backend stage:
def print_ir(func_ir):
    func_ir.dump()

def add_print_stage(pipeline_manager, pipeline):
    pp = pipeline_manager.pipeline_stages['nopython']
    new_pp = []
    for (func,desc) in pp:
        if desc=='nopython mode backend':
            new_pp.append((lambda:print_ir(pipeline.func_ir), "print IR"))
        new_pp.append((func,desc))
    pipeline_manager.pipeline_stages['nopython'] = new_pp

numba.set_user_pipeline_func(add_print_stage)

Codecov Report

Merging #2398 into master will decrease coverage by <.01%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master    #2398      +/-   ##
==========================================
- Coverage   86.25%   86.25%   -0.01%
==========================================
  Files         315      315
  Lines       60004    60007       +3
  Branches     6518     6518
==========================================
+ Hits        51756    51757       +1
- Misses       7199     7201       +2
  Partials     1049     1049

This is very simple and perhaps too simple.  The global user_pipeline_func can be written to by any code and overwriting the previous value without warning.  There can only be one user_pipeline_func defined at any time as well.
Can you explain what is the expected usecase of this pipeline manipulation API?

@sklam Yes, it has several restrictions. Ideally, we should enable addition of user_pipeline_function in the jit call as argument but it would require more core changes.
This code enabled getting the hpat package that we discussed last week started.

@sklam  jit decorator takes user_pipeline_funcs as an argument now. It takes a list of functions to apply to pipeline. For example, the example above becomes @jit(user_pipeline_funcs=[add_print_stage]).

Could this perhaps be closed in favour of https://github.com/numba/numba/pull/2843 ?

Yes.


Alphabetical order and star function

Hi, yesterday I was looking for the 'Seven Inch Soul' station and assumed that some stations might not been listed. But turns out it was on top and the list was't in alphabetical order lol.
Feature suggestion: This is just a shower thought tho not an issue :)
The starring function (or keep the liked tracks as a txt list) would be great. My solution for that is literally write down the name of the song to youtube, search for it and then add it to a playlist. An automated search in youtube with the played song's name.
SomaFM player is amazing. I've been using it for months and I love it's minimalism. Thank you so much.

redacting my feature suggestion as I've noticed some songs are google search results and some are itunes links. Seems like that those data is generated through soma.fm.

Hey! Glad you liked it :)
Have you checked channels sorting option?

Also about song search - I just use song name. App tries to search iTunes first and if there are no results - falls back to Google search. Any ideas for improvements there?

Hey! Glad you liked it :)
Have you checked channels sorting option?
Also about song search - I just use song name. App tries to search iTunes first and if there are no results - falls back to Google search. Any ideas for improvements there?

Oh, sorry didn't saw that! Well, that solved the issue immediately hehe.
For the fall back, maybe an option to set a main search engine to check out tracks? For my case, I use youtube, spotify and rarely beatport (if I'm going to buy singular tracks)
Sorting where the search would fallback (like how browsers sort their default search engines) would be a nice touch as well but I'm guessing it would be a bit pain to implement such thing. So take it as just an  an idea. The app is already free and works perfectly. I'm a bit embarrassed that I'm coming up with these stuff.


Introduce galley/pkg/config/resource

Introduces galley/pkg/config/resource, a newer core data-model, similar to galley/pkg/runtime/resource

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ozevren
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

galley/OWNERS [ozevren]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/lgtm
/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: geeknoid, ozevren
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

galley/OWNERS [geeknoid,ozevren]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ozevren: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
943fed26390b7c538fe6463cc6b9560caf72539c
link
/test e2e-simpleTests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
943fed26390b7c538fe6463cc6b9560caf72539c
link
/test e2e-simpleTests

prow/e2e-bookInfoTests-trustdomain.sh
943fed26390b7c538fe6463cc6b9560caf72539c
link
/test e2e-bookInfoTests-trustdomain

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
943fed26390b7c538fe6463cc6b9560caf72539c
link
/test e2e-simpleTests

prow/e2e-bookInfoTests-trustdomain.sh
943fed26390b7c538fe6463cc6b9560caf72539c
link
/test e2e-bookInfoTests-trustdomain

prow/e2e-bookInfoTests-v1alpha3.sh
943fed26390b7c538fe6463cc6b9560caf72539c
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
943fed26390b7c538fe6463cc6b9560caf72539c
link
/test e2e-simpleTests

prow/e2e-bookInfoTests-trustdomain.sh
943fed26390b7c538fe6463cc6b9560caf72539c
link
/test e2e-bookInfoTests-trustdomain

prow/e2e-bookInfoTests-v1alpha3.sh
943fed26390b7c538fe6463cc6b9560caf72539c
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/integ-galley-k8s-presubmit-tests.sh
943fed26390b7c538fe6463cc6b9560caf72539c
link
/test integ-galley-k8s-presubmit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
943fed26390b7c538fe6463cc6b9560caf72539c
link
/test e2e-simpleTests

prow/e2e-bookInfoTests-trustdomain.sh
943fed26390b7c538fe6463cc6b9560caf72539c
link
/test e2e-bookInfoTests-trustdomain

prow/e2e-bookInfoTests-v1alpha3.sh
943fed26390b7c538fe6463cc6b9560caf72539c
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/integ-galley-k8s-presubmit-tests.sh
943fed26390b7c538fe6463cc6b9560caf72539c
link
/test integ-galley-k8s-presubmit-tests

prow/integ-security-k8s-presubmit-tests.sh
943fed26390b7c538fe6463cc6b9560caf72539c
link
/test integ-security-k8s-presubmit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-galley-k8s-presubmit-tests

/test e2e-simpleTests

/test e2e-bookInfoTests-envoyv2-v1alpha3


Make Pretty: Logo

Change the color of the logo to complement the background color.
Also edit the font family (and maybe even the size) of the application name.

Joseph will do this


fix vulkan best practices

when best practices are enabled in the vulkan sdk, it prints tons of warnings.
it's probably best to implement those.

too difficult
for example, one tip recommend to reset the entire command pool, instead of just a single command buffer, but i don't see how that's possible, when because of frames in flight a buffer may be pending asynchronously.
like the removing of debug features, this should be considered at very late stages in development


Fatal Error parsing invalid cert aborts unit tests

I tried to use the certificate below as test-data in a unit test. The certificate is invalid since it features a GeneralString in the subject:organizationIdentifier. When trying to parse the certificate this leads to
FATA[0000] unable to parse PEM
exit status 1

During unit tests, this leads to the abortion of the tests due to a panic. I think the unit test framework should at least catch any errors of this kind and not simply abort. Even better if the it would be possible to parse such invalid certificates.
-----BEGIN CERTIFICATE-----
MIIEyTCCA7GgAwIBAgINBnUDUrQShFEl9jfPmDANBgkqhkiG9w0BAQsFADBBMRUwEwYDVQQDDAxUZXN0IFN1YkNBIDIxDTALBgNVBAsMBFRlc3QxDDAKBgNVBAoMA01URzELMAkGA1UEBhMCREUwHhcNMTkxMTA0MDYzNTM2WhcNMjAxMTA0MDYzNTM2WjCBojEMMAoGA1UECgwDTVRHMRIwEAYDVQQHDAlEYXJtc3RhZHQxDzANBgNVBAgMBkhlc3NlbjELMAkGA1UEBhMCREUxHTAbBgNVBA8MFFByaXZhdGUgT3JnYW5pemF0aW9uMRgwFgYDVQRhGw9WQVRERS0xMjM0NTY3ODkxEjAQBgNVBAUTCTEyMzQ1Njc4OTETMBEGCysGAQQBgjc8AgEDDAJERTCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBANjJFjxxhlF2HKfm9gFWp4DMwUS5Qhb9Jomq2O425As5PCe9VCFNmV1X8a6wmADuWPPH3UD0BleveWnbtsj1IpU1Eo6uPwqeZQGJIKRuz6wgx9AZcbpXT5zgmf5VDDoVFn7sYvSc4a65FkfE2Ontamf0YuMDfpbZRS7nBzfojQFzKiB0OGvyC4icBMwGm+y11qwpuOImTzRljj3rAEboazF3o+8S8TyY712aXPQno4c3MSM1EqtZO+ILSBUy0ULzVWMFybI/WsnlqkpIpHQSFDX7V5ck8uiLLPrb/WnuE9EQXj4c2B8m8WlpUlAP9fMtqeddOqWSnxx4FAxhyUp9DPUCAwEAAaOCAVwwggFYMB8GA1UdIwQYMBaAFJZgP5yaf4gl4AHNZwhX0IYm8PFKMB0GA1UdDgQWBBTgmXRqGmcO54swL6B3XM95sawpYTAOBgNVHQ8BAf8EBAMCBaAwDAYDVR0TAQH/BAIwADAaBgNVHREEEzARgg93d3cuZXhhbXBsZS5jb20wYgYIKwYBBQUHAQEEVjBUMCgGCCsGAQUFBzAChhxodHRwOi8vY2EuZXhhbXBsZS5jb20vY2EuY3J0MCgGCCsGAQUFBzABhhxodHRwOi8vb2NzcC5leGFtcGxlLmNvbS9vY3NwMFkGA1UdIARSMFAwBwYFZ4EMAQEwRQYKKwYBBAG9Rw0YATA3MDUGCCsGAQUFBwIBFilodHRwOi8vd3d3LnRlbGVzZWMuZGUvc2VydmVycGFzcy9jcHMuaHRtbDAdBgNVHSUEFjAUBggrBgEFBQcDAQYIKwYBBQUHAwIwDQYJKoZIhvcNAQELBQADggEBAFRO6OOXlSsTAKv4Hp2jvIzMQIwwTZJMkHs4qshiFVOrLSXe3dDxxBjgn87rbXL0X6rqHysnSzhlhbW6bUg2gAAcyXf4DBu/TEwYUhlLkzSFFHM9tioHWZmL1sgedl2x4vwnZbMpqRlQTINwWbV0Ey5TfqGw84LoC0SXCzRoV3ta1tsZDIXS5UBuEZXMJ2ElvjqYbEnJhHjUqWRuCtbVlRHJ05EqigDLzv2Qm0Q5MluQq/Qc4SK1WZQ+PGOv2yU/VXdItYirD4LYBAsI2o2Abq5o/tjtjQeynj3NxqrF1Qd0/SHjQXE+ZMU+M7glP9e3jjwd9liavUKsF8O6wLha73g=-----END CERTIFICATE-----

We agree, this is not expected behavior. If ZLint is unable to parse a certificate that should result with the lint failing with a FATAL not for the library to panic.

Actually, scratch that last comment. This certificate does not cause the library to panic. When the certificate is in the form you presented:
-----BEGIN CERTIFICATE-----
MIIEyTCCA7GgAwIBAgINBnUDUrQShFEl9jfPmDANBgkqhkiG9w0BAQsFADBBMRUwEwYDVQQDDAxUZXN0IFN1YkNBIDIxDTALBgNVBAsMBFRlc3QxDDAKBgNVBAoMA01URzELMAkGA1UEBhMCREUwHhcNMTkxMTA0MDYzNTM2WhcNMjAxMTA0MDYzNTM2WjCBojEMMAoGA1UECgwDTVRHMRIwEAYDVQQHDAlEYXJtc3RhZHQxDzANBgNVBAgMBkhlc3NlbjELMAkGA1UEBhMCREUxHTAbBgNVBA8MFFByaXZhdGUgT3JnYW5pemF0aW9uMRgwFgYDVQRhGw9WQVRERS0xMjM0NTY3ODkxEjAQBgNVBAUTCTEyMzQ1Njc4OTETMBEGCysGAQQBgjc8AgEDDAJERTCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBANjJFjxxhlF2HKfm9gFWp4DMwUS5Qhb9Jomq2O425As5PCe9VCFNmV1X8a6wmADuWPPH3UD0BleveWnbtsj1IpU1Eo6uPwqeZQGJIKRuz6wgx9AZcbpXT5zgmf5VDDoVFn7sYvSc4a65FkfE2Ontamf0YuMDfpbZRS7nBzfojQFzKiB0OGvyC4icBMwGm+y11qwpuOImTzRljj3rAEboazF3o+8S8TyY712aXPQno4c3MSM1EqtZO+ILSBUy0ULzVWMFybI/WsnlqkpIpHQSFDX7V5ck8uiLLPrb/WnuE9EQXj4c2B8m8WlpUlAP9fMtqeddOqWSnxx4FAxhyUp9DPUCAwEAAaOCAVwwggFYMB8GA1UdIwQYMBaAFJZgP5yaf4gl4AHNZwhX0IYm8PFKMB0GA1UdDgQWBBTgmXRqGmcO54swL6B3XM95sawpYTAOBgNVHQ8BAf8EBAMCBaAwDAYDVR0TAQH/BAIwADAaBgNVHREEEzARgg93d3cuZXhhbXBsZS5jb20wYgYIKwYBBQUHAQEEVjBUMCgGCCsGAQUFBzAChhxodHRwOi8vY2EuZXhhbXBsZS5jb20vY2EuY3J0MCgGCCsGAQUFBzABhhxodHRwOi8vb2NzcC5leGFtcGxlLmNvbS9vY3NwMFkGA1UdIARSMFAwBwYFZ4EMAQEwRQYKKwYBBAG9Rw0YATA3MDUGCCsGAQUFBwIBFilodHRwOi8vd3d3LnRlbGVzZWMuZGUvc2VydmVycGFzcy9jcHMuaHRtbDAdBgNVHSUEFjAUBggrBgEFBQcDAQYIKwYBBQUHAwIwDQYJKoZIhvcNAQELBQADggEBAFRO6OOXlSsTAKv4Hp2jvIzMQIwwTZJMkHs4qshiFVOrLSXe3dDxxBjgn87rbXL0X6rqHysnSzhlhbW6bUg2gAAcyXf4DBu/TEwYUhlLkzSFFHM9tioHWZmL1sgedl2x4vwnZbMpqRlQTINwWbV0Ey5TfqGw84LoC0SXCzRoV3ta1tsZDIXS5UBuEZXMJ2ElvjqYbEnJhHjUqWRuCtbVlRHJ05EqigDLzv2Qm0Q5MluQq/Qc4SK1WZQ+PGOv2yU/VXdItYirD4LYBAsI2o2Abq5o/tjtjQeynj3NxqrF1Qd0/SHjQXE+ZMU+M7glP9e3jjwd9liavUKsF8O6wLha73g=-----END CERTIFICATE-----```

It's not a valid PEM file and the ZLint command provides a fatal error. It does not panic. This is pretty reasonable. It wasn't presented with a valid certificate to lint.

When you do pass in a valid PEM,
```-----BEGIN CERTIFICATE-----
MIIEyTCCA7GgAwIBAgINBnUDUrQShFEl9jfPmDANBgkqhkiG9w0BAQsFADBBMRUwEwYDVQQDDAxUZXN0IFN1YkNBIDIxDTALBgNVBAsMBFRlc3QxDDAKBgNVBAoMA01URzELMAkGA1UEBhMCREUwHhcNMTkxMTA0MDYzNTM2WhcNMjAxMTA0MDYzNTM2WjCBojEMMAoGA1UECgwDTVRHMRIwEAYDVQQHDAlEYXJtc3RhZHQxDzANBgNVBAgMBkhlc3NlbjELMAkGA1UEBhMCREUxHTAbBgNVBA8MFFByaXZhdGUgT3JnYW5pemF0aW9uMRgwFgYDVQRhGw9WQVRERS0xMjM0NTY3ODkxEjAQBgNVBAUTCTEyMzQ1Njc4OTETMBEGCysGAQQBgjc8AgEDDAJERTCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBANjJFjxxhlF2HKfm9gFWp4DMwUS5Qhb9Jomq2O425As5PCe9VCFNmV1X8a6wmADuWPPH3UD0BleveWnbtsj1IpU1Eo6uPwqeZQGJIKRuz6wgx9AZcbpXT5zgmf5VDDoVFn7sYvSc4a65FkfE2Ontamf0YuMDfpbZRS7nBzfojQFzKiB0OGvyC4icBMwGm+y11qwpuOImTzRljj3rAEboazF3o+8S8TyY712aXPQno4c3MSM1EqtZO+ILSBUy0ULzVWMFybI/WsnlqkpIpHQSFDX7V5ck8uiLLPrb/WnuE9EQXj4c2B8m8WlpUlAP9fMtqeddOqWSnxx4FAxhyUp9DPUCAwEAAaOCAVwwggFYMB8GA1UdIwQYMBaAFJZgP5yaf4gl4AHNZwhX0IYm8PFKMB0GA1UdDgQWBBTgmXRqGmcO54swL6B3XM95sawpYTAOBgNVHQ8BAf8EBAMCBaAwDAYDVR0TAQH/BAIwADAaBgNVHREEEzARgg93d3cuZXhhbXBsZS5jb20wYgYIKwYBBQUHAQEEVjBUMCgGCCsGAQUFBzAChhxodHRwOi8vY2EuZXhhbXBsZS5jb20vY2EuY3J0MCgGCCsGAQUFBzABhhxodHRwOi8vb2NzcC5leGFtcGxlLmNvbS9vY3NwMFkGA1UdIARSMFAwBwYFZ4EMAQEwRQYKKwYBBAG9Rw0YATA3MDUGCCsGAQUFBwIBFilodHRwOi8vd3d3LnRlbGVzZWMuZGUvc2VydmVycGFzcy9jcHMuaHRtbDAdBgNVHSUEFjAUBggrBgEFBQcDAQYIKwYBBQUHAwIwDQYJKoZIhvcNAQELBQADggEBAFRO6OOXlSsTAKv4Hp2jvIzMQIwwTZJMkHs4qshiFVOrLSXe3dDxxBjgn87rbXL0X6rqHysnSzhlhbW6bUg2gAAcyXf4DBu/TEwYUhlLkzSFFHM9tioHWZmL1sgedl2x4vwnZbMpqRlQTINwWbV0Ey5TfqGw84LoC0SXCzRoV3ta1tsZDIXS5UBuEZXMJ2ElvjqYbEnJhHjUqWRuCtbVlRHJ05EqigDLzv2Qm0Q5MluQq/Qc4SK1WZQ+PGOv2yU/VXdItYirD4LYBAsI2o2Abq5o/tjtjQeynj3NxqrF1Qd0/SHjQXE+ZMU+M7glP9e3jjwd9liavUKsF8O6wLha73g=
-----END CERTIFICATE-----```

The library does not panic and produces results as expected:

```{"e_basic_constraints_not_critical":{"result":"NA"},"e_ca_common_name_missing":{"result":"NA"},"e_ca_country_name_invalid":{"result":"NA"},"e_ca_country_name_missing":{"result":"NA"},"e_ca_crl_sign_not_set":{"result":"NA"},"e_ca_is_ca":{"result":"NA"},"e_ca_key_cert_sign_not_set":{"result":"NA"},"e_ca_key_usage_missing":{"result":"NA"},"e_ca_key_usage_not_critical":{"result":"NA"},"e_ca_organization_name_missing":{"result":"NA"},"e_ca_subject_field_empty":{"result":"NA"},"e_cab_dv_conflicts_with_locality":{"result":"NA"},"e_cab_dv_conflicts_with_org":{"result":"NA"},"e_cab_dv_conflicts_with_postal":{"result":"NA"},"e_cab_dv_conflicts_with_province":{"result":"NA"},"e_cab_dv_conflicts_with_street":{"result":"NA"},"e_cab_iv_requires_personal_name":{"result":"NA"},"e_cab_ov_requires_org":{"result":"NA"},"e_cert_contains_unique_identifier":{"result":"pass"},"e_cert_extensions_version_not_3":{"result":"pass"},"e_cert_policy_iv_requires_country":{"result":"NA"},"e_cert_policy_iv_requires_province_or_locality":{"result":"NA"},"e_cert_policy_ov_requires_country":{"result":"NA"},"e_cert_policy_ov_requires_province_or_locality":{"result":"NA"},"e_cert_unique_identifier_version_not_2_or_3":{"result":"NA"},"e_distribution_point_incomplete":{"result":"NA"},"e_dnsname_bad_character_in_label":{"result":"pass"},"e_dnsname_contains_bare_iana_suffix":{"result":"pass"},"e_dnsname_empty_label":{"result":"pass"},"e_dnsname_hyphen_in_sld":{"result":"pass"},"e_dnsname_label_too_long":{"result":"pass"},"e_dnsname_left_label_wildcard_correct":{"result":"pass"},"e_dnsname_not_valid_tld":{"result":"pass"},"e_dnsname_underscore_in_sld":{"result":"pass"},"e_dnsname_wildcard_only_in_left_label":{"result":"pass"},"e_dsa_correct_order_in_subgroup":{"result":"NA"},"e_dsa_improper_modulus_or_divisor_size":{"result":"NA"},"e_dsa_params_missing":{"result":"NA"},"e_dsa_shorter_than_2048_bits":{"result":"NA"},"e_dsa_unique_correct_representation":{"result":"NA"},"e_ec_improper_curves":{"result":"NA"},"e_ev_business_category_missing":{"result":"pass"},"e_ev_country_name_missing":{"result":"pass"},"e_ev_organization_name_missing":{"result":"pass"},"e_ev_serial_number_missing":{"result":"pass"},"e_ev_valid_time_too_long":{"result":"pass"},"e_ext_aia_marked_critical":{"result":"pass"},"e_ext_authority_key_identifier_critical":{"result":"pass"},"e_ext_authority_key_identifier_missing":{"result":"pass"},"e_ext_authority_key_identifier_no_key_identifier":{"result":"pass"},"e_ext_cert_policy_disallowed_any_policy_qualifier":{"result":"pass"},"e_ext_cert_policy_duplicate":{"result":"pass"},"e_ext_cert_policy_explicit_text_ia5_string":{"result":"NA"},"e_ext_cert_policy_explicit_text_too_long":{"result":"NA"},"e_ext_duplicate_extension":{"result":"pass"},"e_ext_freshest_crl_marked_critical":{"result":"NA"},"e_ext_ian_dns_not_ia5_string":{"result":"NA"},"e_ext_ian_empty_name":{"result":"NA"},"e_ext_ian_no_entries":{"result":"NA"},"e_ext_ian_rfc822_format_invalid":{"result":"NA"},"e_ext_ian_space_dns_name":{"result":"NA"},"e_ext_ian_uri_format_invalid":{"result":"NA"},"e_ext_ian_uri_host_not_fqdn_or_ip":{"result":"NA"},"e_ext_ian_uri_not_ia5":{"result":"NA"},"e_ext_ian_uri_relative":{"result":"NA"},"e_ext_key_usage_cert_sign_without_ca":{"result":"pass"},"e_ext_key_usage_without_bits":{"result":"pass"},"e_ext_name_constraints_not_critical":{"result":"NA"},"e_ext_name_constraints_not_in_ca":{"result":"NA"},"e_ext_policy_constraints_empty":{"result":"NA"},"e_ext_policy_constraints_not_critical":{"result":"NA"},"e_ext_policy_map_any_policy":{"result":"NA"},"e_ext_san_contains_reserved_ip":{"result":"pass"},"e_ext_san_directory_name_present":{"result":"pass"},"e_ext_san_dns_name_too_long":{"result":"pass"},"e_ext_san_dns_not_ia5_string":{"result":"pass"},"e_ext_san_edi_party_name_present":{"result":"pass"},"e_ext_san_empty_name":{"result":"pass"},"e_ext_san_missing":{"result":"pass"},"e_ext_san_no_entries":{"result":"pass"},"e_ext_san_not_critical_without_subject":{"result":"pass"},"e_ext_san_other_name_present":{"result":"pass"},"e_ext_san_registered_id_present":{"result":"pass"},"e_ext_san_rfc822_format_invalid":{"result":"pass"},"e_ext_san_rfc822_name_present":{"result":"pass"},"e_ext_san_space_dns_name":{"result":"pass"},"e_ext_san_uniform_resource_identifier_present":{"result":"pass"},"e_ext_san_uri_format_invalid":{"result":"pass"},"e_ext_san_uri_host_not_fqdn_or_ip":{"result":"pass"},"e_ext_san_uri_not_ia5":{"result":"pass"},"e_ext_san_uri_relative":{"result":"pass"},"e_ext_subject_directory_attr_critical":{"result":"NA"},"e_ext_subject_key_identifier_critical":{"result":"pass"},"e_ext_subject_key_identifier_missing_ca":{"result":"NA"},"e_ext_tor_service_descriptor_hash_invalid":{"result":"NA"},"e_generalized_time_does_not_include_seconds":{"result":"NA"},"e_generalized_time_includes_fraction_seconds":{"result":"NA"},"e_generalized_time_not_in_zulu":{"result":"NA"},"e_ian_bare_wildcard":{"result":"NA"},"e_ian_dns_name_includes_null_char":{"result":"NA"},"e_ian_dns_name_starts_with_period":{"result":"NA"},"e_ian_wildcard_not_first":{"result":"NA"},"e_inhibit_any_policy_not_critical":{"result":"NA"},"e_international_dns_name_not_nfc":{"result":"pass"},"e_international_dns_name_not_unicode":{"result":"pass"},"e_invalid_certificate_version":{"result":"pass"},"e_issuer_dn_country_not_printable_string":{"result":"pass"},"e_issuer_field_empty":{"result":"pass"},"e_name_constraint_empty":{"result":"NA"},"e_name_constraint_maximum_not_absent":{"result":"NA"},"e_name_constraint_minimum_non_zero":{"result":"NA"},"e_old_root_ca_rsa_mod_less_than_2048_bits":{"result":"NA"},"e_old_sub_ca_rsa_mod_less_than_1024_bits":{"result":"NA"},"e_old_sub_cert_rsa_mod_less_than_1024_bits":{"result":"NA"},"e_onion_subject_validity_time_too_large":{"result":"NA"},"e_path_len_constraint_improperly_included":{"result":"pass"},"e_path_len_constraint_zero_or_less":{"result":"pass"},"e_public_key_type_not_allowed":{"result":"pass"},"e_qcstatem_etsi_present_qcs_critical":{"result":"NA"},"e_qcstatem_etsi_type_as_statem":{"result":"NA"},"e_qcstatem_mandatory_etsi_statems":{"result":"NA"},"e_qcstatem_qccompliance_valid":{"result":"NA"},"e_qcstatem_qclimitvalue_valid":{"result":"NA"},"e_qcstatem_qcpds_valid":{"result":"NA"},"e_qcstatem_qcretentionperiod_valid":{"result":"NA"},"e_qcstatem_qcsscd_valid":{"result":"NA"},"e_qcstatem_qctype_valid":{"result":"NA"},"e_root_ca_extended_key_usage_present":{"result":"NA"},"e_root_ca_key_usage_must_be_critical":{"result":"NA"},"e_root_ca_key_usage_present":{"result":"NA"},"e_rsa_exp_negative":{"result":"pass"},"e_rsa_mod_less_than_2048_bits":{"result":"pass"},"e_rsa_no_public_key":{"result":"pass"},"e_rsa_public_exponent_not_odd":{"result":"pass"},"e_rsa_public_exponent_too_small":{"result":"pass"},"e_san_bare_wildcard":{"result":"pass"},"e_san_dns_name_includes_null_char":{"result":"pass"},"e_san_dns_name_onion_not_ev_cert":{"result":"NA"},"e_san_dns_name_starts_with_period":{"result":"pass"},"e_san_wildcard_not_first":{"result":"pass"},"e_serial_number_longer_than_20_octets":{"result":"pass"},"e_serial_number_not_positive":{"result":"pass"},"e_signature_algorithm_not_supported":{"result":"pass"},"e_spki_rsa_encryption_parameter_not_null":{"result":"pass"},"e_sub_ca_aia_does_not_contain_ocsp_url":{"result":"NA"},"e_sub_ca_aia_marked_critical":{"result":"NA"},"e_sub_ca_aia_missing":{"result":"NA"},"e_sub_ca_certificate_policies_missing":{"result":"NA"},"e_sub_ca_crl_distribution_points_does_not_contain_url":{"result":"NA"},"e_sub_ca_crl_distribution_points_marked_critical":{"result":"NA"},"e_sub_ca_crl_distribution_points_missing":{"result":"NA"},"e_sub_cert_aia_does_not_contain_ocsp_url":{"result":"pass"},"e_sub_cert_aia_marked_critical":{"result":"pass"},"e_sub_cert_aia_missing":{"result":"pass"},"e_sub_cert_cert_policy_empty":{"result":"pass"},"e_sub_cert_certificate_policies_missing":{"result":"pass"},"e_sub_cert_country_name_must_appear":{"result":"pass"},"e_sub_cert_crl_distribution_points_does_not_contain_url":{"result":"NA"},"e_sub_cert_crl_distribution_points_marked_critical":{"result":"NA"},"e_sub_cert_eku_missing":{"result":"pass"},"e_sub_cert_eku_server_auth_client_auth_missing":{"result":"pass"},"e_sub_cert_given_name_surname_contains_correct_policy":{"result":"NA"},"e_sub_cert_key_usage_cert_sign_bit_set":{"result":"pass"},"e_sub_cert_key_usage_crl_sign_bit_set":{"result":"pass"},"e_sub_cert_locality_name_must_appear":{"result":"pass"},"e_sub_cert_locality_name_must_not_appear":{"result":"pass"},"e_sub_cert_not_is_ca":{"result":"pass"},"e_sub_cert_or_sub_ca_using_sha1":{"result":"pass"},"e_sub_cert_postal_code_must_not_appear":{"result":"pass"},"e_sub_cert_province_must_appear":{"result":"pass"},"e_sub_cert_province_must_not_appear":{"result":"pass"},"e_sub_cert_street_address_should_not_exist":{"result":"pass"},"e_sub_cert_valid_time_longer_than_39_months":{"result":"pass"},"e_sub_cert_valid_time_longer_than_825_days":{"result":"pass"},"e_subject_common_name_max_length":{"result":"pass"},"e_subject_common_name_not_from_san":{"result":"NA"},"e_subject_contains_noninformational_value":{"result":"pass"},"e_subject_contains_reserved_arpa_ip":{"result":"NA"},"e_subject_contains_reserved_ip":{"result":"pass"},"e_subject_country_not_iso":{"result":"pass"},"e_subject_dn_country_not_printable_string":{"result":"pass"},"e_subject_dn_not_printable_characters":{"result":"pass"},"e_subject_dn_serial_number_max_length":{"result":"pass"},"e_subject_dn_serial_number_not_printable_string":{"result":"pass"},"e_subject_email_max_length":{"result":"pass"},"e_subject_empty_without_san":{"result":"pass"},"e_subject_given_name_max_length":{"result":"pass"},"e_subject_info_access_marked_critical":{"result":"NA"},"e_subject_locality_name_max_length":{"result":"pass"},"e_subject_not_dn":{"result":"pass"},"e_subject_organization_name_max_length":{"result":"pass"},"e_subject_organizational_unit_name_max_length":{"result":"pass"},"e_subject_postal_code_max_length":{"result":"pass"},"e_subject_printable_string_badalpha":{"result":"pass"},"e_subject_state_name_max_length":{"result":"pass"},"e_subject_street_address_max_length":{"result":"pass"},"e_subject_surname_max_length":{"result":"pass"},"e_tbs_signature_rsa_encryption_parameter_not_null":{"result":"pass"},"e_utc_time_does_not_include_seconds":{"result":"pass"},"e_utc_time_not_in_zulu":{"result":"pass"},"e_validity_time_not_positive":{"result":"pass"},"e_wrong_time_format_pre2050":{"result":"pass"},"n_ca_digital_signature_not_set":{"result":"NA"},"n_contains_redacted_dnsname":{"result":"pass"},"n_ecdsa_ee_invalid_ku":{"result":"NA"},"n_multiple_subject_rdn":{"result":"pass"},"n_san_dns_name_duplicate":{"result":"pass"},"n_sub_ca_eku_missing":{"result":"NA"},"n_sub_ca_eku_not_technically_constrained":{"result":"NA"},"n_subject_common_name_included":{"result":"pass"},"w_ct_sct_policy_count_unsatisfied":{"result":"info","details":"Certificate had 0 embedded SCTs. Browser policy may require 2 for this certificate."},"w_distribution_point_missing_ldap_or_uri":{"result":"NA"},"w_dnsname_underscore_in_trd":{"result":"pass"},"w_dnsname_wildcard_left_of_public_suffix":{"result":"pass"},"w_eku_critical_improperly":{"result":"pass"},"w_ext_aia_access_location_missing":{"result":"pass"},"w_ext_cert_policy_contains_noticeref":{"result":"pass"},"w_ext_cert_policy_explicit_text_includes_control":{"result":"NA"},"w_ext_cert_policy_explicit_text_not_nfc":{"result":"NA"},"w_ext_cert_policy_explicit_text_not_utf8":{"result":"NA"},"w_ext_crl_distribution_marked_critical":{"result":"NA"},"w_ext_ian_critical":{"result":"NA"},"w_ext_key_usage_not_critical":{"result":"pass"},"w_ext_policy_map_not_critical":{"result":"NA"},"w_ext_policy_map_not_in_cert_policy":{"result":"NA"},"w_ext_san_critical_with_subject_dn":{"result":"pass"},"w_ext_subject_key_identifier_missing_sub_cert":{"result":"pass"},"w_ian_iana_pub_suffix_empty":{"result":"NA"},"w_issuer_dn_leading_whitespace":{"result":"pass"},"w_issuer_dn_trailing_whitespace":{"result":"pass"},"w_multiple_issuer_rdn":{"result":"pass"},"w_name_constraint_on_edi_party_name":{"result":"NA"},"w_name_constraint_on_registered_id":{"result":"NA"},"w_name_constraint_on_x400":{"result":"NA"},"w_qcstatem_qcpds_lang_case":{"result":"NA"},"w_qcstatem_qctype_web":{"result":"NA"},"w_root_ca_basic_constraints_path_len_constraint_field_present":{"result":"NA"},"w_root_ca_contains_cert_policy":{"result":"NA"},"w_rsa_mod_factors_smaller_than_752":{"result":"pass"},"w_rsa_mod_not_odd":{"result":"pass"},"w_rsa_public_exponent_not_in_range":{"result":"pass"},"w_san_iana_pub_suffix_empty":{"result":"pass"},"w_sub_ca_aia_does_not_contain_issuing_ca_url":{"result":"NA"},"w_sub_ca_certificate_policies_marked_critical":{"result":"NA"},"w_sub_ca_eku_critical":{"result":"NA"},"w_sub_ca_name_constraints_not_critical":{"result":"NA"},"w_sub_cert_aia_does_not_contain_issuing_ca_url":{"result":"pass"},"w_sub_cert_certificate_policies_marked_critical":{"result":"pass"},"w_sub_cert_eku_extra_values":{"result":"pass"},"w_sub_cert_sha1_expiration_too_long":{"result":"NA"},"w_subject_contains_malformed_arpa_ip":{"result":"NA"},"w_subject_dn_leading_whitespace":{"result":"pass"},"w_subject_dn_trailing_whitespace":{"result":"pass"}}

As such this doesn't look like a bug.

What I meant was that the in the unit tests the panic is uncaught. I simply added the cert to the list of test certificates in one of the test files. When running
go test -v lints/*
this results in
--- FAIL: TestEtsiQcCompliance (0.00s)
panic: PEM decode failed! [recovered]
        panic: PEM decode failed!

goroutine 431 [running]:
testing.tRunner.func1(0xc0000f4200)
        /usr/local/go/src/testing/testing.go:874 +0x3a3
panic(0x7cbb80, 0x90d4e0)
        /usr/local/go/src/runtime/panic.go:679 +0x1b2
command-line-arguments.ReadCertificate(0xc00029afe0, 0x1c, 0x16)
        /home/fstrenzke/go/src/github.com/zmap/zlint/lints/testingUtil.go:40 +0x1fa
command-line-arguments.TestEtsiQcCompliance(0xc0000f4200)
        /home/fstrenzke/go/src/github.com/zmap/zlint/lints/lint_qcstatem_qccompliance_valid_test.go:35 +0x357
testing.tRunner(0xc0000f4200, 0x8b1000)
        /usr/local/go/src/testing/testing.go:909 +0xc9
created by testing.(*T).Run
        /usr/local/go/src/testing/testing.go:960 +0x350
FAIL    command-line-arguments  0.178s
FAIL

But I assume the only way to deal with this would be to recover from the panic within the lint and possibly then return a fatal result.

@cryptosource-GmbH (are you also @falko-strenzke btw or are we talking to two people?) I agree with @zakird's assessment here. The panic in your last comment seems like working-as-expected behaviour to me. If you add a corrupt test file to a unit test a panic seems like a reasonable response. I see it as a developer facing problem to a developer introduced issue. The ReadCertificate function from lints/testingUtils.go in your trace was deliberately implemented to panic on invalid test input:
https://github.com/zmap/zlint/blob/7314deb0a2a11b829a1144d21ec75d16b587e8f4/lints/testingUtil.go#L38-L41

I assume the only way to deal with this would be to recover from the panic within the lint and possibly then return a fatal result.

I think a more targeted fix would be to change the implementation of ReadCertificate to return (*x509.Certificate, error), return nil and an error when there's a PEM decode panic, and then update all of the callers to check for a non-nil error.
I'm mostly sharing the above to point out an alternative. I don't think it is a good idea to implement. It's a fair amount of find/replace work for the small win of changing the developer experience of adding buggy test data from seeing a panic to seeing an error.

I'm going to close this issue since it seems we've settled on a wontfix outcome. The discussion can continue in this thread if needed. Thanks!

yes, it's the same person ;-) I agree, we can close the thread. Thank you both for your suggestions.


Minor aesthetic and slightly pedantic perhaps ... a drag icon

But persistent enough to keep bugging me and my hack attempts of the styles involved in LT given CSS were unable to resolve this issue:
When I drag a panel (e.g. console, tabset), in Linux, I get this godawful new-document kind of icon instead of a "proper hand icon of some sort".
Now I know I'm a minority using Linux but I guess not if you are frequent user of LT I'd assume, I was wondering if anyone else has this problem and how to (preferably from within LT of course, if it is everywhere) fix this. Because it is killing some of the appeal of the slick-modern editor.
It's not a major turn-off but difficult enough to not have a clue where to look on either internet searches or elsewhere so I figured I'd start here.

Input or solutions please advice
edit: since a picture says more than a thousand words ...
screenshot

Just to add to this, I was unable to reproduce the issue on Ubuntu + KDE, so I think this may be GTK specific.

cldwalker: yea I would say so too... next time I'm hacking the CSS I'll take another round at it, most of it wanted to see if anyone else had this or if it was mostly me/limited.
joshuafcole: ok, thanks for the feedback. I'll refine my searches aimed more towards that, as I'm fairly sure I should be able to override this on platform and not in webkit/css.
Cheers.


Added Entity::HasCollision, Entity::MaxSpeed, Entity::SetProofs

about the Entity Proofs thing, I'm thinking of making a different system where you can get and set each individual proof

I'd do it via simple "IsBulletProof" etc. properties. We can additionally store those values as fields in the entity class, so they are updated correctly when set (since you have to set all of them in one go apparently).

or you could just read and write the bit directly from memory...

something like this would work for bulletproof
bool Entity::BulletProof::get()
{
UINT64 Address = MemoryAccess::GetAddressOfEntity(this->Handle);
return Address != 0 ? bitTest((int*)(Address + 392), 5) : false;
}

Getting and setting individual proofs have been implemented and tested in #313


Error "unable to resolve class Library" with<EMAIL_ADDRESS>

Since 15.0.1 we see this error validating our Jenkins script:
Jenkinsfile.groovy
  0     error    Unknown parsing error: "Jenkinsfile.groovy: 1: unable to resolve class Library for annotation\n @ line 1, column 1.\n   @Library('ff-pipeline-lib@LKG') _\n   ^\n"  NglParseError

The problematic line of code looks like this:
  @Library('ff-pipeline-lib@LKG') _

I am using the "recommended-jenkinsfile" configuration.
I tried against these currently available versions:
15.0.0 - Good
15.0.1 - Bad
15.0.2 - Bad

I am also seeing this issue when using the latest code/container image

We are facing the same issue.

Meanwhile we find a fix, you can try with --no-parse as workaround

We stick to the previous 15.0.0 version as a workaround.

We have pinned the version at 15.0.0 for now as well. Thanks for the suggestion @nvuillam

Facing the same issue but using version 15.0.0 is the workaround we used.

Bump. Don't close please

Same issue, using 15.0.0.

Yes, this issue prevents us from using a newer version. Please fix! Thank you!

I still would like to see this issue resolved

Running npm-groovy-lint via https://github.com/super-linter/super-linter bindle which has upgraded it to 15.0.2 yesterday and now we're hitting the below:
    0     error    Unknown parsing error: "/github/workspace/ami_build/Jenkinsfile: 2: unable to resolve class Library for annotation
   @ line 2, column 1.
     @Library('shared-library') _
     ^
  "  NglParseError

Is there any way to disable them via groovylintrc.json?

unstale


Make render/pick tests use the scene

Most old low-level primitive rendering tests that use render directly can be updated to use the real Cesium Scene, like DebugModelMatrixPrimitiveSpec does, which makes the tests more realistic and more concise.

Billboards/Labels were updated in #2669

@lilleyse after #817, we'll start chipping away at this (not all at once, we'll split it into several pull requests).  To see the files that need to be updated, search in all files for Specs/render.  An easy file to start with is probably ViewportQuadSpec.js.  Look at DebugModelMatrixPrimitiveSpec.js for a simple example.

@lilleyse let's start with ViewportQuadSpec and GroundPrimitiveSpec today.

[ ] DebugAppearanceSpec
[ ] EllipsoidPrimitiveSpec
[ ] EllipsoidSurfaceAppearanceSpec
[ ] GeometryRenderingSpec
[ ] GlobeSpec
[ ] GlobeSurfaceTileProviderSpec
[ ] GroundPrimitiveSpec // Just remove the reference; it is not used
[ ] MaterialAppearanceSpec
[ ] MaterialSpec
[ ] PerInstanceColorAppearanceSpec
[ ] PolygonSpec
[ ] PolylineCollectionSpec
[ ] PolylineColorAppearanceSpec
[ ] PolylineMaterialAppearanceSpec
[ ] PrimitiveCollectionSpec
[ ] PrimitiveCullingSpec
[ ] PrimitiveSpec
[ ] RectanglePrimitiveSpec
[ ] SceneSpec // Not sure we'll do this one
[ ] ViewportQuadSpec

Should all these pull requests go into their own branch, like renderer-refactor in #640 ?

Yes, one branch per pull request.  The branch may have one or more refactored specs.

I mean should the master repo have a branch called spec-refactor, like how I made my renderer pull requests go into renderer-refactor?

Ah, sorry.  No, it is fine to open the pull request directly into master.

GlobeSpec was updated in 8f20940.

@lilleyse can you also update the new tests in PrimitiveSpec.js in the 3d-tiles branch?
[runJsHint] Specs/Scene/PrimitiveSpec.js: line 402, col 9, 'frameState' is not defined.
[runJsHint] Specs/Scene/PrimitiveSpec.js: line 403, col 9, 'frameState' is not defined.
[runJsHint] Specs/Scene/PrimitiveSpec.js: line 404, col 9, 'us' is not defined.
[runJsHint] Specs/Scene/PrimitiveSpec.js: line 404, col 28, 'frameState' is not defined.
[runJsHint] Specs/Scene/PrimitiveSpec.js: line 406, col 9, 'ClearCommand' is not defined.
[runJsHint] Specs/Scene/PrimitiveSpec.js: line 409, col 9, 'render' is not defined.
[runJsHint] Specs/Scene/PrimitiveSpec.js: line 409, col 25, 'frameState' is not defined.
[runJsHint] Specs/Scene/PrimitiveSpec.js: line 439, col 39, 'frameState' is not defined.

@lilleyse can we close this?  If not, what is left?  I took a quick look at SceneSpec and I'm not sure that we need to make any changes there.  Do we still need to update tests to use renderForSpecs?

@lasalvavida is working on a final cleanup PR for any files not included on this list, so until that is ready we can leave this open.

Thanks for the great work on this @lasalvavida.


Raw actions

Add a way for actions to be executed without having colors parsed.
Some other stuff that might be disabled for raw actions: placeholder parsing, action parsing.
I don't even know how this would work. Would this just be a new action? [player:raw]/[player:no-colors]? Or would this be a tag similar to <delay=1>?
Me and
Glare think this is just going to add way more complexity than benefits. A user has requested this feature for a specific case (see attached image)

I like the idea of it being a tag  similar to

Having it be a tag seems like it could be really nice, add it to any action and it just skips parsing the colors.


change generate kafka connect properties from env

Resolves https://github.com/datahub-project/datahub/issues/10544
Checklist

[ ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[x] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
[ ] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Summary by CodeRabbit

New Features

Enhanced Kafka setup script to automatically generate connection properties from environment variables using a new Python script.

Chores

Updated Kafka setup process to improve configuration management.

Thanks!


I have also notice when i change profiles in Evlui the gse debugger pops up every time !

I have also notice when i change profiles in Evlui the gse debugger pops up every time !
Originally posted by @Timf63 in https://github.com/TimothyLuke/GSE-Advanced-Macro-Compiler/discussions/1076#discussioncomment-1804759

I can’t make this happen with Elv and GSE.  As it doesn’t happen without Elv either marking this as unable to be replicated and suspect it’s an Elv issue.


[whatsapp-api-client-cpp] Build error on x64-windows

Hello, please help, I can’t assemble my package
Package<EMAIL_ADDRESS>Host Environment

Host: x64-windows
Compiler: MSVC 19.40.33811.0
vcpkg-tool version: 2024-06-10-02590c430e4ed9215d27870138c2e579cc338772
vcpkg-scripts version: 101cc9a69 2024-06-30 (12 hours ago)

To Reproduce
vcpkg install whatsapp-api-client-cpp
Failure logs
-- Note: whatsapp-api-client-cpp only supports static library linkage. Building static library.
-- Using cached green-api-whatsapp-api-client-cpp-0.0.1.tar.gz.
-- Extracting source F:/projects/GREEN-API/C++/whatsapp-api-client-cpp/vcpkg/downloads/green-api-whatsapp-api-client-cpp-0.0.1.tar.gz
-- Using source at F:/projects/GREEN-API/C++/whatsapp-api-client-cpp/vcpkg/buildtrees/whatsapp-api-client-cpp/src/0.0.1-692377cfed.clean
-- Found external ninja('1.11.0').
-- Configuring x64-windows
-- Building x64-windows-dbg
CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:134 (message):
    Command failed: "C:/Program Files/CMake/bin/cmake.exe" --build . --config Debug --target install -- -v -j17
    Working Directory: F:/projects/GREEN-API/C++/whatsapp-api-client-cpp/vcpkg/buildtrees/whatsapp-api-client-cpp/x64-windows-dbg
    See logs for more information:
      F:\projects\GREEN-API\C++\whatsapp-api-client-cpp\vcpkg\buildtrees\whatsapp-api-client-cpp\install-x64-windows-dbg-out.log
      F:\projects\GREEN-API\C++\whatsapp-api-client-cpp\vcpkg\buildtrees\whatsapp-api-client-cpp\install-x64-windows-dbg-err.log

Call Stack (most recent call first):
  installed/x64-windows/share/vcpkg-cmake/vcpkg_cmake_build.cmake:74 (vcpkg_execute_build_process)
  installed/x64-windows/share/vcpkg-cmake/vcpkg_cmake_install.cmake:16 (vcpkg_cmake_build)
  F:/projects/GREEN-API/C++/whatsapp-api-client-cpp/custom-overlay/whatsapp-api-client-cpp/portfile.cmake:16 (vcpkg_cmake_install)
  scripts/ports.cmake:192 (include)

F:\projects\GREEN-API\C++\whatsapp-api-client-cpp\vcpkg\buildtrees\whatsapp-api-client-cpp\install-x64-windows-dbg-err.log
ninja: error: unknown target 'install'

F:\projects\GREEN-API\C++\whatsapp-api-client-cpp\vcpkg\buildtrees\whatsapp-api-client-cpp\install-x64-windows-dbg-out.log
Change Dir: 'F:/projects/GREEN-API/C++/whatsapp-api-client-cpp/vcpkg/buildtrees/whatsapp-api-client-cpp/x64-windows-dbg'

Run Build Command(s): "C:/Program Files/Microsoft Visual Studio/2022/Community/Common7/IDE/CommonExtensions/Microsoft/CMake/Ninja/ninja.exe" -v -v -j17 install

The whatsapp-api-client-cpp port does not exist in vcpkg. Did you add this port yourself?

@jimwang118
Hello, yes, there is no port in vcpkg at the moment, I’m just trying to add it there, following the instructions https://learn.microsoft.com/ru-ru/vcpkg/get_started/get-started-packaging?pivots=shell -cmd
I created vcpkg.json and portfile, but at step 5 after entering the command with my parameters
vcpkg install vcpkg-sample-library --overlay-ports=C:\path\to\custom-overlay I get an error

I think I understand, I need to make a pull request to the main repository with my vcpkg and portfile files.
And the instructions I follow are just for local checking.

Did you compile successfully after adding whatsapp-api-client-cpp to your local repository?

Thanks for posting this issue. Please reopen this issue if this is still a problem for you.


[Dynamic Regions] resolved ts and gc safepoint can't advance

Bug Report

What version of TiKV are you using?

TiKV
Release Version:   7.5.0-alpha
Edition:           Community
Git Commit Hash:   64d2129a0c21bc1e8521c38dd144a327baa88965
Git Commit Branch: heads/refs/tags/v7.5.0
UTC Build Time:    2023-10-10 05:27:03
Rust Version:      rustc 1.67.0-nightly (96ddd32c4 2022-11-14)
Enable Features:   pprof-fp jemalloc mem-profiling portable sse test-engine-kv-rocksdb test-engine-raft-raft-engine cloud-aws cloud-gcp cloud-azure
Profile:           dist_release
What operating system and CPU are you using?

Steps to reproduce

The cluster contains about 50 tikv with dynamic region enabled, each tikv contains 2.5TB data, a table contains about 6billion rows with each row size about 10kb. insert, large delete and select workload.

What did you expect?
What did happened?

/severity major
/assign @overvenus

The root cause is that there are some locks that not release.  aysnc_write maybe blocked

The root cause is that the apply thread blocked by deadlock , so it can't notify the txn scheduler to release this lock .
Thread 102 (Thread 0x7fd3457bf640 (LWP 128) "apply-0"):
#0  0x00007fd3c387d39a in __futex_abstimed_wait_common () from /lib64/libc.so.6
#1  0x00007fd3c387fba0 in pthread_cond_wait@@GLIBC_2.3.2 () from /lib64/libc.so.6
#2  0x00005565f53ac1d0 in std::condition_variable::wait(std::unique_lockstd::mutex&) ()
#3  0x00005565f5819d3b in rocksdb::WriteThread::BlockingAwaitState(rocksdb::WriteThread::Writer*, unsigned char) ()
#4  0x00005565f5819e93 in rocksdb::WriteThread::AwaitState(rocksdb::WriteThread::Writer*, unsigned char, rocksdb::WriteThread::AdaptationContext*) ()
#5  0x00005565f581b7ef in rocksdb::WriteThread::EnterUnbatched(rocksdb::WriteThread::Writer*, rocksdb::InstrumentedMutex*) ()
#6  0x00005565f56f8f77 in rocksdb::DBImpl::FlushMemTable(rocksdb::ColumnFamilyData*, rocksdb::FlushOptions const&, rocksdb::FlushReason, bool) ()
#7  0x00005565f56fb7e5 in rocksdb::DBImpl::Flush(rocksdb::FlushOptions const&, rocksdb::ColumnFamilyHandle*) ()
#8  0x00005565f588df2f in rocksdb::WriteBufferManager::MaybeFlushLocked(rocksdb::DB*) ()
#9  0x00005565f56e3e11 in rocksdb::DBImpl::PreprocessWrite(rocksdb::WriteOptions const&, rocksdb::DBImpl::LogContext*, rocksdb::DBImpl::WriteContext*) ()
#10 0x00005565f56ea290 in rocksdb::DBImpl::WriteImpl(rocksdb::WriteOptions const&, rocksdb::WriteBatch*, rocksdb::WriteCallback*, unsigned long*, unsigned long, bool, unsigned long*, unsigned long, rocksdb::PreReleaseCallback*, rocksdb::PostWriteCallback*) ()
#11 0x00005565f56eb617 in rocksdb::DBImpl::Write(rocksdb::WriteOptions const&, rocksdb::WriteBatch*, rocksdb::PostWriteCallback*) ()
#12 0x00005565f55e88ca in crocksdb_write_callback ()
#13 0x00005565f3c039bc in <engine_rocks::write_batch::RocksWriteBatchVec as engine_traits::write_batch::WriteBatch>::write_callback_opt ()
#14 0x00005565f3c74fa0 in raftstore_v2::operation::command::<impl raftstore_v2::raft::apply::Apply<EK,R>>::flush ()
#15 0x00005565f48c71ed in <core::future::from_generator::GenFuture as core::future::future::Future>::poll ()
#16 0x00005565f47b67c3 in <core::future::from_generator::GenFuture as core::future::future::Future>::poll ()
#17 0x00005565f43581e9 in <core::future::from_generator::GenFuture as core::future::future::Future>::poll ()
#18 0x00005565f5391f0b in <yatp::task::future::Runner as yatp::pool::runner::Runner>::handle ()
#19 0x00005565f3ab3a7e in <tikv_util::yatp_pool::YatpPoolRunner as yatp::pool::runner::Runner>::handle ()
Thread 110 (Thread 0x7fd3447b7640 (LWP 136) "rocksdb:low"):
#0  0x00007fd3c387d39a in __futex_abstimed_wait_common () from /lib64/libc.so.6
#1  0x00007fd3c387fba0 in pthread_cond_wait@@GLIBC_2.3.2 () from /lib64/libc.so.6
#2  0x00005565f53ac1d0 in std::condition_variable::wait(std::unique_lockstd::mutex&) ()
#3  0x00005565f5b21289 in rocksdb::ThreadPoolImpl::Impl::BGThread(unsigned long) ()
#4  0x00005565f5b2160e in rocksdb::ThreadPoolImpl::Impl::BGThreadWrapper(void*) ()
#5  0x00005565f53e1c34 in execute_native_thread_routine ()
#6  0x00007fd3c3880802 in start_thread () from /lib64/libc.so.6
#7  0x00007fd3c3820314 in clone () from /lib64/libc.so.6
(gdb) thread apply 111 bt -n 30
Thread 111 (Thread 0x7fd343fb6640 (LWP 137) "rocksdb:low"):
#0  0x00007fd3c387d39a in __futex_abstimed_wait_common () from /lib64/libc.so.6
#1  0x00007fd3c387fba0 in pthread_cond_wait@@GLIBC_2.3.2 () from /lib64/libc.so.6
#2  0x00005565f53ac1d0 in std::condition_variable::wait(std::unique_lockstd::mutex&) ()
#3  0x00005565f5b21289 in rocksdb::ThreadPoolImpl::Impl::BGThread(unsigned long) ()
#4  0x00005565f5b2160e in rocksdb::ThreadPoolImpl::Impl::BGThreadWrapper(void*) ()
#5  0x00005565f53e1c34 in execute_native_thread_routine ()
#6  0x00007fd3c3880802 in start_thread () from /lib64/libc.so.6
#7  0x00007fd3c3820314 in clone () from /lib64/libc.so.6

Close this issue temporarily since Dynamic Regions project is paused.


Android assemble cannot package

Version

react-native-router-flux v3.38.1
react-native v0.44.0

Expected behaviour
Assembled a release: gradlew assembleRelease
Expected it to build .apk
Actual behaviour
Build failed:
bundle: Copying 12 asset files
bundle: Done copying assets
:app:processReleaseManifest UP-TO-DATE
:app:processReleaseResources
/Users/kyle/gz/fermion/android/app/build/intermediates/res/merged/release/drawable-mdpi/node_modules_reactnativerouterflux_node_modules_reactnative_libraries_customcomponents_navigationexperimental_assets_backicon.png: error: Invalid filename.  Unable to add.
:app:processReleaseResources FAILED
FAILURE: Build failed with an exception.
Steps to reproduce
run  ./gradlew assembleRelease

Same here
verision
    "react-native": "0.44.0",
    "react-native-router-flux": "^3.38.1",
    "react-native-simple-store": "^1.2.0",
    "react-native-vector-icons": "^4.1.1",

shell output
This warning is caused by a @providesModule declaration with the same name across two different files.
Loading dependency graph, done.
warning: the transform cache was reset.
bundle: start
bundle: finish
bundle: Writing bundle output to: /Users/imalik/code/IdeaProjects/jamaat/AMJNamazzeiten/Gebetszeiten/android/app/build/intermediates/assets/release/index.android.bundle
bundle: Copying 12 asset files
bundle: Done writing bundle output
bundle: Done copying assets
:app:processReleaseManifest UP-TO-DATE
:app:processReleaseResources
/Users/imalik/code/IdeaProjects/jamaat/AMJNamazzeiten/Gebetszeiten/android/app/build/intermediates/res/merged/release/drawable-mdpi/node_modules_reactnativerouterflux_node_modules_reactnative_libraries_customcomponents_navigationexperimental_assets_backicon.png: error: Invalid filename.  Unable to add.

:app:processReleaseResources FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:processReleaseResources'.
> com.android.ide.common.process.ProcessException: Failed to execute aapt

Please check 3.39.1. Sorry, I can't verify android, but iOS Example project works fine.

Try with 3.38.0 and same for me
 "react": "16.0.0-alpha.6",
 "react-native": "0.44.0",
 "react-native-code-push": "^2.0.3-beta",
 "react-native-router-flux": "^3.38.0",

Does this have to do something with maximum byte number?
see: https://github.com/aksonov/react-native-experimental-navigation/issues/1#issuecomment-301360042

@iNeedCode I don't know but I confirm updating the library to 3.39.1 fix release Android