Manifest updates resulting from #174

Motivation
Update modelmesh-serving manifests in the opendatahub/odh-manifests directory to sync with the manifest changes in config/ resulting from the commits included in this sync
Modifications

Copied over the new 0.11.0 manifests over to opendatahub/odh-manifests/model-mesh/odh-modelmesh-controller

Result
CRD version on the main branch is updated to 0.11.0
PR checklist
Checklist items below are applicable for development targeted to both fast and stable branches/tags

[x] Unit tests pass locally
[ ] FVT tests pass locally
[x] If the PR adds a new container image or updates the tag of an existing image (not build within cpaas), is the corresponding change made in live-builder and cpaas-midstream to add/update the image tag in the operator CSV? Link the PRs if applicable

Checklist items below are applicable for development targeted to both fast and stable branches/tags

[x] Tested modelmesh serving deployment with odh-manifests and ran odh-manifests-e2e tests locally

Testing Instructions

Check out the PR from github and use the opendatahub quickstarts to deploy modelmesh serving using the manifests in opendatahub/odh-manifests/model-mesh. Ensure Model Serving functionality works as intended

changes included in https://github.com/opendatahub-io/modelmesh-serving/pull/181/files


[NFC] Modify AccessScope to allow checks for package access level

Add checks to distinguish between public and package access level.
Add enum AccessLimitKind to be used by AccessScope::Value
Resolves rdar://103534243

@swift-ci test

@swift-ci test

@elsh could you please squash the commits?

@elsh could you please squash the commits?

I usually do it at the time of merge. Is it to make reviews easier? I usually just go to the 'Files Changed' tab to see all the changes at once.

@swift-ci test

@swift-ci test

🎉


Wrong text object for an argument before a brace

Not sure the title is correct. The example is (JavaScript):
new Foo('bar', {
    ...

When the cursor is on 'bar' and daa is pressed, the result is:
new Foo(, {

The source of this problem is the same one as #22, but it's a different issue, so fair enough. It should be fixed on the branch single-arguments-on-multiple-lines, so, like I said in #22, try it out for a while, and I'll merge it to master if it's stable.

I've merged the branch, so I'll go ahead and close this issue. Reopen if it turns out there's some related bug.


time stamp of velodyne packets does not changed

Problem
Expected Behavior
rostopic echo /velodyne_packets/header
seq: 0
stamp:
  secs:<PHONE_NUMBER>
  nsecs: 959228516      <--------nsec
frame_id: velodyne
---
seq: 1
stamp:
  secs:<PHONE_NUMBER>
  nsecs:  60075283   <----------nsec  is changed,usually.
frame_id: velodyne
---

Actual Behavior
rostopic echo /velodyne_packets/header
seq: 4699
stamp:
  secs: 904636608
  nsecs:     32663       <--------nsec
frame_id: "velodyne"
---
seq: 4700
stamp:
  secs: 904636608    <----------sec  is not changed and  it should be about<PHONE_NUMBER>.
  nsecs:     32663      <----------nsec is not changed .
frame_id: "velodyne"
---

Steps to Reproduce the Problem
1.connect VelodyneVLP-16
2. start Runtime manager and select sencing tab and  click  Velodyne VLP-16
3. check  time stamp of /velodyne_packets.
it also happened Velodyne32C
It always occurs on a specific PC.
Specifications

Ubuntu version:16.04
ROS version:kinetic
Autoware branch:master 1.9.1 Autoware branch:master 1.6.1

@maedaseiya told me that the following command fixed the problem. I'm not sure why.

touch ~/Autoware_1.9.1/ros/src/sensing/drivers/lidar/packages/velodyne/velodyne_driver/src/lib/input.cc
cd ~/Autoware_1.9.1/ros
source devel/setup.sh
catkin_make

Make sure you don't have the lidar configured to double returns.


spawn without mobs

I have a spawner without mods, mobiplugin plugins, what is the problem

?

Use MobPlugin from Cloudburst

Используйте MobPlugin от Cloudburst

lol, the mobs in the background don't say anything?! Of course I use this plugin

Hey,
Please read this message as I think it has the same reason: https://github.com/KCodeYT/VanillaGenerator/issues/8#issuecomment-1159400833

This issue should be fixed with the 0.0.5-SNAPSHOT update.


(fix): jest shouldn't transform json files in node_modules

not sure why ts-jest was picking these up and giving warnings, but
TSDX's custom transformIgnorePatterns is different from jest's
default (everything in node_modules), so set it to ignore json too

Fixes #161
@jaredpalmer is there a reason TSDX has a custom transformIgnorePattern? It's been like that since one of the first commits so idk.
Jest's default is just /node_modules/, so not sure why TSDX's is slightly different. To allow for transforming TS files in node_modules?

#513 fixes the root cause of this


ci: dest already exists flake

#!/bin/bash -eo pipefail test/ci/_before_script.js
Downloading Electron v1.4.13 before running tests...
Error: dest already exists.
     at /home/circleci/project/node_modules/@electron/get/node_modules/fs-extra/lib/move/move.js:41:31
     at /home/circleci/project/node_modules/@electron/get/node_modules/universalify/index.js:23:46
  Exited with code exit status 1 CircleCI received exit code 1

https://app.circleci.com/pipelines/github/electron/electron-packager/659/workflows/2f15c4a1-abc2-49a9-ac13-81ad1561b738/jobs/2958

Additional debug info:
Downloading Electron v1.4.13 before running tests...
  @electron/get:index Checking the cache (undefined) for SHASUMS256.txt (https://github.com/electron/electron/releases/download/v1.4.13/SHASUMS256.txt) +0ms
  @electron/get:index Cache miss +3ms
  @electron/get:index Downloading https://github.com/electron/electron/releases/download/v1.4.13/SHASUMS256.txt to /tmp/electron-download-PI1wXV/SHASUMS256.txt with options: undefined +59ms
  @electron/get:cache Moving /tmp/electron-download-PI1wXV/SHASUMS256.txt to /home/circleci/.cache/electron/4660c2617dcac48c05988e181e4f7ff85132cd278bba79561816d3e7da1cc50c/SHASUMS256.txt +0ms
  @electron/get:index No arch found, defaulting to the host arch +162ms
  @electron/get:index Checking the cache (/home/circleci/.electron) for electron-v1.4.13-linux-ia32.zip (https://github.com/electron/electron/releases/download/v1.4.13/electron-v1.4.13-linux-ia32.zip) +1ms
  @electron/get:index Checking the cache (/home/circleci/.electron) for electron-v1.4.13-win32-ia32.zip (https://github.com/electron/electron/releases/download/v1.4.13/electron-v1.4.13-win32-ia32.zip) +0ms
  @electron/get:index Checking the cache (/home/circleci/.electron) for electron-v1.4.13-darwin-x64.zip (https://github.com/electron/electron/releases/download/v1.4.13/electron-v1.4.13-darwin-x64.zip) +0ms
  @electron/get:index Checking the cache (/home/circleci/.electron) for electron-v1.4.13-linux-x64.zip (https://github.com/electron/electron/releases/download/v1.4.13/electron-v1.4.13-linux-x64.zip) +0ms
  @electron/get:index Checking the cache (/home/circleci/.electron) for electron-v1.4.13-mas-x64.zip (https://github.com/electron/electron/releases/download/v1.4.13/electron-v1.4.13-mas-x64.zip) +1ms
  @electron/get:index Checking the cache (/home/circleci/.electron) for electron-v1.4.13-win32-x64.zip (https://github.com/electron/electron/releases/download/v1.4.13/electron-v1.4.13-win32-x64.zip) +0ms
  @electron/get:index Checking the cache (/home/circleci/.electron) for electron-v1.4.13-linux-armv7l.zip (https://github.com/electron/electron/releases/download/v1.4.13/electron-v1.4.13-linux-armv7l.zip) +0ms
  @electron/get:index Checking the cache (/home/circleci/.electron) for electron-v6.0.0-darwin-x64.zip (https://github.com/electron/electron/releases/download/v6.0.0/electron-v6.0.0-darwin-x64.zip) +0ms
  @electron/get:index Cache miss +1ms
  @electron/get:index Cache miss +0ms
  @electron/get:index Cache miss +0ms
  @electron/get:index Cache miss +0ms
  @electron/get:index Cache miss +1ms
  @electron/get:index Cache miss +0ms
  @electron/get:index Cache miss +0ms
  @electron/get:index Cache miss +0ms
  @electron/get:index Downloading https://github.com/electron/electron/releases/download/v1.4.13/electron-v1.4.13-linux-ia32.zip to /tmp/electron-download-3O1eel/electron-v1.4.13-linux-ia32.zip with options: undefined +0ms
  @electron/get:index Downloading https://github.com/electron/electron/releases/download/v1.4.13/electron-v1.4.13-win32-ia32.zip to /tmp/electron-download-1OI9ji/electron-v1.4.13-win32-ia32.zip with options: undefined +0ms
  @electron/get:index Downloading https://github.com/electron/electron/releases/download/v1.4.13/electron-v1.4.13-darwin-x64.zip to /tmp/electron-download-Ws7TgH/electron-v1.4.13-darwin-x64.zip with options: undefined +1ms
  @electron/get:index Downloading https://github.com/electron/electron/releases/download/v1.4.13/electron-v1.4.13-linux-x64.zip to /tmp/electron-download-hS3Oc8/electron-v1.4.13-linux-x64.zip with options: undefined +0ms
  @electron/get:index Downloading https://github.com/electron/electron/releases/download/v1.4.13/electron-v1.4.13-mas-x64.zip to /tmp/electron-download-Vc5xwC/electron-v1.4.13-mas-x64.zip with options: undefined +0ms
  @electron/get:index Downloading https://github.com/electron/electron/releases/download/v1.4.13/electron-v1.4.13-win32-x64.zip to /tmp/electron-download-mJHTDK/electron-v1.4.13-win32-x64.zip with options: undefined +0ms
  @electron/get:index Downloading https://github.com/electron/electron/releases/download/v1.4.13/electron-v1.4.13-linux-armv7l.zip to /tmp/electron-download-lbtzTp/electron-v1.4.13-linux-armv7l.zip with options: undefined +0ms
  @electron/get:index Downloading https://github.com/electron/electron/releases/download/v6.0.0/electron-v6.0.0-darwin-x64.zip to /tmp/electron-download-T8gn8V/electron-v6.0.0-darwin-x64.zip with options: undefined +0ms
  @electron/get:index Checking the cache (/home/circleci/.electron) for SHASUMS256.txt (https://github.com/electron/electron/releases/download/v1.4.13/SHASUMS256.txt) +2s
  @electron/get:index Cache miss +1ms
  @electron/get:index Downloading https://github.com/electron/electron/releases/download/v1.4.13/SHASUMS256.txt to /tmp/electron-download-Zcln1Z/SHASUMS256.txt with options: undefined +1ms
  @electron/get:index Checking the cache (/home/circleci/.electron) for SHASUMS256.txt (https://github.com/electron/electron/releases/download/v1.4.13/SHASUMS256.txt) +26ms
  @electron/get:index Cache miss +1ms
  @electron/get:index Downloading https://github.com/electron/electron/releases/download/v1.4.13/SHASUMS256.txt to /tmp/electron-download-oB433U/SHASUMS256.txt with options: undefined +0ms
  @electron/get:index Checking the cache (/home/circleci/.electron) for SHASUMS256.txt (https://github.com/electron/electron/releases/download/v1.4.13/SHASUMS256.txt) +31ms
  @electron/get:index Cache miss +1ms
  @electron/get:index Downloading https://github.com/electron/electron/releases/download/v1.4.13/SHASUMS256.txt to /tmp/electron-download-gaC39r/SHASUMS256.txt with options: undefined +1ms
  @electron/get:index Checking the cache (/home/circleci/.electron) for SHASUMS256.txt (https://github.com/electron/electron/releases/download/v1.4.13/SHASUMS256.txt) +26ms
  @electron/get:index Cache miss +0ms
  @electron/get:index Downloading https://github.com/electron/electron/releases/download/v1.4.13/SHASUMS256.txt to /tmp/electron-download-mSMl8f/SHASUMS256.txt with options: undefined +1ms
  @electron/get:index Checking the cache (/home/circleci/.electron) for SHASUMS256.txt (https://github.com/electron/electron/releases/download/v1.4.13/SHASUMS256.txt) +28ms
  @electron/get:index Cache miss +1ms
  @electron/get:index Downloading https://github.com/electron/electron/releases/download/v1.4.13/SHASUMS256.txt to /tmp/electron-download-SeHepQ/SHASUMS256.txt with options: undefined +1ms
  @electron/get:cache Moving /tmp/electron-download-Zcln1Z/SHASUMS256.txt to /home/circleci/.electron/4660c2617dcac48c05988e181e4f7ff85132cd278bba79561816d3e7da1cc50c/SHASUMS256.txt +2s
  @electron/get:index Checking the cache (/home/circleci/.electron) for SHASUMS256.txt (https://github.com/electron/electron/releases/download/v1.4.13/SHASUMS256.txt) +26ms
  @electron/get:index Cache hit +2ms
  @electron/get:cache Moving /tmp/electron-download-gaC39r/SHASUMS256.txt to /home/circleci/.electron/4660c2617dcac48c05988e181e4f7ff85132cd278bba79561816d3e7da1cc50c/SHASUMS256.txt +12ms
  @electron/get:cache * Replacing existing file +0ms
  @electron/get:cache Moving /tmp/electron-download-mSMl8f/SHASUMS256.txt to /home/circleci/.electron/4660c2617dcac48c05988e181e4f7ff85132cd278bba79561816d3e7da1cc50c/SHASUMS256.txt +7ms
  @electron/get:cache Moving /tmp/electron-download-oB433U/SHASUMS256.txt to /home/circleci/.electron/4660c2617dcac48c05988e181e4f7ff85132cd278bba79561816d3e7da1cc50c/SHASUMS256.txt +12ms
  @electron/get:cache * Replacing existing file +1ms
  @electron/get:cache Moving /tmp/electron-download-SeHepQ/SHASUMS256.txt to /home/circleci/.electron/4660c2617dcac48c05988e181e4f7ff85132cd278bba79561816d3e7da1cc50c/SHASUMS256.txt +18ms
Error: dest already exists.
    at /home/circleci/project/node_modules/@electron/get/node_modules/fs-extra/lib/move/move.js:41:31
    at /home/circleci/project/node_modules/@electron/get/node_modules/universalify/index.js:23:46


[2.0] Ignite i18n

Create a plugin which handles i18n

Complete.

I'd like to see this split out into its own repo, btw.

#791


Cant place enchanted book in soldener

I cant place enchanted book in soldener
Cant make Silk touch upgrade
refinedstorage-1.2.11
forge-1.10.2-<IP_ADDRESS>5-universal

Can't reproduce. Some other mod is causing a conflict with RS.

I made a fortune 3 book from combining fortune 2 books, and i cant place that in a solderer
Does the solderer check enchanted books for nbt? Because if so, minecraft adds the repaircost tag when you combine things in an anvil, and if the solderer expects no nbt but it has that, it wouldnt allow the book
Or am i overthinking this?

Aha, that might be it. Didn't test with repairing.


Add new tarot corpus

WIP - so far just the major arcana

[x] Update sign to be an array (will need for minor arcana)
[x] Add Wands
[x] Add Cups
[x] Add Swords
[x] Add Pentacles

LGTM :shipit: :fishsticks:


Clarification on files in config_discriminator.yaml

I'm hoping for clarification on the files passed into config_discriminator.yaml.
As I understand it:

dis_positive_data and dis_source_data are 1 million random lines from the original target (o_dst) and source training files (o_src), manually padded with  to length 50 (I wrote my own script to do this). These files are created using the same files used in generator pretraining. Must we pad the sentences ourselves as I have?
dis_negative_data (negative_bpe_u8.txt) is the output from sh generate_sample.sh predicted using o_src
dis_src_vocab and dis_dst_vocab are BPE vocabulary lists corresponding to the vocabulary of all BPEs used in o_dst and o_src. The vocabulary lists are created by running o_dst and o_src through vocab.py

alternatively, since I am running the en-de translation, should I expect to use vocab.bpe.32000 for src_vocab and dst_vocab instead of separate vocab files with 38831/34432 words, as in the demo config?

Is my understanding correct? Can you please provide clarification on how the files in the discriminator pretraining are created?
For context, I am trying to solve an issue where when running the discriminator pretraining, my loss falls to 2-3, but the accuracy always oscillates around 0.5 - even after 700K steps.

@kellymarchisio Firstly, Thanks for your contributions to this code.  Actually, your understanding is right. However, the vocabulary file is a little different from vocab.bpe.32000 released by en-de wmt corpora in the artificial tokens, such as "PAD", "", "/S" and "UNK". These tokens are utilized for preparing the training data. You only need to add these four tokens manually at the begin of the vocab.bpe.32000.  I checked the log file in our experiments again, I find that in our experiments, the discriminator achieves accuracy with 0.7 after 2-epochs training.

@ZhenYangIACAS Thanks so much for the response :)  Unfortunately I'm still not able to get discriminator pretraining to work, and I believe it's because I haven't figured out the file formats. Is it possible for you to give a sample line from each file so I can verify that mine are in the right format?
In config_generate_sample.yaml:

my src_path is 1mil random lines from my training file (GS_SP), which is the same file used in config_generator_train.yaml-train:src_path (GT_SP), except in GS_SP I have edited every line to be just 50 words. Lines in GS_SP thus look like this:

<S> Has one of your friends or relatives participated on a Budapest Mar@@ athon of Hal@@ f-@@ mar@@ athon ? </S> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD>

The same line in GT_SP looks like this:

Has one of your friends or relatives participated on a Budapest Mar@@ athon of Hal@@ f-@@ mar@@ athon ?

If a line in GT_SP was > 50 words, its matching line in GS_SP looks like this:

<S> Wenn Sie den Bericht , speziell die Begründung des Berichts , lesen , werden Sie sehen , in wel@@ ch sk@@ andal@@ öser Weise die höheren Autor@@ itäten hier im Parlament und speziell in der Europäischen Union mit den Rechten des Parlaments um@@ springen . Es wird da immer wieder

Question: Are lines in GS_SP supposed to have <S> </S> and <PAD> as I have demonstrated, and are they supposed to still be in BPE? Was I supposed to write my own script to convert GT_SP to lines of length 50 in this format to become GS_SP? (That is what I did)
After running config_generate_sample.yaml with GS_SP, it outputs negative_predictions.txt. Lines in negative_predictions.txt look like this:

Es ist Aufgabe der Kommission und des Rates , sie zu übersetzen .

In config_discriminator_pretrain.yaml:

my dis_positive_data is 1mil random lines from my training file (DP_DP) and is the same file used in config_generator_train.yaml-train:dst_path (GT_DP), except in DP_DP I have edited every line to be just 50 words. Lines in DP_DP thus look like this:

<S> Ex@@ por@@ tieren Sie Ihre Adressen aus dem anderen Programm in einem der erforderlichen Formate . </S> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD>

dis_negative_data is the same file produced from sample generation, thus has the format:

Es ist Aufgabe der Kommission und des Rates , sie zu übersetzen .

dis_source_data is the exact same file as GS_SP, thus has the format:

<S> Has one of your friends or relatives participated on a Budapest Mar@@ athon of Hal@@ f-@@ mar@@ athon ? </S> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD> <PAD>

Do these file formats appear correct?  I have tried a number of different formats but have unfortunately not been successful.  I'm sure it's something small in the way I'm setting up the files, but I haven't been able to pinpoint what that is!
Thanks so much :)

In my project,  when running the discriminator pretraining, my loss also falls to 0-2, but the accuracy always oscillates around 0.5. I wonder what kind of problems may cause that? Thanks.

@jeicy07 In my project, the silly reason this behaviour was caused was because my pickled dictionary was built incorrectly. I fixed it to make sure it was a string:int mapping of word:id. When this was broken, my entire src/trg/neg matrices were written as 1s  (for UNK).  It sounds like the behaviour you observe is symptomatic of indistinguishable matrices.  Try logging the final matrices you feed into the discriminator, to see if you observe anything unusual. Then backtrack from there.

Thanks, I've tried to convert my pickled dictionary into a dict. Finally, it works!

@ZhenYangIACAS Thanks very much for your response. After fixing some errors, I also achieve accuracy 0.70 after 2 epochs.  I notice though that the accuracy bounces around quite significantly as seen here:

testing the accuracy on the evaluation sets when epoch 1, samples 3400000
the total accuracy in evaluation is 0.714286
testing the accuracy on the evaluation sets when epoch 1, samples 3410000
the total accuracy in evaluation is 0.708494
testing the accuracy on the evaluation sets when epoch 1, samples 3420000
the total accuracy in evaluation is 0.722008
testing the accuracy on the evaluation sets when epoch 1, samples 3430000
the total accuracy in evaluation is 0.735521
testing the accuracy on the evaluation sets when epoch 1, samples 3440000
the total accuracy in evaluation is 0.700772

Is this expected, or a bug?
I also notice that loss alternates between very high values and lower values at the beginning of training:

epoch 0, samples 100, loss 8.257384, accuracy 0.510000 BatchTime 21.912569
epoch 0, samples 200, loss 109.485771, accuracy 0.500000 BatchTime 1.326053
epoch 0, samples 300, loss 26.595387, accuracy 0.500000 BatchTime 1.261572
epoch 0, samples 400, loss 109.342659, accuracy 0.500000 BatchTime 1.244808
epoch 0, samples 500, loss 24.455862, accuracy 0.500000 BatchTime 1.179417
epoch 0, samples 600, loss 101.686081, accuracy 0.500000 BatchTime 1.192621

Is this also expected, and what might cause this behavior? I would expect loss to monotonically decrease.
Thanks very much for releasing this code base - I've enjoyed working with it.

@ @kellymarchisio  I am sorry for late response.  Your loss is so strange that it varies significantly ranging from the upper bound and lower bound. In our experiments, the loss should decrease smoothly. Have you shuffled your training data?

@ZhenYangIACAS  Yes, the training data is being shuffled.  Now on Epoch 5, the model has begun to overfit.  The peak was ~0.71-0.72 in earlier epochs. This config I'm using is below. Does anything look amiss here?

src_vocab: '/local/scratch/kvm23/angec_final/yang-gan/model_data/data_gan_ende_4.5mil_test/generate_data/vocab.bpe.32000.e'
dst_vocab: '/local/scratch/kvm23/angec_final/yang-gan/model_data/data_gan_ende_4.5mil_test/generate_data/vocab.bpe.32000.e'
src_vocab_size: 32000
dst_vocab_size: 32000
hidden_units: 512
scale_embedding: True
attention_dropout_rate: 0.0
residual_dropout_rate: 0.1
num_blocks: 6
num_heads: 8
binding_embedding: False
train:
logdir: '/local/scratch/kvm23/angec_final/yang-gan/experience/ende-4.5mil-test/dis_pretrain/4'
dis_src_vocab: '/local/scratch/kvm23/angec_final/yang-gan/model_data/data_gan_ende_4.5mil_test/dis_pretrain/vocab.bpe.32000.e.pkl'
dis_dst_vocab: '/local/scratch/kvm23/angec_final/yang-gan/model_data/data_gan_ende_4.5mil_test/dis_pretrain/vocab.bpe.32000.e.pkl'
dis_max_epoches: 10
dis_dispFreq: 1
dis_saveFreq: 100
dis_devFreq: 100
dis_batch_size: 100
dis_saveto: '/local/scratch/kvm23/angec_final/yang-gan/models/ende-4.5mil-test/4/disc_pretrain'
dis_reshuffle: True
dis_gpu_device: 'gpu-0'
dis_max_len: 50
dis_positive_data: '/local/scratch/kvm23/angec_final/yang-gan/model_data/data_gan_ende_4.5mil_test/dis_pretrain/4/train.tok.clean.bpe.32000.de.shuf.1mil-chop60'
dis_negative_data: '/local/scratch/kvm23/angec_final/yang-gan/model_data/data_gan_ende_4.5mil_test/dis_pretrain/4/negative_predictions.txt'
dis_source_data: '/local/scratch/kvm23/angec_final/yang-gan/model_data/data_gan_ende_4.5mil_test/dis_pretrain/4/train.tok.clean.bpe.32000.en.shuf.1mil-chop60'
dis_dev_positive_data: '/local/scratch/kvm23/angec_final/yang-gan/model_data/data_gan_ende_4.5mil_test/dis_pretrain/4/train.tok.clean.bpe.32000.de.shuf.300.dev'
dis_dev_negative_data: '/local/scratch/kvm23/angec_final/yang-gan/model_data/data_gan_ende_4.5mil_test/dis_pretrain/4/negative_predictions.dev.txt'
dis_dev_source_data: '/local/scratch/kvm23/angec_final/yang-gan/model_data/data_gan_ende_4.5mil_test/dis_pretrain/4/train.tok.clean.bpe.32000.en.shuf.300.dev'
dis_dev_log: '/local/scratch/kvm23/angec_final/yang-gan/experience/ende-4.5mil-test/dis_pretrain/4/dev_log-trial2'
dis_reload: True
dis_clip_c: 1.0
dis_dim_word: 512
dis_optimizer: 'rmsprop'
dis_scope: 'discnn'

@kellymarchisio There is no obvious error for your configuration.

@ZhenYangIACAS thanks for taking a look. To verify, should dis_positive_data, dis_negative_data, etc. look like regular sentences like:

This is a sentence .

Or do I have to pad the text file sent to the config so they look like:

 This is a sentence .    ...

I believe I've tried both, but your verification would be helpful.

@kellymarchisio You do not need to add the padding to the files manually. The code will do it automatically.

@ZhenYangIACAS Thank you for the clarification. According to your paper, I won't be able to reproduce the GAN training unless I get 82% accuracy.  A few quick related questions:

Are there any other parameters (perhaps not mentioned in the paper) necessary to get the discriminator to 82-95% performance?
Did you use pretrained word embeddings?
What initialisation did you use, and what was the tuning to get to higher accuracy?
How many epochs did it take to get to 95% accuracy?
Can you think of a reason why my loss bounces around so much at the beginning of training? (Could this signify a bug in the code?)

I am sure that all of the parameters which show much effect on the translation performance are described detailed in our paper. We did not use pre-trained word embeddings. You can find the initialization method in our code. I remember that when we use the Transformer as the generator, the accuracy is hard to get to more than 90%.  For your problem, it seems that a bug exists, but I am not sure.

@kellymarchisio How did you find dev accuracy in discriminator? I am using transformer as a generator. Code for finding dev accuracy is commented in cnn_discriminator.py file. I used this code but it shows several values in validation accuracy and they vary a lot.

@kellymarchisio  Hi，Can you show me your data sample in config_discriminator_pretrain.yaml？for example，dis_positive_data  dis_negative_data and so on.
thanks

@ZhenYangIACAS  Hi, I see  many data sample in config_discriminator_pretrain.yaml，for example： dis_positive_data，dis_negative_data，dis_dev_positive_data and so on，Can you tell me what means about this data？
What data do I need to prepare if Iwant to run the code successfully？
Thanks！！！！！

@ @luckper dis_positive_data is the positive data for training the discriminator and dis_negative_data is the negative data for training the discriminator. dis_dev_positive_data is the development data for training discriminator, and so on...For understanding these files, I suggest that you should scan gan_train.py. Some files are what you should prepare beforehand, and some other files are generated automatically. I notice that so many files are a little messy for the users. We will re-construct our codes if we have free time.

@ZhenYangIACAS  OK，pass your suggestion，I scan gan_train.py  . However, I still have some questions. First, where dis_dev_positive_data , dis_dev_negative_data , dis_dev_source_data come from? And what is different from dis_positive_data,dis_negative_data,dis_source_data?
Thanks!!!!!

@luckper I think it is easy to get the development data sets.  We just randomly sampled 200 sentences from the dis_positive_data to get the dis_dev_positive_data, and similarly, we get the corresponding dis_negative_data and dis_source_data.

@ZhenYangIACAS  Hi, I run the generate_sample.sh, but some errors have occurred:
Instructions for updating:
Use argmax instead
using rmsprop for g_loss
Traceback (most recent call last):
File "generate_samples.py", line 60, in
generate_samples(config)
File "generate_samples.py", line 32, in generate_samples
optimizer=config.train.optimizer)
File "/home/xxx/Downloads/ZKY-GAN_NMT/NMT_GAN-master/model.py", line 119, in build_generate
optimizer=tf.train.RMSPropOptimizer(self.config.generator.learning_rate)
File "/home/xxx/Downloads/ZKY-GAN_NMT/NMT_GAN-master/utils.py", line 19, in getattr
if type(self[item]) is dict:
KeyError: 'generator'
What is the reason? and the log file record as follows:
Instructions for updating:
Use argmax instead
INFO:root:using rmsprop for g_loss

@ZhenYangIACAS @luckper have you solved "KeyError: 'generator'" error.


Macro definitions in afx.h producing code analysis warnings

The IMPLEMENT_DYNAMIC macro in afx.h takes the following arguments:

the name of the class one is implementing
the name of the base class that the implemented class is to inherit from

The macro defines functions that override those of the base class. As per documentation, the macro is to be accompanied by DECLARE_DYNAMIC, inserted in the class declaration.
However, DECLARE_DYNAMIC does not use the noexcept and override keyword when declaring the overriding GetRuntimeClass function. So VS code analysis would emit the following warning at IMPLEMENT_DYNAMIC:

C26433 Function 'MyClass:GetRuntimeClass' should be marked with 'override' (c.128).
C26440 Function 'MyClass:GetRuntimeClass' can be declared 'noexcept' (f.6).

Test sample:
In .h:
class MyClass : public CDialogEx
{
    DECLARE_DYNAMIC(MyClass)
}

In .cpp:
IMPLEMENT_DYNAMIC(MyClass, CDialogEx)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fd00558d-bce5-b479-8eba-55f83b751857
Version Independent ID: 7c4c6c5c-1834-da74-4990-dff4542070fa
Content: Run-Time Object Model Services
Content Source: docs/mfc/reference/run-time-object-model-services.md
Product: visual-cpp
Technology: cpp-mfc
GitHub Login: @TylerMSFT
Microsoft Alias: twhitney

Hi @wmjdgla, it seems that you are reporting a product issue rather than a documentation issue, in this case due to the march of progress in the C++ language vs. MFC which was released in 1992.
If that is the case, you could consider bringing this up on
developer community where it will be seen by the product team.
Take care.


Short-term plan for this binding

Task list for the first milestone.
The first milestone should:

Be generally available for common SQL queries.
Have a fundamental docs API and can be released to npm.js automatically
Have the basic config API for essential configs.
Define a (unstable) data API (maybe on top of https://arrow.apache.org/docs/js/ ?)

Tasks:

[ ] Expose configuration APIs (SessionContext)
[ ] Define and expose RecordBatch
[ ] Support GCS and Azure Bolb
[ ] Support more kinds of queries (fix them in the "upstream" datafusion)

In addition to the to-do list above, I also want to gradually bring this project to a relatively stable release rhythm, such as regularly synchronizing upstream updates or releasing. This can ensure that the project has a basic vitality.
My personal goal for this project is to make it an official part of DataFusion (ref to https://github.com/apache/datafusion/issues/13815), just like the Python binding. People can easily use DataFusion for computations in more scenarios. At the same time, this project already has several application scenarios (datafusion-wasm-playground, parquet-viewer, or the ongoing one https://github.com/apache/datafusion/issues/13818), ensuring that the basic release rhythm can also facilitate existing projects to use it better.


Is the new way of extending the service configuration compatible with deployments using the previous approach?

In https://github.com/UCL-MIRSG/ansible-role-postgresql/pull/13 the way service definitions are extended was changed so that this role works on RHEL 9. Essentially the configuration has moved from:
/etc/systemd/system/{{ postgresql_service_name }}.service

to:
/etc/systemd/system/{{ postgresql_service_name }}.service.d/postgresql_service.conf

This is fine for new installs, but could there be any issues if there's already a configuration defined in the previous location?

Yep, it seems to work okay


Consider an alternative means to collect metrics and add alerts and notifications

Have a look at prometheus.io.

As of Spring Boot 2.0, https://micrometer.io seems like a good library to integrate. Would mean replacing DropWizard and ReadyTalk dependencies, gutting monitoring package in common module, and re-wiring MetricsAspect.

Completed with upgrade to Spring Boot 3.1and Spring Cloud 2022.


Buttons stop working over time

I'm making a device to automate humidity/temperature in a little tent.
I have 3 virtual buttons. When I run my program, just at the start they work as expected.
If my sensor get a given humidity value, it calls a function to increase it, after this point the buttons stop working
I'm using python 3.7 on a raspberry pi

Not enough info provided. Probably duplicate of #36


DOC: update sphinx requirements for doc building

Simplified the version requirement for sphinx (>= 1.3.2). In principle >= 1.2.2 but < 1.3.0 also works, but left it out for simplicity.
@cswarth Do you have other things that you find unclear about the requirements for the doc build environment?

I don't think clarity is the problem as much as being a relatively high barrier to entry for contributing to the docs.  By the time you get done installing all the prerequisites and optional dependencies, it feels quite onerous.  I used pip to install the optional dependencies as I ran across them, but often wished there were a requirements.txt (or more likely, Dockerfile) to establish a known working environment.

We could change the suggestions of conda create -n pandas_dev python=3 --file ci/requirements_dev.txt to ci/requirements_all.txt

docker is way too heavyweight for anything like this

We could change the suggestions of conda create -n pandas_dev python=3 --file ci/requirements_dev.txt to ci/requirements_all.txt

That is already mentioned in the section about creating a development environment (http://pandas-docs.github.io/pandas-docs-travis/contributing.html#creating-a-development-environment), but it would maybe made more prominent in the section on doc building requirements (instead of just linking to that section)

I only mentioned a dockerfile because I found there were extra-pythonic dependencies that were not captured by pip or conda.   For instance, I couldn't install matplotlib unless I first ran 'apt-get install pkg-config' and apt-get install libfreetype6-dev.

not true conda installs everything u need

[Current coverage][cc-pull] is 84.33%

Merging [#13532][cc-pull] into [master][cc-base-branch] will not change coverage

@@             master     #13532   diff @@
==========================================
  Files           138        138
  Lines         51111      51111
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits          43107      43107
  Misses         8004       8004
  Partials          0          0

Powered by Codecov. Last updated by [3944a36...d30cc3f][cc-compare]
[cc-base-branch]: https://codecov.io/gh/pydata/pandas/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/pydata/pandas/compare/3944a369265f27268d1b3867a161e97f9c63cd62...d30cc3f402535c3393caa2937c27f4fcb05b5594
[cc-pull]: https://codecov.io/gh/pydata/pandas/pull/13532?src=pr

I only mentioned a dockerfile because I found there were extra-pythonic dependencies that were not captured by pip or conda.

@cswarth If you had problems installing matplotlib with conda, you can report it over there, but normally this should just work.
I personally think the instructions of how to set up a development environment are already quite elaborate, but improvements are always welcome!
I reworded the reference to first creating a dev environment for building the docs to make this more clear.


feat(carSales): create and delete rejections

refs: https://autoricardo.atlassian.net/browse/CAR-6320
Adds PUT and DELETE actions for carSales rejections so the Dealer can reject draft carSales in the Client.

Not sure if we need the comment and the reason for the reject.

Yes they where just added, will update the PR


“Various Artists” albums don't show song artists

Hi,
Right now, if an album is marked as Various Artists, Kore will show the following when showing the album: tracknumber, title and track length.
But not the artist.
It is often hard to know what song you're about to play without the artist's name ;)
I think putting the artist's name where the track length currently is and moving track length to the right of that should work nicely to solve the issue.
Thanks!
axel

Done in #281


v0.13.0

Changelog:

Fixed a potential leak of the canary value that occurred when generating it on program startup.
Replaced the WipeBytes function with a Wipe method. A general function implied guarantees that we could not reasonably give to the user.
Added a Size method that returns the total size, in bytes, of a secure buffer.
Minor updates and optimisations.

Since #40 is also a breaking change, this PR is dependent on that being merged. This will reduce the number of reverse-incompatible releases.


Try --debug, -v env approach from ENV

new Kernel($_ENV['APP_ENV'], $_ENV['APP_DEBUG']);

Instead of shell internal resolution

Resolved by #1426


Add first battery of e2e tests for PHP

Add a first battery of simple PHP scripts that are executed with the PHP runtime built to WebAssembly. The result and timing of execution should be compared to the same PHP version, but built for a common architecture, such as x86_64.
Additionally, fuzzing could be added to this tests, so that we are able to detect error conditions that only happen in the wasm32-wasi target and not in a common architecture such as x86_64.

Please include at least one of the major frameworks doing simple operations. It's more than just a script but will represent a far better real world picture of the potential users. Anyone in the PHP world exploring a Wasm Based runtime is not going to be just writing a script or so.
https://symfony.com/
https://laravel.com/
These are probably the two biggest right now.


Online documentation needed

See also: #11
NumDot needs some introductions and proper online documentation pages, akin to the godot docs and the xtensor docs.
I cannot say which documentation system is best as i have not worked with any of them myself. It is very possible that the built-in documentation system we'll build in #11 can be used to auto-generate online pages. In that case, that would be the best approach.

Godot updates its online class reference automatically with doxygen, which feeds into Sphinx.
The doc-class primer describes that you have to run make rst in /doc to generate the html files. The folder includes a Makefile that we should be able to reverse engineer to run the same process for our classes.
Once this is done, we can probably integrate the workflow into godot-cpp.

Online documentation is now available: https://numdot.readthedocs.io/en/latest/


RNA Update

Fixes a capitalization bug in the callsets endpoint and adds a test ensuring that features exist for expression level objects. @dcolligan @saupchurch

+1


heroku deploy problem.

I'v been a lot of hours trying to solve this, and i just can't.
rmagick is working in my local machine, but when I deploy to Heroku, I get an application error.
I got
`require': No such file to load -- rmagick (LoadError)
and
: [3] ! Unable to load application: LoadError: No such file to load -- rmagick
I found several places with similar problems, but not the same, and I can't solve this.
I hope to find some light about this.
thanks.

Hello Javier :)
What does bundle list | grep rmagick tell you? What version of the gem you are using?
If it's older than 2.13.4, then require 'rmagick' simply does not work. There were simply no file named rmagick.rb in the old gem.
In this case, you need to write require 'RMagick'. In your Gemfile, you can write:
gem 'rmagick', require: 'RMagick'

Also you can bundle update rmagick and then require 'rmagick' will work.
Please let us know if this helps.

Hello  Vassilevsky and thanks for your answer.
This is embarrassing, but after take a rest. I saw the problem. I had wrote a test.rb file to test the code I needed with rmagic. I left this file in the assets/images folder, and forgot it. That was causing the problem, and for some reason the app worked in my local machine but not when deployed at heroku.
So, it just fine right now. thanks any way!.

Glad it worked :) Please have enough rest at all times. This is important for health!


Lodash is not tree shaked

Hi,
Great library !
Would it be possible to adjust the configuration so that Lodash is tree shaken correctly ?
From what I've noticed the distribution uses require module syntax and the whole of Lodash is imported. 76.1% of the code size is just lodash<EMAIL_ADDRESS>It would be so great if this could be tree shaken.
Thank you!

Resolved in v0.3.3.
Thanks @alinaMihai for the contribution

Thank you @azizali  for considering it !


Step 1 for early backers airdrop: generate JSONs

What happened?
Prepare the data for the airdrop .
Why?
Because the proposal https://gov.goldfinch.finance/t/retroactive-backer-distribution-proposal-3-with-data/252 was accepted
How has this been tested?
This is just a data preparation for already existing scripts
Checklist

[x] I have reviewed this code myself

Mainnet-forking tests passing for me locally.


feat: add ddev debug match-constraint

In playing with tests on an add-one I was going to query for the version of ddev with some bashism (like https://github.com/ddev/ddev/blob/fddf8c8df8e38ffd9214d6220140f9275640f636/.buildkite/sanetestbot.sh#L13) but then thought that ddev could easily do a much better job with the feature we already have, so I crafted this small PR.
To test this:
ddev debug match-constraint ">= 1.23.5" will work
ddev debug match-constraint ">= 1.23.6" will fail

Your intent here is not to verify the constraint, but rather to see if the DDEV version is valid with the constraint you offer?

This looks like a simpler version of:

#6361

Your intent here is not to verify the constraint, but rather to see if the DDEV version is valid with the constraint you offer?

correct

Maybe --match-constraint is better?

But for add-ons we have ddev_version_constraint for this purpose. What were you trying to do with your test?
(I certainly agree that checking in go is easier than bash)

i.e. in the context of a bats test:
if ddev version --verify-constraint ">= 1.23.5"; then
  ddev add-on get https://....
else
  ddev get https://....
fi

The above example is exactly what prompted be tu submit this, but I can think how this can be useful elsewhere, like in githooks and other potential team workflows.

rebased

docs added and flag name changed

Side note: 2>&1 > /dev/null is the same as &>/dev/null which is shorter (I don't ask to change it here).

Thanks, wasn't aware of that!

Another side note, &>/dev/null works only in bash 4+, not bash 3 (macOS).

The example is a bit of a catch-22, as you are asking if ddev is over 1.1.9 and then if it is over 1.23.5, but it only works on 1.24+ :D - but it is a good example of what you could have done or can do in the future

@rfay excellent suggestion and done.
@stasadev if you want to review again

Committed

I don't think one is needed, as the constraint logic is tested elsewhere, but it's also a simple test to add at least to make sure the command is there and works. Added test

You also have an error in there with "(EXTRA string=)", need to do the % right.

Does the test run locally successfully?

You have an ineffassign too, https://github.com/ddev/ddev/actions/runs/11615220037/job/32345253597?pr=6645
Make sure to do make staticrequired (have golangci-lint installed)

sorry, fixed that go error

So much pain! Seems to be building without tag information for some reason. This isn't my experience I don't think, and we have other things that do this class of test. You can use tmate to go into the test and use make testcmd TESTARGS="-run TestDebugMatchConstraintCmd" to see what's actually happening.

@hanoii, see example from my closed PR https://github.com/ddev/ddev/pull/6361/files#diff-037e1285dac63dbc94244f8cddceca76b2bc71adc43b9fb90827196a451e69b6R16-R27
We can reliably check only the invalid constraint, otherwise we need to skip the test.

How would I use tmate :)?

We can reliably check only the invalid constraint, otherwise we need to skip the test.

I see what you did, might give that a try if what I just pushed is not acceptable, but I think it might be for such a simple test.

How would I use tmate :)?

From your own fork, but you need to enable Actions first in Settings, and then:

I see what you did, might give that a try if what I just pushed is not acceptable, but I think it might be for such a simple test.

I like it, no need for more.

How would I use tmate :)?

tmate is a great tool for these confusing GitHub situations. It was Last week's Contributor Training.

And... we have some more things to learn. The buildkite tests didn't run here, saying

Skipping buildkite build since no code changes found

I was wondering why they didn't fail.

https://github.com/ddev/ddev/blob/608267b6f858ea1ff670fbd48b1d945b41807e94/.buildkite/test.sh#L160-L164
I don't see the problem at first glance, assume it's related to only new code.
I'll open an issue for it.
Thanks so much for working so diligently on these things @hanoii , sorry the pain level has been higher than any of us would expect.

If I cannot test the command behaving as expected, I don't see much of the purpose of adding what @stasadev mentioned, which is basically testing the functionality of the version constraint logic that already have tests.
I vote to remove the test.
Also I wonder, what would be the effort to have test build ddev as local with the proper tags or version?

Also I wonder, what would be the effort to have test build ddev as local with the proper tags or version?

I assume that the problem here is
https://github.com/ddev/ddev/blob/master/.github/workflows/pr-build.yml#L39-L44
But it absolutely says we're to be getting all branches and tags.
You could also do a make VERSION=<whatever> and the resultant ddevBin would have the named version. Maybe that would be fun!

But that's for building the artifacts. The tests seems to be using the hash

I added a little debugging and made the Makefile get all tags. Can't harm to try!
Rebased.

But that's for building the artifacts. The tests seems to be using the hash

The build is using the hash because it can't find any tags in git describe --tags --always --dirty.
make overrides the version.

Your fork has no recent tags in it, so I imagine that is related to what's going on.
Try this for fun:
git ls-remote --tags hanoii # assuming your fork's remote is named `hanoii`; you'll see no recent tags
git fetch upstream --tags #gets all the tags from the upstream repo, assume you've named it that
git push hanoii --tags --no-verify  # some may fail, but it's ok
git ls-remote --tags hanoii. # now all the tags will be there.

I just pushed all tags, so maybe you need to restart tests or push something else?

All you would have to do to restart all tests is git commit -m "run tests" --allow-empty" and git push`
We'll see what we learn, or feel free to do that if you want to do it in advance.

@rfay had fun last night with this, I see it was a matter of having the tags, I think though that something like what @stasadev needs to be added, otherwise this will fail for every other fork that doesn't pull in the tags, which will be a nightmare for you.

I'll fix the lint, add that, and I also went back to a more natural constraint.

ok, let's see, I cleaned up, I think doing --version is unnecessary as that is exactly the same that comes out of versionconstants.DdevVersion, correct me if I am wrong, but that seems to be the case.
This tests should pass, I will try to remove the tags and see if I can test this without them and make sure it's properly skipped.

Locally:
❯ GOTEST_SHORT=true make VERSION=24bfb07 testcmd TESTARGS="-run TestDebugMatchConstraintCmd"
...
Copying complete
=== RUN   TestDebugMatchConstraintCmd
    debug-match-constraint_test.go:18: Skipping because ddev version doesn't start with any valid version tag, it's '24bfb07'
--- SKIP: TestDebugMatchConstraintCmd (0.00s)
PASS
...

seems ok, if this is good enough for you maybe removing the tags is not necessary.

That’s not the case. And that is a valid version anyway
Reply might be shorter than usual / Respuesta más resumida que de costumbre
Enviado desde el celular / Sent from Mobile
On Fri, 1 Nov 2024 at 09:24 Stanislav Zhuk @.***> wrote:

@.**** commented on this pull request.
In cmd/ddev/cmd/debug-match-constraint_test.go
https://github.com/ddev/ddev/pull/6645#discussion_r1825762004:

if !versionRegex.MatchString(versionconstants.DdevVersion) {

t.Skip(fmt.Sprintf("Skipping because ddev version doesn't start with any valid version tag, it's '%v'", versionconstants.DdevVersion))

}

t.Skip won't run because versionconstants.DdevVersion =
v0.0.0-overridden-by-make when there is no tags.
Let me add another commit here. I'll add a better condition.
—
Reply to this email directly, view it on GitHub
https://github.com/ddev/ddev/pull/6645#pullrequestreview-2409977176, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFFP55RGDHKRMKTF3JUG43Z6NXH5AVCNFSM6AAAAABQRNJZ7SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMBZHE3TOMJXGY
.
You are receiving this because you were mentioned.Message ID:
@.***>

@rfay had fun last night with this, I see it was a matter of having the tags, I think though that something like what @stasadev suggested needs to be added, otherwise this will fail for every other fork that doesn't pull in the tags, which will be a nightmare for you.

Fixing this didn't have anything to do with you pushing those tags. It was that we (in only this case) weren't using the right actions/checkout option, so didn't fetch_depth. https://github.com/ddev/ddev/commit/00407fd09b9633a52001f94bc280c8d336bc3747
I think we all looked at that early, but I was looking at the wrong yaml file, so thought it was there, and it wasn't.

Note that v0.0.0-overridden-by-make means that the ddev binary was not built via make, so the git tag didn't get put in there.

It was that we (in only this case) weren't using the right actions/checkout option, so didn't fetch_depth.

Okay, I see.

And I understand now why I got nil here https://github.com/ddev/ddev/pull/6645#discussion_r1825775682
That's because I ran the test from PhpStorm, not from the terminal, so versionconstants.DdevVersion is good.
I'll revert my change for ddev --version, sorry for the fuss.


The document content needs to be corrected

Sandcastle example:  https://cesium.com/learn/cesiumjs-learn/cesiumjs-particle-systems/#boxemitter
Browser: All
Operating System: All

The emitter type in the BoxEmiiter sample code should be new Cesium BoxEmiiter() should not be new Cesium CircleEmiiter(), and the code does not match the sample image
BoxEmiiter 示例代码中的 emitter 类型应该是 new Cesium.BoxEmiiter() 而不应该是 new Cesium.CircleEmiiter()，并且代码与示例图片不匹配

Thanks @danchaotaiyang! I've made a fix on the website content which should be published shortly.


Floor opening cuts mess with element sketch (Element Sketch Collector)

Hi
I don't know that this is actually an issue with the Element Sketch Collector - it might be a Revit issue. But I'm curious to see, if there is a solution to this problem.
When I try to collect the element sketch of a floor with a floor opening cut (vertical opening), the output is the outline of one of the openings.
My current solution is to avoid using floor opening cuts, but that is not the most long lasting solution.
Thank you
##Tina

I can see where the problem comes from - The Element Sketch Collector relies on the correlation between Sketch Id and Element Id to be:
Sketch Id = Element Id -1
But when a floor opening cut is used, the Ids are shifted, and the sketch of one of the openings take over the Sketch Id of Element Id -1.

I tried to be smart and add this as a workaround that avoids rolling back transactions because that can be very slow on large files. Seems like it's not a solid option tho. I think it's best if there's another input controlling this behavior.

What I did find was, when I set the boolean to false, the curves came out correctly - so I did a very similar procedure to what you did in the script. I did a delete and roll back procedure to collect all the related Ids, then I filtered out the model lines by element name and matched them with the outlines I had found from the curves (found with your node) by the location of the centerpoints.


Tweak reads to not require a recordId

From https://github.com/TBD54566975/dwn-sdk-js/issues/468
This is a first pass, currently it accepts either recordId or protocol with protocolPath for a RecordsRead.
If the latest record is disallowed by protocol rules or not implicitly/explicitly allowed it will fail with a 401.
There is a potential to add additional fields to the description such as author, recipient, published etc for further filtering here.
Will think about how this fits in with https://github.com/TBD54566975/dwn-sdk-js/issues/467

I'm not sure about this feature. This feels like we're conflating query and read. Especially given your comment @LiranCohen about possible adding "additional fields to the description such as author, recipient, published, etc." I added a comment in https://github.com/TBD54566975/dwn-sdk-js/issues/468.

After yesterday's office hours discussion I think this is ready to be reviewed.
As I was learning how protocols work, I had context + parent mixed up so i changed allowing to issue a Read based on a parentId along with a path instead of just the path.
Path based RecordsRead will look for the most recent Record which has not been Deleted. If no records are found at all it will 404.

After today's office hours call we hammered out some final details for this PR and agreed on the following:
RecordsRead will now take a filter with a RecordsFilter type within its descriptor. If that filter returns more than one result it will error back to the user, otherwise it will return the single result.
@thehenrytsai @diehuxx this is ready to be re-reviewed.

@diehuxx Yeah, I'm actually really happy where we landed with this design! It took a little to grow on me, but I think we made the right choices here.

Alright, I think this is ready unless there's anything else that was missed! 🚀


After upgrade from 1.5.0 to 1.7.2, JoystickComponent not working

Can not drag the knob to move, the joystick is not dragable anymore.
joystick = JoystickComponent(
      priority: Consts.PRIORITY_OPERATION_UI,
      knob: SpriteComponent(
        sprite: knobImage.getSpriteById(0),
        size: Vector2.all(40),
      )..setAlpha(255),
      background: SpriteComponent(
        sprite: joyImage.getSpriteById(0),
        size: Vector2.all(120),
      )..setAlpha(200),
      margin: const EdgeInsets.only(left: 80, bottom: 40),
    );

@denghejun try removing HasDraggables and HasTappables mixin from your FlameGame class.

HasDraggables

But If I really need HasTappables on my game class, but all buttons not working, how can I deal with?

In 1.7.2 those mixins are not really needed for drag and tap detection. One possible cause of buttons not working might be the old camera system. I had to migrate all my projects to the new CameraComponent APIs to make the buttons work correctly.

In 1.7.2 those mixins are not really needed for drag and tap detection. One possible cause of buttons not working might be the old camera system. I had to migrate all my projects to the new CameraComponent APIs to make the buttons work correctly.

great! thanks, big help.


[WIP] Issue 93/add logic to track streak

Fixes #93
Wait until it's been tested tomorrow.

Everything is broken 😭

I'll need to check if it's the browser before using localStorage
https://www.gatsbyjs.org/tutorial/authentication-tutorial/


ease is not a function

Hi there,
Installed your script via npm and am using it with Vue.. works great!
Trying to customize the options and noticed two things. First of all in your "options" page you use equal signs instead of semi-colons
Secondly, two of the options don't seem to work.. ease and size
the "defaults" for those are "inOutSine" and "diameter". If I put those in quotes, single or double, it just doesn't work. I get "ease is not a function"
And if I put them without quotes I get "inOutSine" and "diameter" is not defined
I suppose you could store a function within a variable and pass that as the ease function, but I don't think this is what you intended? You should be able to just pass it the name of the easing from https://www.npmjs.com/package/ease-component as you write? Could you explain how that works please?
Thanks!

it doesn't accept a string but an reference to a function
the source code of ease-component package is: https://github.com/component/ease/blob/master/index.js
you can copy any of the functions directly from the source and paste it into your addBackToTop call:
addBackToTop({
  ease: function inOutElastic(n){
    var s, a = 0.1, p = 0.4;
    if ( n === 0 ) return 0;
    if ( n === 1 ) return 1;
    if ( !a || a < 1 ) { a = 1; s = p / 4; }
    else s = p * Math.asin( 1 / a ) / ( 2 * Math.PI );
    if ( ( n *= 2 ) < 1 ) return - 0.5 * ( a * Math.pow( 2, 10 * ( n -= 1 ) ) * Math.sin( ( n - s ) * ( 2 * Math.PI ) / p ) );
    return a * Math.pow( 2, -10 * ( n -= 1 ) ) * Math.sin( ( n - s ) * ( 2 * Math.PI ) / p ) * 0.5 + 1;
  }
})

@vfeskov that doesn't seem to be a fix.
Here is my code:
<script>
addBackToTop({
  backgroundColor : '#27de70',
  ease: 'inOutSine',
  scrollDuration : 1000
})
</script>

Here is the error that I get:
Uncaught TypeError: p is not a function at o (vanilla-back-to-top.min.js:1)


🐛 [BUG]: manual control  graph line confusion

Is there an existing issue for this?

[X] I have searched the existing issues and this is a new bug.

Current Behavior
desc
I use dragStatus to show diffrent stauts of render Handle
true status

line is correctly out of Node1's left and connect in Node's right
false status

from top to bottom
App.vue
<script setup>
import { ref } from 'vue'
import { VueFlow, useVueFlow } from '@vue-flow/core'
import { initialEdges, initialNodes } from './initial-elements.js'
import Node from './Node.vue'

/**
 * useVueFlow provides all event handlers and store properties
 * You can pass the composable an object that has the same properties as the VueFlow component props
 */
const { onPaneReady, onNodeDragStop, onConnect, addEdges, setViewport, toObject } = useVueFlow()

const nodes = ref(initialNodes)

const edges = ref(initialEdges)

onPaneReady(({ fitView }) => {
  fitView()
})

const dragStatus = ref(false)
</script>

<template>
  <button @click="dragStatus = !dragStatus">
    toggle drag
  </button>
  <VueFlow
    :nodes="nodes"
    :edges="edges"
    :class="{ dark }"
    class="basicflow"
    :default-viewport="{ zoom: 1.5 }"
    :min-zoom="0.2"
    :max-zoom="4"
  >
    <template #node-custom="data">
      <Node :name="data.label" :dragStatus="dragStatus" />
    </template>

    <Background pattern-color="#aaa" :gap="16" />
  </VueFlow>
</template>

init-element.js
import { MarkerType } from '@vue-flow/core'

export const initialNodes = [
  { id: '1', type: 'custom', label: 'Node 1', position: { x: 250, y: 0 }, class: 'light' },
  { id: '2', type: 'custom', label: 'Node 2', position: { x: 100, y: 100 }, class: 'light' },
  { id: '3', type: 'custom', label: 'Node 3', position: { x: 400, y: 100 }, class: 'light' },
]

export const initialEdges = [
  { id: 'e1-2', source: '1', target: '2', animated: true, sourceHandle: '1__handle-right', targetHandle:'2__handle-left' },
  { id: 'e1-3', label: 'edge with arrowhead', source: '1', target: '3', markerEnd: MarkerType.ArrowClosed },
]

Node.vue
<script setup lang="ts">
  import { Handle, Position } from '@vue-flow/core'

defineProps({
  name: String,
  dragStatus: Boolean
})
</script>

<template>
  <div style="border: 1px solid red">
    123 - {{ name }}

  	<Handle
      v-if="dragStatus"
      :position="Position.Left"
    />

    <Handle
      v-if="dragStatus"
      :position="Position.Right"
    />
  </div>
</template>

Expected Behavior
i want to munual control handle show to realize :
in hover status:

for hover node show handle
for other can connecet from the hover node also show handle
else node do not show handle
all the connect line 's position do not change, i set edge's type to step, the line show be like this

but not like this

in common status

all of nodes do not show handle

Steps To Reproduce
No response
Relevant log output
No response
Anything else?
No response

As mentioned in the previous issue that you opened:
Using multiple handles of the same type (you didn't specify the type so both will fall back to source) requires you to set an id on the handles!.
And as mentioned in the previous issue, this one also doesn't describe in any detail what the issue is.
Please take some time before filling out these issues, the code is appreciated but if you have trouble filling out issues in English use some translation tool or something but these issues say barely anything and seem more like questions and not bug reports.
Sorry but also closed for insufficient info.

If you need support, maybe start a Discussion Thread instead or join the Discord to ask your question but please refrain from opening half-baked issues like this, thank you.


Build failed because services not started

Description:
Build failed because services not started
Steps to reproduce:

clone project from this link https://github.com/HisharaPerera/auction-service

Directed to scatter-gather-messaging/guide and run "ballerina build scatter-gather-messaging " command

Affected Versions:
latest master (0.980.0-RC2)
OS, DB, other environment details and versions:

PR merged hence closing


Refactor method which NEVER will return FALSE.

Hi @wmedvede,
I found out that PolyLine#parse method never returns false value, but I am not sure is it correct or not.
I saw at least two potential usage of the returning value, so not sure where is a bug

this method should be always true and other code shouldn't check this value or
parse method should return false at some cases, for example if (size == 0)

I refactored a bit PolyLine#parse method and now it is easier to read and continue modifications. Please, can I ask you to take a look at this method and produced value? You are more or less already in the context of surrounding code, I guess it should be easier for you.
Right now there is failing test PolyLineTest#testParseWhenPointsIsNull in lienzo-tests repository. It is  because of attr.getPoints() mock (in reality getPoints never returns null, but mock returns).

Hi @hasys , yes, the code can be simplified.
But I preferred to keep this structure mainly because I'ts a sort of structuring I've seen in other places at lienzo. And my fix just adds one use case on the already existing code. So I've preferred keep it this way instead of restructuring it. Anyway, I'll add your suggestion just for moving this forward.

Hi @hasys , I'l close this PR since your suggestions were added to the code.
Thanks!


Provide a method to reference the topic partition

There are cases where I need to reference the topic partition for metrics purposes.
While it's possible to force a reference through the MDC injected by LoggingContext, I would prefer a more direct method.
https://github.com/line/decaton/blob/e0f6dc98814636bf71bb0689bb7874be40db7142/processor/src/main/java/com/linecorp/decaton/processor/LoggingContext.java#L52
Even just adding getters to the various fields of LoggingContext would be helpful, but it might deviate from the original purpose of LoggingContext.
To elaborate on the use case, when using deferCompletion, the decaton.tasks.error metrics cannot be used, so I want to record the metrics myself. In this case, I need to reference the partition topic.
https://github.com/line/decaton/blob/master/docs/monitoring.adoc#:~:text=in a topic.-,decaton.tasks.error,-The number of
(In other words, if decaton.tasks.error could be recorded even when using deferCompletion, that would be fine as well.)

Sorry for the delay of the reaction.
The motivation makes sense.
Why we don't expose partition directly is because we want to make Decaton agnostic to Kafka as much as possible (yeah, I know already there are some places where Kafka-specific thing is exposed though...).
To report per-partition error count even on deferredCompletion is an option though, the problem is how Decaton can know deferred-completion is "failed".
Given these, we are still not sure what's the best way to address the problem.
By the way let me ask if accessing through MDC causes another (e.g. performance) issue, not only the inconvenience.

Why we don't expose partition directly

I see.
With the rise of many Kafka-compatible middleware solutions, it certainly makes sense to hide the implementation as much as possible.

By the way let me ask if accessing through MDC causes another (e.g. performance) issue, not only the inconvenience.

Since it's just reading from thread-local storage, there are no performance concerns.
For now, I'm satisfied with the feedback, so it's okay to close the issue.


Update about us.html

Summary
Briefly describe the purpose of this PR.
Description
Explain in detail what this PR is all about. This should include the problem you're solving, the approach taken, and any technical details that reviewers need to know.
Key Changes:
Color Theme: Replaced any blue with yellow, orange, and white.
Responsiveness: Maintained the grid layout for responsiveness.
Hover Effects & Transitions: Ensured subtle animations without disrupting readability.
Content Visibility: Adjusted color contrasts to ensure full readability.
Images

Include any relevant images or diagrams that can help reviewers visualize the changes, if applicable
Issue(s) Addressed
Enter the issue number of the bug(s) that this PR fixes

Template should be strictly Closes <issue_number>
Example: Closes #1399

Prerequisites

[ ] Have you followed all the CONTRIBUTING GUIDELINES?

@Its-Aman-Yadav @Kalivarapubindusree please review before 7pm

@Its-Aman-Yadav


Decrease MAX_POOL_SIZE in huge_pool test to make it work with rust 1.65

The new rust compiler and standard library generate slightly increased number of SBF instructions, which triggers failure of the stake-pool/program/tests/huge_pool.rs test due to running over the compute budget limit. I would like to decrease the maximum size of the pool to make the test pass when compiled by the new toolchain.

@joncinque Jon, is it ok to merge this?

Ah well, if there's no other way, that's fine! It's weird though, it doesn't impact MAX_POOL_SIZE_WITH_REQUESTED_COMPUTE_UNITS?

I haven't looked at MAX_POOL_SIZE_WITH_REQUESTED_COMPUTE_UNITS because the only test that fails is cleanup_all and I thought that it is affected by MAX_POOL_SIZE only.

Ah ok, that's fine then, thanks!


Fix #4 (pass tuple to component transformation)

I felt compelled to fix this since it was a bug in the code I submitted! :-)

@miguelsousa Huh. Did I accidentally request your review here? If so, sorry for the noise.

You didn't. I just happen to get a notification about this change and the review button was available — not sure why — so I decided to click on it, thinking I could merge the PR thereafter. But I can't.


PXE boot on Rock64 - UDP wrong checksum

I tried several instructions (also https://forum.pine64.org/showthread.php?tid=6814) for configure boot via PXE on Rock64 - no luck :(
Have issue with "UDP wrong checksum":
DDR version 1.13 20180428
ID:0x805 N
In
LPDDR3
786MHz
Bus Width=32 Col=11 Bank=8 Row=15/15 CS=2 Die Bus-Width=32 Size=4096MB
ddrconfig:7
OUT

U-Boot SPL 2017.09-rockchip-ayufan-1035-gd646df03ac (Oct 26 2018 - 08:35:43)
setup_ddr_param  1
booted from SPI flash
Trying to boot from SPI
NOTICE:  BL31: v1.3(debug):9d3f591
NOTICE:  BL31: Built : 14:39:02, Jan 17 2018
NOTICE:  BL31:Rockchip release version: v1.3
INFO:    ARM GICv2 driver initialized
INFO:    Using opteed sec cpu_context!
INFO:    boot cpu mask: 1
INFO:    plat_rockchip_pmu_init: pd status 0xe
INFO:    BL31: Initializing runtime services
WARNING: No OPTEE provided by BL2 boot loader, Booting device without OPTEE initialization. SMC`s destined for OPTEE will return SMC_UNK
ERROR:   Error initializing runtime service opteed_fast
INFO:    BL31: Preparing for EL3 exit to normal world
INFO:    Entry point address = 0x200000
INFO:    SPSR = 0x3c9

U-Boot 2017.09-rockchip-ayufan-1035-gd646df03ac (Oct 26 2018 - 08:36:01 +0000)

Model: Pine64 Rock64
DRAM:  4 GiB
MMC:   rksdmmc@ff520000: 0, rksdmmc@ff500000: 1
SF: Detected gd25q128 with page size 256 Bytes, erase size 4 KiB, total 16 MiB
*** Warning - bad CRC, using default environment

In:    serial@ff130000
Out:   serial@ff130000
Err:   serial@ff130000
Model: Pine64 Rock64
misc_init_r
cpuid=55524b50303930323100000000132807
serial=888ee9b333c974b
Net:   eth0: ethernet@ff540000
Hit any key to stop autoboot:  0
Card did not respond to voltage select!
mmc_init: -95, time 9
Card did not respond to voltage select!
mmc_init: -95, time 9
starting USB...
USB0:   USB EHCI 1.00
USB1:   USB OHCI 1.0
USB2:   Core Release: 3.10a
USB3:   Register 2000140 NbrPorts 2
Starting the controller
USB XHCI 1.10
scanning bus 0 for devices... 1 USB Device(s) found
scanning bus 1 for devices... 1 USB Device(s) found
scanning bus 2 for devices... 1 USB Device(s) found
scanning bus 3 for devices... 1 USB Device(s) found
       scanning usb for storage devices... 0 Storage Device(s) found

Device 0: unknown device
Speed: 1000, full duplex
BOOTP broadcast 1
DHCP client bound to address <IP_ADDRESS> (2 ms)
*** Warning: no boot file name; using 'C0A87865.img'
Using ethernet@ff540000 device
TFTP from server <IP_ADDRESS>; our IP address is <IP_ADDRESS>
Filename 'C0A87865.img'.
Load address: 0x800800
Loading:
TFTP error: 'File not found' (1)
Not retrying...
missing environment variable: pxeuuid
missing environment variable: bootfile
Retrieving file: pxelinux.cfg/01-22-62-24-29-72-b4
Speed: 1000, full duplex
Using ethernet@ff540000 device
TFTP from server <IP_ADDRESS>; our IP address is <IP_ADDRESS>
Filename 'pxelinux.cfg/01-22-62-24-29-72-b4'.
Load address: 0x600000
Loading: #
         72.3 KiB/s
done
Bytes transferred = 1049 (419 hex)
Config file found
1:      rock64
missing environment variable: bootfile
Retrieving file: boot/initrd.img-4.4.167-1161-rockchip-ayufan-g6f1664023387
Speed: 1000, full duplex
Using ethernet@ff540000 device
TFTP from server <IP_ADDRESS>; our IP address is <IP_ADDRESS>
Filename 'boot/initrd.img-4.4.167-1161-rockchip-ayufan-g6f1664023387'.
Load address: 0x4000000
Loading:  UDP wrong checksum 00000800 000022da
T  UDP wrong checksum 00001008 00003091
 UDP wrong checksum 00001008 000022da
T  UDP wrong checksum 00001008 000022da
 UDP wrong checksum 00001008 00003091
T  UDP wrong checksum 00000800 00003091
 UDP wrong checksum 00000810 000022da
# UDP wrong checksum 00000008 00004c20
 UDP wrong checksum 00000800 00003769
 UDP wrong checksum 00000800 00003091
 UDP wrong checksum 00000800 000022da
 UDP wrong checksum 00000800 00008016

P.S. Tried several SPI images, include the latest "2017.09-rockchip-ayufan-1045-g9922d32c04". The same issue on all of them.

Ok, seems I found the issue...
I tried the same method on other 2nd rock64 board and it's WORKS without any issues!
on 3rd rock64 board it works but time to time I see messages about "UDP wrong checksum". After I defined on switch (tl-108e) speed 100MF - no issues.
I tried define speed to 10 and 100 for "problem board" - no luck :( Also changing ethernet cable didn't solve issue. Seems this is hardware issue with this board :( But it's strange. If board loaded from SD card - no issues with ethernet, everything works well.
Can be this hardware issue or it's some specific of hardware and it's can current issue be solved on software level?

It is software. There is some problem with u boot
On Thu, 4 Apr 2019 at 08:08, Oleh Halytskyi<EMAIL_ADDRESS>wrote:

Ok, seems I found the issue...
I tried the same method on other 2nd rock64 board and it's WORKS without
any issues!
on 3rd rock64 board it works but time to time I see messages about "UDP
wrong checksum". After I defined on switch (tl-108e) speed 100MF - no
issues.
I tried define speed to 10 and 100 for "problem board" - no luck :( Also
changing ethernet cable didn't solve issue. Seems this is hardware issue
with this board :( But it's strange. If board loaded from SD card - no
issues with ethernet, everything works well.
Can be this hardware issue or it's some specific of hardware and it's can
current issue be solved on software level?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ayufan-rock64/linux-build/issues/341#issuecomment-479763074,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACTpQRCQ4SSS9szFDQDSwDvBkuidiNoNks5vdZbjgaJpZM4cXJho
.

It is software. There is some problem with u boot

Is it possible to fix? Thanks.

Experiencing same problem with new ROCK64 board..
Tried 3 different TFTP servers, no luck.
It is sad to see how boards with such outstanding hardware as Rock64/Rock64Pro are being bated by RPi just due to lack of normal OS/infrastructure...

Encountering this problem as well.

I am encountering this issue on one brand-new Rock64 board, but not on an identical second. Seems to be tied to the physical board somehow.

I am encountering this issue on one brand-new Rock64 board, but not on an identical second. Seems to be tied to the physical board somehow.


Update KAPE.cs - Fix KapeTriage

The second commit fixes https://github.com/EricZimmerman/TLEFilePlugins/issues/11


Non-blocking operations on scheduler

Hi, this is just a general discussion on the scheduler's behavior. I noticed that in initialize:
async def run_scheduler():
            async with Scheduler(
                interface=interface,
                protocol=protocol,
                dashboard=dashboard,
                dashboard_address=dashboard_address,
            ) as scheduler:
                comm.bcast(scheduler.address, root=0)
                comm.Barrier()
                await scheduler.finished()

The scheduler only starts with 1 thread, and since the scheduler has to maintain communication with all workers and client, I'm very curious that once there is an await call, then the schedule will simply block itself there, and only when after that await, it can start to do other communications. It seems this is a huge overhead in communication.
For example, in distributed.comm.ucx,
@log_errors
    async def write(
        self,
        msg: dict,
        serializers: Collection[str] | None = None,
        on_error: str = "message",
    ) -> int:
        if self.closed():
            raise CommClosedError("Endpoint is closed -- unable to send message")
        try:
            if serializers is None:
                serializers = ("cuda", "dask", "pickle", "error")
            # msg can also be a list of dicts when sending batched messages
            logging.info("send msg={}".format(msg))
            frames = await to_frames(
                msg,
                serializers=serializers,
                on_error=on_error,
                allow_offload=self.allow_offload,
            )
            nframes = len(frames)
            cuda_frames = tuple(hasattr(f, "__cuda_array_interface__") for f in frames)
            sizes = tuple(nbytes(f) for f in frames)
            cuda_send_frames, send_frames = zip(
                *(
                    (is_cuda, each_frame)
                    for is_cuda, each_frame in zip(cuda_frames, frames)
                    if nbytes(each_frame) > 0
                )
            )

            # Send meta data

            # Send close flag and number of frames (_Bool, int64)
            await self.ep.send(struct.pack("?Q", False, nframes))
            # Send which frames are CUDA (bool) and
            # how large each frame is (uint64)
            await self.ep.send(
                struct.pack(nframes * "?" + nframes * "Q", *cuda_frames, *sizes)
            )

            # Send frames

            # It is necessary to first synchronize the default stream before start
            # sending We synchronize the default stream because UCX is not
            # stream-ordered and syncing the default stream will wait for other
            # non-blocking CUDA streams. Note this is only sufficient if the memory
            # being sent is not currently in use on non-blocking CUDA streams.
            if any(cuda_send_frames):
                synchronize_stream(0)

            for each_frame in send_frames:
                await self.ep.send(each_frame)
            return sum(sizes)
        except (ucp.exceptions.UCXBaseException):
            self.abort()
            raise CommClosedError("While writing, the connection was closed")

There are some await self.ep.send, and for example, this is a send from scheduler to worker #1, then despite that all other workers can perform computation in parallel, they still have to sequentially wait for the communication with the scheduler. And in cases where communication is heavier than computation, the overhead will be significant.
I'm wondering if there is any way to perform nonblocking send/recv by giving the scheduler more threads.

This seems to be a question more for the Distributed community. Dask-MPI is just the tool for launching a Dask cluster.

Also, all communication between the scheduler and workers is asynchronous. So, nothing is blocking.
Is there a particular use case you are having problems with?

Oh thanks, I get it. But in case where all the communication happens at the same time, then even with async func, since the scheduler only has 1 thread, it is still going to be sequential.

@pentschev may have some thoughts

On a Dask worker, communication occurs on a different thread than that of compute. On the scheduler you're right that communication occurs on the same thread as the remaining of the work and that may in fact block at times, and I don't think there's currently a mechanism to allow offloading communications to a(multiple) separate thread(s). However, under normal circumstances, messages transferred between scheduler and worker as small and that blocking time may not be as substantial.
If you have the time, it would probably be an interesting experiment to do and check if there are any performance gains from offloading communication to one or more threads on the scheduler. As noted by @kmpaul , this discussion is anyway more suited for https://github.com/dask/distributed/issues , so maybe would be worth raising this question there to check what other people involved in Distributed think of this or whether there has been already someone who experimented on this.


Which version of Panda3D it support?

Which version of Panda3D it support?
I tried to run in 1.94 and occour this error:
src/gui/base/mgr.py", line 23, in init
    cls._task_mgr = base.task_mgr
AttributeError: ShowBase instance has no attribute 'task_mgr'

And Python 3 support is planned?

That error happens because I use the snake_case of base.taskMgr, but base.task_mgr is not defined in version 1.94 of Panda3D.
Therefore, you will need a recent 1.10 development build of Panda3D. Not only because I want to use snake_case in my code as much as possible (camelCase will be phased out in future versions of Panda3D, I believe), but I also want/need to make use of some of the latest bugfixes, without which my code wouldn't work properly.
And since I want my project to be as "future-proof" as possible, I will definitely adapt my code to work with Python 3 eventually. Before I do that, though, I'd like to see Panda3D itself switch over to Python 3 as its main Python version. Right now, its support of Python 3 still seems like a work in progress, so that's why I'd like to wait a bit before changing Python versions (and I don't like the idea of maintaining 2 different versions of my project, or relying on Python's 2to3 library to do automatic conversions, as I fear this might do some weird things to my code; I'd rather do the conversion myself).

For the record, Panda3D 1.10 is completely compatible with Python 3 at this stage, and the Python 3 support is no longer considered "experimental" but first-class and of primary priority.
It is possible to keep the codebase simultaneously compatible with Python 2 and Python 3, like Panda3D also does for the direct tree.  The six library could be used to help make this easier.  You could also consider installing a Continuous Integration or code checking plug-in on the GitHub repository so that it can automatically check for breaking changes.

For the record, Panda3D 1.10 is completely compatible with Python 3 at this stage, and the Python 3 support is no longer considered "experimental" but first-class and of primary priority.

Ah, that is great news! Thank you for letting me know!
Hmm, maybe I should just bite the bullet then and start converting the code to Python 3 before doing anything else. It's already a major new version of my project anyway (with the big GUI overhaul), and by the time it will be truly production ready most people will probably prefer using Python 3, so continued support of Python 2 might be a waste of effort.
By the way @rdb, did you receive the email I sent you on 28 May? The most important part of that email was that I encountered some performance issues with my GUI system, apparently caused by garbageCollectStates when copying PNMImage sub-images (which also seemed to lead to a memory leak in PStats), and I wondered if setting garbage-collect-states to False (which seems to fix the issue) could cause some other kind of problems. There seemed to be other factors at play, which made things a bit confusing, which is why I haven't created an issue for it yet (as you might want to check it out for yourself first, now that the code is available).

I did not receive an e-mail from you (not in spambox either).  I'd be curious to analyse such an issue with garbage-collect-states.  I'm not sure how copying PNMImage could cause such an issue, though.  This type of issue would be caused by constantly assigning new Texture objects to your nodes, or something like that.  Please do make sure you're not still using a development build from last year, though.
There should not be a harmful effect from disabling it, other than performance.  Some applications perform better with it enabled, some perform better with it disabled.

I can help the Python 3 support. I have made this at koparka https://github.com/wezu/koparka/issues/12 , but here we can use full Python 3 if you wish.

I can help with the Python 3 support. I have made this at koparka wezu/koparka#12 , but here we can use full Python 3 if you wish.

That would be great! Yes, full Python 3 please, thank you!

Full support of Python 3 has now been realized.
Thanks to leotada and rdb for your contribution and motivation!


Not working

i just installed it yesterday and this morning after update its gone and when i installed it again its does not work properly it only applies black skin for store and community page not library page not any custom looks for buttons as well please help me with this i loved the new look for the steam

it was working perfectly

use beta mode on steam for now. large changes have been made to steam that currently trumps their support. hopefully it will be resolved in the future.


[now dev] Bump @now/build-utils to 0.9.4

Bump @now/build-utils to 0.9.4

Codecov Report

Merging #2621 into canary will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           canary   #2621      +/-   ##
=========================================
- Coverage    7.96%   7.95%   -0.02%
=========================================
  Files         258     258
  Lines        9404    9396       -8
  Branches     1068    1066       -2
=========================================
- Hits          749     747       -2
+ Misses       8606    8600       -6
  Partials       49      49

Impacted Files
Coverage Δ

src/util/dev/builder-cache.ts
29.65% <0%> (+0.1%)
:arrow_up:

src/util/metrics.ts
68.18% <0%> (+6.64%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fd1cee...c5b032a. Read the comment docs.


Reusable functions that leverage Containers outside components

Let's imagine I have components with similar logic, example:
import React from 'react'
import { AppContainer } from '../container/app'
import "..."

const FileListComponent: FC = () => {
  const app = AppContainer.useContainer()

  const fetchFileList = async () => {
    let myFileList: SavedFileList
    try {
      myFileList = await fetchList()
    } catch (error) {
      return errorToast(error)
    }
    app.replaceFileList(myFileList)
  }

  return (

    {app.fileList.map(file => (
{file.name}
))}

  )
}

I would like to bring the function myFileList out of that, but it has typing problems:
const fetchFileList = async (app: AppContainer) => {
  let myFileList: SavedFileList
  try {
    myFileList = await fetchList()
  } catch (error) {
    return errorToast(error)
  }
  app.replaceFileList(myFileList)
}

As AppContainer is a value, not a type, and it cannot be used that way. Is there a suitable typing solution for this?

A "plausible" typing I have found is the following one:
Demo: container/app.ts
export const initialApp = {
  fileList: [] as SavedFileList[]
}
export function useApp (initialState = initialApp) {
  const [fileList, setFileList] = useState(initialState.fileList)
  const replaceFileList = (files: SavedFileList[]) => setFileList(files)

  return {
    fileList,
    // methods
    replaceFileList,
  }
}

export const AppContainer = createContainer(useApp)
export type AppContainerState = ReturnType<typeof useApp>

I hope there is also a more user-friendly version
Reusable function:
const fetchFileList = async (app: AppContainerState) => {
  let myFileList: SavedFileList
  try {
    myFileList = await fetchList()
  } catch (error) {
    return errorToast(error)
  }
  app.replaceFileList(myFileList)
}


[stable/prometheus-operator] deprecate chart

Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:
This chart has successfully moved 🎉
Special notes for your reviewer:

Completed in https://github.com/prometheus-community/helm-charts/pull/1
Related to https://github.com/helm/charts/issues/21103

Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
~- [ ] Variables are documented in the README.md~
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/lgtm

Looks like test infra had issues earlier, and this has been stuck for a few hours

/test all

Not sure we even need to test this, as it's just a deprecation. But let's see if it does it on it's own now.

It's stuck again. Merging


Refactor On Eldritch Surge

An intricate and brand new subclass! Much more interesting to play than just EB like before.
Fix some bugs and Add some new interfaces.
Major change to original code:
Move Spiritual Shield blocking and Flash Of Genius save bonus to thier separate class in favor of new interfaces.
Make IDefinitionCustomCode applicable to invocation's granted feature to make them able to do things when added and removed. Meanwhile the relevent codes in Party Editor and Level Up Context are modified.
New interfaces:
IInvocationToggled, IMeOrAllySaveFailPossible (Flash Of Genius), IModifyAC, ISpellCast, IAttackBeforeHitPossibleOnMeOrAlly (Spiritual Shield)
New infrastracture:
RulesetConditionCustom
Original custom condition used in Blast Overload is created with new instance when added to character, however, it will return to a pool of RulesetCondition when removed and possibly add to other character in the future, which will eventually mess up your Save (though it will not crash). Newly implemented RulesetConditionCustom has its own pool and you can use it safely and conveniently just as original RulesetCondition, as long as you follow my practice (which is also noted down in the comments).
TODO:
Add texts ans sprite resources.

Please merge others' PR first cause I renamed some methods for clarity.


Peer DID: Validate Doc against DID Identifier

The agents exchange Peer DIDs using DID Exchange Protocol.
The receiving agent should have the capability to validate the DID Document against the name-string component of the DID Identifier.

Part of epic #35

Part of epic #35

@rolsonquadras I'd like to have a model for the DID. Right now we're treating it as a mere string. It would be valuable to have a composite model for DIDs (just the DID ID) from which one could extract its components, such as its method.


Tutorial updates

Codecov Report

Merging #308 (a66ec66) into dev (5d61d0d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #308   +/-   ##
=======================================
  Coverage   78.54%   78.54%
=======================================
  Files          43       43
  Lines        2778     2778
=======================================
  Hits         2182     2182
  Misses        596      596

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d61d0d...a66ec66. Read the comment docs.


Language changing not complete

Several details of lauguage switch need to be handled:

The button Back to Login in the registration page
The home page display
The tab names in the drop-down menu
And the content inside each tabs

i can check these

Closed by #77


PIL not working.

TkinterWeb is clearly bugging right now :skull:.
The error report is here:
ModuleNotFoundError: The files required to run TkinterWeb could not be found. This usually occurs when bundling TkinterWeb into an app without forcing the application maker to include all nessessary files or when some of TkinterWeb's dependencies are not installed. See https://github.com/Andereoo/TkinterWeb/blob/main/tkinterweb/docs/FAQ.md for more information.
Error code: Traceback (most recent call last):
File "/home/dogcmamere/.local/lib/python3.9/site-packages/tkinterweb/init.py", line 31, in
from bindings import TkinterWeb
File "/home/dogcmamere/.local/lib/python3.9/site-packages/tkinterweb/bindings.py", line 39, in
from imageutils import *
File "/home/dogcmamere/.local/lib/python3.9/site-packages/tkinterweb/imageutils.py", line 28, in
from PIL.ImageTk import PhotoImage
ModuleNotFoundError: No module named 'PIL.ImageTk'
If you think this is a bug, please file a bug report at https://github.com/Andereoo/TkinterWeb.

The error is

The error is easy to remove. Pillow must be installed with version 10.0.0 specifically

Or it will crash

Thanks for letting me know about this! From the error it looks like you were missing ImageTk. I can't reproduce this issue but I'm glad you figured it out.


Why isn't addMarker() bound to this?

The addMarker() method in the DisplayMap component, isn't bound to this.
Why?

interesting - could be an oversight or something lost between the writing and the repo. I'll take a look 👍


Add CS Survival Guide page

What's your idea?
We should have a CS Survival Guide page. It shall be a completely separate page from /events, which could probably be /cssg.
The page will be hidden, as in no hyperlinks will reach it by default. However, we can program it so that 1-2 weeks prior to the event start date, the website will either reveal a banner advertising the page or add a section into the main page advertising it. I think the banner is likely better.
To be discussed: what to be included in the cssg page. We can use @AlanCortez1337's flyer designs for this.

/cc @AlanCortez1337
Can you drop your design resources here to be used as reference?


Only manually specified targets are added to Run configurations

I use the Intellij Bazel plugin for Clion and the plugin is built from sources (the HEAD is tag  v2019.11.11).  In my .bazelproject file, the property derive_targets_from_directories is set to true, but no dynamic derived targets are added to the run configuration (only manually specified in the targets section are).
I've jumped deeply into the plugin code and found in the com.google.idea.blaze.base.run.BlazeRunConfigurationSyncListener class that only targets from the project description are added into the run configurations:
Set<TargetExpression> targetExpressions =
  Sets.newLinkedHashSet(projectViewSet.listItems(TargetSection.KEY));
  // We only auto-generate configurations for rules listed in the project view.
  for (TargetExpression target : targetExpressions) {
    if (!(target instanceof Label) || labelsWithConfigs.contains(target)) {
      continue;
    }
 ...

Actually, I know how to fix it: we can receive an instance of the ProjectTargets class using the SyncProjectTargetHelper helper, in the onSyncComplete listener method we have all required data: project, context, projectViewSet and blazeProjectData that can return us a WorkspacePathResolver and WorkspaceLanguageSettings.
If the maintainers approve, I'll open the PR.

Any update on this issue? It's very much needed. Imagine working on a big project, it doesn't make sense maintaining a manually create list of targets, instead I would expect that the Bazel Plugin is able to automatically create run configurations for each target same as Clion does for CMake targets.


qemu is unable to access the libguestfs snap files created in /tmp

when imagefactoryd runs as root, libguestfs process creates its temporary files in /tmp as root too
libvirtd instead, by default, spawns the qemu process as qemu resulting in a permission denied error like:

RuntimeError: could not create appliance through libvirt: internal error process exited while connecting to monitor: qemu-kvm: -drive file=/tmp/libguestfsJLnXYN/snapshot1,if=none,id=drive-scsi0-0-1-0,format=qcow2,cache=unsafe: could not open disk image /tmp/libguestfsJLnXYN/snapshot1: Permission denied

I believe this has sorted itself out at some point.  I regularly run Factory as root with libvirt being used as the backing management for libguestfs.


Support for pandas 1.5 and 2 and above

Fixes #89

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 21.29%. Comparing base (6ed2d4f) to head (3a90339).
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #102      +/-   ##
==========================================
+ Coverage   21.22%   21.29%   +0.06%
==========================================
  Files          28       28
  Lines        3759     3762       +3
==========================================
+ Hits          798      801       +3
  Misses       2961     2961

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Move Build Script to a UPM Package

Context
Users currently have to redo a lot of the default Build Script if they want to have a custom buildMethod.
We should make it easier for users to add to or modify the build method, while still leveraging the default functionality.
Suggested solution
Remove the buildMethod option, and move the default build script to a UPM package that users could choose to include in their project.
If they include the UPM package, they should be able to use an API to easily add to or modify the build process.
If they don't include the package, Unity Builder would still work by importing the package during the build action.
Considered alternatives
My initial solution was to provide an example BuildScript.cs that users could copy and modify, but this approach is still not as user-friendly as it should be.
Additional details
This issue came from user feedback:
https://discord.com/channels/710946343828455455/710946344264794219/839682505434595370
https://discord.com/channels/710946343828455455/710946344264794219/839765128564178966

Maybe another solution would be to add an option to customise the path to copy UnityBuilderAction from.
https://github.com/game-ci/unity-builder/blob/main/dist/steps/build.sh#L51
So an option like:
- uses: game-ci/unity-builder@v2
  env:
    UNITY_EMAIL: ${{ secrets.UNITY_EMAIL }}
    UNITY_PASSWORD: ${{ secrets.UNITY_PASSWORD }}
    UNITY_SERIAL: ${{ secrets.UNITY_SERIAL }}
  with:
    targetPlatform: WebGL
    buildActionPath: /github/workspace/MyCustomBuildAction/

And then in build.sh:
cp -R $UNITY_BUILD_ACTION_PATH "$UNITY_PROJECT_PATH/Assets/Editor/"

With the necessary plumbing to have /UnityBuilderAction/Assets/Editor/ as a default value and pass it around of course

Great suggestion @davidmfinol @sbergen!
Indeed I think it's important to keep our build script as the default behaviour as it's used a lot.
If installing a package inside your project - that provides some hooks for your project specific functionality - does the job, it would be preferable I think.
@Bradshaw about

buildActionPath: /github/workspace/MyCustomBuildAction/

This will work but it brings a few problems:

It doesn't solve that a user would still have to copy and distribute that script, which is hard to document.
We now make it very easy for the user to use a script that's not part of the repository - which I would consider bad practice.
Paths are hard. A big portion of our users that ask support messed up a path. Especially in github actions we try to abstract over the technical details and make it as easy as possible to configure it.

But maybe there's a rationale behind your suggestion that I'm currently not considering?

@webbertakken Just avoiding UPM 🤷♂
If paths are an issue, then maybe it's not a good idea