Streamline 1.0 issues (many of them)

I'm excited to try out Streamline 1.0, but I haven't been able to get it working.
—
First, I got these npm peer dependency warnings and Babel errors.
$ npm install streamline
npm WARN peerDependencies The peer dependency<EMAIL_ADDRESS>included from streamline will no
npm WARN peerDependencies longer be automatically installed to fulfill the peerDependency
npm WARN peerDependencies in npm 3+. Your application will need to depend on it explicitly.
npm WARN peerDependencies The peer dependency<EMAIL_ADDRESS>included from babel-plugin-streamline will no
npm WARN peerDependencies longer be automatically installed to fulfill the peerDependency
npm WARN peerDependencies in npm 3+. Your application will need to depend on it explicitly.

><EMAIL_ADDRESS>install /path/to/project/node_modules/streamline/node_modules/fibers
> node build.js || nodejs build.js

`darwin-x64-v8-3.28` exists; testing
Binary is fine; exiting

npm WARN prefer global<EMAIL_ADDRESS>should be installed with -g
npm WARN prefer global<EMAIL_ADDRESS>should be installed with -g

<EMAIL_ADDRESS>node_modules/babel

<EMAIL_ADDRESS>node_modules/streamline
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS><EMAIL_ADDRESS>
$ npm test

><EMAIL_ADDRESS>test /path/to/project
> mocha test

[STREAMLINE] transforming (fibers): /path/to/project/test/_auth._coffee

/path/to/project/node_modules/streamline/node_modules/babel/index.js:1
(function (exports, require, module, __filename, __dirname) { throw new Error(
                                                                    ^
Error: The node API for `babel` has been moved to `babel-core`.
    at Object.<anonymous> (/path/to/project/node_modules/streamline/node_modules/babel/index.js:1:7)
    at Module._compile (module.js:460:26)
    at Module._compile (/path/to/project/node_modules/streamline/lib/register.js:52:12)
    at Object.Module._extensions..js (module.js:478:10)
    at Module.load (/path/to/project/node_modules/coffee-script/lib/coffee-script/register.js:45:36)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.exports.transform (/path/to/project/node_modules/streamline/lib/transformSync.js:25:10)
    at /path/to/project/node_modules/streamline/lib/transformSync.js:42:18
    at Object.exports.get (/path/to/project/node_modules/streamline/lib/cacheSync.js:58:15)
    at exports.transformFileSync (/path/to/project/node_modules/streamline/lib/transformSync.js:40:19)
    at Object.._coffee (/path/to/project/node_modules/streamline/lib/register.js:64:12)
    at Module.load (/path/to/project/node_modules/coffee-script/lib/coffee-script/register.js:45:36)
    ...

npm ERR! Test failed.  See above for more details.

The root cause seems to be that Streamline asks for Babel >=5.8.0 — as opposed to a safer ^5.8.0 — and Babel 6 indeed introduced breaking changes:
http://babeljs.io/blog/2015/10/29/6.0.0/
I can fix by explicitly installing Babel 5.8.x first:
$ npm uninstall streamline
$ npm uninstall babel    # 6.x got automatically installed alongside Streamline
$ npm install<EMAIL_ADDRESS>$ npm install streamline

—
Even when I fix that (as well as npm install streamline-runtime), my code (which ran fine on Streamline 0.x) won't run.
For starters, I'm surprised it's using Fibers! (And even then, I get this error.) Why?
[STREAMLINE] transforming (fibers): /path/to/project/test/fixtures/index._coffee

/path/to/project/node_modules/babel/node_modules/babel-core/lib/transformation/file/index.js:662
      if (err.stack) {
             ^
Error: No element indexed by 1
    at ArraySet_at [as at] (/path/to/project/node_modules/streamline/node_modules/source-map-support/node_modules/source-map/lib/source-map/array-set.js:83:11)
    at SourceMapConsumer_parseMappings [as _parseMappings] (/path/to/project/node_modules/streamline/node_modules/source-map-support/node_modules/source-map/lib/source-map/source-map-consumer.js:220:44)
    at SourceMapConsumer.Object.defineProperty.get (/path/to/project/node_modules/streamline/node_modules/source-map-support/node_modules/source-map/lib/source-map/source-map-consumer.js:160:14)
    at SourceMapConsumer_originalPositionFor [as originalPositionFor] (/path/to/project/node_modules/streamline/node_modules/source-map-support/node_modules/source-map/lib/source-map/source-map-consumer.js:311:43)
    at mapSourcePosition (/path/to/project/node_modules/streamline/node_modules/source-map-support/source-map-support.js:168:42)
    at wrapCallSite (/path/to/project/node_modules/streamline/node_modules/source-map-support/source-map-support.js:303:20)
    at /path/to/project/node_modules/streamline/node_modules/source-map-support/source-map-support.js:338:26
    at Array.map (native)
    at Function.prepareStackTrace (/path/to/project/node_modules/streamline/node_modules/source-map-support/source-map-support.js:337:24)
    at Function.Error.prepareStackTrace (/path/to/project/node_modules/streamline/node_modules/streamline-runtime/lib/util.js:71:37)
    at Function.Error.prepareStackTrace (/path/to/project/node_modules/streamline-runtime/lib/util.js:71:37)
    at File.wrap (/path/to/project/node_modules/babel/node_modules/babel-core/lib/transformation/file/index.js:662:14)
    at Pipeline.transform (/path/to/project/node_modules/babel/node_modules/babel-core/lib/transformation/pipeline.js:165:17)
    at Object.exports.transform (/path/to/project/node_modules/streamline/lib/transformSync.js:25:27)
    at /path/to/project/node_modules/streamline/lib/transformSync.js:42:18
    at Object.exports.get (/path/to/project/node_modules/streamline/lib/cacheSync.js:58:15)
    at exports.transformFileSync (/path/to/project/node_modules/streamline/lib/transformSync.js:40:19)
    ...

Here's my test/mocha.opts (which worked without issue in Streamline 0.x):
--compilers coffee:coffee-script/register,_coffee:streamline/register
--reporter spec
--timeout 5000
--slow 500

And I have no .streamline.json file (neither in this project directory or my home directory). (And in general, I don't use Fibers, so I doubt I've specified it somewhere.)
—
Even if I add a .streamline.json file and manually specify {"runtime":"callbacks"}, I then get this error about the regenerator module.
[STREAMLINE] transforming (callbacks): /path/to/project/test/_auth._coffee

module.js:338
    throw err;
          ^
Error: Cannot find module 'regenerator/runtime'
    at Function.Module._resolveFilename (module.js:336:15)
    at Function.Module._load (module.js:278:25)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (/path/to/project/test/_auth._coffee:3:58)
    at Module._compile (module.js:460:26)
    at Module._compile (/path/to/project/node_modules/streamline/lib/register.js:52:12)
    at Object.._coffee (/path/to/project/node_modules/streamline/lib/register.js:65:10)
    at Module.load (/path/to/project/node_modules/coffee-script/lib/coffee-script/register.js:45:36)
    ...

Indeed, if I compile my code manually, I see that the generated JS has this at the top:
var regeneratorRuntime = typeof require === 'function' ? require('regenerator/runtime') : Streamline.require('regenerator/runtime');

So I guess I need to manually npm install regenerator too? The docs don't mention that; only that it's used for the compilation. Any reason streamline-runtime couldn't encapsulate this?
—
Finally, even when I do manually install regenerator, now I'm back to the same error as with fibers:
[STREAMLINE] transforming (callbacks): /path/to/project/test/fixtures/index._coffee
/path/to/project/node_modules/babel/node_modules/babel-core/lib/transformation/file/index.js:662
      if (err.stack) {
             ^
Error: No element indexed by 1
    at ArraySet_at [as at] (/path/to/project/node_modules/streamline/node_modules/source-map-support/node_modules/source-map/lib/source-map/array-set.js:83:11)

I debugged this by trying to compile that file manually, which gives a more helpful error:
[STREAMLINE] transforming (callbacks): /path/to/project/test/fixtures/index._coffee
SyntaxError: /path/to/project/test/fixtures/index._coffee: Line 85: unexpected `_` argument: enclosing function does not have an `_` parameter.
  83 |         _results = [];
  84 |         for (i = _i = 0; 0 <= numNodes ? _i < numNodes : _i > numNodes; i = 0 <= numNodes ? ++_i : --_i) {
> 85 |           _results.push(this.createTestNode(suite, _));
     |                         ^
  86 |         }
  87 |         return _results;
  88 |       }).call(_this);
    at File.errorWithNode (/path/to/project/node_modules/babel/node_modules/babel-core/lib/transformation/file/index.js:489:13)
    at NodePath.Plugin.visitor.CallExpression (/path/to/project/node_modules/streamline/node_modules/babel-plugin-streamline/lib/plugin.js:355:53)
    at NodePath.call (/path/to/project/node_modules/babel/node_modules/babel-core/lib/traversal/path/context.js:56:28)
    at NodePath.visit (/path/to/project/node_modules/babel/node_modules/babel-core/lib/traversal/path/context.js:90:8)
    at TraversalContext.visitMultiple (/path/to/project/node_modules/babel/node_modules/babel-core/lib/traversal/context.js:108:16)
    at TraversalContext.visit (/path/to/project/node_modules/babel/node_modules/babel-core/lib/traversal/context.js:146:19)
    at Function.traverse.node (/path/to/project/node_modules/babel/node_modules/babel-core/lib/traversal/index.js:76:17)
    at NodePath.visit (/path/to/project/node_modules/babel/node_modules/babel-core/lib/traversal/path/context.js:107:26)
    at TraversalContext.visitSingle (/path/to/project/node_modules/babel/node_modules/babel-core/lib/traversal/context.js:132:12)
    at TraversalContext.visit (/path/to/project/node_modules/babel/node_modules/babel-core/lib/traversal/context.js:148:19)
    at Function.traverse.node (/path/to/project/node_modules/babel/node_modules/babel-core/lib/traversal/index.js:76:17)
    at NodePath.visit (/path/to/project/node_modules/babel/node_modules/babel-core/lib/traversal/path/context.js:107:26)
    at TraversalContext.visitMultiple (/path/to/project/node_modules/babel/node_modules/babel-core/lib/traversal/context.js:108:16)
    ...

Here's the source CoffeeScript for that line of JS (which worked in Streamline 0.x):
nodes = (@createTestNode suite, _ for i in [0...numNodes])

And here's the JS that compiles to:
nodes = (function() {
  var j, ref, results1;
  results1 = [];
  for (i = j = 0, ref = numNodes; 0 <= ref ? j < ref : j > ref; i = 0 <= ref ? ++j : --j) {
    results1.push(this.createTestNode(suite, _));
  }
  return results1;
}).call(_this);

I think you previously had special-case checks for these CoffeeScript idioms?
—
For now, I rewrote those comprehensions to use explicit loops, so my code finally compiles now! =)
Unfortunately, one more break — with Node, this at the top level refers to module.exports, so I frequently use that in all my CoffeeScript modules to define my public exports:
@expectPrefix = (str, prefix) ->
    # ...

// AKA exports.expectPrefix = ...
this.expectPrefix = function (str, prefix) {
    // ...
};

Unfortunately, it looks like Streamline 1.0 compilation now breaks this!
/path/to/project/test/util/helpers.js:15
  this.expectPrefix = function (str, prefix) {
                    ^
TypeError: Cannot set property 'expectPrefix' of undefined
    at /path/to/project/test/util/helpers.js:15:21
    ...

Indeed, manually compiling with Streamline and looking at the bottom of the file:
var _filename = '/path/to/project/test/util/helpers._coffee';
(function () {
  // ...
}).call(undefined);

Why the undefined? Why not maintain whatever this happens to be at the top level? (E.g. whether exports in Node or window in the browser.)
—
I worked around that by manually replacing my @s with exports. everywhere... and finally, my code ran!! =)
Unfortunately, over half of my tests are failing now, and they're all failing by timing out — which suggests something related to Streamline and callbacks not getting called. =/
I'm exhausted at this point, so haven't debugged this further. But I wanted to file at least these issues.
Hope this helps, suggestions welcome, etc. Thanks @bjouhier.

Okay! I found the issue behind half my tests failing — I had replaced one too many @. Sorry for that false alarm (but literally everything else was still legit).
My tests are now almost back to 100%! I'll continue debugging the last few failures, but wanted to note one other thing: Mocha's reporter now doesn't output the list of errors at the end properly:
    ...
    ✓ should properly handle fatal database errors
    4) should properly handle non-fatal errors on the first query
    ✓ should properly handle fatal client errors on an auto-commit first query
    ✓ should properly handle fatal database errors on the first query
    5) should properly handle errors with batching
    - should support streaming (TODO)
    ✓ (delete test graph)

  99 passing (4s)
  12 pending
  5 failing

  6) (delete test graph)

(Normally, after the summary, Mocha prints all the errors + full stack traces.)
My tests are written in the standard Mocha + Streamline style (which has always worked):
describe 'Schema', ->

    it 'should support foo', (_) ->
        # ...

    # ...

    it '(delete test graph)', (_) ->
        fixtures.deleteTestGraph module, _

I think Streamline + Mocha's done callback is generally working (as evidenced by tests successfully running, and a few failures being reported as failures right away rather than timing out), but I wonder if there's something funky happening with the runner at the end.
It's obv. not your domain to debug Mocha, but FYI. I'm on Mocha 2.0.1 (and Node 0.12); I'll see if upgrading to the latest Mocha 2.3.3 helps.

@aseemk
Thanks for the detailed report. Given the scope of the changes a beta would have been very helpful but I rushed a bit the release because of a dependency on some internal project (which is now running smoothly with streamline 1.0 - but we are not using everything).
Here are some first answers, with links to the issues that I have created to track their resolution.

#298. The NPM warnings are expected. I'm going to upgrade to babel 6 soon and I will try to fix them in this second pass.
#300. The incorrect babel dependency is a serious blunder. I'll fix it ASAP and republish to NPM.
The fibers default is intentional. I put a note about it but it is a bit buried at the end of the FAQ. The main reason is performance and debuggability. At least for us, the fibers runtime is a winner.
#301. You are right about the regenerator dependency. The intent was to encapsulate it in streamline-runtime but I must have missed something.
#302. I'll need to check the CS comprehension issue. Normally streamline 1.0 should handle the CS idioms but my testing is very limited because we only have one CS module in our stack. Our unit tests pass on this module but that's not very thorough. Was this related to the extra @ or not?
#303. The this/undefined issue is an oversight. I'm going to fix it.
#304. The moccha issue needs investigation.

Thanks for being so receptive to feedback as always, @bjouhier. Much appreciated!
Btw, the CS comprehension issue was a legit issue; not related to extra @. Thanks.

Also, thanks for the heads-up that fibers is the new default. Agreed it'd be good to document that explicitly in the runtimes section.

I just published 1.0.9 to NPM. So I'm closing this one and I'll be following up in the specific issues.

Awesome, I'll (try to) try again later today and let you know how it goes. Thanks again!


Methods for option

What type of PR is this? (check all applicable)

[ ] Refactor
[x] Feature
[ ] Bug Fix
[ ] Optimization
[ ] Documentation Update

Description
In this PR I have added two methods for the Option cutie:

ofSome: Creates an Option with a safe value, so it will return the subtype Some
ofNone: Creates an Option with no value, so it will return the subtype None

const some = Option.ofSome(5);
some.match(console.log, () => console.log('none')); // 5

const none = Option.ofNone();
none.match(console.log, () => console.log('none')); // none

Added/updated tests?

[x] Yes
[ ] No, and this is why: please replace this line with details on why tests
have not been included
[ ] I need help with writing tests

What gif best describes this PR or how it makes you feel?

I don't know how the ofSome method should behave with null/undefined, what do you think the behavior should be?
const nullishSome = Option.ofSome(null) // ???
const undefinedSome = Option.ofSome(undefined) // ???

I don't know how the ofSome method should behave with null/undefined, what do you think the behavior should be?
const nullishSome = Option.ofSome(null) // ???
const undefinedSome = Option.ofSome(undefined) // ???

mmm maybe we could create this Type:
type NotNullable<T> = T extends null | undefined ? never : T
So, ofSome method should be something like:
  static ofSome<T>(value: NotNullable<T>): Some<T> {
    return new Some(value);
  }

In this way, the TS compiler raises an error if you try to pass an undefined or null as value with the static analysis

Y try to do this, but not working well. In the editor I see a warning, but the test pass:

I tried two options for NotNullable type:
//type NotNullable<T> = T extends null | undefined ? never : T
export type NotNullable<T> = Exclude<T, null | undefined>;

And I add this in tsconfig:
{
  "compilerOptions": {
    "strict": true,
    "strictNullChecks": true,
  },

You can check all details in the last commit

From my point of view, this cannot be tested with Vitest or Jest with a test case. I mean, the test actually is the static analysis of code, if this finds an error it will notify the developer to fix it (as a red test case). In addition, You can try to run a build, this should fail.  At the end, we can pass anything in runtime a function that allows statically a specific type as input parameter 😟
Could you verify my guess, running the build action?

Yeah this worked well! 😄
In the next commit the code will be ready

Same, thanks for this contribution @Sstark97! ❤

@Sstark97 if you consider PR is ready, you can remove Draft state.


Updated Inheritance and Dynamic Binding sections

Added info about single and multiple inheritance.
Added the alternative names for dynamic binding

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 📝


[Mac] [Net] Installation seems frozen after a couple hours of waiting

The latest Mac OS X network installer (first one shared with me on dropbox) seems to be frozen (been waiting more than 2 hours) at this stage where according to @voldezar the download of components is taking place:

Eventually after another hour or so:

@voldezar this problem continues still. I tried on a fresh new Mac VM without anything on it.


Add support for configuration in SearchPlugin

Description:
Currently, the SearchPlugin in the project lacks some default configurations such as support for fuzzy search. Fuzzy search can significantly improve the accuracy and efficiency of search results, and it is an essential feature for many applications.
I am unsure about the best location for this configuration. maybe, I believe it should be at the same level as the uno.config.ts file.
It would be helpful to update the documentation with information about the new configuration options and usage examples to help other developers use it effectively.
Proposal:
Add the configuration option to the SearchPlugin.
Update the documentation to include information about the new configuration options and usage examples.
I believe this change would significantly improve the search functionality of the project and make it easier to use for developers.
Links
vitepress-plugin-search -- support for fuzzy search #30
import { SearchConfig } from 'search.config.ts'

SearchPlugin(SearchConfig)

Replace vitepress-plugin-search with new vitepress local search option.
Close this issue because it is obsolete.


ConditionalIconItem a valid type for IconSpec, but not working?

The IconSpec type lists ConditionalIconItem as a valid type, but it doesn't appear to be functional for something like a ToolItemDef which has an icon field that is typed as IconSpec
To Reproduce

Create a ToolItemDef instance for a ToolbarComposer that is set with an icon defined as a ConditionalIconItem
Notice the icon in the app shows as blank

Expected behavior
Expected this to behave exactly like ConditionalStringValue except I could use a React.Node for the actual icon, which is the primary use case for attempting to use ConditionalIconItem instead
Desktop (please complete the applicable information):

OS: Windows
Browser: Chrome
Version: 112.0.5615.138
iTwin.js AppUI Version: 4.0.0
iTwin.js Version: 3.7.0

Additional context
I was expecting to find handling for this in ToolbarItemsManager where it checks the ConditionalStringValue and ConditionalBooleanValue

Hi! A fix for this have been included and released in 4.2.0, let us know if it addresses your isssue !


[FLINK-11623][chinese-translation] config.md

<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*

*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*

## Contribution Checklist

  - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/browse/FLINK-11623).

  - Name the pull request in the form "[FLINK-11623] [chinese-translation] Title of the pull request"

Hi @hanfeio ,  thanks for your contribution.
Could you please rebase your commit to the latest master? So that We can start to review it.

@hanfeio are you still working this, and could you please rebase the master to resolve the conflicts.
PS we need only translate the Configuration Page in this PR


parameter in range

How can I put parameter in range like this:
member_{1..<{fixtures_entities_count}>}:

AFAIK you can't. That being said I may be wrong you should ask to Alice instead. Closing the ticket as it's an Alice feature/issue.


Redacts x-ms-copy-source header.

Redacts x-ms-copy-source header.
Optimize comments for highlevel.

Close as sending PR from forked branch is not supported temporarily.


Regression in the Twig url() function

In Grav v1.5.10 and older, the Twig expression {{ url('plugins://doesntexist')|default(url('plugins://exists')) }} would have given the same results as the expression {{ url('plugins://exists') }}, provided plugins://exists existed, and plugins://doesntexist didn't. Now, in Grav v1.6.9 (although I suspect the issue to be there since v1.6.0), the expression returns /. The problem is caused by the Twig function url() having ceased to return null when a path is not found, and the offending commit seems to be getgrav/grav@66bba376db31bc713879c580657c9ae8d02a6b4e.
This has caused various issues with all the usecases of url() that depend on it returning null when a path is not found, although the issue with url() combined with the default filter seems to be the most evident example - not only has it caused some breakage in my plugin, it was also visible in the Grav documentation at the time of this writing. Due to that, I would like to request that the regression is fixed soon - sadly, I don't currently have the time nor expertise to figure out how exactly that should be done in order to avoid breaking some three hundred other things using that function.
Great thanks to everyone working hard to make Grav a better CMS for us all.

Ok after some discussions with @mahagr, we've decided to revert to the previous URL behavior even though this is not really helpful when trying to work out 'why' or 'what' caused the failure in the URL logic.  As such I've added a new $fail_gracefully 3rd argument, which when set to true will exhibit the current 1.6 behavior, but is false by default and will return url() the previous behavior.


Feedback for notebook comparing observational and galaxy properties for DC2

I've created a notebook that can be used with Run 1.2i, 1.2p, or 2.1i to analyze the relationships between observational and galaxy properties.  It is located in the branch u/npjoshi/validation-notebooks under contributed, named Observation_vs_galaxy.  Please take a look at it and give me any feedback regarding additional tests that can be included or anything else that would be useful.  Thanks!
direct link: https://github.com/LSSTDESC/DC2-analysis/blob/u/npjoshi/validation-notebooks/contributed/Observation_vs_galaxy.ipynb

@nehapjoshi do you want to submit a Pull Request for your notebook so that we can assign a reviewer?

At the moment, the notebook isn't ready for review to be incorporated into the master branch.  Rachel and I were hoping to get some general feedback about other tests that would be good to run and show that a galaxy property is (hopefully) independent of observational properties, in addition to ones already included using properties like PSF FWHM and ellipticity of PSF against colors and magnitude.
@fjaviersanchez when Rachel and I had asked about next steps for this notebook you had indicated that I should put it up here. Are there any other steps that would be appropriate?

Thanks @nehapjoshi! The tests in your notebook look good to me. I'll take another look and check if I can come up with something else. @kadrlica and @rmjarvis may have some feedback so I'm pinging them here. One thing that can be useful is to prepare this notebook for review and add other tests in a second version (or a second notebook). What do you think?

We'd like to do whatever is most useful - if there are obvious tests to add based on an initial look, we thought it might be best to do before the initial review.  But if not, then we can indeed prepare it for review now.  Neha, let's discuss this when we meet today.

I think that now that we closed #117 we can close this as well. Please, feel free to reopen if you think it'll be helpful. Thanks for submitting the notebook @nehapjoshi!


first commit

created a branch, created a file and made a commit, and opened a pull request

Pull request


Changes to xSQLServerMemory part:

Changes to xSQLServerMemory

adding possibility to manager memory for multiply SQL instances. Changes were made to DSCResources/MSFT_xSQLServerMemory/MSFT_xSQLServerMemory.schema.mof file, another key value was added - SQLInstanceName;
adding possibility to manage memory for multiply SQL instances. Changes were made to  DSCResources/MSFT_xSQLServerMemory/MSFT_xSQLServerMemory.psm1 fileL

ammended change to accept 0 MB as MinMemory value, predefined value was set to -1, as 0 in all if checks as $false;
SQLInstanceName value became mandatory for this xSQLServerMemory functionality.

This change is

Hi @Radamonas, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@Radamonas, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;

Review status: 0 of 2 files reviewed at latest revision, 4 unresolved discussions.

DSCResources/MSFT_xSQLServerMemory/MSFT_xSQLServerMemory.psm1, line 70 [r1] (raw file):
Remove commented-out code
(You can add an informative comment somewhere if you think the user needs to know what the default value should be.)

DSCResources/MSFT_xSQLServerMemory/MSFT_xSQLServerMemory.psm1, line 128 [r1] (raw file):
Remove commented-out code

DSCResources/MSFT_xSQLServerMemory/MSFT_xSQLServerMemory.psm1, line 176 [r1] (raw file):
There needs to be a check here for $MinMemory -lt 0 to keep the same functionality. If  Ensure = 'Present' was declared without MinMemory, MaxMemory, or Dynamic Alloc declared, then the resource is being called incorrectly and the error needs to be thrown.

DSCResources/MSFT_xSQLServerMemory/MSFT_xSQLServerMemory.psm1, line 229 [r1] (raw file):
Remove commented-out code

Comments from Reviewable

@Radamonas Please add your changes to the README per the contributing guidelines.

Review status: 0 of 2 files reviewed at latest revision, 4 unresolved discussions.

DSCResources/MSFT_xSQLServerMemory/MSFT_xSQLServerMemory.psm1, line 128 [r1] (raw file):
Done.

DSCResources/MSFT_xSQLServerMemory/MSFT_xSQLServerMemory.psm1, line 176 [r1] (raw file):
$MinMemory should not be mandatory, as according to documentation it can be shown as equal to 0 and remain as not defined and it can be equal 0 even it is recalculated as min. according to the environment (32bit or 64bit).
I'd thinking about changing the message below and validation into version below:
 if (!$MaxMemory -or ($MinMemory -gt $MaxMemory))
                    {
                        Throw "Dynamic Allocation is not set, Max memory was not passed or Min memory value is greater than Max memory."
                        Exit
                    }

Also please note, that there is no possibility to provide negative value of $MinMemory value to set it on db as there is additional check below:
 if($MinMemory -ge 0)
            {
                Write-Verbose -message "MinMem will be set to $MinMemory."
                $sql.Configuration.MinServerMemory.ConfigValue = $MinMemory
            }

DSCResources/MSFT_xSQLServerMemory/MSFT_xSQLServerMemory.psm1, line 229 [r1] (raw file):
Done.

Comments from Reviewable

Review status: 0 of 3 files reviewed at latest revision, 4 unresolved discussions.

DSCResources/MSFT_xSQLServerMemory/MSFT_xSQLServerMemory.psm1, line 70 [r1] (raw file):
Previously, kwirkykat wrote…
> Remove commented-out code
> (You can add an informative comment somewhere if you think the user needs to know what the default value should be.)
Done.

DSCResources/MSFT_xSQLServerMemory/MSFT_xSQLServerMemory.psm1, line 128 [r1] (raw file):
Previously, Radamonas (Rapolas Dangveckas) wrote…
> Done.
Done.

Comments from Reviewable

Reviewed 1 of 2 files at r1, 1 of 2 files at r2.
Review status: 2 of 3 files reviewed at latest revision, 3 unresolved discussions.

DSCResources/MSFT_xSQLServerMemory/MSFT_xSQLServerMemory.psm1, line 176 [r1] (raw file):
Previously, Radamonas (Rapolas Dangveckas) wrote…
> $MinMemory should not be mandatory, as according to documentation it can be shown as equal to 0 and remain as not defined and it can be equal 0 even it is recalculated as min. according to the environment (32bit or 64bit).
>
> I'd thinking about changing the message below and validation into version below:
> ```
>  if (!$MaxMemory -or ($MinMemory -gt $MaxMemory))
>                     {
>                         Throw "Dynamic Allocation is not set, Max memory was not passed or Min memory value is greater than Max memory."
>                         Exit
>                     }
> ```
>
> Also please note, that there is no possibility to provide negative value of $MinMemory value to set it on db as there is additional check below:
> ```
>  if($MinMemory -ge 0)
>             {
>                 Write-Verbose -message "MinMem will be set to $MinMemory."
>                 $sql.Configuration.MinServerMemory.ConfigValue = $MinMemory
>             }
> ```
>

I don't think MinMemory should be mandatory, but previously, when DynamicAlloc was set to false and you did not supply MaxMemory but did supply a valid MinMemory (0 or greater), the resource would *not* throw an error. Now, if you supply a valid MinMemory value , but not a MaxMemory value, the resource will throw an error.
Also to keep the error message clear, the check that MaxMemory or MinMemory is present and the check that MinMemory is not greater than MaxMemory should be separated. Like this:
if  (-not $MaxMemory -or $MinMemory -lt 0) {
    throw "Dyanamic Allocation is not set. Valid values were not supplied for MaxMemory or MinMemory.
}

if ($MinMemory -gt $MaxMemory) {
    throw "MinMemory is greater than MaxMemory."
}

DSCResources/MSFT_xSQLServerMemory/MSFT_xSQLServerMemory.psm1, line 60 [r2] (raw file):

        [System.Int32]
        $MinMemory,

This should also be default to -1 to match the other TargetResource functions.

DSCResources/MSFT_xSQLServerMemory/MSFT_xSQLServerMemory.psm1, line 147 [r2] (raw file):

                   $MaxMemory =2147483647
                   $MinMemory = 128
                #}

Please remove commented-out code.

Comments from Reviewable

Review status: 2 of 3 files reviewed at latest revision, 3 unresolved discussions.

DSCResources/MSFT_xSQLServerMemory/MSFT_xSQLServerMemory.psm1, line 147 [r2] (raw file):
Previously, kwirkykat (Katie Keim) wrote…
> Please remove commented-out code.

Done.

Comments from Reviewable

Review status: 2 of 3 files reviewed at latest revision, 3 unresolved discussions.

DSCResources/MSFT_xSQLServerMemory/MSFT_xSQLServerMemory.psm1, line 176 [r1] (raw file):
Previously, kwirkykat (Katie Keim) wrote…
> I don't think MinMemory should be mandatory, but previously, when DynamicAlloc was set to false and you did not supply MaxMemory but did supply a valid MinMemory (0 or greater), the resource would *not* throw an error. Now, if you supply a valid MinMemory value , but not a MaxMemory value, the resource will throw an error.
>
> Also to keep the error message clear, the check that MaxMemory or MinMemory is present and the check that MinMemory is not greater than MaxMemory should be separated. Like this:
>
> ```powershell
> if  (-not $MaxMemory -or $MinMemory -lt 0) {
>     throw "Dyanamic Allocation is not set. Valid values were not supplied for MaxMemory or MinMemory.
> }
>
> if ($MinMemory -gt $MaxMemory) {
>     throw "MinMemory is greater than MaxMemory."
> }
> ```

Done.

DSCResources/MSFT_xSQLServerMemory/MSFT_xSQLServerMemory.psm1, line 60 [r2] (raw file):
Previously, kwirkykat (Katie Keim) wrote…
> This should also be default to -1 to match the other TargetResource functions.

Done.

Comments from Reviewable

Review status: 2 of 3 files reviewed at latest revision, 3 unresolved discussions.

DSCResources/MSFT_xSQLServerMemory/MSFT_xSQLServerMemory.psm1, line 147 [r2] (raw file):
Previously, Radamonas (Rapolas Dangveckas) wrote…
> Done.

Done.

Comments from Reviewable

Review status: 2 of 3 files reviewed at latest revision, 1 unresolved discussion.

DSCResources/MSFT_xSQLServerMemory/MSFT_xSQLServerMemory.psm1, line 176 [r1] (raw file):
Previously, Radamonas (Rapolas Dangveckas) wrote…
> Done.

One last tiny change. It looks like this should be an -and rather than an -or (to avoid making $MinMemory mandatory) since it was an -xor before.

Comments from Reviewable

Review status: 2 of 3 files reviewed at latest revision, 1 unresolved discussion.

DSCResources/MSFT_xSQLServerMemory/MSFT_xSQLServerMemory.psm1, line 176 [r1] (raw file):
Previously, kwirkykat (Katie Keim) wrote…
> One last tiny change. It looks like this should be an -and rather than an -or (to avoid making $MinMemory mandatory) since it was an -xor before.

Hi, as -if we are discussing is within **-if ($DynamicAlloc) {} else {*-- here --*}** it doesn't seem reasonable to have suggested *-and*, as this part assumes that dynamic allocation was not requested and this leads to assumption that all values needed for memory setup has to be provided, so *-or* helps us to identify what one of both values were not provided when dynamic memory allocation was not chosen.

Comments from Reviewable

@Radamonas - Any updates on this PR?

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

DSCResources/MSFT_xSQLServerMemory/MSFT_xSQLServerMemory.psm1, line 176 [r1] (raw file):
Previously, Radamonas (Rapolas Dangveckas) wrote…
> Hi, as -if we are discussing is within **-if ($DynamicAlloc) {} else {*-- here --*}** it doesn't seem reasonable to have suggested *-and*, as this part assumes that dynamic allocation was not requested and this leads to assumption that all values needed for memory setup has to be provided, so *-or* helps us to identify what one of both values were not provided when dynamic memory allocation was not chosen.

Ok. You're right

Comments from Reviewable

@kwirkykat can we merge this since all checks are good?


Any plan for open source?

有计划开源吗？

Hi, sorry for the late reply. The code and training script are released. If you are only interested in the binary preference version of  NCA, it is also supported by the official trl library now (By setting loss_type to nca_pair in DPOTrainer).
https://github.com/huggingface/trl/blob/cd85b14fbbaf7e4d9b01ef8ec19655666af20047/trl/trainer/dpo_trainer.py#L1135


TypeError: "img" must be a numpy array or a str or a pathlib.Path object

(open-mmlab) fsr@serverA2:~/FoveaBox$ python demo/webcam_demo.py configs/foveabox/fovea_r50_fpn_4gpu_2x.py "/home/fsr/FoveaBox/checkpoints/fovea_r50_fpn_4x4_2x_coco_20200203-2df792b1.pth"
[ WARN:0] global /tmp/pip-req-build-xgme2194/opencv/modules/videoio/src/cap_v4l.cpp (893) open VIDEOIO(V4L2:/dev/video0): can't open camera by index
Press "Esc", "q" or "Q" to exit.
Traceback (most recent call last):
File "demo/webcam_demo.py", line 45, in
main()
File "demo/webcam_demo.py", line 33, in main
result = inference_detector(model, img)
File "/home/fsr/FoveaBox/mmdet/apis/inference.py", line 67, in inference_detector
return _inference_single(model, imgs, img_transform, device)
File "/home/fsr/FoveaBox/mmdet/apis/inference.py", line 91, in _inference_single
img = mmcv.imread(img)
File "/home/fsr/anaconda3/envs/open-mmlab/lib/python3.7/site-packages/mmcv/image/io.py", line 98, in imread
raise TypeError('"img" must be a numpy array or a str or '
TypeError: "img" must be a numpy array or a str or a pathlib.Path object

It seems that your image is not correctly read.


bitvec 1.0 fails on esp32 target xtensa-esp32-none-elf due to radium 0.7.0

The if_atomic! macro in radium 0.7.0 doesn't support the xtensa architecture, and as such I get these errors when trying to build with the esp32 toolchain:
 Compiling radium v0.7.0
error[E0432]: unresolved imports `core::sync::atomic::AtomicI64`, `core::sync::atomic::AtomicU64`
  --> /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/radium-0.7.0/src/lib.rs:53:34
   |
53 |         use core::sync::atomic::{AtomicI64, AtomicU64};
   |                                  ^^^^^^^^^  ^^^^^^^^^ no `AtomicU64` in `sync::atomic`
   |                                  |
   |                                  no `AtomicI64` in `sync::atomic`
   |
help: a similar name exists in the module
   |
53 |         use core::sync::atomic::{AtomicI8, AtomicU64};
   |                                  ~~~~~~~~
help: a similar name exists in the module
   |
53 |         use core::sync::atomic::{AtomicI64, AtomicU8};
   |                                             ~~~~~~~~

error[E0412]: cannot find type `AtomicI64` in module `core::sync::atomic`
    --> /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/radium-0.7.0/src/types.rs:52:41
     |
52   |       if atomic(64) { core::sync::atomic::AtomicI64 }
     |                                           ^^^^^^^^^ help: a struct with a similar name exists: `AtomicI16`
     |
    ::: /home/runner/.rustup/toolchains/esp/lib/rustlib/src/rust/library/core/src/sync/atomic.rs:2741:1
     |
2741 | / atomic_int! {
2742 | |     cfg(target_has_atomic = "16"),
2743 | |     cfg(target_has_atomic_equal_alignment = "16"),
2744 | |     stable(feature = "integer_atomics_stable", since = "1.34.0"),
...    |
2758 | |     i16 AtomicI16 ATOMIC_I16_INIT
2759 | | }
     | |_- similarly named struct `AtomicI16` defined here

error[E0412]: cannot find type `AtomicU64` in module `core::sync::atomic`
    --> /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/radium-0.7.0/src/types.rs:58:41
     |
58   |       if atomic(64) { core::sync::atomic::AtomicU64 }
     |                                           ^^^^^^^^^ help: a struct with a similar name exists: `AtomicU16`
     |
    ::: /home/runner/.rustup/toolchains/esp/lib/rustlib/src/rust/library/core/src/sync/atomic.rs:2761:1
     |
2761 | / atomic_int! {
2762 | |     cfg(target_has_atomic = "16"),
2763 | |     cfg(target_has_atomic_equal_alignment = "16"),
2764 | |     stable(feature = "integer_atomics_stable", since = "1.34.0"),
...    |
2778 | |     u16 AtomicU16 ATOMIC_U16_INIT
2779 | | }
     | |_- similarly named struct `AtomicU16` defined here

Would it be possible to upgrade bitvec to radium 1.0.0? It would be less brittle as it relies on cfg(target_has_atomic). This would bump the MSRV of bitvec to 1.60.

Hello! Sorry to necro an old issue, but I'm running into a similar problem trying to use bitvec in my project. I'm using a rust/llvm fork to target the NEC v810 CPU, which has atomics but is only 32-bit. It looks like radium assumes that an unrecognized target supports AtomicU64, which I don't think is easy for me to add.
My target environment uses some memory-mapped structs with lots of bitfields, so I'm planning to try other libraries or maybe just plumb it together manually. But I'd love if I could use bitvec on embedded hardware from the 90s.


Adapt terraform tfvars to start using SLE_15_SP2 repositories and CaaSP v5 devel projects

Why is this PR needed?
This PR is needed to switch master from CaaSPv4 to CaaSPv5.
What does this PR do?
Changes the repositories of the nodes to start using SLE15_SP2 and CaaSPv5.
Anything else a reviewer needs to know?
Note that once this PR is merged master branch won't be any longer CaaSPv4.

This was merged into the branch experimental-v5 when it was ea620ad34d3fc51f13c8e8efbb2186a1500899e9 .

This PR has changed the target branch from master to experimental-v5. There are some opened PRs required for transitioning from v4 to v5:

#997
#1107
#1132
#1138
#1140

We want to merge them all into an experimental branch so we can actually test it all together before merging it to master.
Note this PR commits are expected to get into master along with #1137


Storm-2203 Add a getAll method to KeyValueState interface

Adds a getAll to InMemoryKeyValueState and RedisKeyValueState. I'll add tests once the changes are approved.

@aandis
Looks great. Could you add tests if possible? You may want to rename the prefix of the title to STORM-2203 so that it can be linked to JIRA issue automatically.
Thanks in advance!

Ping @HeartSaVioR @arunmahadevan can you review this?

@aandis Could you address review comments from @arunmahadevan?

@HeartSaVioR yep. will do in next couple of days.

@HeartSaVioR @arunmahadevan ready for review.

+1

@aandis thanks for the work, merged to master and 1.x-branch. You can close the PR.

Thanks @arunmahadevan. :) Out of curiosity, why don't we use github's merge branch feature to merge branches directly from this page? Or was it just a temporary thing because of integration tests failing here?


create perimeter81.sh

sudo ./installomator.sh perimeter81 DEBUG=0
2021-10-06 11:40:25 perimeter81 setting variable from argument DEBUG=0
2021-10-06 11:40:25 perimeter81 ################## Start Installomator v. 0.7.0b1
2021-10-06 11:40:25 perimeter81 ################## perimeter81
2021-10-06 11:40:25 perimeter81 BLOCKING_PROCESS_ACTION=prompt_user
2021-10-06 11:40:25 perimeter81 NOTIFY=success
2021-10-06 11:40:25 perimeter81 LOGO=/System/Applications/App Store.app/Contents/Resources/AppIcon.icns
2021-10-06 11:40:25 perimeter81 no blocking processes defined, using Perimeter81 as default
2021-10-06 11:40:25 perimeter81 Changing directory to /var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/T/tmp.uJdsO9NC
2021-10-06 11:40:26 perimeter81 App(s) found:
2021-10-06 11:40:26 perimeter81 could not find Perimeter81.app
2021-10-06 11:40:26 perimeter81 appversion:
2021-10-06 11:40:26 perimeter81 Latest version of Perimeter81 is curl -fsIL https://static.perimeter81.com/agents/mac/snapshot/latest/Perimeter81.pkg | grep -i ^x-amz-meta-version | sed -E 's/x-amz-meta-version: //'
2021-10-06 11:40:26 perimeter81 Downloading https://static.perimeter81.com/agents/mac/snapshot/latest/Perimeter81.pkg to Perimeter81.pkg
2021-10-06 11:40:27 perimeter81 no more blocking processes, continue with update
2021-10-06 11:40:27 perimeter81 Installing Perimeter81
2021-10-06 11:40:27 perimeter81 Verifying: Perimeter81.pkg
2021-10-06 11:40:27 perimeter81 Team ID: 924635PD62 (expected: 924635PD62 )
2021-10-06 11:40:27 perimeter81 Installing Perimeter81.pkg to /
installer: Package name is Perimeter81
installer: Installing at base path /
installer: The install was successful.
2021-10-06 11:40:40 perimeter81 Finishing…
2021-10-06 11:40:51 perimeter81 App(s) found:
2021-10-06 11:40:51 perimeter81 could not find Perimeter81.app
2021-10-06 11:40:51 perimeter81 Installed Perimeter81
2021-10-06 11:40:51 perimeter81 notifying
2021-10-06 11:40:52 perimeter81 Deleting /var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/T/tmp.uJdsO9NC
2021-10-06 11:40:52 perimeter81 App not closed, so no reopen.
2021-10-06 11:40:52 perimeter81 ################## End Installomator, exit code 0

You are getting closer, but either you have to cut the version returned from the download, or find another place for the version number. I cannot see any other versions in the app to test against.


[Fix #15 #3] Allow to specify the config file location & stop on failure

For example you can modify the base Envoy.blade.php to something like this:
@setup
	$configFile = 'config/deploy.php';
@endsetup

@include('vendor/exolnet/laravel-envoy/init.php')

Oups! Sorry! I've fix it!

I may have a suggestion, although I'm not sure if it's a good one. We could set a list of locations to look for a deploy.php file, and the first that matches would be the one used. This way, we could have a solution that can work for both L4 and L5.
What do you think?

On the long term, I think we should be the less framework agnostic.

Oups... My other change was append! How could I manage my local repo to have multiple PR in parallel?

You'd have to do the change in a separate branch.

I assume you meant "more" framework agnostic? If that is the case, then "laravel-envoy" is going to be a bad project name in the near future :smile:.

Yeah! I know that laravel-envoy would be a bad project name. Maybe we should change it soon.


Parallel BVH creation using rayon

This is essentially just a port of the parallel bvh creation from https://github.com/svenstaro/bvh/pull/80
Most of the added code outside the build functions was added for testing, with the main changes being the build functions being rewritten to work on mutable slices of indices instead of recursively passing back an index.
Based on the polyanya baking bench, this is about 10% faster singlethreaded (with the rayon feature disabled, ~9.4ms main -> 8.4ms pr), or about 60% faster when multithreaded (~9.4ms main -> ~3.5ms pr). Even with a single thread rayon taskpool it's still faster than main (~8.9ms), and gets faster up until 4-5 threads on my machine, at which point gains become tiny, then non existent (2Threads: ~5.5ms, 4T: ~3.8ms, 6T: ~3.4ms, 8T: ~3.4ms)
I had a bevy tasks implementation as well, but it was quite a bit slower than the single threaded version so I didn't bother with it.

Turns out this can be almost as performant with bevy tasks as it is with rayon so long as the number of tasks (parallel recurse iterations) is heavily limited.
Rayon seems to perform better with more tasks than bevy tasks.
Not sure if it should be user configurable, or automatic based on the detected number of cpus, or if it should just have a static max total number of tasks.
Also this leads to conflicting features. I'm currently just panicking at runtime if it detects both the bevy and rayon features enabled at the same time.


SERXIONE-3000: Voice Guidance Spectrum asset heard when Xumo is in fo…

…reground
Reason for change:Enable Access restriction on TTS for COM-RPC interface Test Procedure: Mentioned in ticket
Risks: Low

It is a breaking interface change. We do not own this interface so I cannot forsee if these changes break builds. Typically I would make sure the changes are backwards compatible but I think that is not a high priority for Comcast.. So if you feel it is good to go, happy to merge it...

good to merge...all clients are rebuild


Can't get number of messages in subscription using listTimeSeries

Hello,
It is important for us to know the number of messages in a subscription.
We are using 'num_outstanding_messages'/'num_undelivered_messages' and can't get the exact amount right.
We use a small test to simulate it and it fails many times.
GCP_QUEUE listens to GCP_TOPIC_QUEUE messages.
@google-cloud/monitoring 0.6.0.
Debugging locally with linux mint 17.3.
We get an empty answer many times, even if we wait 4+ minutes,
though the stack driver console itself shows the correct number of messages after 60+seconds.
Test:
           const cp = CloudProvider({type: GCP, env: 'INT'});
            const size0 = await cp.queue.getSize(GCP_QUEUE);
            await cp.queue.sendMessage(GCP_TOPIC_QUEUE, {test: 'added one message to queue'});
           // https://cloud.google.com/monitoring/api/metrics_gcp#gcp-pubsub wait 120
          // seconds for  num_undelivered_messages
            await delay(121000);
            const size = await cp.queue.getSize(GCP_QUEUE);

            assert.ok(size0 === 0);
            assert.ok(size === 1);

And this is the function:
 async function getSize(queue) {
        const metricServiceClient = new monitoring.MetricServiceClient();
        const interval = 60;
        const nowSec = Date.now() / 1000;
        const metricType = 'pubsub.googleapis.com/subscription/num_undelivered_messages';
        const request = {
            name: metricServiceClient.projectPath(GCP_PROJECT_ID),
            filter: `metric.type="${metricType}" AND resource.labels.subscription_id="${queue}"`,
            interval: {
                startTime: {
                    seconds: nowSec - interval,
                },
                endTime: {
                    seconds: nowSec
                }
            }
        };

        const response = await metricServiceClient.listTimeSeries(request);

        if (response && response.length > 0 && response[0].length > 0 &&
            response[0][0].points && response[0][0].points.length > 0) {
            const point = response[0][0].points[0];

            if (point.value && point.value.int64Value) {
                const value = parseInt(point.value.int64Value, 10);

                if (isFinite(value)) {
                    return value;
                }
            }
        }

        return 0;
    }

Updating
            const interval = 60 * 70;
            filter: `metric.type="${metricType}" AND resource.type="pubsub_subscription" AND
            resource.label."subscription_id"="${queue}"`,

variables fixed the issue, it was not in like in the documentation and examples.

Greetings, we're closing this. Looks like the issue got resolved. Please let us know if the issue needs to be reopened.


vimPlugins.aider-nvim: init at 2023-10-22

Description of changes
Adds a package for the aider.nvim plugin.
This plugin allows you to use aider within Neovim.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@PerchunPak Good catch. Unfortunately I don't think there's a Nix package for aider so we need to wait for that first, I believe.

@nvimtor there is - aider-chat
https://github.com/NixOS/nixpkgs/blob/99dc8785f6a0adac95f5e2ab05cc2e1bf666d172/pkgs/by-name/ai/aider-chat/package.nix

@PerchunPak
Thanks. I've hit a roadblock. Given this example flake:
{
  description = "A simple flake with a custom Neovim build";

  inputs = {
    nixpkgs.url = "github:NixOS/nixpkgs/nixos-unstable";

		vitorpkgs.url = "github:nvimtor/nixpkgs/aider-nvim";

    flake-utils.url = "github:numtide/flake-utils";
  };

  outputs = { self, nixpkgs, vitorpkgs, flake-utils }:
    flake-utils.lib.eachDefaultSystem (system:
      let
        pkgs = nixpkgs.legacyPackages.${system};
        customNeovim = pkgs.neovim.override {
          configure = {
            packages.myVimPackage = with vitorpkgs.legacyPackages.${system}.vimPlugins; {
              start = [
								aider-nvim
                # Add more plugins here
              ];
            };
          };
        };
      in
      {
        packages.default = customNeovim;
      }
    );
}

I get
error: builder for '/nix/store/9l8ccbjdralcjy6g3ipqf622c925ammi-aider-chat-0.54.0.drv' failed with exit code 1;
       last 30 log lines:
       >                 if self.input.closed:
       >                     f.set_exception(EOFError)
       >
       >         # Enter raw mode, attach input and attach WINCH event handler.
       >         with self.input.raw_mode(), self.input.attach(
       >             read_from_input_in_context
       >         ), attach_winch_signal_handler(self._on_resize):
       >             # Draw UI.
       >             self._request_absolute_cursor_position()
       >             self._redraw()
       >             self._start_auto_refresh_task()
       >
       >             self.create_background_task(self._poll_output_size())
       >
       >             # Wait for UI to finish.
       >             try:
       > >               result = await f
       > E               EOFError
       >
       > /nix/store/fihchiss2fi8mamqwsfvjpsys2vqqa85-python3.11-prompt-toolkit-3.0.47/lib/python3.11/site-packages/prompt_toolkit/application/application.py:746: EOFError
       > ----------------------------- Captured stdout call -----------------------------
       > Run pip install? (Y)es/(N)o [Yes]:                                   Run pip install? (Y)es/(N)o [Yes]:
       > =========================== short test summary info ============================
       > FAILED tests/basic/test_main.py::TestMain::test_env_file_flag_sets_automatic_variable - EOFError
       > FAILED tests/basic/test_main.py::TestMain::test_false_vals_in_env_file - EOFError
       > FAILED tests/basic/test_main.py::TestMain::test_light_mode_sets_code_theme - EOFError
       > FAILED tests/basic/test_main.py::TestMain::test_main_with_empty_dir_no_files_on_command - EOFError
       > FAILED tests/basic/test_main.py::TestMain::test_true_vals_in_env_file - EOFError
       > FAILED tests/basic/test_main.py::TestMain::test_verbose_mode_lists_env_vars - EOFError
       > ================= 6 failed, 167 passed, 8 deselected in 17.63s =================
       For full logs, run 'nix log /nix/store/9l8ccbjdralcjy6g3ipqf622c925ammi-aider-chat-0.54.0.drv'.
error: 1 dependencies of derivation '/nix/store/1kgbb5r5q3aiwcqm1imyczda4qpwx3vl-vimplugin-aider.nvim-2023-10-22.drv' failed to build
error: 1 dependencies of derivation '/nix/store/yw0rzl96vq0h2pfl47zsll09wk1pd5fw-neovim-0.10.1.drv' failed to build

I'm not really sure what to do. I can build aider-chat just fine by running nix-shell -p aider-chat.
Any ideas?

Yeah, it should be fixed in master. See https://github.com/NixOS/nixpkgs/pull/343759
To fix this, just run git rebase master

@PerchunPak done, and it is working fine now

nixpkgs-review result
Generated using nixpkgs-review.

Command: nixpkgs-review pr 340370
Systems: x86_64-linux,aarch64-linux,x86_64-darwin,aarch64-darwin

x86_64-linux

:white_check_mark: 2 packages built:

vimPlugins.aider-nvim
vimPluginsUpdater

aarch64-linux

:white_check_mark: 2 packages built:

vimPlugins.aider-nvim
vimPluginsUpdater

x86_64-darwin

:white_check_mark: 2 packages built:

vimPlugins.aider-nvim
vimPluginsUpdater

aarch64-darwin

:white_check_mark: 2 packages built:

vimPlugins.aider-nvim
vimPluginsUpdater


PubSub ListenToVideoPlayback / null in VideoPlayback

Hi,
ListenToVideoPlayback needs a channel name, not a channel Id. I would also suggest putting some comment in documentation that is not "official" part of Twitch API and can change without any kind of notice.
 public void ListenToVideoPlayback(string channelName)
        {
            listenToTopic($"video-playback.{channelName}");
        }

and when I actually make that work there is a null crash in VideoPlayback.cs
 if (Type != VideoPlaybackType.ViewCount)
                PlayDelay = int.Parse(json.SelectToken("play_delay").ToString());
            else
                Viewers = int.Parse(json.SelectToken("viewers").ToString());

play_delay token exists only on stream-up type this code triggers on stream-down too.
I guess you want something like
 if (Type == VideoPlaybackType.StreamUp)
                PlayDelay = int.Parse(json.SelectToken("play_delay").ToString());
  else if (Type == ViewCount)
                Viewers = int.Parse(json.SelectToken("viewers").ToString());

and consequence changes to OnStreamDownArgs event

Thanks for this, and yes it does need some improved documentation. Will fix both this weekend.

Hey I know its a late response but try it again with the latest version. It should contain all your mentions and should fix your problems.
If not dont hesistate to tell us what went wrong :)

This issue seems dead, going to go ahead and close it.


Add support for S3-compatible backends

This PR adds support for backing up to AWS S3 buckets, and to other object storage services with an S3-compatible API such as Backblaze. In addition to an address similar to the one for SFTP and REST servers, S3 needs a key ID and a key. This PR adds fields for these, right below the address field, that only show up when S3 is selected:

The values of these fields are then passed to Restic in the corresponding environment variables. The key ID is stored in UserDefaults, while the key is stored in the Keychain.
Restic docs:

Preparing a new repository: Amazon S3
Preparing a new respository: S3-compatible storage

Hi @tiwoc, thank you for the PR, this one looks good to me from the first sight!
I'm going to review this later after New Year, 2 things come into my mind right now:

S3 key's fields should be grouped with the address field (and thus be padded from the password field below)
I'd like to handle environment variables in some consistent way; not sure though but either constructing all the environment in the kit and just pass through the runner or keep doing what we're doing: pass S3 keys in distinct properties like we do with a password and keep assembling the environment in the runner

Very good points, thanks for your feedback!
In the latest commits, I've now changed the field layout so that the S3 fields are grouped with the address field, and moved the creation of the env vars down to the runner for consistency. This probably doesn't scale to dozens of additional config options, but if there's no plan for adding many more, the current solution works well.

Ah, I forgot to post an updated screenshot:

No pressure on the review though. I'm going to use my own build for the time being to see how it goes.


Missing assemblies?

I tried to compile and found references to Shaman.Runtime.* assemblies. I cannot find a package on nuget.org. Are the assemblies available anywhere?

Never mind. After some digging, I found the Shaman.Reflection and Shaman.ProcessUtils in your repository. Including them resolved compile issues. However, I did have to remove ValueTuple from Reflection because of naming conflicts.
This process would have been easier if either your repositories relected the namespace AND/OR readme documented the namespace. I did not initially think to navigate the code tree itself.


Why iOS can not play url start with Http, but start with Https can

Do you have App Transport Security setup correctly for the URL in question?
https://developer.apple.com/news/?id=12212016b

@RickDT yes,I have already setup , I can request api of http ,but I still can't play sound of http.

When I do that , It prompt error ,like this

Does the HTTPS version play in Safari if you just paste the URL?
According to this, the file is not valid, so I’m wondering if your web server is not serving HTTPS properly:
https://www.osstatus.com/search/results?platform=all&framework=all&search=1954115647

@RickDT  Rick, Sorry for the late response. Let me clarify, I want to use this to play mp3 files with http address (not https), i won't work even i set App Transport Security (see above), i can play those files with same address in Safari BTW.  I tried to download those files first and play those mp3 locally, it can play. I tried another mp3 file with https url, and it can play.
So, is there any other possible issue to stop streaming mp3 file with http address with this module?

My best guess is that the web server isn't fully compliant with whatever iOS needs. Things like Range headers come to mind. If you're serving this from your own custom server, that's probably the culprit.
To narrow that down, you could try hosting it on something like S3 and see if that works (it does for us).


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_32ed9c01-c344-4424-bdd5-4cec22408bea/pull/1 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-archive-test-target_32ed9c01-c344-4424-bdd5-4cec22408bea.git

Docs Build status updates of commit 6626f9e:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-UserAccountBuildPermissionInsufficientError] Owner v-alji no longer has Read permission of the repository https://github.com/opstest2/docs-archive-test-source. It might be due to recent GitHub changes on SSO. Please ask the owner v-alji to logon to Docs Portal https://ops.microsoft.com once again. If it is not the case, please ask anyone of Admin permission of the repo to assign a new owner via Docs Portal https://ops.microsoft.com

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Fix/goto timeout

Fixes https://github.com/MarketSquare/robotframework-browser/issues/435

It is buggy

Closed because #449


adding entity courseId and parameter in mutation

Description of changes
Add course ID to content
Add queryByCourseID
Fix section position not being deterministic
Database must be adapted before merge
DO NOT MERGE UNTIL  GATEWAY READY
How has this been tested?
Please describe the test strategy you followed. If not tested, please explain why.

[x] automated unit test
[x] automated integration test
[ ] manual, exploratory test

In case of manual test, please document the test well including a set of user instructions and prerequisites. Each including an action, it's result, and where appropriate a screenshot.
Checklist before requesting a review

[X] My code is easy to understand
[x] My code follows the coding guidelines of this project
[x] My code fulfills all acceptance criteria
[ ] The test coverage (line and branch) is reasonably high, especially on Service classes and other classes with complex logic
[ ] I have made corresponding changes to the documentation or
the wiki/adr
[ ] I made no breaking changes in the database schema or if so, I will perform a database migration

Checklist for reviewer

The code is easy to understand
The code follows
the coding guidelines of
this project
The code is tested or if not, the reason is documented or discussed
The added and existing tests reasonably cover the code change
The code has no breaking changes in the database schema or if so, the assignee is aware of it and
will perform a database migration

Looks good at a glance. But this can only be merged when everything is ready in the other services & gateway.
When everything is ready I will do some very small changes (graphql schema) and then merge.

warn me though because of the DB migration


Terrain exaggeration - make slider smooth and add label

The exaggeration slider snaps to whole (int) values, but the code casts the value to (float). I vaguely remember there being a reason for this. But perhaps we can make the slider go smoothly throughout a range, as well as have the exaggeration update 'live', and not only when releasing the slider drag?

Hi @tschie could you do a second review please?


Fix #16 -- add .pre-commit-hooks.yaml for pre-commit update

Greetings, @FalconSocial peeps!
As mentioned here: https://github.com/FalconSocial/pre-commit-python-sorter/issues/16
We need to add .pre-commit-hooks.yaml for newer pre-commit versions.
And it would be good to leave old hooks.yaml for some time.
Thanks for the package.

Hello @cknv, could you do me a favor?
I hope this commit can get released. Thanks!

I don't think I am in the position to help @TonyPythoneer, I no longer work at Falcon, so I don't have any rights to this repo anymore.

So, who is main maintainer now?

@TonyPythoneer honestly I wouldn't know, but I reached out to one of my contacts still working there, he promised to bring this up with the python developers there.
Sorry about the trouble though - I guess there should have been a clearer handoff between employees.


Stop pinning rake

The removal of the gem install of appbundler probably fixes where this
was leaking in.
Signed-off-by: Tim Smith<EMAIL_ADDRESS>

Confirmed this has no impact via an adhoc build


Added project_on to InnerSpace

Adds a project method to InnerSpace.
IMPORTANT NOTE: I did not check to see if this compiles because I am a bad person :(
I thought I should ask before doing that, should a test be added for this? The correctness of this method somewhat relies on dot and magnitude2 being correct.

I think it would be nice to have some tests. Alas, I have also been bad in adding tests to cgmath, and there are various ways that I have implemented them in the library. Could you have a go at adding them anyway?

Sorry for the late reply - got back from holidays this week and have been fighting jet lag!

Sure, I'll add a few tests when I have some time. And no problem with the late reply, I'm not waiting on this to go through or anything like that. Just thought it would be a useful method.

Hey brendan, just managed to subdue my laziness and add some tests. Hope they work for you!

Thanks! ❤


Add an option to prevent clearing the screen

For the purpose of scripting this app to make it apply to multiple files in a row, it would be good to prevent it from clearing the screen before creating the report.
Command-line switch?  -n for --noclear?  -m for --multi-run? -s for --stackable? -p for --prevent-clear?

I couldn't think of anything better, so I went with the double-negative "no-clear"


⚠ UdeS website (prod) has degraded performance

In b6dc161, UdeS website (prod) (https://www.usherbrooke.ca/) experienced degraded performance:

HTTP code: 200
Response time: 1271 ms

Resolved: UdeS website (prod) performance has improved in 896fa1b.


FR: MT Solutions Secondary PDP MT8 Hero variant

Agile Requirement
Create a new Hero variant for the secondary PDP MT8 page -> https://www.figma.com/file/oNwe2jHIICPMIe551EY62l/Mack-Reskin---Full-Project?type=design&node-id=2243-137825&mode=dev

We should use the PDP hero, no need for a new one, the team sees no value.


(JP) The app doesn't select any support

I have this problem: for some updates after "Nero Fest" the application doesn't select any support, it only searches and refreshes, but the script during the quest works fine.
However, on the NA server, the app perfectly selects the required support.
Device Model: Moto G7 Power
App Version: 1446
Android Version: 10
Screen Size: 1920x1080
RAM: 4G
https://user-images.githubusercontent.com/88400304/128592934-76fc0d80-372e-49e6-bca3-28cf87379576.mp4

In the video, the app should select Artoria but it doesn't. I have even tried with the other supports and the result is the same

You forgot to enable debug mode in the video.

@reconman isn't it just another dupe of #796?
We already had so many duplicate issues on this.

Think so too


HTTP2 example server feature parity

Updates NIOHTTP2Server to match the functionality of the HTTP1 server from swift-nio.

As this hasn't moved in a while @AlanQuatermain I'm going to close this: please feel free to re-open the PR if you want to move it forward again.


Consider becoming an ADP rather than NVD alternative

CVE project supports enhancing the record as an Authorized Data Publisher (ADP). The benefit of this approach is that the enhancement data can be supplied in a consistent CVE 5.0 schema as adpContainer attributes. A given CVE 5.0 record could have multiple enhancements from multiple ADPs supporting workflows based on provider org id.
References
https://github.com/CVEProject/cve-schema/blob/master/schema/v5.0/CVE_JSON_5.0_schema.json#L591
https://www.cve.org/Media/News/item/podcast/2021/12/14/Enhancing-CVE-Records-as-an

I think we're too early to have this conversation. Perhaps someday. I'll leave this open so we don't forget.


Added ctranslate2 translation example script

Added a ctransalte2 example which works on string tokens instead of integer tokens.
To run the example :
python3 example/custom_ct2_model.py --ct2-model-dir <your-modelp-dir> inp.parquet out.parquet

This script is breaking because it is unable to serialize ct2 model while loading on worker. I have run this after initializing NDC gpu dask cluster on slurm but this is not working here.

@uahmed93 , Can you post the error you saw here please.

Here:
Deployed LocalCUDACluster(22f3d4fd, 'tcp://<IP_ADDRESS>:37693', workers=1, threads=1, memory=1.79 TiB)...
2024-09-11 10:56:33,005 - distributed.protocol.pickle - ERROR - Failed to serialize <ToPickle: HighLevelGraph with 4 layers.
<dask.highlevelgraph.HighLevelGraph object at 0x15522cf81900>
 0. read-parquet-2f062a30cf4676cd0b9a4ab5cf06fe85
 1. repartition-2-aa356a5cb4dedecfbdd625f941566718
 2. to-parquet-03d4d012cafd9ed3bdb4ee7374761cf1
 3. store-to-parquet-03d4d012cafd9ed3bdb4ee7374761cf1
>.
Traceback (most recent call last):
  File "/lustre/fsw/portfolios/llmservice/users/uahmed/test_env/lib/python3.10/site-packages/distributed/protocol/pickle.py", line 63, in dumps
    result = pickle.dumps(x, **dump_kwargs)
AttributeError: Can't pickle local object 'to_parquet.<locals>.<lambda>'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/lustre/fsw/portfolios/llmservice/users/uahmed/test_env/lib/python3.10/site-packages/distributed/protocol/pickle.py", line 68, in dumps
    pickler.dump(x)
AttributeError: Can't pickle local object 'to_parquet.<locals>.<lambda>'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/lustre/fsw/portfolios/llmservice/users/uahmed/test_env/lib/python3.10/site-packages/distributed/protocol/pickle.py", line 81, in dumps
    result = cloudpickle.dumps(x, **dump_kwargs)
  File "/lustre/fsw/portfolios/llmservice/users/uahmed/test_env/lib/python3.10/site-packages/cloudpickle/cloudpickle.py", line 1479, in dumps
    cp.dump(obj)
  File "/lustre/fsw/portfolios/llmservice/users/uahmed/test_env/lib/python3.10/site-packages/cloudpickle/cloudpickle.py", line 1245, in dump
    return super().dump(obj)
TypeError: cannot pickle 'ctranslate2._ext.Translator' object
Traceback (most recent call last):
  File "/lustre/fsw/portfolios/llmservice/users/uahmed/test_env/lib/python3.10/site-packages/distributed/protocol/pickle.py", line 63, in dumps
    result = pickle.dumps(x, **dump_kwargs)
AttributeError: Can't pickle local object 'to_parquet.<locals>.<lambda>'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/lustre/fsw/portfolios/llmservice/users/uahmed/test_env/lib/python3.10/site-packages/distributed/protocol/pickle.py", line 68, in dumps
    pickler.dump(x)
AttributeError: Can't pickle local object 'to_parquet.<locals>.<lambda>'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/lustre/fsw/portfolios/llmservice/users/uahmed/test_env/lib/python3.10/site-packages/distributed/protocol/serialize.py", line 353, in serialize
    header, frames = dumps(x, context=context) if wants_context else dumps(x)
  File "/lustre/fsw/portfolios/llmservice/users/uahmed/test_env/lib/python3.10/site-packages/distributed/protocol/serialize.py", line 76, in pickle_dumps
    frames[0] = pickle.dumps(
  File "/lustre/fsw/portfolios/llmservice/users/uahmed/test_env/lib/python3.10/site-packages/distributed/protocol/pickle.py", line 81, in dumps
    result = cloudpickle.dumps(x, **dump_kwargs)
  File "/lustre/fsw/portfolios/llmservice/users/uahmed/test_env/lib/python3.10/site-packages/cloudpickle/cloudpickle.py", line 1479, in dumps
    cp.dump(obj)
  File "/lustre/fsw/portfolios/llmservice/users/uahmed/test_env/lib/python3.10/site-packages/cloudpickle/cloudpickle.py", line 1245, in dump
    return super().dump(obj)
TypeError: cannot pickle 'ctranslate2._ext.Translator' object

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/lustre/fsw/portfolios/llmservice/users/uahmed/ctransl/ctransl_cf.py", line 145, in <module>
    main()
  File "/lustre/fsw/portfolios/llmservice/users/uahmed/ctransl/ctransl_cf.py", line 141, in main
    outputs.to_parquet(args.output_parquet_path)
  File "/lustre/fsw/portfolios/llmservice/users/uahmed/test_env/lib/python3.10/site-packages/nvtx/nvtx.py", line 116, in inner
    result = func(*args, **kwargs)
  File "/lustre/fsw/portfolios/llmservice/users/uahmed/test_env/lib/python3.10/site-packages/dask_cudf/core.py", line 264, in to_parquet
    return to_parquet(self, path, *args, **kwargs)
  File "/lustre/fsw/portfolios/llmservice/users/uahmed/test_env/lib/python3.10/site-packages/dask/dataframe/io/parquet/core.py", line 1047, in to_parquet
    out = out.compute(**compute_kwargs)
  File "/lustre/fsw/portfolios/llmservice/users/uahmed/test_env/lib/python3.10/site-packages/dask/base.py", line 379, in compute
    (result,) = compute(self, traverse=False, **kwargs)
  File "/lustre/fsw/portfolios/llmservice/users/uahmed/test_env/lib/python3.10/site-packages/dask/base.py", line 665, in compute
    results = schedule(dsk, keys, **kwargs)
  File "/lustre/fsw/portfolios/llmservice/users/uahmed/test_env/lib/python3.10/site-packages/distributed/protocol/serialize.py", line 379, in serialize
    raise TypeError(msg, str_x) from exc
TypeError: ('Could not serialize object of type HighLevelGraph', '<ToPickle: HighLevelGraph with 4 layers.\n<dask.highlevelgraph.HighLevelGraph object at 0x15522cf81900>\n 0. read-parquet-2f062a30cf4676cd0b9a4ab5cf06fe85\n 1. repartition-2-aa356a5cb4dedecfbdd625f941566718\n 2. to-parquet-03d4d012cafd9ed3bdb4ee7374761cf1\n 3. store-to-parquet-03d4d012cafd9ed3bdb4ee7374761cf1\n>')

Also , CC: @sarahyurick for suggestions .

Also @uahmed93, I was wondering if I could test this PR myself by downloading the model files at https://huggingface.co/ai4bharat/indictrans2-en-indic-1B? Or should I be using something else?

Thanks @VibhuJawa  and @sarahyurick for detailed analysis. I have now added get_model_output function in Model class to handle postprocessing of outputs as suggested by @VibhuJawa .
I have run black for formatting now.

@sarahyurick  that is hf model. CT2 model can be downloaded from here Base En-indic model.
After downloading you need to unzip and there will be ct2_fp16 model. That model path need to be provided.

Hi, @VibhuJawa  @sarahyurick
Sorry was doing some other priority task due to which I could not handle the reviews immediately.
I have added test case here and corrected some suggestions. can please review them?.

Here:
Deployed LocalCUDACluster(22f3d4fd, 'tcp://<IP_ADDRESS>:37693', workers=1, threads=1, memory=1.79 TiB)...
2024-09-11 10:56:33,005 - distributed.protocol.pickle - ERROR - Failed to serialize <ToPickle: HighLevelGraph with 4 layers.
<dask.highlevelgraph.HighLevelGraph object at 0x15522cf81900>
 0. read-parquet-2f062a30cf4676cd0b9a4ab5cf06fe85
 1. repartition-2-aa356a5cb4dedecfbdd625f941566718
 2. to-parquet-03d4d012cafd9ed3bdb4ee7374761cf1
 3. store-to-parquet-03d4d012cafd9ed3bdb4ee7374761cf1
>.
Traceback (most recent call last):
  File "/lustre/fsw/portfolios/llmservice/users/uahmed/test_env/lib/python3.10/site-packages/distributed/protocol/pickle.py", line 63, in dumps
    result = pickle.dumps(x, **dump_kwargs)
AttributeError: Can't pickle local object 'to_parquet.<locals>.<lambda>'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/lustre/fsw/portfolios/llmservice/users/uahmed/test_env/lib/python3.10/site-packages/distributed/protocol/pickle.py", line 68, in dumps
    pickler.dump(x)
AttributeError: Can't pickle local object 'to_parquet.<locals>.<lambda>'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/lustre/fsw/portfolios/llmservice/users/uahmed/test_env/lib/python3.10/site-packages/distributed/protocol/pickle.py", line 81, in dumps
    result = cloudpickle.dumps(x, **dump_kwargs)
  File "/lustre/fsw/portfolios/llmservice/users/uahmed/test_env/lib/python3.10/site-packages/cloudpickle/cloudpickle.py", line 1479, in dumps
    cp.dump(obj)
  File "/lustre/fsw/portfolios/llmservice/users/uahmed/test_env/lib/python3.10/site-packages/cloudpickle/cloudpickle.py", line 1245, in dump
    return super().dump(obj)
TypeError: cannot pickle 'ctranslate2._ext.Translator' object
Traceback (most recent call last):
  File "/lustre/fsw/portfolios/llmservice/users/uahmed/test_env/lib/python3.10/site-packages/distributed/protocol/pickle.py", line 63, in dumps
    result = pickle.dumps(x, **dump_kwargs)
AttributeError: Can't pickle local object 'to_parquet.<locals>.<lambda>'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/lustre/fsw/portfolios/llmservice/users/uahmed/test_env/lib/python3.10/site-packages/distributed/protocol/pickle.py", line 68, in dumps
    pickler.dump(x)
AttributeError: Can't pickle local object 'to_parquet.<locals>.<lambda>'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/lustre/fsw/portfolios/llmservice/users/uahmed/test_env/lib/python3.10/site-packages/distributed/protocol/serialize.py", line 353, in serialize
    header, frames = dumps(x, context=context) if wants_context else dumps(x)
  File "/lustre/fsw/portfolios/llmservice/users/uahmed/test_env/lib/python3.10/site-packages/distributed/protocol/serialize.py", line 76, in pickle_dumps
    frames[0] = pickle.dumps(
  File "/lustre/fsw/portfolios/llmservice/users/uahmed/test_env/lib/python3.10/site-packages/distributed/protocol/pickle.py", line 81, in dumps
    result = cloudpickle.dumps(x, **dump_kwargs)
  File "/lustre/fsw/portfolios/llmservice/users/uahmed/test_env/lib/python3.10/site-packages/cloudpickle/cloudpickle.py", line 1479, in dumps
    cp.dump(obj)
  File "/lustre/fsw/portfolios/llmservice/users/uahmed/test_env/lib/python3.10/site-packages/cloudpickle/cloudpickle.py", line 1245, in dump
    return super().dump(obj)
TypeError: cannot pickle 'ctranslate2._ext.Translator' object

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/lustre/fsw/portfolios/llmservice/users/uahmed/ctransl/ctransl_cf.py", line 145, in <module>
    main()
  File "/lustre/fsw/portfolios/llmservice/users/uahmed/ctransl/ctransl_cf.py", line 141, in main
    outputs.to_parquet(args.output_parquet_path)
  File "/lustre/fsw/portfolios/llmservice/users/uahmed/test_env/lib/python3.10/site-packages/nvtx/nvtx.py", line 116, in inner
    result = func(*args, **kwargs)
  File "/lustre/fsw/portfolios/llmservice/users/uahmed/test_env/lib/python3.10/site-packages/dask_cudf/core.py", line 264, in to_parquet
    return to_parquet(self, path, *args, **kwargs)
  File "/lustre/fsw/portfolios/llmservice/users/uahmed/test_env/lib/python3.10/site-packages/dask/dataframe/io/parquet/core.py", line 1047, in to_parquet
    out = out.compute(**compute_kwargs)
  File "/lustre/fsw/portfolios/llmservice/users/uahmed/test_env/lib/python3.10/site-packages/dask/base.py", line 379, in compute
    (result,) = compute(self, traverse=False, **kwargs)
  File "/lustre/fsw/portfolios/llmservice/users/uahmed/test_env/lib/python3.10/site-packages/dask/base.py", line 665, in compute
    results = schedule(dsk, keys, **kwargs)
  File "/lustre/fsw/portfolios/llmservice/users/uahmed/test_env/lib/python3.10/site-packages/distributed/protocol/serialize.py", line 379, in serialize
    raise TypeError(msg, str_x) from exc
TypeError: ('Could not serialize object of type HighLevelGraph', '<ToPickle: HighLevelGraph with 4 layers.\n<dask.highlevelgraph.HighLevelGraph object at 0x15522cf81900>\n 0. read-parquet-2f062a30cf4676cd0b9a4ab5cf06fe85\n 1. repartition-2-aa356a5cb4dedecfbdd625f941566718\n 2. to-parquet-03d4d012cafd9ed3bdb4ee7374761cf1\n 3. store-to-parquet-03d4d012cafd9ed3bdb4ee7374761cf1\n>')

Resolved it.

/okay to test

@uahmed93 , Please fix linting issue.

/okay to test


parsing issue with new pubspec_parse

pub.package_graph: Bad state: Error while decoding entity (Unsupported value for `repository`.,
#0 new Pubspec.parse (package:pubspec_parse/src/pubspec.dart:139:7)
#1 new Pubspec (package:pub_dartlang_org/frontend/model_properties.dart:33:25)
#2 PubspecProperty.decodePrimitiveValue (package:pub_dartlang_org/frontend/model_properties.dart:157:18)
#3 _ModelDescription._decodeProperty (file:///root/.pub-cache/hosted/pub.dartlang.org/gcloud-0.6.0+1/lib/src/db/model_db_impl.dart:438:22)
#4 _ModelDescription.decodeEntity.<anonymous closure> (file:///root/.pub-cache/hosted/pub.dartlang.org/gcloud-0.6.0+1/lib/src/db/model_db_impl.dart:428:7)

Should be an error w/ pubspec_parse package?

I wanted to identify the core issue on pub site, but it seems that it is breaking the listing process, and I can't really identify the specific package that has the offending value.
@kevmoo: what are our options here? do we need to revert to using String or can we use a more permitting parsing (that returns a null rather an exception)? It would be bad if every time something is added to the pubspec_parse we would need to worry about broken behaviour on pub.

One of the values of pubspec_parse (in my opinion) is that is throws with
bad inputs – so users can fix them.
We could add a permissive parsing mode which just populates null, I
guess...
On Fri, Dec 28, 2018 at 1:31 PM István Soós<EMAIL_ADDRESS>wrote:

I wanted to identify the core issue on pub site, but it seems that it is
breaking the listing process, and I can't really identify the specific
package that has the offending value.
@kevmoo https://github.com/kevmoo: what are our options here? do we
need to revert to using String or can we use a more permitting parsing
(that returns a null rather an exception)? It would be bad if every time
something is added to the pubspec_parse we would need to worry about
broken behaviour on pub.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dart-lang/pub-dartlang-dart/issues/1898#issuecomment-450430556,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABCisEcxfRgMSWi4Savhl3yAKj87dK1ks5u9o2cgaJpZM4ZkJGC
.

One of the values of pubspec_parse (in my opinion) is that is throws with bad inputs – so users can fix them.

That is a great value at upload time, but not that great when we are re-reading the pubspec.yaml at a later point, when the rules are changed and now we are throwing on values that nobody can fix.

We could add a permissive parsing mode which just populates null, I guess...

Can we have two parsing there? One that has permissive mode with null populated values, and one for the upload-time strict checks that will throw when invalid value is provided?

Only one package has the parsing issue in staging: angular2_authentication_sample, with the following value:
"repository": {
  "url":"https://github.com/rwl/angular2-authentication-sample.git",
  "type":"git"
}

@jonasfj any preference on how to go ahead with this? A parse workaround is possible on pub site (until pubspec_parse has a new version), however, I think the more important question is how we want to have such semi-breaking changes handled going forward.

hmm... maybe pubspec.yaml should be versioned. I'm not actually suggesting that we do this :)
We could rely on the sdk version... but this is not a can of worms I'm looking to open.
I agree that we a permissive parsing mode seems like a good solution.
Or maybe we could forbid the presence of undefined properties in pubspec.yaml (https://github.com/dart-lang/pubspec_parse/issues/34).
That would prevent this sort of thing from happening in the future, right?
We could then scan all published packages and remove all undefined properties. Including the newly added properties such as flutter, issue_tracker, publish_to, and repository, as none of the currently published packages should have been able to define these.

Okay, I see it would definitely be a bad idea to remove usages of the flutter property :)
But would it not be fair to require that new properties be officially approved, documented and supported in pubspec_parse, before we allow packages using these properties to be uploaded to pub.dartlang.org?
If we wanted the flexibility of being able to experiment with properties, I suggest that we allow a custom property to contain arbitrary sub-properties, and serve as an experimental playground for new properties or custom properties introduced in pubspec.yaml. However, in general it seems most other things in the eco-system uses a separate yaml file for analyzer options, build_runner, etc.
Otherwise, it seems likely that any changes to the pubspec.yaml format will cause breaking surprises for people.

Here is the statistics from staging, keys used in pubspec.yaml and their counts:
name: 38464
version: 38464
description: 38464
homepage: 38452

author: 32377
authors: 6087
maintainer: 46
email: 45
uploader: 1

environment: 29058
environnment: 39
sdk: 15
enviroent: 9
language: 6

dependencies: 32667
dev_dependencies: 26181
dependency_overrides: 569
dev-dependencies: 56
test_dependencies: 15
dev_dependency_overrides: 14
devDependencies: 9
dev_dependency: 8
dependecies: 1

documentation: 4268
repository: 7
bugs: 1

flutter: 4457

transformers: 3445
dev_transformers: 2

executables: 2063
executable: 10
bin: 1
excutable: 1
scripts: 5

license: 8

web: 154

collection: 38

changelogname: 18

publish_to: 54

refit_http: 1

analyzer: 31

ghooks: 1

linter: 21
jaguar_http: 5
github: 1
plugin: 2
strong-mode: 7

Some strange parsing happened, because the tool also reported keys like //  complex, I've removed those from the above.

But would it not be fair to require that new properties be officially approved, documented and supported in pubspec_parse, before we allow packages using these properties to be uploaded to pub.dartlang.org?

That's also a synchronisation problem:

as everything happens in the open, people will be eager to set properties before they got finalized, or
pub.dartlang.org may slightly lag behind (or accepting it upfront) in contrast to the official "timestamp of approval".

I'd rather see a process that is clear about what could be wrong, but it is self-correcting. For example if somebody uses an unknown key in pubspec.yaml:

pub publish should warn about them.
pana should add a penalty and lower the maintenance score if they are used.

As pana and pub site goes up-to-date following a new property, the penalty can go away.

However, the above still don't address the issue at hand: the current pubspec_parse version breaks the site, and we should address that and other future changes. E.g. flutter: property may be untyped now, may become typed, using the then-current Flutter config structure, but that may be different from past-published structures, and parsing it could also fail.

pub publish (and pub's upload flow) requires strict mode, that's the main point.
pana is fine with strict mode, because it is aiming to accept the latest standards.
however, accessing the historical data doesn't work well with strict mode, we need a lenient mode (or should do the parsing ourselves).


[Question] Do turbo streams multiplex?

Do turbo streams case on headers to multiplex into different channels that can be subscribed to?

Not sure I fully understand the question, but with the turbo-rails integration that sends streams over a websocket, it's using a single websocket connection and sends multiple streams over it. If that doesn't answer the question, https://discuss.hotwire.dev is a good place to continue exploring it.


Test for message broadcast to the right number of peers

Motivation
As part of https://github.com/ZcashFoundation/zebra/issues/3229 we want to check that broadcasts are sent to the right number of peers.
Solution
Create a prop test that will produce a random number of total peers, make sure the message is sent only to half(rounded up) number of peers of the peer set.
Review
Anyone can review but i think @teor2345 is the only suitable candidate that will be around in the short term.

I merged the main branch to check why the Google Cloud test failed. Feel free to force-push over it.


webm/theora/yuv2rgb/libsimplewebm: Fix colour issues I could find.

Modifies yuv2rgb to remove endian-dependency in one of the functions, correctly orders RGBA, and deduplicates the macros.
The Theora and WEBM video players, rather than using reordered UV inputs to fix the yuv2rgb issue (which produces some distortion), now use the correct YUV order, since yuv2rgb is outputting correctly.
Modifies libsimplewebm to output RGBA so it can support the full range of RGBA formats in future.
libsimplewebm is now dependent on yuv2rgb as a result.
NOTE: This is by no means a complete solution for all WEBM formats.
The library is still limited to planar formats.
The following test project contains the WEBM and Theora files I made for testing.
They display correctly in VLC, so I am assuming they are correct.
VideoColourLab.zip
It'd be a good idea to test this on more WEBM files before continuing.
Additional note: The side effects shown when U/V gets swapped suggests issue 18208 may be caused by this, but don't rely on it.
Here's the screenshots from v3.1-beta4, Arch Linux x86_64:

(To my knowledge, master looks the same. This PR shows them all correctly, but of course that's my own test-cases, so please do test with more WEBMs.)

We usually do not modify thirparty libraries, and when we do, it is via patches or carefully delimited area.
I would suggest you to propose the changes upstream first, and see if they could be merged there instead.

CC @zaps166

Ah, thank you. I'm a bit worried about upstream because the changes needed for handling the various different VP9 modes (including, say, the RGBA modes) essentially mean that libsimplewebm has to output RGBA for consistency between all the different flavours of VP9, which of course breaks API compatibility. It also means yuv2rgb becomes a dependency of libsimplewebm, at least the way I've set things up; I feel it'd be better if yuv2rgb was treated as shared code between both to reduce duplication, but that has other potential problems...
An alternate route would be for me to undo the RGBA pipeline stuff, so libsimplewebm isn't changed as much or at all.
This said in turn, yuv2rgb is also altered by these changes. I do not know how pushing that upstream is going to work...

With upstream now containing the necessary feature, should I have a separate PR for the thirdparty update, or should I perform it as part of this one?

You can use this PR directly by rebasing it. Maybe make a first commit with only the sync from upstream (also update the hash documented in thirdparty/README.md), and a second commit with the remaining changes.

It appears 'OpusVorbisDecoder::getPCMF' is a function that for some reason has been removed or was not contributed to libsimplewebm...?

@20kdc
IIRC OpusVorbisDecoder::getPCMF was not contributed to libsimplewebm.

...Ok, so... getting the resulting diff shows there's a lot of unmarked changes. Biggest is that it looks like the libwebm usage within libsimplewebm was updated in the Godot version.
There's the addition of std::no_throw in various places, as well.
--- a/libwebm/README.libvpx
+++ b/libwebm/README.libvpx
@@ -1,5 +1,5 @@
 URL: https://chromium.googlesource.com/webm/libwebm
-Version: 32d5ac49414a8914ec1e1f285f3f927c6e8ec29d
+Version: d7c62173ff6b4a5e0a2f86683a5b67db98cf09bf
 License: BSD
 License File: LICENSE.txt

The current state of this is that I didn't sync the libwebm part, as it appears to have been updated separately by e71f1099 and 7c0da764.
The main contents of libsimplewebm have been synced with Godot-local changes marked.

...force-pushed again in line with the clang-format checker.

So, er... should I do another rebase to keep up, or... I've lost track of what next to do here.

@akien-mga can you tell me if this pull request will be merged into the master branch or not.
in my opinion the vp8/theora implementation currently in godot 3.1 is worthless, because colors are not reproduced correctly. as far as i can see, the patch from 20kdc successfully fixes the colors, and thats the way it should be.

Thanks!


feature request: filters to pan command like --filter, etc

Would be nice to have support for wildcard in the filter, like pan --filter=btn-* would return all results starting with btn-.

@nunomaduro this can be closed.


Waveform selecting dynamically created object

I have a div that is dynamically created that is using jQuery and I am trying to use Wavesurfer.js which requires the element to be selected using document.querySelector. Since the elements are dynamically created using jQuery, the selector does not recognise the elements.
$( document ).ready(function() {
    $("#audio").append('

');

    $('#audio').on('DOMNodeInserted', 'div', function () {
    var id = 6;
    window['waveForm' + id] = Object.create(WaveSurfer);

    window['waveForm' + id].init({
        container: document.querySelector('wave' + id),
        waveColor: 'violet',
        progressColor: 'purple'
    });

    window['waveForm' + id].on('ready', function () {
        window['waveForm' + id].play();
    });

    window['waveForm' + id].load(id + '.mp3');
});

This is my code so far. id is assigned by jQuery when dynamically creating the elements.
The error I am getting: Uncaught Error: Container element not found

It should be document.querySelector('#wave' + id). In future, please use StackOverflow for this kind of questions.

I tried your suggestion but still get the same error. I posted my question also on StackOverflow and received this answer: http://stackoverflow.com/a/32293351/4705339. I couldn't run it on JSFiddle so I tried to run it on my local machine. Now, I receive no errors and the div is created but the waveform itself does not load.


Use {{projectName}} as BINARY_NAME and runner's CMake project name in UWP template

Up to now in UWP template, app name and window title is always app and runner's CMake project name is always runner, but this settings is different from those in win32 template.
This PR replace app and runner with {{projectName}} in runner root's CMakeLists.txt in UWP template, and make BINARY_NAME and CMake project name the same as one in win32 template.
This PR changes msix file name, exe name in msix too.
It seems no related issue.
No changes in flutter/tests.
Pre-launch Checklist

[X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[X] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
[X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[X] I signed the [CLA].
[X] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
[ ] All existing and new tests are passing.

@cbracken is this a reasonable change?

I'm sorry, I mistaken windows and winuwp dir for windows/runner and winuwp/runner_uwp in this description. I'll replace them.