How do I "remove" a session?

There is a comment hinting at some way to do that:
----------------------------------------------------------------------------
-- Add/remove session

-- | Add cookie header to response. The function can throw the same
-- exceptions as 'encryptSession'.
addSession

but no corresponding function.

Hey @abailly,
I'm currently using removeSession but struggle with it. Do you have a code sample to see how you integrate it in a Servant app ?

Hello,
Here is a place where I use it in my code:
doLogout :: AuthCookieSettings -> UserAccount -> m ()
doLogout settings _ = lift (removeSession settings ())

It's very simple actually... The tricky part is to understand where the session comes from.

@abailly Thanks for your reply !
My api is defined like this
"api" :> "logout" :> AuthProtect "cookie-auth" :> Get '[JSON] (Headers '[Header "Set-Cookie" ByteString] ())

And for the moment the handler looks like yours : logoutServer _ = removeSession settings ()
Though, I've got this error :
No instance for (ToHttpApiData ByteString)
        arising from a use of ‘removeSession’

And I don't quite understand where the problem is 🤔

I have similar code and it works like a charm, except the action is POST and not a GET. For each AuthProtect a you have to define which type is computed by type family AuthServerData, e.g. :
type instance AuthServerData (AuthProtect "cookie-auth") =  X

it might be that X leads to some type which requires implementation of ToHttpApiData ?

I was inspired by what's in the example/ folder so I didn't had to write type instance AuthServerData ... until now.
Here is the code if you have the time to take a quick look (sorry it's a bit drafty...)

It compiles OK here... Might be a version problem?

7.10
--
Arnaud Bailly
twitter: abailly
skype: arnaud-bailly
linkedin: http://fr.linkedin.com/in/arnaudbailly/
On Fri, Jan 13, 2017 at 10:30 PM, Thomas Crevoisier <
<EMAIL_ADDRESS>wrote:

Arf, damned >.< Which resolver are you using ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/zohl/servant-auth-cookie/issues/22#issuecomment-272455751,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AACdHTOYf6-Io_P1grZVS-q9343BGgduks5rR4qCgaJpZM4K8OI8
.

Do you point directly to the github repo of servant-auth-cookie ? I don't find the version 4.2 in this snapshot

hmm, yes.
--
Arnaud Bailly
twitter: abailly
skype: arnaud-bailly
linkedin: http://fr.linkedin.com/in/arnaudbailly/
On Fri, Jan 13, 2017 at 10:36 PM, Thomas Crevoisier <
<EMAIL_ADDRESS>wrote:

Do you point directly to the github repo of servant-auth-cookie ? I don't
find the version 4.2 in this snapshot
https://www.stackage.org/haddock/lts-7.10/servant-auth-cookie-0.3.2/Servant-Server-Experimental-Auth-Cookie.html
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/zohl/servant-auth-cookie/issues/22#issuecomment-272457058,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AACdHTTfrWLoiz0LQSHsV7AE0aZvrQOuks5rR4vXgaJpZM4K8OI8
.

Could you share your stack.yaml please ? ^^

It's really simple:
resolver: lts-7.10
packages:

'assets'

temporary reference to 3rdpaerty libraries
TODO remove once library is published

servant-auth-cookie
system-extra
hdo

propellor needs patching to handle remote execution without local
commits

propellor
extra-deps:
hjson-1.3.2
http-client-<IP_ADDRESS>

I think the problem comes from the version: I use a version from my fork
as a submodule and it is not uptodate with HEAD.
--
Arnaud Bailly
twitter: abailly
skype: arnaud-bailly
linkedin: http://fr.linkedin.com/in/arnaudbailly/
On Fri, Jan 13, 2017 at 11:06 PM, Thomas Crevoisier <
<EMAIL_ADDRESS>wrote:

Could you share your stack.yaml please ? ^^
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/zohl/servant-auth-cookie/issues/22#issuecomment-272464668,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AACdHTZ28gf1YjEPvZUY60Zp93e8zdzwks5rR5L9gaJpZM4K8OI8
.


Is there an Html/JavaScript Client Demo?

I have an uaa identity server configured and running with several spring boot clients authenticating against it. Now I would like to have an Html/JavaScript Client authenticating against it. I can get the code but when I try getting the token it will throw a 400 / Invalid Grant / Redirect URI Mismatch. So was wandering if you have an Html/JavaScript client demo that I could use to see what I'm missing...

Please refer to : https://github.com/cloudfoundry/uaa-singular


Performance issues in production with<EMAIL_ADDRESS>

OS:

[ ]  Windows
[x]  MacOS
[ ]  Linux

Platform:

[x]  iOS
[ ]  Android

I have some performance issues (app very slow and freeze) using<EMAIL_ADDRESS>release mode.
I tested each version of react-native-sentry on an iPhone 7 iOS 10.3.3.

<EMAIL_ADDRESS>until 0.23.0 => Performance issues
<EMAIL_ADDRESS>=> Work well

It is weird because:

In debug mode, everything works. (Simulator & iPhone)
On simulator, everything works. (release & debug mode / each versions of sentry since 0.14.16)
On external device (iPhone 7): performance issue with 0.15.0+ but good with 0.14.6

I read the commits between 0.14.16 and 0.15.0 and nothing looks weird.
Do you have any tips or idea about this bug ?
I'll investigate more and come back if i find something.
Thanks.

Are you using react-navigation?
Because this should be fixed with the latest release 0.23.0
https://github.com/getsentry/react-native-sentry/issues/158
You can also try to do this:
https://github.com/getsentry/react-native-sentry/issues/158#issuecomment-316619835

Yes i'm using react-navigation.
I tried and it works by adding deactivateStacktraceMerging: true in Sentry.config().
Thank you !

Ok, still the issue should be resolved with the latest version 0.23.0 many people also confirmed that.
Please make sure to delete your node_modules folder, make a clean build in Xcode and try it again.

My bad, i don't use react-navigation but the Navigator used by react-native (which is deprecated now). Everything seems ok now.


JSDoc @link not resolved across modules

Bug Report
While verifying https://github.com/microsoft/vscode/issues/119357
🔎 Search Terms

link
export
modules

🕗 Version & Regression Information

I was unable to test this on prior versions because it did not previously exist

⏯ Playground Link
Workbench Repro
💻 Code
// @filename: a.ts
import { Model } from './b';

/**
 * {@link Model}
 */

// @filename: b.ts
export class Model {}

🙁 Actual behavior
@link Model is not clickable
🙂 Expected behavior
I expected to be able to click on @link Model

Actually, this may be wrong -- the workbench seems like it might be slightly buggy. I do see to get this but only if I import the referenced module. However, with the compiler flag disallowed unused locals, this produces a warning.
Maybe the fix for that would be to mark linked types as "Used". C# does that in their xml docs.

After discussing this with @orta, we switched our opinions. Now I think that expanding the scope to all identifiers is the right call and he doesn't. However: it would be difficult to decide on the precise semantics and difficult to implement efficiently, so I don't think it's worthwhile right now.
What should work is import references: import('./b').Model. I don't think that @link even parses this reference right now.

I'd lean towards solving this one by treating imports that are referenced in a @link as used variables so that @typescript-eslint/no-unused-vars doesn't complain. This way the developer can just import variables for links like normal, so they only need to know one mechanism for importing variables.
And then for extra credit, to make the experience even more consistent between @link and normal references:

Report an error for @link references that can't be resolved
Support a quick-fix to auto-import types / variables referenced from a @link.  Ie If I have/** {@link Foo} */

Then Foo has a quick fix to import Foo.


Adding/loading bookmarks doesn't work correctly with custom domain

          > With commit [d485055](https://github.com/goniszewski/grimoire/commit/d485055081a5d191a6782a3363e13c8dce8cc97b) I was successful in launching the app via `docker compose up` for external IP, domain as well as simply local deployment. Moreover, this commit fixes an issue with invalid URLs for files stored by PocketBase.

I hope it will work for you guys just fine this time. Please inform me if that's the case, or if there are any issues or questions related to new/updated environment variables. And also, please accept my apologies for this mess!

It worked for me, but there are still a few issues I observe.

After creating a user, I get a 500 error one single time with the same TypeError: Cannot read properties of null (reading 'id') error. But after refreshing I'm logged in.

Adding a new bookmark just freezes after the spinning circle to grab the meta data. I can, however, press enter again at the URL box to save it.

Saving the bookmark does not add the bookmark to the bookmarks page automatically. I had to manually refresh again to see it appear.

The new bookmark has no meta data, only the URL and HTML code is saved. Images, titles etc are not saved, this is presumably due to error number 2.

Originally posted by @maya329 in https://github.com/goniszewski/grimoire/issues/12#issuecomment-1830138881

First problem is now resolved, but the rest probably not.
I have also seen an issue where some URL, even after successfully loading its metadata, couldn't be saved. It may be related somehow (need further investigation).

With the latest changes, related issues should be resolved. If that's not the case, new, more detailed issues should be created.


Update: added new command (!version)

The print command of the current version, I think this is one of the most basic commands that should be here

I really like this addition! However, I think that the the subprocess command may not work in some cases. For example if a user is not in a venv, then subprocess could fail since it would need to call 'pip3 show gpterminator' instead.

Perhaps we could use the version attribute instead? (I have never before)

Got you, wait for hot fixes


Programmatic options passed to register are always ignored.

Due to the below if condition, introduced in #694, if options are passed to register programmatically (e.g. register({ ...customOptions })), they will be ignored in favor of either the results from readDefaultTsConfig or options gathered directly by swc from a nearby .swcrc file when process.env.SWCRC = 'true'.
https://github.com/swc-project/swc-node/blob/ba8f60db2106a84ee02b79a8b0b71ae8e1e43069/packages/register/register.ts#L108-L110
In cases where SWCRC is not true (unset, etc.), the configuration returned from readDefaultTsConfig is taken even if options are passed to register, meaning the passed options are altogether ignored.
I believe in this specific circumstance, the intuition would be for options passed to register to be used $iif$ they were given && !process.env.SWCRC.
Unless I am totally off-base here, I think the body of the if can be changed to (or something similar):
if (!process.env.SWCRC) {
   options = Object.keys(options).length ? options : readDefaultTsConfig()
}

Where when process.env.SWCRC is falsy, we prefer any programmatically specified options before trying to read a tsconfig.json file. With this, I think the scenario above should be accounted for appropriately, while also not breaking what was fixed in #694.

For anyone running into this currently, using patch-package with the below diff, I was able to quickly fix this for 1.6.6
diff --git<EMAIL_ADDRESS><EMAIL_ADDRESS>index 7d4cfd8..1a8eab1 100644
---<EMAIL_ADDRESS>+++<EMAIL_ADDRESS>@@ -88,7 +88,7 @@ function compile(sourcecode, filename, options, async = false) {
 exports.compile = compile;
 function register(options = {}, hookOpts = {}) {
     if (!process.env.SWCRC) {
-        options = (0, read_default_tsconfig_1.readDefaultTsConfig)();
+        options = Object.keys(options).length ? options : (0, read_default_tsconfig_1.readDefaultTsConfig)();
     }
     options.module = ts.ModuleKind.CommonJS;
     (0, sourcemap_support_1.installSourceMapSupport)();

A more detailed and interactive reproduction can be seen here.

Thank you so much. This patch allows me to update past 1.5.4

With the recent updates to @swc-node/core, assuming your @swc-node/register dependency is still pinned to 1.6.6, here is the new patch to keep everything working:
diff --git<EMAIL_ADDRESS><EMAIL_ADDRESS>index fb48a43..de18175 100644
---<EMAIL_ADDRESS>+++<EMAIL_ADDRESS>@@ -139,6 +139,7 @@ function tsCompilerOptionsToSwcConfig(options, filename) {
                 useBuiltins: true,
             }
             : undefined,
+        baseUrl: path_1.resolve(options.baseUrl ?? './'),
         paths: Object.fromEntries(Object.entries((_h = options.paths) !== null && _h !== void 0 ? _h : {}).map(([aliasKey, aliasPaths]) => {
             var _a;
             return [
diff --git<EMAIL_ADDRESS><EMAIL_ADDRESS>index 7d4cfd8..51adf8a 100644
---<EMAIL_ADDRESS>+++<EMAIL_ADDRESS>@@ -88,7 +88,7 @@ function compile(sourcecode, filename, options, async = false) {
 exports.compile = compile;
 function register(options = {}, hookOpts = {}) {
     if (!process.env.SWCRC) {
-        options = (0, read_default_tsconfig_1.readDefaultTsConfig)();
+        options = Object.keys(options).length ? options : (0, read_default_tsconfig_1.readDefaultTsConfig)();
     }
     options.module = ts.ModuleKind.CommonJS;
     (0, sourcemap_support_1.installSourceMapSupport)();

I have opened #725 to address this issue. @Brooooooklyn please take a look when you can.


Custom App

I am using custom app, I am registering the same.
I need to add the same in Option Panel. How can I do it?

Ye exactly for iOS

I had implemented it our flat project. You can see the code in this link.
https://github.com/netless-io/flat-iOS/blob/f46fcc918668a79e5fa1abbee71824eca0b38ca7/Flat/Modules/ClassRoom/ClassroomFastboard/FastboardViewController.swift#L277
It only works for iPad. If you want to support iPhone, you should update CompactFastRoomOverlay.customOperationPanel.
Feel free to ask further questions!

Hey! Tried it in the phone, its giving me the above error.

Sorry, I forgot that the customOperationPanel is only valid for iPad overlay.
It's not configurable because iPhone has a little screen space.
What about you just add your custom button to your view by yourself.
If you want to align it to the default operation panel, you can use overlay.operationPanel.view to access the default operation view and made your own view constraints.
Here is an example:
      fastRoom.joinRoom { _ in
            if let overlay = fastRoomView.overlay as? CompactFastRoomOverlay {
                let button = UIButton(type: .infoLight)
                self.view.addSubview(button)
                button.snp.makeConstraints { make in
                    make.left.equalTo(overlay.operationPanel.view!)
                    make.top.equalTo(overlay.operationPanel.view!.snp.bottom)
                }
            }
        }

Remind to add your button after join room succeed.
Hope the above helps you. @sheetal2795


Android Basics: lists

https://developer.android.com/codelabs/basic-android-kotlin-training-lists?return=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-kotlin-unit-2-pathway-2%23codelab-https%3A%2F%2Fdeveloper.android.com%2Fcodelabs%2Fbasic-android-kotlin-training-lists#4
Vegetables(listOf("cabbage", "sprouts", "onion")))

There is a residual parentheses at the end of the line of code above
It should be
Vegetables(listOf("cabbage", "sprouts", "onion"))

@hanzhere
Thank you so much for reporting this issue. This is fixed and will be published soon.


cmd/go: be more forgiving with matching names for help

The go help output for topics is mostly good, but guessing how to spell the name of a particular topic can be difficult due to a combination of inconsistencies in the names matched, rigidity in the matching, and little assistance except asking for the full list. For example, is it singular (go help testflag) or plural (go help modules)? Is it hyphenated (go help module-get (not modules-get!)) or not (go help buildmode)?
The output for commands is less troubled, as it is quicker to access the list and the rules just match the commands, which are short and a little bit consistent already. But even here, I had to look at the list again today, as the command is called "work" but the feature is always called "workspaces".
I suggest the matching algorithm be  relaxed. I don't have a particular preference about the mechanism, but it could be as simple as having multiple names for a given command or topic (work, workspace, workspaces), using a prefix-driven algorithm, or some edit distance thing. In practice I find the last form steps too far from the goal, so the one of first two approaches would be my choice, but really anything less rigid would be an improvement.
This sort of thing is a common courtesy honored by many programs in the world. The go command could strive to be more accommodating.

Perhaps some sort of "most similar command" output, like git?
$ git lol
git: 'lol' is not a git command. See 'git --help'.

The most similar command is
	log

That's what I was referring to as the less preferred option, as it cast too wide a net. To go from 'stat' to 'stash', as in your example, is not helpful, and with git I often see much worse suggestions when I mistype something, It's actually pretty terrible. Real example:
% git foo
git: 'foo' is not a git command. See 'git --help'.

The most similar commands are
	gofmt
	log
%

In the not-so-long term, the plan is to move the essays out of 'go help' entirely, so that you can 'go help ' and that's it.
In terms of git, right now go help is too much like 'git log --help' and not enough like 'git log -h'.


IE not working

I know I am a pain..   :-)
I cant get the console to work in IE.  I go to the vsphere web interface and can open the console from IE fine.  I try to run from webcommander and I get a blank screen..

and this error when I close the window..

Not only this one. I couldn't even get some basic CSS or JS features work in IE.
Considering Edge works well and Firefox / Chrome could all be installed on Windows, I won't spend much efforts to support IE. Sorry.


Consider Monaco for the Code Editor

https://microsoft.github.io/monaco-editor/

Coded with commit fb1cc0f3d8bd566897ba07efbeb1f51760a8341a
I used blazaco nuget package


README: add instructions for testing changes locally

This was helpful for https://github.com/Koenkk/zigbee-herdsman-converters/pull/4834 and https://github.com/Koenkk/zigbee-herdsman-converters/pull/4813

Many thanks!


[improve][broker] Make topic policies service pluggable

(WIP)
Documentation

[x] doc
[ ] doc-required
[ ] doc-not-needed
[ ] doc-complete

TODO: fix the following tests

[ ] testTlsHostVerificationProxyToBroker and other tests in ProxyWithAuthorizationTest
[ ] ClusterMetadataTearDownTest.testDeleteCluster
[ ] GeoReplicationTest.testTopicReplication


OS default theme is a little bit weird

OS Mode

Light Mode

Dark Mode

Hello, thank you for your issue.
I can see two differences in the pictures.

Scrollbar color
Different colors in the code block

You are right, the standard code block is not optimal in terms of colors. Do you see any other problems or is the issue related to this one?
Thank you, best regards Julian

Closed because no answer.
Please open again if the bug still persists


Add function to make loading har files easier

Added Features

Add load_file to add a simpler way to create HarParser objects.
Also adds load_json to load JSON as HarParser objects

[X] Released Need. Thinking 2.1.0

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

9 of 9 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.009%) to 99.34%

Totals

Change from base Build<PHONE_NUMBER>:
0.009%

Covered Lines:
602

Relevant Lines:
606

💛  - Coveralls

Great idea! Is it worth considering making these class methods? It might make the interface cleaner, think:
parser = HarParser.from_file('file.har')

That makes more sense. Changed to that


Gymnasium Waldstraße, Germany

Gymnasium Waldstraße, Germany

@OGirnth First stage of verification passed, official domain is gywa.de as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@OGirnth Thank you for your patience while waiting for a review and processing your request. Pull request merged.


backport PR 27296 to v1.23: enable build with boringssl_fips in contrib

Commit Message:
backport PR 27296: enable build with boringssl_fips in contrib
Additional Description:
Risk Level: Low
Testing: compiled locally and run the image
Docs Changes: no
Release Notes: no
Platform Specific Features: no

/retest


Support Dank Memes in Notes

Is your feature request related to a problem? Please describe.
Communication richness is increasing with the ubiquity of chat tools, social media integrations, and unprecedented levels of arguments about pronouncing .gif. The tools we use to annotate and comment on our favorite projects should also support our favorite memes.
Describe the solution you'd like
Create a basic integration for giphy or another service that allows for the searching and posting of dank memes as a part of comments and annotations.
Describe alternatives you've considered
Slack works reasonably well at being able to react to links to Storybook. However, it doesn't support giphy in threads, and honestly, Storybook should try to own this part of the ecosystem internally rather than relying on integrated tooling.
Are you able to assist bring the feature to reality?
Unfortunately, no. I just think it would be cool.

IMO, it's a very important feature. I would say having memes in Storybook is vital for this project, however, we have some less important stuff to finish before, therefore I will mark this as a "good first issue".


docs(sub-patterns): migrate to React DocGen comments

Related Ticket(s)
Refs #2422.
Description
This change migrates JSDoc comments to React DocGen comments for components in packages/react/src/patterns/sub-patterns.
Also:

Tried to make some prop type definitions more detailed, e.g. usage of PropTypes.oneOf() instead of PropTypes.string and usage of PropTypes.shape() instead of PropTypes.object() so that the components can catch more of prop type errors.
Fixed some stale prop type settings.

Changelog
Changed

Migrated JSDoc to React DocGen comments for components in packages/react/src/patterns/sub-patterns.
Tried to make some prop type definitions more detailed, e.g. usage of PropTypes.oneOf() instead of PropTypes.string and usage of PropTypes.shape() instead of PropTypes.object() so that the components can catch more of prop type errors.
Fixed some stale prop type settings.

One thing I think this work is surfacing is the lack of defaultProps in a bunch of our patterns/components. We'll probably need to go back and doublecheck the specs and set those for the ones that are missing.

Great point @jeffchew - Any ideas on how we can best move forward with this...? Probably gathering the specs, reviewing them, and compare with the status quo of the code...?

One thing I think this work is surfacing is the lack of defaultProps in a bunch of our patterns/components. We'll probably need to go back and doublecheck the specs and set those for the ones that are missing.

Great point @jeffchew - Any ideas on how we can best move forward with this...? Probably gathering the specs, reviewing them, and compare with the status quo of the code...?

Most likely. The patterns especially should have corresponding functional specs we can refer to. For components though, we might need to make those determinations from the engineering side.


Enable Sourcegraph

I want to use Sourcegraph for XUPorter code search, browsing, and usage examples. Can an admin enable Sourcegraph for this repository? Just go to https://sourcegraph.com/github.com/onevcat/XUPorter. (It should only take 30 seconds.)
Thank you!

Enabled, but it says C# is not supported. So I wonder whether it could be used...


Abolish PeriodicTimer and determine the next time when something has to run

Currently, a periodic timer checks for next runs.
That is inefficient and opens a surface where jobs run too late (if the Interval is set to a high Timeout).
Instead an approach should be chosen, where the next run-date is calculated.
This should work for instant jobs as well!

Hi @linkdotnet, thanks for creating such a nice job scheduler.
I was investigating this a bit around this issue and something crossed my mind that I want to share with you.
Instead of using a background service to use the periodic timer for executing the next job we can define a timer for each job and do something like this.
Timer timer = new Timer(DoSomething, null, TimeSpan.Zero, TimeSpan.FromSeconds(10));

static void DoSomething(object? state)
{
    // This function will be executed when the timer elapses
    Console.WriteLine("Function executed at: " + DateTime.Now);
    // Call your desired function here
}

Hi @linkdotnet, thanks for creating such a nice job scheduler. I was investigating this a bit around this issue and something crossed my mind that I want to share with you. Instead of using a background service to use the periodic timer for executing the next job we can define a timer for each job and do something like this.
Timer timer = new Timer(DoSomething, null, TimeSpan.Zero, TimeSpan.FromSeconds(10));

static void DoSomething(object? state)
{
    // This function will be executed when the timer elapses
    Console.WriteLine("Function executed at: " + DateTime.Now);
    // Call your desired function here
}

First of all, thanks (again) for jumping in and the kind words.
I do like the timer idea a lot. It would even abolish the need for an isolation level (if I am not wrong here).
The only thing we might wanna keep in mind is that we might want to introduce maximal degree of parallelism. While I don’t expect that out of the box we need a way of tracking the status.
the periodic timer was convenient because you can always see it as kind of a snapshot to look what is going on.
I am currently on vacation so I can only give you ideas or gather ideas with you, if you are up to it.
to be honest that would be something to make it as a v1.
In either case - thanks for the kind words and feedback! Very nice idea

Just a question @Kamyab7  - do you wanna give it a shot and try?

I probably will give your idea a shot

Done. @Kamyab7 I settled on Task.Delay so, by default, we have Isolation.NewTask.
Therefore I could abolish that as well.

@linkdotnet Wow you are super fast I wish one day I would be able to write code as well as you do.

The rough draft is done - I did some refactoring before to make it easier for myself.
But thank you for the kind words, have to patch out some rough edges, maybe bringing IsolationLevel back


Portable install/runn

I have been using ZAP on BTC-LND and it works great;
I also have an LTC-LND installation and can not use ZAP for that as well, since only 1 install can be on Windows on any given time;
Please correct me if I am missing an install option!
Detailed Description
I am looking forward to a pre-compiled portable version of ZAP, which uses the local dir for storing all data to that session.
That will enable to use ZAP wallet for multiple LND connections on the same windows pc.
Context
I see ZAP currently as the only real useable wallet on lightning implementations;
making a portable install would enable it to support all lightning networks.

@P0u1us you just need to log out of the wallet. That will take you to the launchpad area where you can set up as many wallet connections as you like, including LTC wallets:

AAAHHHHHH... thnx!
sometimes it is right in your face ;-)
got it working now on both BTC/LND and LTC/LND
great product!

Awesome!

hmmm... after thought:
happy with that I can now switch between the seeing either wallet;
however, being able to keep both/all open and instantly see status would be even better ;)
The suggestion for a portable version would thus still benefit.
still think Zap outdelivers any other lightning wallet!

That's a fair comment @P0u1us . I'm actually currently working on some refactoring that will in the future make it possible for us to have multiple active simultaneous wallet connections ;)
I've retitled this request to make it more clear.


Remove MetaClass

Addresses #28.

Just for future reference, the swagger_server/messaging/message_queue_producer.py is not currently being used, we are currently using rpc_queue and topic_queue for communication between SDX LC and SDX controller, but it would be good to keep the message_queue, maybe for future BAPM implementation.


Add filters to Unreal log

Add filter to Unreal log with searching by log types (find log category in UE4 now is hell)

Added in UnrealLink 2020.2.61
Available in R4UE 2020.2.1


Create a contact info block

Add links to social networks (LinkedIn, Facebook, Instagram), phone number, email, Telegram username, etc.

Added my own social networks.


chore: Added example for how to build container images with different architectures

Description

Added an example to showcase how one could build a container image on a build machine which might have a different architecture.
Motivation and Context

I struggled to build a docker image using x86_64 architecture with this module when building container images from my local M1 Max mac machine until I found a workaround. #333
The example I am adding is said work around and could be useful to those who also struggled like myself.
Breaking Changes

How Has This Been Tested?

[ ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[ ] I have tested and validated these changes using one or more of the provided examples/* projects

[X] I have executed pre-commit run -a on my pull request

I have tested this example by deploying the example lambda function in my personal AWS account. Additional screenshots demonstrating a deployment can be referenced here #333

Thanks for the review @antonbabenko
I have done the changes you have requested and have tested the updated container-image example

Please let me know if there are any other additional changes that need to be made. Thanks.

Thank you @GonzalezAndrew !

This PR is included in version 4.0.1 :tada:


Initial polishing of ModelSystem

Test branch in electronic-parsers: test_basesections

Hi, these are the changes to be discussed in our meeting. The corresponding branch in nomad is 1728-full-refactoring-of-run-into-data.

Feel free to drop a review when you want / can. Focus on the model_system.py please; there is an associate branch for Wannier90 and the corresponding 1721 in Gitlab.

Feel free to drop a review when you want / can. Focus on the model_system.py please; there is an associate branch for Wannier90 and the corresponding 1721 in Gitlab.

I take it that this just an example of how the new schema may affect a parser, correct?
Or is the aim to have this merged asap as well?

Feel free to drop a review when you want / can. Focus on the model_system.py please; there is an associate branch for Wannier90 and the corresponding 1721 in Gitlab.

I take it that this just an example of how the new schema may affect a parser, correct? Or is the aim to have this merged asap as well?

This is just an example. I will use some parsers to develop the schema, but we will not merge anything.

The only problem with reviewing, is that we should (at least once) have the option of reviewing the code in its entirety.
The changes in this particular PR come across as mostly changes in terminology and (at first glance) will likely go through without a problem.
The feedback we were giving in the last meeting (Tuesday 30.01) is directed at older code on develop, though.
From what I could find (https://github.com/orgs/community/discussions/9099), there's no such feature in Github?

Cannot you add comments within old code then in a review process?

Ok, I changed the name of the file to model_system2.py. I think now it should be easier to review 🙂

Thanks a lot for the reviews! 😄
@ndaelman-hu should I wait for you to finish? I am just curious if you will continue with it or do you prefer me to start with some changes from your suggestions.

Thanks a lot for the reviews! 😄
@ndaelman-hu should I wait for you to finish? I am just curious if you will continue with it or do you prefer me to start with some changes from your suggestions.

@JosePizarro3 No, feel free to go ahead. I pretty much covered AtomicCell, the rest only partially.
Today, I likely won't get around to it, anyway, at best tomorrow. I can always add another review later on, but I think there's already enough, for now.

Hi @JFRudzinski @ndaelman-hu
I added new changes. I am requesting a final review once more. Bear in mind the TODOs, and feel free to resolve your suggestions if you feel satisfied.

@JosePizarro3 is there a branch or commit with the up-to-date base section definitions?
The one you posted at the head (https://gitlab.mpcdf.mpg.de/nomad-lab/nomad-FAIR/-/compare/develop...1728-full-refactoring-of-run-into-data) is missing Computation, among others...
Also consider my advice on the git issue, to move our base classes for the time being into this project.
These are subject to change, as we are still in the process of designing and as such we will keep them at the same version.

Ok, I am merging this after the last changes.
Thanks a lot for the feedback! I will be working in ModelMethod in a new branch, and then we can revisit this section ModelSystem. Probably along the way we can solve #5

@JosePizarro3 Could we take a look at the Gitlab branch before moving on to ModelSystem?
I raised some suggestions that will facilitate us adding testing and generally working all 3 on this project.

@JosePizarro3 Could we take a look at the Gitlab branch before moving on to ModelSystem? I raised some suggestions that will facilitate us adding testing and generally working all 3 on this project.

Yeah, the branch is in gitlab.


impl(pubsub): add span attributes to subscribe span

#13720

This change is

Also note that this appears to be a branch in google-cloud-cpp rather than your personal fork.


Gulp babel not transpiling to es5

I installed gulp babel (and dependencies) and when running gulp, same es6 code is being output in dist. I tried adding .babelrc to specify preset as well as specifying preset in gulp.
Is there anything I am missing?
gulpfile
var gulp         = require('gulp');
var babel        = require('gulp-babel');

gulp.task( 'customJS', function() {
    gulp.src( [ jsCustomSRC ] )
        .pipe( concat( jsCustomFile + '.js' ) )
        .pipe(babel({
            presets: ['@babel/env']
        }))
        .pipe( gulp.dest( jsDestination ) )
});

.babelrc
{
  "presets": ["@babel/env"]
}

package.json
  "devDependencies": {
    "@babel/core": "^7.1.5",
    "@babel/preset-env": "^7.1.5",
    "gulp": "^4.0.0",
    "gulp-babel": "^8.0.0",
    "gulp-concat": "^2.5.2"
  }

I have the same issue I got no files being created by the task where babel runs.

I'm also seeing this behaviour with a similar setup to @vincentGustav's.

I also had this probleem but wrapping it in a second array will fix it,
.pipe($.babel({
    presets: [['@babel/preset-env']]
}))

I experienced the same issue and could not get this working, even with the solution @ArnoMandersTfe has kindly provided.
Here is a Stack Overflow thread on this problem: https://stackoverflow.com/questions/52599370/gulp-babel-dont-produce-any-output-file-or-doesnt-work-properly
I could only get gulp-babel to work by using the Babel 6 install as outlined in the readme

The reason is because of the preset and installed dependency is wrong.
This error is not logged out so a lot of dev do not know
`
{ Error: Cannot find module 'babel-preset-env' from '/Users/xuongluuthich/Code/src-static'

Did you mean "@babel/env"?
at Function.module.exports [as sync] (/Users/xuongluuthich/Code/src-static/node_modules/resolve/lib/sync.js:58:15)
at resolveStandardizedName (/Users/xuongluuthich/Code/src-static/node_modules/@babel/core/lib/config/files/plugins.js:101:31)
at resolvePreset (/Users/xuongluuthich/Code/src-static/node_modules/@babel/core/lib/config/files/plugins.js:58:10)
at loadPreset (/Users/xuongluuthich/Code/src-static/node_modules/@babel/core/lib/config/files/plugins.js:77:20)
at createDescriptor (/Users/xuongluuthich/Code/src-static/node_modules/@babel/core/lib/config/config-descriptors.js:154:9)
at items.map (/Users/xuongluuthich/Code/src-static/node_modules/@babel/core/lib/config/config-descriptors.js:109:50)
at Array.map ()
at createDescriptors (/Users/xuongluuthich/Code/src-static/node_modules/@babel/core/lib/config/config-descriptors.js:109:29)
at createPresetDescriptors (/Users/xuongluuthich/Code/src-static/node_modules/@babel/core/lib/config/config-descriptors.js:101:10)
at presets (/Users/xuongluuthich/Code/src-static/node_modules/@babel/core/lib/config/config-descriptors.js:47:19) code: 'MODULE_NOT_FOUND' }
You need to install babel-preset-envyarn add -D babel-preset-envAnd in the configuration, the preset name should be@babel/env`

Was anyone able to find a solution? The above merge updated from @babel/env to the new @babel/preset-env
Which is what I have been using, but I still get just a minified file with all require lines in it.
gulpfile.js
const gulp = require("gulp");
const babel = require("gulp-babel");
const sourcemaps = require("gulp-sourcemaps");
const uglify = require("gulp-uglify-es").default;
const concat = require("gulp-concat");

gulp.task("buildjs", () => {
  return gulp.src(paths.js.source)
    .pipe(sourcemaps.init({ loadMaps: true }))
    .pipe(concat(paths.build.destMinJSFileName))
    .pipe(babel())
    .pipe(uglify())
    .pipe(sourcemaps.write(paths.build.destMapFolder))
    .pipe(gulp.dest(paths.build.destBuildFolder));
});

.babelrc
{
    "presets": ["@babel/preset-env"]
}

package.json
"@babel/core": "^7.3.4",
"@babel/polyfill": "^7.2.5",
 "gulp": "^4.0.0",
"gulp-concat": "^2.5.2",
"gulp-sourcemaps": "^1.5.2",
"gulp-uglify-es": "^1.0.4"

entry.js (paths.js.source)
require("@babel/polyfill");
require("./main")

bundle.min.js (actual output)
"use strict";require("@babel/polyfill"),require("./main")
//# sourceMappingURL=maps/bundle.min.js.map

I too could only get gulp-babel to work by using the Babel 6 install as outlined in the readme:
$ npm install --save-dev gulp-babel@7 babel-core babel-preset-env

With this, you'll have presets: ['babel-preset-env'].

I have these issues as well. Gulp doesn't seem to use preset-env. I tried multiple variations with @babel/env, babel-preset-env & @babel/preset-env.

No output here too on some files. Tried to downgrade gulp-babel but dependencies were broken.

Modified the gulp-babel code and logged the error on console. There was a JavaScript parsing error in babel in my case.
The this.emit(error) call is not output to console nor does it interrupt the gulp processing. This is not ideal for analyzing issues.

Has anyone figured this problem out yet? I'm also getting ES6 output from using gulp-babel.
Here's my package.json:
{   "name": "g",   "version": "1.0.0",   "description": "",   "main": "index.js",   "scripts": {     "test": "echo \"Error: no test specified\" && exit 1"   },   "babel": {     "presets": [       "@babel/preset-env"     ]   },   "browserslist": [     "last 2 versions",     "> 2%",     "IE 11"   ],   "keywords": [],   "author": "",   "license": "ISC",   "devDependencies": {     "@babel/core": "^7.6.0",     "@babel/preset-env": "^7.6.0",     "del": "^5.1.0",     "fs": "0.0.1-security",     "gulp": "^4.0.2",     "gulp-autoprefixer": "^7.0.0",     "gulp-babel": "^8.0.0",     "gulp-concat": "^2.6.1",     "gulp-gzip": "^1.4.2",     "gulp-rename": "^1.4.0",     "gulp-sass": "^4.0.2",     "gulp-uglify": "^3.0.2",     "gulp-uglifycss": "^1.1.0"   },   "dependencies": {} }
And my gulp.js file:
`const gulp = require('gulp');
const concat = require('gulp-concat');
const uglify = require('gulp-uglify');
const del = require('del');
const fs = require('fs');
const babel = require('gulp-babel');
const rename = require('gulp-rename');
const themePrefix = '/themes/custom';
const config = {
bundleSrc: ['src/scripts/dependencies/.js', 'src/scripts/sources/bundle/.js'],
perPageScripts: 'src/scripts/sources/'
};
function buildBundle() {
return gulp.src(config.bundleSrc)
.pipe(babel())
.pipe(uglify())
.pipe(concat('bundle.min.js'))
.pipe(gulp.dest('wwwroot/js'));
}
function buildPageScripts(done) {
fs.readdir(config.perPageScripts, function (err, items) {
items.map(function (item) {
if (fs.lstatSync(${config.perPageScripts}${item}).isDirectory()) {
if (item !== 'bundle') {
gulp.src(${config.perPageScripts}${item}\\*.js)
.pipe(babel())
.pipe(uglify())
.pipe(rename(path => {
path.dirname = '';
}))
.pipe(gulp.dest('wwwroot/js'));
}
        } else {
            gulp.src(`${config.perPageScripts}${item}`)
                .pipe(babel())
                .pipe(uglify())
                .pipe(gulp.dest('wwwroot/js'));
        }
    });
});

done();

}`
And in the output I still get things like node.closest() and Array.from(). Halp!

Wow I really don't know why my comment looks all janky like that. Sorry guys! I tried to fix it...

Still not working.
PACKAGE.JSON
"devDependencies": {
    "@babel/core": "^7.6.0",
    "@babel/polyfill": "^7.6.0",
    "@babel/preset-env": "^7.6.0",
    "del": "^3.0.0",
    "gulp": "3.9.1",
    "gulp-autoprefixer": "^6.0.0",
    "gulp-babel": "^8.0.0",
    "gulp-clone": "^2.0.1",
    "gulp-concat": "^2.6.1",
    "gulp-cssnano": "^2.1.2",
    "gulp-eslint": "^4.0.0",
    "gulp-merge": "^0.1.1",
    "gulp-plumber": "^1.2.1",
    "gulp-rename": "^1.4.0",
    "gulp-replace": "^1.0.0",
    "gulp-sequence": "1.0.0",
    "gulp-uglify": "^3.0.1",
    "gulp-watch": "5.0.1",
  }

TASK
gulp.src(themeScripts)
	.pipe(babel({
		"presets": [
			[
				"@babel/preset-env",
				{
					"targets": {
						"browsers": [
							"last 2 version",
							"> 1%",
							"ie 10",
							"safari >= 7"
						]
					}
				}
			]
		]
	}))
	.pipe(concat('theme.min.js'))
	.pipe(uglify())
	.pipe(gulp.dest(paths.js));

Excerpt that was not transpiled
{key:"sendRequest",value:function(e){return new Promise(function(t,n){var i=new XMLHttpRequest;i.open("GET",e,!0),i.setRequestHeader("Content-Type","application/x-www-form-urlencoded"),i.onload=function(){if(200!=i.status)n({status:i.status,statusText:i.statusText});else if(""=="".concat(i.response))n({status:i.status,statusText:"empty response"});else{var e=JSON.parse("".concat(i.response));t(e)}},i.onerror=function(){n({status:i.status,statusText:i.statusText})},i.send()})}}

The Promisse should be transpiled to ie10, since are one of my target.

Same here,  using webpack 4 + babel-loader with same dependencies works out of the box, gulp-babel is a no go for any version/presets/plugins combinations.  Files get moved to dest but they are not transpilled . No errors either.

For us it turned out the issue wasn't directly related to gulp-babel, but that our browserslist was no longer transpilling down for IE11  (which has now hit <2%) so most ES6 features (arrow function, etc.) we're correctly being left alone.

I'm struggling to get gulp-babel to do a simple transpile a file with occurrences of String.prototype.includes.
I would be grateful to see a recipe that transpiles String.prototype.includes for:
gulp@^4
gulp-babel@^8
@babel/core@^7
@babel/preset-env@^7
I've tried adding the babel preset and a browserslist but the output from the transpile is a file that still has .includes and I can see no presence of a polyfill.
.browserslistrc
IE 11
> 0.25%
not dead

Ok, don´t know if it´s of any help but I can share my debug process
.pipe(babel()) with a babel.config.js, didn´t work
.pipe(babel()) with a babel.config.json, didn´t work
.pipe(babel({ presets: ['@babel/preset-env'] })) did something
.pipe(babel({ presets: [['@babel/preset-env', { "useBuiltIns": "usage", "core": "3.6" }]] })) didn´t work
.pipe(babel({ presets: [['@babel/preset-env', { "useBuiltIns": "usage", "corejs": "3.6" }]] })) did something
.pipe(babel()) with a babel.config.json (with corejs instead of core) did something
.pipe(babel()) with a babel.config.js (with corejs instead of core) did something
So... I don´t know where the I got the core property? And another issue is ¿why it doesn´t show any message?

npm update solve it for me :)

yarn add -D @babel/preset-env work for me

.pipe(babel({ presets: [['@babel/preset-env', { "useBuiltIns": "usage", "corejs": "3.6" }]] }))

Worked here, but babel added some require('s at the start of the file, which is why I see it worked, so I pressume you'll need to get rollup in the mix to resolve the requires?


Update README

Should we add in the following to readme in usage?
//= require highcharts/modules/offline-exporting

Thank you for reporting, I've updated the readme


Save to S3 in a background thread

Sometimes (depending on many factors) saving to S3 can produce a noticeable delay.
Saving in a background thread would prevent this, I think?  @raphaellig?

This means returning from https://github.com/monetate/s3nb/blob/37216893e04e91463910f8ee8604523dc92651b2/s3nb/ipy3.py#L312 without actually ensuring s3 is written to?  How would signal to the user that the save failed?

Hmm, that's a good point. :(
On Thu, Apr 7, 2016 at 3:41 PM, Gil Raphaelli<EMAIL_ADDRESS>wrote:

This means returning from
https://github.com/monetate/s3nb/blob/37216893e04e91463910f8ee8604523dc92651b2/s3nb/ipy3.py#L312
without actually ensuring s3 is written to? How would signal to the user
that the save failed?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/monetate/s3nb/issues/31#issuecomment-207061627

--
--
Austin Rochford
Principal Data Scientist @ Monetate
o:<PHONE_NUMBER> x382 | m:
<EMAIL_ADDRESS>Watch our Video
http://content.monetate.com/h/i/11572086-welcome-to-monetate | Marketing
Blog http://monetate.com/blog/ | Free Resources
http://monetate.com/resources/ | Follow Monetate on Twitter
http://twitter.com/monetate
http://www.monetatesummit.com
https://www.regonline.com/monetatesummit2016
https://www.regonline.com/monetatesummit2016
https://www.regonline.com/monetatesummit2016
https://www.regonline.com/monetatesummit2016
https://www.regonline.com/monetatesummit2016
https://www.regonline.com/monetatesummit2016
https://www.regonline.com/monetatesummit2016


:art: Add in-page link list #2237

close this one, has copied inpage links commits to bose/inpage-links


⚠ DesiTorrents has degraded performance

In f7446a3, DesiTorrents ($DST) experienced degraded performance:

HTTP code: 200
Response time: 2084 ms

Resolved: DesiTorrents performance has improved in e94a63e.


A question about the history of TS

Was this a spin-off of mklauber's TS?
I was just thinking it might be gook to remove the original from the community reference documentation if this is the replacement.
Thanks!

Yes it was. I sent him an email asking permission to use the name, and he was fine with that, so we callled it TiddlyServer 2.0. He posted an email then stating that he was discontinuing his support for version one, as my system accomplished the same end goal that his had, which was multiple node TiddlyWikis on the same port.
That's part of the reason that I haven't followed the same path as Jed when he made Bob, because he makes a few assumptions and writes to data folders directly, whereas TiddlyServer imitates a fully working Node TiddlyWiki server and client.


Request: Newspaper Icon

I'm missing a newspaper icon so badly. the only icon I had to choose from FontAwesome and I'm not happy with it :(

Means your bot going to implement!

*not


Github maintenance: Ensure that all pull requests are dealt with in a timely way and merge so as to prevent conflicts

Yet to be assigned: Think of this role as the project manager for collaboration and code integration.


Invoking custom functions crashes on mac

Is this still the case? I would like to use custom functions on MacOS and in my tests it seems to be working OK... (Recent Mac M1 + Monterey OS). I'm asking to make sure what Mac / OS versions this would concern.
Could we make a repo with Github Actions CI running across different Mac OS versions? There seems to be  10, 11, 12 VMs available - https://github.com/actions/virtual-environments/tree/main/images/macos.
With the recent stable support for Flutter on desktops  this issue (if still happening) might become more relevant.
If there are some actionable steps, I could provide some support in CI setup or creating reproducible crashes for closer inspection.
Cheers,
Roman

From my understanding, this has never been a problem when running with Flutter and sqlite3_flutter_libs. The crash only occurred when using custom functions with the sqlite3 dylib that comes with macOS.
My best guess at the time was that this is some overly sensitive security thing (e.g. a system library not being able to invoke user code and sqlite3's custom functions not being in the allowlist??). But I'm not experienced enough with macOS to say for sure.
Either way, it also seems to work on macOS 12. Since this is not going to be relevant for most users and it seems to work on macOS now (45a9fe66327d521078be626e2afcdb9da2d8d059), I'll close this as fixed.
I can run an CI pipeline across different macOS versions to see if this still happens with the latest version of the library on older macOS versions if you're interested in that. But if you're using sqlite3_flutter_libs, I don't think you'd run into this.

@simolus3 Thanks for the quick response! Glad to head that this is not happening with Flutter on macOS and that we might get the pipeline running with different macOS versions.
If you want to, I could look into configuring the CI. Should I create a separate issue for this?

If you want to, I could look into configuring the CI. Should I create a separate issue for this?

I've started a single run across all macOS versions supported by GitHub in https://github.com/simolus3/sqlite3.dart/actions/runs/2514598470. Judging by that, user-defined functions now seem to work on all macOS versions. Perhaps it was a change in the Dart SDK or some inadvertent change to this library that fixed the problem.
I'll setup some better caching and then enable testing across OS versions going forward.


Hotkey profile signature does not disappear after unbinding

Windows Terminal version
1.19.10302.0
Windows build number
22631.3085
Other Software
No response
Steps to reproduce
Remove the bind to the terminal profile and open tabmenu
Expected Behavior
The signature next to the profile name disappears
Actual Behavior
The signature next to the profile name does not disappear

Thanks for the report! This is actually already being tracked by another issue on our repo - please refer to #13943 for more discussion.
/dup #13943

Yes, but already 2 years)

You're very welcome to submit a PR to fix it if you'd like 😉


cobs::decode panics on invalid data

Example:
use std::panic;

fn main() {
    let r = panic::catch_unwind(|| {
        let mut buf = [0; 8];
        let _ = ::cobs::decode(&[2], &mut buf);
    });

    assert!(r.is_err());
}

I would expect this to return Err(()).
It's caused by this unwrap:
https://github.com/awelkie/cobs.rs/blob/3d0d280b30b5028469eb697a2b6cfb3747f3b8f8/src/lib.rs#L337
@jamesmunns Looks like you've had an active PR here for a while with no response. If @awelkie doesn't want to continue maintaining the crate, would you consider publishing your fork?

Hey @rjsberry, you might want to check out #14, I now have ownership of this crate.
As a temporary fix, I think https://github.com/ferrous-systems/cobs.rs/pull/2 addresses this issue (probably waaaaay too late, sorry :( ), which I have released as postcard-cobs v0.2.0.
I plan to re-upstream all of the work in postcard-cobs to the cobs.rs crate this weekend, hopefully.

Tentatively closing it, as I believe it has been addressed in my postcard-cobs fork, which I will be merging later this year. If that DOESN'T address your problem @rjsberry, please let me know or re-open the issue!


Update command line to support --json

One of the features that the Visual Studio ASP.NET team would like to support in beta8 is the ability to publish support for EF migrations.
In previous versions we had a difficult time discovering the contexts correctly for the publish dialog. For DNX projects we have dnx ef context list. We would like to use this to simplify the discovery process and to ensure we get the list correct. The issue with this is that the output of dnx ef context list is not in a format that is readable by VS. I'm proposing that we add a new switch --json to indicate that JSON should be returned instead of text.
@rowanmiller @vijayrkn @mayurid

cc @bricelam for his thoughts

Hmm, is there any particular reason you want to use the DNX command as an entry point? It would be better if you could use the API backing that command: Microsoft.Data.Entity.Commands.ContextTool.GetContextTypes() in EntityFramework.Commands.dll

@bricelam we followed a similar approach (although a bit more complex) with unit testing. It will enable us to integrate loosely. The implementation for ef migrations can change and there will be no impact to VS as long as the JSON format doesn't change.

Alright, the approach seems OK to me.
I think JSON is overkill--the most data it could possible return is the list of assembly-qualified type names. I agree that we need to, in general, look at the consumability our our output. Automation workflows shouldn't have to filter out our logging.

I think a -q|--quite flag would be idiomatic.

Sure if you pick some other format thats easily consumed thats fine with me. I suggested JSON because of we needed to add more later it would be easy. If we simply return a list of names there is not much opportunity to introduce additional values later.

Yeah, I do see the point. It seems to work well for the azure command too...

(Implementation Notes:)
The commands where this matters are

ef dbcontext list
ef migrations list
ef migrations script (Already has --output for similar purposes)
#577 (Backlog)

@bricelam there's an azure command?

The non-DNX, node-based one :wink: Azure/azure-xplat-cli


Enable most V8 DCHECKs

It seems that only a few V8 DCHECKs still fail, so I'm enabling the rest.

@alespergl These changes have already been merged to the libcc's master, right?

Just rebased it onto the tip of the electron-2-0-x branch to mitigate Electron build failure on arm.


Pattern: Callout - with data Services template pattern Design QA testing

User Story

As a [user role below]:
DDS Designer and Developer

I need to:
test the Callout - with data

so that I can:
be sure the developer's code correctly works as designed

Additional Information

See the Epic for the Design and Functional specs information
Dev Issue (#2823 )
Storybook link

Tasks
Ensure the Callout - with data pattern has been tested and reviewed by design + dev.
Acceptance criteria

[ ] Pattern is reviewed by designer and design defects are identified
[ ] New issues are opened to log individual defects
[ ] Screenshots of as-is and to-be design should be added to the issue when needed

This pattern is ready for Design QA,
Thank you!
@RobertaJHahn @ltitle

@RobertaJHahn Design QA for this pattern is now complete. The following issue was opened: #2976


Variable name should be proper

In this line "val customEventhubParameters = EventHubsConf(connectionString).setMaxEventsPerTrigger(5)" instead of connectionString variable name in EventHubsConf should be   connStr ?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 147e84ea-1def-dd8a-f562-4ce016138c62
Version Independent ID: ec57e668-b86a-2c0e-4a20-04c17de1c23b
Content: Tutorial: Process data from Azure Event Hubs with Apache Spark in Azure HDInsight
Content Source: articles/hdinsight/spark/apache-spark-eventhub-streaming.md
Service: hdinsight
GitHub Login: @mumian
Microsoft Alias: jgao

@rawatsudhir1 Thanks for bringing this to our attention. Your feedback has been shared with the content owner for further review.

@rawatsudhir1 Thanks for the feedback.  The article will be updated today.

The article has been  updated.  @please-close

#please-close

@rawatsudhir1 We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


Hurdle race- HackerRank

Description
Code added for Hurdle Race problem in C++
Fixes #2204
Checklist:

[x] My code follows the style guidelines(Clean Code) of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings

@ravikr126 @Ayush7614 please review the pr

@sameeksharl please review the pr

@gunjan-g merged into main


The v from var is parsed into prefix when assigned an unknown type, leading to recipe issues further down

What version of OpenRewrite are you using?
I use the current RELEASE version.
I am using

OpenRewrite
Maven plugin
org.openrewrite.staticanalysis.FinalizeLocalVariables

How are you running OpenRewrite?
I ran the following maven command:
mvn -U org.openrewrite.maven:rewrite-maven-plugin:run \
  -Drewrite.recipeArtifactCoordinates=org.openrewrite.recipe:rewrite-static-analysis:RELEASE \
  -Drewrite.activeRecipes=org.openrewrite.staticanalysis.FinalizeLocalVariables

What is the smallest, simplest way to reproduce the problem?
The issue is reproducible with the following test case
@Test
    void shouldFinalizeCorrectly() {
        rewriteRun(
          s -> s.typeValidationOptions(TypeValidation.none()),
          version(
            //language=java
            java(
              """
                public class Main {
                    private boolean test(MessagePayload payload) {
                        var a = DomainObject.from(payload.getValue());

                        return a != null
                            && Integer.valueOf(999).equals(a.getField1())
                            && Integer.valueOf(101).equals(a.getField2());
                    }
                }
                  """,
              """
                public class Main {
                    private boolean test(MessagePayload payload) {
                        final var a = DomainObject.from(payload.getValue());

                        return a != null
                            && Integer.valueOf(999).equals(a.getField1())
                            && Integer.valueOf(101).equals(a.getField2());
                    }
                }
                  """
            ), 17)
        );
    }

The above test fails with the following diff:

I'm currently looking into the issue, but stuck where the "var" is replaced into "(ERROR)"

Method: ReloadableJava17ParserVisitor.visitVariables


Get unexpected result with WeekOfMonth @1.4.5

Hello,
I encountered an issue with the following code:
carbon.Parse("2021-07-28 19:09:00").WeekOfMonth()

carbon version: 1.4.5
golang version: 1.16.6
I expected to get:
5

But I actually get:
4

I'm wondering if go mod 1.4.5 is publish success.
It's get right result when I clone the whole project and run with go test xx (after remove the import math for file getter.go)
However, import by go mod 1.4.5 is wrong.
BTW, I'm sure to use the v 1.4.5 by looking into the local go mod file
module scrum-master-bot

go 1.16

require (
        github.com/anaskhan96/soup v1.2.4 // indirect
        github.com/golang-module/carbon v1.4.5 // indirect
)

Thanks!

Didn't it throw a panic after remove the import math for file getter.go ?

I tried with php's Carbon library, the result also was 4, I'm looking for the reason.

I tried with php's Carbon library, the result also was 4, I'm looking for the reason.

$week = Carbon::parse("2020-07-28")->weekOfMonth;
dump("week of July is $week"); // week of July is 4

should be 2021-07-28

After comparison, the weekNumberInMonth() method in PHP's carbon output result is 5.
In order to keep consistent with cognition, carbon v1.5.5 adopts weekNumberInMonth() as WeekOfMonth()

After comparison, the weekNumberInMonth() method in PHP's carbon output result is 5.

In order to keep consistent with cognition, carbon v1.5.6 adopts weekNumberInMonth() as WeekOfMonth()

Thanks!


map atlases mod crashing

Mod Name
Map Atlases
Mod Homepage
https://modrinth.com/mod/map-atlases
Minecraft version
1.20.1
Describe the bug
minecraft crashing on the forge ( connector ) screen
Steps to reproduce

start minecraft
wait
here is a crash!

Logs
https://gist.github.com/E064/ecb8d782f029f81c8b9415528ddf62fc
Additional context
No response

java.lang.ClassNotFoundException: dev.emi.trinkets.api.TrinketItem

You're missing trinkets

Install all dependencies normally. Instead of Trinkets and Curios, use Accessories and its Compatibility Layers.

A forge version is available too btw https://www.curseforge.com/minecraft/mc-mods/map-atlases-forge


Problems with rowspans

Hello! I've been using this package and stuck with the bug.
I have a table like that in HTML -> example
But when I export it to excel with ExcelParser, I have some extra rows in the excel table. Take a look at the screenshot, I drew them in red.

The code I used to generate the .xslx file
from html2excel import ExcelParser
parser = ExcelParser('./test.html')
parser.to_excel('./converted_file.xlsx')

I'm not sure how browsers parse html files but they do seem to adjust even if our html tables are erroneous. Taking that approach here would be disingenuous as the goal of this library is to create an exact replica of how it would look on excel.


Problem setting conda environment

Hello, I'm unable to create the conda environment.
Once I cloned the repository, I ran the following code:
conda env create -f SVFXenv.yml && conda activate SVFXenv
and I get this error:

Solving environment: failed

ResolvePackageNotFound:
  - openssl==1.1.1g=h0b31af3_0
  - llvm-openmp==9.0.1=h28b9765_2
  - ncurses==6.1=h0a44026_1002
  - tk==8.6.10=hbbe82c9_0
  - libopenblas==0.3.9=h3d69b6c_0
  - scipy==1.4.1=py37h82752d6_0
  - pybigwig==0.3.17=py37haec6b85_0
  - libedit==3.1.20170329=hcfe32e1_1001
  - libssh2==1.8.2=hcdc9a53_2
  - libgfortran==4.0.0=2
  - readline==8.0=hcfe32e1_0
  - pandas==1.0.3=py37h94625e5_0
  - sqlite==3.30.1=h93121df_0
  - python==3.7.6=hfa4aa89_4_cpython
  - libffi==3.2.1=h4a8c4bd_1007
  - xz==5.2.4=h0b31af3_1002
  - libcurl==7.68.0=h709d2b2_0
  - krb5==1.16.4=h1752a42_0
  - zlib==1.2.11=h0b31af3_1006

Thank you!!

Hi, thank you for letting us know! What platform are you running this on (MacOS, Linux, etc.)?

I also have this problem.
My platform info:
Linux 3.10.0-1127.el7.x86_64 #1 SMP Tue Mar 31 23:36:51 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
conda 4.9.2

Hello @jagathv,
Please find below my setup:
conda 4.7.12
Operating System: CentOS Linux 7 (Core)
CPE OS Name: cpe:/o:centos:centos:7
Kernel: Linux 3.10.0-1062.12.1.el7.x86_64
Architecture: x86-64

@frequena @masen0407 Thanks for the information!
We've exported a new environment config that should work for Linux - please pull the new changes, run conda env create -f SVFXenv_all_platforms.yml && conda activate SVFXenv, and let me know if errors persist.


fix composer dependency

Problem:

Installation request for satooshi/php-coveralls dev-master -> satisfiable by satooshi/php-coveralls[dev-master].
satooshi/php-coveralls dev-master requires php >=5.5 -> your PHP version (5.3.29) or "config.platform.php" value does not satisfy that requirement

Details can be found at Travis CI.

Solved

Thank you for a contribution.


python311.pkgs.mox3: disable

Description of changes
Uses APIs removed in Python 3.11, for example this test failure from aprslib:
E           AttributeError: module 'inspect' has no attribute 'getargspec'

/nix/store/x6ps6s9k2i1dcnb9jf1kbfgghgf6k53f-python3.11-mox3-1.1.0/lib/python3.11/site-packages/mox3/mox.py:909: AttributeError

Unmaintained upstream.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Thanks, I've changed which part of the log I was quoting.  Unfortunately it doesn't put the stack trace next to the actual error, but I think that's fine as it's easy to reproduce.


refactor: Refactor structure of Frontend

Change approach from "per type" to "per feature"
Refs: CU-86975w8k1

Task linked: CU-86975w8k1 Refactor frontend structure


Fix source maps relative file lookup for source javascript file.

We are using the ant-design-vue package with source maps, which depends on this package. During compilation there seem to be some problems with the source maps as generated with the compiled source.
The error is as follows:
Module Warning (from ./node_modules/source-map-loader/index.js):
(Emitted value instead of an instance of Error) Cannot find source file 'MutationObserver.js': Error: Can't resolve './MutationObserver.js' in '/home/maico/IdeaProjects/viaduct/node_modules/mutationobserver-shim/dist'

I took a look at the source map that is generated by the closure compiler, which currently looks like:
{
"version":3,
"file":"",
"lineCount":16,
"mappings":"...omitted...",
"sources":["MutationObserver.js"],
"names":["...omitted..."]
}

From the source map spec I know that the file field should contain the name of the minified file, in this case mutationobserver.min.js, however it seems closure compiler does not fill that.
The main problem here is that the sources field should point to the original source file, relative to the source map file. As I'm unfamiliar with closure compiler and didn't see options to change the sources to ["../MutationObserver.js"], I've moved the minified file and the relevant source map to the same folder as the original javascript file. This seems a more future proof solution than manually adding the .. to the path, as the source map will still be correct after a recompile.
P.S. I was unable to run the full test suite on master, it seems gunit:main is not able to run on my local machine. I didn't look into the cause of that, meaning it didn't run for my changes.

@megawac Do you have the time to take a look at these changes?

Yeah the version of grunt we're using is super old (like 6 years) and with its subdeps changing underneath it it likely caused the test cases to break. I'll take a look at this this afternoon however I'm a bit confused why this would cause issues for ant tooling? Have you verified this fix works?


Compare OGER/Ontorunner vs Nemo-Serve/SAPBert vs Nemo-Serve/QuickUMLS on split_11

Needed:

[ ] split_11 annotations from OGER/Ontorunner
[ ] split_11 annotations from Nemo-Serve/SAPBert
[ ] split_11 annotations from Nemo-Serve/QuickUMLS
[ ] Tools to compare them

You can see current tools at #1

We now have Ontorunner output for split_11 available on Hatteras at /projects/ner/split_11_results/ontorunner/split_11-results.jsonl.

Number of results: 488,850 (the same number of results as split_11.txt)
Range: 0-34640 denotations per abstract (only one abstract has zero denotations)
Median: 207, mean: 225.62
25th percentile: 139, 75th percentile: 287

I'm working on documenting how I came up with these results (https://github.com/RENCI-NER/oger-benchmarks/issues/2). As part of that work, I'd like to create a Docker image for OGER/Ontorunner and re-run split_11 on Docker so we have a measure of how quickly Ontorunner can process input text.


fix: content-script run_at

I came across this boilerplate. There was this one issue I saw that the content script wasn't being executed. Also, added the documentation in README.md.
PS: Commented out the Greeting.jsx container.

It's not recommended to use anything but "document_idle" by default.
https://developer.chrome.com/docs/extensions/mv2/content_scripts/#run_time


[2.0] Deprecate the "Master" nomenclature in nodejs client

Description
1.Deprecate setting cluster.initial_master_nodes and introduce
the alternative setting cluster.initial_cluster_manager_nodes.
2.Use a new node role cluster_manager that has the same functionality
with master in the node setting node.roles: [ master ]
3.Cat API _cat/master is replaced with _cat/cluster_manager
4.Deprecate master_timeout parameter to cluster_manager_timeout
5.Deprecate several interfaces, for example CatMasterMasterRecord
6.Replaces tests and comments
Issues Resolved
https://github.com/opensearch-project/opensearch-js/issues/221
Check List

[ ] New functionality includes testing.

[x] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

should be bwc

will change to allow both master and cluster_manager

On cat.master
var response = await client.cat.master();
console.log('Cat master:')
console.log(response.body)

Result:
TypeError: client.cat.master is not a function
    at search (/home/anan/work/test/data.js:41:37)
    at process._tickCallback (internal/process/next_tick.js:68:7)

On client.nodes.info
var time = '5s';
    var response = await client.nodes.info({
        cluster_manager_timeout: time,
    });

Result:
{ ResponseError: illegal_argument_exception: [illegal_argument_exception] Reason: request [/_nodes] contains unrecognized parameter: [cluster_manager_timeout]
    at onBody (/home/anan/work/test/node_modules/@opensearch-project/opensearch/lib/Transport.js:374:23)
    at IncomingMessage.onEnd (/home/anan/work/test/node_modules/@opensearch-project/opensearch/lib/Transport.js:293:11)
    at IncomingMessage.emit (events.js:203:15)
    at endReadableNT (_stream_readable.js:1145:12)
    at process._tickCallback (internal/process/next_tick.js:63:19)
  name: 'ResponseError',
  meta:
   { body: { error: [Object], status: 400 },
     statusCode: 400,
     headers:
      { 'content-type': 'application/json; charset=UTF-8',
        'content-length': '289' },
     meta:
      { context: null,
        request: [Object],
        name: 'opensearch-js',
        connection: [Object],
        attempts: 0,
        aborted: false } } }

On client.cluster.health
This works well.
var time = '5s';
    var response = await client.cluster.health({
        master_timeout: time,
    });
    console.log('Cluster health:')
    console.log(response.body)

Result:
Cluster health:
{ cluster_name: 'runTask',
  status: 'yellow',
  timed_out: false,
  number_of_nodes: 1,
  number_of_data_nodes: 1,
  discovered_master: true,
  discovered_cluster_manager: true,
  active_primary_shards: 4,
  active_shards: 4,
  relocating_shards: 0,
  initializing_shards: 0,
  unassigned_shards: 12,
  delayed_unassigned_shards: 0,
  number_of_pending_tasks: 0,
  number_of_in_flight_fetch: 0,
  task_max_waiting_in_queue_millis: 0,
  active_shards_percent_as_number: 25 }

Sorry my bad.
~/work/test$ node data.js
Creating index:
{ acknowledged: true, shards_acknowledged: true, index: 'books' }
Cat master:
1jjPht0bRDqRuJWT_q6abQ <IP_ADDRESS> <IP_ADDRESS> runTask-0

Cluster health:
{ cluster_name: 'runTask',
  status: 'yellow',
  timed_out: false,
  number_of_nodes: 1,
  number_of_data_nodes: 1,
  discovered_master: true,
  discovered_cluster_manager: true,
  active_primary_shards: 4,
  active_shards: 4,
  relocating_shards: 0,
  initializing_shards: 0,
  unassigned_shards: 12,
  delayed_unassigned_shards: 0,
  number_of_pending_tasks: 0,
  number_of_in_flight_fetch: 0,
  task_max_waiting_in_queue_millis: 0,
  active_shards_percent_as_number: 25 }
Cluster health:
{ persistent: {}, transient: {} }
Adding document:
{ _index: 'books',
  _id: '1',
  _version: 1,
  result: 'created',
  forced_refresh: true,
  _shards: { total: 4, successful: 1, failed: 0 },
  _seq_no: 0,
  _primary_term: 1 }
Search results:
{ total: { value: 1, relation: 'eq' },
  max_score: 0.5753642,
  hits:
   [ { _index: 'books',
       _id: '1',
       _score: 0.5753642,
       _source: [Object] } ] }
Deleting document:
{ _index: 'books',
  _id: '1',
  _version: 2,
  result: 'deleted',
  _shards: { total: 4, successful: 1, failed: 0 },
  _seq_no: 1,
  _primary_term: 1 }
Deleting index:
{ acknowledged: true }

cat.master and cat.cluster_manager are both supported.
var response = await client.cat.master();
console.log('Cat master:')
console.log(response.body)
var response = await client.cat.cluster_manager();
console.log('Cat cluster_manager:')
console.log(response.body)

Cat master:
Y6sYShIMRgiVfIUar5FVoA <IP_ADDRESS> <IP_ADDRESS> runTask-0

Cat cluster_manager:
Y6sYShIMRgiVfIUar5FVoA <IP_ADDRESS> <IP_ADDRESS> runTask-0

Other test results:
anan@***:~/work/opensearch-js$ yarn test:unit
yarn run v1.22.5
$ tap test/unit/{*,**/*}.test.js
 SKIP  test/unit/esm/index.test.js
 ~ Skip because Node version < 12.17.0

 SKIP  test/unit/esm/index.test.js 1 skip of 1 3.378ms
 ~ Skip because Node version < 12.17.0

 PASS  test/unit/cloud-connection-pool.test.js 4 OK 14.881ms
 PASS  test/unit/selectors.test.js 8 OK 9.462ms
 PASS  test/unit/events.test.js 19 OK 33.137ms
 PASS  test/unit/errors.test.js 36 OK 29.054ms
 PASS  test/unit/base-connection-pool.test.js 44 OK 85.439ms
 PASS  test/unit/helpers/search.test.js 8 OK 24.873ms
 PASS  test/unit/serializer.test.js 19 OK 33.493ms
 PASS  test/unit/api.test.js 25 OK 73.844ms
 PASS  test/unit/connection-pool.test.js 90 OK 170.249ms
 PASS  test/unit/child.test.js 36 OK 152.741ms
test/unit/helpers/bulk.test.js 2> (node:3181474) DeprecationWarning: strictEqual() is deprecated, use equal() instead
test/unit/helpers/bulk.test.js 2> (node:3181474) DeprecationWarning: deepEqual() is deprecated, use same() instead
 PASS  test/unit/helpers/scroll.test.js 58 OK 188.939ms
 PASS  test/unit/helpers/bulk.test.js 291 OK 241.85ms
 PASS  test/unit/helpers/msearch.test.js 49 OK 568.246ms
 PASS  test/unit/connection.test.js 77 OK 3s
 PASS  test/unit/transport.test.js 202 OK 4s
 PASS  test/unit/client.test.js 118 OK 11s

  🌈 SUMMARY RESULTS 🌈

 SKIP  test/unit/esm/index.test.js 1 skip of 1 3.378ms
 ~ Skip because Node version < 12.17.0

Suites:   17 passed, 17 of 17 completed
Asserts:  1084 passed, 1 skip, of 1085
Time:     12s
Done in 12.35s.
anan@***:~/work/opensearch-js$ yarn test:integration:helpers
yarn run v1.22.5
$ tap test/integration/helpers/*.test.js
 PASS  test/integration/helpers/search.test.js 11 OK 2s
 PASS  test/integration/helpers/msearch.test.js 27 OK 6s
 PASS  test/integration/helpers/scroll.test.js 215 OK 6s
 PASS  test/integration/helpers/bulk.test.js 25 OK 8s

  🌈 SUMMARY RESULTS 🌈

Suites:   4 passed, 4 of 4 completed
Asserts:  278 passed, of 278
Time:     8s
Done in 8.82s.

I would like to document some test steps:

Prepare
mkdir test
cd test

git clone https://github.com/opensearch-project/OpenSearch

git clone https://github.com/opensearch-project/opensearch-js

//checkout OpenSearch 2.0
cd test/OpenSearch

git checkout -b 2.0 origin/2.0
//Deploy local cluster (optional):
sudo sysctl -w vm.max_map_count=262144
ulimit -n 65535

./deploy_single_tar_cluster.sh -v 1.0.0 -t releases -a x64 -s false
//run OpenSearch
./gradlew run -Drun.distribution=oss (run OpenSearch without security, this is fine for test purpose)
API Tests
//create another client folder in test
mkdir client
cd test/client and run npm init -y
// if opensearch-js package is installed, need to clean it first. Here are some clean steps:
rm -rf node-modules/@opensearch-project
clean yarn.lock (remove @opensearch-project part)
remove opensearch-project/opensearch in package.json
//Reinstall the local opensearch-js package. Do not checkot npm package
//Check package.json, make sure "types": "api/new.d.ts",
yarn add --dev '/home/anan/work/opensearch-js'
//double check package.json that opensearch-project/opensearch is installed and it is from your local
//create a test script
vim data.js and copy the above example
//run test script
node data.js
Unit Tests
yarn test:unit
Integration Tests
yarn test:integration:helpers

[Research & Summary]
[Optional master_timeout]
—> What change:
For each master_timeout? , add anothercluster_manager_timeout?

—> Affected Files:
api/requestParams.d.ts
api/types.d.ts

—> Example:
export interface CatAllocation extends Generic {
  node_id?: string | string[];
  format?: string;
  bytes?: 'b' | 'k' | 'kb' | 'm' | 'mb' | 'g' | 'gb' | 't' | 'tb' | 'p' | 'pb';
  local?: boolean;
  cluster_manager_timeout?: string;
  master_timeout?: string;
  h?: string | string[];
  help?: boolean;
  s?: string | string[];
  v?: boolean;
}

—> How to Test:
There are two possible cases:

1.Only API exist but cluster_manager_timeout/master param does not exist.
For example, client.nodes.info:
https://github.com/opensearch-project/OpenSearch/blob/c31cddf27e9618582b3cd175e4e0bce320af6a14/rest-api-spec/src/main/resources/rest-api-spec/api/nodes.info.json#L80
We could see currently OpenSearch only support two params: timeout and flat_settings.
Use script to test it:
var response = await client.nodes.info({
         master_timeout: time,
     });

var response = await client.nodes.info({
         cluster_manager_timeout: time,
     });

Results are:
{ ResponseError: illegal_argument_exception: [illegal_argument_exception] Reason: request [/_nodes] contains unrecognized parameter: [master_timeout]
    at onBody (/home/anan/work/test/node_modules/@opensearch-project/opensearch/lib/Transport.js:374:23)
    at IncomingMessage.onEnd (/home/anan/work/test/node_modules/@opensearch-project/opensearch/lib/Transport.js:293:11)
    at IncomingMessage.emit (events.js:203:15)
    at endReadableNT (_stream_readable.js:1145:12)
    at process._tickCallback (internal/process/next_tick.js:63:19)

{ ResponseError: illegal_argument_exception: [illegal_argument_exception] Reason: request [/_nodes] contains unrecognized parameter: [cluster_manager_timeout]
    at onBody (/home/anan/work/test/node_modules/@opensearch-project/opensearch/lib/Transport.js:374:23)
    at IncomingMessage.onEnd (/home/anan/work/test/node_modules/@opensearch-project/opensearch/lib/Transport.js:293:11)
    at IncomingMessage.emit (events.js:203:15)
    at endReadableNT (_stream_readable.js:1145:12)
    at process._tickCallback (internal/process/next_tick.js:63:19)

2.Both API and params exist
For example, client.cluster.health:
Master_timeout:
https://github.com/opensearch-project/OpenSearch/blob/70977525622053b662e79aa185034e21543d9a4e/rest-api-spec/src/main/resources/rest-api-spec/api/cluster.health.json#L57
Cluster_manager_timeout:
https://github.com/opensearch-project/OpenSearch/blob/70977525622053b662e79aa185034e21543d9a4e/rest-api-spec/src/main/resources/rest-api-spec/api/cluster.health.json#L65
Use script to test it:
var time = '5s';
var response = await client.cluster.getSettings({
      master_timeout: time,
});
console.log('Cluster getSettings use master_timeout:')
console.log(response.body)

var time = '5s';
var response = await client.cluster.getSettings({
      cluster_manager_timeout: time,
});
console.log('Cluster getSettings use cluster_manager_timeout:')
console.log(response.body)

Results are:
Cluster getSettings use master_timeout:
{ persistent: {}, transient: {} }
Cluster getSettings use cluster_manager_timeout:
{ persistent: {}, transient: {} }

[API's request query string]
—> What change:
Some APIs query params contains master_timeout. For example, cluster API:
const acceptedQuerystring = ['include_yes_decisions', 'include_disk_info', 'pretty', 'human', 'error_trace', 'source', 'filter_path', 'timeout', 'master_timeout', 'wait_for_removal', 'local', 'flat_settings', 'include_defaults', 'expand_wildcards', 'level', 'wait_for_active_shards', 'wait_for_nodes', 'wait_for_events', 'wait_for_no_relocating_shards', 'wait_for_no_initializing_shards', 'wait_for_status', 'node_ids', 'node_names', 'create', 'dry_run', 'explain', 'retry_failed', 'metric', 'wait_for_metadata_version', 'wait_for_timeout', 'ignore_unavailable', 'allow_no_indices']
const snakeCase = { includeYesDecisions: 'include_yes_decisions', includeDiskInfo: 'include_disk_info', errorTrace: 'error_trace', filterPath: 'filter_path', masterTimeout: 'master_timeout', waitForRemoval: 'wait_for_removal', flatSettings: 'flat_settings', includeDefaults: 'include_defaults', expandWildcards: 'expand_wildcards', waitForActiveShards: 'wait_for_active_shards', waitForNodes: 'wait_for_nodes', waitForEvents: 'wait_for_events', waitForNoRelocatingShards: 'wait_for_no_relocating_shards', waitForNoInitializingShards: 'wait_for_no_initializing_shards', waitForStatus: 'wait_for_status', nodeIds: 'node_ids', nodeNames: 'node_names', dryRun: 'dry_run', retryFailed: 'retry_failed', waitForMetadataVersion: 'wait_for_metadata_version', waitForTimeout: 'wait_for_timeout', ignoreUnavailable: 'ignore_unavailable', allowNoIndices: 'allow_no_indices' }

acceptedQuerystring is all the accepted query params for this API. For cluster API's method, query string's keys are transformed using snakeCase then pass to request.
 querystring = snakeCaseKeys(acceptedQuerystring, snakeCase, querystring)

For acceptedQuerystring, add 'cluster_manager_timeout'
For snakeCase, add clusterManagerTimeout: 'cluster_manager_timeout'
—> Affected Files:
api/cat.js
api/cluster.js
api/api/dangling_indices.js
api/api/delete_script.js
api/api/features.js
api/api/get_script.js
api/api/indices.js
api/api/ingest.js
api/api/put_script.js
api/api/snapshot.js

—> Example:
const acceptedQuerystring = ['format', 'local', 'h', 'help', 's', 'v', 'expand_wildcards', 'pretty', 'human', 'error_trace', 'source', 'filter_path', 'bytes', 'cluster_manager_timeout', 'master_timeout', 'fields', 'time', 'ts', 'health', 'pri', 'include_unloaded_segments', 'allow_no_match', 'allow_no_datafeeds', 'allow_no_jobs', 'from', 'size', 'full_id', 'include_bootstrap', 'active_only', 'detailed', 'index', 'ignore_unavailable', 'nodes', 'actions', 'parent_task_id']
const snakeCase = { expandWildcards: 'expand_wildcards', errorTrace: 'error_trace', filterPath: 'filter_path', clusterManagerTimeout: 'cluster_manager_timeout', masterTimeout: 'master_timeout', includeUnloadedSegments: 'include_unloaded_segments', allowNoMatch: 'allow_no_match', allowNoDatafeeds: 'allow_no_datafeeds', allowNoJobs: 'allow_no_jobs', fullId: 'full_id', includeBootstrap: 'include_bootstrap', activeOnly: 'active_only', ignoreUnavailable: 'ignore_unavailable', parentTaskId: 'parent_task_id' }

—> How to Test:
Similar to the previous case. Can use script to test.
[CAT.master API]
—> What change:
Add CatApi.prototype.cluster_manager
Add cluster_master method with corresponding renamed param and response types
(CatMaster --> CatClusterManager it is only used in Cat.master API)
—> Affected Files:
api/api/cat.js
index.d.ts
api/new.d.ts
api/opensearch_dashboards.d.ts

—> How to Test:
Similar to the previous case. Can use script to test.
cat.master and cat.cluster_manager are both supported.
Here is a script example:
var response = await client.cat.master();
console.log('Cat master:')
console.log(response.body)
var response = await client.cat.cluster_manager();
console.log('Cat cluster_manager:')
console.log(response.body)

Results:
Cat master:
Y6sYShIMRgiVfIUar5FVoA <IP_ADDRESS> <IP_ADDRESS> runTask-0

Cat cluster_manager:
Y6sYShIMRgiVfIUar5FVoA <IP_ADDRESS> <IP_ADDRESS> runTask-0

[NodeRole]
—> What change:
NodeRole/NodeRoles are defined in api/types.d.ts. They are used in:

1.NodeAttributes:
https://github.com/opensearch-project/opensearch-js/blob/13d6e0312dfe190cf9818b44cebbd580fb22f5f3/api/types.d.ts#L2053

NodeAttributes is called in ClusterRerouteRerouteState then called by ClusterRerouteResponse
NodeAttributes is called in ClusterStateResponse
NodeAttributes is called in SearchShardsResponse

2.NodesStats
https://github.com/opensearch-project/opensearch-js/blob/13d6e0312dfe190cf9818b44cebbd580fb22f5f3/api/requestParams.d.ts#L1264

NodeStats is called in NodesReloadSecureSettingsResponse
NodeStats is called in NodesStatsResponse
3.NodesInfoNodeInfo:
https://github.com/opensearch-project/opensearch-js/blob/13d6e0312dfe190cf9818b44cebbd580fb22f5f3/api/types.d.ts#L8780

NodesInfoNodeInfo is called in NodesInfoResponse
Add 'cluster_manager' in NodeRole
—> Affected Files:
api/types.d.ts
—> How to Test:
All response types. Should be no bwc issue.
[Connection role]
—> What change:
Add a new support role CLUSTER_MANAGER: 'cluster_manager'
Shrink the defaultRoles to only Connection.roles.DATA and Connection.roles.INGEST.
Connection.roles = { CLUSTER_MANAGER: 'cluster_manager', MASTER: 'master', DATA: 'data', INGEST: 'ingest'}

const defaultRoles = {
  [Connection.roles.DATA]: true,
  [Connection.roles.INGEST]: true
}

—> Affected Files:
lib/Connection.js
—> How to Test:
Can be tested in unit tests.
[Optional initial_master_nodes]
—> What change:
Add optional initial_cluster_manager_nodes?: string
—> Affected Files:
api/types.d.ts
—> Example:
export interface NodesInfoNodeInfoSettingsCluster {
  name: Name
  routing?: IndicesIndexRouting
  election: NodesInfoNodeInfoSettingsClusterElection
  initial_cluster_manager_nodes?: string
  initial_master_nodes?: string
}

—> How to Test:
NodesInfoNodeInfoSettingsCluster is only used in NodesInfoNodeInfoSettings. Then called by interface NodesInfoNodeInfo and then called by interface NodesInfoResponse.
Only affect response. Should be no bwc issue.
[Optional master_node param]
—> What change:
Optional master_node is used in two places, ClusterRerouteRerouteState and ClusterStateResponse.
Add optional cluster_manager_node. See below example section.
—> Affected Files:
api/types.d.ts
—> Example:
export interface ClusterStateResponse {
  cluster_name: Name
  cluster_uuid: Uuid
  cluster_manager_node?: string
  master_node?: string
  state?: string[]
  state_uuid?: Uuid
  version?: VersionNumber
  blocks?: ClusterStateClusterStateBlocks
  metadata?: ClusterClusterStateMetadata
  nodes?: Record<NodeName, NodeAttributes>
  routing_table?: Record<string, EmptyObject>
  routing_nodes?: ClusterClusterStateRoutingNodes
  snapshots?: ClusterClusterStateSnapshots
  snapshot_deletions?: ClusterClusterStateDeletedSnapshots
}

—> How to Test:
ClusterRerouteRerouteState is called in ClusterRerouteResponse which is a response.
ClusterStateResponse is a response.
Only affect response. Should be no bwc issue.
[Optional master param]
—> What change:
There are two interfaces CatNodesNodesRecord and ClusterStatsClusterNodeCount defined in types will be affected.
Add optional cluster_manager.
—> Affected Files:
api/types.d.ts
—> Example:
export interface ClusterStatsClusterNodeCount {
  coordinating_only: integer
  data: integer
  ingest: integer
  cluster_manager?: integer
  master?: integer
  total: integer
  voting_only: integer
  remote_cluster_client: integer
}

—> How to Test:
CatNodesNodesRecord is only called in CatNodesResponse which is a response.
ClusterStatsClusterNodeCount only affects ClusterStatsResponse.
Only affect response. Should be no bwc issue.

@ananzh there ares some lint error's, can you fix them?

@ananzh there ares some lint error's, can you fix them?

done

What's the upgrade path or users? Ideally 2.0 client would work against 1.x, see https://github.com/opensearch-project/opensearch-clients/issues/17

What's the upgrade path for users that have applications that work against OpenSearch 1.x and want to go to 2.x?
Ideally 2.0 client would work against 1.x, see opensearch-project/opensearch-clients#17

I believe mentioned in the thread, assuming none of the new APIs are used it should ideally we work. But I know there was another issue about the source of truth for compatibility. It seems fairly easy to remember clients major versions only equal to the same major version of OpenSearch. I do see the RFC for API versioning which will also effect decisions here. I think for sure it should be standardized across all clients.

Also seems like this file used for generating the API file https://github.com/opensearch-project/opensearch-js/blob/main/scripts/utils/patch.json and marking as deprecated.


Garages/Visited Cities State/Country Codes Not Showing

Hi there,
So sometimes the formatting of the tool's cities/states/country codes doesnt show up or is a words are added. Mind you i have all map dlcs as of currently at writing this issue.
Can you see how to fix this.

It relies on included dictionaries and not on data in save file. So with mods and newly added cities it became outdated fast.


Add reader with support for secret files

On some platforms such as Kubernetes or Docker Swarm, it's possible to pass sensitive configuration values to containers in files instead of environment variables. This is a good thing, and makes applications more secure.
Using secret files usually means the following dance:

Check for the variable we need in the process environment (so we can override a secret locally, for example).
If it isn't defined, check if a matching secret file exists.
If it does, read it, trim the content, and return that; a fallback, if given, otherwise.

Some software systems also use variables suffixed with _PATH, so instead of passing a password as an environment variable, you can pass the path of a file that contains it. This alters the flow to:

Check for the variable we need in the process environment.
If it isn't defined, check if a variable named {$variable}_PATH exists instead.
If it doesn't, or does not contain a valid filesystem path, return a fallback, if given.
Read the given path, trim the content, and return it.

It would be cool to have a reader available that does those things! In the larger picture, I'm trying to get this implemented in Laravel (see the related feature request).
Happy to provide a PR.

Hi @GrahamCampbell
Thanks for your great project, I just want to inform you that I'm ready to implement this.
If you have a plan for it just let me know.

Any update on this?

Just in case, I'd like to offer my help again; we're running a few bigger Laravel deployments relying on environment variables read from secret files, and I have experience in DevOps and cloud deployments, so if there are any concerns over the broader impact of this feature, I'm happy to chip in.


inference demo error

When I followed the steps to build, there were these errors. Please help to solve them. Thank you very much

Hi @ahdxwg,
From the error logs, it looks like something is wrong with the path when you compile the project. Could you try to move the workspace somewhere else? (e.g., with English characters)

Thank you very much. I have solved the problem.

Glad to hear the problem is solved. I will close this issue then.


[Help] i want to reload all data when click button

Any updates on this? Solution?

You can use statemanager.notifyListeners() to reload


Add Carp::Clan requirement to cpanfile

Description
Carp::Clan has been used in ReurnErrors.pm since at least 104 but wasn't in cpanfile. It seems something used to pull in that dependency transitively for some other purpose so the problem wsan't seen, but now it doesn't (presumably a 3rd-party change in the dependency tree for a package we use), so that dependency needs to be in cpanfile for the server to start up.
This PR is to align 106, as per PR #507
Use case
Describe the problem. Please provide an example representing the motivation behind the need for having these changes in place.
Benefits
Please, see #507
Possible Drawbacks
None
Testing
No changes
Changelog
N/A

Coverage remained the same at 44.354% when pulling e25858d04a53ca377b84905f0ac918f5c4f19eee on sgiorgetti:bugfix/carp-clan into cba0cce80990379207926e92a80888e2afbf9c2b on Ensembl:release/106.


Add kwarg for angle style

Addition of angle_style kwarg to specify if angles should be fixed or harmonic.  Right now, I'm trying to figure out how to test this feature.  I initially added this as a kwarg for some of the tests with the methane molecule, but I don't think OPLS methane is supposed to have fixed angles.  As a result, the simulation fails.

The NVT example now runs a simulation of a water system now rather than a methane.  The reason is so that the angle_style kwarg could get tested.
A FF xml for SPCE is contained in ff_files and the path of any xml contained in that directory can be grabbed from utils.get_ff.get_ff_path().
I would like to clean this up a little more and add a couple more tests before serious review.

I would like to clean this up a little more and add a couple more tests before serious review.

Can we get this ready to go in the next couple of days?

Should be ready for review now.  In my most recent commit I added a conditional in write_mcfs that checks that the angle_style is valid.  I also added several tests in test_writers.py.


Mac OS X 64 Bit not working

Hello!
I was attempting to download the Mac OS 64 bit installer and it took me to an error page.

Steps to recreate:
FYI: Tried to install it while using and not using IBM vpn.

https://cloud.ibm.com/docs/cli?topic=cli-install-ibmcloud-cli

started by clicking on "ibm-cloud-cli-releases"

Click on Mac OS X 64 Bit
Arrived to error page as shown in the secon screenshot

The download seems to be working now, thank you!


Stale wording in User Namespaces page

This is a Bug Report

Problem:
https://kubernetes.io/docs/concepts/workloads/pods/user-namespaces/ currently reads:

Please note that containerd v1.7 supports user namespaces for containers, compatible with Kubernetes 1.27. It should not be used with Kubernetes 1.27 (and later).

I was involved in suggesting that text. What I'd hoped was that we'd revise it ahead of the v1.27 release. It looks like that didn't happen - oops!
Proposed Solution:
Amend the text of https://kubernetes.io/docs/concepts/workloads/pods/user-namespaces/ to explain what container runtimes can (or can't) work with K8s v1.27 in user namespace mode. Aim to make the explanation also stay relevant past the v1.28 release.
Page to Update:
https://kubernetes.io/docs/concepts/workloads/pods/user-namespaces/

Additional Information:
/sig node

/language en
/triage accepted

please assign  it to me i can solve this issue

/assign

Anyone who'd like to open a PR with a fix is welcome to. It's polite to co-ordinate with other contributors who may be working in the same area.

/cc @rata

/triage accepted


Sagemaker usage

Describe the problem
FYI I already use Sagemaker in order to train and deploy my custom ML models there.
It's not clear to me how to deploy my model to Sagemaker. More specifically, how can I specify my predict function that will be called by the controller?
Additionally, it would be very useful to train my ML models on Sagemaker using the mlflow commands.
Proposal
I'd like to integrate Sagify (https://github.com/Kenza-AI/sagify, it's one of my open source projects) to mlflow so that to train and deploy ML models on Sagemaker. Please, check the workflow that I'd like to add to mlflow:
Proposal for Training and Deploying on SageMaker:

mlflow sagemaker init -d src: This will create all boilerplate code under the directory src where all my ML code lives. My ML code under src uses already mlflow.
Then, I need to implement two functions, train(...) and predict(input_json). The train(...) function should call my ML training logic that already lives under src, and I need to implement my transformer from JSON to an ML friendly data type in the predict(input_json) function.
mlflow sagemaker build: It will build a Docker image that will contains all the code under src
mlflow sagemaker push: It will push the built Docker image to ECS
mlflow sagemaker local-train: It will the training logic that lives in the Docker image. This can be used for testing before trying on SageMaker
mlflow sagemaker local-deploy: It will run the Docker image on deploy mode where I can test the rest endpoint that calls the trained model.
mlflow sagemaker train: It will run the Docker image on train mode on SageMaker
mlflow sagemaker deploy: It will run the Docker image on deploy mode on SageMaker

Proposal Only for Deploying on SageMaker:

mlflow sagemaker init -d src: This will create all boilerplate code under the directory src where all my ML code lives. My ML code under src uses already mlflow.
Then, I need to implement the functionpredict(input_json). I need to implement my transformer from JSON to an ML friendly data type in the predict(input_json) function.
mlflow sagemaker build: It will build a Docker image that will contains all the code under src
mlflow sagemaker push: It will push the built Docker image to ECS
mlflow sagemaker local-deploy --model-path=<model_path> --run-id=<run_id>: It will run the Docker image on deploy mode where I can test the rest endpoint that calls the trained model.
mlflow sagemaker train: It will run the Docker image on train mode on SageMaker
mlflow sagemaker deploy --model-path=<model_path> --run-id=<run_id>: It will run the Docker image on deploy mode on SageMaker

Please, let me know about your thoughts. I'm thinking to proceed for the Proposal Only for Deploying on SageMaker.

The deploy into Sagemaker is currently done via PyFunc model flavor with high level wrappers available for  sklearn and Tensorflow and Spark ML lib coming in next release.
If you want to deploy non-python models we will have similar code for other languages and we would appreciate any contribution.
If you are deploying python models and PyFunc interface does not work for you, could you provide feedback on what it is missing?


Navigating from detail page to another, duplicates page title

Using FreshMasterDetailPageNavigation, Main menu page not showing, nor detail menu title.
When moving from one detail page to another, page header/title gets pushed on top of previous one, persists with each switch

Reverted navigation in app back to TabbedNavigation, issue no longer valid