Pipeline failing on plan

Describe the Bug
When the pipeline runs it consistently fails on the terraform plan step with the following error message:
Error: Failed to upload configuration files: failed copying file "/home/runner/work/nr-forests-access-management/nr-forests-access-management/server/backend/venv/bin/python" to archive: archive/tar: write too long

Expected Behaviour
The pipeline should execute without error on terraform plan
Actual Behaviour
Package is successfully being built but when it gets deployed it is failing... see error message above ^
** Steps To Reproduce**
Steps to reproduce the behaviour:

create a pull request
the pull request will trigger the pipeline action
the build action will fail on the terraform plan step

Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

n/a

Additional context
The following are links to failing PR error logs:

https://github.com/bcgov/nr-forests-access-management/actions/runs/3103150056/jobs/5026162760
https://github.com/bcgov/nr-forests-access-management/actions/runs/3100302816/jobs/5020427633
https://github.com/bcgov/nr-forests-access-management/actions/runs/3100475136/jobs/5020798706

See: https://github.com/bcgov/nr-forests-access-management/pull/201
Resolves the PR pipeline errors, however identifies that the same fix needs to be applied to the push.yaml action


Adding tokens/ERC20/PreserveBalancesOnTransferToken.sol

🚀 Description
Adding files:

contract/tokens/ERC20/PreserveBalancesOnTransferToken.sol
test/tokens/ERC20/PreserveBalancesOnTransferToken.test.sol

What is PreserveBalancesOnTransferToken?
Please see this Rationale with example here - https://medium.com/thetta/how-non-blocking-votings-work-in-thetta-46706f05b382
PreserveBalancesOnTransferToken can be used to preserve the ERC20 balances after some EVENT happens (voting is started, didivends are calculated, etc) without blocking the token transfers! Please notice that EVENT in this case has nothing to do with Ethereum events.
 * Example of usage (pseudocode):
 *   token.mint(ADDRESS_A, 100);
 *   assert.equal(token.balanceOf(ADDRESS_A), 100);
 *   assert.equal(token.balanceOf(ADDRESS_B), 0);
 *
 *   uint someEventID_1 = token.startNewEvent();
 *   token.transfer(ADDRESS_A, ADDRESS_B, 30);
 *
 *   assert.equal(token.balanceOf(ADDRESS_A), 70);
 *   assert.equal(token.balanceOf(ADDRESS_B), 30);
 *
 *   assert.equal(token.getBalanceAtEvent(someEventID_1, ADDRESS_A), 100);
 *   assert.equal(token.getBalanceAtEvent(someEventID_1, ADDRESS_B), 0);
 *
 *   token.finishEvent(someEventID_1);
 */

How do we use that in Thetta?
Please see  https://github.com/Thetta/Thetta-DAO-Framework/blob/dev2/contracts/tokens/StdDaoToken.sol
We need PreserveBalancesOnTransferToken because we should not block transfers when new voting is started.
p.s. Also, i don't like the name of the PreserveBalancesOnTransferToken, but still has no other ideas((
Maybe NonBlockingToken?
===

[x] 📘 I've reviewed the OpenZeppelin Contributor Guidelines
[x] ✅ I've added tests where applicable to test my new functionality.
[x] 📖 I've made sure that my contracts are well-documented.
[x] 🎨 I've run the JS/Solidity linters and fixed any issues (npm run lint:all:fix).

Hi @AnthonyAkentiev, thanks for your contribution! We already have something along these lines in progress (#991), would that suit these needs?

Hi, @nventuro.
I’ve updated the source code and added SnapshotToken to get balances easier!
So now we have 2 usage scenarious:
One
PreserveBalancesOnTransferToken token;

token.mint(ADDRESS_A, 100);
assert.equal(token.balanceOf(ADDRESS_A), 100);
assert.equal(token.balanceOf(ADDRESS_B), 0);

SnapshotToken snapshot = token.createNewSnapshot();
token.transfer(ADDRESS_A, ADDRESS_B, 30);

assert.equal(token.balanceOf(ADDRESS_A), 70);
assert.equal(token.balanceOf(ADDRESS_B), 30);

// see here. snapshot is ERC20 compatible, but transfers are locked
assert.equal(snapshot.balanceOf(ADDRESS_A), 100);
assert.equal(snapshot.balanceOf(ADDRESS_B), 0);

token.stopSnapshot(snapshot);

Two
PreserveBalancesOnTransferToken token;

token.mint(ADDRESS_A, 100);
assert.equal(token.balanceOf(ADDRESS_A), 100);
assert.equal(token.balanceOf(ADDRESS_B), 0);

uint someEventID_1 = token.startNewEvent();
token.transfer(ADDRESS_A, ADDRESS_B, 30);

assert.equal(token.balanceOf(ADDRESS_A), 70);
assert.equal(token.balanceOf(ADDRESS_B), 30);

assert.equal(token.getBalanceAtEvent(someEventID_1, ADDRESS_A), 100);
assert.equal(token.getBalanceAtEvent(someEventID_1, ADDRESS_B), 0);

token.finishEvent(someEventID_1);

Yes, seems like in #991 is about the same. I haven't seen it when we started to implement the  PreserveBalancesOnTransferToken :-(
However, we have a different design and i think that our implementation (+tests, +code coverage, etc) is little better. How to deal with that? Is there any way we could move forward with the code review?
p.s. I will fix the build little bit later (within 1-2 days)

@frangio Thx for the reply.

There is no arbitrary limit to the number of snapshots in #991, like the limit of 20 concurrent events here.
I can refactor the code so that no limit will be set.

The idea of the auxiliary SnapshotToken included in this PR is quite interesting, but I'm not sure it's actually needed. Did you find any practical situations where you need to expose past balances through an ERC20 interface?
Yes, this is a mandatory feature (in case of our DAO Framework for example). You can pass this snapshot token to any method/contract that is ERC20-compatible-only and get the balances right at the time event is started. There is no need to pass any interface and rewrite the code. Just pass an address of the Snapshot and everything will work fine. I think that it's great and simplifies everything. Under the hood code is a bit more complex of course, but the clients will not see that.

So what we have now:

991: no tests, code is not ready, no SnapshotToken, has no limit, no burn()/mint() support, little bit simpler
1100 (this): good tests, code is ready, SnapshotToken (what is think is a good feature), has limit of 20. Also we have code for mint() and burn() that is compatible with snapshotting.

Of course guys from 991 can add tests and improve the code.
And i can remove the limit and simplify things.
So comparison will be then like this:

991: no SnapshotToken but started earlier.
1100: SnapshotToken and started a bit later.

So if comparing like that, is there any possibility so that i should continue the 1100 and fix everything?
I think that SnapshotToken worth it?
Thx!

@frangio Ah, you are the 991 creator?
No stopSnapshot in 991
Also, i wanted to say about the limit to 20 snapshots. This is just in order to reduce gas costs.
I see that you use 'binary search' that still need while() loop to move through all snapshots.
Still, i can eliminate the magic number 20 and allow infinite snapshots just like in your case.
Still:
In my implementation you can stop the particular snapshot by calling stopSnapshot and that will make sure we don't spend gas for unused anymore snapshots. In your implementation you CAN NOT stop the snapshot from updating (as far as i understood). Just imagine your token and 5 years of snapshotting. We will end up with 100500 snapshots that will eat gas in your case, because you don't have the stopSnapshot method.

I see that you use 'binary search' that still need while() loop to move through all snapshots.

The loop doesn't move through all snapshots. Because it's a binary search it will only move through O(log(snapshot count)) snapshots, and in practice it will be much lower than that. Crucially, though, this relatively expensive loop is only done in the special function balanceOfAt, whereas the normal ERC20 operations have only a constant overhead compared to the standard token implementation:
https://github.com/OpenZeppelin/openzeppelin-solidity/blob/61d16d6998055de79570558b717314e00d9bcbc2/contracts/token/ERC20/SnapshotToken.sol#L54-L59
I went through your implementation in more detail. It potentially loops over all snapshots in every transfer operation, which is why you initially capped it to 20. Removing the cap is not a good idea because the loop can eventually become arbitrarily large resulting in prohibitive gas costs for using the token. The cap was the right choice for this implementation, but while it may be enough for a particular use case, it's not quite enough for a general-purpose library like OpenZeppelin.
The point about minting and burning is a good one. There was no way for #991 to correctly handle that, but after #1197 is merged it will be simple to fix because of the new internal _mint and _burn functions.
I can't deny that #991 is way behind this PR in terms of tests and documentation. But unfortunately there is problems in the implementation here that I think will be too much work to fix compared to taking #991 to completion.
I'm closing this because of everything explained. Thank you for taking the time to contribute, regardless!

@frangio Thank you for the reply.
Still i don't agree with you and think that our implementation is better (it REMOVES the unused snapshots from the array, supports parallel snapshots, has SnapshotTokens, test are ready, _mint and _burn already supported, etc).
Ok, we will just continue to use our code and it will be the part of the Thetta DAO Framework.
I hope that your decision is not based of "politics" but only on the technical side. Still looking forward for cooperation.


endpoint not being exposed right

Hi, great work with this library!
I noticed a minor bug in the expose function endpoint always being '/metrics'.

Thanks for raising this issue, fixed with https://github.com/trallnag/prometheus-fastapi-instrumentator/releases/tag/releases%2F5.3.1


Delete DatastoreTM and most other references to Datastore

This change is

this push only fixed merge conflicts in ExpandRecurringBillingEventsAction*


⚠ Secret Website 3 has degraded performance

In 79b8d5f, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 2630 ms

Resolved: Secret Website 3 performance has improved in a99d3b3.


What about docs?

hey there, I wonder what we should do for documentation on this project. Any thoughts???

[  ] item1

So what you're saying is that we should

[  ]   Create a 'docs' folder
[  ]   Create a new 'index.md' document
[  ]   Turn on Github Pages
[  ]   Decide if we want to go with sometime more complex

@hemu5678  hi there


Fix bug where users could edit policies and roles of other communities

Fix a bug where users could manipulate IDs in the query string (like https://policykit.org/main/editor/?type=Platform&operation=Change&policy=3) to view and edit policies from other communities. This updates all views to check that the document being requested belongs to the community that the user is logged in to.

Thanks for catching this!


enable esm transpilation - fixes IE11 compatibility.

4 releases since this PR went up, any feedback @krisk?

Isn't this just a config setting and pull request sets this IE11 compatibiliuty "on by default"?
Just wondering if this should be a documentation issue or considered a bug.

Any update on when this would be merged and released?

Could you not simply pull in fuse.common.js? See here

Could you not simply use fuse.common.js? See here

this would work for old webpack / browserify, but not for anything modern that uses the ESM output (i.e, webpack2, angular cli, react etc. )

It would be awesome to have a way to use the latest Fuse in IE11. Any chance we can get it?

@krisk
Hi, I'm using fuse.js, and great library, thanks!
And I'm facing ie11 build problem. I know I should use fuse.common.js, however I'm using with Next.js x TypeScript.
So there is no type definitions in fuse.common.js, So I suggest you two ideas.

Merge this pr
This is most easiest way, but bundle size will be larger than now, and ie11 will be disappear soon (1 year or more...).

Create esm for ie11
This way is so clever, react-hook-form is doing. For example,

import Fuse from 'fuse.js' // this is support except ie11
import Fuse from 'fuse.js/dist/fuse.ie11' this is support also ie11

If you adopt this way, normal bundle size will be same, and if ie11 disappear, you should remove as soon as possible.
If you think this way is good, I will make pr.
Thanks.

@krisk will @Qrymy suggestion work?

Could we get this merged in by any chance? :)


Final Merge to Production : GSSoC'2024 🚀

Thanks to all the Contributors :)
Project Admin,
Pooranjoy <3

🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀


add API for re-using prepared statement

This was added in https://github.com/vapor/postgres-nio/pull/15


Incorrect prop name spelling

Hey @bvaughn (and the rest of contributors), first of all — thanks for all the time you've spent building this great set of tools, really appreciate your work. 👍
However, it seems that there's a minor issue with InfiniteLoader's treshold prop name: it's spelling is incorrect, according to most of the dictionaries (e.g. https://www.merriam-webster.com/dictionary/threshold). Not a major issue, but it constantly gets my IDE's spellchecker started. :)
Thanks again!

Hm, where is this typo? Searching the project for the text "treshold" doesn't yield any results. And looking at InfiniteLoader and its doc page show "threshold" (the correct spelling).

Whoops, I hit close before I meant to. (I did mean to close the issue, but not before explaining why.)
Searching this repo for mention of the term "treshold" (results here) yields no matches. So I assume this bug report is a mistake. 😄 Please point me at the offending code if not!

Oh, I'm so sorry — looks like it was actually my own typo. Such an embarrassment, I've even checked the documentation before posting this. Anyway, thanks for your attention — turns out you were right to hit close right away lol.

No worries 😄


Update http4s-circe, http4s-dsl to 0.23.17

Updates

org.http4s:http4s-circe
org.http4s:http4s-dsl

from 0.23.12 to 0.23.17.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.http4s" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "org.http4s" }
}]

labels: library-update, early-semver-minor, semver-spec-patch, commit-count:1

Superseded by #612.


Clicking actions drop button in sl-grid is opening details panel

Clicking actions drop button should never open the details panel. Please see [video] (http://recordit.co/lcslk39klo)

Closing issue, it's isolated to my branch.


Missing anatomical statistics reports when finished

Question/Support Request
Hi FastSurfer experts,
I ran FastSurfer through Docker and attempted to obtain the cortical thickness in ROIs. However, the output directory of /subject/stats is empty, but the other outputs seem OK as what they are expected. I am not so familiar with FreeSurfer, so I want to ask if there is a way to get those stats report?
Environment

FastSurfer Version: deemi/fastsurfer:gpu-v1.1.1
OS: Ubuntu 20.04 LTS
CPU: Intel Core i5-9400F CPU @2.90GHz
GPU: Nvidia GTX 1660

Execution
docker run --gpus all -v /media/lqj/PUS4T/PickUpSam/NIFTI_BIDS/sub-01/anat:/data
-v /media/lqj/PUS4T/PickUpSam/NIFTI_BIDS/sub-01/anat:/output
-v /media/lqj/PUS4T/openNeuron_ds002748/derivatives:/fs_license
--rm --user 1000 deepmi/fastsurfer:gpu-v1.1.1
--fs_license /fs_license/license.txt
--t1 /data/sub-01_T1w.nii
--sid sub-01 --sd /output
--parallel --vol_segstats | tee /media/lqj/PUS4T/PickUpSam/NIFTI_BIDS/sub-01/anat/fs_log.txt
FastSurfer log - acquiring from the terminal
The running log was in attachment, please check.
FS_log.txt

Hi, you can try dropping the --vol_segstats flag (which is mainly used when running segmentation only, i.e. only the CNN, and you still want to get volume segmentation stats with the corpus callous added). Still that is probably not the problem here.
Can you attach log file that is written under /stats/recon-surf.log ? thanks

Hi @QunjunLIANG.
Did you let FastSurfer run through to the end? Your log file indicates that it had not yet reached the anatomical statistics computation step. Once that is executed, you should find stats/{rh/lh}.aparc.mapped.stats (which is probably what you need).
Side note: Although you do not need --vol_segstats, it is strange that your stats directory is empty; in this case, it should contain aparc.DKTatlas+aseg.deep.volume.stats.

Maybe ran out of disk space?

Thanks for your kind help.
I re-ran the FastSurfer docker this mooring with the recommended command (ignore --vol_segstats). But the output stats/ directory was still empty as that in yesterday.
The free space in the running disk is 1.6TB, and the total memory of the GPU is 6144MB. I uploaded all files in the script/ directory in attachment, hope these would be helpful to locate the problem.
Thank you for your time and support.
Attachment

The FastSurfer-running log obtained from the terminal.
fs_log.txt

The document tree of the output directory, obtained with Linux 'tree' command.
document_tree.txt

A zip contains all files in script/ directory.
scripts.zip

Thanks for your kind help.
I re-ran the FastSurfer docker this mooring with the recommended command (ignore --vol_segstats). But the output stats/ directory was still empty as that in yesterday.
The free space in the running disk is 1.6TB, and the total memory of the GPU is 6144MB. I uploaded all files in the script/ directory in attachment, hope these would be helpful to locate the problem.
Thank you for your time and support.
Attachment

The FastSurfer-running log obtained from the terminal.
fs_log.txt

The document tree of the output directory, obtained with Linux 'tree' command.
document_tree.txt

A zip contains all files in script/ directory.
scripts.zip

The log-file unfortunately does not contain an appropriate error message. Is this really the $SUBJECT/scripts/recon-surf.log file or the file you pipe the output to (with tee in the first command you provided)? The recon-surf.log should contain the error message.
Based on the file tree, it looks like the process is failing in the parallel hemi generation part, specifically when creating the aparc annotations (https://github.com/Deep-MI/FastSurfer/blob/v1.1.1/recon_surf/recon-surf.sh#L663, aparc.DKTatlas.mapped.prefix.annot is missing in label directory).
Without the error message, it is hard to know why it fails, so make sure you attached the recon-surf.log.
You can try to run the (potentially) offending command alone (if you have FreeSurfer installed and a local copy of the DKTatlaslookup.txt -> here I assume it is in FASTSURFER_HOME/recon_surf, https://github.com/Deep-MI/FastSurfer/blob/v1.1.1/recon_surf/rh.DKTatlaslookup.txt):
export SUBJECTS_DIR=/media/lqj/PUS4T/PickUpSam/NIFTI_BIDS/sub-01/anat
hemi=rh #or lh
subject=sub-01
mris_sample_parc -ct $FREESURFER_HOME/average/colortable_desikan_killiany.txt -file ${FASTSURFER_HOME}/recon_surf/$hemi.DKTatlaslookup.txt -projmm 0.6 -f 5  -surf white.preaparc $subject $hemi aparc.DKTatlas+aseg.orig.mgz aparc.DKTatlas.mapped.prefix.annot

Thank you for your timely reply. I re-ran the docker without using the --parallel and the error report was finally out. The --parallel option may suppress the writing of the error on the log.
In the log, it wrote that "RMS increased, rejecting step" when entering MRISpositionSurface(). The recon-all log in subject/script/ was in attachment. Please let me know if there's any further information I can provide.
recon-all.log
Thanks in advance.

Ok, thanks. The recon-surf.log should contain an appropriate error message when sth fails in parallel mode. @AhmedFaisal95 @agirodi please look into this.
Do the segmentation (aseg.presurf.mgz), wm.mgz and original surface (lh.orig) look ok?

Thank you for your timely reply @LeHenschel.
I checked the output images, including atlas segmentation and lh.orig with freeview, and they look fine in visual. Here's the screenshot of the freeview. Please check.

And I also uploaded the document tree in subject/ directory, hope this would help.
document_tree.txt
All the best.

Is it possible for you to share the image in question with us?
Based on the error, it looks like something is wrong with the surface generation. The segmentations look ok and the surface as well based on the screenshots. Is this the only subject that fails?

From your provided logs it seems that the problem arises when the two sub-processes for each hemisphere gets interrupted/killed by something and the surface pipeline stops completely at that point (which is before the computation of the stats). That something, that sends a kill signal, is most probably your system, since our script doesn't seem to do it. It could be a lack of RAM or some limitations of resources by your system/administrator.

Hi @LeHenschel and @agirodi ,
Thank you very much for your help. To fix the limitation of the RAM, I extended the SWAP from 2 GB to 8GB and reran FastSurfer with the same subject's data. As a result, the analysis finished without error reported in the recon-all.log. Please check down below:
recon-all.log
However, there seems still some difference in the outputs, comparing with that generated by FreeSurfer. I attach the document tree from FastSurfer and FreeSurfer directory, please check down below:
document_tree_FastSurfer.txt
document_tree_FreeSurfer.txt
I called the FreeSurfer from the latest fMRIprep docker, version 7.2.0. Thus, I would like to ask if the gap between the outputs due to an potential error or the custom pipeline in the fMRIprep?
In addition, I upload the T1 image and its metadata (.json) on the Google Drive. Please download them with the following URL:
https://drive.google.com/file/d/1ri5tDu3z9wAi5QO_kwFQLfXfkLXliWui/view?usp=sharing
https://drive.google.com/file/d/1vhAQjAMd7sy9eIxoBlsZtctn9Z0A1YVg/view?usp=share_link
Thanks in advance.
Best,
Qunjun

I see. 2GB is too little to run FreeSurfer (https://surfer.nmr.mgh.harvard.edu/fswiki/SystemRequirements), so increasing it to 8 GB is a good call. Glad that it is working now.
With respect to the differences between FreeSurfer and FastSurfer directories:
FastSurfer provides FreeSurfer like outputs. We only segment one atlas (DKTatlas) with the CNN. This is the reason for the differences you see in the directories. Are you interested in a specific file or atlas that is not present?
Also the output of the recon-surf.log is the important one. If that ran through without error, you can be sure that all files we provide are there.

I run your image on our system and the output seems completely normal. Everything is there (I compared with the directory-tree of another image) and the segs/surfaces seem to be okay as well.
Comparing your directory tree and ours did not raise any differences.
tree_7.txt

https://github.com/Deep-MI/FastSurfer#system-requirements also describes our system requirements (in case someone else finds this thread). I think this issue is solved and can be closed, if not let us know.


Allow different verbosity levels per MET tool

Currently we have LOG_MET_VERBOSITY to control the verbosity level for all MET tools. Perry suggested that we be able to change the verbosity level for a single tool so we can see more information on a tool that is failing without cluttering up logs with output from tools that are not failing.
We could keep this variable, but also have different variables for each wrapper to override this value for that wrapper.
LOG_MET_VERBOSITY = 2
POINT_STAT_LOG_MET_VERBOSITY = 7
This would use 7 for running PointStat, but use 2 if running another app like GridStat.

This exists starting in METplus 3.0 beta1


Hope add the special-method automatic completion

I found some special-mathod didn't give the automatic completion, such as __enter__ , __exit__ , etc.

I always rely on the automati completion to ensure correctness, so I hope pylance can provide the function.
The information for special-mathod is at https://docs.python.org/3/reference/datamodel.html#special-method-names

Those methods are not included in the auto-complete list because they are not found anywhere in the Foo object hierarchy, whereas the others are (since they are methods provided by the base class object).

But it's important for uers to build the individuation class.

You can get this completion by inheriting from the appropriate ABCs:

from typing import ContextManager
# or
# from contextlib import AbstractContextManager

class Foo(ContextManager[int]):
    def __enter__(self) -> int:
        return super().__enter__()

Thanks @hrmorley34  for the input.


CircleCI config fixes

Issue link

https://github.com/tasitlabs/TasitSDK/issues/74
Types of changes

Bug fix (non-breaking change that fixes an issue)
Meta (a change that affects future changes to this repo)
Technical debt (a code change that doesn't fix a bug or add a feature but makes something clearer for devs)

@marcelomorgado Can you take a look at this? I'm getting this error: Error: Cannot find module 'strip-ansi'
https://circleci.com/gh/tasitlabs/TasitSDK/7

@marcelomorgado FYI I reopened this because I think we still want some of the changes from this PR - your PR was set to auto-close this one (which may or may not have been intentional?).

@marcelomorgado FYI I reopened this because I think we still want some of the changes from this PR - your PR was set to auto-close this one (which may or may not have been intentional?).

I've tought that only image node version will solve the problem. I've should use refs instead closes. Sorry, I'll work on that using my branch + circle ci.

No worries! I think the node version did solve the main problem, but all of the the changes here are either syntax improvements for yaml or leverage lerna better, so we might as well have them too. Thanks!


Branded string literals cannot be used in the computed property name of a type

🔎 Search Terms
type branding, nominal types, nominal typing
🕗 Version & Regression Information
Does not seem like a regression.  I've reproduced it in TS 5.4.2 and 4.8.4
⏯ Playground Link
https://www.typescriptlang.org/play?#code/PTAEBUAsEsGdQO4HsBOBrWAuUBDUsAXFaAOwHMBaAG2gIFMUcrQBjJEwnEg1r0AIzqgArrDoATUKVAFIQtgFsADsPqSlKJEoYEAnqBI4FQpADNcM3dtDi6LKjkYFo7AFCnhJFs-b5oyqjoAdVQ0UjIAYRwxAAoASlAAb1dQVNZ2QnSOAgA1JlAAXlAAIgAPXQAvYoBuVxS0vWsAVUKk+rS0gG02bLyqAF1sImE6dtAAX1rxutcQCBh4cSQ6eAA5AHlwRFCAGlwqWSRhMkgZBazObn3YJFBIaItTaFKJfCJw6loGfIA3JhGzjgeHBQGgSEgECRcDxFEpoIEZP5Rh4vD4ofxjlFYglkh0epl+IwSLZxBEMrkmNgypViqAAGRJAD6jNMSCQmAAjONUkVqVVcPAuLpamNGkIWkVcR0uoSuCSyb0mIMZCgRmNJq5pnU5gAFRzOfIhdCOI7E7AoOjRWDQMhQgi3PDgkgUWXE174ghcHiEYjkT70RjMMXuTzeFxQ5DGzSecQc+JtPHkgRE+XkvpU8r8hmJZms9lcnklTO0h5CkWJ7IiEiu1NKXQZmmtGsSBWEPrlhpWcWtKXS0CdTzN0laXTK4ajDoarWzMBQEF-YhA8O4H5IaDieAW7RL8hnIQ+8KgGgBpgh1HLyNoE0xgBM8d7Fx4OQAggAZVp8mpjD3JuUttOUpY2hmKAL7vtmuZspy3KtGBAq4CQwp1B0YqgBKCZ9v2YFjqqE5pFOrhAA
💻 Code
// This works: a string-literal constant can be used in the computed property name of a type declaration
function simpleWorkingCase() {
    const constVal = "xyz";

    type U = {
        [constVal]: true  // works
    };
}

// This does NOT work, although this constant also has a fixed string-literal value that is known at compile time
function bugCase() {
    const brandedConstVal: "xyz" & {__foo:1}  = "xyz" as any;

    type U = {
        [brandedConstVal]: true  // ERROR!
    };
}

🙁 Actual behavior
The second case gives compiler error ts(1170):

A computed property name in a type literal must refer to an expression whose type is a literal type or a 'unique symbol' type.

🙂 Expected behavior
Since the brandedConstVal still has a literal value that is known at compile time, it should work as a computed property name too.
This is a little weird, since in reality it's impossible for any object key to be itself an object containing fields (the __foo "brand" marker in this example).  But the compiler already ignores that impossibility in allowing type declarations like string & { ...whatever ... } in the first place – a useful trait in light of the nominal typing behaviors it enables.  Since that is already supported, computed property names should ideally work consistently with it as well.
Additional information about the issue
The Playground link also illustrates a workaround (with two variations).
The workaround isn't ideal however.  For example, if type U is being declared in a different module from brandedConstVal, that module would have to now export two copies of the const (brandedConstVal plus the unbranded copy VAL) – which is potentially more confusing for all clients of the module.

I'm also seeing some strange behavior with mapped object types: Playground link
In this case there's

(a) the tooltips for MappedType vs. keyof MappedType disagree with one another about what keys are present in the type! (the former says there are no keys, the latter lists the branded string as a key)
(b) loss of expected type-checking behavior (type checking behaves as if there are no keys, agreeing with the empty tooltip for MappedType)

Seems like these issues probably has the same root cause, but please let me know if you'd rather I break that out as a separate GH issue.

Another oddity: the original bug above is that branded string constants can't be used as a computed property name in a type declaration. Branded string constants can however be used as a computed property name in an object value – but those strings are not correctly matched against plain/unbranded identifiers when type-checking:
function bugCase() {
    const brandedConstVal: "xyz" & {__foo:1}  = "xyz" as any;

    type U = {
        xyz: true
    };
    const u: U = {  // ERROR: Property 'xyz' is missing in type '{ [x: string]: boolean; }'
        [brandedConstVal]: true
    };
}

...this despite the fact that branded string constants are assignable to matching plain/unbranded string types, outside the context of object keys:
function counterpoint() {
    const VAL = "xyz";
    const brandedConstVal: "xyz" & {__foo:1}  = "xyz" as any;

    let foo: "xyz" = VAL;
    foo = brandedConstVal;  // works!
}

More detailed Playground of this here.
So overall, it seems there's a general issue with branded string constants used as keys in object types.  It's not totally disallowed to use them as keys, but you get a lot of undesirable type-checking behavior that is sometimes looser than you want (see my previous comment) and sometimes stricter than you want (original report plus this comment).

Since the brandedConstVal still has a literal value that is known at compile time, it should work as a computed property name too.

I'm not clear on what the alleged bug is here.
The error about the branded type not being a well-formed string name is a legitimate choice IMO. A branded type isn't a string type and there are architectural reasons why we need to be able resolve these without performing any type resolution. Once we open the door for anything but a bare string type, there are tons of new inconsistencies that would appear -- we can't remove this line between readily-resolved types and non-readily-resolved types, so the line has to be somewhere, and putting the line at "really, a string literal" seems like by far the least inconsistent and clearest behavior.
In value space there are different rules because, well, values aren't types, and we have to do something in most cases.
The behavior in this example
    type MappedType = { [k in typeof brandedConstVal]: true }; // {}  --> no keys are listed!
    type MappedKeys = keyof MappedType; // '"xyz" & {__foo:1}'  --> but key IS listed here!

is admittedly odd but sort follows from the definition of a homomorphic mapped type. It doesn't create an unsoundness, though:
    type MappedType = { [k in typeof brandedConstVal]: true }; // {}  --> no keys are listed!
    type MappedKeys = keyof MappedType; // '"xyz" & {__foo:1}'  --> but key IS listed here!
    let s: MappedKeys = null! as any;
    const test: MappedType = { foobar: 99 };
    const p = test[s];
    //          ^ error, can't do that


Question about backbone

Hello,
Congratulations on the great work. I have some questions on the backbone used.

Was it pretrained and frozen for feature extraction? Or was it fine-tuned in a supervised fashion on the self-supervised pretrained features (looks like the latter)?
If fine-tuned, did you unfreeze all layers or few layers only? Did you do an ablation on how many layers to unfreeze?
Did you try to use the frozen features and see how it yields with respect to localization? It would be helpful if you could throw some light on these?
Why did you choose SimMIM, for e.g., why not MAE? Did you try and find out SimMIM works better?

I am sorry if I ask any redundant question. It would be helpful to have some insights into these aspects.
Thanks a lot, again!

We will release the source code soon.

@MLDeS

The backbone is fine-tuned.

We unfreeze all layers by default and do not try to freeze some layers.
Nonetheless, we employ a learning rate decay strategy for mask-image-modeling (MIM) pre-trained models, a technique commonly used when fine-tuning MIM models. This strategy assigns a smaller learning rate to the shallower layers and a larger learning rate to the deeper ones, following the formula lr = base_lr * decay_rate ** (num_layers - layer_depth), where the decay_rate is less than or equal to 1.
By adjusting the decay_rate, we can potentially achieve an effect similar to freezing some layers.

We have not yet evaluated the performance of frozen features within the DETR framework.
In a previous study(paper), we examined the use of frozen features for downstream dense tasks and compared different pre-training methods. We discovered that the performance of MIM frozen features was subpar, but this could be a result of poor classification. We would evaluate their localization performance later.

We use Swin Transformer as backbone and SimMIM provides pre-trained Swin Transformer checkpoints.


US929026: Updated to run on Java 21

Ticket: https://internal.almoctane.com/ui/entity-navigation?p=131002/6001&entityType=work_item&id=929026

A developer build has not yet been created for this branch. Click here to go ahead and create the build...

CI Build Link:
https://sou-jenkins2.swinfra.net/job/CAFapi/job/CAFapi~opensuse-opensearch1-image~US929026~CI


Cookbook doesn't seem to pick up bootstrap'd "environment"

I'm trying to set a client's environment during bootstrap, and when running the chef-client cookbook I would expect to see this environment in the generated /etc/chef/client.rb (similar to how the chef_server_url shows up there). Furthermore the README says this should be the recommended way of setting the environment:
node['chef_client']['environment'] - Set the node's environment directly (e.g., knife bootstrap -E), as it makes it easier to move nodes to different environments.

However looking at this cookbook's default attributes, it doesn't seem to pick up environment:
# We only set these by default because this is what comes from `knife
# bootstrap` (the best way to install Chef Client on managed nodes).
#
# Users can add other configuration options through attributes in
# their favorite way (role, 'site' cookbooks, etc).
default['chef_client']['config'] = {
  'chef_server_url' => Chef::Config[:chef_server_url],
  'validation_client_name' => Chef::Config[:validation_client_name],
  'node_name' => Chef::Config[:node_name] == node['fqdn'] ? false : Chef::Config[:node_name]
}

if Chef::Config.has_key?(:client_fork)
  default['chef_client']['config']['client_fork'] = true
end

Wouldn't it make sense to add "environment" under the default['chef_client']['config'] so it picks it up from bootstrap? Right now I'm stuck having to populate it with my wrapper cookbook around chef_client, which makes moving to another environment difficult...
Thanks!

The docs are probably subtly wrong. You would set node['chef_client']['config']['environment']. Can you test that and see if the README just needs to be updated?

Hey,
Sorry maybe I wasn't clear :)
Setting node['chef_client']['config']['environment'] in a wrapper cookbook does end up populating the client.rb file, yes.
However the README seems to imply that node['chef_client']['environment'] is deprecated, because the chef-client cookbook is supposed to automatically pick up the running environment.
For example, when I bootstrap my node and give it a server URL, that server URL automatically ends up in my client.rb. I don't need to explicitly set node['chef_client']['config']['chef_server_url'].
Similarly, my node is bootstrap'd with an environment name already given - why can't client.rb automatically be populated with it? That way I don't have to specify the environment twice - once during bootstrap and once in my wrapper cookbook. I thought that's what the README implied :)
What I will do tomorrow is test changing the chef-client cookbook and adding the line:
'environment' => Chef::Config[:environment],

and see if the environment does get populated automatically.

Got it working with
  'environment' => Chef::Config[:environment] == '_default' ? false : Chef::Config[:environment],

And modifying the client.rb template to only include environment if not false. I re-used the same logic as the node_name.
Would you accept a pull request fixing this?

Yes, but you shouldn't need to modify the client.rb template if you just leave the value as nil instead of false.

I tested that and unfortunately it still inserts "environment nil" in the
client.rb file.
JF
On Feb 11, 2015 6:58 PM, "Julian C. Dunn"<EMAIL_ADDRESS>wrote:

Yes, but you shouldn't need to modify the client.rb template if you just
leave the value as nil instead of false.
—
Reply to this email directly or view it on GitHub
https://github.com/opscode-cookbooks/chef-client/issues/262#issuecomment-73991476
.

Ah yeah, it's probably because this should really get replaced with something like
@chef_config.sort.select {|k,v| !v.nil? }.each do |option, value|
and then refactoring to deal with the value inline... but that's beyond the scope of what you're asking :grin:
So go ahead and submit the PR as-is.


Fix for wrong coordinate format used for polygons

Polygons use an array of an array of coordinates, because they store every ring in a separate array. The type was corrected and functions using it have been adapted.
Furthermore the type hierarchy was checked for all the geometries and corrected where necessary.

Thanks!


Why are there no open issues when all the closed ones are about the same problem (demo doesn't work) and none of them are solved?

If you're not going to provide us with enough information to do the REST stuff without having to download a library, at least make sure the libraries work.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d9565ceb-e636-e815-f7cf-ff9523fabc2f
Version Independent ID: 7c6b3210-d878-0347-27af-199c2c00daa9
Content: Send telemetry to Azure IoT Hub quickstart (Python)
Content Source: articles/iot-hub/quickstart-send-telemetry-python.md
Service: iot-hub
GitHub Login: @wesmc7777
Microsoft Alias: wesmc

@bhjolly Thanks for the Comment. We are actively investigating and will get back to you soon.

Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

That's absolutely valid feedback. there's a huge gap between the functionality of the current python sdk (which barely functions in some very specific configurations/environments) and the expectation of the python developers (run everywhere, batteries included, etc)
Given the current state of the v1 of the python SDK (barely usable) and the fact that a v2 (that is a complete rewrite) is coming, i wonder if there should be something to signal this on these pages. or maybe a link to the section of the readme that explains how to deal with the most commonly encountered error (ImportError).

I started working on this. I was asked to add a notification at the top of each Python-using article. So I did that, and then realized that now I have duplicate and mismatched information in each article. (I haven't released the changes.) We are fairly consistent about having a section of info about prerequisites and what the customer needs to install in order to run the code. The problem I have is that most of them say they can use Python 2.x or Python 3.x, but the info given about Python and the note to put in each article says they can only use 3.6, and not 2.x or 3.7. So the question is how do I figure out the real prerequisites for the articles? @pierrca can you help me figure out what that looks like, and then I can update each article individually ? /cc: @sergaz-msft @philmea
Here's the PR I'm working on: https://github.com/MicrosoftDocs/azure-docs-pr/pull/83207

@robinsh this section of the readme covers the suppoerted configurations:

#pierreca I knew it was being rewritten, but apparently there's a bunch of GitHub issues (and posts on stack overflow) about the problem, so even giving them some advice in the interim is better than leaving our customers high and dry. I'll work on this, and go through one article at a time and make sure the prerequisites match the info provided, and link them to that SDK article for more information. Looking forward to v2!  I'll post the PR back here in case you have  time to check it out before I release it. Is there anybody else who can review it?

@robinsh agreed. 2.7 or 3.6 for windows. just tag me, i'll review the PRs.

@pierreca How 2.7 for windows? Would that be for non-Windows 10 windows? I'm asking because the SDK doc specifically says python 3.6. My concern is that the paragraph "dealing with importerror issues" really only provides more specific prerequisites and the OS versions corresponding with them. And the articles have a separate list of prerequisites. So do I remove the prerequisites from the articles and just point them to the SDK section, or leave them in place and say "if you're having problem, see here" and link to the SDKs? I'm not trying to be difficult here, I'm just trying to make sure it's clear to the customer what they need to do. Here's an article I've added the note to, and you can see the dissonance between the note and the already-present prerequisites package.
https://review.docs.microsoft.com/en-us/azure/iot-hub/iot-hub-python-python-device-management-get-started?branch=pr-en-us-83207

@pierreca I think I've solved this problem. Here's the final PR. If you could take a look and make sure everything looks okay, I'd really appreciate it. OTW I'll sign off on it next week.
https://github.com/MicrosoftDocs/azure-docs-pr/pull/83207

#reassign @robinsh

#please-close


Add correct rpath for dawn samples on linux when using gn build

Dawn Samples missing correct rpath settings on linux platform in
BUILD.gn. This failed program to find .so like libdawn_native on linux.

This patch fix the issue that sample cannot find .so on linux platform.
@Jiawei-Shao @Kangz PTAL, thx!

@Kangz  That's better. Updated the patch and do some rpath clean works too. PTAL.


feature: tighten return types of config helper by using dynamic analysis

This PR should tighten the return types of the config helper to be the actual resolved type at runtime, rather than Repository|mixed.
This should result in proper types being returned, and reducing the number of PossiblyInvalidCast that psalm emits after using the config helper

Going to leave this open while i ponder how types might change depending on environment configuration

note: always add the type of the default value to the return union type


Add build dependencies to README

I can infer the dependencies from the Makefile but having cross-platform instructions would be helpful.

Good idea @beriberikix!
In addition to just documenting the dependencies, do you think it would also be helpful to provide a VSCode dev container that can be easily opened locally and already has all the dependencies installed?

That would be a nice addition! I've never used them personally but they seem cool.

Done!


Add address derivation

Fixes # .
Motivation

Solution

Open questions

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: patrick-ogrady:x: cindyxkuangYou have signed the CLA already but the status is still pending? Let us recheck it.


Feat: Download multiple files as zip

Ref: https://app.asana.com/0/1199082161983365/1199207223388234

@hitenshKharva make the changes suggested by codacy


sbt run quit condition changed with newer sbt versions

steps
//build.sbt
ThisBuild / version := "0.1.0-SNAPSHOT"

ThisBuild / scalaVersion := "2.13.8"

lazy val libs = {
  Seq(
    "com.typesafe.akka"  %% "akka-stream"    % "2.6.18",
  )
}

lazy val root = (project in file("."))
  .settings(
    name := "sbt-run-issue-repro",
    parallelExecution := false,
    libraryDependencies ++= libs
  )

//Main.scala
import akka.actor.ActorSystem
import scala.concurrent.ExecutionContext

object Main extends App {

  implicit val system: ActorSystem                = ActorSystem()
  implicit val executionContext: ExecutionContext = concurrent.ExecutionContext.global

  println("started")
}

sbt run with sbt 1.4.7 and with sbt 1.6.2
With 1.4.7 the console prints "started" and hangs until the actor system stops (never).
With 1.6.2 the console prints "started" and [success] Total time: 2 s, completed 25 Mar 2022, 22:40:02 and terminates.
problem
With 1.4.7 the console prints "started" and hangs until the actor system stops (never).
With 1.6.2 the console prints "started" and [success] Total time: 2 s, completed 25 Mar 2022, 22:40:02 and terminates.
expectation
sbt run works as before

It is not this trivial :( I can't reproduce with minimal example (or in another project yet).
The error I get is;
t="2022-03-25 22:10:52" level=WARN source=o.f.c.i.s.c.JarFileClassPathLocationScanner#41 | Unable to determine jar from url (jar:file:/Users/X/dev/X/target/bg-jobs/sbt_15a33c37/job-1/target/abe6d8d1/b5eb8afa/X_2.13-0.2.0-e0b957f0ea1a3b3dad00ca06aa7e088c6c6dc004-SNAPSHOT.jar!/db/migration): /Users/X/dev/X/target/bg-jobs/sbt_15a33c37/job-1/target/abe6d8d1/b5eb8afa/X_2.13-0.2.0-e0b957f0ea1a3b3dad00ca06aa7e088c6c6dc004-SNAPSHOT.jar (No such file or directory)

At first, it seems like the process tried to access the file after another process deleted it. But this would be really strange... Any idea is appreciated!

I found it, and edited the original report.

Hi @tg44 see #6767

Thx @jtjeferreira , this is a total duplicate, I come from a seemingly totally different angle, and as I started to minimalize the problem I found out that indeed the run is it. I close this in favor of #6767.


Translate Connecting Applications with Services in Bahasa Indonesia

This PR addresses #13929

/assign @irvifa

Sorry, I forget to check first. Let me fix first.

/assign

we can do follow up PR later for the rest (as it's on going discussion and style still being standardized), I'm going to merge this for now
/lgtm
/approve


[android] Fixed menu list remained tappable after dismiss on android

Hi
Fixes https://github.com/enesozturk/react-native-hold-menu/issues/76

@kesha-antonov An idea could be to use animatedProps with pointerEvents :) I believe it can make the fix simpler

Why to keep rendered views underneath and waste device's resources?

Hi, I saw the lib render {children} 2 times like this:

<GestureHandler>

        <Animated.View ref={containerRef} style={containerStyle}>

          {children} => * HERE

        </Animated.View>

      </GestureHandler>

      <Portal key={key} name={key}>

        <Animated.View

          key={key}

          style={portalContainerStyle}

          animatedProps={animatedPortalProps}

        >

          <PortalOverlay />

          {children} => * HERE

        </Animated.View>

      </Portal>

So I think that make performance down to hell from here

You need to address it to main code base, not my PR) I didn't add this logic


Adaptive Learning: Refactor competencies overview view

Refactor competencies overview view to align the design with the other course overview pages (lectures, exercises, etc.)
UI Mockup

I would still prefer that we use small rings in the cards. This design was a hit when we introduced it and I don't understand why you want to move away from it :-(
I think it's really boring to show the progress with a label!


[pkg][analyzer][gardening] Verify docs test is timing out

This test is timing out again.
Previous attempts:

https://github.com/dart-lang/sdk/issues/53229
https://github.com/dart-lang/sdk/issues/52738

cc @bwilkerson @srawlins

I'll approve the failure so we get a signal of any other failures on pkg bots.

Yes. I have a CL out now that will hopefully fix the timeout by increasing the amount of time the test is allowed to run, but we need a better long term solution.
The test is ensuring that example code in our documentation analyzes cleanly. The more documentation we write the longer it takes to find an analyze the examples. We call the test method once per file, so we're only timing out for larger files.
We could investigate parsing the files to find example code and then calling test once per example.
We could also investigate writing shorter files. :-)
Other ideas are welcome.


Add ParsedTokenStream class and use it for expansion

Curious side-effect of this is that it seems like; once you start dealing with the AST directly, you're likely to continue to use and modify the AST. Returning a token stream becomes almost optional. Except for the case where you don't wrap expanders in other expanders.

It also makes me long for a less hacky way to modify the AST in-place. The purpose of macros is to modify the syntax they encounter, so it seems natural to want to modify bits of the AST in more complex (and nested) macros/expanders.

I have yet to test this approach in the texted expanders I have. I worry about having to specify the full path in ->{"* outer inner"}, even when I'm dealing with "inner" macros...

:tada:


add fastapi-utils

Reusable utilities for FastAPI
https://github.com/dmontagu/fastapi-utils

Added to release 2024-04-14.


update docker image tag to v1.2-v2.1.3

moving pinned version to one with permissions fixes for ibmcloud cli plugins
Signed-off-by: Tim Robinson<EMAIL_ADDRESS>

Updated with PR #16


updated sublime-text-dev (3101)

This PR was generated using cask-repair  so the appcast checkpoint should have been updated automagically, however, it appears that the info at the appcast url is no longer in sync with the current version of sublime-text-dev.

Seems like it. Lets see if it continues like so. Would you mind contacting them about it (perhaps something broke in their build automation)?

I got in contact and the appcast.xml was supposedly removed from the build process due to it not being used in ST3 for a long time, however they will be re-adding it back in the next build.

Good news. Thank you or contacting them.


Request: Auto-dismiss outgoing trade messages after X amount of time

What feature would you like added?
Allow outgoing trade message pop-ups to be auto-dismissed after a set amount of time, with the value being editable in the options. This could also apply to incoming trade messages, although I don't see this being as useful.
Why do you want this feature added?
This would allow for the pop-ups for outgoing trade messages that go unanswered within the set amount of time to automatically disappear without having to click the close button. This would keep the amount of space taken up by several pop-ups, which tends to be an issue when sending multiple messages to several sellers within a short amount of time, for example when looking to buy currency, low cost items, etc.

I'll consider this, but I'm not entirely sold on it. One usability issue is that if trade messages are auto closing, the correct message might move around when you go to click on it. I could suspend the closing when you hover the notification frame, but I still think jumping frames might not be great.
The current solution to this problem is the quick close feature. If you right click the close button on an outgoing trade message, it will close all messages except for the one you click on. Admittedly it doesn't help as you spam trade requests, but it does let you quickly clear the screen when receiving a party invite.

You raise a good point regarding usability, although your suggesting of suspending closing when hovering over the notification seems like a suitable solution. Of course, my suggestion was meant to only be an option that can be turned on or off by the user, not something that would be imposed on all users.
In the meantime, while you decide whether to move forward with this suggestion, I'll make use of the right click close feature, which I wasn't aware of.


missing f" for f-string

Hey thank you :) This will also require updating the submodule that autosklearn/autopytorch points to but I'll make sure to do that tomorrow!

👍 I actually got here from AutoPyTorch

Hi, just to let you know that there are currently experiments being made with auto pytorch and keeping things frozen (such as this submodule) makes it easier for those researching. Sorry that there will be a delay with this into auto pytorch.


Update docs: choosing a principal

Principal can be specified by the package path (i.e. including module name). I have not found a description of this feature anywhere.

Thank you. That's indeed a feature.

Yeah, I was surprised when I found this.
Some time ago, I tried to specify the full path to file with principal, which didn't work. I think this should be added to the documentation.

@fredbi what about updating docs on goswagger.io? There are still no changes

Yes you’re correct
We have a clumsy process to update the site.
I’ve been working on a branch to fully automate that part from CI, but couldn’t complet it so far. Thanks for reminding me this overdue task… :)


Unable to enumerate Entry attributes

Attributes on the Entry class are not enumerable - you have to know the attribute names in advance and call GetAttrStringValues() with the exact name of the attribute.
Is there a way to loop over attributes?

Just added an an indexer property for 'entry["cn"]' reads and writes (although this does not currently mesh with MutableEntry change tracking), and implemented IEnumerable on Entry -- please let me know how this works for you.

Works a treat. Thanks for the quick response and code change!


Inform users of default row limit on Query Builder

The Query Builder default outputs return 2500 results. This is not obvious though and may lead users to think that they have returned all of the results for their query, when they actually haven't.
Potential solutions:

Similar to the old Datastore, have an option to choose the 'Sample' or the 'Entire Selection'

Add a message underneath the three format options, along the lines of "Please note that by default, your query will only return 2500 results. If you wish to return more, copy the query URL into your browser and amend the number of rows".

@JoshStanleyDevInit yes as discussed, lets us review the interface as the old Datastore was only CSV Export while new Data Export in new version supports 3 types of formats. And rendering major JSON blobs into the browser is not a good idea. So this needs to be rewired into the UI first. Ok for you @JoshStanleyDevInit ?

@siemvaessen For now I think ti will be sufficient to go with option 2 so that at least users are aware and will not assume that they are getting all results by default. Post launch we can then discuss if it would be worthwhile adding it into the UI.
@sarahshamiso It would be good to get your thoughts on how this should look if indeed we do decide to add it into the UI.
cc/@petyakangalova

@JoshStanleyDevInit Thanks for looping me in! Could you (or @siemvaessen) provide an explanation of why it was decided to limit to 2500 rows? This presents a pretty significant obstacle for users to be able to access the data. At the minimum, it is essential that users have the option to output either 2500 or all. They shouldn't need to take an additional step outside of the QB to be able to access all of the data.

Hi @sarahshamiso that 2500 cap was mainly set for testing purposes. See ^^

Thanks @siemvaessen. Great to know this will be removed before launch. I was confused by the "post-launch" reference above implying that it would still be in place post-launch.

Hi @sarahshamiso the cap will be removed on go live.

@siemvaessen As discussed on yesterday's call, we would like there to be a very clear UX choice for the user to either return a subset, or the entire stream of results. We are happy for this to take the same form as the old DS:

@Karim-1 see design guidance in Fimga @ https://www.figma.com/file/alAYGYogSt4Yv1V7uQXdQ3/IATI-CLOUD-MASTER-DESIGN?node-id=0%3A909

Default = 50

cc/@amy-silcock this ticket is ti manage the change of default rows returned by the QB and the addition of functionality to allow the user to toggle between 'all results' and 'subset of results'


Camera Parameter Estimation Tool

Thanks for the great work.
I wanted to know then when will you open source the parameter estimation tool that is mentioned in README? The approach seems interesting to me.

Thank you for your interest in our project and for the kind words!
I'm pleased to inform you that the camera parameter estimation tool mentioned in the README has already been open-sourced. You can use it with the following command:
python util/estimate_cam_para.py --img demo/demo.jpg --cam_para demo/cam_para_test.txt

In this tool, demo/demo.jpg is a single image drawn from a video sequence with unknown camera parameters. By adjusting parameters like theta_x, theta_y, theta_z, focal, and t_x in the UI window, you can align a virtual ground plane grid with the ground in the image. This process will provide you with an estimation of the camera parameters. While this estimation might not be extremely precise, it is sufficiently accurate for use with UCMCTrack.
Feel free to give it a try and let us know if you have any further questions or feedback!

@corfyi Thanks for the quick response. Can you help me find an UI which you have shown in the readme?  Aslo the cam_para_test.txt are which parameters? Are rhouse dummy params or the parameters of the site after calibration?

Updated Usage Tutorial in README: I've updated the README file with a detailed tutorial on how to use the Camera Parameter Estimation Tool. This should guide you through the process step-by-step, making it easier to understand and implement.

About cam_para_test.txt: The cam_para_test.txt file contains 'dummy parameters' (placeholders or example values) to start with. You'll need to modify one of these parameters initially — specifically, the camera's midpoint. This can be easily determined based on the size of your photo. Once you've adjusted this initial parameter, you can use the UI tool to tweak the other parameters. This process will provide you with a rough estimate of the camera parameters, which will then be saved back into the cam_para_test.txt file.

I hope this helps to clarify your concerns. Please don't hesitate to reach out if you have more questions or need further assistance.


add Dockerfile for building release wheels

Based on ubuntu16 image.

https://github.com/pypa/cibuildwheel


Python: Loops- break

Description :
What is break in python?
Note :

Changes should be made inside the Python/ directory & Python branch.
Issue only for GWOC'21 contributors.
Issue will be assigned on a first come first serve basis, 1 Issue  ==  1 PR.
In the PR, keep this issue's title as your PR's title.

Must Follow : Contributing Guidelines & Code of Conduct before start Contributing.

I would like to work on this please documentation
Peddi sai lohith
Python batch 4

I would like to work on this!!

I would like to work on this issue via documentation. Thank you!!

I would like to work on this!!

Hi I'd like to contribute through documentation on this topic
Harmandeep - python - batch 4

I would like to work on this issue through documentation.
Python Batch 5

I would like to contribute on this issue.

I would like to contribute to this issue via documentation/audio.
Python Batch 3

Please allow me to contribute here. I am ready to contribute via any of the three ways audio/video/documentation.

I would like to contribute on this issue via documentation
Python Batch 6

I would like to work on this issue via documentation.

Hello sir, I  am from batch 6
I would like to work on this issue via documentation.

@adityabisoi
Sir, I would like to contribute to this issue.
Name: Arushi Rautela
Type: Video
Batch: 6

I would like to contribute to this issue via documentation or audio.
Python Batch 3

Audio.

I would like to contribute on this issue.

Sure, go ahead with VIDEO

@kumarankm Is the mentor of this issue. Please reach out to him in case of queries.

Hello,
My self Rahul Kashyap, Python Batch 6
I would like to work on the documentation part.
please assigned me this issue sir.

@adityabisoi  i would like to contribute


AirTouch integration becomes unavailable

No sure if others are getting this issue, but my AirTouch integration becomes unavailable almost daily and requires manual reload.
These are the logs from the latest unavailable event.
Logger: homeassistant.components.climate
Source: components/climate/init.py:367
integration: Climate (documentation, issues)
First occurred: April 17, 2024 at 7:57:04 PM (7 occurrences)
Last logged: 7:13:47 AM
Entity None (<class 'custom_components.airtouch2plus.Airtouch2PlusClimateEntity.Airtouch2PlusClimateEntity'>) does not set ClimateEntityFeature.TURN_OFF but implements the turn_off method. Please create a bug report at https://github.com/nathanvdh/homeassistant-airtouch2/issues
Entity None (<class 'custom_components.airtouch2plus.Airtouch2PlusClimateEntity.Airtouch2PlusClimateEntity'>) does not set ClimateEntityFeature.TURN_ON but implements the turn_on method. Please create a bug report at https://github.com/nathanvdh/homeassistant-airtouch2/issues
Entity None (<class 'custom_components.airtouch2plus.Airtouch2PlusClimateEntity.Airtouch2PlusClimateEntity'>) implements HVACMode(s): off, heat_cool, heat, dry, fan_only, cool and therefore implicitly supports the turn_on/turn_off methods without setting the proper ClimateEntityFeature. Please create a bug report at https://github.com/nathanvdh/homeassistant-airtouch2/issues

Could be related to an issue I fixed a little while ago... I only published a beta release though and forgot to make a stable one. Addressed those logs as well. Try the latest 0.7.9 release.

Sorry Nathan, I think I got lost and posted in the wrong github. This issue is actually for the AirTouch2+ - I currently have 0.2.6 installed.
I shall reopen this issue for the correct integration.

Closed and moved to https://github.com/nathanvdh/homeassistant-airtouch2plus/issues/5


OperationTimedOut after 16 pages are loaded

I'm re-using a Page to navigate several URLs:
foreach ($urls as $url) {
    $page->navigate($url)->waitForNavigation();
    ...
}

The first 16 URLs are loaded alright, but the 17th always ends up with an OperationTimedOut exception:

Operation timed out (30sec)

I tried to close the Page and create a new one, but got the same timeouts. The only solution is to close the Browser and create a new one after 16 pages are visited.

Hello @BenMorel
can you please provide a minimal reproducible code that I can run on my machine. You could just setup an array of urls and loop on it. So that it's quick to setup and I'm sure that we are testing the same thing

Can't reproduce it today. Will reopen if I can reproduce it!


Use GNU MPFR for all transcendental functions

Converting back to draft because I now need this PR to support running with either Musl or MPFR depending on the current block height.


Check if there should be two different atmo gems in the rpm package

It was discovered that there are the following gems present:

vendor/bundle/ruby/2.2.0/bundler/gems/atmosphere-17b1c6fb6d79
ruby/lib/ruby/gems/2.2.0/bundler/gems/atmosphere-4cd29ccab2bc

Is this the desired behaviour?

Even if they are it is ok, because bundler will choose the correct one.


[feature]: Support CPU accelerate by using GGUF

https://huggingface.co/microsoft/Phi-3-mini-4k-instruct-gguf?source=post_page-----7d1fa0b0b623--------------------------------

Hugging Face transformers already support gguf. However, only several model architectures. So, we will do some test first. If it is ok we will suppert CPU accelerate smoothly.

Currently, we support CPU inference accelerate using llama.cpp. However, we will keep working on kimchima repo. We need to implement the CPT and fine-tune in kimchima


Vector Migration changes so far

added male vector migration
added by-gender vector migration
removed regional vector migration
updated param_overrides in regression tests for the new migration naming conventions
updated outputs

todo:
take out GetReacheableNodesByGender and just use ConvertVectorGender+GetReacheableNodes(human gender);
take out m_RawMigrationRatesVectorGende since we only care to keep track of about female migration

Closing this as this code was moved to VectorMigrationChanges2


[TileCatalog]  allow tile catalogs to start off unselected

Summary
Add prop that allows tile catalogs to start off unselected

:tada: This issue has been resolved in version 2.21.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Connect callback

Hi there!
First of all, great work. I find this library really useful. I just want to know how can I get a success of fail callback (or even better, a promise) as a result from calling the connect method.
The README says I should listen to connection status, but the status method is not something that can listened to. It won't fire a callback every time the status changes, it just checks the current status. And I don't see a way to catch the connection errors, e.g. when you connect to an SSID that's not there, or the password was wrong.
Thanks.

Hey, sorry for the the delay. I unfortunately haven't been maintaining this project lately. Have you looked at this (https://github.com/devstepbcn/react-native-android-wifi)? It appears to look very similar to this project but actually provides a status on the attempted connection.

Hi, Thanks for your response. I ended up writing my own library (forked from yours) and I'm actually really happy with my implementation. Feel free to take a look if you want/need: https://github.com/javorosas/react-native-open-wifi.
Your code was really helpful. Thanks.


refactor(card_details): added missing card data fields for connectors

Type of Change

[ ] Bugfix
[ ] New feature
[ ] Enhancement
[x] Refactoring
[ ] Dependency updates
[ ] Documentation
[ ] CI/CD

Description
added missing card data fields for connectors

Additional Changes

[ ] This PR modifies the API contract
[ ] This PR modifies the database schema
[ ] This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

[x] I formatted the code cargo +nightly fmt --all
[x] I addressed lints thrown by cargo clippy
[x] I reviewed the submitted code
[ ] I added unit tests for my changes where possible

Please mention the changes made in the PR description, what connectors were added, and what fields were added? @KiranKBR


[WIP] GZIP Support

Hi @qiyunzhu ,
I have added the functionality for BinaRena to read gzip files. For some reason, the min file of pako.es5 was not being read so ended up using the normal pako.es5 file.
Thank you
Abhinav Chede

Sorry for the delay on this pull request. I have made the requested syntactical changes. Also, I actually did not find any actual documentation regarding how to identify GZIP files in JS. I was looking in StackOverFlow and found out that is how to identify GZIP files.


[ERROR] Unable to download meta file: https://nvd.nist.gov/feeds/json/cve/1.1/nvdcve-1.1-modified.meta

Describe the bug
Currently Using the Owasp Dependency on azure devops ext, and it is throwing this error below.
Version of dependency-check used
6.1.1
Log file
[ERROR] Error retrieving https://nvd.nist.gov/feeds/json/cve/1.1/nvdcve-1.1-modified.meta; received response code 503; Service Unavailable
[ERROR] Error retrieving https://nvd.nist.gov/feeds/json/cve/1.1/nvdcve-1.1-modified.meta; received response code 503; Service Unavailable
[ERROR] Error retrieving https://nvd.nist.gov/feeds/json/cve/1.1/nvdcve-1.1-modified.meta; received response code 503; Service Unavailable
[ERROR] Error retrieving https://nvd.nist.gov/feeds/json/cve/1.1/nvdcve-1.1-modified.meta; received response code 503; Service Unavailable
[ERROR] Unable to download meta file: https://nvd.nist.gov/feeds/json/cve/1.1/nvdcve-1.1-modified.meta
org.owasp.dependencycheck.data.update.exception.UpdateException: Unable to download meta file: https://nvd.nist.gov/feeds/json/cve/1.1/nvdcve-1.1-modified.meta
at org.owasp.dependencycheck.data.update.NvdCveUpdater.doMetaDownload(NvdCveUpdater.java:410)
at org.owasp.dependencycheck.data.update.NvdCveUpdater.getMetaFile(NvdCveUpdater.java:355)
at org.owasp.dependencycheck.data.update.NvdCveUpdater.getUpdatesNeeded(NvdCveUpdater.java:463)
at org.owasp.dependencycheck.data.update.NvdCveUpdater.update(NvdCveUpdater.java:133)
at org.owasp.dependencycheck.Engine.doUpdates(Engine.java:900)
at org.owasp.dependencycheck.Engine.initializeAndUpdateDatabase(Engine.java:705)
at org.owasp.dependencycheck.Engine.analyzeDependencies(Engine.java:631)
at org.owasp.dependencycheck.App.runScan(App.java:259)
at org.owasp.dependencycheck.App.run(App.java:191)
at org.owasp.dependencycheck.App.main(App.java:86)
Caused by: org.owasp.dependencycheck.utils.DownloadFailedException: Download failed, unable to retrieve 'https://nvd.nist.gov/feeds/json/cve/1.1/nvdcve-1.1-modified.meta'; Error downloading file https://nvd.nist.gov/feeds/json/cve/1.1/nvdcve-1.1-modified.meta; unable to connect.
at org.owasp.dependencycheck.utils.Downloader.fetchContent(Downloader.java:187)
at org.owasp.dependencycheck.data.update.NvdCveUpdater.doMetaDownload(NvdCveUpdater.java:381)
... 9 common frames omitted
Caused by: org.owasp.dependencycheck.utils.DownloadFailedException: Error downloading file https://nvd.nist.gov/feeds/json/cve/1.1/nvdcve-1.1-modified.meta; unable to connect.
at org.owasp.dependencycheck.utils.HttpResourceConnection.obtainConnection(HttpResourceConnection.java:267)
at org.owasp.dependencycheck.utils.HttpResourceConnection.fetch(HttpResourceConnection.java:163)
at org.owasp.dependencycheck.utils.Downloader.fetchContent(Downloader.java:182)
... 10 common frames omitted
Caused by: org.owasp.dependencycheck.utils.DownloadFailedException: Error retrieving https://nvd.nist.gov/feeds/json/cve/1.1/nvdcve-1.1-modified.meta; received response code 503; Service Unavailable
at org.owasp.dependencycheck.utils.HttpResourceConnection.obtainConnection(HttpResourceConnection.java:249)
... 12 common frames omitted
[INFO] Skipping RetireJS update since last update was within 24 hours.
[INFO] Skipping Hosted Suppressions file update since last update was within 2 hours.
[INFO] Skipping Known Exploited Vulnerabilities update check since last check was within 24 hours.
[WARN] Unable to update 1 or more Cached Web DataSource, using local data instead. Results may not include recent vulnerabilities.
[ERROR] Unable to continue dependency-check analysis.
[ERROR] One or more fatal errors occurred
[ERROR] Unable to download meta file: https://nvd.nist.gov/feeds/json/cve/1.1/nvdcve-1.1-modified.meta
[ERROR] No documents exist
##[error]Dependency Check exited with an error code (exit code: 13).

After an hour, this issue has been resolved on its own. Any Idea what causes this issue?

We are still encountering the same issue here, which seems to be server status/network related to the nvd.nist.gov.

same here, it's down. Not only feed, but ordinary NIST page seems unavailable, e.g., https://nvd.nist.gov/vuln/detail/CVE-2023-20861
it seems to be location dependent. NIST pages open ok on my phone browser, and also OK when tunnelling to overseas proxy hosts.

Failed to execute goal org.owasp:dependency-check-maven:8.2.1:aggregate
UpdateException: Unable to download meta file: https://nvd.nist.gov/feeds/json/cve/1.1/nvdcve-1.1-modified.meta
caused by DownloadFailedException: Download failed, unable to retrieve 'https://nvd.nist.gov/feeds/json/cve/1.1/nvdcve-1.1-modified.meta'; Error downloading file https://nvd.nist.gov/feeds/json/cve/1.1/nvdcve-1.1-modified.meta; unable to connect.
caused by DownloadFailedException: Error downloading file https://nvd.nist.gov/feeds/json/cve/1.1/nvdcve-1.1-modified.meta; unable to connect.
caused by DownloadFailedException: Error retrieving https://nvd.nist.gov/feeds/json/cve/1.1/nvdcve-1.1-modified.meta; received response code 503; Service Unavailable
NoDataException: No documents exist
[Help 1]

Unfortunately, this issue still exists. The NVD endpoint is unavailable.
[ERROR] Error retrieving https://nvd.nist.gov/feeds/json/cve/1.1/nvdcve-1.1-modified.meta; received response code 503; Service Unavailable
[ERROR] Error retrieving https://nvd.nist.gov/feeds/json/cve/1.1/nvdcve-1.1-modified.meta; received response code 503; Service Unavailable
[ERROR] Error retrieving https://nvd.nist.gov/feeds/json/cve/1.1/nvdcve-1.1-modified.meta; received response code 503; Service Unavailable
[ERROR] Error retrieving https://nvd.nist.gov/feeds/json/cve/1.1/nvdcve-1.1-modified.meta; received response code 503; Service Unavailable
[ERROR] Unable to download meta file: https://nvd.nist.gov/feeds/json/cve/1.1/nvdcve-1.1-modified.meta
org.owasp.dependencycheck.data.update.exception.UpdateException: Unable to download meta file: https://nvd.nist.gov/feeds/json/cve/1.1/nvdcve-1.1-modified.meta
	at org.owasp.dependencycheck.data.update.NvdCveUpdater.doMetaDownload(NvdCveUpdater.java:410)
	at org.owasp.dependencycheck.data.update.NvdCveUpdater.getMetaFile(NvdCveUpdater.java:355)
	at org.owasp.dependencycheck.data.update.NvdCveUpdater.getUpdatesNeeded(NvdCveUpdater.java:463)
	at org.owasp.dependencycheck.data.update.NvdCveUpdater.update(NvdCveUpdater.java:133)
	at org.owasp.dependencycheck.Engine.doUpdates(Engine.java:900)
	at org.owasp.dependencycheck.Engine.initializeAndUpdateDatabase(Engine.java:705)
	at org.owasp.dependencycheck.Engine.analyzeDependencies(Engine.java:631)
	at org.owasp.dependencycheck.App.runScan(App.java:259)
	at org.owasp.dependencycheck.App.run(App.java:191)
	at org.owasp.dependencycheck.App.main(App.java:86)
Caused by: org.owasp.dependencycheck.utils.DownloadFailedException: Download failed, unable to retrieve 'https://nvd.nist.gov/feeds/json/cve/1.1/nvdcve-1.1-modified.meta'; Error downloading file https://nvd.nist.gov/feeds/json/cve/1.1/nvdcve-1.1-modified.meta; unable to connect.
	at org.owasp.dependencycheck.utils.Downloader.fetchContent(Downloader.java:187)
	at org.owasp.dependencycheck.data.update.NvdCveUpdater.doMetaDownload(NvdCveUpdater.java:381)
	... 9 common frames omitted
Caused by: org.owasp.dependencycheck.utils.DownloadFailedException: Error downloading file https://nvd.nist.gov/feeds/json/cve/1.1/nvdcve-1.1-modified.meta; unable to connect.
	at org.owasp.dependencycheck.utils.HttpResourceConnection.obtainConnection(HttpResourceConnection.java:267)
	at org.owasp.dependencycheck.utils.HttpResourceConnection.fetch(HttpResourceConnection.java:163)
	at org.owasp.dependencycheck.utils.Downloader.fetchContent(Downloader.java:182)
	... 10 common frames omitted
Caused by: org.owasp.dependencycheck.utils.DownloadFailedException: Error retrieving https://nvd.nist.gov/feeds/json/cve/1.1/nvdcve-1.1-modified.meta; received response code 503; Service Unavailable
	at org.owasp.dependencycheck.utils.HttpResourceConnection.obtainConnection(HttpResourceConnection.java:249)
	... 12 common frames omitted

Just thinking, is it not possible to cache this file? Mostly the server is down/unreachable only for an hour or so...?

This issue seems to be intermittent, the last time that my pipeline ran is about 45 minutes from now. And now same issue occurred. I guess I'll be temporarily disabling this task on my pipeline to prevent it from stopping.

Just thinking, is it not possible to cache this file? Mostly the server is down/unreachable only for an hour or so...?

An idea, not tested:
You can execute the CLI with the argument --updateonly, so it fetches all definitions. You just zip and place them on a share/artifact-store/internal static web site and point the CLI to ](https://jeremylong.github.io/DependencyCheck/dependency-check-cli/arguments.html)its URL to fetch it from there.
But I'm not sure if the CLI will try to update the data anyway via web.

See https://jeremylong.github.io/DependencyCheck/data/index.html for ideas on how to setup your system so you don't have to rely on the online data sources to be available at all times.

Seems that it returns 503 for datacenter IPs and it works from home. At least that behaviour I see right now.
I can't get anything by curl from Amazon EC2 and Hetzner, but it works like a charm from Telekom.de and Vodafone.de.

Error still here

Seems that it expected behaviour and soon this data source will be shutdown completley: https://nvd.nist.gov/general/news/change-timeline

See #4732. There will be several significant changes to ODC over the next few months. You can create the database on a network were things work - copy the DB file to the server you are scanning on and just run ODC with updates disabled.

Same for me, do you have a quick fix which could help ?

Yep, it got fixed for a second and then stopped working again unfortunately.

It still seems to be handling these errors incorrectly. You get the warning that fetch failed and it will continue with stale data, but then it doesn't continue.

[WARNING] Unable to update 1 or more Cached Web DataSource, using local data instead. Results may not include recent vulnerabilities.
[ERROR] Unable to continue dependency-check analysis.
[ERROR] Fatal exception(s) analyzing CSRF Data Platform

Anybody have a workaround ?

This is the answer that I got about 10 minutes ago:
Good morning,
We are currently aware of site outages and are investigating the root cause. We apologize for the inconvenience.
V/r,
National Vulnerability Database Team
<EMAIL_ADDRESS>

Hi good day,
Do some of you is still having this kind of issue with nvd? Thumbs up will be appreciated so we can close this issue.

All working over here


Dataframe viewer must use the same interpreter as used in kernel

Currently we have code that checks the version of pandas, this is done by checking against the interpreter used to run jupyter.

Validated.


Beacon

Changes / Comments
Beacon sheet update with lots of fixes:
added Morale field for PCs and hirelings
changed skill bonus calculations
changed to hit and damage calculations to use skill instead of class
(major) recoded repeating fields to use getSectionIds, simpler code and and auto updating.
added small weapons (lower encumbrance)
added small/light weapon check for rogue class
removed two handed weapon type
update class starting text, modify class bonuses
add monster/npc sheet mode
clean up unused css
(major) reworked encumbrance and added conditional formatting
moved base attack and damage info to combat tab
set minimum 0 for damage and fatigue selectors
isolated stat and skill bonus calculations on update page
added rogue and hunter bonus to ranged weapons
removed str bonus from light and small weapon damage
fixed some formatting in javascript
Sheet remains compatible with previous version although some calculations have changed
Roll20 Requests

[y] Does the pull request title have the sheet name(s)? Include each sheet name.
[y] Is this a bug fix?
[y] Does this add functional enhancements (new features or extending existing features) ?
[y] Does this add or change functional aesthetics (such as layout or color scheme) ?
[y] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[n/a] If this is a new sheet, did you follow [Building Character Sheets standards]

Character Sheet Info Roll20 Internal Use only.


Fix categories approval field after removing workspace members

Explanation of Change

Fixed Issues

$ https://github.com/Expensify/App/issues/49574
PROPOSAL: https://github.com/Expensify/App/issues/49574#issuecomment-2366740792
Tests

Precondition:

Rules are enabled.
"Add approvals" is enabled in Workflows.
Workspace has at least one member other than yourself.

Go to workspace settings > Categories..
Click on any category.
Click Approver.
Select a member as the approver.
Go to Members.
Remove the member from the workspace.
Go back to the category rule of the category in Step 3.
Ensure that the approval item is cleared

Offline tests

Precondition:

Rules are enabled.
"Add approvals" is enabled in Workflows.
Workspace has at least one member other than yourself.

Go to workspace settings > Categories..
Click on any category.
Click Approver.
Select a member as the approver.
Go to Members and go offline
Remove the member from the workspace.
Go back to the category rule of the category in Step 3.
Ensure that the approval item is cleared

QA Steps

Same as tests
PR Author Checklist

[X] I linked the correct issue in the ### Fixed Issues section above
[X] I wrote clear testing steps that cover the changes made in this PR

[X] I added steps for local testing in the Tests section
[X] I added steps for the expected offline behavior in the Offline steps section
[X] I added steps for Staging and/or Production testing in the QA steps section
[X] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[X] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[X] I included screenshots or videos for tests on all platforms
[X] I ran the tests on all platforms & verified they passed on:

[X] Android: Native
[X] Android: mWeb Chrome
[X] iOS: Native
[X] iOS: mWeb Safari
[X] MacOS: Chrome / Safari
[X] MacOS: Desktop

[X] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[X] I followed proper code patterns (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[X] If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I followed the guidelines as stated in the Review Guidelines
[X] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
[X] I verified that if a function's arguments changed that all usages have also been updated correctly
[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[X] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[X] I verified that all the inputs inside a form are aligned with each other.
[X] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/db43bc4d-3f87-463f-be8b-728afffdead2

Android: mWeb Chrome

https://github.com/user-attachments/assets/387f7209-e5f7-48f3-af78-e2e4ed23b700

iOS: Native

https://github.com/user-attachments/assets/db43bc4d-3f87-463f-be8b-728afffdead2

iOS: mWeb Safari

https://github.com/user-attachments/assets/682c752b-cc41-409a-83a5-2b48eac6df9c

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/a19c665b-67ba-4dca-ab61-3888ba9558e8

MacOS: Desktop
https://github.com/user-attachments/assets/c8ba3aa4-54d9-44d0-a983-1598f17b8828

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@francoisl I see this for production

🤖🔄 android HybridApp 🤖🔄 | failure ❌

and this for staging

🍎🔄 iOS HybridApp 🍎🔄 | failure ❌

Is there anything that anyone is supposed to do when this happens? (iirc failure wasn't common before hybrid was added)

Thanks @francoisl !


Expert mode: Service still highlighted when changing the channel

This is just a minor cosmetic issue.
Expert mode only.
When you listen to a service, for example

and you change the channel (in order to scan another), the previous service is still highlighted

yes, confirmed. Solved with b3580b3


Updated readme, added blurry and fake examples

As suggested in #3, I have added more samples.

Woot, Woot! That looks great! 💯
Thanks for the PR :)


Error: failed to xxxxxxxx : 400 Bad Request: unable to decode response content type ""

Server:  ec2 instance with Ubuntu 20.04
Influxdb version:  2.1.1
Upgraded to Influxdb OSS v2.1.1 from v2.09
Then I installed influx-cli with
wget https://dl.influxdata.com/influxdb/releases/influxdb2-client-2.2.1-amd64.deb
sudo dpkg -i influxdb2-client-2.2.1-amd64.deb
I have a cli config file: ~/.influxdbv2/configs  :
[default]
 url = "http://localhost:8086"
 token = "xxxxxxx=="
 org = "XXXXX"
 active = true
When I use commands
influx
influx version
I get proper replies.
However using commands like
influx bucket list
influx dashboards
influx ping
influx v1 dbrp list
returns
Error: failed to xxxxxxxx : 400 Bad Request: unable to decode response content type ""
.

I'm not able to reproduce this on an Ubuntu 20.04 ec2 instance, using a fresh install of InfluxDB OSS 2.1.1 via the .deb and running it with systemctl.
Are you able to interact with the server using curl? If influx ping results in an error, it would be interesting to see what curl -i http://localhost:8086/ping gets you. If the server is working, you should see something like:
HTTP/1.1 204 No Content
X-Influxdb-Build: OSS
X-Influxdb-Build: oss2
X-Influxdb-Version: 2.1.1
X-Influxdb-Version: 2.1.1
Date: Thu, 23 Dec 2021 19:31:50 GMT

I'm sorry that I'm replying back so late.
Using
curl -i https://localhost:8086/ping command, gives me
curl: (60) SSL certificate problem: self signed certificate error.
As you can see, I'm using self signed certificates.
When I use curl -i -k  https://localhost:8086/ping to supress the error,
I see a proper reply.
HTTP/2 204
x-influxdb-build: OSS
x-influxdb-build: oss2
x-influxdb-version: 2.1.1
x-influxdb-version: 2.1.1

@MachEleven you need to set the flag --host https://localhost:8086 in your active default config you have http:// ...in the URI.
Alternatively you can create a config for the https URI and set this active. However, in most cases I guess you'll need the additional --skip-verify flag when using influx CLI and a self-signed certificate.

I am also seeing the same error message.  I am running influx as a Windows service via nppm and I started seeing this message after I've enabled TLS certificate for HTTPS.
I type influx server-config -t <my-admin-token>, and I get:
influx : Error: failed to retrieve config: 400 Bad Request: unable to decode response content type ""

I run influx ping, and I get:
influx : Error: failed to retrieve config: 400 Bad Request: unable to decode response content type ""

Running influx ping -t <my-admin-token> gives me the same result as above, and running curl -i https://localhost:8086/ping is asking for uri - not sure how to handle this (this is my response after trying out some of the suggestions found in Google).

My issue has been resolved. I had to add -host https://<url> in the influx server-config command.  The use of -http-debug actually allowed me to see the actual helpful error message.